Avoid crash in print_ada_task_info
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-11-22 Tom Tromey <tromey@adacore.com>
2
3 * ada-tasks.c (ada_task_is_alive): Make parameter const.
4 (print_ada_task_info): Don't try to fetch thread id if task is not
5 alive.
6
7 2019-11-22 Christian Biesinger <cbiesinger@google.com>
8
9 * ada-exp.y: Update.
10 * ada-lang.c (sort_choices): Update.
11 (ada_print_symbol_signature): Update.
12 (resolve_subexp): Update.
13 (ada_parse_renaming): Update.
14 (ada_read_renaming_var_value): Update.
15 (lesseq_defined_than): Update.
16 (remove_extra_symbols): Update.
17 (remove_irrelevant_renamings): Update.
18 (ada_add_block_symbols): Update.
19 (ada_collect_symbol_completion_matches): Update.
20 (ada_is_renaming_symbol): Update.
21 (aggregate_assign_from_choices): Update.
22 (ada_evaluate_subexp): Update.
23 (ada_has_this_exception_support): Update.
24 (ada_is_non_standard_exception_sym): Update.
25 (ada_add_exceptions_from_frame): Update.
26 (ada_add_global_exceptions): Update.
27 (ada_print_subexp): Update.
28 * ax-gdb.c (gen_var_ref): Update.
29 (gen_maybe_namespace_elt): Update.
30 (gen_expr_for_cast): Update.
31 (gen_expr): Update.
32 * block.h: Update.
33 * blockframe.c (find_pc_partial_function): Update.
34 * breakpoint.c (print_breakpoint_location): Update.
35 (update_static_tracepoint): Update.
36 * btrace.c (ftrace_print_function_name): Update.
37 (ftrace_function_switched): Update.
38 * buildsym.c (find_symbol_in_list): Update.
39 * c-exp.y: Update.
40 * c-typeprint.c (c_print_typedef): Update.
41 (c_type_print_template_args): Update.
42 * cli/cli-cmds.c (edit_command): Update.
43 (list_command): Update.
44 (print_sal_location): Update.
45 * coffread.c (patch_opaque_types): Update.
46 (process_coff_symbol): Update.
47 (coff_read_enum_type): Update.
48 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
49 (convert_one_symbol): Update.
50 (hash_symname): Update.
51 (eq_symname): Update.
52 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
53 * compile/compile-cplus-types.c (debug_print_scope): Update.
54 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
55 * compile/compile-object-load.c (get_out_value_type): Update.
56 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
57 (search_symbol_list): Update.
58 (cp_lookup_symbol_imports_or_template): Update.
59 * cp-support.c (overload_list_add_symbol): Update.
60 * ctfread.c (psymtab_to_symtab): Update.
61 * dbxread.c (cp_set_block_scope): Update.
62 * dictionary.c (iter_match_first_hashed): Update.
63 (iter_match_next_hashed): Update.
64 (insert_symbol_hashed): Update.
65 (iter_match_next_linear): Update.
66 * dictionary.h: Update.
67 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
68 (locexpr_describe_location_piece): Update.
69 (locexpr_describe_location_1): Update.
70 (locexpr_generate_c_location): Update.
71 (loclist_describe_location): Update.
72 (loclist_generate_c_location): Update.
73 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
74 (read_func_scope): Update.
75 (process_enumeration_scope): Update.
76 (new_symbol): Update.
77 (dwarf2_const_value): Update.
78 (dwarf2_symbol_mark_computed): Update.
79 * eval.c (evaluate_funcall): Update.
80 (evaluate_subexp_standard): Update.
81 * expprint.c (print_subexp_standard): Update.
82 (dump_subexp_body_standard): Update.
83 * f-valprint.c (info_common_command_for_block): Update.
84 * findvar.c (get_hosting_frame): Update.
85 (default_read_var_value): Update.
86 * go-lang.c (go_symbol_package_name): Update.
87 * guile/scm-block.c (bkscm_print_block_smob): Update.
88 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
89 (gdbscm_symbol_name): Update.
90 (gdbscm_symbol_linkage_name): Update.
91 (gdbscm_symbol_print_name): Update.
92 * infcall.c (get_function_name): Update.
93 * infcmd.c (jump_command): Update.
94 (finish_command): Update.
95 * infrun.c (insert_exception_resume_breakpoint): Update.
96 * linespec.c (canonicalize_linespec): Update.
97 (create_sals_line_offset): Update.
98 (convert_linespec_to_sals): Update.
99 (complete_label): Update.
100 (find_label_symbols_in_block): Update.
101 * m2-typeprint.c (m2_print_typedef): Update.
102 * mdebugread.c (mdebug_reg_to_regnum): Update.
103 (parse_symbol): Update.
104 (mylookup_symbol): Update.
105 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
106 (list_args_or_locals): Update.
107 * objc-lang.c (compare_selectors): Update.
108 (info_selectors_command): Update.
109 (compare_classes): Update.
110 (info_classes_command): Update.
111 (find_imps): Update.
112 * p-typeprint.c (pascal_print_typedef): Update.
113 * printcmd.c (build_address_symbolic): Update.
114 (info_address_command): Update.
115 (print_variable_and_value): Update.
116 * python/py-framefilter.c (extract_sym): Update.
117 (py_print_single_arg): Update.
118 * python/py-symbol.c (sympy_str): Update.
119 (sympy_get_name): Update.
120 (sympy_get_linkage_name): Update.
121 * python/python.c (gdbpy_rbreak): Update.
122 * record-btrace.c (btrace_get_bfun_name): Update.
123 (btrace_call_history): Update.
124 * rust-lang.c (rust_print_typedef): Update.
125 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
126 * stabsread.c (stab_reg_to_regnum): Update.
127 (define_symbol): Update.
128 (read_enum_type): Update.
129 (common_block_end): Update.
130 (cleanup_undefined_types_1): Update.
131 (scan_file_globals): Update.
132 * stack.c (print_frame_arg): Update.
133 (print_frame_args): Update.
134 (find_frame_funname): Update.
135 (info_frame_command_core): Update.
136 (iterate_over_block_locals): Update.
137 (print_block_frame_labels): Update.
138 (do_print_variable_and_value): Update.
139 (iterate_over_block_arg_vars): Update.
140 (return_command): Update.
141 * symmisc.c (dump_symtab_1): Update.
142 (print_symbol): Update.
143 * symtab.c (eq_symbol_entry): Update.
144 (symbol_cache_dump): Update.
145 (lookup_language_this): Update.
146 (find_pc_sect_line): Update.
147 (skip_prologue_sal): Update.
148 (symbol_search::compare_search_syms): Update.
149 (treg_matches_sym_type_name): Update.
150 (search_symbols): Update.
151 (print_symbol_info): Update.
152 (rbreak_command): Update.
153 (completion_list_add_symbol): Update.
154 (find_gnu_ifunc): Update.
155 (get_symbol_address): Update.
156 (search_module_symbols): Update.
157 (info_module_subcommand): Update.
158 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
159 (SYMBOL_LINKAGE_NAME): Remove.
160 (SYMBOL_DEMANGLED_NAME): Remove.
161 (SYMBOL_PRINT_NAME): Remove.
162 (SYMBOL_SEARCH_NAME): Remove.
163 * tracepoint.c (set_traceframe_context): Update.
164 (validate_actionline): Update.
165 (collection_list::collect_symbol): Update.
166 (encode_actions_1): Update.
167 (info_scope_command): Update.
168 (print_one_static_tracepoint_marker): Update.
169 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
170 * valops.c (address_of_variable): Update.
171 (find_overload_match): Update.
172 (find_oload_champ): Update.
173
174 2019-11-22 Christian Biesinger <cbiesinger@google.com>
175
176 * ada-lang.c (ada_lookup_simple_minsym): Update.
177 (ada_collect_symbol_completion_matches): Update.
178 * ada-tasks.c (read_atcb): Update.
179 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
180 (amd64_windows_skip_trampoline_code): Update.
181 * arm-tdep.c (skip_prologue_function): Update.
182 (arm_skip_stack_protector): Update.
183 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
184 (arm_wince_skip_main_prologue): Update.
185 * ax-gdb.c (gen_expr): Update.
186 * block.c (call_site_for_pc): Update.
187 * blockframe.c (find_pc_partial_function): Update.
188 * breakpoint.c (set_breakpoint_location_function): Update.
189 * btrace.c (ftrace_print_function_name): Update.
190 (ftrace_function_switched): Update.
191 * c-valprint.c (print_unpacked_pointer): Update.
192 * coffread.c (coff_symfile_read): Update.
193 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
194 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
195 * dwarf-index-write.c (write_psymbols): Update.
196 * dwarf2loc.c (call_site_to_target_addr): Update.
197 (func_verify_no_selftailcall): Update.
198 (tailcall_dump): Update.
199 (call_site_find_chain_1): Update.
200 (dwarf_expr_reg_to_entry_parameter): Update.
201 * elfread.c (elf_gnu_ifunc_record_cache): Update.
202 * eval.c (evaluate_funcall): Update.
203 (evaluate_subexp_standard): Update.
204 (evaluate_subexp_for_sizeof): Update.
205 * expprint.c (print_subexp_standard): Update.
206 (dump_subexp_body_standard): Update.
207 * frame.c (get_prev_frame_always_1): Update.
208 * frv-tdep.c (frv_skip_main_prologue): Update.
209 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
210 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
211 (gnuv3_get_typename_from_type_info): Update.
212 (gnuv3_skip_trampoline): Update.
213 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
214 * i386-tdep.c (i386_skip_main_prologue): Update.
215 (i386_pe_skip_trampoline_code): Update.
216 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
217 * infcall.c (get_function_name): Update.
218 * linespec.c (minsym_found): Update.
219 * linux-fork.c (info_checkpoints_command): Update.
220 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
221 (m32c_m16c_pointer_to_address): Update.
222 * maint.c (maintenance_translate_address): Update.
223 * minsyms.c (add_minsym_to_hash_table): Update.
224 (add_minsym_to_demangled_hash_table): Update.
225 (lookup_minimal_symbol_mangled): Update.
226 (lookup_minimal_symbol_demangled): Update.
227 (lookup_minimal_symbol_linkage): Update.
228 (lookup_minimal_symbol_text): Update.
229 (lookup_minimal_symbol_by_pc_name): Update.
230 (minimal_symbol_is_less_than): Update.
231 (compact_minimal_symbols): Update.
232 (build_minimal_symbol_hash_tables): Update.
233 (find_solib_trampoline_target): Update.
234 * mips-tdep.c (mips_stub_frame_sniffer): Update.
235 (mips_skip_pic_trampoline_code): Update.
236 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
237 * objc-lang.c (info_selectors_command): Update.
238 (info_classes_command): Update.
239 (find_methods): Update.
240 (find_imps): Update.
241 * p-valprint.c (pascal_val_print): Update.
242 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
243 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
244 * printcmd.c (build_address_symbolic): Update.
245 (info_symbol_command): Update.
246 * psymtab.c (psymbol_name_matches): Update.
247 (match_partial_symbol): Update.
248 (lookup_partial_symbol): Update.
249 (print_partial_symbols): Update.
250 (sort_pst_symbols): Update.
251 (maintenance_check_psymtabs): Update.
252 * python/py-framefilter.c (py_print_frame): Update.
253 * python/python.c (gdbpy_rbreak): Update.
254 * record-btrace.c (btrace_get_bfun_name): Update.
255 (btrace_call_history): Update.
256 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
257 (rs6000_skip_trampoline_code): Update.
258 * sol-thread.c (info_cb): Update.
259 * stabsread.c (scan_file_globals): Update.
260 * stack.c (find_frame_funname): Update.
261 (info_frame_command_core): Update.
262 * symmisc.c (dump_msymbols): Update.
263 * symtab.c (symbol_natural_name): Rename to..,
264 (general_symbol_info::natural_name): ...this.
265 (symbol_demangled_name): Rename to...
266 (general_symbol_info::demangled_name): ...this.
267 (symbol_search_name): Rename to...
268 (general_symbol_info::search_name): ...this.
269 (symbol_matches_search_name): Update.
270 (find_pc_sect_line): Update.
271 (skip_prologue_sal): Update.
272 (search_symbols): Update.
273 (print_msymbol_info): Update.
274 (rbreak_command): Update.
275 (completion_list_add_msymbol): Update.
276 (completion_list_objc_symbol): Update.
277 (get_msymbol_address): Update.
278 * symtab.h (struct general_symbol_info): Add member functions
279 natural_name (), linkage_name (), print_name (), demangled_name (),
280 and search_name ().
281 (SYMBOL_NATURAL_NAME): Update.
282 (symbol_natural_name): Move to a member function on general_symbol_info.
283 (SYMBOL_DEMANGLED_NAME): Update.
284 (symbol_demangled_name): Move to a member function on
285 general_symbol_info.
286 (SYMBOL_SEARCH_NAME): Update.
287 (symbol_search_name): Move to a member function on general_symbol_info.
288 (MSYMBOL_NATURAL_NAME): Remove.
289 (MSYMBOL_LINKAGE_NAME): Remove.
290 (MSYMBOL_PRINT_NAME): Remove.
291 (MSYMBOL_DEMANGLED_NAME): Remove.
292 (MSYMBOL_SEARCH_NAME): Remove.
293 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
294
295 2019-11-22 Christian Biesinger <cbiesinger@google.com>
296
297 * symtab.c (create_demangled_names_hash): Use per_bfd->
298 minimal_symbol_count for computing the initial size, if greater
299 than our default size.
300
301 2019-11-22 Tom de Vries <tdevries@suse.de>
302
303 * contrib/words.sh: Improve words extraction.
304
305 2019-11-22 Tom de Vries <tdevries@suse.de>
306
307 * contrib/words.sh: Combine sed invocations.
308
309 2019-11-21 Christian Biesinger <cbiesinger@google.com>
310
311 * Makefile.in: Update.
312 * demangle.c: Rename to...
313 * gdb-demangle.c: ..this.
314 (is_cplus_marker): Change return type to bool.
315 (_initialize_demangler): Rename to...
316 (_initialize_gdb_demangle): ...this.
317 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
318 * symtab.h (demangle): Remove declaration; instead include
319 gdb-demangle.h.
320
321 2019-11-21 Tom Tromey <tromey@adacore.com>
322
323 * gdbsupport/format.c (format_pieces): Parse %I64d.
324 * unittests/format_pieces-selftests.c (test_windows_formats): New
325 function.
326 (run_tests): Call it.
327
328 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
329
330 Byte reverse display of variables with DW_END_big, DW_END_little
331 (DW_AT_endianity) dwarf attributes if different than the native
332 byte order.
333 * ada-lang.c (ada_value_binop):
334 Use type_byte_order instead of gdbarch_byte_order.
335 * ada-valprint.c (printstr):
336 (ada_val_print_string):
337 * ada-lang.c (value_pointer):
338 (ada_value_binop):
339 Use type_byte_order instead of gdbarch_byte_order.
340 * c-lang.c (c_get_string):
341 Use type_byte_order instead of gdbarch_byte_order.
342 * c-valprint.c (c_val_print_array):
343 Use type_byte_order instead of gdbarch_byte_order.
344 * cp-valprint.c (cp_print_class_member):
345 Use type_byte_order instead of gdbarch_byte_order.
346 * dwarf2loc.c (rw_pieced_value):
347 Use type_byte_order instead of gdbarch_byte_order.
348 * dwarf2read.c (read_base_type): Handle DW_END_big,
349 DW_END_little
350 * f-lang.c (f_get_encoding):
351 Use type_byte_order instead of gdbarch_byte_order.
352 * findvar.c (default_read_var_value):
353 Use type_byte_order instead of gdbarch_byte_order.
354 * gdbtypes.c (check_types_equal):
355 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
356 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
357 and TYPE_ENDIANITY_LITTLE if set.
358 (type_byte_order): new function.
359 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
360 (struct main_type) <flag_endianity_not_default>:
361 New field.
362 (type_byte_order): New function.
363 * infcmd.c (default_print_one_register_info):
364 Use type_byte_order instead of gdbarch_byte_order.
365 * p-lang.c (pascal_printstr):
366 Use type_byte_order instead of gdbarch_byte_order.
367 * p-valprint.c (pascal_val_print):
368 Use type_byte_order instead of gdbarch_byte_order.
369 * printcmd.c (print_scalar_formatted):
370 Use type_byte_order instead of gdbarch_byte_order.
371 * solib-darwin.c (darwin_current_sos):
372 Use type_byte_order instead of gdbarch_byte_order.
373 * solib-svr4.c (solib_svr4_r_ldsomap):
374 Use type_byte_order instead of gdbarch_byte_order.
375 * stap-probe.c (stap_modify_semaphore):
376 Use type_byte_order instead of gdbarch_byte_order.
377 * target-float.c (target_float_same_format_p):
378 Use type_byte_order instead of gdbarch_byte_order.
379 * valarith.c (scalar_binop):
380 (value_bit_index):
381 Use type_byte_order instead of gdbarch_byte_order.
382 * valops.c (value_cast):
383 Use type_byte_order instead of gdbarch_byte_order.
384 * valprint.c (generic_emit_char):
385 (generic_printstr):
386 (val_print_string):
387 Use type_byte_order instead of gdbarch_byte_order.
388 * value.c (unpack_long):
389 (unpack_bits_as_long):
390 (unpack_value_bitfield):
391 (modify_field):
392 (pack_long):
393 (pack_unsigned_long):
394 Use type_byte_order instead of gdbarch_byte_order.
395 * findvar.c (unsigned_pointer_to_address):
396 (signed_pointer_to_address):
397 (unsigned_address_to_pointer):
398 (address_to_signed_pointer):
399 (default_read_var_value):
400 (default_value_from_register):
401 Use type_byte_order instead of gdbarch_byte_order.
402 * gnu-v3-abi.c (gnuv3_make_method_ptr):
403 Use type_byte_order instead of gdbarch_byte_order.
404 * riscv-tdep.c (riscv_print_one_register_info):
405 Use type_byte_order instead of gdbarch_byte_order.
406
407 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
408
409 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
410 (current_ui_gdb_stdin_ptr): Likewise.
411 (current_ui_gdb_stderr_ptr): Likewise.
412 (current_ui_gdb_stdlog_ptr): Likewise.
413 (current_ui_current_uiout_ptr): Likewise.
414 (gen_ret_current_ui_field_ptr): Remove.
415
416 2019-11-21 Tom de Vries <tdevries@suse.de>
417
418 PR gdb/24956
419 * cli/cli-script.c (execute_control_command): Only switch to
420 INTERP_CONSOLE's ui_out when INTERP_MI is active.
421
422 2019-11-19 Tom Tromey <tom@tromey.com>
423
424 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
425 Now static. Change type of "name".
426 (tui_set_win_height_command): Don't copy "arg".
427 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
428 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
429
430 2019-11-19 Ali Tamur <tamur@google.com>
431
432 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
433 "if (attr != nullptr)".
434 (dwarf2_find_base_address): Likewise.
435 (dwarf2_build_include_psymtabs): Likewise.
436 (read_cutu_die_from_dwo): Likewise.
437 (read_func_scope): Likewise.
438 (read_call_site_scope): Likewise.
439 (dwarf2_get_pc_bounds): Likewise.
440 (dwarf2_record_block_ranges): Likewise.
441 (dwarf2_add_field): Likewise.
442 (dwarf2_add_member_fn): Likewise.
443 (read_structure_type): Likewise.
444 (read_enumeration_type): Likewise.
445 (read_array_type): Likewise.
446 (read_array_order): Likewise.
447 (read_set_type): Likewise.
448 (read_common_block): Likewise.
449 (read_tag_reference_type): Likewise.
450 (read_tag_string_type): Likewise.
451 (read_subroutine_type): Likewise.
452 (read_base_type): Likewise.
453 (read_subrange_type): Likewise.
454 (new_symbol): Likewise.
455 (prepare_one_comp_unit): Likewise.
456
457 2019-11-19 Tom Tromey <tromey@adacore.com>
458
459 * windows-nat.c (windows_nat_target::attach): Include GetLastError
460 result in error when DebugActiveProcess fails.
461
462 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
463 Pedro Alves <palves@redhat.com>
464
465 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
466 * target.c (target_stack::push): Call 'unpush' if there's a
467 target on top of the stack.
468
469 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
470
471 * python/py-block.c (blpy_dealloc): Call tp_free.
472 (blpy_block_syms_dealloc): Likewise.
473 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
474 * python/py-inferior.c (infpy_dealloc): Likewise.
475 * python/py-lazy-string.c (stpy_dealloc): Likewise.
476 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
477 * python/py-symbol.c (sympy_dealloc): Likewise.
478 * python/py-symtab.c (stpy_dealloc): Likewise.
479 * python/py-type.c (typy_iterator_dealloc): Likewise.
480
481 2019-11-18 Christian Biesinger <cbiesinger@google.com>
482
483 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
484 constructor instead of using a class initializer.
485
486 2019-11-15 Christian Biesinger <cbiesinger@google.com>
487
488 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
489 * configure: Regenerate.
490 * configure.ac: Don't source common.host.
491 * gdbsupport/common.host: Remove.
492 * gdbsupport/mingw-strerror.c: Remove.
493 * gdbsupport/posix-strerror.c: Rename to...
494 * gdbsupport/safe-strerror.c: ...this.
495
496 2019-11-15 Christian Biesinger <cbiesinger@google.com>
497
498 * maint.c (scoped_command_stats::print_time): Use localtime_r
499 instead of localtime (provided through gnulib if necessary).
500 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
501 of ctime.
502
503 2019-11-15 Christian Biesinger <cbiesinger@google.com>
504
505 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
506 avoid compile errors.
507
508 2019-11-15 Christian Biesinger <cbiesinger@google.com>
509
510 * config.in: Regenerate.
511 * configure: Regenerate.
512 * gdbsupport/common.m4: No longer check for strerror_r.
513 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
514 POSIX version of strerror_r, now that gnulib provides it if
515 necessary.
516
517 2019-11-14 Christian Biesinger <cbiesinger@google.com>
518
519 * README (`configure' options): Update.
520
521 2019-11-14 Tom Tromey <tromey@adacore.com>
522
523 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
524 expected type for the RHS if the LHS is a convenience variable.
525
526 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
527
528 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
529 Provide explicit default and copy constructor.
530
531 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
532
533 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
534 only call Py_INCREF (newbp) in the bppy_pending_object case.
535
536 2019-11-13 Tom Tromey <tromey@adacore.com>
537
538 PR build/25182:
539 * psympriv.h (partial_symbol): Remove static assert.
540 * symtab.h (general_symbol_info, symbol): Remove static assert.
541
542 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
543
544 * gdbsupport/format.c (format_pieces::format_pieces): Support
545 printf 'z' size modifier.
546 * gdbsupport/format.h (enum argclass): Add size_t_arg.
547 * printcmd.c (ui_printf): Handle size_t_arg.
548 * ui-out.c (ui_out::vmessage): Likewise.
549 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
550 function.
551 (run_tests): Call test_format_int_sizes.
552
553 2019-11-12 Christian Biesinger <cbiesinger@google.com>
554
555 * ada-exp.y (write_ambiguous_var): Update.
556 * buildsym.c (add_symbol_to_list): Update.
557 * dwarf2read.c (read_variable): Update.
558 (new_symbol): Update.
559 * jit.c (finalize_symtab): Update.
560 * language.c (language_alloc_type_symbol): Update.
561 * symtab.c (fixup_symbol_section): Update.
562 (initialize_objfile_symbol_1): Move code to...
563 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
564 (allocate_symbol): Update.
565 (allocate_template_symbol): Update.
566 (get_symbol_address): Update.
567 * symtab.h (struct symbol): Inherit from general_symbol_info instead
568 of having as a field, and add a constructor.
569 (SYMBOL_VALUE): Update.
570 (SYMBOL_VALUE_ADDRESS): Update.
571 (SET_SYMBOL_VALUE_ADDRESS): Update.
572 (SYMBOL_VALUE_BYTES): Update.
573 (SYMBOL_VALUE_COMMON_BLOCK): Update.
574 (SYMBOL_BLOCK_VALUE): Update.
575 (SYMBOL_VALUE_CHAIN): Update.
576 (SYMBOL_LANGUAGE): Update.
577 (SYMBOL_SECTION): Update.
578 (SYMBOL_OBJ_SECTION): Update.
579 (SYMBOL_SET_LANGUAGE): Update.
580 (SYMBOL_SET_LINKAGE_NAME): Update.
581 (SYMBOL_SET_NAMES): Update.
582 (SYMBOL_NATURAL_NAME): Update.
583 (SYMBOL_LINKAGE_NAME): Update.
584 (SYMBOL_DEMANGLED_NAME): Update.
585 (SYMBOL_SEARCH_NAME): Update.
586 (SYMBOL_MATCHES_SEARCH_NAME): Update.
587 (struct symbol): Update.
588 (struct template_symbol): Update.
589 (struct rust_vtable_symbol): Update.
590 * xcoffread.c (SYMBOL_DUP): Update.
591
592 2019-11-12 Tom Tromey <tom@tromey.com>
593
594 * tui/tui-layout.c (show_layout): Set current_layout.
595 (show_source_disasm_command, show_data)
596 (show_source_or_disasm_and_command): Don't set current_layout.
597
598 2019-11-12 Tom Tromey <tom@tromey.com>
599
600 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
601
602 2019-11-12 Tom Tromey <tom@tromey.com>
603
604 * tui/tui-win.c (resize_message): New global.
605 (show_tui_resize_message): New function.
606 (tui_async_resize_screen): Print message if requested.
607 (_initialize_tui_win): Add tui-resize-message setting.
608 * NEWS: Add entry for new commands.
609
610 2019-11-11 Tom Tromey <tom@tromey.com>
611
612 * tui/tui.c (tui_initialize_readline): Add new bindable readline
613 functions.
614
615 2019-11-11 Christian Biesinger <cbiesinger@google.com>
616
617 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
618
619 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
620
621 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
622 function.
623 * python/python-internal.h (gdbpy_lookup_static_symbols):
624 Declare new function.
625 * python/python.c (python_GdbMethods): Add
626 gdb.lookup_static_symbols method.
627 * NEWS: Mention gdb.lookup_static_symbols.
628
629 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
630
631 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
632 static block of current object file first. Also fix typo in
633 header comment.
634
635 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
636
637 * stack.c (set_last_displayed_sal): Delete.
638 (last_displayed_sal_valid): Delete.
639 (last_displayed_pspace): Delete.
640 (last_displayed_addr): Delete.
641 (last_displayed_symtab): Delete.
642 (last_displayed_line): Delete.
643 (class last_displayed_symtab_info_type): New.
644 (last_displayed_symtab_info): New static global variable.
645 (print_frame_info): Call methods on last_displayed_symtab_info.
646 (clear_last_displayed_sal): Update header comment, and make use of
647 last_displayed_symtab_info.
648 (last_displayed_sal_is_valid): Likewise.
649 (get_last_displayed_pspace): Likewise.
650 (get_last_displayed_addr): Likewise.
651 (get_last_displayed_symtab): Likewise.
652 (get_last_displayed_line): Likewise.
653 (get_last_displayed_sal): Likewise.
654 * stack.h (clear_last_displayed_sal): Update header comment.
655 (last_displayed_sal_is_valid): Likewise.
656 (get_last_displayed_pspace): Likewise.
657 (get_last_displayed_addr): Likewise.
658 (get_last_displayed_symtab): Likewise.
659 (get_last_displayed_line): Likewise.
660 (get_last_displayed_sal): Likewise.
661
662 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
663
664 * stack.c (frame_show_address): Convert return type to bool.
665 * stack.h (frame_show_address): Likewise, and update header
666 comment.
667
668 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
669
670 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
671 * unittests/vec-utils-selftests.c: New file.
672 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
673
674 2019-11-10 Tom Tromey <tom@tromey.com>
675
676 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
677 (tui_highlight_win): Likewise.
678 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
679 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
680 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
681 Don't set can_highlight.
682
683 2019-11-10 Tom Tromey <tom@tromey.com>
684
685 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
686 Remove unused declaration.
687
688 2019-11-08 Tom Tromey <tromey@adacore.com>
689
690 * top.c (read_command_file): Update.
691 (command_line_input): Make return type const.
692 * python/py-gdb-readline.c: Update.
693 * linespec.c (decode_line_2): Update.
694 * defs.h (command_line_input): Make return type const.
695 * cli/cli-script.c (read_next_line): Make return type const.
696 * ada-lang.c (get_selections): Update.
697
698 2019-11-06 Christian Biesinger <cbiesinger@google.com>
699
700 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
701 * mi/mi-main.c (output_cores): Likewise.
702 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
703 (linux_xfer_osdata_modules): Likewise.
704 * remote.c (register_remote_support_xml): Likewise.
705 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
706 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
707
708 2019-11-06 Tom Tromey <tom@tromey.com>
709
710 * tui/tui-interp.c: Don't include readline.h.
711 * tui/tui-hooks.c: Don't include readline.h.
712 * symmisc.c: Include tilde.h, not readline.h.
713 * symfile.c: Include tilde.h, not readline.h.
714 * source.c: Include tilde.h, not readline.h.
715 * solib.c: Include tilde.h, not readline.h.
716 * psymtab.c: Include tilde.h, not readline.h.
717 * exec.c: Include tilde.h, not readline.h.
718 * corelow.c: Include tilde.h, not readline.h.
719 * cli/cli-dump.c: Include tilde.h, not readline.h.
720 * cli/cli-cmds.c: Don't include readline.h.
721
722 2019-11-05 Tom Tromey <tom@tromey.com>
723
724 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
725 (tui_disassemble): Set addr_size.
726 (tui_disasm_window::set_contents): Use addr_size.
727
728 2019-11-05 Tom Tromey <tom@tromey.com>
729
730 * rust-lang.c (rust_language_defn): Update.
731 * python/py-value.c (valpy_string): Call c_get_string.
732 * p-lang.c (pascal_language_defn): Update.
733 * opencl-lang.c (opencl_language_defn): Update.
734 * objc-lang.c (objc_language_defn): Update.
735 * m2-lang.c (m2_language_defn): Update.
736 * language.c (unknown_language_defn, auto_language_defn): Update.
737 (default_get_string): Remove.
738 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
739 * go-lang.c (go_language_defn): Update.
740 * f-lang.c (f_language_defn): Update.
741 * d-lang.c (d_language_defn): Update.
742 * c-lang.c (c_language_defn, cplus_language_defn)
743 (asm_language_defn, minimal_language_defn): Update.
744 * ada-lang.c (ada_language_defn): Update.
745 * language.h (struct language_defn) <la_get_string>: Remove.
746 (LA_GET_STRING): Remove.
747 (default_get_string): Don't declare.
748
749 2019-11-05 Tom Tromey <tom@tromey.com>
750
751 * tui/tui-source.h (struct tui_source_window): Inline
752 constructor. Remove destructor.
753 <style_changed, m_observable>: Move to superclass.
754 * tui/tui-winsource.h (tui_copy_source_line): Declare.
755 (struct tui_source_window_base): Move private members to end.
756 <style_changed, m_observable>: Move from tui_source_window.
757 * tui/tui-winsource.c (tui_copy_source_line): Move from
758 tui-source.c. Rename from copy_source_line. Add special handling
759 for negative line number.
760 (tui_source_window_base::style_changed): Move from
761 tui_source_window.
762 (tui_source_window_base): Register observer.
763 (~tui_source_window_base): New.
764 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
765 rename.
766 (tui_source_window::set_contents): Use tui_copy_source_line.
767 (tui_source_window::tui_source_window): Move to tui-source.h.
768 (tui_source_window::~tui_source_window): Remove.
769 (tui_source_window::style_changed): Move to superclass.
770 * tui/tui-disasm.c (tui_disassemble): Create string file with
771 styling, when possible. Add "addr_size" parameter.
772 (tui_disasm_window::set_contents): Use tui_copy_source_line.
773 Don't compute maximum size.
774 (len_without_escapes): New function
775
776 2019-11-05 Tom Tromey <tom@tromey.com>
777
778 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
779 std::string.
780 * tui/tui-winsource.c (tui_show_source_line): Update.
781 * tui/tui-source.c (tui_source_window::set_contents): Update.
782 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
783
784 2019-11-05 Christian Biesinger <cbiesinger@google.com>
785
786 * symtab.h (gdb_static_assert): Put && operator at the beginning
787 of the line instead of the end.
788
789 2019-11-04 Christian Biesinger <cbiesinger@google.com>
790
791 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
792 and sizeof (symbol).
793 * symtab.h: Add a static_assert for sizeof (partial_symbol).
794
795 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
796
797 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
798 * configure.host: Mark *-*-solaris2.10* obsolete.
799 * configure.tgt: Mark Solaris < 11 obsolete.
800 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
801 Update target triplet.
802
803 2019-11-01 Tom Tromey <tromey@adacore.com>
804
805 * utils.c (print_sys_errmsg): Simplify.
806
807 2019-11-01 Tom Tromey <tromey@adacore.com>
808
809 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
810
811 2019-11-01 Christian Biesinger <cbiesinger@google.com>
812
813 * configure: Regenerate.
814 * configure.ac: Remove check for strerror_r.
815 * gdbsupport/common.m4: Check for strerror_r.
816
817 2019-11-01 Luis Machado <luis.machado@linaro.org>
818
819 PR gdb/25124
820
821 * arm-tdep.c (arm_per_objfile): Rename to ...
822 (arm_per_bfd): ... this.
823 (arm_objfile_data_key): Rename to ...
824 (arm_bfd_data_key): ... this.
825 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
826 data.
827 (arm_record_special_symbol): Likewise.
828
829 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
830
831 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
832 end.
833 * c-typeprint.c (c_print_typedef): Likewise.
834 * f-typeprint.c (f_print_typedef): Likewise.
835 * m2-typeprint.c (m2_print_typedef): Likewise.
836 * p-typeprint.c (pascal_print_typedef): Likewise.
837 * rust-lang.c (rust_print_typedef): Likewise.
838 * symtab.c (print_symbol_info): Print a newline after calling
839 typedef_print.
840
841 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
842
843 * symtab.c (info_module_cmdlist): New variable.
844 (info_module_command): New function.
845 (search_module_symbols): New function.
846 (info_module_subcommand): New function.
847 (struct info_modules_var_func_options): New struct.
848 (info_modules_var_func_options_defs): New variable.
849 (make_info_modules_var_func_options_def_group): New function.
850 (info_module_functions_command): New function.
851 (info_module_variables_command): New function.
852 (info_module_var_func_command_completer): New function.
853 (_initialize_symtab): Register new 'info module functions' and
854 'info module variables' commands.
855 * symtab.h (typedef symbol_search_in_module): New typedef.
856 (search_module_symbols): Declare new function.
857 * NEWS: Mention new commands.
858
859 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
860
861 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
862 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
863 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
864 MODULES_DOMAIN.
865 (scan_partial_symbols): Only create partial module symbols for non
866 declarations.
867 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
868 and MODULES_DOMAIN.
869 * symtab.c (search_domain_name): Likewise.
870 (search_symbols): Likewise.
871 (print_symbol_info): Likewise.
872 (symtab_symbol_info): Likewise.
873 (info_modules_command): New function.
874 (_initialize_symtab): Register 'info modules' command.
875 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
876 * NEWS: Mention new 'info modules' command.
877
878 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
879
880 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
881 and $_gdb_maint_setting_str.
882
883 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
884
885 * cli/cli-cmds.c (setting_cmd, value_from_setting)
886 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
887 (str_value_from_setting, gdb_setting_str_internal_fn)
888 (gdb_maint_setting_str_internal_fn): New functions.
889 (_initialize_cli_cmds): Define the new convenience functions.
890 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
891 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
892
893 2019-10-31 Christian Biesinger <cbiesinger@google.com>
894
895 * agent.c (set_can_use_agent): When the setting is turned on,
896 look up agent symbols if we don't have them yet.
897 (agent_new_objfile): Don't look up agent symbols when the agent
898 setting is off.
899
900 2019-10-31 Christian Biesinger <cbiesinger@google.com>
901
902 * config.in: Regenerate.
903
904 2019-10-31 Christian Biesinger <cbiesinger@google.com>
905
906 * configure: Regenerate.
907 * configure.ac: Check for strerror_r.
908 * gdbsupport/common-utils.h (safe_strerror): Change return value
909 to const char * and document that this function is now threadsafe.
910 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
911 thread_local and call strerror_r, if available.
912 * utils.c (perror_string): Update.
913 (print_sys_errmsg): Update.
914
915 2019-10-31 Luis Machado <luis.machado@linaro.org>
916
917 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
918 objfile_key.
919 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
920 objfile to fetch per-bfd data.
921 (arm_find_exidx_entry): Likewise.
922
923 2019-10-31 Christian Biesinger <cbiesinger@google.com>
924
925 * gdbsupport/agent.c (debug_agent): Change type to bool.
926 (use_agent): Likewise.
927 (all_agent_symbols_look_up): Likewise.
928 (agent_loaded_p): Change return value to bool.
929 (agent_look_up_symbols): Update.
930 (agent_capability_check): Change return value to bool.
931 * gdbsupport/agent.h (agent_loaded_p): Likewise.
932 (debug_agent): Change type to bool.
933 (use_agent): Likewise.
934 (agent_capability_check): Change return value to bool.
935
936 2019-10-30 Christian Biesinger <cbiesinger@google.com>
937
938 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
939 (build_minimal_symbol_hash_tables): Code to clear the table moved
940 to clear_minimal_symbol_hash_tables.
941 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
942 when needed.
943
944 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
945
946 * infcmd.c: Remove includes.
947 * infrun.c: Remove includes.
948
949 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
950
951 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
952 (grow_vect): Remove declaration.
953 (ada_type_of_array): Remove declaration.
954 (ada_update_initial_language): Remove declaration.
955 (ada_fold_name): Remove declaration.
956 (ada_fill_in_ada_prototype): Remove declaration.
957 (user_select_syms): Remove declaration.
958 (get_selections): Remove declaration.
959 (ada_tag_type): Remove declaration.
960 (ada_value_tag): Remove declaration.
961 (ada_is_others_clause): Remove declaration.
962 (ada_in_variant): Remove declaration.
963 (ada_value_struct_elt): Remove declaration.
964 (ada_attribute_name): Remove declaration.
965 (ada_system_address_type): Remove declaration.
966 * ada-lang.c (ada_watch_location_expression): Make static.
967 (GROW_VECT): Move here from ada-lang.h.
968 (grow_vect): Make static.
969 (ada_update_initial_language): Make static.
970 (ada_fold_name): Make static.
971 (ada_type_of_array): Make static.
972 (encoded_ordered_before): Move up.
973 (sort_choices): Move up.
974 (print_signatures): Move up.
975 (ada_print_symbol_signature): Move up.
976 (get_selections): Move up and make static.
977 (user_select_syms): Move up and make static.
978 (ada_value_struct_elt): Move up and make static.
979 (ada_tag_type): Make static.
980 (ada_value_tag): Make static.
981 (ada_is_others_clause): Make static.
982 (ada_in_variant): Make static.
983 (ada_attribute_name): Make static.
984
985 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
986
987 * ada-lang.c: Remove includes.
988 * ada-typeprint.c: Remove includes.
989 * ada-valprint.c: Remove includes.
990
991 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
992
993 * addrmap.c: Add static assertions of type size, moved from
994 _initialize_addrmap.
995 (_initialize_addrmap): Remove.
996
997 2019-10-29 Christian Biesinger <cbiesinger@google.com>
998
999 * coffread.c (record_minimal_symbol): Update.
1000 (process_coff_symbol): Update.
1001 * dbxread.c (read_dbx_symtab): Update.
1002 * dwarf2read.c (add_partial_symbol): Update.
1003 (fixup_go_packaging): Update.
1004 (load_partial_dies): Update.
1005 (new_symbol): Update.
1006 * elfread.c (record_minimal_symbol): Change signature to use
1007 gdb::string_view instead of name+len.
1008 (elf_symtab_read): Update.
1009 (elf_rel_plt_read): Update.
1010 * mdebugread.c (parse_partial_symbols): Update.
1011 (handle_psymbol_enumerators): Update.
1012 (new_symbol): Update.
1013 * minsyms.c (minimal_symbol_reader::record_full): Change signature
1014 to use gdb::string_view instead of name+len.
1015 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1016 * psympriv.h (add_psymbol_to_list): Likewise.
1017 * psymtab.c (add_psymbol_to_bcache): Likewise.
1018 (add_psymbol_to_list): Likewise.
1019 * stabsread.c (define_symbol): Update.
1020 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1021 * symtab.h (SYMBOL_SET_NAMES): Likewise.
1022 (symbol_set_names): Likewise.
1023 * xcoffread.c (scan_xcoff_symtab): Update.
1024
1025 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1026
1027 * symtab.h (symbol_set_names): Document that copy_name must be
1028 set to true for non-nullterminated strings.
1029 * symtab.c (symbol_set_names): Only make a nullterminated copy of
1030 linkage_name if the entry was not found and we need to demangle.
1031
1032 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1033
1034 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1035 * dwarf2-frame.c (bsearch_fde_cmp): Update.
1036 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1037 * gdbsupport/gdb_binary_search.h: New file.
1038
1039 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1040
1041 * NEWS: Mention new --with-system-gdbinit-dir option.
1042 * config.in: Regenerate.
1043 * configure: Regenerate.
1044 * configure.ac: Add new option --with-system-gdbinit-dir.
1045 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1046 for a ".gdb" suffix.
1047 * main.c (get_init_files): Change system_gdbinit argument to
1048 a vector and return the files in SYSTEM_GDBINIT_DIR in
1049 addition to SYSTEM_GDBINIT.
1050 (captured_main_1): Update.
1051 (print_gdb_help): Update.
1052 * top.c (print_gdb_configuration): Also print the value of
1053 SYSTEM_GDBINIT_DIR.
1054
1055 2019-10-28 Christian Biesinger <cbiesinger@google.com>
1056
1057 * gdbsupport/common-utils.h (startswith): Add an overloaded version
1058 that takes gdb::string_view arguments.
1059
1060 2019-10-26 Tom de Vries <tdevries@suse.de>
1061
1062 * aarch64-linux-tdep.c: Fix typos in comments.
1063 * aarch64-tdep.c: Same.
1064 * ada-lang.c: Same.
1065 * amd64-nat.c: Same.
1066 * arc-tdep.c: Same.
1067 * arch/aarch64-insn.c: Same.
1068 * block.c: Same.
1069 * breakpoint.h: Same.
1070 * btrace.h: Same.
1071 * c-varobj.c: Same.
1072 * cli/cli-decode.c: Same.
1073 * cli/cli-script.c: Same.
1074 * cli/cli-utils.h: Same.
1075 * coff-pe-read.c: Same.
1076 * coffread.c: Same.
1077 * compile/compile-cplus-symbols.c: Same.
1078 * compile/compile-object-run.c: Same.
1079 * completer.c: Same.
1080 * corelow.c: Same.
1081 * cp-support.c: Same.
1082 * demangle.c: Same.
1083 * dwarf-index-write.c: Same.
1084 * dwarf2-frame.c: Same.
1085 * dwarf2-frame.h: Same.
1086 * eval.c: Same.
1087 * frame-base.h: Same.
1088 * frame.h: Same.
1089 * gdbcmd.h: Same.
1090 * gdbtypes.h: Same.
1091 * gnu-nat.c: Same.
1092 * guile/scm-objfile.c: Same.
1093 * i386-tdep.c: Same.
1094 * i386-tdep.h: Same.
1095 * infcall.c: Same.
1096 * infcall.h: Same.
1097 * linux-nat.c: Same.
1098 * m68k-tdep.c: Same.
1099 * macroexp.c: Same.
1100 * memattr.c: Same.
1101 * mi/mi-cmd-disas.c: Same.
1102 * mi/mi-getopt.h: Same.
1103 * mi/mi-main.c: Same.
1104 * minsyms.c: Same.
1105 * nat/aarch64-sve-linux-sigcontext.h: Same.
1106 * objfiles.h: Same.
1107 * ppc-linux-nat.c: Same.
1108 * ppc-linux-tdep.c: Same.
1109 * ppc-tdep.h: Same.
1110 * progspace.h: Same.
1111 * prologue-value.h: Same.
1112 * python/py-evtregistry.c: Same.
1113 * python/py-instruction.h: Same.
1114 * record-btrace.c: Same.
1115 * record-full.c: Same.
1116 * remote.c: Same.
1117 * rs6000-tdep.c: Same.
1118 * ser-tcp.c: Same.
1119 * sol-thread.c: Same.
1120 * sparc-sol2-tdep.c: Same.
1121 * sparc64-tdep.c: Same.
1122 * stabsread.c: Same.
1123 * symfile.c: Same.
1124 * symtab.h: Same.
1125 * target.c: Same.
1126 * tracepoint.c: Same.
1127 * tui/tui-data.h: Same.
1128 * tui/tui-io.c: Same.
1129 * tui/tui-win.c: Same.
1130 * tui/tui.c: Same.
1131 * unittests/rsp-low-selftests.c: Same.
1132 * user-regs.h: Same.
1133 * utils.c: Same.
1134 * utils.h: Same.
1135 * valarith.c: Same.
1136 * valops.c: Same.
1137 * valprint.c: Same.
1138 * valprint.h: Same.
1139 * value.c: Same.
1140 * value.h: Same.
1141 * varobj.c: Same.
1142 * x86-nat.h: Same.
1143 * xtensa-tdep.c: Same.
1144
1145 2019-10-25 Ali Tamur <tamur@google.com>
1146
1147 * charset.c (find_charset_names): Reflect API change.
1148
1149 2019-10-25 Christian Biesinger <cbiesinger@google.com>
1150
1151 * symtab.c (struct demangled_name_entry): Change demangled name
1152 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1153 part of the struct anymore.
1154 (symbol_set_names): No longer obstack allocate + copy the demangled
1155 name, just store the allocated name from bfd.
1156
1157 2019-10-25 Tom Tromey <tromey@adacore.com>
1158
1159 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1160 (bsearch_cie_cmp, add_cie): Remove.
1161 (find_cie): Reimplement.
1162 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
1163 (dwarf2_build_frame_info): Update.
1164
1165 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
1166
1167 PR gdb/25126
1168 * symfile.c (reread_symbols): Call forget_cached_source_info to
1169 clear the stale source cache.
1170
1171 2019-10-24 Christian Biesinger <cbiesinger@google.com>
1172
1173 * configure: Regenerate.
1174 * configure.ac: Remove code that sets python_has_threads.
1175
1176 2019-10-24 Christian Biesinger <cbiesinger@google.com>
1177
1178 * config.in: Regenerate.
1179 * configure: Regenerate.
1180 * configure.ac: Remove the code that uses sed to get the python
1181 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1182
1183 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
1184
1185 * python/py-progspace.c (pspy_block_for_pc): Return None for all
1186 error paths.
1187
1188 2019-10-23 Tom Tromey <tom@tromey.com>
1189
1190 * arc-tdep.c: Remove ".." from include.
1191 * frv-tdep.c: Remove ".." from include.
1192 * lm32-tdep.c: Remove ".." from include.
1193 * microblaze-tdep.c: Remove ".." from include.
1194 * or1k-tdep.h: Remove ".." from include.
1195 * s12z-tdep.c: Remove ".." from include.
1196 * Makefile.in (OPCODES_CFLAGS): Add comment.
1197 (TOP_CFLAGS): New variable.
1198 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1199
1200 2019-10-23 Tom Tromey <tom@tromey.com>
1201
1202 * Makefile.in (READLINE_DIR): Update.
1203
1204 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1205
1206 * infcall.c (call_function_by_hand_dummy): Fix the function
1207 comment. And extract out a code section into...
1208 (reserve_stack_space): ...this new function.
1209
1210 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1211
1212 * infcall.c (value_arg_coerce): Remove an unused parameter.
1213 (call_function_by_hand_dummy): Update the call to
1214 'value_arg_coerce'.
1215
1216 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1217
1218 * infcall.c (call_function_by_hand_dummy): Refactor.
1219
1220 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1221
1222 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1223
1224 2019-10-23 Tom Tromey <tom@tromey.com>
1225
1226 * configure: Rebuild.
1227 * configure.ac: Don't check for sigprocmask.
1228 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1229
1230 2019-10-23 Tom Tromey <tom@tromey.com>
1231
1232 * configure: Rebuild.
1233 * acinclude.m4: Use m4_include, not sinclude.
1234
1235 2019-10-23 Tom de Vries <tdevries@suse.de>
1236
1237 PR breakpoints/24687
1238 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1239
1240 2019-10-22 Christian Biesinger <cbiesinger@google.com>
1241
1242 * symtab.c (struct demangled_name_entry) <language>: Change from
1243 bitfield to regular variable.
1244
1245 2019-10-22 Christian Biesinger <cbiesinger@google.com>
1246
1247 * symtab.c (struct demangled_name_entry): Add a constructor.
1248 (free_demangled_name_entry): New function to call the destructor
1249 for demangled_name_entry.
1250 (create_demangled_names_hash): Pass free_demangled_name_entry to
1251 htab_create_alloc.
1252 (symbol_set_names): Call placement new for demangled_name_entry.
1253 * utils.c: No longer include xxhash.h here, now that fast_hash
1254 is inlined in the header.
1255 * utils.h: Instead, include it here.
1256
1257 2019-10-22 Christian Biesinger <cbiesinger@google.com>
1258
1259 * Makefile.in: Link with libxxhash.
1260 * config.in: Regenerate.
1261 * configure: Regenerate.
1262 * configure.ac: Search for libxxhash.
1263 * utils.c (fast_hash): Use xxhash if present.
1264
1265 2019-10-22 Christian Biesinger <cbiesinger@google.com>
1266
1267 * utils.h (fast_hash): New function.
1268 * symtab.c (hash_demangled_name_entry): Call new function
1269 fast_hash.
1270
1271 2019-10-22 Christian Biesinger <cbiesinger@google.com>
1272
1273 * symtab.c (struct demangled_name_entry): Change type of mangled
1274 to gdb::string_view. Also adds a constructor that takes the
1275 mangled name.
1276 (hash_demangled_name_entry): Update.
1277 (eq_demangled_name_entry): Update.
1278 (free_demangled_name_entry): New function to call the destructor
1279 now that this is not a POD anymore.
1280 (create_demangled_names_hash): Pass free_demangled_name_entry to
1281 htab_create_alloc.
1282 (symbol_set_names): Update.
1283
1284 2019-10-21 Ali Tamur <tamu@google.com>
1285
1286 * dwarf2read.c (dir_index): Change type.
1287 (file_name_index): Likewise.
1288 (line_header::include_dir_at): Change comment and implementation on
1289 whether it is DWARF 5.
1290 (line_header::is_valid_file_index): New function.
1291 (line_header::file_name_at): Change comment and implementation on
1292 whether it is DWARF 5.
1293 (line_header::file_names): Change to private field renamed as
1294 m_file_names and introduce a new accessor method.
1295 (line_header::file_names_size): New method.
1296 (line_header::include_dirs): Change to private field and rename as
1297 m_include_dirs.
1298 (dw2_get_file_names_reader): Define local var at a smaller scope and
1299 reflect API change.
1300 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1301 (process_structure_scope): Likewise.
1302 (line_header::add_include_dir): Change message and reflect renaming.
1303 (line_header::add_file_name): Likewise.
1304 (read_formatted_entries): Handle DW_FORM_data16.
1305 (dwarf_decode_line_header): Fix line header length calculation.
1306 (psymtab_include_file_name): Change comment and API.
1307 (lnp_state_machine::m_file): Update comment and reflect type change.
1308 (lnp_state_machine::record_line): Reflect type change.
1309 (dwarf_decode_lines): Reflect API change.
1310 (file_file_name): Likewise.
1311 (file_full_name): Likewise.
1312
1313 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
1314
1315 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1316
1317 2019-10-21 Tom Tromey <tom@tromey.com>
1318
1319 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1320
1321 2019-10-21 Tom Tromey <tom@tromey.com>
1322
1323 * configure.ac (nm.h): Conditionally create nm.h link. Subst
1324 NM_H. Use AC_CONFIG_LINKS.
1325 * configure: Rebuild.
1326 * Makefile.in (NM_H): New variable.
1327 (generated_files): Add NM_H. Remove gcore.
1328 (nm.h, stamp-nmh): New targets.
1329
1330 2019-10-20 Tom Tromey <tom@tromey.com>
1331
1332 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1333 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
1334 obsolete comment.
1335 (put_objfile_before): Now static.
1336
1337 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
1338
1339 * gdbsupport/common-utils.h (startswith): Change return type to
1340 bool.
1341
1342 2019-10-19 Christian Biesinger <cbiesinger@google.com>
1343
1344 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1345 * breakpoint.c (bp_locations_compare): Rename to...
1346 (bp_location_is_less_than): ...this, and change to std::sort semantics.
1347 (update_global_location_list): Use std::sort instead of qsort.
1348 * buildsym.c (compare_line_numbers): Rename to...
1349 (lte_is_less_than): ...this, and change to std::sort semantics.
1350 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1351 instead of qsort.
1352 * disasm.c (compare_lines): Rename to...
1353 (line_is_less_than): ...this, and change to std::sort semantics.
1354 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1355 of qsort.
1356 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1357 (fde_is_less_than): ...this, and change to std::sort semantics.
1358 (dwarf2_build_frame_info): Call std::sort instead of qsort.
1359 * mdebugread.c (compare_blocks):
1360 (block_is_less_than): ...this, and change to std::sort semantics.
1361 (sort_blocks): Call std::sort instead of qsort.
1362 * objfiles.c (qsort_cmp): Rename to...
1363 (sort_cmp): ...this, and change to std::sort semantics.
1364 (update_section_map): Call std::sort instead of qsort.
1365 * remote.c (compare_pnums): Remove.
1366 (map_regcache_remote_table): Call std::sort instead of qsort.
1367 * utils.c (compare_positive_ints): Remove.
1368 * utils.h (compare_positive_ints): Remove.
1369 * xcoffread.c (compare_lte): Remove.
1370 (arrange_linetable): Call std::sort instead of qsort.
1371
1372 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
1373
1374 * symfile.c (init_entry_point_info): Fix typo.
1375 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1376
1377 2019-10-18 Tom de Vries <tdevries@suse.de>
1378
1379 * aarch64-tdep.c: Fix typos in comments.
1380 * ada-lang.c: Same.
1381 * ada-tasks.c: Same.
1382 * alpha-tdep.c: Same.
1383 * alpha-tdep.h: Same.
1384 * amd64-nat.c: Same.
1385 * amd64-windows-tdep.c: Same.
1386 * arc-tdep.c: Same.
1387 * arc-tdep.h: Same.
1388 * arch-utils.c: Same.
1389 * arm-nbsd-tdep.c: Same.
1390 * arm-tdep.c: Same.
1391 * ax-gdb.c: Same.
1392 * blockframe.c: Same.
1393 * btrace.c: Same.
1394 * c-varobj.c: Same.
1395 * coff-pe-read.c: Same.
1396 * coffread.c: Same.
1397 * cris-tdep.c: Same.
1398 * darwin-nat.c: Same.
1399 * dbxread.c: Same.
1400 * dcache.c: Same.
1401 * disasm.c: Same.
1402 * dtrace-probe.c: Same.
1403 * dwarf-index-write.c: Same.
1404 * dwarf2-frame-tailcall.c: Same.
1405 * dwarf2-frame.c: Same.
1406 * dwarf2read.c: Same.
1407 * eval.c: Same.
1408 * exceptions.c: Same.
1409 * fbsd-tdep.c: Same.
1410 * findvar.c: Same.
1411 * frame.c: Same.
1412 * frv-tdep.c: Same.
1413 * gnu-v3-abi.c: Same.
1414 * go32-nat.c: Same.
1415 * h8300-tdep.c: Same.
1416 * hppa-tdep.c: Same.
1417 * i386-linux-tdep.c: Same.
1418 * i386-tdep.c: Same.
1419 * ia64-libunwind-tdep.c: Same.
1420 * ia64-tdep.c: Same.
1421 * infcmd.c: Same.
1422 * infrun.c: Same.
1423 * linespec.c: Same.
1424 * linux-nat.c: Same.
1425 * linux-thread-db.c: Same.
1426 * machoread.c: Same.
1427 * mdebugread.c: Same.
1428 * mep-tdep.c: Same.
1429 * mn10300-tdep.c: Same.
1430 * namespace.c: Same.
1431 * objfiles.c: Same.
1432 * opencl-lang.c: Same.
1433 * or1k-tdep.c: Same.
1434 * osabi.c: Same.
1435 * ppc-linux-nat.c: Same.
1436 * ppc-linux-tdep.c: Same.
1437 * ppc-sysv-tdep.c: Same.
1438 * printcmd.c: Same.
1439 * procfs.c: Same.
1440 * record-btrace.c: Same.
1441 * record-full.c: Same.
1442 * remote-fileio.c: Same.
1443 * remote.c: Same.
1444 * rs6000-tdep.c: Same.
1445 * s12z-tdep.c: Same.
1446 * score-tdep.c: Same.
1447 * ser-base.c: Same.
1448 * ser-go32.c: Same.
1449 * skip.c: Same.
1450 * sol-thread.c: Same.
1451 * solib-svr4.c: Same.
1452 * solib.c: Same.
1453 * source.c: Same.
1454 * sparc-nat.c: Same.
1455 * sparc-sol2-tdep.c: Same.
1456 * sparc-tdep.c: Same.
1457 * sparc64-tdep.c: Same.
1458 * stabsread.c: Same.
1459 * stack.c: Same.
1460 * symfile.c: Same.
1461 * symtab.c: Same.
1462 * target-descriptions.c: Same.
1463 * target-float.c: Same.
1464 * thread.c: Same.
1465 * utils.c: Same.
1466 * valops.c: Same.
1467 * valprint.c: Same.
1468 * value.c: Same.
1469 * varobj.c: Same.
1470 * windows-nat.c: Same.
1471 * xcoffread.c: Same.
1472 * xstormy16-tdep.c: Same.
1473 * xtensa-tdep.c: Same.
1474
1475 2019-10-17 Tom Tromey <tromey@adacore.com>
1476
1477 * configure: Rebuild.
1478 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
1479 in AC_CONFIG_FILES invocation.
1480 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
1481 new-style config.status invocation.
1482
1483 2019-10-17 Tom de Vries <tdevries@suse.de>
1484
1485 * arm-nbsd-nat.c: Fix typos in comments.
1486 * arm-tdep.c: Same.
1487 * darwin-nat-info.c: Same.
1488 * dwarf2read.c: Same.
1489 * elfread.c: Same.
1490 * event-top.c: Same.
1491 * findvar.c: Same.
1492 * gdbtypes.c: Same.
1493 * hppa-tdep.c: Same.
1494 * i386-tdep.c: Same.
1495 * jit.c: Same.
1496 * main.c: Same.
1497 * mdebugread.c: Same.
1498 * moxie-tdep.c: Same.
1499 * nto-procfs.c: Same.
1500 * osabi.c: Same.
1501 * ppc-linux-tdep.c: Same.
1502 * remote.c: Same.
1503 * riscv-tdep.c: Same.
1504 * s390-tdep.c: Same.
1505 * sh-tdep.c: Same.
1506 * sparc-linux-tdep.c: Same.
1507 * sparc-nat.c: Same.
1508 * stack.c: Same.
1509 * target-descriptions.c: Same.
1510 * top.c: Same.
1511 * varobj.c: Same.
1512
1513 2019-10-16 Tom Tromey <tom@tromey.com>
1514
1515 * objfiles.h (struct objfile) <original_name>: Now const.
1516
1517 2019-10-16 Christian Biesinger <cbiesinger@google.com>
1518
1519 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
1520 pass on to sigsetjmp's second argument.
1521 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
1522
1523 2019-10-16 Keith Seitz <keiths@redhat.com>
1524
1525 PR gdb/23567
1526 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
1527 sections whose size is greater than the file size.
1528
1529 2019-10-16 Jim Wilson <jimw@sifive.com>
1530
1531 * riscv-tdep.c (riscv_gcc_target_options): New.
1532 (riscv_gnu_triplet_regexp): New.
1533 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
1534 set_gdbarch_gnu_triplet_regexp.
1535
1536 2019-10-16 Christian Biesinger <cbiesinger@google.com>
1537
1538 * Makefile.in: Add xml-builtin.h.
1539 * features/feature_to_c.sh: Add an include for xml-builtin.h
1540 to ensure that the compiler checks that the types match.
1541 * xml-builtin.h: New file.
1542 * xml-support.c (fetch_xml_builtin): Add missing const.
1543 * xml-support.h: Remove declaration of xml_builtins.
1544
1545 2019-10-16 Tom de Vries <tdevries@suse.de>
1546
1547 PR tdep/25096
1548 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
1549 (amd64_classify_aggregate): ... here.
1550 (amd64_classify_aggregate_field): Handled fiels of nested structs
1551 recursively.
1552
1553 2019-10-16 Tom de Vries <tdevries@suse.de>
1554
1555 PR tdep/24104
1556 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
1557 that handles 'theclass'.
1558
1559 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
1560
1561 * linespec.c (decode_digits_ordinary): Update comment.
1562 * make-target-delegates: No longer need to handle VEC case.
1563 * memrange.c (normalize_mem_ranges): Update comment.
1564 * namespace.c (add_using_directive): Update comment.
1565 * objc-lang.c (uniquify_strings): Update comment.
1566 * ppc-linux-nat.c (struct thread_points): Update comment.
1567 * probe.h (find_probes_in_objfile): Update comment.
1568 * target.h (enum flash_preserve_mode): Update comment.
1569 * varobj.c (varobj_restrict_range): Update comment.
1570 * varobj.h (varobj_list_children): Update comment.
1571
1572 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
1573
1574 * Makefile.in: Remove references to vec.h and vec.c.
1575 * aarch64-tdep.c: No longer include vec.h.
1576 * ada-lang.c: Likewise.
1577 * ada-lang.h: Likewise.
1578 * arm-tdep.c: Likewise.
1579 * ax.h: Likewise.
1580 * breakpoint.h: Likewise.
1581 * charset.c: Likewise.
1582 * cp-support.h: Likewise.
1583 * dtrace-probe.c: Likewise.
1584 * dwarf2read.c: Likewise.
1585 * extension.h: Likewise.
1586 * gdb_bfd.c: Likewise.
1587 * gdbsupport/gdb_vecs.h: Likewise.
1588 * gdbsupport/vec.c: Remove.
1589 * gdbsupport/vec.h: Remove.
1590 * gdbthread.h: Likewise.
1591 * guile/scm-type.c: Likewise.
1592 * inline-frame.c: Likewise.
1593 * machoread.c: Likewise.
1594 * memattr.c: Likewise.
1595 * memrange.h: Likewise.
1596 * namespace.h: Likewise.
1597 * nat/linux-btrace.h: Likewise.
1598 * osdata.c: Likewise.
1599 * parser-defs.h: Likewise.
1600 * progspace.h: Likewise.
1601 * python/py-type.c: Likewise.
1602 * record-btrace.c: Likewise.
1603 * rust-exp.y: Likewise.
1604 * solib-target.c: Likewise.
1605 * stap-probe.c: Likewise.
1606 * target-descriptions.c: Likewise.
1607 * target-memory.c: Likewise.
1608 * target.h: Likewise.
1609 * varobj.c: Likewise.
1610 * varobj.h: Likewise.
1611 * xml-support.h: Likewise.
1612
1613 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
1614
1615 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
1616 Update for new std::vector based implementation.
1617 (process_psymtab_comp_unit_reader): Likewise.
1618 (scan_partial_symbols): Likewise.
1619 (recursively_compute_inclusions): Likewise.
1620 (compute_compunit_symtab_includes): Likewise.
1621 (process_imported_unit_die): Likewise.
1622 (queue_and_load_dwo_tu): Likewise.
1623 (follow_die_sig_1): Likewise.
1624 * gdb/dwarf2read.h: Remove DEF_VEC_P.
1625 (typedef dwarf2_per_cu_ptr): Remove.
1626 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
1627 function.
1628 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
1629 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
1630 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
1631 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
1632 std::vector.
1633
1634 2019-10-15 Tom Tromey <tromey@adacore.com>
1635
1636 * windows-nat.c (windows_nat_target::resume): Use %x when logging
1637 TID.
1638
1639 2019-10-15 Tom Tromey <tromey@adacore.com>
1640
1641 * windows-nat.c (windows_nat_target::fetch_registers)
1642 (windows_nat_target::store_registers): Rename "pid" to "tid".
1643
1644 2019-10-15 Tom Tromey <tromey@adacore.com>
1645
1646 * gdbarch.h, gdbarch.c: Rebuild.
1647 * gdbarch.sh (gcc_target_options): Change return type to
1648 std::string.
1649 * compile/compile.c (get_args): Update.
1650 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
1651 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
1652 std::string.
1653 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
1654 std::string.
1655 * arch-utils.c (default_gcc_target_options): Return std::string.
1656 * arch-utils.h (default_gcc_target_options): Return std::string.
1657 * s390-tdep.c (s390_gcc_target_options): Return std::string.
1658
1659 2019-10-15 Christian Biesinger <cbiesinger@google.com>
1660
1661 * breakpoint.c (breakpoint_chain): Make static.
1662 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
1663 of accessing breakpoint_chain.
1664
1665 2019-10-15 Christian Biesinger <cbiesinger@google.com>
1666
1667 * breakpoint.c (iterate_over_breakpoints): Change function pointer
1668 to a gdb::function_view and return value to bool.
1669 * breakpoint.h (iterate_over_breakpoints): Likewise.
1670 * dummy-frame.c (pop_dummy_frame_bpt): Update.
1671 (pop_dummy_frame): Update.
1672 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
1673 (gdbscm_breakpoints): Update.
1674 * python/py-breakpoint.c (build_bp_list): Update.
1675 (gdbpy_breakpoints): Update.
1676 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
1677 Update.
1678 (bpfinishpy_handle_stop): Update.
1679 (bpfinishpy_handle_exit): Update.
1680 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
1681 (svr4_update_solib_event_breakpoints): Update.
1682
1683 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
1684
1685 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
1686 when unwrapping single-field structs.
1687
1688 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
1689
1690 * dwarf2read.c: Remove includes.
1691
1692 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
1693
1694 * ui-out.c (ui_out::call_do_message): Silence
1695 -Wformat-nonliteral warning.
1696
1697 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
1698
1699 * breakpoint.c: Remove some includes: continuations.h, skip.h,
1700 mi/mi-main.h, readline/readline.h, readline/history.h. Add
1701 include: readline/tilde.h.
1702
1703 2019-10-12 Christian Biesinger <cbiesinger@google.com>
1704
1705 * remote.c (remote_target::get_trace_status): Remove declaration of
1706 trace_regblock_size.
1707
1708 2019-10-12 Christian Biesinger <cbiesinger@google.com>
1709
1710 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
1711 (show_user): Remove declaration of cmdlist.
1712 * cli/cli-cmds.h (max_user_call_depth): Declare.
1713 * cli/cli-script.c (execute_user_command): Remove declaration
1714 of max_user_call_depth.
1715
1716 2019-10-11 Jim Wilson <jimw@sifive.com>
1717
1718 * gdbsupport/print-utils.h (pulongest): Fix comment.
1719 (plongest): Likewise.
1720 (phex): Add missing comment, mention leading zeros.
1721 (phex_nz): Add mention of no leading zeros to comment.
1722
1723 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
1724 plongest instead of unsigned long long cast.
1725
1726 2019-10-10 Christian Biesinger <cbiesinger@google.com>
1727
1728 * main.c (captured_main_1): Include gdbtk.h and remove declarations
1729 for external_editor_command and gdbtk_test.
1730
1731 2019-10-10 Christian Biesinger <cbiesinger@google.com>
1732
1733 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
1734 * varobj.c (varobjdebug): Move comment to...
1735 * varobj.h (varobjdebug): ...here, and declare.
1736
1737 2019-10-09 Tom Tromey <tom@tromey.com>
1738
1739 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
1740 erase_data_content.
1741
1742 2019-10-09 Tom Tromey <tom@tromey.com>
1743
1744 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
1745 * tui/tui-stack.c (tui_locator_window::rerender): Update.
1746 * tui/tui-command.c (tui_cmd_window::resize)
1747 (tui_refresh_cmd_win): Update.
1748 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
1749 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
1750 * tui/tui-data.c (~tui_gen_win_info): Remove.
1751 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1752 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1753 (tui_redisplay_readline, tui_mld_flush)
1754 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
1755 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
1756 (tui_data_window::erase_data_content)
1757 (tui_data_item_window::rerender)
1758 (tui_data_item_window::refresh_window): Update.
1759 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
1760 (box_win, tui_gen_win_info::make_window)
1761 (tui_gen_win_info::make_visible): Update.
1762 (tui_delete_win): Remove.
1763 * tui/tui-winsource.c
1764 (tui_source_window_base::do_erase_source_content): Update.
1765 (tui_show_source_line, tui_source_window_base::update_tab_width)
1766 (tui_source_window_base::update_exec_info): Update.
1767 * tui/tui-data.h (struct curses_deleter): New.
1768 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
1769 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
1770
1771 2019-10-09 Tom Tromey <tom@tromey.com>
1772
1773 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
1774
1775 2019-10-09 Tom Tromey <tom@tromey.com>
1776
1777 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
1778 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
1779
1780 2019-10-09 Tom Tromey <tom@tromey.com>
1781
1782 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
1783 window height directly.
1784 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
1785 declare.
1786 * tui/tui-layout.c (tui_default_win_height): Remove.
1787 (tui_default_win_viewport_height): Remove.
1788
1789 2019-10-09 Tom Tromey <tom@tromey.com>
1790
1791 * tui/tui.h: Remove comments.
1792
1793 2019-10-09 Tom de Vries <tdevries@suse.de>
1794
1795 * python/lib/gdb/printer/bound_registers.py: Use
1796 '^builtin_type_bound128' as regexp argument for
1797 add_builtin_pretty_printer.
1798
1799 2019-10-09 Christian Biesinger <cbiesinger@google.com>
1800
1801 * guile/guile.c (guile_extension_script_ops): Remove forward
1802 declaration and mark as static.
1803 (guile_script_ops): Likewise.
1804 (extension_language_guile): Move further down in the file so
1805 it can reference the definitions for guile_{extension_,}script_ops.
1806
1807 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
1808
1809 * s390-tdep.c (390_process_record): Handle new arch13 instructions
1810 except SORTL, DFLTCC, and KDSA.
1811
1812 2019-10-08 Tom Tromey <tromey@adacore.com>
1813
1814 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
1815 (struct safe_symbol_file_add_args): Remove.
1816
1817 2019-10-08 Tom Tromey <tromey@adacore.com>
1818
1819 * windows-nat.c: Don't include buildsym-legacy.h.
1820
1821 2019-10-08 Tom Tromey <tromey@adacore.com>
1822
1823 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
1824
1825 2019-10-08 Christian Biesinger <cbiesinger@google.com>
1826
1827 * gdbtypes.c (overload_debug): Move comment to header.
1828 * gdbtypes.h (overload_debug): Declare.
1829 * valops.c: Remove declaration of overload_debug, instead
1830 include gdbtypes.h.
1831
1832 2019-10-08 Christian Biesinger <cbiesinger@google.com>
1833
1834 * language.c (show_language_command): Pass lang_frame_mismatch_warn
1835 through _().
1836 (lang_frame_mismatch_warn): Make const, mark with N_(), and
1837 move comment...
1838 * language.h (lang_frame_mismatch_warn): ... here. Also add
1839 declaration.
1840 * top.c (lang_frame_mismatch_warn): Remove declaration.
1841 (check_frame_language_change): Pass lang_frame_mismatch_warn
1842 through _().
1843
1844 2019-10-07 Christian Biesinger <cbiesinger@google.com>
1845
1846 * c-lang.h (vtbl_ptr_name): Declare.
1847 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
1848 it from the header.
1849 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
1850
1851 2019-10-07 Christian Biesinger <cbiesinger@google.com>
1852
1853 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
1854 gdb_static_assert.
1855
1856 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
1857
1858 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
1859 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
1860 * ctfread.c: New file.
1861 * ctfread.h: New file.
1862 * elfread.c: Include ctfread.h.
1863 (struct elfinfo text_p): New member ctfsect.
1864 (elf_locate_sections): Mark CTF section.
1865 (elf_symfile_read): Call elfctf_build_psymtabs.
1866 * Makefile.in (LIBCTF): Add.
1867 (CLIBS): Use it.
1868 (CDEPS): Likewise.
1869 (DIST): Add ctfread.c.
1870
1871 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
1872
1873 * ctfread.c (struct nextfield): Renamed to ...
1874 (struct ctf_nextfield): ... this.
1875 (struct field_info): Renamed to ...
1876 (strut ctf_field_info): ... this.
1877 (attach_fields_to_type): Update for renamed structures.
1878 (ctf_add_member_cb): Likewise.
1879 (ctf_add_enum_member_cb): Likewise.
1880 (process_struct_members): Likewise.
1881 (process_enum_type): Likewise.
1882
1883 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
1884
1885 * tracectf.h: Rename, was ctf.h.
1886 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
1887 * tracefile.c: Likewise.
1888 * tracepoint.c: Remove unused include ctf.h.
1889 * mi/mi-main.c: Likewise.
1890 * Makefile.in Replace ctf.c with tracectf.c.
1891
1892 2019-10-06 Joel Brobecker <brobecker@adacore.com>
1893
1894 * version.in: Change version number to "9.0.50.DATE-git".
1895
1896 2019-10-03 Tom Tromey <tom@tromey.com>
1897
1898 PR rust/24976:
1899 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
1900
1901 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
1902
1903 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
1904 cp_search_name_hash.
1905 * NEWS: Add entry about nested function support.
1906
1907 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
1908 Andrew Burgess <andrew.burgess@embecosm.com>
1909
1910 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
1911 for nested static variables when searchin VAR_DOMAIN.
1912 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
1913 global scope, update comment.
1914 (add_partial_subprogram): Call add_partial_subprogram recursively
1915 for nested subroutines when processinng Fortran.
1916 (load_partial_dies): Process the child entities of a subprogram
1917 when processing Fortran.
1918 (partial_die_parent_scope): Handle building scope
1919 for Fortran nested functions.
1920 (process_die): Record that nested functions have a scope.
1921 (new_symbol): Always record Fortran subprograms on the global
1922 symbol list.
1923 (determine_prefix): How to build the prefix for Fortran
1924 subprograms.
1925
1926 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
1927
1928 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
1929 have just sent the thread a SIGSTOP and are waiting for it to
1930 arrive.
1931
1932 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
1933
1934 * btrace.c (btrace_add_pc): Remove whitespace before the template
1935 parameter in 'std::vector <...>'.
1936 (parse_xml_btrace_block): Likewise.
1937 (btrace_maint_decode_pt): Likewise.
1938 (btrace_maint_update_packets): Likewise.
1939 (btrace_maint_print_packets): Likewise.
1940 * btrace.h (struct btrace_maint_info): Likewise.
1941 * dwarf2read.c (struct type_unit_group): Likewise.
1942 (build_type_psymtabs_reader): Likewise.
1943 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
1944 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
1945 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
1946
1947 2019-10-03 Tom de Vries <tdevries@suse.de>
1948
1949 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
1950 the first line of the help text for set/show style metadata.
1951
1952 2019-10-02 Tom Tromey <tromey@adacore.com>
1953
1954 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
1955 * gdbsupport/common-inferior.c: New file.
1956 * infcmd.c (startup_with_shell): Don't define.
1957 * nat/fork-inferior.h (startup_with_shell): Don't declare.
1958 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
1959 * inferior.h (startup_with_shell): Don't declare.
1960
1961 2019-10-02 Christian Biesinger <cbiesinger@google.com>
1962
1963 * gdbsupport/gdb_assert.h: Include errors.h.
1964 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
1965
1966 2019-10-02 Tom Tromey <tromey@adacore.com>
1967
1968 * NEWS: Add $_ada_exception entry.
1969 * ada-lang.c (struct ada_catchpoint): Add constructor.
1970 <m_kind>: New member.
1971 (allocate_location_exception, re_set_exception): Remove
1972 "ex" parameter.
1973 (should_stop_exception): Compute $_ada_exception.
1974 (check_status_exception, print_it_exception)
1975 (print_one_exception, print_mention_exception): Remove
1976 "ex" parameter.
1977 (allocate_location_catch_exception, re_set_catch_exception)
1978 (check_status_exception, print_it_catch_exception)
1979 (print_one_catch_exception, print_mention_catch_exception)
1980 (print_recreate_catch_exception)
1981 (allocate_location_catch_exception_unhandled)
1982 (re_set_catch_exception_unhandled)
1983 (check_status_exception, print_it_catch_exception_unhandled)
1984 (print_one_catch_exception_unhandled)
1985 (print_mention_catch_exception_unhandled)
1986 (print_recreate_catch_exception_unhandled)
1987 (allocate_location_catch_assert, re_set_catch_assert)
1988 (check_status_assert, print_it_catch_assert)
1989 (print_one_catch_assert, print_mention_catch_assert)
1990 (print_recreate_catch_assert)
1991 (allocate_location_catch_handlers, re_set_catch_handlers)
1992 (check_status_handlers, print_it_catch_handlers)
1993 (print_one_catch_handlers, print_mention_catch_handlers)
1994 (print_recreate_catch_handlers): Remove.
1995 (create_ada_exception_catchpoint): Update.
1996 (initialize_ada_catchpoint_ops): Update.
1997
1998 2019-10-02 Tom Tromey <tromey@adacore.com>
1999
2000 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2001 (create_excep_cond_exprs): Simplify exception string computation.
2002 (ada_exception_catchpoint_cond_string): Likewise.
2003
2004 2019-10-02 Tom Tromey <tromey@adacore.com>
2005
2006 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2007 * ada-lang.c (lesseq_defined_than): Handle
2008 LOC_STATIC.
2009 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2010 parameter.
2011 (dwarf2_has_info): Likewise.
2012 (new_symbol): Set maybe_copied on symbol when
2013 appropriate.
2014 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2015 parameter.
2016 <can_copy>: New member.
2017 * elfread.c (record_minimal_symbol): Set maybe_copied
2018 on symbol when appropriate.
2019 (elf_symfile_read): Update call to dwarf2_has_info.
2020 * minsyms.c (lookup_minimal_symbol_linkage): New
2021 function.
2022 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2023 * symtab.c (get_symbol_address, get_msymbol_address):
2024 New functions.
2025 * symtab.h (get_symbol_address, get_msymbol_address):
2026 Declare.
2027 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2028 maybe_copied.
2029 (struct symbol, struct minimal_symbol) <maybe_copied>:
2030 New member.
2031
2032 2019-10-02 Tom Tromey <tromey@adacore.com>
2033
2034 * source.c (struct current_source_location): New.
2035 (current_source_key): New global.
2036 (current_source_symtab, current_source_line)
2037 (current_source_pspace): Remove.
2038 (get_source_location): New function.
2039 (get_current_source_symtab_and_line)
2040 (set_default_source_symtab_and_line)
2041 (set_current_source_symtab_and_line)
2042 (clear_current_source_symtab_and_line, select_source_symtab)
2043 (info_source_command, print_source_lines_base)
2044 (info_line_command, search_command_helper, _initialize_source):
2045 Update.
2046
2047 2019-10-02 Tom Tromey <tromey@adacore.com>
2048
2049 * source.c (select_source_symtab): Don't call
2050 decode_line_with_current_source.
2051
2052 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2053
2054 * symtab.c (lookup_global_symbol): Search global block.
2055
2056 2019-10-02 Tom Tromey <tromey@adacore.com>
2057
2058 * coffread.c (process_coff_symbol): Update.
2059 * dwarf2read.c (var_decode_location, new_symbol): Update.
2060 * mdebugread.c (parse_symbol): Update.
2061 * objfiles.c (relocate_one_symbol): Update.
2062 * stabsread.c (define_symbol, fix_common_block)
2063 (scan_file_globals): Update.
2064 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2065 (SET_SYMBOL_VALUE_ADDRESS): New macro.
2066 * xcoffread.c (process_xcoff_symbol): Update.
2067
2068 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
2069
2070 * MAINTAINERS: Update my email address.
2071
2072 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2073
2074 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2075 std::vector.
2076 (build_type_psymtabs_reader): Update for std::vector.
2077 (build_type_psymtab_dependencies): Likewise.
2078 * dwarf2read.h: Remove use of DEF_VEC_P.
2079 (typedef sig_type_ptr): Delete.
2080
2081 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2082
2083 * btrace.c (btrace_maint_clear): Update to handle change from VEC
2084 to std::vector.
2085 (btrace_maint_decode_pt): Likewise, and move allocation of the
2086 vector outside of the loop.
2087 (btrace_maint_update_packets): Update to handle change from VEC to
2088 std::vector.
2089 (btrace_maint_print_packets): Likewise.
2090 (maint_info_btrace_cmd): Likewise.
2091 * btrace.h: Remove use of DEF_VEC_O.
2092 (typedef btrace_pt_packet_s): Delete.
2093 (struct btrace_maint_info) <packets>: Change fromm VEC to
2094 std::vector.
2095 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2096
2097 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2098
2099 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2100 make accesses into the vector constant references.
2101 (btrace_add_pc): Update for std::vector.
2102 (btrace_stitch_bts): Likewise.
2103 (parse_xml_btrace_block): Likewise.
2104 (btrace_maint_update_packets): Likewise.
2105 (btrace_maint_print_packets): Likewise.
2106 (maint_info_btrace_cmd): Likewise.
2107 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2108 std::vector.
2109 (btrace_data::empty): Likewise.
2110 (btrace_data_append): Likewise.
2111 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2112 (typedef btrace_block_s): Delete.
2113 (struct btrace_block): Add constructor.
2114 (struct btrace_data_bts) <blocks>: Change to std::vector.
2115 * nat/linux-btrace.c (perf_event_read_bts): Update for
2116 std::vector.
2117 (linux_read_bts): Likewise.
2118
2119 2019-10-01 Tom Tromey <tom@tromey.com>
2120
2121 * cli/cli-logging.c (show_logging_filename): Use styled_string.
2122
2123 2019-10-01 Tom Tromey <tom@tromey.com>
2124
2125 * stack.c (print_frame, info_frame_command_core): Use
2126 styled_string.
2127 * linux-thread-db.c (try_thread_db_load_1)
2128 (try_thread_db_load_from_pdir_1): Use styled_string.
2129 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2130 (auto_load_section_scripts, info_auto_load_local_gdbinit)
2131 (maybe_print_unsupported_script_warning)
2132 (maybe_print_script_not_found_warning): Use styled_string.
2133 * ada-lang.c (user_select_syms): Use styled_string.
2134
2135 2019-10-01 Tom Tromey <tom@tromey.com>
2136
2137 * p-lang.c (pascal_printstr): Use metadata style.
2138 * value.c (show_convenience): Use metadata style.
2139 * valprint.c (valprint_check_validity, val_print_optimized_out)
2140 (val_print_not_saved, val_print_unavailable)
2141 (val_print_invalid_address, generic_val_print, val_print)
2142 (value_check_printable, val_print_array_elements): Use metadata
2143 style.
2144 * ui-out.h (class ui_out) <field_fmt>: New overload.
2145 <do_field_fmt>: Add style parameter.
2146 * ui-out.c (ui_out::field_fmt): New overload.
2147 * typeprint.c (type_print_unknown_return_type)
2148 (val_print_not_allocated, val_print_not_associated): Use metadata
2149 style.
2150 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2151 parameter.
2152 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2153 * tracepoint.c (tvariables_info_1): Use metadata style.
2154 * stack.c (print_frame_arg, print_frame_info, print_frame)
2155 (info_frame_command_core): Use metadata style.
2156 * skip.c (info_skip_command): Use metadata style.
2157 * rust-lang.c (rust_print_enum): Use metadata style.
2158 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2159 metadata style.
2160 * python/py-framefilter.c (py_print_single_arg): Use metadata
2161 style.
2162 * printcmd.c (do_one_display, print_variable_and_value): Use
2163 metadata style.
2164 * p-valprint.c (pascal_val_print)
2165 (pascal_object_print_value_fields): Use metadata style.
2166 * p-typeprint.c (pascal_type_print_base): Use metadata style.
2167 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2168 parameter.
2169 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2170 * m2-valprint.c (m2_print_long_set): Use metadata style.
2171 * m2-typeprint.c (m2_print_type): Use metadata style.
2172 * infcmd.c (print_return_value_1): Use metadata style.
2173 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2174 * f-valprint.c (info_common_command_for_block): Use metadata
2175 style.
2176 * f-typeprint.c (f_type_print_base): Use metadata style.
2177 * expprint.c (print_subexp_standard): Use metadata style.
2178 * cp-valprint.c (cp_print_value_fields): Use metadata style.
2179 * cli/cli-style.h (class cli_style_option): Add constructor.
2180 (metadata_style): Declare.
2181 * cli/cli-style.c (metadata_style): New global.
2182 (_initialize_cli_style): Register metadata style.
2183 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2184 parameter.
2185 * cli-out.c (cli_ui_out::do_field_fmt): Update.
2186 * c-typeprint.c (c_type_print_base_struct_union)
2187 (c_type_print_base_1): Use metadata style.
2188 * breakpoint.c (watchpoint_value_print)
2189 (print_one_breakpoint_location): Use metadata style.
2190 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2191 style.
2192 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2193 style.
2194 * ada-valprint.c (val_print_packed_array_elements, printstr)
2195 (print_field_values, ada_val_print_ref, ada_val_print): Use
2196 metadata style.
2197 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2198 style.
2199 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2200 style.
2201 * ada-lang.c (user_select_syms): Use metadata style.
2202
2203 2019-10-01 Tom Tromey <tom@tromey.com>
2204
2205 * cli/cli-cmds.c (pwd_command): Style output.
2206
2207 2019-10-01 Pedro Alves <palves@redhat.com>
2208 Tom Tromey <tom@tromey.com>
2209
2210 * symtab.c (print_symbol_info): Use %ps.
2211 (print_msymbol_info): Use %ps.
2212 * symfile.c (symbol_file_add_with_addrs): Use %ps.
2213 * printcmd.c (print_variable_and_value): Use %ps.
2214 * macrocmd.c (show_pp_source_pos): Use %ps.
2215 * infrun.c (print_exited_reason): Use ui_out::message.
2216 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2217 (describe_other_breakpoints): Use ui_out::message and new
2218 formats.
2219 (say_where): Use new formats.
2220 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2221 and new formats.
2222
2223 2019-10-01 Pedro Alves <palves@redhat.com>
2224 Tom Tromey <tom@tromey.com>
2225
2226 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2227 (test_gdb_formats): New function.
2228 (run_tests): Call it.
2229 (test_format_specifier): Update.
2230 * utils.h (fputs_filtered): Update comment.
2231 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2232 (fputs_styled_unfiltered): Declare.
2233 * utils.c (fputs_styled_unfiltered): New function.
2234 (vfprintf_maybe_filtered): Add gdbfmt parameter.
2235 (vfprintf_filtered): Update.
2236 (vfprintf_unfiltered, vprintf_filtered): Update.
2237 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2238 * ui-out.h (enum ui_out_flag) <unfiltered_output,
2239 disallow_ui_out_field>: New constants.
2240 (enum class field_kind): New.
2241 (struct base_field_s, struct signed_field_s): New.
2242 (signed_field): New function.
2243 (struct string_field_s): New.
2244 (string_field): New function.
2245 (struct styled_string_s): New.
2246 (styled_string): New function.
2247 (class ui_out) <message>: Add comment.
2248 <vmessage, call_do_message>: New methods.
2249 <do_message>: Add style parameter.
2250 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2251 methods.
2252 (ui_out::message): Rewrite.
2253 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2254 parameter.
2255 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2256 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2257 gdb_extensions parameter.
2258 (class format_piece): Add parameter to constructor.
2259 (n_int_args): New field.
2260 * gdbsupport/format.c (format_pieces::format_pieces): Add
2261 gdb_extensions parameter. Handle '*'.
2262 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2263 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
2264 vfprintf_styled_no_gdbfmt.
2265 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2266 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2267 unfiltered output.
2268 * ui-style.h (struct ui_file_style) <ptr>: New method.
2269
2270 2019-10-01 Tom Tromey <tom@tromey.com>
2271
2272 * unittests/format_pieces-selftests.c: Update. Add final format.
2273 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2274 empty literal pieces.
2275
2276 2019-10-01 Tom Tromey <tom@tromey.com>
2277
2278 * ui-out.h (enum class ui_out_style_kind): Remove.
2279 (class ui_out) <field_string, field_stsream, do_field_string>:
2280 Change type of "style".
2281 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2282 (ui_out::field_string): Update.
2283 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2284 of "style".
2285 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2286 * tracepoint.c (print_one_static_tracepoint_marker): Update.
2287 * stack.c (print_frame_arg, print_frame_info, print_frame):
2288 Update.
2289 * source.c (print_source_lines_base): Update.
2290 * solib.c (info_sharedlibrary_command): Update.
2291 * skip.c (info_skip_command): Update.
2292 * record-btrace.c (btrace_call_history_src_line)
2293 (btrace_call_history): Update.
2294 * python/py-framefilter.c (py_print_frame): Update.
2295 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2296 "style".
2297 * mi/mi-out.c (mi_ui_out::do_table_header)
2298 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2299 (mi_ui_out::do_field_string): Update.
2300 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2301 Update.
2302 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2303 "style".
2304 * cli-out.c (cli_ui_out::do_table_header)
2305 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2306 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2307 (cli_ui_out::do_field_fmt): Update.
2308 * breakpoint.c (print_breakpoint_location): Update.
2309 (update_static_tracepoint): Update.
2310
2311 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2312
2313 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2314 conversion of gdb_datadir.
2315 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2316 remove not needed c_str ().
2317
2318 2019-09-30 Ali Tamur <tamur@google.com>
2319
2320 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2321 (dwarf2_string_attr): Likewise.
2322
2323 2019-09-30 Ali Tamur <tamur@google.com>
2324
2325 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2326 (process_full_type_unit): Likewise.
2327 (dump_die_shallow): Likewise.
2328 (cu_debug_loc_section): Likewise.
2329
2330 2019-09-28 Christian Biesinger <cbiesinger@google.com>
2331
2332 * minsyms.c (compare_minimal_symbols): Rename to...
2333 (minimal_symbol_is_less_than): ...this, and adjust to STL
2334 conventions (return bool, take arguments as references)
2335 (minimal_symbol_reader::install): Call std::sort instead
2336 of qsort.
2337
2338 2019-09-29 Christian Biesinger <cbiesinger@google.com>
2339
2340 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2341 hash and why.
2342 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2343 msymbol_hash, msymbol_demangled_hash>: Improve comments.
2344
2345 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
2346
2347 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2348 * psympriv.h (add_psymbol_to_list): Move comment here and update
2349 it.
2350
2351 2019-09-29 Tom de Vries <tdevries@suse.de>
2352
2353 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2354 Use $tmpdir/$(basename "$output_file").dwz instead of
2355 "${output_file}.dwz".
2356
2357 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
2358
2359 PR gdb/25045
2360 * hppa-linux-nat.c: Include gdbarch.h.
2361
2362 2019-09-26 Christian Biesinger <cbiesinger@google.com>
2363
2364 * blockframe.c (find_pc_partial_function): Change return type to bool.
2365 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2366 * minsyms.c (in_gnu_ifunc_stub): Likewise.
2367 (stub_gnu_ifunc_resolve_name): Likewise.
2368 * symtab.c (compare_filenames_for_search): Likewise.
2369 (compare_glob_filenames_for_search): Likewise.
2370 (matching_obj_sections): Likewise.
2371 (symbol_matches_domain): Likewise.
2372 (find_line_symtab): Change out param EXACT_MATCH to bool *.
2373 (find_line_pc): Change return type to bool.
2374 (find_line_pc_range): Likewise.
2375 (producer_is_realview): Likewise.
2376 * symtab.h (symbol_matches_domain): Likewise.
2377 (find_pc_partial_function): Likewise.
2378 (find_pc_line_pc_range): Likewise.
2379 (in_gnu_ifunc_stub): Likewise.
2380 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2381 (find_line_pc): Likewise.
2382 (find_line_pc_range): Likewise.
2383 (matching_obj_sections): Likewise.
2384 (find_line_symtab): Change out parameter to bool.
2385 (producer_is_realview): Change return type to bool.
2386 (compare_filenames_for_search): Likewise.
2387 (compare_glob_filenames_for_search): Likewise.
2388
2389 2019-09-26 Tom Tromey <tom@tromey.com>
2390
2391 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2392 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2393 * gdb_usleep.h: Remove.
2394 * gdb_usleep.c: Remove.
2395 * utils.c: Don't include gdb_usleep.h.
2396
2397 2019-09-26 Tom Tromey <tromey@adacore.com>
2398
2399 * python/py-type.c (type_to_type_object): Call check_typedef
2400 for stub types.
2401
2402 2019-09-26 Tom Tromey <tom@tromey.com>
2403
2404 * utils.h (initialize_utils): Don't declare.
2405 * top.c (gdb_init): Don't call initialize_utils.
2406 * utils.c (initialize_utils): Remove. Move contents...
2407 (_initialize_utils): ... here.
2408
2409 2019-09-25 Tom Tromey <tom@tromey.com>
2410
2411 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
2412 * utils.h (make_hex_string): Don't declare.
2413 * utils.c (make_hex_string): Remove.
2414
2415 2019-09-24 Tom de Vries <tdevries@suse.de>
2416
2417 PR gdb/23815
2418 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
2419 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
2420
2421 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
2422
2423 * NEWS: Mention new simulator port for PRU.
2424
2425 2019-09-23 Christian Biesinger <cbiesinger@google.com>
2426
2427 * ada-exp.y (write_object_remaining): Update.
2428 * ada-lang.c (ada_decode): Return a std::string instead of a char*
2429 and eliminate the static buffer.
2430 (ada_decode_symbol): Update.
2431 (ada_la_decode): Update.
2432 (ada_sniff_from_mangled_name): Update.
2433 (is_valid_name_for_wild_match): Update.
2434 (ada_lookup_name_info::matches): Update and simplify.
2435 (name_matches_regex): Update.
2436 (ada_add_global_exceptions): Update.
2437 * ada-lang.h (ada_decode): Update signature.
2438 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
2439 * dwarf-index-write.c (debug_names::insert): Update.
2440
2441 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
2442
2443 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
2444 formatting.
2445
2446 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
2447
2448 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
2449 Change "nonzero" to "true" in documentation.
2450
2451 2019-09-20 Christian Biesinger <cbiesinger@google.com>
2452
2453 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
2454 (_initialize_darwin_solib): Don't set
2455 darwin_so_ops.lookup_lib_global_symbol.
2456 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
2457 set_gdbarch_iterate_over_objfiles_in_search_order.
2458 (elf_lookup_lib_symbol): Rename to...
2459 (svr4_iterate_over_objfiles_in_search_order): this, and update
2460 to iterate semantics.
2461 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
2462 * solib.c (solib_global_lookup): Remove.
2463 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
2464 (solib_global_lookup): Remove.
2465 * symtab.c (lookup_global_or_static_symbol): Remove call to
2466 solib_global_lookup.
2467
2468 2019-09-20 Joel Brobecker <brobecker@adacore.com>
2469
2470 * NEWS: Move entries about default MI version now being
2471 version 3, and about the GDB/MI fix for multi-location
2472 breakpoints to the "since GDB 8.3" section.
2473
2474 2019-09-20 Joel Brobecker <brobecker@adacore.com>
2475
2476 GDB 8.3.1 released.
2477
2478 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
2479
2480 * NEWS: Mention that Cell/B.E. debugging support was removed.
2481 * MAINTAINERS: Remove spu target.
2482
2483 * config/djgpp/fnchange.lst: Remove entries for removed files.
2484
2485 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
2486 spu-multiarch.o, and spu-tdep.o.
2487 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
2488 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
2489 spu-multiarch.c, and spu-tdep.c.
2490 * spu-linux-nat.c: Remove file.
2491 * spu-multiarch.c: Remove file.
2492 * spu-tdep.c: Remove file.
2493 * spu-tdep.h: Remove file.
2494 * solib-spu.c: Remove file.
2495 * solib-spu.h: Remove file.
2496
2497 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
2498 * configure.nat (spu-linux): Remove.
2499 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
2500 solib-multiarch.o from gdb_target_obs.
2501 (spu*-*-*): Remove.
2502
2503 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
2504 feature flag.
2505 (ppc_linux_no_features): Update.
2506 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
2507 Cell/B.E. support.
2508 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
2509 (tdesc_powerpc_cell64l): Likewise.
2510 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
2511 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
2512 Cell/B.E. support.
2513 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
2514 Do not include "features/rs6000/powerpc-cell32l.c" or
2515 "features/rs6000/powerpc-cell64l.c".
2516 (ppc_linux_spu_section): Remove.
2517 (ppc_linux_core_read_description): Remove Cell/B.E. support.
2518 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
2519 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
2520 (ppc_linux_spe_context_lookup): Remove.
2521 (ppc_linux_spe_context_inferior_created): Remove.
2522 (ppc_linux_spe_context_solib_loaded): Remove.
2523 (ppc_linux_spe_context_solib_unloaded): Remove.
2524 (ppc_linux_spe_context): Remove.
2525 (struct ppu2spu_cache): Remove.
2526 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
2527 (struct ppu2spu_data): Remove.
2528 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
2529 ppu2spu_unwind): Remove.
2530 (ppc_linux_init_abi): Remove Cell/B.E. support.
2531 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
2532
2533 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
2534 (rs6000/powerpc-cell64l-expedite): Likewise
2535 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
2536 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
2537 rs6000/powerpc-cell64l.xml.
2538 * features/rs6000/powerpc-cell32l.xml: Remove.
2539 * features/rs6000/powerpc-cell64l.xml: Likewise.
2540 * features/rs6000/powerpc-cell32l.c: Remove generated file.
2541 * features/rs6000/powerpc-cell64l.c: Likewise.
2542 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
2543 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
2544 * regformats/reg-spu.dat: Remove.
2545
2546 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
2547 * corelow.c (struct spuid_list): Remove.
2548 (add_to_spuid_list): Remove.
2549 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2550 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
2551 (remote_protocol_features): Remove associated entries.
2552 (_initialize_remote): No longer initialize them.
2553 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2554 * linux-nat.c (SPUFS_MAGIC): Remove.
2555 (linux_proc_xfer_spu): Remove.
2556 (spu_enumerate_spu_ids): Remove.
2557 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
2558 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
2559 (linux_make_corefile_notes): No longer call it.
2560
2561 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
2562 (cooked_write_test): Likewise.
2563
2564 2019-09-20 Tom Tromey <tom@tromey.com>
2565
2566 * NEWS: Mention case-sensitivity of TUI commands.
2567 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
2568 (tui_set_win_height_command, parse_scrolling_args): Likewise.
2569 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
2570
2571 2019-09-20 Tom Tromey <tom@tromey.com>
2572
2573 * tui/tui-source.c (tui_source_window::set_contents): Use
2574 make_unique_xstrdup.
2575 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
2576 make_unique_xstrdup.
2577
2578 2019-09-20 Tom Tromey <tom@tromey.com>
2579
2580 * tui/tui-data.c: Remove separator comments.
2581 * tui/tui-layout.c: Remove separator comments.
2582 * tui/tui-win.c: Remove separator comments.
2583 * tui/tui-wingeneral.c: Remove separator comments.
2584
2585 2019-09-20 Tom Tromey <tom@tromey.com>
2586
2587 * tui/tui.h (strcat_to_buf): Don't declare.
2588 * tui/tui.c (strcat_to_buf): Remove.
2589
2590 2019-09-20 Tom Tromey <tom@tromey.com>
2591
2592 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
2593 from "fullname".
2594 * tui/tui-source.c (tui_source_window::set_contents)
2595 (tui_source_window::location_matches_p)
2596 (tui_source_window::maybe_update): Update.
2597
2598 2019-09-20 Tom Tromey <tom@tromey.com>
2599
2600 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
2601 Update.
2602 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
2603 prefix.
2604 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2605 (tui_data_window::line_from_reg_element_no)
2606 (tui_data_window::first_reg_element_no_inline)
2607 (tui_data_window::show_registers)
2608 (tui_data_window::show_register_group)
2609 (tui_data_window::display_registers_from)
2610 (tui_data_window::display_registers_from_line)
2611 (tui_data_window::first_data_item_displayed)
2612 (tui_data_window::delete_data_content_windows)
2613 (tui_data_window::erase_data_content)
2614 (tui_data_window::do_scroll_vertical)
2615 (tui_data_window::refresh_window)
2616 (tui_data_window::check_register_values): Update.
2617
2618 2019-09-20 Tom Tromey <tom@tromey.com>
2619
2620 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
2621 (struct tui_locator_window) <full_name, proc_name>: Now
2622 std::string.
2623 * tui/tui-stack.c (tui_locator_window::make_status_line)
2624 (tui_locator_window::set_locator_fullname)
2625 (tui_locator_window::set_locator_info): Update.
2626 * tui/tui-source.c (tui_source_window::set_contents)
2627 (tui_source_window::showing_source_p): Update.
2628
2629 2019-09-20 Tom Tromey <tom@tromey.com>
2630
2631 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2632 Don't call tui_locator_win_info_ptr.
2633
2634 2019-09-20 Tom Tromey <tom@tromey.com>
2635
2636 * tui/tui-win.c (tui_resize_all): Don't call refresh.
2637
2638 2019-09-20 Tom Tromey <tom@tromey.com>
2639
2640 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
2641 height for locator.
2642 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
2643 * tui/tui-layout.c (show_source_disasm_command, show_data)
2644 (show_source_or_disasm_and_command): Use 1 as height for locator.
2645
2646 2019-09-20 Tom Tromey <tom@tromey.com>
2647
2648 * tui/tui.c (tui_enable): Update.
2649 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
2650 Update.
2651 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
2652 Update.
2653 * tui/tui-data.c (win_resized): Now bool.
2654 (tui_win_resized): Return bool.
2655 (tui_set_win_resized_to): Accept a bool.
2656
2657 2019-09-20 Tom Tromey <tom@tromey.com>
2658
2659 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
2660 Change type of "refresh_values_only".
2661 * tui/tui-regs.c (tui_data_window::show_register_group): Change
2662 type of "refresh_values_only".
2663
2664 2019-09-20 Tom Tromey <tom@tromey.com>
2665
2666 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
2667 std::string.
2668 (tui_disassemble): Add "pos" parameter.
2669 (tui_disasm_window::set_contents): Simplify.
2670
2671 2019-09-20 Tom Tromey <tom@tromey.com>
2672
2673 * tui/tui-winsource.h (struct tui_source_window_base)
2674 <show_source_content>: Now private.
2675 * tui/tui-winsource.c
2676 (tui_source_window_base::show_source_content): Don't handle empty
2677 content case.
2678
2679 2019-09-20 Tom Tromey <tom@tromey.com>
2680
2681 * tui/tui-layout.c (show_source_disasm_command)
2682 (show_source_or_disasm_and_command): Don't call
2683 show_source_content.
2684
2685 2019-09-20 Tom Tromey <tom@tromey.com>
2686
2687 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
2688 Declare.
2689 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
2690 from tui_make_status_line.
2691 (tui_locator_window::rerender): Update.
2692
2693 2019-09-20 Tom Tromey <tom@tromey.com>
2694
2695 * tui/tui-stack.c (tui_make_status_line): Return std::string.
2696 (tui_locator_window::rerender): Update.
2697
2698 2019-09-20 Tom Tromey <tom@tromey.com>
2699
2700 * tui/tui-winsource.h (struct tui_source_window_base)
2701 <~tui_source_window_base>: Don't declare.
2702 <fullname>: Remove.
2703 * tui/tui-winsource.c (~tui_source_window_base): Remove.
2704 * tui/tui-source.h (struct tui_source_window) <fullname>: New
2705 member.
2706 * tui/tui-source.c (tui_source_window::set_contents): Update.
2707 (tui_source_window::location_matches_p)
2708 (tui_source_window::maybe_update): Update.
2709
2710 2019-09-20 Tom Tromey <tom@tromey.com>
2711
2712 * tui/tui-winsource.h (~tui_source_element): Remove.
2713 (tui_source_element): Update.
2714 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
2715 * tui/tui-winsource.c (tui_show_source_line): Update.
2716 * tui/tui-source.c (tui_source_window::set_contents): Update.
2717 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2718
2719 2019-09-20 Tom Tromey <tom@tromey.com>
2720
2721 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
2722 declare.
2723 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
2724 tui_clear_source_windows_detail.
2725 * tui/tui-winsource.h (struct tui_source_window_base)
2726 <clear_detail>: Don't declare.
2727 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
2728 Remove.
2729 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
2730
2731 2019-09-20 Tom Tromey <tromey@adacore.com>
2732
2733 PR ada/24919:
2734 * block.c (contained_in): Fix final return value.
2735
2736 2019-09-20 Alan Modra <amodra@gmail.com>
2737
2738 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
2739 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
2740 (read_indirect_string_from_dwz): Use bfd accessor.
2741 * dwarf2read.h (struct dwz_file <filename>): Likewise.
2742 * machoread.c (macho_symfile_read_all_oso): Likewise.
2743 * solib.c (solib_bfd_open): Likewise.
2744
2745 2019-09-19 Christian Biesinger <cbiesinger@google.com>
2746
2747 * eval.c: Move declaration of overload_resolution to...
2748 * value.h: ...here.
2749
2750 2019-09-19 Christian Biesinger <cbiesinger@google.com>
2751
2752 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
2753 * arm-linux-tdep.c: Likewise.
2754 * arm-nbsd-nat.c: Likewise.
2755 * arm-tdep.h: Declare arm_apcs_32.
2756 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
2757
2758 2019-09-19 Christian Biesinger <cbiesinger@google.com>
2759
2760 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
2761 * dwarf2read.h: Declare dwarf_always_disassemble.
2762
2763 2019-09-19 Tom de Vries <tdevries@suse.de>
2764
2765 PR gdb/25009
2766 * source-cache.c (source_cache::ensure): Catch exception thrown during
2767 construction of the highlighter.
2768
2769 2019-09-18 Alan Modra <amodra@gmail.com>
2770
2771 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
2772 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
2773 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
2774 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
2775 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
2776 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
2777 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
2778 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
2779 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
2780 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
2781 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
2782 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
2783 * solib-spu.c, * solib-svr4.c, * solib-target.c,
2784 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
2785 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
2786 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
2787 * mi/mi-interp.c: Update throughout for bfd section macro and
2788 function changes.
2789 * gcore (gcore_create_callback): Use bfd_set_section_lma.
2790 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
2791
2792 2019-09-18 Tom Tromey <tom@tromey.com>
2793
2794 * NEWS: Add entry.
2795 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
2796 call rl_initialize.
2797 (tui_enable): Do not call rl_initialize.
2798
2799 2019-09-18 Christian Groessler <chris@groessler.org>
2800
2801 * alpha-linux-nat.c: Include gdbarch.h.
2802
2803 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
2804
2805 * ui-file.c: Include cli/cli-style.h.
2806 (term_cli_styling): Remove cli_styling declaration.
2807
2808 2019-09-18 Alan Modra <amodra@gmail.com>
2809
2810 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
2811 to bfd_asymbol_section.
2812
2813 2019-09-18 Alan Modra <amodra@gmail.com>
2814
2815 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
2816 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
2817 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
2818
2819 2019-09-18 Alan Modra <amodra@gmail.com>
2820
2821 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
2822 * spu-linux-nat.c (spu_bfd_open): Likewise.
2823
2824 2019-09-18 Christian Biesinger <cbiesinger@google.com>
2825
2826 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
2827 to bool to match definition in dwarf2read.c.
2828
2829 2019-09-17 Christian Biesinger <cbiesinger@google.com>
2830
2831 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
2832 (print_signatures): Likewise.
2833 (trust_pad_over_xvs): Likewise.
2834 * arch/aarch64-insn.c (aarch64_debug): Likewise.
2835 * arch/aarch64-insn.h (aarch64_debug): Likewise.
2836 * arm-linux-nat.c (arm_apcs_32): Likewise.
2837 * arm-linux-tdep.c (arm_apcs_32): Likewise.
2838 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
2839 * arm-tdep.c (arm_debug): Likewise.
2840 (arm_apcs_32): Likewise.
2841 * auto-load.c (debug_auto_load): Likewise.
2842 (auto_load_gdb_scripts): Likewise.
2843 (global_auto_load): Likewise.
2844 (auto_load_local_gdbinit): Likewise.
2845 (auto_load_local_gdbinit_loaded): Likewise.
2846 * auto-load.h (global_auto_load): Likewise.
2847 (auto_load_local_gdbinit): Likewise.
2848 (auto_load_local_gdbinit_loaded): Likewise.
2849 * breakpoint.c (disconnected_dprintf): Likewise.
2850 (breakpoint_proceeded): Likewise.
2851 (automatic_hardware_breakpoints): Likewise.
2852 (always_inserted_mode): Likewise.
2853 (target_exact_watchpoints): Likewise.
2854 (_initialize_breakpoint): Update.
2855 * breakpoint.h (target_exact_watchpoints): Change to bool.
2856 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
2857 * cli/cli-cmds.c (trace_commands): Likewise.
2858 * cli/cli-cmds.h (trace_commands): Likewise.
2859 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
2860 to bool*.
2861 * cli/cli-logging.c (logging_overwrite): Change to bool.
2862 (logging_redirect): Likewise.
2863 (debug_redirect): Likewise.
2864 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
2865 (struct boolean_option_def) <get_var_address_cb_>: Change return type
2866 to bool.
2867 <boolean_option_def>: Update.
2868 (struct flag_option_def): Change default type of Context to bool
2869 from int.
2870 <flag_option_def>: Change return type of var_address_cb_ to bool*.
2871 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
2872 (get_setshow_command_value_string): Likewise.
2873 * cli/cli-style.c (cli_styling): Change to bool.
2874 (source_styling): Likewise.
2875 * cli/cli-style.h (source_styling): Likewise.
2876 (cli_styling): Likewise.
2877 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
2878 to bool.
2879 * command.h (var_types): Update comment.
2880 (add_setshow_boolean_cmd): Change int* var argument to bool*.
2881 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
2882 bool.
2883 (debug_compile_cplus_scopes): Likewise.
2884 * compile/compile-internal.h (compile_debug): Likewise.
2885 * compile/compile.c (compile_debug): Likewise.
2886 (struct compile_options) <raw>: Likewise.
2887 * cp-support.c (catch_demangler_crashes): Likewise.
2888 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
2889 (usr_cmd_cris_dwarf2_cfi): Likewise.
2890 * csky-tdep.c (csky_debug): Likewise.
2891 * darwin-nat.c (enable_mach_exceptions): Likewise.
2892 * dcache.c (dcache_enabled_p): Likewise.
2893 * defs.h (info_verbose): Likewise.
2894 * demangle.c (demangle): Likewise.
2895 (asm_demangle): Likewise.
2896 * dwarf-index-cache.c (debug_index_cache): Likewise.
2897 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
2898 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
2899 * dwarf2read.c (check_physname): Likewise.
2900 (use_deprecated_index_sections): Likewise.
2901 (dwarf_always_disassemble): Likewise.
2902 * eval.c (overload_resolution): Likewise.
2903 * event-top.c (set_editing_cmd_var): Likewise.
2904 (exec_done_display_p): Likewise.
2905 * event-top.h (set_editing_cmd_var): Likewise.
2906 (exec_done_display_p): Likewise.
2907 * exec.c (write_files): Likewise.
2908 * fbsd-nat.c (debug_fbsd_lwp): Likewise
2909 (debug_fbsd_nat): Likewise.
2910 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
2911 Likewise.
2912 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
2913 <backtrace_past_entry> Likewise.
2914 * gdb-demangle.h (demangle): Likewise.
2915 (asm_demangle): Likewise.
2916 * gdb_bfd.c (bfd_sharing): Likewise.
2917 * gdbcore.h (write_files): Likewise.
2918 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
2919 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
2920 * gdbthread.h (print_thread_events): Likewise.
2921 * gdbtypes.c (opaque_type_resolution): Likewise.
2922 (strict_type_checking): Likewise.
2923 * gnu-nat.c (gnu_debug_flag): Likewise.
2924 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
2925 * guile/scm-param.c (pascm_variable): Add boolval.
2926 (add_setshow_generic): Update.
2927 (pascm_param_value): Update.
2928 (pascm_set_param_value_x): Update.
2929 * hppa-tdep.c (hppa_debug): Change to bool..
2930 * infcall.c (may_call_functions_p): Likewise.
2931 (coerce_float_to_double_p): Likewise.
2932 (unwind_on_signal_p): Likewise.
2933 (unwind_on_terminating_exception_p): Likewise.
2934 * infcmd.c (startup_with_shell): Likewise.
2935 * inferior.c (print_inferior_events): Likewise.
2936 * inferior.h (startup_with_shell): Likewise.
2937 (print_inferior_events): Likewise.
2938 * infrun.c (step_stop_if_no_debug): Likewise.
2939 (detach_fork): Likewise.
2940 (debug_displaced): Likewise.
2941 (disable_randomization): Likewise.
2942 (non_stop): Likewise.
2943 (non_stop_1): Likewise.
2944 (observer_mode): Likewise.
2945 (observer_mode_1): Likewise.
2946 (set_observer_mode): Update.
2947 (sched_multi): Change to bool.
2948 * infrun.h (debug_displaced): Likewise.
2949 (sched_multi): Likewise.
2950 (step_stop_if_no_debug): Likewise.
2951 (non_stop): Likewise.
2952 (disable_randomization): Likewise.
2953 * linux-tdep.c (use_coredump_filter): Likewise.
2954 (dump_excluded_mappings): Likewise.
2955 * linux-thread-db.c (auto_load_thread_db): Likewise.
2956 (check_thread_db_on_load): Likewise.
2957 * main.c (captured_main_1): Update.
2958 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
2959 xx2_opt, boolean_opt>: Change to bool.
2960 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
2961 * maint.c (maintenance_profile_p): Likewise.
2962 (per_command_time): Likewise.
2963 (per_command_space): Likewise.
2964 (per_command_symtab): Likewise.
2965 * memattr.c (inaccessible_by_default): Likewise.
2966 * mi/mi-main.c (mi_async): Likewise.
2967 (mi_async_1): Likewise.
2968 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
2969 * nat/fork-inferior.h (startup_with_shell): Likewise.
2970 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
2971 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
2972 * nios2-tdep.c (nios2_debug): Likewise.
2973 * or1k-tdep.c (or1k_debug): Likewise.
2974 * parse.c (parser_debug): Likewise.
2975 * parser-defs.h (parser_debug): Likewise.
2976 * printcmd.c (print_symbol_filename): Likewise.
2977 * proc-api.c (procfs_trace): Likewise.
2978 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
2979 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
2980 (set_parameter_value): Update.
2981 (add_setshow_generic): Update.
2982 * python/py-value.c (copy_py_bool_obj): Change argument from int*
2983 to bool*.
2984 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
2985 int*.
2986 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
2987 * record-btrace.c (record_btrace_target::store_registers): Update.
2988 * record-full.c (record_full_memory_query): Change to bool.
2989 (record_full_stop_at_limit): Likewise.
2990 * record-full.h (record_full_memory_query): Likewise.
2991 * remote-notif.c (notif_debug): Likewise.
2992 * remote-notif.h (notif_debug): Likewise.
2993 * remote.c (use_range_stepping): Likewise.
2994 (interrupt_on_connect): Likewise.
2995 (remote_break): Likewise.
2996 * ser-tcp.c (tcp_auto_retry): Likewise.
2997 * ser-unix.c (serial_hwflow): Likewise.
2998 * skip.c (debug_skip): Likewise.
2999 * solib-aix.c (solib_aix_debug): Likewise.
3000 * spu-tdep.c (spu_stop_on_load_p): Likewise.
3001 (spu_auto_flush_cache_p): Likewise.
3002 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3003 Likewise.
3004 (struct info_print_options) <quiet>: Likewise.
3005 * symfile-debug.c (debug_symfile): Likewise.
3006 * symfile.c (auto_solib_add): Likewise.
3007 (separate_debug_file_debug): Likewise.
3008 * symfile.h (auto_solib_add): Likewise.
3009 (separate_debug_file_debug): Likewise.
3010 * symtab.c (basenames_may_differ): Likewise.
3011 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3012 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3013 (struct info_types_options) <quiet>: Likewise.
3014 * symtab.h (demangle): Likewise.
3015 (basenames_may_differ): Likewise.
3016 * target-dcache.c (stack_cache_enabled_1): Likewise.
3017 (code_cache_enabled_1): Likewise.
3018 * target.c (trust_readonly): Likewise.
3019 (may_write_registers): Likewise.
3020 (may_write_memory): Likewise.
3021 (may_insert_breakpoints): Likewise.
3022 (may_insert_tracepoints): Likewise.
3023 (may_insert_fast_tracepoints): Likewise.
3024 (may_stop): Likewise.
3025 (auto_connect_native_target): Likewise.
3026 (target_stop_and_wait): Update.
3027 (target_async_permitted): Change to bool.
3028 (target_async_permitted_1): Likewise.
3029 (may_write_registers_1): Likewise.
3030 (may_write_memory_1): Likewise.
3031 (may_insert_breakpoints_1): Likewise.
3032 (may_insert_tracepoints_1): Likewise.
3033 (may_insert_fast_tracepoints_1): Likewise.
3034 (may_stop_1): Likewise.
3035 * target.h (target_async_permitted): Likewise.
3036 (may_write_registers): Likewise.
3037 (may_write_memory): Likewise.
3038 (may_insert_breakpoints): Likewise.
3039 (may_insert_tracepoints): Likewise.
3040 (may_insert_fast_tracepoints): Likewise.
3041 (may_stop): Likewise.
3042 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3043 (make_thread_apply_all_options_def_group): Change argument from int*
3044 to bool*.
3045 (thread_apply_all_command): Update.
3046 (print_thread_events): Change to bool.
3047 * top.c (confirm): Likewise.
3048 (command_editing_p): Likewise.
3049 (history_expansion_p): Likewise.
3050 (write_history_p): Likewise.
3051 (info_verbose): Likewise.
3052 * top.h (confirm): Likewise.
3053 (history_expansion_p): Likewise.
3054 * tracepoint.c (disconnected_tracing): Likewise.
3055 (circular_trace_buffer): Likewise.
3056 * typeprint.c (print_methods): Likewise.
3057 (print_typedefs): Likewise.
3058 * utils.c (debug_timestamp): Likewise.
3059 (sevenbit_strings): Likewise.
3060 (pagination_enabled): Likewise.
3061 * utils.h (sevenbit_strings): Likewise.
3062 (pagination_enabled): Likewise.
3063 * valops.c (overload_resolution): Likewise.
3064 * valprint.h (struct value_print_options) <prettyformat_arrays,
3065 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3066 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3067 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3068 Likewise.
3069 * windows-nat.c (new_console): Likewise.
3070 (cygwin_exceptions): Likewise.
3071 (new_group): Likewise.
3072 (debug_exec): Likewise.
3073 (debug_events): Likewise.
3074 (debug_memory): Likewise.
3075 (debug_exceptions): Likewise.
3076 (useshell): Likewise.
3077 * windows-tdep.c (maint_display_all_tib): Likewise.
3078 * xml-support.c (debug_xml): Likewise.
3079
3080 2019-09-17 Mike Gulick <mgulick@mathworks.com>
3081
3082 * source.c (prepare_path_for_appending): New function.
3083 (openp): Make use of new function.
3084 (find_and_open_source): Search for the compilation directory and
3085 source file as a relative path beneath the directory search path.
3086
3087 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
3088
3089 * source-cache.c (source_cache::get_line_charpos): Catch
3090 exceptions and return false, this matches the behaviour documented
3091 in the header file.
3092
3093 2019-09-17 Joel Brobecker <brobecker@adacore.com>
3094
3095 * ada-tasks.c (info_task): Remove quoting of the task's name.
3096
3097 2019-09-16 Christian Biesinger <cbiesinger@google.com>
3098
3099 * symfile.c (auto_solib_add): Replace comment with a reference
3100 to the header file.
3101
3102 2019-09-14 Christian Biesinger <cbiesinger@google.com>
3103
3104 * NEWS: Mention that gdb can now be compiled with Python 3
3105 on Windows.
3106
3107 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3108
3109 * maint.c (maint_print_section_data::maint_print_section_data):
3110 Force use of 'float log10 (float)' by casting the argument to
3111 float.
3112
3113 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3114
3115 * maint.c: Add 'cmath' include.
3116 (struct maint_print_section_data): New structure.
3117 (print_section_index): New function.
3118 (print_bfd_section_info): Add header comment, small whitespace
3119 cleanup, and update to call new print_section_index function.
3120 (print_objfile_section_info): Likewise.
3121 (maint_obj_section_from_bfd_section): New function.
3122 (print_bfd_section_info_maybe_relocated): New function.
3123 (maintenance_info_sections): Add header comment, always use
3124 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3125
3126 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
3127
3128 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3129 inner scope, add check that the objfile has psymtabs before
3130 checking psymtabs_addrmap.
3131 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3132
3133 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3134
3135 * NEWS: Announce that Ada task names are now shown at more places,
3136 and between quotes (except in info task output).
3137 * gdb/ada-tasks.c (task_to_str): New function.
3138 (display_current_task_id): Call task_to_str.
3139 (task_command_1): Likewise.
3140 (print_ada_task_info): In non-mi mode, Properly align headers and data
3141 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3142
3143 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
3144
3145 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3146 prstatus.pr_lwp.pr_info instead of making it up.
3147
3148 2019-09-11 Christian Biesinger <cbiesinger@google.com>
3149
3150 * auto-load.c (auto_load_expand_dir_vars): Update.
3151 * defs.h (gdb_datadir): Change to std::string.
3152 (python_libdir): Likewise.
3153 (relocate_gdb_directory): Change return type to std::string.
3154 * guile/guile.c (gdbscm_data_directory): Update.
3155 (initialize_scheme_side): Update.
3156 * jit.c (jit_reader_dir): Change to std::string.
3157 (jit_reader_load_command): Update.
3158 * main.c (gdb_datadir): Change to std::string.
3159 (python_libdir): Likewise.
3160 (set_gdb_data_directory): Update.
3161 (relocate_path): Change to return std::string.
3162 (relocate_gdb_directory): Change to return std::string.
3163 (relocate_gdbinit_path_maybe_in_datadir): Update.
3164 (captured_main_1): Update.
3165 * python/python.c (do_start_initialization): Update.
3166 * top.c (show_gdb_datadir): Update.
3167 * xml-syscall.c (xml_init_syscalls_info): Update.
3168 (init_syscalls_info): Update.
3169
3170 2019-09-11 Christian Biesinger <cbiesinger@google.com>
3171
3172 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3173 out of get_init_files.
3174 (get_init_files): Update.
3175
3176 2019-09-11 Christian Biesinger <cbiesinger@google.com>
3177
3178 * main.c (get_init_files): Change to use std::string.
3179 (captured_main_1): Update.
3180 (print_gdb_help): Update.
3181
3182 2019-09-11 Ali Tamur <tamur@google.com>
3183
3184 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3185 implementation.
3186
3187 2019-09-11 Christian Biesinger <cbiesinger@google.com>
3188
3189 * dbxread.c (read_dbx_symtab): Update.
3190 * dwarf2read.c (load_partial_dies): Update.
3191 * mdebugread.c (parse_partial_symbols): Update.
3192 (handle_psymbol_enumerators): Update.
3193 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3194 * psymtab.c (add_psymbol_to_bcache): Likewise.
3195 (add_psymbol_to_list): Likewise.
3196 * symtab.c (symbol_set_names): Likewise.
3197 * symtab.h (symbol_set_names): Likewise.
3198 * xcoffread.c (scan_xcoff_symtab): Update.
3199
3200 2019-09-11 Tom Tromey <tom@tromey.com>
3201
3202 * symfile-mem.c (symbol_file_add_from_memory): Use
3203 bfd_set_filename.
3204 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3205 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3206
3207 2019-09-10 Tom Tromey <tromey@adacore.com>
3208
3209 * dwarf-index-write.c (write_psymbols): Extend error message.
3210 (debug_names::insert): Add Ada code.
3211 (debug_names::write_psymbols): Remove Ada check.
3212 (debug_names) <m_string_obstack>: New member.
3213 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3214 (gdb_index_symbol_name_matcher::matches): Remove.
3215 (mapped_index_base::find_name_components_bounds): Add "lang"
3216 parameter.
3217 (mapped_index_base::build_name_components): Also split names
3218 according to Ada syntax.
3219 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
3220 type of "match_callback".
3221 (check_match, check_find_bounds_finds)
3222 (dw2_expand_symtabs_matching): Update.
3223 (dw2_debug_names_iterator): Add new constructor.
3224 (dw2_debug_names_map_matching_symbols): New function.
3225 (dw2_debug_names_expand_symtabs_matching): Update.
3226 (dwarf2_debug_names_functions): Use
3227 dw2_debug_names_map_matching_symbols.
3228
3229 2019-09-10 Tom Tromey <tromey@adacore.com>
3230
3231 * dwarf2read.c (dw2_get_file_names_reader): Add the
3232 CU's file name to the results.
3233
3234 2019-09-10 Tom Tromey <tromey@adacore.com>
3235
3236 * ada-lang.c (add_nonlocal_symbols): Combine calls to
3237 map_matching_symbols. Update.
3238 * dwarf2read.c (dw2_map_matching_symbols): Update.
3239 * psymtab.c (match_partial_symbol): Change type; update.
3240 (psym_map_matching_symbols): Likewise.
3241 * symfile-debug.c (debug_qf_map_matching_symbols): Change
3242 type; update.
3243 * symfile.h (struct quick_symbol_functions)
3244 <map_matching_symbols>: Change "name" to be a lookup_name_info.
3245 Remove "match".
3246
3247 2019-09-10 Tom Tromey <tromey@adacore.com>
3248
3249 * psymtab.c (map_block): Remove.
3250 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3251 * symtab.c (iterate_over_symbols_terminated): New function.
3252 * symtab.c (iterate_over_symbols_terminated): Declare.
3253
3254 2019-09-10 Tom Tromey <tromey@adacore.com>
3255
3256 * ada-lang.c (ada_iterate_over_symbols): Return bool.
3257 * language.h (struct language_defn) <la_iterate_over_symbols>:
3258 Return bool.
3259 * symtab.c (iterate_over_symbols): Return bool.
3260 * symtab.h (iterate_over_symbols): Return bool.
3261
3262 2019-09-10 Tom Tromey <tromey@adacore.com>
3263
3264 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3265 (add_nonlocal_symbols): Update.
3266 * dwarf2read.c (dw2_map_matching_symbols): Change type.
3267 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3268 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3269 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3270 Change type of "callback". Remove "data".
3271
3272
3273 2019-09-09 Ali Tamur <tamur@google.com>
3274
3275 * dwarf2read.c (comp_unit_head): Update comment.
3276 (dwarf2_dwo_name): New function declaration.
3277 (dwarf_unit_type_name): New function declaration.
3278 (read_comp_unit_head): Add support for new compilation units,
3279 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3280 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3281 (currently named as "signature") in their header. Also clarify error
3282 messages.
3283 (lookup_dwo_id): New function. Returns the dwo id of the given
3284 compile unit.
3285 (lookup_dwo_unit): Use the new lookup_dwo_id function.
3286 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3287 functions.
3288 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3289 (dwarf2_dwo_name): Get the dwo name if present.
3290 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3291 purposes.
3292
3293 2019-09-09 Tom Tromey <tom@tromey.com>
3294
3295 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3296
3297 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3298
3299 * python/python.c (do_start_initialization): Make progname_copy static,
3300 to avoid a leak report.
3301
3302 2019-09-08 Tom Tromey <tom@tromey.com>
3303
3304 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3305
3306 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
3307
3308 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3309 Change type to gdb::optional<block_enum>.
3310 (dw2_symtab_iter_init): Change block_index parameter type
3311 to gdb::optional<block_enum>.
3312 (dw2_lookup_symbol): Change block_index parameter
3313 type to block_enum.c
3314 (dw2_debug_names_lookup_symbol): Likewise.
3315 * psymtab.c (psym_lookup_symbol): Likewise.
3316 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3317 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3318 Likewise.
3319
3320 2019-09-06 Christian Biesinger <cbiesinger@google.com>
3321
3322 * defs.h (relocate_gdb_directory): Change int to bool in
3323 signature and rename flag to relocatable.
3324 * main.c (relocate_path): Likewise.
3325 (relocate_gdb_directory): Likewise.
3326
3327 2019-09-06 Alan Modra <amodra@gmail.com>
3328
3329 * coffread.c (coff_symfile_read): Constify filename variable.
3330 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3331 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3332 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3333 * solib.c (reload_shared_libraries_1): Likewise.
3334 * symfile.c (reread_symbols): Likewise.
3335 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3336 * solib-darwin.c (darwin_bfd_open): Likewise.
3337 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3338
3339 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
3340
3341 * psymtab.c (print_partial_symbols): Handle missing domain_enum
3342 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3343
3344 2019-09-03 Tom Tromey <tromey@adacore.com>
3345
3346 * ada-valprint.c (ada_val_print_num): Don't recurse for range
3347 types.
3348 (has_negatives): Unbias a range type bound.
3349 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3350 * gdbtypes.c (operator==): Handle new field.
3351 (create_range_type): Add "bias" parameter.
3352 (create_static_range_type, resolve_dynamic_range): Update.
3353 * gdbtypes.h (struct range_bounds) <bias>: New member.
3354 (create_range_type): Add bias parameter.
3355 * printcmd.c (print_scalar_formatted): Unbias range types.
3356 * value.c (unpack_long): Unbias range types.
3357 (pack_long): Bias range types.
3358
3359 2019-09-02 Alan Hayward <alan.hayward@arm.com>
3360
3361 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3362 probe arguments.
3363
3364 2019-09-02 Alan Hayward <alan.hayward@arm.com>
3365
3366 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3367 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3368 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3369 (compile_probe_arg): Likewise.
3370 * probe.h (get_argument_count): Likewise.
3371 * solib-svr4.c (solib_event_probe_action): Likewise.
3372 * stap-probe.c (stap_probe::get_argument_count): Likewise.
3373
3374 2019-09-02 Alan Hayward <alan.hayward@arm.com>
3375
3376 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3377 code to here...
3378 (svr4_create_solib_event_breakpoints): ...from here.
3379
3380 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
3381
3382 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3383 suffix from warning message.
3384
3385 2019-08-30 Tom Tromey <tom@tromey.com>
3386
3387 * tui/tui-winsource.h (struct tui_source_window_base)
3388 <refresh_all>: Don't declare.
3389 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3390 Remove.
3391 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3392 tui_show_locator_content.
3393 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3394 declare.
3395 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3396 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3397 declare.
3398
3399 2019-08-30 Tom Tromey <tom@tromey.com>
3400
3401 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3402
3403 2019-08-30 Tom Tromey <tom@tromey.com>
3404
3405 * tui/tui-stack.c (_initialize_tui_stack): Move later.
3406 Remove unnecessary forward declarations.
3407
3408 2019-08-30 Tom Tromey <tom@tromey.com>
3409
3410 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
3411 rerender.
3412 (tui_update_locator_fullname, tui_show_frame_info): Don't call
3413 tui_show_locator_content.
3414
3415 2019-08-30 Tom Tromey <tom@tromey.com>
3416
3417 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
3418 (tui_locator_window::rerender): Rewrite using body of previous
3419 tui_show_locator_content.
3420
3421 2019-08-30 Tom Tromey <tom@tromey.com>
3422
3423 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
3424 set_locator_fullname>: New methods.
3425 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3426 Rename from tui_set_locator_fullname.
3427 (tui_locator_window::set_locator_info): Rename from
3428 tui_set_locator_info. Return bool.
3429 (tui_update_locator_fullname, tui_show_frame_info): Update.
3430
3431 2019-08-30 Tom Tromey <tom@tromey.com>
3432
3433 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
3434
3435 2019-08-30 Tom Tromey <tom@tromey.com>
3436
3437 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
3438 call touchwin.
3439
3440 2019-08-30 Tom Tromey <tom@tromey.com>
3441
3442 * tui/tui-wingeneral.c (box_win): Assume win_info and
3443 win_info->handle cannot be NULL.
3444
3445 2019-08-30 Tom Tromey <tom@tromey.com>
3446
3447 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
3448 refresh_window>: Declare.
3449 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
3450 resize.
3451 (tui_data_item_window::rerender): Rename from
3452 tui_display_register.
3453 (tui_data_item_window::refresh_window): New method.
3454 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
3455 no-op.
3456
3457 2019-08-30 Tom Tromey <tom@tromey.com>
3458
3459 * tui/tui-regs.h (struct tui_data_window) <regs_content,
3460 regs_column_count, current_group>: Move later. Now private.
3461 <get_current_group>: New method.
3462 * tui/tui-regs.c (tui_reg_command): Update.
3463 * tui/tui-layout.c (tui_set_layout): Update.
3464
3465 2019-08-30 Tom Tromey <tom@tromey.com>
3466
3467 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3468 (tui_data_window::rerender): Don't call
3469 check_and_display_highlight_if_needed.
3470 (tui_data_window::refresh_all): Remove call to
3471 erase_data_content.
3472
3473 2019-08-30 Tom Tromey <tom@tromey.com>
3474
3475 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3476 (tui_data_window::display_registers_from)
3477 (tui_data_window::display_reg_element_at_line)
3478 (tui_data_window::display_registers_from_line): Remove checks of
3479 "empty".
3480
3481 2019-08-30 Tom Tromey <tom@tromey.com>
3482
3483 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
3484 Don't declare.
3485 * tui/tui-regs.c (tui_data_window::show_registers): Call
3486 rerender.
3487 (tui_data_window::rerender): Rename from display_all_data.
3488 (tui_data_window::rerender): Remove old implementation.
3489
3490 2019-08-30 Tom Tromey <tom@tromey.com>
3491
3492 * tui/tui-regs.c (tui_data_window::display_all_data): Change
3493 text.
3494 * tui/tui-data.h (NO_DATA_STRING): Remove define.
3495
3496 2019-08-29 Bernhard Wodok <barto@gmx.net>
3497 Sergio Durigan Junior <sergiodj@redhat.com>
3498
3499 PR win32/24284
3500 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
3501
3502 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
3503
3504 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
3505 when searching for types.
3506
3507 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
3508
3509 * f-lang.c (f_language_defn): Use f_print_typedef.
3510 * f-lang.h (f_print_typedef): Declare.
3511 * f-typeprint.c (f_print_typedef): Define.
3512
3513 2019-08-27 Christian Biesinger <cbiesinger@google.com>
3514
3515 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
3516
3517 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
3518
3519 * cli/cli-utils.c (info_print_options_defs): Delete.
3520 (make_info_print_options_def_group): Delete.
3521 (extract_info_print_options): Delete.
3522 (info_print_command_completer): Delete.
3523 (info_print_args_help): Add extra parameter, and optionally
3524 include text about -n flag.
3525 * cli/cli-utils.h (struct info_print_options): Delete.
3526 (extract_info_print_options): Delete declaration.
3527 (info_print_command_completer): Delete declaration.
3528 (info_print_args_help): Add extra parameter, extend header
3529 comment.
3530 * python/python.c (gdbpy_rbreak): Pass additional parameter to
3531 search_symbols.
3532 * stack.c (struct info_print_options): New type.
3533 (info_print_options_defs): New file scoped variable.
3534 (make_info_print_options_def_group): New static function.
3535 (info_print_command_completer): New static function.
3536 (info_locals_command): Update to use new local functions.
3537 (info_args_command): Likewise.
3538 (_initialize_stack): Add extra parameter to calls to
3539 info_print_args_help.
3540 * symtab.c (search_symbols): Add extra parameter, use this to
3541 possibly excluse non-debug symbols.
3542 (symtab_symbol_info): Add extra parameter, which is passed on to
3543 search_symbols.
3544 (struct info_print_options): New type.
3545 (info_print_options_defs): New file scoped variable.
3546 (make_info_print_options_def_group): New static function.
3547 (info_print_command_completer): New static function.
3548 (info_variables_command): Update to use local functions, and pass
3549 extra parameter through to symtab_symbol_info.
3550 (info_functions_command): Likewise.
3551 (info_types_command): Pass additional argument through to
3552 symtab_symbol_info.
3553 (rbreak_command): Pass extra argument to search_symbols.
3554 (_initialize_symtab): Add extra arguments for calls to
3555 info_print_args_help, and update help text for 'info variables',
3556 'whereis', and 'info functions' commands.
3557 * symtab.h (search_symbols): Add extra argument to declaration.
3558 * NEWS: Mention new flags.
3559
3560 2019-08-26 Christian Biesinger <cbiesinger@google.com>
3561
3562 * symtab.c (lookup_static_symbol): Call the new function (and move
3563 it down to be next to lookup_global_symbol).
3564 (struct global_sym_lookup_data): Add block_enum member and rename to...
3565 (struct global_or_static_sym_lookup_data): ...this.
3566 (lookup_symbol_global_iterator_cb): Pass block_index instead of
3567 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
3568 (lookup_symbol_global_or_static_iterator_cb): ...this.
3569 (lookup_global_or_static_symbol): New function.
3570 (lookup_global_symbol): Call new function.
3571
3572 2019-08-26 Tom de Vries <tdevries@suse.de>
3573
3574 PR c++/24852
3575 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
3576 when pc_probe.prob == NULL.
3577
3578 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
3579
3580 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
3581 variable symbol_linkage to symbol_linkage_.
3582
3583 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
3584
3585 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
3586 represent whether the symbol is static, dynamic, or we don't
3587 know.
3588
3589 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
3590
3591 * gdb/rx-tdep.c (rx_register_names): New.
3592 (rx_register_name): Delete.
3593 (rx_psw_type): Delete.
3594 (rx_fpsw_type): Delete.
3595 (rx_register_type): Delete.
3596 (rx_gdbarch_init): Convert target-descriptions.
3597 (_initialize_rx_tdep): Add initialize_tdesc_rx.
3598 * gdb/features/Makefile: Add rx.xml.
3599 * gdb/features/rx.xml: New.
3600 * gdb/features/rx.c: Generated.
3601 * gdb/NEWS: Mention target description support.
3602
3603 2019-08-22 Christian Biesinger <cbiesinger@google.com>
3604
3605 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
3606 *slot_ptr.
3607
3608 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
3609
3610 * configure.ac: Don't check for 'dlfcn.h' (moved to
3611 gdbsupport/common.m4).
3612 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
3613 'gdbsupport/'.
3614 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
3615 * compile/compile-c-support.c: Include
3616 'gdbsupport/gdb-dlfcn.h'.
3617 * gdbsupport/common.m4: Check for 'dlfcn.h'.
3618 * gdb-dlfcn.c: Move to...
3619 * gdbsupport/gdb-dlfcn.c: ... here.
3620 * gdb-dlfcn.h: Move to...
3621 * gdbsupport/gdb-dlfcn.h: ... here.
3622
3623 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
3624
3625 * nios2-tdep.c (struct reg_value): Improve comments. Make
3626 the offset field signed.
3627
3628 2019-08-22 Christian Biesinger <cbiesinger@google.com>
3629
3630 * python/lib/gdb/__init__.py (_execute_file): New function.
3631 * python/python.c (python_run_simple_file): Call gdb._execute_file
3632 on Windows.
3633
3634 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
3635
3636 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
3637 all uses as this was never set to anything but a zero value.
3638
3639 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
3640
3641 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
3642
3643 2019-08-21 Christian Biesinger <cbiesinger@google.com>
3644
3645 * tui/tui-data.h (tui_gen_win_info): Add an =default
3646 move constructor, required by some GCC versions.
3647
3648 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
3649
3650 * go32-nat.c (go32_sysinfo): Add hygon_p.
3651
3652 2019-08-20 Tom Tromey <tom@tromey.com>
3653
3654 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
3655 line_from_reg_element_no, first_reg_element_no_inline,
3656 display_all_data, delete_data_content_windows,
3657 erase_data_content>: Now private.
3658
3659 2019-08-20 Tom Tromey <tom@tromey.com>
3660
3661 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
3662 (tui_unhighlight_win, tui_highlight_win)
3663 (tui_win_info::make_window): Update.
3664 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
3665
3666 2019-08-20 Tom Tromey <tom@tromey.com>
3667
3668 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3669 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3670 (MAX_PID_WIDTH): Move to tui-stack.c.
3671 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
3672 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
3673 (MAX_PID_WIDTH): Move from tui-data.h.
3674
3675 2019-08-20 Tom Tromey <tom@tromey.com>
3676
3677 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
3678 * tui/tui-wingeneral.c (box_win): Change type of win_info.
3679 (box_win): Update.
3680 (tui_gen_win_info::make_window): Rename from tui_make_window.
3681 (tui_win_info::make_window): New method.
3682 (tui_gen_win_info::make_visible): Update.
3683 * tui/tui-source.c (tui_source_window::set_contents): Update.
3684 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
3685 (tui_data_window::display_registers_from): Update.
3686 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3687 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
3688 Declare.
3689 <can_box>: Remove.
3690 <title>: Remove.
3691 (struct tui_win_info) <make_window>: Declare.
3692 <can_box>: Now virtual.
3693 <title>: New member.
3694 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
3695 * tui/tui-command.c (tui_cmd_window::resize): Update.
3696
3697 2019-08-20 Tom Tromey <tom@tromey.com>
3698
3699 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
3700 * tui/tui-regs.c (tui_data_window::show_registers): Update.
3701 (tui_data_window::check_register_values): Update.
3702
3703 2019-08-20 Tom Tromey <tom@tromey.com>
3704
3705 * tui/tui-regs.h (struct tui_data_window): Use
3706 DISABLE_COPY_AND_ASSIGN.
3707 <regs_content>: Change type, removing unique_ptr.
3708 <tui_data_window>: Add move constructor.
3709 * tui/tui-regs.c (tui_data_window::show_registers)
3710 (tui_data_window::show_register_group)
3711 (tui_data_window::display_registers_from)
3712 (tui_data_window::display_registers_from)
3713 (tui_data_window::first_data_item_displayed)
3714 (tui_data_window::delete_data_content_windows)
3715 (tui_data_window::rerender, tui_data_window::refresh_window)
3716 (tui_data_window::check_register_values): Update.
3717
3718 2019-08-20 Tom Tromey <tom@tromey.com>
3719
3720 * tui/tui-regs.h (struct tui_data_window) <show_registers,
3721 show_register_group>: Declare.
3722 (tui_show_register_group): Don't declare.
3723 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
3724 tui_show_registers.
3725 (tui_data_window::show_register_group): Rename from
3726 tui_show_register_group.
3727 (tui_data_window::check_register_values, tui_reg_command):
3728 Update.
3729 * tui/tui-layout.c (tui_set_layout): Update.
3730
3731 2019-08-20 Tom Tromey <tom@tromey.com>
3732
3733 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
3734 Declare.
3735 (tui_check_register_values): Don't declare.
3736 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
3737 from tui_check_register_values.
3738 * tui/tui-hooks.c (tui_register_changed): Update.
3739
3740 2019-08-20 Tom Tromey <tom@tromey.com>
3741
3742 * tui/tui-regs.c (tui_reg_layout): Move later.
3743 (tui_show_registers): Don't enable TUI mode or change layout.
3744
3745 2019-08-20 Tom Tromey <tom@tromey.com>
3746
3747 * tui/tui-regs.h (struct tui_data_item_window)
3748 <~tui_data_item_window>: Remove.
3749 <content>: Now a unique_xmalloc_ptr.
3750 * tui/tui-regs.c (tui_register_format): Return a
3751 unique_xmalloc_ptr.
3752 (tui_get_register): Update.
3753 (~tui_data_item_window): Remove.
3754 (tui_data_window::display_registers_from, tui_display_register):
3755 Update.
3756 * tui/tui-io.h (tui_expand_tabs): Update.
3757 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
3758 Remove "col" parameter.
3759
3760 2019-08-20 Tom Tromey <tom@tromey.com>
3761
3762 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
3763 field.
3764 * tui/tui-regs.c (~tui_data_item_window): Update.
3765
3766 2019-08-20 Tom Tromey <tom@tromey.com>
3767
3768 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
3769 earlier.
3770
3771 2019-08-20 Tom Tromey <tom@tromey.com>
3772
3773 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
3774
3775 2019-08-20 Tom Tromey <tom@tromey.com>
3776
3777 * tui/tui-source.h (struct tui_source_window): Update.
3778 * tui/tui-regs.c (tui_show_registers): Update.
3779 * tui/tui-disasm.h (struct tui_disasm_window): Update.
3780 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
3781 (NO_REGS_STRING): Remove defines.
3782
3783 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
3784
3785 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
3786 unnecessary thread walk if remote doesn't support the packet.
3787
3788 2019-08-19 Tom Tromey <tromey@adacore.com>
3789
3790 * python/py-value.c (value_has_field): Fix indentation.
3791
3792 2019-08-19 Tom Tromey <tromey@adacore.com>
3793
3794 * printcmd.c (do_one_display, info_display_command): Update.
3795 * block.h (contained_in): Return bool. Add allow_nested
3796 parameter.
3797 * block.c (contained_in): Return bool. Add allow_nested
3798 parameter.
3799
3800 2019-08-19 Tom Tromey <tom@tromey.com>
3801
3802 * configure: Rebuild.
3803 * configure.ac: Disallow the combination of -static-libstdc++ and
3804 source highlight.
3805 * source-cache.c (get_language_name): Handle rust.
3806 (source_cache::get_source_lines): Ignore highlighting exceptions.
3807
3808 2019-08-16 Tom Tromey <tom@tromey.com>
3809
3810 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
3811 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
3812 (struct tui_source_window_base) <make_visible, refresh_window,
3813 resize>: Remove methods.
3814 <execution_info>: Remove field.
3815 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
3816 (tui_show_source_line, tui_source_window_base)
3817 (~tui_source_window_base): Update.
3818 (tui_source_window_base::resize)
3819 (tui_source_window_base::make_visible)
3820 (tui_source_window_base::refresh_window): Remove.
3821 (tui_source_window_base::update_exec_info): Update.
3822 * tui/tui-source.c (tui_source_window::set_contents): Update.
3823 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3824
3825 2019-08-16 Tom Tromey <tom@tromey.com>
3826
3827 * tui/tui-hooks.c (tui_remove_hooks): Don't set
3828 deprecated_query_hook.
3829
3830 2019-08-16 Tom Tromey <tom@tromey.com>
3831
3832 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
3833 (tui_update_source_windows_with_line): Update.
3834 * tui/tui-source.h (struct tui_source_window)
3835 <show_symtab_source>: Declare.
3836 (tui_show_symtab_source): Don't declare.
3837 * tui/tui-source.c (tui_show_symtab_source): Rename from
3838 tui_show_symtab_source.
3839
3840 2019-08-16 Tom Tromey <tom@tromey.com>
3841
3842 * tui/tui-winsource.h (struct tui_source_window_base)
3843 <set_contents>: Declare.
3844 * tui/tui-winsource.c
3845 (tui_source_window_base::update_source_window_as_is): Update.
3846 * tui/tui-source.h (struct tui_source_window) <set_contents>:
3847 Declare.
3848 (tui_set_source_content): Don't declare.
3849 * tui/tui-source.c (tui_source_window::set_contents): Rename from
3850 tui_set_source_content.
3851 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
3852 Declare.
3853 (tui_set_disassem_content): Don't declare.
3854 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
3855 tui_set_disassem_content.
3856
3857 2019-08-16 Tom Tromey <tom@tromey.com>
3858
3859 * tui/tui-winsource.h (struct tui_source_window_base)
3860 <update_breakpoint_info>: Declare.
3861 (tui_update_breakpoint_info): Don't declare.
3862 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
3863 (tui_update_all_breakpoint_info): Update.
3864 (tui_source_window_base::update_breakpoint_info): Rename from
3865 tui_update_breakpoint_info.
3866 (tui_source_window_base::update_exec_info): Update.
3867
3868 2019-08-16 Tom Tromey <tom@tromey.com>
3869
3870 * tui/tui-winsource.h (struct tui_source_window_base)
3871 <update_source_window>: Declare.
3872 (tui_update_source_window): Don't declare.
3873 * tui/tui-winsource.c
3874 (tui_source_window_base::update_source_window): Rename from
3875 tui_update_source_window.
3876 (tui_source_window_base::rerender): Update.
3877 * tui/tui-source.c (tui_source_window::maybe_update): Update.
3878 * tui/tui-disasm.c (tui_show_disassem)
3879 (tui_show_disassem_and_update_source)
3880 (tui_disasm_window::maybe_update): Update.
3881
3882 2019-08-16 Tom Tromey <tom@tromey.com>
3883
3884 * tui/tui-winsource.h (struct tui_source_window_base)
3885 <update_source_window_as_is>: Declare.
3886 (tui_update_source_window_as_is): Don't declare.
3887 * tui/tui-winsource.c (tui_update_source_window): Update
3888 (tui_source_window_base::update_source_window_as_is): Rename from
3889 tui_update_source_window_as_is.
3890 (tui_source_window_base::refill): Update.
3891 * tui/tui-source.c (tui_show_symtab_source): Update.
3892 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
3893 Update.
3894
3895 2019-08-16 Tom Tromey <tom@tromey.com>
3896
3897 * tui/tui-winsource.h (tui_update_source_window)
3898 (tui_update_source_window_as_is): Remove "noerror" parameter.
3899 * tui/tui-winsource.c (tui_update_source_window)
3900 (tui_update_source_window_as_is): Remove "noerror" parameter.
3901 (tui_update_source_windows_with_addr)
3902 (tui_update_source_windows_with_line)
3903 (tui_source_window_base::rerender)
3904 (tui_source_window_base::refill): Update.
3905 * tui/tui-source.h (tui_set_source_content)
3906 (tui_show_symtab_source): Remove "noerror" parameter.
3907 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
3908 parameter.
3909 (tui_show_symtab_source): Likewise.
3910 (tui_source_window::maybe_update): Update.
3911 * tui/tui-disasm.c (tui_show_disassem)
3912 (tui_show_disassem_and_update_source)
3913 (tui_disasm_window::do_scroll_vertical)
3914 (tui_disasm_window::maybe_update): Update.
3915
3916 2019-08-16 Tom Tromey <tom@tromey.com>
3917
3918 * tui/tui.c (tui_is_window_visible): Update.
3919 * tui/tui-wingeneral.c (tui_make_window)
3920 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
3921 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
3922 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
3923 (tui_set_win_height_command, parse_scrolling_args): Update.
3924 * tui/tui-source.c (tui_source_window::style_changed): Update.
3925 * tui/tui-regs.c (tui_show_registers)
3926 (tui_data_window::first_data_item_displayed)
3927 (tui_data_window::delete_data_content_windows)
3928 (tui_check_register_values, tui_reg_command): Update.
3929 * tui/tui-disasm.c (tui_show_disassem): Update.
3930 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
3931 method.
3932 <is_visible>: Remove field.
3933 * tui/tui-data.c (tui_next_win, tui_prev_win)
3934 (tui_delete_invisible_windows): Update.
3935
3936 2019-08-16 Tom Tromey <tom@tromey.com>
3937
3938 * tui/tui-winsource.h (struct tui_source_window_base)
3939 <m_has_locator>: Remove.
3940 * tui/tui-layout.c (show_source_disasm_command, show_data)
3941 (show_source_or_disasm_and_command): Update.
3942
3943 2019-08-16 Alan Hayward <alan.hayward@arm.com>
3944
3945 * NEWS (Other MI changes): New subsection.
3946 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
3947 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
3948 * arch-utils.c (default_get_pc_address_flags): New function.
3949 * arch-utils.h (default_get_pc_address_flags): New declaration.
3950 * gdbarch.sh: Add get_pc_address_flags.
3951 * gdbarch.c: Regenerate.
3952 * gdbarch.h: Likewise.
3953 * stack.c (print_pc): New function.
3954 (print_frame_info) (print_frame): Call print_pc.
3955
3956 2019-08-16 Tom de Vries <tdevries@suse.de>
3957
3958 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
3959 print_objfile_section_info.
3960
3961 2019-08-15 Tom Tromey <tom@tromey.com>
3962
3963 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
3964 calling update_cmdwin_start_line.
3965 * tui/tui-winsource.h (struct tui_source_window_base)
3966 <do_make_visible_with_new_height, set_new_height>: Don't declare.
3967 <rerender>: Declare.
3968 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
3969 Call rerender.
3970 (tui_source_window_base::set_new_height): Remove.
3971 (tui_source_window_base::rerender): Rename from
3972 do_make_visible_with_new_height.
3973 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
3974 resize method.
3975 (tui_win_info::make_invisible_and_set_new_height)
3976 (tui_win_info::make_visible_with_new_height): Remove.
3977 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
3978 Declare.
3979 * tui/tui-stack.c (tui_locator_window::rerender): New method.
3980 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
3981 do_make_visible_with_new_height>: Don't declare.
3982 <rerender>: Declare.
3983 * tui/tui-regs.c (tui_data_window::rerender): Rename from
3984 set_new_height.
3985 (tui_data_window::do_make_visible_with_new_height): Remove.
3986 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
3987 call tui_show_locator_content.
3988 (tui_gen_win_info::resize): Call rerender.
3989 (show_source_or_disasm_and_command): Don't call
3990 tui_show_locator_content.
3991 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
3992 method.
3993 (struct tui_win_info) <rerender>: Declare.
3994 <set_new_height, make_invisible_and_set_new_height,
3995 make_visible_with_new_height>: Don't declare.
3996 * tui/tui-data.c (tui_win_list::rerender): New method.
3997 * tui/tui-command.h (struct tui_cmd_window)
3998 <do_make_visible_with_new_height>: Don't declare.
3999 * tui/tui-command.c
4000 (tui_cmd_window::do_make_visible_with_new_height): Remove.
4001
4002 2019-08-15 Tom Tromey <tromey@adacore.com>
4003
4004 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4005 * ada-lang.c (ada_enum_name): Likewise.
4006
4007 2019-08-15 Christian Biesinger <cbiesinger@google.com>
4008
4009 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4010 leading underscore.
4011 (GdbOutputErrorFile): Likewise.
4012 (global scope): Adjust constructor calls to GdbOutput{,Error}File
4013 accordingly.
4014 (execute_unwinders): Rename to have a leading underscore.
4015 (auto_load_packages): Likewise.
4016 (global scope): Adjust call to auto_load_packages accordingly.
4017 (GdbSetPythonDirectory): Likewise.
4018 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4019 instead of execute_unwinders.
4020
4021 2019-08-15 Tom Tromey <tom@tromey.com>
4022
4023 * tui/tui-layout.c (show_layout, show_source_disasm_command)
4024 (show_data): Don't change window visibility.
4025 (tui_gen_win_info::resize): Remove special case for command
4026 window. Use wresize, when available.
4027 (show_source_or_disasm_and_command): Don't change window
4028 visibility.
4029 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4030 <make_visible>: New method.
4031 * tui/tui-command.c (tui_cmd_window::resize): New method.
4032
4033 2019-08-15 Tom Tromey <tom@tromey.com>
4034
4035 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4036 (struct tui_source_windows): New.
4037 * tui/tui-winsource.c (tui_display_main): Update.
4038 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4039 (new_height_ok, parse_scrolling_args): Update.
4040 * tui/tui-layout.c (show_layout, show_data): Update.
4041 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4042 (tui_add_to_source_windows): Don't declare.
4043 * tui/tui-data.c (source_windows, tui_source_windows)
4044 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4045
4046 2019-08-15 Tom Tromey <tom@tromey.com>
4047
4048 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4049 Rename from reset.
4050 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4051 * tui/tui-layout.c (show_source_disasm_command, show_data):
4052 Update.
4053 (tui_gen_win_info::resize): Rename.
4054 (show_source_or_disasm_and_command): Update.
4055 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4056 reset.
4057
4058 2019-08-15 Tom Tromey <tom@tromey.com>
4059
4060 * tui/tui-stack.c (tui_initialize_static_data): Remove.
4061 * tui/tui-interp.c (tui_interp::init): Don't call
4062 tui_initialize_static_data.
4063 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4064
4065 2019-08-15 Tom Tromey <tom@tromey.com>
4066
4067 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4068 examine tui_win_list.
4069
4070 2019-08-15 Tom Tromey <tom@tromey.com>
4071
4072 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4073 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4074 tui_clear_source_content.
4075 (tui_clear_source_content): Remove.
4076 (tui_source_window_base::do_erase_source_content): Hoist call to
4077 content.clear().
4078 * tui/tui-stack.c (tui_show_frame_info): Don't call
4079 tui_clear_source_content.
4080
4081 2019-08-15 Tom Tromey <tom@tromey.com>
4082
4083 * tui/tui-winsource.h (struct tui_source_window_base)
4084 <do_erase_source_content>: New method.
4085 <erase_source_content>: New method.
4086 (tui_erase_source_content): Don't declare.
4087 * tui/tui-winsource.c (tui_clear_source_content): Update.
4088 (tui_source_window_base::do_erase_source_content): Rename from
4089 tui_erase_source_content.
4090 (tui_source_window_base::show_source_content): Update.
4091 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4092 * tui/tui-source.h (struct tui_source_window)
4093 <erase_source_content>: New method.
4094 * tui/tui-disasm.h (struct tui_disasm_window)
4095 <erase_source_content>: New method.
4096
4097 2019-08-15 Tom Tromey <tom@tromey.com>
4098
4099 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4100 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4101 constructor.
4102 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4103 * tui/tui-source.c (tui_set_source_content): Update.
4104 * tui/tui-disasm.c (tui_set_disassem_content): Update.
4105
4106 2019-08-15 Tom Tromey <tom@tromey.com>
4107
4108 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4109 * tui/tui-winsource.c (tui_line_is_displayed): Move to
4110 tui-source.c.
4111 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4112 Declare.
4113 * tui/tui-source.c (tui_source_window::line_is_displayed): New
4114 method.
4115 (tui_source_window::maybe_update): Update.
4116
4117 2019-08-15 Tom Tromey <tom@tromey.com>
4118
4119 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4120 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4121 tui-disasm.c.
4122 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4123 Declare.
4124 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4125 method.
4126 (tui_disasm_window::maybe_update): Update.
4127
4128 2019-08-15 Tom Tromey <tom@tromey.com>
4129
4130 * tui/tui-winsource.h (struct tui_source_window_base)
4131 <maybe_update>: Declare.
4132 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4133 method.
4134 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4135 Declare.
4136 * tui/tui-source.c (tui_source_window::maybe_update): New method.
4137 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4138 Declare.
4139 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4140
4141 2019-08-15 Tom Tromey <tom@tromey.com>
4142
4143 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4144
4145 2019-08-15 Tom Tromey <tom@tromey.com>
4146
4147 * tui/tui-wingeneral.c: Include tui-stack.h.
4148 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4149 (struct tui_locator_window): Move from tui-data.h.
4150 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4151 (tui_initialize_static_data): Move from tui-data.c.
4152 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4153 (struct tui_locator_window): Move to tui-stack.c.
4154 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4155 (tui_initialize_static_data): Move to tui-stack.c.
4156
4157 2019-08-15 Tom Tromey <tom@tromey.com>
4158
4159 * tui/tui-layout.c (show_source_disasm_command)
4160 (show_source_or_disasm_and_command): Use make_visible method, not
4161 tui_make_window.
4162 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4163 Remove.
4164
4165 2019-08-15 Tom Tromey <tom@tromey.com>
4166
4167 * tui/tui-wingeneral.h (tui_make_window): Update.
4168 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4169 parameter.
4170 (tui_gen_win_info::make_visible): Update.
4171 * tui/tui-regs.c (tui_data_window::display_registers_from):
4172 Update.
4173 * tui/tui-layout.c (show_source_disasm_command)
4174 (show_source_or_disasm_and_command): Update.
4175 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4176 (enum tui_box): Remove.
4177 (struct tui_win_info) <can_box>: New method.
4178 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4179 method.
4180
4181 2019-08-15 Tom de Vries <tdevries@suse.de>
4182
4183 * linux-nat-trad.c: Include gdbarch.h.
4184
4185 2019-08-14 Alan Hayward <alan.hayward@arm.com>
4186
4187 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4188 register sizes.
4189
4190 2019-08-14 Tom Tromey <tromey@adacore.com>
4191
4192 * darwin-nat.c: Include gdbarch.h.
4193 * darwin-nat-info.c: Include gdbarch.h.
4194
4195 2019-08-13 Tom Tromey <tom@tromey.com>
4196
4197 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4198 Remove.
4199 * tui/tui-data.c (tui_initialize_static_data): Update.
4200
4201 2019-08-13 Tom Tromey <tom@tromey.com>
4202
4203 * tui/tui-winsource.h (struct tui_exec_info_window)
4204 <~tui_exec_info_window, maybe_allocate_content, get_content,
4205 m_content>: Remove.
4206 (struct tui_source_window_base) <set_exec_info_content,
4207 show_exec_info_content>: Don't declare.
4208 * tui/tui-winsource.c
4209 (tui_exec_info_window::maybe_allocate_content): Remove.
4210 (tui_source_window_base::update_exec_info): Rename from
4211 set_exec_info_content.
4212 (tui_source_window_base::show_exec_info_content)
4213 (tui_source_window_base::update_exec_info): Remove.
4214
4215 2019-08-13 Tom Tromey <tom@tromey.com>
4216
4217 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4218 declare.
4219 * tui/tui-winsource.c (tui_update_source_window_as_is)
4220 (tui_update_source_windows_with_addr, tui_erase_source_content):
4221 Update.
4222 (tui_clear_exec_info_content): Remove.
4223
4224 2019-08-13 Tom Tromey <tom@tromey.com>
4225
4226 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4227 declare.
4228 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4229 call tui_erase_exec_info_content.
4230 (tui_clear_exec_info_content): Rename from
4231 tui_erase_exec_info_content.
4232 (tui_clear_exec_info_content): Delete.
4233
4234 2019-08-13 Tom Tromey <tom@tromey.com>
4235
4236 * tui/tui-winsource.h (struct tui_source_window_base)
4237 <show_exec_info_content>: Declare.
4238 (tui_show_exec_info_content): Don't declare.
4239 * tui/tui-winsource.c
4240 (tui_source_window_base::show_exec_info_content): Rename from
4241 tui_show_exec_info_content.
4242 (tui_source_window_base::update_exec_info): Update.
4243
4244 2019-08-13 Tom Tromey <tom@tromey.com>
4245
4246 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4247 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4248 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4249 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4250 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4251 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4252 ... here.
4253
4254 2019-08-13 Tom Tromey <tom@tromey.com>
4255
4256 * tui/tui-winsource.h (struct tui_source_window_base)
4257 <update_exec_info>: Declare.
4258 (tui_update_exec_info): Don't declare.
4259 * tui/tui-winsource.c (tui_update_source_window_as_is)
4260 (tui_source_window_base::refresh_all)
4261 (tui_update_all_breakpoint_info): Update.
4262 (tui_source_window_base::update_exec_info): Rename from
4263 tui_update_exec_info.
4264 * tui/tui-stack.c (tui_show_frame_info): Update.
4265
4266 2019-08-13 Tom Tromey <tom@tromey.com>
4267
4268 * tui/tui-winsource.h (struct tui_source_window_base)
4269 <set_exec_info_content>: Declare.
4270 (tui_set_exec_info_content): Don't declare.
4271 * tui/tui-winsource.c
4272 (tui_source_window_base::set_exec_info_content): Rename from
4273 tui_set_exec_info_content.
4274 (tui_update_exec_info): Update.
4275
4276 2019-08-13 Tom Tromey <tom@tromey.com>
4277
4278 * tui/tui-winsource.h (struct tui_source_window_base)
4279 <show_source_content>: Declare.
4280 (tui_show_source_content): Don't declare.
4281 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4282 (tui_source_window_base::show_source_content): Rename from
4283 tui_show_source_content.
4284 (tui_source_window_base::refresh_all): Update.
4285 * tui/tui-layout.c (show_source_disasm_command)
4286 (show_source_or_disasm_and_command): Update.
4287
4288 2019-08-13 Tom Tromey <tom@tromey.com>
4289
4290 * tui/tui-winsource.c (tui_erase_source_content)
4291 (tui_show_source_content, tui_source_window_base::refresh_all):
4292 Update.
4293 * tui/tui-wingeneral.h
4294 (tui_check_and_display_highlight_if_needed): Don't declare.
4295 * tui/tui-wingeneral.c
4296 (tui_win_info::check_and_display_highlight_if_needed): Rename from
4297 check_and_display_highlight_if_needed.
4298 * tui/tui-win.c (tui_rehighlight_all)
4299 (tui_win_info::make_visible_with_new_height): Update.
4300 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4301 (tui_data_window::erase_data_content)
4302 (tui_data_window::display_all_data): Update.
4303 * tui/tui-data.h (struct tui_win_info)
4304 <check_and_display_highlight_if_needed>: Declare.
4305
4306 2019-08-13 Tom Tromey <tom@tromey.com>
4307
4308 * tui/tui-win.c (tui_resize_all): Call
4309 tui_delete_invisible_windows.
4310 * tui/tui-layout.c (show_layout): Call
4311 tui_delete_invisible_windows.
4312 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4313 * tui/tui-data.c (tui_delete_invisible_windows): New function.
4314
4315 2019-08-13 Tom Tromey <tom@tromey.com>
4316
4317 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
4318 tui_add_win_to_layout.
4319
4320 2019-08-13 Tom Tromey <tom@tromey.com>
4321
4322 * tui/tui-layout.h (tui_default_win_height): Don't declare.
4323 * tui/tui-layout.c (tui_default_win_height): Now static.
4324
4325 2019-08-13 Tom Tromey <tom@tromey.com>
4326
4327 * tui/tui-layout.c (show_layout): Unify all layout cases into a
4328 single switch.
4329 (show_source_disasm_command, show_source_or_disasm_and_command):
4330 Don't check current layout.
4331
4332 2019-08-13 Tom Tromey <tom@tromey.com>
4333
4334 * tui/tui-wingeneral.c (make_all_visible): Remove.
4335 (tui_make_all_invisible): Simplify.
4336 * tui/tui-layout.c (tui_make_all_invisible): Move from
4337 tui-wingeneral.c; simplify.
4338 (show_layout): Hoist call to tui_make_all_invisible.
4339 (show_data): Don't call tui_make_all_invisible.
4340
4341 2019-08-13 Tom Tromey <tom@tromey.com>
4342
4343 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4344 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4345
4346 2019-08-13 Tom Tromey <tom@tromey.com>
4347
4348 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4349 tui-data.c.
4350 (show_source_disasm_command, show_data)
4351 (show_source_or_disasm_and_command): Don't use
4352 tui_set_current_layout_to.
4353 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4354 * tui/tui-data.c (current_layout, tui_current_layout): Move to
4355 tui-layout.c.
4356 (tui_set_current_layout_to): Remove.
4357
4358 2019-08-13 Tom Tromey <tom@tromey.com>
4359
4360 * tui/tui-layout.c (tui_set_layout): Update.
4361 * tui/tui-data.h (struct tui_layout_def): Remove.
4362 (tui_layout_def): Don't declare.
4363 * tui/tui-data.c (layout_def): Remove.
4364 (tui_layout_def): Remove.
4365
4366 2019-08-13 Tom Tromey <tom@tromey.com>
4367
4368 * tui/tui-winsource.h (struct tui_source_window_base)
4369 <clear_detail>: No longer "override".
4370 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4371 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4372 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4373 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4374 Remove.
4375 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4376
4377 2019-08-13 Tom Tromey <tromey@adacore.com>
4378
4379 * tracepoint.c: Don't include readline.h or history.h.
4380
4381 2019-08-12 Tom Tromey <tom@tromey.com>
4382
4383 * configure: Rebuild.
4384 * configure.ac: Check for readline 7.
4385 * NEWS: Mention readline 7 requirement.
4386 * README: Update.
4387
4388 2019-08-12 Tom Tromey <tom@tromey.com>
4389
4390 * mingw-hdep.c (gdb_select): Remove readline hack.
4391
4392 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
4393
4394 * blockframe.c (find_pc_partial_function): Set *block to nullptr
4395 when the function fails.
4396
4397 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
4398
4399 * s390-tdep.c (s390_type_align): New function.
4400 (s390_gdbarch_init): Set it as type_align gdbarch method.
4401
4402 2019-08-09 Tom de Vries <tdevries@suse.de>
4403
4404 PR gdb/24591
4405 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4406 pc_low with relocation offset.
4407
4408 2019-08-07 Tom Tromey <tromey@adacore.com>
4409
4410 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4411 (print_frame_args): Update.
4412 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
4413 Update.
4414 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4415 * frame.h (struct frame_arg): Add initializers.
4416 <error>: Now a unique_xmalloc_ptr.
4417
4418 2019-08-07 Alan Hayward <alan.hayward@arm.com>
4419
4420 * NEWS: Expand the Pointer Authentication entry.
4421 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
4422 (aarch64_frame_unmask_lr): ... to this.
4423 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
4424 Call aarch64_frame_unmask_lr.
4425 * frame.c (struct frame_info): Add "masked" variable.
4426 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
4427 (fprint_frame): Check for masked pc.
4428 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
4429 declarations.
4430 * python/py-framefilter.c (py_print_frame): Check for masked pc.
4431 * stack.c (print_frame): Check for masked pc.
4432
4433 2019-08-06 Tom Tromey <tom@tromey.com>
4434
4435 * stabsread.c (patch_block_stabs, read_one_struct_field)
4436 (read_enum_type): Use obstack_strndup.
4437 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
4438 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
4439 * dwarf2read.c (guess_full_die_structure_name)
4440 (anonymous_struct_prefix): Use obstack_strndup.
4441 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
4442 * c-exp.y (yylex): Use obstack_strndup.
4443 * ada-exp.y (write_object_renaming, write_ambiguous_var)
4444 (write_var_or_type): Use obstack_strndup.
4445
4446 2019-08-06 Tom Tromey <tom@tromey.com>
4447
4448 * symfile.c (reread_symbols): Use obstack_strdup.
4449 * stabsread.c (read_type): Use obstack_strdup.
4450 * gdb_obstack.h (obstack_strdup): New overload.
4451 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
4452 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
4453 (dwarf2_canonicalize_name): Use obstack_strdup.
4454 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
4455 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
4456 Use obstack_strdup.
4457
4458 2019-08-06 Tom Tromey <tom@tromey.com>
4459
4460 * gdb_obstack.h (obstack_strdup): Define.
4461 * gdb_obstack.c (obstack_strdup): Don't define.
4462
4463 2019-08-06 Tom Tromey <tom@tromey.com>
4464
4465 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
4466 obstack_strdup.
4467 * typeprint.c (typedef_hash_table::find_global_typedef): Use
4468 obstack_strdup.
4469 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
4470 * stabsread.c (common_block_start): Use obstack_strdup.
4471 * objfiles.c (set_objfile_main_name, objfile): Use
4472 obstack_strdup.
4473 * namespace.c (add_using_directive): Use obstack_strdup.
4474 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
4475 * jit.c (finalize_symtab): Use obstack_strdup.
4476 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
4477 (guess_partial_die_structure_name, partial_die_info::fixup)
4478 (dwarf2_name): Use obstack_strdup.
4479 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
4480 obstack_strdup.
4481 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
4482 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
4483 obstack_strdup.
4484 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
4485
4486 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4487
4488 * unittests/help-doc-selftests.c: New file.
4489 * Makefile.in: Add the new file.
4490
4491 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4492
4493 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
4494 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
4495 the full first line, except when FOR_VALUE_PREFIX. In this case,
4496 the trailing '.' is not output, and the first character is uppercased.
4497 (print_help_for_command): Update call to print_doc_line.
4498 (print_doc_of_command): Likewise.
4499 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
4500 * cli/cli-option.c (append_indented_doc): Do not append newline.
4501 (build_help_option): Append newline after first appended_indented_doc
4502 only if a second call is done.
4503 (build_help): Append 2 new lines before each option, except the first
4504 one.
4505 * compile/compile.c (_initialize_compile): Add new lines after
4506 %OPTIONS%, when not at the end of the help.
4507 Change help doc or code
4508 producing the help doc to respect the invariants.
4509 * maint-test-options.c (_initialize_maint_test_options): Likewise.
4510 Also removed the new line after 'Options:', as all other commands
4511 do not put an empty line between 'Options:' and the first option.
4512 * printcmd.c (_initialize_printcmd): Likewise.
4513 * stack.c (_initialize_stack): Likewise.
4514 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
4515 incorrectly telling COMMAND is optional.
4516 * ada-lang.c (_initialize_ada_language): Change help doc or code
4517 producing the help doc to respect the invariants.
4518 * ada-tasks.c (_initialize_ada_tasks): Likewise.
4519 * breakpoint.c (_initialize_breakpoint): Likewise.
4520 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
4521 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
4522 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
4523 * cli/cli-style.c (cli_style_option::add_setshow_commands,
4524 _initialize_cli_style): Likewise.
4525 * corelow.c (core_target_info): Likewise.
4526 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
4527 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
4528 * filesystem.c (_initialize_filesystem): Likewise.
4529 * frame.c (_initialize_frame): Likewise.
4530 * gnu-nat.c (add_task_commands): Likewise.
4531 * infcall.c (_initialize_infcall): Likewise.
4532 * infcmd.c (_initialize_infcmd): Likewise.
4533 * interps.c (_initialize_interpreter): Likewise.
4534 * language.c (_initialize_language): Likewise.
4535 * linux-fork.c (_initialize_linux_fork): Likewise.
4536 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
4537 * maint.c (_initialize_maint_cmds): Likewise.
4538 * memattr.c (_initialize_mem): Likewise.
4539 * printcmd.c (_initialize_printcmd): Likewise.
4540 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
4541 _RegEx): Likewise.
4542 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
4543 * record-btrace.c (_initialize_record_btrace): Likewise.
4544 * record-full.c (_initialize_record_full): Likewise.
4545 * record.c (_initialize_record): Likewise.
4546 * regcache-dump.c (_initialize_regcache_dump): Likewise.
4547 * regcache.c (_initialize_regcache): Likewise.
4548 * remote.c (add_packet_config_cmd, init_remote_threadtests,
4549 _initialize_remote): Likewise.
4550 * ser-tcp.c (_initialize_ser_tcp): Likewise.
4551 * serial.c (_initialize_serial): Likewise.
4552 * skip.c (_initialize_step_skip): Likewise.
4553 * source.c (_initialize_source): Likewise.
4554 * stack.c (_initialize_stack): Likewise.
4555 * symfile.c (_initialize_symfile): Likewise.
4556 * symtab.c (_initialize_symtab): Likewise.
4557 * target-descriptions.c (_initialize_target_descriptions): Likewise.
4558 * top.c (init_main): Likewise.
4559 * tracefile-tfile.c (tfile_target_info): Likewise.
4560 * tracepoint.c (_initialize_tracepoint): Likewise.
4561 * tui/tui-win.c (_initialize_tui_win): Likewise.
4562 * utils.c (add_internal_problem_command): Likewise.
4563 * valprint.c (value_print_option_defs): Likewise.
4564
4565 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
4566
4567 PR build/24886
4568 * configure.ac: Drop enable-libmcheck support.
4569 * configure, config.in: Rebuild.
4570 * libmcheck.m4: Remove.
4571 * acinclude.m4: Don't include it.
4572 * Makefile.in: Don't distribute it.
4573 * top.c (print_gdb_configuration): Don't mention it.
4574
4575 2019-08-06 Tom Tromey <tom@tromey.com>
4576
4577 * utils.c (set_output_style): Sometimes pass stream to
4578 emit_style_escape.
4579 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
4580 * record-btrace.c (btrace_insn_history): Update.
4581 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
4582 method.
4583 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
4584 Update initializers.
4585 <m_uiout>: New field.
4586 <m_di>: Move lower.
4587 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4588 Remove "uiout" parameter.
4589 (dump_insns): Update.
4590 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
4591 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
4592
4593 2019-08-06 Christian Biesinger <cbiesinger@google.com>
4594
4595 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
4596 (error_in_psymtab_expansion): Likewise.
4597 (lookup_symbol_via_quick_fns): Likewise.
4598 (basic_lookup_transparent_type_quick): Likewise.
4599 (basic_lookup_transparent_type_1): Likewise.
4600
4601 2019-08-06 Tom Tromey <tromey@adacore.com>
4602
4603 * source.c (last_source_error): Now bool.
4604 (print_source_lines_base): Make "noprint" bool. Only open
4605 source file when last_source_visited changes.
4606
4607 2019-08-06 Tom Tromey <tromey@adacore.com>
4608
4609 * annotate.c (annotate_source_line): Use g_source_cache.
4610 * source-cache.c (source_cache::get_plain_source_lines): Change
4611 parameters. Populate m_offset_cache.
4612 (source_cache::ensure): New method.
4613 (source_cache::get_line_charpos): New method.
4614 (extract_lines): Move lower. Change parameters.
4615 (source_cache::get_source_lines): Move lower.
4616 * source-cache.h (class source_cache): Update comment.
4617 <get_line_charpos>: New method.
4618 <get_source_lines>: Update comment.
4619 <clear>: Clear m_offset_cache.
4620 <get_plain_source_lines>: Change parameters.
4621 <ensure>: New method
4622 <m_offset_cache>: New member.
4623 * source.c (forget_cached_source_info_for_objfile): Update.
4624 (info_source_command): Use g_source_cache.
4625 (find_source_lines, open_source_file_with_line_charpos): Remove.
4626 (print_source_lines_base, search_command_helper): Use g_source_cache.
4627 * source.h (open_source_file_with_line_charpos): Don't declare.
4628 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
4629 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
4630 Use g_source_cache.
4631
4632 2019-08-06 Tom Tromey <tromey@adacore.com>
4633
4634 * source-cache.c (source_cache::get_plain_source_lines):
4635 Remove "first_line" and "last_line" parameters.
4636 (source_cache::get_source_lines): Cache plain text.
4637 * source-cache.h (class source_cache)
4638 <get_plain_source_lines>: Update.
4639
4640 2019-08-06 Tom Tromey <tromey@adacore.com>
4641
4642 * source-cache.c (extract_lines): No longer a method.
4643 Changed type of parameter. Include final newline.
4644 (selftests::extract_lines_test): New function.
4645 (_initialize_source_cache): Likewise.
4646 * source-cache.h (class source_cache)
4647 <extract_lines>: Don't declare.
4648
4649 2019-08-06 Tom Tromey <tromey@adacore.com>
4650
4651 * breakpoint.c (init_breakpoint_sal): Update.
4652 (breakpoint): Update.
4653 * breakpoint.h (struct breakpoint) <filter>: Now a
4654 unique_xmalloc_ptr.
4655
4656 2019-08-05 Christian Biesinger <cbiesinger@google.com>
4657
4658 * NEWS: Mention dictionary access on blocks.
4659 * python/py-block.c (blpy_getitem): New function.
4660 (block_object_as_mapping): New struct.
4661 (block_object_type): Use new struct for tp_as_mapping field.
4662
4663 2019-08-05 Christian Biesinger <cbiesinger@google.com>
4664
4665 * objfiles.h (objfile): Add a comment describing partial symbols.
4666
4667 2019-08-05 Tom Tromey <tromey@adacore.com>
4668
4669 * compile/compile.c (_initialize_compile): Use _(), not N_().
4670 * thread.c (_initialize_thread): Use _(), not N_().
4671 * stack.c (_initialize_stack): Use _(), not N_().
4672 * printcmd.c (_initialize_printcmd): Use _(), not N_().
4673
4674 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
4675
4676 * dwarf2read.c (struct dw2_symtab_iterator):
4677 <want_specific_block>: Remove.
4678 <block_index>: Change type to gdb::optional.
4679 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
4680 change type of BLOCK_INDEX parameter to gdb::optional.
4681 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
4682 (dw2_lookup_symbol): Don't pass argument for
4683 WANT_SPECIFIC_BLOCK.
4684 (dw2_expand_symtabs_for_function): Don't pass argument for
4685 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
4686 (class dw2_debug_names_iterator)
4687 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
4688 parameter, change BLOCK_INDEX type to gdb::optional.
4689 <m_want_specific_block>: Remove.
4690 <m_block_index>: Change type to gdb::optional.
4691 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
4692 gdb::optional. Re-write in function of gdb::optional.
4693 (dw2_debug_names_lookup_symbol): Don't pass argument for
4694 WANT_SPECIFIC_BLOCK.
4695 (dw2_debug_names_expand_symtabs_for_function): Don't pass
4696 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
4697 BLOCK_INDEX.
4698
4699 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4700
4701 * NEWS: Mention changes to "info sources" command.
4702
4703 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4704
4705 * symtab.c (filename_partial_match_opts): New struct type.
4706 (struct output_source_filename_data): New members
4707 regexp, c_regexp, partial_match.
4708 (output_source_filename): Use new members to decide to print file.
4709 (info_sources_option_defs): New variable.
4710 (make_info_sources_options_def_group, print_info_sources_header,
4711 info_sources_command_completer):
4712 New functions.
4713 (info_sources_command): Read new optional arguments.
4714 (_initialize_symtab): Update info sources help.
4715
4716 2019-08-02 Alexandre Oliva <oliva@adacore.com>
4717
4718 * ada-lang.c (exception_support_info_v0): Renamed from...
4719 (default_exception_support_info): ... this. Create new
4720 definition for v1.
4721 (ada_has_this_exception_support): Look up catch_handlers_sym.
4722 (ada_exception_support_info_sniffer): Try v0 after default.
4723
4724 2019-08-01 Tom Tromey <tromey@adacore.com>
4725
4726 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
4727 gdbarch.h.
4728
4729 2019-08-01 Christian Biesinger <cbiesinger@google.com>
4730
4731 * s12z-tdep.c: Fix include path for s12z-opc.h.
4732
4733 2019-08-01 Alan Hayward <alan.hayward@arm.com>
4734
4735 * NEWS: Require GNU make 3.82.
4736
4737 2019-07-16 Tom Tromey <tom@tromey.com>
4738
4739 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
4740 declare.
4741
4742 2019-07-30 Tom Tromey <tromey@adacore.com>
4743
4744 * block.c (contained_in): Remove BLOCK_FUNCTION check.
4745
4746 2019-07-30 Kevin Buettner <kevinb@redhat.com>
4747
4748 * printcmd.c (print_address_symbolic): Print negative offsets.
4749 (build_address_symbolic): Force signed arithmetic when computing
4750 offset.
4751
4752 2019-07-30 Christian Biesinger <cbiesinger@google.com>
4753
4754 PR/24474: Add a function to lookup static variables.
4755 * NEWS: Mention this new function.
4756 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
4757 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
4758 * python/python.c (python_GdbMethods): Add new function.
4759
4760 2019-07-29 Christian Biesinger <cbiesinger@google.com>
4761
4762 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
4763 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
4764 (objfpy_lookup_static_symbol): New function.
4765 (objfile_object_methods): Add new functions.
4766
4767 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4768
4769 * NEWS: Mention 'set|show print frame-info'. Mention new
4770 'presence' value for 'frame-arguments'. Mention new '-frame-info'
4771 backtrace argument. Mention that python frame filtering code
4772 is now consistent with what 'backtrace' command prints.
4773
4774 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4775
4776 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
4777 comments.
4778 (print_frame_info_auto, print_frame_info_source_line,
4779 print_frame_info_location, print_frame_info_source_and_location,
4780 print_frame_info_location_and_address, print_frame_info_short_location):
4781 New declarations.
4782 (struct frame_print_options): New member print_frame_info.
4783 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
4784 * stack.h (get_user_print_what_frame_info): New declaration.
4785 (frame_show_address): New declaration.
4786 * stack.c (print_frame_arguments_choices): New value 'presence'.
4787 (print_frame_info_auto, print_frame_info_source_line,
4788 print_frame_info_location, print_frame_info_source_and_location,
4789 print_frame_info_location_and_address, print_frame_info_short_location,
4790 print_frame_info_choices, print_frame_info_print_what): New definitions.
4791 (print_frame_args): Only print dots for args if print frame-arguments
4792 is 'presence'.
4793 (frame_print_option_defs): New element for "frame-info".
4794 (get_user_print_what_frame_info): New function.
4795 (frame_show_address): Make non static. Move comment to stack.h.
4796 (print_frame_info_to_print_what): New function.
4797 (print_frame_info): Update comment. Use fp_opts.print_frame_info
4798 to decide what to print.
4799 (backtrace_command_1): Handle the new print_frame_arguments_presence
4800 value.
4801 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
4802 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
4803 (py_print_frame): In non-mi mode, use LOCATION as default for
4804 print_what, similarly to frame information printed directly by
4805 backtrace command. Handle frame-info user option in non MI mode.
4806
4807 2019-07-27 Kevin Buettner <kevinb@redhat.com>
4808
4809 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
4810 Add case for debugging 32-bit target on 64-bit host. Revise
4811 comment.
4812
4813 2019-07-27 Kevin Buettner <kevinb@redhat.com>
4814
4815 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
4816 instead of find_function_entry_range_from_pc.
4817
4818 2019-07-27 Kevin Buettner <kevinb@redhat.com>
4819
4820 * stack.c (find_frame_funname): Remove code which preferred
4821 minsym over symtab sym in "certain pathological cases".
4822
4823 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
4824 parameter. Change type of "do_demangle" to bool.
4825 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4826 Pass suitable "prefer_sym_over_minsym" flag to
4827 build_address_symbolic(). Don't output "+" for negative offsets.
4828 * printcmd.c (print_address_symbolic): Update invocation of
4829 build_address_symbolic to include a "prefer_sym_over_minsym"
4830 flag.
4831 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
4832 Restrict cases in which use of minimal symbol is preferred to that
4833 of a found symbol. Update comments.
4834
4835 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
4836 for entry pc when entry pc is out of range for that FDE.
4837
4838 2019-07-26 Brian Callahan <bcallah@openbsd.org>
4839
4840 PR gdb/24839:
4841 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
4842 type.
4843
4844 2019-07-25 Christian Biesinger <cbiesinger@google.com>
4845
4846 * python/py-objfile.c (add_separate_debug_file): Fix comment about
4847 this function's Python signature.
4848
4849
4850 2019-07-24 Christian Biesinger <cbiesinger@google.com>
4851
4852 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
4853 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4854 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
4855 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
4856 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
4857
4858
4859 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
4860
4861 * h8300-tdep.c (h8300_register_name_common): New.
4862 h8300_register_name): Use h8300_register_name_common.
4863 (h8300s_register_name): Likewise.
4864 (h8300sx_register_name): Likewise.
4865 (h8300h_register_nam): New.
4866 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
4867
4868
4869 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
4870
4871 * arm-tdep.c (arm_skip_cmse_entry): New function.
4872 (arm_is_sgstubs_section): New function.
4873 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
4874
4875 2019-07-22 Tom Tromey <tom@tromey.com>
4876
4877 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
4878 Don't self-assign.
4879
4880 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
4881
4882 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
4883 type_print.
4884
4885 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
4886
4887 * symtab.c (search_symbols): Adjust msymbol matching type arrays
4888 so that GDB doesn't match any msymbols when searching in the
4889 TYPES_DOMAIN.
4890 (print_symbol_info): Print using typedef_print or type_print based
4891 on the type of the symbol. Add updated FIXME comment moved from...
4892 (_initialize_symtab): ... move and update FIXME comment to above.
4893
4894 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
4895
4896 * NEWS: Mention adding -q option to "info types".
4897 * symtab.c (struct info_types_options): New struct.
4898 (info_types_options_defs): New variable.
4899 (make_info_types_options_def_group): New function.
4900 (info_types_command): Use gdb::option framework to parse options.
4901 (info_types_command_completer): New function.
4902 (_initialize_symtab): Extend the help text on "info types" and
4903 register command completer.
4904
4905 2019-07-21 Christian Biesinger <cbiesinger@google.com>
4906
4907 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
4908 (lookup_symbol_in_objfile): Change int to block_enum and add a
4909 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
4910
4911 2019-07-20 Christian Biesinger <cbiesinger@google.com>
4912
4913 * MAINTAINERS (Write After Approval): Add self.
4914
4915 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
4916
4917 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
4918 instruction to the dummy code region.
4919
4920 2019-07-19 Tom Tromey <tromey@adacore.com>
4921
4922 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
4923 (ARGSUSED, PARAMS, __func__): Remove rules.
4924
4925 2019-07-19 Alan Hayward <alan.hayward@arm.com>
4926
4927 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
4928 * features/arm/arm-with-iwmmxt.c: Remove.
4929 * features/arm/arm-with-iwmmxt.xml: Remove.
4930 * features/arm/arm-with-m-fpa-layout.c: Remove.
4931 * features/arm/arm-with-m-fpa-layout.xml: Remove.
4932 * features/arm/arm-with-m-vfp-d16.c: Remove.
4933 * features/arm/arm-with-m-vfp-d16.xml: Remove.
4934 * features/arm/arm-with-m.c: Remove.
4935 * features/arm/arm-with-m.xml: Remove.
4936 * features/arm/arm-with-neon.c: Remove.
4937 * features/arm/arm-with-neon.xml: Remove.
4938 * features/arm/arm-with-vfpv2.c: Remove.
4939 * features/arm/arm-with-vfpv2.xml: Remove.
4940 * features/arm/arm-with-vfpv3.c: Remove.
4941 * features/arm/arm-with-vfpv3.xml: Remove.
4942
4943 2019-07-19 Alan Hayward <alan.hayward@arm.com>
4944
4945 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
4946
4947 2019-07-19 Alan Hayward <alan.hayward@arm.com>
4948
4949 * arch/aarch32.c (aarch32_create_target_description): Create
4950 target descriptions using features.
4951 * arch/arm.c (arm_create_target_description)
4952 (arm_create_mprofile_target_description): Likewise.
4953 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
4954
4955 2019-07-19 Alan Hayward <alan.hayward@arm.com>
4956
4957 * Makefile.in: Add new files.
4958 * aarch32-tdep.c: New file.
4959 * aarch32-tdep.h: New file.
4960 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4961 Call aarch32_read_description.
4962 * arch/aarch32.c: New file.
4963 * arch/aarch32.h: New file.
4964 * arch/arm.c (arm_create_target_description)
4965 (arm_create_mprofile_target_description): New function.
4966 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
4967 (arm_create_target_description)
4968 (arm_create_mprofile_target_description): New declaration.
4969 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
4970 read_description functions.
4971 * arm-linux-nat.c (arm_linux_nat_target::read_description):
4972 Likewise.
4973 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4974 * arm-tdep.c (tdesc_arm_list): New variable.
4975 (arm_register_g_packet_guesses): Call create description functions.
4976 (arm_read_description) (arm_read_mprofile_description): New
4977 function.
4978 * arm-tdep.h (arm_read_description)
4979 (arm_read_mprofile_description): Add declaration.
4980 * configure.tgt: Add new files.
4981
4982 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
4983
4984 * top.c (new_ui_command): Open specified terminal just once.
4985
4986 2019-07-18 Tom Tromey <tromey@adacore.com>
4987
4988 * symtab.c (main_name): Constify return type.
4989 * symfile.c (set_initial_language): Update.
4990 * symtab.h (main_name): Constify return type.
4991
4992 2019-07-17 Tom Tromey <tom@tromey.com>
4993
4994 * tui/tui-winsource.c (tui_update_source_window)
4995 (tui_update_source_window_as_is)
4996 (tui_update_source_windows_with_line): Remove return.
4997 * tui/tui-disasm.c (tui_show_disassem)
4998 (tui_show_disassem_and_update_source): Remove return.
4999 * tui/tui.c (tui_reset): Remove return.
5000 * tui/tui-wingeneral.c
5001 (tui_check_and_display_highlight_if_needed): Remove return.
5002
5003 2019-07-17 Tom Tromey <tom@tromey.com>
5004
5005 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5006
5007 2019-07-17 Tom Tromey <tom@tromey.com>
5008
5009 * tui/tui-winsource.h (struct tui_exec_info_window)
5010 (struct tui_source_window_base): Move from tui-data.h.
5011 * tui/tui-winsource.c: Move many method definitions from
5012 elsewhere. Remove "structuring" comments.
5013 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5014 (tui_source_window_base::refresh_window): Move to
5015 tui-winsource.c.
5016 * tui/tui-win.c (tui_source_window_base::refresh_all)
5017 (tui_source_window_base::update_tab_width)
5018 (tui_source_window_base::set_new_height)
5019 (tui_source_window_base::do_make_visible_with_new_height): Move to
5020 tui-winsource.c.
5021 * tui/tui-source.h: Update.
5022 * tui/tui-source.c (tui_source_window_base::reset): Move to
5023 tui-winsource.c.
5024 * tui/tui-disasm.h: Update.
5025 * tui/tui-data.h (struct tui_exec_info_window): Move to
5026 tui-winsource.h.
5027 (struct tui_source_window_base): Likewise.
5028 * tui/tui-data.c (tui_source_window_base::clear_detail)
5029 (tui_source_window_base, ~tui_source_window_base): Move to
5030 tui-winsource.c.
5031
5032 2019-07-17 Tom Tromey <tom@tromey.com>
5033
5034 * tui/tui-win.c (tui_resize_all)
5035 (tui_source_window_base::update_tab_width)
5036 (tui_adjust_win_heights): Update.
5037 (tui_win_info::make_invisible_and_set_new_height): Rename from
5038 make_invisible_and_set_new_height.
5039 * tui/tui-data.h (struct tui_win_info)
5040 <make_invisible_and_set_new_height>: New method.
5041
5042 2019-07-17 Tom Tromey <tom@tromey.com>
5043
5044 * tui/tui.c: Update.
5045 * tui/tui-source.h (struct tui_source_window): Move from
5046 tui-data.h.
5047 * tui/tui-layout.c: Update.
5048 * tui/tui-disasm.c: Update.
5049 * tui/tui-data.h (struct tui_source_window): Move to
5050 tui-source.h.
5051
5052 2019-07-17 Tom Tromey <tom@tromey.com>
5053
5054 * tui/tui-disasm.h (struct tui_disasm_window): Move from
5055 tui-data.h.
5056 * tui/tui-data.h (struct tui_disasm_window): Move to
5057 tui-disasm.h.
5058
5059 2019-07-17 Tom Tromey <tom@tromey.com>
5060
5061 * tui/tui-regs.h (struct tui_data_item_window): Move from
5062 tui-data.h.
5063 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5064 * tui/tui-data.h (struct tui_data_item_window): Move to
5065 tui-regs.h.
5066 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5067
5068 2019-07-17 Tom Tromey <tom@tromey.com>
5069
5070 * tui/tui.c: Update.
5071 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5072 (tui_cmd_window::max_height): Move to tui-command.c.
5073 * tui/tui-layout.c: Update.
5074 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5075 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5076 tui-command.c.
5077 * tui/tui-command.h (struct tui_cmd_window): Move from
5078 tui-data.h.
5079 * tui/tui-command.c: Remove "structuring" comments.
5080 (tui_cmd_window::clear_detail)
5081 (tui_cmd_window::do_make_visible_with_new_height)
5082 (tui_cmd_window::max_height): Move from elsewhere.
5083
5084 2019-07-17 Tom Tromey <tom@tromey.com>
5085
5086 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5087 Now static.
5088 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5089 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5090
5091 2019-07-17 Tom Tromey <tom@tromey.com>
5092
5093 * tui/tui.c: Update.
5094 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5095 tui-regs.c.
5096 * tui/tui-windata.h: Remove file.
5097 * tui/tui-windata.c: Remove file.
5098 * tui/tui-win.c (tui_data_window::set_new_height)
5099 (tui_data_window::do_make_visible_with_new_height): Move to
5100 tui-regs.c.
5101 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5102 * tui/tui-regs.c: Remove "structuring" comments.
5103 (tui_data_window::first_data_item_displayed)
5104 (tui_data_window::delete_data_content_windows)
5105 (tui_data_window::erase_data_content)
5106 (tui_data_window::display_all_data)
5107 (tui_data_window::refresh_all)
5108 (tui_data_window::do_scroll_vertical)
5109 (tui_data_window::clear_detail, tui_data_window::set_new_height)
5110 (tui_data_window::do_make_visible_with_new_height)
5111 (tui_data_window::refresh_window): Move from elsewhere.
5112 (_initialize_tui_regs): Move to end of file.
5113 * tui/tui-layout.c: Update.
5114 * tui/tui-hooks.c: Update.
5115 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5116 * tui/tui-data.c (tui_data_window::clear_detail): Move to
5117 tui-regs.c.
5118 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5119
5120 2019-07-17 Tom Tromey <tom@tromey.com>
5121
5122 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5123 seen.
5124
5125 2019-07-17 Tom Tromey <tom@tromey.com>
5126
5127 * tui/tui-win.c (tui_source_window_base::set_new_height)
5128 (tui_source_window_base::do_make_visible_with_new_height): Use
5129 m_has_locator field directly.
5130 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5131 method.
5132 (struct tui_source_window_base) <has_locator>: Likewise.
5133
5134 2019-07-17 Tom Tromey <tom@tromey.com>
5135
5136 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5137 Don't declare.
5138 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5139 Remove.
5140 * tui/tui-win.c (tui_source_window_base::set_new_height)
5141 (tui_source_window_base::set_new_height)
5142 (make_invisible_and_set_new_height)
5143 (tui_source_window_base::do_make_visible_with_new_height)
5144 (tui_source_window_base::do_make_visible_with_new_height):
5145 Update.
5146 * tui/tui-layout.c (show_source_disasm_command, show_data)
5147 (show_source_or_disasm_and_command): Update.
5148 * tui/tui-layout.c (show_layout): Update.
5149
5150 2019-07-17 Tom Tromey <tom@tromey.com>
5151
5152 * tui/tui-layout.c (make_data_window): Remove.
5153 (show_data): Unify creation and re-initialization cases.
5154
5155 2019-07-17 Tom Tromey <tom@tromey.com>
5156
5157 * tui/tui-layout.c (make_source_window, make_disasm_window):
5158 Remove.
5159 (show_data): Unify creation and re-initialization cases.
5160
5161 2019-07-17 Tom Tromey <tom@tromey.com>
5162
5163 * tui/tui-layout.c (make_command_window): Remove.
5164 (show_source_disasm_command, show_source_or_disasm_and_command):
5165 Unify creation and re-initialization cases.
5166
5167 2019-07-17 Tom Tromey <tom@tromey.com>
5168
5169 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5170 creation and re-initialization cases.
5171
5172 2019-07-17 Tom Tromey <tom@tromey.com>
5173
5174 * tui/tui-regs.c (tui_get_register): Return void.
5175
5176 2019-07-17 Tom Tromey <tom@tromey.com>
5177
5178 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5179 Simplify.
5180
5181 2019-07-17 Tom Tromey <tom@tromey.com>
5182
5183 * tui/tui-layout.c (show_source_disasm_command): Simplify window
5184 resetting.
5185
5186 2019-07-17 Tom Tromey <tom@tromey.com>
5187
5188 * tui/tui.h (tui_set_layout_by_name): Don't declare.
5189 * tui/tui-regs.c (tui_reg_layout): New function.
5190 (tui_show_registers, tui_reg_command): Use it.
5191 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5192 (tui_layout_command): Rename from tui_set_layout_by_name. Change
5193 parameters.
5194 (tui_layout_command): Remove.
5195
5196 2019-07-17 Tom Tromey <tom@tromey.com>
5197
5198 * tui/tui-layout.h (tui/tui-layout): Return void.
5199 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
5200
5201 2019-07-17 Tom Tromey <tom@tromey.com>
5202
5203 * tui/tui-layout.c (show_source_disasm_command, show_data):
5204 Update.
5205 (reset_locator): Remove.
5206 (show_source_or_disasm_and_command): Update.
5207
5208 2019-07-17 Tom Tromey <tom@tromey.com>
5209
5210 * tui/tui-source.c (tui_source_window_base::reset): Remove
5211 win_type parameter.
5212 * tui/tui-layout.c (make_command_window, make_source_window)
5213 (make_disasm_window, make_data_window)
5214 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5215 (reset_locator, show_source_or_disasm_and_command): Update.
5216 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5217 win_type parameter.
5218 (struct tui_source_window_base) <reset>: Likewise.
5219
5220 2019-07-17 Tom Tromey <tom@tromey.com>
5221
5222 * tui/tui-layout.c (show_source_disasm_command): Use
5223 reset_locator.
5224 (reset_locator): New function.
5225 (init_and_make_win): Remove.
5226 (show_source_or_disasm_and_command): Use reset_locator.
5227
5228 2019-07-17 Tom Tromey <tom@tromey.com>
5229
5230 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5231 condition.
5232 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5233 Remove condition.
5234 * tui/tui-source.c (tui_source_window_base::reset): New method.
5235 * tui/tui-layout.c (make_command_window): Don't call
5236 init_and_make_win.
5237 (make_source_window, make_disasm_window): Don't call
5238 make_source_or_disasm_window.
5239 (make_data_window): Don't call init_and_make_win. Change calling
5240 convention.
5241 (show_source_disasm_command, show_data): Simplify.
5242 (make_source_or_disasm_window): Remove.
5243 (show_source_or_disasm_and_command): Simplify.
5244 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5245 (struct tui_source_window_base) <reset>: Likewise.
5246 <execution_info>: Remove initializer.
5247 * tui/tui-data.c (tui_source_window_base): Initialize
5248 execution_info.
5249
5250 2019-07-17 Tom Tromey <tom@tromey.com>
5251
5252 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5253 variable.
5254
5255 2019-07-17 Tom Tromey <tom@tromey.com>
5256
5257 * tui/tui.c (tui_rl_other_window): Update.
5258 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5259 superclass method first. Always iterate over regs_content.
5260 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5261 method.
5262 * tui/tui-win.c (tui_set_focus_command): Update.
5263
5264 2019-07-17 Tom Tromey <tom@tromey.com>
5265
5266 * tui/tui-win.c (tui_set_focus_command): Rename from
5267 tui_set_focus. Call tui_enable.
5268 (tui_set_focus_command): Remove.
5269
5270 2019-07-17 Tom Tromey <tom@tromey.com>
5271
5272 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5273 refresh_window.
5274 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5275 touchwin.
5276 (tui_data_window::refresh_window): Call refresh_window on data
5277 items. Always call superclass refresh_window.
5278 (tui_win_info::refresh): Remove.
5279 (tui_source_window_base::refresh_window): Update.
5280 (tui_refresh_all): Update.
5281 * tui/tui-layout.c (show_source_disasm_command): Remove call to
5282 refresh_window.
5283 (show_source_or_disasm_and_command): Likewise.
5284 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5285 (struct tui_source_window_base) <refresh>: Likewise.
5286
5287 2019-07-17 Tom Tromey <tom@tromey.com>
5288
5289 * tui/tui-winsource.c (tui_clear_source_content)
5290 (tui_show_source_content): Update.
5291 * tui/tui-source.c (tui_source_window::showing_source_p): Check
5292 whether content is empty.
5293 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5294 Remove.
5295
5296 2019-07-17 Tom Tromey <tom@tromey.com>
5297
5298 * tui/tui-winsource.c (tui_erase_source_content): Clear the
5299 window's contents.
5300 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5301 * tui/tui-source.c (tui_set_source_content_nil): Remove.
5302
5303 2019-07-17 Tom Tromey <tom@tromey.com>
5304
5305 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5306 (struct tui_data_item_window): Update.
5307
5308 2019-07-17 Tom Tromey <tom@tromey.com>
5309
5310 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5311 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5312 defines.
5313
5314 2019-07-17 Tom Tromey <tom@tromey.com>
5315
5316 * tui/tui-winsource.h (tui_erase_source_content)
5317 (tui_clear_source_content): Remove "display_prompt" parameter.
5318 * tui/tui-winsource.c (tui_update_source_window_as_is)
5319 (tui_update_source_windows_with_addr): Update.
5320 (tui_clear_source_content): Remove "display_prompt" parameter.
5321 (tui_erase_source_content): Likewise. Simplify.
5322 (tui_show_source_content): Update.
5323 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5324 * tui/tui-stack.c (tui_show_frame_info): Update.
5325 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5326 Remove defines.
5327
5328 2019-07-17 Tom Tromey <tom@tromey.com>
5329
5330 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5331 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5332 parameter.
5333 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5334 parameter.
5335
5336 2019-07-17 Tom Tromey <tom@tromey.com>
5337
5338 * tui/tui-winsource.c (tui_clear_source_content)
5339 (tui_show_source_content, tui_show_exec_info_content)
5340 (tui_clear_exec_info_content): Update.
5341 * tui/tui-stack.c (tui_show_locator_content): Update.
5342 (tui_show_frame_info): Update.
5343 * tui/tui-source.h (tui_source_window): Don't declare.
5344 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5345 from tui_source_is_displayed.
5346 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5347 Remove field.
5348 (struct tui_source_window_base) <content_in_use>: New field. Now
5349 bool.
5350 (struct tui_source_window) <showing_source_p>: New method.
5351 (TUI_SRC_WIN): Change cast.
5352 * tui/tui-data.c (tui_initialize_static_data): Update.
5353
5354 2019-07-17 Tom Tromey <tom@tromey.com>
5355
5356 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5357 location_matches_p.
5358 * tui/tui-source.c (tui_source_window::location_matches_p): New
5359 method.
5360 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5361 method.
5362 * tui/tui-data.h (struct tui_source_window_base)
5363 <location_matches_p>: New method.
5364 (struct tui_source_window, struct tui_disasm_window)
5365 <location_matches_p>: Likewise.
5366
5367 2019-07-17 Tom Tromey <tom@tromey.com>
5368
5369 * tui/tui-win.c (tui_set_win_height_command): Rename from
5370 tui_set_win_height.
5371 (tui_set_win_height_command): Remove.
5372
5373 2019-07-17 Tom Tromey <tom@tromey.com>
5374
5375 * tui/tui-source.c (tui_source_window): New constructor. Add
5376 observer.
5377 (~tui_source_window): New destructor.
5378 (tui_source_window::style_changed): New method.
5379 * tui/tui-hooks.c (tui_redisplay_source): Remove.
5380 (tui_attach_detach_observers): Update.
5381 * tui/tui-data.h (struct tui_source_window): Make constructor not
5382 inline. Add destructor.
5383 (struct tui_source_window) <style_changed>: New method.
5384 <m_observable>: New member.
5385
5386 2019-07-17 Tom Tromey <tom@tromey.com>
5387
5388 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5389 * tui/tui-win.c (tui_resize_all): Fix typo.
5390
5391 2019-07-17 Tom Tromey <tom@tromey.com>
5392
5393 * tui/tui-wingeneral.h (tui_refresh_all): Update.
5394 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5395 (tui_refresh_all): Remove "list" parameter. Use foreach.
5396 * tui/tui-win.c (window_name_completer): Use foreach.
5397 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5398 (update_tab_width): Likewise.
5399 * tui/tui-layout.c (show_layout): Update.
5400 * tui/tui-data.h (class tui_window_iterator): New.
5401 (struct all_tui_windows): New.
5402 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5403
5404 2019-07-17 Tom Tromey <tom@tromey.com>
5405
5406 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5407 parameter. Don't reference globals.
5408 (tui_reg_command): Update.
5409
5410 2019-07-17 Tom Tromey <tom@tromey.com>
5411
5412 * tui/tui-regs.c (tui_show_registers): Simplify.
5413
5414 2019-07-17 Tom Tromey <tom@tromey.com>
5415
5416 * tui/tui-regs.c (tui_show_registers): Update.
5417 (tui_show_register_group): Add win_info parameter.
5418
5419 2019-07-17 Tom Tromey <tom@tromey.com>
5420
5421 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
5422 Rename from tui_display_reg_element_at_line.
5423 (tui_data_window::display_registers_from_line): Update.
5424 * tui/tui-data.h (struct tui_data_window)
5425 <display_reg_element_at_line>: New method.
5426
5427 2019-07-17 Tom Tromey <tom@tromey.com>
5428
5429 * tui/tui-regs.h (tui_display_registers_from)
5430 (tui_display_registers_from_line): Don't declare.
5431 * tui/tui-windata.c (tui_data_window::display_all_data)
5432 (tui_data_window::refresh_all)
5433 (tui_data_window::do_scroll_vertical): Update.
5434 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
5435 from tui_display_registers_from.
5436 (tui_display_reg_element_at_line): Update.
5437 (tui_data_window::display_registers_from_line): Rename from
5438 tui_display_registers_from_line.
5439 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
5440 display_registers_from_line>: New methods.
5441
5442 2019-07-17 Tom Tromey <tom@tromey.com>
5443
5444 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
5445 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
5446 from tui_erase_data_content.
5447 (tui_data_window::display_all_data)
5448 (tui_data_window::refresh_all)
5449 (tui_data_window::do_scroll_vertical): Update.
5450 * tui/tui-regs.c (tui_show_registers): Update.
5451 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
5452 New method.
5453
5454 2019-07-17 Tom Tromey <tom@tromey.com>
5455
5456 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
5457 declare.
5458 * tui/tui-windata.c
5459 (tui_data_window::delete_data_content_windows): Rename from
5460 tui_delete_data_content_windows.
5461 (tui_data_window::display_all_data)
5462 (tui_data_window::do_scroll_vertical): Update.
5463 * tui/tui-data.h (struct tui_data_window)
5464 <delete_data_content_windows>: New method.
5465
5466 2019-07-17 Tom Tromey <tom@tromey.com>
5467
5468 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
5469 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
5470
5471 2019-07-17 Tom Tromey <tom@tromey.com>
5472
5473 * tui/tui-windata.h (tui_display_all_data): Don't declare.
5474 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
5475 from tui_display_all_data.
5476 * tui/tui-win.c
5477 (tui_data_window::do_make_visible_with_new_height): Update.
5478 * tui/tui-regs.c (tui_show_registers): Update.
5479 * tui/tui-layout.c (tui_set_layout): Update.
5480 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
5481 method.
5482
5483 2019-07-17 Tom Tromey <tom@tromey.com>
5484
5485 * tui/tui-windata.h (tui_display_data_from): Don't declare.
5486 * tui/tui-windata.c (tui_display_data_from): Remove.
5487 (tui_data_window::refresh_all): Update.
5488
5489 2019-07-17 Tom Tromey <tom@tromey.com>
5490
5491 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
5492 * tui/tui-windata.c (tui_display_data_from_line): Remove.
5493 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
5494 tui_display_registers_from_line.
5495 * tui/tui-regs.h (tui_display_registers_from_line): Update.
5496 * tui/tui-regs.c (tui_display_registers_from_line): Remove
5497 "force_display" parameter.
5498
5499 2019-07-17 Tom Tromey <tom@tromey.com>
5500
5501 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
5502 declare.
5503 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
5504 Rename from tui_first_reg_element_no_inline.
5505 (tui_display_reg_element_at_line)
5506 (tui_display_registers_from_line): Update.
5507 * tui/tui-data.h (struct tui_data_window)
5508 <first_reg_element_no_inline>: New method.
5509
5510 2019-07-17 Tom Tromey <tom@tromey.com>
5511
5512 * tui/tui-windata.c (tui_display_data_from)
5513 (tui_data_window::do_scroll_vertical): Update.
5514 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
5515 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
5516 Rename from tui_line_from_reg_element_no.
5517 (tui_display_registers_from_line): Update.
5518 * tui/tui-data.h (struct tui_data_window)
5519 <line_from_reg_element_no>: New method.
5520
5521 2019-07-17 Tom Tromey <tom@tromey.com>
5522
5523 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
5524 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
5525 tui_last_regs_line_no.
5526 (tui_display_reg_element_at_line)
5527 (tui_display_registers_from_line): Update.
5528 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
5529 method.
5530
5531 2019-07-17 Tom Tromey <tom@tromey.com>
5532
5533 PR tui/24722:
5534 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
5535 (tui_update_breakpoint_info): Add "being_deleted" parameter.
5536 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5537 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
5538 (tui_update_breakpoint_info): Likewise.
5539 * tui/tui-hooks.c (tui_event_create_breakpoint)
5540 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
5541 Update.
5542
5543 2019-07-17 Tom Tromey <tom@tromey.com>
5544
5545 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
5546
5547 2019-07-17 Tom Tromey <tom@tromey.com>
5548
5549 * tui/tui-winsource.c (tui_update_source_window_as_is)
5550 (tui_update_source_windows_with_addr): Update.
5551 * tui/tui-source.h (tui_set_source_content)
5552 (tui_show_symtab_source): Add "win_info" parameter.
5553 * tui/tui-source.c (tui_set_source_content): Add "win_info"
5554 parameter.
5555 (tui_show_symtab_source): Likewise.
5556
5557 2019-07-17 Tom Tromey <tom@tromey.com>
5558
5559 * tui/tui-wingeneral.c
5560 (tui_check_and_display_highlight_if_needed): Check can_highlight.
5561
5562 2019-07-17 Tom Tromey <tom@tromey.com>
5563
5564 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
5565 (struct tui_cmd_window) <can_scroll>: New method.
5566 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
5567 method.
5568
5569 2019-07-17 Tom Tromey <tromey@adacore.com>
5570
5571 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
5572 do_field_signed>: Rename. Change type of "value".
5573 * ui-out.c (ui_out::field_signed): Rename from field_int.
5574 Change type of "value".
5575 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
5576 type of "value".
5577 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
5578 do_field_int. Change type of "value".
5579 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
5580 do_field_int. Change type of "value".
5581 * tracepoint.c (trace_status_mi, tfind_1)
5582 (print_one_static_tracepoint_marker): Update.
5583 * thread.c (print_thread_info_1, print_selected_thread_frame):
5584 Update.
5585 * stack.c (print_frame, print_frame_info): Update.
5586 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
5587 Update.
5588 * source.c (print_source_lines_base): Update.
5589 * skip.c (info_skip_command): Update.
5590 * record-btrace.c (btrace_ui_out_decode_error)
5591 (btrace_call_history_src_line): Update.
5592 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
5593 Update.
5594 * progspace.c (print_program_space): Update.
5595 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
5596 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
5597 do_field_int. Change type of "value".
5598 * mi/mi-out.c (mi_ui_out::do_table_begin)
5599 (mi_ui_out::do_table_header): Update.
5600 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
5601 type of "value".
5602 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
5603 (mi_cmd_data_list_changed_registers, output_register)
5604 (mi_cmd_data_read_memory, mi_load_progress)
5605 (mi_cmd_trace_frame_collected): Update.
5606 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
5607 Update.
5608 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
5609 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
5610 (mi_cmd_var_list_children, varobj_update_one): Update.
5611 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
5612 (mi_cmd_stack_list_args, list_arg_or_local): Update.
5613 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
5614 * inferior.c (print_inferior): Update.
5615 * gdb_bfd.c (print_one_bfd): Update.
5616 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5617 Update.
5618 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
5619 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
5620 do_field_int. Change type of "value".
5621 * cli-out.c (cli_ui_out::do_field_signed): Rename from
5622 do_field_int. Change type of "value".
5623 * breakpoint.c (watchpoint_check, print_breakpoint_location)
5624 (print_one_breakpoint_location, print_it_catch_fork)
5625 (print_one_catch_fork, print_it_catch_vfork)
5626 (print_one_catch_vfork, print_it_catch_solib)
5627 (print_it_catch_exec, print_it_ranged_breakpoint)
5628 (print_mention_watchpoint, print_mention_masked_watchpoint)
5629 (bkpt_print_it, update_static_tracepoint): Update.
5630 * break-catch-throw.c (print_it_exception_catchpoint): Update.
5631 * break-catch-syscall.c (print_it_catch_syscall): Update.
5632 * ada-tasks.c (print_ada_task_info): Update.
5633 * ada-lang.c (print_it_exception, print_mention_exception):
5634 Update.
5635
5636 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
5637
5638 PR breakpoints/24541
5639 * gdbarch.c: Regenerate.
5640 * gdbarch.h: Regenerate.
5641 * gdbarch.sh: Adjust return type and parameter types for
5642 'stap_adjust_register'.
5643 (i386_stap_adjust_register): Adjust signature and return new
5644 register name.
5645 * stap-probe.c (stap_parse_register_operand): Adjust use of
5646 'gdbarch_stap_adjust_register'.
5647
5648 2019-07-17 Tom Tromey <tromey@adacore.com>
5649
5650 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
5651 declare VEC.
5652 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
5653 std::vector.
5654 (struct s390_process_info): Add initializers.
5655 (s390_add_process): Use new.
5656 (s390_linux_nat_target::low_forget_process): Use delete.
5657 (s390_linux_nat_target::low_new_fork)
5658 (s390_linux_nat_target::stopped_by_watchpoint)
5659 (s390_linux_nat_target::low_prepare_to_resume)
5660 (s390_linux_nat_target::insert_watchpoint)
5661 (s390_linux_nat_target::insert_hw_breakpoint)
5662 (s390_linux_nat_target::remove_watchpoint)
5663 (s390_linux_nat_target::remove_hw_breakpoint): Update.
5664
5665 2019-07-16 John Baldwin <jhb@FreeBSD.org>
5666
5667 * aarch64-fbsd-nat.c: Include regcache.h.
5668 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
5669 argument.
5670 (aarch64_fbsd_nat_target::fetch_registers)
5671 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
5672 variable.
5673 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
5674
5675 2019-07-16 John Baldwin <jhb@FreeBSD.org>
5676
5677 * fbsd-nat.c: Include gdbarch.h.
5678
5679 2019-07-15 Tom Tromey <tromey@adacore.com>
5680
5681 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
5682
5683 2019-07-15 Tom Tromey <tromey@adacore.com>
5684
5685 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
5686 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
5687 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
5688 * cli-out.c (cli_ui_out::do_field_int): New method.
5689 * ui-out.c (ui_out::field_unsigned): New method.
5690 * symfile.c (generic_load): Use field_unsigned.
5691 (print_transfer_performance): Likewise.
5692 * record-btrace.c (ui_out_field_uint): Remove.
5693 (btrace_call_history_insn_range, btrace_call_history): Use
5694 field_unsigned.
5695 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
5696 field_unsigned.
5697 * ui-out.h (class ui_out) <field_unsigned>: New method.
5698 <do_field_unsigned>: Likewise.
5699
5700 2019-07-15 Tom Tromey <tromey@adacore.com>
5701
5702 * mi/mi-main.c (list_available_thread_groups): Use field_string.
5703 * mi/mi-interp.c (mi_memory_changed): Use field_string.
5704 * target.c (flash_erase_command): Use field_string.
5705 * infrun.c (print_signal_received_reason): Use field_string.
5706 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
5707 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
5708 field_string.
5709 * ada-tasks.c (print_ada_task_info): Use field_string.
5710
5711 2019-07-15 Tom Tromey <tromey@adacore.com>
5712
5713 * target.c (flash_erase_command): Use field_core_addr.
5714 * symfile.c (generic_load): Use field_core_addr.
5715 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
5716 Use field_core_addr.
5717 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
5718 field_core_addr.
5719
5720 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5721
5722 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
5723 value if its desired type is smaller than a CORE_ADDR and signed.
5724
5725 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5726
5727 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
5728 of changes to field names, and use new is_reference field to
5729 decide if a property is a reference or not.
5730 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
5731 field.
5732 (struct dwarf2_property_baton): Update header comment, rename
5733 'referenced_type' to 'property_type' and update comments.
5734 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
5735 default property type, store in property baton, update to take
5736 accound of renamed field.
5737 (read_func_scope): Update call to attr_to_dynamic_prop.
5738 (read_array_type): Likewise.
5739 (dwarf2_per_cu_addr_sized_int_type): New function.
5740 (read_subrange_index_type): Move type finding code to
5741 dwarf2_per_cu_addr_sized_int_type.
5742 (read_subrange_type): Update calls to attr_to_dynamic_prop.
5743 (dwarf2_per_cu_addr_type): New function.
5744 (set_die_type): Update calls to attr_to_dynamic_prop.
5745
5746 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5747
5748 * dwarf2read.c (read_subrange_index_type): New function.
5749 (read_subrange_type): Move code into new function and call it.
5750 * gdbtypes.c (create_range_type): Add some asserts.
5751
5752 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5753
5754 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
5755 update return statements.
5756 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
5757 declaration, and update comment to match.
5758 * gdbtypes.c (resolve_dynamic_array): Update call to
5759 dwarf2_evaluate_property to match new return type.
5760
5761 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
5762
5763 * valarith.c (value_subscripted_rvalue): Change lowerbound
5764 parameter type from int to LONGEST.
5765 * value.h (value_subscripted_rvalue): Likewise in declaration.
5766
5767 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
5768
5769 * cli/cli-utils.c (info_print_command_completer): New function.
5770 * cli/cli-utils.h: Add 'completer.h' include, and forward
5771 declaration for 'struct cmd_list_element'.
5772 (info_print_command_completer): Declare.
5773 * stack.c (_initialize_stack): Add completer for 'info locals' and
5774 'info args'.
5775 * symtab.c (_initialize_symtab): Add completer for 'info
5776 variables' and 'info functions'.
5777 * NEWS: Mention completion for additional info commands.
5778
5779 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
5780
5781 * cli/cli-utils.c (extract_info_print_args): Delete.
5782 (extract_arg_maybe_quoted): Delete.
5783 (info_print_options_defs): New variable.
5784 (make_info_print_options_def_group): New function.
5785 (extract_info_print_options): Define new function.
5786 * cli/cli-utils.h (extract_info_print_args): Delete.
5787 (struct info_print_options): New structure.
5788 (extract_info_print_options): Declare new function.
5789 * stack.c (info_locals_command): Update to use new
5790 extract_info_print_options, also add a header comment.
5791 (info_args_command): Likewise.
5792 * symtab.c (info_variables_command): Likewise.
5793 (info_functions_command): Likewise.
5794
5795 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
5796
5797 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
5798 to extract string arguments.
5799 * common/common-utils.c (extract_string_maybe_quoted): New function.
5800 * common/common-utils.h (extract_string_maybe_quoted): Declare.
5801
5802 2019-07-11 Tom Tromey <tromey@adacore.com>
5803
5804 * main.c (get_init_files): Use GDBINIT, not gdbinit.
5805 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
5806 * top.h (gdbinit): Don't declare.
5807 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
5808 into...
5809 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
5810 * top.c (gdb_init): Don't call init_cli_cmds.
5811 (gdbinit): Remove.
5812 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
5813
5814 2019-07-11 Tom Tromey <tromey@adacore.com>
5815
5816 * python/py-inferior.c (add_thread_object): Don't use thread_obj
5817 after it has been moved.
5818
5819 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
5820
5821 * valops.c (value_must_coerce_to_target): Change return type to
5822 bool.
5823 * value.h (value_must_coerce_to_target): Likewise.
5824
5825 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
5826
5827 * breakpoint.c (is_hardware_watchpoint): Remove
5828 forward-declaration.
5829 (is_masked_watchpoint): Change return type to bool.
5830 (is_tracepoint): Likewise.
5831 (is_breakpoint): Likewise.
5832 (is_hardware_watchpoint): Likewise.
5833 (is_watchpoint): Likewise.
5834 (is_no_memory_software_watchpoint): Likewise.
5835 (is_catchpoint): Likewise.
5836 (breakpoint_1): Make FILTER parameter's return type bool.
5837 is_masked_watchpoint): Change return type to bool.
5838 (save_breakpoints): Make FILTER parameter's return type bool.
5839 * breakpoint.h (is_breakpoint): Change return type to bool.
5840 (is_watchpoint): Likewise.
5841 (is_catchpoint): Likewise.
5842 (is_tracepoint): Likewise.
5843
5844 2019-07-10 Tom Tromey <tom@tromey.com>
5845
5846 * defs.h: Don't include gdbarch.h.
5847 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
5848 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
5849 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
5850 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
5851 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
5852 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
5853 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
5854 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
5855 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
5856 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
5857 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
5858 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
5859 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
5860 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
5861 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
5862 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
5863 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
5864 record-btrace.c, record.h, regcache-dump.c, regcache.h,
5865 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
5866 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
5867 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
5868 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
5869 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
5870 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
5871 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
5872 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
5873 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
5874
5875 2019-07-10 Tom Tromey <tromey@adacore.com>
5876
5877 * ada-lang.h (is_ada_exception_catchpoint): Declare.
5878 * breakpoint.c (init_ada_exception_breakpoint): Register as
5879 bp_catchpoint.
5880 (print_one_breakpoint_location, print_one_breakpoint): Use
5881 is_ada_exception_catchpoint.
5882 * ada-lang.c (class ada_catchpoint_location): Pass
5883 bp_loc_software_breakpoint to bp_location constructor.
5884 (is_ada_exception_catchpoint): New function.
5885
5886 2019-07-10 Tom Tromey <tromey@adacore.com>
5887
5888 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
5889 VEC.
5890 (struct arm_exidx_entry): New method operator<.
5891 (struct arm_exidx_data) <section_maps>: Change type.
5892 (arm_exidx_data_free): Remove.
5893 (arm_exidx_data_key): Change type. Move lower.
5894 (arm_exidx_new_objfile): Update.
5895 (arm_compare_exidx_entries): Remove.
5896 (arm_find_exidx_entry, _initialize_arm_tdep)
5897
5898 2019-07-10 Tom Tromey <tromey@adacore.com>
5899
5900 * solib-spu.c (ocl_program_data_key): Change type.
5901 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
5902 Update.
5903
5904 2019-07-10 Tom Tromey <tromey@adacore.com>
5905
5906 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
5907 (struct solib_aix_inferior_data) <library_list>: Change type.
5908 (solib_aix_inferior_data_handle): Change type.
5909 (get_solib_aix_inferior_data): Update.
5910 (solib_aix_free_library_list): Remove.
5911 (library_list_start_library): Update.
5912 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
5913 return type.
5914 (solib_aix_get_library_list)
5915 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
5916 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
5917
5918 2019-07-10 Tom Tromey <tromey@adacore.com>
5919
5920 * solib-dsbt.c (struct dsbt_info): Add initializers.
5921 (solib_dsbt_pspace_data): Change type.
5922 (dsbt_pspace_data_cleanup): Remove.
5923 (get_dsbt_info, _initialize_dsbt_solib): Update.
5924
5925 2019-07-10 Tom Tromey <tromey@adacore.com>
5926
5927 * spu-tdep.c (spu_overlay_data): Change type.
5928 (spu_get_overlay_table, spu_overlay_new_objfile)
5929 (_initialize_spu_tdep): Update.
5930
5931 2019-07-10 Tom Tromey <tromey@adacore.com>
5932
5933 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
5934 destructor.
5935 (dbx_objfile_data_key): Change type and declare later.
5936 (DBX_SYMFILE_INFO): Rewrite.
5937 * dbxread.c (dbx_objfile_data_key): Change type.
5938 (dbx_symfile_init): Update.
5939 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
5940 (coffstab_build_psymtabs, elfstab_build_psymtabs)
5941 (stabsect_build_psymtabs, _initialize_dbxread): Update.
5942
5943 2019-07-10 Tom Tromey <tromey@adacore.com>
5944
5945 * jit.c (jit_program_space_key): Change type. Move lower.
5946 (get_jit_program_space_data): Update.
5947 (jit_program_space_data_cleanup): Remove.
5948 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
5949 Update.
5950 (struct jit_program_space_data): Add initializers.
5951
5952 2019-07-10 Tom Tromey <tromey@adacore.com>
5953
5954 * solib-darwin.c (struct darwin_info): Add initializers.
5955 (solib_darwin_pspace_data): Change type.
5956 (darwin_pspace_data_cleanup): Remove.
5957 (get_darwin_info, _initialize_darwin_solib): Update.
5958
5959 2019-07-10 Tom Tromey <tromey@adacore.com>
5960
5961 * remote-sim.c (struct sim_inferior_data): Add initializers,
5962 constructor, and destructor.
5963 (sim_inferior_data_key): Change type. Move lower.
5964 (check_for_duplicate_sim_descriptor): Update.
5965 (get_sim_inferior_data): Use new. Update.
5966 (~sim_inferior_data_cleanup): Rename from
5967 sim_inferior_data_cleanup. Simplify.
5968 (gdbsim_close_inferior, simulator_command)
5969 (sim_command_completer, _initialize_remote_sim): Update.
5970 (next_pid, INITIAL_PID): Move earlier.
5971
5972 2019-07-10 Tom Tromey <tromey@adacore.com>
5973
5974 * python/python-internal.h (create_thread_object): Return
5975 gdbpy_ref.
5976 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
5977 * python/py-inferior.c (struct threadlist_entry): Add
5978 constructor.
5979 <thread_obj>: Now a gdbpy_ref.
5980 (thread_to_thread_object): Update.
5981 (add_thread_object): Use new.
5982 (delete_thread_object): Use delete.
5983 (infpy_threads): Update.
5984 (py_free_inferior): Update. Construct "inf_obj" after acquiring
5985 GIL.
5986
5987 2019-07-10 Tom Tromey <tromey@adacore.com>
5988
5989 * valops.c (value_cast): Specialize error message for Ada.
5990
5991 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
5992
5993 * breakpoint.c (breakpoint_1): Update doc and parameter names.
5994
5995 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
5996
5997 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
5998 bpstat_should_step): Return bool, adjust comments.
5999 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6000 bpstat_should_step): Likewise.
6001
6002 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6003
6004 * features/Makefile: Use feature target descriptions for Arm.
6005 * features/arm/arm-core.c: Generate new file.
6006 * features/arm/arm-fpa.c: Likewise.
6007 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6008 * features/arm/arm-m-profile.c: Likewise.
6009 * features/arm/arm-vfpv2.c: Likewise.
6010 * features/arm/arm-vfpv3.c: Likewise.
6011 * features/arm/xscale-iwmmxt.c: Likewise.
6012 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6013
6014 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6015
6016 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6017 ptrace earlier.
6018
6019 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6020
6021 * features/aarch64-pauth.c: Regenerate.
6022
6023 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
6024
6025 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6026 bool.
6027 (bpstat_what): Use false instead of 0.
6028
6029 2019-07-09 Pedro Alves <palves@redhat.com>
6030
6031 * break-catch-throw.c (is_exception_catchpoint): New.
6032 * breakpoint.c (print_one_breakpoint_location): New parameter
6033 'raw_loc'. Handle it. Use
6034 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6035 looking at the breakpoint's type.
6036 (print_one_breakpoint): If handling "maint info breakpoints", also
6037 print locations of exception catchpoints.
6038 * breakpoint.h (is_exception_catchpoint): Declare.
6039
6040 2019-07-09 Pedro Alves <palves@redhat.com>
6041
6042 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6043 "addr" field.
6044 (allocate_location_exception_catchpoint): New.
6045 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6046 (initialize_throw_catchpoint_ops): Install
6047 allocate_location_exception_catchpoint as allocate_location
6048 method.
6049 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6050 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6051 bp_loc_other.
6052 (breakpoint_address_is_meaningful): Delete.
6053 (bl_address_is_meaningful): New.
6054 (breakpoint_locations_match): Adjust comment.
6055 (bp_location_from_bp_type): New, factored out of...
6056 (bp_location::bp_location(breakpoint *)): ... this.
6057 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6058 factored out of...
6059 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
6060 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6061 breakpoint_address_is_meaningful.
6062 (bp_locations_compare): Adjust comment.
6063 (update_global_location_list): Use bl_address_is_meaningful
6064 instead of breakpoint_address_is_meaningful.
6065 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6066 explicit.
6067 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6068 * python/py-breakpoint.c (bppy_get_location): No longer check
6069 whether location is null.
6070
6071 2019-07-09 Pedro Alves <palves@redhat.com>
6072
6073 PR c++/15468
6074 * breakpoint.c (print_one_breakpoint_location): Remove
6075 single-location assert.
6076
6077 2019-07-09 Tom Tromey <tom@tromey.com>
6078
6079 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6080 * configure: Rebuild.
6081 * configure.ac: Change common to gdbsupport.
6082 * gdbsupport: Rename from common.
6083 * acinclude.m4: Change common to gdbsupport.
6084 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6085 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6086 gdbsupport.
6087 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6088 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6089 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6090 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6091 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6092 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6093 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6094 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6095 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6096 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6097 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6098 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6099 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6100 coff-pe-read.c, command.h, compile/compile-c-support.c,
6101 compile/compile-c.h, compile/compile-cplus-symbols.c,
6102 compile/compile-cplus-types.c, compile/compile-cplus.h,
6103 compile/compile-loc2c.c, compile/compile.c, completer.c,
6104 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6105 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6106 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6107 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6108 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6109 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6110 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6111 features/aarch64-core.c, features/aarch64-fpu.c,
6112 features/aarch64-pauth.c, features/aarch64-sve.c,
6113 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6114 features/i386/32bit-core.c, features/i386/32bit-linux.c,
6115 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6116 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6117 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6118 features/i386/64bit-core.c, features/i386/64bit-linux.c,
6119 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6120 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6121 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6122 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6123 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6124 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6125 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6126 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6127 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6128 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6129 go32-nat.c, guile/guile.c, guile/scm-ports.c,
6130 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6131 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6132 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6133 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6134 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6135 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6136 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6137 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6138 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6139 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6140 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6141 minsyms.c, mips-linux-tdep.c, namespace.h,
6142 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6143 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6144 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6145 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6146 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6147 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6148 nat/linux-waitpid.c, nat/mips-linux-watch.c,
6149 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6150 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6151 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6152 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6153 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6154 procfs.c, producer.c, progspace.h, psymtab.h,
6155 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6156 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6157 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6158 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6159 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6160 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6161 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6162 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6163 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6164 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6165 target-memory.c, target.c, target.h, target/waitstatus.c,
6166 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6167 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6168 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6169 unittests/array-view-selftests.c,
6170 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6171 unittests/common-utils-selftests.c,
6172 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6173 unittests/format_pieces-selftests.c,
6174 unittests/function-view-selftests.c,
6175 unittests/lookup_name_info-selftests.c,
6176 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6177 unittests/mkdir-recursive-selftests.c,
6178 unittests/observable-selftests.c,
6179 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6180 unittests/parse-connection-spec-selftests.c,
6181 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6182 unittests/scoped_fd-selftests.c,
6183 unittests/scoped_mmap-selftests.c,
6184 unittests/scoped_restore-selftests.c,
6185 unittests/string_view-selftests.c, unittests/style-selftests.c,
6186 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6187 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6188 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6189 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6190 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6191 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6192
6193 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6194
6195 * linespec.c (decode_digits_list_mode): Set explicit_line to a
6196 bool value.
6197 (decode_digits_ordinary): Set explicit_line field in sal.
6198 * symtab.c (skip_prologue_sal): Don't skip prologue for a
6199 symtab_and_line that was set on an explicit line number in
6200 assembler code. Do always update the recorded symtab and line if
6201 we do skip the prologue.
6202
6203 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6204
6205 * breakpoint.c (set_breakpoint_location_function): Remove
6206 explicit_loc parameter.
6207 (momentary_breakpoint_from_master): Update call to
6208 set_breakpoint_location_function.
6209 (add_location_to_breakpoint): Likewise.
6210
6211 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
6212
6213 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6214 required features based on default bfd type when no specific bfd
6215 is present.
6216
6217 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6218
6219 * NEWS: Mention that GDB printf and eval commands can now print
6220 C-style and Ada-style convenience var strings without
6221 calling the inferior.
6222 * printcmd.c (printf_c_string): Locally print GDB internal var
6223 instead of transiting via the inferior.
6224 (printf_wide_c_string): Likewise.
6225
6226 2019-07-04 Alan Hayward <alan.hayward@arm.com>
6227
6228 PR breakpoints/25011
6229 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6230
6231 2019-07-04 Tom Tromey <tom@tromey.com>
6232
6233 PR tui/24724:
6234 * tui/tui-winsource.c (tui_clear_source_content): Update.
6235 (tui_source_window_base::set_is_exec_point_at): Fix comment.
6236 (tui_update_breakpoint_info): Update.
6237 (tui_set_exec_info_content): Update.
6238 * tui/tui-source.c (tui_set_source_content_nil): Update.
6239 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6240 has_break.
6241 * tui/tui-data.h (enum tui_bp_flag): New.
6242 (tui_bp_flags): New enum flags type.
6243 (struct tui_source_element) <break_mode>: Change type. Rename
6244 from has_break.
6245 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6246 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
6247 constants.
6248 * tui/tui-winsource.h: Fix comment.
6249
6250 2019-07-04 Alan Hayward <alan.hayward@arm.com>
6251
6252 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6253 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6254 (store_fpregs_to_thread)
6255 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6256 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6257 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6258 (IWMMXT_REGS_SIZE): Add define.
6259 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6260 (fetch_vfp_regs, store_vfp_regs)
6261 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6262 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6263
6264 2019-07-04 Alan Hayward <alan.hayward@arm.com>
6265
6266 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6267 defines.
6268 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6269 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6270 (ARM_INT_REGISTER_SIZE): ...to this.
6271 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6272 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6273 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6274 (arm_linux_collect_gregset, supply_nwfpe_register)
6275 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6276 defines.
6277 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6278 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6279 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6280 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6281 (arm_return_in_memory, arm_store_return_value)
6282 (arm_get_longjmp_target, arm_register_g_packet_guesses)
6283 (arm_record_ld_st_multiple): Likewise.
6284 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6285 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6286
6287 2019-07-04 Alan Hayward <alan.hayward@arm.com>
6288
6289 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6290 AARCH64_DISPLACED_MODIFIED_INSNS.
6291 * aarch64-tdep.c (struct aarch64_displaced_step_data)
6292 (aarch64_displaced_step_copy_insn): Likewise.
6293 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6294 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6295 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6296 ARM_DISPLACED_MODIFIED_INSNS.
6297 * arm-tdep.c (arm_gdbarch_init): Likewise.
6298 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6299 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6300 (struct arm_displaced_step_closure): Use
6301 ARM_DISPLACED_MODIFIED_INSNS.
6302
6303 2019-07-04 Alan Hayward <alan.hayward@arm.com>
6304
6305 * features/Makefile: Remove unused xml files.
6306 * features/aarch64.xml: Remove.
6307 * features/i386/amd64-avx-avx512-linux.xml: Remove.
6308 * features/i386/amd64-avx-avx512.xml: Remove.
6309 * features/i386/amd64-avx-linux.xml: Remove.
6310 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6311 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6312 * features/i386/amd64-avx-mpx-linux.xml: Remove.
6313 * features/i386/amd64-avx-mpx.xml: Remove.
6314 * features/i386/amd64-avx.xml: Remove.
6315 * features/i386/amd64-linux.xml: Remove.
6316 * features/i386/amd64-mpx-linux.xml: Remove.
6317 * features/i386/amd64-mpx.xml: Remove.
6318 * features/i386/amd64.xml: Remove.
6319 * features/i386/i386-avx-avx512-linux.xml: Remove.
6320 * features/i386/i386-avx-avx512.xml: Remove.
6321 * features/i386/i386-avx-linux.xml: Remove.
6322 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6323 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6324 * features/i386/i386-avx-mpx-linux.xml: Remove.
6325 * features/i386/i386-avx-mpx.xml: Remove.
6326 * features/i386/i386-avx.xml: Remove.
6327 * features/i386/i386-linux.xml: Remove.
6328 * features/i386/i386-mmx-linux.xml: Remove.
6329 * features/i386/i386-mmx.xml: Remove.
6330 * features/i386/i386-mpx-linux.xml: Remove.
6331 * features/i386/i386-mpx.xml: Remove.
6332 * features/i386/i386.xml: Remove.
6333 * features/i386/x32-avx-avx512-linux.xml: Remove.
6334 * features/i386/x32-avx-linux.xml: Remove.
6335 * features/i386/x32-linux.xml: Remove.
6336
6337 2019-07-04 Alan Hayward <alan.hayward@arm.com>
6338
6339 * regformats/aarch64.dat: Remove.
6340 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6341 * regformats/i386/amd64-avx-linux.dat: Remove.
6342 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6343 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6344 * regformats/i386/amd64-linux.dat: Remove.
6345 * regformats/i386/amd64-mpx-linux.dat: Remove.
6346 * regformats/i386/amd64.dat: Remove.
6347 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6348 * regformats/i386/i386-avx-linux.dat: Remove.
6349 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6350 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6351 * regformats/i386/i386-linux.dat: Remove.
6352 * regformats/i386/i386-mmx-linux.dat: Remove.
6353 * regformats/i386/i386-mpx-linux.dat: Remove.
6354 * regformats/i386/i386.dat: Remove.
6355 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6356 * regformats/i386/x32-avx-linux.dat: Remove.
6357 * regformats/i386/x32-linux.dat: Remove.
6358
6359 2019-07-04 Alan Hayward <alan.hayward@arm.com>
6360
6361 * aarch64-tdep.c: Remove xml self tests.
6362 * amd64-linux-tdep.c: Likewise.
6363 * amd64-tdep.c: Likewise.
6364 * i386-linux-tdep.c: Likewise.
6365 * i386-tdep.c: Likewise.
6366
6367 2019-07-03 Pedro Alves <palves@redhat.com>
6368
6369 PR cli/24732
6370 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6371 (pipe_cmd_option_defs): New.
6372 (make_pipe_cmd_options_def_group): New.
6373 (pipe_command): Use gdb::option::process_options.
6374 (pipe_command_completer): New function.
6375 (_initialize_cli_cmds): Install completer for "pipe" command.
6376
6377 2019-07-03 Pedro Alves <palves@redhat.com>
6378
6379 * cli/cli-option.c (union option_value) <string>: New field.
6380 (struct option_def_and_value): Add ctor, move ctor, dtor and
6381 use DISABLE_COPY_AND_ASSIGN.
6382 (option_def_and_value::clear_value): New.
6383 (parse_option, save_option_value_in_ctx, get_val_type_str)
6384 (add_setshow_cmds_for_options): Handle var_string.
6385 * cli-option.h (union option_def::var_address) <string>: New
6386 field.
6387 (struct string_option_def): New.
6388 * maint-test-options.c (struct test_options_opts): Add default
6389 ctor and use DISABLE_COPY_AND_ASSIGN.
6390 <string_opt>: New field.
6391 (test_options_opts::~test_options_opts): New.
6392 (test_options_opts::dump): Also dump "-string".
6393 (test_options_option_defs): Install "string.
6394
6395 2019-07-03 Pedro Alves <palves@redhat.com>
6396
6397 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6398 option_value with a null enumeration.
6399 (complete_options): Save the option values in the context.
6400 (save_option_value_in_ctx): New, factored out from ...
6401 (process_options): ... here.
6402 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6403 of the function.
6404 * maint-test-options.c (test_options_opts::dump): New, factored
6405 out from ...
6406 (maintenance_test_options_command_mode): ... here.
6407 (maintenance_test_options_command_completion_result): Delete.
6408 (maintenance_test_options_command_completion_text): Update
6409 comment.
6410 (maintenance_show_test_options_completion_result): Change
6411 prototype. Just print
6412 maintenance_test_options_command_completion_text.
6413 (save_completion_result): New.
6414 (maintenance_test_options_completer_mode): Pass options context to
6415 complete_options, and then save a dump.
6416 (_initialize_maint_test_options): Use add_cmd to install "maint
6417 show test-options-completion-result".
6418
6419 2019-07-03 Pedro Alves <palves@redhat.com>
6420
6421 * NEWS (New commands): Mention "with" and "maint with".
6422 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
6423 (with_command, with_command_completer): New.
6424 (pipe_command): Adjust to new repeat_previous
6425 interface.
6426 (_initialize_cli_cmds): Install the "with" command and its "w"
6427 alias.
6428 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
6429 declarations.
6430 * cli/cli-setshow.c (parse_cli_var_uinteger)
6431 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
6432 argument strings for all var_types.
6433 (get_setshow_command_value_string): New, factored out from ...
6434 (do_show_command): ... this.
6435 * cli/cli-setshow.h: Include <string>.
6436 (get_setshow_command_value_string): Declare.
6437 * command.h (repeat_previous): Now returns const char *. Adjust
6438 comment.
6439 * maint.c: Include "cli/cli-cmds.h".
6440 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
6441 (_initialize_maint_cmds): Register the "maintenance with" command.
6442 * top.c (repeat_previous): Move bits from pipe_command here:
6443 Return the saved command line, if any; error out if there's no
6444 command to relaunch.
6445
6446 2019-07-03 Pedro Alves <palves@redhat.com>
6447
6448 * NEWS (New commands): Mention "maint set/show test-settings"
6449 instead of "maint test-settings".
6450 * maint-test-settings.c (maintenance_test_settings_list): Delete.
6451 (maintenance_test_settings_set_list): Rename to ...
6452 (maintenance_set_test_settings_list): ... this.
6453 (maintenance_test_settings_show_list): Rename to ...
6454 (maintenance_show_test_settings_list): ... this.
6455 (maintenance_test_settings_cmd): Delete.
6456 (maintenance_test_settings_set_cmd): ...
6457 (maintenance_set_test_settings_cmd): ... this.
6458 (maintenance_test_settings_show_cmd): ...
6459 (maintenance_show_test_settings_cmd): ... this.
6460 (maintenance_test_settings_show_value_cmd):
6461 (maintenance_show_test_settings_value_cmd): ... this.
6462 (_initialize_maint_test_settings): No longer install the "maint
6463 test-settings" prefix command. Rename "maint test-settings set"
6464 to "maint set test-settings", and "maint test-settings show" to
6465 "maint show test-settings". Adjust all subcommands.
6466
6467 2019-07-03 Pedro Alves <palves@redhat.com>
6468
6469 * maint-test-settings.c: Fix file's intro comment. Replace all
6470 references to "test-options" with references to "test-settings",
6471 in comments.
6472
6473 2019-07-03 Pedro Alves <palves@redhat.com>
6474
6475 * maint-test-settings.c (maintenance_test_settings_xxx)
6476 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
6477 New.
6478 (maintenance_test_settings_enums): Use them.
6479 (maintenance_test_settings_enum): Default to
6480 maintenance_test_settings_xxx.
6481 (_initialize_maint_test_settings): Initialize
6482 MAINTENANCE_TEST_SETTINGS_FILENAME.
6483
6484 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
6485
6486 * breakpoint.h (remove_breakpoints_inf): Change return type to
6487 void, move function documentation here.
6488 * breakpoint.c (remove_breakpoints_inf): Change return type to
6489 void, move function documentation to header.
6490
6491 2019-07-02 Pedro Alves <palves@redhat.com>
6492
6493 * NEWS (Completion improvements): Mention "info threads".
6494 * thread.c (struct info_threads_opts, info_threads_option_defs)
6495 (make_info_threads_options_def_group): New.
6496 (info_threads_command): Use gdb::option::process_options.
6497 (info_threads_command_completer): New.
6498 (_initialize_thread): Use gdb::option::build_help to build the
6499 help text for "info threads".
6500
6501 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
6502
6503 * defs.h (generic_load): Move from here...
6504 * symfile.h (generic_load): ... to here. Rename name parameter
6505 to args.
6506 * symfile.c (generic_load): Add comment.
6507
6508 2019-07-01 Tom Tromey <tromey@adacore.com>
6509
6510 * dwarf2read.c
6511 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
6512 declaration of without_params. Fix formatting.
6513
6514 2019-07-01 Tom Tromey <tromey@adacore.com>
6515
6516 * ada-exp.y (find_primitive_type): Update.
6517 * ada-lang.h (ada_lookup_symbol): Update.
6518 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
6519 parameter.
6520 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
6521
6522 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
6523
6524 PR breakpoints/24541
6525 * gdbarch.c: Regenerate.
6526 * gdbarch.h: Regenerate.
6527 * gdbarch.sh: Add 'stap_adjust_register'.
6528 * i386-tdep.c: Include '<unordered_set>'.
6529 (i386_stap_adjust_register): New function.
6530 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
6531 * stap-probe.c (stap_parse_register_operand): Call
6532 'gdbarch_stap_adjust_register'.
6533
6534 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
6535
6536 PR python/24742
6537 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
6538 * python/python.c (do_start_initialization): Use 'xmalloc'
6539 instead of 'PyMem_Malloc'.
6540
6541 2019-06-28 Tom Tromey <tromey@adacore.com>
6542
6543 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
6544 for Ada.
6545
6546 2019-06-27 Tom Tromey <tromey@adacore.com>
6547
6548 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
6549 objfile_key.
6550 (arm_find_mapping_symbol, arm_record_special_symbol)
6551 (_initialize_arm_tdep): Update.
6552 (arm_objfile_data_free): Remove.
6553
6554 2019-06-27 Tom Tromey <tromey@adacore.com>
6555
6556 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
6557 to cp_print_static_field.
6558
6559 2019-06-26 Tom Tromey <tromey@adacore.com>
6560
6561 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
6562 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
6563 declare.
6564
6565 2019-06-26 Alan Hayward <alan.hayward@arm.com>
6566
6567 * features/aarch64-core.c (create_feature_aarch64_core):
6568 Regenerate.
6569 * features/aarch64-core.xml: Add cpsr flags.
6570
6571 2019-06-26 Alan Hayward <alan.hayward@arm.com>
6572
6573 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
6574 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
6575
6576 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
6577
6578 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
6579 field.
6580 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
6581 use.
6582 (arm_record_special_symbol): Don't insert new symbol in sorted
6583 position, push it at the end.
6584
6585 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
6586
6587 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
6588 (arm_mapping_symbol_s): Remove.
6589 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
6590 (arm_mapping_symbol_vec): New typedef.
6591 (struct arm_per_objfile): Add constructor.
6592 <section_maps>: Change type to
6593 std::unique_ptr<arm_mapping_symbol_vec[]>.
6594 (arm_compare_mapping_symbols): Remove.
6595 (arm_find_mapping_symbol): Adjust to section_maps type change.
6596 (arm_objfile_data_free): Call delete on arm_per_objfile.
6597 (arm_record_special_symbol): Adjust to section_maps type change.
6598 Allocate arm_per_objfile with new.
6599
6600 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6601
6602 * cli/cli-cmds.c (alias_command): Compare the alias prefix
6603 with the command prefix.
6604
6605 2019-06-25 Tom Tromey <tom@tromey.com>
6606
6607 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
6608 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
6609
6610 2019-06-25 Tom Tromey <tom@tromey.com>
6611
6612 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
6613 type.
6614 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
6615 protected.
6616
6617 2019-06-25 Tom Tromey <tom@tromey.com>
6618
6619 * tui/tui-winsource.c
6620 (tui_source_window_base::set_is_exec_point_at): Add check against
6621 LOA_ADDRESS.
6622
6623 2019-06-25 Tom Tromey <tom@tromey.com>
6624
6625 * tui/tui-source.c (tui_set_source_content): Don't check before
6626 xfree.
6627 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
6628
6629 2019-06-25 Tom Tromey <tom@tromey.com>
6630
6631 * tui/tui-winsource.h (tui_update_source_window_as_is)
6632 (tui_alloc_source_buffer, tui_line_is_displayed)
6633 (tui_addr_is_displayed): Change type of win_info.
6634 * tui/tui-winsource.c (tui_update_source_window_as_is)
6635 (tui_clear_source_content, tui_show_source_line)
6636 (tui_show_source_content, tui_source_window_base::refill)
6637 (tui_source_window_base::set_is_exec_point_at)
6638 (tui_source_window_base::set_is_exec_point_at)
6639 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
6640 (tui_alloc_source_buffer, tui_line_is_displayed)
6641 (tui_addr_is_displayed): Change type of win_info. Update.
6642 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6643 (tui_source_window_base::do_make_visible_with_new_height):
6644 Update.
6645 * tui/tui-source.c (tui_set_source_content)
6646 (tui_set_source_content_nil)
6647 (tui_source_window::do_scroll_vertical): Update.
6648 * tui/tui-layout.c (show_layout): Update.
6649 * tui/tui-disasm.c (tui_set_disassem_content)
6650 (tui_disasm_window::do_scroll_vertical): Update.
6651 * tui/tui-data.h (tui_win_content): Remove.
6652 (struct tui_gen_win_info) <content, content_size>: Remove.
6653 (struct tui_source_element): Add initializers and destructor.
6654 (union tui_which_element, struct tui_win_element): Remove.
6655 (struct tui_source_window_base) <content>: New field.
6656 (struct tui_data_window): Remove destructor.
6657 (tui_alloc_content, tui_free_win_content)
6658 (tui_free_all_source_wins_content): Don't declare.
6659 * tui/tui-data.c (tui_initialize_static_data): Update.
6660 (init_content_element, tui_alloc_content): Remove.
6661 (~tui_gen_win_info): Update.
6662 (~tui_data_window, tui_free_all_source_wins_content)
6663 (tui_free_win_content, free_content, free_content_elements):
6664 Remove.
6665
6666 2019-06-25 Tom Tromey <tom@tromey.com>
6667
6668 * tui/tui-winsource.h (tui_clear_source_content)
6669 (tui_erase_source_content, tui_show_source_content): Change type
6670 of win_info.
6671 * tui/tui-winsource.c (tui_clear_source_content)
6672 (tui_erase_source_content, tui_show_source_content): Change type
6673 of win_info.
6674 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6675 * tui/tui-source.h (tui_set_source_content_nil): Change type of
6676 win_info.
6677 * tui/tui-source.c (tui_set_source_content_nil): Change type of
6678 win_info.
6679 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
6680
6681 2019-06-25 Tom Tromey <tom@tromey.com>
6682
6683 * tui/tui-winsource.c (tui_clear_source_content)
6684 (tui_source_window_base::set_is_exec_point_at): Update.
6685 * tui/tui-source.c (tui_set_source_content_nil): Update.
6686 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
6687 a bool.
6688 * tui/tui-data.c (init_content_element): Update.
6689
6690 2019-06-25 Tom Tromey <tom@tromey.com>
6691
6692 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
6693 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
6694 * tui/tui-layout.c (init_and_make_win): Update.
6695 * tui/tui.h (enum tui_win_type): Update.
6696 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
6697 tui_win_is_auxillary.
6698 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
6699 tui_win_is_auxillary.
6700
6701 2019-06-25 Tom Tromey <tom@tromey.com>
6702
6703 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
6704 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
6705 (tui_delete_data_content_windows, tui_display_all_data)
6706 (tui_data_window::do_scroll_vertical, tui_display_data_from):
6707 Update.
6708 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
6709 * tui/tui-regs.c (tui_last_regs_line_no)
6710 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6711 (tui_show_registers): Update.
6712 (tui_show_register_group): Return void. Update.
6713 (tui_display_registers_from, tui_display_reg_element_at_line)
6714 (tui_display_registers_from_line, tui_check_register_values):
6715 Update.
6716 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
6717 member.
6718 (struct tui_data_window) <regs_content>: Now a std::vector.
6719 <regs_content_count>: Remove.
6720 (tui_add_content_elements, tui_free_data_content): Don't declare.
6721 * tui/tui-data.c (tui_data_window::clear_detail): Update.
6722 (init_content_element): Remove DATA_WIN case. Add assert.
6723 (tui_add_content_elements): Remove.
6724 (tui_data_window): Update.
6725 (tui_free_data_content): Remove.
6726 (free_content_elements): Remove DATA_WIN case.
6727
6728 2019-06-25 Tom Tromey <tom@tromey.com>
6729
6730 * tui/tui-data.c (tui_data_item_window): Update.
6731 * tui/tui-windata.h (tui_check_data_values): Don't declare.
6732 * tui/tui-windata.c (tui_display_all_data)
6733 (tui_display_data_from_line): Update.
6734 (tui_check_data_values): Remove.
6735 * tui/tui-regs.c (tui_show_register_group)
6736 (tui_display_reg_element_at_line): Update.
6737 * tui/tui-hooks.c (tui_register_changed)
6738 (tui_refresh_frame_and_register_information): Call
6739 tui_check_register_values.
6740 * tui/tui-data.h (struct tui_data_window) <data_content,
6741 data_content_count, data_type>: Remove.
6742 (enum tui_data_type): Remove.
6743
6744 * tui/tui-data.c (tui_data_window::clear_detail)
6745 (~tui_data_window): Update.
6746
6747 2019-06-25 Tom Tromey <tom@tromey.com>
6748
6749 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
6750 declare.
6751 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
6752 Rename from tui_first_data_item_displayed. Update.
6753 (tui_data_window::refresh_all)
6754 (tui_data_window::do_scroll_vertical): Update.
6755 * tui/tui-data.h (struct tui_data_window)
6756 <first_data_item_displayed>: Declare new method.
6757
6758 2019-06-25 Tom Tromey <tom@tromey.com>
6759
6760 * tui/tui-data.h (tui_init_generic_part): Don't declare.
6761 * tui/tui-data.c (tui_init_generic_part): Remove, moving
6762 contents...
6763 (tui_initialize_static_data): ...here.
6764
6765 2019-06-25 Tom Tromey <tom@tromey.com>
6766
6767 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6768 (tui_display_registers_from, tui_check_register_values): Update.
6769 (tui_display_register): Remove win_info parameter; update.
6770 (tui_get_register): Change type of parameters.
6771 * tui/tui-data.h (struct tui_data_element): Remove.
6772 (union tui_which_element) <data>: Remove.
6773 <data_window>: Change type.
6774 (struct tui_data_item_window): New.
6775 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
6776 case. Add assert.
6777 (~tui_data_item_window): New destructor.
6778 (free_content_elements): Remove DATA_ITEM_WIN case.
6779
6780 2019-06-25 Tom Tromey <tom@tromey.com>
6781
6782 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
6783 Remove.
6784
6785 2019-06-25 Tom Tromey <tom@tromey.com>
6786
6787 * tui/tui-data.h (struct tui_command_element): Remove.
6788 (union tui_which_element) <command>: Remove.
6789 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
6790 assert.
6791 (free_content_elements): Remove CMD_WIN case.
6792
6793 2019-06-25 Tom Tromey <tom@tromey.com>
6794
6795 * tui/tui-layout.c (tui_set_layout): Update.
6796 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
6797 * tui/tui-data.c (layout_def): Update.
6798
6799 2019-06-25 Tom Tromey <tom@tromey.com>
6800
6801 * tui/tui-wingeneral.c (tui_refresh_all): Update.
6802 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6803 (tui_source_window_base::set_new_height): Update.
6804 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
6805 Update.
6806 (tui_set_locator_fullname, tui_set_locator_info)
6807 (tui_show_frame_info): Update.
6808 * tui/tui-source.c (tui_set_source_content)
6809 (tui_source_is_displayed): Update.
6810 * tui/tui-layout.c (show_source_disasm_command, show_data)
6811 (show_source_or_disasm_and_command): Update.
6812 * tui/tui-disasm.c (tui_set_disassem_content)
6813 (tui_get_begin_asm_address): Update.
6814 * tui/tui-data.h (struct tui_locator_element): Remove.
6815 (union tui_which_element) <locator>: Remove.
6816 (struct tui_locator_window): New.
6817 (tui_locator_win_info_ptr): Change return type.
6818 * tui/tui-data.c (_locator): Change type.
6819 (tui_locator_win_info_ptr): Change return type.
6820 (init_content_element): Remove LOCATOR_WIN case. Add assert.
6821 (tui_alloc_content): Add assert.
6822
6823 2019-06-25 Tom Tromey <tom@tromey.com>
6824
6825 * tui/tui-winsource.c
6826 (tui_exec_info_window::maybe_allocate_content): New method.
6827 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
6828 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
6829 (make_source_or_disasm_window): Add cast.
6830 * tui/tui-data.h (union tui_which_element) <simple_string>:
6831 Remove.
6832 (struct tui_source_info): New.
6833 (struct tui_source_window_base) <execution_info>: Change type.
6834 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
6835 case, and add assert.
6836 (tui_alloc_content): Add assert.
6837
6838 2019-06-25 Tom Tromey <tom@tromey.com>
6839
6840 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
6841 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
6842 * tui/tui-data.c (tui_alloc_win_info): Remove.
6843
6844 2019-06-25 Tom Tromey <tom@tromey.com>
6845
6846 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
6847 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
6848 can_highlight.
6849
6850 2019-06-25 Tom Tromey <tom@tromey.com>
6851
6852 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
6853 make_visible_with_new_height method.
6854 (tui_win_info::make_visible_with_new_height): New method.
6855 (tui_source_window_base::do_make_visible_with_new_height)
6856 (tui_data_window::do_make_visible_with_new_height)
6857 (tui_cmd_window::do_make_visible_with_new_height): New methods.
6858 (make_visible_with_new_height): Remove.
6859 (tui_resize_all, tui_adjust_win_heights): Use
6860 make_visible_with_new_height method.
6861 * tui/tui-data.h (struct tui_win_info)
6862 <do_make_visible_with_new_height, make_visible_with_new_height>:
6863 New methods.
6864 (struct tui_source_window_base, struct tui_data_window)
6865 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
6866 methods.
6867
6868 2019-06-25 Tom Tromey <tom@tromey.com>
6869
6870 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
6871 method.
6872 (update_tab_width): Call update_tab_width method.
6873 * tui/tui-data.h (struct tui_win_info)
6874 (struct tui_source_window_base) <update_tab_width>: New methods.
6875
6876 2019-06-25 Tom Tromey <tom@tromey.com>
6877
6878 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
6879 parameter.
6880 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
6881 parameter.
6882 (tui_gen_win_info::make_visible): Update.
6883 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
6884 parameter.
6885 * tui/tui-data.h (enum tui_box): New enum.
6886 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
6887
6888 2019-06-25 Tom Tromey <tom@tromey.com>
6889
6890 * tui/tui-layout.c (make_source_or_disasm_window): Always use
6891 init_and_make_win for EXEC_INFO_WIN.
6892 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
6893 longer inline.
6894 (struct tui_win_info) <~tui_win_info>: Inline.
6895 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6896 Don't declare.
6897 * tui/tui-data.c (source_win, disasm_win): Remove globals.
6898 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6899 Remove.
6900 (tui_initialize_static_data): Update.
6901 (~tui_gen_win_info): Handle more cleanup here.
6902 (~tui_source_window_base): Delete "execution_info".
6903 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
6904
6905 2019-06-25 Tom Tromey <tom@tromey.com>
6906
6907 * tui/tui-layout.c (make_command_window): Don't set
6908 can_highlight.
6909 (show_source_disasm_command): Call the reset method.
6910 (show_data): Don't set can_highlight. Call the reset method.
6911 (tui_gen_win_info::reset): Rename from init_gen_win_info
6912 (init_and_make_win): Simplify. Return tui_gen_win_info.
6913 (show_source_or_disasm_and_command): Call the reset method.
6914 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
6915 (struct tui_cmd_window): Set can_highlight.
6916
6917 2019-06-25 Tom Tromey <tom@tromey.com>
6918
6919 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
6920 from make_visible.
6921 (tui_make_visible, tui_make_invisible): Rewrite.
6922 (tui_win_info::make_visible): Remove.
6923 (tui_source_window_base::make_visible): Update.
6924 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
6925 method. Moved from...
6926 (struct tui_win_info) <make_visible>: ...here.
6927
6928 2019-06-25 Tom Tromey <tom@tromey.com>
6929
6930 * tui/tui-winsource.c
6931 (tui_source_window_base::do_scroll_horizontal): Remove direction
6932 parameter.
6933 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
6934 direction parameter.
6935 * tui/tui-win.c (tui_win_info::forward_scroll)
6936 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6937 (tui_win_info::right_scroll): Update.
6938 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
6939 direction parameter.
6940 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
6941 direction parameter.
6942 * tui/tui-data.h (enum tui_scroll_direction): Remove.
6943 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
6944 Remove direction parameter.
6945 (struct tui_source_window_base, struct tui_source_window)
6946 (struct tui_disasm_window, struct tui_data_window)
6947 (struct tui_cmd_window): Update.
6948
6949 2019-06-25 Tom Tromey <tom@tromey.com>
6950
6951 * tui/tui-winsource.h (tui_set_exec_info_content)
6952 (tui_show_exec_info_content, tui_erase_exec_info_content)
6953 (tui_clear_exec_info_content, tui_update_exec_info): Change
6954 argument to tui_source_window_base.
6955 * tui/tui-winsource.c (tui_set_exec_info_content)
6956 (tui_show_exec_info_content, tui_erase_exec_info_content)
6957 (tui_clear_exec_info_content, tui_update_exec_info): Change
6958 argument to tui_source_window_base.
6959
6960 2019-06-25 Tom Tromey <tom@tromey.com>
6961
6962 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
6963 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
6964
6965 2019-06-25 Tom Tromey <tom@tromey.com>
6966
6967 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
6968 check.
6969
6970 2019-06-25 Tom Tromey <tom@tromey.com>
6971
6972 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
6973 type to void.
6974 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
6975 type to void.
6976 * tui/tui-source.c (tui_set_source_content): Update.
6977 * tui/tui-disasm.c (tui_set_disassem_content): Update.
6978
6979 2019-06-25 Tom Tromey <tom@tromey.com>
6980
6981 * tui/tui-win.c (window_name_completer, tui_set_focus)
6982 (tui_all_windows_info): Use name method.
6983 * tui/tui-data.h (struct tui_gen_win_info)
6984 (struct tui_source_window, struct tui_disasm_window)
6985 (struct tui_data_window, struct tui_cmd_window) <name>: New
6986 method.
6987 (tui_win_name): Don't declare.
6988 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
6989 (tui_win_name): Remove.
6990
6991 2019-06-25 Tom Tromey <tom@tromey.com>
6992
6993 * tui/tui-winsource.h (tui_update_source_window)
6994 (tui_update_source_window_as_is): Change parameter type.
6995 * tui/tui-winsource.c (tui_update_source_window): Change win_info
6996 to be a tui_source_window_base.
6997 (tui_update_source_window_as_is): Likewise.
6998 * tui/tui-win.c (make_visible_with_new_height): Update.
6999
7000 2019-06-25 Tom Tromey <tom@tromey.com>
7001
7002 * tui/tui-winsource.c (tui_erase_source_content)
7003 (tui_show_source_content, tui_show_exec_info_content)
7004 (tui_erase_exec_info_content): Use refresh_window method.
7005 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7006 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7007 from tui_refresh_win.
7008 (tui_data_window::refresh_window): New method.
7009 (tui_win_info::refresh, tui_source_window_base::refresh)
7010 (tui_refresh_all): Use refresh_window method.
7011 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7012 method.
7013 * tui/tui-regs.c (tui_display_register): Call refresh_window
7014 method.
7015 * tui/tui-layout.c (show_source_disasm_command)
7016 (show_source_or_disasm_and_command): Call refresh_window method.
7017 * tui/tui-data.h (struct tui_gen_win_info)
7018 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7019 New method.
7020
7021 2019-06-25 Tom Tromey <tom@tromey.com>
7022
7023 * tui/tui.c (tui_rl_other_window, tui_enable)
7024 (tui_is_window_visible, tui_get_command_dimension): Update.
7025 * tui/tui-winsource.c (tui_update_source_window_as_is)
7026 (tui_clear_source_content, tui_erase_source_content)
7027 (tui_show_source_line, tui_source_window_base::refill)
7028 (tui_source_window_base::do_scroll_horizontal)
7029 (tui_source_window_base::set_is_exec_point_at)
7030 (tui_update_breakpoint_info, tui_set_exec_info_content)
7031 (tui_alloc_source_buffer, tui_line_is_displayed)
7032 (tui_addr_is_displayed): Update.
7033 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7034 (tui_check_and_display_highlight_if_needed)
7035 (tui_win_info::make_visible, tui_win_info::refresh)
7036 (tui_refresh_all): Update.
7037 * tui/tui-windata.c (tui_first_data_item_displayed)
7038 (tui_delete_data_content_windows, tui_erase_data_content)
7039 (tui_display_all_data, tui_data_window::refresh_all)
7040 (tui_check_data_values): Update.
7041 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7042 (tui_set_win_focus_to, tui_win_info::forward_scroll)
7043 (tui_win_info::backward_scroll, tui_refresh_all_win)
7044 (tui_resize_all, tui_set_focus, tui_all_windows_info)
7045 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7046 (tui_source_window_base::set_new_height)
7047 (tui_data_window::set_new_height)
7048 (make_invisible_and_set_new_height)
7049 (make_visible_with_new_height, new_height_ok)
7050 (parse_scrolling_args): Update.
7051 * tui/tui-stack.c (tui_show_frame_info): Update.
7052 * tui/tui-source.c (tui_set_source_content)
7053 (tui_set_source_content_nil, tui_source_is_displayed)
7054 (tui_source_window::do_scroll_vertical): Update.
7055 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7056 (tui_display_registers_from, tui_display_reg_element_at_line)
7057 (tui_check_register_values, tui_reg_command): Update.
7058 * tui/tui-layout.c (tui_default_win_height)
7059 (show_source_disasm_command, show_data, init_and_make_win)
7060 (show_source_or_disasm_and_command): Update.
7061 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7062 (tui_redisplay_readline, tui_mld_flush)
7063 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7064 (tui_getc): Update.
7065 * tui/tui-disasm.c (tui_set_disassem_content)
7066 (tui_disasm_window::do_scroll_vertical): Update.
7067 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7068 Now virtual.
7069 (struct tui_win_info): Derive from tui_gen_win_info.
7070 <~tui_win_info>: Mark as override.
7071 <generic>: Remove member.
7072 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7073 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7074 (~tui_data_window, ~tui_win_info)
7075 (tui_free_all_source_wins_content): Update.
7076 * tui/tui-command.c (tui_refresh_cmd_win): Update.
7077
7078 2019-06-25 Tom Tromey <tom@tromey.com>
7079
7080 * tui/tui-layout.c (init_and_make_win): Use new.
7081 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7082 destructor, initializers.
7083 (tui_alloc_generic_win_info): Don't declare.
7084 * tui/tui-data.c (_locator): Add argument to constructor.
7085 (source_win, disasm_win): New globals.
7086 (exec_info): Remove.
7087 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7088 Update.
7089 (tui_alloc_generic_win_info): Remove.
7090 (init_content_element): Use new.
7091 (tui_win_info::tui_win_info): Update.
7092 (free_content_elements) <case DATA_WIN>: Use delete.
7093
7094 2019-06-25 Tom Tromey <tom@tromey.com>
7095
7096 * tui/tui-wingeneral.c (tui_refresh_win): Update.
7097 * tui/tui-windata.c (tui_first_data_item_displayed)
7098 (tui_delete_data_content_windows): Update.
7099 * tui/tui-win.c (tui_data_window::set_new_height): Update.
7100 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7101 (tui_display_registers_from, tui_check_register_values): Update.
7102 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7103 pointer.
7104 * tui/tui-data.c (init_content_element): Update. Allocate the new
7105 window.
7106 (tui_free_data_content): Update.
7107 (free_content_elements) <case DATA_WIN>: Free the window.
7108
7109 2019-06-25 Tom Tromey <tom@tromey.com>
7110
7111 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7112 Update.
7113 * tui/tui-layout.c (make_command_window)
7114 (show_source_disasm_command, show_data, init_and_make_win)
7115 (show_source_or_disasm_and_command): Update.
7116 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7117 method.
7118 <can_highight, is_highlighted>: Now bool.
7119 (tui_set_win_highlight): Don't declare.
7120 * tui/tui-data.c (tui_set_win_highlight): Remove.
7121
7122 2019-06-25 Tom Tromey <tom@tromey.com>
7123
7124 * tui/tui-wingeneral.c (make_visible): Remove check of window
7125 type.
7126
7127 2019-06-25 Tom Tromey <tom@tromey.com>
7128
7129 * tui/tui-win.c (tui_win_info::max_height)
7130 (tui_cmd_window::max_height): New methods.
7131 (new_height_ok): Call max_height.
7132 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7133 <max_height>: New method.
7134
7135 2019-06-25 Tom Tromey <tom@tromey.com>
7136
7137 * tui/tui-win.c (tui_source_window_base::set_new_height)
7138 (tui_data_window::set_new_height): New methods.
7139 (make_invisible_and_set_new_height): Call set_new_height method.
7140 * tui/tui-data.h (struct tui_win_info)
7141 (struct tui_source_window_base, struct tui_data_window)
7142 <set_new_height>: New method.
7143
7144 2019-06-25 Tom Tromey <tom@tromey.com>
7145
7146 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7147 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7148 tui_refresh_data_win.
7149 * tui/tui-win.c (tui_source_window_base::refresh_all): New
7150 method.
7151 (tui_refresh_all_win): Call the refresh_all method.
7152 (tui_set_focus): Likewise.
7153 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7154 (struct tui_source_window_base, struct tui_data_window) <refresh>:
7155 Likewise.
7156
7157 2019-06-25 Tom Tromey <tom@tromey.com>
7158
7159 * tui/tui-winsource.h (tui_refill_source_window)
7160 (tui_set_is_exec_point_at): Don't declare.
7161 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7162 (tui_source_window_base::refill): Rename from
7163 tui_refill_source_window.
7164 (tui_source_window_base::do_scroll_horizontal): Update.
7165 (tui_source_window_base::set_is_exec_point_at): Rename from
7166 tui_set_is_exec_point_at.
7167 (tui_update_all_breakpoint_info): Update.
7168 * tui/tui-stack.c (tui_show_frame_info): Update.
7169 * tui/tui-layout.c (show_data): Add cast.
7170 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7171 * tui/tui-data.h (struct tui_source_window_base) <refill,
7172 set_is_exec_point_at>: New methods.
7173 (tui_source_windows, tui_add_to_source_windows): Update types.
7174 (tui_add_to_source_windows): Remove redundant declaration.
7175 * tui/tui-data.c (source_windows): Store tui_source_window_base.
7176 (tui_source_windows): Change return type.
7177 (tui_clear_source_windows_detail): Update.
7178 (tui_add_to_source_windows): Change type of parameter.
7179 (tui_free_all_source_wins_content): Update.
7180
7181 2019-06-25 Tom Tromey <tom@tromey.com>
7182
7183 * tui/tui-wingeneral.c (tui_win_info::refresh)
7184 (tui_source_window_base::refresh): New methods.
7185 (tui_refresh_all): Call the refresh method.
7186 * tui/tui-data.h (struct tui_win_info)
7187 (struct tui_source_window_base) <refresh>: New method.
7188
7189 2019-06-25 Tom Tromey <tom@tromey.com>
7190
7191 * tui/tui.h (tui_is_window_visible): Return bool.
7192 * tui/tui.c (tui_is_window_visible): Return bool.
7193 * tui/tui-wingeneral.c (tui_make_window, make_visible)
7194 (tui_make_visible, tui_make_invisible)
7195 (tui_win_info::make_visible)
7196 (tui_source_window_base::make_visible, make_all_visible)
7197 (tui_make_all_visible, tui_make_all_invisible): Update.
7198 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7199 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7200 bool.
7201 (struct tui_win_info, struct tui_source_window_base)
7202 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7203 * tui/tui-data.c (tui_init_generic_part): Update.
7204
7205 2019-06-25 Tom Tromey <tom@tromey.com>
7206
7207 * tui/tui-wingeneral.c (tui_win_info::make_visible)
7208 (tui_source_window_base::make_visible): New methods.
7209 (make_all_visible): Make method call.
7210 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7211 (struct tui_source_window_base, struct tui_cmd_window): Override
7212 make_visible.
7213 (tui_win_is_source_type): Don't declare.
7214 * tui/tui-data.c (tui_win_is_source_type): Remove.
7215
7216 2019-06-25 Tom Tromey <tom@tromey.com>
7217
7218 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7219 NULL check.
7220
7221 2019-06-25 Tom Tromey <tom@tromey.com>
7222
7223 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7224 Inline constructor. Add initializers for members.
7225 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7226 constructors; now inline in class.
7227
7228 2019-06-25 Tom Tromey <tom@tromey.com>
7229
7230 * tui/tui-regs.c (tui_show_registers): Update.
7231 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7232 bool.
7233 * tui/tui-data.c (tui_data_window::clear_detail)
7234 (tui_data_window): Update.
7235
7236 2019-06-25 Tom Tromey <tom@tromey.com>
7237
7238 * tui/tui-windata.c (tui_display_all_data)
7239 (tui_display_data_from_line, tui_display_data_from)
7240 (tui_check_data_values, tui_data_window::do_scroll_vertical):
7241 Update.
7242 * tui/tui-regs.c (tui_last_regs_line_no)
7243 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7244 (tui_show_registers, tui_show_register_group)
7245 (tui_display_registers_from, tui_display_reg_element_at_line)
7246 (tui_display_registers_from_line, tui_check_register_values)
7247 (tui_reg_next, tui_reg_prev): Update.
7248 * tui/tui-layout.c (tui_set_layout, show_data): Update.
7249 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
7250 tui_data_window.
7251 (struct tui_win_info) <detail>: Remove. Add new fields from
7252 tui_data_info.
7253 (TUI_DATA_WIN): Add cast.
7254 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7255 (~tui_data_window): Simplify.
7256
7257 2019-06-25 Tom Tromey <tom@tromey.com>
7258
7259 * tui/tui-layout.c (show_source_disasm_command)
7260 (show_source_or_disasm_and_command): Update.
7261 * tui/tui-io.c (update_cmdwin_start_line)
7262 (tui_redisplay_readline): Update.
7263 * tui/tui-data.h (struct tui_command_info): Remove.
7264 (struct tui_win_info) <detail>: Remove command_info member.
7265 (struct tui_data_window) <start_line>: New member, from
7266 tui_command_info.
7267 (TUI_CMD_WIN): Add casts.
7268
7269 2019-06-25 Tom Tromey <tom@tromey.com>
7270
7271 * tui/tui-winsource.c (tui_update_source_window)
7272 (tui_refill_source_window)
7273 (tui_source_window_base::do_scroll_horizontal)
7274 (tui_update_breakpoint_info, tui_set_exec_info_content)
7275 (tui_show_exec_info_content, tui_erase_exec_info_content)
7276 (tui_clear_exec_info_content): Update.
7277 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7278 Update.
7279 * tui/tui-win.c (make_invisible_and_set_new_height)
7280 (make_visible_with_new_height): Update.
7281 * tui/tui-source.c (tui_set_source_content)
7282 (tui_show_symtab_source): Update.
7283 * tui/tui-layout.c (extract_display_start_addr)
7284 (show_source_disasm_command, show_data)
7285 (make_source_or_disasm_window)
7286 (show_source_or_disasm_and_command): Update.
7287 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7288 (tui_disasm_window::do_scroll_vertical): Remove shadowing
7289 "gdbarch".
7290 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
7291 to tui_source_window_base.
7292 (struct tui_win_info) <detail>: Remove source_info member.
7293 (struct tui_source_window_base) <has_locator>: Inline.
7294 Move contents from tui_source_info; rename has_locator member to
7295 m_has_locator.
7296 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7297 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7298 header file.
7299 (tui_source_window_base::clear_detail, ~tui_source_window_base):
7300 Simplify.
7301 (tui_free_all_source_wins_content): Cast to
7302 tui_source_window_base.
7303
7304 2019-06-25 Tom Tromey <tom@tromey.com>
7305
7306 * tui/tui-win.c (make_invisible_and_set_new_height)
7307 (make_visible_with_new_height): Call has_locator method.
7308 * tui/tui-layout.c (show_source_disasm_command, show_data)
7309 (show_source_or_disasm_and_command): Update for bool change.
7310 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7311 (tui_win_info) <has_locator>: New method.
7312 (struct tui_source_window_base) <has_locator>: New method.
7313 (tui_win_has_locator): Don't declare.
7314 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7315 from tui_win_has_locator.
7316 (tui_source_window_base): Use false, not FALSE.
7317
7318 2019-06-25 Tom Tromey <tom@tromey.com>
7319
7320 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7321 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7322 clear_detail method directly.
7323 (tui_clear_win_detail): Remove.
7324
7325 2019-06-25 Tom Tromey <tom@tromey.com>
7326
7327 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7328 "this", not TUI_DISASM_WIN.
7329
7330 2019-06-25 Tom Tromey <tom@tromey.com>
7331
7332 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
7333 declare.
7334 * tui/tui-winsource.c
7335 (tui_source_window_base::do_scroll_horizontal): Rename from
7336 tui_horizontal_source_scroll.
7337 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7338 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7339 from tui_vertical_data_scroll.
7340 * tui/tui-win.h (tui_scroll): Don't declare.
7341 * tui/tui-win.c (tui_win_info::forward_scroll)
7342 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7343 (tui_win_info::right_scroll): Rename and update.
7344 (tui_scroll_forward_command, tui_scroll_backward_command)
7345 (tui_scroll_left_command, tui_scroll_right_command): Update.
7346 (tui_scroll): Remove.
7347 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7348 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7349 from tui_vertical_source_scroll.
7350 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7351 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7352 from tui_vertical_disassem_scroll.
7353 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7354 do_scroll_horizontal>: New methods.
7355 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7356 Likewise.
7357 (struct tui_source_window_base): Add do_scroll_horizontal.
7358 (struct tui_source_window, struct tui_disasm_window): Add
7359 do_scroll_vertical.
7360 (struct tui_data_window, struct tui_cmd_window): Add
7361 do_scroll_horizontal and do_scroll_vertical.
7362 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7363
7364 2019-06-25 Tom Tromey <tom@tromey.com>
7365
7366 * tui/tui-data.h (struct tui_source_window_base): New struct.
7367 (struct tui_source_window): Derive from tui_source_window_base.
7368 (struct tui_disasm_window): New struct.
7369 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7370 from tui_source_window::clear_detail.
7371 (tui_source_window_base): Rename from tui_source_window.
7372 (~tui_source_window_base): Rename from ~tui_source_window.
7373 (tui_alloc_win_info): Create a tui_disasm_window.
7374
7375 2019-06-25 Tom Tromey <tom@tromey.com>
7376
7377 * tui/tui-data.h (struct tui_source_window)
7378 (struct tui_data_window): Declare destructors.
7379 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7380 destructors.
7381 (tui_win_info): Simplify.
7382
7383 2019-06-25 Tom Tromey <tom@tromey.com>
7384
7385 * tui/tui-winsource.c (tui_display_main)
7386 (tui_update_source_windows_with_addr)
7387 (tui_update_all_breakpoint_info): Update.
7388 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7389 (new_height_ok, parse_scrolling_args): Update.
7390 * tui/tui-stack.c (tui_show_frame_info): Update.
7391 * tui/tui-data.h (struct tui_list): Remove.
7392 (tui_source_windows): Return a reference to a std::vector.
7393 * tui/tui-data.c (source_windows): Now a std::vector.
7394 (tui_source_windows): Change return type.
7395 (tui_clear_source_windows): Rewrite.
7396 (tui_clear_source_windows_detail, tui_add_to_source_windows)
7397 (tui_free_all_source_wins_content): Rewrite.
7398
7399 2019-06-25 Tom Tromey <tom@tromey.com>
7400
7401 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7402 (struct tui_data_window, struct tui_cmd_window): Declare
7403 clear_detail method.
7404 * tui/tui-data.c (tui_source_window::clear_detail)
7405 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7406 methods.
7407 (tui_clear_win_detail): Simplify.
7408
7409 2019-06-25 Tom Tromey <tom@tromey.com>
7410
7411 * tui/tui-layout.c (make_source_window, make_disasm_window)
7412 (make_source_or_disasm_window): Remove win_info_ptr parameter.
7413 Return the new window.
7414 (show_source_disasm_command, show_data)
7415 (show_source_or_disasm_and_command): Update.
7416
7417 2019-06-25 Tom Tromey <tom@tromey.com>
7418
7419 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
7420 parameter. Return the new window.
7421 (show_source_disasm_command): Update and remove NULL check.
7422 (show_source_or_disasm_and_command): Update.
7423
7424 2019-06-25 Tom Tromey <tom@tromey.com>
7425
7426 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
7427
7428 2019-06-25 Tom Tromey <tom@tromey.com>
7429
7430 * tui/tui-data.h (struct tui_win_info): Make constructor
7431 protected. Make destructor virtual. Add initializers.
7432 (tui_source_window, tui_data_window, tui_cmd_window): New
7433 classes.
7434 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
7435 constructor. Add "type" parameter.
7436 (tui_source_window, tui_data_window, tui_cmd_window): New
7437 constructors.
7438 (tui_alloc_win_info): Instantiate the appropriate subclass.
7439
7440 2019-06-25 Tom Tromey <tom@tromey.com>
7441
7442 * tui/tui-win.c (tui_resize_all): Use delete.
7443 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
7444 destructor.
7445 (tui_free_window): Don't declare.
7446 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
7447 Update.
7448
7449 2019-06-25 Tom Tromey <tom@tromey.com>
7450
7451 * tui/tui-data.h (struct tui_win_info): Add constructor.
7452 * tui/tui-data.c (tui_alloc_win_info): Use new.
7453 (tui_free_window): Use delete.
7454
7455 2019-06-22 Tom Tromey <tom@tromey.com>
7456
7457 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
7458 declare.
7459 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
7460
7461 2019-06-22 Tom Tromey <tom@tromey.com>
7462
7463 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
7464 declare.
7465 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
7466
7467 2019-06-22 Tom de Vries <tdevries@suse.de>
7468
7469 * dwarf2read.c (create_addrmap_from_aranges)
7470 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
7471 instead of '%zu'.
7472
7473 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
7474
7475 * dwarf2read.h (dwarf2_section_info_def): Remove.
7476 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
7477 * dwarf2read.c (struct dwo_sections) <types>: Change type to
7478 std::vector<dwarf2_section_info>.
7479 (struct dwo_file) <~dwo_file>: Remove.
7480 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
7481 types field.
7482 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
7483 (dwarf2_read_debug_names): Likewise.
7484 (create_debug_types_hash_table): Change parameter type to
7485 array_view, adjust code accordingly.
7486 (dwarf2_locate_dwo_sections): Adjust to std::vector.
7487 (partial_die_info::fixup): Likewise.
7488 (determine_prefix): Likewise.
7489 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
7490
7491 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
7492
7493 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
7494 gdb_bfd_ref_ptr.
7495 <~dwo_file>: Remove call to gdb_bfd_unref.
7496 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
7497 gdb_bfd_ref_ptr::get.
7498
7499 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
7500
7501 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
7502 type to htab_up.
7503 * dwarf2read.c (struct dwo_file): Initialize fields.
7504 <~dwo_file>: New.
7505 (free_dwo_file): Remove, move content to ~dwo_file.
7506 (struct dwo_file_deleter): Remove.
7507 (dwo_file_up>: Remove custom deleter.
7508 (free_dwo_files): Remove.
7509 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
7510 dwo_files.
7511 (process_skeletonless_type_units): Call unique_ptr::get.
7512 (allocate_dwo_file_hash_table): Add deleter to created hash
7513 table. Change return type to htab_up.
7514 (lookup_dwo_file_slot): Don't memset dwo_file, call
7515 unique_ptr::get.
7516 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
7517 (create_dwo_unit_in_dwp_v2): Likewise.
7518 (open_and_init_dwo_file): Likewise.
7519 (free_dwo_file_from_slot): Remove.
7520
7521 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
7522
7523 * dwarf2read.h (struct dwarf2_section_info) <readin,
7524 is_virtual>: Change type to bool.
7525 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
7526 true instead of 1.
7527
7528 2019-06-19 Tom Tromey <tom@tromey.com>
7529
7530 * tui/tui-data.h (tui_init_content_element): Don't declare.
7531
7532 2019-06-19 Tom Tromey <tom@tromey.com>
7533
7534 * tui/tui-data.h (tui_init_win_info): Don't declare.
7535
7536 2019-06-19 Tom de Vries <tdevries@suse.de>
7537
7538 * dwarf2read.h (abstract_to_concrete): Change type to
7539 std::unordered_map<sect_offset, std::vector<sect_offset>,
7540 gdb::hash_enum<sect_offset>>.
7541
7542 2019-06-19 Tom Tromey <tromey@adacore.com>
7543
7544 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
7545 EVAL_AVOID_SIDE_EFFECTS specially.
7546
7547 2019-06-19 Tom Tromey <tromey@adacore.com>
7548
7549 * source-cache.c (highlighter): New global.
7550 (source_cache::get_source_lines): Create a highlighter on demand.
7551
7552 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
7553
7554 * defs.h (deprecated_interactive_hook): Delete declaration.
7555 * interps.c (clear_interpreter_hooks): Remove use of
7556 deprecated_interactive_hook.
7557 * top.c (deprecated_interactive_hook): Delete definition.
7558 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
7559
7560 2019-06-18 Tom de Vries <tdevries@suse.de>
7561
7562 PR gdb/24515
7563 * dwarf2read.h (abstract_to_concrete): Change type from
7564 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
7565 std::unordered_map<sect_offset, std::vector<sect_offset>>.
7566 * dwarf2read.c (read_variable): Update.
7567 (dwarf2_fetch_die_loc_sect_off): Update.
7568
7569 2019-06-17 Tom de Vries <tdevries@suse.de>
7570
7571 PR gdb/24617
7572 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
7573 accessing parent[parent_len - 1].
7574
7575 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
7576
7577 PR gdb/24364
7578 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
7579 call dtrace_process_dof with NULL dof.
7580
7581 2019-06-16 Tom de Vries <tdevries@suse.de>
7582
7583 PR gdb/24445
7584 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
7585
7586 2019-06-16 Tom Tromey <tom@tromey.com>
7587
7588 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7589 (make_all_visible): Use address of member.
7590
7591 2019-06-16 Tom Tromey <tom@tromey.com>
7592
7593 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
7594 (tui_free_window, free_content, free_content_elements): Remove
7595 unnecessary cast.
7596 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
7597 cast.
7598 * tui/tui-regs.c (tui_show_register_group)
7599 (tui_display_registers_from, tui_display_reg_element_at_line):
7600 Remove unnecessary cast.
7601
7602 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
7603
7604 * linux-nat.c (normal_mask): Delete.
7605 (_initialize_linux_nat): Don't initialise normal_mask.
7606
7607 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
7608
7609 PR gdb/24445
7610 * dwarf-index-write.h (write_psymtabs_to_index): Add
7611 dwz_basename parameter.
7612 * dwarf-index-write.c (write_gdbindex): Move file writing to
7613 write_gdbindex_1. Change return type void.
7614 (assert_file_size): Move up, remove filename parameter.
7615 (write_gdbindex_1): New function.
7616 (write_debug_names): Change return type to void, call
7617 assert_file_size.
7618 (struct index_wip_file): New struct.
7619 (write_psymtabs_to_index): Add dwz_basename parameter. Move
7620 file logic to index_wip_file. Write index for dwz file if
7621 needed.
7622 (save_gdb_index_command): Pass basename of dwz file, if present.
7623 * dwarf-index-cache.c (index_cache::store): Obtain and pass
7624 build-id of dwz file, if present.
7625 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
7626 (dwarf2_get_dwz_file): Likewise.
7627 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
7628 (dwarf2_get_dwz_file): Likewise.
7629
7630 2019-06-16 Tom Tromey <tom@tromey.com>
7631
7632 * coffread.c (process_coff_symbol): Use xstrdup.
7633 * value.c (create_internalvar): Use xstrdup.
7634
7635 2019-06-16 Tom Tromey <tom@tromey.com>
7636
7637 * valops.c (value_cast, value_slice): Remove unnecessary cast.
7638 * breakpoint.c (stopin_command, stopat_command)
7639 (until_break_command, decode_location_default): Remove unnecessary
7640 cast.
7641 * utils.c (subset_compare): Remove unnecessary cast.
7642 * ada-lang.c (ada_update_initial_language): Remove unnecessary
7643 cast.
7644 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
7645 cast.
7646 * infcmd.c (path_command): Remove unnecessary cast.
7647 * coffread.c (decode_type): Remove unnecessary cast.
7648 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
7649 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
7650 * tui/tui-stack.c (tui_show_locator_content)
7651 (tui_show_frame_info): Remove unnecessary cast.
7652 * tui/tui-win.c (tui_scroll_forward_command)
7653 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
7654 (parse_scrolling_args): Remove unnecessary cast.
7655 * tui/tui-data.c (init_win_info, tui_del_window)
7656 (tui_free_window, tui_del_data_windows, tui_free_data_content)
7657 (free_content_elements): Remove unnecessary cast.
7658 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
7659 unnecessary cast.
7660 * tui/tui-source.c (tui_set_source_content)
7661 (tui_vertical_source_scroll): Remove unnecessary cast.
7662 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
7663 cast.
7664 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
7665 * tui/tui-regs.c (tui_display_registers_from)
7666 (tui_display_register): Remove unnecessary cast.
7667 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
7668 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
7669 (make_visible): Remove unnecessary cast.
7670 * tui/tui-winsource.c (tui_erase_source_content)
7671 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
7672 unnecessary cast.
7673 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
7674 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
7675 * stabsread.c (read_type, read_array_type, read_range_type):
7676 Remove unnecessary cast.
7677 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
7678 (parse_symbol, parse_type, upgrade_type, parse_external)
7679 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
7680 unnecessary cast.
7681 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
7682
7683 2019-06-16 Tom Tromey <tom@tromey.com>
7684
7685 * tui/tui-data.c (tui_alloc_generic_win_info)
7686 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
7687 checks.
7688
7689 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
7690 Andrew Burgess <andrew.burgess@embecosm.com>
7691
7692 * f-typeprint.c (f_print_type): Don't return early for not
7693 associated or not allocated types.
7694 (f_type_print_varspec_suffix): Add print_rank parameter and print
7695 ranks of array types in case they dangling.
7696 (f_type_print_base): Add print_rank parameter.
7697
7698 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7699
7700 * NEWS: Mention new MI commands.
7701 * break-catch-throw.c (enum exception_event_kind): Move to
7702 breakpoint.h.
7703 (print_mention_exception_catchpoint): Output text as a single
7704 message.
7705 (catch_exception_command_1): Rename to...
7706 (catch_exception_event): ...this, make non-static, update header
7707 command, and change some parameter types.
7708 (catch_catch_command): Update for changes to
7709 catch_exception_command_1.
7710 (catch_throw_command): Likewise.
7711 (catch_rethrow_command): Likewise.
7712 * breakpoint.c (enum exception_event_kind): Delete.
7713 * breakpoint.h (enum exception_event_kind): Moved here from
7714 break-catch-throw.c.
7715 (catch_exception_event): Declare.
7716 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
7717 (mi_cmd_catch_throw): New function.
7718 (mi_cmd_catch_rethrow): New function.
7719 (mi_cmd_catch_catch): New function.
7720 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
7721 'catch-catch' entries.
7722 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
7723 (mi_cmd_catch_rethrow): Declare.
7724 (mi_cmd_catch_catch): Declare.
7725
7726 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7727
7728 * annotate.c (annotate_source_line): Change return type to void,
7729 update implementation to match.
7730 * annotate.h (annotate_source_line): Change return type to void,
7731 update header comment.
7732 * stack.c (print_frame_info): Don't change what frame information
7733 is printed based on whether annotations are on or not.
7734
7735 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7736
7737 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
7738 (annotate_source): Make static.
7739 (annotate_source_line): Moved from source.c and renamed from
7740 identify_source_line. Update the return type.
7741 * annotate.h (annotate_source): Delete declaration.
7742 (annotate_source_line): Declaration moved from source.h, and
7743 renamed from identify_source_line. Return type updated.
7744 * source.c (identify_source_line): Moved to annotate.c and renamed
7745 to annotate_source_line.
7746 (info_line_command): Remove check of annotation_level.
7747 * source.h (identify_source_line): Move declaration to annotate.h
7748 and rename to annotate_source_line.
7749 * stack.c: Add 'annotate.h' include.
7750 (print_frame_info): Remove check of annotation_level before
7751 calling annotate_source_line.
7752
7753 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7754
7755 * source-cache.c (source_cache::get_plain_source_lines): Use
7756 open_source_file_with_line_charpos instead of just
7757 open_source_file, remove call to find_source_lines.
7758 (source_cache::get_source_lines): Likewise.
7759 * source.c (find_source_lines): Make static.
7760 (get_filename_and_charpos): Renamed into...
7761 (open_source_file_with_line_charpos): ..this along with changes to
7762 return a scoped_fd, and some other minor clean ups.
7763 (identify_source_line): Use open_source_file_with_line_charpos.
7764 (search_command_helper): Use open_source_file_with_line_charpos
7765 instead of just open_source_file, remove call to
7766 find_source_lines.
7767 * source.h (open_source_file_with_line_charpos): Declare new
7768 function.
7769 (find_source_lines): Delete declaration.
7770
7771 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
7772
7773 * source.c (get_filename_and_charpos): Remove fullname
7774 parameter.
7775 (identify_source_line): Update call to get_filename_and_charpos.
7776
7777 2019-06-14 Tom Tromey <tromey@adacore.com>
7778
7779 PR gdb/24502:
7780 * ui-style.h (skip_ansi_escape): Update comment.
7781 * ui-file.h (class no_terminal_escape_file): New class.
7782 * ui-file.c (no_terminal_escape_file::write)
7783 (no_terminal_escape_file::puts): New methods.
7784 * cli/cli-logging.c (handle_redirections): Use
7785 no_terminal_escape_file.
7786
7787 2019-06-14 Tom Tromey <tromey@adacore.com>
7788
7789 * NEWS: Move convenience variable news above Python news.
7790
7791 2019-06-14 Tom Tromey <tom@tromey.com>
7792
7793 * gnulib: Move directory to top-level.
7794 * configure.ac: Don't configure gnulib.
7795 * configure: Rebuild.
7796 * common/common-defs.h: Use new path to gnulib.
7797 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
7798 (GNULIB_H): Remove.
7799 (INCGNU): Look in new gnulib location.
7800 (HFILES_NO_SRCDIR): Remove gnulib files.
7801 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
7802 (generated_files): Remove GNULIB_H.
7803 ($(LIBGNU), all-lib): Remove targets.
7804 (distclean): Don't mention GNULIB_BUILDDIR.
7805 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
7806
7807 2019-06-14 Tom Tromey <tromey@adacore.com>
7808
7809 * symfile.c (add_symbol_file_command): Remove obsolete comment.
7810 Warn if symbol file does not provide any symbols.
7811
7812 2019-06-14 Tom Tromey <tromey@adacore.com>
7813
7814 * source.c (find_and_open_source): Respect basenames_may_differ.
7815
7816 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
7817
7818 * annotate.c (annotate_breakpoints_invalid): Make use of
7819 scoped_restore_terminal_state.
7820 (annotate_frames_invalid): Likewise.
7821
7822 2019-06-14 Tom Tromey <tromey@adacore.com>
7823
7824 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
7825 allow assignment to an internalvar.
7826
7827 2019-06-14 Tom Tromey <tromey@adacore.com>
7828
7829 * ada-lex.l: Allow "_" in attribute names.
7830
7831 2019-06-14 Tom Tromey <tromey@adacore.com>
7832
7833 PR gdb/24653:
7834 * regcache.c (registers_changed): Don't call alloca.
7835 * top.c (execute_command): Don't call alloca.
7836
7837 2019-06-13 Pedro Alves <palves@redhat.com>
7838
7839 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
7840 'expression'. When parsing an expression, error out if there's
7841 junk after "unlimited".
7842 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7843 (do_set_command): Adjust calls to is_unlimited_literal.
7844
7845 2019-06-13 Pedro Alves <palves@redhat.com>
7846
7847 * compile/compile.c (make_compile_options_def_group): Add braces
7848 around array_view initializer.
7849 * thread.c (make_thread_apply_all_options_def_group)
7850 (make_thread_apply_all_options_def_group): Likewise.
7851
7852 2019-06-13 Pedro Alves <palves@redhat.com>
7853
7854 * NEWS (New commands): Mention "maint test-options
7855 require-delimiter", "maint test-options unknown-is-error", "maint
7856 test-options unknown-is-operand" and "maint show
7857 test-options-completion-result".
7858 (New command options, command completion): New section.
7859 (Completion improvements): New section.
7860 Mention that you can abbreviate "unlimited".
7861
7862 2019-06-13 Pedro Alves <palves@redhat.com>
7863
7864 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
7865 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
7866 * unittests/cli-utils-selftests.c (test_parse_flags)
7867 (test_parse_flags_qcs): Delete.
7868 (test_cli_utils): Don't call deleted functions.
7869
7870 2019-06-13 Pedro Alves <palves@redhat.com>
7871
7872 * thread.c: Include "cli/cli-option.h".
7873 (tp_array_compar_ascending): Global.
7874 (tp_array_compar): Delete function.
7875 (tp_array_compar_ascending, tp_array_compar_descending): New
7876 functions.
7877 (ascending_option_def, qcs_flag_option_def)
7878 (thr_qcs_flags_option_defs)
7879 (make_thread_apply_all_options_def_group)
7880 (make_thread_apply_options_def_group): New.
7881 (thread_apply_all_command): Use gdb::option::process_options.
7882 (thread_apply_command_completer)
7883 (thread_apply_all_command_completer): New.
7884 (thread_apply_command): Use gdb::option::process_options.
7885 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
7886 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
7887 to generate help text of "thread apply". Adjust "taas"'s help.
7888 * tid-parse.c (tid_range_parser::in_thread_range): New method.
7889 * tid-parse.h (tid_range_parser::in_thread_range): New method.
7890
7891 2019-06-13 Pedro Alves <palves@redhat.com>
7892
7893 * thread.c (thread_apply_command): Check for invalid TID with
7894 isdigit instead of !isalpha.
7895
7896 2019-06-13 Pedro Alves <palves@redhat.com>
7897
7898 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
7899 (validate_flags_qcs): New.
7900 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
7901 (validate_flags_qcs): Declare.
7902 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
7903 (make_frame_apply_options_def_group): New.
7904 (frame_apply_command_count): Process options with
7905 gdb::option::process_options.
7906 (frame_apply_completer): New.
7907 (frame_apply_level_completer, frame_apply_all_completer)
7908 (frame_apply_completer): New.
7909 (_initialize_stack): Update help of "frame apply", "frame apply
7910 level", "frame apply all" and "faas" to mention supported options
7911 and install command completers.
7912 * stack.h (frame_apply_all_completer): Declare.
7913 * thread.c: Include "stack.h".
7914 (tfaas_command): Add "--".
7915 (_initialize_thread): Update help "tfaas" to mention supported
7916 options and install command completer.
7917
7918 2019-06-13 Pedro Alves <palves@redhat.com>
7919
7920 * completer.c (complete_nested_command_line): New.
7921 (gdb_completion_word_break_characters_throw): Add assertion.
7922 * completer.h (complete_nested_command_line): Declare.
7923
7924 2019-06-13 Pedro Alves <palves@redhat.com>
7925
7926 * stack.c (parse_backtrace_qualifiers): New.
7927 (backtrace_command): Use it.
7928 (backtrace_command_completer): Complete on qualifiers.
7929
7930 2019-06-13 Pedro Alves <palves@redhat.com>
7931
7932 * frame.c: Include "cli/cli-option.h.
7933 (user_set_backtrace_options): New.
7934 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
7935 Delete.
7936 (get_prev_frame): Adjust.
7937 (boolean_option_def, uinteger_option_def)
7938 (set_backtrace_option_defs): New.
7939 (_initialize_frame): Adjust and use
7940 gdb::option::add_setshow_cmds_for_options to install "set
7941 backtrace past-main" and "set backtrace past-entry".
7942 * frame.h: Include "cli/cli-option.h".
7943 (struct frame_print_options): Forward declare.
7944 (print_frame_arguments_all, print_frame_arguments_scalars)
7945 (print_frame_arguments_none): Declare.
7946 (print_entry_values): Delete declaration.
7947 (struct frame_print_options, user_frame_print_options): New.
7948 (struct set_backtrace_options): New.
7949 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
7950 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
7951 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
7952 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
7953 (list_args_or_locals): Add frame_print_options parameter.
7954 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7955 * python/py-framefilter.c (enumerate_args): Pass down
7956 USER_FRAME_PRINT_OPTIONS.
7957 * stack.c: Include "cli/cli-option.h".
7958 (print_frame_arguments_all, print_frame_arguments_scalars)
7959 (print_frame_arguments_none): Declare.
7960 (print_raw_frame_arguments, print_entry_values): Delete.
7961 (user_frame_print_options): New.
7962 (boolean_option_def, enum_option_def, frame_print_option_defs):
7963 New.
7964 (struct backtrace_cmd_options): New.
7965 (bt_flag_option_def): New.
7966 (backtrace_command_option_defs): New.
7967 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
7968 (print_frame_arg, read_frame_arg, print_frame_args)
7969 (print_frame_info, print_frame): Add frame_print_options parameter
7970 and use it.
7971 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
7972 (backtrace_command_1): Add frame_print_options and
7973 backtrace_cmd_options parameters and use them.
7974 (make_backtrace_options_def_group): New.
7975 (backtrace_command): Process command options with
7976 gdb::option::process_options.
7977 (backtrace_command_completer): New.
7978 (_initialize_stack): Extend "backtrace"'s help to mention
7979 supported options. Install completer for "backtrace".
7980 Install some settings commands with add_setshow_cmds_for_options.
7981
7982 2019-06-13 Pedro Alves <palves@redhat.com>
7983
7984 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
7985 and that "set/show print raw frame-arguments" are now deprecated.
7986
7987 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
7988 command.
7989 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
7990 * stack.c (_initialize_stack): Install "set/show print
7991 raw-frame-arguments", and deprecate "set/show print raw
7992 frame-arguments".
7993 * valprint.c (_initialize_valprint): Deprecate "set/show print
7994 raw".
7995
7996 2019-06-13 Pedro Alves <palves@redhat.com>
7997
7998 * compile/compile.c (struct compile_options): New.
7999 (compile_flag_option_def, compile_command_option_defs)
8000 (make_compile_options_def_group): New.
8001 (compile_file_command): Handle options with
8002 gdb::option::process_options.
8003 (compile_file_command_completer): New function.
8004 (compile_code_command): Handle options with
8005 gdb::option::process_options.
8006 (compile_code_command_completer): New function.
8007 (_initialize_compiler): Install completers for "compile code" and
8008 "compile file". Mention available options in "compile code" and
8009 "compile code"'s help.
8010 * completer.c (advance_to_completion_word): New, factored out from
8011 ...
8012 (advance_to_expression_complete_word_point): ... this.
8013 (advance_to_filename_complete_word_point): New.
8014 * completer.h (advance_to_filename_complete_word_point): New
8015 declaration.
8016
8017 2019-06-13 Pedro Alves <palves@redhat.com>
8018
8019 * compile/compile.c: Include "cli/cli-option.h".
8020 (compile_print_value): Scope data pointer is now a
8021 value_print_options pointer; adjust.
8022 (compile_print_command): Process options. Scope data pointer is
8023 now a value_print_options pointer; adjust.
8024 (_initialize_compile): Update "compile print"'s help to include
8025 supported options. Install a completer for "compile print".
8026 * cp-valprint.c (show_vtblprint, show_objectprint)
8027 (show_static_field_print): Delete.
8028 (_initialize_cp_valprint): Don't install "set print
8029 static-members", "set print vtbl", "set print object" here.
8030 * printcmd.c: Include "cli/cli-option.h" and
8031 "common/gdb_optional.h".
8032 (print_command_parse_format): Rework to fill in a
8033 value_print_options instead of a format_data.
8034 (print_value): Change parameter type from format_data pointer to
8035 value_print_options reference. Adjust.
8036 (print_command_1): Process options. Adjust to pass down a
8037 value_print_options.
8038 (print_command_completer): New.
8039 (_initialize_printcmd): Install print_command_completer as
8040 handle_brkchars completer for the "print" command. Update
8041 "print"'s help to include supported options.
8042 * valprint.c: Include "cli/cli-option.h".
8043 (show_vtblprint, show_objectprint, show_static_field_print): Moved
8044 here from cp-valprint.c.
8045 (boolean_option_def, uinteger_option_def)
8046 (value_print_option_defs, make_value_print_options_def_group):
8047 New. Use gdb::option::add_setshow_cmds_for_options to install
8048 "set print elements", "set print null-stop", "set print repeats",
8049 "set print pretty", "set print union", "set print array", "set
8050 print address", "set print symbol", "set print array-indexes".
8051 * valprint.h: Include <string> and "cli/cli-option.h".
8052 (make_value_print_options_def_group): Declare.
8053 (print_value): Change parameter type from format_data pointer to
8054 value_print_options reference.
8055 (print_command_completer): Declare.
8056
8057 2019-06-13 Pedro Alves <palves@redhat.com>
8058
8059 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8060 (COMMON_SFILES): Add maint-test-settings.c.
8061 * cli/cli-decode.c (boolean_enums): New global, factored out from
8062 ...
8063 (add_setshow_boolean_cmd): ... here.
8064 * cli/cli-decode.h (boolean_enums): Declare.
8065 * cli/cli-option.c: New file.
8066 * cli/cli-option.h: New file.
8067 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8068 factored out from ...
8069 (parse_cli_boolean_value(const char *)): ... this.
8070 (is_unlimited_literal): Change parameter type to pointer to
8071 pointer. Adjust and advance ARG pointer.
8072 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8073 (parse_cli_var_enum): New, factored out from ...
8074 (do_set_command): ... this. Adjust.
8075 * cli/cli-setshow.h (parse_cli_boolean_value)
8076 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8077 (parse_cli_var_enum): Declare.
8078 * cli/cli-utils.c: Include "cli/cli-option.h".
8079 (get_ulongest): New.
8080 * cli/cli-utils.h (get_ulongest): Declare.
8081 (check_for_argument): New overloads.
8082 * maint-test-options.c: New file.
8083
8084 2019-06-13 Pedro Alves <palves@redhat.com>
8085
8086 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8087 parse a range if "-" is at the end of the string.
8088
8089 2019-06-13 Pedro Alves <palves@redhat.com>
8090
8091 * cli/cli-setshow.c (parse_auto_binary_operation)
8092 (parse_cli_boolean_value): Don't allow "o".
8093
8094 2019-06-13 Pedro Alves <palves@redhat.com>
8095
8096 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8097 * NEWS: Mention maint test-settings KIND.
8098 * maint-test-settings.c: New file.
8099
8100 2019-06-13 Pedro Alves <palves@redhat.com>
8101
8102 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8103 completer.
8104 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8105 "set" completers.
8106
8107 2019-06-13 Pedro Alves <palves@redhat.com>
8108
8109 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8110 after item.
8111
8112 2019-06-13 Pedro Alves <palves@redhat.com>
8113
8114 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8115
8116 2019-06-13 Pedro Alves <palves@redhat.com>
8117
8118 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8119 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8120 call.
8121 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8122 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8123 calls.
8124 (check_for_argument): Skip spaces after argument.
8125
8126 2019-06-13 Pedro Alves <palves@redhat.com>
8127
8128 * thread.c (thread_apply_command): Adjust TID parsing.
8129 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8130 detected before end of string.
8131 (tid_is_in_list): Error out if LIST is invalid.
8132
8133 2019-06-13 Pedro Alves <palves@redhat.com>
8134
8135 * completer.c (complete_line_internal_1): Rewind completion word
8136 point.
8137 (completion_tracker::advance_custom_word_point_by): Change
8138 parameter type to int.
8139 * completer.h (completion_tracker::advance_custom_word_point_by):
8140 Likewise.
8141
8142 2019-06-13 Pedro Alves <palves@redhat.com>
8143
8144 * completer.c (advance_to_completion_word): Handle delimiters.
8145
8146 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
8147
8148 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8149
8150 2019-06-11 Tom Tromey <tom@tromey.com>
8151
8152 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8153 (xmalloc_failed): Move to alloc.c.
8154 * alloc.c: New file.
8155 * Makefile.in (COMMON_SFILES): Add alloc.c.
8156
8157 2019-06-11 Tom Tromey <tom@tromey.com>
8158
8159 * nat/linux-waitpid.c: Don't include server.h.
8160 (linux_debug): Remove.
8161 (my_waitpid): Update.
8162
8163 2019-06-11 Tom Tromey <tromey@adacore.com>
8164
8165 * infcall.c (_initialize_infcall): Remove trailing newline from
8166 help.
8167 * user-regs.c (_initialize_user_regs): Remove trailing newline
8168 from help.
8169 * typeprint.c (_initialize_typeprint): Remove trailing newline
8170 from help.
8171 * reverse.c (_initialize_reverse): Remove trailing newlines from
8172 help.
8173 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8174 from help.
8175 * language.c (add_set_language_command): Remove trailing newline
8176 from help.
8177 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8178 help.
8179 * disasm.c (_initialize_disasm): Remove trailing newline from
8180 help.
8181 * top.c (init_main): Remove trailing newline from help.
8182 * interps.c (_initialize_interpreter): Remove trailing newline
8183 from help.
8184 * btrace.c (_initialize_btrace): Remove trailing newlines from
8185 help.
8186 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8187 from help.
8188 * python/python.c (_initialize_python): Remove trailing newline
8189 from help.
8190 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8191 help.
8192 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8193 from help. Reformat some text.
8194 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8195 from help.
8196 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8197 newline from help.
8198
8199 2019-06-11 Tom Tromey <tromey@adacore.com>
8200
8201 * darwin-nat.c (darwin_decode_exception_message)
8202 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8203
8204 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
8205
8206 * valops.c (value_slice): Check for not allocated or not
8207 associated values.
8208
8209 2019-06-10 Tom de Vries <tdevries@suse.de>
8210
8211 PR gdb/24618
8212 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8213 sure an empty slot (defined by a 32-bit zero pair) is recognized as
8214 invalid.
8215
8216 2019-06-10 Tom de Vries <tdevries@suse.de>
8217
8218 PR gdb/24611
8219 * linespec.c (linespec_lexer_lex_string): Remove incorrect
8220 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
8221
8222 2019-06-10 Tom de Vries <tdevries@suse.de>
8223
8224 PR symtab/24545
8225 * symtab.c (struct demangled_name_entry): Add language field.
8226 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
8227 static minimal symbol". Set and use language field.
8228
8229 2019-06-10 Tom Tromey <tromey@adacore.com>
8230
8231 * ada-lang.c (_initialize_ada_language): Update help text.
8232
8233 2019-06-10 Tom Tromey <tromey@adacore.com>
8234
8235 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8236 with a newline.
8237 * guile/guile.c (handle_boot_error): Don't end warning with a
8238 newline.
8239 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8240 warning with a newline.
8241 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8242 newline.
8243 (s12z_frame_cache): Likewise.
8244 * dwarf-index-cache.c (index_cache::store): Don't end warning with
8245 a newline.
8246 * solib-svr4.c (disable_probes_interface): Don't end warning with
8247 a newline.
8248 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8249 newline.
8250 * python/python.c (do_finish_initialization): Don't end warning
8251 with a newline.
8252
8253 2019-06-10 Tom Tromey <tom@tromey.com>
8254
8255 * python/py-breakpoint.c (gdbpy_breakpoint_created)
8256 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8257 gdbpy_enter.
8258
8259 2019-06-10 Tom Tromey <tromey@adacore.com>
8260
8261 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8262 data.
8263 (elf_new_init): Don't call stabsread_new_init.
8264 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8265 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
8266 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8267
8268 2019-06-10 Tom de Vries <tdevries@suse.de>
8269
8270 PR symtab/16264
8271 PR symtab/24517
8272 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8273
8274 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
8275
8276 * source.c (find_and_open_source): Also rewrite relative file
8277 names.
8278
8279 2019-04-26 Amos Bird <amosbird@gmail.com>
8280
8281 * annotate.c (annotate_thread_exited): Add "thread-exited"
8282 annotation.
8283
8284 2019-06-06 Tom Tromey <tromey@adacore.com>
8285
8286 * maint.h (class scoped_command_stats): Use
8287 DISABLE_COPY_AND_ASSIGN.
8288 <print_time>: New method.
8289 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8290 print_time.
8291 (scoped_command_stats::print_time): New method.
8292
8293 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
8294
8295 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8296 instructions of lengths 6 or 8 bytes.
8297
8298 2019-06-04 Pedro Alves <palves@redhat.com>
8299
8300 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8301
8302 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8303 * breakpoint.c (condition_completer): Likewise.
8304 * cli/cli-dump.c (scan_expression): Likewise.
8305 * common/filestuff.c (mkdir_recursive): Likewise.
8306 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8307 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8308 (gdb_abspath): Likewise.
8309 * compile/compile-cplus-types.c
8310 (compile_cplus_instance::decl_name): Likewise.
8311 * completer.c (complete_explicit_location):
8312 (signal_completer, reg_or_group_completer_1): Likewise.
8313 * cp-support.c (cp_remove_params_if_any): Likewise.
8314 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8315 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8316 * infcmd.c (strip_bg_char): Likewise.
8317 * linespec.c (copy_token_string): Likewise.
8318 * mi/mi-main.c (output_cores): Likewise.
8319 * psymtab.c (psymtab_search_name):
8320 * symfile.c (test_set_ext_lang_command): Likewise.
8321 * target.c (target_fileio_read_stralloc): Likewise.
8322 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8323 * value.c (complete_internalvar): Likewise.
8324
8325 2019-06-04 Christian Biesinger <cbiesinger@google.com>
8326
8327 Add objfile property to gdb.Type.
8328 * NEWS: Mention Python API addition.
8329 * python/py-type.c (typy_get_objfile): New method.
8330
8331 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8332
8333 * NEWS: Mention the new set|show style [title|highlight].
8334 Mention changes to "show style", "help" and "apropos".
8335
8336 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8337
8338 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8339 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
8340 instead of print_help_for_command.
8341 (print_doc_of_command): New function.
8342 (help_list): Add 'apropos -v word' suggestion.
8343 (print_help_for_command): Style the command name using title style.
8344 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8345 (_initialize_cli_cmds): Describe -v in apropos_command help.
8346
8347 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8348
8349 * cli/cli-style.h (cli_style_option): Add name in constructor,
8350 add m_name class member, add constructor with intensity,
8351 add name class function.
8352 (cli_style_option::add_setshow_commands): Remove name argument.
8353 (highlight_style, title_style): New styles.
8354 * cli/cli-style.c (do_show): New function that shows a style
8355 characteristic styling the style name with itself.
8356 (set_style_name): New function.
8357 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8358 Update all callers according to the changes in cli/cli-style.h.
8359 * utils.h (fputs_highlighted): New function.
8360 * utils.c (fputs_highlighted): Likewise.
8361
8362 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8363
8364 * NEWS: Mention new pipe command and new convenience variables.
8365
8366 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8367
8368 * cli/cli-cmds.c (pipe_command): New function.
8369 (_initialize_cli_cmds): Call add_com for pipe_command.
8370 Define | as an alias for pipe.
8371 (exit_status_set_internal_vars): New function.
8372 (shell_escape): Call exit_status_set_internal_vars.
8373 cli/cli-decode.c (find_command_name_length): Recognize | as
8374 a single character command.
8375
8376 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8377
8378 * gdbcmd.h (execute_command_to_ui_file): New declaration.
8379 top.c (execute_command_to_ui_file): New function, mostly a copy
8380 of execute_command_to_string.
8381 (execute_command_to_string): Implement by calling
8382 execute_command_to_ui_file.
8383
8384 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8385
8386 * top.h (saved_command_line): Remove declaration.
8387 * top.c (previous_saved_command_line, previous_repeat_arguments):
8388 New variables.
8389 (saved_command_line): Make static, define together with other
8390 'repeat variables'.
8391 (dont_repeat): Clear repeat_arguments.
8392 (repeat_previous, get_saved_command_line, save_command_line):
8393 New functions.
8394 (gdb_init): Initialize saved_command_line
8395 and previous_saved_command_line.
8396 * main.c (captured_main_1): Remove saved_command_line initialization.
8397 * event-top.c (handle_line_of_input): Update to use
8398 the new 'repeat' related functions instead of direct access to
8399 saved_command_line.
8400 * command.h (repeat_previous, get_saved_command_line,
8401 save_command_line): New declarations.
8402 (dont_repeat): Add comment.
8403
8404 2019-05-30 Tom Tromey <tromey@adacore.com>
8405
8406 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8407 Fix comment.
8408 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8409
8410 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
8411
8412 PR cli/24587
8413 * completer.c (complete): Initialize variable word.
8414
8415 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
8416
8417 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8418 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
8419 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
8420 'body' is NULL to the outter 'if', protecting the '!is_define'
8421 situation as well.
8422
8423 2019-05-29 Tom Tromey <tromey@adacore.com>
8424
8425 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
8426 (dwarf_unknown): New function.
8427 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
8428 (dwarf_type_encoding_name): Use dwarf_unknown.
8429
8430 2019-05-29 Tom Tromey <tromey@adacore.com>
8431
8432 PR c++/20020:
8433 * cp-valprint.c (cp_print_value_fields): Call
8434 cp_print_static_field inside "try".
8435
8436 2019-05-29 Tom Tromey <tromey@adacore.com>
8437
8438 * inflow.c (struct terminal_info): Add default operator=.
8439 * configure: Rebuild.
8440 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
8441 -Wdeprecated-copy-dtor, -Wredundant-move.
8442
8443 2019-05-29 Tom Tromey <tromey@adacore.com>
8444
8445 * NEWS: Add entry.
8446 * infcmd.c (print_return_value_1): Handle finish_print
8447 option.
8448 (show_print_finish): New function.
8449 (_initialize_infcmd): Add "set/show print finish" commands.
8450 * valprint.c (user_print_options): Initialize new member.
8451 * valprint.h (struct value_print_options) <finish_print>: New
8452 member.
8453
8454 2019-05-28 Tom Tromey <tromey@adacore.com>
8455
8456 * ada-lang.c (ada_remove_Xbn_suffix)
8457 (find_old_style_renaming_symbol)
8458 (parse_old_style_renaming): Remove.
8459 (ada_find_renaming_symbol): Don't call
8460 find_old_style_renaming_symbol.
8461 (ada_is_renaming_symbol): Rename from
8462 ada_find_renaming_symbol. Remove "block" parameter. Return
8463 bool. Now static.
8464 (ada_read_var_value): Update and simplify.
8465 * ada-exp.y (write_var_or_type): Remove old code.
8466
8467 2019-05-28 Alan Hayward <alan.hayward@arm.com>
8468
8469 PR gdb/25010
8470 * event-top.c: Remove include comment.
8471 * inflow.c (class scoped_ignore_sigttou): Move from here...
8472 * inflow.h (class scoped_ignore_sigttou): ...to here.
8473 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
8474 * top.c: Remove include comment.
8475
8476 2019-05-27 Tom Tromey <tom@tromey.com>
8477
8478 * NEWS: Fix typo.
8479
8480 2019-05-22 Tom Tromey <tromey@adacore.com>
8481
8482 * target.c (target_follow_exec): Constify parameter.
8483 * target-delegates.c: Rebuild.
8484 * remote.c (remote_target::follow_exec): Constify parameter.
8485 * infrun.c (follow_exec): Constify parameter.
8486 * target.h (struct target_ops) <follow_exec>: Constify parameter.
8487 (target_follow_exec): Likewise.
8488
8489 2019-05-22 Alan Hayward <alan.hayward@arm.com>
8490
8491 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
8492 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
8493
8494 2019-05-22 Alan Hayward <alan.hayward@arm.com>
8495
8496 * NEWS: Add debugredirect and testsuite sections.
8497
8498 2019-05-22 Simon Cook <simon.cook@embecosm.com>
8499
8500 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
8501 target descriptions using exclusively floating point register name
8502 aliases.
8503
8504 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
8505
8506 PR gdb/18644:
8507 * f-lang.c (build_fortran_types): Handle the case where
8508 gdbarch_floatformat_for_type returns a nullptr.
8509
8510 2019-05-21 Tom de Vries <tdevries@suse.de>
8511
8512 PR cli/24587
8513 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
8514
8515 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
8516
8517 PR gdb/18644:
8518 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
8519 16-byte floats.
8520 * i386-tdep.c (i386_floatformat_for_type): Use
8521 floatformats_ia64_quad for the 16-byte floating point component
8522 within a fortran 32-byte complex number.
8523
8524 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
8525
8526 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
8527 delete default constructor.
8528 (find_partial_die): Update to return const struct.
8529 (partial_die_parent_scope): Move variable declaration into scope
8530 of its use and change its type to auto.
8531 (guess_partial_die_structure_name): Likewise.
8532 (partial_die_info::fixup): Likewise.
8533
8534 2019-05-17 Tom Tromey <tromey@adacore.com>
8535
8536 * source.c (find_and_open_source): Remove cast.
8537
8538 2019-05-17 Tom Tromey <tromey@adacore.com>
8539
8540 * annotate.c (annotate_source): Make "filename" const.
8541 * annotate.h (annotate_source): Use const.
8542
8543 2019-05-17 Alan Hayward <alan.hayward@arm.com>
8544
8545 * disasm.c (set_disassembler_options): Send errors to stderr.
8546
8547 2019-05-17 Alan Hayward <alan.hayward@arm.com>
8548
8549 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
8550 (cli_interp_base::set_logging): Check debug_redirect.
8551 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
8552 * cli/cli-logging.c (debug_redirect): Add static variable.
8553 (pop_output_files): Add default param.
8554 (handle_redirections): Print debug setting.
8555 (show_logging_command): Likewise.
8556 (_initialize_cli_logging): Add debugredirect command.
8557 * interps.c (current_interp_set_logging): Add debug_redirect
8558 parameter.
8559 * interps.h (set_logging): Add debug_redirect parameter.
8560 (current_interp_set_logging): Likewise.
8561 * mi/mi-common.h: Likewise.
8562 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
8563
8564 2019-05-17 Alan Hayward <alan.hayward@arm.com>
8565 Tom Tromey <tromey@adacore.com>
8566
8567 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
8568 directly.
8569 * cli/cli-interp.h (make_logging_output): Remove declaration.
8570 * cli/cli-logging.c (make_logging_output): Remove function.
8571 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
8572 directly.
8573 * ui-file.c (tee_file::tee_file): Remove bools.
8574 (tee_file::~tee_file): Remove deletes.
8575 * ui-file.h (tee_file): Remove bools.
8576
8577 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
8578
8579 * mi/mi-cmds.h (mi_cmd_complete): New function.
8580 * mi/mi-main.c (mi_cmd_complete): Likewise.
8581 * mi/mi-cmds.c: Define new MI command -complete.
8582 * NEWS: Mention new -complete command.
8583
8584 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
8585
8586 * completer.h (complete): New function.
8587 * completer.c (complete): Likewise.
8588 * cli/cli-cmds.c: (complete_command): Update to use new complete()
8589 function defined in completer.h.
8590
8591 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
8592
8593 * MAINTAINERS (Write After Approval): Add myself.
8594
8595 2019-05-17 Tom de Vries <tdevries@suse.de>
8596
8597 PR gdb/24094
8598 * dwarf2read.c (struct cu_partial_die_info): New struct.
8599 (find_partial_die): Return cu_partial_die_info.
8600 (partial_die_parent_scope, guess_partial_die_structure_name)
8601 (partial_die_info::fixup): Handle new return type of find_partial_die.
8602
8603 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8604
8605 PR breakpoints/24541
8606 * stap-probe.c (stap_parse_register_operand): Make "regname" an
8607 "std::string", simplifying the algorithm.
8608
8609 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8610
8611 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
8612 (stap_static_probe_ops::get_probes): Likewise.
8613
8614 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8615
8616 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
8617 '-')" and "else if".
8618 (stap_parse_single_operand): Join checks for
8619 "gdbarch_stap_parse_special_token_p" and
8620 "gdbarch_stap_parse_special_token" in the same "if" statement.
8621 Invert check when verifying for operation on register
8622 displacement.
8623
8624 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8625
8626 * stap-probe.c (stap_get_opcode): Update comment.
8627 (stap_get_expected_argument_type): Likewise.
8628 (handle_stap_probe): Likewise.
8629
8630 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
8631
8632 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
8633 return type to 'bool'. Adjust comment. Use 'bool' when
8634 appropriate.
8635 (i386_stap_parse_special_token_three_arg_disp): Likewise.
8636 * stap-probe.c (stap_parse_argument_1): Likewise.
8637 (stap_is_operator): Likewise.
8638 (stap_is_generic_prefix): Likewise.
8639 (stap_is_register_prefix): Likewise.
8640 (stap_is_register_indirection_prefix): Likewise.
8641 (stap_is_integer_prefix): Likewise.
8642 (stap_generic_check_suffix): Likewise.
8643 (stap_check_integer_suffix): Likewise.
8644 (stap_check_register_suffix): Likewise.
8645 (stap_check_register_indirection_suffix): Likewise.
8646 (stap_parse_register_operand): Likewise.
8647 (stap_parse_single_operand): Likewise.
8648 (stap_parse_argument_1): Likewise.
8649 (stap_probe::get_argument_count): Likewise.
8650 (stap_is_operator): Likewise.
8651
8652 2019-05-16 Tom Tromey <tromey@adacore.com>
8653
8654 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
8655 keyword to foreach.
8656
8657 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
8658
8659 * linux-thread-db.c (try_thread_db_load_1): Change return type
8660 to bool.
8661 (try_thread_db_load): Likewise.
8662 (try_thread_db_load_from_pdir_1): Likewise.
8663 (try_thread_db_load_from_pdir): Likewise.
8664 (try_thread_db_load_from_sdir): Likewise.
8665 (try_thread_db_load_from_dir): Likewise.
8666 (thread_db_load_search): Likewise.
8667 (has_libpthread): Likewise.
8668 (thread_db_load): Likewise.
8669
8670 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
8671
8672 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
8673 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
8674 NULL, and complain/return if that's the case.
8675
8676 2019-05-15 John Darrington <john@darrington.wattle.id.au>
8677
8678 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
8679 (advance, posn, abstract_read_memory): New functions.
8680 [struct mem_read_abstraction]: New struct.
8681 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
8682
8683 2019-05-14 Tom Tromey <tromey@adacore.com>
8684
8685 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
8686 value is not lval_memory.
8687
8688 2019-05-14 Tom Tromey <tromey@adacore.com>
8689
8690 * solib.c (info_sharedlibrary_command): Style the file name.
8691
8692 2019-05-14 Alan Hayward <alan.hayward@arm.com>
8693
8694 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
8695 (aarch64_vnv_type): Likewise.
8696 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
8697 * common/tdesc.c: Likewise.
8698 * common/tdesc.h (enum tdesc_type_kind): Likewise.
8699 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
8700 * features/aarch64-fpu.xml: Add ieee half view.
8701 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
8702 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
8703 * gdbtypes.h (struct builtin_type): Likewise.
8704 (struct objfile_type): Likewise.
8705
8706 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
8707
8708 * language.c (language_sniff_from_mangled_name): Fix "langauge"
8709 typo.
8710 * location.h (string_to_event_location): Likewise.
8711
8712 2019-05-11 Joel Brobecker <brobecker@adacore.com>
8713
8714 GDB 8.3 released.
8715
8716 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
8717
8718 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
8719 New variable declaration.
8720 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
8721 New variable.
8722 (print_one_breakpoint): Use ui_out::test_flags and new global
8723 variable to compute use_fixed_output.
8724 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
8725 Remove.
8726 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
8727 (mi_multi_location_breakpoint_output_fixed): Remove.
8728 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
8729 new variable.
8730 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
8731 fix_multi_location_breakpoint_output flag if version >= 3.
8732 * ui-out.h (enum ui_out_flag)
8733 <fix_multi_location_breakpoint_output>: New enumerator.
8734
8735 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
8736
8737 * contrib/cc-with-tweaks.sh: Validate dwz's work.
8738
8739 2019-05-10 Tom Tromey <tromey@adacore.com>
8740
8741 * ada-lang.c (catch_ada_completer): New function.
8742 (_initialize_ada_language): Use it.
8743
8744 2019-05-10 Tom Tromey <tromey@adacore.com>
8745
8746 * thread.c (print_thread_info): Make "requested_threads" const.
8747 * gdbthread.h (print_thread_info): Make "requested_threads"
8748 const.
8749 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
8750 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
8751
8752 2019-05-08 Tom Tromey <tom@tromey.com>
8753
8754 * gdbtypes.c (objfile_type_data): Change type.
8755 (objfile_type, _initialize_gdbtypes): Update.
8756
8757 2019-05-08 Tom Tromey <tom@tromey.com>
8758
8759 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
8760 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
8761 (_initialize_dwarf2_frame): Update.
8762
8763 2019-05-08 Tom Tromey <tom@tromey.com>
8764
8765 * objc-lang.c (objc_objfile_data): Change type.
8766 (find_methods): Update.
8767 (_initialize_objc_lang): Remove.
8768
8769 2019-05-08 Tom Tromey <tom@tromey.com>
8770
8771 * stabsread.c (rs6000_builtin_type_data): Change type.
8772 (rs6000_builtin_type, _initialize_stabsread): Update.
8773
8774 2019-05-08 Tom Tromey <tom@tromey.com>
8775
8776 * mips-tdep.c (mips_pdr_data): Remove.
8777 (_initialize_mips_tdep): Update.
8778
8779 2019-05-08 Tom Tromey <tom@tromey.com>
8780
8781 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
8782 (hppa_init_objfile_priv_data, read_unwind_info)
8783 (find_unwind_entry, _initialize_hppa_tdep): Update.
8784
8785 2019-05-08 Tom Tromey <tom@tromey.com>
8786
8787 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
8788 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
8789 on obstack.
8790 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
8791
8792 2019-05-08 Tom Tromey <tom@tromey.com>
8793
8794 * mdebugread.c (basic_type_data): Change type.
8795 (basic_type, _initialize_mdebugread): Update.
8796
8797 2019-05-08 Tom Tromey <tom@tromey.com>
8798
8799 * common/gdb_unique_ptr.h (struct noop_deleter): New.
8800
8801 2019-05-08 Tom Tromey <tom@tromey.com>
8802
8803 * nto-tdep.c (nto_inferior_data_reg): Change type.
8804 (nto_inferior_data): Update.
8805 (nto_inferior_data_cleanup, nto_new_inferior_data)
8806 (_initialize_nto_tdep): Remove.
8807 * nto-tdep.h (struct nto_inferior_data): Add initializers.
8808
8809 2019-05-08 Tom Tromey <tom@tromey.com>
8810
8811 * ada-lang.c (struct ada_inferior_data): Add initializers.
8812 (ada_inferior_data): Change type.
8813 (ada_inferior_data_cleanup): Remove.
8814 (get_ada_inferior_data, ada_inferior_exit)
8815 (struct ada_pspace_data): Add initializers, destructor.
8816 (ada_pspace_data_handle): Change type.
8817 (get_ada_pspace_data): Update.
8818 (ada_pspace_data_cleanup): Remove.
8819
8820 2019-05-08 Tom Tromey <tom@tromey.com>
8821
8822 * coffread.c (struct coff_symfile_info): Add initializers.
8823 (coff_objfile_data_key): Move lower. Change type.
8824 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
8825 Update.
8826 (coff_free_info): Remove.
8827
8828 2019-05-08 Tom Tromey <tom@tromey.com>
8829
8830 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
8831 (fbsd_pspace_data_handle): Move lower. Change type.
8832 (get_fbsd_pspace_data): Update.
8833 (fbsd_pspace_data_cleanup): Remove.
8834 (_initialize_fbsd_tdep): Update.
8835
8836 2019-05-08 Tom Tromey <tom@tromey.com>
8837
8838 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
8839 (get_ada_tasks_pspace_data): Update.
8840 (ada_tasks_pspace_data_cleanup): Remove.
8841 (_initialize_tasks): Update.
8842 (ada_tasks_inferior_data_handle): Change type.
8843 (get_ada_tasks_inferior_data): Update.
8844 (ada_tasks_inferior_data_cleanup): Remove.
8845 (struct ada_tasks_pspace_data): Add initializers.
8846
8847 2019-05-08 Tom Tromey <tom@tromey.com>
8848
8849 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
8850 * symfile-debug.c (debug_sym_get_probes): Change type.
8851 * stap-probe.c (handle_stap_probe):
8852 (stap_static_probe_ops::get_probes): Change type.
8853 * probe.h (class static_probe_ops) <get_probes>: Change type.
8854 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
8855 (parse_probes_in_pspace): Update.
8856 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
8857 Update.
8858 (any_static_probe_ops::get_probes): Change type.
8859 * elfread.c (elfread_data): New typedef.
8860 (probe_key): Change type.
8861 (elf_get_probes): Likewise. Update.
8862 (probe_key_free): Remove.
8863 (_initialize_elfread): Update.
8864 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
8865 Change type.
8866 (dtrace_process_dof_probe, dtrace_process_dof)
8867 (dtrace_static_probe_ops::get_probe): Change type.
8868
8869 2019-05-08 Tom Tromey <tom@tromey.com>
8870
8871 * xcoffread.c (struct xcoff_symfile_info): Rename from
8872 coff_symfile_info. Add initializers.
8873 (xcoff_objfile_data_key): Move lower. Change type.
8874 (XCOFF_DATA): Rewrite.
8875 (xcoff_free_info): Remove.
8876 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
8877 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
8878 (xcoff_initial_scan): Update.
8879
8880 2019-05-08 Tom Tromey <tom@tromey.com>
8881
8882 * solib-svr4.c (struct svr4_info): Add initializers and
8883 destructor.
8884 <probes_table>: Now an htab_up.
8885 (solib_svr4_pspace_data): Change type.
8886 (free_probes_table): Simplify.
8887 (~svr4_info): Rename from svr4_pspace_data_cleanup.
8888 (get_svr4_info, probes_table_htab_remove_objfile_probes)
8889 (probes_table_remove_objfile_probes, register_solib_event_probe)
8890 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
8891 (_initialize_svr4_solib): Update.
8892
8893 2019-05-08 Tom Tromey <tom@tromey.com>
8894
8895 * remote.c (remote_pspace_data): Change type.
8896 (remote_pspace_data_cleanup): Remove.
8897 (get_remote_exec_file, set_pspace_remote_exec_file)
8898 (_initialize_remote): Update.
8899
8900 2019-05-08 Tom Tromey <tom@tromey.com>
8901
8902 * breakpoint.c (breakpoint_objfile_key): Change type.
8903 (get_breakpoint_objfile_data): Update.
8904 (free_breakpoint_objfile_data): Remove.
8905 (_initialize_breakpoint): Update.
8906
8907 2019-05-08 Tom Tromey <tom@tromey.com>
8908
8909 * linux-tdep.c (struct linux_info): Add initializers.
8910 (linux_inferior_data): Move. Change type.
8911 (invalidate_linux_cache_inf): Update.
8912 (linux_inferior_data_cleanup): Remove.
8913 (get_linux_inferior_data, _initialize_linux_tdep): Update.
8914
8915 2019-05-08 Tom Tromey <tom@tromey.com>
8916
8917 * auxv.c (auxv_inferior_data): Move. Change type.
8918 (auxv_inferior_data_cleanup): Remove.
8919 (invalidate_auxv_cache_inf): Rewrite.
8920 (get_auxv_inferior_data, _initialize_auxv): Update.
8921
8922 2019-05-08 Tom Tromey <tom@tromey.com>
8923
8924 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
8925 (symfile_debug_objfile_data_key): Change type.
8926 (symfile_debug_installed, debug_qf_has_symbols)
8927 (debug_qf_find_last_source_symtab)
8928 (debug_qf_forget_cached_source_info)
8929 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
8930 (debug_qf_print_stats, debug_qf_dump)
8931 (debug_qf_expand_symtabs_for_function)
8932 (debug_qf_expand_all_symtabs)
8933 (debug_qf_expand_symtabs_with_fullname)
8934 (debug_qf_map_matching_symbols)
8935 (debug_qf_expand_symtabs_matching)
8936 (debug_qf_find_pc_sect_compunit_symtab)
8937 (debug_qf_map_symbol_filenames)
8938 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
8939 (debug_sym_new_init, debug_sym_init, debug_sym_read)
8940 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
8941 (debug_sym_read_linetable, debug_sym_relocate): Update.
8942 (symfile_debug_free_objfile): Remove.
8943 (install_symfile_debug_logging, _initialize_symfile_debug):
8944 Update.
8945
8946 2019-05-08 Tom Tromey <tom@tromey.com>
8947
8948 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
8949 allocate_on_obstack.
8950 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
8951 (get_dwarf2_per_objfile): Update.
8952 (set_dwarf2_per_objfile): Remove.
8953 (dwarf2_has_info, dwarf2_get_section_info): Update.
8954 (dwarf2_free_objfile): Remove.
8955 (_initialize_dwarf2_read): Update.
8956
8957 2019-05-08 Tom Tromey <tom@tromey.com>
8958
8959 * auto-load.c (struct auto_load_pspace_info): Add destructor and
8960 initializers.
8961 <unsupported_script_warning_printed,
8962 script_not_found_warning_printed>: Now bool.
8963 (auto_load_pspace_data): Change type.
8964 (~auto_load_pspace_info): Rename from
8965 auto_load_pspace_data_cleanup.
8966 (get_auto_load_pspace_data, init_loaded_scripts_info)
8967 (clear_section_scripts, maybe_print_unsupported_script_warning)
8968 (maybe_print_script_not_found_warning, _initialize_auto_load):
8969 Update.
8970
8971 2019-05-08 Tom Tromey <tom@tromey.com>
8972
8973 * objfiles.c (objfile_pspace_info): Add destructor and
8974 initializers.
8975 (objfiles_pspace_data): Change type.
8976 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
8977 (get_objfile_pspace_data): Update.
8978 (objfiles_bfd_data): Change type.
8979 (get_objfile_bfd_data): Update.
8980 (objfile_bfd_data_free, _initialize_objfiles): Remove.
8981
8982 2019-05-08 Tom Tromey <tom@tromey.com>
8983
8984 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
8985 Change type.
8986 (get_catch_syscall_inferior_data): Update.
8987 (catch_syscall_inferior_data_cleanup): Remove.
8988 (_initialize_break_catch_syscall): Update.
8989
8990 2019-05-08 Tom Tromey <tom@tromey.com>
8991
8992 * inflow.c (struct terminal_info): Add destructor and
8993 initializers.
8994 (inflow_inferior_data): Change type.
8995 (~terminal_info): Rename from inflow_inferior_data_cleanup.
8996 (get_inflow_inferior_data, inflow_inferior_exit)
8997 (swap_terminal_info, _initialize_inflow): Update.
8998
8999 2019-05-08 Tom Tromey <tom@tromey.com>
9000
9001 * target-dcache.c (target_dcache_cleanup): Remove.
9002 (target_dcache_aspace_key): Change type.
9003 (target_dcache_init_p, target_dcache_invalidate)
9004 (target_dcache_get, target_dcache_get_or_init)
9005 (_initialize_target_dcache): Update.
9006 * dcache.h (struct dcache_deleter): New.
9007
9008 2019-05-08 Tom Tromey <tom@tromey.com>
9009
9010 * symtab.c (struct symbol_cache): Add destructor and
9011 initializers.
9012 (symbol_cache_key): Move. Change type.
9013 (make_symbol_cache, free_symbol_cache): Remove.
9014 (get_symbol_cache): Update.
9015 (symbol_cache_cleanup): Remove.
9016 (ALL_PSPACES, symbol_cache_flush)
9017 (maintenance_print_symbol_cache)
9018 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9019 Update.
9020
9021 2019-05-08 Tom Tromey <tom@tromey.com>
9022
9023 * symtab.c (struct main_info): Add destructor and initializers.
9024 (main_progspace_key): Move. Change type.
9025 (get_main_info): Update.
9026 (main_info_cleanup): Remove.
9027 (_initialize_symtab): Update.
9028
9029 2019-05-08 Tom Tromey <tom@tromey.com>
9030
9031 * registry.h (DECLARE_REGISTRY): Define the _key class.
9032
9033 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
9034
9035 * NEWS: Merge two 'New commands' sections.
9036
9037 2019-05-08 Joel Brobecker <brobecker@adacore.com>
9038
9039 * ada-valprint.c (ada_val_print_gnat_array): Remove language
9040 parameter and use Ada language definition instead.
9041 (ada_val_print_ptr): Remove unused language parameter.
9042 (ada_val_print_num): Remove language parameter and use Ada language
9043 definition instead.
9044 (ada_val_print_enum, ada_val_print_flt): Remove unused language
9045 parameter.
9046 (ada_val_print_struct_union, ada_val_print_ref): Remove language
9047 parameter and use Ada language definition instead.
9048 (ada_val_print_1): Update all ada_val_print_xxx calls.
9049 Remove language parameter.
9050 (ada_val_print): Update ada_val_print_1 call.
9051
9052 2019-05-08 Tom Tromey <tromey@adacore.com>
9053
9054 * remote.c (remote_hw_watchpoint_limit)
9055 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9056 Now static.
9057
9058 2019-05-08 Tom Tromey <tromey@adacore.com>
9059
9060 * maint.c (_initialize_maint_cmds): Move initialization code to
9061 remote.c.
9062 (watchdog, show_watchdog): Move to remote.c.
9063 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
9064 "watchdog" static.
9065 (_initialize_remote): Move initialization code from maint.c.
9066 * defs.h (watchdog): Don't declare.
9067
9068 2019-05-08 Tom Tromey <tromey@adacore.com>
9069
9070 * tui/tui-interp.c: Include main.h.
9071 * interps.c: Include main.h.
9072 * main.h (interpreter_p): Declare.
9073 * defs.h (interpreter_p): Don't declare.
9074
9075 2019-05-08 Tom Tromey <tromey@adacore.com>
9076
9077 * dwarf2loc.c: Include dwarf2read.h.
9078 * defs.h (read_unsigned_leb128): Don't declare.
9079 * dwarf2read.h (read_unsigned_leb128): Declare.
9080
9081 2019-05-08 Tom Tromey <tromey@adacore.com>
9082
9083 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9084 method.
9085
9086 2019-05-08 Tom Tromey <tromey@adacore.com>
9087
9088 * utils.c (fputs_maybe_filtered): Reset style after paging, even
9089 when no wrap column is set.
9090
9091 2019-05-08 Tom Tromey <tromey@adacore.com>
9092
9093 * c-lang.c (c_get_string): Handle non-C-style arrays.
9094
9095 2019-05-08 Tom Tromey <tromey@adacore.com>
9096
9097 * typeprint.c (print_offset_data::update): Print the bit offset,
9098 not the number of bits remaining.
9099
9100 2019-05-08 Tom Tromey <tromey@adacore.com>
9101
9102 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9103 padding at end of comment.
9104
9105 2019-05-08 Tom Tromey <tromey@adacore.com>
9106
9107 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9108 Compare main types.
9109
9110 2019-05-06 Tom Tromey <tom@tromey.com>
9111
9112 * common/scoped_mmap.c: Include common-defs.h.
9113 * common/scoped_mmap.h: Don't include config.h.
9114
9115 2019-05-04 Tom Tromey <tom@tromey.com>
9116
9117 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9118 (struct aarch64_call_info): Add initializers.
9119 <si>: Now a std::vector.
9120 (pass_on_stack, aarch64_push_dummy_call): Update.
9121
9122 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
9123 Tom Tromey <tom@tromey.com>
9124
9125 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9126 (ppc_threads): Now a std::vector. Now static.
9127 (hwdebug_find_thread_points_by_tid)
9128 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9129 Update.
9130
9131 2019-05-04 Tom Tromey <tom@tromey.com>
9132
9133 * arc-tdep.c (arc_tdesc_init): Return bool.
9134
9135 2019-05-04 Tom Tromey <tom@tromey.com>
9136
9137 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9138 Use gdb_assert_not_reached.
9139
9140 2019-05-04 Tom Tromey <tom@tromey.com>
9141
9142 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9143 "false".
9144
9145 2019-05-04 Tom Tromey <tom@tromey.com>
9146
9147 * arc-tdep.c (arc_tdesc_init): Use bool.
9148
9149 2019-05-04 Tom Tromey <tom@tromey.com>
9150
9151 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9152
9153 2019-05-04 Tom Tromey <tom@tromey.com>
9154
9155 * cli/cli-cmds.c (valid_command_p): Return bool.
9156
9157 2019-05-04 Tom Tromey <tom@tromey.com>
9158
9159 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9160 * command.h (valid_user_defined_cmd_name_p): Channge return type.
9161
9162 2019-05-04 Raul Tambre <raul@tambre.ee>
9163
9164 * python/lib/gdb/prompt.py (_ExtendedPrompt)
9165 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9166 operator for comparison.
9167
9168 2019-05-04 Tom Tromey <tom@tromey.com>
9169
9170 * psymtab.c (psymbol_name_matches, match_partial_symbol)
9171 (lookup_partial_symbol, print_partial_symbols)
9172 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9173 (psymbol_compare): Update.
9174 (add_psymbol_to_bcache): Clear the entire psymbol.
9175 (maintenance_check_psymtabs): Update.
9176 * psympriv.h (struct partial_symbol): Don't derive from
9177 general_symbol_info.
9178 <obj_section, unrelocated_address, address,
9179 set_unrelocated_address>: Update.
9180 <ginfo>: New member.
9181 * dwarf-index-write.c (write_psymbols, debug_names::insert)
9182 (debug_names::write_psymbols): Update.
9183
9184 2019-05-04 Tom de Vries <tdevries@suse.de>
9185
9186 * contrib/cc-with-tweaks.sh: Support -n arg.
9187
9188 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9189
9190 * corelow.c (core_target::detach): Ensure frame cache and
9191 register caches are cleared.
9192 inferior.c (exit_inferior_1): Likewise.
9193
9194 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
9195 Tom Tromey <tom@tromey.com>
9196
9197 * dictionary.c (collate_pending_symbols_by_language): Remove
9198 "struct" from foreach.
9199 * symtab.c (lookup_global_symbol_from_objfile)
9200 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9201 foreach.
9202 * ser-tcp.c (net_open): Remove "struct" from foreach.
9203 * objfiles.c (objfile_relocate, objfile_rebase)
9204 (objfile_has_symbols): Remove "struct" from foreach.
9205 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9206 from foreach.
9207 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9208 foreach.
9209 * darwin-nat.c (thread_info_from_private_thread_info): Remove
9210 "struct" from foreach.
9211 * ada-lang.c (create_excep_cond_exprs)
9212 (ada_exception_catchpoint_cond_string): Remove "struct" from
9213 foreach.
9214
9215 2019-05-03 Tom Tromey <tromey@adacore.com>
9216
9217 * ada-exp.y (convert_char_literal): Check suffix of each
9218 enumerator.
9219
9220 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
9221
9222 PR ada/21406:
9223 * ada-exp.y (yywrap): Don't define.
9224 * ada-lex.l (%option): Add noyywrap
9225 (yywrap): Remove.
9226
9227 2019-05-03 Eli Zaretskii <eliz@gnu.org>
9228
9229 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9230 _WIN32_WINNT to the XP level, unless already defined to a higher
9231 level.
9232
9233 * unittests/parse-connection-spec-selftests.c:
9234 * ser-tcp.c:
9235 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
9236 override.
9237
9238 * symfile.c (find_separate_debug_file): Remove colon from the
9239 drive spec of DOS/Windows file names of the target, so that the
9240 file name produced from DEBUGDIR and the target's directory will
9241 be valid on DOS/Windows systems.
9242
9243 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
9244
9245 * rust-lang.c (val_print_struct): Handle printing structures
9246 containing strings.
9247
9248 2019-05-02 Tom Tromey <tromey@adacore.com>
9249
9250 * valarith.c (_initialize_valarith): Remove.
9251
9252 2019-05-01 Tom Tromey <tromey@adacore.com>
9253
9254 * ada-lang.c (ada_value_primitive_field): Treat more fields as
9255 bitfields.
9256
9257 2019-05-01 Tom Tromey <tromey@adacore.com>
9258
9259 * ada-lang.c (ada_value_assign): Correctly compute starting offset
9260 for big-endian copies.
9261
9262 2019-04-30 Ali Tamur <tamur@google.com>
9263 * gdb/dwarf2read.c (read_3_bytes): New declaration.
9264 (read_attribute_value): Added DW_FORM_strx1-4 cases.
9265 (read_3_bytes): New function.
9266
9267 2019-04-30 Joel Brobecker <brobecker@adacore.com>
9268
9269 * windows-nat.c (main_thread_id): Delete.
9270 (handle_output_debug_string): Replace main_thread_id by
9271 current_event.dwThreadId.
9272 (fake_create_process): Likewise.
9273 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9274 Do not set main_thread_id.
9275 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9276 current_event.dwThreadId.
9277 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9278
9279 2019-04-30 Joel Brobecker <brobecker@adacore.com>
9280
9281 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9282 Use current_event.dwThreadId instead of main_thread_id.
9283
9284 2019-04-30 Tom Tromey <tromey@adacore.com>
9285
9286 * ada-lang.c (ada_lookup_simple_minsyms): New function.
9287 (create_excep_cond_exprs): Iterate over program spaces.
9288 (ada_exception_catchpoint_cond_string): Examine all minimal
9289 symbols for exception types.
9290
9291 2019-04-30 Tom Tromey <tromey@adacore.com>
9292
9293 PR c++/24470:
9294 * dwarf2read.c (process_structure_scope): Handle case where type
9295 has template parameters but no symbol was created.
9296
9297 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9298 Chris January <chris.january@arm.com>
9299
9300 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9301 qualifier.
9302 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9303
9304 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9305
9306 * f-typeprint.c (f_print_type): Update rules for printing
9307 whitespace.
9308 (f_type_print_varspec_suffix): Likewise.
9309
9310 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9311 Chris January <chris.january@arm.com>
9312
9313 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9314 function arguments.
9315
9316 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9317
9318 * f-lang.c (build_fortran_types): Change name of void type to
9319 lower case.
9320 * f-typeprint.c (f_type_print_base): Print the name of the void
9321 type, rather than a fixed string.
9322 * f-valprint.c (f_decorations): Use lower case void string.
9323
9324 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9325 Chris January <chris.january@arm.com>
9326
9327 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9328 types for Fortran.
9329
9330 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9331 Chris January <chris.january@arm.com>
9332 David Lecomber <david.lecomber@arm.com>
9333
9334 * f-exp.y (BINOP_INTRINSIC): New token.
9335 (exp): New parser rule handling BINOP_INTRINSIC.
9336 (f77_keywords): Add new builtin procedures.
9337 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9338 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9339 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9340 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9341 (print_unop_subexp_f): New function.
9342 (print_binop_subexp_f): New function.
9343 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9344 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9345 (dump_subexp_body_f): Likewise.
9346 (operator_check_f): Likewise.
9347 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9348 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9349
9350 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9351
9352 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9353 UNOP_KIND.
9354 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9355 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9356 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9357 (operator_length_f): New fuction.
9358 (print_subexp_f): New function.
9359 (op_name_f): New function.
9360 (dump_subexp_body_f): New function.
9361 (operator_check_f): New function.
9362 (exp_descriptor_f): Replace standard expression handling functions
9363 with new functions.
9364 * gdb/fortran-operator.def: New file.
9365 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9366 * gdb/std-operator.def: Remove UNOP_KIND.
9367
9368 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
9369
9370 * std-operator.def: Remove unbalanced, stray double quote
9371 character.
9372
9373 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
9374 Chris January <chris.january@arm.com>
9375 Daniel Everett <daniel.everett@arm.com>
9376 Nick Forrington <nick.forrington@arm.com>
9377 Richard Bunt <richard.bunt@arm.com>
9378
9379 * cp-valprint.c (cp_print_value_fields): Allow an additional level
9380 of depth when printing anonymous structs or unions.
9381 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9382 Don't print either the top-level value, or the children if the
9383 max-depth is exceeded.
9384 (ppscm_print_children): When printing the key of a map, allow one
9385 extra level of depth.
9386 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9387 print either the top-level value, or the children if the max-depth
9388 is exceeded.
9389 (print_children): When printing the key of a map, allow one extra
9390 level of depth.
9391 * python/py-value.c (valpy_format_string): Add max_depth keyword.
9392 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9393 (user_print_options): Initialise max_depth field.
9394 (val_print_scalar_or_string_type_p): New function.
9395 (val_print): Check to see if the max depth has been reached.
9396 (val_print_check_max_depth): Define new function.
9397 (show_print_max_depth): New function.
9398 (_initialize_valprint): Add 'print max-depth' option.
9399 * valprint.h (struct value_print_options) <max_depth>: New field.
9400 (val_print_check_max_depth): Declare new function.
9401 * NEWS: Document new feature.
9402
9403 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
9404
9405 * ada-lang.c (ada_language_defn): Initialise new field.
9406 * c-lang.c (c_is_string_type_p): New function.
9407 (c_language_defn): Initialise new field.
9408 (cplus_language_defn): Initialise new field.
9409 (asm_language_defn): Initialise new field.
9410 (minimal_language_defn): Initialise new field.
9411 * c-lang.h (c_is_string_type_p): Declare new function.
9412 * d-lang.c (d_language_defn): Initialise new field.
9413 * f-lang.c (f_is_string_type_p): New function.
9414 (f_language_defn): Initialise new field.
9415 * go-lang.c (go_is_string_type_p): New function.
9416 (go_language_defn): Initialise new field.
9417 * language.c (default_is_string_type_p): New function.
9418 (unknown_language_defn): Initialise new field.
9419 (auto_language_defn): Initialise new field.
9420 * language.h (struct language_defn) <la_is_string_type_p>: New
9421 member variable.
9422 (default_is_string_type_p): Declare new function.
9423 * m2-lang.c (m2_language_defn): Initialise new field.
9424 * objc-lang.c (objc_language_defn): Initialise new field.
9425 * opencl-lang.c (opencl_language_defn): Initialise new field.
9426 * p-lang.c (pascal_is_string_type_p): New function.
9427 (pascal_language_defn): Initialise new field.
9428 * rust-lang.c (rust_is_string_type_p): New function.
9429 (rust_language_defn): Initialise new field.
9430
9431 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
9432
9433 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
9434 New field.
9435 * ada-lang.c (ada_language_defn): Initialise new field.
9436 * c-lang.c (c_language_defn): Likewise.
9437 (cplus_language_defn): Likewise.
9438 (asm_language_defn): Likewise.
9439 (minimal_language_defn): Likewise.
9440 * d-lang.c (d_language_defn): Likewise.
9441 * f-lang.c (f_language_defn): Likewise.
9442 * go-lang.c (go_language_defn): Likewise.
9443 * language.c (unknown_language_defn): Likewise.
9444 (auto_language_defn): Likewise.
9445 * m2-lang.c (m2_language_defn): Likewise.
9446 * objc-lang.c (objc_language_defn): Likewise.
9447 * opencl-lang.c (opencl_language_defn): Likewise.
9448 * p-lang.c (pascal_language_defn): Likewise.
9449 * rust-lang.c (rust_language_defn): Likewise.
9450
9451 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
9452
9453 * ada-lang.c (ada_is_character_type): Change return type to bool.
9454 (ada_is_string_type): Likewise.
9455 * ada-lang.h (ada_is_character_type): Update declaration
9456 (ada_is_string_type): Likewise.
9457
9458 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9459
9460 Support style in 'frame|thread apply'
9461
9462 * gdbcmd.h (execute_command_to_string): New term_out parameter.
9463 * record.c (record_start, record_stop): Update callers of
9464 execute_command_to_string with false.
9465 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
9466 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
9467 methods.
9468 (class string_file): New constructor with term_out parameter.
9469 Override methods term_out and can_emit_style_escape. New member
9470 term_out.
9471 (class stdio_file): Override can_emit_style_escape.
9472 (class tee_file): Override term_out and can_emit_style_escape.
9473 * utils.h (can_emit_style_escape): Remove.
9474 * utils.c (can_emit_style_escape): Likewise.
9475 Update all callers of can_emit_style_escape (SOMESTREAM) to
9476 SOMESTREAM->can_emit_style_escape.
9477 * source-cache.c (source_cache::get_source_lines): Likewise.
9478 * stack.c (frame_apply_command_count): Call execute_command_to_string
9479 passing the term_out characteristic of the current gdb_stdout.
9480 * thread.c (thr_try_catch_cmd): Likewise.
9481 * top.c (execute_command_to_string): pass term_out parameter
9482 to construct the string_file for the command output.
9483 * ui-file.c (term_cli_styling): New function (most code moved
9484 from utils.c can_emit_style_escape).
9485 (string_file::string_file, string_file::can_emit_style_escape,
9486 stdio_file::can_emit_style_escape, tee_file::term_out,
9487 tee_file::can_emit_style_escape): New functions.
9488
9489 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9490
9491 * NEWS: Mention the new set|show may-call-functions.
9492 * infcall.c (may_call_functions_p): New variable.
9493 (show_may_call_functions_p): New function.
9494 (call_function_by_hand_dummy): Throws an error if not
9495 may-call-functions.
9496 (_initialize_infcall): Call add_setshow_boolean_cmd for
9497 may-call-functions.
9498
9499 2019-04-25 Keith Seitz <keiths@redhat.com>
9500
9501 PR c++/24367
9502 * cp-support.c (inspect_type): Don't attempt substitutions
9503 of symbol with the same name.
9504
9505 2019-04-25 Tom Tromey <tromey@adacore.com>
9506
9507 PR gdb/24475:
9508 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
9509 static.
9510
9511 2019-04-25 Tom Tromey <tromey@adacore.com>
9512
9513 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
9514 rvalue reference.
9515 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
9516 (gdb_xml_parser::parse): Use std::move.
9517 * python/python-internal.h (gdbpy_convert_exception): Take a const
9518 reference.
9519 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
9520 std::move.
9521 * python/py-utils.c (gdbpy_convert_exception): Take a const
9522 reference.
9523 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9524 Use std::move.
9525 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9526 Use std::move.
9527 * mi/mi-main.c (mi_print_exception): Take a const reference.
9528 * main.c (handle_command_errors): Take a const reference.
9529 * linespec.c (parse_linespec): Use std::move.
9530 * infcall.c (run_inferior_call): Use std::move.
9531 (call_function_by_hand_dummy): Use std::move.
9532 * exec.c (try_open_exec_file): Use std::move.
9533 * exceptions.h (exception_print, exception_fprintf)
9534 (exception_print_same): Update.
9535 * exceptions.c (print_exception, exception_print)
9536 (exception_fprintf, exception_print_same): Change parameters to
9537 const reference.
9538 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
9539 * common/new-op.c: Use std::move.
9540 * common/common-exceptions.h (struct gdb_exception): Add move
9541 constructor.
9542 (struct gdb_exception_error, struct gdb_exception_quit, struct
9543 gdb_quit_bad_alloc): Change constructor to move constructor.
9544 (throw_exception): Change parameter to rvalue reference.
9545 * common/common-exceptions.c (throw_exception): Take rvalue
9546 reference.
9547 * cli/cli-interp.c (safe_execute_command): Use std::move.
9548 * breakpoint.c (insert_bp_location, location_to_sals): Use
9549 std::move.
9550
9551 2019-04-25 Tom Tromey <tromey@adacore.com>
9552
9553 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
9554 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
9555 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
9556 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
9557 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
9558 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
9559 guile/scm-value.c: Use unpack.
9560 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
9561 gdbscm_gdb_exception.
9562 (gdbscm_throw_gdb_exception): Likewise.
9563 (struct gdbscm_gdb_exception): New.
9564 (unpack): New function.
9565 (gdbscm_wrap): Use unpack.
9566
9567 2019-04-25 Tom Tromey <tromey@adacore.com>
9568
9569 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9570 (gdb_rl_callback_handler): Use std::move.
9571 * common/common-exceptions.h (struct gdb_exception): Add move
9572 assignment operator.
9573 (throw_exception_sjlj): Change "exception" to const reference.
9574 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
9575 (throw_exception_sjlj): Change "exception" to const reference.
9576
9577 2019-04-25 Tom Tromey <tromey@adacore.com>
9578
9579 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
9580 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
9581 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
9582 Update.
9583 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
9584 Update.
9585 * mi/mi-interp.c (mi_interp::exec): Update.
9586 * linespec.c (parse_linespec): Update.
9587 * infcall.c (run_inferior_call): Update.
9588 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
9589 * guile/scm-symbol.c (gdbscm_lookup_symbol)
9590 (gdbscm_lookup_global_symbol): Update.
9591 * guile/scm-param.c (gdbscm_parameter_value): Update.
9592 * guile/scm-frame.c (gdbscm_frame_read_register)
9593 (gdbscm_frame_read_var): Update.
9594 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
9595 * exec.c (try_open_exec_file): Update.
9596 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
9597 (gdb_rl_callback_handler): Update.
9598 * common/common-exceptions.h (exception_none): Don't declare.
9599 * common/common-exceptions.c (exception_none): Don't define.
9600 (struct catcher) <exception>: Update.
9601 * cli/cli-interp.c (safe_execute_command): Update.
9602 * breakpoint.c (insert_bp_location, location_to_sals): Update.
9603
9604 2019-04-25 Ali Tamur <tamur@google.com>
9605
9606 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
9607 (read_attribute_value): Likewise.
9608 (dwarf2_read_addr_index): Update comment.
9609 (read_str_index): Add DW_FORM_strx.
9610 (dwarf2_string_attr): Likewise.
9611 (dwarf2_const_value_attr): Likewise.
9612 (dump_die_shallow): Likewise.
9613 (dwarf2_fetch_constant_bytes): Likewise.
9614 (skip_form_bytes): Likewise.
9615 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
9616
9617 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
9618
9619 PR corefiles/11608
9620 PR corefiles/18187
9621 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
9622 OFFSET. Verify if current mapping contains an ELF header.
9623 (linux_find_memory_regions_full): Adjust call to
9624 dump_mapping_p.
9625
9626 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
9627 Kang Li <kanglictf@gmail.com>
9628
9629 PR gdb/21600
9630
9631 * dwarf2-frame.c (read_initial_length): Be consistent about using
9632 unsigned representation of length.
9633 (decode_frame_entry_1): Likewise. Check for wraparound of
9634 end pointer as well as buffer overflow.
9635
9636 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
9637
9638 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
9639 "vq".
9640
9641 2019-04-24 Tom Tromey <tromey@adacore.com>
9642
9643 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
9644
9645 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9646
9647 * s12z-tdep.c (s12z_unwind_pc): Delete.
9648 (s12z_unwind_sp): Delete.
9649 (s12z_gdbarch_init): Don't register deleted functions with
9650 gdbarch.
9651
9652 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9653
9654 * rl78-tdep.c (rl78_unwind_sp): Delete.
9655 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
9656
9657 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9658
9659 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
9660 (xstormy16_unwind_pc): Delete.
9661 (xstormy16_dummy_id): Delete.
9662 (xstormy16_gdbarch_init): Don't register deleted functions with
9663 gdbarch.
9664
9665 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9666
9667 * vax-tdep.c (vax_unwind_pc): Delete.
9668 (vax_gdbarch_init): Don't register deleted function with gdbarch.
9669
9670 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9671
9672 * v850-tdep.c (v850_unwind_sp): Delete.
9673 (v850_unwind_pc): Delete.
9674 (v850_dummy_id): Delete.
9675 (v850_gdbarch_init): Don't register deleted functions with
9676 gdbarch.
9677
9678 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9679
9680 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
9681 (tilegx_unwind_pc): Delete.
9682 (tilegx_unwind_dummy_id): Delete.
9683 (tilegx_gdbarch_init): Don't register deleted functions with
9684 gdbarch.
9685
9686 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9687
9688 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
9689 (tic6x_dummy_id): Delete.
9690 (tic6x_gdbarch_init): Don't register deleted functions with
9691 gdbarch.
9692
9693 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9694
9695 * sparc-tdep.c (sparc_unwind_pc): Delete.
9696 (sparc32_gdbarch_init): Don't register deleted function with
9697 gdbarch.
9698
9699 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9700
9701 * sh-tdep.c (sh_unwind_sp): Delete.
9702 (sh_unwind_pc): Delete.
9703 (sh_dummy_id): Delete.
9704 (sh_gdbarch_init): Don't register deleted functions with
9705 gdbarch.
9706
9707 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9708
9709 * score-tdep.c (score_unwind_sp): Delete.
9710 (score_unwind_pc): Delete.
9711 (score_dummy_id): Delete.
9712 (score_gdbarch_init): Don't register deleted functions with
9713 gdbarch.
9714
9715 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9716
9717 * rx-tdep.c (rx_unwind_pc): Delete.
9718 (rx_unwind_sp): Delete.
9719 (rx_dummy_id): Delete.
9720 (rx_gdbarch_init): Don't register deleted functions with
9721 gdbarch. Update comment.
9722
9723 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9724
9725 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
9726 (rs6000_dummy_id): Delete.
9727 (rs6000_gdbarch_init): Don't register deleted functions with
9728 gdbarch.
9729
9730 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9731
9732 * or1k-tdep.c (or1k_dummy_id): Delete.
9733 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
9734
9735 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9736
9737 * nios2-tdep.c (nios2_dummy_id): Delete.
9738 (nios2_unwind_sp): Delete.
9739 (nios2_gdbarch_init): Don't register deleted functions with
9740 gdbarch.
9741
9742 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9743
9744 * nds32-tdep.c (nds32_dummy_id): Delete.
9745 (nds32_unwind_pc): Delete.
9746 (nds32_unwind_sp): Delete.
9747 (nds32_gdbarch_init): Don't register deleted functions with
9748 gdbarch.
9749
9750 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9751
9752 * msp430-tdep.c (msp430_unwind_pc): Delete.
9753 (msp430_unwind_sp): Delete.
9754 (msp430_dummy_id): Delete.
9755 (msp430_gdbarch_init): Don't register deleted functions with
9756 gdbarch.
9757
9758 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9759
9760 * moxie-tdep.c (moxie_unwind_sp): Delete.
9761 (moxie_unwind_pc): Delete.
9762 (moxie_dummy_id): Delete.
9763 (moxie_gdbarch_init): Don't register deleted functions with
9764 gdbarch.
9765
9766 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9767
9768 * mn10300-tdep.c (mn10300_dummy_id): Delete.
9769 (mn10300_unwind_pc): Delete.
9770 (mn10300_unwind_sp): Delete.
9771 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
9772 mn10300_unwind_sp.
9773 (mn10300_frame_unwind_init): Don't register deleted functions with
9774 gdbarch.
9775
9776 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9777
9778 * mep-tdep.c (mep_unwind_pc): Delete.
9779 (mep_unwind_sp): Delete.
9780 (mep_dummy_id): Delete.
9781 (mep_gdbarch_init): Don't register deleted functions with
9782 gdbarch.
9783
9784 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9785
9786 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
9787 (m68hc11_unwind_sp): Delete.
9788 (m68hc11_gdbarch_init): Don't register deleted functions with
9789 gdbarch.
9790
9791 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9792
9793 * m32r-tdep.c (m32r_unwind_sp): Delete.
9794 (m32r_unwind_pc): Delete.
9795 (m32r_dummy_id): Delete.
9796 (m32r_gdbarch_init): Don't register deleted functions with
9797 gdbarch.
9798
9799 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9800
9801 * m32c-tdep.c (m32c_unwind_pc): Delete.
9802 (m32c_unwind_sp): Delete.
9803 (m32c_dummy_id): Delete.
9804 (m32c_gdbarch_init): Don't register deleted functions with
9805 gdbarch.
9806
9807 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9808
9809 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
9810 (lm32_unwind_pc): Delete.
9811 (lm32_dummy_id): Delete.
9812 (lm32_gdbarch_init): Don't register deleted functions with
9813 gdbarch.
9814
9815 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9816
9817 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
9818 (iq2000_unwind_pc): Delete.
9819 (iq2000_dummy_id): Delete.
9820 (iq2000_gdbarch_init): Don't register deleted functions with
9821 gdbarch.
9822
9823 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9824
9825 * nds32-tdep.c (nds32_type_align): Delete.
9826 (nds32_push_dummy_call): Use type_align instead.
9827
9828 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9829
9830 * arm-tdep.c (arm_type_align): Only handle vector override case.
9831 (arm_push_dummy_call): Use type_align.
9832 (arm_gdbarch_init): Register arm_type_align gdbarch function.
9833
9834 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
9835
9836 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
9837 case.
9838 (pass_on_stack): Use type_align.
9839 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
9840 function.
9841
9842 2019-04-23 Tom Tromey <tromey@adacore.com>
9843
9844 * dwarf2read.c (line_header::file_name_at): Remove unused
9845 overload.
9846
9847 2019-04-23 Tom de Vries <tdevries@suse.de>
9848
9849 PR gdb/24438
9850 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
9851 invocation.
9852
9853
9854 2019-03-27 Ali Tamur <tamur@google.com>
9855
9856 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
9857 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
9858 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
9859 (dwarf_expr_context::get_addr_index): Likewise
9860 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
9861 (symbol_needs_eval_context::get_addr_index): Likewise
9862 (disassemble_dwarf_expression): Add DW_OP_addrx
9863 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
9864 (read_cutu_die_from_dwo): Update comment
9865 (skip_one_die): Add DW_FORM_addrx
9866 (read_attribute_value): Likewise
9867 (var_decode_location): Add DW_OP_addrx
9868 (dwarf2_const_value_attr): Add DW_FORM_addrx
9869 (dump_die_shallow): Likewise
9870 (dwarf2_fetch_constant_bytes): Likewise
9871 (decode_locdesc): Add DW_OP_addrx
9872 (skip_form_bytes): Add DW_FORM_addrx
9873
9874 2019-04-22 Ali Tamur <tamur@google.com>
9875
9876 * MAINTAINERS (Write After Approval): Add self.
9877
9878 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
9879
9880 * solib-svr4.c (get_svr4_info): Add pspace parameter.
9881 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
9882 (open_symbol_file_object): Likewise.
9883 (svr4_default_sos): Add info parameter.
9884 (svr4_read_so_list): Likewise.
9885 (svr4_current_sos_direct): Adjust functions calls to pass down
9886 info.
9887 (svr4_current_sos_1): Add info parameter.
9888 (svr4_current_sos): Call get_svr4_info, pass info down to
9889 svr4_current_sos_1.
9890 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
9891 get_svr4_info.
9892 (svr4_in_dynsym_resolve_code): Pass current_program_space to
9893 get_svr4_info.
9894 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
9895 to get_svr4_info.
9896 (probes_table_remove_objfile_probes): Likewise.
9897 (register_solib_event_probe): Add info parameter.
9898 (solist_update_incremental): Pass info parameter down to
9899 svr4_read_so_list.
9900 (disable_probes_interface): Add info parameter.
9901 (svr4_handle_solib_event): Pass current_program_space to
9902 get_svr4_info. Adjust disable_probes_interface cleanup.
9903 (svr4_create_probe_breakpoints): Add info parameter, pass it
9904 down to register_solib_event_probe.
9905 (svr4_create_solib_event_breakpoints): Add info parameter,
9906 pass it down to svr4_create_probe_breakpoints.
9907 (enable_break): Pass info down to
9908 svr4_create_solib_event_breakpoints.
9909 (svr4_solib_create_inferior_hook): Pass current_program_space to
9910 get_svr4_info.
9911 (svr4_clear_solib): Likewise.
9912
9913 2019-04-22 Pedro Alves <palves@redhat.com>
9914
9915 * solib-svr4.c (svr4_free_objfile_observer): New.
9916 (probe_and_action::objfile): New field.
9917 (probes_table_htab_remove_objfile_probes)
9918 (probes_table_remove_objfile_probes): New functions.
9919 (register_solib_event_probe): Add 'objfile' parameter. Store it
9920 in the new probe_and_action. Don't store the probe in 'lookup'.
9921 (svr4_create_probe_breakpoints): Pass objfile to
9922 register_solib_event_probe.
9923 (_initialize_svr4_solib): Register a free_objfile observer.
9924
9925 2019-04-19 Tom Tromey <tom@tromey.com>
9926
9927 * common/queue.h: Remove.
9928
9929 2019-04-19 Tom Tromey <tom@tromey.com>
9930
9931 * event-loop.c: Don't include "common/queue.h".
9932
9933 2019-04-19 Tom Tromey <tom@tromey.com>
9934
9935 * remote.c (remote_target): Use delete.
9936 * remote-notif.h: Include <list>, not "common/queue.h".
9937 (notif_client_p): Remove typedef.
9938 (remote_notif_state): Add constructor, destructor, initializer.
9939 <notif_queue>: Now a std::list.
9940 (remote_notif_state_xfree): Don't declare.
9941 * remote-notif.c (remote_notif_process, handle_notification)
9942 (remote_notif_state_allocate): Update.
9943 (~remote_notif_state): Rename from remote_notif_state_xfree.
9944
9945 2019-04-19 Tom Tromey <tom@tromey.com>
9946
9947 * symfile.c (reread_symbols): Update.
9948 * objfiles.c (objfile_register_static_link)
9949 (objfile_lookup_static_link): Update
9950 (~objfile) Don't delete static_links.
9951 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
9952
9953 2019-04-19 Tom Tromey <tom@tromey.com>
9954
9955 * type-stack.h (struct type_stack) <insert>: Constify string.
9956 * type-stack.c (type_stack::insert): Constify string.
9957 * gdbtypes.h (lookup_template_type): Update.
9958 (address_space_name_to_int): Update.
9959 * gdbtypes.c (address_space_name_to_int): Make space_identifier
9960 const.
9961 (lookup_template_type): Make name const.
9962 * c-exp.y: Update rules.
9963 (lex_one_token, classify_name, classify_inner_name)
9964 (c_print_token): Update.
9965 * p-exp.y: Update rules.
9966 (yylex): Update.
9967 * f-exp.y: Update rules.
9968 (yylex): Update.
9969 * d-exp.y: Update rules.
9970 (lex_one_token, classify_name, classify_inner_name): Update.
9971 * parse.c (write_dollar_variable, copy_name): Return std::string.
9972 * parser-defs.h (copy_name): Change return type.
9973 * m2-exp.y: Update rules.
9974 (yylex): Update.
9975 * go-exp.y (lex_one_token): Update.
9976 Update rules.
9977 (classify_unsafe_function, classify_packaged_name)
9978 (classify_name, yylex): Update.
9979
9980 2019-04-19 Sergei Trofimovich <siarheit@google.com>
9981
9982 * configure.ac: add --enable-source-highlight switch.
9983 * configure: Regenerate.
9984 * top.c (print_gdb_version): plumb --enable-source-highlight
9985 status to "show configuration".
9986
9987 2019-04-19 Tom Tromey <tromey@adacore.com>
9988
9989 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
9990 Check ADA_TYPE_P.
9991 (empty_record, ada_template_to_fixed_record_type_1)
9992 (template_to_static_fixed_type)
9993 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
9994 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
9995 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
9996 macros.
9997
9998 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
9999
10000 PR symtab/24423:
10001 * source.c (print_source_lines_base): Advance "iter" when a
10002 control character is seen.
10003
10004 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10005
10006 * inferior.h (struct infcall_suspend_state_deleter):
10007 Catch exception in destructor to avoid crash.
10008
10009 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10010
10011 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10012 close to the add_com "shell".
10013
10014 2019-04-18 Tom Tromey <tromey@adacore.com>
10015
10016 * process-stratum-target.h (class process_stratum_target)
10017 <stratum>: Add "final".
10018
10019 2019-04-17 Tom Tromey <tromey@adacore.com>
10020
10021 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10022 against nullptr before use.
10023
10024 2019-04-17 Alan Hayward <alan.hayward@arm.com>
10025
10026 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10027
10028 2019-04-17 Jim Wilson <jimw@sifive.com>
10029 Andrew Burgess <andrew.burgess@embecosm.com>
10030
10031 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10032 code read might fail, assume 4-byte breakpoint in that case.
10033
10034 2019-04-15 Leszek Swirski <leszeks@google.com>
10035
10036 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10037 rather than a hand-rolled POD check when checking for forced MEMORY
10038 classification.
10039
10040 2019-04-15 Alan Hayward <alan.hayward@arm.com>
10041
10042 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10043 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10044 function.
10045 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10046 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10047 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10048 declaration.
10049
10050 2019-04-15 Alan Hayward <alan.hayward@arm.com>
10051
10052 * aarch64-linux-nat.c
10053 (aarch64_linux_nat_target::thread_architecture): Add override.
10054 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10055 each VQ.
10056
10057 2019-04-15 Alan Hayward <alan.hayward@arm.com>
10058
10059 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10060
10061 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
10062
10063 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10064 target types of size 96-bits, add some additional comments, and
10065 check that the builtin type we found was the correct size.
10066
10067 2019-04-12 Eli Zaretskii <eliz@gnu.org>
10068
10069 * utils.c (prompt_for_continue): Don't restore the styling at the
10070 end, as applied_style has the wrong value. This fixes styling in
10071 long lists of file names that are interrupted by the "Continue?"
10072 prompt.
10073
10074 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
10075
10076 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10077 * c-lang.c (c_language_defn): Likewise.
10078 (cplus_language_defn): Likewise.
10079 (asm_language_defn): Likewise.
10080 (minimal_language_defn): Likewise.
10081 * d-lang.c (d_language_defn): Likewise.
10082 * f-lang.c (f_language_defn): Likewise.
10083 * go-lang.c (go_language_defn): Likewise.
10084 * language.c (unknown_language_defn): Likewise.
10085 (auto_language_defn): Likewise.
10086 * language.h (struct language_defn): Remove la_magic field.
10087 (LANG_MAGIC): Delete.
10088 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10089 * objc-lang.c (objc_language_defn): Likewise.
10090 * opencl-lang.c (opencl_language_defn): Likewise.
10091 * p-lang.c (pascal_language_defn): Likewise.
10092 * rust-lang.c (rust_language_defn): Likewise.
10093
10094 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10095
10096 * riscv-tdep.c (riscv_type_align): New function.
10097 (riscv_type_alignment): Delete.
10098 (riscv_arg_location): Use 'type_align'.
10099 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10100
10101 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10102
10103 * gdbtypes.c (type_align): A struct with no non-static fields also
10104 has alignment of 1.
10105
10106 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10107
10108 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10109 component to 0.
10110 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10111 member.
10112 (riscv_struct_info::analyse): New implementation using new
10113 analyse_inner member function.
10114 (riscv_struct_info::field_offset): New member function.
10115 (riscv_struct_info::m_offsets): New member variable.
10116 (riscv_struct_info::analyse_inner): New private member function,
10117 takes the old implementation of riscv_struct_info::analyse but
10118 extended to track field offsets.
10119 (riscv_call_arg_struct): Update the struct folding special cases
10120 to handle cases where empty C++ structs, which are non-zero
10121 length, are found.
10122 (riscv_arg_location): Initialise the length of each location, a
10123 non-zero length now indicates the location is in use.
10124 (riscv_push_dummy_call): Allow for the first location having a
10125 non-zero offset when setting up arguments.
10126 (riscv_return_value): Likewise, but for return values.
10127
10128 2019-04-11 Tom Tromey <tromey@adacore.com>
10129
10130 * utils.c (internal_vproblem): Make "msg" const.
10131
10132 2019-04-11 Alan Hayward <alan.hayward@arm.com>
10133
10134 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10135 * trad-frame.c (trad_frame_reset_saved_regs): New function.
10136 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10137 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10138
10139 2019-04-10 Kevin Buettner <kevinb@redhat.com>
10140
10141 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10142 function.
10143 (fill_gregset): Call amd64_linux_collect_native_gregset instead
10144 of amd64_collect_native_gregset.
10145 (amd64_linux_nat_target::store_registers): Likewise.
10146
10147 2019-04-10 Tom Tromey <tom@tromey.com>
10148
10149 * symtab.c (lookup_global_symbol_from_objfile)
10150 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10151 * objfiles.h (class separate_debug_iterator): New.
10152 (class separate_debug_range): New.
10153 (struct objfile) <separate_debug_objfiles>: New method.
10154 (objfile_separate_debug_iterate): Don't declare.
10155 * objfiles.c (separate_debug_iterator::operator++): Rename from
10156 objfile_separate_debug_iterate.
10157 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10158 iterator.
10159 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10160 iterator.
10161
10162 2019-04-10 Tom Tromey <tom@tromey.com>
10163
10164 * symfile.c (reread_symbols): Remove old comment.
10165 * objfiles.c (free_all_objfiles): Fix a typo.
10166
10167 2019-04-10 Tom Tromey <tom@tromey.com>
10168
10169 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10170 * minsyms.c (lookup_minimal_symbol): Use foreach.
10171 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10172 (lookup_minimal_symbol_solib_trampoline): Likewise.
10173 * symfile.c (reread_symbols): Use foreach.
10174
10175 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
10176 Tom Tromey <tromey@adacore.com>
10177
10178 PR rust/24414:
10179 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10180 (rust_lex_int_test): Change "value" to be LONGEST.
10181 (rust_lex_tests): Add test for long integer literal.
10182
10183 2019-04-09 Tom Tromey <tromey@adacore.com>
10184
10185 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10186 to bool.
10187 (extended_remote_target::attach): Update.
10188 (remote_target::remote_notice_new_inferior): Update.
10189 (remote_target::add_current_inferior_and_thread): Update.
10190 * inferior.c (exit_inferior_1): Use "false".
10191 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10192
10193 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
10194
10195 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10196 the "start" command.
10197
10198 2019-04-08 Kevin Buettner <kevinb@redhat.com>
10199
10200 * python/py-inferior.c (infpy_thread_from_thread_handle):
10201 Adjust comments to reflect renaming of thread_from_thread_handle
10202 to thread_from_handle. Adjust keywords. Fix type error message.
10203 (inferior_object_methods): Add thread_from_handle. Retain
10204 thread_from_thread_handle, but mark it as deprecated.
10205
10206 2019-04-08 Kevin Buettner <kevinb@redhat.com>
10207
10208 * gdbthread.h (find_thread_by_handle): Revise declaration.
10209 * thread.c (find_thread_by_handle): Likewise. Adjust
10210 implementation too.
10211 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10212 support for buffer objects as handles.
10213
10214 2019-04-08 Kevin Buettner <kevinb@redhat.com>
10215
10216 * python/py-infthread.c (thpy_thread_handle): New function.
10217 (thread_object_methods): Register thpy_thread_handle.
10218
10219 2019-04-08 Kevin Buettner <kevinb@redhat.com>
10220
10221 * gdbthread.h (thread_to_thread_handle): Declare.
10222 * thread.c (gdbtypes.h): Include.
10223 (thread_to_thread_handle): New function.
10224
10225 * target.h (struct target_ops): Add thread_info_to_thread_handle.
10226 (target_thread_info_to_thread_handle): Declare.
10227 * target.c (target_thread_info_to_thread_handle): New function.
10228 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10229 * target-delegates.c: Regenerate.
10230
10231 * linux-thread-db.c (class thread_db_target): Add method
10232 thread_info_to_thread_handle.
10233 (thread_db_target::thread_info_to_thread_handle): Define.
10234 * remote.c (class remote_target): Add new method
10235 thread_info_to_thread_handle.
10236 (remote_target::thread_info_to_thread_handle): Define.
10237
10238 2019-04-08 Pedro Alves <palves@redhat.com>
10239
10240 * common/common-exceptions.c (throw_exception): Don't create
10241 named object to throw; throw directly.
10242 (throw_it): Likewise. Don't initialize gdb_exception::message
10243 here, with new; pass FMT and AP to the ctor instead.
10244 * common/common-exceptions.h: Include <string>.
10245 (gdb_exception::gdb_exception(enum return_reason, enum errors,
10246 const char *, va_list)): New ctor. Use std::make_shared.
10247 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10248 errors)): Delete.
10249 (gdb_exception_error::gdb_exception_error(enum errors, const char
10250 *, va_list)): New.
10251 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10252 Add assertion.
10253 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10254 errors)): Delete.
10255 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10256 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10257 Add assertion.
10258
10259 2019-04-08 Tom Tromey <tom@tromey.com>
10260
10261 * valops.c (value_rtti_indirect_type): Replace throw_exception
10262 with throw.
10263 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10264 with throw.
10265 * thread.c (thr_try_catch_cmd): Replace throw_exception with
10266 throw.
10267 * target.c (target_translate_tls_address): Replace throw_exception
10268 with throw.
10269 * stack.c (frame_apply_command_count): Replace throw_exception
10270 with throw.
10271 * solib-spu.c (append_ocl_sos): Replace throw_exception with
10272 throw.
10273 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10274 with throw.
10275 * rs6000-tdep.c (rs6000_frame_cache)
10276 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10277 * remote.c: Replace throw_exception with throw.
10278 * record-full.c (record_full_message, record_full_wait_1)
10279 (record_full_restore): Replace throw_exception with throw.
10280 * record-btrace.c:
10281 (get_thread_current_frame_id, record_btrace_start_replaying)
10282 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10283 (cmd_record_btrace_start): Replace throw_exception with throw.
10284 * parse.c (parse_exp_in_context_1): Replace throw_exception with
10285 throw.
10286 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10287 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10288 * linespec.c:
10289 (find_linespec_symbols): Replace throw_exception with throw.
10290 * infrun.c (displaced_step_prepare, resume): Replace
10291 throw_exception with throw.
10292 * infcmd.c (post_create_inferior): Replace throw_exception with
10293 throw.
10294 * inf-loop.c (inferior_event_handler): Replace throw_exception
10295 with throw.
10296 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10297 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10298 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10299 (get_prev_frame_always, get_frame_pc_if_available)
10300 (get_frame_address_in_block_if_available, get_frame_language):
10301 Replace throw_exception with throw.
10302 * frame-unwind.c (frame_unwind_try_unwinder): Replace
10303 throw_exception with throw.
10304 * eval.c (fetch_subexp_value, evaluate_var_value)
10305 (evaluate_funcall, evaluate_subexp_standard): Replace
10306 throw_exception with throw.
10307 * dwarf2loc.c (call_site_find_chain)
10308 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10309 Replace throw_exception with throw.
10310 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10311 with throw.
10312 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10313 throw.
10314 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10315 * completer.c (complete_line_internal): Replace throw_exception
10316 with throw.
10317 * compile/compile-object-run.c (compile_object_run): Replace
10318 throw_exception with throw.
10319 * cli/cli-script.c (process_next_line): Replace throw_exception
10320 with throw.
10321 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10322 (btrace_enable, btrace_maint_update_pt_packets): Replace
10323 throw_exception with throw.
10324 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10325 throw_exception with throw.
10326 * break-catch-throw.c (re_set_exception_catchpoint): Replace
10327 throw_exception with throw.
10328 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10329 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10330 * aarch64-tdep.c (aarch64_make_prologue_cache)
10331 (aarch64_make_stub_cache): Replace throw_exception with throw.
10332
10333 2019-04-08 Tom Tromey <tom@tromey.com>
10334
10335 * common/common-exceptions.c (throw_exception): Rename from
10336 throw_exception_cxx. Remove old copy. Make argument const.
10337 (throw_it): Create and throw exception objects directly.
10338 * common/common-exceptions.h (throw_exception): Make argument
10339 const.
10340 (struct gdb_exception_error): Add constructor.
10341 (struct gdb_exception_quit): Add constructor.
10342
10343 2019-04-08 Tom Tromey <tom@tromey.com>
10344
10345 * common/common-exceptions.h (exception_rethrow): Don't declare.
10346 (TRY_SJLJ): Update comment.
10347 (TRY, CATCH, END_CATCH): Remove.
10348 * common/common-exceptions.c (exception_rethrow): Remove.
10349
10350 2019-04-08 Tom Tromey <tom@tromey.com>
10351
10352 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10353 Remove.
10354 (gdb_exception_error): Rename from
10355 gdb_exception_RETURN_MASK_ERROR.
10356 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10357 (gdb_quit_bad_alloc): Update.
10358 * aarch64-tdep.c: Update.
10359 * ada-lang.c: Update.
10360 * ada-typeprint.c: Update.
10361 * ada-valprint.c: Update.
10362 * amd64-tdep.c: Update.
10363 * arch-utils.c: Update.
10364 * break-catch-throw.c: Update.
10365 * breakpoint.c: Update.
10366 * btrace.c: Update.
10367 * c-varobj.c: Update.
10368 * cli/cli-cmds.c: Update.
10369 * cli/cli-interp.c: Update.
10370 * cli/cli-script.c: Update.
10371 * common/common-exceptions.c: Update.
10372 * common/new-op.c: Update.
10373 * common/selftest.c: Update.
10374 * compile/compile-c-symbols.c: Update.
10375 * compile/compile-cplus-symbols.c: Update.
10376 * compile/compile-object-load.c: Update.
10377 * compile/compile-object-run.c: Update.
10378 * completer.c: Update.
10379 * corelow.c: Update.
10380 * cp-abi.c: Update.
10381 * cp-support.c: Update.
10382 * cp-valprint.c: Update.
10383 * darwin-nat.c: Update.
10384 * disasm-selftests.c: Update.
10385 * dtrace-probe.c: Update.
10386 * dwarf-index-cache.c: Update.
10387 * dwarf-index-write.c: Update.
10388 * dwarf2-frame-tailcall.c: Update.
10389 * dwarf2-frame.c: Update.
10390 * dwarf2loc.c: Update.
10391 * dwarf2read.c: Update.
10392 * eval.c: Update.
10393 * event-loop.c: Update.
10394 * event-top.c: Update.
10395 * exec.c: Update.
10396 * f-valprint.c: Update.
10397 * fbsd-tdep.c: Update.
10398 * frame-unwind.c: Update.
10399 * frame.c: Update.
10400 * gdbtypes.c: Update.
10401 * gnu-v3-abi.c: Update.
10402 * guile/guile-internal.h: Update.
10403 * guile/scm-block.c: Update.
10404 * guile/scm-breakpoint.c: Update.
10405 * guile/scm-cmd.c: Update.
10406 * guile/scm-disasm.c: Update.
10407 * guile/scm-frame.c: Update.
10408 * guile/scm-lazy-string.c: Update.
10409 * guile/scm-math.c: Update.
10410 * guile/scm-param.c: Update.
10411 * guile/scm-ports.c: Update.
10412 * guile/scm-pretty-print.c: Update.
10413 * guile/scm-symbol.c: Update.
10414 * guile/scm-symtab.c: Update.
10415 * guile/scm-type.c: Update.
10416 * guile/scm-value.c: Update.
10417 * i386-linux-tdep.c: Update.
10418 * i386-tdep.c: Update.
10419 * inf-loop.c: Update.
10420 * infcall.c: Update.
10421 * infcmd.c: Update.
10422 * infrun.c: Update.
10423 * jit.c: Update.
10424 * language.c: Update.
10425 * linespec.c: Update.
10426 * linux-fork.c: Update.
10427 * linux-nat.c: Update.
10428 * linux-tdep.c: Update.
10429 * linux-thread-db.c: Update.
10430 * main.c: Update.
10431 * mi/mi-cmd-break.c: Update.
10432 * mi/mi-cmd-stack.c: Update.
10433 * mi/mi-interp.c: Update.
10434 * mi/mi-main.c: Update.
10435 * objc-lang.c: Update.
10436 * p-valprint.c: Update.
10437 * parse.c: Update.
10438 * ppc-linux-tdep.c: Update.
10439 * printcmd.c: Update.
10440 * python/py-arch.c: Update.
10441 * python/py-breakpoint.c: Update.
10442 * python/py-cmd.c: Update.
10443 * python/py-finishbreakpoint.c: Update.
10444 * python/py-frame.c: Update.
10445 * python/py-framefilter.c: Update.
10446 * python/py-gdb-readline.c: Update.
10447 * python/py-inferior.c: Update.
10448 * python/py-infthread.c: Update.
10449 * python/py-lazy-string.c: Update.
10450 * python/py-linetable.c: Update.
10451 * python/py-objfile.c: Update.
10452 * python/py-param.c: Update.
10453 * python/py-prettyprint.c: Update.
10454 * python/py-progspace.c: Update.
10455 * python/py-record-btrace.c: Update.
10456 * python/py-record.c: Update.
10457 * python/py-symbol.c: Update.
10458 * python/py-type.c: Update.
10459 * python/py-unwind.c: Update.
10460 * python/py-utils.c: Update.
10461 * python/py-value.c: Update.
10462 * python/python.c: Update.
10463 * record-btrace.c: Update.
10464 * record-full.c: Update.
10465 * remote-fileio.c: Update.
10466 * remote.c: Update.
10467 * riscv-tdep.c: Update.
10468 * rs6000-aix-tdep.c: Update.
10469 * rs6000-tdep.c: Update.
10470 * rust-exp.y: Update.
10471 * rust-lang.c: Update.
10472 * s390-tdep.c: Update.
10473 * selftest-arch.c: Update.
10474 * solib-dsbt.c: Update.
10475 * solib-frv.c: Update.
10476 * solib-spu.c: Update.
10477 * solib-svr4.c: Update.
10478 * solib.c: Update.
10479 * sparc64-linux-tdep.c: Update.
10480 * stack.c: Update.
10481 * symfile-mem.c: Update.
10482 * symmisc.c: Update.
10483 * target.c: Update.
10484 * thread.c: Update.
10485 * top.c: Update.
10486 * tracefile-tfile.c: Update.
10487 * tui/tui.c: Update.
10488 * typeprint.c: Update.
10489 * unittests/cli-utils-selftests.c: Update.
10490 * unittests/parse-connection-spec-selftests.c: Update.
10491 * valops.c: Update.
10492 * valprint.c: Update.
10493 * value.c: Update.
10494 * varobj.c: Update.
10495 * windows-nat.c: Update.
10496 * x86-linux-nat.c: Update.
10497 * xml-support.c: Update.
10498
10499 2019-04-08 Tom Tromey <tom@tromey.com>
10500
10501 * xml-support.c: Use C++ exception handling.
10502 * x86-linux-nat.c: Use C++ exception handling.
10503 * windows-nat.c: Use C++ exception handling.
10504 * varobj.c: Use C++ exception handling.
10505 * value.c: Use C++ exception handling.
10506 * valprint.c: Use C++ exception handling.
10507 * valops.c: Use C++ exception handling.
10508 * unittests/parse-connection-spec-selftests.c: Use C++ exception
10509 handling.
10510 * unittests/cli-utils-selftests.c: Use C++ exception handling.
10511 * typeprint.c: Use C++ exception handling.
10512 * tui/tui.c: Use C++ exception handling.
10513 * tracefile-tfile.c: Use C++ exception handling.
10514 * top.c: Use C++ exception handling.
10515 * thread.c: Use C++ exception handling.
10516 * target.c: Use C++ exception handling.
10517 * symmisc.c: Use C++ exception handling.
10518 * symfile-mem.c: Use C++ exception handling.
10519 * stack.c: Use C++ exception handling.
10520 * sparc64-linux-tdep.c: Use C++ exception handling.
10521 * solib.c: Use C++ exception handling.
10522 * solib-svr4.c: Use C++ exception handling.
10523 * solib-spu.c: Use C++ exception handling.
10524 * solib-frv.c: Use C++ exception handling.
10525 * solib-dsbt.c: Use C++ exception handling.
10526 * selftest-arch.c: Use C++ exception handling.
10527 * s390-tdep.c: Use C++ exception handling.
10528 * rust-lang.c: Use C++ exception handling.
10529 * rust-exp.y: Use C++ exception handling.
10530 * rs6000-tdep.c: Use C++ exception handling.
10531 * rs6000-aix-tdep.c: Use C++ exception handling.
10532 * riscv-tdep.c: Use C++ exception handling.
10533 * remote.c: Use C++ exception handling.
10534 * remote-fileio.c: Use C++ exception handling.
10535 * record-full.c: Use C++ exception handling.
10536 * record-btrace.c: Use C++ exception handling.
10537 * python/python.c: Use C++ exception handling.
10538 * python/py-value.c: Use C++ exception handling.
10539 * python/py-utils.c: Use C++ exception handling.
10540 * python/py-unwind.c: Use C++ exception handling.
10541 * python/py-type.c: Use C++ exception handling.
10542 * python/py-symbol.c: Use C++ exception handling.
10543 * python/py-record.c: Use C++ exception handling.
10544 * python/py-record-btrace.c: Use C++ exception handling.
10545 * python/py-progspace.c: Use C++ exception handling.
10546 * python/py-prettyprint.c: Use C++ exception handling.
10547 * python/py-param.c: Use C++ exception handling.
10548 * python/py-objfile.c: Use C++ exception handling.
10549 * python/py-linetable.c: Use C++ exception handling.
10550 * python/py-lazy-string.c: Use C++ exception handling.
10551 * python/py-infthread.c: Use C++ exception handling.
10552 * python/py-inferior.c: Use C++ exception handling.
10553 * python/py-gdb-readline.c: Use C++ exception handling.
10554 * python/py-framefilter.c: Use C++ exception handling.
10555 * python/py-frame.c: Use C++ exception handling.
10556 * python/py-finishbreakpoint.c: Use C++ exception handling.
10557 * python/py-cmd.c: Use C++ exception handling.
10558 * python/py-breakpoint.c: Use C++ exception handling.
10559 * python/py-arch.c: Use C++ exception handling.
10560 * printcmd.c: Use C++ exception handling.
10561 * ppc-linux-tdep.c: Use C++ exception handling.
10562 * parse.c: Use C++ exception handling.
10563 * p-valprint.c: Use C++ exception handling.
10564 * objc-lang.c: Use C++ exception handling.
10565 * mi/mi-main.c: Use C++ exception handling.
10566 * mi/mi-interp.c: Use C++ exception handling.
10567 * mi/mi-cmd-stack.c: Use C++ exception handling.
10568 * mi/mi-cmd-break.c: Use C++ exception handling.
10569 * main.c: Use C++ exception handling.
10570 * linux-thread-db.c: Use C++ exception handling.
10571 * linux-tdep.c: Use C++ exception handling.
10572 * linux-nat.c: Use C++ exception handling.
10573 * linux-fork.c: Use C++ exception handling.
10574 * linespec.c: Use C++ exception handling.
10575 * language.c: Use C++ exception handling.
10576 * jit.c: Use C++ exception handling.
10577 * infrun.c: Use C++ exception handling.
10578 * infcmd.c: Use C++ exception handling.
10579 * infcall.c: Use C++ exception handling.
10580 * inf-loop.c: Use C++ exception handling.
10581 * i386-tdep.c: Use C++ exception handling.
10582 * i386-linux-tdep.c: Use C++ exception handling.
10583 * guile/scm-value.c: Use C++ exception handling.
10584 * guile/scm-type.c: Use C++ exception handling.
10585 * guile/scm-symtab.c: Use C++ exception handling.
10586 * guile/scm-symbol.c: Use C++ exception handling.
10587 * guile/scm-pretty-print.c: Use C++ exception handling.
10588 * guile/scm-ports.c: Use C++ exception handling.
10589 * guile/scm-param.c: Use C++ exception handling.
10590 * guile/scm-math.c: Use C++ exception handling.
10591 * guile/scm-lazy-string.c: Use C++ exception handling.
10592 * guile/scm-frame.c: Use C++ exception handling.
10593 * guile/scm-disasm.c: Use C++ exception handling.
10594 * guile/scm-cmd.c: Use C++ exception handling.
10595 * guile/scm-breakpoint.c: Use C++ exception handling.
10596 * guile/scm-block.c: Use C++ exception handling.
10597 * guile/guile-internal.h: Use C++ exception handling.
10598 * gnu-v3-abi.c: Use C++ exception handling.
10599 * gdbtypes.c: Use C++ exception handling.
10600 * frame.c: Use C++ exception handling.
10601 * frame-unwind.c: Use C++ exception handling.
10602 * fbsd-tdep.c: Use C++ exception handling.
10603 * f-valprint.c: Use C++ exception handling.
10604 * exec.c: Use C++ exception handling.
10605 * event-top.c: Use C++ exception handling.
10606 * event-loop.c: Use C++ exception handling.
10607 * eval.c: Use C++ exception handling.
10608 * dwarf2read.c: Use C++ exception handling.
10609 * dwarf2loc.c: Use C++ exception handling.
10610 * dwarf2-frame.c: Use C++ exception handling.
10611 * dwarf2-frame-tailcall.c: Use C++ exception handling.
10612 * dwarf-index-write.c: Use C++ exception handling.
10613 * dwarf-index-cache.c: Use C++ exception handling.
10614 * dtrace-probe.c: Use C++ exception handling.
10615 * disasm-selftests.c: Use C++ exception handling.
10616 * darwin-nat.c: Use C++ exception handling.
10617 * cp-valprint.c: Use C++ exception handling.
10618 * cp-support.c: Use C++ exception handling.
10619 * cp-abi.c: Use C++ exception handling.
10620 * corelow.c: Use C++ exception handling.
10621 * completer.c: Use C++ exception handling.
10622 * compile/compile-object-run.c: Use C++ exception handling.
10623 * compile/compile-object-load.c: Use C++ exception handling.
10624 * compile/compile-cplus-symbols.c: Use C++ exception handling.
10625 * compile/compile-c-symbols.c: Use C++ exception handling.
10626 * common/selftest.c: Use C++ exception handling.
10627 * common/new-op.c: Use C++ exception handling.
10628 * cli/cli-script.c: Use C++ exception handling.
10629 * cli/cli-interp.c: Use C++ exception handling.
10630 * cli/cli-cmds.c: Use C++ exception handling.
10631 * c-varobj.c: Use C++ exception handling.
10632 * btrace.c: Use C++ exception handling.
10633 * breakpoint.c: Use C++ exception handling.
10634 * break-catch-throw.c: Use C++ exception handling.
10635 * arch-utils.c: Use C++ exception handling.
10636 * amd64-tdep.c: Use C++ exception handling.
10637 * ada-valprint.c: Use C++ exception handling.
10638 * ada-typeprint.c: Use C++ exception handling.
10639 * ada-lang.c: Use C++ exception handling.
10640 * aarch64-tdep.c: Use C++ exception handling.
10641
10642 2019-04-08 Tom Tromey <tom@tromey.com>
10643
10644 * xml-support.c (gdb_xml_parser::parse): Update.
10645 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10646 * value.c (show_convenience): Update.
10647 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
10648 (test_parse_flags_qcs): Update.
10649 * thread.c (thr_try_catch_cmd): Update.
10650 * target.c (target_translate_tls_address): Update.
10651 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
10652 (info_frame_command_core, frame_apply_command_count): Update.
10653 * rust-exp.y (rust_lex_exception_test): Update.
10654 * riscv-tdep.c (riscv_print_one_register_info): Update.
10655 * remote.c (remote_target::enable_btrace): Update.
10656 * record-btrace.c (record_btrace_enable_warn): Update.
10657 * python/py-utils.c (gdbpy_convert_exception): Update.
10658 * printcmd.c (do_one_display, print_variable_and_value): Update.
10659 * mi/mi-main.c (mi_print_exception): Update.
10660 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
10661 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
10662 * linux-nat.c (linux_nat_target::attach): Update.
10663 * linux-fork.c (class scoped_switch_fork_info): Update.
10664 * infrun.c (displaced_step_prepare): Update.
10665 * infcall.c (call_function_by_hand_dummy): Update.
10666 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
10667 * gnu-v3-abi.c (print_one_vtable): Update.
10668 * frame.c (get_prev_frame_always): Update.
10669 * f-valprint.c (info_common_command_for_block): Update.
10670 * exec.c (try_open_exec_file): Update.
10671 * exceptions.c (print_exception, exception_print)
10672 (exception_fprintf, exception_print_same): Update.
10673 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
10674 * dwarf-index-cache.c (index_cache::store)
10675 (index_cache::lookup_gdb_index): Update.
10676 * darwin-nat.c (maybe_cache_shell): Update.
10677 * cp-valprint.c (cp_print_value_fields): Update.
10678 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
10679 (gcc_cplus_symbol_address): Update.
10680 * compile/compile-c-symbols.c (gcc_convert_symbol)
10681 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
10682 * common/selftest.c: Update.
10683 * common/common-exceptions.h (struct gdb_exception) <message>: Now
10684 a std::string.
10685 (exception_try_scope_entry, exception_try_scope_exit): Don't
10686 declare.
10687 (struct exception_try_scope): Remove.
10688 (TRY): Don't use exception_try_scope.
10689 (struct gdb_exception): Add constructor, operator=.
10690 <what>: New method.
10691 (struct gdb_exception_RETURN_MASK_ALL)
10692 (struct gdb_exception_RETURN_MASK_ERROR)
10693 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
10694 (struct gdb_quit_bad_alloc): Update.
10695 * common/common-exceptions.c (exception_none): Change
10696 initializer.
10697 (struct catcher) <state, exception>: Initialize inline.
10698 <prev>: Remove member.
10699 (current_catcher): Remove.
10700 (catchers): New global.
10701 (exceptions_state_mc_init): Simplify.
10702 (catcher_pop): Remove.
10703 (exceptions_state_mc, exceptions_state_mc_catch): Update.
10704 (try_scope_depth, exception_try_scope_entry)
10705 (exception_try_scope_exit): Remove.
10706 (throw_exception_sjlj): Update.
10707 (exception_messages, exception_messages_size): Remove.
10708 (throw_it): Simplify.
10709 (gdb_exception_sliced_copy): Remove.
10710 (throw_exception_cxx): Update.
10711 * cli/cli-script.c (script_from_file): Update.
10712 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
10713 Update.
10714 * ada-valprint.c (ada_val_print): Update.
10715 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
10716 (create_excep_cond_exprs): Update.
10717
10718 2019-04-08 Tom Tromey <tom@tromey.com>
10719
10720 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
10721 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
10722 (TRY, CATCH, END_CATCH): Remove some definitions.
10723 * common/common-exceptions.c: Don't use GDB_XCPT.
10724 (catcher_list_size): Remove.
10725 (throw_exception, throw_it): Simplify.
10726
10727 2019-04-05 Tom Tromey <tom@tromey.com>
10728
10729 Revert the header-sorting patch.
10730 * ft32-tdep.c: Revert.
10731 * frv-tdep.c: Revert.
10732 * frv-linux-tdep.c: Revert.
10733 * frame.c: Revert.
10734 * frame-unwind.c: Revert.
10735 * frame-base.c: Revert.
10736 * fork-child.c: Revert.
10737 * findvar.c: Revert.
10738 * findcmd.c: Revert.
10739 * filesystem.c: Revert.
10740 * filename-seen-cache.h: Revert.
10741 * filename-seen-cache.c: Revert.
10742 * fbsd-tdep.c: Revert.
10743 * fbsd-nat.h: Revert.
10744 * fbsd-nat.c: Revert.
10745 * f-valprint.c: Revert.
10746 * f-typeprint.c: Revert.
10747 * f-lang.c: Revert.
10748 * extension.h: Revert.
10749 * extension.c: Revert.
10750 * extension-priv.h: Revert.
10751 * expprint.c: Revert.
10752 * exec.h: Revert.
10753 * exec.c: Revert.
10754 * exceptions.c: Revert.
10755 * event-top.c: Revert.
10756 * event-loop.c: Revert.
10757 * eval.c: Revert.
10758 * elfread.c: Revert.
10759 * dwarf2read.h: Revert.
10760 * dwarf2read.c: Revert.
10761 * dwarf2loc.c: Revert.
10762 * dwarf2expr.h: Revert.
10763 * dwarf2expr.c: Revert.
10764 * dwarf2-frame.c: Revert.
10765 * dwarf2-frame-tailcall.c: Revert.
10766 * dwarf-index-write.h: Revert.
10767 * dwarf-index-write.c: Revert.
10768 * dwarf-index-common.c: Revert.
10769 * dwarf-index-cache.h: Revert.
10770 * dwarf-index-cache.c: Revert.
10771 * dummy-frame.c: Revert.
10772 * dtrace-probe.c: Revert.
10773 * disasm.h: Revert.
10774 * disasm.c: Revert.
10775 * disasm-selftests.c: Revert.
10776 * dictionary.c: Revert.
10777 * dicos-tdep.c: Revert.
10778 * demangle.c: Revert.
10779 * dcache.h: Revert.
10780 * dcache.c: Revert.
10781 * darwin-nat.h: Revert.
10782 * darwin-nat.c: Revert.
10783 * darwin-nat-info.c: Revert.
10784 * d-valprint.c: Revert.
10785 * d-namespace.c: Revert.
10786 * d-lang.c: Revert.
10787 * ctf.c: Revert.
10788 * csky-tdep.c: Revert.
10789 * csky-linux-tdep.c: Revert.
10790 * cris-tdep.c: Revert.
10791 * cris-linux-tdep.c: Revert.
10792 * cp-valprint.c: Revert.
10793 * cp-support.c: Revert.
10794 * cp-namespace.c: Revert.
10795 * cp-abi.c: Revert.
10796 * corelow.c: Revert.
10797 * corefile.c: Revert.
10798 * continuations.c: Revert.
10799 * completer.h: Revert.
10800 * completer.c: Revert.
10801 * complaints.c: Revert.
10802 * coffread.c: Revert.
10803 * coff-pe-read.c: Revert.
10804 * cli-out.h: Revert.
10805 * cli-out.c: Revert.
10806 * charset.c: Revert.
10807 * c-varobj.c: Revert.
10808 * c-valprint.c: Revert.
10809 * c-typeprint.c: Revert.
10810 * c-lang.c: Revert.
10811 * buildsym.c: Revert.
10812 * buildsym-legacy.c: Revert.
10813 * build-id.h: Revert.
10814 * build-id.c: Revert.
10815 * btrace.c: Revert.
10816 * bsd-uthread.c: Revert.
10817 * breakpoint.h: Revert.
10818 * breakpoint.c: Revert.
10819 * break-catch-throw.c: Revert.
10820 * break-catch-syscall.c: Revert.
10821 * break-catch-sig.c: Revert.
10822 * blockframe.c: Revert.
10823 * block.c: Revert.
10824 * bfin-tdep.c: Revert.
10825 * bfin-linux-tdep.c: Revert.
10826 * bfd-target.c: Revert.
10827 * bcache.c: Revert.
10828 * ax-general.c: Revert.
10829 * ax-gdb.h: Revert.
10830 * ax-gdb.c: Revert.
10831 * avr-tdep.c: Revert.
10832 * auxv.c: Revert.
10833 * auto-load.c: Revert.
10834 * arm-wince-tdep.c: Revert.
10835 * arm-tdep.c: Revert.
10836 * arm-symbian-tdep.c: Revert.
10837 * arm-pikeos-tdep.c: Revert.
10838 * arm-obsd-tdep.c: Revert.
10839 * arm-nbsd-tdep.c: Revert.
10840 * arm-nbsd-nat.c: Revert.
10841 * arm-linux-tdep.c: Revert.
10842 * arm-linux-nat.c: Revert.
10843 * arm-fbsd-tdep.c: Revert.
10844 * arm-fbsd-nat.c: Revert.
10845 * arm-bsd-tdep.c: Revert.
10846 * arch-utils.c: Revert.
10847 * arc-tdep.c: Revert.
10848 * arc-newlib-tdep.c: Revert.
10849 * annotate.h: Revert.
10850 * annotate.c: Revert.
10851 * amd64-windows-tdep.c: Revert.
10852 * amd64-windows-nat.c: Revert.
10853 * amd64-tdep.c: Revert.
10854 * amd64-sol2-tdep.c: Revert.
10855 * amd64-obsd-tdep.c: Revert.
10856 * amd64-obsd-nat.c: Revert.
10857 * amd64-nbsd-tdep.c: Revert.
10858 * amd64-nbsd-nat.c: Revert.
10859 * amd64-nat.c: Revert.
10860 * amd64-linux-tdep.c: Revert.
10861 * amd64-linux-nat.c: Revert.
10862 * amd64-fbsd-tdep.c: Revert.
10863 * amd64-fbsd-nat.c: Revert.
10864 * amd64-dicos-tdep.c: Revert.
10865 * amd64-darwin-tdep.c: Revert.
10866 * amd64-bsd-nat.c: Revert.
10867 * alpha-tdep.c: Revert.
10868 * alpha-obsd-tdep.c: Revert.
10869 * alpha-nbsd-tdep.c: Revert.
10870 * alpha-mdebug-tdep.c: Revert.
10871 * alpha-linux-tdep.c: Revert.
10872 * alpha-linux-nat.c: Revert.
10873 * alpha-bsd-tdep.c: Revert.
10874 * alpha-bsd-nat.c: Revert.
10875 * aix-thread.c: Revert.
10876 * agent.c: Revert.
10877 * addrmap.c: Revert.
10878 * ada-varobj.c: Revert.
10879 * ada-valprint.c: Revert.
10880 * ada-typeprint.c: Revert.
10881 * ada-tasks.c: Revert.
10882 * ada-lang.c: Revert.
10883 * aarch64-tdep.c: Revert.
10884 * aarch64-ravenscar-thread.c: Revert.
10885 * aarch64-newlib-tdep.c: Revert.
10886 * aarch64-linux-tdep.c: Revert.
10887 * aarch64-linux-nat.c: Revert.
10888 * aarch64-fbsd-tdep.c: Revert.
10889 * aarch64-fbsd-nat.c: Revert.
10890 * aarch32-linux-nat.c: Revert.
10891
10892 2019-04-05 Tom Tromey <tom@tromey.com>
10893
10894 * ft32-tdep.c: Sort headers.
10895 * frv-tdep.c: Sort headers.
10896 * frv-linux-tdep.c: Sort headers.
10897 * frame.c: Sort headers.
10898 * frame-unwind.c: Sort headers.
10899 * frame-base.c: Sort headers.
10900 * fork-child.c: Sort headers.
10901 * findvar.c: Sort headers.
10902 * findcmd.c: Sort headers.
10903 * filesystem.c: Sort headers.
10904 * filename-seen-cache.h: Sort headers.
10905 * filename-seen-cache.c: Sort headers.
10906 * fbsd-tdep.c: Sort headers.
10907 * fbsd-nat.h: Sort headers.
10908 * fbsd-nat.c: Sort headers.
10909 * f-valprint.c: Sort headers.
10910 * f-typeprint.c: Sort headers.
10911 * f-lang.c: Sort headers.
10912 * extension.h: Sort headers.
10913 * extension.c: Sort headers.
10914 * extension-priv.h: Sort headers.
10915 * expprint.c: Sort headers.
10916 * exec.h: Sort headers.
10917 * exec.c: Sort headers.
10918 * exceptions.c: Sort headers.
10919 * event-top.c: Sort headers.
10920 * event-loop.c: Sort headers.
10921 * eval.c: Sort headers.
10922 * elfread.c: Sort headers.
10923 * dwarf2read.h: Sort headers.
10924 * dwarf2read.c: Sort headers.
10925 * dwarf2loc.c: Sort headers.
10926 * dwarf2expr.h: Sort headers.
10927 * dwarf2expr.c: Sort headers.
10928 * dwarf2-frame.c: Sort headers.
10929 * dwarf2-frame-tailcall.c: Sort headers.
10930 * dwarf-index-write.h: Sort headers.
10931 * dwarf-index-write.c: Sort headers.
10932 * dwarf-index-common.c: Sort headers.
10933 * dwarf-index-cache.h: Sort headers.
10934 * dwarf-index-cache.c: Sort headers.
10935 * dummy-frame.c: Sort headers.
10936 * dtrace-probe.c: Sort headers.
10937 * disasm.h: Sort headers.
10938 * disasm.c: Sort headers.
10939 * disasm-selftests.c: Sort headers.
10940 * dictionary.c: Sort headers.
10941 * dicos-tdep.c: Sort headers.
10942 * demangle.c: Sort headers.
10943 * dcache.h: Sort headers.
10944 * dcache.c: Sort headers.
10945 * darwin-nat.h: Sort headers.
10946 * darwin-nat.c: Sort headers.
10947 * darwin-nat-info.c: Sort headers.
10948 * d-valprint.c: Sort headers.
10949 * d-namespace.c: Sort headers.
10950 * d-lang.c: Sort headers.
10951 * ctf.c: Sort headers.
10952 * csky-tdep.c: Sort headers.
10953 * csky-linux-tdep.c: Sort headers.
10954 * cris-tdep.c: Sort headers.
10955 * cris-linux-tdep.c: Sort headers.
10956 * cp-valprint.c: Sort headers.
10957 * cp-support.c: Sort headers.
10958 * cp-namespace.c: Sort headers.
10959 * cp-abi.c: Sort headers.
10960 * corelow.c: Sort headers.
10961 * corefile.c: Sort headers.
10962 * continuations.c: Sort headers.
10963 * completer.h: Sort headers.
10964 * completer.c: Sort headers.
10965 * complaints.c: Sort headers.
10966 * coffread.c: Sort headers.
10967 * coff-pe-read.c: Sort headers.
10968 * cli-out.h: Sort headers.
10969 * cli-out.c: Sort headers.
10970 * charset.c: Sort headers.
10971 * c-varobj.c: Sort headers.
10972 * c-valprint.c: Sort headers.
10973 * c-typeprint.c: Sort headers.
10974 * c-lang.c: Sort headers.
10975 * buildsym.c: Sort headers.
10976 * buildsym-legacy.c: Sort headers.
10977 * build-id.h: Sort headers.
10978 * build-id.c: Sort headers.
10979 * btrace.c: Sort headers.
10980 * bsd-uthread.c: Sort headers.
10981 * breakpoint.h: Sort headers.
10982 * breakpoint.c: Sort headers.
10983 * break-catch-throw.c: Sort headers.
10984 * break-catch-syscall.c: Sort headers.
10985 * break-catch-sig.c: Sort headers.
10986 * blockframe.c: Sort headers.
10987 * block.c: Sort headers.
10988 * bfin-tdep.c: Sort headers.
10989 * bfin-linux-tdep.c: Sort headers.
10990 * bfd-target.c: Sort headers.
10991 * bcache.c: Sort headers.
10992 * ax-general.c: Sort headers.
10993 * ax-gdb.h: Sort headers.
10994 * ax-gdb.c: Sort headers.
10995 * avr-tdep.c: Sort headers.
10996 * auxv.c: Sort headers.
10997 * auto-load.c: Sort headers.
10998 * arm-wince-tdep.c: Sort headers.
10999 * arm-tdep.c: Sort headers.
11000 * arm-symbian-tdep.c: Sort headers.
11001 * arm-pikeos-tdep.c: Sort headers.
11002 * arm-obsd-tdep.c: Sort headers.
11003 * arm-nbsd-tdep.c: Sort headers.
11004 * arm-nbsd-nat.c: Sort headers.
11005 * arm-linux-tdep.c: Sort headers.
11006 * arm-linux-nat.c: Sort headers.
11007 * arm-fbsd-tdep.c: Sort headers.
11008 * arm-fbsd-nat.c: Sort headers.
11009 * arm-bsd-tdep.c: Sort headers.
11010 * arch-utils.c: Sort headers.
11011 * arc-tdep.c: Sort headers.
11012 * arc-newlib-tdep.c: Sort headers.
11013 * annotate.h: Sort headers.
11014 * annotate.c: Sort headers.
11015 * amd64-windows-tdep.c: Sort headers.
11016 * amd64-windows-nat.c: Sort headers.
11017 * amd64-tdep.c: Sort headers.
11018 * amd64-sol2-tdep.c: Sort headers.
11019 * amd64-obsd-tdep.c: Sort headers.
11020 * amd64-obsd-nat.c: Sort headers.
11021 * amd64-nbsd-tdep.c: Sort headers.
11022 * amd64-nbsd-nat.c: Sort headers.
11023 * amd64-nat.c: Sort headers.
11024 * amd64-linux-tdep.c: Sort headers.
11025 * amd64-linux-nat.c: Sort headers.
11026 * amd64-fbsd-tdep.c: Sort headers.
11027 * amd64-fbsd-nat.c: Sort headers.
11028 * amd64-dicos-tdep.c: Sort headers.
11029 * amd64-darwin-tdep.c: Sort headers.
11030 * amd64-bsd-nat.c: Sort headers.
11031 * alpha-tdep.c: Sort headers.
11032 * alpha-obsd-tdep.c: Sort headers.
11033 * alpha-nbsd-tdep.c: Sort headers.
11034 * alpha-mdebug-tdep.c: Sort headers.
11035 * alpha-linux-tdep.c: Sort headers.
11036 * alpha-linux-nat.c: Sort headers.
11037 * alpha-bsd-tdep.c: Sort headers.
11038 * alpha-bsd-nat.c: Sort headers.
11039 * aix-thread.c: Sort headers.
11040 * agent.c: Sort headers.
11041 * addrmap.c: Sort headers.
11042 * ada-varobj.c: Sort headers.
11043 * ada-valprint.c: Sort headers.
11044 * ada-typeprint.c: Sort headers.
11045 * ada-tasks.c: Sort headers.
11046 * ada-lang.c: Sort headers.
11047 * aarch64-tdep.c: Sort headers.
11048 * aarch64-ravenscar-thread.c: Sort headers.
11049 * aarch64-newlib-tdep.c: Sort headers.
11050 * aarch64-linux-tdep.c: Sort headers.
11051 * aarch64-linux-nat.c: Sort headers.
11052 * aarch64-fbsd-tdep.c: Sort headers.
11053 * aarch64-fbsd-nat.c: Sort headers.
11054 * aarch32-linux-nat.c: Sort headers.
11055
11056 2019-04-04 Tom Tromey <tom@tromey.com>
11057
11058 * varobj.c (varobj_create): Update.
11059 * rust-exp.y (struct rust_parser) <update_innermost_block,
11060 lookup_symbol>: New methods.
11061 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11062 Rename.
11063 (rust_parser::rust_lookup_type)
11064 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11065 * printcmd.c (display_command, do_one_display): Update.
11066 * parser-defs.h (struct parser_state) <parser_state>: Add
11067 "tracker" parameter.
11068 (block_tracker): New member.
11069 (class innermost_block_tracker) <innermost_block_tracker>: Add
11070 "types" parameter.
11071 <reset>: Remove method.
11072 (innermost_block): Don't declare.
11073 (null_post_parser): Update.
11074 * parse.c (innermost_block): Remove global.
11075 (write_dollar_variable): Update.
11076 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11077 Remove "tracker_types" parameter.
11078 (parse_expression): Add "tracker" parameter.
11079 (parse_expression_for_completion): Update.
11080 (null_post_parser): Add "tracker" parameter.
11081 * p-exp.y: Update rules.
11082 * m2-exp.y: Update rules.
11083 * language.h (struct language_defn) <la_post_parser>: Add
11084 "tracker" parameter.
11085 * go-exp.y: Update rules.
11086 * f-exp.y: Update rules.
11087 * expression.h (parse_expression, parse_exp_1): Add "tracker"
11088 parameter.
11089 * d-exp.y: Update rules.
11090 * c-exp.y: Update rules.
11091 * breakpoint.c (set_breakpoint_condition): Create an
11092 innermost_block_tracker.
11093 (watch_command_1): Likewise.
11094 * ada-lang.c (resolve): Add "tracker" parameter.
11095 (resolve_subexp): Likewise.
11096 * ada-exp.y (write_var_from_sym): Update.
11097
11098 2019-04-04 Tom Tromey <tom@tromey.com>
11099
11100 * type-stack.h: New file.
11101 * type-stack.c: New file.
11102 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11103 type-stack.h.
11104 (insert_into_type_stack, insert_type, push_type, push_type_int)
11105 (insert_type_address_space, pop_type, pop_type_int)
11106 (pop_typelist, pop_type_stack, append_type_stack)
11107 (push_type_stack, get_type_stack, push_typelist)
11108 (follow_type_instance_flags, follow_types): Don't declare.
11109 * parse.c (type_stack): Remove global.
11110 (parse_exp_in_context): Update.
11111 (insert_into_type_stack, insert_type, push_type, push_type_int)
11112 (insert_type_address_space, pop_type, pop_type_int)
11113 (pop_typelist, pop_type_stack, append_type_stack)
11114 (push_type_stack, get_type_stack, push_typelist)
11115 (follow_type_instance_flags, follow_types): Remove (moved to
11116 type-stack.c).
11117 * f-exp.y (type_stack): New global.
11118 Update rules.
11119 (push_kind_type, f_parse): Update.
11120 * d-exp.y (type_stack): New global.
11121 Update rules.
11122 (d_parse): Update.
11123 * c-exp.y (struct c_parse_state) <type_stack>: New member.
11124 Update rules.
11125 * Makefile.in (COMMON_SFILES): Add type-stack.c.
11126 (HFILES_NO_SRCDIR): Add type-stack.h.
11127
11128 2019-04-04 Tom Tromey <tom@tromey.com>
11129
11130 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11131 (rust_parser::convert_ast_to_expression, rust_parse)
11132 (rust_lex_test_completion, rust_lex_tests): Update.
11133 * parser-defs.h (struct expr_completion_state): New.
11134 (struct parser_state) <parser_state>: Add completion parameter.
11135 <mark_struct_expression, mark_completion_tag>: New methods.
11136 <parse_completion, m_completion_state>: New members.
11137 (prefixify_expression, null_post_parser): Update.
11138 (mark_struct_expression, mark_completion_tag): Don't declare.
11139 * parse.c (parse_completion, expout_last_struct)
11140 (expout_tag_completion_type, expout_completion_name): Remove
11141 globals.
11142 (parser_state::mark_struct_expression)
11143 (parser_state::mark_completion_tag): Now methods.
11144 (prefixify_expression): Add last_struct parameter.
11145 (prefixify_subexp): Likewise.
11146 (parse_exp_1): Update.
11147 (parse_exp_in_context): Add cstate parameter. Update.
11148 (parse_expression_for_completion): Create an
11149 expr_completion_state.
11150 (null_post_parser): Add "completion" parameter.
11151 * p-exp.y: Update rules.
11152 (yylex): Update.
11153 * language.h (struct language_defn) <la_post_parser>: Add
11154 "completing" parameter.
11155 * go-exp.y: Update rules.
11156 (lex_one_token): Update.
11157 * expression.h (parse_completion): Don't declare.
11158 * d-exp.y: Update rules.
11159 (lex_one_token): Update rules.
11160 * c-exp.y: Update rules.
11161 (lex_one_token): Update.
11162 * ada-lang.c (resolve): Add "parse_completion" parameter.
11163 (resolve_subexp): Likewise.
11164 (ada_resolve_function): Likewise.
11165
11166 2019-04-04 Tom Tromey <tom@tromey.com>
11167
11168 * parser-defs.h (struct parser_state) <start_arglist,
11169 end_arglist>: New methods.
11170 <arglist_len, m_funcall_chain>: New members.
11171 (arglist_len, start_arglist, end_arglist): Don't declare.
11172 * parse.c (arglist_len, funcall_chain): Remove global.
11173 (start_arglist, end_arglist): Remove functions.
11174 (parse_exp_in_context): Update.
11175 * p-exp.y: Update rules.
11176 * m2-exp.y: Update rules.
11177 * go-exp.y: Update rules.
11178 * f-exp.y: Update rules.
11179 * d-exp.y: Update rules.
11180 * c-exp.y: Update rules.
11181
11182 2019-04-04 Tom Tromey <tom@tromey.com>
11183
11184 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11185 lex_operator, push_back>: New methods.
11186 Update all rules.
11187 (rust_parser::lex_hex, lex_escape): Rename and update.
11188 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11189 (rust_parser::lex_operator): Rename and update.
11190 (rust_parser::lex_number, rustyylex, rustyyerror)
11191 (rust_lex_test_init, rust_lex_test_sequence)
11192 (rust_lex_test_push_back, rust_lex_tests): Update.
11193 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11194 parameter.
11195 <lexptr, prev_lexptr>: New members.
11196 (lexptr, prev_lexptr): Don't declare.
11197 * parse.c (lexptr, prev_lexptr): Remove globals.
11198 (parse_exp_in_context): Update.
11199 * p-exp.y (yylex, yyerror): Update.
11200 * m2-exp.y (parse_number, yylex, yyerror): Update.
11201 * go-exp.y (lex_one_token, yyerror): Update.
11202 * f-exp.y (match_string_literal, yylex, yyerror): Update.
11203 * d-exp.y (lex_one_token, yyerror): Update.
11204 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11205 (lex_one_token, yyerror): Update.
11206 * ada-lex.l (YY_INPUT): Update.
11207 (rewind_to_char): Update.
11208 * ada-exp.y (yyerror): Update.
11209
11210 2019-04-04 Tom Tromey <tom@tromey.com>
11211
11212 * rust-exp.y (rustyylex, rust_lex_tests): Update.
11213 * parser-defs.h (struct parser_state) <parser_state>: Add new
11214 parameter.
11215 <comma_terminates>: New member.
11216 (comma_terminates): Don't declare global.
11217 * parse.c (comma_terminates): Remove global.
11218 (parse_exp_in_context): Update.
11219 * p-exp.y (yylex): Update.
11220 * m2-exp.y (yylex): Update.
11221 * go-exp.y (lex_one_token): Update.
11222 * f-exp.y (yylex): Update.
11223 * d-exp.y (lex_one_token): Update.
11224 * c-exp.y (lex_one_token): Update.
11225 * ada-lex.l: Update.
11226
11227 2019-04-04 Tom Tromey <tom@tromey.com>
11228
11229 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11230 (rustyylex, rust_lex_test_init, rust_lex_test_one)
11231 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11232 * parser-defs.h (paren_depth): Don't declare.
11233 * parse.c (paren_depth): Remove global.
11234 (parse_exp_in_context): Update.
11235 * p-exp.y (paren_depth): New global.
11236 (pascal_parse): Initialize it.
11237 * m2-exp.y (paren_depth): New global.
11238 (m2_parse): Initialize it.
11239 * go-exp.y (paren_depth): New global.
11240 (go_parse): Initialize it.
11241 * f-exp.y (paren_depth): New global.
11242 (f_parse): Initialize it.
11243 * d-exp.y (paren_depth): New global.
11244 (d_parse): Initialize it.
11245 * c-exp.y (paren_depth): New global.
11246 (c_parse): Initialize it.
11247 * ada-lex.l (paren_depth): New global.
11248 (lexer_init): Initialize it.
11249
11250 2019-04-04 Tom Tromey <tom@tromey.com>
11251
11252 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11253 (rust_parser::convert_ast_to_type)
11254 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11255 * parser-defs.h (struct parser_state) <parser_state>: Add
11256 parameters. Initialize new members.
11257 <expression_context_block, expression_context_pc>: New members.
11258 * parse.c (expression_context_block, expression_context_pc):
11259 Remove globals.
11260 (parse_exp_in_context): Update.
11261 * p-exp.y: Update all rules.
11262 (yylex): Update.
11263 * m2-exp.y: Update all rules.
11264 (yylex): Update.
11265 * go-exp.y (yylex): Update.
11266 * f-exp.y (yylex): Update.
11267 * d-exp.y: Update all rules.
11268 (yylex): Update.
11269 * c-exp.y: Update all rules.
11270 (lex_one_token, classify_name, yylex, c_parse): Update.
11271 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11272
11273 2019-04-04 Tom Tromey <tom@tromey.com>
11274
11275 * gdbarch.h, gdbarch.c: Rebuild.
11276 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11277 * stap-probe.h:
11278 (struct stap_parse_info): Replace "parser_state" with
11279 "expr_builder".
11280 * parser-defs.h (struct expr_builder): Rename from "parser_state".
11281 (parser_state): New class.
11282 * parse.c (expr_builder): Rename.
11283 (expr_builder::release): Rename.
11284 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11285 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11286 (write_exp_elt_longcst, write_exp_elt_floatcst)
11287 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11288 (write_exp_string_vector, write_exp_bitstring)
11289 (write_exp_msymbol, mark_struct_expression)
11290 (write_dollar_variable)
11291 (insert_type_address_space, increase_expout_size): Replace
11292 "parser_state" with "expr_builder".
11293 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11294 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11295 "parser_state" with "expr_builder".
11296
11297 2019-04-04 Tom Tromey <tom@tromey.com>
11298
11299 * rust-exp.y: Replace "parse_language" with method call.
11300 * p-exp.y:
11301 (yylex): Replace "parse_language" with method call.
11302 * m2-exp.y:
11303 (yylex): Replace "parse_language" with method call.
11304 * go-exp.y (classify_name): Replace "parse_language" with method
11305 call.
11306 * f-exp.y (yylex): Replace "parse_language" with method call.
11307 * d-exp.y (lex_one_token): Replace "parse_language" with method
11308 call.
11309 * c-exp.y:
11310 (lex_one_token, classify_name, yylex): Replace "parse_language"
11311 with method call.
11312 * ada-exp.y (find_primitive_type, type_char)
11313 (type_system_address): Replace "parse_language" with method call.
11314
11315 2019-04-04 Tom Tromey <tom@tromey.com>
11316
11317 * rust-exp.y: Replace "parse_gdbarch" with method call.
11318 * parse.c (write_dollar_variable, insert_type_address_space):
11319 Replace "parse_gdbarch" with method call.
11320 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11321 call.
11322 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11323 call.
11324 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11325 "parse_gdbarch" with method call.
11326 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11327 with method call.
11328 * f-exp.y (parse_type, parse_f_type, yylex): Replace
11329 "parse_gdbarch" with method call.
11330 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11331 "parse_gdbarch" with method call.
11332 * c-exp.y (parse_type, parse_number, classify_name): Replace
11333 "parse_gdbarch" with method call.
11334 * ada-lex.l: Replace "parse_gdbarch" with method call.
11335 * ada-exp.y (parse_type, find_primitive_type, type_char)
11336 (type_system_address): Replace "parse_gdbarch" with method call.
11337
11338 2019-04-04 Tom Tromey <tom@tromey.com>
11339
11340 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11341 * stap-probe.c (stap_parse_argument): Update.
11342 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11343 initial_size parameter.
11344 * rust-exp.y (rust_lex_tests): Update.
11345 * parse.c (parser_state): Update.
11346 (parse_exp_in_context): Update.
11347 * parser-defs.h (struct parser_state) <parser_state>: Remove
11348 "initial_size" parameter.
11349
11350 2019-04-04 Tom Tromey <tom@tromey.com>
11351
11352 * parser-defs.h (increase_expout_size): Don't declare.
11353 * parse.c (increase_expout_size): Now static.
11354
11355 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
11356
11357 * gnu-nat.c (gnu_nat_target::wait): Fix
11358 target_waitstatus_to_string call.
11359
11360 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
11361
11362 * eval.c (evaluate_subexp_standard): Handle internal functions
11363 during Fortran function call handling.
11364
11365 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
11366
11367 * NEWS: Mention new internal functions.
11368 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11369 (read_base_type): Use dwarf2_init_complex_target_type.
11370 * value.c (creal_internal_fn): New function.
11371 (cimag_internal_fn): New function.
11372 (_initialize_values): Register new internal functions.
11373
11374 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11375
11376 * infrun.c (stop_all_threads): If debug_infrun, always
11377 trace the wait status after wait_one, using
11378 target_waitstatus_to_string and target_pid_to_str.
11379 (handle_inferior_event): Replace various trace of
11380 wait status kind by a single trace.
11381 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11382 wait status kind image by target_waitstatus_to_string.
11383 * target/waitstatus.c (target_waitstatus_to_string): Fix
11384 obsolete comment.
11385
11386 2019-04-01 Tom Tromey <tromey@adacore.com>
11387
11388 PR symtab/23331:
11389 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11390
11391 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
11392 Pedro Alves <palves@redhat.com>
11393
11394 * top.c (quit_force): Call 'finalize_values'.
11395 * value.c (finalize_values): New function.
11396 * value.h (finalize_values): Declare.
11397
11398 2019-03-30 Eli Zaretskii <eliz@gnu.org>
11399
11400 * NEWS: Announce $_gdb_major and $_gdb_minor.
11401
11402 * top.c (init_gdb_version_vars): New function.
11403 (gdb_init): Call init_gdb_version_vars.
11404
11405 2019-03-29 Tom Tromey <tromey@adacore.com>
11406
11407 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
11408 help text. Remove dead code.
11409
11410 2019-03-29 Keith Seitz <keiths@redhat.com>
11411
11412 From Siddhesh Poyarekar:
11413 * f-lang.h (f77_get_upperbound): Return LONGEST.
11414 (f77_get_lowerbound): Likewise.
11415 * f-typeprint.c (f_type_print_varspec_suffix): Expand
11416 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
11417 print them.
11418 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
11419 plongest to format print it.
11420 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
11421 (f77_get_upperbound): Likewise.
11422 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
11423 LOWER_BOUND to LONGEST.
11424 (f77_create_arrayprint_offset_tbl): Likewise.
11425
11426 2019-03-29 Keith Seitz <keiths@redhat.com>
11427
11428 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
11429 %s/pulongest for TYPE_LENGTH instead of %d in format
11430 strings.
11431 * ada-typerint.c (ada_print_type): Likewise.
11432 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
11433 * compile/compile-c-support.c (generate_register_struct): Likewise.
11434 * gdbtypes.c (recursive_dump_type): Likewise.
11435 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
11436 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
11437 instead of %d in format strings.
11438 * riscv-tdep.c (riscv_type_alignment): Cast second argument
11439 to std::min to ULONGEST.
11440 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
11441 instead of %d in format strings.
11442 * tracepoint.c (info_scope_command): Likewise.
11443 * typeprint.c (print_offset_data::update)
11444 (print_offset_data::finish): Likewise.
11445 * xtensa-tdep.c (xtensa_store_return_value)
11446 (xtensa_push_dummy_call): Likewise.
11447
11448 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
11449
11450 * windows-nat.c (display_selector): Fixed format specifications
11451 for 64-bit Cygwin.
11452
11453 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11454
11455 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
11456
11457 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
11458
11459 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
11460 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
11461 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
11462 (nios2_linux_init_abi): Install it.
11463
11464 2019-03-28 Alan Hayward <alan.hayward@arm.com>
11465
11466 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
11467
11468 2019-03-28 Alan Hayward <alan.hayward@arm.com>
11469
11470 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
11471
11472 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11473 Tom Tromey <tromey@adacore.com>
11474
11475 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
11476
11477 2019-03-26 Joel Brobecker <brobecker@adacore.com>
11478
11479 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
11480 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
11481 method to compute the bounds of range types. Also print "[evaluated]"
11482 if the bounds' values come from a dynamic evaluation.
11483
11484 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
11485
11486 * cp-valprint.c (cp_print_value_fields): Don't print trailing
11487 whitespace when pretty printing is on.
11488
11489 2019-03-26 Alan Hayward <alan.hayward@arm.com>
11490
11491 * ppc-linux-nat.c: Add include.
11492
11493 2019-03-26 Alan Hayward <alan.hayward@arm.com>
11494
11495 * NEWS: Mention AArch64 Pointer Authentication.
11496
11497 2019-03-26 Alan Hayward <alan.hayward@arm.com>
11498
11499 * arm-linux-nat.c: Add include.
11500
11501 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
11502
11503 * source-cache.c (source_cache::get_source_lines): Re-read
11504 fullname after calling open_source_file.
11505
11506 2019-03-25 John Baldwin <jhb@FreeBSD.org>
11507
11508 * NEWS: Mention TLS support for FreeBSD.
11509
11510 2019-03-25 Tom Tromey <tromey@adacore.com>
11511
11512 * minsyms.c (BUNCH_SIZE): Update comment.
11513 (~minimal_symbol_reader): Remove old comment.
11514 (compact_minimal_symbols): Update comment.
11515 (minimal_symbol_reader::install): Remove old comment. Update
11516 other comments.
11517
11518 2019-03-25 Alan Hayward <alan.hayward@arm.com>
11519
11520 * s390-linux-nat.c: Add include.
11521
11522 2019-03-25 Alan Hayward <alan.hayward@arm.com>
11523
11524 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
11525 Call linux_get_hwcap.
11526 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
11527 Likewise.
11528 (aarch64_linux_get_hwcap): Remove function.
11529 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
11530 declaration.
11531 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
11532 linux_get_hwcap.
11533 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
11534 * linux-tdep.c (linux_get_hwcap): Add function.
11535 (linux_get_hwcap2): Likewise.
11536 * linux-tdep.h (linux_get_hwcap): Add declaration.
11537 (linux_get_hwcap2): Likewise.
11538 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
11539 (ppc_linux_get_hwcap2): Likewise.
11540 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
11541 linux_get_hwcap.
11542 (ppc_linux_nat_target::insert_watchpoint): Likewise.
11543 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
11544 (ppc_linux_nat_target::read_description): Likewise.
11545 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
11546 * s390-linux-nat.c: Likewise.
11547 * s390-linux-tdep.c (s390_core_read_description): Likewise.
11548
11549 2019-03-24 Tom Tromey <tom@tromey.com>
11550
11551 * ada-lang.c (standard_lookup): Simplify initialization.
11552 (ada_lookup_symbol_nonlocal): Simplify return.
11553 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
11554 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
11555 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
11556 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
11557 initialization.
11558 * solib.c (solib_global_lookup): Simplify.
11559 * symtab.c (null_block_symbol): Remove.
11560 (symbol_cache_lookup): Simplify returns.
11561 (lookup_language_this): Simplify returns.
11562 (lookup_symbol_aux): Simplify return.
11563 (lookup_local_symbol): Simplify returns.
11564 (lookup_global_symbol_from_objfile): Simplify return.
11565 (lookup_symbol_in_objfile_symtabs)
11566 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
11567 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
11568 (lookup_static_symbol, lookup_global_symbol): Simplify return.
11569 * cp-namespace.c (cp_lookup_bare_symbol)
11570 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
11571 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
11572 (cp_lookup_nested_symbol): Don't use null_block_symbol.
11573 (cp_lookup_symbol_via_imports): Simplify initialization.
11574 (find_symbol_in_baseclass): Likewise.
11575 * symtab.h (null_block_symbol): Remove.
11576 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
11577 (d_lookup_nested_symbol, d_lookup_symbol_imports)
11578 (d_lookup_symbol_module): Likewise.
11579 (find_symbol_in_baseclass): Simplify initialization.
11580
11581 2019-03-24 Tom Tromey <tom@tromey.com>
11582
11583 * expression.h: Don't include symtab.h.
11584 (struct block): Forward declare.
11585
11586 2019-03-24 Tom Tromey <tom@tromey.com>
11587
11588 * c-exp.y (typebase): Remove casts.
11589 * gdbtypes.c (lookup_unsigned_typename, )
11590 (lookup_signed_typename): Remove cast.
11591 * eval.c (parse_to_comma_and_eval): Remove cast.
11592 * parse.c (write_dollar_variable): Remove cast.
11593 * block.h (struct block) <superblock>: Now const.
11594 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
11595 * psymtab.c (psym_map_matching_symbols): Make "block" const.
11596 (map_block): Make "block" const.
11597 * symfile.h (struct quick_symbol_functions)
11598 <map_matching_symbols>: Constify block argument to "callback".
11599 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
11600 const.
11601 (find_pc_sect_compunit_symtab): Make "b" const.
11602 (find_symbol_at_address): Likewise.
11603 (search_symbols): Likewise.
11604 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
11605 (dw2_debug_names_lookup_symbol): Likewise.
11606 (dw2_map_matching_symbols): Update.
11607 * p-valprint.c (pascal_val_print): Remove "block".
11608 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
11609 (aux_add_nonlocal_symbols): Make "block" const.
11610 (resolve_subexp): Remove cast.
11611 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
11612 const.
11613 (iterate_over_file_blocks): Likewise.
11614 * f-exp.y (%union) <bval>: Remove.
11615 * coffread.c (patch_opaque_types): Make "b" const.
11616 * spu-tdep.c (spu_catch_start): Make "block" const.
11617 * c-valprint.c (print_unpacked_pointer): Remove "block".
11618 * symmisc.c (dump_symtab_1): Make "b" const.
11619 (block_depth): Make "block" const.
11620 * d-exp.y (%union) <bval>: Remove.
11621 * cp-support.h (cp_lookup_rtti_type): Update.
11622 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
11623 * psymtab.c (psym_lookup_symbol): Make "block" const.
11624 (maintenance_check_psymtabs): Make "b" const.
11625 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
11626 (enumerate_locals, enumerate_args): Update.
11627 * python/py-symtab.c (stpy_global_block): Make "block" const.
11628 (stpy_static_block): Likewise.
11629 * inline-frame.c (block_starting_point_at): Make "new_block"
11630 const.
11631 * block.c (find_block_in_blockvector): Make return type const.
11632 (blockvector_for_pc_sect): Make "b" const.
11633 (find_block_in_blockvector): Make "b" const.
11634
11635 2019-03-23 Tom Tromey <tom@tromey.com>
11636
11637 * varobj.c (varobj_create): Update.
11638 * symfile.c (clear_symtab_users): Don't reset innermost_block.
11639 * printcmd.c (display_command, do_one_display): Don't reset
11640 innermost_block.
11641 * parser-defs.h (enum innermost_block_tracker_type): Move to
11642 expression.h.
11643 (innermost_block): Update comment.
11644 * parse.c (parse_exp_1): Add tracker_types parameter.
11645 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
11646 tracker_types parameter. Reset innermost_block.
11647 (parse_exp_in_context): Remove.
11648 (parse_expression_for_completion): Update.
11649 * objfiles.c (~objfile): Don't reset expression_context_block or
11650 innermost_block.
11651 * expression.h (enum innermost_block_tracker_type): Move from
11652 parser-defs.h.
11653 (parse_exp_1): Add tracker_types parameter.
11654 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
11655 reset innermost_block.
11656
11657 2019-03-23 Tom Tromey <tom@tromey.com>
11658
11659 * objfiles.h: Include bcache.h.
11660
11661 2019-03-23 Tom Tromey <tom@tromey.com>
11662
11663 * linespec.c (get_current_search_block): Use
11664 scoped_restore_current_language.
11665 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
11666
11667 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11668 Jiong Wang <jiong.wang@arm.com>
11669
11670 * aarch64-linux-tdep.c
11671 (aarch64_linux_iterate_over_regset_sections): Check for pauth
11672 section.
11673 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
11674
11675 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11676 Jiong Wang <jiong.wang@arm.com>
11677
11678 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
11679 instructions.
11680 (aarch64_analyze_prologue_test): Add PACIASP test.
11681 (aarch64_prologue_prev_register): Unmask PC value.
11682
11683 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11684 Jiong Wang <jiong.wang@arm.com>
11685
11686 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
11687 (aarch64_dwarf2_prev_register): Unmask PC value.
11688 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
11689 (aarch64_execute_dwarf_cfa_vendor_op): Check for
11690 DW_CFA_AARCH64_negate_ra_state.
11691 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
11692
11693 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11694 Jiong Wang <jiong.wang@arm.com>
11695
11696 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
11697 registers.
11698 (aarch64_pseudo_register_name): Likewise.
11699 (aarch64_pseudo_register_type): Likewise.
11700 (aarch64_pseudo_register_reggroup_p): Likewise.
11701 (aarch64_gdbarch_init): Add pauth registers.
11702 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
11703 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
11704 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
11705 (struct gdbarch_tdep): Add regnum for ra_state.
11706
11707 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11708 Jiong Wang <jiong.wang@arm.com>
11709
11710 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
11711
11712 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11713 Jiong Wang <jiong.wang@arm.com>
11714
11715 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
11716 function.
11717 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
11718 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
11719 (aarch64_gdbarch_init): Add puth registers.
11720 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
11721 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
11722 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
11723
11724 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11725 Jiong Wang <jiong.wang@arm.com>
11726
11727 * aarch64-linux-nat.c
11728 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
11729 * aarch64-linux-tdep.c
11730 (aarch64_linux_core_read_description): Likewise.
11731 (aarch64_linux_get_hwcap): New function.
11732 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
11733 (aarch64_linux_get_hwcap): New declaration.
11734
11735 2019-03-22 Alan Hayward <alan.hayward@arm.com>
11736 Jiong Wang <jiong.wang@arm.com>
11737
11738 * aarch64-linux-nat.c
11739 (aarch64_linux_nat_target::read_description): Add pauth param.
11740 * aarch64-linux-tdep.c
11741 (aarch64_linux_core_read_description): Likewise.
11742 * aarch64-tdep.c (struct target_desc): Add in pauth.
11743 (aarch64_read_description): Add pauth param.
11744 (aarch64_gdbarch_init): Likewise.
11745 * aarch64-tdep.h (aarch64_read_description): Likewise.
11746 * arch/aarch64.c (aarch64_create_target_description): Likewise.
11747 * arch/aarch64.h (aarch64_create_target_description): Likewise.
11748 * features/Makefile: Add new files.
11749 * features/aarch64-pauth.c: New file.
11750 * features/aarch64-pauth.xml: New file.
11751
11752 2019-03-20 Tom Tromey <tromey@adacore.com>
11753
11754 * infrun.c (handle_inferior_event): Rename from
11755 handle_inferior_event_1. Create a scoped_value_mark.
11756 (handle_inferior_event): Remove.
11757
11758 2019-03-19 Tom Tromey <tromey@adacore.com>
11759
11760 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
11761 * infrun.h (print_stop_event): Add "displays" parameter.
11762 * infrun.c (print_stop_event): Add "displays" parameter.
11763
11764 2019-03-19 Pedro Alves <palves@redhat.com>
11765
11766 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
11767 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
11768 to -1. Fix TABs vs spaces.
11769 (tui_ui_out::tui_ui_out): Don't initialize fields here.
11770 * tui/tui-out.h (tui_ui_out) Add intro comments.
11771 <m_line, m_start_of_line>: In-class initialize, and add describing
11772 comment.
11773
11774 2019-03-18 Alan Hayward <alan.hayward@arm.com>
11775
11776 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
11777 variable names.
11778 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
11779
11780 2019-03-18 Pedro Alves <palves@redhat.com>
11781 Eli Zaretskii <eliz@gnu.org>
11782
11783 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
11784 m_line and m_start_of_line.
11785
11786 2019-03-18 Eli Zaretskii <eliz@gnu.org>
11787
11788 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
11789 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
11790 it returns a newline. This fixes a regression in TU mode, whereby
11791 the next line is output on the same screen line as the user input.
11792
11793 2019-03-18 Tom Tromey <tromey@adacore.com>
11794
11795 * minsyms.c (minimal_symbol_reader::install): Remove call to
11796 obstack_blank.
11797
11798 2019-03-18 Pedro Alves <palves@redhat.com>
11799
11800 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
11801 New globals.
11802 (apply_style): New, factored out from ...
11803 (apply_ansi_escape): ... this. Handle reverse video mode.
11804 (tui_set_reverse_mode): New function.
11805 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
11806 * tui/tui-winsource.c (tui_show_source_line): Use
11807 tui_set_reverse_mode instead of setting A_STANDOUT.
11808 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
11809 New setter methods.
11810
11811 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
11812
11813 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
11814 Handle tabs.
11815
11816 2019-03-18 Tom Tromey <tromey@adacore.com>
11817
11818 * ada-lang.c (empty_array): Add "high" parameter.
11819 (ada_evaluate_subexp): Update.
11820
11821 2019-03-17 Sergei Trofimovich <siarheit@google.com>
11822
11823 * unittests/string_view-selftests.c: Define
11824 _initialize_string_view_selftests unconditionally.
11825
11826 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
11827
11828 PR gdb/24350
11829 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
11830
11831 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
11832
11833 PR gdb/24351
11834 * windows-nat.c (display_selector): Fix format specifiers.
11835
11836 2019-03-17 Eli Zaretskii <eliz@gnu.org>
11837
11838 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
11839 tui_refill_source_window instead of tui_refresh_win, to update the
11840 current execution line. This fixes redisplay of the current line
11841 when stepping through the code with "next" or "step".
11842
11843 2019-03-16 Eli Zaretskii <eliz@gnu.org>
11844
11845 * source-cache.c (source_cache::get_source_lines): Call
11846 find_source_lines to initialize s->nlines. This fixes vertical
11847 scrolling of TUI source window when the DOWN arrow is pressed.
11848
11849 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11850
11851 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
11852 linux-thread-db.c (_initialize_thread_db): Likewise.
11853
11854 2019-03-16 Eli Zaretskii <eliz@gnu.org>
11855
11856 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
11857 wclrtoeol in tui_show_source_line". This reverts changes made in
11858 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
11859
11860 2019-03-15 Tom Tromey <tom@tromey.com>
11861
11862 * symtab.h (struct minimal_symbol): Derive from
11863 general_symbol_info.
11864 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
11865 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
11866 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
11867 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
11868 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
11869 (MSYMBOL_SEARCH_NAME): Update.
11870 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
11871 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
11872 * minsyms.c (minimal_symbol_reader::record_full): Update.
11873
11874 2019-03-15 Tom Tromey <tom@tromey.com>
11875
11876 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
11877
11878 2019-03-15 Tom Tromey <tom@tromey.com>
11879
11880 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
11881 unique_xmalloc_ptr.
11882 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
11883 Update.
11884 * minsyms.c (lookup_minimal_symbol_by_pc_section)
11885 (build_minimal_symbol_hash_tables)
11886 (minimal_symbol_reader::install): Update.
11887
11888 2019-03-15 Tom Tromey <tom@tromey.com>
11889
11890 * symtab.c (create_demangled_names_hash): Update.
11891 (symbol_set_names): Update.
11892 * objfiles.h (struct objfile_per_bfd_storage)
11893 <demangled_names_hash>: Now an htab_up.
11894 * objfiles.c (objfile_per_bfd_storage): Simplify.
11895
11896 2019-03-15 Tom Tromey <tom@tromey.com>
11897
11898 * objfiles.h (struct objfile_per_bfd_storage): Declare
11899 destructor.
11900 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
11901 New.
11902 (get_objfile_bfd_data): Use new. Don't initialize
11903 language_of_main.
11904 (free_objfile_per_bfd_storage): Remove.
11905 (objfile_bfd_data_free, objfile::~objfile): Use delete.
11906
11907 2019-03-15 Tom Tromey <tom@tromey.com>
11908
11909 * symfile.c (reread_symbols): Update.
11910 * objfiles.c (objfile::objfile): Update.
11911 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
11912 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
11913 comment.
11914 (minimal_symbol_reader::install): Update.
11915 (terminate_minimal_symbol_table): Remove.
11916 * jit.c (jit_object_close_impl): Update.
11917
11918 2019-03-15 Tom Tromey <tom@tromey.com>
11919
11920 * minsyms.c (minimal_symbol_reader::record_full): Remove some
11921 initializations.
11922
11923 2019-03-15 Tom Tromey <tom@tromey.com>
11924
11925 * objfiles.h (struct objfile_per_bfd_storage)
11926 <demangled_hash_languages>: Now a bitset.
11927 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
11928 (lookup_minimal_symbol): Update.
11929
11930 2019-03-15 Tom Tromey <tom@tromey.com>
11931
11932 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
11933 Don't return the symbol.
11934 * coffread.c (record_minimal_symbol): Use record_full.
11935
11936 2019-03-14 Eli Zaretskii <eliz@gnu.org>
11937
11938 The MS-Windows port of ncurses fails to switch to a color pair if
11939 one or both of the colors are the implicit default colors. This
11940 change records the default colors when TUI is initialized, and
11941 then specifies them explicitly when a color pair uses the default
11942 colors. This allows color styling in TUI mode on MS-Windows.
11943
11944 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
11945 ncurses_norm_attr.
11946 (tui_initialize_io) [__MINGW32__]: Record the default terminal
11947 colors in ncurses_norm_attr.
11948 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
11949 "none", replace it with the default color recorded in
11950 ncurses_norm_attr.
11951
11952 2019-03-14 Tom Tromey <tromey@adacore.com>
11953
11954 * source-cache.h (class source_cache) <get_source_lines>: Return
11955 std::string.
11956 * source-cache.c (source_cache::extract_lines): Handle case where
11957 first_pos==npos. Return std::string.
11958 (source_cache::get_source_lines): Update.
11959
11960 2019-03-14 Tom Tromey <tromey@adacore.com>
11961
11962 * NEWS: Add item for "style sources" commands.
11963 * source-cache.c (source_cache::get_source_lines): Check
11964 source_styling.
11965 * cli/cli-style.c (source_styling): New global.
11966 (_initialize_cli_style): Add "style sources" commands.
11967 (show_style_sources): New function.
11968 * cli/cli-style.h (source_styling): Declare.
11969
11970 2019-03-14 Pedro Alves <palves@redhat.com>
11971 Tom Tromey <tromey@adacore.com>
11972
11973 * tui/tui-winsource.h (tui_refill_source_window): Declare.
11974 * tui/tui-winsource.c (tui_refill_source_window): New function,
11975 from...
11976 (tui_horizontal_source_scroll): ... here. Move some logic.
11977 * cli/cli-style.c (set_style_enabled): Notify new observable.
11978 * tui/tui-hooks.c (tui_redisplay_source): New function.
11979 (tui_attach_detach_observers): Attach or detach
11980 tui_redisplay_source.
11981 * observable.h (source_styling_changed): New observable.
11982 * observable.c: Define source_styling_changed observable.
11983
11984 2019-03-13 Tom Tromey <tromey@adacore.com>
11985
11986 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
11987 (i386_gnu_nat_target::store_registers): Update.
11988 * target-debug.h (target_debug_print_std_string): New macro.
11989 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11990 * windows-tdep.c (display_one_tib): Update.
11991 * tui/tui-stack.c (tui_make_status_line): Update.
11992 * top.c (print_inferior_quit_action): Update.
11993 * thread.c (thr_try_catch_cmd): Update.
11994 (add_thread_with_info): Update.
11995 (thread_target_id_str): Update.
11996 (thr_try_catch_cmd): Update.
11997 (thread_command): Update.
11998 (thread_find_command): Update.
11999 * record-btrace.c (record_btrace_target::info_record)
12000 (record_btrace_resume_thread, record_btrace_target::resume)
12001 (record_btrace_cancel_resume, record_btrace_step_thread)
12002 (record_btrace_target::wait, record_btrace_target::wait)
12003 (record_btrace_target::wait, record_btrace_target::stop): Update.
12004 * progspace.c (print_program_space): Update.
12005 * process-stratum-target.c
12006 (process_stratum_target::thread_address_space): Update.
12007 * linux-fork.c (linux_fork_mourn_inferior)
12008 (detach_checkpoint_command, info_checkpoints_command)
12009 (linux_fork_context): Update.
12010 (linux_fork_detach): Update.
12011 (class scoped_switch_fork_info): Update.
12012 (delete_checkpoint_command): Update.
12013 * infrun.c (follow_fork_inferior): Update.
12014 (follow_fork_inferior): Update.
12015 (proceed_after_vfork_done): Update.
12016 (handle_vfork_child_exec_or_exit): Update.
12017 (follow_exec): Update.
12018 (displaced_step_prepare_throw): Update.
12019 (displaced_step_restore): Update.
12020 (start_step_over): Update.
12021 (resume_1): Update.
12022 (clear_proceed_status_thread): Update.
12023 (proceed): Update.
12024 (print_target_wait_results): Update.
12025 (do_target_wait): Update.
12026 (context_switch): Update.
12027 (stop_all_threads): Update.
12028 (restart_threads): Update.
12029 (finish_step_over): Update.
12030 (handle_signal_stop): Update.
12031 (switch_back_to_stepped_thread): Update.
12032 (keep_going_pass_signal): Update.
12033 (print_exited_reason): Update.
12034 (normal_stop): Update.
12035 * inferior.c (inferior_pid_to_str): Change return type.
12036 (print_selected_inferior): Update.
12037 (add_inferior): Update.
12038 (detach_inferior): Update.
12039 * dummy-frame.c (fprint_dummy_frames): Update.
12040 * dcache.c (dcache_info_1): Update.
12041 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12042 (btrace_fetch, btrace_clear): Update.
12043 * linux-tdep.c (linux_core_pid_to_str): Change return type.
12044 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12045 type.
12046 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12047 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12048 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12049 * gdbarch.c, gdbarch.h: Rebuild.
12050 * gdbarch.sh (core_pid_to_str): Change return type.
12051 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12052 return type.
12053 (windows_nat_target::pid_to_str): Change return type.
12054 (windows_delete_thread): Update.
12055 (windows_nat_target::attach): Update.
12056 (windows_nat_target::files_info): Update.
12057 * target-delegates.c: Rebuild.
12058 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12059 return type.
12060 (sol_thread_target::pid_to_str): Change return type.
12061 * remote.c (class remote_target) <pid_to_str>: Change return
12062 type.
12063 (remote_target::pid_to_str): Change return type.
12064 (extended_remote_target::attach, remote_target::remote_stop_ns)
12065 (remote_target::remote_notif_remove_queued_reply)
12066 (remote_target::push_stop_reply, remote_target::disable_btrace):
12067 Update.
12068 (extended_remote_target::attach): Update.
12069 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12070 type.
12071 (gdbsim_target::pid_to_str): Change return type.
12072 * ravenscar-thread.c (struct ravenscar_thread_target)
12073 <pid_to_str>: Change return type.
12074 (ravenscar_thread_target::pid_to_str): Change return type.
12075 * procfs.c (class procfs_target) <pid_to_str>: Change return
12076 type.
12077 (procfs_target::pid_to_str): Change return type.
12078 (procfs_target::attach): Update.
12079 (procfs_target::detach): Update.
12080 (procfs_target::fetch_registers): Update.
12081 (procfs_target::store_registers): Update.
12082 (procfs_target::wait): Update.
12083 (procfs_target::files_info): Update.
12084 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12085 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12086 return type.
12087 (nto_procfs_target::pid_to_str): Change return type.
12088 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12089 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12090 return type.
12091 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12092 (exit_lwp): Update.
12093 (attach_proc_task_lwp_callback, get_detach_signal)
12094 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12095 (linux_nat_target::resume, wait_lwp, stop_callback)
12096 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12097 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12098 (linux_nat_wait_1, resume_stopped_resumed_lwps)
12099 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12100 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12101 type.
12102 (inf_ptrace_target::attach): Update.
12103 (inf_ptrace_target::files_info): Update.
12104 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12105 type.
12106 (go32_nat_target::pid_to_str): Change return type.
12107 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12108 (gnu_nat_target::wait): Update.
12109 (gnu_nat_target::wait): Update.
12110 (gnu_nat_target::resume): Update.
12111 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12112 (fbsd_nat_target::wait): Update.
12113 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12114 type.
12115 (darwin_nat_target::attach): Update.
12116 * corelow.c (class core_target) <pid_to_str>: Change return type.
12117 (core_target::pid_to_str): Change return type.
12118 * target.c (normal_pid_to_str): Change return type.
12119 (default_pid_to_str): Likewise.
12120 (target_pid_to_str): Change return type.
12121 (target_translate_tls_address): Update.
12122 (target_announce_detach): Update.
12123 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12124 return type.
12125 (bsd_uthread_target::pid_to_str): Change return type.
12126 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12127 type.
12128 (bsd_kvm_target::pid_to_str): Change return type.
12129 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12130 return type.
12131 (aix_thread_target::pid_to_str): Change return type.
12132 * target.h (struct target_ops) <pid_to_str>: Change return type.
12133 (target_pid_to_str, normal_pid_to_str): Likewise.
12134 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12135 type.
12136 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12137 type.
12138 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12139 return type.
12140 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12141 type.
12142 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12143 type.
12144 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12145 return type.
12146
12147 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
12148
12149 * NEWS: Mention that the new default MI version is 3. Mention
12150 changes to the output of commands and events that deal with
12151 multi-location breakpoints.
12152 * breakpoint.c: Include "mi/mi-out.h".
12153 (print_one_breakpoint): Change output syntax if using MI version
12154 >= 3.
12155 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12156 New.
12157 (mi_multi_location_breakpoint_output_fixed): New.
12158 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12159 (mi_cmd_fix_multi_location_breakpoint_output): New.
12160 (mi_multi_location_breakpoint_output_fixed): New.
12161 * mi/mi-cmds.c (mi_cmds): Register command
12162 -fix-multi-location-breakpoint-output.
12163 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12164 interpreter "mi".
12165
12166 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
12167
12168 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12169 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12170 instantiate mi_ui_out based on interpreter name.
12171 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12172 * mi/mi-main.c (mi_load_progress): Likewise.
12173
12174 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12175
12176 * NEWS: Combine separate "New targets" sections for 8.3.
12177
12178 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12179
12180 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12181 (ppcfbsd_init_abi): Install gdbarch
12182 "fetch_tls_load_module_address" and "get_thread_local_address"
12183 methods.
12184
12185 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12186
12187 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12188 (riscv_fbsd_init_abi): Install gdbarch
12189 "fetch_tls_load_module_address" and "get_thread_local_address"
12190 methods.
12191
12192 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12193
12194 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12195 (i386fbsd_init_abi): Install gdbarch
12196 "fetch_tls_load_module_address" and "get_thread_local_address"
12197 methods.
12198
12199 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12200
12201 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12202 (amd64fbsd_init_abi): Install gdbarch
12203 "fetch_tls_load_module_address" and "get_thread_local_address"
12204 methods.
12205
12206 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12207
12208 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12209 (struct fbsd_pspace_data): New type.
12210 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12211 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12212 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12213 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12214 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12215
12216 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12217
12218 * gdbtypes.c (lookup_struct_elt): New function.
12219 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12220 * gdbtypes.h (struct struct_elt): New type.
12221 (lookup_struct_elt): New prototype.
12222
12223 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12224
12225 * gdbtypes.c (lookup_struct_elt_type): Update comment and
12226 remove disabled code block.
12227
12228 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12229
12230 * gdbarch.sh (get_thread_local_address): New method.
12231 * gdbarch.h, gdbarch.c: Regenerate.
12232 * target.c (target_translate_tls_address): Use
12233 gdbarch_get_thread_local_address if present instead of
12234 target::get_thread_local_address.
12235
12236 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12237
12238 * target.h (target::get_thread_local_address): Update comment.
12239
12240 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12241
12242 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12243 objfile->separate_debug_objfile_backlink if not NULL.
12244
12245 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12246
12247 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12248 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12249 (amd64bsd_store_inferior_registers): Likewise.
12250 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12251 Enable segment base registers.
12252 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12253 PT_GETFSBASE and PT_GETGSBASE.
12254 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12255 PT_SETGSBASE.
12256 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12257 segment base registers.
12258 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12259
12260 2019-03-12 John Baldwin <jhb@FreeBSD.org>
12261
12262 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12263 Update calls to i386_target_description to add 'segments'
12264 parameter.
12265 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
12266 add segment base registers.
12267 * arch/i386.c (i386_create_target_description): Add 'segments'
12268 parameter to enable segment base registers.
12269 * arch/i386.h (i386_create_target_description): Likewise.
12270 * features/i386/32bit-segments.xml: New file.
12271 * features/i386/32bit-segments.c: Generate.
12272 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12273 call to i386_target_description to add 'segments' parameter.
12274 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12275 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12276 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12277 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12278 if feature is present.
12279 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12280 Add 'segments' parameter to call to i386_target_description.
12281 (i386_target_description): Add 'segments' parameter to enable
12282 segment base registers.
12283 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12284 to call to i386_target_description.
12285 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12286 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12287 Define I386_NUM_REGS.
12288 (i386_target_description): Add 'segments' parameter to enable
12289 segment base registers.
12290
12291 2019-03-12 Eli Zaretskii <eliz@gnu.org>
12292
12293 PR/24325
12294 * source-cache.c: #undef open and close, to avoid unresolved
12295 externals during linking.
12296
12297 2019-03-12 Tom Tromey <tromey@adacore.com>
12298
12299 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12300 const. Add initializers.
12301 (_initialize_remote): Don't initialize ptid globals.
12302
12303 2019-03-12 Pedro Alves <palves@redhat.com>
12304
12305 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12306
12307 2019-03-12 Pedro Alves <palves@redhat.com>
12308
12309 * cp-name-parser.y (main): Remove unused 'len' variable.
12310
12311 2019-03-12 Tom Tromey <tromey@adacore.com>
12312
12313 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12314 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12315
12316 2019-03-12 Tom Tromey <tromey@adacore.com>
12317
12318 * linux-nat.c (iterate_over_lwps): Update.
12319 (stop_callback): Remove parameter.
12320 (stop_wait_callback, detach_callback, resume_set_callback)
12321 (select_singlestep_lwp_callback, set_ignore_sigint)
12322 (status_callback, resumed_callback, resume_clear_callback)
12323 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12324 data parameter.
12325 (linux_nat_target::detach, linux_nat_target::resume)
12326 (linux_stop_and_wait_all_lwps, select_event_lwp)
12327 (linux_nat_filter_event, linux_nat_wait_1)
12328 (linux_nat_target::kill, linux_nat_target::stop)
12329 (linux_nat_target::stop): Update.
12330 (linux_nat_resume_callback): Change type.
12331 (resume_stopped_resumed_lwps, count_events_callback)
12332 (select_event_lwp_callback): Likewise.
12333 (linux_stop_lwp, linux_nat_stop_lwp): Update.
12334 * arm-linux-nat.c (struct update_registers_data): Remove.
12335 (update_registers_callback): Change type.
12336 (arm_linux_insert_hw_breakpoint1): Update.
12337 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12338 parameter.
12339 (x86_linux_dr_set_addr): Update.
12340 (x86_linux_dr_set_control): Update.
12341 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12342 (iterate_over_lwps): Use gdb::function_view.
12343 * nat/aarch64-linux-hw-point.c (struct
12344 aarch64_dr_update_callback_param): Remove.
12345 (debug_reg_change_callback): Change type.
12346 (aarch64_notify_debug_reg_change): Update.
12347 * s390-linux-nat.c (s390_refresh_per_info): Update.
12348
12349 2019-03-11 Tom Tromey <tromey@adacore.com>
12350
12351 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12352 redundant assignment to "this_cu".
12353
12354 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12355
12356 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12357
12358 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12359
12360 * gdbtypes.c (rank_one_type_parm_set): New function extracted
12361 from...
12362 (rank_one_type): ... this.
12363
12364 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12365
12366 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12367 from...
12368 (rank_one_type): ... this.
12369
12370 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12371
12372 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12373 from...
12374 (rank_one_type): ... this.
12375
12376 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12377
12378 * gdbtypes.c (rank_one_type_parm_float): New function extracted
12379 from...
12380 (rank_one_type): ... this.
12381
12382 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12383
12384 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12385 from...
12386 (rank_one_type): ... this.
12387
12388 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12389
12390 * gdbtypes.c (rank_one_type_parm_range): New function extracted
12391 from...
12392 (rank_one_type): ... this.
12393
12394 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12395
12396 * gdbtypes.c (rank_one_type_parm_char): New function extracted
12397 from...
12398 (rank_one_type): ... this.
12399
12400 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12401
12402 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12403 from...
12404 (rank_one_type): ... this.
12405
12406 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12407
12408 * gdbtypes.c (rank_one_type_parm_int): New function extracted
12409 from...
12410 (rank_one_type): ... this.
12411
12412 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12413
12414 * gdbtypes.c (rank_one_type_parm_func): New function extracted
12415 from...
12416 (rank_one_type): ... this.
12417
12418 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12419
12420 * gdbtypes.c (rank_one_type_parm_array): New function extracted
12421 from...
12422 (rank_one_type): ... this.
12423
12424 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
12425
12426 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
12427 from...
12428 (rank_one_type): ... this.
12429
12430 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12431
12432 * inferior.c (initialize_inferiors): Ensure 'help set/show print
12433 inferior-events' shows the example events.
12434
12435 2019-03-08 Eli Zaretskii <eliz@gnu.org>
12436
12437 Support styling on native MS-Windows console
12438
12439 PR/24315
12440 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
12441 on MS-Windows if $TERM is not defined.
12442
12443 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
12444
12445 * posix-hdep.c (gdb_console_fputs):
12446 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
12447 functions.
12448 * ui-file.h (gdb_console_fputs): Add prototype.
12449
12450 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
12451 back to fputs only if the former returns zero.
12452
12453 2019-03-07 Tom Tromey <tom@tromey.com>
12454
12455 * symmisc.c (print_symbol_bcache_statistics): Update.
12456 (print_objfile_statistics): Update.
12457 * symfile.c (allocate_symtab): Update.
12458 * stabsread.c: Don't include bcache.h.
12459 * psymtab.h (struct psymbol_bcache): Don't declare.
12460 (class psymtab_storage) <psymbol_cache>: Now a bcache.
12461 (psymbol_bcache_init, psymbol_bcache_free)
12462 (psymbol_bcache_get_bcache): Don't declare.
12463 * psymtab.c (struct psymbol_bcache): Remove.
12464 (psymtab_storage::psymtab_storage): Update.
12465 (psymtab_storage::~psymtab_storage): Update.
12466 (psymbol_bcache_init, psymbol_bcache_free)
12467 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
12468 (add_psymbol_to_bcache): Update.
12469 (allocate_psymtab): Update.
12470 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
12471 macro_cache>: No longer pointers.
12472 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
12473 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
12474 * macrotab.c (macro_bcache): Update.
12475 * macroexp.c: Don't include bcache.h.
12476 * gdbtypes.c (check_types_worklist): Update.
12477 (types_deeply_equal): Remove TRY/CATCH. Update.
12478 * elfread.c (elf_symtab_read): Update.
12479 * dwarf2read.c: Don't include bcache.h.
12480 * buildsym.c (buildsym_compunit::get_macro_table): Update.
12481 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
12482 (print_bcache_statistics, bcache_memory_used): Don't declare.
12483 (struct bcache): Move from bcache.c. Add constructor, destructor,
12484 methods. Rename all data members.
12485 * bcache.c (struct bcache): Move to bcache.h.
12486 (bcache::expand_hash_table): Rename from expand_hash_table.
12487 (bcache): Remove.
12488 (bcache::insert): Rename from bcache_full.
12489 (bcache::compare): Rename from bcache_compare.
12490 (bcache_xmalloc): Remove.
12491 (bcache::~bcache): Rename from bcache_xfree.
12492 (bcache::print_statistics): Rename from print_bcache_statistics.
12493 (bcache::memory_used): Rename from bcache_memory_used.
12494
12495 2019-03-07 Pedro Alves <palves@redhat.com>
12496
12497 * infrun.c (normal_stop): Also check for
12498 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
12499
12500 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
12501
12502 * f-lang.c (value_from_host_double): Moved to...
12503 * value.c (value_from_host_double): ...here.
12504 * value.h (value_from_host_double): Declare.
12505 * guile/scm-math.c (vlscm_convert_typed_number): Use
12506 value_from_host_double.
12507 (vlscm_convert_number): Likewise.
12508 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
12509 * python/py-value.c (convert_value_from_python): Likewise.
12510
12511 2019-03-06 Tom Tromey <tom@tromey.com>
12512
12513 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
12514
12515 2019-03-06 Tom Tromey <tom@tromey.com>
12516
12517 * utils.h (free_current_contents): Don't declare.
12518 * utils.c (free_current_contents): Remove.
12519
12520 2019-03-06 Tom Tromey <tom@tromey.com>
12521
12522 * top.c (quit_force): Update.
12523 * main.c (captured_command_loop): Update.
12524 * common/new-op.c (operator new): Update.
12525 * common/common-exceptions.c (struct catcher)
12526 <save_cleanup_chain>: Remove member.
12527 (exceptions_state_mc_init): Update.
12528 (exception_try_scope_entry): Return nullptr.
12529 (exception_try_scope_exit, exception_rethrow)
12530 (throw_exception_sjlj, throw_exception_cxx): Update.
12531 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
12532 (all_cleanups, do_cleanups, discard_cleanups)
12533 (discard_final_cleanups, save_cleanups, save_final_cleanups)
12534 (restore_cleanups, restore_final_cleanups): Don't declare.
12535 (do_final_cleanups): Remove parameter.
12536 * common/cleanups.c (cleanup_chain, make_cleanup)
12537 (make_cleanup_dtor, all_cleanups, do_cleanups)
12538 (discard_my_cleanups, discard_cleanups)
12539 (discard_final_cleanups, save_my_cleanups, save_cleanups)
12540 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
12541 (null_cleanup): Remove.
12542 (do_final_cleanups): Remove parameter.
12543
12544 2019-03-06 Tom Tromey <tom@tromey.com>
12545
12546 * remote.c (remote_target::remote_parse_stop_reply): Use
12547 unique_xmalloc_ptr.
12548
12549 2019-03-06 Tom Tromey <tom@tromey.com>
12550
12551 * stabsread.c (struct stabs_field_info): Rename from field_info.
12552 <list, fnlist>: Add initializers.
12553 <obstack>: New member.
12554 (read_member_functions, read_struct_fields, read_baseclasses):
12555 Allocate on obstack. Don't use cleanups.
12556 (read_one_struct_field, read_member_functions, read_struct_fields)
12557 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
12558 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
12559 (read_struct_type): Update.
12560
12561 2019-03-06 Tom Tromey <tom@tromey.com>
12562
12563 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
12564 * common/filestuff.h (make_cleanup_close): Don't declare.
12565 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
12566 Remove.
12567
12568 2019-03-06 Tom Tromey <tom@tromey.com>
12569
12570 * solib-aix.c: Use make_scope_exit.
12571
12572 2019-03-06 Tom Tromey <tom@tromey.com>
12573
12574 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
12575 Use make_scope_exit.
12576
12577 2019-03-06 Tom Tromey <tom@tromey.com>
12578
12579 * solib-svr4.c (disable_probes_interface): Remove parameter.
12580 (svr4_handle_solib_event): Use make_scope_exit.
12581
12582 2019-03-06 Tom Tromey <tom@tromey.com>
12583
12584 * remote.c (struct stop_reply_deleter): Remove.
12585 (stop_reply_up): Update.
12586 (struct stop_reply): Derive from notif_event. Don't typedef.
12587 <regcache>: Now a std::vector.
12588 (stop_reply_xfree): Remove.
12589 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
12590 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
12591 (remote_target::discard_pending_stop_replies): Use delete.
12592 (remote_target::remote_parse_stop_reply): Update.
12593 (remote_target::process_stop_reply): Update.
12594 * remote-notif.h (struct notif_event): Add virtual destructor.
12595 Remove "dtr" member.
12596 (struct notif_client) <alloc_event>: Return a unique_ptr.
12597 (notif_event_xfree): Don't declare.
12598 (notif_event_up): New typedef.
12599 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
12600 (notif_event_xfree, do_notif_event_xfree): Remove.
12601 (remote_notif_state_xfree): Update.
12602
12603 2019-03-06 Tom Tromey <tom@tromey.com>
12604
12605 * infrun.c (displaced_step_clear_cleanup): Now a
12606 forward_scope_exit type.
12607 (displaced_step_prepare_throw): Update.
12608 (displaced_step_fixup): Update.
12609
12610 2019-03-06 Tom Tromey <tom@tromey.com>
12611
12612 * inferior.h (class inferior): Update comment.
12613 * gdbthread.h (class thread_info): Update comment.
12614
12615 2019-03-06 Joel Brobecker <brobecker@adacore.com>
12616 Tom Tromey <tom@tromey.com>
12617
12618 * stabsread.h (struct stab_section_list): Remove.
12619 (coffstab_build_psymtabs): Update.
12620 * dbxread.c (symbuf_sections): Now a std::vector.
12621 (sect_idx): New global.
12622 (fill_symbuf): Update.
12623 (coffstab_build_psymtabs): Change type of stabsects parameter.
12624 Update.
12625 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
12626 std::vector.
12627 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
12628 (coff_locate_sections): Update.
12629 (coff_symfile_read): Remove cleanups. Update.
12630 (init_stringtab): Add storage parameter.
12631 (free_stringtab, free_stringtab_cleanup): Remove.
12632 (init_lineno): Add storage parameter.
12633 (free_linetab, free_linetab_cleanup): Remove.
12634
12635 2019-03-06 Pedro Alves <palves@redhat.com>
12636
12637 * linux-fork.c (fork_info::clobber_regs): Delete.
12638 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
12639 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
12640 comment. Adjust.
12641 (scoped_switch_fork_info::scoped_switch_fork_info)
12642 (checkpoint_command, linux_fork_context): Adjust
12643 fork_save_infrun_state calls.
12644
12645 2019-03-06 Pedro Alves <palves@redhat.com>
12646
12647 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
12648 (inf_has_multiple_threads): Return 'bool' and rewrite using
12649 inferior_info::threads().
12650
12651 2019-03-06 Pedro Alves <palves@redhat.com>
12652
12653 * linux-fork.c: Include <list>.
12654 (fork_list): Now a std::list instance.
12655 (fork_info): Add ctor, dtor, and in-class initialize all fields.
12656 (forks_exist_p, find_last_fork): Adjust.
12657 (new_fork): Delete.
12658 (one_fork_p): New.
12659 (add_fork): Adjust.
12660 (free_fork): Delete, folded into fork_info::~fork_info().
12661 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
12662 Adjust.
12663 (init_fork_list): Delete.
12664 (linux_fork_killall, linux_fork_mourn_inferior)
12665 (linux_fork_detach, info_checkpoints_command): Adjust.
12666 (_initialize_linux_fork): No longer call init_fork_list.
12667
12668 2019-03-06 Pedro Alves <palves@redhat.com>
12669
12670 * linux-fork.c (new_fork): New, split out of ...
12671 (add_fork): ... this. Return void. Move "first fork" special
12672 case from here, to ...
12673 (checkpoint_command): ... here.
12674 * linux-linux.h (add_fork): Return void.
12675
12676 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12677
12678 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
12679
12680 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12681 Chris January <chris.january@arm.com>
12682 David Lecomber <david.lecomber@arm.com>
12683
12684 * f-exp.y: New token, UNOP_INTRINSIC.
12685 (exp): New pattern using UNOP_INTRINSIC token.
12686 (f77_keywords): Add 'abs' keyword.
12687 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
12688 (value_from_host_double): New function.
12689 (evaluate_subexp_f): Support UNOP_ABS.
12690
12691 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12692
12693 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
12694 types.
12695
12696 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12697
12698 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
12699 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
12700 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
12701
12702 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12703
12704 * f-exp.y (convert_to_kind_type): Handle more type kinds.
12705
12706 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12707 Chris January <chris.january@arm.com>
12708
12709 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
12710 * f-exp.y: Define 'KIND' token.
12711 (exp): New pattern for KIND expressions.
12712 (ptype): Handle types with a kind extension.
12713 (direct_abs_decl): Extend to spot kind extensions.
12714 (f77_keywords): Add 'kind' to the list.
12715 (push_kind_type): New function.
12716 (convert_to_kind_type): New function.
12717 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
12718 * parse.c (operator_length_standard): Likewise.
12719 * parser-defs.h (enum type_pieces): Add tp_kind.
12720 * std-operator.def: Add UNOP_KIND.
12721
12722 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12723
12724 * f-exp.y (f_parse): Set yydebug.
12725
12726 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12727
12728 * f-lang.c (evaluate_subexp_f): New function.
12729 (exp_descriptor_f): New global.
12730 (f_language_defn): Use exp_descriptor_f instead of
12731 exp_descriptor_standard.
12732
12733 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12734
12735 * f-exp.y (struct token): Add comments.
12736 (dot_ops): Remove uppercase versions and the end marker.
12737 (f77_keywords): Likewise.
12738 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
12739 entries in the dot_ops array are case insensitive, and use
12740 strncasecmp to compare strings. Also some whitespace cleanup in
12741 this area. Similar for the f77_keywords array, except entries in
12742 this list might be case sensitive.
12743
12744 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
12745
12746 * f-exp.y (struct f77_boolean_val): Add comments.
12747 (boolean_values): Remove uppercase versions, and end marker.
12748 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
12749 and use strncasecmp to achieve case insensitivity. Additionally,
12750 perform whitespace cleanup around this code.
12751
12752 2019-03-06 Tom Tromey <tromey@adacore.com>
12753
12754 * remote-sim.c (gdbsim_target_open): Use result of
12755 gdb_argv::release.
12756
12757 2019-03-06 Richard Bunt <richard.bunt@arm.com>
12758 Dirk Schubert <dirk.schubert@arm.com>
12759 Chris January <chris.january@arm.com>
12760
12761 * eval.c (evaluate_subexp_standard): Call Fortran argument
12762 wrapping logic.
12763 * f-lang.c (struct value): A value which can be passed into a
12764 Fortran function call.
12765 (fortran_argument_convert): Wrap Fortran arguments in a pointer
12766 where appropriate.
12767 (struct type): Value ready for a Fortran function call.
12768 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
12769 is needed.
12770 * f-lang.h (fortran_argument_convert): Declaration.
12771 (fortran_preserve_arg_pointer): Declaration.
12772 * infcall.c (value_arg_coerce): Call Fortran argument logic.
12773
12774 2019-03-05 Tom Tromey <tromey@adacore.com>
12775
12776 * python/py-prettyprint.c (print_string_repr): Remove #if.
12777 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
12778
12779 2019-03-05 Tom Tromey <tromey@adacore.com>
12780
12781 * target.c (the_dummy_target): Move later. Change type to
12782 "dummy_target".
12783 (initialize_targets): Don't initialize the_dummy_target.
12784
12785 2019-03-05 Tom Tromey <tromey@adacore.com>
12786
12787 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
12788 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
12789
12790 2019-03-05 Tom Tromey <tromey@adacore.com>
12791
12792 * windows-nat.c (windows_nat_target::attach)
12793 (windows_nat_target::detach): Don't call gdb_flush.
12794 * valprint.c (generic_val_print, val_print, val_print_string):
12795 Don't call gdb_flush.
12796 * utils.c (defaulted_query): Don't call gdb_flush.
12797 * typeprint.c (print_type_scalar): Don't call gdb_flush.
12798 * target.c (target_announce_detach): Don't call gdb_flush.
12799 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
12800 * remote.c (extended_remote_target::attach): Don't call
12801 gdb_flush.
12802 * procfs.c (procfs_target::detach): Don't call gdb_flush.
12803 * printcmd.c (do_examine): Don't call gdb_flush.
12804 (info_display_command): Don't call gdb_flush.
12805 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
12806 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
12807 * memattr.c (info_mem_command): Don't call gdb_flush.
12808 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
12809 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
12810 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
12811 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
12812 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
12813 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
12814 (gnu_nat_target::detach): Don't call gdb_flush.
12815 * f-valprint.c (f_val_print): Don't call gdb_flush.
12816 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
12817 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
12818 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
12819 gdb_flush.
12820 * c-valprint.c (c_val_print): Don't call gdb_flush.
12821 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
12822
12823 2019-03-05 Tom Tromey <tromey@adacore.com>
12824
12825 * varobj.c (update_dynamic_varobj_children): Update.
12826 (install_default_visualizer): Use reset, not release.
12827 * value.c (set_internalvar): Update.
12828 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
12829 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
12830 ATTRIBUTE_UNUSED_RESULT.
12831
12832 2019-03-05 Tom Tromey <tromey@adacore.com>
12833
12834 * remote.c (class scoped_remote_fd) <release>: Add
12835 ATTRIBUTE_UNUSED_RESULT.
12836
12837 2019-03-05 Tom Tromey <tromey@adacore.com>
12838
12839 * macroexp.c (struct macro_buffer) <release>: Add
12840 ATTRIBUTE_UNUSED_RESULT.
12841
12842 2019-03-05 Tom Tromey <tromey@adacore.com>
12843
12844 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
12845 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
12846 ATTRIBUTE_UNUSED_RESULT.
12847
12848 2019-03-05 Tom Tromey <tromey@adacore.com>
12849
12850 * common/scoped_fd.h (class scoped_fd) <release>: Add
12851 ATTRIBUTE_UNUSED_RESULT.
12852
12853 2019-03-05 Tom Tromey <tromey@adacore.com>
12854
12855 * parser-defs.h (struct parser_state) <release>: Add
12856 ATTRIBUTE_UNUSED_RESULT.
12857
12858 2019-03-05 Tom Tromey <tromey@adacore.com>
12859
12860 * utils.h (class gdb_argv) <release>: Add
12861 ATTRIBUTE_UNUSED_RESULT.
12862 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
12863
12864 2019-03-02 Eli Zaretskii <eliz@gnu.org>
12865
12866 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
12867 for-loop range, to avoid compiler warnings.
12868
12869 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
12870 avoid compiler warnings about unused variables.
12871
12872 * NEWS: Mention end of support for native debugging on MS-Windows
12873 before XP.
12874
12875 PR gdb/24292
12876 * common/netstuff.c:
12877 * gdbserver/gdbreplay.c
12878 * gdbserver/remote-utils.c:
12879 * ser-tcp.c:
12880 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
12881 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
12882 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
12883 'getaddrinfo' and 'freeaddrinfo' were not available before
12884 Windows XP, and mingw.org's MinGW headers by default define
12885 _WIN32_WINNT to 0x500.
12886
12887 2019-03-01 Gary Benson <gbenson@redhat.com>
12888
12889 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
12890
12891 2019-02-28 Brian Vandenberg <phantall@gmail.com>
12892 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
12893
12894 PR gdb/8527
12895 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
12896 set_sigint_trap, clear_sigint_trap.
12897
12898 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12899
12900 * target.c (target_detach): Clear the regcache and the
12901 frame cache.
12902
12903 2019-02-27 Pedro Alves <palves@redhat.com>
12904
12905 * utils.c (set_screen_size): When we cap the height/width sizes,
12906 tweak the corresponding command variable to show "unlimited":
12907
12908 2019-02-27 Saagar Jha <saagar@saagarjha.com>
12909 Pedro Alves <palves@redhat.com>
12910
12911 * utils.c (set_screen_size): Reduce "infinite" rows and columns
12912 before calling rl_set_screen_size.
12913
12914 2019-02-27 Tom Tromey <tromey@adacore.com>
12915
12916 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
12917 define.
12918 * python/py-value.c: Remove Python 2.4 workaround.
12919 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
12920 workaround.
12921 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
12922 Python 2.4 workaround.
12923 * python/python-internal.h: Remove Python 2.4 comment.
12924 (Py_ssize_t): Don't define.
12925 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
12926 (gdb_Py_DECREF): Remove Python 2.4 workaround.
12927 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
12928 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
12929 * python/python.c (do_start_initialization): Remove Python 2.4
12930 workaround.
12931 * python/py-prettyprint.c (class dummy_python_frame): Remove.
12932 (print_children): Remove Python 2.4 workaround.
12933 * python/py-inferior.c (buffer_procs): Remove Python 2.4
12934 workaround.
12935 (CHARBUFFERPROC_NAME): Remove.
12936 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
12937 Python 2.4 workaround.
12938
12939 2019-02-27 Kevin Buettner <kevinb@redhat.com>
12940
12941 * NEWS: Note minimum Python version.
12942
12943 2019-02-27 Kevin Buettner <kevinb@redhat.com>
12944
12945 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
12946 code from these functions. Remove corresponding ifdefs. Use
12947 Py_buffer_up instead of explicit calls to PyBuffer_Release.
12948 Remove gotos and target of gotos.
12949 (infpy_search_memory): Likewise.
12950
12951 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12952
12953 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
12954 (hppa_gdbarch_init): Don't register deleted functions with
12955 gdbarch.
12956
12957 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12958
12959 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
12960 (h8300_unwind_sp): Delete.
12961 (h8300_dummy_id): Delete.
12962 (h8300_gdbarch_init): Don't register deleted functions with
12963 gdbarch.
12964
12965 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12966
12967 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
12968 (ft32_unwind_pc): Delete.
12969 (ft32_unwind_sp): Delete.
12970 (ft32_gdbarch_init): Don't register deleted functions with
12971 gdbarch.
12972
12973 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12974
12975 * gdb/frv-tdep.c (frv_dummy_id): Delete.
12976 (frv_unwind_pc): Delete.
12977 (frv_unwind_sp): Delete.
12978 (frv_gdbarch_init): Don't register deleted functions with
12979 gdbarch.
12980
12981 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12982
12983 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
12984 (riscv_unwind_pc): Delete.
12985 (riscv_unwind_sp): Delete.
12986 (riscv_gdbarch_init): Don't register deleted functions with
12987 gdbarch.
12988
12989 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12990
12991 * gdb/csky-tdep.c (csky_dummy_id): Delete.
12992 (csky_unwind_pc): Delete.
12993 (csky_unwind_sp): Delete.
12994 (csky_gdbarch_init): Don't register deleted functions with
12995 gdbarch.
12996
12997 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
12998
12999 * gdb/cris-tdep.c (cris_dummy_id): Delete.
13000 (cris_unwind_pc): Delete.
13001 (cris_unwind_sp): Delete.
13002 (cris_gdbarch_init): Don't register deleted functions with
13003 gdbarch.
13004
13005 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13006
13007 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13008 (bfin_unwind_pc): Delete.
13009 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13010
13011 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13012
13013 * gdb/arm-tdep.c (arm_dummy_id): Delete.
13014 (arm_unwind_pc): Delete.
13015 (arm_unwind_sp): Delete.
13016 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13017
13018 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13019
13020 * gdb/arc-tdep.c (arc_dummy_id): Delete.
13021 (arc_unwind_pc): Delete.
13022 (arc_unwind_sp): Delete.
13023 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13024
13025 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13026
13027 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13028 (alpha_unwind_pc): Delete.
13029 (alpha_gdbarch_init): Don't register deleted functions with
13030 gdbarch.
13031
13032 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13033
13034 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13035 (aarch64_unwind_pc): Delete.
13036 (aarch64_unwind_sp): Delete.
13037 (aarch64_gdbarch_init): Don't register deleted functions with
13038 gdbarch.
13039
13040 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13041
13042 * gdbtypes.c (type_align): Don't consider static members when
13043 computing structure alignment.
13044
13045 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13046
13047 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13048 return 0 for other types.
13049 * arch-utils.c (default_type_align): Always return 0.
13050 * gdbarch.h: Regenerate.
13051 * gdbarch.sh (type_align): Extend comment.
13052 * gdbtypes.c (type_align): Add additional comments, always call
13053 gdbarch_type_align before applying the default rules.
13054 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13055 generic code will then apply a suitable default.
13056 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13057 types, return 0 for other types.
13058
13059 2019-02-27 Joel Brobecker <brobecker@adacore.com>
13060
13061 * NEWS: Create a new section for the next release branch.
13062 Rename the section of the current branch, now that it has
13063 been cut.
13064
13065 2019-02-27 Joel Brobecker <brobecker@adacore.com>
13066
13067 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13068 * version.in: Bump version to 8.3.50.DATE-git.
13069
13070 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
13071
13072 * aix-thread.c (ptid_cmp): Remove unused variable.
13073 (get_signaled_thread): Likewise.
13074 (store_regs_user_thread): Likewise.
13075 (store_regs_kernel_thread): Likewise.
13076 (fetch_regs_kernel_thread): Remove shadowed variable.
13077
13078 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
13079
13080 * features/riscv/32bit-cpu.xml: Add register numbers.
13081 * features/riscv/32bit-fpu.c: Regenerate.
13082 * features/riscv/32bit-fpu.xml: Add register numbers.
13083 * features/riscv/64bit-cpu.xml: Add register numbers.
13084 * features/riscv/64bit-fpu.c: Regenerate.
13085 * features/riscv/64bit-fpu.xml: Add register numbers.
13086
13087 2019-02-26 Kevin Buettner <kevinb@redhat.com>
13088
13089 * NEWS: Mention two argument form of gdb.Value constructor.
13090 * python/py-value.c (convert_buffer_and_type_to_value): New
13091 function.
13092 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13093 Add support for handling an optional second argument. Call
13094 convert_buffer_and_type_to_value as appropriate.
13095 * python/python-internal.h (Py_buffer_deleter): New struct.
13096 (Py_buffer_up): New typedef.
13097
13098 2019-02-25 John Baldwin <jhb@FreeBSD.org>
13099
13100 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13101 instead of releasing ownership.
13102
13103 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
13104
13105 * dwarf2read.c (open_and_init_dwp_file): Call
13106 elf_numsections instead of bfd_count_sections to initialize
13107 dwp_file->num_sections.
13108
13109 2019-02-25 Tom Tromey <tromey@adacore.com>
13110
13111 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13112
13113 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
13114
13115 * gcore.in: Add '--readnever' option when invoking GDB.
13116
13117 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
13118
13119 * MAINTAINERS: Update my email address.
13120
13121 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
13122
13123 * build-id.c (build_id_to_debug_bfd_1): New function.
13124 (build_id_to_debug_bfd): Look for separate debug file in
13125 sysroot.
13126
13127 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
13128
13129 * gdbarch.sh: Update the copyright year range that is placed into
13130 generated files.
13131
13132 2019-02-22 Keith Seitz <keiths@redhat.com>
13133
13134 PR symtab/23853
13135 * linespec.c (create_sals_line_offset): Search for the default
13136 symtab's filename instead of its fullname.
13137
13138 2019-02-21 Alan Hayward <alan.hayward@arm.com>
13139
13140 * NEWS: Update style defaults.
13141
13142 2019-02-21 Alan Hayward <alan.hayward@arm.com>
13143
13144 * main.c (captured_main_1): Disable styling in batch mode.
13145
13146 2019-02-20 Tom Tromey <tom@tromey.com>
13147
13148 * symtab.c (symtab_symbol_info): Fix typos.
13149
13150 2019-02-20 Tom Tromey <tromey@adacore.com>
13151
13152 * findcmd.c (_initialize_mem_search): Use upper case for
13153 metasyntactic variables.
13154
13155 2019-02-20 Alan Hayward <alan.hayward@arm.com>
13156
13157 * aarch64-tdep.c (aarch64_add_reggroups): New function.
13158 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13159
13160 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
13161
13162 * top.h (source_file_name): Change to std::string.
13163 * top.c (source_file_name): Likewise.
13164 (command_line_input): Adjust.
13165 * cli/cli-script.c (script_from_file): Adjust.
13166
13167 2019-02-19 Tom Tromey <tromey@adacore.com>
13168
13169 * ravenscar-thread.c
13170 (ravenscar_thread_target::update_thread_list): Don't call
13171 ada_build_task_list.
13172 * ada-lang.h (ada_build_task_list): Don't declare.
13173 * ada-tasks.c (struct ada_tasks_inferior_data)
13174 <task_list_valid_p>: Now bool.
13175 (read_known_tasks, ada_task_list_changed)
13176 (ada_tasks_invalidate_inferior_data): Update.
13177 (read_known_tasks_array): Return bool.
13178 (read_known_tasks_list): Likewise.
13179 (read_known_tasks): Return void.
13180 (ada_build_task_list): Now static.
13181
13182 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
13183
13184 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13185 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13186
13187 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13188
13189 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13190 variant for ada_tasks_pspace_data_handle and
13191 ada_tasks_inferior_data_handle.
13192 (ada_tasks_pspace_data_cleanup): New function.
13193 (ada_tasks_inferior_data_cleanup): New function.
13194
13195 2019-02-17 Tom Tromey <tom@tromey.com>
13196
13197 * macrotab.h (macro_source_fullname): Return a std::string.
13198 * macrotab.c (macro_include, check_for_redefinition)
13199 (macro_undef, macro_lookup_definition, foreach_macro)
13200 (foreach_macro_in_scope): Update.
13201 (macro_source_fullname): Return a std::string.
13202 * macrocmd.c (show_pp_source_pos): Update.
13203
13204 2019-02-17 Tom Tromey <tom@tromey.com>
13205
13206 * macrocmd.c (show_pp_source_pos): Style the file names.
13207
13208 2019-02-17 Tom Tromey <tom@tromey.com>
13209
13210 PR tui/24197:
13211 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13212
13213 2019-02-17 Tom Tromey <tom@tromey.com>
13214
13215 * ada-lang.c (user_select_syms): Use filtered printing.
13216 * utils.c (wrap_style): New global.
13217 (desired_style): Remove.
13218 (emit_style_escape): Add stream parameter.
13219 (set_output_style, reset_terminal_style, prompt_for_continue):
13220 Update.
13221 (flush_wrap_buffer): Only flush gdb_stdout.
13222 (wrap_here): Set wrap_style.
13223 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
13224 treat escape sequences as a character. Change when wrap buffer is
13225 flushed.
13226 (fputs_styled): Do not set the output style when the default is
13227 requested.
13228 * ui-style.h (struct ui_file_style) <is_default>: New method.
13229 * source.c (print_source_lines_base): Emit escape sequences in one
13230 piece.
13231
13232 2019-02-17 Joel Brobecker <brobecker@adacore.com>
13233
13234 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13235 integers and enumeration types.
13236
13237 2019-02-17 Joel Brobecker <brobecker@adacore.com>
13238
13239 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13240 instead of lookup_symbol_in_language
13241 (do_exact_match): New function.
13242 (ada_get_symbol_name_matcher): Return do_exact_match when
13243 doing a verbatim match.
13244
13245 2019-02-15 Tom Tromey <tromey@adacore.com>
13246
13247 * ravenscar-thread.c (ravenscar_thread_target::resume)
13248 (ravenscar_thread_target::wait): Special case wildcard requests.
13249
13250 2019-02-15 Tom Tromey <tromey@adacore.com>
13251
13252 * ravenscar-thread.c (base_ptid): Remove.
13253 (struct ravenscar_thread_target) <close>: New method.
13254 <m_base_ptid>: New member.
13255 <update_inferior_ptid, active_task, task_is_currently_active,
13256 runtime_initialized>: Declare methods.
13257 <ravenscar_thread_target>: Add constructor.
13258 (ravenscar_thread_target::task_is_currently_active)
13259 (ravenscar_thread_target::update_inferior_ptid)
13260 (ravenscar_runtime_initialized): Rename. Now methods.
13261 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13262 (ravenscar_thread_target::update_thread_list): Update.
13263 (ravenscar_thread_target::active_task): Now method.
13264 (ravenscar_thread_target::store_registers)
13265 (ravenscar_thread_target::prepare_to_store)
13266 (ravenscar_thread_target::prepare_to_store)
13267 (ravenscar_thread_target::mourn_inferior): Update.
13268 (ravenscar_inferior_created): Use "new" to create target.
13269 (ravenscar_thread_target::get_ada_task_ptid): Update.
13270 (_initialize_ravenscar): Don't initialize base_ptid.
13271 (ravenscar_ops): Remove global.
13272
13273 2019-02-15 Tom Tromey <tromey@adacore.com>
13274
13275 * target.h (push_target): Declare new overload.
13276 * target.c (push_target): New overload, taking an rvalue reference.
13277 * remote.c (remote_target::open_1): Use push_target overload.
13278 * corelow.c (core_target_open): Use push_target overload.
13279
13280 2019-02-15 Tom Tromey <tromey@adacore.com>
13281
13282 * ravenscar-thread.c (is_ravenscar_task)
13283 (ravenscar_task_is_currently_active): Return bool.
13284 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13285 (_initialize_ravenscar): Remove "(void)".
13286 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13287 Return bool.
13288
13289 2019-02-15 Tom Tromey <tromey@adacore.com>
13290
13291 * ravenscar-thread.c (ravenscar_runtime_initializer)
13292 (has_ravenscar_runtime, get_running_thread_id)
13293 (ravenscar_thread_target::resume): Fix indentation.
13294
13295 2019-02-15 Tom Tromey <tromey@adacore.com>
13296
13297 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13298 from ravenscar_arch_ops.
13299 (sparc_ravenscar_ops::fetch_registers)
13300 (sparc_ravenscar_ops::store_registers): Now methods.
13301 (sparc_ravenscar_prepare_to_store): Remove.
13302 (sparc_ravenscar_ops): Redefine.
13303 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13304 methods and destructor. Remove members.
13305 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13306 (ravenscar_thread_target::store_registers)
13307 (ravenscar_thread_target::prepare_to_store): Update.
13308 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13309 Remove.
13310 (struct ppc_ravenscar_powerpc_ops): Derive from
13311 ravenscar_arch_ops.
13312 (ppc_ravenscar_powerpc_ops::fetch_registers)
13313 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13314 (ppc_ravenscar_powerpc_ops): Redefine.
13315 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13316 (ppc_ravenscar_e500_ops::fetch_registers)
13317 (ppc_ravenscar_e500_ops::store_registers): Now methods.
13318 (ppc_ravenscar_e500_ops): Redefine.
13319 * aarch64-ravenscar-thread.c
13320 (aarch64_ravenscar_generic_prepare_to_store): Remove.
13321 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13322 (aarch64_ravenscar_fetch_registers)
13323 (aarch64_ravenscar_store_registers): Now methods.
13324 (aarch64_ravenscar_ops): Redefine.
13325
13326 2019-02-15 Tom Tromey <tromey@adacore.com>
13327
13328 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13329 (ravenscar_thread_target::stopped_by_hw_breakpoint)
13330 (ravenscar_thread_target::stopped_by_watchpoint)
13331 (ravenscar_thread_target::stopped_data_address)
13332 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13333
13334 2019-02-15 Tom Tromey <tromey@adacore.com>
13335
13336 * ravenscar-thread.c: Fix some typos.
13337
13338 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13339 Tom Tromey <tromey@adacore.com>
13340
13341 * ada-lang.c (ada_exception_sal): Change addr_string to a
13342 std::string.
13343 (create_ada_exception_catchpoint): Update.
13344
13345 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13346 Tom Tromey <tromey@adacore.com>
13347
13348 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13349 (bp_location_ops): Remove.
13350 (base_breakpoint_allocate_location): Update.
13351 (free_bp_location): Update.
13352 * ada-lang.c (class ada_catchpoint_location)
13353 <ada_catchpoint_location>: Remove ops parameter.
13354 (ada_catchpoint_location_dtor): Remove.
13355 (ada_catchpoint_location_ops): Remove.
13356 (allocate_location_exception): Update.
13357 * breakpoint.h (struct bp_location_ops): Remove.
13358 (class bp_location) <bp_location>: Remove bp_location_ops
13359 parameter.
13360 <~bp_location>: Add destructor.
13361 <ops>: Remove.
13362
13363 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
13364 Pedro Alves <palves@redhat.com>
13365
13366 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13367 'PATH_MAX'.
13368
13369 2019-02-14 David Michael <fedora.dm0@gmail.com>
13370 Samuel Thibault <samuel.thibault@gnu.org>
13371 Thomas Schwinge <thomas@codesourcery.com>
13372
13373 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13374 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13375
13376 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
13377
13378 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13379 (check_empty): Use "const char *".
13380
13381 * gnu-nat.c (gnu_nat_target::detach): Instead of
13382 'detach_inferior (pid)' call
13383 'detach_inferior (find_inferior_pid (pid))'.
13384
13385 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13386 'nat/fork-inferior.o'.
13387 * gnu-nat.c: #include "nat/fork-inferior.h".
13388
13389 * gnu-nat.c (gnu_nat_target::detach): Instead of
13390 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13391 * gnu-nat.h: #include "inf-child.h".
13392 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13393 'i386_gnu_nat_target::fetch_registers'.
13394 (gnu_store_registers): Rename/move to
13395 'i386_gnu_nat_target::store_registers'.
13396
13397 * config/i386/nm-i386gnu.h: Don't "#include" any files.
13398 * gnu-nat.h (mach_thread_info): New function.
13399 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13400
13401 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13402
13403 2019-02-14 Frederic Konrad <konrad@adacore.com>
13404
13405 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13406
13407 2019-02-14 Joel Brobecker <brobecker@adacore.com>
13408
13409 * windows-nat.c (windows_add_thread): Add new parameter
13410 "main_thread_p" with default value set to false. Update
13411 function documentation as well as all callers.
13412 (windows_delete_thread): Likewise.
13413 (fake_create_process): Update call to windows_add_thread.
13414 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
13415 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
13416 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
13417 call to windows_delete_thread.
13418
13419 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
13420
13421 * MAINTAINERS: Add Andrew Burgess as global maintainer.
13422
13423 2019-02-12 John Baldwin <jhb@FreeBSD.org>
13424
13425 * symfile.c (find_separate_debug_file): Use canonical path of
13426 sysroot with child_path instead of gdb_sysroot if it is valid.
13427
13428 2019-02-12 John Baldwin <jhb@FreeBSD.org>
13429
13430 * symfile.c (find_separate_debug_file): Use child_path to
13431 determine if an object file is under a sysroot.
13432
13433 2019-02-12 John Baldwin <jhb@FreeBSD.org>
13434
13435 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
13436 unittests/child-path-selftests.c.
13437 * common/pathstuff.c (child_path): New function.
13438 * common/pathstuff.h (child_path): New prototype.
13439 * unittests/child-path-selftests.c: New file.
13440
13441 2019-02-12 John Baldwin <jhb@FreeBSD.org>
13442
13443 * symfile.c (find_separate_debug_file): Look for separate debug
13444 files in debug directories under the sysroot.
13445
13446 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13447
13448 * symtab.h (struct minimal_symbol data_p): New const method.
13449 (struct minimal_symbol text_p): Likewise.
13450 * symtab.c (output_source_filename): Use file name style
13451 to print file name.
13452 (print_symbol_info): Likewise.
13453 (print_msymbol_info): Use address style to print addresses.
13454 Use function name style to print executable text symbols.
13455 (expand_symtab_containing_pc): Use data_p.
13456 (find_pc_sect_compunit_symtab): Likewise.
13457
13458 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13459
13460 * breakpoint.c (describe_other_breakpoints): Use address style
13461 to print addresses.
13462 (say_where): Likewise.
13463
13464 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13465
13466 * ada-typeprint.c (print_func_type): Print function name
13467 style to print function name.
13468 * c-typeprint.c (c_print_type_1): Likewise.
13469
13470 2019-02-11 Alan Hayward <alan.hayward@arm.com>
13471
13472 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
13473 for execve.
13474
13475 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13476
13477 * c-exp.y (direct_abs_decl): Use emplace_back to record the
13478 type_stack.
13479
13480 2019-02-10 Joel Brobecker <brobecker@adacore.com>
13481
13482 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
13483 TYPE_CODE_REF types.
13484
13485 2019-02-08 Jim Wilson <jimw@sifive.com>
13486
13487 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
13488 (riscv_linux_fregset): New.
13489 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
13490
13491 2019-02-07 Tom Tromey <tom@tromey.com>
13492
13493 * thread.c (thread_cancel_execution_command): Update.
13494 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
13495 methods.
13496 (struct thread_fsm_ops): Remove.
13497 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
13498 (thread_fsm_should_stop, thread_fsm_return_value)
13499 (thread_fsm_set_finished, thread_fsm_finished_p)
13500 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
13501 Don't declare.
13502 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
13503 * infrun.c (clear_proceed_status_thread)
13504 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
13505 (print_stop_event): Update.
13506 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
13507 Add constructor.
13508 (step_command_fsm_ops): Remove.
13509 (new_step_command_fsm): Remove.
13510 (step_1): Update.
13511 (step_command_fsm::should_stop): Rename from
13512 step_command_fsm_should_stop.
13513 (step_command_fsm::clean_up): Rename from
13514 step_command_fsm_clean_up.
13515 (step_command_fsm::do_async_reply_reason): Rename from
13516 step_command_fsm_async_reply_reason.
13517 (struct until_next_fsm): Inherit from thread_fsm. Add
13518 constructor.
13519 (until_next_fsm_ops): Remove.
13520 (new_until_next_fsm): Remove.
13521 (until_next_fsm::should_stop): Rename from
13522 until_next_fsm_should_stop.
13523 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
13524 (until_next_fsm::do_async_reply_reason): Rename from
13525 until_next_fsm_async_reply_reason.
13526 (struct finish_command_fsm): Inherit from thread_fsm. Add
13527 constructor. Change type of breakpoint.
13528 (finish_command_fsm_ops): Remove.
13529 (new_finish_command_fsm): Remove.
13530 (finish_command_fsm::should_stop): Rename from
13531 finish_command_fsm_should_stop.
13532 (finish_command_fsm::clean_up): Rename from
13533 finish_command_fsm_clean_up.
13534 (finish_command_fsm::return_value): Rename from
13535 finish_command_fsm_return_value.
13536 (finish_command_fsm::do_async_reply_reason): Rename from
13537 finish_command_fsm_async_reply_reason.
13538 (finish_command): Update.
13539 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
13540 Add constructor.
13541 (call_thread_fsm_ops): Remove.
13542 (call_thread_fsm::call_thread_fsm): Rename from
13543 new_call_thread_fsm.
13544 (call_thread_fsm::should_stop): Rename from
13545 call_thread_fsm_should_stop.
13546 (call_thread_fsm::should_notify_stop): Rename from
13547 call_thread_fsm_should_notify_stop.
13548 (run_inferior_call, call_function_by_hand_dummy): Update.
13549 * cli/cli-interp.c (should_print_stop_to_console): Update.
13550 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
13551 Add constructor. Change type of location_breakpoint,
13552 caller_breakpoint.
13553 (until_break_fsm_ops): Remove.
13554 (new_until_break_fsm): Remove.
13555 (until_break_fsm::should_stop): Rename from
13556 until_break_fsm_should_stop.
13557 (until_break_fsm::clean_up): Rename from
13558 until_break_fsm_clean_up.
13559 (until_break_fsm::do_async_reply_reason): Rename from
13560 until_break_fsm_async_reply_reason.
13561 (until_break_command): Update.
13562 * thread-fsm.c: Remove.
13563 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
13564
13565 2019-02-07 Tom Tromey <tom@tromey.com>
13566
13567 * yy-remap.h: Add include guard.
13568 * xtensa-tdep.h: Add include guard.
13569 * xcoffread.h: Rename include guard.
13570 * varobj-iter.h: Add include guard.
13571 * tui/tui.h: Rename include guard.
13572 * tui/tui-winsource.h: Rename include guard.
13573 * tui/tui-wingeneral.h: Rename include guard.
13574 * tui/tui-windata.h: Rename include guard.
13575 * tui/tui-win.h: Rename include guard.
13576 * tui/tui-stack.h: Rename include guard.
13577 * tui/tui-source.h: Rename include guard.
13578 * tui/tui-regs.h: Rename include guard.
13579 * tui/tui-out.h: Rename include guard.
13580 * tui/tui-layout.h: Rename include guard.
13581 * tui/tui-io.h: Rename include guard.
13582 * tui/tui-hooks.h: Rename include guard.
13583 * tui/tui-file.h: Rename include guard.
13584 * tui/tui-disasm.h: Rename include guard.
13585 * tui/tui-data.h: Rename include guard.
13586 * tui/tui-command.h: Rename include guard.
13587 * tic6x-tdep.h: Add include guard.
13588 * target/waitstatus.h: Rename include guard.
13589 * target/wait.h: Rename include guard.
13590 * target/target.h: Rename include guard.
13591 * target/resume.h: Rename include guard.
13592 * target-float.h: Rename include guard.
13593 * stabsread.h: Add include guard.
13594 * rs6000-tdep.h: Add include guard.
13595 * riscv-fbsd-tdep.h: Add include guard.
13596 * regformats/regdef.h: Rename include guard.
13597 * record.h: Rename include guard.
13598 * python/python.h: Rename include guard.
13599 * python/python-internal.h: Rename include guard.
13600 * python/py-stopevent.h: Rename include guard.
13601 * python/py-ref.h: Rename include guard.
13602 * python/py-record.h: Rename include guard.
13603 * python/py-record-full.h: Rename include guard.
13604 * python/py-record-btrace.h: Rename include guard.
13605 * python/py-instruction.h: Rename include guard.
13606 * python/py-events.h: Rename include guard.
13607 * python/py-event.h: Rename include guard.
13608 * procfs.h: Add include guard.
13609 * proc-utils.h: Add include guard.
13610 * p-lang.h: Add include guard.
13611 * or1k-tdep.h: Rename include guard.
13612 * observable.h: Rename include guard.
13613 * nto-tdep.h: Rename include guard.
13614 * nat/x86-linux.h: Rename include guard.
13615 * nat/x86-linux-dregs.h: Rename include guard.
13616 * nat/x86-gcc-cpuid.h: Add include guard.
13617 * nat/x86-dregs.h: Rename include guard.
13618 * nat/x86-cpuid.h: Rename include guard.
13619 * nat/ppc-linux.h: Rename include guard.
13620 * nat/mips-linux-watch.h: Rename include guard.
13621 * nat/linux-waitpid.h: Rename include guard.
13622 * nat/linux-ptrace.h: Rename include guard.
13623 * nat/linux-procfs.h: Rename include guard.
13624 * nat/linux-osdata.h: Rename include guard.
13625 * nat/linux-nat.h: Rename include guard.
13626 * nat/linux-namespaces.h: Rename include guard.
13627 * nat/linux-btrace.h: Rename include guard.
13628 * nat/glibc_thread_db.h: Rename include guard.
13629 * nat/gdb_thread_db.h: Rename include guard.
13630 * nat/gdb_ptrace.h: Rename include guard.
13631 * nat/fork-inferior.h: Rename include guard.
13632 * nat/amd64-linux-siginfo.h: Rename include guard.
13633 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
13634 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
13635 * nat/aarch64-linux.h: Rename include guard.
13636 * nat/aarch64-linux-hw-point.h: Rename include guard.
13637 * mn10300-tdep.h: Add include guard.
13638 * mips-linux-tdep.h: Add include guard.
13639 * mi/mi-parse.h: Rename include guard.
13640 * mi/mi-out.h: Rename include guard.
13641 * mi/mi-main.h: Rename include guard.
13642 * mi/mi-interp.h: Rename include guard.
13643 * mi/mi-getopt.h: Rename include guard.
13644 * mi/mi-console.h: Rename include guard.
13645 * mi/mi-common.h: Rename include guard.
13646 * mi/mi-cmds.h: Rename include guard.
13647 * mi/mi-cmd-break.h: Rename include guard.
13648 * m2-lang.h: Add include guard.
13649 * location.h: Rename include guard.
13650 * linux-record.h: Rename include guard.
13651 * linux-nat.h: Add include guard.
13652 * linux-fork.h: Add include guard.
13653 * i386-darwin-tdep.h: Rename include guard.
13654 * hppa-linux-offsets.h: Add include guard.
13655 * guile/guile.h: Rename include guard.
13656 * guile/guile-internal.h: Rename include guard.
13657 * gnu-nat.h: Rename include guard.
13658 * gdb-stabs.h: Rename include guard.
13659 * frv-tdep.h: Add include guard.
13660 * f-lang.h: Add include guard.
13661 * event-loop.h: Add include guard.
13662 * darwin-nat.h: Rename include guard.
13663 * cp-abi.h: Rename include guard.
13664 * config/sparc/nm-sol2.h: Rename include guard.
13665 * config/nm-nto.h: Rename include guard.
13666 * config/nm-linux.h: Add include guard.
13667 * config/i386/nm-i386gnu.h: Rename include guard.
13668 * config/djgpp/nl_types.h: Rename include guard.
13669 * config/djgpp/langinfo.h: Rename include guard.
13670 * compile/gcc-cp-plugin.h: Add include guard.
13671 * compile/gcc-c-plugin.h: Add include guard.
13672 * compile/compile.h: Rename include guard.
13673 * compile/compile-object-run.h: Rename include guard.
13674 * compile/compile-object-load.h: Rename include guard.
13675 * compile/compile-internal.h: Rename include guard.
13676 * compile/compile-cplus.h: Rename include guard.
13677 * compile/compile-c.h: Rename include guard.
13678 * common/xml-utils.h: Rename include guard.
13679 * common/x86-xstate.h: Rename include guard.
13680 * common/version.h: Rename include guard.
13681 * common/vec.h: Rename include guard.
13682 * common/tdesc.h: Rename include guard.
13683 * common/selftest.h: Rename include guard.
13684 * common/scoped_restore.h: Rename include guard.
13685 * common/scoped_mmap.h: Rename include guard.
13686 * common/scoped_fd.h: Rename include guard.
13687 * common/safe-iterator.h: Rename include guard.
13688 * common/run-time-clock.h: Rename include guard.
13689 * common/refcounted-object.h: Rename include guard.
13690 * common/queue.h: Rename include guard.
13691 * common/ptid.h: Rename include guard.
13692 * common/print-utils.h: Rename include guard.
13693 * common/preprocessor.h: Rename include guard.
13694 * common/pathstuff.h: Rename include guard.
13695 * common/observable.h: Rename include guard.
13696 * common/netstuff.h: Rename include guard.
13697 * common/job-control.h: Rename include guard.
13698 * common/host-defs.h: Rename include guard.
13699 * common/gdb_wait.h: Rename include guard.
13700 * common/gdb_vecs.h: Rename include guard.
13701 * common/gdb_unlinker.h: Rename include guard.
13702 * common/gdb_unique_ptr.h: Rename include guard.
13703 * common/gdb_tilde_expand.h: Rename include guard.
13704 * common/gdb_sys_time.h: Rename include guard.
13705 * common/gdb_string_view.h: Rename include guard.
13706 * common/gdb_splay_tree.h: Rename include guard.
13707 * common/gdb_setjmp.h: Rename include guard.
13708 * common/gdb_ref_ptr.h: Rename include guard.
13709 * common/gdb_optional.h: Rename include guard.
13710 * common/gdb_locale.h: Rename include guard.
13711 * common/gdb_assert.h: Rename include guard.
13712 * common/filtered-iterator.h: Rename include guard.
13713 * common/filestuff.h: Rename include guard.
13714 * common/fileio.h: Rename include guard.
13715 * common/environ.h: Rename include guard.
13716 * common/common-utils.h: Rename include guard.
13717 * common/common-types.h: Rename include guard.
13718 * common/common-regcache.h: Rename include guard.
13719 * common/common-inferior.h: Rename include guard.
13720 * common/common-gdbthread.h: Rename include guard.
13721 * common/common-exceptions.h: Rename include guard.
13722 * common/common-defs.h: Rename include guard.
13723 * common/common-debug.h: Rename include guard.
13724 * common/cleanups.h: Rename include guard.
13725 * common/buffer.h: Rename include guard.
13726 * common/btrace-common.h: Rename include guard.
13727 * common/break-common.h: Rename include guard.
13728 * cli/cli-utils.h: Rename include guard.
13729 * cli/cli-style.h: Rename include guard.
13730 * cli/cli-setshow.h: Rename include guard.
13731 * cli/cli-script.h: Rename include guard.
13732 * cli/cli-interp.h: Rename include guard.
13733 * cli/cli-decode.h: Rename include guard.
13734 * cli/cli-cmds.h: Rename include guard.
13735 * charset-list.h: Add include guard.
13736 * buildsym-legacy.h: Rename include guard.
13737 * bfin-tdep.h: Add include guard.
13738 * ax.h: Rename include guard.
13739 * arm-linux-tdep.h: Add include guard.
13740 * arm-fbsd-tdep.h: Add include guard.
13741 * arch/xtensa.h: Rename include guard.
13742 * arch/tic6x.h: Add include guard.
13743 * arch/i386.h: Add include guard.
13744 * arch/arm.h: Rename include guard.
13745 * arch/arm-linux.h: Rename include guard.
13746 * arch/arm-get-next-pcs.h: Rename include guard.
13747 * arch/amd64.h: Add include guard.
13748 * arch/aarch64-insn.h: Rename include guard.
13749 * arch-utils.h: Rename include guard.
13750 * annotate.h: Add include guard.
13751 * amd64-darwin-tdep.h: Rename include guard.
13752 * aarch64-linux-tdep.h: Add include guard.
13753 * aarch64-fbsd-tdep.h: Add include guard.
13754 * aarch32-linux-nat.h: Add include guard.
13755
13756 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13757
13758 * macrotab.c (macro_define_internal): New function that
13759 factorizes macro_define_object_internal and macro_define_function
13760 code.
13761 (macro_define_object_internal): Use macro_define_internal.
13762 (macro_define_function): Likewise.
13763
13764 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13765
13766 * macrocmd.c (extract_identifier): Return
13767 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
13768 callers.
13769
13770 2019-02-06 John Baldwin <jhb@FreeBSD.org>
13771
13772 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
13773
13774 2019-02-05 Tom Tromey <tom@tromey.com>
13775
13776 * target.c (target_stack::unpush): Move assertion earlier.
13777
13778 2019-01-30 Tom Tromey <tom@tromey.com>
13779
13780 PR python/23615:
13781 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
13782 (gdbpy_parse_and_eval): Likewise.
13783 * python/python-internal.h (gdbpy_allow_threads): New class.
13784
13785 2019-01-28 John Baldwin <jhb@FreeBSD.org>
13786
13787 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
13788 (aarch64_fbsd_fpregmap): Move earlier.
13789 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
13790 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13791 instead of individual calls to trad_frame_set_reg_addr.
13792 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
13793 earlier.
13794 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
13795 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
13796 instead of individual calls to trad_frame_set_reg_addr.
13797
13798 2019-01-28 Alan Hayward <alan.hayward@arm.com>
13799
13800 * CONTRIBUTE: Replace contribution list with wiki link.
13801
13802 2019-01-25 Tom Tromey <tom@tromey.com>
13803
13804 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
13805
13806 2019-01-25 Tom Tromey <tom@tromey.com>
13807
13808 * xtensa-linux-nat.c: Fix common/ includes.
13809 * xml-support.h: Fix common/ includes.
13810 * xml-support.c: Fix common/ includes.
13811 * x86-linux-nat.c: Fix common/ includes.
13812 * windows-nat.c: Fix common/ includes.
13813 * varobj.h: Fix common/ includes.
13814 * varobj.c: Fix common/ includes.
13815 * value.c: Fix common/ includes.
13816 * valops.c: Fix common/ includes.
13817 * utils.c: Fix common/ includes.
13818 * unittests/xml-utils-selftests.c: Fix common/ includes.
13819 * unittests/utils-selftests.c: Fix common/ includes.
13820 * unittests/unpack-selftests.c: Fix common/ includes.
13821 * unittests/tracepoint-selftests.c: Fix common/ includes.
13822 * unittests/style-selftests.c: Fix common/ includes.
13823 * unittests/string_view-selftests.c: Fix common/ includes.
13824 * unittests/scoped_restore-selftests.c: Fix common/ includes.
13825 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
13826 * unittests/scoped_fd-selftests.c: Fix common/ includes.
13827 * unittests/rsp-low-selftests.c: Fix common/ includes.
13828 * unittests/parse-connection-spec-selftests.c: Fix common/
13829 includes.
13830 * unittests/optional-selftests.c: Fix common/ includes.
13831 * unittests/offset-type-selftests.c: Fix common/ includes.
13832 * unittests/observable-selftests.c: Fix common/ includes.
13833 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
13834 * unittests/memrange-selftests.c: Fix common/ includes.
13835 * unittests/memory-map-selftests.c: Fix common/ includes.
13836 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
13837 * unittests/function-view-selftests.c: Fix common/ includes.
13838 * unittests/environ-selftests.c: Fix common/ includes.
13839 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
13840 * unittests/common-utils-selftests.c: Fix common/ includes.
13841 * unittests/cli-utils-selftests.c: Fix common/ includes.
13842 * unittests/array-view-selftests.c: Fix common/ includes.
13843 * ui-file.c: Fix common/ includes.
13844 * tui/tui-io.c: Fix common/ includes.
13845 * tracepoint.h: Fix common/ includes.
13846 * tracepoint.c: Fix common/ includes.
13847 * tracefile-tfile.c: Fix common/ includes.
13848 * top.h: Fix common/ includes.
13849 * top.c: Fix common/ includes.
13850 * thread.c: Fix common/ includes.
13851 * target/waitstatus.h: Fix common/ includes.
13852 * target/waitstatus.c: Fix common/ includes.
13853 * target.h: Fix common/ includes.
13854 * target.c: Fix common/ includes.
13855 * target-memory.c: Fix common/ includes.
13856 * target-descriptions.c: Fix common/ includes.
13857 * symtab.h: Fix common/ includes.
13858 * symfile.c: Fix common/ includes.
13859 * stap-probe.c: Fix common/ includes.
13860 * spu-linux-nat.c: Fix common/ includes.
13861 * sparc-nat.c: Fix common/ includes.
13862 * source.c: Fix common/ includes.
13863 * solib.c: Fix common/ includes.
13864 * solib-target.c: Fix common/ includes.
13865 * ser-unix.c: Fix common/ includes.
13866 * ser-tcp.c: Fix common/ includes.
13867 * ser-pipe.c: Fix common/ includes.
13868 * ser-base.c: Fix common/ includes.
13869 * selftest-arch.c: Fix common/ includes.
13870 * s12z-tdep.c: Fix common/ includes.
13871 * rust-exp.y: Fix common/ includes.
13872 * rs6000-aix-tdep.c: Fix common/ includes.
13873 * riscv-tdep.c: Fix common/ includes.
13874 * remote.c: Fix common/ includes.
13875 * remote-notif.h: Fix common/ includes.
13876 * remote-fileio.h: Fix common/ includes.
13877 * remote-fileio.c: Fix common/ includes.
13878 * regcache.h: Fix common/ includes.
13879 * regcache.c: Fix common/ includes.
13880 * record-btrace.c: Fix common/ includes.
13881 * python/python.c: Fix common/ includes.
13882 * python/py-type.c: Fix common/ includes.
13883 * python/py-inferior.c: Fix common/ includes.
13884 * progspace.h: Fix common/ includes.
13885 * producer.c: Fix common/ includes.
13886 * procfs.c: Fix common/ includes.
13887 * proc-api.c: Fix common/ includes.
13888 * printcmd.c: Fix common/ includes.
13889 * ppc-linux-nat.c: Fix common/ includes.
13890 * parser-defs.h: Fix common/ includes.
13891 * osdata.c: Fix common/ includes.
13892 * obsd-nat.c: Fix common/ includes.
13893 * nat/x86-linux.c: Fix common/ includes.
13894 * nat/x86-linux-dregs.c: Fix common/ includes.
13895 * nat/x86-dregs.h: Fix common/ includes.
13896 * nat/x86-dregs.c: Fix common/ includes.
13897 * nat/ppc-linux.c: Fix common/ includes.
13898 * nat/mips-linux-watch.h: Fix common/ includes.
13899 * nat/mips-linux-watch.c: Fix common/ includes.
13900 * nat/linux-waitpid.c: Fix common/ includes.
13901 * nat/linux-ptrace.h: Fix common/ includes.
13902 * nat/linux-ptrace.c: Fix common/ includes.
13903 * nat/linux-procfs.c: Fix common/ includes.
13904 * nat/linux-personality.c: Fix common/ includes.
13905 * nat/linux-osdata.c: Fix common/ includes.
13906 * nat/linux-namespaces.c: Fix common/ includes.
13907 * nat/linux-btrace.h: Fix common/ includes.
13908 * nat/linux-btrace.c: Fix common/ includes.
13909 * nat/fork-inferior.c: Fix common/ includes.
13910 * nat/amd64-linux-siginfo.c: Fix common/ includes.
13911 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
13912 * nat/aarch64-linux.c: Fix common/ includes.
13913 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
13914 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
13915 * namespace.h: Fix common/ includes.
13916 * mips-linux-tdep.c: Fix common/ includes.
13917 * minsyms.c: Fix common/ includes.
13918 * mi/mi-parse.h: Fix common/ includes.
13919 * mi/mi-main.c: Fix common/ includes.
13920 * mi/mi-cmd-env.c: Fix common/ includes.
13921 * memrange.h: Fix common/ includes.
13922 * memattr.c: Fix common/ includes.
13923 * maint.h: Fix common/ includes.
13924 * maint.c: Fix common/ includes.
13925 * main.c: Fix common/ includes.
13926 * machoread.c: Fix common/ includes.
13927 * location.c: Fix common/ includes.
13928 * linux-thread-db.c: Fix common/ includes.
13929 * linux-nat.c: Fix common/ includes.
13930 * linux-fork.c: Fix common/ includes.
13931 * inline-frame.c: Fix common/ includes.
13932 * infrun.c: Fix common/ includes.
13933 * inflow.c: Fix common/ includes.
13934 * inferior.h: Fix common/ includes.
13935 * inferior.c: Fix common/ includes.
13936 * infcmd.c: Fix common/ includes.
13937 * inf-ptrace.c: Fix common/ includes.
13938 * inf-child.c: Fix common/ includes.
13939 * ia64-linux-nat.c: Fix common/ includes.
13940 * i387-tdep.c: Fix common/ includes.
13941 * i386-tdep.c: Fix common/ includes.
13942 * i386-linux-tdep.c: Fix common/ includes.
13943 * i386-linux-nat.c: Fix common/ includes.
13944 * i386-go32-tdep.c: Fix common/ includes.
13945 * i386-fbsd-tdep.c: Fix common/ includes.
13946 * i386-fbsd-nat.c: Fix common/ includes.
13947 * guile/scm-type.c: Fix common/ includes.
13948 * guile/guile.c: Fix common/ includes.
13949 * go32-nat.c: Fix common/ includes.
13950 * gnu-nat.c: Fix common/ includes.
13951 * gdbthread.h: Fix common/ includes.
13952 * gdbarch-selftests.c: Fix common/ includes.
13953 * gdb_usleep.c: Fix common/ includes.
13954 * gdb_select.h: Fix common/ includes.
13955 * gdb_bfd.c: Fix common/ includes.
13956 * gcore.c: Fix common/ includes.
13957 * fork-child.c: Fix common/ includes.
13958 * findvar.c: Fix common/ includes.
13959 * fbsd-nat.c: Fix common/ includes.
13960 * event-top.c: Fix common/ includes.
13961 * event-loop.c: Fix common/ includes.
13962 * dwarf2read.c: Fix common/ includes.
13963 * dwarf2loc.c: Fix common/ includes.
13964 * dwarf2-frame.c: Fix common/ includes.
13965 * dwarf-index-cache.c: Fix common/ includes.
13966 * dtrace-probe.c: Fix common/ includes.
13967 * disasm-selftests.c: Fix common/ includes.
13968 * defs.h: Fix common/ includes.
13969 * csky-tdep.c: Fix common/ includes.
13970 * cp-valprint.c: Fix common/ includes.
13971 * cp-support.h: Fix common/ includes.
13972 * cp-support.c: Fix common/ includes.
13973 * corelow.c: Fix common/ includes.
13974 * completer.h: Fix common/ includes.
13975 * completer.c: Fix common/ includes.
13976 * compile/compile.c: Fix common/ includes.
13977 * compile/compile-loc2c.c: Fix common/ includes.
13978 * compile/compile-cplus-types.c: Fix common/ includes.
13979 * compile/compile-cplus-symbols.c: Fix common/ includes.
13980 * command.h: Fix common/ includes.
13981 * cli/cli-dump.c: Fix common/ includes.
13982 * cli/cli-cmds.c: Fix common/ includes.
13983 * charset.c: Fix common/ includes.
13984 * build-id.c: Fix common/ includes.
13985 * btrace.h: Fix common/ includes.
13986 * btrace.c: Fix common/ includes.
13987 * breakpoint.h: Fix common/ includes.
13988 * breakpoint.c: Fix common/ includes.
13989 * ax.h:
13990 (enum agent_op): Fix common/ includes.
13991 * ax-general.c (struct aop_map): Fix common/ includes.
13992 * ax-gdb.c: Fix common/ includes.
13993 * auxv.c: Fix common/ includes.
13994 * auto-load.c: Fix common/ includes.
13995 * arm-tdep.c: Fix common/ includes.
13996 * arch/riscv.c: Fix common/ includes.
13997 * arch/ppc-linux-common.c: Fix common/ includes.
13998 * arch/i386.c: Fix common/ includes.
13999 * arch/arm.c: Fix common/ includes.
14000 * arch/arm-linux.c: Fix common/ includes.
14001 * arch/arm-get-next-pcs.c: Fix common/ includes.
14002 * arch/amd64.c: Fix common/ includes.
14003 * arch/aarch64.c: Fix common/ includes.
14004 * arch/aarch64-insn.c: Fix common/ includes.
14005 * arch-utils.c: Fix common/ includes.
14006 * amd64-windows-tdep.c: Fix common/ includes.
14007 * amd64-tdep.c: Fix common/ includes.
14008 * amd64-sol2-tdep.c: Fix common/ includes.
14009 * amd64-obsd-tdep.c: Fix common/ includes.
14010 * amd64-nbsd-tdep.c: Fix common/ includes.
14011 * amd64-linux-tdep.c: Fix common/ includes.
14012 * amd64-linux-nat.c: Fix common/ includes.
14013 * amd64-fbsd-tdep.c: Fix common/ includes.
14014 * amd64-fbsd-nat.c: Fix common/ includes.
14015 * amd64-dicos-tdep.c: Fix common/ includes.
14016 * amd64-darwin-tdep.c: Fix common/ includes.
14017 * agent.c: Fix common/ includes.
14018 * ada-lang.h: Fix common/ includes.
14019 * ada-lang.c: Fix common/ includes.
14020 * aarch64-tdep.c: Fix common/ includes.
14021
14022 2019-01-25 Tom Tromey <tom@tromey.com>
14023
14024 * common/create-version.sh: Use common/version.h.
14025
14026 2019-01-24 Pedro Alves <palves@redhat.com>
14027
14028 * infrun.c (signal_stop, signal_print, signal_program)
14029 (signal_catch, signal_pass): Now arrays instead of pointers.
14030 (update_signals_program_target, do_target_resume)
14031 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14032 * linux-nat.c (linux_nat_target::pass_signals)
14033 (linux_nat_target::create_inferior, linux_nat_target::attach):
14034 Adjust.
14035 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14036 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14037 * procfs.c (procfs_target::pass_signals): Adjust.
14038 * record-full.c (record_full_target::resume): Adjust.
14039 * remote.c (remote_target::pass_signals)
14040 (remote_target::program_signals): Adjust.
14041 * target-debug.h (target_debug_print_signals): Now takes a
14042 gdb::array_view as parameter. Adjust.
14043 * target.h (target_ops) <pass_signals, program_signals>: Replace
14044 pointer and length parameters with gdb::array_view.
14045 (target_pass_signals, target_program_signals): Likewise.
14046 * target-delegates.c: Regenerate.
14047
14048 2019-01-24 Pedro Alves <palves@redhat.com>
14049
14050 * common/forward-scope-exit.h
14051 (forward_scope_exit::forward_scope_exit): Pass arguments to
14052 m_bind_function directly, instead of creating a std::bind and
14053 copying that.
14054
14055 2019-01-24 Alan Hayward <alan.hayward@arm.com>
14056
14057 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14058 for static members.
14059 (pass_in_v_vfp_candidate): Likewise.
14060
14061 2019-01-23 Tom Tromey <tom@tromey.com>
14062 Pedro Alves <palves@redhat.com>
14063
14064 * regcache.c (class regcache_invalidator): Remove.
14065 (regcache::raw_write): Use make_scope_exit.
14066
14067 2019-01-23 Tom Tromey <tom@tromey.com>
14068
14069 * ui-out.h (class ui_out_emit_type): Update comment.
14070
14071 2019-01-23 Tom Tromey <tom@tromey.com>
14072
14073 * infrun.c (fetch_inferior_event): Update comment.
14074
14075 2019-01-23 Tom Tromey <tom@tromey.com>
14076 Pedro Alves <palves@redhat.com>
14077
14078 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14079 parameter.
14080 (fetch_inferior_event): Use SCOPE_EXIT.
14081
14082
14083 2019-01-23 Tom Tromey <tom@tromey.com>
14084 Pedro Alves <palves@redhat.com>
14085
14086 * infrun.c (disable_thread_events): Delete.
14087 (stop_all_threads): Use SCOPE_EXIT.
14088
14089 2019-01-23 Tom Tromey <tom@tromey.com>
14090 Pedro Alves <palves@redhat.com>
14091
14092 * symfile.c: Include forward-scope-exit.h.
14093 (clear_symtab_users_cleanup): Replace forward declaration with
14094 a FORWARD_SCOPE_EXIT.
14095 (syms_from_objfile_1): Use the forward_scope_exit and
14096 gdb::optional instead of cleanup_function.
14097 (reread_symbols): Use the forward_scope_exit instead of
14098 cleanup_function.
14099 (clear_symtab_users_cleanup): Remove function.
14100
14101 2019-01-23 Tom Tromey <tom@tromey.com>
14102 Pedro Alves <palves@redhat.com>
14103
14104 * linux-nat.c: Include scope-exit.h.
14105 (cleanup_target_stop): Remove.
14106 (linux_nat_target::static_tracepoint_markers_by_strid): Use
14107 SCOPE_EXIT.
14108
14109 2019-01-23 Tom Tromey <tom@tromey.com>
14110 Pedro Alves <palves@redhat.com>
14111
14112 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14113 (call_function_by_hand_dummy): Use SCOPE_EXIT.
14114
14115 2019-01-23 Tom Tromey <tom@tromey.com>
14116 Andrew Burgess <andrew.burgess@embecosm.com>
14117 Pedro Alves <palves@redhat.com>
14118
14119 * infrun.c (fetch_inferior_event): Use scope_exit.
14120 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14121 * top.c (execute_command): Use scope_exit.
14122 * breakpoint.c (bpstat_do_actions): Use scope_exit.
14123 * utils.c (do_bpstat_clear_actions_cleanup)
14124 (make_bpstat_clear_actions_cleanup): Remove.
14125
14126 2019-01-23 Tom Tromey <tom@tromey.com>
14127 Pedro Alves <palves@redhat.com>
14128
14129 * infrun.c: Include "common/scope-exit.h"
14130 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14131 (wait_for_inferior): Use SCOPE_EXIT.
14132 (fetch_inferior_event): Use scope_exit.
14133
14134 2019-01-23 Tom Tromey <tom@tromey.com>
14135 Pedro Alves <palves@redhat.com>
14136
14137 * breakpoint.c (create_breakpoint): Remove cleanup.
14138
14139 2019-01-23 Tom Tromey <tom@tromey.com>
14140 Andrew Burgess <andrew.burgess@embecosm.com>
14141 Pedro Alves <palves@redhat.com>
14142
14143 2019-01-23 Pedro Alves <palves@redhat.com>
14144
14145 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14146
14147 2019-01-23 Pedro Alves <palves@redhat.com>
14148 Andrew Burgess <andrew.burgess@embecosm.com>
14149
14150 * gdbthread.h: Include "common/forward-scope-exit.h".
14151 (scoped_finish_thread_state): Redefine custom class in terms of
14152 forward_scope_exit.
14153
14154 2019-01-23 Pedro Alves <palves@redhat.com>
14155 Andrew Burgess <andrew.burgess@embecosm.com>
14156
14157 * common/forward-scope-exit.h: New file.
14158
14159 2019-01-23 Pedro Alves <palves@redhat.com>
14160 Andrew Burgess <andrew.burgess@embecosm.com>
14161 Tom Tromey <tom@tromey.com>
14162
14163 * common/scope-exit.h: New file.
14164
14165 2019-01-23 Pedro Alves <palves@redhat.com>
14166
14167 * common/preprocessor.h (ESC): Rename to ...
14168 (ESC_PARENS): ... this.
14169 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14170 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14171
14172 2019-01-23 Tom Tromey <tom@tromey.com>
14173
14174 * language.h (class scoped_switch_to_sym_language_if_auto):
14175 Initialize m_lang in both cases.
14176
14177 2019-01-23 Alan Hayward <alan.hayward@arm.com>
14178
14179 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14180 with XCNEW.
14181
14182 2019-01-22 Tom Tromey <tom@tromey.com>
14183
14184 * corelow.c: Do not include sys/file.h.
14185
14186 2019-01-22 Tom Tromey <tom@tromey.com>
14187
14188 * tui/tui-wingeneral.h: Include gdb_curses.h.
14189
14190 2019-01-22 Tom Tromey <tom@tromey.com>
14191
14192 * source-cache.h (class source_cache) <get_source_lines,
14193 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14194
14195 2019-01-22 Tom Tromey <tom@tromey.com>
14196
14197 * remote-fileio.h (struct remote_target): Declare.
14198
14199 2019-01-22 Tom Tromey <tom@tromey.com>
14200
14201 * python/py-arch.c: Do not include py-ref.h.
14202 * python/py-bpevent.c: Do not include py-ref.h.
14203 * python/py-cmd.c: Do not include py-ref.h.
14204 * python/py-continueevent.c: Do not include py-ref.h.
14205 * python/py-event.h: Do not include py-ref.h.
14206 * python/py-evtregistry.c: Do not include py-ref.h.
14207 * python/py-finishbreakpoint.c: Do not include py-ref.h.
14208 * python/py-frame.c: Do not include py-ref.h.
14209 * python/py-framefilter.c: Do not include py-ref.h.
14210 * python/py-function.c: Do not include py-ref.h.
14211 * python/py-infevents.c: Do not include py-ref.h.
14212 * python/py-linetable.c: Do not include py-ref.h.
14213 * python/py-objfile.c: Do not include py-ref.h.
14214 * python/py-param.c: Do not include py-ref.h.
14215 * python/py-prettyprint.c: Do not include py-ref.h.
14216 * python/py-progspace.c: Do not include py-ref.h.
14217 * python/py-symbol.c: Do not include py-ref.h.
14218 * python/py-symtab.c: Do not include py-ref.h.
14219 * python/py-type.c: Do not include py-ref.h.
14220 * python/py-unwind.c: Do not include py-ref.h.
14221 * python/py-utils.c: Do not include py-ref.h.
14222 * python/py-value.c: Do not include py-ref.h.
14223 * python/py-varobj.c: Do not include py-ref.h.
14224 * python/py-xmethods.c: Do not include py-ref.h.
14225 * python/python.c: Do not include py-ref.h.
14226 * varobj.c: Do not include py-ref.h.
14227
14228 2019-01-22 Tom Tromey <tom@tromey.com>
14229
14230 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14231 keyword for bcache.
14232
14233 2019-01-22 Tom Tromey <tom@tromey.com>
14234
14235 * compile/compile-cplus-types.c: Remove a comment by #include.
14236
14237 2019-01-22 Tom Tromey <tom@tromey.com>
14238
14239 * compile/gcc-c-plugin.h: Include compile-internal.h.
14240
14241 2019-01-22 Tom Tromey <tom@tromey.com>
14242
14243 * stabsread.c (EXTERN): Do not define.
14244 (symnum, next_symbol_text_func, processing_gcc_compilation)
14245 (within_function, global_sym_chain, global_stabs)
14246 (previous_stab_code, this_object_header_files)
14247 (n_this_object_header_files)
14248 (n_allocated_this_object_header_files): Define.
14249 * stabsread.h (EXTERN): Never define. Use "extern".
14250
14251 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14252
14253 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14254 history_value.
14255
14256 2019-01-21 Tom Tromey <tom@tromey.com>
14257
14258 * ui-out.c: Fix includes.
14259 * tui/tui-source.c: Fix includes.
14260 * target.c: Fix includes.
14261 * remote.c: Fix includes.
14262 * regcache.c: Fix includes.
14263 * python/py-block.c: Fix includes.
14264 * printcmd.c: Fix includes.
14265 * or1k-tdep.c: Fix includes.
14266 * mi/mi-main.c: Fix includes.
14267 * m32r-tdep.c: Fix includes.
14268 * csky-tdep.c: Fix includes.
14269 * compile/compile-cplus-types.c: Fix includes.
14270 * cli/cli-interp.c: Fix includes.
14271
14272 2019-01-21 Alan Hayward <alan.hayward@arm.com>
14273
14274 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14275 for padding.
14276
14277 2019-01-16 Tom Tromey <tom@tromey.com>
14278
14279 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
14280 earlier.
14281 (struct objfile) <msymbols_range>: Move from top level.
14282 <msymbols>: New method.
14283 (class objfile_msymbols): Remove.
14284 * symtab.c (default_collect_symbol_completion_matches_break_on):
14285 Update.
14286 * symmisc.c (dump_msymbols): Update.
14287 * stabsread.c (scan_file_globals): Update.
14288 * objc-lang.c (info_selectors_command, info_classes_command)
14289 (find_methods): Update.
14290 * minsyms.c (find_solib_trampoline_target): Update.
14291 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14292 * coffread.c (coff_symfile_read): Update.
14293 * ada-lang.c (ada_lookup_simple_minsym)
14294 (ada_collect_symbol_completion_matches): Update.
14295
14296 2019-01-16 Tom Tromey <tom@tromey.com>
14297
14298 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14299 type. Remove no-argument constructor.
14300 <iterator::operator++>: Simplify.
14301 <begin>: Update.
14302 <end>: Use minimal_symbol_count.
14303
14304 2019-01-16 Tom Tromey <tom@tromey.com>
14305
14306 * objfiles.h (struct objfile) <psymtabs>: New method.
14307 (class objfile_psymtabs): Remove.
14308 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14309 typedef.
14310 <range>: New method.
14311 (require_partial_symbols): Change return type.
14312 * psymtab.c (require_partial_symbols)
14313 (psym_expand_symtabs_matching): Update.
14314 * mdebugread.c (parse_partial_symbols): Update.
14315 * dbxread.c (dbx_end_psymtab): Update.
14316
14317 2019-01-15 Tom Tromey <tom@tromey.com>
14318
14319 * symtab.c (lookup_objfile_from_block)
14320 (lookup_symbol_in_objfile_symtabs)
14321 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14322 (find_line_symtab, info_sources_command)
14323 (default_collect_symbol_completion_matches_break_on)
14324 (make_source_files_completion_list): Update.
14325 * symmisc.c (print_objfile_statistics, dump_objfile)
14326 (maintenance_print_symbols, maintenance_info_symtabs)
14327 (maintenance_check_symtabs, maintenance_info_line_tables):
14328 Update.
14329 * source.c (select_source_symtab)
14330 (forget_cached_source_info_for_objfile): Update.
14331 * objfiles.h (class objfile_compunits): Remove.
14332 (struct objfile) <compunits_range>: New typedef.
14333 (compunits): New method.
14334 * objfiles.c (objfile_relocate1): Update.
14335 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14336 * maint.c (count_symtabs_and_blocks): Update.
14337 * linespec.c (iterate_over_all_matching_symtabs): Update.
14338 * cp-support.c (add_symbol_overload_list_qualified): Update.
14339 * coffread.c (coff_symtab_read): Update.
14340 * ada-lang.c (add_nonlocal_symbols)
14341 (ada_collect_symbol_completion_matches)
14342 (ada_add_global_exceptions): Update.
14343
14344 2019-01-15 Tom Tromey <tom@tromey.com>
14345
14346 * progspace.h (program_space) <objfiles_safe_range>: New
14347 typedef.
14348 <objfiles_safe>: New method.
14349 * objfiles.h (class all_objfiles_safe): Remove.
14350 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14351 * jit.c (jit_inferior_exit_hook): Update.
14352
14353 2019-01-17 Tom Tromey <tom@tromey.com>
14354
14355 * progspace.h (program_space) <objfiles_range>: New typedef.
14356 <objfiles>: New method.
14357 <objfiles_head>: Rename from objfiles.
14358 (object_files): Update.
14359 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14360 * guile/scm-pretty-print.c
14361 (ppscm_find_pretty_printer_from_objfiles): Update.
14362 * guile/scm-objfile.c (gdbscm_objfiles): Update.
14363 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14364 Update.
14365 * python/py-progspace.c (pspy_get_objfiles): Update.
14366 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14367 Update.
14368 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14369 (objfpy_lookup_objfile_by_build_id): Update.
14370 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14371 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14372 Update.
14373 * symtab.c (iterate_over_symtabs, matching_obj_sections)
14374 (expand_symtab_containing_pc, lookup_objfile_from_block)
14375 (lookup_static_symbol, basic_lookup_transparent_type)
14376 (find_pc_sect_compunit_symtab, find_symbol_at_address)
14377 (find_line_symtab, info_sources_command)
14378 (default_collect_symbol_completion_matches_break_on)
14379 (make_source_files_completion_list, find_main_name): Update.
14380 * symmisc.c (print_symbol_bcache_statistics)
14381 (print_objfile_statistics, maintenance_print_symbols)
14382 (maintenance_print_msymbols, maintenance_print_objfiles)
14383 (maintenance_info_symtabs, maintenance_check_symtabs)
14384 (maintenance_expand_symtabs, maintenance_info_line_tables):
14385 Update.
14386 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14387 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14388 (map_overlay_command, unmap_overlay_command)
14389 (simple_overlay_update, expand_symtabs_matching)
14390 (map_symbol_filenames): Update.
14391 * symfile-debug.c (set_debug_symfile): Update.
14392 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14393 Update.
14394 * source.c (select_source_symtab, forget_cached_source_info):
14395 Update.
14396 * solib.c (solib_read_symbols): Update.
14397 * solib-spu.c (append_ocl_sos): Update.
14398 * psymtab.c (maintenance_print_psymbols)
14399 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14400 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14401 * printcmd.c (info_symbol_command): Update.
14402 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14403 Update.
14404 * objfiles.h (class all_objfiles): Remove.
14405 * objfiles.c (have_partial_symbols, have_full_symbols)
14406 (have_minimal_symbols, qsort_cmp, update_section_map)
14407 (shared_objfile_contains_address_p)
14408 (default_iterate_over_objfiles_in_search_order): Update.
14409 * objc-lang.c (info_selectors_command, info_classes_command)
14410 (find_methods): Update.
14411 * minsyms.c (find_solib_trampoline_target): Update.
14412 * maint.c (maintenance_info_sections)
14413 (maintenance_translate_address, count_symtabs_and_blocks):
14414 Update.
14415 * main.c (captured_main_1): Update.
14416 * linux-thread-db.c (try_thread_db_load_from_pdir)
14417 (has_libpthread): Update.
14418 * linespec.c (iterate_over_all_matching_symtabs)
14419 (search_minsyms_for_name): Update.
14420 * jit.c (jit_find_objf_with_entry_addr): Update.
14421 * hppa-tdep.c (find_unwind_entry)
14422 (hppa_lookup_stub_minimal_symbol): Update.
14423 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
14424 Update.
14425 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14426 (elf_gnu_ifunc_resolve_by_got): Update.
14427 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
14428 * dwarf-index-write.c (save_gdb_index_command): Update.
14429 * cp-support.c (add_symbol_overload_list_qualified): Update.
14430 * breakpoint.c (create_overlay_event_breakpoint)
14431 (create_longjmp_master_breakpoint)
14432 (create_std_terminate_master_breakpoint)
14433 (create_exception_master_breakpoint): Update.
14434 * blockframe.c (find_pc_partial_function): Update.
14435 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
14436 (ada_collect_symbol_completion_matches)
14437 (ada_add_global_exceptions): Update.
14438
14439 2019-01-17 Tom Tromey <tom@tromey.com>
14440
14441 * solib-target.c (lm_info_target_p): Remove typedef. Don't
14442 declare VEC.
14443 (solib_target_parse_libraries): Change return type.
14444 (library_list_start_segment, library_list_start_section)
14445 (library_list_end_library, library_list_start_library); Update.
14446 (solib_target_free_library_list): Remove.
14447 (solib_target_parse_libraries): Remove cleanup. Change return
14448 type.
14449 (solib_target_current_sos): Update.
14450
14451 2019-01-17 Tom Tromey <tromey@bapiya>
14452
14453 * valprint.c: Replace "the the" with "the".
14454 * symtab.c: Replace "the the" with "the".
14455 * solib.c: Replace "the the" with "the".
14456 * solib-dsbt.c: Replace "the the" with "the".
14457 * linespec.c: Replace "the the" with "the".
14458 * dwarf2loc.h: Replace "the the" with "the".
14459 * amd64-windows-tdep.c: Replace "the the" with "the".
14460 * aarch64-tdep.c: Replace "the the" with "the".
14461
14462 2019-01-16 Keith Seitz <keiths@redhat.com>
14463
14464 PR gdb/23773
14465 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
14466 <builder>: Rename to ..
14467 <m_builder>: ... this and make private.
14468 (dwarf2_cu::get_builder): New method. Change all users of
14469 `builder' to use this method.
14470 (dwarf2_start_symtab): Move to ...
14471 (dwarf2_cu::start_symtab): ... here. Update all callers
14472 (setup_type_unit_groups): Move to ...
14473 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
14474 callers.
14475 (dwarf2_cu::reset_builder): New method.
14476 (process_full_compunit, process_full_type_unit): Use
14477 dwarf2_cu::reset_builder.
14478 (follow_die_offset): Record the ancestor CU if it is different
14479 from the followed DIE's CU.
14480 (follow_die_sig_1): Likewise.
14481
14482 2019-01-15 Tom Tromey <tom@tromey.com>
14483
14484 * remote.c (class remote_state) <buf>: Now a char_vector.
14485 <buf_size>: Remove.
14486 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
14487 parameter.
14488 (remote_target::getpkt_or_notif_sane_1)
14489 (remote_target::getpkt_sane)
14490 (remote_target::getpkt_or_notif_sane): Likewise.
14491 (class remote_target) <putpkt>: New overload.
14492 (remote_target::read_frame): Change type of "buf_p". Remove
14493 sizeof_p parameter.
14494 (packet_ok): New overload.
14495 (packet_check_result): New overload.
14496 Update all uses.
14497
14498 2019-01-14 Tom Tromey <tom@tromey.com>
14499
14500 * remote-notif.c (handle_notification, remote_notif_ack)
14501 (remote_notif_parse): Make "buf" const.
14502 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
14503 const.
14504 (remote_notif_parse, remote_notif_ack, handle_notification):
14505 Likewise.
14506 * remote.c (remote_notif_stop_parse): Make "buf" const.
14507 (remote_target::remote_parse_stop_reply): Make "buf" const.
14508 (remote_notif_stop_ack): Make "buf" const.
14509
14510 2019-01-14 Tom Tromey <tom@tromey.com>
14511
14512 * remote.c (remote_console_output): Make parameter const.
14513
14514 2019-01-14 Tom Tromey <tom@tromey.com>
14515
14516 * target-debug.h (target_debug_print_signals): Constify.
14517 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
14518 * procfs.c (procfs_target::pass_signals): Update.
14519 * linux-nat.c (linux_nat_target::pass_signals): Update.
14520 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
14521 * target-delegates.c: Rebuild.
14522 * remote.c (remote_target::program_signals): Update.
14523 (remote_target::pass_signals): Update.
14524 * target.c (target_pass_signals): Constify argument.
14525 (target_program_signals): Likewise.
14526 * target.h (struct target_ops) <pass_signals, program_signals>:
14527 Constify argument.
14528 (target_pass_signals, target_program_signals): Constify argument.
14529
14530 2019-01-14 Tom Tromey <tom@tromey.com>
14531
14532 PR tui/28819:
14533 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
14534
14535 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
14536
14537 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
14538 field.
14539 * rs6000-tdep.c: Include reggroups.h.
14540 (IS_V_ALIAS_PSEUDOREG): Define.
14541 (rs6000_register_name): Return names for the "vX" aliases.
14542 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
14543 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
14544 aliases. Call default_register_reggroup_p for all other
14545 pseudo-registers.
14546 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
14547 New functions.
14548 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
14549 Handle "vX" aliases.
14550 (v_alias_pseudo_register_collect): New function.
14551 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
14552 (rs6000_gdbarch_init): Initialize "vX" aliases as
14553 pseudo-registers. Restore registration of
14554 rs6000_pseudo_register_reggroup_p with
14555 set_tdesc_pseudo_register_reggroup_p.
14556
14557 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
14558
14559 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
14560 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
14561 set_gdbarch_num_pseudo_regs.
14562
14563 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14564
14565 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
14566 Remove arg prefixname, add do_set and do_show.
14567 Add member functions set_list and show_list.
14568 * cli/cli-style.c (class cli_style_option): Update accordingly.
14569 (style_set_list): Move to file scope.
14570 (style_show_list): Likewise.
14571 (set_style): Call help_list.
14572 (show_style): Call cmd_show_list.
14573 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
14574 Update to use the new macro.
14575
14576 2019-10-12 Joel Brobecker <brobecker@adacore.com>
14577
14578 * ada-lang.c (_initialize_ada_language): Expand the help text
14579 for the "catch exception" command.
14580
14581 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14582
14583 * symtab.c (matching_obj_sections): Initialize obj,
14584 declare it closer to its usage.
14585
14586 2019-01-10 Tom Tromey <tom@tromey.com>
14587
14588 * thread-iter.h (inf_threads_iterator): Use next_iterator.
14589 (basic_inf_threads_range): Remove.
14590 (inf_threads_range, inf_non_exited_threads_range)
14591 (safe_inf_threads_range): Use next_adapter.
14592
14593 2019-01-10 Keith Seitz <keiths@redhat.com>
14594
14595 PR gdb/23712
14596 PR symtab/23010
14597 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
14598 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
14599
14600 2019-01-10 Keith Seitz <keiths@redhat.com>
14601
14602 PR gdb/23712
14603 PR symtab/23010
14604 * dictionary.c (pending_to_vector): Remove.
14605 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14606 Remove _1 suffix, replacing functions of the same name. Update
14607 all callers.
14608 (dict_create_hashed, dict_create_hashed_expandable)
14609 (dict_create_linear, dict_create_linear_expandable, dict_free)
14610 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
14611 Make functions static.
14612
14613 2019-01-10 Keith Seitz <keiths@redhat.com>
14614
14615 PR gdb/23712
14616 PR symtab/23010
14617 * dictionary.h (struct dictionary): Replace declaration with
14618 multidictionary.
14619 (dict_create_hashed, dict_create_hashed_expandable)
14620 (dict_create_linear, dict_create_linear_expandable)
14621 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
14622 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
14623 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
14624 taking multidictionary argument.
14625 [ALL_DICT_SYMBOLS]: Update for multidictionary.
14626 * block.h (struct block) <dict>: Change to multidictionary
14627 and rename `multidict'.
14628 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
14629 symmisc.c: Update all dictionary references to multidictionary.
14630
14631 2019-01-10 Keith Seitz <keiths@redhat.com>
14632
14633 PR gdb/23712
14634 PR symtab/23010
14635 * dictionary.c: Include unordered_map.
14636 (pending_to_vector): New function.
14637 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
14638 Rewrite the non-"_1" functions to take vector instead
14639 of linked list.
14640 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
14641 "new" _1 versions of the same name.
14642 (multidictionary): Define.
14643 (std::hash<enum language): New definition.
14644 (collate_pending_symbols_by_language, mdict_create_hashed)
14645 (mdict_create_hashed_expandable, mdict_create_linear)
14646 (mdict_create_linear_expandable, mdict_free)
14647 (find_language_dictionary, create_new_language_dictionary)
14648 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
14649 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
14650 (mdict_size, mdict_empty): New functions.
14651 * dictionary.h (mdict_iterator): Define.
14652
14653 2019-01-10 Pedro Alves <palves@redhat.com>
14654
14655 * breakpoint.c (read_uploaded_action)
14656 (create_tracepoint_from_upload): Adjust to use
14657 gdb::unique_xmalloc_ptr.
14658 * ctf.c (ctf_write_uploaded_tp):
14659 (SET_ARRAY_FIELD): Use emplace_back.
14660 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
14661 * tracefile-tfile.c (tfile_write_uploaded_tp):
14662 * tracepoint.c (parse_tracepoint_definition): Adjust to use
14663 gdb::unique_xmalloc_ptr.
14664 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
14665 at_string, cond_string, cmd_strings>: Replace char pointers
14666 with gdb::unique_xmalloc_ptr.
14667
14668 2019-01-10 Pedro Alves <palves@redhat.com>
14669
14670 * solib-target.c (library_list_start_library): Don't xstrdup name.
14671
14672 2019-01-10 Pedro Alves <palves@redhat.com>
14673
14674 * mdebugread.c (parse_partial_symbols): Use
14675 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
14676
14677 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
14678
14679 * linux-fork.c (scoped_switch_fork_info)
14680 <~scoped_switch_fork_info>: Fix incorrect variable name.
14681
14682 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
14683
14684 * linux-fork.c (scoped_switch_fork_info)
14685 <scoped_switch_fork_info>: Make explicit.
14686 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
14687
14688 2019-01-10 Tom Tromey <tom@tromey.com>
14689
14690 * objfiles.h (objfile::reset_psymtabs): Update.
14691 * objfiles.c (objfile::objfile): Update.
14692 * psymtab.h (psymtab_storage::obstack): Update.
14693 (psymtab_storage::m_obstack): Use gdb::optional.
14694 (class psymtab_storage): Update comment. Remove objfile
14695 parameter.
14696 * psymtab.c (psymtab_storage::psymtab_storage): Update.
14697
14698 2019-01-10 Tom Tromey <tom@tromey.com>
14699
14700 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
14701 <free_psymtabs>: Now private.
14702 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
14703 (allocate_psymtab): Use new method.
14704
14705 2019-01-10 Tom Tromey <tom@tromey.com>
14706
14707 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
14708 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
14709 * mdebugread.c (parse_partial_symbols): Use
14710 allocate_dependencies.
14711 * dwarf2read.c (dwarf2_create_include_psymtab): Use
14712 allocate_dependencies.
14713 (process_psymtab_comp_unit_reader)
14714 (build_type_psymtab_dependencies): Likewise.
14715 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
14716
14717 2019-01-10 Tom Tromey <tom@tromey.com>
14718
14719 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
14720 PSYMBOL_SET_LANGUAGE.
14721 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
14722
14723 2019-01-10 Tom Tromey <tom@tromey.com>
14724
14725 * psymtab.h (psymtab_storage::obstack): New method.
14726 <m_obstack>: Rename from obstack; now private.
14727 * psymtab.c (psymtab_storage): Update.
14728 * dwarf2read.c (create_addrmap_from_index)
14729 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
14730 Update.
14731
14732 2019-01-10 Tom Tromey <tom@tromey.com>
14733
14734 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
14735 * objfiles.h (objfile::reset_psymtabs): New method.
14736
14737 2019-01-10 Tom Tromey <tom@tromey.com>
14738
14739 * symmisc.c (print_symbol_bcache_statistics): Update.
14740 (print_objfile_statistics): Update.
14741 * symfile.c (reread_symbols): Update.
14742 * psymtab.h (class psymtab_storage): New.
14743 * psymtab.c (psymtab_storage): New constructor.
14744 (~psymtab_storage): New destructor.
14745 (require_partial_symbols): Update.
14746 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
14747 (find_pc_sect_psymtab, find_pc_sect_psymbol)
14748 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
14749 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
14750 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
14751 (start_psymtab_common, end_psymtab_common)
14752 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
14753 (allocate_psymtab): Update.
14754 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
14755 Update.
14756 (dump_psymtab_addrmap, maintenance_print_psymbols)
14757 (maintenance_check_psymtabs): Update.
14758 (class objfile_psymtabs): Move to objfiles.h.
14759 * psympriv.h (discard_psymtab): Now inline.
14760 (psymtab_discarder::psymtab_discarder): Update.
14761 (psymtab_discarder::~psymtab_discarder): Update.
14762 (ALL_OBJFILE_PSYMTABS): Rewrite.
14763 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
14764 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
14765 Remove fields.
14766 <partial_symtabs>: New field.
14767 (class objfile_psymtabs): Move from psymtab.h. Update.
14768 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
14769 psymbol_cache.
14770 (objfile::~objfile): Don't destroy psymbol_cache.
14771 * mdebugread.c (parse_partial_symbols): Update.
14772 * dwarf2read.c (create_addrmap_from_index)
14773 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
14774 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
14775 (add_partial_subprogram, dwarf2_ranges_read): Update.
14776 * dwarf-index-write.c (write_address_map)
14777 (write_one_signatured_type, recursively_write_psymbols)
14778 (class debug_names, class debug_names, write_psymtabs_to_index):
14779 Update.
14780
14781 2019-01-10 Tom Tromey <tom@tromey.com>
14782
14783 * symtab.h (SYMBOL_SET_NAMES): Update.
14784 (symbol_set_names): Update.
14785 (MSYMBOL_SET_NAMES): Update.
14786 * symtab.c (symbol_set_names): Change argument to be an
14787 objfile_per_bfd_storage.
14788 * psymtab.c (add_psymbol_to_bcache): Update.
14789 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
14790
14791 2019-01-10 Tom Tromey <tom@tromey.com>
14792
14793 * symtab.c (create_demangled_names_hash): Change argument to be an
14794 objfile_per_bfd_storage.
14795 (symbol_set_names): Update.
14796
14797 2019-01-10 Tom Tromey <tom@tromey.com>
14798
14799 * xcoffread.c (xcoff_initial_scan): Unconditionally call
14800 init_psymbol_list.
14801 * psymtab.c (init_psymbol_list): Do nothing if already called.
14802 * psympriv.h (init_psymbol_list): Add comment.
14803 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
14804 init_psymbol_list.
14805 * dbxread.c (dbx_symfile_read): Unconditionally call
14806 init_psymbol_list.
14807
14808 2019-01-10 Tom Tromey <tom@tromey.com>
14809
14810 * xcoffread.c (scan_xcoff_symtab): Update.
14811 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
14812 "where".
14813 * mdebugread.c (parse_partial_symbols)
14814 (handle_psymbol_enumerators): Update.
14815 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
14816 * dbxread.c (read_dbx_symtab): Update.
14817 * psympriv.h (psymbol_placement): New enum.
14818 (add_psymbol_to_list): Update.
14819
14820 2019-01-10 Tom Tromey <tom@tromey.com>
14821
14822 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
14823 static_psymbols parameters.
14824 (scan_xcoff_symtab): Update.
14825 * psymtab.c (start_psymtab_common): Remove global_psymbols and
14826 static_psymbols parameters.
14827 * psympriv.h (start_psymtab_common): Update.
14828 * mdebugread.c (parse_partial_symbols): Update.
14829 * dwarf2read.c (create_partial_symtab): Update.
14830 * dbxread.c (read_dbx_symtab): Update.
14831 (start_psymtab): Remove global_psymbols and static_psymbols
14832 parameters.
14833
14834 2019-01-10 Tom Tromey <tom@tromey.com>
14835
14836 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
14837 * psymtab.c (allocate_psymtab): Add comment.
14838 * psympriv.h (allocate_psymtab): Add comment.
14839 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
14840 initializations.
14841 * dbxread.c (dbx_end_psymtab): Remove some initializations.
14842
14843 2019-01-10 Tom Tromey <tom@tromey.com>
14844
14845 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14846 Don't declare.
14847 * mipsread.c: Include mdebugread.h.
14848 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
14849 Declare.
14850 * elfread.c: Include mdebugread.h.
14851
14852 2019-01-09 Tom Tromey <tom@tromey.com>
14853
14854 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
14855 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
14856 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
14857 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
14858 (psym_lookup_symbol, psym_find_last_source_symtab)
14859 (psym_forget_cached_source_info, psym_print_stats)
14860 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
14861 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
14862 (psym_map_matching_symbols, psym_expand_symtabs_matching)
14863 (psym_find_compunit_symtab_by_address)
14864 (maintenance_print_psymbols, maintenance_info_psymtabs)
14865 (maintenance_check_psymtabs): Use ranged for.
14866 * psymtab.h (class objfile_psymtabs): New.
14867 (require_partial_symbols): Return objfile_psymtabs.
14868 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
14869
14870 2019-01-09 Tom Tromey <tom@tromey.com>
14871
14872 * symfile.c (overlay_invalidate_all, find_pc_overlay)
14873 (find_pc_mapped_section, list_overlays_command)
14874 (map_overlay_command, unmap_overlay_command)
14875 (simple_overlay_update): Use all_objfiles.
14876 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
14877 * printcmd.c (info_symbol_command): Use all_objfiles.
14878 * objfiles.h (ALL_OBJSECTIONS): Remove.
14879 * maint.c (maintenance_translate_address): Use all_objfiles.
14880 * gcore.c (gcore_create_callback): Use all_objfiles.
14881 (objfile_find_memory_regions): Likewise.
14882
14883 2019-01-09 Tom Tromey <tom@tromey.com>
14884
14885 * symtab.c (find_line_symtab, info_sources_command)
14886 (make_source_files_completion_list): Use objfile_compunits.
14887 * source.c (select_source_symtab): Use objfile_compunits.
14888 * objfiles.h (struct objfile): Update comment.
14889 (ALL_OBJFILES): Remove.
14890 (ALL_FILETABS): Remove.
14891 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
14892 objfile_compunits.
14893
14894 2019-01-09 Tom Tromey <tom@tromey.com>
14895
14896 * symmisc.c (print_objfile_statistics, dump_objfile)
14897 (maintenance_print_symbols): Use compunit_filetabs.
14898 * source.c (forget_cached_source_info_for_objfile): Use
14899 compunit_filetabs.
14900 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
14901 (ALL_FILETABS): Use compunit_filetabs.
14902 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
14903 * coffread.c (coff_symtab_read): Use compunit_filetabs.
14904
14905 2019-01-09 Tom Tromey <tom@tromey.com>
14906
14907 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
14908 (compunit_filetabs): New.
14909 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
14910 compunit_filetabs.
14911 (info_sources_command, make_source_files_completion_list): Remove
14912 declaration.
14913 * symmisc.c (print_objfile_statistics, dump_objfile)
14914 (maintenance_print_symbols): Remove declaration.
14915 (maintenance_info_symtabs): Use compunit_filetabs.
14916 (maintenance_info_line_tables): Likewise.
14917 * source.c (select_source_symtab): Change local variable name.
14918 (forget_cached_source_info_for_objfile): Remove declaration.
14919 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
14920 * objfiles.c (objfile_relocate1): Remove declaration.
14921 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14922 declaration.
14923 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
14924 * coffread.c (coff_symtab_read): Remove declaration.
14925 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
14926 compunit_filetabs.
14927
14928 2019-01-09 Tom Tromey <tom@tromey.com>
14929
14930 * symtab.c (lookup_objfile_from_block)
14931 (find_pc_sect_compunit_symtab, search_symbols)
14932 (default_collect_symbol_completion_matches_break_on): Use
14933 objfile_compunits.
14934 * objfiles.h (ALL_COMPUNITS): Remove.
14935 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
14936 * cp-support.c (add_symbol_overload_list_qualified): Use
14937 objfile_compunits.
14938 * ada-lang.c (ada_collect_symbol_completion_matches)
14939 (ada_add_global_exceptions): Use objfile_compunits.
14940
14941 2019-01-09 Tom Tromey <tom@tromey.com>
14942
14943 * source.c (select_source_symtab)
14944 (forget_cached_source_info_for_objfile): Remove declaration.
14945 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
14946 declaration.
14947 * maint.c (count_symtabs_and_blocks): Remove declaration.
14948 * cp-support.c (add_symbol_overload_list_qualified): Remove
14949 declaration.
14950 * coffread.c (coff_symtab_read): Remove declaration.
14951 * symtab.c (lookup_symbol_in_objfile_symtabs)
14952 (basic_lookup_transparent_type_1): Use objfile_compunits.
14953 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
14954 (info_sources_command, search_symbols)
14955 (default_collect_symbol_completion_matches_break_on)
14956 (make_source_files_completion_list): Remove declaration.
14957 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
14958 (ada_collect_symbol_completion_matches)
14959 (ada_add_global_exceptions): Remove declaration.
14960 * linespec.c (iterate_over_all_matching_symtabs): Use
14961 objfile_compunits.
14962 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
14963 (class objfile_compunits): New.
14964 (ALL_COMPUNITS): Use objfile_compunits.
14965 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
14966 (maintenance_check_symtabs, maintenance_info_line_tables): Use
14967 objfile_compunits.
14968 * objfiles.c (objfile_relocate1): Use objfile_compunits.
14969
14970 2019-01-09 Tom Tromey <tom@tromey.com>
14971
14972 * symtab.c (search_symbols)
14973 (default_collect_symbol_completion_matches_break_on): Use
14974 objfile_msymbols.
14975 * ada-lang.c (ada_lookup_simple_minsym)
14976 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
14977 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
14978 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
14979 objfile_msymbols.
14980 * coffread.c (coff_symfile_read): Use objfile_msymbols.
14981 * symmisc.c (dump_msymbols): Use objfile_msymbols.
14982 * objc-lang.c (find_methods): Use objfile_msymbols.
14983 (info_selectors_command, info_classes_command): Likewise.
14984 * stabsread.c (scan_file_globals): Use objfile_msymbols.
14985 * objfiles.h (class objfile_msymbols): New.
14986 (ALL_OBJFILE_MSYMBOLS): Remove.
14987 (ALL_MSYMBOLS): Remove.
14988
14989 2019-01-09 Tom Tromey <tom@tromey.com>
14990
14991 * common/next-iterator.h (next_adapter): Add Iterator template
14992 parameter.
14993 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
14994 (class all_objfiles_safe): New.
14995 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
14996 * objfiles.c (put_objfile_before): Update comment.
14997 (add_separate_debug_objfile): Likewise.
14998 (free_all_objfiles): Use all_objfiles_safe.
14999 (objfile_purge_solibs): Likewise.
15000
15001 2019-01-09 Tom Tromey <tom@tromey.com>
15002
15003 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15004 (expand_symtab_containing_pc, lookup_static_symbol)
15005 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15006 (find_symbol_at_address, find_line_symtab, find_main_name): Use
15007 all_objfiles.
15008 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15009 * breakpoint.c (create_overlay_event_breakpoint)
15010 (create_longjmp_master_breakpoint)
15011 (create_std_terminate_master_breakpoint)
15012 (create_exception_master_breakpoint): Use all_objfiles.
15013 * linux-thread-db.c (try_thread_db_load_from_pdir)
15014 (has_libpthread): Use all_objfiles.
15015 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15016 * linespec.c (iterate_over_all_matching_symtabs)
15017 (search_minsyms_for_name): Use all_objfiles.
15018 * maint.c (maintenance_info_sections): Use all_objfiles.
15019 * main.c (captured_main_1): Use all_objfiles.
15020 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15021 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15022 * guile/scm-pretty-print.c
15023 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15024 * solib-spu.c (append_ocl_sos): Use all_objfiles.
15025 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15026 (maintenance_print_msymbols): Use all_objfiles.
15027 * source.c (select_source_symtab): Use all_objfiles.
15028 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15029 * symfile.c (remove_symbol_file_command)
15030 (expand_symtabs_matching, map_symbol_filenames): Use
15031 all_objfiles.
15032 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15033 all_objfiles.
15034 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15035 * objc-lang.c (find_methods): Use all_objfiles.
15036 * objfiles.c (have_partial_symbols, have_full_symbols)
15037 (have_minimal_symbols, qsort_cmp)
15038 (default_iterate_over_objfiles_in_search_order): Use
15039 all_objfiles.
15040 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15041 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15042 (maintenance_check_psymtabs): Use all_objfiles.
15043 (ALL_PSYMTABS): Remove.
15044 * compile/compile-object-run.c (do_module_cleanup): Use
15045 all_objfiles.
15046 * blockframe.c (find_pc_partial_function): Use all_objfiles.
15047 * cp-support.c (add_symbol_overload_list_qualified): Use
15048 all_objfiles.
15049 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15050 Use all_objfiles.
15051 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15052 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15053 all_objfiles.
15054 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15055 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15056 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15057 Uses all_objfiles.
15058 * solib.c (solib_read_symbols): Use all_objfiles
15059
15060 2019-01-09 Tom Tromey <tom@tromey.com>
15061
15062 * probe.c (parse_probes_in_pspace): Use all_objfiles.
15063 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15064 all_objfiles.
15065 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15066 * symmisc.c (print_symbol_bcache_statistics)
15067 (print_objfile_statistics, maintenance_print_objfiles)
15068 (maintenance_info_symtabs, maintenance_check_symtabs)
15069 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15070 all_objfiles.
15071 * source.c (forget_cached_source_info): Use all_objfiles.
15072 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15073 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15074 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15075 * objfiles.c (update_section_map): Use all_objfiles.
15076 (shared_objfile_contains_address_p): Likewise.
15077 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15078 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15079
15080 2019-01-09 Tom Tromey <tom@tromey.com>
15081
15082 * common/next-iterator.h: New file.
15083 * objfiles.h (class all_objfiles): New.
15084 (struct objfile_iterator): New.
15085
15086 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15087
15088 * NEWS: Move the description of the changed "frame", "select-frame",
15089 and "info frame" commands to the Changed commands section.
15090
15091 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
15092
15093 * gdbtypes.c (check_stub_method_group): Remove handling of old
15094 mangling schemes.
15095 * linespec.c (find_methods): Likewise.
15096 * stabsread.c (read_member_functions): Likewise.
15097 * valops.c (search_struct_method): Likewise.
15098 (value_struct_elt_for_reference): Likewise.
15099 * NEWS: Mention this change.
15100
15101 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
15102
15103 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15104 print_source_lines.
15105 * source.c (print_source_lines_base): Update line number check.
15106 (print_source_lines): New function.
15107 (source_lines_range::source_lines_range): New function.
15108 * source.h (class source_lines_range): New class.
15109 (print_source_lines): New declaration.
15110
15111 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15112
15113 * linespec.c (linespec_state_destructor): Free self->canonical_names.
15114
15115 2019-01-08 Tom Tromey <tom@tromey.com>
15116 Simon Marchi <simon.marchi@ericsson.com>
15117
15118 PR gdb/24060
15119 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15120 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15121 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15122 * f-exp.y (DOLLAR_VARIABLE): Likewise.
15123 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15124 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15125
15126 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15127
15128 * source.c (select_source_symtab): Move header comment to
15129 declaration in source.h.
15130 (forget_cached_source_info_for_objfile): Likewise.
15131 (forget_cached_source_info): Likewise.
15132 (identify_source_line): Likewise.
15133 * source.h (identify_source_line): Move declaration from symtab.h
15134 and add comment from source.c
15135 (print_source_lines): Likewise.
15136 (forget_cached_source_info_for_objfile): Likewise.
15137 (forget_cached_source_info): Likewise.
15138 (select_source_symtab): Likewise.
15139 (enum print_source_lines_flag): Move definition from symtab.h.
15140 * symtab.h (identify_source_line): Move declaration to source.h.
15141 (print_source_lines): Likewise.
15142 (forget_cached_source_info_for_objfile): Likewise.
15143 (forget_cached_source_info): Likewise.
15144 (select_source_symtab): Likewise.
15145 (enum print_source_lines_flag): Move definition to source.h.
15146 * tui/tui-hooks.c: Add 'source.h' include.
15147
15148 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15149
15150 * source.c (print_source_lines_base): Handle requests to print
15151 reverse line number sequences, and guard against empty lines
15152 string.
15153
15154 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
15155
15156 * source.c (print_source_lines_base): Fix skip of '\r' if next
15157 character is '\n'.
15158
15159 2019-01-06 Tom Tromey <tom@tromey.com>
15160
15161 * c-exp.y (struct c_parse_state) <macro_original_text,
15162 expansion_obstack>: New member.
15163 (macro_original_text, expansion_obstack): Remove globals.
15164 (scan_macro_expansion, scanning_macro_expansion)
15165 (finished_macro_expansion): Update.
15166 (scan_macro_cleanup): Remove.
15167 (yylex, c_parse): Update.
15168
15169 2019-01-06 Tom Tromey <tom@tromey.com>
15170
15171 * c-exp.y (struct c_parse_state) <strings>: New member.
15172 (operator_stoken): Update.
15173
15174 2019-01-06 Tom Tromey <tom@tromey.com>
15175
15176 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
15177 (union type_stack_elt) <typelist_val>: Now a pointer to
15178 std::vector.
15179 (type_stack_cleanup): Don't declare.
15180 (push_typelist): Update.
15181 * parse.c (pop_typelist): Return a std::vector.
15182 (push_typelist): Take a std::vector.
15183 (follow_types): Update. Do not free args.
15184 (type_stack_cleanup): Remove.
15185 * c-exp.y (struct c_parse_state): New.
15186 (cpstate): New global.
15187 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15188 (nonempty_typelist): Update.
15189 (func_mod): Create a new vector.
15190 (c_parse): Create a c_parse_state.
15191 (check_parameter_typelist): Do not delete params.
15192 (function_method): Update. Do not delete type_list.
15193
15194 2019-01-06 Tom Tromey <tom@tromey.com>
15195
15196 PR gdb/28155:
15197 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15198 check_typedef.
15199 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15200 (print_return_value): Likewise.
15201
15202 2019-01-05 Tom Tromey <tom@tromey.com>
15203
15204 * contrib/cleanup_check.py: Remove.
15205 * contrib/gcc-with-excheck: Remove.
15206 * contrib/exsummary.py: Remove.
15207 * contrib/excheck.py: Remove.
15208
15209 2019-01-05 Joel Brobecker <brobecker@adacore.com>
15210
15211 * thread.c (delete_thread_1): Add gdb_assert that THR is not
15212 NULL. Initialize tpprev to NULL instead of assigning it
15213 to NULL on the next statement.
15214 * windows-nat.c (windows_delete_thread): Remove check for
15215 main_thread_id before printing thread exit notifications.
15216 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15217 Remove thread ID check against main_thread_id.
15218 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15219 windows_delete_thread.
15220 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15221
15222 2019-01-04 Tom Tromey <tom@tromey.com>
15223
15224 * compile/compile.c (_initialize_compile): Use upper case for
15225 metasyntactic variables.
15226 * symmisc.c (_initialize_symmisc): Use upper case for
15227 metasyntactic variables.
15228 * psymtab.c (_initialize_psymtab): Use upper case for
15229 metasyntactic variables.
15230 * demangle.c (demangle_command): Use upper case for metasyntactic
15231 variables.
15232 (_initialize_demangler): Likewise.
15233 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15234 variables.
15235
15236 2019-01-03 Tom Tromey <tom@tromey.com>
15237
15238 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15239
15240 2019-01-03 Tom Tromey <tom@tromey.com>
15241
15242 * python/py-symtab.c (salpy_str): Update.
15243 (struct salpy_sal_object) <symtab>: Now a PyObject.
15244 (salpy_dealloc): Update.
15245 (del_objfile_sal): Use gdbpy_ref.
15246
15247 2019-01-03 Tom Tromey <tom@tromey.com>
15248
15249 * python/py-type.c (convert_field): Use new_reference. Return
15250 gdbpy_ref.
15251 (make_fielditem): Return gdbpy_ref.
15252 (typy_fields): Update.
15253 (typy_getitem): Update.
15254 (field_name): Return gdbpy_ref. Use new_reference.
15255 (typy_iterator_iternext): Update.
15256
15257 2019-01-03 Tom Tromey <tom@tromey.com>
15258
15259 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15260
15261 2019-01-03 Tom Tromey <tom@tromey.com>
15262
15263 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15264 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15265 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15266 (pspy_set_frame_filters, pspy_set_frame_unwinders)
15267 (pspy_set_type_printers): Likewise.
15268 * python/py-function.c (fnpy_init): Use gdbpy_ref.
15269 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15270 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15271 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15272 (objfpy_set_type_printers): Likewise.
15273
15274 2019-01-03 Tom Tromey <tom@tromey.com>
15275
15276 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15277 (gdbpy_print_stack): Use gdbpy_err_fetch.
15278 * python/python-internal.h (class gdbpy_err_fetch): New class.
15279 (class gdbpy_enter) <m_error_type, m_error_value,
15280 m_error_traceback>: Remove.
15281 <m_error>: New member.
15282 (gdbpy_exception_to_string): Don't declare.
15283 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15284 * python/py-value.c (convert_value_from_python): Use
15285 gdbpy_err_fetch.
15286 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15287 gdbpy_exception_to_string.
15288 (gdbpy_handle_exception): Use gdbpy_err_fetch.
15289 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15290 gdbpy_err_fetch.
15291
15292 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15293
15294 * linux-nat.c (delete_lwp_cleanup): Delete.
15295 (struct lwp_deleter): New struct.
15296 (lwp_info_up): New typedef.
15297 (linux_nat_target::follow_fork): Delete cleanup, and make use of
15298 lwp_info_up.
15299
15300 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15301
15302 * linux-fork.c (class scoped_switch_fork_info): New class.
15303 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15304
15305 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15306
15307 * valops.c (find_overload_match): Remove use of null_cleanup, and
15308 calls to do_cleanups.
15309
15310 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15311
15312 * compile/compile-cplus-types.c
15313 (compile_cplus_instance::decl_name): Handle changes to
15314 cp_func_name.
15315 * cp-support.c (cp_func_name): Update header comment, update
15316 return type.
15317 * cp-support.h (cp_func_name): Update return type in declaration.
15318 * valops.c (find_overload_match): Move temp_func local to top
15319 level of function and change its type. Use temp_func to hold and
15320 delete temporary string obtained from cp_func_name.
15321
15322 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
15323
15324 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15325 gdb::char_vector, remove cleanup, and update uses of `msg`.
15326
15327 2019-01-03 Jim Wilson <jimw@sifive.com>
15328
15329 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15330
15331 2019-01-02 Tom Tromey <tom@tromey.com>
15332
15333 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15334 (tdesc_parse_xml): Remove cleanups.
15335 * target-descriptions.h (make_cleanup_free_target_description):
15336 Don't declare.
15337 (target_desc_deleter): New struct.
15338 (target_desc_up): New typedef.
15339 * target-descriptions.c (target_desc_deleter::operator()): Rename
15340 from free_target_description.
15341 (make_cleanup_free_target_description): Remove.
15342
15343 2019-01-02 Tom Tromey <tom@tromey.com>
15344
15345 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
15346 constructor, destructor.
15347 (linespec_parser): Remove typedef.
15348 (~linespec_parser): Rename from linespec_parser_delete.
15349 (linespec_lex_to_end, linespec_complete_label)
15350 (linespec_complete): Update.
15351 (decode_line_full): Remove cleanups.
15352 (decode_line_1): Update.
15353
15354 2019-01-02 Tom Tromey <tom@tromey.com>
15355
15356 * python/python-internal.h (inferior_to_inferior_object): Change
15357 return type.
15358 * python/py-exitedevent.c (create_exited_event_object): Update.
15359 * python/py-inferior.c (inferior_to_inferior_object): Return
15360 gdbpy_ref.
15361 (python_new_inferior, python_inferior_deleted)
15362 (thread_to_thread_object, delete_thread_object)
15363 (build_inferior_list, gdbpy_selected_inferior): Update.
15364 * python/py-infthread.c (create_thread_object): Update. Also fail
15365 if inferior_to_inferior_object fails.
15366
15367 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
15368
15369 * inferior.h (class inferior) <displaced_step_state>: New field.
15370 * infrun.h (struct displaced_step_state): Move here from
15371 infrun.c. Initialize fields, add constructor.
15372 <inf>: Remove field.
15373 <reset>: New method.
15374 * infrun.c (struct displaced_step_inferior_state): Move to
15375 infrun.h.
15376 (displaced_step_inferior_states): Remove.
15377 (get_displaced_stepping_state): Adust.
15378 (displaced_step_in_progress_any_inferior): Adjust.
15379 (displaced_step_in_progress_thread): Adjust.
15380 (displaced_step_in_progress): Adjust.
15381 (add_displaced_stepping_state): Remove.
15382 (get_displaced_step_closure_by_addr): Adjust.
15383 (remove_displaced_stepping_state): Remove.
15384 (infrun_inferior_exit): Call displaced_step_state.reset.
15385 (use_displaced_stepping): Don't check for NULL.
15386 (displaced_step_prepare_throw): Call
15387 get_displaced_stepping_state.
15388 (displaced_step_fixup): Don't check for NULL.
15389 (prepare_for_detach): Don't check for NULL.
15390
15391 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15392
15393 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15394 in case of call that did not complete.
15395
15396 2019-01-02 Andrey Utkin <autkin@undo.io>
15397
15398 * symfile.c (find_separate_debug_file): Fix search of debug files for
15399 remote debuggee.
15400
15401 2019-01-02 Tom Tromey <tom@tromey.com>
15402
15403 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15404 indentation.
15405 * python/py-frame.c (frapy_older): Remove cast.
15406 (frapy_newer): Likewise.
15407 * python/py-breakpoint.c (local_setattro): Remove cast.
15408 * python/py-arch.c (archpy_name): Remove local variable.
15409 * python/py-type.c (gdbpy_lookup_type): Remove cast.
15410
15411 2019-01-02 Joel Brobecker <brobecker@adacore.com>
15412
15413 * unittests/basic_string_view/element_access/char/empty.cc:
15414 Fix year range in copyright header.
15415
15416 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
15417
15418 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
15419 Delete.
15420 <operator==>: Update with for removed field.
15421 <hash>: Likewise.
15422 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
15423 <isa_features>: ...this.
15424 <abi_features>: New field.
15425 (riscv_isa_flen): Update comment.
15426 (riscv_abi_xlen): New declaration.
15427 (riscv_abi_flen): New declaration.
15428 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
15429 isa_features.
15430 (riscv_abi_xlen): New function.
15431 (riscv_isa_flen): Update to get answer from isa_features.
15432 (riscv_abi_flen): New function.
15433 (riscv_has_fp_abi): Update to get answer from abi_features.
15434 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
15435 xlen and flen.
15436 (riscv_call_info) <xlen, flen>: Update comment.
15437 (riscv_call_arg_struct): Remove invalid assertions
15438 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
15439 is removed.
15440 (riscv_gdbarch_init): Gather isa features and abi features
15441 separately, ensure both match on the gdbarch when reusing an old
15442 gdbarch. Relax an error check to allow 32-bit abi float to run on
15443 a target with 64-bit float hardware.
15444
15445 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15446
15447 * source.c (search_command_helper): Stop reverse search
15448 when line 1 has been searched.
15449
15450 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15451
15452 * record-full.c (record_full_base_target::close): Rewrite
15453 record_full_core_buf_list free logic.
15454
15455 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15456
15457 * break-catch-syscall.c (print_one_catch_syscall): xfree
15458 the last text.
15459
15460 2019-01-01 Joel Brobecker <brobecker@adacore.com>
15461
15462 * top.c (print_gdb_version): Update Copyright year in version
15463 message.
15464
15465 2019-01-01 Joel Brobecker <brobecker@adacore.com>
15466
15467 Update copyright year range in all GDB files.
15468
15469 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
15470
15471 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
15472
15473 For older changes see ChangeLog-2018.
15474 \f
15475 Local Variables:
15476 mode: change-log
15477 left-margin: 8
15478 fill-column: 74
15479 version-control: never
15480 coding: utf-8
15481 End:
15482
This page took 0.379182 seconds and 4 git commands to generate.