gdb/ChangeLog

   1 2019-10-16  Keith Seitz  <keiths@redhat.com>
   2
   3         PR gdb/23567
   4         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
   5         sections whose size is greater than the file size.
   6
   7 2019-10-16  Jim Wilson  <jimw@sifive.com>
   8
   9         * riscv-tdep.c (riscv_gcc_target_options): New.
  10         (riscv_gnu_triplet_regexp): New.
  11         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
  12         set_gdbarch_gnu_triplet_regexp.
  13
  14 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
  15
  16         * Makefile.in: Add xml-builtin.h.
  17         * features/feature_to_c.sh: Add an include for xml-builtin.h
  18         to ensure that the compiler checks that the types match.
  19         * xml-builtin.h: New file.
  20         * xml-support.c (fetch_xml_builtin): Add missing const.
  21         * xml-support.h: Remove declaration of xml_builtins.
  22
  23 2019-10-16  Tom de Vries  <tdevries@suse.de>
  24
  25         PR tdep/25096
  26         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
  27         (amd64_classify_aggregate): ... here.
  28         (amd64_classify_aggregate_field): Handled fiels of nested structs
  29         recursively.
  30
  31 2019-10-16  Tom de Vries  <tdevries@suse.de>
  32
  33         PR tdep/24104
  34         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
  35         that handles 'theclass'.
  36
  37 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  38
  39         * linespec.c (decode_digits_ordinary): Update comment.
  40         * make-target-delegates: No longer need to handle VEC case.
  41         * memrange.c (normalize_mem_ranges): Update comment.
  42         * namespace.c (add_using_directive): Update comment.
  43         * objc-lang.c (uniquify_strings): Update comment.
  44         * ppc-linux-nat.c (struct thread_points): Update comment.
  45         * probe.h (find_probes_in_objfile): Update comment.
  46         * target.h (enum flash_preserve_mode): Update comment.
  47         * varobj.c (varobj_restrict_range): Update comment.
  48         * varobj.h (varobj_list_children): Update comment.
  49
  50 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * Makefile.in: Remove references to vec.h and vec.c.
  53         * aarch64-tdep.c: No longer include vec.h.
  54         * ada-lang.c: Likewise.
  55         * ada-lang.h: Likewise.
  56         * arm-tdep.c: Likewise.
  57         * ax.h: Likewise.
  58         * breakpoint.h: Likewise.
  59         * charset.c: Likewise.
  60         * cp-support.h: Likewise.
  61         * dtrace-probe.c: Likewise.
  62         * dwarf2read.c: Likewise.
  63         * extension.h: Likewise.
  64         * gdb_bfd.c: Likewise.
  65         * gdbsupport/gdb_vecs.h: Likewise.
  66         * gdbsupport/vec.c: Remove.
  67         * gdbsupport/vec.h: Remove.
  68         * gdbthread.h: Likewise.
  69         * guile/scm-type.c: Likewise.
  70         * inline-frame.c: Likewise.
  71         * machoread.c: Likewise.
  72         * memattr.c: Likewise.
  73         * memrange.h: Likewise.
  74         * namespace.h: Likewise.
  75         * nat/linux-btrace.h: Likewise.
  76         * osdata.c: Likewise.
  77         * parser-defs.h: Likewise.
  78         * progspace.h: Likewise.
  79         * python/py-type.c: Likewise.
  80         * record-btrace.c: Likewise.
  81         * rust-exp.y: Likewise.
  82         * solib-target.c: Likewise.
  83         * stap-probe.c: Likewise.
  84         * target-descriptions.c: Likewise.
  85         * target-memory.c: Likewise.
  86         * target.h: Likewise.
  87         * varobj.c: Likewise.
  88         * varobj.h: Likewise.
  89         * xml-support.h: Likewise.
  90
  91 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
  92
  93         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
  94         Update for new std::vector based implementation.
  95         (process_psymtab_comp_unit_reader): Likewise.
  96         (scan_partial_symbols): Likewise.
  97         (recursively_compute_inclusions): Likewise.
  98         (compute_compunit_symtab_includes): Likewise.
  99         (process_imported_unit_die): Likewise.
 100         (queue_and_load_dwo_tu): Likewise.
 101         (follow_die_sig_1): Likewise.
 102         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 103         (typedef dwarf2_per_cu_ptr): Remove.
 104         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 105         function.
 106         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 107         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 108         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 109         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 110         std::vector.
 111
 112 2019-10-15  Tom Tromey  <tromey@adacore.com>
 113
 114         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 115         TID.
 116
 117 2019-10-15  Tom Tromey  <tromey@adacore.com>
 118
 119         * windows-nat.c (windows_nat_target::fetch_registers)
 120         (windows_nat_target::store_registers): Rename "pid" to "tid".
 121
 122 2019-10-15  Tom Tromey  <tromey@adacore.com>
 123
 124         * gdbarch.h, gdbarch.c: Rebuild.
 125         * gdbarch.sh (gcc_target_options): Change return type to
 126         std::string.
 127         * compile/compile.c (get_args): Update.
 128         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 129         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 130         std::string.
 131         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 132         std::string.
 133         * arch-utils.c (default_gcc_target_options): Return std::string.
 134         * arch-utils.h (default_gcc_target_options): Return std::string.
 135         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 136
 137 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 138
 139         * breakpoint.c (breakpoint_chain): Make static.
 140         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 141         of accessing breakpoint_chain.
 142
 143 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 144
 145         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 146         to a gdb::function_view and return value to bool.
 147         * breakpoint.h (iterate_over_breakpoints): Likewise.
 148         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 149         (pop_dummy_frame): Update.
 150         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 151         (gdbscm_breakpoints): Update.
 152         * python/py-breakpoint.c (build_bp_list): Update.
 153         (gdbpy_breakpoints): Update.
 154         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 155         Update.
 156         (bpfinishpy_handle_stop): Update.
 157         (bpfinishpy_handle_exit): Update.
 158         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 159         (svr4_update_solib_event_breakpoints): Update.
 160
 161 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 162
 163         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 164         when unwrapping single-field structs.
 165
 166 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 167
 168         * dwarf2read.c: Remove includes.
 169
 170 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 171
 172         * ui-out.c (ui_out::call_do_message): Silence
 173         -Wformat-nonliteral warning.
 174
 175 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 176
 177         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 178         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 179         include: readline/tilde.h.
 180
 181 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 182
 183         * remote.c (remote_target::get_trace_status): Remove declaration of
 184         trace_regblock_size.
 185
 186 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 187
 188         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 189         (show_user): Remove declaration of cmdlist.
 190         * cli/cli-cmds.h (max_user_call_depth): Declare.
 191         * cli/cli-script.c (execute_user_command): Remove declaration
 192         of max_user_call_depth.
 193
 194 2019-10-11  Jim Wilson  <jimw@sifive.com>
 195
 196         * gdbsupport/print-utils.h (pulongest): Fix comment.
 197         (plongest): Likewise.
 198         (phex): Add missing comment, mention leading zeros.
 199         (phex_nz): Add mention of no leading zeros to comment.
 200
 201         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 202         plongest instead of unsigned long long cast.
 203
 204 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 205
 206         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 207         for external_editor_command and gdbtk_test.
 208
 209 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 210
 211         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 212         * varobj.c (varobjdebug): Move comment to...
 213         * varobj.h (varobjdebug): ...here, and declare.
 214
 215 2019-10-09  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 218         erase_data_content.
 219
 220 2019-10-09  Tom Tromey  <tom@tromey.com>
 221
 222         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 223         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 224         * tui/tui-command.c (tui_cmd_window::resize)
 225         (tui_refresh_cmd_win): Update.
 226         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 227         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 228         * tui/tui-data.c (~tui_gen_win_info): Remove.
 229         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 230         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 231         (tui_redisplay_readline, tui_mld_flush)
 232         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 233         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 234         (tui_data_window::erase_data_content)
 235         (tui_data_item_window::rerender)
 236         (tui_data_item_window::refresh_window): Update.
 237         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 238         (box_win, tui_gen_win_info::make_window)
 239         (tui_gen_win_info::make_visible): Update.
 240         (tui_delete_win): Remove.
 241         * tui/tui-winsource.c
 242         (tui_source_window_base::do_erase_source_content): Update.
 243         (tui_show_source_line, tui_source_window_base::update_tab_width)
 244         (tui_source_window_base::update_exec_info): Update.
 245         * tui/tui-data.h (struct curses_deleter): New.
 246         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 247         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 248
 249 2019-10-09  Tom Tromey  <tom@tromey.com>
 250
 251         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 252
 253 2019-10-09  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 256         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 257
 258 2019-10-09  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 261         window height directly.
 262         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 263         declare.
 264         * tui/tui-layout.c (tui_default_win_height): Remove.
 265         (tui_default_win_viewport_height): Remove.
 266
 267 2019-10-09  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui.h: Remove comments.
 270
 271 2019-10-09  Tom de Vries  <tdevries@suse.de>
 272
 273         * python/lib/gdb/printer/bound_registers.py: Use
 274         '^builtin_type_bound128' as regexp argument for
 275         add_builtin_pretty_printer.
 276
 277 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 278
 279         * guile/guile.c (guile_extension_script_ops): Remove forward
 280         declaration and mark as static.
 281         (guile_script_ops): Likewise.
 282         (extension_language_guile): Move further down in the file so
 283         it can reference the definitions for guile_{extension_,}script_ops.
 284
 285 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 286
 287         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 288         except SORTL, DFLTCC, and KDSA.
 289
 290 2019-10-08  Tom Tromey  <tromey@adacore.com>
 291
 292         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 293         (struct safe_symbol_file_add_args): Remove.
 294
 295 2019-10-08  Tom Tromey  <tromey@adacore.com>
 296
 297         * windows-nat.c: Don't include buildsym-legacy.h.
 298
 299 2019-10-08  Tom Tromey  <tromey@adacore.com>
 300
 301         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 302
 303 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 304
 305         * gdbtypes.c (overload_debug): Move comment to header.
 306         * gdbtypes.h (overload_debug): Declare.
 307         * valops.c: Remove declaration of overload_debug, instead
 308         include gdbtypes.h.
 309
 310 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 311
 312         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 313         through _().
 314         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 315         move comment...
 316         * language.h (lang_frame_mismatch_warn): ... here. Also add
 317         declaration.
 318         * top.c (lang_frame_mismatch_warn): Remove declaration.
 319         (check_frame_language_change): Pass lang_frame_mismatch_warn
 320         through _().
 321
 322 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 323
 324         * c-lang.h (vtbl_ptr_name): Declare.
 325         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 326         it from the header.
 327         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 328
 329 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 330
 331         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 332         gdb_static_assert.
 333
 334 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 335
 336         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 337         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 338         * ctfread.c: New file.
 339         * ctfread.h: New file.
 340         * elfread.c: Include ctfread.h.
 341         (struct elfinfo text_p): New member ctfsect.
 342         (elf_locate_sections): Mark CTF section.
 343         (elf_symfile_read): Call elfctf_build_psymtabs.
 344         * Makefile.in (LIBCTF): Add.
 345         (CLIBS): Use it.
 346         (CDEPS): Likewise.
 347         (DIST): Add ctfread.c.
 348
 349 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 350
 351         * ctfread.c (struct nextfield): Renamed to ...
 352         (struct ctf_nextfield): ... this.
 353         (struct field_info): Renamed to ...
 354         (strut ctf_field_info): ... this.
 355         (attach_fields_to_type): Update for renamed structures.
 356         (ctf_add_member_cb): Likewise.
 357         (ctf_add_enum_member_cb): Likewise.
 358         (process_struct_members): Likewise.
 359         (process_enum_type): Likewise.
 360
 361 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 362
 363         * tracectf.h: Rename, was ctf.h.
 364         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 365         * tracefile.c: Likewise.
 366         * tracepoint.c: Remove unused include ctf.h.
 367         * mi/mi-main.c: Likewise.
 368         * Makefile.in Replace ctf.c with tracectf.c.
 369
 370 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 371
 372         * version.in: Change version number to "9.0.50.DATE-git".
 373
 374 2019-10-03  Tom Tromey  <tom@tromey.com>
 375
 376         PR rust/24976:
 377         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 378
 379 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 380
 381         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 382         cp_search_name_hash.
 383         * NEWS: Add entry about nested function support.
 384
 385 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 386             Andrew Burgess  <andrew.burgess@embecosm.com>
 387
 388         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 389         for nested static variables when searchin VAR_DOMAIN.
 390         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 391         global scope, update comment.
 392         (add_partial_subprogram): Call add_partial_subprogram recursively
 393         for nested subroutines when processinng Fortran.
 394         (load_partial_dies): Process the child entities of a subprogram
 395         when processing Fortran.
 396         (partial_die_parent_scope): Handle building scope
 397         for Fortran nested functions.
 398         (process_die): Record that nested functions have a scope.
 399         (new_symbol): Always record Fortran subprograms on the global
 400         symbol list.
 401         (determine_prefix): How to build the prefix for Fortran
 402         subprograms.
 403
 404 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 407         have just sent the thread a SIGSTOP and are waiting for it to
 408         arrive.
 409
 410 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 411
 412         * btrace.c (btrace_add_pc): Remove whitespace before the template
 413         parameter in 'std::vector <...>'.
 414         (parse_xml_btrace_block): Likewise.
 415         (btrace_maint_decode_pt): Likewise.
 416         (btrace_maint_update_packets): Likewise.
 417         (btrace_maint_print_packets): Likewise.
 418         * btrace.h (struct btrace_maint_info): Likewise.
 419         * dwarf2read.c (struct type_unit_group): Likewise.
 420         (build_type_psymtabs_reader): Likewise.
 421         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 422         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 423         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 424
 425 2019-10-03  Tom de Vries  <tdevries@suse.de>
 426
 427         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 428         the first line of the help text for set/show style metadata.
 429
 430 2019-10-02  Tom Tromey  <tromey@adacore.com>
 431
 432         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 433         * gdbsupport/common-inferior.c: New file.
 434         * infcmd.c (startup_with_shell): Don't define.
 435         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 436         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 437         * inferior.h (startup_with_shell): Don't declare.
 438
 439 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 440
 441         * gdbsupport/gdb_assert.h: Include errors.h.
 442         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 443
 444 2019-10-02  Tom Tromey  <tromey@adacore.com>
 445
 446         * NEWS: Add $_ada_exception entry.
 447         * ada-lang.c (struct ada_catchpoint): Add constructor.
 448         <m_kind>: New member.
 449         (allocate_location_exception, re_set_exception): Remove
 450         "ex" parameter.
 451         (should_stop_exception): Compute $_ada_exception.
 452         (check_status_exception, print_it_exception)
 453         (print_one_exception, print_mention_exception): Remove
 454         "ex" parameter.
 455         (allocate_location_catch_exception, re_set_catch_exception)
 456         (check_status_exception, print_it_catch_exception)
 457         (print_one_catch_exception, print_mention_catch_exception)
 458         (print_recreate_catch_exception)
 459         (allocate_location_catch_exception_unhandled)
 460         (re_set_catch_exception_unhandled)
 461         (check_status_exception, print_it_catch_exception_unhandled)
 462         (print_one_catch_exception_unhandled)
 463         (print_mention_catch_exception_unhandled)
 464         (print_recreate_catch_exception_unhandled)
 465         (allocate_location_catch_assert, re_set_catch_assert)
 466         (check_status_assert, print_it_catch_assert)
 467         (print_one_catch_assert, print_mention_catch_assert)
 468         (print_recreate_catch_assert)
 469         (allocate_location_catch_handlers, re_set_catch_handlers)
 470         (check_status_handlers, print_it_catch_handlers)
 471         (print_one_catch_handlers, print_mention_catch_handlers)
 472         (print_recreate_catch_handlers): Remove.
 473         (create_ada_exception_catchpoint): Update.
 474         (initialize_ada_catchpoint_ops): Update.
 475
 476 2019-10-02  Tom Tromey  <tromey@adacore.com>
 477
 478         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 479         (create_excep_cond_exprs): Simplify exception string computation.
 480         (ada_exception_catchpoint_cond_string): Likewise.
 481
 482 2019-10-02  Tom Tromey  <tromey@adacore.com>
 483
 484         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 485         * ada-lang.c (lesseq_defined_than): Handle
 486         LOC_STATIC.
 487         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 488         parameter.
 489         (dwarf2_has_info): Likewise.
 490         (new_symbol): Set maybe_copied on symbol when
 491         appropriate.
 492         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 493         parameter.
 494         <can_copy>: New member.
 495         * elfread.c (record_minimal_symbol): Set maybe_copied
 496         on symbol when appropriate.
 497         (elf_symfile_read): Update call to dwarf2_has_info.
 498         * minsyms.c (lookup_minimal_symbol_linkage): New
 499         function.
 500         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 501         * symtab.c (get_symbol_address, get_msymbol_address):
 502         New functions.
 503         * symtab.h (get_symbol_address, get_msymbol_address):
 504         Declare.
 505         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 506         maybe_copied.
 507         (struct symbol, struct minimal_symbol) <maybe_copied>:
 508         New member.
 509
 510 2019-10-02  Tom Tromey  <tromey@adacore.com>
 511
 512         * source.c (struct current_source_location): New.
 513         (current_source_key): New global.
 514         (current_source_symtab, current_source_line)
 515         (current_source_pspace): Remove.
 516         (get_source_location): New function.
 517         (get_current_source_symtab_and_line)
 518         (set_default_source_symtab_and_line)
 519         (set_current_source_symtab_and_line)
 520         (clear_current_source_symtab_and_line, select_source_symtab)
 521         (info_source_command, print_source_lines_base)
 522         (info_line_command, search_command_helper, _initialize_source):
 523         Update.
 524
 525 2019-10-02  Tom Tromey  <tromey@adacore.com>
 526
 527         * source.c (select_source_symtab): Don't call
 528         decode_line_with_current_source.
 529
 530 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * symtab.c (lookup_global_symbol): Search global block.
 533
 534 2019-10-02  Tom Tromey  <tromey@adacore.com>
 535
 536         * coffread.c (process_coff_symbol): Update.
 537         * dwarf2read.c (var_decode_location, new_symbol): Update.
 538         * mdebugread.c (parse_symbol): Update.
 539         * objfiles.c (relocate_one_symbol): Update.
 540         * stabsread.c (define_symbol, fix_common_block)
 541         (scan_file_globals): Update.
 542         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 543         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 544         * xcoffread.c (process_xcoff_symbol): Update.
 545
 546 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 547
 548         * MAINTAINERS: Update my email address.
 549
 550 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 551
 552         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 553         std::vector.
 554         (build_type_psymtabs_reader): Update for std::vector.
 555         (build_type_psymtab_dependencies): Likewise.
 556         * dwarf2read.h: Remove use of DEF_VEC_P.
 557         (typedef sig_type_ptr): Delete.
 558
 559 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 560
 561         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 562         to std::vector.
 563         (btrace_maint_decode_pt): Likewise, and move allocation of the
 564         vector outside of the loop.
 565         (btrace_maint_update_packets): Update to handle change from VEC to
 566         std::vector.
 567         (btrace_maint_print_packets): Likewise.
 568         (maint_info_btrace_cmd): Likewise.
 569         * btrace.h: Remove use of DEF_VEC_O.
 570         (typedef btrace_pt_packet_s): Delete.
 571         (struct btrace_maint_info) <packets>: Change fromm VEC to
 572         std::vector.
 573         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 574
 575 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 576
 577         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 578         make accesses into the vector constant references.
 579         (btrace_add_pc): Update for std::vector.
 580         (btrace_stitch_bts): Likewise.
 581         (parse_xml_btrace_block): Likewise.
 582         (btrace_maint_update_packets): Likewise.
 583         (btrace_maint_print_packets): Likewise.
 584         (maint_info_btrace_cmd): Likewise.
 585         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 586         std::vector.
 587         (btrace_data::empty): Likewise.
 588         (btrace_data_append): Likewise.
 589         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 590         (typedef btrace_block_s): Delete.
 591         (struct btrace_block): Add constructor.
 592         (struct btrace_data_bts) <blocks>: Change to std::vector.
 593         * nat/linux-btrace.c (perf_event_read_bts): Update for
 594         std::vector.
 595         (linux_read_bts): Likewise.
 596
 597 2019-10-01  Tom Tromey  <tom@tromey.com>
 598
 599         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 600
 601 2019-10-01  Tom Tromey  <tom@tromey.com>
 602
 603         * stack.c (print_frame, info_frame_command_core): Use
 604         styled_string.
 605         * linux-thread-db.c (try_thread_db_load_1)
 606         (try_thread_db_load_from_pdir_1): Use styled_string.
 607         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 608         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 609         (maybe_print_unsupported_script_warning)
 610         (maybe_print_script_not_found_warning): Use styled_string.
 611         * ada-lang.c (user_select_syms): Use styled_string.
 612
 613 2019-10-01  Tom Tromey  <tom@tromey.com>
 614
 615         * p-lang.c (pascal_printstr): Use metadata style.
 616         * value.c (show_convenience): Use metadata style.
 617         * valprint.c (valprint_check_validity, val_print_optimized_out)
 618         (val_print_not_saved, val_print_unavailable)
 619         (val_print_invalid_address, generic_val_print, val_print)
 620         (value_check_printable, val_print_array_elements): Use metadata
 621         style.
 622         * ui-out.h (class ui_out) <field_fmt>: New overload.
 623         <do_field_fmt>: Add style parameter.
 624         * ui-out.c (ui_out::field_fmt): New overload.
 625         * typeprint.c (type_print_unknown_return_type)
 626         (val_print_not_allocated, val_print_not_associated): Use metadata
 627         style.
 628         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 629         parameter.
 630         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 631         * tracepoint.c (tvariables_info_1): Use metadata style.
 632         * stack.c (print_frame_arg, print_frame_info, print_frame)
 633         (info_frame_command_core): Use metadata style.
 634         * skip.c (info_skip_command): Use metadata style.
 635         * rust-lang.c (rust_print_enum): Use metadata style.
 636         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 637         metadata style.
 638         * python/py-framefilter.c (py_print_single_arg): Use metadata
 639         style.
 640         * printcmd.c (do_one_display, print_variable_and_value): Use
 641         metadata style.
 642         * p-valprint.c (pascal_val_print)
 643         (pascal_object_print_value_fields): Use metadata style.
 644         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 645         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 646         parameter.
 647         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 648         * m2-valprint.c (m2_print_long_set): Use metadata style.
 649         * m2-typeprint.c (m2_print_type): Use metadata style.
 650         * infcmd.c (print_return_value_1): Use metadata style.
 651         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 652         * f-valprint.c (info_common_command_for_block): Use metadata
 653         style.
 654         * f-typeprint.c (f_type_print_base): Use metadata style.
 655         * expprint.c (print_subexp_standard): Use metadata style.
 656         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 657         * cli/cli-style.h (class cli_style_option): Add constructor.
 658         (metadata_style): Declare.
 659         * cli/cli-style.c (metadata_style): New global.
 660         (_initialize_cli_style): Register metadata style.
 661         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 662         parameter.
 663         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 664         * c-typeprint.c (c_type_print_base_struct_union)
 665         (c_type_print_base_1): Use metadata style.
 666         * breakpoint.c (watchpoint_value_print)
 667         (print_one_breakpoint_location): Use metadata style.
 668         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 669         style.
 670         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 671         style.
 672         * ada-valprint.c (val_print_packed_array_elements, printstr)
 673         (print_field_values, ada_val_print_ref, ada_val_print): Use
 674         metadata style.
 675         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 676         style.
 677         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 678         style.
 679         * ada-lang.c (user_select_syms): Use metadata style.
 680
 681 2019-10-01  Tom Tromey  <tom@tromey.com>
 682
 683         * cli/cli-cmds.c (pwd_command): Style output.
 684
 685 2019-10-01  Pedro Alves  <palves@redhat.com>
 686             Tom Tromey  <tom@tromey.com>
 687
 688         * symtab.c (print_symbol_info): Use %ps.
 689         (print_msymbol_info): Use %ps.
 690         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 691         * printcmd.c (print_variable_and_value): Use %ps.
 692         * macrocmd.c (show_pp_source_pos): Use %ps.
 693         * infrun.c (print_exited_reason): Use ui_out::message.
 694         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 695         (describe_other_breakpoints): Use ui_out::message and new
 696         formats.
 697         (say_where): Use new formats.
 698         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 699         and new formats.
 700
 701 2019-10-01  Pedro Alves  <palves@redhat.com>
 702             Tom Tromey  <tom@tromey.com>
 703
 704         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 705         (test_gdb_formats): New function.
 706         (run_tests): Call it.
 707         (test_format_specifier): Update.
 708         * utils.h (fputs_filtered): Update comment.
 709         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 710         (fputs_styled_unfiltered): Declare.
 711         * utils.c (fputs_styled_unfiltered): New function.
 712         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 713         (vfprintf_filtered): Update.
 714         (vfprintf_unfiltered, vprintf_filtered): Update.
 715         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 716         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 717         disallow_ui_out_field>: New constants.
 718         (enum class field_kind): New.
 719         (struct base_field_s, struct signed_field_s): New.
 720         (signed_field): New function.
 721         (struct string_field_s): New.
 722         (string_field): New function.
 723         (struct styled_string_s): New.
 724         (styled_string): New function.
 725         (class ui_out) <message>: Add comment.
 726         <vmessage, call_do_message>: New methods.
 727         <do_message>: Add style parameter.
 728         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 729         methods.
 730         (ui_out::message): Rewrite.
 731         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 732         parameter.
 733         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 734         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 735         gdb_extensions parameter.
 736         (class format_piece): Add parameter to constructor.
 737         (n_int_args): New field.
 738         * gdbsupport/format.c (format_pieces::format_pieces): Add
 739         gdb_extensions parameter.  Handle '*'.
 740         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 741         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 742         vfprintf_styled_no_gdbfmt.
 743         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 744         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 745         unfiltered output.
 746         * ui-style.h (struct ui_file_style) <ptr>: New method.
 747
 748 2019-10-01  Tom Tromey  <tom@tromey.com>
 749
 750         * unittests/format_pieces-selftests.c: Update.  Add final format.
 751         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 752         empty literal pieces.
 753
 754 2019-10-01  Tom Tromey  <tom@tromey.com>
 755
 756         * ui-out.h (enum class ui_out_style_kind): Remove.
 757         (class ui_out) <field_string, field_stsream, do_field_string>:
 758         Change type of "style".
 759         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 760         (ui_out::field_string): Update.
 761         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 762         of "style".
 763         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 764         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 765         * stack.c (print_frame_arg, print_frame_info, print_frame):
 766         Update.
 767         * source.c (print_source_lines_base): Update.
 768         * solib.c (info_sharedlibrary_command): Update.
 769         * skip.c (info_skip_command): Update.
 770         * record-btrace.c (btrace_call_history_src_line)
 771         (btrace_call_history): Update.
 772         * python/py-framefilter.c (py_print_frame): Update.
 773         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 774         "style".
 775         * mi/mi-out.c (mi_ui_out::do_table_header)
 776         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 777         (mi_ui_out::do_field_string): Update.
 778         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 779         Update.
 780         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 781         "style".
 782         * cli-out.c (cli_ui_out::do_table_header)
 783         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 784         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 785         (cli_ui_out::do_field_fmt): Update.
 786         * breakpoint.c (print_breakpoint_location): Update.
 787         (update_static_tracepoint): Update.
 788
 789 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 790
 791         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 792         conversion of gdb_datadir.
 793         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 794         remove not needed c_str ().
 795
 796 2019-09-30  Ali Tamur <tamur@google.com>
 797
 798         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 799         (dwarf2_string_attr): Likewise.
 800
 801 2019-09-30  Ali Tamur <tamur@google.com>
 802
 803         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 804         (process_full_type_unit): Likewise.
 805         (dump_die_shallow): Likewise.
 806         (cu_debug_loc_section): Likewise.
 807
 808 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 809
 810         * minsyms.c (compare_minimal_symbols): Rename to...
 811         (minimal_symbol_is_less_than): ...this, and adjust to STL
 812         conventions (return bool, take arguments as references)
 813         (minimal_symbol_reader::install): Call std::sort instead
 814         of qsort.
 815
 816 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 817
 818         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 819         hash and why.
 820         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 821         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 822
 823 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 824
 825         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 826         * psympriv.h (add_psymbol_to_list): Move comment here and update
 827         it.
 828
 829 2019-09-29  Tom de Vries  <tdevries@suse.de>
 830
 831         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 832         Use $tmpdir/$(basename "$output_file").dwz instead of
 833         "${output_file}.dwz".
 834
 835 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 836
 837         PR gdb/25045
 838         * hppa-linux-nat.c: Include gdbarch.h.
 839
 840 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 841
 842         * blockframe.c (find_pc_partial_function): Change return type to bool.
 843         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 844         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 845         (stub_gnu_ifunc_resolve_name): Likewise.
 846         * symtab.c (compare_filenames_for_search): Likewise.
 847         (compare_glob_filenames_for_search): Likewise.
 848         (matching_obj_sections): Likewise.
 849         (symbol_matches_domain): Likewise.
 850         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 851         (find_line_pc): Change return type to bool.
 852         (find_line_pc_range): Likewise.
 853         (producer_is_realview): Likewise.
 854         * symtab.h (symbol_matches_domain): Likewise.
 855         (find_pc_partial_function): Likewise.
 856         (find_pc_line_pc_range): Likewise.
 857         (in_gnu_ifunc_stub): Likewise.
 858         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 859         (find_line_pc): Likewise.
 860         (find_line_pc_range): Likewise.
 861         (matching_obj_sections): Likewise.
 862         (find_line_symtab): Change out parameter to bool.
 863         (producer_is_realview): Change return type to bool.
 864         (compare_filenames_for_search): Likewise.
 865         (compare_glob_filenames_for_search): Likewise.
 866
 867 2019-09-26  Tom Tromey  <tom@tromey.com>
 868
 869         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 870         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 871         * gdb_usleep.h: Remove.
 872         * gdb_usleep.c: Remove.
 873         * utils.c: Don't include gdb_usleep.h.
 874
 875 2019-09-26  Tom Tromey  <tromey@adacore.com>
 876
 877         * python/py-type.c (type_to_type_object): Call check_typedef
 878         for stub types.
 879
 880 2019-09-26  Tom Tromey  <tom@tromey.com>
 881
 882         * utils.h (initialize_utils): Don't declare.
 883         * top.c (gdb_init): Don't call initialize_utils.
 884         * utils.c (initialize_utils): Remove.  Move contents...
 885         (_initialize_utils): ... here.
 886
 887 2019-09-25  Tom Tromey  <tom@tromey.com>
 888
 889         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 890         * utils.h (make_hex_string): Don't declare.
 891         * utils.c (make_hex_string): Remove.
 892
 893 2019-09-24  Tom de Vries  <tdevries@suse.de>
 894
 895         PR gdb/23815
 896         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 897         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 898
 899 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 900
 901         * NEWS: Mention new simulator port for PRU.
 902
 903 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 904
 905         * ada-exp.y (write_object_remaining): Update.
 906         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 907         and eliminate the static buffer.
 908         (ada_decode_symbol): Update.
 909         (ada_la_decode): Update.
 910         (ada_sniff_from_mangled_name): Update.
 911         (is_valid_name_for_wild_match): Update.
 912         (ada_lookup_name_info::matches): Update and simplify.
 913         (name_matches_regex): Update.
 914         (ada_add_global_exceptions): Update.
 915         * ada-lang.h (ada_decode): Update signature.
 916         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 917         * dwarf-index-write.c (debug_names::insert): Update.
 918
 919 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 920
 921         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 922         formatting.
 923
 924 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 925
 926         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 927         Change "nonzero" to "true" in documentation.
 928
 929 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 930
 931         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 932         (_initialize_darwin_solib): Don't set
 933         darwin_so_ops.lookup_lib_global_symbol.
 934         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 935         set_gdbarch_iterate_over_objfiles_in_search_order.
 936         (elf_lookup_lib_symbol): Rename to...
 937         (svr4_iterate_over_objfiles_in_search_order): this, and update
 938         to iterate semantics.
 939         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 940         * solib.c (solib_global_lookup): Remove.
 941         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 942         (solib_global_lookup): Remove.
 943         * symtab.c (lookup_global_or_static_symbol): Remove call to
 944         solib_global_lookup.
 945
 946 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 947
 948         * NEWS: Move entries about default MI version now being
 949         version 3, and about the GDB/MI fix for multi-location
 950         breakpoints to the "since GDB 8.3" section.
 951
 952 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 953
 954         GDB 8.3.1 released.
 955
 956 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 957
 958         * NEWS: Mention that Cell/B.E. debugging support was removed.
 959         * MAINTAINERS: Remove spu target.
 960
 961         * config/djgpp/fnchange.lst: Remove entries for removed files.
 962
 963         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 964         spu-multiarch.o, and spu-tdep.o.
 965         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 966         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 967         spu-multiarch.c, and spu-tdep.c.
 968         * spu-linux-nat.c: Remove file.
 969         * spu-multiarch.c: Remove file.
 970         * spu-tdep.c: Remove file.
 971         * spu-tdep.h: Remove file.
 972         * solib-spu.c: Remove file.
 973         * solib-spu.h: Remove file.
 974
 975         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 976         * configure.nat (spu-linux): Remove.
 977         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 978         solib-multiarch.o from gdb_target_obs.
 979         (spu*-*-*): Remove.
 980
 981         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 982         feature flag.
 983         (ppc_linux_no_features): Update.
 984         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 985         Cell/B.E. support.
 986         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 987         (tdesc_powerpc_cell64l): Likewise.
 988         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 989         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 990         Cell/B.E. support.
 991         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 992         Do not include "features/rs6000/powerpc-cell32l.c" or
 993         "features/rs6000/powerpc-cell64l.c".
 994         (ppc_linux_spu_section): Remove.
 995         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 996         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 997         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 998         (ppc_linux_spe_context_lookup): Remove.
 999         (ppc_linux_spe_context_inferior_created): Remove.
1000         (ppc_linux_spe_context_solib_loaded): Remove.
1001         (ppc_linux_spe_context_solib_unloaded): Remove.
1002         (ppc_linux_spe_context): Remove.
1003         (struct ppu2spu_cache): Remove.
1004         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1005         (struct ppu2spu_data): Remove.
1006         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1007         ppu2spu_unwind): Remove.
1008         (ppc_linux_init_abi): Remove Cell/B.E. support.
1009         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1010
1011         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1012         (rs6000/powerpc-cell64l-expedite): Likewise
1013         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1014         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1015         rs6000/powerpc-cell64l.xml.
1016         * features/rs6000/powerpc-cell32l.xml: Remove.
1017         * features/rs6000/powerpc-cell64l.xml: Likewise.
1018         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1019         * features/rs6000/powerpc-cell64l.c: Likewise.
1020         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1021         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1022         * regformats/reg-spu.dat: Remove.
1023
1024         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1025         * corelow.c (struct spuid_list): Remove.
1026         (add_to_spuid_list): Remove.
1027         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1028         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1029         (remote_protocol_features): Remove associated entries.
1030         (_initialize_remote): No longer initialize them.
1031         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1032         * linux-nat.c (SPUFS_MAGIC): Remove.
1033         (linux_proc_xfer_spu): Remove.
1034         (spu_enumerate_spu_ids): Remove.
1035         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1036         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1037         (linux_make_corefile_notes): No longer call it.
1038
1039         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1040         (cooked_write_test): Likewise.
1041
1042 2019-09-20  Tom Tromey  <tom@tromey.com>
1043
1044         * NEWS: Mention case-sensitivity of TUI commands.
1045         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1046         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1047         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1048
1049 2019-09-20  Tom Tromey  <tom@tromey.com>
1050
1051         * tui/tui-source.c (tui_source_window::set_contents): Use
1052         make_unique_xstrdup.
1053         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1054         make_unique_xstrdup.
1055
1056 2019-09-20  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-data.c: Remove separator comments.
1059         * tui/tui-layout.c: Remove separator comments.
1060         * tui/tui-win.c: Remove separator comments.
1061         * tui/tui-wingeneral.c: Remove separator comments.
1062
1063 2019-09-20  Tom Tromey  <tom@tromey.com>
1064
1065         * tui/tui.h (strcat_to_buf): Don't declare.
1066         * tui/tui.c (strcat_to_buf): Remove.
1067
1068 2019-09-20  Tom Tromey  <tom@tromey.com>
1069
1070         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1071         from "fullname".
1072         * tui/tui-source.c (tui_source_window::set_contents)
1073         (tui_source_window::location_matches_p)
1074         (tui_source_window::maybe_update): Update.
1075
1076 2019-09-20  Tom Tromey  <tom@tromey.com>
1077
1078         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1079         Update.
1080         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1081         prefix.
1082         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1083         (tui_data_window::line_from_reg_element_no)
1084         (tui_data_window::first_reg_element_no_inline)
1085         (tui_data_window::show_registers)
1086         (tui_data_window::show_register_group)
1087         (tui_data_window::display_registers_from)
1088         (tui_data_window::display_registers_from_line)
1089         (tui_data_window::first_data_item_displayed)
1090         (tui_data_window::delete_data_content_windows)
1091         (tui_data_window::erase_data_content)
1092         (tui_data_window::do_scroll_vertical)
1093         (tui_data_window::refresh_window)
1094         (tui_data_window::check_register_values): Update.
1095
1096 2019-09-20  Tom Tromey  <tom@tromey.com>
1097
1098         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1099         (struct tui_locator_window) <full_name, proc_name>: Now
1100         std::string.
1101         * tui/tui-stack.c (tui_locator_window::make_status_line)
1102         (tui_locator_window::set_locator_fullname)
1103         (tui_locator_window::set_locator_info): Update.
1104         * tui/tui-source.c (tui_source_window::set_contents)
1105         (tui_source_window::showing_source_p): Update.
1106
1107 2019-09-20  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1110         Don't call tui_locator_win_info_ptr.
1111
1112 2019-09-20  Tom Tromey  <tom@tromey.com>
1113
1114         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1115
1116 2019-09-20  Tom Tromey  <tom@tromey.com>
1117
1118         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1119         height for locator.
1120         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1121         * tui/tui-layout.c (show_source_disasm_command, show_data)
1122         (show_source_or_disasm_and_command): Use 1 as height for locator.
1123
1124 2019-09-20  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui.c (tui_enable): Update.
1127         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1128         Update.
1129         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1130         Update.
1131         * tui/tui-data.c (win_resized): Now bool.
1132         (tui_win_resized): Return bool.
1133         (tui_set_win_resized_to): Accept a bool.
1134
1135 2019-09-20  Tom Tromey  <tom@tromey.com>
1136
1137         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1138         Change type of "refresh_values_only".
1139         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1140         type of "refresh_values_only".
1141
1142 2019-09-20  Tom Tromey  <tom@tromey.com>
1143
1144         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1145         std::string.
1146         (tui_disassemble): Add "pos" parameter.
1147         (tui_disasm_window::set_contents): Simplify.
1148
1149 2019-09-20  Tom Tromey  <tom@tromey.com>
1150
1151         * tui/tui-winsource.h (struct tui_source_window_base)
1152         <show_source_content>: Now private.
1153         * tui/tui-winsource.c
1154         (tui_source_window_base::show_source_content): Don't handle empty
1155         content case.
1156
1157 2019-09-20  Tom Tromey  <tom@tromey.com>
1158
1159         * tui/tui-layout.c (show_source_disasm_command)
1160         (show_source_or_disasm_and_command): Don't call
1161         show_source_content.
1162
1163 2019-09-20  Tom Tromey  <tom@tromey.com>
1164
1165         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1166         Declare.
1167         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1168         from tui_make_status_line.
1169         (tui_locator_window::rerender): Update.
1170
1171 2019-09-20  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1174         (tui_locator_window::rerender): Update.
1175
1176 2019-09-20  Tom Tromey  <tom@tromey.com>
1177
1178         * tui/tui-winsource.h (struct tui_source_window_base)
1179         <~tui_source_window_base>: Don't declare.
1180         <fullname>: Remove.
1181         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1182         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1183         member.
1184         * tui/tui-source.c (tui_source_window::set_contents): Update.
1185         (tui_source_window::location_matches_p)
1186         (tui_source_window::maybe_update): Update.
1187
1188 2019-09-20  Tom Tromey  <tom@tromey.com>
1189
1190         * tui/tui-winsource.h (~tui_source_element): Remove.
1191         (tui_source_element): Update.
1192         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1193         * tui/tui-winsource.c (tui_show_source_line): Update.
1194         * tui/tui-source.c (tui_source_window::set_contents): Update.
1195         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1196
1197 2019-09-20  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1200         declare.
1201         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1202         tui_clear_source_windows_detail.
1203         * tui/tui-winsource.h (struct tui_source_window_base)
1204         <clear_detail>: Don't declare.
1205         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1206         Remove.
1207         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1208
1209 2019-09-20  Tom Tromey  <tromey@adacore.com>
1210
1211         PR ada/24919:
1212         * block.c (contained_in): Fix final return value.
1213
1214 2019-09-20  Alan Modra  <amodra@gmail.com>
1215
1216         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1217         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1218         (read_indirect_string_from_dwz): Use bfd accessor.
1219         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1220         * machoread.c (macho_symfile_read_all_oso): Likewise.
1221         * solib.c (solib_bfd_open): Likewise.
1222
1223 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1224
1225         * eval.c: Move declaration of overload_resolution to...
1226         * value.h: ...here.
1227
1228 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1229
1230         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1231         * arm-linux-tdep.c: Likewise.
1232         * arm-nbsd-nat.c: Likewise.
1233         * arm-tdep.h: Declare arm_apcs_32.
1234         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1235
1236 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1237
1238         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1239         * dwarf2read.h: Declare dwarf_always_disassemble.
1240
1241 2019-09-19  Tom de Vries  <tdevries@suse.de>
1242
1243         PR gdb/25009
1244         * source-cache.c (source_cache::ensure): Catch exception thrown during
1245         construction of the highlighter.
1246
1247 2019-09-18  Alan Modra  <amodra@gmail.com>
1248
1249         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1250         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1251         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1252         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1253         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1254         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1255         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1256         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1257         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1258         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1259         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1260         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1261         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1262         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1263         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1264         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1265         * mi/mi-interp.c: Update throughout for bfd section macro and
1266         function changes.
1267         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1268         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1269
1270 2019-09-18  Tom Tromey  <tom@tromey.com>
1271
1272         * NEWS: Add entry.
1273         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1274         call rl_initialize.
1275         (tui_enable): Do not call rl_initialize.
1276
1277 2019-09-18  Christian Groessler  <chris@groessler.org>
1278
1279         * alpha-linux-nat.c: Include gdbarch.h.
1280
1281 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1282
1283         * ui-file.c: Include cli/cli-style.h.
1284         (term_cli_styling): Remove cli_styling declaration.
1285
1286 2019-09-18  Alan Modra  <amodra@gmail.com>
1287
1288         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1289         to bfd_asymbol_section.
1290
1291 2019-09-18  Alan Modra  <amodra@gmail.com>
1292
1293         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1294         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1295         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1296
1297 2019-09-18  Alan Modra  <amodra@gmail.com>
1298
1299         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1300         * spu-linux-nat.c (spu_bfd_open): Likewise.
1301
1302 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1303
1304         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1305         to bool to match definition in dwarf2read.c.
1306
1307 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1308
1309         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1310         (print_signatures): Likewise.
1311         (trust_pad_over_xvs): Likewise.
1312         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1313         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1314         * arm-linux-nat.c (arm_apcs_32): Likewise.
1315         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1316         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1317         * arm-tdep.c (arm_debug): Likewise.
1318         (arm_apcs_32): Likewise.
1319         * auto-load.c (debug_auto_load): Likewise.
1320         (auto_load_gdb_scripts): Likewise.
1321         (global_auto_load): Likewise.
1322         (auto_load_local_gdbinit): Likewise.
1323         (auto_load_local_gdbinit_loaded): Likewise.
1324         * auto-load.h (global_auto_load): Likewise.
1325         (auto_load_local_gdbinit): Likewise.
1326         (auto_load_local_gdbinit_loaded): Likewise.
1327         * breakpoint.c (disconnected_dprintf): Likewise.
1328         (breakpoint_proceeded): Likewise.
1329         (automatic_hardware_breakpoints): Likewise.
1330         (always_inserted_mode): Likewise.
1331         (target_exact_watchpoints): Likewise.
1332         (_initialize_breakpoint): Update.
1333         * breakpoint.h (target_exact_watchpoints): Change to bool.
1334         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1335         * cli/cli-cmds.c (trace_commands): Likewise.
1336         * cli/cli-cmds.h (trace_commands): Likewise.
1337         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1338         to bool*.
1339         * cli/cli-logging.c (logging_overwrite): Change to bool.
1340         (logging_redirect): Likewise.
1341         (debug_redirect): Likewise.
1342         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1343         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1344         to bool.
1345         <boolean_option_def>: Update.
1346         (struct flag_option_def): Change default type of Context to bool
1347         from int.
1348         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1349         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1350         (get_setshow_command_value_string): Likewise.
1351         * cli/cli-style.c (cli_styling): Change to bool.
1352         (source_styling): Likewise.
1353         * cli/cli-style.h (source_styling): Likewise.
1354         (cli_styling): Likewise.
1355         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1356         to bool.
1357         * command.h (var_types): Update comment.
1358         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1359         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1360         bool.
1361         (debug_compile_cplus_scopes): Likewise.
1362         * compile/compile-internal.h (compile_debug): Likewise.
1363         * compile/compile.c (compile_debug): Likewise.
1364         (struct compile_options) <raw>: Likewise.
1365         * cp-support.c (catch_demangler_crashes): Likewise.
1366         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1367         (usr_cmd_cris_dwarf2_cfi): Likewise.
1368         * csky-tdep.c (csky_debug): Likewise.
1369         * darwin-nat.c (enable_mach_exceptions): Likewise.
1370         * dcache.c (dcache_enabled_p): Likewise.
1371         * defs.h (info_verbose): Likewise.
1372         * demangle.c (demangle): Likewise.
1373         (asm_demangle): Likewise.
1374         * dwarf-index-cache.c (debug_index_cache): Likewise.
1375         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1376         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1377         * dwarf2read.c (check_physname): Likewise.
1378         (use_deprecated_index_sections): Likewise.
1379         (dwarf_always_disassemble): Likewise.
1380         * eval.c (overload_resolution): Likewise.
1381         * event-top.c (set_editing_cmd_var): Likewise.
1382         (exec_done_display_p): Likewise.
1383         * event-top.h (set_editing_cmd_var): Likewise.
1384         (exec_done_display_p): Likewise.
1385         * exec.c (write_files): Likewise.
1386         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1387         (debug_fbsd_nat): Likewise.
1388         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1389         Likewise.
1390         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1391         <backtrace_past_entry> Likewise.
1392         * gdb-demangle.h (demangle): Likewise.
1393         (asm_demangle): Likewise.
1394         * gdb_bfd.c (bfd_sharing): Likewise.
1395         * gdbcore.h (write_files): Likewise.
1396         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1397         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1398         * gdbthread.h (print_thread_events): Likewise.
1399         * gdbtypes.c (opaque_type_resolution): Likewise.
1400         (strict_type_checking): Likewise.
1401         * gnu-nat.c (gnu_debug_flag): Likewise.
1402         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1403         * guile/scm-param.c (pascm_variable): Add boolval.
1404         (add_setshow_generic): Update.
1405         (pascm_param_value): Update.
1406         (pascm_set_param_value_x): Update.
1407         * hppa-tdep.c (hppa_debug): Change to bool..
1408         * infcall.c (may_call_functions_p): Likewise.
1409         (coerce_float_to_double_p): Likewise.
1410         (unwind_on_signal_p): Likewise.
1411         (unwind_on_terminating_exception_p): Likewise.
1412         * infcmd.c (startup_with_shell): Likewise.
1413         * inferior.c (print_inferior_events): Likewise.
1414         * inferior.h (startup_with_shell): Likewise.
1415         (print_inferior_events): Likewise.
1416         * infrun.c (step_stop_if_no_debug): Likewise.
1417         (detach_fork): Likewise.
1418         (debug_displaced): Likewise.
1419         (disable_randomization): Likewise.
1420         (non_stop): Likewise.
1421         (non_stop_1): Likewise.
1422         (observer_mode): Likewise.
1423         (observer_mode_1): Likewise.
1424         (set_observer_mode): Update.
1425         (sched_multi): Change to bool.
1426         * infrun.h (debug_displaced): Likewise.
1427         (sched_multi): Likewise.
1428         (step_stop_if_no_debug): Likewise.
1429         (non_stop): Likewise.
1430         (disable_randomization): Likewise.
1431         * linux-tdep.c (use_coredump_filter): Likewise.
1432         (dump_excluded_mappings): Likewise.
1433         * linux-thread-db.c (auto_load_thread_db): Likewise.
1434         (check_thread_db_on_load): Likewise.
1435         * main.c (captured_main_1): Update.
1436         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1437         xx2_opt, boolean_opt>: Change to bool.
1438         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1439         * maint.c (maintenance_profile_p): Likewise.
1440         (per_command_time): Likewise.
1441         (per_command_space): Likewise.
1442         (per_command_symtab): Likewise.
1443         * memattr.c (inaccessible_by_default): Likewise.
1444         * mi/mi-main.c (mi_async): Likewise.
1445         (mi_async_1): Likewise.
1446         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1447         * nat/fork-inferior.h (startup_with_shell): Likewise.
1448         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1449         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1450         * nios2-tdep.c (nios2_debug): Likewise.
1451         * or1k-tdep.c (or1k_debug): Likewise.
1452         * parse.c (parser_debug): Likewise.
1453         * parser-defs.h (parser_debug): Likewise.
1454         * printcmd.c (print_symbol_filename): Likewise.
1455         * proc-api.c (procfs_trace): Likewise.
1456         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1457         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1458         (set_parameter_value): Update.
1459         (add_setshow_generic): Update.
1460         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1461         to bool*.
1462         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1463         int*.
1464         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1465         * record-btrace.c (record_btrace_target::store_registers): Update.
1466         * record-full.c (record_full_memory_query): Change to bool.
1467         (record_full_stop_at_limit): Likewise.
1468         * record-full.h (record_full_memory_query): Likewise.
1469         * remote-notif.c (notif_debug): Likewise.
1470         * remote-notif.h (notif_debug): Likewise.
1471         * remote.c (use_range_stepping): Likewise.
1472         (interrupt_on_connect): Likewise.
1473         (remote_break): Likewise.
1474         * ser-tcp.c (tcp_auto_retry): Likewise.
1475         * ser-unix.c (serial_hwflow): Likewise.
1476         * skip.c (debug_skip): Likewise.
1477         * solib-aix.c (solib_aix_debug): Likewise.
1478         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1479         (spu_auto_flush_cache_p): Likewise.
1480         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1481         Likewise.
1482         (struct info_print_options) <quiet>: Likewise.
1483         * symfile-debug.c (debug_symfile): Likewise.
1484         * symfile.c (auto_solib_add): Likewise.
1485         (separate_debug_file_debug): Likewise.
1486         * symfile.h (auto_solib_add): Likewise.
1487         (separate_debug_file_debug): Likewise.
1488         * symtab.c (basenames_may_differ): Likewise.
1489         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1490         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1491         (struct info_types_options) <quiet>: Likewise.
1492         * symtab.h (demangle): Likewise.
1493         (basenames_may_differ): Likewise.
1494         * target-dcache.c (stack_cache_enabled_1): Likewise.
1495         (code_cache_enabled_1): Likewise.
1496         * target.c (trust_readonly): Likewise.
1497         (may_write_registers): Likewise.
1498         (may_write_memory): Likewise.
1499         (may_insert_breakpoints): Likewise.
1500         (may_insert_tracepoints): Likewise.
1501         (may_insert_fast_tracepoints): Likewise.
1502         (may_stop): Likewise.
1503         (auto_connect_native_target): Likewise.
1504         (target_stop_and_wait): Update.
1505         (target_async_permitted): Change to bool.
1506         (target_async_permitted_1): Likewise.
1507         (may_write_registers_1): Likewise.
1508         (may_write_memory_1): Likewise.
1509         (may_insert_breakpoints_1): Likewise.
1510         (may_insert_tracepoints_1): Likewise.
1511         (may_insert_fast_tracepoints_1): Likewise.
1512         (may_stop_1): Likewise.
1513         * target.h (target_async_permitted): Likewise.
1514         (may_write_registers): Likewise.
1515         (may_write_memory): Likewise.
1516         (may_insert_breakpoints): Likewise.
1517         (may_insert_tracepoints): Likewise.
1518         (may_insert_fast_tracepoints): Likewise.
1519         (may_stop): Likewise.
1520         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1521         (make_thread_apply_all_options_def_group): Change argument from int*
1522         to bool*.
1523         (thread_apply_all_command): Update.
1524         (print_thread_events): Change to bool.
1525         * top.c (confirm): Likewise.
1526         (command_editing_p): Likewise.
1527         (history_expansion_p): Likewise.
1528         (write_history_p): Likewise.
1529         (info_verbose): Likewise.
1530         * top.h (confirm): Likewise.
1531         (history_expansion_p): Likewise.
1532         * tracepoint.c (disconnected_tracing): Likewise.
1533         (circular_trace_buffer): Likewise.
1534         * typeprint.c (print_methods): Likewise.
1535         (print_typedefs): Likewise.
1536         * utils.c (debug_timestamp): Likewise.
1537         (sevenbit_strings): Likewise.
1538         (pagination_enabled): Likewise.
1539         * utils.h (sevenbit_strings): Likewise.
1540         (pagination_enabled): Likewise.
1541         * valops.c (overload_resolution): Likewise.
1542         * valprint.h (struct value_print_options) <prettyformat_arrays,
1543         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1544         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1545         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1546         Likewise.
1547         * windows-nat.c (new_console): Likewise.
1548         (cygwin_exceptions): Likewise.
1549         (new_group): Likewise.
1550         (debug_exec): Likewise.
1551         (debug_events): Likewise.
1552         (debug_memory): Likewise.
1553         (debug_exceptions): Likewise.
1554         (useshell): Likewise.
1555         * windows-tdep.c (maint_display_all_tib): Likewise.
1556         * xml-support.c (debug_xml): Likewise.
1557
1558 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1559
1560         * source.c (prepare_path_for_appending): New function.
1561         (openp): Make use of new function.
1562         (find_and_open_source): Search for the compilation directory and
1563         source file as a relative path beneath the directory search path.
1564
1565 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1566
1567         * source-cache.c (source_cache::get_line_charpos): Catch
1568         exceptions and return false, this matches the behaviour documented
1569         in the header file.
1570
1571 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1572
1573         * ada-tasks.c (info_task): Remove quoting of the task's name.
1574
1575 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1576
1577         * symfile.c (auto_solib_add): Replace comment with a reference
1578         to the header file.
1579
1580 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1581
1582         * NEWS: Mention that gdb can now be compiled with Python 3
1583         on Windows.
1584
1585 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * maint.c (maint_print_section_data::maint_print_section_data):
1588         Force use of 'float log10 (float)' by casting the argument to
1589         float.
1590
1591 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1592
1593         * maint.c: Add 'cmath' include.
1594         (struct maint_print_section_data): New structure.
1595         (print_section_index): New function.
1596         (print_bfd_section_info): Add header comment, small whitespace
1597         cleanup, and update to call new print_section_index function.
1598         (print_objfile_section_info): Likewise.
1599         (maint_obj_section_from_bfd_section): New function.
1600         (print_bfd_section_info_maybe_relocated): New function.
1601         (maintenance_info_sections): Add header comment, always use
1602         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1603
1604 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1605
1606         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1607         inner scope, add check that the objfile has psymtabs before
1608         checking psymtabs_addrmap.
1609         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1610
1611 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1612
1613         * NEWS: Announce that Ada task names are now shown at more places,
1614         and between quotes (except in info task output).
1615         * gdb/ada-tasks.c (task_to_str): New function.
1616         (display_current_task_id): Call task_to_str.
1617         (task_command_1): Likewise.
1618         (print_ada_task_info): In non-mi mode, Properly align headers and data
1619         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1620
1621 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1622
1623         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1624         prstatus.pr_lwp.pr_info instead of making it up.
1625
1626 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1627
1628         * auto-load.c (auto_load_expand_dir_vars): Update.
1629         * defs.h (gdb_datadir): Change to std::string.
1630         (python_libdir): Likewise.
1631         (relocate_gdb_directory): Change return type to std::string.
1632         * guile/guile.c (gdbscm_data_directory): Update.
1633         (initialize_scheme_side): Update.
1634         * jit.c (jit_reader_dir): Change to std::string.
1635         (jit_reader_load_command): Update.
1636         * main.c (gdb_datadir): Change to std::string.
1637         (python_libdir): Likewise.
1638         (set_gdb_data_directory): Update.
1639         (relocate_path): Change to return std::string.
1640         (relocate_gdb_directory): Change to return std::string.
1641         (relocate_gdbinit_path_maybe_in_datadir): Update.
1642         (captured_main_1): Update.
1643         * python/python.c (do_start_initialization): Update.
1644         * top.c (show_gdb_datadir): Update.
1645         * xml-syscall.c (xml_init_syscalls_info): Update.
1646         (init_syscalls_info): Update.
1647
1648 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1649
1650         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1651         out of get_init_files.
1652         (get_init_files): Update.
1653
1654 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1655
1656         * main.c (get_init_files): Change to use std::string.
1657         (captured_main_1): Update.
1658         (print_gdb_help): Update.
1659
1660 2019-09-11  Ali Tamur  <tamur@google.com>
1661
1662         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1663         implementation.
1664
1665 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1666
1667         * dbxread.c (read_dbx_symtab): Update.
1668         * dwarf2read.c (load_partial_dies): Update.
1669         * mdebugread.c (parse_partial_symbols): Update.
1670         (handle_psymbol_enumerators): Update.
1671         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1672         * psymtab.c (add_psymbol_to_bcache): Likewise.
1673         (add_psymbol_to_list): Likewise.
1674         * symtab.c (symbol_set_names): Likewise.
1675         * symtab.h (symbol_set_names): Likewise.
1676         * xcoffread.c (scan_xcoff_symtab): Update.
1677
1678 2019-09-11  Tom Tromey  <tom@tromey.com>
1679
1680         * symfile-mem.c (symbol_file_add_from_memory): Use
1681         bfd_set_filename.
1682         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1683         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1684
1685 2019-09-10  Tom Tromey  <tromey@adacore.com>
1686
1687         * dwarf-index-write.c (write_psymbols): Extend error message.
1688         (debug_names::insert): Add Ada code.
1689         (debug_names::write_psymbols): Remove Ada check.
1690         (debug_names) <m_string_obstack>: New member.
1691         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1692         (gdb_index_symbol_name_matcher::matches): Remove.
1693         (mapped_index_base::find_name_components_bounds): Add "lang"
1694         parameter.
1695         (mapped_index_base::build_name_components): Also split names
1696         according to Ada syntax.
1697         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1698         type of "match_callback".
1699         (check_match, check_find_bounds_finds)
1700         (dw2_expand_symtabs_matching): Update.
1701         (dw2_debug_names_iterator): Add new constructor.
1702         (dw2_debug_names_map_matching_symbols): New function.
1703         (dw2_debug_names_expand_symtabs_matching): Update.
1704         (dwarf2_debug_names_functions): Use
1705         dw2_debug_names_map_matching_symbols.
1706
1707 2019-09-10  Tom Tromey  <tromey@adacore.com>
1708
1709         * dwarf2read.c (dw2_get_file_names_reader): Add the
1710         CU's file name to the results.
1711
1712 2019-09-10  Tom Tromey  <tromey@adacore.com>
1713
1714         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1715         map_matching_symbols.  Update.
1716         * dwarf2read.c (dw2_map_matching_symbols): Update.
1717         * psymtab.c (match_partial_symbol): Change type; update.
1718         (psym_map_matching_symbols): Likewise.
1719         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1720         type; update.
1721         * symfile.h (struct quick_symbol_functions)
1722         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1723         Remove "match".
1724
1725 2019-09-10  Tom Tromey  <tromey@adacore.com>
1726
1727         * psymtab.c (map_block): Remove.
1728         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1729         * symtab.c (iterate_over_symbols_terminated): New function.
1730         * symtab.c (iterate_over_symbols_terminated): Declare.
1731
1732 2019-09-10  Tom Tromey  <tromey@adacore.com>
1733
1734         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1735         * language.h (struct language_defn) <la_iterate_over_symbols>:
1736         Return bool.
1737         * symtab.c (iterate_over_symbols): Return bool.
1738         * symtab.h (iterate_over_symbols): Return bool.
1739
1740 2019-09-10  Tom Tromey  <tromey@adacore.com>
1741
1742         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1743         (add_nonlocal_symbols): Update.
1744         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1745         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1746         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1747         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1748         Change type of "callback".  Remove "data".
1749
1750
1751 2019-09-09  Ali Tamur  <tamur@google.com>
1752
1753         * dwarf2read.c (comp_unit_head): Update comment.
1754         (dwarf2_dwo_name): New function declaration.
1755         (dwarf_unit_type_name): New function declaration.
1756         (read_comp_unit_head): Add support for new compilation units,
1757         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1758         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1759         (currently named as "signature") in their header. Also clarify error
1760         messages.
1761         (lookup_dwo_id): New function. Returns the dwo id of the given
1762         compile unit.
1763         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1764         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1765         functions.
1766         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1767         (dwarf2_dwo_name): Get the dwo name if present.
1768         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1769         purposes.
1770
1771 2019-09-09  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1774
1775 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1776
1777         * python/python.c (do_start_initialization): Make progname_copy static,
1778         to avoid a leak report.
1779
1780 2019-09-08  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1783
1784 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1785
1786         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1787         Change type to gdb::optional<block_enum>.
1788         (dw2_symtab_iter_init): Change block_index parameter type
1789         to gdb::optional<block_enum>.
1790         (dw2_lookup_symbol): Change block_index parameter
1791         type to block_enum.c
1792         (dw2_debug_names_lookup_symbol): Likewise.
1793         * psymtab.c (psym_lookup_symbol): Likewise.
1794         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1795         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1796         Likewise.
1797
1798 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1799
1800         * defs.h (relocate_gdb_directory): Change int to bool in
1801         signature and rename flag to relocatable.
1802         * main.c (relocate_path): Likewise.
1803         (relocate_gdb_directory): Likewise.
1804
1805 2019-09-06  Alan Modra  <amodra@gmail.com>
1806
1807         * coffread.c (coff_symfile_read): Constify filename variable.
1808         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1809         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1810         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1811         * solib.c (reload_shared_libraries_1): Likewise.
1812         * symfile.c (reread_symbols): Likewise.
1813         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1814         * solib-darwin.c (darwin_bfd_open): Likewise.
1815         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1816
1817 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1818
1819         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1820         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1821
1822 2019-09-03  Tom Tromey  <tromey@adacore.com>
1823
1824         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1825         types.
1826         (has_negatives): Unbias a range type bound.
1827         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1828         * gdbtypes.c (operator==): Handle new field.
1829         (create_range_type): Add "bias" parameter.
1830         (create_static_range_type, resolve_dynamic_range): Update.
1831         * gdbtypes.h (struct range_bounds) <bias>: New member.
1832         (create_range_type): Add bias parameter.
1833         * printcmd.c (print_scalar_formatted): Unbias range types.
1834         * value.c (unpack_long): Unbias range types.
1835         (pack_long): Bias range types.
1836
1837 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1838
1839         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1840         probe arguments.
1841
1842 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1843
1844         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1845         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1846         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1847         (compile_probe_arg): Likewise.
1848         * probe.h (get_argument_count): Likewise.
1849         * solib-svr4.c (solib_event_probe_action): Likewise.
1850         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1851
1852 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1853
1854         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1855         code to here...
1856         (svr4_create_solib_event_breakpoints): ...from here.
1857
1858 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1859
1860         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1861         suffix from warning message.
1862
1863 2019-08-30  Tom Tromey  <tom@tromey.com>
1864
1865         * tui/tui-winsource.h (struct tui_source_window_base)
1866         <refresh_all>: Don't declare.
1867         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1868         Remove.
1869         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1870         tui_show_locator_content.
1871         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1872         declare.
1873         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1874         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1875         declare.
1876
1877 2019-08-30  Tom Tromey  <tom@tromey.com>
1878
1879         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1880
1881 2019-08-30  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1884         Remove unnecessary forward declarations.
1885
1886 2019-08-30  Tom Tromey  <tom@tromey.com>
1887
1888         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1889         rerender.
1890         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1891         tui_show_locator_content.
1892
1893 2019-08-30  Tom Tromey  <tom@tromey.com>
1894
1895         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1896         (tui_locator_window::rerender): Rewrite using body of previous
1897         tui_show_locator_content.
1898
1899 2019-08-30  Tom Tromey  <tom@tromey.com>
1900
1901         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1902         set_locator_fullname>: New methods.
1903         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1904         Rename from tui_set_locator_fullname.
1905         (tui_locator_window::set_locator_info): Rename from
1906         tui_set_locator_info.  Return bool.
1907         (tui_update_locator_fullname, tui_show_frame_info): Update.
1908
1909 2019-08-30  Tom Tromey  <tom@tromey.com>
1910
1911         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1912
1913 2019-08-30  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1916         call touchwin.
1917
1918 2019-08-30  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-wingeneral.c (box_win): Assume win_info and
1921         win_info->handle cannot be NULL.
1922
1923 2019-08-30  Tom Tromey  <tom@tromey.com>
1924
1925         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1926         refresh_window>: Declare.
1927         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1928         resize.
1929         (tui_data_item_window::rerender): Rename from
1930         tui_display_register.
1931         (tui_data_item_window::refresh_window): New method.
1932         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1933         no-op.
1934
1935 2019-08-30  Tom Tromey  <tom@tromey.com>
1936
1937         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1938         regs_column_count, current_group>: Move later.  Now private.
1939         <get_current_group>: New method.
1940         * tui/tui-regs.c (tui_reg_command): Update.
1941         * tui/tui-layout.c (tui_set_layout): Update.
1942
1943 2019-08-30  Tom Tromey  <tom@tromey.com>
1944
1945         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1946         (tui_data_window::rerender): Don't call
1947         check_and_display_highlight_if_needed.
1948         (tui_data_window::refresh_all): Remove call to
1949         erase_data_content.
1950
1951 2019-08-30  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1954         (tui_data_window::display_registers_from)
1955         (tui_data_window::display_reg_element_at_line)
1956         (tui_data_window::display_registers_from_line): Remove checks of
1957         "empty".
1958
1959 2019-08-30  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1962         Don't declare.
1963         * tui/tui-regs.c (tui_data_window::show_registers): Call
1964         rerender.
1965         (tui_data_window::rerender): Rename from display_all_data.
1966         (tui_data_window::rerender): Remove old implementation.
1967
1968 2019-08-30  Tom Tromey  <tom@tromey.com>
1969
1970         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1971         text.
1972         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1973
1974 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1975             Sergio Durigan Junior  <sergiodj@redhat.com>
1976
1977         PR win32/24284
1978         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1979
1980 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1981
1982         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1983         when searching for types.
1984
1985 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1986
1987         * f-lang.c (f_language_defn): Use f_print_typedef.
1988         * f-lang.h (f_print_typedef): Declare.
1989         * f-typeprint.c (f_print_typedef): Define.
1990
1991 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1992
1993         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1994
1995 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1996
1997         * cli/cli-utils.c (info_print_options_defs): Delete.
1998         (make_info_print_options_def_group): Delete.
1999         (extract_info_print_options): Delete.
2000         (info_print_command_completer): Delete.
2001         (info_print_args_help): Add extra parameter, and optionally
2002         include text about -n flag.
2003         * cli/cli-utils.h (struct info_print_options): Delete.
2004         (extract_info_print_options): Delete declaration.
2005         (info_print_command_completer): Delete declaration.
2006         (info_print_args_help): Add extra parameter, extend header
2007         comment.
2008         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2009         search_symbols.
2010         * stack.c (struct info_print_options): New type.
2011         (info_print_options_defs): New file scoped variable.
2012         (make_info_print_options_def_group): New static function.
2013         (info_print_command_completer): New static function.
2014         (info_locals_command): Update to use new local functions.
2015         (info_args_command): Likewise.
2016         (_initialize_stack): Add extra parameter to calls to
2017         info_print_args_help.
2018         * symtab.c (search_symbols): Add extra parameter, use this to
2019         possibly excluse non-debug symbols.
2020         (symtab_symbol_info): Add extra parameter, which is passed on to
2021         search_symbols.
2022         (struct info_print_options): New type.
2023         (info_print_options_defs): New file scoped variable.
2024         (make_info_print_options_def_group): New static function.
2025         (info_print_command_completer): New static function.
2026         (info_variables_command): Update to use local functions, and pass
2027         extra parameter through to symtab_symbol_info.
2028         (info_functions_command): Likewise.
2029         (info_types_command): Pass additional argument through to
2030         symtab_symbol_info.
2031         (rbreak_command): Pass extra argument to search_symbols.
2032         (_initialize_symtab): Add extra arguments for calls to
2033         info_print_args_help, and update help text for 'info variables',
2034         'whereis', and 'info functions' commands.
2035         * symtab.h (search_symbols): Add extra argument to declaration.
2036         * NEWS: Mention new flags.
2037
2038 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2039
2040         * symtab.c (lookup_static_symbol): Call the new function (and move
2041         it down to be next to lookup_global_symbol).
2042         (struct global_sym_lookup_data): Add block_enum member and rename to...
2043         (struct global_or_static_sym_lookup_data): ...this.
2044         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2045         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2046         (lookup_symbol_global_or_static_iterator_cb): ...this.
2047         (lookup_global_or_static_symbol): New function.
2048         (lookup_global_symbol): Call new function.
2049
2050 2019-08-26  Tom de Vries  <tdevries@suse.de>
2051
2052         PR c++/24852
2053         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2054         when pc_probe.prob == NULL.
2055
2056 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2057
2058         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2059         variable symbol_linkage to symbol_linkage_.
2060
2061 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2062
2063         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2064         represent whether the symbol is static, dynamic, or we don't
2065         know.
2066
2067 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2068
2069         * gdb/rx-tdep.c (rx_register_names): New.
2070         (rx_register_name): Delete.
2071         (rx_psw_type): Delete.
2072         (rx_fpsw_type): Delete.
2073         (rx_register_type): Delete.
2074         (rx_gdbarch_init): Convert target-descriptions.
2075         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2076         * gdb/features/Makefile: Add rx.xml.
2077         * gdb/features/rx.xml: New.
2078         * gdb/features/rx.c: Generated.
2079         * gdb/NEWS: Mention target description support.
2080
2081 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2082
2083         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2084         *slot_ptr.
2085
2086 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2087
2088         * configure.ac: Don't check for 'dlfcn.h' (moved to
2089         gdbsupport/common.m4).
2090         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2091         'gdbsupport/'.
2092         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2093         * compile/compile-c-support.c: Include
2094         'gdbsupport/gdb-dlfcn.h'.
2095         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2096         * gdb-dlfcn.c: Move to...
2097         * gdbsupport/gdb-dlfcn.c: ... here.
2098         * gdb-dlfcn.h: Move to...
2099         * gdbsupport/gdb-dlfcn.h: ... here.
2100
2101 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2102
2103         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2104         the offset field signed.
2105
2106 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2107
2108         * python/lib/gdb/__init__.py (_execute_file): New function.
2109         * python/python.c (python_run_simple_file): Call gdb._execute_file
2110         on Windows.
2111
2112 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2113
2114         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2115         all uses as this was never set to anything but a zero value.
2116
2117 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2118
2119         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2120
2121 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2122
2123         * tui/tui-data.h (tui_gen_win_info): Add an =default
2124         move constructor, required by some GCC versions.
2125
2126 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2127
2128         * go32-nat.c (go32_sysinfo): Add hygon_p.
2129
2130 2019-08-20  Tom Tromey  <tom@tromey.com>
2131
2132         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2133         line_from_reg_element_no, first_reg_element_no_inline,
2134         display_all_data, delete_data_content_windows,
2135         erase_data_content>: Now private.
2136
2137 2019-08-20  Tom Tromey  <tom@tromey.com>
2138
2139         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2140         (tui_unhighlight_win, tui_highlight_win)
2141         (tui_win_info::make_window): Update.
2142         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2143
2144 2019-08-20  Tom Tromey  <tom@tromey.com>
2145
2146         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2147         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2148         (MAX_PID_WIDTH): Move to tui-stack.c.
2149         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2150         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2151         (MAX_PID_WIDTH): Move from tui-data.h.
2152
2153 2019-08-20  Tom Tromey  <tom@tromey.com>
2154
2155         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2156         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2157         (box_win): Update.
2158         (tui_gen_win_info::make_window): Rename from tui_make_window.
2159         (tui_win_info::make_window): New method.
2160         (tui_gen_win_info::make_visible): Update.
2161         * tui/tui-source.c (tui_source_window::set_contents): Update.
2162         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2163         (tui_data_window::display_registers_from): Update.
2164         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2165         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2166         Declare.
2167         <can_box>: Remove.
2168         <title>: Remove.
2169         (struct tui_win_info) <make_window>: Declare.
2170         <can_box>: Now virtual.
2171         <title>: New member.
2172         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2173         * tui/tui-command.c (tui_cmd_window::resize): Update.
2174
2175 2019-08-20  Tom Tromey  <tom@tromey.com>
2176
2177         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2178         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2179         (tui_data_window::check_register_values): Update.
2180
2181 2019-08-20  Tom Tromey  <tom@tromey.com>
2182
2183         * tui/tui-regs.h (struct tui_data_window): Use
2184         DISABLE_COPY_AND_ASSIGN.
2185         <regs_content>: Change type, removing unique_ptr.
2186         <tui_data_window>: Add move constructor.
2187         * tui/tui-regs.c (tui_data_window::show_registers)
2188         (tui_data_window::show_register_group)
2189         (tui_data_window::display_registers_from)
2190         (tui_data_window::display_registers_from)
2191         (tui_data_window::first_data_item_displayed)
2192         (tui_data_window::delete_data_content_windows)
2193         (tui_data_window::rerender, tui_data_window::refresh_window)
2194         (tui_data_window::check_register_values): Update.
2195
2196 2019-08-20  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2199         show_register_group>: Declare.
2200         (tui_show_register_group): Don't declare.
2201         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2202         tui_show_registers.
2203         (tui_data_window::show_register_group): Rename from
2204         tui_show_register_group.
2205         (tui_data_window::check_register_values, tui_reg_command):
2206         Update.
2207         * tui/tui-layout.c (tui_set_layout): Update.
2208
2209 2019-08-20  Tom Tromey  <tom@tromey.com>
2210
2211         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2212         Declare.
2213         (tui_check_register_values): Don't declare.
2214         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2215         from tui_check_register_values.
2216         * tui/tui-hooks.c (tui_register_changed): Update.
2217
2218 2019-08-20  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-regs.c (tui_reg_layout): Move later.
2221         (tui_show_registers): Don't enable TUI mode or change layout.
2222
2223 2019-08-20  Tom Tromey  <tom@tromey.com>
2224
2225         * tui/tui-regs.h (struct tui_data_item_window)
2226         <~tui_data_item_window>: Remove.
2227         <content>: Now a unique_xmalloc_ptr.
2228         * tui/tui-regs.c (tui_register_format): Return a
2229         unique_xmalloc_ptr.
2230         (tui_get_register): Update.
2231         (~tui_data_item_window): Remove.
2232         (tui_data_window::display_registers_from, tui_display_register):
2233         Update.
2234         * tui/tui-io.h (tui_expand_tabs): Update.
2235         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2236         Remove "col" parameter.
2237
2238 2019-08-20  Tom Tromey  <tom@tromey.com>
2239
2240         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2241         field.
2242         * tui/tui-regs.c (~tui_data_item_window): Update.
2243
2244 2019-08-20  Tom Tromey  <tom@tromey.com>
2245
2246         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2247         earlier.
2248
2249 2019-08-20  Tom Tromey  <tom@tromey.com>
2250
2251         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2252
2253 2019-08-20  Tom Tromey  <tom@tromey.com>
2254
2255         * tui/tui-source.h (struct tui_source_window): Update.
2256         * tui/tui-regs.c (tui_show_registers): Update.
2257         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2258         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2259         (NO_REGS_STRING): Remove defines.
2260
2261 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2262
2263         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2264         unnecessary thread walk if remote doesn't support the packet.
2265
2266 2019-08-19  Tom Tromey  <tromey@adacore.com>
2267
2268         * python/py-value.c (value_has_field): Fix indentation.
2269
2270 2019-08-19  Tom Tromey  <tromey@adacore.com>
2271
2272         * printcmd.c (do_one_display, info_display_command): Update.
2273         * block.h (contained_in): Return bool.  Add allow_nested
2274         parameter.
2275         * block.c (contained_in): Return bool.  Add allow_nested
2276         parameter.
2277
2278 2019-08-19  Tom Tromey  <tom@tromey.com>
2279
2280         * configure: Rebuild.
2281         * configure.ac: Disallow the combination of -static-libstdc++ and
2282         source highlight.
2283         * source-cache.c (get_language_name): Handle rust.
2284         (source_cache::get_source_lines): Ignore highlighting exceptions.
2285
2286 2019-08-16  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2289         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2290         (struct tui_source_window_base) <make_visible, refresh_window,
2291         resize>: Remove methods.
2292         <execution_info>: Remove field.
2293         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2294         (tui_show_source_line, tui_source_window_base)
2295         (~tui_source_window_base): Update.
2296         (tui_source_window_base::resize)
2297         (tui_source_window_base::make_visible)
2298         (tui_source_window_base::refresh_window): Remove.
2299         (tui_source_window_base::update_exec_info): Update.
2300         * tui/tui-source.c (tui_source_window::set_contents): Update.
2301         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2302
2303 2019-08-16  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2306         deprecated_query_hook.
2307
2308 2019-08-16  Tom Tromey  <tom@tromey.com>
2309
2310         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2311         (tui_update_source_windows_with_line): Update.
2312         * tui/tui-source.h (struct tui_source_window)
2313         <show_symtab_source>: Declare.
2314         (tui_show_symtab_source): Don't declare.
2315         * tui/tui-source.c (tui_show_symtab_source): Rename from
2316         tui_show_symtab_source.
2317
2318 2019-08-16  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-winsource.h (struct tui_source_window_base)
2321         <set_contents>: Declare.
2322         * tui/tui-winsource.c
2323         (tui_source_window_base::update_source_window_as_is): Update.
2324         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2325         Declare.
2326         (tui_set_source_content): Don't declare.
2327         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2328         tui_set_source_content.
2329         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2330         Declare.
2331         (tui_set_disassem_content): Don't declare.
2332         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2333         tui_set_disassem_content.
2334
2335 2019-08-16  Tom Tromey  <tom@tromey.com>
2336
2337         * tui/tui-winsource.h (struct tui_source_window_base)
2338         <update_breakpoint_info>: Declare.
2339         (tui_update_breakpoint_info): Don't declare.
2340         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2341         (tui_update_all_breakpoint_info): Update.
2342         (tui_source_window_base::update_breakpoint_info): Rename from
2343         tui_update_breakpoint_info.
2344         (tui_source_window_base::update_exec_info): Update.
2345
2346 2019-08-16  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-winsource.h (struct tui_source_window_base)
2349         <update_source_window>: Declare.
2350         (tui_update_source_window): Don't declare.
2351         * tui/tui-winsource.c
2352         (tui_source_window_base::update_source_window): Rename from
2353         tui_update_source_window.
2354         (tui_source_window_base::rerender): Update.
2355         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2356         * tui/tui-disasm.c (tui_show_disassem)
2357         (tui_show_disassem_and_update_source)
2358         (tui_disasm_window::maybe_update): Update.
2359
2360 2019-08-16  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-winsource.h (struct tui_source_window_base)
2363         <update_source_window_as_is>: Declare.
2364         (tui_update_source_window_as_is): Don't declare.
2365         * tui/tui-winsource.c (tui_update_source_window): Update
2366         (tui_source_window_base::update_source_window_as_is): Rename from
2367         tui_update_source_window_as_is.
2368         (tui_source_window_base::refill): Update.
2369         * tui/tui-source.c (tui_show_symtab_source): Update.
2370         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2371         Update.
2372
2373 2019-08-16  Tom Tromey  <tom@tromey.com>
2374
2375         * tui/tui-winsource.h (tui_update_source_window)
2376         (tui_update_source_window_as_is): Remove "noerror" parameter.
2377         * tui/tui-winsource.c (tui_update_source_window)
2378         (tui_update_source_window_as_is): Remove "noerror" parameter.
2379         (tui_update_source_windows_with_addr)
2380         (tui_update_source_windows_with_line)
2381         (tui_source_window_base::rerender)
2382         (tui_source_window_base::refill): Update.
2383         * tui/tui-source.h (tui_set_source_content)
2384         (tui_show_symtab_source): Remove "noerror" parameter.
2385         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2386         parameter.
2387         (tui_show_symtab_source): Likewise.
2388         (tui_source_window::maybe_update): Update.
2389         * tui/tui-disasm.c (tui_show_disassem)
2390         (tui_show_disassem_and_update_source)
2391         (tui_disasm_window::do_scroll_vertical)
2392         (tui_disasm_window::maybe_update): Update.
2393
2394 2019-08-16  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui.c (tui_is_window_visible): Update.
2397         * tui/tui-wingeneral.c (tui_make_window)
2398         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2399         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2400         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2401         (tui_set_win_height_command, parse_scrolling_args): Update.
2402         * tui/tui-source.c (tui_source_window::style_changed): Update.
2403         * tui/tui-regs.c (tui_show_registers)
2404         (tui_data_window::first_data_item_displayed)
2405         (tui_data_window::delete_data_content_windows)
2406         (tui_check_register_values, tui_reg_command): Update.
2407         * tui/tui-disasm.c (tui_show_disassem): Update.
2408         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2409         method.
2410         <is_visible>: Remove field.
2411         * tui/tui-data.c (tui_next_win, tui_prev_win)
2412         (tui_delete_invisible_windows): Update.
2413
2414 2019-08-16  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-winsource.h (struct tui_source_window_base)
2417         <m_has_locator>: Remove.
2418         * tui/tui-layout.c (show_source_disasm_command, show_data)
2419         (show_source_or_disasm_and_command): Update.
2420
2421 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2422
2423         * NEWS (Other MI changes): New subsection.
2424         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2425         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2426         * arch-utils.c (default_get_pc_address_flags): New function.
2427         * arch-utils.h (default_get_pc_address_flags): New declaration.
2428         * gdbarch.sh: Add get_pc_address_flags.
2429         * gdbarch.c: Regenerate.
2430         * gdbarch.h: Likewise.
2431         * stack.c (print_pc): New function.
2432         (print_frame_info) (print_frame): Call print_pc.
2433
2434 2019-08-16  Tom de Vries  <tdevries@suse.de>
2435
2436         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2437         print_objfile_section_info.
2438
2439 2019-08-15  Tom Tromey  <tom@tromey.com>
2440
2441         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2442         calling update_cmdwin_start_line.
2443         * tui/tui-winsource.h (struct tui_source_window_base)
2444         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2445         <rerender>: Declare.
2446         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2447         Call rerender.
2448         (tui_source_window_base::set_new_height): Remove.
2449         (tui_source_window_base::rerender): Rename from
2450         do_make_visible_with_new_height.
2451         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2452         resize method.
2453         (tui_win_info::make_invisible_and_set_new_height)
2454         (tui_win_info::make_visible_with_new_height): Remove.
2455         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2456         Declare.
2457         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2458         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2459         do_make_visible_with_new_height>: Don't declare.
2460         <rerender>: Declare.
2461         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2462         set_new_height.
2463         (tui_data_window::do_make_visible_with_new_height): Remove.
2464         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2465         call tui_show_locator_content.
2466         (tui_gen_win_info::resize): Call rerender.
2467         (show_source_or_disasm_and_command): Don't call
2468         tui_show_locator_content.
2469         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2470         method.
2471         (struct tui_win_info) <rerender>: Declare.
2472         <set_new_height, make_invisible_and_set_new_height,
2473         make_visible_with_new_height>: Don't declare.
2474         * tui/tui-data.c (tui_win_list::rerender): New method.
2475         * tui/tui-command.h (struct tui_cmd_window)
2476         <do_make_visible_with_new_height>: Don't declare.
2477         * tui/tui-command.c
2478         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2479
2480 2019-08-15  Tom Tromey  <tromey@adacore.com>
2481
2482         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2483         * ada-lang.c (ada_enum_name): Likewise.
2484
2485 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2486
2487         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2488         leading underscore.
2489         (GdbOutputErrorFile): Likewise.
2490         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2491         accordingly.
2492         (execute_unwinders): Rename to have a leading underscore.
2493         (auto_load_packages): Likewise.
2494         (global scope): Adjust call to auto_load_packages accordingly.
2495         (GdbSetPythonDirectory): Likewise.
2496         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2497         instead of execute_unwinders.
2498
2499 2019-08-15  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2502         (show_data): Don't change window visibility.
2503         (tui_gen_win_info::resize): Remove special case for command
2504         window.  Use wresize, when available.
2505         (show_source_or_disasm_and_command): Don't change window
2506         visibility.
2507         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2508         <make_visible>: New method.
2509         * tui/tui-command.c (tui_cmd_window::resize): New method.
2510
2511 2019-08-15  Tom Tromey  <tom@tromey.com>
2512
2513         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2514         (struct tui_source_windows): New.
2515         * tui/tui-winsource.c (tui_display_main): Update.
2516         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2517         (new_height_ok, parse_scrolling_args): Update.
2518         * tui/tui-layout.c (show_layout, show_data): Update.
2519         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2520         (tui_add_to_source_windows): Don't declare.
2521         * tui/tui-data.c (source_windows, tui_source_windows)
2522         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2523
2524 2019-08-15  Tom Tromey  <tom@tromey.com>
2525
2526         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2527         Rename from reset.
2528         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2529         * tui/tui-layout.c (show_source_disasm_command, show_data):
2530         Update.
2531         (tui_gen_win_info::resize): Rename.
2532         (show_source_or_disasm_and_command): Update.
2533         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2534         reset.
2535
2536 2019-08-15  Tom Tromey  <tom@tromey.com>
2537
2538         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2539         * tui/tui-interp.c (tui_interp::init): Don't call
2540         tui_initialize_static_data.
2541         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2542
2543 2019-08-15  Tom Tromey  <tom@tromey.com>
2544
2545         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2546         examine tui_win_list.
2547
2548 2019-08-15  Tom Tromey  <tom@tromey.com>
2549
2550         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2551         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2552         tui_clear_source_content.
2553         (tui_clear_source_content): Remove.
2554         (tui_source_window_base::do_erase_source_content): Hoist call to
2555         content.clear().
2556         * tui/tui-stack.c (tui_show_frame_info): Don't call
2557         tui_clear_source_content.
2558
2559 2019-08-15  Tom Tromey  <tom@tromey.com>
2560
2561         * tui/tui-winsource.h (struct tui_source_window_base)
2562         <do_erase_source_content>: New method.
2563         <erase_source_content>: New method.
2564         (tui_erase_source_content): Don't declare.
2565         * tui/tui-winsource.c (tui_clear_source_content): Update.
2566         (tui_source_window_base::do_erase_source_content): Rename from
2567         tui_erase_source_content.
2568         (tui_source_window_base::show_source_content): Update.
2569         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2570         * tui/tui-source.h (struct tui_source_window)
2571         <erase_source_content>: New method.
2572         * tui/tui-disasm.h (struct tui_disasm_window)
2573         <erase_source_content>: New method.
2574
2575 2019-08-15  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2578         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2579         constructor.
2580         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2581         * tui/tui-source.c (tui_set_source_content): Update.
2582         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2583
2584 2019-08-15  Tom Tromey  <tom@tromey.com>
2585
2586         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2587         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2588         tui-source.c.
2589         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2590         Declare.
2591         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2592         method.
2593         (tui_source_window::maybe_update): Update.
2594
2595 2019-08-15  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2598         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2599         tui-disasm.c.
2600         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2601         Declare.
2602         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2603         method.
2604         (tui_disasm_window::maybe_update): Update.
2605
2606 2019-08-15  Tom Tromey  <tom@tromey.com>
2607
2608         * tui/tui-winsource.h (struct tui_source_window_base)
2609         <maybe_update>: Declare.
2610         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2611         method.
2612         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2613         Declare.
2614         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2615         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2616         Declare.
2617         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2618
2619 2019-08-15  Tom Tromey  <tom@tromey.com>
2620
2621         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2622
2623 2019-08-15  Tom Tromey  <tom@tromey.com>
2624
2625         * tui/tui-wingeneral.c: Include tui-stack.h.
2626         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2627         (struct tui_locator_window): Move from tui-data.h.
2628         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2629         (tui_initialize_static_data): Move from tui-data.c.
2630         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2631         (struct tui_locator_window): Move to tui-stack.c.
2632         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2633         (tui_initialize_static_data): Move to tui-stack.c.
2634
2635 2019-08-15  Tom Tromey  <tom@tromey.com>
2636
2637         * tui/tui-layout.c (show_source_disasm_command)
2638         (show_source_or_disasm_and_command): Use make_visible method, not
2639         tui_make_window.
2640         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2641         Remove.
2642
2643 2019-08-15  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-wingeneral.h (tui_make_window): Update.
2646         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2647         parameter.
2648         (tui_gen_win_info::make_visible): Update.
2649         * tui/tui-regs.c (tui_data_window::display_registers_from):
2650         Update.
2651         * tui/tui-layout.c (show_source_disasm_command)
2652         (show_source_or_disasm_and_command): Update.
2653         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2654         (enum tui_box): Remove.
2655         (struct tui_win_info) <can_box>: New method.
2656         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2657         method.
2658
2659 2019-08-15  Tom de Vries  <tdevries@suse.de>
2660
2661         * linux-nat-trad.c: Include gdbarch.h.
2662
2663 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2664
2665         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2666         register sizes.
2667
2668 2019-08-14  Tom Tromey  <tromey@adacore.com>
2669
2670         * darwin-nat.c: Include gdbarch.h.
2671         * darwin-nat-info.c: Include gdbarch.h.
2672
2673 2019-08-13  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2676         Remove.
2677         * tui/tui-data.c (tui_initialize_static_data): Update.
2678
2679 2019-08-13  Tom Tromey  <tom@tromey.com>
2680
2681         * tui/tui-winsource.h (struct tui_exec_info_window)
2682         <~tui_exec_info_window, maybe_allocate_content, get_content,
2683         m_content>: Remove.
2684         (struct tui_source_window_base) <set_exec_info_content,
2685         show_exec_info_content>: Don't declare.
2686         * tui/tui-winsource.c
2687         (tui_exec_info_window::maybe_allocate_content): Remove.
2688         (tui_source_window_base::update_exec_info): Rename from
2689         set_exec_info_content.
2690         (tui_source_window_base::show_exec_info_content)
2691         (tui_source_window_base::update_exec_info): Remove.
2692
2693 2019-08-13  Tom Tromey  <tom@tromey.com>
2694
2695         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2696         declare.
2697         * tui/tui-winsource.c (tui_update_source_window_as_is)
2698         (tui_update_source_windows_with_addr, tui_erase_source_content):
2699         Update.
2700         (tui_clear_exec_info_content): Remove.
2701
2702 2019-08-13  Tom Tromey  <tom@tromey.com>
2703
2704         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2705         declare.
2706         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2707         call tui_erase_exec_info_content.
2708         (tui_clear_exec_info_content): Rename from
2709         tui_erase_exec_info_content.
2710         (tui_clear_exec_info_content): Delete.
2711
2712 2019-08-13  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-winsource.h (struct tui_source_window_base)
2715         <show_exec_info_content>: Declare.
2716         (tui_show_exec_info_content): Don't declare.
2717         * tui/tui-winsource.c
2718         (tui_source_window_base::show_exec_info_content): Rename from
2719         tui_show_exec_info_content.
2720         (tui_source_window_base::update_exec_info): Update.
2721
2722 2019-08-13  Tom Tromey  <tom@tromey.com>
2723
2724         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2725         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2726         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2727         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2728         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2729         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2730         ... here.
2731
2732 2019-08-13  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-winsource.h (struct tui_source_window_base)
2735         <update_exec_info>: Declare.
2736         (tui_update_exec_info): Don't declare.
2737         * tui/tui-winsource.c (tui_update_source_window_as_is)
2738         (tui_source_window_base::refresh_all)
2739         (tui_update_all_breakpoint_info): Update.
2740         (tui_source_window_base::update_exec_info): Rename from
2741         tui_update_exec_info.
2742         * tui/tui-stack.c (tui_show_frame_info): Update.
2743
2744 2019-08-13  Tom Tromey  <tom@tromey.com>
2745
2746         * tui/tui-winsource.h (struct tui_source_window_base)
2747         <set_exec_info_content>: Declare.
2748         (tui_set_exec_info_content): Don't declare.
2749         * tui/tui-winsource.c
2750         (tui_source_window_base::set_exec_info_content): Rename from
2751         tui_set_exec_info_content.
2752         (tui_update_exec_info): Update.
2753
2754 2019-08-13  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-winsource.h (struct tui_source_window_base)
2757         <show_source_content>: Declare.
2758         (tui_show_source_content): Don't declare.
2759         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2760         (tui_source_window_base::show_source_content): Rename from
2761         tui_show_source_content.
2762         (tui_source_window_base::refresh_all): Update.
2763         * tui/tui-layout.c (show_source_disasm_command)
2764         (show_source_or_disasm_and_command): Update.
2765
2766 2019-08-13  Tom Tromey  <tom@tromey.com>
2767
2768         * tui/tui-winsource.c (tui_erase_source_content)
2769         (tui_show_source_content, tui_source_window_base::refresh_all):
2770         Update.
2771         * tui/tui-wingeneral.h
2772         (tui_check_and_display_highlight_if_needed): Don't declare.
2773         * tui/tui-wingeneral.c
2774         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2775         check_and_display_highlight_if_needed.
2776         * tui/tui-win.c (tui_rehighlight_all)
2777         (tui_win_info::make_visible_with_new_height): Update.
2778         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2779         (tui_data_window::erase_data_content)
2780         (tui_data_window::display_all_data): Update.
2781         * tui/tui-data.h (struct tui_win_info)
2782         <check_and_display_highlight_if_needed>: Declare.
2783
2784 2019-08-13  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-win.c (tui_resize_all): Call
2787         tui_delete_invisible_windows.
2788         * tui/tui-layout.c (show_layout): Call
2789         tui_delete_invisible_windows.
2790         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2791         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2792
2793 2019-08-13  Tom Tromey  <tom@tromey.com>
2794
2795         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2796         tui_add_win_to_layout.
2797
2798 2019-08-13  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2801         * tui/tui-layout.c (tui_default_win_height): Now static.
2802
2803 2019-08-13  Tom Tromey  <tom@tromey.com>
2804
2805         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2806         single switch.
2807         (show_source_disasm_command, show_source_or_disasm_and_command):
2808         Don't check current layout.
2809
2810 2019-08-13  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-wingeneral.c (make_all_visible): Remove.
2813         (tui_make_all_invisible): Simplify.
2814         * tui/tui-layout.c (tui_make_all_invisible): Move from
2815         tui-wingeneral.c; simplify.
2816         (show_layout): Hoist call to tui_make_all_invisible.
2817         (show_data): Don't call tui_make_all_invisible.
2818
2819 2019-08-13  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2822         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2823
2824 2019-08-13  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2827         tui-data.c.
2828         (show_source_disasm_command, show_data)
2829         (show_source_or_disasm_and_command): Don't use
2830         tui_set_current_layout_to.
2831         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2832         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2833         tui-layout.c.
2834         (tui_set_current_layout_to): Remove.
2835
2836 2019-08-13  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-layout.c (tui_set_layout): Update.
2839         * tui/tui-data.h (struct tui_layout_def): Remove.
2840         (tui_layout_def): Don't declare.
2841         * tui/tui-data.c (layout_def): Remove.
2842         (tui_layout_def): Remove.
2843
2844 2019-08-13  Tom Tromey  <tom@tromey.com>
2845
2846         * tui/tui-winsource.h (struct tui_source_window_base)
2847         <clear_detail>: No longer "override".
2848         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2849         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2850         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2851         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2852         Remove.
2853         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2854
2855 2019-08-13  Tom Tromey  <tromey@adacore.com>
2856
2857         * tracepoint.c: Don't include readline.h or history.h.
2858
2859 2019-08-12  Tom Tromey  <tom@tromey.com>
2860
2861         * configure: Rebuild.
2862         * configure.ac: Check for readline 7.
2863         * NEWS: Mention readline 7 requirement.
2864         * README: Update.
2865
2866 2019-08-12  Tom Tromey  <tom@tromey.com>
2867
2868         * mingw-hdep.c (gdb_select): Remove readline hack.
2869
2870 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2871
2872         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2873         when the function fails.
2874
2875 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2876
2877         * s390-tdep.c (s390_type_align): New function.
2878         (s390_gdbarch_init): Set it as type_align gdbarch method.
2879
2880 2019-08-09  Tom de Vries  <tdevries@suse.de>
2881
2882         PR gdb/24591
2883         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2884         pc_low with relocation offset.
2885
2886 2019-08-07  Tom Tromey  <tromey@adacore.com>
2887
2888         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2889         (print_frame_args): Update.
2890         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2891         Update.
2892         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2893         * frame.h (struct frame_arg): Add initializers.
2894         <error>: Now a unique_xmalloc_ptr.
2895
2896 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2897
2898         * NEWS: Expand the Pointer Authentication entry.
2899         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2900         (aarch64_frame_unmask_lr): ... to this.
2901         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2902         Call aarch64_frame_unmask_lr.
2903         * frame.c (struct frame_info): Add "masked" variable.
2904         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2905         (fprint_frame): Check for masked pc.
2906         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2907         declarations.
2908         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2909         * stack.c (print_frame): Check for masked pc.
2910
2911 2019-08-06  Tom Tromey  <tom@tromey.com>
2912
2913         * stabsread.c (patch_block_stabs, read_one_struct_field)
2914         (read_enum_type): Use obstack_strndup.
2915         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2916         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2917         * dwarf2read.c (guess_full_die_structure_name)
2918         (anonymous_struct_prefix): Use obstack_strndup.
2919         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2920         * c-exp.y (yylex): Use obstack_strndup.
2921         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2922         (write_var_or_type): Use obstack_strndup.
2923
2924 2019-08-06  Tom Tromey  <tom@tromey.com>
2925
2926         * symfile.c (reread_symbols): Use obstack_strdup.
2927         * stabsread.c (read_type): Use obstack_strdup.
2928         * gdb_obstack.h (obstack_strdup): New overload.
2929         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2930         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2931         (dwarf2_canonicalize_name): Use obstack_strdup.
2932         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2933         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2934         Use obstack_strdup.
2935
2936 2019-08-06  Tom Tromey  <tom@tromey.com>
2937
2938         * gdb_obstack.h (obstack_strdup): Define.
2939         * gdb_obstack.c (obstack_strdup): Don't define.
2940
2941 2019-08-06  Tom Tromey  <tom@tromey.com>
2942
2943         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2944         obstack_strdup.
2945         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2946         obstack_strdup.
2947         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2948         * stabsread.c (common_block_start): Use obstack_strdup.
2949         * objfiles.c (set_objfile_main_name, objfile): Use
2950         obstack_strdup.
2951         * namespace.c (add_using_directive): Use obstack_strdup.
2952         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2953         * jit.c (finalize_symtab): Use obstack_strdup.
2954         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2955         (guess_partial_die_structure_name, partial_die_info::fixup)
2956         (dwarf2_name): Use obstack_strdup.
2957         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2958         obstack_strdup.
2959         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2960         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2961         obstack_strdup.
2962         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2963
2964 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2965
2966         * unittests/help-doc-selftests.c: New file.
2967         * Makefile.in: Add the new file.
2968
2969 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2970
2971         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2972         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2973         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2974         the trailing '.' is not output, and the first character is uppercased.
2975         (print_help_for_command): Update call to print_doc_line.
2976         (print_doc_of_command): Likewise.
2977         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2978         * cli/cli-option.c (append_indented_doc): Do not append newline.
2979         (build_help_option): Append newline after first appended_indented_doc
2980         only if a second call is done.
2981         (build_help): Append 2 new lines before each option, except the first
2982         one.
2983         * compile/compile.c (_initialize_compile): Add new lines after
2984         %OPTIONS%, when not at the end of the help.
2985         Change help doc or code
2986         producing the help doc to respect the invariants.
2987         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2988         Also removed the new line after 'Options:', as all other commands
2989         do not put an empty line between 'Options:' and the first option.
2990         * printcmd.c (_initialize_printcmd): Likewise.
2991         * stack.c (_initialize_stack): Likewise.
2992         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2993         incorrectly telling COMMAND is optional.
2994         * ada-lang.c (_initialize_ada_language): Change help doc or code
2995         producing the help doc to respect the invariants.
2996         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2997         * breakpoint.c (_initialize_breakpoint): Likewise.
2998         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2999         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3000         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3001         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3002         _initialize_cli_style): Likewise.
3003         * corelow.c (core_target_info): Likewise.
3004         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3005         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3006         * filesystem.c (_initialize_filesystem): Likewise.
3007         * frame.c (_initialize_frame): Likewise.
3008         * gnu-nat.c (add_task_commands): Likewise.
3009         * infcall.c (_initialize_infcall): Likewise.
3010         * infcmd.c (_initialize_infcmd): Likewise.
3011         * interps.c (_initialize_interpreter): Likewise.
3012         * language.c (_initialize_language): Likewise.
3013         * linux-fork.c (_initialize_linux_fork): Likewise.
3014         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3015         * maint.c (_initialize_maint_cmds): Likewise.
3016         * memattr.c (_initialize_mem): Likewise.
3017         * printcmd.c (_initialize_printcmd): Likewise.
3018         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3019         _RegEx): Likewise.
3020         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3021         * record-btrace.c (_initialize_record_btrace): Likewise.
3022         * record-full.c (_initialize_record_full): Likewise.
3023         * record.c (_initialize_record): Likewise.
3024         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3025         * regcache.c (_initialize_regcache): Likewise.
3026         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3027         _initialize_remote): Likewise.
3028         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3029         * serial.c (_initialize_serial): Likewise.
3030         * skip.c (_initialize_step_skip): Likewise.
3031         * source.c (_initialize_source): Likewise.
3032         * stack.c (_initialize_stack): Likewise.
3033         * symfile.c (_initialize_symfile): Likewise.
3034         * symtab.c (_initialize_symtab): Likewise.
3035         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3036         * top.c (init_main): Likewise.
3037         * tracefile-tfile.c (tfile_target_info): Likewise.
3038         * tracepoint.c (_initialize_tracepoint): Likewise.
3039         * tui/tui-win.c (_initialize_tui_win): Likewise.
3040         * utils.c (add_internal_problem_command): Likewise.
3041         * valprint.c (value_print_option_defs): Likewise.
3042
3043 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3044
3045         PR build/24886
3046         * configure.ac: Drop enable-libmcheck support.
3047         * configure, config.in: Rebuild.
3048         * libmcheck.m4: Remove.
3049         * acinclude.m4: Don't include it.
3050         * Makefile.in: Don't distribute it.
3051         * top.c (print_gdb_configuration): Don't mention it.
3052
3053 2019-08-06  Tom Tromey  <tom@tromey.com>
3054
3055         * utils.c (set_output_style): Sometimes pass stream to
3056         emit_style_escape.
3057         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3058         * record-btrace.c (btrace_insn_history): Update.
3059         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3060         method.
3061         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3062         Update initializers.
3063         <m_uiout>: New field.
3064         <m_di>: Move lower.
3065         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3066         Remove "uiout" parameter.
3067         (dump_insns): Update.
3068         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3069         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3070
3071 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3072
3073         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3074         (error_in_psymtab_expansion): Likewise.
3075         (lookup_symbol_via_quick_fns): Likewise.
3076         (basic_lookup_transparent_type_quick): Likewise.
3077         (basic_lookup_transparent_type_1): Likewise.
3078
3079 2019-08-06  Tom Tromey  <tromey@adacore.com>
3080
3081         * source.c (last_source_error): Now bool.
3082         (print_source_lines_base): Make "noprint" bool.  Only open
3083         source file when last_source_visited changes.
3084
3085 2019-08-06  Tom Tromey  <tromey@adacore.com>
3086
3087         * annotate.c (annotate_source_line): Use g_source_cache.
3088         * source-cache.c (source_cache::get_plain_source_lines): Change
3089         parameters.  Populate m_offset_cache.
3090         (source_cache::ensure): New method.
3091         (source_cache::get_line_charpos): New method.
3092         (extract_lines): Move lower.  Change parameters.
3093         (source_cache::get_source_lines): Move lower.
3094         * source-cache.h (class source_cache): Update comment.
3095         <get_line_charpos>: New method.
3096         <get_source_lines>: Update comment.
3097         <clear>: Clear m_offset_cache.
3098         <get_plain_source_lines>: Change parameters.
3099         <ensure>: New method
3100         <m_offset_cache>: New member.
3101         * source.c (forget_cached_source_info_for_objfile): Update.
3102         (info_source_command): Use g_source_cache.
3103         (find_source_lines, open_source_file_with_line_charpos): Remove.
3104         (print_source_lines_base, search_command_helper): Use g_source_cache.
3105         * source.h (open_source_file_with_line_charpos): Don't declare.
3106         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3107         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3108         Use g_source_cache.
3109
3110 2019-08-06  Tom Tromey  <tromey@adacore.com>
3111
3112         * source-cache.c (source_cache::get_plain_source_lines):
3113         Remove "first_line" and "last_line" parameters.
3114         (source_cache::get_source_lines): Cache plain text.
3115         * source-cache.h (class source_cache)
3116         <get_plain_source_lines>: Update.
3117
3118 2019-08-06  Tom Tromey  <tromey@adacore.com>
3119
3120         * source-cache.c (extract_lines): No longer a method.
3121         Changed type of parameter.  Include final newline.
3122         (selftests::extract_lines_test): New function.
3123         (_initialize_source_cache): Likewise.
3124         * source-cache.h (class source_cache)
3125         <extract_lines>: Don't declare.
3126
3127 2019-08-06  Tom Tromey  <tromey@adacore.com>
3128
3129         * breakpoint.c (init_breakpoint_sal): Update.
3130         (breakpoint): Update.
3131         * breakpoint.h (struct breakpoint) <filter>: Now a
3132         unique_xmalloc_ptr.
3133
3134 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3135
3136         * NEWS: Mention dictionary access on blocks.
3137         * python/py-block.c (blpy_getitem): New function.
3138         (block_object_as_mapping): New struct.
3139         (block_object_type): Use new struct for tp_as_mapping field.
3140
3141 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3142
3143         * objfiles.h (objfile): Add a comment describing partial symbols.
3144
3145 2019-08-05  Tom Tromey  <tromey@adacore.com>
3146
3147         * compile/compile.c (_initialize_compile): Use _(), not N_().
3148         * thread.c (_initialize_thread): Use _(), not N_().
3149         * stack.c (_initialize_stack): Use _(), not N_().
3150         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3151
3152 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3153
3154         * dwarf2read.c (struct dw2_symtab_iterator):
3155         <want_specific_block>: Remove.
3156         <block_index>: Change type to gdb::optional.
3157         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3158         change type of BLOCK_INDEX parameter to gdb::optional.
3159         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3160         (dw2_lookup_symbol): Don't pass argument for
3161         WANT_SPECIFIC_BLOCK.
3162         (dw2_expand_symtabs_for_function): Don't pass argument for
3163         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3164         (class dw2_debug_names_iterator)
3165         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3166         parameter, change BLOCK_INDEX type to gdb::optional.
3167         <m_want_specific_block>: Remove.
3168         <m_block_index>: Change type to gdb::optional.
3169         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3170         gdb::optional.  Re-write in function of gdb::optional.
3171         (dw2_debug_names_lookup_symbol): Don't pass argument for
3172         WANT_SPECIFIC_BLOCK.
3173         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3174         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3175         BLOCK_INDEX.
3176
3177 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3178
3179         * NEWS: Mention changes to "info sources" command.
3180
3181 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3182
3183         * symtab.c (filename_partial_match_opts): New struct type.
3184         (struct output_source_filename_data): New members
3185         regexp, c_regexp, partial_match.
3186         (output_source_filename): Use new members to decide to print file.
3187         (info_sources_option_defs): New variable.
3188         (make_info_sources_options_def_group, print_info_sources_header,
3189         info_sources_command_completer):
3190         New functions.
3191         (info_sources_command): Read new optional arguments.
3192         (_initialize_symtab): Update info sources help.
3193
3194 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3195
3196         * ada-lang.c (exception_support_info_v0): Renamed from...
3197         (default_exception_support_info): ... this.  Create new
3198         definition for v1.
3199         (ada_has_this_exception_support): Look up catch_handlers_sym.
3200         (ada_exception_support_info_sniffer): Try v0 after default.
3201
3202 2019-08-01  Tom Tromey  <tromey@adacore.com>
3203
3204         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3205         gdbarch.h.
3206
3207 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3208
3209         * s12z-tdep.c: Fix include path for s12z-opc.h.
3210
3211 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3212
3213         * NEWS: Require GNU make 3.82.
3214
3215 2019-07-16  Tom Tromey  <tom@tromey.com>
3216
3217         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3218         declare.
3219
3220 2019-07-30  Tom Tromey  <tromey@adacore.com>
3221
3222         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3223
3224 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3225
3226         * printcmd.c (print_address_symbolic): Print negative offsets.
3227         (build_address_symbolic): Force signed arithmetic when computing
3228         offset.
3229
3230 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3231
3232         PR/24474: Add a function to lookup static variables.
3233         * NEWS: Mention this new function.
3234         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3235         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3236         * python/python.c (python_GdbMethods): Add new function.
3237
3238 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3239
3240         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3241         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3242         (objfpy_lookup_static_symbol): New function.
3243         (objfile_object_methods): Add new functions.
3244
3245 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3246
3247         * NEWS: Mention 'set|show print frame-info'.  Mention new
3248         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3249         backtrace argument.  Mention that python frame filtering code
3250         is now consistent with what 'backtrace' command prints.
3251
3252 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3253
3254         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3255         comments.
3256         (print_frame_info_auto, print_frame_info_source_line,
3257         print_frame_info_location, print_frame_info_source_and_location,
3258         print_frame_info_location_and_address, print_frame_info_short_location):
3259         New declarations.
3260         (struct frame_print_options): New member print_frame_info.
3261         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3262         * stack.h (get_user_print_what_frame_info): New declaration.
3263         (frame_show_address): New declaration.
3264         * stack.c (print_frame_arguments_choices): New value 'presence'.
3265         (print_frame_info_auto, print_frame_info_source_line,
3266         print_frame_info_location, print_frame_info_source_and_location,
3267         print_frame_info_location_and_address, print_frame_info_short_location,
3268         print_frame_info_choices, print_frame_info_print_what): New definitions.
3269         (print_frame_args): Only print dots for args if print frame-arguments
3270         is 'presence'.
3271         (frame_print_option_defs): New element for "frame-info".
3272         (get_user_print_what_frame_info): New function.
3273         (frame_show_address): Make non static.  Move comment to stack.h.
3274         (print_frame_info_to_print_what): New function.
3275         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3276         to decide what to print.
3277         (backtrace_command_1): Handle the new print_frame_arguments_presence
3278         value.
3279         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3280         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3281         (py_print_frame): In non-mi mode, use LOCATION as default for
3282         print_what, similarly to frame information printed directly by
3283         backtrace command. Handle frame-info user option in non MI mode.
3284
3285 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3286
3287         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3288         Add case for debugging 32-bit target on 64-bit host.  Revise
3289         comment.
3290
3291 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3292
3293         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3294         instead of find_function_entry_range_from_pc.
3295
3296 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3297
3298         * stack.c (find_frame_funname): Remove code which preferred
3299         minsym over symtab sym in "certain pathological cases".
3300
3301         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3302         parameter.  Change type of "do_demangle" to bool.
3303         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3304         Pass suitable "prefer_sym_over_minsym" flag to
3305         build_address_symbolic().  Don't output "+" for negative offsets.
3306         * printcmd.c (print_address_symbolic): Update invocation of
3307         build_address_symbolic to include a "prefer_sym_over_minsym"
3308         flag.
3309         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3310         Restrict cases in which use of minimal symbol is preferred to that
3311         of a found symbol.  Update comments.
3312
3313         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3314         for entry pc when entry pc is out of range for that FDE.
3315
3316 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3317
3318         PR gdb/24839:
3319         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3320         type.
3321
3322 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3323
3324         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3325         this function's Python signature.
3326
3327
3328 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3329
3330         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3331         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3332         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3333         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3334         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3335
3336
3337 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3338
3339         * h8300-tdep.c (h8300_register_name_common): New.
3340         h8300_register_name): Use h8300_register_name_common.
3341         (h8300s_register_name): Likewise.
3342         (h8300sx_register_name): Likewise.
3343         (h8300h_register_nam): New.
3344         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3345
3346
3347 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3348
3349         * arm-tdep.c (arm_skip_cmse_entry): New function.
3350         (arm_is_sgstubs_section): New function.
3351         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3352
3353 2019-07-22  Tom Tromey  <tom@tromey.com>
3354
3355         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3356         Don't self-assign.
3357
3358 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3359
3360         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3361         type_print.
3362
3363 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3364
3365         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3366         so that GDB doesn't match any msymbols when searching in the
3367         TYPES_DOMAIN.
3368         (print_symbol_info): Print using typedef_print or type_print based
3369         on the type of the symbol.  Add updated FIXME comment moved from...
3370         (_initialize_symtab): ... move and update FIXME comment to above.
3371
3372 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3373
3374         * NEWS: Mention adding -q option to "info types".
3375         * symtab.c (struct info_types_options): New struct.
3376         (info_types_options_defs): New variable.
3377         (make_info_types_options_def_group): New function.
3378         (info_types_command): Use gdb::option framework to parse options.
3379         (info_types_command_completer): New function.
3380         (_initialize_symtab): Extend the help text on "info types" and
3381         register command completer.
3382
3383 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3384
3385         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3386         (lookup_symbol_in_objfile): Change int to block_enum and add a
3387         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3388
3389 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3390
3391         * MAINTAINERS (Write After Approval): Add self.
3392
3393 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3394
3395         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3396         instruction to the dummy code region.
3397
3398 2019-07-19  Tom Tromey  <tromey@adacore.com>
3399
3400         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3401         (ARGSUSED, PARAMS, __func__): Remove rules.
3402
3403 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3404
3405         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3406         * features/arm/arm-with-iwmmxt.c: Remove.
3407         * features/arm/arm-with-iwmmxt.xml: Remove.
3408         * features/arm/arm-with-m-fpa-layout.c: Remove.
3409         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3410         * features/arm/arm-with-m-vfp-d16.c: Remove.
3411         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3412         * features/arm/arm-with-m.c: Remove.
3413         * features/arm/arm-with-m.xml: Remove.
3414         * features/arm/arm-with-neon.c: Remove.
3415         * features/arm/arm-with-neon.xml: Remove.
3416         * features/arm/arm-with-vfpv2.c: Remove.
3417         * features/arm/arm-with-vfpv2.xml: Remove.
3418         * features/arm/arm-with-vfpv3.c: Remove.
3419         * features/arm/arm-with-vfpv3.xml: Remove.
3420
3421 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3422
3423         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3424
3425 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3426
3427         * arch/aarch32.c (aarch32_create_target_description): Create
3428         target descriptions using features.
3429         * arch/arm.c (arm_create_target_description)
3430         (arm_create_mprofile_target_description): Likewise.
3431         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3432
3433 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3434
3435         * Makefile.in: Add new files.
3436         * aarch32-tdep.c: New file.
3437         * aarch32-tdep.h: New file.
3438         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3439         Call aarch32_read_description.
3440         * arch/aarch32.c: New file.
3441         * arch/aarch32.h: New file.
3442         * arch/arm.c (arm_create_target_description)
3443         (arm_create_mprofile_target_description): New function.
3444         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3445         (arm_create_target_description)
3446         (arm_create_mprofile_target_description): New declaration.
3447         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3448         read_description functions.
3449         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3450         Likewise.
3451         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3452         * arm-tdep.c (tdesc_arm_list): New variable.
3453         (arm_register_g_packet_guesses): Call create description functions.
3454         (arm_read_description) (arm_read_mprofile_description): New
3455         function.
3456         * arm-tdep.h (arm_read_description)
3457         (arm_read_mprofile_description): Add declaration.
3458         * configure.tgt: Add new files.
3459
3460 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3461
3462         * top.c (new_ui_command): Open specified terminal just once.
3463
3464 2019-07-18  Tom Tromey  <tromey@adacore.com>
3465
3466         * symtab.c (main_name): Constify return type.
3467         * symfile.c (set_initial_language): Update.
3468         * symtab.h (main_name): Constify return type.
3469
3470 2019-07-17  Tom Tromey  <tom@tromey.com>
3471
3472         * tui/tui-winsource.c (tui_update_source_window)
3473         (tui_update_source_window_as_is)
3474         (tui_update_source_windows_with_line): Remove return.
3475         * tui/tui-disasm.c (tui_show_disassem)
3476         (tui_show_disassem_and_update_source): Remove return.
3477         * tui/tui.c (tui_reset): Remove return.
3478         * tui/tui-wingeneral.c
3479         (tui_check_and_display_highlight_if_needed): Remove return.
3480
3481 2019-07-17  Tom Tromey  <tom@tromey.com>
3482
3483         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3484
3485 2019-07-17  Tom Tromey  <tom@tromey.com>
3486
3487         * tui/tui-winsource.h (struct tui_exec_info_window)
3488         (struct tui_source_window_base): Move from tui-data.h.
3489         * tui/tui-winsource.c: Move many method definitions from
3490         elsewhere.  Remove "structuring" comments.
3491         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3492         (tui_source_window_base::refresh_window): Move to
3493         tui-winsource.c.
3494         * tui/tui-win.c (tui_source_window_base::refresh_all)
3495         (tui_source_window_base::update_tab_width)
3496         (tui_source_window_base::set_new_height)
3497         (tui_source_window_base::do_make_visible_with_new_height): Move to
3498         tui-winsource.c.
3499         * tui/tui-source.h: Update.
3500         * tui/tui-source.c (tui_source_window_base::reset): Move to
3501         tui-winsource.c.
3502         * tui/tui-disasm.h: Update.
3503         * tui/tui-data.h (struct tui_exec_info_window): Move to
3504         tui-winsource.h.
3505         (struct tui_source_window_base): Likewise.
3506         * tui/tui-data.c (tui_source_window_base::clear_detail)
3507         (tui_source_window_base, ~tui_source_window_base): Move to
3508         tui-winsource.c.
3509
3510 2019-07-17  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-win.c (tui_resize_all)
3513         (tui_source_window_base::update_tab_width)
3514         (tui_adjust_win_heights): Update.
3515         (tui_win_info::make_invisible_and_set_new_height): Rename from
3516         make_invisible_and_set_new_height.
3517         * tui/tui-data.h (struct tui_win_info)
3518         <make_invisible_and_set_new_height>: New method.
3519
3520 2019-07-17  Tom Tromey  <tom@tromey.com>
3521
3522         * tui/tui.c: Update.
3523         * tui/tui-source.h (struct tui_source_window): Move from
3524         tui-data.h.
3525         * tui/tui-layout.c: Update.
3526         * tui/tui-disasm.c: Update.
3527         * tui/tui-data.h (struct tui_source_window): Move to
3528         tui-source.h.
3529
3530 2019-07-17  Tom Tromey  <tom@tromey.com>
3531
3532         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3533         tui-data.h.
3534         * tui/tui-data.h (struct tui_disasm_window): Move to
3535         tui-disasm.h.
3536
3537 2019-07-17  Tom Tromey  <tom@tromey.com>
3538
3539         * tui/tui-regs.h (struct tui_data_item_window): Move from
3540         tui-data.h.
3541         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3542         * tui/tui-data.h (struct tui_data_item_window): Move to
3543         tui-regs.h.
3544         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3545
3546 2019-07-17  Tom Tromey  <tom@tromey.com>
3547
3548         * tui/tui.c: Update.
3549         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3550         (tui_cmd_window::max_height): Move to tui-command.c.
3551         * tui/tui-layout.c: Update.
3552         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3553         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3554         tui-command.c.
3555         * tui/tui-command.h (struct tui_cmd_window): Move from
3556         tui-data.h.
3557         * tui/tui-command.c: Remove "structuring" comments.
3558         (tui_cmd_window::clear_detail)
3559         (tui_cmd_window::do_make_visible_with_new_height)
3560         (tui_cmd_window::max_height): Move from elsewhere.
3561
3562 2019-07-17  Tom Tromey  <tom@tromey.com>
3563
3564         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3565         Now static.
3566         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3567         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3568
3569 2019-07-17  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui.c: Update.
3572         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3573         tui-regs.c.
3574         * tui/tui-windata.h: Remove file.
3575         * tui/tui-windata.c: Remove file.
3576         * tui/tui-win.c (tui_data_window::set_new_height)
3577         (tui_data_window::do_make_visible_with_new_height): Move to
3578         tui-regs.c.
3579         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3580         * tui/tui-regs.c: Remove "structuring" comments.
3581         (tui_data_window::first_data_item_displayed)
3582         (tui_data_window::delete_data_content_windows)
3583         (tui_data_window::erase_data_content)
3584         (tui_data_window::display_all_data)
3585         (tui_data_window::refresh_all)
3586         (tui_data_window::do_scroll_vertical)
3587         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3588         (tui_data_window::do_make_visible_with_new_height)
3589         (tui_data_window::refresh_window): Move from elsewhere.
3590         (_initialize_tui_regs): Move to end of file.
3591         * tui/tui-layout.c: Update.
3592         * tui/tui-hooks.c: Update.
3593         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3594         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3595         tui-regs.c.
3596         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3597
3598 2019-07-17  Tom Tromey  <tom@tromey.com>
3599
3600         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3601         seen.
3602
3603 2019-07-17  Tom Tromey  <tom@tromey.com>
3604
3605         * tui/tui-win.c (tui_source_window_base::set_new_height)
3606         (tui_source_window_base::do_make_visible_with_new_height): Use
3607         m_has_locator field directly.
3608         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3609         method.
3610         (struct tui_source_window_base) <has_locator>: Likewise.
3611
3612 2019-07-17  Tom Tromey  <tom@tromey.com>
3613
3614         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3615         Don't declare.
3616         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3617         Remove.
3618         * tui/tui-win.c (tui_source_window_base::set_new_height)
3619         (tui_source_window_base::set_new_height)
3620         (make_invisible_and_set_new_height)
3621         (tui_source_window_base::do_make_visible_with_new_height)
3622         (tui_source_window_base::do_make_visible_with_new_height):
3623         Update.
3624         * tui/tui-layout.c (show_source_disasm_command, show_data)
3625         (show_source_or_disasm_and_command): Update.
3626         * tui/tui-layout.c (show_layout): Update.
3627
3628 2019-07-17  Tom Tromey  <tom@tromey.com>
3629
3630         * tui/tui-layout.c (make_data_window): Remove.
3631         (show_data): Unify creation and re-initialization cases.
3632
3633 2019-07-17  Tom Tromey  <tom@tromey.com>
3634
3635         * tui/tui-layout.c (make_source_window, make_disasm_window):
3636         Remove.
3637         (show_data): Unify creation and re-initialization cases.
3638
3639 2019-07-17  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-layout.c (make_command_window): Remove.
3642         (show_source_disasm_command, show_source_or_disasm_and_command):
3643         Unify creation and re-initialization cases.
3644
3645 2019-07-17  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3648         creation and re-initialization cases.
3649
3650 2019-07-17  Tom Tromey  <tom@tromey.com>
3651
3652         * tui/tui-regs.c (tui_get_register): Return void.
3653
3654 2019-07-17  Tom Tromey  <tom@tromey.com>
3655
3656         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3657         Simplify.
3658
3659 2019-07-17  Tom Tromey  <tom@tromey.com>
3660
3661         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3662         resetting.
3663
3664 2019-07-17  Tom Tromey  <tom@tromey.com>
3665
3666         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3667         * tui/tui-regs.c (tui_reg_layout): New function.
3668         (tui_show_registers, tui_reg_command): Use it.
3669         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3670         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3671         parameters.
3672         (tui_layout_command): Remove.
3673
3674 2019-07-17  Tom Tromey  <tom@tromey.com>
3675
3676         * tui/tui-layout.h (tui/tui-layout): Return void.
3677         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3678
3679 2019-07-17  Tom Tromey  <tom@tromey.com>
3680
3681         * tui/tui-layout.c (show_source_disasm_command, show_data):
3682         Update.
3683         (reset_locator): Remove.
3684         (show_source_or_disasm_and_command): Update.
3685
3686 2019-07-17  Tom Tromey  <tom@tromey.com>
3687
3688         * tui/tui-source.c (tui_source_window_base::reset): Remove
3689         win_type parameter.
3690         * tui/tui-layout.c (make_command_window, make_source_window)
3691         (make_disasm_window, make_data_window)
3692         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3693         (reset_locator, show_source_or_disasm_and_command): Update.
3694         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3695         win_type parameter.
3696         (struct tui_source_window_base) <reset>: Likewise.
3697
3698 2019-07-17  Tom Tromey  <tom@tromey.com>
3699
3700         * tui/tui-layout.c (show_source_disasm_command): Use
3701         reset_locator.
3702         (reset_locator): New function.
3703         (init_and_make_win): Remove.
3704         (show_source_or_disasm_and_command): Use reset_locator.
3705
3706 2019-07-17  Tom Tromey  <tom@tromey.com>
3707
3708         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3709         condition.
3710         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3711         Remove condition.
3712         * tui/tui-source.c (tui_source_window_base::reset): New method.
3713         * tui/tui-layout.c (make_command_window): Don't call
3714         init_and_make_win.
3715         (make_source_window, make_disasm_window): Don't call
3716         make_source_or_disasm_window.
3717         (make_data_window): Don't call init_and_make_win.  Change calling
3718         convention.
3719         (show_source_disasm_command, show_data): Simplify.
3720         (make_source_or_disasm_window): Remove.
3721         (show_source_or_disasm_and_command): Simplify.
3722         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3723         (struct tui_source_window_base) <reset>: Likewise.
3724         <execution_info>: Remove initializer.
3725         * tui/tui-data.c (tui_source_window_base): Initialize
3726         execution_info.
3727
3728 2019-07-17  Tom Tromey  <tom@tromey.com>
3729
3730         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3731         variable.
3732
3733 2019-07-17  Tom Tromey  <tom@tromey.com>
3734
3735         * tui/tui.c (tui_rl_other_window): Update.
3736         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3737         superclass method first.  Always iterate over regs_content.
3738         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3739         method.
3740         * tui/tui-win.c (tui_set_focus_command): Update.
3741
3742 2019-07-17  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-win.c (tui_set_focus_command): Rename from
3745         tui_set_focus.  Call tui_enable.
3746         (tui_set_focus_command): Remove.
3747
3748 2019-07-17  Tom Tromey  <tom@tromey.com>
3749
3750         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3751         refresh_window.
3752         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3753         touchwin.
3754         (tui_data_window::refresh_window): Call refresh_window on data
3755         items.  Always call superclass refresh_window.
3756         (tui_win_info::refresh): Remove.
3757         (tui_source_window_base::refresh_window): Update.
3758         (tui_refresh_all): Update.
3759         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3760         refresh_window.
3761         (show_source_or_disasm_and_command): Likewise.
3762         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3763         (struct tui_source_window_base) <refresh>: Likewise.
3764
3765 2019-07-17  Tom Tromey  <tom@tromey.com>
3766
3767         * tui/tui-winsource.c (tui_clear_source_content)
3768         (tui_show_source_content): Update.
3769         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3770         whether content is empty.
3771         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3772         Remove.
3773
3774 2019-07-17  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3777         window's contents.
3778         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3779         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3780
3781 2019-07-17  Tom Tromey  <tom@tromey.com>
3782
3783         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3784         (struct tui_data_item_window): Update.
3785
3786 2019-07-17  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3789         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3790         defines.
3791
3792 2019-07-17  Tom Tromey  <tom@tromey.com>
3793
3794         * tui/tui-winsource.h (tui_erase_source_content)
3795         (tui_clear_source_content): Remove "display_prompt" parameter.
3796         * tui/tui-winsource.c (tui_update_source_window_as_is)
3797         (tui_update_source_windows_with_addr): Update.
3798         (tui_clear_source_content): Remove "display_prompt" parameter.
3799         (tui_erase_source_content): Likewise.  Simplify.
3800         (tui_show_source_content): Update.
3801         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3802         * tui/tui-stack.c (tui_show_frame_info): Update.
3803         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3804         Remove defines.
3805
3806 2019-07-17  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3809         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3810         parameter.
3811         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3812         parameter.
3813
3814 2019-07-17  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-winsource.c (tui_clear_source_content)
3817         (tui_show_source_content, tui_show_exec_info_content)
3818         (tui_clear_exec_info_content): Update.
3819         * tui/tui-stack.c (tui_show_locator_content): Update.
3820         (tui_show_frame_info): Update.
3821         * tui/tui-source.h (tui_source_window): Don't declare.
3822         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3823         from tui_source_is_displayed.
3824         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3825         Remove field.
3826         (struct tui_source_window_base) <content_in_use>: New field.  Now
3827         bool.
3828         (struct tui_source_window) <showing_source_p>: New method.
3829         (TUI_SRC_WIN): Change cast.
3830         * tui/tui-data.c (tui_initialize_static_data): Update.
3831
3832 2019-07-17  Tom Tromey  <tom@tromey.com>
3833
3834         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3835         location_matches_p.
3836         * tui/tui-source.c (tui_source_window::location_matches_p): New
3837         method.
3838         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3839         method.
3840         * tui/tui-data.h (struct tui_source_window_base)
3841         <location_matches_p>: New method.
3842         (struct tui_source_window, struct tui_disasm_window)
3843         <location_matches_p>: Likewise.
3844
3845 2019-07-17  Tom Tromey  <tom@tromey.com>
3846
3847         * tui/tui-win.c (tui_set_win_height_command): Rename from
3848         tui_set_win_height.
3849         (tui_set_win_height_command): Remove.
3850
3851 2019-07-17  Tom Tromey  <tom@tromey.com>
3852
3853         * tui/tui-source.c (tui_source_window): New constructor.  Add
3854         observer.
3855         (~tui_source_window): New destructor.
3856         (tui_source_window::style_changed): New method.
3857         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3858         (tui_attach_detach_observers): Update.
3859         * tui/tui-data.h (struct tui_source_window): Make constructor not
3860         inline.  Add destructor.
3861         (struct tui_source_window) <style_changed>: New method.
3862         <m_observable>: New member.
3863
3864 2019-07-17  Tom Tromey  <tom@tromey.com>
3865
3866         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3867         * tui/tui-win.c (tui_resize_all): Fix typo.
3868
3869 2019-07-17  Tom Tromey  <tom@tromey.com>
3870
3871         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3872         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3873         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3874         * tui/tui-win.c (window_name_completer): Use foreach.
3875         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3876         (update_tab_width): Likewise.
3877         * tui/tui-layout.c (show_layout): Update.
3878         * tui/tui-data.h (class tui_window_iterator): New.
3879         (struct all_tui_windows): New.
3880         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3881
3882 2019-07-17  Tom Tromey  <tom@tromey.com>
3883
3884         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3885         parameter.  Don't reference globals.
3886         (tui_reg_command): Update.
3887
3888 2019-07-17  Tom Tromey  <tom@tromey.com>
3889
3890         * tui/tui-regs.c (tui_show_registers): Simplify.
3891
3892 2019-07-17  Tom Tromey  <tom@tromey.com>
3893
3894         * tui/tui-regs.c (tui_show_registers): Update.
3895         (tui_show_register_group): Add win_info parameter.
3896
3897 2019-07-17  Tom Tromey  <tom@tromey.com>
3898
3899         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3900         Rename from tui_display_reg_element_at_line.
3901         (tui_data_window::display_registers_from_line): Update.
3902         * tui/tui-data.h (struct tui_data_window)
3903         <display_reg_element_at_line>: New method.
3904
3905 2019-07-17  Tom Tromey  <tom@tromey.com>
3906
3907         * tui/tui-regs.h (tui_display_registers_from)
3908         (tui_display_registers_from_line): Don't declare.
3909         * tui/tui-windata.c (tui_data_window::display_all_data)
3910         (tui_data_window::refresh_all)
3911         (tui_data_window::do_scroll_vertical): Update.
3912         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3913         from tui_display_registers_from.
3914         (tui_display_reg_element_at_line): Update.
3915         (tui_data_window::display_registers_from_line): Rename from
3916         tui_display_registers_from_line.
3917         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3918         display_registers_from_line>: New methods.
3919
3920 2019-07-17  Tom Tromey  <tom@tromey.com>
3921
3922         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3923         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3924         from tui_erase_data_content.
3925         (tui_data_window::display_all_data)
3926         (tui_data_window::refresh_all)
3927         (tui_data_window::do_scroll_vertical): Update.
3928         * tui/tui-regs.c (tui_show_registers): Update.
3929         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3930         New method.
3931
3932 2019-07-17  Tom Tromey  <tom@tromey.com>
3933
3934         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3935         declare.
3936         * tui/tui-windata.c
3937         (tui_data_window::delete_data_content_windows): Rename from
3938         tui_delete_data_content_windows.
3939         (tui_data_window::display_all_data)
3940         (tui_data_window::do_scroll_vertical): Update.
3941         * tui/tui-data.h (struct tui_data_window)
3942         <delete_data_content_windows>: New method.
3943
3944 2019-07-17  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3947         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3948
3949 2019-07-17  Tom Tromey  <tom@tromey.com>
3950
3951         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3952         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3953         from tui_display_all_data.
3954         * tui/tui-win.c
3955         (tui_data_window::do_make_visible_with_new_height): Update.
3956         * tui/tui-regs.c (tui_show_registers): Update.
3957         * tui/tui-layout.c (tui_set_layout): Update.
3958         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3959         method.
3960
3961 2019-07-17  Tom Tromey  <tom@tromey.com>
3962
3963         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3964         * tui/tui-windata.c (tui_display_data_from): Remove.
3965         (tui_data_window::refresh_all): Update.
3966
3967 2019-07-17  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3970         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3971         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3972         tui_display_registers_from_line.
3973         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3974         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3975         "force_display" parameter.
3976
3977 2019-07-17  Tom Tromey  <tom@tromey.com>
3978
3979         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3980         declare.
3981         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3982         Rename from tui_first_reg_element_no_inline.
3983         (tui_display_reg_element_at_line)
3984         (tui_display_registers_from_line): Update.
3985         * tui/tui-data.h (struct tui_data_window)
3986         <first_reg_element_no_inline>: New method.
3987
3988 2019-07-17  Tom Tromey  <tom@tromey.com>
3989
3990         * tui/tui-windata.c (tui_display_data_from)
3991         (tui_data_window::do_scroll_vertical): Update.
3992         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3993         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3994         Rename from tui_line_from_reg_element_no.
3995         (tui_display_registers_from_line): Update.
3996         * tui/tui-data.h (struct tui_data_window)
3997         <line_from_reg_element_no>: New method.
3998
3999 2019-07-17  Tom Tromey  <tom@tromey.com>
4000
4001         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4002         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4003         tui_last_regs_line_no.
4004         (tui_display_reg_element_at_line)
4005         (tui_display_registers_from_line): Update.
4006         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4007         method.
4008
4009 2019-07-17  Tom Tromey  <tom@tromey.com>
4010
4011         PR tui/24722:
4012         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4013         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4014         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4015         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4016         (tui_update_breakpoint_info): Likewise.
4017         * tui/tui-hooks.c (tui_event_create_breakpoint)
4018         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4019         Update.
4020
4021 2019-07-17  Tom Tromey  <tom@tromey.com>
4022
4023         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4024
4025 2019-07-17  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-winsource.c (tui_update_source_window_as_is)
4028         (tui_update_source_windows_with_addr): Update.
4029         * tui/tui-source.h (tui_set_source_content)
4030         (tui_show_symtab_source): Add "win_info" parameter.
4031         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4032         parameter.
4033         (tui_show_symtab_source): Likewise.
4034
4035 2019-07-17  Tom Tromey  <tom@tromey.com>
4036
4037         * tui/tui-wingeneral.c
4038         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4039
4040 2019-07-17  Tom Tromey  <tom@tromey.com>
4041
4042         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4043         (struct tui_cmd_window) <can_scroll>: New method.
4044         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4045         method.
4046
4047 2019-07-17  Tom Tromey  <tromey@adacore.com>
4048
4049         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4050         do_field_signed>: Rename.  Change type of "value".
4051         * ui-out.c (ui_out::field_signed): Rename from field_int.
4052         Change type of "value".
4053         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4054         type of "value".
4055         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4056         do_field_int.  Change type of "value".
4057         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4058         do_field_int.  Change type of "value".
4059         * tracepoint.c (trace_status_mi, tfind_1)
4060         (print_one_static_tracepoint_marker): Update.
4061         * thread.c (print_thread_info_1, print_selected_thread_frame):
4062         Update.
4063         * stack.c (print_frame, print_frame_info): Update.
4064         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4065         Update.
4066         * source.c (print_source_lines_base): Update.
4067         * skip.c (info_skip_command): Update.
4068         * record-btrace.c (btrace_ui_out_decode_error)
4069         (btrace_call_history_src_line): Update.
4070         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4071         Update.
4072         * progspace.c (print_program_space): Update.
4073         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4074         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4075         do_field_int.  Change type of "value".
4076         * mi/mi-out.c (mi_ui_out::do_table_begin)
4077         (mi_ui_out::do_table_header): Update.
4078         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4079         type of "value".
4080         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4081         (mi_cmd_data_list_changed_registers, output_register)
4082         (mi_cmd_data_read_memory, mi_load_progress)
4083         (mi_cmd_trace_frame_collected): Update.
4084         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4085         Update.
4086         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4087         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4088         (mi_cmd_var_list_children, varobj_update_one): Update.
4089         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4090         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4091         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4092         * inferior.c (print_inferior): Update.
4093         * gdb_bfd.c (print_one_bfd): Update.
4094         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4095         Update.
4096         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4097         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4098         do_field_int.  Change type of "value".
4099         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4100         do_field_int.  Change type of "value".
4101         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4102         (print_one_breakpoint_location, print_it_catch_fork)
4103         (print_one_catch_fork, print_it_catch_vfork)
4104         (print_one_catch_vfork, print_it_catch_solib)
4105         (print_it_catch_exec, print_it_ranged_breakpoint)
4106         (print_mention_watchpoint, print_mention_masked_watchpoint)
4107         (bkpt_print_it, update_static_tracepoint): Update.
4108         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4109         * break-catch-syscall.c (print_it_catch_syscall): Update.
4110         * ada-tasks.c (print_ada_task_info): Update.
4111         * ada-lang.c (print_it_exception, print_mention_exception):
4112         Update.
4113
4114 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4115
4116         PR breakpoints/24541
4117         * gdbarch.c: Regenerate.
4118         * gdbarch.h: Regenerate.
4119         * gdbarch.sh: Adjust return type and parameter types for
4120         'stap_adjust_register'.
4121         (i386_stap_adjust_register): Adjust signature and return new
4122         register name.
4123         * stap-probe.c (stap_parse_register_operand): Adjust use of
4124         'gdbarch_stap_adjust_register'.
4125
4126 2019-07-17  Tom Tromey  <tromey@adacore.com>
4127
4128         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4129         declare VEC.
4130         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4131         std::vector.
4132         (struct s390_process_info): Add initializers.
4133         (s390_add_process): Use new.
4134         (s390_linux_nat_target::low_forget_process): Use delete.
4135         (s390_linux_nat_target::low_new_fork)
4136         (s390_linux_nat_target::stopped_by_watchpoint)
4137         (s390_linux_nat_target::low_prepare_to_resume)
4138         (s390_linux_nat_target::insert_watchpoint)
4139         (s390_linux_nat_target::insert_hw_breakpoint)
4140         (s390_linux_nat_target::remove_watchpoint)
4141         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4142
4143 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4144
4145         * aarch64-fbsd-nat.c: Include regcache.h.
4146         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4147         argument.
4148         (aarch64_fbsd_nat_target::fetch_registers)
4149         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4150         variable.
4151         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4152
4153 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4154
4155         * fbsd-nat.c: Include gdbarch.h.
4156
4157 2019-07-15  Tom Tromey  <tromey@adacore.com>
4158
4159         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4160
4161 2019-07-15  Tom Tromey  <tromey@adacore.com>
4162
4163         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4164         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4165         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4166         * cli-out.c (cli_ui_out::do_field_int): New method.
4167         * ui-out.c (ui_out::field_unsigned): New method.
4168         * symfile.c (generic_load): Use field_unsigned.
4169         (print_transfer_performance): Likewise.
4170         * record-btrace.c (ui_out_field_uint): Remove.
4171         (btrace_call_history_insn_range, btrace_call_history): Use
4172         field_unsigned.
4173         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4174         field_unsigned.
4175         * ui-out.h (class ui_out) <field_unsigned>: New method.
4176         <do_field_unsigned>: Likewise.
4177
4178 2019-07-15  Tom Tromey  <tromey@adacore.com>
4179
4180         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4181         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4182         * target.c (flash_erase_command): Use field_string.
4183         * infrun.c (print_signal_received_reason): Use field_string.
4184         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4185         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4186         field_string.
4187         * ada-tasks.c (print_ada_task_info): Use field_string.
4188
4189 2019-07-15  Tom Tromey  <tromey@adacore.com>
4190
4191         * target.c (flash_erase_command): Use field_core_addr.
4192         * symfile.c (generic_load): Use field_core_addr.
4193         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4194         Use field_core_addr.
4195         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4196         field_core_addr.
4197
4198 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4199
4200         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4201         value if its desired type is smaller than a CORE_ADDR and signed.
4202
4203 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4204
4205         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4206         of changes to field names, and use new is_reference field to
4207         decide if a property is a reference or not.
4208         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4209         field.
4210         (struct dwarf2_property_baton): Update header comment, rename
4211         'referenced_type' to 'property_type' and update comments.
4212         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4213         default property type, store in property baton, update to take
4214         accound of renamed field.
4215         (read_func_scope): Update call to attr_to_dynamic_prop.
4216         (read_array_type): Likewise.
4217         (dwarf2_per_cu_addr_sized_int_type): New function.
4218         (read_subrange_index_type): Move type finding code to
4219         dwarf2_per_cu_addr_sized_int_type.
4220         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4221         (dwarf2_per_cu_addr_type): New function.
4222         (set_die_type): Update calls to attr_to_dynamic_prop.
4223
4224 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4225
4226         * dwarf2read.c (read_subrange_index_type): New function.
4227         (read_subrange_type): Move code into new function and call it.
4228         * gdbtypes.c (create_range_type): Add some asserts.
4229
4230 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4231
4232         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4233         update return statements.
4234         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4235         declaration, and update comment to match.
4236         * gdbtypes.c (resolve_dynamic_array): Update call to
4237         dwarf2_evaluate_property to match new return type.
4238
4239 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4240
4241         * valarith.c (value_subscripted_rvalue): Change lowerbound
4242         parameter type from int to LONGEST.
4243         * value.h (value_subscripted_rvalue): Likewise in declaration.
4244
4245 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4246
4247         * cli/cli-utils.c (info_print_command_completer): New function.
4248         * cli/cli-utils.h: Add 'completer.h' include, and forward
4249         declaration for 'struct cmd_list_element'.
4250         (info_print_command_completer): Declare.
4251         * stack.c (_initialize_stack): Add completer for 'info locals' and
4252         'info args'.
4253         * symtab.c (_initialize_symtab): Add completer for 'info
4254         variables' and 'info functions'.
4255         * NEWS: Mention completion for additional info commands.
4256
4257 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4258
4259         * cli/cli-utils.c (extract_info_print_args): Delete.
4260         (extract_arg_maybe_quoted): Delete.
4261         (info_print_options_defs): New variable.
4262         (make_info_print_options_def_group): New function.
4263         (extract_info_print_options): Define new function.
4264         * cli/cli-utils.h (extract_info_print_args): Delete.
4265         (struct info_print_options): New structure.
4266         (extract_info_print_options): Declare new function.
4267         * stack.c (info_locals_command): Update to use new
4268         extract_info_print_options, also add a header comment.
4269         (info_args_command): Likewise.
4270         * symtab.c (info_variables_command): Likewise.
4271         (info_functions_command): Likewise.
4272
4273 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4274
4275         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4276         to extract string arguments.
4277         * common/common-utils.c (extract_string_maybe_quoted): New function.
4278         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4279
4280 2019-07-11  Tom Tromey  <tromey@adacore.com>
4281
4282         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4283         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4284         * top.h (gdbinit): Don't declare.
4285         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4286         into...
4287         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4288         * top.c (gdb_init): Don't call init_cli_cmds.
4289         (gdbinit): Remove.
4290         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4291
4292 2019-07-11  Tom Tromey  <tromey@adacore.com>
4293
4294         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4295         after it has been moved.
4296
4297 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4298
4299         * valops.c (value_must_coerce_to_target): Change return type to
4300         bool.
4301         * value.h (value_must_coerce_to_target): Likewise.
4302
4303 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4304
4305         * breakpoint.c (is_hardware_watchpoint): Remove
4306         forward-declaration.
4307         (is_masked_watchpoint): Change return type to bool.
4308         (is_tracepoint): Likewise.
4309         (is_breakpoint): Likewise.
4310         (is_hardware_watchpoint): Likewise.
4311         (is_watchpoint): Likewise.
4312         (is_no_memory_software_watchpoint): Likewise.
4313         (is_catchpoint): Likewise.
4314         (breakpoint_1): Make FILTER parameter's return type bool.
4315         is_masked_watchpoint): Change return type to bool.
4316         (save_breakpoints): Make FILTER parameter's return type bool.
4317         * breakpoint.h (is_breakpoint): Change return type to bool.
4318         (is_watchpoint): Likewise.
4319         (is_catchpoint): Likewise.
4320         (is_tracepoint): Likewise.
4321
4322 2019-07-10  Tom Tromey  <tom@tromey.com>
4323
4324         * defs.h: Don't include gdbarch.h.
4325         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4326         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4327         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4328         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4329         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4330         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4331         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4332         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4333         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4334         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4335         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4336         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4337         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4338         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4339         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4340         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4341         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4342         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4343         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4344         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4345         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4346         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4347         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4348         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4349         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4350         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4351         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4352
4353 2019-07-10  Tom Tromey  <tromey@adacore.com>
4354
4355         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4356         * breakpoint.c (init_ada_exception_breakpoint): Register as
4357         bp_catchpoint.
4358         (print_one_breakpoint_location, print_one_breakpoint): Use
4359         is_ada_exception_catchpoint.
4360         * ada-lang.c (class ada_catchpoint_location): Pass
4361         bp_loc_software_breakpoint to bp_location constructor.
4362         (is_ada_exception_catchpoint): New function.
4363
4364 2019-07-10  Tom Tromey  <tromey@adacore.com>
4365
4366         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4367         VEC.
4368         (struct arm_exidx_entry): New method operator<.
4369         (struct arm_exidx_data) <section_maps>: Change type.
4370         (arm_exidx_data_free): Remove.
4371         (arm_exidx_data_key): Change type.  Move lower.
4372         (arm_exidx_new_objfile): Update.
4373         (arm_compare_exidx_entries): Remove.
4374         (arm_find_exidx_entry, _initialize_arm_tdep)
4375
4376 2019-07-10  Tom Tromey  <tromey@adacore.com>
4377
4378         * solib-spu.c (ocl_program_data_key): Change type.
4379         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4380         Update.
4381
4382 2019-07-10  Tom Tromey  <tromey@adacore.com>
4383
4384         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4385         (struct solib_aix_inferior_data) <library_list>: Change type.
4386         (solib_aix_inferior_data_handle): Change type.
4387         (get_solib_aix_inferior_data): Update.
4388         (solib_aix_free_library_list): Remove.
4389         (library_list_start_library): Update.
4390         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4391         return type.
4392         (solib_aix_get_library_list)
4393         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4394         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4395
4396 2019-07-10  Tom Tromey  <tromey@adacore.com>
4397
4398         * solib-dsbt.c (struct dsbt_info): Add initializers.
4399         (solib_dsbt_pspace_data): Change type.
4400         (dsbt_pspace_data_cleanup): Remove.
4401         (get_dsbt_info, _initialize_dsbt_solib): Update.
4402
4403 2019-07-10  Tom Tromey  <tromey@adacore.com>
4404
4405         * spu-tdep.c (spu_overlay_data): Change type.
4406         (spu_get_overlay_table, spu_overlay_new_objfile)
4407         (_initialize_spu_tdep): Update.
4408
4409 2019-07-10  Tom Tromey  <tromey@adacore.com>
4410
4411         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4412         destructor.
4413         (dbx_objfile_data_key): Change type and declare later.
4414         (DBX_SYMFILE_INFO): Rewrite.
4415         * dbxread.c (dbx_objfile_data_key): Change type.
4416         (dbx_symfile_init): Update.
4417         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4418         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4419         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4420
4421 2019-07-10  Tom Tromey  <tromey@adacore.com>
4422
4423         * jit.c (jit_program_space_key): Change type.  Move lower.
4424         (get_jit_program_space_data): Update.
4425         (jit_program_space_data_cleanup): Remove.
4426         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4427         Update.
4428         (struct jit_program_space_data): Add initializers.
4429
4430 2019-07-10  Tom Tromey  <tromey@adacore.com>
4431
4432         * solib-darwin.c (struct darwin_info): Add initializers.
4433         (solib_darwin_pspace_data): Change type.
4434         (darwin_pspace_data_cleanup): Remove.
4435         (get_darwin_info, _initialize_darwin_solib): Update.
4436
4437 2019-07-10  Tom Tromey  <tromey@adacore.com>
4438
4439         * remote-sim.c (struct sim_inferior_data): Add initializers,
4440         constructor, and destructor.
4441         (sim_inferior_data_key): Change type.  Move lower.
4442         (check_for_duplicate_sim_descriptor): Update.
4443         (get_sim_inferior_data): Use new.  Update.
4444         (~sim_inferior_data_cleanup): Rename from
4445         sim_inferior_data_cleanup.  Simplify.
4446         (gdbsim_close_inferior, simulator_command)
4447         (sim_command_completer, _initialize_remote_sim): Update.
4448         (next_pid, INITIAL_PID): Move earlier.
4449
4450 2019-07-10  Tom Tromey  <tromey@adacore.com>
4451
4452         * python/python-internal.h (create_thread_object): Return
4453         gdbpy_ref.
4454         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4455         * python/py-inferior.c (struct threadlist_entry): Add
4456         constructor.
4457         <thread_obj>: Now a gdbpy_ref.
4458         (thread_to_thread_object): Update.
4459         (add_thread_object): Use new.
4460         (delete_thread_object): Use delete.
4461         (infpy_threads): Update.
4462         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4463         GIL.
4464
4465 2019-07-10  Tom Tromey  <tromey@adacore.com>
4466
4467         * valops.c (value_cast): Specialize error message for Ada.
4468
4469 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4470
4471         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4472
4473 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4474
4475         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4476         bpstat_should_step): Return bool, adjust comments.
4477         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4478         bpstat_should_step): Likewise.
4479
4480 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4481
4482         * features/Makefile: Use feature target descriptions for Arm.
4483         * features/arm/arm-core.c: Generate new file.
4484         * features/arm/arm-fpa.c: Likewise.
4485         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4486         * features/arm/arm-m-profile.c: Likewise.
4487         * features/arm/arm-vfpv2.c: Likewise.
4488         * features/arm/arm-vfpv3.c: Likewise.
4489         * features/arm/xscale-iwmmxt.c: Likewise.
4490         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4491
4492 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4493
4494         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4495         ptrace earlier.
4496
4497 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4498
4499         * features/aarch64-pauth.c: Regenerate.
4500
4501 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4502
4503         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4504         bool.
4505         (bpstat_what): Use false instead of 0.
4506
4507 2019-07-09  Pedro Alves  <palves@redhat.com>
4508
4509         * break-catch-throw.c (is_exception_catchpoint): New.
4510         * breakpoint.c (print_one_breakpoint_location): New parameter
4511         'raw_loc'.  Handle it.  Use
4512         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4513         looking at the breakpoint's type.
4514         (print_one_breakpoint): If handling "maint info breakpoints", also
4515         print locations of exception catchpoints.
4516         * breakpoint.h (is_exception_catchpoint): Declare.
4517
4518 2019-07-09  Pedro Alves  <palves@redhat.com>
4519
4520         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4521         "addr" field.
4522         (allocate_location_exception_catchpoint): New.
4523         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4524         (initialize_throw_catchpoint_ops): Install
4525         allocate_location_exception_catchpoint as allocate_location
4526         method.
4527         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4528         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4529         bp_loc_other.
4530         (breakpoint_address_is_meaningful): Delete.
4531         (bl_address_is_meaningful): New.
4532         (breakpoint_locations_match): Adjust comment.
4533         (bp_location_from_bp_type): New, factored out of...
4534         (bp_location::bp_location(breakpoint *)): ... this.
4535         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4536         factored out of...
4537         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4538         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4539         breakpoint_address_is_meaningful.
4540         (bp_locations_compare): Adjust comment.
4541         (update_global_location_list): Use bl_address_is_meaningful
4542         instead of breakpoint_address_is_meaningful.
4543         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4544         explicit.
4545         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4546         * python/py-breakpoint.c (bppy_get_location): No longer check
4547         whether location is null.
4548
4549 2019-07-09  Pedro Alves  <palves@redhat.com>
4550
4551         PR c++/15468
4552         * breakpoint.c (print_one_breakpoint_location): Remove
4553         single-location assert.
4554
4555 2019-07-09  Tom Tromey  <tom@tromey.com>
4556
4557         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4558         * configure: Rebuild.
4559         * configure.ac: Change common to gdbsupport.
4560         * gdbsupport: Rename from common.
4561         * acinclude.m4: Change common to gdbsupport.
4562         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4563         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4564         gdbsupport.
4565         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4566         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4567         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4568         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4569         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4570         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4571         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4572         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4573         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4574         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4575         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4576         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4577         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4578         coff-pe-read.c, command.h, compile/compile-c-support.c,
4579         compile/compile-c.h, compile/compile-cplus-symbols.c,
4580         compile/compile-cplus-types.c, compile/compile-cplus.h,
4581         compile/compile-loc2c.c, compile/compile.c, completer.c,
4582         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4583         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4584         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4585         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4586         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4587         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4588         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4589         features/aarch64-core.c, features/aarch64-fpu.c,
4590         features/aarch64-pauth.c, features/aarch64-sve.c,
4591         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4592         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4593         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4594         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4595         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4596         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4597         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4598         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4599         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4600         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4601         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4602         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4603         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4604         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4605         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4606         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4607         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4608         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4609         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4610         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4611         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4612         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4613         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4614         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4615         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4616         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4617         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4618         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4619         minsyms.c, mips-linux-tdep.c, namespace.h,
4620         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4621         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4622         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4623         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4624         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4625         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4626         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4627         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4628         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4629         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4630         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4631         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4632         procfs.c, producer.c, progspace.h, psymtab.h,
4633         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4634         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4635         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4636         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4637         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4638         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4639         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4640         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4641         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4642         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4643         target-memory.c, target.c, target.h, target/waitstatus.c,
4644         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4645         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4646         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4647         unittests/array-view-selftests.c,
4648         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4649         unittests/common-utils-selftests.c,
4650         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4651         unittests/format_pieces-selftests.c,
4652         unittests/function-view-selftests.c,
4653         unittests/lookup_name_info-selftests.c,
4654         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4655         unittests/mkdir-recursive-selftests.c,
4656         unittests/observable-selftests.c,
4657         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4658         unittests/parse-connection-spec-selftests.c,
4659         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4660         unittests/scoped_fd-selftests.c,
4661         unittests/scoped_mmap-selftests.c,
4662         unittests/scoped_restore-selftests.c,
4663         unittests/string_view-selftests.c, unittests/style-selftests.c,
4664         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4665         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4666         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4667         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4668         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4669         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4670
4671 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4672
4673         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4674         bool value.
4675         (decode_digits_ordinary): Set explicit_line field in sal.
4676         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4677         symtab_and_line that was set on an explicit line number in
4678         assembler code.  Do always update the recorded symtab and line if
4679         we do skip the prologue.
4680
4681 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4682
4683         * breakpoint.c (set_breakpoint_location_function): Remove
4684         explicit_loc parameter.
4685         (momentary_breakpoint_from_master): Update call to
4686         set_breakpoint_location_function.
4687         (add_location_to_breakpoint): Likewise.
4688
4689 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4690
4691         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4692         required features based on default bfd type when no specific bfd
4693         is present.
4694
4695 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4696
4697         * NEWS: Mention that GDB printf and eval commands can now print
4698         C-style and Ada-style convenience var strings without
4699         calling the inferior.
4700         * printcmd.c (printf_c_string): Locally print GDB internal var
4701         instead of transiting via the inferior.
4702         (printf_wide_c_string): Likewise.
4703
4704 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4705
4706         PR breakpoints/25011
4707         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4708
4709 2019-07-04  Tom Tromey  <tom@tromey.com>
4710
4711         PR tui/24724:
4712         * tui/tui-winsource.c (tui_clear_source_content): Update.
4713         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4714         (tui_update_breakpoint_info): Update.
4715         (tui_set_exec_info_content): Update.
4716         * tui/tui-source.c (tui_set_source_content_nil): Update.
4717         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4718         has_break.
4719         * tui/tui-data.h (enum tui_bp_flag): New.
4720         (tui_bp_flags): New enum flags type.
4721         (struct tui_source_element) <break_mode>: Change type.  Rename
4722         from has_break.
4723         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4724         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4725         constants.
4726         * tui/tui-winsource.h: Fix comment.
4727
4728 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4729
4730         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4731         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4732         (store_fpregs_to_thread)
4733         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4734         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4735         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4736         (IWMMXT_REGS_SIZE): Add define.
4737         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4738         (fetch_vfp_regs, store_vfp_regs)
4739         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4740         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4741
4742 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4743
4744         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4745         defines.
4746         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4747         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4748         (ARM_INT_REGISTER_SIZE): ...to this.
4749         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4750         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4751         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4752         (arm_linux_collect_gregset, supply_nwfpe_register)
4753         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4754         defines.
4755         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4756         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4757         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4758         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4759         (arm_return_in_memory, arm_store_return_value)
4760         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4761         (arm_record_ld_st_multiple): Likewise.
4762         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4763         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4764
4765 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4766
4767         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4768         AARCH64_DISPLACED_MODIFIED_INSNS.
4769         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4770         (aarch64_displaced_step_copy_insn): Likewise.
4771         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4772         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4773         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4774         ARM_DISPLACED_MODIFIED_INSNS.
4775         * arm-tdep.c (arm_gdbarch_init): Likewise.
4776         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4777         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4778         (struct arm_displaced_step_closure): Use
4779         ARM_DISPLACED_MODIFIED_INSNS.
4780
4781 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4782
4783         * features/Makefile: Remove unused xml files.
4784         * features/aarch64.xml: Remove.
4785         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4786         * features/i386/amd64-avx-avx512.xml: Remove.
4787         * features/i386/amd64-avx-linux.xml: Remove.
4788         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4789         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4790         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4791         * features/i386/amd64-avx-mpx.xml: Remove.
4792         * features/i386/amd64-avx.xml: Remove.
4793         * features/i386/amd64-linux.xml: Remove.
4794         * features/i386/amd64-mpx-linux.xml: Remove.
4795         * features/i386/amd64-mpx.xml: Remove.
4796         * features/i386/amd64.xml: Remove.
4797         * features/i386/i386-avx-avx512-linux.xml: Remove.
4798         * features/i386/i386-avx-avx512.xml: Remove.
4799         * features/i386/i386-avx-linux.xml: Remove.
4800         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4801         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4802         * features/i386/i386-avx-mpx-linux.xml: Remove.
4803         * features/i386/i386-avx-mpx.xml: Remove.
4804         * features/i386/i386-avx.xml: Remove.
4805         * features/i386/i386-linux.xml: Remove.
4806         * features/i386/i386-mmx-linux.xml: Remove.
4807         * features/i386/i386-mmx.xml: Remove.
4808         * features/i386/i386-mpx-linux.xml: Remove.
4809         * features/i386/i386-mpx.xml: Remove.
4810         * features/i386/i386.xml: Remove.
4811         * features/i386/x32-avx-avx512-linux.xml: Remove.
4812         * features/i386/x32-avx-linux.xml: Remove.
4813         * features/i386/x32-linux.xml: Remove.
4814
4815 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4816
4817         * regformats/aarch64.dat: Remove.
4818         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4819         * regformats/i386/amd64-avx-linux.dat: Remove.
4820         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4821         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4822         * regformats/i386/amd64-linux.dat: Remove.
4823         * regformats/i386/amd64-mpx-linux.dat: Remove.
4824         * regformats/i386/amd64.dat: Remove.
4825         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4826         * regformats/i386/i386-avx-linux.dat: Remove.
4827         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4828         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4829         * regformats/i386/i386-linux.dat: Remove.
4830         * regformats/i386/i386-mmx-linux.dat: Remove.
4831         * regformats/i386/i386-mpx-linux.dat: Remove.
4832         * regformats/i386/i386.dat: Remove.
4833         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4834         * regformats/i386/x32-avx-linux.dat: Remove.
4835         * regformats/i386/x32-linux.dat: Remove.
4836
4837 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4838
4839         * aarch64-tdep.c: Remove xml self tests.
4840         * amd64-linux-tdep.c: Likewise.
4841         * amd64-tdep.c: Likewise.
4842         * i386-linux-tdep.c: Likewise.
4843         * i386-tdep.c: Likewise.
4844
4845 2019-07-03  Pedro Alves  <palves@redhat.com>
4846
4847         PR cli/24732
4848         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4849         (pipe_cmd_option_defs): New.
4850         (make_pipe_cmd_options_def_group): New.
4851         (pipe_command): Use gdb::option::process_options.
4852         (pipe_command_completer): New function.
4853         (_initialize_cli_cmds): Install completer for "pipe" command.
4854
4855 2019-07-03  Pedro Alves  <palves@redhat.com>
4856
4857         * cli/cli-option.c (union option_value) <string>: New field.
4858         (struct option_def_and_value): Add ctor, move ctor, dtor and
4859         use DISABLE_COPY_AND_ASSIGN.
4860         (option_def_and_value::clear_value): New.
4861         (parse_option, save_option_value_in_ctx, get_val_type_str)
4862         (add_setshow_cmds_for_options): Handle var_string.
4863         * cli-option.h (union option_def::var_address) <string>: New
4864         field.
4865         (struct string_option_def): New.
4866         * maint-test-options.c (struct test_options_opts): Add default
4867         ctor and use DISABLE_COPY_AND_ASSIGN.
4868         <string_opt>: New field.
4869         (test_options_opts::~test_options_opts): New.
4870         (test_options_opts::dump): Also dump "-string".
4871         (test_options_option_defs): Install "string.
4872
4873 2019-07-03  Pedro Alves  <palves@redhat.com>
4874
4875         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4876         option_value with a null enumeration.
4877         (complete_options): Save the option values in the context.
4878         (save_option_value_in_ctx): New, factored out from ...
4879         (process_options): ... here.
4880         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4881         of the function.
4882         * maint-test-options.c (test_options_opts::dump): New, factored
4883         out from ...
4884         (maintenance_test_options_command_mode): ... here.
4885         (maintenance_test_options_command_completion_result): Delete.
4886         (maintenance_test_options_command_completion_text): Update
4887         comment.
4888         (maintenance_show_test_options_completion_result): Change
4889         prototype.  Just print
4890         maintenance_test_options_command_completion_text.
4891         (save_completion_result): New.
4892         (maintenance_test_options_completer_mode): Pass options context to
4893         complete_options, and then save a dump.
4894         (_initialize_maint_test_options): Use add_cmd to install "maint
4895         show test-options-completion-result".
4896
4897 2019-07-03  Pedro Alves  <palves@redhat.com>
4898
4899         * NEWS (New commands): Mention "with" and "maint with".
4900         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4901         (with_command, with_command_completer): New.
4902         (pipe_command): Adjust to new repeat_previous
4903         interface.
4904         (_initialize_cli_cmds): Install the "with" command and its "w"
4905         alias.
4906         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4907         declarations.
4908         * cli/cli-setshow.c (parse_cli_var_uinteger)
4909         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4910         argument strings for all var_types.
4911         (get_setshow_command_value_string): New, factored out from ...
4912         (do_show_command): ... this.
4913         * cli/cli-setshow.h: Include <string>.
4914         (get_setshow_command_value_string): Declare.
4915         * command.h (repeat_previous): Now returns const char *.  Adjust
4916         comment.
4917         * maint.c: Include "cli/cli-cmds.h".
4918         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4919         (_initialize_maint_cmds): Register the "maintenance with" command.
4920         * top.c (repeat_previous): Move bits from pipe_command here:
4921         Return the saved command line, if any; error out if there's no
4922         command to relaunch.
4923
4924 2019-07-03  Pedro Alves  <palves@redhat.com>
4925
4926         * NEWS (New commands): Mention "maint set/show test-settings"
4927         instead of "maint test-settings".
4928         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4929         (maintenance_test_settings_set_list): Rename to ...
4930         (maintenance_set_test_settings_list): ... this.
4931         (maintenance_test_settings_show_list): Rename to  ...
4932         (maintenance_show_test_settings_list): ... this.
4933         (maintenance_test_settings_cmd): Delete.
4934         (maintenance_test_settings_set_cmd): ...
4935         (maintenance_set_test_settings_cmd): ... this.
4936         (maintenance_test_settings_show_cmd): ...
4937         (maintenance_show_test_settings_cmd): ... this.
4938         (maintenance_test_settings_show_value_cmd):
4939         (maintenance_show_test_settings_value_cmd): ... this.
4940         (_initialize_maint_test_settings): No longer install the "maint
4941         test-settings" prefix command.  Rename "maint test-settings set"
4942         to "maint set test-settings", and "maint test-settings show" to
4943         "maint show test-settings".  Adjust all subcommands.
4944
4945 2019-07-03  Pedro Alves  <palves@redhat.com>
4946
4947         * maint-test-settings.c: Fix file's intro comment.  Replace all
4948         references to "test-options" with references to "test-settings",
4949         in comments.
4950
4951 2019-07-03  Pedro Alves  <palves@redhat.com>
4952
4953         * maint-test-settings.c (maintenance_test_settings_xxx)
4954         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4955         New.
4956         (maintenance_test_settings_enums): Use them.
4957         (maintenance_test_settings_enum): Default to
4958         maintenance_test_settings_xxx.
4959         (_initialize_maint_test_settings): Initialize
4960         MAINTENANCE_TEST_SETTINGS_FILENAME.
4961
4962 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4963
4964         * breakpoint.h (remove_breakpoints_inf): Change return type to
4965         void, move function documentation here.
4966         * breakpoint.c (remove_breakpoints_inf): Change return type to
4967         void, move function documentation to header.
4968
4969 2019-07-02  Pedro Alves  <palves@redhat.com>
4970
4971         * NEWS (Completion improvements): Mention "info threads".
4972         * thread.c (struct info_threads_opts, info_threads_option_defs)
4973         (make_info_threads_options_def_group): New.
4974         (info_threads_command): Use gdb::option::process_options.
4975         (info_threads_command_completer): New.
4976         (_initialize_thread): Use gdb::option::build_help to build the
4977         help text for "info threads".
4978
4979 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4980
4981         * defs.h (generic_load): Move from here...
4982         * symfile.h (generic_load): ... to here.  Rename name parameter
4983         to args.
4984         * symfile.c (generic_load): Add comment.
4985
4986 2019-07-01  Tom Tromey  <tromey@adacore.com>
4987
4988         * dwarf2read.c
4989         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4990         declaration of without_params.  Fix formatting.
4991
4992 2019-07-01  Tom Tromey  <tromey@adacore.com>
4993
4994         * ada-exp.y (find_primitive_type): Update.
4995         * ada-lang.h (ada_lookup_symbol): Update.
4996         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4997         parameter.
4998         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4999
5000 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5001
5002         PR breakpoints/24541
5003         * gdbarch.c: Regenerate.
5004         * gdbarch.h: Regenerate.
5005         * gdbarch.sh: Add 'stap_adjust_register'.
5006         * i386-tdep.c: Include '<unordered_set>'.
5007         (i386_stap_adjust_register): New function.
5008         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5009         * stap-probe.c (stap_parse_register_operand): Call
5010         'gdbarch_stap_adjust_register'.
5011
5012 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5013
5014         PR python/24742
5015         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5016         * python/python.c (do_start_initialization): Use 'xmalloc'
5017         instead of 'PyMem_Malloc'.
5018
5019 2019-06-28  Tom Tromey  <tromey@adacore.com>
5020
5021         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5022         for Ada.
5023
5024 2019-06-27  Tom Tromey  <tromey@adacore.com>
5025
5026         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5027         objfile_key.
5028         (arm_find_mapping_symbol, arm_record_special_symbol)
5029         (_initialize_arm_tdep): Update.
5030         (arm_objfile_data_free): Remove.
5031
5032 2019-06-27  Tom Tromey  <tromey@adacore.com>
5033
5034         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5035         to cp_print_static_field.
5036
5037 2019-06-26  Tom Tromey  <tromey@adacore.com>
5038
5039         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5040         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5041         declare.
5042
5043 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5044
5045         * features/aarch64-core.c (create_feature_aarch64_core):
5046         Regenerate.
5047         * features/aarch64-core.xml: Add cpsr flags.
5048
5049 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5050
5051         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5052         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5053
5054 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5055
5056         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5057         field.
5058         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5059         use.
5060         (arm_record_special_symbol): Don't insert new symbol in sorted
5061         position, push it at the end.
5062
5063 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5064
5065         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5066         (arm_mapping_symbol_s): Remove.
5067         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5068         (arm_mapping_symbol_vec): New typedef.
5069         (struct arm_per_objfile): Add constructor.
5070         <section_maps>: Change type to
5071         std::unique_ptr<arm_mapping_symbol_vec[]>.
5072         (arm_compare_mapping_symbols): Remove.
5073         (arm_find_mapping_symbol): Adjust to section_maps type change.
5074         (arm_objfile_data_free): Call delete on arm_per_objfile.
5075         (arm_record_special_symbol): Adjust to section_maps type change.
5076         Allocate arm_per_objfile with new.
5077
5078 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5079
5080         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5081         with the command prefix.
5082
5083 2019-06-25  Tom Tromey  <tom@tromey.com>
5084
5085         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5086         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5087
5088 2019-06-25  Tom Tromey  <tom@tromey.com>
5089
5090         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5091         type.
5092         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5093         protected.
5094
5095 2019-06-25  Tom Tromey  <tom@tromey.com>
5096
5097         * tui/tui-winsource.c
5098         (tui_source_window_base::set_is_exec_point_at): Add check against
5099         LOA_ADDRESS.
5100
5101 2019-06-25  Tom Tromey  <tom@tromey.com>
5102
5103         * tui/tui-source.c (tui_set_source_content): Don't check before
5104         xfree.
5105         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5106
5107 2019-06-25  Tom Tromey  <tom@tromey.com>
5108
5109         * tui/tui-winsource.h (tui_update_source_window_as_is)
5110         (tui_alloc_source_buffer, tui_line_is_displayed)
5111         (tui_addr_is_displayed): Change type of win_info.
5112         * tui/tui-winsource.c (tui_update_source_window_as_is)
5113         (tui_clear_source_content, tui_show_source_line)
5114         (tui_show_source_content, tui_source_window_base::refill)
5115         (tui_source_window_base::set_is_exec_point_at)
5116         (tui_source_window_base::set_is_exec_point_at)
5117         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5118         (tui_alloc_source_buffer, tui_line_is_displayed)
5119         (tui_addr_is_displayed): Change type of win_info.  Update.
5120         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5121         (tui_source_window_base::do_make_visible_with_new_height):
5122         Update.
5123         * tui/tui-source.c (tui_set_source_content)
5124         (tui_set_source_content_nil)
5125         (tui_source_window::do_scroll_vertical): Update.
5126         * tui/tui-layout.c (show_layout): Update.
5127         * tui/tui-disasm.c (tui_set_disassem_content)
5128         (tui_disasm_window::do_scroll_vertical): Update.
5129         * tui/tui-data.h (tui_win_content): Remove.
5130         (struct tui_gen_win_info) <content, content_size>: Remove.
5131         (struct tui_source_element): Add initializers and destructor.
5132         (union tui_which_element, struct tui_win_element): Remove.
5133         (struct tui_source_window_base) <content>: New field.
5134         (struct tui_data_window): Remove destructor.
5135         (tui_alloc_content, tui_free_win_content)
5136         (tui_free_all_source_wins_content): Don't declare.
5137         * tui/tui-data.c (tui_initialize_static_data): Update.
5138         (init_content_element, tui_alloc_content): Remove.
5139         (~tui_gen_win_info): Update.
5140         (~tui_data_window, tui_free_all_source_wins_content)
5141         (tui_free_win_content, free_content, free_content_elements):
5142         Remove.
5143
5144 2019-06-25  Tom Tromey  <tom@tromey.com>
5145
5146         * tui/tui-winsource.h (tui_clear_source_content)
5147         (tui_erase_source_content, tui_show_source_content): Change type
5148         of win_info.
5149         * tui/tui-winsource.c (tui_clear_source_content)
5150         (tui_erase_source_content, tui_show_source_content): Change type
5151         of win_info.
5152         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5153         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5154         win_info.
5155         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5156         win_info.
5157         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5158
5159 2019-06-25  Tom Tromey  <tom@tromey.com>
5160
5161         * tui/tui-winsource.c (tui_clear_source_content)
5162         (tui_source_window_base::set_is_exec_point_at): Update.
5163         * tui/tui-source.c (tui_set_source_content_nil): Update.
5164         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5165         a bool.
5166         * tui/tui-data.c (init_content_element): Update.
5167
5168 2019-06-25  Tom Tromey  <tom@tromey.com>
5169
5170         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5171         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5172         * tui/tui-layout.c (init_and_make_win): Update.
5173         * tui/tui.h (enum tui_win_type): Update.
5174         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5175         tui_win_is_auxillary.
5176         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5177         tui_win_is_auxillary.
5178
5179 2019-06-25  Tom Tromey  <tom@tromey.com>
5180
5181         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5182         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5183         (tui_delete_data_content_windows, tui_display_all_data)
5184         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5185         Update.
5186         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5187         * tui/tui-regs.c (tui_last_regs_line_no)
5188         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5189         (tui_show_registers): Update.
5190         (tui_show_register_group): Return void.  Update.
5191         (tui_display_registers_from, tui_display_reg_element_at_line)
5192         (tui_display_registers_from_line, tui_check_register_values):
5193         Update.
5194         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5195         member.
5196         (struct tui_data_window) <regs_content>: Now a std::vector.
5197         <regs_content_count>: Remove.
5198         (tui_add_content_elements, tui_free_data_content): Don't declare.
5199         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5200         (init_content_element): Remove DATA_WIN case.  Add assert.
5201         (tui_add_content_elements): Remove.
5202         (tui_data_window): Update.
5203         (tui_free_data_content): Remove.
5204         (free_content_elements): Remove DATA_WIN case.
5205
5206 2019-06-25  Tom Tromey  <tom@tromey.com>
5207
5208         * tui/tui-data.c (tui_data_item_window): Update.
5209         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5210         * tui/tui-windata.c (tui_display_all_data)
5211         (tui_display_data_from_line): Update.
5212         (tui_check_data_values): Remove.
5213         * tui/tui-regs.c (tui_show_register_group)
5214         (tui_display_reg_element_at_line): Update.
5215         * tui/tui-hooks.c (tui_register_changed)
5216         (tui_refresh_frame_and_register_information): Call
5217         tui_check_register_values.
5218         * tui/tui-data.h (struct tui_data_window) <data_content,
5219         data_content_count, data_type>: Remove.
5220         (enum tui_data_type): Remove.
5221
5222         * tui/tui-data.c (tui_data_window::clear_detail)
5223         (~tui_data_window): Update.
5224
5225 2019-06-25  Tom Tromey  <tom@tromey.com>
5226
5227         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5228         declare.
5229         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5230         Rename from tui_first_data_item_displayed.  Update.
5231         (tui_data_window::refresh_all)
5232         (tui_data_window::do_scroll_vertical): Update.
5233         * tui/tui-data.h (struct tui_data_window)
5234         <first_data_item_displayed>: Declare new method.
5235
5236 2019-06-25  Tom Tromey  <tom@tromey.com>
5237
5238         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5239         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5240         contents...
5241         (tui_initialize_static_data): ...here.
5242
5243 2019-06-25  Tom Tromey  <tom@tromey.com>
5244
5245         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5246         (tui_display_registers_from, tui_check_register_values): Update.
5247         (tui_display_register): Remove win_info parameter; update.
5248         (tui_get_register): Change type of parameters.
5249         * tui/tui-data.h (struct tui_data_element): Remove.
5250         (union tui_which_element) <data>: Remove.
5251         <data_window>: Change type.
5252         (struct tui_data_item_window): New.
5253         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5254         case.  Add assert.
5255         (~tui_data_item_window): New destructor.
5256         (free_content_elements): Remove DATA_ITEM_WIN case.
5257
5258 2019-06-25  Tom Tromey  <tom@tromey.com>
5259
5260         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5261         Remove.
5262
5263 2019-06-25  Tom Tromey  <tom@tromey.com>
5264
5265         * tui/tui-data.h (struct tui_command_element): Remove.
5266         (union tui_which_element) <command>: Remove.
5267         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5268         assert.
5269         (free_content_elements): Remove CMD_WIN case.
5270
5271 2019-06-25  Tom Tromey  <tom@tromey.com>
5272
5273         * tui/tui-layout.c (tui_set_layout): Update.
5274         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5275         * tui/tui-data.c (layout_def): Update.
5276
5277 2019-06-25  Tom Tromey  <tom@tromey.com>
5278
5279         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5280         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5281         (tui_source_window_base::set_new_height): Update.
5282         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5283         Update.
5284         (tui_set_locator_fullname, tui_set_locator_info)
5285         (tui_show_frame_info): Update.
5286         * tui/tui-source.c (tui_set_source_content)
5287         (tui_source_is_displayed): Update.
5288         * tui/tui-layout.c (show_source_disasm_command, show_data)
5289         (show_source_or_disasm_and_command): Update.
5290         * tui/tui-disasm.c (tui_set_disassem_content)
5291         (tui_get_begin_asm_address): Update.
5292         * tui/tui-data.h (struct tui_locator_element): Remove.
5293         (union tui_which_element) <locator>: Remove.
5294         (struct tui_locator_window): New.
5295         (tui_locator_win_info_ptr): Change return type.
5296         * tui/tui-data.c (_locator): Change type.
5297         (tui_locator_win_info_ptr): Change return type.
5298         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5299         (tui_alloc_content): Add assert.
5300
5301 2019-06-25  Tom Tromey  <tom@tromey.com>
5302
5303         * tui/tui-winsource.c
5304         (tui_exec_info_window::maybe_allocate_content): New method.
5305         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5306         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5307         (make_source_or_disasm_window): Add cast.
5308         * tui/tui-data.h (union tui_which_element) <simple_string>:
5309         Remove.
5310         (struct tui_source_info): New.
5311         (struct tui_source_window_base) <execution_info>: Change type.
5312         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5313         case, and add assert.
5314         (tui_alloc_content): Add assert.
5315
5316 2019-06-25  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5319         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5320         * tui/tui-data.c (tui_alloc_win_info): Remove.
5321
5322 2019-06-25  Tom Tromey  <tom@tromey.com>
5323
5324         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5325         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5326         can_highlight.
5327
5328 2019-06-25  Tom Tromey  <tom@tromey.com>
5329
5330         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5331         make_visible_with_new_height method.
5332         (tui_win_info::make_visible_with_new_height): New method.
5333         (tui_source_window_base::do_make_visible_with_new_height)
5334         (tui_data_window::do_make_visible_with_new_height)
5335         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5336         (make_visible_with_new_height): Remove.
5337         (tui_resize_all, tui_adjust_win_heights): Use
5338         make_visible_with_new_height method.
5339         * tui/tui-data.h (struct tui_win_info)
5340         <do_make_visible_with_new_height, make_visible_with_new_height>:
5341         New methods.
5342         (struct tui_source_window_base, struct tui_data_window)
5343         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5344         methods.
5345
5346 2019-06-25  Tom Tromey  <tom@tromey.com>
5347
5348         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5349         method.
5350         (update_tab_width): Call update_tab_width method.
5351         * tui/tui-data.h (struct tui_win_info)
5352         (struct tui_source_window_base) <update_tab_width>: New methods.
5353
5354 2019-06-25  Tom Tromey  <tom@tromey.com>
5355
5356         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5357         parameter.
5358         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5359         parameter.
5360         (tui_gen_win_info::make_visible): Update.
5361         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5362         parameter.
5363         * tui/tui-data.h (enum tui_box): New enum.
5364         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5365
5366 2019-06-25  Tom Tromey  <tom@tromey.com>
5367
5368         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5369         init_and_make_win for EXEC_INFO_WIN.
5370         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5371         longer inline.
5372         (struct tui_win_info) <~tui_win_info>: Inline.
5373         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5374         Don't declare.
5375         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5376         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5377         Remove.
5378         (tui_initialize_static_data): Update.
5379         (~tui_gen_win_info): Handle more cleanup here.
5380         (~tui_source_window_base): Delete "execution_info".
5381         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5382
5383 2019-06-25  Tom Tromey  <tom@tromey.com>
5384
5385         * tui/tui-layout.c (make_command_window): Don't set
5386         can_highlight.
5387         (show_source_disasm_command): Call the reset method.
5388         (show_data): Don't set can_highlight.  Call the reset method.
5389         (tui_gen_win_info::reset): Rename from init_gen_win_info
5390         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5391         (show_source_or_disasm_and_command): Call the reset method.
5392         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5393         (struct tui_cmd_window): Set can_highlight.
5394
5395 2019-06-25  Tom Tromey  <tom@tromey.com>
5396
5397         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5398         from make_visible.
5399         (tui_make_visible, tui_make_invisible): Rewrite.
5400         (tui_win_info::make_visible): Remove.
5401         (tui_source_window_base::make_visible): Update.
5402         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5403         method.  Moved from...
5404         (struct tui_win_info) <make_visible>: ...here.
5405
5406 2019-06-25  Tom Tromey  <tom@tromey.com>
5407
5408         * tui/tui-winsource.c
5409         (tui_source_window_base::do_scroll_horizontal): Remove direction
5410         parameter.
5411         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5412         direction parameter.
5413         * tui/tui-win.c (tui_win_info::forward_scroll)
5414         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5415         (tui_win_info::right_scroll): Update.
5416         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5417         direction parameter.
5418         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5419         direction parameter.
5420         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5421         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5422         Remove direction parameter.
5423         (struct tui_source_window_base, struct tui_source_window)
5424         (struct tui_disasm_window, struct tui_data_window)
5425         (struct tui_cmd_window): Update.
5426
5427 2019-06-25  Tom Tromey  <tom@tromey.com>
5428
5429         * tui/tui-winsource.h (tui_set_exec_info_content)
5430         (tui_show_exec_info_content, tui_erase_exec_info_content)
5431         (tui_clear_exec_info_content, tui_update_exec_info): Change
5432         argument to tui_source_window_base.
5433         * tui/tui-winsource.c (tui_set_exec_info_content)
5434         (tui_show_exec_info_content, tui_erase_exec_info_content)
5435         (tui_clear_exec_info_content, tui_update_exec_info): Change
5436         argument to tui_source_window_base.
5437
5438 2019-06-25  Tom Tromey  <tom@tromey.com>
5439
5440         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5441         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5442
5443 2019-06-25  Tom Tromey  <tom@tromey.com>
5444
5445         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5446         check.
5447
5448 2019-06-25  Tom Tromey  <tom@tromey.com>
5449
5450         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5451         type to void.
5452         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5453         type to void.
5454         * tui/tui-source.c (tui_set_source_content): Update.
5455         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5456
5457 2019-06-25  Tom Tromey  <tom@tromey.com>
5458
5459         * tui/tui-win.c (window_name_completer, tui_set_focus)
5460         (tui_all_windows_info): Use name method.
5461         * tui/tui-data.h (struct tui_gen_win_info)
5462         (struct tui_source_window, struct tui_disasm_window)
5463         (struct tui_data_window, struct tui_cmd_window) <name>: New
5464         method.
5465         (tui_win_name): Don't declare.
5466         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5467         (tui_win_name): Remove.
5468
5469 2019-06-25  Tom Tromey  <tom@tromey.com>
5470
5471         * tui/tui-winsource.h (tui_update_source_window)
5472         (tui_update_source_window_as_is): Change parameter type.
5473         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5474         to be a tui_source_window_base.
5475         (tui_update_source_window_as_is): Likewise.
5476         * tui/tui-win.c (make_visible_with_new_height): Update.
5477
5478 2019-06-25  Tom Tromey  <tom@tromey.com>
5479
5480         * tui/tui-winsource.c (tui_erase_source_content)
5481         (tui_show_source_content, tui_show_exec_info_content)
5482         (tui_erase_exec_info_content): Use refresh_window method.
5483         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5484         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5485         from tui_refresh_win.
5486         (tui_data_window::refresh_window): New method.
5487         (tui_win_info::refresh, tui_source_window_base::refresh)
5488         (tui_refresh_all): Use refresh_window method.
5489         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5490         method.
5491         * tui/tui-regs.c (tui_display_register): Call refresh_window
5492         method.
5493         * tui/tui-layout.c (show_source_disasm_command)
5494         (show_source_or_disasm_and_command): Call refresh_window method.
5495         * tui/tui-data.h (struct tui_gen_win_info)
5496         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5497         New method.
5498
5499 2019-06-25  Tom Tromey  <tom@tromey.com>
5500
5501         * tui/tui.c (tui_rl_other_window, tui_enable)
5502         (tui_is_window_visible, tui_get_command_dimension): Update.
5503         * tui/tui-winsource.c (tui_update_source_window_as_is)
5504         (tui_clear_source_content, tui_erase_source_content)
5505         (tui_show_source_line, tui_source_window_base::refill)
5506         (tui_source_window_base::do_scroll_horizontal)
5507         (tui_source_window_base::set_is_exec_point_at)
5508         (tui_update_breakpoint_info, tui_set_exec_info_content)
5509         (tui_alloc_source_buffer, tui_line_is_displayed)
5510         (tui_addr_is_displayed): Update.
5511         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5512         (tui_check_and_display_highlight_if_needed)
5513         (tui_win_info::make_visible, tui_win_info::refresh)
5514         (tui_refresh_all): Update.
5515         * tui/tui-windata.c (tui_first_data_item_displayed)
5516         (tui_delete_data_content_windows, tui_erase_data_content)
5517         (tui_display_all_data, tui_data_window::refresh_all)
5518         (tui_check_data_values): Update.
5519         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5520         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5521         (tui_win_info::backward_scroll, tui_refresh_all_win)
5522         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5523         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5524         (tui_source_window_base::set_new_height)
5525         (tui_data_window::set_new_height)
5526         (make_invisible_and_set_new_height)
5527         (make_visible_with_new_height, new_height_ok)
5528         (parse_scrolling_args): Update.
5529         * tui/tui-stack.c (tui_show_frame_info): Update.
5530         * tui/tui-source.c (tui_set_source_content)
5531         (tui_set_source_content_nil, tui_source_is_displayed)
5532         (tui_source_window::do_scroll_vertical): Update.
5533         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5534         (tui_display_registers_from, tui_display_reg_element_at_line)
5535         (tui_check_register_values, tui_reg_command): Update.
5536         * tui/tui-layout.c (tui_default_win_height)
5537         (show_source_disasm_command, show_data, init_and_make_win)
5538         (show_source_or_disasm_and_command): Update.
5539         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5540         (tui_redisplay_readline, tui_mld_flush)
5541         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5542         (tui_getc): Update.
5543         * tui/tui-disasm.c (tui_set_disassem_content)
5544         (tui_disasm_window::do_scroll_vertical): Update.
5545         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5546         Now virtual.
5547         (struct tui_win_info): Derive from tui_gen_win_info.
5548         <~tui_win_info>: Mark as override.
5549         <generic>: Remove member.
5550         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5551         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5552         (~tui_data_window, ~tui_win_info)
5553         (tui_free_all_source_wins_content): Update.
5554         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5555
5556 2019-06-25  Tom Tromey  <tom@tromey.com>
5557
5558         * tui/tui-layout.c (init_and_make_win): Use new.
5559         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5560         destructor, initializers.
5561         (tui_alloc_generic_win_info): Don't declare.
5562         * tui/tui-data.c (_locator): Add argument to constructor.
5563         (source_win, disasm_win): New globals.
5564         (exec_info): Remove.
5565         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5566         Update.
5567         (tui_alloc_generic_win_info): Remove.
5568         (init_content_element): Use new.
5569         (tui_win_info::tui_win_info): Update.
5570         (free_content_elements) <case DATA_WIN>: Use delete.
5571
5572 2019-06-25  Tom Tromey  <tom@tromey.com>
5573
5574         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5575         * tui/tui-windata.c (tui_first_data_item_displayed)
5576         (tui_delete_data_content_windows): Update.
5577         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5578         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5579         (tui_display_registers_from, tui_check_register_values): Update.
5580         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5581         pointer.
5582         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5583         window.
5584         (tui_free_data_content): Update.
5585         (free_content_elements) <case DATA_WIN>: Free the window.
5586
5587 2019-06-25  Tom Tromey  <tom@tromey.com>
5588
5589         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5590         Update.
5591         * tui/tui-layout.c (make_command_window)
5592         (show_source_disasm_command, show_data, init_and_make_win)
5593         (show_source_or_disasm_and_command): Update.
5594         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5595         method.
5596         <can_highight, is_highlighted>: Now bool.
5597         (tui_set_win_highlight): Don't declare.
5598         * tui/tui-data.c (tui_set_win_highlight): Remove.
5599
5600 2019-06-25  Tom Tromey  <tom@tromey.com>
5601
5602         * tui/tui-wingeneral.c (make_visible): Remove check of window
5603         type.
5604
5605 2019-06-25  Tom Tromey  <tom@tromey.com>
5606
5607         * tui/tui-win.c (tui_win_info::max_height)
5608         (tui_cmd_window::max_height): New methods.
5609         (new_height_ok): Call max_height.
5610         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5611         <max_height>: New method.
5612
5613 2019-06-25  Tom Tromey  <tom@tromey.com>
5614
5615         * tui/tui-win.c (tui_source_window_base::set_new_height)
5616         (tui_data_window::set_new_height): New methods.
5617         (make_invisible_and_set_new_height): Call set_new_height method.
5618         * tui/tui-data.h (struct tui_win_info)
5619         (struct tui_source_window_base, struct tui_data_window)
5620         <set_new_height>: New method.
5621
5622 2019-06-25  Tom Tromey  <tom@tromey.com>
5623
5624         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5625         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5626         tui_refresh_data_win.
5627         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5628         method.
5629         (tui_refresh_all_win): Call the refresh_all method.
5630         (tui_set_focus): Likewise.
5631         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5632         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5633         Likewise.
5634
5635 2019-06-25  Tom Tromey  <tom@tromey.com>
5636
5637         * tui/tui-winsource.h (tui_refill_source_window)
5638         (tui_set_is_exec_point_at): Don't declare.
5639         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5640         (tui_source_window_base::refill): Rename from
5641         tui_refill_source_window.
5642         (tui_source_window_base::do_scroll_horizontal): Update.
5643         (tui_source_window_base::set_is_exec_point_at): Rename from
5644         tui_set_is_exec_point_at.
5645         (tui_update_all_breakpoint_info): Update.
5646         * tui/tui-stack.c (tui_show_frame_info): Update.
5647         * tui/tui-layout.c (show_data): Add cast.
5648         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5649         * tui/tui-data.h (struct tui_source_window_base) <refill,
5650         set_is_exec_point_at>: New methods.
5651         (tui_source_windows, tui_add_to_source_windows): Update types.
5652         (tui_add_to_source_windows): Remove redundant declaration.
5653         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5654         (tui_source_windows): Change return type.
5655         (tui_clear_source_windows_detail): Update.
5656         (tui_add_to_source_windows): Change type of parameter.
5657         (tui_free_all_source_wins_content): Update.
5658
5659 2019-06-25  Tom Tromey  <tom@tromey.com>
5660
5661         * tui/tui-wingeneral.c (tui_win_info::refresh)
5662         (tui_source_window_base::refresh): New methods.
5663         (tui_refresh_all): Call the refresh method.
5664         * tui/tui-data.h (struct tui_win_info)
5665         (struct tui_source_window_base) <refresh>: New method.
5666
5667 2019-06-25  Tom Tromey  <tom@tromey.com>
5668
5669         * tui/tui.h (tui_is_window_visible): Return bool.
5670         * tui/tui.c (tui_is_window_visible): Return bool.
5671         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5672         (tui_make_visible, tui_make_invisible)
5673         (tui_win_info::make_visible)
5674         (tui_source_window_base::make_visible, make_all_visible)
5675         (tui_make_all_visible, tui_make_all_invisible): Update.
5676         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5677         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5678         bool.
5679         (struct tui_win_info, struct tui_source_window_base)
5680         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5681         * tui/tui-data.c (tui_init_generic_part): Update.
5682
5683 2019-06-25  Tom Tromey  <tom@tromey.com>
5684
5685         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5686         (tui_source_window_base::make_visible): New methods.
5687         (make_all_visible): Make method call.
5688         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5689         (struct tui_source_window_base, struct tui_cmd_window): Override
5690         make_visible.
5691         (tui_win_is_source_type): Don't declare.
5692         * tui/tui-data.c (tui_win_is_source_type): Remove.
5693
5694 2019-06-25  Tom Tromey  <tom@tromey.com>
5695
5696         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5697         NULL check.
5698
5699 2019-06-25  Tom Tromey  <tom@tromey.com>
5700
5701         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5702         Inline constructor.  Add initializers for members.
5703         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5704         constructors; now inline in class.
5705
5706 2019-06-25  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-regs.c (tui_show_registers): Update.
5709         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5710         bool.
5711         * tui/tui-data.c (tui_data_window::clear_detail)
5712         (tui_data_window): Update.
5713
5714 2019-06-25  Tom Tromey  <tom@tromey.com>
5715
5716         * tui/tui-windata.c (tui_display_all_data)
5717         (tui_display_data_from_line, tui_display_data_from)
5718         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5719         Update.
5720         * tui/tui-regs.c (tui_last_regs_line_no)
5721         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5722         (tui_show_registers, tui_show_register_group)
5723         (tui_display_registers_from, tui_display_reg_element_at_line)
5724         (tui_display_registers_from_line, tui_check_register_values)
5725         (tui_reg_next, tui_reg_prev): Update.
5726         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5727         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5728         tui_data_window.
5729         (struct tui_win_info) <detail>: Remove.  Add new fields from
5730         tui_data_info.
5731         (TUI_DATA_WIN): Add cast.
5732         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5733         (~tui_data_window): Simplify.
5734
5735 2019-06-25  Tom Tromey  <tom@tromey.com>
5736
5737         * tui/tui-layout.c (show_source_disasm_command)
5738         (show_source_or_disasm_and_command): Update.
5739         * tui/tui-io.c (update_cmdwin_start_line)
5740         (tui_redisplay_readline): Update.
5741         * tui/tui-data.h (struct tui_command_info): Remove.
5742         (struct tui_win_info) <detail>: Remove command_info member.
5743         (struct tui_data_window) <start_line>: New member, from
5744         tui_command_info.
5745         (TUI_CMD_WIN): Add casts.
5746
5747 2019-06-25  Tom Tromey  <tom@tromey.com>
5748
5749         * tui/tui-winsource.c (tui_update_source_window)
5750         (tui_refill_source_window)
5751         (tui_source_window_base::do_scroll_horizontal)
5752         (tui_update_breakpoint_info, tui_set_exec_info_content)
5753         (tui_show_exec_info_content, tui_erase_exec_info_content)
5754         (tui_clear_exec_info_content): Update.
5755         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5756         Update.
5757         * tui/tui-win.c (make_invisible_and_set_new_height)
5758         (make_visible_with_new_height): Update.
5759         * tui/tui-source.c (tui_set_source_content)
5760         (tui_show_symtab_source): Update.
5761         * tui/tui-layout.c (extract_display_start_addr)
5762         (show_source_disasm_command, show_data)
5763         (make_source_or_disasm_window)
5764         (show_source_or_disasm_and_command): Update.
5765         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5766         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5767         "gdbarch".
5768         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5769         to tui_source_window_base.
5770         (struct tui_win_info) <detail>: Remove source_info member.
5771         (struct tui_source_window_base) <has_locator>: Inline.
5772         Move contents from tui_source_info; rename has_locator member to
5773         m_has_locator.
5774         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5775         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5776         header file.
5777         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5778         Simplify.
5779         (tui_free_all_source_wins_content): Cast to
5780         tui_source_window_base.
5781
5782 2019-06-25  Tom Tromey  <tom@tromey.com>
5783
5784         * tui/tui-win.c (make_invisible_and_set_new_height)
5785         (make_visible_with_new_height): Call has_locator method.
5786         * tui/tui-layout.c (show_source_disasm_command, show_data)
5787         (show_source_or_disasm_and_command): Update for bool change.
5788         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5789         (tui_win_info) <has_locator>: New method.
5790         (struct tui_source_window_base) <has_locator>: New method.
5791         (tui_win_has_locator): Don't declare.
5792         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5793         from tui_win_has_locator.
5794         (tui_source_window_base): Use false, not FALSE.
5795
5796 2019-06-25  Tom Tromey  <tom@tromey.com>
5797
5798         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5799         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5800         clear_detail method directly.
5801         (tui_clear_win_detail): Remove.
5802
5803 2019-06-25  Tom Tromey  <tom@tromey.com>
5804
5805         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5806         "this", not TUI_DISASM_WIN.
5807
5808 2019-06-25  Tom Tromey  <tom@tromey.com>
5809
5810         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5811         declare.
5812         * tui/tui-winsource.c
5813         (tui_source_window_base::do_scroll_horizontal): Rename from
5814         tui_horizontal_source_scroll.
5815         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5816         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5817         from tui_vertical_data_scroll.
5818         * tui/tui-win.h (tui_scroll): Don't declare.
5819         * tui/tui-win.c (tui_win_info::forward_scroll)
5820         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5821         (tui_win_info::right_scroll): Rename and update.
5822         (tui_scroll_forward_command, tui_scroll_backward_command)
5823         (tui_scroll_left_command, tui_scroll_right_command): Update.
5824         (tui_scroll): Remove.
5825         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5826         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5827         from tui_vertical_source_scroll.
5828         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5829         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5830         from tui_vertical_disassem_scroll.
5831         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5832         do_scroll_horizontal>: New methods.
5833         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5834         Likewise.
5835         (struct tui_source_window_base): Add do_scroll_horizontal.
5836         (struct tui_source_window, struct tui_disasm_window): Add
5837         do_scroll_vertical.
5838         (struct tui_data_window, struct tui_cmd_window): Add
5839         do_scroll_horizontal and do_scroll_vertical.
5840         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5841
5842 2019-06-25  Tom Tromey  <tom@tromey.com>
5843
5844         * tui/tui-data.h (struct tui_source_window_base): New struct.
5845         (struct tui_source_window): Derive from tui_source_window_base.
5846         (struct tui_disasm_window): New struct.
5847         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5848         from tui_source_window::clear_detail.
5849         (tui_source_window_base): Rename from tui_source_window.
5850         (~tui_source_window_base): Rename from ~tui_source_window.
5851         (tui_alloc_win_info): Create a tui_disasm_window.
5852
5853 2019-06-25  Tom Tromey  <tom@tromey.com>
5854
5855         * tui/tui-data.h (struct tui_source_window)
5856         (struct tui_data_window): Declare destructors.
5857         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5858         destructors.
5859         (tui_win_info): Simplify.
5860
5861 2019-06-25  Tom Tromey  <tom@tromey.com>
5862
5863         * tui/tui-winsource.c (tui_display_main)
5864         (tui_update_source_windows_with_addr)
5865         (tui_update_all_breakpoint_info): Update.
5866         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5867         (new_height_ok, parse_scrolling_args): Update.
5868         * tui/tui-stack.c (tui_show_frame_info): Update.
5869         * tui/tui-data.h (struct tui_list): Remove.
5870         (tui_source_windows): Return a reference to a std::vector.
5871         * tui/tui-data.c (source_windows): Now a std::vector.
5872         (tui_source_windows): Change return type.
5873         (tui_clear_source_windows): Rewrite.
5874         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5875         (tui_free_all_source_wins_content): Rewrite.
5876
5877 2019-06-25  Tom Tromey  <tom@tromey.com>
5878
5879         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5880         (struct tui_data_window, struct tui_cmd_window): Declare
5881         clear_detail method.
5882         * tui/tui-data.c (tui_source_window::clear_detail)
5883         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5884         methods.
5885         (tui_clear_win_detail): Simplify.
5886
5887 2019-06-25  Tom Tromey  <tom@tromey.com>
5888
5889         * tui/tui-layout.c (make_source_window, make_disasm_window)
5890         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5891         Return the new window.
5892         (show_source_disasm_command, show_data)
5893         (show_source_or_disasm_and_command): Update.
5894
5895 2019-06-25  Tom Tromey  <tom@tromey.com>
5896
5897         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5898         parameter.  Return the new window.
5899         (show_source_disasm_command): Update and remove NULL check.
5900         (show_source_or_disasm_and_command): Update.
5901
5902 2019-06-25  Tom Tromey  <tom@tromey.com>
5903
5904         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5905
5906 2019-06-25  Tom Tromey  <tom@tromey.com>
5907
5908         * tui/tui-data.h (struct tui_win_info): Make constructor
5909         protected.  Make destructor virtual.  Add initializers.
5910         (tui_source_window, tui_data_window, tui_cmd_window): New
5911         classes.
5912         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5913         constructor.  Add "type" parameter.
5914         (tui_source_window, tui_data_window, tui_cmd_window): New
5915         constructors.
5916         (tui_alloc_win_info): Instantiate the appropriate subclass.
5917
5918 2019-06-25  Tom Tromey  <tom@tromey.com>
5919
5920         * tui/tui-win.c (tui_resize_all): Use delete.
5921         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5922         destructor.
5923         (tui_free_window): Don't declare.
5924         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5925         Update.
5926
5927 2019-06-25  Tom Tromey  <tom@tromey.com>
5928
5929         * tui/tui-data.h (struct tui_win_info): Add constructor.
5930         * tui/tui-data.c (tui_alloc_win_info): Use new.
5931         (tui_free_window): Use delete.
5932
5933 2019-06-22  Tom Tromey  <tom@tromey.com>
5934
5935         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5936         declare.
5937         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5938
5939 2019-06-22  Tom Tromey  <tom@tromey.com>
5940
5941         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5942         declare.
5943         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5944
5945 2019-06-22  Tom de Vries  <tdevries@suse.de>
5946
5947         * dwarf2read.c (create_addrmap_from_aranges)
5948         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5949         instead of '%zu'.
5950
5951 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5952
5953         * dwarf2read.h (dwarf2_section_info_def): Remove.
5954         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5955         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5956         std::vector<dwarf2_section_info>.
5957         (struct dwo_file) <~dwo_file>: Remove.
5958         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5959         types field.
5960         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5961         (dwarf2_read_debug_names): Likewise.
5962         (create_debug_types_hash_table): Change parameter type to
5963         array_view, adjust code accordingly.
5964         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5965         (partial_die_info::fixup): Likewise.
5966         (determine_prefix): Likewise.
5967         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5968
5969 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5970
5971         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5972         gdb_bfd_ref_ptr.
5973         <~dwo_file>: Remove call to gdb_bfd_unref.
5974         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5975         gdb_bfd_ref_ptr::get.
5976
5977 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5978
5979         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5980         type to htab_up.
5981         * dwarf2read.c (struct dwo_file): Initialize fields.
5982         <~dwo_file>: New.
5983         (free_dwo_file): Remove, move content to ~dwo_file.
5984         (struct dwo_file_deleter): Remove.
5985         (dwo_file_up>: Remove custom deleter.
5986         (free_dwo_files): Remove.
5987         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5988         dwo_files.
5989         (process_skeletonless_type_units): Call unique_ptr::get.
5990         (allocate_dwo_file_hash_table): Add deleter to created hash
5991         table.  Change return type to htab_up.
5992         (lookup_dwo_file_slot): Don't memset dwo_file, call
5993         unique_ptr::get.
5994         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5995         (create_dwo_unit_in_dwp_v2): Likewise.
5996         (open_and_init_dwo_file): Likewise.
5997         (free_dwo_file_from_slot): Remove.
5998
5999 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6000
6001         * dwarf2read.h (struct dwarf2_section_info) <readin,
6002         is_virtual>: Change type to bool.
6003         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6004         true instead of 1.
6005
6006 2019-06-19  Tom Tromey  <tom@tromey.com>
6007
6008         * tui/tui-data.h (tui_init_content_element): Don't declare.
6009
6010 2019-06-19  Tom Tromey  <tom@tromey.com>
6011
6012         * tui/tui-data.h (tui_init_win_info): Don't declare.
6013
6014 2019-06-19  Tom de Vries  <tdevries@suse.de>
6015
6016         * dwarf2read.h (abstract_to_concrete): Change type to
6017         std::unordered_map<sect_offset, std::vector<sect_offset>,
6018         gdb::hash_enum<sect_offset>>.
6019
6020 2019-06-19  Tom Tromey  <tromey@adacore.com>
6021
6022         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6023         EVAL_AVOID_SIDE_EFFECTS specially.
6024
6025 2019-06-19  Tom Tromey  <tromey@adacore.com>
6026
6027         * source-cache.c (highlighter): New global.
6028         (source_cache::get_source_lines): Create a highlighter on demand.
6029
6030 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6031
6032         * defs.h (deprecated_interactive_hook): Delete declaration.
6033         * interps.c (clear_interpreter_hooks): Remove use of
6034         deprecated_interactive_hook.
6035         * top.c (deprecated_interactive_hook): Delete definition.
6036         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6037
6038 2019-06-18  Tom de Vries  <tdevries@suse.de>
6039
6040         PR gdb/24515
6041         * dwarf2read.h (abstract_to_concrete): Change type from
6042         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6043         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6044         * dwarf2read.c (read_variable): Update.
6045         (dwarf2_fetch_die_loc_sect_off): Update.
6046
6047 2019-06-17  Tom de Vries  <tdevries@suse.de>
6048
6049         PR gdb/24617
6050         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6051         accessing parent[parent_len - 1].
6052
6053 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6054
6055         PR gdb/24364
6056         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6057         call dtrace_process_dof with NULL dof.
6058
6059 2019-06-16  Tom de Vries  <tdevries@suse.de>
6060
6061         PR gdb/24445
6062         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6063
6064 2019-06-16  Tom Tromey  <tom@tromey.com>
6065
6066         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6067         (make_all_visible): Use address of member.
6068
6069 2019-06-16  Tom Tromey  <tom@tromey.com>
6070
6071         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6072         (tui_free_window, free_content, free_content_elements): Remove
6073         unnecessary cast.
6074         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6075         cast.
6076         * tui/tui-regs.c (tui_show_register_group)
6077         (tui_display_registers_from, tui_display_reg_element_at_line):
6078         Remove unnecessary cast.
6079
6080 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6081
6082         * linux-nat.c (normal_mask): Delete.
6083         (_initialize_linux_nat): Don't initialise normal_mask.
6084
6085 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6086
6087         PR gdb/24445
6088         * dwarf-index-write.h (write_psymtabs_to_index): Add
6089         dwz_basename parameter.
6090         * dwarf-index-write.c (write_gdbindex): Move file writing to
6091         write_gdbindex_1.  Change return type void.
6092         (assert_file_size): Move up, remove filename parameter.
6093         (write_gdbindex_1): New function.
6094         (write_debug_names): Change return type to void, call
6095         assert_file_size.
6096         (struct index_wip_file): New struct.
6097         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6098         file logic to index_wip_file.  Write index for dwz file if
6099         needed.
6100         (save_gdb_index_command): Pass basename of dwz file, if present.
6101         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6102         build-id of dwz file, if present.
6103         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6104         (dwarf2_get_dwz_file): Likewise.
6105         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6106         (dwarf2_get_dwz_file): Likewise.
6107
6108 2019-06-16  Tom Tromey  <tom@tromey.com>
6109
6110         * coffread.c (process_coff_symbol): Use xstrdup.
6111         * value.c (create_internalvar): Use xstrdup.
6112
6113 2019-06-16  Tom Tromey  <tom@tromey.com>
6114
6115         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6116         * breakpoint.c (stopin_command, stopat_command)
6117         (until_break_command, decode_location_default): Remove unnecessary
6118         cast.
6119         * utils.c (subset_compare): Remove unnecessary cast.
6120         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6121         cast.
6122         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6123         cast.
6124         * infcmd.c (path_command): Remove unnecessary cast.
6125         * coffread.c (decode_type): Remove unnecessary cast.
6126         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6127         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6128         * tui/tui-stack.c (tui_show_locator_content)
6129         (tui_show_frame_info): Remove unnecessary cast.
6130         * tui/tui-win.c (tui_scroll_forward_command)
6131         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6132         (parse_scrolling_args): Remove unnecessary cast.
6133         * tui/tui-data.c (init_win_info, tui_del_window)
6134         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6135         (free_content_elements): Remove unnecessary cast.
6136         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6137         unnecessary cast.
6138         * tui/tui-source.c (tui_set_source_content)
6139         (tui_vertical_source_scroll): Remove unnecessary cast.
6140         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6141         cast.
6142         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6143         * tui/tui-regs.c (tui_display_registers_from)
6144         (tui_display_register): Remove unnecessary cast.
6145         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6146         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6147         (make_visible): Remove unnecessary cast.
6148         * tui/tui-winsource.c (tui_erase_source_content)
6149         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6150         unnecessary cast.
6151         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6152         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6153         * stabsread.c (read_type, read_array_type, read_range_type):
6154         Remove unnecessary cast.
6155         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6156         (parse_symbol, parse_type, upgrade_type, parse_external)
6157         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6158         unnecessary cast.
6159         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6160
6161 2019-06-16  Tom Tromey  <tom@tromey.com>
6162
6163         * tui/tui-data.c (tui_alloc_generic_win_info)
6164         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6165         checks.
6166
6167 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6168             Andrew Burgess  <andrew.burgess@embecosm.com>
6169
6170         * f-typeprint.c (f_print_type): Don't return early for not
6171         associated or not allocated types.
6172         (f_type_print_varspec_suffix): Add print_rank parameter and print
6173         ranks of array types in case they dangling.
6174         (f_type_print_base): Add print_rank parameter.
6175
6176 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6177
6178         * NEWS: Mention new MI commands.
6179         * break-catch-throw.c (enum exception_event_kind): Move to
6180         breakpoint.h.
6181         (print_mention_exception_catchpoint): Output text as a single
6182         message.
6183         (catch_exception_command_1): Rename to...
6184         (catch_exception_event): ...this, make non-static, update header
6185         command, and change some parameter types.
6186         (catch_catch_command): Update for changes to
6187         catch_exception_command_1.
6188         (catch_throw_command): Likewise.
6189         (catch_rethrow_command): Likewise.
6190         * breakpoint.c (enum exception_event_kind): Delete.
6191         * breakpoint.h (enum exception_event_kind): Moved here from
6192         break-catch-throw.c.
6193         (catch_exception_event): Declare.
6194         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6195         (mi_cmd_catch_throw): New function.
6196         (mi_cmd_catch_rethrow): New function.
6197         (mi_cmd_catch_catch): New function.
6198         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6199         'catch-catch' entries.
6200         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6201         (mi_cmd_catch_rethrow): Declare.
6202         (mi_cmd_catch_catch): Declare.
6203
6204 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6205
6206         * annotate.c (annotate_source_line): Change return type to void,
6207         update implementation to match.
6208         * annotate.h (annotate_source_line): Change return type to void,
6209         update header comment.
6210         * stack.c (print_frame_info): Don't change what frame information
6211         is printed based on whether annotations are on or not.
6212
6213 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6214
6215         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6216         (annotate_source): Make static.
6217         (annotate_source_line): Moved from source.c and renamed from
6218         identify_source_line.  Update the return type.
6219         * annotate.h (annotate_source): Delete declaration.
6220         (annotate_source_line): Declaration moved from source.h, and
6221         renamed from identify_source_line.  Return type updated.
6222         * source.c (identify_source_line): Moved to annotate.c and renamed
6223         to annotate_source_line.
6224         (info_line_command): Remove check of annotation_level.
6225         * source.h (identify_source_line): Move declaration to annotate.h
6226         and rename to annotate_source_line.
6227         * stack.c: Add 'annotate.h' include.
6228         (print_frame_info): Remove check of annotation_level before
6229         calling annotate_source_line.
6230
6231 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6232
6233         * source-cache.c (source_cache::get_plain_source_lines): Use
6234         open_source_file_with_line_charpos instead of just
6235         open_source_file, remove call to find_source_lines.
6236         (source_cache::get_source_lines): Likewise.
6237         * source.c (find_source_lines): Make static.
6238         (get_filename_and_charpos): Renamed into...
6239         (open_source_file_with_line_charpos): ..this along with changes to
6240         return a scoped_fd, and some other minor clean ups.
6241         (identify_source_line): Use open_source_file_with_line_charpos.
6242         (search_command_helper): Use open_source_file_with_line_charpos
6243         instead of just open_source_file, remove call to
6244         find_source_lines.
6245         * source.h (open_source_file_with_line_charpos): Declare new
6246         function.
6247         (find_source_lines): Delete declaration.
6248
6249 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6250
6251         * source.c (get_filename_and_charpos): Remove fullname
6252         parameter.
6253         (identify_source_line): Update call to get_filename_and_charpos.
6254
6255 2019-06-14  Tom Tromey  <tromey@adacore.com>
6256
6257         PR gdb/24502:
6258         * ui-style.h (skip_ansi_escape): Update comment.
6259         * ui-file.h (class no_terminal_escape_file): New class.
6260         * ui-file.c (no_terminal_escape_file::write)
6261         (no_terminal_escape_file::puts): New methods.
6262         * cli/cli-logging.c (handle_redirections): Use
6263         no_terminal_escape_file.
6264
6265 2019-06-14  Tom Tromey  <tromey@adacore.com>
6266
6267         * NEWS: Move convenience variable news above Python news.
6268
6269 2019-06-14  Tom Tromey  <tom@tromey.com>
6270
6271         * gnulib: Move directory to top-level.
6272         * configure.ac: Don't configure gnulib.
6273         * configure: Rebuild.
6274         * common/common-defs.h: Use new path to gnulib.
6275         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6276         (GNULIB_H): Remove.
6277         (INCGNU): Look in new gnulib location.
6278         (HFILES_NO_SRCDIR): Remove gnulib files.
6279         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6280         (generated_files): Remove GNULIB_H.
6281         ($(LIBGNU), all-lib): Remove targets.
6282         (distclean): Don't mention GNULIB_BUILDDIR.
6283         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6284
6285 2019-06-14  Tom Tromey  <tromey@adacore.com>
6286
6287         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6288         Warn if symbol file does not provide any symbols.
6289
6290 2019-06-14  Tom Tromey  <tromey@adacore.com>
6291
6292         * source.c (find_and_open_source): Respect basenames_may_differ.
6293
6294 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6295
6296         * annotate.c (annotate_breakpoints_invalid): Make use of
6297         scoped_restore_terminal_state.
6298         (annotate_frames_invalid): Likewise.
6299
6300 2019-06-14  Tom Tromey  <tromey@adacore.com>
6301
6302         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6303         allow assignment to an internalvar.
6304
6305 2019-06-14  Tom Tromey  <tromey@adacore.com>
6306
6307         * ada-lex.l: Allow "_" in attribute names.
6308
6309 2019-06-14  Tom Tromey  <tromey@adacore.com>
6310
6311         PR gdb/24653:
6312         * regcache.c (registers_changed): Don't call alloca.
6313         * top.c (execute_command): Don't call alloca.
6314
6315 2019-06-13  Pedro Alves  <palves@redhat.com>
6316
6317         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6318         'expression'.  When parsing an expression, error out if there's
6319         junk after "unlimited".
6320         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6321         (do_set_command): Adjust calls to is_unlimited_literal.
6322
6323 2019-06-13  Pedro Alves  <palves@redhat.com>
6324
6325         * compile/compile.c (make_compile_options_def_group): Add braces
6326         around array_view initializer.
6327         * thread.c (make_thread_apply_all_options_def_group)
6328         (make_thread_apply_all_options_def_group): Likewise.
6329
6330 2019-06-13  Pedro Alves  <palves@redhat.com>
6331
6332         * NEWS (New commands): Mention "maint test-options
6333         require-delimiter", "maint test-options unknown-is-error", "maint
6334         test-options unknown-is-operand" and "maint show
6335         test-options-completion-result".
6336         (New command options, command completion): New section.
6337         (Completion improvements): New section.
6338         Mention that you can abbreviate "unlimited".
6339
6340 2019-06-13  Pedro Alves  <palves@redhat.com>
6341
6342         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6343         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6344         * unittests/cli-utils-selftests.c (test_parse_flags)
6345         (test_parse_flags_qcs): Delete.
6346         (test_cli_utils): Don't call deleted functions.
6347
6348 2019-06-13  Pedro Alves  <palves@redhat.com>
6349
6350         * thread.c: Include "cli/cli-option.h".
6351         (tp_array_compar_ascending): Global.
6352         (tp_array_compar): Delete function.
6353         (tp_array_compar_ascending, tp_array_compar_descending): New
6354         functions.
6355         (ascending_option_def, qcs_flag_option_def)
6356         (thr_qcs_flags_option_defs)
6357         (make_thread_apply_all_options_def_group)
6358         (make_thread_apply_options_def_group): New.
6359         (thread_apply_all_command): Use gdb::option::process_options.
6360         (thread_apply_command_completer)
6361         (thread_apply_all_command_completer): New.
6362         (thread_apply_command): Use gdb::option::process_options.
6363         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6364         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6365         to generate help text of "thread apply".  Adjust "taas"'s help.
6366         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6367         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6368
6369 2019-06-13  Pedro Alves  <palves@redhat.com>
6370
6371         * thread.c (thread_apply_command): Check for invalid TID with
6372         isdigit instead of !isalpha.
6373
6374 2019-06-13  Pedro Alves  <palves@redhat.com>
6375
6376         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6377         (validate_flags_qcs): New.
6378         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6379         (validate_flags_qcs): Declare.
6380         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6381         (make_frame_apply_options_def_group): New.
6382         (frame_apply_command_count): Process options with
6383         gdb::option::process_options.
6384         (frame_apply_completer): New.
6385         (frame_apply_level_completer, frame_apply_all_completer)
6386         (frame_apply_completer): New.
6387         (_initialize_stack): Update help of "frame apply", "frame apply
6388         level", "frame apply all" and "faas" to mention supported options
6389         and install command completers.
6390         * stack.h (frame_apply_all_completer): Declare.
6391         * thread.c: Include "stack.h".
6392         (tfaas_command): Add "--".
6393         (_initialize_thread): Update help "tfaas" to mention supported
6394         options and install command completer.
6395
6396 2019-06-13  Pedro Alves  <palves@redhat.com>
6397
6398         * completer.c (complete_nested_command_line): New.
6399         (gdb_completion_word_break_characters_throw): Add assertion.
6400         * completer.h (complete_nested_command_line): Declare.
6401
6402 2019-06-13  Pedro Alves  <palves@redhat.com>
6403
6404         * stack.c (parse_backtrace_qualifiers): New.
6405         (backtrace_command): Use it.
6406         (backtrace_command_completer): Complete on qualifiers.
6407
6408 2019-06-13  Pedro Alves  <palves@redhat.com>
6409
6410         * frame.c: Include "cli/cli-option.h.
6411         (user_set_backtrace_options): New.
6412         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6413         Delete.
6414         (get_prev_frame): Adjust.
6415         (boolean_option_def, uinteger_option_def)
6416         (set_backtrace_option_defs): New.
6417         (_initialize_frame): Adjust and use
6418         gdb::option::add_setshow_cmds_for_options to install "set
6419         backtrace past-main" and "set backtrace past-entry".
6420         * frame.h: Include "cli/cli-option.h".
6421         (struct frame_print_options): Forward declare.
6422         (print_frame_arguments_all, print_frame_arguments_scalars)
6423         (print_frame_arguments_none): Declare.
6424         (print_entry_values): Delete declaration.
6425         (struct frame_print_options, user_frame_print_options): New.
6426         (struct set_backtrace_options): New.
6427         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6428         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6429         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6430         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6431         (list_args_or_locals): Add frame_print_options parameter.
6432         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6433         * python/py-framefilter.c (enumerate_args): Pass down
6434         USER_FRAME_PRINT_OPTIONS.
6435         * stack.c: Include "cli/cli-option.h".
6436         (print_frame_arguments_all, print_frame_arguments_scalars)
6437         (print_frame_arguments_none): Declare.
6438         (print_raw_frame_arguments, print_entry_values): Delete.
6439         (user_frame_print_options): New.
6440         (boolean_option_def, enum_option_def, frame_print_option_defs):
6441         New.
6442         (struct backtrace_cmd_options): New.
6443         (bt_flag_option_def): New.
6444         (backtrace_command_option_defs): New.
6445         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6446         (print_frame_arg, read_frame_arg, print_frame_args)
6447         (print_frame_info, print_frame): Add frame_print_options parameter
6448         and use it.
6449         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6450         (backtrace_command_1): Add frame_print_options and
6451         backtrace_cmd_options parameters and use them.
6452         (make_backtrace_options_def_group): New.
6453         (backtrace_command): Process command options with
6454         gdb::option::process_options.
6455         (backtrace_command_completer): New.
6456         (_initialize_stack): Extend "backtrace"'s help to mention
6457         supported options.  Install completer for "backtrace".
6458         Install some settings commands with add_setshow_cmds_for_options.
6459
6460 2019-06-13  Pedro Alves  <palves@redhat.com>
6461
6462         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6463         and that "set/show print raw frame-arguments" are now deprecated.
6464
6465         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6466         command.
6467         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6468         * stack.c (_initialize_stack): Install "set/show print
6469         raw-frame-arguments", and deprecate "set/show print raw
6470         frame-arguments".
6471         * valprint.c (_initialize_valprint): Deprecate "set/show print
6472         raw".
6473
6474 2019-06-13  Pedro Alves  <palves@redhat.com>
6475
6476         * compile/compile.c (struct compile_options): New.
6477         (compile_flag_option_def, compile_command_option_defs)
6478         (make_compile_options_def_group): New.
6479         (compile_file_command): Handle options with
6480         gdb::option::process_options.
6481         (compile_file_command_completer): New function.
6482         (compile_code_command): Handle options with
6483         gdb::option::process_options.
6484         (compile_code_command_completer): New function.
6485         (_initialize_compiler): Install completers for "compile code" and
6486         "compile file".  Mention available options in "compile code" and
6487         "compile code"'s help.
6488         * completer.c (advance_to_completion_word): New, factored out from
6489         ...
6490         (advance_to_expression_complete_word_point): ... this.
6491         (advance_to_filename_complete_word_point): New.
6492         * completer.h (advance_to_filename_complete_word_point): New
6493         declaration.
6494
6495 2019-06-13  Pedro Alves  <palves@redhat.com>
6496
6497         * compile/compile.c: Include "cli/cli-option.h".
6498         (compile_print_value): Scope data pointer is now a
6499         value_print_options pointer; adjust.
6500         (compile_print_command): Process options.  Scope data pointer is
6501         now a value_print_options pointer; adjust.
6502         (_initialize_compile): Update "compile print"'s help to include
6503         supported options.  Install a completer for "compile print".
6504         * cp-valprint.c (show_vtblprint, show_objectprint)
6505         (show_static_field_print): Delete.
6506         (_initialize_cp_valprint): Don't install "set print
6507         static-members", "set print vtbl", "set print object" here.
6508         * printcmd.c: Include "cli/cli-option.h" and
6509         "common/gdb_optional.h".
6510         (print_command_parse_format): Rework to fill in a
6511         value_print_options instead of a format_data.
6512         (print_value): Change parameter type from format_data pointer to
6513         value_print_options reference.  Adjust.
6514         (print_command_1): Process options.  Adjust to pass down a
6515         value_print_options.
6516         (print_command_completer): New.
6517         (_initialize_printcmd): Install print_command_completer as
6518         handle_brkchars completer for the "print" command.  Update
6519         "print"'s help to include supported options.
6520         * valprint.c: Include "cli/cli-option.h".
6521         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6522         here from cp-valprint.c.
6523         (boolean_option_def, uinteger_option_def)
6524         (value_print_option_defs, make_value_print_options_def_group):
6525         New.  Use gdb::option::add_setshow_cmds_for_options to install
6526         "set print elements", "set print null-stop", "set print repeats",
6527         "set print pretty", "set print union", "set print array", "set
6528         print address", "set print symbol", "set print array-indexes".
6529         * valprint.h: Include <string> and "cli/cli-option.h".
6530         (make_value_print_options_def_group): Declare.
6531         (print_value): Change parameter type from format_data pointer to
6532         value_print_options reference.
6533         (print_command_completer): Declare.
6534
6535 2019-06-13  Pedro Alves  <palves@redhat.com>
6536
6537         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6538         (COMMON_SFILES): Add maint-test-settings.c.
6539         * cli/cli-decode.c (boolean_enums): New global, factored out from
6540         ...
6541         (add_setshow_boolean_cmd): ... here.
6542         * cli/cli-decode.h (boolean_enums): Declare.
6543         * cli/cli-option.c: New file.
6544         * cli/cli-option.h: New file.
6545         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6546         factored out from ...
6547         (parse_cli_boolean_value(const char *)): ... this.
6548         (is_unlimited_literal): Change parameter type to pointer to
6549         pointer.  Adjust and advance ARG pointer.
6550         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6551         (parse_cli_var_enum): New, factored out from ...
6552         (do_set_command): ... this.  Adjust.
6553         * cli/cli-setshow.h (parse_cli_boolean_value)
6554         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6555         (parse_cli_var_enum): Declare.
6556         * cli/cli-utils.c: Include "cli/cli-option.h".
6557         (get_ulongest): New.
6558         * cli/cli-utils.h (get_ulongest): Declare.
6559         (check_for_argument): New overloads.
6560         * maint-test-options.c: New file.
6561
6562 2019-06-13  Pedro Alves  <palves@redhat.com>
6563
6564         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6565         parse a range if "-" is at the end of the string.
6566
6567 2019-06-13  Pedro Alves  <palves@redhat.com>
6568
6569         * cli/cli-setshow.c (parse_auto_binary_operation)
6570         (parse_cli_boolean_value): Don't allow "o".
6571
6572 2019-06-13  Pedro Alves  <palves@redhat.com>
6573
6574         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6575         * NEWS: Mention maint test-settings KIND.
6576         * maint-test-settings.c: New file.
6577
6578 2019-06-13  Pedro Alves  <palves@redhat.com>
6579
6580         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6581         completer.
6582         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6583         "set" completers.
6584
6585 2019-06-13  Pedro Alves  <palves@redhat.com>
6586
6587         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6588         after item.
6589
6590 2019-06-13  Pedro Alves  <palves@redhat.com>
6591
6592         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6593
6594 2019-06-13  Pedro Alves <palves@redhat.com>
6595
6596         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6597         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6598         call.
6599         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6600         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6601         calls.
6602         (check_for_argument): Skip spaces after argument.
6603
6604 2019-06-13  Pedro Alves  <palves@redhat.com>
6605
6606         * thread.c (thread_apply_command): Adjust TID parsing.
6607         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6608         detected before end of string.
6609         (tid_is_in_list): Error out if LIST is invalid.
6610
6611 2019-06-13  Pedro Alves  <palves@redhat.com>
6612
6613         * completer.c (complete_line_internal_1): Rewind completion word
6614         point.
6615         (completion_tracker::advance_custom_word_point_by): Change
6616         parameter type to int.
6617         * completer.h (completion_tracker::advance_custom_word_point_by):
6618         Likewise.
6619
6620 2019-06-13  Pedro Alves  <palves@redhat.com>
6621
6622         * completer.c (advance_to_completion_word): Handle delimiters.
6623
6624 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6625
6626         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6627
6628 2019-06-11  Tom Tromey  <tom@tromey.com>
6629
6630         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6631         (xmalloc_failed): Move to alloc.c.
6632         * alloc.c: New file.
6633         * Makefile.in (COMMON_SFILES): Add alloc.c.
6634
6635 2019-06-11  Tom Tromey  <tom@tromey.com>
6636
6637         * nat/linux-waitpid.c: Don't include server.h.
6638         (linux_debug): Remove.
6639         (my_waitpid): Update.
6640
6641 2019-06-11  Tom Tromey  <tromey@adacore.com>
6642
6643         * infcall.c (_initialize_infcall): Remove trailing newline from
6644         help.
6645         * user-regs.c (_initialize_user_regs): Remove trailing newline
6646         from help.
6647         * typeprint.c (_initialize_typeprint): Remove trailing newline
6648         from help.
6649         * reverse.c (_initialize_reverse): Remove trailing newlines from
6650         help.
6651         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6652         from help.
6653         * language.c (add_set_language_command): Remove trailing newline
6654         from help.
6655         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6656         help.
6657         * disasm.c (_initialize_disasm): Remove trailing newline from
6658         help.
6659         * top.c (init_main): Remove trailing newline from help.
6660         * interps.c (_initialize_interpreter): Remove trailing newline
6661         from help.
6662         * btrace.c (_initialize_btrace): Remove trailing newlines from
6663         help.
6664         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6665         from help.
6666         * python/python.c (_initialize_python): Remove trailing newline
6667         from help.
6668         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6669         help.
6670         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6671         from help.  Reformat some text.
6672         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6673         from help.
6674         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6675         newline from help.
6676
6677 2019-06-11  Tom Tromey  <tromey@adacore.com>
6678
6679         * darwin-nat.c (darwin_decode_exception_message)
6680         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6681
6682 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6683
6684         * valops.c (value_slice): Check for not allocated or not
6685         associated values.
6686
6687 2019-06-10  Tom de Vries  <tdevries@suse.de>
6688
6689         PR gdb/24618
6690         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6691         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6692         invalid.
6693
6694 2019-06-10  Tom de Vries  <tdevries@suse.de>
6695
6696         PR gdb/24611
6697         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6698         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6699
6700 2019-06-10  Tom de Vries  <tdevries@suse.de>
6701
6702         PR symtab/24545
6703         * symtab.c (struct demangled_name_entry): Add language field.
6704         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6705         static minimal symbol".  Set and use language field.
6706
6707 2019-06-10  Tom Tromey  <tromey@adacore.com>
6708
6709         * ada-lang.c (_initialize_ada_language): Update help text.
6710
6711 2019-06-10  Tom Tromey  <tromey@adacore.com>
6712
6713         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6714         with a newline.
6715         * guile/guile.c (handle_boot_error): Don't end warning with a
6716         newline.
6717         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6718         warning with a newline.
6719         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6720         newline.
6721         (s12z_frame_cache): Likewise.
6722         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6723         a newline.
6724         * solib-svr4.c (disable_probes_interface): Don't end warning with
6725         a newline.
6726         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6727         newline.
6728         * python/python.c (do_finish_initialization): Don't end warning
6729         with a newline.
6730
6731 2019-06-10  Tom Tromey  <tom@tromey.com>
6732
6733         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6734         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6735         gdbpy_enter.
6736
6737 2019-06-10  Tom Tromey  <tromey@adacore.com>
6738
6739         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6740         data.
6741         (elf_new_init): Don't call stabsread_new_init.
6742         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6743         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6744         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6745
6746 2019-06-10  Tom de Vries  <tdevries@suse.de>
6747
6748         PR symtab/16264
6749         PR symtab/24517
6750         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6751
6752 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6753
6754         * source.c (find_and_open_source): Also rewrite relative file
6755         names.
6756
6757 2019-04-26  Amos Bird  <amosbird@gmail.com>
6758
6759         * annotate.c (annotate_thread_exited): Add "thread-exited"
6760         annotation.
6761
6762 2019-06-06  Tom Tromey  <tromey@adacore.com>
6763
6764         * maint.h (class scoped_command_stats): Use
6765         DISABLE_COPY_AND_ASSIGN.
6766         <print_time>: New method.
6767         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6768         print_time.
6769         (scoped_command_stats::print_time): New method.
6770
6771 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6772
6773         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6774         instructions of lengths 6 or 8 bytes.
6775
6776 2019-06-04  Pedro Alves  <palves@redhat.com>
6777
6778         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6779
6780         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6781         * breakpoint.c (condition_completer): Likewise.
6782         * cli/cli-dump.c (scan_expression): Likewise.
6783         * common/filestuff.c (mkdir_recursive): Likewise.
6784         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6785         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6786         (gdb_abspath): Likewise.
6787         * compile/compile-cplus-types.c
6788         (compile_cplus_instance::decl_name): Likewise.
6789         * completer.c (complete_explicit_location):
6790         (signal_completer, reg_or_group_completer_1): Likewise.
6791         * cp-support.c (cp_remove_params_if_any): Likewise.
6792         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6793         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6794         * infcmd.c (strip_bg_char): Likewise.
6795         * linespec.c (copy_token_string): Likewise.
6796         * mi/mi-main.c (output_cores): Likewise.
6797         * psymtab.c (psymtab_search_name):
6798         * symfile.c (test_set_ext_lang_command): Likewise.
6799         * target.c (target_fileio_read_stralloc): Likewise.
6800         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6801         * value.c (complete_internalvar): Likewise.
6802
6803 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6804
6805         Add objfile property to gdb.Type.
6806         * NEWS: Mention Python API addition.
6807         * python/py-type.c (typy_get_objfile): New method.
6808
6809 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6810
6811         * NEWS: Mention the new set|show style [title|highlight].
6812         Mention changes to "show style", "help" and "apropos".
6813
6814 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6815
6816         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6817         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6818         instead of print_help_for_command.
6819         (print_doc_of_command): New function.
6820         (help_list): Add 'apropos -v word' suggestion.
6821         (print_help_for_command): Style the command name using title style.
6822         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6823         (_initialize_cli_cmds): Describe -v in apropos_command help.
6824
6825 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6826
6827         * cli/cli-style.h (cli_style_option): Add name in constructor,
6828         add m_name class member, add constructor with intensity,
6829         add name class function.
6830         (cli_style_option::add_setshow_commands): Remove name argument.
6831         (highlight_style, title_style): New styles.
6832         * cli/cli-style.c (do_show): New function that shows a style
6833         characteristic styling the style name with itself.
6834         (set_style_name): New function.
6835         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6836         Update all callers according to the changes in cli/cli-style.h.
6837         * utils.h (fputs_highlighted): New function.
6838         * utils.c (fputs_highlighted): Likewise.
6839
6840 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6841
6842         * NEWS: Mention new pipe command and new convenience variables.
6843
6844 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6845
6846         * cli/cli-cmds.c (pipe_command): New function.
6847         (_initialize_cli_cmds): Call add_com for pipe_command.
6848         Define | as an alias for pipe.
6849         (exit_status_set_internal_vars): New function.
6850         (shell_escape): Call exit_status_set_internal_vars.
6851         cli/cli-decode.c (find_command_name_length): Recognize | as
6852         a single character command.
6853
6854 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6855
6856         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6857         top.c (execute_command_to_ui_file): New function, mostly a copy
6858         of execute_command_to_string.
6859         (execute_command_to_string): Implement by calling
6860         execute_command_to_ui_file.
6861
6862 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6863
6864         * top.h (saved_command_line): Remove declaration.
6865         * top.c (previous_saved_command_line, previous_repeat_arguments):
6866         New variables.
6867         (saved_command_line): Make static, define together with other
6868         'repeat variables'.
6869         (dont_repeat): Clear repeat_arguments.
6870         (repeat_previous, get_saved_command_line, save_command_line):
6871         New functions.
6872         (gdb_init): Initialize saved_command_line
6873         and previous_saved_command_line.
6874         * main.c (captured_main_1): Remove saved_command_line initialization.
6875         * event-top.c (handle_line_of_input): Update to use
6876         the new 'repeat' related functions instead of direct access to
6877         saved_command_line.
6878         * command.h (repeat_previous, get_saved_command_line,
6879         save_command_line): New declarations.
6880         (dont_repeat): Add comment.
6881
6882 2019-05-30  Tom Tromey  <tromey@adacore.com>
6883
6884         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6885         Fix comment.
6886         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6887
6888 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6889
6890         PR cli/24587
6891         * completer.c (complete): Initialize variable word.
6892
6893 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6894
6895         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6896         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6897         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6898         'body' is NULL to the outter 'if', protecting the '!is_define'
6899         situation as well.
6900
6901 2019-05-29  Tom Tromey  <tromey@adacore.com>
6902
6903         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6904         (dwarf_unknown): New function.
6905         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6906         (dwarf_type_encoding_name): Use dwarf_unknown.
6907
6908 2019-05-29  Tom Tromey  <tromey@adacore.com>
6909
6910         PR c++/20020:
6911         * cp-valprint.c (cp_print_value_fields): Call
6912         cp_print_static_field inside "try".
6913
6914 2019-05-29  Tom Tromey  <tromey@adacore.com>
6915
6916         * inflow.c (struct terminal_info): Add default operator=.
6917         * configure: Rebuild.
6918         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6919         -Wdeprecated-copy-dtor, -Wredundant-move.
6920
6921 2019-05-29  Tom Tromey  <tromey@adacore.com>
6922
6923         * NEWS: Add entry.
6924         * infcmd.c (print_return_value_1): Handle finish_print
6925         option.
6926         (show_print_finish): New function.
6927         (_initialize_infcmd): Add "set/show print finish" commands.
6928         * valprint.c (user_print_options): Initialize new member.
6929         * valprint.h (struct value_print_options) <finish_print>: New
6930         member.
6931
6932 2019-05-28  Tom Tromey  <tromey@adacore.com>
6933
6934         * ada-lang.c (ada_remove_Xbn_suffix)
6935         (find_old_style_renaming_symbol)
6936         (parse_old_style_renaming): Remove.
6937         (ada_find_renaming_symbol): Don't call
6938         find_old_style_renaming_symbol.
6939         (ada_is_renaming_symbol): Rename from
6940         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6941         bool.  Now static.
6942         (ada_read_var_value): Update and simplify.
6943         * ada-exp.y (write_var_or_type): Remove old code.
6944
6945 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6946
6947         PR gdb/25010
6948         * event-top.c: Remove include comment.
6949         * inflow.c (class scoped_ignore_sigttou): Move from here...
6950         * inflow.h (class scoped_ignore_sigttou): ...to here.
6951         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6952         * top.c:  Remove include comment.
6953
6954 2019-05-27  Tom Tromey  <tom@tromey.com>
6955
6956         * NEWS: Fix typo.
6957
6958 2019-05-22  Tom Tromey  <tromey@adacore.com>
6959
6960         * target.c (target_follow_exec): Constify parameter.
6961         * target-delegates.c: Rebuild.
6962         * remote.c (remote_target::follow_exec): Constify parameter.
6963         * infrun.c (follow_exec): Constify parameter.
6964         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6965         (target_follow_exec): Likewise.
6966
6967 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6968
6969         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6970         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6971
6972 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6973
6974         * NEWS: Add debugredirect and testsuite sections.
6975
6976 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6977
6978         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6979         target descriptions using exclusively floating point register name
6980         aliases.
6981
6982 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6983
6984         PR gdb/18644:
6985         * f-lang.c (build_fortran_types): Handle the case where
6986         gdbarch_floatformat_for_type returns a nullptr.
6987
6988 2019-05-21  Tom de Vries  <tdevries@suse.de>
6989
6990         PR cli/24587
6991         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6992
6993 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6994
6995         PR gdb/18644:
6996         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6997         16-byte floats.
6998         * i386-tdep.c (i386_floatformat_for_type): Use
6999         floatformats_ia64_quad for the 16-byte floating point component
7000         within a fortran 32-byte complex number.
7001
7002 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7003
7004         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7005         delete default constructor.
7006         (find_partial_die): Update to return const struct.
7007         (partial_die_parent_scope): Move variable declaration into scope
7008         of its use and change its type to auto.
7009         (guess_partial_die_structure_name): Likewise.
7010         (partial_die_info::fixup): Likewise.
7011
7012 2019-05-17  Tom Tromey  <tromey@adacore.com>
7013
7014         * source.c (find_and_open_source): Remove cast.
7015
7016 2019-05-17  Tom Tromey  <tromey@adacore.com>
7017
7018         * annotate.c (annotate_source): Make "filename" const.
7019         * annotate.h (annotate_source): Use const.
7020
7021 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7022
7023         * disasm.c (set_disassembler_options): Send errors to stderr.
7024
7025 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7026
7027         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7028         (cli_interp_base::set_logging): Check debug_redirect.
7029         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7030         * cli/cli-logging.c (debug_redirect): Add static variable.
7031         (pop_output_files): Add default param.
7032         (handle_redirections): Print debug setting.
7033         (show_logging_command): Likewise.
7034         (_initialize_cli_logging): Add debugredirect command.
7035         * interps.c (current_interp_set_logging): Add debug_redirect
7036         parameter.
7037         * interps.h (set_logging): Add debug_redirect parameter.
7038         (current_interp_set_logging): Likewise.
7039         * mi/mi-common.h: Likewise.
7040         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7041
7042 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7043             Tom Tromey  <tromey@adacore.com>
7044
7045         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7046         directly.
7047         * cli/cli-interp.h (make_logging_output): Remove declaration.
7048         * cli/cli-logging.c (make_logging_output): Remove function.
7049         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7050         directly.
7051         * ui-file.c (tee_file::tee_file): Remove bools.
7052         (tee_file::~tee_file): Remove deletes.
7053         * ui-file.h (tee_file): Remove bools.
7054
7055 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7056
7057         * mi/mi-cmds.h (mi_cmd_complete): New function.
7058         * mi/mi-main.c (mi_cmd_complete): Likewise.
7059         * mi/mi-cmds.c: Define new MI command -complete.
7060         * NEWS: Mention new -complete command.
7061
7062 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7063
7064         * completer.h (complete): New function.
7065         * completer.c (complete): Likewise.
7066         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7067         function defined in completer.h.
7068
7069 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7070
7071         * MAINTAINERS (Write After Approval): Add myself.
7072
7073 2019-05-17  Tom de Vries  <tdevries@suse.de>
7074
7075         PR gdb/24094
7076         * dwarf2read.c (struct cu_partial_die_info): New struct.
7077         (find_partial_die): Return cu_partial_die_info.
7078         (partial_die_parent_scope, guess_partial_die_structure_name)
7079         (partial_die_info::fixup): Handle new return type of find_partial_die.
7080
7081 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7082
7083         PR breakpoints/24541
7084         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7085         "std::string", simplifying the algorithm.
7086
7087 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7088
7089         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7090         (stap_static_probe_ops::get_probes): Likewise.
7091
7092 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7093
7094         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7095         '-')" and "else if".
7096         (stap_parse_single_operand): Join checks for
7097         "gdbarch_stap_parse_special_token_p" and
7098         "gdbarch_stap_parse_special_token" in the same "if" statement.
7099         Invert check when verifying for operation on register
7100         displacement.
7101
7102 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7103
7104         * stap-probe.c (stap_get_opcode): Update comment.
7105         (stap_get_expected_argument_type): Likewise.
7106         (handle_stap_probe): Likewise.
7107
7108 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7109
7110         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7111         return type to 'bool'.  Adjust comment.  Use 'bool' when
7112         appropriate.
7113         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7114         * stap-probe.c (stap_parse_argument_1): Likewise.
7115         (stap_is_operator): Likewise.
7116         (stap_is_generic_prefix): Likewise.
7117         (stap_is_register_prefix): Likewise.
7118         (stap_is_register_indirection_prefix): Likewise.
7119         (stap_is_integer_prefix): Likewise.
7120         (stap_generic_check_suffix): Likewise.
7121         (stap_check_integer_suffix): Likewise.
7122         (stap_check_register_suffix): Likewise.
7123         (stap_check_register_indirection_suffix): Likewise.
7124         (stap_parse_register_operand): Likewise.
7125         (stap_parse_single_operand): Likewise.
7126         (stap_parse_argument_1): Likewise.
7127         (stap_probe::get_argument_count): Likewise.
7128         (stap_is_operator): Likewise.
7129
7130 2019-05-16  Tom Tromey  <tromey@adacore.com>
7131
7132         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7133         keyword to foreach.
7134
7135 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7136
7137         * linux-thread-db.c (try_thread_db_load_1): Change return type
7138         to bool.
7139         (try_thread_db_load): Likewise.
7140         (try_thread_db_load_from_pdir_1): Likewise.
7141         (try_thread_db_load_from_pdir): Likewise.
7142         (try_thread_db_load_from_sdir): Likewise.
7143         (try_thread_db_load_from_dir): Likewise.
7144         (thread_db_load_search): Likewise.
7145         (has_libpthread): Likewise.
7146         (thread_db_load): Likewise.
7147
7148 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7149
7150         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7151         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7152         NULL, and complain/return if that's the case.
7153
7154 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7155
7156         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7157         (advance, posn, abstract_read_memory): New functions.
7158         [struct mem_read_abstraction]: New struct.
7159         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7160
7161 2019-05-14  Tom Tromey  <tromey@adacore.com>
7162
7163         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7164         value is not lval_memory.
7165
7166 2019-05-14  Tom Tromey  <tromey@adacore.com>
7167
7168         * solib.c (info_sharedlibrary_command): Style the file name.
7169
7170 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7171
7172         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7173         (aarch64_vnv_type): Likewise.
7174         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7175         * common/tdesc.c: Likewise.
7176         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7177         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7178         * features/aarch64-fpu.xml: Add ieee half view.
7179         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7180         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7181         * gdbtypes.h (struct builtin_type): Likewise.
7182         (struct objfile_type): Likewise.
7183
7184 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7185
7186         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7187         typo.
7188         * location.h (string_to_event_location): Likewise.
7189
7190 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7191
7192         GDB 8.3 released.
7193
7194 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7195
7196         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7197         New variable declaration.
7198         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7199         New variable.
7200         (print_one_breakpoint): Use ui_out::test_flags and new global
7201         variable to compute use_fixed_output.
7202         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7203         Remove.
7204         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7205         (mi_multi_location_breakpoint_output_fixed): Remove.
7206         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7207         new variable.
7208         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7209         fix_multi_location_breakpoint_output flag if version >= 3.
7210         * ui-out.h (enum ui_out_flag)
7211         <fix_multi_location_breakpoint_output>: New enumerator.
7212
7213 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7214
7215         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7216
7217 2019-05-10  Tom Tromey  <tromey@adacore.com>
7218
7219         * ada-lang.c (catch_ada_completer): New function.
7220         (_initialize_ada_language): Use it.
7221
7222 2019-05-10  Tom Tromey  <tromey@adacore.com>
7223
7224         * thread.c (print_thread_info): Make "requested_threads" const.
7225         * gdbthread.h (print_thread_info): Make "requested_threads"
7226         const.
7227         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7228         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7229
7230 2019-05-08  Tom Tromey  <tom@tromey.com>
7231
7232         * gdbtypes.c (objfile_type_data): Change type.
7233         (objfile_type, _initialize_gdbtypes): Update.
7234
7235 2019-05-08  Tom Tromey  <tom@tromey.com>
7236
7237         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7238         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7239         (_initialize_dwarf2_frame): Update.
7240
7241 2019-05-08  Tom Tromey  <tom@tromey.com>
7242
7243         * objc-lang.c (objc_objfile_data): Change type.
7244         (find_methods): Update.
7245         (_initialize_objc_lang): Remove.
7246
7247 2019-05-08  Tom Tromey  <tom@tromey.com>
7248
7249         * stabsread.c (rs6000_builtin_type_data): Change type.
7250         (rs6000_builtin_type, _initialize_stabsread): Update.
7251
7252 2019-05-08  Tom Tromey  <tom@tromey.com>
7253
7254         * mips-tdep.c (mips_pdr_data): Remove.
7255         (_initialize_mips_tdep): Update.
7256
7257 2019-05-08  Tom Tromey  <tom@tromey.com>
7258
7259         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7260         (hppa_init_objfile_priv_data, read_unwind_info)
7261         (find_unwind_entry, _initialize_hppa_tdep): Update.
7262
7263 2019-05-08  Tom Tromey  <tom@tromey.com>
7264
7265         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7266         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7267         on obstack.
7268         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7269
7270 2019-05-08  Tom Tromey  <tom@tromey.com>
7271
7272         * mdebugread.c (basic_type_data): Change type.
7273         (basic_type, _initialize_mdebugread): Update.
7274
7275 2019-05-08  Tom Tromey  <tom@tromey.com>
7276
7277         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7278
7279 2019-05-08  Tom Tromey  <tom@tromey.com>
7280
7281         * nto-tdep.c (nto_inferior_data_reg): Change type.
7282         (nto_inferior_data): Update.
7283         (nto_inferior_data_cleanup, nto_new_inferior_data)
7284         (_initialize_nto_tdep): Remove.
7285         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7286
7287 2019-05-08  Tom Tromey  <tom@tromey.com>
7288
7289         * ada-lang.c (struct ada_inferior_data): Add initializers.
7290         (ada_inferior_data): Change type.
7291         (ada_inferior_data_cleanup): Remove.
7292         (get_ada_inferior_data, ada_inferior_exit)
7293         (struct ada_pspace_data): Add initializers, destructor.
7294         (ada_pspace_data_handle): Change type.
7295         (get_ada_pspace_data): Update.
7296         (ada_pspace_data_cleanup): Remove.
7297
7298 2019-05-08  Tom Tromey  <tom@tromey.com>
7299
7300         * coffread.c (struct coff_symfile_info): Add initializers.
7301         (coff_objfile_data_key): Move lower.  Change type.
7302         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7303         Update.
7304         (coff_free_info): Remove.
7305
7306 2019-05-08  Tom Tromey  <tom@tromey.com>
7307
7308         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7309         (fbsd_pspace_data_handle): Move lower.  Change type.
7310         (get_fbsd_pspace_data): Update.
7311         (fbsd_pspace_data_cleanup): Remove.
7312         (_initialize_fbsd_tdep): Update.
7313
7314 2019-05-08  Tom Tromey  <tom@tromey.com>
7315
7316         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7317         (get_ada_tasks_pspace_data): Update.
7318         (ada_tasks_pspace_data_cleanup): Remove.
7319         (_initialize_tasks): Update.
7320         (ada_tasks_inferior_data_handle): Change type.
7321         (get_ada_tasks_inferior_data): Update.
7322         (ada_tasks_inferior_data_cleanup): Remove.
7323         (struct ada_tasks_pspace_data): Add initializers.
7324
7325 2019-05-08  Tom Tromey  <tom@tromey.com>
7326
7327         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7328         * symfile-debug.c (debug_sym_get_probes): Change type.
7329         * stap-probe.c (handle_stap_probe):
7330         (stap_static_probe_ops::get_probes): Change type.
7331         * probe.h (class static_probe_ops) <get_probes>: Change type.
7332         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7333         (parse_probes_in_pspace): Update.
7334         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7335         Update.
7336         (any_static_probe_ops::get_probes): Change type.
7337         * elfread.c (elfread_data): New typedef.
7338         (probe_key): Change type.
7339         (elf_get_probes): Likewise.  Update.
7340         (probe_key_free): Remove.
7341         (_initialize_elfread): Update.
7342         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7343         Change type.
7344         (dtrace_process_dof_probe, dtrace_process_dof)
7345         (dtrace_static_probe_ops::get_probe): Change type.
7346
7347 2019-05-08  Tom Tromey  <tom@tromey.com>
7348
7349         * xcoffread.c (struct xcoff_symfile_info): Rename from
7350         coff_symfile_info.  Add initializers.
7351         (xcoff_objfile_data_key): Move lower.  Change type.
7352         (XCOFF_DATA): Rewrite.
7353         (xcoff_free_info): Remove.
7354         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7355         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7356         (xcoff_initial_scan): Update.
7357
7358 2019-05-08  Tom Tromey  <tom@tromey.com>
7359
7360         * solib-svr4.c (struct svr4_info): Add initializers and
7361         destructor.
7362         <probes_table>: Now an htab_up.
7363         (solib_svr4_pspace_data): Change type.
7364         (free_probes_table): Simplify.
7365         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7366         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7367         (probes_table_remove_objfile_probes, register_solib_event_probe)
7368         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7369         (_initialize_svr4_solib): Update.
7370
7371 2019-05-08  Tom Tromey  <tom@tromey.com>
7372
7373         * remote.c (remote_pspace_data): Change type.
7374         (remote_pspace_data_cleanup): Remove.
7375         (get_remote_exec_file, set_pspace_remote_exec_file)
7376         (_initialize_remote): Update.
7377
7378 2019-05-08  Tom Tromey  <tom@tromey.com>
7379
7380         * breakpoint.c (breakpoint_objfile_key): Change type.
7381         (get_breakpoint_objfile_data): Update.
7382         (free_breakpoint_objfile_data): Remove.
7383         (_initialize_breakpoint): Update.
7384
7385 2019-05-08  Tom Tromey  <tom@tromey.com>
7386
7387         * linux-tdep.c (struct linux_info): Add initializers.
7388         (linux_inferior_data): Move.  Change type.
7389         (invalidate_linux_cache_inf): Update.
7390         (linux_inferior_data_cleanup): Remove.
7391         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7392
7393 2019-05-08  Tom Tromey  <tom@tromey.com>
7394
7395         * auxv.c (auxv_inferior_data): Move.  Change type.
7396         (auxv_inferior_data_cleanup): Remove.
7397         (invalidate_auxv_cache_inf): Rewrite.
7398         (get_auxv_inferior_data, _initialize_auxv): Update.
7399
7400 2019-05-08  Tom Tromey  <tom@tromey.com>
7401
7402         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7403         (symfile_debug_objfile_data_key): Change type.
7404         (symfile_debug_installed, debug_qf_has_symbols)
7405         (debug_qf_find_last_source_symtab)
7406         (debug_qf_forget_cached_source_info)
7407         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7408         (debug_qf_print_stats, debug_qf_dump)
7409         (debug_qf_expand_symtabs_for_function)
7410         (debug_qf_expand_all_symtabs)
7411         (debug_qf_expand_symtabs_with_fullname)
7412         (debug_qf_map_matching_symbols)
7413         (debug_qf_expand_symtabs_matching)
7414         (debug_qf_find_pc_sect_compunit_symtab)
7415         (debug_qf_map_symbol_filenames)
7416         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7417         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7418         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7419         (debug_sym_read_linetable, debug_sym_relocate): Update.
7420         (symfile_debug_free_objfile): Remove.
7421         (install_symfile_debug_logging, _initialize_symfile_debug):
7422         Update.
7423
7424 2019-05-08  Tom Tromey  <tom@tromey.com>
7425
7426         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7427         allocate_on_obstack.
7428         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7429         (get_dwarf2_per_objfile): Update.
7430         (set_dwarf2_per_objfile): Remove.
7431         (dwarf2_has_info, dwarf2_get_section_info): Update.
7432         (dwarf2_free_objfile): Remove.
7433         (_initialize_dwarf2_read): Update.
7434
7435 2019-05-08  Tom Tromey  <tom@tromey.com>
7436
7437         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7438         initializers.
7439         <unsupported_script_warning_printed,
7440         script_not_found_warning_printed>: Now bool.
7441         (auto_load_pspace_data): Change type.
7442         (~auto_load_pspace_info): Rename from
7443         auto_load_pspace_data_cleanup.
7444         (get_auto_load_pspace_data, init_loaded_scripts_info)
7445         (clear_section_scripts, maybe_print_unsupported_script_warning)
7446         (maybe_print_script_not_found_warning, _initialize_auto_load):
7447         Update.
7448
7449 2019-05-08  Tom Tromey  <tom@tromey.com>
7450
7451         * objfiles.c (objfile_pspace_info): Add destructor and
7452         initializers.
7453         (objfiles_pspace_data): Change type.
7454         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7455         (get_objfile_pspace_data): Update.
7456         (objfiles_bfd_data): Change type.
7457         (get_objfile_bfd_data): Update.
7458         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7459
7460 2019-05-08  Tom Tromey  <tom@tromey.com>
7461
7462         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7463         Change type.
7464         (get_catch_syscall_inferior_data): Update.
7465         (catch_syscall_inferior_data_cleanup): Remove.
7466         (_initialize_break_catch_syscall): Update.
7467
7468 2019-05-08  Tom Tromey  <tom@tromey.com>
7469
7470         * inflow.c (struct terminal_info): Add destructor and
7471         initializers.
7472         (inflow_inferior_data): Change type.
7473         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7474         (get_inflow_inferior_data, inflow_inferior_exit)
7475         (swap_terminal_info, _initialize_inflow): Update.
7476
7477 2019-05-08  Tom Tromey  <tom@tromey.com>
7478
7479         * target-dcache.c (target_dcache_cleanup): Remove.
7480         (target_dcache_aspace_key): Change type.
7481         (target_dcache_init_p, target_dcache_invalidate)
7482         (target_dcache_get, target_dcache_get_or_init)
7483         (_initialize_target_dcache): Update.
7484         * dcache.h (struct dcache_deleter): New.
7485
7486 2019-05-08  Tom Tromey  <tom@tromey.com>
7487
7488         * symtab.c (struct symbol_cache): Add destructor and
7489         initializers.
7490         (symbol_cache_key): Move.  Change type.
7491         (make_symbol_cache, free_symbol_cache): Remove.
7492         (get_symbol_cache): Update.
7493         (symbol_cache_cleanup): Remove.
7494         (ALL_PSPACES, symbol_cache_flush)
7495         (maintenance_print_symbol_cache)
7496         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7497         Update.
7498
7499 2019-05-08  Tom Tromey  <tom@tromey.com>
7500
7501         * symtab.c (struct main_info): Add destructor and initializers.
7502         (main_progspace_key): Move.  Change type.
7503         (get_main_info): Update.
7504         (main_info_cleanup): Remove.
7505         (_initialize_symtab): Update.
7506
7507 2019-05-08  Tom Tromey  <tom@tromey.com>
7508
7509         * registry.h (DECLARE_REGISTRY): Define the _key class.
7510
7511 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7512
7513         * NEWS: Merge two 'New commands' sections.
7514
7515 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7516
7517         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7518         parameter and use Ada language definition instead.
7519         (ada_val_print_ptr): Remove unused language parameter.
7520         (ada_val_print_num): Remove language parameter and use Ada language
7521         definition instead.
7522         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7523         parameter.
7524         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7525         parameter and use Ada language definition instead.
7526         (ada_val_print_1): Update all ada_val_print_xxx calls.
7527         Remove language parameter.
7528         (ada_val_print): Update ada_val_print_1 call.
7529
7530 2019-05-08  Tom Tromey  <tromey@adacore.com>
7531
7532         * remote.c (remote_hw_watchpoint_limit)
7533         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7534         Now static.
7535
7536 2019-05-08  Tom Tromey  <tromey@adacore.com>
7537
7538         * maint.c (_initialize_maint_cmds): Move initialization code to
7539         remote.c.
7540         (watchdog, show_watchdog): Move to remote.c.
7541         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7542         "watchdog" static.
7543         (_initialize_remote): Move initialization code from maint.c.
7544         * defs.h (watchdog): Don't declare.
7545
7546 2019-05-08  Tom Tromey  <tromey@adacore.com>
7547
7548         * tui/tui-interp.c: Include main.h.
7549         * interps.c: Include main.h.
7550         * main.h (interpreter_p): Declare.
7551         * defs.h (interpreter_p): Don't declare.
7552
7553 2019-05-08  Tom Tromey  <tromey@adacore.com>
7554
7555         * dwarf2loc.c: Include dwarf2read.h.
7556         * defs.h (read_unsigned_leb128): Don't declare.
7557         * dwarf2read.h (read_unsigned_leb128): Declare.
7558
7559 2019-05-08  Tom Tromey  <tromey@adacore.com>
7560
7561         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7562         method.
7563
7564 2019-05-08  Tom Tromey  <tromey@adacore.com>
7565
7566         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7567         when no wrap column is set.
7568
7569 2019-05-08  Tom Tromey  <tromey@adacore.com>
7570
7571         * c-lang.c (c_get_string): Handle non-C-style arrays.
7572
7573 2019-05-08  Tom Tromey  <tromey@adacore.com>
7574
7575         * typeprint.c (print_offset_data::update): Print the bit offset,
7576         not the number of bits remaining.
7577
7578 2019-05-08  Tom Tromey  <tromey@adacore.com>
7579
7580         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7581         padding at end of comment.
7582
7583 2019-05-08  Tom Tromey  <tromey@adacore.com>
7584
7585         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7586         Compare main types.
7587
7588 2019-05-06  Tom Tromey  <tom@tromey.com>
7589
7590         * common/scoped_mmap.c: Include common-defs.h.
7591         * common/scoped_mmap.h: Don't include config.h.
7592
7593 2019-05-04  Tom Tromey  <tom@tromey.com>
7594
7595         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7596         (struct aarch64_call_info): Add initializers.
7597         <si>: Now a std::vector.
7598         (pass_on_stack, aarch64_push_dummy_call): Update.
7599
7600 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7601             Tom Tromey  <tom@tromey.com>
7602
7603         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7604         (ppc_threads): Now a std::vector.  Now static.
7605         (hwdebug_find_thread_points_by_tid)
7606         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7607         Update.
7608
7609 2019-05-04  Tom Tromey  <tom@tromey.com>
7610
7611         * arc-tdep.c (arc_tdesc_init): Return bool.
7612
7613 2019-05-04  Tom Tromey  <tom@tromey.com>
7614
7615         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7616         Use gdb_assert_not_reached.
7617
7618 2019-05-04  Tom Tromey  <tom@tromey.com>
7619
7620         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7621         "false".
7622
7623 2019-05-04  Tom Tromey  <tom@tromey.com>
7624
7625         * arc-tdep.c (arc_tdesc_init): Use bool.
7626
7627 2019-05-04  Tom Tromey  <tom@tromey.com>
7628
7629         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7630
7631 2019-05-04  Tom Tromey  <tom@tromey.com>
7632
7633         * cli/cli-cmds.c (valid_command_p): Return bool.
7634
7635 2019-05-04  Tom Tromey  <tom@tromey.com>
7636
7637         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7638         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7639
7640 2019-05-04  Raul Tambre  <raul@tambre.ee>
7641
7642         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7643         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7644         operator for comparison.
7645
7646 2019-05-04  Tom Tromey  <tom@tromey.com>
7647
7648         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7649         (lookup_partial_symbol, print_partial_symbols)
7650         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7651         (psymbol_compare): Update.
7652         (add_psymbol_to_bcache): Clear the entire psymbol.
7653         (maintenance_check_psymtabs): Update.
7654         * psympriv.h (struct partial_symbol): Don't derive from
7655         general_symbol_info.
7656         <obj_section, unrelocated_address, address,
7657         set_unrelocated_address>: Update.
7658         <ginfo>: New member.
7659         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7660         (debug_names::write_psymbols): Update.
7661
7662 2019-05-04  Tom de Vries  <tdevries@suse.de>
7663
7664         * contrib/cc-with-tweaks.sh: Support -n arg.
7665
7666 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7667
7668         * corelow.c (core_target::detach): Ensure frame cache and
7669         register caches are cleared.
7670         inferior.c (exit_inferior_1): Likewise.
7671
7672 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7673             Tom Tromey  <tom@tromey.com>
7674
7675         * dictionary.c (collate_pending_symbols_by_language): Remove
7676         "struct" from foreach.
7677         * symtab.c (lookup_global_symbol_from_objfile)
7678         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7679         foreach.
7680         * ser-tcp.c (net_open): Remove "struct" from foreach.
7681         * objfiles.c (objfile_relocate, objfile_rebase)
7682         (objfile_has_symbols): Remove "struct" from foreach.
7683         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7684         from foreach.
7685         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7686         foreach.
7687         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7688         "struct" from foreach.
7689         * ada-lang.c (create_excep_cond_exprs)
7690         (ada_exception_catchpoint_cond_string): Remove "struct" from
7691         foreach.
7692
7693 2019-05-03  Tom Tromey  <tromey@adacore.com>
7694
7695         * ada-exp.y (convert_char_literal): Check suffix of each
7696         enumerator.
7697
7698 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7699
7700         PR ada/21406:
7701         * ada-exp.y (yywrap): Don't define.
7702         * ada-lex.l (%option): Add noyywrap
7703         (yywrap): Remove.
7704
7705 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7706
7707         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7708         _WIN32_WINNT to the XP level, unless already defined to a higher
7709         level.
7710
7711         * unittests/parse-connection-spec-selftests.c:
7712         * ser-tcp.c:
7713         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7714         override.
7715
7716         * symfile.c (find_separate_debug_file): Remove colon from the
7717         drive spec of DOS/Windows file names of the target, so that the
7718         file name produced from DEBUGDIR and the target's directory will
7719         be valid on DOS/Windows systems.
7720
7721 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         * rust-lang.c (val_print_struct): Handle printing structures
7724         containing strings.
7725
7726 2019-05-02  Tom Tromey  <tromey@adacore.com>
7727
7728         * valarith.c (_initialize_valarith): Remove.
7729
7730 2019-05-01  Tom Tromey  <tromey@adacore.com>
7731
7732         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7733         bitfields.
7734
7735 2019-05-01  Tom Tromey  <tromey@adacore.com>
7736
7737         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7738         for big-endian copies.
7739
7740 2019-04-30  Ali Tamur  <tamur@google.com>
7741         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7742         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7743         (read_3_bytes): New function.
7744
7745 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7746
7747         * windows-nat.c (main_thread_id): Delete.
7748         (handle_output_debug_string): Replace main_thread_id by
7749         current_event.dwThreadId.
7750         (fake_create_process): Likewise.
7751         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7752         Do not set main_thread_id.
7753         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7754         current_event.dwThreadId.
7755         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7756
7757 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7758
7759         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7760         Use current_event.dwThreadId instead of main_thread_id.
7761
7762 2019-04-30  Tom Tromey  <tromey@adacore.com>
7763
7764         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7765         (create_excep_cond_exprs): Iterate over program spaces.
7766         (ada_exception_catchpoint_cond_string): Examine all minimal
7767         symbols for exception types.
7768
7769 2019-04-30  Tom Tromey  <tromey@adacore.com>
7770
7771         PR c++/24470:
7772         * dwarf2read.c (process_structure_scope): Handle case where type
7773         has template parameters but no symbol was created.
7774
7775 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7776             Chris January  <chris.january@arm.com>
7777
7778         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7779         qualifier.
7780         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7781
7782 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7783
7784         * f-typeprint.c (f_print_type): Update rules for printing
7785         whitespace.
7786         (f_type_print_varspec_suffix): Likewise.
7787
7788 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7789             Chris January  <chris.january@arm.com>
7790
7791         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7792         function arguments.
7793
7794 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7795
7796         * f-lang.c (build_fortran_types): Change name of void type to
7797         lower case.
7798         * f-typeprint.c (f_type_print_base): Print the name of the void
7799         type, rather than a fixed string.
7800         * f-valprint.c (f_decorations): Use lower case void string.
7801
7802 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7803             Chris January  <chris.january@arm.com>
7804
7805         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7806         types for Fortran.
7807
7808 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7809             Chris January  <chris.january@arm.com>
7810             David Lecomber  <david.lecomber@arm.com>
7811
7812         * f-exp.y (BINOP_INTRINSIC): New token.
7813         (exp): New parser rule handling BINOP_INTRINSIC.
7814         (f77_keywords): Add new builtin procedures.
7815         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7816         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7817         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7818         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7819         (print_unop_subexp_f): New function.
7820         (print_binop_subexp_f): New function.
7821         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7822         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7823         (dump_subexp_body_f): Likewise.
7824         (operator_check_f): Likewise.
7825         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7826         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7827
7828 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7829
7830         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7831         UNOP_KIND.
7832         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7833         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7834         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7835         (operator_length_f): New fuction.
7836         (print_subexp_f): New function.
7837         (op_name_f): New function.
7838         (dump_subexp_body_f): New function.
7839         (operator_check_f): New function.
7840         (exp_descriptor_f): Replace standard expression handling functions
7841         with new functions.
7842         * gdb/fortran-operator.def: New file.
7843         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7844         * gdb/std-operator.def: Remove UNOP_KIND.
7845
7846 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7847
7848         * std-operator.def: Remove unbalanced, stray double quote
7849         character.
7850
7851 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7852             Chris January  <chris.january@arm.com>
7853             Daniel Everett  <daniel.everett@arm.com>
7854             Nick Forrington  <nick.forrington@arm.com>
7855             Richard Bunt  <richard.bunt@arm.com>
7856
7857         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7858         of depth when printing anonymous structs or unions.
7859         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7860         Don't print either the top-level value, or the children if the
7861         max-depth is exceeded.
7862         (ppscm_print_children): When printing the key of a map, allow one
7863         extra level of depth.
7864         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7865         print either the top-level value, or the children if the max-depth
7866         is exceeded.
7867         (print_children): When printing the key of a map, allow one extra
7868         level of depth.
7869         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7870         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7871         (user_print_options): Initialise max_depth field.
7872         (val_print_scalar_or_string_type_p): New function.
7873         (val_print): Check to see if the max depth has been reached.
7874         (val_print_check_max_depth): Define new function.
7875         (show_print_max_depth): New function.
7876         (_initialize_valprint): Add 'print max-depth' option.
7877         * valprint.h (struct value_print_options) <max_depth>: New field.
7878         (val_print_check_max_depth): Declare new function.
7879         * NEWS: Document new feature.
7880
7881 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7882
7883         * ada-lang.c (ada_language_defn): Initialise new field.
7884         * c-lang.c (c_is_string_type_p): New function.
7885         (c_language_defn): Initialise new field.
7886         (cplus_language_defn): Initialise new field.
7887         (asm_language_defn): Initialise new field.
7888         (minimal_language_defn): Initialise new field.
7889         * c-lang.h (c_is_string_type_p): Declare new function.
7890         * d-lang.c (d_language_defn): Initialise new field.
7891         * f-lang.c (f_is_string_type_p): New function.
7892         (f_language_defn): Initialise new field.
7893         * go-lang.c (go_is_string_type_p): New function.
7894         (go_language_defn): Initialise new field.
7895         * language.c (default_is_string_type_p): New function.
7896         (unknown_language_defn): Initialise new field.
7897         (auto_language_defn): Initialise new field.
7898         * language.h (struct language_defn) <la_is_string_type_p>: New
7899         member variable.
7900         (default_is_string_type_p): Declare new function.
7901         * m2-lang.c (m2_language_defn): Initialise new field.
7902         * objc-lang.c (objc_language_defn): Initialise new field.
7903         * opencl-lang.c (opencl_language_defn): Initialise new field.
7904         * p-lang.c (pascal_is_string_type_p): New function.
7905         (pascal_language_defn): Initialise new field.
7906         * rust-lang.c (rust_is_string_type_p): New function.
7907         (rust_language_defn): Initialise new field.
7908
7909 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7910
7911         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7912         New field.
7913         * ada-lang.c (ada_language_defn): Initialise new field.
7914         * c-lang.c (c_language_defn): Likewise.
7915         (cplus_language_defn): Likewise.
7916         (asm_language_defn): Likewise.
7917         (minimal_language_defn): Likewise.
7918         * d-lang.c (d_language_defn): Likewise.
7919         * f-lang.c (f_language_defn): Likewise.
7920         * go-lang.c (go_language_defn): Likewise.
7921         * language.c (unknown_language_defn): Likewise.
7922         (auto_language_defn): Likewise.
7923         * m2-lang.c (m2_language_defn): Likewise.
7924         * objc-lang.c (objc_language_defn): Likewise.
7925         * opencl-lang.c (opencl_language_defn): Likewise.
7926         * p-lang.c (pascal_language_defn): Likewise.
7927         * rust-lang.c (rust_language_defn): Likewise.
7928
7929 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7930
7931         * ada-lang.c (ada_is_character_type): Change return type to bool.
7932         (ada_is_string_type): Likewise.
7933         * ada-lang.h (ada_is_character_type): Update declaration
7934         (ada_is_string_type): Likewise.
7935
7936 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7937
7938         Support style in 'frame|thread apply'
7939
7940         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7941         * record.c (record_start, record_stop): Update callers of
7942         execute_command_to_string with false.
7943         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7944         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7945         methods.
7946         (class string_file): New constructor with term_out parameter.
7947         Override methods term_out and can_emit_style_escape.  New member
7948         term_out.
7949         (class stdio_file): Override can_emit_style_escape.
7950         (class tee_file): Override term_out and can_emit_style_escape.
7951         * utils.h (can_emit_style_escape): Remove.
7952         * utils.c (can_emit_style_escape): Likewise.
7953         Update all callers of can_emit_style_escape (SOMESTREAM) to
7954         SOMESTREAM->can_emit_style_escape.
7955         * source-cache.c (source_cache::get_source_lines): Likewise.
7956         * stack.c (frame_apply_command_count): Call execute_command_to_string
7957         passing the term_out characteristic of the current gdb_stdout.
7958         * thread.c (thr_try_catch_cmd): Likewise.
7959         * top.c (execute_command_to_string): pass term_out parameter
7960         to construct the string_file for the command output.
7961         * ui-file.c (term_cli_styling): New function (most code moved
7962         from utils.c can_emit_style_escape).
7963         (string_file::string_file, string_file::can_emit_style_escape,
7964         stdio_file::can_emit_style_escape, tee_file::term_out,
7965         tee_file::can_emit_style_escape): New functions.
7966
7967 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7968
7969         * NEWS: Mention the new set|show may-call-functions.
7970         * infcall.c (may_call_functions_p): New variable.
7971         (show_may_call_functions_p): New function.
7972         (call_function_by_hand_dummy): Throws an error if not
7973         may-call-functions.
7974         (_initialize_infcall): Call add_setshow_boolean_cmd for
7975         may-call-functions.
7976
7977 2019-04-25  Keith Seitz  <keiths@redhat.com>
7978
7979         PR c++/24367
7980         * cp-support.c (inspect_type): Don't attempt substitutions
7981         of symbol with the same name.
7982
7983 2019-04-25  Tom Tromey  <tromey@adacore.com>
7984
7985         PR gdb/24475:
7986         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7987         static.
7988
7989 2019-04-25  Tom Tromey  <tromey@adacore.com>
7990
7991         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7992         rvalue reference.
7993         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7994         (gdb_xml_parser::parse): Use std::move.
7995         * python/python-internal.h (gdbpy_convert_exception): Take a const
7996         reference.
7997         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7998         std::move.
7999         * python/py-utils.c (gdbpy_convert_exception): Take a const
8000         reference.
8001         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8002         Use std::move.
8003         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8004         Use std::move.
8005         * mi/mi-main.c (mi_print_exception): Take a const reference.
8006         * main.c (handle_command_errors): Take a const reference.
8007         * linespec.c (parse_linespec): Use std::move.
8008         * infcall.c (run_inferior_call): Use std::move.
8009         (call_function_by_hand_dummy): Use std::move.
8010         * exec.c (try_open_exec_file): Use std::move.
8011         * exceptions.h (exception_print, exception_fprintf)
8012         (exception_print_same): Update.
8013         * exceptions.c (print_exception, exception_print)
8014         (exception_fprintf, exception_print_same): Change parameters to
8015         const reference.
8016         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8017         * common/new-op.c: Use std::move.
8018         * common/common-exceptions.h (struct gdb_exception): Add move
8019         constructor.
8020         (struct gdb_exception_error, struct gdb_exception_quit, struct
8021         gdb_quit_bad_alloc): Change constructor to move constructor.
8022         (throw_exception): Change parameter to rvalue reference.
8023         * common/common-exceptions.c (throw_exception): Take rvalue
8024         reference.
8025         * cli/cli-interp.c (safe_execute_command): Use std::move.
8026         * breakpoint.c (insert_bp_location, location_to_sals): Use
8027         std::move.
8028
8029 2019-04-25  Tom Tromey  <tromey@adacore.com>
8030
8031         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8032         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8033         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8034         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8035         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8036         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8037         guile/scm-value.c: Use unpack.
8038         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8039         gdbscm_gdb_exception.
8040         (gdbscm_throw_gdb_exception): Likewise.
8041         (struct gdbscm_gdb_exception): New.
8042         (unpack): New function.
8043         (gdbscm_wrap): Use unpack.
8044
8045 2019-04-25  Tom Tromey  <tromey@adacore.com>
8046
8047         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8048         (gdb_rl_callback_handler): Use std::move.
8049         * common/common-exceptions.h (struct gdb_exception): Add move
8050         assignment operator.
8051         (throw_exception_sjlj): Change "exception" to const reference.
8052         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8053         (throw_exception_sjlj): Change "exception" to const reference.
8054
8055 2019-04-25  Tom Tromey  <tromey@adacore.com>
8056
8057         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8058         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8059         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8060         Update.
8061         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8062         Update.
8063         * mi/mi-interp.c (mi_interp::exec): Update.
8064         * linespec.c (parse_linespec): Update.
8065         * infcall.c (run_inferior_call): Update.
8066         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8067         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8068         (gdbscm_lookup_global_symbol): Update.
8069         * guile/scm-param.c (gdbscm_parameter_value): Update.
8070         * guile/scm-frame.c (gdbscm_frame_read_register)
8071         (gdbscm_frame_read_var): Update.
8072         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8073         * exec.c (try_open_exec_file): Update.
8074         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8075         (gdb_rl_callback_handler): Update.
8076         * common/common-exceptions.h (exception_none): Don't declare.
8077         * common/common-exceptions.c (exception_none): Don't define.
8078         (struct catcher) <exception>: Update.
8079         * cli/cli-interp.c (safe_execute_command): Update.
8080         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8081
8082 2019-04-25  Ali Tamur  <tamur@google.com>
8083
8084         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8085         (read_attribute_value): Likewise.
8086         (dwarf2_read_addr_index): Update comment.
8087         (read_str_index): Add DW_FORM_strx.
8088         (dwarf2_string_attr): Likewise.
8089         (dwarf2_const_value_attr): Likewise.
8090         (dump_die_shallow): Likewise.
8091         (dwarf2_fetch_constant_bytes): Likewise.
8092         (skip_form_bytes): Likewise.
8093         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8094
8095 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8096
8097         PR corefiles/11608
8098         PR corefiles/18187
8099         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8100         OFFSET.  Verify if current mapping contains an ELF header.
8101         (linux_find_memory_regions_full): Adjust call to
8102         dump_mapping_p.
8103
8104 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8105             Kang Li <kanglictf@gmail.com>
8106
8107         PR gdb/21600
8108
8109         * dwarf2-frame.c (read_initial_length): Be consistent about using
8110         unsigned representation of length.
8111         (decode_frame_entry_1): Likewise.  Check for wraparound of
8112         end pointer as well as buffer overflow.
8113
8114 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8115
8116         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8117         "vq".
8118
8119 2019-04-24  Tom Tromey  <tromey@adacore.com>
8120
8121         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8122
8123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8124
8125         * s12z-tdep.c (s12z_unwind_pc): Delete.
8126         (s12z_unwind_sp): Delete.
8127         (s12z_gdbarch_init): Don't register deleted functions with
8128         gdbarch.
8129
8130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8131
8132         * rl78-tdep.c (rl78_unwind_sp): Delete.
8133         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8134
8135 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8136
8137         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8138         (xstormy16_unwind_pc): Delete.
8139         (xstormy16_dummy_id): Delete.
8140         (xstormy16_gdbarch_init): Don't register deleted functions with
8141         gdbarch.
8142
8143 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8144
8145         * vax-tdep.c (vax_unwind_pc): Delete.
8146         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8147
8148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8149
8150         * v850-tdep.c (v850_unwind_sp): Delete.
8151         (v850_unwind_pc): Delete.
8152         (v850_dummy_id): Delete.
8153         (v850_gdbarch_init): Don't register deleted functions with
8154         gdbarch.
8155
8156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8157
8158         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8159         (tilegx_unwind_pc): Delete.
8160         (tilegx_unwind_dummy_id): Delete.
8161         (tilegx_gdbarch_init): Don't register deleted functions with
8162         gdbarch.
8163
8164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8165
8166         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8167         (tic6x_dummy_id): Delete.
8168         (tic6x_gdbarch_init): Don't register deleted functions with
8169         gdbarch.
8170
8171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8172
8173         * sparc-tdep.c (sparc_unwind_pc): Delete.
8174         (sparc32_gdbarch_init): Don't register deleted function with
8175         gdbarch.
8176
8177 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8178
8179         * sh-tdep.c (sh_unwind_sp): Delete.
8180         (sh_unwind_pc): Delete.
8181         (sh_dummy_id): Delete.
8182         (sh_gdbarch_init): Don't register deleted functions with
8183         gdbarch.
8184
8185 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8186
8187         * score-tdep.c (score_unwind_sp): Delete.
8188         (score_unwind_pc): Delete.
8189         (score_dummy_id): Delete.
8190         (score_gdbarch_init): Don't register deleted functions with
8191         gdbarch.
8192
8193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8194
8195         * rx-tdep.c (rx_unwind_pc): Delete.
8196         (rx_unwind_sp): Delete.
8197         (rx_dummy_id): Delete.
8198         (rx_gdbarch_init): Don't register deleted functions with
8199         gdbarch.  Update comment.
8200
8201 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8202
8203         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8204         (rs6000_dummy_id): Delete.
8205         (rs6000_gdbarch_init): Don't register deleted functions with
8206         gdbarch.
8207
8208 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8209
8210         * or1k-tdep.c (or1k_dummy_id): Delete.
8211         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8212
8213 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8214
8215         * nios2-tdep.c (nios2_dummy_id): Delete.
8216         (nios2_unwind_sp): Delete.
8217         (nios2_gdbarch_init): Don't register deleted functions with
8218         gdbarch.
8219
8220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8221
8222         * nds32-tdep.c (nds32_dummy_id): Delete.
8223         (nds32_unwind_pc): Delete.
8224         (nds32_unwind_sp): Delete.
8225         (nds32_gdbarch_init): Don't register deleted functions with
8226         gdbarch.
8227
8228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8229
8230         * msp430-tdep.c (msp430_unwind_pc): Delete.
8231         (msp430_unwind_sp): Delete.
8232         (msp430_dummy_id): Delete.
8233         (msp430_gdbarch_init): Don't register deleted functions with
8234         gdbarch.
8235
8236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8237
8238         * moxie-tdep.c (moxie_unwind_sp): Delete.
8239         (moxie_unwind_pc): Delete.
8240         (moxie_dummy_id): Delete.
8241         (moxie_gdbarch_init): Don't register deleted functions with
8242         gdbarch.
8243
8244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8245
8246         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8247         (mn10300_unwind_pc): Delete.
8248         (mn10300_unwind_sp): Delete.
8249         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8250         mn10300_unwind_sp.
8251         (mn10300_frame_unwind_init): Don't register deleted functions with
8252         gdbarch.
8253
8254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8255
8256         * mep-tdep.c (mep_unwind_pc): Delete.
8257         (mep_unwind_sp): Delete.
8258         (mep_dummy_id): Delete.
8259         (mep_gdbarch_init): Don't register deleted functions with
8260         gdbarch.
8261
8262 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8263
8264         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8265         (m68hc11_unwind_sp): Delete.
8266         (m68hc11_gdbarch_init): Don't register deleted functions with
8267         gdbarch.
8268
8269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8270
8271         * m32r-tdep.c (m32r_unwind_sp): Delete.
8272         (m32r_unwind_pc): Delete.
8273         (m32r_dummy_id): Delete.
8274         (m32r_gdbarch_init): Don't register deleted functions with
8275         gdbarch.
8276
8277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8278
8279         * m32c-tdep.c (m32c_unwind_pc): Delete.
8280         (m32c_unwind_sp): Delete.
8281         (m32c_dummy_id): Delete.
8282         (m32c_gdbarch_init): Don't register deleted functions with
8283         gdbarch.
8284
8285 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8286
8287         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8288         (lm32_unwind_pc): Delete.
8289         (lm32_dummy_id): Delete.
8290         (lm32_gdbarch_init): Don't register deleted functions with
8291         gdbarch.
8292
8293 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8294
8295         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8296         (iq2000_unwind_pc): Delete.
8297         (iq2000_dummy_id): Delete.
8298         (iq2000_gdbarch_init): Don't register deleted functions with
8299         gdbarch.
8300
8301 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8302
8303         * nds32-tdep.c (nds32_type_align): Delete.
8304         (nds32_push_dummy_call): Use type_align instead.
8305
8306 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8307
8308         * arm-tdep.c (arm_type_align): Only handle vector override case.
8309         (arm_push_dummy_call): Use type_align.
8310         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8311
8312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8313
8314         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8315         case.
8316         (pass_on_stack): Use type_align.
8317         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8318         function.
8319
8320 2019-04-23  Tom Tromey  <tromey@adacore.com>
8321
8322         * dwarf2read.c (line_header::file_name_at): Remove unused
8323         overload.
8324
8325 2019-04-23  Tom de Vries  <tdevries@suse.de>
8326
8327         PR gdb/24438
8328         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8329         invocation.
8330
8331
8332 2019-03-27  Ali Tamur  <tamur@google.com>
8333
8334         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8335         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8336         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8337         (dwarf_expr_context::get_addr_index): Likewise
8338         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8339         (symbol_needs_eval_context::get_addr_index): Likewise
8340         (disassemble_dwarf_expression): Add DW_OP_addrx
8341         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8342         (read_cutu_die_from_dwo): Update comment
8343         (skip_one_die): Add DW_FORM_addrx
8344         (read_attribute_value): Likewise
8345         (var_decode_location): Add DW_OP_addrx
8346         (dwarf2_const_value_attr): Add DW_FORM_addrx
8347         (dump_die_shallow): Likewise
8348         (dwarf2_fetch_constant_bytes): Likewise
8349         (decode_locdesc): Add DW_OP_addrx
8350         (skip_form_bytes): Add DW_FORM_addrx
8351
8352 2019-04-22  Ali Tamur  <tamur@google.com>
8353
8354         * MAINTAINERS (Write After Approval): Add self.
8355
8356 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8357
8358         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8359         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8360         (open_symbol_file_object): Likewise.
8361         (svr4_default_sos): Add info parameter.
8362         (svr4_read_so_list): Likewise.
8363         (svr4_current_sos_direct): Adjust functions calls to pass down
8364         info.
8365         (svr4_current_sos_1): Add info parameter.
8366         (svr4_current_sos): Call get_svr4_info, pass info down to
8367         svr4_current_sos_1.
8368         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8369         get_svr4_info.
8370         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8371         get_svr4_info.
8372         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8373         to get_svr4_info.
8374         (probes_table_remove_objfile_probes): Likewise.
8375         (register_solib_event_probe): Add info parameter.
8376         (solist_update_incremental): Pass info parameter down to
8377         svr4_read_so_list.
8378         (disable_probes_interface): Add info parameter.
8379         (svr4_handle_solib_event): Pass current_program_space to
8380         get_svr4_info.  Adjust disable_probes_interface cleanup.
8381         (svr4_create_probe_breakpoints): Add info parameter, pass it
8382         down to register_solib_event_probe.
8383         (svr4_create_solib_event_breakpoints): Add info parameter,
8384         pass it down to svr4_create_probe_breakpoints.
8385         (enable_break): Pass info down to
8386         svr4_create_solib_event_breakpoints.
8387         (svr4_solib_create_inferior_hook): Pass current_program_space to
8388         get_svr4_info.
8389         (svr4_clear_solib): Likewise.
8390
8391 2019-04-22  Pedro Alves  <palves@redhat.com>
8392
8393         * solib-svr4.c (svr4_free_objfile_observer): New.
8394         (probe_and_action::objfile): New field.
8395         (probes_table_htab_remove_objfile_probes)
8396         (probes_table_remove_objfile_probes): New functions.
8397         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8398         in the new probe_and_action.  Don't store the probe in 'lookup'.
8399         (svr4_create_probe_breakpoints): Pass objfile to
8400         register_solib_event_probe.
8401         (_initialize_svr4_solib): Register a free_objfile observer.
8402
8403 2019-04-19  Tom Tromey  <tom@tromey.com>
8404
8405         * common/queue.h: Remove.
8406
8407 2019-04-19  Tom Tromey  <tom@tromey.com>
8408
8409         * event-loop.c: Don't include "common/queue.h".
8410
8411 2019-04-19  Tom Tromey  <tom@tromey.com>
8412
8413         * remote.c (remote_target): Use delete.
8414         * remote-notif.h: Include <list>, not "common/queue.h".
8415         (notif_client_p): Remove typedef.
8416         (remote_notif_state): Add constructor, destructor, initializer.
8417         <notif_queue>: Now a std::list.
8418         (remote_notif_state_xfree): Don't declare.
8419         * remote-notif.c (remote_notif_process, handle_notification)
8420         (remote_notif_state_allocate): Update.
8421         (~remote_notif_state): Rename from remote_notif_state_xfree.
8422
8423 2019-04-19  Tom Tromey  <tom@tromey.com>
8424
8425         * symfile.c (reread_symbols): Update.
8426         * objfiles.c (objfile_register_static_link)
8427         (objfile_lookup_static_link): Update
8428         (~objfile) Don't delete static_links.
8429         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8430
8431 2019-04-19  Tom Tromey  <tom@tromey.com>
8432
8433         * type-stack.h (struct type_stack) <insert>: Constify string.
8434         * type-stack.c (type_stack::insert): Constify string.
8435         * gdbtypes.h (lookup_template_type): Update.
8436         (address_space_name_to_int): Update.
8437         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8438         const.
8439         (lookup_template_type): Make name const.
8440         * c-exp.y: Update rules.
8441         (lex_one_token, classify_name, classify_inner_name)
8442         (c_print_token): Update.
8443         * p-exp.y: Update rules.
8444         (yylex): Update.
8445         * f-exp.y: Update rules.
8446         (yylex): Update.
8447         * d-exp.y: Update rules.
8448         (lex_one_token, classify_name, classify_inner_name): Update.
8449         * parse.c (write_dollar_variable, copy_name): Return std::string.
8450         * parser-defs.h (copy_name): Change return type.
8451         * m2-exp.y: Update rules.
8452         (yylex): Update.
8453         * go-exp.y (lex_one_token): Update.
8454         Update rules.
8455         (classify_unsafe_function, classify_packaged_name)
8456         (classify_name, yylex): Update.
8457
8458 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8459
8460         * configure.ac: add --enable-source-highlight switch.
8461         * configure: Regenerate.
8462         * top.c (print_gdb_version): plumb --enable-source-highlight
8463         status to "show configuration".
8464
8465 2019-04-19  Tom Tromey  <tromey@adacore.com>
8466
8467         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8468         Check ADA_TYPE_P.
8469         (empty_record, ada_template_to_fixed_record_type_1)
8470         (template_to_static_fixed_type)
8471         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8472         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8473         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8474         macros.
8475
8476 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8477
8478         PR symtab/24423:
8479         * source.c (print_source_lines_base): Advance "iter" when a
8480         control character is seen.
8481
8482 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8483
8484         * inferior.h (struct infcall_suspend_state_deleter):
8485         Catch exception in destructor to avoid crash.
8486
8487 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8488
8489         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8490         close to the add_com "shell".
8491
8492 2019-04-18  Tom Tromey  <tromey@adacore.com>
8493
8494         * process-stratum-target.h (class process_stratum_target)
8495         <stratum>: Add "final".
8496
8497 2019-04-17  Tom Tromey  <tromey@adacore.com>
8498
8499         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8500         against nullptr before use.
8501
8502 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8503
8504         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8505
8506 2019-04-17  Jim Wilson  <jimw@sifive.com>
8507             Andrew Burgess  <andrew.burgess@embecosm.com>
8508
8509         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8510         code read might fail, assume 4-byte breakpoint in that case.
8511
8512 2019-04-15  Leszek Swirski  <leszeks@google.com>
8513
8514         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8515         rather than a hand-rolled POD check when checking for forced MEMORY
8516         classification.
8517
8518 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8519
8520         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8521         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8522         function.
8523         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8524         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8525         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8526         declaration.
8527
8528 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8529
8530         * aarch64-linux-nat.c
8531         (aarch64_linux_nat_target::thread_architecture): Add override.
8532         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8533         each VQ.
8534
8535 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8536
8537         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8538
8539 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8540
8541         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8542         target types of size 96-bits, add some additional comments, and
8543         check that the builtin type we found was the correct size.
8544
8545 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8546
8547         * utils.c (prompt_for_continue): Don't restore the styling at the
8548         end, as applied_style has the wrong value.  This fixes styling in
8549         long lists of file names that are interrupted by the "Continue?"
8550         prompt.
8551
8552 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8553
8554         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8555         * c-lang.c (c_language_defn): Likewise.
8556         (cplus_language_defn): Likewise.
8557         (asm_language_defn): Likewise.
8558         (minimal_language_defn): Likewise.
8559         * d-lang.c (d_language_defn): Likewise.
8560         * f-lang.c (f_language_defn): Likewise.
8561         * go-lang.c (go_language_defn): Likewise.
8562         * language.c (unknown_language_defn): Likewise.
8563         (auto_language_defn): Likewise.
8564         * language.h (struct language_defn): Remove la_magic field.
8565         (LANG_MAGIC): Delete.
8566         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8567         * objc-lang.c (objc_language_defn): Likewise.
8568         * opencl-lang.c (opencl_language_defn): Likewise.
8569         * p-lang.c (pascal_language_defn): Likewise.
8570         * rust-lang.c (rust_language_defn): Likewise.
8571
8572 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8573
8574         * riscv-tdep.c (riscv_type_align): New function.
8575         (riscv_type_alignment): Delete.
8576         (riscv_arg_location): Use 'type_align'.
8577         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8578
8579 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8580
8581         * gdbtypes.c (type_align): A struct with no non-static fields also
8582         has alignment of 1.
8583
8584 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8585
8586         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8587         component to 0.
8588         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8589         member.
8590         (riscv_struct_info::analyse): New implementation using new
8591         analyse_inner member function.
8592         (riscv_struct_info::field_offset): New member function.
8593         (riscv_struct_info::m_offsets): New member variable.
8594         (riscv_struct_info::analyse_inner): New private member function,
8595         takes the old implementation of riscv_struct_info::analyse but
8596         extended to track field offsets.
8597         (riscv_call_arg_struct): Update the struct folding special cases
8598         to handle cases where empty C++ structs, which are non-zero
8599         length, are found.
8600         (riscv_arg_location): Initialise the length of each location, a
8601         non-zero length now indicates the location is in use.
8602         (riscv_push_dummy_call): Allow for the first location having a
8603         non-zero offset when setting up arguments.
8604         (riscv_return_value): Likewise, but for return values.
8605
8606 2019-04-11  Tom Tromey  <tromey@adacore.com>
8607
8608         * utils.c (internal_vproblem): Make "msg" const.
8609
8610 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8611
8612         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8613         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8614         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8615         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8616
8617 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8618
8619         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8620         function.
8621         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8622         of amd64_collect_native_gregset.
8623         (amd64_linux_nat_target::store_registers): Likewise.
8624
8625 2019-04-10  Tom Tromey  <tom@tromey.com>
8626
8627         * symtab.c (lookup_global_symbol_from_objfile)
8628         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8629         * objfiles.h (class separate_debug_iterator): New.
8630         (class separate_debug_range): New.
8631         (struct objfile) <separate_debug_objfiles>: New method.
8632         (objfile_separate_debug_iterate): Don't declare.
8633         * objfiles.c (separate_debug_iterator::operator++): Rename from
8634         objfile_separate_debug_iterate.
8635         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8636         iterator.
8637         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8638         iterator.
8639
8640 2019-04-10  Tom Tromey  <tom@tromey.com>
8641
8642         * symfile.c (reread_symbols): Remove old comment.
8643         * objfiles.c (free_all_objfiles): Fix a typo.
8644
8645 2019-04-10  Tom Tromey  <tom@tromey.com>
8646
8647         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8648         * minsyms.c (lookup_minimal_symbol): Use foreach.
8649         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8650         (lookup_minimal_symbol_solib_trampoline): Likewise.
8651         * symfile.c (reread_symbols): Use foreach.
8652
8653 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8654             Tom Tromey  <tromey@adacore.com>
8655
8656         PR rust/24414:
8657         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8658         (rust_lex_int_test): Change "value" to be LONGEST.
8659         (rust_lex_tests): Add test for long integer literal.
8660
8661 2019-04-09  Tom Tromey  <tromey@adacore.com>
8662
8663         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8664         to bool.
8665         (extended_remote_target::attach): Update.
8666         (remote_target::remote_notice_new_inferior): Update.
8667         (remote_target::add_current_inferior_and_thread): Update.
8668         * inferior.c (exit_inferior_1): Use "false".
8669         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8670
8671 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8672
8673         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8674         the "start" command.
8675
8676 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8677
8678         * python/py-inferior.c (infpy_thread_from_thread_handle):
8679         Adjust comments to reflect renaming of thread_from_thread_handle
8680         to thread_from_handle.  Adjust keywords.  Fix type error message.
8681         (inferior_object_methods): Add thread_from_handle.  Retain
8682         thread_from_thread_handle, but mark it as deprecated.
8683
8684 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8685
8686         * gdbthread.h (find_thread_by_handle): Revise declaration.
8687         * thread.c (find_thread_by_handle): Likewise.  Adjust
8688         implementation too.
8689         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8690         support for buffer objects as handles.
8691
8692 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8693
8694         * python/py-infthread.c (thpy_thread_handle): New function.
8695         (thread_object_methods): Register thpy_thread_handle.
8696
8697 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8698
8699         * gdbthread.h (thread_to_thread_handle): Declare.
8700         * thread.c (gdbtypes.h): Include.
8701         (thread_to_thread_handle): New function.
8702
8703         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8704         (target_thread_info_to_thread_handle): Declare.
8705         * target.c (target_thread_info_to_thread_handle): New function.
8706         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8707         * target-delegates.c: Regenerate.
8708
8709         * linux-thread-db.c (class thread_db_target): Add method
8710         thread_info_to_thread_handle.
8711         (thread_db_target::thread_info_to_thread_handle): Define.
8712         * remote.c (class remote_target): Add new method
8713         thread_info_to_thread_handle.
8714         (remote_target::thread_info_to_thread_handle): Define.
8715
8716 2019-04-08  Pedro Alves  <palves@redhat.com>
8717
8718         * common/common-exceptions.c (throw_exception): Don't create
8719         named object to throw; throw directly.
8720         (throw_it): Likewise.  Don't initialize gdb_exception::message
8721         here, with new; pass FMT and AP to the ctor instead.
8722         * common/common-exceptions.h: Include <string>.
8723         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8724         const char *, va_list)): New ctor.  Use std::make_shared.
8725         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8726         errors)): Delete.
8727         (gdb_exception_error::gdb_exception_error(enum errors, const char
8728         *, va_list)): New.
8729         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8730         Add assertion.
8731         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8732         errors)): Delete.
8733         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8734         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8735         Add assertion.
8736
8737 2019-04-08  Tom Tromey  <tom@tromey.com>
8738
8739         * valops.c (value_rtti_indirect_type): Replace throw_exception
8740         with throw.
8741         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8742         with throw.
8743         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8744         throw.
8745         * target.c (target_translate_tls_address): Replace throw_exception
8746         with throw.
8747         * stack.c (frame_apply_command_count): Replace throw_exception
8748         with throw.
8749         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8750         throw.
8751         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8752         with throw.
8753         * rs6000-tdep.c (rs6000_frame_cache)
8754         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8755         * remote.c: Replace throw_exception with throw.
8756         * record-full.c (record_full_message, record_full_wait_1)
8757         (record_full_restore): Replace throw_exception with throw.
8758         * record-btrace.c:
8759         (get_thread_current_frame_id, record_btrace_start_replaying)
8760         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8761         (cmd_record_btrace_start): Replace throw_exception with throw.
8762         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8763         throw.
8764         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8765         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8766         * linespec.c:
8767         (find_linespec_symbols): Replace throw_exception with throw.
8768         * infrun.c (displaced_step_prepare, resume): Replace
8769         throw_exception with throw.
8770         * infcmd.c (post_create_inferior): Replace throw_exception with
8771         throw.
8772         * inf-loop.c (inferior_event_handler): Replace throw_exception
8773         with throw.
8774         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8775         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8776         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8777         (get_prev_frame_always, get_frame_pc_if_available)
8778         (get_frame_address_in_block_if_available, get_frame_language):
8779         Replace throw_exception with throw.
8780         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8781         throw_exception with throw.
8782         * eval.c (fetch_subexp_value, evaluate_var_value)
8783         (evaluate_funcall, evaluate_subexp_standard): Replace
8784         throw_exception with throw.
8785         * dwarf2loc.c (call_site_find_chain)
8786         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8787         Replace throw_exception with throw.
8788         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8789         with throw.
8790         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8791         throw.
8792         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8793         * completer.c (complete_line_internal): Replace throw_exception
8794         with throw.
8795         * compile/compile-object-run.c (compile_object_run): Replace
8796         throw_exception with throw.
8797         * cli/cli-script.c (process_next_line): Replace throw_exception
8798         with throw.
8799         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8800         (btrace_enable, btrace_maint_update_pt_packets): Replace
8801         throw_exception with throw.
8802         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8803         throw_exception with throw.
8804         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8805         throw_exception with throw.
8806         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8807         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8808         * aarch64-tdep.c (aarch64_make_prologue_cache)
8809         (aarch64_make_stub_cache): Replace throw_exception with throw.
8810
8811 2019-04-08  Tom Tromey  <tom@tromey.com>
8812
8813         * common/common-exceptions.c (throw_exception): Rename from
8814         throw_exception_cxx.  Remove old copy.  Make argument const.
8815         (throw_it): Create and throw exception objects directly.
8816         * common/common-exceptions.h (throw_exception): Make argument
8817         const.
8818         (struct gdb_exception_error): Add constructor.
8819         (struct gdb_exception_quit): Add constructor.
8820
8821 2019-04-08  Tom Tromey  <tom@tromey.com>
8822
8823         * common/common-exceptions.h (exception_rethrow): Don't declare.
8824         (TRY_SJLJ): Update comment.
8825         (TRY, CATCH, END_CATCH): Remove.
8826         * common/common-exceptions.c (exception_rethrow): Remove.
8827
8828 2019-04-08  Tom Tromey  <tom@tromey.com>
8829
8830         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8831         Remove.
8832         (gdb_exception_error): Rename from
8833         gdb_exception_RETURN_MASK_ERROR.
8834         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8835         (gdb_quit_bad_alloc): Update.
8836         * aarch64-tdep.c: Update.
8837         * ada-lang.c: Update.
8838         * ada-typeprint.c: Update.
8839         * ada-valprint.c: Update.
8840         * amd64-tdep.c: Update.
8841         * arch-utils.c: Update.
8842         * break-catch-throw.c: Update.
8843         * breakpoint.c: Update.
8844         * btrace.c: Update.
8845         * c-varobj.c: Update.
8846         * cli/cli-cmds.c: Update.
8847         * cli/cli-interp.c: Update.
8848         * cli/cli-script.c: Update.
8849         * common/common-exceptions.c: Update.
8850         * common/new-op.c: Update.
8851         * common/selftest.c: Update.
8852         * compile/compile-c-symbols.c: Update.
8853         * compile/compile-cplus-symbols.c: Update.
8854         * compile/compile-object-load.c: Update.
8855         * compile/compile-object-run.c: Update.
8856         * completer.c: Update.
8857         * corelow.c: Update.
8858         * cp-abi.c: Update.
8859         * cp-support.c: Update.
8860         * cp-valprint.c: Update.
8861         * darwin-nat.c: Update.
8862         * disasm-selftests.c: Update.
8863         * dtrace-probe.c: Update.
8864         * dwarf-index-cache.c: Update.
8865         * dwarf-index-write.c: Update.
8866         * dwarf2-frame-tailcall.c: Update.
8867         * dwarf2-frame.c: Update.
8868         * dwarf2loc.c: Update.
8869         * dwarf2read.c: Update.
8870         * eval.c: Update.
8871         * event-loop.c: Update.
8872         * event-top.c: Update.
8873         * exec.c: Update.
8874         * f-valprint.c: Update.
8875         * fbsd-tdep.c: Update.
8876         * frame-unwind.c: Update.
8877         * frame.c: Update.
8878         * gdbtypes.c: Update.
8879         * gnu-v3-abi.c: Update.
8880         * guile/guile-internal.h: Update.
8881         * guile/scm-block.c: Update.
8882         * guile/scm-breakpoint.c: Update.
8883         * guile/scm-cmd.c: Update.
8884         * guile/scm-disasm.c: Update.
8885         * guile/scm-frame.c: Update.
8886         * guile/scm-lazy-string.c: Update.
8887         * guile/scm-math.c: Update.
8888         * guile/scm-param.c: Update.
8889         * guile/scm-ports.c: Update.
8890         * guile/scm-pretty-print.c: Update.
8891         * guile/scm-symbol.c: Update.
8892         * guile/scm-symtab.c: Update.
8893         * guile/scm-type.c: Update.
8894         * guile/scm-value.c: Update.
8895         * i386-linux-tdep.c: Update.
8896         * i386-tdep.c: Update.
8897         * inf-loop.c: Update.
8898         * infcall.c: Update.
8899         * infcmd.c: Update.
8900         * infrun.c: Update.
8901         * jit.c: Update.
8902         * language.c: Update.
8903         * linespec.c: Update.
8904         * linux-fork.c: Update.
8905         * linux-nat.c: Update.
8906         * linux-tdep.c: Update.
8907         * linux-thread-db.c: Update.
8908         * main.c: Update.
8909         * mi/mi-cmd-break.c: Update.
8910         * mi/mi-cmd-stack.c: Update.
8911         * mi/mi-interp.c: Update.
8912         * mi/mi-main.c: Update.
8913         * objc-lang.c: Update.
8914         * p-valprint.c: Update.
8915         * parse.c: Update.
8916         * ppc-linux-tdep.c: Update.
8917         * printcmd.c: Update.
8918         * python/py-arch.c: Update.
8919         * python/py-breakpoint.c: Update.
8920         * python/py-cmd.c: Update.
8921         * python/py-finishbreakpoint.c: Update.
8922         * python/py-frame.c: Update.
8923         * python/py-framefilter.c: Update.
8924         * python/py-gdb-readline.c: Update.
8925         * python/py-inferior.c: Update.
8926         * python/py-infthread.c: Update.
8927         * python/py-lazy-string.c: Update.
8928         * python/py-linetable.c: Update.
8929         * python/py-objfile.c: Update.
8930         * python/py-param.c: Update.
8931         * python/py-prettyprint.c: Update.
8932         * python/py-progspace.c: Update.
8933         * python/py-record-btrace.c: Update.
8934         * python/py-record.c: Update.
8935         * python/py-symbol.c: Update.
8936         * python/py-type.c: Update.
8937         * python/py-unwind.c: Update.
8938         * python/py-utils.c: Update.
8939         * python/py-value.c: Update.
8940         * python/python.c: Update.
8941         * record-btrace.c: Update.
8942         * record-full.c: Update.
8943         * remote-fileio.c: Update.
8944         * remote.c: Update.
8945         * riscv-tdep.c: Update.
8946         * rs6000-aix-tdep.c: Update.
8947         * rs6000-tdep.c: Update.
8948         * rust-exp.y: Update.
8949         * rust-lang.c: Update.
8950         * s390-tdep.c: Update.
8951         * selftest-arch.c: Update.
8952         * solib-dsbt.c: Update.
8953         * solib-frv.c: Update.
8954         * solib-spu.c: Update.
8955         * solib-svr4.c: Update.
8956         * solib.c: Update.
8957         * sparc64-linux-tdep.c: Update.
8958         * stack.c: Update.
8959         * symfile-mem.c: Update.
8960         * symmisc.c: Update.
8961         * target.c: Update.
8962         * thread.c: Update.
8963         * top.c: Update.
8964         * tracefile-tfile.c: Update.
8965         * tui/tui.c: Update.
8966         * typeprint.c: Update.
8967         * unittests/cli-utils-selftests.c: Update.
8968         * unittests/parse-connection-spec-selftests.c: Update.
8969         * valops.c: Update.
8970         * valprint.c: Update.
8971         * value.c: Update.
8972         * varobj.c: Update.
8973         * windows-nat.c: Update.
8974         * x86-linux-nat.c: Update.
8975         * xml-support.c: Update.
8976
8977 2019-04-08  Tom Tromey  <tom@tromey.com>
8978
8979         * xml-support.c: Use C++ exception handling.
8980         * x86-linux-nat.c: Use C++ exception handling.
8981         * windows-nat.c: Use C++ exception handling.
8982         * varobj.c: Use C++ exception handling.
8983         * value.c: Use C++ exception handling.
8984         * valprint.c: Use C++ exception handling.
8985         * valops.c: Use C++ exception handling.
8986         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8987         handling.
8988         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8989         * typeprint.c: Use C++ exception handling.
8990         * tui/tui.c: Use C++ exception handling.
8991         * tracefile-tfile.c: Use C++ exception handling.
8992         * top.c: Use C++ exception handling.
8993         * thread.c: Use C++ exception handling.
8994         * target.c: Use C++ exception handling.
8995         * symmisc.c: Use C++ exception handling.
8996         * symfile-mem.c: Use C++ exception handling.
8997         * stack.c: Use C++ exception handling.
8998         * sparc64-linux-tdep.c: Use C++ exception handling.
8999         * solib.c: Use C++ exception handling.
9000         * solib-svr4.c: Use C++ exception handling.
9001         * solib-spu.c: Use C++ exception handling.
9002         * solib-frv.c: Use C++ exception handling.
9003         * solib-dsbt.c: Use C++ exception handling.
9004         * selftest-arch.c: Use C++ exception handling.
9005         * s390-tdep.c: Use C++ exception handling.
9006         * rust-lang.c: Use C++ exception handling.
9007         * rust-exp.y: Use C++ exception handling.
9008         * rs6000-tdep.c: Use C++ exception handling.
9009         * rs6000-aix-tdep.c: Use C++ exception handling.
9010         * riscv-tdep.c: Use C++ exception handling.
9011         * remote.c: Use C++ exception handling.
9012         * remote-fileio.c: Use C++ exception handling.
9013         * record-full.c: Use C++ exception handling.
9014         * record-btrace.c: Use C++ exception handling.
9015         * python/python.c: Use C++ exception handling.
9016         * python/py-value.c: Use C++ exception handling.
9017         * python/py-utils.c: Use C++ exception handling.
9018         * python/py-unwind.c: Use C++ exception handling.
9019         * python/py-type.c: Use C++ exception handling.
9020         * python/py-symbol.c: Use C++ exception handling.
9021         * python/py-record.c: Use C++ exception handling.
9022         * python/py-record-btrace.c: Use C++ exception handling.
9023         * python/py-progspace.c: Use C++ exception handling.
9024         * python/py-prettyprint.c: Use C++ exception handling.
9025         * python/py-param.c: Use C++ exception handling.
9026         * python/py-objfile.c: Use C++ exception handling.
9027         * python/py-linetable.c: Use C++ exception handling.
9028         * python/py-lazy-string.c: Use C++ exception handling.
9029         * python/py-infthread.c: Use C++ exception handling.
9030         * python/py-inferior.c: Use C++ exception handling.
9031         * python/py-gdb-readline.c: Use C++ exception handling.
9032         * python/py-framefilter.c: Use C++ exception handling.
9033         * python/py-frame.c: Use C++ exception handling.
9034         * python/py-finishbreakpoint.c: Use C++ exception handling.
9035         * python/py-cmd.c: Use C++ exception handling.
9036         * python/py-breakpoint.c: Use C++ exception handling.
9037         * python/py-arch.c: Use C++ exception handling.
9038         * printcmd.c: Use C++ exception handling.
9039         * ppc-linux-tdep.c: Use C++ exception handling.
9040         * parse.c: Use C++ exception handling.
9041         * p-valprint.c: Use C++ exception handling.
9042         * objc-lang.c: Use C++ exception handling.
9043         * mi/mi-main.c: Use C++ exception handling.
9044         * mi/mi-interp.c: Use C++ exception handling.
9045         * mi/mi-cmd-stack.c: Use C++ exception handling.
9046         * mi/mi-cmd-break.c: Use C++ exception handling.
9047         * main.c: Use C++ exception handling.
9048         * linux-thread-db.c: Use C++ exception handling.
9049         * linux-tdep.c: Use C++ exception handling.
9050         * linux-nat.c: Use C++ exception handling.
9051         * linux-fork.c: Use C++ exception handling.
9052         * linespec.c: Use C++ exception handling.
9053         * language.c: Use C++ exception handling.
9054         * jit.c: Use C++ exception handling.
9055         * infrun.c: Use C++ exception handling.
9056         * infcmd.c: Use C++ exception handling.
9057         * infcall.c: Use C++ exception handling.
9058         * inf-loop.c: Use C++ exception handling.
9059         * i386-tdep.c: Use C++ exception handling.
9060         * i386-linux-tdep.c: Use C++ exception handling.
9061         * guile/scm-value.c: Use C++ exception handling.
9062         * guile/scm-type.c: Use C++ exception handling.
9063         * guile/scm-symtab.c: Use C++ exception handling.
9064         * guile/scm-symbol.c: Use C++ exception handling.
9065         * guile/scm-pretty-print.c: Use C++ exception handling.
9066         * guile/scm-ports.c: Use C++ exception handling.
9067         * guile/scm-param.c: Use C++ exception handling.
9068         * guile/scm-math.c: Use C++ exception handling.
9069         * guile/scm-lazy-string.c: Use C++ exception handling.
9070         * guile/scm-frame.c: Use C++ exception handling.
9071         * guile/scm-disasm.c: Use C++ exception handling.
9072         * guile/scm-cmd.c: Use C++ exception handling.
9073         * guile/scm-breakpoint.c: Use C++ exception handling.
9074         * guile/scm-block.c: Use C++ exception handling.
9075         * guile/guile-internal.h: Use C++ exception handling.
9076         * gnu-v3-abi.c: Use C++ exception handling.
9077         * gdbtypes.c: Use C++ exception handling.
9078         * frame.c: Use C++ exception handling.
9079         * frame-unwind.c: Use C++ exception handling.
9080         * fbsd-tdep.c: Use C++ exception handling.
9081         * f-valprint.c: Use C++ exception handling.
9082         * exec.c: Use C++ exception handling.
9083         * event-top.c: Use C++ exception handling.
9084         * event-loop.c: Use C++ exception handling.
9085         * eval.c: Use C++ exception handling.
9086         * dwarf2read.c: Use C++ exception handling.
9087         * dwarf2loc.c: Use C++ exception handling.
9088         * dwarf2-frame.c: Use C++ exception handling.
9089         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9090         * dwarf-index-write.c: Use C++ exception handling.
9091         * dwarf-index-cache.c: Use C++ exception handling.
9092         * dtrace-probe.c: Use C++ exception handling.
9093         * disasm-selftests.c: Use C++ exception handling.
9094         * darwin-nat.c: Use C++ exception handling.
9095         * cp-valprint.c: Use C++ exception handling.
9096         * cp-support.c: Use C++ exception handling.
9097         * cp-abi.c: Use C++ exception handling.
9098         * corelow.c: Use C++ exception handling.
9099         * completer.c: Use C++ exception handling.
9100         * compile/compile-object-run.c: Use C++ exception handling.
9101         * compile/compile-object-load.c: Use C++ exception handling.
9102         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9103         * compile/compile-c-symbols.c: Use C++ exception handling.
9104         * common/selftest.c: Use C++ exception handling.
9105         * common/new-op.c: Use C++ exception handling.
9106         * cli/cli-script.c: Use C++ exception handling.
9107         * cli/cli-interp.c: Use C++ exception handling.
9108         * cli/cli-cmds.c: Use C++ exception handling.
9109         * c-varobj.c: Use C++ exception handling.
9110         * btrace.c: Use C++ exception handling.
9111         * breakpoint.c: Use C++ exception handling.
9112         * break-catch-throw.c: Use C++ exception handling.
9113         * arch-utils.c: Use C++ exception handling.
9114         * amd64-tdep.c: Use C++ exception handling.
9115         * ada-valprint.c: Use C++ exception handling.
9116         * ada-typeprint.c: Use C++ exception handling.
9117         * ada-lang.c: Use C++ exception handling.
9118         * aarch64-tdep.c: Use C++ exception handling.
9119
9120 2019-04-08  Tom Tromey  <tom@tromey.com>
9121
9122         * xml-support.c (gdb_xml_parser::parse): Update.
9123         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9124         * value.c (show_convenience): Update.
9125         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9126         (test_parse_flags_qcs): Update.
9127         * thread.c (thr_try_catch_cmd): Update.
9128         * target.c (target_translate_tls_address): Update.
9129         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9130         (info_frame_command_core, frame_apply_command_count): Update.
9131         * rust-exp.y (rust_lex_exception_test): Update.
9132         * riscv-tdep.c (riscv_print_one_register_info): Update.
9133         * remote.c (remote_target::enable_btrace): Update.
9134         * record-btrace.c (record_btrace_enable_warn): Update.
9135         * python/py-utils.c (gdbpy_convert_exception): Update.
9136         * printcmd.c (do_one_display, print_variable_and_value): Update.
9137         * mi/mi-main.c (mi_print_exception): Update.
9138         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9139         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9140         * linux-nat.c (linux_nat_target::attach): Update.
9141         * linux-fork.c (class scoped_switch_fork_info): Update.
9142         * infrun.c (displaced_step_prepare): Update.
9143         * infcall.c (call_function_by_hand_dummy): Update.
9144         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9145         * gnu-v3-abi.c (print_one_vtable): Update.
9146         * frame.c (get_prev_frame_always): Update.
9147         * f-valprint.c (info_common_command_for_block): Update.
9148         * exec.c (try_open_exec_file): Update.
9149         * exceptions.c (print_exception, exception_print)
9150         (exception_fprintf, exception_print_same): Update.
9151         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9152         * dwarf-index-cache.c (index_cache::store)
9153         (index_cache::lookup_gdb_index): Update.
9154         * darwin-nat.c (maybe_cache_shell): Update.
9155         * cp-valprint.c (cp_print_value_fields): Update.
9156         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9157         (gcc_cplus_symbol_address): Update.
9158         * compile/compile-c-symbols.c (gcc_convert_symbol)
9159         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9160         * common/selftest.c: Update.
9161         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9162         a std::string.
9163         (exception_try_scope_entry, exception_try_scope_exit): Don't
9164         declare.
9165         (struct exception_try_scope): Remove.
9166         (TRY): Don't use exception_try_scope.
9167         (struct gdb_exception): Add constructor, operator=.
9168         <what>: New method.
9169         (struct gdb_exception_RETURN_MASK_ALL)
9170         (struct gdb_exception_RETURN_MASK_ERROR)
9171         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9172         (struct gdb_quit_bad_alloc): Update.
9173         * common/common-exceptions.c (exception_none): Change
9174         initializer.
9175         (struct catcher) <state, exception>: Initialize inline.
9176         <prev>: Remove member.
9177         (current_catcher): Remove.
9178         (catchers): New global.
9179         (exceptions_state_mc_init): Simplify.
9180         (catcher_pop): Remove.
9181         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9182         (try_scope_depth, exception_try_scope_entry)
9183         (exception_try_scope_exit): Remove.
9184         (throw_exception_sjlj): Update.
9185         (exception_messages, exception_messages_size): Remove.
9186         (throw_it): Simplify.
9187         (gdb_exception_sliced_copy): Remove.
9188         (throw_exception_cxx): Update.
9189         * cli/cli-script.c (script_from_file): Update.
9190         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9191         Update.
9192         * ada-valprint.c (ada_val_print): Update.
9193         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9194         (create_excep_cond_exprs): Update.
9195
9196 2019-04-08  Tom Tromey  <tom@tromey.com>
9197
9198         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9199         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9200         (TRY, CATCH, END_CATCH): Remove some definitions.
9201         * common/common-exceptions.c: Don't use GDB_XCPT.
9202         (catcher_list_size): Remove.
9203         (throw_exception, throw_it): Simplify.
9204
9205 2019-04-05  Tom Tromey  <tom@tromey.com>
9206
9207         Revert the header-sorting patch.
9208         * ft32-tdep.c: Revert.
9209         * frv-tdep.c: Revert.
9210         * frv-linux-tdep.c: Revert.
9211         * frame.c: Revert.
9212         * frame-unwind.c: Revert.
9213         * frame-base.c: Revert.
9214         * fork-child.c: Revert.
9215         * findvar.c: Revert.
9216         * findcmd.c: Revert.
9217         * filesystem.c: Revert.
9218         * filename-seen-cache.h: Revert.
9219         * filename-seen-cache.c: Revert.
9220         * fbsd-tdep.c: Revert.
9221         * fbsd-nat.h: Revert.
9222         * fbsd-nat.c: Revert.
9223         * f-valprint.c: Revert.
9224         * f-typeprint.c: Revert.
9225         * f-lang.c: Revert.
9226         * extension.h: Revert.
9227         * extension.c: Revert.
9228         * extension-priv.h: Revert.
9229         * expprint.c: Revert.
9230         * exec.h: Revert.
9231         * exec.c: Revert.
9232         * exceptions.c: Revert.
9233         * event-top.c: Revert.
9234         * event-loop.c: Revert.
9235         * eval.c: Revert.
9236         * elfread.c: Revert.
9237         * dwarf2read.h: Revert.
9238         * dwarf2read.c: Revert.
9239         * dwarf2loc.c: Revert.
9240         * dwarf2expr.h: Revert.
9241         * dwarf2expr.c: Revert.
9242         * dwarf2-frame.c: Revert.
9243         * dwarf2-frame-tailcall.c: Revert.
9244         * dwarf-index-write.h: Revert.
9245         * dwarf-index-write.c: Revert.
9246         * dwarf-index-common.c: Revert.
9247         * dwarf-index-cache.h: Revert.
9248         * dwarf-index-cache.c: Revert.
9249         * dummy-frame.c: Revert.
9250         * dtrace-probe.c: Revert.
9251         * disasm.h: Revert.
9252         * disasm.c: Revert.
9253         * disasm-selftests.c: Revert.
9254         * dictionary.c: Revert.
9255         * dicos-tdep.c: Revert.
9256         * demangle.c: Revert.
9257         * dcache.h: Revert.
9258         * dcache.c: Revert.
9259         * darwin-nat.h: Revert.
9260         * darwin-nat.c: Revert.
9261         * darwin-nat-info.c: Revert.
9262         * d-valprint.c: Revert.
9263         * d-namespace.c: Revert.
9264         * d-lang.c: Revert.
9265         * ctf.c: Revert.
9266         * csky-tdep.c: Revert.
9267         * csky-linux-tdep.c: Revert.
9268         * cris-tdep.c: Revert.
9269         * cris-linux-tdep.c: Revert.
9270         * cp-valprint.c: Revert.
9271         * cp-support.c: Revert.
9272         * cp-namespace.c: Revert.
9273         * cp-abi.c: Revert.
9274         * corelow.c: Revert.
9275         * corefile.c: Revert.
9276         * continuations.c: Revert.
9277         * completer.h: Revert.
9278         * completer.c: Revert.
9279         * complaints.c: Revert.
9280         * coffread.c: Revert.
9281         * coff-pe-read.c: Revert.
9282         * cli-out.h: Revert.
9283         * cli-out.c: Revert.
9284         * charset.c: Revert.
9285         * c-varobj.c: Revert.
9286         * c-valprint.c: Revert.
9287         * c-typeprint.c: Revert.
9288         * c-lang.c: Revert.
9289         * buildsym.c: Revert.
9290         * buildsym-legacy.c: Revert.
9291         * build-id.h: Revert.
9292         * build-id.c: Revert.
9293         * btrace.c: Revert.
9294         * bsd-uthread.c: Revert.
9295         * breakpoint.h: Revert.
9296         * breakpoint.c: Revert.
9297         * break-catch-throw.c: Revert.
9298         * break-catch-syscall.c: Revert.
9299         * break-catch-sig.c: Revert.
9300         * blockframe.c: Revert.
9301         * block.c: Revert.
9302         * bfin-tdep.c: Revert.
9303         * bfin-linux-tdep.c: Revert.
9304         * bfd-target.c: Revert.
9305         * bcache.c: Revert.
9306         * ax-general.c: Revert.
9307         * ax-gdb.h: Revert.
9308         * ax-gdb.c: Revert.
9309         * avr-tdep.c: Revert.
9310         * auxv.c: Revert.
9311         * auto-load.c: Revert.
9312         * arm-wince-tdep.c: Revert.
9313         * arm-tdep.c: Revert.
9314         * arm-symbian-tdep.c: Revert.
9315         * arm-pikeos-tdep.c: Revert.
9316         * arm-obsd-tdep.c: Revert.
9317         * arm-nbsd-tdep.c: Revert.
9318         * arm-nbsd-nat.c: Revert.
9319         * arm-linux-tdep.c: Revert.
9320         * arm-linux-nat.c: Revert.
9321         * arm-fbsd-tdep.c: Revert.
9322         * arm-fbsd-nat.c: Revert.
9323         * arm-bsd-tdep.c: Revert.
9324         * arch-utils.c: Revert.
9325         * arc-tdep.c: Revert.
9326         * arc-newlib-tdep.c: Revert.
9327         * annotate.h: Revert.
9328         * annotate.c: Revert.
9329         * amd64-windows-tdep.c: Revert.
9330         * amd64-windows-nat.c: Revert.
9331         * amd64-tdep.c: Revert.
9332         * amd64-sol2-tdep.c: Revert.
9333         * amd64-obsd-tdep.c: Revert.
9334         * amd64-obsd-nat.c: Revert.
9335         * amd64-nbsd-tdep.c: Revert.
9336         * amd64-nbsd-nat.c: Revert.
9337         * amd64-nat.c: Revert.
9338         * amd64-linux-tdep.c: Revert.
9339         * amd64-linux-nat.c: Revert.
9340         * amd64-fbsd-tdep.c: Revert.
9341         * amd64-fbsd-nat.c: Revert.
9342         * amd64-dicos-tdep.c: Revert.
9343         * amd64-darwin-tdep.c: Revert.
9344         * amd64-bsd-nat.c: Revert.
9345         * alpha-tdep.c: Revert.
9346         * alpha-obsd-tdep.c: Revert.
9347         * alpha-nbsd-tdep.c: Revert.
9348         * alpha-mdebug-tdep.c: Revert.
9349         * alpha-linux-tdep.c: Revert.
9350         * alpha-linux-nat.c: Revert.
9351         * alpha-bsd-tdep.c: Revert.
9352         * alpha-bsd-nat.c: Revert.
9353         * aix-thread.c: Revert.
9354         * agent.c: Revert.
9355         * addrmap.c: Revert.
9356         * ada-varobj.c: Revert.
9357         * ada-valprint.c: Revert.
9358         * ada-typeprint.c: Revert.
9359         * ada-tasks.c: Revert.
9360         * ada-lang.c: Revert.
9361         * aarch64-tdep.c: Revert.
9362         * aarch64-ravenscar-thread.c: Revert.
9363         * aarch64-newlib-tdep.c: Revert.
9364         * aarch64-linux-tdep.c: Revert.
9365         * aarch64-linux-nat.c: Revert.
9366         * aarch64-fbsd-tdep.c: Revert.
9367         * aarch64-fbsd-nat.c: Revert.
9368         * aarch32-linux-nat.c: Revert.
9369
9370 2019-04-05  Tom Tromey  <tom@tromey.com>
9371
9372         * ft32-tdep.c: Sort headers.
9373         * frv-tdep.c: Sort headers.
9374         * frv-linux-tdep.c: Sort headers.
9375         * frame.c: Sort headers.
9376         * frame-unwind.c: Sort headers.
9377         * frame-base.c: Sort headers.
9378         * fork-child.c: Sort headers.
9379         * findvar.c: Sort headers.
9380         * findcmd.c: Sort headers.
9381         * filesystem.c: Sort headers.
9382         * filename-seen-cache.h: Sort headers.
9383         * filename-seen-cache.c: Sort headers.
9384         * fbsd-tdep.c: Sort headers.
9385         * fbsd-nat.h: Sort headers.
9386         * fbsd-nat.c: Sort headers.
9387         * f-valprint.c: Sort headers.
9388         * f-typeprint.c: Sort headers.
9389         * f-lang.c: Sort headers.
9390         * extension.h: Sort headers.
9391         * extension.c: Sort headers.
9392         * extension-priv.h: Sort headers.
9393         * expprint.c: Sort headers.
9394         * exec.h: Sort headers.
9395         * exec.c: Sort headers.
9396         * exceptions.c: Sort headers.
9397         * event-top.c: Sort headers.
9398         * event-loop.c: Sort headers.
9399         * eval.c: Sort headers.
9400         * elfread.c: Sort headers.
9401         * dwarf2read.h: Sort headers.
9402         * dwarf2read.c: Sort headers.
9403         * dwarf2loc.c: Sort headers.
9404         * dwarf2expr.h: Sort headers.
9405         * dwarf2expr.c: Sort headers.
9406         * dwarf2-frame.c: Sort headers.
9407         * dwarf2-frame-tailcall.c: Sort headers.
9408         * dwarf-index-write.h: Sort headers.
9409         * dwarf-index-write.c: Sort headers.
9410         * dwarf-index-common.c: Sort headers.
9411         * dwarf-index-cache.h: Sort headers.
9412         * dwarf-index-cache.c: Sort headers.
9413         * dummy-frame.c: Sort headers.
9414         * dtrace-probe.c: Sort headers.
9415         * disasm.h: Sort headers.
9416         * disasm.c: Sort headers.
9417         * disasm-selftests.c: Sort headers.
9418         * dictionary.c: Sort headers.
9419         * dicos-tdep.c: Sort headers.
9420         * demangle.c: Sort headers.
9421         * dcache.h: Sort headers.
9422         * dcache.c: Sort headers.
9423         * darwin-nat.h: Sort headers.
9424         * darwin-nat.c: Sort headers.
9425         * darwin-nat-info.c: Sort headers.
9426         * d-valprint.c: Sort headers.
9427         * d-namespace.c: Sort headers.
9428         * d-lang.c: Sort headers.
9429         * ctf.c: Sort headers.
9430         * csky-tdep.c: Sort headers.
9431         * csky-linux-tdep.c: Sort headers.
9432         * cris-tdep.c: Sort headers.
9433         * cris-linux-tdep.c: Sort headers.
9434         * cp-valprint.c: Sort headers.
9435         * cp-support.c: Sort headers.
9436         * cp-namespace.c: Sort headers.
9437         * cp-abi.c: Sort headers.
9438         * corelow.c: Sort headers.
9439         * corefile.c: Sort headers.
9440         * continuations.c: Sort headers.
9441         * completer.h: Sort headers.
9442         * completer.c: Sort headers.
9443         * complaints.c: Sort headers.
9444         * coffread.c: Sort headers.
9445         * coff-pe-read.c: Sort headers.
9446         * cli-out.h: Sort headers.
9447         * cli-out.c: Sort headers.
9448         * charset.c: Sort headers.
9449         * c-varobj.c: Sort headers.
9450         * c-valprint.c: Sort headers.
9451         * c-typeprint.c: Sort headers.
9452         * c-lang.c: Sort headers.
9453         * buildsym.c: Sort headers.
9454         * buildsym-legacy.c: Sort headers.
9455         * build-id.h: Sort headers.
9456         * build-id.c: Sort headers.
9457         * btrace.c: Sort headers.
9458         * bsd-uthread.c: Sort headers.
9459         * breakpoint.h: Sort headers.
9460         * breakpoint.c: Sort headers.
9461         * break-catch-throw.c: Sort headers.
9462         * break-catch-syscall.c: Sort headers.
9463         * break-catch-sig.c: Sort headers.
9464         * blockframe.c: Sort headers.
9465         * block.c: Sort headers.
9466         * bfin-tdep.c: Sort headers.
9467         * bfin-linux-tdep.c: Sort headers.
9468         * bfd-target.c: Sort headers.
9469         * bcache.c: Sort headers.
9470         * ax-general.c: Sort headers.
9471         * ax-gdb.h: Sort headers.
9472         * ax-gdb.c: Sort headers.
9473         * avr-tdep.c: Sort headers.
9474         * auxv.c: Sort headers.
9475         * auto-load.c: Sort headers.
9476         * arm-wince-tdep.c: Sort headers.
9477         * arm-tdep.c: Sort headers.
9478         * arm-symbian-tdep.c: Sort headers.
9479         * arm-pikeos-tdep.c: Sort headers.
9480         * arm-obsd-tdep.c: Sort headers.
9481         * arm-nbsd-tdep.c: Sort headers.
9482         * arm-nbsd-nat.c: Sort headers.
9483         * arm-linux-tdep.c: Sort headers.
9484         * arm-linux-nat.c: Sort headers.
9485         * arm-fbsd-tdep.c: Sort headers.
9486         * arm-fbsd-nat.c: Sort headers.
9487         * arm-bsd-tdep.c: Sort headers.
9488         * arch-utils.c: Sort headers.
9489         * arc-tdep.c: Sort headers.
9490         * arc-newlib-tdep.c: Sort headers.
9491         * annotate.h: Sort headers.
9492         * annotate.c: Sort headers.
9493         * amd64-windows-tdep.c: Sort headers.
9494         * amd64-windows-nat.c: Sort headers.
9495         * amd64-tdep.c: Sort headers.
9496         * amd64-sol2-tdep.c: Sort headers.
9497         * amd64-obsd-tdep.c: Sort headers.
9498         * amd64-obsd-nat.c: Sort headers.
9499         * amd64-nbsd-tdep.c: Sort headers.
9500         * amd64-nbsd-nat.c: Sort headers.
9501         * amd64-nat.c: Sort headers.
9502         * amd64-linux-tdep.c: Sort headers.
9503         * amd64-linux-nat.c: Sort headers.
9504         * amd64-fbsd-tdep.c: Sort headers.
9505         * amd64-fbsd-nat.c: Sort headers.
9506         * amd64-dicos-tdep.c: Sort headers.
9507         * amd64-darwin-tdep.c: Sort headers.
9508         * amd64-bsd-nat.c: Sort headers.
9509         * alpha-tdep.c: Sort headers.
9510         * alpha-obsd-tdep.c: Sort headers.
9511         * alpha-nbsd-tdep.c: Sort headers.
9512         * alpha-mdebug-tdep.c: Sort headers.
9513         * alpha-linux-tdep.c: Sort headers.
9514         * alpha-linux-nat.c: Sort headers.
9515         * alpha-bsd-tdep.c: Sort headers.
9516         * alpha-bsd-nat.c: Sort headers.
9517         * aix-thread.c: Sort headers.
9518         * agent.c: Sort headers.
9519         * addrmap.c: Sort headers.
9520         * ada-varobj.c: Sort headers.
9521         * ada-valprint.c: Sort headers.
9522         * ada-typeprint.c: Sort headers.
9523         * ada-tasks.c: Sort headers.
9524         * ada-lang.c: Sort headers.
9525         * aarch64-tdep.c: Sort headers.
9526         * aarch64-ravenscar-thread.c: Sort headers.
9527         * aarch64-newlib-tdep.c: Sort headers.
9528         * aarch64-linux-tdep.c: Sort headers.
9529         * aarch64-linux-nat.c: Sort headers.
9530         * aarch64-fbsd-tdep.c: Sort headers.
9531         * aarch64-fbsd-nat.c: Sort headers.
9532         * aarch32-linux-nat.c: Sort headers.
9533
9534 2019-04-04  Tom Tromey  <tom@tromey.com>
9535
9536         * varobj.c (varobj_create): Update.
9537         * rust-exp.y (struct rust_parser) <update_innermost_block,
9538         lookup_symbol>: New methods.
9539         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9540         Rename.
9541         (rust_parser::rust_lookup_type)
9542         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9543         * printcmd.c (display_command, do_one_display): Update.
9544         * parser-defs.h (struct parser_state) <parser_state>: Add
9545         "tracker" parameter.
9546         (block_tracker): New member.
9547         (class innermost_block_tracker) <innermost_block_tracker>: Add
9548         "types" parameter.
9549         <reset>: Remove method.
9550         (innermost_block): Don't declare.
9551         (null_post_parser): Update.
9552         * parse.c (innermost_block): Remove global.
9553         (write_dollar_variable): Update.
9554         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9555         Remove "tracker_types" parameter.
9556         (parse_expression): Add "tracker" parameter.
9557         (parse_expression_for_completion): Update.
9558         (null_post_parser): Add "tracker" parameter.
9559         * p-exp.y: Update rules.
9560         * m2-exp.y: Update rules.
9561         * language.h (struct language_defn) <la_post_parser>: Add
9562         "tracker" parameter.
9563         * go-exp.y: Update rules.
9564         * f-exp.y: Update rules.
9565         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9566         parameter.
9567         * d-exp.y: Update rules.
9568         * c-exp.y: Update rules.
9569         * breakpoint.c (set_breakpoint_condition): Create an
9570         innermost_block_tracker.
9571         (watch_command_1): Likewise.
9572         * ada-lang.c (resolve): Add "tracker" parameter.
9573         (resolve_subexp): Likewise.
9574         * ada-exp.y (write_var_from_sym): Update.
9575
9576 2019-04-04  Tom Tromey  <tom@tromey.com>
9577
9578         * type-stack.h: New file.
9579         * type-stack.c: New file.
9580         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9581         type-stack.h.
9582         (insert_into_type_stack, insert_type, push_type, push_type_int)
9583         (insert_type_address_space, pop_type, pop_type_int)
9584         (pop_typelist, pop_type_stack, append_type_stack)
9585         (push_type_stack, get_type_stack, push_typelist)
9586         (follow_type_instance_flags, follow_types): Don't declare.
9587         * parse.c (type_stack): Remove global.
9588         (parse_exp_in_context): Update.
9589         (insert_into_type_stack, insert_type, push_type, push_type_int)
9590         (insert_type_address_space, pop_type, pop_type_int)
9591         (pop_typelist, pop_type_stack, append_type_stack)
9592         (push_type_stack, get_type_stack, push_typelist)
9593         (follow_type_instance_flags, follow_types): Remove (moved to
9594         type-stack.c).
9595         * f-exp.y (type_stack): New global.
9596         Update rules.
9597         (push_kind_type, f_parse): Update.
9598         * d-exp.y (type_stack): New global.
9599         Update rules.
9600         (d_parse): Update.
9601         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9602         Update rules.
9603         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9604         (HFILES_NO_SRCDIR): Add type-stack.h.
9605
9606 2019-04-04  Tom Tromey  <tom@tromey.com>
9607
9608         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9609         (rust_parser::convert_ast_to_expression, rust_parse)
9610         (rust_lex_test_completion, rust_lex_tests): Update.
9611         * parser-defs.h (struct expr_completion_state): New.
9612         (struct parser_state) <parser_state>: Add completion parameter.
9613         <mark_struct_expression, mark_completion_tag>: New methods.
9614         <parse_completion, m_completion_state>: New members.
9615         (prefixify_expression, null_post_parser): Update.
9616         (mark_struct_expression, mark_completion_tag): Don't declare.
9617         * parse.c (parse_completion, expout_last_struct)
9618         (expout_tag_completion_type, expout_completion_name): Remove
9619         globals.
9620         (parser_state::mark_struct_expression)
9621         (parser_state::mark_completion_tag): Now methods.
9622         (prefixify_expression): Add last_struct parameter.
9623         (prefixify_subexp): Likewise.
9624         (parse_exp_1): Update.
9625         (parse_exp_in_context): Add cstate parameter.  Update.
9626         (parse_expression_for_completion): Create an
9627         expr_completion_state.
9628         (null_post_parser): Add "completion" parameter.
9629         * p-exp.y: Update rules.
9630         (yylex): Update.
9631         * language.h (struct language_defn) <la_post_parser>: Add
9632         "completing" parameter.
9633         * go-exp.y: Update rules.
9634         (lex_one_token): Update.
9635         * expression.h (parse_completion): Don't declare.
9636         * d-exp.y: Update rules.
9637         (lex_one_token): Update rules.
9638         * c-exp.y: Update rules.
9639         (lex_one_token): Update.
9640         * ada-lang.c (resolve): Add "parse_completion" parameter.
9641         (resolve_subexp): Likewise.
9642         (ada_resolve_function): Likewise.
9643
9644 2019-04-04  Tom Tromey  <tom@tromey.com>
9645
9646         * parser-defs.h (struct parser_state) <start_arglist,
9647         end_arglist>: New methods.
9648         <arglist_len, m_funcall_chain>: New members.
9649         (arglist_len, start_arglist, end_arglist): Don't declare.
9650         * parse.c (arglist_len, funcall_chain): Remove global.
9651         (start_arglist, end_arglist): Remove functions.
9652         (parse_exp_in_context): Update.
9653         * p-exp.y: Update rules.
9654         * m2-exp.y: Update rules.
9655         * go-exp.y: Update rules.
9656         * f-exp.y: Update rules.
9657         * d-exp.y: Update rules.
9658         * c-exp.y: Update rules.
9659
9660 2019-04-04  Tom Tromey  <tom@tromey.com>
9661
9662         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9663         lex_operator, push_back>: New methods.
9664         Update all rules.
9665         (rust_parser::lex_hex, lex_escape): Rename and update.
9666         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9667         (rust_parser::lex_operator): Rename and update.
9668         (rust_parser::lex_number, rustyylex, rustyyerror)
9669         (rust_lex_test_init, rust_lex_test_sequence)
9670         (rust_lex_test_push_back, rust_lex_tests): Update.
9671         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9672         parameter.
9673         <lexptr, prev_lexptr>: New members.
9674         (lexptr, prev_lexptr): Don't declare.
9675         * parse.c (lexptr, prev_lexptr): Remove globals.
9676         (parse_exp_in_context): Update.
9677         * p-exp.y (yylex, yyerror): Update.
9678         * m2-exp.y (parse_number, yylex, yyerror): Update.
9679         * go-exp.y (lex_one_token, yyerror): Update.
9680         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9681         * d-exp.y (lex_one_token, yyerror): Update.
9682         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9683         (lex_one_token, yyerror): Update.
9684         * ada-lex.l (YY_INPUT): Update.
9685         (rewind_to_char): Update.
9686         * ada-exp.y (yyerror): Update.
9687
9688 2019-04-04  Tom Tromey  <tom@tromey.com>
9689
9690         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9691         * parser-defs.h (struct parser_state) <parser_state>: Add new
9692         parameter.
9693         <comma_terminates>: New member.
9694         (comma_terminates): Don't declare global.
9695         * parse.c (comma_terminates): Remove global.
9696         (parse_exp_in_context): Update.
9697         * p-exp.y (yylex): Update.
9698         * m2-exp.y (yylex): Update.
9699         * go-exp.y (lex_one_token): Update.
9700         * f-exp.y (yylex): Update.
9701         * d-exp.y (lex_one_token): Update.
9702         * c-exp.y (lex_one_token): Update.
9703         * ada-lex.l: Update.
9704
9705 2019-04-04  Tom Tromey  <tom@tromey.com>
9706
9707         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9708         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9709         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9710         * parser-defs.h (paren_depth): Don't declare.
9711         * parse.c (paren_depth): Remove global.
9712         (parse_exp_in_context): Update.
9713         * p-exp.y (paren_depth): New global.
9714         (pascal_parse): Initialize it.
9715         * m2-exp.y (paren_depth): New global.
9716         (m2_parse): Initialize it.
9717         * go-exp.y (paren_depth): New global.
9718         (go_parse): Initialize it.
9719         * f-exp.y (paren_depth): New global.
9720         (f_parse): Initialize it.
9721         * d-exp.y (paren_depth): New global.
9722         (d_parse): Initialize it.
9723         * c-exp.y (paren_depth): New global.
9724         (c_parse): Initialize it.
9725         * ada-lex.l (paren_depth): New global.
9726         (lexer_init): Initialize it.
9727
9728 2019-04-04  Tom Tromey  <tom@tromey.com>
9729
9730         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9731         (rust_parser::convert_ast_to_type)
9732         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9733         * parser-defs.h (struct parser_state) <parser_state>: Add
9734         parameters.  Initialize new members.
9735         <expression_context_block, expression_context_pc>: New members.
9736         * parse.c (expression_context_block, expression_context_pc):
9737         Remove globals.
9738         (parse_exp_in_context): Update.
9739         * p-exp.y: Update all rules.
9740         (yylex): Update.
9741         * m2-exp.y: Update all rules.
9742         (yylex): Update.
9743         * go-exp.y (yylex): Update.
9744         * f-exp.y (yylex): Update.
9745         * d-exp.y: Update all rules.
9746         (yylex): Update.
9747         * c-exp.y: Update all rules.
9748         (lex_one_token, classify_name, yylex, c_parse): Update.
9749         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9750
9751 2019-04-04  Tom Tromey  <tom@tromey.com>
9752
9753         * gdbarch.h, gdbarch.c: Rebuild.
9754         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9755         * stap-probe.h:
9756         (struct stap_parse_info): Replace "parser_state" with
9757         "expr_builder".
9758         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9759         (parser_state): New class.
9760         * parse.c (expr_builder): Rename.
9761         (expr_builder::release): Rename.
9762         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9763         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9764         (write_exp_elt_longcst, write_exp_elt_floatcst)
9765         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9766         (write_exp_string_vector, write_exp_bitstring)
9767         (write_exp_msymbol, mark_struct_expression)
9768         (write_dollar_variable)
9769         (insert_type_address_space, increase_expout_size): Replace
9770         "parser_state" with "expr_builder".
9771         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9772         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9773         "parser_state" with "expr_builder".
9774
9775 2019-04-04  Tom Tromey  <tom@tromey.com>
9776
9777         * rust-exp.y: Replace "parse_language" with method call.
9778         * p-exp.y:
9779         (yylex): Replace "parse_language" with method call.
9780         * m2-exp.y:
9781         (yylex): Replace "parse_language" with method call.
9782         * go-exp.y (classify_name): Replace "parse_language" with method
9783         call.
9784         * f-exp.y (yylex): Replace "parse_language" with method call.
9785         * d-exp.y (lex_one_token): Replace "parse_language" with method
9786         call.
9787         * c-exp.y:
9788         (lex_one_token, classify_name, yylex): Replace "parse_language"
9789         with method call.
9790         * ada-exp.y (find_primitive_type, type_char)
9791         (type_system_address): Replace "parse_language" with method call.
9792
9793 2019-04-04  Tom Tromey  <tom@tromey.com>
9794
9795         * rust-exp.y: Replace "parse_gdbarch" with method call.
9796         * parse.c (write_dollar_variable, insert_type_address_space):
9797         Replace "parse_gdbarch" with method call.
9798         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9799         call.
9800         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9801         call.
9802         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9803         "parse_gdbarch" with method call.
9804         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9805         with method call.
9806         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9807         "parse_gdbarch" with method call.
9808         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9809         "parse_gdbarch" with method call.
9810         * c-exp.y (parse_type, parse_number, classify_name): Replace
9811         "parse_gdbarch" with method call.
9812         * ada-lex.l: Replace "parse_gdbarch" with method call.
9813         * ada-exp.y (parse_type, find_primitive_type, type_char)
9814         (type_system_address): Replace "parse_gdbarch" with method call.
9815
9816 2019-04-04  Tom Tromey  <tom@tromey.com>
9817
9818         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9819         * stap-probe.c (stap_parse_argument): Update.
9820         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9821         initial_size parameter.
9822         * rust-exp.y (rust_lex_tests): Update.
9823         * parse.c (parser_state): Update.
9824         (parse_exp_in_context): Update.
9825         * parser-defs.h (struct parser_state) <parser_state>: Remove
9826         "initial_size" parameter.
9827
9828 2019-04-04  Tom Tromey  <tom@tromey.com>
9829
9830         * parser-defs.h (increase_expout_size): Don't declare.
9831         * parse.c (increase_expout_size): Now static.
9832
9833 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9834
9835         * gnu-nat.c (gnu_nat_target::wait): Fix
9836         target_waitstatus_to_string call.
9837
9838 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9839
9840         * eval.c (evaluate_subexp_standard): Handle internal functions
9841         during Fortran function call handling.
9842
9843 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9844
9845         * NEWS: Mention new internal functions.
9846         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9847         (read_base_type): Use dwarf2_init_complex_target_type.
9848         * value.c (creal_internal_fn): New function.
9849         (cimag_internal_fn): New function.
9850         (_initialize_values): Register new internal functions.
9851
9852 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9853
9854         * infrun.c (stop_all_threads): If debug_infrun, always
9855         trace the wait status after wait_one, using
9856         target_waitstatus_to_string and target_pid_to_str.
9857         (handle_inferior_event): Replace various trace of
9858         wait status kind by a single trace.
9859         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9860         wait status kind image by target_waitstatus_to_string.
9861         * target/waitstatus.c (target_waitstatus_to_string): Fix
9862         obsolete comment.
9863
9864 2019-04-01  Tom Tromey  <tromey@adacore.com>
9865
9866         PR symtab/23331:
9867         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9868
9869 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9870             Pedro Alves  <palves@redhat.com>
9871
9872         * top.c (quit_force): Call 'finalize_values'.
9873         * value.c (finalize_values): New function.
9874         * value.h (finalize_values): Declare.
9875
9876 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9877
9878         * NEWS: Announce $_gdb_major and $_gdb_minor.
9879
9880         * top.c (init_gdb_version_vars): New function.
9881         (gdb_init): Call init_gdb_version_vars.
9882
9883 2019-03-29  Tom Tromey  <tromey@adacore.com>
9884
9885         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9886         help text.  Remove dead code.
9887
9888 2019-03-29  Keith Seitz  <keiths@redhat.com>
9889
9890         From Siddhesh Poyarekar:
9891         * f-lang.h (f77_get_upperbound): Return LONGEST.
9892         (f77_get_lowerbound): Likewise.
9893         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9894         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9895         print them.
9896         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9897         plongest to format print it.
9898         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9899         (f77_get_upperbound): Likewise.
9900         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9901         LOWER_BOUND to LONGEST.
9902         (f77_create_arrayprint_offset_tbl): Likewise.
9903
9904 2019-03-29  Keith Seitz  <keiths@redhat.com>
9905
9906         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9907         %s/pulongest for TYPE_LENGTH instead of %d in format
9908         strings.
9909         * ada-typerint.c (ada_print_type): Likewise.
9910         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9911         * compile/compile-c-support.c (generate_register_struct): Likewise.
9912         * gdbtypes.c (recursive_dump_type): Likewise.
9913         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9914         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9915         instead of %d in format strings.
9916         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9917         to std::min to ULONGEST.
9918         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9919         instead of %d in format strings.
9920         * tracepoint.c (info_scope_command): Likewise.
9921         * typeprint.c (print_offset_data::update)
9922         (print_offset_data::finish): Likewise.
9923         * xtensa-tdep.c (xtensa_store_return_value)
9924         (xtensa_push_dummy_call): Likewise.
9925
9926 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9927
9928         * windows-nat.c (display_selector): Fixed format specifications
9929         for 64-bit Cygwin.
9930
9931 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9932
9933         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9934
9935 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9936
9937         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9938         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9939         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9940         (nios2_linux_init_abi): Install it.
9941
9942 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9943
9944         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9945
9946 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9947
9948         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9949
9950 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9951             Tom Tromey  <tromey@adacore.com>
9952
9953         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9954
9955 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9956
9957         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9958         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9959         method to compute the bounds of range types. Also print "[evaluated]"
9960         if the bounds' values come from a dynamic evaluation.
9961
9962 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9963
9964         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9965         whitespace when pretty printing is on.
9966
9967 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9968
9969         * ppc-linux-nat.c: Add include.
9970
9971 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9972
9973         * NEWS: Mention AArch64 Pointer Authentication.
9974
9975 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9976
9977         * arm-linux-nat.c: Add include.
9978
9979 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9980
9981         * source-cache.c (source_cache::get_source_lines): Re-read
9982         fullname after calling open_source_file.
9983
9984 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9985
9986         * NEWS: Mention TLS support for FreeBSD.
9987
9988 2019-03-25  Tom Tromey  <tromey@adacore.com>
9989
9990         * minsyms.c (BUNCH_SIZE): Update comment.
9991         (~minimal_symbol_reader): Remove old comment.
9992         (compact_minimal_symbols): Update comment.
9993         (minimal_symbol_reader::install): Remove old comment.  Update
9994         other comments.
9995
9996 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9997
9998         * s390-linux-nat.c: Add include.
9999
10000 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10001
10002         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10003         Call linux_get_hwcap.
10004         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10005         Likewise.
10006         (aarch64_linux_get_hwcap): Remove function.
10007         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10008         declaration.
10009         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10010         linux_get_hwcap.
10011         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10012         * linux-tdep.c (linux_get_hwcap): Add function.
10013         (linux_get_hwcap2): Likewise.
10014         * linux-tdep.h (linux_get_hwcap): Add declaration.
10015         (linux_get_hwcap2): Likewise.
10016         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10017         (ppc_linux_get_hwcap2): Likewise.
10018         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10019         linux_get_hwcap.
10020         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10021         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10022         (ppc_linux_nat_target::read_description): Likewise.
10023         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10024         * s390-linux-nat.c: Likewise.
10025         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10026
10027 2019-03-24  Tom Tromey  <tom@tromey.com>
10028
10029         * ada-lang.c (standard_lookup): Simplify initialization.
10030         (ada_lookup_symbol_nonlocal): Simplify return.
10031         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10032         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10033         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10034         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10035         initialization.
10036         * solib.c (solib_global_lookup): Simplify.
10037         * symtab.c (null_block_symbol): Remove.
10038         (symbol_cache_lookup): Simplify returns.
10039         (lookup_language_this): Simplify returns.
10040         (lookup_symbol_aux): Simplify return.
10041         (lookup_local_symbol): Simplify returns.
10042         (lookup_global_symbol_from_objfile): Simplify return.
10043         (lookup_symbol_in_objfile_symtabs)
10044         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10045         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10046         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10047         * cp-namespace.c (cp_lookup_bare_symbol)
10048         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10049         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10050         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10051         (cp_lookup_symbol_via_imports): Simplify initialization.
10052         (find_symbol_in_baseclass): Likewise.
10053         * symtab.h (null_block_symbol): Remove.
10054         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10055         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10056         (d_lookup_symbol_module): Likewise.
10057         (find_symbol_in_baseclass): Simplify initialization.
10058
10059 2019-03-24  Tom Tromey  <tom@tromey.com>
10060
10061         * expression.h: Don't include symtab.h.
10062         (struct block): Forward declare.
10063
10064 2019-03-24  Tom Tromey  <tom@tromey.com>
10065
10066         * c-exp.y (typebase): Remove casts.
10067         * gdbtypes.c (lookup_unsigned_typename, )
10068         (lookup_signed_typename): Remove cast.
10069         * eval.c (parse_to_comma_and_eval): Remove cast.
10070         * parse.c (write_dollar_variable): Remove cast.
10071         * block.h (struct block) <superblock>: Now const.
10072         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10073         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10074         (map_block): Make "block" const.
10075         * symfile.h (struct quick_symbol_functions)
10076         <map_matching_symbols>: Constify block argument to "callback".
10077         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10078         const.
10079         (find_pc_sect_compunit_symtab): Make "b" const.
10080         (find_symbol_at_address): Likewise.
10081         (search_symbols): Likewise.
10082         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10083         (dw2_debug_names_lookup_symbol): Likewise.
10084         (dw2_map_matching_symbols): Update.
10085         * p-valprint.c (pascal_val_print): Remove "block".
10086         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10087         (aux_add_nonlocal_symbols): Make "block" const.
10088         (resolve_subexp): Remove cast.
10089         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10090         const.
10091         (iterate_over_file_blocks): Likewise.
10092         * f-exp.y (%union) <bval>: Remove.
10093         * coffread.c (patch_opaque_types): Make "b" const.
10094         * spu-tdep.c (spu_catch_start): Make "block" const.
10095         * c-valprint.c (print_unpacked_pointer): Remove "block".
10096         * symmisc.c (dump_symtab_1): Make "b" const.
10097         (block_depth): Make "block" const.
10098         * d-exp.y (%union) <bval>: Remove.
10099         * cp-support.h (cp_lookup_rtti_type): Update.
10100         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10101         * psymtab.c (psym_lookup_symbol): Make "block" const.
10102         (maintenance_check_psymtabs): Make "b" const.
10103         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10104         (enumerate_locals, enumerate_args): Update.
10105         * python/py-symtab.c (stpy_global_block): Make "block" const.
10106         (stpy_static_block): Likewise.
10107         * inline-frame.c (block_starting_point_at): Make "new_block"
10108         const.
10109         * block.c (find_block_in_blockvector): Make return type const.
10110         (blockvector_for_pc_sect): Make "b" const.
10111         (find_block_in_blockvector): Make "b" const.
10112
10113 2019-03-23  Tom Tromey  <tom@tromey.com>
10114
10115         * varobj.c (varobj_create): Update.
10116         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10117         * printcmd.c (display_command, do_one_display): Don't reset
10118         innermost_block.
10119         * parser-defs.h (enum innermost_block_tracker_type): Move to
10120         expression.h.
10121         (innermost_block): Update comment.
10122         * parse.c (parse_exp_1): Add tracker_types parameter.
10123         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10124         tracker_types parameter.  Reset innermost_block.
10125         (parse_exp_in_context): Remove.
10126         (parse_expression_for_completion): Update.
10127         * objfiles.c (~objfile): Don't reset expression_context_block or
10128         innermost_block.
10129         * expression.h (enum innermost_block_tracker_type): Move from
10130         parser-defs.h.
10131         (parse_exp_1): Add tracker_types parameter.
10132         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10133         reset innermost_block.
10134
10135 2019-03-23  Tom Tromey  <tom@tromey.com>
10136
10137         * objfiles.h: Include bcache.h.
10138
10139 2019-03-23  Tom Tromey  <tom@tromey.com>
10140
10141         * linespec.c (get_current_search_block): Use
10142         scoped_restore_current_language.
10143         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10144
10145 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10146             Jiong Wang  <jiong.wang@arm.com>
10147
10148         * aarch64-linux-tdep.c
10149         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10150         section.
10151         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10152
10153 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10154             Jiong Wang  <jiong.wang@arm.com>
10155
10156         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10157         instructions.
10158         (aarch64_analyze_prologue_test): Add PACIASP test.
10159         (aarch64_prologue_prev_register): Unmask PC value.
10160
10161 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10162             Jiong Wang  <jiong.wang@arm.com>
10163
10164         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10165         (aarch64_dwarf2_prev_register): Unmask PC value.
10166         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10167         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10168         DW_CFA_AARCH64_negate_ra_state.
10169         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10170
10171 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10172             Jiong Wang  <jiong.wang@arm.com>
10173
10174         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10175         registers.
10176         (aarch64_pseudo_register_name): Likewise.
10177         (aarch64_pseudo_register_type): Likewise.
10178         (aarch64_pseudo_register_reggroup_p): Likewise.
10179         (aarch64_gdbarch_init): Add pauth registers.
10180         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10181         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10182         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10183         (struct gdbarch_tdep): Add regnum for ra_state.
10184
10185 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10186             Jiong Wang  <jiong.wang@arm.com>
10187
10188         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10189
10190 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10191             Jiong Wang  <jiong.wang@arm.com>
10192
10193         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10194         function.
10195         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10196         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10197         (aarch64_gdbarch_init): Add puth registers.
10198         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10199         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10200         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10201
10202 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10203             Jiong Wang  <jiong.wang@arm.com>
10204
10205         * aarch64-linux-nat.c
10206         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10207         * aarch64-linux-tdep.c
10208         (aarch64_linux_core_read_description): Likewise.
10209         (aarch64_linux_get_hwcap): New function.
10210         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10211         (aarch64_linux_get_hwcap): New declaration.
10212
10213 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10214             Jiong Wang  <jiong.wang@arm.com>
10215
10216         * aarch64-linux-nat.c
10217         (aarch64_linux_nat_target::read_description): Add pauth param.
10218         * aarch64-linux-tdep.c
10219         (aarch64_linux_core_read_description): Likewise.
10220         * aarch64-tdep.c (struct target_desc): Add in pauth.
10221         (aarch64_read_description): Add pauth param.
10222         (aarch64_gdbarch_init): Likewise.
10223         * aarch64-tdep.h (aarch64_read_description): Likewise.
10224         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10225         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10226         * features/Makefile: Add new files.
10227         * features/aarch64-pauth.c: New file.
10228         * features/aarch64-pauth.xml: New file.
10229
10230 2019-03-20  Tom Tromey  <tromey@adacore.com>
10231
10232         * infrun.c (handle_inferior_event): Rename from
10233         handle_inferior_event_1.  Create a scoped_value_mark.
10234         (handle_inferior_event): Remove.
10235
10236 2019-03-19  Tom Tromey  <tromey@adacore.com>
10237
10238         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10239         * infrun.h (print_stop_event): Add "displays" parameter.
10240         * infrun.c (print_stop_event): Add "displays" parameter.
10241
10242 2019-03-19  Pedro Alves  <palves@redhat.com>
10243
10244         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10245         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10246         to -1.  Fix TABs vs spaces.
10247         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10248         * tui/tui-out.h (tui_ui_out) Add intro comments.
10249         <m_line, m_start_of_line>: In-class initialize, and add describing
10250         comment.
10251
10252 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10253
10254         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10255         variable names.
10256         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10257
10258 2019-03-18  Pedro Alves  <palves@redhat.com>
10259             Eli Zaretskii <eliz@gnu.org>
10260
10261         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10262         m_line and m_start_of_line.
10263
10264 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10265
10266         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10267         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10268         it returns a newline.  This fixes a regression in TU mode, whereby
10269         the next line is output on the same screen line as the user input.
10270
10271 2019-03-18  Tom Tromey  <tromey@adacore.com>
10272
10273         * minsyms.c (minimal_symbol_reader::install): Remove call to
10274         obstack_blank.
10275
10276 2019-03-18  Pedro Alves  <palves@redhat.com>
10277
10278         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10279         New globals.
10280         (apply_style): New, factored out from ...
10281         (apply_ansi_escape): ... this.  Handle reverse video mode.
10282         (tui_set_reverse_mode): New function.
10283         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10284         * tui/tui-winsource.c (tui_show_source_line): Use
10285         tui_set_reverse_mode instead of setting A_STANDOUT.
10286         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10287         New setter methods.
10288
10289 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10290
10291         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10292         Handle tabs.
10293
10294 2019-03-18  Tom Tromey  <tromey@adacore.com>
10295
10296         * ada-lang.c (empty_array): Add "high" parameter.
10297         (ada_evaluate_subexp): Update.
10298
10299 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10300
10301         * unittests/string_view-selftests.c: Define
10302         _initialize_string_view_selftests unconditionally.
10303
10304 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10305
10306         PR gdb/24350
10307         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10308
10309 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10310
10311         PR gdb/24351
10312         * windows-nat.c (display_selector): Fix format specifiers.
10313
10314 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10315
10316         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10317         tui_refill_source_window instead of tui_refresh_win, to update the
10318         current execution line.  This fixes redisplay of the current line
10319         when stepping through the code with "next" or "step".
10320
10321 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10322
10323         * source-cache.c (source_cache::get_source_lines): Call
10324         find_source_lines to initialize s->nlines.  This fixes vertical
10325         scrolling of TUI source window when the DOWN arrow is pressed.
10326
10327 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10328
10329         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10330         linux-thread-db.c (_initialize_thread_db): Likewise.
10331
10332 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10333
10334         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10335         wclrtoeol in tui_show_source_line".  This reverts changes made in
10336         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10337
10338 2019-03-15  Tom Tromey  <tom@tromey.com>
10339
10340         * symtab.h (struct minimal_symbol): Derive from
10341         general_symbol_info.
10342         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10343         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10344         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10345         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10346         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10347         (MSYMBOL_SEARCH_NAME): Update.
10348         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10349         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10350         * minsyms.c (minimal_symbol_reader::record_full): Update.
10351
10352 2019-03-15  Tom Tromey  <tom@tromey.com>
10353
10354         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10355
10356 2019-03-15  Tom Tromey  <tom@tromey.com>
10357
10358         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10359         unique_xmalloc_ptr.
10360         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10361         Update.
10362         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10363         (build_minimal_symbol_hash_tables)
10364         (minimal_symbol_reader::install): Update.
10365
10366 2019-03-15  Tom Tromey  <tom@tromey.com>
10367
10368         * symtab.c (create_demangled_names_hash): Update.
10369         (symbol_set_names): Update.
10370         * objfiles.h (struct objfile_per_bfd_storage)
10371         <demangled_names_hash>: Now an htab_up.
10372         * objfiles.c (objfile_per_bfd_storage): Simplify.
10373
10374 2019-03-15  Tom Tromey  <tom@tromey.com>
10375
10376         * objfiles.h (struct objfile_per_bfd_storage): Declare
10377         destructor.
10378         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10379         New.
10380         (get_objfile_bfd_data): Use new.  Don't initialize
10381         language_of_main.
10382         (free_objfile_per_bfd_storage): Remove.
10383         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10384
10385 2019-03-15  Tom Tromey  <tom@tromey.com>
10386
10387         * symfile.c (reread_symbols): Update.
10388         * objfiles.c (objfile::objfile): Update.
10389         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10390         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10391         comment.
10392         (minimal_symbol_reader::install): Update.
10393         (terminate_minimal_symbol_table): Remove.
10394         * jit.c (jit_object_close_impl): Update.
10395
10396 2019-03-15  Tom Tromey  <tom@tromey.com>
10397
10398         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10399         initializations.
10400
10401 2019-03-15  Tom Tromey  <tom@tromey.com>
10402
10403         * objfiles.h (struct objfile_per_bfd_storage)
10404         <demangled_hash_languages>: Now a bitset.
10405         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10406         (lookup_minimal_symbol): Update.
10407
10408 2019-03-15  Tom Tromey  <tom@tromey.com>
10409
10410         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10411         Don't return the symbol.
10412         * coffread.c (record_minimal_symbol): Use record_full.
10413
10414 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10415
10416         The MS-Windows port of ncurses fails to switch to a color pair if
10417         one or both of the colors are the implicit default colors.  This
10418         change records the default colors when TUI is initialized, and
10419         then specifies them explicitly when a color pair uses the default
10420         colors.  This allows color styling in TUI mode on MS-Windows.
10421
10422         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10423         ncurses_norm_attr.
10424         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10425         colors in ncurses_norm_attr.
10426         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10427         "none", replace it with the default color recorded in
10428         ncurses_norm_attr.
10429
10430 2019-03-14  Tom Tromey  <tromey@adacore.com>
10431
10432         * source-cache.h (class source_cache) <get_source_lines>: Return
10433         std::string.
10434         * source-cache.c (source_cache::extract_lines): Handle case where
10435         first_pos==npos.  Return std::string.
10436         (source_cache::get_source_lines): Update.
10437
10438 2019-03-14  Tom Tromey  <tromey@adacore.com>
10439
10440         * NEWS: Add item for "style sources" commands.
10441         * source-cache.c (source_cache::get_source_lines): Check
10442         source_styling.
10443         * cli/cli-style.c (source_styling): New global.
10444         (_initialize_cli_style): Add "style sources" commands.
10445         (show_style_sources): New function.
10446         * cli/cli-style.h (source_styling): Declare.
10447
10448 2019-03-14  Pedro Alves  <palves@redhat.com>
10449             Tom Tromey  <tromey@adacore.com>
10450
10451         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10452         * tui/tui-winsource.c (tui_refill_source_window): New function,
10453         from...
10454         (tui_horizontal_source_scroll): ... here.  Move some logic.
10455         * cli/cli-style.c (set_style_enabled): Notify new observable.
10456         * tui/tui-hooks.c (tui_redisplay_source): New function.
10457         (tui_attach_detach_observers): Attach or detach
10458         tui_redisplay_source.
10459         * observable.h (source_styling_changed): New observable.
10460         * observable.c: Define source_styling_changed observable.
10461
10462 2019-03-13  Tom Tromey  <tromey@adacore.com>
10463
10464         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10465         (i386_gnu_nat_target::store_registers): Update.
10466         * target-debug.h (target_debug_print_std_string): New macro.
10467         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10468         * windows-tdep.c (display_one_tib): Update.
10469         * tui/tui-stack.c (tui_make_status_line): Update.
10470         * top.c (print_inferior_quit_action): Update.
10471         * thread.c (thr_try_catch_cmd): Update.
10472         (add_thread_with_info): Update.
10473         (thread_target_id_str): Update.
10474         (thr_try_catch_cmd): Update.
10475         (thread_command): Update.
10476         (thread_find_command): Update.
10477         * record-btrace.c (record_btrace_target::info_record)
10478         (record_btrace_resume_thread, record_btrace_target::resume)
10479         (record_btrace_cancel_resume, record_btrace_step_thread)
10480         (record_btrace_target::wait, record_btrace_target::wait)
10481         (record_btrace_target::wait, record_btrace_target::stop): Update.
10482         * progspace.c (print_program_space): Update.
10483         * process-stratum-target.c
10484         (process_stratum_target::thread_address_space): Update.
10485         * linux-fork.c (linux_fork_mourn_inferior)
10486         (detach_checkpoint_command, info_checkpoints_command)
10487         (linux_fork_context): Update.
10488         (linux_fork_detach): Update.
10489         (class scoped_switch_fork_info): Update.
10490         (delete_checkpoint_command): Update.
10491         * infrun.c (follow_fork_inferior): Update.
10492         (follow_fork_inferior): Update.
10493         (proceed_after_vfork_done): Update.
10494         (handle_vfork_child_exec_or_exit): Update.
10495         (follow_exec): Update.
10496         (displaced_step_prepare_throw): Update.
10497         (displaced_step_restore): Update.
10498         (start_step_over): Update.
10499         (resume_1): Update.
10500         (clear_proceed_status_thread): Update.
10501         (proceed): Update.
10502         (print_target_wait_results): Update.
10503         (do_target_wait): Update.
10504         (context_switch): Update.
10505         (stop_all_threads): Update.
10506         (restart_threads): Update.
10507         (finish_step_over): Update.
10508         (handle_signal_stop): Update.
10509         (switch_back_to_stepped_thread): Update.
10510         (keep_going_pass_signal): Update.
10511         (print_exited_reason): Update.
10512         (normal_stop): Update.
10513         * inferior.c (inferior_pid_to_str): Change return type.
10514         (print_selected_inferior): Update.
10515         (add_inferior): Update.
10516         (detach_inferior): Update.
10517         * dummy-frame.c (fprint_dummy_frames): Update.
10518         * dcache.c (dcache_info_1): Update.
10519         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10520         (btrace_fetch, btrace_clear): Update.
10521         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10522         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10523         type.
10524         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10525         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10526         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10527         * gdbarch.c, gdbarch.h: Rebuild.
10528         * gdbarch.sh (core_pid_to_str): Change return type.
10529         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10530         return type.
10531         (windows_nat_target::pid_to_str): Change return type.
10532         (windows_delete_thread): Update.
10533         (windows_nat_target::attach): Update.
10534         (windows_nat_target::files_info): Update.
10535         * target-delegates.c: Rebuild.
10536         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10537         return type.
10538         (sol_thread_target::pid_to_str): Change return type.
10539         * remote.c (class remote_target) <pid_to_str>: Change return
10540         type.
10541         (remote_target::pid_to_str): Change return type.
10542         (extended_remote_target::attach, remote_target::remote_stop_ns)
10543         (remote_target::remote_notif_remove_queued_reply)
10544         (remote_target::push_stop_reply, remote_target::disable_btrace):
10545         Update.
10546         (extended_remote_target::attach): Update.
10547         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10548         type.
10549         (gdbsim_target::pid_to_str): Change return type.
10550         * ravenscar-thread.c (struct ravenscar_thread_target)
10551         <pid_to_str>: Change return type.
10552         (ravenscar_thread_target::pid_to_str): Change return type.
10553         * procfs.c (class procfs_target) <pid_to_str>: Change return
10554         type.
10555         (procfs_target::pid_to_str): Change return type.
10556         (procfs_target::attach): Update.
10557         (procfs_target::detach): Update.
10558         (procfs_target::fetch_registers): Update.
10559         (procfs_target::store_registers): Update.
10560         (procfs_target::wait): Update.
10561         (procfs_target::files_info): Update.
10562         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10563         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10564         return type.
10565         (nto_procfs_target::pid_to_str): Change return type.
10566         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10567         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10568         return type.
10569         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10570         (exit_lwp): Update.
10571         (attach_proc_task_lwp_callback, get_detach_signal)
10572         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10573         (linux_nat_target::resume, wait_lwp, stop_callback)
10574         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10575         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10576         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10577         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10578         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10579         type.
10580         (inf_ptrace_target::attach): Update.
10581         (inf_ptrace_target::files_info): Update.
10582         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10583         type.
10584         (go32_nat_target::pid_to_str): Change return type.
10585         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10586         (gnu_nat_target::wait): Update.
10587         (gnu_nat_target::wait): Update.
10588         (gnu_nat_target::resume): Update.
10589         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10590         (fbsd_nat_target::wait): Update.
10591         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10592         type.
10593         (darwin_nat_target::attach): Update.
10594         * corelow.c (class core_target) <pid_to_str>: Change return type.
10595         (core_target::pid_to_str): Change return type.
10596         * target.c (normal_pid_to_str): Change return type.
10597         (default_pid_to_str): Likewise.
10598         (target_pid_to_str): Change return type.
10599         (target_translate_tls_address): Update.
10600         (target_announce_detach): Update.
10601         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10602         return type.
10603         (bsd_uthread_target::pid_to_str): Change return type.
10604         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10605         type.
10606         (bsd_kvm_target::pid_to_str): Change return type.
10607         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10608         return type.
10609         (aix_thread_target::pid_to_str): Change return type.
10610         * target.h (struct target_ops) <pid_to_str>: Change return type.
10611         (target_pid_to_str, normal_pid_to_str): Likewise.
10612         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10613         type.
10614         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10615         type.
10616         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10617         return type.
10618         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10619         type.
10620         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10621         type.
10622         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10623         return type.
10624
10625 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10626
10627         * NEWS: Mention that the new default MI version is 3.  Mention
10628         changes to the output of commands and events that deal with
10629         multi-location breakpoints.
10630         * breakpoint.c: Include "mi/mi-out.h".
10631         (print_one_breakpoint): Change output syntax if using MI version
10632         >= 3.
10633         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10634         New.
10635         (mi_multi_location_breakpoint_output_fixed): New.
10636         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10637         (mi_cmd_fix_multi_location_breakpoint_output): New.
10638         (mi_multi_location_breakpoint_output_fixed): New.
10639         * mi/mi-cmds.c (mi_cmds): Register command
10640         -fix-multi-location-breakpoint-output.
10641         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10642         interpreter "mi".
10643
10644 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10645
10646         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10647         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10648         instantiate mi_ui_out based on interpreter name.
10649         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10650         * mi/mi-main.c (mi_load_progress): Likewise.
10651
10652 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10653
10654         * NEWS: Combine separate "New targets" sections for 8.3.
10655
10656 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10657
10658         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10659         (ppcfbsd_init_abi): Install gdbarch
10660         "fetch_tls_load_module_address" and "get_thread_local_address"
10661         methods.
10662
10663 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10664
10665         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10666         (riscv_fbsd_init_abi): Install gdbarch
10667         "fetch_tls_load_module_address" and "get_thread_local_address"
10668         methods.
10669
10670 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10671
10672         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10673         (i386fbsd_init_abi): Install gdbarch
10674         "fetch_tls_load_module_address" and "get_thread_local_address"
10675         methods.
10676
10677 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10678
10679         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10680         (amd64fbsd_init_abi): Install gdbarch
10681         "fetch_tls_load_module_address" and "get_thread_local_address"
10682         methods.
10683
10684 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10685
10686         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10687         (struct fbsd_pspace_data): New type.
10688         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10689         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10690         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10691         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10692         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10693
10694 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10695
10696         * gdbtypes.c (lookup_struct_elt): New function.
10697         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10698         * gdbtypes.h (struct struct_elt): New type.
10699         (lookup_struct_elt): New prototype.
10700
10701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10702
10703         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10704         remove disabled code block.
10705
10706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10707
10708         * gdbarch.sh (get_thread_local_address): New method.
10709         * gdbarch.h, gdbarch.c: Regenerate.
10710         * target.c (target_translate_tls_address): Use
10711         gdbarch_get_thread_local_address if present instead of
10712         target::get_thread_local_address.
10713
10714 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10715
10716         * target.h (target::get_thread_local_address): Update comment.
10717
10718 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10719
10720         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10721         objfile->separate_debug_objfile_backlink if not NULL.
10722
10723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10724
10725         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10726         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10727         (amd64bsd_store_inferior_registers): Likewise.
10728         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10729         Enable segment base registers.
10730         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10731         PT_GETFSBASE and PT_GETGSBASE.
10732         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10733         PT_SETGSBASE.
10734         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10735         segment base registers.
10736         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10737
10738 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10739
10740         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10741         Update calls to i386_target_description to add 'segments'
10742         parameter.
10743         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10744         add segment base registers.
10745         * arch/i386.c (i386_create_target_description): Add 'segments'
10746         parameter to enable segment base registers.
10747         * arch/i386.h (i386_create_target_description): Likewise.
10748         * features/i386/32bit-segments.xml: New file.
10749         * features/i386/32bit-segments.c: Generate.
10750         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10751         call to i386_target_description to add 'segments' parameter.
10752         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10753         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10754         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10755         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10756         if feature is present.
10757         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10758         Add 'segments' parameter to call to i386_target_description.
10759         (i386_target_description): Add 'segments' parameter to enable
10760         segment base registers.
10761         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10762         to call to i386_target_description.
10763         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10764         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10765         Define I386_NUM_REGS.
10766         (i386_target_description): Add 'segments' parameter to enable
10767         segment base registers.
10768
10769 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10770
10771         PR/24325
10772         * source-cache.c: #undef open and close, to avoid unresolved
10773         externals during linking.
10774
10775 2019-03-12  Tom Tromey  <tromey@adacore.com>
10776
10777         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10778         const.  Add initializers.
10779         (_initialize_remote): Don't initialize ptid globals.
10780
10781 2019-03-12  Pedro Alves  <palves@redhat.com>
10782
10783         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10784
10785 2019-03-12  Pedro Alves  <palves@redhat.com>
10786
10787         * cp-name-parser.y (main): Remove unused 'len' variable.
10788
10789 2019-03-12  Tom Tromey  <tromey@adacore.com>
10790
10791         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10792         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10793
10794 2019-03-12  Tom Tromey  <tromey@adacore.com>
10795
10796         * linux-nat.c (iterate_over_lwps): Update.
10797         (stop_callback): Remove parameter.
10798         (stop_wait_callback, detach_callback, resume_set_callback)
10799         (select_singlestep_lwp_callback, set_ignore_sigint)
10800         (status_callback, resumed_callback, resume_clear_callback)
10801         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10802         data parameter.
10803         (linux_nat_target::detach, linux_nat_target::resume)
10804         (linux_stop_and_wait_all_lwps, select_event_lwp)
10805         (linux_nat_filter_event, linux_nat_wait_1)
10806         (linux_nat_target::kill, linux_nat_target::stop)
10807         (linux_nat_target::stop): Update.
10808         (linux_nat_resume_callback): Change type.
10809         (resume_stopped_resumed_lwps, count_events_callback)
10810         (select_event_lwp_callback): Likewise.
10811         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10812         * arm-linux-nat.c (struct update_registers_data): Remove.
10813         (update_registers_callback): Change type.
10814         (arm_linux_insert_hw_breakpoint1): Update.
10815         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10816         parameter.
10817         (x86_linux_dr_set_addr): Update.
10818         (x86_linux_dr_set_control): Update.
10819         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10820         (iterate_over_lwps): Use gdb::function_view.
10821         * nat/aarch64-linux-hw-point.c (struct
10822         aarch64_dr_update_callback_param): Remove.
10823         (debug_reg_change_callback): Change type.
10824         (aarch64_notify_debug_reg_change): Update.
10825         * s390-linux-nat.c (s390_refresh_per_info): Update.
10826
10827 2019-03-11  Tom Tromey  <tromey@adacore.com>
10828
10829         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10830         redundant assignment to "this_cu".
10831
10832 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10833
10834         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10835
10836 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10837
10838         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10839         from...
10840         (rank_one_type): ... this.
10841
10842 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10843
10844         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10845         from...
10846         (rank_one_type): ... this.
10847
10848 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10849
10850         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10851         from...
10852         (rank_one_type): ... this.
10853
10854 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10855
10856         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10857         from...
10858         (rank_one_type): ... this.
10859
10860 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10861
10862         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10863         from...
10864         (rank_one_type): ... this.
10865
10866 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10867
10868         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10869         from...
10870         (rank_one_type): ... this.
10871
10872 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10873
10874         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10875         from...
10876         (rank_one_type): ... this.
10877
10878 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10879
10880         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10881         from...
10882         (rank_one_type): ... this.
10883
10884 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10885
10886         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10887         from...
10888         (rank_one_type): ... this.
10889
10890 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10891
10892         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10893         from...
10894         (rank_one_type): ... this.
10895
10896 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10897
10898         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10899         from...
10900         (rank_one_type): ... this.
10901
10902 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10903
10904         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10905         from...
10906         (rank_one_type): ... this.
10907
10908 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10909
10910         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10911         inferior-events' shows the example events.
10912
10913 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10914
10915         Support styling on native MS-Windows console
10916
10917         PR/24315
10918         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10919         on MS-Windows if $TERM is not defined.
10920
10921         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10922
10923         * posix-hdep.c (gdb_console_fputs):
10924         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10925         functions.
10926         * ui-file.h (gdb_console_fputs): Add prototype.
10927
10928         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10929         back to fputs only if the former returns zero.
10930
10931 2019-03-07  Tom Tromey  <tom@tromey.com>
10932
10933         * symmisc.c (print_symbol_bcache_statistics): Update.
10934         (print_objfile_statistics): Update.
10935         * symfile.c (allocate_symtab): Update.
10936         * stabsread.c: Don't include bcache.h.
10937         * psymtab.h (struct psymbol_bcache): Don't declare.
10938         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10939         (psymbol_bcache_init, psymbol_bcache_free)
10940         (psymbol_bcache_get_bcache): Don't declare.
10941         * psymtab.c (struct psymbol_bcache): Remove.
10942         (psymtab_storage::psymtab_storage): Update.
10943         (psymtab_storage::~psymtab_storage): Update.
10944         (psymbol_bcache_init, psymbol_bcache_free)
10945         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10946         (add_psymbol_to_bcache): Update.
10947         (allocate_psymtab): Update.
10948         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10949         macro_cache>: No longer pointers.
10950         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10951         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10952         * macrotab.c (macro_bcache): Update.
10953         * macroexp.c: Don't include bcache.h.
10954         * gdbtypes.c (check_types_worklist): Update.
10955         (types_deeply_equal): Remove TRY/CATCH.  Update.
10956         * elfread.c (elf_symtab_read): Update.
10957         * dwarf2read.c: Don't include bcache.h.
10958         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10959         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10960         (print_bcache_statistics, bcache_memory_used): Don't declare.
10961         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10962         methods.  Rename all data members.
10963         * bcache.c (struct bcache): Move to bcache.h.
10964         (bcache::expand_hash_table): Rename from expand_hash_table.
10965         (bcache): Remove.
10966         (bcache::insert): Rename from bcache_full.
10967         (bcache::compare): Rename from bcache_compare.
10968         (bcache_xmalloc): Remove.
10969         (bcache::~bcache): Rename from bcache_xfree.
10970         (bcache::print_statistics): Rename from print_bcache_statistics.
10971         (bcache::memory_used): Rename from bcache_memory_used.
10972
10973 2019-03-07  Pedro Alves  <palves@redhat.com>
10974
10975         * infrun.c (normal_stop): Also check for
10976         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10977
10978 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10979
10980         * f-lang.c (value_from_host_double): Moved to...
10981         * value.c (value_from_host_double): ...here.
10982         * value.h (value_from_host_double): Declare.
10983         * guile/scm-math.c (vlscm_convert_typed_number): Use
10984         value_from_host_double.
10985         (vlscm_convert_number): Likewise.
10986         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10987         * python/py-value.c (convert_value_from_python): Likewise.
10988
10989 2019-03-06  Tom Tromey  <tom@tromey.com>
10990
10991         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10992
10993 2019-03-06  Tom Tromey  <tom@tromey.com>
10994
10995         * utils.h (free_current_contents): Don't declare.
10996         * utils.c (free_current_contents): Remove.
10997
10998 2019-03-06  Tom Tromey  <tom@tromey.com>
10999
11000         * top.c (quit_force): Update.
11001         * main.c (captured_command_loop): Update.
11002         * common/new-op.c (operator new): Update.
11003         * common/common-exceptions.c (struct catcher)
11004         <save_cleanup_chain>: Remove member.
11005         (exceptions_state_mc_init): Update.
11006         (exception_try_scope_entry): Return nullptr.
11007         (exception_try_scope_exit, exception_rethrow)
11008         (throw_exception_sjlj, throw_exception_cxx): Update.
11009         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11010         (all_cleanups, do_cleanups, discard_cleanups)
11011         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11012         (restore_cleanups, restore_final_cleanups): Don't declare.
11013         (do_final_cleanups): Remove parameter.
11014         * common/cleanups.c (cleanup_chain, make_cleanup)
11015         (make_cleanup_dtor, all_cleanups, do_cleanups)
11016         (discard_my_cleanups, discard_cleanups)
11017         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11018         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11019         (null_cleanup): Remove.
11020         (do_final_cleanups): Remove parameter.
11021
11022 2019-03-06  Tom Tromey  <tom@tromey.com>
11023
11024         * remote.c (remote_target::remote_parse_stop_reply): Use
11025         unique_xmalloc_ptr.
11026
11027 2019-03-06  Tom Tromey  <tom@tromey.com>
11028
11029         * stabsread.c (struct stabs_field_info): Rename from field_info.
11030         <list, fnlist>: Add initializers.
11031         <obstack>: New member.
11032         (read_member_functions, read_struct_fields, read_baseclasses):
11033         Allocate on obstack.  Don't use cleanups.
11034         (read_one_struct_field, read_member_functions, read_struct_fields)
11035         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11036         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11037         (read_struct_type): Update.
11038
11039 2019-03-06  Tom Tromey  <tom@tromey.com>
11040
11041         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11042         * common/filestuff.h (make_cleanup_close): Don't declare.
11043         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11044         Remove.
11045
11046 2019-03-06  Tom Tromey  <tom@tromey.com>
11047
11048         * solib-aix.c: Use make_scope_exit.
11049
11050 2019-03-06  Tom Tromey  <tom@tromey.com>
11051
11052         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11053         Use make_scope_exit.
11054
11055 2019-03-06  Tom Tromey  <tom@tromey.com>
11056
11057         * solib-svr4.c (disable_probes_interface): Remove parameter.
11058         (svr4_handle_solib_event): Use make_scope_exit.
11059
11060 2019-03-06  Tom Tromey  <tom@tromey.com>
11061
11062         * remote.c (struct stop_reply_deleter): Remove.
11063         (stop_reply_up): Update.
11064         (struct stop_reply): Derive from notif_event.  Don't typedef.
11065         <regcache>: Now a std::vector.
11066         (stop_reply_xfree): Remove.
11067         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11068         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11069         (remote_target::discard_pending_stop_replies): Use delete.
11070         (remote_target::remote_parse_stop_reply): Update.
11071         (remote_target::process_stop_reply): Update.
11072         * remote-notif.h (struct notif_event): Add virtual destructor.
11073         Remove "dtr" member.
11074         (struct notif_client) <alloc_event>: Return a unique_ptr.
11075         (notif_event_xfree): Don't declare.
11076         (notif_event_up): New typedef.
11077         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11078         (notif_event_xfree, do_notif_event_xfree): Remove.
11079         (remote_notif_state_xfree): Update.
11080
11081 2019-03-06  Tom Tromey  <tom@tromey.com>
11082
11083         * infrun.c (displaced_step_clear_cleanup): Now a
11084         forward_scope_exit type.
11085         (displaced_step_prepare_throw): Update.
11086         (displaced_step_fixup): Update.
11087
11088 2019-03-06  Tom Tromey  <tom@tromey.com>
11089
11090         * inferior.h (class inferior): Update comment.
11091         * gdbthread.h (class thread_info): Update comment.
11092
11093 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11094             Tom Tromey  <tom@tromey.com>
11095
11096         * stabsread.h (struct stab_section_list): Remove.
11097         (coffstab_build_psymtabs): Update.
11098         * dbxread.c (symbuf_sections): Now a std::vector.
11099         (sect_idx): New global.
11100         (fill_symbuf): Update.
11101         (coffstab_build_psymtabs): Change type of stabsects parameter.
11102         Update.
11103         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11104         std::vector.
11105         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11106         (coff_locate_sections): Update.
11107         (coff_symfile_read): Remove cleanups.  Update.
11108         (init_stringtab): Add storage parameter.
11109         (free_stringtab, free_stringtab_cleanup): Remove.
11110         (init_lineno): Add storage parameter.
11111         (free_linetab, free_linetab_cleanup): Remove.
11112
11113 2019-03-06  Pedro Alves  <palves@redhat.com>
11114
11115         * linux-fork.c (fork_info::clobber_regs): Delete.
11116         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11117         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11118         comment.  Adjust.
11119         (scoped_switch_fork_info::scoped_switch_fork_info)
11120         (checkpoint_command, linux_fork_context): Adjust
11121         fork_save_infrun_state calls.
11122
11123 2019-03-06  Pedro Alves  <palves@redhat.com>
11124
11125         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11126         (inf_has_multiple_threads): Return 'bool' and rewrite using
11127         inferior_info::threads().
11128
11129 2019-03-06  Pedro Alves  <palves@redhat.com>
11130
11131         * linux-fork.c: Include <list>.
11132         (fork_list): Now a std::list instance.
11133         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11134         (forks_exist_p, find_last_fork): Adjust.
11135         (new_fork): Delete.
11136         (one_fork_p): New.
11137         (add_fork): Adjust.
11138         (free_fork): Delete, folded into fork_info::~fork_info().
11139         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11140         Adjust.
11141         (init_fork_list): Delete.
11142         (linux_fork_killall, linux_fork_mourn_inferior)
11143         (linux_fork_detach, info_checkpoints_command): Adjust.
11144         (_initialize_linux_fork): No longer call init_fork_list.
11145
11146 2019-03-06  Pedro Alves  <palves@redhat.com>
11147
11148         * linux-fork.c (new_fork): New, split out of ...
11149         (add_fork): ... this.  Return void.  Move "first fork" special
11150         case from here, to ...
11151         (checkpoint_command): ... here.
11152         * linux-linux.h (add_fork): Return void.
11153
11154 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11155
11156         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11157
11158 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11159             Chris January  <chris.january@arm.com>
11160             David Lecomber  <david.lecomber@arm.com>
11161
11162         * f-exp.y: New token, UNOP_INTRINSIC.
11163         (exp): New pattern using UNOP_INTRINSIC token.
11164         (f77_keywords): Add 'abs' keyword.
11165         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11166         (value_from_host_double): New function.
11167         (evaluate_subexp_f): Support UNOP_ABS.
11168
11169 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11170
11171         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11172         types.
11173
11174 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11175
11176         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11177         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11178         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11179
11180 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11181
11182         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11183
11184 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11185             Chris January  <chris.january@arm.com>
11186
11187         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11188         * f-exp.y: Define 'KIND' token.
11189         (exp): New pattern for KIND expressions.
11190         (ptype): Handle types with a kind extension.
11191         (direct_abs_decl): Extend to spot kind extensions.
11192         (f77_keywords): Add 'kind' to the list.
11193         (push_kind_type): New function.
11194         (convert_to_kind_type): New function.
11195         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11196         * parse.c (operator_length_standard): Likewise.
11197         * parser-defs.h (enum type_pieces): Add tp_kind.
11198         * std-operator.def: Add UNOP_KIND.
11199
11200 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11201
11202         * f-exp.y (f_parse): Set yydebug.
11203
11204 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11205
11206         * f-lang.c (evaluate_subexp_f): New function.
11207         (exp_descriptor_f): New global.
11208         (f_language_defn): Use exp_descriptor_f instead of
11209         exp_descriptor_standard.
11210
11211 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11212
11213         * f-exp.y (struct token): Add comments.
11214         (dot_ops): Remove uppercase versions and the end marker.
11215         (f77_keywords): Likewise.
11216         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11217         entries in the dot_ops array are case insensitive, and use
11218         strncasecmp to compare strings.  Also some whitespace cleanup in
11219         this area.  Similar for the f77_keywords array, except entries in
11220         this list might be case sensitive.
11221
11222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11223
11224         * f-exp.y (struct f77_boolean_val): Add comments.
11225         (boolean_values): Remove uppercase versions, and end marker.
11226         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11227         and use strncasecmp to achieve case insensitivity.  Additionally,
11228         perform whitespace cleanup around this code.
11229
11230 2019-03-06  Tom Tromey  <tromey@adacore.com>
11231
11232         * remote-sim.c (gdbsim_target_open): Use result of
11233         gdb_argv::release.
11234
11235 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11236         Dirk Schubert  <dirk.schubert@arm.com>
11237         Chris January  <chris.january@arm.com>
11238
11239         * eval.c (evaluate_subexp_standard): Call Fortran argument
11240         wrapping logic.
11241         * f-lang.c (struct value): A value which can be passed into a
11242         Fortran function call.
11243         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11244         where appropriate.
11245         (struct type): Value ready for a Fortran function call.
11246         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11247         is needed.
11248         * f-lang.h (fortran_argument_convert): Declaration.
11249         (fortran_preserve_arg_pointer): Declaration.
11250         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11251
11252 2019-03-05  Tom Tromey  <tromey@adacore.com>
11253
11254         * python/py-prettyprint.c (print_string_repr): Remove #if.
11255         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11256
11257 2019-03-05  Tom Tromey  <tromey@adacore.com>
11258
11259         * target.c (the_dummy_target): Move later.  Change type to
11260         "dummy_target".
11261         (initialize_targets): Don't initialize the_dummy_target.
11262
11263 2019-03-05  Tom Tromey  <tromey@adacore.com>
11264
11265         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11266         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11267
11268 2019-03-05  Tom Tromey  <tromey@adacore.com>
11269
11270         * windows-nat.c (windows_nat_target::attach)
11271         (windows_nat_target::detach): Don't call gdb_flush.
11272         * valprint.c (generic_val_print, val_print, val_print_string):
11273         Don't call gdb_flush.
11274         * utils.c (defaulted_query): Don't call gdb_flush.
11275         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11276         * target.c (target_announce_detach): Don't call gdb_flush.
11277         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11278         * remote.c (extended_remote_target::attach): Don't call
11279         gdb_flush.
11280         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11281         * printcmd.c (do_examine): Don't call gdb_flush.
11282         (info_display_command): Don't call gdb_flush.
11283         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11284         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11285         * memattr.c (info_mem_command): Don't call gdb_flush.
11286         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11287         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11288         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11289         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11290         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11291         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11292         (gnu_nat_target::detach): Don't call gdb_flush.
11293         * f-valprint.c (f_val_print): Don't call gdb_flush.
11294         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11295         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11296         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11297         gdb_flush.
11298         * c-valprint.c (c_val_print): Don't call gdb_flush.
11299         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11300
11301 2019-03-05  Tom Tromey  <tromey@adacore.com>
11302
11303         * varobj.c (update_dynamic_varobj_children): Update.
11304         (install_default_visualizer): Use reset, not release.
11305         * value.c (set_internalvar): Update.
11306         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11307         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11308         ATTRIBUTE_UNUSED_RESULT.
11309
11310 2019-03-05  Tom Tromey  <tromey@adacore.com>
11311
11312         * remote.c (class scoped_remote_fd) <release>: Add
11313         ATTRIBUTE_UNUSED_RESULT.
11314
11315 2019-03-05  Tom Tromey  <tromey@adacore.com>
11316
11317         * macroexp.c (struct macro_buffer) <release>: Add
11318         ATTRIBUTE_UNUSED_RESULT.
11319
11320 2019-03-05  Tom Tromey  <tromey@adacore.com>
11321
11322         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11323         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11324         ATTRIBUTE_UNUSED_RESULT.
11325
11326 2019-03-05  Tom Tromey  <tromey@adacore.com>
11327
11328         * common/scoped_fd.h (class scoped_fd) <release>: Add
11329         ATTRIBUTE_UNUSED_RESULT.
11330
11331 2019-03-05  Tom Tromey  <tromey@adacore.com>
11332
11333         * parser-defs.h (struct parser_state) <release>: Add
11334         ATTRIBUTE_UNUSED_RESULT.
11335
11336 2019-03-05  Tom Tromey  <tromey@adacore.com>
11337
11338         * utils.h (class gdb_argv) <release>: Add
11339         ATTRIBUTE_UNUSED_RESULT.
11340         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11341
11342 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11343
11344         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11345         for-loop range, to avoid compiler warnings.
11346
11347         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11348         avoid compiler warnings about unused variables.
11349
11350         * NEWS: Mention end of support for native debugging on MS-Windows
11351         before XP.
11352
11353         PR gdb/24292
11354         * common/netstuff.c:
11355         * gdbserver/gdbreplay.c
11356         * gdbserver/remote-utils.c:
11357         * ser-tcp.c:
11358         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11359         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11360         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11361         'getaddrinfo' and 'freeaddrinfo' were not available before
11362         Windows XP, and mingw.org's MinGW headers by default define
11363         _WIN32_WINNT to 0x500.
11364
11365 2019-03-01  Gary Benson <gbenson@redhat.com>
11366
11367         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11368
11369 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11370             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11371
11372         PR gdb/8527
11373         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11374         set_sigint_trap, clear_sigint_trap.
11375
11376 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11377
11378         * target.c (target_detach): Clear the regcache and the
11379         frame cache.
11380
11381 2019-02-27  Pedro Alves  <palves@redhat.com>
11382
11383         * utils.c (set_screen_size): When we cap the height/width sizes,
11384         tweak the corresponding command variable to show "unlimited":
11385
11386 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11387             Pedro Alves  <palves@redhat.com>
11388
11389         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11390         before calling rl_set_screen_size.
11391
11392 2019-02-27  Tom Tromey  <tromey@adacore.com>
11393
11394         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11395         define.
11396         * python/py-value.c: Remove Python 2.4 workaround.
11397         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11398         workaround.
11399         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11400         Python 2.4 workaround.
11401         * python/python-internal.h: Remove Python 2.4 comment.
11402         (Py_ssize_t): Don't define.
11403         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11404         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11405         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11406         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11407         * python/python.c (do_start_initialization): Remove Python 2.4
11408         workaround.
11409         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11410         (print_children): Remove Python 2.4 workaround.
11411         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11412         workaround.
11413         (CHARBUFFERPROC_NAME): Remove.
11414         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11415         Python 2.4 workaround.
11416
11417 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11418
11419         * NEWS: Note minimum Python version.
11420
11421 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11422
11423         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11424         code from these functions.  Remove corresponding ifdefs.  Use
11425         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11426         Remove gotos and target of gotos.
11427         (infpy_search_memory): Likewise.
11428
11429 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11430
11431         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11432         (hppa_gdbarch_init): Don't register deleted functions with
11433         gdbarch.
11434
11435 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11436
11437         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11438         (h8300_unwind_sp): Delete.
11439         (h8300_dummy_id): Delete.
11440         (h8300_gdbarch_init): Don't register deleted functions with
11441         gdbarch.
11442
11443 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11444
11445         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11446         (ft32_unwind_pc): Delete.
11447         (ft32_unwind_sp): Delete.
11448         (ft32_gdbarch_init): Don't register deleted functions with
11449         gdbarch.
11450
11451 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11452
11453         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11454         (frv_unwind_pc): Delete.
11455         (frv_unwind_sp): Delete.
11456         (frv_gdbarch_init): Don't register deleted functions with
11457         gdbarch.
11458
11459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11460
11461         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11462         (riscv_unwind_pc): Delete.
11463         (riscv_unwind_sp): Delete.
11464         (riscv_gdbarch_init): Don't register deleted functions with
11465         gdbarch.
11466
11467 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11468
11469         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11470         (csky_unwind_pc): Delete.
11471         (csky_unwind_sp): Delete.
11472         (csky_gdbarch_init): Don't register deleted functions with
11473         gdbarch.
11474
11475 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11476
11477         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11478         (cris_unwind_pc): Delete.
11479         (cris_unwind_sp): Delete.
11480         (cris_gdbarch_init): Don't register deleted functions with
11481         gdbarch.
11482
11483 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11484
11485         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11486         (bfin_unwind_pc): Delete.
11487         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11488
11489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11490
11491         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11492         (arm_unwind_pc): Delete.
11493         (arm_unwind_sp): Delete.
11494         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11495
11496 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11497
11498         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11499         (arc_unwind_pc): Delete.
11500         (arc_unwind_sp): Delete.
11501         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11502
11503 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11504
11505         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11506         (alpha_unwind_pc): Delete.
11507         (alpha_gdbarch_init): Don't register deleted functions with
11508         gdbarch.
11509
11510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11511
11512         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11513         (aarch64_unwind_pc): Delete.
11514         (aarch64_unwind_sp): Delete.
11515         (aarch64_gdbarch_init): Don't register deleted functions with
11516         gdbarch.
11517
11518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11519
11520         * gdbtypes.c (type_align): Don't consider static members when
11521         computing structure alignment.
11522
11523 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11524
11525         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11526         return 0 for other types.
11527         * arch-utils.c (default_type_align): Always return 0.
11528         * gdbarch.h: Regenerate.
11529         * gdbarch.sh (type_align): Extend comment.
11530         * gdbtypes.c (type_align): Add additional comments, always call
11531         gdbarch_type_align before applying the default rules.
11532         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11533         generic code will then apply a suitable default.
11534         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11535         types, return 0 for other types.
11536
11537 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11538
11539         * NEWS: Create a new section for the next release branch.
11540         Rename the section of the current branch, now that it has
11541         been cut.
11542
11543 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11544
11545         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11546         * version.in: Bump version to 8.3.50.DATE-git.
11547
11548 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11549
11550         * aix-thread.c (ptid_cmp): Remove unused variable.
11551         (get_signaled_thread): Likewise.
11552         (store_regs_user_thread): Likewise.
11553         (store_regs_kernel_thread): Likewise.
11554         (fetch_regs_kernel_thread): Remove shadowed variable.
11555
11556 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11557
11558         * features/riscv/32bit-cpu.xml: Add register numbers.
11559         * features/riscv/32bit-fpu.c: Regenerate.
11560         * features/riscv/32bit-fpu.xml: Add register numbers.
11561         * features/riscv/64bit-cpu.xml: Add register numbers.
11562         * features/riscv/64bit-fpu.c: Regenerate.
11563         * features/riscv/64bit-fpu.xml: Add register numbers.
11564
11565 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11566
11567         * NEWS: Mention two argument form of gdb.Value constructor.
11568         * python/py-value.c (convert_buffer_and_type_to_value): New
11569         function.
11570         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11571         Add support for handling an optional second argument.  Call
11572         convert_buffer_and_type_to_value as appropriate.
11573         * python/python-internal.h (Py_buffer_deleter): New struct.
11574         (Py_buffer_up): New typedef.
11575
11576 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11577
11578         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11579         instead of releasing ownership.
11580
11581 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11582
11583         * dwarf2read.c (open_and_init_dwp_file): Call
11584         elf_numsections instead of bfd_count_sections to initialize
11585         dwp_file->num_sections.
11586
11587 2019-02-25  Tom Tromey  <tromey@adacore.com>
11588
11589         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11590
11591 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11592
11593         * gcore.in: Add '--readnever' option when invoking GDB.
11594
11595 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11596
11597         * MAINTAINERS: Update my email address.
11598
11599 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11600
11601         * build-id.c (build_id_to_debug_bfd_1): New function.
11602         (build_id_to_debug_bfd): Look for separate debug file in
11603         sysroot.
11604
11605 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11606
11607         * gdbarch.sh: Update the copyright year range that is placed into
11608         generated files.
11609
11610 2019-02-22  Keith Seitz  <keiths@redhat.com>
11611
11612         PR symtab/23853
11613         * linespec.c (create_sals_line_offset): Search for the default
11614         symtab's filename instead of its fullname.
11615
11616 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11617
11618         * NEWS: Update style defaults.
11619
11620 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11621
11622         * main.c (captured_main_1): Disable styling in batch mode.
11623
11624 2019-02-20  Tom Tromey  <tom@tromey.com>
11625
11626         * symtab.c (symtab_symbol_info): Fix typos.
11627
11628 2019-02-20  Tom Tromey  <tromey@adacore.com>
11629
11630         * findcmd.c (_initialize_mem_search): Use upper case for
11631         metasyntactic variables.
11632
11633 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11634
11635         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11636         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11637
11638 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11639
11640         * top.h (source_file_name): Change to std::string.
11641         * top.c (source_file_name): Likewise.
11642         (command_line_input): Adjust.
11643         * cli/cli-script.c (script_from_file): Adjust.
11644
11645 2019-02-19  Tom Tromey  <tromey@adacore.com>
11646
11647         * ravenscar-thread.c
11648         (ravenscar_thread_target::update_thread_list): Don't call
11649         ada_build_task_list.
11650         * ada-lang.h (ada_build_task_list): Don't declare.
11651         * ada-tasks.c (struct ada_tasks_inferior_data)
11652         <task_list_valid_p>: Now bool.
11653         (read_known_tasks, ada_task_list_changed)
11654         (ada_tasks_invalidate_inferior_data): Update.
11655         (read_known_tasks_array): Return bool.
11656         (read_known_tasks_list): Likewise.
11657         (read_known_tasks): Return void.
11658         (ada_build_task_list): Now static.
11659
11660 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11661
11662         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11663         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11664
11665 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11666
11667         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11668         variant for ada_tasks_pspace_data_handle and
11669         ada_tasks_inferior_data_handle.
11670         (ada_tasks_pspace_data_cleanup): New function.
11671         (ada_tasks_inferior_data_cleanup): New function.
11672
11673 2019-02-17  Tom Tromey  <tom@tromey.com>
11674
11675         * macrotab.h (macro_source_fullname): Return a std::string.
11676         * macrotab.c (macro_include, check_for_redefinition)
11677         (macro_undef, macro_lookup_definition, foreach_macro)
11678         (foreach_macro_in_scope): Update.
11679         (macro_source_fullname): Return a std::string.
11680         * macrocmd.c (show_pp_source_pos): Update.
11681
11682 2019-02-17  Tom Tromey  <tom@tromey.com>
11683
11684         * macrocmd.c (show_pp_source_pos): Style the file names.
11685
11686 2019-02-17  Tom Tromey  <tom@tromey.com>
11687
11688         PR tui/24197:
11689         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11690
11691 2019-02-17  Tom Tromey  <tom@tromey.com>
11692
11693         * ada-lang.c (user_select_syms): Use filtered printing.
11694         * utils.c (wrap_style): New global.
11695         (desired_style): Remove.
11696         (emit_style_escape): Add stream parameter.
11697         (set_output_style, reset_terminal_style, prompt_for_continue):
11698         Update.
11699         (flush_wrap_buffer): Only flush gdb_stdout.
11700         (wrap_here): Set wrap_style.
11701         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11702         treat escape sequences as a character.  Change when wrap buffer is
11703         flushed.
11704         (fputs_styled): Do not set the output style when the default is
11705         requested.
11706         * ui-style.h (struct ui_file_style) <is_default>: New method.
11707         * source.c (print_source_lines_base): Emit escape sequences in one
11708         piece.
11709
11710 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11711
11712         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11713         integers and enumeration types.
11714
11715 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11716
11717         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11718         instead of lookup_symbol_in_language
11719         (do_exact_match): New function.
11720         (ada_get_symbol_name_matcher): Return do_exact_match when
11721         doing a verbatim match.
11722
11723 2019-02-15  Tom Tromey  <tromey@adacore.com>
11724
11725         * ravenscar-thread.c (ravenscar_thread_target::resume)
11726         (ravenscar_thread_target::wait): Special case wildcard requests.
11727
11728 2019-02-15  Tom Tromey  <tromey@adacore.com>
11729
11730         * ravenscar-thread.c (base_ptid): Remove.
11731         (struct ravenscar_thread_target) <close>: New method.
11732         <m_base_ptid>: New member.
11733         <update_inferior_ptid, active_task, task_is_currently_active,
11734         runtime_initialized>: Declare methods.
11735         <ravenscar_thread_target>: Add constructor.
11736         (ravenscar_thread_target::task_is_currently_active)
11737         (ravenscar_thread_target::update_inferior_ptid)
11738         (ravenscar_runtime_initialized): Rename.  Now methods.
11739         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11740         (ravenscar_thread_target::update_thread_list): Update.
11741         (ravenscar_thread_target::active_task): Now method.
11742         (ravenscar_thread_target::store_registers)
11743         (ravenscar_thread_target::prepare_to_store)
11744         (ravenscar_thread_target::prepare_to_store)
11745         (ravenscar_thread_target::mourn_inferior): Update.
11746         (ravenscar_inferior_created): Use "new" to create target.
11747         (ravenscar_thread_target::get_ada_task_ptid): Update.
11748         (_initialize_ravenscar): Don't initialize base_ptid.
11749         (ravenscar_ops): Remove global.
11750
11751 2019-02-15  Tom Tromey  <tromey@adacore.com>
11752
11753         * target.h (push_target): Declare new overload.
11754         * target.c (push_target): New overload, taking an rvalue reference.
11755         * remote.c (remote_target::open_1): Use push_target overload.
11756         * corelow.c (core_target_open): Use push_target overload.
11757
11758 2019-02-15  Tom Tromey  <tromey@adacore.com>
11759
11760         * ravenscar-thread.c (is_ravenscar_task)
11761         (ravenscar_task_is_currently_active): Return bool.
11762         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11763         (_initialize_ravenscar): Remove "(void)".
11764         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11765         Return bool.
11766
11767 2019-02-15  Tom Tromey  <tromey@adacore.com>
11768
11769         * ravenscar-thread.c (ravenscar_runtime_initializer)
11770         (has_ravenscar_runtime, get_running_thread_id)
11771         (ravenscar_thread_target::resume): Fix indentation.
11772
11773 2019-02-15  Tom Tromey  <tromey@adacore.com>
11774
11775         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11776         from ravenscar_arch_ops.
11777         (sparc_ravenscar_ops::fetch_registers)
11778         (sparc_ravenscar_ops::store_registers): Now methods.
11779         (sparc_ravenscar_prepare_to_store): Remove.
11780         (sparc_ravenscar_ops): Redefine.
11781         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11782         methods and destructor.  Remove members.
11783         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11784         (ravenscar_thread_target::store_registers)
11785         (ravenscar_thread_target::prepare_to_store): Update.
11786         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11787         Remove.
11788         (struct ppc_ravenscar_powerpc_ops): Derive from
11789         ravenscar_arch_ops.
11790         (ppc_ravenscar_powerpc_ops::fetch_registers)
11791         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11792         (ppc_ravenscar_powerpc_ops): Redefine.
11793         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11794         (ppc_ravenscar_e500_ops::fetch_registers)
11795         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11796         (ppc_ravenscar_e500_ops): Redefine.
11797         * aarch64-ravenscar-thread.c
11798         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11799         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11800         (aarch64_ravenscar_fetch_registers)
11801         (aarch64_ravenscar_store_registers): Now methods.
11802         (aarch64_ravenscar_ops): Redefine.
11803
11804 2019-02-15  Tom Tromey  <tromey@adacore.com>
11805
11806         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11807         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11808         (ravenscar_thread_target::stopped_by_watchpoint)
11809         (ravenscar_thread_target::stopped_data_address)
11810         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11811
11812 2019-02-15  Tom Tromey  <tromey@adacore.com>
11813
11814         * ravenscar-thread.c: Fix some typos.
11815
11816 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11817             Tom Tromey  <tromey@adacore.com>
11818
11819         * ada-lang.c (ada_exception_sal): Change addr_string to a
11820         std::string.
11821         (create_ada_exception_catchpoint): Update.
11822
11823 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11824             Tom Tromey  <tromey@adacore.com>
11825
11826         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11827         (bp_location_ops): Remove.
11828         (base_breakpoint_allocate_location): Update.
11829         (free_bp_location): Update.
11830         * ada-lang.c (class ada_catchpoint_location)
11831         <ada_catchpoint_location>: Remove ops parameter.
11832         (ada_catchpoint_location_dtor): Remove.
11833         (ada_catchpoint_location_ops): Remove.
11834         (allocate_location_exception): Update.
11835         * breakpoint.h (struct bp_location_ops): Remove.
11836         (class bp_location) <bp_location>: Remove bp_location_ops
11837         parameter.
11838         <~bp_location>: Add destructor.
11839         <ops>: Remove.
11840
11841 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11842             Pedro Alves  <palves@redhat.com>
11843
11844         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11845         'PATH_MAX'.
11846
11847 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11848             Samuel Thibault  <samuel.thibault@gnu.org>
11849             Thomas Schwinge  <thomas@codesourcery.com>
11850
11851         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11852         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11853
11854 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11855
11856         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11857         (check_empty): Use "const char *".
11858
11859         * gnu-nat.c (gnu_nat_target::detach): Instead of
11860         'detach_inferior (pid)' call
11861         'detach_inferior (find_inferior_pid (pid))'.
11862
11863         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11864         'nat/fork-inferior.o'.
11865         * gnu-nat.c: #include "nat/fork-inferior.h".
11866
11867         * gnu-nat.c (gnu_nat_target::detach): Instead of
11868         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11869         * gnu-nat.h: #include "inf-child.h".
11870         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11871         'i386_gnu_nat_target::fetch_registers'.
11872         (gnu_store_registers): Rename/move to
11873         'i386_gnu_nat_target::store_registers'.
11874
11875         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11876         * gnu-nat.h (mach_thread_info): New function.
11877         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11878
11879         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11880
11881 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11882
11883         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11884
11885 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11886
11887         * windows-nat.c (windows_add_thread): Add new parameter
11888         "main_thread_p" with default value set to false.  Update
11889         function documentation as well as all callers.
11890         (windows_delete_thread): Likewise.
11891         (fake_create_process): Update call to windows_add_thread.
11892         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11893         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11894         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11895         call to windows_delete_thread.
11896
11897 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11898
11899         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11900
11901 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11902
11903         * symfile.c (find_separate_debug_file): Use canonical path of
11904         sysroot with child_path instead of gdb_sysroot if it is valid.
11905
11906 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11907
11908         * symfile.c (find_separate_debug_file): Use child_path to
11909         determine if an object file is under a sysroot.
11910
11911 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11912
11913         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11914         unittests/child-path-selftests.c.
11915         * common/pathstuff.c (child_path): New function.
11916         * common/pathstuff.h (child_path): New prototype.
11917         * unittests/child-path-selftests.c: New file.
11918
11919 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11920
11921         * symfile.c (find_separate_debug_file): Look for separate debug
11922         files in debug directories under the sysroot.
11923
11924 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11925
11926         * symtab.h (struct minimal_symbol data_p): New const method.
11927         (struct minimal_symbol text_p): Likewise.
11928         * symtab.c (output_source_filename): Use file name style
11929         to print file name.
11930         (print_symbol_info): Likewise.
11931         (print_msymbol_info): Use address style to print addresses.
11932         Use function name style to print executable text symbols.
11933         (expand_symtab_containing_pc): Use data_p.
11934         (find_pc_sect_compunit_symtab): Likewise.
11935
11936 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11937
11938         * breakpoint.c (describe_other_breakpoints): Use address style
11939         to print addresses.
11940         (say_where): Likewise.
11941
11942 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11943
11944         * ada-typeprint.c (print_func_type): Print function name
11945         style to print function name.
11946         * c-typeprint.c (c_print_type_1): Likewise.
11947
11948 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11949
11950         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11951         for execve.
11952
11953 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11954
11955         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11956         type_stack.
11957
11958 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11959
11960         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11961         TYPE_CODE_REF types.
11962
11963 2019-02-08  Jim Wilson  <jimw@sifive.com>
11964
11965         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11966         (riscv_linux_fregset): New.
11967         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11968
11969 2019-02-07  Tom Tromey  <tom@tromey.com>
11970
11971         * thread.c (thread_cancel_execution_command): Update.
11972         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11973         methods.
11974         (struct thread_fsm_ops): Remove.
11975         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11976         (thread_fsm_should_stop, thread_fsm_return_value)
11977         (thread_fsm_set_finished, thread_fsm_finished_p)
11978         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11979         Don't declare.
11980         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11981         * infrun.c (clear_proceed_status_thread)
11982         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11983         (print_stop_event): Update.
11984         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11985         Add constructor.
11986         (step_command_fsm_ops): Remove.
11987         (new_step_command_fsm): Remove.
11988         (step_1): Update.
11989         (step_command_fsm::should_stop): Rename from
11990         step_command_fsm_should_stop.
11991         (step_command_fsm::clean_up): Rename from
11992         step_command_fsm_clean_up.
11993         (step_command_fsm::do_async_reply_reason): Rename from
11994         step_command_fsm_async_reply_reason.
11995         (struct until_next_fsm): Inherit from thread_fsm.  Add
11996         constructor.
11997         (until_next_fsm_ops): Remove.
11998         (new_until_next_fsm): Remove.
11999         (until_next_fsm::should_stop): Rename from
12000         until_next_fsm_should_stop.
12001         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12002         (until_next_fsm::do_async_reply_reason): Rename from
12003         until_next_fsm_async_reply_reason.
12004         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12005         constructor.  Change type of breakpoint.
12006         (finish_command_fsm_ops): Remove.
12007         (new_finish_command_fsm): Remove.
12008         (finish_command_fsm::should_stop): Rename from
12009         finish_command_fsm_should_stop.
12010         (finish_command_fsm::clean_up): Rename from
12011         finish_command_fsm_clean_up.
12012         (finish_command_fsm::return_value): Rename from
12013         finish_command_fsm_return_value.
12014         (finish_command_fsm::do_async_reply_reason): Rename from
12015         finish_command_fsm_async_reply_reason.
12016         (finish_command): Update.
12017         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12018         Add constructor.
12019         (call_thread_fsm_ops): Remove.
12020         (call_thread_fsm::call_thread_fsm): Rename from
12021         new_call_thread_fsm.
12022         (call_thread_fsm::should_stop): Rename from
12023         call_thread_fsm_should_stop.
12024         (call_thread_fsm::should_notify_stop): Rename from
12025         call_thread_fsm_should_notify_stop.
12026         (run_inferior_call, call_function_by_hand_dummy): Update.
12027         * cli/cli-interp.c (should_print_stop_to_console): Update.
12028         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12029         Add constructor.  Change type of location_breakpoint,
12030         caller_breakpoint.
12031         (until_break_fsm_ops): Remove.
12032         (new_until_break_fsm): Remove.
12033         (until_break_fsm::should_stop): Rename from
12034         until_break_fsm_should_stop.
12035         (until_break_fsm::clean_up): Rename from
12036         until_break_fsm_clean_up.
12037         (until_break_fsm::do_async_reply_reason): Rename from
12038         until_break_fsm_async_reply_reason.
12039         (until_break_command): Update.
12040         * thread-fsm.c: Remove.
12041         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12042
12043 2019-02-07  Tom Tromey  <tom@tromey.com>
12044
12045         * yy-remap.h: Add include guard.
12046         * xtensa-tdep.h: Add include guard.
12047         * xcoffread.h: Rename include guard.
12048         * varobj-iter.h: Add include guard.
12049         * tui/tui.h: Rename include guard.
12050         * tui/tui-winsource.h: Rename include guard.
12051         * tui/tui-wingeneral.h: Rename include guard.
12052         * tui/tui-windata.h: Rename include guard.
12053         * tui/tui-win.h: Rename include guard.
12054         * tui/tui-stack.h: Rename include guard.
12055         * tui/tui-source.h: Rename include guard.
12056         * tui/tui-regs.h: Rename include guard.
12057         * tui/tui-out.h: Rename include guard.
12058         * tui/tui-layout.h: Rename include guard.
12059         * tui/tui-io.h: Rename include guard.
12060         * tui/tui-hooks.h: Rename include guard.
12061         * tui/tui-file.h: Rename include guard.
12062         * tui/tui-disasm.h: Rename include guard.
12063         * tui/tui-data.h: Rename include guard.
12064         * tui/tui-command.h: Rename include guard.
12065         * tic6x-tdep.h: Add include guard.
12066         * target/waitstatus.h: Rename include guard.
12067         * target/wait.h: Rename include guard.
12068         * target/target.h: Rename include guard.
12069         * target/resume.h: Rename include guard.
12070         * target-float.h: Rename include guard.
12071         * stabsread.h: Add include guard.
12072         * rs6000-tdep.h: Add include guard.
12073         * riscv-fbsd-tdep.h: Add include guard.
12074         * regformats/regdef.h: Rename include guard.
12075         * record.h: Rename include guard.
12076         * python/python.h: Rename include guard.
12077         * python/python-internal.h: Rename include guard.
12078         * python/py-stopevent.h: Rename include guard.
12079         * python/py-ref.h: Rename include guard.
12080         * python/py-record.h: Rename include guard.
12081         * python/py-record-full.h: Rename include guard.
12082         * python/py-record-btrace.h: Rename include guard.
12083         * python/py-instruction.h: Rename include guard.
12084         * python/py-events.h: Rename include guard.
12085         * python/py-event.h: Rename include guard.
12086         * procfs.h: Add include guard.
12087         * proc-utils.h: Add include guard.
12088         * p-lang.h: Add include guard.
12089         * or1k-tdep.h: Rename include guard.
12090         * observable.h: Rename include guard.
12091         * nto-tdep.h: Rename include guard.
12092         * nat/x86-linux.h: Rename include guard.
12093         * nat/x86-linux-dregs.h: Rename include guard.
12094         * nat/x86-gcc-cpuid.h: Add include guard.
12095         * nat/x86-dregs.h: Rename include guard.
12096         * nat/x86-cpuid.h: Rename include guard.
12097         * nat/ppc-linux.h: Rename include guard.
12098         * nat/mips-linux-watch.h: Rename include guard.
12099         * nat/linux-waitpid.h: Rename include guard.
12100         * nat/linux-ptrace.h: Rename include guard.
12101         * nat/linux-procfs.h: Rename include guard.
12102         * nat/linux-osdata.h: Rename include guard.
12103         * nat/linux-nat.h: Rename include guard.
12104         * nat/linux-namespaces.h: Rename include guard.
12105         * nat/linux-btrace.h: Rename include guard.
12106         * nat/glibc_thread_db.h: Rename include guard.
12107         * nat/gdb_thread_db.h: Rename include guard.
12108         * nat/gdb_ptrace.h: Rename include guard.
12109         * nat/fork-inferior.h: Rename include guard.
12110         * nat/amd64-linux-siginfo.h: Rename include guard.
12111         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12112         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12113         * nat/aarch64-linux.h: Rename include guard.
12114         * nat/aarch64-linux-hw-point.h: Rename include guard.
12115         * mn10300-tdep.h: Add include guard.
12116         * mips-linux-tdep.h: Add include guard.
12117         * mi/mi-parse.h: Rename include guard.
12118         * mi/mi-out.h: Rename include guard.
12119         * mi/mi-main.h: Rename include guard.
12120         * mi/mi-interp.h: Rename include guard.
12121         * mi/mi-getopt.h: Rename include guard.
12122         * mi/mi-console.h: Rename include guard.
12123         * mi/mi-common.h: Rename include guard.
12124         * mi/mi-cmds.h: Rename include guard.
12125         * mi/mi-cmd-break.h: Rename include guard.
12126         * m2-lang.h: Add include guard.
12127         * location.h: Rename include guard.
12128         * linux-record.h: Rename include guard.
12129         * linux-nat.h: Add include guard.
12130         * linux-fork.h: Add include guard.
12131         * i386-darwin-tdep.h: Rename include guard.
12132         * hppa-linux-offsets.h: Add include guard.
12133         * guile/guile.h: Rename include guard.
12134         * guile/guile-internal.h: Rename include guard.
12135         * gnu-nat.h: Rename include guard.
12136         * gdb-stabs.h: Rename include guard.
12137         * frv-tdep.h: Add include guard.
12138         * f-lang.h: Add include guard.
12139         * event-loop.h: Add include guard.
12140         * darwin-nat.h: Rename include guard.
12141         * cp-abi.h: Rename include guard.
12142         * config/sparc/nm-sol2.h: Rename include guard.
12143         * config/nm-nto.h: Rename include guard.
12144         * config/nm-linux.h: Add include guard.
12145         * config/i386/nm-i386gnu.h: Rename include guard.
12146         * config/djgpp/nl_types.h: Rename include guard.
12147         * config/djgpp/langinfo.h: Rename include guard.
12148         * compile/gcc-cp-plugin.h: Add include guard.
12149         * compile/gcc-c-plugin.h: Add include guard.
12150         * compile/compile.h: Rename include guard.
12151         * compile/compile-object-run.h: Rename include guard.
12152         * compile/compile-object-load.h: Rename include guard.
12153         * compile/compile-internal.h: Rename include guard.
12154         * compile/compile-cplus.h: Rename include guard.
12155         * compile/compile-c.h: Rename include guard.
12156         * common/xml-utils.h: Rename include guard.
12157         * common/x86-xstate.h: Rename include guard.
12158         * common/version.h: Rename include guard.
12159         * common/vec.h: Rename include guard.
12160         * common/tdesc.h: Rename include guard.
12161         * common/selftest.h: Rename include guard.
12162         * common/scoped_restore.h: Rename include guard.
12163         * common/scoped_mmap.h: Rename include guard.
12164         * common/scoped_fd.h: Rename include guard.
12165         * common/safe-iterator.h: Rename include guard.
12166         * common/run-time-clock.h: Rename include guard.
12167         * common/refcounted-object.h: Rename include guard.
12168         * common/queue.h: Rename include guard.
12169         * common/ptid.h: Rename include guard.
12170         * common/print-utils.h: Rename include guard.
12171         * common/preprocessor.h: Rename include guard.
12172         * common/pathstuff.h: Rename include guard.
12173         * common/observable.h: Rename include guard.
12174         * common/netstuff.h: Rename include guard.
12175         * common/job-control.h: Rename include guard.
12176         * common/host-defs.h: Rename include guard.
12177         * common/gdb_wait.h: Rename include guard.
12178         * common/gdb_vecs.h: Rename include guard.
12179         * common/gdb_unlinker.h: Rename include guard.
12180         * common/gdb_unique_ptr.h: Rename include guard.
12181         * common/gdb_tilde_expand.h: Rename include guard.
12182         * common/gdb_sys_time.h: Rename include guard.
12183         * common/gdb_string_view.h: Rename include guard.
12184         * common/gdb_splay_tree.h: Rename include guard.
12185         * common/gdb_setjmp.h: Rename include guard.
12186         * common/gdb_ref_ptr.h: Rename include guard.
12187         * common/gdb_optional.h: Rename include guard.
12188         * common/gdb_locale.h: Rename include guard.
12189         * common/gdb_assert.h: Rename include guard.
12190         * common/filtered-iterator.h: Rename include guard.
12191         * common/filestuff.h: Rename include guard.
12192         * common/fileio.h: Rename include guard.
12193         * common/environ.h: Rename include guard.
12194         * common/common-utils.h: Rename include guard.
12195         * common/common-types.h: Rename include guard.
12196         * common/common-regcache.h: Rename include guard.
12197         * common/common-inferior.h: Rename include guard.
12198         * common/common-gdbthread.h: Rename include guard.
12199         * common/common-exceptions.h: Rename include guard.
12200         * common/common-defs.h: Rename include guard.
12201         * common/common-debug.h: Rename include guard.
12202         * common/cleanups.h: Rename include guard.
12203         * common/buffer.h: Rename include guard.
12204         * common/btrace-common.h: Rename include guard.
12205         * common/break-common.h: Rename include guard.
12206         * cli/cli-utils.h: Rename include guard.
12207         * cli/cli-style.h: Rename include guard.
12208         * cli/cli-setshow.h: Rename include guard.
12209         * cli/cli-script.h: Rename include guard.
12210         * cli/cli-interp.h: Rename include guard.
12211         * cli/cli-decode.h: Rename include guard.
12212         * cli/cli-cmds.h: Rename include guard.
12213         * charset-list.h: Add include guard.
12214         * buildsym-legacy.h: Rename include guard.
12215         * bfin-tdep.h: Add include guard.
12216         * ax.h: Rename include guard.
12217         * arm-linux-tdep.h: Add include guard.
12218         * arm-fbsd-tdep.h: Add include guard.
12219         * arch/xtensa.h: Rename include guard.
12220         * arch/tic6x.h: Add include guard.
12221         * arch/i386.h: Add include guard.
12222         * arch/arm.h: Rename include guard.
12223         * arch/arm-linux.h: Rename include guard.
12224         * arch/arm-get-next-pcs.h: Rename include guard.
12225         * arch/amd64.h: Add include guard.
12226         * arch/aarch64-insn.h: Rename include guard.
12227         * arch-utils.h: Rename include guard.
12228         * annotate.h: Add include guard.
12229         * amd64-darwin-tdep.h: Rename include guard.
12230         * aarch64-linux-tdep.h: Add include guard.
12231         * aarch64-fbsd-tdep.h: Add include guard.
12232         * aarch32-linux-nat.h: Add include guard.
12233
12234 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12235
12236         * macrotab.c (macro_define_internal): New function that
12237         factorizes macro_define_object_internal and macro_define_function
12238         code.
12239         (macro_define_object_internal): Use macro_define_internal.
12240         (macro_define_function): Likewise.
12241
12242 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12243
12244         * macrocmd.c (extract_identifier): Return
12245         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12246         callers.
12247
12248 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12249
12250         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12251
12252 2019-02-05  Tom Tromey  <tom@tromey.com>
12253
12254         * target.c (target_stack::unpush): Move assertion earlier.
12255
12256 2019-01-30  Tom Tromey  <tom@tromey.com>
12257
12258         PR python/23615:
12259         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12260         (gdbpy_parse_and_eval): Likewise.
12261         * python/python-internal.h (gdbpy_allow_threads): New class.
12262
12263 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12264
12265         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12266         (aarch64_fbsd_fpregmap): Move earlier.
12267         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12268         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12269         instead of individual calls to trad_frame_set_reg_addr.
12270         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12271         earlier.
12272         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12273         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12274         instead of individual calls to trad_frame_set_reg_addr.
12275
12276 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12277
12278         * CONTRIBUTE: Replace contribution list with wiki link.
12279
12280 2019-01-25  Tom Tromey  <tom@tromey.com>
12281
12282         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12283
12284 2019-01-25  Tom Tromey  <tom@tromey.com>
12285
12286         * xtensa-linux-nat.c: Fix common/ includes.
12287         * xml-support.h: Fix common/ includes.
12288         * xml-support.c: Fix common/ includes.
12289         * x86-linux-nat.c: Fix common/ includes.
12290         * windows-nat.c: Fix common/ includes.
12291         * varobj.h: Fix common/ includes.
12292         * varobj.c: Fix common/ includes.
12293         * value.c: Fix common/ includes.
12294         * valops.c: Fix common/ includes.
12295         * utils.c: Fix common/ includes.
12296         * unittests/xml-utils-selftests.c: Fix common/ includes.
12297         * unittests/utils-selftests.c: Fix common/ includes.
12298         * unittests/unpack-selftests.c: Fix common/ includes.
12299         * unittests/tracepoint-selftests.c: Fix common/ includes.
12300         * unittests/style-selftests.c: Fix common/ includes.
12301         * unittests/string_view-selftests.c: Fix common/ includes.
12302         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12303         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12304         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12305         * unittests/rsp-low-selftests.c: Fix common/ includes.
12306         * unittests/parse-connection-spec-selftests.c: Fix common/
12307         includes.
12308         * unittests/optional-selftests.c: Fix common/ includes.
12309         * unittests/offset-type-selftests.c: Fix common/ includes.
12310         * unittests/observable-selftests.c: Fix common/ includes.
12311         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12312         * unittests/memrange-selftests.c: Fix common/ includes.
12313         * unittests/memory-map-selftests.c: Fix common/ includes.
12314         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12315         * unittests/function-view-selftests.c: Fix common/ includes.
12316         * unittests/environ-selftests.c: Fix common/ includes.
12317         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12318         * unittests/common-utils-selftests.c: Fix common/ includes.
12319         * unittests/cli-utils-selftests.c: Fix common/ includes.
12320         * unittests/array-view-selftests.c: Fix common/ includes.
12321         * ui-file.c: Fix common/ includes.
12322         * tui/tui-io.c: Fix common/ includes.
12323         * tracepoint.h: Fix common/ includes.
12324         * tracepoint.c: Fix common/ includes.
12325         * tracefile-tfile.c: Fix common/ includes.
12326         * top.h: Fix common/ includes.
12327         * top.c: Fix common/ includes.
12328         * thread.c: Fix common/ includes.
12329         * target/waitstatus.h: Fix common/ includes.
12330         * target/waitstatus.c: Fix common/ includes.
12331         * target.h: Fix common/ includes.
12332         * target.c: Fix common/ includes.
12333         * target-memory.c: Fix common/ includes.
12334         * target-descriptions.c: Fix common/ includes.
12335         * symtab.h: Fix common/ includes.
12336         * symfile.c: Fix common/ includes.
12337         * stap-probe.c: Fix common/ includes.
12338         * spu-linux-nat.c: Fix common/ includes.
12339         * sparc-nat.c: Fix common/ includes.
12340         * source.c: Fix common/ includes.
12341         * solib.c: Fix common/ includes.
12342         * solib-target.c: Fix common/ includes.
12343         * ser-unix.c: Fix common/ includes.
12344         * ser-tcp.c: Fix common/ includes.
12345         * ser-pipe.c: Fix common/ includes.
12346         * ser-base.c: Fix common/ includes.
12347         * selftest-arch.c: Fix common/ includes.
12348         * s12z-tdep.c: Fix common/ includes.
12349         * rust-exp.y: Fix common/ includes.
12350         * rs6000-aix-tdep.c: Fix common/ includes.
12351         * riscv-tdep.c: Fix common/ includes.
12352         * remote.c: Fix common/ includes.
12353         * remote-notif.h: Fix common/ includes.
12354         * remote-fileio.h: Fix common/ includes.
12355         * remote-fileio.c: Fix common/ includes.
12356         * regcache.h: Fix common/ includes.
12357         * regcache.c: Fix common/ includes.
12358         * record-btrace.c: Fix common/ includes.
12359         * python/python.c: Fix common/ includes.
12360         * python/py-type.c: Fix common/ includes.
12361         * python/py-inferior.c: Fix common/ includes.
12362         * progspace.h: Fix common/ includes.
12363         * producer.c: Fix common/ includes.
12364         * procfs.c: Fix common/ includes.
12365         * proc-api.c: Fix common/ includes.
12366         * printcmd.c: Fix common/ includes.
12367         * ppc-linux-nat.c: Fix common/ includes.
12368         * parser-defs.h: Fix common/ includes.
12369         * osdata.c: Fix common/ includes.
12370         * obsd-nat.c: Fix common/ includes.
12371         * nat/x86-linux.c: Fix common/ includes.
12372         * nat/x86-linux-dregs.c: Fix common/ includes.
12373         * nat/x86-dregs.h: Fix common/ includes.
12374         * nat/x86-dregs.c: Fix common/ includes.
12375         * nat/ppc-linux.c: Fix common/ includes.
12376         * nat/mips-linux-watch.h: Fix common/ includes.
12377         * nat/mips-linux-watch.c: Fix common/ includes.
12378         * nat/linux-waitpid.c: Fix common/ includes.
12379         * nat/linux-ptrace.h: Fix common/ includes.
12380         * nat/linux-ptrace.c: Fix common/ includes.
12381         * nat/linux-procfs.c: Fix common/ includes.
12382         * nat/linux-personality.c: Fix common/ includes.
12383         * nat/linux-osdata.c: Fix common/ includes.
12384         * nat/linux-namespaces.c: Fix common/ includes.
12385         * nat/linux-btrace.h: Fix common/ includes.
12386         * nat/linux-btrace.c: Fix common/ includes.
12387         * nat/fork-inferior.c: Fix common/ includes.
12388         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12389         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12390         * nat/aarch64-linux.c: Fix common/ includes.
12391         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12392         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12393         * namespace.h: Fix common/ includes.
12394         * mips-linux-tdep.c: Fix common/ includes.
12395         * minsyms.c: Fix common/ includes.
12396         * mi/mi-parse.h: Fix common/ includes.
12397         * mi/mi-main.c: Fix common/ includes.
12398         * mi/mi-cmd-env.c: Fix common/ includes.
12399         * memrange.h: Fix common/ includes.
12400         * memattr.c: Fix common/ includes.
12401         * maint.h: Fix common/ includes.
12402         * maint.c: Fix common/ includes.
12403         * main.c: Fix common/ includes.
12404         * machoread.c: Fix common/ includes.
12405         * location.c: Fix common/ includes.
12406         * linux-thread-db.c: Fix common/ includes.
12407         * linux-nat.c: Fix common/ includes.
12408         * linux-fork.c: Fix common/ includes.
12409         * inline-frame.c: Fix common/ includes.
12410         * infrun.c: Fix common/ includes.
12411         * inflow.c: Fix common/ includes.
12412         * inferior.h: Fix common/ includes.
12413         * inferior.c: Fix common/ includes.
12414         * infcmd.c: Fix common/ includes.
12415         * inf-ptrace.c: Fix common/ includes.
12416         * inf-child.c: Fix common/ includes.
12417         * ia64-linux-nat.c: Fix common/ includes.
12418         * i387-tdep.c: Fix common/ includes.
12419         * i386-tdep.c: Fix common/ includes.
12420         * i386-linux-tdep.c: Fix common/ includes.
12421         * i386-linux-nat.c: Fix common/ includes.
12422         * i386-go32-tdep.c: Fix common/ includes.
12423         * i386-fbsd-tdep.c: Fix common/ includes.
12424         * i386-fbsd-nat.c: Fix common/ includes.
12425         * guile/scm-type.c: Fix common/ includes.
12426         * guile/guile.c: Fix common/ includes.
12427         * go32-nat.c: Fix common/ includes.
12428         * gnu-nat.c: Fix common/ includes.
12429         * gdbthread.h: Fix common/ includes.
12430         * gdbarch-selftests.c: Fix common/ includes.
12431         * gdb_usleep.c: Fix common/ includes.
12432         * gdb_select.h: Fix common/ includes.
12433         * gdb_bfd.c: Fix common/ includes.
12434         * gcore.c: Fix common/ includes.
12435         * fork-child.c: Fix common/ includes.
12436         * findvar.c: Fix common/ includes.
12437         * fbsd-nat.c: Fix common/ includes.
12438         * event-top.c: Fix common/ includes.
12439         * event-loop.c: Fix common/ includes.
12440         * dwarf2read.c: Fix common/ includes.
12441         * dwarf2loc.c: Fix common/ includes.
12442         * dwarf2-frame.c: Fix common/ includes.
12443         * dwarf-index-cache.c: Fix common/ includes.
12444         * dtrace-probe.c: Fix common/ includes.
12445         * disasm-selftests.c: Fix common/ includes.
12446         * defs.h: Fix common/ includes.
12447         * csky-tdep.c: Fix common/ includes.
12448         * cp-valprint.c: Fix common/ includes.
12449         * cp-support.h: Fix common/ includes.
12450         * cp-support.c: Fix common/ includes.
12451         * corelow.c: Fix common/ includes.
12452         * completer.h: Fix common/ includes.
12453         * completer.c: Fix common/ includes.
12454         * compile/compile.c: Fix common/ includes.
12455         * compile/compile-loc2c.c: Fix common/ includes.
12456         * compile/compile-cplus-types.c: Fix common/ includes.
12457         * compile/compile-cplus-symbols.c: Fix common/ includes.
12458         * command.h: Fix common/ includes.
12459         * cli/cli-dump.c: Fix common/ includes.
12460         * cli/cli-cmds.c: Fix common/ includes.
12461         * charset.c: Fix common/ includes.
12462         * build-id.c: Fix common/ includes.
12463         * btrace.h: Fix common/ includes.
12464         * btrace.c: Fix common/ includes.
12465         * breakpoint.h: Fix common/ includes.
12466         * breakpoint.c: Fix common/ includes.
12467         * ax.h:
12468         (enum agent_op): Fix common/ includes.
12469         * ax-general.c (struct aop_map): Fix common/ includes.
12470         * ax-gdb.c: Fix common/ includes.
12471         * auxv.c: Fix common/ includes.
12472         * auto-load.c: Fix common/ includes.
12473         * arm-tdep.c: Fix common/ includes.
12474         * arch/riscv.c: Fix common/ includes.
12475         * arch/ppc-linux-common.c: Fix common/ includes.
12476         * arch/i386.c: Fix common/ includes.
12477         * arch/arm.c: Fix common/ includes.
12478         * arch/arm-linux.c: Fix common/ includes.
12479         * arch/arm-get-next-pcs.c: Fix common/ includes.
12480         * arch/amd64.c: Fix common/ includes.
12481         * arch/aarch64.c: Fix common/ includes.
12482         * arch/aarch64-insn.c: Fix common/ includes.
12483         * arch-utils.c: Fix common/ includes.
12484         * amd64-windows-tdep.c: Fix common/ includes.
12485         * amd64-tdep.c: Fix common/ includes.
12486         * amd64-sol2-tdep.c: Fix common/ includes.
12487         * amd64-obsd-tdep.c: Fix common/ includes.
12488         * amd64-nbsd-tdep.c: Fix common/ includes.
12489         * amd64-linux-tdep.c: Fix common/ includes.
12490         * amd64-linux-nat.c: Fix common/ includes.
12491         * amd64-fbsd-tdep.c: Fix common/ includes.
12492         * amd64-fbsd-nat.c: Fix common/ includes.
12493         * amd64-dicos-tdep.c: Fix common/ includes.
12494         * amd64-darwin-tdep.c: Fix common/ includes.
12495         * agent.c: Fix common/ includes.
12496         * ada-lang.h: Fix common/ includes.
12497         * ada-lang.c: Fix common/ includes.
12498         * aarch64-tdep.c: Fix common/ includes.
12499
12500 2019-01-25  Tom Tromey  <tom@tromey.com>
12501
12502         * common/create-version.sh: Use common/version.h.
12503
12504 2019-01-24  Pedro Alves  <palves@redhat.com>
12505
12506         * infrun.c (signal_stop, signal_print, signal_program)
12507         (signal_catch, signal_pass): Now arrays instead of pointers.
12508         (update_signals_program_target, do_target_resume)
12509         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12510         * linux-nat.c (linux_nat_target::pass_signals)
12511         (linux_nat_target::create_inferior, linux_nat_target::attach):
12512         Adjust.
12513         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12514         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12515         * procfs.c (procfs_target::pass_signals): Adjust.
12516         * record-full.c (record_full_target::resume): Adjust.
12517         * remote.c (remote_target::pass_signals)
12518         (remote_target::program_signals): Adjust.
12519         * target-debug.h (target_debug_print_signals): Now takes a
12520         gdb::array_view as parameter.  Adjust.
12521         * target.h (target_ops) <pass_signals, program_signals>: Replace
12522         pointer and length parameters with gdb::array_view.
12523         (target_pass_signals, target_program_signals): Likewise.
12524         * target-delegates.c: Regenerate.
12525
12526 2019-01-24  Pedro Alves  <palves@redhat.com>
12527
12528         * common/forward-scope-exit.h
12529         (forward_scope_exit::forward_scope_exit): Pass arguments to
12530         m_bind_function directly, instead of creating a std::bind and
12531         copying that.
12532
12533 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12534
12535         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12536         for static members.
12537         (pass_in_v_vfp_candidate): Likewise.
12538
12539 2019-01-23  Tom Tromey  <tom@tromey.com>
12540             Pedro Alves  <palves@redhat.com>
12541
12542         * regcache.c (class regcache_invalidator): Remove.
12543         (regcache::raw_write): Use make_scope_exit.
12544
12545 2019-01-23  Tom Tromey  <tom@tromey.com>
12546
12547         * ui-out.h (class ui_out_emit_type): Update comment.
12548
12549 2019-01-23  Tom Tromey  <tom@tromey.com>
12550
12551         * infrun.c (fetch_inferior_event): Update comment.
12552
12553 2019-01-23  Tom Tromey  <tom@tromey.com>
12554             Pedro Alves  <palves@redhat.com>
12555
12556         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12557         parameter.
12558         (fetch_inferior_event): Use SCOPE_EXIT.
12559
12560
12561 2019-01-23  Tom Tromey  <tom@tromey.com>
12562             Pedro Alves  <palves@redhat.com>
12563
12564         * infrun.c (disable_thread_events): Delete.
12565         (stop_all_threads): Use SCOPE_EXIT.
12566
12567 2019-01-23  Tom Tromey  <tom@tromey.com>
12568             Pedro Alves  <palves@redhat.com>
12569
12570         * symfile.c: Include forward-scope-exit.h.
12571         (clear_symtab_users_cleanup): Replace forward declaration with
12572         a FORWARD_SCOPE_EXIT.
12573         (syms_from_objfile_1): Use the forward_scope_exit and
12574         gdb::optional instead of cleanup_function.
12575         (reread_symbols): Use the forward_scope_exit instead of
12576         cleanup_function.
12577         (clear_symtab_users_cleanup): Remove function.
12578
12579 2019-01-23  Tom Tromey  <tom@tromey.com>
12580             Pedro Alves  <palves@redhat.com>
12581
12582         * linux-nat.c: Include scope-exit.h.
12583         (cleanup_target_stop): Remove.
12584         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12585         SCOPE_EXIT.
12586
12587 2019-01-23  Tom Tromey  <tom@tromey.com>
12588             Pedro Alves  <palves@redhat.com>
12589
12590         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12591         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12592
12593 2019-01-23  Tom Tromey  <tom@tromey.com>
12594             Andrew Burgess  <andrew.burgess@embecosm.com>
12595             Pedro Alves  <palves@redhat.com>
12596
12597         * infrun.c (fetch_inferior_event): Use scope_exit.
12598         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12599         * top.c (execute_command): Use scope_exit.
12600         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12601         * utils.c (do_bpstat_clear_actions_cleanup)
12602         (make_bpstat_clear_actions_cleanup): Remove.
12603
12604 2019-01-23  Tom Tromey  <tom@tromey.com>
12605             Pedro Alves  <palves@redhat.com>
12606
12607         * infrun.c: Include "common/scope-exit.h"
12608         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12609         (wait_for_inferior): Use SCOPE_EXIT.
12610         (fetch_inferior_event): Use scope_exit.
12611
12612 2019-01-23  Tom Tromey  <tom@tromey.com>
12613             Pedro Alves  <palves@redhat.com>
12614
12615         * breakpoint.c (create_breakpoint): Remove cleanup.
12616
12617 2019-01-23  Tom Tromey  <tom@tromey.com>
12618             Andrew Burgess  <andrew.burgess@embecosm.com>
12619             Pedro Alves  <palves@redhat.com>
12620
12621 2019-01-23  Pedro Alves  <palves@redhat.com>
12622
12623         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12624
12625 2019-01-23  Pedro Alves  <palves@redhat.com>
12626             Andrew Burgess  <andrew.burgess@embecosm.com>
12627
12628         * gdbthread.h: Include "common/forward-scope-exit.h".
12629         (scoped_finish_thread_state): Redefine custom class in terms of
12630         forward_scope_exit.
12631
12632 2019-01-23  Pedro Alves  <palves@redhat.com>
12633             Andrew Burgess  <andrew.burgess@embecosm.com>
12634
12635         * common/forward-scope-exit.h: New file.
12636
12637 2019-01-23  Pedro Alves  <palves@redhat.com>
12638             Andrew Burgess  <andrew.burgess@embecosm.com>
12639             Tom Tromey  <tom@tromey.com>
12640
12641         * common/scope-exit.h: New file.
12642
12643 2019-01-23  Pedro Alves  <palves@redhat.com>
12644
12645         * common/preprocessor.h (ESC): Rename to ...
12646         (ESC_PARENS): ... this.
12647         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12648         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12649
12650 2019-01-23  Tom Tromey  <tom@tromey.com>
12651
12652         * language.h (class scoped_switch_to_sym_language_if_auto):
12653         Initialize m_lang in both cases.
12654
12655 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12656
12657         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12658         with XCNEW.
12659
12660 2019-01-22  Tom Tromey  <tom@tromey.com>
12661
12662         * corelow.c: Do not include sys/file.h.
12663
12664 2019-01-22  Tom Tromey  <tom@tromey.com>
12665
12666         * tui/tui-wingeneral.h: Include gdb_curses.h.
12667
12668 2019-01-22  Tom Tromey  <tom@tromey.com>
12669
12670         * source-cache.h (class source_cache) <get_source_lines,
12671         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12672
12673 2019-01-22  Tom Tromey  <tom@tromey.com>
12674
12675         * remote-fileio.h (struct remote_target): Declare.
12676
12677 2019-01-22  Tom Tromey  <tom@tromey.com>
12678
12679         * python/py-arch.c: Do not include py-ref.h.
12680         * python/py-bpevent.c: Do not include py-ref.h.
12681         * python/py-cmd.c: Do not include py-ref.h.
12682         * python/py-continueevent.c: Do not include py-ref.h.
12683         * python/py-event.h: Do not include py-ref.h.
12684         * python/py-evtregistry.c: Do not include py-ref.h.
12685         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12686         * python/py-frame.c: Do not include py-ref.h.
12687         * python/py-framefilter.c: Do not include py-ref.h.
12688         * python/py-function.c: Do not include py-ref.h.
12689         * python/py-infevents.c: Do not include py-ref.h.
12690         * python/py-linetable.c: Do not include py-ref.h.
12691         * python/py-objfile.c: Do not include py-ref.h.
12692         * python/py-param.c: Do not include py-ref.h.
12693         * python/py-prettyprint.c: Do not include py-ref.h.
12694         * python/py-progspace.c: Do not include py-ref.h.
12695         * python/py-symbol.c: Do not include py-ref.h.
12696         * python/py-symtab.c: Do not include py-ref.h.
12697         * python/py-type.c: Do not include py-ref.h.
12698         * python/py-unwind.c: Do not include py-ref.h.
12699         * python/py-utils.c: Do not include py-ref.h.
12700         * python/py-value.c: Do not include py-ref.h.
12701         * python/py-varobj.c: Do not include py-ref.h.
12702         * python/py-xmethods.c: Do not include py-ref.h.
12703         * python/python.c: Do not include py-ref.h.
12704         * varobj.c: Do not include py-ref.h.
12705
12706 2019-01-22  Tom Tromey  <tom@tromey.com>
12707
12708         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12709         keyword for bcache.
12710
12711 2019-01-22  Tom Tromey  <tom@tromey.com>
12712
12713         * compile/compile-cplus-types.c: Remove a comment by #include.
12714
12715 2019-01-22  Tom Tromey  <tom@tromey.com>
12716
12717         * compile/gcc-c-plugin.h: Include compile-internal.h.
12718
12719 2019-01-22  Tom Tromey  <tom@tromey.com>
12720
12721         * stabsread.c (EXTERN): Do not define.
12722         (symnum, next_symbol_text_func, processing_gcc_compilation)
12723         (within_function, global_sym_chain, global_stabs)
12724         (previous_stab_code, this_object_header_files)
12725         (n_this_object_header_files)
12726         (n_allocated_this_object_header_files): Define.
12727         * stabsread.h (EXTERN): Never define.  Use "extern".
12728
12729 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12730
12731         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12732         history_value.
12733
12734 2019-01-21  Tom Tromey  <tom@tromey.com>
12735
12736         * ui-out.c: Fix includes.
12737         * tui/tui-source.c: Fix includes.
12738         * target.c: Fix includes.
12739         * remote.c: Fix includes.
12740         * regcache.c: Fix includes.
12741         * python/py-block.c: Fix includes.
12742         * printcmd.c: Fix includes.
12743         * or1k-tdep.c: Fix includes.
12744         * mi/mi-main.c: Fix includes.
12745         * m32r-tdep.c: Fix includes.
12746         * csky-tdep.c: Fix includes.
12747         * compile/compile-cplus-types.c: Fix includes.
12748         * cli/cli-interp.c: Fix includes.
12749
12750 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12751
12752         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12753         for padding.
12754
12755 2019-01-16  Tom Tromey  <tom@tromey.com>
12756
12757         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12758         earlier.
12759         (struct objfile) <msymbols_range>: Move from top level.
12760         <msymbols>: New method.
12761         (class objfile_msymbols): Remove.
12762         * symtab.c (default_collect_symbol_completion_matches_break_on):
12763         Update.
12764         * symmisc.c (dump_msymbols): Update.
12765         * stabsread.c (scan_file_globals): Update.
12766         * objc-lang.c (info_selectors_command, info_classes_command)
12767         (find_methods): Update.
12768         * minsyms.c (find_solib_trampoline_target): Update.
12769         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12770         * coffread.c (coff_symfile_read): Update.
12771         * ada-lang.c (ada_lookup_simple_minsym)
12772         (ada_collect_symbol_completion_matches): Update.
12773
12774 2019-01-16  Tom Tromey  <tom@tromey.com>
12775
12776         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12777         type.  Remove no-argument constructor.
12778         <iterator::operator++>: Simplify.
12779         <begin>: Update.
12780         <end>: Use minimal_symbol_count.
12781
12782 2019-01-16  Tom Tromey  <tom@tromey.com>
12783
12784         * objfiles.h (struct objfile) <psymtabs>: New method.
12785         (class objfile_psymtabs): Remove.
12786         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12787         typedef.
12788         <range>: New method.
12789         (require_partial_symbols): Change return type.
12790         * psymtab.c (require_partial_symbols)
12791         (psym_expand_symtabs_matching): Update.
12792         * mdebugread.c (parse_partial_symbols): Update.
12793         * dbxread.c (dbx_end_psymtab): Update.
12794
12795 2019-01-15  Tom Tromey  <tom@tromey.com>
12796
12797         * symtab.c (lookup_objfile_from_block)
12798         (lookup_symbol_in_objfile_symtabs)
12799         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12800         (find_line_symtab, info_sources_command)
12801         (default_collect_symbol_completion_matches_break_on)
12802         (make_source_files_completion_list): Update.
12803         * symmisc.c (print_objfile_statistics, dump_objfile)
12804         (maintenance_print_symbols, maintenance_info_symtabs)
12805         (maintenance_check_symtabs, maintenance_info_line_tables):
12806         Update.
12807         * source.c (select_source_symtab)
12808         (forget_cached_source_info_for_objfile): Update.
12809         * objfiles.h (class objfile_compunits): Remove.
12810         (struct objfile) <compunits_range>: New typedef.
12811         (compunits): New method.
12812         * objfiles.c (objfile_relocate1): Update.
12813         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12814         * maint.c (count_symtabs_and_blocks): Update.
12815         * linespec.c (iterate_over_all_matching_symtabs): Update.
12816         * cp-support.c (add_symbol_overload_list_qualified): Update.
12817         * coffread.c (coff_symtab_read): Update.
12818         * ada-lang.c (add_nonlocal_symbols)
12819         (ada_collect_symbol_completion_matches)
12820         (ada_add_global_exceptions): Update.
12821
12822 2019-01-15  Tom Tromey  <tom@tromey.com>
12823
12824         * progspace.h (program_space) <objfiles_safe_range>: New
12825         typedef.
12826         <objfiles_safe>: New method.
12827         * objfiles.h (class all_objfiles_safe): Remove.
12828         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12829         * jit.c (jit_inferior_exit_hook): Update.
12830
12831 2019-01-17  Tom Tromey  <tom@tromey.com>
12832
12833         * progspace.h (program_space) <objfiles_range>: New typedef.
12834         <objfiles>: New method.
12835         <objfiles_head>: Rename from objfiles.
12836         (object_files): Update.
12837         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12838         * guile/scm-pretty-print.c
12839         (ppscm_find_pretty_printer_from_objfiles): Update.
12840         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12841         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12842         Update.
12843         * python/py-progspace.c (pspy_get_objfiles): Update.
12844         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12845         Update.
12846         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12847         (objfpy_lookup_objfile_by_build_id): Update.
12848         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12849         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12850         Update.
12851         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12852         (expand_symtab_containing_pc, lookup_objfile_from_block)
12853         (lookup_static_symbol, basic_lookup_transparent_type)
12854         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12855         (find_line_symtab, info_sources_command)
12856         (default_collect_symbol_completion_matches_break_on)
12857         (make_source_files_completion_list, find_main_name): Update.
12858         * symmisc.c (print_symbol_bcache_statistics)
12859         (print_objfile_statistics, maintenance_print_symbols)
12860         (maintenance_print_msymbols, maintenance_print_objfiles)
12861         (maintenance_info_symtabs, maintenance_check_symtabs)
12862         (maintenance_expand_symtabs, maintenance_info_line_tables):
12863         Update.
12864         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12865         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12866         (map_overlay_command, unmap_overlay_command)
12867         (simple_overlay_update, expand_symtabs_matching)
12868         (map_symbol_filenames): Update.
12869         * symfile-debug.c (set_debug_symfile): Update.
12870         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12871         Update.
12872         * source.c (select_source_symtab, forget_cached_source_info):
12873         Update.
12874         * solib.c (solib_read_symbols): Update.
12875         * solib-spu.c (append_ocl_sos): Update.
12876         * psymtab.c (maintenance_print_psymbols)
12877         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12878         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12879         * printcmd.c (info_symbol_command): Update.
12880         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12881         Update.
12882         * objfiles.h (class all_objfiles): Remove.
12883         * objfiles.c (have_partial_symbols, have_full_symbols)
12884         (have_minimal_symbols, qsort_cmp, update_section_map)
12885         (shared_objfile_contains_address_p)
12886         (default_iterate_over_objfiles_in_search_order): Update.
12887         * objc-lang.c (info_selectors_command, info_classes_command)
12888         (find_methods): Update.
12889         * minsyms.c (find_solib_trampoline_target): Update.
12890         * maint.c (maintenance_info_sections)
12891         (maintenance_translate_address, count_symtabs_and_blocks):
12892         Update.
12893         * main.c (captured_main_1): Update.
12894         * linux-thread-db.c (try_thread_db_load_from_pdir)
12895         (has_libpthread): Update.
12896         * linespec.c (iterate_over_all_matching_symtabs)
12897         (search_minsyms_for_name): Update.
12898         * jit.c (jit_find_objf_with_entry_addr): Update.
12899         * hppa-tdep.c (find_unwind_entry)
12900         (hppa_lookup_stub_minimal_symbol): Update.
12901         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12902         Update.
12903         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12904         (elf_gnu_ifunc_resolve_by_got): Update.
12905         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12906         * dwarf-index-write.c (save_gdb_index_command): Update.
12907         * cp-support.c (add_symbol_overload_list_qualified): Update.
12908         * breakpoint.c (create_overlay_event_breakpoint)
12909         (create_longjmp_master_breakpoint)
12910         (create_std_terminate_master_breakpoint)
12911         (create_exception_master_breakpoint): Update.
12912         * blockframe.c (find_pc_partial_function): Update.
12913         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12914         (ada_collect_symbol_completion_matches)
12915         (ada_add_global_exceptions): Update.
12916
12917 2019-01-17  Tom Tromey  <tom@tromey.com>
12918
12919         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12920         declare VEC.
12921         (solib_target_parse_libraries): Change return type.
12922         (library_list_start_segment, library_list_start_section)
12923         (library_list_end_library, library_list_start_library); Update.
12924         (solib_target_free_library_list): Remove.
12925         (solib_target_parse_libraries): Remove cleanup.  Change return
12926         type.
12927         (solib_target_current_sos): Update.
12928
12929 2019-01-17  Tom Tromey  <tromey@bapiya>
12930
12931         * valprint.c: Replace "the the" with "the".
12932         * symtab.c: Replace "the the" with "the".
12933         * solib.c: Replace "the the" with "the".
12934         * solib-dsbt.c: Replace "the the" with "the".
12935         * linespec.c: Replace "the the" with "the".
12936         * dwarf2loc.h: Replace "the the" with "the".
12937         * amd64-windows-tdep.c: Replace "the the" with "the".
12938         * aarch64-tdep.c: Replace "the the" with "the".
12939
12940 2019-01-16  Keith Seitz  <keiths@redhat.com>
12941
12942         PR gdb/23773
12943         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12944         <builder>: Rename to ..
12945         <m_builder>: ... this and make private.
12946         (dwarf2_cu::get_builder): New method.  Change all users of
12947         `builder' to use this method.
12948         (dwarf2_start_symtab): Move to ...
12949         (dwarf2_cu::start_symtab): ... here.  Update all callers
12950         (setup_type_unit_groups): Move to ...
12951         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12952         callers.
12953         (dwarf2_cu::reset_builder): New method.
12954         (process_full_compunit, process_full_type_unit): Use
12955         dwarf2_cu::reset_builder.
12956         (follow_die_offset): Record the ancestor CU if it is different
12957         from the followed DIE's CU.
12958         (follow_die_sig_1): Likewise.
12959
12960 2019-01-15  Tom Tromey  <tom@tromey.com>
12961
12962         * remote.c (class remote_state) <buf>: Now a char_vector.
12963         <buf_size>: Remove.
12964         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12965         parameter.
12966         (remote_target::getpkt_or_notif_sane_1)
12967         (remote_target::getpkt_sane)
12968         (remote_target::getpkt_or_notif_sane): Likewise.
12969         (class remote_target) <putpkt>: New overload.
12970         (remote_target::read_frame): Change type of "buf_p".  Remove
12971         sizeof_p parameter.
12972         (packet_ok): New overload.
12973         (packet_check_result): New overload.
12974         Update all uses.
12975
12976 2019-01-14  Tom Tromey  <tom@tromey.com>
12977
12978         * remote-notif.c (handle_notification, remote_notif_ack)
12979         (remote_notif_parse): Make "buf" const.
12980         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12981         const.
12982         (remote_notif_parse, remote_notif_ack, handle_notification):
12983         Likewise.
12984         * remote.c (remote_notif_stop_parse): Make "buf" const.
12985         (remote_target::remote_parse_stop_reply): Make "buf" const.
12986         (remote_notif_stop_ack): Make "buf" const.
12987
12988 2019-01-14  Tom Tromey  <tom@tromey.com>
12989
12990         * remote.c (remote_console_output): Make parameter const.
12991
12992 2019-01-14  Tom Tromey  <tom@tromey.com>
12993
12994         * target-debug.h (target_debug_print_signals): Constify.
12995         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12996         * procfs.c (procfs_target::pass_signals): Update.
12997         * linux-nat.c (linux_nat_target::pass_signals): Update.
12998         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12999         * target-delegates.c: Rebuild.
13000         * remote.c (remote_target::program_signals): Update.
13001         (remote_target::pass_signals): Update.
13002         * target.c (target_pass_signals): Constify argument.
13003         (target_program_signals): Likewise.
13004         * target.h (struct target_ops) <pass_signals, program_signals>:
13005         Constify argument.
13006         (target_pass_signals, target_program_signals): Constify argument.
13007
13008 2019-01-14  Tom Tromey  <tom@tromey.com>
13009
13010         PR tui/28819:
13011         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13012
13013 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13014
13015         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13016         field.
13017         * rs6000-tdep.c: Include reggroups.h.
13018         (IS_V_ALIAS_PSEUDOREG): Define.
13019         (rs6000_register_name): Return names for the "vX" aliases.
13020         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13021         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13022         aliases.  Call default_register_reggroup_p for all other
13023         pseudo-registers.
13024         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13025         New functions.
13026         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13027         Handle "vX" aliases.
13028         (v_alias_pseudo_register_collect): New function.
13029         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13030         (rs6000_gdbarch_init): Initialize "vX" aliases as
13031         pseudo-registers.  Restore registration of
13032         rs6000_pseudo_register_reggroup_p with
13033         set_tdesc_pseudo_register_reggroup_p.
13034
13035 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13036
13037         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13038         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13039         set_gdbarch_num_pseudo_regs.
13040
13041 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13042
13043         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13044         Remove arg prefixname, add do_set and do_show.
13045         Add member functions set_list and show_list.
13046         * cli/cli-style.c (class cli_style_option): Update accordingly.
13047         (style_set_list): Move to file scope.
13048         (style_show_list): Likewise.
13049         (set_style): Call help_list.
13050         (show_style): Call cmd_show_list.
13051         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13052         Update to use the new macro.
13053
13054 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13055
13056         * ada-lang.c (_initialize_ada_language): Expand the help text
13057         for the "catch exception" command.
13058
13059 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13060
13061         * symtab.c (matching_obj_sections): Initialize obj,
13062         declare it closer to its usage.
13063
13064 2019-01-10  Tom Tromey  <tom@tromey.com>
13065
13066         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13067         (basic_inf_threads_range): Remove.
13068         (inf_threads_range, inf_non_exited_threads_range)
13069         (safe_inf_threads_range): Use next_adapter.
13070
13071 2019-01-10  Keith Seitz  <keiths@redhat.com>
13072
13073         PR gdb/23712
13074         PR symtab/23010
13075         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13076         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13077
13078 2019-01-10  Keith Seitz  <keiths@redhat.com>
13079
13080         PR gdb/23712
13081         PR symtab/23010
13082         * dictionary.c (pending_to_vector): Remove.
13083         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13084         Remove _1 suffix, replacing functions of the same name.  Update
13085         all callers.
13086         (dict_create_hashed, dict_create_hashed_expandable)
13087         (dict_create_linear, dict_create_linear_expandable, dict_free)
13088         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13089         Make functions static.
13090
13091 2019-01-10  Keith Seitz  <keiths@redhat.com>
13092
13093         PR gdb/23712
13094         PR symtab/23010
13095         * dictionary.h (struct dictionary): Replace declaration with
13096         multidictionary.
13097         (dict_create_hashed, dict_create_hashed_expandable)
13098         (dict_create_linear, dict_create_linear_expandable)
13099         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13100         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13101         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13102         taking multidictionary argument.
13103         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13104         * block.h (struct block) <dict>: Change to multidictionary
13105         and rename `multidict'.
13106         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13107         symmisc.c: Update all dictionary references to multidictionary.
13108
13109 2019-01-10  Keith Seitz  <keiths@redhat.com>
13110
13111         PR gdb/23712
13112         PR symtab/23010
13113         * dictionary.c: Include unordered_map.
13114         (pending_to_vector): New function.
13115         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13116         Rewrite the non-"_1" functions to take vector instead
13117         of linked list.
13118         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13119         "new" _1 versions of the same name.
13120         (multidictionary): Define.
13121         (std::hash<enum language): New definition.
13122         (collate_pending_symbols_by_language, mdict_create_hashed)
13123         (mdict_create_hashed_expandable, mdict_create_linear)
13124         (mdict_create_linear_expandable, mdict_free)
13125         (find_language_dictionary, create_new_language_dictionary)
13126         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13127         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13128         (mdict_size, mdict_empty): New functions.
13129         * dictionary.h (mdict_iterator): Define.
13130
13131 2019-01-10  Pedro Alves  <palves@redhat.com>
13132
13133         * breakpoint.c (read_uploaded_action)
13134         (create_tracepoint_from_upload): Adjust to use
13135         gdb::unique_xmalloc_ptr.
13136         * ctf.c (ctf_write_uploaded_tp):
13137         (SET_ARRAY_FIELD): Use emplace_back.
13138         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13139         * tracefile-tfile.c (tfile_write_uploaded_tp):
13140         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13141         gdb::unique_xmalloc_ptr.
13142         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13143         at_string, cond_string, cmd_strings>: Replace char pointers
13144         with gdb::unique_xmalloc_ptr.
13145
13146 2019-01-10  Pedro Alves  <palves@redhat.com>
13147
13148         * solib-target.c (library_list_start_library): Don't xstrdup name.
13149
13150 2019-01-10  Pedro Alves  <palves@redhat.com>
13151
13152         * mdebugread.c (parse_partial_symbols): Use
13153         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13154
13155 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13156
13157         * linux-fork.c (scoped_switch_fork_info)
13158         <~scoped_switch_fork_info>: Fix incorrect variable name.
13159
13160 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13161
13162         * linux-fork.c (scoped_switch_fork_info)
13163         <scoped_switch_fork_info>: Make explicit.
13164         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13165
13166 2019-01-10  Tom Tromey  <tom@tromey.com>
13167
13168         * objfiles.h (objfile::reset_psymtabs): Update.
13169         * objfiles.c (objfile::objfile): Update.
13170         * psymtab.h (psymtab_storage::obstack): Update.
13171         (psymtab_storage::m_obstack): Use gdb::optional.
13172         (class psymtab_storage): Update comment.  Remove objfile
13173         parameter.
13174         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13175
13176 2019-01-10  Tom Tromey  <tom@tromey.com>
13177
13178         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13179         <free_psymtabs>: Now private.
13180         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13181         (allocate_psymtab): Use new method.
13182
13183 2019-01-10  Tom Tromey  <tom@tromey.com>
13184
13185         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13186         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13187         * mdebugread.c (parse_partial_symbols): Use
13188         allocate_dependencies.
13189         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13190         allocate_dependencies.
13191         (process_psymtab_comp_unit_reader)
13192         (build_type_psymtab_dependencies): Likewise.
13193         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13194
13195 2019-01-10  Tom Tromey  <tom@tromey.com>
13196
13197         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13198         PSYMBOL_SET_LANGUAGE.
13199         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13200
13201 2019-01-10  Tom Tromey  <tom@tromey.com>
13202
13203         * psymtab.h (psymtab_storage::obstack): New method.
13204         <m_obstack>: Rename from obstack; now private.
13205         * psymtab.c (psymtab_storage): Update.
13206         * dwarf2read.c (create_addrmap_from_index)
13207         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13208         Update.
13209
13210 2019-01-10  Tom Tromey  <tom@tromey.com>
13211
13212         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13213         * objfiles.h (objfile::reset_psymtabs): New method.
13214
13215 2019-01-10  Tom Tromey  <tom@tromey.com>
13216
13217         * symmisc.c (print_symbol_bcache_statistics): Update.
13218         (print_objfile_statistics): Update.
13219         * symfile.c (reread_symbols): Update.
13220         * psymtab.h (class psymtab_storage): New.
13221         * psymtab.c (psymtab_storage): New constructor.
13222         (~psymtab_storage): New destructor.
13223         (require_partial_symbols): Update.
13224         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13225         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13226         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13227         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13228         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13229         (start_psymtab_common, end_psymtab_common)
13230         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13231         (allocate_psymtab): Update.
13232         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13233         Update.
13234         (dump_psymtab_addrmap, maintenance_print_psymbols)
13235         (maintenance_check_psymtabs): Update.
13236         (class objfile_psymtabs): Move to objfiles.h.
13237         * psympriv.h (discard_psymtab): Now inline.
13238         (psymtab_discarder::psymtab_discarder): Update.
13239         (psymtab_discarder::~psymtab_discarder): Update.
13240         (ALL_OBJFILE_PSYMTABS): Rewrite.
13241         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13242         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13243         Remove fields.
13244         <partial_symtabs>: New field.
13245         (class objfile_psymtabs): Move from psymtab.h.  Update.
13246         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13247         psymbol_cache.
13248         (objfile::~objfile): Don't destroy psymbol_cache.
13249         * mdebugread.c (parse_partial_symbols): Update.
13250         * dwarf2read.c (create_addrmap_from_index)
13251         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13252         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13253         (add_partial_subprogram, dwarf2_ranges_read): Update.
13254         * dwarf-index-write.c (write_address_map)
13255         (write_one_signatured_type, recursively_write_psymbols)
13256         (class debug_names, class debug_names, write_psymtabs_to_index):
13257         Update.
13258
13259 2019-01-10  Tom Tromey  <tom@tromey.com>
13260
13261         * symtab.h (SYMBOL_SET_NAMES): Update.
13262         (symbol_set_names): Update.
13263         (MSYMBOL_SET_NAMES): Update.
13264         * symtab.c (symbol_set_names): Change argument to be an
13265         objfile_per_bfd_storage.
13266         * psymtab.c (add_psymbol_to_bcache): Update.
13267         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13268
13269 2019-01-10  Tom Tromey  <tom@tromey.com>
13270
13271         * symtab.c (create_demangled_names_hash): Change argument to be an
13272         objfile_per_bfd_storage.
13273         (symbol_set_names): Update.
13274
13275 2019-01-10  Tom Tromey  <tom@tromey.com>
13276
13277         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13278         init_psymbol_list.
13279         * psymtab.c (init_psymbol_list): Do nothing if already called.
13280         * psympriv.h (init_psymbol_list): Add comment.
13281         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13282         init_psymbol_list.
13283         * dbxread.c (dbx_symfile_read): Unconditionally call
13284         init_psymbol_list.
13285
13286 2019-01-10  Tom Tromey  <tom@tromey.com>
13287
13288         * xcoffread.c (scan_xcoff_symtab): Update.
13289         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13290         "where".
13291         * mdebugread.c (parse_partial_symbols)
13292         (handle_psymbol_enumerators): Update.
13293         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13294         * dbxread.c (read_dbx_symtab): Update.
13295         * psympriv.h (psymbol_placement): New enum.
13296         (add_psymbol_to_list): Update.
13297
13298 2019-01-10  Tom Tromey  <tom@tromey.com>
13299
13300         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13301         static_psymbols parameters.
13302         (scan_xcoff_symtab): Update.
13303         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13304         static_psymbols parameters.
13305         * psympriv.h (start_psymtab_common): Update.
13306         * mdebugread.c (parse_partial_symbols): Update.
13307         * dwarf2read.c (create_partial_symtab): Update.
13308         * dbxread.c (read_dbx_symtab): Update.
13309         (start_psymtab): Remove global_psymbols and static_psymbols
13310         parameters.
13311
13312 2019-01-10  Tom Tromey  <tom@tromey.com>
13313
13314         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13315         * psymtab.c (allocate_psymtab): Add comment.
13316         * psympriv.h (allocate_psymtab): Add comment.
13317         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13318         initializations.
13319         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13320
13321 2019-01-10  Tom Tromey  <tom@tromey.com>
13322
13323         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13324         Don't declare.
13325         * mipsread.c: Include mdebugread.h.
13326         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13327         Declare.
13328         * elfread.c: Include mdebugread.h.
13329
13330 2019-01-09  Tom Tromey  <tom@tromey.com>
13331
13332         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13333         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13334         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13335         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13336         (psym_lookup_symbol, psym_find_last_source_symtab)
13337         (psym_forget_cached_source_info, psym_print_stats)
13338         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13339         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13340         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13341         (psym_find_compunit_symtab_by_address)
13342         (maintenance_print_psymbols, maintenance_info_psymtabs)
13343         (maintenance_check_psymtabs): Use ranged for.
13344         * psymtab.h (class objfile_psymtabs): New.
13345         (require_partial_symbols): Return objfile_psymtabs.
13346         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13347
13348 2019-01-09  Tom Tromey  <tom@tromey.com>
13349
13350         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13351         (find_pc_mapped_section, list_overlays_command)
13352         (map_overlay_command, unmap_overlay_command)
13353         (simple_overlay_update): Use all_objfiles.
13354         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13355         * printcmd.c (info_symbol_command): Use all_objfiles.
13356         * objfiles.h (ALL_OBJSECTIONS): Remove.
13357         * maint.c (maintenance_translate_address): Use all_objfiles.
13358         * gcore.c (gcore_create_callback): Use all_objfiles.
13359         (objfile_find_memory_regions): Likewise.
13360
13361 2019-01-09  Tom Tromey  <tom@tromey.com>
13362
13363         * symtab.c (find_line_symtab, info_sources_command)
13364         (make_source_files_completion_list): Use objfile_compunits.
13365         * source.c (select_source_symtab): Use objfile_compunits.
13366         * objfiles.h (struct objfile): Update comment.
13367         (ALL_OBJFILES): Remove.
13368         (ALL_FILETABS): Remove.
13369         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13370         objfile_compunits.
13371
13372 2019-01-09  Tom Tromey  <tom@tromey.com>
13373
13374         * symmisc.c (print_objfile_statistics, dump_objfile)
13375         (maintenance_print_symbols): Use compunit_filetabs.
13376         * source.c (forget_cached_source_info_for_objfile): Use
13377         compunit_filetabs.
13378         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13379         (ALL_FILETABS): Use compunit_filetabs.
13380         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13381         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13382
13383 2019-01-09  Tom Tromey  <tom@tromey.com>
13384
13385         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13386         (compunit_filetabs): New.
13387         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13388         compunit_filetabs.
13389         (info_sources_command, make_source_files_completion_list): Remove
13390         declaration.
13391         * symmisc.c (print_objfile_statistics, dump_objfile)
13392         (maintenance_print_symbols): Remove declaration.
13393         (maintenance_info_symtabs): Use compunit_filetabs.
13394         (maintenance_info_line_tables): Likewise.
13395         * source.c (select_source_symtab): Change local variable name.
13396         (forget_cached_source_info_for_objfile): Remove declaration.
13397         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13398         * objfiles.c (objfile_relocate1): Remove declaration.
13399         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13400         declaration.
13401         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13402         * coffread.c (coff_symtab_read): Remove declaration.
13403         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13404         compunit_filetabs.
13405
13406 2019-01-09  Tom Tromey  <tom@tromey.com>
13407
13408         * symtab.c (lookup_objfile_from_block)
13409         (find_pc_sect_compunit_symtab, search_symbols)
13410         (default_collect_symbol_completion_matches_break_on): Use
13411         objfile_compunits.
13412         * objfiles.h (ALL_COMPUNITS): Remove.
13413         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13414         * cp-support.c (add_symbol_overload_list_qualified): Use
13415         objfile_compunits.
13416         * ada-lang.c (ada_collect_symbol_completion_matches)
13417         (ada_add_global_exceptions): Use objfile_compunits.
13418
13419 2019-01-09  Tom Tromey  <tom@tromey.com>
13420
13421         * source.c (select_source_symtab)
13422         (forget_cached_source_info_for_objfile): Remove declaration.
13423         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13424         declaration.
13425         * maint.c (count_symtabs_and_blocks): Remove declaration.
13426         * cp-support.c (add_symbol_overload_list_qualified): Remove
13427         declaration.
13428         * coffread.c (coff_symtab_read): Remove declaration.
13429         * symtab.c (lookup_symbol_in_objfile_symtabs)
13430         (basic_lookup_transparent_type_1): Use objfile_compunits.
13431         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13432         (info_sources_command, search_symbols)
13433         (default_collect_symbol_completion_matches_break_on)
13434         (make_source_files_completion_list): Remove declaration.
13435         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13436         (ada_collect_symbol_completion_matches)
13437         (ada_add_global_exceptions): Remove declaration.
13438         * linespec.c (iterate_over_all_matching_symtabs): Use
13439         objfile_compunits.
13440         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13441         (class objfile_compunits): New.
13442         (ALL_COMPUNITS): Use objfile_compunits.
13443         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13444         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13445         objfile_compunits.
13446         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13447
13448 2019-01-09  Tom Tromey  <tom@tromey.com>
13449
13450         * symtab.c (search_symbols)
13451         (default_collect_symbol_completion_matches_break_on): Use
13452         objfile_msymbols.
13453         * ada-lang.c (ada_lookup_simple_minsym)
13454         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13455         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13456         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13457         objfile_msymbols.
13458         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13459         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13460         * objc-lang.c (find_methods): Use objfile_msymbols.
13461         (info_selectors_command, info_classes_command): Likewise.
13462         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13463         * objfiles.h (class objfile_msymbols): New.
13464         (ALL_OBJFILE_MSYMBOLS): Remove.
13465         (ALL_MSYMBOLS): Remove.
13466
13467 2019-01-09  Tom Tromey  <tom@tromey.com>
13468
13469         * common/next-iterator.h (next_adapter): Add Iterator template
13470         parameter.
13471         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13472         (class all_objfiles_safe): New.
13473         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13474         * objfiles.c (put_objfile_before): Update comment.
13475         (add_separate_debug_objfile): Likewise.
13476         (free_all_objfiles): Use all_objfiles_safe.
13477         (objfile_purge_solibs): Likewise.
13478
13479 2019-01-09  Tom Tromey  <tom@tromey.com>
13480
13481         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13482         (expand_symtab_containing_pc, lookup_static_symbol)
13483         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13484         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13485         all_objfiles.
13486         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13487         * breakpoint.c (create_overlay_event_breakpoint)
13488         (create_longjmp_master_breakpoint)
13489         (create_std_terminate_master_breakpoint)
13490         (create_exception_master_breakpoint): Use all_objfiles.
13491         * linux-thread-db.c (try_thread_db_load_from_pdir)
13492         (has_libpthread): Use all_objfiles.
13493         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13494         * linespec.c (iterate_over_all_matching_symtabs)
13495         (search_minsyms_for_name): Use all_objfiles.
13496         * maint.c (maintenance_info_sections): Use all_objfiles.
13497         * main.c (captured_main_1): Use all_objfiles.
13498         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13499         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13500         * guile/scm-pretty-print.c
13501         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13502         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13503         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13504         (maintenance_print_msymbols): Use all_objfiles.
13505         * source.c (select_source_symtab): Use all_objfiles.
13506         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13507         * symfile.c (remove_symbol_file_command)
13508         (expand_symtabs_matching, map_symbol_filenames): Use
13509         all_objfiles.
13510         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13511         all_objfiles.
13512         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13513         * objc-lang.c (find_methods): Use all_objfiles.
13514         * objfiles.c (have_partial_symbols, have_full_symbols)
13515         (have_minimal_symbols, qsort_cmp)
13516         (default_iterate_over_objfiles_in_search_order): Use
13517         all_objfiles.
13518         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13519         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13520         (maintenance_check_psymtabs): Use all_objfiles.
13521         (ALL_PSYMTABS): Remove.
13522         * compile/compile-object-run.c (do_module_cleanup): Use
13523         all_objfiles.
13524         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13525         * cp-support.c (add_symbol_overload_list_qualified): Use
13526         all_objfiles.
13527         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13528         Use all_objfiles.
13529         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13530         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13531         all_objfiles.
13532         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13533         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13534         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13535         Uses all_objfiles.
13536         * solib.c (solib_read_symbols): Use all_objfiles
13537
13538 2019-01-09  Tom Tromey  <tom@tromey.com>
13539
13540         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13541         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13542         all_objfiles.
13543         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13544         * symmisc.c (print_symbol_bcache_statistics)
13545         (print_objfile_statistics, maintenance_print_objfiles)
13546         (maintenance_info_symtabs, maintenance_check_symtabs)
13547         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13548         all_objfiles.
13549         * source.c (forget_cached_source_info): Use all_objfiles.
13550         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13551         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13552         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13553         * objfiles.c (update_section_map): Use all_objfiles.
13554         (shared_objfile_contains_address_p): Likewise.
13555         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13556         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13557
13558 2019-01-09  Tom Tromey  <tom@tromey.com>
13559
13560         * common/next-iterator.h: New file.
13561         * objfiles.h (class all_objfiles): New.
13562         (struct objfile_iterator): New.
13563
13564 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13565
13566         * NEWS: Move the description of the changed "frame", "select-frame",
13567          and "info frame" commands to the Changed commands section.
13568
13569 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13570
13571         * gdbtypes.c (check_stub_method_group): Remove handling of old
13572         mangling schemes.
13573         * linespec.c (find_methods): Likewise.
13574         * stabsread.c (read_member_functions): Likewise.
13575         * valops.c (search_struct_method): Likewise.
13576         (value_struct_elt_for_reference): Likewise.
13577         * NEWS: Mention this change.
13578
13579 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13580
13581         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13582         print_source_lines.
13583         * source.c (print_source_lines_base): Update line number check.
13584         (print_source_lines): New function.
13585         (source_lines_range::source_lines_range): New function.
13586         * source.h (class source_lines_range): New class.
13587         (print_source_lines): New declaration.
13588
13589 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13590
13591         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13592
13593 2019-01-08  Tom Tromey  <tom@tromey.com>
13594             Simon Marchi  <simon.marchi@ericsson.com>
13595
13596         PR gdb/24060
13597         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13598         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13599         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13600         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13601         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13602         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13603
13604 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13605
13606         * source.c (select_source_symtab): Move header comment to
13607         declaration in source.h.
13608         (forget_cached_source_info_for_objfile): Likewise.
13609         (forget_cached_source_info): Likewise.
13610         (identify_source_line): Likewise.
13611         * source.h (identify_source_line): Move declaration from symtab.h
13612         and add comment from source.c
13613         (print_source_lines): Likewise.
13614         (forget_cached_source_info_for_objfile): Likewise.
13615         (forget_cached_source_info): Likewise.
13616         (select_source_symtab): Likewise.
13617         (enum print_source_lines_flag): Move definition from symtab.h.
13618         * symtab.h (identify_source_line): Move declaration to source.h.
13619         (print_source_lines): Likewise.
13620         (forget_cached_source_info_for_objfile): Likewise.
13621         (forget_cached_source_info): Likewise.
13622         (select_source_symtab): Likewise.
13623         (enum print_source_lines_flag): Move definition to source.h.
13624         * tui/tui-hooks.c: Add 'source.h' include.
13625
13626 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13627
13628         * source.c (print_source_lines_base): Handle requests to print
13629         reverse line number sequences, and guard against empty lines
13630         string.
13631
13632 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13633
13634         * source.c (print_source_lines_base): Fix skip of '\r' if next
13635         character is '\n'.
13636
13637 2019-01-06  Tom Tromey  <tom@tromey.com>
13638
13639         * c-exp.y (struct c_parse_state) <macro_original_text,
13640         expansion_obstack>: New member.
13641         (macro_original_text, expansion_obstack): Remove globals.
13642         (scan_macro_expansion, scanning_macro_expansion)
13643         (finished_macro_expansion): Update.
13644         (scan_macro_cleanup): Remove.
13645         (yylex, c_parse): Update.
13646
13647 2019-01-06  Tom Tromey  <tom@tromey.com>
13648
13649         * c-exp.y (struct c_parse_state) <strings>: New member.
13650         (operator_stoken): Update.
13651
13652 2019-01-06  Tom Tromey  <tom@tromey.com>
13653
13654         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13655         (union type_stack_elt) <typelist_val>: Now a pointer to
13656         std::vector.
13657         (type_stack_cleanup): Don't declare.
13658         (push_typelist): Update.
13659         * parse.c (pop_typelist): Return a std::vector.
13660         (push_typelist): Take a std::vector.
13661         (follow_types): Update.  Do not free args.
13662         (type_stack_cleanup): Remove.
13663         * c-exp.y (struct c_parse_state): New.
13664         (cpstate): New global.
13665         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13666         (nonempty_typelist): Update.
13667         (func_mod): Create a new vector.
13668         (c_parse): Create a c_parse_state.
13669         (check_parameter_typelist): Do not delete params.
13670         (function_method): Update.  Do not delete type_list.
13671
13672 2019-01-06  Tom Tromey  <tom@tromey.com>
13673
13674         PR gdb/28155:
13675         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13676         check_typedef.
13677         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13678         (print_return_value): Likewise.
13679
13680 2019-01-05  Tom Tromey  <tom@tromey.com>
13681
13682         * contrib/cleanup_check.py: Remove.
13683         * contrib/gcc-with-excheck: Remove.
13684         * contrib/exsummary.py: Remove.
13685         * contrib/excheck.py: Remove.
13686
13687 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13688
13689         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13690         NULL. Initialize tpprev to NULL instead of assigning it
13691         to NULL on the next statement.
13692         * windows-nat.c (windows_delete_thread): Remove check for
13693         main_thread_id before printing thread exit notifications.
13694         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13695         Remove thread ID check against main_thread_id.
13696         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13697         windows_delete_thread.
13698         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13699
13700 2019-01-04  Tom Tromey  <tom@tromey.com>
13701
13702         * compile/compile.c (_initialize_compile): Use upper case for
13703         metasyntactic variables.
13704         * symmisc.c (_initialize_symmisc): Use upper case for
13705         metasyntactic variables.
13706         * psymtab.c (_initialize_psymtab): Use upper case for
13707         metasyntactic variables.
13708         * demangle.c (demangle_command): Use upper case for metasyntactic
13709         variables.
13710         (_initialize_demangler): Likewise.
13711         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13712         variables.
13713
13714 2019-01-03  Tom Tromey  <tom@tromey.com>
13715
13716         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13717
13718 2019-01-03  Tom Tromey  <tom@tromey.com>
13719
13720         * python/py-symtab.c (salpy_str): Update.
13721         (struct salpy_sal_object) <symtab>: Now a PyObject.
13722         (salpy_dealloc): Update.
13723         (del_objfile_sal): Use gdbpy_ref.
13724
13725 2019-01-03  Tom Tromey  <tom@tromey.com>
13726
13727         * python/py-type.c (convert_field): Use new_reference.  Return
13728         gdbpy_ref.
13729         (make_fielditem): Return gdbpy_ref.
13730         (typy_fields): Update.
13731         (typy_getitem): Update.
13732         (field_name): Return gdbpy_ref.  Use new_reference.
13733         (typy_iterator_iternext): Update.
13734
13735 2019-01-03  Tom Tromey  <tom@tromey.com>
13736
13737         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13738
13739 2019-01-03  Tom Tromey  <tom@tromey.com>
13740
13741         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13742         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13743         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13744         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13745         (pspy_set_type_printers): Likewise.
13746         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13747         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13748         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13749         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13750         (objfpy_set_type_printers): Likewise.
13751
13752 2019-01-03  Tom Tromey  <tom@tromey.com>
13753
13754         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13755         (gdbpy_print_stack): Use gdbpy_err_fetch.
13756         * python/python-internal.h (class gdbpy_err_fetch): New class.
13757         (class gdbpy_enter) <m_error_type, m_error_value,
13758         m_error_traceback>: Remove.
13759         <m_error>: New member.
13760         (gdbpy_exception_to_string): Don't declare.
13761         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13762         * python/py-value.c (convert_value_from_python): Use
13763         gdbpy_err_fetch.
13764         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13765         gdbpy_exception_to_string.
13766         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13767         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13768         gdbpy_err_fetch.
13769
13770 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13771
13772         * linux-nat.c (delete_lwp_cleanup): Delete.
13773         (struct lwp_deleter): New struct.
13774         (lwp_info_up): New typedef.
13775         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13776         lwp_info_up.
13777
13778 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13779
13780         * linux-fork.c (class scoped_switch_fork_info): New class.
13781         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13782
13783 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13784
13785         * valops.c (find_overload_match): Remove use of null_cleanup, and
13786         calls to do_cleanups.
13787
13788 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13789
13790         * compile/compile-cplus-types.c
13791         (compile_cplus_instance::decl_name): Handle changes to
13792         cp_func_name.
13793         * cp-support.c (cp_func_name): Update header comment, update
13794         return type.
13795         * cp-support.h (cp_func_name): Update return type in declaration.
13796         * valops.c (find_overload_match): Move temp_func local to top
13797         level of function and change its type.  Use temp_func to hold and
13798         delete temporary string obtained from cp_func_name.
13799
13800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13801
13802         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13803         gdb::char_vector, remove cleanup, and update uses of `msg`.
13804
13805 2019-01-03  Jim Wilson  <jimw@sifive.com>
13806
13807         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13808
13809 2019-01-02  Tom Tromey  <tom@tromey.com>
13810
13811         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13812         (tdesc_parse_xml): Remove cleanups.
13813         * target-descriptions.h (make_cleanup_free_target_description):
13814         Don't declare.
13815         (target_desc_deleter): New struct.
13816         (target_desc_up): New typedef.
13817         * target-descriptions.c (target_desc_deleter::operator()): Rename
13818         from free_target_description.
13819         (make_cleanup_free_target_description): Remove.
13820
13821 2019-01-02  Tom Tromey  <tom@tromey.com>
13822
13823         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13824         constructor, destructor.
13825         (linespec_parser): Remove typedef.
13826         (~linespec_parser): Rename from linespec_parser_delete.
13827         (linespec_lex_to_end, linespec_complete_label)
13828         (linespec_complete): Update.
13829         (decode_line_full): Remove cleanups.
13830         (decode_line_1): Update.
13831
13832 2019-01-02  Tom Tromey  <tom@tromey.com>
13833
13834         * python/python-internal.h (inferior_to_inferior_object): Change
13835         return type.
13836         * python/py-exitedevent.c (create_exited_event_object): Update.
13837         * python/py-inferior.c (inferior_to_inferior_object): Return
13838         gdbpy_ref.
13839         (python_new_inferior, python_inferior_deleted)
13840         (thread_to_thread_object, delete_thread_object)
13841         (build_inferior_list, gdbpy_selected_inferior): Update.
13842         * python/py-infthread.c (create_thread_object): Update.  Also fail
13843         if inferior_to_inferior_object fails.
13844
13845 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13846
13847         * inferior.h (class inferior) <displaced_step_state>: New field.
13848         * infrun.h (struct displaced_step_state): Move here from
13849         infrun.c.  Initialize fields, add constructor.
13850         <inf>: Remove field.
13851         <reset>: New method.
13852         * infrun.c (struct displaced_step_inferior_state): Move to
13853         infrun.h.
13854         (displaced_step_inferior_states): Remove.
13855         (get_displaced_stepping_state): Adust.
13856         (displaced_step_in_progress_any_inferior): Adjust.
13857         (displaced_step_in_progress_thread): Adjust.
13858         (displaced_step_in_progress): Adjust.
13859         (add_displaced_stepping_state): Remove.
13860         (get_displaced_step_closure_by_addr): Adjust.
13861         (remove_displaced_stepping_state): Remove.
13862         (infrun_inferior_exit): Call displaced_step_state.reset.
13863         (use_displaced_stepping): Don't check for NULL.
13864         (displaced_step_prepare_throw): Call
13865         get_displaced_stepping_state.
13866         (displaced_step_fixup): Don't check for NULL.
13867         (prepare_for_detach): Don't check for NULL.
13868
13869 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13870
13871         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13872          in case of call that did not complete.
13873
13874 2019-01-02  Andrey Utkin  <autkin@undo.io>
13875
13876         * symfile.c (find_separate_debug_file): Fix search of debug files for
13877         remote debuggee.
13878
13879 2019-01-02  Tom Tromey  <tom@tromey.com>
13880
13881         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13882         indentation.
13883         * python/py-frame.c (frapy_older): Remove cast.
13884         (frapy_newer): Likewise.
13885         * python/py-breakpoint.c (local_setattro): Remove cast.
13886         * python/py-arch.c (archpy_name): Remove local variable.
13887         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13888
13889 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13890
13891         * unittests/basic_string_view/element_access/char/empty.cc:
13892         Fix year range in copyright header.
13893
13894 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13895
13896         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13897         Delete.
13898         <operator==>: Update with for removed field.
13899         <hash>: Likewise.
13900         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13901         <isa_features>: ...this.
13902         <abi_features>: New field.
13903         (riscv_isa_flen): Update comment.
13904         (riscv_abi_xlen): New declaration.
13905         (riscv_abi_flen): New declaration.
13906         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13907         isa_features.
13908         (riscv_abi_xlen): New function.
13909         (riscv_isa_flen): Update to get answer from isa_features.
13910         (riscv_abi_flen): New function.
13911         (riscv_has_fp_abi): Update to get answer from abi_features.
13912         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13913         xlen and flen.
13914         (riscv_call_info) <xlen, flen>: Update comment.
13915         (riscv_call_arg_struct): Remove invalid assertions
13916         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13917         is removed.
13918         (riscv_gdbarch_init): Gather isa features and abi features
13919         separately, ensure both match on the gdbarch when reusing an old
13920         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13921         a target with 64-bit float hardware.
13922
13923 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13924
13925         * source.c (search_command_helper): Stop reverse search
13926         when line 1 has been searched.
13927
13928 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13929
13930         * record-full.c (record_full_base_target::close): Rewrite
13931         record_full_core_buf_list free logic.
13932
13933 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13934
13935         * break-catch-syscall.c (print_one_catch_syscall): xfree
13936         the last text.
13937
13938 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13939
13940         * top.c (print_gdb_version): Update Copyright year in version
13941         message.
13942
13943 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13944
13945         Update copyright year range in all GDB files.
13946
13947 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13948
13949         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13950
13951 For older changes see ChangeLog-2018.
13952 \f
13953 Local Variables:
13954 mode: change-log
13955 left-margin: 8
13956 fill-column: 74
13957 version-control: never
13958 coding: utf-8
13959 End:
13960