gdb/ChangeLog

   1 2019-03-18  Pedro Alves  <palves@redhat.com>
   2
   3         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
   4         New globals.
   5         (apply_style): New, factored out from ...
   6         (apply_ansi_escape): ... this.  Handle reverse video mode.
   7         (tui_set_reverse_mode): New function.
   8         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
   9         * tui/tui-winsource.c (tui_show_source_line): Use
  10         tui_set_reverse_mode instead of setting A_STANDOUT.
  11         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
  12         New setter methods.
  13
  14 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
  15
  16         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
  17         Handle tabs.
  18
  19 2019-03-18  Tom Tromey  <tromey@adacore.com>
  20
  21         * ada-lang.c (empty_array): Add "high" parameter.
  22         (ada_evaluate_subexp): Update.
  23
  24 2019-03-17  Sergei Trofimovich <siarheit@google.com>
  25
  26         * unittests/string_view-selftests.c: Define
  27         _initialize_string_view_selftests unconditionally.
  28
  29 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  30
  31         PR gdb/24350
  32         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
  33
  34 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
  35
  36         PR gdb/24351
  37         * windows-nat.c (display_selector): Fix format specifiers.
  38
  39 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
  40
  41         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
  42         tui_refill_source_window instead of tui_refresh_win, to update the
  43         current execution line.  This fixes redisplay of the current line
  44         when stepping through the code with "next" or "step".
  45
  46 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  47
  48         * source-cache.c (source_cache::get_source_lines): Call
  49         find_source_lines to initialize s->nlines.  This fixes vertical
  50         scrolling of TUI source window when the DOWN arrow is pressed.
  51
  52 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  53
  54         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
  55         linux-thread-db.c (_initialize_thread_db): Likewise.
  56
  57 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
  58
  59         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
  60         wclrtoeol in tui_show_source_line".  This reverts changes made in
  61         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
  62
  63 2019-03-15  Tom Tromey  <tom@tromey.com>
  64
  65         * symtab.h (struct minimal_symbol): Derive from
  66         general_symbol_info.
  67         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
  68         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
  69         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
  70         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
  71         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
  72         (MSYMBOL_SEARCH_NAME): Update.
  73         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
  74         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
  75         * minsyms.c (minimal_symbol_reader::record_full): Update.
  76
  77 2019-03-15  Tom Tromey  <tom@tromey.com>
  78
  79         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
  80
  81 2019-03-15  Tom Tromey  <tom@tromey.com>
  82
  83         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
  84         unique_xmalloc_ptr.
  85         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
  86         Update.
  87         * minsyms.c (lookup_minimal_symbol_by_pc_section)
  88         (build_minimal_symbol_hash_tables)
  89         (minimal_symbol_reader::install): Update.
  90
  91 2019-03-15  Tom Tromey  <tom@tromey.com>
  92
  93         * symtab.c (create_demangled_names_hash): Update.
  94         (symbol_set_names): Update.
  95         * objfiles.h (struct objfile_per_bfd_storage)
  96         <demangled_names_hash>: Now an htab_up.
  97         * objfiles.c (objfile_per_bfd_storage): Simplify.
  98
  99 2019-03-15  Tom Tromey  <tom@tromey.com>
 100
 101         * objfiles.h (struct objfile_per_bfd_storage): Declare
 102         destructor.
 103         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
 104         New.
 105         (get_objfile_bfd_data): Use new.  Don't initialize
 106         language_of_main.
 107         (free_objfile_per_bfd_storage): Remove.
 108         (objfile_bfd_data_free, objfile::~objfile): Use delete.
 109
 110 2019-03-15  Tom Tromey  <tom@tromey.com>
 111
 112         * symfile.c (reread_symbols): Update.
 113         * objfiles.c (objfile::objfile): Update.
 114         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
 115         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
 116         comment.
 117         (minimal_symbol_reader::install): Update.
 118         (terminate_minimal_symbol_table): Remove.
 119         * jit.c (jit_object_close_impl): Update.
 120
 121 2019-03-15  Tom Tromey  <tom@tromey.com>
 122
 123         * minsyms.c (minimal_symbol_reader::record_full): Remove some
 124         initializations.
 125
 126 2019-03-15  Tom Tromey  <tom@tromey.com>
 127
 128         * objfiles.h (struct objfile_per_bfd_storage)
 129         <demangled_hash_languages>: Now a bitset.
 130         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 131         (lookup_minimal_symbol): Update.
 132
 133 2019-03-15  Tom Tromey  <tom@tromey.com>
 134
 135         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
 136         Don't return the symbol.
 137         * coffread.c (record_minimal_symbol): Use record_full.
 138
 139 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
 140
 141         The MS-Windows port of ncurses fails to switch to a color pair if
 142         one or both of the colors are the implicit default colors.  This
 143         change records the default colors when TUI is initialized, and
 144         then specifies them explicitly when a color pair uses the default
 145         colors.  This allows color styling in TUI mode on MS-Windows.
 146
 147         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
 148         ncurses_norm_attr.
 149         (tui_initialize_io) [__MINGW32__]: Record the default terminal
 150         colors in ncurses_norm_attr.
 151         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
 152         "none", replace it with the default color recorded in
 153         ncurses_norm_attr.
 154
 155 2019-03-14  Tom Tromey  <tromey@adacore.com>
 156
 157         * source-cache.h (class source_cache) <get_source_lines>: Return
 158         std::string.
 159         * source-cache.c (source_cache::extract_lines): Handle case where
 160         first_pos==npos.  Return std::string.
 161         (source_cache::get_source_lines): Update.
 162
 163 2019-03-14  Tom Tromey  <tromey@adacore.com>
 164
 165         * NEWS: Add item for "style sources" commands.
 166         * source-cache.c (source_cache::get_source_lines): Check
 167         source_styling.
 168         * cli/cli-style.c (source_styling): New global.
 169         (_initialize_cli_style): Add "style sources" commands.
 170         (show_style_sources): New function.
 171         * cli/cli-style.h (source_styling): Declare.
 172
 173 2019-03-14  Pedro Alves  <palves@redhat.com>
 174             Tom Tromey  <tromey@adacore.com>
 175
 176         * tui/tui-winsource.h (tui_refill_source_window): Declare.
 177         * tui/tui-winsource.c (tui_refill_source_window): New function,
 178         from...
 179         (tui_horizontal_source_scroll): ... here.  Move some logic.
 180         * cli/cli-style.c (set_style_enabled): Notify new observable.
 181         * tui/tui-hooks.c (tui_redisplay_source): New function.
 182         (tui_attach_detach_observers): Attach or detach
 183         tui_redisplay_source.
 184         * observable.h (source_styling_changed): New observable.
 185         * observable.c: Define source_styling_changed observable.
 186
 187 2019-03-13  Tom Tromey  <tromey@adacore.com>
 188
 189         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
 190         (i386_gnu_nat_target::store_registers): Update.
 191         * target-debug.h (target_debug_print_std_string): New macro.
 192         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 193         * windows-tdep.c (display_one_tib): Update.
 194         * tui/tui-stack.c (tui_make_status_line): Update.
 195         * top.c (print_inferior_quit_action): Update.
 196         * thread.c (thr_try_catch_cmd): Update.
 197         (add_thread_with_info): Update.
 198         (thread_target_id_str): Update.
 199         (thr_try_catch_cmd): Update.
 200         (thread_command): Update.
 201         (thread_find_command): Update.
 202         * record-btrace.c (record_btrace_target::info_record)
 203         (record_btrace_resume_thread, record_btrace_target::resume)
 204         (record_btrace_cancel_resume, record_btrace_step_thread)
 205         (record_btrace_target::wait, record_btrace_target::wait)
 206         (record_btrace_target::wait, record_btrace_target::stop): Update.
 207         * progspace.c (print_program_space): Update.
 208         * process-stratum-target.c
 209         (process_stratum_target::thread_address_space): Update.
 210         * linux-fork.c (linux_fork_mourn_inferior)
 211         (detach_checkpoint_command, info_checkpoints_command)
 212         (linux_fork_context): Update.
 213         (linux_fork_detach): Update.
 214         (class scoped_switch_fork_info): Update.
 215         (delete_checkpoint_command): Update.
 216         * infrun.c (follow_fork_inferior): Update.
 217         (follow_fork_inferior): Update.
 218         (proceed_after_vfork_done): Update.
 219         (handle_vfork_child_exec_or_exit): Update.
 220         (follow_exec): Update.
 221         (displaced_step_prepare_throw): Update.
 222         (displaced_step_restore): Update.
 223         (start_step_over): Update.
 224         (resume_1): Update.
 225         (clear_proceed_status_thread): Update.
 226         (proceed): Update.
 227         (print_target_wait_results): Update.
 228         (do_target_wait): Update.
 229         (context_switch): Update.
 230         (stop_all_threads): Update.
 231         (restart_threads): Update.
 232         (finish_step_over): Update.
 233         (handle_signal_stop): Update.
 234         (switch_back_to_stepped_thread): Update.
 235         (keep_going_pass_signal): Update.
 236         (print_exited_reason): Update.
 237         (normal_stop): Update.
 238         * inferior.c (inferior_pid_to_str): Change return type.
 239         (print_selected_inferior): Update.
 240         (add_inferior): Update.
 241         (detach_inferior): Update.
 242         * dummy-frame.c (fprint_dummy_frames): Update.
 243         * dcache.c (dcache_info_1): Update.
 244         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
 245         (btrace_fetch, btrace_clear): Update.
 246         * linux-tdep.c (linux_core_pid_to_str): Change return type.
 247         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
 248         type.
 249         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
 250         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
 251         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
 252         * gdbarch.c, gdbarch.h: Rebuild.
 253         * gdbarch.sh (core_pid_to_str): Change return type.
 254         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
 255         return type.
 256         (windows_nat_target::pid_to_str): Change return type.
 257         (windows_delete_thread): Update.
 258         (windows_nat_target::attach): Update.
 259         (windows_nat_target::files_info): Update.
 260         * target-delegates.c: Rebuild.
 261         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
 262         return type.
 263         (sol_thread_target::pid_to_str): Change return type.
 264         * remote.c (class remote_target) <pid_to_str>: Change return
 265         type.
 266         (remote_target::pid_to_str): Change return type.
 267         (extended_remote_target::attach, remote_target::remote_stop_ns)
 268         (remote_target::remote_notif_remove_queued_reply)
 269         (remote_target::push_stop_reply, remote_target::disable_btrace):
 270         Update.
 271         (extended_remote_target::attach): Update.
 272         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
 273         type.
 274         (gdbsim_target::pid_to_str): Change return type.
 275         * ravenscar-thread.c (struct ravenscar_thread_target)
 276         <pid_to_str>: Change return type.
 277         (ravenscar_thread_target::pid_to_str): Change return type.
 278         * procfs.c (class procfs_target) <pid_to_str>: Change return
 279         type.
 280         (procfs_target::pid_to_str): Change return type.
 281         (procfs_target::attach): Update.
 282         (procfs_target::detach): Update.
 283         (procfs_target::fetch_registers): Update.
 284         (procfs_target::store_registers): Update.
 285         (procfs_target::wait): Update.
 286         (procfs_target::files_info): Update.
 287         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
 288         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
 289         return type.
 290         (nto_procfs_target::pid_to_str): Change return type.
 291         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
 292         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
 293         return type.
 294         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
 295         (exit_lwp): Update.
 296         (attach_proc_task_lwp_callback, get_detach_signal)
 297         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
 298         (linux_nat_target::resume, wait_lwp, stop_callback)
 299         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
 300         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
 301         (linux_nat_wait_1, resume_stopped_resumed_lwps)
 302         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
 303         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
 304         type.
 305         (inf_ptrace_target::attach): Update.
 306         (inf_ptrace_target::files_info): Update.
 307         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
 308         type.
 309         (go32_nat_target::pid_to_str): Change return type.
 310         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
 311         (gnu_nat_target::wait): Update.
 312         (gnu_nat_target::wait): Update.
 313         (gnu_nat_target::resume): Update.
 314         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
 315         (fbsd_nat_target::wait): Update.
 316         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
 317         type.
 318         (darwin_nat_target::attach): Update.
 319         * corelow.c (class core_target) <pid_to_str>: Change return type.
 320         (core_target::pid_to_str): Change return type.
 321         * target.c (normal_pid_to_str): Change return type.
 322         (default_pid_to_str): Likewise.
 323         (target_pid_to_str): Change return type.
 324         (target_translate_tls_address): Update.
 325         (target_announce_detach): Update.
 326         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
 327         return type.
 328         (bsd_uthread_target::pid_to_str): Change return type.
 329         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
 330         type.
 331         (bsd_kvm_target::pid_to_str): Change return type.
 332         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
 333         return type.
 334         (aix_thread_target::pid_to_str): Change return type.
 335         * target.h (struct target_ops) <pid_to_str>: Change return type.
 336         (target_pid_to_str, normal_pid_to_str): Likewise.
 337         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
 338         type.
 339         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
 340         type.
 341         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
 342         return type.
 343         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
 344         type.
 345         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
 346         type.
 347         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
 348         return type.
 349
 350 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
 351
 352         * NEWS: Mention that the new default MI version is 3.  Mention
 353         changes to the output of commands and events that deal with
 354         multi-location breakpoints.
 355         * breakpoint.c: Include "mi/mi-out.h".
 356         (print_one_breakpoint): Change output syntax if using MI version
 357         >= 3.
 358         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
 359         New.
 360         (mi_multi_location_breakpoint_output_fixed): New.
 361         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
 362         (mi_cmd_fix_multi_location_breakpoint_output): New.
 363         (mi_multi_location_breakpoint_output_fixed): New.
 364         * mi/mi-cmds.c (mi_cmds): Register command
 365         -fix-multi-location-breakpoint-output.
 366         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
 367         interpreter "mi".
 368
 369 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
 370
 371         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
 372         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
 373         instantiate mi_ui_out based on interpreter name.
 374         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
 375         * mi/mi-main.c (mi_load_progress): Likewise.
 376
 377 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 378
 379         * NEWS: Combine separate "New targets" sections for 8.3.
 380
 381 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 382
 383         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
 384         (ppcfbsd_init_abi): Install gdbarch
 385         "fetch_tls_load_module_address" and "get_thread_local_address"
 386         methods.
 387
 388 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 389
 390         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
 391         (riscv_fbsd_init_abi): Install gdbarch
 392         "fetch_tls_load_module_address" and "get_thread_local_address"
 393         methods.
 394
 395 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 396
 397         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
 398         (i386fbsd_init_abi): Install gdbarch
 399         "fetch_tls_load_module_address" and "get_thread_local_address"
 400         methods.
 401
 402 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 403
 404         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
 405         (amd64fbsd_init_abi): Install gdbarch
 406         "fetch_tls_load_module_address" and "get_thread_local_address"
 407         methods.
 408
 409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 410
 411         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
 412         (struct fbsd_pspace_data): New type.
 413         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
 414         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
 415         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
 416         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
 417         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
 418
 419 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 420
 421         * gdbtypes.c (lookup_struct_elt): New function.
 422         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
 423         * gdbtypes.h (struct struct_elt): New type.
 424         (lookup_struct_elt): New prototype.
 425
 426 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 427
 428         * gdbtypes.c (lookup_struct_elt_type): Update comment and
 429         remove disabled code block.
 430
 431 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 432
 433         * gdbarch.sh (get_thread_local_address): New method.
 434         * gdbarch.h, gdbarch.c: Regenerate.
 435         * target.c (target_translate_tls_address): Use
 436         gdbarch_get_thread_local_address if present instead of
 437         target::get_thread_local_address.
 438
 439 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 440
 441         * target.h (target::get_thread_local_address): Update comment.
 442
 443 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 444
 445         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
 446         objfile->separate_debug_objfile_backlink if not NULL.
 447
 448 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 449
 450         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
 451         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
 452         (amd64bsd_store_inferior_registers): Likewise.
 453         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 454         Enable segment base registers.
 455         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
 456         PT_GETFSBASE and PT_GETGSBASE.
 457         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
 458         PT_SETGSBASE.
 459         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
 460         segment base registers.
 461         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 462
 463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
 464
 465         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
 466         Update calls to i386_target_description to add 'segments'
 467         parameter.
 468         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
 469         add segment base registers.
 470         * arch/i386.c (i386_create_target_description): Add 'segments'
 471         parameter to enable segment base registers.
 472         * arch/i386.h (i386_create_target_description): Likewise.
 473         * features/i386/32bit-segments.xml: New file.
 474         * features/i386/32bit-segments.c: Generate.
 475         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
 476         call to i386_target_description to add 'segments' parameter.
 477         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
 478         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
 479         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
 480         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
 481         if feature is present.
 482         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
 483         Add 'segments' parameter to call to i386_target_description.
 484         (i386_target_description): Add 'segments' parameter to enable
 485         segment base registers.
 486         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
 487         to call to i386_target_description.
 488         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
 489         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
 490         Define I386_NUM_REGS.
 491         (i386_target_description): Add 'segments' parameter to enable
 492         segment base registers.
 493
 494 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
 495
 496         PR/24325
 497         * source-cache.c: #undef open and close, to avoid unresolved
 498         externals during linking.
 499
 500 2019-03-12  Tom Tromey  <tromey@adacore.com>
 501
 502         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
 503         const.  Add initializers.
 504         (_initialize_remote): Don't initialize ptid globals.
 505
 506 2019-03-12  Pedro Alves  <palves@redhat.com>
 507
 508         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
 509
 510 2019-03-12  Pedro Alves  <palves@redhat.com>
 511
 512         * cp-name-parser.y (main): Remove unused 'len' variable.
 513
 514 2019-03-12  Tom Tromey  <tromey@adacore.com>
 515
 516         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
 517         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
 518
 519 2019-03-12  Tom Tromey  <tromey@adacore.com>
 520
 521         * linux-nat.c (iterate_over_lwps): Update.
 522         (stop_callback): Remove parameter.
 523         (stop_wait_callback, detach_callback, resume_set_callback)
 524         (select_singlestep_lwp_callback, set_ignore_sigint)
 525         (status_callback, resumed_callback, resume_clear_callback)
 526         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
 527         data parameter.
 528         (linux_nat_target::detach, linux_nat_target::resume)
 529         (linux_stop_and_wait_all_lwps, select_event_lwp)
 530         (linux_nat_filter_event, linux_nat_wait_1)
 531         (linux_nat_target::kill, linux_nat_target::stop)
 532         (linux_nat_target::stop): Update.
 533         (linux_nat_resume_callback): Change type.
 534         (resume_stopped_resumed_lwps, count_events_callback)
 535         (select_event_lwp_callback): Likewise.
 536         (linux_stop_lwp, linux_nat_stop_lwp): Update.
 537         * arm-linux-nat.c (struct update_registers_data): Remove.
 538         (update_registers_callback): Change type.
 539         (arm_linux_insert_hw_breakpoint1): Update.
 540         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
 541         parameter.
 542         (x86_linux_dr_set_addr): Update.
 543         (x86_linux_dr_set_control): Update.
 544         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
 545         (iterate_over_lwps): Use gdb::function_view.
 546         * nat/aarch64-linux-hw-point.c (struct
 547         aarch64_dr_update_callback_param): Remove.
 548         (debug_reg_change_callback): Change type.
 549         (aarch64_notify_debug_reg_change): Update.
 550         * s390-linux-nat.c (s390_refresh_per_info): Update.
 551
 552 2019-03-11  Tom Tromey  <tromey@adacore.com>
 553
 554         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
 555         redundant assignment to "this_cu".
 556
 557 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 558
 559         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
 560
 561 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 562
 563         * gdbtypes.c (rank_one_type_parm_set): New function extracted
 564         from...
 565         (rank_one_type): ... this.
 566
 567 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 568
 569         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
 570         from...
 571         (rank_one_type): ... this.
 572
 573 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 574
 575         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
 576         from...
 577         (rank_one_type): ... this.
 578
 579 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 580
 581         * gdbtypes.c (rank_one_type_parm_float): New function extracted
 582         from...
 583         (rank_one_type): ... this.
 584
 585 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 586
 587         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
 588         from...
 589         (rank_one_type): ... this.
 590
 591 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 592
 593         * gdbtypes.c (rank_one_type_parm_range): New function extracted
 594         from...
 595         (rank_one_type): ... this.
 596
 597 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 598
 599         * gdbtypes.c (rank_one_type_parm_char): New function extracted
 600         from...
 601         (rank_one_type): ... this.
 602
 603 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 604
 605         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
 606         from...
 607         (rank_one_type): ... this.
 608
 609 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 610
 611         * gdbtypes.c (rank_one_type_parm_int): New function extracted
 612         from...
 613         (rank_one_type): ... this.
 614
 615 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 616
 617         * gdbtypes.c (rank_one_type_parm_func): New function extracted
 618         from...
 619         (rank_one_type): ... this.
 620
 621 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 622
 623         * gdbtypes.c (rank_one_type_parm_array): New function extracted
 624         from...
 625         (rank_one_type): ... this.
 626
 627 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
 628
 629         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
 630         from...
 631         (rank_one_type): ... this.
 632
 633 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 634
 635         * inferior.c (initialize_inferiors): Ensure 'help set/show print
 636         inferior-events' shows the example events.
 637
 638 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
 639
 640         Support styling on native MS-Windows console
 641
 642         PR/24315
 643         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
 644         on MS-Windows if $TERM is not defined.
 645
 646         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
 647
 648         * posix-hdep.c (gdb_console_fputs):
 649         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
 650         functions.
 651         * ui-file.h (gdb_console_fputs): Add prototype.
 652
 653         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
 654         back to fputs only if the former returns zero.
 655
 656 2019-03-07  Tom Tromey  <tom@tromey.com>
 657
 658         * symmisc.c (print_symbol_bcache_statistics): Update.
 659         (print_objfile_statistics): Update.
 660         * symfile.c (allocate_symtab): Update.
 661         * stabsread.c: Don't include bcache.h.
 662         * psymtab.h (struct psymbol_bcache): Don't declare.
 663         (class psymtab_storage) <psymbol_cache>: Now a bcache.
 664         (psymbol_bcache_init, psymbol_bcache_free)
 665         (psymbol_bcache_get_bcache): Don't declare.
 666         * psymtab.c (struct psymbol_bcache): Remove.
 667         (psymtab_storage::psymtab_storage): Update.
 668         (psymtab_storage::~psymtab_storage): Update.
 669         (psymbol_bcache_init, psymbol_bcache_free)
 670         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
 671         (add_psymbol_to_bcache): Update.
 672         (allocate_psymtab): Update.
 673         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
 674         macro_cache>: No longer pointers.
 675         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
 676         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
 677         * macrotab.c (macro_bcache): Update.
 678         * macroexp.c: Don't include bcache.h.
 679         * gdbtypes.c (check_types_worklist): Update.
 680         (types_deeply_equal): Remove TRY/CATCH.  Update.
 681         * elfread.c (elf_symtab_read): Update.
 682         * dwarf2read.c: Don't include bcache.h.
 683         * buildsym.c (buildsym_compunit::get_macro_table): Update.
 684         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
 685         (print_bcache_statistics, bcache_memory_used): Don't declare.
 686         (struct bcache): Move from bcache.c.  Add constructor, destructor,
 687         methods.  Rename all data members.
 688         * bcache.c (struct bcache): Move to bcache.h.
 689         (bcache::expand_hash_table): Rename from expand_hash_table.
 690         (bcache): Remove.
 691         (bcache::insert): Rename from bcache_full.
 692         (bcache::compare): Rename from bcache_compare.
 693         (bcache_xmalloc): Remove.
 694         (bcache::~bcache): Rename from bcache_xfree.
 695         (bcache::print_statistics): Rename from print_bcache_statistics.
 696         (bcache::memory_used): Rename from bcache_memory_used.
 697
 698 2019-03-07  Pedro Alves  <palves@redhat.com>
 699
 700         * infrun.c (normal_stop): Also check for
 701         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
 702
 703 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 704
 705         * f-lang.c (value_from_host_double): Moved to...
 706         * value.c (value_from_host_double): ...here.
 707         * value.h (value_from_host_double): Declare.
 708         * guile/scm-math.c (vlscm_convert_typed_number): Use
 709         value_from_host_double.
 710         (vlscm_convert_number): Likewise.
 711         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
 712         * python/py-value.c (convert_value_from_python): Likewise.
 713
 714 2019-03-06  Tom Tromey  <tom@tromey.com>
 715
 716         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
 717
 718 2019-03-06  Tom Tromey  <tom@tromey.com>
 719
 720         * utils.h (free_current_contents): Don't declare.
 721         * utils.c (free_current_contents): Remove.
 722
 723 2019-03-06  Tom Tromey  <tom@tromey.com>
 724
 725         * top.c (quit_force): Update.
 726         * main.c (captured_command_loop): Update.
 727         * common/new-op.c (operator new): Update.
 728         * common/common-exceptions.c (struct catcher)
 729         <save_cleanup_chain>: Remove member.
 730         (exceptions_state_mc_init): Update.
 731         (exception_try_scope_entry): Return nullptr.
 732         (exception_try_scope_exit, exception_rethrow)
 733         (throw_exception_sjlj, throw_exception_cxx): Update.
 734         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
 735         (all_cleanups, do_cleanups, discard_cleanups)
 736         (discard_final_cleanups, save_cleanups, save_final_cleanups)
 737         (restore_cleanups, restore_final_cleanups): Don't declare.
 738         (do_final_cleanups): Remove parameter.
 739         * common/cleanups.c (cleanup_chain, make_cleanup)
 740         (make_cleanup_dtor, all_cleanups, do_cleanups)
 741         (discard_my_cleanups, discard_cleanups)
 742         (discard_final_cleanups, save_my_cleanups, save_cleanups)
 743         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
 744         (null_cleanup): Remove.
 745         (do_final_cleanups): Remove parameter.
 746
 747 2019-03-06  Tom Tromey  <tom@tromey.com>
 748
 749         * remote.c (remote_target::remote_parse_stop_reply): Use
 750         unique_xmalloc_ptr.
 751
 752 2019-03-06  Tom Tromey  <tom@tromey.com>
 753
 754         * stabsread.c (struct stabs_field_info): Rename from field_info.
 755         <list, fnlist>: Add initializers.
 756         <obstack>: New member.
 757         (read_member_functions, read_struct_fields, read_baseclasses):
 758         Allocate on obstack.  Don't use cleanups.
 759         (read_one_struct_field, read_member_functions, read_struct_fields)
 760         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
 761         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
 762         (read_struct_type): Update.
 763
 764 2019-03-06  Tom Tromey  <tom@tromey.com>
 765
 766         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
 767         * common/filestuff.h (make_cleanup_close): Don't declare.
 768         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
 769         Remove.
 770
 771 2019-03-06  Tom Tromey  <tom@tromey.com>
 772
 773         * solib-aix.c: Use make_scope_exit.
 774
 775 2019-03-06  Tom Tromey  <tom@tromey.com>
 776
 777         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
 778         Use make_scope_exit.
 779
 780 2019-03-06  Tom Tromey  <tom@tromey.com>
 781
 782         * solib-svr4.c (disable_probes_interface): Remove parameter.
 783         (svr4_handle_solib_event): Use make_scope_exit.
 784
 785 2019-03-06  Tom Tromey  <tom@tromey.com>
 786
 787         * remote.c (struct stop_reply_deleter): Remove.
 788         (stop_reply_up): Update.
 789         (struct stop_reply): Derive from notif_event.  Don't typedef.
 790         <regcache>: Now a std::vector.
 791         (stop_reply_xfree): Remove.
 792         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
 793         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
 794         (remote_target::discard_pending_stop_replies): Use delete.
 795         (remote_target::remote_parse_stop_reply): Update.
 796         (remote_target::process_stop_reply): Update.
 797         * remote-notif.h (struct notif_event): Add virtual destructor.
 798         Remove "dtr" member.
 799         (struct notif_client) <alloc_event>: Return a unique_ptr.
 800         (notif_event_xfree): Don't declare.
 801         (notif_event_up): New typedef.
 802         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
 803         (notif_event_xfree, do_notif_event_xfree): Remove.
 804         (remote_notif_state_xfree): Update.
 805
 806 2019-03-06  Tom Tromey  <tom@tromey.com>
 807
 808         * infrun.c (displaced_step_clear_cleanup): Now a
 809         forward_scope_exit type.
 810         (displaced_step_prepare_throw): Update.
 811         (displaced_step_fixup): Update.
 812
 813 2019-03-06  Tom Tromey  <tom@tromey.com>
 814
 815         * inferior.h (class inferior): Update comment.
 816         * gdbthread.h (class thread_info): Update comment.
 817
 818 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
 819             Tom Tromey  <tom@tromey.com>
 820
 821         * stabsread.h (struct stab_section_list): Remove.
 822         (coffstab_build_psymtabs): Update.
 823         * dbxread.c (symbuf_sections): Now a std::vector.
 824         (sect_idx): New global.
 825         (fill_symbuf): Update.
 826         (coffstab_build_psymtabs): Change type of stabsects parameter.
 827         Update.
 828         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
 829         std::vector.
 830         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
 831         (coff_locate_sections): Update.
 832         (coff_symfile_read): Remove cleanups.  Update.
 833         (init_stringtab): Add storage parameter.
 834         (free_stringtab, free_stringtab_cleanup): Remove.
 835         (init_lineno): Add storage parameter.
 836         (free_linetab, free_linetab_cleanup): Remove.
 837
 838 2019-03-06  Pedro Alves  <palves@redhat.com>
 839
 840         * linux-fork.c (fork_info::clobber_regs): Delete.
 841         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
 842         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
 843         comment.  Adjust.
 844         (scoped_switch_fork_info::scoped_switch_fork_info)
 845         (checkpoint_command, linux_fork_context): Adjust
 846         fork_save_infrun_state calls.
 847
 848 2019-03-06  Pedro Alves  <palves@redhat.com>
 849
 850         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
 851         (inf_has_multiple_threads): Return 'bool' and rewrite using
 852         inferior_info::threads().
 853
 854 2019-03-06  Pedro Alves  <palves@redhat.com>
 855
 856         * linux-fork.c: Include <list>.
 857         (fork_list): Now a std::list instance.
 858         (fork_info): Add ctor, dtor, and in-class initialize all fields.
 859         (forks_exist_p, find_last_fork): Adjust.
 860         (new_fork): Delete.
 861         (one_fork_p): New.
 862         (add_fork): Adjust.
 863         (free_fork): Delete, folded into fork_info::~fork_info().
 864         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
 865         Adjust.
 866         (init_fork_list): Delete.
 867         (linux_fork_killall, linux_fork_mourn_inferior)
 868         (linux_fork_detach, info_checkpoints_command): Adjust.
 869         (_initialize_linux_fork): No longer call init_fork_list.
 870
 871 2019-03-06  Pedro Alves  <palves@redhat.com>
 872
 873         * linux-fork.c (new_fork): New, split out of ...
 874         (add_fork): ... this.  Return void.  Move "first fork" special
 875         case from here, to ...
 876         (checkpoint_command): ... here.
 877         * linux-linux.h (add_fork): Return void.
 878
 879 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
 882
 883 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 884             Chris January  <chris.january@arm.com>
 885             David Lecomber  <david.lecomber@arm.com>
 886
 887         * f-exp.y: New token, UNOP_INTRINSIC.
 888         (exp): New pattern using UNOP_INTRINSIC token.
 889         (f77_keywords): Add 'abs' keyword.
 890         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
 891         (value_from_host_double): New function.
 892         (evaluate_subexp_f): Support UNOP_ABS.
 893
 894 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 895
 896         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
 897         types.
 898
 899 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
 902         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
 903         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
 904
 905 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 906
 907         * f-exp.y (convert_to_kind_type): Handle more type kinds.
 908
 909 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 910             Chris January  <chris.january@arm.com>
 911
 912         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
 913         * f-exp.y: Define 'KIND' token.
 914         (exp): New pattern for KIND expressions.
 915         (ptype): Handle types with a kind extension.
 916         (direct_abs_decl): Extend to spot kind extensions.
 917         (f77_keywords): Add 'kind' to the list.
 918         (push_kind_type): New function.
 919         (convert_to_kind_type): New function.
 920         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
 921         * parse.c (operator_length_standard): Likewise.
 922         * parser-defs.h (enum type_pieces): Add tp_kind.
 923         * std-operator.def: Add UNOP_KIND.
 924
 925 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * f-exp.y (f_parse): Set yydebug.
 928
 929 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 930
 931         * f-lang.c (evaluate_subexp_f): New function.
 932         (exp_descriptor_f): New global.
 933         (f_language_defn): Use exp_descriptor_f instead of
 934         exp_descriptor_standard.
 935
 936 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 937
 938         * f-exp.y (struct token): Add comments.
 939         (dot_ops): Remove uppercase versions and the end marker.
 940         (f77_keywords): Likewise.
 941         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
 942         entries in the dot_ops array are case insensitive, and use
 943         strncasecmp to compare strings.  Also some whitespace cleanup in
 944         this area.  Similar for the f77_keywords array, except entries in
 945         this list might be case sensitive.
 946
 947 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
 948
 949         * f-exp.y (struct f77_boolean_val): Add comments.
 950         (boolean_values): Remove uppercase versions, and end marker.
 951         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
 952         and use strncasecmp to achieve case insensitivity.  Additionally,
 953         perform whitespace cleanup around this code.
 954
 955 2019-03-06  Tom Tromey  <tromey@adacore.com>
 956
 957         * remote-sim.c (gdbsim_target_open): Use result of
 958         gdb_argv::release.
 959
 960 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
 961         Dirk Schubert  <dirk.schubert@arm.com>
 962         Chris January  <chris.january@arm.com>
 963
 964         * eval.c (evaluate_subexp_standard): Call Fortran argument
 965         wrapping logic.
 966         * f-lang.c (struct value): A value which can be passed into a
 967         Fortran function call.
 968         (fortran_argument_convert): Wrap Fortran arguments in a pointer
 969         where appropriate.
 970         (struct type): Value ready for a Fortran function call.
 971         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
 972         is needed.
 973         * f-lang.h (fortran_argument_convert): Declaration.
 974         (fortran_preserve_arg_pointer): Declaration.
 975         * infcall.c (value_arg_coerce): Call Fortran argument logic.
 976
 977 2019-03-05  Tom Tromey  <tromey@adacore.com>
 978
 979         * python/py-prettyprint.c (print_string_repr): Remove #if.
 980         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
 981
 982 2019-03-05  Tom Tromey  <tromey@adacore.com>
 983
 984         * target.c (the_dummy_target): Move later.  Change type to
 985         "dummy_target".
 986         (initialize_targets): Don't initialize the_dummy_target.
 987
 988 2019-03-05  Tom Tromey  <tromey@adacore.com>
 989
 990         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
 991         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
 992
 993 2019-03-05  Tom Tromey  <tromey@adacore.com>
 994
 995         * windows-nat.c (windows_nat_target::attach)
 996         (windows_nat_target::detach): Don't call gdb_flush.
 997         * valprint.c (generic_val_print, val_print, val_print_string):
 998         Don't call gdb_flush.
 999         * utils.c (defaulted_query): Don't call gdb_flush.
1000         * typeprint.c (print_type_scalar): Don't call gdb_flush.
1001         * target.c (target_announce_detach): Don't call gdb_flush.
1002         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
1003         * remote.c (extended_remote_target::attach): Don't call
1004         gdb_flush.
1005         * procfs.c (procfs_target::detach): Don't call gdb_flush.
1006         * printcmd.c (do_examine): Don't call gdb_flush.
1007         (info_display_command): Don't call gdb_flush.
1008         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
1009         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
1010         * memattr.c (info_mem_command): Don't call gdb_flush.
1011         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
1012         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
1013         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
1014         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
1015         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
1016         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
1017         (gnu_nat_target::detach): Don't call gdb_flush.
1018         * f-valprint.c (f_val_print): Don't call gdb_flush.
1019         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
1020         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
1021         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
1022         gdb_flush.
1023         * c-valprint.c (c_val_print): Don't call gdb_flush.
1024         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
1025
1026 2019-03-05  Tom Tromey  <tromey@adacore.com>
1027
1028         * varobj.c (update_dynamic_varobj_children): Update.
1029         (install_default_visualizer): Use reset, not release.
1030         * value.c (set_internalvar): Update.
1031         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
1032         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
1033         ATTRIBUTE_UNUSED_RESULT.
1034
1035 2019-03-05  Tom Tromey  <tromey@adacore.com>
1036
1037         * remote.c (class scoped_remote_fd) <release>: Add
1038         ATTRIBUTE_UNUSED_RESULT.
1039
1040 2019-03-05  Tom Tromey  <tromey@adacore.com>
1041
1042         * macroexp.c (struct macro_buffer) <release>: Add
1043         ATTRIBUTE_UNUSED_RESULT.
1044
1045 2019-03-05  Tom Tromey  <tromey@adacore.com>
1046
1047         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
1048         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
1049         ATTRIBUTE_UNUSED_RESULT.
1050
1051 2019-03-05  Tom Tromey  <tromey@adacore.com>
1052
1053         * common/scoped_fd.h (class scoped_fd) <release>: Add
1054         ATTRIBUTE_UNUSED_RESULT.
1055
1056 2019-03-05  Tom Tromey  <tromey@adacore.com>
1057
1058         * parser-defs.h (struct parser_state) <release>: Add
1059         ATTRIBUTE_UNUSED_RESULT.
1060
1061 2019-03-05  Tom Tromey  <tromey@adacore.com>
1062
1063         * utils.h (class gdb_argv) <release>: Add
1064         ATTRIBUTE_UNUSED_RESULT.
1065         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
1066
1067 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
1068
1069         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
1070         for-loop range, to avoid compiler warnings.
1071
1072         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
1073         avoid compiler warnings about unused variables.
1074
1075         * NEWS: Mention end of support for native debugging on MS-Windows
1076         before XP.
1077
1078         PR gdb/24292
1079         * common/netstuff.c:
1080         * gdbserver/gdbreplay.c
1081         * gdbserver/remote-utils.c:
1082         * ser-tcp.c:
1083         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
1084         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
1085         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
1086         'getaddrinfo' and 'freeaddrinfo' were not available before
1087         Windows XP, and mingw.org's MinGW headers by default define
1088         _WIN32_WINNT to 0x500.
1089
1090 2019-03-01  Gary Benson <gbenson@redhat.com>
1091
1092         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
1093
1094 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
1095             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1096
1097         PR gdb/8527
1098         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
1099         set_sigint_trap, clear_sigint_trap.
1100
1101 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1102
1103         * target.c (target_detach): Clear the regcache and the
1104         frame cache.
1105
1106 2019-02-27  Pedro Alves  <palves@redhat.com>
1107
1108         * utils.c (set_screen_size): When we cap the height/width sizes,
1109         tweak the corresponding command variable to show "unlimited":
1110
1111 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
1112             Pedro Alves  <palves@redhat.com>
1113
1114         * utils.c (set_screen_size): Reduce "infinite" rows and columns
1115         before calling rl_set_screen_size.
1116
1117 2019-02-27  Tom Tromey  <tromey@adacore.com>
1118
1119         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
1120         define.
1121         * python/py-value.c: Remove Python 2.4 workaround.
1122         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
1123         workaround.
1124         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
1125         Python 2.4 workaround.
1126         * python/python-internal.h: Remove Python 2.4 comment.
1127         (Py_ssize_t): Don't define.
1128         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
1129         (gdb_Py_DECREF): Remove Python 2.4 workaround.
1130         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
1131         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
1132         * python/python.c (do_start_initialization): Remove Python 2.4
1133         workaround.
1134         * python/py-prettyprint.c (class dummy_python_frame): Remove.
1135         (print_children): Remove Python 2.4 workaround.
1136         * python/py-inferior.c (buffer_procs): Remove Python 2.4
1137         workaround.
1138         (CHARBUFFERPROC_NAME): Remove.
1139         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
1140         Python 2.4 workaround.
1141
1142 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1143
1144         * NEWS: Note minimum Python version.
1145
1146 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
1147
1148         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
1149         code from these functions.  Remove corresponding ifdefs.  Use
1150         Py_buffer_up instead of explicit calls to PyBuffer_Release.
1151         Remove gotos and target of gotos.
1152         (infpy_search_memory): Likewise.
1153
1154 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1155
1156         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
1157         (hppa_gdbarch_init): Don't register deleted functions with
1158         gdbarch.
1159
1160 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1161
1162         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
1163         (h8300_unwind_sp): Delete.
1164         (h8300_dummy_id): Delete.
1165         (h8300_gdbarch_init): Don't register deleted functions with
1166         gdbarch.
1167
1168 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1169
1170         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
1171         (ft32_unwind_pc): Delete.
1172         (ft32_unwind_sp): Delete.
1173         (ft32_gdbarch_init): Don't register deleted functions with
1174         gdbarch.
1175
1176 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * gdb/frv-tdep.c (frv_dummy_id): Delete.
1179         (frv_unwind_pc): Delete.
1180         (frv_unwind_sp): Delete.
1181         (frv_gdbarch_init): Don't register deleted functions with
1182         gdbarch.
1183
1184 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
1187         (riscv_unwind_pc): Delete.
1188         (riscv_unwind_sp): Delete.
1189         (riscv_gdbarch_init): Don't register deleted functions with
1190         gdbarch.
1191
1192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1193
1194         * gdb/csky-tdep.c (csky_dummy_id): Delete.
1195         (csky_unwind_pc): Delete.
1196         (csky_unwind_sp): Delete.
1197         (csky_gdbarch_init): Don't register deleted functions with
1198         gdbarch.
1199
1200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1201
1202         * gdb/cris-tdep.c (cris_dummy_id): Delete.
1203         (cris_unwind_pc): Delete.
1204         (cris_unwind_sp): Delete.
1205         (cris_gdbarch_init): Don't register deleted functions with
1206         gdbarch.
1207
1208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
1211         (bfin_unwind_pc): Delete.
1212         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
1213
1214 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1215
1216         * gdb/arm-tdep.c (arm_dummy_id): Delete.
1217         (arm_unwind_pc): Delete.
1218         (arm_unwind_sp): Delete.
1219         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
1220
1221 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1222
1223         * gdb/arc-tdep.c (arc_dummy_id): Delete.
1224         (arc_unwind_pc): Delete.
1225         (arc_unwind_sp): Delete.
1226         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
1227
1228 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1229
1230         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
1231         (alpha_unwind_pc): Delete.
1232         (alpha_gdbarch_init): Don't register deleted functions with
1233         gdbarch.
1234
1235 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1236
1237         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
1238         (aarch64_unwind_pc): Delete.
1239         (aarch64_unwind_sp): Delete.
1240         (aarch64_gdbarch_init): Don't register deleted functions with
1241         gdbarch.
1242
1243 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1244
1245         * gdbtypes.c (type_align): Don't consider static members when
1246         computing structure alignment.
1247
1248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1249
1250         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
1251         return 0 for other types.
1252         * arch-utils.c (default_type_align): Always return 0.
1253         * gdbarch.h: Regenerate.
1254         * gdbarch.sh (type_align): Extend comment.
1255         * gdbtypes.c (type_align): Add additional comments, always call
1256         gdbarch_type_align before applying the default rules.
1257         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
1258         generic code will then apply a suitable default.
1259         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
1260         types, return 0 for other types.
1261
1262 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1263
1264         * NEWS: Create a new section for the next release branch.
1265         Rename the section of the current branch, now that it has
1266         been cut.
1267
1268 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
1269
1270         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
1271         * version.in: Bump version to 8.3.50.DATE-git.
1272
1273 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
1274
1275         * aix-thread.c (ptid_cmp): Remove unused variable.
1276         (get_signaled_thread): Likewise.
1277         (store_regs_user_thread): Likewise.
1278         (store_regs_kernel_thread): Likewise.
1279         (fetch_regs_kernel_thread): Remove shadowed variable.
1280
1281 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1282
1283         * features/riscv/32bit-cpu.xml: Add register numbers.
1284         * features/riscv/32bit-fpu.c: Regenerate.
1285         * features/riscv/32bit-fpu.xml: Add register numbers.
1286         * features/riscv/64bit-cpu.xml: Add register numbers.
1287         * features/riscv/64bit-fpu.c: Regenerate.
1288         * features/riscv/64bit-fpu.xml: Add register numbers.
1289
1290 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
1291
1292         * NEWS: Mention two argument form of gdb.Value constructor.
1293         * python/py-value.c (convert_buffer_and_type_to_value): New
1294         function.
1295         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
1296         Add support for handling an optional second argument.  Call
1297         convert_buffer_and_type_to_value as appropriate.
1298         * python/python-internal.h (Py_buffer_deleter): New struct.
1299         (Py_buffer_up): New typedef.
1300
1301 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
1302
1303         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
1304         instead of releasing ownership.
1305
1306 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
1307
1308         * dwarf2read.c (open_and_init_dwp_file): Call
1309         elf_numsections instead of bfd_count_sections to initialize
1310         dwp_file->num_sections.
1311
1312 2019-02-25  Tom Tromey  <tromey@adacore.com>
1313
1314         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
1315
1316 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1317
1318         * gcore.in: Add '--readnever' option when invoking GDB.
1319
1320 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1321
1322         * MAINTAINERS: Update my email address.
1323
1324 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
1325
1326         * build-id.c (build_id_to_debug_bfd_1): New function.
1327         (build_id_to_debug_bfd): Look for separate debug file in
1328         sysroot.
1329
1330 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1331
1332         * gdbarch.sh: Update the copyright year range that is placed into
1333         generated files.
1334
1335 2019-02-22  Keith Seitz  <keiths@redhat.com>
1336
1337         PR symtab/23853
1338         * linespec.c (create_sals_line_offset): Search for the default
1339         symtab's filename instead of its fullname.
1340
1341 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1342
1343         * NEWS: Update style defaults.
1344
1345 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
1346
1347         * main.c (captured_main_1): Disable styling in batch mode.
1348
1349 2019-02-20  Tom Tromey  <tom@tromey.com>
1350
1351         * symtab.c (symtab_symbol_info): Fix typos.
1352
1353 2019-02-20  Tom Tromey  <tromey@adacore.com>
1354
1355         * findcmd.c (_initialize_mem_search): Use upper case for
1356         metasyntactic variables.
1357
1358 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
1359
1360         * aarch64-tdep.c (aarch64_add_reggroups): New function.
1361         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
1362
1363 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
1364
1365         * top.h (source_file_name): Change to std::string.
1366         * top.c (source_file_name): Likewise.
1367         (command_line_input): Adjust.
1368         * cli/cli-script.c (script_from_file): Adjust.
1369
1370 2019-02-19  Tom Tromey  <tromey@adacore.com>
1371
1372         * ravenscar-thread.c
1373         (ravenscar_thread_target::update_thread_list): Don't call
1374         ada_build_task_list.
1375         * ada-lang.h (ada_build_task_list): Don't declare.
1376         * ada-tasks.c (struct ada_tasks_inferior_data)
1377         <task_list_valid_p>: Now bool.
1378         (read_known_tasks, ada_task_list_changed)
1379         (ada_tasks_invalidate_inferior_data): Update.
1380         (read_known_tasks_array): Return bool.
1381         (read_known_tasks_list): Likewise.
1382         (read_known_tasks): Return void.
1383         (ada_build_task_list): Now static.
1384
1385 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
1388         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
1389
1390 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1391
1392         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
1393         variant for ada_tasks_pspace_data_handle and
1394         ada_tasks_inferior_data_handle.
1395         (ada_tasks_pspace_data_cleanup): New function.
1396         (ada_tasks_inferior_data_cleanup): New function.
1397
1398 2019-02-17  Tom Tromey  <tom@tromey.com>
1399
1400         * macrotab.h (macro_source_fullname): Return a std::string.
1401         * macrotab.c (macro_include, check_for_redefinition)
1402         (macro_undef, macro_lookup_definition, foreach_macro)
1403         (foreach_macro_in_scope): Update.
1404         (macro_source_fullname): Return a std::string.
1405         * macrocmd.c (show_pp_source_pos): Update.
1406
1407 2019-02-17  Tom Tromey  <tom@tromey.com>
1408
1409         * macrocmd.c (show_pp_source_pos): Style the file names.
1410
1411 2019-02-17  Tom Tromey  <tom@tromey.com>
1412
1413         PR tui/24197:
1414         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
1415
1416 2019-02-17  Tom Tromey  <tom@tromey.com>
1417
1418         * ada-lang.c (user_select_syms): Use filtered printing.
1419         * utils.c (wrap_style): New global.
1420         (desired_style): Remove.
1421         (emit_style_escape): Add stream parameter.
1422         (set_output_style, reset_terminal_style, prompt_for_continue):
1423         Update.
1424         (flush_wrap_buffer): Only flush gdb_stdout.
1425         (wrap_here): Set wrap_style.
1426         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
1427         treat escape sequences as a character.  Change when wrap buffer is
1428         flushed.
1429         (fputs_styled): Do not set the output style when the default is
1430         requested.
1431         * ui-style.h (struct ui_file_style) <is_default>: New method.
1432         * source.c (print_source_lines_base): Emit escape sequences in one
1433         piece.
1434
1435 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1436
1437         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
1438         integers and enumeration types.
1439
1440 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
1441
1442         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
1443         instead of lookup_symbol_in_language
1444         (do_exact_match): New function.
1445         (ada_get_symbol_name_matcher): Return do_exact_match when
1446         doing a verbatim match.
1447
1448 2019-02-15  Tom Tromey  <tromey@adacore.com>
1449
1450         * ravenscar-thread.c (ravenscar_thread_target::resume)
1451         (ravenscar_thread_target::wait): Special case wildcard requests.
1452
1453 2019-02-15  Tom Tromey  <tromey@adacore.com>
1454
1455         * ravenscar-thread.c (base_ptid): Remove.
1456         (struct ravenscar_thread_target) <close>: New method.
1457         <m_base_ptid>: New member.
1458         <update_inferior_ptid, active_task, task_is_currently_active,
1459         runtime_initialized>: Declare methods.
1460         <ravenscar_thread_target>: Add constructor.
1461         (ravenscar_thread_target::task_is_currently_active)
1462         (ravenscar_thread_target::update_inferior_ptid)
1463         (ravenscar_runtime_initialized): Rename.  Now methods.
1464         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
1465         (ravenscar_thread_target::update_thread_list): Update.
1466         (ravenscar_thread_target::active_task): Now method.
1467         (ravenscar_thread_target::store_registers)
1468         (ravenscar_thread_target::prepare_to_store)
1469         (ravenscar_thread_target::prepare_to_store)
1470         (ravenscar_thread_target::mourn_inferior): Update.
1471         (ravenscar_inferior_created): Use "new" to create target.
1472         (ravenscar_thread_target::get_ada_task_ptid): Update.
1473         (_initialize_ravenscar): Don't initialize base_ptid.
1474         (ravenscar_ops): Remove global.
1475
1476 2019-02-15  Tom Tromey  <tromey@adacore.com>
1477
1478         * target.h (push_target): Declare new overload.
1479         * target.c (push_target): New overload, taking an rvalue reference.
1480         * remote.c (remote_target::open_1): Use push_target overload.
1481         * corelow.c (core_target_open): Use push_target overload.
1482
1483 2019-02-15  Tom Tromey  <tromey@adacore.com>
1484
1485         * ravenscar-thread.c (is_ravenscar_task)
1486         (ravenscar_task_is_currently_active): Return bool.
1487         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
1488         (_initialize_ravenscar): Remove "(void)".
1489         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
1490         Return bool.
1491
1492 2019-02-15  Tom Tromey  <tromey@adacore.com>
1493
1494         * ravenscar-thread.c (ravenscar_runtime_initializer)
1495         (has_ravenscar_runtime, get_running_thread_id)
1496         (ravenscar_thread_target::resume): Fix indentation.
1497
1498 2019-02-15  Tom Tromey  <tromey@adacore.com>
1499
1500         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
1501         from ravenscar_arch_ops.
1502         (sparc_ravenscar_ops::fetch_registers)
1503         (sparc_ravenscar_ops::store_registers): Now methods.
1504         (sparc_ravenscar_prepare_to_store): Remove.
1505         (sparc_ravenscar_ops): Redefine.
1506         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
1507         methods and destructor.  Remove members.
1508         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
1509         (ravenscar_thread_target::store_registers)
1510         (ravenscar_thread_target::prepare_to_store): Update.
1511         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
1512         Remove.
1513         (struct ppc_ravenscar_powerpc_ops): Derive from
1514         ravenscar_arch_ops.
1515         (ppc_ravenscar_powerpc_ops::fetch_registers)
1516         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
1517         (ppc_ravenscar_powerpc_ops): Redefine.
1518         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
1519         (ppc_ravenscar_e500_ops::fetch_registers)
1520         (ppc_ravenscar_e500_ops::store_registers): Now methods.
1521         (ppc_ravenscar_e500_ops): Redefine.
1522         * aarch64-ravenscar-thread.c
1523         (aarch64_ravenscar_generic_prepare_to_store): Remove.
1524         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
1525         (aarch64_ravenscar_fetch_registers)
1526         (aarch64_ravenscar_store_registers): Now methods.
1527         (aarch64_ravenscar_ops): Redefine.
1528
1529 2019-02-15  Tom Tromey  <tromey@adacore.com>
1530
1531         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
1532         (ravenscar_thread_target::stopped_by_hw_breakpoint)
1533         (ravenscar_thread_target::stopped_by_watchpoint)
1534         (ravenscar_thread_target::stopped_data_address)
1535         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
1536
1537 2019-02-15  Tom Tromey  <tromey@adacore.com>
1538
1539         * ravenscar-thread.c: Fix some typos.
1540
1541 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1542             Tom Tromey  <tromey@adacore.com>
1543
1544         * ada-lang.c (ada_exception_sal): Change addr_string to a
1545         std::string.
1546         (create_ada_exception_catchpoint): Update.
1547
1548 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1549             Tom Tromey  <tromey@adacore.com>
1550
1551         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
1552         (bp_location_ops): Remove.
1553         (base_breakpoint_allocate_location): Update.
1554         (free_bp_location): Update.
1555         * ada-lang.c (class ada_catchpoint_location)
1556         <ada_catchpoint_location>: Remove ops parameter.
1557         (ada_catchpoint_location_dtor): Remove.
1558         (ada_catchpoint_location_ops): Remove.
1559         (allocate_location_exception): Update.
1560         * breakpoint.h (struct bp_location_ops): Remove.
1561         (class bp_location) <bp_location>: Remove bp_location_ops
1562         parameter.
1563         <~bp_location>: Add destructor.
1564         <ops>: Remove.
1565
1566 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1567             Pedro Alves  <palves@redhat.com>
1568
1569         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
1570         'PATH_MAX'.
1571
1572 2019-02-14  David Michael  <fedora.dm0@gmail.com>
1573             Samuel Thibault  <samuel.thibault@gnu.org>
1574             Thomas Schwinge  <thomas@codesourcery.com>
1575
1576         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
1577         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
1578
1579 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
1580
1581         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
1582         (check_empty): Use "const char *".
1583
1584         * gnu-nat.c (gnu_nat_target::detach): Instead of
1585         'detach_inferior (pid)' call
1586         'detach_inferior (find_inferior_pid (pid))'.
1587
1588         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
1589         'nat/fork-inferior.o'.
1590         * gnu-nat.c: #include "nat/fork-inferior.h".
1591
1592         * gnu-nat.c (gnu_nat_target::detach): Instead of
1593         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
1594         * gnu-nat.h: #include "inf-child.h".
1595         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
1596         'i386_gnu_nat_target::fetch_registers'.
1597         (gnu_store_registers): Rename/move to
1598         'i386_gnu_nat_target::store_registers'.
1599
1600         * config/i386/nm-i386gnu.h: Don't "#include" any files.
1601         * gnu-nat.h (mach_thread_info): New function.
1602         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
1603
1604         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
1605
1606 2019-02-14  Frederic Konrad  <konrad@adacore.com>
1607
1608         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
1609
1610 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
1611
1612         * windows-nat.c (windows_add_thread): Add new parameter
1613         "main_thread_p" with default value set to false.  Update
1614         function documentation as well as all callers.
1615         (windows_delete_thread): Likewise.
1616         (fake_create_process): Update call to windows_add_thread.
1617         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
1618         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
1619         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
1620         call to windows_delete_thread.
1621
1622 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
1623
1624         * MAINTAINERS: Add Andrew Burgess as global maintainer.
1625
1626 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1627
1628         * symfile.c (find_separate_debug_file): Use canonical path of
1629         sysroot with child_path instead of gdb_sysroot if it is valid.
1630
1631 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1632
1633         * symfile.c (find_separate_debug_file): Use child_path to
1634         determine if an object file is under a sysroot.
1635
1636 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1637
1638         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1639         unittests/child-path-selftests.c.
1640         * common/pathstuff.c (child_path): New function.
1641         * common/pathstuff.h (child_path): New prototype.
1642         * unittests/child-path-selftests.c: New file.
1643
1644 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
1645
1646         * symfile.c (find_separate_debug_file): Look for separate debug
1647         files in debug directories under the sysroot.
1648
1649 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1650
1651         * symtab.h (struct minimal_symbol data_p): New const method.
1652         (struct minimal_symbol text_p): Likewise.
1653         * symtab.c (output_source_filename): Use file name style
1654         to print file name.
1655         (print_symbol_info): Likewise.
1656         (print_msymbol_info): Use address style to print addresses.
1657         Use function name style to print executable text symbols.
1658         (expand_symtab_containing_pc): Use data_p.
1659         (find_pc_sect_compunit_symtab): Likewise.
1660
1661 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1662
1663         * breakpoint.c (describe_other_breakpoints): Use address style
1664         to print addresses.
1665         (say_where): Likewise.
1666
1667 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1668
1669         * ada-typeprint.c (print_func_type): Print function name
1670         style to print function name.
1671         * c-typeprint.c (c_print_type_1): Likewise.
1672
1673 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
1674
1675         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
1676         for execve.
1677
1678 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1679
1680         * c-exp.y (direct_abs_decl): Use emplace_back to record the
1681         type_stack.
1682
1683 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
1684
1685         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
1686         TYPE_CODE_REF types.
1687
1688 2019-02-08  Jim Wilson  <jimw@sifive.com>
1689
1690         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
1691         (riscv_linux_fregset): New.
1692         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
1693
1694 2019-02-07  Tom Tromey  <tom@tromey.com>
1695
1696         * thread.c (thread_cancel_execution_command): Update.
1697         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
1698         methods.
1699         (struct thread_fsm_ops): Remove.
1700         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
1701         (thread_fsm_should_stop, thread_fsm_return_value)
1702         (thread_fsm_set_finished, thread_fsm_finished_p)
1703         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
1704         Don't declare.
1705         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
1706         * infrun.c (clear_proceed_status_thread)
1707         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
1708         (print_stop_event): Update.
1709         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
1710         Add constructor.
1711         (step_command_fsm_ops): Remove.
1712         (new_step_command_fsm): Remove.
1713         (step_1): Update.
1714         (step_command_fsm::should_stop): Rename from
1715         step_command_fsm_should_stop.
1716         (step_command_fsm::clean_up): Rename from
1717         step_command_fsm_clean_up.
1718         (step_command_fsm::do_async_reply_reason): Rename from
1719         step_command_fsm_async_reply_reason.
1720         (struct until_next_fsm): Inherit from thread_fsm.  Add
1721         constructor.
1722         (until_next_fsm_ops): Remove.
1723         (new_until_next_fsm): Remove.
1724         (until_next_fsm::should_stop): Rename from
1725         until_next_fsm_should_stop.
1726         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
1727         (until_next_fsm::do_async_reply_reason): Rename from
1728         until_next_fsm_async_reply_reason.
1729         (struct finish_command_fsm): Inherit from thread_fsm.  Add
1730         constructor.  Change type of breakpoint.
1731         (finish_command_fsm_ops): Remove.
1732         (new_finish_command_fsm): Remove.
1733         (finish_command_fsm::should_stop): Rename from
1734         finish_command_fsm_should_stop.
1735         (finish_command_fsm::clean_up): Rename from
1736         finish_command_fsm_clean_up.
1737         (finish_command_fsm::return_value): Rename from
1738         finish_command_fsm_return_value.
1739         (finish_command_fsm::do_async_reply_reason): Rename from
1740         finish_command_fsm_async_reply_reason.
1741         (finish_command): Update.
1742         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
1743         Add constructor.
1744         (call_thread_fsm_ops): Remove.
1745         (call_thread_fsm::call_thread_fsm): Rename from
1746         new_call_thread_fsm.
1747         (call_thread_fsm::should_stop): Rename from
1748         call_thread_fsm_should_stop.
1749         (call_thread_fsm::should_notify_stop): Rename from
1750         call_thread_fsm_should_notify_stop.
1751         (run_inferior_call, call_function_by_hand_dummy): Update.
1752         * cli/cli-interp.c (should_print_stop_to_console): Update.
1753         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
1754         Add constructor.  Change type of location_breakpoint,
1755         caller_breakpoint.
1756         (until_break_fsm_ops): Remove.
1757         (new_until_break_fsm): Remove.
1758         (until_break_fsm::should_stop): Rename from
1759         until_break_fsm_should_stop.
1760         (until_break_fsm::clean_up): Rename from
1761         until_break_fsm_clean_up.
1762         (until_break_fsm::do_async_reply_reason): Rename from
1763         until_break_fsm_async_reply_reason.
1764         (until_break_command): Update.
1765         * thread-fsm.c: Remove.
1766         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
1767
1768 2019-02-07  Tom Tromey  <tom@tromey.com>
1769
1770         * yy-remap.h: Add include guard.
1771         * xtensa-tdep.h: Add include guard.
1772         * xcoffread.h: Rename include guard.
1773         * varobj-iter.h: Add include guard.
1774         * tui/tui.h: Rename include guard.
1775         * tui/tui-winsource.h: Rename include guard.
1776         * tui/tui-wingeneral.h: Rename include guard.
1777         * tui/tui-windata.h: Rename include guard.
1778         * tui/tui-win.h: Rename include guard.
1779         * tui/tui-stack.h: Rename include guard.
1780         * tui/tui-source.h: Rename include guard.
1781         * tui/tui-regs.h: Rename include guard.
1782         * tui/tui-out.h: Rename include guard.
1783         * tui/tui-layout.h: Rename include guard.
1784         * tui/tui-io.h: Rename include guard.
1785         * tui/tui-hooks.h: Rename include guard.
1786         * tui/tui-file.h: Rename include guard.
1787         * tui/tui-disasm.h: Rename include guard.
1788         * tui/tui-data.h: Rename include guard.
1789         * tui/tui-command.h: Rename include guard.
1790         * tic6x-tdep.h: Add include guard.
1791         * target/waitstatus.h: Rename include guard.
1792         * target/wait.h: Rename include guard.
1793         * target/target.h: Rename include guard.
1794         * target/resume.h: Rename include guard.
1795         * target-float.h: Rename include guard.
1796         * stabsread.h: Add include guard.
1797         * rs6000-tdep.h: Add include guard.
1798         * riscv-fbsd-tdep.h: Add include guard.
1799         * regformats/regdef.h: Rename include guard.
1800         * record.h: Rename include guard.
1801         * python/python.h: Rename include guard.
1802         * python/python-internal.h: Rename include guard.
1803         * python/py-stopevent.h: Rename include guard.
1804         * python/py-ref.h: Rename include guard.
1805         * python/py-record.h: Rename include guard.
1806         * python/py-record-full.h: Rename include guard.
1807         * python/py-record-btrace.h: Rename include guard.
1808         * python/py-instruction.h: Rename include guard.
1809         * python/py-events.h: Rename include guard.
1810         * python/py-event.h: Rename include guard.
1811         * procfs.h: Add include guard.
1812         * proc-utils.h: Add include guard.
1813         * p-lang.h: Add include guard.
1814         * or1k-tdep.h: Rename include guard.
1815         * observable.h: Rename include guard.
1816         * nto-tdep.h: Rename include guard.
1817         * nat/x86-linux.h: Rename include guard.
1818         * nat/x86-linux-dregs.h: Rename include guard.
1819         * nat/x86-gcc-cpuid.h: Add include guard.
1820         * nat/x86-dregs.h: Rename include guard.
1821         * nat/x86-cpuid.h: Rename include guard.
1822         * nat/ppc-linux.h: Rename include guard.
1823         * nat/mips-linux-watch.h: Rename include guard.
1824         * nat/linux-waitpid.h: Rename include guard.
1825         * nat/linux-ptrace.h: Rename include guard.
1826         * nat/linux-procfs.h: Rename include guard.
1827         * nat/linux-osdata.h: Rename include guard.
1828         * nat/linux-nat.h: Rename include guard.
1829         * nat/linux-namespaces.h: Rename include guard.
1830         * nat/linux-btrace.h: Rename include guard.
1831         * nat/glibc_thread_db.h: Rename include guard.
1832         * nat/gdb_thread_db.h: Rename include guard.
1833         * nat/gdb_ptrace.h: Rename include guard.
1834         * nat/fork-inferior.h: Rename include guard.
1835         * nat/amd64-linux-siginfo.h: Rename include guard.
1836         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
1837         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
1838         * nat/aarch64-linux.h: Rename include guard.
1839         * nat/aarch64-linux-hw-point.h: Rename include guard.
1840         * mn10300-tdep.h: Add include guard.
1841         * mips-linux-tdep.h: Add include guard.
1842         * mi/mi-parse.h: Rename include guard.
1843         * mi/mi-out.h: Rename include guard.
1844         * mi/mi-main.h: Rename include guard.
1845         * mi/mi-interp.h: Rename include guard.
1846         * mi/mi-getopt.h: Rename include guard.
1847         * mi/mi-console.h: Rename include guard.
1848         * mi/mi-common.h: Rename include guard.
1849         * mi/mi-cmds.h: Rename include guard.
1850         * mi/mi-cmd-break.h: Rename include guard.
1851         * m2-lang.h: Add include guard.
1852         * location.h: Rename include guard.
1853         * linux-record.h: Rename include guard.
1854         * linux-nat.h: Add include guard.
1855         * linux-fork.h: Add include guard.
1856         * i386-darwin-tdep.h: Rename include guard.
1857         * hppa-linux-offsets.h: Add include guard.
1858         * guile/guile.h: Rename include guard.
1859         * guile/guile-internal.h: Rename include guard.
1860         * gnu-nat.h: Rename include guard.
1861         * gdb-stabs.h: Rename include guard.
1862         * frv-tdep.h: Add include guard.
1863         * f-lang.h: Add include guard.
1864         * event-loop.h: Add include guard.
1865         * darwin-nat.h: Rename include guard.
1866         * cp-abi.h: Rename include guard.
1867         * config/sparc/nm-sol2.h: Rename include guard.
1868         * config/nm-nto.h: Rename include guard.
1869         * config/nm-linux.h: Add include guard.
1870         * config/i386/nm-i386gnu.h: Rename include guard.
1871         * config/djgpp/nl_types.h: Rename include guard.
1872         * config/djgpp/langinfo.h: Rename include guard.
1873         * compile/gcc-cp-plugin.h: Add include guard.
1874         * compile/gcc-c-plugin.h: Add include guard.
1875         * compile/compile.h: Rename include guard.
1876         * compile/compile-object-run.h: Rename include guard.
1877         * compile/compile-object-load.h: Rename include guard.
1878         * compile/compile-internal.h: Rename include guard.
1879         * compile/compile-cplus.h: Rename include guard.
1880         * compile/compile-c.h: Rename include guard.
1881         * common/xml-utils.h: Rename include guard.
1882         * common/x86-xstate.h: Rename include guard.
1883         * common/version.h: Rename include guard.
1884         * common/vec.h: Rename include guard.
1885         * common/tdesc.h: Rename include guard.
1886         * common/selftest.h: Rename include guard.
1887         * common/scoped_restore.h: Rename include guard.
1888         * common/scoped_mmap.h: Rename include guard.
1889         * common/scoped_fd.h: Rename include guard.
1890         * common/safe-iterator.h: Rename include guard.
1891         * common/run-time-clock.h: Rename include guard.
1892         * common/refcounted-object.h: Rename include guard.
1893         * common/queue.h: Rename include guard.
1894         * common/ptid.h: Rename include guard.
1895         * common/print-utils.h: Rename include guard.
1896         * common/preprocessor.h: Rename include guard.
1897         * common/pathstuff.h: Rename include guard.
1898         * common/observable.h: Rename include guard.
1899         * common/netstuff.h: Rename include guard.
1900         * common/job-control.h: Rename include guard.
1901         * common/host-defs.h: Rename include guard.
1902         * common/gdb_wait.h: Rename include guard.
1903         * common/gdb_vecs.h: Rename include guard.
1904         * common/gdb_unlinker.h: Rename include guard.
1905         * common/gdb_unique_ptr.h: Rename include guard.
1906         * common/gdb_tilde_expand.h: Rename include guard.
1907         * common/gdb_sys_time.h: Rename include guard.
1908         * common/gdb_string_view.h: Rename include guard.
1909         * common/gdb_splay_tree.h: Rename include guard.
1910         * common/gdb_setjmp.h: Rename include guard.
1911         * common/gdb_ref_ptr.h: Rename include guard.
1912         * common/gdb_optional.h: Rename include guard.
1913         * common/gdb_locale.h: Rename include guard.
1914         * common/gdb_assert.h: Rename include guard.
1915         * common/filtered-iterator.h: Rename include guard.
1916         * common/filestuff.h: Rename include guard.
1917         * common/fileio.h: Rename include guard.
1918         * common/environ.h: Rename include guard.
1919         * common/common-utils.h: Rename include guard.
1920         * common/common-types.h: Rename include guard.
1921         * common/common-regcache.h: Rename include guard.
1922         * common/common-inferior.h: Rename include guard.
1923         * common/common-gdbthread.h: Rename include guard.
1924         * common/common-exceptions.h: Rename include guard.
1925         * common/common-defs.h: Rename include guard.
1926         * common/common-debug.h: Rename include guard.
1927         * common/cleanups.h: Rename include guard.
1928         * common/buffer.h: Rename include guard.
1929         * common/btrace-common.h: Rename include guard.
1930         * common/break-common.h: Rename include guard.
1931         * cli/cli-utils.h: Rename include guard.
1932         * cli/cli-style.h: Rename include guard.
1933         * cli/cli-setshow.h: Rename include guard.
1934         * cli/cli-script.h: Rename include guard.
1935         * cli/cli-interp.h: Rename include guard.
1936         * cli/cli-decode.h: Rename include guard.
1937         * cli/cli-cmds.h: Rename include guard.
1938         * charset-list.h: Add include guard.
1939         * buildsym-legacy.h: Rename include guard.
1940         * bfin-tdep.h: Add include guard.
1941         * ax.h: Rename include guard.
1942         * arm-linux-tdep.h: Add include guard.
1943         * arm-fbsd-tdep.h: Add include guard.
1944         * arch/xtensa.h: Rename include guard.
1945         * arch/tic6x.h: Add include guard.
1946         * arch/i386.h: Add include guard.
1947         * arch/arm.h: Rename include guard.
1948         * arch/arm-linux.h: Rename include guard.
1949         * arch/arm-get-next-pcs.h: Rename include guard.
1950         * arch/amd64.h: Add include guard.
1951         * arch/aarch64-insn.h: Rename include guard.
1952         * arch-utils.h: Rename include guard.
1953         * annotate.h: Add include guard.
1954         * amd64-darwin-tdep.h: Rename include guard.
1955         * aarch64-linux-tdep.h: Add include guard.
1956         * aarch64-fbsd-tdep.h: Add include guard.
1957         * aarch32-linux-nat.h: Add include guard.
1958
1959 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1960
1961         * macrotab.c (macro_define_internal): New function that
1962         factorizes macro_define_object_internal and macro_define_function
1963         code.
1964         (macro_define_object_internal): Use macro_define_internal.
1965         (macro_define_function): Likewise.
1966
1967 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1968
1969         * macrocmd.c (extract_identifier): Return
1970         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
1971         callers.
1972
1973 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
1974
1975         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
1976
1977 2019-02-05  Tom Tromey  <tom@tromey.com>
1978
1979         * target.c (target_stack::unpush): Move assertion earlier.
1980
1981 2019-01-30  Tom Tromey  <tom@tromey.com>
1982
1983         PR python/23615:
1984         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
1985         (gdbpy_parse_and_eval): Likewise.
1986         * python/python-internal.h (gdbpy_allow_threads): New class.
1987
1988 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
1989
1990         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
1991         (aarch64_fbsd_fpregmap): Move earlier.
1992         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
1993         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1994         instead of individual calls to trad_frame_set_reg_addr.
1995         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
1996         earlier.
1997         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
1998         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
1999         instead of individual calls to trad_frame_set_reg_addr.
2000
2001 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
2002
2003         * CONTRIBUTE: Replace contribution list with wiki link.
2004
2005 2019-01-25  Tom Tromey  <tom@tromey.com>
2006
2007         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
2008
2009 2019-01-25  Tom Tromey  <tom@tromey.com>
2010
2011         * xtensa-linux-nat.c: Fix common/ includes.
2012         * xml-support.h: Fix common/ includes.
2013         * xml-support.c: Fix common/ includes.
2014         * x86-linux-nat.c: Fix common/ includes.
2015         * windows-nat.c: Fix common/ includes.
2016         * varobj.h: Fix common/ includes.
2017         * varobj.c: Fix common/ includes.
2018         * value.c: Fix common/ includes.
2019         * valops.c: Fix common/ includes.
2020         * utils.c: Fix common/ includes.
2021         * unittests/xml-utils-selftests.c: Fix common/ includes.
2022         * unittests/utils-selftests.c: Fix common/ includes.
2023         * unittests/unpack-selftests.c: Fix common/ includes.
2024         * unittests/tracepoint-selftests.c: Fix common/ includes.
2025         * unittests/style-selftests.c: Fix common/ includes.
2026         * unittests/string_view-selftests.c: Fix common/ includes.
2027         * unittests/scoped_restore-selftests.c: Fix common/ includes.
2028         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
2029         * unittests/scoped_fd-selftests.c: Fix common/ includes.
2030         * unittests/rsp-low-selftests.c: Fix common/ includes.
2031         * unittests/parse-connection-spec-selftests.c: Fix common/
2032         includes.
2033         * unittests/optional-selftests.c: Fix common/ includes.
2034         * unittests/offset-type-selftests.c: Fix common/ includes.
2035         * unittests/observable-selftests.c: Fix common/ includes.
2036         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
2037         * unittests/memrange-selftests.c: Fix common/ includes.
2038         * unittests/memory-map-selftests.c: Fix common/ includes.
2039         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
2040         * unittests/function-view-selftests.c: Fix common/ includes.
2041         * unittests/environ-selftests.c: Fix common/ includes.
2042         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
2043         * unittests/common-utils-selftests.c: Fix common/ includes.
2044         * unittests/cli-utils-selftests.c: Fix common/ includes.
2045         * unittests/array-view-selftests.c: Fix common/ includes.
2046         * ui-file.c: Fix common/ includes.
2047         * tui/tui-io.c: Fix common/ includes.
2048         * tracepoint.h: Fix common/ includes.
2049         * tracepoint.c: Fix common/ includes.
2050         * tracefile-tfile.c: Fix common/ includes.
2051         * top.h: Fix common/ includes.
2052         * top.c: Fix common/ includes.
2053         * thread.c: Fix common/ includes.
2054         * target/waitstatus.h: Fix common/ includes.
2055         * target/waitstatus.c: Fix common/ includes.
2056         * target.h: Fix common/ includes.
2057         * target.c: Fix common/ includes.
2058         * target-memory.c: Fix common/ includes.
2059         * target-descriptions.c: Fix common/ includes.
2060         * symtab.h: Fix common/ includes.
2061         * symfile.c: Fix common/ includes.
2062         * stap-probe.c: Fix common/ includes.
2063         * spu-linux-nat.c: Fix common/ includes.
2064         * sparc-nat.c: Fix common/ includes.
2065         * source.c: Fix common/ includes.
2066         * solib.c: Fix common/ includes.
2067         * solib-target.c: Fix common/ includes.
2068         * ser-unix.c: Fix common/ includes.
2069         * ser-tcp.c: Fix common/ includes.
2070         * ser-pipe.c: Fix common/ includes.
2071         * ser-base.c: Fix common/ includes.
2072         * selftest-arch.c: Fix common/ includes.
2073         * s12z-tdep.c: Fix common/ includes.
2074         * rust-exp.y: Fix common/ includes.
2075         * rs6000-aix-tdep.c: Fix common/ includes.
2076         * riscv-tdep.c: Fix common/ includes.
2077         * remote.c: Fix common/ includes.
2078         * remote-notif.h: Fix common/ includes.
2079         * remote-fileio.h: Fix common/ includes.
2080         * remote-fileio.c: Fix common/ includes.
2081         * regcache.h: Fix common/ includes.
2082         * regcache.c: Fix common/ includes.
2083         * record-btrace.c: Fix common/ includes.
2084         * python/python.c: Fix common/ includes.
2085         * python/py-type.c: Fix common/ includes.
2086         * python/py-inferior.c: Fix common/ includes.
2087         * progspace.h: Fix common/ includes.
2088         * producer.c: Fix common/ includes.
2089         * procfs.c: Fix common/ includes.
2090         * proc-api.c: Fix common/ includes.
2091         * printcmd.c: Fix common/ includes.
2092         * ppc-linux-nat.c: Fix common/ includes.
2093         * parser-defs.h: Fix common/ includes.
2094         * osdata.c: Fix common/ includes.
2095         * obsd-nat.c: Fix common/ includes.
2096         * nat/x86-linux.c: Fix common/ includes.
2097         * nat/x86-linux-dregs.c: Fix common/ includes.
2098         * nat/x86-dregs.h: Fix common/ includes.
2099         * nat/x86-dregs.c: Fix common/ includes.
2100         * nat/ppc-linux.c: Fix common/ includes.
2101         * nat/mips-linux-watch.h: Fix common/ includes.
2102         * nat/mips-linux-watch.c: Fix common/ includes.
2103         * nat/linux-waitpid.c: Fix common/ includes.
2104         * nat/linux-ptrace.h: Fix common/ includes.
2105         * nat/linux-ptrace.c: Fix common/ includes.
2106         * nat/linux-procfs.c: Fix common/ includes.
2107         * nat/linux-personality.c: Fix common/ includes.
2108         * nat/linux-osdata.c: Fix common/ includes.
2109         * nat/linux-namespaces.c: Fix common/ includes.
2110         * nat/linux-btrace.h: Fix common/ includes.
2111         * nat/linux-btrace.c: Fix common/ includes.
2112         * nat/fork-inferior.c: Fix common/ includes.
2113         * nat/amd64-linux-siginfo.c: Fix common/ includes.
2114         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
2115         * nat/aarch64-linux.c: Fix common/ includes.
2116         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
2117         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
2118         * namespace.h: Fix common/ includes.
2119         * mips-linux-tdep.c: Fix common/ includes.
2120         * minsyms.c: Fix common/ includes.
2121         * mi/mi-parse.h: Fix common/ includes.
2122         * mi/mi-main.c: Fix common/ includes.
2123         * mi/mi-cmd-env.c: Fix common/ includes.
2124         * memrange.h: Fix common/ includes.
2125         * memattr.c: Fix common/ includes.
2126         * maint.h: Fix common/ includes.
2127         * maint.c: Fix common/ includes.
2128         * main.c: Fix common/ includes.
2129         * machoread.c: Fix common/ includes.
2130         * location.c: Fix common/ includes.
2131         * linux-thread-db.c: Fix common/ includes.
2132         * linux-nat.c: Fix common/ includes.
2133         * linux-fork.c: Fix common/ includes.
2134         * inline-frame.c: Fix common/ includes.
2135         * infrun.c: Fix common/ includes.
2136         * inflow.c: Fix common/ includes.
2137         * inferior.h: Fix common/ includes.
2138         * inferior.c: Fix common/ includes.
2139         * infcmd.c: Fix common/ includes.
2140         * inf-ptrace.c: Fix common/ includes.
2141         * inf-child.c: Fix common/ includes.
2142         * ia64-linux-nat.c: Fix common/ includes.
2143         * i387-tdep.c: Fix common/ includes.
2144         * i386-tdep.c: Fix common/ includes.
2145         * i386-linux-tdep.c: Fix common/ includes.
2146         * i386-linux-nat.c: Fix common/ includes.
2147         * i386-go32-tdep.c: Fix common/ includes.
2148         * i386-fbsd-tdep.c: Fix common/ includes.
2149         * i386-fbsd-nat.c: Fix common/ includes.
2150         * guile/scm-type.c: Fix common/ includes.
2151         * guile/guile.c: Fix common/ includes.
2152         * go32-nat.c: Fix common/ includes.
2153         * gnu-nat.c: Fix common/ includes.
2154         * gdbthread.h: Fix common/ includes.
2155         * gdbarch-selftests.c: Fix common/ includes.
2156         * gdb_usleep.c: Fix common/ includes.
2157         * gdb_select.h: Fix common/ includes.
2158         * gdb_bfd.c: Fix common/ includes.
2159         * gcore.c: Fix common/ includes.
2160         * fork-child.c: Fix common/ includes.
2161         * findvar.c: Fix common/ includes.
2162         * fbsd-nat.c: Fix common/ includes.
2163         * event-top.c: Fix common/ includes.
2164         * event-loop.c: Fix common/ includes.
2165         * dwarf2read.c: Fix common/ includes.
2166         * dwarf2loc.c: Fix common/ includes.
2167         * dwarf2-frame.c: Fix common/ includes.
2168         * dwarf-index-cache.c: Fix common/ includes.
2169         * dtrace-probe.c: Fix common/ includes.
2170         * disasm-selftests.c: Fix common/ includes.
2171         * defs.h: Fix common/ includes.
2172         * csky-tdep.c: Fix common/ includes.
2173         * cp-valprint.c: Fix common/ includes.
2174         * cp-support.h: Fix common/ includes.
2175         * cp-support.c: Fix common/ includes.
2176         * corelow.c: Fix common/ includes.
2177         * completer.h: Fix common/ includes.
2178         * completer.c: Fix common/ includes.
2179         * compile/compile.c: Fix common/ includes.
2180         * compile/compile-loc2c.c: Fix common/ includes.
2181         * compile/compile-cplus-types.c: Fix common/ includes.
2182         * compile/compile-cplus-symbols.c: Fix common/ includes.
2183         * command.h: Fix common/ includes.
2184         * cli/cli-dump.c: Fix common/ includes.
2185         * cli/cli-cmds.c: Fix common/ includes.
2186         * charset.c: Fix common/ includes.
2187         * build-id.c: Fix common/ includes.
2188         * btrace.h: Fix common/ includes.
2189         * btrace.c: Fix common/ includes.
2190         * breakpoint.h: Fix common/ includes.
2191         * breakpoint.c: Fix common/ includes.
2192         * ax.h:
2193         (enum agent_op): Fix common/ includes.
2194         * ax-general.c (struct aop_map): Fix common/ includes.
2195         * ax-gdb.c: Fix common/ includes.
2196         * auxv.c: Fix common/ includes.
2197         * auto-load.c: Fix common/ includes.
2198         * arm-tdep.c: Fix common/ includes.
2199         * arch/riscv.c: Fix common/ includes.
2200         * arch/ppc-linux-common.c: Fix common/ includes.
2201         * arch/i386.c: Fix common/ includes.
2202         * arch/arm.c: Fix common/ includes.
2203         * arch/arm-linux.c: Fix common/ includes.
2204         * arch/arm-get-next-pcs.c: Fix common/ includes.
2205         * arch/amd64.c: Fix common/ includes.
2206         * arch/aarch64.c: Fix common/ includes.
2207         * arch/aarch64-insn.c: Fix common/ includes.
2208         * arch-utils.c: Fix common/ includes.
2209         * amd64-windows-tdep.c: Fix common/ includes.
2210         * amd64-tdep.c: Fix common/ includes.
2211         * amd64-sol2-tdep.c: Fix common/ includes.
2212         * amd64-obsd-tdep.c: Fix common/ includes.
2213         * amd64-nbsd-tdep.c: Fix common/ includes.
2214         * amd64-linux-tdep.c: Fix common/ includes.
2215         * amd64-linux-nat.c: Fix common/ includes.
2216         * amd64-fbsd-tdep.c: Fix common/ includes.
2217         * amd64-fbsd-nat.c: Fix common/ includes.
2218         * amd64-dicos-tdep.c: Fix common/ includes.
2219         * amd64-darwin-tdep.c: Fix common/ includes.
2220         * agent.c: Fix common/ includes.
2221         * ada-lang.h: Fix common/ includes.
2222         * ada-lang.c: Fix common/ includes.
2223         * aarch64-tdep.c: Fix common/ includes.
2224
2225 2019-01-25  Tom Tromey  <tom@tromey.com>
2226
2227         * common/create-version.sh: Use common/version.h.
2228
2229 2019-01-24  Pedro Alves  <palves@redhat.com>
2230
2231         * infrun.c (signal_stop, signal_print, signal_program)
2232         (signal_catch, signal_pass): Now arrays instead of pointers.
2233         (update_signals_program_target, do_target_resume)
2234         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
2235         * linux-nat.c (linux_nat_target::pass_signals)
2236         (linux_nat_target::create_inferior, linux_nat_target::attach):
2237         Adjust.
2238         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
2239         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
2240         * procfs.c (procfs_target::pass_signals): Adjust.
2241         * record-full.c (record_full_target::resume): Adjust.
2242         * remote.c (remote_target::pass_signals)
2243         (remote_target::program_signals): Adjust.
2244         * target-debug.h (target_debug_print_signals): Now takes a
2245         gdb::array_view as parameter.  Adjust.
2246         * target.h (target_ops) <pass_signals, program_signals>: Replace
2247         pointer and length parameters with gdb::array_view.
2248         (target_pass_signals, target_program_signals): Likewise.
2249         * target-delegates.c: Regenerate.
2250
2251 2019-01-24  Pedro Alves  <palves@redhat.com>
2252
2253         * common/forward-scope-exit.h
2254         (forward_scope_exit::forward_scope_exit): Pass arguments to
2255         m_bind_function directly, instead of creating a std::bind and
2256         copying that.
2257
2258 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
2259
2260         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2261         for static members.
2262         (pass_in_v_vfp_candidate): Likewise.
2263
2264 2019-01-23  Tom Tromey  <tom@tromey.com>
2265             Pedro Alves  <palves@redhat.com>
2266
2267         * regcache.c (class regcache_invalidator): Remove.
2268         (regcache::raw_write): Use make_scope_exit.
2269
2270 2019-01-23  Tom Tromey  <tom@tromey.com>
2271
2272         * ui-out.h (class ui_out_emit_type): Update comment.
2273
2274 2019-01-23  Tom Tromey  <tom@tromey.com>
2275
2276         * infrun.c (fetch_inferior_event): Update comment.
2277
2278 2019-01-23  Tom Tromey  <tom@tromey.com>
2279             Pedro Alves  <palves@redhat.com>
2280
2281         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
2282         parameter.
2283         (fetch_inferior_event): Use SCOPE_EXIT.
2284
2285
2286 2019-01-23  Tom Tromey  <tom@tromey.com>
2287             Pedro Alves  <palves@redhat.com>
2288
2289         * infrun.c (disable_thread_events): Delete.
2290         (stop_all_threads): Use SCOPE_EXIT.
2291
2292 2019-01-23  Tom Tromey  <tom@tromey.com>
2293             Pedro Alves  <palves@redhat.com>
2294
2295         * symfile.c: Include forward-scope-exit.h.
2296         (clear_symtab_users_cleanup): Replace forward declaration with
2297         a FORWARD_SCOPE_EXIT.
2298         (syms_from_objfile_1): Use the forward_scope_exit and
2299         gdb::optional instead of cleanup_function.
2300         (reread_symbols): Use the forward_scope_exit instead of
2301         cleanup_function.
2302         (clear_symtab_users_cleanup): Remove function.
2303
2304 2019-01-23  Tom Tromey  <tom@tromey.com>
2305             Pedro Alves  <palves@redhat.com>
2306
2307         * linux-nat.c: Include scope-exit.h.
2308         (cleanup_target_stop): Remove.
2309         (linux_nat_target::static_tracepoint_markers_by_strid): Use
2310         SCOPE_EXIT.
2311
2312 2019-01-23  Tom Tromey  <tom@tromey.com>
2313             Pedro Alves  <palves@redhat.com>
2314
2315         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
2316         (call_function_by_hand_dummy): Use SCOPE_EXIT.
2317
2318 2019-01-23  Tom Tromey  <tom@tromey.com>
2319             Andrew Burgess  <andrew.burgess@embecosm.com>
2320             Pedro Alves  <palves@redhat.com>
2321
2322         * infrun.c (fetch_inferior_event): Use scope_exit.
2323         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
2324         * top.c (execute_command): Use scope_exit.
2325         * breakpoint.c (bpstat_do_actions): Use scope_exit.
2326         * utils.c (do_bpstat_clear_actions_cleanup)
2327         (make_bpstat_clear_actions_cleanup): Remove.
2328
2329 2019-01-23  Tom Tromey  <tom@tromey.com>
2330             Pedro Alves  <palves@redhat.com>
2331
2332         * infrun.c: Include "common/scope-exit.h"
2333         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
2334         (wait_for_inferior): Use SCOPE_EXIT.
2335         (fetch_inferior_event): Use scope_exit.
2336
2337 2019-01-23  Tom Tromey  <tom@tromey.com>
2338             Pedro Alves  <palves@redhat.com>
2339
2340         * breakpoint.c (create_breakpoint): Remove cleanup.
2341
2342 2019-01-23  Tom Tromey  <tom@tromey.com>
2343             Andrew Burgess  <andrew.burgess@embecosm.com>
2344             Pedro Alves  <palves@redhat.com>
2345
2346 2019-01-23  Pedro Alves  <palves@redhat.com>
2347
2348         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
2349
2350 2019-01-23  Pedro Alves  <palves@redhat.com>
2351             Andrew Burgess  <andrew.burgess@embecosm.com>
2352
2353         * gdbthread.h: Include "common/forward-scope-exit.h".
2354         (scoped_finish_thread_state): Redefine custom class in terms of
2355         forward_scope_exit.
2356
2357 2019-01-23  Pedro Alves  <palves@redhat.com>
2358             Andrew Burgess  <andrew.burgess@embecosm.com>
2359
2360         * common/forward-scope-exit.h: New file.
2361
2362 2019-01-23  Pedro Alves  <palves@redhat.com>
2363             Andrew Burgess  <andrew.burgess@embecosm.com>
2364             Tom Tromey  <tom@tromey.com>
2365
2366         * common/scope-exit.h: New file.
2367
2368 2019-01-23  Pedro Alves  <palves@redhat.com>
2369
2370         * common/preprocessor.h (ESC): Rename to ...
2371         (ESC_PARENS): ... this.
2372         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
2373         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
2374
2375 2019-01-23  Tom Tromey  <tom@tromey.com>
2376
2377         * language.h (class scoped_switch_to_sym_language_if_auto):
2378         Initialize m_lang in both cases.
2379
2380 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
2381
2382         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
2383         with XCNEW.
2384
2385 2019-01-22  Tom Tromey  <tom@tromey.com>
2386
2387         * corelow.c: Do not include sys/file.h.
2388
2389 2019-01-22  Tom Tromey  <tom@tromey.com>
2390
2391         * tui/tui-wingeneral.h: Include gdb_curses.h.
2392
2393 2019-01-22  Tom Tromey  <tom@tromey.com>
2394
2395         * source-cache.h (class source_cache) <get_source_lines,
2396         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
2397
2398 2019-01-22  Tom Tromey  <tom@tromey.com>
2399
2400         * remote-fileio.h (struct remote_target): Declare.
2401
2402 2019-01-22  Tom Tromey  <tom@tromey.com>
2403
2404         * python/py-arch.c: Do not include py-ref.h.
2405         * python/py-bpevent.c: Do not include py-ref.h.
2406         * python/py-cmd.c: Do not include py-ref.h.
2407         * python/py-continueevent.c: Do not include py-ref.h.
2408         * python/py-event.h: Do not include py-ref.h.
2409         * python/py-evtregistry.c: Do not include py-ref.h.
2410         * python/py-finishbreakpoint.c: Do not include py-ref.h.
2411         * python/py-frame.c: Do not include py-ref.h.
2412         * python/py-framefilter.c: Do not include py-ref.h.
2413         * python/py-function.c: Do not include py-ref.h.
2414         * python/py-infevents.c: Do not include py-ref.h.
2415         * python/py-linetable.c: Do not include py-ref.h.
2416         * python/py-objfile.c: Do not include py-ref.h.
2417         * python/py-param.c: Do not include py-ref.h.
2418         * python/py-prettyprint.c: Do not include py-ref.h.
2419         * python/py-progspace.c: Do not include py-ref.h.
2420         * python/py-symbol.c: Do not include py-ref.h.
2421         * python/py-symtab.c: Do not include py-ref.h.
2422         * python/py-type.c: Do not include py-ref.h.
2423         * python/py-unwind.c: Do not include py-ref.h.
2424         * python/py-utils.c: Do not include py-ref.h.
2425         * python/py-value.c: Do not include py-ref.h.
2426         * python/py-varobj.c: Do not include py-ref.h.
2427         * python/py-xmethods.c: Do not include py-ref.h.
2428         * python/python.c: Do not include py-ref.h.
2429         * varobj.c: Do not include py-ref.h.
2430
2431 2019-01-22  Tom Tromey  <tom@tromey.com>
2432
2433         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
2434         keyword for bcache.
2435
2436 2019-01-22  Tom Tromey  <tom@tromey.com>
2437
2438         * compile/compile-cplus-types.c: Remove a comment by #include.
2439
2440 2019-01-22  Tom Tromey  <tom@tromey.com>
2441
2442         * compile/gcc-c-plugin.h: Include compile-internal.h.
2443
2444 2019-01-22  Tom Tromey  <tom@tromey.com>
2445
2446         * stabsread.c (EXTERN): Do not define.
2447         (symnum, next_symbol_text_func, processing_gcc_compilation)
2448         (within_function, global_sym_chain, global_stabs)
2449         (previous_stab_code, this_object_header_files)
2450         (n_this_object_header_files)
2451         (n_allocated_this_object_header_files): Define.
2452         * stabsread.h (EXTERN): Never define.  Use "extern".
2453
2454 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2455
2456         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
2457         history_value.
2458
2459 2019-01-21  Tom Tromey  <tom@tromey.com>
2460
2461         * ui-out.c: Fix includes.
2462         * tui/tui-source.c: Fix includes.
2463         * target.c: Fix includes.
2464         * remote.c: Fix includes.
2465         * regcache.c: Fix includes.
2466         * python/py-block.c: Fix includes.
2467         * printcmd.c: Fix includes.
2468         * or1k-tdep.c: Fix includes.
2469         * mi/mi-main.c: Fix includes.
2470         * m32r-tdep.c: Fix includes.
2471         * csky-tdep.c: Fix includes.
2472         * compile/compile-cplus-types.c: Fix includes.
2473         * cli/cli-interp.c: Fix includes.
2474
2475 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
2476
2477         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
2478         for padding.
2479
2480 2019-01-16  Tom Tromey  <tom@tromey.com>
2481
2482         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
2483         earlier.
2484         (struct objfile) <msymbols_range>: Move from top level.
2485         <msymbols>: New method.
2486         (class objfile_msymbols): Remove.
2487         * symtab.c (default_collect_symbol_completion_matches_break_on):
2488         Update.
2489         * symmisc.c (dump_msymbols): Update.
2490         * stabsread.c (scan_file_globals): Update.
2491         * objc-lang.c (info_selectors_command, info_classes_command)
2492         (find_methods): Update.
2493         * minsyms.c (find_solib_trampoline_target): Update.
2494         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2495         * coffread.c (coff_symfile_read): Update.
2496         * ada-lang.c (ada_lookup_simple_minsym)
2497         (ada_collect_symbol_completion_matches): Update.
2498
2499 2019-01-16  Tom Tromey  <tom@tromey.com>
2500
2501         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
2502         type.  Remove no-argument constructor.
2503         <iterator::operator++>: Simplify.
2504         <begin>: Update.
2505         <end>: Use minimal_symbol_count.
2506
2507 2019-01-16  Tom Tromey  <tom@tromey.com>
2508
2509         * objfiles.h (struct objfile) <psymtabs>: New method.
2510         (class objfile_psymtabs): Remove.
2511         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
2512         typedef.
2513         <range>: New method.
2514         (require_partial_symbols): Change return type.
2515         * psymtab.c (require_partial_symbols)
2516         (psym_expand_symtabs_matching): Update.
2517         * mdebugread.c (parse_partial_symbols): Update.
2518         * dbxread.c (dbx_end_psymtab): Update.
2519
2520 2019-01-15  Tom Tromey  <tom@tromey.com>
2521
2522         * symtab.c (lookup_objfile_from_block)
2523         (lookup_symbol_in_objfile_symtabs)
2524         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
2525         (find_line_symtab, info_sources_command)
2526         (default_collect_symbol_completion_matches_break_on)
2527         (make_source_files_completion_list): Update.
2528         * symmisc.c (print_objfile_statistics, dump_objfile)
2529         (maintenance_print_symbols, maintenance_info_symtabs)
2530         (maintenance_check_symtabs, maintenance_info_line_tables):
2531         Update.
2532         * source.c (select_source_symtab)
2533         (forget_cached_source_info_for_objfile): Update.
2534         * objfiles.h (class objfile_compunits): Remove.
2535         (struct objfile) <compunits_range>: New typedef.
2536         (compunits): New method.
2537         * objfiles.c (objfile_relocate1): Update.
2538         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2539         * maint.c (count_symtabs_and_blocks): Update.
2540         * linespec.c (iterate_over_all_matching_symtabs): Update.
2541         * cp-support.c (add_symbol_overload_list_qualified): Update.
2542         * coffread.c (coff_symtab_read): Update.
2543         * ada-lang.c (add_nonlocal_symbols)
2544         (ada_collect_symbol_completion_matches)
2545         (ada_add_global_exceptions): Update.
2546
2547 2019-01-15  Tom Tromey  <tom@tromey.com>
2548
2549         * progspace.h (program_space) <objfiles_safe_range>: New
2550         typedef.
2551         <objfiles_safe>: New method.
2552         * objfiles.h (class all_objfiles_safe): Remove.
2553         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
2554         * jit.c (jit_inferior_exit_hook): Update.
2555
2556 2019-01-17  Tom Tromey  <tom@tromey.com>
2557
2558         * progspace.h (program_space) <objfiles_range>: New typedef.
2559         <objfiles>: New method.
2560         <objfiles_head>: Rename from objfiles.
2561         (object_files): Update.
2562         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
2563         * guile/scm-pretty-print.c
2564         (ppscm_find_pretty_printer_from_objfiles): Update.
2565         * guile/scm-objfile.c (gdbscm_objfiles): Update.
2566         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
2567         Update.
2568         * python/py-progspace.c (pspy_get_objfiles): Update.
2569         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
2570         Update.
2571         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
2572         (objfpy_lookup_objfile_by_build_id): Update.
2573         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
2574         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
2575         Update.
2576         * symtab.c (iterate_over_symtabs, matching_obj_sections)
2577         (expand_symtab_containing_pc, lookup_objfile_from_block)
2578         (lookup_static_symbol, basic_lookup_transparent_type)
2579         (find_pc_sect_compunit_symtab, find_symbol_at_address)
2580         (find_line_symtab, info_sources_command)
2581         (default_collect_symbol_completion_matches_break_on)
2582         (make_source_files_completion_list, find_main_name): Update.
2583         * symmisc.c (print_symbol_bcache_statistics)
2584         (print_objfile_statistics, maintenance_print_symbols)
2585         (maintenance_print_msymbols, maintenance_print_objfiles)
2586         (maintenance_info_symtabs, maintenance_check_symtabs)
2587         (maintenance_expand_symtabs, maintenance_info_line_tables):
2588         Update.
2589         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
2590         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
2591         (map_overlay_command, unmap_overlay_command)
2592         (simple_overlay_update, expand_symtabs_matching)
2593         (map_symbol_filenames): Update.
2594         * symfile-debug.c (set_debug_symfile): Update.
2595         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
2596         Update.
2597         * source.c (select_source_symtab, forget_cached_source_info):
2598         Update.
2599         * solib.c (solib_read_symbols): Update.
2600         * solib-spu.c (append_ocl_sos): Update.
2601         * psymtab.c (maintenance_print_psymbols)
2602         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
2603         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
2604         * printcmd.c (info_symbol_command): Update.
2605         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
2606         Update.
2607         * objfiles.h (class all_objfiles): Remove.
2608         * objfiles.c (have_partial_symbols, have_full_symbols)
2609         (have_minimal_symbols, qsort_cmp, update_section_map)
2610         (shared_objfile_contains_address_p)
2611         (default_iterate_over_objfiles_in_search_order): Update.
2612         * objc-lang.c (info_selectors_command, info_classes_command)
2613         (find_methods): Update.
2614         * minsyms.c (find_solib_trampoline_target): Update.
2615         * maint.c (maintenance_info_sections)
2616         (maintenance_translate_address, count_symtabs_and_blocks):
2617         Update.
2618         * main.c (captured_main_1): Update.
2619         * linux-thread-db.c (try_thread_db_load_from_pdir)
2620         (has_libpthread): Update.
2621         * linespec.c (iterate_over_all_matching_symtabs)
2622         (search_minsyms_for_name): Update.
2623         * jit.c (jit_find_objf_with_entry_addr): Update.
2624         * hppa-tdep.c (find_unwind_entry)
2625         (hppa_lookup_stub_minimal_symbol): Update.
2626         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
2627         Update.
2628         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
2629         (elf_gnu_ifunc_resolve_by_got): Update.
2630         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
2631         * dwarf-index-write.c (save_gdb_index_command): Update.
2632         * cp-support.c (add_symbol_overload_list_qualified): Update.
2633         * breakpoint.c (create_overlay_event_breakpoint)
2634         (create_longjmp_master_breakpoint)
2635         (create_std_terminate_master_breakpoint)
2636         (create_exception_master_breakpoint): Update.
2637         * blockframe.c (find_pc_partial_function): Update.
2638         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
2639         (ada_collect_symbol_completion_matches)
2640         (ada_add_global_exceptions): Update.
2641
2642 2019-01-17  Tom Tromey  <tom@tromey.com>
2643
2644         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
2645         declare VEC.
2646         (solib_target_parse_libraries): Change return type.
2647         (library_list_start_segment, library_list_start_section)
2648         (library_list_end_library, library_list_start_library); Update.
2649         (solib_target_free_library_list): Remove.
2650         (solib_target_parse_libraries): Remove cleanup.  Change return
2651         type.
2652         (solib_target_current_sos): Update.
2653
2654 2019-01-17  Tom Tromey  <tromey@bapiya>
2655
2656         * valprint.c: Replace "the the" with "the".
2657         * symtab.c: Replace "the the" with "the".
2658         * solib.c: Replace "the the" with "the".
2659         * solib-dsbt.c: Replace "the the" with "the".
2660         * linespec.c: Replace "the the" with "the".
2661         * dwarf2loc.h: Replace "the the" with "the".
2662         * amd64-windows-tdep.c: Replace "the the" with "the".
2663         * aarch64-tdep.c: Replace "the the" with "the".
2664
2665 2019-01-16  Keith Seitz  <keiths@redhat.com>
2666
2667         PR gdb/23773
2668         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
2669         <builder>: Rename to ..
2670         <m_builder>: ... this and make private.
2671         (dwarf2_cu::get_builder): New method.  Change all users of
2672         `builder' to use this method.
2673         (dwarf2_start_symtab): Move to ...
2674         (dwarf2_cu::start_symtab): ... here.  Update all callers
2675         (setup_type_unit_groups): Move to ...
2676         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
2677         callers.
2678         (dwarf2_cu::reset_builder): New method.
2679         (process_full_compunit, process_full_type_unit): Use
2680         dwarf2_cu::reset_builder.
2681         (follow_die_offset): Record the ancestor CU if it is different
2682         from the followed DIE's CU.
2683         (follow_die_sig_1): Likewise.
2684
2685 2019-01-15  Tom Tromey  <tom@tromey.com>
2686
2687         * remote.c (class remote_state) <buf>: Now a char_vector.
2688         <buf_size>: Remove.
2689         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
2690         parameter.
2691         (remote_target::getpkt_or_notif_sane_1)
2692         (remote_target::getpkt_sane)
2693         (remote_target::getpkt_or_notif_sane): Likewise.
2694         (class remote_target) <putpkt>: New overload.
2695         (remote_target::read_frame): Change type of "buf_p".  Remove
2696         sizeof_p parameter.
2697         (packet_ok): New overload.
2698         (packet_check_result): New overload.
2699         Update all uses.
2700
2701 2019-01-14  Tom Tromey  <tom@tromey.com>
2702
2703         * remote-notif.c (handle_notification, remote_notif_ack)
2704         (remote_notif_parse): Make "buf" const.
2705         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
2706         const.
2707         (remote_notif_parse, remote_notif_ack, handle_notification):
2708         Likewise.
2709         * remote.c (remote_notif_stop_parse): Make "buf" const.
2710         (remote_target::remote_parse_stop_reply): Make "buf" const.
2711         (remote_notif_stop_ack): Make "buf" const.
2712
2713 2019-01-14  Tom Tromey  <tom@tromey.com>
2714
2715         * remote.c (remote_console_output): Make parameter const.
2716
2717 2019-01-14  Tom Tromey  <tom@tromey.com>
2718
2719         * target-debug.h (target_debug_print_signals): Constify.
2720         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
2721         * procfs.c (procfs_target::pass_signals): Update.
2722         * linux-nat.c (linux_nat_target::pass_signals): Update.
2723         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
2724         * target-delegates.c: Rebuild.
2725         * remote.c (remote_target::program_signals): Update.
2726         (remote_target::pass_signals): Update.
2727         * target.c (target_pass_signals): Constify argument.
2728         (target_program_signals): Likewise.
2729         * target.h (struct target_ops) <pass_signals, program_signals>:
2730         Constify argument.
2731         (target_pass_signals, target_program_signals): Constify argument.
2732
2733 2019-01-14  Tom Tromey  <tom@tromey.com>
2734
2735         PR tui/28819:
2736         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
2737
2738 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2739
2740         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
2741         field.
2742         * rs6000-tdep.c: Include reggroups.h.
2743         (IS_V_ALIAS_PSEUDOREG): Define.
2744         (rs6000_register_name): Return names for the "vX" aliases.
2745         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
2746         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
2747         aliases.  Call default_register_reggroup_p for all other
2748         pseudo-registers.
2749         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
2750         New functions.
2751         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
2752         Handle "vX" aliases.
2753         (v_alias_pseudo_register_collect): New function.
2754         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
2755         (rs6000_gdbarch_init): Initialize "vX" aliases as
2756         pseudo-registers.  Restore registration of
2757         rs6000_pseudo_register_reggroup_p with
2758         set_tdesc_pseudo_register_reggroup_p.
2759
2760 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
2761
2762         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
2763         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
2764         set_gdbarch_num_pseudo_regs.
2765
2766 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2767
2768         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
2769         Remove arg prefixname, add do_set and do_show.
2770         Add member functions set_list and show_list.
2771         * cli/cli-style.c (class cli_style_option): Update accordingly.
2772         (style_set_list): Move to file scope.
2773         (style_show_list): Likewise.
2774         (set_style): Call help_list.
2775         (show_style): Call cmd_show_list.
2776         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
2777         Update to use the new macro.
2778
2779 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
2780
2781         * ada-lang.c (_initialize_ada_language): Expand the help text
2782         for the "catch exception" command.
2783
2784 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2785
2786         * symtab.c (matching_obj_sections): Initialize obj,
2787         declare it closer to its usage.
2788
2789 2019-01-10  Tom Tromey  <tom@tromey.com>
2790
2791         * thread-iter.h (inf_threads_iterator): Use next_iterator.
2792         (basic_inf_threads_range): Remove.
2793         (inf_threads_range, inf_non_exited_threads_range)
2794         (safe_inf_threads_range): Use next_adapter.
2795
2796 2019-01-10  Keith Seitz  <keiths@redhat.com>
2797
2798         PR gdb/23712
2799         PR symtab/23010
2800         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
2801         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
2802
2803 2019-01-10  Keith Seitz  <keiths@redhat.com>
2804
2805         PR gdb/23712
2806         PR symtab/23010
2807         * dictionary.c (pending_to_vector): Remove.
2808         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2809         Remove _1 suffix, replacing functions of the same name.  Update
2810         all callers.
2811         (dict_create_hashed, dict_create_hashed_expandable)
2812         (dict_create_linear, dict_create_linear_expandable, dict_free)
2813         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
2814         Make functions static.
2815
2816 2019-01-10  Keith Seitz  <keiths@redhat.com>
2817
2818         PR gdb/23712
2819         PR symtab/23010
2820         * dictionary.h (struct dictionary): Replace declaration with
2821         multidictionary.
2822         (dict_create_hashed, dict_create_hashed_expandable)
2823         (dict_create_linear, dict_create_linear_expandable)
2824         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
2825         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
2826         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
2827         taking multidictionary argument.
2828         [ALL_DICT_SYMBOLS]: Update for multidictionary.
2829         * block.h (struct block) <dict>: Change to multidictionary
2830         and rename `multidict'.
2831         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
2832         symmisc.c: Update all dictionary references to multidictionary.
2833
2834 2019-01-10  Keith Seitz  <keiths@redhat.com>
2835
2836         PR gdb/23712
2837         PR symtab/23010
2838         * dictionary.c: Include unordered_map.
2839         (pending_to_vector): New function.
2840         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
2841         Rewrite the non-"_1" functions to take vector instead
2842         of linked list.
2843         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
2844         "new" _1 versions of the same name.
2845         (multidictionary): Define.
2846         (std::hash<enum language): New definition.
2847         (collate_pending_symbols_by_language, mdict_create_hashed)
2848         (mdict_create_hashed_expandable, mdict_create_linear)
2849         (mdict_create_linear_expandable, mdict_free)
2850         (find_language_dictionary, create_new_language_dictionary)
2851         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
2852         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
2853         (mdict_size, mdict_empty): New functions.
2854         * dictionary.h (mdict_iterator): Define.
2855
2856 2019-01-10  Pedro Alves  <palves@redhat.com>
2857
2858         * breakpoint.c (read_uploaded_action)
2859         (create_tracepoint_from_upload): Adjust to use
2860         gdb::unique_xmalloc_ptr.
2861         * ctf.c (ctf_write_uploaded_tp):
2862         (SET_ARRAY_FIELD): Use emplace_back.
2863         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
2864         * tracefile-tfile.c (tfile_write_uploaded_tp):
2865         * tracepoint.c (parse_tracepoint_definition): Adjust to use
2866         gdb::unique_xmalloc_ptr.
2867         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
2868         at_string, cond_string, cmd_strings>: Replace char pointers
2869         with gdb::unique_xmalloc_ptr.
2870
2871 2019-01-10  Pedro Alves  <palves@redhat.com>
2872
2873         * solib-target.c (library_list_start_library): Don't xstrdup name.
2874
2875 2019-01-10  Pedro Alves  <palves@redhat.com>
2876
2877         * mdebugread.c (parse_partial_symbols): Use
2878         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
2879
2880 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2881
2882         * linux-fork.c (scoped_switch_fork_info)
2883         <~scoped_switch_fork_info>: Fix incorrect variable name.
2884
2885 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2886
2887         * linux-fork.c (scoped_switch_fork_info)
2888         <scoped_switch_fork_info>: Make explicit.
2889         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
2890
2891 2019-01-10  Tom Tromey  <tom@tromey.com>
2892
2893         * objfiles.h (objfile::reset_psymtabs): Update.
2894         * objfiles.c (objfile::objfile): Update.
2895         * psymtab.h (psymtab_storage::obstack): Update.
2896         (psymtab_storage::m_obstack): Use gdb::optional.
2897         (class psymtab_storage): Update comment.  Remove objfile
2898         parameter.
2899         * psymtab.c (psymtab_storage::psymtab_storage): Update.
2900
2901 2019-01-10  Tom Tromey  <tom@tromey.com>
2902
2903         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
2904         <free_psymtabs>: Now private.
2905         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
2906         (allocate_psymtab): Use new method.
2907
2908 2019-01-10  Tom Tromey  <tom@tromey.com>
2909
2910         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
2911         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
2912         * mdebugread.c (parse_partial_symbols): Use
2913         allocate_dependencies.
2914         * dwarf2read.c (dwarf2_create_include_psymtab): Use
2915         allocate_dependencies.
2916         (process_psymtab_comp_unit_reader)
2917         (build_type_psymtab_dependencies): Likewise.
2918         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
2919
2920 2019-01-10  Tom Tromey  <tom@tromey.com>
2921
2922         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
2923         PSYMBOL_SET_LANGUAGE.
2924         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
2925
2926 2019-01-10  Tom Tromey  <tom@tromey.com>
2927
2928         * psymtab.h (psymtab_storage::obstack): New method.
2929         <m_obstack>: Rename from obstack; now private.
2930         * psymtab.c (psymtab_storage): Update.
2931         * dwarf2read.c (create_addrmap_from_index)
2932         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
2933         Update.
2934
2935 2019-01-10  Tom Tromey  <tom@tromey.com>
2936
2937         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
2938         * objfiles.h (objfile::reset_psymtabs): New method.
2939
2940 2019-01-10  Tom Tromey  <tom@tromey.com>
2941
2942         * symmisc.c (print_symbol_bcache_statistics): Update.
2943         (print_objfile_statistics): Update.
2944         * symfile.c (reread_symbols): Update.
2945         * psymtab.h (class psymtab_storage): New.
2946         * psymtab.c (psymtab_storage): New constructor.
2947         (~psymtab_storage): New destructor.
2948         (require_partial_symbols): Update.
2949         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
2950         (find_pc_sect_psymtab, find_pc_sect_psymbol)
2951         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
2952         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
2953         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
2954         (start_psymtab_common, end_psymtab_common)
2955         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
2956         (allocate_psymtab): Update.
2957         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
2958         Update.
2959         (dump_psymtab_addrmap, maintenance_print_psymbols)
2960         (maintenance_check_psymtabs): Update.
2961         (class objfile_psymtabs): Move to objfiles.h.
2962         * psympriv.h (discard_psymtab): Now inline.
2963         (psymtab_discarder::psymtab_discarder): Update.
2964         (psymtab_discarder::~psymtab_discarder): Update.
2965         (ALL_OBJFILE_PSYMTABS): Rewrite.
2966         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
2967         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
2968         Remove fields.
2969         <partial_symtabs>: New field.
2970         (class objfile_psymtabs): Move from psymtab.h.  Update.
2971         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
2972         psymbol_cache.
2973         (objfile::~objfile): Don't destroy psymbol_cache.
2974         * mdebugread.c (parse_partial_symbols): Update.
2975         * dwarf2read.c (create_addrmap_from_index)
2976         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2977         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
2978         (add_partial_subprogram, dwarf2_ranges_read): Update.
2979         * dwarf-index-write.c (write_address_map)
2980         (write_one_signatured_type, recursively_write_psymbols)
2981         (class debug_names, class debug_names, write_psymtabs_to_index):
2982         Update.
2983
2984 2019-01-10  Tom Tromey  <tom@tromey.com>
2985
2986         * symtab.h (SYMBOL_SET_NAMES): Update.
2987         (symbol_set_names): Update.
2988         (MSYMBOL_SET_NAMES): Update.
2989         * symtab.c (symbol_set_names): Change argument to be an
2990         objfile_per_bfd_storage.
2991         * psymtab.c (add_psymbol_to_bcache): Update.
2992         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
2993
2994 2019-01-10  Tom Tromey  <tom@tromey.com>
2995
2996         * symtab.c (create_demangled_names_hash): Change argument to be an
2997         objfile_per_bfd_storage.
2998         (symbol_set_names): Update.
2999
3000 2019-01-10  Tom Tromey  <tom@tromey.com>
3001
3002         * xcoffread.c (xcoff_initial_scan): Unconditionally call
3003         init_psymbol_list.
3004         * psymtab.c (init_psymbol_list): Do nothing if already called.
3005         * psympriv.h (init_psymbol_list): Add comment.
3006         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
3007         init_psymbol_list.
3008         * dbxread.c (dbx_symfile_read): Unconditionally call
3009         init_psymbol_list.
3010
3011 2019-01-10  Tom Tromey  <tom@tromey.com>
3012
3013         * xcoffread.c (scan_xcoff_symtab): Update.
3014         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
3015         "where".
3016         * mdebugread.c (parse_partial_symbols)
3017         (handle_psymbol_enumerators): Update.
3018         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
3019         * dbxread.c (read_dbx_symtab): Update.
3020         * psympriv.h (psymbol_placement): New enum.
3021         (add_psymbol_to_list): Update.
3022
3023 2019-01-10  Tom Tromey  <tom@tromey.com>
3024
3025         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
3026         static_psymbols parameters.
3027         (scan_xcoff_symtab): Update.
3028         * psymtab.c (start_psymtab_common): Remove global_psymbols and
3029         static_psymbols parameters.
3030         * psympriv.h (start_psymtab_common): Update.
3031         * mdebugread.c (parse_partial_symbols): Update.
3032         * dwarf2read.c (create_partial_symtab): Update.
3033         * dbxread.c (read_dbx_symtab): Update.
3034         (start_psymtab): Remove global_psymbols and static_psymbols
3035         parameters.
3036
3037 2019-01-10  Tom Tromey  <tom@tromey.com>
3038
3039         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
3040         * psymtab.c (allocate_psymtab): Add comment.
3041         * psympriv.h (allocate_psymtab): Add comment.
3042         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
3043         initializations.
3044         * dbxread.c (dbx_end_psymtab): Remove some initializations.
3045
3046 2019-01-10  Tom Tromey  <tom@tromey.com>
3047
3048         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3049         Don't declare.
3050         * mipsread.c: Include mdebugread.h.
3051         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
3052         Declare.
3053         * elfread.c: Include mdebugread.h.
3054
3055 2019-01-09  Tom Tromey  <tom@tromey.com>
3056
3057         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
3058         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
3059         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
3060         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
3061         (psym_lookup_symbol, psym_find_last_source_symtab)
3062         (psym_forget_cached_source_info, psym_print_stats)
3063         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
3064         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
3065         (psym_map_matching_symbols, psym_expand_symtabs_matching)
3066         (psym_find_compunit_symtab_by_address)
3067         (maintenance_print_psymbols, maintenance_info_psymtabs)
3068         (maintenance_check_psymtabs): Use ranged for.
3069         * psymtab.h (class objfile_psymtabs): New.
3070         (require_partial_symbols): Return objfile_psymtabs.
3071         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
3072
3073 2019-01-09  Tom Tromey  <tom@tromey.com>
3074
3075         * symfile.c (overlay_invalidate_all, find_pc_overlay)
3076         (find_pc_mapped_section, list_overlays_command)
3077         (map_overlay_command, unmap_overlay_command)
3078         (simple_overlay_update): Use all_objfiles.
3079         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
3080         * printcmd.c (info_symbol_command): Use all_objfiles.
3081         * objfiles.h (ALL_OBJSECTIONS): Remove.
3082         * maint.c (maintenance_translate_address): Use all_objfiles.
3083         * gcore.c (gcore_create_callback): Use all_objfiles.
3084         (objfile_find_memory_regions): Likewise.
3085
3086 2019-01-09  Tom Tromey  <tom@tromey.com>
3087
3088         * symtab.c (find_line_symtab, info_sources_command)
3089         (make_source_files_completion_list): Use objfile_compunits.
3090         * source.c (select_source_symtab): Use objfile_compunits.
3091         * objfiles.h (struct objfile): Update comment.
3092         (ALL_OBJFILES): Remove.
3093         (ALL_FILETABS): Remove.
3094         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
3095         objfile_compunits.
3096
3097 2019-01-09  Tom Tromey  <tom@tromey.com>
3098
3099         * symmisc.c (print_objfile_statistics, dump_objfile)
3100         (maintenance_print_symbols): Use compunit_filetabs.
3101         * source.c (forget_cached_source_info_for_objfile): Use
3102         compunit_filetabs.
3103         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
3104         (ALL_FILETABS): Use compunit_filetabs.
3105         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
3106         * coffread.c (coff_symtab_read): Use compunit_filetabs.
3107
3108 2019-01-09  Tom Tromey  <tom@tromey.com>
3109
3110         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
3111         (compunit_filetabs): New.
3112         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
3113         compunit_filetabs.
3114         (info_sources_command, make_source_files_completion_list): Remove
3115         declaration.
3116         * symmisc.c (print_objfile_statistics, dump_objfile)
3117         (maintenance_print_symbols): Remove declaration.
3118         (maintenance_info_symtabs): Use compunit_filetabs.
3119         (maintenance_info_line_tables): Likewise.
3120         * source.c (select_source_symtab): Change local variable name.
3121         (forget_cached_source_info_for_objfile): Remove declaration.
3122         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
3123         * objfiles.c (objfile_relocate1): Remove declaration.
3124         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3125         declaration.
3126         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
3127         * coffread.c (coff_symtab_read): Remove declaration.
3128         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3129         compunit_filetabs.
3130
3131 2019-01-09  Tom Tromey  <tom@tromey.com>
3132
3133         * symtab.c (lookup_objfile_from_block)
3134         (find_pc_sect_compunit_symtab, search_symbols)
3135         (default_collect_symbol_completion_matches_break_on): Use
3136         objfile_compunits.
3137         * objfiles.h (ALL_COMPUNITS): Remove.
3138         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
3139         * cp-support.c (add_symbol_overload_list_qualified): Use
3140         objfile_compunits.
3141         * ada-lang.c (ada_collect_symbol_completion_matches)
3142         (ada_add_global_exceptions): Use objfile_compunits.
3143
3144 2019-01-09  Tom Tromey  <tom@tromey.com>
3145
3146         * source.c (select_source_symtab)
3147         (forget_cached_source_info_for_objfile): Remove declaration.
3148         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
3149         declaration.
3150         * maint.c (count_symtabs_and_blocks): Remove declaration.
3151         * cp-support.c (add_symbol_overload_list_qualified): Remove
3152         declaration.
3153         * coffread.c (coff_symtab_read): Remove declaration.
3154         * symtab.c (lookup_symbol_in_objfile_symtabs)
3155         (basic_lookup_transparent_type_1): Use objfile_compunits.
3156         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
3157         (info_sources_command, search_symbols)
3158         (default_collect_symbol_completion_matches_break_on)
3159         (make_source_files_completion_list): Remove declaration.
3160         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
3161         (ada_collect_symbol_completion_matches)
3162         (ada_add_global_exceptions): Remove declaration.
3163         * linespec.c (iterate_over_all_matching_symtabs): Use
3164         objfile_compunits.
3165         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
3166         (class objfile_compunits): New.
3167         (ALL_COMPUNITS): Use objfile_compunits.
3168         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
3169         (maintenance_check_symtabs, maintenance_info_line_tables): Use
3170         objfile_compunits.
3171         * objfiles.c (objfile_relocate1): Use objfile_compunits.
3172
3173 2019-01-09  Tom Tromey  <tom@tromey.com>
3174
3175         * symtab.c (search_symbols)
3176         (default_collect_symbol_completion_matches_break_on): Use
3177         objfile_msymbols.
3178         * ada-lang.c (ada_lookup_simple_minsym)
3179         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
3180         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
3181         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
3182         objfile_msymbols.
3183         * coffread.c (coff_symfile_read): Use objfile_msymbols.
3184         * symmisc.c (dump_msymbols): Use objfile_msymbols.
3185         * objc-lang.c (find_methods): Use objfile_msymbols.
3186         (info_selectors_command, info_classes_command): Likewise.
3187         * stabsread.c (scan_file_globals): Use objfile_msymbols.
3188         * objfiles.h (class objfile_msymbols): New.
3189         (ALL_OBJFILE_MSYMBOLS): Remove.
3190         (ALL_MSYMBOLS): Remove.
3191
3192 2019-01-09  Tom Tromey  <tom@tromey.com>
3193
3194         * common/next-iterator.h (next_adapter): Add Iterator template
3195         parameter.
3196         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
3197         (class all_objfiles_safe): New.
3198         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
3199         * objfiles.c (put_objfile_before): Update comment.
3200         (add_separate_debug_objfile): Likewise.
3201         (free_all_objfiles): Use all_objfiles_safe.
3202         (objfile_purge_solibs): Likewise.
3203
3204 2019-01-09  Tom Tromey  <tom@tromey.com>
3205
3206         * symtab.c (iterate_over_symtabs, matching_obj_sections)
3207         (expand_symtab_containing_pc, lookup_static_symbol)
3208         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
3209         (find_symbol_at_address, find_line_symtab, find_main_name): Use
3210         all_objfiles.
3211         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
3212         * breakpoint.c (create_overlay_event_breakpoint)
3213         (create_longjmp_master_breakpoint)
3214         (create_std_terminate_master_breakpoint)
3215         (create_exception_master_breakpoint): Use all_objfiles.
3216         * linux-thread-db.c (try_thread_db_load_from_pdir)
3217         (has_libpthread): Use all_objfiles.
3218         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
3219         * linespec.c (iterate_over_all_matching_symtabs)
3220         (search_minsyms_for_name): Use all_objfiles.
3221         * maint.c (maintenance_info_sections): Use all_objfiles.
3222         * main.c (captured_main_1): Use all_objfiles.
3223         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
3224         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
3225         * guile/scm-pretty-print.c
3226         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
3227         * solib-spu.c (append_ocl_sos): Use all_objfiles.
3228         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
3229         (maintenance_print_msymbols): Use all_objfiles.
3230         * source.c (select_source_symtab): Use all_objfiles.
3231         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
3232         * symfile.c (remove_symbol_file_command)
3233         (expand_symtabs_matching, map_symbol_filenames): Use
3234         all_objfiles.
3235         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
3236         all_objfiles.
3237         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
3238         * objc-lang.c (find_methods): Use all_objfiles.
3239         * objfiles.c (have_partial_symbols, have_full_symbols)
3240         (have_minimal_symbols, qsort_cmp)
3241         (default_iterate_over_objfiles_in_search_order): Use
3242         all_objfiles.
3243         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
3244         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
3245         (maintenance_check_psymtabs): Use all_objfiles.
3246         (ALL_PSYMTABS): Remove.
3247         * compile/compile-object-run.c (do_module_cleanup): Use
3248         all_objfiles.
3249         * blockframe.c (find_pc_partial_function): Use all_objfiles.
3250         * cp-support.c (add_symbol_overload_list_qualified): Use
3251         all_objfiles.
3252         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
3253         Use all_objfiles.
3254         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
3255         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
3256         all_objfiles.
3257         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
3258         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
3259         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
3260         Uses all_objfiles.
3261         * solib.c (solib_read_symbols): Use all_objfiles
3262
3263 2019-01-09  Tom Tromey  <tom@tromey.com>
3264
3265         * probe.c (parse_probes_in_pspace): Use all_objfiles.
3266         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
3267         all_objfiles.
3268         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
3269         * symmisc.c (print_symbol_bcache_statistics)
3270         (print_objfile_statistics, maintenance_print_objfiles)
3271         (maintenance_info_symtabs, maintenance_check_symtabs)
3272         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
3273         all_objfiles.
3274         * source.c (forget_cached_source_info): Use all_objfiles.
3275         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
3276         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
3277         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
3278         * objfiles.c (update_section_map): Use all_objfiles.
3279         (shared_objfile_contains_address_p): Likewise.
3280         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
3281         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
3282
3283 2019-01-09  Tom Tromey  <tom@tromey.com>
3284
3285         * common/next-iterator.h: New file.
3286         * objfiles.h (class all_objfiles): New.
3287         (struct objfile_iterator): New.
3288
3289 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3290
3291         * NEWS: Move the description of the changed "frame", "select-frame",
3292          and "info frame" commands to the Changed commands section.
3293
3294 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
3295
3296         * gdbtypes.c (check_stub_method_group): Remove handling of old
3297         mangling schemes.
3298         * linespec.c (find_methods): Likewise.
3299         * stabsread.c (read_member_functions): Likewise.
3300         * valops.c (search_struct_method): Likewise.
3301         (value_struct_elt_for_reference): Likewise.
3302         * NEWS: Mention this change.
3303
3304 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3305
3306         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
3307         print_source_lines.
3308         * source.c (print_source_lines_base): Update line number check.
3309         (print_source_lines): New function.
3310         (source_lines_range::source_lines_range): New function.
3311         * source.h (class source_lines_range): New class.
3312         (print_source_lines): New declaration.
3313
3314 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3315
3316         * linespec.c (linespec_state_destructor): Free self->canonical_names.
3317
3318 2019-01-08  Tom Tromey  <tom@tromey.com>
3319             Simon Marchi  <simon.marchi@ericsson.com>
3320
3321         PR gdb/24060
3322         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
3323         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
3324         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3325         * f-exp.y (DOLLAR_VARIABLE): Likewise.
3326         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
3327         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
3328
3329 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3330
3331         * source.c (select_source_symtab): Move header comment to
3332         declaration in source.h.
3333         (forget_cached_source_info_for_objfile): Likewise.
3334         (forget_cached_source_info): Likewise.
3335         (identify_source_line): Likewise.
3336         * source.h (identify_source_line): Move declaration from symtab.h
3337         and add comment from source.c
3338         (print_source_lines): Likewise.
3339         (forget_cached_source_info_for_objfile): Likewise.
3340         (forget_cached_source_info): Likewise.
3341         (select_source_symtab): Likewise.
3342         (enum print_source_lines_flag): Move definition from symtab.h.
3343         * symtab.h (identify_source_line): Move declaration to source.h.
3344         (print_source_lines): Likewise.
3345         (forget_cached_source_info_for_objfile): Likewise.
3346         (forget_cached_source_info): Likewise.
3347         (select_source_symtab): Likewise.
3348         (enum print_source_lines_flag): Move definition to source.h.
3349         * tui/tui-hooks.c: Add 'source.h' include.
3350
3351 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3352
3353         * source.c (print_source_lines_base): Handle requests to print
3354         reverse line number sequences, and guard against empty lines
3355         string.
3356
3357 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3358
3359         * source.c (print_source_lines_base): Fix skip of '\r' if next
3360         character is '\n'.
3361
3362 2019-01-06  Tom Tromey  <tom@tromey.com>
3363
3364         * c-exp.y (struct c_parse_state) <macro_original_text,
3365         expansion_obstack>: New member.
3366         (macro_original_text, expansion_obstack): Remove globals.
3367         (scan_macro_expansion, scanning_macro_expansion)
3368         (finished_macro_expansion): Update.
3369         (scan_macro_cleanup): Remove.
3370         (yylex, c_parse): Update.
3371
3372 2019-01-06  Tom Tromey  <tom@tromey.com>
3373
3374         * c-exp.y (struct c_parse_state) <strings>: New member.
3375         (operator_stoken): Update.
3376
3377 2019-01-06  Tom Tromey  <tom@tromey.com>
3378
3379         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
3380         (union type_stack_elt) <typelist_val>: Now a pointer to
3381         std::vector.
3382         (type_stack_cleanup): Don't declare.
3383         (push_typelist): Update.
3384         * parse.c (pop_typelist): Return a std::vector.
3385         (push_typelist): Take a std::vector.
3386         (follow_types): Update.  Do not free args.
3387         (type_stack_cleanup): Remove.
3388         * c-exp.y (struct c_parse_state): New.
3389         (cpstate): New global.
3390         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
3391         (nonempty_typelist): Update.
3392         (func_mod): Create a new vector.
3393         (c_parse): Create a c_parse_state.
3394         (check_parameter_typelist): Do not delete params.
3395         (function_method): Update.  Do not delete type_list.
3396
3397 2019-01-06  Tom Tromey  <tom@tromey.com>
3398
3399         PR gdb/28155:
3400         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
3401         check_typedef.
3402         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
3403         (print_return_value): Likewise.
3404
3405 2019-01-05  Tom Tromey  <tom@tromey.com>
3406
3407         * contrib/cleanup_check.py: Remove.
3408         * contrib/gcc-with-excheck: Remove.
3409         * contrib/exsummary.py: Remove.
3410         * contrib/excheck.py: Remove.
3411
3412 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
3413
3414         * thread.c (delete_thread_1): Add gdb_assert that THR is not
3415         NULL. Initialize tpprev to NULL instead of assigning it
3416         to NULL on the next statement.
3417         * windows-nat.c (windows_delete_thread): Remove check for
3418         main_thread_id before printing thread exit notifications.
3419         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
3420         Remove thread ID check against main_thread_id.
3421         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
3422         windows_delete_thread.
3423         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
3424
3425 2019-01-04  Tom Tromey  <tom@tromey.com>
3426
3427         * compile/compile.c (_initialize_compile): Use upper case for
3428         metasyntactic variables.
3429         * symmisc.c (_initialize_symmisc): Use upper case for
3430         metasyntactic variables.
3431         * psymtab.c (_initialize_psymtab): Use upper case for
3432         metasyntactic variables.
3433         * demangle.c (demangle_command): Use upper case for metasyntactic
3434         variables.
3435         (_initialize_demangler): Likewise.
3436         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
3437         variables.
3438
3439 2019-01-03  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
3442
3443 2019-01-03  Tom Tromey  <tom@tromey.com>
3444
3445         * python/py-symtab.c (salpy_str): Update.
3446         (struct salpy_sal_object) <symtab>: Now a PyObject.
3447         (salpy_dealloc): Update.
3448         (del_objfile_sal): Use gdbpy_ref.
3449
3450 2019-01-03  Tom Tromey  <tom@tromey.com>
3451
3452         * python/py-type.c (convert_field): Use new_reference.  Return
3453         gdbpy_ref.
3454         (make_fielditem): Return gdbpy_ref.
3455         (typy_fields): Update.
3456         (typy_getitem): Update.
3457         (field_name): Return gdbpy_ref.  Use new_reference.
3458         (typy_iterator_iternext): Update.
3459
3460 2019-01-03  Tom Tromey  <tom@tromey.com>
3461
3462         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
3463
3464 2019-01-03  Tom Tromey  <tom@tromey.com>
3465
3466         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
3467         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
3468         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
3469         (pspy_set_frame_filters, pspy_set_frame_unwinders)
3470         (pspy_set_type_printers): Likewise.
3471         * python/py-function.c (fnpy_init): Use gdbpy_ref.
3472         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
3473         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
3474         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
3475         (objfpy_set_type_printers): Likewise.
3476
3477 2019-01-03  Tom Tromey  <tom@tromey.com>
3478
3479         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
3480         (gdbpy_print_stack): Use gdbpy_err_fetch.
3481         * python/python-internal.h (class gdbpy_err_fetch): New class.
3482         (class gdbpy_enter) <m_error_type, m_error_value,
3483         m_error_traceback>: Remove.
3484         <m_error>: New member.
3485         (gdbpy_exception_to_string): Don't declare.
3486         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
3487         * python/py-value.c (convert_value_from_python): Use
3488         gdbpy_err_fetch.
3489         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
3490         gdbpy_exception_to_string.
3491         (gdbpy_handle_exception): Use gdbpy_err_fetch.
3492         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3493         gdbpy_err_fetch.
3494
3495 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3496
3497         * linux-nat.c (delete_lwp_cleanup): Delete.
3498         (struct lwp_deleter): New struct.
3499         (lwp_info_up): New typedef.
3500         (linux_nat_target::follow_fork): Delete cleanup, and make use of
3501         lwp_info_up.
3502
3503 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3504
3505         * linux-fork.c (class scoped_switch_fork_info): New class.
3506         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
3507
3508 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3509
3510         * valops.c (find_overload_match): Remove use of null_cleanup, and
3511         calls to do_cleanups.
3512
3513 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3514
3515         * compile/compile-cplus-types.c
3516         (compile_cplus_instance::decl_name): Handle changes to
3517         cp_func_name.
3518         * cp-support.c (cp_func_name): Update header comment, update
3519         return type.
3520         * cp-support.h (cp_func_name): Update return type in declaration.
3521         * valops.c (find_overload_match): Move temp_func local to top
3522         level of function and change its type.  Use temp_func to hold and
3523         delete temporary string obtained from cp_func_name.
3524
3525 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3526
3527         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
3528         gdb::char_vector, remove cleanup, and update uses of `msg`.
3529
3530 2019-01-03  Jim Wilson  <jimw@sifive.com>
3531
3532         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
3533
3534 2019-01-02  Tom Tromey  <tom@tromey.com>
3535
3536         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
3537         (tdesc_parse_xml): Remove cleanups.
3538         * target-descriptions.h (make_cleanup_free_target_description):
3539         Don't declare.
3540         (target_desc_deleter): New struct.
3541         (target_desc_up): New typedef.
3542         * target-descriptions.c (target_desc_deleter::operator()): Rename
3543         from free_target_description.
3544         (make_cleanup_free_target_description): Remove.
3545
3546 2019-01-02  Tom Tromey  <tom@tromey.com>
3547
3548         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
3549         constructor, destructor.
3550         (linespec_parser): Remove typedef.
3551         (~linespec_parser): Rename from linespec_parser_delete.
3552         (linespec_lex_to_end, linespec_complete_label)
3553         (linespec_complete): Update.
3554         (decode_line_full): Remove cleanups.
3555         (decode_line_1): Update.
3556
3557 2019-01-02  Tom Tromey  <tom@tromey.com>
3558
3559         * python/python-internal.h (inferior_to_inferior_object): Change
3560         return type.
3561         * python/py-exitedevent.c (create_exited_event_object): Update.
3562         * python/py-inferior.c (inferior_to_inferior_object): Return
3563         gdbpy_ref.
3564         (python_new_inferior, python_inferior_deleted)
3565         (thread_to_thread_object, delete_thread_object)
3566         (build_inferior_list, gdbpy_selected_inferior): Update.
3567         * python/py-infthread.c (create_thread_object): Update.  Also fail
3568         if inferior_to_inferior_object fails.
3569
3570 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
3571
3572         * inferior.h (class inferior) <displaced_step_state>: New field.
3573         * infrun.h (struct displaced_step_state): Move here from
3574         infrun.c.  Initialize fields, add constructor.
3575         <inf>: Remove field.
3576         <reset>: New method.
3577         * infrun.c (struct displaced_step_inferior_state): Move to
3578         infrun.h.
3579         (displaced_step_inferior_states): Remove.
3580         (get_displaced_stepping_state): Adust.
3581         (displaced_step_in_progress_any_inferior): Adjust.
3582         (displaced_step_in_progress_thread): Adjust.
3583         (displaced_step_in_progress): Adjust.
3584         (add_displaced_stepping_state): Remove.
3585         (get_displaced_step_closure_by_addr): Adjust.
3586         (remove_displaced_stepping_state): Remove.
3587         (infrun_inferior_exit): Call displaced_step_state.reset.
3588         (use_displaced_stepping): Don't check for NULL.
3589         (displaced_step_prepare_throw): Call
3590         get_displaced_stepping_state.
3591         (displaced_step_fixup): Don't check for NULL.
3592         (prepare_for_detach): Don't check for NULL.
3593
3594 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3595
3596         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
3597          in case of call that did not complete.
3598
3599 2019-01-02  Andrey Utkin  <autkin@undo.io>
3600
3601         * symfile.c (find_separate_debug_file): Fix search of debug files for
3602         remote debuggee.
3603
3604 2019-01-02  Tom Tromey  <tom@tromey.com>
3605
3606         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
3607         indentation.
3608         * python/py-frame.c (frapy_older): Remove cast.
3609         (frapy_newer): Likewise.
3610         * python/py-breakpoint.c (local_setattro): Remove cast.
3611         * python/py-arch.c (archpy_name): Remove local variable.
3612         * python/py-type.c (gdbpy_lookup_type): Remove cast.
3613
3614 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
3615
3616         * unittests/basic_string_view/element_access/char/empty.cc:
3617         Fix year range in copyright header.
3618
3619 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3620
3621         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
3622         Delete.
3623         <operator==>: Update with for removed field.
3624         <hash>: Likewise.
3625         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
3626         <isa_features>: ...this.
3627         <abi_features>: New field.
3628         (riscv_isa_flen): Update comment.
3629         (riscv_abi_xlen): New declaration.
3630         (riscv_abi_flen): New declaration.
3631         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
3632         isa_features.
3633         (riscv_abi_xlen): New function.
3634         (riscv_isa_flen): Update to get answer from isa_features.
3635         (riscv_abi_flen): New function.
3636         (riscv_has_fp_abi): Update to get answer from abi_features.
3637         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
3638         xlen and flen.
3639         (riscv_call_info) <xlen, flen>: Update comment.
3640         (riscv_call_arg_struct): Remove invalid assertions
3641         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
3642         is removed.
3643         (riscv_gdbarch_init): Gather isa features and abi features
3644         separately, ensure both match on the gdbarch when reusing an old
3645         gdbarch.  Relax an error check to allow 32-bit abi float to run on
3646         a target with 64-bit float hardware.
3647
3648 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3649
3650         * source.c (search_command_helper): Stop reverse search
3651         when line 1 has been searched.
3652
3653 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3654
3655         * record-full.c (record_full_base_target::close): Rewrite
3656         record_full_core_buf_list free logic.
3657
3658 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3659
3660         * break-catch-syscall.c (print_one_catch_syscall): xfree
3661         the last text.
3662
3663 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3664
3665         * top.c (print_gdb_version): Update Copyright year in version
3666         message.
3667
3668 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
3669
3670         Update copyright year range in all GDB files.
3671
3672 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
3673
3674         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
3675
3676 For older changes see ChangeLog-2018.
3677 \f
3678 Local Variables:
3679 mode: change-log
3680 left-margin: 8
3681 fill-column: 74
3682 version-control: never
3683 coding: utf-8
3684 End:
3685