gdb/ChangeLog

   1 2019-10-02  Tom Tromey  <tromey@adacore.com>
   2
   3         * source.c (select_source_symtab): Don't call
   4         decode_line_with_current_source.
   5
   6 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         * symtab.c (lookup_global_symbol): Search global block.
   9
  10 2019-10-02  Tom Tromey  <tromey@adacore.com>
  11
  12         * coffread.c (process_coff_symbol): Update.
  13         * dwarf2read.c (var_decode_location, new_symbol): Update.
  14         * mdebugread.c (parse_symbol): Update.
  15         * objfiles.c (relocate_one_symbol): Update.
  16         * stabsread.c (define_symbol, fix_common_block)
  17         (scan_file_globals): Update.
  18         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
  19         (SET_SYMBOL_VALUE_ADDRESS): New macro.
  20         * xcoffread.c (process_xcoff_symbol): Update.
  21
  22 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
  23
  24         * MAINTAINERS: Update my email address.
  25
  26 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  27
  28         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
  29         std::vector.
  30         (build_type_psymtabs_reader): Update for std::vector.
  31         (build_type_psymtab_dependencies): Likewise.
  32         * dwarf2read.h: Remove use of DEF_VEC_P.
  33         (typedef sig_type_ptr): Delete.
  34
  35 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * btrace.c (btrace_maint_clear): Update to handle change from VEC
  38         to std::vector.
  39         (btrace_maint_decode_pt): Likewise, and move allocation of the
  40         vector outside of the loop.
  41         (btrace_maint_update_packets): Update to handle change from VEC to
  42         std::vector.
  43         (btrace_maint_print_packets): Likewise.
  44         (maint_info_btrace_cmd): Likewise.
  45         * btrace.h: Remove use of DEF_VEC_O.
  46         (typedef btrace_pt_packet_s): Delete.
  47         (struct btrace_maint_info) <packets>: Change fromm VEC to
  48         std::vector.
  49         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
  50
  51 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  52
  53         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
  54         make accesses into the vector constant references.
  55         (btrace_add_pc): Update for std::vector.
  56         (btrace_stitch_bts): Likewise.
  57         (parse_xml_btrace_block): Likewise.
  58         (btrace_maint_update_packets): Likewise.
  59         (btrace_maint_print_packets): Likewise.
  60         (maint_info_btrace_cmd): Likewise.
  61         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
  62         std::vector.
  63         (btrace_data::empty): Likewise.
  64         (btrace_data_append): Likewise.
  65         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
  66         (typedef btrace_block_s): Delete.
  67         (struct btrace_block): Add constructor.
  68         (struct btrace_data_bts) <blocks>: Change to std::vector.
  69         * nat/linux-btrace.c (perf_event_read_bts): Update for
  70         std::vector.
  71         (linux_read_bts): Likewise.
  72
  73 2019-10-01  Tom Tromey  <tom@tromey.com>
  74
  75         * cli/cli-logging.c (show_logging_filename): Use styled_string.
  76
  77 2019-10-01  Tom Tromey  <tom@tromey.com>
  78
  79         * stack.c (print_frame, info_frame_command_core): Use
  80         styled_string.
  81         * linux-thread-db.c (try_thread_db_load_1)
  82         (try_thread_db_load_from_pdir_1): Use styled_string.
  83         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
  84         (auto_load_section_scripts, info_auto_load_local_gdbinit)
  85         (maybe_print_unsupported_script_warning)
  86         (maybe_print_script_not_found_warning): Use styled_string.
  87         * ada-lang.c (user_select_syms): Use styled_string.
  88
  89 2019-10-01  Tom Tromey  <tom@tromey.com>
  90
  91         * p-lang.c (pascal_printstr): Use metadata style.
  92         * value.c (show_convenience): Use metadata style.
  93         * valprint.c (valprint_check_validity, val_print_optimized_out)
  94         (val_print_not_saved, val_print_unavailable)
  95         (val_print_invalid_address, generic_val_print, val_print)
  96         (value_check_printable, val_print_array_elements): Use metadata
  97         style.
  98         * ui-out.h (class ui_out) <field_fmt>: New overload.
  99         <do_field_fmt>: Add style parameter.
 100         * ui-out.c (ui_out::field_fmt): New overload.
 101         * typeprint.c (type_print_unknown_return_type)
 102         (val_print_not_allocated, val_print_not_associated): Use metadata
 103         style.
 104         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 105         parameter.
 106         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 107         * tracepoint.c (tvariables_info_1): Use metadata style.
 108         * stack.c (print_frame_arg, print_frame_info, print_frame)
 109         (info_frame_command_core): Use metadata style.
 110         * skip.c (info_skip_command): Use metadata style.
 111         * rust-lang.c (rust_print_enum): Use metadata style.
 112         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 113         metadata style.
 114         * python/py-framefilter.c (py_print_single_arg): Use metadata
 115         style.
 116         * printcmd.c (do_one_display, print_variable_and_value): Use
 117         metadata style.
 118         * p-valprint.c (pascal_val_print)
 119         (pascal_object_print_value_fields): Use metadata style.
 120         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 121         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 122         parameter.
 123         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 124         * m2-valprint.c (m2_print_long_set): Use metadata style.
 125         * m2-typeprint.c (m2_print_type): Use metadata style.
 126         * infcmd.c (print_return_value_1): Use metadata style.
 127         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 128         * f-valprint.c (info_common_command_for_block): Use metadata
 129         style.
 130         * f-typeprint.c (f_type_print_base): Use metadata style.
 131         * expprint.c (print_subexp_standard): Use metadata style.
 132         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 133         * cli/cli-style.h (class cli_style_option): Add constructor.
 134         (metadata_style): Declare.
 135         * cli/cli-style.c (metadata_style): New global.
 136         (_initialize_cli_style): Register metadata style.
 137         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 138         parameter.
 139         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 140         * c-typeprint.c (c_type_print_base_struct_union)
 141         (c_type_print_base_1): Use metadata style.
 142         * breakpoint.c (watchpoint_value_print)
 143         (print_one_breakpoint_location): Use metadata style.
 144         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 145         style.
 146         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 147         style.
 148         * ada-valprint.c (val_print_packed_array_elements, printstr)
 149         (print_field_values, ada_val_print_ref, ada_val_print): Use
 150         metadata style.
 151         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 152         style.
 153         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 154         style.
 155         * ada-lang.c (user_select_syms): Use metadata style.
 156
 157 2019-10-01  Tom Tromey  <tom@tromey.com>
 158
 159         * cli/cli-cmds.c (pwd_command): Style output.
 160
 161 2019-10-01  Pedro Alves  <palves@redhat.com>
 162             Tom Tromey  <tom@tromey.com>
 163
 164         * symtab.c (print_symbol_info): Use %ps.
 165         (print_msymbol_info): Use %ps.
 166         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 167         * printcmd.c (print_variable_and_value): Use %ps.
 168         * macrocmd.c (show_pp_source_pos): Use %ps.
 169         * infrun.c (print_exited_reason): Use ui_out::message.
 170         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 171         (describe_other_breakpoints): Use ui_out::message and new
 172         formats.
 173         (say_where): Use new formats.
 174         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 175         and new formats.
 176
 177 2019-10-01  Pedro Alves  <palves@redhat.com>
 178             Tom Tromey  <tom@tromey.com>
 179
 180         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 181         (test_gdb_formats): New function.
 182         (run_tests): Call it.
 183         (test_format_specifier): Update.
 184         * utils.h (fputs_filtered): Update comment.
 185         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 186         (fputs_styled_unfiltered): Declare.
 187         * utils.c (fputs_styled_unfiltered): New function.
 188         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 189         (vfprintf_filtered): Update.
 190         (vfprintf_unfiltered, vprintf_filtered): Update.
 191         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 192         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 193         disallow_ui_out_field>: New constants.
 194         (enum class field_kind): New.
 195         (struct base_field_s, struct signed_field_s): New.
 196         (signed_field): New function.
 197         (struct string_field_s): New.
 198         (string_field): New function.
 199         (struct styled_string_s): New.
 200         (styled_string): New function.
 201         (class ui_out) <message>: Add comment.
 202         <vmessage, call_do_message>: New methods.
 203         <do_message>: Add style parameter.
 204         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 205         methods.
 206         (ui_out::message): Rewrite.
 207         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 208         parameter.
 209         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 210         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 211         gdb_extensions parameter.
 212         (class format_piece): Add parameter to constructor.
 213         (n_int_args): New field.
 214         * gdbsupport/format.c (format_pieces::format_pieces): Add
 215         gdb_extensions parameter.  Handle '*'.
 216         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 217         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 218         vfprintf_styled_no_gdbfmt.
 219         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 220         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 221         unfiltered output.
 222         * ui-style.h (struct ui_file_style) <ptr>: New method.
 223
 224 2019-10-01  Tom Tromey  <tom@tromey.com>
 225
 226         * unittests/format_pieces-selftests.c: Update.  Add final format.
 227         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 228         empty literal pieces.
 229
 230 2019-10-01  Tom Tromey  <tom@tromey.com>
 231
 232         * ui-out.h (enum class ui_out_style_kind): Remove.
 233         (class ui_out) <field_string, field_stsream, do_field_string>:
 234         Change type of "style".
 235         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 236         (ui_out::field_string): Update.
 237         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 238         of "style".
 239         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 240         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 241         * stack.c (print_frame_arg, print_frame_info, print_frame):
 242         Update.
 243         * source.c (print_source_lines_base): Update.
 244         * solib.c (info_sharedlibrary_command): Update.
 245         * skip.c (info_skip_command): Update.
 246         * record-btrace.c (btrace_call_history_src_line)
 247         (btrace_call_history): Update.
 248         * python/py-framefilter.c (py_print_frame): Update.
 249         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 250         "style".
 251         * mi/mi-out.c (mi_ui_out::do_table_header)
 252         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 253         (mi_ui_out::do_field_string): Update.
 254         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 255         Update.
 256         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 257         "style".
 258         * cli-out.c (cli_ui_out::do_table_header)
 259         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 260         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 261         (cli_ui_out::do_field_fmt): Update.
 262         * breakpoint.c (print_breakpoint_location): Update.
 263         (update_static_tracepoint): Update.
 264
 265 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 266
 267         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 268         conversion of gdb_datadir.
 269         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 270         remove not needed c_str ().
 271
 272 2019-09-30  Ali Tamur <tamur@google.com>
 273
 274         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 275         (dwarf2_string_attr): Likewise.
 276
 277 2019-09-30  Ali Tamur <tamur@google.com>
 278
 279         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 280         (process_full_type_unit): Likewise.
 281         (dump_die_shallow): Likewise.
 282         (cu_debug_loc_section): Likewise.
 283
 284 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 285
 286         * minsyms.c (compare_minimal_symbols): Rename to...
 287         (minimal_symbol_is_less_than): ...this, and adjust to STL
 288         conventions (return bool, take arguments as references)
 289         (minimal_symbol_reader::install): Call std::sort instead
 290         of qsort.
 291
 292 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 293
 294         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 295         hash and why.
 296         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 297         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 298
 299 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 300
 301         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 302         * psympriv.h (add_psymbol_to_list): Move comment here and update
 303         it.
 304
 305 2019-09-29  Tom de Vries  <tdevries@suse.de>
 306
 307         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 308         Use $tmpdir/$(basename "$output_file").dwz instead of
 309         "${output_file}.dwz".
 310
 311 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 312
 313         PR gdb/25045
 314         * hppa-linux-nat.c: Include gdbarch.h.
 315
 316 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 317
 318         * blockframe.c (find_pc_partial_function): Change return type to bool.
 319         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 320         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 321         (stub_gnu_ifunc_resolve_name): Likewise.
 322         * symtab.c (compare_filenames_for_search): Likewise.
 323         (compare_glob_filenames_for_search): Likewise.
 324         (matching_obj_sections): Likewise.
 325         (symbol_matches_domain): Likewise.
 326         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 327         (find_line_pc): Change return type to bool.
 328         (find_line_pc_range): Likewise.
 329         (producer_is_realview): Likewise.
 330         * symtab.h (symbol_matches_domain): Likewise.
 331         (find_pc_partial_function): Likewise.
 332         (find_pc_line_pc_range): Likewise.
 333         (in_gnu_ifunc_stub): Likewise.
 334         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 335         (find_line_pc): Likewise.
 336         (find_line_pc_range): Likewise.
 337         (matching_obj_sections): Likewise.
 338         (find_line_symtab): Change out parameter to bool.
 339         (producer_is_realview): Change return type to bool.
 340         (compare_filenames_for_search): Likewise.
 341         (compare_glob_filenames_for_search): Likewise.
 342
 343 2019-09-26  Tom Tromey  <tom@tromey.com>
 344
 345         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 346         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 347         * gdb_usleep.h: Remove.
 348         * gdb_usleep.c: Remove.
 349         * utils.c: Don't include gdb_usleep.h.
 350
 351 2019-09-26  Tom Tromey  <tromey@adacore.com>
 352
 353         * python/py-type.c (type_to_type_object): Call check_typedef
 354         for stub types.
 355
 356 2019-09-26  Tom Tromey  <tom@tromey.com>
 357
 358         * utils.h (initialize_utils): Don't declare.
 359         * top.c (gdb_init): Don't call initialize_utils.
 360         * utils.c (initialize_utils): Remove.  Move contents...
 361         (_initialize_utils): ... here.
 362
 363 2019-09-25  Tom Tromey  <tom@tromey.com>
 364
 365         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 366         * utils.h (make_hex_string): Don't declare.
 367         * utils.c (make_hex_string): Remove.
 368
 369 2019-09-24  Tom de Vries  <tdevries@suse.de>
 370
 371         PR gdb/23815
 372         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 373         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 374
 375 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 376
 377         * NEWS: Mention new simulator port for PRU.
 378
 379 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 380
 381         * ada-exp.y (write_object_remaining): Update.
 382         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 383         and eliminate the static buffer.
 384         (ada_decode_symbol): Update.
 385         (ada_la_decode): Update.
 386         (ada_sniff_from_mangled_name): Update.
 387         (is_valid_name_for_wild_match): Update.
 388         (ada_lookup_name_info::matches): Update and simplify.
 389         (name_matches_regex): Update.
 390         (ada_add_global_exceptions): Update.
 391         * ada-lang.h (ada_decode): Update signature.
 392         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 393         * dwarf-index-write.c (debug_names::insert): Update.
 394
 395 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 396
 397         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 398         formatting.
 399
 400 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 401
 402         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 403         Change "nonzero" to "true" in documentation.
 404
 405 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 406
 407         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 408         (_initialize_darwin_solib): Don't set
 409         darwin_so_ops.lookup_lib_global_symbol.
 410         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 411         set_gdbarch_iterate_over_objfiles_in_search_order.
 412         (elf_lookup_lib_symbol): Rename to...
 413         (svr4_iterate_over_objfiles_in_search_order): this, and update
 414         to iterate semantics.
 415         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 416         * solib.c (solib_global_lookup): Remove.
 417         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 418         (solib_global_lookup): Remove.
 419         * symtab.c (lookup_global_or_static_symbol): Remove call to
 420         solib_global_lookup.
 421
 422 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 423
 424         * NEWS: Move entries about default MI version now being
 425         version 3, and about the GDB/MI fix for multi-location
 426         breakpoints to the "since GDB 8.3" section.
 427
 428 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 429
 430         GDB 8.3.1 released.
 431
 432 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 433
 434         * NEWS: Mention that Cell/B.E. debugging support was removed.
 435         * MAINTAINERS: Remove spu target.
 436
 437         * config/djgpp/fnchange.lst: Remove entries for removed files.
 438
 439         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 440         spu-multiarch.o, and spu-tdep.o.
 441         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 442         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 443         spu-multiarch.c, and spu-tdep.c.
 444         * spu-linux-nat.c: Remove file.
 445         * spu-multiarch.c: Remove file.
 446         * spu-tdep.c: Remove file.
 447         * spu-tdep.h: Remove file.
 448         * solib-spu.c: Remove file.
 449         * solib-spu.h: Remove file.
 450
 451         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 452         * configure.nat (spu-linux): Remove.
 453         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 454         solib-multiarch.o from gdb_target_obs.
 455         (spu*-*-*): Remove.
 456
 457         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 458         feature flag.
 459         (ppc_linux_no_features): Update.
 460         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 461         Cell/B.E. support.
 462         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 463         (tdesc_powerpc_cell64l): Likewise.
 464         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 465         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 466         Cell/B.E. support.
 467         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 468         Do not include "features/rs6000/powerpc-cell32l.c" or
 469         "features/rs6000/powerpc-cell64l.c".
 470         (ppc_linux_spu_section): Remove.
 471         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 472         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 473         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 474         (ppc_linux_spe_context_lookup): Remove.
 475         (ppc_linux_spe_context_inferior_created): Remove.
 476         (ppc_linux_spe_context_solib_loaded): Remove.
 477         (ppc_linux_spe_context_solib_unloaded): Remove.
 478         (ppc_linux_spe_context): Remove.
 479         (struct ppu2spu_cache): Remove.
 480         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 481         (struct ppu2spu_data): Remove.
 482         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 483         ppu2spu_unwind): Remove.
 484         (ppc_linux_init_abi): Remove Cell/B.E. support.
 485         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 486
 487         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 488         (rs6000/powerpc-cell64l-expedite): Likewise
 489         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 490         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 491         rs6000/powerpc-cell64l.xml.
 492         * features/rs6000/powerpc-cell32l.xml: Remove.
 493         * features/rs6000/powerpc-cell64l.xml: Likewise.
 494         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 495         * features/rs6000/powerpc-cell64l.c: Likewise.
 496         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 497         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 498         * regformats/reg-spu.dat: Remove.
 499
 500         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 501         * corelow.c (struct spuid_list): Remove.
 502         (add_to_spuid_list): Remove.
 503         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 504         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 505         (remote_protocol_features): Remove associated entries.
 506         (_initialize_remote): No longer initialize them.
 507         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 508         * linux-nat.c (SPUFS_MAGIC): Remove.
 509         (linux_proc_xfer_spu): Remove.
 510         (spu_enumerate_spu_ids): Remove.
 511         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 512         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 513         (linux_make_corefile_notes): No longer call it.
 514
 515         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 516         (cooked_write_test): Likewise.
 517
 518 2019-09-20  Tom Tromey  <tom@tromey.com>
 519
 520         * NEWS: Mention case-sensitivity of TUI commands.
 521         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 522         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 523         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 524
 525 2019-09-20  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-source.c (tui_source_window::set_contents): Use
 528         make_unique_xstrdup.
 529         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 530         make_unique_xstrdup.
 531
 532 2019-09-20  Tom Tromey  <tom@tromey.com>
 533
 534         * tui/tui-data.c: Remove separator comments.
 535         * tui/tui-layout.c: Remove separator comments.
 536         * tui/tui-win.c: Remove separator comments.
 537         * tui/tui-wingeneral.c: Remove separator comments.
 538
 539 2019-09-20  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui.h (strcat_to_buf): Don't declare.
 542         * tui/tui.c (strcat_to_buf): Remove.
 543
 544 2019-09-20  Tom Tromey  <tom@tromey.com>
 545
 546         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 547         from "fullname".
 548         * tui/tui-source.c (tui_source_window::set_contents)
 549         (tui_source_window::location_matches_p)
 550         (tui_source_window::maybe_update): Update.
 551
 552 2019-09-20  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 555         Update.
 556         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 557         prefix.
 558         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 559         (tui_data_window::line_from_reg_element_no)
 560         (tui_data_window::first_reg_element_no_inline)
 561         (tui_data_window::show_registers)
 562         (tui_data_window::show_register_group)
 563         (tui_data_window::display_registers_from)
 564         (tui_data_window::display_registers_from_line)
 565         (tui_data_window::first_data_item_displayed)
 566         (tui_data_window::delete_data_content_windows)
 567         (tui_data_window::erase_data_content)
 568         (tui_data_window::do_scroll_vertical)
 569         (tui_data_window::refresh_window)
 570         (tui_data_window::check_register_values): Update.
 571
 572 2019-09-20  Tom Tromey  <tom@tromey.com>
 573
 574         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 575         (struct tui_locator_window) <full_name, proc_name>: Now
 576         std::string.
 577         * tui/tui-stack.c (tui_locator_window::make_status_line)
 578         (tui_locator_window::set_locator_fullname)
 579         (tui_locator_window::set_locator_info): Update.
 580         * tui/tui-source.c (tui_source_window::set_contents)
 581         (tui_source_window::showing_source_p): Update.
 582
 583 2019-09-20  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 586         Don't call tui_locator_win_info_ptr.
 587
 588 2019-09-20  Tom Tromey  <tom@tromey.com>
 589
 590         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 591
 592 2019-09-20  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 595         height for locator.
 596         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 597         * tui/tui-layout.c (show_source_disasm_command, show_data)
 598         (show_source_or_disasm_and_command): Use 1 as height for locator.
 599
 600 2019-09-20  Tom Tromey  <tom@tromey.com>
 601
 602         * tui/tui.c (tui_enable): Update.
 603         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 604         Update.
 605         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 606         Update.
 607         * tui/tui-data.c (win_resized): Now bool.
 608         (tui_win_resized): Return bool.
 609         (tui_set_win_resized_to): Accept a bool.
 610
 611 2019-09-20  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 614         Change type of "refresh_values_only".
 615         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 616         type of "refresh_values_only".
 617
 618 2019-09-20  Tom Tromey  <tom@tromey.com>
 619
 620         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 621         std::string.
 622         (tui_disassemble): Add "pos" parameter.
 623         (tui_disasm_window::set_contents): Simplify.
 624
 625 2019-09-20  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-winsource.h (struct tui_source_window_base)
 628         <show_source_content>: Now private.
 629         * tui/tui-winsource.c
 630         (tui_source_window_base::show_source_content): Don't handle empty
 631         content case.
 632
 633 2019-09-20  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-layout.c (show_source_disasm_command)
 636         (show_source_or_disasm_and_command): Don't call
 637         show_source_content.
 638
 639 2019-09-20  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 642         Declare.
 643         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 644         from tui_make_status_line.
 645         (tui_locator_window::rerender): Update.
 646
 647 2019-09-20  Tom Tromey  <tom@tromey.com>
 648
 649         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 650         (tui_locator_window::rerender): Update.
 651
 652 2019-09-20  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-winsource.h (struct tui_source_window_base)
 655         <~tui_source_window_base>: Don't declare.
 656         <fullname>: Remove.
 657         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 658         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 659         member.
 660         * tui/tui-source.c (tui_source_window::set_contents): Update.
 661         (tui_source_window::location_matches_p)
 662         (tui_source_window::maybe_update): Update.
 663
 664 2019-09-20  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-winsource.h (~tui_source_element): Remove.
 667         (tui_source_element): Update.
 668         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 669         * tui/tui-winsource.c (tui_show_source_line): Update.
 670         * tui/tui-source.c (tui_source_window::set_contents): Update.
 671         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 672
 673 2019-09-20  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 676         declare.
 677         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 678         tui_clear_source_windows_detail.
 679         * tui/tui-winsource.h (struct tui_source_window_base)
 680         <clear_detail>: Don't declare.
 681         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 682         Remove.
 683         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 684
 685 2019-09-20  Tom Tromey  <tromey@adacore.com>
 686
 687         PR ada/24919:
 688         * block.c (contained_in): Fix final return value.
 689
 690 2019-09-20  Alan Modra  <amodra@gmail.com>
 691
 692         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 693         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 694         (read_indirect_string_from_dwz): Use bfd accessor.
 695         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 696         * machoread.c (macho_symfile_read_all_oso): Likewise.
 697         * solib.c (solib_bfd_open): Likewise.
 698
 699 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 700
 701         * eval.c: Move declaration of overload_resolution to...
 702         * value.h: ...here.
 703
 704 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 705
 706         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 707         * arm-linux-tdep.c: Likewise.
 708         * arm-nbsd-nat.c: Likewise.
 709         * arm-tdep.h: Declare arm_apcs_32.
 710         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 711
 712 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 713
 714         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 715         * dwarf2read.h: Declare dwarf_always_disassemble.
 716
 717 2019-09-19  Tom de Vries  <tdevries@suse.de>
 718
 719         PR gdb/25009
 720         * source-cache.c (source_cache::ensure): Catch exception thrown during
 721         construction of the highlighter.
 722
 723 2019-09-18  Alan Modra  <amodra@gmail.com>
 724
 725         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 726         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 727         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 728         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 729         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 730         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 731         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 732         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 733         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 734         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 735         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 736         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 737         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 738         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 739         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 740         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 741         * mi/mi-interp.c: Update throughout for bfd section macro and
 742         function changes.
 743         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 744         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 745
 746 2019-09-18  Tom Tromey  <tom@tromey.com>
 747
 748         * NEWS: Add entry.
 749         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 750         call rl_initialize.
 751         (tui_enable): Do not call rl_initialize.
 752
 753 2019-09-18  Christian Groessler  <chris@groessler.org>
 754
 755         * alpha-linux-nat.c: Include gdbarch.h.
 756
 757 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 758
 759         * ui-file.c: Include cli/cli-style.h.
 760         (term_cli_styling): Remove cli_styling declaration.
 761
 762 2019-09-18  Alan Modra  <amodra@gmail.com>
 763
 764         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 765         to bfd_asymbol_section.
 766
 767 2019-09-18  Alan Modra  <amodra@gmail.com>
 768
 769         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 770         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 771         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 772
 773 2019-09-18  Alan Modra  <amodra@gmail.com>
 774
 775         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 776         * spu-linux-nat.c (spu_bfd_open): Likewise.
 777
 778 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 779
 780         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 781         to bool to match definition in dwarf2read.c.
 782
 783 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 784
 785         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 786         (print_signatures): Likewise.
 787         (trust_pad_over_xvs): Likewise.
 788         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 789         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 790         * arm-linux-nat.c (arm_apcs_32): Likewise.
 791         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 792         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 793         * arm-tdep.c (arm_debug): Likewise.
 794         (arm_apcs_32): Likewise.
 795         * auto-load.c (debug_auto_load): Likewise.
 796         (auto_load_gdb_scripts): Likewise.
 797         (global_auto_load): Likewise.
 798         (auto_load_local_gdbinit): Likewise.
 799         (auto_load_local_gdbinit_loaded): Likewise.
 800         * auto-load.h (global_auto_load): Likewise.
 801         (auto_load_local_gdbinit): Likewise.
 802         (auto_load_local_gdbinit_loaded): Likewise.
 803         * breakpoint.c (disconnected_dprintf): Likewise.
 804         (breakpoint_proceeded): Likewise.
 805         (automatic_hardware_breakpoints): Likewise.
 806         (always_inserted_mode): Likewise.
 807         (target_exact_watchpoints): Likewise.
 808         (_initialize_breakpoint): Update.
 809         * breakpoint.h (target_exact_watchpoints): Change to bool.
 810         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 811         * cli/cli-cmds.c (trace_commands): Likewise.
 812         * cli/cli-cmds.h (trace_commands): Likewise.
 813         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 814         to bool*.
 815         * cli/cli-logging.c (logging_overwrite): Change to bool.
 816         (logging_redirect): Likewise.
 817         (debug_redirect): Likewise.
 818         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 819         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 820         to bool.
 821         <boolean_option_def>: Update.
 822         (struct flag_option_def): Change default type of Context to bool
 823         from int.
 824         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 825         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 826         (get_setshow_command_value_string): Likewise.
 827         * cli/cli-style.c (cli_styling): Change to bool.
 828         (source_styling): Likewise.
 829         * cli/cli-style.h (source_styling): Likewise.
 830         (cli_styling): Likewise.
 831         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 832         to bool.
 833         * command.h (var_types): Update comment.
 834         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 835         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 836         bool.
 837         (debug_compile_cplus_scopes): Likewise.
 838         * compile/compile-internal.h (compile_debug): Likewise.
 839         * compile/compile.c (compile_debug): Likewise.
 840         (struct compile_options) <raw>: Likewise.
 841         * cp-support.c (catch_demangler_crashes): Likewise.
 842         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 843         (usr_cmd_cris_dwarf2_cfi): Likewise.
 844         * csky-tdep.c (csky_debug): Likewise.
 845         * darwin-nat.c (enable_mach_exceptions): Likewise.
 846         * dcache.c (dcache_enabled_p): Likewise.
 847         * defs.h (info_verbose): Likewise.
 848         * demangle.c (demangle): Likewise.
 849         (asm_demangle): Likewise.
 850         * dwarf-index-cache.c (debug_index_cache): Likewise.
 851         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 852         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 853         * dwarf2read.c (check_physname): Likewise.
 854         (use_deprecated_index_sections): Likewise.
 855         (dwarf_always_disassemble): Likewise.
 856         * eval.c (overload_resolution): Likewise.
 857         * event-top.c (set_editing_cmd_var): Likewise.
 858         (exec_done_display_p): Likewise.
 859         * event-top.h (set_editing_cmd_var): Likewise.
 860         (exec_done_display_p): Likewise.
 861         * exec.c (write_files): Likewise.
 862         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 863         (debug_fbsd_nat): Likewise.
 864         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 865         Likewise.
 866         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 867         <backtrace_past_entry> Likewise.
 868         * gdb-demangle.h (demangle): Likewise.
 869         (asm_demangle): Likewise.
 870         * gdb_bfd.c (bfd_sharing): Likewise.
 871         * gdbcore.h (write_files): Likewise.
 872         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 873         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 874         * gdbthread.h (print_thread_events): Likewise.
 875         * gdbtypes.c (opaque_type_resolution): Likewise.
 876         (strict_type_checking): Likewise.
 877         * gnu-nat.c (gnu_debug_flag): Likewise.
 878         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 879         * guile/scm-param.c (pascm_variable): Add boolval.
 880         (add_setshow_generic): Update.
 881         (pascm_param_value): Update.
 882         (pascm_set_param_value_x): Update.
 883         * hppa-tdep.c (hppa_debug): Change to bool..
 884         * infcall.c (may_call_functions_p): Likewise.
 885         (coerce_float_to_double_p): Likewise.
 886         (unwind_on_signal_p): Likewise.
 887         (unwind_on_terminating_exception_p): Likewise.
 888         * infcmd.c (startup_with_shell): Likewise.
 889         * inferior.c (print_inferior_events): Likewise.
 890         * inferior.h (startup_with_shell): Likewise.
 891         (print_inferior_events): Likewise.
 892         * infrun.c (step_stop_if_no_debug): Likewise.
 893         (detach_fork): Likewise.
 894         (debug_displaced): Likewise.
 895         (disable_randomization): Likewise.
 896         (non_stop): Likewise.
 897         (non_stop_1): Likewise.
 898         (observer_mode): Likewise.
 899         (observer_mode_1): Likewise.
 900         (set_observer_mode): Update.
 901         (sched_multi): Change to bool.
 902         * infrun.h (debug_displaced): Likewise.
 903         (sched_multi): Likewise.
 904         (step_stop_if_no_debug): Likewise.
 905         (non_stop): Likewise.
 906         (disable_randomization): Likewise.
 907         * linux-tdep.c (use_coredump_filter): Likewise.
 908         (dump_excluded_mappings): Likewise.
 909         * linux-thread-db.c (auto_load_thread_db): Likewise.
 910         (check_thread_db_on_load): Likewise.
 911         * main.c (captured_main_1): Update.
 912         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 913         xx2_opt, boolean_opt>: Change to bool.
 914         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 915         * maint.c (maintenance_profile_p): Likewise.
 916         (per_command_time): Likewise.
 917         (per_command_space): Likewise.
 918         (per_command_symtab): Likewise.
 919         * memattr.c (inaccessible_by_default): Likewise.
 920         * mi/mi-main.c (mi_async): Likewise.
 921         (mi_async_1): Likewise.
 922         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 923         * nat/fork-inferior.h (startup_with_shell): Likewise.
 924         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 925         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 926         * nios2-tdep.c (nios2_debug): Likewise.
 927         * or1k-tdep.c (or1k_debug): Likewise.
 928         * parse.c (parser_debug): Likewise.
 929         * parser-defs.h (parser_debug): Likewise.
 930         * printcmd.c (print_symbol_filename): Likewise.
 931         * proc-api.c (procfs_trace): Likewise.
 932         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 933         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 934         (set_parameter_value): Update.
 935         (add_setshow_generic): Update.
 936         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 937         to bool*.
 938         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 939         int*.
 940         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 941         * record-btrace.c (record_btrace_target::store_registers): Update.
 942         * record-full.c (record_full_memory_query): Change to bool.
 943         (record_full_stop_at_limit): Likewise.
 944         * record-full.h (record_full_memory_query): Likewise.
 945         * remote-notif.c (notif_debug): Likewise.
 946         * remote-notif.h (notif_debug): Likewise.
 947         * remote.c (use_range_stepping): Likewise.
 948         (interrupt_on_connect): Likewise.
 949         (remote_break): Likewise.
 950         * ser-tcp.c (tcp_auto_retry): Likewise.
 951         * ser-unix.c (serial_hwflow): Likewise.
 952         * skip.c (debug_skip): Likewise.
 953         * solib-aix.c (solib_aix_debug): Likewise.
 954         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 955         (spu_auto_flush_cache_p): Likewise.
 956         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 957         Likewise.
 958         (struct info_print_options) <quiet>: Likewise.
 959         * symfile-debug.c (debug_symfile): Likewise.
 960         * symfile.c (auto_solib_add): Likewise.
 961         (separate_debug_file_debug): Likewise.
 962         * symfile.h (auto_solib_add): Likewise.
 963         (separate_debug_file_debug): Likewise.
 964         * symtab.c (basenames_may_differ): Likewise.
 965         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 966         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 967         (struct info_types_options) <quiet>: Likewise.
 968         * symtab.h (demangle): Likewise.
 969         (basenames_may_differ): Likewise.
 970         * target-dcache.c (stack_cache_enabled_1): Likewise.
 971         (code_cache_enabled_1): Likewise.
 972         * target.c (trust_readonly): Likewise.
 973         (may_write_registers): Likewise.
 974         (may_write_memory): Likewise.
 975         (may_insert_breakpoints): Likewise.
 976         (may_insert_tracepoints): Likewise.
 977         (may_insert_fast_tracepoints): Likewise.
 978         (may_stop): Likewise.
 979         (auto_connect_native_target): Likewise.
 980         (target_stop_and_wait): Update.
 981         (target_async_permitted): Change to bool.
 982         (target_async_permitted_1): Likewise.
 983         (may_write_registers_1): Likewise.
 984         (may_write_memory_1): Likewise.
 985         (may_insert_breakpoints_1): Likewise.
 986         (may_insert_tracepoints_1): Likewise.
 987         (may_insert_fast_tracepoints_1): Likewise.
 988         (may_stop_1): Likewise.
 989         * target.h (target_async_permitted): Likewise.
 990         (may_write_registers): Likewise.
 991         (may_write_memory): Likewise.
 992         (may_insert_breakpoints): Likewise.
 993         (may_insert_tracepoints): Likewise.
 994         (may_insert_fast_tracepoints): Likewise.
 995         (may_stop): Likewise.
 996         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 997         (make_thread_apply_all_options_def_group): Change argument from int*
 998         to bool*.
 999         (thread_apply_all_command): Update.
1000         (print_thread_events): Change to bool.
1001         * top.c (confirm): Likewise.
1002         (command_editing_p): Likewise.
1003         (history_expansion_p): Likewise.
1004         (write_history_p): Likewise.
1005         (info_verbose): Likewise.
1006         * top.h (confirm): Likewise.
1007         (history_expansion_p): Likewise.
1008         * tracepoint.c (disconnected_tracing): Likewise.
1009         (circular_trace_buffer): Likewise.
1010         * typeprint.c (print_methods): Likewise.
1011         (print_typedefs): Likewise.
1012         * utils.c (debug_timestamp): Likewise.
1013         (sevenbit_strings): Likewise.
1014         (pagination_enabled): Likewise.
1015         * utils.h (sevenbit_strings): Likewise.
1016         (pagination_enabled): Likewise.
1017         * valops.c (overload_resolution): Likewise.
1018         * valprint.h (struct value_print_options) <prettyformat_arrays,
1019         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1020         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1021         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1022         Likewise.
1023         * windows-nat.c (new_console): Likewise.
1024         (cygwin_exceptions): Likewise.
1025         (new_group): Likewise.
1026         (debug_exec): Likewise.
1027         (debug_events): Likewise.
1028         (debug_memory): Likewise.
1029         (debug_exceptions): Likewise.
1030         (useshell): Likewise.
1031         * windows-tdep.c (maint_display_all_tib): Likewise.
1032         * xml-support.c (debug_xml): Likewise.
1033
1034 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1035
1036         * source.c (prepare_path_for_appending): New function.
1037         (openp): Make use of new function.
1038         (find_and_open_source): Search for the compilation directory and
1039         source file as a relative path beneath the directory search path.
1040
1041 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1042
1043         * source-cache.c (source_cache::get_line_charpos): Catch
1044         exceptions and return false, this matches the behaviour documented
1045         in the header file.
1046
1047 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1048
1049         * ada-tasks.c (info_task): Remove quoting of the task's name.
1050
1051 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1052
1053         * symfile.c (auto_solib_add): Replace comment with a reference
1054         to the header file.
1055
1056 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1057
1058         * NEWS: Mention that gdb can now be compiled with Python 3
1059         on Windows.
1060
1061 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1062
1063         * maint.c (maint_print_section_data::maint_print_section_data):
1064         Force use of 'float log10 (float)' by casting the argument to
1065         float.
1066
1067 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1068
1069         * maint.c: Add 'cmath' include.
1070         (struct maint_print_section_data): New structure.
1071         (print_section_index): New function.
1072         (print_bfd_section_info): Add header comment, small whitespace
1073         cleanup, and update to call new print_section_index function.
1074         (print_objfile_section_info): Likewise.
1075         (maint_obj_section_from_bfd_section): New function.
1076         (print_bfd_section_info_maybe_relocated): New function.
1077         (maintenance_info_sections): Add header comment, always use
1078         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1079
1080 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1081
1082         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1083         inner scope, add check that the objfile has psymtabs before
1084         checking psymtabs_addrmap.
1085         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1086
1087 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1088
1089         * NEWS: Announce that Ada task names are now shown at more places,
1090         and between quotes (except in info task output).
1091         * gdb/ada-tasks.c (task_to_str): New function.
1092         (display_current_task_id): Call task_to_str.
1093         (task_command_1): Likewise.
1094         (print_ada_task_info): In non-mi mode, Properly align headers and data
1095         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1096
1097 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1098
1099         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1100         prstatus.pr_lwp.pr_info instead of making it up.
1101
1102 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1103
1104         * auto-load.c (auto_load_expand_dir_vars): Update.
1105         * defs.h (gdb_datadir): Change to std::string.
1106         (python_libdir): Likewise.
1107         (relocate_gdb_directory): Change return type to std::string.
1108         * guile/guile.c (gdbscm_data_directory): Update.
1109         (initialize_scheme_side): Update.
1110         * jit.c (jit_reader_dir): Change to std::string.
1111         (jit_reader_load_command): Update.
1112         * main.c (gdb_datadir): Change to std::string.
1113         (python_libdir): Likewise.
1114         (set_gdb_data_directory): Update.
1115         (relocate_path): Change to return std::string.
1116         (relocate_gdb_directory): Change to return std::string.
1117         (relocate_gdbinit_path_maybe_in_datadir): Update.
1118         (captured_main_1): Update.
1119         * python/python.c (do_start_initialization): Update.
1120         * top.c (show_gdb_datadir): Update.
1121         * xml-syscall.c (xml_init_syscalls_info): Update.
1122         (init_syscalls_info): Update.
1123
1124 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1125
1126         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1127         out of get_init_files.
1128         (get_init_files): Update.
1129
1130 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1131
1132         * main.c (get_init_files): Change to use std::string.
1133         (captured_main_1): Update.
1134         (print_gdb_help): Update.
1135
1136 2019-09-11  Ali Tamur  <tamur@google.com>
1137
1138         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1139         implementation.
1140
1141 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1142
1143         * dbxread.c (read_dbx_symtab): Update.
1144         * dwarf2read.c (load_partial_dies): Update.
1145         * mdebugread.c (parse_partial_symbols): Update.
1146         (handle_psymbol_enumerators): Update.
1147         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1148         * psymtab.c (add_psymbol_to_bcache): Likewise.
1149         (add_psymbol_to_list): Likewise.
1150         * symtab.c (symbol_set_names): Likewise.
1151         * symtab.h (symbol_set_names): Likewise.
1152         * xcoffread.c (scan_xcoff_symtab): Update.
1153
1154 2019-09-11  Tom Tromey  <tom@tromey.com>
1155
1156         * symfile-mem.c (symbol_file_add_from_memory): Use
1157         bfd_set_filename.
1158         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1159         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1160
1161 2019-09-10  Tom Tromey  <tromey@adacore.com>
1162
1163         * dwarf-index-write.c (write_psymbols): Extend error message.
1164         (debug_names::insert): Add Ada code.
1165         (debug_names::write_psymbols): Remove Ada check.
1166         (debug_names) <m_string_obstack>: New member.
1167         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1168         (gdb_index_symbol_name_matcher::matches): Remove.
1169         (mapped_index_base::find_name_components_bounds): Add "lang"
1170         parameter.
1171         (mapped_index_base::build_name_components): Also split names
1172         according to Ada syntax.
1173         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1174         type of "match_callback".
1175         (check_match, check_find_bounds_finds)
1176         (dw2_expand_symtabs_matching): Update.
1177         (dw2_debug_names_iterator): Add new constructor.
1178         (dw2_debug_names_map_matching_symbols): New function.
1179         (dw2_debug_names_expand_symtabs_matching): Update.
1180         (dwarf2_debug_names_functions): Use
1181         dw2_debug_names_map_matching_symbols.
1182
1183 2019-09-10  Tom Tromey  <tromey@adacore.com>
1184
1185         * dwarf2read.c (dw2_get_file_names_reader): Add the
1186         CU's file name to the results.
1187
1188 2019-09-10  Tom Tromey  <tromey@adacore.com>
1189
1190         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1191         map_matching_symbols.  Update.
1192         * dwarf2read.c (dw2_map_matching_symbols): Update.
1193         * psymtab.c (match_partial_symbol): Change type; update.
1194         (psym_map_matching_symbols): Likewise.
1195         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1196         type; update.
1197         * symfile.h (struct quick_symbol_functions)
1198         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1199         Remove "match".
1200
1201 2019-09-10  Tom Tromey  <tromey@adacore.com>
1202
1203         * psymtab.c (map_block): Remove.
1204         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1205         * symtab.c (iterate_over_symbols_terminated): New function.
1206         * symtab.c (iterate_over_symbols_terminated): Declare.
1207
1208 2019-09-10  Tom Tromey  <tromey@adacore.com>
1209
1210         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1211         * language.h (struct language_defn) <la_iterate_over_symbols>:
1212         Return bool.
1213         * symtab.c (iterate_over_symbols): Return bool.
1214         * symtab.h (iterate_over_symbols): Return bool.
1215
1216 2019-09-10  Tom Tromey  <tromey@adacore.com>
1217
1218         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1219         (add_nonlocal_symbols): Update.
1220         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1221         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1222         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1223         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1224         Change type of "callback".  Remove "data".
1225
1226
1227 2019-09-09  Ali Tamur  <tamur@google.com>
1228
1229         * dwarf2read.c (comp_unit_head): Update comment.
1230         (dwarf2_dwo_name): New function declaration.
1231         (dwarf_unit_type_name): New function declaration.
1232         (read_comp_unit_head): Add support for new compilation units,
1233         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1234         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1235         (currently named as "signature") in their header. Also clarify error
1236         messages.
1237         (lookup_dwo_id): New function. Returns the dwo id of the given
1238         compile unit.
1239         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1240         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1241         functions.
1242         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1243         (dwarf2_dwo_name): Get the dwo name if present.
1244         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1245         purposes.
1246
1247 2019-09-09  Tom Tromey  <tom@tromey.com>
1248
1249         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1250
1251 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1252
1253         * python/python.c (do_start_initialization): Make progname_copy static,
1254         to avoid a leak report.
1255
1256 2019-09-08  Tom Tromey  <tom@tromey.com>
1257
1258         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1259
1260 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1261
1262         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1263         Change type to gdb::optional<block_enum>.
1264         (dw2_symtab_iter_init): Change block_index parameter type
1265         to gdb::optional<block_enum>.
1266         (dw2_lookup_symbol): Change block_index parameter
1267         type to block_enum.c
1268         (dw2_debug_names_lookup_symbol): Likewise.
1269         * psymtab.c (psym_lookup_symbol): Likewise.
1270         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1271         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1272         Likewise.
1273
1274 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1275
1276         * defs.h (relocate_gdb_directory): Change int to bool in
1277         signature and rename flag to relocatable.
1278         * main.c (relocate_path): Likewise.
1279         (relocate_gdb_directory): Likewise.
1280
1281 2019-09-06  Alan Modra  <amodra@gmail.com>
1282
1283         * coffread.c (coff_symfile_read): Constify filename variable.
1284         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1285         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1286         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1287         * solib.c (reload_shared_libraries_1): Likewise.
1288         * symfile.c (reread_symbols): Likewise.
1289         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1290         * solib-darwin.c (darwin_bfd_open): Likewise.
1291         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1292
1293 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1294
1295         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1296         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1297
1298 2019-09-03  Tom Tromey  <tromey@adacore.com>
1299
1300         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1301         types.
1302         (has_negatives): Unbias a range type bound.
1303         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1304         * gdbtypes.c (operator==): Handle new field.
1305         (create_range_type): Add "bias" parameter.
1306         (create_static_range_type, resolve_dynamic_range): Update.
1307         * gdbtypes.h (struct range_bounds) <bias>: New member.
1308         (create_range_type): Add bias parameter.
1309         * printcmd.c (print_scalar_formatted): Unbias range types.
1310         * value.c (unpack_long): Unbias range types.
1311         (pack_long): Bias range types.
1312
1313 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1314
1315         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1316         probe arguments.
1317
1318 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1319
1320         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1321         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1322         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1323         (compile_probe_arg): Likewise.
1324         * probe.h (get_argument_count): Likewise.
1325         * solib-svr4.c (solib_event_probe_action): Likewise.
1326         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1327
1328 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1329
1330         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1331         code to here...
1332         (svr4_create_solib_event_breakpoints): ...from here.
1333
1334 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1335
1336         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1337         suffix from warning message.
1338
1339 2019-08-30  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-winsource.h (struct tui_source_window_base)
1342         <refresh_all>: Don't declare.
1343         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1344         Remove.
1345         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1346         tui_show_locator_content.
1347         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1348         declare.
1349         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1350         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1351         declare.
1352
1353 2019-08-30  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1356
1357 2019-08-30  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1360         Remove unnecessary forward declarations.
1361
1362 2019-08-30  Tom Tromey  <tom@tromey.com>
1363
1364         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1365         rerender.
1366         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1367         tui_show_locator_content.
1368
1369 2019-08-30  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1372         (tui_locator_window::rerender): Rewrite using body of previous
1373         tui_show_locator_content.
1374
1375 2019-08-30  Tom Tromey  <tom@tromey.com>
1376
1377         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1378         set_locator_fullname>: New methods.
1379         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1380         Rename from tui_set_locator_fullname.
1381         (tui_locator_window::set_locator_info): Rename from
1382         tui_set_locator_info.  Return bool.
1383         (tui_update_locator_fullname, tui_show_frame_info): Update.
1384
1385 2019-08-30  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1388
1389 2019-08-30  Tom Tromey  <tom@tromey.com>
1390
1391         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1392         call touchwin.
1393
1394 2019-08-30  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-wingeneral.c (box_win): Assume win_info and
1397         win_info->handle cannot be NULL.
1398
1399 2019-08-30  Tom Tromey  <tom@tromey.com>
1400
1401         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1402         refresh_window>: Declare.
1403         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1404         resize.
1405         (tui_data_item_window::rerender): Rename from
1406         tui_display_register.
1407         (tui_data_item_window::refresh_window): New method.
1408         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1409         no-op.
1410
1411 2019-08-30  Tom Tromey  <tom@tromey.com>
1412
1413         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1414         regs_column_count, current_group>: Move later.  Now private.
1415         <get_current_group>: New method.
1416         * tui/tui-regs.c (tui_reg_command): Update.
1417         * tui/tui-layout.c (tui_set_layout): Update.
1418
1419 2019-08-30  Tom Tromey  <tom@tromey.com>
1420
1421         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1422         (tui_data_window::rerender): Don't call
1423         check_and_display_highlight_if_needed.
1424         (tui_data_window::refresh_all): Remove call to
1425         erase_data_content.
1426
1427 2019-08-30  Tom Tromey  <tom@tromey.com>
1428
1429         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1430         (tui_data_window::display_registers_from)
1431         (tui_data_window::display_reg_element_at_line)
1432         (tui_data_window::display_registers_from_line): Remove checks of
1433         "empty".
1434
1435 2019-08-30  Tom Tromey  <tom@tromey.com>
1436
1437         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1438         Don't declare.
1439         * tui/tui-regs.c (tui_data_window::show_registers): Call
1440         rerender.
1441         (tui_data_window::rerender): Rename from display_all_data.
1442         (tui_data_window::rerender): Remove old implementation.
1443
1444 2019-08-30  Tom Tromey  <tom@tromey.com>
1445
1446         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1447         text.
1448         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1449
1450 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1451             Sergio Durigan Junior  <sergiodj@redhat.com>
1452
1453         PR win32/24284
1454         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1455
1456 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1459         when searching for types.
1460
1461 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1462
1463         * f-lang.c (f_language_defn): Use f_print_typedef.
1464         * f-lang.h (f_print_typedef): Declare.
1465         * f-typeprint.c (f_print_typedef): Define.
1466
1467 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1468
1469         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1470
1471 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * cli/cli-utils.c (info_print_options_defs): Delete.
1474         (make_info_print_options_def_group): Delete.
1475         (extract_info_print_options): Delete.
1476         (info_print_command_completer): Delete.
1477         (info_print_args_help): Add extra parameter, and optionally
1478         include text about -n flag.
1479         * cli/cli-utils.h (struct info_print_options): Delete.
1480         (extract_info_print_options): Delete declaration.
1481         (info_print_command_completer): Delete declaration.
1482         (info_print_args_help): Add extra parameter, extend header
1483         comment.
1484         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1485         search_symbols.
1486         * stack.c (struct info_print_options): New type.
1487         (info_print_options_defs): New file scoped variable.
1488         (make_info_print_options_def_group): New static function.
1489         (info_print_command_completer): New static function.
1490         (info_locals_command): Update to use new local functions.
1491         (info_args_command): Likewise.
1492         (_initialize_stack): Add extra parameter to calls to
1493         info_print_args_help.
1494         * symtab.c (search_symbols): Add extra parameter, use this to
1495         possibly excluse non-debug symbols.
1496         (symtab_symbol_info): Add extra parameter, which is passed on to
1497         search_symbols.
1498         (struct info_print_options): New type.
1499         (info_print_options_defs): New file scoped variable.
1500         (make_info_print_options_def_group): New static function.
1501         (info_print_command_completer): New static function.
1502         (info_variables_command): Update to use local functions, and pass
1503         extra parameter through to symtab_symbol_info.
1504         (info_functions_command): Likewise.
1505         (info_types_command): Pass additional argument through to
1506         symtab_symbol_info.
1507         (rbreak_command): Pass extra argument to search_symbols.
1508         (_initialize_symtab): Add extra arguments for calls to
1509         info_print_args_help, and update help text for 'info variables',
1510         'whereis', and 'info functions' commands.
1511         * symtab.h (search_symbols): Add extra argument to declaration.
1512         * NEWS: Mention new flags.
1513
1514 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1515
1516         * symtab.c (lookup_static_symbol): Call the new function (and move
1517         it down to be next to lookup_global_symbol).
1518         (struct global_sym_lookup_data): Add block_enum member and rename to...
1519         (struct global_or_static_sym_lookup_data): ...this.
1520         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1521         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1522         (lookup_symbol_global_or_static_iterator_cb): ...this.
1523         (lookup_global_or_static_symbol): New function.
1524         (lookup_global_symbol): Call new function.
1525
1526 2019-08-26  Tom de Vries  <tdevries@suse.de>
1527
1528         PR c++/24852
1529         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1530         when pc_probe.prob == NULL.
1531
1532 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1533
1534         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1535         variable symbol_linkage to symbol_linkage_.
1536
1537 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1538
1539         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1540         represent whether the symbol is static, dynamic, or we don't
1541         know.
1542
1543 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1544
1545         * gdb/rx-tdep.c (rx_register_names): New.
1546         (rx_register_name): Delete.
1547         (rx_psw_type): Delete.
1548         (rx_fpsw_type): Delete.
1549         (rx_register_type): Delete.
1550         (rx_gdbarch_init): Convert target-descriptions.
1551         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1552         * gdb/features/Makefile: Add rx.xml.
1553         * gdb/features/rx.xml: New.
1554         * gdb/features/rx.c: Generated.
1555         * gdb/NEWS: Mention target description support.
1556
1557 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1558
1559         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1560         *slot_ptr.
1561
1562 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1563
1564         * configure.ac: Don't check for 'dlfcn.h' (moved to
1565         gdbsupport/common.m4).
1566         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1567         'gdbsupport/'.
1568         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1569         * compile/compile-c-support.c: Include
1570         'gdbsupport/gdb-dlfcn.h'.
1571         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1572         * gdb-dlfcn.c: Move to...
1573         * gdbsupport/gdb-dlfcn.c: ... here.
1574         * gdb-dlfcn.h: Move to...
1575         * gdbsupport/gdb-dlfcn.h: ... here.
1576
1577 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1578
1579         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1580         the offset field signed.
1581
1582 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1583
1584         * python/lib/gdb/__init__.py (_execute_file): New function.
1585         * python/python.c (python_run_simple_file): Call gdb._execute_file
1586         on Windows.
1587
1588 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1589
1590         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1591         all uses as this was never set to anything but a zero value.
1592
1593 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1594
1595         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1596
1597 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1598
1599         * tui/tui-data.h (tui_gen_win_info): Add an =default
1600         move constructor, required by some GCC versions.
1601
1602 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1603
1604         * go32-nat.c (go32_sysinfo): Add hygon_p.
1605
1606 2019-08-20  Tom Tromey  <tom@tromey.com>
1607
1608         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1609         line_from_reg_element_no, first_reg_element_no_inline,
1610         display_all_data, delete_data_content_windows,
1611         erase_data_content>: Now private.
1612
1613 2019-08-20  Tom Tromey  <tom@tromey.com>
1614
1615         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1616         (tui_unhighlight_win, tui_highlight_win)
1617         (tui_win_info::make_window): Update.
1618         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1619
1620 2019-08-20  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1623         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1624         (MAX_PID_WIDTH): Move to tui-stack.c.
1625         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1626         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1627         (MAX_PID_WIDTH): Move from tui-data.h.
1628
1629 2019-08-20  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1632         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1633         (box_win): Update.
1634         (tui_gen_win_info::make_window): Rename from tui_make_window.
1635         (tui_win_info::make_window): New method.
1636         (tui_gen_win_info::make_visible): Update.
1637         * tui/tui-source.c (tui_source_window::set_contents): Update.
1638         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1639         (tui_data_window::display_registers_from): Update.
1640         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1641         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1642         Declare.
1643         <can_box>: Remove.
1644         <title>: Remove.
1645         (struct tui_win_info) <make_window>: Declare.
1646         <can_box>: Now virtual.
1647         <title>: New member.
1648         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1649         * tui/tui-command.c (tui_cmd_window::resize): Update.
1650
1651 2019-08-20  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1654         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1655         (tui_data_window::check_register_values): Update.
1656
1657 2019-08-20  Tom Tromey  <tom@tromey.com>
1658
1659         * tui/tui-regs.h (struct tui_data_window): Use
1660         DISABLE_COPY_AND_ASSIGN.
1661         <regs_content>: Change type, removing unique_ptr.
1662         <tui_data_window>: Add move constructor.
1663         * tui/tui-regs.c (tui_data_window::show_registers)
1664         (tui_data_window::show_register_group)
1665         (tui_data_window::display_registers_from)
1666         (tui_data_window::display_registers_from)
1667         (tui_data_window::first_data_item_displayed)
1668         (tui_data_window::delete_data_content_windows)
1669         (tui_data_window::rerender, tui_data_window::refresh_window)
1670         (tui_data_window::check_register_values): Update.
1671
1672 2019-08-20  Tom Tromey  <tom@tromey.com>
1673
1674         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1675         show_register_group>: Declare.
1676         (tui_show_register_group): Don't declare.
1677         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1678         tui_show_registers.
1679         (tui_data_window::show_register_group): Rename from
1680         tui_show_register_group.
1681         (tui_data_window::check_register_values, tui_reg_command):
1682         Update.
1683         * tui/tui-layout.c (tui_set_layout): Update.
1684
1685 2019-08-20  Tom Tromey  <tom@tromey.com>
1686
1687         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1688         Declare.
1689         (tui_check_register_values): Don't declare.
1690         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1691         from tui_check_register_values.
1692         * tui/tui-hooks.c (tui_register_changed): Update.
1693
1694 2019-08-20  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-regs.c (tui_reg_layout): Move later.
1697         (tui_show_registers): Don't enable TUI mode or change layout.
1698
1699 2019-08-20  Tom Tromey  <tom@tromey.com>
1700
1701         * tui/tui-regs.h (struct tui_data_item_window)
1702         <~tui_data_item_window>: Remove.
1703         <content>: Now a unique_xmalloc_ptr.
1704         * tui/tui-regs.c (tui_register_format): Return a
1705         unique_xmalloc_ptr.
1706         (tui_get_register): Update.
1707         (~tui_data_item_window): Remove.
1708         (tui_data_window::display_registers_from, tui_display_register):
1709         Update.
1710         * tui/tui-io.h (tui_expand_tabs): Update.
1711         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1712         Remove "col" parameter.
1713
1714 2019-08-20  Tom Tromey  <tom@tromey.com>
1715
1716         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1717         field.
1718         * tui/tui-regs.c (~tui_data_item_window): Update.
1719
1720 2019-08-20  Tom Tromey  <tom@tromey.com>
1721
1722         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1723         earlier.
1724
1725 2019-08-20  Tom Tromey  <tom@tromey.com>
1726
1727         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1728
1729 2019-08-20  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-source.h (struct tui_source_window): Update.
1732         * tui/tui-regs.c (tui_show_registers): Update.
1733         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1734         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1735         (NO_REGS_STRING): Remove defines.
1736
1737 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1738
1739         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1740         unnecessary thread walk if remote doesn't support the packet.
1741
1742 2019-08-19  Tom Tromey  <tromey@adacore.com>
1743
1744         * python/py-value.c (value_has_field): Fix indentation.
1745
1746 2019-08-19  Tom Tromey  <tromey@adacore.com>
1747
1748         * printcmd.c (do_one_display, info_display_command): Update.
1749         * block.h (contained_in): Return bool.  Add allow_nested
1750         parameter.
1751         * block.c (contained_in): Return bool.  Add allow_nested
1752         parameter.
1753
1754 2019-08-19  Tom Tromey  <tom@tromey.com>
1755
1756         * configure: Rebuild.
1757         * configure.ac: Disallow the combination of -static-libstdc++ and
1758         source highlight.
1759         * source-cache.c (get_language_name): Handle rust.
1760         (source_cache::get_source_lines): Ignore highlighting exceptions.
1761
1762 2019-08-16  Tom Tromey  <tom@tromey.com>
1763
1764         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1765         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1766         (struct tui_source_window_base) <make_visible, refresh_window,
1767         resize>: Remove methods.
1768         <execution_info>: Remove field.
1769         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1770         (tui_show_source_line, tui_source_window_base)
1771         (~tui_source_window_base): Update.
1772         (tui_source_window_base::resize)
1773         (tui_source_window_base::make_visible)
1774         (tui_source_window_base::refresh_window): Remove.
1775         (tui_source_window_base::update_exec_info): Update.
1776         * tui/tui-source.c (tui_source_window::set_contents): Update.
1777         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1778
1779 2019-08-16  Tom Tromey  <tom@tromey.com>
1780
1781         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1782         deprecated_query_hook.
1783
1784 2019-08-16  Tom Tromey  <tom@tromey.com>
1785
1786         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1787         (tui_update_source_windows_with_line): Update.
1788         * tui/tui-source.h (struct tui_source_window)
1789         <show_symtab_source>: Declare.
1790         (tui_show_symtab_source): Don't declare.
1791         * tui/tui-source.c (tui_show_symtab_source): Rename from
1792         tui_show_symtab_source.
1793
1794 2019-08-16  Tom Tromey  <tom@tromey.com>
1795
1796         * tui/tui-winsource.h (struct tui_source_window_base)
1797         <set_contents>: Declare.
1798         * tui/tui-winsource.c
1799         (tui_source_window_base::update_source_window_as_is): Update.
1800         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1801         Declare.
1802         (tui_set_source_content): Don't declare.
1803         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1804         tui_set_source_content.
1805         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1806         Declare.
1807         (tui_set_disassem_content): Don't declare.
1808         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1809         tui_set_disassem_content.
1810
1811 2019-08-16  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-winsource.h (struct tui_source_window_base)
1814         <update_breakpoint_info>: Declare.
1815         (tui_update_breakpoint_info): Don't declare.
1816         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1817         (tui_update_all_breakpoint_info): Update.
1818         (tui_source_window_base::update_breakpoint_info): Rename from
1819         tui_update_breakpoint_info.
1820         (tui_source_window_base::update_exec_info): Update.
1821
1822 2019-08-16  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-winsource.h (struct tui_source_window_base)
1825         <update_source_window>: Declare.
1826         (tui_update_source_window): Don't declare.
1827         * tui/tui-winsource.c
1828         (tui_source_window_base::update_source_window): Rename from
1829         tui_update_source_window.
1830         (tui_source_window_base::rerender): Update.
1831         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1832         * tui/tui-disasm.c (tui_show_disassem)
1833         (tui_show_disassem_and_update_source)
1834         (tui_disasm_window::maybe_update): Update.
1835
1836 2019-08-16  Tom Tromey  <tom@tromey.com>
1837
1838         * tui/tui-winsource.h (struct tui_source_window_base)
1839         <update_source_window_as_is>: Declare.
1840         (tui_update_source_window_as_is): Don't declare.
1841         * tui/tui-winsource.c (tui_update_source_window): Update
1842         (tui_source_window_base::update_source_window_as_is): Rename from
1843         tui_update_source_window_as_is.
1844         (tui_source_window_base::refill): Update.
1845         * tui/tui-source.c (tui_show_symtab_source): Update.
1846         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1847         Update.
1848
1849 2019-08-16  Tom Tromey  <tom@tromey.com>
1850
1851         * tui/tui-winsource.h (tui_update_source_window)
1852         (tui_update_source_window_as_is): Remove "noerror" parameter.
1853         * tui/tui-winsource.c (tui_update_source_window)
1854         (tui_update_source_window_as_is): Remove "noerror" parameter.
1855         (tui_update_source_windows_with_addr)
1856         (tui_update_source_windows_with_line)
1857         (tui_source_window_base::rerender)
1858         (tui_source_window_base::refill): Update.
1859         * tui/tui-source.h (tui_set_source_content)
1860         (tui_show_symtab_source): Remove "noerror" parameter.
1861         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1862         parameter.
1863         (tui_show_symtab_source): Likewise.
1864         (tui_source_window::maybe_update): Update.
1865         * tui/tui-disasm.c (tui_show_disassem)
1866         (tui_show_disassem_and_update_source)
1867         (tui_disasm_window::do_scroll_vertical)
1868         (tui_disasm_window::maybe_update): Update.
1869
1870 2019-08-16  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui.c (tui_is_window_visible): Update.
1873         * tui/tui-wingeneral.c (tui_make_window)
1874         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1875         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1876         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1877         (tui_set_win_height_command, parse_scrolling_args): Update.
1878         * tui/tui-source.c (tui_source_window::style_changed): Update.
1879         * tui/tui-regs.c (tui_show_registers)
1880         (tui_data_window::first_data_item_displayed)
1881         (tui_data_window::delete_data_content_windows)
1882         (tui_check_register_values, tui_reg_command): Update.
1883         * tui/tui-disasm.c (tui_show_disassem): Update.
1884         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1885         method.
1886         <is_visible>: Remove field.
1887         * tui/tui-data.c (tui_next_win, tui_prev_win)
1888         (tui_delete_invisible_windows): Update.
1889
1890 2019-08-16  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-winsource.h (struct tui_source_window_base)
1893         <m_has_locator>: Remove.
1894         * tui/tui-layout.c (show_source_disasm_command, show_data)
1895         (show_source_or_disasm_and_command): Update.
1896
1897 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1898
1899         * NEWS (Other MI changes): New subsection.
1900         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1901         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1902         * arch-utils.c (default_get_pc_address_flags): New function.
1903         * arch-utils.h (default_get_pc_address_flags): New declaration.
1904         * gdbarch.sh: Add get_pc_address_flags.
1905         * gdbarch.c: Regenerate.
1906         * gdbarch.h: Likewise.
1907         * stack.c (print_pc): New function.
1908         (print_frame_info) (print_frame): Call print_pc.
1909
1910 2019-08-16  Tom de Vries  <tdevries@suse.de>
1911
1912         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1913         print_objfile_section_info.
1914
1915 2019-08-15  Tom Tromey  <tom@tromey.com>
1916
1917         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1918         calling update_cmdwin_start_line.
1919         * tui/tui-winsource.h (struct tui_source_window_base)
1920         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1921         <rerender>: Declare.
1922         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1923         Call rerender.
1924         (tui_source_window_base::set_new_height): Remove.
1925         (tui_source_window_base::rerender): Rename from
1926         do_make_visible_with_new_height.
1927         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1928         resize method.
1929         (tui_win_info::make_invisible_and_set_new_height)
1930         (tui_win_info::make_visible_with_new_height): Remove.
1931         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1932         Declare.
1933         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1934         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1935         do_make_visible_with_new_height>: Don't declare.
1936         <rerender>: Declare.
1937         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1938         set_new_height.
1939         (tui_data_window::do_make_visible_with_new_height): Remove.
1940         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1941         call tui_show_locator_content.
1942         (tui_gen_win_info::resize): Call rerender.
1943         (show_source_or_disasm_and_command): Don't call
1944         tui_show_locator_content.
1945         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1946         method.
1947         (struct tui_win_info) <rerender>: Declare.
1948         <set_new_height, make_invisible_and_set_new_height,
1949         make_visible_with_new_height>: Don't declare.
1950         * tui/tui-data.c (tui_win_list::rerender): New method.
1951         * tui/tui-command.h (struct tui_cmd_window)
1952         <do_make_visible_with_new_height>: Don't declare.
1953         * tui/tui-command.c
1954         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1955
1956 2019-08-15  Tom Tromey  <tromey@adacore.com>
1957
1958         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1959         * ada-lang.c (ada_enum_name): Likewise.
1960
1961 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1962
1963         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1964         leading underscore.
1965         (GdbOutputErrorFile): Likewise.
1966         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1967         accordingly.
1968         (execute_unwinders): Rename to have a leading underscore.
1969         (auto_load_packages): Likewise.
1970         (global scope): Adjust call to auto_load_packages accordingly.
1971         (GdbSetPythonDirectory): Likewise.
1972         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1973         instead of execute_unwinders.
1974
1975 2019-08-15  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1978         (show_data): Don't change window visibility.
1979         (tui_gen_win_info::resize): Remove special case for command
1980         window.  Use wresize, when available.
1981         (show_source_or_disasm_and_command): Don't change window
1982         visibility.
1983         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1984         <make_visible>: New method.
1985         * tui/tui-command.c (tui_cmd_window::resize): New method.
1986
1987 2019-08-15  Tom Tromey  <tom@tromey.com>
1988
1989         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1990         (struct tui_source_windows): New.
1991         * tui/tui-winsource.c (tui_display_main): Update.
1992         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1993         (new_height_ok, parse_scrolling_args): Update.
1994         * tui/tui-layout.c (show_layout, show_data): Update.
1995         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1996         (tui_add_to_source_windows): Don't declare.
1997         * tui/tui-data.c (source_windows, tui_source_windows)
1998         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1999
2000 2019-08-15  Tom Tromey  <tom@tromey.com>
2001
2002         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2003         Rename from reset.
2004         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2005         * tui/tui-layout.c (show_source_disasm_command, show_data):
2006         Update.
2007         (tui_gen_win_info::resize): Rename.
2008         (show_source_or_disasm_and_command): Update.
2009         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2010         reset.
2011
2012 2019-08-15  Tom Tromey  <tom@tromey.com>
2013
2014         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2015         * tui/tui-interp.c (tui_interp::init): Don't call
2016         tui_initialize_static_data.
2017         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2018
2019 2019-08-15  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2022         examine tui_win_list.
2023
2024 2019-08-15  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2027         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2028         tui_clear_source_content.
2029         (tui_clear_source_content): Remove.
2030         (tui_source_window_base::do_erase_source_content): Hoist call to
2031         content.clear().
2032         * tui/tui-stack.c (tui_show_frame_info): Don't call
2033         tui_clear_source_content.
2034
2035 2019-08-15  Tom Tromey  <tom@tromey.com>
2036
2037         * tui/tui-winsource.h (struct tui_source_window_base)
2038         <do_erase_source_content>: New method.
2039         <erase_source_content>: New method.
2040         (tui_erase_source_content): Don't declare.
2041         * tui/tui-winsource.c (tui_clear_source_content): Update.
2042         (tui_source_window_base::do_erase_source_content): Rename from
2043         tui_erase_source_content.
2044         (tui_source_window_base::show_source_content): Update.
2045         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2046         * tui/tui-source.h (struct tui_source_window)
2047         <erase_source_content>: New method.
2048         * tui/tui-disasm.h (struct tui_disasm_window)
2049         <erase_source_content>: New method.
2050
2051 2019-08-15  Tom Tromey  <tom@tromey.com>
2052
2053         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2054         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2055         constructor.
2056         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2057         * tui/tui-source.c (tui_set_source_content): Update.
2058         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2059
2060 2019-08-15  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2063         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2064         tui-source.c.
2065         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2066         Declare.
2067         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2068         method.
2069         (tui_source_window::maybe_update): Update.
2070
2071 2019-08-15  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2074         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2075         tui-disasm.c.
2076         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2077         Declare.
2078         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2079         method.
2080         (tui_disasm_window::maybe_update): Update.
2081
2082 2019-08-15  Tom Tromey  <tom@tromey.com>
2083
2084         * tui/tui-winsource.h (struct tui_source_window_base)
2085         <maybe_update>: Declare.
2086         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2087         method.
2088         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2089         Declare.
2090         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2091         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2092         Declare.
2093         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2094
2095 2019-08-15  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2098
2099 2019-08-15  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-wingeneral.c: Include tui-stack.h.
2102         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2103         (struct tui_locator_window): Move from tui-data.h.
2104         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2105         (tui_initialize_static_data): Move from tui-data.c.
2106         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2107         (struct tui_locator_window): Move to tui-stack.c.
2108         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2109         (tui_initialize_static_data): Move to tui-stack.c.
2110
2111 2019-08-15  Tom Tromey  <tom@tromey.com>
2112
2113         * tui/tui-layout.c (show_source_disasm_command)
2114         (show_source_or_disasm_and_command): Use make_visible method, not
2115         tui_make_window.
2116         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2117         Remove.
2118
2119 2019-08-15  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-wingeneral.h (tui_make_window): Update.
2122         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2123         parameter.
2124         (tui_gen_win_info::make_visible): Update.
2125         * tui/tui-regs.c (tui_data_window::display_registers_from):
2126         Update.
2127         * tui/tui-layout.c (show_source_disasm_command)
2128         (show_source_or_disasm_and_command): Update.
2129         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2130         (enum tui_box): Remove.
2131         (struct tui_win_info) <can_box>: New method.
2132         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2133         method.
2134
2135 2019-08-15  Tom de Vries  <tdevries@suse.de>
2136
2137         * linux-nat-trad.c: Include gdbarch.h.
2138
2139 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2140
2141         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2142         register sizes.
2143
2144 2019-08-14  Tom Tromey  <tromey@adacore.com>
2145
2146         * darwin-nat.c: Include gdbarch.h.
2147         * darwin-nat-info.c: Include gdbarch.h.
2148
2149 2019-08-13  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2152         Remove.
2153         * tui/tui-data.c (tui_initialize_static_data): Update.
2154
2155 2019-08-13  Tom Tromey  <tom@tromey.com>
2156
2157         * tui/tui-winsource.h (struct tui_exec_info_window)
2158         <~tui_exec_info_window, maybe_allocate_content, get_content,
2159         m_content>: Remove.
2160         (struct tui_source_window_base) <set_exec_info_content,
2161         show_exec_info_content>: Don't declare.
2162         * tui/tui-winsource.c
2163         (tui_exec_info_window::maybe_allocate_content): Remove.
2164         (tui_source_window_base::update_exec_info): Rename from
2165         set_exec_info_content.
2166         (tui_source_window_base::show_exec_info_content)
2167         (tui_source_window_base::update_exec_info): Remove.
2168
2169 2019-08-13  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2172         declare.
2173         * tui/tui-winsource.c (tui_update_source_window_as_is)
2174         (tui_update_source_windows_with_addr, tui_erase_source_content):
2175         Update.
2176         (tui_clear_exec_info_content): Remove.
2177
2178 2019-08-13  Tom Tromey  <tom@tromey.com>
2179
2180         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2181         declare.
2182         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2183         call tui_erase_exec_info_content.
2184         (tui_clear_exec_info_content): Rename from
2185         tui_erase_exec_info_content.
2186         (tui_clear_exec_info_content): Delete.
2187
2188 2019-08-13  Tom Tromey  <tom@tromey.com>
2189
2190         * tui/tui-winsource.h (struct tui_source_window_base)
2191         <show_exec_info_content>: Declare.
2192         (tui_show_exec_info_content): Don't declare.
2193         * tui/tui-winsource.c
2194         (tui_source_window_base::show_exec_info_content): Rename from
2195         tui_show_exec_info_content.
2196         (tui_source_window_base::update_exec_info): Update.
2197
2198 2019-08-13  Tom Tromey  <tom@tromey.com>
2199
2200         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2201         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2202         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2203         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2204         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2205         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2206         ... here.
2207
2208 2019-08-13  Tom Tromey  <tom@tromey.com>
2209
2210         * tui/tui-winsource.h (struct tui_source_window_base)
2211         <update_exec_info>: Declare.
2212         (tui_update_exec_info): Don't declare.
2213         * tui/tui-winsource.c (tui_update_source_window_as_is)
2214         (tui_source_window_base::refresh_all)
2215         (tui_update_all_breakpoint_info): Update.
2216         (tui_source_window_base::update_exec_info): Rename from
2217         tui_update_exec_info.
2218         * tui/tui-stack.c (tui_show_frame_info): Update.
2219
2220 2019-08-13  Tom Tromey  <tom@tromey.com>
2221
2222         * tui/tui-winsource.h (struct tui_source_window_base)
2223         <set_exec_info_content>: Declare.
2224         (tui_set_exec_info_content): Don't declare.
2225         * tui/tui-winsource.c
2226         (tui_source_window_base::set_exec_info_content): Rename from
2227         tui_set_exec_info_content.
2228         (tui_update_exec_info): Update.
2229
2230 2019-08-13  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-winsource.h (struct tui_source_window_base)
2233         <show_source_content>: Declare.
2234         (tui_show_source_content): Don't declare.
2235         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2236         (tui_source_window_base::show_source_content): Rename from
2237         tui_show_source_content.
2238         (tui_source_window_base::refresh_all): Update.
2239         * tui/tui-layout.c (show_source_disasm_command)
2240         (show_source_or_disasm_and_command): Update.
2241
2242 2019-08-13  Tom Tromey  <tom@tromey.com>
2243
2244         * tui/tui-winsource.c (tui_erase_source_content)
2245         (tui_show_source_content, tui_source_window_base::refresh_all):
2246         Update.
2247         * tui/tui-wingeneral.h
2248         (tui_check_and_display_highlight_if_needed): Don't declare.
2249         * tui/tui-wingeneral.c
2250         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2251         check_and_display_highlight_if_needed.
2252         * tui/tui-win.c (tui_rehighlight_all)
2253         (tui_win_info::make_visible_with_new_height): Update.
2254         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2255         (tui_data_window::erase_data_content)
2256         (tui_data_window::display_all_data): Update.
2257         * tui/tui-data.h (struct tui_win_info)
2258         <check_and_display_highlight_if_needed>: Declare.
2259
2260 2019-08-13  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-win.c (tui_resize_all): Call
2263         tui_delete_invisible_windows.
2264         * tui/tui-layout.c (show_layout): Call
2265         tui_delete_invisible_windows.
2266         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2267         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2268
2269 2019-08-13  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2272         tui_add_win_to_layout.
2273
2274 2019-08-13  Tom Tromey  <tom@tromey.com>
2275
2276         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2277         * tui/tui-layout.c (tui_default_win_height): Now static.
2278
2279 2019-08-13  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2282         single switch.
2283         (show_source_disasm_command, show_source_or_disasm_and_command):
2284         Don't check current layout.
2285
2286 2019-08-13  Tom Tromey  <tom@tromey.com>
2287
2288         * tui/tui-wingeneral.c (make_all_visible): Remove.
2289         (tui_make_all_invisible): Simplify.
2290         * tui/tui-layout.c (tui_make_all_invisible): Move from
2291         tui-wingeneral.c; simplify.
2292         (show_layout): Hoist call to tui_make_all_invisible.
2293         (show_data): Don't call tui_make_all_invisible.
2294
2295 2019-08-13  Tom Tromey  <tom@tromey.com>
2296
2297         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2298         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2299
2300 2019-08-13  Tom Tromey  <tom@tromey.com>
2301
2302         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2303         tui-data.c.
2304         (show_source_disasm_command, show_data)
2305         (show_source_or_disasm_and_command): Don't use
2306         tui_set_current_layout_to.
2307         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2308         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2309         tui-layout.c.
2310         (tui_set_current_layout_to): Remove.
2311
2312 2019-08-13  Tom Tromey  <tom@tromey.com>
2313
2314         * tui/tui-layout.c (tui_set_layout): Update.
2315         * tui/tui-data.h (struct tui_layout_def): Remove.
2316         (tui_layout_def): Don't declare.
2317         * tui/tui-data.c (layout_def): Remove.
2318         (tui_layout_def): Remove.
2319
2320 2019-08-13  Tom Tromey  <tom@tromey.com>
2321
2322         * tui/tui-winsource.h (struct tui_source_window_base)
2323         <clear_detail>: No longer "override".
2324         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2325         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2326         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2327         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2328         Remove.
2329         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2330
2331 2019-08-13  Tom Tromey  <tromey@adacore.com>
2332
2333         * tracepoint.c: Don't include readline.h or history.h.
2334
2335 2019-08-12  Tom Tromey  <tom@tromey.com>
2336
2337         * configure: Rebuild.
2338         * configure.ac: Check for readline 7.
2339         * NEWS: Mention readline 7 requirement.
2340         * README: Update.
2341
2342 2019-08-12  Tom Tromey  <tom@tromey.com>
2343
2344         * mingw-hdep.c (gdb_select): Remove readline hack.
2345
2346 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2347
2348         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2349         when the function fails.
2350
2351 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2352
2353         * s390-tdep.c (s390_type_align): New function.
2354         (s390_gdbarch_init): Set it as type_align gdbarch method.
2355
2356 2019-08-09  Tom de Vries  <tdevries@suse.de>
2357
2358         PR gdb/24591
2359         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2360         pc_low with relocation offset.
2361
2362 2019-08-07  Tom Tromey  <tromey@adacore.com>
2363
2364         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2365         (print_frame_args): Update.
2366         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2367         Update.
2368         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2369         * frame.h (struct frame_arg): Add initializers.
2370         <error>: Now a unique_xmalloc_ptr.
2371
2372 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2373
2374         * NEWS: Expand the Pointer Authentication entry.
2375         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2376         (aarch64_frame_unmask_lr): ... to this.
2377         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2378         Call aarch64_frame_unmask_lr.
2379         * frame.c (struct frame_info): Add "masked" variable.
2380         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2381         (fprint_frame): Check for masked pc.
2382         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2383         declarations.
2384         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2385         * stack.c (print_frame): Check for masked pc.
2386
2387 2019-08-06  Tom Tromey  <tom@tromey.com>
2388
2389         * stabsread.c (patch_block_stabs, read_one_struct_field)
2390         (read_enum_type): Use obstack_strndup.
2391         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2392         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2393         * dwarf2read.c (guess_full_die_structure_name)
2394         (anonymous_struct_prefix): Use obstack_strndup.
2395         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2396         * c-exp.y (yylex): Use obstack_strndup.
2397         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2398         (write_var_or_type): Use obstack_strndup.
2399
2400 2019-08-06  Tom Tromey  <tom@tromey.com>
2401
2402         * symfile.c (reread_symbols): Use obstack_strdup.
2403         * stabsread.c (read_type): Use obstack_strdup.
2404         * gdb_obstack.h (obstack_strdup): New overload.
2405         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2406         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2407         (dwarf2_canonicalize_name): Use obstack_strdup.
2408         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2409         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2410         Use obstack_strdup.
2411
2412 2019-08-06  Tom Tromey  <tom@tromey.com>
2413
2414         * gdb_obstack.h (obstack_strdup): Define.
2415         * gdb_obstack.c (obstack_strdup): Don't define.
2416
2417 2019-08-06  Tom Tromey  <tom@tromey.com>
2418
2419         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2420         obstack_strdup.
2421         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2422         obstack_strdup.
2423         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2424         * stabsread.c (common_block_start): Use obstack_strdup.
2425         * objfiles.c (set_objfile_main_name, objfile): Use
2426         obstack_strdup.
2427         * namespace.c (add_using_directive): Use obstack_strdup.
2428         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2429         * jit.c (finalize_symtab): Use obstack_strdup.
2430         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2431         (guess_partial_die_structure_name, partial_die_info::fixup)
2432         (dwarf2_name): Use obstack_strdup.
2433         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2434         obstack_strdup.
2435         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2436         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2437         obstack_strdup.
2438         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2439
2440 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2441
2442         * unittests/help-doc-selftests.c: New file.
2443         * Makefile.in: Add the new file.
2444
2445 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2446
2447         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2448         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2449         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2450         the trailing '.' is not output, and the first character is uppercased.
2451         (print_help_for_command): Update call to print_doc_line.
2452         (print_doc_of_command): Likewise.
2453         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2454         * cli/cli-option.c (append_indented_doc): Do not append newline.
2455         (build_help_option): Append newline after first appended_indented_doc
2456         only if a second call is done.
2457         (build_help): Append 2 new lines before each option, except the first
2458         one.
2459         * compile/compile.c (_initialize_compile): Add new lines after
2460         %OPTIONS%, when not at the end of the help.
2461         Change help doc or code
2462         producing the help doc to respect the invariants.
2463         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2464         Also removed the new line after 'Options:', as all other commands
2465         do not put an empty line between 'Options:' and the first option.
2466         * printcmd.c (_initialize_printcmd): Likewise.
2467         * stack.c (_initialize_stack): Likewise.
2468         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2469         incorrectly telling COMMAND is optional.
2470         * ada-lang.c (_initialize_ada_language): Change help doc or code
2471         producing the help doc to respect the invariants.
2472         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2473         * breakpoint.c (_initialize_breakpoint): Likewise.
2474         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2475         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2476         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2477         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2478         _initialize_cli_style): Likewise.
2479         * corelow.c (core_target_info): Likewise.
2480         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2481         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2482         * filesystem.c (_initialize_filesystem): Likewise.
2483         * frame.c (_initialize_frame): Likewise.
2484         * gnu-nat.c (add_task_commands): Likewise.
2485         * infcall.c (_initialize_infcall): Likewise.
2486         * infcmd.c (_initialize_infcmd): Likewise.
2487         * interps.c (_initialize_interpreter): Likewise.
2488         * language.c (_initialize_language): Likewise.
2489         * linux-fork.c (_initialize_linux_fork): Likewise.
2490         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2491         * maint.c (_initialize_maint_cmds): Likewise.
2492         * memattr.c (_initialize_mem): Likewise.
2493         * printcmd.c (_initialize_printcmd): Likewise.
2494         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2495         _RegEx): Likewise.
2496         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2497         * record-btrace.c (_initialize_record_btrace): Likewise.
2498         * record-full.c (_initialize_record_full): Likewise.
2499         * record.c (_initialize_record): Likewise.
2500         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2501         * regcache.c (_initialize_regcache): Likewise.
2502         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2503         _initialize_remote): Likewise.
2504         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2505         * serial.c (_initialize_serial): Likewise.
2506         * skip.c (_initialize_step_skip): Likewise.
2507         * source.c (_initialize_source): Likewise.
2508         * stack.c (_initialize_stack): Likewise.
2509         * symfile.c (_initialize_symfile): Likewise.
2510         * symtab.c (_initialize_symtab): Likewise.
2511         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2512         * top.c (init_main): Likewise.
2513         * tracefile-tfile.c (tfile_target_info): Likewise.
2514         * tracepoint.c (_initialize_tracepoint): Likewise.
2515         * tui/tui-win.c (_initialize_tui_win): Likewise.
2516         * utils.c (add_internal_problem_command): Likewise.
2517         * valprint.c (value_print_option_defs): Likewise.
2518
2519 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2520
2521         PR build/24886
2522         * configure.ac: Drop enable-libmcheck support.
2523         * configure, config.in: Rebuild.
2524         * libmcheck.m4: Remove.
2525         * acinclude.m4: Don't include it.
2526         * Makefile.in: Don't distribute it.
2527         * top.c (print_gdb_configuration): Don't mention it.
2528
2529 2019-08-06  Tom Tromey  <tom@tromey.com>
2530
2531         * utils.c (set_output_style): Sometimes pass stream to
2532         emit_style_escape.
2533         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2534         * record-btrace.c (btrace_insn_history): Update.
2535         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2536         method.
2537         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2538         Update initializers.
2539         <m_uiout>: New field.
2540         <m_di>: Move lower.
2541         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2542         Remove "uiout" parameter.
2543         (dump_insns): Update.
2544         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2545         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2546
2547 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2548
2549         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2550         (error_in_psymtab_expansion): Likewise.
2551         (lookup_symbol_via_quick_fns): Likewise.
2552         (basic_lookup_transparent_type_quick): Likewise.
2553         (basic_lookup_transparent_type_1): Likewise.
2554
2555 2019-08-06  Tom Tromey  <tromey@adacore.com>
2556
2557         * source.c (last_source_error): Now bool.
2558         (print_source_lines_base): Make "noprint" bool.  Only open
2559         source file when last_source_visited changes.
2560
2561 2019-08-06  Tom Tromey  <tromey@adacore.com>
2562
2563         * annotate.c (annotate_source_line): Use g_source_cache.
2564         * source-cache.c (source_cache::get_plain_source_lines): Change
2565         parameters.  Populate m_offset_cache.
2566         (source_cache::ensure): New method.
2567         (source_cache::get_line_charpos): New method.
2568         (extract_lines): Move lower.  Change parameters.
2569         (source_cache::get_source_lines): Move lower.
2570         * source-cache.h (class source_cache): Update comment.
2571         <get_line_charpos>: New method.
2572         <get_source_lines>: Update comment.
2573         <clear>: Clear m_offset_cache.
2574         <get_plain_source_lines>: Change parameters.
2575         <ensure>: New method
2576         <m_offset_cache>: New member.
2577         * source.c (forget_cached_source_info_for_objfile): Update.
2578         (info_source_command): Use g_source_cache.
2579         (find_source_lines, open_source_file_with_line_charpos): Remove.
2580         (print_source_lines_base, search_command_helper): Use g_source_cache.
2581         * source.h (open_source_file_with_line_charpos): Don't declare.
2582         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2583         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2584         Use g_source_cache.
2585
2586 2019-08-06  Tom Tromey  <tromey@adacore.com>
2587
2588         * source-cache.c (source_cache::get_plain_source_lines):
2589         Remove "first_line" and "last_line" parameters.
2590         (source_cache::get_source_lines): Cache plain text.
2591         * source-cache.h (class source_cache)
2592         <get_plain_source_lines>: Update.
2593
2594 2019-08-06  Tom Tromey  <tromey@adacore.com>
2595
2596         * source-cache.c (extract_lines): No longer a method.
2597         Changed type of parameter.  Include final newline.
2598         (selftests::extract_lines_test): New function.
2599         (_initialize_source_cache): Likewise.
2600         * source-cache.h (class source_cache)
2601         <extract_lines>: Don't declare.
2602
2603 2019-08-06  Tom Tromey  <tromey@adacore.com>
2604
2605         * breakpoint.c (init_breakpoint_sal): Update.
2606         (breakpoint): Update.
2607         * breakpoint.h (struct breakpoint) <filter>: Now a
2608         unique_xmalloc_ptr.
2609
2610 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2611
2612         * NEWS: Mention dictionary access on blocks.
2613         * python/py-block.c (blpy_getitem): New function.
2614         (block_object_as_mapping): New struct.
2615         (block_object_type): Use new struct for tp_as_mapping field.
2616
2617 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2618
2619         * objfiles.h (objfile): Add a comment describing partial symbols.
2620
2621 2019-08-05  Tom Tromey  <tromey@adacore.com>
2622
2623         * compile/compile.c (_initialize_compile): Use _(), not N_().
2624         * thread.c (_initialize_thread): Use _(), not N_().
2625         * stack.c (_initialize_stack): Use _(), not N_().
2626         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2627
2628 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2629
2630         * dwarf2read.c (struct dw2_symtab_iterator):
2631         <want_specific_block>: Remove.
2632         <block_index>: Change type to gdb::optional.
2633         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2634         change type of BLOCK_INDEX parameter to gdb::optional.
2635         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2636         (dw2_lookup_symbol): Don't pass argument for
2637         WANT_SPECIFIC_BLOCK.
2638         (dw2_expand_symtabs_for_function): Don't pass argument for
2639         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2640         (class dw2_debug_names_iterator)
2641         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2642         parameter, change BLOCK_INDEX type to gdb::optional.
2643         <m_want_specific_block>: Remove.
2644         <m_block_index>: Change type to gdb::optional.
2645         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2646         gdb::optional.  Re-write in function of gdb::optional.
2647         (dw2_debug_names_lookup_symbol): Don't pass argument for
2648         WANT_SPECIFIC_BLOCK.
2649         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2650         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2651         BLOCK_INDEX.
2652
2653 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2654
2655         * NEWS: Mention changes to "info sources" command.
2656
2657 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2658
2659         * symtab.c (filename_partial_match_opts): New struct type.
2660         (struct output_source_filename_data): New members
2661         regexp, c_regexp, partial_match.
2662         (output_source_filename): Use new members to decide to print file.
2663         (info_sources_option_defs): New variable.
2664         (make_info_sources_options_def_group, print_info_sources_header,
2665         info_sources_command_completer):
2666         New functions.
2667         (info_sources_command): Read new optional arguments.
2668         (_initialize_symtab): Update info sources help.
2669
2670 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2671
2672         * ada-lang.c (exception_support_info_v0): Renamed from...
2673         (default_exception_support_info): ... this.  Create new
2674         definition for v1.
2675         (ada_has_this_exception_support): Look up catch_handlers_sym.
2676         (ada_exception_support_info_sniffer): Try v0 after default.
2677
2678 2019-08-01  Tom Tromey  <tromey@adacore.com>
2679
2680         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2681         gdbarch.h.
2682
2683 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2684
2685         * s12z-tdep.c: Fix include path for s12z-opc.h.
2686
2687 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2688
2689         * NEWS: Require GNU make 3.82.
2690
2691 2019-07-16  Tom Tromey  <tom@tromey.com>
2692
2693         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2694         declare.
2695
2696 2019-07-30  Tom Tromey  <tromey@adacore.com>
2697
2698         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2699
2700 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2701
2702         * printcmd.c (print_address_symbolic): Print negative offsets.
2703         (build_address_symbolic): Force signed arithmetic when computing
2704         offset.
2705
2706 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2707
2708         PR/24474: Add a function to lookup static variables.
2709         * NEWS: Mention this new function.
2710         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2711         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2712         * python/python.c (python_GdbMethods): Add new function.
2713
2714 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2715
2716         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2717         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2718         (objfpy_lookup_static_symbol): New function.
2719         (objfile_object_methods): Add new functions.
2720
2721 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2722
2723         * NEWS: Mention 'set|show print frame-info'.  Mention new
2724         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2725         backtrace argument.  Mention that python frame filtering code
2726         is now consistent with what 'backtrace' command prints.
2727
2728 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2729
2730         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2731         comments.
2732         (print_frame_info_auto, print_frame_info_source_line,
2733         print_frame_info_location, print_frame_info_source_and_location,
2734         print_frame_info_location_and_address, print_frame_info_short_location):
2735         New declarations.
2736         (struct frame_print_options): New member print_frame_info.
2737         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2738         * stack.h (get_user_print_what_frame_info): New declaration.
2739         (frame_show_address): New declaration.
2740         * stack.c (print_frame_arguments_choices): New value 'presence'.
2741         (print_frame_info_auto, print_frame_info_source_line,
2742         print_frame_info_location, print_frame_info_source_and_location,
2743         print_frame_info_location_and_address, print_frame_info_short_location,
2744         print_frame_info_choices, print_frame_info_print_what): New definitions.
2745         (print_frame_args): Only print dots for args if print frame-arguments
2746         is 'presence'.
2747         (frame_print_option_defs): New element for "frame-info".
2748         (get_user_print_what_frame_info): New function.
2749         (frame_show_address): Make non static.  Move comment to stack.h.
2750         (print_frame_info_to_print_what): New function.
2751         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2752         to decide what to print.
2753         (backtrace_command_1): Handle the new print_frame_arguments_presence
2754         value.
2755         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2756         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2757         (py_print_frame): In non-mi mode, use LOCATION as default for
2758         print_what, similarly to frame information printed directly by
2759         backtrace command. Handle frame-info user option in non MI mode.
2760
2761 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2762
2763         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2764         Add case for debugging 32-bit target on 64-bit host.  Revise
2765         comment.
2766
2767 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2768
2769         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2770         instead of find_function_entry_range_from_pc.
2771
2772 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2773
2774         * stack.c (find_frame_funname): Remove code which preferred
2775         minsym over symtab sym in "certain pathological cases".
2776
2777         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2778         parameter.  Change type of "do_demangle" to bool.
2779         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2780         Pass suitable "prefer_sym_over_minsym" flag to
2781         build_address_symbolic().  Don't output "+" for negative offsets.
2782         * printcmd.c (print_address_symbolic): Update invocation of
2783         build_address_symbolic to include a "prefer_sym_over_minsym"
2784         flag.
2785         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2786         Restrict cases in which use of minimal symbol is preferred to that
2787         of a found symbol.  Update comments.
2788
2789         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2790         for entry pc when entry pc is out of range for that FDE.
2791
2792 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2793
2794         PR gdb/24839:
2795         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2796         type.
2797
2798 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2799
2800         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2801         this function's Python signature.
2802
2803
2804 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2805
2806         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2807         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2808         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2809         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2810         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2811
2812
2813 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2814
2815         * h8300-tdep.c (h8300_register_name_common): New.
2816         h8300_register_name): Use h8300_register_name_common.
2817         (h8300s_register_name): Likewise.
2818         (h8300sx_register_name): Likewise.
2819         (h8300h_register_nam): New.
2820         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2821
2822
2823 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2824
2825         * arm-tdep.c (arm_skip_cmse_entry): New function.
2826         (arm_is_sgstubs_section): New function.
2827         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2828
2829 2019-07-22  Tom Tromey  <tom@tromey.com>
2830
2831         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2832         Don't self-assign.
2833
2834 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2835
2836         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2837         type_print.
2838
2839 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2842         so that GDB doesn't match any msymbols when searching in the
2843         TYPES_DOMAIN.
2844         (print_symbol_info): Print using typedef_print or type_print based
2845         on the type of the symbol.  Add updated FIXME comment moved from...
2846         (_initialize_symtab): ... move and update FIXME comment to above.
2847
2848 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2849
2850         * NEWS: Mention adding -q option to "info types".
2851         * symtab.c (struct info_types_options): New struct.
2852         (info_types_options_defs): New variable.
2853         (make_info_types_options_def_group): New function.
2854         (info_types_command): Use gdb::option framework to parse options.
2855         (info_types_command_completer): New function.
2856         (_initialize_symtab): Extend the help text on "info types" and
2857         register command completer.
2858
2859 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2860
2861         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2862         (lookup_symbol_in_objfile): Change int to block_enum and add a
2863         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2864
2865 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2866
2867         * MAINTAINERS (Write After Approval): Add self.
2868
2869 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2870
2871         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2872         instruction to the dummy code region.
2873
2874 2019-07-19  Tom Tromey  <tromey@adacore.com>
2875
2876         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2877         (ARGSUSED, PARAMS, __func__): Remove rules.
2878
2879 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2880
2881         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2882         * features/arm/arm-with-iwmmxt.c: Remove.
2883         * features/arm/arm-with-iwmmxt.xml: Remove.
2884         * features/arm/arm-with-m-fpa-layout.c: Remove.
2885         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2886         * features/arm/arm-with-m-vfp-d16.c: Remove.
2887         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2888         * features/arm/arm-with-m.c: Remove.
2889         * features/arm/arm-with-m.xml: Remove.
2890         * features/arm/arm-with-neon.c: Remove.
2891         * features/arm/arm-with-neon.xml: Remove.
2892         * features/arm/arm-with-vfpv2.c: Remove.
2893         * features/arm/arm-with-vfpv2.xml: Remove.
2894         * features/arm/arm-with-vfpv3.c: Remove.
2895         * features/arm/arm-with-vfpv3.xml: Remove.
2896
2897 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2898
2899         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2900
2901 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2902
2903         * arch/aarch32.c (aarch32_create_target_description): Create
2904         target descriptions using features.
2905         * arch/arm.c (arm_create_target_description)
2906         (arm_create_mprofile_target_description): Likewise.
2907         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2908
2909 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2910
2911         * Makefile.in: Add new files.
2912         * aarch32-tdep.c: New file.
2913         * aarch32-tdep.h: New file.
2914         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2915         Call aarch32_read_description.
2916         * arch/aarch32.c: New file.
2917         * arch/aarch32.h: New file.
2918         * arch/arm.c (arm_create_target_description)
2919         (arm_create_mprofile_target_description): New function.
2920         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2921         (arm_create_target_description)
2922         (arm_create_mprofile_target_description): New declaration.
2923         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2924         read_description functions.
2925         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2926         Likewise.
2927         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2928         * arm-tdep.c (tdesc_arm_list): New variable.
2929         (arm_register_g_packet_guesses): Call create description functions.
2930         (arm_read_description) (arm_read_mprofile_description): New
2931         function.
2932         * arm-tdep.h (arm_read_description)
2933         (arm_read_mprofile_description): Add declaration.
2934         * configure.tgt: Add new files.
2935
2936 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2937
2938         * top.c (new_ui_command): Open specified terminal just once.
2939
2940 2019-07-18  Tom Tromey  <tromey@adacore.com>
2941
2942         * symtab.c (main_name): Constify return type.
2943         * symfile.c (set_initial_language): Update.
2944         * symtab.h (main_name): Constify return type.
2945
2946 2019-07-17  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui-winsource.c (tui_update_source_window)
2949         (tui_update_source_window_as_is)
2950         (tui_update_source_windows_with_line): Remove return.
2951         * tui/tui-disasm.c (tui_show_disassem)
2952         (tui_show_disassem_and_update_source): Remove return.
2953         * tui/tui.c (tui_reset): Remove return.
2954         * tui/tui-wingeneral.c
2955         (tui_check_and_display_highlight_if_needed): Remove return.
2956
2957 2019-07-17  Tom Tromey  <tom@tromey.com>
2958
2959         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2960
2961 2019-07-17  Tom Tromey  <tom@tromey.com>
2962
2963         * tui/tui-winsource.h (struct tui_exec_info_window)
2964         (struct tui_source_window_base): Move from tui-data.h.
2965         * tui/tui-winsource.c: Move many method definitions from
2966         elsewhere.  Remove "structuring" comments.
2967         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2968         (tui_source_window_base::refresh_window): Move to
2969         tui-winsource.c.
2970         * tui/tui-win.c (tui_source_window_base::refresh_all)
2971         (tui_source_window_base::update_tab_width)
2972         (tui_source_window_base::set_new_height)
2973         (tui_source_window_base::do_make_visible_with_new_height): Move to
2974         tui-winsource.c.
2975         * tui/tui-source.h: Update.
2976         * tui/tui-source.c (tui_source_window_base::reset): Move to
2977         tui-winsource.c.
2978         * tui/tui-disasm.h: Update.
2979         * tui/tui-data.h (struct tui_exec_info_window): Move to
2980         tui-winsource.h.
2981         (struct tui_source_window_base): Likewise.
2982         * tui/tui-data.c (tui_source_window_base::clear_detail)
2983         (tui_source_window_base, ~tui_source_window_base): Move to
2984         tui-winsource.c.
2985
2986 2019-07-17  Tom Tromey  <tom@tromey.com>
2987
2988         * tui/tui-win.c (tui_resize_all)
2989         (tui_source_window_base::update_tab_width)
2990         (tui_adjust_win_heights): Update.
2991         (tui_win_info::make_invisible_and_set_new_height): Rename from
2992         make_invisible_and_set_new_height.
2993         * tui/tui-data.h (struct tui_win_info)
2994         <make_invisible_and_set_new_height>: New method.
2995
2996 2019-07-17  Tom Tromey  <tom@tromey.com>
2997
2998         * tui/tui.c: Update.
2999         * tui/tui-source.h (struct tui_source_window): Move from
3000         tui-data.h.
3001         * tui/tui-layout.c: Update.
3002         * tui/tui-disasm.c: Update.
3003         * tui/tui-data.h (struct tui_source_window): Move to
3004         tui-source.h.
3005
3006 2019-07-17  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3009         tui-data.h.
3010         * tui/tui-data.h (struct tui_disasm_window): Move to
3011         tui-disasm.h.
3012
3013 2019-07-17  Tom Tromey  <tom@tromey.com>
3014
3015         * tui/tui-regs.h (struct tui_data_item_window): Move from
3016         tui-data.h.
3017         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3018         * tui/tui-data.h (struct tui_data_item_window): Move to
3019         tui-regs.h.
3020         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3021
3022 2019-07-17  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui.c: Update.
3025         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3026         (tui_cmd_window::max_height): Move to tui-command.c.
3027         * tui/tui-layout.c: Update.
3028         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3029         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3030         tui-command.c.
3031         * tui/tui-command.h (struct tui_cmd_window): Move from
3032         tui-data.h.
3033         * tui/tui-command.c: Remove "structuring" comments.
3034         (tui_cmd_window::clear_detail)
3035         (tui_cmd_window::do_make_visible_with_new_height)
3036         (tui_cmd_window::max_height): Move from elsewhere.
3037
3038 2019-07-17  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3041         Now static.
3042         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3043         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3044
3045 2019-07-17  Tom Tromey  <tom@tromey.com>
3046
3047         * tui/tui.c: Update.
3048         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3049         tui-regs.c.
3050         * tui/tui-windata.h: Remove file.
3051         * tui/tui-windata.c: Remove file.
3052         * tui/tui-win.c (tui_data_window::set_new_height)
3053         (tui_data_window::do_make_visible_with_new_height): Move to
3054         tui-regs.c.
3055         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3056         * tui/tui-regs.c: Remove "structuring" comments.
3057         (tui_data_window::first_data_item_displayed)
3058         (tui_data_window::delete_data_content_windows)
3059         (tui_data_window::erase_data_content)
3060         (tui_data_window::display_all_data)
3061         (tui_data_window::refresh_all)
3062         (tui_data_window::do_scroll_vertical)
3063         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3064         (tui_data_window::do_make_visible_with_new_height)
3065         (tui_data_window::refresh_window): Move from elsewhere.
3066         (_initialize_tui_regs): Move to end of file.
3067         * tui/tui-layout.c: Update.
3068         * tui/tui-hooks.c: Update.
3069         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3070         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3071         tui-regs.c.
3072         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3073
3074 2019-07-17  Tom Tromey  <tom@tromey.com>
3075
3076         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3077         seen.
3078
3079 2019-07-17  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui-win.c (tui_source_window_base::set_new_height)
3082         (tui_source_window_base::do_make_visible_with_new_height): Use
3083         m_has_locator field directly.
3084         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3085         method.
3086         (struct tui_source_window_base) <has_locator>: Likewise.
3087
3088 2019-07-17  Tom Tromey  <tom@tromey.com>
3089
3090         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3091         Don't declare.
3092         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3093         Remove.
3094         * tui/tui-win.c (tui_source_window_base::set_new_height)
3095         (tui_source_window_base::set_new_height)
3096         (make_invisible_and_set_new_height)
3097         (tui_source_window_base::do_make_visible_with_new_height)
3098         (tui_source_window_base::do_make_visible_with_new_height):
3099         Update.
3100         * tui/tui-layout.c (show_source_disasm_command, show_data)
3101         (show_source_or_disasm_and_command): Update.
3102         * tui/tui-layout.c (show_layout): Update.
3103
3104 2019-07-17  Tom Tromey  <tom@tromey.com>
3105
3106         * tui/tui-layout.c (make_data_window): Remove.
3107         (show_data): Unify creation and re-initialization cases.
3108
3109 2019-07-17  Tom Tromey  <tom@tromey.com>
3110
3111         * tui/tui-layout.c (make_source_window, make_disasm_window):
3112         Remove.
3113         (show_data): Unify creation and re-initialization cases.
3114
3115 2019-07-17  Tom Tromey  <tom@tromey.com>
3116
3117         * tui/tui-layout.c (make_command_window): Remove.
3118         (show_source_disasm_command, show_source_or_disasm_and_command):
3119         Unify creation and re-initialization cases.
3120
3121 2019-07-17  Tom Tromey  <tom@tromey.com>
3122
3123         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3124         creation and re-initialization cases.
3125
3126 2019-07-17  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui-regs.c (tui_get_register): Return void.
3129
3130 2019-07-17  Tom Tromey  <tom@tromey.com>
3131
3132         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3133         Simplify.
3134
3135 2019-07-17  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3138         resetting.
3139
3140 2019-07-17  Tom Tromey  <tom@tromey.com>
3141
3142         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3143         * tui/tui-regs.c (tui_reg_layout): New function.
3144         (tui_show_registers, tui_reg_command): Use it.
3145         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3146         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3147         parameters.
3148         (tui_layout_command): Remove.
3149
3150 2019-07-17  Tom Tromey  <tom@tromey.com>
3151
3152         * tui/tui-layout.h (tui/tui-layout): Return void.
3153         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3154
3155 2019-07-17  Tom Tromey  <tom@tromey.com>
3156
3157         * tui/tui-layout.c (show_source_disasm_command, show_data):
3158         Update.
3159         (reset_locator): Remove.
3160         (show_source_or_disasm_and_command): Update.
3161
3162 2019-07-17  Tom Tromey  <tom@tromey.com>
3163
3164         * tui/tui-source.c (tui_source_window_base::reset): Remove
3165         win_type parameter.
3166         * tui/tui-layout.c (make_command_window, make_source_window)
3167         (make_disasm_window, make_data_window)
3168         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3169         (reset_locator, show_source_or_disasm_and_command): Update.
3170         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3171         win_type parameter.
3172         (struct tui_source_window_base) <reset>: Likewise.
3173
3174 2019-07-17  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-layout.c (show_source_disasm_command): Use
3177         reset_locator.
3178         (reset_locator): New function.
3179         (init_and_make_win): Remove.
3180         (show_source_or_disasm_and_command): Use reset_locator.
3181
3182 2019-07-17  Tom Tromey  <tom@tromey.com>
3183
3184         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3185         condition.
3186         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3187         Remove condition.
3188         * tui/tui-source.c (tui_source_window_base::reset): New method.
3189         * tui/tui-layout.c (make_command_window): Don't call
3190         init_and_make_win.
3191         (make_source_window, make_disasm_window): Don't call
3192         make_source_or_disasm_window.
3193         (make_data_window): Don't call init_and_make_win.  Change calling
3194         convention.
3195         (show_source_disasm_command, show_data): Simplify.
3196         (make_source_or_disasm_window): Remove.
3197         (show_source_or_disasm_and_command): Simplify.
3198         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3199         (struct tui_source_window_base) <reset>: Likewise.
3200         <execution_info>: Remove initializer.
3201         * tui/tui-data.c (tui_source_window_base): Initialize
3202         execution_info.
3203
3204 2019-07-17  Tom Tromey  <tom@tromey.com>
3205
3206         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3207         variable.
3208
3209 2019-07-17  Tom Tromey  <tom@tromey.com>
3210
3211         * tui/tui.c (tui_rl_other_window): Update.
3212         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3213         superclass method first.  Always iterate over regs_content.
3214         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3215         method.
3216         * tui/tui-win.c (tui_set_focus_command): Update.
3217
3218 2019-07-17  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-win.c (tui_set_focus_command): Rename from
3221         tui_set_focus.  Call tui_enable.
3222         (tui_set_focus_command): Remove.
3223
3224 2019-07-17  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3227         refresh_window.
3228         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3229         touchwin.
3230         (tui_data_window::refresh_window): Call refresh_window on data
3231         items.  Always call superclass refresh_window.
3232         (tui_win_info::refresh): Remove.
3233         (tui_source_window_base::refresh_window): Update.
3234         (tui_refresh_all): Update.
3235         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3236         refresh_window.
3237         (show_source_or_disasm_and_command): Likewise.
3238         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3239         (struct tui_source_window_base) <refresh>: Likewise.
3240
3241 2019-07-17  Tom Tromey  <tom@tromey.com>
3242
3243         * tui/tui-winsource.c (tui_clear_source_content)
3244         (tui_show_source_content): Update.
3245         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3246         whether content is empty.
3247         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3248         Remove.
3249
3250 2019-07-17  Tom Tromey  <tom@tromey.com>
3251
3252         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3253         window's contents.
3254         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3255         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3256
3257 2019-07-17  Tom Tromey  <tom@tromey.com>
3258
3259         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3260         (struct tui_data_item_window): Update.
3261
3262 2019-07-17  Tom Tromey  <tom@tromey.com>
3263
3264         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3265         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3266         defines.
3267
3268 2019-07-17  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-winsource.h (tui_erase_source_content)
3271         (tui_clear_source_content): Remove "display_prompt" parameter.
3272         * tui/tui-winsource.c (tui_update_source_window_as_is)
3273         (tui_update_source_windows_with_addr): Update.
3274         (tui_clear_source_content): Remove "display_prompt" parameter.
3275         (tui_erase_source_content): Likewise.  Simplify.
3276         (tui_show_source_content): Update.
3277         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3278         * tui/tui-stack.c (tui_show_frame_info): Update.
3279         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3280         Remove defines.
3281
3282 2019-07-17  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3285         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3286         parameter.
3287         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3288         parameter.
3289
3290 2019-07-17  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-winsource.c (tui_clear_source_content)
3293         (tui_show_source_content, tui_show_exec_info_content)
3294         (tui_clear_exec_info_content): Update.
3295         * tui/tui-stack.c (tui_show_locator_content): Update.
3296         (tui_show_frame_info): Update.
3297         * tui/tui-source.h (tui_source_window): Don't declare.
3298         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3299         from tui_source_is_displayed.
3300         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3301         Remove field.
3302         (struct tui_source_window_base) <content_in_use>: New field.  Now
3303         bool.
3304         (struct tui_source_window) <showing_source_p>: New method.
3305         (TUI_SRC_WIN): Change cast.
3306         * tui/tui-data.c (tui_initialize_static_data): Update.
3307
3308 2019-07-17  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3311         location_matches_p.
3312         * tui/tui-source.c (tui_source_window::location_matches_p): New
3313         method.
3314         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3315         method.
3316         * tui/tui-data.h (struct tui_source_window_base)
3317         <location_matches_p>: New method.
3318         (struct tui_source_window, struct tui_disasm_window)
3319         <location_matches_p>: Likewise.
3320
3321 2019-07-17  Tom Tromey  <tom@tromey.com>
3322
3323         * tui/tui-win.c (tui_set_win_height_command): Rename from
3324         tui_set_win_height.
3325         (tui_set_win_height_command): Remove.
3326
3327 2019-07-17  Tom Tromey  <tom@tromey.com>
3328
3329         * tui/tui-source.c (tui_source_window): New constructor.  Add
3330         observer.
3331         (~tui_source_window): New destructor.
3332         (tui_source_window::style_changed): New method.
3333         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3334         (tui_attach_detach_observers): Update.
3335         * tui/tui-data.h (struct tui_source_window): Make constructor not
3336         inline.  Add destructor.
3337         (struct tui_source_window) <style_changed>: New method.
3338         <m_observable>: New member.
3339
3340 2019-07-17  Tom Tromey  <tom@tromey.com>
3341
3342         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3343         * tui/tui-win.c (tui_resize_all): Fix typo.
3344
3345 2019-07-17  Tom Tromey  <tom@tromey.com>
3346
3347         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3348         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3349         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3350         * tui/tui-win.c (window_name_completer): Use foreach.
3351         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3352         (update_tab_width): Likewise.
3353         * tui/tui-layout.c (show_layout): Update.
3354         * tui/tui-data.h (class tui_window_iterator): New.
3355         (struct all_tui_windows): New.
3356         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3357
3358 2019-07-17  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3361         parameter.  Don't reference globals.
3362         (tui_reg_command): Update.
3363
3364 2019-07-17  Tom Tromey  <tom@tromey.com>
3365
3366         * tui/tui-regs.c (tui_show_registers): Simplify.
3367
3368 2019-07-17  Tom Tromey  <tom@tromey.com>
3369
3370         * tui/tui-regs.c (tui_show_registers): Update.
3371         (tui_show_register_group): Add win_info parameter.
3372
3373 2019-07-17  Tom Tromey  <tom@tromey.com>
3374
3375         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3376         Rename from tui_display_reg_element_at_line.
3377         (tui_data_window::display_registers_from_line): Update.
3378         * tui/tui-data.h (struct tui_data_window)
3379         <display_reg_element_at_line>: New method.
3380
3381 2019-07-17  Tom Tromey  <tom@tromey.com>
3382
3383         * tui/tui-regs.h (tui_display_registers_from)
3384         (tui_display_registers_from_line): Don't declare.
3385         * tui/tui-windata.c (tui_data_window::display_all_data)
3386         (tui_data_window::refresh_all)
3387         (tui_data_window::do_scroll_vertical): Update.
3388         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3389         from tui_display_registers_from.
3390         (tui_display_reg_element_at_line): Update.
3391         (tui_data_window::display_registers_from_line): Rename from
3392         tui_display_registers_from_line.
3393         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3394         display_registers_from_line>: New methods.
3395
3396 2019-07-17  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3399         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3400         from tui_erase_data_content.
3401         (tui_data_window::display_all_data)
3402         (tui_data_window::refresh_all)
3403         (tui_data_window::do_scroll_vertical): Update.
3404         * tui/tui-regs.c (tui_show_registers): Update.
3405         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3406         New method.
3407
3408 2019-07-17  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3411         declare.
3412         * tui/tui-windata.c
3413         (tui_data_window::delete_data_content_windows): Rename from
3414         tui_delete_data_content_windows.
3415         (tui_data_window::display_all_data)
3416         (tui_data_window::do_scroll_vertical): Update.
3417         * tui/tui-data.h (struct tui_data_window)
3418         <delete_data_content_windows>: New method.
3419
3420 2019-07-17  Tom Tromey  <tom@tromey.com>
3421
3422         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3423         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3424
3425 2019-07-17  Tom Tromey  <tom@tromey.com>
3426
3427         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3428         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3429         from tui_display_all_data.
3430         * tui/tui-win.c
3431         (tui_data_window::do_make_visible_with_new_height): Update.
3432         * tui/tui-regs.c (tui_show_registers): Update.
3433         * tui/tui-layout.c (tui_set_layout): Update.
3434         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3435         method.
3436
3437 2019-07-17  Tom Tromey  <tom@tromey.com>
3438
3439         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3440         * tui/tui-windata.c (tui_display_data_from): Remove.
3441         (tui_data_window::refresh_all): Update.
3442
3443 2019-07-17  Tom Tromey  <tom@tromey.com>
3444
3445         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3446         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3447         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3448         tui_display_registers_from_line.
3449         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3450         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3451         "force_display" parameter.
3452
3453 2019-07-17  Tom Tromey  <tom@tromey.com>
3454
3455         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3456         declare.
3457         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3458         Rename from tui_first_reg_element_no_inline.
3459         (tui_display_reg_element_at_line)
3460         (tui_display_registers_from_line): Update.
3461         * tui/tui-data.h (struct tui_data_window)
3462         <first_reg_element_no_inline>: New method.
3463
3464 2019-07-17  Tom Tromey  <tom@tromey.com>
3465
3466         * tui/tui-windata.c (tui_display_data_from)
3467         (tui_data_window::do_scroll_vertical): Update.
3468         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3469         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3470         Rename from tui_line_from_reg_element_no.
3471         (tui_display_registers_from_line): Update.
3472         * tui/tui-data.h (struct tui_data_window)
3473         <line_from_reg_element_no>: New method.
3474
3475 2019-07-17  Tom Tromey  <tom@tromey.com>
3476
3477         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3478         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3479         tui_last_regs_line_no.
3480         (tui_display_reg_element_at_line)
3481         (tui_display_registers_from_line): Update.
3482         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3483         method.
3484
3485 2019-07-17  Tom Tromey  <tom@tromey.com>
3486
3487         PR tui/24722:
3488         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3489         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3490         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3491         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3492         (tui_update_breakpoint_info): Likewise.
3493         * tui/tui-hooks.c (tui_event_create_breakpoint)
3494         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3495         Update.
3496
3497 2019-07-17  Tom Tromey  <tom@tromey.com>
3498
3499         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3500
3501 2019-07-17  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui-winsource.c (tui_update_source_window_as_is)
3504         (tui_update_source_windows_with_addr): Update.
3505         * tui/tui-source.h (tui_set_source_content)
3506         (tui_show_symtab_source): Add "win_info" parameter.
3507         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3508         parameter.
3509         (tui_show_symtab_source): Likewise.
3510
3511 2019-07-17  Tom Tromey  <tom@tromey.com>
3512
3513         * tui/tui-wingeneral.c
3514         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3515
3516 2019-07-17  Tom Tromey  <tom@tromey.com>
3517
3518         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3519         (struct tui_cmd_window) <can_scroll>: New method.
3520         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3521         method.
3522
3523 2019-07-17  Tom Tromey  <tromey@adacore.com>
3524
3525         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3526         do_field_signed>: Rename.  Change type of "value".
3527         * ui-out.c (ui_out::field_signed): Rename from field_int.
3528         Change type of "value".
3529         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3530         type of "value".
3531         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3532         do_field_int.  Change type of "value".
3533         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3534         do_field_int.  Change type of "value".
3535         * tracepoint.c (trace_status_mi, tfind_1)
3536         (print_one_static_tracepoint_marker): Update.
3537         * thread.c (print_thread_info_1, print_selected_thread_frame):
3538         Update.
3539         * stack.c (print_frame, print_frame_info): Update.
3540         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3541         Update.
3542         * source.c (print_source_lines_base): Update.
3543         * skip.c (info_skip_command): Update.
3544         * record-btrace.c (btrace_ui_out_decode_error)
3545         (btrace_call_history_src_line): Update.
3546         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3547         Update.
3548         * progspace.c (print_program_space): Update.
3549         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3550         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3551         do_field_int.  Change type of "value".
3552         * mi/mi-out.c (mi_ui_out::do_table_begin)
3553         (mi_ui_out::do_table_header): Update.
3554         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3555         type of "value".
3556         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3557         (mi_cmd_data_list_changed_registers, output_register)
3558         (mi_cmd_data_read_memory, mi_load_progress)
3559         (mi_cmd_trace_frame_collected): Update.
3560         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3561         Update.
3562         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3563         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3564         (mi_cmd_var_list_children, varobj_update_one): Update.
3565         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3566         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3567         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3568         * inferior.c (print_inferior): Update.
3569         * gdb_bfd.c (print_one_bfd): Update.
3570         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3571         Update.
3572         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3573         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3574         do_field_int.  Change type of "value".
3575         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3576         do_field_int.  Change type of "value".
3577         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3578         (print_one_breakpoint_location, print_it_catch_fork)
3579         (print_one_catch_fork, print_it_catch_vfork)
3580         (print_one_catch_vfork, print_it_catch_solib)
3581         (print_it_catch_exec, print_it_ranged_breakpoint)
3582         (print_mention_watchpoint, print_mention_masked_watchpoint)
3583         (bkpt_print_it, update_static_tracepoint): Update.
3584         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3585         * break-catch-syscall.c (print_it_catch_syscall): Update.
3586         * ada-tasks.c (print_ada_task_info): Update.
3587         * ada-lang.c (print_it_exception, print_mention_exception):
3588         Update.
3589
3590 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3591
3592         PR breakpoints/24541
3593         * gdbarch.c: Regenerate.
3594         * gdbarch.h: Regenerate.
3595         * gdbarch.sh: Adjust return type and parameter types for
3596         'stap_adjust_register'.
3597         (i386_stap_adjust_register): Adjust signature and return new
3598         register name.
3599         * stap-probe.c (stap_parse_register_operand): Adjust use of
3600         'gdbarch_stap_adjust_register'.
3601
3602 2019-07-17  Tom Tromey  <tromey@adacore.com>
3603
3604         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3605         declare VEC.
3606         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3607         std::vector.
3608         (struct s390_process_info): Add initializers.
3609         (s390_add_process): Use new.
3610         (s390_linux_nat_target::low_forget_process): Use delete.
3611         (s390_linux_nat_target::low_new_fork)
3612         (s390_linux_nat_target::stopped_by_watchpoint)
3613         (s390_linux_nat_target::low_prepare_to_resume)
3614         (s390_linux_nat_target::insert_watchpoint)
3615         (s390_linux_nat_target::insert_hw_breakpoint)
3616         (s390_linux_nat_target::remove_watchpoint)
3617         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3618
3619 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3620
3621         * aarch64-fbsd-nat.c: Include regcache.h.
3622         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3623         argument.
3624         (aarch64_fbsd_nat_target::fetch_registers)
3625         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3626         variable.
3627         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3628
3629 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3630
3631         * fbsd-nat.c: Include gdbarch.h.
3632
3633 2019-07-15  Tom Tromey  <tromey@adacore.com>
3634
3635         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3636
3637 2019-07-15  Tom Tromey  <tromey@adacore.com>
3638
3639         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3640         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3641         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3642         * cli-out.c (cli_ui_out::do_field_int): New method.
3643         * ui-out.c (ui_out::field_unsigned): New method.
3644         * symfile.c (generic_load): Use field_unsigned.
3645         (print_transfer_performance): Likewise.
3646         * record-btrace.c (ui_out_field_uint): Remove.
3647         (btrace_call_history_insn_range, btrace_call_history): Use
3648         field_unsigned.
3649         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3650         field_unsigned.
3651         * ui-out.h (class ui_out) <field_unsigned>: New method.
3652         <do_field_unsigned>: Likewise.
3653
3654 2019-07-15  Tom Tromey  <tromey@adacore.com>
3655
3656         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3657         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3658         * target.c (flash_erase_command): Use field_string.
3659         * infrun.c (print_signal_received_reason): Use field_string.
3660         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3661         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3662         field_string.
3663         * ada-tasks.c (print_ada_task_info): Use field_string.
3664
3665 2019-07-15  Tom Tromey  <tromey@adacore.com>
3666
3667         * target.c (flash_erase_command): Use field_core_addr.
3668         * symfile.c (generic_load): Use field_core_addr.
3669         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3670         Use field_core_addr.
3671         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3672         field_core_addr.
3673
3674 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3677         value if its desired type is smaller than a CORE_ADDR and signed.
3678
3679 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3680
3681         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3682         of changes to field names, and use new is_reference field to
3683         decide if a property is a reference or not.
3684         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3685         field.
3686         (struct dwarf2_property_baton): Update header comment, rename
3687         'referenced_type' to 'property_type' and update comments.
3688         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3689         default property type, store in property baton, update to take
3690         accound of renamed field.
3691         (read_func_scope): Update call to attr_to_dynamic_prop.
3692         (read_array_type): Likewise.
3693         (dwarf2_per_cu_addr_sized_int_type): New function.
3694         (read_subrange_index_type): Move type finding code to
3695         dwarf2_per_cu_addr_sized_int_type.
3696         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3697         (dwarf2_per_cu_addr_type): New function.
3698         (set_die_type): Update calls to attr_to_dynamic_prop.
3699
3700 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3701
3702         * dwarf2read.c (read_subrange_index_type): New function.
3703         (read_subrange_type): Move code into new function and call it.
3704         * gdbtypes.c (create_range_type): Add some asserts.
3705
3706 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3709         update return statements.
3710         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3711         declaration, and update comment to match.
3712         * gdbtypes.c (resolve_dynamic_array): Update call to
3713         dwarf2_evaluate_property to match new return type.
3714
3715 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3716
3717         * valarith.c (value_subscripted_rvalue): Change lowerbound
3718         parameter type from int to LONGEST.
3719         * value.h (value_subscripted_rvalue): Likewise in declaration.
3720
3721 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3722
3723         * cli/cli-utils.c (info_print_command_completer): New function.
3724         * cli/cli-utils.h: Add 'completer.h' include, and forward
3725         declaration for 'struct cmd_list_element'.
3726         (info_print_command_completer): Declare.
3727         * stack.c (_initialize_stack): Add completer for 'info locals' and
3728         'info args'.
3729         * symtab.c (_initialize_symtab): Add completer for 'info
3730         variables' and 'info functions'.
3731         * NEWS: Mention completion for additional info commands.
3732
3733 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * cli/cli-utils.c (extract_info_print_args): Delete.
3736         (extract_arg_maybe_quoted): Delete.
3737         (info_print_options_defs): New variable.
3738         (make_info_print_options_def_group): New function.
3739         (extract_info_print_options): Define new function.
3740         * cli/cli-utils.h (extract_info_print_args): Delete.
3741         (struct info_print_options): New structure.
3742         (extract_info_print_options): Declare new function.
3743         * stack.c (info_locals_command): Update to use new
3744         extract_info_print_options, also add a header comment.
3745         (info_args_command): Likewise.
3746         * symtab.c (info_variables_command): Likewise.
3747         (info_functions_command): Likewise.
3748
3749 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3752         to extract string arguments.
3753         * common/common-utils.c (extract_string_maybe_quoted): New function.
3754         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3755
3756 2019-07-11  Tom Tromey  <tromey@adacore.com>
3757
3758         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3759         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3760         * top.h (gdbinit): Don't declare.
3761         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3762         into...
3763         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3764         * top.c (gdb_init): Don't call init_cli_cmds.
3765         (gdbinit): Remove.
3766         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3767
3768 2019-07-11  Tom Tromey  <tromey@adacore.com>
3769
3770         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3771         after it has been moved.
3772
3773 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3774
3775         * valops.c (value_must_coerce_to_target): Change return type to
3776         bool.
3777         * value.h (value_must_coerce_to_target): Likewise.
3778
3779 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3780
3781         * breakpoint.c (is_hardware_watchpoint): Remove
3782         forward-declaration.
3783         (is_masked_watchpoint): Change return type to bool.
3784         (is_tracepoint): Likewise.
3785         (is_breakpoint): Likewise.
3786         (is_hardware_watchpoint): Likewise.
3787         (is_watchpoint): Likewise.
3788         (is_no_memory_software_watchpoint): Likewise.
3789         (is_catchpoint): Likewise.
3790         (breakpoint_1): Make FILTER parameter's return type bool.
3791         is_masked_watchpoint): Change return type to bool.
3792         (save_breakpoints): Make FILTER parameter's return type bool.
3793         * breakpoint.h (is_breakpoint): Change return type to bool.
3794         (is_watchpoint): Likewise.
3795         (is_catchpoint): Likewise.
3796         (is_tracepoint): Likewise.
3797
3798 2019-07-10  Tom Tromey  <tom@tromey.com>
3799
3800         * defs.h: Don't include gdbarch.h.
3801         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3802         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3803         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3804         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3805         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3806         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3807         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3808         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3809         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3810         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3811         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3812         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3813         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3814         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3815         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3816         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3817         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3818         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3819         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3820         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3821         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3822         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3823         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3824         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3825         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3826         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3827         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3828
3829 2019-07-10  Tom Tromey  <tromey@adacore.com>
3830
3831         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3832         * breakpoint.c (init_ada_exception_breakpoint): Register as
3833         bp_catchpoint.
3834         (print_one_breakpoint_location, print_one_breakpoint): Use
3835         is_ada_exception_catchpoint.
3836         * ada-lang.c (class ada_catchpoint_location): Pass
3837         bp_loc_software_breakpoint to bp_location constructor.
3838         (is_ada_exception_catchpoint): New function.
3839
3840 2019-07-10  Tom Tromey  <tromey@adacore.com>
3841
3842         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3843         VEC.
3844         (struct arm_exidx_entry): New method operator<.
3845         (struct arm_exidx_data) <section_maps>: Change type.
3846         (arm_exidx_data_free): Remove.
3847         (arm_exidx_data_key): Change type.  Move lower.
3848         (arm_exidx_new_objfile): Update.
3849         (arm_compare_exidx_entries): Remove.
3850         (arm_find_exidx_entry, _initialize_arm_tdep)
3851
3852 2019-07-10  Tom Tromey  <tromey@adacore.com>
3853
3854         * solib-spu.c (ocl_program_data_key): Change type.
3855         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3856         Update.
3857
3858 2019-07-10  Tom Tromey  <tromey@adacore.com>
3859
3860         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3861         (struct solib_aix_inferior_data) <library_list>: Change type.
3862         (solib_aix_inferior_data_handle): Change type.
3863         (get_solib_aix_inferior_data): Update.
3864         (solib_aix_free_library_list): Remove.
3865         (library_list_start_library): Update.
3866         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3867         return type.
3868         (solib_aix_get_library_list)
3869         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3870         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3871
3872 2019-07-10  Tom Tromey  <tromey@adacore.com>
3873
3874         * solib-dsbt.c (struct dsbt_info): Add initializers.
3875         (solib_dsbt_pspace_data): Change type.
3876         (dsbt_pspace_data_cleanup): Remove.
3877         (get_dsbt_info, _initialize_dsbt_solib): Update.
3878
3879 2019-07-10  Tom Tromey  <tromey@adacore.com>
3880
3881         * spu-tdep.c (spu_overlay_data): Change type.
3882         (spu_get_overlay_table, spu_overlay_new_objfile)
3883         (_initialize_spu_tdep): Update.
3884
3885 2019-07-10  Tom Tromey  <tromey@adacore.com>
3886
3887         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3888         destructor.
3889         (dbx_objfile_data_key): Change type and declare later.
3890         (DBX_SYMFILE_INFO): Rewrite.
3891         * dbxread.c (dbx_objfile_data_key): Change type.
3892         (dbx_symfile_init): Update.
3893         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3894         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3895         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3896
3897 2019-07-10  Tom Tromey  <tromey@adacore.com>
3898
3899         * jit.c (jit_program_space_key): Change type.  Move lower.
3900         (get_jit_program_space_data): Update.
3901         (jit_program_space_data_cleanup): Remove.
3902         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3903         Update.
3904         (struct jit_program_space_data): Add initializers.
3905
3906 2019-07-10  Tom Tromey  <tromey@adacore.com>
3907
3908         * solib-darwin.c (struct darwin_info): Add initializers.
3909         (solib_darwin_pspace_data): Change type.
3910         (darwin_pspace_data_cleanup): Remove.
3911         (get_darwin_info, _initialize_darwin_solib): Update.
3912
3913 2019-07-10  Tom Tromey  <tromey@adacore.com>
3914
3915         * remote-sim.c (struct sim_inferior_data): Add initializers,
3916         constructor, and destructor.
3917         (sim_inferior_data_key): Change type.  Move lower.
3918         (check_for_duplicate_sim_descriptor): Update.
3919         (get_sim_inferior_data): Use new.  Update.
3920         (~sim_inferior_data_cleanup): Rename from
3921         sim_inferior_data_cleanup.  Simplify.
3922         (gdbsim_close_inferior, simulator_command)
3923         (sim_command_completer, _initialize_remote_sim): Update.
3924         (next_pid, INITIAL_PID): Move earlier.
3925
3926 2019-07-10  Tom Tromey  <tromey@adacore.com>
3927
3928         * python/python-internal.h (create_thread_object): Return
3929         gdbpy_ref.
3930         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3931         * python/py-inferior.c (struct threadlist_entry): Add
3932         constructor.
3933         <thread_obj>: Now a gdbpy_ref.
3934         (thread_to_thread_object): Update.
3935         (add_thread_object): Use new.
3936         (delete_thread_object): Use delete.
3937         (infpy_threads): Update.
3938         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3939         GIL.
3940
3941 2019-07-10  Tom Tromey  <tromey@adacore.com>
3942
3943         * valops.c (value_cast): Specialize error message for Ada.
3944
3945 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3946
3947         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3948
3949 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3950
3951         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3952         bpstat_should_step): Return bool, adjust comments.
3953         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3954         bpstat_should_step): Likewise.
3955
3956 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3957
3958         * features/Makefile: Use feature target descriptions for Arm.
3959         * features/arm/arm-core.c: Generate new file.
3960         * features/arm/arm-fpa.c: Likewise.
3961         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3962         * features/arm/arm-m-profile.c: Likewise.
3963         * features/arm/arm-vfpv2.c: Likewise.
3964         * features/arm/arm-vfpv3.c: Likewise.
3965         * features/arm/xscale-iwmmxt.c: Likewise.
3966         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3967
3968 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3969
3970         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3971         ptrace earlier.
3972
3973 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3974
3975         * features/aarch64-pauth.c: Regenerate.
3976
3977 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3978
3979         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3980         bool.
3981         (bpstat_what): Use false instead of 0.
3982
3983 2019-07-09  Pedro Alves  <palves@redhat.com>
3984
3985         * break-catch-throw.c (is_exception_catchpoint): New.
3986         * breakpoint.c (print_one_breakpoint_location): New parameter
3987         'raw_loc'.  Handle it.  Use
3988         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3989         looking at the breakpoint's type.
3990         (print_one_breakpoint): If handling "maint info breakpoints", also
3991         print locations of exception catchpoints.
3992         * breakpoint.h (is_exception_catchpoint): Declare.
3993
3994 2019-07-09  Pedro Alves  <palves@redhat.com>
3995
3996         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3997         "addr" field.
3998         (allocate_location_exception_catchpoint): New.
3999         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4000         (initialize_throw_catchpoint_ops): Install
4001         allocate_location_exception_catchpoint as allocate_location
4002         method.
4003         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4004         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4005         bp_loc_other.
4006         (breakpoint_address_is_meaningful): Delete.
4007         (bl_address_is_meaningful): New.
4008         (breakpoint_locations_match): Adjust comment.
4009         (bp_location_from_bp_type): New, factored out of...
4010         (bp_location::bp_location(breakpoint *)): ... this.
4011         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4012         factored out of...
4013         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4014         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4015         breakpoint_address_is_meaningful.
4016         (bp_locations_compare): Adjust comment.
4017         (update_global_location_list): Use bl_address_is_meaningful
4018         instead of breakpoint_address_is_meaningful.
4019         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4020         explicit.
4021         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4022         * python/py-breakpoint.c (bppy_get_location): No longer check
4023         whether location is null.
4024
4025 2019-07-09  Pedro Alves  <palves@redhat.com>
4026
4027         PR c++/15468
4028         * breakpoint.c (print_one_breakpoint_location): Remove
4029         single-location assert.
4030
4031 2019-07-09  Tom Tromey  <tom@tromey.com>
4032
4033         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4034         * configure: Rebuild.
4035         * configure.ac: Change common to gdbsupport.
4036         * gdbsupport: Rename from common.
4037         * acinclude.m4: Change common to gdbsupport.
4038         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4039         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4040         gdbsupport.
4041         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4042         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4043         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4044         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4045         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4046         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4047         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4048         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4049         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4050         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4051         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4052         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4053         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4054         coff-pe-read.c, command.h, compile/compile-c-support.c,
4055         compile/compile-c.h, compile/compile-cplus-symbols.c,
4056         compile/compile-cplus-types.c, compile/compile-cplus.h,
4057         compile/compile-loc2c.c, compile/compile.c, completer.c,
4058         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4059         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4060         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4061         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4062         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4063         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4064         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4065         features/aarch64-core.c, features/aarch64-fpu.c,
4066         features/aarch64-pauth.c, features/aarch64-sve.c,
4067         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4068         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4069         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4070         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4071         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4072         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4073         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4074         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4075         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4076         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4077         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4078         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4079         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4080         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4081         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4082         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4083         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4084         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4085         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4086         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4087         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4088         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4089         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4090         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4091         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4092         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4093         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4094         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4095         minsyms.c, mips-linux-tdep.c, namespace.h,
4096         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4097         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4098         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4099         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4100         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4101         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4102         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4103         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4104         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4105         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4106         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4107         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4108         procfs.c, producer.c, progspace.h, psymtab.h,
4109         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4110         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4111         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4112         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4113         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4114         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4115         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4116         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4117         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4118         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4119         target-memory.c, target.c, target.h, target/waitstatus.c,
4120         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4121         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4122         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4123         unittests/array-view-selftests.c,
4124         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4125         unittests/common-utils-selftests.c,
4126         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4127         unittests/format_pieces-selftests.c,
4128         unittests/function-view-selftests.c,
4129         unittests/lookup_name_info-selftests.c,
4130         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4131         unittests/mkdir-recursive-selftests.c,
4132         unittests/observable-selftests.c,
4133         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4134         unittests/parse-connection-spec-selftests.c,
4135         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4136         unittests/scoped_fd-selftests.c,
4137         unittests/scoped_mmap-selftests.c,
4138         unittests/scoped_restore-selftests.c,
4139         unittests/string_view-selftests.c, unittests/style-selftests.c,
4140         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4141         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4142         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4143         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4144         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4145         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4146
4147 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4148
4149         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4150         bool value.
4151         (decode_digits_ordinary): Set explicit_line field in sal.
4152         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4153         symtab_and_line that was set on an explicit line number in
4154         assembler code.  Do always update the recorded symtab and line if
4155         we do skip the prologue.
4156
4157 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4158
4159         * breakpoint.c (set_breakpoint_location_function): Remove
4160         explicit_loc parameter.
4161         (momentary_breakpoint_from_master): Update call to
4162         set_breakpoint_location_function.
4163         (add_location_to_breakpoint): Likewise.
4164
4165 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4166
4167         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4168         required features based on default bfd type when no specific bfd
4169         is present.
4170
4171 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4172
4173         * NEWS: Mention that GDB printf and eval commands can now print
4174         C-style and Ada-style convenience var strings without
4175         calling the inferior.
4176         * printcmd.c (printf_c_string): Locally print GDB internal var
4177         instead of transiting via the inferior.
4178         (printf_wide_c_string): Likewise.
4179
4180 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4181
4182         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4183
4184 2019-07-04  Tom Tromey  <tom@tromey.com>
4185
4186         PR tui/24724:
4187         * tui/tui-winsource.c (tui_clear_source_content): Update.
4188         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4189         (tui_update_breakpoint_info): Update.
4190         (tui_set_exec_info_content): Update.
4191         * tui/tui-source.c (tui_set_source_content_nil): Update.
4192         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4193         has_break.
4194         * tui/tui-data.h (enum tui_bp_flag): New.
4195         (tui_bp_flags): New enum flags type.
4196         (struct tui_source_element) <break_mode>: Change type.  Rename
4197         from has_break.
4198         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4199         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4200         constants.
4201         * tui/tui-winsource.h: Fix comment.
4202
4203 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4204
4205         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4206         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4207         (store_fpregs_to_thread)
4208         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4209         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4210         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4211         (IWMMXT_REGS_SIZE): Add define.
4212         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4213         (fetch_vfp_regs, store_vfp_regs)
4214         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4215         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4216
4217 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4218
4219         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4220         defines.
4221         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4222         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4223         (ARM_INT_REGISTER_SIZE): ...to this.
4224         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4225         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4226         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4227         (arm_linux_collect_gregset, supply_nwfpe_register)
4228         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4229         defines.
4230         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4231         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4232         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4233         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4234         (arm_return_in_memory, arm_store_return_value)
4235         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4236         (arm_record_ld_st_multiple): Likewise.
4237         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4238         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4239
4240 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4241
4242         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4243         AARCH64_DISPLACED_MODIFIED_INSNS.
4244         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4245         (aarch64_displaced_step_copy_insn): Likewise.
4246         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4247         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4248         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4249         ARM_DISPLACED_MODIFIED_INSNS.
4250         * arm-tdep.c (arm_gdbarch_init): Likewise.
4251         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4252         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4253         (struct arm_displaced_step_closure): Use
4254         ARM_DISPLACED_MODIFIED_INSNS.
4255
4256 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4257
4258         * features/Makefile: Remove unused xml files.
4259         * features/aarch64.xml: Remove.
4260         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4261         * features/i386/amd64-avx-avx512.xml: Remove.
4262         * features/i386/amd64-avx-linux.xml: Remove.
4263         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4264         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4265         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4266         * features/i386/amd64-avx-mpx.xml: Remove.
4267         * features/i386/amd64-avx.xml: Remove.
4268         * features/i386/amd64-linux.xml: Remove.
4269         * features/i386/amd64-mpx-linux.xml: Remove.
4270         * features/i386/amd64-mpx.xml: Remove.
4271         * features/i386/amd64.xml: Remove.
4272         * features/i386/i386-avx-avx512-linux.xml: Remove.
4273         * features/i386/i386-avx-avx512.xml: Remove.
4274         * features/i386/i386-avx-linux.xml: Remove.
4275         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4276         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4277         * features/i386/i386-avx-mpx-linux.xml: Remove.
4278         * features/i386/i386-avx-mpx.xml: Remove.
4279         * features/i386/i386-avx.xml: Remove.
4280         * features/i386/i386-linux.xml: Remove.
4281         * features/i386/i386-mmx-linux.xml: Remove.
4282         * features/i386/i386-mmx.xml: Remove.
4283         * features/i386/i386-mpx-linux.xml: Remove.
4284         * features/i386/i386-mpx.xml: Remove.
4285         * features/i386/i386.xml: Remove.
4286         * features/i386/x32-avx-avx512-linux.xml: Remove.
4287         * features/i386/x32-avx-linux.xml: Remove.
4288         * features/i386/x32-linux.xml: Remove.
4289
4290 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4291
4292         * regformats/aarch64.dat: Remove.
4293         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4294         * regformats/i386/amd64-avx-linux.dat: Remove.
4295         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4296         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4297         * regformats/i386/amd64-linux.dat: Remove.
4298         * regformats/i386/amd64-mpx-linux.dat: Remove.
4299         * regformats/i386/amd64.dat: Remove.
4300         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4301         * regformats/i386/i386-avx-linux.dat: Remove.
4302         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4303         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4304         * regformats/i386/i386-linux.dat: Remove.
4305         * regformats/i386/i386-mmx-linux.dat: Remove.
4306         * regformats/i386/i386-mpx-linux.dat: Remove.
4307         * regformats/i386/i386.dat: Remove.
4308         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4309         * regformats/i386/x32-avx-linux.dat: Remove.
4310         * regformats/i386/x32-linux.dat: Remove.
4311
4312 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4313
4314         * aarch64-tdep.c: Remove xml self tests.
4315         * amd64-linux-tdep.c: Likewise.
4316         * amd64-tdep.c: Likewise.
4317         * i386-linux-tdep.c: Likewise.
4318         * i386-tdep.c: Likewise.
4319
4320 2019-07-03  Pedro Alves  <palves@redhat.com>
4321
4322         PR cli/24732
4323         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4324         (pipe_cmd_option_defs): New.
4325         (make_pipe_cmd_options_def_group): New.
4326         (pipe_command): Use gdb::option::process_options.
4327         (pipe_command_completer): New function.
4328         (_initialize_cli_cmds): Install completer for "pipe" command.
4329
4330 2019-07-03  Pedro Alves  <palves@redhat.com>
4331
4332         * cli/cli-option.c (union option_value) <string>: New field.
4333         (struct option_def_and_value): Add ctor, move ctor, dtor and
4334         use DISABLE_COPY_AND_ASSIGN.
4335         (option_def_and_value::clear_value): New.
4336         (parse_option, save_option_value_in_ctx, get_val_type_str)
4337         (add_setshow_cmds_for_options): Handle var_string.
4338         * cli-option.h (union option_def::var_address) <string>: New
4339         field.
4340         (struct string_option_def): New.
4341         * maint-test-options.c (struct test_options_opts): Add default
4342         ctor and use DISABLE_COPY_AND_ASSIGN.
4343         <string_opt>: New field.
4344         (test_options_opts::~test_options_opts): New.
4345         (test_options_opts::dump): Also dump "-string".
4346         (test_options_option_defs): Install "string.
4347
4348 2019-07-03  Pedro Alves  <palves@redhat.com>
4349
4350         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4351         option_value with a null enumeration.
4352         (complete_options): Save the option values in the context.
4353         (save_option_value_in_ctx): New, factored out from ...
4354         (process_options): ... here.
4355         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4356         of the function.
4357         * maint-test-options.c (test_options_opts::dump): New, factored
4358         out from ...
4359         (maintenance_test_options_command_mode): ... here.
4360         (maintenance_test_options_command_completion_result): Delete.
4361         (maintenance_test_options_command_completion_text): Update
4362         comment.
4363         (maintenance_show_test_options_completion_result): Change
4364         prototype.  Just print
4365         maintenance_test_options_command_completion_text.
4366         (save_completion_result): New.
4367         (maintenance_test_options_completer_mode): Pass options context to
4368         complete_options, and then save a dump.
4369         (_initialize_maint_test_options): Use add_cmd to install "maint
4370         show test-options-completion-result".
4371
4372 2019-07-03  Pedro Alves  <palves@redhat.com>
4373
4374         * NEWS (New commands): Mention "with" and "maint with".
4375         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4376         (with_command, with_command_completer): New.
4377         (pipe_command): Adjust to new repeat_previous
4378         interface.
4379         (_initialize_cli_cmds): Install the "with" command and its "w"
4380         alias.
4381         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4382         declarations.
4383         * cli/cli-setshow.c (parse_cli_var_uinteger)
4384         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4385         argument strings for all var_types.
4386         (get_setshow_command_value_string): New, factored out from ...
4387         (do_show_command): ... this.
4388         * cli/cli-setshow.h: Include <string>.
4389         (get_setshow_command_value_string): Declare.
4390         * command.h (repeat_previous): Now returns const char *.  Adjust
4391         comment.
4392         * maint.c: Include "cli/cli-cmds.h".
4393         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4394         (_initialize_maint_cmds): Register the "maintenance with" command.
4395         * top.c (repeat_previous): Move bits from pipe_command here:
4396         Return the saved command line, if any; error out if there's no
4397         command to relaunch.
4398
4399 2019-07-03  Pedro Alves  <palves@redhat.com>
4400
4401         * NEWS (New commands): Mention "maint set/show test-settings"
4402         instead of "maint test-settings".
4403         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4404         (maintenance_test_settings_set_list): Rename to ...
4405         (maintenance_set_test_settings_list): ... this.
4406         (maintenance_test_settings_show_list): Rename to  ...
4407         (maintenance_show_test_settings_list): ... this.
4408         (maintenance_test_settings_cmd): Delete.
4409         (maintenance_test_settings_set_cmd): ...
4410         (maintenance_set_test_settings_cmd): ... this.
4411         (maintenance_test_settings_show_cmd): ...
4412         (maintenance_show_test_settings_cmd): ... this.
4413         (maintenance_test_settings_show_value_cmd):
4414         (maintenance_show_test_settings_value_cmd): ... this.
4415         (_initialize_maint_test_settings): No longer install the "maint
4416         test-settings" prefix command.  Rename "maint test-settings set"
4417         to "maint set test-settings", and "maint test-settings show" to
4418         "maint show test-settings".  Adjust all subcommands.
4419
4420 2019-07-03  Pedro Alves  <palves@redhat.com>
4421
4422         * maint-test-settings.c: Fix file's intro comment.  Replace all
4423         references to "test-options" with references to "test-settings",
4424         in comments.
4425
4426 2019-07-03  Pedro Alves  <palves@redhat.com>
4427
4428         * maint-test-settings.c (maintenance_test_settings_xxx)
4429         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4430         New.
4431         (maintenance_test_settings_enums): Use them.
4432         (maintenance_test_settings_enum): Default to
4433         maintenance_test_settings_xxx.
4434         (_initialize_maint_test_settings): Initialize
4435         MAINTENANCE_TEST_SETTINGS_FILENAME.
4436
4437 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4438
4439         * breakpoint.h (remove_breakpoints_inf): Change return type to
4440         void, move function documentation here.
4441         * breakpoint.c (remove_breakpoints_inf): Change return type to
4442         void, move function documentation to header.
4443
4444 2019-07-02  Pedro Alves  <palves@redhat.com>
4445
4446         * NEWS (Completion improvements): Mention "info threads".
4447         * thread.c (struct info_threads_opts, info_threads_option_defs)
4448         (make_info_threads_options_def_group): New.
4449         (info_threads_command): Use gdb::option::process_options.
4450         (info_threads_command_completer): New.
4451         (_initialize_thread): Use gdb::option::build_help to build the
4452         help text for "info threads".
4453
4454 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4455
4456         * defs.h (generic_load): Move from here...
4457         * symfile.h (generic_load): ... to here.  Rename name parameter
4458         to args.
4459         * symfile.c (generic_load): Add comment.
4460
4461 2019-07-01  Tom Tromey  <tromey@adacore.com>
4462
4463         * dwarf2read.c
4464         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4465         declaration of without_params.  Fix formatting.
4466
4467 2019-07-01  Tom Tromey  <tromey@adacore.com>
4468
4469         * ada-exp.y (find_primitive_type): Update.
4470         * ada-lang.h (ada_lookup_symbol): Update.
4471         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4472         parameter.
4473         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4474
4475 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4476
4477         PR breakpoints/24541
4478         * gdbarch.c: Regenerate.
4479         * gdbarch.h: Regenerate.
4480         * gdbarch.sh: Add 'stap_adjust_register'.
4481         * i386-tdep.c: Include '<unordered_set>'.
4482         (i386_stap_adjust_register): New function.
4483         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4484         * stap-probe.c (stap_parse_register_operand): Call
4485         'gdbarch_stap_adjust_register'.
4486
4487 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4488
4489         PR python/24742
4490         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4491         * python/python.c (do_start_initialization): Use 'xmalloc'
4492         instead of 'PyMem_Malloc'.
4493
4494 2019-06-28  Tom Tromey  <tromey@adacore.com>
4495
4496         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4497         for Ada.
4498
4499 2019-06-27  Tom Tromey  <tromey@adacore.com>
4500
4501         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4502         objfile_key.
4503         (arm_find_mapping_symbol, arm_record_special_symbol)
4504         (_initialize_arm_tdep): Update.
4505         (arm_objfile_data_free): Remove.
4506
4507 2019-06-27  Tom Tromey  <tromey@adacore.com>
4508
4509         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4510         to cp_print_static_field.
4511
4512 2019-06-26  Tom Tromey  <tromey@adacore.com>
4513
4514         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4515         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4516         declare.
4517
4518 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4519
4520         * features/aarch64-core.c (create_feature_aarch64_core):
4521         Regenerate.
4522         * features/aarch64-core.xml: Add cpsr flags.
4523
4524 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4525
4526         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4527         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4528
4529 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4530
4531         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4532         field.
4533         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4534         use.
4535         (arm_record_special_symbol): Don't insert new symbol in sorted
4536         position, push it at the end.
4537
4538 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4539
4540         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4541         (arm_mapping_symbol_s): Remove.
4542         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4543         (arm_mapping_symbol_vec): New typedef.
4544         (struct arm_per_objfile): Add constructor.
4545         <section_maps>: Change type to
4546         std::unique_ptr<arm_mapping_symbol_vec[]>.
4547         (arm_compare_mapping_symbols): Remove.
4548         (arm_find_mapping_symbol): Adjust to section_maps type change.
4549         (arm_objfile_data_free): Call delete on arm_per_objfile.
4550         (arm_record_special_symbol): Adjust to section_maps type change.
4551         Allocate arm_per_objfile with new.
4552
4553 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4554
4555         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4556         with the command prefix.
4557
4558 2019-06-25  Tom Tromey  <tom@tromey.com>
4559
4560         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4561         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4562
4563 2019-06-25  Tom Tromey  <tom@tromey.com>
4564
4565         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4566         type.
4567         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4568         protected.
4569
4570 2019-06-25  Tom Tromey  <tom@tromey.com>
4571
4572         * tui/tui-winsource.c
4573         (tui_source_window_base::set_is_exec_point_at): Add check against
4574         LOA_ADDRESS.
4575
4576 2019-06-25  Tom Tromey  <tom@tromey.com>
4577
4578         * tui/tui-source.c (tui_set_source_content): Don't check before
4579         xfree.
4580         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4581
4582 2019-06-25  Tom Tromey  <tom@tromey.com>
4583
4584         * tui/tui-winsource.h (tui_update_source_window_as_is)
4585         (tui_alloc_source_buffer, tui_line_is_displayed)
4586         (tui_addr_is_displayed): Change type of win_info.
4587         * tui/tui-winsource.c (tui_update_source_window_as_is)
4588         (tui_clear_source_content, tui_show_source_line)
4589         (tui_show_source_content, tui_source_window_base::refill)
4590         (tui_source_window_base::set_is_exec_point_at)
4591         (tui_source_window_base::set_is_exec_point_at)
4592         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4593         (tui_alloc_source_buffer, tui_line_is_displayed)
4594         (tui_addr_is_displayed): Change type of win_info.  Update.
4595         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4596         (tui_source_window_base::do_make_visible_with_new_height):
4597         Update.
4598         * tui/tui-source.c (tui_set_source_content)
4599         (tui_set_source_content_nil)
4600         (tui_source_window::do_scroll_vertical): Update.
4601         * tui/tui-layout.c (show_layout): Update.
4602         * tui/tui-disasm.c (tui_set_disassem_content)
4603         (tui_disasm_window::do_scroll_vertical): Update.
4604         * tui/tui-data.h (tui_win_content): Remove.
4605         (struct tui_gen_win_info) <content, content_size>: Remove.
4606         (struct tui_source_element): Add initializers and destructor.
4607         (union tui_which_element, struct tui_win_element): Remove.
4608         (struct tui_source_window_base) <content>: New field.
4609         (struct tui_data_window): Remove destructor.
4610         (tui_alloc_content, tui_free_win_content)
4611         (tui_free_all_source_wins_content): Don't declare.
4612         * tui/tui-data.c (tui_initialize_static_data): Update.
4613         (init_content_element, tui_alloc_content): Remove.
4614         (~tui_gen_win_info): Update.
4615         (~tui_data_window, tui_free_all_source_wins_content)
4616         (tui_free_win_content, free_content, free_content_elements):
4617         Remove.
4618
4619 2019-06-25  Tom Tromey  <tom@tromey.com>
4620
4621         * tui/tui-winsource.h (tui_clear_source_content)
4622         (tui_erase_source_content, tui_show_source_content): Change type
4623         of win_info.
4624         * tui/tui-winsource.c (tui_clear_source_content)
4625         (tui_erase_source_content, tui_show_source_content): Change type
4626         of win_info.
4627         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4628         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4629         win_info.
4630         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4631         win_info.
4632         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4633
4634 2019-06-25  Tom Tromey  <tom@tromey.com>
4635
4636         * tui/tui-winsource.c (tui_clear_source_content)
4637         (tui_source_window_base::set_is_exec_point_at): Update.
4638         * tui/tui-source.c (tui_set_source_content_nil): Update.
4639         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4640         a bool.
4641         * tui/tui-data.c (init_content_element): Update.
4642
4643 2019-06-25  Tom Tromey  <tom@tromey.com>
4644
4645         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4646         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4647         * tui/tui-layout.c (init_and_make_win): Update.
4648         * tui/tui.h (enum tui_win_type): Update.
4649         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4650         tui_win_is_auxillary.
4651         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4652         tui_win_is_auxillary.
4653
4654 2019-06-25  Tom Tromey  <tom@tromey.com>
4655
4656         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4657         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4658         (tui_delete_data_content_windows, tui_display_all_data)
4659         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4660         Update.
4661         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4662         * tui/tui-regs.c (tui_last_regs_line_no)
4663         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4664         (tui_show_registers): Update.
4665         (tui_show_register_group): Return void.  Update.
4666         (tui_display_registers_from, tui_display_reg_element_at_line)
4667         (tui_display_registers_from_line, tui_check_register_values):
4668         Update.
4669         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4670         member.
4671         (struct tui_data_window) <regs_content>: Now a std::vector.
4672         <regs_content_count>: Remove.
4673         (tui_add_content_elements, tui_free_data_content): Don't declare.
4674         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4675         (init_content_element): Remove DATA_WIN case.  Add assert.
4676         (tui_add_content_elements): Remove.
4677         (tui_data_window): Update.
4678         (tui_free_data_content): Remove.
4679         (free_content_elements): Remove DATA_WIN case.
4680
4681 2019-06-25  Tom Tromey  <tom@tromey.com>
4682
4683         * tui/tui-data.c (tui_data_item_window): Update.
4684         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4685         * tui/tui-windata.c (tui_display_all_data)
4686         (tui_display_data_from_line): Update.
4687         (tui_check_data_values): Remove.
4688         * tui/tui-regs.c (tui_show_register_group)
4689         (tui_display_reg_element_at_line): Update.
4690         * tui/tui-hooks.c (tui_register_changed)
4691         (tui_refresh_frame_and_register_information): Call
4692         tui_check_register_values.
4693         * tui/tui-data.h (struct tui_data_window) <data_content,
4694         data_content_count, data_type>: Remove.
4695         (enum tui_data_type): Remove.
4696
4697         * tui/tui-data.c (tui_data_window::clear_detail)
4698         (~tui_data_window): Update.
4699
4700 2019-06-25  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4703         declare.
4704         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4705         Rename from tui_first_data_item_displayed.  Update.
4706         (tui_data_window::refresh_all)
4707         (tui_data_window::do_scroll_vertical): Update.
4708         * tui/tui-data.h (struct tui_data_window)
4709         <first_data_item_displayed>: Declare new method.
4710
4711 2019-06-25  Tom Tromey  <tom@tromey.com>
4712
4713         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4714         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4715         contents...
4716         (tui_initialize_static_data): ...here.
4717
4718 2019-06-25  Tom Tromey  <tom@tromey.com>
4719
4720         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4721         (tui_display_registers_from, tui_check_register_values): Update.
4722         (tui_display_register): Remove win_info parameter; update.
4723         (tui_get_register): Change type of parameters.
4724         * tui/tui-data.h (struct tui_data_element): Remove.
4725         (union tui_which_element) <data>: Remove.
4726         <data_window>: Change type.
4727         (struct tui_data_item_window): New.
4728         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4729         case.  Add assert.
4730         (~tui_data_item_window): New destructor.
4731         (free_content_elements): Remove DATA_ITEM_WIN case.
4732
4733 2019-06-25  Tom Tromey  <tom@tromey.com>
4734
4735         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4736         Remove.
4737
4738 2019-06-25  Tom Tromey  <tom@tromey.com>
4739
4740         * tui/tui-data.h (struct tui_command_element): Remove.
4741         (union tui_which_element) <command>: Remove.
4742         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4743         assert.
4744         (free_content_elements): Remove CMD_WIN case.
4745
4746 2019-06-25  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-layout.c (tui_set_layout): Update.
4749         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4750         * tui/tui-data.c (layout_def): Update.
4751
4752 2019-06-25  Tom Tromey  <tom@tromey.com>
4753
4754         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4755         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4756         (tui_source_window_base::set_new_height): Update.
4757         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4758         Update.
4759         (tui_set_locator_fullname, tui_set_locator_info)
4760         (tui_show_frame_info): Update.
4761         * tui/tui-source.c (tui_set_source_content)
4762         (tui_source_is_displayed): Update.
4763         * tui/tui-layout.c (show_source_disasm_command, show_data)
4764         (show_source_or_disasm_and_command): Update.
4765         * tui/tui-disasm.c (tui_set_disassem_content)
4766         (tui_get_begin_asm_address): Update.
4767         * tui/tui-data.h (struct tui_locator_element): Remove.
4768         (union tui_which_element) <locator>: Remove.
4769         (struct tui_locator_window): New.
4770         (tui_locator_win_info_ptr): Change return type.
4771         * tui/tui-data.c (_locator): Change type.
4772         (tui_locator_win_info_ptr): Change return type.
4773         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4774         (tui_alloc_content): Add assert.
4775
4776 2019-06-25  Tom Tromey  <tom@tromey.com>
4777
4778         * tui/tui-winsource.c
4779         (tui_exec_info_window::maybe_allocate_content): New method.
4780         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4781         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4782         (make_source_or_disasm_window): Add cast.
4783         * tui/tui-data.h (union tui_which_element) <simple_string>:
4784         Remove.
4785         (struct tui_source_info): New.
4786         (struct tui_source_window_base) <execution_info>: Change type.
4787         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4788         case, and add assert.
4789         (tui_alloc_content): Add assert.
4790
4791 2019-06-25  Tom Tromey  <tom@tromey.com>
4792
4793         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4794         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4795         * tui/tui-data.c (tui_alloc_win_info): Remove.
4796
4797 2019-06-25  Tom Tromey  <tom@tromey.com>
4798
4799         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4800         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4801         can_highlight.
4802
4803 2019-06-25  Tom Tromey  <tom@tromey.com>
4804
4805         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4806         make_visible_with_new_height method.
4807         (tui_win_info::make_visible_with_new_height): New method.
4808         (tui_source_window_base::do_make_visible_with_new_height)
4809         (tui_data_window::do_make_visible_with_new_height)
4810         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4811         (make_visible_with_new_height): Remove.
4812         (tui_resize_all, tui_adjust_win_heights): Use
4813         make_visible_with_new_height method.
4814         * tui/tui-data.h (struct tui_win_info)
4815         <do_make_visible_with_new_height, make_visible_with_new_height>:
4816         New methods.
4817         (struct tui_source_window_base, struct tui_data_window)
4818         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4819         methods.
4820
4821 2019-06-25  Tom Tromey  <tom@tromey.com>
4822
4823         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4824         method.
4825         (update_tab_width): Call update_tab_width method.
4826         * tui/tui-data.h (struct tui_win_info)
4827         (struct tui_source_window_base) <update_tab_width>: New methods.
4828
4829 2019-06-25  Tom Tromey  <tom@tromey.com>
4830
4831         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4832         parameter.
4833         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4834         parameter.
4835         (tui_gen_win_info::make_visible): Update.
4836         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4837         parameter.
4838         * tui/tui-data.h (enum tui_box): New enum.
4839         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4840
4841 2019-06-25  Tom Tromey  <tom@tromey.com>
4842
4843         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4844         init_and_make_win for EXEC_INFO_WIN.
4845         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4846         longer inline.
4847         (struct tui_win_info) <~tui_win_info>: Inline.
4848         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4849         Don't declare.
4850         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4851         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4852         Remove.
4853         (tui_initialize_static_data): Update.
4854         (~tui_gen_win_info): Handle more cleanup here.
4855         (~tui_source_window_base): Delete "execution_info".
4856         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4857
4858 2019-06-25  Tom Tromey  <tom@tromey.com>
4859
4860         * tui/tui-layout.c (make_command_window): Don't set
4861         can_highlight.
4862         (show_source_disasm_command): Call the reset method.
4863         (show_data): Don't set can_highlight.  Call the reset method.
4864         (tui_gen_win_info::reset): Rename from init_gen_win_info
4865         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4866         (show_source_or_disasm_and_command): Call the reset method.
4867         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4868         (struct tui_cmd_window): Set can_highlight.
4869
4870 2019-06-25  Tom Tromey  <tom@tromey.com>
4871
4872         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4873         from make_visible.
4874         (tui_make_visible, tui_make_invisible): Rewrite.
4875         (tui_win_info::make_visible): Remove.
4876         (tui_source_window_base::make_visible): Update.
4877         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4878         method.  Moved from...
4879         (struct tui_win_info) <make_visible>: ...here.
4880
4881 2019-06-25  Tom Tromey  <tom@tromey.com>
4882
4883         * tui/tui-winsource.c
4884         (tui_source_window_base::do_scroll_horizontal): Remove direction
4885         parameter.
4886         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4887         direction parameter.
4888         * tui/tui-win.c (tui_win_info::forward_scroll)
4889         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4890         (tui_win_info::right_scroll): Update.
4891         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4892         direction parameter.
4893         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4894         direction parameter.
4895         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4896         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4897         Remove direction parameter.
4898         (struct tui_source_window_base, struct tui_source_window)
4899         (struct tui_disasm_window, struct tui_data_window)
4900         (struct tui_cmd_window): Update.
4901
4902 2019-06-25  Tom Tromey  <tom@tromey.com>
4903
4904         * tui/tui-winsource.h (tui_set_exec_info_content)
4905         (tui_show_exec_info_content, tui_erase_exec_info_content)
4906         (tui_clear_exec_info_content, tui_update_exec_info): Change
4907         argument to tui_source_window_base.
4908         * tui/tui-winsource.c (tui_set_exec_info_content)
4909         (tui_show_exec_info_content, tui_erase_exec_info_content)
4910         (tui_clear_exec_info_content, tui_update_exec_info): Change
4911         argument to tui_source_window_base.
4912
4913 2019-06-25  Tom Tromey  <tom@tromey.com>
4914
4915         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4916         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4917
4918 2019-06-25  Tom Tromey  <tom@tromey.com>
4919
4920         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4921         check.
4922
4923 2019-06-25  Tom Tromey  <tom@tromey.com>
4924
4925         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4926         type to void.
4927         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4928         type to void.
4929         * tui/tui-source.c (tui_set_source_content): Update.
4930         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4931
4932 2019-06-25  Tom Tromey  <tom@tromey.com>
4933
4934         * tui/tui-win.c (window_name_completer, tui_set_focus)
4935         (tui_all_windows_info): Use name method.
4936         * tui/tui-data.h (struct tui_gen_win_info)
4937         (struct tui_source_window, struct tui_disasm_window)
4938         (struct tui_data_window, struct tui_cmd_window) <name>: New
4939         method.
4940         (tui_win_name): Don't declare.
4941         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4942         (tui_win_name): Remove.
4943
4944 2019-06-25  Tom Tromey  <tom@tromey.com>
4945
4946         * tui/tui-winsource.h (tui_update_source_window)
4947         (tui_update_source_window_as_is): Change parameter type.
4948         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4949         to be a tui_source_window_base.
4950         (tui_update_source_window_as_is): Likewise.
4951         * tui/tui-win.c (make_visible_with_new_height): Update.
4952
4953 2019-06-25  Tom Tromey  <tom@tromey.com>
4954
4955         * tui/tui-winsource.c (tui_erase_source_content)
4956         (tui_show_source_content, tui_show_exec_info_content)
4957         (tui_erase_exec_info_content): Use refresh_window method.
4958         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4959         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4960         from tui_refresh_win.
4961         (tui_data_window::refresh_window): New method.
4962         (tui_win_info::refresh, tui_source_window_base::refresh)
4963         (tui_refresh_all): Use refresh_window method.
4964         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4965         method.
4966         * tui/tui-regs.c (tui_display_register): Call refresh_window
4967         method.
4968         * tui/tui-layout.c (show_source_disasm_command)
4969         (show_source_or_disasm_and_command): Call refresh_window method.
4970         * tui/tui-data.h (struct tui_gen_win_info)
4971         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4972         New method.
4973
4974 2019-06-25  Tom Tromey  <tom@tromey.com>
4975
4976         * tui/tui.c (tui_rl_other_window, tui_enable)
4977         (tui_is_window_visible, tui_get_command_dimension): Update.
4978         * tui/tui-winsource.c (tui_update_source_window_as_is)
4979         (tui_clear_source_content, tui_erase_source_content)
4980         (tui_show_source_line, tui_source_window_base::refill)
4981         (tui_source_window_base::do_scroll_horizontal)
4982         (tui_source_window_base::set_is_exec_point_at)
4983         (tui_update_breakpoint_info, tui_set_exec_info_content)
4984         (tui_alloc_source_buffer, tui_line_is_displayed)
4985         (tui_addr_is_displayed): Update.
4986         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4987         (tui_check_and_display_highlight_if_needed)
4988         (tui_win_info::make_visible, tui_win_info::refresh)
4989         (tui_refresh_all): Update.
4990         * tui/tui-windata.c (tui_first_data_item_displayed)
4991         (tui_delete_data_content_windows, tui_erase_data_content)
4992         (tui_display_all_data, tui_data_window::refresh_all)
4993         (tui_check_data_values): Update.
4994         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4995         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4996         (tui_win_info::backward_scroll, tui_refresh_all_win)
4997         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4998         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4999         (tui_source_window_base::set_new_height)
5000         (tui_data_window::set_new_height)
5001         (make_invisible_and_set_new_height)
5002         (make_visible_with_new_height, new_height_ok)
5003         (parse_scrolling_args): Update.
5004         * tui/tui-stack.c (tui_show_frame_info): Update.
5005         * tui/tui-source.c (tui_set_source_content)
5006         (tui_set_source_content_nil, tui_source_is_displayed)
5007         (tui_source_window::do_scroll_vertical): Update.
5008         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5009         (tui_display_registers_from, tui_display_reg_element_at_line)
5010         (tui_check_register_values, tui_reg_command): Update.
5011         * tui/tui-layout.c (tui_default_win_height)
5012         (show_source_disasm_command, show_data, init_and_make_win)
5013         (show_source_or_disasm_and_command): Update.
5014         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5015         (tui_redisplay_readline, tui_mld_flush)
5016         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5017         (tui_getc): Update.
5018         * tui/tui-disasm.c (tui_set_disassem_content)
5019         (tui_disasm_window::do_scroll_vertical): Update.
5020         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5021         Now virtual.
5022         (struct tui_win_info): Derive from tui_gen_win_info.
5023         <~tui_win_info>: Mark as override.
5024         <generic>: Remove member.
5025         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5026         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5027         (~tui_data_window, ~tui_win_info)
5028         (tui_free_all_source_wins_content): Update.
5029         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5030
5031 2019-06-25  Tom Tromey  <tom@tromey.com>
5032
5033         * tui/tui-layout.c (init_and_make_win): Use new.
5034         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5035         destructor, initializers.
5036         (tui_alloc_generic_win_info): Don't declare.
5037         * tui/tui-data.c (_locator): Add argument to constructor.
5038         (source_win, disasm_win): New globals.
5039         (exec_info): Remove.
5040         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5041         Update.
5042         (tui_alloc_generic_win_info): Remove.
5043         (init_content_element): Use new.
5044         (tui_win_info::tui_win_info): Update.
5045         (free_content_elements) <case DATA_WIN>: Use delete.
5046
5047 2019-06-25  Tom Tromey  <tom@tromey.com>
5048
5049         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5050         * tui/tui-windata.c (tui_first_data_item_displayed)
5051         (tui_delete_data_content_windows): Update.
5052         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5053         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5054         (tui_display_registers_from, tui_check_register_values): Update.
5055         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5056         pointer.
5057         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5058         window.
5059         (tui_free_data_content): Update.
5060         (free_content_elements) <case DATA_WIN>: Free the window.
5061
5062 2019-06-25  Tom Tromey  <tom@tromey.com>
5063
5064         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5065         Update.
5066         * tui/tui-layout.c (make_command_window)
5067         (show_source_disasm_command, show_data, init_and_make_win)
5068         (show_source_or_disasm_and_command): Update.
5069         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5070         method.
5071         <can_highight, is_highlighted>: Now bool.
5072         (tui_set_win_highlight): Don't declare.
5073         * tui/tui-data.c (tui_set_win_highlight): Remove.
5074
5075 2019-06-25  Tom Tromey  <tom@tromey.com>
5076
5077         * tui/tui-wingeneral.c (make_visible): Remove check of window
5078         type.
5079
5080 2019-06-25  Tom Tromey  <tom@tromey.com>
5081
5082         * tui/tui-win.c (tui_win_info::max_height)
5083         (tui_cmd_window::max_height): New methods.
5084         (new_height_ok): Call max_height.
5085         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5086         <max_height>: New method.
5087
5088 2019-06-25  Tom Tromey  <tom@tromey.com>
5089
5090         * tui/tui-win.c (tui_source_window_base::set_new_height)
5091         (tui_data_window::set_new_height): New methods.
5092         (make_invisible_and_set_new_height): Call set_new_height method.
5093         * tui/tui-data.h (struct tui_win_info)
5094         (struct tui_source_window_base, struct tui_data_window)
5095         <set_new_height>: New method.
5096
5097 2019-06-25  Tom Tromey  <tom@tromey.com>
5098
5099         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5100         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5101         tui_refresh_data_win.
5102         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5103         method.
5104         (tui_refresh_all_win): Call the refresh_all method.
5105         (tui_set_focus): Likewise.
5106         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5107         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5108         Likewise.
5109
5110 2019-06-25  Tom Tromey  <tom@tromey.com>
5111
5112         * tui/tui-winsource.h (tui_refill_source_window)
5113         (tui_set_is_exec_point_at): Don't declare.
5114         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5115         (tui_source_window_base::refill): Rename from
5116         tui_refill_source_window.
5117         (tui_source_window_base::do_scroll_horizontal): Update.
5118         (tui_source_window_base::set_is_exec_point_at): Rename from
5119         tui_set_is_exec_point_at.
5120         (tui_update_all_breakpoint_info): Update.
5121         * tui/tui-stack.c (tui_show_frame_info): Update.
5122         * tui/tui-layout.c (show_data): Add cast.
5123         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5124         * tui/tui-data.h (struct tui_source_window_base) <refill,
5125         set_is_exec_point_at>: New methods.
5126         (tui_source_windows, tui_add_to_source_windows): Update types.
5127         (tui_add_to_source_windows): Remove redundant declaration.
5128         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5129         (tui_source_windows): Change return type.
5130         (tui_clear_source_windows_detail): Update.
5131         (tui_add_to_source_windows): Change type of parameter.
5132         (tui_free_all_source_wins_content): Update.
5133
5134 2019-06-25  Tom Tromey  <tom@tromey.com>
5135
5136         * tui/tui-wingeneral.c (tui_win_info::refresh)
5137         (tui_source_window_base::refresh): New methods.
5138         (tui_refresh_all): Call the refresh method.
5139         * tui/tui-data.h (struct tui_win_info)
5140         (struct tui_source_window_base) <refresh>: New method.
5141
5142 2019-06-25  Tom Tromey  <tom@tromey.com>
5143
5144         * tui/tui.h (tui_is_window_visible): Return bool.
5145         * tui/tui.c (tui_is_window_visible): Return bool.
5146         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5147         (tui_make_visible, tui_make_invisible)
5148         (tui_win_info::make_visible)
5149         (tui_source_window_base::make_visible, make_all_visible)
5150         (tui_make_all_visible, tui_make_all_invisible): Update.
5151         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5152         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5153         bool.
5154         (struct tui_win_info, struct tui_source_window_base)
5155         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5156         * tui/tui-data.c (tui_init_generic_part): Update.
5157
5158 2019-06-25  Tom Tromey  <tom@tromey.com>
5159
5160         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5161         (tui_source_window_base::make_visible): New methods.
5162         (make_all_visible): Make method call.
5163         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5164         (struct tui_source_window_base, struct tui_cmd_window): Override
5165         make_visible.
5166         (tui_win_is_source_type): Don't declare.
5167         * tui/tui-data.c (tui_win_is_source_type): Remove.
5168
5169 2019-06-25  Tom Tromey  <tom@tromey.com>
5170
5171         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5172         NULL check.
5173
5174 2019-06-25  Tom Tromey  <tom@tromey.com>
5175
5176         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5177         Inline constructor.  Add initializers for members.
5178         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5179         constructors; now inline in class.
5180
5181 2019-06-25  Tom Tromey  <tom@tromey.com>
5182
5183         * tui/tui-regs.c (tui_show_registers): Update.
5184         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5185         bool.
5186         * tui/tui-data.c (tui_data_window::clear_detail)
5187         (tui_data_window): Update.
5188
5189 2019-06-25  Tom Tromey  <tom@tromey.com>
5190
5191         * tui/tui-windata.c (tui_display_all_data)
5192         (tui_display_data_from_line, tui_display_data_from)
5193         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5194         Update.
5195         * tui/tui-regs.c (tui_last_regs_line_no)
5196         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5197         (tui_show_registers, tui_show_register_group)
5198         (tui_display_registers_from, tui_display_reg_element_at_line)
5199         (tui_display_registers_from_line, tui_check_register_values)
5200         (tui_reg_next, tui_reg_prev): Update.
5201         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5202         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5203         tui_data_window.
5204         (struct tui_win_info) <detail>: Remove.  Add new fields from
5205         tui_data_info.
5206         (TUI_DATA_WIN): Add cast.
5207         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5208         (~tui_data_window): Simplify.
5209
5210 2019-06-25  Tom Tromey  <tom@tromey.com>
5211
5212         * tui/tui-layout.c (show_source_disasm_command)
5213         (show_source_or_disasm_and_command): Update.
5214         * tui/tui-io.c (update_cmdwin_start_line)
5215         (tui_redisplay_readline): Update.
5216         * tui/tui-data.h (struct tui_command_info): Remove.
5217         (struct tui_win_info) <detail>: Remove command_info member.
5218         (struct tui_data_window) <start_line>: New member, from
5219         tui_command_info.
5220         (TUI_CMD_WIN): Add casts.
5221
5222 2019-06-25  Tom Tromey  <tom@tromey.com>
5223
5224         * tui/tui-winsource.c (tui_update_source_window)
5225         (tui_refill_source_window)
5226         (tui_source_window_base::do_scroll_horizontal)
5227         (tui_update_breakpoint_info, tui_set_exec_info_content)
5228         (tui_show_exec_info_content, tui_erase_exec_info_content)
5229         (tui_clear_exec_info_content): Update.
5230         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5231         Update.
5232         * tui/tui-win.c (make_invisible_and_set_new_height)
5233         (make_visible_with_new_height): Update.
5234         * tui/tui-source.c (tui_set_source_content)
5235         (tui_show_symtab_source): Update.
5236         * tui/tui-layout.c (extract_display_start_addr)
5237         (show_source_disasm_command, show_data)
5238         (make_source_or_disasm_window)
5239         (show_source_or_disasm_and_command): Update.
5240         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5241         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5242         "gdbarch".
5243         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5244         to tui_source_window_base.
5245         (struct tui_win_info) <detail>: Remove source_info member.
5246         (struct tui_source_window_base) <has_locator>: Inline.
5247         Move contents from tui_source_info; rename has_locator member to
5248         m_has_locator.
5249         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5250         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5251         header file.
5252         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5253         Simplify.
5254         (tui_free_all_source_wins_content): Cast to
5255         tui_source_window_base.
5256
5257 2019-06-25  Tom Tromey  <tom@tromey.com>
5258
5259         * tui/tui-win.c (make_invisible_and_set_new_height)
5260         (make_visible_with_new_height): Call has_locator method.
5261         * tui/tui-layout.c (show_source_disasm_command, show_data)
5262         (show_source_or_disasm_and_command): Update for bool change.
5263         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5264         (tui_win_info) <has_locator>: New method.
5265         (struct tui_source_window_base) <has_locator>: New method.
5266         (tui_win_has_locator): Don't declare.
5267         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5268         from tui_win_has_locator.
5269         (tui_source_window_base): Use false, not FALSE.
5270
5271 2019-06-25  Tom Tromey  <tom@tromey.com>
5272
5273         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5274         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5275         clear_detail method directly.
5276         (tui_clear_win_detail): Remove.
5277
5278 2019-06-25  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5281         "this", not TUI_DISASM_WIN.
5282
5283 2019-06-25  Tom Tromey  <tom@tromey.com>
5284
5285         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5286         declare.
5287         * tui/tui-winsource.c
5288         (tui_source_window_base::do_scroll_horizontal): Rename from
5289         tui_horizontal_source_scroll.
5290         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5291         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5292         from tui_vertical_data_scroll.
5293         * tui/tui-win.h (tui_scroll): Don't declare.
5294         * tui/tui-win.c (tui_win_info::forward_scroll)
5295         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5296         (tui_win_info::right_scroll): Rename and update.
5297         (tui_scroll_forward_command, tui_scroll_backward_command)
5298         (tui_scroll_left_command, tui_scroll_right_command): Update.
5299         (tui_scroll): Remove.
5300         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5301         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5302         from tui_vertical_source_scroll.
5303         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5304         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5305         from tui_vertical_disassem_scroll.
5306         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5307         do_scroll_horizontal>: New methods.
5308         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5309         Likewise.
5310         (struct tui_source_window_base): Add do_scroll_horizontal.
5311         (struct tui_source_window, struct tui_disasm_window): Add
5312         do_scroll_vertical.
5313         (struct tui_data_window, struct tui_cmd_window): Add
5314         do_scroll_horizontal and do_scroll_vertical.
5315         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5316
5317 2019-06-25  Tom Tromey  <tom@tromey.com>
5318
5319         * tui/tui-data.h (struct tui_source_window_base): New struct.
5320         (struct tui_source_window): Derive from tui_source_window_base.
5321         (struct tui_disasm_window): New struct.
5322         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5323         from tui_source_window::clear_detail.
5324         (tui_source_window_base): Rename from tui_source_window.
5325         (~tui_source_window_base): Rename from ~tui_source_window.
5326         (tui_alloc_win_info): Create a tui_disasm_window.
5327
5328 2019-06-25  Tom Tromey  <tom@tromey.com>
5329
5330         * tui/tui-data.h (struct tui_source_window)
5331         (struct tui_data_window): Declare destructors.
5332         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5333         destructors.
5334         (tui_win_info): Simplify.
5335
5336 2019-06-25  Tom Tromey  <tom@tromey.com>
5337
5338         * tui/tui-winsource.c (tui_display_main)
5339         (tui_update_source_windows_with_addr)
5340         (tui_update_all_breakpoint_info): Update.
5341         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5342         (new_height_ok, parse_scrolling_args): Update.
5343         * tui/tui-stack.c (tui_show_frame_info): Update.
5344         * tui/tui-data.h (struct tui_list): Remove.
5345         (tui_source_windows): Return a reference to a std::vector.
5346         * tui/tui-data.c (source_windows): Now a std::vector.
5347         (tui_source_windows): Change return type.
5348         (tui_clear_source_windows): Rewrite.
5349         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5350         (tui_free_all_source_wins_content): Rewrite.
5351
5352 2019-06-25  Tom Tromey  <tom@tromey.com>
5353
5354         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5355         (struct tui_data_window, struct tui_cmd_window): Declare
5356         clear_detail method.
5357         * tui/tui-data.c (tui_source_window::clear_detail)
5358         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5359         methods.
5360         (tui_clear_win_detail): Simplify.
5361
5362 2019-06-25  Tom Tromey  <tom@tromey.com>
5363
5364         * tui/tui-layout.c (make_source_window, make_disasm_window)
5365         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5366         Return the new window.
5367         (show_source_disasm_command, show_data)
5368         (show_source_or_disasm_and_command): Update.
5369
5370 2019-06-25  Tom Tromey  <tom@tromey.com>
5371
5372         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5373         parameter.  Return the new window.
5374         (show_source_disasm_command): Update and remove NULL check.
5375         (show_source_or_disasm_and_command): Update.
5376
5377 2019-06-25  Tom Tromey  <tom@tromey.com>
5378
5379         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5380
5381 2019-06-25  Tom Tromey  <tom@tromey.com>
5382
5383         * tui/tui-data.h (struct tui_win_info): Make constructor
5384         protected.  Make destructor virtual.  Add initializers.
5385         (tui_source_window, tui_data_window, tui_cmd_window): New
5386         classes.
5387         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5388         constructor.  Add "type" parameter.
5389         (tui_source_window, tui_data_window, tui_cmd_window): New
5390         constructors.
5391         (tui_alloc_win_info): Instantiate the appropriate subclass.
5392
5393 2019-06-25  Tom Tromey  <tom@tromey.com>
5394
5395         * tui/tui-win.c (tui_resize_all): Use delete.
5396         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5397         destructor.
5398         (tui_free_window): Don't declare.
5399         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5400         Update.
5401
5402 2019-06-25  Tom Tromey  <tom@tromey.com>
5403
5404         * tui/tui-data.h (struct tui_win_info): Add constructor.
5405         * tui/tui-data.c (tui_alloc_win_info): Use new.
5406         (tui_free_window): Use delete.
5407
5408 2019-06-22  Tom Tromey  <tom@tromey.com>
5409
5410         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5411         declare.
5412         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5413
5414 2019-06-22  Tom Tromey  <tom@tromey.com>
5415
5416         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5417         declare.
5418         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5419
5420 2019-06-22  Tom de Vries  <tdevries@suse.de>
5421
5422         * dwarf2read.c (create_addrmap_from_aranges)
5423         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5424         instead of '%zu'.
5425
5426 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5427
5428         * dwarf2read.h (dwarf2_section_info_def): Remove.
5429         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5430         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5431         std::vector<dwarf2_section_info>.
5432         (struct dwo_file) <~dwo_file>: Remove.
5433         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5434         types field.
5435         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5436         (dwarf2_read_debug_names): Likewise.
5437         (create_debug_types_hash_table): Change parameter type to
5438         array_view, adjust code accordingly.
5439         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5440         (partial_die_info::fixup): Likewise.
5441         (determine_prefix): Likewise.
5442         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5443
5444 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5445
5446         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5447         gdb_bfd_ref_ptr.
5448         <~dwo_file>: Remove call to gdb_bfd_unref.
5449         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5450         gdb_bfd_ref_ptr::get.
5451
5452 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5453
5454         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5455         type to htab_up.
5456         * dwarf2read.c (struct dwo_file): Initialize fields.
5457         <~dwo_file>: New.
5458         (free_dwo_file): Remove, move content to ~dwo_file.
5459         (struct dwo_file_deleter): Remove.
5460         (dwo_file_up>: Remove custom deleter.
5461         (free_dwo_files): Remove.
5462         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5463         dwo_files.
5464         (process_skeletonless_type_units): Call unique_ptr::get.
5465         (allocate_dwo_file_hash_table): Add deleter to created hash
5466         table.  Change return type to htab_up.
5467         (lookup_dwo_file_slot): Don't memset dwo_file, call
5468         unique_ptr::get.
5469         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5470         (create_dwo_unit_in_dwp_v2): Likewise.
5471         (open_and_init_dwo_file): Likewise.
5472         (free_dwo_file_from_slot): Remove.
5473
5474 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5475
5476         * dwarf2read.h (struct dwarf2_section_info) <readin,
5477         is_virtual>: Change type to bool.
5478         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5479         true instead of 1.
5480
5481 2019-06-19  Tom Tromey  <tom@tromey.com>
5482
5483         * tui/tui-data.h (tui_init_content_element): Don't declare.
5484
5485 2019-06-19  Tom Tromey  <tom@tromey.com>
5486
5487         * tui/tui-data.h (tui_init_win_info): Don't declare.
5488
5489 2019-06-19  Tom de Vries  <tdevries@suse.de>
5490
5491         * dwarf2read.h (abstract_to_concrete): Change type to
5492         std::unordered_map<sect_offset, std::vector<sect_offset>,
5493         gdb::hash_enum<sect_offset>>.
5494
5495 2019-06-19  Tom Tromey  <tromey@adacore.com>
5496
5497         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5498         EVAL_AVOID_SIDE_EFFECTS specially.
5499
5500 2019-06-19  Tom Tromey  <tromey@adacore.com>
5501
5502         * source-cache.c (highlighter): New global.
5503         (source_cache::get_source_lines): Create a highlighter on demand.
5504
5505 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5506
5507         * defs.h (deprecated_interactive_hook): Delete declaration.
5508         * interps.c (clear_interpreter_hooks): Remove use of
5509         deprecated_interactive_hook.
5510         * top.c (deprecated_interactive_hook): Delete definition.
5511         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5512
5513 2019-06-18  Tom de Vries  <tdevries@suse.de>
5514
5515         PR gdb/24515
5516         * dwarf2read.h (abstract_to_concrete): Change type from
5517         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5518         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5519         * dwarf2read.c (read_variable): Update.
5520         (dwarf2_fetch_die_loc_sect_off): Update.
5521
5522 2019-06-17  Tom de Vries  <tdevries@suse.de>
5523
5524         PR gdb/24617
5525         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5526         accessing parent[parent_len - 1].
5527
5528 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5529
5530         PR gdb/24364
5531         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5532         call dtrace_process_dof with NULL dof.
5533
5534 2019-06-16  Tom de Vries  <tdevries@suse.de>
5535
5536         PR gdb/24445
5537         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5538
5539 2019-06-16  Tom Tromey  <tom@tromey.com>
5540
5541         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5542         (make_all_visible): Use address of member.
5543
5544 2019-06-16  Tom Tromey  <tom@tromey.com>
5545
5546         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5547         (tui_free_window, free_content, free_content_elements): Remove
5548         unnecessary cast.
5549         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5550         cast.
5551         * tui/tui-regs.c (tui_show_register_group)
5552         (tui_display_registers_from, tui_display_reg_element_at_line):
5553         Remove unnecessary cast.
5554
5555 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5556
5557         * linux-nat.c (normal_mask): Delete.
5558         (_initialize_linux_nat): Don't initialise normal_mask.
5559
5560 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5561
5562         PR gdb/24445
5563         * dwarf-index-write.h (write_psymtabs_to_index): Add
5564         dwz_basename parameter.
5565         * dwarf-index-write.c (write_gdbindex): Move file writing to
5566         write_gdbindex_1.  Change return type void.
5567         (assert_file_size): Move up, remove filename parameter.
5568         (write_gdbindex_1): New function.
5569         (write_debug_names): Change return type to void, call
5570         assert_file_size.
5571         (struct index_wip_file): New struct.
5572         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5573         file logic to index_wip_file.  Write index for dwz file if
5574         needed.
5575         (save_gdb_index_command): Pass basename of dwz file, if present.
5576         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5577         build-id of dwz file, if present.
5578         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5579         (dwarf2_get_dwz_file): Likewise.
5580         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5581         (dwarf2_get_dwz_file): Likewise.
5582
5583 2019-06-16  Tom Tromey  <tom@tromey.com>
5584
5585         * coffread.c (process_coff_symbol): Use xstrdup.
5586         * value.c (create_internalvar): Use xstrdup.
5587
5588 2019-06-16  Tom Tromey  <tom@tromey.com>
5589
5590         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5591         * breakpoint.c (stopin_command, stopat_command)
5592         (until_break_command, decode_location_default): Remove unnecessary
5593         cast.
5594         * utils.c (subset_compare): Remove unnecessary cast.
5595         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5596         cast.
5597         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5598         cast.
5599         * infcmd.c (path_command): Remove unnecessary cast.
5600         * coffread.c (decode_type): Remove unnecessary cast.
5601         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5602         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5603         * tui/tui-stack.c (tui_show_locator_content)
5604         (tui_show_frame_info): Remove unnecessary cast.
5605         * tui/tui-win.c (tui_scroll_forward_command)
5606         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5607         (parse_scrolling_args): Remove unnecessary cast.
5608         * tui/tui-data.c (init_win_info, tui_del_window)
5609         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5610         (free_content_elements): Remove unnecessary cast.
5611         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5612         unnecessary cast.
5613         * tui/tui-source.c (tui_set_source_content)
5614         (tui_vertical_source_scroll): Remove unnecessary cast.
5615         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5616         cast.
5617         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5618         * tui/tui-regs.c (tui_display_registers_from)
5619         (tui_display_register): Remove unnecessary cast.
5620         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5621         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5622         (make_visible): Remove unnecessary cast.
5623         * tui/tui-winsource.c (tui_erase_source_content)
5624         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5625         unnecessary cast.
5626         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5627         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5628         * stabsread.c (read_type, read_array_type, read_range_type):
5629         Remove unnecessary cast.
5630         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5631         (parse_symbol, parse_type, upgrade_type, parse_external)
5632         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5633         unnecessary cast.
5634         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5635
5636 2019-06-16  Tom Tromey  <tom@tromey.com>
5637
5638         * tui/tui-data.c (tui_alloc_generic_win_info)
5639         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5640         checks.
5641
5642 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5643             Andrew Burgess  <andrew.burgess@embecosm.com>
5644
5645         * f-typeprint.c (f_print_type): Don't return early for not
5646         associated or not allocated types.
5647         (f_type_print_varspec_suffix): Add print_rank parameter and print
5648         ranks of array types in case they dangling.
5649         (f_type_print_base): Add print_rank parameter.
5650
5651 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5652
5653         * NEWS: Mention new MI commands.
5654         * break-catch-throw.c (enum exception_event_kind): Move to
5655         breakpoint.h.
5656         (print_mention_exception_catchpoint): Output text as a single
5657         message.
5658         (catch_exception_command_1): Rename to...
5659         (catch_exception_event): ...this, make non-static, update header
5660         command, and change some parameter types.
5661         (catch_catch_command): Update for changes to
5662         catch_exception_command_1.
5663         (catch_throw_command): Likewise.
5664         (catch_rethrow_command): Likewise.
5665         * breakpoint.c (enum exception_event_kind): Delete.
5666         * breakpoint.h (enum exception_event_kind): Moved here from
5667         break-catch-throw.c.
5668         (catch_exception_event): Declare.
5669         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5670         (mi_cmd_catch_throw): New function.
5671         (mi_cmd_catch_rethrow): New function.
5672         (mi_cmd_catch_catch): New function.
5673         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5674         'catch-catch' entries.
5675         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5676         (mi_cmd_catch_rethrow): Declare.
5677         (mi_cmd_catch_catch): Declare.
5678
5679 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5680
5681         * annotate.c (annotate_source_line): Change return type to void,
5682         update implementation to match.
5683         * annotate.h (annotate_source_line): Change return type to void,
5684         update header comment.
5685         * stack.c (print_frame_info): Don't change what frame information
5686         is printed based on whether annotations are on or not.
5687
5688 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5689
5690         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5691         (annotate_source): Make static.
5692         (annotate_source_line): Moved from source.c and renamed from
5693         identify_source_line.  Update the return type.
5694         * annotate.h (annotate_source): Delete declaration.
5695         (annotate_source_line): Declaration moved from source.h, and
5696         renamed from identify_source_line.  Return type updated.
5697         * source.c (identify_source_line): Moved to annotate.c and renamed
5698         to annotate_source_line.
5699         (info_line_command): Remove check of annotation_level.
5700         * source.h (identify_source_line): Move declaration to annotate.h
5701         and rename to annotate_source_line.
5702         * stack.c: Add 'annotate.h' include.
5703         (print_frame_info): Remove check of annotation_level before
5704         calling annotate_source_line.
5705
5706 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5707
5708         * source-cache.c (source_cache::get_plain_source_lines): Use
5709         open_source_file_with_line_charpos instead of just
5710         open_source_file, remove call to find_source_lines.
5711         (source_cache::get_source_lines): Likewise.
5712         * source.c (find_source_lines): Make static.
5713         (get_filename_and_charpos): Renamed into...
5714         (open_source_file_with_line_charpos): ..this along with changes to
5715         return a scoped_fd, and some other minor clean ups.
5716         (identify_source_line): Use open_source_file_with_line_charpos.
5717         (search_command_helper): Use open_source_file_with_line_charpos
5718         instead of just open_source_file, remove call to
5719         find_source_lines.
5720         * source.h (open_source_file_with_line_charpos): Declare new
5721         function.
5722         (find_source_lines): Delete declaration.
5723
5724 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * source.c (get_filename_and_charpos): Remove fullname
5727         parameter.
5728         (identify_source_line): Update call to get_filename_and_charpos.
5729
5730 2019-06-14  Tom Tromey  <tromey@adacore.com>
5731
5732         PR gdb/24502:
5733         * ui-style.h (skip_ansi_escape): Update comment.
5734         * ui-file.h (class no_terminal_escape_file): New class.
5735         * ui-file.c (no_terminal_escape_file::write)
5736         (no_terminal_escape_file::puts): New methods.
5737         * cli/cli-logging.c (handle_redirections): Use
5738         no_terminal_escape_file.
5739
5740 2019-06-14  Tom Tromey  <tromey@adacore.com>
5741
5742         * NEWS: Move convenience variable news above Python news.
5743
5744 2019-06-14  Tom Tromey  <tom@tromey.com>
5745
5746         * gnulib: Move directory to top-level.
5747         * configure.ac: Don't configure gnulib.
5748         * configure: Rebuild.
5749         * common/common-defs.h: Use new path to gnulib.
5750         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5751         (GNULIB_H): Remove.
5752         (INCGNU): Look in new gnulib location.
5753         (HFILES_NO_SRCDIR): Remove gnulib files.
5754         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5755         (generated_files): Remove GNULIB_H.
5756         ($(LIBGNU), all-lib): Remove targets.
5757         (distclean): Don't mention GNULIB_BUILDDIR.
5758         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5759
5760 2019-06-14  Tom Tromey  <tromey@adacore.com>
5761
5762         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5763         Warn if symbol file does not provide any symbols.
5764
5765 2019-06-14  Tom Tromey  <tromey@adacore.com>
5766
5767         * source.c (find_and_open_source): Respect basenames_may_differ.
5768
5769 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5770
5771         * annotate.c (annotate_breakpoints_invalid): Make use of
5772         scoped_restore_terminal_state.
5773         (annotate_frames_invalid): Likewise.
5774
5775 2019-06-14  Tom Tromey  <tromey@adacore.com>
5776
5777         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5778         allow assignment to an internalvar.
5779
5780 2019-06-14  Tom Tromey  <tromey@adacore.com>
5781
5782         * ada-lex.l: Allow "_" in attribute names.
5783
5784 2019-06-14  Tom Tromey  <tromey@adacore.com>
5785
5786         PR gdb/24653:
5787         * regcache.c (registers_changed): Don't call alloca.
5788         * top.c (execute_command): Don't call alloca.
5789
5790 2019-06-13  Pedro Alves  <palves@redhat.com>
5791
5792         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5793         'expression'.  When parsing an expression, error out if there's
5794         junk after "unlimited".
5795         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5796         (do_set_command): Adjust calls to is_unlimited_literal.
5797
5798 2019-06-13  Pedro Alves  <palves@redhat.com>
5799
5800         * compile/compile.c (make_compile_options_def_group): Add braces
5801         around array_view initializer.
5802         * thread.c (make_thread_apply_all_options_def_group)
5803         (make_thread_apply_all_options_def_group): Likewise.
5804
5805 2019-06-13  Pedro Alves  <palves@redhat.com>
5806
5807         * NEWS (New commands): Mention "maint test-options
5808         require-delimiter", "maint test-options unknown-is-error", "maint
5809         test-options unknown-is-operand" and "maint show
5810         test-options-completion-result".
5811         (New command options, command completion): New section.
5812         (Completion improvements): New section.
5813         Mention that you can abbreviate "unlimited".
5814
5815 2019-06-13  Pedro Alves  <palves@redhat.com>
5816
5817         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5818         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5819         * unittests/cli-utils-selftests.c (test_parse_flags)
5820         (test_parse_flags_qcs): Delete.
5821         (test_cli_utils): Don't call deleted functions.
5822
5823 2019-06-13  Pedro Alves  <palves@redhat.com>
5824
5825         * thread.c: Include "cli/cli-option.h".
5826         (tp_array_compar_ascending): Global.
5827         (tp_array_compar): Delete function.
5828         (tp_array_compar_ascending, tp_array_compar_descending): New
5829         functions.
5830         (ascending_option_def, qcs_flag_option_def)
5831         (thr_qcs_flags_option_defs)
5832         (make_thread_apply_all_options_def_group)
5833         (make_thread_apply_options_def_group): New.
5834         (thread_apply_all_command): Use gdb::option::process_options.
5835         (thread_apply_command_completer)
5836         (thread_apply_all_command_completer): New.
5837         (thread_apply_command): Use gdb::option::process_options.
5838         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5839         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5840         to generate help text of "thread apply".  Adjust "taas"'s help.
5841         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5842         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5843
5844 2019-06-13  Pedro Alves  <palves@redhat.com>
5845
5846         * thread.c (thread_apply_command): Check for invalid TID with
5847         isdigit instead of !isalpha.
5848
5849 2019-06-13  Pedro Alves  <palves@redhat.com>
5850
5851         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5852         (validate_flags_qcs): New.
5853         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5854         (validate_flags_qcs): Declare.
5855         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5856         (make_frame_apply_options_def_group): New.
5857         (frame_apply_command_count): Process options with
5858         gdb::option::process_options.
5859         (frame_apply_completer): New.
5860         (frame_apply_level_completer, frame_apply_all_completer)
5861         (frame_apply_completer): New.
5862         (_initialize_stack): Update help of "frame apply", "frame apply
5863         level", "frame apply all" and "faas" to mention supported options
5864         and install command completers.
5865         * stack.h (frame_apply_all_completer): Declare.
5866         * thread.c: Include "stack.h".
5867         (tfaas_command): Add "--".
5868         (_initialize_thread): Update help "tfaas" to mention supported
5869         options and install command completer.
5870
5871 2019-06-13  Pedro Alves  <palves@redhat.com>
5872
5873         * completer.c (complete_nested_command_line): New.
5874         (gdb_completion_word_break_characters_throw): Add assertion.
5875         * completer.h (complete_nested_command_line): Declare.
5876
5877 2019-06-13  Pedro Alves  <palves@redhat.com>
5878
5879         * stack.c (parse_backtrace_qualifiers): New.
5880         (backtrace_command): Use it.
5881         (backtrace_command_completer): Complete on qualifiers.
5882
5883 2019-06-13  Pedro Alves  <palves@redhat.com>
5884
5885         * frame.c: Include "cli/cli-option.h.
5886         (user_set_backtrace_options): New.
5887         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5888         Delete.
5889         (get_prev_frame): Adjust.
5890         (boolean_option_def, uinteger_option_def)
5891         (set_backtrace_option_defs): New.
5892         (_initialize_frame): Adjust and use
5893         gdb::option::add_setshow_cmds_for_options to install "set
5894         backtrace past-main" and "set backtrace past-entry".
5895         * frame.h: Include "cli/cli-option.h".
5896         (struct frame_print_options): Forward declare.
5897         (print_frame_arguments_all, print_frame_arguments_scalars)
5898         (print_frame_arguments_none): Declare.
5899         (print_entry_values): Delete declaration.
5900         (struct frame_print_options, user_frame_print_options): New.
5901         (struct set_backtrace_options): New.
5902         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5903         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5904         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5905         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5906         (list_args_or_locals): Add frame_print_options parameter.
5907         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5908         * python/py-framefilter.c (enumerate_args): Pass down
5909         USER_FRAME_PRINT_OPTIONS.
5910         * stack.c: Include "cli/cli-option.h".
5911         (print_frame_arguments_all, print_frame_arguments_scalars)
5912         (print_frame_arguments_none): Declare.
5913         (print_raw_frame_arguments, print_entry_values): Delete.
5914         (user_frame_print_options): New.
5915         (boolean_option_def, enum_option_def, frame_print_option_defs):
5916         New.
5917         (struct backtrace_cmd_options): New.
5918         (bt_flag_option_def): New.
5919         (backtrace_command_option_defs): New.
5920         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5921         (print_frame_arg, read_frame_arg, print_frame_args)
5922         (print_frame_info, print_frame): Add frame_print_options parameter
5923         and use it.
5924         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5925         (backtrace_command_1): Add frame_print_options and
5926         backtrace_cmd_options parameters and use them.
5927         (make_backtrace_options_def_group): New.
5928         (backtrace_command): Process command options with
5929         gdb::option::process_options.
5930         (backtrace_command_completer): New.
5931         (_initialize_stack): Extend "backtrace"'s help to mention
5932         supported options.  Install completer for "backtrace".
5933         Install some settings commands with add_setshow_cmds_for_options.
5934
5935 2019-06-13  Pedro Alves  <palves@redhat.com>
5936
5937         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5938         and that "set/show print raw frame-arguments" are now deprecated.
5939
5940         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5941         command.
5942         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5943         * stack.c (_initialize_stack): Install "set/show print
5944         raw-frame-arguments", and deprecate "set/show print raw
5945         frame-arguments".
5946         * valprint.c (_initialize_valprint): Deprecate "set/show print
5947         raw".
5948
5949 2019-06-13  Pedro Alves  <palves@redhat.com>
5950
5951         * compile/compile.c (struct compile_options): New.
5952         (compile_flag_option_def, compile_command_option_defs)
5953         (make_compile_options_def_group): New.
5954         (compile_file_command): Handle options with
5955         gdb::option::process_options.
5956         (compile_file_command_completer): New function.
5957         (compile_code_command): Handle options with
5958         gdb::option::process_options.
5959         (compile_code_command_completer): New function.
5960         (_initialize_compiler): Install completers for "compile code" and
5961         "compile file".  Mention available options in "compile code" and
5962         "compile code"'s help.
5963         * completer.c (advance_to_completion_word): New, factored out from
5964         ...
5965         (advance_to_expression_complete_word_point): ... this.
5966         (advance_to_filename_complete_word_point): New.
5967         * completer.h (advance_to_filename_complete_word_point): New
5968         declaration.
5969
5970 2019-06-13  Pedro Alves  <palves@redhat.com>
5971
5972         * compile/compile.c: Include "cli/cli-option.h".
5973         (compile_print_value): Scope data pointer is now a
5974         value_print_options pointer; adjust.
5975         (compile_print_command): Process options.  Scope data pointer is
5976         now a value_print_options pointer; adjust.
5977         (_initialize_compile): Update "compile print"'s help to include
5978         supported options.  Install a completer for "compile print".
5979         * cp-valprint.c (show_vtblprint, show_objectprint)
5980         (show_static_field_print): Delete.
5981         (_initialize_cp_valprint): Don't install "set print
5982         static-members", "set print vtbl", "set print object" here.
5983         * printcmd.c: Include "cli/cli-option.h" and
5984         "common/gdb_optional.h".
5985         (print_command_parse_format): Rework to fill in a
5986         value_print_options instead of a format_data.
5987         (print_value): Change parameter type from format_data pointer to
5988         value_print_options reference.  Adjust.
5989         (print_command_1): Process options.  Adjust to pass down a
5990         value_print_options.
5991         (print_command_completer): New.
5992         (_initialize_printcmd): Install print_command_completer as
5993         handle_brkchars completer for the "print" command.  Update
5994         "print"'s help to include supported options.
5995         * valprint.c: Include "cli/cli-option.h".
5996         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5997         here from cp-valprint.c.
5998         (boolean_option_def, uinteger_option_def)
5999         (value_print_option_defs, make_value_print_options_def_group):
6000         New.  Use gdb::option::add_setshow_cmds_for_options to install
6001         "set print elements", "set print null-stop", "set print repeats",
6002         "set print pretty", "set print union", "set print array", "set
6003         print address", "set print symbol", "set print array-indexes".
6004         * valprint.h: Include <string> and "cli/cli-option.h".
6005         (make_value_print_options_def_group): Declare.
6006         (print_value): Change parameter type from format_data pointer to
6007         value_print_options reference.
6008         (print_command_completer): Declare.
6009
6010 2019-06-13  Pedro Alves  <palves@redhat.com>
6011
6012         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6013         (COMMON_SFILES): Add maint-test-settings.c.
6014         * cli/cli-decode.c (boolean_enums): New global, factored out from
6015         ...
6016         (add_setshow_boolean_cmd): ... here.
6017         * cli/cli-decode.h (boolean_enums): Declare.
6018         * cli/cli-option.c: New file.
6019         * cli/cli-option.h: New file.
6020         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6021         factored out from ...
6022         (parse_cli_boolean_value(const char *)): ... this.
6023         (is_unlimited_literal): Change parameter type to pointer to
6024         pointer.  Adjust and advance ARG pointer.
6025         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6026         (parse_cli_var_enum): New, factored out from ...
6027         (do_set_command): ... this.  Adjust.
6028         * cli/cli-setshow.h (parse_cli_boolean_value)
6029         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6030         (parse_cli_var_enum): Declare.
6031         * cli/cli-utils.c: Include "cli/cli-option.h".
6032         (get_ulongest): New.
6033         * cli/cli-utils.h (get_ulongest): Declare.
6034         (check_for_argument): New overloads.
6035         * maint-test-options.c: New file.
6036
6037 2019-06-13  Pedro Alves  <palves@redhat.com>
6038
6039         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6040         parse a range if "-" is at the end of the string.
6041
6042 2019-06-13  Pedro Alves  <palves@redhat.com>
6043
6044         * cli/cli-setshow.c (parse_auto_binary_operation)
6045         (parse_cli_boolean_value): Don't allow "o".
6046
6047 2019-06-13  Pedro Alves  <palves@redhat.com>
6048
6049         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6050         * NEWS: Mention maint test-settings KIND.
6051         * maint-test-settings.c: New file.
6052
6053 2019-06-13  Pedro Alves  <palves@redhat.com>
6054
6055         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6056         completer.
6057         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6058         "set" completers.
6059
6060 2019-06-13  Pedro Alves  <palves@redhat.com>
6061
6062         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6063         after item.
6064
6065 2019-06-13  Pedro Alves  <palves@redhat.com>
6066
6067         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6068
6069 2019-06-13  Pedro Alves <palves@redhat.com>
6070
6071         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6072         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6073         call.
6074         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6075         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6076         calls.
6077         (check_for_argument): Skip spaces after argument.
6078
6079 2019-06-13  Pedro Alves  <palves@redhat.com>
6080
6081         * thread.c (thread_apply_command): Adjust TID parsing.
6082         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6083         detected before end of string.
6084         (tid_is_in_list): Error out if LIST is invalid.
6085
6086 2019-06-13  Pedro Alves  <palves@redhat.com>
6087
6088         * completer.c (complete_line_internal_1): Rewind completion word
6089         point.
6090         (completion_tracker::advance_custom_word_point_by): Change
6091         parameter type to int.
6092         * completer.h (completion_tracker::advance_custom_word_point_by):
6093         Likewise.
6094
6095 2019-06-13  Pedro Alves  <palves@redhat.com>
6096
6097         * completer.c (advance_to_completion_word): Handle delimiters.
6098
6099 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6100
6101         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6102
6103 2019-06-11  Tom Tromey  <tom@tromey.com>
6104
6105         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6106         (xmalloc_failed): Move to alloc.c.
6107         * alloc.c: New file.
6108         * Makefile.in (COMMON_SFILES): Add alloc.c.
6109
6110 2019-06-11  Tom Tromey  <tom@tromey.com>
6111
6112         * nat/linux-waitpid.c: Don't include server.h.
6113         (linux_debug): Remove.
6114         (my_waitpid): Update.
6115
6116 2019-06-11  Tom Tromey  <tromey@adacore.com>
6117
6118         * infcall.c (_initialize_infcall): Remove trailing newline from
6119         help.
6120         * user-regs.c (_initialize_user_regs): Remove trailing newline
6121         from help.
6122         * typeprint.c (_initialize_typeprint): Remove trailing newline
6123         from help.
6124         * reverse.c (_initialize_reverse): Remove trailing newlines from
6125         help.
6126         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6127         from help.
6128         * language.c (add_set_language_command): Remove trailing newline
6129         from help.
6130         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6131         help.
6132         * disasm.c (_initialize_disasm): Remove trailing newline from
6133         help.
6134         * top.c (init_main): Remove trailing newline from help.
6135         * interps.c (_initialize_interpreter): Remove trailing newline
6136         from help.
6137         * btrace.c (_initialize_btrace): Remove trailing newlines from
6138         help.
6139         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6140         from help.
6141         * python/python.c (_initialize_python): Remove trailing newline
6142         from help.
6143         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6144         help.
6145         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6146         from help.  Reformat some text.
6147         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6148         from help.
6149         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6150         newline from help.
6151
6152 2019-06-11  Tom Tromey  <tromey@adacore.com>
6153
6154         * darwin-nat.c (darwin_decode_exception_message)
6155         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6156
6157 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6158
6159         * valops.c (value_slice): Check for not allocated or not
6160         associated values.
6161
6162 2019-06-10  Tom de Vries  <tdevries@suse.de>
6163
6164         PR gdb/24618
6165         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6166         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6167         invalid.
6168
6169 2019-06-10  Tom de Vries  <tdevries@suse.de>
6170
6171         PR gdb/24611
6172         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6173         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6174
6175 2019-06-10  Tom de Vries  <tdevries@suse.de>
6176
6177         PR symtab/24545
6178         * symtab.c (struct demangled_name_entry): Add language field.
6179         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6180         static minimal symbol".  Set and use language field.
6181
6182 2019-06-10  Tom Tromey  <tromey@adacore.com>
6183
6184         * ada-lang.c (_initialize_ada_language): Update help text.
6185
6186 2019-06-10  Tom Tromey  <tromey@adacore.com>
6187
6188         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6189         with a newline.
6190         * guile/guile.c (handle_boot_error): Don't end warning with a
6191         newline.
6192         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6193         warning with a newline.
6194         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6195         newline.
6196         (s12z_frame_cache): Likewise.
6197         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6198         a newline.
6199         * solib-svr4.c (disable_probes_interface): Don't end warning with
6200         a newline.
6201         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6202         newline.
6203         * python/python.c (do_finish_initialization): Don't end warning
6204         with a newline.
6205
6206 2019-06-10  Tom Tromey  <tom@tromey.com>
6207
6208         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6209         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6210         gdbpy_enter.
6211
6212 2019-06-10  Tom Tromey  <tromey@adacore.com>
6213
6214         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6215         data.
6216         (elf_new_init): Don't call stabsread_new_init.
6217         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6218         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6219         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6220
6221 2019-06-10  Tom de Vries  <tdevries@suse.de>
6222
6223         PR symtab/16264
6224         PR symtab/24517
6225         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6226
6227 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6228
6229         * source.c (find_and_open_source): Also rewrite relative file
6230         names.
6231
6232 2019-04-26  Amos Bird  <amosbird@gmail.com>
6233
6234         * annotate.c (annotate_thread_exited): Add "thread-exited"
6235         annotation.
6236
6237 2019-06-06  Tom Tromey  <tromey@adacore.com>
6238
6239         * maint.h (class scoped_command_stats): Use
6240         DISABLE_COPY_AND_ASSIGN.
6241         <print_time>: New method.
6242         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6243         print_time.
6244         (scoped_command_stats::print_time): New method.
6245
6246 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6247
6248         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6249         instructions of lengths 6 or 8 bytes.
6250
6251 2019-06-04  Pedro Alves  <palves@redhat.com>
6252
6253         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6254
6255         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6256         * breakpoint.c (condition_completer): Likewise.
6257         * cli/cli-dump.c (scan_expression): Likewise.
6258         * common/filestuff.c (mkdir_recursive): Likewise.
6259         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6260         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6261         (gdb_abspath): Likewise.
6262         * compile/compile-cplus-types.c
6263         (compile_cplus_instance::decl_name): Likewise.
6264         * completer.c (complete_explicit_location):
6265         (signal_completer, reg_or_group_completer_1): Likewise.
6266         * cp-support.c (cp_remove_params_if_any): Likewise.
6267         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6268         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6269         * infcmd.c (strip_bg_char): Likewise.
6270         * linespec.c (copy_token_string): Likewise.
6271         * mi/mi-main.c (output_cores): Likewise.
6272         * psymtab.c (psymtab_search_name):
6273         * symfile.c (test_set_ext_lang_command): Likewise.
6274         * target.c (target_fileio_read_stralloc): Likewise.
6275         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6276         * value.c (complete_internalvar): Likewise.
6277
6278 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6279
6280         Add objfile property to gdb.Type.
6281         * NEWS: Mention Python API addition.
6282         * python/py-type.c (typy_get_objfile): New method.
6283
6284 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6285
6286         * NEWS: Mention the new set|show style [title|highlight].
6287         Mention changes to "show style", "help" and "apropos".
6288
6289 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6290
6291         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6292         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6293         instead of print_help_for_command.
6294         (print_doc_of_command): New function.
6295         (help_list): Add 'apropos -v word' suggestion.
6296         (print_help_for_command): Style the command name using title style.
6297         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6298         (_initialize_cli_cmds): Describe -v in apropos_command help.
6299
6300 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6301
6302         * cli/cli-style.h (cli_style_option): Add name in constructor,
6303         add m_name class member, add constructor with intensity,
6304         add name class function.
6305         (cli_style_option::add_setshow_commands): Remove name argument.
6306         (highlight_style, title_style): New styles.
6307         * cli/cli-style.c (do_show): New function that shows a style
6308         characteristic styling the style name with itself.
6309         (set_style_name): New function.
6310         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6311         Update all callers according to the changes in cli/cli-style.h.
6312         * utils.h (fputs_highlighted): New function.
6313         * utils.c (fputs_highlighted): Likewise.
6314
6315 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6316
6317         * NEWS: Mention new pipe command and new convenience variables.
6318
6319 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6320
6321         * cli/cli-cmds.c (pipe_command): New function.
6322         (_initialize_cli_cmds): Call add_com for pipe_command.
6323         Define | as an alias for pipe.
6324         (exit_status_set_internal_vars): New function.
6325         (shell_escape): Call exit_status_set_internal_vars.
6326         cli/cli-decode.c (find_command_name_length): Recognize | as
6327         a single character command.
6328
6329 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6330
6331         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6332         top.c (execute_command_to_ui_file): New function, mostly a copy
6333         of execute_command_to_string.
6334         (execute_command_to_string): Implement by calling
6335         execute_command_to_ui_file.
6336
6337 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6338
6339         * top.h (saved_command_line): Remove declaration.
6340         * top.c (previous_saved_command_line, previous_repeat_arguments):
6341         New variables.
6342         (saved_command_line): Make static, define together with other
6343         'repeat variables'.
6344         (dont_repeat): Clear repeat_arguments.
6345         (repeat_previous, get_saved_command_line, save_command_line):
6346         New functions.
6347         (gdb_init): Initialize saved_command_line
6348         and previous_saved_command_line.
6349         * main.c (captured_main_1): Remove saved_command_line initialization.
6350         * event-top.c (handle_line_of_input): Update to use
6351         the new 'repeat' related functions instead of direct access to
6352         saved_command_line.
6353         * command.h (repeat_previous, get_saved_command_line,
6354         save_command_line): New declarations.
6355         (dont_repeat): Add comment.
6356
6357 2019-05-30  Tom Tromey  <tromey@adacore.com>
6358
6359         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6360         Fix comment.
6361         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6362
6363 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6364
6365         PR cli/24587
6366         * completer.c (complete): Initialize variable word.
6367
6368 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6369
6370         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6371         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6372         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6373         'body' is NULL to the outter 'if', protecting the '!is_define'
6374         situation as well.
6375
6376 2019-05-29  Tom Tromey  <tromey@adacore.com>
6377
6378         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6379         (dwarf_unknown): New function.
6380         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6381         (dwarf_type_encoding_name): Use dwarf_unknown.
6382
6383 2019-05-29  Tom Tromey  <tromey@adacore.com>
6384
6385         PR c++/20020:
6386         * cp-valprint.c (cp_print_value_fields): Call
6387         cp_print_static_field inside "try".
6388
6389 2019-05-29  Tom Tromey  <tromey@adacore.com>
6390
6391         * inflow.c (struct terminal_info): Add default operator=.
6392         * configure: Rebuild.
6393         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6394         -Wdeprecated-copy-dtor, -Wredundant-move.
6395
6396 2019-05-29  Tom Tromey  <tromey@adacore.com>
6397
6398         * NEWS: Add entry.
6399         * infcmd.c (print_return_value_1): Handle finish_print
6400         option.
6401         (show_print_finish): New function.
6402         (_initialize_infcmd): Add "set/show print finish" commands.
6403         * valprint.c (user_print_options): Initialize new member.
6404         * valprint.h (struct value_print_options) <finish_print>: New
6405         member.
6406
6407 2019-05-28  Tom Tromey  <tromey@adacore.com>
6408
6409         * ada-lang.c (ada_remove_Xbn_suffix)
6410         (find_old_style_renaming_symbol)
6411         (parse_old_style_renaming): Remove.
6412         (ada_find_renaming_symbol): Don't call
6413         find_old_style_renaming_symbol.
6414         (ada_is_renaming_symbol): Rename from
6415         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6416         bool.  Now static.
6417         (ada_read_var_value): Update and simplify.
6418         * ada-exp.y (write_var_or_type): Remove old code.
6419
6420 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6421
6422         * event-top.c: Remove include comment.
6423         * inflow.c (class scoped_ignore_sigttou): Move from here...
6424         * inflow.h (class scoped_ignore_sigttou): ...to here.
6425         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6426         * top.c:  Remove include comment.
6427
6428 2019-05-27  Tom Tromey  <tom@tromey.com>
6429
6430         * NEWS: Fix typo.
6431
6432 2019-05-22  Tom Tromey  <tromey@adacore.com>
6433
6434         * target.c (target_follow_exec): Constify parameter.
6435         * target-delegates.c: Rebuild.
6436         * remote.c (remote_target::follow_exec): Constify parameter.
6437         * infrun.c (follow_exec): Constify parameter.
6438         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6439         (target_follow_exec): Likewise.
6440
6441 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6442
6443         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6444         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6445
6446 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6447
6448         * NEWS: Add debugredirect and testsuite sections.
6449
6450 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6451
6452         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6453         target descriptions using exclusively floating point register name
6454         aliases.
6455
6456 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6457
6458         PR gdb/18644:
6459         * f-lang.c (build_fortran_types): Handle the case where
6460         gdbarch_floatformat_for_type returns a nullptr.
6461
6462 2019-05-21  Tom de Vries  <tdevries@suse.de>
6463
6464         PR cli/24587
6465         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6466
6467 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6468
6469         PR gdb/18644:
6470         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6471         16-byte floats.
6472         * i386-tdep.c (i386_floatformat_for_type): Use
6473         floatformats_ia64_quad for the 16-byte floating point component
6474         within a fortran 32-byte complex number.
6475
6476 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6477
6478         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6479         delete default constructor.
6480         (find_partial_die): Update to return const struct.
6481         (partial_die_parent_scope): Move variable declaration into scope
6482         of its use and change its type to auto.
6483         (guess_partial_die_structure_name): Likewise.
6484         (partial_die_info::fixup): Likewise.
6485
6486 2019-05-17  Tom Tromey  <tromey@adacore.com>
6487
6488         * source.c (find_and_open_source): Remove cast.
6489
6490 2019-05-17  Tom Tromey  <tromey@adacore.com>
6491
6492         * annotate.c (annotate_source): Make "filename" const.
6493         * annotate.h (annotate_source): Use const.
6494
6495 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6496
6497         * disasm.c (set_disassembler_options): Send errors to stderr.
6498
6499 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6500
6501         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6502         (cli_interp_base::set_logging): Check debug_redirect.
6503         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6504         * cli/cli-logging.c (debug_redirect): Add static variable.
6505         (pop_output_files): Add default param.
6506         (handle_redirections): Print debug setting.
6507         (show_logging_command): Likewise.
6508         (_initialize_cli_logging): Add debugredirect command.
6509         * interps.c (current_interp_set_logging): Add debug_redirect
6510         parameter.
6511         * interps.h (set_logging): Add debug_redirect parameter.
6512         (current_interp_set_logging): Likewise.
6513         * mi/mi-common.h: Likewise.
6514         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6515
6516 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6517             Tom Tromey  <tromey@adacore.com>
6518
6519         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6520         directly.
6521         * cli/cli-interp.h (make_logging_output): Remove declaration.
6522         * cli/cli-logging.c (make_logging_output): Remove function.
6523         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6524         directly.
6525         * ui-file.c (tee_file::tee_file): Remove bools.
6526         (tee_file::~tee_file): Remove deletes.
6527         * ui-file.h (tee_file): Remove bools.
6528
6529 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6530
6531         * mi/mi-cmds.h (mi_cmd_complete): New function.
6532         * mi/mi-main.c (mi_cmd_complete): Likewise.
6533         * mi/mi-cmds.c: Define new MI command -complete.
6534         * NEWS: Mention new -complete command.
6535
6536 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6537
6538         * completer.h (complete): New function.
6539         * completer.c (complete): Likewise.
6540         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6541         function defined in completer.h.
6542
6543 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6544
6545         * MAINTAINERS (Write After Approval): Add myself.
6546
6547 2019-05-17  Tom de Vries  <tdevries@suse.de>
6548
6549         PR gdb/24094
6550         * dwarf2read.c (struct cu_partial_die_info): New struct.
6551         (find_partial_die): Return cu_partial_die_info.
6552         (partial_die_parent_scope, guess_partial_die_structure_name)
6553         (partial_die_info::fixup): Handle new return type of find_partial_die.
6554
6555 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6556
6557         PR breakpoints/24541
6558         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6559         "std::string", simplifying the algorithm.
6560
6561 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6562
6563         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6564         (stap_static_probe_ops::get_probes): Likewise.
6565
6566 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6567
6568         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6569         '-')" and "else if".
6570         (stap_parse_single_operand): Join checks for
6571         "gdbarch_stap_parse_special_token_p" and
6572         "gdbarch_stap_parse_special_token" in the same "if" statement.
6573         Invert check when verifying for operation on register
6574         displacement.
6575
6576 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6577
6578         * stap-probe.c (stap_get_opcode): Update comment.
6579         (stap_get_expected_argument_type): Likewise.
6580         (handle_stap_probe): Likewise.
6581
6582 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6583
6584         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6585         return type to 'bool'.  Adjust comment.  Use 'bool' when
6586         appropriate.
6587         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6588         * stap-probe.c (stap_parse_argument_1): Likewise.
6589         (stap_is_operator): Likewise.
6590         (stap_is_generic_prefix): Likewise.
6591         (stap_is_register_prefix): Likewise.
6592         (stap_is_register_indirection_prefix): Likewise.
6593         (stap_is_integer_prefix): Likewise.
6594         (stap_generic_check_suffix): Likewise.
6595         (stap_check_integer_suffix): Likewise.
6596         (stap_check_register_suffix): Likewise.
6597         (stap_check_register_indirection_suffix): Likewise.
6598         (stap_parse_register_operand): Likewise.
6599         (stap_parse_single_operand): Likewise.
6600         (stap_parse_argument_1): Likewise.
6601         (stap_probe::get_argument_count): Likewise.
6602         (stap_is_operator): Likewise.
6603
6604 2019-05-16  Tom Tromey  <tromey@adacore.com>
6605
6606         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6607         keyword to foreach.
6608
6609 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6610
6611         * linux-thread-db.c (try_thread_db_load_1): Change return type
6612         to bool.
6613         (try_thread_db_load): Likewise.
6614         (try_thread_db_load_from_pdir_1): Likewise.
6615         (try_thread_db_load_from_pdir): Likewise.
6616         (try_thread_db_load_from_sdir): Likewise.
6617         (try_thread_db_load_from_dir): Likewise.
6618         (thread_db_load_search): Likewise.
6619         (has_libpthread): Likewise.
6620         (thread_db_load): Likewise.
6621
6622 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6623
6624         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6625         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6626         NULL, and complain/return if that's the case.
6627
6628 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6629
6630         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6631         (advance, posn, abstract_read_memory): New functions.
6632         [struct mem_read_abstraction]: New struct.
6633         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6634
6635 2019-05-14  Tom Tromey  <tromey@adacore.com>
6636
6637         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6638         value is not lval_memory.
6639
6640 2019-05-14  Tom Tromey  <tromey@adacore.com>
6641
6642         * solib.c (info_sharedlibrary_command): Style the file name.
6643
6644 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6645
6646         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6647         (aarch64_vnv_type): Likewise.
6648         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6649         * common/tdesc.c: Likewise.
6650         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6651         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6652         * features/aarch64-fpu.xml: Add ieee half view.
6653         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6654         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6655         * gdbtypes.h (struct builtin_type): Likewise.
6656         (struct objfile_type): Likewise.
6657
6658 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6659
6660         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6661         typo.
6662         * location.h (string_to_event_location): Likewise.
6663
6664 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6665
6666         GDB 8.3 released.
6667
6668 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6669
6670         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6671         New variable declaration.
6672         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6673         New variable.
6674         (print_one_breakpoint): Use ui_out::test_flags and new global
6675         variable to compute use_fixed_output.
6676         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6677         Remove.
6678         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6679         (mi_multi_location_breakpoint_output_fixed): Remove.
6680         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6681         new variable.
6682         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6683         fix_multi_location_breakpoint_output flag if version >= 3.
6684         * ui-out.h (enum ui_out_flag)
6685         <fix_multi_location_breakpoint_output>: New enumerator.
6686
6687 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6688
6689         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6690
6691 2019-05-10  Tom Tromey  <tromey@adacore.com>
6692
6693         * ada-lang.c (catch_ada_completer): New function.
6694         (_initialize_ada_language): Use it.
6695
6696 2019-05-10  Tom Tromey  <tromey@adacore.com>
6697
6698         * thread.c (print_thread_info): Make "requested_threads" const.
6699         * gdbthread.h (print_thread_info): Make "requested_threads"
6700         const.
6701         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6702         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6703
6704 2019-05-08  Tom Tromey  <tom@tromey.com>
6705
6706         * gdbtypes.c (objfile_type_data): Change type.
6707         (objfile_type, _initialize_gdbtypes): Update.
6708
6709 2019-05-08  Tom Tromey  <tom@tromey.com>
6710
6711         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6712         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6713         (_initialize_dwarf2_frame): Update.
6714
6715 2019-05-08  Tom Tromey  <tom@tromey.com>
6716
6717         * objc-lang.c (objc_objfile_data): Change type.
6718         (find_methods): Update.
6719         (_initialize_objc_lang): Remove.
6720
6721 2019-05-08  Tom Tromey  <tom@tromey.com>
6722
6723         * stabsread.c (rs6000_builtin_type_data): Change type.
6724         (rs6000_builtin_type, _initialize_stabsread): Update.
6725
6726 2019-05-08  Tom Tromey  <tom@tromey.com>
6727
6728         * mips-tdep.c (mips_pdr_data): Remove.
6729         (_initialize_mips_tdep): Update.
6730
6731 2019-05-08  Tom Tromey  <tom@tromey.com>
6732
6733         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6734         (hppa_init_objfile_priv_data, read_unwind_info)
6735         (find_unwind_entry, _initialize_hppa_tdep): Update.
6736
6737 2019-05-08  Tom Tromey  <tom@tromey.com>
6738
6739         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6740         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6741         on obstack.
6742         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6743
6744 2019-05-08  Tom Tromey  <tom@tromey.com>
6745
6746         * mdebugread.c (basic_type_data): Change type.
6747         (basic_type, _initialize_mdebugread): Update.
6748
6749 2019-05-08  Tom Tromey  <tom@tromey.com>
6750
6751         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6752
6753 2019-05-08  Tom Tromey  <tom@tromey.com>
6754
6755         * nto-tdep.c (nto_inferior_data_reg): Change type.
6756         (nto_inferior_data): Update.
6757         (nto_inferior_data_cleanup, nto_new_inferior_data)
6758         (_initialize_nto_tdep): Remove.
6759         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6760
6761 2019-05-08  Tom Tromey  <tom@tromey.com>
6762
6763         * ada-lang.c (struct ada_inferior_data): Add initializers.
6764         (ada_inferior_data): Change type.
6765         (ada_inferior_data_cleanup): Remove.
6766         (get_ada_inferior_data, ada_inferior_exit)
6767         (struct ada_pspace_data): Add initializers, destructor.
6768         (ada_pspace_data_handle): Change type.
6769         (get_ada_pspace_data): Update.
6770         (ada_pspace_data_cleanup): Remove.
6771
6772 2019-05-08  Tom Tromey  <tom@tromey.com>
6773
6774         * coffread.c (struct coff_symfile_info): Add initializers.
6775         (coff_objfile_data_key): Move lower.  Change type.
6776         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6777         Update.
6778         (coff_free_info): Remove.
6779
6780 2019-05-08  Tom Tromey  <tom@tromey.com>
6781
6782         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6783         (fbsd_pspace_data_handle): Move lower.  Change type.
6784         (get_fbsd_pspace_data): Update.
6785         (fbsd_pspace_data_cleanup): Remove.
6786         (_initialize_fbsd_tdep): Update.
6787
6788 2019-05-08  Tom Tromey  <tom@tromey.com>
6789
6790         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6791         (get_ada_tasks_pspace_data): Update.
6792         (ada_tasks_pspace_data_cleanup): Remove.
6793         (_initialize_tasks): Update.
6794         (ada_tasks_inferior_data_handle): Change type.
6795         (get_ada_tasks_inferior_data): Update.
6796         (ada_tasks_inferior_data_cleanup): Remove.
6797         (struct ada_tasks_pspace_data): Add initializers.
6798
6799 2019-05-08  Tom Tromey  <tom@tromey.com>
6800
6801         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6802         * symfile-debug.c (debug_sym_get_probes): Change type.
6803         * stap-probe.c (handle_stap_probe):
6804         (stap_static_probe_ops::get_probes): Change type.
6805         * probe.h (class static_probe_ops) <get_probes>: Change type.
6806         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6807         (parse_probes_in_pspace): Update.
6808         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6809         Update.
6810         (any_static_probe_ops::get_probes): Change type.
6811         * elfread.c (elfread_data): New typedef.
6812         (probe_key): Change type.
6813         (elf_get_probes): Likewise.  Update.
6814         (probe_key_free): Remove.
6815         (_initialize_elfread): Update.
6816         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6817         Change type.
6818         (dtrace_process_dof_probe, dtrace_process_dof)
6819         (dtrace_static_probe_ops::get_probe): Change type.
6820
6821 2019-05-08  Tom Tromey  <tom@tromey.com>
6822
6823         * xcoffread.c (struct xcoff_symfile_info): Rename from
6824         coff_symfile_info.  Add initializers.
6825         (xcoff_objfile_data_key): Move lower.  Change type.
6826         (XCOFF_DATA): Rewrite.
6827         (xcoff_free_info): Remove.
6828         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6829         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6830         (xcoff_initial_scan): Update.
6831
6832 2019-05-08  Tom Tromey  <tom@tromey.com>
6833
6834         * solib-svr4.c (struct svr4_info): Add initializers and
6835         destructor.
6836         <probes_table>: Now an htab_up.
6837         (solib_svr4_pspace_data): Change type.
6838         (free_probes_table): Simplify.
6839         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6840         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6841         (probes_table_remove_objfile_probes, register_solib_event_probe)
6842         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6843         (_initialize_svr4_solib): Update.
6844
6845 2019-05-08  Tom Tromey  <tom@tromey.com>
6846
6847         * remote.c (remote_pspace_data): Change type.
6848         (remote_pspace_data_cleanup): Remove.
6849         (get_remote_exec_file, set_pspace_remote_exec_file)
6850         (_initialize_remote): Update.
6851
6852 2019-05-08  Tom Tromey  <tom@tromey.com>
6853
6854         * breakpoint.c (breakpoint_objfile_key): Change type.
6855         (get_breakpoint_objfile_data): Update.
6856         (free_breakpoint_objfile_data): Remove.
6857         (_initialize_breakpoint): Update.
6858
6859 2019-05-08  Tom Tromey  <tom@tromey.com>
6860
6861         * linux-tdep.c (struct linux_info): Add initializers.
6862         (linux_inferior_data): Move.  Change type.
6863         (invalidate_linux_cache_inf): Update.
6864         (linux_inferior_data_cleanup): Remove.
6865         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6866
6867 2019-05-08  Tom Tromey  <tom@tromey.com>
6868
6869         * auxv.c (auxv_inferior_data): Move.  Change type.
6870         (auxv_inferior_data_cleanup): Remove.
6871         (invalidate_auxv_cache_inf): Rewrite.
6872         (get_auxv_inferior_data, _initialize_auxv): Update.
6873
6874 2019-05-08  Tom Tromey  <tom@tromey.com>
6875
6876         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6877         (symfile_debug_objfile_data_key): Change type.
6878         (symfile_debug_installed, debug_qf_has_symbols)
6879         (debug_qf_find_last_source_symtab)
6880         (debug_qf_forget_cached_source_info)
6881         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6882         (debug_qf_print_stats, debug_qf_dump)
6883         (debug_qf_expand_symtabs_for_function)
6884         (debug_qf_expand_all_symtabs)
6885         (debug_qf_expand_symtabs_with_fullname)
6886         (debug_qf_map_matching_symbols)
6887         (debug_qf_expand_symtabs_matching)
6888         (debug_qf_find_pc_sect_compunit_symtab)
6889         (debug_qf_map_symbol_filenames)
6890         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6891         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6892         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6893         (debug_sym_read_linetable, debug_sym_relocate): Update.
6894         (symfile_debug_free_objfile): Remove.
6895         (install_symfile_debug_logging, _initialize_symfile_debug):
6896         Update.
6897
6898 2019-05-08  Tom Tromey  <tom@tromey.com>
6899
6900         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6901         allocate_on_obstack.
6902         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6903         (get_dwarf2_per_objfile): Update.
6904         (set_dwarf2_per_objfile): Remove.
6905         (dwarf2_has_info, dwarf2_get_section_info): Update.
6906         (dwarf2_free_objfile): Remove.
6907         (_initialize_dwarf2_read): Update.
6908
6909 2019-05-08  Tom Tromey  <tom@tromey.com>
6910
6911         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6912         initializers.
6913         <unsupported_script_warning_printed,
6914         script_not_found_warning_printed>: Now bool.
6915         (auto_load_pspace_data): Change type.
6916         (~auto_load_pspace_info): Rename from
6917         auto_load_pspace_data_cleanup.
6918         (get_auto_load_pspace_data, init_loaded_scripts_info)
6919         (clear_section_scripts, maybe_print_unsupported_script_warning)
6920         (maybe_print_script_not_found_warning, _initialize_auto_load):
6921         Update.
6922
6923 2019-05-08  Tom Tromey  <tom@tromey.com>
6924
6925         * objfiles.c (objfile_pspace_info): Add destructor and
6926         initializers.
6927         (objfiles_pspace_data): Change type.
6928         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6929         (get_objfile_pspace_data): Update.
6930         (objfiles_bfd_data): Change type.
6931         (get_objfile_bfd_data): Update.
6932         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6933
6934 2019-05-08  Tom Tromey  <tom@tromey.com>
6935
6936         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6937         Change type.
6938         (get_catch_syscall_inferior_data): Update.
6939         (catch_syscall_inferior_data_cleanup): Remove.
6940         (_initialize_break_catch_syscall): Update.
6941
6942 2019-05-08  Tom Tromey  <tom@tromey.com>
6943
6944         * inflow.c (struct terminal_info): Add destructor and
6945         initializers.
6946         (inflow_inferior_data): Change type.
6947         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6948         (get_inflow_inferior_data, inflow_inferior_exit)
6949         (swap_terminal_info, _initialize_inflow): Update.
6950
6951 2019-05-08  Tom Tromey  <tom@tromey.com>
6952
6953         * target-dcache.c (target_dcache_cleanup): Remove.
6954         (target_dcache_aspace_key): Change type.
6955         (target_dcache_init_p, target_dcache_invalidate)
6956         (target_dcache_get, target_dcache_get_or_init)
6957         (_initialize_target_dcache): Update.
6958         * dcache.h (struct dcache_deleter): New.
6959
6960 2019-05-08  Tom Tromey  <tom@tromey.com>
6961
6962         * symtab.c (struct symbol_cache): Add destructor and
6963         initializers.
6964         (symbol_cache_key): Move.  Change type.
6965         (make_symbol_cache, free_symbol_cache): Remove.
6966         (get_symbol_cache): Update.
6967         (symbol_cache_cleanup): Remove.
6968         (ALL_PSPACES, symbol_cache_flush)
6969         (maintenance_print_symbol_cache)
6970         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6971         Update.
6972
6973 2019-05-08  Tom Tromey  <tom@tromey.com>
6974
6975         * symtab.c (struct main_info): Add destructor and initializers.
6976         (main_progspace_key): Move.  Change type.
6977         (get_main_info): Update.
6978         (main_info_cleanup): Remove.
6979         (_initialize_symtab): Update.
6980
6981 2019-05-08  Tom Tromey  <tom@tromey.com>
6982
6983         * registry.h (DECLARE_REGISTRY): Define the _key class.
6984
6985 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6986
6987         * NEWS: Merge two 'New commands' sections.
6988
6989 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6990
6991         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6992         parameter and use Ada language definition instead.
6993         (ada_val_print_ptr): Remove unused language parameter.
6994         (ada_val_print_num): Remove language parameter and use Ada language
6995         definition instead.
6996         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6997         parameter.
6998         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6999         parameter and use Ada language definition instead.
7000         (ada_val_print_1): Update all ada_val_print_xxx calls.
7001         Remove language parameter.
7002         (ada_val_print): Update ada_val_print_1 call.
7003
7004 2019-05-08  Tom Tromey  <tromey@adacore.com>
7005
7006         * remote.c (remote_hw_watchpoint_limit)
7007         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7008         Now static.
7009
7010 2019-05-08  Tom Tromey  <tromey@adacore.com>
7011
7012         * maint.c (_initialize_maint_cmds): Move initialization code to
7013         remote.c.
7014         (watchdog, show_watchdog): Move to remote.c.
7015         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7016         "watchdog" static.
7017         (_initialize_remote): Move initialization code from maint.c.
7018         * defs.h (watchdog): Don't declare.
7019
7020 2019-05-08  Tom Tromey  <tromey@adacore.com>
7021
7022         * tui/tui-interp.c: Include main.h.
7023         * interps.c: Include main.h.
7024         * main.h (interpreter_p): Declare.
7025         * defs.h (interpreter_p): Don't declare.
7026
7027 2019-05-08  Tom Tromey  <tromey@adacore.com>
7028
7029         * dwarf2loc.c: Include dwarf2read.h.
7030         * defs.h (read_unsigned_leb128): Don't declare.
7031         * dwarf2read.h (read_unsigned_leb128): Declare.
7032
7033 2019-05-08  Tom Tromey  <tromey@adacore.com>
7034
7035         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7036         method.
7037
7038 2019-05-08  Tom Tromey  <tromey@adacore.com>
7039
7040         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7041         when no wrap column is set.
7042
7043 2019-05-08  Tom Tromey  <tromey@adacore.com>
7044
7045         * c-lang.c (c_get_string): Handle non-C-style arrays.
7046
7047 2019-05-08  Tom Tromey  <tromey@adacore.com>
7048
7049         * typeprint.c (print_offset_data::update): Print the bit offset,
7050         not the number of bits remaining.
7051
7052 2019-05-08  Tom Tromey  <tromey@adacore.com>
7053
7054         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7055         padding at end of comment.
7056
7057 2019-05-08  Tom Tromey  <tromey@adacore.com>
7058
7059         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7060         Compare main types.
7061
7062 2019-05-06  Tom Tromey  <tom@tromey.com>
7063
7064         * common/scoped_mmap.c: Include common-defs.h.
7065         * common/scoped_mmap.h: Don't include config.h.
7066
7067 2019-05-04  Tom Tromey  <tom@tromey.com>
7068
7069         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7070         (struct aarch64_call_info): Add initializers.
7071         <si>: Now a std::vector.
7072         (pass_on_stack, aarch64_push_dummy_call): Update.
7073
7074 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7075             Tom Tromey  <tom@tromey.com>
7076
7077         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7078         (ppc_threads): Now a std::vector.  Now static.
7079         (hwdebug_find_thread_points_by_tid)
7080         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7081         Update.
7082
7083 2019-05-04  Tom Tromey  <tom@tromey.com>
7084
7085         * arc-tdep.c (arc_tdesc_init): Return bool.
7086
7087 2019-05-04  Tom Tromey  <tom@tromey.com>
7088
7089         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7090         Use gdb_assert_not_reached.
7091
7092 2019-05-04  Tom Tromey  <tom@tromey.com>
7093
7094         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7095         "false".
7096
7097 2019-05-04  Tom Tromey  <tom@tromey.com>
7098
7099         * arc-tdep.c (arc_tdesc_init): Use bool.
7100
7101 2019-05-04  Tom Tromey  <tom@tromey.com>
7102
7103         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7104
7105 2019-05-04  Tom Tromey  <tom@tromey.com>
7106
7107         * cli/cli-cmds.c (valid_command_p): Return bool.
7108
7109 2019-05-04  Tom Tromey  <tom@tromey.com>
7110
7111         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7112         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7113
7114 2019-05-04  Raul Tambre  <raul@tambre.ee>
7115
7116         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7117         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7118         operator for comparison.
7119
7120 2019-05-04  Tom Tromey  <tom@tromey.com>
7121
7122         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7123         (lookup_partial_symbol, print_partial_symbols)
7124         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7125         (psymbol_compare): Update.
7126         (add_psymbol_to_bcache): Clear the entire psymbol.
7127         (maintenance_check_psymtabs): Update.
7128         * psympriv.h (struct partial_symbol): Don't derive from
7129         general_symbol_info.
7130         <obj_section, unrelocated_address, address,
7131         set_unrelocated_address>: Update.
7132         <ginfo>: New member.
7133         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7134         (debug_names::write_psymbols): Update.
7135
7136 2019-05-04  Tom de Vries  <tdevries@suse.de>
7137
7138         * contrib/cc-with-tweaks.sh: Support -n arg.
7139
7140 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7141
7142         * corelow.c (core_target::detach): Ensure frame cache and
7143         register caches are cleared.
7144         inferior.c (exit_inferior_1): Likewise.
7145
7146 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7147             Tom Tromey  <tom@tromey.com>
7148
7149         * dictionary.c (collate_pending_symbols_by_language): Remove
7150         "struct" from foreach.
7151         * symtab.c (lookup_global_symbol_from_objfile)
7152         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7153         foreach.
7154         * ser-tcp.c (net_open): Remove "struct" from foreach.
7155         * objfiles.c (objfile_relocate, objfile_rebase)
7156         (objfile_has_symbols): Remove "struct" from foreach.
7157         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7158         from foreach.
7159         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7160         foreach.
7161         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7162         "struct" from foreach.
7163         * ada-lang.c (create_excep_cond_exprs)
7164         (ada_exception_catchpoint_cond_string): Remove "struct" from
7165         foreach.
7166
7167 2019-05-03  Tom Tromey  <tromey@adacore.com>
7168
7169         * ada-exp.y (convert_char_literal): Check suffix of each
7170         enumerator.
7171
7172 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7173
7174         PR ada/21406:
7175         * ada-exp.y (yywrap): Don't define.
7176         * ada-lex.l (%option): Add noyywrap
7177         (yywrap): Remove.
7178
7179 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7180
7181         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7182         _WIN32_WINNT to the XP level, unless already defined to a higher
7183         level.
7184
7185         * unittests/parse-connection-spec-selftests.c:
7186         * ser-tcp.c:
7187         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7188         override.
7189
7190         * symfile.c (find_separate_debug_file): Remove colon from the
7191         drive spec of DOS/Windows file names of the target, so that the
7192         file name produced from DEBUGDIR and the target's directory will
7193         be valid on DOS/Windows systems.
7194
7195 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7196
7197         * rust-lang.c (val_print_struct): Handle printing structures
7198         containing strings.
7199
7200 2019-05-02  Tom Tromey  <tromey@adacore.com>
7201
7202         * valarith.c (_initialize_valarith): Remove.
7203
7204 2019-05-01  Tom Tromey  <tromey@adacore.com>
7205
7206         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7207         bitfields.
7208
7209 2019-05-01  Tom Tromey  <tromey@adacore.com>
7210
7211         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7212         for big-endian copies.
7213
7214 2019-04-30  Ali Tamur  <tamur@google.com>
7215         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7216         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7217         (read_3_bytes): New function.
7218
7219 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7220
7221         * windows-nat.c (main_thread_id): Delete.
7222         (handle_output_debug_string): Replace main_thread_id by
7223         current_event.dwThreadId.
7224         (fake_create_process): Likewise.
7225         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7226         Do not set main_thread_id.
7227         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7228         current_event.dwThreadId.
7229         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7230
7231 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7232
7233         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7234         Use current_event.dwThreadId instead of main_thread_id.
7235
7236 2019-04-30  Tom Tromey  <tromey@adacore.com>
7237
7238         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7239         (create_excep_cond_exprs): Iterate over program spaces.
7240         (ada_exception_catchpoint_cond_string): Examine all minimal
7241         symbols for exception types.
7242
7243 2019-04-30  Tom Tromey  <tromey@adacore.com>
7244
7245         PR c++/24470:
7246         * dwarf2read.c (process_structure_scope): Handle case where type
7247         has template parameters but no symbol was created.
7248
7249 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7250             Chris January  <chris.january@arm.com>
7251
7252         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7253         qualifier.
7254         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7255
7256 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7257
7258         * f-typeprint.c (f_print_type): Update rules for printing
7259         whitespace.
7260         (f_type_print_varspec_suffix): Likewise.
7261
7262 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7263             Chris January  <chris.january@arm.com>
7264
7265         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7266         function arguments.
7267
7268 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7269
7270         * f-lang.c (build_fortran_types): Change name of void type to
7271         lower case.
7272         * f-typeprint.c (f_type_print_base): Print the name of the void
7273         type, rather than a fixed string.
7274         * f-valprint.c (f_decorations): Use lower case void string.
7275
7276 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7277             Chris January  <chris.january@arm.com>
7278
7279         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7280         types for Fortran.
7281
7282 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7283             Chris January  <chris.january@arm.com>
7284             David Lecomber  <david.lecomber@arm.com>
7285
7286         * f-exp.y (BINOP_INTRINSIC): New token.
7287         (exp): New parser rule handling BINOP_INTRINSIC.
7288         (f77_keywords): Add new builtin procedures.
7289         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7290         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7291         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7292         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7293         (print_unop_subexp_f): New function.
7294         (print_binop_subexp_f): New function.
7295         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7296         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7297         (dump_subexp_body_f): Likewise.
7298         (operator_check_f): Likewise.
7299         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7300         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7301
7302 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7303
7304         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7305         UNOP_KIND.
7306         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7307         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7308         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7309         (operator_length_f): New fuction.
7310         (print_subexp_f): New function.
7311         (op_name_f): New function.
7312         (dump_subexp_body_f): New function.
7313         (operator_check_f): New function.
7314         (exp_descriptor_f): Replace standard expression handling functions
7315         with new functions.
7316         * gdb/fortran-operator.def: New file.
7317         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7318         * gdb/std-operator.def: Remove UNOP_KIND.
7319
7320 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7321
7322         * std-operator.def: Remove unbalanced, stray double quote
7323         character.
7324
7325 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7326             Chris January  <chris.january@arm.com>
7327             Daniel Everett  <daniel.everett@arm.com>
7328             Nick Forrington  <nick.forrington@arm.com>
7329             Richard Bunt  <richard.bunt@arm.com>
7330
7331         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7332         of depth when printing anonymous structs or unions.
7333         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7334         Don't print either the top-level value, or the children if the
7335         max-depth is exceeded.
7336         (ppscm_print_children): When printing the key of a map, allow one
7337         extra level of depth.
7338         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7339         print either the top-level value, or the children if the max-depth
7340         is exceeded.
7341         (print_children): When printing the key of a map, allow one extra
7342         level of depth.
7343         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7344         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7345         (user_print_options): Initialise max_depth field.
7346         (val_print_scalar_or_string_type_p): New function.
7347         (val_print): Check to see if the max depth has been reached.
7348         (val_print_check_max_depth): Define new function.
7349         (show_print_max_depth): New function.
7350         (_initialize_valprint): Add 'print max-depth' option.
7351         * valprint.h (struct value_print_options) <max_depth>: New field.
7352         (val_print_check_max_depth): Declare new function.
7353         * NEWS: Document new feature.
7354
7355 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         * ada-lang.c (ada_language_defn): Initialise new field.
7358         * c-lang.c (c_is_string_type_p): New function.
7359         (c_language_defn): Initialise new field.
7360         (cplus_language_defn): Initialise new field.
7361         (asm_language_defn): Initialise new field.
7362         (minimal_language_defn): Initialise new field.
7363         * c-lang.h (c_is_string_type_p): Declare new function.
7364         * d-lang.c (d_language_defn): Initialise new field.
7365         * f-lang.c (f_is_string_type_p): New function.
7366         (f_language_defn): Initialise new field.
7367         * go-lang.c (go_is_string_type_p): New function.
7368         (go_language_defn): Initialise new field.
7369         * language.c (default_is_string_type_p): New function.
7370         (unknown_language_defn): Initialise new field.
7371         (auto_language_defn): Initialise new field.
7372         * language.h (struct language_defn) <la_is_string_type_p>: New
7373         member variable.
7374         (default_is_string_type_p): Declare new function.
7375         * m2-lang.c (m2_language_defn): Initialise new field.
7376         * objc-lang.c (objc_language_defn): Initialise new field.
7377         * opencl-lang.c (opencl_language_defn): Initialise new field.
7378         * p-lang.c (pascal_is_string_type_p): New function.
7379         (pascal_language_defn): Initialise new field.
7380         * rust-lang.c (rust_is_string_type_p): New function.
7381         (rust_language_defn): Initialise new field.
7382
7383 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7384
7385         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7386         New field.
7387         * ada-lang.c (ada_language_defn): Initialise new field.
7388         * c-lang.c (c_language_defn): Likewise.
7389         (cplus_language_defn): Likewise.
7390         (asm_language_defn): Likewise.
7391         (minimal_language_defn): Likewise.
7392         * d-lang.c (d_language_defn): Likewise.
7393         * f-lang.c (f_language_defn): Likewise.
7394         * go-lang.c (go_language_defn): Likewise.
7395         * language.c (unknown_language_defn): Likewise.
7396         (auto_language_defn): Likewise.
7397         * m2-lang.c (m2_language_defn): Likewise.
7398         * objc-lang.c (objc_language_defn): Likewise.
7399         * opencl-lang.c (opencl_language_defn): Likewise.
7400         * p-lang.c (pascal_language_defn): Likewise.
7401         * rust-lang.c (rust_language_defn): Likewise.
7402
7403 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7404
7405         * ada-lang.c (ada_is_character_type): Change return type to bool.
7406         (ada_is_string_type): Likewise.
7407         * ada-lang.h (ada_is_character_type): Update declaration
7408         (ada_is_string_type): Likewise.
7409
7410 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7411
7412         Support style in 'frame|thread apply'
7413
7414         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7415         * record.c (record_start, record_stop): Update callers of
7416         execute_command_to_string with false.
7417         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7418         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7419         methods.
7420         (class string_file): New constructor with term_out parameter.
7421         Override methods term_out and can_emit_style_escape.  New member
7422         term_out.
7423         (class stdio_file): Override can_emit_style_escape.
7424         (class tee_file): Override term_out and can_emit_style_escape.
7425         * utils.h (can_emit_style_escape): Remove.
7426         * utils.c (can_emit_style_escape): Likewise.
7427         Update all callers of can_emit_style_escape (SOMESTREAM) to
7428         SOMESTREAM->can_emit_style_escape.
7429         * source-cache.c (source_cache::get_source_lines): Likewise.
7430         * stack.c (frame_apply_command_count): Call execute_command_to_string
7431         passing the term_out characteristic of the current gdb_stdout.
7432         * thread.c (thr_try_catch_cmd): Likewise.
7433         * top.c (execute_command_to_string): pass term_out parameter
7434         to construct the string_file for the command output.
7435         * ui-file.c (term_cli_styling): New function (most code moved
7436         from utils.c can_emit_style_escape).
7437         (string_file::string_file, string_file::can_emit_style_escape,
7438         stdio_file::can_emit_style_escape, tee_file::term_out,
7439         tee_file::can_emit_style_escape): New functions.
7440
7441 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7442
7443         * NEWS: Mention the new set|show may-call-functions.
7444         * infcall.c (may_call_functions_p): New variable.
7445         (show_may_call_functions_p): New function.
7446         (call_function_by_hand_dummy): Throws an error if not
7447         may-call-functions.
7448         (_initialize_infcall): Call add_setshow_boolean_cmd for
7449         may-call-functions.
7450
7451 2019-04-25  Keith Seitz  <keiths@redhat.com>
7452
7453         PR c++/24367
7454         * cp-support.c (inspect_type): Don't attempt substitutions
7455         of symbol with the same name.
7456
7457 2019-04-25  Tom Tromey  <tromey@adacore.com>
7458
7459         PR gdb/24475:
7460         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7461         static.
7462
7463 2019-04-25  Tom Tromey  <tromey@adacore.com>
7464
7465         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7466         rvalue reference.
7467         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7468         (gdb_xml_parser::parse): Use std::move.
7469         * python/python-internal.h (gdbpy_convert_exception): Take a const
7470         reference.
7471         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7472         std::move.
7473         * python/py-utils.c (gdbpy_convert_exception): Take a const
7474         reference.
7475         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7476         Use std::move.
7477         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7478         Use std::move.
7479         * mi/mi-main.c (mi_print_exception): Take a const reference.
7480         * main.c (handle_command_errors): Take a const reference.
7481         * linespec.c (parse_linespec): Use std::move.
7482         * infcall.c (run_inferior_call): Use std::move.
7483         (call_function_by_hand_dummy): Use std::move.
7484         * exec.c (try_open_exec_file): Use std::move.
7485         * exceptions.h (exception_print, exception_fprintf)
7486         (exception_print_same): Update.
7487         * exceptions.c (print_exception, exception_print)
7488         (exception_fprintf, exception_print_same): Change parameters to
7489         const reference.
7490         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7491         * common/new-op.c: Use std::move.
7492         * common/common-exceptions.h (struct gdb_exception): Add move
7493         constructor.
7494         (struct gdb_exception_error, struct gdb_exception_quit, struct
7495         gdb_quit_bad_alloc): Change constructor to move constructor.
7496         (throw_exception): Change parameter to rvalue reference.
7497         * common/common-exceptions.c (throw_exception): Take rvalue
7498         reference.
7499         * cli/cli-interp.c (safe_execute_command): Use std::move.
7500         * breakpoint.c (insert_bp_location, location_to_sals): Use
7501         std::move.
7502
7503 2019-04-25  Tom Tromey  <tromey@adacore.com>
7504
7505         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7506         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7507         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7508         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7509         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7510         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7511         guile/scm-value.c: Use unpack.
7512         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7513         gdbscm_gdb_exception.
7514         (gdbscm_throw_gdb_exception): Likewise.
7515         (struct gdbscm_gdb_exception): New.
7516         (unpack): New function.
7517         (gdbscm_wrap): Use unpack.
7518
7519 2019-04-25  Tom Tromey  <tromey@adacore.com>
7520
7521         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7522         (gdb_rl_callback_handler): Use std::move.
7523         * common/common-exceptions.h (struct gdb_exception): Add move
7524         assignment operator.
7525         (throw_exception_sjlj): Change "exception" to const reference.
7526         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7527         (throw_exception_sjlj): Change "exception" to const reference.
7528
7529 2019-04-25  Tom Tromey  <tromey@adacore.com>
7530
7531         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7532         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7533         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7534         Update.
7535         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7536         Update.
7537         * mi/mi-interp.c (mi_interp::exec): Update.
7538         * linespec.c (parse_linespec): Update.
7539         * infcall.c (run_inferior_call): Update.
7540         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7541         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7542         (gdbscm_lookup_global_symbol): Update.
7543         * guile/scm-param.c (gdbscm_parameter_value): Update.
7544         * guile/scm-frame.c (gdbscm_frame_read_register)
7545         (gdbscm_frame_read_var): Update.
7546         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7547         * exec.c (try_open_exec_file): Update.
7548         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7549         (gdb_rl_callback_handler): Update.
7550         * common/common-exceptions.h (exception_none): Don't declare.
7551         * common/common-exceptions.c (exception_none): Don't define.
7552         (struct catcher) <exception>: Update.
7553         * cli/cli-interp.c (safe_execute_command): Update.
7554         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7555
7556 2019-04-25  Ali Tamur  <tamur@google.com>
7557
7558         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7559         (read_attribute_value): Likewise.
7560         (dwarf2_read_addr_index): Update comment.
7561         (read_str_index): Add DW_FORM_strx.
7562         (dwarf2_string_attr): Likewise.
7563         (dwarf2_const_value_attr): Likewise.
7564         (dump_die_shallow): Likewise.
7565         (dwarf2_fetch_constant_bytes): Likewise.
7566         (skip_form_bytes): Likewise.
7567         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7568
7569 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7570
7571         PR corefiles/11608
7572         PR corefiles/18187
7573         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7574         OFFSET.  Verify if current mapping contains an ELF header.
7575         (linux_find_memory_regions_full): Adjust call to
7576         dump_mapping_p.
7577
7578 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7579             Kang Li <kanglictf@gmail.com>
7580
7581         PR gdb/21600
7582
7583         * dwarf2-frame.c (read_initial_length): Be consistent about using
7584         unsigned representation of length.
7585         (decode_frame_entry_1): Likewise.  Check for wraparound of
7586         end pointer as well as buffer overflow.
7587
7588 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7589
7590         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7591         "vq".
7592
7593 2019-04-24  Tom Tromey  <tromey@adacore.com>
7594
7595         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7596
7597 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7598
7599         * s12z-tdep.c (s12z_unwind_pc): Delete.
7600         (s12z_unwind_sp): Delete.
7601         (s12z_gdbarch_init): Don't register deleted functions with
7602         gdbarch.
7603
7604 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7605
7606         * rl78-tdep.c (rl78_unwind_sp): Delete.
7607         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7608
7609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7610
7611         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7612         (xstormy16_unwind_pc): Delete.
7613         (xstormy16_dummy_id): Delete.
7614         (xstormy16_gdbarch_init): Don't register deleted functions with
7615         gdbarch.
7616
7617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7618
7619         * vax-tdep.c (vax_unwind_pc): Delete.
7620         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7621
7622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7623
7624         * v850-tdep.c (v850_unwind_sp): Delete.
7625         (v850_unwind_pc): Delete.
7626         (v850_dummy_id): Delete.
7627         (v850_gdbarch_init): Don't register deleted functions with
7628         gdbarch.
7629
7630 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7631
7632         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7633         (tilegx_unwind_pc): Delete.
7634         (tilegx_unwind_dummy_id): Delete.
7635         (tilegx_gdbarch_init): Don't register deleted functions with
7636         gdbarch.
7637
7638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7639
7640         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7641         (tic6x_dummy_id): Delete.
7642         (tic6x_gdbarch_init): Don't register deleted functions with
7643         gdbarch.
7644
7645 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7646
7647         * sparc-tdep.c (sparc_unwind_pc): Delete.
7648         (sparc32_gdbarch_init): Don't register deleted function with
7649         gdbarch.
7650
7651 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7652
7653         * sh-tdep.c (sh_unwind_sp): Delete.
7654         (sh_unwind_pc): Delete.
7655         (sh_dummy_id): Delete.
7656         (sh_gdbarch_init): Don't register deleted functions with
7657         gdbarch.
7658
7659 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7660
7661         * score-tdep.c (score_unwind_sp): Delete.
7662         (score_unwind_pc): Delete.
7663         (score_dummy_id): Delete.
7664         (score_gdbarch_init): Don't register deleted functions with
7665         gdbarch.
7666
7667 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7668
7669         * rx-tdep.c (rx_unwind_pc): Delete.
7670         (rx_unwind_sp): Delete.
7671         (rx_dummy_id): Delete.
7672         (rx_gdbarch_init): Don't register deleted functions with
7673         gdbarch.  Update comment.
7674
7675 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7676
7677         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7678         (rs6000_dummy_id): Delete.
7679         (rs6000_gdbarch_init): Don't register deleted functions with
7680         gdbarch.
7681
7682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7683
7684         * or1k-tdep.c (or1k_dummy_id): Delete.
7685         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7686
7687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7688
7689         * nios2-tdep.c (nios2_dummy_id): Delete.
7690         (nios2_unwind_sp): Delete.
7691         (nios2_gdbarch_init): Don't register deleted functions with
7692         gdbarch.
7693
7694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7695
7696         * nds32-tdep.c (nds32_dummy_id): Delete.
7697         (nds32_unwind_pc): Delete.
7698         (nds32_unwind_sp): Delete.
7699         (nds32_gdbarch_init): Don't register deleted functions with
7700         gdbarch.
7701
7702 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7703
7704         * msp430-tdep.c (msp430_unwind_pc): Delete.
7705         (msp430_unwind_sp): Delete.
7706         (msp430_dummy_id): Delete.
7707         (msp430_gdbarch_init): Don't register deleted functions with
7708         gdbarch.
7709
7710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7711
7712         * moxie-tdep.c (moxie_unwind_sp): Delete.
7713         (moxie_unwind_pc): Delete.
7714         (moxie_dummy_id): Delete.
7715         (moxie_gdbarch_init): Don't register deleted functions with
7716         gdbarch.
7717
7718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7719
7720         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7721         (mn10300_unwind_pc): Delete.
7722         (mn10300_unwind_sp): Delete.
7723         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7724         mn10300_unwind_sp.
7725         (mn10300_frame_unwind_init): Don't register deleted functions with
7726         gdbarch.
7727
7728 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7729
7730         * mep-tdep.c (mep_unwind_pc): Delete.
7731         (mep_unwind_sp): Delete.
7732         (mep_dummy_id): Delete.
7733         (mep_gdbarch_init): Don't register deleted functions with
7734         gdbarch.
7735
7736 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7737
7738         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7739         (m68hc11_unwind_sp): Delete.
7740         (m68hc11_gdbarch_init): Don't register deleted functions with
7741         gdbarch.
7742
7743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7744
7745         * m32r-tdep.c (m32r_unwind_sp): Delete.
7746         (m32r_unwind_pc): Delete.
7747         (m32r_dummy_id): Delete.
7748         (m32r_gdbarch_init): Don't register deleted functions with
7749         gdbarch.
7750
7751 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7752
7753         * m32c-tdep.c (m32c_unwind_pc): Delete.
7754         (m32c_unwind_sp): Delete.
7755         (m32c_dummy_id): Delete.
7756         (m32c_gdbarch_init): Don't register deleted functions with
7757         gdbarch.
7758
7759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7762         (lm32_unwind_pc): Delete.
7763         (lm32_dummy_id): Delete.
7764         (lm32_gdbarch_init): Don't register deleted functions with
7765         gdbarch.
7766
7767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7768
7769         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7770         (iq2000_unwind_pc): Delete.
7771         (iq2000_dummy_id): Delete.
7772         (iq2000_gdbarch_init): Don't register deleted functions with
7773         gdbarch.
7774
7775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * nds32-tdep.c (nds32_type_align): Delete.
7778         (nds32_push_dummy_call): Use type_align instead.
7779
7780 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7781
7782         * arm-tdep.c (arm_type_align): Only handle vector override case.
7783         (arm_push_dummy_call): Use type_align.
7784         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7785
7786 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7787
7788         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7789         case.
7790         (pass_on_stack): Use type_align.
7791         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7792         function.
7793
7794 2019-04-23  Tom Tromey  <tromey@adacore.com>
7795
7796         * dwarf2read.c (line_header::file_name_at): Remove unused
7797         overload.
7798
7799 2019-04-23  Tom de Vries  <tdevries@suse.de>
7800
7801         PR gdb/24438
7802         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7803         invocation.
7804
7805
7806 2019-03-27  Ali Tamur  <tamur@google.com>
7807
7808         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7809         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7810         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7811         (dwarf_expr_context::get_addr_index): Likewise
7812         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7813         (symbol_needs_eval_context::get_addr_index): Likewise
7814         (disassemble_dwarf_expression): Add DW_OP_addrx
7815         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7816         (read_cutu_die_from_dwo): Update comment
7817         (skip_one_die): Add DW_FORM_addrx
7818         (read_attribute_value): Likewise
7819         (var_decode_location): Add DW_OP_addrx
7820         (dwarf2_const_value_attr): Add DW_FORM_addrx
7821         (dump_die_shallow): Likewise
7822         (dwarf2_fetch_constant_bytes): Likewise
7823         (decode_locdesc): Add DW_OP_addrx
7824         (skip_form_bytes): Add DW_FORM_addrx
7825
7826 2019-04-22  Ali Tamur  <tamur@google.com>
7827
7828         * MAINTAINERS (Write After Approval): Add self.
7829
7830 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7831
7832         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7833         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7834         (open_symbol_file_object): Likewise.
7835         (svr4_default_sos): Add info parameter.
7836         (svr4_read_so_list): Likewise.
7837         (svr4_current_sos_direct): Adjust functions calls to pass down
7838         info.
7839         (svr4_current_sos_1): Add info parameter.
7840         (svr4_current_sos): Call get_svr4_info, pass info down to
7841         svr4_current_sos_1.
7842         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7843         get_svr4_info.
7844         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7845         get_svr4_info.
7846         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7847         to get_svr4_info.
7848         (probes_table_remove_objfile_probes): Likewise.
7849         (register_solib_event_probe): Add info parameter.
7850         (solist_update_incremental): Pass info parameter down to
7851         svr4_read_so_list.
7852         (disable_probes_interface): Add info parameter.
7853         (svr4_handle_solib_event): Pass current_program_space to
7854         get_svr4_info.  Adjust disable_probes_interface cleanup.
7855         (svr4_create_probe_breakpoints): Add info parameter, pass it
7856         down to register_solib_event_probe.
7857         (svr4_create_solib_event_breakpoints): Add info parameter,
7858         pass it down to svr4_create_probe_breakpoints.
7859         (enable_break): Pass info down to
7860         svr4_create_solib_event_breakpoints.
7861         (svr4_solib_create_inferior_hook): Pass current_program_space to
7862         get_svr4_info.
7863         (svr4_clear_solib): Likewise.
7864
7865 2019-04-22  Pedro Alves  <palves@redhat.com>
7866
7867         * solib-svr4.c (svr4_free_objfile_observer): New.
7868         (probe_and_action::objfile): New field.
7869         (probes_table_htab_remove_objfile_probes)
7870         (probes_table_remove_objfile_probes): New functions.
7871         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7872         in the new probe_and_action.  Don't store the probe in 'lookup'.
7873         (svr4_create_probe_breakpoints): Pass objfile to
7874         register_solib_event_probe.
7875         (_initialize_svr4_solib): Register a free_objfile observer.
7876
7877 2019-04-19  Tom Tromey  <tom@tromey.com>
7878
7879         * common/queue.h: Remove.
7880
7881 2019-04-19  Tom Tromey  <tom@tromey.com>
7882
7883         * event-loop.c: Don't include "common/queue.h".
7884
7885 2019-04-19  Tom Tromey  <tom@tromey.com>
7886
7887         * remote.c (remote_target): Use delete.
7888         * remote-notif.h: Include <list>, not "common/queue.h".
7889         (notif_client_p): Remove typedef.
7890         (remote_notif_state): Add constructor, destructor, initializer.
7891         <notif_queue>: Now a std::list.
7892         (remote_notif_state_xfree): Don't declare.
7893         * remote-notif.c (remote_notif_process, handle_notification)
7894         (remote_notif_state_allocate): Update.
7895         (~remote_notif_state): Rename from remote_notif_state_xfree.
7896
7897 2019-04-19  Tom Tromey  <tom@tromey.com>
7898
7899         * symfile.c (reread_symbols): Update.
7900         * objfiles.c (objfile_register_static_link)
7901         (objfile_lookup_static_link): Update
7902         (~objfile) Don't delete static_links.
7903         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7904
7905 2019-04-19  Tom Tromey  <tom@tromey.com>
7906
7907         * type-stack.h (struct type_stack) <insert>: Constify string.
7908         * type-stack.c (type_stack::insert): Constify string.
7909         * gdbtypes.h (lookup_template_type): Update.
7910         (address_space_name_to_int): Update.
7911         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7912         const.
7913         (lookup_template_type): Make name const.
7914         * c-exp.y: Update rules.
7915         (lex_one_token, classify_name, classify_inner_name)
7916         (c_print_token): Update.
7917         * p-exp.y: Update rules.
7918         (yylex): Update.
7919         * f-exp.y: Update rules.
7920         (yylex): Update.
7921         * d-exp.y: Update rules.
7922         (lex_one_token, classify_name, classify_inner_name): Update.
7923         * parse.c (write_dollar_variable, copy_name): Return std::string.
7924         * parser-defs.h (copy_name): Change return type.
7925         * m2-exp.y: Update rules.
7926         (yylex): Update.
7927         * go-exp.y (lex_one_token): Update.
7928         Update rules.
7929         (classify_unsafe_function, classify_packaged_name)
7930         (classify_name, yylex): Update.
7931
7932 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7933
7934         * configure.ac: add --enable-source-highlight switch.
7935         * configure: Regenerate.
7936         * top.c (print_gdb_version): plumb --enable-source-highlight
7937         status to "show configuration".
7938
7939 2019-04-19  Tom Tromey  <tromey@adacore.com>
7940
7941         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7942         Check ADA_TYPE_P.
7943         (empty_record, ada_template_to_fixed_record_type_1)
7944         (template_to_static_fixed_type)
7945         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7946         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7947         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7948         macros.
7949
7950 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7951
7952         PR symtab/24423:
7953         * source.c (print_source_lines_base): Advance "iter" when a
7954         control character is seen.
7955
7956 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7957
7958         * inferior.h (struct infcall_suspend_state_deleter):
7959         Catch exception in destructor to avoid crash.
7960
7961 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7962
7963         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7964         close to the add_com "shell".
7965
7966 2019-04-18  Tom Tromey  <tromey@adacore.com>
7967
7968         * process-stratum-target.h (class process_stratum_target)
7969         <stratum>: Add "final".
7970
7971 2019-04-17  Tom Tromey  <tromey@adacore.com>
7972
7973         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7974         against nullptr before use.
7975
7976 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7977
7978         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7979
7980 2019-04-17  Jim Wilson  <jimw@sifive.com>
7981             Andrew Burgess  <andrew.burgess@embecosm.com>
7982
7983         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7984         code read might fail, assume 4-byte breakpoint in that case.
7985
7986 2019-04-15  Leszek Swirski  <leszeks@google.com>
7987
7988         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7989         rather than a hand-rolled POD check when checking for forced MEMORY
7990         classification.
7991
7992 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7993
7994         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7995         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7996         function.
7997         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7998         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7999         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8000         declaration.
8001
8002 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8003
8004         * aarch64-linux-nat.c
8005         (aarch64_linux_nat_target::thread_architecture): Add override.
8006         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8007         each VQ.
8008
8009 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8010
8011         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8012
8013 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8014
8015         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8016         target types of size 96-bits, add some additional comments, and
8017         check that the builtin type we found was the correct size.
8018
8019 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8020
8021         * utils.c (prompt_for_continue): Don't restore the styling at the
8022         end, as applied_style has the wrong value.  This fixes styling in
8023         long lists of file names that are interrupted by the "Continue?"
8024         prompt.
8025
8026 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8027
8028         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8029         * c-lang.c (c_language_defn): Likewise.
8030         (cplus_language_defn): Likewise.
8031         (asm_language_defn): Likewise.
8032         (minimal_language_defn): Likewise.
8033         * d-lang.c (d_language_defn): Likewise.
8034         * f-lang.c (f_language_defn): Likewise.
8035         * go-lang.c (go_language_defn): Likewise.
8036         * language.c (unknown_language_defn): Likewise.
8037         (auto_language_defn): Likewise.
8038         * language.h (struct language_defn): Remove la_magic field.
8039         (LANG_MAGIC): Delete.
8040         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8041         * objc-lang.c (objc_language_defn): Likewise.
8042         * opencl-lang.c (opencl_language_defn): Likewise.
8043         * p-lang.c (pascal_language_defn): Likewise.
8044         * rust-lang.c (rust_language_defn): Likewise.
8045
8046 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8047
8048         * riscv-tdep.c (riscv_type_align): New function.
8049         (riscv_type_alignment): Delete.
8050         (riscv_arg_location): Use 'type_align'.
8051         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8052
8053 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8054
8055         * gdbtypes.c (type_align): A struct with no non-static fields also
8056         has alignment of 1.
8057
8058 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8059
8060         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8061         component to 0.
8062         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8063         member.
8064         (riscv_struct_info::analyse): New implementation using new
8065         analyse_inner member function.
8066         (riscv_struct_info::field_offset): New member function.
8067         (riscv_struct_info::m_offsets): New member variable.
8068         (riscv_struct_info::analyse_inner): New private member function,
8069         takes the old implementation of riscv_struct_info::analyse but
8070         extended to track field offsets.
8071         (riscv_call_arg_struct): Update the struct folding special cases
8072         to handle cases where empty C++ structs, which are non-zero
8073         length, are found.
8074         (riscv_arg_location): Initialise the length of each location, a
8075         non-zero length now indicates the location is in use.
8076         (riscv_push_dummy_call): Allow for the first location having a
8077         non-zero offset when setting up arguments.
8078         (riscv_return_value): Likewise, but for return values.
8079
8080 2019-04-11  Tom Tromey  <tromey@adacore.com>
8081
8082         * utils.c (internal_vproblem): Make "msg" const.
8083
8084 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8085
8086         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8087         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8088         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8089         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8090
8091 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8092
8093         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8094         function.
8095         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8096         of amd64_collect_native_gregset.
8097         (amd64_linux_nat_target::store_registers): Likewise.
8098
8099 2019-04-10  Tom Tromey  <tom@tromey.com>
8100
8101         * symtab.c (lookup_global_symbol_from_objfile)
8102         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8103         * objfiles.h (class separate_debug_iterator): New.
8104         (class separate_debug_range): New.
8105         (struct objfile) <separate_debug_objfiles>: New method.
8106         (objfile_separate_debug_iterate): Don't declare.
8107         * objfiles.c (separate_debug_iterator::operator++): Rename from
8108         objfile_separate_debug_iterate.
8109         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8110         iterator.
8111         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8112         iterator.
8113
8114 2019-04-10  Tom Tromey  <tom@tromey.com>
8115
8116         * symfile.c (reread_symbols): Remove old comment.
8117         * objfiles.c (free_all_objfiles): Fix a typo.
8118
8119 2019-04-10  Tom Tromey  <tom@tromey.com>
8120
8121         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8122         * minsyms.c (lookup_minimal_symbol): Use foreach.
8123         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8124         (lookup_minimal_symbol_solib_trampoline): Likewise.
8125         * symfile.c (reread_symbols): Use foreach.
8126
8127 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8128             Tom Tromey  <tromey@adacore.com>
8129
8130         PR rust/24414:
8131         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8132         (rust_lex_int_test): Change "value" to be LONGEST.
8133         (rust_lex_tests): Add test for long integer literal.
8134
8135 2019-04-09  Tom Tromey  <tromey@adacore.com>
8136
8137         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8138         to bool.
8139         (extended_remote_target::attach): Update.
8140         (remote_target::remote_notice_new_inferior): Update.
8141         (remote_target::add_current_inferior_and_thread): Update.
8142         * inferior.c (exit_inferior_1): Use "false".
8143         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8144
8145 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8146
8147         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8148         the "start" command.
8149
8150 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8151
8152         * python/py-inferior.c (infpy_thread_from_thread_handle):
8153         Adjust comments to reflect renaming of thread_from_thread_handle
8154         to thread_from_handle.  Adjust keywords.  Fix type error message.
8155         (inferior_object_methods): Add thread_from_handle.  Retain
8156         thread_from_thread_handle, but mark it as deprecated.
8157
8158 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8159
8160         * gdbthread.h (find_thread_by_handle): Revise declaration.
8161         * thread.c (find_thread_by_handle): Likewise.  Adjust
8162         implementation too.
8163         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8164         support for buffer objects as handles.
8165
8166 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8167
8168         * python/py-infthread.c (thpy_thread_handle): New function.
8169         (thread_object_methods): Register thpy_thread_handle.
8170
8171 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8172
8173         * gdbthread.h (thread_to_thread_handle): Declare.
8174         * thread.c (gdbtypes.h): Include.
8175         (thread_to_thread_handle): New function.
8176
8177         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8178         (target_thread_info_to_thread_handle): Declare.
8179         * target.c (target_thread_info_to_thread_handle): New function.
8180         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8181         * target-delegates.c: Regenerate.
8182
8183         * linux-thread-db.c (class thread_db_target): Add method
8184         thread_info_to_thread_handle.
8185         (thread_db_target::thread_info_to_thread_handle): Define.
8186         * remote.c (class remote_target): Add new method
8187         thread_info_to_thread_handle.
8188         (remote_target::thread_info_to_thread_handle): Define.
8189
8190 2019-04-08  Pedro Alves  <palves@redhat.com>
8191
8192         * common/common-exceptions.c (throw_exception): Don't create
8193         named object to throw; throw directly.
8194         (throw_it): Likewise.  Don't initialize gdb_exception::message
8195         here, with new; pass FMT and AP to the ctor instead.
8196         * common/common-exceptions.h: Include <string>.
8197         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8198         const char *, va_list)): New ctor.  Use std::make_shared.
8199         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8200         errors)): Delete.
8201         (gdb_exception_error::gdb_exception_error(enum errors, const char
8202         *, va_list)): New.
8203         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8204         Add assertion.
8205         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8206         errors)): Delete.
8207         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8208         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8209         Add assertion.
8210
8211 2019-04-08  Tom Tromey  <tom@tromey.com>
8212
8213         * valops.c (value_rtti_indirect_type): Replace throw_exception
8214         with throw.
8215         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8216         with throw.
8217         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8218         throw.
8219         * target.c (target_translate_tls_address): Replace throw_exception
8220         with throw.
8221         * stack.c (frame_apply_command_count): Replace throw_exception
8222         with throw.
8223         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8224         throw.
8225         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8226         with throw.
8227         * rs6000-tdep.c (rs6000_frame_cache)
8228         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8229         * remote.c: Replace throw_exception with throw.
8230         * record-full.c (record_full_message, record_full_wait_1)
8231         (record_full_restore): Replace throw_exception with throw.
8232         * record-btrace.c:
8233         (get_thread_current_frame_id, record_btrace_start_replaying)
8234         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8235         (cmd_record_btrace_start): Replace throw_exception with throw.
8236         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8237         throw.
8238         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8239         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8240         * linespec.c:
8241         (find_linespec_symbols): Replace throw_exception with throw.
8242         * infrun.c (displaced_step_prepare, resume): Replace
8243         throw_exception with throw.
8244         * infcmd.c (post_create_inferior): Replace throw_exception with
8245         throw.
8246         * inf-loop.c (inferior_event_handler): Replace throw_exception
8247         with throw.
8248         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8249         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8250         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8251         (get_prev_frame_always, get_frame_pc_if_available)
8252         (get_frame_address_in_block_if_available, get_frame_language):
8253         Replace throw_exception with throw.
8254         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8255         throw_exception with throw.
8256         * eval.c (fetch_subexp_value, evaluate_var_value)
8257         (evaluate_funcall, evaluate_subexp_standard): Replace
8258         throw_exception with throw.
8259         * dwarf2loc.c (call_site_find_chain)
8260         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8261         Replace throw_exception with throw.
8262         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8263         with throw.
8264         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8265         throw.
8266         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8267         * completer.c (complete_line_internal): Replace throw_exception
8268         with throw.
8269         * compile/compile-object-run.c (compile_object_run): Replace
8270         throw_exception with throw.
8271         * cli/cli-script.c (process_next_line): Replace throw_exception
8272         with throw.
8273         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8274         (btrace_enable, btrace_maint_update_pt_packets): Replace
8275         throw_exception with throw.
8276         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8277         throw_exception with throw.
8278         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8279         throw_exception with throw.
8280         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8281         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8282         * aarch64-tdep.c (aarch64_make_prologue_cache)
8283         (aarch64_make_stub_cache): Replace throw_exception with throw.
8284
8285 2019-04-08  Tom Tromey  <tom@tromey.com>
8286
8287         * common/common-exceptions.c (throw_exception): Rename from
8288         throw_exception_cxx.  Remove old copy.  Make argument const.
8289         (throw_it): Create and throw exception objects directly.
8290         * common/common-exceptions.h (throw_exception): Make argument
8291         const.
8292         (struct gdb_exception_error): Add constructor.
8293         (struct gdb_exception_quit): Add constructor.
8294
8295 2019-04-08  Tom Tromey  <tom@tromey.com>
8296
8297         * common/common-exceptions.h (exception_rethrow): Don't declare.
8298         (TRY_SJLJ): Update comment.
8299         (TRY, CATCH, END_CATCH): Remove.
8300         * common/common-exceptions.c (exception_rethrow): Remove.
8301
8302 2019-04-08  Tom Tromey  <tom@tromey.com>
8303
8304         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8305         Remove.
8306         (gdb_exception_error): Rename from
8307         gdb_exception_RETURN_MASK_ERROR.
8308         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8309         (gdb_quit_bad_alloc): Update.
8310         * aarch64-tdep.c: Update.
8311         * ada-lang.c: Update.
8312         * ada-typeprint.c: Update.
8313         * ada-valprint.c: Update.
8314         * amd64-tdep.c: Update.
8315         * arch-utils.c: Update.
8316         * break-catch-throw.c: Update.
8317         * breakpoint.c: Update.
8318         * btrace.c: Update.
8319         * c-varobj.c: Update.
8320         * cli/cli-cmds.c: Update.
8321         * cli/cli-interp.c: Update.
8322         * cli/cli-script.c: Update.
8323         * common/common-exceptions.c: Update.
8324         * common/new-op.c: Update.
8325         * common/selftest.c: Update.
8326         * compile/compile-c-symbols.c: Update.
8327         * compile/compile-cplus-symbols.c: Update.
8328         * compile/compile-object-load.c: Update.
8329         * compile/compile-object-run.c: Update.
8330         * completer.c: Update.
8331         * corelow.c: Update.
8332         * cp-abi.c: Update.
8333         * cp-support.c: Update.
8334         * cp-valprint.c: Update.
8335         * darwin-nat.c: Update.
8336         * disasm-selftests.c: Update.
8337         * dtrace-probe.c: Update.
8338         * dwarf-index-cache.c: Update.
8339         * dwarf-index-write.c: Update.
8340         * dwarf2-frame-tailcall.c: Update.
8341         * dwarf2-frame.c: Update.
8342         * dwarf2loc.c: Update.
8343         * dwarf2read.c: Update.
8344         * eval.c: Update.
8345         * event-loop.c: Update.
8346         * event-top.c: Update.
8347         * exec.c: Update.
8348         * f-valprint.c: Update.
8349         * fbsd-tdep.c: Update.
8350         * frame-unwind.c: Update.
8351         * frame.c: Update.
8352         * gdbtypes.c: Update.
8353         * gnu-v3-abi.c: Update.
8354         * guile/guile-internal.h: Update.
8355         * guile/scm-block.c: Update.
8356         * guile/scm-breakpoint.c: Update.
8357         * guile/scm-cmd.c: Update.
8358         * guile/scm-disasm.c: Update.
8359         * guile/scm-frame.c: Update.
8360         * guile/scm-lazy-string.c: Update.
8361         * guile/scm-math.c: Update.
8362         * guile/scm-param.c: Update.
8363         * guile/scm-ports.c: Update.
8364         * guile/scm-pretty-print.c: Update.
8365         * guile/scm-symbol.c: Update.
8366         * guile/scm-symtab.c: Update.
8367         * guile/scm-type.c: Update.
8368         * guile/scm-value.c: Update.
8369         * i386-linux-tdep.c: Update.
8370         * i386-tdep.c: Update.
8371         * inf-loop.c: Update.
8372         * infcall.c: Update.
8373         * infcmd.c: Update.
8374         * infrun.c: Update.
8375         * jit.c: Update.
8376         * language.c: Update.
8377         * linespec.c: Update.
8378         * linux-fork.c: Update.
8379         * linux-nat.c: Update.
8380         * linux-tdep.c: Update.
8381         * linux-thread-db.c: Update.
8382         * main.c: Update.
8383         * mi/mi-cmd-break.c: Update.
8384         * mi/mi-cmd-stack.c: Update.
8385         * mi/mi-interp.c: Update.
8386         * mi/mi-main.c: Update.
8387         * objc-lang.c: Update.
8388         * p-valprint.c: Update.
8389         * parse.c: Update.
8390         * ppc-linux-tdep.c: Update.
8391         * printcmd.c: Update.
8392         * python/py-arch.c: Update.
8393         * python/py-breakpoint.c: Update.
8394         * python/py-cmd.c: Update.
8395         * python/py-finishbreakpoint.c: Update.
8396         * python/py-frame.c: Update.
8397         * python/py-framefilter.c: Update.
8398         * python/py-gdb-readline.c: Update.
8399         * python/py-inferior.c: Update.
8400         * python/py-infthread.c: Update.
8401         * python/py-lazy-string.c: Update.
8402         * python/py-linetable.c: Update.
8403         * python/py-objfile.c: Update.
8404         * python/py-param.c: Update.
8405         * python/py-prettyprint.c: Update.
8406         * python/py-progspace.c: Update.
8407         * python/py-record-btrace.c: Update.
8408         * python/py-record.c: Update.
8409         * python/py-symbol.c: Update.
8410         * python/py-type.c: Update.
8411         * python/py-unwind.c: Update.
8412         * python/py-utils.c: Update.
8413         * python/py-value.c: Update.
8414         * python/python.c: Update.
8415         * record-btrace.c: Update.
8416         * record-full.c: Update.
8417         * remote-fileio.c: Update.
8418         * remote.c: Update.
8419         * riscv-tdep.c: Update.
8420         * rs6000-aix-tdep.c: Update.
8421         * rs6000-tdep.c: Update.
8422         * rust-exp.y: Update.
8423         * rust-lang.c: Update.
8424         * s390-tdep.c: Update.
8425         * selftest-arch.c: Update.
8426         * solib-dsbt.c: Update.
8427         * solib-frv.c: Update.
8428         * solib-spu.c: Update.
8429         * solib-svr4.c: Update.
8430         * solib.c: Update.
8431         * sparc64-linux-tdep.c: Update.
8432         * stack.c: Update.
8433         * symfile-mem.c: Update.
8434         * symmisc.c: Update.
8435         * target.c: Update.
8436         * thread.c: Update.
8437         * top.c: Update.
8438         * tracefile-tfile.c: Update.
8439         * tui/tui.c: Update.
8440         * typeprint.c: Update.
8441         * unittests/cli-utils-selftests.c: Update.
8442         * unittests/parse-connection-spec-selftests.c: Update.
8443         * valops.c: Update.
8444         * valprint.c: Update.
8445         * value.c: Update.
8446         * varobj.c: Update.
8447         * windows-nat.c: Update.
8448         * x86-linux-nat.c: Update.
8449         * xml-support.c: Update.
8450
8451 2019-04-08  Tom Tromey  <tom@tromey.com>
8452
8453         * xml-support.c: Use C++ exception handling.
8454         * x86-linux-nat.c: Use C++ exception handling.
8455         * windows-nat.c: Use C++ exception handling.
8456         * varobj.c: Use C++ exception handling.
8457         * value.c: Use C++ exception handling.
8458         * valprint.c: Use C++ exception handling.
8459         * valops.c: Use C++ exception handling.
8460         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8461         handling.
8462         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8463         * typeprint.c: Use C++ exception handling.
8464         * tui/tui.c: Use C++ exception handling.
8465         * tracefile-tfile.c: Use C++ exception handling.
8466         * top.c: Use C++ exception handling.
8467         * thread.c: Use C++ exception handling.
8468         * target.c: Use C++ exception handling.
8469         * symmisc.c: Use C++ exception handling.
8470         * symfile-mem.c: Use C++ exception handling.
8471         * stack.c: Use C++ exception handling.
8472         * sparc64-linux-tdep.c: Use C++ exception handling.
8473         * solib.c: Use C++ exception handling.
8474         * solib-svr4.c: Use C++ exception handling.
8475         * solib-spu.c: Use C++ exception handling.
8476         * solib-frv.c: Use C++ exception handling.
8477         * solib-dsbt.c: Use C++ exception handling.
8478         * selftest-arch.c: Use C++ exception handling.
8479         * s390-tdep.c: Use C++ exception handling.
8480         * rust-lang.c: Use C++ exception handling.
8481         * rust-exp.y: Use C++ exception handling.
8482         * rs6000-tdep.c: Use C++ exception handling.
8483         * rs6000-aix-tdep.c: Use C++ exception handling.
8484         * riscv-tdep.c: Use C++ exception handling.
8485         * remote.c: Use C++ exception handling.
8486         * remote-fileio.c: Use C++ exception handling.
8487         * record-full.c: Use C++ exception handling.
8488         * record-btrace.c: Use C++ exception handling.
8489         * python/python.c: Use C++ exception handling.
8490         * python/py-value.c: Use C++ exception handling.
8491         * python/py-utils.c: Use C++ exception handling.
8492         * python/py-unwind.c: Use C++ exception handling.
8493         * python/py-type.c: Use C++ exception handling.
8494         * python/py-symbol.c: Use C++ exception handling.
8495         * python/py-record.c: Use C++ exception handling.
8496         * python/py-record-btrace.c: Use C++ exception handling.
8497         * python/py-progspace.c: Use C++ exception handling.
8498         * python/py-prettyprint.c: Use C++ exception handling.
8499         * python/py-param.c: Use C++ exception handling.
8500         * python/py-objfile.c: Use C++ exception handling.
8501         * python/py-linetable.c: Use C++ exception handling.
8502         * python/py-lazy-string.c: Use C++ exception handling.
8503         * python/py-infthread.c: Use C++ exception handling.
8504         * python/py-inferior.c: Use C++ exception handling.
8505         * python/py-gdb-readline.c: Use C++ exception handling.
8506         * python/py-framefilter.c: Use C++ exception handling.
8507         * python/py-frame.c: Use C++ exception handling.
8508         * python/py-finishbreakpoint.c: Use C++ exception handling.
8509         * python/py-cmd.c: Use C++ exception handling.
8510         * python/py-breakpoint.c: Use C++ exception handling.
8511         * python/py-arch.c: Use C++ exception handling.
8512         * printcmd.c: Use C++ exception handling.
8513         * ppc-linux-tdep.c: Use C++ exception handling.
8514         * parse.c: Use C++ exception handling.
8515         * p-valprint.c: Use C++ exception handling.
8516         * objc-lang.c: Use C++ exception handling.
8517         * mi/mi-main.c: Use C++ exception handling.
8518         * mi/mi-interp.c: Use C++ exception handling.
8519         * mi/mi-cmd-stack.c: Use C++ exception handling.
8520         * mi/mi-cmd-break.c: Use C++ exception handling.
8521         * main.c: Use C++ exception handling.
8522         * linux-thread-db.c: Use C++ exception handling.
8523         * linux-tdep.c: Use C++ exception handling.
8524         * linux-nat.c: Use C++ exception handling.
8525         * linux-fork.c: Use C++ exception handling.
8526         * linespec.c: Use C++ exception handling.
8527         * language.c: Use C++ exception handling.
8528         * jit.c: Use C++ exception handling.
8529         * infrun.c: Use C++ exception handling.
8530         * infcmd.c: Use C++ exception handling.
8531         * infcall.c: Use C++ exception handling.
8532         * inf-loop.c: Use C++ exception handling.
8533         * i386-tdep.c: Use C++ exception handling.
8534         * i386-linux-tdep.c: Use C++ exception handling.
8535         * guile/scm-value.c: Use C++ exception handling.
8536         * guile/scm-type.c: Use C++ exception handling.
8537         * guile/scm-symtab.c: Use C++ exception handling.
8538         * guile/scm-symbol.c: Use C++ exception handling.
8539         * guile/scm-pretty-print.c: Use C++ exception handling.
8540         * guile/scm-ports.c: Use C++ exception handling.
8541         * guile/scm-param.c: Use C++ exception handling.
8542         * guile/scm-math.c: Use C++ exception handling.
8543         * guile/scm-lazy-string.c: Use C++ exception handling.
8544         * guile/scm-frame.c: Use C++ exception handling.
8545         * guile/scm-disasm.c: Use C++ exception handling.
8546         * guile/scm-cmd.c: Use C++ exception handling.
8547         * guile/scm-breakpoint.c: Use C++ exception handling.
8548         * guile/scm-block.c: Use C++ exception handling.
8549         * guile/guile-internal.h: Use C++ exception handling.
8550         * gnu-v3-abi.c: Use C++ exception handling.
8551         * gdbtypes.c: Use C++ exception handling.
8552         * frame.c: Use C++ exception handling.
8553         * frame-unwind.c: Use C++ exception handling.
8554         * fbsd-tdep.c: Use C++ exception handling.
8555         * f-valprint.c: Use C++ exception handling.
8556         * exec.c: Use C++ exception handling.
8557         * event-top.c: Use C++ exception handling.
8558         * event-loop.c: Use C++ exception handling.
8559         * eval.c: Use C++ exception handling.
8560         * dwarf2read.c: Use C++ exception handling.
8561         * dwarf2loc.c: Use C++ exception handling.
8562         * dwarf2-frame.c: Use C++ exception handling.
8563         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8564         * dwarf-index-write.c: Use C++ exception handling.
8565         * dwarf-index-cache.c: Use C++ exception handling.
8566         * dtrace-probe.c: Use C++ exception handling.
8567         * disasm-selftests.c: Use C++ exception handling.
8568         * darwin-nat.c: Use C++ exception handling.
8569         * cp-valprint.c: Use C++ exception handling.
8570         * cp-support.c: Use C++ exception handling.
8571         * cp-abi.c: Use C++ exception handling.
8572         * corelow.c: Use C++ exception handling.
8573         * completer.c: Use C++ exception handling.
8574         * compile/compile-object-run.c: Use C++ exception handling.
8575         * compile/compile-object-load.c: Use C++ exception handling.
8576         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8577         * compile/compile-c-symbols.c: Use C++ exception handling.
8578         * common/selftest.c: Use C++ exception handling.
8579         * common/new-op.c: Use C++ exception handling.
8580         * cli/cli-script.c: Use C++ exception handling.
8581         * cli/cli-interp.c: Use C++ exception handling.
8582         * cli/cli-cmds.c: Use C++ exception handling.
8583         * c-varobj.c: Use C++ exception handling.
8584         * btrace.c: Use C++ exception handling.
8585         * breakpoint.c: Use C++ exception handling.
8586         * break-catch-throw.c: Use C++ exception handling.
8587         * arch-utils.c: Use C++ exception handling.
8588         * amd64-tdep.c: Use C++ exception handling.
8589         * ada-valprint.c: Use C++ exception handling.
8590         * ada-typeprint.c: Use C++ exception handling.
8591         * ada-lang.c: Use C++ exception handling.
8592         * aarch64-tdep.c: Use C++ exception handling.
8593
8594 2019-04-08  Tom Tromey  <tom@tromey.com>
8595
8596         * xml-support.c (gdb_xml_parser::parse): Update.
8597         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8598         * value.c (show_convenience): Update.
8599         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8600         (test_parse_flags_qcs): Update.
8601         * thread.c (thr_try_catch_cmd): Update.
8602         * target.c (target_translate_tls_address): Update.
8603         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8604         (info_frame_command_core, frame_apply_command_count): Update.
8605         * rust-exp.y (rust_lex_exception_test): Update.
8606         * riscv-tdep.c (riscv_print_one_register_info): Update.
8607         * remote.c (remote_target::enable_btrace): Update.
8608         * record-btrace.c (record_btrace_enable_warn): Update.
8609         * python/py-utils.c (gdbpy_convert_exception): Update.
8610         * printcmd.c (do_one_display, print_variable_and_value): Update.
8611         * mi/mi-main.c (mi_print_exception): Update.
8612         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8613         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8614         * linux-nat.c (linux_nat_target::attach): Update.
8615         * linux-fork.c (class scoped_switch_fork_info): Update.
8616         * infrun.c (displaced_step_prepare): Update.
8617         * infcall.c (call_function_by_hand_dummy): Update.
8618         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8619         * gnu-v3-abi.c (print_one_vtable): Update.
8620         * frame.c (get_prev_frame_always): Update.
8621         * f-valprint.c (info_common_command_for_block): Update.
8622         * exec.c (try_open_exec_file): Update.
8623         * exceptions.c (print_exception, exception_print)
8624         (exception_fprintf, exception_print_same): Update.
8625         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8626         * dwarf-index-cache.c (index_cache::store)
8627         (index_cache::lookup_gdb_index): Update.
8628         * darwin-nat.c (maybe_cache_shell): Update.
8629         * cp-valprint.c (cp_print_value_fields): Update.
8630         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8631         (gcc_cplus_symbol_address): Update.
8632         * compile/compile-c-symbols.c (gcc_convert_symbol)
8633         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8634         * common/selftest.c: Update.
8635         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8636         a std::string.
8637         (exception_try_scope_entry, exception_try_scope_exit): Don't
8638         declare.
8639         (struct exception_try_scope): Remove.
8640         (TRY): Don't use exception_try_scope.
8641         (struct gdb_exception): Add constructor, operator=.
8642         <what>: New method.
8643         (struct gdb_exception_RETURN_MASK_ALL)
8644         (struct gdb_exception_RETURN_MASK_ERROR)
8645         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8646         (struct gdb_quit_bad_alloc): Update.
8647         * common/common-exceptions.c (exception_none): Change
8648         initializer.
8649         (struct catcher) <state, exception>: Initialize inline.
8650         <prev>: Remove member.
8651         (current_catcher): Remove.
8652         (catchers): New global.
8653         (exceptions_state_mc_init): Simplify.
8654         (catcher_pop): Remove.
8655         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8656         (try_scope_depth, exception_try_scope_entry)
8657         (exception_try_scope_exit): Remove.
8658         (throw_exception_sjlj): Update.
8659         (exception_messages, exception_messages_size): Remove.
8660         (throw_it): Simplify.
8661         (gdb_exception_sliced_copy): Remove.
8662         (throw_exception_cxx): Update.
8663         * cli/cli-script.c (script_from_file): Update.
8664         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8665         Update.
8666         * ada-valprint.c (ada_val_print): Update.
8667         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8668         (create_excep_cond_exprs): Update.
8669
8670 2019-04-08  Tom Tromey  <tom@tromey.com>
8671
8672         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8673         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8674         (TRY, CATCH, END_CATCH): Remove some definitions.
8675         * common/common-exceptions.c: Don't use GDB_XCPT.
8676         (catcher_list_size): Remove.
8677         (throw_exception, throw_it): Simplify.
8678
8679 2019-04-05  Tom Tromey  <tom@tromey.com>
8680
8681         Revert the header-sorting patch.
8682         * ft32-tdep.c: Revert.
8683         * frv-tdep.c: Revert.
8684         * frv-linux-tdep.c: Revert.
8685         * frame.c: Revert.
8686         * frame-unwind.c: Revert.
8687         * frame-base.c: Revert.
8688         * fork-child.c: Revert.
8689         * findvar.c: Revert.
8690         * findcmd.c: Revert.
8691         * filesystem.c: Revert.
8692         * filename-seen-cache.h: Revert.
8693         * filename-seen-cache.c: Revert.
8694         * fbsd-tdep.c: Revert.
8695         * fbsd-nat.h: Revert.
8696         * fbsd-nat.c: Revert.
8697         * f-valprint.c: Revert.
8698         * f-typeprint.c: Revert.
8699         * f-lang.c: Revert.
8700         * extension.h: Revert.
8701         * extension.c: Revert.
8702         * extension-priv.h: Revert.
8703         * expprint.c: Revert.
8704         * exec.h: Revert.
8705         * exec.c: Revert.
8706         * exceptions.c: Revert.
8707         * event-top.c: Revert.
8708         * event-loop.c: Revert.
8709         * eval.c: Revert.
8710         * elfread.c: Revert.
8711         * dwarf2read.h: Revert.
8712         * dwarf2read.c: Revert.
8713         * dwarf2loc.c: Revert.
8714         * dwarf2expr.h: Revert.
8715         * dwarf2expr.c: Revert.
8716         * dwarf2-frame.c: Revert.
8717         * dwarf2-frame-tailcall.c: Revert.
8718         * dwarf-index-write.h: Revert.
8719         * dwarf-index-write.c: Revert.
8720         * dwarf-index-common.c: Revert.
8721         * dwarf-index-cache.h: Revert.
8722         * dwarf-index-cache.c: Revert.
8723         * dummy-frame.c: Revert.
8724         * dtrace-probe.c: Revert.
8725         * disasm.h: Revert.
8726         * disasm.c: Revert.
8727         * disasm-selftests.c: Revert.
8728         * dictionary.c: Revert.
8729         * dicos-tdep.c: Revert.
8730         * demangle.c: Revert.
8731         * dcache.h: Revert.
8732         * dcache.c: Revert.
8733         * darwin-nat.h: Revert.
8734         * darwin-nat.c: Revert.
8735         * darwin-nat-info.c: Revert.
8736         * d-valprint.c: Revert.
8737         * d-namespace.c: Revert.
8738         * d-lang.c: Revert.
8739         * ctf.c: Revert.
8740         * csky-tdep.c: Revert.
8741         * csky-linux-tdep.c: Revert.
8742         * cris-tdep.c: Revert.
8743         * cris-linux-tdep.c: Revert.
8744         * cp-valprint.c: Revert.
8745         * cp-support.c: Revert.
8746         * cp-namespace.c: Revert.
8747         * cp-abi.c: Revert.
8748         * corelow.c: Revert.
8749         * corefile.c: Revert.
8750         * continuations.c: Revert.
8751         * completer.h: Revert.
8752         * completer.c: Revert.
8753         * complaints.c: Revert.
8754         * coffread.c: Revert.
8755         * coff-pe-read.c: Revert.
8756         * cli-out.h: Revert.
8757         * cli-out.c: Revert.
8758         * charset.c: Revert.
8759         * c-varobj.c: Revert.
8760         * c-valprint.c: Revert.
8761         * c-typeprint.c: Revert.
8762         * c-lang.c: Revert.
8763         * buildsym.c: Revert.
8764         * buildsym-legacy.c: Revert.
8765         * build-id.h: Revert.
8766         * build-id.c: Revert.
8767         * btrace.c: Revert.
8768         * bsd-uthread.c: Revert.
8769         * breakpoint.h: Revert.
8770         * breakpoint.c: Revert.
8771         * break-catch-throw.c: Revert.
8772         * break-catch-syscall.c: Revert.
8773         * break-catch-sig.c: Revert.
8774         * blockframe.c: Revert.
8775         * block.c: Revert.
8776         * bfin-tdep.c: Revert.
8777         * bfin-linux-tdep.c: Revert.
8778         * bfd-target.c: Revert.
8779         * bcache.c: Revert.
8780         * ax-general.c: Revert.
8781         * ax-gdb.h: Revert.
8782         * ax-gdb.c: Revert.
8783         * avr-tdep.c: Revert.
8784         * auxv.c: Revert.
8785         * auto-load.c: Revert.
8786         * arm-wince-tdep.c: Revert.
8787         * arm-tdep.c: Revert.
8788         * arm-symbian-tdep.c: Revert.
8789         * arm-pikeos-tdep.c: Revert.
8790         * arm-obsd-tdep.c: Revert.
8791         * arm-nbsd-tdep.c: Revert.
8792         * arm-nbsd-nat.c: Revert.
8793         * arm-linux-tdep.c: Revert.
8794         * arm-linux-nat.c: Revert.
8795         * arm-fbsd-tdep.c: Revert.
8796         * arm-fbsd-nat.c: Revert.
8797         * arm-bsd-tdep.c: Revert.
8798         * arch-utils.c: Revert.
8799         * arc-tdep.c: Revert.
8800         * arc-newlib-tdep.c: Revert.
8801         * annotate.h: Revert.
8802         * annotate.c: Revert.
8803         * amd64-windows-tdep.c: Revert.
8804         * amd64-windows-nat.c: Revert.
8805         * amd64-tdep.c: Revert.
8806         * amd64-sol2-tdep.c: Revert.
8807         * amd64-obsd-tdep.c: Revert.
8808         * amd64-obsd-nat.c: Revert.
8809         * amd64-nbsd-tdep.c: Revert.
8810         * amd64-nbsd-nat.c: Revert.
8811         * amd64-nat.c: Revert.
8812         * amd64-linux-tdep.c: Revert.
8813         * amd64-linux-nat.c: Revert.
8814         * amd64-fbsd-tdep.c: Revert.
8815         * amd64-fbsd-nat.c: Revert.
8816         * amd64-dicos-tdep.c: Revert.
8817         * amd64-darwin-tdep.c: Revert.
8818         * amd64-bsd-nat.c: Revert.
8819         * alpha-tdep.c: Revert.
8820         * alpha-obsd-tdep.c: Revert.
8821         * alpha-nbsd-tdep.c: Revert.
8822         * alpha-mdebug-tdep.c: Revert.
8823         * alpha-linux-tdep.c: Revert.
8824         * alpha-linux-nat.c: Revert.
8825         * alpha-bsd-tdep.c: Revert.
8826         * alpha-bsd-nat.c: Revert.
8827         * aix-thread.c: Revert.
8828         * agent.c: Revert.
8829         * addrmap.c: Revert.
8830         * ada-varobj.c: Revert.
8831         * ada-valprint.c: Revert.
8832         * ada-typeprint.c: Revert.
8833         * ada-tasks.c: Revert.
8834         * ada-lang.c: Revert.
8835         * aarch64-tdep.c: Revert.
8836         * aarch64-ravenscar-thread.c: Revert.
8837         * aarch64-newlib-tdep.c: Revert.
8838         * aarch64-linux-tdep.c: Revert.
8839         * aarch64-linux-nat.c: Revert.
8840         * aarch64-fbsd-tdep.c: Revert.
8841         * aarch64-fbsd-nat.c: Revert.
8842         * aarch32-linux-nat.c: Revert.
8843
8844 2019-04-05  Tom Tromey  <tom@tromey.com>
8845
8846         * ft32-tdep.c: Sort headers.
8847         * frv-tdep.c: Sort headers.
8848         * frv-linux-tdep.c: Sort headers.
8849         * frame.c: Sort headers.
8850         * frame-unwind.c: Sort headers.
8851         * frame-base.c: Sort headers.
8852         * fork-child.c: Sort headers.
8853         * findvar.c: Sort headers.
8854         * findcmd.c: Sort headers.
8855         * filesystem.c: Sort headers.
8856         * filename-seen-cache.h: Sort headers.
8857         * filename-seen-cache.c: Sort headers.
8858         * fbsd-tdep.c: Sort headers.
8859         * fbsd-nat.h: Sort headers.
8860         * fbsd-nat.c: Sort headers.
8861         * f-valprint.c: Sort headers.
8862         * f-typeprint.c: Sort headers.
8863         * f-lang.c: Sort headers.
8864         * extension.h: Sort headers.
8865         * extension.c: Sort headers.
8866         * extension-priv.h: Sort headers.
8867         * expprint.c: Sort headers.
8868         * exec.h: Sort headers.
8869         * exec.c: Sort headers.
8870         * exceptions.c: Sort headers.
8871         * event-top.c: Sort headers.
8872         * event-loop.c: Sort headers.
8873         * eval.c: Sort headers.
8874         * elfread.c: Sort headers.
8875         * dwarf2read.h: Sort headers.
8876         * dwarf2read.c: Sort headers.
8877         * dwarf2loc.c: Sort headers.
8878         * dwarf2expr.h: Sort headers.
8879         * dwarf2expr.c: Sort headers.
8880         * dwarf2-frame.c: Sort headers.
8881         * dwarf2-frame-tailcall.c: Sort headers.
8882         * dwarf-index-write.h: Sort headers.
8883         * dwarf-index-write.c: Sort headers.
8884         * dwarf-index-common.c: Sort headers.
8885         * dwarf-index-cache.h: Sort headers.
8886         * dwarf-index-cache.c: Sort headers.
8887         * dummy-frame.c: Sort headers.
8888         * dtrace-probe.c: Sort headers.
8889         * disasm.h: Sort headers.
8890         * disasm.c: Sort headers.
8891         * disasm-selftests.c: Sort headers.
8892         * dictionary.c: Sort headers.
8893         * dicos-tdep.c: Sort headers.
8894         * demangle.c: Sort headers.
8895         * dcache.h: Sort headers.
8896         * dcache.c: Sort headers.
8897         * darwin-nat.h: Sort headers.
8898         * darwin-nat.c: Sort headers.
8899         * darwin-nat-info.c: Sort headers.
8900         * d-valprint.c: Sort headers.
8901         * d-namespace.c: Sort headers.
8902         * d-lang.c: Sort headers.
8903         * ctf.c: Sort headers.
8904         * csky-tdep.c: Sort headers.
8905         * csky-linux-tdep.c: Sort headers.
8906         * cris-tdep.c: Sort headers.
8907         * cris-linux-tdep.c: Sort headers.
8908         * cp-valprint.c: Sort headers.
8909         * cp-support.c: Sort headers.
8910         * cp-namespace.c: Sort headers.
8911         * cp-abi.c: Sort headers.
8912         * corelow.c: Sort headers.
8913         * corefile.c: Sort headers.
8914         * continuations.c: Sort headers.
8915         * completer.h: Sort headers.
8916         * completer.c: Sort headers.
8917         * complaints.c: Sort headers.
8918         * coffread.c: Sort headers.
8919         * coff-pe-read.c: Sort headers.
8920         * cli-out.h: Sort headers.
8921         * cli-out.c: Sort headers.
8922         * charset.c: Sort headers.
8923         * c-varobj.c: Sort headers.
8924         * c-valprint.c: Sort headers.
8925         * c-typeprint.c: Sort headers.
8926         * c-lang.c: Sort headers.
8927         * buildsym.c: Sort headers.
8928         * buildsym-legacy.c: Sort headers.
8929         * build-id.h: Sort headers.
8930         * build-id.c: Sort headers.
8931         * btrace.c: Sort headers.
8932         * bsd-uthread.c: Sort headers.
8933         * breakpoint.h: Sort headers.
8934         * breakpoint.c: Sort headers.
8935         * break-catch-throw.c: Sort headers.
8936         * break-catch-syscall.c: Sort headers.
8937         * break-catch-sig.c: Sort headers.
8938         * blockframe.c: Sort headers.
8939         * block.c: Sort headers.
8940         * bfin-tdep.c: Sort headers.
8941         * bfin-linux-tdep.c: Sort headers.
8942         * bfd-target.c: Sort headers.
8943         * bcache.c: Sort headers.
8944         * ax-general.c: Sort headers.
8945         * ax-gdb.h: Sort headers.
8946         * ax-gdb.c: Sort headers.
8947         * avr-tdep.c: Sort headers.
8948         * auxv.c: Sort headers.
8949         * auto-load.c: Sort headers.
8950         * arm-wince-tdep.c: Sort headers.
8951         * arm-tdep.c: Sort headers.
8952         * arm-symbian-tdep.c: Sort headers.
8953         * arm-pikeos-tdep.c: Sort headers.
8954         * arm-obsd-tdep.c: Sort headers.
8955         * arm-nbsd-tdep.c: Sort headers.
8956         * arm-nbsd-nat.c: Sort headers.
8957         * arm-linux-tdep.c: Sort headers.
8958         * arm-linux-nat.c: Sort headers.
8959         * arm-fbsd-tdep.c: Sort headers.
8960         * arm-fbsd-nat.c: Sort headers.
8961         * arm-bsd-tdep.c: Sort headers.
8962         * arch-utils.c: Sort headers.
8963         * arc-tdep.c: Sort headers.
8964         * arc-newlib-tdep.c: Sort headers.
8965         * annotate.h: Sort headers.
8966         * annotate.c: Sort headers.
8967         * amd64-windows-tdep.c: Sort headers.
8968         * amd64-windows-nat.c: Sort headers.
8969         * amd64-tdep.c: Sort headers.
8970         * amd64-sol2-tdep.c: Sort headers.
8971         * amd64-obsd-tdep.c: Sort headers.
8972         * amd64-obsd-nat.c: Sort headers.
8973         * amd64-nbsd-tdep.c: Sort headers.
8974         * amd64-nbsd-nat.c: Sort headers.
8975         * amd64-nat.c: Sort headers.
8976         * amd64-linux-tdep.c: Sort headers.
8977         * amd64-linux-nat.c: Sort headers.
8978         * amd64-fbsd-tdep.c: Sort headers.
8979         * amd64-fbsd-nat.c: Sort headers.
8980         * amd64-dicos-tdep.c: Sort headers.
8981         * amd64-darwin-tdep.c: Sort headers.
8982         * amd64-bsd-nat.c: Sort headers.
8983         * alpha-tdep.c: Sort headers.
8984         * alpha-obsd-tdep.c: Sort headers.
8985         * alpha-nbsd-tdep.c: Sort headers.
8986         * alpha-mdebug-tdep.c: Sort headers.
8987         * alpha-linux-tdep.c: Sort headers.
8988         * alpha-linux-nat.c: Sort headers.
8989         * alpha-bsd-tdep.c: Sort headers.
8990         * alpha-bsd-nat.c: Sort headers.
8991         * aix-thread.c: Sort headers.
8992         * agent.c: Sort headers.
8993         * addrmap.c: Sort headers.
8994         * ada-varobj.c: Sort headers.
8995         * ada-valprint.c: Sort headers.
8996         * ada-typeprint.c: Sort headers.
8997         * ada-tasks.c: Sort headers.
8998         * ada-lang.c: Sort headers.
8999         * aarch64-tdep.c: Sort headers.
9000         * aarch64-ravenscar-thread.c: Sort headers.
9001         * aarch64-newlib-tdep.c: Sort headers.
9002         * aarch64-linux-tdep.c: Sort headers.
9003         * aarch64-linux-nat.c: Sort headers.
9004         * aarch64-fbsd-tdep.c: Sort headers.
9005         * aarch64-fbsd-nat.c: Sort headers.
9006         * aarch32-linux-nat.c: Sort headers.
9007
9008 2019-04-04  Tom Tromey  <tom@tromey.com>
9009
9010         * varobj.c (varobj_create): Update.
9011         * rust-exp.y (struct rust_parser) <update_innermost_block,
9012         lookup_symbol>: New methods.
9013         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9014         Rename.
9015         (rust_parser::rust_lookup_type)
9016         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9017         * printcmd.c (display_command, do_one_display): Update.
9018         * parser-defs.h (struct parser_state) <parser_state>: Add
9019         "tracker" parameter.
9020         (block_tracker): New member.
9021         (class innermost_block_tracker) <innermost_block_tracker>: Add
9022         "types" parameter.
9023         <reset>: Remove method.
9024         (innermost_block): Don't declare.
9025         (null_post_parser): Update.
9026         * parse.c (innermost_block): Remove global.
9027         (write_dollar_variable): Update.
9028         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9029         Remove "tracker_types" parameter.
9030         (parse_expression): Add "tracker" parameter.
9031         (parse_expression_for_completion): Update.
9032         (null_post_parser): Add "tracker" parameter.
9033         * p-exp.y: Update rules.
9034         * m2-exp.y: Update rules.
9035         * language.h (struct language_defn) <la_post_parser>: Add
9036         "tracker" parameter.
9037         * go-exp.y: Update rules.
9038         * f-exp.y: Update rules.
9039         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9040         parameter.
9041         * d-exp.y: Update rules.
9042         * c-exp.y: Update rules.
9043         * breakpoint.c (set_breakpoint_condition): Create an
9044         innermost_block_tracker.
9045         (watch_command_1): Likewise.
9046         * ada-lang.c (resolve): Add "tracker" parameter.
9047         (resolve_subexp): Likewise.
9048         * ada-exp.y (write_var_from_sym): Update.
9049
9050 2019-04-04  Tom Tromey  <tom@tromey.com>
9051
9052         * type-stack.h: New file.
9053         * type-stack.c: New file.
9054         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9055         type-stack.h.
9056         (insert_into_type_stack, insert_type, push_type, push_type_int)
9057         (insert_type_address_space, pop_type, pop_type_int)
9058         (pop_typelist, pop_type_stack, append_type_stack)
9059         (push_type_stack, get_type_stack, push_typelist)
9060         (follow_type_instance_flags, follow_types): Don't declare.
9061         * parse.c (type_stack): Remove global.
9062         (parse_exp_in_context): Update.
9063         (insert_into_type_stack, insert_type, push_type, push_type_int)
9064         (insert_type_address_space, pop_type, pop_type_int)
9065         (pop_typelist, pop_type_stack, append_type_stack)
9066         (push_type_stack, get_type_stack, push_typelist)
9067         (follow_type_instance_flags, follow_types): Remove (moved to
9068         type-stack.c).
9069         * f-exp.y (type_stack): New global.
9070         Update rules.
9071         (push_kind_type, f_parse): Update.
9072         * d-exp.y (type_stack): New global.
9073         Update rules.
9074         (d_parse): Update.
9075         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9076         Update rules.
9077         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9078         (HFILES_NO_SRCDIR): Add type-stack.h.
9079
9080 2019-04-04  Tom Tromey  <tom@tromey.com>
9081
9082         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9083         (rust_parser::convert_ast_to_expression, rust_parse)
9084         (rust_lex_test_completion, rust_lex_tests): Update.
9085         * parser-defs.h (struct expr_completion_state): New.
9086         (struct parser_state) <parser_state>: Add completion parameter.
9087         <mark_struct_expression, mark_completion_tag>: New methods.
9088         <parse_completion, m_completion_state>: New members.
9089         (prefixify_expression, null_post_parser): Update.
9090         (mark_struct_expression, mark_completion_tag): Don't declare.
9091         * parse.c (parse_completion, expout_last_struct)
9092         (expout_tag_completion_type, expout_completion_name): Remove
9093         globals.
9094         (parser_state::mark_struct_expression)
9095         (parser_state::mark_completion_tag): Now methods.
9096         (prefixify_expression): Add last_struct parameter.
9097         (prefixify_subexp): Likewise.
9098         (parse_exp_1): Update.
9099         (parse_exp_in_context): Add cstate parameter.  Update.
9100         (parse_expression_for_completion): Create an
9101         expr_completion_state.
9102         (null_post_parser): Add "completion" parameter.
9103         * p-exp.y: Update rules.
9104         (yylex): Update.
9105         * language.h (struct language_defn) <la_post_parser>: Add
9106         "completing" parameter.
9107         * go-exp.y: Update rules.
9108         (lex_one_token): Update.
9109         * expression.h (parse_completion): Don't declare.
9110         * d-exp.y: Update rules.
9111         (lex_one_token): Update rules.
9112         * c-exp.y: Update rules.
9113         (lex_one_token): Update.
9114         * ada-lang.c (resolve): Add "parse_completion" parameter.
9115         (resolve_subexp): Likewise.
9116         (ada_resolve_function): Likewise.
9117
9118 2019-04-04  Tom Tromey  <tom@tromey.com>
9119
9120         * parser-defs.h (struct parser_state) <start_arglist,
9121         end_arglist>: New methods.
9122         <arglist_len, m_funcall_chain>: New members.
9123         (arglist_len, start_arglist, end_arglist): Don't declare.
9124         * parse.c (arglist_len, funcall_chain): Remove global.
9125         (start_arglist, end_arglist): Remove functions.
9126         (parse_exp_in_context): Update.
9127         * p-exp.y: Update rules.
9128         * m2-exp.y: Update rules.
9129         * go-exp.y: Update rules.
9130         * f-exp.y: Update rules.
9131         * d-exp.y: Update rules.
9132         * c-exp.y: Update rules.
9133
9134 2019-04-04  Tom Tromey  <tom@tromey.com>
9135
9136         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9137         lex_operator, push_back>: New methods.
9138         Update all rules.
9139         (rust_parser::lex_hex, lex_escape): Rename and update.
9140         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9141         (rust_parser::lex_operator): Rename and update.
9142         (rust_parser::lex_number, rustyylex, rustyyerror)
9143         (rust_lex_test_init, rust_lex_test_sequence)
9144         (rust_lex_test_push_back, rust_lex_tests): Update.
9145         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9146         parameter.
9147         <lexptr, prev_lexptr>: New members.
9148         (lexptr, prev_lexptr): Don't declare.
9149         * parse.c (lexptr, prev_lexptr): Remove globals.
9150         (parse_exp_in_context): Update.
9151         * p-exp.y (yylex, yyerror): Update.
9152         * m2-exp.y (parse_number, yylex, yyerror): Update.
9153         * go-exp.y (lex_one_token, yyerror): Update.
9154         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9155         * d-exp.y (lex_one_token, yyerror): Update.
9156         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9157         (lex_one_token, yyerror): Update.
9158         * ada-lex.l (YY_INPUT): Update.
9159         (rewind_to_char): Update.
9160         * ada-exp.y (yyerror): Update.
9161
9162 2019-04-04  Tom Tromey  <tom@tromey.com>
9163
9164         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9165         * parser-defs.h (struct parser_state) <parser_state>: Add new
9166         parameter.
9167         <comma_terminates>: New member.
9168         (comma_terminates): Don't declare global.
9169         * parse.c (comma_terminates): Remove global.
9170         (parse_exp_in_context): Update.
9171         * p-exp.y (yylex): Update.
9172         * m2-exp.y (yylex): Update.
9173         * go-exp.y (lex_one_token): Update.
9174         * f-exp.y (yylex): Update.
9175         * d-exp.y (lex_one_token): Update.
9176         * c-exp.y (lex_one_token): Update.
9177         * ada-lex.l: Update.
9178
9179 2019-04-04  Tom Tromey  <tom@tromey.com>
9180
9181         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9182         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9183         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9184         * parser-defs.h (paren_depth): Don't declare.
9185         * parse.c (paren_depth): Remove global.
9186         (parse_exp_in_context): Update.
9187         * p-exp.y (paren_depth): New global.
9188         (pascal_parse): Initialize it.
9189         * m2-exp.y (paren_depth): New global.
9190         (m2_parse): Initialize it.
9191         * go-exp.y (paren_depth): New global.
9192         (go_parse): Initialize it.
9193         * f-exp.y (paren_depth): New global.
9194         (f_parse): Initialize it.
9195         * d-exp.y (paren_depth): New global.
9196         (d_parse): Initialize it.
9197         * c-exp.y (paren_depth): New global.
9198         (c_parse): Initialize it.
9199         * ada-lex.l (paren_depth): New global.
9200         (lexer_init): Initialize it.
9201
9202 2019-04-04  Tom Tromey  <tom@tromey.com>
9203
9204         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9205         (rust_parser::convert_ast_to_type)
9206         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9207         * parser-defs.h (struct parser_state) <parser_state>: Add
9208         parameters.  Initialize new members.
9209         <expression_context_block, expression_context_pc>: New members.
9210         * parse.c (expression_context_block, expression_context_pc):
9211         Remove globals.
9212         (parse_exp_in_context): Update.
9213         * p-exp.y: Update all rules.
9214         (yylex): Update.
9215         * m2-exp.y: Update all rules.
9216         (yylex): Update.
9217         * go-exp.y (yylex): Update.
9218         * f-exp.y (yylex): Update.
9219         * d-exp.y: Update all rules.
9220         (yylex): Update.
9221         * c-exp.y: Update all rules.
9222         (lex_one_token, classify_name, yylex, c_parse): Update.
9223         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9224
9225 2019-04-04  Tom Tromey  <tom@tromey.com>
9226
9227         * gdbarch.h, gdbarch.c: Rebuild.
9228         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9229         * stap-probe.h:
9230         (struct stap_parse_info): Replace "parser_state" with
9231         "expr_builder".
9232         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9233         (parser_state): New class.
9234         * parse.c (expr_builder): Rename.
9235         (expr_builder::release): Rename.
9236         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9237         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9238         (write_exp_elt_longcst, write_exp_elt_floatcst)
9239         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9240         (write_exp_string_vector, write_exp_bitstring)
9241         (write_exp_msymbol, mark_struct_expression)
9242         (write_dollar_variable)
9243         (insert_type_address_space, increase_expout_size): Replace
9244         "parser_state" with "expr_builder".
9245         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9246         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9247         "parser_state" with "expr_builder".
9248
9249 2019-04-04  Tom Tromey  <tom@tromey.com>
9250
9251         * rust-exp.y: Replace "parse_language" with method call.
9252         * p-exp.y:
9253         (yylex): Replace "parse_language" with method call.
9254         * m2-exp.y:
9255         (yylex): Replace "parse_language" with method call.
9256         * go-exp.y (classify_name): Replace "parse_language" with method
9257         call.
9258         * f-exp.y (yylex): Replace "parse_language" with method call.
9259         * d-exp.y (lex_one_token): Replace "parse_language" with method
9260         call.
9261         * c-exp.y:
9262         (lex_one_token, classify_name, yylex): Replace "parse_language"
9263         with method call.
9264         * ada-exp.y (find_primitive_type, type_char)
9265         (type_system_address): Replace "parse_language" with method call.
9266
9267 2019-04-04  Tom Tromey  <tom@tromey.com>
9268
9269         * rust-exp.y: Replace "parse_gdbarch" with method call.
9270         * parse.c (write_dollar_variable, insert_type_address_space):
9271         Replace "parse_gdbarch" with method call.
9272         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9273         call.
9274         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9275         call.
9276         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9277         "parse_gdbarch" with method call.
9278         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9279         with method call.
9280         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9281         "parse_gdbarch" with method call.
9282         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9283         "parse_gdbarch" with method call.
9284         * c-exp.y (parse_type, parse_number, classify_name): Replace
9285         "parse_gdbarch" with method call.
9286         * ada-lex.l: Replace "parse_gdbarch" with method call.
9287         * ada-exp.y (parse_type, find_primitive_type, type_char)
9288         (type_system_address): Replace "parse_gdbarch" with method call.
9289
9290 2019-04-04  Tom Tromey  <tom@tromey.com>
9291
9292         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9293         * stap-probe.c (stap_parse_argument): Update.
9294         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9295         initial_size parameter.
9296         * rust-exp.y (rust_lex_tests): Update.
9297         * parse.c (parser_state): Update.
9298         (parse_exp_in_context): Update.
9299         * parser-defs.h (struct parser_state) <parser_state>: Remove
9300         "initial_size" parameter.
9301
9302 2019-04-04  Tom Tromey  <tom@tromey.com>
9303
9304         * parser-defs.h (increase_expout_size): Don't declare.
9305         * parse.c (increase_expout_size): Now static.
9306
9307 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9308
9309         * gnu-nat.c (gnu_nat_target::wait): Fix
9310         target_waitstatus_to_string call.
9311
9312 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9313
9314         * eval.c (evaluate_subexp_standard): Handle internal functions
9315         during Fortran function call handling.
9316
9317 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9318
9319         * NEWS: Mention new internal functions.
9320         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9321         (read_base_type): Use dwarf2_init_complex_target_type.
9322         * value.c (creal_internal_fn): New function.
9323         (cimag_internal_fn): New function.
9324         (_initialize_values): Register new internal functions.
9325
9326 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9327
9328         * infrun.c (stop_all_threads): If debug_infrun, always
9329         trace the wait status after wait_one, using
9330         target_waitstatus_to_string and target_pid_to_str.
9331         (handle_inferior_event): Replace various trace of
9332         wait status kind by a single trace.
9333         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9334         wait status kind image by target_waitstatus_to_string.
9335         * target/waitstatus.c (target_waitstatus_to_string): Fix
9336         obsolete comment.
9337
9338 2019-04-01  Tom Tromey  <tromey@adacore.com>
9339
9340         PR symtab/23331:
9341         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9342
9343 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9344             Pedro Alves  <palves@redhat.com>
9345
9346         * top.c (quit_force): Call 'finalize_values'.
9347         * value.c (finalize_values): New function.
9348         * value.h (finalize_values): Declare.
9349
9350 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9351
9352         * NEWS: Announce $_gdb_major and $_gdb_minor.
9353
9354         * top.c (init_gdb_version_vars): New function.
9355         (gdb_init): Call init_gdb_version_vars.
9356
9357 2019-03-29  Tom Tromey  <tromey@adacore.com>
9358
9359         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9360         help text.  Remove dead code.
9361
9362 2019-03-29  Keith Seitz  <keiths@redhat.com>
9363
9364         From Siddhesh Poyarekar:
9365         * f-lang.h (f77_get_upperbound): Return LONGEST.
9366         (f77_get_lowerbound): Likewise.
9367         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9368         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9369         print them.
9370         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9371         plongest to format print it.
9372         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9373         (f77_get_upperbound): Likewise.
9374         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9375         LOWER_BOUND to LONGEST.
9376         (f77_create_arrayprint_offset_tbl): Likewise.
9377
9378 2019-03-29  Keith Seitz  <keiths@redhat.com>
9379
9380         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9381         %s/pulongest for TYPE_LENGTH instead of %d in format
9382         strings.
9383         * ada-typerint.c (ada_print_type): Likewise.
9384         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9385         * compile/compile-c-support.c (generate_register_struct): Likewise.
9386         * gdbtypes.c (recursive_dump_type): Likewise.
9387         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9388         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9389         instead of %d in format strings.
9390         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9391         to std::min to ULONGEST.
9392         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9393         instead of %d in format strings.
9394         * tracepoint.c (info_scope_command): Likewise.
9395         * typeprint.c (print_offset_data::update)
9396         (print_offset_data::finish): Likewise.
9397         * xtensa-tdep.c (xtensa_store_return_value)
9398         (xtensa_push_dummy_call): Likewise.
9399
9400 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9401
9402         * windows-nat.c (display_selector): Fixed format specifications
9403         for 64-bit Cygwin.
9404
9405 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9406
9407         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9408
9409 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9410
9411         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9412         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9413         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9414         (nios2_linux_init_abi): Install it.
9415
9416 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9417
9418         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9419
9420 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9421
9422         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9423
9424 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9425             Tom Tromey  <tromey@adacore.com>
9426
9427         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9428
9429 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9430
9431         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9432         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9433         method to compute the bounds of range types. Also print "[evaluated]"
9434         if the bounds' values come from a dynamic evaluation.
9435
9436 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9437
9438         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9439         whitespace when pretty printing is on.
9440
9441 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9442
9443         * ppc-linux-nat.c: Add include.
9444
9445 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9446
9447         * NEWS: Mention AArch64 Pointer Authentication.
9448
9449 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9450
9451         * arm-linux-nat.c: Add include.
9452
9453 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9454
9455         * source-cache.c (source_cache::get_source_lines): Re-read
9456         fullname after calling open_source_file.
9457
9458 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9459
9460         * NEWS: Mention TLS support for FreeBSD.
9461
9462 2019-03-25  Tom Tromey  <tromey@adacore.com>
9463
9464         * minsyms.c (BUNCH_SIZE): Update comment.
9465         (~minimal_symbol_reader): Remove old comment.
9466         (compact_minimal_symbols): Update comment.
9467         (minimal_symbol_reader::install): Remove old comment.  Update
9468         other comments.
9469
9470 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9471
9472         * s390-linux-nat.c: Add include.
9473
9474 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9475
9476         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9477         Call linux_get_hwcap.
9478         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9479         Likewise.
9480         (aarch64_linux_get_hwcap): Remove function.
9481         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9482         declaration.
9483         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9484         linux_get_hwcap.
9485         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9486         * linux-tdep.c (linux_get_hwcap): Add function.
9487         (linux_get_hwcap2): Likewise.
9488         * linux-tdep.h (linux_get_hwcap): Add declaration.
9489         (linux_get_hwcap2): Likewise.
9490         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9491         (ppc_linux_get_hwcap2): Likewise.
9492         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9493         linux_get_hwcap.
9494         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9495         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9496         (ppc_linux_nat_target::read_description): Likewise.
9497         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9498         * s390-linux-nat.c: Likewise.
9499         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9500
9501 2019-03-24  Tom Tromey  <tom@tromey.com>
9502
9503         * ada-lang.c (standard_lookup): Simplify initialization.
9504         (ada_lookup_symbol_nonlocal): Simplify return.
9505         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9506         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9507         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9508         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9509         initialization.
9510         * solib.c (solib_global_lookup): Simplify.
9511         * symtab.c (null_block_symbol): Remove.
9512         (symbol_cache_lookup): Simplify returns.
9513         (lookup_language_this): Simplify returns.
9514         (lookup_symbol_aux): Simplify return.
9515         (lookup_local_symbol): Simplify returns.
9516         (lookup_global_symbol_from_objfile): Simplify return.
9517         (lookup_symbol_in_objfile_symtabs)
9518         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9519         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9520         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9521         * cp-namespace.c (cp_lookup_bare_symbol)
9522         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9523         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9524         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9525         (cp_lookup_symbol_via_imports): Simplify initialization.
9526         (find_symbol_in_baseclass): Likewise.
9527         * symtab.h (null_block_symbol): Remove.
9528         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9529         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9530         (d_lookup_symbol_module): Likewise.
9531         (find_symbol_in_baseclass): Simplify initialization.
9532
9533 2019-03-24  Tom Tromey  <tom@tromey.com>
9534
9535         * expression.h: Don't include symtab.h.
9536         (struct block): Forward declare.
9537
9538 2019-03-24  Tom Tromey  <tom@tromey.com>
9539
9540         * c-exp.y (typebase): Remove casts.
9541         * gdbtypes.c (lookup_unsigned_typename, )
9542         (lookup_signed_typename): Remove cast.
9543         * eval.c (parse_to_comma_and_eval): Remove cast.
9544         * parse.c (write_dollar_variable): Remove cast.
9545         * block.h (struct block) <superblock>: Now const.
9546         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9547         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9548         (map_block): Make "block" const.
9549         * symfile.h (struct quick_symbol_functions)
9550         <map_matching_symbols>: Constify block argument to "callback".
9551         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9552         const.
9553         (find_pc_sect_compunit_symtab): Make "b" const.
9554         (find_symbol_at_address): Likewise.
9555         (search_symbols): Likewise.
9556         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9557         (dw2_debug_names_lookup_symbol): Likewise.
9558         (dw2_map_matching_symbols): Update.
9559         * p-valprint.c (pascal_val_print): Remove "block".
9560         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9561         (aux_add_nonlocal_symbols): Make "block" const.
9562         (resolve_subexp): Remove cast.
9563         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9564         const.
9565         (iterate_over_file_blocks): Likewise.
9566         * f-exp.y (%union) <bval>: Remove.
9567         * coffread.c (patch_opaque_types): Make "b" const.
9568         * spu-tdep.c (spu_catch_start): Make "block" const.
9569         * c-valprint.c (print_unpacked_pointer): Remove "block".
9570         * symmisc.c (dump_symtab_1): Make "b" const.
9571         (block_depth): Make "block" const.
9572         * d-exp.y (%union) <bval>: Remove.
9573         * cp-support.h (cp_lookup_rtti_type): Update.
9574         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9575         * psymtab.c (psym_lookup_symbol): Make "block" const.
9576         (maintenance_check_psymtabs): Make "b" const.
9577         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9578         (enumerate_locals, enumerate_args): Update.
9579         * python/py-symtab.c (stpy_global_block): Make "block" const.
9580         (stpy_static_block): Likewise.
9581         * inline-frame.c (block_starting_point_at): Make "new_block"
9582         const.
9583         * block.c (find_block_in_blockvector): Make return type const.
9584         (blockvector_for_pc_sect): Make "b" const.
9585         (find_block_in_blockvector): Make "b" const.
9586
9587 2019-03-23  Tom Tromey  <tom@tromey.com>
9588
9589         * varobj.c (varobj_create): Update.
9590         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9591         * printcmd.c (display_command, do_one_display): Don't reset
9592         innermost_block.
9593         * parser-defs.h (enum innermost_block_tracker_type): Move to
9594         expression.h.
9595         (innermost_block): Update comment.
9596         * parse.c (parse_exp_1): Add tracker_types parameter.
9597         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9598         tracker_types parameter.  Reset innermost_block.
9599         (parse_exp_in_context): Remove.
9600         (parse_expression_for_completion): Update.
9601         * objfiles.c (~objfile): Don't reset expression_context_block or
9602         innermost_block.
9603         * expression.h (enum innermost_block_tracker_type): Move from
9604         parser-defs.h.
9605         (parse_exp_1): Add tracker_types parameter.
9606         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9607         reset innermost_block.
9608
9609 2019-03-23  Tom Tromey  <tom@tromey.com>
9610
9611         * objfiles.h: Include bcache.h.
9612
9613 2019-03-23  Tom Tromey  <tom@tromey.com>
9614
9615         * linespec.c (get_current_search_block): Use
9616         scoped_restore_current_language.
9617         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9618
9619 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9620             Jiong Wang  <jiong.wang@arm.com>
9621
9622         * aarch64-linux-tdep.c
9623         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9624         section.
9625         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9626
9627 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9628             Jiong Wang  <jiong.wang@arm.com>
9629
9630         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9631         instructions.
9632         (aarch64_analyze_prologue_test): Add PACIASP test.
9633         (aarch64_prologue_prev_register): Unmask PC value.
9634
9635 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9636             Jiong Wang  <jiong.wang@arm.com>
9637
9638         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9639         (aarch64_dwarf2_prev_register): Unmask PC value.
9640         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9641         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9642         DW_CFA_AARCH64_negate_ra_state.
9643         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9644
9645 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9646             Jiong Wang  <jiong.wang@arm.com>
9647
9648         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9649         registers.
9650         (aarch64_pseudo_register_name): Likewise.
9651         (aarch64_pseudo_register_type): Likewise.
9652         (aarch64_pseudo_register_reggroup_p): Likewise.
9653         (aarch64_gdbarch_init): Add pauth registers.
9654         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9655         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9656         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9657         (struct gdbarch_tdep): Add regnum for ra_state.
9658
9659 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9660             Jiong Wang  <jiong.wang@arm.com>
9661
9662         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9663
9664 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9665             Jiong Wang  <jiong.wang@arm.com>
9666
9667         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9668         function.
9669         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9670         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9671         (aarch64_gdbarch_init): Add puth registers.
9672         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9673         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9674         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9675
9676 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9677             Jiong Wang  <jiong.wang@arm.com>
9678
9679         * aarch64-linux-nat.c
9680         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9681         * aarch64-linux-tdep.c
9682         (aarch64_linux_core_read_description): Likewise.
9683         (aarch64_linux_get_hwcap): New function.
9684         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9685         (aarch64_linux_get_hwcap): New declaration.
9686
9687 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9688             Jiong Wang  <jiong.wang@arm.com>
9689
9690         * aarch64-linux-nat.c
9691         (aarch64_linux_nat_target::read_description): Add pauth param.
9692         * aarch64-linux-tdep.c
9693         (aarch64_linux_core_read_description): Likewise.
9694         * aarch64-tdep.c (struct target_desc): Add in pauth.
9695         (aarch64_read_description): Add pauth param.
9696         (aarch64_gdbarch_init): Likewise.
9697         * aarch64-tdep.h (aarch64_read_description): Likewise.
9698         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9699         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9700         * features/Makefile: Add new files.
9701         * features/aarch64-pauth.c: New file.
9702         * features/aarch64-pauth.xml: New file.
9703
9704 2019-03-20  Tom Tromey  <tromey@adacore.com>
9705
9706         * infrun.c (handle_inferior_event): Rename from
9707         handle_inferior_event_1.  Create a scoped_value_mark.
9708         (handle_inferior_event): Remove.
9709
9710 2019-03-19  Tom Tromey  <tromey@adacore.com>
9711
9712         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9713         * infrun.h (print_stop_event): Add "displays" parameter.
9714         * infrun.c (print_stop_event): Add "displays" parameter.
9715
9716 2019-03-19  Pedro Alves  <palves@redhat.com>
9717
9718         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9719         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9720         to -1.  Fix TABs vs spaces.
9721         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9722         * tui/tui-out.h (tui_ui_out) Add intro comments.
9723         <m_line, m_start_of_line>: In-class initialize, and add describing
9724         comment.
9725
9726 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9727
9728         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9729         variable names.
9730         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9731
9732 2019-03-18  Pedro Alves  <palves@redhat.com>
9733             Eli Zaretskii <eliz@gnu.org>
9734
9735         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9736         m_line and m_start_of_line.
9737
9738 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9739
9740         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9741         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9742         it returns a newline.  This fixes a regression in TU mode, whereby
9743         the next line is output on the same screen line as the user input.
9744
9745 2019-03-18  Tom Tromey  <tromey@adacore.com>
9746
9747         * minsyms.c (minimal_symbol_reader::install): Remove call to
9748         obstack_blank.
9749
9750 2019-03-18  Pedro Alves  <palves@redhat.com>
9751
9752         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9753         New globals.
9754         (apply_style): New, factored out from ...
9755         (apply_ansi_escape): ... this.  Handle reverse video mode.
9756         (tui_set_reverse_mode): New function.
9757         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9758         * tui/tui-winsource.c (tui_show_source_line): Use
9759         tui_set_reverse_mode instead of setting A_STANDOUT.
9760         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9761         New setter methods.
9762
9763 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9764
9765         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9766         Handle tabs.
9767
9768 2019-03-18  Tom Tromey  <tromey@adacore.com>
9769
9770         * ada-lang.c (empty_array): Add "high" parameter.
9771         (ada_evaluate_subexp): Update.
9772
9773 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9774
9775         * unittests/string_view-selftests.c: Define
9776         _initialize_string_view_selftests unconditionally.
9777
9778 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9779
9780         PR gdb/24350
9781         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9782
9783 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9784
9785         PR gdb/24351
9786         * windows-nat.c (display_selector): Fix format specifiers.
9787
9788 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9789
9790         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9791         tui_refill_source_window instead of tui_refresh_win, to update the
9792         current execution line.  This fixes redisplay of the current line
9793         when stepping through the code with "next" or "step".
9794
9795 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9796
9797         * source-cache.c (source_cache::get_source_lines): Call
9798         find_source_lines to initialize s->nlines.  This fixes vertical
9799         scrolling of TUI source window when the DOWN arrow is pressed.
9800
9801 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9802
9803         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9804         linux-thread-db.c (_initialize_thread_db): Likewise.
9805
9806 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9807
9808         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9809         wclrtoeol in tui_show_source_line".  This reverts changes made in
9810         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9811
9812 2019-03-15  Tom Tromey  <tom@tromey.com>
9813
9814         * symtab.h (struct minimal_symbol): Derive from
9815         general_symbol_info.
9816         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9817         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9818         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9819         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9820         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9821         (MSYMBOL_SEARCH_NAME): Update.
9822         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9823         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9824         * minsyms.c (minimal_symbol_reader::record_full): Update.
9825
9826 2019-03-15  Tom Tromey  <tom@tromey.com>
9827
9828         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9829
9830 2019-03-15  Tom Tromey  <tom@tromey.com>
9831
9832         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9833         unique_xmalloc_ptr.
9834         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9835         Update.
9836         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9837         (build_minimal_symbol_hash_tables)
9838         (minimal_symbol_reader::install): Update.
9839
9840 2019-03-15  Tom Tromey  <tom@tromey.com>
9841
9842         * symtab.c (create_demangled_names_hash): Update.
9843         (symbol_set_names): Update.
9844         * objfiles.h (struct objfile_per_bfd_storage)
9845         <demangled_names_hash>: Now an htab_up.
9846         * objfiles.c (objfile_per_bfd_storage): Simplify.
9847
9848 2019-03-15  Tom Tromey  <tom@tromey.com>
9849
9850         * objfiles.h (struct objfile_per_bfd_storage): Declare
9851         destructor.
9852         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9853         New.
9854         (get_objfile_bfd_data): Use new.  Don't initialize
9855         language_of_main.
9856         (free_objfile_per_bfd_storage): Remove.
9857         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9858
9859 2019-03-15  Tom Tromey  <tom@tromey.com>
9860
9861         * symfile.c (reread_symbols): Update.
9862         * objfiles.c (objfile::objfile): Update.
9863         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9864         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9865         comment.
9866         (minimal_symbol_reader::install): Update.
9867         (terminate_minimal_symbol_table): Remove.
9868         * jit.c (jit_object_close_impl): Update.
9869
9870 2019-03-15  Tom Tromey  <tom@tromey.com>
9871
9872         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9873         initializations.
9874
9875 2019-03-15  Tom Tromey  <tom@tromey.com>
9876
9877         * objfiles.h (struct objfile_per_bfd_storage)
9878         <demangled_hash_languages>: Now a bitset.
9879         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9880         (lookup_minimal_symbol): Update.
9881
9882 2019-03-15  Tom Tromey  <tom@tromey.com>
9883
9884         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9885         Don't return the symbol.
9886         * coffread.c (record_minimal_symbol): Use record_full.
9887
9888 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9889
9890         The MS-Windows port of ncurses fails to switch to a color pair if
9891         one or both of the colors are the implicit default colors.  This
9892         change records the default colors when TUI is initialized, and
9893         then specifies them explicitly when a color pair uses the default
9894         colors.  This allows color styling in TUI mode on MS-Windows.
9895
9896         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9897         ncurses_norm_attr.
9898         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9899         colors in ncurses_norm_attr.
9900         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9901         "none", replace it with the default color recorded in
9902         ncurses_norm_attr.
9903
9904 2019-03-14  Tom Tromey  <tromey@adacore.com>
9905
9906         * source-cache.h (class source_cache) <get_source_lines>: Return
9907         std::string.
9908         * source-cache.c (source_cache::extract_lines): Handle case where
9909         first_pos==npos.  Return std::string.
9910         (source_cache::get_source_lines): Update.
9911
9912 2019-03-14  Tom Tromey  <tromey@adacore.com>
9913
9914         * NEWS: Add item for "style sources" commands.
9915         * source-cache.c (source_cache::get_source_lines): Check
9916         source_styling.
9917         * cli/cli-style.c (source_styling): New global.
9918         (_initialize_cli_style): Add "style sources" commands.
9919         (show_style_sources): New function.
9920         * cli/cli-style.h (source_styling): Declare.
9921
9922 2019-03-14  Pedro Alves  <palves@redhat.com>
9923             Tom Tromey  <tromey@adacore.com>
9924
9925         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9926         * tui/tui-winsource.c (tui_refill_source_window): New function,
9927         from...
9928         (tui_horizontal_source_scroll): ... here.  Move some logic.
9929         * cli/cli-style.c (set_style_enabled): Notify new observable.
9930         * tui/tui-hooks.c (tui_redisplay_source): New function.
9931         (tui_attach_detach_observers): Attach or detach
9932         tui_redisplay_source.
9933         * observable.h (source_styling_changed): New observable.
9934         * observable.c: Define source_styling_changed observable.
9935
9936 2019-03-13  Tom Tromey  <tromey@adacore.com>
9937
9938         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9939         (i386_gnu_nat_target::store_registers): Update.
9940         * target-debug.h (target_debug_print_std_string): New macro.
9941         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9942         * windows-tdep.c (display_one_tib): Update.
9943         * tui/tui-stack.c (tui_make_status_line): Update.
9944         * top.c (print_inferior_quit_action): Update.
9945         * thread.c (thr_try_catch_cmd): Update.
9946         (add_thread_with_info): Update.
9947         (thread_target_id_str): Update.
9948         (thr_try_catch_cmd): Update.
9949         (thread_command): Update.
9950         (thread_find_command): Update.
9951         * record-btrace.c (record_btrace_target::info_record)
9952         (record_btrace_resume_thread, record_btrace_target::resume)
9953         (record_btrace_cancel_resume, record_btrace_step_thread)
9954         (record_btrace_target::wait, record_btrace_target::wait)
9955         (record_btrace_target::wait, record_btrace_target::stop): Update.
9956         * progspace.c (print_program_space): Update.
9957         * process-stratum-target.c
9958         (process_stratum_target::thread_address_space): Update.
9959         * linux-fork.c (linux_fork_mourn_inferior)
9960         (detach_checkpoint_command, info_checkpoints_command)
9961         (linux_fork_context): Update.
9962         (linux_fork_detach): Update.
9963         (class scoped_switch_fork_info): Update.
9964         (delete_checkpoint_command): Update.
9965         * infrun.c (follow_fork_inferior): Update.
9966         (follow_fork_inferior): Update.
9967         (proceed_after_vfork_done): Update.
9968         (handle_vfork_child_exec_or_exit): Update.
9969         (follow_exec): Update.
9970         (displaced_step_prepare_throw): Update.
9971         (displaced_step_restore): Update.
9972         (start_step_over): Update.
9973         (resume_1): Update.
9974         (clear_proceed_status_thread): Update.
9975         (proceed): Update.
9976         (print_target_wait_results): Update.
9977         (do_target_wait): Update.
9978         (context_switch): Update.
9979         (stop_all_threads): Update.
9980         (restart_threads): Update.
9981         (finish_step_over): Update.
9982         (handle_signal_stop): Update.
9983         (switch_back_to_stepped_thread): Update.
9984         (keep_going_pass_signal): Update.
9985         (print_exited_reason): Update.
9986         (normal_stop): Update.
9987         * inferior.c (inferior_pid_to_str): Change return type.
9988         (print_selected_inferior): Update.
9989         (add_inferior): Update.
9990         (detach_inferior): Update.
9991         * dummy-frame.c (fprint_dummy_frames): Update.
9992         * dcache.c (dcache_info_1): Update.
9993         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9994         (btrace_fetch, btrace_clear): Update.
9995         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9996         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9997         type.
9998         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9999         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10000         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10001         * gdbarch.c, gdbarch.h: Rebuild.
10002         * gdbarch.sh (core_pid_to_str): Change return type.
10003         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10004         return type.
10005         (windows_nat_target::pid_to_str): Change return type.
10006         (windows_delete_thread): Update.
10007         (windows_nat_target::attach): Update.
10008         (windows_nat_target::files_info): Update.
10009         * target-delegates.c: Rebuild.
10010         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10011         return type.
10012         (sol_thread_target::pid_to_str): Change return type.
10013         * remote.c (class remote_target) <pid_to_str>: Change return
10014         type.
10015         (remote_target::pid_to_str): Change return type.
10016         (extended_remote_target::attach, remote_target::remote_stop_ns)
10017         (remote_target::remote_notif_remove_queued_reply)
10018         (remote_target::push_stop_reply, remote_target::disable_btrace):
10019         Update.
10020         (extended_remote_target::attach): Update.
10021         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10022         type.
10023         (gdbsim_target::pid_to_str): Change return type.
10024         * ravenscar-thread.c (struct ravenscar_thread_target)
10025         <pid_to_str>: Change return type.
10026         (ravenscar_thread_target::pid_to_str): Change return type.
10027         * procfs.c (class procfs_target) <pid_to_str>: Change return
10028         type.
10029         (procfs_target::pid_to_str): Change return type.
10030         (procfs_target::attach): Update.
10031         (procfs_target::detach): Update.
10032         (procfs_target::fetch_registers): Update.
10033         (procfs_target::store_registers): Update.
10034         (procfs_target::wait): Update.
10035         (procfs_target::files_info): Update.
10036         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10037         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10038         return type.
10039         (nto_procfs_target::pid_to_str): Change return type.
10040         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10041         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10042         return type.
10043         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10044         (exit_lwp): Update.
10045         (attach_proc_task_lwp_callback, get_detach_signal)
10046         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10047         (linux_nat_target::resume, wait_lwp, stop_callback)
10048         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10049         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10050         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10051         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10052         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10053         type.
10054         (inf_ptrace_target::attach): Update.
10055         (inf_ptrace_target::files_info): Update.
10056         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10057         type.
10058         (go32_nat_target::pid_to_str): Change return type.
10059         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10060         (gnu_nat_target::wait): Update.
10061         (gnu_nat_target::wait): Update.
10062         (gnu_nat_target::resume): Update.
10063         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10064         (fbsd_nat_target::wait): Update.
10065         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10066         type.
10067         (darwin_nat_target::attach): Update.
10068         * corelow.c (class core_target) <pid_to_str>: Change return type.
10069         (core_target::pid_to_str): Change return type.
10070         * target.c (normal_pid_to_str): Change return type.
10071         (default_pid_to_str): Likewise.
10072         (target_pid_to_str): Change return type.
10073         (target_translate_tls_address): Update.
10074         (target_announce_detach): Update.
10075         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10076         return type.
10077         (bsd_uthread_target::pid_to_str): Change return type.
10078         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10079         type.
10080         (bsd_kvm_target::pid_to_str): Change return type.
10081         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10082         return type.
10083         (aix_thread_target::pid_to_str): Change return type.
10084         * target.h (struct target_ops) <pid_to_str>: Change return type.
10085         (target_pid_to_str, normal_pid_to_str): Likewise.
10086         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10087         type.
10088         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10089         type.
10090         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10091         return type.
10092         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10093         type.
10094         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10095         type.
10096         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10097         return type.
10098
10099 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10100
10101         * NEWS: Mention that the new default MI version is 3.  Mention
10102         changes to the output of commands and events that deal with
10103         multi-location breakpoints.
10104         * breakpoint.c: Include "mi/mi-out.h".
10105         (print_one_breakpoint): Change output syntax if using MI version
10106         >= 3.
10107         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10108         New.
10109         (mi_multi_location_breakpoint_output_fixed): New.
10110         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10111         (mi_cmd_fix_multi_location_breakpoint_output): New.
10112         (mi_multi_location_breakpoint_output_fixed): New.
10113         * mi/mi-cmds.c (mi_cmds): Register command
10114         -fix-multi-location-breakpoint-output.
10115         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10116         interpreter "mi".
10117
10118 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10119
10120         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10121         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10122         instantiate mi_ui_out based on interpreter name.
10123         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10124         * mi/mi-main.c (mi_load_progress): Likewise.
10125
10126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10127
10128         * NEWS: Combine separate "New targets" sections for 8.3.
10129
10130 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10131
10132         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10133         (ppcfbsd_init_abi): Install gdbarch
10134         "fetch_tls_load_module_address" and "get_thread_local_address"
10135         methods.
10136
10137 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10138
10139         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10140         (riscv_fbsd_init_abi): Install gdbarch
10141         "fetch_tls_load_module_address" and "get_thread_local_address"
10142         methods.
10143
10144 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10145
10146         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10147         (i386fbsd_init_abi): Install gdbarch
10148         "fetch_tls_load_module_address" and "get_thread_local_address"
10149         methods.
10150
10151 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10152
10153         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10154         (amd64fbsd_init_abi): Install gdbarch
10155         "fetch_tls_load_module_address" and "get_thread_local_address"
10156         methods.
10157
10158 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10159
10160         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10161         (struct fbsd_pspace_data): New type.
10162         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10163         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10164         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10165         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10166         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10167
10168 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10169
10170         * gdbtypes.c (lookup_struct_elt): New function.
10171         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10172         * gdbtypes.h (struct struct_elt): New type.
10173         (lookup_struct_elt): New prototype.
10174
10175 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10176
10177         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10178         remove disabled code block.
10179
10180 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10181
10182         * gdbarch.sh (get_thread_local_address): New method.
10183         * gdbarch.h, gdbarch.c: Regenerate.
10184         * target.c (target_translate_tls_address): Use
10185         gdbarch_get_thread_local_address if present instead of
10186         target::get_thread_local_address.
10187
10188 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10189
10190         * target.h (target::get_thread_local_address): Update comment.
10191
10192 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10193
10194         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10195         objfile->separate_debug_objfile_backlink if not NULL.
10196
10197 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10198
10199         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10200         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10201         (amd64bsd_store_inferior_registers): Likewise.
10202         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10203         Enable segment base registers.
10204         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10205         PT_GETFSBASE and PT_GETGSBASE.
10206         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10207         PT_SETGSBASE.
10208         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10209         segment base registers.
10210         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10211
10212 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10213
10214         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10215         Update calls to i386_target_description to add 'segments'
10216         parameter.
10217         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10218         add segment base registers.
10219         * arch/i386.c (i386_create_target_description): Add 'segments'
10220         parameter to enable segment base registers.
10221         * arch/i386.h (i386_create_target_description): Likewise.
10222         * features/i386/32bit-segments.xml: New file.
10223         * features/i386/32bit-segments.c: Generate.
10224         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10225         call to i386_target_description to add 'segments' parameter.
10226         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10227         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10228         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10229         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10230         if feature is present.
10231         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10232         Add 'segments' parameter to call to i386_target_description.
10233         (i386_target_description): Add 'segments' parameter to enable
10234         segment base registers.
10235         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10236         to call to i386_target_description.
10237         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10238         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10239         Define I386_NUM_REGS.
10240         (i386_target_description): Add 'segments' parameter to enable
10241         segment base registers.
10242
10243 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10244
10245         PR/24325
10246         * source-cache.c: #undef open and close, to avoid unresolved
10247         externals during linking.
10248
10249 2019-03-12  Tom Tromey  <tromey@adacore.com>
10250
10251         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10252         const.  Add initializers.
10253         (_initialize_remote): Don't initialize ptid globals.
10254
10255 2019-03-12  Pedro Alves  <palves@redhat.com>
10256
10257         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10258
10259 2019-03-12  Pedro Alves  <palves@redhat.com>
10260
10261         * cp-name-parser.y (main): Remove unused 'len' variable.
10262
10263 2019-03-12  Tom Tromey  <tromey@adacore.com>
10264
10265         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10266         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10267
10268 2019-03-12  Tom Tromey  <tromey@adacore.com>
10269
10270         * linux-nat.c (iterate_over_lwps): Update.
10271         (stop_callback): Remove parameter.
10272         (stop_wait_callback, detach_callback, resume_set_callback)
10273         (select_singlestep_lwp_callback, set_ignore_sigint)
10274         (status_callback, resumed_callback, resume_clear_callback)
10275         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10276         data parameter.
10277         (linux_nat_target::detach, linux_nat_target::resume)
10278         (linux_stop_and_wait_all_lwps, select_event_lwp)
10279         (linux_nat_filter_event, linux_nat_wait_1)
10280         (linux_nat_target::kill, linux_nat_target::stop)
10281         (linux_nat_target::stop): Update.
10282         (linux_nat_resume_callback): Change type.
10283         (resume_stopped_resumed_lwps, count_events_callback)
10284         (select_event_lwp_callback): Likewise.
10285         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10286         * arm-linux-nat.c (struct update_registers_data): Remove.
10287         (update_registers_callback): Change type.
10288         (arm_linux_insert_hw_breakpoint1): Update.
10289         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10290         parameter.
10291         (x86_linux_dr_set_addr): Update.
10292         (x86_linux_dr_set_control): Update.
10293         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10294         (iterate_over_lwps): Use gdb::function_view.
10295         * nat/aarch64-linux-hw-point.c (struct
10296         aarch64_dr_update_callback_param): Remove.
10297         (debug_reg_change_callback): Change type.
10298         (aarch64_notify_debug_reg_change): Update.
10299         * s390-linux-nat.c (s390_refresh_per_info): Update.
10300
10301 2019-03-11  Tom Tromey  <tromey@adacore.com>
10302
10303         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10304         redundant assignment to "this_cu".
10305
10306 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10307
10308         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10309
10310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10311
10312         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10313         from...
10314         (rank_one_type): ... this.
10315
10316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10317
10318         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10319         from...
10320         (rank_one_type): ... this.
10321
10322 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10323
10324         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10325         from...
10326         (rank_one_type): ... this.
10327
10328 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10329
10330         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10331         from...
10332         (rank_one_type): ... this.
10333
10334 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10335
10336         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10337         from...
10338         (rank_one_type): ... this.
10339
10340 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10341
10342         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10343         from...
10344         (rank_one_type): ... this.
10345
10346 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10347
10348         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10349         from...
10350         (rank_one_type): ... this.
10351
10352 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10353
10354         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10355         from...
10356         (rank_one_type): ... this.
10357
10358 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10359
10360         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10361         from...
10362         (rank_one_type): ... this.
10363
10364 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10365
10366         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10367         from...
10368         (rank_one_type): ... this.
10369
10370 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10371
10372         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10373         from...
10374         (rank_one_type): ... this.
10375
10376 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10377
10378         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10379         from...
10380         (rank_one_type): ... this.
10381
10382 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10383
10384         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10385         inferior-events' shows the example events.
10386
10387 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10388
10389         Support styling on native MS-Windows console
10390
10391         PR/24315
10392         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10393         on MS-Windows if $TERM is not defined.
10394
10395         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10396
10397         * posix-hdep.c (gdb_console_fputs):
10398         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10399         functions.
10400         * ui-file.h (gdb_console_fputs): Add prototype.
10401
10402         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10403         back to fputs only if the former returns zero.
10404
10405 2019-03-07  Tom Tromey  <tom@tromey.com>
10406
10407         * symmisc.c (print_symbol_bcache_statistics): Update.
10408         (print_objfile_statistics): Update.
10409         * symfile.c (allocate_symtab): Update.
10410         * stabsread.c: Don't include bcache.h.
10411         * psymtab.h (struct psymbol_bcache): Don't declare.
10412         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10413         (psymbol_bcache_init, psymbol_bcache_free)
10414         (psymbol_bcache_get_bcache): Don't declare.
10415         * psymtab.c (struct psymbol_bcache): Remove.
10416         (psymtab_storage::psymtab_storage): Update.
10417         (psymtab_storage::~psymtab_storage): Update.
10418         (psymbol_bcache_init, psymbol_bcache_free)
10419         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10420         (add_psymbol_to_bcache): Update.
10421         (allocate_psymtab): Update.
10422         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10423         macro_cache>: No longer pointers.
10424         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10425         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10426         * macrotab.c (macro_bcache): Update.
10427         * macroexp.c: Don't include bcache.h.
10428         * gdbtypes.c (check_types_worklist): Update.
10429         (types_deeply_equal): Remove TRY/CATCH.  Update.
10430         * elfread.c (elf_symtab_read): Update.
10431         * dwarf2read.c: Don't include bcache.h.
10432         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10433         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10434         (print_bcache_statistics, bcache_memory_used): Don't declare.
10435         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10436         methods.  Rename all data members.
10437         * bcache.c (struct bcache): Move to bcache.h.
10438         (bcache::expand_hash_table): Rename from expand_hash_table.
10439         (bcache): Remove.
10440         (bcache::insert): Rename from bcache_full.
10441         (bcache::compare): Rename from bcache_compare.
10442         (bcache_xmalloc): Remove.
10443         (bcache::~bcache): Rename from bcache_xfree.
10444         (bcache::print_statistics): Rename from print_bcache_statistics.
10445         (bcache::memory_used): Rename from bcache_memory_used.
10446
10447 2019-03-07  Pedro Alves  <palves@redhat.com>
10448
10449         * infrun.c (normal_stop): Also check for
10450         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10451
10452 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10453
10454         * f-lang.c (value_from_host_double): Moved to...
10455         * value.c (value_from_host_double): ...here.
10456         * value.h (value_from_host_double): Declare.
10457         * guile/scm-math.c (vlscm_convert_typed_number): Use
10458         value_from_host_double.
10459         (vlscm_convert_number): Likewise.
10460         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10461         * python/py-value.c (convert_value_from_python): Likewise.
10462
10463 2019-03-06  Tom Tromey  <tom@tromey.com>
10464
10465         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10466
10467 2019-03-06  Tom Tromey  <tom@tromey.com>
10468
10469         * utils.h (free_current_contents): Don't declare.
10470         * utils.c (free_current_contents): Remove.
10471
10472 2019-03-06  Tom Tromey  <tom@tromey.com>
10473
10474         * top.c (quit_force): Update.
10475         * main.c (captured_command_loop): Update.
10476         * common/new-op.c (operator new): Update.
10477         * common/common-exceptions.c (struct catcher)
10478         <save_cleanup_chain>: Remove member.
10479         (exceptions_state_mc_init): Update.
10480         (exception_try_scope_entry): Return nullptr.
10481         (exception_try_scope_exit, exception_rethrow)
10482         (throw_exception_sjlj, throw_exception_cxx): Update.
10483         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10484         (all_cleanups, do_cleanups, discard_cleanups)
10485         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10486         (restore_cleanups, restore_final_cleanups): Don't declare.
10487         (do_final_cleanups): Remove parameter.
10488         * common/cleanups.c (cleanup_chain, make_cleanup)
10489         (make_cleanup_dtor, all_cleanups, do_cleanups)
10490         (discard_my_cleanups, discard_cleanups)
10491         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10492         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10493         (null_cleanup): Remove.
10494         (do_final_cleanups): Remove parameter.
10495
10496 2019-03-06  Tom Tromey  <tom@tromey.com>
10497
10498         * remote.c (remote_target::remote_parse_stop_reply): Use
10499         unique_xmalloc_ptr.
10500
10501 2019-03-06  Tom Tromey  <tom@tromey.com>
10502
10503         * stabsread.c (struct stabs_field_info): Rename from field_info.
10504         <list, fnlist>: Add initializers.
10505         <obstack>: New member.
10506         (read_member_functions, read_struct_fields, read_baseclasses):
10507         Allocate on obstack.  Don't use cleanups.
10508         (read_one_struct_field, read_member_functions, read_struct_fields)
10509         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10510         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10511         (read_struct_type): Update.
10512
10513 2019-03-06  Tom Tromey  <tom@tromey.com>
10514
10515         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10516         * common/filestuff.h (make_cleanup_close): Don't declare.
10517         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10518         Remove.
10519
10520 2019-03-06  Tom Tromey  <tom@tromey.com>
10521
10522         * solib-aix.c: Use make_scope_exit.
10523
10524 2019-03-06  Tom Tromey  <tom@tromey.com>
10525
10526         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10527         Use make_scope_exit.
10528
10529 2019-03-06  Tom Tromey  <tom@tromey.com>
10530
10531         * solib-svr4.c (disable_probes_interface): Remove parameter.
10532         (svr4_handle_solib_event): Use make_scope_exit.
10533
10534 2019-03-06  Tom Tromey  <tom@tromey.com>
10535
10536         * remote.c (struct stop_reply_deleter): Remove.
10537         (stop_reply_up): Update.
10538         (struct stop_reply): Derive from notif_event.  Don't typedef.
10539         <regcache>: Now a std::vector.
10540         (stop_reply_xfree): Remove.
10541         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10542         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10543         (remote_target::discard_pending_stop_replies): Use delete.
10544         (remote_target::remote_parse_stop_reply): Update.
10545         (remote_target::process_stop_reply): Update.
10546         * remote-notif.h (struct notif_event): Add virtual destructor.
10547         Remove "dtr" member.
10548         (struct notif_client) <alloc_event>: Return a unique_ptr.
10549         (notif_event_xfree): Don't declare.
10550         (notif_event_up): New typedef.
10551         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10552         (notif_event_xfree, do_notif_event_xfree): Remove.
10553         (remote_notif_state_xfree): Update.
10554
10555 2019-03-06  Tom Tromey  <tom@tromey.com>
10556
10557         * infrun.c (displaced_step_clear_cleanup): Now a
10558         forward_scope_exit type.
10559         (displaced_step_prepare_throw): Update.
10560         (displaced_step_fixup): Update.
10561
10562 2019-03-06  Tom Tromey  <tom@tromey.com>
10563
10564         * inferior.h (class inferior): Update comment.
10565         * gdbthread.h (class thread_info): Update comment.
10566
10567 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10568             Tom Tromey  <tom@tromey.com>
10569
10570         * stabsread.h (struct stab_section_list): Remove.
10571         (coffstab_build_psymtabs): Update.
10572         * dbxread.c (symbuf_sections): Now a std::vector.
10573         (sect_idx): New global.
10574         (fill_symbuf): Update.
10575         (coffstab_build_psymtabs): Change type of stabsects parameter.
10576         Update.
10577         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10578         std::vector.
10579         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10580         (coff_locate_sections): Update.
10581         (coff_symfile_read): Remove cleanups.  Update.
10582         (init_stringtab): Add storage parameter.
10583         (free_stringtab, free_stringtab_cleanup): Remove.
10584         (init_lineno): Add storage parameter.
10585         (free_linetab, free_linetab_cleanup): Remove.
10586
10587 2019-03-06  Pedro Alves  <palves@redhat.com>
10588
10589         * linux-fork.c (fork_info::clobber_regs): Delete.
10590         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10591         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10592         comment.  Adjust.
10593         (scoped_switch_fork_info::scoped_switch_fork_info)
10594         (checkpoint_command, linux_fork_context): Adjust
10595         fork_save_infrun_state calls.
10596
10597 2019-03-06  Pedro Alves  <palves@redhat.com>
10598
10599         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10600         (inf_has_multiple_threads): Return 'bool' and rewrite using
10601         inferior_info::threads().
10602
10603 2019-03-06  Pedro Alves  <palves@redhat.com>
10604
10605         * linux-fork.c: Include <list>.
10606         (fork_list): Now a std::list instance.
10607         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10608         (forks_exist_p, find_last_fork): Adjust.
10609         (new_fork): Delete.
10610         (one_fork_p): New.
10611         (add_fork): Adjust.
10612         (free_fork): Delete, folded into fork_info::~fork_info().
10613         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10614         Adjust.
10615         (init_fork_list): Delete.
10616         (linux_fork_killall, linux_fork_mourn_inferior)
10617         (linux_fork_detach, info_checkpoints_command): Adjust.
10618         (_initialize_linux_fork): No longer call init_fork_list.
10619
10620 2019-03-06  Pedro Alves  <palves@redhat.com>
10621
10622         * linux-fork.c (new_fork): New, split out of ...
10623         (add_fork): ... this.  Return void.  Move "first fork" special
10624         case from here, to ...
10625         (checkpoint_command): ... here.
10626         * linux-linux.h (add_fork): Return void.
10627
10628 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10629
10630         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10631
10632 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10633             Chris January  <chris.january@arm.com>
10634             David Lecomber  <david.lecomber@arm.com>
10635
10636         * f-exp.y: New token, UNOP_INTRINSIC.
10637         (exp): New pattern using UNOP_INTRINSIC token.
10638         (f77_keywords): Add 'abs' keyword.
10639         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10640         (value_from_host_double): New function.
10641         (evaluate_subexp_f): Support UNOP_ABS.
10642
10643 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10644
10645         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10646         types.
10647
10648 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10649
10650         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10651         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10652         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10653
10654 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10655
10656         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10657
10658 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10659             Chris January  <chris.january@arm.com>
10660
10661         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10662         * f-exp.y: Define 'KIND' token.
10663         (exp): New pattern for KIND expressions.
10664         (ptype): Handle types with a kind extension.
10665         (direct_abs_decl): Extend to spot kind extensions.
10666         (f77_keywords): Add 'kind' to the list.
10667         (push_kind_type): New function.
10668         (convert_to_kind_type): New function.
10669         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10670         * parse.c (operator_length_standard): Likewise.
10671         * parser-defs.h (enum type_pieces): Add tp_kind.
10672         * std-operator.def: Add UNOP_KIND.
10673
10674 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10675
10676         * f-exp.y (f_parse): Set yydebug.
10677
10678 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10679
10680         * f-lang.c (evaluate_subexp_f): New function.
10681         (exp_descriptor_f): New global.
10682         (f_language_defn): Use exp_descriptor_f instead of
10683         exp_descriptor_standard.
10684
10685 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10686
10687         * f-exp.y (struct token): Add comments.
10688         (dot_ops): Remove uppercase versions and the end marker.
10689         (f77_keywords): Likewise.
10690         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10691         entries in the dot_ops array are case insensitive, and use
10692         strncasecmp to compare strings.  Also some whitespace cleanup in
10693         this area.  Similar for the f77_keywords array, except entries in
10694         this list might be case sensitive.
10695
10696 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10697
10698         * f-exp.y (struct f77_boolean_val): Add comments.
10699         (boolean_values): Remove uppercase versions, and end marker.
10700         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10701         and use strncasecmp to achieve case insensitivity.  Additionally,
10702         perform whitespace cleanup around this code.
10703
10704 2019-03-06  Tom Tromey  <tromey@adacore.com>
10705
10706         * remote-sim.c (gdbsim_target_open): Use result of
10707         gdb_argv::release.
10708
10709 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10710         Dirk Schubert  <dirk.schubert@arm.com>
10711         Chris January  <chris.january@arm.com>
10712
10713         * eval.c (evaluate_subexp_standard): Call Fortran argument
10714         wrapping logic.
10715         * f-lang.c (struct value): A value which can be passed into a
10716         Fortran function call.
10717         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10718         where appropriate.
10719         (struct type): Value ready for a Fortran function call.
10720         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10721         is needed.
10722         * f-lang.h (fortran_argument_convert): Declaration.
10723         (fortran_preserve_arg_pointer): Declaration.
10724         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10725
10726 2019-03-05  Tom Tromey  <tromey@adacore.com>
10727
10728         * python/py-prettyprint.c (print_string_repr): Remove #if.
10729         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10730
10731 2019-03-05  Tom Tromey  <tromey@adacore.com>
10732
10733         * target.c (the_dummy_target): Move later.  Change type to
10734         "dummy_target".
10735         (initialize_targets): Don't initialize the_dummy_target.
10736
10737 2019-03-05  Tom Tromey  <tromey@adacore.com>
10738
10739         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10740         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10741
10742 2019-03-05  Tom Tromey  <tromey@adacore.com>
10743
10744         * windows-nat.c (windows_nat_target::attach)
10745         (windows_nat_target::detach): Don't call gdb_flush.
10746         * valprint.c (generic_val_print, val_print, val_print_string):
10747         Don't call gdb_flush.
10748         * utils.c (defaulted_query): Don't call gdb_flush.
10749         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10750         * target.c (target_announce_detach): Don't call gdb_flush.
10751         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10752         * remote.c (extended_remote_target::attach): Don't call
10753         gdb_flush.
10754         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10755         * printcmd.c (do_examine): Don't call gdb_flush.
10756         (info_display_command): Don't call gdb_flush.
10757         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10758         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10759         * memattr.c (info_mem_command): Don't call gdb_flush.
10760         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10761         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10762         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10763         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10764         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10765         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10766         (gnu_nat_target::detach): Don't call gdb_flush.
10767         * f-valprint.c (f_val_print): Don't call gdb_flush.
10768         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10769         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10770         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10771         gdb_flush.
10772         * c-valprint.c (c_val_print): Don't call gdb_flush.
10773         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10774
10775 2019-03-05  Tom Tromey  <tromey@adacore.com>
10776
10777         * varobj.c (update_dynamic_varobj_children): Update.
10778         (install_default_visualizer): Use reset, not release.
10779         * value.c (set_internalvar): Update.
10780         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10781         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10782         ATTRIBUTE_UNUSED_RESULT.
10783
10784 2019-03-05  Tom Tromey  <tromey@adacore.com>
10785
10786         * remote.c (class scoped_remote_fd) <release>: Add
10787         ATTRIBUTE_UNUSED_RESULT.
10788
10789 2019-03-05  Tom Tromey  <tromey@adacore.com>
10790
10791         * macroexp.c (struct macro_buffer) <release>: Add
10792         ATTRIBUTE_UNUSED_RESULT.
10793
10794 2019-03-05  Tom Tromey  <tromey@adacore.com>
10795
10796         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10797         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10798         ATTRIBUTE_UNUSED_RESULT.
10799
10800 2019-03-05  Tom Tromey  <tromey@adacore.com>
10801
10802         * common/scoped_fd.h (class scoped_fd) <release>: Add
10803         ATTRIBUTE_UNUSED_RESULT.
10804
10805 2019-03-05  Tom Tromey  <tromey@adacore.com>
10806
10807         * parser-defs.h (struct parser_state) <release>: Add
10808         ATTRIBUTE_UNUSED_RESULT.
10809
10810 2019-03-05  Tom Tromey  <tromey@adacore.com>
10811
10812         * utils.h (class gdb_argv) <release>: Add
10813         ATTRIBUTE_UNUSED_RESULT.
10814         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10815
10816 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10817
10818         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10819         for-loop range, to avoid compiler warnings.
10820
10821         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10822         avoid compiler warnings about unused variables.
10823
10824         * NEWS: Mention end of support for native debugging on MS-Windows
10825         before XP.
10826
10827         PR gdb/24292
10828         * common/netstuff.c:
10829         * gdbserver/gdbreplay.c
10830         * gdbserver/remote-utils.c:
10831         * ser-tcp.c:
10832         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10833         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10834         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10835         'getaddrinfo' and 'freeaddrinfo' were not available before
10836         Windows XP, and mingw.org's MinGW headers by default define
10837         _WIN32_WINNT to 0x500.
10838
10839 2019-03-01  Gary Benson <gbenson@redhat.com>
10840
10841         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10842
10843 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10844             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10845
10846         PR gdb/8527
10847         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10848         set_sigint_trap, clear_sigint_trap.
10849
10850 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10851
10852         * target.c (target_detach): Clear the regcache and the
10853         frame cache.
10854
10855 2019-02-27  Pedro Alves  <palves@redhat.com>
10856
10857         * utils.c (set_screen_size): When we cap the height/width sizes,
10858         tweak the corresponding command variable to show "unlimited":
10859
10860 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10861             Pedro Alves  <palves@redhat.com>
10862
10863         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10864         before calling rl_set_screen_size.
10865
10866 2019-02-27  Tom Tromey  <tromey@adacore.com>
10867
10868         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10869         define.
10870         * python/py-value.c: Remove Python 2.4 workaround.
10871         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10872         workaround.
10873         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10874         Python 2.4 workaround.
10875         * python/python-internal.h: Remove Python 2.4 comment.
10876         (Py_ssize_t): Don't define.
10877         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10878         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10879         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10880         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10881         * python/python.c (do_start_initialization): Remove Python 2.4
10882         workaround.
10883         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10884         (print_children): Remove Python 2.4 workaround.
10885         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10886         workaround.
10887         (CHARBUFFERPROC_NAME): Remove.
10888         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10889         Python 2.4 workaround.
10890
10891 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10892
10893         * NEWS: Note minimum Python version.
10894
10895 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10896
10897         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10898         code from these functions.  Remove corresponding ifdefs.  Use
10899         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10900         Remove gotos and target of gotos.
10901         (infpy_search_memory): Likewise.
10902
10903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10904
10905         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10906         (hppa_gdbarch_init): Don't register deleted functions with
10907         gdbarch.
10908
10909 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10910
10911         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10912         (h8300_unwind_sp): Delete.
10913         (h8300_dummy_id): Delete.
10914         (h8300_gdbarch_init): Don't register deleted functions with
10915         gdbarch.
10916
10917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10918
10919         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10920         (ft32_unwind_pc): Delete.
10921         (ft32_unwind_sp): Delete.
10922         (ft32_gdbarch_init): Don't register deleted functions with
10923         gdbarch.
10924
10925 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10926
10927         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10928         (frv_unwind_pc): Delete.
10929         (frv_unwind_sp): Delete.
10930         (frv_gdbarch_init): Don't register deleted functions with
10931         gdbarch.
10932
10933 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10934
10935         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10936         (riscv_unwind_pc): Delete.
10937         (riscv_unwind_sp): Delete.
10938         (riscv_gdbarch_init): Don't register deleted functions with
10939         gdbarch.
10940
10941 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10942
10943         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10944         (csky_unwind_pc): Delete.
10945         (csky_unwind_sp): Delete.
10946         (csky_gdbarch_init): Don't register deleted functions with
10947         gdbarch.
10948
10949 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10950
10951         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10952         (cris_unwind_pc): Delete.
10953         (cris_unwind_sp): Delete.
10954         (cris_gdbarch_init): Don't register deleted functions with
10955         gdbarch.
10956
10957 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10958
10959         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10960         (bfin_unwind_pc): Delete.
10961         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10962
10963 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10964
10965         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10966         (arm_unwind_pc): Delete.
10967         (arm_unwind_sp): Delete.
10968         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10969
10970 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10971
10972         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10973         (arc_unwind_pc): Delete.
10974         (arc_unwind_sp): Delete.
10975         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10976
10977 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10978
10979         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10980         (alpha_unwind_pc): Delete.
10981         (alpha_gdbarch_init): Don't register deleted functions with
10982         gdbarch.
10983
10984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10985
10986         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10987         (aarch64_unwind_pc): Delete.
10988         (aarch64_unwind_sp): Delete.
10989         (aarch64_gdbarch_init): Don't register deleted functions with
10990         gdbarch.
10991
10992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10993
10994         * gdbtypes.c (type_align): Don't consider static members when
10995         computing structure alignment.
10996
10997 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10998
10999         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11000         return 0 for other types.
11001         * arch-utils.c (default_type_align): Always return 0.
11002         * gdbarch.h: Regenerate.
11003         * gdbarch.sh (type_align): Extend comment.
11004         * gdbtypes.c (type_align): Add additional comments, always call
11005         gdbarch_type_align before applying the default rules.
11006         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11007         generic code will then apply a suitable default.
11008         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11009         types, return 0 for other types.
11010
11011 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11012
11013         * NEWS: Create a new section for the next release branch.
11014         Rename the section of the current branch, now that it has
11015         been cut.
11016
11017 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11018
11019         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11020         * version.in: Bump version to 8.3.50.DATE-git.
11021
11022 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11023
11024         * aix-thread.c (ptid_cmp): Remove unused variable.
11025         (get_signaled_thread): Likewise.
11026         (store_regs_user_thread): Likewise.
11027         (store_regs_kernel_thread): Likewise.
11028         (fetch_regs_kernel_thread): Remove shadowed variable.
11029
11030 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11031
11032         * features/riscv/32bit-cpu.xml: Add register numbers.
11033         * features/riscv/32bit-fpu.c: Regenerate.
11034         * features/riscv/32bit-fpu.xml: Add register numbers.
11035         * features/riscv/64bit-cpu.xml: Add register numbers.
11036         * features/riscv/64bit-fpu.c: Regenerate.
11037         * features/riscv/64bit-fpu.xml: Add register numbers.
11038
11039 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11040
11041         * NEWS: Mention two argument form of gdb.Value constructor.
11042         * python/py-value.c (convert_buffer_and_type_to_value): New
11043         function.
11044         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11045         Add support for handling an optional second argument.  Call
11046         convert_buffer_and_type_to_value as appropriate.
11047         * python/python-internal.h (Py_buffer_deleter): New struct.
11048         (Py_buffer_up): New typedef.
11049
11050 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11051
11052         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11053         instead of releasing ownership.
11054
11055 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11056
11057         * dwarf2read.c (open_and_init_dwp_file): Call
11058         elf_numsections instead of bfd_count_sections to initialize
11059         dwp_file->num_sections.
11060
11061 2019-02-25  Tom Tromey  <tromey@adacore.com>
11062
11063         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11064
11065 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11066
11067         * gcore.in: Add '--readnever' option when invoking GDB.
11068
11069 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11070
11071         * MAINTAINERS: Update my email address.
11072
11073 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11074
11075         * build-id.c (build_id_to_debug_bfd_1): New function.
11076         (build_id_to_debug_bfd): Look for separate debug file in
11077         sysroot.
11078
11079 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11080
11081         * gdbarch.sh: Update the copyright year range that is placed into
11082         generated files.
11083
11084 2019-02-22  Keith Seitz  <keiths@redhat.com>
11085
11086         PR symtab/23853
11087         * linespec.c (create_sals_line_offset): Search for the default
11088         symtab's filename instead of its fullname.
11089
11090 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11091
11092         * NEWS: Update style defaults.
11093
11094 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11095
11096         * main.c (captured_main_1): Disable styling in batch mode.
11097
11098 2019-02-20  Tom Tromey  <tom@tromey.com>
11099
11100         * symtab.c (symtab_symbol_info): Fix typos.
11101
11102 2019-02-20  Tom Tromey  <tromey@adacore.com>
11103
11104         * findcmd.c (_initialize_mem_search): Use upper case for
11105         metasyntactic variables.
11106
11107 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11108
11109         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11110         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11111
11112 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11113
11114         * top.h (source_file_name): Change to std::string.
11115         * top.c (source_file_name): Likewise.
11116         (command_line_input): Adjust.
11117         * cli/cli-script.c (script_from_file): Adjust.
11118
11119 2019-02-19  Tom Tromey  <tromey@adacore.com>
11120
11121         * ravenscar-thread.c
11122         (ravenscar_thread_target::update_thread_list): Don't call
11123         ada_build_task_list.
11124         * ada-lang.h (ada_build_task_list): Don't declare.
11125         * ada-tasks.c (struct ada_tasks_inferior_data)
11126         <task_list_valid_p>: Now bool.
11127         (read_known_tasks, ada_task_list_changed)
11128         (ada_tasks_invalidate_inferior_data): Update.
11129         (read_known_tasks_array): Return bool.
11130         (read_known_tasks_list): Likewise.
11131         (read_known_tasks): Return void.
11132         (ada_build_task_list): Now static.
11133
11134 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11135
11136         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11137         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11138
11139 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11140
11141         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11142         variant for ada_tasks_pspace_data_handle and
11143         ada_tasks_inferior_data_handle.
11144         (ada_tasks_pspace_data_cleanup): New function.
11145         (ada_tasks_inferior_data_cleanup): New function.
11146
11147 2019-02-17  Tom Tromey  <tom@tromey.com>
11148
11149         * macrotab.h (macro_source_fullname): Return a std::string.
11150         * macrotab.c (macro_include, check_for_redefinition)
11151         (macro_undef, macro_lookup_definition, foreach_macro)
11152         (foreach_macro_in_scope): Update.
11153         (macro_source_fullname): Return a std::string.
11154         * macrocmd.c (show_pp_source_pos): Update.
11155
11156 2019-02-17  Tom Tromey  <tom@tromey.com>
11157
11158         * macrocmd.c (show_pp_source_pos): Style the file names.
11159
11160 2019-02-17  Tom Tromey  <tom@tromey.com>
11161
11162         PR tui/24197:
11163         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11164
11165 2019-02-17  Tom Tromey  <tom@tromey.com>
11166
11167         * ada-lang.c (user_select_syms): Use filtered printing.
11168         * utils.c (wrap_style): New global.
11169         (desired_style): Remove.
11170         (emit_style_escape): Add stream parameter.
11171         (set_output_style, reset_terminal_style, prompt_for_continue):
11172         Update.
11173         (flush_wrap_buffer): Only flush gdb_stdout.
11174         (wrap_here): Set wrap_style.
11175         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11176         treat escape sequences as a character.  Change when wrap buffer is
11177         flushed.
11178         (fputs_styled): Do not set the output style when the default is
11179         requested.
11180         * ui-style.h (struct ui_file_style) <is_default>: New method.
11181         * source.c (print_source_lines_base): Emit escape sequences in one
11182         piece.
11183
11184 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11185
11186         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11187         integers and enumeration types.
11188
11189 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11190
11191         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11192         instead of lookup_symbol_in_language
11193         (do_exact_match): New function.
11194         (ada_get_symbol_name_matcher): Return do_exact_match when
11195         doing a verbatim match.
11196
11197 2019-02-15  Tom Tromey  <tromey@adacore.com>
11198
11199         * ravenscar-thread.c (ravenscar_thread_target::resume)
11200         (ravenscar_thread_target::wait): Special case wildcard requests.
11201
11202 2019-02-15  Tom Tromey  <tromey@adacore.com>
11203
11204         * ravenscar-thread.c (base_ptid): Remove.
11205         (struct ravenscar_thread_target) <close>: New method.
11206         <m_base_ptid>: New member.
11207         <update_inferior_ptid, active_task, task_is_currently_active,
11208         runtime_initialized>: Declare methods.
11209         <ravenscar_thread_target>: Add constructor.
11210         (ravenscar_thread_target::task_is_currently_active)
11211         (ravenscar_thread_target::update_inferior_ptid)
11212         (ravenscar_runtime_initialized): Rename.  Now methods.
11213         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11214         (ravenscar_thread_target::update_thread_list): Update.
11215         (ravenscar_thread_target::active_task): Now method.
11216         (ravenscar_thread_target::store_registers)
11217         (ravenscar_thread_target::prepare_to_store)
11218         (ravenscar_thread_target::prepare_to_store)
11219         (ravenscar_thread_target::mourn_inferior): Update.
11220         (ravenscar_inferior_created): Use "new" to create target.
11221         (ravenscar_thread_target::get_ada_task_ptid): Update.
11222         (_initialize_ravenscar): Don't initialize base_ptid.
11223         (ravenscar_ops): Remove global.
11224
11225 2019-02-15  Tom Tromey  <tromey@adacore.com>
11226
11227         * target.h (push_target): Declare new overload.
11228         * target.c (push_target): New overload, taking an rvalue reference.
11229         * remote.c (remote_target::open_1): Use push_target overload.
11230         * corelow.c (core_target_open): Use push_target overload.
11231
11232 2019-02-15  Tom Tromey  <tromey@adacore.com>
11233
11234         * ravenscar-thread.c (is_ravenscar_task)
11235         (ravenscar_task_is_currently_active): Return bool.
11236         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11237         (_initialize_ravenscar): Remove "(void)".
11238         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11239         Return bool.
11240
11241 2019-02-15  Tom Tromey  <tromey@adacore.com>
11242
11243         * ravenscar-thread.c (ravenscar_runtime_initializer)
11244         (has_ravenscar_runtime, get_running_thread_id)
11245         (ravenscar_thread_target::resume): Fix indentation.
11246
11247 2019-02-15  Tom Tromey  <tromey@adacore.com>
11248
11249         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11250         from ravenscar_arch_ops.
11251         (sparc_ravenscar_ops::fetch_registers)
11252         (sparc_ravenscar_ops::store_registers): Now methods.
11253         (sparc_ravenscar_prepare_to_store): Remove.
11254         (sparc_ravenscar_ops): Redefine.
11255         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11256         methods and destructor.  Remove members.
11257         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11258         (ravenscar_thread_target::store_registers)
11259         (ravenscar_thread_target::prepare_to_store): Update.
11260         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11261         Remove.
11262         (struct ppc_ravenscar_powerpc_ops): Derive from
11263         ravenscar_arch_ops.
11264         (ppc_ravenscar_powerpc_ops::fetch_registers)
11265         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11266         (ppc_ravenscar_powerpc_ops): Redefine.
11267         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11268         (ppc_ravenscar_e500_ops::fetch_registers)
11269         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11270         (ppc_ravenscar_e500_ops): Redefine.
11271         * aarch64-ravenscar-thread.c
11272         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11273         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11274         (aarch64_ravenscar_fetch_registers)
11275         (aarch64_ravenscar_store_registers): Now methods.
11276         (aarch64_ravenscar_ops): Redefine.
11277
11278 2019-02-15  Tom Tromey  <tromey@adacore.com>
11279
11280         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11281         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11282         (ravenscar_thread_target::stopped_by_watchpoint)
11283         (ravenscar_thread_target::stopped_data_address)
11284         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11285
11286 2019-02-15  Tom Tromey  <tromey@adacore.com>
11287
11288         * ravenscar-thread.c: Fix some typos.
11289
11290 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11291             Tom Tromey  <tromey@adacore.com>
11292
11293         * ada-lang.c (ada_exception_sal): Change addr_string to a
11294         std::string.
11295         (create_ada_exception_catchpoint): Update.
11296
11297 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11298             Tom Tromey  <tromey@adacore.com>
11299
11300         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11301         (bp_location_ops): Remove.
11302         (base_breakpoint_allocate_location): Update.
11303         (free_bp_location): Update.
11304         * ada-lang.c (class ada_catchpoint_location)
11305         <ada_catchpoint_location>: Remove ops parameter.
11306         (ada_catchpoint_location_dtor): Remove.
11307         (ada_catchpoint_location_ops): Remove.
11308         (allocate_location_exception): Update.
11309         * breakpoint.h (struct bp_location_ops): Remove.
11310         (class bp_location) <bp_location>: Remove bp_location_ops
11311         parameter.
11312         <~bp_location>: Add destructor.
11313         <ops>: Remove.
11314
11315 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11316             Pedro Alves  <palves@redhat.com>
11317
11318         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11319         'PATH_MAX'.
11320
11321 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11322             Samuel Thibault  <samuel.thibault@gnu.org>
11323             Thomas Schwinge  <thomas@codesourcery.com>
11324
11325         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11326         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11327
11328 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11329
11330         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11331         (check_empty): Use "const char *".
11332
11333         * gnu-nat.c (gnu_nat_target::detach): Instead of
11334         'detach_inferior (pid)' call
11335         'detach_inferior (find_inferior_pid (pid))'.
11336
11337         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11338         'nat/fork-inferior.o'.
11339         * gnu-nat.c: #include "nat/fork-inferior.h".
11340
11341         * gnu-nat.c (gnu_nat_target::detach): Instead of
11342         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11343         * gnu-nat.h: #include "inf-child.h".
11344         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11345         'i386_gnu_nat_target::fetch_registers'.
11346         (gnu_store_registers): Rename/move to
11347         'i386_gnu_nat_target::store_registers'.
11348
11349         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11350         * gnu-nat.h (mach_thread_info): New function.
11351         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11352
11353         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11354
11355 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11356
11357         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11358
11359 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11360
11361         * windows-nat.c (windows_add_thread): Add new parameter
11362         "main_thread_p" with default value set to false.  Update
11363         function documentation as well as all callers.
11364         (windows_delete_thread): Likewise.
11365         (fake_create_process): Update call to windows_add_thread.
11366         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11367         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11368         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11369         call to windows_delete_thread.
11370
11371 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11372
11373         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11374
11375 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11376
11377         * symfile.c (find_separate_debug_file): Use canonical path of
11378         sysroot with child_path instead of gdb_sysroot if it is valid.
11379
11380 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11381
11382         * symfile.c (find_separate_debug_file): Use child_path to
11383         determine if an object file is under a sysroot.
11384
11385 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11386
11387         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11388         unittests/child-path-selftests.c.
11389         * common/pathstuff.c (child_path): New function.
11390         * common/pathstuff.h (child_path): New prototype.
11391         * unittests/child-path-selftests.c: New file.
11392
11393 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11394
11395         * symfile.c (find_separate_debug_file): Look for separate debug
11396         files in debug directories under the sysroot.
11397
11398 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11399
11400         * symtab.h (struct minimal_symbol data_p): New const method.
11401         (struct minimal_symbol text_p): Likewise.
11402         * symtab.c (output_source_filename): Use file name style
11403         to print file name.
11404         (print_symbol_info): Likewise.
11405         (print_msymbol_info): Use address style to print addresses.
11406         Use function name style to print executable text symbols.
11407         (expand_symtab_containing_pc): Use data_p.
11408         (find_pc_sect_compunit_symtab): Likewise.
11409
11410 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11411
11412         * breakpoint.c (describe_other_breakpoints): Use address style
11413         to print addresses.
11414         (say_where): Likewise.
11415
11416 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11417
11418         * ada-typeprint.c (print_func_type): Print function name
11419         style to print function name.
11420         * c-typeprint.c (c_print_type_1): Likewise.
11421
11422 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11423
11424         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11425         for execve.
11426
11427 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11428
11429         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11430         type_stack.
11431
11432 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11433
11434         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11435         TYPE_CODE_REF types.
11436
11437 2019-02-08  Jim Wilson  <jimw@sifive.com>
11438
11439         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11440         (riscv_linux_fregset): New.
11441         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11442
11443 2019-02-07  Tom Tromey  <tom@tromey.com>
11444
11445         * thread.c (thread_cancel_execution_command): Update.
11446         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11447         methods.
11448         (struct thread_fsm_ops): Remove.
11449         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11450         (thread_fsm_should_stop, thread_fsm_return_value)
11451         (thread_fsm_set_finished, thread_fsm_finished_p)
11452         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11453         Don't declare.
11454         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11455         * infrun.c (clear_proceed_status_thread)
11456         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11457         (print_stop_event): Update.
11458         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11459         Add constructor.
11460         (step_command_fsm_ops): Remove.
11461         (new_step_command_fsm): Remove.
11462         (step_1): Update.
11463         (step_command_fsm::should_stop): Rename from
11464         step_command_fsm_should_stop.
11465         (step_command_fsm::clean_up): Rename from
11466         step_command_fsm_clean_up.
11467         (step_command_fsm::do_async_reply_reason): Rename from
11468         step_command_fsm_async_reply_reason.
11469         (struct until_next_fsm): Inherit from thread_fsm.  Add
11470         constructor.
11471         (until_next_fsm_ops): Remove.
11472         (new_until_next_fsm): Remove.
11473         (until_next_fsm::should_stop): Rename from
11474         until_next_fsm_should_stop.
11475         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11476         (until_next_fsm::do_async_reply_reason): Rename from
11477         until_next_fsm_async_reply_reason.
11478         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11479         constructor.  Change type of breakpoint.
11480         (finish_command_fsm_ops): Remove.
11481         (new_finish_command_fsm): Remove.
11482         (finish_command_fsm::should_stop): Rename from
11483         finish_command_fsm_should_stop.
11484         (finish_command_fsm::clean_up): Rename from
11485         finish_command_fsm_clean_up.
11486         (finish_command_fsm::return_value): Rename from
11487         finish_command_fsm_return_value.
11488         (finish_command_fsm::do_async_reply_reason): Rename from
11489         finish_command_fsm_async_reply_reason.
11490         (finish_command): Update.
11491         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11492         Add constructor.
11493         (call_thread_fsm_ops): Remove.
11494         (call_thread_fsm::call_thread_fsm): Rename from
11495         new_call_thread_fsm.
11496         (call_thread_fsm::should_stop): Rename from
11497         call_thread_fsm_should_stop.
11498         (call_thread_fsm::should_notify_stop): Rename from
11499         call_thread_fsm_should_notify_stop.
11500         (run_inferior_call, call_function_by_hand_dummy): Update.
11501         * cli/cli-interp.c (should_print_stop_to_console): Update.
11502         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11503         Add constructor.  Change type of location_breakpoint,
11504         caller_breakpoint.
11505         (until_break_fsm_ops): Remove.
11506         (new_until_break_fsm): Remove.
11507         (until_break_fsm::should_stop): Rename from
11508         until_break_fsm_should_stop.
11509         (until_break_fsm::clean_up): Rename from
11510         until_break_fsm_clean_up.
11511         (until_break_fsm::do_async_reply_reason): Rename from
11512         until_break_fsm_async_reply_reason.
11513         (until_break_command): Update.
11514         * thread-fsm.c: Remove.
11515         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11516
11517 2019-02-07  Tom Tromey  <tom@tromey.com>
11518
11519         * yy-remap.h: Add include guard.
11520         * xtensa-tdep.h: Add include guard.
11521         * xcoffread.h: Rename include guard.
11522         * varobj-iter.h: Add include guard.
11523         * tui/tui.h: Rename include guard.
11524         * tui/tui-winsource.h: Rename include guard.
11525         * tui/tui-wingeneral.h: Rename include guard.
11526         * tui/tui-windata.h: Rename include guard.
11527         * tui/tui-win.h: Rename include guard.
11528         * tui/tui-stack.h: Rename include guard.
11529         * tui/tui-source.h: Rename include guard.
11530         * tui/tui-regs.h: Rename include guard.
11531         * tui/tui-out.h: Rename include guard.
11532         * tui/tui-layout.h: Rename include guard.
11533         * tui/tui-io.h: Rename include guard.
11534         * tui/tui-hooks.h: Rename include guard.
11535         * tui/tui-file.h: Rename include guard.
11536         * tui/tui-disasm.h: Rename include guard.
11537         * tui/tui-data.h: Rename include guard.
11538         * tui/tui-command.h: Rename include guard.
11539         * tic6x-tdep.h: Add include guard.
11540         * target/waitstatus.h: Rename include guard.
11541         * target/wait.h: Rename include guard.
11542         * target/target.h: Rename include guard.
11543         * target/resume.h: Rename include guard.
11544         * target-float.h: Rename include guard.
11545         * stabsread.h: Add include guard.
11546         * rs6000-tdep.h: Add include guard.
11547         * riscv-fbsd-tdep.h: Add include guard.
11548         * regformats/regdef.h: Rename include guard.
11549         * record.h: Rename include guard.
11550         * python/python.h: Rename include guard.
11551         * python/python-internal.h: Rename include guard.
11552         * python/py-stopevent.h: Rename include guard.
11553         * python/py-ref.h: Rename include guard.
11554         * python/py-record.h: Rename include guard.
11555         * python/py-record-full.h: Rename include guard.
11556         * python/py-record-btrace.h: Rename include guard.
11557         * python/py-instruction.h: Rename include guard.
11558         * python/py-events.h: Rename include guard.
11559         * python/py-event.h: Rename include guard.
11560         * procfs.h: Add include guard.
11561         * proc-utils.h: Add include guard.
11562         * p-lang.h: Add include guard.
11563         * or1k-tdep.h: Rename include guard.
11564         * observable.h: Rename include guard.
11565         * nto-tdep.h: Rename include guard.
11566         * nat/x86-linux.h: Rename include guard.
11567         * nat/x86-linux-dregs.h: Rename include guard.
11568         * nat/x86-gcc-cpuid.h: Add include guard.
11569         * nat/x86-dregs.h: Rename include guard.
11570         * nat/x86-cpuid.h: Rename include guard.
11571         * nat/ppc-linux.h: Rename include guard.
11572         * nat/mips-linux-watch.h: Rename include guard.
11573         * nat/linux-waitpid.h: Rename include guard.
11574         * nat/linux-ptrace.h: Rename include guard.
11575         * nat/linux-procfs.h: Rename include guard.
11576         * nat/linux-osdata.h: Rename include guard.
11577         * nat/linux-nat.h: Rename include guard.
11578         * nat/linux-namespaces.h: Rename include guard.
11579         * nat/linux-btrace.h: Rename include guard.
11580         * nat/glibc_thread_db.h: Rename include guard.
11581         * nat/gdb_thread_db.h: Rename include guard.
11582         * nat/gdb_ptrace.h: Rename include guard.
11583         * nat/fork-inferior.h: Rename include guard.
11584         * nat/amd64-linux-siginfo.h: Rename include guard.
11585         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11586         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11587         * nat/aarch64-linux.h: Rename include guard.
11588         * nat/aarch64-linux-hw-point.h: Rename include guard.
11589         * mn10300-tdep.h: Add include guard.
11590         * mips-linux-tdep.h: Add include guard.
11591         * mi/mi-parse.h: Rename include guard.
11592         * mi/mi-out.h: Rename include guard.
11593         * mi/mi-main.h: Rename include guard.
11594         * mi/mi-interp.h: Rename include guard.
11595         * mi/mi-getopt.h: Rename include guard.
11596         * mi/mi-console.h: Rename include guard.
11597         * mi/mi-common.h: Rename include guard.
11598         * mi/mi-cmds.h: Rename include guard.
11599         * mi/mi-cmd-break.h: Rename include guard.
11600         * m2-lang.h: Add include guard.
11601         * location.h: Rename include guard.
11602         * linux-record.h: Rename include guard.
11603         * linux-nat.h: Add include guard.
11604         * linux-fork.h: Add include guard.
11605         * i386-darwin-tdep.h: Rename include guard.
11606         * hppa-linux-offsets.h: Add include guard.
11607         * guile/guile.h: Rename include guard.
11608         * guile/guile-internal.h: Rename include guard.
11609         * gnu-nat.h: Rename include guard.
11610         * gdb-stabs.h: Rename include guard.
11611         * frv-tdep.h: Add include guard.
11612         * f-lang.h: Add include guard.
11613         * event-loop.h: Add include guard.
11614         * darwin-nat.h: Rename include guard.
11615         * cp-abi.h: Rename include guard.
11616         * config/sparc/nm-sol2.h: Rename include guard.
11617         * config/nm-nto.h: Rename include guard.
11618         * config/nm-linux.h: Add include guard.
11619         * config/i386/nm-i386gnu.h: Rename include guard.
11620         * config/djgpp/nl_types.h: Rename include guard.
11621         * config/djgpp/langinfo.h: Rename include guard.
11622         * compile/gcc-cp-plugin.h: Add include guard.
11623         * compile/gcc-c-plugin.h: Add include guard.
11624         * compile/compile.h: Rename include guard.
11625         * compile/compile-object-run.h: Rename include guard.
11626         * compile/compile-object-load.h: Rename include guard.
11627         * compile/compile-internal.h: Rename include guard.
11628         * compile/compile-cplus.h: Rename include guard.
11629         * compile/compile-c.h: Rename include guard.
11630         * common/xml-utils.h: Rename include guard.
11631         * common/x86-xstate.h: Rename include guard.
11632         * common/version.h: Rename include guard.
11633         * common/vec.h: Rename include guard.
11634         * common/tdesc.h: Rename include guard.
11635         * common/selftest.h: Rename include guard.
11636         * common/scoped_restore.h: Rename include guard.
11637         * common/scoped_mmap.h: Rename include guard.
11638         * common/scoped_fd.h: Rename include guard.
11639         * common/safe-iterator.h: Rename include guard.
11640         * common/run-time-clock.h: Rename include guard.
11641         * common/refcounted-object.h: Rename include guard.
11642         * common/queue.h: Rename include guard.
11643         * common/ptid.h: Rename include guard.
11644         * common/print-utils.h: Rename include guard.
11645         * common/preprocessor.h: Rename include guard.
11646         * common/pathstuff.h: Rename include guard.
11647         * common/observable.h: Rename include guard.
11648         * common/netstuff.h: Rename include guard.
11649         * common/job-control.h: Rename include guard.
11650         * common/host-defs.h: Rename include guard.
11651         * common/gdb_wait.h: Rename include guard.
11652         * common/gdb_vecs.h: Rename include guard.
11653         * common/gdb_unlinker.h: Rename include guard.
11654         * common/gdb_unique_ptr.h: Rename include guard.
11655         * common/gdb_tilde_expand.h: Rename include guard.
11656         * common/gdb_sys_time.h: Rename include guard.
11657         * common/gdb_string_view.h: Rename include guard.
11658         * common/gdb_splay_tree.h: Rename include guard.
11659         * common/gdb_setjmp.h: Rename include guard.
11660         * common/gdb_ref_ptr.h: Rename include guard.
11661         * common/gdb_optional.h: Rename include guard.
11662         * common/gdb_locale.h: Rename include guard.
11663         * common/gdb_assert.h: Rename include guard.
11664         * common/filtered-iterator.h: Rename include guard.
11665         * common/filestuff.h: Rename include guard.
11666         * common/fileio.h: Rename include guard.
11667         * common/environ.h: Rename include guard.
11668         * common/common-utils.h: Rename include guard.
11669         * common/common-types.h: Rename include guard.
11670         * common/common-regcache.h: Rename include guard.
11671         * common/common-inferior.h: Rename include guard.
11672         * common/common-gdbthread.h: Rename include guard.
11673         * common/common-exceptions.h: Rename include guard.
11674         * common/common-defs.h: Rename include guard.
11675         * common/common-debug.h: Rename include guard.
11676         * common/cleanups.h: Rename include guard.
11677         * common/buffer.h: Rename include guard.
11678         * common/btrace-common.h: Rename include guard.
11679         * common/break-common.h: Rename include guard.
11680         * cli/cli-utils.h: Rename include guard.
11681         * cli/cli-style.h: Rename include guard.
11682         * cli/cli-setshow.h: Rename include guard.
11683         * cli/cli-script.h: Rename include guard.
11684         * cli/cli-interp.h: Rename include guard.
11685         * cli/cli-decode.h: Rename include guard.
11686         * cli/cli-cmds.h: Rename include guard.
11687         * charset-list.h: Add include guard.
11688         * buildsym-legacy.h: Rename include guard.
11689         * bfin-tdep.h: Add include guard.
11690         * ax.h: Rename include guard.
11691         * arm-linux-tdep.h: Add include guard.
11692         * arm-fbsd-tdep.h: Add include guard.
11693         * arch/xtensa.h: Rename include guard.
11694         * arch/tic6x.h: Add include guard.
11695         * arch/i386.h: Add include guard.
11696         * arch/arm.h: Rename include guard.
11697         * arch/arm-linux.h: Rename include guard.
11698         * arch/arm-get-next-pcs.h: Rename include guard.
11699         * arch/amd64.h: Add include guard.
11700         * arch/aarch64-insn.h: Rename include guard.
11701         * arch-utils.h: Rename include guard.
11702         * annotate.h: Add include guard.
11703         * amd64-darwin-tdep.h: Rename include guard.
11704         * aarch64-linux-tdep.h: Add include guard.
11705         * aarch64-fbsd-tdep.h: Add include guard.
11706         * aarch32-linux-nat.h: Add include guard.
11707
11708 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11709
11710         * macrotab.c (macro_define_internal): New function that
11711         factorizes macro_define_object_internal and macro_define_function
11712         code.
11713         (macro_define_object_internal): Use macro_define_internal.
11714         (macro_define_function): Likewise.
11715
11716 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11717
11718         * macrocmd.c (extract_identifier): Return
11719         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11720         callers.
11721
11722 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11723
11724         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11725
11726 2019-02-05  Tom Tromey  <tom@tromey.com>
11727
11728         * target.c (target_stack::unpush): Move assertion earlier.
11729
11730 2019-01-30  Tom Tromey  <tom@tromey.com>
11731
11732         PR python/23615:
11733         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11734         (gdbpy_parse_and_eval): Likewise.
11735         * python/python-internal.h (gdbpy_allow_threads): New class.
11736
11737 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11738
11739         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11740         (aarch64_fbsd_fpregmap): Move earlier.
11741         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11742         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11743         instead of individual calls to trad_frame_set_reg_addr.
11744         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11745         earlier.
11746         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11747         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11748         instead of individual calls to trad_frame_set_reg_addr.
11749
11750 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11751
11752         * CONTRIBUTE: Replace contribution list with wiki link.
11753
11754 2019-01-25  Tom Tromey  <tom@tromey.com>
11755
11756         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11757
11758 2019-01-25  Tom Tromey  <tom@tromey.com>
11759
11760         * xtensa-linux-nat.c: Fix common/ includes.
11761         * xml-support.h: Fix common/ includes.
11762         * xml-support.c: Fix common/ includes.
11763         * x86-linux-nat.c: Fix common/ includes.
11764         * windows-nat.c: Fix common/ includes.
11765         * varobj.h: Fix common/ includes.
11766         * varobj.c: Fix common/ includes.
11767         * value.c: Fix common/ includes.
11768         * valops.c: Fix common/ includes.
11769         * utils.c: Fix common/ includes.
11770         * unittests/xml-utils-selftests.c: Fix common/ includes.
11771         * unittests/utils-selftests.c: Fix common/ includes.
11772         * unittests/unpack-selftests.c: Fix common/ includes.
11773         * unittests/tracepoint-selftests.c: Fix common/ includes.
11774         * unittests/style-selftests.c: Fix common/ includes.
11775         * unittests/string_view-selftests.c: Fix common/ includes.
11776         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11777         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11778         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11779         * unittests/rsp-low-selftests.c: Fix common/ includes.
11780         * unittests/parse-connection-spec-selftests.c: Fix common/
11781         includes.
11782         * unittests/optional-selftests.c: Fix common/ includes.
11783         * unittests/offset-type-selftests.c: Fix common/ includes.
11784         * unittests/observable-selftests.c: Fix common/ includes.
11785         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11786         * unittests/memrange-selftests.c: Fix common/ includes.
11787         * unittests/memory-map-selftests.c: Fix common/ includes.
11788         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11789         * unittests/function-view-selftests.c: Fix common/ includes.
11790         * unittests/environ-selftests.c: Fix common/ includes.
11791         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11792         * unittests/common-utils-selftests.c: Fix common/ includes.
11793         * unittests/cli-utils-selftests.c: Fix common/ includes.
11794         * unittests/array-view-selftests.c: Fix common/ includes.
11795         * ui-file.c: Fix common/ includes.
11796         * tui/tui-io.c: Fix common/ includes.
11797         * tracepoint.h: Fix common/ includes.
11798         * tracepoint.c: Fix common/ includes.
11799         * tracefile-tfile.c: Fix common/ includes.
11800         * top.h: Fix common/ includes.
11801         * top.c: Fix common/ includes.
11802         * thread.c: Fix common/ includes.
11803         * target/waitstatus.h: Fix common/ includes.
11804         * target/waitstatus.c: Fix common/ includes.
11805         * target.h: Fix common/ includes.
11806         * target.c: Fix common/ includes.
11807         * target-memory.c: Fix common/ includes.
11808         * target-descriptions.c: Fix common/ includes.
11809         * symtab.h: Fix common/ includes.
11810         * symfile.c: Fix common/ includes.
11811         * stap-probe.c: Fix common/ includes.
11812         * spu-linux-nat.c: Fix common/ includes.
11813         * sparc-nat.c: Fix common/ includes.
11814         * source.c: Fix common/ includes.
11815         * solib.c: Fix common/ includes.
11816         * solib-target.c: Fix common/ includes.
11817         * ser-unix.c: Fix common/ includes.
11818         * ser-tcp.c: Fix common/ includes.
11819         * ser-pipe.c: Fix common/ includes.
11820         * ser-base.c: Fix common/ includes.
11821         * selftest-arch.c: Fix common/ includes.
11822         * s12z-tdep.c: Fix common/ includes.
11823         * rust-exp.y: Fix common/ includes.
11824         * rs6000-aix-tdep.c: Fix common/ includes.
11825         * riscv-tdep.c: Fix common/ includes.
11826         * remote.c: Fix common/ includes.
11827         * remote-notif.h: Fix common/ includes.
11828         * remote-fileio.h: Fix common/ includes.
11829         * remote-fileio.c: Fix common/ includes.
11830         * regcache.h: Fix common/ includes.
11831         * regcache.c: Fix common/ includes.
11832         * record-btrace.c: Fix common/ includes.
11833         * python/python.c: Fix common/ includes.
11834         * python/py-type.c: Fix common/ includes.
11835         * python/py-inferior.c: Fix common/ includes.
11836         * progspace.h: Fix common/ includes.
11837         * producer.c: Fix common/ includes.
11838         * procfs.c: Fix common/ includes.
11839         * proc-api.c: Fix common/ includes.
11840         * printcmd.c: Fix common/ includes.
11841         * ppc-linux-nat.c: Fix common/ includes.
11842         * parser-defs.h: Fix common/ includes.
11843         * osdata.c: Fix common/ includes.
11844         * obsd-nat.c: Fix common/ includes.
11845         * nat/x86-linux.c: Fix common/ includes.
11846         * nat/x86-linux-dregs.c: Fix common/ includes.
11847         * nat/x86-dregs.h: Fix common/ includes.
11848         * nat/x86-dregs.c: Fix common/ includes.
11849         * nat/ppc-linux.c: Fix common/ includes.
11850         * nat/mips-linux-watch.h: Fix common/ includes.
11851         * nat/mips-linux-watch.c: Fix common/ includes.
11852         * nat/linux-waitpid.c: Fix common/ includes.
11853         * nat/linux-ptrace.h: Fix common/ includes.
11854         * nat/linux-ptrace.c: Fix common/ includes.
11855         * nat/linux-procfs.c: Fix common/ includes.
11856         * nat/linux-personality.c: Fix common/ includes.
11857         * nat/linux-osdata.c: Fix common/ includes.
11858         * nat/linux-namespaces.c: Fix common/ includes.
11859         * nat/linux-btrace.h: Fix common/ includes.
11860         * nat/linux-btrace.c: Fix common/ includes.
11861         * nat/fork-inferior.c: Fix common/ includes.
11862         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11863         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11864         * nat/aarch64-linux.c: Fix common/ includes.
11865         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11866         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11867         * namespace.h: Fix common/ includes.
11868         * mips-linux-tdep.c: Fix common/ includes.
11869         * minsyms.c: Fix common/ includes.
11870         * mi/mi-parse.h: Fix common/ includes.
11871         * mi/mi-main.c: Fix common/ includes.
11872         * mi/mi-cmd-env.c: Fix common/ includes.
11873         * memrange.h: Fix common/ includes.
11874         * memattr.c: Fix common/ includes.
11875         * maint.h: Fix common/ includes.
11876         * maint.c: Fix common/ includes.
11877         * main.c: Fix common/ includes.
11878         * machoread.c: Fix common/ includes.
11879         * location.c: Fix common/ includes.
11880         * linux-thread-db.c: Fix common/ includes.
11881         * linux-nat.c: Fix common/ includes.
11882         * linux-fork.c: Fix common/ includes.
11883         * inline-frame.c: Fix common/ includes.
11884         * infrun.c: Fix common/ includes.
11885         * inflow.c: Fix common/ includes.
11886         * inferior.h: Fix common/ includes.
11887         * inferior.c: Fix common/ includes.
11888         * infcmd.c: Fix common/ includes.
11889         * inf-ptrace.c: Fix common/ includes.
11890         * inf-child.c: Fix common/ includes.
11891         * ia64-linux-nat.c: Fix common/ includes.
11892         * i387-tdep.c: Fix common/ includes.
11893         * i386-tdep.c: Fix common/ includes.
11894         * i386-linux-tdep.c: Fix common/ includes.
11895         * i386-linux-nat.c: Fix common/ includes.
11896         * i386-go32-tdep.c: Fix common/ includes.
11897         * i386-fbsd-tdep.c: Fix common/ includes.
11898         * i386-fbsd-nat.c: Fix common/ includes.
11899         * guile/scm-type.c: Fix common/ includes.
11900         * guile/guile.c: Fix common/ includes.
11901         * go32-nat.c: Fix common/ includes.
11902         * gnu-nat.c: Fix common/ includes.
11903         * gdbthread.h: Fix common/ includes.
11904         * gdbarch-selftests.c: Fix common/ includes.
11905         * gdb_usleep.c: Fix common/ includes.
11906         * gdb_select.h: Fix common/ includes.
11907         * gdb_bfd.c: Fix common/ includes.
11908         * gcore.c: Fix common/ includes.
11909         * fork-child.c: Fix common/ includes.
11910         * findvar.c: Fix common/ includes.
11911         * fbsd-nat.c: Fix common/ includes.
11912         * event-top.c: Fix common/ includes.
11913         * event-loop.c: Fix common/ includes.
11914         * dwarf2read.c: Fix common/ includes.
11915         * dwarf2loc.c: Fix common/ includes.
11916         * dwarf2-frame.c: Fix common/ includes.
11917         * dwarf-index-cache.c: Fix common/ includes.
11918         * dtrace-probe.c: Fix common/ includes.
11919         * disasm-selftests.c: Fix common/ includes.
11920         * defs.h: Fix common/ includes.
11921         * csky-tdep.c: Fix common/ includes.
11922         * cp-valprint.c: Fix common/ includes.
11923         * cp-support.h: Fix common/ includes.
11924         * cp-support.c: Fix common/ includes.
11925         * corelow.c: Fix common/ includes.
11926         * completer.h: Fix common/ includes.
11927         * completer.c: Fix common/ includes.
11928         * compile/compile.c: Fix common/ includes.
11929         * compile/compile-loc2c.c: Fix common/ includes.
11930         * compile/compile-cplus-types.c: Fix common/ includes.
11931         * compile/compile-cplus-symbols.c: Fix common/ includes.
11932         * command.h: Fix common/ includes.
11933         * cli/cli-dump.c: Fix common/ includes.
11934         * cli/cli-cmds.c: Fix common/ includes.
11935         * charset.c: Fix common/ includes.
11936         * build-id.c: Fix common/ includes.
11937         * btrace.h: Fix common/ includes.
11938         * btrace.c: Fix common/ includes.
11939         * breakpoint.h: Fix common/ includes.
11940         * breakpoint.c: Fix common/ includes.
11941         * ax.h:
11942         (enum agent_op): Fix common/ includes.
11943         * ax-general.c (struct aop_map): Fix common/ includes.
11944         * ax-gdb.c: Fix common/ includes.
11945         * auxv.c: Fix common/ includes.
11946         * auto-load.c: Fix common/ includes.
11947         * arm-tdep.c: Fix common/ includes.
11948         * arch/riscv.c: Fix common/ includes.
11949         * arch/ppc-linux-common.c: Fix common/ includes.
11950         * arch/i386.c: Fix common/ includes.
11951         * arch/arm.c: Fix common/ includes.
11952         * arch/arm-linux.c: Fix common/ includes.
11953         * arch/arm-get-next-pcs.c: Fix common/ includes.
11954         * arch/amd64.c: Fix common/ includes.
11955         * arch/aarch64.c: Fix common/ includes.
11956         * arch/aarch64-insn.c: Fix common/ includes.
11957         * arch-utils.c: Fix common/ includes.
11958         * amd64-windows-tdep.c: Fix common/ includes.
11959         * amd64-tdep.c: Fix common/ includes.
11960         * amd64-sol2-tdep.c: Fix common/ includes.
11961         * amd64-obsd-tdep.c: Fix common/ includes.
11962         * amd64-nbsd-tdep.c: Fix common/ includes.
11963         * amd64-linux-tdep.c: Fix common/ includes.
11964         * amd64-linux-nat.c: Fix common/ includes.
11965         * amd64-fbsd-tdep.c: Fix common/ includes.
11966         * amd64-fbsd-nat.c: Fix common/ includes.
11967         * amd64-dicos-tdep.c: Fix common/ includes.
11968         * amd64-darwin-tdep.c: Fix common/ includes.
11969         * agent.c: Fix common/ includes.
11970         * ada-lang.h: Fix common/ includes.
11971         * ada-lang.c: Fix common/ includes.
11972         * aarch64-tdep.c: Fix common/ includes.
11973
11974 2019-01-25  Tom Tromey  <tom@tromey.com>
11975
11976         * common/create-version.sh: Use common/version.h.
11977
11978 2019-01-24  Pedro Alves  <palves@redhat.com>
11979
11980         * infrun.c (signal_stop, signal_print, signal_program)
11981         (signal_catch, signal_pass): Now arrays instead of pointers.
11982         (update_signals_program_target, do_target_resume)
11983         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11984         * linux-nat.c (linux_nat_target::pass_signals)
11985         (linux_nat_target::create_inferior, linux_nat_target::attach):
11986         Adjust.
11987         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11988         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11989         * procfs.c (procfs_target::pass_signals): Adjust.
11990         * record-full.c (record_full_target::resume): Adjust.
11991         * remote.c (remote_target::pass_signals)
11992         (remote_target::program_signals): Adjust.
11993         * target-debug.h (target_debug_print_signals): Now takes a
11994         gdb::array_view as parameter.  Adjust.
11995         * target.h (target_ops) <pass_signals, program_signals>: Replace
11996         pointer and length parameters with gdb::array_view.
11997         (target_pass_signals, target_program_signals): Likewise.
11998         * target-delegates.c: Regenerate.
11999
12000 2019-01-24  Pedro Alves  <palves@redhat.com>
12001
12002         * common/forward-scope-exit.h
12003         (forward_scope_exit::forward_scope_exit): Pass arguments to
12004         m_bind_function directly, instead of creating a std::bind and
12005         copying that.
12006
12007 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12008
12009         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12010         for static members.
12011         (pass_in_v_vfp_candidate): Likewise.
12012
12013 2019-01-23  Tom Tromey  <tom@tromey.com>
12014             Pedro Alves  <palves@redhat.com>
12015
12016         * regcache.c (class regcache_invalidator): Remove.
12017         (regcache::raw_write): Use make_scope_exit.
12018
12019 2019-01-23  Tom Tromey  <tom@tromey.com>
12020
12021         * ui-out.h (class ui_out_emit_type): Update comment.
12022
12023 2019-01-23  Tom Tromey  <tom@tromey.com>
12024
12025         * infrun.c (fetch_inferior_event): Update comment.
12026
12027 2019-01-23  Tom Tromey  <tom@tromey.com>
12028             Pedro Alves  <palves@redhat.com>
12029
12030         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12031         parameter.
12032         (fetch_inferior_event): Use SCOPE_EXIT.
12033
12034
12035 2019-01-23  Tom Tromey  <tom@tromey.com>
12036             Pedro Alves  <palves@redhat.com>
12037
12038         * infrun.c (disable_thread_events): Delete.
12039         (stop_all_threads): Use SCOPE_EXIT.
12040
12041 2019-01-23  Tom Tromey  <tom@tromey.com>
12042             Pedro Alves  <palves@redhat.com>
12043
12044         * symfile.c: Include forward-scope-exit.h.
12045         (clear_symtab_users_cleanup): Replace forward declaration with
12046         a FORWARD_SCOPE_EXIT.
12047         (syms_from_objfile_1): Use the forward_scope_exit and
12048         gdb::optional instead of cleanup_function.
12049         (reread_symbols): Use the forward_scope_exit instead of
12050         cleanup_function.
12051         (clear_symtab_users_cleanup): Remove function.
12052
12053 2019-01-23  Tom Tromey  <tom@tromey.com>
12054             Pedro Alves  <palves@redhat.com>
12055
12056         * linux-nat.c: Include scope-exit.h.
12057         (cleanup_target_stop): Remove.
12058         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12059         SCOPE_EXIT.
12060
12061 2019-01-23  Tom Tromey  <tom@tromey.com>
12062             Pedro Alves  <palves@redhat.com>
12063
12064         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12065         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12066
12067 2019-01-23  Tom Tromey  <tom@tromey.com>
12068             Andrew Burgess  <andrew.burgess@embecosm.com>
12069             Pedro Alves  <palves@redhat.com>
12070
12071         * infrun.c (fetch_inferior_event): Use scope_exit.
12072         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12073         * top.c (execute_command): Use scope_exit.
12074         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12075         * utils.c (do_bpstat_clear_actions_cleanup)
12076         (make_bpstat_clear_actions_cleanup): Remove.
12077
12078 2019-01-23  Tom Tromey  <tom@tromey.com>
12079             Pedro Alves  <palves@redhat.com>
12080
12081         * infrun.c: Include "common/scope-exit.h"
12082         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12083         (wait_for_inferior): Use SCOPE_EXIT.
12084         (fetch_inferior_event): Use scope_exit.
12085
12086 2019-01-23  Tom Tromey  <tom@tromey.com>
12087             Pedro Alves  <palves@redhat.com>
12088
12089         * breakpoint.c (create_breakpoint): Remove cleanup.
12090
12091 2019-01-23  Tom Tromey  <tom@tromey.com>
12092             Andrew Burgess  <andrew.burgess@embecosm.com>
12093             Pedro Alves  <palves@redhat.com>
12094
12095 2019-01-23  Pedro Alves  <palves@redhat.com>
12096
12097         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12098
12099 2019-01-23  Pedro Alves  <palves@redhat.com>
12100             Andrew Burgess  <andrew.burgess@embecosm.com>
12101
12102         * gdbthread.h: Include "common/forward-scope-exit.h".
12103         (scoped_finish_thread_state): Redefine custom class in terms of
12104         forward_scope_exit.
12105
12106 2019-01-23  Pedro Alves  <palves@redhat.com>
12107             Andrew Burgess  <andrew.burgess@embecosm.com>
12108
12109         * common/forward-scope-exit.h: New file.
12110
12111 2019-01-23  Pedro Alves  <palves@redhat.com>
12112             Andrew Burgess  <andrew.burgess@embecosm.com>
12113             Tom Tromey  <tom@tromey.com>
12114
12115         * common/scope-exit.h: New file.
12116
12117 2019-01-23  Pedro Alves  <palves@redhat.com>
12118
12119         * common/preprocessor.h (ESC): Rename to ...
12120         (ESC_PARENS): ... this.
12121         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12122         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12123
12124 2019-01-23  Tom Tromey  <tom@tromey.com>
12125
12126         * language.h (class scoped_switch_to_sym_language_if_auto):
12127         Initialize m_lang in both cases.
12128
12129 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12130
12131         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12132         with XCNEW.
12133
12134 2019-01-22  Tom Tromey  <tom@tromey.com>
12135
12136         * corelow.c: Do not include sys/file.h.
12137
12138 2019-01-22  Tom Tromey  <tom@tromey.com>
12139
12140         * tui/tui-wingeneral.h: Include gdb_curses.h.
12141
12142 2019-01-22  Tom Tromey  <tom@tromey.com>
12143
12144         * source-cache.h (class source_cache) <get_source_lines,
12145         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12146
12147 2019-01-22  Tom Tromey  <tom@tromey.com>
12148
12149         * remote-fileio.h (struct remote_target): Declare.
12150
12151 2019-01-22  Tom Tromey  <tom@tromey.com>
12152
12153         * python/py-arch.c: Do not include py-ref.h.
12154         * python/py-bpevent.c: Do not include py-ref.h.
12155         * python/py-cmd.c: Do not include py-ref.h.
12156         * python/py-continueevent.c: Do not include py-ref.h.
12157         * python/py-event.h: Do not include py-ref.h.
12158         * python/py-evtregistry.c: Do not include py-ref.h.
12159         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12160         * python/py-frame.c: Do not include py-ref.h.
12161         * python/py-framefilter.c: Do not include py-ref.h.
12162         * python/py-function.c: Do not include py-ref.h.
12163         * python/py-infevents.c: Do not include py-ref.h.
12164         * python/py-linetable.c: Do not include py-ref.h.
12165         * python/py-objfile.c: Do not include py-ref.h.
12166         * python/py-param.c: Do not include py-ref.h.
12167         * python/py-prettyprint.c: Do not include py-ref.h.
12168         * python/py-progspace.c: Do not include py-ref.h.
12169         * python/py-symbol.c: Do not include py-ref.h.
12170         * python/py-symtab.c: Do not include py-ref.h.
12171         * python/py-type.c: Do not include py-ref.h.
12172         * python/py-unwind.c: Do not include py-ref.h.
12173         * python/py-utils.c: Do not include py-ref.h.
12174         * python/py-value.c: Do not include py-ref.h.
12175         * python/py-varobj.c: Do not include py-ref.h.
12176         * python/py-xmethods.c: Do not include py-ref.h.
12177         * python/python.c: Do not include py-ref.h.
12178         * varobj.c: Do not include py-ref.h.
12179
12180 2019-01-22  Tom Tromey  <tom@tromey.com>
12181
12182         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12183         keyword for bcache.
12184
12185 2019-01-22  Tom Tromey  <tom@tromey.com>
12186
12187         * compile/compile-cplus-types.c: Remove a comment by #include.
12188
12189 2019-01-22  Tom Tromey  <tom@tromey.com>
12190
12191         * compile/gcc-c-plugin.h: Include compile-internal.h.
12192
12193 2019-01-22  Tom Tromey  <tom@tromey.com>
12194
12195         * stabsread.c (EXTERN): Do not define.
12196         (symnum, next_symbol_text_func, processing_gcc_compilation)
12197         (within_function, global_sym_chain, global_stabs)
12198         (previous_stab_code, this_object_header_files)
12199         (n_this_object_header_files)
12200         (n_allocated_this_object_header_files): Define.
12201         * stabsread.h (EXTERN): Never define.  Use "extern".
12202
12203 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12204
12205         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12206         history_value.
12207
12208 2019-01-21  Tom Tromey  <tom@tromey.com>
12209
12210         * ui-out.c: Fix includes.
12211         * tui/tui-source.c: Fix includes.
12212         * target.c: Fix includes.
12213         * remote.c: Fix includes.
12214         * regcache.c: Fix includes.
12215         * python/py-block.c: Fix includes.
12216         * printcmd.c: Fix includes.
12217         * or1k-tdep.c: Fix includes.
12218         * mi/mi-main.c: Fix includes.
12219         * m32r-tdep.c: Fix includes.
12220         * csky-tdep.c: Fix includes.
12221         * compile/compile-cplus-types.c: Fix includes.
12222         * cli/cli-interp.c: Fix includes.
12223
12224 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12225
12226         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12227         for padding.
12228
12229 2019-01-16  Tom Tromey  <tom@tromey.com>
12230
12231         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12232         earlier.
12233         (struct objfile) <msymbols_range>: Move from top level.
12234         <msymbols>: New method.
12235         (class objfile_msymbols): Remove.
12236         * symtab.c (default_collect_symbol_completion_matches_break_on):
12237         Update.
12238         * symmisc.c (dump_msymbols): Update.
12239         * stabsread.c (scan_file_globals): Update.
12240         * objc-lang.c (info_selectors_command, info_classes_command)
12241         (find_methods): Update.
12242         * minsyms.c (find_solib_trampoline_target): Update.
12243         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12244         * coffread.c (coff_symfile_read): Update.
12245         * ada-lang.c (ada_lookup_simple_minsym)
12246         (ada_collect_symbol_completion_matches): Update.
12247
12248 2019-01-16  Tom Tromey  <tom@tromey.com>
12249
12250         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12251         type.  Remove no-argument constructor.
12252         <iterator::operator++>: Simplify.
12253         <begin>: Update.
12254         <end>: Use minimal_symbol_count.
12255
12256 2019-01-16  Tom Tromey  <tom@tromey.com>
12257
12258         * objfiles.h (struct objfile) <psymtabs>: New method.
12259         (class objfile_psymtabs): Remove.
12260         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12261         typedef.
12262         <range>: New method.
12263         (require_partial_symbols): Change return type.
12264         * psymtab.c (require_partial_symbols)
12265         (psym_expand_symtabs_matching): Update.
12266         * mdebugread.c (parse_partial_symbols): Update.
12267         * dbxread.c (dbx_end_psymtab): Update.
12268
12269 2019-01-15  Tom Tromey  <tom@tromey.com>
12270
12271         * symtab.c (lookup_objfile_from_block)
12272         (lookup_symbol_in_objfile_symtabs)
12273         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12274         (find_line_symtab, info_sources_command)
12275         (default_collect_symbol_completion_matches_break_on)
12276         (make_source_files_completion_list): Update.
12277         * symmisc.c (print_objfile_statistics, dump_objfile)
12278         (maintenance_print_symbols, maintenance_info_symtabs)
12279         (maintenance_check_symtabs, maintenance_info_line_tables):
12280         Update.
12281         * source.c (select_source_symtab)
12282         (forget_cached_source_info_for_objfile): Update.
12283         * objfiles.h (class objfile_compunits): Remove.
12284         (struct objfile) <compunits_range>: New typedef.
12285         (compunits): New method.
12286         * objfiles.c (objfile_relocate1): Update.
12287         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12288         * maint.c (count_symtabs_and_blocks): Update.
12289         * linespec.c (iterate_over_all_matching_symtabs): Update.
12290         * cp-support.c (add_symbol_overload_list_qualified): Update.
12291         * coffread.c (coff_symtab_read): Update.
12292         * ada-lang.c (add_nonlocal_symbols)
12293         (ada_collect_symbol_completion_matches)
12294         (ada_add_global_exceptions): Update.
12295
12296 2019-01-15  Tom Tromey  <tom@tromey.com>
12297
12298         * progspace.h (program_space) <objfiles_safe_range>: New
12299         typedef.
12300         <objfiles_safe>: New method.
12301         * objfiles.h (class all_objfiles_safe): Remove.
12302         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12303         * jit.c (jit_inferior_exit_hook): Update.
12304
12305 2019-01-17  Tom Tromey  <tom@tromey.com>
12306
12307         * progspace.h (program_space) <objfiles_range>: New typedef.
12308         <objfiles>: New method.
12309         <objfiles_head>: Rename from objfiles.
12310         (object_files): Update.
12311         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12312         * guile/scm-pretty-print.c
12313         (ppscm_find_pretty_printer_from_objfiles): Update.
12314         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12315         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12316         Update.
12317         * python/py-progspace.c (pspy_get_objfiles): Update.
12318         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12319         Update.
12320         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12321         (objfpy_lookup_objfile_by_build_id): Update.
12322         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12323         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12324         Update.
12325         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12326         (expand_symtab_containing_pc, lookup_objfile_from_block)
12327         (lookup_static_symbol, basic_lookup_transparent_type)
12328         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12329         (find_line_symtab, info_sources_command)
12330         (default_collect_symbol_completion_matches_break_on)
12331         (make_source_files_completion_list, find_main_name): Update.
12332         * symmisc.c (print_symbol_bcache_statistics)
12333         (print_objfile_statistics, maintenance_print_symbols)
12334         (maintenance_print_msymbols, maintenance_print_objfiles)
12335         (maintenance_info_symtabs, maintenance_check_symtabs)
12336         (maintenance_expand_symtabs, maintenance_info_line_tables):
12337         Update.
12338         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12339         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12340         (map_overlay_command, unmap_overlay_command)
12341         (simple_overlay_update, expand_symtabs_matching)
12342         (map_symbol_filenames): Update.
12343         * symfile-debug.c (set_debug_symfile): Update.
12344         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12345         Update.
12346         * source.c (select_source_symtab, forget_cached_source_info):
12347         Update.
12348         * solib.c (solib_read_symbols): Update.
12349         * solib-spu.c (append_ocl_sos): Update.
12350         * psymtab.c (maintenance_print_psymbols)
12351         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12352         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12353         * printcmd.c (info_symbol_command): Update.
12354         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12355         Update.
12356         * objfiles.h (class all_objfiles): Remove.
12357         * objfiles.c (have_partial_symbols, have_full_symbols)
12358         (have_minimal_symbols, qsort_cmp, update_section_map)
12359         (shared_objfile_contains_address_p)
12360         (default_iterate_over_objfiles_in_search_order): Update.
12361         * objc-lang.c (info_selectors_command, info_classes_command)
12362         (find_methods): Update.
12363         * minsyms.c (find_solib_trampoline_target): Update.
12364         * maint.c (maintenance_info_sections)
12365         (maintenance_translate_address, count_symtabs_and_blocks):
12366         Update.
12367         * main.c (captured_main_1): Update.
12368         * linux-thread-db.c (try_thread_db_load_from_pdir)
12369         (has_libpthread): Update.
12370         * linespec.c (iterate_over_all_matching_symtabs)
12371         (search_minsyms_for_name): Update.
12372         * jit.c (jit_find_objf_with_entry_addr): Update.
12373         * hppa-tdep.c (find_unwind_entry)
12374         (hppa_lookup_stub_minimal_symbol): Update.
12375         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12376         Update.
12377         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12378         (elf_gnu_ifunc_resolve_by_got): Update.
12379         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12380         * dwarf-index-write.c (save_gdb_index_command): Update.
12381         * cp-support.c (add_symbol_overload_list_qualified): Update.
12382         * breakpoint.c (create_overlay_event_breakpoint)
12383         (create_longjmp_master_breakpoint)
12384         (create_std_terminate_master_breakpoint)
12385         (create_exception_master_breakpoint): Update.
12386         * blockframe.c (find_pc_partial_function): Update.
12387         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12388         (ada_collect_symbol_completion_matches)
12389         (ada_add_global_exceptions): Update.
12390
12391 2019-01-17  Tom Tromey  <tom@tromey.com>
12392
12393         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12394         declare VEC.
12395         (solib_target_parse_libraries): Change return type.
12396         (library_list_start_segment, library_list_start_section)
12397         (library_list_end_library, library_list_start_library); Update.
12398         (solib_target_free_library_list): Remove.
12399         (solib_target_parse_libraries): Remove cleanup.  Change return
12400         type.
12401         (solib_target_current_sos): Update.
12402
12403 2019-01-17  Tom Tromey  <tromey@bapiya>
12404
12405         * valprint.c: Replace "the the" with "the".
12406         * symtab.c: Replace "the the" with "the".
12407         * solib.c: Replace "the the" with "the".
12408         * solib-dsbt.c: Replace "the the" with "the".
12409         * linespec.c: Replace "the the" with "the".
12410         * dwarf2loc.h: Replace "the the" with "the".
12411         * amd64-windows-tdep.c: Replace "the the" with "the".
12412         * aarch64-tdep.c: Replace "the the" with "the".
12413
12414 2019-01-16  Keith Seitz  <keiths@redhat.com>
12415
12416         PR gdb/23773
12417         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12418         <builder>: Rename to ..
12419         <m_builder>: ... this and make private.
12420         (dwarf2_cu::get_builder): New method.  Change all users of
12421         `builder' to use this method.
12422         (dwarf2_start_symtab): Move to ...
12423         (dwarf2_cu::start_symtab): ... here.  Update all callers
12424         (setup_type_unit_groups): Move to ...
12425         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12426         callers.
12427         (dwarf2_cu::reset_builder): New method.
12428         (process_full_compunit, process_full_type_unit): Use
12429         dwarf2_cu::reset_builder.
12430         (follow_die_offset): Record the ancestor CU if it is different
12431         from the followed DIE's CU.
12432         (follow_die_sig_1): Likewise.
12433
12434 2019-01-15  Tom Tromey  <tom@tromey.com>
12435
12436         * remote.c (class remote_state) <buf>: Now a char_vector.
12437         <buf_size>: Remove.
12438         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12439         parameter.
12440         (remote_target::getpkt_or_notif_sane_1)
12441         (remote_target::getpkt_sane)
12442         (remote_target::getpkt_or_notif_sane): Likewise.
12443         (class remote_target) <putpkt>: New overload.
12444         (remote_target::read_frame): Change type of "buf_p".  Remove
12445         sizeof_p parameter.
12446         (packet_ok): New overload.
12447         (packet_check_result): New overload.
12448         Update all uses.
12449
12450 2019-01-14  Tom Tromey  <tom@tromey.com>
12451
12452         * remote-notif.c (handle_notification, remote_notif_ack)
12453         (remote_notif_parse): Make "buf" const.
12454         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12455         const.
12456         (remote_notif_parse, remote_notif_ack, handle_notification):
12457         Likewise.
12458         * remote.c (remote_notif_stop_parse): Make "buf" const.
12459         (remote_target::remote_parse_stop_reply): Make "buf" const.
12460         (remote_notif_stop_ack): Make "buf" const.
12461
12462 2019-01-14  Tom Tromey  <tom@tromey.com>
12463
12464         * remote.c (remote_console_output): Make parameter const.
12465
12466 2019-01-14  Tom Tromey  <tom@tromey.com>
12467
12468         * target-debug.h (target_debug_print_signals): Constify.
12469         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12470         * procfs.c (procfs_target::pass_signals): Update.
12471         * linux-nat.c (linux_nat_target::pass_signals): Update.
12472         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12473         * target-delegates.c: Rebuild.
12474         * remote.c (remote_target::program_signals): Update.
12475         (remote_target::pass_signals): Update.
12476         * target.c (target_pass_signals): Constify argument.
12477         (target_program_signals): Likewise.
12478         * target.h (struct target_ops) <pass_signals, program_signals>:
12479         Constify argument.
12480         (target_pass_signals, target_program_signals): Constify argument.
12481
12482 2019-01-14  Tom Tromey  <tom@tromey.com>
12483
12484         PR tui/28819:
12485         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12486
12487 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12488
12489         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12490         field.
12491         * rs6000-tdep.c: Include reggroups.h.
12492         (IS_V_ALIAS_PSEUDOREG): Define.
12493         (rs6000_register_name): Return names for the "vX" aliases.
12494         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12495         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12496         aliases.  Call default_register_reggroup_p for all other
12497         pseudo-registers.
12498         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12499         New functions.
12500         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12501         Handle "vX" aliases.
12502         (v_alias_pseudo_register_collect): New function.
12503         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12504         (rs6000_gdbarch_init): Initialize "vX" aliases as
12505         pseudo-registers.  Restore registration of
12506         rs6000_pseudo_register_reggroup_p with
12507         set_tdesc_pseudo_register_reggroup_p.
12508
12509 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12510
12511         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12512         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12513         set_gdbarch_num_pseudo_regs.
12514
12515 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12516
12517         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12518         Remove arg prefixname, add do_set and do_show.
12519         Add member functions set_list and show_list.
12520         * cli/cli-style.c (class cli_style_option): Update accordingly.
12521         (style_set_list): Move to file scope.
12522         (style_show_list): Likewise.
12523         (set_style): Call help_list.
12524         (show_style): Call cmd_show_list.
12525         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12526         Update to use the new macro.
12527
12528 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12529
12530         * ada-lang.c (_initialize_ada_language): Expand the help text
12531         for the "catch exception" command.
12532
12533 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12534
12535         * symtab.c (matching_obj_sections): Initialize obj,
12536         declare it closer to its usage.
12537
12538 2019-01-10  Tom Tromey  <tom@tromey.com>
12539
12540         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12541         (basic_inf_threads_range): Remove.
12542         (inf_threads_range, inf_non_exited_threads_range)
12543         (safe_inf_threads_range): Use next_adapter.
12544
12545 2019-01-10  Keith Seitz  <keiths@redhat.com>
12546
12547         PR gdb/23712
12548         PR symtab/23010
12549         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12550         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12551
12552 2019-01-10  Keith Seitz  <keiths@redhat.com>
12553
12554         PR gdb/23712
12555         PR symtab/23010
12556         * dictionary.c (pending_to_vector): Remove.
12557         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12558         Remove _1 suffix, replacing functions of the same name.  Update
12559         all callers.
12560         (dict_create_hashed, dict_create_hashed_expandable)
12561         (dict_create_linear, dict_create_linear_expandable, dict_free)
12562         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12563         Make functions static.
12564
12565 2019-01-10  Keith Seitz  <keiths@redhat.com>
12566
12567         PR gdb/23712
12568         PR symtab/23010
12569         * dictionary.h (struct dictionary): Replace declaration with
12570         multidictionary.
12571         (dict_create_hashed, dict_create_hashed_expandable)
12572         (dict_create_linear, dict_create_linear_expandable)
12573         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12574         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12575         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12576         taking multidictionary argument.
12577         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12578         * block.h (struct block) <dict>: Change to multidictionary
12579         and rename `multidict'.
12580         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12581         symmisc.c: Update all dictionary references to multidictionary.
12582
12583 2019-01-10  Keith Seitz  <keiths@redhat.com>
12584
12585         PR gdb/23712
12586         PR symtab/23010
12587         * dictionary.c: Include unordered_map.
12588         (pending_to_vector): New function.
12589         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12590         Rewrite the non-"_1" functions to take vector instead
12591         of linked list.
12592         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12593         "new" _1 versions of the same name.
12594         (multidictionary): Define.
12595         (std::hash<enum language): New definition.
12596         (collate_pending_symbols_by_language, mdict_create_hashed)
12597         (mdict_create_hashed_expandable, mdict_create_linear)
12598         (mdict_create_linear_expandable, mdict_free)
12599         (find_language_dictionary, create_new_language_dictionary)
12600         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12601         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12602         (mdict_size, mdict_empty): New functions.
12603         * dictionary.h (mdict_iterator): Define.
12604
12605 2019-01-10  Pedro Alves  <palves@redhat.com>
12606
12607         * breakpoint.c (read_uploaded_action)
12608         (create_tracepoint_from_upload): Adjust to use
12609         gdb::unique_xmalloc_ptr.
12610         * ctf.c (ctf_write_uploaded_tp):
12611         (SET_ARRAY_FIELD): Use emplace_back.
12612         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12613         * tracefile-tfile.c (tfile_write_uploaded_tp):
12614         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12615         gdb::unique_xmalloc_ptr.
12616         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12617         at_string, cond_string, cmd_strings>: Replace char pointers
12618         with gdb::unique_xmalloc_ptr.
12619
12620 2019-01-10  Pedro Alves  <palves@redhat.com>
12621
12622         * solib-target.c (library_list_start_library): Don't xstrdup name.
12623
12624 2019-01-10  Pedro Alves  <palves@redhat.com>
12625
12626         * mdebugread.c (parse_partial_symbols): Use
12627         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12628
12629 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12630
12631         * linux-fork.c (scoped_switch_fork_info)
12632         <~scoped_switch_fork_info>: Fix incorrect variable name.
12633
12634 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12635
12636         * linux-fork.c (scoped_switch_fork_info)
12637         <scoped_switch_fork_info>: Make explicit.
12638         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12639
12640 2019-01-10  Tom Tromey  <tom@tromey.com>
12641
12642         * objfiles.h (objfile::reset_psymtabs): Update.
12643         * objfiles.c (objfile::objfile): Update.
12644         * psymtab.h (psymtab_storage::obstack): Update.
12645         (psymtab_storage::m_obstack): Use gdb::optional.
12646         (class psymtab_storage): Update comment.  Remove objfile
12647         parameter.
12648         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12649
12650 2019-01-10  Tom Tromey  <tom@tromey.com>
12651
12652         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12653         <free_psymtabs>: Now private.
12654         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12655         (allocate_psymtab): Use new method.
12656
12657 2019-01-10  Tom Tromey  <tom@tromey.com>
12658
12659         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12660         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12661         * mdebugread.c (parse_partial_symbols): Use
12662         allocate_dependencies.
12663         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12664         allocate_dependencies.
12665         (process_psymtab_comp_unit_reader)
12666         (build_type_psymtab_dependencies): Likewise.
12667         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12668
12669 2019-01-10  Tom Tromey  <tom@tromey.com>
12670
12671         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12672         PSYMBOL_SET_LANGUAGE.
12673         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12674
12675 2019-01-10  Tom Tromey  <tom@tromey.com>
12676
12677         * psymtab.h (psymtab_storage::obstack): New method.
12678         <m_obstack>: Rename from obstack; now private.
12679         * psymtab.c (psymtab_storage): Update.
12680         * dwarf2read.c (create_addrmap_from_index)
12681         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12682         Update.
12683
12684 2019-01-10  Tom Tromey  <tom@tromey.com>
12685
12686         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12687         * objfiles.h (objfile::reset_psymtabs): New method.
12688
12689 2019-01-10  Tom Tromey  <tom@tromey.com>
12690
12691         * symmisc.c (print_symbol_bcache_statistics): Update.
12692         (print_objfile_statistics): Update.
12693         * symfile.c (reread_symbols): Update.
12694         * psymtab.h (class psymtab_storage): New.
12695         * psymtab.c (psymtab_storage): New constructor.
12696         (~psymtab_storage): New destructor.
12697         (require_partial_symbols): Update.
12698         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12699         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12700         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12701         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12702         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12703         (start_psymtab_common, end_psymtab_common)
12704         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12705         (allocate_psymtab): Update.
12706         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12707         Update.
12708         (dump_psymtab_addrmap, maintenance_print_psymbols)
12709         (maintenance_check_psymtabs): Update.
12710         (class objfile_psymtabs): Move to objfiles.h.
12711         * psympriv.h (discard_psymtab): Now inline.
12712         (psymtab_discarder::psymtab_discarder): Update.
12713         (psymtab_discarder::~psymtab_discarder): Update.
12714         (ALL_OBJFILE_PSYMTABS): Rewrite.
12715         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12716         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12717         Remove fields.
12718         <partial_symtabs>: New field.
12719         (class objfile_psymtabs): Move from psymtab.h.  Update.
12720         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12721         psymbol_cache.
12722         (objfile::~objfile): Don't destroy psymbol_cache.
12723         * mdebugread.c (parse_partial_symbols): Update.
12724         * dwarf2read.c (create_addrmap_from_index)
12725         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12726         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12727         (add_partial_subprogram, dwarf2_ranges_read): Update.
12728         * dwarf-index-write.c (write_address_map)
12729         (write_one_signatured_type, recursively_write_psymbols)
12730         (class debug_names, class debug_names, write_psymtabs_to_index):
12731         Update.
12732
12733 2019-01-10  Tom Tromey  <tom@tromey.com>
12734
12735         * symtab.h (SYMBOL_SET_NAMES): Update.
12736         (symbol_set_names): Update.
12737         (MSYMBOL_SET_NAMES): Update.
12738         * symtab.c (symbol_set_names): Change argument to be an
12739         objfile_per_bfd_storage.
12740         * psymtab.c (add_psymbol_to_bcache): Update.
12741         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12742
12743 2019-01-10  Tom Tromey  <tom@tromey.com>
12744
12745         * symtab.c (create_demangled_names_hash): Change argument to be an
12746         objfile_per_bfd_storage.
12747         (symbol_set_names): Update.
12748
12749 2019-01-10  Tom Tromey  <tom@tromey.com>
12750
12751         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12752         init_psymbol_list.
12753         * psymtab.c (init_psymbol_list): Do nothing if already called.
12754         * psympriv.h (init_psymbol_list): Add comment.
12755         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12756         init_psymbol_list.
12757         * dbxread.c (dbx_symfile_read): Unconditionally call
12758         init_psymbol_list.
12759
12760 2019-01-10  Tom Tromey  <tom@tromey.com>
12761
12762         * xcoffread.c (scan_xcoff_symtab): Update.
12763         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12764         "where".
12765         * mdebugread.c (parse_partial_symbols)
12766         (handle_psymbol_enumerators): Update.
12767         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12768         * dbxread.c (read_dbx_symtab): Update.
12769         * psympriv.h (psymbol_placement): New enum.
12770         (add_psymbol_to_list): Update.
12771
12772 2019-01-10  Tom Tromey  <tom@tromey.com>
12773
12774         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12775         static_psymbols parameters.
12776         (scan_xcoff_symtab): Update.
12777         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12778         static_psymbols parameters.
12779         * psympriv.h (start_psymtab_common): Update.
12780         * mdebugread.c (parse_partial_symbols): Update.
12781         * dwarf2read.c (create_partial_symtab): Update.
12782         * dbxread.c (read_dbx_symtab): Update.
12783         (start_psymtab): Remove global_psymbols and static_psymbols
12784         parameters.
12785
12786 2019-01-10  Tom Tromey  <tom@tromey.com>
12787
12788         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12789         * psymtab.c (allocate_psymtab): Add comment.
12790         * psympriv.h (allocate_psymtab): Add comment.
12791         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12792         initializations.
12793         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12794
12795 2019-01-10  Tom Tromey  <tom@tromey.com>
12796
12797         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12798         Don't declare.
12799         * mipsread.c: Include mdebugread.h.
12800         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12801         Declare.
12802         * elfread.c: Include mdebugread.h.
12803
12804 2019-01-09  Tom Tromey  <tom@tromey.com>
12805
12806         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12807         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12808         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12809         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12810         (psym_lookup_symbol, psym_find_last_source_symtab)
12811         (psym_forget_cached_source_info, psym_print_stats)
12812         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12813         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12814         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12815         (psym_find_compunit_symtab_by_address)
12816         (maintenance_print_psymbols, maintenance_info_psymtabs)
12817         (maintenance_check_psymtabs): Use ranged for.
12818         * psymtab.h (class objfile_psymtabs): New.
12819         (require_partial_symbols): Return objfile_psymtabs.
12820         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12821
12822 2019-01-09  Tom Tromey  <tom@tromey.com>
12823
12824         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12825         (find_pc_mapped_section, list_overlays_command)
12826         (map_overlay_command, unmap_overlay_command)
12827         (simple_overlay_update): Use all_objfiles.
12828         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12829         * printcmd.c (info_symbol_command): Use all_objfiles.
12830         * objfiles.h (ALL_OBJSECTIONS): Remove.
12831         * maint.c (maintenance_translate_address): Use all_objfiles.
12832         * gcore.c (gcore_create_callback): Use all_objfiles.
12833         (objfile_find_memory_regions): Likewise.
12834
12835 2019-01-09  Tom Tromey  <tom@tromey.com>
12836
12837         * symtab.c (find_line_symtab, info_sources_command)
12838         (make_source_files_completion_list): Use objfile_compunits.
12839         * source.c (select_source_symtab): Use objfile_compunits.
12840         * objfiles.h (struct objfile): Update comment.
12841         (ALL_OBJFILES): Remove.
12842         (ALL_FILETABS): Remove.
12843         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12844         objfile_compunits.
12845
12846 2019-01-09  Tom Tromey  <tom@tromey.com>
12847
12848         * symmisc.c (print_objfile_statistics, dump_objfile)
12849         (maintenance_print_symbols): Use compunit_filetabs.
12850         * source.c (forget_cached_source_info_for_objfile): Use
12851         compunit_filetabs.
12852         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12853         (ALL_FILETABS): Use compunit_filetabs.
12854         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12855         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12856
12857 2019-01-09  Tom Tromey  <tom@tromey.com>
12858
12859         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12860         (compunit_filetabs): New.
12861         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12862         compunit_filetabs.
12863         (info_sources_command, make_source_files_completion_list): Remove
12864         declaration.
12865         * symmisc.c (print_objfile_statistics, dump_objfile)
12866         (maintenance_print_symbols): Remove declaration.
12867         (maintenance_info_symtabs): Use compunit_filetabs.
12868         (maintenance_info_line_tables): Likewise.
12869         * source.c (select_source_symtab): Change local variable name.
12870         (forget_cached_source_info_for_objfile): Remove declaration.
12871         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12872         * objfiles.c (objfile_relocate1): Remove declaration.
12873         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12874         declaration.
12875         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12876         * coffread.c (coff_symtab_read): Remove declaration.
12877         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12878         compunit_filetabs.
12879
12880 2019-01-09  Tom Tromey  <tom@tromey.com>
12881
12882         * symtab.c (lookup_objfile_from_block)
12883         (find_pc_sect_compunit_symtab, search_symbols)
12884         (default_collect_symbol_completion_matches_break_on): Use
12885         objfile_compunits.
12886         * objfiles.h (ALL_COMPUNITS): Remove.
12887         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12888         * cp-support.c (add_symbol_overload_list_qualified): Use
12889         objfile_compunits.
12890         * ada-lang.c (ada_collect_symbol_completion_matches)
12891         (ada_add_global_exceptions): Use objfile_compunits.
12892
12893 2019-01-09  Tom Tromey  <tom@tromey.com>
12894
12895         * source.c (select_source_symtab)
12896         (forget_cached_source_info_for_objfile): Remove declaration.
12897         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12898         declaration.
12899         * maint.c (count_symtabs_and_blocks): Remove declaration.
12900         * cp-support.c (add_symbol_overload_list_qualified): Remove
12901         declaration.
12902         * coffread.c (coff_symtab_read): Remove declaration.
12903         * symtab.c (lookup_symbol_in_objfile_symtabs)
12904         (basic_lookup_transparent_type_1): Use objfile_compunits.
12905         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12906         (info_sources_command, search_symbols)
12907         (default_collect_symbol_completion_matches_break_on)
12908         (make_source_files_completion_list): Remove declaration.
12909         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12910         (ada_collect_symbol_completion_matches)
12911         (ada_add_global_exceptions): Remove declaration.
12912         * linespec.c (iterate_over_all_matching_symtabs): Use
12913         objfile_compunits.
12914         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12915         (class objfile_compunits): New.
12916         (ALL_COMPUNITS): Use objfile_compunits.
12917         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12918         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12919         objfile_compunits.
12920         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12921
12922 2019-01-09  Tom Tromey  <tom@tromey.com>
12923
12924         * symtab.c (search_symbols)
12925         (default_collect_symbol_completion_matches_break_on): Use
12926         objfile_msymbols.
12927         * ada-lang.c (ada_lookup_simple_minsym)
12928         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12929         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12930         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12931         objfile_msymbols.
12932         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12933         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12934         * objc-lang.c (find_methods): Use objfile_msymbols.
12935         (info_selectors_command, info_classes_command): Likewise.
12936         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12937         * objfiles.h (class objfile_msymbols): New.
12938         (ALL_OBJFILE_MSYMBOLS): Remove.
12939         (ALL_MSYMBOLS): Remove.
12940
12941 2019-01-09  Tom Tromey  <tom@tromey.com>
12942
12943         * common/next-iterator.h (next_adapter): Add Iterator template
12944         parameter.
12945         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12946         (class all_objfiles_safe): New.
12947         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12948         * objfiles.c (put_objfile_before): Update comment.
12949         (add_separate_debug_objfile): Likewise.
12950         (free_all_objfiles): Use all_objfiles_safe.
12951         (objfile_purge_solibs): Likewise.
12952
12953 2019-01-09  Tom Tromey  <tom@tromey.com>
12954
12955         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12956         (expand_symtab_containing_pc, lookup_static_symbol)
12957         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12958         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12959         all_objfiles.
12960         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12961         * breakpoint.c (create_overlay_event_breakpoint)
12962         (create_longjmp_master_breakpoint)
12963         (create_std_terminate_master_breakpoint)
12964         (create_exception_master_breakpoint): Use all_objfiles.
12965         * linux-thread-db.c (try_thread_db_load_from_pdir)
12966         (has_libpthread): Use all_objfiles.
12967         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12968         * linespec.c (iterate_over_all_matching_symtabs)
12969         (search_minsyms_for_name): Use all_objfiles.
12970         * maint.c (maintenance_info_sections): Use all_objfiles.
12971         * main.c (captured_main_1): Use all_objfiles.
12972         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12973         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12974         * guile/scm-pretty-print.c
12975         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12976         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12977         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12978         (maintenance_print_msymbols): Use all_objfiles.
12979         * source.c (select_source_symtab): Use all_objfiles.
12980         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12981         * symfile.c (remove_symbol_file_command)
12982         (expand_symtabs_matching, map_symbol_filenames): Use
12983         all_objfiles.
12984         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12985         all_objfiles.
12986         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12987         * objc-lang.c (find_methods): Use all_objfiles.
12988         * objfiles.c (have_partial_symbols, have_full_symbols)
12989         (have_minimal_symbols, qsort_cmp)
12990         (default_iterate_over_objfiles_in_search_order): Use
12991         all_objfiles.
12992         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12993         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12994         (maintenance_check_psymtabs): Use all_objfiles.
12995         (ALL_PSYMTABS): Remove.
12996         * compile/compile-object-run.c (do_module_cleanup): Use
12997         all_objfiles.
12998         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12999         * cp-support.c (add_symbol_overload_list_qualified): Use
13000         all_objfiles.
13001         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13002         Use all_objfiles.
13003         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13004         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13005         all_objfiles.
13006         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13007         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13008         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13009         Uses all_objfiles.
13010         * solib.c (solib_read_symbols): Use all_objfiles
13011
13012 2019-01-09  Tom Tromey  <tom@tromey.com>
13013
13014         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13015         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13016         all_objfiles.
13017         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13018         * symmisc.c (print_symbol_bcache_statistics)
13019         (print_objfile_statistics, maintenance_print_objfiles)
13020         (maintenance_info_symtabs, maintenance_check_symtabs)
13021         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13022         all_objfiles.
13023         * source.c (forget_cached_source_info): Use all_objfiles.
13024         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13025         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13026         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13027         * objfiles.c (update_section_map): Use all_objfiles.
13028         (shared_objfile_contains_address_p): Likewise.
13029         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13030         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13031
13032 2019-01-09  Tom Tromey  <tom@tromey.com>
13033
13034         * common/next-iterator.h: New file.
13035         * objfiles.h (class all_objfiles): New.
13036         (struct objfile_iterator): New.
13037
13038 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13039
13040         * NEWS: Move the description of the changed "frame", "select-frame",
13041          and "info frame" commands to the Changed commands section.
13042
13043 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13044
13045         * gdbtypes.c (check_stub_method_group): Remove handling of old
13046         mangling schemes.
13047         * linespec.c (find_methods): Likewise.
13048         * stabsread.c (read_member_functions): Likewise.
13049         * valops.c (search_struct_method): Likewise.
13050         (value_struct_elt_for_reference): Likewise.
13051         * NEWS: Mention this change.
13052
13053 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13054
13055         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13056         print_source_lines.
13057         * source.c (print_source_lines_base): Update line number check.
13058         (print_source_lines): New function.
13059         (source_lines_range::source_lines_range): New function.
13060         * source.h (class source_lines_range): New class.
13061         (print_source_lines): New declaration.
13062
13063 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13064
13065         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13066
13067 2019-01-08  Tom Tromey  <tom@tromey.com>
13068             Simon Marchi  <simon.marchi@ericsson.com>
13069
13070         PR gdb/24060
13071         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13072         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13073         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13074         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13075         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13076         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13077
13078 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13079
13080         * source.c (select_source_symtab): Move header comment to
13081         declaration in source.h.
13082         (forget_cached_source_info_for_objfile): Likewise.
13083         (forget_cached_source_info): Likewise.
13084         (identify_source_line): Likewise.
13085         * source.h (identify_source_line): Move declaration from symtab.h
13086         and add comment from source.c
13087         (print_source_lines): Likewise.
13088         (forget_cached_source_info_for_objfile): Likewise.
13089         (forget_cached_source_info): Likewise.
13090         (select_source_symtab): Likewise.
13091         (enum print_source_lines_flag): Move definition from symtab.h.
13092         * symtab.h (identify_source_line): Move declaration to source.h.
13093         (print_source_lines): Likewise.
13094         (forget_cached_source_info_for_objfile): Likewise.
13095         (forget_cached_source_info): Likewise.
13096         (select_source_symtab): Likewise.
13097         (enum print_source_lines_flag): Move definition to source.h.
13098         * tui/tui-hooks.c: Add 'source.h' include.
13099
13100 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13101
13102         * source.c (print_source_lines_base): Handle requests to print
13103         reverse line number sequences, and guard against empty lines
13104         string.
13105
13106 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13107
13108         * source.c (print_source_lines_base): Fix skip of '\r' if next
13109         character is '\n'.
13110
13111 2019-01-06  Tom Tromey  <tom@tromey.com>
13112
13113         * c-exp.y (struct c_parse_state) <macro_original_text,
13114         expansion_obstack>: New member.
13115         (macro_original_text, expansion_obstack): Remove globals.
13116         (scan_macro_expansion, scanning_macro_expansion)
13117         (finished_macro_expansion): Update.
13118         (scan_macro_cleanup): Remove.
13119         (yylex, c_parse): Update.
13120
13121 2019-01-06  Tom Tromey  <tom@tromey.com>
13122
13123         * c-exp.y (struct c_parse_state) <strings>: New member.
13124         (operator_stoken): Update.
13125
13126 2019-01-06  Tom Tromey  <tom@tromey.com>
13127
13128         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13129         (union type_stack_elt) <typelist_val>: Now a pointer to
13130         std::vector.
13131         (type_stack_cleanup): Don't declare.
13132         (push_typelist): Update.
13133         * parse.c (pop_typelist): Return a std::vector.
13134         (push_typelist): Take a std::vector.
13135         (follow_types): Update.  Do not free args.
13136         (type_stack_cleanup): Remove.
13137         * c-exp.y (struct c_parse_state): New.
13138         (cpstate): New global.
13139         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13140         (nonempty_typelist): Update.
13141         (func_mod): Create a new vector.
13142         (c_parse): Create a c_parse_state.
13143         (check_parameter_typelist): Do not delete params.
13144         (function_method): Update.  Do not delete type_list.
13145
13146 2019-01-06  Tom Tromey  <tom@tromey.com>
13147
13148         PR gdb/28155:
13149         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13150         check_typedef.
13151         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13152         (print_return_value): Likewise.
13153
13154 2019-01-05  Tom Tromey  <tom@tromey.com>
13155
13156         * contrib/cleanup_check.py: Remove.
13157         * contrib/gcc-with-excheck: Remove.
13158         * contrib/exsummary.py: Remove.
13159         * contrib/excheck.py: Remove.
13160
13161 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13162
13163         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13164         NULL. Initialize tpprev to NULL instead of assigning it
13165         to NULL on the next statement.
13166         * windows-nat.c (windows_delete_thread): Remove check for
13167         main_thread_id before printing thread exit notifications.
13168         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13169         Remove thread ID check against main_thread_id.
13170         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13171         windows_delete_thread.
13172         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13173
13174 2019-01-04  Tom Tromey  <tom@tromey.com>
13175
13176         * compile/compile.c (_initialize_compile): Use upper case for
13177         metasyntactic variables.
13178         * symmisc.c (_initialize_symmisc): Use upper case for
13179         metasyntactic variables.
13180         * psymtab.c (_initialize_psymtab): Use upper case for
13181         metasyntactic variables.
13182         * demangle.c (demangle_command): Use upper case for metasyntactic
13183         variables.
13184         (_initialize_demangler): Likewise.
13185         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13186         variables.
13187
13188 2019-01-03  Tom Tromey  <tom@tromey.com>
13189
13190         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13191
13192 2019-01-03  Tom Tromey  <tom@tromey.com>
13193
13194         * python/py-symtab.c (salpy_str): Update.
13195         (struct salpy_sal_object) <symtab>: Now a PyObject.
13196         (salpy_dealloc): Update.
13197         (del_objfile_sal): Use gdbpy_ref.
13198
13199 2019-01-03  Tom Tromey  <tom@tromey.com>
13200
13201         * python/py-type.c (convert_field): Use new_reference.  Return
13202         gdbpy_ref.
13203         (make_fielditem): Return gdbpy_ref.
13204         (typy_fields): Update.
13205         (typy_getitem): Update.
13206         (field_name): Return gdbpy_ref.  Use new_reference.
13207         (typy_iterator_iternext): Update.
13208
13209 2019-01-03  Tom Tromey  <tom@tromey.com>
13210
13211         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13212
13213 2019-01-03  Tom Tromey  <tom@tromey.com>
13214
13215         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13216         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13217         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13218         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13219         (pspy_set_type_printers): Likewise.
13220         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13221         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13222         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13223         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13224         (objfpy_set_type_printers): Likewise.
13225
13226 2019-01-03  Tom Tromey  <tom@tromey.com>
13227
13228         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13229         (gdbpy_print_stack): Use gdbpy_err_fetch.
13230         * python/python-internal.h (class gdbpy_err_fetch): New class.
13231         (class gdbpy_enter) <m_error_type, m_error_value,
13232         m_error_traceback>: Remove.
13233         <m_error>: New member.
13234         (gdbpy_exception_to_string): Don't declare.
13235         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13236         * python/py-value.c (convert_value_from_python): Use
13237         gdbpy_err_fetch.
13238         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13239         gdbpy_exception_to_string.
13240         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13241         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13242         gdbpy_err_fetch.
13243
13244 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13245
13246         * linux-nat.c (delete_lwp_cleanup): Delete.
13247         (struct lwp_deleter): New struct.
13248         (lwp_info_up): New typedef.
13249         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13250         lwp_info_up.
13251
13252 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13253
13254         * linux-fork.c (class scoped_switch_fork_info): New class.
13255         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13256
13257 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13258
13259         * valops.c (find_overload_match): Remove use of null_cleanup, and
13260         calls to do_cleanups.
13261
13262 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13263
13264         * compile/compile-cplus-types.c
13265         (compile_cplus_instance::decl_name): Handle changes to
13266         cp_func_name.
13267         * cp-support.c (cp_func_name): Update header comment, update
13268         return type.
13269         * cp-support.h (cp_func_name): Update return type in declaration.
13270         * valops.c (find_overload_match): Move temp_func local to top
13271         level of function and change its type.  Use temp_func to hold and
13272         delete temporary string obtained from cp_func_name.
13273
13274 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13275
13276         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13277         gdb::char_vector, remove cleanup, and update uses of `msg`.
13278
13279 2019-01-03  Jim Wilson  <jimw@sifive.com>
13280
13281         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13282
13283 2019-01-02  Tom Tromey  <tom@tromey.com>
13284
13285         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13286         (tdesc_parse_xml): Remove cleanups.
13287         * target-descriptions.h (make_cleanup_free_target_description):
13288         Don't declare.
13289         (target_desc_deleter): New struct.
13290         (target_desc_up): New typedef.
13291         * target-descriptions.c (target_desc_deleter::operator()): Rename
13292         from free_target_description.
13293         (make_cleanup_free_target_description): Remove.
13294
13295 2019-01-02  Tom Tromey  <tom@tromey.com>
13296
13297         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13298         constructor, destructor.
13299         (linespec_parser): Remove typedef.
13300         (~linespec_parser): Rename from linespec_parser_delete.
13301         (linespec_lex_to_end, linespec_complete_label)
13302         (linespec_complete): Update.
13303         (decode_line_full): Remove cleanups.
13304         (decode_line_1): Update.
13305
13306 2019-01-02  Tom Tromey  <tom@tromey.com>
13307
13308         * python/python-internal.h (inferior_to_inferior_object): Change
13309         return type.
13310         * python/py-exitedevent.c (create_exited_event_object): Update.
13311         * python/py-inferior.c (inferior_to_inferior_object): Return
13312         gdbpy_ref.
13313         (python_new_inferior, python_inferior_deleted)
13314         (thread_to_thread_object, delete_thread_object)
13315         (build_inferior_list, gdbpy_selected_inferior): Update.
13316         * python/py-infthread.c (create_thread_object): Update.  Also fail
13317         if inferior_to_inferior_object fails.
13318
13319 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13320
13321         * inferior.h (class inferior) <displaced_step_state>: New field.
13322         * infrun.h (struct displaced_step_state): Move here from
13323         infrun.c.  Initialize fields, add constructor.
13324         <inf>: Remove field.
13325         <reset>: New method.
13326         * infrun.c (struct displaced_step_inferior_state): Move to
13327         infrun.h.
13328         (displaced_step_inferior_states): Remove.
13329         (get_displaced_stepping_state): Adust.
13330         (displaced_step_in_progress_any_inferior): Adjust.
13331         (displaced_step_in_progress_thread): Adjust.
13332         (displaced_step_in_progress): Adjust.
13333         (add_displaced_stepping_state): Remove.
13334         (get_displaced_step_closure_by_addr): Adjust.
13335         (remove_displaced_stepping_state): Remove.
13336         (infrun_inferior_exit): Call displaced_step_state.reset.
13337         (use_displaced_stepping): Don't check for NULL.
13338         (displaced_step_prepare_throw): Call
13339         get_displaced_stepping_state.
13340         (displaced_step_fixup): Don't check for NULL.
13341         (prepare_for_detach): Don't check for NULL.
13342
13343 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13344
13345         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13346          in case of call that did not complete.
13347
13348 2019-01-02  Andrey Utkin  <autkin@undo.io>
13349
13350         * symfile.c (find_separate_debug_file): Fix search of debug files for
13351         remote debuggee.
13352
13353 2019-01-02  Tom Tromey  <tom@tromey.com>
13354
13355         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13356         indentation.
13357         * python/py-frame.c (frapy_older): Remove cast.
13358         (frapy_newer): Likewise.
13359         * python/py-breakpoint.c (local_setattro): Remove cast.
13360         * python/py-arch.c (archpy_name): Remove local variable.
13361         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13362
13363 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13364
13365         * unittests/basic_string_view/element_access/char/empty.cc:
13366         Fix year range in copyright header.
13367
13368 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13369
13370         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13371         Delete.
13372         <operator==>: Update with for removed field.
13373         <hash>: Likewise.
13374         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13375         <isa_features>: ...this.
13376         <abi_features>: New field.
13377         (riscv_isa_flen): Update comment.
13378         (riscv_abi_xlen): New declaration.
13379         (riscv_abi_flen): New declaration.
13380         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13381         isa_features.
13382         (riscv_abi_xlen): New function.
13383         (riscv_isa_flen): Update to get answer from isa_features.
13384         (riscv_abi_flen): New function.
13385         (riscv_has_fp_abi): Update to get answer from abi_features.
13386         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13387         xlen and flen.
13388         (riscv_call_info) <xlen, flen>: Update comment.
13389         (riscv_call_arg_struct): Remove invalid assertions
13390         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13391         is removed.
13392         (riscv_gdbarch_init): Gather isa features and abi features
13393         separately, ensure both match on the gdbarch when reusing an old
13394         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13395         a target with 64-bit float hardware.
13396
13397 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13398
13399         * source.c (search_command_helper): Stop reverse search
13400         when line 1 has been searched.
13401
13402 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13403
13404         * record-full.c (record_full_base_target::close): Rewrite
13405         record_full_core_buf_list free logic.
13406
13407 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13408
13409         * break-catch-syscall.c (print_one_catch_syscall): xfree
13410         the last text.
13411
13412 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13413
13414         * top.c (print_gdb_version): Update Copyright year in version
13415         message.
13416
13417 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13418
13419         Update copyright year range in all GDB files.
13420
13421 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13422
13423         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13424
13425 For older changes see ChangeLog-2018.
13426 \f
13427 Local Variables:
13428 mode: change-log
13429 left-margin: 8
13430 fill-column: 74
13431 version-control: never
13432 coding: utf-8
13433 End:
13434