gdb/ChangeLog

   1 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
   2
   3         * Makefile.in: Add new files.
   4         * aarch32-tdep.c: New file.
   5         * aarch32-tdep.h: New file.
   6         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
   7         Call aarch32_read_description.
   8         * arch/aarch32.c: New file.
   9         * arch/aarch32.h: New file.
  10         * arch/arm.c (arm_create_target_description)
  11         (arm_create_mprofile_target_description): New function.
  12         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
  13         (arm_create_target_description)
  14         (arm_create_mprofile_target_description): New declaration.
  15         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
  16         read_description functions.
  17         * arm-linux-nat.c (arm_linux_nat_target::read_description):
  18         Likewise.
  19         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
  20         * arm-tdep.c (tdesc_arm_list): New variable.
  21         (arm_register_g_packet_guesses): Call create description functions.
  22         (arm_read_description) (arm_read_mprofile_description): New
  23         function.
  24         * arm-tdep.h (arm_read_description)
  25         (arm_read_mprofile_description): Add declaration.
  26         * configure.tgt: Add new files.
  27
  28 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
  29
  30         * top.c (new_ui_command): Open specified terminal just once.
  31
  32 2019-07-18  Tom Tromey  <tromey@adacore.com>
  33
  34         * symtab.c (main_name): Constify return type.
  35         * symfile.c (set_initial_language): Update.
  36         * symtab.h (main_name): Constify return type.
  37
  38 2019-07-17  Tom Tromey  <tom@tromey.com>
  39
  40         * tui/tui-winsource.c (tui_update_source_window)
  41         (tui_update_source_window_as_is)
  42         (tui_update_source_windows_with_line): Remove return.
  43         * tui/tui-disasm.c (tui_show_disassem)
  44         (tui_show_disassem_and_update_source): Remove return.
  45         * tui/tui.c (tui_reset): Remove return.
  46         * tui/tui-wingeneral.c
  47         (tui_check_and_display_highlight_if_needed): Remove return.
  48
  49 2019-07-17  Tom Tromey  <tom@tromey.com>
  50
  51         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
  52
  53 2019-07-17  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-winsource.h (struct tui_exec_info_window)
  56         (struct tui_source_window_base): Move from tui-data.h.
  57         * tui/tui-winsource.c: Move many method definitions from
  58         elsewhere.  Remove "structuring" comments.
  59         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
  60         (tui_source_window_base::refresh_window): Move to
  61         tui-winsource.c.
  62         * tui/tui-win.c (tui_source_window_base::refresh_all)
  63         (tui_source_window_base::update_tab_width)
  64         (tui_source_window_base::set_new_height)
  65         (tui_source_window_base::do_make_visible_with_new_height): Move to
  66         tui-winsource.c.
  67         * tui/tui-source.h: Update.
  68         * tui/tui-source.c (tui_source_window_base::reset): Move to
  69         tui-winsource.c.
  70         * tui/tui-disasm.h: Update.
  71         * tui/tui-data.h (struct tui_exec_info_window): Move to
  72         tui-winsource.h.
  73         (struct tui_source_window_base): Likewise.
  74         * tui/tui-data.c (tui_source_window_base::clear_detail)
  75         (tui_source_window_base, ~tui_source_window_base): Move to
  76         tui-winsource.c.
  77
  78 2019-07-17  Tom Tromey  <tom@tromey.com>
  79
  80         * tui/tui-win.c (tui_resize_all)
  81         (tui_source_window_base::update_tab_width)
  82         (tui_adjust_win_heights): Update.
  83         (tui_win_info::make_invisible_and_set_new_height): Rename from
  84         make_invisible_and_set_new_height.
  85         * tui/tui-data.h (struct tui_win_info)
  86         <make_invisible_and_set_new_height>: New method.
  87
  88 2019-07-17  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui.c: Update.
  91         * tui/tui-source.h (struct tui_source_window): Move from
  92         tui-data.h.
  93         * tui/tui-layout.c: Update.
  94         * tui/tui-disasm.c: Update.
  95         * tui/tui-data.h (struct tui_source_window): Move to
  96         tui-source.h.
  97
  98 2019-07-17  Tom Tromey  <tom@tromey.com>
  99
 100         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 101         tui-data.h.
 102         * tui/tui-data.h (struct tui_disasm_window): Move to
 103         tui-disasm.h.
 104
 105 2019-07-17  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-regs.h (struct tui_data_item_window): Move from
 108         tui-data.h.
 109         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 110         * tui/tui-data.h (struct tui_data_item_window): Move to
 111         tui-regs.h.
 112         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 113
 114 2019-07-17  Tom Tromey  <tom@tromey.com>
 115
 116         * tui/tui.c: Update.
 117         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 118         (tui_cmd_window::max_height): Move to tui-command.c.
 119         * tui/tui-layout.c: Update.
 120         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 121         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 122         tui-command.c.
 123         * tui/tui-command.h (struct tui_cmd_window): Move from
 124         tui-data.h.
 125         * tui/tui-command.c: Remove "structuring" comments.
 126         (tui_cmd_window::clear_detail)
 127         (tui_cmd_window::do_make_visible_with_new_height)
 128         (tui_cmd_window::max_height): Move from elsewhere.
 129
 130 2019-07-17  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 133         Now static.
 134         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 135         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 136
 137 2019-07-17  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui.c: Update.
 140         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 141         tui-regs.c.
 142         * tui/tui-windata.h: Remove file.
 143         * tui/tui-windata.c: Remove file.
 144         * tui/tui-win.c (tui_data_window::set_new_height)
 145         (tui_data_window::do_make_visible_with_new_height): Move to
 146         tui-regs.c.
 147         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 148         * tui/tui-regs.c: Remove "structuring" comments.
 149         (tui_data_window::first_data_item_displayed)
 150         (tui_data_window::delete_data_content_windows)
 151         (tui_data_window::erase_data_content)
 152         (tui_data_window::display_all_data)
 153         (tui_data_window::refresh_all)
 154         (tui_data_window::do_scroll_vertical)
 155         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 156         (tui_data_window::do_make_visible_with_new_height)
 157         (tui_data_window::refresh_window): Move from elsewhere.
 158         (_initialize_tui_regs): Move to end of file.
 159         * tui/tui-layout.c: Update.
 160         * tui/tui-hooks.c: Update.
 161         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 162         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 163         tui-regs.c.
 164         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 165
 166 2019-07-17  Tom Tromey  <tom@tromey.com>
 167
 168         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 169         seen.
 170
 171 2019-07-17  Tom Tromey  <tom@tromey.com>
 172
 173         * tui/tui-win.c (tui_source_window_base::set_new_height)
 174         (tui_source_window_base::do_make_visible_with_new_height): Use
 175         m_has_locator field directly.
 176         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 177         method.
 178         (struct tui_source_window_base) <has_locator>: Likewise.
 179
 180 2019-07-17  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 183         Don't declare.
 184         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 185         Remove.
 186         * tui/tui-win.c (tui_source_window_base::set_new_height)
 187         (tui_source_window_base::set_new_height)
 188         (make_invisible_and_set_new_height)
 189         (tui_source_window_base::do_make_visible_with_new_height)
 190         (tui_source_window_base::do_make_visible_with_new_height):
 191         Update.
 192         * tui/tui-layout.c (show_source_disasm_command, show_data)
 193         (show_source_or_disasm_and_command): Update.
 194         * tui/tui-layout.c (show_layout): Update.
 195
 196 2019-07-17  Tom Tromey  <tom@tromey.com>
 197
 198         * tui/tui-layout.c (make_data_window): Remove.
 199         (show_data): Unify creation and re-initialization cases.
 200
 201 2019-07-17  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-layout.c (make_source_window, make_disasm_window):
 204         Remove.
 205         (show_data): Unify creation and re-initialization cases.
 206
 207 2019-07-17  Tom Tromey  <tom@tromey.com>
 208
 209         * tui/tui-layout.c (make_command_window): Remove.
 210         (show_source_disasm_command, show_source_or_disasm_and_command):
 211         Unify creation and re-initialization cases.
 212
 213 2019-07-17  Tom Tromey  <tom@tromey.com>
 214
 215         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 216         creation and re-initialization cases.
 217
 218 2019-07-17  Tom Tromey  <tom@tromey.com>
 219
 220         * tui/tui-regs.c (tui_get_register): Return void.
 221
 222 2019-07-17  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 225         Simplify.
 226
 227 2019-07-17  Tom Tromey  <tom@tromey.com>
 228
 229         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 230         resetting.
 231
 232 2019-07-17  Tom Tromey  <tom@tromey.com>
 233
 234         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 235         * tui/tui-regs.c (tui_reg_layout): New function.
 236         (tui_show_registers, tui_reg_command): Use it.
 237         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 238         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 239         parameters.
 240         (tui_layout_command): Remove.
 241
 242 2019-07-17  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-layout.h (tui/tui-layout): Return void.
 245         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 246
 247 2019-07-17  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-layout.c (show_source_disasm_command, show_data):
 250         Update.
 251         (reset_locator): Remove.
 252         (show_source_or_disasm_and_command): Update.
 253
 254 2019-07-17  Tom Tromey  <tom@tromey.com>
 255
 256         * tui/tui-source.c (tui_source_window_base::reset): Remove
 257         win_type parameter.
 258         * tui/tui-layout.c (make_command_window, make_source_window)
 259         (make_disasm_window, make_data_window)
 260         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 261         (reset_locator, show_source_or_disasm_and_command): Update.
 262         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 263         win_type parameter.
 264         (struct tui_source_window_base) <reset>: Likewise.
 265
 266 2019-07-17  Tom Tromey  <tom@tromey.com>
 267
 268         * tui/tui-layout.c (show_source_disasm_command): Use
 269         reset_locator.
 270         (reset_locator): New function.
 271         (init_and_make_win): Remove.
 272         (show_source_or_disasm_and_command): Use reset_locator.
 273
 274 2019-07-17  Tom Tromey  <tom@tromey.com>
 275
 276         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 277         condition.
 278         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 279         Remove condition.
 280         * tui/tui-source.c (tui_source_window_base::reset): New method.
 281         * tui/tui-layout.c (make_command_window): Don't call
 282         init_and_make_win.
 283         (make_source_window, make_disasm_window): Don't call
 284         make_source_or_disasm_window.
 285         (make_data_window): Don't call init_and_make_win.  Change calling
 286         convention.
 287         (show_source_disasm_command, show_data): Simplify.
 288         (make_source_or_disasm_window): Remove.
 289         (show_source_or_disasm_and_command): Simplify.
 290         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 291         (struct tui_source_window_base) <reset>: Likewise.
 292         <execution_info>: Remove initializer.
 293         * tui/tui-data.c (tui_source_window_base): Initialize
 294         execution_info.
 295
 296 2019-07-17  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 299         variable.
 300
 301 2019-07-17  Tom Tromey  <tom@tromey.com>
 302
 303         * tui/tui.c (tui_rl_other_window): Update.
 304         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 305         superclass method first.  Always iterate over regs_content.
 306         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 307         method.
 308         * tui/tui-win.c (tui_set_focus_command): Update.
 309
 310 2019-07-17  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-win.c (tui_set_focus_command): Rename from
 313         tui_set_focus.  Call tui_enable.
 314         (tui_set_focus_command): Remove.
 315
 316 2019-07-17  Tom Tromey  <tom@tromey.com>
 317
 318         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 319         refresh_window.
 320         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 321         touchwin.
 322         (tui_data_window::refresh_window): Call refresh_window on data
 323         items.  Always call superclass refresh_window.
 324         (tui_win_info::refresh): Remove.
 325         (tui_source_window_base::refresh_window): Update.
 326         (tui_refresh_all): Update.
 327         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 328         refresh_window.
 329         (show_source_or_disasm_and_command): Likewise.
 330         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 331         (struct tui_source_window_base) <refresh>: Likewise.
 332
 333 2019-07-17  Tom Tromey  <tom@tromey.com>
 334
 335         * tui/tui-winsource.c (tui_clear_source_content)
 336         (tui_show_source_content): Update.
 337         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 338         whether content is empty.
 339         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 340         Remove.
 341
 342 2019-07-17  Tom Tromey  <tom@tromey.com>
 343
 344         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 345         window's contents.
 346         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 347         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 348
 349 2019-07-17  Tom Tromey  <tom@tromey.com>
 350
 351         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 352         (struct tui_data_item_window): Update.
 353
 354 2019-07-17  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 357         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 358         defines.
 359
 360 2019-07-17  Tom Tromey  <tom@tromey.com>
 361
 362         * tui/tui-winsource.h (tui_erase_source_content)
 363         (tui_clear_source_content): Remove "display_prompt" parameter.
 364         * tui/tui-winsource.c (tui_update_source_window_as_is)
 365         (tui_update_source_windows_with_addr): Update.
 366         (tui_clear_source_content): Remove "display_prompt" parameter.
 367         (tui_erase_source_content): Likewise.  Simplify.
 368         (tui_show_source_content): Update.
 369         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 370         * tui/tui-stack.c (tui_show_frame_info): Update.
 371         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 372         Remove defines.
 373
 374 2019-07-17  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 377         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 378         parameter.
 379         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 380         parameter.
 381
 382 2019-07-17  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-winsource.c (tui_clear_source_content)
 385         (tui_show_source_content, tui_show_exec_info_content)
 386         (tui_clear_exec_info_content): Update.
 387         * tui/tui-stack.c (tui_show_locator_content): Update.
 388         (tui_show_frame_info): Update.
 389         * tui/tui-source.h (tui_source_window): Don't declare.
 390         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 391         from tui_source_is_displayed.
 392         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 393         Remove field.
 394         (struct tui_source_window_base) <content_in_use>: New field.  Now
 395         bool.
 396         (struct tui_source_window) <showing_source_p>: New method.
 397         (TUI_SRC_WIN): Change cast.
 398         * tui/tui-data.c (tui_initialize_static_data): Update.
 399
 400 2019-07-17  Tom Tromey  <tom@tromey.com>
 401
 402         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 403         location_matches_p.
 404         * tui/tui-source.c (tui_source_window::location_matches_p): New
 405         method.
 406         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 407         method.
 408         * tui/tui-data.h (struct tui_source_window_base)
 409         <location_matches_p>: New method.
 410         (struct tui_source_window, struct tui_disasm_window)
 411         <location_matches_p>: Likewise.
 412
 413 2019-07-17  Tom Tromey  <tom@tromey.com>
 414
 415         * tui/tui-win.c (tui_set_win_height_command): Rename from
 416         tui_set_win_height.
 417         (tui_set_win_height_command): Remove.
 418
 419 2019-07-17  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-source.c (tui_source_window): New constructor.  Add
 422         observer.
 423         (~tui_source_window): New destructor.
 424         (tui_source_window::style_changed): New method.
 425         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 426         (tui_attach_detach_observers): Update.
 427         * tui/tui-data.h (struct tui_source_window): Make constructor not
 428         inline.  Add destructor.
 429         (struct tui_source_window) <style_changed>: New method.
 430         <m_observable>: New member.
 431
 432 2019-07-17  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 435         * tui/tui-win.c (tui_resize_all): Fix typo.
 436
 437 2019-07-17  Tom Tromey  <tom@tromey.com>
 438
 439         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 440         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 441         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 442         * tui/tui-win.c (window_name_completer): Use foreach.
 443         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 444         (update_tab_width): Likewise.
 445         * tui/tui-layout.c (show_layout): Update.
 446         * tui/tui-data.h (class tui_window_iterator): New.
 447         (struct all_tui_windows): New.
 448         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 449
 450 2019-07-17  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 453         parameter.  Don't reference globals.
 454         (tui_reg_command): Update.
 455
 456 2019-07-17  Tom Tromey  <tom@tromey.com>
 457
 458         * tui/tui-regs.c (tui_show_registers): Simplify.
 459
 460 2019-07-17  Tom Tromey  <tom@tromey.com>
 461
 462         * tui/tui-regs.c (tui_show_registers): Update.
 463         (tui_show_register_group): Add win_info parameter.
 464
 465 2019-07-17  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 468         Rename from tui_display_reg_element_at_line.
 469         (tui_data_window::display_registers_from_line): Update.
 470         * tui/tui-data.h (struct tui_data_window)
 471         <display_reg_element_at_line>: New method.
 472
 473 2019-07-17  Tom Tromey  <tom@tromey.com>
 474
 475         * tui/tui-regs.h (tui_display_registers_from)
 476         (tui_display_registers_from_line): Don't declare.
 477         * tui/tui-windata.c (tui_data_window::display_all_data)
 478         (tui_data_window::refresh_all)
 479         (tui_data_window::do_scroll_vertical): Update.
 480         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 481         from tui_display_registers_from.
 482         (tui_display_reg_element_at_line): Update.
 483         (tui_data_window::display_registers_from_line): Rename from
 484         tui_display_registers_from_line.
 485         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 486         display_registers_from_line>: New methods.
 487
 488 2019-07-17  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 491         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 492         from tui_erase_data_content.
 493         (tui_data_window::display_all_data)
 494         (tui_data_window::refresh_all)
 495         (tui_data_window::do_scroll_vertical): Update.
 496         * tui/tui-regs.c (tui_show_registers): Update.
 497         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 498         New method.
 499
 500 2019-07-17  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 503         declare.
 504         * tui/tui-windata.c
 505         (tui_data_window::delete_data_content_windows): Rename from
 506         tui_delete_data_content_windows.
 507         (tui_data_window::display_all_data)
 508         (tui_data_window::do_scroll_vertical): Update.
 509         * tui/tui-data.h (struct tui_data_window)
 510         <delete_data_content_windows>: New method.
 511
 512 2019-07-17  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 515         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 516
 517 2019-07-17  Tom Tromey  <tom@tromey.com>
 518
 519         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 520         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 521         from tui_display_all_data.
 522         * tui/tui-win.c
 523         (tui_data_window::do_make_visible_with_new_height): Update.
 524         * tui/tui-regs.c (tui_show_registers): Update.
 525         * tui/tui-layout.c (tui_set_layout): Update.
 526         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 527         method.
 528
 529 2019-07-17  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 532         * tui/tui-windata.c (tui_display_data_from): Remove.
 533         (tui_data_window::refresh_all): Update.
 534
 535 2019-07-17  Tom Tromey  <tom@tromey.com>
 536
 537         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 538         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 539         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 540         tui_display_registers_from_line.
 541         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 542         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 543         "force_display" parameter.
 544
 545 2019-07-17  Tom Tromey  <tom@tromey.com>
 546
 547         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 548         declare.
 549         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 550         Rename from tui_first_reg_element_no_inline.
 551         (tui_display_reg_element_at_line)
 552         (tui_display_registers_from_line): Update.
 553         * tui/tui-data.h (struct tui_data_window)
 554         <first_reg_element_no_inline>: New method.
 555
 556 2019-07-17  Tom Tromey  <tom@tromey.com>
 557
 558         * tui/tui-windata.c (tui_display_data_from)
 559         (tui_data_window::do_scroll_vertical): Update.
 560         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 561         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 562         Rename from tui_line_from_reg_element_no.
 563         (tui_display_registers_from_line): Update.
 564         * tui/tui-data.h (struct tui_data_window)
 565         <line_from_reg_element_no>: New method.
 566
 567 2019-07-17  Tom Tromey  <tom@tromey.com>
 568
 569         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 570         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 571         tui_last_regs_line_no.
 572         (tui_display_reg_element_at_line)
 573         (tui_display_registers_from_line): Update.
 574         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 575         method.
 576
 577 2019-07-17  Tom Tromey  <tom@tromey.com>
 578
 579         PR tui/24722:
 580         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 581         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 582         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 583         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 584         (tui_update_breakpoint_info): Likewise.
 585         * tui/tui-hooks.c (tui_event_create_breakpoint)
 586         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 587         Update.
 588
 589 2019-07-17  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 592
 593 2019-07-17  Tom Tromey  <tom@tromey.com>
 594
 595         * tui/tui-winsource.c (tui_update_source_window_as_is)
 596         (tui_update_source_windows_with_addr): Update.
 597         * tui/tui-source.h (tui_set_source_content)
 598         (tui_show_symtab_source): Add "win_info" parameter.
 599         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 600         parameter.
 601         (tui_show_symtab_source): Likewise.
 602
 603 2019-07-17  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-wingeneral.c
 606         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 607
 608 2019-07-17  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 611         (struct tui_cmd_window) <can_scroll>: New method.
 612         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 613         method.
 614
 615 2019-07-17  Tom Tromey  <tromey@adacore.com>
 616
 617         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 618         do_field_signed>: Rename.  Change type of "value".
 619         * ui-out.c (ui_out::field_signed): Rename from field_int.
 620         Change type of "value".
 621         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 622         type of "value".
 623         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 624         do_field_int.  Change type of "value".
 625         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 626         do_field_int.  Change type of "value".
 627         * tracepoint.c (trace_status_mi, tfind_1)
 628         (print_one_static_tracepoint_marker): Update.
 629         * thread.c (print_thread_info_1, print_selected_thread_frame):
 630         Update.
 631         * stack.c (print_frame, print_frame_info): Update.
 632         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 633         Update.
 634         * source.c (print_source_lines_base): Update.
 635         * skip.c (info_skip_command): Update.
 636         * record-btrace.c (btrace_ui_out_decode_error)
 637         (btrace_call_history_src_line): Update.
 638         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 639         Update.
 640         * progspace.c (print_program_space): Update.
 641         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 642         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 643         do_field_int.  Change type of "value".
 644         * mi/mi-out.c (mi_ui_out::do_table_begin)
 645         (mi_ui_out::do_table_header): Update.
 646         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 647         type of "value".
 648         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 649         (mi_cmd_data_list_changed_registers, output_register)
 650         (mi_cmd_data_read_memory, mi_load_progress)
 651         (mi_cmd_trace_frame_collected): Update.
 652         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 653         Update.
 654         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 655         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 656         (mi_cmd_var_list_children, varobj_update_one): Update.
 657         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 658         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 659         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 660         * inferior.c (print_inferior): Update.
 661         * gdb_bfd.c (print_one_bfd): Update.
 662         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 663         Update.
 664         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 665         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 666         do_field_int.  Change type of "value".
 667         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 668         do_field_int.  Change type of "value".
 669         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 670         (print_one_breakpoint_location, print_it_catch_fork)
 671         (print_one_catch_fork, print_it_catch_vfork)
 672         (print_one_catch_vfork, print_it_catch_solib)
 673         (print_it_catch_exec, print_it_ranged_breakpoint)
 674         (print_mention_watchpoint, print_mention_masked_watchpoint)
 675         (bkpt_print_it, update_static_tracepoint): Update.
 676         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 677         * break-catch-syscall.c (print_it_catch_syscall): Update.
 678         * ada-tasks.c (print_ada_task_info): Update.
 679         * ada-lang.c (print_it_exception, print_mention_exception):
 680         Update.
 681
 682 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 683
 684         PR breakpoints/24541
 685         * gdbarch.c: Regenerate.
 686         * gdbarch.h: Regenerate.
 687         * gdbarch.sh: Adjust return type and parameter types for
 688         'stap_adjust_register'.
 689         (i386_stap_adjust_register): Adjust signature and return new
 690         register name.
 691         * stap-probe.c (stap_parse_register_operand): Adjust use of
 692         'gdbarch_stap_adjust_register'.
 693
 694 2019-07-17  Tom Tromey  <tromey@adacore.com>
 695
 696         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 697         declare VEC.
 698         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 699         std::vector.
 700         (struct s390_process_info): Add initializers.
 701         (s390_add_process): Use new.
 702         (s390_linux_nat_target::low_forget_process): Use delete.
 703         (s390_linux_nat_target::low_new_fork)
 704         (s390_linux_nat_target::stopped_by_watchpoint)
 705         (s390_linux_nat_target::low_prepare_to_resume)
 706         (s390_linux_nat_target::insert_watchpoint)
 707         (s390_linux_nat_target::insert_hw_breakpoint)
 708         (s390_linux_nat_target::remove_watchpoint)
 709         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 710
 711 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 712
 713         * aarch64-fbsd-nat.c: Include regcache.h.
 714         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 715         argument.
 716         (aarch64_fbsd_nat_target::fetch_registers)
 717         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 718         variable.
 719         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 720
 721 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 722
 723         * fbsd-nat.c: Include gdbarch.h.
 724
 725 2019-07-15  Tom Tromey  <tromey@adacore.com>
 726
 727         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 728
 729 2019-07-15  Tom Tromey  <tromey@adacore.com>
 730
 731         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 732         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 733         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 734         * cli-out.c (cli_ui_out::do_field_int): New method.
 735         * ui-out.c (ui_out::field_unsigned): New method.
 736         * symfile.c (generic_load): Use field_unsigned.
 737         (print_transfer_performance): Likewise.
 738         * record-btrace.c (ui_out_field_uint): Remove.
 739         (btrace_call_history_insn_range, btrace_call_history): Use
 740         field_unsigned.
 741         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 742         field_unsigned.
 743         * ui-out.h (class ui_out) <field_unsigned>: New method.
 744         <do_field_unsigned>: Likewise.
 745
 746 2019-07-15  Tom Tromey  <tromey@adacore.com>
 747
 748         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 749         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 750         * target.c (flash_erase_command): Use field_string.
 751         * infrun.c (print_signal_received_reason): Use field_string.
 752         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 753         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 754         field_string.
 755         * ada-tasks.c (print_ada_task_info): Use field_string.
 756
 757 2019-07-15  Tom Tromey  <tromey@adacore.com>
 758
 759         * target.c (flash_erase_command): Use field_core_addr.
 760         * symfile.c (generic_load): Use field_core_addr.
 761         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 762         Use field_core_addr.
 763         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 764         field_core_addr.
 765
 766 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 767
 768         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 769         value if its desired type is smaller than a CORE_ADDR and signed.
 770
 771 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 772
 773         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 774         of changes to field names, and use new is_reference field to
 775         decide if a property is a reference or not.
 776         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 777         field.
 778         (struct dwarf2_property_baton): Update header comment, rename
 779         'referenced_type' to 'property_type' and update comments.
 780         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 781         default property type, store in property baton, update to take
 782         accound of renamed field.
 783         (read_func_scope): Update call to attr_to_dynamic_prop.
 784         (read_array_type): Likewise.
 785         (dwarf2_per_cu_addr_sized_int_type): New function.
 786         (read_subrange_index_type): Move type finding code to
 787         dwarf2_per_cu_addr_sized_int_type.
 788         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 789         (dwarf2_per_cu_addr_type): New function.
 790         (set_die_type): Update calls to attr_to_dynamic_prop.
 791
 792 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 793
 794         * dwarf2read.c (read_subrange_index_type): New function.
 795         (read_subrange_type): Move code into new function and call it.
 796         * gdbtypes.c (create_range_type): Add some asserts.
 797
 798 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 801         update return statements.
 802         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 803         declaration, and update comment to match.
 804         * gdbtypes.c (resolve_dynamic_array): Update call to
 805         dwarf2_evaluate_property to match new return type.
 806
 807 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 808
 809         * valarith.c (value_subscripted_rvalue): Change lowerbound
 810         parameter type from int to LONGEST.
 811         * value.h (value_subscripted_rvalue): Likewise in declaration.
 812
 813 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 814
 815         * cli/cli-utils.c (info_print_command_completer): New function.
 816         * cli/cli-utils.h: Add 'completer.h' include, and forward
 817         declaration for 'struct cmd_list_element'.
 818         (info_print_command_completer): Declare.
 819         * stack.c (_initialize_stack): Add completer for 'info locals' and
 820         'info args'.
 821         * symtab.c (_initialize_symtab): Add completer for 'info
 822         variables' and 'info functions'.
 823         * NEWS: Mention completion for additional info commands.
 824
 825 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 826
 827         * cli/cli-utils.c (extract_info_print_args): Delete.
 828         (extract_arg_maybe_quoted): Delete.
 829         (info_print_options_defs): New variable.
 830         (make_info_print_options_def_group): New function.
 831         (extract_info_print_options): Define new function.
 832         * cli/cli-utils.h (extract_info_print_args): Delete.
 833         (struct info_print_options): New structure.
 834         (extract_info_print_options): Declare new function.
 835         * stack.c (info_locals_command): Update to use new
 836         extract_info_print_options, also add a header comment.
 837         (info_args_command): Likewise.
 838         * symtab.c (info_variables_command): Likewise.
 839         (info_functions_command): Likewise.
 840
 841 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 842
 843         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 844         to extract string arguments.
 845         * common/common-utils.c (extract_string_maybe_quoted): New function.
 846         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 847
 848 2019-07-11  Tom Tromey  <tromey@adacore.com>
 849
 850         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 851         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 852         * top.h (gdbinit): Don't declare.
 853         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 854         into...
 855         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 856         * top.c (gdb_init): Don't call init_cli_cmds.
 857         (gdbinit): Remove.
 858         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 859
 860 2019-07-11  Tom Tromey  <tromey@adacore.com>
 861
 862         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 863         after it has been moved.
 864
 865 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 866
 867         * valops.c (value_must_coerce_to_target): Change return type to
 868         bool.
 869         * value.h (value_must_coerce_to_target): Likewise.
 870
 871 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 872
 873         * breakpoint.c (is_hardware_watchpoint): Remove
 874         forward-declaration.
 875         (is_masked_watchpoint): Change return type to bool.
 876         (is_tracepoint): Likewise.
 877         (is_breakpoint): Likewise.
 878         (is_hardware_watchpoint): Likewise.
 879         (is_watchpoint): Likewise.
 880         (is_no_memory_software_watchpoint): Likewise.
 881         (is_catchpoint): Likewise.
 882         (breakpoint_1): Make FILTER parameter's return type bool.
 883         is_masked_watchpoint): Change return type to bool.
 884         (save_breakpoints): Make FILTER parameter's return type bool.
 885         * breakpoint.h (is_breakpoint): Change return type to bool.
 886         (is_watchpoint): Likewise.
 887         (is_catchpoint): Likewise.
 888         (is_tracepoint): Likewise.
 889
 890 2019-07-10  Tom Tromey  <tom@tromey.com>
 891
 892         * defs.h: Don't include gdbarch.h.
 893         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 894         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 895         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 896         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 897         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 898         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 899         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 900         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 901         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 902         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 903         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 904         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 905         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 906         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 907         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 908         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 909         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 910         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 911         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 912         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 913         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 914         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 915         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 916         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 917         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 918         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 919         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 920
 921 2019-07-10  Tom Tromey  <tromey@adacore.com>
 922
 923         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 924         * breakpoint.c (init_ada_exception_breakpoint): Register as
 925         bp_catchpoint.
 926         (print_one_breakpoint_location, print_one_breakpoint): Use
 927         is_ada_exception_catchpoint.
 928         * ada-lang.c (class ada_catchpoint_location): Pass
 929         bp_loc_software_breakpoint to bp_location constructor.
 930         (is_ada_exception_catchpoint): New function.
 931
 932 2019-07-10  Tom Tromey  <tromey@adacore.com>
 933
 934         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 935         VEC.
 936         (struct arm_exidx_entry): New method operator<.
 937         (struct arm_exidx_data) <section_maps>: Change type.
 938         (arm_exidx_data_free): Remove.
 939         (arm_exidx_data_key): Change type.  Move lower.
 940         (arm_exidx_new_objfile): Update.
 941         (arm_compare_exidx_entries): Remove.
 942         (arm_find_exidx_entry, _initialize_arm_tdep)
 943
 944 2019-07-10  Tom Tromey  <tromey@adacore.com>
 945
 946         * solib-spu.c (ocl_program_data_key): Change type.
 947         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 948         Update.
 949
 950 2019-07-10  Tom Tromey  <tromey@adacore.com>
 951
 952         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 953         (struct solib_aix_inferior_data) <library_list>: Change type.
 954         (solib_aix_inferior_data_handle): Change type.
 955         (get_solib_aix_inferior_data): Update.
 956         (solib_aix_free_library_list): Remove.
 957         (library_list_start_library): Update.
 958         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 959         return type.
 960         (solib_aix_get_library_list)
 961         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 962         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 963
 964 2019-07-10  Tom Tromey  <tromey@adacore.com>
 965
 966         * solib-dsbt.c (struct dsbt_info): Add initializers.
 967         (solib_dsbt_pspace_data): Change type.
 968         (dsbt_pspace_data_cleanup): Remove.
 969         (get_dsbt_info, _initialize_dsbt_solib): Update.
 970
 971 2019-07-10  Tom Tromey  <tromey@adacore.com>
 972
 973         * spu-tdep.c (spu_overlay_data): Change type.
 974         (spu_get_overlay_table, spu_overlay_new_objfile)
 975         (_initialize_spu_tdep): Update.
 976
 977 2019-07-10  Tom Tromey  <tromey@adacore.com>
 978
 979         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 980         destructor.
 981         (dbx_objfile_data_key): Change type and declare later.
 982         (DBX_SYMFILE_INFO): Rewrite.
 983         * dbxread.c (dbx_objfile_data_key): Change type.
 984         (dbx_symfile_init): Update.
 985         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 986         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 987         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 988
 989 2019-07-10  Tom Tromey  <tromey@adacore.com>
 990
 991         * jit.c (jit_program_space_key): Change type.  Move lower.
 992         (get_jit_program_space_data): Update.
 993         (jit_program_space_data_cleanup): Remove.
 994         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 995         Update.
 996         (struct jit_program_space_data): Add initializers.
 997
 998 2019-07-10  Tom Tromey  <tromey@adacore.com>
 999
1000         * solib-darwin.c (struct darwin_info): Add initializers.
1001         (solib_darwin_pspace_data): Change type.
1002         (darwin_pspace_data_cleanup): Remove.
1003         (get_darwin_info, _initialize_darwin_solib): Update.
1004
1005 2019-07-10  Tom Tromey  <tromey@adacore.com>
1006
1007         * remote-sim.c (struct sim_inferior_data): Add initializers,
1008         constructor, and destructor.
1009         (sim_inferior_data_key): Change type.  Move lower.
1010         (check_for_duplicate_sim_descriptor): Update.
1011         (get_sim_inferior_data): Use new.  Update.
1012         (~sim_inferior_data_cleanup): Rename from
1013         sim_inferior_data_cleanup.  Simplify.
1014         (gdbsim_close_inferior, simulator_command)
1015         (sim_command_completer, _initialize_remote_sim): Update.
1016         (next_pid, INITIAL_PID): Move earlier.
1017
1018 2019-07-10  Tom Tromey  <tromey@adacore.com>
1019
1020         * python/python-internal.h (create_thread_object): Return
1021         gdbpy_ref.
1022         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1023         * python/py-inferior.c (struct threadlist_entry): Add
1024         constructor.
1025         <thread_obj>: Now a gdbpy_ref.
1026         (thread_to_thread_object): Update.
1027         (add_thread_object): Use new.
1028         (delete_thread_object): Use delete.
1029         (infpy_threads): Update.
1030         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1031         GIL.
1032
1033 2019-07-10  Tom Tromey  <tromey@adacore.com>
1034
1035         * valops.c (value_cast): Specialize error message for Ada.
1036
1037 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1038
1039         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1040
1041 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1042
1043         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1044         bpstat_should_step): Return bool, adjust comments.
1045         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1046         bpstat_should_step): Likewise.
1047
1048 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1049
1050         * features/Makefile: Use feature target descriptions for Arm.
1051         * features/arm/arm-core.c: Generate new file.
1052         * features/arm/arm-fpa.c: Likewise.
1053         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1054         * features/arm/arm-m-profile.c: Likewise.
1055         * features/arm/arm-vfpv2.c: Likewise.
1056         * features/arm/arm-vfpv3.c: Likewise.
1057         * features/arm/xscale-iwmmxt.c: Likewise.
1058         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1059
1060 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1061
1062         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1063         ptrace earlier.
1064
1065 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1066
1067         * features/aarch64-pauth.c: Regenerate.
1068
1069 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1070
1071         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1072         bool.
1073         (bpstat_what): Use false instead of 0.
1074
1075 2019-07-09  Pedro Alves  <palves@redhat.com>
1076
1077         * break-catch-throw.c (is_exception_catchpoint): New.
1078         * breakpoint.c (print_one_breakpoint_location): New parameter
1079         'raw_loc'.  Handle it.  Use
1080         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1081         looking at the breakpoint's type.
1082         (print_one_breakpoint): If handling "maint info breakpoints", also
1083         print locations of exception catchpoints.
1084         * breakpoint.h (is_exception_catchpoint): Declare.
1085
1086 2019-07-09  Pedro Alves  <palves@redhat.com>
1087
1088         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1089         "addr" field.
1090         (allocate_location_exception_catchpoint): New.
1091         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1092         (initialize_throw_catchpoint_ops): Install
1093         allocate_location_exception_catchpoint as allocate_location
1094         method.
1095         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1096         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1097         bp_loc_other.
1098         (breakpoint_address_is_meaningful): Delete.
1099         (bl_address_is_meaningful): New.
1100         (breakpoint_locations_match): Adjust comment.
1101         (bp_location_from_bp_type): New, factored out of...
1102         (bp_location::bp_location(breakpoint *)): ... this.
1103         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1104         factored out of...
1105         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1106         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1107         breakpoint_address_is_meaningful.
1108         (bp_locations_compare): Adjust comment.
1109         (update_global_location_list): Use bl_address_is_meaningful
1110         instead of breakpoint_address_is_meaningful.
1111         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1112         explicit.
1113         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1114         * python/py-breakpoint.c (bppy_get_location): No longer check
1115         whether location is null.
1116
1117 2019-07-09  Pedro Alves  <palves@redhat.com>
1118
1119         PR c++/15468
1120         * breakpoint.c (print_one_breakpoint_location): Remove
1121         single-location assert.
1122
1123 2019-07-09  Tom Tromey  <tom@tromey.com>
1124
1125         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1126         * configure: Rebuild.
1127         * configure.ac: Change common to gdbsupport.
1128         * gdbsupport: Rename from common.
1129         * acinclude.m4: Change common to gdbsupport.
1130         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1131         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1132         gdbsupport.
1133         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1134         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1135         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1136         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1137         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1138         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1139         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1140         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1141         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1142         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1143         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1144         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1145         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1146         coff-pe-read.c, command.h, compile/compile-c-support.c,
1147         compile/compile-c.h, compile/compile-cplus-symbols.c,
1148         compile/compile-cplus-types.c, compile/compile-cplus.h,
1149         compile/compile-loc2c.c, compile/compile.c, completer.c,
1150         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1151         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1152         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1153         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1154         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1155         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1156         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1157         features/aarch64-core.c, features/aarch64-fpu.c,
1158         features/aarch64-pauth.c, features/aarch64-sve.c,
1159         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1160         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1161         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1162         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1163         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1164         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1165         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1166         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1167         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1168         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1169         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1170         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1171         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1172         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1173         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1174         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1175         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1176         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1177         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1178         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1179         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1180         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1181         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1182         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1183         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1184         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1185         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1186         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1187         minsyms.c, mips-linux-tdep.c, namespace.h,
1188         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1189         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1190         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1191         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1192         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1193         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1194         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1195         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1196         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1197         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1198         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1199         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1200         procfs.c, producer.c, progspace.h, psymtab.h,
1201         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1202         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1203         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1204         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1205         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1206         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1207         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1208         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1209         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1210         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1211         target-memory.c, target.c, target.h, target/waitstatus.c,
1212         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1213         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1214         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1215         unittests/array-view-selftests.c,
1216         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1217         unittests/common-utils-selftests.c,
1218         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1219         unittests/format_pieces-selftests.c,
1220         unittests/function-view-selftests.c,
1221         unittests/lookup_name_info-selftests.c,
1222         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1223         unittests/mkdir-recursive-selftests.c,
1224         unittests/observable-selftests.c,
1225         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1226         unittests/parse-connection-spec-selftests.c,
1227         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1228         unittests/scoped_fd-selftests.c,
1229         unittests/scoped_mmap-selftests.c,
1230         unittests/scoped_restore-selftests.c,
1231         unittests/string_view-selftests.c, unittests/style-selftests.c,
1232         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1233         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1234         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1235         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1236         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1237         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1238
1239 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1242         bool value.
1243         (decode_digits_ordinary): Set explicit_line field in sal.
1244         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1245         symtab_and_line that was set on an explicit line number in
1246         assembler code.  Do always update the recorded symtab and line if
1247         we do skip the prologue.
1248
1249 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1250
1251         * breakpoint.c (set_breakpoint_location_function): Remove
1252         explicit_loc parameter.
1253         (momentary_breakpoint_from_master): Update call to
1254         set_breakpoint_location_function.
1255         (add_location_to_breakpoint): Likewise.
1256
1257 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1260         required features based on default bfd type when no specific bfd
1261         is present.
1262
1263 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1264
1265         * NEWS: Mention that GDB printf and eval commands can now print
1266         C-style and Ada-style convenience var strings without
1267         calling the inferior.
1268         * printcmd.c (printf_c_string): Locally print GDB internal var
1269         instead of transiting via the inferior.
1270         (printf_wide_c_string): Likewise.
1271
1272 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1273
1274         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1275
1276 2019-07-04  Tom Tromey  <tom@tromey.com>
1277
1278         PR tui/24724:
1279         * tui/tui-winsource.c (tui_clear_source_content): Update.
1280         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1281         (tui_update_breakpoint_info): Update.
1282         (tui_set_exec_info_content): Update.
1283         * tui/tui-source.c (tui_set_source_content_nil): Update.
1284         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1285         has_break.
1286         * tui/tui-data.h (enum tui_bp_flag): New.
1287         (tui_bp_flags): New enum flags type.
1288         (struct tui_source_element) <break_mode>: Change type.  Rename
1289         from has_break.
1290         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1291         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1292         constants.
1293         * tui/tui-winsource.h: Fix comment.
1294
1295 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1296
1297         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1298         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1299         (store_fpregs_to_thread)
1300         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1301         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1302         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1303         (IWMMXT_REGS_SIZE): Add define.
1304         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1305         (fetch_vfp_regs, store_vfp_regs)
1306         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1307         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1308
1309 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1310
1311         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1312         defines.
1313         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1314         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1315         (ARM_INT_REGISTER_SIZE): ...to this.
1316         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1317         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1318         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1319         (arm_linux_collect_gregset, supply_nwfpe_register)
1320         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1321         defines.
1322         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1323         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1324         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1325         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1326         (arm_return_in_memory, arm_store_return_value)
1327         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1328         (arm_record_ld_st_multiple): Likewise.
1329         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1330         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1331
1332 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1333
1334         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1335         AARCH64_DISPLACED_MODIFIED_INSNS.
1336         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1337         (aarch64_displaced_step_copy_insn): Likewise.
1338         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1339         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1340         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1341         ARM_DISPLACED_MODIFIED_INSNS.
1342         * arm-tdep.c (arm_gdbarch_init): Likewise.
1343         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1344         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1345         (struct arm_displaced_step_closure): Use
1346         ARM_DISPLACED_MODIFIED_INSNS.
1347
1348 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1349
1350         * features/Makefile: Remove unused xml files.
1351         * features/aarch64.xml: Remove.
1352         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1353         * features/i386/amd64-avx-avx512.xml: Remove.
1354         * features/i386/amd64-avx-linux.xml: Remove.
1355         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1356         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1357         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1358         * features/i386/amd64-avx-mpx.xml: Remove.
1359         * features/i386/amd64-avx.xml: Remove.
1360         * features/i386/amd64-linux.xml: Remove.
1361         * features/i386/amd64-mpx-linux.xml: Remove.
1362         * features/i386/amd64-mpx.xml: Remove.
1363         * features/i386/amd64.xml: Remove.
1364         * features/i386/i386-avx-avx512-linux.xml: Remove.
1365         * features/i386/i386-avx-avx512.xml: Remove.
1366         * features/i386/i386-avx-linux.xml: Remove.
1367         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1368         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1369         * features/i386/i386-avx-mpx-linux.xml: Remove.
1370         * features/i386/i386-avx-mpx.xml: Remove.
1371         * features/i386/i386-avx.xml: Remove.
1372         * features/i386/i386-linux.xml: Remove.
1373         * features/i386/i386-mmx-linux.xml: Remove.
1374         * features/i386/i386-mmx.xml: Remove.
1375         * features/i386/i386-mpx-linux.xml: Remove.
1376         * features/i386/i386-mpx.xml: Remove.
1377         * features/i386/i386.xml: Remove.
1378         * features/i386/x32-avx-avx512-linux.xml: Remove.
1379         * features/i386/x32-avx-linux.xml: Remove.
1380         * features/i386/x32-linux.xml: Remove.
1381
1382 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1383
1384         * regformats/aarch64.dat: Remove.
1385         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1386         * regformats/i386/amd64-avx-linux.dat: Remove.
1387         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1388         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1389         * regformats/i386/amd64-linux.dat: Remove.
1390         * regformats/i386/amd64-mpx-linux.dat: Remove.
1391         * regformats/i386/amd64.dat: Remove.
1392         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1393         * regformats/i386/i386-avx-linux.dat: Remove.
1394         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1395         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1396         * regformats/i386/i386-linux.dat: Remove.
1397         * regformats/i386/i386-mmx-linux.dat: Remove.
1398         * regformats/i386/i386-mpx-linux.dat: Remove.
1399         * regformats/i386/i386.dat: Remove.
1400         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1401         * regformats/i386/x32-avx-linux.dat: Remove.
1402         * regformats/i386/x32-linux.dat: Remove.
1403
1404 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1405
1406         * aarch64-tdep.c: Remove xml self tests.
1407         * amd64-linux-tdep.c: Likewise.
1408         * amd64-tdep.c: Likewise.
1409         * i386-linux-tdep.c: Likewise.
1410         * i386-tdep.c: Likewise.
1411
1412 2019-07-03  Pedro Alves  <palves@redhat.com>
1413
1414         PR cli/24732
1415         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1416         (pipe_cmd_option_defs): New.
1417         (make_pipe_cmd_options_def_group): New.
1418         (pipe_command): Use gdb::option::process_options.
1419         (pipe_command_completer): New function.
1420         (_initialize_cli_cmds): Install completer for "pipe" command.
1421
1422 2019-07-03  Pedro Alves  <palves@redhat.com>
1423
1424         * cli/cli-option.c (union option_value) <string>: New field.
1425         (struct option_def_and_value): Add ctor, move ctor, dtor and
1426         use DISABLE_COPY_AND_ASSIGN.
1427         (option_def_and_value::clear_value): New.
1428         (parse_option, save_option_value_in_ctx, get_val_type_str)
1429         (add_setshow_cmds_for_options): Handle var_string.
1430         * cli-option.h (union option_def::var_address) <string>: New
1431         field.
1432         (struct string_option_def): New.
1433         * maint-test-options.c (struct test_options_opts): Add default
1434         ctor and use DISABLE_COPY_AND_ASSIGN.
1435         <string_opt>: New field.
1436         (test_options_opts::~test_options_opts): New.
1437         (test_options_opts::dump): Also dump "-string".
1438         (test_options_option_defs): Install "string.
1439
1440 2019-07-03  Pedro Alves  <palves@redhat.com>
1441
1442         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1443         option_value with a null enumeration.
1444         (complete_options): Save the option values in the context.
1445         (save_option_value_in_ctx): New, factored out from ...
1446         (process_options): ... here.
1447         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1448         of the function.
1449         * maint-test-options.c (test_options_opts::dump): New, factored
1450         out from ...
1451         (maintenance_test_options_command_mode): ... here.
1452         (maintenance_test_options_command_completion_result): Delete.
1453         (maintenance_test_options_command_completion_text): Update
1454         comment.
1455         (maintenance_show_test_options_completion_result): Change
1456         prototype.  Just print
1457         maintenance_test_options_command_completion_text.
1458         (save_completion_result): New.
1459         (maintenance_test_options_completer_mode): Pass options context to
1460         complete_options, and then save a dump.
1461         (_initialize_maint_test_options): Use add_cmd to install "maint
1462         show test-options-completion-result".
1463
1464 2019-07-03  Pedro Alves  <palves@redhat.com>
1465
1466         * NEWS (New commands): Mention "with" and "maint with".
1467         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1468         (with_command, with_command_completer): New.
1469         (pipe_command): Adjust to new repeat_previous
1470         interface.
1471         (_initialize_cli_cmds): Install the "with" command and its "w"
1472         alias.
1473         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1474         declarations.
1475         * cli/cli-setshow.c (parse_cli_var_uinteger)
1476         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1477         argument strings for all var_types.
1478         (get_setshow_command_value_string): New, factored out from ...
1479         (do_show_command): ... this.
1480         * cli/cli-setshow.h: Include <string>.
1481         (get_setshow_command_value_string): Declare.
1482         * command.h (repeat_previous): Now returns const char *.  Adjust
1483         comment.
1484         * maint.c: Include "cli/cli-cmds.h".
1485         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1486         (_initialize_maint_cmds): Register the "maintenance with" command.
1487         * top.c (repeat_previous): Move bits from pipe_command here:
1488         Return the saved command line, if any; error out if there's no
1489         command to relaunch.
1490
1491 2019-07-03  Pedro Alves  <palves@redhat.com>
1492
1493         * NEWS (New commands): Mention "maint set/show test-settings"
1494         instead of "maint test-settings".
1495         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1496         (maintenance_test_settings_set_list): Rename to ...
1497         (maintenance_set_test_settings_list): ... this.
1498         (maintenance_test_settings_show_list): Rename to  ...
1499         (maintenance_show_test_settings_list): ... this.
1500         (maintenance_test_settings_cmd): Delete.
1501         (maintenance_test_settings_set_cmd): ...
1502         (maintenance_set_test_settings_cmd): ... this.
1503         (maintenance_test_settings_show_cmd): ...
1504         (maintenance_show_test_settings_cmd): ... this.
1505         (maintenance_test_settings_show_value_cmd):
1506         (maintenance_show_test_settings_value_cmd): ... this.
1507         (_initialize_maint_test_settings): No longer install the "maint
1508         test-settings" prefix command.  Rename "maint test-settings set"
1509         to "maint set test-settings", and "maint test-settings show" to
1510         "maint show test-settings".  Adjust all subcommands.
1511
1512 2019-07-03  Pedro Alves  <palves@redhat.com>
1513
1514         * maint-test-settings.c: Fix file's intro comment.  Replace all
1515         references to "test-options" with references to "test-settings",
1516         in comments.
1517
1518 2019-07-03  Pedro Alves  <palves@redhat.com>
1519
1520         * maint-test-settings.c (maintenance_test_settings_xxx)
1521         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1522         New.
1523         (maintenance_test_settings_enums): Use them.
1524         (maintenance_test_settings_enum): Default to
1525         maintenance_test_settings_xxx.
1526         (_initialize_maint_test_settings): Initialize
1527         MAINTENANCE_TEST_SETTINGS_FILENAME.
1528
1529 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1530
1531         * breakpoint.h (remove_breakpoints_inf): Change return type to
1532         void, move function documentation here.
1533         * breakpoint.c (remove_breakpoints_inf): Change return type to
1534         void, move function documentation to header.
1535
1536 2019-07-02  Pedro Alves  <palves@redhat.com>
1537
1538         * NEWS (Completion improvements): Mention "info threads".
1539         * thread.c (struct info_threads_opts, info_threads_option_defs)
1540         (make_info_threads_options_def_group): New.
1541         (info_threads_command): Use gdb::option::process_options.
1542         (info_threads_command_completer): New.
1543         (_initialize_thread): Use gdb::option::build_help to build the
1544         help text for "info threads".
1545
1546 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1547
1548         * defs.h (generic_load): Move from here...
1549         * symfile.h (generic_load): ... to here.  Rename name parameter
1550         to args.
1551         * symfile.c (generic_load): Add comment.
1552
1553 2019-07-01  Tom Tromey  <tromey@adacore.com>
1554
1555         * dwarf2read.c
1556         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1557         declaration of without_params.  Fix formatting.
1558
1559 2019-07-01  Tom Tromey  <tromey@adacore.com>
1560
1561         * ada-exp.y (find_primitive_type): Update.
1562         * ada-lang.h (ada_lookup_symbol): Update.
1563         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1564         parameter.
1565         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1566
1567 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1568
1569         PR breakpoints/24541
1570         * gdbarch.c: Regenerate.
1571         * gdbarch.h: Regenerate.
1572         * gdbarch.sh: Add 'stap_adjust_register'.
1573         * i386-tdep.c: Include '<unordered_set>'.
1574         (i386_stap_adjust_register): New function.
1575         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1576         * stap-probe.c (stap_parse_register_operand): Call
1577         'gdbarch_stap_adjust_register'.
1578
1579 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1580
1581         PR python/24742
1582         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1583         * python/python.c (do_start_initialization): Use 'xmalloc'
1584         instead of 'PyMem_Malloc'.
1585
1586 2019-06-28  Tom Tromey  <tromey@adacore.com>
1587
1588         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1589         for Ada.
1590
1591 2019-06-27  Tom Tromey  <tromey@adacore.com>
1592
1593         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1594         objfile_key.
1595         (arm_find_mapping_symbol, arm_record_special_symbol)
1596         (_initialize_arm_tdep): Update.
1597         (arm_objfile_data_free): Remove.
1598
1599 2019-06-27  Tom Tromey  <tromey@adacore.com>
1600
1601         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1602         to cp_print_static_field.
1603
1604 2019-06-26  Tom Tromey  <tromey@adacore.com>
1605
1606         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1607         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1608         declare.
1609
1610 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1611
1612         * features/aarch64-core.c (create_feature_aarch64_core):
1613         Regenerate.
1614         * features/aarch64-core.xml: Add cpsr flags.
1615
1616 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1617
1618         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1619         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1620
1621 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1622
1623         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1624         field.
1625         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1626         use.
1627         (arm_record_special_symbol): Don't insert new symbol in sorted
1628         position, push it at the end.
1629
1630 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1631
1632         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1633         (arm_mapping_symbol_s): Remove.
1634         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1635         (arm_mapping_symbol_vec): New typedef.
1636         (struct arm_per_objfile): Add constructor.
1637         <section_maps>: Change type to
1638         std::unique_ptr<arm_mapping_symbol_vec[]>.
1639         (arm_compare_mapping_symbols): Remove.
1640         (arm_find_mapping_symbol): Adjust to section_maps type change.
1641         (arm_objfile_data_free): Call delete on arm_per_objfile.
1642         (arm_record_special_symbol): Adjust to section_maps type change.
1643         Allocate arm_per_objfile with new.
1644
1645 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1646
1647         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1648         with the command prefix.
1649
1650 2019-06-25  Tom Tromey  <tom@tromey.com>
1651
1652         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1653         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1654
1655 2019-06-25  Tom Tromey  <tom@tromey.com>
1656
1657         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1658         type.
1659         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1660         protected.
1661
1662 2019-06-25  Tom Tromey  <tom@tromey.com>
1663
1664         * tui/tui-winsource.c
1665         (tui_source_window_base::set_is_exec_point_at): Add check against
1666         LOA_ADDRESS.
1667
1668 2019-06-25  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-source.c (tui_set_source_content): Don't check before
1671         xfree.
1672         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1673
1674 2019-06-25  Tom Tromey  <tom@tromey.com>
1675
1676         * tui/tui-winsource.h (tui_update_source_window_as_is)
1677         (tui_alloc_source_buffer, tui_line_is_displayed)
1678         (tui_addr_is_displayed): Change type of win_info.
1679         * tui/tui-winsource.c (tui_update_source_window_as_is)
1680         (tui_clear_source_content, tui_show_source_line)
1681         (tui_show_source_content, tui_source_window_base::refill)
1682         (tui_source_window_base::set_is_exec_point_at)
1683         (tui_source_window_base::set_is_exec_point_at)
1684         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1685         (tui_alloc_source_buffer, tui_line_is_displayed)
1686         (tui_addr_is_displayed): Change type of win_info.  Update.
1687         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1688         (tui_source_window_base::do_make_visible_with_new_height):
1689         Update.
1690         * tui/tui-source.c (tui_set_source_content)
1691         (tui_set_source_content_nil)
1692         (tui_source_window::do_scroll_vertical): Update.
1693         * tui/tui-layout.c (show_layout): Update.
1694         * tui/tui-disasm.c (tui_set_disassem_content)
1695         (tui_disasm_window::do_scroll_vertical): Update.
1696         * tui/tui-data.h (tui_win_content): Remove.
1697         (struct tui_gen_win_info) <content, content_size>: Remove.
1698         (struct tui_source_element): Add initializers and destructor.
1699         (union tui_which_element, struct tui_win_element): Remove.
1700         (struct tui_source_window_base) <content>: New field.
1701         (struct tui_data_window): Remove destructor.
1702         (tui_alloc_content, tui_free_win_content)
1703         (tui_free_all_source_wins_content): Don't declare.
1704         * tui/tui-data.c (tui_initialize_static_data): Update.
1705         (init_content_element, tui_alloc_content): Remove.
1706         (~tui_gen_win_info): Update.
1707         (~tui_data_window, tui_free_all_source_wins_content)
1708         (tui_free_win_content, free_content, free_content_elements):
1709         Remove.
1710
1711 2019-06-25  Tom Tromey  <tom@tromey.com>
1712
1713         * tui/tui-winsource.h (tui_clear_source_content)
1714         (tui_erase_source_content, tui_show_source_content): Change type
1715         of win_info.
1716         * tui/tui-winsource.c (tui_clear_source_content)
1717         (tui_erase_source_content, tui_show_source_content): Change type
1718         of win_info.
1719         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1720         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1721         win_info.
1722         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1723         win_info.
1724         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1725
1726 2019-06-25  Tom Tromey  <tom@tromey.com>
1727
1728         * tui/tui-winsource.c (tui_clear_source_content)
1729         (tui_source_window_base::set_is_exec_point_at): Update.
1730         * tui/tui-source.c (tui_set_source_content_nil): Update.
1731         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1732         a bool.
1733         * tui/tui-data.c (init_content_element): Update.
1734
1735 2019-06-25  Tom Tromey  <tom@tromey.com>
1736
1737         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1738         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1739         * tui/tui-layout.c (init_and_make_win): Update.
1740         * tui/tui.h (enum tui_win_type): Update.
1741         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1742         tui_win_is_auxillary.
1743         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1744         tui_win_is_auxillary.
1745
1746 2019-06-25  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1749         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1750         (tui_delete_data_content_windows, tui_display_all_data)
1751         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1752         Update.
1753         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1754         * tui/tui-regs.c (tui_last_regs_line_no)
1755         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1756         (tui_show_registers): Update.
1757         (tui_show_register_group): Return void.  Update.
1758         (tui_display_registers_from, tui_display_reg_element_at_line)
1759         (tui_display_registers_from_line, tui_check_register_values):
1760         Update.
1761         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1762         member.
1763         (struct tui_data_window) <regs_content>: Now a std::vector.
1764         <regs_content_count>: Remove.
1765         (tui_add_content_elements, tui_free_data_content): Don't declare.
1766         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1767         (init_content_element): Remove DATA_WIN case.  Add assert.
1768         (tui_add_content_elements): Remove.
1769         (tui_data_window): Update.
1770         (tui_free_data_content): Remove.
1771         (free_content_elements): Remove DATA_WIN case.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-data.c (tui_data_item_window): Update.
1776         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1777         * tui/tui-windata.c (tui_display_all_data)
1778         (tui_display_data_from_line): Update.
1779         (tui_check_data_values): Remove.
1780         * tui/tui-regs.c (tui_show_register_group)
1781         (tui_display_reg_element_at_line): Update.
1782         * tui/tui-hooks.c (tui_register_changed)
1783         (tui_refresh_frame_and_register_information): Call
1784         tui_check_register_values.
1785         * tui/tui-data.h (struct tui_data_window) <data_content,
1786         data_content_count, data_type>: Remove.
1787         (enum tui_data_type): Remove.
1788
1789         * tui/tui-data.c (tui_data_window::clear_detail)
1790         (~tui_data_window): Update.
1791
1792 2019-06-25  Tom Tromey  <tom@tromey.com>
1793
1794         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1795         declare.
1796         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1797         Rename from tui_first_data_item_displayed.  Update.
1798         (tui_data_window::refresh_all)
1799         (tui_data_window::do_scroll_vertical): Update.
1800         * tui/tui-data.h (struct tui_data_window)
1801         <first_data_item_displayed>: Declare new method.
1802
1803 2019-06-25  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1806         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1807         contents...
1808         (tui_initialize_static_data): ...here.
1809
1810 2019-06-25  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1813         (tui_display_registers_from, tui_check_register_values): Update.
1814         (tui_display_register): Remove win_info parameter; update.
1815         (tui_get_register): Change type of parameters.
1816         * tui/tui-data.h (struct tui_data_element): Remove.
1817         (union tui_which_element) <data>: Remove.
1818         <data_window>: Change type.
1819         (struct tui_data_item_window): New.
1820         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1821         case.  Add assert.
1822         (~tui_data_item_window): New destructor.
1823         (free_content_elements): Remove DATA_ITEM_WIN case.
1824
1825 2019-06-25  Tom Tromey  <tom@tromey.com>
1826
1827         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1828         Remove.
1829
1830 2019-06-25  Tom Tromey  <tom@tromey.com>
1831
1832         * tui/tui-data.h (struct tui_command_element): Remove.
1833         (union tui_which_element) <command>: Remove.
1834         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1835         assert.
1836         (free_content_elements): Remove CMD_WIN case.
1837
1838 2019-06-25  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-layout.c (tui_set_layout): Update.
1841         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1842         * tui/tui-data.c (layout_def): Update.
1843
1844 2019-06-25  Tom Tromey  <tom@tromey.com>
1845
1846         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1847         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1848         (tui_source_window_base::set_new_height): Update.
1849         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1850         Update.
1851         (tui_set_locator_fullname, tui_set_locator_info)
1852         (tui_show_frame_info): Update.
1853         * tui/tui-source.c (tui_set_source_content)
1854         (tui_source_is_displayed): Update.
1855         * tui/tui-layout.c (show_source_disasm_command, show_data)
1856         (show_source_or_disasm_and_command): Update.
1857         * tui/tui-disasm.c (tui_set_disassem_content)
1858         (tui_get_begin_asm_address): Update.
1859         * tui/tui-data.h (struct tui_locator_element): Remove.
1860         (union tui_which_element) <locator>: Remove.
1861         (struct tui_locator_window): New.
1862         (tui_locator_win_info_ptr): Change return type.
1863         * tui/tui-data.c (_locator): Change type.
1864         (tui_locator_win_info_ptr): Change return type.
1865         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1866         (tui_alloc_content): Add assert.
1867
1868 2019-06-25  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-winsource.c
1871         (tui_exec_info_window::maybe_allocate_content): New method.
1872         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1873         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1874         (make_source_or_disasm_window): Add cast.
1875         * tui/tui-data.h (union tui_which_element) <simple_string>:
1876         Remove.
1877         (struct tui_source_info): New.
1878         (struct tui_source_window_base) <execution_info>: Change type.
1879         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1880         case, and add assert.
1881         (tui_alloc_content): Add assert.
1882
1883 2019-06-25  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1886         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1887         * tui/tui-data.c (tui_alloc_win_info): Remove.
1888
1889 2019-06-25  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1892         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1893         can_highlight.
1894
1895 2019-06-25  Tom Tromey  <tom@tromey.com>
1896
1897         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1898         make_visible_with_new_height method.
1899         (tui_win_info::make_visible_with_new_height): New method.
1900         (tui_source_window_base::do_make_visible_with_new_height)
1901         (tui_data_window::do_make_visible_with_new_height)
1902         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1903         (make_visible_with_new_height): Remove.
1904         (tui_resize_all, tui_adjust_win_heights): Use
1905         make_visible_with_new_height method.
1906         * tui/tui-data.h (struct tui_win_info)
1907         <do_make_visible_with_new_height, make_visible_with_new_height>:
1908         New methods.
1909         (struct tui_source_window_base, struct tui_data_window)
1910         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1911         methods.
1912
1913 2019-06-25  Tom Tromey  <tom@tromey.com>
1914
1915         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1916         method.
1917         (update_tab_width): Call update_tab_width method.
1918         * tui/tui-data.h (struct tui_win_info)
1919         (struct tui_source_window_base) <update_tab_width>: New methods.
1920
1921 2019-06-25  Tom Tromey  <tom@tromey.com>
1922
1923         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1924         parameter.
1925         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1926         parameter.
1927         (tui_gen_win_info::make_visible): Update.
1928         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1929         parameter.
1930         * tui/tui-data.h (enum tui_box): New enum.
1931         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1932
1933 2019-06-25  Tom Tromey  <tom@tromey.com>
1934
1935         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1936         init_and_make_win for EXEC_INFO_WIN.
1937         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1938         longer inline.
1939         (struct tui_win_info) <~tui_win_info>: Inline.
1940         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1941         Don't declare.
1942         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1943         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1944         Remove.
1945         (tui_initialize_static_data): Update.
1946         (~tui_gen_win_info): Handle more cleanup here.
1947         (~tui_source_window_base): Delete "execution_info".
1948         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1949
1950 2019-06-25  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-layout.c (make_command_window): Don't set
1953         can_highlight.
1954         (show_source_disasm_command): Call the reset method.
1955         (show_data): Don't set can_highlight.  Call the reset method.
1956         (tui_gen_win_info::reset): Rename from init_gen_win_info
1957         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1958         (show_source_or_disasm_and_command): Call the reset method.
1959         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1960         (struct tui_cmd_window): Set can_highlight.
1961
1962 2019-06-25  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1965         from make_visible.
1966         (tui_make_visible, tui_make_invisible): Rewrite.
1967         (tui_win_info::make_visible): Remove.
1968         (tui_source_window_base::make_visible): Update.
1969         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1970         method.  Moved from...
1971         (struct tui_win_info) <make_visible>: ...here.
1972
1973 2019-06-25  Tom Tromey  <tom@tromey.com>
1974
1975         * tui/tui-winsource.c
1976         (tui_source_window_base::do_scroll_horizontal): Remove direction
1977         parameter.
1978         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1979         direction parameter.
1980         * tui/tui-win.c (tui_win_info::forward_scroll)
1981         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1982         (tui_win_info::right_scroll): Update.
1983         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1984         direction parameter.
1985         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1986         direction parameter.
1987         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1988         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1989         Remove direction parameter.
1990         (struct tui_source_window_base, struct tui_source_window)
1991         (struct tui_disasm_window, struct tui_data_window)
1992         (struct tui_cmd_window): Update.
1993
1994 2019-06-25  Tom Tromey  <tom@tromey.com>
1995
1996         * tui/tui-winsource.h (tui_set_exec_info_content)
1997         (tui_show_exec_info_content, tui_erase_exec_info_content)
1998         (tui_clear_exec_info_content, tui_update_exec_info): Change
1999         argument to tui_source_window_base.
2000         * tui/tui-winsource.c (tui_set_exec_info_content)
2001         (tui_show_exec_info_content, tui_erase_exec_info_content)
2002         (tui_clear_exec_info_content, tui_update_exec_info): Change
2003         argument to tui_source_window_base.
2004
2005 2019-06-25  Tom Tromey  <tom@tromey.com>
2006
2007         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2008         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2009
2010 2019-06-25  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2013         check.
2014
2015 2019-06-25  Tom Tromey  <tom@tromey.com>
2016
2017         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2018         type to void.
2019         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2020         type to void.
2021         * tui/tui-source.c (tui_set_source_content): Update.
2022         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2023
2024 2019-06-25  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-win.c (window_name_completer, tui_set_focus)
2027         (tui_all_windows_info): Use name method.
2028         * tui/tui-data.h (struct tui_gen_win_info)
2029         (struct tui_source_window, struct tui_disasm_window)
2030         (struct tui_data_window, struct tui_cmd_window) <name>: New
2031         method.
2032         (tui_win_name): Don't declare.
2033         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2034         (tui_win_name): Remove.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-winsource.h (tui_update_source_window)
2039         (tui_update_source_window_as_is): Change parameter type.
2040         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2041         to be a tui_source_window_base.
2042         (tui_update_source_window_as_is): Likewise.
2043         * tui/tui-win.c (make_visible_with_new_height): Update.
2044
2045 2019-06-25  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-winsource.c (tui_erase_source_content)
2048         (tui_show_source_content, tui_show_exec_info_content)
2049         (tui_erase_exec_info_content): Use refresh_window method.
2050         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2051         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2052         from tui_refresh_win.
2053         (tui_data_window::refresh_window): New method.
2054         (tui_win_info::refresh, tui_source_window_base::refresh)
2055         (tui_refresh_all): Use refresh_window method.
2056         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2057         method.
2058         * tui/tui-regs.c (tui_display_register): Call refresh_window
2059         method.
2060         * tui/tui-layout.c (show_source_disasm_command)
2061         (show_source_or_disasm_and_command): Call refresh_window method.
2062         * tui/tui-data.h (struct tui_gen_win_info)
2063         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2064         New method.
2065
2066 2019-06-25  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui.c (tui_rl_other_window, tui_enable)
2069         (tui_is_window_visible, tui_get_command_dimension): Update.
2070         * tui/tui-winsource.c (tui_update_source_window_as_is)
2071         (tui_clear_source_content, tui_erase_source_content)
2072         (tui_show_source_line, tui_source_window_base::refill)
2073         (tui_source_window_base::do_scroll_horizontal)
2074         (tui_source_window_base::set_is_exec_point_at)
2075         (tui_update_breakpoint_info, tui_set_exec_info_content)
2076         (tui_alloc_source_buffer, tui_line_is_displayed)
2077         (tui_addr_is_displayed): Update.
2078         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2079         (tui_check_and_display_highlight_if_needed)
2080         (tui_win_info::make_visible, tui_win_info::refresh)
2081         (tui_refresh_all): Update.
2082         * tui/tui-windata.c (tui_first_data_item_displayed)
2083         (tui_delete_data_content_windows, tui_erase_data_content)
2084         (tui_display_all_data, tui_data_window::refresh_all)
2085         (tui_check_data_values): Update.
2086         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2087         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2088         (tui_win_info::backward_scroll, tui_refresh_all_win)
2089         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2090         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2091         (tui_source_window_base::set_new_height)
2092         (tui_data_window::set_new_height)
2093         (make_invisible_and_set_new_height)
2094         (make_visible_with_new_height, new_height_ok)
2095         (parse_scrolling_args): Update.
2096         * tui/tui-stack.c (tui_show_frame_info): Update.
2097         * tui/tui-source.c (tui_set_source_content)
2098         (tui_set_source_content_nil, tui_source_is_displayed)
2099         (tui_source_window::do_scroll_vertical): Update.
2100         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2101         (tui_display_registers_from, tui_display_reg_element_at_line)
2102         (tui_check_register_values, tui_reg_command): Update.
2103         * tui/tui-layout.c (tui_default_win_height)
2104         (show_source_disasm_command, show_data, init_and_make_win)
2105         (show_source_or_disasm_and_command): Update.
2106         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2107         (tui_redisplay_readline, tui_mld_flush)
2108         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2109         (tui_getc): Update.
2110         * tui/tui-disasm.c (tui_set_disassem_content)
2111         (tui_disasm_window::do_scroll_vertical): Update.
2112         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2113         Now virtual.
2114         (struct tui_win_info): Derive from tui_gen_win_info.
2115         <~tui_win_info>: Mark as override.
2116         <generic>: Remove member.
2117         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2118         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2119         (~tui_data_window, ~tui_win_info)
2120         (tui_free_all_source_wins_content): Update.
2121         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2122
2123 2019-06-25  Tom Tromey  <tom@tromey.com>
2124
2125         * tui/tui-layout.c (init_and_make_win): Use new.
2126         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2127         destructor, initializers.
2128         (tui_alloc_generic_win_info): Don't declare.
2129         * tui/tui-data.c (_locator): Add argument to constructor.
2130         (source_win, disasm_win): New globals.
2131         (exec_info): Remove.
2132         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2133         Update.
2134         (tui_alloc_generic_win_info): Remove.
2135         (init_content_element): Use new.
2136         (tui_win_info::tui_win_info): Update.
2137         (free_content_elements) <case DATA_WIN>: Use delete.
2138
2139 2019-06-25  Tom Tromey  <tom@tromey.com>
2140
2141         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2142         * tui/tui-windata.c (tui_first_data_item_displayed)
2143         (tui_delete_data_content_windows): Update.
2144         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2145         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2146         (tui_display_registers_from, tui_check_register_values): Update.
2147         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2148         pointer.
2149         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2150         window.
2151         (tui_free_data_content): Update.
2152         (free_content_elements) <case DATA_WIN>: Free the window.
2153
2154 2019-06-25  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2157         Update.
2158         * tui/tui-layout.c (make_command_window)
2159         (show_source_disasm_command, show_data, init_and_make_win)
2160         (show_source_or_disasm_and_command): Update.
2161         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2162         method.
2163         <can_highight, is_highlighted>: Now bool.
2164         (tui_set_win_highlight): Don't declare.
2165         * tui/tui-data.c (tui_set_win_highlight): Remove.
2166
2167 2019-06-25  Tom Tromey  <tom@tromey.com>
2168
2169         * tui/tui-wingeneral.c (make_visible): Remove check of window
2170         type.
2171
2172 2019-06-25  Tom Tromey  <tom@tromey.com>
2173
2174         * tui/tui-win.c (tui_win_info::max_height)
2175         (tui_cmd_window::max_height): New methods.
2176         (new_height_ok): Call max_height.
2177         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2178         <max_height>: New method.
2179
2180 2019-06-25  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-win.c (tui_source_window_base::set_new_height)
2183         (tui_data_window::set_new_height): New methods.
2184         (make_invisible_and_set_new_height): Call set_new_height method.
2185         * tui/tui-data.h (struct tui_win_info)
2186         (struct tui_source_window_base, struct tui_data_window)
2187         <set_new_height>: New method.
2188
2189 2019-06-25  Tom Tromey  <tom@tromey.com>
2190
2191         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2192         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2193         tui_refresh_data_win.
2194         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2195         method.
2196         (tui_refresh_all_win): Call the refresh_all method.
2197         (tui_set_focus): Likewise.
2198         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2199         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2200         Likewise.
2201
2202 2019-06-25  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-winsource.h (tui_refill_source_window)
2205         (tui_set_is_exec_point_at): Don't declare.
2206         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2207         (tui_source_window_base::refill): Rename from
2208         tui_refill_source_window.
2209         (tui_source_window_base::do_scroll_horizontal): Update.
2210         (tui_source_window_base::set_is_exec_point_at): Rename from
2211         tui_set_is_exec_point_at.
2212         (tui_update_all_breakpoint_info): Update.
2213         * tui/tui-stack.c (tui_show_frame_info): Update.
2214         * tui/tui-layout.c (show_data): Add cast.
2215         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2216         * tui/tui-data.h (struct tui_source_window_base) <refill,
2217         set_is_exec_point_at>: New methods.
2218         (tui_source_windows, tui_add_to_source_windows): Update types.
2219         (tui_add_to_source_windows): Remove redundant declaration.
2220         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2221         (tui_source_windows): Change return type.
2222         (tui_clear_source_windows_detail): Update.
2223         (tui_add_to_source_windows): Change type of parameter.
2224         (tui_free_all_source_wins_content): Update.
2225
2226 2019-06-25  Tom Tromey  <tom@tromey.com>
2227
2228         * tui/tui-wingeneral.c (tui_win_info::refresh)
2229         (tui_source_window_base::refresh): New methods.
2230         (tui_refresh_all): Call the refresh method.
2231         * tui/tui-data.h (struct tui_win_info)
2232         (struct tui_source_window_base) <refresh>: New method.
2233
2234 2019-06-25  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui.h (tui_is_window_visible): Return bool.
2237         * tui/tui.c (tui_is_window_visible): Return bool.
2238         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2239         (tui_make_visible, tui_make_invisible)
2240         (tui_win_info::make_visible)
2241         (tui_source_window_base::make_visible, make_all_visible)
2242         (tui_make_all_visible, tui_make_all_invisible): Update.
2243         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2244         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2245         bool.
2246         (struct tui_win_info, struct tui_source_window_base)
2247         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2248         * tui/tui-data.c (tui_init_generic_part): Update.
2249
2250 2019-06-25  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2253         (tui_source_window_base::make_visible): New methods.
2254         (make_all_visible): Make method call.
2255         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2256         (struct tui_source_window_base, struct tui_cmd_window): Override
2257         make_visible.
2258         (tui_win_is_source_type): Don't declare.
2259         * tui/tui-data.c (tui_win_is_source_type): Remove.
2260
2261 2019-06-25  Tom Tromey  <tom@tromey.com>
2262
2263         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2264         NULL check.
2265
2266 2019-06-25  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2269         Inline constructor.  Add initializers for members.
2270         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2271         constructors; now inline in class.
2272
2273 2019-06-25  Tom Tromey  <tom@tromey.com>
2274
2275         * tui/tui-regs.c (tui_show_registers): Update.
2276         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2277         bool.
2278         * tui/tui-data.c (tui_data_window::clear_detail)
2279         (tui_data_window): Update.
2280
2281 2019-06-25  Tom Tromey  <tom@tromey.com>
2282
2283         * tui/tui-windata.c (tui_display_all_data)
2284         (tui_display_data_from_line, tui_display_data_from)
2285         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2286         Update.
2287         * tui/tui-regs.c (tui_last_regs_line_no)
2288         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2289         (tui_show_registers, tui_show_register_group)
2290         (tui_display_registers_from, tui_display_reg_element_at_line)
2291         (tui_display_registers_from_line, tui_check_register_values)
2292         (tui_reg_next, tui_reg_prev): Update.
2293         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2294         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2295         tui_data_window.
2296         (struct tui_win_info) <detail>: Remove.  Add new fields from
2297         tui_data_info.
2298         (TUI_DATA_WIN): Add cast.
2299         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2300         (~tui_data_window): Simplify.
2301
2302 2019-06-25  Tom Tromey  <tom@tromey.com>
2303
2304         * tui/tui-layout.c (show_source_disasm_command)
2305         (show_source_or_disasm_and_command): Update.
2306         * tui/tui-io.c (update_cmdwin_start_line)
2307         (tui_redisplay_readline): Update.
2308         * tui/tui-data.h (struct tui_command_info): Remove.
2309         (struct tui_win_info) <detail>: Remove command_info member.
2310         (struct tui_data_window) <start_line>: New member, from
2311         tui_command_info.
2312         (TUI_CMD_WIN): Add casts.
2313
2314 2019-06-25  Tom Tromey  <tom@tromey.com>
2315
2316         * tui/tui-winsource.c (tui_update_source_window)
2317         (tui_refill_source_window)
2318         (tui_source_window_base::do_scroll_horizontal)
2319         (tui_update_breakpoint_info, tui_set_exec_info_content)
2320         (tui_show_exec_info_content, tui_erase_exec_info_content)
2321         (tui_clear_exec_info_content): Update.
2322         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2323         Update.
2324         * tui/tui-win.c (make_invisible_and_set_new_height)
2325         (make_visible_with_new_height): Update.
2326         * tui/tui-source.c (tui_set_source_content)
2327         (tui_show_symtab_source): Update.
2328         * tui/tui-layout.c (extract_display_start_addr)
2329         (show_source_disasm_command, show_data)
2330         (make_source_or_disasm_window)
2331         (show_source_or_disasm_and_command): Update.
2332         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2333         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2334         "gdbarch".
2335         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2336         to tui_source_window_base.
2337         (struct tui_win_info) <detail>: Remove source_info member.
2338         (struct tui_source_window_base) <has_locator>: Inline.
2339         Move contents from tui_source_info; rename has_locator member to
2340         m_has_locator.
2341         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2342         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2343         header file.
2344         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2345         Simplify.
2346         (tui_free_all_source_wins_content): Cast to
2347         tui_source_window_base.
2348
2349 2019-06-25  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-win.c (make_invisible_and_set_new_height)
2352         (make_visible_with_new_height): Call has_locator method.
2353         * tui/tui-layout.c (show_source_disasm_command, show_data)
2354         (show_source_or_disasm_and_command): Update for bool change.
2355         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2356         (tui_win_info) <has_locator>: New method.
2357         (struct tui_source_window_base) <has_locator>: New method.
2358         (tui_win_has_locator): Don't declare.
2359         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2360         from tui_win_has_locator.
2361         (tui_source_window_base): Use false, not FALSE.
2362
2363 2019-06-25  Tom Tromey  <tom@tromey.com>
2364
2365         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2366         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2367         clear_detail method directly.
2368         (tui_clear_win_detail): Remove.
2369
2370 2019-06-25  Tom Tromey  <tom@tromey.com>
2371
2372         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2373         "this", not TUI_DISASM_WIN.
2374
2375 2019-06-25  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2378         declare.
2379         * tui/tui-winsource.c
2380         (tui_source_window_base::do_scroll_horizontal): Rename from
2381         tui_horizontal_source_scroll.
2382         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2383         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2384         from tui_vertical_data_scroll.
2385         * tui/tui-win.h (tui_scroll): Don't declare.
2386         * tui/tui-win.c (tui_win_info::forward_scroll)
2387         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2388         (tui_win_info::right_scroll): Rename and update.
2389         (tui_scroll_forward_command, tui_scroll_backward_command)
2390         (tui_scroll_left_command, tui_scroll_right_command): Update.
2391         (tui_scroll): Remove.
2392         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2393         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2394         from tui_vertical_source_scroll.
2395         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2396         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2397         from tui_vertical_disassem_scroll.
2398         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2399         do_scroll_horizontal>: New methods.
2400         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2401         Likewise.
2402         (struct tui_source_window_base): Add do_scroll_horizontal.
2403         (struct tui_source_window, struct tui_disasm_window): Add
2404         do_scroll_vertical.
2405         (struct tui_data_window, struct tui_cmd_window): Add
2406         do_scroll_horizontal and do_scroll_vertical.
2407         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2408
2409 2019-06-25  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-data.h (struct tui_source_window_base): New struct.
2412         (struct tui_source_window): Derive from tui_source_window_base.
2413         (struct tui_disasm_window): New struct.
2414         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2415         from tui_source_window::clear_detail.
2416         (tui_source_window_base): Rename from tui_source_window.
2417         (~tui_source_window_base): Rename from ~tui_source_window.
2418         (tui_alloc_win_info): Create a tui_disasm_window.
2419
2420 2019-06-25  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-data.h (struct tui_source_window)
2423         (struct tui_data_window): Declare destructors.
2424         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2425         destructors.
2426         (tui_win_info): Simplify.
2427
2428 2019-06-25  Tom Tromey  <tom@tromey.com>
2429
2430         * tui/tui-winsource.c (tui_display_main)
2431         (tui_update_source_windows_with_addr)
2432         (tui_update_all_breakpoint_info): Update.
2433         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2434         (new_height_ok, parse_scrolling_args): Update.
2435         * tui/tui-stack.c (tui_show_frame_info): Update.
2436         * tui/tui-data.h (struct tui_list): Remove.
2437         (tui_source_windows): Return a reference to a std::vector.
2438         * tui/tui-data.c (source_windows): Now a std::vector.
2439         (tui_source_windows): Change return type.
2440         (tui_clear_source_windows): Rewrite.
2441         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2442         (tui_free_all_source_wins_content): Rewrite.
2443
2444 2019-06-25  Tom Tromey  <tom@tromey.com>
2445
2446         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2447         (struct tui_data_window, struct tui_cmd_window): Declare
2448         clear_detail method.
2449         * tui/tui-data.c (tui_source_window::clear_detail)
2450         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2451         methods.
2452         (tui_clear_win_detail): Simplify.
2453
2454 2019-06-25  Tom Tromey  <tom@tromey.com>
2455
2456         * tui/tui-layout.c (make_source_window, make_disasm_window)
2457         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2458         Return the new window.
2459         (show_source_disasm_command, show_data)
2460         (show_source_or_disasm_and_command): Update.
2461
2462 2019-06-25  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2465         parameter.  Return the new window.
2466         (show_source_disasm_command): Update and remove NULL check.
2467         (show_source_or_disasm_and_command): Update.
2468
2469 2019-06-25  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2472
2473 2019-06-25  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-data.h (struct tui_win_info): Make constructor
2476         protected.  Make destructor virtual.  Add initializers.
2477         (tui_source_window, tui_data_window, tui_cmd_window): New
2478         classes.
2479         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2480         constructor.  Add "type" parameter.
2481         (tui_source_window, tui_data_window, tui_cmd_window): New
2482         constructors.
2483         (tui_alloc_win_info): Instantiate the appropriate subclass.
2484
2485 2019-06-25  Tom Tromey  <tom@tromey.com>
2486
2487         * tui/tui-win.c (tui_resize_all): Use delete.
2488         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2489         destructor.
2490         (tui_free_window): Don't declare.
2491         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2492         Update.
2493
2494 2019-06-25  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-data.h (struct tui_win_info): Add constructor.
2497         * tui/tui-data.c (tui_alloc_win_info): Use new.
2498         (tui_free_window): Use delete.
2499
2500 2019-06-22  Tom Tromey  <tom@tromey.com>
2501
2502         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2503         declare.
2504         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2505
2506 2019-06-22  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2509         declare.
2510         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2511
2512 2019-06-22  Tom de Vries  <tdevries@suse.de>
2513
2514         * dwarf2read.c (create_addrmap_from_aranges)
2515         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2516         instead of '%zu'.
2517
2518 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2519
2520         * dwarf2read.h (dwarf2_section_info_def): Remove.
2521         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2522         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2523         std::vector<dwarf2_section_info>.
2524         (struct dwo_file) <~dwo_file>: Remove.
2525         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2526         types field.
2527         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2528         (dwarf2_read_debug_names): Likewise.
2529         (create_debug_types_hash_table): Change parameter type to
2530         array_view, adjust code accordingly.
2531         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2532         (partial_die_info::fixup): Likewise.
2533         (determine_prefix): Likewise.
2534         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2535
2536 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2537
2538         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2539         gdb_bfd_ref_ptr.
2540         <~dwo_file>: Remove call to gdb_bfd_unref.
2541         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2542         gdb_bfd_ref_ptr::get.
2543
2544 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2545
2546         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2547         type to htab_up.
2548         * dwarf2read.c (struct dwo_file): Initialize fields.
2549         <~dwo_file>: New.
2550         (free_dwo_file): Remove, move content to ~dwo_file.
2551         (struct dwo_file_deleter): Remove.
2552         (dwo_file_up>: Remove custom deleter.
2553         (free_dwo_files): Remove.
2554         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2555         dwo_files.
2556         (process_skeletonless_type_units): Call unique_ptr::get.
2557         (allocate_dwo_file_hash_table): Add deleter to created hash
2558         table.  Change return type to htab_up.
2559         (lookup_dwo_file_slot): Don't memset dwo_file, call
2560         unique_ptr::get.
2561         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2562         (create_dwo_unit_in_dwp_v2): Likewise.
2563         (open_and_init_dwo_file): Likewise.
2564         (free_dwo_file_from_slot): Remove.
2565
2566 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2567
2568         * dwarf2read.h (struct dwarf2_section_info) <readin,
2569         is_virtual>: Change type to bool.
2570         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2571         true instead of 1.
2572
2573 2019-06-19  Tom Tromey  <tom@tromey.com>
2574
2575         * tui/tui-data.h (tui_init_content_element): Don't declare.
2576
2577 2019-06-19  Tom Tromey  <tom@tromey.com>
2578
2579         * tui/tui-data.h (tui_init_win_info): Don't declare.
2580
2581 2019-06-19  Tom de Vries  <tdevries@suse.de>
2582
2583         * dwarf2read.h (abstract_to_concrete): Change type to
2584         std::unordered_map<sect_offset, std::vector<sect_offset>,
2585         gdb::hash_enum<sect_offset>>.
2586
2587 2019-06-19  Tom Tromey  <tromey@adacore.com>
2588
2589         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2590         EVAL_AVOID_SIDE_EFFECTS specially.
2591
2592 2019-06-19  Tom Tromey  <tromey@adacore.com>
2593
2594         * source-cache.c (highlighter): New global.
2595         (source_cache::get_source_lines): Create a highlighter on demand.
2596
2597 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2598
2599         * defs.h (deprecated_interactive_hook): Delete declaration.
2600         * interps.c (clear_interpreter_hooks): Remove use of
2601         deprecated_interactive_hook.
2602         * top.c (deprecated_interactive_hook): Delete definition.
2603         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2604
2605 2019-06-18  Tom de Vries  <tdevries@suse.de>
2606
2607         PR gdb/24515
2608         * dwarf2read.h (abstract_to_concrete): Change type from
2609         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2610         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2611         * dwarf2read.c (read_variable): Update.
2612         (dwarf2_fetch_die_loc_sect_off): Update.
2613
2614 2019-06-17  Tom de Vries  <tdevries@suse.de>
2615
2616         PR gdb/24617
2617         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2618         accessing parent[parent_len - 1].
2619
2620 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2621
2622         PR gdb/24364
2623         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2624         call dtrace_process_dof with NULL dof.
2625
2626 2019-06-16  Tom de Vries  <tdevries@suse.de>
2627
2628         PR gdb/24445
2629         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2630
2631 2019-06-16  Tom Tromey  <tom@tromey.com>
2632
2633         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2634         (make_all_visible): Use address of member.
2635
2636 2019-06-16  Tom Tromey  <tom@tromey.com>
2637
2638         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2639         (tui_free_window, free_content, free_content_elements): Remove
2640         unnecessary cast.
2641         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2642         cast.
2643         * tui/tui-regs.c (tui_show_register_group)
2644         (tui_display_registers_from, tui_display_reg_element_at_line):
2645         Remove unnecessary cast.
2646
2647 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2648
2649         * linux-nat.c (normal_mask): Delete.
2650         (_initialize_linux_nat): Don't initialise normal_mask.
2651
2652 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2653
2654         PR gdb/24445
2655         * dwarf-index-write.h (write_psymtabs_to_index): Add
2656         dwz_basename parameter.
2657         * dwarf-index-write.c (write_gdbindex): Move file writing to
2658         write_gdbindex_1.  Change return type void.
2659         (assert_file_size): Move up, remove filename parameter.
2660         (write_gdbindex_1): New function.
2661         (write_debug_names): Change return type to void, call
2662         assert_file_size.
2663         (struct index_wip_file): New struct.
2664         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2665         file logic to index_wip_file.  Write index for dwz file if
2666         needed.
2667         (save_gdb_index_command): Pass basename of dwz file, if present.
2668         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2669         build-id of dwz file, if present.
2670         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2671         (dwarf2_get_dwz_file): Likewise.
2672         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2673         (dwarf2_get_dwz_file): Likewise.
2674
2675 2019-06-16  Tom Tromey  <tom@tromey.com>
2676
2677         * coffread.c (process_coff_symbol): Use xstrdup.
2678         * value.c (create_internalvar): Use xstrdup.
2679
2680 2019-06-16  Tom Tromey  <tom@tromey.com>
2681
2682         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2683         * breakpoint.c (stopin_command, stopat_command)
2684         (until_break_command, decode_location_default): Remove unnecessary
2685         cast.
2686         * utils.c (subset_compare): Remove unnecessary cast.
2687         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2688         cast.
2689         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2690         cast.
2691         * infcmd.c (path_command): Remove unnecessary cast.
2692         * coffread.c (decode_type): Remove unnecessary cast.
2693         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2694         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2695         * tui/tui-stack.c (tui_show_locator_content)
2696         (tui_show_frame_info): Remove unnecessary cast.
2697         * tui/tui-win.c (tui_scroll_forward_command)
2698         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2699         (parse_scrolling_args): Remove unnecessary cast.
2700         * tui/tui-data.c (init_win_info, tui_del_window)
2701         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2702         (free_content_elements): Remove unnecessary cast.
2703         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2704         unnecessary cast.
2705         * tui/tui-source.c (tui_set_source_content)
2706         (tui_vertical_source_scroll): Remove unnecessary cast.
2707         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2708         cast.
2709         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2710         * tui/tui-regs.c (tui_display_registers_from)
2711         (tui_display_register): Remove unnecessary cast.
2712         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2713         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2714         (make_visible): Remove unnecessary cast.
2715         * tui/tui-winsource.c (tui_erase_source_content)
2716         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2717         unnecessary cast.
2718         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2719         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2720         * stabsread.c (read_type, read_array_type, read_range_type):
2721         Remove unnecessary cast.
2722         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2723         (parse_symbol, parse_type, upgrade_type, parse_external)
2724         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2725         unnecessary cast.
2726         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2727
2728 2019-06-16  Tom Tromey  <tom@tromey.com>
2729
2730         * tui/tui-data.c (tui_alloc_generic_win_info)
2731         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2732         checks.
2733
2734 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2735             Andrew Burgess  <andrew.burgess@embecosm.com>
2736
2737         * f-typeprint.c (f_print_type): Don't return early for not
2738         associated or not allocated types.
2739         (f_type_print_varspec_suffix): Add print_rank parameter and print
2740         ranks of array types in case they dangling.
2741         (f_type_print_base): Add print_rank parameter.
2742
2743 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * NEWS: Mention new MI commands.
2746         * break-catch-throw.c (enum exception_event_kind): Move to
2747         breakpoint.h.
2748         (print_mention_exception_catchpoint): Output text as a single
2749         message.
2750         (catch_exception_command_1): Rename to...
2751         (catch_exception_event): ...this, make non-static, update header
2752         command, and change some parameter types.
2753         (catch_catch_command): Update for changes to
2754         catch_exception_command_1.
2755         (catch_throw_command): Likewise.
2756         (catch_rethrow_command): Likewise.
2757         * breakpoint.c (enum exception_event_kind): Delete.
2758         * breakpoint.h (enum exception_event_kind): Moved here from
2759         break-catch-throw.c.
2760         (catch_exception_event): Declare.
2761         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2762         (mi_cmd_catch_throw): New function.
2763         (mi_cmd_catch_rethrow): New function.
2764         (mi_cmd_catch_catch): New function.
2765         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2766         'catch-catch' entries.
2767         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2768         (mi_cmd_catch_rethrow): Declare.
2769         (mi_cmd_catch_catch): Declare.
2770
2771 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2772
2773         * annotate.c (annotate_source_line): Change return type to void,
2774         update implementation to match.
2775         * annotate.h (annotate_source_line): Change return type to void,
2776         update header comment.
2777         * stack.c (print_frame_info): Don't change what frame information
2778         is printed based on whether annotations are on or not.
2779
2780 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2781
2782         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2783         (annotate_source): Make static.
2784         (annotate_source_line): Moved from source.c and renamed from
2785         identify_source_line.  Update the return type.
2786         * annotate.h (annotate_source): Delete declaration.
2787         (annotate_source_line): Declaration moved from source.h, and
2788         renamed from identify_source_line.  Return type updated.
2789         * source.c (identify_source_line): Moved to annotate.c and renamed
2790         to annotate_source_line.
2791         (info_line_command): Remove check of annotation_level.
2792         * source.h (identify_source_line): Move declaration to annotate.h
2793         and rename to annotate_source_line.
2794         * stack.c: Add 'annotate.h' include.
2795         (print_frame_info): Remove check of annotation_level before
2796         calling annotate_source_line.
2797
2798 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2799
2800         * source-cache.c (source_cache::get_plain_source_lines): Use
2801         open_source_file_with_line_charpos instead of just
2802         open_source_file, remove call to find_source_lines.
2803         (source_cache::get_source_lines): Likewise.
2804         * source.c (find_source_lines): Make static.
2805         (get_filename_and_charpos): Renamed into...
2806         (open_source_file_with_line_charpos): ..this along with changes to
2807         return a scoped_fd, and some other minor clean ups.
2808         (identify_source_line): Use open_source_file_with_line_charpos.
2809         (search_command_helper): Use open_source_file_with_line_charpos
2810         instead of just open_source_file, remove call to
2811         find_source_lines.
2812         * source.h (open_source_file_with_line_charpos): Declare new
2813         function.
2814         (find_source_lines): Delete declaration.
2815
2816 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2817
2818         * source.c (get_filename_and_charpos): Remove fullname
2819         parameter.
2820         (identify_source_line): Update call to get_filename_and_charpos.
2821
2822 2019-06-14  Tom Tromey  <tromey@adacore.com>
2823
2824         PR gdb/24502:
2825         * ui-style.h (skip_ansi_escape): Update comment.
2826         * ui-file.h (class no_terminal_escape_file): New class.
2827         * ui-file.c (no_terminal_escape_file::write)
2828         (no_terminal_escape_file::puts): New methods.
2829         * cli/cli-logging.c (handle_redirections): Use
2830         no_terminal_escape_file.
2831
2832 2019-06-14  Tom Tromey  <tromey@adacore.com>
2833
2834         * NEWS: Move convenience variable news above Python news.
2835
2836 2019-06-14  Tom Tromey  <tom@tromey.com>
2837
2838         * gnulib: Move directory to top-level.
2839         * configure.ac: Don't configure gnulib.
2840         * configure: Rebuild.
2841         * common/common-defs.h: Use new path to gnulib.
2842         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2843         (GNULIB_H): Remove.
2844         (INCGNU): Look in new gnulib location.
2845         (HFILES_NO_SRCDIR): Remove gnulib files.
2846         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2847         (generated_files): Remove GNULIB_H.
2848         ($(LIBGNU), all-lib): Remove targets.
2849         (distclean): Don't mention GNULIB_BUILDDIR.
2850         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2851
2852 2019-06-14  Tom Tromey  <tromey@adacore.com>
2853
2854         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2855         Warn if symbol file does not provide any symbols.
2856
2857 2019-06-14  Tom Tromey  <tromey@adacore.com>
2858
2859         * source.c (find_and_open_source): Respect basenames_may_differ.
2860
2861 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2862
2863         * annotate.c (annotate_breakpoints_invalid): Make use of
2864         scoped_restore_terminal_state.
2865         (annotate_frames_invalid): Likewise.
2866
2867 2019-06-14  Tom Tromey  <tromey@adacore.com>
2868
2869         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2870         allow assignment to an internalvar.
2871
2872 2019-06-14  Tom Tromey  <tromey@adacore.com>
2873
2874         * ada-lex.l: Allow "_" in attribute names.
2875
2876 2019-06-14  Tom Tromey  <tromey@adacore.com>
2877
2878         PR gdb/24653:
2879         * regcache.c (registers_changed): Don't call alloca.
2880         * top.c (execute_command): Don't call alloca.
2881
2882 2019-06-13  Pedro Alves  <palves@redhat.com>
2883
2884         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2885         'expression'.  When parsing an expression, error out if there's
2886         junk after "unlimited".
2887         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2888         (do_set_command): Adjust calls to is_unlimited_literal.
2889
2890 2019-06-13  Pedro Alves  <palves@redhat.com>
2891
2892         * compile/compile.c (make_compile_options_def_group): Add braces
2893         around array_view initializer.
2894         * thread.c (make_thread_apply_all_options_def_group)
2895         (make_thread_apply_all_options_def_group): Likewise.
2896
2897 2019-06-13  Pedro Alves  <palves@redhat.com>
2898
2899         * NEWS (New commands): Mention "maint test-options
2900         require-delimiter", "maint test-options unknown-is-error", "maint
2901         test-options unknown-is-operand" and "maint show
2902         test-options-completion-result".
2903         (New command options, command completion): New section.
2904         (Completion improvements): New section.
2905         Mention that you can abbreviate "unlimited".
2906
2907 2019-06-13  Pedro Alves  <palves@redhat.com>
2908
2909         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2910         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2911         * unittests/cli-utils-selftests.c (test_parse_flags)
2912         (test_parse_flags_qcs): Delete.
2913         (test_cli_utils): Don't call deleted functions.
2914
2915 2019-06-13  Pedro Alves  <palves@redhat.com>
2916
2917         * thread.c: Include "cli/cli-option.h".
2918         (tp_array_compar_ascending): Global.
2919         (tp_array_compar): Delete function.
2920         (tp_array_compar_ascending, tp_array_compar_descending): New
2921         functions.
2922         (ascending_option_def, qcs_flag_option_def)
2923         (thr_qcs_flags_option_defs)
2924         (make_thread_apply_all_options_def_group)
2925         (make_thread_apply_options_def_group): New.
2926         (thread_apply_all_command): Use gdb::option::process_options.
2927         (thread_apply_command_completer)
2928         (thread_apply_all_command_completer): New.
2929         (thread_apply_command): Use gdb::option::process_options.
2930         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2931         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2932         to generate help text of "thread apply".  Adjust "taas"'s help.
2933         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2934         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2935
2936 2019-06-13  Pedro Alves  <palves@redhat.com>
2937
2938         * thread.c (thread_apply_command): Check for invalid TID with
2939         isdigit instead of !isalpha.
2940
2941 2019-06-13  Pedro Alves  <palves@redhat.com>
2942
2943         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2944         (validate_flags_qcs): New.
2945         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2946         (validate_flags_qcs): Declare.
2947         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2948         (make_frame_apply_options_def_group): New.
2949         (frame_apply_command_count): Process options with
2950         gdb::option::process_options.
2951         (frame_apply_completer): New.
2952         (frame_apply_level_completer, frame_apply_all_completer)
2953         (frame_apply_completer): New.
2954         (_initialize_stack): Update help of "frame apply", "frame apply
2955         level", "frame apply all" and "faas" to mention supported options
2956         and install command completers.
2957         * stack.h (frame_apply_all_completer): Declare.
2958         * thread.c: Include "stack.h".
2959         (tfaas_command): Add "--".
2960         (_initialize_thread): Update help "tfaas" to mention supported
2961         options and install command completer.
2962
2963 2019-06-13  Pedro Alves  <palves@redhat.com>
2964
2965         * completer.c (complete_nested_command_line): New.
2966         (gdb_completion_word_break_characters_throw): Add assertion.
2967         * completer.h (complete_nested_command_line): Declare.
2968
2969 2019-06-13  Pedro Alves  <palves@redhat.com>
2970
2971         * stack.c (parse_backtrace_qualifiers): New.
2972         (backtrace_command): Use it.
2973         (backtrace_command_completer): Complete on qualifiers.
2974
2975 2019-06-13  Pedro Alves  <palves@redhat.com>
2976
2977         * frame.c: Include "cli/cli-option.h.
2978         (user_set_backtrace_options): New.
2979         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2980         Delete.
2981         (get_prev_frame): Adjust.
2982         (boolean_option_def, uinteger_option_def)
2983         (set_backtrace_option_defs): New.
2984         (_initialize_frame): Adjust and use
2985         gdb::option::add_setshow_cmds_for_options to install "set
2986         backtrace past-main" and "set backtrace past-entry".
2987         * frame.h: Include "cli/cli-option.h".
2988         (struct frame_print_options): Forward declare.
2989         (print_frame_arguments_all, print_frame_arguments_scalars)
2990         (print_frame_arguments_none): Declare.
2991         (print_entry_values): Delete declaration.
2992         (struct frame_print_options, user_frame_print_options): New.
2993         (struct set_backtrace_options): New.
2994         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2995         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2996         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2997         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2998         (list_args_or_locals): Add frame_print_options parameter.
2999         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3000         * python/py-framefilter.c (enumerate_args): Pass down
3001         USER_FRAME_PRINT_OPTIONS.
3002         * stack.c: Include "cli/cli-option.h".
3003         (print_frame_arguments_all, print_frame_arguments_scalars)
3004         (print_frame_arguments_none): Declare.
3005         (print_raw_frame_arguments, print_entry_values): Delete.
3006         (user_frame_print_options): New.
3007         (boolean_option_def, enum_option_def, frame_print_option_defs):
3008         New.
3009         (struct backtrace_cmd_options): New.
3010         (bt_flag_option_def): New.
3011         (backtrace_command_option_defs): New.
3012         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3013         (print_frame_arg, read_frame_arg, print_frame_args)
3014         (print_frame_info, print_frame): Add frame_print_options parameter
3015         and use it.
3016         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3017         (backtrace_command_1): Add frame_print_options and
3018         backtrace_cmd_options parameters and use them.
3019         (make_backtrace_options_def_group): New.
3020         (backtrace_command): Process command options with
3021         gdb::option::process_options.
3022         (backtrace_command_completer): New.
3023         (_initialize_stack): Extend "backtrace"'s help to mention
3024         supported options.  Install completer for "backtrace".
3025         Install some settings commands with add_setshow_cmds_for_options.
3026
3027 2019-06-13  Pedro Alves  <palves@redhat.com>
3028
3029         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3030         and that "set/show print raw frame-arguments" are now deprecated.
3031
3032         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3033         command.
3034         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3035         * stack.c (_initialize_stack): Install "set/show print
3036         raw-frame-arguments", and deprecate "set/show print raw
3037         frame-arguments".
3038         * valprint.c (_initialize_valprint): Deprecate "set/show print
3039         raw".
3040
3041 2019-06-13  Pedro Alves  <palves@redhat.com>
3042
3043         * compile/compile.c (struct compile_options): New.
3044         (compile_flag_option_def, compile_command_option_defs)
3045         (make_compile_options_def_group): New.
3046         (compile_file_command): Handle options with
3047         gdb::option::process_options.
3048         (compile_file_command_completer): New function.
3049         (compile_code_command): Handle options with
3050         gdb::option::process_options.
3051         (compile_code_command_completer): New function.
3052         (_initialize_compiler): Install completers for "compile code" and
3053         "compile file".  Mention available options in "compile code" and
3054         "compile code"'s help.
3055         * completer.c (advance_to_completion_word): New, factored out from
3056         ...
3057         (advance_to_expression_complete_word_point): ... this.
3058         (advance_to_filename_complete_word_point): New.
3059         * completer.h (advance_to_filename_complete_word_point): New
3060         declaration.
3061
3062 2019-06-13  Pedro Alves  <palves@redhat.com>
3063
3064         * compile/compile.c: Include "cli/cli-option.h".
3065         (compile_print_value): Scope data pointer is now a
3066         value_print_options pointer; adjust.
3067         (compile_print_command): Process options.  Scope data pointer is
3068         now a value_print_options pointer; adjust.
3069         (_initialize_compile): Update "compile print"'s help to include
3070         supported options.  Install a completer for "compile print".
3071         * cp-valprint.c (show_vtblprint, show_objectprint)
3072         (show_static_field_print): Delete.
3073         (_initialize_cp_valprint): Don't install "set print
3074         static-members", "set print vtbl", "set print object" here.
3075         * printcmd.c: Include "cli/cli-option.h" and
3076         "common/gdb_optional.h".
3077         (print_command_parse_format): Rework to fill in a
3078         value_print_options instead of a format_data.
3079         (print_value): Change parameter type from format_data pointer to
3080         value_print_options reference.  Adjust.
3081         (print_command_1): Process options.  Adjust to pass down a
3082         value_print_options.
3083         (print_command_completer): New.
3084         (_initialize_printcmd): Install print_command_completer as
3085         handle_brkchars completer for the "print" command.  Update
3086         "print"'s help to include supported options.
3087         * valprint.c: Include "cli/cli-option.h".
3088         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3089         here from cp-valprint.c.
3090         (boolean_option_def, uinteger_option_def)
3091         (value_print_option_defs, make_value_print_options_def_group):
3092         New.  Use gdb::option::add_setshow_cmds_for_options to install
3093         "set print elements", "set print null-stop", "set print repeats",
3094         "set print pretty", "set print union", "set print array", "set
3095         print address", "set print symbol", "set print array-indexes".
3096         * valprint.h: Include <string> and "cli/cli-option.h".
3097         (make_value_print_options_def_group): Declare.
3098         (print_value): Change parameter type from format_data pointer to
3099         value_print_options reference.
3100         (print_command_completer): Declare.
3101
3102 2019-06-13  Pedro Alves  <palves@redhat.com>
3103
3104         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3105         (COMMON_SFILES): Add maint-test-settings.c.
3106         * cli/cli-decode.c (boolean_enums): New global, factored out from
3107         ...
3108         (add_setshow_boolean_cmd): ... here.
3109         * cli/cli-decode.h (boolean_enums): Declare.
3110         * cli/cli-option.c: New file.
3111         * cli/cli-option.h: New file.
3112         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3113         factored out from ...
3114         (parse_cli_boolean_value(const char *)): ... this.
3115         (is_unlimited_literal): Change parameter type to pointer to
3116         pointer.  Adjust and advance ARG pointer.
3117         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3118         (parse_cli_var_enum): New, factored out from ...
3119         (do_set_command): ... this.  Adjust.
3120         * cli/cli-setshow.h (parse_cli_boolean_value)
3121         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3122         (parse_cli_var_enum): Declare.
3123         * cli/cli-utils.c: Include "cli/cli-option.h".
3124         (get_ulongest): New.
3125         * cli/cli-utils.h (get_ulongest): Declare.
3126         (check_for_argument): New overloads.
3127         * maint-test-options.c: New file.
3128
3129 2019-06-13  Pedro Alves  <palves@redhat.com>
3130
3131         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3132         parse a range if "-" is at the end of the string.
3133
3134 2019-06-13  Pedro Alves  <palves@redhat.com>
3135
3136         * cli/cli-setshow.c (parse_auto_binary_operation)
3137         (parse_cli_boolean_value): Don't allow "o".
3138
3139 2019-06-13  Pedro Alves  <palves@redhat.com>
3140
3141         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3142         * NEWS: Mention maint test-settings KIND.
3143         * maint-test-settings.c: New file.
3144
3145 2019-06-13  Pedro Alves  <palves@redhat.com>
3146
3147         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3148         completer.
3149         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3150         "set" completers.
3151
3152 2019-06-13  Pedro Alves  <palves@redhat.com>
3153
3154         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3155         after item.
3156
3157 2019-06-13  Pedro Alves  <palves@redhat.com>
3158
3159         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3160
3161 2019-06-13  Pedro Alves <palves@redhat.com>
3162
3163         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3164         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3165         call.
3166         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3167         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3168         calls.
3169         (check_for_argument): Skip spaces after argument.
3170
3171 2019-06-13  Pedro Alves  <palves@redhat.com>
3172
3173         * thread.c (thread_apply_command): Adjust TID parsing.
3174         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3175         detected before end of string.
3176         (tid_is_in_list): Error out if LIST is invalid.
3177
3178 2019-06-13  Pedro Alves  <palves@redhat.com>
3179
3180         * completer.c (complete_line_internal_1): Rewind completion word
3181         point.
3182         (completion_tracker::advance_custom_word_point_by): Change
3183         parameter type to int.
3184         * completer.h (completion_tracker::advance_custom_word_point_by):
3185         Likewise.
3186
3187 2019-06-13  Pedro Alves  <palves@redhat.com>
3188
3189         * completer.c (advance_to_completion_word): Handle delimiters.
3190
3191 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3192
3193         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3194
3195 2019-06-11  Tom Tromey  <tom@tromey.com>
3196
3197         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3198         (xmalloc_failed): Move to alloc.c.
3199         * alloc.c: New file.
3200         * Makefile.in (COMMON_SFILES): Add alloc.c.
3201
3202 2019-06-11  Tom Tromey  <tom@tromey.com>
3203
3204         * nat/linux-waitpid.c: Don't include server.h.
3205         (linux_debug): Remove.
3206         (my_waitpid): Update.
3207
3208 2019-06-11  Tom Tromey  <tromey@adacore.com>
3209
3210         * infcall.c (_initialize_infcall): Remove trailing newline from
3211         help.
3212         * user-regs.c (_initialize_user_regs): Remove trailing newline
3213         from help.
3214         * typeprint.c (_initialize_typeprint): Remove trailing newline
3215         from help.
3216         * reverse.c (_initialize_reverse): Remove trailing newlines from
3217         help.
3218         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3219         from help.
3220         * language.c (add_set_language_command): Remove trailing newline
3221         from help.
3222         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3223         help.
3224         * disasm.c (_initialize_disasm): Remove trailing newline from
3225         help.
3226         * top.c (init_main): Remove trailing newline from help.
3227         * interps.c (_initialize_interpreter): Remove trailing newline
3228         from help.
3229         * btrace.c (_initialize_btrace): Remove trailing newlines from
3230         help.
3231         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3232         from help.
3233         * python/python.c (_initialize_python): Remove trailing newline
3234         from help.
3235         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3236         help.
3237         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3238         from help.  Reformat some text.
3239         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3240         from help.
3241         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3242         newline from help.
3243
3244 2019-06-11  Tom Tromey  <tromey@adacore.com>
3245
3246         * darwin-nat.c (darwin_decode_exception_message)
3247         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3248
3249 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3250
3251         * valops.c (value_slice): Check for not allocated or not
3252         associated values.
3253
3254 2019-06-10  Tom de Vries  <tdevries@suse.de>
3255
3256         PR gdb/24618
3257         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3258         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3259         invalid.
3260
3261 2019-06-10  Tom de Vries  <tdevries@suse.de>
3262
3263         PR gdb/24611
3264         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3265         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3266
3267 2019-06-10  Tom de Vries  <tdevries@suse.de>
3268
3269         PR symtab/24545
3270         * symtab.c (struct demangled_name_entry): Add language field.
3271         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3272         static minimal symbol".  Set and use language field.
3273
3274 2019-06-10  Tom Tromey  <tromey@adacore.com>
3275
3276         * ada-lang.c (_initialize_ada_language): Update help text.
3277
3278 2019-06-10  Tom Tromey  <tromey@adacore.com>
3279
3280         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3281         with a newline.
3282         * guile/guile.c (handle_boot_error): Don't end warning with a
3283         newline.
3284         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3285         warning with a newline.
3286         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3287         newline.
3288         (s12z_frame_cache): Likewise.
3289         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3290         a newline.
3291         * solib-svr4.c (disable_probes_interface): Don't end warning with
3292         a newline.
3293         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3294         newline.
3295         * python/python.c (do_finish_initialization): Don't end warning
3296         with a newline.
3297
3298 2019-06-10  Tom Tromey  <tom@tromey.com>
3299
3300         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3301         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3302         gdbpy_enter.
3303
3304 2019-06-10  Tom Tromey  <tromey@adacore.com>
3305
3306         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3307         data.
3308         (elf_new_init): Don't call stabsread_new_init.
3309         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3310         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3311         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3312
3313 2019-06-10  Tom de Vries  <tdevries@suse.de>
3314
3315         PR symtab/16264
3316         PR symtab/24517
3317         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3318
3319 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3320
3321         * source.c (find_and_open_source): Also rewrite relative file
3322         names.
3323
3324 2019-04-26  Amos Bird  <amosbird@gmail.com>
3325
3326         * annotate.c (annotate_thread_exited): Add "thread-exited"
3327         annotation.
3328
3329 2019-06-06  Tom Tromey  <tromey@adacore.com>
3330
3331         * maint.h (class scoped_command_stats): Use
3332         DISABLE_COPY_AND_ASSIGN.
3333         <print_time>: New method.
3334         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3335         print_time.
3336         (scoped_command_stats::print_time): New method.
3337
3338 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3341         instructions of lengths 6 or 8 bytes.
3342
3343 2019-06-04  Pedro Alves  <palves@redhat.com>
3344
3345         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3346
3347         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3348         * breakpoint.c (condition_completer): Likewise.
3349         * cli/cli-dump.c (scan_expression): Likewise.
3350         * common/filestuff.c (mkdir_recursive): Likewise.
3351         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3352         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3353         (gdb_abspath): Likewise.
3354         * compile/compile-cplus-types.c
3355         (compile_cplus_instance::decl_name): Likewise.
3356         * completer.c (complete_explicit_location):
3357         (signal_completer, reg_or_group_completer_1): Likewise.
3358         * cp-support.c (cp_remove_params_if_any): Likewise.
3359         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3360         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3361         * infcmd.c (strip_bg_char): Likewise.
3362         * linespec.c (copy_token_string): Likewise.
3363         * mi/mi-main.c (output_cores): Likewise.
3364         * psymtab.c (psymtab_search_name):
3365         * symfile.c (test_set_ext_lang_command): Likewise.
3366         * target.c (target_fileio_read_stralloc): Likewise.
3367         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3368         * value.c (complete_internalvar): Likewise.
3369
3370 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3371
3372         Add objfile property to gdb.Type.
3373         * NEWS: Mention Python API addition.
3374         * python/py-type.c (typy_get_objfile): New method.
3375
3376 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3377
3378         * NEWS: Mention the new set|show style [title|highlight].
3379         Mention changes to "show style", "help" and "apropos".
3380
3381 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3382
3383         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3384         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3385         instead of print_help_for_command.
3386         (print_doc_of_command): New function.
3387         (help_list): Add 'apropos -v word' suggestion.
3388         (print_help_for_command): Style the command name using title style.
3389         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3390         (_initialize_cli_cmds): Describe -v in apropos_command help.
3391
3392 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3393
3394         * cli/cli-style.h (cli_style_option): Add name in constructor,
3395         add m_name class member, add constructor with intensity,
3396         add name class function.
3397         (cli_style_option::add_setshow_commands): Remove name argument.
3398         (highlight_style, title_style): New styles.
3399         * cli/cli-style.c (do_show): New function that shows a style
3400         characteristic styling the style name with itself.
3401         (set_style_name): New function.
3402         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3403         Update all callers according to the changes in cli/cli-style.h.
3404         * utils.h (fputs_highlighted): New function.
3405         * utils.c (fputs_highlighted): Likewise.
3406
3407 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3408
3409         * NEWS: Mention new pipe command and new convenience variables.
3410
3411 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3412
3413         * cli/cli-cmds.c (pipe_command): New function.
3414         (_initialize_cli_cmds): Call add_com for pipe_command.
3415         Define | as an alias for pipe.
3416         (exit_status_set_internal_vars): New function.
3417         (shell_escape): Call exit_status_set_internal_vars.
3418         cli/cli-decode.c (find_command_name_length): Recognize | as
3419         a single character command.
3420
3421 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3422
3423         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3424         top.c (execute_command_to_ui_file): New function, mostly a copy
3425         of execute_command_to_string.
3426         (execute_command_to_string): Implement by calling
3427         execute_command_to_ui_file.
3428
3429 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3430
3431         * top.h (saved_command_line): Remove declaration.
3432         * top.c (previous_saved_command_line, previous_repeat_arguments):
3433         New variables.
3434         (saved_command_line): Make static, define together with other
3435         'repeat variables'.
3436         (dont_repeat): Clear repeat_arguments.
3437         (repeat_previous, get_saved_command_line, save_command_line):
3438         New functions.
3439         (gdb_init): Initialize saved_command_line
3440         and previous_saved_command_line.
3441         * main.c (captured_main_1): Remove saved_command_line initialization.
3442         * event-top.c (handle_line_of_input): Update to use
3443         the new 'repeat' related functions instead of direct access to
3444         saved_command_line.
3445         * command.h (repeat_previous, get_saved_command_line,
3446         save_command_line): New declarations.
3447         (dont_repeat): Add comment.
3448
3449 2019-05-30  Tom Tromey  <tromey@adacore.com>
3450
3451         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3452         Fix comment.
3453         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3454
3455 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3456
3457         PR cli/24587
3458         * completer.c (complete): Initialize variable word.
3459
3460 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3461
3462         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3463         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3464         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3465         'body' is NULL to the outter 'if', protecting the '!is_define'
3466         situation as well.
3467
3468 2019-05-29  Tom Tromey  <tromey@adacore.com>
3469
3470         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3471         (dwarf_unknown): New function.
3472         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3473         (dwarf_type_encoding_name): Use dwarf_unknown.
3474
3475 2019-05-29  Tom Tromey  <tromey@adacore.com>
3476
3477         PR c++/20020:
3478         * cp-valprint.c (cp_print_value_fields): Call
3479         cp_print_static_field inside "try".
3480
3481 2019-05-29  Tom Tromey  <tromey@adacore.com>
3482
3483         * inflow.c (struct terminal_info): Add default operator=.
3484         * configure: Rebuild.
3485         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3486         -Wdeprecated-copy-dtor, -Wredundant-move.
3487
3488 2019-05-29  Tom Tromey  <tromey@adacore.com>
3489
3490         * NEWS: Add entry.
3491         * infcmd.c (print_return_value_1): Handle finish_print
3492         option.
3493         (show_print_finish): New function.
3494         (_initialize_infcmd): Add "set/show print finish" commands.
3495         * valprint.c (user_print_options): Initialize new member.
3496         * valprint.h (struct value_print_options) <finish_print>: New
3497         member.
3498
3499 2019-05-28  Tom Tromey  <tromey@adacore.com>
3500
3501         * ada-lang.c (ada_remove_Xbn_suffix)
3502         (find_old_style_renaming_symbol)
3503         (parse_old_style_renaming): Remove.
3504         (ada_find_renaming_symbol): Don't call
3505         find_old_style_renaming_symbol.
3506         (ada_is_renaming_symbol): Rename from
3507         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3508         bool.  Now static.
3509         (ada_read_var_value): Update and simplify.
3510         * ada-exp.y (write_var_or_type): Remove old code.
3511
3512 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3513
3514         * event-top.c: Remove include comment.
3515         * inflow.c (class scoped_ignore_sigttou): Move from here...
3516         * inflow.h (class scoped_ignore_sigttou): ...to here.
3517         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3518         * top.c:  Remove include comment.
3519
3520 2019-05-27  Tom Tromey  <tom@tromey.com>
3521
3522         * NEWS: Fix typo.
3523
3524 2019-05-22  Tom Tromey  <tromey@adacore.com>
3525
3526         * target.c (target_follow_exec): Constify parameter.
3527         * target-delegates.c: Rebuild.
3528         * remote.c (remote_target::follow_exec): Constify parameter.
3529         * infrun.c (follow_exec): Constify parameter.
3530         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3531         (target_follow_exec): Likewise.
3532
3533 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3534
3535         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3536         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3537
3538 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3539
3540         * NEWS: Add debugredirect and testsuite sections.
3541
3542 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3543
3544         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3545         target descriptions using exclusively floating point register name
3546         aliases.
3547
3548 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3549
3550         PR gdb/18644:
3551         * f-lang.c (build_fortran_types): Handle the case where
3552         gdbarch_floatformat_for_type returns a nullptr.
3553
3554 2019-05-21  Tom de Vries  <tdevries@suse.de>
3555
3556         PR cli/24587
3557         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3558
3559 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3560
3561         PR gdb/18644:
3562         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3563         16-byte floats.
3564         * i386-tdep.c (i386_floatformat_for_type): Use
3565         floatformats_ia64_quad for the 16-byte floating point component
3566         within a fortran 32-byte complex number.
3567
3568 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3569
3570         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3571         delete default constructor.
3572         (find_partial_die): Update to return const struct.
3573         (partial_die_parent_scope): Move variable declaration into scope
3574         of its use and change its type to auto.
3575         (guess_partial_die_structure_name): Likewise.
3576         (partial_die_info::fixup): Likewise.
3577
3578 2019-05-17  Tom Tromey  <tromey@adacore.com>
3579
3580         * source.c (find_and_open_source): Remove cast.
3581
3582 2019-05-17  Tom Tromey  <tromey@adacore.com>
3583
3584         * annotate.c (annotate_source): Make "filename" const.
3585         * annotate.h (annotate_source): Use const.
3586
3587 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3588
3589         * disasm.c (set_disassembler_options): Send errors to stderr.
3590
3591 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3592
3593         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3594         (cli_interp_base::set_logging): Check debug_redirect.
3595         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3596         * cli/cli-logging.c (debug_redirect): Add static variable.
3597         (pop_output_files): Add default param.
3598         (handle_redirections): Print debug setting.
3599         (show_logging_command): Likewise.
3600         (_initialize_cli_logging): Add debugredirect command.
3601         * interps.c (current_interp_set_logging): Add debug_redirect
3602         parameter.
3603         * interps.h (set_logging): Add debug_redirect parameter.
3604         (current_interp_set_logging): Likewise.
3605         * mi/mi-common.h: Likewise.
3606         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3607
3608 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3609             Tom Tromey  <tromey@adacore.com>
3610
3611         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3612         directly.
3613         * cli/cli-interp.h (make_logging_output): Remove declaration.
3614         * cli/cli-logging.c (make_logging_output): Remove function.
3615         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3616         directly.
3617         * ui-file.c (tee_file::tee_file): Remove bools.
3618         (tee_file::~tee_file): Remove deletes.
3619         * ui-file.h (tee_file): Remove bools.
3620
3621 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3622
3623         * mi/mi-cmds.h (mi_cmd_complete): New function.
3624         * mi/mi-main.c (mi_cmd_complete): Likewise.
3625         * mi/mi-cmds.c: Define new MI command -complete.
3626         * NEWS: Mention new -complete command.
3627
3628 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3629
3630         * completer.h (complete): New function.
3631         * completer.c (complete): Likewise.
3632         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3633         function defined in completer.h.
3634
3635 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3636
3637         * MAINTAINERS (Write After Approval): Add myself.
3638
3639 2019-05-17  Tom de Vries  <tdevries@suse.de>
3640
3641         PR gdb/24094
3642         * dwarf2read.c (struct cu_partial_die_info): New struct.
3643         (find_partial_die): Return cu_partial_die_info.
3644         (partial_die_parent_scope, guess_partial_die_structure_name)
3645         (partial_die_info::fixup): Handle new return type of find_partial_die.
3646
3647 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3648
3649         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3650         "std::string", simplifying the algorithm.
3651
3652 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3653
3654         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3655         (stap_static_probe_ops::get_probes): Likewise.
3656
3657 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3658
3659         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3660         '-')" and "else if".
3661         (stap_parse_single_operand): Join checks for
3662         "gdbarch_stap_parse_special_token_p" and
3663         "gdbarch_stap_parse_special_token" in the same "if" statement.
3664         Invert check when verifying for operation on register
3665         displacement.
3666
3667 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3668
3669         * stap-probe.c (stap_get_opcode): Update comment.
3670         (stap_get_expected_argument_type): Likewise.
3671         (handle_stap_probe): Likewise.
3672
3673 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3674
3675         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3676         return type to 'bool'.  Adjust comment.  Use 'bool' when
3677         appropriate.
3678         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3679         * stap-probe.c (stap_parse_argument_1): Likewise.
3680         (stap_is_operator): Likewise.
3681         (stap_is_generic_prefix): Likewise.
3682         (stap_is_register_prefix): Likewise.
3683         (stap_is_register_indirection_prefix): Likewise.
3684         (stap_is_integer_prefix): Likewise.
3685         (stap_generic_check_suffix): Likewise.
3686         (stap_check_integer_suffix): Likewise.
3687         (stap_check_register_suffix): Likewise.
3688         (stap_check_register_indirection_suffix): Likewise.
3689         (stap_parse_register_operand): Likewise.
3690         (stap_parse_single_operand): Likewise.
3691         (stap_parse_argument_1): Likewise.
3692         (stap_probe::get_argument_count): Likewise.
3693         (stap_is_operator): Likewise.
3694
3695 2019-05-16  Tom Tromey  <tromey@adacore.com>
3696
3697         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3698         keyword to foreach.
3699
3700 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3701
3702         * linux-thread-db.c (try_thread_db_load_1): Change return type
3703         to bool.
3704         (try_thread_db_load): Likewise.
3705         (try_thread_db_load_from_pdir_1): Likewise.
3706         (try_thread_db_load_from_pdir): Likewise.
3707         (try_thread_db_load_from_sdir): Likewise.
3708         (try_thread_db_load_from_dir): Likewise.
3709         (thread_db_load_search): Likewise.
3710         (has_libpthread): Likewise.
3711         (thread_db_load): Likewise.
3712
3713 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3714
3715         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3716         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3717         NULL, and complain/return if that's the case.
3718
3719 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3720
3721         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3722         (advance, posn, abstract_read_memory): New functions.
3723         [struct mem_read_abstraction]: New struct.
3724         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3725
3726 2019-05-14  Tom Tromey  <tromey@adacore.com>
3727
3728         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3729         value is not lval_memory.
3730
3731 2019-05-14  Tom Tromey  <tromey@adacore.com>
3732
3733         * solib.c (info_sharedlibrary_command): Style the file name.
3734
3735 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3736
3737         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3738         (aarch64_vnv_type): Likewise.
3739         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3740         * common/tdesc.c: Likewise.
3741         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3742         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3743         * features/aarch64-fpu.xml: Add ieee half view.
3744         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3745         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3746         * gdbtypes.h (struct builtin_type): Likewise.
3747         (struct objfile_type): Likewise.
3748
3749 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3750
3751         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3752         typo.
3753         * location.h (string_to_event_location): Likewise.
3754
3755 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3756
3757         GDB 8.3 released.
3758
3759 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3760
3761         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3762         New variable declaration.
3763         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3764         New variable.
3765         (print_one_breakpoint): Use ui_out::test_flags and new global
3766         variable to compute use_fixed_output.
3767         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3768         Remove.
3769         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3770         (mi_multi_location_breakpoint_output_fixed): Remove.
3771         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3772         new variable.
3773         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3774         fix_multi_location_breakpoint_output flag if version >= 3.
3775         * ui-out.h (enum ui_out_flag)
3776         <fix_multi_location_breakpoint_output>: New enumerator.
3777
3778 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3779
3780         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3781
3782 2019-05-10  Tom Tromey  <tromey@adacore.com>
3783
3784         * ada-lang.c (catch_ada_completer): New function.
3785         (_initialize_ada_language): Use it.
3786
3787 2019-05-10  Tom Tromey  <tromey@adacore.com>
3788
3789         * thread.c (print_thread_info): Make "requested_threads" const.
3790         * gdbthread.h (print_thread_info): Make "requested_threads"
3791         const.
3792         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3793         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3794
3795 2019-05-08  Tom Tromey  <tom@tromey.com>
3796
3797         * gdbtypes.c (objfile_type_data): Change type.
3798         (objfile_type, _initialize_gdbtypes): Update.
3799
3800 2019-05-08  Tom Tromey  <tom@tromey.com>
3801
3802         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3803         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3804         (_initialize_dwarf2_frame): Update.
3805
3806 2019-05-08  Tom Tromey  <tom@tromey.com>
3807
3808         * objc-lang.c (objc_objfile_data): Change type.
3809         (find_methods): Update.
3810         (_initialize_objc_lang): Remove.
3811
3812 2019-05-08  Tom Tromey  <tom@tromey.com>
3813
3814         * stabsread.c (rs6000_builtin_type_data): Change type.
3815         (rs6000_builtin_type, _initialize_stabsread): Update.
3816
3817 2019-05-08  Tom Tromey  <tom@tromey.com>
3818
3819         * mips-tdep.c (mips_pdr_data): Remove.
3820         (_initialize_mips_tdep): Update.
3821
3822 2019-05-08  Tom Tromey  <tom@tromey.com>
3823
3824         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3825         (hppa_init_objfile_priv_data, read_unwind_info)
3826         (find_unwind_entry, _initialize_hppa_tdep): Update.
3827
3828 2019-05-08  Tom Tromey  <tom@tromey.com>
3829
3830         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3831         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3832         on obstack.
3833         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3834
3835 2019-05-08  Tom Tromey  <tom@tromey.com>
3836
3837         * mdebugread.c (basic_type_data): Change type.
3838         (basic_type, _initialize_mdebugread): Update.
3839
3840 2019-05-08  Tom Tromey  <tom@tromey.com>
3841
3842         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3843
3844 2019-05-08  Tom Tromey  <tom@tromey.com>
3845
3846         * nto-tdep.c (nto_inferior_data_reg): Change type.
3847         (nto_inferior_data): Update.
3848         (nto_inferior_data_cleanup, nto_new_inferior_data)
3849         (_initialize_nto_tdep): Remove.
3850         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3851
3852 2019-05-08  Tom Tromey  <tom@tromey.com>
3853
3854         * ada-lang.c (struct ada_inferior_data): Add initializers.
3855         (ada_inferior_data): Change type.
3856         (ada_inferior_data_cleanup): Remove.
3857         (get_ada_inferior_data, ada_inferior_exit)
3858         (struct ada_pspace_data): Add initializers, destructor.
3859         (ada_pspace_data_handle): Change type.
3860         (get_ada_pspace_data): Update.
3861         (ada_pspace_data_cleanup): Remove.
3862
3863 2019-05-08  Tom Tromey  <tom@tromey.com>
3864
3865         * coffread.c (struct coff_symfile_info): Add initializers.
3866         (coff_objfile_data_key): Move lower.  Change type.
3867         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3868         Update.
3869         (coff_free_info): Remove.
3870
3871 2019-05-08  Tom Tromey  <tom@tromey.com>
3872
3873         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3874         (fbsd_pspace_data_handle): Move lower.  Change type.
3875         (get_fbsd_pspace_data): Update.
3876         (fbsd_pspace_data_cleanup): Remove.
3877         (_initialize_fbsd_tdep): Update.
3878
3879 2019-05-08  Tom Tromey  <tom@tromey.com>
3880
3881         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3882         (get_ada_tasks_pspace_data): Update.
3883         (ada_tasks_pspace_data_cleanup): Remove.
3884         (_initialize_tasks): Update.
3885         (ada_tasks_inferior_data_handle): Change type.
3886         (get_ada_tasks_inferior_data): Update.
3887         (ada_tasks_inferior_data_cleanup): Remove.
3888         (struct ada_tasks_pspace_data): Add initializers.
3889
3890 2019-05-08  Tom Tromey  <tom@tromey.com>
3891
3892         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3893         * symfile-debug.c (debug_sym_get_probes): Change type.
3894         * stap-probe.c (handle_stap_probe):
3895         (stap_static_probe_ops::get_probes): Change type.
3896         * probe.h (class static_probe_ops) <get_probes>: Change type.
3897         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3898         (parse_probes_in_pspace): Update.
3899         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3900         Update.
3901         (any_static_probe_ops::get_probes): Change type.
3902         * elfread.c (elfread_data): New typedef.
3903         (probe_key): Change type.
3904         (elf_get_probes): Likewise.  Update.
3905         (probe_key_free): Remove.
3906         (_initialize_elfread): Update.
3907         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3908         Change type.
3909         (dtrace_process_dof_probe, dtrace_process_dof)
3910         (dtrace_static_probe_ops::get_probe): Change type.
3911
3912 2019-05-08  Tom Tromey  <tom@tromey.com>
3913
3914         * xcoffread.c (struct xcoff_symfile_info): Rename from
3915         coff_symfile_info.  Add initializers.
3916         (xcoff_objfile_data_key): Move lower.  Change type.
3917         (XCOFF_DATA): Rewrite.
3918         (xcoff_free_info): Remove.
3919         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3920         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3921         (xcoff_initial_scan): Update.
3922
3923 2019-05-08  Tom Tromey  <tom@tromey.com>
3924
3925         * solib-svr4.c (struct svr4_info): Add initializers and
3926         destructor.
3927         <probes_table>: Now an htab_up.
3928         (solib_svr4_pspace_data): Change type.
3929         (free_probes_table): Simplify.
3930         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3931         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3932         (probes_table_remove_objfile_probes, register_solib_event_probe)
3933         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3934         (_initialize_svr4_solib): Update.
3935
3936 2019-05-08  Tom Tromey  <tom@tromey.com>
3937
3938         * remote.c (remote_pspace_data): Change type.
3939         (remote_pspace_data_cleanup): Remove.
3940         (get_remote_exec_file, set_pspace_remote_exec_file)
3941         (_initialize_remote): Update.
3942
3943 2019-05-08  Tom Tromey  <tom@tromey.com>
3944
3945         * breakpoint.c (breakpoint_objfile_key): Change type.
3946         (get_breakpoint_objfile_data): Update.
3947         (free_breakpoint_objfile_data): Remove.
3948         (_initialize_breakpoint): Update.
3949
3950 2019-05-08  Tom Tromey  <tom@tromey.com>
3951
3952         * linux-tdep.c (struct linux_info): Add initializers.
3953         (linux_inferior_data): Move.  Change type.
3954         (invalidate_linux_cache_inf): Update.
3955         (linux_inferior_data_cleanup): Remove.
3956         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3957
3958 2019-05-08  Tom Tromey  <tom@tromey.com>
3959
3960         * auxv.c (auxv_inferior_data): Move.  Change type.
3961         (auxv_inferior_data_cleanup): Remove.
3962         (invalidate_auxv_cache_inf): Rewrite.
3963         (get_auxv_inferior_data, _initialize_auxv): Update.
3964
3965 2019-05-08  Tom Tromey  <tom@tromey.com>
3966
3967         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3968         (symfile_debug_objfile_data_key): Change type.
3969         (symfile_debug_installed, debug_qf_has_symbols)
3970         (debug_qf_find_last_source_symtab)
3971         (debug_qf_forget_cached_source_info)
3972         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3973         (debug_qf_print_stats, debug_qf_dump)
3974         (debug_qf_expand_symtabs_for_function)
3975         (debug_qf_expand_all_symtabs)
3976         (debug_qf_expand_symtabs_with_fullname)
3977         (debug_qf_map_matching_symbols)
3978         (debug_qf_expand_symtabs_matching)
3979         (debug_qf_find_pc_sect_compunit_symtab)
3980         (debug_qf_map_symbol_filenames)
3981         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3982         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3983         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3984         (debug_sym_read_linetable, debug_sym_relocate): Update.
3985         (symfile_debug_free_objfile): Remove.
3986         (install_symfile_debug_logging, _initialize_symfile_debug):
3987         Update.
3988
3989 2019-05-08  Tom Tromey  <tom@tromey.com>
3990
3991         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3992         allocate_on_obstack.
3993         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3994         (get_dwarf2_per_objfile): Update.
3995         (set_dwarf2_per_objfile): Remove.
3996         (dwarf2_has_info, dwarf2_get_section_info): Update.
3997         (dwarf2_free_objfile): Remove.
3998         (_initialize_dwarf2_read): Update.
3999
4000 2019-05-08  Tom Tromey  <tom@tromey.com>
4001
4002         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4003         initializers.
4004         <unsupported_script_warning_printed,
4005         script_not_found_warning_printed>: Now bool.
4006         (auto_load_pspace_data): Change type.
4007         (~auto_load_pspace_info): Rename from
4008         auto_load_pspace_data_cleanup.
4009         (get_auto_load_pspace_data, init_loaded_scripts_info)
4010         (clear_section_scripts, maybe_print_unsupported_script_warning)
4011         (maybe_print_script_not_found_warning, _initialize_auto_load):
4012         Update.
4013
4014 2019-05-08  Tom Tromey  <tom@tromey.com>
4015
4016         * objfiles.c (objfile_pspace_info): Add destructor and
4017         initializers.
4018         (objfiles_pspace_data): Change type.
4019         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4020         (get_objfile_pspace_data): Update.
4021         (objfiles_bfd_data): Change type.
4022         (get_objfile_bfd_data): Update.
4023         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4024
4025 2019-05-08  Tom Tromey  <tom@tromey.com>
4026
4027         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4028         Change type.
4029         (get_catch_syscall_inferior_data): Update.
4030         (catch_syscall_inferior_data_cleanup): Remove.
4031         (_initialize_break_catch_syscall): Update.
4032
4033 2019-05-08  Tom Tromey  <tom@tromey.com>
4034
4035         * inflow.c (struct terminal_info): Add destructor and
4036         initializers.
4037         (inflow_inferior_data): Change type.
4038         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4039         (get_inflow_inferior_data, inflow_inferior_exit)
4040         (swap_terminal_info, _initialize_inflow): Update.
4041
4042 2019-05-08  Tom Tromey  <tom@tromey.com>
4043
4044         * target-dcache.c (target_dcache_cleanup): Remove.
4045         (target_dcache_aspace_key): Change type.
4046         (target_dcache_init_p, target_dcache_invalidate)
4047         (target_dcache_get, target_dcache_get_or_init)
4048         (_initialize_target_dcache): Update.
4049         * dcache.h (struct dcache_deleter): New.
4050
4051 2019-05-08  Tom Tromey  <tom@tromey.com>
4052
4053         * symtab.c (struct symbol_cache): Add destructor and
4054         initializers.
4055         (symbol_cache_key): Move.  Change type.
4056         (make_symbol_cache, free_symbol_cache): Remove.
4057         (get_symbol_cache): Update.
4058         (symbol_cache_cleanup): Remove.
4059         (ALL_PSPACES, symbol_cache_flush)
4060         (maintenance_print_symbol_cache)
4061         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4062         Update.
4063
4064 2019-05-08  Tom Tromey  <tom@tromey.com>
4065
4066         * symtab.c (struct main_info): Add destructor and initializers.
4067         (main_progspace_key): Move.  Change type.
4068         (get_main_info): Update.
4069         (main_info_cleanup): Remove.
4070         (_initialize_symtab): Update.
4071
4072 2019-05-08  Tom Tromey  <tom@tromey.com>
4073
4074         * registry.h (DECLARE_REGISTRY): Define the _key class.
4075
4076 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4077
4078         * NEWS: Merge two 'New commands' sections.
4079
4080 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4081
4082         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4083         parameter and use Ada language definition instead.
4084         (ada_val_print_ptr): Remove unused language parameter.
4085         (ada_val_print_num): Remove language parameter and use Ada language
4086         definition instead.
4087         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4088         parameter.
4089         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4090         parameter and use Ada language definition instead.
4091         (ada_val_print_1): Update all ada_val_print_xxx calls.
4092         Remove language parameter.
4093         (ada_val_print): Update ada_val_print_1 call.
4094
4095 2019-05-08  Tom Tromey  <tromey@adacore.com>
4096
4097         * remote.c (remote_hw_watchpoint_limit)
4098         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4099         Now static.
4100
4101 2019-05-08  Tom Tromey  <tromey@adacore.com>
4102
4103         * maint.c (_initialize_maint_cmds): Move initialization code to
4104         remote.c.
4105         (watchdog, show_watchdog): Move to remote.c.
4106         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4107         "watchdog" static.
4108         (_initialize_remote): Move initialization code from maint.c.
4109         * defs.h (watchdog): Don't declare.
4110
4111 2019-05-08  Tom Tromey  <tromey@adacore.com>
4112
4113         * tui/tui-interp.c: Include main.h.
4114         * interps.c: Include main.h.
4115         * main.h (interpreter_p): Declare.
4116         * defs.h (interpreter_p): Don't declare.
4117
4118 2019-05-08  Tom Tromey  <tromey@adacore.com>
4119
4120         * dwarf2loc.c: Include dwarf2read.h.
4121         * defs.h (read_unsigned_leb128): Don't declare.
4122         * dwarf2read.h (read_unsigned_leb128): Declare.
4123
4124 2019-05-08  Tom Tromey  <tromey@adacore.com>
4125
4126         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4127         method.
4128
4129 2019-05-08  Tom Tromey  <tromey@adacore.com>
4130
4131         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4132         when no wrap column is set.
4133
4134 2019-05-08  Tom Tromey  <tromey@adacore.com>
4135
4136         * c-lang.c (c_get_string): Handle non-C-style arrays.
4137
4138 2019-05-08  Tom Tromey  <tromey@adacore.com>
4139
4140         * typeprint.c (print_offset_data::update): Print the bit offset,
4141         not the number of bits remaining.
4142
4143 2019-05-08  Tom Tromey  <tromey@adacore.com>
4144
4145         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4146         padding at end of comment.
4147
4148 2019-05-08  Tom Tromey  <tromey@adacore.com>
4149
4150         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4151         Compare main types.
4152
4153 2019-05-06  Tom Tromey  <tom@tromey.com>
4154
4155         * common/scoped_mmap.c: Include common-defs.h.
4156         * common/scoped_mmap.h: Don't include config.h.
4157
4158 2019-05-04  Tom Tromey  <tom@tromey.com>
4159
4160         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4161         (struct aarch64_call_info): Add initializers.
4162         <si>: Now a std::vector.
4163         (pass_on_stack, aarch64_push_dummy_call): Update.
4164
4165 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4166             Tom Tromey  <tom@tromey.com>
4167
4168         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4169         (ppc_threads): Now a std::vector.  Now static.
4170         (hwdebug_find_thread_points_by_tid)
4171         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4172         Update.
4173
4174 2019-05-04  Tom Tromey  <tom@tromey.com>
4175
4176         * arc-tdep.c (arc_tdesc_init): Return bool.
4177
4178 2019-05-04  Tom Tromey  <tom@tromey.com>
4179
4180         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4181         Use gdb_assert_not_reached.
4182
4183 2019-05-04  Tom Tromey  <tom@tromey.com>
4184
4185         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4186         "false".
4187
4188 2019-05-04  Tom Tromey  <tom@tromey.com>
4189
4190         * arc-tdep.c (arc_tdesc_init): Use bool.
4191
4192 2019-05-04  Tom Tromey  <tom@tromey.com>
4193
4194         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4195
4196 2019-05-04  Tom Tromey  <tom@tromey.com>
4197
4198         * cli/cli-cmds.c (valid_command_p): Return bool.
4199
4200 2019-05-04  Tom Tromey  <tom@tromey.com>
4201
4202         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4203         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4204
4205 2019-05-04  Raul Tambre  <raul@tambre.ee>
4206
4207         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4208         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4209         operator for comparison.
4210
4211 2019-05-04  Tom Tromey  <tom@tromey.com>
4212
4213         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4214         (lookup_partial_symbol, print_partial_symbols)
4215         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4216         (psymbol_compare): Update.
4217         (add_psymbol_to_bcache): Clear the entire psymbol.
4218         (maintenance_check_psymtabs): Update.
4219         * psympriv.h (struct partial_symbol): Don't derive from
4220         general_symbol_info.
4221         <obj_section, unrelocated_address, address,
4222         set_unrelocated_address>: Update.
4223         <ginfo>: New member.
4224         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4225         (debug_names::write_psymbols): Update.
4226
4227 2019-05-04  Tom de Vries  <tdevries@suse.de>
4228
4229         * contrib/cc-with-tweaks.sh: Support -n arg.
4230
4231 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4232
4233         * corelow.c (core_target::detach): Ensure frame cache and
4234         register caches are cleared.
4235         inferior.c (exit_inferior_1): Likewise.
4236
4237 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4238             Tom Tromey  <tom@tromey.com>
4239
4240         * dictionary.c (collate_pending_symbols_by_language): Remove
4241         "struct" from foreach.
4242         * symtab.c (lookup_global_symbol_from_objfile)
4243         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4244         foreach.
4245         * ser-tcp.c (net_open): Remove "struct" from foreach.
4246         * objfiles.c (objfile_relocate, objfile_rebase)
4247         (objfile_has_symbols): Remove "struct" from foreach.
4248         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4249         from foreach.
4250         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4251         foreach.
4252         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4253         "struct" from foreach.
4254         * ada-lang.c (create_excep_cond_exprs)
4255         (ada_exception_catchpoint_cond_string): Remove "struct" from
4256         foreach.
4257
4258 2019-05-03  Tom Tromey  <tromey@adacore.com>
4259
4260         * ada-exp.y (convert_char_literal): Check suffix of each
4261         enumerator.
4262
4263 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4264
4265         PR ada/21406:
4266         * ada-exp.y (yywrap): Don't define.
4267         * ada-lex.l (%option): Add noyywrap
4268         (yywrap): Remove.
4269
4270 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4271
4272         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4273         _WIN32_WINNT to the XP level, unless already defined to a higher
4274         level.
4275
4276         * unittests/parse-connection-spec-selftests.c:
4277         * ser-tcp.c:
4278         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4279         override.
4280
4281         * symfile.c (find_separate_debug_file): Remove colon from the
4282         drive spec of DOS/Windows file names of the target, so that the
4283         file name produced from DEBUGDIR and the target's directory will
4284         be valid on DOS/Windows systems.
4285
4286 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4287
4288         * rust-lang.c (val_print_struct): Handle printing structures
4289         containing strings.
4290
4291 2019-05-02  Tom Tromey  <tromey@adacore.com>
4292
4293         * valarith.c (_initialize_valarith): Remove.
4294
4295 2019-05-01  Tom Tromey  <tromey@adacore.com>
4296
4297         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4298         bitfields.
4299
4300 2019-05-01  Tom Tromey  <tromey@adacore.com>
4301
4302         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4303         for big-endian copies.
4304
4305 2019-04-30  Ali Tamur  <tamur@google.com>
4306         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4307         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4308         (read_3_bytes): New function.
4309
4310 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4311
4312         * windows-nat.c (main_thread_id): Delete.
4313         (handle_output_debug_string): Replace main_thread_id by
4314         current_event.dwThreadId.
4315         (fake_create_process): Likewise.
4316         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4317         Do not set main_thread_id.
4318         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4319         current_event.dwThreadId.
4320         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4321
4322 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4323
4324         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4325         Use current_event.dwThreadId instead of main_thread_id.
4326
4327 2019-04-30  Tom Tromey  <tromey@adacore.com>
4328
4329         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4330         (create_excep_cond_exprs): Iterate over program spaces.
4331         (ada_exception_catchpoint_cond_string): Examine all minimal
4332         symbols for exception types.
4333
4334 2019-04-30  Tom Tromey  <tromey@adacore.com>
4335
4336         PR c++/24470:
4337         * dwarf2read.c (process_structure_scope): Handle case where type
4338         has template parameters but no symbol was created.
4339
4340 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4341             Chris January  <chris.january@arm.com>
4342
4343         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4344         qualifier.
4345         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4346
4347 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4348
4349         * f-typeprint.c (f_print_type): Update rules for printing
4350         whitespace.
4351         (f_type_print_varspec_suffix): Likewise.
4352
4353 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4354             Chris January  <chris.january@arm.com>
4355
4356         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4357         function arguments.
4358
4359 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4360
4361         * f-lang.c (build_fortran_types): Change name of void type to
4362         lower case.
4363         * f-typeprint.c (f_type_print_base): Print the name of the void
4364         type, rather than a fixed string.
4365         * f-valprint.c (f_decorations): Use lower case void string.
4366
4367 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4368             Chris January  <chris.january@arm.com>
4369
4370         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4371         types for Fortran.
4372
4373 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4374             Chris January  <chris.january@arm.com>
4375             David Lecomber  <david.lecomber@arm.com>
4376
4377         * f-exp.y (BINOP_INTRINSIC): New token.
4378         (exp): New parser rule handling BINOP_INTRINSIC.
4379         (f77_keywords): Add new builtin procedures.
4380         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4381         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4382         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4383         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4384         (print_unop_subexp_f): New function.
4385         (print_binop_subexp_f): New function.
4386         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4387         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4388         (dump_subexp_body_f): Likewise.
4389         (operator_check_f): Likewise.
4390         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4391         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4392
4393 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4394
4395         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4396         UNOP_KIND.
4397         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4398         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4399         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4400         (operator_length_f): New fuction.
4401         (print_subexp_f): New function.
4402         (op_name_f): New function.
4403         (dump_subexp_body_f): New function.
4404         (operator_check_f): New function.
4405         (exp_descriptor_f): Replace standard expression handling functions
4406         with new functions.
4407         * gdb/fortran-operator.def: New file.
4408         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4409         * gdb/std-operator.def: Remove UNOP_KIND.
4410
4411 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4412
4413         * std-operator.def: Remove unbalanced, stray double quote
4414         character.
4415
4416 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4417             Chris January  <chris.january@arm.com>
4418             Daniel Everett  <daniel.everett@arm.com>
4419             Nick Forrington  <nick.forrington@arm.com>
4420             Richard Bunt  <richard.bunt@arm.com>
4421
4422         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4423         of depth when printing anonymous structs or unions.
4424         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4425         Don't print either the top-level value, or the children if the
4426         max-depth is exceeded.
4427         (ppscm_print_children): When printing the key of a map, allow one
4428         extra level of depth.
4429         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4430         print either the top-level value, or the children if the max-depth
4431         is exceeded.
4432         (print_children): When printing the key of a map, allow one extra
4433         level of depth.
4434         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4435         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4436         (user_print_options): Initialise max_depth field.
4437         (val_print_scalar_or_string_type_p): New function.
4438         (val_print): Check to see if the max depth has been reached.
4439         (val_print_check_max_depth): Define new function.
4440         (show_print_max_depth): New function.
4441         (_initialize_valprint): Add 'print max-depth' option.
4442         * valprint.h (struct value_print_options) <max_depth>: New field.
4443         (val_print_check_max_depth): Declare new function.
4444         * NEWS: Document new feature.
4445
4446 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4447
4448         * ada-lang.c (ada_language_defn): Initialise new field.
4449         * c-lang.c (c_is_string_type_p): New function.
4450         (c_language_defn): Initialise new field.
4451         (cplus_language_defn): Initialise new field.
4452         (asm_language_defn): Initialise new field.
4453         (minimal_language_defn): Initialise new field.
4454         * c-lang.h (c_is_string_type_p): Declare new function.
4455         * d-lang.c (d_language_defn): Initialise new field.
4456         * f-lang.c (f_is_string_type_p): New function.
4457         (f_language_defn): Initialise new field.
4458         * go-lang.c (go_is_string_type_p): New function.
4459         (go_language_defn): Initialise new field.
4460         * language.c (default_is_string_type_p): New function.
4461         (unknown_language_defn): Initialise new field.
4462         (auto_language_defn): Initialise new field.
4463         * language.h (struct language_defn) <la_is_string_type_p>: New
4464         member variable.
4465         (default_is_string_type_p): Declare new function.
4466         * m2-lang.c (m2_language_defn): Initialise new field.
4467         * objc-lang.c (objc_language_defn): Initialise new field.
4468         * opencl-lang.c (opencl_language_defn): Initialise new field.
4469         * p-lang.c (pascal_is_string_type_p): New function.
4470         (pascal_language_defn): Initialise new field.
4471         * rust-lang.c (rust_is_string_type_p): New function.
4472         (rust_language_defn): Initialise new field.
4473
4474 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4475
4476         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4477         New field.
4478         * ada-lang.c (ada_language_defn): Initialise new field.
4479         * c-lang.c (c_language_defn): Likewise.
4480         (cplus_language_defn): Likewise.
4481         (asm_language_defn): Likewise.
4482         (minimal_language_defn): Likewise.
4483         * d-lang.c (d_language_defn): Likewise.
4484         * f-lang.c (f_language_defn): Likewise.
4485         * go-lang.c (go_language_defn): Likewise.
4486         * language.c (unknown_language_defn): Likewise.
4487         (auto_language_defn): Likewise.
4488         * m2-lang.c (m2_language_defn): Likewise.
4489         * objc-lang.c (objc_language_defn): Likewise.
4490         * opencl-lang.c (opencl_language_defn): Likewise.
4491         * p-lang.c (pascal_language_defn): Likewise.
4492         * rust-lang.c (rust_language_defn): Likewise.
4493
4494 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4495
4496         * ada-lang.c (ada_is_character_type): Change return type to bool.
4497         (ada_is_string_type): Likewise.
4498         * ada-lang.h (ada_is_character_type): Update declaration
4499         (ada_is_string_type): Likewise.
4500
4501 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4502
4503         Support style in 'frame|thread apply'
4504
4505         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4506         * record.c (record_start, record_stop): Update callers of
4507         execute_command_to_string with false.
4508         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4509         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4510         methods.
4511         (class string_file): New constructor with term_out parameter.
4512         Override methods term_out and can_emit_style_escape.  New member
4513         term_out.
4514         (class stdio_file): Override can_emit_style_escape.
4515         (class tee_file): Override term_out and can_emit_style_escape.
4516         * utils.h (can_emit_style_escape): Remove.
4517         * utils.c (can_emit_style_escape): Likewise.
4518         Update all callers of can_emit_style_escape (SOMESTREAM) to
4519         SOMESTREAM->can_emit_style_escape.
4520         * source-cache.c (source_cache::get_source_lines): Likewise.
4521         * stack.c (frame_apply_command_count): Call execute_command_to_string
4522         passing the term_out characteristic of the current gdb_stdout.
4523         * thread.c (thr_try_catch_cmd): Likewise.
4524         * top.c (execute_command_to_string): pass term_out parameter
4525         to construct the string_file for the command output.
4526         * ui-file.c (term_cli_styling): New function (most code moved
4527         from utils.c can_emit_style_escape).
4528         (string_file::string_file, string_file::can_emit_style_escape,
4529         stdio_file::can_emit_style_escape, tee_file::term_out,
4530         tee_file::can_emit_style_escape): New functions.
4531
4532 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4533
4534         * NEWS: Mention the new set|show may-call-functions.
4535         * infcall.c (may_call_functions_p): New variable.
4536         (show_may_call_functions_p): New function.
4537         (call_function_by_hand_dummy): Throws an error if not
4538         may-call-functions.
4539         (_initialize_infcall): Call add_setshow_boolean_cmd for
4540         may-call-functions.
4541
4542 2019-04-25  Keith Seitz  <keiths@redhat.com>
4543
4544         PR c++/24367
4545         * cp-support.c (inspect_type): Don't attempt substitutions
4546         of symbol with the same name.
4547
4548 2019-04-25  Tom Tromey  <tromey@adacore.com>
4549
4550         PR gdb/24475:
4551         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4552         static.
4553
4554 2019-04-25  Tom Tromey  <tromey@adacore.com>
4555
4556         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4557         rvalue reference.
4558         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4559         (gdb_xml_parser::parse): Use std::move.
4560         * python/python-internal.h (gdbpy_convert_exception): Take a const
4561         reference.
4562         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4563         std::move.
4564         * python/py-utils.c (gdbpy_convert_exception): Take a const
4565         reference.
4566         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4567         Use std::move.
4568         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4569         Use std::move.
4570         * mi/mi-main.c (mi_print_exception): Take a const reference.
4571         * main.c (handle_command_errors): Take a const reference.
4572         * linespec.c (parse_linespec): Use std::move.
4573         * infcall.c (run_inferior_call): Use std::move.
4574         (call_function_by_hand_dummy): Use std::move.
4575         * exec.c (try_open_exec_file): Use std::move.
4576         * exceptions.h (exception_print, exception_fprintf)
4577         (exception_print_same): Update.
4578         * exceptions.c (print_exception, exception_print)
4579         (exception_fprintf, exception_print_same): Change parameters to
4580         const reference.
4581         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4582         * common/new-op.c: Use std::move.
4583         * common/common-exceptions.h (struct gdb_exception): Add move
4584         constructor.
4585         (struct gdb_exception_error, struct gdb_exception_quit, struct
4586         gdb_quit_bad_alloc): Change constructor to move constructor.
4587         (throw_exception): Change parameter to rvalue reference.
4588         * common/common-exceptions.c (throw_exception): Take rvalue
4589         reference.
4590         * cli/cli-interp.c (safe_execute_command): Use std::move.
4591         * breakpoint.c (insert_bp_location, location_to_sals): Use
4592         std::move.
4593
4594 2019-04-25  Tom Tromey  <tromey@adacore.com>
4595
4596         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4597         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4598         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4599         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4600         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4601         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4602         guile/scm-value.c: Use unpack.
4603         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4604         gdbscm_gdb_exception.
4605         (gdbscm_throw_gdb_exception): Likewise.
4606         (struct gdbscm_gdb_exception): New.
4607         (unpack): New function.
4608         (gdbscm_wrap): Use unpack.
4609
4610 2019-04-25  Tom Tromey  <tromey@adacore.com>
4611
4612         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4613         (gdb_rl_callback_handler): Use std::move.
4614         * common/common-exceptions.h (struct gdb_exception): Add move
4615         assignment operator.
4616         (throw_exception_sjlj): Change "exception" to const reference.
4617         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4618         (throw_exception_sjlj): Change "exception" to const reference.
4619
4620 2019-04-25  Tom Tromey  <tromey@adacore.com>
4621
4622         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4623         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4624         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4625         Update.
4626         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4627         Update.
4628         * mi/mi-interp.c (mi_interp::exec): Update.
4629         * linespec.c (parse_linespec): Update.
4630         * infcall.c (run_inferior_call): Update.
4631         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4632         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4633         (gdbscm_lookup_global_symbol): Update.
4634         * guile/scm-param.c (gdbscm_parameter_value): Update.
4635         * guile/scm-frame.c (gdbscm_frame_read_register)
4636         (gdbscm_frame_read_var): Update.
4637         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4638         * exec.c (try_open_exec_file): Update.
4639         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4640         (gdb_rl_callback_handler): Update.
4641         * common/common-exceptions.h (exception_none): Don't declare.
4642         * common/common-exceptions.c (exception_none): Don't define.
4643         (struct catcher) <exception>: Update.
4644         * cli/cli-interp.c (safe_execute_command): Update.
4645         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4646
4647 2019-04-25  Ali Tamur  <tamur@google.com>
4648
4649         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4650         (read_attribute_value): Likewise.
4651         (dwarf2_read_addr_index): Update comment.
4652         (read_str_index): Add DW_FORM_strx.
4653         (dwarf2_string_attr): Likewise.
4654         (dwarf2_const_value_attr): Likewise.
4655         (dump_die_shallow): Likewise.
4656         (dwarf2_fetch_constant_bytes): Likewise.
4657         (skip_form_bytes): Likewise.
4658         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4659
4660 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4661
4662         PR corefiles/11608
4663         PR corefiles/18187
4664         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4665         OFFSET.  Verify if current mapping contains an ELF header.
4666         (linux_find_memory_regions_full): Adjust call to
4667         dump_mapping_p.
4668
4669 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4670             Kang Li <kanglictf@gmail.com>
4671
4672         PR gdb/21600
4673
4674         * dwarf2-frame.c (read_initial_length): Be consistent about using
4675         unsigned representation of length.
4676         (decode_frame_entry_1): Likewise.  Check for wraparound of
4677         end pointer as well as buffer overflow.
4678
4679 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4680
4681         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4682         "vq".
4683
4684 2019-04-24  Tom Tromey  <tromey@adacore.com>
4685
4686         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4687
4688 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4689
4690         * s12z-tdep.c (s12z_unwind_pc): Delete.
4691         (s12z_unwind_sp): Delete.
4692         (s12z_gdbarch_init): Don't register deleted functions with
4693         gdbarch.
4694
4695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4696
4697         * rl78-tdep.c (rl78_unwind_sp): Delete.
4698         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4699
4700 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4701
4702         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4703         (xstormy16_unwind_pc): Delete.
4704         (xstormy16_dummy_id): Delete.
4705         (xstormy16_gdbarch_init): Don't register deleted functions with
4706         gdbarch.
4707
4708 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * vax-tdep.c (vax_unwind_pc): Delete.
4711         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4712
4713 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4714
4715         * v850-tdep.c (v850_unwind_sp): Delete.
4716         (v850_unwind_pc): Delete.
4717         (v850_dummy_id): Delete.
4718         (v850_gdbarch_init): Don't register deleted functions with
4719         gdbarch.
4720
4721 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4722
4723         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4724         (tilegx_unwind_pc): Delete.
4725         (tilegx_unwind_dummy_id): Delete.
4726         (tilegx_gdbarch_init): Don't register deleted functions with
4727         gdbarch.
4728
4729 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4730
4731         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4732         (tic6x_dummy_id): Delete.
4733         (tic6x_gdbarch_init): Don't register deleted functions with
4734         gdbarch.
4735
4736 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4737
4738         * sparc-tdep.c (sparc_unwind_pc): Delete.
4739         (sparc32_gdbarch_init): Don't register deleted function with
4740         gdbarch.
4741
4742 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4743
4744         * sh-tdep.c (sh_unwind_sp): Delete.
4745         (sh_unwind_pc): Delete.
4746         (sh_dummy_id): Delete.
4747         (sh_gdbarch_init): Don't register deleted functions with
4748         gdbarch.
4749
4750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4751
4752         * score-tdep.c (score_unwind_sp): Delete.
4753         (score_unwind_pc): Delete.
4754         (score_dummy_id): Delete.
4755         (score_gdbarch_init): Don't register deleted functions with
4756         gdbarch.
4757
4758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4759
4760         * rx-tdep.c (rx_unwind_pc): Delete.
4761         (rx_unwind_sp): Delete.
4762         (rx_dummy_id): Delete.
4763         (rx_gdbarch_init): Don't register deleted functions with
4764         gdbarch.  Update comment.
4765
4766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4767
4768         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4769         (rs6000_dummy_id): Delete.
4770         (rs6000_gdbarch_init): Don't register deleted functions with
4771         gdbarch.
4772
4773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4774
4775         * or1k-tdep.c (or1k_dummy_id): Delete.
4776         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4777
4778 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4779
4780         * nios2-tdep.c (nios2_dummy_id): Delete.
4781         (nios2_unwind_sp): Delete.
4782         (nios2_gdbarch_init): Don't register deleted functions with
4783         gdbarch.
4784
4785 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4786
4787         * nds32-tdep.c (nds32_dummy_id): Delete.
4788         (nds32_unwind_pc): Delete.
4789         (nds32_unwind_sp): Delete.
4790         (nds32_gdbarch_init): Don't register deleted functions with
4791         gdbarch.
4792
4793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4794
4795         * msp430-tdep.c (msp430_unwind_pc): Delete.
4796         (msp430_unwind_sp): Delete.
4797         (msp430_dummy_id): Delete.
4798         (msp430_gdbarch_init): Don't register deleted functions with
4799         gdbarch.
4800
4801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4802
4803         * moxie-tdep.c (moxie_unwind_sp): Delete.
4804         (moxie_unwind_pc): Delete.
4805         (moxie_dummy_id): Delete.
4806         (moxie_gdbarch_init): Don't register deleted functions with
4807         gdbarch.
4808
4809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4810
4811         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4812         (mn10300_unwind_pc): Delete.
4813         (mn10300_unwind_sp): Delete.
4814         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4815         mn10300_unwind_sp.
4816         (mn10300_frame_unwind_init): Don't register deleted functions with
4817         gdbarch.
4818
4819 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4820
4821         * mep-tdep.c (mep_unwind_pc): Delete.
4822         (mep_unwind_sp): Delete.
4823         (mep_dummy_id): Delete.
4824         (mep_gdbarch_init): Don't register deleted functions with
4825         gdbarch.
4826
4827 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4828
4829         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4830         (m68hc11_unwind_sp): Delete.
4831         (m68hc11_gdbarch_init): Don't register deleted functions with
4832         gdbarch.
4833
4834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4835
4836         * m32r-tdep.c (m32r_unwind_sp): Delete.
4837         (m32r_unwind_pc): Delete.
4838         (m32r_dummy_id): Delete.
4839         (m32r_gdbarch_init): Don't register deleted functions with
4840         gdbarch.
4841
4842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4843
4844         * m32c-tdep.c (m32c_unwind_pc): Delete.
4845         (m32c_unwind_sp): Delete.
4846         (m32c_dummy_id): Delete.
4847         (m32c_gdbarch_init): Don't register deleted functions with
4848         gdbarch.
4849
4850 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4851
4852         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4853         (lm32_unwind_pc): Delete.
4854         (lm32_dummy_id): Delete.
4855         (lm32_gdbarch_init): Don't register deleted functions with
4856         gdbarch.
4857
4858 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4859
4860         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4861         (iq2000_unwind_pc): Delete.
4862         (iq2000_dummy_id): Delete.
4863         (iq2000_gdbarch_init): Don't register deleted functions with
4864         gdbarch.
4865
4866 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4867
4868         * nds32-tdep.c (nds32_type_align): Delete.
4869         (nds32_push_dummy_call): Use type_align instead.
4870
4871 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4872
4873         * arm-tdep.c (arm_type_align): Only handle vector override case.
4874         (arm_push_dummy_call): Use type_align.
4875         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4876
4877 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4878
4879         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4880         case.
4881         (pass_on_stack): Use type_align.
4882         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4883         function.
4884
4885 2019-04-23  Tom Tromey  <tromey@adacore.com>
4886
4887         * dwarf2read.c (line_header::file_name_at): Remove unused
4888         overload.
4889
4890 2019-04-23  Tom de Vries  <tdevries@suse.de>
4891
4892         PR gdb/24438
4893         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4894         invocation.
4895
4896
4897 2019-03-27  Ali Tamur  <tamur@google.com>
4898
4899         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4900         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4901         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4902         (dwarf_expr_context::get_addr_index): Likewise
4903         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4904         (symbol_needs_eval_context::get_addr_index): Likewise
4905         (disassemble_dwarf_expression): Add DW_OP_addrx
4906         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4907         (read_cutu_die_from_dwo): Update comment
4908         (skip_one_die): Add DW_FORM_addrx
4909         (read_attribute_value): Likewise
4910         (var_decode_location): Add DW_OP_addrx
4911         (dwarf2_const_value_attr): Add DW_FORM_addrx
4912         (dump_die_shallow): Likewise
4913         (dwarf2_fetch_constant_bytes): Likewise
4914         (decode_locdesc): Add DW_OP_addrx
4915         (skip_form_bytes): Add DW_FORM_addrx
4916
4917 2019-04-22  Ali Tamur  <tamur@google.com>
4918
4919         * MAINTAINERS (Write After Approval): Add self.
4920
4921 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4922
4923         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4924         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4925         (open_symbol_file_object): Likewise.
4926         (svr4_default_sos): Add info parameter.
4927         (svr4_read_so_list): Likewise.
4928         (svr4_current_sos_direct): Adjust functions calls to pass down
4929         info.
4930         (svr4_current_sos_1): Add info parameter.
4931         (svr4_current_sos): Call get_svr4_info, pass info down to
4932         svr4_current_sos_1.
4933         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4934         get_svr4_info.
4935         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4936         get_svr4_info.
4937         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4938         to get_svr4_info.
4939         (probes_table_remove_objfile_probes): Likewise.
4940         (register_solib_event_probe): Add info parameter.
4941         (solist_update_incremental): Pass info parameter down to
4942         svr4_read_so_list.
4943         (disable_probes_interface): Add info parameter.
4944         (svr4_handle_solib_event): Pass current_program_space to
4945         get_svr4_info.  Adjust disable_probes_interface cleanup.
4946         (svr4_create_probe_breakpoints): Add info parameter, pass it
4947         down to register_solib_event_probe.
4948         (svr4_create_solib_event_breakpoints): Add info parameter,
4949         pass it down to svr4_create_probe_breakpoints.
4950         (enable_break): Pass info down to
4951         svr4_create_solib_event_breakpoints.
4952         (svr4_solib_create_inferior_hook): Pass current_program_space to
4953         get_svr4_info.
4954         (svr4_clear_solib): Likewise.
4955
4956 2019-04-22  Pedro Alves  <palves@redhat.com>
4957
4958         * solib-svr4.c (svr4_free_objfile_observer): New.
4959         (probe_and_action::objfile): New field.
4960         (probes_table_htab_remove_objfile_probes)
4961         (probes_table_remove_objfile_probes): New functions.
4962         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4963         in the new probe_and_action.  Don't store the probe in 'lookup'.
4964         (svr4_create_probe_breakpoints): Pass objfile to
4965         register_solib_event_probe.
4966         (_initialize_svr4_solib): Register a free_objfile observer.
4967
4968 2019-04-19  Tom Tromey  <tom@tromey.com>
4969
4970         * common/queue.h: Remove.
4971
4972 2019-04-19  Tom Tromey  <tom@tromey.com>
4973
4974         * event-loop.c: Don't include "common/queue.h".
4975
4976 2019-04-19  Tom Tromey  <tom@tromey.com>
4977
4978         * remote.c (remote_target): Use delete.
4979         * remote-notif.h: Include <list>, not "common/queue.h".
4980         (notif_client_p): Remove typedef.
4981         (remote_notif_state): Add constructor, destructor, initializer.
4982         <notif_queue>: Now a std::list.
4983         (remote_notif_state_xfree): Don't declare.
4984         * remote-notif.c (remote_notif_process, handle_notification)
4985         (remote_notif_state_allocate): Update.
4986         (~remote_notif_state): Rename from remote_notif_state_xfree.
4987
4988 2019-04-19  Tom Tromey  <tom@tromey.com>
4989
4990         * symfile.c (reread_symbols): Update.
4991         * objfiles.c (objfile_register_static_link)
4992         (objfile_lookup_static_link): Update
4993         (~objfile) Don't delete static_links.
4994         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4995
4996 2019-04-19  Tom Tromey  <tom@tromey.com>
4997
4998         * type-stack.h (struct type_stack) <insert>: Constify string.
4999         * type-stack.c (type_stack::insert): Constify string.
5000         * gdbtypes.h (lookup_template_type): Update.
5001         (address_space_name_to_int): Update.
5002         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5003         const.
5004         (lookup_template_type): Make name const.
5005         * c-exp.y: Update rules.
5006         (lex_one_token, classify_name, classify_inner_name)
5007         (c_print_token): Update.
5008         * p-exp.y: Update rules.
5009         (yylex): Update.
5010         * f-exp.y: Update rules.
5011         (yylex): Update.
5012         * d-exp.y: Update rules.
5013         (lex_one_token, classify_name, classify_inner_name): Update.
5014         * parse.c (write_dollar_variable, copy_name): Return std::string.
5015         * parser-defs.h (copy_name): Change return type.
5016         * m2-exp.y: Update rules.
5017         (yylex): Update.
5018         * go-exp.y (lex_one_token): Update.
5019         Update rules.
5020         (classify_unsafe_function, classify_packaged_name)
5021         (classify_name, yylex): Update.
5022
5023 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5024
5025         * configure.ac: add --enable-source-highlight switch.
5026         * configure: Regenerate.
5027         * top.c (print_gdb_version): plumb --enable-source-highlight
5028         status to "show configuration".
5029
5030 2019-04-19  Tom Tromey  <tromey@adacore.com>
5031
5032         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5033         Check ADA_TYPE_P.
5034         (empty_record, ada_template_to_fixed_record_type_1)
5035         (template_to_static_fixed_type)
5036         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5037         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5038         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5039         macros.
5040
5041 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5042
5043         PR symtab/24423:
5044         * source.c (print_source_lines_base): Advance "iter" when a
5045         control character is seen.
5046
5047 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5048
5049         * inferior.h (struct infcall_suspend_state_deleter):
5050         Catch exception in destructor to avoid crash.
5051
5052 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5053
5054         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5055         close to the add_com "shell".
5056
5057 2019-04-18  Tom Tromey  <tromey@adacore.com>
5058
5059         * process-stratum-target.h (class process_stratum_target)
5060         <stratum>: Add "final".
5061
5062 2019-04-17  Tom Tromey  <tromey@adacore.com>
5063
5064         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5065         against nullptr before use.
5066
5067 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5068
5069         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5070
5071 2019-04-17  Jim Wilson  <jimw@sifive.com>
5072             Andrew Burgess  <andrew.burgess@embecosm.com>
5073
5074         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5075         code read might fail, assume 4-byte breakpoint in that case.
5076
5077 2019-04-15  Leszek Swirski  <leszeks@google.com>
5078
5079         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5080         rather than a hand-rolled POD check when checking for forced MEMORY
5081         classification.
5082
5083 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5084
5085         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5086         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5087         function.
5088         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5089         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5090         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5091         declaration.
5092
5093 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5094
5095         * aarch64-linux-nat.c
5096         (aarch64_linux_nat_target::thread_architecture): Add override.
5097         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5098         each VQ.
5099
5100 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5101
5102         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5103
5104 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5105
5106         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5107         target types of size 96-bits, add some additional comments, and
5108         check that the builtin type we found was the correct size.
5109
5110 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5111
5112         * utils.c (prompt_for_continue): Don't restore the styling at the
5113         end, as applied_style has the wrong value.  This fixes styling in
5114         long lists of file names that are interrupted by the "Continue?"
5115         prompt.
5116
5117 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5118
5119         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5120         * c-lang.c (c_language_defn): Likewise.
5121         (cplus_language_defn): Likewise.
5122         (asm_language_defn): Likewise.
5123         (minimal_language_defn): Likewise.
5124         * d-lang.c (d_language_defn): Likewise.
5125         * f-lang.c (f_language_defn): Likewise.
5126         * go-lang.c (go_language_defn): Likewise.
5127         * language.c (unknown_language_defn): Likewise.
5128         (auto_language_defn): Likewise.
5129         * language.h (struct language_defn): Remove la_magic field.
5130         (LANG_MAGIC): Delete.
5131         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5132         * objc-lang.c (objc_language_defn): Likewise.
5133         * opencl-lang.c (opencl_language_defn): Likewise.
5134         * p-lang.c (pascal_language_defn): Likewise.
5135         * rust-lang.c (rust_language_defn): Likewise.
5136
5137 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5138
5139         * riscv-tdep.c (riscv_type_align): New function.
5140         (riscv_type_alignment): Delete.
5141         (riscv_arg_location): Use 'type_align'.
5142         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5143
5144 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * gdbtypes.c (type_align): A struct with no non-static fields also
5147         has alignment of 1.
5148
5149 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5150
5151         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5152         component to 0.
5153         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5154         member.
5155         (riscv_struct_info::analyse): New implementation using new
5156         analyse_inner member function.
5157         (riscv_struct_info::field_offset): New member function.
5158         (riscv_struct_info::m_offsets): New member variable.
5159         (riscv_struct_info::analyse_inner): New private member function,
5160         takes the old implementation of riscv_struct_info::analyse but
5161         extended to track field offsets.
5162         (riscv_call_arg_struct): Update the struct folding special cases
5163         to handle cases where empty C++ structs, which are non-zero
5164         length, are found.
5165         (riscv_arg_location): Initialise the length of each location, a
5166         non-zero length now indicates the location is in use.
5167         (riscv_push_dummy_call): Allow for the first location having a
5168         non-zero offset when setting up arguments.
5169         (riscv_return_value): Likewise, but for return values.
5170
5171 2019-04-11  Tom Tromey  <tromey@adacore.com>
5172
5173         * utils.c (internal_vproblem): Make "msg" const.
5174
5175 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5176
5177         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5178         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5179         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5180         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5181
5182 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5183
5184         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5185         function.
5186         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5187         of amd64_collect_native_gregset.
5188         (amd64_linux_nat_target::store_registers): Likewise.
5189
5190 2019-04-10  Tom Tromey  <tom@tromey.com>
5191
5192         * symtab.c (lookup_global_symbol_from_objfile)
5193         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5194         * objfiles.h (class separate_debug_iterator): New.
5195         (class separate_debug_range): New.
5196         (struct objfile) <separate_debug_objfiles>: New method.
5197         (objfile_separate_debug_iterate): Don't declare.
5198         * objfiles.c (separate_debug_iterator::operator++): Rename from
5199         objfile_separate_debug_iterate.
5200         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5201         iterator.
5202         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5203         iterator.
5204
5205 2019-04-10  Tom Tromey  <tom@tromey.com>
5206
5207         * symfile.c (reread_symbols): Remove old comment.
5208         * objfiles.c (free_all_objfiles): Fix a typo.
5209
5210 2019-04-10  Tom Tromey  <tom@tromey.com>
5211
5212         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5213         * minsyms.c (lookup_minimal_symbol): Use foreach.
5214         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5215         (lookup_minimal_symbol_solib_trampoline): Likewise.
5216         * symfile.c (reread_symbols): Use foreach.
5217
5218 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5219             Tom Tromey  <tromey@adacore.com>
5220
5221         PR rust/24414:
5222         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5223         (rust_lex_int_test): Change "value" to be LONGEST.
5224         (rust_lex_tests): Add test for long integer literal.
5225
5226 2019-04-09  Tom Tromey  <tromey@adacore.com>
5227
5228         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5229         to bool.
5230         (extended_remote_target::attach): Update.
5231         (remote_target::remote_notice_new_inferior): Update.
5232         (remote_target::add_current_inferior_and_thread): Update.
5233         * inferior.c (exit_inferior_1): Use "false".
5234         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5235
5236 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5237
5238         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5239         the "start" command.
5240
5241 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5242
5243         * python/py-inferior.c (infpy_thread_from_thread_handle):
5244         Adjust comments to reflect renaming of thread_from_thread_handle
5245         to thread_from_handle.  Adjust keywords.  Fix type error message.
5246         (inferior_object_methods): Add thread_from_handle.  Retain
5247         thread_from_thread_handle, but mark it as deprecated.
5248
5249 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5250
5251         * gdbthread.h (find_thread_by_handle): Revise declaration.
5252         * thread.c (find_thread_by_handle): Likewise.  Adjust
5253         implementation too.
5254         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5255         support for buffer objects as handles.
5256
5257 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5258
5259         * python/py-infthread.c (thpy_thread_handle): New function.
5260         (thread_object_methods): Register thpy_thread_handle.
5261
5262 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5263
5264         * gdbthread.h (thread_to_thread_handle): Declare.
5265         * thread.c (gdbtypes.h): Include.
5266         (thread_to_thread_handle): New function.
5267
5268         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5269         (target_thread_info_to_thread_handle): Declare.
5270         * target.c (target_thread_info_to_thread_handle): New function.
5271         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5272         * target-delegates.c: Regenerate.
5273
5274         * linux-thread-db.c (class thread_db_target): Add method
5275         thread_info_to_thread_handle.
5276         (thread_db_target::thread_info_to_thread_handle): Define.
5277         * remote.c (class remote_target): Add new method
5278         thread_info_to_thread_handle.
5279         (remote_target::thread_info_to_thread_handle): Define.
5280
5281 2019-04-08  Pedro Alves  <palves@redhat.com>
5282
5283         * common/common-exceptions.c (throw_exception): Don't create
5284         named object to throw; throw directly.
5285         (throw_it): Likewise.  Don't initialize gdb_exception::message
5286         here, with new; pass FMT and AP to the ctor instead.
5287         * common/common-exceptions.h: Include <string>.
5288         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5289         const char *, va_list)): New ctor.  Use std::make_shared.
5290         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5291         errors)): Delete.
5292         (gdb_exception_error::gdb_exception_error(enum errors, const char
5293         *, va_list)): New.
5294         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5295         Add assertion.
5296         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5297         errors)): Delete.
5298         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5299         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5300         Add assertion.
5301
5302 2019-04-08  Tom Tromey  <tom@tromey.com>
5303
5304         * valops.c (value_rtti_indirect_type): Replace throw_exception
5305         with throw.
5306         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5307         with throw.
5308         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5309         throw.
5310         * target.c (target_translate_tls_address): Replace throw_exception
5311         with throw.
5312         * stack.c (frame_apply_command_count): Replace throw_exception
5313         with throw.
5314         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5315         throw.
5316         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5317         with throw.
5318         * rs6000-tdep.c (rs6000_frame_cache)
5319         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5320         * remote.c: Replace throw_exception with throw.
5321         * record-full.c (record_full_message, record_full_wait_1)
5322         (record_full_restore): Replace throw_exception with throw.
5323         * record-btrace.c:
5324         (get_thread_current_frame_id, record_btrace_start_replaying)
5325         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5326         (cmd_record_btrace_start): Replace throw_exception with throw.
5327         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5328         throw.
5329         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5330         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5331         * linespec.c:
5332         (find_linespec_symbols): Replace throw_exception with throw.
5333         * infrun.c (displaced_step_prepare, resume): Replace
5334         throw_exception with throw.
5335         * infcmd.c (post_create_inferior): Replace throw_exception with
5336         throw.
5337         * inf-loop.c (inferior_event_handler): Replace throw_exception
5338         with throw.
5339         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5340         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5341         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5342         (get_prev_frame_always, get_frame_pc_if_available)
5343         (get_frame_address_in_block_if_available, get_frame_language):
5344         Replace throw_exception with throw.
5345         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5346         throw_exception with throw.
5347         * eval.c (fetch_subexp_value, evaluate_var_value)
5348         (evaluate_funcall, evaluate_subexp_standard): Replace
5349         throw_exception with throw.
5350         * dwarf2loc.c (call_site_find_chain)
5351         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5352         Replace throw_exception with throw.
5353         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5354         with throw.
5355         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5356         throw.
5357         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5358         * completer.c (complete_line_internal): Replace throw_exception
5359         with throw.
5360         * compile/compile-object-run.c (compile_object_run): Replace
5361         throw_exception with throw.
5362         * cli/cli-script.c (process_next_line): Replace throw_exception
5363         with throw.
5364         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5365         (btrace_enable, btrace_maint_update_pt_packets): Replace
5366         throw_exception with throw.
5367         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5368         throw_exception with throw.
5369         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5370         throw_exception with throw.
5371         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5372         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5373         * aarch64-tdep.c (aarch64_make_prologue_cache)
5374         (aarch64_make_stub_cache): Replace throw_exception with throw.
5375
5376 2019-04-08  Tom Tromey  <tom@tromey.com>
5377
5378         * common/common-exceptions.c (throw_exception): Rename from
5379         throw_exception_cxx.  Remove old copy.  Make argument const.
5380         (throw_it): Create and throw exception objects directly.
5381         * common/common-exceptions.h (throw_exception): Make argument
5382         const.
5383         (struct gdb_exception_error): Add constructor.
5384         (struct gdb_exception_quit): Add constructor.
5385
5386 2019-04-08  Tom Tromey  <tom@tromey.com>
5387
5388         * common/common-exceptions.h (exception_rethrow): Don't declare.
5389         (TRY_SJLJ): Update comment.
5390         (TRY, CATCH, END_CATCH): Remove.
5391         * common/common-exceptions.c (exception_rethrow): Remove.
5392
5393 2019-04-08  Tom Tromey  <tom@tromey.com>
5394
5395         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5396         Remove.
5397         (gdb_exception_error): Rename from
5398         gdb_exception_RETURN_MASK_ERROR.
5399         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5400         (gdb_quit_bad_alloc): Update.
5401         * aarch64-tdep.c: Update.
5402         * ada-lang.c: Update.
5403         * ada-typeprint.c: Update.
5404         * ada-valprint.c: Update.
5405         * amd64-tdep.c: Update.
5406         * arch-utils.c: Update.
5407         * break-catch-throw.c: Update.
5408         * breakpoint.c: Update.
5409         * btrace.c: Update.
5410         * c-varobj.c: Update.
5411         * cli/cli-cmds.c: Update.
5412         * cli/cli-interp.c: Update.
5413         * cli/cli-script.c: Update.
5414         * common/common-exceptions.c: Update.
5415         * common/new-op.c: Update.
5416         * common/selftest.c: Update.
5417         * compile/compile-c-symbols.c: Update.
5418         * compile/compile-cplus-symbols.c: Update.
5419         * compile/compile-object-load.c: Update.
5420         * compile/compile-object-run.c: Update.
5421         * completer.c: Update.
5422         * corelow.c: Update.
5423         * cp-abi.c: Update.
5424         * cp-support.c: Update.
5425         * cp-valprint.c: Update.
5426         * darwin-nat.c: Update.
5427         * disasm-selftests.c: Update.
5428         * dtrace-probe.c: Update.
5429         * dwarf-index-cache.c: Update.
5430         * dwarf-index-write.c: Update.
5431         * dwarf2-frame-tailcall.c: Update.
5432         * dwarf2-frame.c: Update.
5433         * dwarf2loc.c: Update.
5434         * dwarf2read.c: Update.
5435         * eval.c: Update.
5436         * event-loop.c: Update.
5437         * event-top.c: Update.
5438         * exec.c: Update.
5439         * f-valprint.c: Update.
5440         * fbsd-tdep.c: Update.
5441         * frame-unwind.c: Update.
5442         * frame.c: Update.
5443         * gdbtypes.c: Update.
5444         * gnu-v3-abi.c: Update.
5445         * guile/guile-internal.h: Update.
5446         * guile/scm-block.c: Update.
5447         * guile/scm-breakpoint.c: Update.
5448         * guile/scm-cmd.c: Update.
5449         * guile/scm-disasm.c: Update.
5450         * guile/scm-frame.c: Update.
5451         * guile/scm-lazy-string.c: Update.
5452         * guile/scm-math.c: Update.
5453         * guile/scm-param.c: Update.
5454         * guile/scm-ports.c: Update.
5455         * guile/scm-pretty-print.c: Update.
5456         * guile/scm-symbol.c: Update.
5457         * guile/scm-symtab.c: Update.
5458         * guile/scm-type.c: Update.
5459         * guile/scm-value.c: Update.
5460         * i386-linux-tdep.c: Update.
5461         * i386-tdep.c: Update.
5462         * inf-loop.c: Update.
5463         * infcall.c: Update.
5464         * infcmd.c: Update.
5465         * infrun.c: Update.
5466         * jit.c: Update.
5467         * language.c: Update.
5468         * linespec.c: Update.
5469         * linux-fork.c: Update.
5470         * linux-nat.c: Update.
5471         * linux-tdep.c: Update.
5472         * linux-thread-db.c: Update.
5473         * main.c: Update.
5474         * mi/mi-cmd-break.c: Update.
5475         * mi/mi-cmd-stack.c: Update.
5476         * mi/mi-interp.c: Update.
5477         * mi/mi-main.c: Update.
5478         * objc-lang.c: Update.
5479         * p-valprint.c: Update.
5480         * parse.c: Update.
5481         * ppc-linux-tdep.c: Update.
5482         * printcmd.c: Update.
5483         * python/py-arch.c: Update.
5484         * python/py-breakpoint.c: Update.
5485         * python/py-cmd.c: Update.
5486         * python/py-finishbreakpoint.c: Update.
5487         * python/py-frame.c: Update.
5488         * python/py-framefilter.c: Update.
5489         * python/py-gdb-readline.c: Update.
5490         * python/py-inferior.c: Update.
5491         * python/py-infthread.c: Update.
5492         * python/py-lazy-string.c: Update.
5493         * python/py-linetable.c: Update.
5494         * python/py-objfile.c: Update.
5495         * python/py-param.c: Update.
5496         * python/py-prettyprint.c: Update.
5497         * python/py-progspace.c: Update.
5498         * python/py-record-btrace.c: Update.
5499         * python/py-record.c: Update.
5500         * python/py-symbol.c: Update.
5501         * python/py-type.c: Update.
5502         * python/py-unwind.c: Update.
5503         * python/py-utils.c: Update.
5504         * python/py-value.c: Update.
5505         * python/python.c: Update.
5506         * record-btrace.c: Update.
5507         * record-full.c: Update.
5508         * remote-fileio.c: Update.
5509         * remote.c: Update.
5510         * riscv-tdep.c: Update.
5511         * rs6000-aix-tdep.c: Update.
5512         * rs6000-tdep.c: Update.
5513         * rust-exp.y: Update.
5514         * rust-lang.c: Update.
5515         * s390-tdep.c: Update.
5516         * selftest-arch.c: Update.
5517         * solib-dsbt.c: Update.
5518         * solib-frv.c: Update.
5519         * solib-spu.c: Update.
5520         * solib-svr4.c: Update.
5521         * solib.c: Update.
5522         * sparc64-linux-tdep.c: Update.
5523         * stack.c: Update.
5524         * symfile-mem.c: Update.
5525         * symmisc.c: Update.
5526         * target.c: Update.
5527         * thread.c: Update.
5528         * top.c: Update.
5529         * tracefile-tfile.c: Update.
5530         * tui/tui.c: Update.
5531         * typeprint.c: Update.
5532         * unittests/cli-utils-selftests.c: Update.
5533         * unittests/parse-connection-spec-selftests.c: Update.
5534         * valops.c: Update.
5535         * valprint.c: Update.
5536         * value.c: Update.
5537         * varobj.c: Update.
5538         * windows-nat.c: Update.
5539         * x86-linux-nat.c: Update.
5540         * xml-support.c: Update.
5541
5542 2019-04-08  Tom Tromey  <tom@tromey.com>
5543
5544         * xml-support.c: Use C++ exception handling.
5545         * x86-linux-nat.c: Use C++ exception handling.
5546         * windows-nat.c: Use C++ exception handling.
5547         * varobj.c: Use C++ exception handling.
5548         * value.c: Use C++ exception handling.
5549         * valprint.c: Use C++ exception handling.
5550         * valops.c: Use C++ exception handling.
5551         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5552         handling.
5553         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5554         * typeprint.c: Use C++ exception handling.
5555         * tui/tui.c: Use C++ exception handling.
5556         * tracefile-tfile.c: Use C++ exception handling.
5557         * top.c: Use C++ exception handling.
5558         * thread.c: Use C++ exception handling.
5559         * target.c: Use C++ exception handling.
5560         * symmisc.c: Use C++ exception handling.
5561         * symfile-mem.c: Use C++ exception handling.
5562         * stack.c: Use C++ exception handling.
5563         * sparc64-linux-tdep.c: Use C++ exception handling.
5564         * solib.c: Use C++ exception handling.
5565         * solib-svr4.c: Use C++ exception handling.
5566         * solib-spu.c: Use C++ exception handling.
5567         * solib-frv.c: Use C++ exception handling.
5568         * solib-dsbt.c: Use C++ exception handling.
5569         * selftest-arch.c: Use C++ exception handling.
5570         * s390-tdep.c: Use C++ exception handling.
5571         * rust-lang.c: Use C++ exception handling.
5572         * rust-exp.y: Use C++ exception handling.
5573         * rs6000-tdep.c: Use C++ exception handling.
5574         * rs6000-aix-tdep.c: Use C++ exception handling.
5575         * riscv-tdep.c: Use C++ exception handling.
5576         * remote.c: Use C++ exception handling.
5577         * remote-fileio.c: Use C++ exception handling.
5578         * record-full.c: Use C++ exception handling.
5579         * record-btrace.c: Use C++ exception handling.
5580         * python/python.c: Use C++ exception handling.
5581         * python/py-value.c: Use C++ exception handling.
5582         * python/py-utils.c: Use C++ exception handling.
5583         * python/py-unwind.c: Use C++ exception handling.
5584         * python/py-type.c: Use C++ exception handling.
5585         * python/py-symbol.c: Use C++ exception handling.
5586         * python/py-record.c: Use C++ exception handling.
5587         * python/py-record-btrace.c: Use C++ exception handling.
5588         * python/py-progspace.c: Use C++ exception handling.
5589         * python/py-prettyprint.c: Use C++ exception handling.
5590         * python/py-param.c: Use C++ exception handling.
5591         * python/py-objfile.c: Use C++ exception handling.
5592         * python/py-linetable.c: Use C++ exception handling.
5593         * python/py-lazy-string.c: Use C++ exception handling.
5594         * python/py-infthread.c: Use C++ exception handling.
5595         * python/py-inferior.c: Use C++ exception handling.
5596         * python/py-gdb-readline.c: Use C++ exception handling.
5597         * python/py-framefilter.c: Use C++ exception handling.
5598         * python/py-frame.c: Use C++ exception handling.
5599         * python/py-finishbreakpoint.c: Use C++ exception handling.
5600         * python/py-cmd.c: Use C++ exception handling.
5601         * python/py-breakpoint.c: Use C++ exception handling.
5602         * python/py-arch.c: Use C++ exception handling.
5603         * printcmd.c: Use C++ exception handling.
5604         * ppc-linux-tdep.c: Use C++ exception handling.
5605         * parse.c: Use C++ exception handling.
5606         * p-valprint.c: Use C++ exception handling.
5607         * objc-lang.c: Use C++ exception handling.
5608         * mi/mi-main.c: Use C++ exception handling.
5609         * mi/mi-interp.c: Use C++ exception handling.
5610         * mi/mi-cmd-stack.c: Use C++ exception handling.
5611         * mi/mi-cmd-break.c: Use C++ exception handling.
5612         * main.c: Use C++ exception handling.
5613         * linux-thread-db.c: Use C++ exception handling.
5614         * linux-tdep.c: Use C++ exception handling.
5615         * linux-nat.c: Use C++ exception handling.
5616         * linux-fork.c: Use C++ exception handling.
5617         * linespec.c: Use C++ exception handling.
5618         * language.c: Use C++ exception handling.
5619         * jit.c: Use C++ exception handling.
5620         * infrun.c: Use C++ exception handling.
5621         * infcmd.c: Use C++ exception handling.
5622         * infcall.c: Use C++ exception handling.
5623         * inf-loop.c: Use C++ exception handling.
5624         * i386-tdep.c: Use C++ exception handling.
5625         * i386-linux-tdep.c: Use C++ exception handling.
5626         * guile/scm-value.c: Use C++ exception handling.
5627         * guile/scm-type.c: Use C++ exception handling.
5628         * guile/scm-symtab.c: Use C++ exception handling.
5629         * guile/scm-symbol.c: Use C++ exception handling.
5630         * guile/scm-pretty-print.c: Use C++ exception handling.
5631         * guile/scm-ports.c: Use C++ exception handling.
5632         * guile/scm-param.c: Use C++ exception handling.
5633         * guile/scm-math.c: Use C++ exception handling.
5634         * guile/scm-lazy-string.c: Use C++ exception handling.
5635         * guile/scm-frame.c: Use C++ exception handling.
5636         * guile/scm-disasm.c: Use C++ exception handling.
5637         * guile/scm-cmd.c: Use C++ exception handling.
5638         * guile/scm-breakpoint.c: Use C++ exception handling.
5639         * guile/scm-block.c: Use C++ exception handling.
5640         * guile/guile-internal.h: Use C++ exception handling.
5641         * gnu-v3-abi.c: Use C++ exception handling.
5642         * gdbtypes.c: Use C++ exception handling.
5643         * frame.c: Use C++ exception handling.
5644         * frame-unwind.c: Use C++ exception handling.
5645         * fbsd-tdep.c: Use C++ exception handling.
5646         * f-valprint.c: Use C++ exception handling.
5647         * exec.c: Use C++ exception handling.
5648         * event-top.c: Use C++ exception handling.
5649         * event-loop.c: Use C++ exception handling.
5650         * eval.c: Use C++ exception handling.
5651         * dwarf2read.c: Use C++ exception handling.
5652         * dwarf2loc.c: Use C++ exception handling.
5653         * dwarf2-frame.c: Use C++ exception handling.
5654         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5655         * dwarf-index-write.c: Use C++ exception handling.
5656         * dwarf-index-cache.c: Use C++ exception handling.
5657         * dtrace-probe.c: Use C++ exception handling.
5658         * disasm-selftests.c: Use C++ exception handling.
5659         * darwin-nat.c: Use C++ exception handling.
5660         * cp-valprint.c: Use C++ exception handling.
5661         * cp-support.c: Use C++ exception handling.
5662         * cp-abi.c: Use C++ exception handling.
5663         * corelow.c: Use C++ exception handling.
5664         * completer.c: Use C++ exception handling.
5665         * compile/compile-object-run.c: Use C++ exception handling.
5666         * compile/compile-object-load.c: Use C++ exception handling.
5667         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5668         * compile/compile-c-symbols.c: Use C++ exception handling.
5669         * common/selftest.c: Use C++ exception handling.
5670         * common/new-op.c: Use C++ exception handling.
5671         * cli/cli-script.c: Use C++ exception handling.
5672         * cli/cli-interp.c: Use C++ exception handling.
5673         * cli/cli-cmds.c: Use C++ exception handling.
5674         * c-varobj.c: Use C++ exception handling.
5675         * btrace.c: Use C++ exception handling.
5676         * breakpoint.c: Use C++ exception handling.
5677         * break-catch-throw.c: Use C++ exception handling.
5678         * arch-utils.c: Use C++ exception handling.
5679         * amd64-tdep.c: Use C++ exception handling.
5680         * ada-valprint.c: Use C++ exception handling.
5681         * ada-typeprint.c: Use C++ exception handling.
5682         * ada-lang.c: Use C++ exception handling.
5683         * aarch64-tdep.c: Use C++ exception handling.
5684
5685 2019-04-08  Tom Tromey  <tom@tromey.com>
5686
5687         * xml-support.c (gdb_xml_parser::parse): Update.
5688         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5689         * value.c (show_convenience): Update.
5690         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5691         (test_parse_flags_qcs): Update.
5692         * thread.c (thr_try_catch_cmd): Update.
5693         * target.c (target_translate_tls_address): Update.
5694         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5695         (info_frame_command_core, frame_apply_command_count): Update.
5696         * rust-exp.y (rust_lex_exception_test): Update.
5697         * riscv-tdep.c (riscv_print_one_register_info): Update.
5698         * remote.c (remote_target::enable_btrace): Update.
5699         * record-btrace.c (record_btrace_enable_warn): Update.
5700         * python/py-utils.c (gdbpy_convert_exception): Update.
5701         * printcmd.c (do_one_display, print_variable_and_value): Update.
5702         * mi/mi-main.c (mi_print_exception): Update.
5703         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5704         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5705         * linux-nat.c (linux_nat_target::attach): Update.
5706         * linux-fork.c (class scoped_switch_fork_info): Update.
5707         * infrun.c (displaced_step_prepare): Update.
5708         * infcall.c (call_function_by_hand_dummy): Update.
5709         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5710         * gnu-v3-abi.c (print_one_vtable): Update.
5711         * frame.c (get_prev_frame_always): Update.
5712         * f-valprint.c (info_common_command_for_block): Update.
5713         * exec.c (try_open_exec_file): Update.
5714         * exceptions.c (print_exception, exception_print)
5715         (exception_fprintf, exception_print_same): Update.
5716         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5717         * dwarf-index-cache.c (index_cache::store)
5718         (index_cache::lookup_gdb_index): Update.
5719         * darwin-nat.c (maybe_cache_shell): Update.
5720         * cp-valprint.c (cp_print_value_fields): Update.
5721         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5722         (gcc_cplus_symbol_address): Update.
5723         * compile/compile-c-symbols.c (gcc_convert_symbol)
5724         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5725         * common/selftest.c: Update.
5726         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5727         a std::string.
5728         (exception_try_scope_entry, exception_try_scope_exit): Don't
5729         declare.
5730         (struct exception_try_scope): Remove.
5731         (TRY): Don't use exception_try_scope.
5732         (struct gdb_exception): Add constructor, operator=.
5733         <what>: New method.
5734         (struct gdb_exception_RETURN_MASK_ALL)
5735         (struct gdb_exception_RETURN_MASK_ERROR)
5736         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5737         (struct gdb_quit_bad_alloc): Update.
5738         * common/common-exceptions.c (exception_none): Change
5739         initializer.
5740         (struct catcher) <state, exception>: Initialize inline.
5741         <prev>: Remove member.
5742         (current_catcher): Remove.
5743         (catchers): New global.
5744         (exceptions_state_mc_init): Simplify.
5745         (catcher_pop): Remove.
5746         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5747         (try_scope_depth, exception_try_scope_entry)
5748         (exception_try_scope_exit): Remove.
5749         (throw_exception_sjlj): Update.
5750         (exception_messages, exception_messages_size): Remove.
5751         (throw_it): Simplify.
5752         (gdb_exception_sliced_copy): Remove.
5753         (throw_exception_cxx): Update.
5754         * cli/cli-script.c (script_from_file): Update.
5755         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5756         Update.
5757         * ada-valprint.c (ada_val_print): Update.
5758         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5759         (create_excep_cond_exprs): Update.
5760
5761 2019-04-08  Tom Tromey  <tom@tromey.com>
5762
5763         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5764         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5765         (TRY, CATCH, END_CATCH): Remove some definitions.
5766         * common/common-exceptions.c: Don't use GDB_XCPT.
5767         (catcher_list_size): Remove.
5768         (throw_exception, throw_it): Simplify.
5769
5770 2019-04-05  Tom Tromey  <tom@tromey.com>
5771
5772         Revert the header-sorting patch.
5773         * ft32-tdep.c: Revert.
5774         * frv-tdep.c: Revert.
5775         * frv-linux-tdep.c: Revert.
5776         * frame.c: Revert.
5777         * frame-unwind.c: Revert.
5778         * frame-base.c: Revert.
5779         * fork-child.c: Revert.
5780         * findvar.c: Revert.
5781         * findcmd.c: Revert.
5782         * filesystem.c: Revert.
5783         * filename-seen-cache.h: Revert.
5784         * filename-seen-cache.c: Revert.
5785         * fbsd-tdep.c: Revert.
5786         * fbsd-nat.h: Revert.
5787         * fbsd-nat.c: Revert.
5788         * f-valprint.c: Revert.
5789         * f-typeprint.c: Revert.
5790         * f-lang.c: Revert.
5791         * extension.h: Revert.
5792         * extension.c: Revert.
5793         * extension-priv.h: Revert.
5794         * expprint.c: Revert.
5795         * exec.h: Revert.
5796         * exec.c: Revert.
5797         * exceptions.c: Revert.
5798         * event-top.c: Revert.
5799         * event-loop.c: Revert.
5800         * eval.c: Revert.
5801         * elfread.c: Revert.
5802         * dwarf2read.h: Revert.
5803         * dwarf2read.c: Revert.
5804         * dwarf2loc.c: Revert.
5805         * dwarf2expr.h: Revert.
5806         * dwarf2expr.c: Revert.
5807         * dwarf2-frame.c: Revert.
5808         * dwarf2-frame-tailcall.c: Revert.
5809         * dwarf-index-write.h: Revert.
5810         * dwarf-index-write.c: Revert.
5811         * dwarf-index-common.c: Revert.
5812         * dwarf-index-cache.h: Revert.
5813         * dwarf-index-cache.c: Revert.
5814         * dummy-frame.c: Revert.
5815         * dtrace-probe.c: Revert.
5816         * disasm.h: Revert.
5817         * disasm.c: Revert.
5818         * disasm-selftests.c: Revert.
5819         * dictionary.c: Revert.
5820         * dicos-tdep.c: Revert.
5821         * demangle.c: Revert.
5822         * dcache.h: Revert.
5823         * dcache.c: Revert.
5824         * darwin-nat.h: Revert.
5825         * darwin-nat.c: Revert.
5826         * darwin-nat-info.c: Revert.
5827         * d-valprint.c: Revert.
5828         * d-namespace.c: Revert.
5829         * d-lang.c: Revert.
5830         * ctf.c: Revert.
5831         * csky-tdep.c: Revert.
5832         * csky-linux-tdep.c: Revert.
5833         * cris-tdep.c: Revert.
5834         * cris-linux-tdep.c: Revert.
5835         * cp-valprint.c: Revert.
5836         * cp-support.c: Revert.
5837         * cp-namespace.c: Revert.
5838         * cp-abi.c: Revert.
5839         * corelow.c: Revert.
5840         * corefile.c: Revert.
5841         * continuations.c: Revert.
5842         * completer.h: Revert.
5843         * completer.c: Revert.
5844         * complaints.c: Revert.
5845         * coffread.c: Revert.
5846         * coff-pe-read.c: Revert.
5847         * cli-out.h: Revert.
5848         * cli-out.c: Revert.
5849         * charset.c: Revert.
5850         * c-varobj.c: Revert.
5851         * c-valprint.c: Revert.
5852         * c-typeprint.c: Revert.
5853         * c-lang.c: Revert.
5854         * buildsym.c: Revert.
5855         * buildsym-legacy.c: Revert.
5856         * build-id.h: Revert.
5857         * build-id.c: Revert.
5858         * btrace.c: Revert.
5859         * bsd-uthread.c: Revert.
5860         * breakpoint.h: Revert.
5861         * breakpoint.c: Revert.
5862         * break-catch-throw.c: Revert.
5863         * break-catch-syscall.c: Revert.
5864         * break-catch-sig.c: Revert.
5865         * blockframe.c: Revert.
5866         * block.c: Revert.
5867         * bfin-tdep.c: Revert.
5868         * bfin-linux-tdep.c: Revert.
5869         * bfd-target.c: Revert.
5870         * bcache.c: Revert.
5871         * ax-general.c: Revert.
5872         * ax-gdb.h: Revert.
5873         * ax-gdb.c: Revert.
5874         * avr-tdep.c: Revert.
5875         * auxv.c: Revert.
5876         * auto-load.c: Revert.
5877         * arm-wince-tdep.c: Revert.
5878         * arm-tdep.c: Revert.
5879         * arm-symbian-tdep.c: Revert.
5880         * arm-pikeos-tdep.c: Revert.
5881         * arm-obsd-tdep.c: Revert.
5882         * arm-nbsd-tdep.c: Revert.
5883         * arm-nbsd-nat.c: Revert.
5884         * arm-linux-tdep.c: Revert.
5885         * arm-linux-nat.c: Revert.
5886         * arm-fbsd-tdep.c: Revert.
5887         * arm-fbsd-nat.c: Revert.
5888         * arm-bsd-tdep.c: Revert.
5889         * arch-utils.c: Revert.
5890         * arc-tdep.c: Revert.
5891         * arc-newlib-tdep.c: Revert.
5892         * annotate.h: Revert.
5893         * annotate.c: Revert.
5894         * amd64-windows-tdep.c: Revert.
5895         * amd64-windows-nat.c: Revert.
5896         * amd64-tdep.c: Revert.
5897         * amd64-sol2-tdep.c: Revert.
5898         * amd64-obsd-tdep.c: Revert.
5899         * amd64-obsd-nat.c: Revert.
5900         * amd64-nbsd-tdep.c: Revert.
5901         * amd64-nbsd-nat.c: Revert.
5902         * amd64-nat.c: Revert.
5903         * amd64-linux-tdep.c: Revert.
5904         * amd64-linux-nat.c: Revert.
5905         * amd64-fbsd-tdep.c: Revert.
5906         * amd64-fbsd-nat.c: Revert.
5907         * amd64-dicos-tdep.c: Revert.
5908         * amd64-darwin-tdep.c: Revert.
5909         * amd64-bsd-nat.c: Revert.
5910         * alpha-tdep.c: Revert.
5911         * alpha-obsd-tdep.c: Revert.
5912         * alpha-nbsd-tdep.c: Revert.
5913         * alpha-mdebug-tdep.c: Revert.
5914         * alpha-linux-tdep.c: Revert.
5915         * alpha-linux-nat.c: Revert.
5916         * alpha-bsd-tdep.c: Revert.
5917         * alpha-bsd-nat.c: Revert.
5918         * aix-thread.c: Revert.
5919         * agent.c: Revert.
5920         * addrmap.c: Revert.
5921         * ada-varobj.c: Revert.
5922         * ada-valprint.c: Revert.
5923         * ada-typeprint.c: Revert.
5924         * ada-tasks.c: Revert.
5925         * ada-lang.c: Revert.
5926         * aarch64-tdep.c: Revert.
5927         * aarch64-ravenscar-thread.c: Revert.
5928         * aarch64-newlib-tdep.c: Revert.
5929         * aarch64-linux-tdep.c: Revert.
5930         * aarch64-linux-nat.c: Revert.
5931         * aarch64-fbsd-tdep.c: Revert.
5932         * aarch64-fbsd-nat.c: Revert.
5933         * aarch32-linux-nat.c: Revert.
5934
5935 2019-04-05  Tom Tromey  <tom@tromey.com>
5936
5937         * ft32-tdep.c: Sort headers.
5938         * frv-tdep.c: Sort headers.
5939         * frv-linux-tdep.c: Sort headers.
5940         * frame.c: Sort headers.
5941         * frame-unwind.c: Sort headers.
5942         * frame-base.c: Sort headers.
5943         * fork-child.c: Sort headers.
5944         * findvar.c: Sort headers.
5945         * findcmd.c: Sort headers.
5946         * filesystem.c: Sort headers.
5947         * filename-seen-cache.h: Sort headers.
5948         * filename-seen-cache.c: Sort headers.
5949         * fbsd-tdep.c: Sort headers.
5950         * fbsd-nat.h: Sort headers.
5951         * fbsd-nat.c: Sort headers.
5952         * f-valprint.c: Sort headers.
5953         * f-typeprint.c: Sort headers.
5954         * f-lang.c: Sort headers.
5955         * extension.h: Sort headers.
5956         * extension.c: Sort headers.
5957         * extension-priv.h: Sort headers.
5958         * expprint.c: Sort headers.
5959         * exec.h: Sort headers.
5960         * exec.c: Sort headers.
5961         * exceptions.c: Sort headers.
5962         * event-top.c: Sort headers.
5963         * event-loop.c: Sort headers.
5964         * eval.c: Sort headers.
5965         * elfread.c: Sort headers.
5966         * dwarf2read.h: Sort headers.
5967         * dwarf2read.c: Sort headers.
5968         * dwarf2loc.c: Sort headers.
5969         * dwarf2expr.h: Sort headers.
5970         * dwarf2expr.c: Sort headers.
5971         * dwarf2-frame.c: Sort headers.
5972         * dwarf2-frame-tailcall.c: Sort headers.
5973         * dwarf-index-write.h: Sort headers.
5974         * dwarf-index-write.c: Sort headers.
5975         * dwarf-index-common.c: Sort headers.
5976         * dwarf-index-cache.h: Sort headers.
5977         * dwarf-index-cache.c: Sort headers.
5978         * dummy-frame.c: Sort headers.
5979         * dtrace-probe.c: Sort headers.
5980         * disasm.h: Sort headers.
5981         * disasm.c: Sort headers.
5982         * disasm-selftests.c: Sort headers.
5983         * dictionary.c: Sort headers.
5984         * dicos-tdep.c: Sort headers.
5985         * demangle.c: Sort headers.
5986         * dcache.h: Sort headers.
5987         * dcache.c: Sort headers.
5988         * darwin-nat.h: Sort headers.
5989         * darwin-nat.c: Sort headers.
5990         * darwin-nat-info.c: Sort headers.
5991         * d-valprint.c: Sort headers.
5992         * d-namespace.c: Sort headers.
5993         * d-lang.c: Sort headers.
5994         * ctf.c: Sort headers.
5995         * csky-tdep.c: Sort headers.
5996         * csky-linux-tdep.c: Sort headers.
5997         * cris-tdep.c: Sort headers.
5998         * cris-linux-tdep.c: Sort headers.
5999         * cp-valprint.c: Sort headers.
6000         * cp-support.c: Sort headers.
6001         * cp-namespace.c: Sort headers.
6002         * cp-abi.c: Sort headers.
6003         * corelow.c: Sort headers.
6004         * corefile.c: Sort headers.
6005         * continuations.c: Sort headers.
6006         * completer.h: Sort headers.
6007         * completer.c: Sort headers.
6008         * complaints.c: Sort headers.
6009         * coffread.c: Sort headers.
6010         * coff-pe-read.c: Sort headers.
6011         * cli-out.h: Sort headers.
6012         * cli-out.c: Sort headers.
6013         * charset.c: Sort headers.
6014         * c-varobj.c: Sort headers.
6015         * c-valprint.c: Sort headers.
6016         * c-typeprint.c: Sort headers.
6017         * c-lang.c: Sort headers.
6018         * buildsym.c: Sort headers.
6019         * buildsym-legacy.c: Sort headers.
6020         * build-id.h: Sort headers.
6021         * build-id.c: Sort headers.
6022         * btrace.c: Sort headers.
6023         * bsd-uthread.c: Sort headers.
6024         * breakpoint.h: Sort headers.
6025         * breakpoint.c: Sort headers.
6026         * break-catch-throw.c: Sort headers.
6027         * break-catch-syscall.c: Sort headers.
6028         * break-catch-sig.c: Sort headers.
6029         * blockframe.c: Sort headers.
6030         * block.c: Sort headers.
6031         * bfin-tdep.c: Sort headers.
6032         * bfin-linux-tdep.c: Sort headers.
6033         * bfd-target.c: Sort headers.
6034         * bcache.c: Sort headers.
6035         * ax-general.c: Sort headers.
6036         * ax-gdb.h: Sort headers.
6037         * ax-gdb.c: Sort headers.
6038         * avr-tdep.c: Sort headers.
6039         * auxv.c: Sort headers.
6040         * auto-load.c: Sort headers.
6041         * arm-wince-tdep.c: Sort headers.
6042         * arm-tdep.c: Sort headers.
6043         * arm-symbian-tdep.c: Sort headers.
6044         * arm-pikeos-tdep.c: Sort headers.
6045         * arm-obsd-tdep.c: Sort headers.
6046         * arm-nbsd-tdep.c: Sort headers.
6047         * arm-nbsd-nat.c: Sort headers.
6048         * arm-linux-tdep.c: Sort headers.
6049         * arm-linux-nat.c: Sort headers.
6050         * arm-fbsd-tdep.c: Sort headers.
6051         * arm-fbsd-nat.c: Sort headers.
6052         * arm-bsd-tdep.c: Sort headers.
6053         * arch-utils.c: Sort headers.
6054         * arc-tdep.c: Sort headers.
6055         * arc-newlib-tdep.c: Sort headers.
6056         * annotate.h: Sort headers.
6057         * annotate.c: Sort headers.
6058         * amd64-windows-tdep.c: Sort headers.
6059         * amd64-windows-nat.c: Sort headers.
6060         * amd64-tdep.c: Sort headers.
6061         * amd64-sol2-tdep.c: Sort headers.
6062         * amd64-obsd-tdep.c: Sort headers.
6063         * amd64-obsd-nat.c: Sort headers.
6064         * amd64-nbsd-tdep.c: Sort headers.
6065         * amd64-nbsd-nat.c: Sort headers.
6066         * amd64-nat.c: Sort headers.
6067         * amd64-linux-tdep.c: Sort headers.
6068         * amd64-linux-nat.c: Sort headers.
6069         * amd64-fbsd-tdep.c: Sort headers.
6070         * amd64-fbsd-nat.c: Sort headers.
6071         * amd64-dicos-tdep.c: Sort headers.
6072         * amd64-darwin-tdep.c: Sort headers.
6073         * amd64-bsd-nat.c: Sort headers.
6074         * alpha-tdep.c: Sort headers.
6075         * alpha-obsd-tdep.c: Sort headers.
6076         * alpha-nbsd-tdep.c: Sort headers.
6077         * alpha-mdebug-tdep.c: Sort headers.
6078         * alpha-linux-tdep.c: Sort headers.
6079         * alpha-linux-nat.c: Sort headers.
6080         * alpha-bsd-tdep.c: Sort headers.
6081         * alpha-bsd-nat.c: Sort headers.
6082         * aix-thread.c: Sort headers.
6083         * agent.c: Sort headers.
6084         * addrmap.c: Sort headers.
6085         * ada-varobj.c: Sort headers.
6086         * ada-valprint.c: Sort headers.
6087         * ada-typeprint.c: Sort headers.
6088         * ada-tasks.c: Sort headers.
6089         * ada-lang.c: Sort headers.
6090         * aarch64-tdep.c: Sort headers.
6091         * aarch64-ravenscar-thread.c: Sort headers.
6092         * aarch64-newlib-tdep.c: Sort headers.
6093         * aarch64-linux-tdep.c: Sort headers.
6094         * aarch64-linux-nat.c: Sort headers.
6095         * aarch64-fbsd-tdep.c: Sort headers.
6096         * aarch64-fbsd-nat.c: Sort headers.
6097         * aarch32-linux-nat.c: Sort headers.
6098
6099 2019-04-04  Tom Tromey  <tom@tromey.com>
6100
6101         * varobj.c (varobj_create): Update.
6102         * rust-exp.y (struct rust_parser) <update_innermost_block,
6103         lookup_symbol>: New methods.
6104         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6105         Rename.
6106         (rust_parser::rust_lookup_type)
6107         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6108         * printcmd.c (display_command, do_one_display): Update.
6109         * parser-defs.h (struct parser_state) <parser_state>: Add
6110         "tracker" parameter.
6111         (block_tracker): New member.
6112         (class innermost_block_tracker) <innermost_block_tracker>: Add
6113         "types" parameter.
6114         <reset>: Remove method.
6115         (innermost_block): Don't declare.
6116         (null_post_parser): Update.
6117         * parse.c (innermost_block): Remove global.
6118         (write_dollar_variable): Update.
6119         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6120         Remove "tracker_types" parameter.
6121         (parse_expression): Add "tracker" parameter.
6122         (parse_expression_for_completion): Update.
6123         (null_post_parser): Add "tracker" parameter.
6124         * p-exp.y: Update rules.
6125         * m2-exp.y: Update rules.
6126         * language.h (struct language_defn) <la_post_parser>: Add
6127         "tracker" parameter.
6128         * go-exp.y: Update rules.
6129         * f-exp.y: Update rules.
6130         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6131         parameter.
6132         * d-exp.y: Update rules.
6133         * c-exp.y: Update rules.
6134         * breakpoint.c (set_breakpoint_condition): Create an
6135         innermost_block_tracker.
6136         (watch_command_1): Likewise.
6137         * ada-lang.c (resolve): Add "tracker" parameter.
6138         (resolve_subexp): Likewise.
6139         * ada-exp.y (write_var_from_sym): Update.
6140
6141 2019-04-04  Tom Tromey  <tom@tromey.com>
6142
6143         * type-stack.h: New file.
6144         * type-stack.c: New file.
6145         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6146         type-stack.h.
6147         (insert_into_type_stack, insert_type, push_type, push_type_int)
6148         (insert_type_address_space, pop_type, pop_type_int)
6149         (pop_typelist, pop_type_stack, append_type_stack)
6150         (push_type_stack, get_type_stack, push_typelist)
6151         (follow_type_instance_flags, follow_types): Don't declare.
6152         * parse.c (type_stack): Remove global.
6153         (parse_exp_in_context): Update.
6154         (insert_into_type_stack, insert_type, push_type, push_type_int)
6155         (insert_type_address_space, pop_type, pop_type_int)
6156         (pop_typelist, pop_type_stack, append_type_stack)
6157         (push_type_stack, get_type_stack, push_typelist)
6158         (follow_type_instance_flags, follow_types): Remove (moved to
6159         type-stack.c).
6160         * f-exp.y (type_stack): New global.
6161         Update rules.
6162         (push_kind_type, f_parse): Update.
6163         * d-exp.y (type_stack): New global.
6164         Update rules.
6165         (d_parse): Update.
6166         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6167         Update rules.
6168         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6169         (HFILES_NO_SRCDIR): Add type-stack.h.
6170
6171 2019-04-04  Tom Tromey  <tom@tromey.com>
6172
6173         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6174         (rust_parser::convert_ast_to_expression, rust_parse)
6175         (rust_lex_test_completion, rust_lex_tests): Update.
6176         * parser-defs.h (struct expr_completion_state): New.
6177         (struct parser_state) <parser_state>: Add completion parameter.
6178         <mark_struct_expression, mark_completion_tag>: New methods.
6179         <parse_completion, m_completion_state>: New members.
6180         (prefixify_expression, null_post_parser): Update.
6181         (mark_struct_expression, mark_completion_tag): Don't declare.
6182         * parse.c (parse_completion, expout_last_struct)
6183         (expout_tag_completion_type, expout_completion_name): Remove
6184         globals.
6185         (parser_state::mark_struct_expression)
6186         (parser_state::mark_completion_tag): Now methods.
6187         (prefixify_expression): Add last_struct parameter.
6188         (prefixify_subexp): Likewise.
6189         (parse_exp_1): Update.
6190         (parse_exp_in_context): Add cstate parameter.  Update.
6191         (parse_expression_for_completion): Create an
6192         expr_completion_state.
6193         (null_post_parser): Add "completion" parameter.
6194         * p-exp.y: Update rules.
6195         (yylex): Update.
6196         * language.h (struct language_defn) <la_post_parser>: Add
6197         "completing" parameter.
6198         * go-exp.y: Update rules.
6199         (lex_one_token): Update.
6200         * expression.h (parse_completion): Don't declare.
6201         * d-exp.y: Update rules.
6202         (lex_one_token): Update rules.
6203         * c-exp.y: Update rules.
6204         (lex_one_token): Update.
6205         * ada-lang.c (resolve): Add "parse_completion" parameter.
6206         (resolve_subexp): Likewise.
6207         (ada_resolve_function): Likewise.
6208
6209 2019-04-04  Tom Tromey  <tom@tromey.com>
6210
6211         * parser-defs.h (struct parser_state) <start_arglist,
6212         end_arglist>: New methods.
6213         <arglist_len, m_funcall_chain>: New members.
6214         (arglist_len, start_arglist, end_arglist): Don't declare.
6215         * parse.c (arglist_len, funcall_chain): Remove global.
6216         (start_arglist, end_arglist): Remove functions.
6217         (parse_exp_in_context): Update.
6218         * p-exp.y: Update rules.
6219         * m2-exp.y: Update rules.
6220         * go-exp.y: Update rules.
6221         * f-exp.y: Update rules.
6222         * d-exp.y: Update rules.
6223         * c-exp.y: Update rules.
6224
6225 2019-04-04  Tom Tromey  <tom@tromey.com>
6226
6227         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6228         lex_operator, push_back>: New methods.
6229         Update all rules.
6230         (rust_parser::lex_hex, lex_escape): Rename and update.
6231         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6232         (rust_parser::lex_operator): Rename and update.
6233         (rust_parser::lex_number, rustyylex, rustyyerror)
6234         (rust_lex_test_init, rust_lex_test_sequence)
6235         (rust_lex_test_push_back, rust_lex_tests): Update.
6236         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6237         parameter.
6238         <lexptr, prev_lexptr>: New members.
6239         (lexptr, prev_lexptr): Don't declare.
6240         * parse.c (lexptr, prev_lexptr): Remove globals.
6241         (parse_exp_in_context): Update.
6242         * p-exp.y (yylex, yyerror): Update.
6243         * m2-exp.y (parse_number, yylex, yyerror): Update.
6244         * go-exp.y (lex_one_token, yyerror): Update.
6245         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6246         * d-exp.y (lex_one_token, yyerror): Update.
6247         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6248         (lex_one_token, yyerror): Update.
6249         * ada-lex.l (YY_INPUT): Update.
6250         (rewind_to_char): Update.
6251         * ada-exp.y (yyerror): Update.
6252
6253 2019-04-04  Tom Tromey  <tom@tromey.com>
6254
6255         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6256         * parser-defs.h (struct parser_state) <parser_state>: Add new
6257         parameter.
6258         <comma_terminates>: New member.
6259         (comma_terminates): Don't declare global.
6260         * parse.c (comma_terminates): Remove global.
6261         (parse_exp_in_context): Update.
6262         * p-exp.y (yylex): Update.
6263         * m2-exp.y (yylex): Update.
6264         * go-exp.y (lex_one_token): Update.
6265         * f-exp.y (yylex): Update.
6266         * d-exp.y (lex_one_token): Update.
6267         * c-exp.y (lex_one_token): Update.
6268         * ada-lex.l: Update.
6269
6270 2019-04-04  Tom Tromey  <tom@tromey.com>
6271
6272         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6273         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6274         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6275         * parser-defs.h (paren_depth): Don't declare.
6276         * parse.c (paren_depth): Remove global.
6277         (parse_exp_in_context): Update.
6278         * p-exp.y (paren_depth): New global.
6279         (pascal_parse): Initialize it.
6280         * m2-exp.y (paren_depth): New global.
6281         (m2_parse): Initialize it.
6282         * go-exp.y (paren_depth): New global.
6283         (go_parse): Initialize it.
6284         * f-exp.y (paren_depth): New global.
6285         (f_parse): Initialize it.
6286         * d-exp.y (paren_depth): New global.
6287         (d_parse): Initialize it.
6288         * c-exp.y (paren_depth): New global.
6289         (c_parse): Initialize it.
6290         * ada-lex.l (paren_depth): New global.
6291         (lexer_init): Initialize it.
6292
6293 2019-04-04  Tom Tromey  <tom@tromey.com>
6294
6295         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6296         (rust_parser::convert_ast_to_type)
6297         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6298         * parser-defs.h (struct parser_state) <parser_state>: Add
6299         parameters.  Initialize new members.
6300         <expression_context_block, expression_context_pc>: New members.
6301         * parse.c (expression_context_block, expression_context_pc):
6302         Remove globals.
6303         (parse_exp_in_context): Update.
6304         * p-exp.y: Update all rules.
6305         (yylex): Update.
6306         * m2-exp.y: Update all rules.
6307         (yylex): Update.
6308         * go-exp.y (yylex): Update.
6309         * f-exp.y (yylex): Update.
6310         * d-exp.y: Update all rules.
6311         (yylex): Update.
6312         * c-exp.y: Update all rules.
6313         (lex_one_token, classify_name, yylex, c_parse): Update.
6314         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6315
6316 2019-04-04  Tom Tromey  <tom@tromey.com>
6317
6318         * gdbarch.h, gdbarch.c: Rebuild.
6319         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6320         * stap-probe.h:
6321         (struct stap_parse_info): Replace "parser_state" with
6322         "expr_builder".
6323         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6324         (parser_state): New class.
6325         * parse.c (expr_builder): Rename.
6326         (expr_builder::release): Rename.
6327         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6328         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6329         (write_exp_elt_longcst, write_exp_elt_floatcst)
6330         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6331         (write_exp_string_vector, write_exp_bitstring)
6332         (write_exp_msymbol, mark_struct_expression)
6333         (write_dollar_variable)
6334         (insert_type_address_space, increase_expout_size): Replace
6335         "parser_state" with "expr_builder".
6336         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6337         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6338         "parser_state" with "expr_builder".
6339
6340 2019-04-04  Tom Tromey  <tom@tromey.com>
6341
6342         * rust-exp.y: Replace "parse_language" with method call.
6343         * p-exp.y:
6344         (yylex): Replace "parse_language" with method call.
6345         * m2-exp.y:
6346         (yylex): Replace "parse_language" with method call.
6347         * go-exp.y (classify_name): Replace "parse_language" with method
6348         call.
6349         * f-exp.y (yylex): Replace "parse_language" with method call.
6350         * d-exp.y (lex_one_token): Replace "parse_language" with method
6351         call.
6352         * c-exp.y:
6353         (lex_one_token, classify_name, yylex): Replace "parse_language"
6354         with method call.
6355         * ada-exp.y (find_primitive_type, type_char)
6356         (type_system_address): Replace "parse_language" with method call.
6357
6358 2019-04-04  Tom Tromey  <tom@tromey.com>
6359
6360         * rust-exp.y: Replace "parse_gdbarch" with method call.
6361         * parse.c (write_dollar_variable, insert_type_address_space):
6362         Replace "parse_gdbarch" with method call.
6363         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6364         call.
6365         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6366         call.
6367         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6368         "parse_gdbarch" with method call.
6369         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6370         with method call.
6371         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6372         "parse_gdbarch" with method call.
6373         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6374         "parse_gdbarch" with method call.
6375         * c-exp.y (parse_type, parse_number, classify_name): Replace
6376         "parse_gdbarch" with method call.
6377         * ada-lex.l: Replace "parse_gdbarch" with method call.
6378         * ada-exp.y (parse_type, find_primitive_type, type_char)
6379         (type_system_address): Replace "parse_gdbarch" with method call.
6380
6381 2019-04-04  Tom Tromey  <tom@tromey.com>
6382
6383         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6384         * stap-probe.c (stap_parse_argument): Update.
6385         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6386         initial_size parameter.
6387         * rust-exp.y (rust_lex_tests): Update.
6388         * parse.c (parser_state): Update.
6389         (parse_exp_in_context): Update.
6390         * parser-defs.h (struct parser_state) <parser_state>: Remove
6391         "initial_size" parameter.
6392
6393 2019-04-04  Tom Tromey  <tom@tromey.com>
6394
6395         * parser-defs.h (increase_expout_size): Don't declare.
6396         * parse.c (increase_expout_size): Now static.
6397
6398 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6399
6400         * gnu-nat.c (gnu_nat_target::wait): Fix
6401         target_waitstatus_to_string call.
6402
6403 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6404
6405         * eval.c (evaluate_subexp_standard): Handle internal functions
6406         during Fortran function call handling.
6407
6408 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6409
6410         * NEWS: Mention new internal functions.
6411         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6412         (read_base_type): Use dwarf2_init_complex_target_type.
6413         * value.c (creal_internal_fn): New function.
6414         (cimag_internal_fn): New function.
6415         (_initialize_values): Register new internal functions.
6416
6417 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6418
6419         * infrun.c (stop_all_threads): If debug_infrun, always
6420         trace the wait status after wait_one, using
6421         target_waitstatus_to_string and target_pid_to_str.
6422         (handle_inferior_event): Replace various trace of
6423         wait status kind by a single trace.
6424         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6425         wait status kind image by target_waitstatus_to_string.
6426         * target/waitstatus.c (target_waitstatus_to_string): Fix
6427         obsolete comment.
6428
6429 2019-04-01  Tom Tromey  <tromey@adacore.com>
6430
6431         PR symtab/23331:
6432         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6433
6434 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6435             Pedro Alves  <palves@redhat.com>
6436
6437         * top.c (quit_force): Call 'finalize_values'.
6438         * value.c (finalize_values): New function.
6439         * value.h (finalize_values): Declare.
6440
6441 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6442
6443         * NEWS: Announce $_gdb_major and $_gdb_minor.
6444
6445         * top.c (init_gdb_version_vars): New function.
6446         (gdb_init): Call init_gdb_version_vars.
6447
6448 2019-03-29  Tom Tromey  <tromey@adacore.com>
6449
6450         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6451         help text.  Remove dead code.
6452
6453 2019-03-29  Keith Seitz  <keiths@redhat.com>
6454
6455         From Siddhesh Poyarekar:
6456         * f-lang.h (f77_get_upperbound): Return LONGEST.
6457         (f77_get_lowerbound): Likewise.
6458         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6459         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6460         print them.
6461         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6462         plongest to format print it.
6463         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6464         (f77_get_upperbound): Likewise.
6465         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6466         LOWER_BOUND to LONGEST.
6467         (f77_create_arrayprint_offset_tbl): Likewise.
6468
6469 2019-03-29  Keith Seitz  <keiths@redhat.com>
6470
6471         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6472         %s/pulongest for TYPE_LENGTH instead of %d in format
6473         strings.
6474         * ada-typerint.c (ada_print_type): Likewise.
6475         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6476         * compile/compile-c-support.c (generate_register_struct): Likewise.
6477         * gdbtypes.c (recursive_dump_type): Likewise.
6478         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6479         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6480         instead of %d in format strings.
6481         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6482         to std::min to ULONGEST.
6483         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6484         instead of %d in format strings.
6485         * tracepoint.c (info_scope_command): Likewise.
6486         * typeprint.c (print_offset_data::update)
6487         (print_offset_data::finish): Likewise.
6488         * xtensa-tdep.c (xtensa_store_return_value)
6489         (xtensa_push_dummy_call): Likewise.
6490
6491 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6492
6493         * windows-nat.c (display_selector): Fixed format specifications
6494         for 64-bit Cygwin.
6495
6496 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6497
6498         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6499
6500 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6501
6502         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6503         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6504         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6505         (nios2_linux_init_abi): Install it.
6506
6507 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6508
6509         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6510
6511 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6512
6513         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6514
6515 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6516             Tom Tromey  <tromey@adacore.com>
6517
6518         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6519
6520 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6521
6522         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6523         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6524         method to compute the bounds of range types. Also print "[evaluated]"
6525         if the bounds' values come from a dynamic evaluation.
6526
6527 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6528
6529         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6530         whitespace when pretty printing is on.
6531
6532 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6533
6534         * ppc-linux-nat.c: Add include.
6535
6536 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6537
6538         * NEWS: Mention AArch64 Pointer Authentication.
6539
6540 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6541
6542         * arm-linux-nat.c: Add include.
6543
6544 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6545
6546         * source-cache.c (source_cache::get_source_lines): Re-read
6547         fullname after calling open_source_file.
6548
6549 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6550
6551         * NEWS: Mention TLS support for FreeBSD.
6552
6553 2019-03-25  Tom Tromey  <tromey@adacore.com>
6554
6555         * minsyms.c (BUNCH_SIZE): Update comment.
6556         (~minimal_symbol_reader): Remove old comment.
6557         (compact_minimal_symbols): Update comment.
6558         (minimal_symbol_reader::install): Remove old comment.  Update
6559         other comments.
6560
6561 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6562
6563         * s390-linux-nat.c: Add include.
6564
6565 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6566
6567         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6568         Call linux_get_hwcap.
6569         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6570         Likewise.
6571         (aarch64_linux_get_hwcap): Remove function.
6572         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6573         declaration.
6574         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6575         linux_get_hwcap.
6576         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6577         * linux-tdep.c (linux_get_hwcap): Add function.
6578         (linux_get_hwcap2): Likewise.
6579         * linux-tdep.h (linux_get_hwcap): Add declaration.
6580         (linux_get_hwcap2): Likewise.
6581         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6582         (ppc_linux_get_hwcap2): Likewise.
6583         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6584         linux_get_hwcap.
6585         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6586         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6587         (ppc_linux_nat_target::read_description): Likewise.
6588         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6589         * s390-linux-nat.c: Likewise.
6590         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6591
6592 2019-03-24  Tom Tromey  <tom@tromey.com>
6593
6594         * ada-lang.c (standard_lookup): Simplify initialization.
6595         (ada_lookup_symbol_nonlocal): Simplify return.
6596         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6597         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6598         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6599         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6600         initialization.
6601         * solib.c (solib_global_lookup): Simplify.
6602         * symtab.c (null_block_symbol): Remove.
6603         (symbol_cache_lookup): Simplify returns.
6604         (lookup_language_this): Simplify returns.
6605         (lookup_symbol_aux): Simplify return.
6606         (lookup_local_symbol): Simplify returns.
6607         (lookup_global_symbol_from_objfile): Simplify return.
6608         (lookup_symbol_in_objfile_symtabs)
6609         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6610         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6611         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6612         * cp-namespace.c (cp_lookup_bare_symbol)
6613         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6614         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6615         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6616         (cp_lookup_symbol_via_imports): Simplify initialization.
6617         (find_symbol_in_baseclass): Likewise.
6618         * symtab.h (null_block_symbol): Remove.
6619         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6620         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6621         (d_lookup_symbol_module): Likewise.
6622         (find_symbol_in_baseclass): Simplify initialization.
6623
6624 2019-03-24  Tom Tromey  <tom@tromey.com>
6625
6626         * expression.h: Don't include symtab.h.
6627         (struct block): Forward declare.
6628
6629 2019-03-24  Tom Tromey  <tom@tromey.com>
6630
6631         * c-exp.y (typebase): Remove casts.
6632         * gdbtypes.c (lookup_unsigned_typename, )
6633         (lookup_signed_typename): Remove cast.
6634         * eval.c (parse_to_comma_and_eval): Remove cast.
6635         * parse.c (write_dollar_variable): Remove cast.
6636         * block.h (struct block) <superblock>: Now const.
6637         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6638         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6639         (map_block): Make "block" const.
6640         * symfile.h (struct quick_symbol_functions)
6641         <map_matching_symbols>: Constify block argument to "callback".
6642         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6643         const.
6644         (find_pc_sect_compunit_symtab): Make "b" const.
6645         (find_symbol_at_address): Likewise.
6646         (search_symbols): Likewise.
6647         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6648         (dw2_debug_names_lookup_symbol): Likewise.
6649         (dw2_map_matching_symbols): Update.
6650         * p-valprint.c (pascal_val_print): Remove "block".
6651         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6652         (aux_add_nonlocal_symbols): Make "block" const.
6653         (resolve_subexp): Remove cast.
6654         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6655         const.
6656         (iterate_over_file_blocks): Likewise.
6657         * f-exp.y (%union) <bval>: Remove.
6658         * coffread.c (patch_opaque_types): Make "b" const.
6659         * spu-tdep.c (spu_catch_start): Make "block" const.
6660         * c-valprint.c (print_unpacked_pointer): Remove "block".
6661         * symmisc.c (dump_symtab_1): Make "b" const.
6662         (block_depth): Make "block" const.
6663         * d-exp.y (%union) <bval>: Remove.
6664         * cp-support.h (cp_lookup_rtti_type): Update.
6665         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6666         * psymtab.c (psym_lookup_symbol): Make "block" const.
6667         (maintenance_check_psymtabs): Make "b" const.
6668         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6669         (enumerate_locals, enumerate_args): Update.
6670         * python/py-symtab.c (stpy_global_block): Make "block" const.
6671         (stpy_static_block): Likewise.
6672         * inline-frame.c (block_starting_point_at): Make "new_block"
6673         const.
6674         * block.c (find_block_in_blockvector): Make return type const.
6675         (blockvector_for_pc_sect): Make "b" const.
6676         (find_block_in_blockvector): Make "b" const.
6677
6678 2019-03-23  Tom Tromey  <tom@tromey.com>
6679
6680         * varobj.c (varobj_create): Update.
6681         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6682         * printcmd.c (display_command, do_one_display): Don't reset
6683         innermost_block.
6684         * parser-defs.h (enum innermost_block_tracker_type): Move to
6685         expression.h.
6686         (innermost_block): Update comment.
6687         * parse.c (parse_exp_1): Add tracker_types parameter.
6688         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6689         tracker_types parameter.  Reset innermost_block.
6690         (parse_exp_in_context): Remove.
6691         (parse_expression_for_completion): Update.
6692         * objfiles.c (~objfile): Don't reset expression_context_block or
6693         innermost_block.
6694         * expression.h (enum innermost_block_tracker_type): Move from
6695         parser-defs.h.
6696         (parse_exp_1): Add tracker_types parameter.
6697         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6698         reset innermost_block.
6699
6700 2019-03-23  Tom Tromey  <tom@tromey.com>
6701
6702         * objfiles.h: Include bcache.h.
6703
6704 2019-03-23  Tom Tromey  <tom@tromey.com>
6705
6706         * linespec.c (get_current_search_block): Use
6707         scoped_restore_current_language.
6708         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6709
6710 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6711             Jiong Wang  <jiong.wang@arm.com>
6712
6713         * aarch64-linux-tdep.c
6714         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6715         section.
6716         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6717
6718 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6719             Jiong Wang  <jiong.wang@arm.com>
6720
6721         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6722         instructions.
6723         (aarch64_analyze_prologue_test): Add PACIASP test.
6724         (aarch64_prologue_prev_register): Unmask PC value.
6725
6726 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6727             Jiong Wang  <jiong.wang@arm.com>
6728
6729         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6730         (aarch64_dwarf2_prev_register): Unmask PC value.
6731         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6732         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6733         DW_CFA_AARCH64_negate_ra_state.
6734         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6735
6736 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6737             Jiong Wang  <jiong.wang@arm.com>
6738
6739         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6740         registers.
6741         (aarch64_pseudo_register_name): Likewise.
6742         (aarch64_pseudo_register_type): Likewise.
6743         (aarch64_pseudo_register_reggroup_p): Likewise.
6744         (aarch64_gdbarch_init): Add pauth registers.
6745         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6746         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6747         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6748         (struct gdbarch_tdep): Add regnum for ra_state.
6749
6750 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6751             Jiong Wang  <jiong.wang@arm.com>
6752
6753         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6754
6755 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6756             Jiong Wang  <jiong.wang@arm.com>
6757
6758         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6759         function.
6760         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6761         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6762         (aarch64_gdbarch_init): Add puth registers.
6763         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6764         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6765         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6766
6767 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6768             Jiong Wang  <jiong.wang@arm.com>
6769
6770         * aarch64-linux-nat.c
6771         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6772         * aarch64-linux-tdep.c
6773         (aarch64_linux_core_read_description): Likewise.
6774         (aarch64_linux_get_hwcap): New function.
6775         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6776         (aarch64_linux_get_hwcap): New declaration.
6777
6778 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6779             Jiong Wang  <jiong.wang@arm.com>
6780
6781         * aarch64-linux-nat.c
6782         (aarch64_linux_nat_target::read_description): Add pauth param.
6783         * aarch64-linux-tdep.c
6784         (aarch64_linux_core_read_description): Likewise.
6785         * aarch64-tdep.c (struct target_desc): Add in pauth.
6786         (aarch64_read_description): Add pauth param.
6787         (aarch64_gdbarch_init): Likewise.
6788         * aarch64-tdep.h (aarch64_read_description): Likewise.
6789         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6790         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6791         * features/Makefile: Add new files.
6792         * features/aarch64-pauth.c: New file.
6793         * features/aarch64-pauth.xml: New file.
6794
6795 2019-03-20  Tom Tromey  <tromey@adacore.com>
6796
6797         * infrun.c (handle_inferior_event): Rename from
6798         handle_inferior_event_1.  Create a scoped_value_mark.
6799         (handle_inferior_event): Remove.
6800
6801 2019-03-19  Tom Tromey  <tromey@adacore.com>
6802
6803         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6804         * infrun.h (print_stop_event): Add "displays" parameter.
6805         * infrun.c (print_stop_event): Add "displays" parameter.
6806
6807 2019-03-19  Pedro Alves  <palves@redhat.com>
6808
6809         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6810         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6811         to -1.  Fix TABs vs spaces.
6812         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6813         * tui/tui-out.h (tui_ui_out) Add intro comments.
6814         <m_line, m_start_of_line>: In-class initialize, and add describing
6815         comment.
6816
6817 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6818
6819         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6820         variable names.
6821         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6822
6823 2019-03-18  Pedro Alves  <palves@redhat.com>
6824             Eli Zaretskii <eliz@gnu.org>
6825
6826         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6827         m_line and m_start_of_line.
6828
6829 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6830
6831         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6832         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6833         it returns a newline.  This fixes a regression in TU mode, whereby
6834         the next line is output on the same screen line as the user input.
6835
6836 2019-03-18  Tom Tromey  <tromey@adacore.com>
6837
6838         * minsyms.c (minimal_symbol_reader::install): Remove call to
6839         obstack_blank.
6840
6841 2019-03-18  Pedro Alves  <palves@redhat.com>
6842
6843         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6844         New globals.
6845         (apply_style): New, factored out from ...
6846         (apply_ansi_escape): ... this.  Handle reverse video mode.
6847         (tui_set_reverse_mode): New function.
6848         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6849         * tui/tui-winsource.c (tui_show_source_line): Use
6850         tui_set_reverse_mode instead of setting A_STANDOUT.
6851         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6852         New setter methods.
6853
6854 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6855
6856         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6857         Handle tabs.
6858
6859 2019-03-18  Tom Tromey  <tromey@adacore.com>
6860
6861         * ada-lang.c (empty_array): Add "high" parameter.
6862         (ada_evaluate_subexp): Update.
6863
6864 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6865
6866         * unittests/string_view-selftests.c: Define
6867         _initialize_string_view_selftests unconditionally.
6868
6869 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6870
6871         PR gdb/24350
6872         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6873
6874 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6875
6876         PR gdb/24351
6877         * windows-nat.c (display_selector): Fix format specifiers.
6878
6879 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6880
6881         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6882         tui_refill_source_window instead of tui_refresh_win, to update the
6883         current execution line.  This fixes redisplay of the current line
6884         when stepping through the code with "next" or "step".
6885
6886 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6887
6888         * source-cache.c (source_cache::get_source_lines): Call
6889         find_source_lines to initialize s->nlines.  This fixes vertical
6890         scrolling of TUI source window when the DOWN arrow is pressed.
6891
6892 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6893
6894         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6895         linux-thread-db.c (_initialize_thread_db): Likewise.
6896
6897 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6898
6899         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6900         wclrtoeol in tui_show_source_line".  This reverts changes made in
6901         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6902
6903 2019-03-15  Tom Tromey  <tom@tromey.com>
6904
6905         * symtab.h (struct minimal_symbol): Derive from
6906         general_symbol_info.
6907         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6908         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6909         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6910         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6911         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6912         (MSYMBOL_SEARCH_NAME): Update.
6913         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6914         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6915         * minsyms.c (minimal_symbol_reader::record_full): Update.
6916
6917 2019-03-15  Tom Tromey  <tom@tromey.com>
6918
6919         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6920
6921 2019-03-15  Tom Tromey  <tom@tromey.com>
6922
6923         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6924         unique_xmalloc_ptr.
6925         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6926         Update.
6927         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6928         (build_minimal_symbol_hash_tables)
6929         (minimal_symbol_reader::install): Update.
6930
6931 2019-03-15  Tom Tromey  <tom@tromey.com>
6932
6933         * symtab.c (create_demangled_names_hash): Update.
6934         (symbol_set_names): Update.
6935         * objfiles.h (struct objfile_per_bfd_storage)
6936         <demangled_names_hash>: Now an htab_up.
6937         * objfiles.c (objfile_per_bfd_storage): Simplify.
6938
6939 2019-03-15  Tom Tromey  <tom@tromey.com>
6940
6941         * objfiles.h (struct objfile_per_bfd_storage): Declare
6942         destructor.
6943         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6944         New.
6945         (get_objfile_bfd_data): Use new.  Don't initialize
6946         language_of_main.
6947         (free_objfile_per_bfd_storage): Remove.
6948         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6949
6950 2019-03-15  Tom Tromey  <tom@tromey.com>
6951
6952         * symfile.c (reread_symbols): Update.
6953         * objfiles.c (objfile::objfile): Update.
6954         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6955         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6956         comment.
6957         (minimal_symbol_reader::install): Update.
6958         (terminate_minimal_symbol_table): Remove.
6959         * jit.c (jit_object_close_impl): Update.
6960
6961 2019-03-15  Tom Tromey  <tom@tromey.com>
6962
6963         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6964         initializations.
6965
6966 2019-03-15  Tom Tromey  <tom@tromey.com>
6967
6968         * objfiles.h (struct objfile_per_bfd_storage)
6969         <demangled_hash_languages>: Now a bitset.
6970         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6971         (lookup_minimal_symbol): Update.
6972
6973 2019-03-15  Tom Tromey  <tom@tromey.com>
6974
6975         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6976         Don't return the symbol.
6977         * coffread.c (record_minimal_symbol): Use record_full.
6978
6979 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6980
6981         The MS-Windows port of ncurses fails to switch to a color pair if
6982         one or both of the colors are the implicit default colors.  This
6983         change records the default colors when TUI is initialized, and
6984         then specifies them explicitly when a color pair uses the default
6985         colors.  This allows color styling in TUI mode on MS-Windows.
6986
6987         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6988         ncurses_norm_attr.
6989         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6990         colors in ncurses_norm_attr.
6991         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6992         "none", replace it with the default color recorded in
6993         ncurses_norm_attr.
6994
6995 2019-03-14  Tom Tromey  <tromey@adacore.com>
6996
6997         * source-cache.h (class source_cache) <get_source_lines>: Return
6998         std::string.
6999         * source-cache.c (source_cache::extract_lines): Handle case where
7000         first_pos==npos.  Return std::string.
7001         (source_cache::get_source_lines): Update.
7002
7003 2019-03-14  Tom Tromey  <tromey@adacore.com>
7004
7005         * NEWS: Add item for "style sources" commands.
7006         * source-cache.c (source_cache::get_source_lines): Check
7007         source_styling.
7008         * cli/cli-style.c (source_styling): New global.
7009         (_initialize_cli_style): Add "style sources" commands.
7010         (show_style_sources): New function.
7011         * cli/cli-style.h (source_styling): Declare.
7012
7013 2019-03-14  Pedro Alves  <palves@redhat.com>
7014             Tom Tromey  <tromey@adacore.com>
7015
7016         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7017         * tui/tui-winsource.c (tui_refill_source_window): New function,
7018         from...
7019         (tui_horizontal_source_scroll): ... here.  Move some logic.
7020         * cli/cli-style.c (set_style_enabled): Notify new observable.
7021         * tui/tui-hooks.c (tui_redisplay_source): New function.
7022         (tui_attach_detach_observers): Attach or detach
7023         tui_redisplay_source.
7024         * observable.h (source_styling_changed): New observable.
7025         * observable.c: Define source_styling_changed observable.
7026
7027 2019-03-13  Tom Tromey  <tromey@adacore.com>
7028
7029         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7030         (i386_gnu_nat_target::store_registers): Update.
7031         * target-debug.h (target_debug_print_std_string): New macro.
7032         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7033         * windows-tdep.c (display_one_tib): Update.
7034         * tui/tui-stack.c (tui_make_status_line): Update.
7035         * top.c (print_inferior_quit_action): Update.
7036         * thread.c (thr_try_catch_cmd): Update.
7037         (add_thread_with_info): Update.
7038         (thread_target_id_str): Update.
7039         (thr_try_catch_cmd): Update.
7040         (thread_command): Update.
7041         (thread_find_command): Update.
7042         * record-btrace.c (record_btrace_target::info_record)
7043         (record_btrace_resume_thread, record_btrace_target::resume)
7044         (record_btrace_cancel_resume, record_btrace_step_thread)
7045         (record_btrace_target::wait, record_btrace_target::wait)
7046         (record_btrace_target::wait, record_btrace_target::stop): Update.
7047         * progspace.c (print_program_space): Update.
7048         * process-stratum-target.c
7049         (process_stratum_target::thread_address_space): Update.
7050         * linux-fork.c (linux_fork_mourn_inferior)
7051         (detach_checkpoint_command, info_checkpoints_command)
7052         (linux_fork_context): Update.
7053         (linux_fork_detach): Update.
7054         (class scoped_switch_fork_info): Update.
7055         (delete_checkpoint_command): Update.
7056         * infrun.c (follow_fork_inferior): Update.
7057         (follow_fork_inferior): Update.
7058         (proceed_after_vfork_done): Update.
7059         (handle_vfork_child_exec_or_exit): Update.
7060         (follow_exec): Update.
7061         (displaced_step_prepare_throw): Update.
7062         (displaced_step_restore): Update.
7063         (start_step_over): Update.
7064         (resume_1): Update.
7065         (clear_proceed_status_thread): Update.
7066         (proceed): Update.
7067         (print_target_wait_results): Update.
7068         (do_target_wait): Update.
7069         (context_switch): Update.
7070         (stop_all_threads): Update.
7071         (restart_threads): Update.
7072         (finish_step_over): Update.
7073         (handle_signal_stop): Update.
7074         (switch_back_to_stepped_thread): Update.
7075         (keep_going_pass_signal): Update.
7076         (print_exited_reason): Update.
7077         (normal_stop): Update.
7078         * inferior.c (inferior_pid_to_str): Change return type.
7079         (print_selected_inferior): Update.
7080         (add_inferior): Update.
7081         (detach_inferior): Update.
7082         * dummy-frame.c (fprint_dummy_frames): Update.
7083         * dcache.c (dcache_info_1): Update.
7084         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7085         (btrace_fetch, btrace_clear): Update.
7086         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7087         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7088         type.
7089         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7090         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7091         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7092         * gdbarch.c, gdbarch.h: Rebuild.
7093         * gdbarch.sh (core_pid_to_str): Change return type.
7094         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7095         return type.
7096         (windows_nat_target::pid_to_str): Change return type.
7097         (windows_delete_thread): Update.
7098         (windows_nat_target::attach): Update.
7099         (windows_nat_target::files_info): Update.
7100         * target-delegates.c: Rebuild.
7101         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7102         return type.
7103         (sol_thread_target::pid_to_str): Change return type.
7104         * remote.c (class remote_target) <pid_to_str>: Change return
7105         type.
7106         (remote_target::pid_to_str): Change return type.
7107         (extended_remote_target::attach, remote_target::remote_stop_ns)
7108         (remote_target::remote_notif_remove_queued_reply)
7109         (remote_target::push_stop_reply, remote_target::disable_btrace):
7110         Update.
7111         (extended_remote_target::attach): Update.
7112         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7113         type.
7114         (gdbsim_target::pid_to_str): Change return type.
7115         * ravenscar-thread.c (struct ravenscar_thread_target)
7116         <pid_to_str>: Change return type.
7117         (ravenscar_thread_target::pid_to_str): Change return type.
7118         * procfs.c (class procfs_target) <pid_to_str>: Change return
7119         type.
7120         (procfs_target::pid_to_str): Change return type.
7121         (procfs_target::attach): Update.
7122         (procfs_target::detach): Update.
7123         (procfs_target::fetch_registers): Update.
7124         (procfs_target::store_registers): Update.
7125         (procfs_target::wait): Update.
7126         (procfs_target::files_info): Update.
7127         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7128         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7129         return type.
7130         (nto_procfs_target::pid_to_str): Change return type.
7131         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7132         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7133         return type.
7134         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7135         (exit_lwp): Update.
7136         (attach_proc_task_lwp_callback, get_detach_signal)
7137         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7138         (linux_nat_target::resume, wait_lwp, stop_callback)
7139         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7140         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7141         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7142         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7143         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7144         type.
7145         (inf_ptrace_target::attach): Update.
7146         (inf_ptrace_target::files_info): Update.
7147         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7148         type.
7149         (go32_nat_target::pid_to_str): Change return type.
7150         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7151         (gnu_nat_target::wait): Update.
7152         (gnu_nat_target::wait): Update.
7153         (gnu_nat_target::resume): Update.
7154         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7155         (fbsd_nat_target::wait): Update.
7156         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7157         type.
7158         (darwin_nat_target::attach): Update.
7159         * corelow.c (class core_target) <pid_to_str>: Change return type.
7160         (core_target::pid_to_str): Change return type.
7161         * target.c (normal_pid_to_str): Change return type.
7162         (default_pid_to_str): Likewise.
7163         (target_pid_to_str): Change return type.
7164         (target_translate_tls_address): Update.
7165         (target_announce_detach): Update.
7166         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7167         return type.
7168         (bsd_uthread_target::pid_to_str): Change return type.
7169         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7170         type.
7171         (bsd_kvm_target::pid_to_str): Change return type.
7172         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7173         return type.
7174         (aix_thread_target::pid_to_str): Change return type.
7175         * target.h (struct target_ops) <pid_to_str>: Change return type.
7176         (target_pid_to_str, normal_pid_to_str): Likewise.
7177         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7178         type.
7179         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7180         type.
7181         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7182         return type.
7183         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7184         type.
7185         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7186         type.
7187         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7188         return type.
7189
7190 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7191
7192         * NEWS: Mention that the new default MI version is 3.  Mention
7193         changes to the output of commands and events that deal with
7194         multi-location breakpoints.
7195         * breakpoint.c: Include "mi/mi-out.h".
7196         (print_one_breakpoint): Change output syntax if using MI version
7197         >= 3.
7198         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7199         New.
7200         (mi_multi_location_breakpoint_output_fixed): New.
7201         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7202         (mi_cmd_fix_multi_location_breakpoint_output): New.
7203         (mi_multi_location_breakpoint_output_fixed): New.
7204         * mi/mi-cmds.c (mi_cmds): Register command
7205         -fix-multi-location-breakpoint-output.
7206         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7207         interpreter "mi".
7208
7209 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7210
7211         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7212         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7213         instantiate mi_ui_out based on interpreter name.
7214         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7215         * mi/mi-main.c (mi_load_progress): Likewise.
7216
7217 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7218
7219         * NEWS: Combine separate "New targets" sections for 8.3.
7220
7221 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7222
7223         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7224         (ppcfbsd_init_abi): Install gdbarch
7225         "fetch_tls_load_module_address" and "get_thread_local_address"
7226         methods.
7227
7228 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7229
7230         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7231         (riscv_fbsd_init_abi): Install gdbarch
7232         "fetch_tls_load_module_address" and "get_thread_local_address"
7233         methods.
7234
7235 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7236
7237         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7238         (i386fbsd_init_abi): Install gdbarch
7239         "fetch_tls_load_module_address" and "get_thread_local_address"
7240         methods.
7241
7242 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7243
7244         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7245         (amd64fbsd_init_abi): Install gdbarch
7246         "fetch_tls_load_module_address" and "get_thread_local_address"
7247         methods.
7248
7249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7250
7251         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7252         (struct fbsd_pspace_data): New type.
7253         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7254         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7255         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7256         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7257         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7258
7259 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7260
7261         * gdbtypes.c (lookup_struct_elt): New function.
7262         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7263         * gdbtypes.h (struct struct_elt): New type.
7264         (lookup_struct_elt): New prototype.
7265
7266 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7267
7268         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7269         remove disabled code block.
7270
7271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7272
7273         * gdbarch.sh (get_thread_local_address): New method.
7274         * gdbarch.h, gdbarch.c: Regenerate.
7275         * target.c (target_translate_tls_address): Use
7276         gdbarch_get_thread_local_address if present instead of
7277         target::get_thread_local_address.
7278
7279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7280
7281         * target.h (target::get_thread_local_address): Update comment.
7282
7283 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7284
7285         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7286         objfile->separate_debug_objfile_backlink if not NULL.
7287
7288 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7289
7290         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7291         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7292         (amd64bsd_store_inferior_registers): Likewise.
7293         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7294         Enable segment base registers.
7295         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7296         PT_GETFSBASE and PT_GETGSBASE.
7297         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7298         PT_SETGSBASE.
7299         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7300         segment base registers.
7301         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7302
7303 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7304
7305         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7306         Update calls to i386_target_description to add 'segments'
7307         parameter.
7308         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7309         add segment base registers.
7310         * arch/i386.c (i386_create_target_description): Add 'segments'
7311         parameter to enable segment base registers.
7312         * arch/i386.h (i386_create_target_description): Likewise.
7313         * features/i386/32bit-segments.xml: New file.
7314         * features/i386/32bit-segments.c: Generate.
7315         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7316         call to i386_target_description to add 'segments' parameter.
7317         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7318         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7319         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7320         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7321         if feature is present.
7322         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7323         Add 'segments' parameter to call to i386_target_description.
7324         (i386_target_description): Add 'segments' parameter to enable
7325         segment base registers.
7326         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7327         to call to i386_target_description.
7328         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7329         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7330         Define I386_NUM_REGS.
7331         (i386_target_description): Add 'segments' parameter to enable
7332         segment base registers.
7333
7334 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7335
7336         PR/24325
7337         * source-cache.c: #undef open and close, to avoid unresolved
7338         externals during linking.
7339
7340 2019-03-12  Tom Tromey  <tromey@adacore.com>
7341
7342         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7343         const.  Add initializers.
7344         (_initialize_remote): Don't initialize ptid globals.
7345
7346 2019-03-12  Pedro Alves  <palves@redhat.com>
7347
7348         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7349
7350 2019-03-12  Pedro Alves  <palves@redhat.com>
7351
7352         * cp-name-parser.y (main): Remove unused 'len' variable.
7353
7354 2019-03-12  Tom Tromey  <tromey@adacore.com>
7355
7356         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7357         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7358
7359 2019-03-12  Tom Tromey  <tromey@adacore.com>
7360
7361         * linux-nat.c (iterate_over_lwps): Update.
7362         (stop_callback): Remove parameter.
7363         (stop_wait_callback, detach_callback, resume_set_callback)
7364         (select_singlestep_lwp_callback, set_ignore_sigint)
7365         (status_callback, resumed_callback, resume_clear_callback)
7366         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7367         data parameter.
7368         (linux_nat_target::detach, linux_nat_target::resume)
7369         (linux_stop_and_wait_all_lwps, select_event_lwp)
7370         (linux_nat_filter_event, linux_nat_wait_1)
7371         (linux_nat_target::kill, linux_nat_target::stop)
7372         (linux_nat_target::stop): Update.
7373         (linux_nat_resume_callback): Change type.
7374         (resume_stopped_resumed_lwps, count_events_callback)
7375         (select_event_lwp_callback): Likewise.
7376         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7377         * arm-linux-nat.c (struct update_registers_data): Remove.
7378         (update_registers_callback): Change type.
7379         (arm_linux_insert_hw_breakpoint1): Update.
7380         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7381         parameter.
7382         (x86_linux_dr_set_addr): Update.
7383         (x86_linux_dr_set_control): Update.
7384         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7385         (iterate_over_lwps): Use gdb::function_view.
7386         * nat/aarch64-linux-hw-point.c (struct
7387         aarch64_dr_update_callback_param): Remove.
7388         (debug_reg_change_callback): Change type.
7389         (aarch64_notify_debug_reg_change): Update.
7390         * s390-linux-nat.c (s390_refresh_per_info): Update.
7391
7392 2019-03-11  Tom Tromey  <tromey@adacore.com>
7393
7394         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7395         redundant assignment to "this_cu".
7396
7397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7398
7399         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7400
7401 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7402
7403         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7404         from...
7405         (rank_one_type): ... this.
7406
7407 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7408
7409         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7410         from...
7411         (rank_one_type): ... this.
7412
7413 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7414
7415         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7416         from...
7417         (rank_one_type): ... this.
7418
7419 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7420
7421         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7422         from...
7423         (rank_one_type): ... this.
7424
7425 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7426
7427         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7428         from...
7429         (rank_one_type): ... this.
7430
7431 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7432
7433         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7434         from...
7435         (rank_one_type): ... this.
7436
7437 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7438
7439         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7440         from...
7441         (rank_one_type): ... this.
7442
7443 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7444
7445         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7446         from...
7447         (rank_one_type): ... this.
7448
7449 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7450
7451         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7452         from...
7453         (rank_one_type): ... this.
7454
7455 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7456
7457         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7458         from...
7459         (rank_one_type): ... this.
7460
7461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7462
7463         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7464         from...
7465         (rank_one_type): ... this.
7466
7467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7468
7469         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7470         from...
7471         (rank_one_type): ... this.
7472
7473 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7474
7475         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7476         inferior-events' shows the example events.
7477
7478 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7479
7480         Support styling on native MS-Windows console
7481
7482         PR/24315
7483         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7484         on MS-Windows if $TERM is not defined.
7485
7486         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7487
7488         * posix-hdep.c (gdb_console_fputs):
7489         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7490         functions.
7491         * ui-file.h (gdb_console_fputs): Add prototype.
7492
7493         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7494         back to fputs only if the former returns zero.
7495
7496 2019-03-07  Tom Tromey  <tom@tromey.com>
7497
7498         * symmisc.c (print_symbol_bcache_statistics): Update.
7499         (print_objfile_statistics): Update.
7500         * symfile.c (allocate_symtab): Update.
7501         * stabsread.c: Don't include bcache.h.
7502         * psymtab.h (struct psymbol_bcache): Don't declare.
7503         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7504         (psymbol_bcache_init, psymbol_bcache_free)
7505         (psymbol_bcache_get_bcache): Don't declare.
7506         * psymtab.c (struct psymbol_bcache): Remove.
7507         (psymtab_storage::psymtab_storage): Update.
7508         (psymtab_storage::~psymtab_storage): Update.
7509         (psymbol_bcache_init, psymbol_bcache_free)
7510         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7511         (add_psymbol_to_bcache): Update.
7512         (allocate_psymtab): Update.
7513         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7514         macro_cache>: No longer pointers.
7515         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7516         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7517         * macrotab.c (macro_bcache): Update.
7518         * macroexp.c: Don't include bcache.h.
7519         * gdbtypes.c (check_types_worklist): Update.
7520         (types_deeply_equal): Remove TRY/CATCH.  Update.
7521         * elfread.c (elf_symtab_read): Update.
7522         * dwarf2read.c: Don't include bcache.h.
7523         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7524         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7525         (print_bcache_statistics, bcache_memory_used): Don't declare.
7526         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7527         methods.  Rename all data members.
7528         * bcache.c (struct bcache): Move to bcache.h.
7529         (bcache::expand_hash_table): Rename from expand_hash_table.
7530         (bcache): Remove.
7531         (bcache::insert): Rename from bcache_full.
7532         (bcache::compare): Rename from bcache_compare.
7533         (bcache_xmalloc): Remove.
7534         (bcache::~bcache): Rename from bcache_xfree.
7535         (bcache::print_statistics): Rename from print_bcache_statistics.
7536         (bcache::memory_used): Rename from bcache_memory_used.
7537
7538 2019-03-07  Pedro Alves  <palves@redhat.com>
7539
7540         * infrun.c (normal_stop): Also check for
7541         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7542
7543 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7544
7545         * f-lang.c (value_from_host_double): Moved to...
7546         * value.c (value_from_host_double): ...here.
7547         * value.h (value_from_host_double): Declare.
7548         * guile/scm-math.c (vlscm_convert_typed_number): Use
7549         value_from_host_double.
7550         (vlscm_convert_number): Likewise.
7551         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7552         * python/py-value.c (convert_value_from_python): Likewise.
7553
7554 2019-03-06  Tom Tromey  <tom@tromey.com>
7555
7556         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7557
7558 2019-03-06  Tom Tromey  <tom@tromey.com>
7559
7560         * utils.h (free_current_contents): Don't declare.
7561         * utils.c (free_current_contents): Remove.
7562
7563 2019-03-06  Tom Tromey  <tom@tromey.com>
7564
7565         * top.c (quit_force): Update.
7566         * main.c (captured_command_loop): Update.
7567         * common/new-op.c (operator new): Update.
7568         * common/common-exceptions.c (struct catcher)
7569         <save_cleanup_chain>: Remove member.
7570         (exceptions_state_mc_init): Update.
7571         (exception_try_scope_entry): Return nullptr.
7572         (exception_try_scope_exit, exception_rethrow)
7573         (throw_exception_sjlj, throw_exception_cxx): Update.
7574         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7575         (all_cleanups, do_cleanups, discard_cleanups)
7576         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7577         (restore_cleanups, restore_final_cleanups): Don't declare.
7578         (do_final_cleanups): Remove parameter.
7579         * common/cleanups.c (cleanup_chain, make_cleanup)
7580         (make_cleanup_dtor, all_cleanups, do_cleanups)
7581         (discard_my_cleanups, discard_cleanups)
7582         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7583         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7584         (null_cleanup): Remove.
7585         (do_final_cleanups): Remove parameter.
7586
7587 2019-03-06  Tom Tromey  <tom@tromey.com>
7588
7589         * remote.c (remote_target::remote_parse_stop_reply): Use
7590         unique_xmalloc_ptr.
7591
7592 2019-03-06  Tom Tromey  <tom@tromey.com>
7593
7594         * stabsread.c (struct stabs_field_info): Rename from field_info.
7595         <list, fnlist>: Add initializers.
7596         <obstack>: New member.
7597         (read_member_functions, read_struct_fields, read_baseclasses):
7598         Allocate on obstack.  Don't use cleanups.
7599         (read_one_struct_field, read_member_functions, read_struct_fields)
7600         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7601         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7602         (read_struct_type): Update.
7603
7604 2019-03-06  Tom Tromey  <tom@tromey.com>
7605
7606         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7607         * common/filestuff.h (make_cleanup_close): Don't declare.
7608         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7609         Remove.
7610
7611 2019-03-06  Tom Tromey  <tom@tromey.com>
7612
7613         * solib-aix.c: Use make_scope_exit.
7614
7615 2019-03-06  Tom Tromey  <tom@tromey.com>
7616
7617         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7618         Use make_scope_exit.
7619
7620 2019-03-06  Tom Tromey  <tom@tromey.com>
7621
7622         * solib-svr4.c (disable_probes_interface): Remove parameter.
7623         (svr4_handle_solib_event): Use make_scope_exit.
7624
7625 2019-03-06  Tom Tromey  <tom@tromey.com>
7626
7627         * remote.c (struct stop_reply_deleter): Remove.
7628         (stop_reply_up): Update.
7629         (struct stop_reply): Derive from notif_event.  Don't typedef.
7630         <regcache>: Now a std::vector.
7631         (stop_reply_xfree): Remove.
7632         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7633         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7634         (remote_target::discard_pending_stop_replies): Use delete.
7635         (remote_target::remote_parse_stop_reply): Update.
7636         (remote_target::process_stop_reply): Update.
7637         * remote-notif.h (struct notif_event): Add virtual destructor.
7638         Remove "dtr" member.
7639         (struct notif_client) <alloc_event>: Return a unique_ptr.
7640         (notif_event_xfree): Don't declare.
7641         (notif_event_up): New typedef.
7642         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7643         (notif_event_xfree, do_notif_event_xfree): Remove.
7644         (remote_notif_state_xfree): Update.
7645
7646 2019-03-06  Tom Tromey  <tom@tromey.com>
7647
7648         * infrun.c (displaced_step_clear_cleanup): Now a
7649         forward_scope_exit type.
7650         (displaced_step_prepare_throw): Update.
7651         (displaced_step_fixup): Update.
7652
7653 2019-03-06  Tom Tromey  <tom@tromey.com>
7654
7655         * inferior.h (class inferior): Update comment.
7656         * gdbthread.h (class thread_info): Update comment.
7657
7658 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7659             Tom Tromey  <tom@tromey.com>
7660
7661         * stabsread.h (struct stab_section_list): Remove.
7662         (coffstab_build_psymtabs): Update.
7663         * dbxread.c (symbuf_sections): Now a std::vector.
7664         (sect_idx): New global.
7665         (fill_symbuf): Update.
7666         (coffstab_build_psymtabs): Change type of stabsects parameter.
7667         Update.
7668         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7669         std::vector.
7670         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7671         (coff_locate_sections): Update.
7672         (coff_symfile_read): Remove cleanups.  Update.
7673         (init_stringtab): Add storage parameter.
7674         (free_stringtab, free_stringtab_cleanup): Remove.
7675         (init_lineno): Add storage parameter.
7676         (free_linetab, free_linetab_cleanup): Remove.
7677
7678 2019-03-06  Pedro Alves  <palves@redhat.com>
7679
7680         * linux-fork.c (fork_info::clobber_regs): Delete.
7681         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7682         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7683         comment.  Adjust.
7684         (scoped_switch_fork_info::scoped_switch_fork_info)
7685         (checkpoint_command, linux_fork_context): Adjust
7686         fork_save_infrun_state calls.
7687
7688 2019-03-06  Pedro Alves  <palves@redhat.com>
7689
7690         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7691         (inf_has_multiple_threads): Return 'bool' and rewrite using
7692         inferior_info::threads().
7693
7694 2019-03-06  Pedro Alves  <palves@redhat.com>
7695
7696         * linux-fork.c: Include <list>.
7697         (fork_list): Now a std::list instance.
7698         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7699         (forks_exist_p, find_last_fork): Adjust.
7700         (new_fork): Delete.
7701         (one_fork_p): New.
7702         (add_fork): Adjust.
7703         (free_fork): Delete, folded into fork_info::~fork_info().
7704         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7705         Adjust.
7706         (init_fork_list): Delete.
7707         (linux_fork_killall, linux_fork_mourn_inferior)
7708         (linux_fork_detach, info_checkpoints_command): Adjust.
7709         (_initialize_linux_fork): No longer call init_fork_list.
7710
7711 2019-03-06  Pedro Alves  <palves@redhat.com>
7712
7713         * linux-fork.c (new_fork): New, split out of ...
7714         (add_fork): ... this.  Return void.  Move "first fork" special
7715         case from here, to ...
7716         (checkpoint_command): ... here.
7717         * linux-linux.h (add_fork): Return void.
7718
7719 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7720
7721         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7722
7723 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7724             Chris January  <chris.january@arm.com>
7725             David Lecomber  <david.lecomber@arm.com>
7726
7727         * f-exp.y: New token, UNOP_INTRINSIC.
7728         (exp): New pattern using UNOP_INTRINSIC token.
7729         (f77_keywords): Add 'abs' keyword.
7730         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7731         (value_from_host_double): New function.
7732         (evaluate_subexp_f): Support UNOP_ABS.
7733
7734 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7735
7736         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7737         types.
7738
7739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7740
7741         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7742         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7743         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7744
7745 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7746
7747         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7748
7749 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7750             Chris January  <chris.january@arm.com>
7751
7752         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7753         * f-exp.y: Define 'KIND' token.
7754         (exp): New pattern for KIND expressions.
7755         (ptype): Handle types with a kind extension.
7756         (direct_abs_decl): Extend to spot kind extensions.
7757         (f77_keywords): Add 'kind' to the list.
7758         (push_kind_type): New function.
7759         (convert_to_kind_type): New function.
7760         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7761         * parse.c (operator_length_standard): Likewise.
7762         * parser-defs.h (enum type_pieces): Add tp_kind.
7763         * std-operator.def: Add UNOP_KIND.
7764
7765 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7766
7767         * f-exp.y (f_parse): Set yydebug.
7768
7769 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7770
7771         * f-lang.c (evaluate_subexp_f): New function.
7772         (exp_descriptor_f): New global.
7773         (f_language_defn): Use exp_descriptor_f instead of
7774         exp_descriptor_standard.
7775
7776 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7777
7778         * f-exp.y (struct token): Add comments.
7779         (dot_ops): Remove uppercase versions and the end marker.
7780         (f77_keywords): Likewise.
7781         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7782         entries in the dot_ops array are case insensitive, and use
7783         strncasecmp to compare strings.  Also some whitespace cleanup in
7784         this area.  Similar for the f77_keywords array, except entries in
7785         this list might be case sensitive.
7786
7787 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7788
7789         * f-exp.y (struct f77_boolean_val): Add comments.
7790         (boolean_values): Remove uppercase versions, and end marker.
7791         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7792         and use strncasecmp to achieve case insensitivity.  Additionally,
7793         perform whitespace cleanup around this code.
7794
7795 2019-03-06  Tom Tromey  <tromey@adacore.com>
7796
7797         * remote-sim.c (gdbsim_target_open): Use result of
7798         gdb_argv::release.
7799
7800 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7801         Dirk Schubert  <dirk.schubert@arm.com>
7802         Chris January  <chris.january@arm.com>
7803
7804         * eval.c (evaluate_subexp_standard): Call Fortran argument
7805         wrapping logic.
7806         * f-lang.c (struct value): A value which can be passed into a
7807         Fortran function call.
7808         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7809         where appropriate.
7810         (struct type): Value ready for a Fortran function call.
7811         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7812         is needed.
7813         * f-lang.h (fortran_argument_convert): Declaration.
7814         (fortran_preserve_arg_pointer): Declaration.
7815         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7816
7817 2019-03-05  Tom Tromey  <tromey@adacore.com>
7818
7819         * python/py-prettyprint.c (print_string_repr): Remove #if.
7820         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7821
7822 2019-03-05  Tom Tromey  <tromey@adacore.com>
7823
7824         * target.c (the_dummy_target): Move later.  Change type to
7825         "dummy_target".
7826         (initialize_targets): Don't initialize the_dummy_target.
7827
7828 2019-03-05  Tom Tromey  <tromey@adacore.com>
7829
7830         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7831         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7832
7833 2019-03-05  Tom Tromey  <tromey@adacore.com>
7834
7835         * windows-nat.c (windows_nat_target::attach)
7836         (windows_nat_target::detach): Don't call gdb_flush.
7837         * valprint.c (generic_val_print, val_print, val_print_string):
7838         Don't call gdb_flush.
7839         * utils.c (defaulted_query): Don't call gdb_flush.
7840         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7841         * target.c (target_announce_detach): Don't call gdb_flush.
7842         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7843         * remote.c (extended_remote_target::attach): Don't call
7844         gdb_flush.
7845         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7846         * printcmd.c (do_examine): Don't call gdb_flush.
7847         (info_display_command): Don't call gdb_flush.
7848         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7849         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7850         * memattr.c (info_mem_command): Don't call gdb_flush.
7851         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7852         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7853         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7854         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7855         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7856         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7857         (gnu_nat_target::detach): Don't call gdb_flush.
7858         * f-valprint.c (f_val_print): Don't call gdb_flush.
7859         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7860         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7861         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7862         gdb_flush.
7863         * c-valprint.c (c_val_print): Don't call gdb_flush.
7864         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7865
7866 2019-03-05  Tom Tromey  <tromey@adacore.com>
7867
7868         * varobj.c (update_dynamic_varobj_children): Update.
7869         (install_default_visualizer): Use reset, not release.
7870         * value.c (set_internalvar): Update.
7871         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7872         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7873         ATTRIBUTE_UNUSED_RESULT.
7874
7875 2019-03-05  Tom Tromey  <tromey@adacore.com>
7876
7877         * remote.c (class scoped_remote_fd) <release>: Add
7878         ATTRIBUTE_UNUSED_RESULT.
7879
7880 2019-03-05  Tom Tromey  <tromey@adacore.com>
7881
7882         * macroexp.c (struct macro_buffer) <release>: Add
7883         ATTRIBUTE_UNUSED_RESULT.
7884
7885 2019-03-05  Tom Tromey  <tromey@adacore.com>
7886
7887         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7888         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7889         ATTRIBUTE_UNUSED_RESULT.
7890
7891 2019-03-05  Tom Tromey  <tromey@adacore.com>
7892
7893         * common/scoped_fd.h (class scoped_fd) <release>: Add
7894         ATTRIBUTE_UNUSED_RESULT.
7895
7896 2019-03-05  Tom Tromey  <tromey@adacore.com>
7897
7898         * parser-defs.h (struct parser_state) <release>: Add
7899         ATTRIBUTE_UNUSED_RESULT.
7900
7901 2019-03-05  Tom Tromey  <tromey@adacore.com>
7902
7903         * utils.h (class gdb_argv) <release>: Add
7904         ATTRIBUTE_UNUSED_RESULT.
7905         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7906
7907 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7908
7909         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7910         for-loop range, to avoid compiler warnings.
7911
7912         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7913         avoid compiler warnings about unused variables.
7914
7915         * NEWS: Mention end of support for native debugging on MS-Windows
7916         before XP.
7917
7918         PR gdb/24292
7919         * common/netstuff.c:
7920         * gdbserver/gdbreplay.c
7921         * gdbserver/remote-utils.c:
7922         * ser-tcp.c:
7923         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7924         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7925         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7926         'getaddrinfo' and 'freeaddrinfo' were not available before
7927         Windows XP, and mingw.org's MinGW headers by default define
7928         _WIN32_WINNT to 0x500.
7929
7930 2019-03-01  Gary Benson <gbenson@redhat.com>
7931
7932         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7933
7934 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7935             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7936
7937         PR gdb/8527
7938         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7939         set_sigint_trap, clear_sigint_trap.
7940
7941 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7942
7943         * target.c (target_detach): Clear the regcache and the
7944         frame cache.
7945
7946 2019-02-27  Pedro Alves  <palves@redhat.com>
7947
7948         * utils.c (set_screen_size): When we cap the height/width sizes,
7949         tweak the corresponding command variable to show "unlimited":
7950
7951 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7952             Pedro Alves  <palves@redhat.com>
7953
7954         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7955         before calling rl_set_screen_size.
7956
7957 2019-02-27  Tom Tromey  <tromey@adacore.com>
7958
7959         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7960         define.
7961         * python/py-value.c: Remove Python 2.4 workaround.
7962         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7963         workaround.
7964         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7965         Python 2.4 workaround.
7966         * python/python-internal.h: Remove Python 2.4 comment.
7967         (Py_ssize_t): Don't define.
7968         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7969         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7970         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7971         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7972         * python/python.c (do_start_initialization): Remove Python 2.4
7973         workaround.
7974         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7975         (print_children): Remove Python 2.4 workaround.
7976         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7977         workaround.
7978         (CHARBUFFERPROC_NAME): Remove.
7979         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7980         Python 2.4 workaround.
7981
7982 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7983
7984         * NEWS: Note minimum Python version.
7985
7986 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7987
7988         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7989         code from these functions.  Remove corresponding ifdefs.  Use
7990         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7991         Remove gotos and target of gotos.
7992         (infpy_search_memory): Likewise.
7993
7994 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7995
7996         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7997         (hppa_gdbarch_init): Don't register deleted functions with
7998         gdbarch.
7999
8000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8001
8002         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8003         (h8300_unwind_sp): Delete.
8004         (h8300_dummy_id): Delete.
8005         (h8300_gdbarch_init): Don't register deleted functions with
8006         gdbarch.
8007
8008 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8009
8010         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8011         (ft32_unwind_pc): Delete.
8012         (ft32_unwind_sp): Delete.
8013         (ft32_gdbarch_init): Don't register deleted functions with
8014         gdbarch.
8015
8016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8017
8018         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8019         (frv_unwind_pc): Delete.
8020         (frv_unwind_sp): Delete.
8021         (frv_gdbarch_init): Don't register deleted functions with
8022         gdbarch.
8023
8024 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8025
8026         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8027         (riscv_unwind_pc): Delete.
8028         (riscv_unwind_sp): Delete.
8029         (riscv_gdbarch_init): Don't register deleted functions with
8030         gdbarch.
8031
8032 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8033
8034         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8035         (csky_unwind_pc): Delete.
8036         (csky_unwind_sp): Delete.
8037         (csky_gdbarch_init): Don't register deleted functions with
8038         gdbarch.
8039
8040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8043         (cris_unwind_pc): Delete.
8044         (cris_unwind_sp): Delete.
8045         (cris_gdbarch_init): Don't register deleted functions with
8046         gdbarch.
8047
8048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8049
8050         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8051         (bfin_unwind_pc): Delete.
8052         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8053
8054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8055
8056         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8057         (arm_unwind_pc): Delete.
8058         (arm_unwind_sp): Delete.
8059         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8060
8061 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8062
8063         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8064         (arc_unwind_pc): Delete.
8065         (arc_unwind_sp): Delete.
8066         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8067
8068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8069
8070         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8071         (alpha_unwind_pc): Delete.
8072         (alpha_gdbarch_init): Don't register deleted functions with
8073         gdbarch.
8074
8075 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8076
8077         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8078         (aarch64_unwind_pc): Delete.
8079         (aarch64_unwind_sp): Delete.
8080         (aarch64_gdbarch_init): Don't register deleted functions with
8081         gdbarch.
8082
8083 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8084
8085         * gdbtypes.c (type_align): Don't consider static members when
8086         computing structure alignment.
8087
8088 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8089
8090         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8091         return 0 for other types.
8092         * arch-utils.c (default_type_align): Always return 0.
8093         * gdbarch.h: Regenerate.
8094         * gdbarch.sh (type_align): Extend comment.
8095         * gdbtypes.c (type_align): Add additional comments, always call
8096         gdbarch_type_align before applying the default rules.
8097         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8098         generic code will then apply a suitable default.
8099         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8100         types, return 0 for other types.
8101
8102 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8103
8104         * NEWS: Create a new section for the next release branch.
8105         Rename the section of the current branch, now that it has
8106         been cut.
8107
8108 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8109
8110         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8111         * version.in: Bump version to 8.3.50.DATE-git.
8112
8113 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8114
8115         * aix-thread.c (ptid_cmp): Remove unused variable.
8116         (get_signaled_thread): Likewise.
8117         (store_regs_user_thread): Likewise.
8118         (store_regs_kernel_thread): Likewise.
8119         (fetch_regs_kernel_thread): Remove shadowed variable.
8120
8121 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8122
8123         * features/riscv/32bit-cpu.xml: Add register numbers.
8124         * features/riscv/32bit-fpu.c: Regenerate.
8125         * features/riscv/32bit-fpu.xml: Add register numbers.
8126         * features/riscv/64bit-cpu.xml: Add register numbers.
8127         * features/riscv/64bit-fpu.c: Regenerate.
8128         * features/riscv/64bit-fpu.xml: Add register numbers.
8129
8130 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8131
8132         * NEWS: Mention two argument form of gdb.Value constructor.
8133         * python/py-value.c (convert_buffer_and_type_to_value): New
8134         function.
8135         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8136         Add support for handling an optional second argument.  Call
8137         convert_buffer_and_type_to_value as appropriate.
8138         * python/python-internal.h (Py_buffer_deleter): New struct.
8139         (Py_buffer_up): New typedef.
8140
8141 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8142
8143         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8144         instead of releasing ownership.
8145
8146 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8147
8148         * dwarf2read.c (open_and_init_dwp_file): Call
8149         elf_numsections instead of bfd_count_sections to initialize
8150         dwp_file->num_sections.
8151
8152 2019-02-25  Tom Tromey  <tromey@adacore.com>
8153
8154         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8155
8156 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8157
8158         * gcore.in: Add '--readnever' option when invoking GDB.
8159
8160 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8161
8162         * MAINTAINERS: Update my email address.
8163
8164 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8165
8166         * build-id.c (build_id_to_debug_bfd_1): New function.
8167         (build_id_to_debug_bfd): Look for separate debug file in
8168         sysroot.
8169
8170 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8171
8172         * gdbarch.sh: Update the copyright year range that is placed into
8173         generated files.
8174
8175 2019-02-22  Keith Seitz  <keiths@redhat.com>
8176
8177         PR symtab/23853
8178         * linespec.c (create_sals_line_offset): Search for the default
8179         symtab's filename instead of its fullname.
8180
8181 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8182
8183         * NEWS: Update style defaults.
8184
8185 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8186
8187         * main.c (captured_main_1): Disable styling in batch mode.
8188
8189 2019-02-20  Tom Tromey  <tom@tromey.com>
8190
8191         * symtab.c (symtab_symbol_info): Fix typos.
8192
8193 2019-02-20  Tom Tromey  <tromey@adacore.com>
8194
8195         * findcmd.c (_initialize_mem_search): Use upper case for
8196         metasyntactic variables.
8197
8198 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8199
8200         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8201         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8202
8203 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8204
8205         * top.h (source_file_name): Change to std::string.
8206         * top.c (source_file_name): Likewise.
8207         (command_line_input): Adjust.
8208         * cli/cli-script.c (script_from_file): Adjust.
8209
8210 2019-02-19  Tom Tromey  <tromey@adacore.com>
8211
8212         * ravenscar-thread.c
8213         (ravenscar_thread_target::update_thread_list): Don't call
8214         ada_build_task_list.
8215         * ada-lang.h (ada_build_task_list): Don't declare.
8216         * ada-tasks.c (struct ada_tasks_inferior_data)
8217         <task_list_valid_p>: Now bool.
8218         (read_known_tasks, ada_task_list_changed)
8219         (ada_tasks_invalidate_inferior_data): Update.
8220         (read_known_tasks_array): Return bool.
8221         (read_known_tasks_list): Likewise.
8222         (read_known_tasks): Return void.
8223         (ada_build_task_list): Now static.
8224
8225 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8226
8227         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8228         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8229
8230 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8231
8232         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8233         variant for ada_tasks_pspace_data_handle and
8234         ada_tasks_inferior_data_handle.
8235         (ada_tasks_pspace_data_cleanup): New function.
8236         (ada_tasks_inferior_data_cleanup): New function.
8237
8238 2019-02-17  Tom Tromey  <tom@tromey.com>
8239
8240         * macrotab.h (macro_source_fullname): Return a std::string.
8241         * macrotab.c (macro_include, check_for_redefinition)
8242         (macro_undef, macro_lookup_definition, foreach_macro)
8243         (foreach_macro_in_scope): Update.
8244         (macro_source_fullname): Return a std::string.
8245         * macrocmd.c (show_pp_source_pos): Update.
8246
8247 2019-02-17  Tom Tromey  <tom@tromey.com>
8248
8249         * macrocmd.c (show_pp_source_pos): Style the file names.
8250
8251 2019-02-17  Tom Tromey  <tom@tromey.com>
8252
8253         PR tui/24197:
8254         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8255
8256 2019-02-17  Tom Tromey  <tom@tromey.com>
8257
8258         * ada-lang.c (user_select_syms): Use filtered printing.
8259         * utils.c (wrap_style): New global.
8260         (desired_style): Remove.
8261         (emit_style_escape): Add stream parameter.
8262         (set_output_style, reset_terminal_style, prompt_for_continue):
8263         Update.
8264         (flush_wrap_buffer): Only flush gdb_stdout.
8265         (wrap_here): Set wrap_style.
8266         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8267         treat escape sequences as a character.  Change when wrap buffer is
8268         flushed.
8269         (fputs_styled): Do not set the output style when the default is
8270         requested.
8271         * ui-style.h (struct ui_file_style) <is_default>: New method.
8272         * source.c (print_source_lines_base): Emit escape sequences in one
8273         piece.
8274
8275 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8276
8277         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8278         integers and enumeration types.
8279
8280 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8281
8282         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8283         instead of lookup_symbol_in_language
8284         (do_exact_match): New function.
8285         (ada_get_symbol_name_matcher): Return do_exact_match when
8286         doing a verbatim match.
8287
8288 2019-02-15  Tom Tromey  <tromey@adacore.com>
8289
8290         * ravenscar-thread.c (ravenscar_thread_target::resume)
8291         (ravenscar_thread_target::wait): Special case wildcard requests.
8292
8293 2019-02-15  Tom Tromey  <tromey@adacore.com>
8294
8295         * ravenscar-thread.c (base_ptid): Remove.
8296         (struct ravenscar_thread_target) <close>: New method.
8297         <m_base_ptid>: New member.
8298         <update_inferior_ptid, active_task, task_is_currently_active,
8299         runtime_initialized>: Declare methods.
8300         <ravenscar_thread_target>: Add constructor.
8301         (ravenscar_thread_target::task_is_currently_active)
8302         (ravenscar_thread_target::update_inferior_ptid)
8303         (ravenscar_runtime_initialized): Rename.  Now methods.
8304         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8305         (ravenscar_thread_target::update_thread_list): Update.
8306         (ravenscar_thread_target::active_task): Now method.
8307         (ravenscar_thread_target::store_registers)
8308         (ravenscar_thread_target::prepare_to_store)
8309         (ravenscar_thread_target::prepare_to_store)
8310         (ravenscar_thread_target::mourn_inferior): Update.
8311         (ravenscar_inferior_created): Use "new" to create target.
8312         (ravenscar_thread_target::get_ada_task_ptid): Update.
8313         (_initialize_ravenscar): Don't initialize base_ptid.
8314         (ravenscar_ops): Remove global.
8315
8316 2019-02-15  Tom Tromey  <tromey@adacore.com>
8317
8318         * target.h (push_target): Declare new overload.
8319         * target.c (push_target): New overload, taking an rvalue reference.
8320         * remote.c (remote_target::open_1): Use push_target overload.
8321         * corelow.c (core_target_open): Use push_target overload.
8322
8323 2019-02-15  Tom Tromey  <tromey@adacore.com>
8324
8325         * ravenscar-thread.c (is_ravenscar_task)
8326         (ravenscar_task_is_currently_active): Return bool.
8327         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8328         (_initialize_ravenscar): Remove "(void)".
8329         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8330         Return bool.
8331
8332 2019-02-15  Tom Tromey  <tromey@adacore.com>
8333
8334         * ravenscar-thread.c (ravenscar_runtime_initializer)
8335         (has_ravenscar_runtime, get_running_thread_id)
8336         (ravenscar_thread_target::resume): Fix indentation.
8337
8338 2019-02-15  Tom Tromey  <tromey@adacore.com>
8339
8340         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8341         from ravenscar_arch_ops.
8342         (sparc_ravenscar_ops::fetch_registers)
8343         (sparc_ravenscar_ops::store_registers): Now methods.
8344         (sparc_ravenscar_prepare_to_store): Remove.
8345         (sparc_ravenscar_ops): Redefine.
8346         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8347         methods and destructor.  Remove members.
8348         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8349         (ravenscar_thread_target::store_registers)
8350         (ravenscar_thread_target::prepare_to_store): Update.
8351         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8352         Remove.
8353         (struct ppc_ravenscar_powerpc_ops): Derive from
8354         ravenscar_arch_ops.
8355         (ppc_ravenscar_powerpc_ops::fetch_registers)
8356         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8357         (ppc_ravenscar_powerpc_ops): Redefine.
8358         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8359         (ppc_ravenscar_e500_ops::fetch_registers)
8360         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8361         (ppc_ravenscar_e500_ops): Redefine.
8362         * aarch64-ravenscar-thread.c
8363         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8364         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8365         (aarch64_ravenscar_fetch_registers)
8366         (aarch64_ravenscar_store_registers): Now methods.
8367         (aarch64_ravenscar_ops): Redefine.
8368
8369 2019-02-15  Tom Tromey  <tromey@adacore.com>
8370
8371         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8372         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8373         (ravenscar_thread_target::stopped_by_watchpoint)
8374         (ravenscar_thread_target::stopped_data_address)
8375         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8376
8377 2019-02-15  Tom Tromey  <tromey@adacore.com>
8378
8379         * ravenscar-thread.c: Fix some typos.
8380
8381 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8382             Tom Tromey  <tromey@adacore.com>
8383
8384         * ada-lang.c (ada_exception_sal): Change addr_string to a
8385         std::string.
8386         (create_ada_exception_catchpoint): Update.
8387
8388 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8389             Tom Tromey  <tromey@adacore.com>
8390
8391         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8392         (bp_location_ops): Remove.
8393         (base_breakpoint_allocate_location): Update.
8394         (free_bp_location): Update.
8395         * ada-lang.c (class ada_catchpoint_location)
8396         <ada_catchpoint_location>: Remove ops parameter.
8397         (ada_catchpoint_location_dtor): Remove.
8398         (ada_catchpoint_location_ops): Remove.
8399         (allocate_location_exception): Update.
8400         * breakpoint.h (struct bp_location_ops): Remove.
8401         (class bp_location) <bp_location>: Remove bp_location_ops
8402         parameter.
8403         <~bp_location>: Add destructor.
8404         <ops>: Remove.
8405
8406 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8407             Pedro Alves  <palves@redhat.com>
8408
8409         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8410         'PATH_MAX'.
8411
8412 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8413             Samuel Thibault  <samuel.thibault@gnu.org>
8414             Thomas Schwinge  <thomas@codesourcery.com>
8415
8416         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8417         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8418
8419 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8420
8421         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8422         (check_empty): Use "const char *".
8423
8424         * gnu-nat.c (gnu_nat_target::detach): Instead of
8425         'detach_inferior (pid)' call
8426         'detach_inferior (find_inferior_pid (pid))'.
8427
8428         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8429         'nat/fork-inferior.o'.
8430         * gnu-nat.c: #include "nat/fork-inferior.h".
8431
8432         * gnu-nat.c (gnu_nat_target::detach): Instead of
8433         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8434         * gnu-nat.h: #include "inf-child.h".
8435         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8436         'i386_gnu_nat_target::fetch_registers'.
8437         (gnu_store_registers): Rename/move to
8438         'i386_gnu_nat_target::store_registers'.
8439
8440         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8441         * gnu-nat.h (mach_thread_info): New function.
8442         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8443
8444         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8445
8446 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8447
8448         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8449
8450 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8451
8452         * windows-nat.c (windows_add_thread): Add new parameter
8453         "main_thread_p" with default value set to false.  Update
8454         function documentation as well as all callers.
8455         (windows_delete_thread): Likewise.
8456         (fake_create_process): Update call to windows_add_thread.
8457         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8458         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8459         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8460         call to windows_delete_thread.
8461
8462 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8463
8464         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8465
8466 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8467
8468         * symfile.c (find_separate_debug_file): Use canonical path of
8469         sysroot with child_path instead of gdb_sysroot if it is valid.
8470
8471 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8472
8473         * symfile.c (find_separate_debug_file): Use child_path to
8474         determine if an object file is under a sysroot.
8475
8476 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8477
8478         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8479         unittests/child-path-selftests.c.
8480         * common/pathstuff.c (child_path): New function.
8481         * common/pathstuff.h (child_path): New prototype.
8482         * unittests/child-path-selftests.c: New file.
8483
8484 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8485
8486         * symfile.c (find_separate_debug_file): Look for separate debug
8487         files in debug directories under the sysroot.
8488
8489 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8490
8491         * symtab.h (struct minimal_symbol data_p): New const method.
8492         (struct minimal_symbol text_p): Likewise.
8493         * symtab.c (output_source_filename): Use file name style
8494         to print file name.
8495         (print_symbol_info): Likewise.
8496         (print_msymbol_info): Use address style to print addresses.
8497         Use function name style to print executable text symbols.
8498         (expand_symtab_containing_pc): Use data_p.
8499         (find_pc_sect_compunit_symtab): Likewise.
8500
8501 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8502
8503         * breakpoint.c (describe_other_breakpoints): Use address style
8504         to print addresses.
8505         (say_where): Likewise.
8506
8507 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8508
8509         * ada-typeprint.c (print_func_type): Print function name
8510         style to print function name.
8511         * c-typeprint.c (c_print_type_1): Likewise.
8512
8513 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8514
8515         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8516         for execve.
8517
8518 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8519
8520         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8521         type_stack.
8522
8523 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8524
8525         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8526         TYPE_CODE_REF types.
8527
8528 2019-02-08  Jim Wilson  <jimw@sifive.com>
8529
8530         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8531         (riscv_linux_fregset): New.
8532         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8533
8534 2019-02-07  Tom Tromey  <tom@tromey.com>
8535
8536         * thread.c (thread_cancel_execution_command): Update.
8537         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8538         methods.
8539         (struct thread_fsm_ops): Remove.
8540         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8541         (thread_fsm_should_stop, thread_fsm_return_value)
8542         (thread_fsm_set_finished, thread_fsm_finished_p)
8543         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8544         Don't declare.
8545         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8546         * infrun.c (clear_proceed_status_thread)
8547         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8548         (print_stop_event): Update.
8549         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8550         Add constructor.
8551         (step_command_fsm_ops): Remove.
8552         (new_step_command_fsm): Remove.
8553         (step_1): Update.
8554         (step_command_fsm::should_stop): Rename from
8555         step_command_fsm_should_stop.
8556         (step_command_fsm::clean_up): Rename from
8557         step_command_fsm_clean_up.
8558         (step_command_fsm::do_async_reply_reason): Rename from
8559         step_command_fsm_async_reply_reason.
8560         (struct until_next_fsm): Inherit from thread_fsm.  Add
8561         constructor.
8562         (until_next_fsm_ops): Remove.
8563         (new_until_next_fsm): Remove.
8564         (until_next_fsm::should_stop): Rename from
8565         until_next_fsm_should_stop.
8566         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8567         (until_next_fsm::do_async_reply_reason): Rename from
8568         until_next_fsm_async_reply_reason.
8569         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8570         constructor.  Change type of breakpoint.
8571         (finish_command_fsm_ops): Remove.
8572         (new_finish_command_fsm): Remove.
8573         (finish_command_fsm::should_stop): Rename from
8574         finish_command_fsm_should_stop.
8575         (finish_command_fsm::clean_up): Rename from
8576         finish_command_fsm_clean_up.
8577         (finish_command_fsm::return_value): Rename from
8578         finish_command_fsm_return_value.
8579         (finish_command_fsm::do_async_reply_reason): Rename from
8580         finish_command_fsm_async_reply_reason.
8581         (finish_command): Update.
8582         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8583         Add constructor.
8584         (call_thread_fsm_ops): Remove.
8585         (call_thread_fsm::call_thread_fsm): Rename from
8586         new_call_thread_fsm.
8587         (call_thread_fsm::should_stop): Rename from
8588         call_thread_fsm_should_stop.
8589         (call_thread_fsm::should_notify_stop): Rename from
8590         call_thread_fsm_should_notify_stop.
8591         (run_inferior_call, call_function_by_hand_dummy): Update.
8592         * cli/cli-interp.c (should_print_stop_to_console): Update.
8593         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8594         Add constructor.  Change type of location_breakpoint,
8595         caller_breakpoint.
8596         (until_break_fsm_ops): Remove.
8597         (new_until_break_fsm): Remove.
8598         (until_break_fsm::should_stop): Rename from
8599         until_break_fsm_should_stop.
8600         (until_break_fsm::clean_up): Rename from
8601         until_break_fsm_clean_up.
8602         (until_break_fsm::do_async_reply_reason): Rename from
8603         until_break_fsm_async_reply_reason.
8604         (until_break_command): Update.
8605         * thread-fsm.c: Remove.
8606         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8607
8608 2019-02-07  Tom Tromey  <tom@tromey.com>
8609
8610         * yy-remap.h: Add include guard.
8611         * xtensa-tdep.h: Add include guard.
8612         * xcoffread.h: Rename include guard.
8613         * varobj-iter.h: Add include guard.
8614         * tui/tui.h: Rename include guard.
8615         * tui/tui-winsource.h: Rename include guard.
8616         * tui/tui-wingeneral.h: Rename include guard.
8617         * tui/tui-windata.h: Rename include guard.
8618         * tui/tui-win.h: Rename include guard.
8619         * tui/tui-stack.h: Rename include guard.
8620         * tui/tui-source.h: Rename include guard.
8621         * tui/tui-regs.h: Rename include guard.
8622         * tui/tui-out.h: Rename include guard.
8623         * tui/tui-layout.h: Rename include guard.
8624         * tui/tui-io.h: Rename include guard.
8625         * tui/tui-hooks.h: Rename include guard.
8626         * tui/tui-file.h: Rename include guard.
8627         * tui/tui-disasm.h: Rename include guard.
8628         * tui/tui-data.h: Rename include guard.
8629         * tui/tui-command.h: Rename include guard.
8630         * tic6x-tdep.h: Add include guard.
8631         * target/waitstatus.h: Rename include guard.
8632         * target/wait.h: Rename include guard.
8633         * target/target.h: Rename include guard.
8634         * target/resume.h: Rename include guard.
8635         * target-float.h: Rename include guard.
8636         * stabsread.h: Add include guard.
8637         * rs6000-tdep.h: Add include guard.
8638         * riscv-fbsd-tdep.h: Add include guard.
8639         * regformats/regdef.h: Rename include guard.
8640         * record.h: Rename include guard.
8641         * python/python.h: Rename include guard.
8642         * python/python-internal.h: Rename include guard.
8643         * python/py-stopevent.h: Rename include guard.
8644         * python/py-ref.h: Rename include guard.
8645         * python/py-record.h: Rename include guard.
8646         * python/py-record-full.h: Rename include guard.
8647         * python/py-record-btrace.h: Rename include guard.
8648         * python/py-instruction.h: Rename include guard.
8649         * python/py-events.h: Rename include guard.
8650         * python/py-event.h: Rename include guard.
8651         * procfs.h: Add include guard.
8652         * proc-utils.h: Add include guard.
8653         * p-lang.h: Add include guard.
8654         * or1k-tdep.h: Rename include guard.
8655         * observable.h: Rename include guard.
8656         * nto-tdep.h: Rename include guard.
8657         * nat/x86-linux.h: Rename include guard.
8658         * nat/x86-linux-dregs.h: Rename include guard.
8659         * nat/x86-gcc-cpuid.h: Add include guard.
8660         * nat/x86-dregs.h: Rename include guard.
8661         * nat/x86-cpuid.h: Rename include guard.
8662         * nat/ppc-linux.h: Rename include guard.
8663         * nat/mips-linux-watch.h: Rename include guard.
8664         * nat/linux-waitpid.h: Rename include guard.
8665         * nat/linux-ptrace.h: Rename include guard.
8666         * nat/linux-procfs.h: Rename include guard.
8667         * nat/linux-osdata.h: Rename include guard.
8668         * nat/linux-nat.h: Rename include guard.
8669         * nat/linux-namespaces.h: Rename include guard.
8670         * nat/linux-btrace.h: Rename include guard.
8671         * nat/glibc_thread_db.h: Rename include guard.
8672         * nat/gdb_thread_db.h: Rename include guard.
8673         * nat/gdb_ptrace.h: Rename include guard.
8674         * nat/fork-inferior.h: Rename include guard.
8675         * nat/amd64-linux-siginfo.h: Rename include guard.
8676         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8677         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8678         * nat/aarch64-linux.h: Rename include guard.
8679         * nat/aarch64-linux-hw-point.h: Rename include guard.
8680         * mn10300-tdep.h: Add include guard.
8681         * mips-linux-tdep.h: Add include guard.
8682         * mi/mi-parse.h: Rename include guard.
8683         * mi/mi-out.h: Rename include guard.
8684         * mi/mi-main.h: Rename include guard.
8685         * mi/mi-interp.h: Rename include guard.
8686         * mi/mi-getopt.h: Rename include guard.
8687         * mi/mi-console.h: Rename include guard.
8688         * mi/mi-common.h: Rename include guard.
8689         * mi/mi-cmds.h: Rename include guard.
8690         * mi/mi-cmd-break.h: Rename include guard.
8691         * m2-lang.h: Add include guard.
8692         * location.h: Rename include guard.
8693         * linux-record.h: Rename include guard.
8694         * linux-nat.h: Add include guard.
8695         * linux-fork.h: Add include guard.
8696         * i386-darwin-tdep.h: Rename include guard.
8697         * hppa-linux-offsets.h: Add include guard.
8698         * guile/guile.h: Rename include guard.
8699         * guile/guile-internal.h: Rename include guard.
8700         * gnu-nat.h: Rename include guard.
8701         * gdb-stabs.h: Rename include guard.
8702         * frv-tdep.h: Add include guard.
8703         * f-lang.h: Add include guard.
8704         * event-loop.h: Add include guard.
8705         * darwin-nat.h: Rename include guard.
8706         * cp-abi.h: Rename include guard.
8707         * config/sparc/nm-sol2.h: Rename include guard.
8708         * config/nm-nto.h: Rename include guard.
8709         * config/nm-linux.h: Add include guard.
8710         * config/i386/nm-i386gnu.h: Rename include guard.
8711         * config/djgpp/nl_types.h: Rename include guard.
8712         * config/djgpp/langinfo.h: Rename include guard.
8713         * compile/gcc-cp-plugin.h: Add include guard.
8714         * compile/gcc-c-plugin.h: Add include guard.
8715         * compile/compile.h: Rename include guard.
8716         * compile/compile-object-run.h: Rename include guard.
8717         * compile/compile-object-load.h: Rename include guard.
8718         * compile/compile-internal.h: Rename include guard.
8719         * compile/compile-cplus.h: Rename include guard.
8720         * compile/compile-c.h: Rename include guard.
8721         * common/xml-utils.h: Rename include guard.
8722         * common/x86-xstate.h: Rename include guard.
8723         * common/version.h: Rename include guard.
8724         * common/vec.h: Rename include guard.
8725         * common/tdesc.h: Rename include guard.
8726         * common/selftest.h: Rename include guard.
8727         * common/scoped_restore.h: Rename include guard.
8728         * common/scoped_mmap.h: Rename include guard.
8729         * common/scoped_fd.h: Rename include guard.
8730         * common/safe-iterator.h: Rename include guard.
8731         * common/run-time-clock.h: Rename include guard.
8732         * common/refcounted-object.h: Rename include guard.
8733         * common/queue.h: Rename include guard.
8734         * common/ptid.h: Rename include guard.
8735         * common/print-utils.h: Rename include guard.
8736         * common/preprocessor.h: Rename include guard.
8737         * common/pathstuff.h: Rename include guard.
8738         * common/observable.h: Rename include guard.
8739         * common/netstuff.h: Rename include guard.
8740         * common/job-control.h: Rename include guard.
8741         * common/host-defs.h: Rename include guard.
8742         * common/gdb_wait.h: Rename include guard.
8743         * common/gdb_vecs.h: Rename include guard.
8744         * common/gdb_unlinker.h: Rename include guard.
8745         * common/gdb_unique_ptr.h: Rename include guard.
8746         * common/gdb_tilde_expand.h: Rename include guard.
8747         * common/gdb_sys_time.h: Rename include guard.
8748         * common/gdb_string_view.h: Rename include guard.
8749         * common/gdb_splay_tree.h: Rename include guard.
8750         * common/gdb_setjmp.h: Rename include guard.
8751         * common/gdb_ref_ptr.h: Rename include guard.
8752         * common/gdb_optional.h: Rename include guard.
8753         * common/gdb_locale.h: Rename include guard.
8754         * common/gdb_assert.h: Rename include guard.
8755         * common/filtered-iterator.h: Rename include guard.
8756         * common/filestuff.h: Rename include guard.
8757         * common/fileio.h: Rename include guard.
8758         * common/environ.h: Rename include guard.
8759         * common/common-utils.h: Rename include guard.
8760         * common/common-types.h: Rename include guard.
8761         * common/common-regcache.h: Rename include guard.
8762         * common/common-inferior.h: Rename include guard.
8763         * common/common-gdbthread.h: Rename include guard.
8764         * common/common-exceptions.h: Rename include guard.
8765         * common/common-defs.h: Rename include guard.
8766         * common/common-debug.h: Rename include guard.
8767         * common/cleanups.h: Rename include guard.
8768         * common/buffer.h: Rename include guard.
8769         * common/btrace-common.h: Rename include guard.
8770         * common/break-common.h: Rename include guard.
8771         * cli/cli-utils.h: Rename include guard.
8772         * cli/cli-style.h: Rename include guard.
8773         * cli/cli-setshow.h: Rename include guard.
8774         * cli/cli-script.h: Rename include guard.
8775         * cli/cli-interp.h: Rename include guard.
8776         * cli/cli-decode.h: Rename include guard.
8777         * cli/cli-cmds.h: Rename include guard.
8778         * charset-list.h: Add include guard.
8779         * buildsym-legacy.h: Rename include guard.
8780         * bfin-tdep.h: Add include guard.
8781         * ax.h: Rename include guard.
8782         * arm-linux-tdep.h: Add include guard.
8783         * arm-fbsd-tdep.h: Add include guard.
8784         * arch/xtensa.h: Rename include guard.
8785         * arch/tic6x.h: Add include guard.
8786         * arch/i386.h: Add include guard.
8787         * arch/arm.h: Rename include guard.
8788         * arch/arm-linux.h: Rename include guard.
8789         * arch/arm-get-next-pcs.h: Rename include guard.
8790         * arch/amd64.h: Add include guard.
8791         * arch/aarch64-insn.h: Rename include guard.
8792         * arch-utils.h: Rename include guard.
8793         * annotate.h: Add include guard.
8794         * amd64-darwin-tdep.h: Rename include guard.
8795         * aarch64-linux-tdep.h: Add include guard.
8796         * aarch64-fbsd-tdep.h: Add include guard.
8797         * aarch32-linux-nat.h: Add include guard.
8798
8799 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8800
8801         * macrotab.c (macro_define_internal): New function that
8802         factorizes macro_define_object_internal and macro_define_function
8803         code.
8804         (macro_define_object_internal): Use macro_define_internal.
8805         (macro_define_function): Likewise.
8806
8807 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8808
8809         * macrocmd.c (extract_identifier): Return
8810         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8811         callers.
8812
8813 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8814
8815         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8816
8817 2019-02-05  Tom Tromey  <tom@tromey.com>
8818
8819         * target.c (target_stack::unpush): Move assertion earlier.
8820
8821 2019-01-30  Tom Tromey  <tom@tromey.com>
8822
8823         PR python/23615:
8824         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8825         (gdbpy_parse_and_eval): Likewise.
8826         * python/python-internal.h (gdbpy_allow_threads): New class.
8827
8828 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8829
8830         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8831         (aarch64_fbsd_fpregmap): Move earlier.
8832         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8833         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8834         instead of individual calls to trad_frame_set_reg_addr.
8835         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8836         earlier.
8837         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8838         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8839         instead of individual calls to trad_frame_set_reg_addr.
8840
8841 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8842
8843         * CONTRIBUTE: Replace contribution list with wiki link.
8844
8845 2019-01-25  Tom Tromey  <tom@tromey.com>
8846
8847         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8848
8849 2019-01-25  Tom Tromey  <tom@tromey.com>
8850
8851         * xtensa-linux-nat.c: Fix common/ includes.
8852         * xml-support.h: Fix common/ includes.
8853         * xml-support.c: Fix common/ includes.
8854         * x86-linux-nat.c: Fix common/ includes.
8855         * windows-nat.c: Fix common/ includes.
8856         * varobj.h: Fix common/ includes.
8857         * varobj.c: Fix common/ includes.
8858         * value.c: Fix common/ includes.
8859         * valops.c: Fix common/ includes.
8860         * utils.c: Fix common/ includes.
8861         * unittests/xml-utils-selftests.c: Fix common/ includes.
8862         * unittests/utils-selftests.c: Fix common/ includes.
8863         * unittests/unpack-selftests.c: Fix common/ includes.
8864         * unittests/tracepoint-selftests.c: Fix common/ includes.
8865         * unittests/style-selftests.c: Fix common/ includes.
8866         * unittests/string_view-selftests.c: Fix common/ includes.
8867         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8868         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8869         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8870         * unittests/rsp-low-selftests.c: Fix common/ includes.
8871         * unittests/parse-connection-spec-selftests.c: Fix common/
8872         includes.
8873         * unittests/optional-selftests.c: Fix common/ includes.
8874         * unittests/offset-type-selftests.c: Fix common/ includes.
8875         * unittests/observable-selftests.c: Fix common/ includes.
8876         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8877         * unittests/memrange-selftests.c: Fix common/ includes.
8878         * unittests/memory-map-selftests.c: Fix common/ includes.
8879         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8880         * unittests/function-view-selftests.c: Fix common/ includes.
8881         * unittests/environ-selftests.c: Fix common/ includes.
8882         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8883         * unittests/common-utils-selftests.c: Fix common/ includes.
8884         * unittests/cli-utils-selftests.c: Fix common/ includes.
8885         * unittests/array-view-selftests.c: Fix common/ includes.
8886         * ui-file.c: Fix common/ includes.
8887         * tui/tui-io.c: Fix common/ includes.
8888         * tracepoint.h: Fix common/ includes.
8889         * tracepoint.c: Fix common/ includes.
8890         * tracefile-tfile.c: Fix common/ includes.
8891         * top.h: Fix common/ includes.
8892         * top.c: Fix common/ includes.
8893         * thread.c: Fix common/ includes.
8894         * target/waitstatus.h: Fix common/ includes.
8895         * target/waitstatus.c: Fix common/ includes.
8896         * target.h: Fix common/ includes.
8897         * target.c: Fix common/ includes.
8898         * target-memory.c: Fix common/ includes.
8899         * target-descriptions.c: Fix common/ includes.
8900         * symtab.h: Fix common/ includes.
8901         * symfile.c: Fix common/ includes.
8902         * stap-probe.c: Fix common/ includes.
8903         * spu-linux-nat.c: Fix common/ includes.
8904         * sparc-nat.c: Fix common/ includes.
8905         * source.c: Fix common/ includes.
8906         * solib.c: Fix common/ includes.
8907         * solib-target.c: Fix common/ includes.
8908         * ser-unix.c: Fix common/ includes.
8909         * ser-tcp.c: Fix common/ includes.
8910         * ser-pipe.c: Fix common/ includes.
8911         * ser-base.c: Fix common/ includes.
8912         * selftest-arch.c: Fix common/ includes.
8913         * s12z-tdep.c: Fix common/ includes.
8914         * rust-exp.y: Fix common/ includes.
8915         * rs6000-aix-tdep.c: Fix common/ includes.
8916         * riscv-tdep.c: Fix common/ includes.
8917         * remote.c: Fix common/ includes.
8918         * remote-notif.h: Fix common/ includes.
8919         * remote-fileio.h: Fix common/ includes.
8920         * remote-fileio.c: Fix common/ includes.
8921         * regcache.h: Fix common/ includes.
8922         * regcache.c: Fix common/ includes.
8923         * record-btrace.c: Fix common/ includes.
8924         * python/python.c: Fix common/ includes.
8925         * python/py-type.c: Fix common/ includes.
8926         * python/py-inferior.c: Fix common/ includes.
8927         * progspace.h: Fix common/ includes.
8928         * producer.c: Fix common/ includes.
8929         * procfs.c: Fix common/ includes.
8930         * proc-api.c: Fix common/ includes.
8931         * printcmd.c: Fix common/ includes.
8932         * ppc-linux-nat.c: Fix common/ includes.
8933         * parser-defs.h: Fix common/ includes.
8934         * osdata.c: Fix common/ includes.
8935         * obsd-nat.c: Fix common/ includes.
8936         * nat/x86-linux.c: Fix common/ includes.
8937         * nat/x86-linux-dregs.c: Fix common/ includes.
8938         * nat/x86-dregs.h: Fix common/ includes.
8939         * nat/x86-dregs.c: Fix common/ includes.
8940         * nat/ppc-linux.c: Fix common/ includes.
8941         * nat/mips-linux-watch.h: Fix common/ includes.
8942         * nat/mips-linux-watch.c: Fix common/ includes.
8943         * nat/linux-waitpid.c: Fix common/ includes.
8944         * nat/linux-ptrace.h: Fix common/ includes.
8945         * nat/linux-ptrace.c: Fix common/ includes.
8946         * nat/linux-procfs.c: Fix common/ includes.
8947         * nat/linux-personality.c: Fix common/ includes.
8948         * nat/linux-osdata.c: Fix common/ includes.
8949         * nat/linux-namespaces.c: Fix common/ includes.
8950         * nat/linux-btrace.h: Fix common/ includes.
8951         * nat/linux-btrace.c: Fix common/ includes.
8952         * nat/fork-inferior.c: Fix common/ includes.
8953         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8954         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8955         * nat/aarch64-linux.c: Fix common/ includes.
8956         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8957         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8958         * namespace.h: Fix common/ includes.
8959         * mips-linux-tdep.c: Fix common/ includes.
8960         * minsyms.c: Fix common/ includes.
8961         * mi/mi-parse.h: Fix common/ includes.
8962         * mi/mi-main.c: Fix common/ includes.
8963         * mi/mi-cmd-env.c: Fix common/ includes.
8964         * memrange.h: Fix common/ includes.
8965         * memattr.c: Fix common/ includes.
8966         * maint.h: Fix common/ includes.
8967         * maint.c: Fix common/ includes.
8968         * main.c: Fix common/ includes.
8969         * machoread.c: Fix common/ includes.
8970         * location.c: Fix common/ includes.
8971         * linux-thread-db.c: Fix common/ includes.
8972         * linux-nat.c: Fix common/ includes.
8973         * linux-fork.c: Fix common/ includes.
8974         * inline-frame.c: Fix common/ includes.
8975         * infrun.c: Fix common/ includes.
8976         * inflow.c: Fix common/ includes.
8977         * inferior.h: Fix common/ includes.
8978         * inferior.c: Fix common/ includes.
8979         * infcmd.c: Fix common/ includes.
8980         * inf-ptrace.c: Fix common/ includes.
8981         * inf-child.c: Fix common/ includes.
8982         * ia64-linux-nat.c: Fix common/ includes.
8983         * i387-tdep.c: Fix common/ includes.
8984         * i386-tdep.c: Fix common/ includes.
8985         * i386-linux-tdep.c: Fix common/ includes.
8986         * i386-linux-nat.c: Fix common/ includes.
8987         * i386-go32-tdep.c: Fix common/ includes.
8988         * i386-fbsd-tdep.c: Fix common/ includes.
8989         * i386-fbsd-nat.c: Fix common/ includes.
8990         * guile/scm-type.c: Fix common/ includes.
8991         * guile/guile.c: Fix common/ includes.
8992         * go32-nat.c: Fix common/ includes.
8993         * gnu-nat.c: Fix common/ includes.
8994         * gdbthread.h: Fix common/ includes.
8995         * gdbarch-selftests.c: Fix common/ includes.
8996         * gdb_usleep.c: Fix common/ includes.
8997         * gdb_select.h: Fix common/ includes.
8998         * gdb_bfd.c: Fix common/ includes.
8999         * gcore.c: Fix common/ includes.
9000         * fork-child.c: Fix common/ includes.
9001         * findvar.c: Fix common/ includes.
9002         * fbsd-nat.c: Fix common/ includes.
9003         * event-top.c: Fix common/ includes.
9004         * event-loop.c: Fix common/ includes.
9005         * dwarf2read.c: Fix common/ includes.
9006         * dwarf2loc.c: Fix common/ includes.
9007         * dwarf2-frame.c: Fix common/ includes.
9008         * dwarf-index-cache.c: Fix common/ includes.
9009         * dtrace-probe.c: Fix common/ includes.
9010         * disasm-selftests.c: Fix common/ includes.
9011         * defs.h: Fix common/ includes.
9012         * csky-tdep.c: Fix common/ includes.
9013         * cp-valprint.c: Fix common/ includes.
9014         * cp-support.h: Fix common/ includes.
9015         * cp-support.c: Fix common/ includes.
9016         * corelow.c: Fix common/ includes.
9017         * completer.h: Fix common/ includes.
9018         * completer.c: Fix common/ includes.
9019         * compile/compile.c: Fix common/ includes.
9020         * compile/compile-loc2c.c: Fix common/ includes.
9021         * compile/compile-cplus-types.c: Fix common/ includes.
9022         * compile/compile-cplus-symbols.c: Fix common/ includes.
9023         * command.h: Fix common/ includes.
9024         * cli/cli-dump.c: Fix common/ includes.
9025         * cli/cli-cmds.c: Fix common/ includes.
9026         * charset.c: Fix common/ includes.
9027         * build-id.c: Fix common/ includes.
9028         * btrace.h: Fix common/ includes.
9029         * btrace.c: Fix common/ includes.
9030         * breakpoint.h: Fix common/ includes.
9031         * breakpoint.c: Fix common/ includes.
9032         * ax.h:
9033         (enum agent_op): Fix common/ includes.
9034         * ax-general.c (struct aop_map): Fix common/ includes.
9035         * ax-gdb.c: Fix common/ includes.
9036         * auxv.c: Fix common/ includes.
9037         * auto-load.c: Fix common/ includes.
9038         * arm-tdep.c: Fix common/ includes.
9039         * arch/riscv.c: Fix common/ includes.
9040         * arch/ppc-linux-common.c: Fix common/ includes.
9041         * arch/i386.c: Fix common/ includes.
9042         * arch/arm.c: Fix common/ includes.
9043         * arch/arm-linux.c: Fix common/ includes.
9044         * arch/arm-get-next-pcs.c: Fix common/ includes.
9045         * arch/amd64.c: Fix common/ includes.
9046         * arch/aarch64.c: Fix common/ includes.
9047         * arch/aarch64-insn.c: Fix common/ includes.
9048         * arch-utils.c: Fix common/ includes.
9049         * amd64-windows-tdep.c: Fix common/ includes.
9050         * amd64-tdep.c: Fix common/ includes.
9051         * amd64-sol2-tdep.c: Fix common/ includes.
9052         * amd64-obsd-tdep.c: Fix common/ includes.
9053         * amd64-nbsd-tdep.c: Fix common/ includes.
9054         * amd64-linux-tdep.c: Fix common/ includes.
9055         * amd64-linux-nat.c: Fix common/ includes.
9056         * amd64-fbsd-tdep.c: Fix common/ includes.
9057         * amd64-fbsd-nat.c: Fix common/ includes.
9058         * amd64-dicos-tdep.c: Fix common/ includes.
9059         * amd64-darwin-tdep.c: Fix common/ includes.
9060         * agent.c: Fix common/ includes.
9061         * ada-lang.h: Fix common/ includes.
9062         * ada-lang.c: Fix common/ includes.
9063         * aarch64-tdep.c: Fix common/ includes.
9064
9065 2019-01-25  Tom Tromey  <tom@tromey.com>
9066
9067         * common/create-version.sh: Use common/version.h.
9068
9069 2019-01-24  Pedro Alves  <palves@redhat.com>
9070
9071         * infrun.c (signal_stop, signal_print, signal_program)
9072         (signal_catch, signal_pass): Now arrays instead of pointers.
9073         (update_signals_program_target, do_target_resume)
9074         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9075         * linux-nat.c (linux_nat_target::pass_signals)
9076         (linux_nat_target::create_inferior, linux_nat_target::attach):
9077         Adjust.
9078         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9079         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9080         * procfs.c (procfs_target::pass_signals): Adjust.
9081         * record-full.c (record_full_target::resume): Adjust.
9082         * remote.c (remote_target::pass_signals)
9083         (remote_target::program_signals): Adjust.
9084         * target-debug.h (target_debug_print_signals): Now takes a
9085         gdb::array_view as parameter.  Adjust.
9086         * target.h (target_ops) <pass_signals, program_signals>: Replace
9087         pointer and length parameters with gdb::array_view.
9088         (target_pass_signals, target_program_signals): Likewise.
9089         * target-delegates.c: Regenerate.
9090
9091 2019-01-24  Pedro Alves  <palves@redhat.com>
9092
9093         * common/forward-scope-exit.h
9094         (forward_scope_exit::forward_scope_exit): Pass arguments to
9095         m_bind_function directly, instead of creating a std::bind and
9096         copying that.
9097
9098 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9099
9100         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9101         for static members.
9102         (pass_in_v_vfp_candidate): Likewise.
9103
9104 2019-01-23  Tom Tromey  <tom@tromey.com>
9105             Pedro Alves  <palves@redhat.com>
9106
9107         * regcache.c (class regcache_invalidator): Remove.
9108         (regcache::raw_write): Use make_scope_exit.
9109
9110 2019-01-23  Tom Tromey  <tom@tromey.com>
9111
9112         * ui-out.h (class ui_out_emit_type): Update comment.
9113
9114 2019-01-23  Tom Tromey  <tom@tromey.com>
9115
9116         * infrun.c (fetch_inferior_event): Update comment.
9117
9118 2019-01-23  Tom Tromey  <tom@tromey.com>
9119             Pedro Alves  <palves@redhat.com>
9120
9121         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9122         parameter.
9123         (fetch_inferior_event): Use SCOPE_EXIT.
9124
9125
9126 2019-01-23  Tom Tromey  <tom@tromey.com>
9127             Pedro Alves  <palves@redhat.com>
9128
9129         * infrun.c (disable_thread_events): Delete.
9130         (stop_all_threads): Use SCOPE_EXIT.
9131
9132 2019-01-23  Tom Tromey  <tom@tromey.com>
9133             Pedro Alves  <palves@redhat.com>
9134
9135         * symfile.c: Include forward-scope-exit.h.
9136         (clear_symtab_users_cleanup): Replace forward declaration with
9137         a FORWARD_SCOPE_EXIT.
9138         (syms_from_objfile_1): Use the forward_scope_exit and
9139         gdb::optional instead of cleanup_function.
9140         (reread_symbols): Use the forward_scope_exit instead of
9141         cleanup_function.
9142         (clear_symtab_users_cleanup): Remove function.
9143
9144 2019-01-23  Tom Tromey  <tom@tromey.com>
9145             Pedro Alves  <palves@redhat.com>
9146
9147         * linux-nat.c: Include scope-exit.h.
9148         (cleanup_target_stop): Remove.
9149         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9150         SCOPE_EXIT.
9151
9152 2019-01-23  Tom Tromey  <tom@tromey.com>
9153             Pedro Alves  <palves@redhat.com>
9154
9155         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9156         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9157
9158 2019-01-23  Tom Tromey  <tom@tromey.com>
9159             Andrew Burgess  <andrew.burgess@embecosm.com>
9160             Pedro Alves  <palves@redhat.com>
9161
9162         * infrun.c (fetch_inferior_event): Use scope_exit.
9163         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9164         * top.c (execute_command): Use scope_exit.
9165         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9166         * utils.c (do_bpstat_clear_actions_cleanup)
9167         (make_bpstat_clear_actions_cleanup): Remove.
9168
9169 2019-01-23  Tom Tromey  <tom@tromey.com>
9170             Pedro Alves  <palves@redhat.com>
9171
9172         * infrun.c: Include "common/scope-exit.h"
9173         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9174         (wait_for_inferior): Use SCOPE_EXIT.
9175         (fetch_inferior_event): Use scope_exit.
9176
9177 2019-01-23  Tom Tromey  <tom@tromey.com>
9178             Pedro Alves  <palves@redhat.com>
9179
9180         * breakpoint.c (create_breakpoint): Remove cleanup.
9181
9182 2019-01-23  Tom Tromey  <tom@tromey.com>
9183             Andrew Burgess  <andrew.burgess@embecosm.com>
9184             Pedro Alves  <palves@redhat.com>
9185
9186 2019-01-23  Pedro Alves  <palves@redhat.com>
9187
9188         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9189
9190 2019-01-23  Pedro Alves  <palves@redhat.com>
9191             Andrew Burgess  <andrew.burgess@embecosm.com>
9192
9193         * gdbthread.h: Include "common/forward-scope-exit.h".
9194         (scoped_finish_thread_state): Redefine custom class in terms of
9195         forward_scope_exit.
9196
9197 2019-01-23  Pedro Alves  <palves@redhat.com>
9198             Andrew Burgess  <andrew.burgess@embecosm.com>
9199
9200         * common/forward-scope-exit.h: New file.
9201
9202 2019-01-23  Pedro Alves  <palves@redhat.com>
9203             Andrew Burgess  <andrew.burgess@embecosm.com>
9204             Tom Tromey  <tom@tromey.com>
9205
9206         * common/scope-exit.h: New file.
9207
9208 2019-01-23  Pedro Alves  <palves@redhat.com>
9209
9210         * common/preprocessor.h (ESC): Rename to ...
9211         (ESC_PARENS): ... this.
9212         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9213         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9214
9215 2019-01-23  Tom Tromey  <tom@tromey.com>
9216
9217         * language.h (class scoped_switch_to_sym_language_if_auto):
9218         Initialize m_lang in both cases.
9219
9220 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9221
9222         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9223         with XCNEW.
9224
9225 2019-01-22  Tom Tromey  <tom@tromey.com>
9226
9227         * corelow.c: Do not include sys/file.h.
9228
9229 2019-01-22  Tom Tromey  <tom@tromey.com>
9230
9231         * tui/tui-wingeneral.h: Include gdb_curses.h.
9232
9233 2019-01-22  Tom Tromey  <tom@tromey.com>
9234
9235         * source-cache.h (class source_cache) <get_source_lines,
9236         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9237
9238 2019-01-22  Tom Tromey  <tom@tromey.com>
9239
9240         * remote-fileio.h (struct remote_target): Declare.
9241
9242 2019-01-22  Tom Tromey  <tom@tromey.com>
9243
9244         * python/py-arch.c: Do not include py-ref.h.
9245         * python/py-bpevent.c: Do not include py-ref.h.
9246         * python/py-cmd.c: Do not include py-ref.h.
9247         * python/py-continueevent.c: Do not include py-ref.h.
9248         * python/py-event.h: Do not include py-ref.h.
9249         * python/py-evtregistry.c: Do not include py-ref.h.
9250         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9251         * python/py-frame.c: Do not include py-ref.h.
9252         * python/py-framefilter.c: Do not include py-ref.h.
9253         * python/py-function.c: Do not include py-ref.h.
9254         * python/py-infevents.c: Do not include py-ref.h.
9255         * python/py-linetable.c: Do not include py-ref.h.
9256         * python/py-objfile.c: Do not include py-ref.h.
9257         * python/py-param.c: Do not include py-ref.h.
9258         * python/py-prettyprint.c: Do not include py-ref.h.
9259         * python/py-progspace.c: Do not include py-ref.h.
9260         * python/py-symbol.c: Do not include py-ref.h.
9261         * python/py-symtab.c: Do not include py-ref.h.
9262         * python/py-type.c: Do not include py-ref.h.
9263         * python/py-unwind.c: Do not include py-ref.h.
9264         * python/py-utils.c: Do not include py-ref.h.
9265         * python/py-value.c: Do not include py-ref.h.
9266         * python/py-varobj.c: Do not include py-ref.h.
9267         * python/py-xmethods.c: Do not include py-ref.h.
9268         * python/python.c: Do not include py-ref.h.
9269         * varobj.c: Do not include py-ref.h.
9270
9271 2019-01-22  Tom Tromey  <tom@tromey.com>
9272
9273         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9274         keyword for bcache.
9275
9276 2019-01-22  Tom Tromey  <tom@tromey.com>
9277
9278         * compile/compile-cplus-types.c: Remove a comment by #include.
9279
9280 2019-01-22  Tom Tromey  <tom@tromey.com>
9281
9282         * compile/gcc-c-plugin.h: Include compile-internal.h.
9283
9284 2019-01-22  Tom Tromey  <tom@tromey.com>
9285
9286         * stabsread.c (EXTERN): Do not define.
9287         (symnum, next_symbol_text_func, processing_gcc_compilation)
9288         (within_function, global_sym_chain, global_stabs)
9289         (previous_stab_code, this_object_header_files)
9290         (n_this_object_header_files)
9291         (n_allocated_this_object_header_files): Define.
9292         * stabsread.h (EXTERN): Never define.  Use "extern".
9293
9294 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9295
9296         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9297         history_value.
9298
9299 2019-01-21  Tom Tromey  <tom@tromey.com>
9300
9301         * ui-out.c: Fix includes.
9302         * tui/tui-source.c: Fix includes.
9303         * target.c: Fix includes.
9304         * remote.c: Fix includes.
9305         * regcache.c: Fix includes.
9306         * python/py-block.c: Fix includes.
9307         * printcmd.c: Fix includes.
9308         * or1k-tdep.c: Fix includes.
9309         * mi/mi-main.c: Fix includes.
9310         * m32r-tdep.c: Fix includes.
9311         * csky-tdep.c: Fix includes.
9312         * compile/compile-cplus-types.c: Fix includes.
9313         * cli/cli-interp.c: Fix includes.
9314
9315 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9316
9317         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9318         for padding.
9319
9320 2019-01-16  Tom Tromey  <tom@tromey.com>
9321
9322         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9323         earlier.
9324         (struct objfile) <msymbols_range>: Move from top level.
9325         <msymbols>: New method.
9326         (class objfile_msymbols): Remove.
9327         * symtab.c (default_collect_symbol_completion_matches_break_on):
9328         Update.
9329         * symmisc.c (dump_msymbols): Update.
9330         * stabsread.c (scan_file_globals): Update.
9331         * objc-lang.c (info_selectors_command, info_classes_command)
9332         (find_methods): Update.
9333         * minsyms.c (find_solib_trampoline_target): Update.
9334         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9335         * coffread.c (coff_symfile_read): Update.
9336         * ada-lang.c (ada_lookup_simple_minsym)
9337         (ada_collect_symbol_completion_matches): Update.
9338
9339 2019-01-16  Tom Tromey  <tom@tromey.com>
9340
9341         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9342         type.  Remove no-argument constructor.
9343         <iterator::operator++>: Simplify.
9344         <begin>: Update.
9345         <end>: Use minimal_symbol_count.
9346
9347 2019-01-16  Tom Tromey  <tom@tromey.com>
9348
9349         * objfiles.h (struct objfile) <psymtabs>: New method.
9350         (class objfile_psymtabs): Remove.
9351         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9352         typedef.
9353         <range>: New method.
9354         (require_partial_symbols): Change return type.
9355         * psymtab.c (require_partial_symbols)
9356         (psym_expand_symtabs_matching): Update.
9357         * mdebugread.c (parse_partial_symbols): Update.
9358         * dbxread.c (dbx_end_psymtab): Update.
9359
9360 2019-01-15  Tom Tromey  <tom@tromey.com>
9361
9362         * symtab.c (lookup_objfile_from_block)
9363         (lookup_symbol_in_objfile_symtabs)
9364         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9365         (find_line_symtab, info_sources_command)
9366         (default_collect_symbol_completion_matches_break_on)
9367         (make_source_files_completion_list): Update.
9368         * symmisc.c (print_objfile_statistics, dump_objfile)
9369         (maintenance_print_symbols, maintenance_info_symtabs)
9370         (maintenance_check_symtabs, maintenance_info_line_tables):
9371         Update.
9372         * source.c (select_source_symtab)
9373         (forget_cached_source_info_for_objfile): Update.
9374         * objfiles.h (class objfile_compunits): Remove.
9375         (struct objfile) <compunits_range>: New typedef.
9376         (compunits): New method.
9377         * objfiles.c (objfile_relocate1): Update.
9378         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9379         * maint.c (count_symtabs_and_blocks): Update.
9380         * linespec.c (iterate_over_all_matching_symtabs): Update.
9381         * cp-support.c (add_symbol_overload_list_qualified): Update.
9382         * coffread.c (coff_symtab_read): Update.
9383         * ada-lang.c (add_nonlocal_symbols)
9384         (ada_collect_symbol_completion_matches)
9385         (ada_add_global_exceptions): Update.
9386
9387 2019-01-15  Tom Tromey  <tom@tromey.com>
9388
9389         * progspace.h (program_space) <objfiles_safe_range>: New
9390         typedef.
9391         <objfiles_safe>: New method.
9392         * objfiles.h (class all_objfiles_safe): Remove.
9393         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9394         * jit.c (jit_inferior_exit_hook): Update.
9395
9396 2019-01-17  Tom Tromey  <tom@tromey.com>
9397
9398         * progspace.h (program_space) <objfiles_range>: New typedef.
9399         <objfiles>: New method.
9400         <objfiles_head>: Rename from objfiles.
9401         (object_files): Update.
9402         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9403         * guile/scm-pretty-print.c
9404         (ppscm_find_pretty_printer_from_objfiles): Update.
9405         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9406         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9407         Update.
9408         * python/py-progspace.c (pspy_get_objfiles): Update.
9409         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9410         Update.
9411         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9412         (objfpy_lookup_objfile_by_build_id): Update.
9413         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9414         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9415         Update.
9416         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9417         (expand_symtab_containing_pc, lookup_objfile_from_block)
9418         (lookup_static_symbol, basic_lookup_transparent_type)
9419         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9420         (find_line_symtab, info_sources_command)
9421         (default_collect_symbol_completion_matches_break_on)
9422         (make_source_files_completion_list, find_main_name): Update.
9423         * symmisc.c (print_symbol_bcache_statistics)
9424         (print_objfile_statistics, maintenance_print_symbols)
9425         (maintenance_print_msymbols, maintenance_print_objfiles)
9426         (maintenance_info_symtabs, maintenance_check_symtabs)
9427         (maintenance_expand_symtabs, maintenance_info_line_tables):
9428         Update.
9429         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9430         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9431         (map_overlay_command, unmap_overlay_command)
9432         (simple_overlay_update, expand_symtabs_matching)
9433         (map_symbol_filenames): Update.
9434         * symfile-debug.c (set_debug_symfile): Update.
9435         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9436         Update.
9437         * source.c (select_source_symtab, forget_cached_source_info):
9438         Update.
9439         * solib.c (solib_read_symbols): Update.
9440         * solib-spu.c (append_ocl_sos): Update.
9441         * psymtab.c (maintenance_print_psymbols)
9442         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9443         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9444         * printcmd.c (info_symbol_command): Update.
9445         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9446         Update.
9447         * objfiles.h (class all_objfiles): Remove.
9448         * objfiles.c (have_partial_symbols, have_full_symbols)
9449         (have_minimal_symbols, qsort_cmp, update_section_map)
9450         (shared_objfile_contains_address_p)
9451         (default_iterate_over_objfiles_in_search_order): Update.
9452         * objc-lang.c (info_selectors_command, info_classes_command)
9453         (find_methods): Update.
9454         * minsyms.c (find_solib_trampoline_target): Update.
9455         * maint.c (maintenance_info_sections)
9456         (maintenance_translate_address, count_symtabs_and_blocks):
9457         Update.
9458         * main.c (captured_main_1): Update.
9459         * linux-thread-db.c (try_thread_db_load_from_pdir)
9460         (has_libpthread): Update.
9461         * linespec.c (iterate_over_all_matching_symtabs)
9462         (search_minsyms_for_name): Update.
9463         * jit.c (jit_find_objf_with_entry_addr): Update.
9464         * hppa-tdep.c (find_unwind_entry)
9465         (hppa_lookup_stub_minimal_symbol): Update.
9466         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9467         Update.
9468         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9469         (elf_gnu_ifunc_resolve_by_got): Update.
9470         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9471         * dwarf-index-write.c (save_gdb_index_command): Update.
9472         * cp-support.c (add_symbol_overload_list_qualified): Update.
9473         * breakpoint.c (create_overlay_event_breakpoint)
9474         (create_longjmp_master_breakpoint)
9475         (create_std_terminate_master_breakpoint)
9476         (create_exception_master_breakpoint): Update.
9477         * blockframe.c (find_pc_partial_function): Update.
9478         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9479         (ada_collect_symbol_completion_matches)
9480         (ada_add_global_exceptions): Update.
9481
9482 2019-01-17  Tom Tromey  <tom@tromey.com>
9483
9484         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9485         declare VEC.
9486         (solib_target_parse_libraries): Change return type.
9487         (library_list_start_segment, library_list_start_section)
9488         (library_list_end_library, library_list_start_library); Update.
9489         (solib_target_free_library_list): Remove.
9490         (solib_target_parse_libraries): Remove cleanup.  Change return
9491         type.
9492         (solib_target_current_sos): Update.
9493
9494 2019-01-17  Tom Tromey  <tromey@bapiya>
9495
9496         * valprint.c: Replace "the the" with "the".
9497         * symtab.c: Replace "the the" with "the".
9498         * solib.c: Replace "the the" with "the".
9499         * solib-dsbt.c: Replace "the the" with "the".
9500         * linespec.c: Replace "the the" with "the".
9501         * dwarf2loc.h: Replace "the the" with "the".
9502         * amd64-windows-tdep.c: Replace "the the" with "the".
9503         * aarch64-tdep.c: Replace "the the" with "the".
9504
9505 2019-01-16  Keith Seitz  <keiths@redhat.com>
9506
9507         PR gdb/23773
9508         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9509         <builder>: Rename to ..
9510         <m_builder>: ... this and make private.
9511         (dwarf2_cu::get_builder): New method.  Change all users of
9512         `builder' to use this method.
9513         (dwarf2_start_symtab): Move to ...
9514         (dwarf2_cu::start_symtab): ... here.  Update all callers
9515         (setup_type_unit_groups): Move to ...
9516         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9517         callers.
9518         (dwarf2_cu::reset_builder): New method.
9519         (process_full_compunit, process_full_type_unit): Use
9520         dwarf2_cu::reset_builder.
9521         (follow_die_offset): Record the ancestor CU if it is different
9522         from the followed DIE's CU.
9523         (follow_die_sig_1): Likewise.
9524
9525 2019-01-15  Tom Tromey  <tom@tromey.com>
9526
9527         * remote.c (class remote_state) <buf>: Now a char_vector.
9528         <buf_size>: Remove.
9529         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9530         parameter.
9531         (remote_target::getpkt_or_notif_sane_1)
9532         (remote_target::getpkt_sane)
9533         (remote_target::getpkt_or_notif_sane): Likewise.
9534         (class remote_target) <putpkt>: New overload.
9535         (remote_target::read_frame): Change type of "buf_p".  Remove
9536         sizeof_p parameter.
9537         (packet_ok): New overload.
9538         (packet_check_result): New overload.
9539         Update all uses.
9540
9541 2019-01-14  Tom Tromey  <tom@tromey.com>
9542
9543         * remote-notif.c (handle_notification, remote_notif_ack)
9544         (remote_notif_parse): Make "buf" const.
9545         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9546         const.
9547         (remote_notif_parse, remote_notif_ack, handle_notification):
9548         Likewise.
9549         * remote.c (remote_notif_stop_parse): Make "buf" const.
9550         (remote_target::remote_parse_stop_reply): Make "buf" const.
9551         (remote_notif_stop_ack): Make "buf" const.
9552
9553 2019-01-14  Tom Tromey  <tom@tromey.com>
9554
9555         * remote.c (remote_console_output): Make parameter const.
9556
9557 2019-01-14  Tom Tromey  <tom@tromey.com>
9558
9559         * target-debug.h (target_debug_print_signals): Constify.
9560         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9561         * procfs.c (procfs_target::pass_signals): Update.
9562         * linux-nat.c (linux_nat_target::pass_signals): Update.
9563         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9564         * target-delegates.c: Rebuild.
9565         * remote.c (remote_target::program_signals): Update.
9566         (remote_target::pass_signals): Update.
9567         * target.c (target_pass_signals): Constify argument.
9568         (target_program_signals): Likewise.
9569         * target.h (struct target_ops) <pass_signals, program_signals>:
9570         Constify argument.
9571         (target_pass_signals, target_program_signals): Constify argument.
9572
9573 2019-01-14  Tom Tromey  <tom@tromey.com>
9574
9575         PR tui/28819:
9576         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9577
9578 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9579
9580         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9581         field.
9582         * rs6000-tdep.c: Include reggroups.h.
9583         (IS_V_ALIAS_PSEUDOREG): Define.
9584         (rs6000_register_name): Return names for the "vX" aliases.
9585         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9586         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9587         aliases.  Call default_register_reggroup_p for all other
9588         pseudo-registers.
9589         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9590         New functions.
9591         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9592         Handle "vX" aliases.
9593         (v_alias_pseudo_register_collect): New function.
9594         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9595         (rs6000_gdbarch_init): Initialize "vX" aliases as
9596         pseudo-registers.  Restore registration of
9597         rs6000_pseudo_register_reggroup_p with
9598         set_tdesc_pseudo_register_reggroup_p.
9599
9600 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9601
9602         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9603         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9604         set_gdbarch_num_pseudo_regs.
9605
9606 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9607
9608         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9609         Remove arg prefixname, add do_set and do_show.
9610         Add member functions set_list and show_list.
9611         * cli/cli-style.c (class cli_style_option): Update accordingly.
9612         (style_set_list): Move to file scope.
9613         (style_show_list): Likewise.
9614         (set_style): Call help_list.
9615         (show_style): Call cmd_show_list.
9616         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9617         Update to use the new macro.
9618
9619 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9620
9621         * ada-lang.c (_initialize_ada_language): Expand the help text
9622         for the "catch exception" command.
9623
9624 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9625
9626         * symtab.c (matching_obj_sections): Initialize obj,
9627         declare it closer to its usage.
9628
9629 2019-01-10  Tom Tromey  <tom@tromey.com>
9630
9631         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9632         (basic_inf_threads_range): Remove.
9633         (inf_threads_range, inf_non_exited_threads_range)
9634         (safe_inf_threads_range): Use next_adapter.
9635
9636 2019-01-10  Keith Seitz  <keiths@redhat.com>
9637
9638         PR gdb/23712
9639         PR symtab/23010
9640         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9641         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9642
9643 2019-01-10  Keith Seitz  <keiths@redhat.com>
9644
9645         PR gdb/23712
9646         PR symtab/23010
9647         * dictionary.c (pending_to_vector): Remove.
9648         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9649         Remove _1 suffix, replacing functions of the same name.  Update
9650         all callers.
9651         (dict_create_hashed, dict_create_hashed_expandable)
9652         (dict_create_linear, dict_create_linear_expandable, dict_free)
9653         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9654         Make functions static.
9655
9656 2019-01-10  Keith Seitz  <keiths@redhat.com>
9657
9658         PR gdb/23712
9659         PR symtab/23010
9660         * dictionary.h (struct dictionary): Replace declaration with
9661         multidictionary.
9662         (dict_create_hashed, dict_create_hashed_expandable)
9663         (dict_create_linear, dict_create_linear_expandable)
9664         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9665         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9666         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9667         taking multidictionary argument.
9668         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9669         * block.h (struct block) <dict>: Change to multidictionary
9670         and rename `multidict'.
9671         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9672         symmisc.c: Update all dictionary references to multidictionary.
9673
9674 2019-01-10  Keith Seitz  <keiths@redhat.com>
9675
9676         PR gdb/23712
9677         PR symtab/23010
9678         * dictionary.c: Include unordered_map.
9679         (pending_to_vector): New function.
9680         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9681         Rewrite the non-"_1" functions to take vector instead
9682         of linked list.
9683         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9684         "new" _1 versions of the same name.
9685         (multidictionary): Define.
9686         (std::hash<enum language): New definition.
9687         (collate_pending_symbols_by_language, mdict_create_hashed)
9688         (mdict_create_hashed_expandable, mdict_create_linear)
9689         (mdict_create_linear_expandable, mdict_free)
9690         (find_language_dictionary, create_new_language_dictionary)
9691         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9692         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9693         (mdict_size, mdict_empty): New functions.
9694         * dictionary.h (mdict_iterator): Define.
9695
9696 2019-01-10  Pedro Alves  <palves@redhat.com>
9697
9698         * breakpoint.c (read_uploaded_action)
9699         (create_tracepoint_from_upload): Adjust to use
9700         gdb::unique_xmalloc_ptr.
9701         * ctf.c (ctf_write_uploaded_tp):
9702         (SET_ARRAY_FIELD): Use emplace_back.
9703         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9704         * tracefile-tfile.c (tfile_write_uploaded_tp):
9705         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9706         gdb::unique_xmalloc_ptr.
9707         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9708         at_string, cond_string, cmd_strings>: Replace char pointers
9709         with gdb::unique_xmalloc_ptr.
9710
9711 2019-01-10  Pedro Alves  <palves@redhat.com>
9712
9713         * solib-target.c (library_list_start_library): Don't xstrdup name.
9714
9715 2019-01-10  Pedro Alves  <palves@redhat.com>
9716
9717         * mdebugread.c (parse_partial_symbols): Use
9718         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9719
9720 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9721
9722         * linux-fork.c (scoped_switch_fork_info)
9723         <~scoped_switch_fork_info>: Fix incorrect variable name.
9724
9725 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9726
9727         * linux-fork.c (scoped_switch_fork_info)
9728         <scoped_switch_fork_info>: Make explicit.
9729         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9730
9731 2019-01-10  Tom Tromey  <tom@tromey.com>
9732
9733         * objfiles.h (objfile::reset_psymtabs): Update.
9734         * objfiles.c (objfile::objfile): Update.
9735         * psymtab.h (psymtab_storage::obstack): Update.
9736         (psymtab_storage::m_obstack): Use gdb::optional.
9737         (class psymtab_storage): Update comment.  Remove objfile
9738         parameter.
9739         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9740
9741 2019-01-10  Tom Tromey  <tom@tromey.com>
9742
9743         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9744         <free_psymtabs>: Now private.
9745         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9746         (allocate_psymtab): Use new method.
9747
9748 2019-01-10  Tom Tromey  <tom@tromey.com>
9749
9750         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9751         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9752         * mdebugread.c (parse_partial_symbols): Use
9753         allocate_dependencies.
9754         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9755         allocate_dependencies.
9756         (process_psymtab_comp_unit_reader)
9757         (build_type_psymtab_dependencies): Likewise.
9758         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9759
9760 2019-01-10  Tom Tromey  <tom@tromey.com>
9761
9762         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9763         PSYMBOL_SET_LANGUAGE.
9764         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9765
9766 2019-01-10  Tom Tromey  <tom@tromey.com>
9767
9768         * psymtab.h (psymtab_storage::obstack): New method.
9769         <m_obstack>: Rename from obstack; now private.
9770         * psymtab.c (psymtab_storage): Update.
9771         * dwarf2read.c (create_addrmap_from_index)
9772         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9773         Update.
9774
9775 2019-01-10  Tom Tromey  <tom@tromey.com>
9776
9777         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9778         * objfiles.h (objfile::reset_psymtabs): New method.
9779
9780 2019-01-10  Tom Tromey  <tom@tromey.com>
9781
9782         * symmisc.c (print_symbol_bcache_statistics): Update.
9783         (print_objfile_statistics): Update.
9784         * symfile.c (reread_symbols): Update.
9785         * psymtab.h (class psymtab_storage): New.
9786         * psymtab.c (psymtab_storage): New constructor.
9787         (~psymtab_storage): New destructor.
9788         (require_partial_symbols): Update.
9789         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9790         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9791         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9792         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9793         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9794         (start_psymtab_common, end_psymtab_common)
9795         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9796         (allocate_psymtab): Update.
9797         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9798         Update.
9799         (dump_psymtab_addrmap, maintenance_print_psymbols)
9800         (maintenance_check_psymtabs): Update.
9801         (class objfile_psymtabs): Move to objfiles.h.
9802         * psympriv.h (discard_psymtab): Now inline.
9803         (psymtab_discarder::psymtab_discarder): Update.
9804         (psymtab_discarder::~psymtab_discarder): Update.
9805         (ALL_OBJFILE_PSYMTABS): Rewrite.
9806         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9807         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9808         Remove fields.
9809         <partial_symtabs>: New field.
9810         (class objfile_psymtabs): Move from psymtab.h.  Update.
9811         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9812         psymbol_cache.
9813         (objfile::~objfile): Don't destroy psymbol_cache.
9814         * mdebugread.c (parse_partial_symbols): Update.
9815         * dwarf2read.c (create_addrmap_from_index)
9816         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9817         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9818         (add_partial_subprogram, dwarf2_ranges_read): Update.
9819         * dwarf-index-write.c (write_address_map)
9820         (write_one_signatured_type, recursively_write_psymbols)
9821         (class debug_names, class debug_names, write_psymtabs_to_index):
9822         Update.
9823
9824 2019-01-10  Tom Tromey  <tom@tromey.com>
9825
9826         * symtab.h (SYMBOL_SET_NAMES): Update.
9827         (symbol_set_names): Update.
9828         (MSYMBOL_SET_NAMES): Update.
9829         * symtab.c (symbol_set_names): Change argument to be an
9830         objfile_per_bfd_storage.
9831         * psymtab.c (add_psymbol_to_bcache): Update.
9832         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9833
9834 2019-01-10  Tom Tromey  <tom@tromey.com>
9835
9836         * symtab.c (create_demangled_names_hash): Change argument to be an
9837         objfile_per_bfd_storage.
9838         (symbol_set_names): Update.
9839
9840 2019-01-10  Tom Tromey  <tom@tromey.com>
9841
9842         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9843         init_psymbol_list.
9844         * psymtab.c (init_psymbol_list): Do nothing if already called.
9845         * psympriv.h (init_psymbol_list): Add comment.
9846         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9847         init_psymbol_list.
9848         * dbxread.c (dbx_symfile_read): Unconditionally call
9849         init_psymbol_list.
9850
9851 2019-01-10  Tom Tromey  <tom@tromey.com>
9852
9853         * xcoffread.c (scan_xcoff_symtab): Update.
9854         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9855         "where".
9856         * mdebugread.c (parse_partial_symbols)
9857         (handle_psymbol_enumerators): Update.
9858         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9859         * dbxread.c (read_dbx_symtab): Update.
9860         * psympriv.h (psymbol_placement): New enum.
9861         (add_psymbol_to_list): Update.
9862
9863 2019-01-10  Tom Tromey  <tom@tromey.com>
9864
9865         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9866         static_psymbols parameters.
9867         (scan_xcoff_symtab): Update.
9868         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9869         static_psymbols parameters.
9870         * psympriv.h (start_psymtab_common): Update.
9871         * mdebugread.c (parse_partial_symbols): Update.
9872         * dwarf2read.c (create_partial_symtab): Update.
9873         * dbxread.c (read_dbx_symtab): Update.
9874         (start_psymtab): Remove global_psymbols and static_psymbols
9875         parameters.
9876
9877 2019-01-10  Tom Tromey  <tom@tromey.com>
9878
9879         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9880         * psymtab.c (allocate_psymtab): Add comment.
9881         * psympriv.h (allocate_psymtab): Add comment.
9882         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9883         initializations.
9884         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9885
9886 2019-01-10  Tom Tromey  <tom@tromey.com>
9887
9888         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9889         Don't declare.
9890         * mipsread.c: Include mdebugread.h.
9891         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9892         Declare.
9893         * elfread.c: Include mdebugread.h.
9894
9895 2019-01-09  Tom Tromey  <tom@tromey.com>
9896
9897         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9898         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9899         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9900         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9901         (psym_lookup_symbol, psym_find_last_source_symtab)
9902         (psym_forget_cached_source_info, psym_print_stats)
9903         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9904         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9905         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9906         (psym_find_compunit_symtab_by_address)
9907         (maintenance_print_psymbols, maintenance_info_psymtabs)
9908         (maintenance_check_psymtabs): Use ranged for.
9909         * psymtab.h (class objfile_psymtabs): New.
9910         (require_partial_symbols): Return objfile_psymtabs.
9911         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9912
9913 2019-01-09  Tom Tromey  <tom@tromey.com>
9914
9915         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9916         (find_pc_mapped_section, list_overlays_command)
9917         (map_overlay_command, unmap_overlay_command)
9918         (simple_overlay_update): Use all_objfiles.
9919         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9920         * printcmd.c (info_symbol_command): Use all_objfiles.
9921         * objfiles.h (ALL_OBJSECTIONS): Remove.
9922         * maint.c (maintenance_translate_address): Use all_objfiles.
9923         * gcore.c (gcore_create_callback): Use all_objfiles.
9924         (objfile_find_memory_regions): Likewise.
9925
9926 2019-01-09  Tom Tromey  <tom@tromey.com>
9927
9928         * symtab.c (find_line_symtab, info_sources_command)
9929         (make_source_files_completion_list): Use objfile_compunits.
9930         * source.c (select_source_symtab): Use objfile_compunits.
9931         * objfiles.h (struct objfile): Update comment.
9932         (ALL_OBJFILES): Remove.
9933         (ALL_FILETABS): Remove.
9934         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9935         objfile_compunits.
9936
9937 2019-01-09  Tom Tromey  <tom@tromey.com>
9938
9939         * symmisc.c (print_objfile_statistics, dump_objfile)
9940         (maintenance_print_symbols): Use compunit_filetabs.
9941         * source.c (forget_cached_source_info_for_objfile): Use
9942         compunit_filetabs.
9943         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9944         (ALL_FILETABS): Use compunit_filetabs.
9945         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9946         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9947
9948 2019-01-09  Tom Tromey  <tom@tromey.com>
9949
9950         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9951         (compunit_filetabs): New.
9952         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9953         compunit_filetabs.
9954         (info_sources_command, make_source_files_completion_list): Remove
9955         declaration.
9956         * symmisc.c (print_objfile_statistics, dump_objfile)
9957         (maintenance_print_symbols): Remove declaration.
9958         (maintenance_info_symtabs): Use compunit_filetabs.
9959         (maintenance_info_line_tables): Likewise.
9960         * source.c (select_source_symtab): Change local variable name.
9961         (forget_cached_source_info_for_objfile): Remove declaration.
9962         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9963         * objfiles.c (objfile_relocate1): Remove declaration.
9964         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9965         declaration.
9966         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9967         * coffread.c (coff_symtab_read): Remove declaration.
9968         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9969         compunit_filetabs.
9970
9971 2019-01-09  Tom Tromey  <tom@tromey.com>
9972
9973         * symtab.c (lookup_objfile_from_block)
9974         (find_pc_sect_compunit_symtab, search_symbols)
9975         (default_collect_symbol_completion_matches_break_on): Use
9976         objfile_compunits.
9977         * objfiles.h (ALL_COMPUNITS): Remove.
9978         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9979         * cp-support.c (add_symbol_overload_list_qualified): Use
9980         objfile_compunits.
9981         * ada-lang.c (ada_collect_symbol_completion_matches)
9982         (ada_add_global_exceptions): Use objfile_compunits.
9983
9984 2019-01-09  Tom Tromey  <tom@tromey.com>
9985
9986         * source.c (select_source_symtab)
9987         (forget_cached_source_info_for_objfile): Remove declaration.
9988         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9989         declaration.
9990         * maint.c (count_symtabs_and_blocks): Remove declaration.
9991         * cp-support.c (add_symbol_overload_list_qualified): Remove
9992         declaration.
9993         * coffread.c (coff_symtab_read): Remove declaration.
9994         * symtab.c (lookup_symbol_in_objfile_symtabs)
9995         (basic_lookup_transparent_type_1): Use objfile_compunits.
9996         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9997         (info_sources_command, search_symbols)
9998         (default_collect_symbol_completion_matches_break_on)
9999         (make_source_files_completion_list): Remove declaration.
10000         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10001         (ada_collect_symbol_completion_matches)
10002         (ada_add_global_exceptions): Remove declaration.
10003         * linespec.c (iterate_over_all_matching_symtabs): Use
10004         objfile_compunits.
10005         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10006         (class objfile_compunits): New.
10007         (ALL_COMPUNITS): Use objfile_compunits.
10008         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10009         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10010         objfile_compunits.
10011         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10012
10013 2019-01-09  Tom Tromey  <tom@tromey.com>
10014
10015         * symtab.c (search_symbols)
10016         (default_collect_symbol_completion_matches_break_on): Use
10017         objfile_msymbols.
10018         * ada-lang.c (ada_lookup_simple_minsym)
10019         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10020         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10021         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10022         objfile_msymbols.
10023         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10024         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10025         * objc-lang.c (find_methods): Use objfile_msymbols.
10026         (info_selectors_command, info_classes_command): Likewise.
10027         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10028         * objfiles.h (class objfile_msymbols): New.
10029         (ALL_OBJFILE_MSYMBOLS): Remove.
10030         (ALL_MSYMBOLS): Remove.
10031
10032 2019-01-09  Tom Tromey  <tom@tromey.com>
10033
10034         * common/next-iterator.h (next_adapter): Add Iterator template
10035         parameter.
10036         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10037         (class all_objfiles_safe): New.
10038         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10039         * objfiles.c (put_objfile_before): Update comment.
10040         (add_separate_debug_objfile): Likewise.
10041         (free_all_objfiles): Use all_objfiles_safe.
10042         (objfile_purge_solibs): Likewise.
10043
10044 2019-01-09  Tom Tromey  <tom@tromey.com>
10045
10046         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10047         (expand_symtab_containing_pc, lookup_static_symbol)
10048         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10049         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10050         all_objfiles.
10051         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10052         * breakpoint.c (create_overlay_event_breakpoint)
10053         (create_longjmp_master_breakpoint)
10054         (create_std_terminate_master_breakpoint)
10055         (create_exception_master_breakpoint): Use all_objfiles.
10056         * linux-thread-db.c (try_thread_db_load_from_pdir)
10057         (has_libpthread): Use all_objfiles.
10058         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10059         * linespec.c (iterate_over_all_matching_symtabs)
10060         (search_minsyms_for_name): Use all_objfiles.
10061         * maint.c (maintenance_info_sections): Use all_objfiles.
10062         * main.c (captured_main_1): Use all_objfiles.
10063         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10064         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10065         * guile/scm-pretty-print.c
10066         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10067         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10068         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10069         (maintenance_print_msymbols): Use all_objfiles.
10070         * source.c (select_source_symtab): Use all_objfiles.
10071         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10072         * symfile.c (remove_symbol_file_command)
10073         (expand_symtabs_matching, map_symbol_filenames): Use
10074         all_objfiles.
10075         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10076         all_objfiles.
10077         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10078         * objc-lang.c (find_methods): Use all_objfiles.
10079         * objfiles.c (have_partial_symbols, have_full_symbols)
10080         (have_minimal_symbols, qsort_cmp)
10081         (default_iterate_over_objfiles_in_search_order): Use
10082         all_objfiles.
10083         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10084         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10085         (maintenance_check_psymtabs): Use all_objfiles.
10086         (ALL_PSYMTABS): Remove.
10087         * compile/compile-object-run.c (do_module_cleanup): Use
10088         all_objfiles.
10089         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10090         * cp-support.c (add_symbol_overload_list_qualified): Use
10091         all_objfiles.
10092         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10093         Use all_objfiles.
10094         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10095         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10096         all_objfiles.
10097         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10098         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10099         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10100         Uses all_objfiles.
10101         * solib.c (solib_read_symbols): Use all_objfiles
10102
10103 2019-01-09  Tom Tromey  <tom@tromey.com>
10104
10105         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10106         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10107         all_objfiles.
10108         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10109         * symmisc.c (print_symbol_bcache_statistics)
10110         (print_objfile_statistics, maintenance_print_objfiles)
10111         (maintenance_info_symtabs, maintenance_check_symtabs)
10112         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10113         all_objfiles.
10114         * source.c (forget_cached_source_info): Use all_objfiles.
10115         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10116         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10117         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10118         * objfiles.c (update_section_map): Use all_objfiles.
10119         (shared_objfile_contains_address_p): Likewise.
10120         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10121         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10122
10123 2019-01-09  Tom Tromey  <tom@tromey.com>
10124
10125         * common/next-iterator.h: New file.
10126         * objfiles.h (class all_objfiles): New.
10127         (struct objfile_iterator): New.
10128
10129 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10130
10131         * NEWS: Move the description of the changed "frame", "select-frame",
10132          and "info frame" commands to the Changed commands section.
10133
10134 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10135
10136         * gdbtypes.c (check_stub_method_group): Remove handling of old
10137         mangling schemes.
10138         * linespec.c (find_methods): Likewise.
10139         * stabsread.c (read_member_functions): Likewise.
10140         * valops.c (search_struct_method): Likewise.
10141         (value_struct_elt_for_reference): Likewise.
10142         * NEWS: Mention this change.
10143
10144 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10145
10146         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10147         print_source_lines.
10148         * source.c (print_source_lines_base): Update line number check.
10149         (print_source_lines): New function.
10150         (source_lines_range::source_lines_range): New function.
10151         * source.h (class source_lines_range): New class.
10152         (print_source_lines): New declaration.
10153
10154 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10155
10156         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10157
10158 2019-01-08  Tom Tromey  <tom@tromey.com>
10159             Simon Marchi  <simon.marchi@ericsson.com>
10160
10161         PR gdb/24060
10162         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10163         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10164         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10165         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10166         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10167         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10168
10169 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10170
10171         * source.c (select_source_symtab): Move header comment to
10172         declaration in source.h.
10173         (forget_cached_source_info_for_objfile): Likewise.
10174         (forget_cached_source_info): Likewise.
10175         (identify_source_line): Likewise.
10176         * source.h (identify_source_line): Move declaration from symtab.h
10177         and add comment from source.c
10178         (print_source_lines): Likewise.
10179         (forget_cached_source_info_for_objfile): Likewise.
10180         (forget_cached_source_info): Likewise.
10181         (select_source_symtab): Likewise.
10182         (enum print_source_lines_flag): Move definition from symtab.h.
10183         * symtab.h (identify_source_line): Move declaration to source.h.
10184         (print_source_lines): Likewise.
10185         (forget_cached_source_info_for_objfile): Likewise.
10186         (forget_cached_source_info): Likewise.
10187         (select_source_symtab): Likewise.
10188         (enum print_source_lines_flag): Move definition to source.h.
10189         * tui/tui-hooks.c: Add 'source.h' include.
10190
10191 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10192
10193         * source.c (print_source_lines_base): Handle requests to print
10194         reverse line number sequences, and guard against empty lines
10195         string.
10196
10197 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10198
10199         * source.c (print_source_lines_base): Fix skip of '\r' if next
10200         character is '\n'.
10201
10202 2019-01-06  Tom Tromey  <tom@tromey.com>
10203
10204         * c-exp.y (struct c_parse_state) <macro_original_text,
10205         expansion_obstack>: New member.
10206         (macro_original_text, expansion_obstack): Remove globals.
10207         (scan_macro_expansion, scanning_macro_expansion)
10208         (finished_macro_expansion): Update.
10209         (scan_macro_cleanup): Remove.
10210         (yylex, c_parse): Update.
10211
10212 2019-01-06  Tom Tromey  <tom@tromey.com>
10213
10214         * c-exp.y (struct c_parse_state) <strings>: New member.
10215         (operator_stoken): Update.
10216
10217 2019-01-06  Tom Tromey  <tom@tromey.com>
10218
10219         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10220         (union type_stack_elt) <typelist_val>: Now a pointer to
10221         std::vector.
10222         (type_stack_cleanup): Don't declare.
10223         (push_typelist): Update.
10224         * parse.c (pop_typelist): Return a std::vector.
10225         (push_typelist): Take a std::vector.
10226         (follow_types): Update.  Do not free args.
10227         (type_stack_cleanup): Remove.
10228         * c-exp.y (struct c_parse_state): New.
10229         (cpstate): New global.
10230         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10231         (nonempty_typelist): Update.
10232         (func_mod): Create a new vector.
10233         (c_parse): Create a c_parse_state.
10234         (check_parameter_typelist): Do not delete params.
10235         (function_method): Update.  Do not delete type_list.
10236
10237 2019-01-06  Tom Tromey  <tom@tromey.com>
10238
10239         PR gdb/28155:
10240         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10241         check_typedef.
10242         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10243         (print_return_value): Likewise.
10244
10245 2019-01-05  Tom Tromey  <tom@tromey.com>
10246
10247         * contrib/cleanup_check.py: Remove.
10248         * contrib/gcc-with-excheck: Remove.
10249         * contrib/exsummary.py: Remove.
10250         * contrib/excheck.py: Remove.
10251
10252 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10253
10254         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10255         NULL. Initialize tpprev to NULL instead of assigning it
10256         to NULL on the next statement.
10257         * windows-nat.c (windows_delete_thread): Remove check for
10258         main_thread_id before printing thread exit notifications.
10259         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10260         Remove thread ID check against main_thread_id.
10261         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10262         windows_delete_thread.
10263         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10264
10265 2019-01-04  Tom Tromey  <tom@tromey.com>
10266
10267         * compile/compile.c (_initialize_compile): Use upper case for
10268         metasyntactic variables.
10269         * symmisc.c (_initialize_symmisc): Use upper case for
10270         metasyntactic variables.
10271         * psymtab.c (_initialize_psymtab): Use upper case for
10272         metasyntactic variables.
10273         * demangle.c (demangle_command): Use upper case for metasyntactic
10274         variables.
10275         (_initialize_demangler): Likewise.
10276         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10277         variables.
10278
10279 2019-01-03  Tom Tromey  <tom@tromey.com>
10280
10281         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10282
10283 2019-01-03  Tom Tromey  <tom@tromey.com>
10284
10285         * python/py-symtab.c (salpy_str): Update.
10286         (struct salpy_sal_object) <symtab>: Now a PyObject.
10287         (salpy_dealloc): Update.
10288         (del_objfile_sal): Use gdbpy_ref.
10289
10290 2019-01-03  Tom Tromey  <tom@tromey.com>
10291
10292         * python/py-type.c (convert_field): Use new_reference.  Return
10293         gdbpy_ref.
10294         (make_fielditem): Return gdbpy_ref.
10295         (typy_fields): Update.
10296         (typy_getitem): Update.
10297         (field_name): Return gdbpy_ref.  Use new_reference.
10298         (typy_iterator_iternext): Update.
10299
10300 2019-01-03  Tom Tromey  <tom@tromey.com>
10301
10302         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10303
10304 2019-01-03  Tom Tromey  <tom@tromey.com>
10305
10306         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10307         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10308         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10309         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10310         (pspy_set_type_printers): Likewise.
10311         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10312         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10313         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10314         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10315         (objfpy_set_type_printers): Likewise.
10316
10317 2019-01-03  Tom Tromey  <tom@tromey.com>
10318
10319         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10320         (gdbpy_print_stack): Use gdbpy_err_fetch.
10321         * python/python-internal.h (class gdbpy_err_fetch): New class.
10322         (class gdbpy_enter) <m_error_type, m_error_value,
10323         m_error_traceback>: Remove.
10324         <m_error>: New member.
10325         (gdbpy_exception_to_string): Don't declare.
10326         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10327         * python/py-value.c (convert_value_from_python): Use
10328         gdbpy_err_fetch.
10329         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10330         gdbpy_exception_to_string.
10331         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10332         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10333         gdbpy_err_fetch.
10334
10335 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10336
10337         * linux-nat.c (delete_lwp_cleanup): Delete.
10338         (struct lwp_deleter): New struct.
10339         (lwp_info_up): New typedef.
10340         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10341         lwp_info_up.
10342
10343 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10344
10345         * linux-fork.c (class scoped_switch_fork_info): New class.
10346         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10347
10348 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10349
10350         * valops.c (find_overload_match): Remove use of null_cleanup, and
10351         calls to do_cleanups.
10352
10353 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10354
10355         * compile/compile-cplus-types.c
10356         (compile_cplus_instance::decl_name): Handle changes to
10357         cp_func_name.
10358         * cp-support.c (cp_func_name): Update header comment, update
10359         return type.
10360         * cp-support.h (cp_func_name): Update return type in declaration.
10361         * valops.c (find_overload_match): Move temp_func local to top
10362         level of function and change its type.  Use temp_func to hold and
10363         delete temporary string obtained from cp_func_name.
10364
10365 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10366
10367         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10368         gdb::char_vector, remove cleanup, and update uses of `msg`.
10369
10370 2019-01-03  Jim Wilson  <jimw@sifive.com>
10371
10372         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10373
10374 2019-01-02  Tom Tromey  <tom@tromey.com>
10375
10376         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10377         (tdesc_parse_xml): Remove cleanups.
10378         * target-descriptions.h (make_cleanup_free_target_description):
10379         Don't declare.
10380         (target_desc_deleter): New struct.
10381         (target_desc_up): New typedef.
10382         * target-descriptions.c (target_desc_deleter::operator()): Rename
10383         from free_target_description.
10384         (make_cleanup_free_target_description): Remove.
10385
10386 2019-01-02  Tom Tromey  <tom@tromey.com>
10387
10388         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10389         constructor, destructor.
10390         (linespec_parser): Remove typedef.
10391         (~linespec_parser): Rename from linespec_parser_delete.
10392         (linespec_lex_to_end, linespec_complete_label)
10393         (linespec_complete): Update.
10394         (decode_line_full): Remove cleanups.
10395         (decode_line_1): Update.
10396
10397 2019-01-02  Tom Tromey  <tom@tromey.com>
10398
10399         * python/python-internal.h (inferior_to_inferior_object): Change
10400         return type.
10401         * python/py-exitedevent.c (create_exited_event_object): Update.
10402         * python/py-inferior.c (inferior_to_inferior_object): Return
10403         gdbpy_ref.
10404         (python_new_inferior, python_inferior_deleted)
10405         (thread_to_thread_object, delete_thread_object)
10406         (build_inferior_list, gdbpy_selected_inferior): Update.
10407         * python/py-infthread.c (create_thread_object): Update.  Also fail
10408         if inferior_to_inferior_object fails.
10409
10410 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10411
10412         * inferior.h (class inferior) <displaced_step_state>: New field.
10413         * infrun.h (struct displaced_step_state): Move here from
10414         infrun.c.  Initialize fields, add constructor.
10415         <inf>: Remove field.
10416         <reset>: New method.
10417         * infrun.c (struct displaced_step_inferior_state): Move to
10418         infrun.h.
10419         (displaced_step_inferior_states): Remove.
10420         (get_displaced_stepping_state): Adust.
10421         (displaced_step_in_progress_any_inferior): Adjust.
10422         (displaced_step_in_progress_thread): Adjust.
10423         (displaced_step_in_progress): Adjust.
10424         (add_displaced_stepping_state): Remove.
10425         (get_displaced_step_closure_by_addr): Adjust.
10426         (remove_displaced_stepping_state): Remove.
10427         (infrun_inferior_exit): Call displaced_step_state.reset.
10428         (use_displaced_stepping): Don't check for NULL.
10429         (displaced_step_prepare_throw): Call
10430         get_displaced_stepping_state.
10431         (displaced_step_fixup): Don't check for NULL.
10432         (prepare_for_detach): Don't check for NULL.
10433
10434 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10435
10436         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10437          in case of call that did not complete.
10438
10439 2019-01-02  Andrey Utkin  <autkin@undo.io>
10440
10441         * symfile.c (find_separate_debug_file): Fix search of debug files for
10442         remote debuggee.
10443
10444 2019-01-02  Tom Tromey  <tom@tromey.com>
10445
10446         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10447         indentation.
10448         * python/py-frame.c (frapy_older): Remove cast.
10449         (frapy_newer): Likewise.
10450         * python/py-breakpoint.c (local_setattro): Remove cast.
10451         * python/py-arch.c (archpy_name): Remove local variable.
10452         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10453
10454 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10455
10456         * unittests/basic_string_view/element_access/char/empty.cc:
10457         Fix year range in copyright header.
10458
10459 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10460
10461         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10462         Delete.
10463         <operator==>: Update with for removed field.
10464         <hash>: Likewise.
10465         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10466         <isa_features>: ...this.
10467         <abi_features>: New field.
10468         (riscv_isa_flen): Update comment.
10469         (riscv_abi_xlen): New declaration.
10470         (riscv_abi_flen): New declaration.
10471         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10472         isa_features.
10473         (riscv_abi_xlen): New function.
10474         (riscv_isa_flen): Update to get answer from isa_features.
10475         (riscv_abi_flen): New function.
10476         (riscv_has_fp_abi): Update to get answer from abi_features.
10477         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10478         xlen and flen.
10479         (riscv_call_info) <xlen, flen>: Update comment.
10480         (riscv_call_arg_struct): Remove invalid assertions
10481         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10482         is removed.
10483         (riscv_gdbarch_init): Gather isa features and abi features
10484         separately, ensure both match on the gdbarch when reusing an old
10485         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10486         a target with 64-bit float hardware.
10487
10488 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10489
10490         * source.c (search_command_helper): Stop reverse search
10491         when line 1 has been searched.
10492
10493 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10494
10495         * record-full.c (record_full_base_target::close): Rewrite
10496         record_full_core_buf_list free logic.
10497
10498 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10499
10500         * break-catch-syscall.c (print_one_catch_syscall): xfree
10501         the last text.
10502
10503 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10504
10505         * top.c (print_gdb_version): Update Copyright year in version
10506         message.
10507
10508 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10509
10510         Update copyright year range in all GDB files.
10511
10512 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10513
10514         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10515
10516 For older changes see ChangeLog-2018.
10517 \f
10518 Local Variables:
10519 mode: change-log
10520 left-margin: 8
10521 fill-column: 74
10522 version-control: never
10523 coding: utf-8
10524 End:
10525