gdb/ChangeLog

   1 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
   4         * breakpoint.c (bp_locations_compare): Rename to...
   5         (bp_location_is_less_than): ...this, and change to std::sort semantics.
   6         (update_global_location_list): Use std::sort instead of qsort.
   7         * buildsym.c (compare_line_numbers): Rename to...
   8         (lte_is_less_than): ...this, and change to std::sort semantics.
   9         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
  10         instead of qsort.
  11         * disasm.c (compare_lines): Rename to...
  12         (line_is_less_than): ...this, and change to std::sort semantics.
  13         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
  14         of qsort.
  15         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
  16         (fde_is_less_than): ...this, and change to std::sort semantics.
  17         (dwarf2_build_frame_info): Call std::sort instead of qsort.
  18         * mdebugread.c (compare_blocks):
  19         (block_is_less_than): ...this, and change to std::sort semantics.
  20         (sort_blocks): Call std::sort instead of qsort.
  21         * objfiles.c (qsort_cmp): Rename to...
  22         (sort_cmp): ...this, and change to std::sort semantics.
  23         (update_section_map): Call std::sort instead of qsort.
  24         * remote.c (compare_pnums): Remove.
  25         (map_regcache_remote_table): Call std::sort instead of qsort.
  26         * utils.c (compare_positive_ints): Remove.
  27         * utils.h (compare_positive_ints): Remove.
  28         * xcoffread.c (compare_lte): Remove.
  29         (arrange_linetable): Call std::sort instead of qsort.
  30
  31 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
  32
  33         * symfile.c (init_entry_point_info): Fix typo.
  34         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
  35
  36 2019-10-18  Tom de Vries  <tdevries@suse.de>
  37
  38         * aarch64-tdep.c: Fix typos in comments.
  39         * ada-lang.c: Same.
  40         * ada-tasks.c: Same.
  41         * alpha-tdep.c: Same.
  42         * alpha-tdep.h: Same.
  43         * amd64-nat.c: Same.
  44         * amd64-windows-tdep.c: Same.
  45         * arc-tdep.c: Same.
  46         * arc-tdep.h: Same.
  47         * arch-utils.c: Same.
  48         * arm-nbsd-tdep.c: Same.
  49         * arm-tdep.c: Same.
  50         * ax-gdb.c: Same.
  51         * blockframe.c: Same.
  52         * btrace.c: Same.
  53         * c-varobj.c: Same.
  54         * coff-pe-read.c: Same.
  55         * coffread.c: Same.
  56         * cris-tdep.c: Same.
  57         * darwin-nat.c: Same.
  58         * dbxread.c: Same.
  59         * dcache.c: Same.
  60         * disasm.c: Same.
  61         * dtrace-probe.c: Same.
  62         * dwarf-index-write.c: Same.
  63         * dwarf2-frame-tailcall.c: Same.
  64         * dwarf2-frame.c: Same.
  65         * dwarf2read.c: Same.
  66         * eval.c: Same.
  67         * exceptions.c: Same.
  68         * fbsd-tdep.c: Same.
  69         * findvar.c: Same.
  70         * frame.c: Same.
  71         * frv-tdep.c: Same.
  72         * gnu-v3-abi.c: Same.
  73         * go32-nat.c: Same.
  74         * h8300-tdep.c: Same.
  75         * hppa-tdep.c: Same.
  76         * i386-linux-tdep.c: Same.
  77         * i386-tdep.c: Same.
  78         * ia64-libunwind-tdep.c: Same.
  79         * ia64-tdep.c: Same.
  80         * infcmd.c: Same.
  81         * infrun.c: Same.
  82         * linespec.c: Same.
  83         * linux-nat.c: Same.
  84         * linux-thread-db.c: Same.
  85         * machoread.c: Same.
  86         * mdebugread.c: Same.
  87         * mep-tdep.c: Same.
  88         * mn10300-tdep.c: Same.
  89         * namespace.c: Same.
  90         * objfiles.c: Same.
  91         * opencl-lang.c: Same.
  92         * or1k-tdep.c: Same.
  93         * osabi.c: Same.
  94         * ppc-linux-nat.c: Same.
  95         * ppc-linux-tdep.c: Same.
  96         * ppc-sysv-tdep.c: Same.
  97         * printcmd.c: Same.
  98         * procfs.c: Same.
  99         * record-btrace.c: Same.
 100         * record-full.c: Same.
 101         * remote-fileio.c: Same.
 102         * remote.c: Same.
 103         * rs6000-tdep.c: Same.
 104         * s12z-tdep.c: Same.
 105         * score-tdep.c: Same.
 106         * ser-base.c: Same.
 107         * ser-go32.c: Same.
 108         * skip.c: Same.
 109         * sol-thread.c: Same.
 110         * solib-svr4.c: Same.
 111         * solib.c: Same.
 112         * source.c: Same.
 113         * sparc-nat.c: Same.
 114         * sparc-sol2-tdep.c: Same.
 115         * sparc-tdep.c: Same.
 116         * sparc64-tdep.c: Same.
 117         * stabsread.c: Same.
 118         * stack.c: Same.
 119         * symfile.c: Same.
 120         * symtab.c: Same.
 121         * target-descriptions.c: Same.
 122         * target-float.c: Same.
 123         * thread.c: Same.
 124         * utils.c: Same.
 125         * valops.c: Same.
 126         * valprint.c: Same.
 127         * value.c: Same.
 128         * varobj.c: Same.
 129         * windows-nat.c: Same.
 130         * xcoffread.c: Same.
 131         * xstormy16-tdep.c: Same.
 132         * xtensa-tdep.c: Same.
 133
 134 2019-10-17  Tom Tromey  <tromey@adacore.com>
 135
 136         * configure: Rebuild.
 137         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 138         in AC_CONFIG_FILES invocation.
 139         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 140         new-style config.status invocation.
 141
 142 2019-10-17  Tom de Vries  <tdevries@suse.de>
 143
 144         * arm-nbsd-nat.c: Fix typos in comments.
 145         * arm-tdep.c: Same.
 146         * darwin-nat-info.c: Same.
 147         * dwarf2read.c: Same.
 148         * elfread.c: Same.
 149         * event-top.c: Same.
 150         * findvar.c: Same.
 151         * gdbtypes.c: Same.
 152         * hppa-tdep.c: Same.
 153         * i386-tdep.c: Same.
 154         * jit.c: Same.
 155         * main.c: Same.
 156         * mdebugread.c: Same.
 157         * moxie-tdep.c: Same.
 158         * nto-procfs.c: Same.
 159         * osabi.c: Same.
 160         * ppc-linux-tdep.c: Same.
 161         * remote.c: Same.
 162         * riscv-tdep.c: Same.
 163         * s390-tdep.c: Same.
 164         * sh-tdep.c: Same.
 165         * sparc-linux-tdep.c: Same.
 166         * sparc-nat.c: Same.
 167         * stack.c: Same.
 168         * target-descriptions.c: Same.
 169         * top.c: Same.
 170         * varobj.c: Same.
 171
 172 2019-10-16  Tom Tromey  <tom@tromey.com>
 173
 174         * objfiles.h (struct objfile) <original_name>: Now const.
 175
 176 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 177
 178         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 179         pass on to sigsetjmp's second argument.
 180         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 181
 182 2019-10-16  Keith Seitz  <keiths@redhat.com>
 183
 184         PR gdb/23567
 185         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 186         sections whose size is greater than the file size.
 187
 188 2019-10-16  Jim Wilson  <jimw@sifive.com>
 189
 190         * riscv-tdep.c (riscv_gcc_target_options): New.
 191         (riscv_gnu_triplet_regexp): New.
 192         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 193         set_gdbarch_gnu_triplet_regexp.
 194
 195 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 196
 197         * Makefile.in: Add xml-builtin.h.
 198         * features/feature_to_c.sh: Add an include for xml-builtin.h
 199         to ensure that the compiler checks that the types match.
 200         * xml-builtin.h: New file.
 201         * xml-support.c (fetch_xml_builtin): Add missing const.
 202         * xml-support.h: Remove declaration of xml_builtins.
 203
 204 2019-10-16  Tom de Vries  <tdevries@suse.de>
 205
 206         PR tdep/25096
 207         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 208         (amd64_classify_aggregate): ... here.
 209         (amd64_classify_aggregate_field): Handled fiels of nested structs
 210         recursively.
 211
 212 2019-10-16  Tom de Vries  <tdevries@suse.de>
 213
 214         PR tdep/24104
 215         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 216         that handles 'theclass'.
 217
 218 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 219
 220         * linespec.c (decode_digits_ordinary): Update comment.
 221         * make-target-delegates: No longer need to handle VEC case.
 222         * memrange.c (normalize_mem_ranges): Update comment.
 223         * namespace.c (add_using_directive): Update comment.
 224         * objc-lang.c (uniquify_strings): Update comment.
 225         * ppc-linux-nat.c (struct thread_points): Update comment.
 226         * probe.h (find_probes_in_objfile): Update comment.
 227         * target.h (enum flash_preserve_mode): Update comment.
 228         * varobj.c (varobj_restrict_range): Update comment.
 229         * varobj.h (varobj_list_children): Update comment.
 230
 231 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 232
 233         * Makefile.in: Remove references to vec.h and vec.c.
 234         * aarch64-tdep.c: No longer include vec.h.
 235         * ada-lang.c: Likewise.
 236         * ada-lang.h: Likewise.
 237         * arm-tdep.c: Likewise.
 238         * ax.h: Likewise.
 239         * breakpoint.h: Likewise.
 240         * charset.c: Likewise.
 241         * cp-support.h: Likewise.
 242         * dtrace-probe.c: Likewise.
 243         * dwarf2read.c: Likewise.
 244         * extension.h: Likewise.
 245         * gdb_bfd.c: Likewise.
 246         * gdbsupport/gdb_vecs.h: Likewise.
 247         * gdbsupport/vec.c: Remove.
 248         * gdbsupport/vec.h: Remove.
 249         * gdbthread.h: Likewise.
 250         * guile/scm-type.c: Likewise.
 251         * inline-frame.c: Likewise.
 252         * machoread.c: Likewise.
 253         * memattr.c: Likewise.
 254         * memrange.h: Likewise.
 255         * namespace.h: Likewise.
 256         * nat/linux-btrace.h: Likewise.
 257         * osdata.c: Likewise.
 258         * parser-defs.h: Likewise.
 259         * progspace.h: Likewise.
 260         * python/py-type.c: Likewise.
 261         * record-btrace.c: Likewise.
 262         * rust-exp.y: Likewise.
 263         * solib-target.c: Likewise.
 264         * stap-probe.c: Likewise.
 265         * target-descriptions.c: Likewise.
 266         * target-memory.c: Likewise.
 267         * target.h: Likewise.
 268         * varobj.c: Likewise.
 269         * varobj.h: Likewise.
 270         * xml-support.h: Likewise.
 271
 272 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 273
 274         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 275         Update for new std::vector based implementation.
 276         (process_psymtab_comp_unit_reader): Likewise.
 277         (scan_partial_symbols): Likewise.
 278         (recursively_compute_inclusions): Likewise.
 279         (compute_compunit_symtab_includes): Likewise.
 280         (process_imported_unit_die): Likewise.
 281         (queue_and_load_dwo_tu): Likewise.
 282         (follow_die_sig_1): Likewise.
 283         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 284         (typedef dwarf2_per_cu_ptr): Remove.
 285         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 286         function.
 287         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 288         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 289         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 290         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 291         std::vector.
 292
 293 2019-10-15  Tom Tromey  <tromey@adacore.com>
 294
 295         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 296         TID.
 297
 298 2019-10-15  Tom Tromey  <tromey@adacore.com>
 299
 300         * windows-nat.c (windows_nat_target::fetch_registers)
 301         (windows_nat_target::store_registers): Rename "pid" to "tid".
 302
 303 2019-10-15  Tom Tromey  <tromey@adacore.com>
 304
 305         * gdbarch.h, gdbarch.c: Rebuild.
 306         * gdbarch.sh (gcc_target_options): Change return type to
 307         std::string.
 308         * compile/compile.c (get_args): Update.
 309         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 310         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 311         std::string.
 312         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 313         std::string.
 314         * arch-utils.c (default_gcc_target_options): Return std::string.
 315         * arch-utils.h (default_gcc_target_options): Return std::string.
 316         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 317
 318 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 319
 320         * breakpoint.c (breakpoint_chain): Make static.
 321         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 322         of accessing breakpoint_chain.
 323
 324 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 325
 326         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 327         to a gdb::function_view and return value to bool.
 328         * breakpoint.h (iterate_over_breakpoints): Likewise.
 329         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 330         (pop_dummy_frame): Update.
 331         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 332         (gdbscm_breakpoints): Update.
 333         * python/py-breakpoint.c (build_bp_list): Update.
 334         (gdbpy_breakpoints): Update.
 335         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 336         Update.
 337         (bpfinishpy_handle_stop): Update.
 338         (bpfinishpy_handle_exit): Update.
 339         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 340         (svr4_update_solib_event_breakpoints): Update.
 341
 342 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 343
 344         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 345         when unwrapping single-field structs.
 346
 347 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 348
 349         * dwarf2read.c: Remove includes.
 350
 351 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 352
 353         * ui-out.c (ui_out::call_do_message): Silence
 354         -Wformat-nonliteral warning.
 355
 356 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 357
 358         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 359         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 360         include: readline/tilde.h.
 361
 362 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 363
 364         * remote.c (remote_target::get_trace_status): Remove declaration of
 365         trace_regblock_size.
 366
 367 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 368
 369         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 370         (show_user): Remove declaration of cmdlist.
 371         * cli/cli-cmds.h (max_user_call_depth): Declare.
 372         * cli/cli-script.c (execute_user_command): Remove declaration
 373         of max_user_call_depth.
 374
 375 2019-10-11  Jim Wilson  <jimw@sifive.com>
 376
 377         * gdbsupport/print-utils.h (pulongest): Fix comment.
 378         (plongest): Likewise.
 379         (phex): Add missing comment, mention leading zeros.
 380         (phex_nz): Add mention of no leading zeros to comment.
 381
 382         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 383         plongest instead of unsigned long long cast.
 384
 385 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 386
 387         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 388         for external_editor_command and gdbtk_test.
 389
 390 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 391
 392         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 393         * varobj.c (varobjdebug): Move comment to...
 394         * varobj.h (varobjdebug): ...here, and declare.
 395
 396 2019-10-09  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 399         erase_data_content.
 400
 401 2019-10-09  Tom Tromey  <tom@tromey.com>
 402
 403         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 404         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 405         * tui/tui-command.c (tui_cmd_window::resize)
 406         (tui_refresh_cmd_win): Update.
 407         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 408         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 409         * tui/tui-data.c (~tui_gen_win_info): Remove.
 410         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 411         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 412         (tui_redisplay_readline, tui_mld_flush)
 413         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 414         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 415         (tui_data_window::erase_data_content)
 416         (tui_data_item_window::rerender)
 417         (tui_data_item_window::refresh_window): Update.
 418         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 419         (box_win, tui_gen_win_info::make_window)
 420         (tui_gen_win_info::make_visible): Update.
 421         (tui_delete_win): Remove.
 422         * tui/tui-winsource.c
 423         (tui_source_window_base::do_erase_source_content): Update.
 424         (tui_show_source_line, tui_source_window_base::update_tab_width)
 425         (tui_source_window_base::update_exec_info): Update.
 426         * tui/tui-data.h (struct curses_deleter): New.
 427         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 428         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 429
 430 2019-10-09  Tom Tromey  <tom@tromey.com>
 431
 432         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 433
 434 2019-10-09  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 437         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 438
 439 2019-10-09  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 442         window height directly.
 443         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 444         declare.
 445         * tui/tui-layout.c (tui_default_win_height): Remove.
 446         (tui_default_win_viewport_height): Remove.
 447
 448 2019-10-09  Tom Tromey  <tom@tromey.com>
 449
 450         * tui/tui.h: Remove comments.
 451
 452 2019-10-09  Tom de Vries  <tdevries@suse.de>
 453
 454         * python/lib/gdb/printer/bound_registers.py: Use
 455         '^builtin_type_bound128' as regexp argument for
 456         add_builtin_pretty_printer.
 457
 458 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 459
 460         * guile/guile.c (guile_extension_script_ops): Remove forward
 461         declaration and mark as static.
 462         (guile_script_ops): Likewise.
 463         (extension_language_guile): Move further down in the file so
 464         it can reference the definitions for guile_{extension_,}script_ops.
 465
 466 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 467
 468         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 469         except SORTL, DFLTCC, and KDSA.
 470
 471 2019-10-08  Tom Tromey  <tromey@adacore.com>
 472
 473         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 474         (struct safe_symbol_file_add_args): Remove.
 475
 476 2019-10-08  Tom Tromey  <tromey@adacore.com>
 477
 478         * windows-nat.c: Don't include buildsym-legacy.h.
 479
 480 2019-10-08  Tom Tromey  <tromey@adacore.com>
 481
 482         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 483
 484 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 485
 486         * gdbtypes.c (overload_debug): Move comment to header.
 487         * gdbtypes.h (overload_debug): Declare.
 488         * valops.c: Remove declaration of overload_debug, instead
 489         include gdbtypes.h.
 490
 491 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 492
 493         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 494         through _().
 495         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 496         move comment...
 497         * language.h (lang_frame_mismatch_warn): ... here. Also add
 498         declaration.
 499         * top.c (lang_frame_mismatch_warn): Remove declaration.
 500         (check_frame_language_change): Pass lang_frame_mismatch_warn
 501         through _().
 502
 503 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 504
 505         * c-lang.h (vtbl_ptr_name): Declare.
 506         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 507         it from the header.
 508         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 509
 510 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 511
 512         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 513         gdb_static_assert.
 514
 515 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 516
 517         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 518         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 519         * ctfread.c: New file.
 520         * ctfread.h: New file.
 521         * elfread.c: Include ctfread.h.
 522         (struct elfinfo text_p): New member ctfsect.
 523         (elf_locate_sections): Mark CTF section.
 524         (elf_symfile_read): Call elfctf_build_psymtabs.
 525         * Makefile.in (LIBCTF): Add.
 526         (CLIBS): Use it.
 527         (CDEPS): Likewise.
 528         (DIST): Add ctfread.c.
 529
 530 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * ctfread.c (struct nextfield): Renamed to ...
 533         (struct ctf_nextfield): ... this.
 534         (struct field_info): Renamed to ...
 535         (strut ctf_field_info): ... this.
 536         (attach_fields_to_type): Update for renamed structures.
 537         (ctf_add_member_cb): Likewise.
 538         (ctf_add_enum_member_cb): Likewise.
 539         (process_struct_members): Likewise.
 540         (process_enum_type): Likewise.
 541
 542 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 543
 544         * tracectf.h: Rename, was ctf.h.
 545         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 546         * tracefile.c: Likewise.
 547         * tracepoint.c: Remove unused include ctf.h.
 548         * mi/mi-main.c: Likewise.
 549         * Makefile.in Replace ctf.c with tracectf.c.
 550
 551 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 552
 553         * version.in: Change version number to "9.0.50.DATE-git".
 554
 555 2019-10-03  Tom Tromey  <tom@tromey.com>
 556
 557         PR rust/24976:
 558         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 559
 560 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 561
 562         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 563         cp_search_name_hash.
 564         * NEWS: Add entry about nested function support.
 565
 566 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 567             Andrew Burgess  <andrew.burgess@embecosm.com>
 568
 569         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 570         for nested static variables when searchin VAR_DOMAIN.
 571         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 572         global scope, update comment.
 573         (add_partial_subprogram): Call add_partial_subprogram recursively
 574         for nested subroutines when processinng Fortran.
 575         (load_partial_dies): Process the child entities of a subprogram
 576         when processing Fortran.
 577         (partial_die_parent_scope): Handle building scope
 578         for Fortran nested functions.
 579         (process_die): Record that nested functions have a scope.
 580         (new_symbol): Always record Fortran subprograms on the global
 581         symbol list.
 582         (determine_prefix): How to build the prefix for Fortran
 583         subprograms.
 584
 585 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 586
 587         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 588         have just sent the thread a SIGSTOP and are waiting for it to
 589         arrive.
 590
 591 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 592
 593         * btrace.c (btrace_add_pc): Remove whitespace before the template
 594         parameter in 'std::vector <...>'.
 595         (parse_xml_btrace_block): Likewise.
 596         (btrace_maint_decode_pt): Likewise.
 597         (btrace_maint_update_packets): Likewise.
 598         (btrace_maint_print_packets): Likewise.
 599         * btrace.h (struct btrace_maint_info): Likewise.
 600         * dwarf2read.c (struct type_unit_group): Likewise.
 601         (build_type_psymtabs_reader): Likewise.
 602         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 603         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 604         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 605
 606 2019-10-03  Tom de Vries  <tdevries@suse.de>
 607
 608         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 609         the first line of the help text for set/show style metadata.
 610
 611 2019-10-02  Tom Tromey  <tromey@adacore.com>
 612
 613         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 614         * gdbsupport/common-inferior.c: New file.
 615         * infcmd.c (startup_with_shell): Don't define.
 616         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 617         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 618         * inferior.h (startup_with_shell): Don't declare.
 619
 620 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 621
 622         * gdbsupport/gdb_assert.h: Include errors.h.
 623         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 624
 625 2019-10-02  Tom Tromey  <tromey@adacore.com>
 626
 627         * NEWS: Add $_ada_exception entry.
 628         * ada-lang.c (struct ada_catchpoint): Add constructor.
 629         <m_kind>: New member.
 630         (allocate_location_exception, re_set_exception): Remove
 631         "ex" parameter.
 632         (should_stop_exception): Compute $_ada_exception.
 633         (check_status_exception, print_it_exception)
 634         (print_one_exception, print_mention_exception): Remove
 635         "ex" parameter.
 636         (allocate_location_catch_exception, re_set_catch_exception)
 637         (check_status_exception, print_it_catch_exception)
 638         (print_one_catch_exception, print_mention_catch_exception)
 639         (print_recreate_catch_exception)
 640         (allocate_location_catch_exception_unhandled)
 641         (re_set_catch_exception_unhandled)
 642         (check_status_exception, print_it_catch_exception_unhandled)
 643         (print_one_catch_exception_unhandled)
 644         (print_mention_catch_exception_unhandled)
 645         (print_recreate_catch_exception_unhandled)
 646         (allocate_location_catch_assert, re_set_catch_assert)
 647         (check_status_assert, print_it_catch_assert)
 648         (print_one_catch_assert, print_mention_catch_assert)
 649         (print_recreate_catch_assert)
 650         (allocate_location_catch_handlers, re_set_catch_handlers)
 651         (check_status_handlers, print_it_catch_handlers)
 652         (print_one_catch_handlers, print_mention_catch_handlers)
 653         (print_recreate_catch_handlers): Remove.
 654         (create_ada_exception_catchpoint): Update.
 655         (initialize_ada_catchpoint_ops): Update.
 656
 657 2019-10-02  Tom Tromey  <tromey@adacore.com>
 658
 659         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 660         (create_excep_cond_exprs): Simplify exception string computation.
 661         (ada_exception_catchpoint_cond_string): Likewise.
 662
 663 2019-10-02  Tom Tromey  <tromey@adacore.com>
 664
 665         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 666         * ada-lang.c (lesseq_defined_than): Handle
 667         LOC_STATIC.
 668         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 669         parameter.
 670         (dwarf2_has_info): Likewise.
 671         (new_symbol): Set maybe_copied on symbol when
 672         appropriate.
 673         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 674         parameter.
 675         <can_copy>: New member.
 676         * elfread.c (record_minimal_symbol): Set maybe_copied
 677         on symbol when appropriate.
 678         (elf_symfile_read): Update call to dwarf2_has_info.
 679         * minsyms.c (lookup_minimal_symbol_linkage): New
 680         function.
 681         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 682         * symtab.c (get_symbol_address, get_msymbol_address):
 683         New functions.
 684         * symtab.h (get_symbol_address, get_msymbol_address):
 685         Declare.
 686         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 687         maybe_copied.
 688         (struct symbol, struct minimal_symbol) <maybe_copied>:
 689         New member.
 690
 691 2019-10-02  Tom Tromey  <tromey@adacore.com>
 692
 693         * source.c (struct current_source_location): New.
 694         (current_source_key): New global.
 695         (current_source_symtab, current_source_line)
 696         (current_source_pspace): Remove.
 697         (get_source_location): New function.
 698         (get_current_source_symtab_and_line)
 699         (set_default_source_symtab_and_line)
 700         (set_current_source_symtab_and_line)
 701         (clear_current_source_symtab_and_line, select_source_symtab)
 702         (info_source_command, print_source_lines_base)
 703         (info_line_command, search_command_helper, _initialize_source):
 704         Update.
 705
 706 2019-10-02  Tom Tromey  <tromey@adacore.com>
 707
 708         * source.c (select_source_symtab): Don't call
 709         decode_line_with_current_source.
 710
 711 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 712
 713         * symtab.c (lookup_global_symbol): Search global block.
 714
 715 2019-10-02  Tom Tromey  <tromey@adacore.com>
 716
 717         * coffread.c (process_coff_symbol): Update.
 718         * dwarf2read.c (var_decode_location, new_symbol): Update.
 719         * mdebugread.c (parse_symbol): Update.
 720         * objfiles.c (relocate_one_symbol): Update.
 721         * stabsread.c (define_symbol, fix_common_block)
 722         (scan_file_globals): Update.
 723         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 724         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 725         * xcoffread.c (process_xcoff_symbol): Update.
 726
 727 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 728
 729         * MAINTAINERS: Update my email address.
 730
 731 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 732
 733         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 734         std::vector.
 735         (build_type_psymtabs_reader): Update for std::vector.
 736         (build_type_psymtab_dependencies): Likewise.
 737         * dwarf2read.h: Remove use of DEF_VEC_P.
 738         (typedef sig_type_ptr): Delete.
 739
 740 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 741
 742         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 743         to std::vector.
 744         (btrace_maint_decode_pt): Likewise, and move allocation of the
 745         vector outside of the loop.
 746         (btrace_maint_update_packets): Update to handle change from VEC to
 747         std::vector.
 748         (btrace_maint_print_packets): Likewise.
 749         (maint_info_btrace_cmd): Likewise.
 750         * btrace.h: Remove use of DEF_VEC_O.
 751         (typedef btrace_pt_packet_s): Delete.
 752         (struct btrace_maint_info) <packets>: Change fromm VEC to
 753         std::vector.
 754         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 755
 756 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 757
 758         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 759         make accesses into the vector constant references.
 760         (btrace_add_pc): Update for std::vector.
 761         (btrace_stitch_bts): Likewise.
 762         (parse_xml_btrace_block): Likewise.
 763         (btrace_maint_update_packets): Likewise.
 764         (btrace_maint_print_packets): Likewise.
 765         (maint_info_btrace_cmd): Likewise.
 766         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 767         std::vector.
 768         (btrace_data::empty): Likewise.
 769         (btrace_data_append): Likewise.
 770         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 771         (typedef btrace_block_s): Delete.
 772         (struct btrace_block): Add constructor.
 773         (struct btrace_data_bts) <blocks>: Change to std::vector.
 774         * nat/linux-btrace.c (perf_event_read_bts): Update for
 775         std::vector.
 776         (linux_read_bts): Likewise.
 777
 778 2019-10-01  Tom Tromey  <tom@tromey.com>
 779
 780         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 781
 782 2019-10-01  Tom Tromey  <tom@tromey.com>
 783
 784         * stack.c (print_frame, info_frame_command_core): Use
 785         styled_string.
 786         * linux-thread-db.c (try_thread_db_load_1)
 787         (try_thread_db_load_from_pdir_1): Use styled_string.
 788         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 789         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 790         (maybe_print_unsupported_script_warning)
 791         (maybe_print_script_not_found_warning): Use styled_string.
 792         * ada-lang.c (user_select_syms): Use styled_string.
 793
 794 2019-10-01  Tom Tromey  <tom@tromey.com>
 795
 796         * p-lang.c (pascal_printstr): Use metadata style.
 797         * value.c (show_convenience): Use metadata style.
 798         * valprint.c (valprint_check_validity, val_print_optimized_out)
 799         (val_print_not_saved, val_print_unavailable)
 800         (val_print_invalid_address, generic_val_print, val_print)
 801         (value_check_printable, val_print_array_elements): Use metadata
 802         style.
 803         * ui-out.h (class ui_out) <field_fmt>: New overload.
 804         <do_field_fmt>: Add style parameter.
 805         * ui-out.c (ui_out::field_fmt): New overload.
 806         * typeprint.c (type_print_unknown_return_type)
 807         (val_print_not_allocated, val_print_not_associated): Use metadata
 808         style.
 809         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 810         parameter.
 811         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 812         * tracepoint.c (tvariables_info_1): Use metadata style.
 813         * stack.c (print_frame_arg, print_frame_info, print_frame)
 814         (info_frame_command_core): Use metadata style.
 815         * skip.c (info_skip_command): Use metadata style.
 816         * rust-lang.c (rust_print_enum): Use metadata style.
 817         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 818         metadata style.
 819         * python/py-framefilter.c (py_print_single_arg): Use metadata
 820         style.
 821         * printcmd.c (do_one_display, print_variable_and_value): Use
 822         metadata style.
 823         * p-valprint.c (pascal_val_print)
 824         (pascal_object_print_value_fields): Use metadata style.
 825         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 826         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 827         parameter.
 828         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 829         * m2-valprint.c (m2_print_long_set): Use metadata style.
 830         * m2-typeprint.c (m2_print_type): Use metadata style.
 831         * infcmd.c (print_return_value_1): Use metadata style.
 832         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 833         * f-valprint.c (info_common_command_for_block): Use metadata
 834         style.
 835         * f-typeprint.c (f_type_print_base): Use metadata style.
 836         * expprint.c (print_subexp_standard): Use metadata style.
 837         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 838         * cli/cli-style.h (class cli_style_option): Add constructor.
 839         (metadata_style): Declare.
 840         * cli/cli-style.c (metadata_style): New global.
 841         (_initialize_cli_style): Register metadata style.
 842         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 843         parameter.
 844         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 845         * c-typeprint.c (c_type_print_base_struct_union)
 846         (c_type_print_base_1): Use metadata style.
 847         * breakpoint.c (watchpoint_value_print)
 848         (print_one_breakpoint_location): Use metadata style.
 849         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 850         style.
 851         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 852         style.
 853         * ada-valprint.c (val_print_packed_array_elements, printstr)
 854         (print_field_values, ada_val_print_ref, ada_val_print): Use
 855         metadata style.
 856         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 857         style.
 858         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 859         style.
 860         * ada-lang.c (user_select_syms): Use metadata style.
 861
 862 2019-10-01  Tom Tromey  <tom@tromey.com>
 863
 864         * cli/cli-cmds.c (pwd_command): Style output.
 865
 866 2019-10-01  Pedro Alves  <palves@redhat.com>
 867             Tom Tromey  <tom@tromey.com>
 868
 869         * symtab.c (print_symbol_info): Use %ps.
 870         (print_msymbol_info): Use %ps.
 871         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 872         * printcmd.c (print_variable_and_value): Use %ps.
 873         * macrocmd.c (show_pp_source_pos): Use %ps.
 874         * infrun.c (print_exited_reason): Use ui_out::message.
 875         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 876         (describe_other_breakpoints): Use ui_out::message and new
 877         formats.
 878         (say_where): Use new formats.
 879         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 880         and new formats.
 881
 882 2019-10-01  Pedro Alves  <palves@redhat.com>
 883             Tom Tromey  <tom@tromey.com>
 884
 885         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 886         (test_gdb_formats): New function.
 887         (run_tests): Call it.
 888         (test_format_specifier): Update.
 889         * utils.h (fputs_filtered): Update comment.
 890         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 891         (fputs_styled_unfiltered): Declare.
 892         * utils.c (fputs_styled_unfiltered): New function.
 893         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 894         (vfprintf_filtered): Update.
 895         (vfprintf_unfiltered, vprintf_filtered): Update.
 896         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 897         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 898         disallow_ui_out_field>: New constants.
 899         (enum class field_kind): New.
 900         (struct base_field_s, struct signed_field_s): New.
 901         (signed_field): New function.
 902         (struct string_field_s): New.
 903         (string_field): New function.
 904         (struct styled_string_s): New.
 905         (styled_string): New function.
 906         (class ui_out) <message>: Add comment.
 907         <vmessage, call_do_message>: New methods.
 908         <do_message>: Add style parameter.
 909         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 910         methods.
 911         (ui_out::message): Rewrite.
 912         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 913         parameter.
 914         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 915         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 916         gdb_extensions parameter.
 917         (class format_piece): Add parameter to constructor.
 918         (n_int_args): New field.
 919         * gdbsupport/format.c (format_pieces::format_pieces): Add
 920         gdb_extensions parameter.  Handle '*'.
 921         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 922         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 923         vfprintf_styled_no_gdbfmt.
 924         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 925         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 926         unfiltered output.
 927         * ui-style.h (struct ui_file_style) <ptr>: New method.
 928
 929 2019-10-01  Tom Tromey  <tom@tromey.com>
 930
 931         * unittests/format_pieces-selftests.c: Update.  Add final format.
 932         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 933         empty literal pieces.
 934
 935 2019-10-01  Tom Tromey  <tom@tromey.com>
 936
 937         * ui-out.h (enum class ui_out_style_kind): Remove.
 938         (class ui_out) <field_string, field_stsream, do_field_string>:
 939         Change type of "style".
 940         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 941         (ui_out::field_string): Update.
 942         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 943         of "style".
 944         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 945         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 946         * stack.c (print_frame_arg, print_frame_info, print_frame):
 947         Update.
 948         * source.c (print_source_lines_base): Update.
 949         * solib.c (info_sharedlibrary_command): Update.
 950         * skip.c (info_skip_command): Update.
 951         * record-btrace.c (btrace_call_history_src_line)
 952         (btrace_call_history): Update.
 953         * python/py-framefilter.c (py_print_frame): Update.
 954         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 955         "style".
 956         * mi/mi-out.c (mi_ui_out::do_table_header)
 957         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 958         (mi_ui_out::do_field_string): Update.
 959         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 960         Update.
 961         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 962         "style".
 963         * cli-out.c (cli_ui_out::do_table_header)
 964         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 965         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 966         (cli_ui_out::do_field_fmt): Update.
 967         * breakpoint.c (print_breakpoint_location): Update.
 968         (update_static_tracepoint): Update.
 969
 970 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 971
 972         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 973         conversion of gdb_datadir.
 974         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 975         remove not needed c_str ().
 976
 977 2019-09-30  Ali Tamur <tamur@google.com>
 978
 979         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 980         (dwarf2_string_attr): Likewise.
 981
 982 2019-09-30  Ali Tamur <tamur@google.com>
 983
 984         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 985         (process_full_type_unit): Likewise.
 986         (dump_die_shallow): Likewise.
 987         (cu_debug_loc_section): Likewise.
 988
 989 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 990
 991         * minsyms.c (compare_minimal_symbols): Rename to...
 992         (minimal_symbol_is_less_than): ...this, and adjust to STL
 993         conventions (return bool, take arguments as references)
 994         (minimal_symbol_reader::install): Call std::sort instead
 995         of qsort.
 996
 997 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 998
 999         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1000         hash and why.
1001         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1002         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1003
1004 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1005
1006         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1007         * psympriv.h (add_psymbol_to_list): Move comment here and update
1008         it.
1009
1010 2019-09-29  Tom de Vries  <tdevries@suse.de>
1011
1012         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1013         Use $tmpdir/$(basename "$output_file").dwz instead of
1014         "${output_file}.dwz".
1015
1016 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1017
1018         PR gdb/25045
1019         * hppa-linux-nat.c: Include gdbarch.h.
1020
1021 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1022
1023         * blockframe.c (find_pc_partial_function): Change return type to bool.
1024         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1025         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1026         (stub_gnu_ifunc_resolve_name): Likewise.
1027         * symtab.c (compare_filenames_for_search): Likewise.
1028         (compare_glob_filenames_for_search): Likewise.
1029         (matching_obj_sections): Likewise.
1030         (symbol_matches_domain): Likewise.
1031         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1032         (find_line_pc): Change return type to bool.
1033         (find_line_pc_range): Likewise.
1034         (producer_is_realview): Likewise.
1035         * symtab.h (symbol_matches_domain): Likewise.
1036         (find_pc_partial_function): Likewise.
1037         (find_pc_line_pc_range): Likewise.
1038         (in_gnu_ifunc_stub): Likewise.
1039         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1040         (find_line_pc): Likewise.
1041         (find_line_pc_range): Likewise.
1042         (matching_obj_sections): Likewise.
1043         (find_line_symtab): Change out parameter to bool.
1044         (producer_is_realview): Change return type to bool.
1045         (compare_filenames_for_search): Likewise.
1046         (compare_glob_filenames_for_search): Likewise.
1047
1048 2019-09-26  Tom Tromey  <tom@tromey.com>
1049
1050         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1051         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1052         * gdb_usleep.h: Remove.
1053         * gdb_usleep.c: Remove.
1054         * utils.c: Don't include gdb_usleep.h.
1055
1056 2019-09-26  Tom Tromey  <tromey@adacore.com>
1057
1058         * python/py-type.c (type_to_type_object): Call check_typedef
1059         for stub types.
1060
1061 2019-09-26  Tom Tromey  <tom@tromey.com>
1062
1063         * utils.h (initialize_utils): Don't declare.
1064         * top.c (gdb_init): Don't call initialize_utils.
1065         * utils.c (initialize_utils): Remove.  Move contents...
1066         (_initialize_utils): ... here.
1067
1068 2019-09-25  Tom Tromey  <tom@tromey.com>
1069
1070         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1071         * utils.h (make_hex_string): Don't declare.
1072         * utils.c (make_hex_string): Remove.
1073
1074 2019-09-24  Tom de Vries  <tdevries@suse.de>
1075
1076         PR gdb/23815
1077         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1078         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1079
1080 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1081
1082         * NEWS: Mention new simulator port for PRU.
1083
1084 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1085
1086         * ada-exp.y (write_object_remaining): Update.
1087         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1088         and eliminate the static buffer.
1089         (ada_decode_symbol): Update.
1090         (ada_la_decode): Update.
1091         (ada_sniff_from_mangled_name): Update.
1092         (is_valid_name_for_wild_match): Update.
1093         (ada_lookup_name_info::matches): Update and simplify.
1094         (name_matches_regex): Update.
1095         (ada_add_global_exceptions): Update.
1096         * ada-lang.h (ada_decode): Update signature.
1097         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1098         * dwarf-index-write.c (debug_names::insert): Update.
1099
1100 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1101
1102         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1103         formatting.
1104
1105 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1106
1107         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1108         Change "nonzero" to "true" in documentation.
1109
1110 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1111
1112         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1113         (_initialize_darwin_solib): Don't set
1114         darwin_so_ops.lookup_lib_global_symbol.
1115         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1116         set_gdbarch_iterate_over_objfiles_in_search_order.
1117         (elf_lookup_lib_symbol): Rename to...
1118         (svr4_iterate_over_objfiles_in_search_order): this, and update
1119         to iterate semantics.
1120         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1121         * solib.c (solib_global_lookup): Remove.
1122         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1123         (solib_global_lookup): Remove.
1124         * symtab.c (lookup_global_or_static_symbol): Remove call to
1125         solib_global_lookup.
1126
1127 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1128
1129         * NEWS: Move entries about default MI version now being
1130         version 3, and about the GDB/MI fix for multi-location
1131         breakpoints to the "since GDB 8.3" section.
1132
1133 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1134
1135         GDB 8.3.1 released.
1136
1137 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1138
1139         * NEWS: Mention that Cell/B.E. debugging support was removed.
1140         * MAINTAINERS: Remove spu target.
1141
1142         * config/djgpp/fnchange.lst: Remove entries for removed files.
1143
1144         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1145         spu-multiarch.o, and spu-tdep.o.
1146         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1147         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1148         spu-multiarch.c, and spu-tdep.c.
1149         * spu-linux-nat.c: Remove file.
1150         * spu-multiarch.c: Remove file.
1151         * spu-tdep.c: Remove file.
1152         * spu-tdep.h: Remove file.
1153         * solib-spu.c: Remove file.
1154         * solib-spu.h: Remove file.
1155
1156         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1157         * configure.nat (spu-linux): Remove.
1158         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1159         solib-multiarch.o from gdb_target_obs.
1160         (spu*-*-*): Remove.
1161
1162         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1163         feature flag.
1164         (ppc_linux_no_features): Update.
1165         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1166         Cell/B.E. support.
1167         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1168         (tdesc_powerpc_cell64l): Likewise.
1169         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1170         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1171         Cell/B.E. support.
1172         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1173         Do not include "features/rs6000/powerpc-cell32l.c" or
1174         "features/rs6000/powerpc-cell64l.c".
1175         (ppc_linux_spu_section): Remove.
1176         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1177         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1178         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1179         (ppc_linux_spe_context_lookup): Remove.
1180         (ppc_linux_spe_context_inferior_created): Remove.
1181         (ppc_linux_spe_context_solib_loaded): Remove.
1182         (ppc_linux_spe_context_solib_unloaded): Remove.
1183         (ppc_linux_spe_context): Remove.
1184         (struct ppu2spu_cache): Remove.
1185         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1186         (struct ppu2spu_data): Remove.
1187         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1188         ppu2spu_unwind): Remove.
1189         (ppc_linux_init_abi): Remove Cell/B.E. support.
1190         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1191
1192         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1193         (rs6000/powerpc-cell64l-expedite): Likewise
1194         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1195         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1196         rs6000/powerpc-cell64l.xml.
1197         * features/rs6000/powerpc-cell32l.xml: Remove.
1198         * features/rs6000/powerpc-cell64l.xml: Likewise.
1199         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1200         * features/rs6000/powerpc-cell64l.c: Likewise.
1201         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1202         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1203         * regformats/reg-spu.dat: Remove.
1204
1205         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1206         * corelow.c (struct spuid_list): Remove.
1207         (add_to_spuid_list): Remove.
1208         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1209         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1210         (remote_protocol_features): Remove associated entries.
1211         (_initialize_remote): No longer initialize them.
1212         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1213         * linux-nat.c (SPUFS_MAGIC): Remove.
1214         (linux_proc_xfer_spu): Remove.
1215         (spu_enumerate_spu_ids): Remove.
1216         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1217         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1218         (linux_make_corefile_notes): No longer call it.
1219
1220         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1221         (cooked_write_test): Likewise.
1222
1223 2019-09-20  Tom Tromey  <tom@tromey.com>
1224
1225         * NEWS: Mention case-sensitivity of TUI commands.
1226         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1227         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1228         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1229
1230 2019-09-20  Tom Tromey  <tom@tromey.com>
1231
1232         * tui/tui-source.c (tui_source_window::set_contents): Use
1233         make_unique_xstrdup.
1234         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1235         make_unique_xstrdup.
1236
1237 2019-09-20  Tom Tromey  <tom@tromey.com>
1238
1239         * tui/tui-data.c: Remove separator comments.
1240         * tui/tui-layout.c: Remove separator comments.
1241         * tui/tui-win.c: Remove separator comments.
1242         * tui/tui-wingeneral.c: Remove separator comments.
1243
1244 2019-09-20  Tom Tromey  <tom@tromey.com>
1245
1246         * tui/tui.h (strcat_to_buf): Don't declare.
1247         * tui/tui.c (strcat_to_buf): Remove.
1248
1249 2019-09-20  Tom Tromey  <tom@tromey.com>
1250
1251         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1252         from "fullname".
1253         * tui/tui-source.c (tui_source_window::set_contents)
1254         (tui_source_window::location_matches_p)
1255         (tui_source_window::maybe_update): Update.
1256
1257 2019-09-20  Tom Tromey  <tom@tromey.com>
1258
1259         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1260         Update.
1261         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1262         prefix.
1263         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1264         (tui_data_window::line_from_reg_element_no)
1265         (tui_data_window::first_reg_element_no_inline)
1266         (tui_data_window::show_registers)
1267         (tui_data_window::show_register_group)
1268         (tui_data_window::display_registers_from)
1269         (tui_data_window::display_registers_from_line)
1270         (tui_data_window::first_data_item_displayed)
1271         (tui_data_window::delete_data_content_windows)
1272         (tui_data_window::erase_data_content)
1273         (tui_data_window::do_scroll_vertical)
1274         (tui_data_window::refresh_window)
1275         (tui_data_window::check_register_values): Update.
1276
1277 2019-09-20  Tom Tromey  <tom@tromey.com>
1278
1279         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1280         (struct tui_locator_window) <full_name, proc_name>: Now
1281         std::string.
1282         * tui/tui-stack.c (tui_locator_window::make_status_line)
1283         (tui_locator_window::set_locator_fullname)
1284         (tui_locator_window::set_locator_info): Update.
1285         * tui/tui-source.c (tui_source_window::set_contents)
1286         (tui_source_window::showing_source_p): Update.
1287
1288 2019-09-20  Tom Tromey  <tom@tromey.com>
1289
1290         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1291         Don't call tui_locator_win_info_ptr.
1292
1293 2019-09-20  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1296
1297 2019-09-20  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1300         height for locator.
1301         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1302         * tui/tui-layout.c (show_source_disasm_command, show_data)
1303         (show_source_or_disasm_and_command): Use 1 as height for locator.
1304
1305 2019-09-20  Tom Tromey  <tom@tromey.com>
1306
1307         * tui/tui.c (tui_enable): Update.
1308         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1309         Update.
1310         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1311         Update.
1312         * tui/tui-data.c (win_resized): Now bool.
1313         (tui_win_resized): Return bool.
1314         (tui_set_win_resized_to): Accept a bool.
1315
1316 2019-09-20  Tom Tromey  <tom@tromey.com>
1317
1318         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1319         Change type of "refresh_values_only".
1320         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1321         type of "refresh_values_only".
1322
1323 2019-09-20  Tom Tromey  <tom@tromey.com>
1324
1325         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1326         std::string.
1327         (tui_disassemble): Add "pos" parameter.
1328         (tui_disasm_window::set_contents): Simplify.
1329
1330 2019-09-20  Tom Tromey  <tom@tromey.com>
1331
1332         * tui/tui-winsource.h (struct tui_source_window_base)
1333         <show_source_content>: Now private.
1334         * tui/tui-winsource.c
1335         (tui_source_window_base::show_source_content): Don't handle empty
1336         content case.
1337
1338 2019-09-20  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-layout.c (show_source_disasm_command)
1341         (show_source_or_disasm_and_command): Don't call
1342         show_source_content.
1343
1344 2019-09-20  Tom Tromey  <tom@tromey.com>
1345
1346         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1347         Declare.
1348         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1349         from tui_make_status_line.
1350         (tui_locator_window::rerender): Update.
1351
1352 2019-09-20  Tom Tromey  <tom@tromey.com>
1353
1354         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1355         (tui_locator_window::rerender): Update.
1356
1357 2019-09-20  Tom Tromey  <tom@tromey.com>
1358
1359         * tui/tui-winsource.h (struct tui_source_window_base)
1360         <~tui_source_window_base>: Don't declare.
1361         <fullname>: Remove.
1362         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1363         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1364         member.
1365         * tui/tui-source.c (tui_source_window::set_contents): Update.
1366         (tui_source_window::location_matches_p)
1367         (tui_source_window::maybe_update): Update.
1368
1369 2019-09-20  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-winsource.h (~tui_source_element): Remove.
1372         (tui_source_element): Update.
1373         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1374         * tui/tui-winsource.c (tui_show_source_line): Update.
1375         * tui/tui-source.c (tui_source_window::set_contents): Update.
1376         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1377
1378 2019-09-20  Tom Tromey  <tom@tromey.com>
1379
1380         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1381         declare.
1382         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1383         tui_clear_source_windows_detail.
1384         * tui/tui-winsource.h (struct tui_source_window_base)
1385         <clear_detail>: Don't declare.
1386         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1387         Remove.
1388         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1389
1390 2019-09-20  Tom Tromey  <tromey@adacore.com>
1391
1392         PR ada/24919:
1393         * block.c (contained_in): Fix final return value.
1394
1395 2019-09-20  Alan Modra  <amodra@gmail.com>
1396
1397         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1398         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1399         (read_indirect_string_from_dwz): Use bfd accessor.
1400         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1401         * machoread.c (macho_symfile_read_all_oso): Likewise.
1402         * solib.c (solib_bfd_open): Likewise.
1403
1404 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1405
1406         * eval.c: Move declaration of overload_resolution to...
1407         * value.h: ...here.
1408
1409 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1410
1411         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1412         * arm-linux-tdep.c: Likewise.
1413         * arm-nbsd-nat.c: Likewise.
1414         * arm-tdep.h: Declare arm_apcs_32.
1415         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1416
1417 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1418
1419         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1420         * dwarf2read.h: Declare dwarf_always_disassemble.
1421
1422 2019-09-19  Tom de Vries  <tdevries@suse.de>
1423
1424         PR gdb/25009
1425         * source-cache.c (source_cache::ensure): Catch exception thrown during
1426         construction of the highlighter.
1427
1428 2019-09-18  Alan Modra  <amodra@gmail.com>
1429
1430         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1431         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1432         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1433         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1434         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1435         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1436         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1437         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1438         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1439         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1440         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1441         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1442         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1443         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1444         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1445         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1446         * mi/mi-interp.c: Update throughout for bfd section macro and
1447         function changes.
1448         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1449         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1450
1451 2019-09-18  Tom Tromey  <tom@tromey.com>
1452
1453         * NEWS: Add entry.
1454         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1455         call rl_initialize.
1456         (tui_enable): Do not call rl_initialize.
1457
1458 2019-09-18  Christian Groessler  <chris@groessler.org>
1459
1460         * alpha-linux-nat.c: Include gdbarch.h.
1461
1462 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1463
1464         * ui-file.c: Include cli/cli-style.h.
1465         (term_cli_styling): Remove cli_styling declaration.
1466
1467 2019-09-18  Alan Modra  <amodra@gmail.com>
1468
1469         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1470         to bfd_asymbol_section.
1471
1472 2019-09-18  Alan Modra  <amodra@gmail.com>
1473
1474         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1475         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1476         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1477
1478 2019-09-18  Alan Modra  <amodra@gmail.com>
1479
1480         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1481         * spu-linux-nat.c (spu_bfd_open): Likewise.
1482
1483 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1484
1485         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1486         to bool to match definition in dwarf2read.c.
1487
1488 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1489
1490         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1491         (print_signatures): Likewise.
1492         (trust_pad_over_xvs): Likewise.
1493         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1494         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1495         * arm-linux-nat.c (arm_apcs_32): Likewise.
1496         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1497         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1498         * arm-tdep.c (arm_debug): Likewise.
1499         (arm_apcs_32): Likewise.
1500         * auto-load.c (debug_auto_load): Likewise.
1501         (auto_load_gdb_scripts): Likewise.
1502         (global_auto_load): Likewise.
1503         (auto_load_local_gdbinit): Likewise.
1504         (auto_load_local_gdbinit_loaded): Likewise.
1505         * auto-load.h (global_auto_load): Likewise.
1506         (auto_load_local_gdbinit): Likewise.
1507         (auto_load_local_gdbinit_loaded): Likewise.
1508         * breakpoint.c (disconnected_dprintf): Likewise.
1509         (breakpoint_proceeded): Likewise.
1510         (automatic_hardware_breakpoints): Likewise.
1511         (always_inserted_mode): Likewise.
1512         (target_exact_watchpoints): Likewise.
1513         (_initialize_breakpoint): Update.
1514         * breakpoint.h (target_exact_watchpoints): Change to bool.
1515         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1516         * cli/cli-cmds.c (trace_commands): Likewise.
1517         * cli/cli-cmds.h (trace_commands): Likewise.
1518         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1519         to bool*.
1520         * cli/cli-logging.c (logging_overwrite): Change to bool.
1521         (logging_redirect): Likewise.
1522         (debug_redirect): Likewise.
1523         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1524         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1525         to bool.
1526         <boolean_option_def>: Update.
1527         (struct flag_option_def): Change default type of Context to bool
1528         from int.
1529         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1530         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1531         (get_setshow_command_value_string): Likewise.
1532         * cli/cli-style.c (cli_styling): Change to bool.
1533         (source_styling): Likewise.
1534         * cli/cli-style.h (source_styling): Likewise.
1535         (cli_styling): Likewise.
1536         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1537         to bool.
1538         * command.h (var_types): Update comment.
1539         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1540         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1541         bool.
1542         (debug_compile_cplus_scopes): Likewise.
1543         * compile/compile-internal.h (compile_debug): Likewise.
1544         * compile/compile.c (compile_debug): Likewise.
1545         (struct compile_options) <raw>: Likewise.
1546         * cp-support.c (catch_demangler_crashes): Likewise.
1547         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1548         (usr_cmd_cris_dwarf2_cfi): Likewise.
1549         * csky-tdep.c (csky_debug): Likewise.
1550         * darwin-nat.c (enable_mach_exceptions): Likewise.
1551         * dcache.c (dcache_enabled_p): Likewise.
1552         * defs.h (info_verbose): Likewise.
1553         * demangle.c (demangle): Likewise.
1554         (asm_demangle): Likewise.
1555         * dwarf-index-cache.c (debug_index_cache): Likewise.
1556         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1557         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1558         * dwarf2read.c (check_physname): Likewise.
1559         (use_deprecated_index_sections): Likewise.
1560         (dwarf_always_disassemble): Likewise.
1561         * eval.c (overload_resolution): Likewise.
1562         * event-top.c (set_editing_cmd_var): Likewise.
1563         (exec_done_display_p): Likewise.
1564         * event-top.h (set_editing_cmd_var): Likewise.
1565         (exec_done_display_p): Likewise.
1566         * exec.c (write_files): Likewise.
1567         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1568         (debug_fbsd_nat): Likewise.
1569         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1570         Likewise.
1571         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1572         <backtrace_past_entry> Likewise.
1573         * gdb-demangle.h (demangle): Likewise.
1574         (asm_demangle): Likewise.
1575         * gdb_bfd.c (bfd_sharing): Likewise.
1576         * gdbcore.h (write_files): Likewise.
1577         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1578         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1579         * gdbthread.h (print_thread_events): Likewise.
1580         * gdbtypes.c (opaque_type_resolution): Likewise.
1581         (strict_type_checking): Likewise.
1582         * gnu-nat.c (gnu_debug_flag): Likewise.
1583         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1584         * guile/scm-param.c (pascm_variable): Add boolval.
1585         (add_setshow_generic): Update.
1586         (pascm_param_value): Update.
1587         (pascm_set_param_value_x): Update.
1588         * hppa-tdep.c (hppa_debug): Change to bool..
1589         * infcall.c (may_call_functions_p): Likewise.
1590         (coerce_float_to_double_p): Likewise.
1591         (unwind_on_signal_p): Likewise.
1592         (unwind_on_terminating_exception_p): Likewise.
1593         * infcmd.c (startup_with_shell): Likewise.
1594         * inferior.c (print_inferior_events): Likewise.
1595         * inferior.h (startup_with_shell): Likewise.
1596         (print_inferior_events): Likewise.
1597         * infrun.c (step_stop_if_no_debug): Likewise.
1598         (detach_fork): Likewise.
1599         (debug_displaced): Likewise.
1600         (disable_randomization): Likewise.
1601         (non_stop): Likewise.
1602         (non_stop_1): Likewise.
1603         (observer_mode): Likewise.
1604         (observer_mode_1): Likewise.
1605         (set_observer_mode): Update.
1606         (sched_multi): Change to bool.
1607         * infrun.h (debug_displaced): Likewise.
1608         (sched_multi): Likewise.
1609         (step_stop_if_no_debug): Likewise.
1610         (non_stop): Likewise.
1611         (disable_randomization): Likewise.
1612         * linux-tdep.c (use_coredump_filter): Likewise.
1613         (dump_excluded_mappings): Likewise.
1614         * linux-thread-db.c (auto_load_thread_db): Likewise.
1615         (check_thread_db_on_load): Likewise.
1616         * main.c (captured_main_1): Update.
1617         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1618         xx2_opt, boolean_opt>: Change to bool.
1619         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1620         * maint.c (maintenance_profile_p): Likewise.
1621         (per_command_time): Likewise.
1622         (per_command_space): Likewise.
1623         (per_command_symtab): Likewise.
1624         * memattr.c (inaccessible_by_default): Likewise.
1625         * mi/mi-main.c (mi_async): Likewise.
1626         (mi_async_1): Likewise.
1627         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1628         * nat/fork-inferior.h (startup_with_shell): Likewise.
1629         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1630         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1631         * nios2-tdep.c (nios2_debug): Likewise.
1632         * or1k-tdep.c (or1k_debug): Likewise.
1633         * parse.c (parser_debug): Likewise.
1634         * parser-defs.h (parser_debug): Likewise.
1635         * printcmd.c (print_symbol_filename): Likewise.
1636         * proc-api.c (procfs_trace): Likewise.
1637         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1638         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1639         (set_parameter_value): Update.
1640         (add_setshow_generic): Update.
1641         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1642         to bool*.
1643         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1644         int*.
1645         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1646         * record-btrace.c (record_btrace_target::store_registers): Update.
1647         * record-full.c (record_full_memory_query): Change to bool.
1648         (record_full_stop_at_limit): Likewise.
1649         * record-full.h (record_full_memory_query): Likewise.
1650         * remote-notif.c (notif_debug): Likewise.
1651         * remote-notif.h (notif_debug): Likewise.
1652         * remote.c (use_range_stepping): Likewise.
1653         (interrupt_on_connect): Likewise.
1654         (remote_break): Likewise.
1655         * ser-tcp.c (tcp_auto_retry): Likewise.
1656         * ser-unix.c (serial_hwflow): Likewise.
1657         * skip.c (debug_skip): Likewise.
1658         * solib-aix.c (solib_aix_debug): Likewise.
1659         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1660         (spu_auto_flush_cache_p): Likewise.
1661         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1662         Likewise.
1663         (struct info_print_options) <quiet>: Likewise.
1664         * symfile-debug.c (debug_symfile): Likewise.
1665         * symfile.c (auto_solib_add): Likewise.
1666         (separate_debug_file_debug): Likewise.
1667         * symfile.h (auto_solib_add): Likewise.
1668         (separate_debug_file_debug): Likewise.
1669         * symtab.c (basenames_may_differ): Likewise.
1670         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1671         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1672         (struct info_types_options) <quiet>: Likewise.
1673         * symtab.h (demangle): Likewise.
1674         (basenames_may_differ): Likewise.
1675         * target-dcache.c (stack_cache_enabled_1): Likewise.
1676         (code_cache_enabled_1): Likewise.
1677         * target.c (trust_readonly): Likewise.
1678         (may_write_registers): Likewise.
1679         (may_write_memory): Likewise.
1680         (may_insert_breakpoints): Likewise.
1681         (may_insert_tracepoints): Likewise.
1682         (may_insert_fast_tracepoints): Likewise.
1683         (may_stop): Likewise.
1684         (auto_connect_native_target): Likewise.
1685         (target_stop_and_wait): Update.
1686         (target_async_permitted): Change to bool.
1687         (target_async_permitted_1): Likewise.
1688         (may_write_registers_1): Likewise.
1689         (may_write_memory_1): Likewise.
1690         (may_insert_breakpoints_1): Likewise.
1691         (may_insert_tracepoints_1): Likewise.
1692         (may_insert_fast_tracepoints_1): Likewise.
1693         (may_stop_1): Likewise.
1694         * target.h (target_async_permitted): Likewise.
1695         (may_write_registers): Likewise.
1696         (may_write_memory): Likewise.
1697         (may_insert_breakpoints): Likewise.
1698         (may_insert_tracepoints): Likewise.
1699         (may_insert_fast_tracepoints): Likewise.
1700         (may_stop): Likewise.
1701         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1702         (make_thread_apply_all_options_def_group): Change argument from int*
1703         to bool*.
1704         (thread_apply_all_command): Update.
1705         (print_thread_events): Change to bool.
1706         * top.c (confirm): Likewise.
1707         (command_editing_p): Likewise.
1708         (history_expansion_p): Likewise.
1709         (write_history_p): Likewise.
1710         (info_verbose): Likewise.
1711         * top.h (confirm): Likewise.
1712         (history_expansion_p): Likewise.
1713         * tracepoint.c (disconnected_tracing): Likewise.
1714         (circular_trace_buffer): Likewise.
1715         * typeprint.c (print_methods): Likewise.
1716         (print_typedefs): Likewise.
1717         * utils.c (debug_timestamp): Likewise.
1718         (sevenbit_strings): Likewise.
1719         (pagination_enabled): Likewise.
1720         * utils.h (sevenbit_strings): Likewise.
1721         (pagination_enabled): Likewise.
1722         * valops.c (overload_resolution): Likewise.
1723         * valprint.h (struct value_print_options) <prettyformat_arrays,
1724         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1725         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1726         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1727         Likewise.
1728         * windows-nat.c (new_console): Likewise.
1729         (cygwin_exceptions): Likewise.
1730         (new_group): Likewise.
1731         (debug_exec): Likewise.
1732         (debug_events): Likewise.
1733         (debug_memory): Likewise.
1734         (debug_exceptions): Likewise.
1735         (useshell): Likewise.
1736         * windows-tdep.c (maint_display_all_tib): Likewise.
1737         * xml-support.c (debug_xml): Likewise.
1738
1739 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1740
1741         * source.c (prepare_path_for_appending): New function.
1742         (openp): Make use of new function.
1743         (find_and_open_source): Search for the compilation directory and
1744         source file as a relative path beneath the directory search path.
1745
1746 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1747
1748         * source-cache.c (source_cache::get_line_charpos): Catch
1749         exceptions and return false, this matches the behaviour documented
1750         in the header file.
1751
1752 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1753
1754         * ada-tasks.c (info_task): Remove quoting of the task's name.
1755
1756 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1757
1758         * symfile.c (auto_solib_add): Replace comment with a reference
1759         to the header file.
1760
1761 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1762
1763         * NEWS: Mention that gdb can now be compiled with Python 3
1764         on Windows.
1765
1766 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1767
1768         * maint.c (maint_print_section_data::maint_print_section_data):
1769         Force use of 'float log10 (float)' by casting the argument to
1770         float.
1771
1772 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1773
1774         * maint.c: Add 'cmath' include.
1775         (struct maint_print_section_data): New structure.
1776         (print_section_index): New function.
1777         (print_bfd_section_info): Add header comment, small whitespace
1778         cleanup, and update to call new print_section_index function.
1779         (print_objfile_section_info): Likewise.
1780         (maint_obj_section_from_bfd_section): New function.
1781         (print_bfd_section_info_maybe_relocated): New function.
1782         (maintenance_info_sections): Add header comment, always use
1783         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1784
1785 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1786
1787         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1788         inner scope, add check that the objfile has psymtabs before
1789         checking psymtabs_addrmap.
1790         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1791
1792 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1793
1794         * NEWS: Announce that Ada task names are now shown at more places,
1795         and between quotes (except in info task output).
1796         * gdb/ada-tasks.c (task_to_str): New function.
1797         (display_current_task_id): Call task_to_str.
1798         (task_command_1): Likewise.
1799         (print_ada_task_info): In non-mi mode, Properly align headers and data
1800         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1801
1802 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1803
1804         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1805         prstatus.pr_lwp.pr_info instead of making it up.
1806
1807 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1808
1809         * auto-load.c (auto_load_expand_dir_vars): Update.
1810         * defs.h (gdb_datadir): Change to std::string.
1811         (python_libdir): Likewise.
1812         (relocate_gdb_directory): Change return type to std::string.
1813         * guile/guile.c (gdbscm_data_directory): Update.
1814         (initialize_scheme_side): Update.
1815         * jit.c (jit_reader_dir): Change to std::string.
1816         (jit_reader_load_command): Update.
1817         * main.c (gdb_datadir): Change to std::string.
1818         (python_libdir): Likewise.
1819         (set_gdb_data_directory): Update.
1820         (relocate_path): Change to return std::string.
1821         (relocate_gdb_directory): Change to return std::string.
1822         (relocate_gdbinit_path_maybe_in_datadir): Update.
1823         (captured_main_1): Update.
1824         * python/python.c (do_start_initialization): Update.
1825         * top.c (show_gdb_datadir): Update.
1826         * xml-syscall.c (xml_init_syscalls_info): Update.
1827         (init_syscalls_info): Update.
1828
1829 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1830
1831         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1832         out of get_init_files.
1833         (get_init_files): Update.
1834
1835 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1836
1837         * main.c (get_init_files): Change to use std::string.
1838         (captured_main_1): Update.
1839         (print_gdb_help): Update.
1840
1841 2019-09-11  Ali Tamur  <tamur@google.com>
1842
1843         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1844         implementation.
1845
1846 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1847
1848         * dbxread.c (read_dbx_symtab): Update.
1849         * dwarf2read.c (load_partial_dies): Update.
1850         * mdebugread.c (parse_partial_symbols): Update.
1851         (handle_psymbol_enumerators): Update.
1852         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1853         * psymtab.c (add_psymbol_to_bcache): Likewise.
1854         (add_psymbol_to_list): Likewise.
1855         * symtab.c (symbol_set_names): Likewise.
1856         * symtab.h (symbol_set_names): Likewise.
1857         * xcoffread.c (scan_xcoff_symtab): Update.
1858
1859 2019-09-11  Tom Tromey  <tom@tromey.com>
1860
1861         * symfile-mem.c (symbol_file_add_from_memory): Use
1862         bfd_set_filename.
1863         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1864         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1865
1866 2019-09-10  Tom Tromey  <tromey@adacore.com>
1867
1868         * dwarf-index-write.c (write_psymbols): Extend error message.
1869         (debug_names::insert): Add Ada code.
1870         (debug_names::write_psymbols): Remove Ada check.
1871         (debug_names) <m_string_obstack>: New member.
1872         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1873         (gdb_index_symbol_name_matcher::matches): Remove.
1874         (mapped_index_base::find_name_components_bounds): Add "lang"
1875         parameter.
1876         (mapped_index_base::build_name_components): Also split names
1877         according to Ada syntax.
1878         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1879         type of "match_callback".
1880         (check_match, check_find_bounds_finds)
1881         (dw2_expand_symtabs_matching): Update.
1882         (dw2_debug_names_iterator): Add new constructor.
1883         (dw2_debug_names_map_matching_symbols): New function.
1884         (dw2_debug_names_expand_symtabs_matching): Update.
1885         (dwarf2_debug_names_functions): Use
1886         dw2_debug_names_map_matching_symbols.
1887
1888 2019-09-10  Tom Tromey  <tromey@adacore.com>
1889
1890         * dwarf2read.c (dw2_get_file_names_reader): Add the
1891         CU's file name to the results.
1892
1893 2019-09-10  Tom Tromey  <tromey@adacore.com>
1894
1895         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1896         map_matching_symbols.  Update.
1897         * dwarf2read.c (dw2_map_matching_symbols): Update.
1898         * psymtab.c (match_partial_symbol): Change type; update.
1899         (psym_map_matching_symbols): Likewise.
1900         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1901         type; update.
1902         * symfile.h (struct quick_symbol_functions)
1903         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1904         Remove "match".
1905
1906 2019-09-10  Tom Tromey  <tromey@adacore.com>
1907
1908         * psymtab.c (map_block): Remove.
1909         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1910         * symtab.c (iterate_over_symbols_terminated): New function.
1911         * symtab.c (iterate_over_symbols_terminated): Declare.
1912
1913 2019-09-10  Tom Tromey  <tromey@adacore.com>
1914
1915         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1916         * language.h (struct language_defn) <la_iterate_over_symbols>:
1917         Return bool.
1918         * symtab.c (iterate_over_symbols): Return bool.
1919         * symtab.h (iterate_over_symbols): Return bool.
1920
1921 2019-09-10  Tom Tromey  <tromey@adacore.com>
1922
1923         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1924         (add_nonlocal_symbols): Update.
1925         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1926         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1927         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1928         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1929         Change type of "callback".  Remove "data".
1930
1931
1932 2019-09-09  Ali Tamur  <tamur@google.com>
1933
1934         * dwarf2read.c (comp_unit_head): Update comment.
1935         (dwarf2_dwo_name): New function declaration.
1936         (dwarf_unit_type_name): New function declaration.
1937         (read_comp_unit_head): Add support for new compilation units,
1938         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1939         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1940         (currently named as "signature") in their header. Also clarify error
1941         messages.
1942         (lookup_dwo_id): New function. Returns the dwo id of the given
1943         compile unit.
1944         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1945         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1946         functions.
1947         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1948         (dwarf2_dwo_name): Get the dwo name if present.
1949         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1950         purposes.
1951
1952 2019-09-09  Tom Tromey  <tom@tromey.com>
1953
1954         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1955
1956 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1957
1958         * python/python.c (do_start_initialization): Make progname_copy static,
1959         to avoid a leak report.
1960
1961 2019-09-08  Tom Tromey  <tom@tromey.com>
1962
1963         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1964
1965 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1966
1967         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1968         Change type to gdb::optional<block_enum>.
1969         (dw2_symtab_iter_init): Change block_index parameter type
1970         to gdb::optional<block_enum>.
1971         (dw2_lookup_symbol): Change block_index parameter
1972         type to block_enum.c
1973         (dw2_debug_names_lookup_symbol): Likewise.
1974         * psymtab.c (psym_lookup_symbol): Likewise.
1975         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1976         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1977         Likewise.
1978
1979 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1980
1981         * defs.h (relocate_gdb_directory): Change int to bool in
1982         signature and rename flag to relocatable.
1983         * main.c (relocate_path): Likewise.
1984         (relocate_gdb_directory): Likewise.
1985
1986 2019-09-06  Alan Modra  <amodra@gmail.com>
1987
1988         * coffread.c (coff_symfile_read): Constify filename variable.
1989         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1990         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1991         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1992         * solib.c (reload_shared_libraries_1): Likewise.
1993         * symfile.c (reread_symbols): Likewise.
1994         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1995         * solib-darwin.c (darwin_bfd_open): Likewise.
1996         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1997
1998 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1999
2000         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2001         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2002
2003 2019-09-03  Tom Tromey  <tromey@adacore.com>
2004
2005         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2006         types.
2007         (has_negatives): Unbias a range type bound.
2008         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2009         * gdbtypes.c (operator==): Handle new field.
2010         (create_range_type): Add "bias" parameter.
2011         (create_static_range_type, resolve_dynamic_range): Update.
2012         * gdbtypes.h (struct range_bounds) <bias>: New member.
2013         (create_range_type): Add bias parameter.
2014         * printcmd.c (print_scalar_formatted): Unbias range types.
2015         * value.c (unpack_long): Unbias range types.
2016         (pack_long): Bias range types.
2017
2018 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2019
2020         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2021         probe arguments.
2022
2023 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2024
2025         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2026         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2027         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2028         (compile_probe_arg): Likewise.
2029         * probe.h (get_argument_count): Likewise.
2030         * solib-svr4.c (solib_event_probe_action): Likewise.
2031         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2032
2033 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2034
2035         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2036         code to here...
2037         (svr4_create_solib_event_breakpoints): ...from here.
2038
2039 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2040
2041         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2042         suffix from warning message.
2043
2044 2019-08-30  Tom Tromey  <tom@tromey.com>
2045
2046         * tui/tui-winsource.h (struct tui_source_window_base)
2047         <refresh_all>: Don't declare.
2048         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2049         Remove.
2050         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2051         tui_show_locator_content.
2052         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2053         declare.
2054         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2055         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2056         declare.
2057
2058 2019-08-30  Tom Tromey  <tom@tromey.com>
2059
2060         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2061
2062 2019-08-30  Tom Tromey  <tom@tromey.com>
2063
2064         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2065         Remove unnecessary forward declarations.
2066
2067 2019-08-30  Tom Tromey  <tom@tromey.com>
2068
2069         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2070         rerender.
2071         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2072         tui_show_locator_content.
2073
2074 2019-08-30  Tom Tromey  <tom@tromey.com>
2075
2076         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2077         (tui_locator_window::rerender): Rewrite using body of previous
2078         tui_show_locator_content.
2079
2080 2019-08-30  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2083         set_locator_fullname>: New methods.
2084         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2085         Rename from tui_set_locator_fullname.
2086         (tui_locator_window::set_locator_info): Rename from
2087         tui_set_locator_info.  Return bool.
2088         (tui_update_locator_fullname, tui_show_frame_info): Update.
2089
2090 2019-08-30  Tom Tromey  <tom@tromey.com>
2091
2092         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2093
2094 2019-08-30  Tom Tromey  <tom@tromey.com>
2095
2096         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2097         call touchwin.
2098
2099 2019-08-30  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-wingeneral.c (box_win): Assume win_info and
2102         win_info->handle cannot be NULL.
2103
2104 2019-08-30  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2107         refresh_window>: Declare.
2108         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2109         resize.
2110         (tui_data_item_window::rerender): Rename from
2111         tui_display_register.
2112         (tui_data_item_window::refresh_window): New method.
2113         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2114         no-op.
2115
2116 2019-08-30  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2119         regs_column_count, current_group>: Move later.  Now private.
2120         <get_current_group>: New method.
2121         * tui/tui-regs.c (tui_reg_command): Update.
2122         * tui/tui-layout.c (tui_set_layout): Update.
2123
2124 2019-08-30  Tom Tromey  <tom@tromey.com>
2125
2126         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2127         (tui_data_window::rerender): Don't call
2128         check_and_display_highlight_if_needed.
2129         (tui_data_window::refresh_all): Remove call to
2130         erase_data_content.
2131
2132 2019-08-30  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2135         (tui_data_window::display_registers_from)
2136         (tui_data_window::display_reg_element_at_line)
2137         (tui_data_window::display_registers_from_line): Remove checks of
2138         "empty".
2139
2140 2019-08-30  Tom Tromey  <tom@tromey.com>
2141
2142         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2143         Don't declare.
2144         * tui/tui-regs.c (tui_data_window::show_registers): Call
2145         rerender.
2146         (tui_data_window::rerender): Rename from display_all_data.
2147         (tui_data_window::rerender): Remove old implementation.
2148
2149 2019-08-30  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2152         text.
2153         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2154
2155 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2156             Sergio Durigan Junior  <sergiodj@redhat.com>
2157
2158         PR win32/24284
2159         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2160
2161 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2162
2163         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2164         when searching for types.
2165
2166 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2167
2168         * f-lang.c (f_language_defn): Use f_print_typedef.
2169         * f-lang.h (f_print_typedef): Declare.
2170         * f-typeprint.c (f_print_typedef): Define.
2171
2172 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2173
2174         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2175
2176 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2177
2178         * cli/cli-utils.c (info_print_options_defs): Delete.
2179         (make_info_print_options_def_group): Delete.
2180         (extract_info_print_options): Delete.
2181         (info_print_command_completer): Delete.
2182         (info_print_args_help): Add extra parameter, and optionally
2183         include text about -n flag.
2184         * cli/cli-utils.h (struct info_print_options): Delete.
2185         (extract_info_print_options): Delete declaration.
2186         (info_print_command_completer): Delete declaration.
2187         (info_print_args_help): Add extra parameter, extend header
2188         comment.
2189         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2190         search_symbols.
2191         * stack.c (struct info_print_options): New type.
2192         (info_print_options_defs): New file scoped variable.
2193         (make_info_print_options_def_group): New static function.
2194         (info_print_command_completer): New static function.
2195         (info_locals_command): Update to use new local functions.
2196         (info_args_command): Likewise.
2197         (_initialize_stack): Add extra parameter to calls to
2198         info_print_args_help.
2199         * symtab.c (search_symbols): Add extra parameter, use this to
2200         possibly excluse non-debug symbols.
2201         (symtab_symbol_info): Add extra parameter, which is passed on to
2202         search_symbols.
2203         (struct info_print_options): New type.
2204         (info_print_options_defs): New file scoped variable.
2205         (make_info_print_options_def_group): New static function.
2206         (info_print_command_completer): New static function.
2207         (info_variables_command): Update to use local functions, and pass
2208         extra parameter through to symtab_symbol_info.
2209         (info_functions_command): Likewise.
2210         (info_types_command): Pass additional argument through to
2211         symtab_symbol_info.
2212         (rbreak_command): Pass extra argument to search_symbols.
2213         (_initialize_symtab): Add extra arguments for calls to
2214         info_print_args_help, and update help text for 'info variables',
2215         'whereis', and 'info functions' commands.
2216         * symtab.h (search_symbols): Add extra argument to declaration.
2217         * NEWS: Mention new flags.
2218
2219 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2220
2221         * symtab.c (lookup_static_symbol): Call the new function (and move
2222         it down to be next to lookup_global_symbol).
2223         (struct global_sym_lookup_data): Add block_enum member and rename to...
2224         (struct global_or_static_sym_lookup_data): ...this.
2225         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2226         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2227         (lookup_symbol_global_or_static_iterator_cb): ...this.
2228         (lookup_global_or_static_symbol): New function.
2229         (lookup_global_symbol): Call new function.
2230
2231 2019-08-26  Tom de Vries  <tdevries@suse.de>
2232
2233         PR c++/24852
2234         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2235         when pc_probe.prob == NULL.
2236
2237 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2238
2239         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2240         variable symbol_linkage to symbol_linkage_.
2241
2242 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2243
2244         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2245         represent whether the symbol is static, dynamic, or we don't
2246         know.
2247
2248 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2249
2250         * gdb/rx-tdep.c (rx_register_names): New.
2251         (rx_register_name): Delete.
2252         (rx_psw_type): Delete.
2253         (rx_fpsw_type): Delete.
2254         (rx_register_type): Delete.
2255         (rx_gdbarch_init): Convert target-descriptions.
2256         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2257         * gdb/features/Makefile: Add rx.xml.
2258         * gdb/features/rx.xml: New.
2259         * gdb/features/rx.c: Generated.
2260         * gdb/NEWS: Mention target description support.
2261
2262 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2263
2264         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2265         *slot_ptr.
2266
2267 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2268
2269         * configure.ac: Don't check for 'dlfcn.h' (moved to
2270         gdbsupport/common.m4).
2271         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2272         'gdbsupport/'.
2273         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2274         * compile/compile-c-support.c: Include
2275         'gdbsupport/gdb-dlfcn.h'.
2276         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2277         * gdb-dlfcn.c: Move to...
2278         * gdbsupport/gdb-dlfcn.c: ... here.
2279         * gdb-dlfcn.h: Move to...
2280         * gdbsupport/gdb-dlfcn.h: ... here.
2281
2282 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2283
2284         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2285         the offset field signed.
2286
2287 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2288
2289         * python/lib/gdb/__init__.py (_execute_file): New function.
2290         * python/python.c (python_run_simple_file): Call gdb._execute_file
2291         on Windows.
2292
2293 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2294
2295         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2296         all uses as this was never set to anything but a zero value.
2297
2298 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2299
2300         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2301
2302 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2303
2304         * tui/tui-data.h (tui_gen_win_info): Add an =default
2305         move constructor, required by some GCC versions.
2306
2307 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2308
2309         * go32-nat.c (go32_sysinfo): Add hygon_p.
2310
2311 2019-08-20  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2314         line_from_reg_element_no, first_reg_element_no_inline,
2315         display_all_data, delete_data_content_windows,
2316         erase_data_content>: Now private.
2317
2318 2019-08-20  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2321         (tui_unhighlight_win, tui_highlight_win)
2322         (tui_win_info::make_window): Update.
2323         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2324
2325 2019-08-20  Tom Tromey  <tom@tromey.com>
2326
2327         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2328         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2329         (MAX_PID_WIDTH): Move to tui-stack.c.
2330         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2331         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2332         (MAX_PID_WIDTH): Move from tui-data.h.
2333
2334 2019-08-20  Tom Tromey  <tom@tromey.com>
2335
2336         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2337         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2338         (box_win): Update.
2339         (tui_gen_win_info::make_window): Rename from tui_make_window.
2340         (tui_win_info::make_window): New method.
2341         (tui_gen_win_info::make_visible): Update.
2342         * tui/tui-source.c (tui_source_window::set_contents): Update.
2343         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2344         (tui_data_window::display_registers_from): Update.
2345         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2346         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2347         Declare.
2348         <can_box>: Remove.
2349         <title>: Remove.
2350         (struct tui_win_info) <make_window>: Declare.
2351         <can_box>: Now virtual.
2352         <title>: New member.
2353         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2354         * tui/tui-command.c (tui_cmd_window::resize): Update.
2355
2356 2019-08-20  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2359         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2360         (tui_data_window::check_register_values): Update.
2361
2362 2019-08-20  Tom Tromey  <tom@tromey.com>
2363
2364         * tui/tui-regs.h (struct tui_data_window): Use
2365         DISABLE_COPY_AND_ASSIGN.
2366         <regs_content>: Change type, removing unique_ptr.
2367         <tui_data_window>: Add move constructor.
2368         * tui/tui-regs.c (tui_data_window::show_registers)
2369         (tui_data_window::show_register_group)
2370         (tui_data_window::display_registers_from)
2371         (tui_data_window::display_registers_from)
2372         (tui_data_window::first_data_item_displayed)
2373         (tui_data_window::delete_data_content_windows)
2374         (tui_data_window::rerender, tui_data_window::refresh_window)
2375         (tui_data_window::check_register_values): Update.
2376
2377 2019-08-20  Tom Tromey  <tom@tromey.com>
2378
2379         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2380         show_register_group>: Declare.
2381         (tui_show_register_group): Don't declare.
2382         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2383         tui_show_registers.
2384         (tui_data_window::show_register_group): Rename from
2385         tui_show_register_group.
2386         (tui_data_window::check_register_values, tui_reg_command):
2387         Update.
2388         * tui/tui-layout.c (tui_set_layout): Update.
2389
2390 2019-08-20  Tom Tromey  <tom@tromey.com>
2391
2392         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2393         Declare.
2394         (tui_check_register_values): Don't declare.
2395         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2396         from tui_check_register_values.
2397         * tui/tui-hooks.c (tui_register_changed): Update.
2398
2399 2019-08-20  Tom Tromey  <tom@tromey.com>
2400
2401         * tui/tui-regs.c (tui_reg_layout): Move later.
2402         (tui_show_registers): Don't enable TUI mode or change layout.
2403
2404 2019-08-20  Tom Tromey  <tom@tromey.com>
2405
2406         * tui/tui-regs.h (struct tui_data_item_window)
2407         <~tui_data_item_window>: Remove.
2408         <content>: Now a unique_xmalloc_ptr.
2409         * tui/tui-regs.c (tui_register_format): Return a
2410         unique_xmalloc_ptr.
2411         (tui_get_register): Update.
2412         (~tui_data_item_window): Remove.
2413         (tui_data_window::display_registers_from, tui_display_register):
2414         Update.
2415         * tui/tui-io.h (tui_expand_tabs): Update.
2416         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2417         Remove "col" parameter.
2418
2419 2019-08-20  Tom Tromey  <tom@tromey.com>
2420
2421         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2422         field.
2423         * tui/tui-regs.c (~tui_data_item_window): Update.
2424
2425 2019-08-20  Tom Tromey  <tom@tromey.com>
2426
2427         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2428         earlier.
2429
2430 2019-08-20  Tom Tromey  <tom@tromey.com>
2431
2432         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2433
2434 2019-08-20  Tom Tromey  <tom@tromey.com>
2435
2436         * tui/tui-source.h (struct tui_source_window): Update.
2437         * tui/tui-regs.c (tui_show_registers): Update.
2438         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2439         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2440         (NO_REGS_STRING): Remove defines.
2441
2442 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2443
2444         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2445         unnecessary thread walk if remote doesn't support the packet.
2446
2447 2019-08-19  Tom Tromey  <tromey@adacore.com>
2448
2449         * python/py-value.c (value_has_field): Fix indentation.
2450
2451 2019-08-19  Tom Tromey  <tromey@adacore.com>
2452
2453         * printcmd.c (do_one_display, info_display_command): Update.
2454         * block.h (contained_in): Return bool.  Add allow_nested
2455         parameter.
2456         * block.c (contained_in): Return bool.  Add allow_nested
2457         parameter.
2458
2459 2019-08-19  Tom Tromey  <tom@tromey.com>
2460
2461         * configure: Rebuild.
2462         * configure.ac: Disallow the combination of -static-libstdc++ and
2463         source highlight.
2464         * source-cache.c (get_language_name): Handle rust.
2465         (source_cache::get_source_lines): Ignore highlighting exceptions.
2466
2467 2019-08-16  Tom Tromey  <tom@tromey.com>
2468
2469         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2470         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2471         (struct tui_source_window_base) <make_visible, refresh_window,
2472         resize>: Remove methods.
2473         <execution_info>: Remove field.
2474         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2475         (tui_show_source_line, tui_source_window_base)
2476         (~tui_source_window_base): Update.
2477         (tui_source_window_base::resize)
2478         (tui_source_window_base::make_visible)
2479         (tui_source_window_base::refresh_window): Remove.
2480         (tui_source_window_base::update_exec_info): Update.
2481         * tui/tui-source.c (tui_source_window::set_contents): Update.
2482         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2483
2484 2019-08-16  Tom Tromey  <tom@tromey.com>
2485
2486         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2487         deprecated_query_hook.
2488
2489 2019-08-16  Tom Tromey  <tom@tromey.com>
2490
2491         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2492         (tui_update_source_windows_with_line): Update.
2493         * tui/tui-source.h (struct tui_source_window)
2494         <show_symtab_source>: Declare.
2495         (tui_show_symtab_source): Don't declare.
2496         * tui/tui-source.c (tui_show_symtab_source): Rename from
2497         tui_show_symtab_source.
2498
2499 2019-08-16  Tom Tromey  <tom@tromey.com>
2500
2501         * tui/tui-winsource.h (struct tui_source_window_base)
2502         <set_contents>: Declare.
2503         * tui/tui-winsource.c
2504         (tui_source_window_base::update_source_window_as_is): Update.
2505         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2506         Declare.
2507         (tui_set_source_content): Don't declare.
2508         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2509         tui_set_source_content.
2510         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2511         Declare.
2512         (tui_set_disassem_content): Don't declare.
2513         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2514         tui_set_disassem_content.
2515
2516 2019-08-16  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-winsource.h (struct tui_source_window_base)
2519         <update_breakpoint_info>: Declare.
2520         (tui_update_breakpoint_info): Don't declare.
2521         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2522         (tui_update_all_breakpoint_info): Update.
2523         (tui_source_window_base::update_breakpoint_info): Rename from
2524         tui_update_breakpoint_info.
2525         (tui_source_window_base::update_exec_info): Update.
2526
2527 2019-08-16  Tom Tromey  <tom@tromey.com>
2528
2529         * tui/tui-winsource.h (struct tui_source_window_base)
2530         <update_source_window>: Declare.
2531         (tui_update_source_window): Don't declare.
2532         * tui/tui-winsource.c
2533         (tui_source_window_base::update_source_window): Rename from
2534         tui_update_source_window.
2535         (tui_source_window_base::rerender): Update.
2536         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2537         * tui/tui-disasm.c (tui_show_disassem)
2538         (tui_show_disassem_and_update_source)
2539         (tui_disasm_window::maybe_update): Update.
2540
2541 2019-08-16  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-winsource.h (struct tui_source_window_base)
2544         <update_source_window_as_is>: Declare.
2545         (tui_update_source_window_as_is): Don't declare.
2546         * tui/tui-winsource.c (tui_update_source_window): Update
2547         (tui_source_window_base::update_source_window_as_is): Rename from
2548         tui_update_source_window_as_is.
2549         (tui_source_window_base::refill): Update.
2550         * tui/tui-source.c (tui_show_symtab_source): Update.
2551         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2552         Update.
2553
2554 2019-08-16  Tom Tromey  <tom@tromey.com>
2555
2556         * tui/tui-winsource.h (tui_update_source_window)
2557         (tui_update_source_window_as_is): Remove "noerror" parameter.
2558         * tui/tui-winsource.c (tui_update_source_window)
2559         (tui_update_source_window_as_is): Remove "noerror" parameter.
2560         (tui_update_source_windows_with_addr)
2561         (tui_update_source_windows_with_line)
2562         (tui_source_window_base::rerender)
2563         (tui_source_window_base::refill): Update.
2564         * tui/tui-source.h (tui_set_source_content)
2565         (tui_show_symtab_source): Remove "noerror" parameter.
2566         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2567         parameter.
2568         (tui_show_symtab_source): Likewise.
2569         (tui_source_window::maybe_update): Update.
2570         * tui/tui-disasm.c (tui_show_disassem)
2571         (tui_show_disassem_and_update_source)
2572         (tui_disasm_window::do_scroll_vertical)
2573         (tui_disasm_window::maybe_update): Update.
2574
2575 2019-08-16  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui.c (tui_is_window_visible): Update.
2578         * tui/tui-wingeneral.c (tui_make_window)
2579         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2580         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2581         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2582         (tui_set_win_height_command, parse_scrolling_args): Update.
2583         * tui/tui-source.c (tui_source_window::style_changed): Update.
2584         * tui/tui-regs.c (tui_show_registers)
2585         (tui_data_window::first_data_item_displayed)
2586         (tui_data_window::delete_data_content_windows)
2587         (tui_check_register_values, tui_reg_command): Update.
2588         * tui/tui-disasm.c (tui_show_disassem): Update.
2589         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2590         method.
2591         <is_visible>: Remove field.
2592         * tui/tui-data.c (tui_next_win, tui_prev_win)
2593         (tui_delete_invisible_windows): Update.
2594
2595 2019-08-16  Tom Tromey  <tom@tromey.com>
2596
2597         * tui/tui-winsource.h (struct tui_source_window_base)
2598         <m_has_locator>: Remove.
2599         * tui/tui-layout.c (show_source_disasm_command, show_data)
2600         (show_source_or_disasm_and_command): Update.
2601
2602 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2603
2604         * NEWS (Other MI changes): New subsection.
2605         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2606         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2607         * arch-utils.c (default_get_pc_address_flags): New function.
2608         * arch-utils.h (default_get_pc_address_flags): New declaration.
2609         * gdbarch.sh: Add get_pc_address_flags.
2610         * gdbarch.c: Regenerate.
2611         * gdbarch.h: Likewise.
2612         * stack.c (print_pc): New function.
2613         (print_frame_info) (print_frame): Call print_pc.
2614
2615 2019-08-16  Tom de Vries  <tdevries@suse.de>
2616
2617         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2618         print_objfile_section_info.
2619
2620 2019-08-15  Tom Tromey  <tom@tromey.com>
2621
2622         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2623         calling update_cmdwin_start_line.
2624         * tui/tui-winsource.h (struct tui_source_window_base)
2625         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2626         <rerender>: Declare.
2627         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2628         Call rerender.
2629         (tui_source_window_base::set_new_height): Remove.
2630         (tui_source_window_base::rerender): Rename from
2631         do_make_visible_with_new_height.
2632         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2633         resize method.
2634         (tui_win_info::make_invisible_and_set_new_height)
2635         (tui_win_info::make_visible_with_new_height): Remove.
2636         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2637         Declare.
2638         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2639         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2640         do_make_visible_with_new_height>: Don't declare.
2641         <rerender>: Declare.
2642         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2643         set_new_height.
2644         (tui_data_window::do_make_visible_with_new_height): Remove.
2645         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2646         call tui_show_locator_content.
2647         (tui_gen_win_info::resize): Call rerender.
2648         (show_source_or_disasm_and_command): Don't call
2649         tui_show_locator_content.
2650         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2651         method.
2652         (struct tui_win_info) <rerender>: Declare.
2653         <set_new_height, make_invisible_and_set_new_height,
2654         make_visible_with_new_height>: Don't declare.
2655         * tui/tui-data.c (tui_win_list::rerender): New method.
2656         * tui/tui-command.h (struct tui_cmd_window)
2657         <do_make_visible_with_new_height>: Don't declare.
2658         * tui/tui-command.c
2659         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2660
2661 2019-08-15  Tom Tromey  <tromey@adacore.com>
2662
2663         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2664         * ada-lang.c (ada_enum_name): Likewise.
2665
2666 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2667
2668         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2669         leading underscore.
2670         (GdbOutputErrorFile): Likewise.
2671         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2672         accordingly.
2673         (execute_unwinders): Rename to have a leading underscore.
2674         (auto_load_packages): Likewise.
2675         (global scope): Adjust call to auto_load_packages accordingly.
2676         (GdbSetPythonDirectory): Likewise.
2677         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2678         instead of execute_unwinders.
2679
2680 2019-08-15  Tom Tromey  <tom@tromey.com>
2681
2682         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2683         (show_data): Don't change window visibility.
2684         (tui_gen_win_info::resize): Remove special case for command
2685         window.  Use wresize, when available.
2686         (show_source_or_disasm_and_command): Don't change window
2687         visibility.
2688         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2689         <make_visible>: New method.
2690         * tui/tui-command.c (tui_cmd_window::resize): New method.
2691
2692 2019-08-15  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2695         (struct tui_source_windows): New.
2696         * tui/tui-winsource.c (tui_display_main): Update.
2697         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2698         (new_height_ok, parse_scrolling_args): Update.
2699         * tui/tui-layout.c (show_layout, show_data): Update.
2700         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2701         (tui_add_to_source_windows): Don't declare.
2702         * tui/tui-data.c (source_windows, tui_source_windows)
2703         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2704
2705 2019-08-15  Tom Tromey  <tom@tromey.com>
2706
2707         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2708         Rename from reset.
2709         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2710         * tui/tui-layout.c (show_source_disasm_command, show_data):
2711         Update.
2712         (tui_gen_win_info::resize): Rename.
2713         (show_source_or_disasm_and_command): Update.
2714         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2715         reset.
2716
2717 2019-08-15  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2720         * tui/tui-interp.c (tui_interp::init): Don't call
2721         tui_initialize_static_data.
2722         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2723
2724 2019-08-15  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2727         examine tui_win_list.
2728
2729 2019-08-15  Tom Tromey  <tom@tromey.com>
2730
2731         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2732         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2733         tui_clear_source_content.
2734         (tui_clear_source_content): Remove.
2735         (tui_source_window_base::do_erase_source_content): Hoist call to
2736         content.clear().
2737         * tui/tui-stack.c (tui_show_frame_info): Don't call
2738         tui_clear_source_content.
2739
2740 2019-08-15  Tom Tromey  <tom@tromey.com>
2741
2742         * tui/tui-winsource.h (struct tui_source_window_base)
2743         <do_erase_source_content>: New method.
2744         <erase_source_content>: New method.
2745         (tui_erase_source_content): Don't declare.
2746         * tui/tui-winsource.c (tui_clear_source_content): Update.
2747         (tui_source_window_base::do_erase_source_content): Rename from
2748         tui_erase_source_content.
2749         (tui_source_window_base::show_source_content): Update.
2750         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2751         * tui/tui-source.h (struct tui_source_window)
2752         <erase_source_content>: New method.
2753         * tui/tui-disasm.h (struct tui_disasm_window)
2754         <erase_source_content>: New method.
2755
2756 2019-08-15  Tom Tromey  <tom@tromey.com>
2757
2758         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2759         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2760         constructor.
2761         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2762         * tui/tui-source.c (tui_set_source_content): Update.
2763         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2764
2765 2019-08-15  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2768         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2769         tui-source.c.
2770         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2771         Declare.
2772         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2773         method.
2774         (tui_source_window::maybe_update): Update.
2775
2776 2019-08-15  Tom Tromey  <tom@tromey.com>
2777
2778         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2779         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2780         tui-disasm.c.
2781         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2782         Declare.
2783         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2784         method.
2785         (tui_disasm_window::maybe_update): Update.
2786
2787 2019-08-15  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-winsource.h (struct tui_source_window_base)
2790         <maybe_update>: Declare.
2791         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2792         method.
2793         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2794         Declare.
2795         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2796         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2797         Declare.
2798         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2799
2800 2019-08-15  Tom Tromey  <tom@tromey.com>
2801
2802         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2803
2804 2019-08-15  Tom Tromey  <tom@tromey.com>
2805
2806         * tui/tui-wingeneral.c: Include tui-stack.h.
2807         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2808         (struct tui_locator_window): Move from tui-data.h.
2809         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2810         (tui_initialize_static_data): Move from tui-data.c.
2811         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2812         (struct tui_locator_window): Move to tui-stack.c.
2813         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2814         (tui_initialize_static_data): Move to tui-stack.c.
2815
2816 2019-08-15  Tom Tromey  <tom@tromey.com>
2817
2818         * tui/tui-layout.c (show_source_disasm_command)
2819         (show_source_or_disasm_and_command): Use make_visible method, not
2820         tui_make_window.
2821         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2822         Remove.
2823
2824 2019-08-15  Tom Tromey  <tom@tromey.com>
2825
2826         * tui/tui-wingeneral.h (tui_make_window): Update.
2827         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2828         parameter.
2829         (tui_gen_win_info::make_visible): Update.
2830         * tui/tui-regs.c (tui_data_window::display_registers_from):
2831         Update.
2832         * tui/tui-layout.c (show_source_disasm_command)
2833         (show_source_or_disasm_and_command): Update.
2834         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2835         (enum tui_box): Remove.
2836         (struct tui_win_info) <can_box>: New method.
2837         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2838         method.
2839
2840 2019-08-15  Tom de Vries  <tdevries@suse.de>
2841
2842         * linux-nat-trad.c: Include gdbarch.h.
2843
2844 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2845
2846         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2847         register sizes.
2848
2849 2019-08-14  Tom Tromey  <tromey@adacore.com>
2850
2851         * darwin-nat.c: Include gdbarch.h.
2852         * darwin-nat-info.c: Include gdbarch.h.
2853
2854 2019-08-13  Tom Tromey  <tom@tromey.com>
2855
2856         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2857         Remove.
2858         * tui/tui-data.c (tui_initialize_static_data): Update.
2859
2860 2019-08-13  Tom Tromey  <tom@tromey.com>
2861
2862         * tui/tui-winsource.h (struct tui_exec_info_window)
2863         <~tui_exec_info_window, maybe_allocate_content, get_content,
2864         m_content>: Remove.
2865         (struct tui_source_window_base) <set_exec_info_content,
2866         show_exec_info_content>: Don't declare.
2867         * tui/tui-winsource.c
2868         (tui_exec_info_window::maybe_allocate_content): Remove.
2869         (tui_source_window_base::update_exec_info): Rename from
2870         set_exec_info_content.
2871         (tui_source_window_base::show_exec_info_content)
2872         (tui_source_window_base::update_exec_info): Remove.
2873
2874 2019-08-13  Tom Tromey  <tom@tromey.com>
2875
2876         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2877         declare.
2878         * tui/tui-winsource.c (tui_update_source_window_as_is)
2879         (tui_update_source_windows_with_addr, tui_erase_source_content):
2880         Update.
2881         (tui_clear_exec_info_content): Remove.
2882
2883 2019-08-13  Tom Tromey  <tom@tromey.com>
2884
2885         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2886         declare.
2887         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2888         call tui_erase_exec_info_content.
2889         (tui_clear_exec_info_content): Rename from
2890         tui_erase_exec_info_content.
2891         (tui_clear_exec_info_content): Delete.
2892
2893 2019-08-13  Tom Tromey  <tom@tromey.com>
2894
2895         * tui/tui-winsource.h (struct tui_source_window_base)
2896         <show_exec_info_content>: Declare.
2897         (tui_show_exec_info_content): Don't declare.
2898         * tui/tui-winsource.c
2899         (tui_source_window_base::show_exec_info_content): Rename from
2900         tui_show_exec_info_content.
2901         (tui_source_window_base::update_exec_info): Update.
2902
2903 2019-08-13  Tom Tromey  <tom@tromey.com>
2904
2905         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2906         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2907         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2908         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2909         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2910         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2911         ... here.
2912
2913 2019-08-13  Tom Tromey  <tom@tromey.com>
2914
2915         * tui/tui-winsource.h (struct tui_source_window_base)
2916         <update_exec_info>: Declare.
2917         (tui_update_exec_info): Don't declare.
2918         * tui/tui-winsource.c (tui_update_source_window_as_is)
2919         (tui_source_window_base::refresh_all)
2920         (tui_update_all_breakpoint_info): Update.
2921         (tui_source_window_base::update_exec_info): Rename from
2922         tui_update_exec_info.
2923         * tui/tui-stack.c (tui_show_frame_info): Update.
2924
2925 2019-08-13  Tom Tromey  <tom@tromey.com>
2926
2927         * tui/tui-winsource.h (struct tui_source_window_base)
2928         <set_exec_info_content>: Declare.
2929         (tui_set_exec_info_content): Don't declare.
2930         * tui/tui-winsource.c
2931         (tui_source_window_base::set_exec_info_content): Rename from
2932         tui_set_exec_info_content.
2933         (tui_update_exec_info): Update.
2934
2935 2019-08-13  Tom Tromey  <tom@tromey.com>
2936
2937         * tui/tui-winsource.h (struct tui_source_window_base)
2938         <show_source_content>: Declare.
2939         (tui_show_source_content): Don't declare.
2940         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2941         (tui_source_window_base::show_source_content): Rename from
2942         tui_show_source_content.
2943         (tui_source_window_base::refresh_all): Update.
2944         * tui/tui-layout.c (show_source_disasm_command)
2945         (show_source_or_disasm_and_command): Update.
2946
2947 2019-08-13  Tom Tromey  <tom@tromey.com>
2948
2949         * tui/tui-winsource.c (tui_erase_source_content)
2950         (tui_show_source_content, tui_source_window_base::refresh_all):
2951         Update.
2952         * tui/tui-wingeneral.h
2953         (tui_check_and_display_highlight_if_needed): Don't declare.
2954         * tui/tui-wingeneral.c
2955         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2956         check_and_display_highlight_if_needed.
2957         * tui/tui-win.c (tui_rehighlight_all)
2958         (tui_win_info::make_visible_with_new_height): Update.
2959         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2960         (tui_data_window::erase_data_content)
2961         (tui_data_window::display_all_data): Update.
2962         * tui/tui-data.h (struct tui_win_info)
2963         <check_and_display_highlight_if_needed>: Declare.
2964
2965 2019-08-13  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-win.c (tui_resize_all): Call
2968         tui_delete_invisible_windows.
2969         * tui/tui-layout.c (show_layout): Call
2970         tui_delete_invisible_windows.
2971         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2972         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2973
2974 2019-08-13  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2977         tui_add_win_to_layout.
2978
2979 2019-08-13  Tom Tromey  <tom@tromey.com>
2980
2981         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2982         * tui/tui-layout.c (tui_default_win_height): Now static.
2983
2984 2019-08-13  Tom Tromey  <tom@tromey.com>
2985
2986         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2987         single switch.
2988         (show_source_disasm_command, show_source_or_disasm_and_command):
2989         Don't check current layout.
2990
2991 2019-08-13  Tom Tromey  <tom@tromey.com>
2992
2993         * tui/tui-wingeneral.c (make_all_visible): Remove.
2994         (tui_make_all_invisible): Simplify.
2995         * tui/tui-layout.c (tui_make_all_invisible): Move from
2996         tui-wingeneral.c; simplify.
2997         (show_layout): Hoist call to tui_make_all_invisible.
2998         (show_data): Don't call tui_make_all_invisible.
2999
3000 2019-08-13  Tom Tromey  <tom@tromey.com>
3001
3002         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3003         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3004
3005 2019-08-13  Tom Tromey  <tom@tromey.com>
3006
3007         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3008         tui-data.c.
3009         (show_source_disasm_command, show_data)
3010         (show_source_or_disasm_and_command): Don't use
3011         tui_set_current_layout_to.
3012         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3013         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3014         tui-layout.c.
3015         (tui_set_current_layout_to): Remove.
3016
3017 2019-08-13  Tom Tromey  <tom@tromey.com>
3018
3019         * tui/tui-layout.c (tui_set_layout): Update.
3020         * tui/tui-data.h (struct tui_layout_def): Remove.
3021         (tui_layout_def): Don't declare.
3022         * tui/tui-data.c (layout_def): Remove.
3023         (tui_layout_def): Remove.
3024
3025 2019-08-13  Tom Tromey  <tom@tromey.com>
3026
3027         * tui/tui-winsource.h (struct tui_source_window_base)
3028         <clear_detail>: No longer "override".
3029         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3030         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3031         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3032         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3033         Remove.
3034         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3035
3036 2019-08-13  Tom Tromey  <tromey@adacore.com>
3037
3038         * tracepoint.c: Don't include readline.h or history.h.
3039
3040 2019-08-12  Tom Tromey  <tom@tromey.com>
3041
3042         * configure: Rebuild.
3043         * configure.ac: Check for readline 7.
3044         * NEWS: Mention readline 7 requirement.
3045         * README: Update.
3046
3047 2019-08-12  Tom Tromey  <tom@tromey.com>
3048
3049         * mingw-hdep.c (gdb_select): Remove readline hack.
3050
3051 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3052
3053         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3054         when the function fails.
3055
3056 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3057
3058         * s390-tdep.c (s390_type_align): New function.
3059         (s390_gdbarch_init): Set it as type_align gdbarch method.
3060
3061 2019-08-09  Tom de Vries  <tdevries@suse.de>
3062
3063         PR gdb/24591
3064         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3065         pc_low with relocation offset.
3066
3067 2019-08-07  Tom Tromey  <tromey@adacore.com>
3068
3069         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3070         (print_frame_args): Update.
3071         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3072         Update.
3073         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3074         * frame.h (struct frame_arg): Add initializers.
3075         <error>: Now a unique_xmalloc_ptr.
3076
3077 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3078
3079         * NEWS: Expand the Pointer Authentication entry.
3080         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3081         (aarch64_frame_unmask_lr): ... to this.
3082         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3083         Call aarch64_frame_unmask_lr.
3084         * frame.c (struct frame_info): Add "masked" variable.
3085         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3086         (fprint_frame): Check for masked pc.
3087         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3088         declarations.
3089         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3090         * stack.c (print_frame): Check for masked pc.
3091
3092 2019-08-06  Tom Tromey  <tom@tromey.com>
3093
3094         * stabsread.c (patch_block_stabs, read_one_struct_field)
3095         (read_enum_type): Use obstack_strndup.
3096         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3097         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3098         * dwarf2read.c (guess_full_die_structure_name)
3099         (anonymous_struct_prefix): Use obstack_strndup.
3100         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3101         * c-exp.y (yylex): Use obstack_strndup.
3102         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3103         (write_var_or_type): Use obstack_strndup.
3104
3105 2019-08-06  Tom Tromey  <tom@tromey.com>
3106
3107         * symfile.c (reread_symbols): Use obstack_strdup.
3108         * stabsread.c (read_type): Use obstack_strdup.
3109         * gdb_obstack.h (obstack_strdup): New overload.
3110         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3111         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3112         (dwarf2_canonicalize_name): Use obstack_strdup.
3113         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3114         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3115         Use obstack_strdup.
3116
3117 2019-08-06  Tom Tromey  <tom@tromey.com>
3118
3119         * gdb_obstack.h (obstack_strdup): Define.
3120         * gdb_obstack.c (obstack_strdup): Don't define.
3121
3122 2019-08-06  Tom Tromey  <tom@tromey.com>
3123
3124         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3125         obstack_strdup.
3126         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3127         obstack_strdup.
3128         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3129         * stabsread.c (common_block_start): Use obstack_strdup.
3130         * objfiles.c (set_objfile_main_name, objfile): Use
3131         obstack_strdup.
3132         * namespace.c (add_using_directive): Use obstack_strdup.
3133         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3134         * jit.c (finalize_symtab): Use obstack_strdup.
3135         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3136         (guess_partial_die_structure_name, partial_die_info::fixup)
3137         (dwarf2_name): Use obstack_strdup.
3138         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3139         obstack_strdup.
3140         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3141         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3142         obstack_strdup.
3143         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3144
3145 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3146
3147         * unittests/help-doc-selftests.c: New file.
3148         * Makefile.in: Add the new file.
3149
3150 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3151
3152         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3153         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3154         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3155         the trailing '.' is not output, and the first character is uppercased.
3156         (print_help_for_command): Update call to print_doc_line.
3157         (print_doc_of_command): Likewise.
3158         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3159         * cli/cli-option.c (append_indented_doc): Do not append newline.
3160         (build_help_option): Append newline after first appended_indented_doc
3161         only if a second call is done.
3162         (build_help): Append 2 new lines before each option, except the first
3163         one.
3164         * compile/compile.c (_initialize_compile): Add new lines after
3165         %OPTIONS%, when not at the end of the help.
3166         Change help doc or code
3167         producing the help doc to respect the invariants.
3168         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3169         Also removed the new line after 'Options:', as all other commands
3170         do not put an empty line between 'Options:' and the first option.
3171         * printcmd.c (_initialize_printcmd): Likewise.
3172         * stack.c (_initialize_stack): Likewise.
3173         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3174         incorrectly telling COMMAND is optional.
3175         * ada-lang.c (_initialize_ada_language): Change help doc or code
3176         producing the help doc to respect the invariants.
3177         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3178         * breakpoint.c (_initialize_breakpoint): Likewise.
3179         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3180         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3181         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3182         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3183         _initialize_cli_style): Likewise.
3184         * corelow.c (core_target_info): Likewise.
3185         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3186         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3187         * filesystem.c (_initialize_filesystem): Likewise.
3188         * frame.c (_initialize_frame): Likewise.
3189         * gnu-nat.c (add_task_commands): Likewise.
3190         * infcall.c (_initialize_infcall): Likewise.
3191         * infcmd.c (_initialize_infcmd): Likewise.
3192         * interps.c (_initialize_interpreter): Likewise.
3193         * language.c (_initialize_language): Likewise.
3194         * linux-fork.c (_initialize_linux_fork): Likewise.
3195         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3196         * maint.c (_initialize_maint_cmds): Likewise.
3197         * memattr.c (_initialize_mem): Likewise.
3198         * printcmd.c (_initialize_printcmd): Likewise.
3199         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3200         _RegEx): Likewise.
3201         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3202         * record-btrace.c (_initialize_record_btrace): Likewise.
3203         * record-full.c (_initialize_record_full): Likewise.
3204         * record.c (_initialize_record): Likewise.
3205         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3206         * regcache.c (_initialize_regcache): Likewise.
3207         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3208         _initialize_remote): Likewise.
3209         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3210         * serial.c (_initialize_serial): Likewise.
3211         * skip.c (_initialize_step_skip): Likewise.
3212         * source.c (_initialize_source): Likewise.
3213         * stack.c (_initialize_stack): Likewise.
3214         * symfile.c (_initialize_symfile): Likewise.
3215         * symtab.c (_initialize_symtab): Likewise.
3216         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3217         * top.c (init_main): Likewise.
3218         * tracefile-tfile.c (tfile_target_info): Likewise.
3219         * tracepoint.c (_initialize_tracepoint): Likewise.
3220         * tui/tui-win.c (_initialize_tui_win): Likewise.
3221         * utils.c (add_internal_problem_command): Likewise.
3222         * valprint.c (value_print_option_defs): Likewise.
3223
3224 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3225
3226         PR build/24886
3227         * configure.ac: Drop enable-libmcheck support.
3228         * configure, config.in: Rebuild.
3229         * libmcheck.m4: Remove.
3230         * acinclude.m4: Don't include it.
3231         * Makefile.in: Don't distribute it.
3232         * top.c (print_gdb_configuration): Don't mention it.
3233
3234 2019-08-06  Tom Tromey  <tom@tromey.com>
3235
3236         * utils.c (set_output_style): Sometimes pass stream to
3237         emit_style_escape.
3238         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3239         * record-btrace.c (btrace_insn_history): Update.
3240         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3241         method.
3242         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3243         Update initializers.
3244         <m_uiout>: New field.
3245         <m_di>: Move lower.
3246         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3247         Remove "uiout" parameter.
3248         (dump_insns): Update.
3249         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3250         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3251
3252 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3253
3254         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3255         (error_in_psymtab_expansion): Likewise.
3256         (lookup_symbol_via_quick_fns): Likewise.
3257         (basic_lookup_transparent_type_quick): Likewise.
3258         (basic_lookup_transparent_type_1): Likewise.
3259
3260 2019-08-06  Tom Tromey  <tromey@adacore.com>
3261
3262         * source.c (last_source_error): Now bool.
3263         (print_source_lines_base): Make "noprint" bool.  Only open
3264         source file when last_source_visited changes.
3265
3266 2019-08-06  Tom Tromey  <tromey@adacore.com>
3267
3268         * annotate.c (annotate_source_line): Use g_source_cache.
3269         * source-cache.c (source_cache::get_plain_source_lines): Change
3270         parameters.  Populate m_offset_cache.
3271         (source_cache::ensure): New method.
3272         (source_cache::get_line_charpos): New method.
3273         (extract_lines): Move lower.  Change parameters.
3274         (source_cache::get_source_lines): Move lower.
3275         * source-cache.h (class source_cache): Update comment.
3276         <get_line_charpos>: New method.
3277         <get_source_lines>: Update comment.
3278         <clear>: Clear m_offset_cache.
3279         <get_plain_source_lines>: Change parameters.
3280         <ensure>: New method
3281         <m_offset_cache>: New member.
3282         * source.c (forget_cached_source_info_for_objfile): Update.
3283         (info_source_command): Use g_source_cache.
3284         (find_source_lines, open_source_file_with_line_charpos): Remove.
3285         (print_source_lines_base, search_command_helper): Use g_source_cache.
3286         * source.h (open_source_file_with_line_charpos): Don't declare.
3287         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3288         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3289         Use g_source_cache.
3290
3291 2019-08-06  Tom Tromey  <tromey@adacore.com>
3292
3293         * source-cache.c (source_cache::get_plain_source_lines):
3294         Remove "first_line" and "last_line" parameters.
3295         (source_cache::get_source_lines): Cache plain text.
3296         * source-cache.h (class source_cache)
3297         <get_plain_source_lines>: Update.
3298
3299 2019-08-06  Tom Tromey  <tromey@adacore.com>
3300
3301         * source-cache.c (extract_lines): No longer a method.
3302         Changed type of parameter.  Include final newline.
3303         (selftests::extract_lines_test): New function.
3304         (_initialize_source_cache): Likewise.
3305         * source-cache.h (class source_cache)
3306         <extract_lines>: Don't declare.
3307
3308 2019-08-06  Tom Tromey  <tromey@adacore.com>
3309
3310         * breakpoint.c (init_breakpoint_sal): Update.
3311         (breakpoint): Update.
3312         * breakpoint.h (struct breakpoint) <filter>: Now a
3313         unique_xmalloc_ptr.
3314
3315 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3316
3317         * NEWS: Mention dictionary access on blocks.
3318         * python/py-block.c (blpy_getitem): New function.
3319         (block_object_as_mapping): New struct.
3320         (block_object_type): Use new struct for tp_as_mapping field.
3321
3322 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3323
3324         * objfiles.h (objfile): Add a comment describing partial symbols.
3325
3326 2019-08-05  Tom Tromey  <tromey@adacore.com>
3327
3328         * compile/compile.c (_initialize_compile): Use _(), not N_().
3329         * thread.c (_initialize_thread): Use _(), not N_().
3330         * stack.c (_initialize_stack): Use _(), not N_().
3331         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3332
3333 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3334
3335         * dwarf2read.c (struct dw2_symtab_iterator):
3336         <want_specific_block>: Remove.
3337         <block_index>: Change type to gdb::optional.
3338         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3339         change type of BLOCK_INDEX parameter to gdb::optional.
3340         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3341         (dw2_lookup_symbol): Don't pass argument for
3342         WANT_SPECIFIC_BLOCK.
3343         (dw2_expand_symtabs_for_function): Don't pass argument for
3344         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3345         (class dw2_debug_names_iterator)
3346         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3347         parameter, change BLOCK_INDEX type to gdb::optional.
3348         <m_want_specific_block>: Remove.
3349         <m_block_index>: Change type to gdb::optional.
3350         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3351         gdb::optional.  Re-write in function of gdb::optional.
3352         (dw2_debug_names_lookup_symbol): Don't pass argument for
3353         WANT_SPECIFIC_BLOCK.
3354         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3355         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3356         BLOCK_INDEX.
3357
3358 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3359
3360         * NEWS: Mention changes to "info sources" command.
3361
3362 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3363
3364         * symtab.c (filename_partial_match_opts): New struct type.
3365         (struct output_source_filename_data): New members
3366         regexp, c_regexp, partial_match.
3367         (output_source_filename): Use new members to decide to print file.
3368         (info_sources_option_defs): New variable.
3369         (make_info_sources_options_def_group, print_info_sources_header,
3370         info_sources_command_completer):
3371         New functions.
3372         (info_sources_command): Read new optional arguments.
3373         (_initialize_symtab): Update info sources help.
3374
3375 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3376
3377         * ada-lang.c (exception_support_info_v0): Renamed from...
3378         (default_exception_support_info): ... this.  Create new
3379         definition for v1.
3380         (ada_has_this_exception_support): Look up catch_handlers_sym.
3381         (ada_exception_support_info_sniffer): Try v0 after default.
3382
3383 2019-08-01  Tom Tromey  <tromey@adacore.com>
3384
3385         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3386         gdbarch.h.
3387
3388 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3389
3390         * s12z-tdep.c: Fix include path for s12z-opc.h.
3391
3392 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3393
3394         * NEWS: Require GNU make 3.82.
3395
3396 2019-07-16  Tom Tromey  <tom@tromey.com>
3397
3398         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3399         declare.
3400
3401 2019-07-30  Tom Tromey  <tromey@adacore.com>
3402
3403         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3404
3405 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3406
3407         * printcmd.c (print_address_symbolic): Print negative offsets.
3408         (build_address_symbolic): Force signed arithmetic when computing
3409         offset.
3410
3411 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3412
3413         PR/24474: Add a function to lookup static variables.
3414         * NEWS: Mention this new function.
3415         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3416         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3417         * python/python.c (python_GdbMethods): Add new function.
3418
3419 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3420
3421         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3422         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3423         (objfpy_lookup_static_symbol): New function.
3424         (objfile_object_methods): Add new functions.
3425
3426 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3427
3428         * NEWS: Mention 'set|show print frame-info'.  Mention new
3429         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3430         backtrace argument.  Mention that python frame filtering code
3431         is now consistent with what 'backtrace' command prints.
3432
3433 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3434
3435         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3436         comments.
3437         (print_frame_info_auto, print_frame_info_source_line,
3438         print_frame_info_location, print_frame_info_source_and_location,
3439         print_frame_info_location_and_address, print_frame_info_short_location):
3440         New declarations.
3441         (struct frame_print_options): New member print_frame_info.
3442         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3443         * stack.h (get_user_print_what_frame_info): New declaration.
3444         (frame_show_address): New declaration.
3445         * stack.c (print_frame_arguments_choices): New value 'presence'.
3446         (print_frame_info_auto, print_frame_info_source_line,
3447         print_frame_info_location, print_frame_info_source_and_location,
3448         print_frame_info_location_and_address, print_frame_info_short_location,
3449         print_frame_info_choices, print_frame_info_print_what): New definitions.
3450         (print_frame_args): Only print dots for args if print frame-arguments
3451         is 'presence'.
3452         (frame_print_option_defs): New element for "frame-info".
3453         (get_user_print_what_frame_info): New function.
3454         (frame_show_address): Make non static.  Move comment to stack.h.
3455         (print_frame_info_to_print_what): New function.
3456         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3457         to decide what to print.
3458         (backtrace_command_1): Handle the new print_frame_arguments_presence
3459         value.
3460         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3461         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3462         (py_print_frame): In non-mi mode, use LOCATION as default for
3463         print_what, similarly to frame information printed directly by
3464         backtrace command. Handle frame-info user option in non MI mode.
3465
3466 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3467
3468         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3469         Add case for debugging 32-bit target on 64-bit host.  Revise
3470         comment.
3471
3472 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3473
3474         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3475         instead of find_function_entry_range_from_pc.
3476
3477 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3478
3479         * stack.c (find_frame_funname): Remove code which preferred
3480         minsym over symtab sym in "certain pathological cases".
3481
3482         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3483         parameter.  Change type of "do_demangle" to bool.
3484         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3485         Pass suitable "prefer_sym_over_minsym" flag to
3486         build_address_symbolic().  Don't output "+" for negative offsets.
3487         * printcmd.c (print_address_symbolic): Update invocation of
3488         build_address_symbolic to include a "prefer_sym_over_minsym"
3489         flag.
3490         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3491         Restrict cases in which use of minimal symbol is preferred to that
3492         of a found symbol.  Update comments.
3493
3494         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3495         for entry pc when entry pc is out of range for that FDE.
3496
3497 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3498
3499         PR gdb/24839:
3500         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3501         type.
3502
3503 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3504
3505         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3506         this function's Python signature.
3507
3508
3509 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3510
3511         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3512         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3513         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3514         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3515         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3516
3517
3518 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3519
3520         * h8300-tdep.c (h8300_register_name_common): New.
3521         h8300_register_name): Use h8300_register_name_common.
3522         (h8300s_register_name): Likewise.
3523         (h8300sx_register_name): Likewise.
3524         (h8300h_register_nam): New.
3525         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3526
3527
3528 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3529
3530         * arm-tdep.c (arm_skip_cmse_entry): New function.
3531         (arm_is_sgstubs_section): New function.
3532         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3533
3534 2019-07-22  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3537         Don't self-assign.
3538
3539 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3540
3541         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3542         type_print.
3543
3544 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3545
3546         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3547         so that GDB doesn't match any msymbols when searching in the
3548         TYPES_DOMAIN.
3549         (print_symbol_info): Print using typedef_print or type_print based
3550         on the type of the symbol.  Add updated FIXME comment moved from...
3551         (_initialize_symtab): ... move and update FIXME comment to above.
3552
3553 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3554
3555         * NEWS: Mention adding -q option to "info types".
3556         * symtab.c (struct info_types_options): New struct.
3557         (info_types_options_defs): New variable.
3558         (make_info_types_options_def_group): New function.
3559         (info_types_command): Use gdb::option framework to parse options.
3560         (info_types_command_completer): New function.
3561         (_initialize_symtab): Extend the help text on "info types" and
3562         register command completer.
3563
3564 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3565
3566         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3567         (lookup_symbol_in_objfile): Change int to block_enum and add a
3568         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3569
3570 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3571
3572         * MAINTAINERS (Write After Approval): Add self.
3573
3574 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3575
3576         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3577         instruction to the dummy code region.
3578
3579 2019-07-19  Tom Tromey  <tromey@adacore.com>
3580
3581         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3582         (ARGSUSED, PARAMS, __func__): Remove rules.
3583
3584 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3585
3586         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3587         * features/arm/arm-with-iwmmxt.c: Remove.
3588         * features/arm/arm-with-iwmmxt.xml: Remove.
3589         * features/arm/arm-with-m-fpa-layout.c: Remove.
3590         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3591         * features/arm/arm-with-m-vfp-d16.c: Remove.
3592         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3593         * features/arm/arm-with-m.c: Remove.
3594         * features/arm/arm-with-m.xml: Remove.
3595         * features/arm/arm-with-neon.c: Remove.
3596         * features/arm/arm-with-neon.xml: Remove.
3597         * features/arm/arm-with-vfpv2.c: Remove.
3598         * features/arm/arm-with-vfpv2.xml: Remove.
3599         * features/arm/arm-with-vfpv3.c: Remove.
3600         * features/arm/arm-with-vfpv3.xml: Remove.
3601
3602 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3603
3604         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3605
3606 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3607
3608         * arch/aarch32.c (aarch32_create_target_description): Create
3609         target descriptions using features.
3610         * arch/arm.c (arm_create_target_description)
3611         (arm_create_mprofile_target_description): Likewise.
3612         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3613
3614 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3615
3616         * Makefile.in: Add new files.
3617         * aarch32-tdep.c: New file.
3618         * aarch32-tdep.h: New file.
3619         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3620         Call aarch32_read_description.
3621         * arch/aarch32.c: New file.
3622         * arch/aarch32.h: New file.
3623         * arch/arm.c (arm_create_target_description)
3624         (arm_create_mprofile_target_description): New function.
3625         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3626         (arm_create_target_description)
3627         (arm_create_mprofile_target_description): New declaration.
3628         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3629         read_description functions.
3630         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3631         Likewise.
3632         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3633         * arm-tdep.c (tdesc_arm_list): New variable.
3634         (arm_register_g_packet_guesses): Call create description functions.
3635         (arm_read_description) (arm_read_mprofile_description): New
3636         function.
3637         * arm-tdep.h (arm_read_description)
3638         (arm_read_mprofile_description): Add declaration.
3639         * configure.tgt: Add new files.
3640
3641 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3642
3643         * top.c (new_ui_command): Open specified terminal just once.
3644
3645 2019-07-18  Tom Tromey  <tromey@adacore.com>
3646
3647         * symtab.c (main_name): Constify return type.
3648         * symfile.c (set_initial_language): Update.
3649         * symtab.h (main_name): Constify return type.
3650
3651 2019-07-17  Tom Tromey  <tom@tromey.com>
3652
3653         * tui/tui-winsource.c (tui_update_source_window)
3654         (tui_update_source_window_as_is)
3655         (tui_update_source_windows_with_line): Remove return.
3656         * tui/tui-disasm.c (tui_show_disassem)
3657         (tui_show_disassem_and_update_source): Remove return.
3658         * tui/tui.c (tui_reset): Remove return.
3659         * tui/tui-wingeneral.c
3660         (tui_check_and_display_highlight_if_needed): Remove return.
3661
3662 2019-07-17  Tom Tromey  <tom@tromey.com>
3663
3664         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3665
3666 2019-07-17  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-winsource.h (struct tui_exec_info_window)
3669         (struct tui_source_window_base): Move from tui-data.h.
3670         * tui/tui-winsource.c: Move many method definitions from
3671         elsewhere.  Remove "structuring" comments.
3672         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3673         (tui_source_window_base::refresh_window): Move to
3674         tui-winsource.c.
3675         * tui/tui-win.c (tui_source_window_base::refresh_all)
3676         (tui_source_window_base::update_tab_width)
3677         (tui_source_window_base::set_new_height)
3678         (tui_source_window_base::do_make_visible_with_new_height): Move to
3679         tui-winsource.c.
3680         * tui/tui-source.h: Update.
3681         * tui/tui-source.c (tui_source_window_base::reset): Move to
3682         tui-winsource.c.
3683         * tui/tui-disasm.h: Update.
3684         * tui/tui-data.h (struct tui_exec_info_window): Move to
3685         tui-winsource.h.
3686         (struct tui_source_window_base): Likewise.
3687         * tui/tui-data.c (tui_source_window_base::clear_detail)
3688         (tui_source_window_base, ~tui_source_window_base): Move to
3689         tui-winsource.c.
3690
3691 2019-07-17  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-win.c (tui_resize_all)
3694         (tui_source_window_base::update_tab_width)
3695         (tui_adjust_win_heights): Update.
3696         (tui_win_info::make_invisible_and_set_new_height): Rename from
3697         make_invisible_and_set_new_height.
3698         * tui/tui-data.h (struct tui_win_info)
3699         <make_invisible_and_set_new_height>: New method.
3700
3701 2019-07-17  Tom Tromey  <tom@tromey.com>
3702
3703         * tui/tui.c: Update.
3704         * tui/tui-source.h (struct tui_source_window): Move from
3705         tui-data.h.
3706         * tui/tui-layout.c: Update.
3707         * tui/tui-disasm.c: Update.
3708         * tui/tui-data.h (struct tui_source_window): Move to
3709         tui-source.h.
3710
3711 2019-07-17  Tom Tromey  <tom@tromey.com>
3712
3713         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3714         tui-data.h.
3715         * tui/tui-data.h (struct tui_disasm_window): Move to
3716         tui-disasm.h.
3717
3718 2019-07-17  Tom Tromey  <tom@tromey.com>
3719
3720         * tui/tui-regs.h (struct tui_data_item_window): Move from
3721         tui-data.h.
3722         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3723         * tui/tui-data.h (struct tui_data_item_window): Move to
3724         tui-regs.h.
3725         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3726
3727 2019-07-17  Tom Tromey  <tom@tromey.com>
3728
3729         * tui/tui.c: Update.
3730         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3731         (tui_cmd_window::max_height): Move to tui-command.c.
3732         * tui/tui-layout.c: Update.
3733         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3734         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3735         tui-command.c.
3736         * tui/tui-command.h (struct tui_cmd_window): Move from
3737         tui-data.h.
3738         * tui/tui-command.c: Remove "structuring" comments.
3739         (tui_cmd_window::clear_detail)
3740         (tui_cmd_window::do_make_visible_with_new_height)
3741         (tui_cmd_window::max_height): Move from elsewhere.
3742
3743 2019-07-17  Tom Tromey  <tom@tromey.com>
3744
3745         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3746         Now static.
3747         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3748         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3749
3750 2019-07-17  Tom Tromey  <tom@tromey.com>
3751
3752         * tui/tui.c: Update.
3753         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3754         tui-regs.c.
3755         * tui/tui-windata.h: Remove file.
3756         * tui/tui-windata.c: Remove file.
3757         * tui/tui-win.c (tui_data_window::set_new_height)
3758         (tui_data_window::do_make_visible_with_new_height): Move to
3759         tui-regs.c.
3760         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3761         * tui/tui-regs.c: Remove "structuring" comments.
3762         (tui_data_window::first_data_item_displayed)
3763         (tui_data_window::delete_data_content_windows)
3764         (tui_data_window::erase_data_content)
3765         (tui_data_window::display_all_data)
3766         (tui_data_window::refresh_all)
3767         (tui_data_window::do_scroll_vertical)
3768         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3769         (tui_data_window::do_make_visible_with_new_height)
3770         (tui_data_window::refresh_window): Move from elsewhere.
3771         (_initialize_tui_regs): Move to end of file.
3772         * tui/tui-layout.c: Update.
3773         * tui/tui-hooks.c: Update.
3774         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3775         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3776         tui-regs.c.
3777         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3778
3779 2019-07-17  Tom Tromey  <tom@tromey.com>
3780
3781         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3782         seen.
3783
3784 2019-07-17  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-win.c (tui_source_window_base::set_new_height)
3787         (tui_source_window_base::do_make_visible_with_new_height): Use
3788         m_has_locator field directly.
3789         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3790         method.
3791         (struct tui_source_window_base) <has_locator>: Likewise.
3792
3793 2019-07-17  Tom Tromey  <tom@tromey.com>
3794
3795         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3796         Don't declare.
3797         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3798         Remove.
3799         * tui/tui-win.c (tui_source_window_base::set_new_height)
3800         (tui_source_window_base::set_new_height)
3801         (make_invisible_and_set_new_height)
3802         (tui_source_window_base::do_make_visible_with_new_height)
3803         (tui_source_window_base::do_make_visible_with_new_height):
3804         Update.
3805         * tui/tui-layout.c (show_source_disasm_command, show_data)
3806         (show_source_or_disasm_and_command): Update.
3807         * tui/tui-layout.c (show_layout): Update.
3808
3809 2019-07-17  Tom Tromey  <tom@tromey.com>
3810
3811         * tui/tui-layout.c (make_data_window): Remove.
3812         (show_data): Unify creation and re-initialization cases.
3813
3814 2019-07-17  Tom Tromey  <tom@tromey.com>
3815
3816         * tui/tui-layout.c (make_source_window, make_disasm_window):
3817         Remove.
3818         (show_data): Unify creation and re-initialization cases.
3819
3820 2019-07-17  Tom Tromey  <tom@tromey.com>
3821
3822         * tui/tui-layout.c (make_command_window): Remove.
3823         (show_source_disasm_command, show_source_or_disasm_and_command):
3824         Unify creation and re-initialization cases.
3825
3826 2019-07-17  Tom Tromey  <tom@tromey.com>
3827
3828         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3829         creation and re-initialization cases.
3830
3831 2019-07-17  Tom Tromey  <tom@tromey.com>
3832
3833         * tui/tui-regs.c (tui_get_register): Return void.
3834
3835 2019-07-17  Tom Tromey  <tom@tromey.com>
3836
3837         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3838         Simplify.
3839
3840 2019-07-17  Tom Tromey  <tom@tromey.com>
3841
3842         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3843         resetting.
3844
3845 2019-07-17  Tom Tromey  <tom@tromey.com>
3846
3847         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3848         * tui/tui-regs.c (tui_reg_layout): New function.
3849         (tui_show_registers, tui_reg_command): Use it.
3850         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3851         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3852         parameters.
3853         (tui_layout_command): Remove.
3854
3855 2019-07-17  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-layout.h (tui/tui-layout): Return void.
3858         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3859
3860 2019-07-17  Tom Tromey  <tom@tromey.com>
3861
3862         * tui/tui-layout.c (show_source_disasm_command, show_data):
3863         Update.
3864         (reset_locator): Remove.
3865         (show_source_or_disasm_and_command): Update.
3866
3867 2019-07-17  Tom Tromey  <tom@tromey.com>
3868
3869         * tui/tui-source.c (tui_source_window_base::reset): Remove
3870         win_type parameter.
3871         * tui/tui-layout.c (make_command_window, make_source_window)
3872         (make_disasm_window, make_data_window)
3873         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3874         (reset_locator, show_source_or_disasm_and_command): Update.
3875         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3876         win_type parameter.
3877         (struct tui_source_window_base) <reset>: Likewise.
3878
3879 2019-07-17  Tom Tromey  <tom@tromey.com>
3880
3881         * tui/tui-layout.c (show_source_disasm_command): Use
3882         reset_locator.
3883         (reset_locator): New function.
3884         (init_and_make_win): Remove.
3885         (show_source_or_disasm_and_command): Use reset_locator.
3886
3887 2019-07-17  Tom Tromey  <tom@tromey.com>
3888
3889         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3890         condition.
3891         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3892         Remove condition.
3893         * tui/tui-source.c (tui_source_window_base::reset): New method.
3894         * tui/tui-layout.c (make_command_window): Don't call
3895         init_and_make_win.
3896         (make_source_window, make_disasm_window): Don't call
3897         make_source_or_disasm_window.
3898         (make_data_window): Don't call init_and_make_win.  Change calling
3899         convention.
3900         (show_source_disasm_command, show_data): Simplify.
3901         (make_source_or_disasm_window): Remove.
3902         (show_source_or_disasm_and_command): Simplify.
3903         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3904         (struct tui_source_window_base) <reset>: Likewise.
3905         <execution_info>: Remove initializer.
3906         * tui/tui-data.c (tui_source_window_base): Initialize
3907         execution_info.
3908
3909 2019-07-17  Tom Tromey  <tom@tromey.com>
3910
3911         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3912         variable.
3913
3914 2019-07-17  Tom Tromey  <tom@tromey.com>
3915
3916         * tui/tui.c (tui_rl_other_window): Update.
3917         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3918         superclass method first.  Always iterate over regs_content.
3919         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3920         method.
3921         * tui/tui-win.c (tui_set_focus_command): Update.
3922
3923 2019-07-17  Tom Tromey  <tom@tromey.com>
3924
3925         * tui/tui-win.c (tui_set_focus_command): Rename from
3926         tui_set_focus.  Call tui_enable.
3927         (tui_set_focus_command): Remove.
3928
3929 2019-07-17  Tom Tromey  <tom@tromey.com>
3930
3931         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3932         refresh_window.
3933         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3934         touchwin.
3935         (tui_data_window::refresh_window): Call refresh_window on data
3936         items.  Always call superclass refresh_window.
3937         (tui_win_info::refresh): Remove.
3938         (tui_source_window_base::refresh_window): Update.
3939         (tui_refresh_all): Update.
3940         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3941         refresh_window.
3942         (show_source_or_disasm_and_command): Likewise.
3943         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3944         (struct tui_source_window_base) <refresh>: Likewise.
3945
3946 2019-07-17  Tom Tromey  <tom@tromey.com>
3947
3948         * tui/tui-winsource.c (tui_clear_source_content)
3949         (tui_show_source_content): Update.
3950         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3951         whether content is empty.
3952         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3953         Remove.
3954
3955 2019-07-17  Tom Tromey  <tom@tromey.com>
3956
3957         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3958         window's contents.
3959         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3960         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3961
3962 2019-07-17  Tom Tromey  <tom@tromey.com>
3963
3964         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3965         (struct tui_data_item_window): Update.
3966
3967 2019-07-17  Tom Tromey  <tom@tromey.com>
3968
3969         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3970         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3971         defines.
3972
3973 2019-07-17  Tom Tromey  <tom@tromey.com>
3974
3975         * tui/tui-winsource.h (tui_erase_source_content)
3976         (tui_clear_source_content): Remove "display_prompt" parameter.
3977         * tui/tui-winsource.c (tui_update_source_window_as_is)
3978         (tui_update_source_windows_with_addr): Update.
3979         (tui_clear_source_content): Remove "display_prompt" parameter.
3980         (tui_erase_source_content): Likewise.  Simplify.
3981         (tui_show_source_content): Update.
3982         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3983         * tui/tui-stack.c (tui_show_frame_info): Update.
3984         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3985         Remove defines.
3986
3987 2019-07-17  Tom Tromey  <tom@tromey.com>
3988
3989         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3990         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3991         parameter.
3992         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3993         parameter.
3994
3995 2019-07-17  Tom Tromey  <tom@tromey.com>
3996
3997         * tui/tui-winsource.c (tui_clear_source_content)
3998         (tui_show_source_content, tui_show_exec_info_content)
3999         (tui_clear_exec_info_content): Update.
4000         * tui/tui-stack.c (tui_show_locator_content): Update.
4001         (tui_show_frame_info): Update.
4002         * tui/tui-source.h (tui_source_window): Don't declare.
4003         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4004         from tui_source_is_displayed.
4005         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4006         Remove field.
4007         (struct tui_source_window_base) <content_in_use>: New field.  Now
4008         bool.
4009         (struct tui_source_window) <showing_source_p>: New method.
4010         (TUI_SRC_WIN): Change cast.
4011         * tui/tui-data.c (tui_initialize_static_data): Update.
4012
4013 2019-07-17  Tom Tromey  <tom@tromey.com>
4014
4015         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4016         location_matches_p.
4017         * tui/tui-source.c (tui_source_window::location_matches_p): New
4018         method.
4019         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4020         method.
4021         * tui/tui-data.h (struct tui_source_window_base)
4022         <location_matches_p>: New method.
4023         (struct tui_source_window, struct tui_disasm_window)
4024         <location_matches_p>: Likewise.
4025
4026 2019-07-17  Tom Tromey  <tom@tromey.com>
4027
4028         * tui/tui-win.c (tui_set_win_height_command): Rename from
4029         tui_set_win_height.
4030         (tui_set_win_height_command): Remove.
4031
4032 2019-07-17  Tom Tromey  <tom@tromey.com>
4033
4034         * tui/tui-source.c (tui_source_window): New constructor.  Add
4035         observer.
4036         (~tui_source_window): New destructor.
4037         (tui_source_window::style_changed): New method.
4038         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4039         (tui_attach_detach_observers): Update.
4040         * tui/tui-data.h (struct tui_source_window): Make constructor not
4041         inline.  Add destructor.
4042         (struct tui_source_window) <style_changed>: New method.
4043         <m_observable>: New member.
4044
4045 2019-07-17  Tom Tromey  <tom@tromey.com>
4046
4047         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4048         * tui/tui-win.c (tui_resize_all): Fix typo.
4049
4050 2019-07-17  Tom Tromey  <tom@tromey.com>
4051
4052         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4053         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4054         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4055         * tui/tui-win.c (window_name_completer): Use foreach.
4056         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4057         (update_tab_width): Likewise.
4058         * tui/tui-layout.c (show_layout): Update.
4059         * tui/tui-data.h (class tui_window_iterator): New.
4060         (struct all_tui_windows): New.
4061         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4062
4063 2019-07-17  Tom Tromey  <tom@tromey.com>
4064
4065         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4066         parameter.  Don't reference globals.
4067         (tui_reg_command): Update.
4068
4069 2019-07-17  Tom Tromey  <tom@tromey.com>
4070
4071         * tui/tui-regs.c (tui_show_registers): Simplify.
4072
4073 2019-07-17  Tom Tromey  <tom@tromey.com>
4074
4075         * tui/tui-regs.c (tui_show_registers): Update.
4076         (tui_show_register_group): Add win_info parameter.
4077
4078 2019-07-17  Tom Tromey  <tom@tromey.com>
4079
4080         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4081         Rename from tui_display_reg_element_at_line.
4082         (tui_data_window::display_registers_from_line): Update.
4083         * tui/tui-data.h (struct tui_data_window)
4084         <display_reg_element_at_line>: New method.
4085
4086 2019-07-17  Tom Tromey  <tom@tromey.com>
4087
4088         * tui/tui-regs.h (tui_display_registers_from)
4089         (tui_display_registers_from_line): Don't declare.
4090         * tui/tui-windata.c (tui_data_window::display_all_data)
4091         (tui_data_window::refresh_all)
4092         (tui_data_window::do_scroll_vertical): Update.
4093         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4094         from tui_display_registers_from.
4095         (tui_display_reg_element_at_line): Update.
4096         (tui_data_window::display_registers_from_line): Rename from
4097         tui_display_registers_from_line.
4098         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4099         display_registers_from_line>: New methods.
4100
4101 2019-07-17  Tom Tromey  <tom@tromey.com>
4102
4103         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4104         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4105         from tui_erase_data_content.
4106         (tui_data_window::display_all_data)
4107         (tui_data_window::refresh_all)
4108         (tui_data_window::do_scroll_vertical): Update.
4109         * tui/tui-regs.c (tui_show_registers): Update.
4110         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4111         New method.
4112
4113 2019-07-17  Tom Tromey  <tom@tromey.com>
4114
4115         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4116         declare.
4117         * tui/tui-windata.c
4118         (tui_data_window::delete_data_content_windows): Rename from
4119         tui_delete_data_content_windows.
4120         (tui_data_window::display_all_data)
4121         (tui_data_window::do_scroll_vertical): Update.
4122         * tui/tui-data.h (struct tui_data_window)
4123         <delete_data_content_windows>: New method.
4124
4125 2019-07-17  Tom Tromey  <tom@tromey.com>
4126
4127         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4128         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4129
4130 2019-07-17  Tom Tromey  <tom@tromey.com>
4131
4132         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4133         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4134         from tui_display_all_data.
4135         * tui/tui-win.c
4136         (tui_data_window::do_make_visible_with_new_height): Update.
4137         * tui/tui-regs.c (tui_show_registers): Update.
4138         * tui/tui-layout.c (tui_set_layout): Update.
4139         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4140         method.
4141
4142 2019-07-17  Tom Tromey  <tom@tromey.com>
4143
4144         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4145         * tui/tui-windata.c (tui_display_data_from): Remove.
4146         (tui_data_window::refresh_all): Update.
4147
4148 2019-07-17  Tom Tromey  <tom@tromey.com>
4149
4150         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4151         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4152         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4153         tui_display_registers_from_line.
4154         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4155         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4156         "force_display" parameter.
4157
4158 2019-07-17  Tom Tromey  <tom@tromey.com>
4159
4160         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4161         declare.
4162         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4163         Rename from tui_first_reg_element_no_inline.
4164         (tui_display_reg_element_at_line)
4165         (tui_display_registers_from_line): Update.
4166         * tui/tui-data.h (struct tui_data_window)
4167         <first_reg_element_no_inline>: New method.
4168
4169 2019-07-17  Tom Tromey  <tom@tromey.com>
4170
4171         * tui/tui-windata.c (tui_display_data_from)
4172         (tui_data_window::do_scroll_vertical): Update.
4173         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4174         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4175         Rename from tui_line_from_reg_element_no.
4176         (tui_display_registers_from_line): Update.
4177         * tui/tui-data.h (struct tui_data_window)
4178         <line_from_reg_element_no>: New method.
4179
4180 2019-07-17  Tom Tromey  <tom@tromey.com>
4181
4182         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4183         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4184         tui_last_regs_line_no.
4185         (tui_display_reg_element_at_line)
4186         (tui_display_registers_from_line): Update.
4187         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4188         method.
4189
4190 2019-07-17  Tom Tromey  <tom@tromey.com>
4191
4192         PR tui/24722:
4193         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4194         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4195         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4196         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4197         (tui_update_breakpoint_info): Likewise.
4198         * tui/tui-hooks.c (tui_event_create_breakpoint)
4199         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4200         Update.
4201
4202 2019-07-17  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4205
4206 2019-07-17  Tom Tromey  <tom@tromey.com>
4207
4208         * tui/tui-winsource.c (tui_update_source_window_as_is)
4209         (tui_update_source_windows_with_addr): Update.
4210         * tui/tui-source.h (tui_set_source_content)
4211         (tui_show_symtab_source): Add "win_info" parameter.
4212         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4213         parameter.
4214         (tui_show_symtab_source): Likewise.
4215
4216 2019-07-17  Tom Tromey  <tom@tromey.com>
4217
4218         * tui/tui-wingeneral.c
4219         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4220
4221 2019-07-17  Tom Tromey  <tom@tromey.com>
4222
4223         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4224         (struct tui_cmd_window) <can_scroll>: New method.
4225         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4226         method.
4227
4228 2019-07-17  Tom Tromey  <tromey@adacore.com>
4229
4230         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4231         do_field_signed>: Rename.  Change type of "value".
4232         * ui-out.c (ui_out::field_signed): Rename from field_int.
4233         Change type of "value".
4234         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4235         type of "value".
4236         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4237         do_field_int.  Change type of "value".
4238         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4239         do_field_int.  Change type of "value".
4240         * tracepoint.c (trace_status_mi, tfind_1)
4241         (print_one_static_tracepoint_marker): Update.
4242         * thread.c (print_thread_info_1, print_selected_thread_frame):
4243         Update.
4244         * stack.c (print_frame, print_frame_info): Update.
4245         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4246         Update.
4247         * source.c (print_source_lines_base): Update.
4248         * skip.c (info_skip_command): Update.
4249         * record-btrace.c (btrace_ui_out_decode_error)
4250         (btrace_call_history_src_line): Update.
4251         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4252         Update.
4253         * progspace.c (print_program_space): Update.
4254         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4255         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4256         do_field_int.  Change type of "value".
4257         * mi/mi-out.c (mi_ui_out::do_table_begin)
4258         (mi_ui_out::do_table_header): Update.
4259         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4260         type of "value".
4261         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4262         (mi_cmd_data_list_changed_registers, output_register)
4263         (mi_cmd_data_read_memory, mi_load_progress)
4264         (mi_cmd_trace_frame_collected): Update.
4265         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4266         Update.
4267         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4268         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4269         (mi_cmd_var_list_children, varobj_update_one): Update.
4270         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4271         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4272         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4273         * inferior.c (print_inferior): Update.
4274         * gdb_bfd.c (print_one_bfd): Update.
4275         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4276         Update.
4277         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4278         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4279         do_field_int.  Change type of "value".
4280         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4281         do_field_int.  Change type of "value".
4282         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4283         (print_one_breakpoint_location, print_it_catch_fork)
4284         (print_one_catch_fork, print_it_catch_vfork)
4285         (print_one_catch_vfork, print_it_catch_solib)
4286         (print_it_catch_exec, print_it_ranged_breakpoint)
4287         (print_mention_watchpoint, print_mention_masked_watchpoint)
4288         (bkpt_print_it, update_static_tracepoint): Update.
4289         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4290         * break-catch-syscall.c (print_it_catch_syscall): Update.
4291         * ada-tasks.c (print_ada_task_info): Update.
4292         * ada-lang.c (print_it_exception, print_mention_exception):
4293         Update.
4294
4295 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4296
4297         PR breakpoints/24541
4298         * gdbarch.c: Regenerate.
4299         * gdbarch.h: Regenerate.
4300         * gdbarch.sh: Adjust return type and parameter types for
4301         'stap_adjust_register'.
4302         (i386_stap_adjust_register): Adjust signature and return new
4303         register name.
4304         * stap-probe.c (stap_parse_register_operand): Adjust use of
4305         'gdbarch_stap_adjust_register'.
4306
4307 2019-07-17  Tom Tromey  <tromey@adacore.com>
4308
4309         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4310         declare VEC.
4311         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4312         std::vector.
4313         (struct s390_process_info): Add initializers.
4314         (s390_add_process): Use new.
4315         (s390_linux_nat_target::low_forget_process): Use delete.
4316         (s390_linux_nat_target::low_new_fork)
4317         (s390_linux_nat_target::stopped_by_watchpoint)
4318         (s390_linux_nat_target::low_prepare_to_resume)
4319         (s390_linux_nat_target::insert_watchpoint)
4320         (s390_linux_nat_target::insert_hw_breakpoint)
4321         (s390_linux_nat_target::remove_watchpoint)
4322         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4323
4324 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4325
4326         * aarch64-fbsd-nat.c: Include regcache.h.
4327         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4328         argument.
4329         (aarch64_fbsd_nat_target::fetch_registers)
4330         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4331         variable.
4332         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4333
4334 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4335
4336         * fbsd-nat.c: Include gdbarch.h.
4337
4338 2019-07-15  Tom Tromey  <tromey@adacore.com>
4339
4340         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4341
4342 2019-07-15  Tom Tromey  <tromey@adacore.com>
4343
4344         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4345         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4346         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4347         * cli-out.c (cli_ui_out::do_field_int): New method.
4348         * ui-out.c (ui_out::field_unsigned): New method.
4349         * symfile.c (generic_load): Use field_unsigned.
4350         (print_transfer_performance): Likewise.
4351         * record-btrace.c (ui_out_field_uint): Remove.
4352         (btrace_call_history_insn_range, btrace_call_history): Use
4353         field_unsigned.
4354         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4355         field_unsigned.
4356         * ui-out.h (class ui_out) <field_unsigned>: New method.
4357         <do_field_unsigned>: Likewise.
4358
4359 2019-07-15  Tom Tromey  <tromey@adacore.com>
4360
4361         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4362         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4363         * target.c (flash_erase_command): Use field_string.
4364         * infrun.c (print_signal_received_reason): Use field_string.
4365         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4366         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4367         field_string.
4368         * ada-tasks.c (print_ada_task_info): Use field_string.
4369
4370 2019-07-15  Tom Tromey  <tromey@adacore.com>
4371
4372         * target.c (flash_erase_command): Use field_core_addr.
4373         * symfile.c (generic_load): Use field_core_addr.
4374         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4375         Use field_core_addr.
4376         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4377         field_core_addr.
4378
4379 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4380
4381         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4382         value if its desired type is smaller than a CORE_ADDR and signed.
4383
4384 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4385
4386         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4387         of changes to field names, and use new is_reference field to
4388         decide if a property is a reference or not.
4389         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4390         field.
4391         (struct dwarf2_property_baton): Update header comment, rename
4392         'referenced_type' to 'property_type' and update comments.
4393         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4394         default property type, store in property baton, update to take
4395         accound of renamed field.
4396         (read_func_scope): Update call to attr_to_dynamic_prop.
4397         (read_array_type): Likewise.
4398         (dwarf2_per_cu_addr_sized_int_type): New function.
4399         (read_subrange_index_type): Move type finding code to
4400         dwarf2_per_cu_addr_sized_int_type.
4401         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4402         (dwarf2_per_cu_addr_type): New function.
4403         (set_die_type): Update calls to attr_to_dynamic_prop.
4404
4405 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4406
4407         * dwarf2read.c (read_subrange_index_type): New function.
4408         (read_subrange_type): Move code into new function and call it.
4409         * gdbtypes.c (create_range_type): Add some asserts.
4410
4411 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4412
4413         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4414         update return statements.
4415         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4416         declaration, and update comment to match.
4417         * gdbtypes.c (resolve_dynamic_array): Update call to
4418         dwarf2_evaluate_property to match new return type.
4419
4420 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4421
4422         * valarith.c (value_subscripted_rvalue): Change lowerbound
4423         parameter type from int to LONGEST.
4424         * value.h (value_subscripted_rvalue): Likewise in declaration.
4425
4426 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4427
4428         * cli/cli-utils.c (info_print_command_completer): New function.
4429         * cli/cli-utils.h: Add 'completer.h' include, and forward
4430         declaration for 'struct cmd_list_element'.
4431         (info_print_command_completer): Declare.
4432         * stack.c (_initialize_stack): Add completer for 'info locals' and
4433         'info args'.
4434         * symtab.c (_initialize_symtab): Add completer for 'info
4435         variables' and 'info functions'.
4436         * NEWS: Mention completion for additional info commands.
4437
4438 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4439
4440         * cli/cli-utils.c (extract_info_print_args): Delete.
4441         (extract_arg_maybe_quoted): Delete.
4442         (info_print_options_defs): New variable.
4443         (make_info_print_options_def_group): New function.
4444         (extract_info_print_options): Define new function.
4445         * cli/cli-utils.h (extract_info_print_args): Delete.
4446         (struct info_print_options): New structure.
4447         (extract_info_print_options): Declare new function.
4448         * stack.c (info_locals_command): Update to use new
4449         extract_info_print_options, also add a header comment.
4450         (info_args_command): Likewise.
4451         * symtab.c (info_variables_command): Likewise.
4452         (info_functions_command): Likewise.
4453
4454 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4455
4456         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4457         to extract string arguments.
4458         * common/common-utils.c (extract_string_maybe_quoted): New function.
4459         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4460
4461 2019-07-11  Tom Tromey  <tromey@adacore.com>
4462
4463         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4464         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4465         * top.h (gdbinit): Don't declare.
4466         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4467         into...
4468         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4469         * top.c (gdb_init): Don't call init_cli_cmds.
4470         (gdbinit): Remove.
4471         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4472
4473 2019-07-11  Tom Tromey  <tromey@adacore.com>
4474
4475         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4476         after it has been moved.
4477
4478 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4479
4480         * valops.c (value_must_coerce_to_target): Change return type to
4481         bool.
4482         * value.h (value_must_coerce_to_target): Likewise.
4483
4484 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4485
4486         * breakpoint.c (is_hardware_watchpoint): Remove
4487         forward-declaration.
4488         (is_masked_watchpoint): Change return type to bool.
4489         (is_tracepoint): Likewise.
4490         (is_breakpoint): Likewise.
4491         (is_hardware_watchpoint): Likewise.
4492         (is_watchpoint): Likewise.
4493         (is_no_memory_software_watchpoint): Likewise.
4494         (is_catchpoint): Likewise.
4495         (breakpoint_1): Make FILTER parameter's return type bool.
4496         is_masked_watchpoint): Change return type to bool.
4497         (save_breakpoints): Make FILTER parameter's return type bool.
4498         * breakpoint.h (is_breakpoint): Change return type to bool.
4499         (is_watchpoint): Likewise.
4500         (is_catchpoint): Likewise.
4501         (is_tracepoint): Likewise.
4502
4503 2019-07-10  Tom Tromey  <tom@tromey.com>
4504
4505         * defs.h: Don't include gdbarch.h.
4506         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4507         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4508         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4509         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4510         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4511         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4512         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4513         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4514         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4515         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4516         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4517         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4518         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4519         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4520         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4521         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4522         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4523         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4524         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4525         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4526         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4527         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4528         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4529         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4530         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4531         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4532         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4533
4534 2019-07-10  Tom Tromey  <tromey@adacore.com>
4535
4536         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4537         * breakpoint.c (init_ada_exception_breakpoint): Register as
4538         bp_catchpoint.
4539         (print_one_breakpoint_location, print_one_breakpoint): Use
4540         is_ada_exception_catchpoint.
4541         * ada-lang.c (class ada_catchpoint_location): Pass
4542         bp_loc_software_breakpoint to bp_location constructor.
4543         (is_ada_exception_catchpoint): New function.
4544
4545 2019-07-10  Tom Tromey  <tromey@adacore.com>
4546
4547         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4548         VEC.
4549         (struct arm_exidx_entry): New method operator<.
4550         (struct arm_exidx_data) <section_maps>: Change type.
4551         (arm_exidx_data_free): Remove.
4552         (arm_exidx_data_key): Change type.  Move lower.
4553         (arm_exidx_new_objfile): Update.
4554         (arm_compare_exidx_entries): Remove.
4555         (arm_find_exidx_entry, _initialize_arm_tdep)
4556
4557 2019-07-10  Tom Tromey  <tromey@adacore.com>
4558
4559         * solib-spu.c (ocl_program_data_key): Change type.
4560         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4561         Update.
4562
4563 2019-07-10  Tom Tromey  <tromey@adacore.com>
4564
4565         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4566         (struct solib_aix_inferior_data) <library_list>: Change type.
4567         (solib_aix_inferior_data_handle): Change type.
4568         (get_solib_aix_inferior_data): Update.
4569         (solib_aix_free_library_list): Remove.
4570         (library_list_start_library): Update.
4571         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4572         return type.
4573         (solib_aix_get_library_list)
4574         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4575         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4576
4577 2019-07-10  Tom Tromey  <tromey@adacore.com>
4578
4579         * solib-dsbt.c (struct dsbt_info): Add initializers.
4580         (solib_dsbt_pspace_data): Change type.
4581         (dsbt_pspace_data_cleanup): Remove.
4582         (get_dsbt_info, _initialize_dsbt_solib): Update.
4583
4584 2019-07-10  Tom Tromey  <tromey@adacore.com>
4585
4586         * spu-tdep.c (spu_overlay_data): Change type.
4587         (spu_get_overlay_table, spu_overlay_new_objfile)
4588         (_initialize_spu_tdep): Update.
4589
4590 2019-07-10  Tom Tromey  <tromey@adacore.com>
4591
4592         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4593         destructor.
4594         (dbx_objfile_data_key): Change type and declare later.
4595         (DBX_SYMFILE_INFO): Rewrite.
4596         * dbxread.c (dbx_objfile_data_key): Change type.
4597         (dbx_symfile_init): Update.
4598         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4599         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4600         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4601
4602 2019-07-10  Tom Tromey  <tromey@adacore.com>
4603
4604         * jit.c (jit_program_space_key): Change type.  Move lower.
4605         (get_jit_program_space_data): Update.
4606         (jit_program_space_data_cleanup): Remove.
4607         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4608         Update.
4609         (struct jit_program_space_data): Add initializers.
4610
4611 2019-07-10  Tom Tromey  <tromey@adacore.com>
4612
4613         * solib-darwin.c (struct darwin_info): Add initializers.
4614         (solib_darwin_pspace_data): Change type.
4615         (darwin_pspace_data_cleanup): Remove.
4616         (get_darwin_info, _initialize_darwin_solib): Update.
4617
4618 2019-07-10  Tom Tromey  <tromey@adacore.com>
4619
4620         * remote-sim.c (struct sim_inferior_data): Add initializers,
4621         constructor, and destructor.
4622         (sim_inferior_data_key): Change type.  Move lower.
4623         (check_for_duplicate_sim_descriptor): Update.
4624         (get_sim_inferior_data): Use new.  Update.
4625         (~sim_inferior_data_cleanup): Rename from
4626         sim_inferior_data_cleanup.  Simplify.
4627         (gdbsim_close_inferior, simulator_command)
4628         (sim_command_completer, _initialize_remote_sim): Update.
4629         (next_pid, INITIAL_PID): Move earlier.
4630
4631 2019-07-10  Tom Tromey  <tromey@adacore.com>
4632
4633         * python/python-internal.h (create_thread_object): Return
4634         gdbpy_ref.
4635         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4636         * python/py-inferior.c (struct threadlist_entry): Add
4637         constructor.
4638         <thread_obj>: Now a gdbpy_ref.
4639         (thread_to_thread_object): Update.
4640         (add_thread_object): Use new.
4641         (delete_thread_object): Use delete.
4642         (infpy_threads): Update.
4643         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4644         GIL.
4645
4646 2019-07-10  Tom Tromey  <tromey@adacore.com>
4647
4648         * valops.c (value_cast): Specialize error message for Ada.
4649
4650 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4651
4652         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4653
4654 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4655
4656         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4657         bpstat_should_step): Return bool, adjust comments.
4658         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4659         bpstat_should_step): Likewise.
4660
4661 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4662
4663         * features/Makefile: Use feature target descriptions for Arm.
4664         * features/arm/arm-core.c: Generate new file.
4665         * features/arm/arm-fpa.c: Likewise.
4666         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4667         * features/arm/arm-m-profile.c: Likewise.
4668         * features/arm/arm-vfpv2.c: Likewise.
4669         * features/arm/arm-vfpv3.c: Likewise.
4670         * features/arm/xscale-iwmmxt.c: Likewise.
4671         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4672
4673 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4674
4675         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4676         ptrace earlier.
4677
4678 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4679
4680         * features/aarch64-pauth.c: Regenerate.
4681
4682 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4683
4684         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4685         bool.
4686         (bpstat_what): Use false instead of 0.
4687
4688 2019-07-09  Pedro Alves  <palves@redhat.com>
4689
4690         * break-catch-throw.c (is_exception_catchpoint): New.
4691         * breakpoint.c (print_one_breakpoint_location): New parameter
4692         'raw_loc'.  Handle it.  Use
4693         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4694         looking at the breakpoint's type.
4695         (print_one_breakpoint): If handling "maint info breakpoints", also
4696         print locations of exception catchpoints.
4697         * breakpoint.h (is_exception_catchpoint): Declare.
4698
4699 2019-07-09  Pedro Alves  <palves@redhat.com>
4700
4701         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4702         "addr" field.
4703         (allocate_location_exception_catchpoint): New.
4704         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4705         (initialize_throw_catchpoint_ops): Install
4706         allocate_location_exception_catchpoint as allocate_location
4707         method.
4708         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4709         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4710         bp_loc_other.
4711         (breakpoint_address_is_meaningful): Delete.
4712         (bl_address_is_meaningful): New.
4713         (breakpoint_locations_match): Adjust comment.
4714         (bp_location_from_bp_type): New, factored out of...
4715         (bp_location::bp_location(breakpoint *)): ... this.
4716         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4717         factored out of...
4718         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4719         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4720         breakpoint_address_is_meaningful.
4721         (bp_locations_compare): Adjust comment.
4722         (update_global_location_list): Use bl_address_is_meaningful
4723         instead of breakpoint_address_is_meaningful.
4724         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4725         explicit.
4726         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4727         * python/py-breakpoint.c (bppy_get_location): No longer check
4728         whether location is null.
4729
4730 2019-07-09  Pedro Alves  <palves@redhat.com>
4731
4732         PR c++/15468
4733         * breakpoint.c (print_one_breakpoint_location): Remove
4734         single-location assert.
4735
4736 2019-07-09  Tom Tromey  <tom@tromey.com>
4737
4738         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4739         * configure: Rebuild.
4740         * configure.ac: Change common to gdbsupport.
4741         * gdbsupport: Rename from common.
4742         * acinclude.m4: Change common to gdbsupport.
4743         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4744         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4745         gdbsupport.
4746         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4747         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4748         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4749         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4750         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4751         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4752         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4753         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4754         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4755         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4756         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4757         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4758         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4759         coff-pe-read.c, command.h, compile/compile-c-support.c,
4760         compile/compile-c.h, compile/compile-cplus-symbols.c,
4761         compile/compile-cplus-types.c, compile/compile-cplus.h,
4762         compile/compile-loc2c.c, compile/compile.c, completer.c,
4763         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4764         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4765         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4766         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4767         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4768         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4769         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4770         features/aarch64-core.c, features/aarch64-fpu.c,
4771         features/aarch64-pauth.c, features/aarch64-sve.c,
4772         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4773         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4774         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4775         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4776         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4777         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4778         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4779         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4780         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4781         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4782         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4783         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4784         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4785         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4786         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4787         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4788         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4789         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4790         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4791         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4792         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4793         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4794         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4795         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4796         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4797         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4798         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4799         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4800         minsyms.c, mips-linux-tdep.c, namespace.h,
4801         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4802         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4803         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4804         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4805         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4806         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4807         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4808         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4809         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4810         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4811         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4812         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4813         procfs.c, producer.c, progspace.h, psymtab.h,
4814         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4815         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4816         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4817         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4818         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4819         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4820         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4821         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4822         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4823         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4824         target-memory.c, target.c, target.h, target/waitstatus.c,
4825         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4826         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4827         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4828         unittests/array-view-selftests.c,
4829         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4830         unittests/common-utils-selftests.c,
4831         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4832         unittests/format_pieces-selftests.c,
4833         unittests/function-view-selftests.c,
4834         unittests/lookup_name_info-selftests.c,
4835         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4836         unittests/mkdir-recursive-selftests.c,
4837         unittests/observable-selftests.c,
4838         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4839         unittests/parse-connection-spec-selftests.c,
4840         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4841         unittests/scoped_fd-selftests.c,
4842         unittests/scoped_mmap-selftests.c,
4843         unittests/scoped_restore-selftests.c,
4844         unittests/string_view-selftests.c, unittests/style-selftests.c,
4845         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4846         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4847         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4848         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4849         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4850         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4851
4852 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4853
4854         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4855         bool value.
4856         (decode_digits_ordinary): Set explicit_line field in sal.
4857         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4858         symtab_and_line that was set on an explicit line number in
4859         assembler code.  Do always update the recorded symtab and line if
4860         we do skip the prologue.
4861
4862 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4863
4864         * breakpoint.c (set_breakpoint_location_function): Remove
4865         explicit_loc parameter.
4866         (momentary_breakpoint_from_master): Update call to
4867         set_breakpoint_location_function.
4868         (add_location_to_breakpoint): Likewise.
4869
4870 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4871
4872         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4873         required features based on default bfd type when no specific bfd
4874         is present.
4875
4876 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4877
4878         * NEWS: Mention that GDB printf and eval commands can now print
4879         C-style and Ada-style convenience var strings without
4880         calling the inferior.
4881         * printcmd.c (printf_c_string): Locally print GDB internal var
4882         instead of transiting via the inferior.
4883         (printf_wide_c_string): Likewise.
4884
4885 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4886
4887         PR breakpoints/25011
4888         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4889
4890 2019-07-04  Tom Tromey  <tom@tromey.com>
4891
4892         PR tui/24724:
4893         * tui/tui-winsource.c (tui_clear_source_content): Update.
4894         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4895         (tui_update_breakpoint_info): Update.
4896         (tui_set_exec_info_content): Update.
4897         * tui/tui-source.c (tui_set_source_content_nil): Update.
4898         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4899         has_break.
4900         * tui/tui-data.h (enum tui_bp_flag): New.
4901         (tui_bp_flags): New enum flags type.
4902         (struct tui_source_element) <break_mode>: Change type.  Rename
4903         from has_break.
4904         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4905         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4906         constants.
4907         * tui/tui-winsource.h: Fix comment.
4908
4909 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4910
4911         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4912         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4913         (store_fpregs_to_thread)
4914         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4915         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4916         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4917         (IWMMXT_REGS_SIZE): Add define.
4918         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4919         (fetch_vfp_regs, store_vfp_regs)
4920         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4921         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4922
4923 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4924
4925         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4926         defines.
4927         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4928         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4929         (ARM_INT_REGISTER_SIZE): ...to this.
4930         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4931         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4932         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4933         (arm_linux_collect_gregset, supply_nwfpe_register)
4934         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4935         defines.
4936         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4937         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4938         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4939         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4940         (arm_return_in_memory, arm_store_return_value)
4941         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4942         (arm_record_ld_st_multiple): Likewise.
4943         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4944         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4945
4946 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4947
4948         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4949         AARCH64_DISPLACED_MODIFIED_INSNS.
4950         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4951         (aarch64_displaced_step_copy_insn): Likewise.
4952         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4953         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4954         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4955         ARM_DISPLACED_MODIFIED_INSNS.
4956         * arm-tdep.c (arm_gdbarch_init): Likewise.
4957         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4958         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4959         (struct arm_displaced_step_closure): Use
4960         ARM_DISPLACED_MODIFIED_INSNS.
4961
4962 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4963
4964         * features/Makefile: Remove unused xml files.
4965         * features/aarch64.xml: Remove.
4966         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4967         * features/i386/amd64-avx-avx512.xml: Remove.
4968         * features/i386/amd64-avx-linux.xml: Remove.
4969         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4970         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4971         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4972         * features/i386/amd64-avx-mpx.xml: Remove.
4973         * features/i386/amd64-avx.xml: Remove.
4974         * features/i386/amd64-linux.xml: Remove.
4975         * features/i386/amd64-mpx-linux.xml: Remove.
4976         * features/i386/amd64-mpx.xml: Remove.
4977         * features/i386/amd64.xml: Remove.
4978         * features/i386/i386-avx-avx512-linux.xml: Remove.
4979         * features/i386/i386-avx-avx512.xml: Remove.
4980         * features/i386/i386-avx-linux.xml: Remove.
4981         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4982         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4983         * features/i386/i386-avx-mpx-linux.xml: Remove.
4984         * features/i386/i386-avx-mpx.xml: Remove.
4985         * features/i386/i386-avx.xml: Remove.
4986         * features/i386/i386-linux.xml: Remove.
4987         * features/i386/i386-mmx-linux.xml: Remove.
4988         * features/i386/i386-mmx.xml: Remove.
4989         * features/i386/i386-mpx-linux.xml: Remove.
4990         * features/i386/i386-mpx.xml: Remove.
4991         * features/i386/i386.xml: Remove.
4992         * features/i386/x32-avx-avx512-linux.xml: Remove.
4993         * features/i386/x32-avx-linux.xml: Remove.
4994         * features/i386/x32-linux.xml: Remove.
4995
4996 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4997
4998         * regformats/aarch64.dat: Remove.
4999         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5000         * regformats/i386/amd64-avx-linux.dat: Remove.
5001         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5002         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5003         * regformats/i386/amd64-linux.dat: Remove.
5004         * regformats/i386/amd64-mpx-linux.dat: Remove.
5005         * regformats/i386/amd64.dat: Remove.
5006         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5007         * regformats/i386/i386-avx-linux.dat: Remove.
5008         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5009         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5010         * regformats/i386/i386-linux.dat: Remove.
5011         * regformats/i386/i386-mmx-linux.dat: Remove.
5012         * regformats/i386/i386-mpx-linux.dat: Remove.
5013         * regformats/i386/i386.dat: Remove.
5014         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5015         * regformats/i386/x32-avx-linux.dat: Remove.
5016         * regformats/i386/x32-linux.dat: Remove.
5017
5018 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5019
5020         * aarch64-tdep.c: Remove xml self tests.
5021         * amd64-linux-tdep.c: Likewise.
5022         * amd64-tdep.c: Likewise.
5023         * i386-linux-tdep.c: Likewise.
5024         * i386-tdep.c: Likewise.
5025
5026 2019-07-03  Pedro Alves  <palves@redhat.com>
5027
5028         PR cli/24732
5029         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5030         (pipe_cmd_option_defs): New.
5031         (make_pipe_cmd_options_def_group): New.
5032         (pipe_command): Use gdb::option::process_options.
5033         (pipe_command_completer): New function.
5034         (_initialize_cli_cmds): Install completer for "pipe" command.
5035
5036 2019-07-03  Pedro Alves  <palves@redhat.com>
5037
5038         * cli/cli-option.c (union option_value) <string>: New field.
5039         (struct option_def_and_value): Add ctor, move ctor, dtor and
5040         use DISABLE_COPY_AND_ASSIGN.
5041         (option_def_and_value::clear_value): New.
5042         (parse_option, save_option_value_in_ctx, get_val_type_str)
5043         (add_setshow_cmds_for_options): Handle var_string.
5044         * cli-option.h (union option_def::var_address) <string>: New
5045         field.
5046         (struct string_option_def): New.
5047         * maint-test-options.c (struct test_options_opts): Add default
5048         ctor and use DISABLE_COPY_AND_ASSIGN.
5049         <string_opt>: New field.
5050         (test_options_opts::~test_options_opts): New.
5051         (test_options_opts::dump): Also dump "-string".
5052         (test_options_option_defs): Install "string.
5053
5054 2019-07-03  Pedro Alves  <palves@redhat.com>
5055
5056         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5057         option_value with a null enumeration.
5058         (complete_options): Save the option values in the context.
5059         (save_option_value_in_ctx): New, factored out from ...
5060         (process_options): ... here.
5061         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5062         of the function.
5063         * maint-test-options.c (test_options_opts::dump): New, factored
5064         out from ...
5065         (maintenance_test_options_command_mode): ... here.
5066         (maintenance_test_options_command_completion_result): Delete.
5067         (maintenance_test_options_command_completion_text): Update
5068         comment.
5069         (maintenance_show_test_options_completion_result): Change
5070         prototype.  Just print
5071         maintenance_test_options_command_completion_text.
5072         (save_completion_result): New.
5073         (maintenance_test_options_completer_mode): Pass options context to
5074         complete_options, and then save a dump.
5075         (_initialize_maint_test_options): Use add_cmd to install "maint
5076         show test-options-completion-result".
5077
5078 2019-07-03  Pedro Alves  <palves@redhat.com>
5079
5080         * NEWS (New commands): Mention "with" and "maint with".
5081         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5082         (with_command, with_command_completer): New.
5083         (pipe_command): Adjust to new repeat_previous
5084         interface.
5085         (_initialize_cli_cmds): Install the "with" command and its "w"
5086         alias.
5087         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5088         declarations.
5089         * cli/cli-setshow.c (parse_cli_var_uinteger)
5090         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5091         argument strings for all var_types.
5092         (get_setshow_command_value_string): New, factored out from ...
5093         (do_show_command): ... this.
5094         * cli/cli-setshow.h: Include <string>.
5095         (get_setshow_command_value_string): Declare.
5096         * command.h (repeat_previous): Now returns const char *.  Adjust
5097         comment.
5098         * maint.c: Include "cli/cli-cmds.h".
5099         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5100         (_initialize_maint_cmds): Register the "maintenance with" command.
5101         * top.c (repeat_previous): Move bits from pipe_command here:
5102         Return the saved command line, if any; error out if there's no
5103         command to relaunch.
5104
5105 2019-07-03  Pedro Alves  <palves@redhat.com>
5106
5107         * NEWS (New commands): Mention "maint set/show test-settings"
5108         instead of "maint test-settings".
5109         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5110         (maintenance_test_settings_set_list): Rename to ...
5111         (maintenance_set_test_settings_list): ... this.
5112         (maintenance_test_settings_show_list): Rename to  ...
5113         (maintenance_show_test_settings_list): ... this.
5114         (maintenance_test_settings_cmd): Delete.
5115         (maintenance_test_settings_set_cmd): ...
5116         (maintenance_set_test_settings_cmd): ... this.
5117         (maintenance_test_settings_show_cmd): ...
5118         (maintenance_show_test_settings_cmd): ... this.
5119         (maintenance_test_settings_show_value_cmd):
5120         (maintenance_show_test_settings_value_cmd): ... this.
5121         (_initialize_maint_test_settings): No longer install the "maint
5122         test-settings" prefix command.  Rename "maint test-settings set"
5123         to "maint set test-settings", and "maint test-settings show" to
5124         "maint show test-settings".  Adjust all subcommands.
5125
5126 2019-07-03  Pedro Alves  <palves@redhat.com>
5127
5128         * maint-test-settings.c: Fix file's intro comment.  Replace all
5129         references to "test-options" with references to "test-settings",
5130         in comments.
5131
5132 2019-07-03  Pedro Alves  <palves@redhat.com>
5133
5134         * maint-test-settings.c (maintenance_test_settings_xxx)
5135         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5136         New.
5137         (maintenance_test_settings_enums): Use them.
5138         (maintenance_test_settings_enum): Default to
5139         maintenance_test_settings_xxx.
5140         (_initialize_maint_test_settings): Initialize
5141         MAINTENANCE_TEST_SETTINGS_FILENAME.
5142
5143 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5144
5145         * breakpoint.h (remove_breakpoints_inf): Change return type to
5146         void, move function documentation here.
5147         * breakpoint.c (remove_breakpoints_inf): Change return type to
5148         void, move function documentation to header.
5149
5150 2019-07-02  Pedro Alves  <palves@redhat.com>
5151
5152         * NEWS (Completion improvements): Mention "info threads".
5153         * thread.c (struct info_threads_opts, info_threads_option_defs)
5154         (make_info_threads_options_def_group): New.
5155         (info_threads_command): Use gdb::option::process_options.
5156         (info_threads_command_completer): New.
5157         (_initialize_thread): Use gdb::option::build_help to build the
5158         help text for "info threads".
5159
5160 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5161
5162         * defs.h (generic_load): Move from here...
5163         * symfile.h (generic_load): ... to here.  Rename name parameter
5164         to args.
5165         * symfile.c (generic_load): Add comment.
5166
5167 2019-07-01  Tom Tromey  <tromey@adacore.com>
5168
5169         * dwarf2read.c
5170         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5171         declaration of without_params.  Fix formatting.
5172
5173 2019-07-01  Tom Tromey  <tromey@adacore.com>
5174
5175         * ada-exp.y (find_primitive_type): Update.
5176         * ada-lang.h (ada_lookup_symbol): Update.
5177         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5178         parameter.
5179         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5180
5181 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5182
5183         PR breakpoints/24541
5184         * gdbarch.c: Regenerate.
5185         * gdbarch.h: Regenerate.
5186         * gdbarch.sh: Add 'stap_adjust_register'.
5187         * i386-tdep.c: Include '<unordered_set>'.
5188         (i386_stap_adjust_register): New function.
5189         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5190         * stap-probe.c (stap_parse_register_operand): Call
5191         'gdbarch_stap_adjust_register'.
5192
5193 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5194
5195         PR python/24742
5196         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5197         * python/python.c (do_start_initialization): Use 'xmalloc'
5198         instead of 'PyMem_Malloc'.
5199
5200 2019-06-28  Tom Tromey  <tromey@adacore.com>
5201
5202         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5203         for Ada.
5204
5205 2019-06-27  Tom Tromey  <tromey@adacore.com>
5206
5207         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5208         objfile_key.
5209         (arm_find_mapping_symbol, arm_record_special_symbol)
5210         (_initialize_arm_tdep): Update.
5211         (arm_objfile_data_free): Remove.
5212
5213 2019-06-27  Tom Tromey  <tromey@adacore.com>
5214
5215         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5216         to cp_print_static_field.
5217
5218 2019-06-26  Tom Tromey  <tromey@adacore.com>
5219
5220         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5221         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5222         declare.
5223
5224 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5225
5226         * features/aarch64-core.c (create_feature_aarch64_core):
5227         Regenerate.
5228         * features/aarch64-core.xml: Add cpsr flags.
5229
5230 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5231
5232         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5233         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5234
5235 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5236
5237         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5238         field.
5239         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5240         use.
5241         (arm_record_special_symbol): Don't insert new symbol in sorted
5242         position, push it at the end.
5243
5244 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5245
5246         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5247         (arm_mapping_symbol_s): Remove.
5248         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5249         (arm_mapping_symbol_vec): New typedef.
5250         (struct arm_per_objfile): Add constructor.
5251         <section_maps>: Change type to
5252         std::unique_ptr<arm_mapping_symbol_vec[]>.
5253         (arm_compare_mapping_symbols): Remove.
5254         (arm_find_mapping_symbol): Adjust to section_maps type change.
5255         (arm_objfile_data_free): Call delete on arm_per_objfile.
5256         (arm_record_special_symbol): Adjust to section_maps type change.
5257         Allocate arm_per_objfile with new.
5258
5259 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5260
5261         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5262         with the command prefix.
5263
5264 2019-06-25  Tom Tromey  <tom@tromey.com>
5265
5266         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5267         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5268
5269 2019-06-25  Tom Tromey  <tom@tromey.com>
5270
5271         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5272         type.
5273         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5274         protected.
5275
5276 2019-06-25  Tom Tromey  <tom@tromey.com>
5277
5278         * tui/tui-winsource.c
5279         (tui_source_window_base::set_is_exec_point_at): Add check against
5280         LOA_ADDRESS.
5281
5282 2019-06-25  Tom Tromey  <tom@tromey.com>
5283
5284         * tui/tui-source.c (tui_set_source_content): Don't check before
5285         xfree.
5286         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5287
5288 2019-06-25  Tom Tromey  <tom@tromey.com>
5289
5290         * tui/tui-winsource.h (tui_update_source_window_as_is)
5291         (tui_alloc_source_buffer, tui_line_is_displayed)
5292         (tui_addr_is_displayed): Change type of win_info.
5293         * tui/tui-winsource.c (tui_update_source_window_as_is)
5294         (tui_clear_source_content, tui_show_source_line)
5295         (tui_show_source_content, tui_source_window_base::refill)
5296         (tui_source_window_base::set_is_exec_point_at)
5297         (tui_source_window_base::set_is_exec_point_at)
5298         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5299         (tui_alloc_source_buffer, tui_line_is_displayed)
5300         (tui_addr_is_displayed): Change type of win_info.  Update.
5301         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5302         (tui_source_window_base::do_make_visible_with_new_height):
5303         Update.
5304         * tui/tui-source.c (tui_set_source_content)
5305         (tui_set_source_content_nil)
5306         (tui_source_window::do_scroll_vertical): Update.
5307         * tui/tui-layout.c (show_layout): Update.
5308         * tui/tui-disasm.c (tui_set_disassem_content)
5309         (tui_disasm_window::do_scroll_vertical): Update.
5310         * tui/tui-data.h (tui_win_content): Remove.
5311         (struct tui_gen_win_info) <content, content_size>: Remove.
5312         (struct tui_source_element): Add initializers and destructor.
5313         (union tui_which_element, struct tui_win_element): Remove.
5314         (struct tui_source_window_base) <content>: New field.
5315         (struct tui_data_window): Remove destructor.
5316         (tui_alloc_content, tui_free_win_content)
5317         (tui_free_all_source_wins_content): Don't declare.
5318         * tui/tui-data.c (tui_initialize_static_data): Update.
5319         (init_content_element, tui_alloc_content): Remove.
5320         (~tui_gen_win_info): Update.
5321         (~tui_data_window, tui_free_all_source_wins_content)
5322         (tui_free_win_content, free_content, free_content_elements):
5323         Remove.
5324
5325 2019-06-25  Tom Tromey  <tom@tromey.com>
5326
5327         * tui/tui-winsource.h (tui_clear_source_content)
5328         (tui_erase_source_content, tui_show_source_content): Change type
5329         of win_info.
5330         * tui/tui-winsource.c (tui_clear_source_content)
5331         (tui_erase_source_content, tui_show_source_content): Change type
5332         of win_info.
5333         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5334         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5335         win_info.
5336         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5337         win_info.
5338         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5339
5340 2019-06-25  Tom Tromey  <tom@tromey.com>
5341
5342         * tui/tui-winsource.c (tui_clear_source_content)
5343         (tui_source_window_base::set_is_exec_point_at): Update.
5344         * tui/tui-source.c (tui_set_source_content_nil): Update.
5345         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5346         a bool.
5347         * tui/tui-data.c (init_content_element): Update.
5348
5349 2019-06-25  Tom Tromey  <tom@tromey.com>
5350
5351         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5352         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5353         * tui/tui-layout.c (init_and_make_win): Update.
5354         * tui/tui.h (enum tui_win_type): Update.
5355         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5356         tui_win_is_auxillary.
5357         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5358         tui_win_is_auxillary.
5359
5360 2019-06-25  Tom Tromey  <tom@tromey.com>
5361
5362         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5363         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5364         (tui_delete_data_content_windows, tui_display_all_data)
5365         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5366         Update.
5367         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5368         * tui/tui-regs.c (tui_last_regs_line_no)
5369         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5370         (tui_show_registers): Update.
5371         (tui_show_register_group): Return void.  Update.
5372         (tui_display_registers_from, tui_display_reg_element_at_line)
5373         (tui_display_registers_from_line, tui_check_register_values):
5374         Update.
5375         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5376         member.
5377         (struct tui_data_window) <regs_content>: Now a std::vector.
5378         <regs_content_count>: Remove.
5379         (tui_add_content_elements, tui_free_data_content): Don't declare.
5380         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5381         (init_content_element): Remove DATA_WIN case.  Add assert.
5382         (tui_add_content_elements): Remove.
5383         (tui_data_window): Update.
5384         (tui_free_data_content): Remove.
5385         (free_content_elements): Remove DATA_WIN case.
5386
5387 2019-06-25  Tom Tromey  <tom@tromey.com>
5388
5389         * tui/tui-data.c (tui_data_item_window): Update.
5390         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5391         * tui/tui-windata.c (tui_display_all_data)
5392         (tui_display_data_from_line): Update.
5393         (tui_check_data_values): Remove.
5394         * tui/tui-regs.c (tui_show_register_group)
5395         (tui_display_reg_element_at_line): Update.
5396         * tui/tui-hooks.c (tui_register_changed)
5397         (tui_refresh_frame_and_register_information): Call
5398         tui_check_register_values.
5399         * tui/tui-data.h (struct tui_data_window) <data_content,
5400         data_content_count, data_type>: Remove.
5401         (enum tui_data_type): Remove.
5402
5403         * tui/tui-data.c (tui_data_window::clear_detail)
5404         (~tui_data_window): Update.
5405
5406 2019-06-25  Tom Tromey  <tom@tromey.com>
5407
5408         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5409         declare.
5410         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5411         Rename from tui_first_data_item_displayed.  Update.
5412         (tui_data_window::refresh_all)
5413         (tui_data_window::do_scroll_vertical): Update.
5414         * tui/tui-data.h (struct tui_data_window)
5415         <first_data_item_displayed>: Declare new method.
5416
5417 2019-06-25  Tom Tromey  <tom@tromey.com>
5418
5419         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5420         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5421         contents...
5422         (tui_initialize_static_data): ...here.
5423
5424 2019-06-25  Tom Tromey  <tom@tromey.com>
5425
5426         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5427         (tui_display_registers_from, tui_check_register_values): Update.
5428         (tui_display_register): Remove win_info parameter; update.
5429         (tui_get_register): Change type of parameters.
5430         * tui/tui-data.h (struct tui_data_element): Remove.
5431         (union tui_which_element) <data>: Remove.
5432         <data_window>: Change type.
5433         (struct tui_data_item_window): New.
5434         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5435         case.  Add assert.
5436         (~tui_data_item_window): New destructor.
5437         (free_content_elements): Remove DATA_ITEM_WIN case.
5438
5439 2019-06-25  Tom Tromey  <tom@tromey.com>
5440
5441         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5442         Remove.
5443
5444 2019-06-25  Tom Tromey  <tom@tromey.com>
5445
5446         * tui/tui-data.h (struct tui_command_element): Remove.
5447         (union tui_which_element) <command>: Remove.
5448         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5449         assert.
5450         (free_content_elements): Remove CMD_WIN case.
5451
5452 2019-06-25  Tom Tromey  <tom@tromey.com>
5453
5454         * tui/tui-layout.c (tui_set_layout): Update.
5455         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5456         * tui/tui-data.c (layout_def): Update.
5457
5458 2019-06-25  Tom Tromey  <tom@tromey.com>
5459
5460         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5461         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5462         (tui_source_window_base::set_new_height): Update.
5463         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5464         Update.
5465         (tui_set_locator_fullname, tui_set_locator_info)
5466         (tui_show_frame_info): Update.
5467         * tui/tui-source.c (tui_set_source_content)
5468         (tui_source_is_displayed): Update.
5469         * tui/tui-layout.c (show_source_disasm_command, show_data)
5470         (show_source_or_disasm_and_command): Update.
5471         * tui/tui-disasm.c (tui_set_disassem_content)
5472         (tui_get_begin_asm_address): Update.
5473         * tui/tui-data.h (struct tui_locator_element): Remove.
5474         (union tui_which_element) <locator>: Remove.
5475         (struct tui_locator_window): New.
5476         (tui_locator_win_info_ptr): Change return type.
5477         * tui/tui-data.c (_locator): Change type.
5478         (tui_locator_win_info_ptr): Change return type.
5479         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5480         (tui_alloc_content): Add assert.
5481
5482 2019-06-25  Tom Tromey  <tom@tromey.com>
5483
5484         * tui/tui-winsource.c
5485         (tui_exec_info_window::maybe_allocate_content): New method.
5486         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5487         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5488         (make_source_or_disasm_window): Add cast.
5489         * tui/tui-data.h (union tui_which_element) <simple_string>:
5490         Remove.
5491         (struct tui_source_info): New.
5492         (struct tui_source_window_base) <execution_info>: Change type.
5493         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5494         case, and add assert.
5495         (tui_alloc_content): Add assert.
5496
5497 2019-06-25  Tom Tromey  <tom@tromey.com>
5498
5499         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5500         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5501         * tui/tui-data.c (tui_alloc_win_info): Remove.
5502
5503 2019-06-25  Tom Tromey  <tom@tromey.com>
5504
5505         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5506         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5507         can_highlight.
5508
5509 2019-06-25  Tom Tromey  <tom@tromey.com>
5510
5511         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5512         make_visible_with_new_height method.
5513         (tui_win_info::make_visible_with_new_height): New method.
5514         (tui_source_window_base::do_make_visible_with_new_height)
5515         (tui_data_window::do_make_visible_with_new_height)
5516         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5517         (make_visible_with_new_height): Remove.
5518         (tui_resize_all, tui_adjust_win_heights): Use
5519         make_visible_with_new_height method.
5520         * tui/tui-data.h (struct tui_win_info)
5521         <do_make_visible_with_new_height, make_visible_with_new_height>:
5522         New methods.
5523         (struct tui_source_window_base, struct tui_data_window)
5524         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5525         methods.
5526
5527 2019-06-25  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5530         method.
5531         (update_tab_width): Call update_tab_width method.
5532         * tui/tui-data.h (struct tui_win_info)
5533         (struct tui_source_window_base) <update_tab_width>: New methods.
5534
5535 2019-06-25  Tom Tromey  <tom@tromey.com>
5536
5537         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5538         parameter.
5539         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5540         parameter.
5541         (tui_gen_win_info::make_visible): Update.
5542         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5543         parameter.
5544         * tui/tui-data.h (enum tui_box): New enum.
5545         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5546
5547 2019-06-25  Tom Tromey  <tom@tromey.com>
5548
5549         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5550         init_and_make_win for EXEC_INFO_WIN.
5551         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5552         longer inline.
5553         (struct tui_win_info) <~tui_win_info>: Inline.
5554         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5555         Don't declare.
5556         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5557         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5558         Remove.
5559         (tui_initialize_static_data): Update.
5560         (~tui_gen_win_info): Handle more cleanup here.
5561         (~tui_source_window_base): Delete "execution_info".
5562         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5563
5564 2019-06-25  Tom Tromey  <tom@tromey.com>
5565
5566         * tui/tui-layout.c (make_command_window): Don't set
5567         can_highlight.
5568         (show_source_disasm_command): Call the reset method.
5569         (show_data): Don't set can_highlight.  Call the reset method.
5570         (tui_gen_win_info::reset): Rename from init_gen_win_info
5571         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5572         (show_source_or_disasm_and_command): Call the reset method.
5573         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5574         (struct tui_cmd_window): Set can_highlight.
5575
5576 2019-06-25  Tom Tromey  <tom@tromey.com>
5577
5578         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5579         from make_visible.
5580         (tui_make_visible, tui_make_invisible): Rewrite.
5581         (tui_win_info::make_visible): Remove.
5582         (tui_source_window_base::make_visible): Update.
5583         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5584         method.  Moved from...
5585         (struct tui_win_info) <make_visible>: ...here.
5586
5587 2019-06-25  Tom Tromey  <tom@tromey.com>
5588
5589         * tui/tui-winsource.c
5590         (tui_source_window_base::do_scroll_horizontal): Remove direction
5591         parameter.
5592         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5593         direction parameter.
5594         * tui/tui-win.c (tui_win_info::forward_scroll)
5595         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5596         (tui_win_info::right_scroll): Update.
5597         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5598         direction parameter.
5599         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5600         direction parameter.
5601         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5602         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5603         Remove direction parameter.
5604         (struct tui_source_window_base, struct tui_source_window)
5605         (struct tui_disasm_window, struct tui_data_window)
5606         (struct tui_cmd_window): Update.
5607
5608 2019-06-25  Tom Tromey  <tom@tromey.com>
5609
5610         * tui/tui-winsource.h (tui_set_exec_info_content)
5611         (tui_show_exec_info_content, tui_erase_exec_info_content)
5612         (tui_clear_exec_info_content, tui_update_exec_info): Change
5613         argument to tui_source_window_base.
5614         * tui/tui-winsource.c (tui_set_exec_info_content)
5615         (tui_show_exec_info_content, tui_erase_exec_info_content)
5616         (tui_clear_exec_info_content, tui_update_exec_info): Change
5617         argument to tui_source_window_base.
5618
5619 2019-06-25  Tom Tromey  <tom@tromey.com>
5620
5621         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5622         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5627         check.
5628
5629 2019-06-25  Tom Tromey  <tom@tromey.com>
5630
5631         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5632         type to void.
5633         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5634         type to void.
5635         * tui/tui-source.c (tui_set_source_content): Update.
5636         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5637
5638 2019-06-25  Tom Tromey  <tom@tromey.com>
5639
5640         * tui/tui-win.c (window_name_completer, tui_set_focus)
5641         (tui_all_windows_info): Use name method.
5642         * tui/tui-data.h (struct tui_gen_win_info)
5643         (struct tui_source_window, struct tui_disasm_window)
5644         (struct tui_data_window, struct tui_cmd_window) <name>: New
5645         method.
5646         (tui_win_name): Don't declare.
5647         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5648         (tui_win_name): Remove.
5649
5650 2019-06-25  Tom Tromey  <tom@tromey.com>
5651
5652         * tui/tui-winsource.h (tui_update_source_window)
5653         (tui_update_source_window_as_is): Change parameter type.
5654         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5655         to be a tui_source_window_base.
5656         (tui_update_source_window_as_is): Likewise.
5657         * tui/tui-win.c (make_visible_with_new_height): Update.
5658
5659 2019-06-25  Tom Tromey  <tom@tromey.com>
5660
5661         * tui/tui-winsource.c (tui_erase_source_content)
5662         (tui_show_source_content, tui_show_exec_info_content)
5663         (tui_erase_exec_info_content): Use refresh_window method.
5664         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5665         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5666         from tui_refresh_win.
5667         (tui_data_window::refresh_window): New method.
5668         (tui_win_info::refresh, tui_source_window_base::refresh)
5669         (tui_refresh_all): Use refresh_window method.
5670         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5671         method.
5672         * tui/tui-regs.c (tui_display_register): Call refresh_window
5673         method.
5674         * tui/tui-layout.c (show_source_disasm_command)
5675         (show_source_or_disasm_and_command): Call refresh_window method.
5676         * tui/tui-data.h (struct tui_gen_win_info)
5677         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5678         New method.
5679
5680 2019-06-25  Tom Tromey  <tom@tromey.com>
5681
5682         * tui/tui.c (tui_rl_other_window, tui_enable)
5683         (tui_is_window_visible, tui_get_command_dimension): Update.
5684         * tui/tui-winsource.c (tui_update_source_window_as_is)
5685         (tui_clear_source_content, tui_erase_source_content)
5686         (tui_show_source_line, tui_source_window_base::refill)
5687         (tui_source_window_base::do_scroll_horizontal)
5688         (tui_source_window_base::set_is_exec_point_at)
5689         (tui_update_breakpoint_info, tui_set_exec_info_content)
5690         (tui_alloc_source_buffer, tui_line_is_displayed)
5691         (tui_addr_is_displayed): Update.
5692         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5693         (tui_check_and_display_highlight_if_needed)
5694         (tui_win_info::make_visible, tui_win_info::refresh)
5695         (tui_refresh_all): Update.
5696         * tui/tui-windata.c (tui_first_data_item_displayed)
5697         (tui_delete_data_content_windows, tui_erase_data_content)
5698         (tui_display_all_data, tui_data_window::refresh_all)
5699         (tui_check_data_values): Update.
5700         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5701         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5702         (tui_win_info::backward_scroll, tui_refresh_all_win)
5703         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5704         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5705         (tui_source_window_base::set_new_height)
5706         (tui_data_window::set_new_height)
5707         (make_invisible_and_set_new_height)
5708         (make_visible_with_new_height, new_height_ok)
5709         (parse_scrolling_args): Update.
5710         * tui/tui-stack.c (tui_show_frame_info): Update.
5711         * tui/tui-source.c (tui_set_source_content)
5712         (tui_set_source_content_nil, tui_source_is_displayed)
5713         (tui_source_window::do_scroll_vertical): Update.
5714         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5715         (tui_display_registers_from, tui_display_reg_element_at_line)
5716         (tui_check_register_values, tui_reg_command): Update.
5717         * tui/tui-layout.c (tui_default_win_height)
5718         (show_source_disasm_command, show_data, init_and_make_win)
5719         (show_source_or_disasm_and_command): Update.
5720         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5721         (tui_redisplay_readline, tui_mld_flush)
5722         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5723         (tui_getc): Update.
5724         * tui/tui-disasm.c (tui_set_disassem_content)
5725         (tui_disasm_window::do_scroll_vertical): Update.
5726         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5727         Now virtual.
5728         (struct tui_win_info): Derive from tui_gen_win_info.
5729         <~tui_win_info>: Mark as override.
5730         <generic>: Remove member.
5731         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5732         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5733         (~tui_data_window, ~tui_win_info)
5734         (tui_free_all_source_wins_content): Update.
5735         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5736
5737 2019-06-25  Tom Tromey  <tom@tromey.com>
5738
5739         * tui/tui-layout.c (init_and_make_win): Use new.
5740         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5741         destructor, initializers.
5742         (tui_alloc_generic_win_info): Don't declare.
5743         * tui/tui-data.c (_locator): Add argument to constructor.
5744         (source_win, disasm_win): New globals.
5745         (exec_info): Remove.
5746         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5747         Update.
5748         (tui_alloc_generic_win_info): Remove.
5749         (init_content_element): Use new.
5750         (tui_win_info::tui_win_info): Update.
5751         (free_content_elements) <case DATA_WIN>: Use delete.
5752
5753 2019-06-25  Tom Tromey  <tom@tromey.com>
5754
5755         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5756         * tui/tui-windata.c (tui_first_data_item_displayed)
5757         (tui_delete_data_content_windows): Update.
5758         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5759         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5760         (tui_display_registers_from, tui_check_register_values): Update.
5761         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5762         pointer.
5763         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5764         window.
5765         (tui_free_data_content): Update.
5766         (free_content_elements) <case DATA_WIN>: Free the window.
5767
5768 2019-06-25  Tom Tromey  <tom@tromey.com>
5769
5770         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5771         Update.
5772         * tui/tui-layout.c (make_command_window)
5773         (show_source_disasm_command, show_data, init_and_make_win)
5774         (show_source_or_disasm_and_command): Update.
5775         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5776         method.
5777         <can_highight, is_highlighted>: Now bool.
5778         (tui_set_win_highlight): Don't declare.
5779         * tui/tui-data.c (tui_set_win_highlight): Remove.
5780
5781 2019-06-25  Tom Tromey  <tom@tromey.com>
5782
5783         * tui/tui-wingeneral.c (make_visible): Remove check of window
5784         type.
5785
5786 2019-06-25  Tom Tromey  <tom@tromey.com>
5787
5788         * tui/tui-win.c (tui_win_info::max_height)
5789         (tui_cmd_window::max_height): New methods.
5790         (new_height_ok): Call max_height.
5791         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5792         <max_height>: New method.
5793
5794 2019-06-25  Tom Tromey  <tom@tromey.com>
5795
5796         * tui/tui-win.c (tui_source_window_base::set_new_height)
5797         (tui_data_window::set_new_height): New methods.
5798         (make_invisible_and_set_new_height): Call set_new_height method.
5799         * tui/tui-data.h (struct tui_win_info)
5800         (struct tui_source_window_base, struct tui_data_window)
5801         <set_new_height>: New method.
5802
5803 2019-06-25  Tom Tromey  <tom@tromey.com>
5804
5805         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5806         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5807         tui_refresh_data_win.
5808         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5809         method.
5810         (tui_refresh_all_win): Call the refresh_all method.
5811         (tui_set_focus): Likewise.
5812         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5813         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5814         Likewise.
5815
5816 2019-06-25  Tom Tromey  <tom@tromey.com>
5817
5818         * tui/tui-winsource.h (tui_refill_source_window)
5819         (tui_set_is_exec_point_at): Don't declare.
5820         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5821         (tui_source_window_base::refill): Rename from
5822         tui_refill_source_window.
5823         (tui_source_window_base::do_scroll_horizontal): Update.
5824         (tui_source_window_base::set_is_exec_point_at): Rename from
5825         tui_set_is_exec_point_at.
5826         (tui_update_all_breakpoint_info): Update.
5827         * tui/tui-stack.c (tui_show_frame_info): Update.
5828         * tui/tui-layout.c (show_data): Add cast.
5829         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5830         * tui/tui-data.h (struct tui_source_window_base) <refill,
5831         set_is_exec_point_at>: New methods.
5832         (tui_source_windows, tui_add_to_source_windows): Update types.
5833         (tui_add_to_source_windows): Remove redundant declaration.
5834         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5835         (tui_source_windows): Change return type.
5836         (tui_clear_source_windows_detail): Update.
5837         (tui_add_to_source_windows): Change type of parameter.
5838         (tui_free_all_source_wins_content): Update.
5839
5840 2019-06-25  Tom Tromey  <tom@tromey.com>
5841
5842         * tui/tui-wingeneral.c (tui_win_info::refresh)
5843         (tui_source_window_base::refresh): New methods.
5844         (tui_refresh_all): Call the refresh method.
5845         * tui/tui-data.h (struct tui_win_info)
5846         (struct tui_source_window_base) <refresh>: New method.
5847
5848 2019-06-25  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui.h (tui_is_window_visible): Return bool.
5851         * tui/tui.c (tui_is_window_visible): Return bool.
5852         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5853         (tui_make_visible, tui_make_invisible)
5854         (tui_win_info::make_visible)
5855         (tui_source_window_base::make_visible, make_all_visible)
5856         (tui_make_all_visible, tui_make_all_invisible): Update.
5857         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5858         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5859         bool.
5860         (struct tui_win_info, struct tui_source_window_base)
5861         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5862         * tui/tui-data.c (tui_init_generic_part): Update.
5863
5864 2019-06-25  Tom Tromey  <tom@tromey.com>
5865
5866         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5867         (tui_source_window_base::make_visible): New methods.
5868         (make_all_visible): Make method call.
5869         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5870         (struct tui_source_window_base, struct tui_cmd_window): Override
5871         make_visible.
5872         (tui_win_is_source_type): Don't declare.
5873         * tui/tui-data.c (tui_win_is_source_type): Remove.
5874
5875 2019-06-25  Tom Tromey  <tom@tromey.com>
5876
5877         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5878         NULL check.
5879
5880 2019-06-25  Tom Tromey  <tom@tromey.com>
5881
5882         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5883         Inline constructor.  Add initializers for members.
5884         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5885         constructors; now inline in class.
5886
5887 2019-06-25  Tom Tromey  <tom@tromey.com>
5888
5889         * tui/tui-regs.c (tui_show_registers): Update.
5890         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5891         bool.
5892         * tui/tui-data.c (tui_data_window::clear_detail)
5893         (tui_data_window): Update.
5894
5895 2019-06-25  Tom Tromey  <tom@tromey.com>
5896
5897         * tui/tui-windata.c (tui_display_all_data)
5898         (tui_display_data_from_line, tui_display_data_from)
5899         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5900         Update.
5901         * tui/tui-regs.c (tui_last_regs_line_no)
5902         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5903         (tui_show_registers, tui_show_register_group)
5904         (tui_display_registers_from, tui_display_reg_element_at_line)
5905         (tui_display_registers_from_line, tui_check_register_values)
5906         (tui_reg_next, tui_reg_prev): Update.
5907         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5908         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5909         tui_data_window.
5910         (struct tui_win_info) <detail>: Remove.  Add new fields from
5911         tui_data_info.
5912         (TUI_DATA_WIN): Add cast.
5913         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5914         (~tui_data_window): Simplify.
5915
5916 2019-06-25  Tom Tromey  <tom@tromey.com>
5917
5918         * tui/tui-layout.c (show_source_disasm_command)
5919         (show_source_or_disasm_and_command): Update.
5920         * tui/tui-io.c (update_cmdwin_start_line)
5921         (tui_redisplay_readline): Update.
5922         * tui/tui-data.h (struct tui_command_info): Remove.
5923         (struct tui_win_info) <detail>: Remove command_info member.
5924         (struct tui_data_window) <start_line>: New member, from
5925         tui_command_info.
5926         (TUI_CMD_WIN): Add casts.
5927
5928 2019-06-25  Tom Tromey  <tom@tromey.com>
5929
5930         * tui/tui-winsource.c (tui_update_source_window)
5931         (tui_refill_source_window)
5932         (tui_source_window_base::do_scroll_horizontal)
5933         (tui_update_breakpoint_info, tui_set_exec_info_content)
5934         (tui_show_exec_info_content, tui_erase_exec_info_content)
5935         (tui_clear_exec_info_content): Update.
5936         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5937         Update.
5938         * tui/tui-win.c (make_invisible_and_set_new_height)
5939         (make_visible_with_new_height): Update.
5940         * tui/tui-source.c (tui_set_source_content)
5941         (tui_show_symtab_source): Update.
5942         * tui/tui-layout.c (extract_display_start_addr)
5943         (show_source_disasm_command, show_data)
5944         (make_source_or_disasm_window)
5945         (show_source_or_disasm_and_command): Update.
5946         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5947         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5948         "gdbarch".
5949         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5950         to tui_source_window_base.
5951         (struct tui_win_info) <detail>: Remove source_info member.
5952         (struct tui_source_window_base) <has_locator>: Inline.
5953         Move contents from tui_source_info; rename has_locator member to
5954         m_has_locator.
5955         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5956         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5957         header file.
5958         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5959         Simplify.
5960         (tui_free_all_source_wins_content): Cast to
5961         tui_source_window_base.
5962
5963 2019-06-25  Tom Tromey  <tom@tromey.com>
5964
5965         * tui/tui-win.c (make_invisible_and_set_new_height)
5966         (make_visible_with_new_height): Call has_locator method.
5967         * tui/tui-layout.c (show_source_disasm_command, show_data)
5968         (show_source_or_disasm_and_command): Update for bool change.
5969         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5970         (tui_win_info) <has_locator>: New method.
5971         (struct tui_source_window_base) <has_locator>: New method.
5972         (tui_win_has_locator): Don't declare.
5973         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5974         from tui_win_has_locator.
5975         (tui_source_window_base): Use false, not FALSE.
5976
5977 2019-06-25  Tom Tromey  <tom@tromey.com>
5978
5979         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5980         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5981         clear_detail method directly.
5982         (tui_clear_win_detail): Remove.
5983
5984 2019-06-25  Tom Tromey  <tom@tromey.com>
5985
5986         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5987         "this", not TUI_DISASM_WIN.
5988
5989 2019-06-25  Tom Tromey  <tom@tromey.com>
5990
5991         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5992         declare.
5993         * tui/tui-winsource.c
5994         (tui_source_window_base::do_scroll_horizontal): Rename from
5995         tui_horizontal_source_scroll.
5996         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5997         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5998         from tui_vertical_data_scroll.
5999         * tui/tui-win.h (tui_scroll): Don't declare.
6000         * tui/tui-win.c (tui_win_info::forward_scroll)
6001         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6002         (tui_win_info::right_scroll): Rename and update.
6003         (tui_scroll_forward_command, tui_scroll_backward_command)
6004         (tui_scroll_left_command, tui_scroll_right_command): Update.
6005         (tui_scroll): Remove.
6006         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6007         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6008         from tui_vertical_source_scroll.
6009         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6010         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6011         from tui_vertical_disassem_scroll.
6012         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6013         do_scroll_horizontal>: New methods.
6014         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6015         Likewise.
6016         (struct tui_source_window_base): Add do_scroll_horizontal.
6017         (struct tui_source_window, struct tui_disasm_window): Add
6018         do_scroll_vertical.
6019         (struct tui_data_window, struct tui_cmd_window): Add
6020         do_scroll_horizontal and do_scroll_vertical.
6021         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6022
6023 2019-06-25  Tom Tromey  <tom@tromey.com>
6024
6025         * tui/tui-data.h (struct tui_source_window_base): New struct.
6026         (struct tui_source_window): Derive from tui_source_window_base.
6027         (struct tui_disasm_window): New struct.
6028         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6029         from tui_source_window::clear_detail.
6030         (tui_source_window_base): Rename from tui_source_window.
6031         (~tui_source_window_base): Rename from ~tui_source_window.
6032         (tui_alloc_win_info): Create a tui_disasm_window.
6033
6034 2019-06-25  Tom Tromey  <tom@tromey.com>
6035
6036         * tui/tui-data.h (struct tui_source_window)
6037         (struct tui_data_window): Declare destructors.
6038         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6039         destructors.
6040         (tui_win_info): Simplify.
6041
6042 2019-06-25  Tom Tromey  <tom@tromey.com>
6043
6044         * tui/tui-winsource.c (tui_display_main)
6045         (tui_update_source_windows_with_addr)
6046         (tui_update_all_breakpoint_info): Update.
6047         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6048         (new_height_ok, parse_scrolling_args): Update.
6049         * tui/tui-stack.c (tui_show_frame_info): Update.
6050         * tui/tui-data.h (struct tui_list): Remove.
6051         (tui_source_windows): Return a reference to a std::vector.
6052         * tui/tui-data.c (source_windows): Now a std::vector.
6053         (tui_source_windows): Change return type.
6054         (tui_clear_source_windows): Rewrite.
6055         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6056         (tui_free_all_source_wins_content): Rewrite.
6057
6058 2019-06-25  Tom Tromey  <tom@tromey.com>
6059
6060         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6061         (struct tui_data_window, struct tui_cmd_window): Declare
6062         clear_detail method.
6063         * tui/tui-data.c (tui_source_window::clear_detail)
6064         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6065         methods.
6066         (tui_clear_win_detail): Simplify.
6067
6068 2019-06-25  Tom Tromey  <tom@tromey.com>
6069
6070         * tui/tui-layout.c (make_source_window, make_disasm_window)
6071         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6072         Return the new window.
6073         (show_source_disasm_command, show_data)
6074         (show_source_or_disasm_and_command): Update.
6075
6076 2019-06-25  Tom Tromey  <tom@tromey.com>
6077
6078         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6079         parameter.  Return the new window.
6080         (show_source_disasm_command): Update and remove NULL check.
6081         (show_source_or_disasm_and_command): Update.
6082
6083 2019-06-25  Tom Tromey  <tom@tromey.com>
6084
6085         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6086
6087 2019-06-25  Tom Tromey  <tom@tromey.com>
6088
6089         * tui/tui-data.h (struct tui_win_info): Make constructor
6090         protected.  Make destructor virtual.  Add initializers.
6091         (tui_source_window, tui_data_window, tui_cmd_window): New
6092         classes.
6093         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6094         constructor.  Add "type" parameter.
6095         (tui_source_window, tui_data_window, tui_cmd_window): New
6096         constructors.
6097         (tui_alloc_win_info): Instantiate the appropriate subclass.
6098
6099 2019-06-25  Tom Tromey  <tom@tromey.com>
6100
6101         * tui/tui-win.c (tui_resize_all): Use delete.
6102         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6103         destructor.
6104         (tui_free_window): Don't declare.
6105         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6106         Update.
6107
6108 2019-06-25  Tom Tromey  <tom@tromey.com>
6109
6110         * tui/tui-data.h (struct tui_win_info): Add constructor.
6111         * tui/tui-data.c (tui_alloc_win_info): Use new.
6112         (tui_free_window): Use delete.
6113
6114 2019-06-22  Tom Tromey  <tom@tromey.com>
6115
6116         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6117         declare.
6118         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6119
6120 2019-06-22  Tom Tromey  <tom@tromey.com>
6121
6122         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6123         declare.
6124         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6125
6126 2019-06-22  Tom de Vries  <tdevries@suse.de>
6127
6128         * dwarf2read.c (create_addrmap_from_aranges)
6129         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6130         instead of '%zu'.
6131
6132 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6133
6134         * dwarf2read.h (dwarf2_section_info_def): Remove.
6135         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6136         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6137         std::vector<dwarf2_section_info>.
6138         (struct dwo_file) <~dwo_file>: Remove.
6139         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6140         types field.
6141         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6142         (dwarf2_read_debug_names): Likewise.
6143         (create_debug_types_hash_table): Change parameter type to
6144         array_view, adjust code accordingly.
6145         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6146         (partial_die_info::fixup): Likewise.
6147         (determine_prefix): Likewise.
6148         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6149
6150 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6151
6152         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6153         gdb_bfd_ref_ptr.
6154         <~dwo_file>: Remove call to gdb_bfd_unref.
6155         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6156         gdb_bfd_ref_ptr::get.
6157
6158 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6159
6160         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6161         type to htab_up.
6162         * dwarf2read.c (struct dwo_file): Initialize fields.
6163         <~dwo_file>: New.
6164         (free_dwo_file): Remove, move content to ~dwo_file.
6165         (struct dwo_file_deleter): Remove.
6166         (dwo_file_up>: Remove custom deleter.
6167         (free_dwo_files): Remove.
6168         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6169         dwo_files.
6170         (process_skeletonless_type_units): Call unique_ptr::get.
6171         (allocate_dwo_file_hash_table): Add deleter to created hash
6172         table.  Change return type to htab_up.
6173         (lookup_dwo_file_slot): Don't memset dwo_file, call
6174         unique_ptr::get.
6175         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6176         (create_dwo_unit_in_dwp_v2): Likewise.
6177         (open_and_init_dwo_file): Likewise.
6178         (free_dwo_file_from_slot): Remove.
6179
6180 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6181
6182         * dwarf2read.h (struct dwarf2_section_info) <readin,
6183         is_virtual>: Change type to bool.
6184         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6185         true instead of 1.
6186
6187 2019-06-19  Tom Tromey  <tom@tromey.com>
6188
6189         * tui/tui-data.h (tui_init_content_element): Don't declare.
6190
6191 2019-06-19  Tom Tromey  <tom@tromey.com>
6192
6193         * tui/tui-data.h (tui_init_win_info): Don't declare.
6194
6195 2019-06-19  Tom de Vries  <tdevries@suse.de>
6196
6197         * dwarf2read.h (abstract_to_concrete): Change type to
6198         std::unordered_map<sect_offset, std::vector<sect_offset>,
6199         gdb::hash_enum<sect_offset>>.
6200
6201 2019-06-19  Tom Tromey  <tromey@adacore.com>
6202
6203         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6204         EVAL_AVOID_SIDE_EFFECTS specially.
6205
6206 2019-06-19  Tom Tromey  <tromey@adacore.com>
6207
6208         * source-cache.c (highlighter): New global.
6209         (source_cache::get_source_lines): Create a highlighter on demand.
6210
6211 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6212
6213         * defs.h (deprecated_interactive_hook): Delete declaration.
6214         * interps.c (clear_interpreter_hooks): Remove use of
6215         deprecated_interactive_hook.
6216         * top.c (deprecated_interactive_hook): Delete definition.
6217         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6218
6219 2019-06-18  Tom de Vries  <tdevries@suse.de>
6220
6221         PR gdb/24515
6222         * dwarf2read.h (abstract_to_concrete): Change type from
6223         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6224         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6225         * dwarf2read.c (read_variable): Update.
6226         (dwarf2_fetch_die_loc_sect_off): Update.
6227
6228 2019-06-17  Tom de Vries  <tdevries@suse.de>
6229
6230         PR gdb/24617
6231         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6232         accessing parent[parent_len - 1].
6233
6234 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6235
6236         PR gdb/24364
6237         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6238         call dtrace_process_dof with NULL dof.
6239
6240 2019-06-16  Tom de Vries  <tdevries@suse.de>
6241
6242         PR gdb/24445
6243         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6244
6245 2019-06-16  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6248         (make_all_visible): Use address of member.
6249
6250 2019-06-16  Tom Tromey  <tom@tromey.com>
6251
6252         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6253         (tui_free_window, free_content, free_content_elements): Remove
6254         unnecessary cast.
6255         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6256         cast.
6257         * tui/tui-regs.c (tui_show_register_group)
6258         (tui_display_registers_from, tui_display_reg_element_at_line):
6259         Remove unnecessary cast.
6260
6261 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6262
6263         * linux-nat.c (normal_mask): Delete.
6264         (_initialize_linux_nat): Don't initialise normal_mask.
6265
6266 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6267
6268         PR gdb/24445
6269         * dwarf-index-write.h (write_psymtabs_to_index): Add
6270         dwz_basename parameter.
6271         * dwarf-index-write.c (write_gdbindex): Move file writing to
6272         write_gdbindex_1.  Change return type void.
6273         (assert_file_size): Move up, remove filename parameter.
6274         (write_gdbindex_1): New function.
6275         (write_debug_names): Change return type to void, call
6276         assert_file_size.
6277         (struct index_wip_file): New struct.
6278         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6279         file logic to index_wip_file.  Write index for dwz file if
6280         needed.
6281         (save_gdb_index_command): Pass basename of dwz file, if present.
6282         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6283         build-id of dwz file, if present.
6284         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6285         (dwarf2_get_dwz_file): Likewise.
6286         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6287         (dwarf2_get_dwz_file): Likewise.
6288
6289 2019-06-16  Tom Tromey  <tom@tromey.com>
6290
6291         * coffread.c (process_coff_symbol): Use xstrdup.
6292         * value.c (create_internalvar): Use xstrdup.
6293
6294 2019-06-16  Tom Tromey  <tom@tromey.com>
6295
6296         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6297         * breakpoint.c (stopin_command, stopat_command)
6298         (until_break_command, decode_location_default): Remove unnecessary
6299         cast.
6300         * utils.c (subset_compare): Remove unnecessary cast.
6301         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6302         cast.
6303         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6304         cast.
6305         * infcmd.c (path_command): Remove unnecessary cast.
6306         * coffread.c (decode_type): Remove unnecessary cast.
6307         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6308         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6309         * tui/tui-stack.c (tui_show_locator_content)
6310         (tui_show_frame_info): Remove unnecessary cast.
6311         * tui/tui-win.c (tui_scroll_forward_command)
6312         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6313         (parse_scrolling_args): Remove unnecessary cast.
6314         * tui/tui-data.c (init_win_info, tui_del_window)
6315         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6316         (free_content_elements): Remove unnecessary cast.
6317         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6318         unnecessary cast.
6319         * tui/tui-source.c (tui_set_source_content)
6320         (tui_vertical_source_scroll): Remove unnecessary cast.
6321         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6322         cast.
6323         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6324         * tui/tui-regs.c (tui_display_registers_from)
6325         (tui_display_register): Remove unnecessary cast.
6326         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6327         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6328         (make_visible): Remove unnecessary cast.
6329         * tui/tui-winsource.c (tui_erase_source_content)
6330         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6331         unnecessary cast.
6332         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6333         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6334         * stabsread.c (read_type, read_array_type, read_range_type):
6335         Remove unnecessary cast.
6336         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6337         (parse_symbol, parse_type, upgrade_type, parse_external)
6338         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6339         unnecessary cast.
6340         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6341
6342 2019-06-16  Tom Tromey  <tom@tromey.com>
6343
6344         * tui/tui-data.c (tui_alloc_generic_win_info)
6345         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6346         checks.
6347
6348 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6349             Andrew Burgess  <andrew.burgess@embecosm.com>
6350
6351         * f-typeprint.c (f_print_type): Don't return early for not
6352         associated or not allocated types.
6353         (f_type_print_varspec_suffix): Add print_rank parameter and print
6354         ranks of array types in case they dangling.
6355         (f_type_print_base): Add print_rank parameter.
6356
6357 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6358
6359         * NEWS: Mention new MI commands.
6360         * break-catch-throw.c (enum exception_event_kind): Move to
6361         breakpoint.h.
6362         (print_mention_exception_catchpoint): Output text as a single
6363         message.
6364         (catch_exception_command_1): Rename to...
6365         (catch_exception_event): ...this, make non-static, update header
6366         command, and change some parameter types.
6367         (catch_catch_command): Update for changes to
6368         catch_exception_command_1.
6369         (catch_throw_command): Likewise.
6370         (catch_rethrow_command): Likewise.
6371         * breakpoint.c (enum exception_event_kind): Delete.
6372         * breakpoint.h (enum exception_event_kind): Moved here from
6373         break-catch-throw.c.
6374         (catch_exception_event): Declare.
6375         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6376         (mi_cmd_catch_throw): New function.
6377         (mi_cmd_catch_rethrow): New function.
6378         (mi_cmd_catch_catch): New function.
6379         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6380         'catch-catch' entries.
6381         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6382         (mi_cmd_catch_rethrow): Declare.
6383         (mi_cmd_catch_catch): Declare.
6384
6385 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6386
6387         * annotate.c (annotate_source_line): Change return type to void,
6388         update implementation to match.
6389         * annotate.h (annotate_source_line): Change return type to void,
6390         update header comment.
6391         * stack.c (print_frame_info): Don't change what frame information
6392         is printed based on whether annotations are on or not.
6393
6394 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6395
6396         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6397         (annotate_source): Make static.
6398         (annotate_source_line): Moved from source.c and renamed from
6399         identify_source_line.  Update the return type.
6400         * annotate.h (annotate_source): Delete declaration.
6401         (annotate_source_line): Declaration moved from source.h, and
6402         renamed from identify_source_line.  Return type updated.
6403         * source.c (identify_source_line): Moved to annotate.c and renamed
6404         to annotate_source_line.
6405         (info_line_command): Remove check of annotation_level.
6406         * source.h (identify_source_line): Move declaration to annotate.h
6407         and rename to annotate_source_line.
6408         * stack.c: Add 'annotate.h' include.
6409         (print_frame_info): Remove check of annotation_level before
6410         calling annotate_source_line.
6411
6412 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6413
6414         * source-cache.c (source_cache::get_plain_source_lines): Use
6415         open_source_file_with_line_charpos instead of just
6416         open_source_file, remove call to find_source_lines.
6417         (source_cache::get_source_lines): Likewise.
6418         * source.c (find_source_lines): Make static.
6419         (get_filename_and_charpos): Renamed into...
6420         (open_source_file_with_line_charpos): ..this along with changes to
6421         return a scoped_fd, and some other minor clean ups.
6422         (identify_source_line): Use open_source_file_with_line_charpos.
6423         (search_command_helper): Use open_source_file_with_line_charpos
6424         instead of just open_source_file, remove call to
6425         find_source_lines.
6426         * source.h (open_source_file_with_line_charpos): Declare new
6427         function.
6428         (find_source_lines): Delete declaration.
6429
6430 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6431
6432         * source.c (get_filename_and_charpos): Remove fullname
6433         parameter.
6434         (identify_source_line): Update call to get_filename_and_charpos.
6435
6436 2019-06-14  Tom Tromey  <tromey@adacore.com>
6437
6438         PR gdb/24502:
6439         * ui-style.h (skip_ansi_escape): Update comment.
6440         * ui-file.h (class no_terminal_escape_file): New class.
6441         * ui-file.c (no_terminal_escape_file::write)
6442         (no_terminal_escape_file::puts): New methods.
6443         * cli/cli-logging.c (handle_redirections): Use
6444         no_terminal_escape_file.
6445
6446 2019-06-14  Tom Tromey  <tromey@adacore.com>
6447
6448         * NEWS: Move convenience variable news above Python news.
6449
6450 2019-06-14  Tom Tromey  <tom@tromey.com>
6451
6452         * gnulib: Move directory to top-level.
6453         * configure.ac: Don't configure gnulib.
6454         * configure: Rebuild.
6455         * common/common-defs.h: Use new path to gnulib.
6456         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6457         (GNULIB_H): Remove.
6458         (INCGNU): Look in new gnulib location.
6459         (HFILES_NO_SRCDIR): Remove gnulib files.
6460         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6461         (generated_files): Remove GNULIB_H.
6462         ($(LIBGNU), all-lib): Remove targets.
6463         (distclean): Don't mention GNULIB_BUILDDIR.
6464         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6465
6466 2019-06-14  Tom Tromey  <tromey@adacore.com>
6467
6468         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6469         Warn if symbol file does not provide any symbols.
6470
6471 2019-06-14  Tom Tromey  <tromey@adacore.com>
6472
6473         * source.c (find_and_open_source): Respect basenames_may_differ.
6474
6475 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6476
6477         * annotate.c (annotate_breakpoints_invalid): Make use of
6478         scoped_restore_terminal_state.
6479         (annotate_frames_invalid): Likewise.
6480
6481 2019-06-14  Tom Tromey  <tromey@adacore.com>
6482
6483         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6484         allow assignment to an internalvar.
6485
6486 2019-06-14  Tom Tromey  <tromey@adacore.com>
6487
6488         * ada-lex.l: Allow "_" in attribute names.
6489
6490 2019-06-14  Tom Tromey  <tromey@adacore.com>
6491
6492         PR gdb/24653:
6493         * regcache.c (registers_changed): Don't call alloca.
6494         * top.c (execute_command): Don't call alloca.
6495
6496 2019-06-13  Pedro Alves  <palves@redhat.com>
6497
6498         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6499         'expression'.  When parsing an expression, error out if there's
6500         junk after "unlimited".
6501         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6502         (do_set_command): Adjust calls to is_unlimited_literal.
6503
6504 2019-06-13  Pedro Alves  <palves@redhat.com>
6505
6506         * compile/compile.c (make_compile_options_def_group): Add braces
6507         around array_view initializer.
6508         * thread.c (make_thread_apply_all_options_def_group)
6509         (make_thread_apply_all_options_def_group): Likewise.
6510
6511 2019-06-13  Pedro Alves  <palves@redhat.com>
6512
6513         * NEWS (New commands): Mention "maint test-options
6514         require-delimiter", "maint test-options unknown-is-error", "maint
6515         test-options unknown-is-operand" and "maint show
6516         test-options-completion-result".
6517         (New command options, command completion): New section.
6518         (Completion improvements): New section.
6519         Mention that you can abbreviate "unlimited".
6520
6521 2019-06-13  Pedro Alves  <palves@redhat.com>
6522
6523         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6524         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6525         * unittests/cli-utils-selftests.c (test_parse_flags)
6526         (test_parse_flags_qcs): Delete.
6527         (test_cli_utils): Don't call deleted functions.
6528
6529 2019-06-13  Pedro Alves  <palves@redhat.com>
6530
6531         * thread.c: Include "cli/cli-option.h".
6532         (tp_array_compar_ascending): Global.
6533         (tp_array_compar): Delete function.
6534         (tp_array_compar_ascending, tp_array_compar_descending): New
6535         functions.
6536         (ascending_option_def, qcs_flag_option_def)
6537         (thr_qcs_flags_option_defs)
6538         (make_thread_apply_all_options_def_group)
6539         (make_thread_apply_options_def_group): New.
6540         (thread_apply_all_command): Use gdb::option::process_options.
6541         (thread_apply_command_completer)
6542         (thread_apply_all_command_completer): New.
6543         (thread_apply_command): Use gdb::option::process_options.
6544         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6545         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6546         to generate help text of "thread apply".  Adjust "taas"'s help.
6547         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6548         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6549
6550 2019-06-13  Pedro Alves  <palves@redhat.com>
6551
6552         * thread.c (thread_apply_command): Check for invalid TID with
6553         isdigit instead of !isalpha.
6554
6555 2019-06-13  Pedro Alves  <palves@redhat.com>
6556
6557         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6558         (validate_flags_qcs): New.
6559         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6560         (validate_flags_qcs): Declare.
6561         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6562         (make_frame_apply_options_def_group): New.
6563         (frame_apply_command_count): Process options with
6564         gdb::option::process_options.
6565         (frame_apply_completer): New.
6566         (frame_apply_level_completer, frame_apply_all_completer)
6567         (frame_apply_completer): New.
6568         (_initialize_stack): Update help of "frame apply", "frame apply
6569         level", "frame apply all" and "faas" to mention supported options
6570         and install command completers.
6571         * stack.h (frame_apply_all_completer): Declare.
6572         * thread.c: Include "stack.h".
6573         (tfaas_command): Add "--".
6574         (_initialize_thread): Update help "tfaas" to mention supported
6575         options and install command completer.
6576
6577 2019-06-13  Pedro Alves  <palves@redhat.com>
6578
6579         * completer.c (complete_nested_command_line): New.
6580         (gdb_completion_word_break_characters_throw): Add assertion.
6581         * completer.h (complete_nested_command_line): Declare.
6582
6583 2019-06-13  Pedro Alves  <palves@redhat.com>
6584
6585         * stack.c (parse_backtrace_qualifiers): New.
6586         (backtrace_command): Use it.
6587         (backtrace_command_completer): Complete on qualifiers.
6588
6589 2019-06-13  Pedro Alves  <palves@redhat.com>
6590
6591         * frame.c: Include "cli/cli-option.h.
6592         (user_set_backtrace_options): New.
6593         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6594         Delete.
6595         (get_prev_frame): Adjust.
6596         (boolean_option_def, uinteger_option_def)
6597         (set_backtrace_option_defs): New.
6598         (_initialize_frame): Adjust and use
6599         gdb::option::add_setshow_cmds_for_options to install "set
6600         backtrace past-main" and "set backtrace past-entry".
6601         * frame.h: Include "cli/cli-option.h".
6602         (struct frame_print_options): Forward declare.
6603         (print_frame_arguments_all, print_frame_arguments_scalars)
6604         (print_frame_arguments_none): Declare.
6605         (print_entry_values): Delete declaration.
6606         (struct frame_print_options, user_frame_print_options): New.
6607         (struct set_backtrace_options): New.
6608         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6609         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6610         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6611         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6612         (list_args_or_locals): Add frame_print_options parameter.
6613         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6614         * python/py-framefilter.c (enumerate_args): Pass down
6615         USER_FRAME_PRINT_OPTIONS.
6616         * stack.c: Include "cli/cli-option.h".
6617         (print_frame_arguments_all, print_frame_arguments_scalars)
6618         (print_frame_arguments_none): Declare.
6619         (print_raw_frame_arguments, print_entry_values): Delete.
6620         (user_frame_print_options): New.
6621         (boolean_option_def, enum_option_def, frame_print_option_defs):
6622         New.
6623         (struct backtrace_cmd_options): New.
6624         (bt_flag_option_def): New.
6625         (backtrace_command_option_defs): New.
6626         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6627         (print_frame_arg, read_frame_arg, print_frame_args)
6628         (print_frame_info, print_frame): Add frame_print_options parameter
6629         and use it.
6630         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6631         (backtrace_command_1): Add frame_print_options and
6632         backtrace_cmd_options parameters and use them.
6633         (make_backtrace_options_def_group): New.
6634         (backtrace_command): Process command options with
6635         gdb::option::process_options.
6636         (backtrace_command_completer): New.
6637         (_initialize_stack): Extend "backtrace"'s help to mention
6638         supported options.  Install completer for "backtrace".
6639         Install some settings commands with add_setshow_cmds_for_options.
6640
6641 2019-06-13  Pedro Alves  <palves@redhat.com>
6642
6643         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6644         and that "set/show print raw frame-arguments" are now deprecated.
6645
6646         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6647         command.
6648         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6649         * stack.c (_initialize_stack): Install "set/show print
6650         raw-frame-arguments", and deprecate "set/show print raw
6651         frame-arguments".
6652         * valprint.c (_initialize_valprint): Deprecate "set/show print
6653         raw".
6654
6655 2019-06-13  Pedro Alves  <palves@redhat.com>
6656
6657         * compile/compile.c (struct compile_options): New.
6658         (compile_flag_option_def, compile_command_option_defs)
6659         (make_compile_options_def_group): New.
6660         (compile_file_command): Handle options with
6661         gdb::option::process_options.
6662         (compile_file_command_completer): New function.
6663         (compile_code_command): Handle options with
6664         gdb::option::process_options.
6665         (compile_code_command_completer): New function.
6666         (_initialize_compiler): Install completers for "compile code" and
6667         "compile file".  Mention available options in "compile code" and
6668         "compile code"'s help.
6669         * completer.c (advance_to_completion_word): New, factored out from
6670         ...
6671         (advance_to_expression_complete_word_point): ... this.
6672         (advance_to_filename_complete_word_point): New.
6673         * completer.h (advance_to_filename_complete_word_point): New
6674         declaration.
6675
6676 2019-06-13  Pedro Alves  <palves@redhat.com>
6677
6678         * compile/compile.c: Include "cli/cli-option.h".
6679         (compile_print_value): Scope data pointer is now a
6680         value_print_options pointer; adjust.
6681         (compile_print_command): Process options.  Scope data pointer is
6682         now a value_print_options pointer; adjust.
6683         (_initialize_compile): Update "compile print"'s help to include
6684         supported options.  Install a completer for "compile print".
6685         * cp-valprint.c (show_vtblprint, show_objectprint)
6686         (show_static_field_print): Delete.
6687         (_initialize_cp_valprint): Don't install "set print
6688         static-members", "set print vtbl", "set print object" here.
6689         * printcmd.c: Include "cli/cli-option.h" and
6690         "common/gdb_optional.h".
6691         (print_command_parse_format): Rework to fill in a
6692         value_print_options instead of a format_data.
6693         (print_value): Change parameter type from format_data pointer to
6694         value_print_options reference.  Adjust.
6695         (print_command_1): Process options.  Adjust to pass down a
6696         value_print_options.
6697         (print_command_completer): New.
6698         (_initialize_printcmd): Install print_command_completer as
6699         handle_brkchars completer for the "print" command.  Update
6700         "print"'s help to include supported options.
6701         * valprint.c: Include "cli/cli-option.h".
6702         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6703         here from cp-valprint.c.
6704         (boolean_option_def, uinteger_option_def)
6705         (value_print_option_defs, make_value_print_options_def_group):
6706         New.  Use gdb::option::add_setshow_cmds_for_options to install
6707         "set print elements", "set print null-stop", "set print repeats",
6708         "set print pretty", "set print union", "set print array", "set
6709         print address", "set print symbol", "set print array-indexes".
6710         * valprint.h: Include <string> and "cli/cli-option.h".
6711         (make_value_print_options_def_group): Declare.
6712         (print_value): Change parameter type from format_data pointer to
6713         value_print_options reference.
6714         (print_command_completer): Declare.
6715
6716 2019-06-13  Pedro Alves  <palves@redhat.com>
6717
6718         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6719         (COMMON_SFILES): Add maint-test-settings.c.
6720         * cli/cli-decode.c (boolean_enums): New global, factored out from
6721         ...
6722         (add_setshow_boolean_cmd): ... here.
6723         * cli/cli-decode.h (boolean_enums): Declare.
6724         * cli/cli-option.c: New file.
6725         * cli/cli-option.h: New file.
6726         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6727         factored out from ...
6728         (parse_cli_boolean_value(const char *)): ... this.
6729         (is_unlimited_literal): Change parameter type to pointer to
6730         pointer.  Adjust and advance ARG pointer.
6731         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6732         (parse_cli_var_enum): New, factored out from ...
6733         (do_set_command): ... this.  Adjust.
6734         * cli/cli-setshow.h (parse_cli_boolean_value)
6735         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6736         (parse_cli_var_enum): Declare.
6737         * cli/cli-utils.c: Include "cli/cli-option.h".
6738         (get_ulongest): New.
6739         * cli/cli-utils.h (get_ulongest): Declare.
6740         (check_for_argument): New overloads.
6741         * maint-test-options.c: New file.
6742
6743 2019-06-13  Pedro Alves  <palves@redhat.com>
6744
6745         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6746         parse a range if "-" is at the end of the string.
6747
6748 2019-06-13  Pedro Alves  <palves@redhat.com>
6749
6750         * cli/cli-setshow.c (parse_auto_binary_operation)
6751         (parse_cli_boolean_value): Don't allow "o".
6752
6753 2019-06-13  Pedro Alves  <palves@redhat.com>
6754
6755         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6756         * NEWS: Mention maint test-settings KIND.
6757         * maint-test-settings.c: New file.
6758
6759 2019-06-13  Pedro Alves  <palves@redhat.com>
6760
6761         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6762         completer.
6763         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6764         "set" completers.
6765
6766 2019-06-13  Pedro Alves  <palves@redhat.com>
6767
6768         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6769         after item.
6770
6771 2019-06-13  Pedro Alves  <palves@redhat.com>
6772
6773         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6774
6775 2019-06-13  Pedro Alves <palves@redhat.com>
6776
6777         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6778         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6779         call.
6780         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6781         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6782         calls.
6783         (check_for_argument): Skip spaces after argument.
6784
6785 2019-06-13  Pedro Alves  <palves@redhat.com>
6786
6787         * thread.c (thread_apply_command): Adjust TID parsing.
6788         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6789         detected before end of string.
6790         (tid_is_in_list): Error out if LIST is invalid.
6791
6792 2019-06-13  Pedro Alves  <palves@redhat.com>
6793
6794         * completer.c (complete_line_internal_1): Rewind completion word
6795         point.
6796         (completion_tracker::advance_custom_word_point_by): Change
6797         parameter type to int.
6798         * completer.h (completion_tracker::advance_custom_word_point_by):
6799         Likewise.
6800
6801 2019-06-13  Pedro Alves  <palves@redhat.com>
6802
6803         * completer.c (advance_to_completion_word): Handle delimiters.
6804
6805 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6806
6807         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6808
6809 2019-06-11  Tom Tromey  <tom@tromey.com>
6810
6811         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6812         (xmalloc_failed): Move to alloc.c.
6813         * alloc.c: New file.
6814         * Makefile.in (COMMON_SFILES): Add alloc.c.
6815
6816 2019-06-11  Tom Tromey  <tom@tromey.com>
6817
6818         * nat/linux-waitpid.c: Don't include server.h.
6819         (linux_debug): Remove.
6820         (my_waitpid): Update.
6821
6822 2019-06-11  Tom Tromey  <tromey@adacore.com>
6823
6824         * infcall.c (_initialize_infcall): Remove trailing newline from
6825         help.
6826         * user-regs.c (_initialize_user_regs): Remove trailing newline
6827         from help.
6828         * typeprint.c (_initialize_typeprint): Remove trailing newline
6829         from help.
6830         * reverse.c (_initialize_reverse): Remove trailing newlines from
6831         help.
6832         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6833         from help.
6834         * language.c (add_set_language_command): Remove trailing newline
6835         from help.
6836         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6837         help.
6838         * disasm.c (_initialize_disasm): Remove trailing newline from
6839         help.
6840         * top.c (init_main): Remove trailing newline from help.
6841         * interps.c (_initialize_interpreter): Remove trailing newline
6842         from help.
6843         * btrace.c (_initialize_btrace): Remove trailing newlines from
6844         help.
6845         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6846         from help.
6847         * python/python.c (_initialize_python): Remove trailing newline
6848         from help.
6849         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6850         help.
6851         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6852         from help.  Reformat some text.
6853         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6854         from help.
6855         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6856         newline from help.
6857
6858 2019-06-11  Tom Tromey  <tromey@adacore.com>
6859
6860         * darwin-nat.c (darwin_decode_exception_message)
6861         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6862
6863 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6864
6865         * valops.c (value_slice): Check for not allocated or not
6866         associated values.
6867
6868 2019-06-10  Tom de Vries  <tdevries@suse.de>
6869
6870         PR gdb/24618
6871         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6872         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6873         invalid.
6874
6875 2019-06-10  Tom de Vries  <tdevries@suse.de>
6876
6877         PR gdb/24611
6878         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6879         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6880
6881 2019-06-10  Tom de Vries  <tdevries@suse.de>
6882
6883         PR symtab/24545
6884         * symtab.c (struct demangled_name_entry): Add language field.
6885         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6886         static minimal symbol".  Set and use language field.
6887
6888 2019-06-10  Tom Tromey  <tromey@adacore.com>
6889
6890         * ada-lang.c (_initialize_ada_language): Update help text.
6891
6892 2019-06-10  Tom Tromey  <tromey@adacore.com>
6893
6894         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6895         with a newline.
6896         * guile/guile.c (handle_boot_error): Don't end warning with a
6897         newline.
6898         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6899         warning with a newline.
6900         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6901         newline.
6902         (s12z_frame_cache): Likewise.
6903         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6904         a newline.
6905         * solib-svr4.c (disable_probes_interface): Don't end warning with
6906         a newline.
6907         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6908         newline.
6909         * python/python.c (do_finish_initialization): Don't end warning
6910         with a newline.
6911
6912 2019-06-10  Tom Tromey  <tom@tromey.com>
6913
6914         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6915         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6916         gdbpy_enter.
6917
6918 2019-06-10  Tom Tromey  <tromey@adacore.com>
6919
6920         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6921         data.
6922         (elf_new_init): Don't call stabsread_new_init.
6923         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6924         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6925         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6926
6927 2019-06-10  Tom de Vries  <tdevries@suse.de>
6928
6929         PR symtab/16264
6930         PR symtab/24517
6931         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6932
6933 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6934
6935         * source.c (find_and_open_source): Also rewrite relative file
6936         names.
6937
6938 2019-04-26  Amos Bird  <amosbird@gmail.com>
6939
6940         * annotate.c (annotate_thread_exited): Add "thread-exited"
6941         annotation.
6942
6943 2019-06-06  Tom Tromey  <tromey@adacore.com>
6944
6945         * maint.h (class scoped_command_stats): Use
6946         DISABLE_COPY_AND_ASSIGN.
6947         <print_time>: New method.
6948         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6949         print_time.
6950         (scoped_command_stats::print_time): New method.
6951
6952 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6953
6954         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6955         instructions of lengths 6 or 8 bytes.
6956
6957 2019-06-04  Pedro Alves  <palves@redhat.com>
6958
6959         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6960
6961         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6962         * breakpoint.c (condition_completer): Likewise.
6963         * cli/cli-dump.c (scan_expression): Likewise.
6964         * common/filestuff.c (mkdir_recursive): Likewise.
6965         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6966         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6967         (gdb_abspath): Likewise.
6968         * compile/compile-cplus-types.c
6969         (compile_cplus_instance::decl_name): Likewise.
6970         * completer.c (complete_explicit_location):
6971         (signal_completer, reg_or_group_completer_1): Likewise.
6972         * cp-support.c (cp_remove_params_if_any): Likewise.
6973         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6974         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6975         * infcmd.c (strip_bg_char): Likewise.
6976         * linespec.c (copy_token_string): Likewise.
6977         * mi/mi-main.c (output_cores): Likewise.
6978         * psymtab.c (psymtab_search_name):
6979         * symfile.c (test_set_ext_lang_command): Likewise.
6980         * target.c (target_fileio_read_stralloc): Likewise.
6981         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6982         * value.c (complete_internalvar): Likewise.
6983
6984 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6985
6986         Add objfile property to gdb.Type.
6987         * NEWS: Mention Python API addition.
6988         * python/py-type.c (typy_get_objfile): New method.
6989
6990 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6991
6992         * NEWS: Mention the new set|show style [title|highlight].
6993         Mention changes to "show style", "help" and "apropos".
6994
6995 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6996
6997         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6998         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6999         instead of print_help_for_command.
7000         (print_doc_of_command): New function.
7001         (help_list): Add 'apropos -v word' suggestion.
7002         (print_help_for_command): Style the command name using title style.
7003         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7004         (_initialize_cli_cmds): Describe -v in apropos_command help.
7005
7006 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7007
7008         * cli/cli-style.h (cli_style_option): Add name in constructor,
7009         add m_name class member, add constructor with intensity,
7010         add name class function.
7011         (cli_style_option::add_setshow_commands): Remove name argument.
7012         (highlight_style, title_style): New styles.
7013         * cli/cli-style.c (do_show): New function that shows a style
7014         characteristic styling the style name with itself.
7015         (set_style_name): New function.
7016         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7017         Update all callers according to the changes in cli/cli-style.h.
7018         * utils.h (fputs_highlighted): New function.
7019         * utils.c (fputs_highlighted): Likewise.
7020
7021 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7022
7023         * NEWS: Mention new pipe command and new convenience variables.
7024
7025 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7026
7027         * cli/cli-cmds.c (pipe_command): New function.
7028         (_initialize_cli_cmds): Call add_com for pipe_command.
7029         Define | as an alias for pipe.
7030         (exit_status_set_internal_vars): New function.
7031         (shell_escape): Call exit_status_set_internal_vars.
7032         cli/cli-decode.c (find_command_name_length): Recognize | as
7033         a single character command.
7034
7035 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7036
7037         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7038         top.c (execute_command_to_ui_file): New function, mostly a copy
7039         of execute_command_to_string.
7040         (execute_command_to_string): Implement by calling
7041         execute_command_to_ui_file.
7042
7043 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7044
7045         * top.h (saved_command_line): Remove declaration.
7046         * top.c (previous_saved_command_line, previous_repeat_arguments):
7047         New variables.
7048         (saved_command_line): Make static, define together with other
7049         'repeat variables'.
7050         (dont_repeat): Clear repeat_arguments.
7051         (repeat_previous, get_saved_command_line, save_command_line):
7052         New functions.
7053         (gdb_init): Initialize saved_command_line
7054         and previous_saved_command_line.
7055         * main.c (captured_main_1): Remove saved_command_line initialization.
7056         * event-top.c (handle_line_of_input): Update to use
7057         the new 'repeat' related functions instead of direct access to
7058         saved_command_line.
7059         * command.h (repeat_previous, get_saved_command_line,
7060         save_command_line): New declarations.
7061         (dont_repeat): Add comment.
7062
7063 2019-05-30  Tom Tromey  <tromey@adacore.com>
7064
7065         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7066         Fix comment.
7067         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7068
7069 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7070
7071         PR cli/24587
7072         * completer.c (complete): Initialize variable word.
7073
7074 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7075
7076         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7077         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7078         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7079         'body' is NULL to the outter 'if', protecting the '!is_define'
7080         situation as well.
7081
7082 2019-05-29  Tom Tromey  <tromey@adacore.com>
7083
7084         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7085         (dwarf_unknown): New function.
7086         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7087         (dwarf_type_encoding_name): Use dwarf_unknown.
7088
7089 2019-05-29  Tom Tromey  <tromey@adacore.com>
7090
7091         PR c++/20020:
7092         * cp-valprint.c (cp_print_value_fields): Call
7093         cp_print_static_field inside "try".
7094
7095 2019-05-29  Tom Tromey  <tromey@adacore.com>
7096
7097         * inflow.c (struct terminal_info): Add default operator=.
7098         * configure: Rebuild.
7099         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7100         -Wdeprecated-copy-dtor, -Wredundant-move.
7101
7102 2019-05-29  Tom Tromey  <tromey@adacore.com>
7103
7104         * NEWS: Add entry.
7105         * infcmd.c (print_return_value_1): Handle finish_print
7106         option.
7107         (show_print_finish): New function.
7108         (_initialize_infcmd): Add "set/show print finish" commands.
7109         * valprint.c (user_print_options): Initialize new member.
7110         * valprint.h (struct value_print_options) <finish_print>: New
7111         member.
7112
7113 2019-05-28  Tom Tromey  <tromey@adacore.com>
7114
7115         * ada-lang.c (ada_remove_Xbn_suffix)
7116         (find_old_style_renaming_symbol)
7117         (parse_old_style_renaming): Remove.
7118         (ada_find_renaming_symbol): Don't call
7119         find_old_style_renaming_symbol.
7120         (ada_is_renaming_symbol): Rename from
7121         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7122         bool.  Now static.
7123         (ada_read_var_value): Update and simplify.
7124         * ada-exp.y (write_var_or_type): Remove old code.
7125
7126 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7127
7128         PR gdb/25010
7129         * event-top.c: Remove include comment.
7130         * inflow.c (class scoped_ignore_sigttou): Move from here...
7131         * inflow.h (class scoped_ignore_sigttou): ...to here.
7132         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7133         * top.c:  Remove include comment.
7134
7135 2019-05-27  Tom Tromey  <tom@tromey.com>
7136
7137         * NEWS: Fix typo.
7138
7139 2019-05-22  Tom Tromey  <tromey@adacore.com>
7140
7141         * target.c (target_follow_exec): Constify parameter.
7142         * target-delegates.c: Rebuild.
7143         * remote.c (remote_target::follow_exec): Constify parameter.
7144         * infrun.c (follow_exec): Constify parameter.
7145         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7146         (target_follow_exec): Likewise.
7147
7148 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7149
7150         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7151         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7152
7153 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7154
7155         * NEWS: Add debugredirect and testsuite sections.
7156
7157 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7158
7159         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7160         target descriptions using exclusively floating point register name
7161         aliases.
7162
7163 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7164
7165         PR gdb/18644:
7166         * f-lang.c (build_fortran_types): Handle the case where
7167         gdbarch_floatformat_for_type returns a nullptr.
7168
7169 2019-05-21  Tom de Vries  <tdevries@suse.de>
7170
7171         PR cli/24587
7172         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7173
7174 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7175
7176         PR gdb/18644:
7177         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7178         16-byte floats.
7179         * i386-tdep.c (i386_floatformat_for_type): Use
7180         floatformats_ia64_quad for the 16-byte floating point component
7181         within a fortran 32-byte complex number.
7182
7183 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7184
7185         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7186         delete default constructor.
7187         (find_partial_die): Update to return const struct.
7188         (partial_die_parent_scope): Move variable declaration into scope
7189         of its use and change its type to auto.
7190         (guess_partial_die_structure_name): Likewise.
7191         (partial_die_info::fixup): Likewise.
7192
7193 2019-05-17  Tom Tromey  <tromey@adacore.com>
7194
7195         * source.c (find_and_open_source): Remove cast.
7196
7197 2019-05-17  Tom Tromey  <tromey@adacore.com>
7198
7199         * annotate.c (annotate_source): Make "filename" const.
7200         * annotate.h (annotate_source): Use const.
7201
7202 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7203
7204         * disasm.c (set_disassembler_options): Send errors to stderr.
7205
7206 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7207
7208         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7209         (cli_interp_base::set_logging): Check debug_redirect.
7210         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7211         * cli/cli-logging.c (debug_redirect): Add static variable.
7212         (pop_output_files): Add default param.
7213         (handle_redirections): Print debug setting.
7214         (show_logging_command): Likewise.
7215         (_initialize_cli_logging): Add debugredirect command.
7216         * interps.c (current_interp_set_logging): Add debug_redirect
7217         parameter.
7218         * interps.h (set_logging): Add debug_redirect parameter.
7219         (current_interp_set_logging): Likewise.
7220         * mi/mi-common.h: Likewise.
7221         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7222
7223 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7224             Tom Tromey  <tromey@adacore.com>
7225
7226         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7227         directly.
7228         * cli/cli-interp.h (make_logging_output): Remove declaration.
7229         * cli/cli-logging.c (make_logging_output): Remove function.
7230         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7231         directly.
7232         * ui-file.c (tee_file::tee_file): Remove bools.
7233         (tee_file::~tee_file): Remove deletes.
7234         * ui-file.h (tee_file): Remove bools.
7235
7236 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7237
7238         * mi/mi-cmds.h (mi_cmd_complete): New function.
7239         * mi/mi-main.c (mi_cmd_complete): Likewise.
7240         * mi/mi-cmds.c: Define new MI command -complete.
7241         * NEWS: Mention new -complete command.
7242
7243 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7244
7245         * completer.h (complete): New function.
7246         * completer.c (complete): Likewise.
7247         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7248         function defined in completer.h.
7249
7250 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7251
7252         * MAINTAINERS (Write After Approval): Add myself.
7253
7254 2019-05-17  Tom de Vries  <tdevries@suse.de>
7255
7256         PR gdb/24094
7257         * dwarf2read.c (struct cu_partial_die_info): New struct.
7258         (find_partial_die): Return cu_partial_die_info.
7259         (partial_die_parent_scope, guess_partial_die_structure_name)
7260         (partial_die_info::fixup): Handle new return type of find_partial_die.
7261
7262 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7263
7264         PR breakpoints/24541
7265         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7266         "std::string", simplifying the algorithm.
7267
7268 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7269
7270         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7271         (stap_static_probe_ops::get_probes): Likewise.
7272
7273 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7274
7275         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7276         '-')" and "else if".
7277         (stap_parse_single_operand): Join checks for
7278         "gdbarch_stap_parse_special_token_p" and
7279         "gdbarch_stap_parse_special_token" in the same "if" statement.
7280         Invert check when verifying for operation on register
7281         displacement.
7282
7283 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7284
7285         * stap-probe.c (stap_get_opcode): Update comment.
7286         (stap_get_expected_argument_type): Likewise.
7287         (handle_stap_probe): Likewise.
7288
7289 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7290
7291         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7292         return type to 'bool'.  Adjust comment.  Use 'bool' when
7293         appropriate.
7294         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7295         * stap-probe.c (stap_parse_argument_1): Likewise.
7296         (stap_is_operator): Likewise.
7297         (stap_is_generic_prefix): Likewise.
7298         (stap_is_register_prefix): Likewise.
7299         (stap_is_register_indirection_prefix): Likewise.
7300         (stap_is_integer_prefix): Likewise.
7301         (stap_generic_check_suffix): Likewise.
7302         (stap_check_integer_suffix): Likewise.
7303         (stap_check_register_suffix): Likewise.
7304         (stap_check_register_indirection_suffix): Likewise.
7305         (stap_parse_register_operand): Likewise.
7306         (stap_parse_single_operand): Likewise.
7307         (stap_parse_argument_1): Likewise.
7308         (stap_probe::get_argument_count): Likewise.
7309         (stap_is_operator): Likewise.
7310
7311 2019-05-16  Tom Tromey  <tromey@adacore.com>
7312
7313         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7314         keyword to foreach.
7315
7316 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7317
7318         * linux-thread-db.c (try_thread_db_load_1): Change return type
7319         to bool.
7320         (try_thread_db_load): Likewise.
7321         (try_thread_db_load_from_pdir_1): Likewise.
7322         (try_thread_db_load_from_pdir): Likewise.
7323         (try_thread_db_load_from_sdir): Likewise.
7324         (try_thread_db_load_from_dir): Likewise.
7325         (thread_db_load_search): Likewise.
7326         (has_libpthread): Likewise.
7327         (thread_db_load): Likewise.
7328
7329 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7330
7331         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7332         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7333         NULL, and complain/return if that's the case.
7334
7335 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7336
7337         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7338         (advance, posn, abstract_read_memory): New functions.
7339         [struct mem_read_abstraction]: New struct.
7340         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7341
7342 2019-05-14  Tom Tromey  <tromey@adacore.com>
7343
7344         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7345         value is not lval_memory.
7346
7347 2019-05-14  Tom Tromey  <tromey@adacore.com>
7348
7349         * solib.c (info_sharedlibrary_command): Style the file name.
7350
7351 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7352
7353         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7354         (aarch64_vnv_type): Likewise.
7355         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7356         * common/tdesc.c: Likewise.
7357         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7358         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7359         * features/aarch64-fpu.xml: Add ieee half view.
7360         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7361         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7362         * gdbtypes.h (struct builtin_type): Likewise.
7363         (struct objfile_type): Likewise.
7364
7365 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7366
7367         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7368         typo.
7369         * location.h (string_to_event_location): Likewise.
7370
7371 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7372
7373         GDB 8.3 released.
7374
7375 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7376
7377         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7378         New variable declaration.
7379         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7380         New variable.
7381         (print_one_breakpoint): Use ui_out::test_flags and new global
7382         variable to compute use_fixed_output.
7383         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7384         Remove.
7385         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7386         (mi_multi_location_breakpoint_output_fixed): Remove.
7387         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7388         new variable.
7389         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7390         fix_multi_location_breakpoint_output flag if version >= 3.
7391         * ui-out.h (enum ui_out_flag)
7392         <fix_multi_location_breakpoint_output>: New enumerator.
7393
7394 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7395
7396         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7397
7398 2019-05-10  Tom Tromey  <tromey@adacore.com>
7399
7400         * ada-lang.c (catch_ada_completer): New function.
7401         (_initialize_ada_language): Use it.
7402
7403 2019-05-10  Tom Tromey  <tromey@adacore.com>
7404
7405         * thread.c (print_thread_info): Make "requested_threads" const.
7406         * gdbthread.h (print_thread_info): Make "requested_threads"
7407         const.
7408         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7409         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7410
7411 2019-05-08  Tom Tromey  <tom@tromey.com>
7412
7413         * gdbtypes.c (objfile_type_data): Change type.
7414         (objfile_type, _initialize_gdbtypes): Update.
7415
7416 2019-05-08  Tom Tromey  <tom@tromey.com>
7417
7418         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7419         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7420         (_initialize_dwarf2_frame): Update.
7421
7422 2019-05-08  Tom Tromey  <tom@tromey.com>
7423
7424         * objc-lang.c (objc_objfile_data): Change type.
7425         (find_methods): Update.
7426         (_initialize_objc_lang): Remove.
7427
7428 2019-05-08  Tom Tromey  <tom@tromey.com>
7429
7430         * stabsread.c (rs6000_builtin_type_data): Change type.
7431         (rs6000_builtin_type, _initialize_stabsread): Update.
7432
7433 2019-05-08  Tom Tromey  <tom@tromey.com>
7434
7435         * mips-tdep.c (mips_pdr_data): Remove.
7436         (_initialize_mips_tdep): Update.
7437
7438 2019-05-08  Tom Tromey  <tom@tromey.com>
7439
7440         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7441         (hppa_init_objfile_priv_data, read_unwind_info)
7442         (find_unwind_entry, _initialize_hppa_tdep): Update.
7443
7444 2019-05-08  Tom Tromey  <tom@tromey.com>
7445
7446         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7447         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7448         on obstack.
7449         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7450
7451 2019-05-08  Tom Tromey  <tom@tromey.com>
7452
7453         * mdebugread.c (basic_type_data): Change type.
7454         (basic_type, _initialize_mdebugread): Update.
7455
7456 2019-05-08  Tom Tromey  <tom@tromey.com>
7457
7458         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7459
7460 2019-05-08  Tom Tromey  <tom@tromey.com>
7461
7462         * nto-tdep.c (nto_inferior_data_reg): Change type.
7463         (nto_inferior_data): Update.
7464         (nto_inferior_data_cleanup, nto_new_inferior_data)
7465         (_initialize_nto_tdep): Remove.
7466         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7467
7468 2019-05-08  Tom Tromey  <tom@tromey.com>
7469
7470         * ada-lang.c (struct ada_inferior_data): Add initializers.
7471         (ada_inferior_data): Change type.
7472         (ada_inferior_data_cleanup): Remove.
7473         (get_ada_inferior_data, ada_inferior_exit)
7474         (struct ada_pspace_data): Add initializers, destructor.
7475         (ada_pspace_data_handle): Change type.
7476         (get_ada_pspace_data): Update.
7477         (ada_pspace_data_cleanup): Remove.
7478
7479 2019-05-08  Tom Tromey  <tom@tromey.com>
7480
7481         * coffread.c (struct coff_symfile_info): Add initializers.
7482         (coff_objfile_data_key): Move lower.  Change type.
7483         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7484         Update.
7485         (coff_free_info): Remove.
7486
7487 2019-05-08  Tom Tromey  <tom@tromey.com>
7488
7489         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7490         (fbsd_pspace_data_handle): Move lower.  Change type.
7491         (get_fbsd_pspace_data): Update.
7492         (fbsd_pspace_data_cleanup): Remove.
7493         (_initialize_fbsd_tdep): Update.
7494
7495 2019-05-08  Tom Tromey  <tom@tromey.com>
7496
7497         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7498         (get_ada_tasks_pspace_data): Update.
7499         (ada_tasks_pspace_data_cleanup): Remove.
7500         (_initialize_tasks): Update.
7501         (ada_tasks_inferior_data_handle): Change type.
7502         (get_ada_tasks_inferior_data): Update.
7503         (ada_tasks_inferior_data_cleanup): Remove.
7504         (struct ada_tasks_pspace_data): Add initializers.
7505
7506 2019-05-08  Tom Tromey  <tom@tromey.com>
7507
7508         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7509         * symfile-debug.c (debug_sym_get_probes): Change type.
7510         * stap-probe.c (handle_stap_probe):
7511         (stap_static_probe_ops::get_probes): Change type.
7512         * probe.h (class static_probe_ops) <get_probes>: Change type.
7513         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7514         (parse_probes_in_pspace): Update.
7515         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7516         Update.
7517         (any_static_probe_ops::get_probes): Change type.
7518         * elfread.c (elfread_data): New typedef.
7519         (probe_key): Change type.
7520         (elf_get_probes): Likewise.  Update.
7521         (probe_key_free): Remove.
7522         (_initialize_elfread): Update.
7523         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7524         Change type.
7525         (dtrace_process_dof_probe, dtrace_process_dof)
7526         (dtrace_static_probe_ops::get_probe): Change type.
7527
7528 2019-05-08  Tom Tromey  <tom@tromey.com>
7529
7530         * xcoffread.c (struct xcoff_symfile_info): Rename from
7531         coff_symfile_info.  Add initializers.
7532         (xcoff_objfile_data_key): Move lower.  Change type.
7533         (XCOFF_DATA): Rewrite.
7534         (xcoff_free_info): Remove.
7535         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7536         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7537         (xcoff_initial_scan): Update.
7538
7539 2019-05-08  Tom Tromey  <tom@tromey.com>
7540
7541         * solib-svr4.c (struct svr4_info): Add initializers and
7542         destructor.
7543         <probes_table>: Now an htab_up.
7544         (solib_svr4_pspace_data): Change type.
7545         (free_probes_table): Simplify.
7546         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7547         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7548         (probes_table_remove_objfile_probes, register_solib_event_probe)
7549         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7550         (_initialize_svr4_solib): Update.
7551
7552 2019-05-08  Tom Tromey  <tom@tromey.com>
7553
7554         * remote.c (remote_pspace_data): Change type.
7555         (remote_pspace_data_cleanup): Remove.
7556         (get_remote_exec_file, set_pspace_remote_exec_file)
7557         (_initialize_remote): Update.
7558
7559 2019-05-08  Tom Tromey  <tom@tromey.com>
7560
7561         * breakpoint.c (breakpoint_objfile_key): Change type.
7562         (get_breakpoint_objfile_data): Update.
7563         (free_breakpoint_objfile_data): Remove.
7564         (_initialize_breakpoint): Update.
7565
7566 2019-05-08  Tom Tromey  <tom@tromey.com>
7567
7568         * linux-tdep.c (struct linux_info): Add initializers.
7569         (linux_inferior_data): Move.  Change type.
7570         (invalidate_linux_cache_inf): Update.
7571         (linux_inferior_data_cleanup): Remove.
7572         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7573
7574 2019-05-08  Tom Tromey  <tom@tromey.com>
7575
7576         * auxv.c (auxv_inferior_data): Move.  Change type.
7577         (auxv_inferior_data_cleanup): Remove.
7578         (invalidate_auxv_cache_inf): Rewrite.
7579         (get_auxv_inferior_data, _initialize_auxv): Update.
7580
7581 2019-05-08  Tom Tromey  <tom@tromey.com>
7582
7583         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7584         (symfile_debug_objfile_data_key): Change type.
7585         (symfile_debug_installed, debug_qf_has_symbols)
7586         (debug_qf_find_last_source_symtab)
7587         (debug_qf_forget_cached_source_info)
7588         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7589         (debug_qf_print_stats, debug_qf_dump)
7590         (debug_qf_expand_symtabs_for_function)
7591         (debug_qf_expand_all_symtabs)
7592         (debug_qf_expand_symtabs_with_fullname)
7593         (debug_qf_map_matching_symbols)
7594         (debug_qf_expand_symtabs_matching)
7595         (debug_qf_find_pc_sect_compunit_symtab)
7596         (debug_qf_map_symbol_filenames)
7597         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7598         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7599         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7600         (debug_sym_read_linetable, debug_sym_relocate): Update.
7601         (symfile_debug_free_objfile): Remove.
7602         (install_symfile_debug_logging, _initialize_symfile_debug):
7603         Update.
7604
7605 2019-05-08  Tom Tromey  <tom@tromey.com>
7606
7607         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7608         allocate_on_obstack.
7609         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7610         (get_dwarf2_per_objfile): Update.
7611         (set_dwarf2_per_objfile): Remove.
7612         (dwarf2_has_info, dwarf2_get_section_info): Update.
7613         (dwarf2_free_objfile): Remove.
7614         (_initialize_dwarf2_read): Update.
7615
7616 2019-05-08  Tom Tromey  <tom@tromey.com>
7617
7618         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7619         initializers.
7620         <unsupported_script_warning_printed,
7621         script_not_found_warning_printed>: Now bool.
7622         (auto_load_pspace_data): Change type.
7623         (~auto_load_pspace_info): Rename from
7624         auto_load_pspace_data_cleanup.
7625         (get_auto_load_pspace_data, init_loaded_scripts_info)
7626         (clear_section_scripts, maybe_print_unsupported_script_warning)
7627         (maybe_print_script_not_found_warning, _initialize_auto_load):
7628         Update.
7629
7630 2019-05-08  Tom Tromey  <tom@tromey.com>
7631
7632         * objfiles.c (objfile_pspace_info): Add destructor and
7633         initializers.
7634         (objfiles_pspace_data): Change type.
7635         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7636         (get_objfile_pspace_data): Update.
7637         (objfiles_bfd_data): Change type.
7638         (get_objfile_bfd_data): Update.
7639         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7640
7641 2019-05-08  Tom Tromey  <tom@tromey.com>
7642
7643         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7644         Change type.
7645         (get_catch_syscall_inferior_data): Update.
7646         (catch_syscall_inferior_data_cleanup): Remove.
7647         (_initialize_break_catch_syscall): Update.
7648
7649 2019-05-08  Tom Tromey  <tom@tromey.com>
7650
7651         * inflow.c (struct terminal_info): Add destructor and
7652         initializers.
7653         (inflow_inferior_data): Change type.
7654         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7655         (get_inflow_inferior_data, inflow_inferior_exit)
7656         (swap_terminal_info, _initialize_inflow): Update.
7657
7658 2019-05-08  Tom Tromey  <tom@tromey.com>
7659
7660         * target-dcache.c (target_dcache_cleanup): Remove.
7661         (target_dcache_aspace_key): Change type.
7662         (target_dcache_init_p, target_dcache_invalidate)
7663         (target_dcache_get, target_dcache_get_or_init)
7664         (_initialize_target_dcache): Update.
7665         * dcache.h (struct dcache_deleter): New.
7666
7667 2019-05-08  Tom Tromey  <tom@tromey.com>
7668
7669         * symtab.c (struct symbol_cache): Add destructor and
7670         initializers.
7671         (symbol_cache_key): Move.  Change type.
7672         (make_symbol_cache, free_symbol_cache): Remove.
7673         (get_symbol_cache): Update.
7674         (symbol_cache_cleanup): Remove.
7675         (ALL_PSPACES, symbol_cache_flush)
7676         (maintenance_print_symbol_cache)
7677         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7678         Update.
7679
7680 2019-05-08  Tom Tromey  <tom@tromey.com>
7681
7682         * symtab.c (struct main_info): Add destructor and initializers.
7683         (main_progspace_key): Move.  Change type.
7684         (get_main_info): Update.
7685         (main_info_cleanup): Remove.
7686         (_initialize_symtab): Update.
7687
7688 2019-05-08  Tom Tromey  <tom@tromey.com>
7689
7690         * registry.h (DECLARE_REGISTRY): Define the _key class.
7691
7692 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * NEWS: Merge two 'New commands' sections.
7695
7696 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7697
7698         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7699         parameter and use Ada language definition instead.
7700         (ada_val_print_ptr): Remove unused language parameter.
7701         (ada_val_print_num): Remove language parameter and use Ada language
7702         definition instead.
7703         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7704         parameter.
7705         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7706         parameter and use Ada language definition instead.
7707         (ada_val_print_1): Update all ada_val_print_xxx calls.
7708         Remove language parameter.
7709         (ada_val_print): Update ada_val_print_1 call.
7710
7711 2019-05-08  Tom Tromey  <tromey@adacore.com>
7712
7713         * remote.c (remote_hw_watchpoint_limit)
7714         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7715         Now static.
7716
7717 2019-05-08  Tom Tromey  <tromey@adacore.com>
7718
7719         * maint.c (_initialize_maint_cmds): Move initialization code to
7720         remote.c.
7721         (watchdog, show_watchdog): Move to remote.c.
7722         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7723         "watchdog" static.
7724         (_initialize_remote): Move initialization code from maint.c.
7725         * defs.h (watchdog): Don't declare.
7726
7727 2019-05-08  Tom Tromey  <tromey@adacore.com>
7728
7729         * tui/tui-interp.c: Include main.h.
7730         * interps.c: Include main.h.
7731         * main.h (interpreter_p): Declare.
7732         * defs.h (interpreter_p): Don't declare.
7733
7734 2019-05-08  Tom Tromey  <tromey@adacore.com>
7735
7736         * dwarf2loc.c: Include dwarf2read.h.
7737         * defs.h (read_unsigned_leb128): Don't declare.
7738         * dwarf2read.h (read_unsigned_leb128): Declare.
7739
7740 2019-05-08  Tom Tromey  <tromey@adacore.com>
7741
7742         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7743         method.
7744
7745 2019-05-08  Tom Tromey  <tromey@adacore.com>
7746
7747         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7748         when no wrap column is set.
7749
7750 2019-05-08  Tom Tromey  <tromey@adacore.com>
7751
7752         * c-lang.c (c_get_string): Handle non-C-style arrays.
7753
7754 2019-05-08  Tom Tromey  <tromey@adacore.com>
7755
7756         * typeprint.c (print_offset_data::update): Print the bit offset,
7757         not the number of bits remaining.
7758
7759 2019-05-08  Tom Tromey  <tromey@adacore.com>
7760
7761         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7762         padding at end of comment.
7763
7764 2019-05-08  Tom Tromey  <tromey@adacore.com>
7765
7766         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7767         Compare main types.
7768
7769 2019-05-06  Tom Tromey  <tom@tromey.com>
7770
7771         * common/scoped_mmap.c: Include common-defs.h.
7772         * common/scoped_mmap.h: Don't include config.h.
7773
7774 2019-05-04  Tom Tromey  <tom@tromey.com>
7775
7776         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7777         (struct aarch64_call_info): Add initializers.
7778         <si>: Now a std::vector.
7779         (pass_on_stack, aarch64_push_dummy_call): Update.
7780
7781 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7782             Tom Tromey  <tom@tromey.com>
7783
7784         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7785         (ppc_threads): Now a std::vector.  Now static.
7786         (hwdebug_find_thread_points_by_tid)
7787         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7788         Update.
7789
7790 2019-05-04  Tom Tromey  <tom@tromey.com>
7791
7792         * arc-tdep.c (arc_tdesc_init): Return bool.
7793
7794 2019-05-04  Tom Tromey  <tom@tromey.com>
7795
7796         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7797         Use gdb_assert_not_reached.
7798
7799 2019-05-04  Tom Tromey  <tom@tromey.com>
7800
7801         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7802         "false".
7803
7804 2019-05-04  Tom Tromey  <tom@tromey.com>
7805
7806         * arc-tdep.c (arc_tdesc_init): Use bool.
7807
7808 2019-05-04  Tom Tromey  <tom@tromey.com>
7809
7810         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7811
7812 2019-05-04  Tom Tromey  <tom@tromey.com>
7813
7814         * cli/cli-cmds.c (valid_command_p): Return bool.
7815
7816 2019-05-04  Tom Tromey  <tom@tromey.com>
7817
7818         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7819         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7820
7821 2019-05-04  Raul Tambre  <raul@tambre.ee>
7822
7823         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7824         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7825         operator for comparison.
7826
7827 2019-05-04  Tom Tromey  <tom@tromey.com>
7828
7829         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7830         (lookup_partial_symbol, print_partial_symbols)
7831         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7832         (psymbol_compare): Update.
7833         (add_psymbol_to_bcache): Clear the entire psymbol.
7834         (maintenance_check_psymtabs): Update.
7835         * psympriv.h (struct partial_symbol): Don't derive from
7836         general_symbol_info.
7837         <obj_section, unrelocated_address, address,
7838         set_unrelocated_address>: Update.
7839         <ginfo>: New member.
7840         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7841         (debug_names::write_psymbols): Update.
7842
7843 2019-05-04  Tom de Vries  <tdevries@suse.de>
7844
7845         * contrib/cc-with-tweaks.sh: Support -n arg.
7846
7847 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7848
7849         * corelow.c (core_target::detach): Ensure frame cache and
7850         register caches are cleared.
7851         inferior.c (exit_inferior_1): Likewise.
7852
7853 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7854             Tom Tromey  <tom@tromey.com>
7855
7856         * dictionary.c (collate_pending_symbols_by_language): Remove
7857         "struct" from foreach.
7858         * symtab.c (lookup_global_symbol_from_objfile)
7859         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7860         foreach.
7861         * ser-tcp.c (net_open): Remove "struct" from foreach.
7862         * objfiles.c (objfile_relocate, objfile_rebase)
7863         (objfile_has_symbols): Remove "struct" from foreach.
7864         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7865         from foreach.
7866         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7867         foreach.
7868         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7869         "struct" from foreach.
7870         * ada-lang.c (create_excep_cond_exprs)
7871         (ada_exception_catchpoint_cond_string): Remove "struct" from
7872         foreach.
7873
7874 2019-05-03  Tom Tromey  <tromey@adacore.com>
7875
7876         * ada-exp.y (convert_char_literal): Check suffix of each
7877         enumerator.
7878
7879 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7880
7881         PR ada/21406:
7882         * ada-exp.y (yywrap): Don't define.
7883         * ada-lex.l (%option): Add noyywrap
7884         (yywrap): Remove.
7885
7886 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7887
7888         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7889         _WIN32_WINNT to the XP level, unless already defined to a higher
7890         level.
7891
7892         * unittests/parse-connection-spec-selftests.c:
7893         * ser-tcp.c:
7894         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7895         override.
7896
7897         * symfile.c (find_separate_debug_file): Remove colon from the
7898         drive spec of DOS/Windows file names of the target, so that the
7899         file name produced from DEBUGDIR and the target's directory will
7900         be valid on DOS/Windows systems.
7901
7902 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7903
7904         * rust-lang.c (val_print_struct): Handle printing structures
7905         containing strings.
7906
7907 2019-05-02  Tom Tromey  <tromey@adacore.com>
7908
7909         * valarith.c (_initialize_valarith): Remove.
7910
7911 2019-05-01  Tom Tromey  <tromey@adacore.com>
7912
7913         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7914         bitfields.
7915
7916 2019-05-01  Tom Tromey  <tromey@adacore.com>
7917
7918         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7919         for big-endian copies.
7920
7921 2019-04-30  Ali Tamur  <tamur@google.com>
7922         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7923         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7924         (read_3_bytes): New function.
7925
7926 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7927
7928         * windows-nat.c (main_thread_id): Delete.
7929         (handle_output_debug_string): Replace main_thread_id by
7930         current_event.dwThreadId.
7931         (fake_create_process): Likewise.
7932         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7933         Do not set main_thread_id.
7934         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7935         current_event.dwThreadId.
7936         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7937
7938 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7939
7940         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7941         Use current_event.dwThreadId instead of main_thread_id.
7942
7943 2019-04-30  Tom Tromey  <tromey@adacore.com>
7944
7945         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7946         (create_excep_cond_exprs): Iterate over program spaces.
7947         (ada_exception_catchpoint_cond_string): Examine all minimal
7948         symbols for exception types.
7949
7950 2019-04-30  Tom Tromey  <tromey@adacore.com>
7951
7952         PR c++/24470:
7953         * dwarf2read.c (process_structure_scope): Handle case where type
7954         has template parameters but no symbol was created.
7955
7956 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7957             Chris January  <chris.january@arm.com>
7958
7959         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7960         qualifier.
7961         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7962
7963 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7964
7965         * f-typeprint.c (f_print_type): Update rules for printing
7966         whitespace.
7967         (f_type_print_varspec_suffix): Likewise.
7968
7969 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7970             Chris January  <chris.january@arm.com>
7971
7972         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7973         function arguments.
7974
7975 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7976
7977         * f-lang.c (build_fortran_types): Change name of void type to
7978         lower case.
7979         * f-typeprint.c (f_type_print_base): Print the name of the void
7980         type, rather than a fixed string.
7981         * f-valprint.c (f_decorations): Use lower case void string.
7982
7983 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7984             Chris January  <chris.january@arm.com>
7985
7986         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7987         types for Fortran.
7988
7989 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7990             Chris January  <chris.january@arm.com>
7991             David Lecomber  <david.lecomber@arm.com>
7992
7993         * f-exp.y (BINOP_INTRINSIC): New token.
7994         (exp): New parser rule handling BINOP_INTRINSIC.
7995         (f77_keywords): Add new builtin procedures.
7996         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7997         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7998         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7999         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8000         (print_unop_subexp_f): New function.
8001         (print_binop_subexp_f): New function.
8002         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8003         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8004         (dump_subexp_body_f): Likewise.
8005         (operator_check_f): Likewise.
8006         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8007         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8008
8009 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8010
8011         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8012         UNOP_KIND.
8013         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8014         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8015         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8016         (operator_length_f): New fuction.
8017         (print_subexp_f): New function.
8018         (op_name_f): New function.
8019         (dump_subexp_body_f): New function.
8020         (operator_check_f): New function.
8021         (exp_descriptor_f): Replace standard expression handling functions
8022         with new functions.
8023         * gdb/fortran-operator.def: New file.
8024         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8025         * gdb/std-operator.def: Remove UNOP_KIND.
8026
8027 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8028
8029         * std-operator.def: Remove unbalanced, stray double quote
8030         character.
8031
8032 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8033             Chris January  <chris.january@arm.com>
8034             Daniel Everett  <daniel.everett@arm.com>
8035             Nick Forrington  <nick.forrington@arm.com>
8036             Richard Bunt  <richard.bunt@arm.com>
8037
8038         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8039         of depth when printing anonymous structs or unions.
8040         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8041         Don't print either the top-level value, or the children if the
8042         max-depth is exceeded.
8043         (ppscm_print_children): When printing the key of a map, allow one
8044         extra level of depth.
8045         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8046         print either the top-level value, or the children if the max-depth
8047         is exceeded.
8048         (print_children): When printing the key of a map, allow one extra
8049         level of depth.
8050         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8051         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8052         (user_print_options): Initialise max_depth field.
8053         (val_print_scalar_or_string_type_p): New function.
8054         (val_print): Check to see if the max depth has been reached.
8055         (val_print_check_max_depth): Define new function.
8056         (show_print_max_depth): New function.
8057         (_initialize_valprint): Add 'print max-depth' option.
8058         * valprint.h (struct value_print_options) <max_depth>: New field.
8059         (val_print_check_max_depth): Declare new function.
8060         * NEWS: Document new feature.
8061
8062 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8063
8064         * ada-lang.c (ada_language_defn): Initialise new field.
8065         * c-lang.c (c_is_string_type_p): New function.
8066         (c_language_defn): Initialise new field.
8067         (cplus_language_defn): Initialise new field.
8068         (asm_language_defn): Initialise new field.
8069         (minimal_language_defn): Initialise new field.
8070         * c-lang.h (c_is_string_type_p): Declare new function.
8071         * d-lang.c (d_language_defn): Initialise new field.
8072         * f-lang.c (f_is_string_type_p): New function.
8073         (f_language_defn): Initialise new field.
8074         * go-lang.c (go_is_string_type_p): New function.
8075         (go_language_defn): Initialise new field.
8076         * language.c (default_is_string_type_p): New function.
8077         (unknown_language_defn): Initialise new field.
8078         (auto_language_defn): Initialise new field.
8079         * language.h (struct language_defn) <la_is_string_type_p>: New
8080         member variable.
8081         (default_is_string_type_p): Declare new function.
8082         * m2-lang.c (m2_language_defn): Initialise new field.
8083         * objc-lang.c (objc_language_defn): Initialise new field.
8084         * opencl-lang.c (opencl_language_defn): Initialise new field.
8085         * p-lang.c (pascal_is_string_type_p): New function.
8086         (pascal_language_defn): Initialise new field.
8087         * rust-lang.c (rust_is_string_type_p): New function.
8088         (rust_language_defn): Initialise new field.
8089
8090 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8091
8092         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8093         New field.
8094         * ada-lang.c (ada_language_defn): Initialise new field.
8095         * c-lang.c (c_language_defn): Likewise.
8096         (cplus_language_defn): Likewise.
8097         (asm_language_defn): Likewise.
8098         (minimal_language_defn): Likewise.
8099         * d-lang.c (d_language_defn): Likewise.
8100         * f-lang.c (f_language_defn): Likewise.
8101         * go-lang.c (go_language_defn): Likewise.
8102         * language.c (unknown_language_defn): Likewise.
8103         (auto_language_defn): Likewise.
8104         * m2-lang.c (m2_language_defn): Likewise.
8105         * objc-lang.c (objc_language_defn): Likewise.
8106         * opencl-lang.c (opencl_language_defn): Likewise.
8107         * p-lang.c (pascal_language_defn): Likewise.
8108         * rust-lang.c (rust_language_defn): Likewise.
8109
8110 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8111
8112         * ada-lang.c (ada_is_character_type): Change return type to bool.
8113         (ada_is_string_type): Likewise.
8114         * ada-lang.h (ada_is_character_type): Update declaration
8115         (ada_is_string_type): Likewise.
8116
8117 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8118
8119         Support style in 'frame|thread apply'
8120
8121         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8122         * record.c (record_start, record_stop): Update callers of
8123         execute_command_to_string with false.
8124         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8125         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8126         methods.
8127         (class string_file): New constructor with term_out parameter.
8128         Override methods term_out and can_emit_style_escape.  New member
8129         term_out.
8130         (class stdio_file): Override can_emit_style_escape.
8131         (class tee_file): Override term_out and can_emit_style_escape.
8132         * utils.h (can_emit_style_escape): Remove.
8133         * utils.c (can_emit_style_escape): Likewise.
8134         Update all callers of can_emit_style_escape (SOMESTREAM) to
8135         SOMESTREAM->can_emit_style_escape.
8136         * source-cache.c (source_cache::get_source_lines): Likewise.
8137         * stack.c (frame_apply_command_count): Call execute_command_to_string
8138         passing the term_out characteristic of the current gdb_stdout.
8139         * thread.c (thr_try_catch_cmd): Likewise.
8140         * top.c (execute_command_to_string): pass term_out parameter
8141         to construct the string_file for the command output.
8142         * ui-file.c (term_cli_styling): New function (most code moved
8143         from utils.c can_emit_style_escape).
8144         (string_file::string_file, string_file::can_emit_style_escape,
8145         stdio_file::can_emit_style_escape, tee_file::term_out,
8146         tee_file::can_emit_style_escape): New functions.
8147
8148 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8149
8150         * NEWS: Mention the new set|show may-call-functions.
8151         * infcall.c (may_call_functions_p): New variable.
8152         (show_may_call_functions_p): New function.
8153         (call_function_by_hand_dummy): Throws an error if not
8154         may-call-functions.
8155         (_initialize_infcall): Call add_setshow_boolean_cmd for
8156         may-call-functions.
8157
8158 2019-04-25  Keith Seitz  <keiths@redhat.com>
8159
8160         PR c++/24367
8161         * cp-support.c (inspect_type): Don't attempt substitutions
8162         of symbol with the same name.
8163
8164 2019-04-25  Tom Tromey  <tromey@adacore.com>
8165
8166         PR gdb/24475:
8167         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8168         static.
8169
8170 2019-04-25  Tom Tromey  <tromey@adacore.com>
8171
8172         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8173         rvalue reference.
8174         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8175         (gdb_xml_parser::parse): Use std::move.
8176         * python/python-internal.h (gdbpy_convert_exception): Take a const
8177         reference.
8178         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8179         std::move.
8180         * python/py-utils.c (gdbpy_convert_exception): Take a const
8181         reference.
8182         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8183         Use std::move.
8184         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8185         Use std::move.
8186         * mi/mi-main.c (mi_print_exception): Take a const reference.
8187         * main.c (handle_command_errors): Take a const reference.
8188         * linespec.c (parse_linespec): Use std::move.
8189         * infcall.c (run_inferior_call): Use std::move.
8190         (call_function_by_hand_dummy): Use std::move.
8191         * exec.c (try_open_exec_file): Use std::move.
8192         * exceptions.h (exception_print, exception_fprintf)
8193         (exception_print_same): Update.
8194         * exceptions.c (print_exception, exception_print)
8195         (exception_fprintf, exception_print_same): Change parameters to
8196         const reference.
8197         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8198         * common/new-op.c: Use std::move.
8199         * common/common-exceptions.h (struct gdb_exception): Add move
8200         constructor.
8201         (struct gdb_exception_error, struct gdb_exception_quit, struct
8202         gdb_quit_bad_alloc): Change constructor to move constructor.
8203         (throw_exception): Change parameter to rvalue reference.
8204         * common/common-exceptions.c (throw_exception): Take rvalue
8205         reference.
8206         * cli/cli-interp.c (safe_execute_command): Use std::move.
8207         * breakpoint.c (insert_bp_location, location_to_sals): Use
8208         std::move.
8209
8210 2019-04-25  Tom Tromey  <tromey@adacore.com>
8211
8212         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8213         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8214         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8215         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8216         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8217         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8218         guile/scm-value.c: Use unpack.
8219         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8220         gdbscm_gdb_exception.
8221         (gdbscm_throw_gdb_exception): Likewise.
8222         (struct gdbscm_gdb_exception): New.
8223         (unpack): New function.
8224         (gdbscm_wrap): Use unpack.
8225
8226 2019-04-25  Tom Tromey  <tromey@adacore.com>
8227
8228         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8229         (gdb_rl_callback_handler): Use std::move.
8230         * common/common-exceptions.h (struct gdb_exception): Add move
8231         assignment operator.
8232         (throw_exception_sjlj): Change "exception" to const reference.
8233         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8234         (throw_exception_sjlj): Change "exception" to const reference.
8235
8236 2019-04-25  Tom Tromey  <tromey@adacore.com>
8237
8238         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8239         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8240         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8241         Update.
8242         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8243         Update.
8244         * mi/mi-interp.c (mi_interp::exec): Update.
8245         * linespec.c (parse_linespec): Update.
8246         * infcall.c (run_inferior_call): Update.
8247         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8248         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8249         (gdbscm_lookup_global_symbol): Update.
8250         * guile/scm-param.c (gdbscm_parameter_value): Update.
8251         * guile/scm-frame.c (gdbscm_frame_read_register)
8252         (gdbscm_frame_read_var): Update.
8253         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8254         * exec.c (try_open_exec_file): Update.
8255         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8256         (gdb_rl_callback_handler): Update.
8257         * common/common-exceptions.h (exception_none): Don't declare.
8258         * common/common-exceptions.c (exception_none): Don't define.
8259         (struct catcher) <exception>: Update.
8260         * cli/cli-interp.c (safe_execute_command): Update.
8261         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8262
8263 2019-04-25  Ali Tamur  <tamur@google.com>
8264
8265         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8266         (read_attribute_value): Likewise.
8267         (dwarf2_read_addr_index): Update comment.
8268         (read_str_index): Add DW_FORM_strx.
8269         (dwarf2_string_attr): Likewise.
8270         (dwarf2_const_value_attr): Likewise.
8271         (dump_die_shallow): Likewise.
8272         (dwarf2_fetch_constant_bytes): Likewise.
8273         (skip_form_bytes): Likewise.
8274         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8275
8276 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8277
8278         PR corefiles/11608
8279         PR corefiles/18187
8280         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8281         OFFSET.  Verify if current mapping contains an ELF header.
8282         (linux_find_memory_regions_full): Adjust call to
8283         dump_mapping_p.
8284
8285 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8286             Kang Li <kanglictf@gmail.com>
8287
8288         PR gdb/21600
8289
8290         * dwarf2-frame.c (read_initial_length): Be consistent about using
8291         unsigned representation of length.
8292         (decode_frame_entry_1): Likewise.  Check for wraparound of
8293         end pointer as well as buffer overflow.
8294
8295 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8296
8297         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8298         "vq".
8299
8300 2019-04-24  Tom Tromey  <tromey@adacore.com>
8301
8302         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8303
8304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8305
8306         * s12z-tdep.c (s12z_unwind_pc): Delete.
8307         (s12z_unwind_sp): Delete.
8308         (s12z_gdbarch_init): Don't register deleted functions with
8309         gdbarch.
8310
8311 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8312
8313         * rl78-tdep.c (rl78_unwind_sp): Delete.
8314         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8315
8316 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8317
8318         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8319         (xstormy16_unwind_pc): Delete.
8320         (xstormy16_dummy_id): Delete.
8321         (xstormy16_gdbarch_init): Don't register deleted functions with
8322         gdbarch.
8323
8324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8325
8326         * vax-tdep.c (vax_unwind_pc): Delete.
8327         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8328
8329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8330
8331         * v850-tdep.c (v850_unwind_sp): Delete.
8332         (v850_unwind_pc): Delete.
8333         (v850_dummy_id): Delete.
8334         (v850_gdbarch_init): Don't register deleted functions with
8335         gdbarch.
8336
8337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8338
8339         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8340         (tilegx_unwind_pc): Delete.
8341         (tilegx_unwind_dummy_id): Delete.
8342         (tilegx_gdbarch_init): Don't register deleted functions with
8343         gdbarch.
8344
8345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8346
8347         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8348         (tic6x_dummy_id): Delete.
8349         (tic6x_gdbarch_init): Don't register deleted functions with
8350         gdbarch.
8351
8352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8353
8354         * sparc-tdep.c (sparc_unwind_pc): Delete.
8355         (sparc32_gdbarch_init): Don't register deleted function with
8356         gdbarch.
8357
8358 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8359
8360         * sh-tdep.c (sh_unwind_sp): Delete.
8361         (sh_unwind_pc): Delete.
8362         (sh_dummy_id): Delete.
8363         (sh_gdbarch_init): Don't register deleted functions with
8364         gdbarch.
8365
8366 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8367
8368         * score-tdep.c (score_unwind_sp): Delete.
8369         (score_unwind_pc): Delete.
8370         (score_dummy_id): Delete.
8371         (score_gdbarch_init): Don't register deleted functions with
8372         gdbarch.
8373
8374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8375
8376         * rx-tdep.c (rx_unwind_pc): Delete.
8377         (rx_unwind_sp): Delete.
8378         (rx_dummy_id): Delete.
8379         (rx_gdbarch_init): Don't register deleted functions with
8380         gdbarch.  Update comment.
8381
8382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8383
8384         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8385         (rs6000_dummy_id): Delete.
8386         (rs6000_gdbarch_init): Don't register deleted functions with
8387         gdbarch.
8388
8389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8390
8391         * or1k-tdep.c (or1k_dummy_id): Delete.
8392         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8393
8394 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8395
8396         * nios2-tdep.c (nios2_dummy_id): Delete.
8397         (nios2_unwind_sp): Delete.
8398         (nios2_gdbarch_init): Don't register deleted functions with
8399         gdbarch.
8400
8401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8402
8403         * nds32-tdep.c (nds32_dummy_id): Delete.
8404         (nds32_unwind_pc): Delete.
8405         (nds32_unwind_sp): Delete.
8406         (nds32_gdbarch_init): Don't register deleted functions with
8407         gdbarch.
8408
8409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8410
8411         * msp430-tdep.c (msp430_unwind_pc): Delete.
8412         (msp430_unwind_sp): Delete.
8413         (msp430_dummy_id): Delete.
8414         (msp430_gdbarch_init): Don't register deleted functions with
8415         gdbarch.
8416
8417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8418
8419         * moxie-tdep.c (moxie_unwind_sp): Delete.
8420         (moxie_unwind_pc): Delete.
8421         (moxie_dummy_id): Delete.
8422         (moxie_gdbarch_init): Don't register deleted functions with
8423         gdbarch.
8424
8425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8426
8427         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8428         (mn10300_unwind_pc): Delete.
8429         (mn10300_unwind_sp): Delete.
8430         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8431         mn10300_unwind_sp.
8432         (mn10300_frame_unwind_init): Don't register deleted functions with
8433         gdbarch.
8434
8435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8436
8437         * mep-tdep.c (mep_unwind_pc): Delete.
8438         (mep_unwind_sp): Delete.
8439         (mep_dummy_id): Delete.
8440         (mep_gdbarch_init): Don't register deleted functions with
8441         gdbarch.
8442
8443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8444
8445         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8446         (m68hc11_unwind_sp): Delete.
8447         (m68hc11_gdbarch_init): Don't register deleted functions with
8448         gdbarch.
8449
8450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8451
8452         * m32r-tdep.c (m32r_unwind_sp): Delete.
8453         (m32r_unwind_pc): Delete.
8454         (m32r_dummy_id): Delete.
8455         (m32r_gdbarch_init): Don't register deleted functions with
8456         gdbarch.
8457
8458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8459
8460         * m32c-tdep.c (m32c_unwind_pc): Delete.
8461         (m32c_unwind_sp): Delete.
8462         (m32c_dummy_id): Delete.
8463         (m32c_gdbarch_init): Don't register deleted functions with
8464         gdbarch.
8465
8466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8467
8468         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8469         (lm32_unwind_pc): Delete.
8470         (lm32_dummy_id): Delete.
8471         (lm32_gdbarch_init): Don't register deleted functions with
8472         gdbarch.
8473
8474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8475
8476         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8477         (iq2000_unwind_pc): Delete.
8478         (iq2000_dummy_id): Delete.
8479         (iq2000_gdbarch_init): Don't register deleted functions with
8480         gdbarch.
8481
8482 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8483
8484         * nds32-tdep.c (nds32_type_align): Delete.
8485         (nds32_push_dummy_call): Use type_align instead.
8486
8487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8488
8489         * arm-tdep.c (arm_type_align): Only handle vector override case.
8490         (arm_push_dummy_call): Use type_align.
8491         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8492
8493 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8494
8495         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8496         case.
8497         (pass_on_stack): Use type_align.
8498         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8499         function.
8500
8501 2019-04-23  Tom Tromey  <tromey@adacore.com>
8502
8503         * dwarf2read.c (line_header::file_name_at): Remove unused
8504         overload.
8505
8506 2019-04-23  Tom de Vries  <tdevries@suse.de>
8507
8508         PR gdb/24438
8509         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8510         invocation.
8511
8512
8513 2019-03-27  Ali Tamur  <tamur@google.com>
8514
8515         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8516         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8517         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8518         (dwarf_expr_context::get_addr_index): Likewise
8519         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8520         (symbol_needs_eval_context::get_addr_index): Likewise
8521         (disassemble_dwarf_expression): Add DW_OP_addrx
8522         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8523         (read_cutu_die_from_dwo): Update comment
8524         (skip_one_die): Add DW_FORM_addrx
8525         (read_attribute_value): Likewise
8526         (var_decode_location): Add DW_OP_addrx
8527         (dwarf2_const_value_attr): Add DW_FORM_addrx
8528         (dump_die_shallow): Likewise
8529         (dwarf2_fetch_constant_bytes): Likewise
8530         (decode_locdesc): Add DW_OP_addrx
8531         (skip_form_bytes): Add DW_FORM_addrx
8532
8533 2019-04-22  Ali Tamur  <tamur@google.com>
8534
8535         * MAINTAINERS (Write After Approval): Add self.
8536
8537 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8538
8539         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8540         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8541         (open_symbol_file_object): Likewise.
8542         (svr4_default_sos): Add info parameter.
8543         (svr4_read_so_list): Likewise.
8544         (svr4_current_sos_direct): Adjust functions calls to pass down
8545         info.
8546         (svr4_current_sos_1): Add info parameter.
8547         (svr4_current_sos): Call get_svr4_info, pass info down to
8548         svr4_current_sos_1.
8549         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8550         get_svr4_info.
8551         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8552         get_svr4_info.
8553         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8554         to get_svr4_info.
8555         (probes_table_remove_objfile_probes): Likewise.
8556         (register_solib_event_probe): Add info parameter.
8557         (solist_update_incremental): Pass info parameter down to
8558         svr4_read_so_list.
8559         (disable_probes_interface): Add info parameter.
8560         (svr4_handle_solib_event): Pass current_program_space to
8561         get_svr4_info.  Adjust disable_probes_interface cleanup.
8562         (svr4_create_probe_breakpoints): Add info parameter, pass it
8563         down to register_solib_event_probe.
8564         (svr4_create_solib_event_breakpoints): Add info parameter,
8565         pass it down to svr4_create_probe_breakpoints.
8566         (enable_break): Pass info down to
8567         svr4_create_solib_event_breakpoints.
8568         (svr4_solib_create_inferior_hook): Pass current_program_space to
8569         get_svr4_info.
8570         (svr4_clear_solib): Likewise.
8571
8572 2019-04-22  Pedro Alves  <palves@redhat.com>
8573
8574         * solib-svr4.c (svr4_free_objfile_observer): New.
8575         (probe_and_action::objfile): New field.
8576         (probes_table_htab_remove_objfile_probes)
8577         (probes_table_remove_objfile_probes): New functions.
8578         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8579         in the new probe_and_action.  Don't store the probe in 'lookup'.
8580         (svr4_create_probe_breakpoints): Pass objfile to
8581         register_solib_event_probe.
8582         (_initialize_svr4_solib): Register a free_objfile observer.
8583
8584 2019-04-19  Tom Tromey  <tom@tromey.com>
8585
8586         * common/queue.h: Remove.
8587
8588 2019-04-19  Tom Tromey  <tom@tromey.com>
8589
8590         * event-loop.c: Don't include "common/queue.h".
8591
8592 2019-04-19  Tom Tromey  <tom@tromey.com>
8593
8594         * remote.c (remote_target): Use delete.
8595         * remote-notif.h: Include <list>, not "common/queue.h".
8596         (notif_client_p): Remove typedef.
8597         (remote_notif_state): Add constructor, destructor, initializer.
8598         <notif_queue>: Now a std::list.
8599         (remote_notif_state_xfree): Don't declare.
8600         * remote-notif.c (remote_notif_process, handle_notification)
8601         (remote_notif_state_allocate): Update.
8602         (~remote_notif_state): Rename from remote_notif_state_xfree.
8603
8604 2019-04-19  Tom Tromey  <tom@tromey.com>
8605
8606         * symfile.c (reread_symbols): Update.
8607         * objfiles.c (objfile_register_static_link)
8608         (objfile_lookup_static_link): Update
8609         (~objfile) Don't delete static_links.
8610         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8611
8612 2019-04-19  Tom Tromey  <tom@tromey.com>
8613
8614         * type-stack.h (struct type_stack) <insert>: Constify string.
8615         * type-stack.c (type_stack::insert): Constify string.
8616         * gdbtypes.h (lookup_template_type): Update.
8617         (address_space_name_to_int): Update.
8618         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8619         const.
8620         (lookup_template_type): Make name const.
8621         * c-exp.y: Update rules.
8622         (lex_one_token, classify_name, classify_inner_name)
8623         (c_print_token): Update.
8624         * p-exp.y: Update rules.
8625         (yylex): Update.
8626         * f-exp.y: Update rules.
8627         (yylex): Update.
8628         * d-exp.y: Update rules.
8629         (lex_one_token, classify_name, classify_inner_name): Update.
8630         * parse.c (write_dollar_variable, copy_name): Return std::string.
8631         * parser-defs.h (copy_name): Change return type.
8632         * m2-exp.y: Update rules.
8633         (yylex): Update.
8634         * go-exp.y (lex_one_token): Update.
8635         Update rules.
8636         (classify_unsafe_function, classify_packaged_name)
8637         (classify_name, yylex): Update.
8638
8639 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8640
8641         * configure.ac: add --enable-source-highlight switch.
8642         * configure: Regenerate.
8643         * top.c (print_gdb_version): plumb --enable-source-highlight
8644         status to "show configuration".
8645
8646 2019-04-19  Tom Tromey  <tromey@adacore.com>
8647
8648         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8649         Check ADA_TYPE_P.
8650         (empty_record, ada_template_to_fixed_record_type_1)
8651         (template_to_static_fixed_type)
8652         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8653         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8654         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8655         macros.
8656
8657 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8658
8659         PR symtab/24423:
8660         * source.c (print_source_lines_base): Advance "iter" when a
8661         control character is seen.
8662
8663 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8664
8665         * inferior.h (struct infcall_suspend_state_deleter):
8666         Catch exception in destructor to avoid crash.
8667
8668 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8669
8670         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8671         close to the add_com "shell".
8672
8673 2019-04-18  Tom Tromey  <tromey@adacore.com>
8674
8675         * process-stratum-target.h (class process_stratum_target)
8676         <stratum>: Add "final".
8677
8678 2019-04-17  Tom Tromey  <tromey@adacore.com>
8679
8680         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8681         against nullptr before use.
8682
8683 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8684
8685         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8686
8687 2019-04-17  Jim Wilson  <jimw@sifive.com>
8688             Andrew Burgess  <andrew.burgess@embecosm.com>
8689
8690         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8691         code read might fail, assume 4-byte breakpoint in that case.
8692
8693 2019-04-15  Leszek Swirski  <leszeks@google.com>
8694
8695         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8696         rather than a hand-rolled POD check when checking for forced MEMORY
8697         classification.
8698
8699 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8700
8701         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8702         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8703         function.
8704         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8705         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8706         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8707         declaration.
8708
8709 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8710
8711         * aarch64-linux-nat.c
8712         (aarch64_linux_nat_target::thread_architecture): Add override.
8713         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8714         each VQ.
8715
8716 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8717
8718         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8719
8720 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8721
8722         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8723         target types of size 96-bits, add some additional comments, and
8724         check that the builtin type we found was the correct size.
8725
8726 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8727
8728         * utils.c (prompt_for_continue): Don't restore the styling at the
8729         end, as applied_style has the wrong value.  This fixes styling in
8730         long lists of file names that are interrupted by the "Continue?"
8731         prompt.
8732
8733 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8734
8735         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8736         * c-lang.c (c_language_defn): Likewise.
8737         (cplus_language_defn): Likewise.
8738         (asm_language_defn): Likewise.
8739         (minimal_language_defn): Likewise.
8740         * d-lang.c (d_language_defn): Likewise.
8741         * f-lang.c (f_language_defn): Likewise.
8742         * go-lang.c (go_language_defn): Likewise.
8743         * language.c (unknown_language_defn): Likewise.
8744         (auto_language_defn): Likewise.
8745         * language.h (struct language_defn): Remove la_magic field.
8746         (LANG_MAGIC): Delete.
8747         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8748         * objc-lang.c (objc_language_defn): Likewise.
8749         * opencl-lang.c (opencl_language_defn): Likewise.
8750         * p-lang.c (pascal_language_defn): Likewise.
8751         * rust-lang.c (rust_language_defn): Likewise.
8752
8753 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8754
8755         * riscv-tdep.c (riscv_type_align): New function.
8756         (riscv_type_alignment): Delete.
8757         (riscv_arg_location): Use 'type_align'.
8758         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8759
8760 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8761
8762         * gdbtypes.c (type_align): A struct with no non-static fields also
8763         has alignment of 1.
8764
8765 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8766
8767         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8768         component to 0.
8769         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8770         member.
8771         (riscv_struct_info::analyse): New implementation using new
8772         analyse_inner member function.
8773         (riscv_struct_info::field_offset): New member function.
8774         (riscv_struct_info::m_offsets): New member variable.
8775         (riscv_struct_info::analyse_inner): New private member function,
8776         takes the old implementation of riscv_struct_info::analyse but
8777         extended to track field offsets.
8778         (riscv_call_arg_struct): Update the struct folding special cases
8779         to handle cases where empty C++ structs, which are non-zero
8780         length, are found.
8781         (riscv_arg_location): Initialise the length of each location, a
8782         non-zero length now indicates the location is in use.
8783         (riscv_push_dummy_call): Allow for the first location having a
8784         non-zero offset when setting up arguments.
8785         (riscv_return_value): Likewise, but for return values.
8786
8787 2019-04-11  Tom Tromey  <tromey@adacore.com>
8788
8789         * utils.c (internal_vproblem): Make "msg" const.
8790
8791 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8792
8793         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8794         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8795         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8796         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8797
8798 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8799
8800         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8801         function.
8802         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8803         of amd64_collect_native_gregset.
8804         (amd64_linux_nat_target::store_registers): Likewise.
8805
8806 2019-04-10  Tom Tromey  <tom@tromey.com>
8807
8808         * symtab.c (lookup_global_symbol_from_objfile)
8809         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8810         * objfiles.h (class separate_debug_iterator): New.
8811         (class separate_debug_range): New.
8812         (struct objfile) <separate_debug_objfiles>: New method.
8813         (objfile_separate_debug_iterate): Don't declare.
8814         * objfiles.c (separate_debug_iterator::operator++): Rename from
8815         objfile_separate_debug_iterate.
8816         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8817         iterator.
8818         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8819         iterator.
8820
8821 2019-04-10  Tom Tromey  <tom@tromey.com>
8822
8823         * symfile.c (reread_symbols): Remove old comment.
8824         * objfiles.c (free_all_objfiles): Fix a typo.
8825
8826 2019-04-10  Tom Tromey  <tom@tromey.com>
8827
8828         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8829         * minsyms.c (lookup_minimal_symbol): Use foreach.
8830         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8831         (lookup_minimal_symbol_solib_trampoline): Likewise.
8832         * symfile.c (reread_symbols): Use foreach.
8833
8834 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8835             Tom Tromey  <tromey@adacore.com>
8836
8837         PR rust/24414:
8838         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8839         (rust_lex_int_test): Change "value" to be LONGEST.
8840         (rust_lex_tests): Add test for long integer literal.
8841
8842 2019-04-09  Tom Tromey  <tromey@adacore.com>
8843
8844         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8845         to bool.
8846         (extended_remote_target::attach): Update.
8847         (remote_target::remote_notice_new_inferior): Update.
8848         (remote_target::add_current_inferior_and_thread): Update.
8849         * inferior.c (exit_inferior_1): Use "false".
8850         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8851
8852 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8853
8854         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8855         the "start" command.
8856
8857 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8858
8859         * python/py-inferior.c (infpy_thread_from_thread_handle):
8860         Adjust comments to reflect renaming of thread_from_thread_handle
8861         to thread_from_handle.  Adjust keywords.  Fix type error message.
8862         (inferior_object_methods): Add thread_from_handle.  Retain
8863         thread_from_thread_handle, but mark it as deprecated.
8864
8865 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8866
8867         * gdbthread.h (find_thread_by_handle): Revise declaration.
8868         * thread.c (find_thread_by_handle): Likewise.  Adjust
8869         implementation too.
8870         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8871         support for buffer objects as handles.
8872
8873 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8874
8875         * python/py-infthread.c (thpy_thread_handle): New function.
8876         (thread_object_methods): Register thpy_thread_handle.
8877
8878 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8879
8880         * gdbthread.h (thread_to_thread_handle): Declare.
8881         * thread.c (gdbtypes.h): Include.
8882         (thread_to_thread_handle): New function.
8883
8884         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8885         (target_thread_info_to_thread_handle): Declare.
8886         * target.c (target_thread_info_to_thread_handle): New function.
8887         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8888         * target-delegates.c: Regenerate.
8889
8890         * linux-thread-db.c (class thread_db_target): Add method
8891         thread_info_to_thread_handle.
8892         (thread_db_target::thread_info_to_thread_handle): Define.
8893         * remote.c (class remote_target): Add new method
8894         thread_info_to_thread_handle.
8895         (remote_target::thread_info_to_thread_handle): Define.
8896
8897 2019-04-08  Pedro Alves  <palves@redhat.com>
8898
8899         * common/common-exceptions.c (throw_exception): Don't create
8900         named object to throw; throw directly.
8901         (throw_it): Likewise.  Don't initialize gdb_exception::message
8902         here, with new; pass FMT and AP to the ctor instead.
8903         * common/common-exceptions.h: Include <string>.
8904         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8905         const char *, va_list)): New ctor.  Use std::make_shared.
8906         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8907         errors)): Delete.
8908         (gdb_exception_error::gdb_exception_error(enum errors, const char
8909         *, va_list)): New.
8910         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8911         Add assertion.
8912         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8913         errors)): Delete.
8914         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8915         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8916         Add assertion.
8917
8918 2019-04-08  Tom Tromey  <tom@tromey.com>
8919
8920         * valops.c (value_rtti_indirect_type): Replace throw_exception
8921         with throw.
8922         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8923         with throw.
8924         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8925         throw.
8926         * target.c (target_translate_tls_address): Replace throw_exception
8927         with throw.
8928         * stack.c (frame_apply_command_count): Replace throw_exception
8929         with throw.
8930         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8931         throw.
8932         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8933         with throw.
8934         * rs6000-tdep.c (rs6000_frame_cache)
8935         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8936         * remote.c: Replace throw_exception with throw.
8937         * record-full.c (record_full_message, record_full_wait_1)
8938         (record_full_restore): Replace throw_exception with throw.
8939         * record-btrace.c:
8940         (get_thread_current_frame_id, record_btrace_start_replaying)
8941         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8942         (cmd_record_btrace_start): Replace throw_exception with throw.
8943         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8944         throw.
8945         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8946         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8947         * linespec.c:
8948         (find_linespec_symbols): Replace throw_exception with throw.
8949         * infrun.c (displaced_step_prepare, resume): Replace
8950         throw_exception with throw.
8951         * infcmd.c (post_create_inferior): Replace throw_exception with
8952         throw.
8953         * inf-loop.c (inferior_event_handler): Replace throw_exception
8954         with throw.
8955         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8956         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8957         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8958         (get_prev_frame_always, get_frame_pc_if_available)
8959         (get_frame_address_in_block_if_available, get_frame_language):
8960         Replace throw_exception with throw.
8961         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8962         throw_exception with throw.
8963         * eval.c (fetch_subexp_value, evaluate_var_value)
8964         (evaluate_funcall, evaluate_subexp_standard): Replace
8965         throw_exception with throw.
8966         * dwarf2loc.c (call_site_find_chain)
8967         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8968         Replace throw_exception with throw.
8969         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8970         with throw.
8971         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8972         throw.
8973         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8974         * completer.c (complete_line_internal): Replace throw_exception
8975         with throw.
8976         * compile/compile-object-run.c (compile_object_run): Replace
8977         throw_exception with throw.
8978         * cli/cli-script.c (process_next_line): Replace throw_exception
8979         with throw.
8980         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8981         (btrace_enable, btrace_maint_update_pt_packets): Replace
8982         throw_exception with throw.
8983         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8984         throw_exception with throw.
8985         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8986         throw_exception with throw.
8987         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8988         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8989         * aarch64-tdep.c (aarch64_make_prologue_cache)
8990         (aarch64_make_stub_cache): Replace throw_exception with throw.
8991
8992 2019-04-08  Tom Tromey  <tom@tromey.com>
8993
8994         * common/common-exceptions.c (throw_exception): Rename from
8995         throw_exception_cxx.  Remove old copy.  Make argument const.
8996         (throw_it): Create and throw exception objects directly.
8997         * common/common-exceptions.h (throw_exception): Make argument
8998         const.
8999         (struct gdb_exception_error): Add constructor.
9000         (struct gdb_exception_quit): Add constructor.
9001
9002 2019-04-08  Tom Tromey  <tom@tromey.com>
9003
9004         * common/common-exceptions.h (exception_rethrow): Don't declare.
9005         (TRY_SJLJ): Update comment.
9006         (TRY, CATCH, END_CATCH): Remove.
9007         * common/common-exceptions.c (exception_rethrow): Remove.
9008
9009 2019-04-08  Tom Tromey  <tom@tromey.com>
9010
9011         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9012         Remove.
9013         (gdb_exception_error): Rename from
9014         gdb_exception_RETURN_MASK_ERROR.
9015         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9016         (gdb_quit_bad_alloc): Update.
9017         * aarch64-tdep.c: Update.
9018         * ada-lang.c: Update.
9019         * ada-typeprint.c: Update.
9020         * ada-valprint.c: Update.
9021         * amd64-tdep.c: Update.
9022         * arch-utils.c: Update.
9023         * break-catch-throw.c: Update.
9024         * breakpoint.c: Update.
9025         * btrace.c: Update.
9026         * c-varobj.c: Update.
9027         * cli/cli-cmds.c: Update.
9028         * cli/cli-interp.c: Update.
9029         * cli/cli-script.c: Update.
9030         * common/common-exceptions.c: Update.
9031         * common/new-op.c: Update.
9032         * common/selftest.c: Update.
9033         * compile/compile-c-symbols.c: Update.
9034         * compile/compile-cplus-symbols.c: Update.
9035         * compile/compile-object-load.c: Update.
9036         * compile/compile-object-run.c: Update.
9037         * completer.c: Update.
9038         * corelow.c: Update.
9039         * cp-abi.c: Update.
9040         * cp-support.c: Update.
9041         * cp-valprint.c: Update.
9042         * darwin-nat.c: Update.
9043         * disasm-selftests.c: Update.
9044         * dtrace-probe.c: Update.
9045         * dwarf-index-cache.c: Update.
9046         * dwarf-index-write.c: Update.
9047         * dwarf2-frame-tailcall.c: Update.
9048         * dwarf2-frame.c: Update.
9049         * dwarf2loc.c: Update.
9050         * dwarf2read.c: Update.
9051         * eval.c: Update.
9052         * event-loop.c: Update.
9053         * event-top.c: Update.
9054         * exec.c: Update.
9055         * f-valprint.c: Update.
9056         * fbsd-tdep.c: Update.
9057         * frame-unwind.c: Update.
9058         * frame.c: Update.
9059         * gdbtypes.c: Update.
9060         * gnu-v3-abi.c: Update.
9061         * guile/guile-internal.h: Update.
9062         * guile/scm-block.c: Update.
9063         * guile/scm-breakpoint.c: Update.
9064         * guile/scm-cmd.c: Update.
9065         * guile/scm-disasm.c: Update.
9066         * guile/scm-frame.c: Update.
9067         * guile/scm-lazy-string.c: Update.
9068         * guile/scm-math.c: Update.
9069         * guile/scm-param.c: Update.
9070         * guile/scm-ports.c: Update.
9071         * guile/scm-pretty-print.c: Update.
9072         * guile/scm-symbol.c: Update.
9073         * guile/scm-symtab.c: Update.
9074         * guile/scm-type.c: Update.
9075         * guile/scm-value.c: Update.
9076         * i386-linux-tdep.c: Update.
9077         * i386-tdep.c: Update.
9078         * inf-loop.c: Update.
9079         * infcall.c: Update.
9080         * infcmd.c: Update.
9081         * infrun.c: Update.
9082         * jit.c: Update.
9083         * language.c: Update.
9084         * linespec.c: Update.
9085         * linux-fork.c: Update.
9086         * linux-nat.c: Update.
9087         * linux-tdep.c: Update.
9088         * linux-thread-db.c: Update.
9089         * main.c: Update.
9090         * mi/mi-cmd-break.c: Update.
9091         * mi/mi-cmd-stack.c: Update.
9092         * mi/mi-interp.c: Update.
9093         * mi/mi-main.c: Update.
9094         * objc-lang.c: Update.
9095         * p-valprint.c: Update.
9096         * parse.c: Update.
9097         * ppc-linux-tdep.c: Update.
9098         * printcmd.c: Update.
9099         * python/py-arch.c: Update.
9100         * python/py-breakpoint.c: Update.
9101         * python/py-cmd.c: Update.
9102         * python/py-finishbreakpoint.c: Update.
9103         * python/py-frame.c: Update.
9104         * python/py-framefilter.c: Update.
9105         * python/py-gdb-readline.c: Update.
9106         * python/py-inferior.c: Update.
9107         * python/py-infthread.c: Update.
9108         * python/py-lazy-string.c: Update.
9109         * python/py-linetable.c: Update.
9110         * python/py-objfile.c: Update.
9111         * python/py-param.c: Update.
9112         * python/py-prettyprint.c: Update.
9113         * python/py-progspace.c: Update.
9114         * python/py-record-btrace.c: Update.
9115         * python/py-record.c: Update.
9116         * python/py-symbol.c: Update.
9117         * python/py-type.c: Update.
9118         * python/py-unwind.c: Update.
9119         * python/py-utils.c: Update.
9120         * python/py-value.c: Update.
9121         * python/python.c: Update.
9122         * record-btrace.c: Update.
9123         * record-full.c: Update.
9124         * remote-fileio.c: Update.
9125         * remote.c: Update.
9126         * riscv-tdep.c: Update.
9127         * rs6000-aix-tdep.c: Update.
9128         * rs6000-tdep.c: Update.
9129         * rust-exp.y: Update.
9130         * rust-lang.c: Update.
9131         * s390-tdep.c: Update.
9132         * selftest-arch.c: Update.
9133         * solib-dsbt.c: Update.
9134         * solib-frv.c: Update.
9135         * solib-spu.c: Update.
9136         * solib-svr4.c: Update.
9137         * solib.c: Update.
9138         * sparc64-linux-tdep.c: Update.
9139         * stack.c: Update.
9140         * symfile-mem.c: Update.
9141         * symmisc.c: Update.
9142         * target.c: Update.
9143         * thread.c: Update.
9144         * top.c: Update.
9145         * tracefile-tfile.c: Update.
9146         * tui/tui.c: Update.
9147         * typeprint.c: Update.
9148         * unittests/cli-utils-selftests.c: Update.
9149         * unittests/parse-connection-spec-selftests.c: Update.
9150         * valops.c: Update.
9151         * valprint.c: Update.
9152         * value.c: Update.
9153         * varobj.c: Update.
9154         * windows-nat.c: Update.
9155         * x86-linux-nat.c: Update.
9156         * xml-support.c: Update.
9157
9158 2019-04-08  Tom Tromey  <tom@tromey.com>
9159
9160         * xml-support.c: Use C++ exception handling.
9161         * x86-linux-nat.c: Use C++ exception handling.
9162         * windows-nat.c: Use C++ exception handling.
9163         * varobj.c: Use C++ exception handling.
9164         * value.c: Use C++ exception handling.
9165         * valprint.c: Use C++ exception handling.
9166         * valops.c: Use C++ exception handling.
9167         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9168         handling.
9169         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9170         * typeprint.c: Use C++ exception handling.
9171         * tui/tui.c: Use C++ exception handling.
9172         * tracefile-tfile.c: Use C++ exception handling.
9173         * top.c: Use C++ exception handling.
9174         * thread.c: Use C++ exception handling.
9175         * target.c: Use C++ exception handling.
9176         * symmisc.c: Use C++ exception handling.
9177         * symfile-mem.c: Use C++ exception handling.
9178         * stack.c: Use C++ exception handling.
9179         * sparc64-linux-tdep.c: Use C++ exception handling.
9180         * solib.c: Use C++ exception handling.
9181         * solib-svr4.c: Use C++ exception handling.
9182         * solib-spu.c: Use C++ exception handling.
9183         * solib-frv.c: Use C++ exception handling.
9184         * solib-dsbt.c: Use C++ exception handling.
9185         * selftest-arch.c: Use C++ exception handling.
9186         * s390-tdep.c: Use C++ exception handling.
9187         * rust-lang.c: Use C++ exception handling.
9188         * rust-exp.y: Use C++ exception handling.
9189         * rs6000-tdep.c: Use C++ exception handling.
9190         * rs6000-aix-tdep.c: Use C++ exception handling.
9191         * riscv-tdep.c: Use C++ exception handling.
9192         * remote.c: Use C++ exception handling.
9193         * remote-fileio.c: Use C++ exception handling.
9194         * record-full.c: Use C++ exception handling.
9195         * record-btrace.c: Use C++ exception handling.
9196         * python/python.c: Use C++ exception handling.
9197         * python/py-value.c: Use C++ exception handling.
9198         * python/py-utils.c: Use C++ exception handling.
9199         * python/py-unwind.c: Use C++ exception handling.
9200         * python/py-type.c: Use C++ exception handling.
9201         * python/py-symbol.c: Use C++ exception handling.
9202         * python/py-record.c: Use C++ exception handling.
9203         * python/py-record-btrace.c: Use C++ exception handling.
9204         * python/py-progspace.c: Use C++ exception handling.
9205         * python/py-prettyprint.c: Use C++ exception handling.
9206         * python/py-param.c: Use C++ exception handling.
9207         * python/py-objfile.c: Use C++ exception handling.
9208         * python/py-linetable.c: Use C++ exception handling.
9209         * python/py-lazy-string.c: Use C++ exception handling.
9210         * python/py-infthread.c: Use C++ exception handling.
9211         * python/py-inferior.c: Use C++ exception handling.
9212         * python/py-gdb-readline.c: Use C++ exception handling.
9213         * python/py-framefilter.c: Use C++ exception handling.
9214         * python/py-frame.c: Use C++ exception handling.
9215         * python/py-finishbreakpoint.c: Use C++ exception handling.
9216         * python/py-cmd.c: Use C++ exception handling.
9217         * python/py-breakpoint.c: Use C++ exception handling.
9218         * python/py-arch.c: Use C++ exception handling.
9219         * printcmd.c: Use C++ exception handling.
9220         * ppc-linux-tdep.c: Use C++ exception handling.
9221         * parse.c: Use C++ exception handling.
9222         * p-valprint.c: Use C++ exception handling.
9223         * objc-lang.c: Use C++ exception handling.
9224         * mi/mi-main.c: Use C++ exception handling.
9225         * mi/mi-interp.c: Use C++ exception handling.
9226         * mi/mi-cmd-stack.c: Use C++ exception handling.
9227         * mi/mi-cmd-break.c: Use C++ exception handling.
9228         * main.c: Use C++ exception handling.
9229         * linux-thread-db.c: Use C++ exception handling.
9230         * linux-tdep.c: Use C++ exception handling.
9231         * linux-nat.c: Use C++ exception handling.
9232         * linux-fork.c: Use C++ exception handling.
9233         * linespec.c: Use C++ exception handling.
9234         * language.c: Use C++ exception handling.
9235         * jit.c: Use C++ exception handling.
9236         * infrun.c: Use C++ exception handling.
9237         * infcmd.c: Use C++ exception handling.
9238         * infcall.c: Use C++ exception handling.
9239         * inf-loop.c: Use C++ exception handling.
9240         * i386-tdep.c: Use C++ exception handling.
9241         * i386-linux-tdep.c: Use C++ exception handling.
9242         * guile/scm-value.c: Use C++ exception handling.
9243         * guile/scm-type.c: Use C++ exception handling.
9244         * guile/scm-symtab.c: Use C++ exception handling.
9245         * guile/scm-symbol.c: Use C++ exception handling.
9246         * guile/scm-pretty-print.c: Use C++ exception handling.
9247         * guile/scm-ports.c: Use C++ exception handling.
9248         * guile/scm-param.c: Use C++ exception handling.
9249         * guile/scm-math.c: Use C++ exception handling.
9250         * guile/scm-lazy-string.c: Use C++ exception handling.
9251         * guile/scm-frame.c: Use C++ exception handling.
9252         * guile/scm-disasm.c: Use C++ exception handling.
9253         * guile/scm-cmd.c: Use C++ exception handling.
9254         * guile/scm-breakpoint.c: Use C++ exception handling.
9255         * guile/scm-block.c: Use C++ exception handling.
9256         * guile/guile-internal.h: Use C++ exception handling.
9257         * gnu-v3-abi.c: Use C++ exception handling.
9258         * gdbtypes.c: Use C++ exception handling.
9259         * frame.c: Use C++ exception handling.
9260         * frame-unwind.c: Use C++ exception handling.
9261         * fbsd-tdep.c: Use C++ exception handling.
9262         * f-valprint.c: Use C++ exception handling.
9263         * exec.c: Use C++ exception handling.
9264         * event-top.c: Use C++ exception handling.
9265         * event-loop.c: Use C++ exception handling.
9266         * eval.c: Use C++ exception handling.
9267         * dwarf2read.c: Use C++ exception handling.
9268         * dwarf2loc.c: Use C++ exception handling.
9269         * dwarf2-frame.c: Use C++ exception handling.
9270         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9271         * dwarf-index-write.c: Use C++ exception handling.
9272         * dwarf-index-cache.c: Use C++ exception handling.
9273         * dtrace-probe.c: Use C++ exception handling.
9274         * disasm-selftests.c: Use C++ exception handling.
9275         * darwin-nat.c: Use C++ exception handling.
9276         * cp-valprint.c: Use C++ exception handling.
9277         * cp-support.c: Use C++ exception handling.
9278         * cp-abi.c: Use C++ exception handling.
9279         * corelow.c: Use C++ exception handling.
9280         * completer.c: Use C++ exception handling.
9281         * compile/compile-object-run.c: Use C++ exception handling.
9282         * compile/compile-object-load.c: Use C++ exception handling.
9283         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9284         * compile/compile-c-symbols.c: Use C++ exception handling.
9285         * common/selftest.c: Use C++ exception handling.
9286         * common/new-op.c: Use C++ exception handling.
9287         * cli/cli-script.c: Use C++ exception handling.
9288         * cli/cli-interp.c: Use C++ exception handling.
9289         * cli/cli-cmds.c: Use C++ exception handling.
9290         * c-varobj.c: Use C++ exception handling.
9291         * btrace.c: Use C++ exception handling.
9292         * breakpoint.c: Use C++ exception handling.
9293         * break-catch-throw.c: Use C++ exception handling.
9294         * arch-utils.c: Use C++ exception handling.
9295         * amd64-tdep.c: Use C++ exception handling.
9296         * ada-valprint.c: Use C++ exception handling.
9297         * ada-typeprint.c: Use C++ exception handling.
9298         * ada-lang.c: Use C++ exception handling.
9299         * aarch64-tdep.c: Use C++ exception handling.
9300
9301 2019-04-08  Tom Tromey  <tom@tromey.com>
9302
9303         * xml-support.c (gdb_xml_parser::parse): Update.
9304         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9305         * value.c (show_convenience): Update.
9306         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9307         (test_parse_flags_qcs): Update.
9308         * thread.c (thr_try_catch_cmd): Update.
9309         * target.c (target_translate_tls_address): Update.
9310         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9311         (info_frame_command_core, frame_apply_command_count): Update.
9312         * rust-exp.y (rust_lex_exception_test): Update.
9313         * riscv-tdep.c (riscv_print_one_register_info): Update.
9314         * remote.c (remote_target::enable_btrace): Update.
9315         * record-btrace.c (record_btrace_enable_warn): Update.
9316         * python/py-utils.c (gdbpy_convert_exception): Update.
9317         * printcmd.c (do_one_display, print_variable_and_value): Update.
9318         * mi/mi-main.c (mi_print_exception): Update.
9319         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9320         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9321         * linux-nat.c (linux_nat_target::attach): Update.
9322         * linux-fork.c (class scoped_switch_fork_info): Update.
9323         * infrun.c (displaced_step_prepare): Update.
9324         * infcall.c (call_function_by_hand_dummy): Update.
9325         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9326         * gnu-v3-abi.c (print_one_vtable): Update.
9327         * frame.c (get_prev_frame_always): Update.
9328         * f-valprint.c (info_common_command_for_block): Update.
9329         * exec.c (try_open_exec_file): Update.
9330         * exceptions.c (print_exception, exception_print)
9331         (exception_fprintf, exception_print_same): Update.
9332         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9333         * dwarf-index-cache.c (index_cache::store)
9334         (index_cache::lookup_gdb_index): Update.
9335         * darwin-nat.c (maybe_cache_shell): Update.
9336         * cp-valprint.c (cp_print_value_fields): Update.
9337         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9338         (gcc_cplus_symbol_address): Update.
9339         * compile/compile-c-symbols.c (gcc_convert_symbol)
9340         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9341         * common/selftest.c: Update.
9342         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9343         a std::string.
9344         (exception_try_scope_entry, exception_try_scope_exit): Don't
9345         declare.
9346         (struct exception_try_scope): Remove.
9347         (TRY): Don't use exception_try_scope.
9348         (struct gdb_exception): Add constructor, operator=.
9349         <what>: New method.
9350         (struct gdb_exception_RETURN_MASK_ALL)
9351         (struct gdb_exception_RETURN_MASK_ERROR)
9352         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9353         (struct gdb_quit_bad_alloc): Update.
9354         * common/common-exceptions.c (exception_none): Change
9355         initializer.
9356         (struct catcher) <state, exception>: Initialize inline.
9357         <prev>: Remove member.
9358         (current_catcher): Remove.
9359         (catchers): New global.
9360         (exceptions_state_mc_init): Simplify.
9361         (catcher_pop): Remove.
9362         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9363         (try_scope_depth, exception_try_scope_entry)
9364         (exception_try_scope_exit): Remove.
9365         (throw_exception_sjlj): Update.
9366         (exception_messages, exception_messages_size): Remove.
9367         (throw_it): Simplify.
9368         (gdb_exception_sliced_copy): Remove.
9369         (throw_exception_cxx): Update.
9370         * cli/cli-script.c (script_from_file): Update.
9371         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9372         Update.
9373         * ada-valprint.c (ada_val_print): Update.
9374         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9375         (create_excep_cond_exprs): Update.
9376
9377 2019-04-08  Tom Tromey  <tom@tromey.com>
9378
9379         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9380         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9381         (TRY, CATCH, END_CATCH): Remove some definitions.
9382         * common/common-exceptions.c: Don't use GDB_XCPT.
9383         (catcher_list_size): Remove.
9384         (throw_exception, throw_it): Simplify.
9385
9386 2019-04-05  Tom Tromey  <tom@tromey.com>
9387
9388         Revert the header-sorting patch.
9389         * ft32-tdep.c: Revert.
9390         * frv-tdep.c: Revert.
9391         * frv-linux-tdep.c: Revert.
9392         * frame.c: Revert.
9393         * frame-unwind.c: Revert.
9394         * frame-base.c: Revert.
9395         * fork-child.c: Revert.
9396         * findvar.c: Revert.
9397         * findcmd.c: Revert.
9398         * filesystem.c: Revert.
9399         * filename-seen-cache.h: Revert.
9400         * filename-seen-cache.c: Revert.
9401         * fbsd-tdep.c: Revert.
9402         * fbsd-nat.h: Revert.
9403         * fbsd-nat.c: Revert.
9404         * f-valprint.c: Revert.
9405         * f-typeprint.c: Revert.
9406         * f-lang.c: Revert.
9407         * extension.h: Revert.
9408         * extension.c: Revert.
9409         * extension-priv.h: Revert.
9410         * expprint.c: Revert.
9411         * exec.h: Revert.
9412         * exec.c: Revert.
9413         * exceptions.c: Revert.
9414         * event-top.c: Revert.
9415         * event-loop.c: Revert.
9416         * eval.c: Revert.
9417         * elfread.c: Revert.
9418         * dwarf2read.h: Revert.
9419         * dwarf2read.c: Revert.
9420         * dwarf2loc.c: Revert.
9421         * dwarf2expr.h: Revert.
9422         * dwarf2expr.c: Revert.
9423         * dwarf2-frame.c: Revert.
9424         * dwarf2-frame-tailcall.c: Revert.
9425         * dwarf-index-write.h: Revert.
9426         * dwarf-index-write.c: Revert.
9427         * dwarf-index-common.c: Revert.
9428         * dwarf-index-cache.h: Revert.
9429         * dwarf-index-cache.c: Revert.
9430         * dummy-frame.c: Revert.
9431         * dtrace-probe.c: Revert.
9432         * disasm.h: Revert.
9433         * disasm.c: Revert.
9434         * disasm-selftests.c: Revert.
9435         * dictionary.c: Revert.
9436         * dicos-tdep.c: Revert.
9437         * demangle.c: Revert.
9438         * dcache.h: Revert.
9439         * dcache.c: Revert.
9440         * darwin-nat.h: Revert.
9441         * darwin-nat.c: Revert.
9442         * darwin-nat-info.c: Revert.
9443         * d-valprint.c: Revert.
9444         * d-namespace.c: Revert.
9445         * d-lang.c: Revert.
9446         * ctf.c: Revert.
9447         * csky-tdep.c: Revert.
9448         * csky-linux-tdep.c: Revert.
9449         * cris-tdep.c: Revert.
9450         * cris-linux-tdep.c: Revert.
9451         * cp-valprint.c: Revert.
9452         * cp-support.c: Revert.
9453         * cp-namespace.c: Revert.
9454         * cp-abi.c: Revert.
9455         * corelow.c: Revert.
9456         * corefile.c: Revert.
9457         * continuations.c: Revert.
9458         * completer.h: Revert.
9459         * completer.c: Revert.
9460         * complaints.c: Revert.
9461         * coffread.c: Revert.
9462         * coff-pe-read.c: Revert.
9463         * cli-out.h: Revert.
9464         * cli-out.c: Revert.
9465         * charset.c: Revert.
9466         * c-varobj.c: Revert.
9467         * c-valprint.c: Revert.
9468         * c-typeprint.c: Revert.
9469         * c-lang.c: Revert.
9470         * buildsym.c: Revert.
9471         * buildsym-legacy.c: Revert.
9472         * build-id.h: Revert.
9473         * build-id.c: Revert.
9474         * btrace.c: Revert.
9475         * bsd-uthread.c: Revert.
9476         * breakpoint.h: Revert.
9477         * breakpoint.c: Revert.
9478         * break-catch-throw.c: Revert.
9479         * break-catch-syscall.c: Revert.
9480         * break-catch-sig.c: Revert.
9481         * blockframe.c: Revert.
9482         * block.c: Revert.
9483         * bfin-tdep.c: Revert.
9484         * bfin-linux-tdep.c: Revert.
9485         * bfd-target.c: Revert.
9486         * bcache.c: Revert.
9487         * ax-general.c: Revert.
9488         * ax-gdb.h: Revert.
9489         * ax-gdb.c: Revert.
9490         * avr-tdep.c: Revert.
9491         * auxv.c: Revert.
9492         * auto-load.c: Revert.
9493         * arm-wince-tdep.c: Revert.
9494         * arm-tdep.c: Revert.
9495         * arm-symbian-tdep.c: Revert.
9496         * arm-pikeos-tdep.c: Revert.
9497         * arm-obsd-tdep.c: Revert.
9498         * arm-nbsd-tdep.c: Revert.
9499         * arm-nbsd-nat.c: Revert.
9500         * arm-linux-tdep.c: Revert.
9501         * arm-linux-nat.c: Revert.
9502         * arm-fbsd-tdep.c: Revert.
9503         * arm-fbsd-nat.c: Revert.
9504         * arm-bsd-tdep.c: Revert.
9505         * arch-utils.c: Revert.
9506         * arc-tdep.c: Revert.
9507         * arc-newlib-tdep.c: Revert.
9508         * annotate.h: Revert.
9509         * annotate.c: Revert.
9510         * amd64-windows-tdep.c: Revert.
9511         * amd64-windows-nat.c: Revert.
9512         * amd64-tdep.c: Revert.
9513         * amd64-sol2-tdep.c: Revert.
9514         * amd64-obsd-tdep.c: Revert.
9515         * amd64-obsd-nat.c: Revert.
9516         * amd64-nbsd-tdep.c: Revert.
9517         * amd64-nbsd-nat.c: Revert.
9518         * amd64-nat.c: Revert.
9519         * amd64-linux-tdep.c: Revert.
9520         * amd64-linux-nat.c: Revert.
9521         * amd64-fbsd-tdep.c: Revert.
9522         * amd64-fbsd-nat.c: Revert.
9523         * amd64-dicos-tdep.c: Revert.
9524         * amd64-darwin-tdep.c: Revert.
9525         * amd64-bsd-nat.c: Revert.
9526         * alpha-tdep.c: Revert.
9527         * alpha-obsd-tdep.c: Revert.
9528         * alpha-nbsd-tdep.c: Revert.
9529         * alpha-mdebug-tdep.c: Revert.
9530         * alpha-linux-tdep.c: Revert.
9531         * alpha-linux-nat.c: Revert.
9532         * alpha-bsd-tdep.c: Revert.
9533         * alpha-bsd-nat.c: Revert.
9534         * aix-thread.c: Revert.
9535         * agent.c: Revert.
9536         * addrmap.c: Revert.
9537         * ada-varobj.c: Revert.
9538         * ada-valprint.c: Revert.
9539         * ada-typeprint.c: Revert.
9540         * ada-tasks.c: Revert.
9541         * ada-lang.c: Revert.
9542         * aarch64-tdep.c: Revert.
9543         * aarch64-ravenscar-thread.c: Revert.
9544         * aarch64-newlib-tdep.c: Revert.
9545         * aarch64-linux-tdep.c: Revert.
9546         * aarch64-linux-nat.c: Revert.
9547         * aarch64-fbsd-tdep.c: Revert.
9548         * aarch64-fbsd-nat.c: Revert.
9549         * aarch32-linux-nat.c: Revert.
9550
9551 2019-04-05  Tom Tromey  <tom@tromey.com>
9552
9553         * ft32-tdep.c: Sort headers.
9554         * frv-tdep.c: Sort headers.
9555         * frv-linux-tdep.c: Sort headers.
9556         * frame.c: Sort headers.
9557         * frame-unwind.c: Sort headers.
9558         * frame-base.c: Sort headers.
9559         * fork-child.c: Sort headers.
9560         * findvar.c: Sort headers.
9561         * findcmd.c: Sort headers.
9562         * filesystem.c: Sort headers.
9563         * filename-seen-cache.h: Sort headers.
9564         * filename-seen-cache.c: Sort headers.
9565         * fbsd-tdep.c: Sort headers.
9566         * fbsd-nat.h: Sort headers.
9567         * fbsd-nat.c: Sort headers.
9568         * f-valprint.c: Sort headers.
9569         * f-typeprint.c: Sort headers.
9570         * f-lang.c: Sort headers.
9571         * extension.h: Sort headers.
9572         * extension.c: Sort headers.
9573         * extension-priv.h: Sort headers.
9574         * expprint.c: Sort headers.
9575         * exec.h: Sort headers.
9576         * exec.c: Sort headers.
9577         * exceptions.c: Sort headers.
9578         * event-top.c: Sort headers.
9579         * event-loop.c: Sort headers.
9580         * eval.c: Sort headers.
9581         * elfread.c: Sort headers.
9582         * dwarf2read.h: Sort headers.
9583         * dwarf2read.c: Sort headers.
9584         * dwarf2loc.c: Sort headers.
9585         * dwarf2expr.h: Sort headers.
9586         * dwarf2expr.c: Sort headers.
9587         * dwarf2-frame.c: Sort headers.
9588         * dwarf2-frame-tailcall.c: Sort headers.
9589         * dwarf-index-write.h: Sort headers.
9590         * dwarf-index-write.c: Sort headers.
9591         * dwarf-index-common.c: Sort headers.
9592         * dwarf-index-cache.h: Sort headers.
9593         * dwarf-index-cache.c: Sort headers.
9594         * dummy-frame.c: Sort headers.
9595         * dtrace-probe.c: Sort headers.
9596         * disasm.h: Sort headers.
9597         * disasm.c: Sort headers.
9598         * disasm-selftests.c: Sort headers.
9599         * dictionary.c: Sort headers.
9600         * dicos-tdep.c: Sort headers.
9601         * demangle.c: Sort headers.
9602         * dcache.h: Sort headers.
9603         * dcache.c: Sort headers.
9604         * darwin-nat.h: Sort headers.
9605         * darwin-nat.c: Sort headers.
9606         * darwin-nat-info.c: Sort headers.
9607         * d-valprint.c: Sort headers.
9608         * d-namespace.c: Sort headers.
9609         * d-lang.c: Sort headers.
9610         * ctf.c: Sort headers.
9611         * csky-tdep.c: Sort headers.
9612         * csky-linux-tdep.c: Sort headers.
9613         * cris-tdep.c: Sort headers.
9614         * cris-linux-tdep.c: Sort headers.
9615         * cp-valprint.c: Sort headers.
9616         * cp-support.c: Sort headers.
9617         * cp-namespace.c: Sort headers.
9618         * cp-abi.c: Sort headers.
9619         * corelow.c: Sort headers.
9620         * corefile.c: Sort headers.
9621         * continuations.c: Sort headers.
9622         * completer.h: Sort headers.
9623         * completer.c: Sort headers.
9624         * complaints.c: Sort headers.
9625         * coffread.c: Sort headers.
9626         * coff-pe-read.c: Sort headers.
9627         * cli-out.h: Sort headers.
9628         * cli-out.c: Sort headers.
9629         * charset.c: Sort headers.
9630         * c-varobj.c: Sort headers.
9631         * c-valprint.c: Sort headers.
9632         * c-typeprint.c: Sort headers.
9633         * c-lang.c: Sort headers.
9634         * buildsym.c: Sort headers.
9635         * buildsym-legacy.c: Sort headers.
9636         * build-id.h: Sort headers.
9637         * build-id.c: Sort headers.
9638         * btrace.c: Sort headers.
9639         * bsd-uthread.c: Sort headers.
9640         * breakpoint.h: Sort headers.
9641         * breakpoint.c: Sort headers.
9642         * break-catch-throw.c: Sort headers.
9643         * break-catch-syscall.c: Sort headers.
9644         * break-catch-sig.c: Sort headers.
9645         * blockframe.c: Sort headers.
9646         * block.c: Sort headers.
9647         * bfin-tdep.c: Sort headers.
9648         * bfin-linux-tdep.c: Sort headers.
9649         * bfd-target.c: Sort headers.
9650         * bcache.c: Sort headers.
9651         * ax-general.c: Sort headers.
9652         * ax-gdb.h: Sort headers.
9653         * ax-gdb.c: Sort headers.
9654         * avr-tdep.c: Sort headers.
9655         * auxv.c: Sort headers.
9656         * auto-load.c: Sort headers.
9657         * arm-wince-tdep.c: Sort headers.
9658         * arm-tdep.c: Sort headers.
9659         * arm-symbian-tdep.c: Sort headers.
9660         * arm-pikeos-tdep.c: Sort headers.
9661         * arm-obsd-tdep.c: Sort headers.
9662         * arm-nbsd-tdep.c: Sort headers.
9663         * arm-nbsd-nat.c: Sort headers.
9664         * arm-linux-tdep.c: Sort headers.
9665         * arm-linux-nat.c: Sort headers.
9666         * arm-fbsd-tdep.c: Sort headers.
9667         * arm-fbsd-nat.c: Sort headers.
9668         * arm-bsd-tdep.c: Sort headers.
9669         * arch-utils.c: Sort headers.
9670         * arc-tdep.c: Sort headers.
9671         * arc-newlib-tdep.c: Sort headers.
9672         * annotate.h: Sort headers.
9673         * annotate.c: Sort headers.
9674         * amd64-windows-tdep.c: Sort headers.
9675         * amd64-windows-nat.c: Sort headers.
9676         * amd64-tdep.c: Sort headers.
9677         * amd64-sol2-tdep.c: Sort headers.
9678         * amd64-obsd-tdep.c: Sort headers.
9679         * amd64-obsd-nat.c: Sort headers.
9680         * amd64-nbsd-tdep.c: Sort headers.
9681         * amd64-nbsd-nat.c: Sort headers.
9682         * amd64-nat.c: Sort headers.
9683         * amd64-linux-tdep.c: Sort headers.
9684         * amd64-linux-nat.c: Sort headers.
9685         * amd64-fbsd-tdep.c: Sort headers.
9686         * amd64-fbsd-nat.c: Sort headers.
9687         * amd64-dicos-tdep.c: Sort headers.
9688         * amd64-darwin-tdep.c: Sort headers.
9689         * amd64-bsd-nat.c: Sort headers.
9690         * alpha-tdep.c: Sort headers.
9691         * alpha-obsd-tdep.c: Sort headers.
9692         * alpha-nbsd-tdep.c: Sort headers.
9693         * alpha-mdebug-tdep.c: Sort headers.
9694         * alpha-linux-tdep.c: Sort headers.
9695         * alpha-linux-nat.c: Sort headers.
9696         * alpha-bsd-tdep.c: Sort headers.
9697         * alpha-bsd-nat.c: Sort headers.
9698         * aix-thread.c: Sort headers.
9699         * agent.c: Sort headers.
9700         * addrmap.c: Sort headers.
9701         * ada-varobj.c: Sort headers.
9702         * ada-valprint.c: Sort headers.
9703         * ada-typeprint.c: Sort headers.
9704         * ada-tasks.c: Sort headers.
9705         * ada-lang.c: Sort headers.
9706         * aarch64-tdep.c: Sort headers.
9707         * aarch64-ravenscar-thread.c: Sort headers.
9708         * aarch64-newlib-tdep.c: Sort headers.
9709         * aarch64-linux-tdep.c: Sort headers.
9710         * aarch64-linux-nat.c: Sort headers.
9711         * aarch64-fbsd-tdep.c: Sort headers.
9712         * aarch64-fbsd-nat.c: Sort headers.
9713         * aarch32-linux-nat.c: Sort headers.
9714
9715 2019-04-04  Tom Tromey  <tom@tromey.com>
9716
9717         * varobj.c (varobj_create): Update.
9718         * rust-exp.y (struct rust_parser) <update_innermost_block,
9719         lookup_symbol>: New methods.
9720         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9721         Rename.
9722         (rust_parser::rust_lookup_type)
9723         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9724         * printcmd.c (display_command, do_one_display): Update.
9725         * parser-defs.h (struct parser_state) <parser_state>: Add
9726         "tracker" parameter.
9727         (block_tracker): New member.
9728         (class innermost_block_tracker) <innermost_block_tracker>: Add
9729         "types" parameter.
9730         <reset>: Remove method.
9731         (innermost_block): Don't declare.
9732         (null_post_parser): Update.
9733         * parse.c (innermost_block): Remove global.
9734         (write_dollar_variable): Update.
9735         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9736         Remove "tracker_types" parameter.
9737         (parse_expression): Add "tracker" parameter.
9738         (parse_expression_for_completion): Update.
9739         (null_post_parser): Add "tracker" parameter.
9740         * p-exp.y: Update rules.
9741         * m2-exp.y: Update rules.
9742         * language.h (struct language_defn) <la_post_parser>: Add
9743         "tracker" parameter.
9744         * go-exp.y: Update rules.
9745         * f-exp.y: Update rules.
9746         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9747         parameter.
9748         * d-exp.y: Update rules.
9749         * c-exp.y: Update rules.
9750         * breakpoint.c (set_breakpoint_condition): Create an
9751         innermost_block_tracker.
9752         (watch_command_1): Likewise.
9753         * ada-lang.c (resolve): Add "tracker" parameter.
9754         (resolve_subexp): Likewise.
9755         * ada-exp.y (write_var_from_sym): Update.
9756
9757 2019-04-04  Tom Tromey  <tom@tromey.com>
9758
9759         * type-stack.h: New file.
9760         * type-stack.c: New file.
9761         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9762         type-stack.h.
9763         (insert_into_type_stack, insert_type, push_type, push_type_int)
9764         (insert_type_address_space, pop_type, pop_type_int)
9765         (pop_typelist, pop_type_stack, append_type_stack)
9766         (push_type_stack, get_type_stack, push_typelist)
9767         (follow_type_instance_flags, follow_types): Don't declare.
9768         * parse.c (type_stack): Remove global.
9769         (parse_exp_in_context): Update.
9770         (insert_into_type_stack, insert_type, push_type, push_type_int)
9771         (insert_type_address_space, pop_type, pop_type_int)
9772         (pop_typelist, pop_type_stack, append_type_stack)
9773         (push_type_stack, get_type_stack, push_typelist)
9774         (follow_type_instance_flags, follow_types): Remove (moved to
9775         type-stack.c).
9776         * f-exp.y (type_stack): New global.
9777         Update rules.
9778         (push_kind_type, f_parse): Update.
9779         * d-exp.y (type_stack): New global.
9780         Update rules.
9781         (d_parse): Update.
9782         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9783         Update rules.
9784         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9785         (HFILES_NO_SRCDIR): Add type-stack.h.
9786
9787 2019-04-04  Tom Tromey  <tom@tromey.com>
9788
9789         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9790         (rust_parser::convert_ast_to_expression, rust_parse)
9791         (rust_lex_test_completion, rust_lex_tests): Update.
9792         * parser-defs.h (struct expr_completion_state): New.
9793         (struct parser_state) <parser_state>: Add completion parameter.
9794         <mark_struct_expression, mark_completion_tag>: New methods.
9795         <parse_completion, m_completion_state>: New members.
9796         (prefixify_expression, null_post_parser): Update.
9797         (mark_struct_expression, mark_completion_tag): Don't declare.
9798         * parse.c (parse_completion, expout_last_struct)
9799         (expout_tag_completion_type, expout_completion_name): Remove
9800         globals.
9801         (parser_state::mark_struct_expression)
9802         (parser_state::mark_completion_tag): Now methods.
9803         (prefixify_expression): Add last_struct parameter.
9804         (prefixify_subexp): Likewise.
9805         (parse_exp_1): Update.
9806         (parse_exp_in_context): Add cstate parameter.  Update.
9807         (parse_expression_for_completion): Create an
9808         expr_completion_state.
9809         (null_post_parser): Add "completion" parameter.
9810         * p-exp.y: Update rules.
9811         (yylex): Update.
9812         * language.h (struct language_defn) <la_post_parser>: Add
9813         "completing" parameter.
9814         * go-exp.y: Update rules.
9815         (lex_one_token): Update.
9816         * expression.h (parse_completion): Don't declare.
9817         * d-exp.y: Update rules.
9818         (lex_one_token): Update rules.
9819         * c-exp.y: Update rules.
9820         (lex_one_token): Update.
9821         * ada-lang.c (resolve): Add "parse_completion" parameter.
9822         (resolve_subexp): Likewise.
9823         (ada_resolve_function): Likewise.
9824
9825 2019-04-04  Tom Tromey  <tom@tromey.com>
9826
9827         * parser-defs.h (struct parser_state) <start_arglist,
9828         end_arglist>: New methods.
9829         <arglist_len, m_funcall_chain>: New members.
9830         (arglist_len, start_arglist, end_arglist): Don't declare.
9831         * parse.c (arglist_len, funcall_chain): Remove global.
9832         (start_arglist, end_arglist): Remove functions.
9833         (parse_exp_in_context): Update.
9834         * p-exp.y: Update rules.
9835         * m2-exp.y: Update rules.
9836         * go-exp.y: Update rules.
9837         * f-exp.y: Update rules.
9838         * d-exp.y: Update rules.
9839         * c-exp.y: Update rules.
9840
9841 2019-04-04  Tom Tromey  <tom@tromey.com>
9842
9843         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9844         lex_operator, push_back>: New methods.
9845         Update all rules.
9846         (rust_parser::lex_hex, lex_escape): Rename and update.
9847         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9848         (rust_parser::lex_operator): Rename and update.
9849         (rust_parser::lex_number, rustyylex, rustyyerror)
9850         (rust_lex_test_init, rust_lex_test_sequence)
9851         (rust_lex_test_push_back, rust_lex_tests): Update.
9852         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9853         parameter.
9854         <lexptr, prev_lexptr>: New members.
9855         (lexptr, prev_lexptr): Don't declare.
9856         * parse.c (lexptr, prev_lexptr): Remove globals.
9857         (parse_exp_in_context): Update.
9858         * p-exp.y (yylex, yyerror): Update.
9859         * m2-exp.y (parse_number, yylex, yyerror): Update.
9860         * go-exp.y (lex_one_token, yyerror): Update.
9861         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9862         * d-exp.y (lex_one_token, yyerror): Update.
9863         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9864         (lex_one_token, yyerror): Update.
9865         * ada-lex.l (YY_INPUT): Update.
9866         (rewind_to_char): Update.
9867         * ada-exp.y (yyerror): Update.
9868
9869 2019-04-04  Tom Tromey  <tom@tromey.com>
9870
9871         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9872         * parser-defs.h (struct parser_state) <parser_state>: Add new
9873         parameter.
9874         <comma_terminates>: New member.
9875         (comma_terminates): Don't declare global.
9876         * parse.c (comma_terminates): Remove global.
9877         (parse_exp_in_context): Update.
9878         * p-exp.y (yylex): Update.
9879         * m2-exp.y (yylex): Update.
9880         * go-exp.y (lex_one_token): Update.
9881         * f-exp.y (yylex): Update.
9882         * d-exp.y (lex_one_token): Update.
9883         * c-exp.y (lex_one_token): Update.
9884         * ada-lex.l: Update.
9885
9886 2019-04-04  Tom Tromey  <tom@tromey.com>
9887
9888         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9889         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9890         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9891         * parser-defs.h (paren_depth): Don't declare.
9892         * parse.c (paren_depth): Remove global.
9893         (parse_exp_in_context): Update.
9894         * p-exp.y (paren_depth): New global.
9895         (pascal_parse): Initialize it.
9896         * m2-exp.y (paren_depth): New global.
9897         (m2_parse): Initialize it.
9898         * go-exp.y (paren_depth): New global.
9899         (go_parse): Initialize it.
9900         * f-exp.y (paren_depth): New global.
9901         (f_parse): Initialize it.
9902         * d-exp.y (paren_depth): New global.
9903         (d_parse): Initialize it.
9904         * c-exp.y (paren_depth): New global.
9905         (c_parse): Initialize it.
9906         * ada-lex.l (paren_depth): New global.
9907         (lexer_init): Initialize it.
9908
9909 2019-04-04  Tom Tromey  <tom@tromey.com>
9910
9911         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9912         (rust_parser::convert_ast_to_type)
9913         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9914         * parser-defs.h (struct parser_state) <parser_state>: Add
9915         parameters.  Initialize new members.
9916         <expression_context_block, expression_context_pc>: New members.
9917         * parse.c (expression_context_block, expression_context_pc):
9918         Remove globals.
9919         (parse_exp_in_context): Update.
9920         * p-exp.y: Update all rules.
9921         (yylex): Update.
9922         * m2-exp.y: Update all rules.
9923         (yylex): Update.
9924         * go-exp.y (yylex): Update.
9925         * f-exp.y (yylex): Update.
9926         * d-exp.y: Update all rules.
9927         (yylex): Update.
9928         * c-exp.y: Update all rules.
9929         (lex_one_token, classify_name, yylex, c_parse): Update.
9930         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9931
9932 2019-04-04  Tom Tromey  <tom@tromey.com>
9933
9934         * gdbarch.h, gdbarch.c: Rebuild.
9935         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9936         * stap-probe.h:
9937         (struct stap_parse_info): Replace "parser_state" with
9938         "expr_builder".
9939         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9940         (parser_state): New class.
9941         * parse.c (expr_builder): Rename.
9942         (expr_builder::release): Rename.
9943         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9944         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9945         (write_exp_elt_longcst, write_exp_elt_floatcst)
9946         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9947         (write_exp_string_vector, write_exp_bitstring)
9948         (write_exp_msymbol, mark_struct_expression)
9949         (write_dollar_variable)
9950         (insert_type_address_space, increase_expout_size): Replace
9951         "parser_state" with "expr_builder".
9952         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9953         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9954         "parser_state" with "expr_builder".
9955
9956 2019-04-04  Tom Tromey  <tom@tromey.com>
9957
9958         * rust-exp.y: Replace "parse_language" with method call.
9959         * p-exp.y:
9960         (yylex): Replace "parse_language" with method call.
9961         * m2-exp.y:
9962         (yylex): Replace "parse_language" with method call.
9963         * go-exp.y (classify_name): Replace "parse_language" with method
9964         call.
9965         * f-exp.y (yylex): Replace "parse_language" with method call.
9966         * d-exp.y (lex_one_token): Replace "parse_language" with method
9967         call.
9968         * c-exp.y:
9969         (lex_one_token, classify_name, yylex): Replace "parse_language"
9970         with method call.
9971         * ada-exp.y (find_primitive_type, type_char)
9972         (type_system_address): Replace "parse_language" with method call.
9973
9974 2019-04-04  Tom Tromey  <tom@tromey.com>
9975
9976         * rust-exp.y: Replace "parse_gdbarch" with method call.
9977         * parse.c (write_dollar_variable, insert_type_address_space):
9978         Replace "parse_gdbarch" with method call.
9979         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9980         call.
9981         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9982         call.
9983         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9984         "parse_gdbarch" with method call.
9985         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9986         with method call.
9987         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9988         "parse_gdbarch" with method call.
9989         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9990         "parse_gdbarch" with method call.
9991         * c-exp.y (parse_type, parse_number, classify_name): Replace
9992         "parse_gdbarch" with method call.
9993         * ada-lex.l: Replace "parse_gdbarch" with method call.
9994         * ada-exp.y (parse_type, find_primitive_type, type_char)
9995         (type_system_address): Replace "parse_gdbarch" with method call.
9996
9997 2019-04-04  Tom Tromey  <tom@tromey.com>
9998
9999         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10000         * stap-probe.c (stap_parse_argument): Update.
10001         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10002         initial_size parameter.
10003         * rust-exp.y (rust_lex_tests): Update.
10004         * parse.c (parser_state): Update.
10005         (parse_exp_in_context): Update.
10006         * parser-defs.h (struct parser_state) <parser_state>: Remove
10007         "initial_size" parameter.
10008
10009 2019-04-04  Tom Tromey  <tom@tromey.com>
10010
10011         * parser-defs.h (increase_expout_size): Don't declare.
10012         * parse.c (increase_expout_size): Now static.
10013
10014 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10015
10016         * gnu-nat.c (gnu_nat_target::wait): Fix
10017         target_waitstatus_to_string call.
10018
10019 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10020
10021         * eval.c (evaluate_subexp_standard): Handle internal functions
10022         during Fortran function call handling.
10023
10024 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10025
10026         * NEWS: Mention new internal functions.
10027         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10028         (read_base_type): Use dwarf2_init_complex_target_type.
10029         * value.c (creal_internal_fn): New function.
10030         (cimag_internal_fn): New function.
10031         (_initialize_values): Register new internal functions.
10032
10033 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10034
10035         * infrun.c (stop_all_threads): If debug_infrun, always
10036         trace the wait status after wait_one, using
10037         target_waitstatus_to_string and target_pid_to_str.
10038         (handle_inferior_event): Replace various trace of
10039         wait status kind by a single trace.
10040         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10041         wait status kind image by target_waitstatus_to_string.
10042         * target/waitstatus.c (target_waitstatus_to_string): Fix
10043         obsolete comment.
10044
10045 2019-04-01  Tom Tromey  <tromey@adacore.com>
10046
10047         PR symtab/23331:
10048         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10049
10050 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10051             Pedro Alves  <palves@redhat.com>
10052
10053         * top.c (quit_force): Call 'finalize_values'.
10054         * value.c (finalize_values): New function.
10055         * value.h (finalize_values): Declare.
10056
10057 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10058
10059         * NEWS: Announce $_gdb_major and $_gdb_minor.
10060
10061         * top.c (init_gdb_version_vars): New function.
10062         (gdb_init): Call init_gdb_version_vars.
10063
10064 2019-03-29  Tom Tromey  <tromey@adacore.com>
10065
10066         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10067         help text.  Remove dead code.
10068
10069 2019-03-29  Keith Seitz  <keiths@redhat.com>
10070
10071         From Siddhesh Poyarekar:
10072         * f-lang.h (f77_get_upperbound): Return LONGEST.
10073         (f77_get_lowerbound): Likewise.
10074         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10075         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10076         print them.
10077         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10078         plongest to format print it.
10079         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10080         (f77_get_upperbound): Likewise.
10081         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10082         LOWER_BOUND to LONGEST.
10083         (f77_create_arrayprint_offset_tbl): Likewise.
10084
10085 2019-03-29  Keith Seitz  <keiths@redhat.com>
10086
10087         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10088         %s/pulongest for TYPE_LENGTH instead of %d in format
10089         strings.
10090         * ada-typerint.c (ada_print_type): Likewise.
10091         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10092         * compile/compile-c-support.c (generate_register_struct): Likewise.
10093         * gdbtypes.c (recursive_dump_type): Likewise.
10094         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10095         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10096         instead of %d in format strings.
10097         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10098         to std::min to ULONGEST.
10099         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10100         instead of %d in format strings.
10101         * tracepoint.c (info_scope_command): Likewise.
10102         * typeprint.c (print_offset_data::update)
10103         (print_offset_data::finish): Likewise.
10104         * xtensa-tdep.c (xtensa_store_return_value)
10105         (xtensa_push_dummy_call): Likewise.
10106
10107 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10108
10109         * windows-nat.c (display_selector): Fixed format specifications
10110         for 64-bit Cygwin.
10111
10112 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10113
10114         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10115
10116 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10117
10118         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10119         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10120         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10121         (nios2_linux_init_abi): Install it.
10122
10123 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10124
10125         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10126
10127 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10128
10129         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10130
10131 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10132             Tom Tromey  <tromey@adacore.com>
10133
10134         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10135
10136 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10137
10138         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10139         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10140         method to compute the bounds of range types. Also print "[evaluated]"
10141         if the bounds' values come from a dynamic evaluation.
10142
10143 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10144
10145         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10146         whitespace when pretty printing is on.
10147
10148 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10149
10150         * ppc-linux-nat.c: Add include.
10151
10152 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10153
10154         * NEWS: Mention AArch64 Pointer Authentication.
10155
10156 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10157
10158         * arm-linux-nat.c: Add include.
10159
10160 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10161
10162         * source-cache.c (source_cache::get_source_lines): Re-read
10163         fullname after calling open_source_file.
10164
10165 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10166
10167         * NEWS: Mention TLS support for FreeBSD.
10168
10169 2019-03-25  Tom Tromey  <tromey@adacore.com>
10170
10171         * minsyms.c (BUNCH_SIZE): Update comment.
10172         (~minimal_symbol_reader): Remove old comment.
10173         (compact_minimal_symbols): Update comment.
10174         (minimal_symbol_reader::install): Remove old comment.  Update
10175         other comments.
10176
10177 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10178
10179         * s390-linux-nat.c: Add include.
10180
10181 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10182
10183         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10184         Call linux_get_hwcap.
10185         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10186         Likewise.
10187         (aarch64_linux_get_hwcap): Remove function.
10188         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10189         declaration.
10190         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10191         linux_get_hwcap.
10192         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10193         * linux-tdep.c (linux_get_hwcap): Add function.
10194         (linux_get_hwcap2): Likewise.
10195         * linux-tdep.h (linux_get_hwcap): Add declaration.
10196         (linux_get_hwcap2): Likewise.
10197         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10198         (ppc_linux_get_hwcap2): Likewise.
10199         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10200         linux_get_hwcap.
10201         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10202         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10203         (ppc_linux_nat_target::read_description): Likewise.
10204         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10205         * s390-linux-nat.c: Likewise.
10206         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10207
10208 2019-03-24  Tom Tromey  <tom@tromey.com>
10209
10210         * ada-lang.c (standard_lookup): Simplify initialization.
10211         (ada_lookup_symbol_nonlocal): Simplify return.
10212         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10213         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10214         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10215         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10216         initialization.
10217         * solib.c (solib_global_lookup): Simplify.
10218         * symtab.c (null_block_symbol): Remove.
10219         (symbol_cache_lookup): Simplify returns.
10220         (lookup_language_this): Simplify returns.
10221         (lookup_symbol_aux): Simplify return.
10222         (lookup_local_symbol): Simplify returns.
10223         (lookup_global_symbol_from_objfile): Simplify return.
10224         (lookup_symbol_in_objfile_symtabs)
10225         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10226         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10227         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10228         * cp-namespace.c (cp_lookup_bare_symbol)
10229         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10230         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10231         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10232         (cp_lookup_symbol_via_imports): Simplify initialization.
10233         (find_symbol_in_baseclass): Likewise.
10234         * symtab.h (null_block_symbol): Remove.
10235         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10236         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10237         (d_lookup_symbol_module): Likewise.
10238         (find_symbol_in_baseclass): Simplify initialization.
10239
10240 2019-03-24  Tom Tromey  <tom@tromey.com>
10241
10242         * expression.h: Don't include symtab.h.
10243         (struct block): Forward declare.
10244
10245 2019-03-24  Tom Tromey  <tom@tromey.com>
10246
10247         * c-exp.y (typebase): Remove casts.
10248         * gdbtypes.c (lookup_unsigned_typename, )
10249         (lookup_signed_typename): Remove cast.
10250         * eval.c (parse_to_comma_and_eval): Remove cast.
10251         * parse.c (write_dollar_variable): Remove cast.
10252         * block.h (struct block) <superblock>: Now const.
10253         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10254         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10255         (map_block): Make "block" const.
10256         * symfile.h (struct quick_symbol_functions)
10257         <map_matching_symbols>: Constify block argument to "callback".
10258         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10259         const.
10260         (find_pc_sect_compunit_symtab): Make "b" const.
10261         (find_symbol_at_address): Likewise.
10262         (search_symbols): Likewise.
10263         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10264         (dw2_debug_names_lookup_symbol): Likewise.
10265         (dw2_map_matching_symbols): Update.
10266         * p-valprint.c (pascal_val_print): Remove "block".
10267         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10268         (aux_add_nonlocal_symbols): Make "block" const.
10269         (resolve_subexp): Remove cast.
10270         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10271         const.
10272         (iterate_over_file_blocks): Likewise.
10273         * f-exp.y (%union) <bval>: Remove.
10274         * coffread.c (patch_opaque_types): Make "b" const.
10275         * spu-tdep.c (spu_catch_start): Make "block" const.
10276         * c-valprint.c (print_unpacked_pointer): Remove "block".
10277         * symmisc.c (dump_symtab_1): Make "b" const.
10278         (block_depth): Make "block" const.
10279         * d-exp.y (%union) <bval>: Remove.
10280         * cp-support.h (cp_lookup_rtti_type): Update.
10281         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10282         * psymtab.c (psym_lookup_symbol): Make "block" const.
10283         (maintenance_check_psymtabs): Make "b" const.
10284         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10285         (enumerate_locals, enumerate_args): Update.
10286         * python/py-symtab.c (stpy_global_block): Make "block" const.
10287         (stpy_static_block): Likewise.
10288         * inline-frame.c (block_starting_point_at): Make "new_block"
10289         const.
10290         * block.c (find_block_in_blockvector): Make return type const.
10291         (blockvector_for_pc_sect): Make "b" const.
10292         (find_block_in_blockvector): Make "b" const.
10293
10294 2019-03-23  Tom Tromey  <tom@tromey.com>
10295
10296         * varobj.c (varobj_create): Update.
10297         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10298         * printcmd.c (display_command, do_one_display): Don't reset
10299         innermost_block.
10300         * parser-defs.h (enum innermost_block_tracker_type): Move to
10301         expression.h.
10302         (innermost_block): Update comment.
10303         * parse.c (parse_exp_1): Add tracker_types parameter.
10304         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10305         tracker_types parameter.  Reset innermost_block.
10306         (parse_exp_in_context): Remove.
10307         (parse_expression_for_completion): Update.
10308         * objfiles.c (~objfile): Don't reset expression_context_block or
10309         innermost_block.
10310         * expression.h (enum innermost_block_tracker_type): Move from
10311         parser-defs.h.
10312         (parse_exp_1): Add tracker_types parameter.
10313         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10314         reset innermost_block.
10315
10316 2019-03-23  Tom Tromey  <tom@tromey.com>
10317
10318         * objfiles.h: Include bcache.h.
10319
10320 2019-03-23  Tom Tromey  <tom@tromey.com>
10321
10322         * linespec.c (get_current_search_block): Use
10323         scoped_restore_current_language.
10324         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10325
10326 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10327             Jiong Wang  <jiong.wang@arm.com>
10328
10329         * aarch64-linux-tdep.c
10330         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10331         section.
10332         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10333
10334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10335             Jiong Wang  <jiong.wang@arm.com>
10336
10337         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10338         instructions.
10339         (aarch64_analyze_prologue_test): Add PACIASP test.
10340         (aarch64_prologue_prev_register): Unmask PC value.
10341
10342 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10343             Jiong Wang  <jiong.wang@arm.com>
10344
10345         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10346         (aarch64_dwarf2_prev_register): Unmask PC value.
10347         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10348         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10349         DW_CFA_AARCH64_negate_ra_state.
10350         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10351
10352 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10353             Jiong Wang  <jiong.wang@arm.com>
10354
10355         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10356         registers.
10357         (aarch64_pseudo_register_name): Likewise.
10358         (aarch64_pseudo_register_type): Likewise.
10359         (aarch64_pseudo_register_reggroup_p): Likewise.
10360         (aarch64_gdbarch_init): Add pauth registers.
10361         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10362         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10363         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10364         (struct gdbarch_tdep): Add regnum for ra_state.
10365
10366 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10367             Jiong Wang  <jiong.wang@arm.com>
10368
10369         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10370
10371 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10372             Jiong Wang  <jiong.wang@arm.com>
10373
10374         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10375         function.
10376         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10377         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10378         (aarch64_gdbarch_init): Add puth registers.
10379         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10380         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10381         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10382
10383 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10384             Jiong Wang  <jiong.wang@arm.com>
10385
10386         * aarch64-linux-nat.c
10387         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10388         * aarch64-linux-tdep.c
10389         (aarch64_linux_core_read_description): Likewise.
10390         (aarch64_linux_get_hwcap): New function.
10391         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10392         (aarch64_linux_get_hwcap): New declaration.
10393
10394 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10395             Jiong Wang  <jiong.wang@arm.com>
10396
10397         * aarch64-linux-nat.c
10398         (aarch64_linux_nat_target::read_description): Add pauth param.
10399         * aarch64-linux-tdep.c
10400         (aarch64_linux_core_read_description): Likewise.
10401         * aarch64-tdep.c (struct target_desc): Add in pauth.
10402         (aarch64_read_description): Add pauth param.
10403         (aarch64_gdbarch_init): Likewise.
10404         * aarch64-tdep.h (aarch64_read_description): Likewise.
10405         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10406         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10407         * features/Makefile: Add new files.
10408         * features/aarch64-pauth.c: New file.
10409         * features/aarch64-pauth.xml: New file.
10410
10411 2019-03-20  Tom Tromey  <tromey@adacore.com>
10412
10413         * infrun.c (handle_inferior_event): Rename from
10414         handle_inferior_event_1.  Create a scoped_value_mark.
10415         (handle_inferior_event): Remove.
10416
10417 2019-03-19  Tom Tromey  <tromey@adacore.com>
10418
10419         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10420         * infrun.h (print_stop_event): Add "displays" parameter.
10421         * infrun.c (print_stop_event): Add "displays" parameter.
10422
10423 2019-03-19  Pedro Alves  <palves@redhat.com>
10424
10425         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10426         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10427         to -1.  Fix TABs vs spaces.
10428         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10429         * tui/tui-out.h (tui_ui_out) Add intro comments.
10430         <m_line, m_start_of_line>: In-class initialize, and add describing
10431         comment.
10432
10433 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10434
10435         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10436         variable names.
10437         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10438
10439 2019-03-18  Pedro Alves  <palves@redhat.com>
10440             Eli Zaretskii <eliz@gnu.org>
10441
10442         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10443         m_line and m_start_of_line.
10444
10445 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10446
10447         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10448         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10449         it returns a newline.  This fixes a regression in TU mode, whereby
10450         the next line is output on the same screen line as the user input.
10451
10452 2019-03-18  Tom Tromey  <tromey@adacore.com>
10453
10454         * minsyms.c (minimal_symbol_reader::install): Remove call to
10455         obstack_blank.
10456
10457 2019-03-18  Pedro Alves  <palves@redhat.com>
10458
10459         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10460         New globals.
10461         (apply_style): New, factored out from ...
10462         (apply_ansi_escape): ... this.  Handle reverse video mode.
10463         (tui_set_reverse_mode): New function.
10464         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10465         * tui/tui-winsource.c (tui_show_source_line): Use
10466         tui_set_reverse_mode instead of setting A_STANDOUT.
10467         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10468         New setter methods.
10469
10470 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10471
10472         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10473         Handle tabs.
10474
10475 2019-03-18  Tom Tromey  <tromey@adacore.com>
10476
10477         * ada-lang.c (empty_array): Add "high" parameter.
10478         (ada_evaluate_subexp): Update.
10479
10480 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10481
10482         * unittests/string_view-selftests.c: Define
10483         _initialize_string_view_selftests unconditionally.
10484
10485 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10486
10487         PR gdb/24350
10488         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10489
10490 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10491
10492         PR gdb/24351
10493         * windows-nat.c (display_selector): Fix format specifiers.
10494
10495 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10496
10497         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10498         tui_refill_source_window instead of tui_refresh_win, to update the
10499         current execution line.  This fixes redisplay of the current line
10500         when stepping through the code with "next" or "step".
10501
10502 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10503
10504         * source-cache.c (source_cache::get_source_lines): Call
10505         find_source_lines to initialize s->nlines.  This fixes vertical
10506         scrolling of TUI source window when the DOWN arrow is pressed.
10507
10508 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10509
10510         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10511         linux-thread-db.c (_initialize_thread_db): Likewise.
10512
10513 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10514
10515         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10516         wclrtoeol in tui_show_source_line".  This reverts changes made in
10517         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10518
10519 2019-03-15  Tom Tromey  <tom@tromey.com>
10520
10521         * symtab.h (struct minimal_symbol): Derive from
10522         general_symbol_info.
10523         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10524         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10525         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10526         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10527         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10528         (MSYMBOL_SEARCH_NAME): Update.
10529         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10530         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10531         * minsyms.c (minimal_symbol_reader::record_full): Update.
10532
10533 2019-03-15  Tom Tromey  <tom@tromey.com>
10534
10535         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10536
10537 2019-03-15  Tom Tromey  <tom@tromey.com>
10538
10539         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10540         unique_xmalloc_ptr.
10541         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10542         Update.
10543         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10544         (build_minimal_symbol_hash_tables)
10545         (minimal_symbol_reader::install): Update.
10546
10547 2019-03-15  Tom Tromey  <tom@tromey.com>
10548
10549         * symtab.c (create_demangled_names_hash): Update.
10550         (symbol_set_names): Update.
10551         * objfiles.h (struct objfile_per_bfd_storage)
10552         <demangled_names_hash>: Now an htab_up.
10553         * objfiles.c (objfile_per_bfd_storage): Simplify.
10554
10555 2019-03-15  Tom Tromey  <tom@tromey.com>
10556
10557         * objfiles.h (struct objfile_per_bfd_storage): Declare
10558         destructor.
10559         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10560         New.
10561         (get_objfile_bfd_data): Use new.  Don't initialize
10562         language_of_main.
10563         (free_objfile_per_bfd_storage): Remove.
10564         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10565
10566 2019-03-15  Tom Tromey  <tom@tromey.com>
10567
10568         * symfile.c (reread_symbols): Update.
10569         * objfiles.c (objfile::objfile): Update.
10570         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10571         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10572         comment.
10573         (minimal_symbol_reader::install): Update.
10574         (terminate_minimal_symbol_table): Remove.
10575         * jit.c (jit_object_close_impl): Update.
10576
10577 2019-03-15  Tom Tromey  <tom@tromey.com>
10578
10579         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10580         initializations.
10581
10582 2019-03-15  Tom Tromey  <tom@tromey.com>
10583
10584         * objfiles.h (struct objfile_per_bfd_storage)
10585         <demangled_hash_languages>: Now a bitset.
10586         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10587         (lookup_minimal_symbol): Update.
10588
10589 2019-03-15  Tom Tromey  <tom@tromey.com>
10590
10591         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10592         Don't return the symbol.
10593         * coffread.c (record_minimal_symbol): Use record_full.
10594
10595 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10596
10597         The MS-Windows port of ncurses fails to switch to a color pair if
10598         one or both of the colors are the implicit default colors.  This
10599         change records the default colors when TUI is initialized, and
10600         then specifies them explicitly when a color pair uses the default
10601         colors.  This allows color styling in TUI mode on MS-Windows.
10602
10603         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10604         ncurses_norm_attr.
10605         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10606         colors in ncurses_norm_attr.
10607         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10608         "none", replace it with the default color recorded in
10609         ncurses_norm_attr.
10610
10611 2019-03-14  Tom Tromey  <tromey@adacore.com>
10612
10613         * source-cache.h (class source_cache) <get_source_lines>: Return
10614         std::string.
10615         * source-cache.c (source_cache::extract_lines): Handle case where
10616         first_pos==npos.  Return std::string.
10617         (source_cache::get_source_lines): Update.
10618
10619 2019-03-14  Tom Tromey  <tromey@adacore.com>
10620
10621         * NEWS: Add item for "style sources" commands.
10622         * source-cache.c (source_cache::get_source_lines): Check
10623         source_styling.
10624         * cli/cli-style.c (source_styling): New global.
10625         (_initialize_cli_style): Add "style sources" commands.
10626         (show_style_sources): New function.
10627         * cli/cli-style.h (source_styling): Declare.
10628
10629 2019-03-14  Pedro Alves  <palves@redhat.com>
10630             Tom Tromey  <tromey@adacore.com>
10631
10632         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10633         * tui/tui-winsource.c (tui_refill_source_window): New function,
10634         from...
10635         (tui_horizontal_source_scroll): ... here.  Move some logic.
10636         * cli/cli-style.c (set_style_enabled): Notify new observable.
10637         * tui/tui-hooks.c (tui_redisplay_source): New function.
10638         (tui_attach_detach_observers): Attach or detach
10639         tui_redisplay_source.
10640         * observable.h (source_styling_changed): New observable.
10641         * observable.c: Define source_styling_changed observable.
10642
10643 2019-03-13  Tom Tromey  <tromey@adacore.com>
10644
10645         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10646         (i386_gnu_nat_target::store_registers): Update.
10647         * target-debug.h (target_debug_print_std_string): New macro.
10648         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10649         * windows-tdep.c (display_one_tib): Update.
10650         * tui/tui-stack.c (tui_make_status_line): Update.
10651         * top.c (print_inferior_quit_action): Update.
10652         * thread.c (thr_try_catch_cmd): Update.
10653         (add_thread_with_info): Update.
10654         (thread_target_id_str): Update.
10655         (thr_try_catch_cmd): Update.
10656         (thread_command): Update.
10657         (thread_find_command): Update.
10658         * record-btrace.c (record_btrace_target::info_record)
10659         (record_btrace_resume_thread, record_btrace_target::resume)
10660         (record_btrace_cancel_resume, record_btrace_step_thread)
10661         (record_btrace_target::wait, record_btrace_target::wait)
10662         (record_btrace_target::wait, record_btrace_target::stop): Update.
10663         * progspace.c (print_program_space): Update.
10664         * process-stratum-target.c
10665         (process_stratum_target::thread_address_space): Update.
10666         * linux-fork.c (linux_fork_mourn_inferior)
10667         (detach_checkpoint_command, info_checkpoints_command)
10668         (linux_fork_context): Update.
10669         (linux_fork_detach): Update.
10670         (class scoped_switch_fork_info): Update.
10671         (delete_checkpoint_command): Update.
10672         * infrun.c (follow_fork_inferior): Update.
10673         (follow_fork_inferior): Update.
10674         (proceed_after_vfork_done): Update.
10675         (handle_vfork_child_exec_or_exit): Update.
10676         (follow_exec): Update.
10677         (displaced_step_prepare_throw): Update.
10678         (displaced_step_restore): Update.
10679         (start_step_over): Update.
10680         (resume_1): Update.
10681         (clear_proceed_status_thread): Update.
10682         (proceed): Update.
10683         (print_target_wait_results): Update.
10684         (do_target_wait): Update.
10685         (context_switch): Update.
10686         (stop_all_threads): Update.
10687         (restart_threads): Update.
10688         (finish_step_over): Update.
10689         (handle_signal_stop): Update.
10690         (switch_back_to_stepped_thread): Update.
10691         (keep_going_pass_signal): Update.
10692         (print_exited_reason): Update.
10693         (normal_stop): Update.
10694         * inferior.c (inferior_pid_to_str): Change return type.
10695         (print_selected_inferior): Update.
10696         (add_inferior): Update.
10697         (detach_inferior): Update.
10698         * dummy-frame.c (fprint_dummy_frames): Update.
10699         * dcache.c (dcache_info_1): Update.
10700         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10701         (btrace_fetch, btrace_clear): Update.
10702         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10703         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10704         type.
10705         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10706         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10707         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10708         * gdbarch.c, gdbarch.h: Rebuild.
10709         * gdbarch.sh (core_pid_to_str): Change return type.
10710         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10711         return type.
10712         (windows_nat_target::pid_to_str): Change return type.
10713         (windows_delete_thread): Update.
10714         (windows_nat_target::attach): Update.
10715         (windows_nat_target::files_info): Update.
10716         * target-delegates.c: Rebuild.
10717         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10718         return type.
10719         (sol_thread_target::pid_to_str): Change return type.
10720         * remote.c (class remote_target) <pid_to_str>: Change return
10721         type.
10722         (remote_target::pid_to_str): Change return type.
10723         (extended_remote_target::attach, remote_target::remote_stop_ns)
10724         (remote_target::remote_notif_remove_queued_reply)
10725         (remote_target::push_stop_reply, remote_target::disable_btrace):
10726         Update.
10727         (extended_remote_target::attach): Update.
10728         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10729         type.
10730         (gdbsim_target::pid_to_str): Change return type.
10731         * ravenscar-thread.c (struct ravenscar_thread_target)
10732         <pid_to_str>: Change return type.
10733         (ravenscar_thread_target::pid_to_str): Change return type.
10734         * procfs.c (class procfs_target) <pid_to_str>: Change return
10735         type.
10736         (procfs_target::pid_to_str): Change return type.
10737         (procfs_target::attach): Update.
10738         (procfs_target::detach): Update.
10739         (procfs_target::fetch_registers): Update.
10740         (procfs_target::store_registers): Update.
10741         (procfs_target::wait): Update.
10742         (procfs_target::files_info): Update.
10743         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10744         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10745         return type.
10746         (nto_procfs_target::pid_to_str): Change return type.
10747         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10748         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10749         return type.
10750         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10751         (exit_lwp): Update.
10752         (attach_proc_task_lwp_callback, get_detach_signal)
10753         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10754         (linux_nat_target::resume, wait_lwp, stop_callback)
10755         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10756         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10757         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10758         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10759         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10760         type.
10761         (inf_ptrace_target::attach): Update.
10762         (inf_ptrace_target::files_info): Update.
10763         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10764         type.
10765         (go32_nat_target::pid_to_str): Change return type.
10766         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10767         (gnu_nat_target::wait): Update.
10768         (gnu_nat_target::wait): Update.
10769         (gnu_nat_target::resume): Update.
10770         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10771         (fbsd_nat_target::wait): Update.
10772         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10773         type.
10774         (darwin_nat_target::attach): Update.
10775         * corelow.c (class core_target) <pid_to_str>: Change return type.
10776         (core_target::pid_to_str): Change return type.
10777         * target.c (normal_pid_to_str): Change return type.
10778         (default_pid_to_str): Likewise.
10779         (target_pid_to_str): Change return type.
10780         (target_translate_tls_address): Update.
10781         (target_announce_detach): Update.
10782         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10783         return type.
10784         (bsd_uthread_target::pid_to_str): Change return type.
10785         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10786         type.
10787         (bsd_kvm_target::pid_to_str): Change return type.
10788         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10789         return type.
10790         (aix_thread_target::pid_to_str): Change return type.
10791         * target.h (struct target_ops) <pid_to_str>: Change return type.
10792         (target_pid_to_str, normal_pid_to_str): Likewise.
10793         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10794         type.
10795         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10796         type.
10797         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10798         return type.
10799         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10800         type.
10801         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10802         type.
10803         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10804         return type.
10805
10806 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10807
10808         * NEWS: Mention that the new default MI version is 3.  Mention
10809         changes to the output of commands and events that deal with
10810         multi-location breakpoints.
10811         * breakpoint.c: Include "mi/mi-out.h".
10812         (print_one_breakpoint): Change output syntax if using MI version
10813         >= 3.
10814         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10815         New.
10816         (mi_multi_location_breakpoint_output_fixed): New.
10817         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10818         (mi_cmd_fix_multi_location_breakpoint_output): New.
10819         (mi_multi_location_breakpoint_output_fixed): New.
10820         * mi/mi-cmds.c (mi_cmds): Register command
10821         -fix-multi-location-breakpoint-output.
10822         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10823         interpreter "mi".
10824
10825 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10826
10827         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10828         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10829         instantiate mi_ui_out based on interpreter name.
10830         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10831         * mi/mi-main.c (mi_load_progress): Likewise.
10832
10833 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10834
10835         * NEWS: Combine separate "New targets" sections for 8.3.
10836
10837 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10838
10839         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10840         (ppcfbsd_init_abi): Install gdbarch
10841         "fetch_tls_load_module_address" and "get_thread_local_address"
10842         methods.
10843
10844 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10845
10846         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10847         (riscv_fbsd_init_abi): Install gdbarch
10848         "fetch_tls_load_module_address" and "get_thread_local_address"
10849         methods.
10850
10851 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10852
10853         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10854         (i386fbsd_init_abi): Install gdbarch
10855         "fetch_tls_load_module_address" and "get_thread_local_address"
10856         methods.
10857
10858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10859
10860         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10861         (amd64fbsd_init_abi): Install gdbarch
10862         "fetch_tls_load_module_address" and "get_thread_local_address"
10863         methods.
10864
10865 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10866
10867         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10868         (struct fbsd_pspace_data): New type.
10869         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10870         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10871         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10872         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10873         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10874
10875 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10876
10877         * gdbtypes.c (lookup_struct_elt): New function.
10878         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10879         * gdbtypes.h (struct struct_elt): New type.
10880         (lookup_struct_elt): New prototype.
10881
10882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10883
10884         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10885         remove disabled code block.
10886
10887 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10888
10889         * gdbarch.sh (get_thread_local_address): New method.
10890         * gdbarch.h, gdbarch.c: Regenerate.
10891         * target.c (target_translate_tls_address): Use
10892         gdbarch_get_thread_local_address if present instead of
10893         target::get_thread_local_address.
10894
10895 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10896
10897         * target.h (target::get_thread_local_address): Update comment.
10898
10899 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10900
10901         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10902         objfile->separate_debug_objfile_backlink if not NULL.
10903
10904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10905
10906         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10907         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10908         (amd64bsd_store_inferior_registers): Likewise.
10909         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10910         Enable segment base registers.
10911         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10912         PT_GETFSBASE and PT_GETGSBASE.
10913         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10914         PT_SETGSBASE.
10915         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10916         segment base registers.
10917         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10918
10919 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10920
10921         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10922         Update calls to i386_target_description to add 'segments'
10923         parameter.
10924         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10925         add segment base registers.
10926         * arch/i386.c (i386_create_target_description): Add 'segments'
10927         parameter to enable segment base registers.
10928         * arch/i386.h (i386_create_target_description): Likewise.
10929         * features/i386/32bit-segments.xml: New file.
10930         * features/i386/32bit-segments.c: Generate.
10931         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10932         call to i386_target_description to add 'segments' parameter.
10933         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10934         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10935         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10936         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10937         if feature is present.
10938         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10939         Add 'segments' parameter to call to i386_target_description.
10940         (i386_target_description): Add 'segments' parameter to enable
10941         segment base registers.
10942         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10943         to call to i386_target_description.
10944         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10945         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10946         Define I386_NUM_REGS.
10947         (i386_target_description): Add 'segments' parameter to enable
10948         segment base registers.
10949
10950 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10951
10952         PR/24325
10953         * source-cache.c: #undef open and close, to avoid unresolved
10954         externals during linking.
10955
10956 2019-03-12  Tom Tromey  <tromey@adacore.com>
10957
10958         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10959         const.  Add initializers.
10960         (_initialize_remote): Don't initialize ptid globals.
10961
10962 2019-03-12  Pedro Alves  <palves@redhat.com>
10963
10964         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10965
10966 2019-03-12  Pedro Alves  <palves@redhat.com>
10967
10968         * cp-name-parser.y (main): Remove unused 'len' variable.
10969
10970 2019-03-12  Tom Tromey  <tromey@adacore.com>
10971
10972         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10973         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10974
10975 2019-03-12  Tom Tromey  <tromey@adacore.com>
10976
10977         * linux-nat.c (iterate_over_lwps): Update.
10978         (stop_callback): Remove parameter.
10979         (stop_wait_callback, detach_callback, resume_set_callback)
10980         (select_singlestep_lwp_callback, set_ignore_sigint)
10981         (status_callback, resumed_callback, resume_clear_callback)
10982         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10983         data parameter.
10984         (linux_nat_target::detach, linux_nat_target::resume)
10985         (linux_stop_and_wait_all_lwps, select_event_lwp)
10986         (linux_nat_filter_event, linux_nat_wait_1)
10987         (linux_nat_target::kill, linux_nat_target::stop)
10988         (linux_nat_target::stop): Update.
10989         (linux_nat_resume_callback): Change type.
10990         (resume_stopped_resumed_lwps, count_events_callback)
10991         (select_event_lwp_callback): Likewise.
10992         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10993         * arm-linux-nat.c (struct update_registers_data): Remove.
10994         (update_registers_callback): Change type.
10995         (arm_linux_insert_hw_breakpoint1): Update.
10996         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10997         parameter.
10998         (x86_linux_dr_set_addr): Update.
10999         (x86_linux_dr_set_control): Update.
11000         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11001         (iterate_over_lwps): Use gdb::function_view.
11002         * nat/aarch64-linux-hw-point.c (struct
11003         aarch64_dr_update_callback_param): Remove.
11004         (debug_reg_change_callback): Change type.
11005         (aarch64_notify_debug_reg_change): Update.
11006         * s390-linux-nat.c (s390_refresh_per_info): Update.
11007
11008 2019-03-11  Tom Tromey  <tromey@adacore.com>
11009
11010         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11011         redundant assignment to "this_cu".
11012
11013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11014
11015         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11016
11017 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11018
11019         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11020         from...
11021         (rank_one_type): ... this.
11022
11023 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11024
11025         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11026         from...
11027         (rank_one_type): ... this.
11028
11029 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11030
11031         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11032         from...
11033         (rank_one_type): ... this.
11034
11035 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11036
11037         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11038         from...
11039         (rank_one_type): ... this.
11040
11041 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11042
11043         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11044         from...
11045         (rank_one_type): ... this.
11046
11047 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11048
11049         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11050         from...
11051         (rank_one_type): ... this.
11052
11053 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11054
11055         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11056         from...
11057         (rank_one_type): ... this.
11058
11059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11060
11061         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11062         from...
11063         (rank_one_type): ... this.
11064
11065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11066
11067         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11068         from...
11069         (rank_one_type): ... this.
11070
11071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11072
11073         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11074         from...
11075         (rank_one_type): ... this.
11076
11077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11078
11079         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11080         from...
11081         (rank_one_type): ... this.
11082
11083 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11084
11085         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11086         from...
11087         (rank_one_type): ... this.
11088
11089 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11090
11091         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11092         inferior-events' shows the example events.
11093
11094 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11095
11096         Support styling on native MS-Windows console
11097
11098         PR/24315
11099         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11100         on MS-Windows if $TERM is not defined.
11101
11102         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11103
11104         * posix-hdep.c (gdb_console_fputs):
11105         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11106         functions.
11107         * ui-file.h (gdb_console_fputs): Add prototype.
11108
11109         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11110         back to fputs only if the former returns zero.
11111
11112 2019-03-07  Tom Tromey  <tom@tromey.com>
11113
11114         * symmisc.c (print_symbol_bcache_statistics): Update.
11115         (print_objfile_statistics): Update.
11116         * symfile.c (allocate_symtab): Update.
11117         * stabsread.c: Don't include bcache.h.
11118         * psymtab.h (struct psymbol_bcache): Don't declare.
11119         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11120         (psymbol_bcache_init, psymbol_bcache_free)
11121         (psymbol_bcache_get_bcache): Don't declare.
11122         * psymtab.c (struct psymbol_bcache): Remove.
11123         (psymtab_storage::psymtab_storage): Update.
11124         (psymtab_storage::~psymtab_storage): Update.
11125         (psymbol_bcache_init, psymbol_bcache_free)
11126         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11127         (add_psymbol_to_bcache): Update.
11128         (allocate_psymtab): Update.
11129         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11130         macro_cache>: No longer pointers.
11131         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11132         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11133         * macrotab.c (macro_bcache): Update.
11134         * macroexp.c: Don't include bcache.h.
11135         * gdbtypes.c (check_types_worklist): Update.
11136         (types_deeply_equal): Remove TRY/CATCH.  Update.
11137         * elfread.c (elf_symtab_read): Update.
11138         * dwarf2read.c: Don't include bcache.h.
11139         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11140         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11141         (print_bcache_statistics, bcache_memory_used): Don't declare.
11142         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11143         methods.  Rename all data members.
11144         * bcache.c (struct bcache): Move to bcache.h.
11145         (bcache::expand_hash_table): Rename from expand_hash_table.
11146         (bcache): Remove.
11147         (bcache::insert): Rename from bcache_full.
11148         (bcache::compare): Rename from bcache_compare.
11149         (bcache_xmalloc): Remove.
11150         (bcache::~bcache): Rename from bcache_xfree.
11151         (bcache::print_statistics): Rename from print_bcache_statistics.
11152         (bcache::memory_used): Rename from bcache_memory_used.
11153
11154 2019-03-07  Pedro Alves  <palves@redhat.com>
11155
11156         * infrun.c (normal_stop): Also check for
11157         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11158
11159 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11160
11161         * f-lang.c (value_from_host_double): Moved to...
11162         * value.c (value_from_host_double): ...here.
11163         * value.h (value_from_host_double): Declare.
11164         * guile/scm-math.c (vlscm_convert_typed_number): Use
11165         value_from_host_double.
11166         (vlscm_convert_number): Likewise.
11167         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11168         * python/py-value.c (convert_value_from_python): Likewise.
11169
11170 2019-03-06  Tom Tromey  <tom@tromey.com>
11171
11172         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11173
11174 2019-03-06  Tom Tromey  <tom@tromey.com>
11175
11176         * utils.h (free_current_contents): Don't declare.
11177         * utils.c (free_current_contents): Remove.
11178
11179 2019-03-06  Tom Tromey  <tom@tromey.com>
11180
11181         * top.c (quit_force): Update.
11182         * main.c (captured_command_loop): Update.
11183         * common/new-op.c (operator new): Update.
11184         * common/common-exceptions.c (struct catcher)
11185         <save_cleanup_chain>: Remove member.
11186         (exceptions_state_mc_init): Update.
11187         (exception_try_scope_entry): Return nullptr.
11188         (exception_try_scope_exit, exception_rethrow)
11189         (throw_exception_sjlj, throw_exception_cxx): Update.
11190         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11191         (all_cleanups, do_cleanups, discard_cleanups)
11192         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11193         (restore_cleanups, restore_final_cleanups): Don't declare.
11194         (do_final_cleanups): Remove parameter.
11195         * common/cleanups.c (cleanup_chain, make_cleanup)
11196         (make_cleanup_dtor, all_cleanups, do_cleanups)
11197         (discard_my_cleanups, discard_cleanups)
11198         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11199         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11200         (null_cleanup): Remove.
11201         (do_final_cleanups): Remove parameter.
11202
11203 2019-03-06  Tom Tromey  <tom@tromey.com>
11204
11205         * remote.c (remote_target::remote_parse_stop_reply): Use
11206         unique_xmalloc_ptr.
11207
11208 2019-03-06  Tom Tromey  <tom@tromey.com>
11209
11210         * stabsread.c (struct stabs_field_info): Rename from field_info.
11211         <list, fnlist>: Add initializers.
11212         <obstack>: New member.
11213         (read_member_functions, read_struct_fields, read_baseclasses):
11214         Allocate on obstack.  Don't use cleanups.
11215         (read_one_struct_field, read_member_functions, read_struct_fields)
11216         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11217         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11218         (read_struct_type): Update.
11219
11220 2019-03-06  Tom Tromey  <tom@tromey.com>
11221
11222         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11223         * common/filestuff.h (make_cleanup_close): Don't declare.
11224         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11225         Remove.
11226
11227 2019-03-06  Tom Tromey  <tom@tromey.com>
11228
11229         * solib-aix.c: Use make_scope_exit.
11230
11231 2019-03-06  Tom Tromey  <tom@tromey.com>
11232
11233         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11234         Use make_scope_exit.
11235
11236 2019-03-06  Tom Tromey  <tom@tromey.com>
11237
11238         * solib-svr4.c (disable_probes_interface): Remove parameter.
11239         (svr4_handle_solib_event): Use make_scope_exit.
11240
11241 2019-03-06  Tom Tromey  <tom@tromey.com>
11242
11243         * remote.c (struct stop_reply_deleter): Remove.
11244         (stop_reply_up): Update.
11245         (struct stop_reply): Derive from notif_event.  Don't typedef.
11246         <regcache>: Now a std::vector.
11247         (stop_reply_xfree): Remove.
11248         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11249         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11250         (remote_target::discard_pending_stop_replies): Use delete.
11251         (remote_target::remote_parse_stop_reply): Update.
11252         (remote_target::process_stop_reply): Update.
11253         * remote-notif.h (struct notif_event): Add virtual destructor.
11254         Remove "dtr" member.
11255         (struct notif_client) <alloc_event>: Return a unique_ptr.
11256         (notif_event_xfree): Don't declare.
11257         (notif_event_up): New typedef.
11258         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11259         (notif_event_xfree, do_notif_event_xfree): Remove.
11260         (remote_notif_state_xfree): Update.
11261
11262 2019-03-06  Tom Tromey  <tom@tromey.com>
11263
11264         * infrun.c (displaced_step_clear_cleanup): Now a
11265         forward_scope_exit type.
11266         (displaced_step_prepare_throw): Update.
11267         (displaced_step_fixup): Update.
11268
11269 2019-03-06  Tom Tromey  <tom@tromey.com>
11270
11271         * inferior.h (class inferior): Update comment.
11272         * gdbthread.h (class thread_info): Update comment.
11273
11274 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11275             Tom Tromey  <tom@tromey.com>
11276
11277         * stabsread.h (struct stab_section_list): Remove.
11278         (coffstab_build_psymtabs): Update.
11279         * dbxread.c (symbuf_sections): Now a std::vector.
11280         (sect_idx): New global.
11281         (fill_symbuf): Update.
11282         (coffstab_build_psymtabs): Change type of stabsects parameter.
11283         Update.
11284         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11285         std::vector.
11286         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11287         (coff_locate_sections): Update.
11288         (coff_symfile_read): Remove cleanups.  Update.
11289         (init_stringtab): Add storage parameter.
11290         (free_stringtab, free_stringtab_cleanup): Remove.
11291         (init_lineno): Add storage parameter.
11292         (free_linetab, free_linetab_cleanup): Remove.
11293
11294 2019-03-06  Pedro Alves  <palves@redhat.com>
11295
11296         * linux-fork.c (fork_info::clobber_regs): Delete.
11297         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11298         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11299         comment.  Adjust.
11300         (scoped_switch_fork_info::scoped_switch_fork_info)
11301         (checkpoint_command, linux_fork_context): Adjust
11302         fork_save_infrun_state calls.
11303
11304 2019-03-06  Pedro Alves  <palves@redhat.com>
11305
11306         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11307         (inf_has_multiple_threads): Return 'bool' and rewrite using
11308         inferior_info::threads().
11309
11310 2019-03-06  Pedro Alves  <palves@redhat.com>
11311
11312         * linux-fork.c: Include <list>.
11313         (fork_list): Now a std::list instance.
11314         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11315         (forks_exist_p, find_last_fork): Adjust.
11316         (new_fork): Delete.
11317         (one_fork_p): New.
11318         (add_fork): Adjust.
11319         (free_fork): Delete, folded into fork_info::~fork_info().
11320         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11321         Adjust.
11322         (init_fork_list): Delete.
11323         (linux_fork_killall, linux_fork_mourn_inferior)
11324         (linux_fork_detach, info_checkpoints_command): Adjust.
11325         (_initialize_linux_fork): No longer call init_fork_list.
11326
11327 2019-03-06  Pedro Alves  <palves@redhat.com>
11328
11329         * linux-fork.c (new_fork): New, split out of ...
11330         (add_fork): ... this.  Return void.  Move "first fork" special
11331         case from here, to ...
11332         (checkpoint_command): ... here.
11333         * linux-linux.h (add_fork): Return void.
11334
11335 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11336
11337         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11338
11339 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11340             Chris January  <chris.january@arm.com>
11341             David Lecomber  <david.lecomber@arm.com>
11342
11343         * f-exp.y: New token, UNOP_INTRINSIC.
11344         (exp): New pattern using UNOP_INTRINSIC token.
11345         (f77_keywords): Add 'abs' keyword.
11346         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11347         (value_from_host_double): New function.
11348         (evaluate_subexp_f): Support UNOP_ABS.
11349
11350 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11351
11352         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11353         types.
11354
11355 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11356
11357         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11358         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11359         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11360
11361 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11362
11363         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11364
11365 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11366             Chris January  <chris.january@arm.com>
11367
11368         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11369         * f-exp.y: Define 'KIND' token.
11370         (exp): New pattern for KIND expressions.
11371         (ptype): Handle types with a kind extension.
11372         (direct_abs_decl): Extend to spot kind extensions.
11373         (f77_keywords): Add 'kind' to the list.
11374         (push_kind_type): New function.
11375         (convert_to_kind_type): New function.
11376         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11377         * parse.c (operator_length_standard): Likewise.
11378         * parser-defs.h (enum type_pieces): Add tp_kind.
11379         * std-operator.def: Add UNOP_KIND.
11380
11381 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11382
11383         * f-exp.y (f_parse): Set yydebug.
11384
11385 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11386
11387         * f-lang.c (evaluate_subexp_f): New function.
11388         (exp_descriptor_f): New global.
11389         (f_language_defn): Use exp_descriptor_f instead of
11390         exp_descriptor_standard.
11391
11392 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11393
11394         * f-exp.y (struct token): Add comments.
11395         (dot_ops): Remove uppercase versions and the end marker.
11396         (f77_keywords): Likewise.
11397         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11398         entries in the dot_ops array are case insensitive, and use
11399         strncasecmp to compare strings.  Also some whitespace cleanup in
11400         this area.  Similar for the f77_keywords array, except entries in
11401         this list might be case sensitive.
11402
11403 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11404
11405         * f-exp.y (struct f77_boolean_val): Add comments.
11406         (boolean_values): Remove uppercase versions, and end marker.
11407         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11408         and use strncasecmp to achieve case insensitivity.  Additionally,
11409         perform whitespace cleanup around this code.
11410
11411 2019-03-06  Tom Tromey  <tromey@adacore.com>
11412
11413         * remote-sim.c (gdbsim_target_open): Use result of
11414         gdb_argv::release.
11415
11416 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11417         Dirk Schubert  <dirk.schubert@arm.com>
11418         Chris January  <chris.january@arm.com>
11419
11420         * eval.c (evaluate_subexp_standard): Call Fortran argument
11421         wrapping logic.
11422         * f-lang.c (struct value): A value which can be passed into a
11423         Fortran function call.
11424         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11425         where appropriate.
11426         (struct type): Value ready for a Fortran function call.
11427         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11428         is needed.
11429         * f-lang.h (fortran_argument_convert): Declaration.
11430         (fortran_preserve_arg_pointer): Declaration.
11431         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11432
11433 2019-03-05  Tom Tromey  <tromey@adacore.com>
11434
11435         * python/py-prettyprint.c (print_string_repr): Remove #if.
11436         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11437
11438 2019-03-05  Tom Tromey  <tromey@adacore.com>
11439
11440         * target.c (the_dummy_target): Move later.  Change type to
11441         "dummy_target".
11442         (initialize_targets): Don't initialize the_dummy_target.
11443
11444 2019-03-05  Tom Tromey  <tromey@adacore.com>
11445
11446         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11447         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11448
11449 2019-03-05  Tom Tromey  <tromey@adacore.com>
11450
11451         * windows-nat.c (windows_nat_target::attach)
11452         (windows_nat_target::detach): Don't call gdb_flush.
11453         * valprint.c (generic_val_print, val_print, val_print_string):
11454         Don't call gdb_flush.
11455         * utils.c (defaulted_query): Don't call gdb_flush.
11456         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11457         * target.c (target_announce_detach): Don't call gdb_flush.
11458         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11459         * remote.c (extended_remote_target::attach): Don't call
11460         gdb_flush.
11461         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11462         * printcmd.c (do_examine): Don't call gdb_flush.
11463         (info_display_command): Don't call gdb_flush.
11464         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11465         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11466         * memattr.c (info_mem_command): Don't call gdb_flush.
11467         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11468         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11469         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11470         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11471         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11472         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11473         (gnu_nat_target::detach): Don't call gdb_flush.
11474         * f-valprint.c (f_val_print): Don't call gdb_flush.
11475         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11476         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11477         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11478         gdb_flush.
11479         * c-valprint.c (c_val_print): Don't call gdb_flush.
11480         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11481
11482 2019-03-05  Tom Tromey  <tromey@adacore.com>
11483
11484         * varobj.c (update_dynamic_varobj_children): Update.
11485         (install_default_visualizer): Use reset, not release.
11486         * value.c (set_internalvar): Update.
11487         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11488         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11489         ATTRIBUTE_UNUSED_RESULT.
11490
11491 2019-03-05  Tom Tromey  <tromey@adacore.com>
11492
11493         * remote.c (class scoped_remote_fd) <release>: Add
11494         ATTRIBUTE_UNUSED_RESULT.
11495
11496 2019-03-05  Tom Tromey  <tromey@adacore.com>
11497
11498         * macroexp.c (struct macro_buffer) <release>: Add
11499         ATTRIBUTE_UNUSED_RESULT.
11500
11501 2019-03-05  Tom Tromey  <tromey@adacore.com>
11502
11503         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11504         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11505         ATTRIBUTE_UNUSED_RESULT.
11506
11507 2019-03-05  Tom Tromey  <tromey@adacore.com>
11508
11509         * common/scoped_fd.h (class scoped_fd) <release>: Add
11510         ATTRIBUTE_UNUSED_RESULT.
11511
11512 2019-03-05  Tom Tromey  <tromey@adacore.com>
11513
11514         * parser-defs.h (struct parser_state) <release>: Add
11515         ATTRIBUTE_UNUSED_RESULT.
11516
11517 2019-03-05  Tom Tromey  <tromey@adacore.com>
11518
11519         * utils.h (class gdb_argv) <release>: Add
11520         ATTRIBUTE_UNUSED_RESULT.
11521         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11522
11523 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11524
11525         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11526         for-loop range, to avoid compiler warnings.
11527
11528         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11529         avoid compiler warnings about unused variables.
11530
11531         * NEWS: Mention end of support for native debugging on MS-Windows
11532         before XP.
11533
11534         PR gdb/24292
11535         * common/netstuff.c:
11536         * gdbserver/gdbreplay.c
11537         * gdbserver/remote-utils.c:
11538         * ser-tcp.c:
11539         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11540         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11541         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11542         'getaddrinfo' and 'freeaddrinfo' were not available before
11543         Windows XP, and mingw.org's MinGW headers by default define
11544         _WIN32_WINNT to 0x500.
11545
11546 2019-03-01  Gary Benson <gbenson@redhat.com>
11547
11548         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11549
11550 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11551             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11552
11553         PR gdb/8527
11554         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11555         set_sigint_trap, clear_sigint_trap.
11556
11557 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11558
11559         * target.c (target_detach): Clear the regcache and the
11560         frame cache.
11561
11562 2019-02-27  Pedro Alves  <palves@redhat.com>
11563
11564         * utils.c (set_screen_size): When we cap the height/width sizes,
11565         tweak the corresponding command variable to show "unlimited":
11566
11567 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11568             Pedro Alves  <palves@redhat.com>
11569
11570         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11571         before calling rl_set_screen_size.
11572
11573 2019-02-27  Tom Tromey  <tromey@adacore.com>
11574
11575         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11576         define.
11577         * python/py-value.c: Remove Python 2.4 workaround.
11578         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11579         workaround.
11580         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11581         Python 2.4 workaround.
11582         * python/python-internal.h: Remove Python 2.4 comment.
11583         (Py_ssize_t): Don't define.
11584         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11585         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11586         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11587         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11588         * python/python.c (do_start_initialization): Remove Python 2.4
11589         workaround.
11590         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11591         (print_children): Remove Python 2.4 workaround.
11592         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11593         workaround.
11594         (CHARBUFFERPROC_NAME): Remove.
11595         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11596         Python 2.4 workaround.
11597
11598 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11599
11600         * NEWS: Note minimum Python version.
11601
11602 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11603
11604         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11605         code from these functions.  Remove corresponding ifdefs.  Use
11606         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11607         Remove gotos and target of gotos.
11608         (infpy_search_memory): Likewise.
11609
11610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11611
11612         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11613         (hppa_gdbarch_init): Don't register deleted functions with
11614         gdbarch.
11615
11616 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11617
11618         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11619         (h8300_unwind_sp): Delete.
11620         (h8300_dummy_id): Delete.
11621         (h8300_gdbarch_init): Don't register deleted functions with
11622         gdbarch.
11623
11624 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11625
11626         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11627         (ft32_unwind_pc): Delete.
11628         (ft32_unwind_sp): Delete.
11629         (ft32_gdbarch_init): Don't register deleted functions with
11630         gdbarch.
11631
11632 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11633
11634         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11635         (frv_unwind_pc): Delete.
11636         (frv_unwind_sp): Delete.
11637         (frv_gdbarch_init): Don't register deleted functions with
11638         gdbarch.
11639
11640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11641
11642         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11643         (riscv_unwind_pc): Delete.
11644         (riscv_unwind_sp): Delete.
11645         (riscv_gdbarch_init): Don't register deleted functions with
11646         gdbarch.
11647
11648 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11649
11650         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11651         (csky_unwind_pc): Delete.
11652         (csky_unwind_sp): Delete.
11653         (csky_gdbarch_init): Don't register deleted functions with
11654         gdbarch.
11655
11656 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11657
11658         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11659         (cris_unwind_pc): Delete.
11660         (cris_unwind_sp): Delete.
11661         (cris_gdbarch_init): Don't register deleted functions with
11662         gdbarch.
11663
11664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11665
11666         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11667         (bfin_unwind_pc): Delete.
11668         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11669
11670 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11671
11672         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11673         (arm_unwind_pc): Delete.
11674         (arm_unwind_sp): Delete.
11675         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11676
11677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11678
11679         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11680         (arc_unwind_pc): Delete.
11681         (arc_unwind_sp): Delete.
11682         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11683
11684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11685
11686         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11687         (alpha_unwind_pc): Delete.
11688         (alpha_gdbarch_init): Don't register deleted functions with
11689         gdbarch.
11690
11691 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11692
11693         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11694         (aarch64_unwind_pc): Delete.
11695         (aarch64_unwind_sp): Delete.
11696         (aarch64_gdbarch_init): Don't register deleted functions with
11697         gdbarch.
11698
11699 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11700
11701         * gdbtypes.c (type_align): Don't consider static members when
11702         computing structure alignment.
11703
11704 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11705
11706         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11707         return 0 for other types.
11708         * arch-utils.c (default_type_align): Always return 0.
11709         * gdbarch.h: Regenerate.
11710         * gdbarch.sh (type_align): Extend comment.
11711         * gdbtypes.c (type_align): Add additional comments, always call
11712         gdbarch_type_align before applying the default rules.
11713         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11714         generic code will then apply a suitable default.
11715         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11716         types, return 0 for other types.
11717
11718 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11719
11720         * NEWS: Create a new section for the next release branch.
11721         Rename the section of the current branch, now that it has
11722         been cut.
11723
11724 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11725
11726         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11727         * version.in: Bump version to 8.3.50.DATE-git.
11728
11729 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11730
11731         * aix-thread.c (ptid_cmp): Remove unused variable.
11732         (get_signaled_thread): Likewise.
11733         (store_regs_user_thread): Likewise.
11734         (store_regs_kernel_thread): Likewise.
11735         (fetch_regs_kernel_thread): Remove shadowed variable.
11736
11737 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11738
11739         * features/riscv/32bit-cpu.xml: Add register numbers.
11740         * features/riscv/32bit-fpu.c: Regenerate.
11741         * features/riscv/32bit-fpu.xml: Add register numbers.
11742         * features/riscv/64bit-cpu.xml: Add register numbers.
11743         * features/riscv/64bit-fpu.c: Regenerate.
11744         * features/riscv/64bit-fpu.xml: Add register numbers.
11745
11746 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11747
11748         * NEWS: Mention two argument form of gdb.Value constructor.
11749         * python/py-value.c (convert_buffer_and_type_to_value): New
11750         function.
11751         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11752         Add support for handling an optional second argument.  Call
11753         convert_buffer_and_type_to_value as appropriate.
11754         * python/python-internal.h (Py_buffer_deleter): New struct.
11755         (Py_buffer_up): New typedef.
11756
11757 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11758
11759         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11760         instead of releasing ownership.
11761
11762 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11763
11764         * dwarf2read.c (open_and_init_dwp_file): Call
11765         elf_numsections instead of bfd_count_sections to initialize
11766         dwp_file->num_sections.
11767
11768 2019-02-25  Tom Tromey  <tromey@adacore.com>
11769
11770         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11771
11772 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11773
11774         * gcore.in: Add '--readnever' option when invoking GDB.
11775
11776 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11777
11778         * MAINTAINERS: Update my email address.
11779
11780 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11781
11782         * build-id.c (build_id_to_debug_bfd_1): New function.
11783         (build_id_to_debug_bfd): Look for separate debug file in
11784         sysroot.
11785
11786 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11787
11788         * gdbarch.sh: Update the copyright year range that is placed into
11789         generated files.
11790
11791 2019-02-22  Keith Seitz  <keiths@redhat.com>
11792
11793         PR symtab/23853
11794         * linespec.c (create_sals_line_offset): Search for the default
11795         symtab's filename instead of its fullname.
11796
11797 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11798
11799         * NEWS: Update style defaults.
11800
11801 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11802
11803         * main.c (captured_main_1): Disable styling in batch mode.
11804
11805 2019-02-20  Tom Tromey  <tom@tromey.com>
11806
11807         * symtab.c (symtab_symbol_info): Fix typos.
11808
11809 2019-02-20  Tom Tromey  <tromey@adacore.com>
11810
11811         * findcmd.c (_initialize_mem_search): Use upper case for
11812         metasyntactic variables.
11813
11814 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11815
11816         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11817         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11818
11819 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11820
11821         * top.h (source_file_name): Change to std::string.
11822         * top.c (source_file_name): Likewise.
11823         (command_line_input): Adjust.
11824         * cli/cli-script.c (script_from_file): Adjust.
11825
11826 2019-02-19  Tom Tromey  <tromey@adacore.com>
11827
11828         * ravenscar-thread.c
11829         (ravenscar_thread_target::update_thread_list): Don't call
11830         ada_build_task_list.
11831         * ada-lang.h (ada_build_task_list): Don't declare.
11832         * ada-tasks.c (struct ada_tasks_inferior_data)
11833         <task_list_valid_p>: Now bool.
11834         (read_known_tasks, ada_task_list_changed)
11835         (ada_tasks_invalidate_inferior_data): Update.
11836         (read_known_tasks_array): Return bool.
11837         (read_known_tasks_list): Likewise.
11838         (read_known_tasks): Return void.
11839         (ada_build_task_list): Now static.
11840
11841 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11842
11843         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11844         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11845
11846 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11847
11848         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11849         variant for ada_tasks_pspace_data_handle and
11850         ada_tasks_inferior_data_handle.
11851         (ada_tasks_pspace_data_cleanup): New function.
11852         (ada_tasks_inferior_data_cleanup): New function.
11853
11854 2019-02-17  Tom Tromey  <tom@tromey.com>
11855
11856         * macrotab.h (macro_source_fullname): Return a std::string.
11857         * macrotab.c (macro_include, check_for_redefinition)
11858         (macro_undef, macro_lookup_definition, foreach_macro)
11859         (foreach_macro_in_scope): Update.
11860         (macro_source_fullname): Return a std::string.
11861         * macrocmd.c (show_pp_source_pos): Update.
11862
11863 2019-02-17  Tom Tromey  <tom@tromey.com>
11864
11865         * macrocmd.c (show_pp_source_pos): Style the file names.
11866
11867 2019-02-17  Tom Tromey  <tom@tromey.com>
11868
11869         PR tui/24197:
11870         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11871
11872 2019-02-17  Tom Tromey  <tom@tromey.com>
11873
11874         * ada-lang.c (user_select_syms): Use filtered printing.
11875         * utils.c (wrap_style): New global.
11876         (desired_style): Remove.
11877         (emit_style_escape): Add stream parameter.
11878         (set_output_style, reset_terminal_style, prompt_for_continue):
11879         Update.
11880         (flush_wrap_buffer): Only flush gdb_stdout.
11881         (wrap_here): Set wrap_style.
11882         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11883         treat escape sequences as a character.  Change when wrap buffer is
11884         flushed.
11885         (fputs_styled): Do not set the output style when the default is
11886         requested.
11887         * ui-style.h (struct ui_file_style) <is_default>: New method.
11888         * source.c (print_source_lines_base): Emit escape sequences in one
11889         piece.
11890
11891 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11892
11893         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11894         integers and enumeration types.
11895
11896 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11897
11898         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11899         instead of lookup_symbol_in_language
11900         (do_exact_match): New function.
11901         (ada_get_symbol_name_matcher): Return do_exact_match when
11902         doing a verbatim match.
11903
11904 2019-02-15  Tom Tromey  <tromey@adacore.com>
11905
11906         * ravenscar-thread.c (ravenscar_thread_target::resume)
11907         (ravenscar_thread_target::wait): Special case wildcard requests.
11908
11909 2019-02-15  Tom Tromey  <tromey@adacore.com>
11910
11911         * ravenscar-thread.c (base_ptid): Remove.
11912         (struct ravenscar_thread_target) <close>: New method.
11913         <m_base_ptid>: New member.
11914         <update_inferior_ptid, active_task, task_is_currently_active,
11915         runtime_initialized>: Declare methods.
11916         <ravenscar_thread_target>: Add constructor.
11917         (ravenscar_thread_target::task_is_currently_active)
11918         (ravenscar_thread_target::update_inferior_ptid)
11919         (ravenscar_runtime_initialized): Rename.  Now methods.
11920         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11921         (ravenscar_thread_target::update_thread_list): Update.
11922         (ravenscar_thread_target::active_task): Now method.
11923         (ravenscar_thread_target::store_registers)
11924         (ravenscar_thread_target::prepare_to_store)
11925         (ravenscar_thread_target::prepare_to_store)
11926         (ravenscar_thread_target::mourn_inferior): Update.
11927         (ravenscar_inferior_created): Use "new" to create target.
11928         (ravenscar_thread_target::get_ada_task_ptid): Update.
11929         (_initialize_ravenscar): Don't initialize base_ptid.
11930         (ravenscar_ops): Remove global.
11931
11932 2019-02-15  Tom Tromey  <tromey@adacore.com>
11933
11934         * target.h (push_target): Declare new overload.
11935         * target.c (push_target): New overload, taking an rvalue reference.
11936         * remote.c (remote_target::open_1): Use push_target overload.
11937         * corelow.c (core_target_open): Use push_target overload.
11938
11939 2019-02-15  Tom Tromey  <tromey@adacore.com>
11940
11941         * ravenscar-thread.c (is_ravenscar_task)
11942         (ravenscar_task_is_currently_active): Return bool.
11943         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11944         (_initialize_ravenscar): Remove "(void)".
11945         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11946         Return bool.
11947
11948 2019-02-15  Tom Tromey  <tromey@adacore.com>
11949
11950         * ravenscar-thread.c (ravenscar_runtime_initializer)
11951         (has_ravenscar_runtime, get_running_thread_id)
11952         (ravenscar_thread_target::resume): Fix indentation.
11953
11954 2019-02-15  Tom Tromey  <tromey@adacore.com>
11955
11956         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11957         from ravenscar_arch_ops.
11958         (sparc_ravenscar_ops::fetch_registers)
11959         (sparc_ravenscar_ops::store_registers): Now methods.
11960         (sparc_ravenscar_prepare_to_store): Remove.
11961         (sparc_ravenscar_ops): Redefine.
11962         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11963         methods and destructor.  Remove members.
11964         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11965         (ravenscar_thread_target::store_registers)
11966         (ravenscar_thread_target::prepare_to_store): Update.
11967         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11968         Remove.
11969         (struct ppc_ravenscar_powerpc_ops): Derive from
11970         ravenscar_arch_ops.
11971         (ppc_ravenscar_powerpc_ops::fetch_registers)
11972         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11973         (ppc_ravenscar_powerpc_ops): Redefine.
11974         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11975         (ppc_ravenscar_e500_ops::fetch_registers)
11976         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11977         (ppc_ravenscar_e500_ops): Redefine.
11978         * aarch64-ravenscar-thread.c
11979         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11980         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11981         (aarch64_ravenscar_fetch_registers)
11982         (aarch64_ravenscar_store_registers): Now methods.
11983         (aarch64_ravenscar_ops): Redefine.
11984
11985 2019-02-15  Tom Tromey  <tromey@adacore.com>
11986
11987         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11988         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11989         (ravenscar_thread_target::stopped_by_watchpoint)
11990         (ravenscar_thread_target::stopped_data_address)
11991         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11992
11993 2019-02-15  Tom Tromey  <tromey@adacore.com>
11994
11995         * ravenscar-thread.c: Fix some typos.
11996
11997 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11998             Tom Tromey  <tromey@adacore.com>
11999
12000         * ada-lang.c (ada_exception_sal): Change addr_string to a
12001         std::string.
12002         (create_ada_exception_catchpoint): Update.
12003
12004 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12005             Tom Tromey  <tromey@adacore.com>
12006
12007         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12008         (bp_location_ops): Remove.
12009         (base_breakpoint_allocate_location): Update.
12010         (free_bp_location): Update.
12011         * ada-lang.c (class ada_catchpoint_location)
12012         <ada_catchpoint_location>: Remove ops parameter.
12013         (ada_catchpoint_location_dtor): Remove.
12014         (ada_catchpoint_location_ops): Remove.
12015         (allocate_location_exception): Update.
12016         * breakpoint.h (struct bp_location_ops): Remove.
12017         (class bp_location) <bp_location>: Remove bp_location_ops
12018         parameter.
12019         <~bp_location>: Add destructor.
12020         <ops>: Remove.
12021
12022 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12023             Pedro Alves  <palves@redhat.com>
12024
12025         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12026         'PATH_MAX'.
12027
12028 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12029             Samuel Thibault  <samuel.thibault@gnu.org>
12030             Thomas Schwinge  <thomas@codesourcery.com>
12031
12032         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12033         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12034
12035 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12036
12037         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12038         (check_empty): Use "const char *".
12039
12040         * gnu-nat.c (gnu_nat_target::detach): Instead of
12041         'detach_inferior (pid)' call
12042         'detach_inferior (find_inferior_pid (pid))'.
12043
12044         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12045         'nat/fork-inferior.o'.
12046         * gnu-nat.c: #include "nat/fork-inferior.h".
12047
12048         * gnu-nat.c (gnu_nat_target::detach): Instead of
12049         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12050         * gnu-nat.h: #include "inf-child.h".
12051         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12052         'i386_gnu_nat_target::fetch_registers'.
12053         (gnu_store_registers): Rename/move to
12054         'i386_gnu_nat_target::store_registers'.
12055
12056         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12057         * gnu-nat.h (mach_thread_info): New function.
12058         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12059
12060         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12061
12062 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12063
12064         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12065
12066 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12067
12068         * windows-nat.c (windows_add_thread): Add new parameter
12069         "main_thread_p" with default value set to false.  Update
12070         function documentation as well as all callers.
12071         (windows_delete_thread): Likewise.
12072         (fake_create_process): Update call to windows_add_thread.
12073         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12074         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12075         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12076         call to windows_delete_thread.
12077
12078 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12079
12080         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12081
12082 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12083
12084         * symfile.c (find_separate_debug_file): Use canonical path of
12085         sysroot with child_path instead of gdb_sysroot if it is valid.
12086
12087 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12088
12089         * symfile.c (find_separate_debug_file): Use child_path to
12090         determine if an object file is under a sysroot.
12091
12092 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12093
12094         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12095         unittests/child-path-selftests.c.
12096         * common/pathstuff.c (child_path): New function.
12097         * common/pathstuff.h (child_path): New prototype.
12098         * unittests/child-path-selftests.c: New file.
12099
12100 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12101
12102         * symfile.c (find_separate_debug_file): Look for separate debug
12103         files in debug directories under the sysroot.
12104
12105 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12106
12107         * symtab.h (struct minimal_symbol data_p): New const method.
12108         (struct minimal_symbol text_p): Likewise.
12109         * symtab.c (output_source_filename): Use file name style
12110         to print file name.
12111         (print_symbol_info): Likewise.
12112         (print_msymbol_info): Use address style to print addresses.
12113         Use function name style to print executable text symbols.
12114         (expand_symtab_containing_pc): Use data_p.
12115         (find_pc_sect_compunit_symtab): Likewise.
12116
12117 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12118
12119         * breakpoint.c (describe_other_breakpoints): Use address style
12120         to print addresses.
12121         (say_where): Likewise.
12122
12123 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12124
12125         * ada-typeprint.c (print_func_type): Print function name
12126         style to print function name.
12127         * c-typeprint.c (c_print_type_1): Likewise.
12128
12129 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12130
12131         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12132         for execve.
12133
12134 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12135
12136         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12137         type_stack.
12138
12139 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12140
12141         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12142         TYPE_CODE_REF types.
12143
12144 2019-02-08  Jim Wilson  <jimw@sifive.com>
12145
12146         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12147         (riscv_linux_fregset): New.
12148         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12149
12150 2019-02-07  Tom Tromey  <tom@tromey.com>
12151
12152         * thread.c (thread_cancel_execution_command): Update.
12153         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12154         methods.
12155         (struct thread_fsm_ops): Remove.
12156         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12157         (thread_fsm_should_stop, thread_fsm_return_value)
12158         (thread_fsm_set_finished, thread_fsm_finished_p)
12159         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12160         Don't declare.
12161         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12162         * infrun.c (clear_proceed_status_thread)
12163         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12164         (print_stop_event): Update.
12165         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12166         Add constructor.
12167         (step_command_fsm_ops): Remove.
12168         (new_step_command_fsm): Remove.
12169         (step_1): Update.
12170         (step_command_fsm::should_stop): Rename from
12171         step_command_fsm_should_stop.
12172         (step_command_fsm::clean_up): Rename from
12173         step_command_fsm_clean_up.
12174         (step_command_fsm::do_async_reply_reason): Rename from
12175         step_command_fsm_async_reply_reason.
12176         (struct until_next_fsm): Inherit from thread_fsm.  Add
12177         constructor.
12178         (until_next_fsm_ops): Remove.
12179         (new_until_next_fsm): Remove.
12180         (until_next_fsm::should_stop): Rename from
12181         until_next_fsm_should_stop.
12182         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12183         (until_next_fsm::do_async_reply_reason): Rename from
12184         until_next_fsm_async_reply_reason.
12185         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12186         constructor.  Change type of breakpoint.
12187         (finish_command_fsm_ops): Remove.
12188         (new_finish_command_fsm): Remove.
12189         (finish_command_fsm::should_stop): Rename from
12190         finish_command_fsm_should_stop.
12191         (finish_command_fsm::clean_up): Rename from
12192         finish_command_fsm_clean_up.
12193         (finish_command_fsm::return_value): Rename from
12194         finish_command_fsm_return_value.
12195         (finish_command_fsm::do_async_reply_reason): Rename from
12196         finish_command_fsm_async_reply_reason.
12197         (finish_command): Update.
12198         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12199         Add constructor.
12200         (call_thread_fsm_ops): Remove.
12201         (call_thread_fsm::call_thread_fsm): Rename from
12202         new_call_thread_fsm.
12203         (call_thread_fsm::should_stop): Rename from
12204         call_thread_fsm_should_stop.
12205         (call_thread_fsm::should_notify_stop): Rename from
12206         call_thread_fsm_should_notify_stop.
12207         (run_inferior_call, call_function_by_hand_dummy): Update.
12208         * cli/cli-interp.c (should_print_stop_to_console): Update.
12209         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12210         Add constructor.  Change type of location_breakpoint,
12211         caller_breakpoint.
12212         (until_break_fsm_ops): Remove.
12213         (new_until_break_fsm): Remove.
12214         (until_break_fsm::should_stop): Rename from
12215         until_break_fsm_should_stop.
12216         (until_break_fsm::clean_up): Rename from
12217         until_break_fsm_clean_up.
12218         (until_break_fsm::do_async_reply_reason): Rename from
12219         until_break_fsm_async_reply_reason.
12220         (until_break_command): Update.
12221         * thread-fsm.c: Remove.
12222         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12223
12224 2019-02-07  Tom Tromey  <tom@tromey.com>
12225
12226         * yy-remap.h: Add include guard.
12227         * xtensa-tdep.h: Add include guard.
12228         * xcoffread.h: Rename include guard.
12229         * varobj-iter.h: Add include guard.
12230         * tui/tui.h: Rename include guard.
12231         * tui/tui-winsource.h: Rename include guard.
12232         * tui/tui-wingeneral.h: Rename include guard.
12233         * tui/tui-windata.h: Rename include guard.
12234         * tui/tui-win.h: Rename include guard.
12235         * tui/tui-stack.h: Rename include guard.
12236         * tui/tui-source.h: Rename include guard.
12237         * tui/tui-regs.h: Rename include guard.
12238         * tui/tui-out.h: Rename include guard.
12239         * tui/tui-layout.h: Rename include guard.
12240         * tui/tui-io.h: Rename include guard.
12241         * tui/tui-hooks.h: Rename include guard.
12242         * tui/tui-file.h: Rename include guard.
12243         * tui/tui-disasm.h: Rename include guard.
12244         * tui/tui-data.h: Rename include guard.
12245         * tui/tui-command.h: Rename include guard.
12246         * tic6x-tdep.h: Add include guard.
12247         * target/waitstatus.h: Rename include guard.
12248         * target/wait.h: Rename include guard.
12249         * target/target.h: Rename include guard.
12250         * target/resume.h: Rename include guard.
12251         * target-float.h: Rename include guard.
12252         * stabsread.h: Add include guard.
12253         * rs6000-tdep.h: Add include guard.
12254         * riscv-fbsd-tdep.h: Add include guard.
12255         * regformats/regdef.h: Rename include guard.
12256         * record.h: Rename include guard.
12257         * python/python.h: Rename include guard.
12258         * python/python-internal.h: Rename include guard.
12259         * python/py-stopevent.h: Rename include guard.
12260         * python/py-ref.h: Rename include guard.
12261         * python/py-record.h: Rename include guard.
12262         * python/py-record-full.h: Rename include guard.
12263         * python/py-record-btrace.h: Rename include guard.
12264         * python/py-instruction.h: Rename include guard.
12265         * python/py-events.h: Rename include guard.
12266         * python/py-event.h: Rename include guard.
12267         * procfs.h: Add include guard.
12268         * proc-utils.h: Add include guard.
12269         * p-lang.h: Add include guard.
12270         * or1k-tdep.h: Rename include guard.
12271         * observable.h: Rename include guard.
12272         * nto-tdep.h: Rename include guard.
12273         * nat/x86-linux.h: Rename include guard.
12274         * nat/x86-linux-dregs.h: Rename include guard.
12275         * nat/x86-gcc-cpuid.h: Add include guard.
12276         * nat/x86-dregs.h: Rename include guard.
12277         * nat/x86-cpuid.h: Rename include guard.
12278         * nat/ppc-linux.h: Rename include guard.
12279         * nat/mips-linux-watch.h: Rename include guard.
12280         * nat/linux-waitpid.h: Rename include guard.
12281         * nat/linux-ptrace.h: Rename include guard.
12282         * nat/linux-procfs.h: Rename include guard.
12283         * nat/linux-osdata.h: Rename include guard.
12284         * nat/linux-nat.h: Rename include guard.
12285         * nat/linux-namespaces.h: Rename include guard.
12286         * nat/linux-btrace.h: Rename include guard.
12287         * nat/glibc_thread_db.h: Rename include guard.
12288         * nat/gdb_thread_db.h: Rename include guard.
12289         * nat/gdb_ptrace.h: Rename include guard.
12290         * nat/fork-inferior.h: Rename include guard.
12291         * nat/amd64-linux-siginfo.h: Rename include guard.
12292         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12293         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12294         * nat/aarch64-linux.h: Rename include guard.
12295         * nat/aarch64-linux-hw-point.h: Rename include guard.
12296         * mn10300-tdep.h: Add include guard.
12297         * mips-linux-tdep.h: Add include guard.
12298         * mi/mi-parse.h: Rename include guard.
12299         * mi/mi-out.h: Rename include guard.
12300         * mi/mi-main.h: Rename include guard.
12301         * mi/mi-interp.h: Rename include guard.
12302         * mi/mi-getopt.h: Rename include guard.
12303         * mi/mi-console.h: Rename include guard.
12304         * mi/mi-common.h: Rename include guard.
12305         * mi/mi-cmds.h: Rename include guard.
12306         * mi/mi-cmd-break.h: Rename include guard.
12307         * m2-lang.h: Add include guard.
12308         * location.h: Rename include guard.
12309         * linux-record.h: Rename include guard.
12310         * linux-nat.h: Add include guard.
12311         * linux-fork.h: Add include guard.
12312         * i386-darwin-tdep.h: Rename include guard.
12313         * hppa-linux-offsets.h: Add include guard.
12314         * guile/guile.h: Rename include guard.
12315         * guile/guile-internal.h: Rename include guard.
12316         * gnu-nat.h: Rename include guard.
12317         * gdb-stabs.h: Rename include guard.
12318         * frv-tdep.h: Add include guard.
12319         * f-lang.h: Add include guard.
12320         * event-loop.h: Add include guard.
12321         * darwin-nat.h: Rename include guard.
12322         * cp-abi.h: Rename include guard.
12323         * config/sparc/nm-sol2.h: Rename include guard.
12324         * config/nm-nto.h: Rename include guard.
12325         * config/nm-linux.h: Add include guard.
12326         * config/i386/nm-i386gnu.h: Rename include guard.
12327         * config/djgpp/nl_types.h: Rename include guard.
12328         * config/djgpp/langinfo.h: Rename include guard.
12329         * compile/gcc-cp-plugin.h: Add include guard.
12330         * compile/gcc-c-plugin.h: Add include guard.
12331         * compile/compile.h: Rename include guard.
12332         * compile/compile-object-run.h: Rename include guard.
12333         * compile/compile-object-load.h: Rename include guard.
12334         * compile/compile-internal.h: Rename include guard.
12335         * compile/compile-cplus.h: Rename include guard.
12336         * compile/compile-c.h: Rename include guard.
12337         * common/xml-utils.h: Rename include guard.
12338         * common/x86-xstate.h: Rename include guard.
12339         * common/version.h: Rename include guard.
12340         * common/vec.h: Rename include guard.
12341         * common/tdesc.h: Rename include guard.
12342         * common/selftest.h: Rename include guard.
12343         * common/scoped_restore.h: Rename include guard.
12344         * common/scoped_mmap.h: Rename include guard.
12345         * common/scoped_fd.h: Rename include guard.
12346         * common/safe-iterator.h: Rename include guard.
12347         * common/run-time-clock.h: Rename include guard.
12348         * common/refcounted-object.h: Rename include guard.
12349         * common/queue.h: Rename include guard.
12350         * common/ptid.h: Rename include guard.
12351         * common/print-utils.h: Rename include guard.
12352         * common/preprocessor.h: Rename include guard.
12353         * common/pathstuff.h: Rename include guard.
12354         * common/observable.h: Rename include guard.
12355         * common/netstuff.h: Rename include guard.
12356         * common/job-control.h: Rename include guard.
12357         * common/host-defs.h: Rename include guard.
12358         * common/gdb_wait.h: Rename include guard.
12359         * common/gdb_vecs.h: Rename include guard.
12360         * common/gdb_unlinker.h: Rename include guard.
12361         * common/gdb_unique_ptr.h: Rename include guard.
12362         * common/gdb_tilde_expand.h: Rename include guard.
12363         * common/gdb_sys_time.h: Rename include guard.
12364         * common/gdb_string_view.h: Rename include guard.
12365         * common/gdb_splay_tree.h: Rename include guard.
12366         * common/gdb_setjmp.h: Rename include guard.
12367         * common/gdb_ref_ptr.h: Rename include guard.
12368         * common/gdb_optional.h: Rename include guard.
12369         * common/gdb_locale.h: Rename include guard.
12370         * common/gdb_assert.h: Rename include guard.
12371         * common/filtered-iterator.h: Rename include guard.
12372         * common/filestuff.h: Rename include guard.
12373         * common/fileio.h: Rename include guard.
12374         * common/environ.h: Rename include guard.
12375         * common/common-utils.h: Rename include guard.
12376         * common/common-types.h: Rename include guard.
12377         * common/common-regcache.h: Rename include guard.
12378         * common/common-inferior.h: Rename include guard.
12379         * common/common-gdbthread.h: Rename include guard.
12380         * common/common-exceptions.h: Rename include guard.
12381         * common/common-defs.h: Rename include guard.
12382         * common/common-debug.h: Rename include guard.
12383         * common/cleanups.h: Rename include guard.
12384         * common/buffer.h: Rename include guard.
12385         * common/btrace-common.h: Rename include guard.
12386         * common/break-common.h: Rename include guard.
12387         * cli/cli-utils.h: Rename include guard.
12388         * cli/cli-style.h: Rename include guard.
12389         * cli/cli-setshow.h: Rename include guard.
12390         * cli/cli-script.h: Rename include guard.
12391         * cli/cli-interp.h: Rename include guard.
12392         * cli/cli-decode.h: Rename include guard.
12393         * cli/cli-cmds.h: Rename include guard.
12394         * charset-list.h: Add include guard.
12395         * buildsym-legacy.h: Rename include guard.
12396         * bfin-tdep.h: Add include guard.
12397         * ax.h: Rename include guard.
12398         * arm-linux-tdep.h: Add include guard.
12399         * arm-fbsd-tdep.h: Add include guard.
12400         * arch/xtensa.h: Rename include guard.
12401         * arch/tic6x.h: Add include guard.
12402         * arch/i386.h: Add include guard.
12403         * arch/arm.h: Rename include guard.
12404         * arch/arm-linux.h: Rename include guard.
12405         * arch/arm-get-next-pcs.h: Rename include guard.
12406         * arch/amd64.h: Add include guard.
12407         * arch/aarch64-insn.h: Rename include guard.
12408         * arch-utils.h: Rename include guard.
12409         * annotate.h: Add include guard.
12410         * amd64-darwin-tdep.h: Rename include guard.
12411         * aarch64-linux-tdep.h: Add include guard.
12412         * aarch64-fbsd-tdep.h: Add include guard.
12413         * aarch32-linux-nat.h: Add include guard.
12414
12415 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12416
12417         * macrotab.c (macro_define_internal): New function that
12418         factorizes macro_define_object_internal and macro_define_function
12419         code.
12420         (macro_define_object_internal): Use macro_define_internal.
12421         (macro_define_function): Likewise.
12422
12423 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12424
12425         * macrocmd.c (extract_identifier): Return
12426         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12427         callers.
12428
12429 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12430
12431         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12432
12433 2019-02-05  Tom Tromey  <tom@tromey.com>
12434
12435         * target.c (target_stack::unpush): Move assertion earlier.
12436
12437 2019-01-30  Tom Tromey  <tom@tromey.com>
12438
12439         PR python/23615:
12440         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12441         (gdbpy_parse_and_eval): Likewise.
12442         * python/python-internal.h (gdbpy_allow_threads): New class.
12443
12444 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12445
12446         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12447         (aarch64_fbsd_fpregmap): Move earlier.
12448         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12449         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12450         instead of individual calls to trad_frame_set_reg_addr.
12451         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12452         earlier.
12453         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12454         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12455         instead of individual calls to trad_frame_set_reg_addr.
12456
12457 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12458
12459         * CONTRIBUTE: Replace contribution list with wiki link.
12460
12461 2019-01-25  Tom Tromey  <tom@tromey.com>
12462
12463         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12464
12465 2019-01-25  Tom Tromey  <tom@tromey.com>
12466
12467         * xtensa-linux-nat.c: Fix common/ includes.
12468         * xml-support.h: Fix common/ includes.
12469         * xml-support.c: Fix common/ includes.
12470         * x86-linux-nat.c: Fix common/ includes.
12471         * windows-nat.c: Fix common/ includes.
12472         * varobj.h: Fix common/ includes.
12473         * varobj.c: Fix common/ includes.
12474         * value.c: Fix common/ includes.
12475         * valops.c: Fix common/ includes.
12476         * utils.c: Fix common/ includes.
12477         * unittests/xml-utils-selftests.c: Fix common/ includes.
12478         * unittests/utils-selftests.c: Fix common/ includes.
12479         * unittests/unpack-selftests.c: Fix common/ includes.
12480         * unittests/tracepoint-selftests.c: Fix common/ includes.
12481         * unittests/style-selftests.c: Fix common/ includes.
12482         * unittests/string_view-selftests.c: Fix common/ includes.
12483         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12484         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12485         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12486         * unittests/rsp-low-selftests.c: Fix common/ includes.
12487         * unittests/parse-connection-spec-selftests.c: Fix common/
12488         includes.
12489         * unittests/optional-selftests.c: Fix common/ includes.
12490         * unittests/offset-type-selftests.c: Fix common/ includes.
12491         * unittests/observable-selftests.c: Fix common/ includes.
12492         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12493         * unittests/memrange-selftests.c: Fix common/ includes.
12494         * unittests/memory-map-selftests.c: Fix common/ includes.
12495         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12496         * unittests/function-view-selftests.c: Fix common/ includes.
12497         * unittests/environ-selftests.c: Fix common/ includes.
12498         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12499         * unittests/common-utils-selftests.c: Fix common/ includes.
12500         * unittests/cli-utils-selftests.c: Fix common/ includes.
12501         * unittests/array-view-selftests.c: Fix common/ includes.
12502         * ui-file.c: Fix common/ includes.
12503         * tui/tui-io.c: Fix common/ includes.
12504         * tracepoint.h: Fix common/ includes.
12505         * tracepoint.c: Fix common/ includes.
12506         * tracefile-tfile.c: Fix common/ includes.
12507         * top.h: Fix common/ includes.
12508         * top.c: Fix common/ includes.
12509         * thread.c: Fix common/ includes.
12510         * target/waitstatus.h: Fix common/ includes.
12511         * target/waitstatus.c: Fix common/ includes.
12512         * target.h: Fix common/ includes.
12513         * target.c: Fix common/ includes.
12514         * target-memory.c: Fix common/ includes.
12515         * target-descriptions.c: Fix common/ includes.
12516         * symtab.h: Fix common/ includes.
12517         * symfile.c: Fix common/ includes.
12518         * stap-probe.c: Fix common/ includes.
12519         * spu-linux-nat.c: Fix common/ includes.
12520         * sparc-nat.c: Fix common/ includes.
12521         * source.c: Fix common/ includes.
12522         * solib.c: Fix common/ includes.
12523         * solib-target.c: Fix common/ includes.
12524         * ser-unix.c: Fix common/ includes.
12525         * ser-tcp.c: Fix common/ includes.
12526         * ser-pipe.c: Fix common/ includes.
12527         * ser-base.c: Fix common/ includes.
12528         * selftest-arch.c: Fix common/ includes.
12529         * s12z-tdep.c: Fix common/ includes.
12530         * rust-exp.y: Fix common/ includes.
12531         * rs6000-aix-tdep.c: Fix common/ includes.
12532         * riscv-tdep.c: Fix common/ includes.
12533         * remote.c: Fix common/ includes.
12534         * remote-notif.h: Fix common/ includes.
12535         * remote-fileio.h: Fix common/ includes.
12536         * remote-fileio.c: Fix common/ includes.
12537         * regcache.h: Fix common/ includes.
12538         * regcache.c: Fix common/ includes.
12539         * record-btrace.c: Fix common/ includes.
12540         * python/python.c: Fix common/ includes.
12541         * python/py-type.c: Fix common/ includes.
12542         * python/py-inferior.c: Fix common/ includes.
12543         * progspace.h: Fix common/ includes.
12544         * producer.c: Fix common/ includes.
12545         * procfs.c: Fix common/ includes.
12546         * proc-api.c: Fix common/ includes.
12547         * printcmd.c: Fix common/ includes.
12548         * ppc-linux-nat.c: Fix common/ includes.
12549         * parser-defs.h: Fix common/ includes.
12550         * osdata.c: Fix common/ includes.
12551         * obsd-nat.c: Fix common/ includes.
12552         * nat/x86-linux.c: Fix common/ includes.
12553         * nat/x86-linux-dregs.c: Fix common/ includes.
12554         * nat/x86-dregs.h: Fix common/ includes.
12555         * nat/x86-dregs.c: Fix common/ includes.
12556         * nat/ppc-linux.c: Fix common/ includes.
12557         * nat/mips-linux-watch.h: Fix common/ includes.
12558         * nat/mips-linux-watch.c: Fix common/ includes.
12559         * nat/linux-waitpid.c: Fix common/ includes.
12560         * nat/linux-ptrace.h: Fix common/ includes.
12561         * nat/linux-ptrace.c: Fix common/ includes.
12562         * nat/linux-procfs.c: Fix common/ includes.
12563         * nat/linux-personality.c: Fix common/ includes.
12564         * nat/linux-osdata.c: Fix common/ includes.
12565         * nat/linux-namespaces.c: Fix common/ includes.
12566         * nat/linux-btrace.h: Fix common/ includes.
12567         * nat/linux-btrace.c: Fix common/ includes.
12568         * nat/fork-inferior.c: Fix common/ includes.
12569         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12570         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12571         * nat/aarch64-linux.c: Fix common/ includes.
12572         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12573         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12574         * namespace.h: Fix common/ includes.
12575         * mips-linux-tdep.c: Fix common/ includes.
12576         * minsyms.c: Fix common/ includes.
12577         * mi/mi-parse.h: Fix common/ includes.
12578         * mi/mi-main.c: Fix common/ includes.
12579         * mi/mi-cmd-env.c: Fix common/ includes.
12580         * memrange.h: Fix common/ includes.
12581         * memattr.c: Fix common/ includes.
12582         * maint.h: Fix common/ includes.
12583         * maint.c: Fix common/ includes.
12584         * main.c: Fix common/ includes.
12585         * machoread.c: Fix common/ includes.
12586         * location.c: Fix common/ includes.
12587         * linux-thread-db.c: Fix common/ includes.
12588         * linux-nat.c: Fix common/ includes.
12589         * linux-fork.c: Fix common/ includes.
12590         * inline-frame.c: Fix common/ includes.
12591         * infrun.c: Fix common/ includes.
12592         * inflow.c: Fix common/ includes.
12593         * inferior.h: Fix common/ includes.
12594         * inferior.c: Fix common/ includes.
12595         * infcmd.c: Fix common/ includes.
12596         * inf-ptrace.c: Fix common/ includes.
12597         * inf-child.c: Fix common/ includes.
12598         * ia64-linux-nat.c: Fix common/ includes.
12599         * i387-tdep.c: Fix common/ includes.
12600         * i386-tdep.c: Fix common/ includes.
12601         * i386-linux-tdep.c: Fix common/ includes.
12602         * i386-linux-nat.c: Fix common/ includes.
12603         * i386-go32-tdep.c: Fix common/ includes.
12604         * i386-fbsd-tdep.c: Fix common/ includes.
12605         * i386-fbsd-nat.c: Fix common/ includes.
12606         * guile/scm-type.c: Fix common/ includes.
12607         * guile/guile.c: Fix common/ includes.
12608         * go32-nat.c: Fix common/ includes.
12609         * gnu-nat.c: Fix common/ includes.
12610         * gdbthread.h: Fix common/ includes.
12611         * gdbarch-selftests.c: Fix common/ includes.
12612         * gdb_usleep.c: Fix common/ includes.
12613         * gdb_select.h: Fix common/ includes.
12614         * gdb_bfd.c: Fix common/ includes.
12615         * gcore.c: Fix common/ includes.
12616         * fork-child.c: Fix common/ includes.
12617         * findvar.c: Fix common/ includes.
12618         * fbsd-nat.c: Fix common/ includes.
12619         * event-top.c: Fix common/ includes.
12620         * event-loop.c: Fix common/ includes.
12621         * dwarf2read.c: Fix common/ includes.
12622         * dwarf2loc.c: Fix common/ includes.
12623         * dwarf2-frame.c: Fix common/ includes.
12624         * dwarf-index-cache.c: Fix common/ includes.
12625         * dtrace-probe.c: Fix common/ includes.
12626         * disasm-selftests.c: Fix common/ includes.
12627         * defs.h: Fix common/ includes.
12628         * csky-tdep.c: Fix common/ includes.
12629         * cp-valprint.c: Fix common/ includes.
12630         * cp-support.h: Fix common/ includes.
12631         * cp-support.c: Fix common/ includes.
12632         * corelow.c: Fix common/ includes.
12633         * completer.h: Fix common/ includes.
12634         * completer.c: Fix common/ includes.
12635         * compile/compile.c: Fix common/ includes.
12636         * compile/compile-loc2c.c: Fix common/ includes.
12637         * compile/compile-cplus-types.c: Fix common/ includes.
12638         * compile/compile-cplus-symbols.c: Fix common/ includes.
12639         * command.h: Fix common/ includes.
12640         * cli/cli-dump.c: Fix common/ includes.
12641         * cli/cli-cmds.c: Fix common/ includes.
12642         * charset.c: Fix common/ includes.
12643         * build-id.c: Fix common/ includes.
12644         * btrace.h: Fix common/ includes.
12645         * btrace.c: Fix common/ includes.
12646         * breakpoint.h: Fix common/ includes.
12647         * breakpoint.c: Fix common/ includes.
12648         * ax.h:
12649         (enum agent_op): Fix common/ includes.
12650         * ax-general.c (struct aop_map): Fix common/ includes.
12651         * ax-gdb.c: Fix common/ includes.
12652         * auxv.c: Fix common/ includes.
12653         * auto-load.c: Fix common/ includes.
12654         * arm-tdep.c: Fix common/ includes.
12655         * arch/riscv.c: Fix common/ includes.
12656         * arch/ppc-linux-common.c: Fix common/ includes.
12657         * arch/i386.c: Fix common/ includes.
12658         * arch/arm.c: Fix common/ includes.
12659         * arch/arm-linux.c: Fix common/ includes.
12660         * arch/arm-get-next-pcs.c: Fix common/ includes.
12661         * arch/amd64.c: Fix common/ includes.
12662         * arch/aarch64.c: Fix common/ includes.
12663         * arch/aarch64-insn.c: Fix common/ includes.
12664         * arch-utils.c: Fix common/ includes.
12665         * amd64-windows-tdep.c: Fix common/ includes.
12666         * amd64-tdep.c: Fix common/ includes.
12667         * amd64-sol2-tdep.c: Fix common/ includes.
12668         * amd64-obsd-tdep.c: Fix common/ includes.
12669         * amd64-nbsd-tdep.c: Fix common/ includes.
12670         * amd64-linux-tdep.c: Fix common/ includes.
12671         * amd64-linux-nat.c: Fix common/ includes.
12672         * amd64-fbsd-tdep.c: Fix common/ includes.
12673         * amd64-fbsd-nat.c: Fix common/ includes.
12674         * amd64-dicos-tdep.c: Fix common/ includes.
12675         * amd64-darwin-tdep.c: Fix common/ includes.
12676         * agent.c: Fix common/ includes.
12677         * ada-lang.h: Fix common/ includes.
12678         * ada-lang.c: Fix common/ includes.
12679         * aarch64-tdep.c: Fix common/ includes.
12680
12681 2019-01-25  Tom Tromey  <tom@tromey.com>
12682
12683         * common/create-version.sh: Use common/version.h.
12684
12685 2019-01-24  Pedro Alves  <palves@redhat.com>
12686
12687         * infrun.c (signal_stop, signal_print, signal_program)
12688         (signal_catch, signal_pass): Now arrays instead of pointers.
12689         (update_signals_program_target, do_target_resume)
12690         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12691         * linux-nat.c (linux_nat_target::pass_signals)
12692         (linux_nat_target::create_inferior, linux_nat_target::attach):
12693         Adjust.
12694         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12695         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12696         * procfs.c (procfs_target::pass_signals): Adjust.
12697         * record-full.c (record_full_target::resume): Adjust.
12698         * remote.c (remote_target::pass_signals)
12699         (remote_target::program_signals): Adjust.
12700         * target-debug.h (target_debug_print_signals): Now takes a
12701         gdb::array_view as parameter.  Adjust.
12702         * target.h (target_ops) <pass_signals, program_signals>: Replace
12703         pointer and length parameters with gdb::array_view.
12704         (target_pass_signals, target_program_signals): Likewise.
12705         * target-delegates.c: Regenerate.
12706
12707 2019-01-24  Pedro Alves  <palves@redhat.com>
12708
12709         * common/forward-scope-exit.h
12710         (forward_scope_exit::forward_scope_exit): Pass arguments to
12711         m_bind_function directly, instead of creating a std::bind and
12712         copying that.
12713
12714 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12715
12716         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12717         for static members.
12718         (pass_in_v_vfp_candidate): Likewise.
12719
12720 2019-01-23  Tom Tromey  <tom@tromey.com>
12721             Pedro Alves  <palves@redhat.com>
12722
12723         * regcache.c (class regcache_invalidator): Remove.
12724         (regcache::raw_write): Use make_scope_exit.
12725
12726 2019-01-23  Tom Tromey  <tom@tromey.com>
12727
12728         * ui-out.h (class ui_out_emit_type): Update comment.
12729
12730 2019-01-23  Tom Tromey  <tom@tromey.com>
12731
12732         * infrun.c (fetch_inferior_event): Update comment.
12733
12734 2019-01-23  Tom Tromey  <tom@tromey.com>
12735             Pedro Alves  <palves@redhat.com>
12736
12737         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12738         parameter.
12739         (fetch_inferior_event): Use SCOPE_EXIT.
12740
12741
12742 2019-01-23  Tom Tromey  <tom@tromey.com>
12743             Pedro Alves  <palves@redhat.com>
12744
12745         * infrun.c (disable_thread_events): Delete.
12746         (stop_all_threads): Use SCOPE_EXIT.
12747
12748 2019-01-23  Tom Tromey  <tom@tromey.com>
12749             Pedro Alves  <palves@redhat.com>
12750
12751         * symfile.c: Include forward-scope-exit.h.
12752         (clear_symtab_users_cleanup): Replace forward declaration with
12753         a FORWARD_SCOPE_EXIT.
12754         (syms_from_objfile_1): Use the forward_scope_exit and
12755         gdb::optional instead of cleanup_function.
12756         (reread_symbols): Use the forward_scope_exit instead of
12757         cleanup_function.
12758         (clear_symtab_users_cleanup): Remove function.
12759
12760 2019-01-23  Tom Tromey  <tom@tromey.com>
12761             Pedro Alves  <palves@redhat.com>
12762
12763         * linux-nat.c: Include scope-exit.h.
12764         (cleanup_target_stop): Remove.
12765         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12766         SCOPE_EXIT.
12767
12768 2019-01-23  Tom Tromey  <tom@tromey.com>
12769             Pedro Alves  <palves@redhat.com>
12770
12771         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12772         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12773
12774 2019-01-23  Tom Tromey  <tom@tromey.com>
12775             Andrew Burgess  <andrew.burgess@embecosm.com>
12776             Pedro Alves  <palves@redhat.com>
12777
12778         * infrun.c (fetch_inferior_event): Use scope_exit.
12779         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12780         * top.c (execute_command): Use scope_exit.
12781         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12782         * utils.c (do_bpstat_clear_actions_cleanup)
12783         (make_bpstat_clear_actions_cleanup): Remove.
12784
12785 2019-01-23  Tom Tromey  <tom@tromey.com>
12786             Pedro Alves  <palves@redhat.com>
12787
12788         * infrun.c: Include "common/scope-exit.h"
12789         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12790         (wait_for_inferior): Use SCOPE_EXIT.
12791         (fetch_inferior_event): Use scope_exit.
12792
12793 2019-01-23  Tom Tromey  <tom@tromey.com>
12794             Pedro Alves  <palves@redhat.com>
12795
12796         * breakpoint.c (create_breakpoint): Remove cleanup.
12797
12798 2019-01-23  Tom Tromey  <tom@tromey.com>
12799             Andrew Burgess  <andrew.burgess@embecosm.com>
12800             Pedro Alves  <palves@redhat.com>
12801
12802 2019-01-23  Pedro Alves  <palves@redhat.com>
12803
12804         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12805
12806 2019-01-23  Pedro Alves  <palves@redhat.com>
12807             Andrew Burgess  <andrew.burgess@embecosm.com>
12808
12809         * gdbthread.h: Include "common/forward-scope-exit.h".
12810         (scoped_finish_thread_state): Redefine custom class in terms of
12811         forward_scope_exit.
12812
12813 2019-01-23  Pedro Alves  <palves@redhat.com>
12814             Andrew Burgess  <andrew.burgess@embecosm.com>
12815
12816         * common/forward-scope-exit.h: New file.
12817
12818 2019-01-23  Pedro Alves  <palves@redhat.com>
12819             Andrew Burgess  <andrew.burgess@embecosm.com>
12820             Tom Tromey  <tom@tromey.com>
12821
12822         * common/scope-exit.h: New file.
12823
12824 2019-01-23  Pedro Alves  <palves@redhat.com>
12825
12826         * common/preprocessor.h (ESC): Rename to ...
12827         (ESC_PARENS): ... this.
12828         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12829         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12830
12831 2019-01-23  Tom Tromey  <tom@tromey.com>
12832
12833         * language.h (class scoped_switch_to_sym_language_if_auto):
12834         Initialize m_lang in both cases.
12835
12836 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12837
12838         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12839         with XCNEW.
12840
12841 2019-01-22  Tom Tromey  <tom@tromey.com>
12842
12843         * corelow.c: Do not include sys/file.h.
12844
12845 2019-01-22  Tom Tromey  <tom@tromey.com>
12846
12847         * tui/tui-wingeneral.h: Include gdb_curses.h.
12848
12849 2019-01-22  Tom Tromey  <tom@tromey.com>
12850
12851         * source-cache.h (class source_cache) <get_source_lines,
12852         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12853
12854 2019-01-22  Tom Tromey  <tom@tromey.com>
12855
12856         * remote-fileio.h (struct remote_target): Declare.
12857
12858 2019-01-22  Tom Tromey  <tom@tromey.com>
12859
12860         * python/py-arch.c: Do not include py-ref.h.
12861         * python/py-bpevent.c: Do not include py-ref.h.
12862         * python/py-cmd.c: Do not include py-ref.h.
12863         * python/py-continueevent.c: Do not include py-ref.h.
12864         * python/py-event.h: Do not include py-ref.h.
12865         * python/py-evtregistry.c: Do not include py-ref.h.
12866         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12867         * python/py-frame.c: Do not include py-ref.h.
12868         * python/py-framefilter.c: Do not include py-ref.h.
12869         * python/py-function.c: Do not include py-ref.h.
12870         * python/py-infevents.c: Do not include py-ref.h.
12871         * python/py-linetable.c: Do not include py-ref.h.
12872         * python/py-objfile.c: Do not include py-ref.h.
12873         * python/py-param.c: Do not include py-ref.h.
12874         * python/py-prettyprint.c: Do not include py-ref.h.
12875         * python/py-progspace.c: Do not include py-ref.h.
12876         * python/py-symbol.c: Do not include py-ref.h.
12877         * python/py-symtab.c: Do not include py-ref.h.
12878         * python/py-type.c: Do not include py-ref.h.
12879         * python/py-unwind.c: Do not include py-ref.h.
12880         * python/py-utils.c: Do not include py-ref.h.
12881         * python/py-value.c: Do not include py-ref.h.
12882         * python/py-varobj.c: Do not include py-ref.h.
12883         * python/py-xmethods.c: Do not include py-ref.h.
12884         * python/python.c: Do not include py-ref.h.
12885         * varobj.c: Do not include py-ref.h.
12886
12887 2019-01-22  Tom Tromey  <tom@tromey.com>
12888
12889         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12890         keyword for bcache.
12891
12892 2019-01-22  Tom Tromey  <tom@tromey.com>
12893
12894         * compile/compile-cplus-types.c: Remove a comment by #include.
12895
12896 2019-01-22  Tom Tromey  <tom@tromey.com>
12897
12898         * compile/gcc-c-plugin.h: Include compile-internal.h.
12899
12900 2019-01-22  Tom Tromey  <tom@tromey.com>
12901
12902         * stabsread.c (EXTERN): Do not define.
12903         (symnum, next_symbol_text_func, processing_gcc_compilation)
12904         (within_function, global_sym_chain, global_stabs)
12905         (previous_stab_code, this_object_header_files)
12906         (n_this_object_header_files)
12907         (n_allocated_this_object_header_files): Define.
12908         * stabsread.h (EXTERN): Never define.  Use "extern".
12909
12910 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12911
12912         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12913         history_value.
12914
12915 2019-01-21  Tom Tromey  <tom@tromey.com>
12916
12917         * ui-out.c: Fix includes.
12918         * tui/tui-source.c: Fix includes.
12919         * target.c: Fix includes.
12920         * remote.c: Fix includes.
12921         * regcache.c: Fix includes.
12922         * python/py-block.c: Fix includes.
12923         * printcmd.c: Fix includes.
12924         * or1k-tdep.c: Fix includes.
12925         * mi/mi-main.c: Fix includes.
12926         * m32r-tdep.c: Fix includes.
12927         * csky-tdep.c: Fix includes.
12928         * compile/compile-cplus-types.c: Fix includes.
12929         * cli/cli-interp.c: Fix includes.
12930
12931 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12932
12933         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12934         for padding.
12935
12936 2019-01-16  Tom Tromey  <tom@tromey.com>
12937
12938         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12939         earlier.
12940         (struct objfile) <msymbols_range>: Move from top level.
12941         <msymbols>: New method.
12942         (class objfile_msymbols): Remove.
12943         * symtab.c (default_collect_symbol_completion_matches_break_on):
12944         Update.
12945         * symmisc.c (dump_msymbols): Update.
12946         * stabsread.c (scan_file_globals): Update.
12947         * objc-lang.c (info_selectors_command, info_classes_command)
12948         (find_methods): Update.
12949         * minsyms.c (find_solib_trampoline_target): Update.
12950         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12951         * coffread.c (coff_symfile_read): Update.
12952         * ada-lang.c (ada_lookup_simple_minsym)
12953         (ada_collect_symbol_completion_matches): Update.
12954
12955 2019-01-16  Tom Tromey  <tom@tromey.com>
12956
12957         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12958         type.  Remove no-argument constructor.
12959         <iterator::operator++>: Simplify.
12960         <begin>: Update.
12961         <end>: Use minimal_symbol_count.
12962
12963 2019-01-16  Tom Tromey  <tom@tromey.com>
12964
12965         * objfiles.h (struct objfile) <psymtabs>: New method.
12966         (class objfile_psymtabs): Remove.
12967         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12968         typedef.
12969         <range>: New method.
12970         (require_partial_symbols): Change return type.
12971         * psymtab.c (require_partial_symbols)
12972         (psym_expand_symtabs_matching): Update.
12973         * mdebugread.c (parse_partial_symbols): Update.
12974         * dbxread.c (dbx_end_psymtab): Update.
12975
12976 2019-01-15  Tom Tromey  <tom@tromey.com>
12977
12978         * symtab.c (lookup_objfile_from_block)
12979         (lookup_symbol_in_objfile_symtabs)
12980         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12981         (find_line_symtab, info_sources_command)
12982         (default_collect_symbol_completion_matches_break_on)
12983         (make_source_files_completion_list): Update.
12984         * symmisc.c (print_objfile_statistics, dump_objfile)
12985         (maintenance_print_symbols, maintenance_info_symtabs)
12986         (maintenance_check_symtabs, maintenance_info_line_tables):
12987         Update.
12988         * source.c (select_source_symtab)
12989         (forget_cached_source_info_for_objfile): Update.
12990         * objfiles.h (class objfile_compunits): Remove.
12991         (struct objfile) <compunits_range>: New typedef.
12992         (compunits): New method.
12993         * objfiles.c (objfile_relocate1): Update.
12994         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12995         * maint.c (count_symtabs_and_blocks): Update.
12996         * linespec.c (iterate_over_all_matching_symtabs): Update.
12997         * cp-support.c (add_symbol_overload_list_qualified): Update.
12998         * coffread.c (coff_symtab_read): Update.
12999         * ada-lang.c (add_nonlocal_symbols)
13000         (ada_collect_symbol_completion_matches)
13001         (ada_add_global_exceptions): Update.
13002
13003 2019-01-15  Tom Tromey  <tom@tromey.com>
13004
13005         * progspace.h (program_space) <objfiles_safe_range>: New
13006         typedef.
13007         <objfiles_safe>: New method.
13008         * objfiles.h (class all_objfiles_safe): Remove.
13009         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13010         * jit.c (jit_inferior_exit_hook): Update.
13011
13012 2019-01-17  Tom Tromey  <tom@tromey.com>
13013
13014         * progspace.h (program_space) <objfiles_range>: New typedef.
13015         <objfiles>: New method.
13016         <objfiles_head>: Rename from objfiles.
13017         (object_files): Update.
13018         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13019         * guile/scm-pretty-print.c
13020         (ppscm_find_pretty_printer_from_objfiles): Update.
13021         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13022         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13023         Update.
13024         * python/py-progspace.c (pspy_get_objfiles): Update.
13025         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13026         Update.
13027         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13028         (objfpy_lookup_objfile_by_build_id): Update.
13029         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13030         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13031         Update.
13032         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13033         (expand_symtab_containing_pc, lookup_objfile_from_block)
13034         (lookup_static_symbol, basic_lookup_transparent_type)
13035         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13036         (find_line_symtab, info_sources_command)
13037         (default_collect_symbol_completion_matches_break_on)
13038         (make_source_files_completion_list, find_main_name): Update.
13039         * symmisc.c (print_symbol_bcache_statistics)
13040         (print_objfile_statistics, maintenance_print_symbols)
13041         (maintenance_print_msymbols, maintenance_print_objfiles)
13042         (maintenance_info_symtabs, maintenance_check_symtabs)
13043         (maintenance_expand_symtabs, maintenance_info_line_tables):
13044         Update.
13045         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13046         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13047         (map_overlay_command, unmap_overlay_command)
13048         (simple_overlay_update, expand_symtabs_matching)
13049         (map_symbol_filenames): Update.
13050         * symfile-debug.c (set_debug_symfile): Update.
13051         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13052         Update.
13053         * source.c (select_source_symtab, forget_cached_source_info):
13054         Update.
13055         * solib.c (solib_read_symbols): Update.
13056         * solib-spu.c (append_ocl_sos): Update.
13057         * psymtab.c (maintenance_print_psymbols)
13058         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13059         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13060         * printcmd.c (info_symbol_command): Update.
13061         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13062         Update.
13063         * objfiles.h (class all_objfiles): Remove.
13064         * objfiles.c (have_partial_symbols, have_full_symbols)
13065         (have_minimal_symbols, qsort_cmp, update_section_map)
13066         (shared_objfile_contains_address_p)
13067         (default_iterate_over_objfiles_in_search_order): Update.
13068         * objc-lang.c (info_selectors_command, info_classes_command)
13069         (find_methods): Update.
13070         * minsyms.c (find_solib_trampoline_target): Update.
13071         * maint.c (maintenance_info_sections)
13072         (maintenance_translate_address, count_symtabs_and_blocks):
13073         Update.
13074         * main.c (captured_main_1): Update.
13075         * linux-thread-db.c (try_thread_db_load_from_pdir)
13076         (has_libpthread): Update.
13077         * linespec.c (iterate_over_all_matching_symtabs)
13078         (search_minsyms_for_name): Update.
13079         * jit.c (jit_find_objf_with_entry_addr): Update.
13080         * hppa-tdep.c (find_unwind_entry)
13081         (hppa_lookup_stub_minimal_symbol): Update.
13082         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13083         Update.
13084         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13085         (elf_gnu_ifunc_resolve_by_got): Update.
13086         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13087         * dwarf-index-write.c (save_gdb_index_command): Update.
13088         * cp-support.c (add_symbol_overload_list_qualified): Update.
13089         * breakpoint.c (create_overlay_event_breakpoint)
13090         (create_longjmp_master_breakpoint)
13091         (create_std_terminate_master_breakpoint)
13092         (create_exception_master_breakpoint): Update.
13093         * blockframe.c (find_pc_partial_function): Update.
13094         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13095         (ada_collect_symbol_completion_matches)
13096         (ada_add_global_exceptions): Update.
13097
13098 2019-01-17  Tom Tromey  <tom@tromey.com>
13099
13100         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13101         declare VEC.
13102         (solib_target_parse_libraries): Change return type.
13103         (library_list_start_segment, library_list_start_section)
13104         (library_list_end_library, library_list_start_library); Update.
13105         (solib_target_free_library_list): Remove.
13106         (solib_target_parse_libraries): Remove cleanup.  Change return
13107         type.
13108         (solib_target_current_sos): Update.
13109
13110 2019-01-17  Tom Tromey  <tromey@bapiya>
13111
13112         * valprint.c: Replace "the the" with "the".
13113         * symtab.c: Replace "the the" with "the".
13114         * solib.c: Replace "the the" with "the".
13115         * solib-dsbt.c: Replace "the the" with "the".
13116         * linespec.c: Replace "the the" with "the".
13117         * dwarf2loc.h: Replace "the the" with "the".
13118         * amd64-windows-tdep.c: Replace "the the" with "the".
13119         * aarch64-tdep.c: Replace "the the" with "the".
13120
13121 2019-01-16  Keith Seitz  <keiths@redhat.com>
13122
13123         PR gdb/23773
13124         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13125         <builder>: Rename to ..
13126         <m_builder>: ... this and make private.
13127         (dwarf2_cu::get_builder): New method.  Change all users of
13128         `builder' to use this method.
13129         (dwarf2_start_symtab): Move to ...
13130         (dwarf2_cu::start_symtab): ... here.  Update all callers
13131         (setup_type_unit_groups): Move to ...
13132         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13133         callers.
13134         (dwarf2_cu::reset_builder): New method.
13135         (process_full_compunit, process_full_type_unit): Use
13136         dwarf2_cu::reset_builder.
13137         (follow_die_offset): Record the ancestor CU if it is different
13138         from the followed DIE's CU.
13139         (follow_die_sig_1): Likewise.
13140
13141 2019-01-15  Tom Tromey  <tom@tromey.com>
13142
13143         * remote.c (class remote_state) <buf>: Now a char_vector.
13144         <buf_size>: Remove.
13145         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13146         parameter.
13147         (remote_target::getpkt_or_notif_sane_1)
13148         (remote_target::getpkt_sane)
13149         (remote_target::getpkt_or_notif_sane): Likewise.
13150         (class remote_target) <putpkt>: New overload.
13151         (remote_target::read_frame): Change type of "buf_p".  Remove
13152         sizeof_p parameter.
13153         (packet_ok): New overload.
13154         (packet_check_result): New overload.
13155         Update all uses.
13156
13157 2019-01-14  Tom Tromey  <tom@tromey.com>
13158
13159         * remote-notif.c (handle_notification, remote_notif_ack)
13160         (remote_notif_parse): Make "buf" const.
13161         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13162         const.
13163         (remote_notif_parse, remote_notif_ack, handle_notification):
13164         Likewise.
13165         * remote.c (remote_notif_stop_parse): Make "buf" const.
13166         (remote_target::remote_parse_stop_reply): Make "buf" const.
13167         (remote_notif_stop_ack): Make "buf" const.
13168
13169 2019-01-14  Tom Tromey  <tom@tromey.com>
13170
13171         * remote.c (remote_console_output): Make parameter const.
13172
13173 2019-01-14  Tom Tromey  <tom@tromey.com>
13174
13175         * target-debug.h (target_debug_print_signals): Constify.
13176         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13177         * procfs.c (procfs_target::pass_signals): Update.
13178         * linux-nat.c (linux_nat_target::pass_signals): Update.
13179         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13180         * target-delegates.c: Rebuild.
13181         * remote.c (remote_target::program_signals): Update.
13182         (remote_target::pass_signals): Update.
13183         * target.c (target_pass_signals): Constify argument.
13184         (target_program_signals): Likewise.
13185         * target.h (struct target_ops) <pass_signals, program_signals>:
13186         Constify argument.
13187         (target_pass_signals, target_program_signals): Constify argument.
13188
13189 2019-01-14  Tom Tromey  <tom@tromey.com>
13190
13191         PR tui/28819:
13192         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13193
13194 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13195
13196         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13197         field.
13198         * rs6000-tdep.c: Include reggroups.h.
13199         (IS_V_ALIAS_PSEUDOREG): Define.
13200         (rs6000_register_name): Return names for the "vX" aliases.
13201         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13202         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13203         aliases.  Call default_register_reggroup_p for all other
13204         pseudo-registers.
13205         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13206         New functions.
13207         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13208         Handle "vX" aliases.
13209         (v_alias_pseudo_register_collect): New function.
13210         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13211         (rs6000_gdbarch_init): Initialize "vX" aliases as
13212         pseudo-registers.  Restore registration of
13213         rs6000_pseudo_register_reggroup_p with
13214         set_tdesc_pseudo_register_reggroup_p.
13215
13216 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13217
13218         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13219         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13220         set_gdbarch_num_pseudo_regs.
13221
13222 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13223
13224         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13225         Remove arg prefixname, add do_set and do_show.
13226         Add member functions set_list and show_list.
13227         * cli/cli-style.c (class cli_style_option): Update accordingly.
13228         (style_set_list): Move to file scope.
13229         (style_show_list): Likewise.
13230         (set_style): Call help_list.
13231         (show_style): Call cmd_show_list.
13232         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13233         Update to use the new macro.
13234
13235 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13236
13237         * ada-lang.c (_initialize_ada_language): Expand the help text
13238         for the "catch exception" command.
13239
13240 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13241
13242         * symtab.c (matching_obj_sections): Initialize obj,
13243         declare it closer to its usage.
13244
13245 2019-01-10  Tom Tromey  <tom@tromey.com>
13246
13247         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13248         (basic_inf_threads_range): Remove.
13249         (inf_threads_range, inf_non_exited_threads_range)
13250         (safe_inf_threads_range): Use next_adapter.
13251
13252 2019-01-10  Keith Seitz  <keiths@redhat.com>
13253
13254         PR gdb/23712
13255         PR symtab/23010
13256         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13257         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13258
13259 2019-01-10  Keith Seitz  <keiths@redhat.com>
13260
13261         PR gdb/23712
13262         PR symtab/23010
13263         * dictionary.c (pending_to_vector): Remove.
13264         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13265         Remove _1 suffix, replacing functions of the same name.  Update
13266         all callers.
13267         (dict_create_hashed, dict_create_hashed_expandable)
13268         (dict_create_linear, dict_create_linear_expandable, dict_free)
13269         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13270         Make functions static.
13271
13272 2019-01-10  Keith Seitz  <keiths@redhat.com>
13273
13274         PR gdb/23712
13275         PR symtab/23010
13276         * dictionary.h (struct dictionary): Replace declaration with
13277         multidictionary.
13278         (dict_create_hashed, dict_create_hashed_expandable)
13279         (dict_create_linear, dict_create_linear_expandable)
13280         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13281         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13282         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13283         taking multidictionary argument.
13284         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13285         * block.h (struct block) <dict>: Change to multidictionary
13286         and rename `multidict'.
13287         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13288         symmisc.c: Update all dictionary references to multidictionary.
13289
13290 2019-01-10  Keith Seitz  <keiths@redhat.com>
13291
13292         PR gdb/23712
13293         PR symtab/23010
13294         * dictionary.c: Include unordered_map.
13295         (pending_to_vector): New function.
13296         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13297         Rewrite the non-"_1" functions to take vector instead
13298         of linked list.
13299         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13300         "new" _1 versions of the same name.
13301         (multidictionary): Define.
13302         (std::hash<enum language): New definition.
13303         (collate_pending_symbols_by_language, mdict_create_hashed)
13304         (mdict_create_hashed_expandable, mdict_create_linear)
13305         (mdict_create_linear_expandable, mdict_free)
13306         (find_language_dictionary, create_new_language_dictionary)
13307         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13308         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13309         (mdict_size, mdict_empty): New functions.
13310         * dictionary.h (mdict_iterator): Define.
13311
13312 2019-01-10  Pedro Alves  <palves@redhat.com>
13313
13314         * breakpoint.c (read_uploaded_action)
13315         (create_tracepoint_from_upload): Adjust to use
13316         gdb::unique_xmalloc_ptr.
13317         * ctf.c (ctf_write_uploaded_tp):
13318         (SET_ARRAY_FIELD): Use emplace_back.
13319         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13320         * tracefile-tfile.c (tfile_write_uploaded_tp):
13321         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13322         gdb::unique_xmalloc_ptr.
13323         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13324         at_string, cond_string, cmd_strings>: Replace char pointers
13325         with gdb::unique_xmalloc_ptr.
13326
13327 2019-01-10  Pedro Alves  <palves@redhat.com>
13328
13329         * solib-target.c (library_list_start_library): Don't xstrdup name.
13330
13331 2019-01-10  Pedro Alves  <palves@redhat.com>
13332
13333         * mdebugread.c (parse_partial_symbols): Use
13334         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13335
13336 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13337
13338         * linux-fork.c (scoped_switch_fork_info)
13339         <~scoped_switch_fork_info>: Fix incorrect variable name.
13340
13341 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13342
13343         * linux-fork.c (scoped_switch_fork_info)
13344         <scoped_switch_fork_info>: Make explicit.
13345         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13346
13347 2019-01-10  Tom Tromey  <tom@tromey.com>
13348
13349         * objfiles.h (objfile::reset_psymtabs): Update.
13350         * objfiles.c (objfile::objfile): Update.
13351         * psymtab.h (psymtab_storage::obstack): Update.
13352         (psymtab_storage::m_obstack): Use gdb::optional.
13353         (class psymtab_storage): Update comment.  Remove objfile
13354         parameter.
13355         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13356
13357 2019-01-10  Tom Tromey  <tom@tromey.com>
13358
13359         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13360         <free_psymtabs>: Now private.
13361         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13362         (allocate_psymtab): Use new method.
13363
13364 2019-01-10  Tom Tromey  <tom@tromey.com>
13365
13366         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13367         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13368         * mdebugread.c (parse_partial_symbols): Use
13369         allocate_dependencies.
13370         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13371         allocate_dependencies.
13372         (process_psymtab_comp_unit_reader)
13373         (build_type_psymtab_dependencies): Likewise.
13374         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13375
13376 2019-01-10  Tom Tromey  <tom@tromey.com>
13377
13378         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13379         PSYMBOL_SET_LANGUAGE.
13380         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13381
13382 2019-01-10  Tom Tromey  <tom@tromey.com>
13383
13384         * psymtab.h (psymtab_storage::obstack): New method.
13385         <m_obstack>: Rename from obstack; now private.
13386         * psymtab.c (psymtab_storage): Update.
13387         * dwarf2read.c (create_addrmap_from_index)
13388         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13389         Update.
13390
13391 2019-01-10  Tom Tromey  <tom@tromey.com>
13392
13393         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13394         * objfiles.h (objfile::reset_psymtabs): New method.
13395
13396 2019-01-10  Tom Tromey  <tom@tromey.com>
13397
13398         * symmisc.c (print_symbol_bcache_statistics): Update.
13399         (print_objfile_statistics): Update.
13400         * symfile.c (reread_symbols): Update.
13401         * psymtab.h (class psymtab_storage): New.
13402         * psymtab.c (psymtab_storage): New constructor.
13403         (~psymtab_storage): New destructor.
13404         (require_partial_symbols): Update.
13405         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13406         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13407         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13408         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13409         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13410         (start_psymtab_common, end_psymtab_common)
13411         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13412         (allocate_psymtab): Update.
13413         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13414         Update.
13415         (dump_psymtab_addrmap, maintenance_print_psymbols)
13416         (maintenance_check_psymtabs): Update.
13417         (class objfile_psymtabs): Move to objfiles.h.
13418         * psympriv.h (discard_psymtab): Now inline.
13419         (psymtab_discarder::psymtab_discarder): Update.
13420         (psymtab_discarder::~psymtab_discarder): Update.
13421         (ALL_OBJFILE_PSYMTABS): Rewrite.
13422         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13423         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13424         Remove fields.
13425         <partial_symtabs>: New field.
13426         (class objfile_psymtabs): Move from psymtab.h.  Update.
13427         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13428         psymbol_cache.
13429         (objfile::~objfile): Don't destroy psymbol_cache.
13430         * mdebugread.c (parse_partial_symbols): Update.
13431         * dwarf2read.c (create_addrmap_from_index)
13432         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13433         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13434         (add_partial_subprogram, dwarf2_ranges_read): Update.
13435         * dwarf-index-write.c (write_address_map)
13436         (write_one_signatured_type, recursively_write_psymbols)
13437         (class debug_names, class debug_names, write_psymtabs_to_index):
13438         Update.
13439
13440 2019-01-10  Tom Tromey  <tom@tromey.com>
13441
13442         * symtab.h (SYMBOL_SET_NAMES): Update.
13443         (symbol_set_names): Update.
13444         (MSYMBOL_SET_NAMES): Update.
13445         * symtab.c (symbol_set_names): Change argument to be an
13446         objfile_per_bfd_storage.
13447         * psymtab.c (add_psymbol_to_bcache): Update.
13448         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13449
13450 2019-01-10  Tom Tromey  <tom@tromey.com>
13451
13452         * symtab.c (create_demangled_names_hash): Change argument to be an
13453         objfile_per_bfd_storage.
13454         (symbol_set_names): Update.
13455
13456 2019-01-10  Tom Tromey  <tom@tromey.com>
13457
13458         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13459         init_psymbol_list.
13460         * psymtab.c (init_psymbol_list): Do nothing if already called.
13461         * psympriv.h (init_psymbol_list): Add comment.
13462         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13463         init_psymbol_list.
13464         * dbxread.c (dbx_symfile_read): Unconditionally call
13465         init_psymbol_list.
13466
13467 2019-01-10  Tom Tromey  <tom@tromey.com>
13468
13469         * xcoffread.c (scan_xcoff_symtab): Update.
13470         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13471         "where".
13472         * mdebugread.c (parse_partial_symbols)
13473         (handle_psymbol_enumerators): Update.
13474         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13475         * dbxread.c (read_dbx_symtab): Update.
13476         * psympriv.h (psymbol_placement): New enum.
13477         (add_psymbol_to_list): Update.
13478
13479 2019-01-10  Tom Tromey  <tom@tromey.com>
13480
13481         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13482         static_psymbols parameters.
13483         (scan_xcoff_symtab): Update.
13484         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13485         static_psymbols parameters.
13486         * psympriv.h (start_psymtab_common): Update.
13487         * mdebugread.c (parse_partial_symbols): Update.
13488         * dwarf2read.c (create_partial_symtab): Update.
13489         * dbxread.c (read_dbx_symtab): Update.
13490         (start_psymtab): Remove global_psymbols and static_psymbols
13491         parameters.
13492
13493 2019-01-10  Tom Tromey  <tom@tromey.com>
13494
13495         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13496         * psymtab.c (allocate_psymtab): Add comment.
13497         * psympriv.h (allocate_psymtab): Add comment.
13498         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13499         initializations.
13500         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13501
13502 2019-01-10  Tom Tromey  <tom@tromey.com>
13503
13504         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13505         Don't declare.
13506         * mipsread.c: Include mdebugread.h.
13507         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13508         Declare.
13509         * elfread.c: Include mdebugread.h.
13510
13511 2019-01-09  Tom Tromey  <tom@tromey.com>
13512
13513         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13514         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13515         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13516         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13517         (psym_lookup_symbol, psym_find_last_source_symtab)
13518         (psym_forget_cached_source_info, psym_print_stats)
13519         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13520         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13521         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13522         (psym_find_compunit_symtab_by_address)
13523         (maintenance_print_psymbols, maintenance_info_psymtabs)
13524         (maintenance_check_psymtabs): Use ranged for.
13525         * psymtab.h (class objfile_psymtabs): New.
13526         (require_partial_symbols): Return objfile_psymtabs.
13527         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13528
13529 2019-01-09  Tom Tromey  <tom@tromey.com>
13530
13531         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13532         (find_pc_mapped_section, list_overlays_command)
13533         (map_overlay_command, unmap_overlay_command)
13534         (simple_overlay_update): Use all_objfiles.
13535         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13536         * printcmd.c (info_symbol_command): Use all_objfiles.
13537         * objfiles.h (ALL_OBJSECTIONS): Remove.
13538         * maint.c (maintenance_translate_address): Use all_objfiles.
13539         * gcore.c (gcore_create_callback): Use all_objfiles.
13540         (objfile_find_memory_regions): Likewise.
13541
13542 2019-01-09  Tom Tromey  <tom@tromey.com>
13543
13544         * symtab.c (find_line_symtab, info_sources_command)
13545         (make_source_files_completion_list): Use objfile_compunits.
13546         * source.c (select_source_symtab): Use objfile_compunits.
13547         * objfiles.h (struct objfile): Update comment.
13548         (ALL_OBJFILES): Remove.
13549         (ALL_FILETABS): Remove.
13550         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13551         objfile_compunits.
13552
13553 2019-01-09  Tom Tromey  <tom@tromey.com>
13554
13555         * symmisc.c (print_objfile_statistics, dump_objfile)
13556         (maintenance_print_symbols): Use compunit_filetabs.
13557         * source.c (forget_cached_source_info_for_objfile): Use
13558         compunit_filetabs.
13559         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13560         (ALL_FILETABS): Use compunit_filetabs.
13561         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13562         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13563
13564 2019-01-09  Tom Tromey  <tom@tromey.com>
13565
13566         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13567         (compunit_filetabs): New.
13568         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13569         compunit_filetabs.
13570         (info_sources_command, make_source_files_completion_list): Remove
13571         declaration.
13572         * symmisc.c (print_objfile_statistics, dump_objfile)
13573         (maintenance_print_symbols): Remove declaration.
13574         (maintenance_info_symtabs): Use compunit_filetabs.
13575         (maintenance_info_line_tables): Likewise.
13576         * source.c (select_source_symtab): Change local variable name.
13577         (forget_cached_source_info_for_objfile): Remove declaration.
13578         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13579         * objfiles.c (objfile_relocate1): Remove declaration.
13580         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13581         declaration.
13582         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13583         * coffread.c (coff_symtab_read): Remove declaration.
13584         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13585         compunit_filetabs.
13586
13587 2019-01-09  Tom Tromey  <tom@tromey.com>
13588
13589         * symtab.c (lookup_objfile_from_block)
13590         (find_pc_sect_compunit_symtab, search_symbols)
13591         (default_collect_symbol_completion_matches_break_on): Use
13592         objfile_compunits.
13593         * objfiles.h (ALL_COMPUNITS): Remove.
13594         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13595         * cp-support.c (add_symbol_overload_list_qualified): Use
13596         objfile_compunits.
13597         * ada-lang.c (ada_collect_symbol_completion_matches)
13598         (ada_add_global_exceptions): Use objfile_compunits.
13599
13600 2019-01-09  Tom Tromey  <tom@tromey.com>
13601
13602         * source.c (select_source_symtab)
13603         (forget_cached_source_info_for_objfile): Remove declaration.
13604         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13605         declaration.
13606         * maint.c (count_symtabs_and_blocks): Remove declaration.
13607         * cp-support.c (add_symbol_overload_list_qualified): Remove
13608         declaration.
13609         * coffread.c (coff_symtab_read): Remove declaration.
13610         * symtab.c (lookup_symbol_in_objfile_symtabs)
13611         (basic_lookup_transparent_type_1): Use objfile_compunits.
13612         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13613         (info_sources_command, search_symbols)
13614         (default_collect_symbol_completion_matches_break_on)
13615         (make_source_files_completion_list): Remove declaration.
13616         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13617         (ada_collect_symbol_completion_matches)
13618         (ada_add_global_exceptions): Remove declaration.
13619         * linespec.c (iterate_over_all_matching_symtabs): Use
13620         objfile_compunits.
13621         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13622         (class objfile_compunits): New.
13623         (ALL_COMPUNITS): Use objfile_compunits.
13624         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13625         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13626         objfile_compunits.
13627         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13628
13629 2019-01-09  Tom Tromey  <tom@tromey.com>
13630
13631         * symtab.c (search_symbols)
13632         (default_collect_symbol_completion_matches_break_on): Use
13633         objfile_msymbols.
13634         * ada-lang.c (ada_lookup_simple_minsym)
13635         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13636         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13637         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13638         objfile_msymbols.
13639         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13640         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13641         * objc-lang.c (find_methods): Use objfile_msymbols.
13642         (info_selectors_command, info_classes_command): Likewise.
13643         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13644         * objfiles.h (class objfile_msymbols): New.
13645         (ALL_OBJFILE_MSYMBOLS): Remove.
13646         (ALL_MSYMBOLS): Remove.
13647
13648 2019-01-09  Tom Tromey  <tom@tromey.com>
13649
13650         * common/next-iterator.h (next_adapter): Add Iterator template
13651         parameter.
13652         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13653         (class all_objfiles_safe): New.
13654         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13655         * objfiles.c (put_objfile_before): Update comment.
13656         (add_separate_debug_objfile): Likewise.
13657         (free_all_objfiles): Use all_objfiles_safe.
13658         (objfile_purge_solibs): Likewise.
13659
13660 2019-01-09  Tom Tromey  <tom@tromey.com>
13661
13662         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13663         (expand_symtab_containing_pc, lookup_static_symbol)
13664         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13665         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13666         all_objfiles.
13667         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13668         * breakpoint.c (create_overlay_event_breakpoint)
13669         (create_longjmp_master_breakpoint)
13670         (create_std_terminate_master_breakpoint)
13671         (create_exception_master_breakpoint): Use all_objfiles.
13672         * linux-thread-db.c (try_thread_db_load_from_pdir)
13673         (has_libpthread): Use all_objfiles.
13674         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13675         * linespec.c (iterate_over_all_matching_symtabs)
13676         (search_minsyms_for_name): Use all_objfiles.
13677         * maint.c (maintenance_info_sections): Use all_objfiles.
13678         * main.c (captured_main_1): Use all_objfiles.
13679         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13680         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13681         * guile/scm-pretty-print.c
13682         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13683         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13684         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13685         (maintenance_print_msymbols): Use all_objfiles.
13686         * source.c (select_source_symtab): Use all_objfiles.
13687         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13688         * symfile.c (remove_symbol_file_command)
13689         (expand_symtabs_matching, map_symbol_filenames): Use
13690         all_objfiles.
13691         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13692         all_objfiles.
13693         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13694         * objc-lang.c (find_methods): Use all_objfiles.
13695         * objfiles.c (have_partial_symbols, have_full_symbols)
13696         (have_minimal_symbols, qsort_cmp)
13697         (default_iterate_over_objfiles_in_search_order): Use
13698         all_objfiles.
13699         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13700         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13701         (maintenance_check_psymtabs): Use all_objfiles.
13702         (ALL_PSYMTABS): Remove.
13703         * compile/compile-object-run.c (do_module_cleanup): Use
13704         all_objfiles.
13705         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13706         * cp-support.c (add_symbol_overload_list_qualified): Use
13707         all_objfiles.
13708         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13709         Use all_objfiles.
13710         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13711         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13712         all_objfiles.
13713         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13714         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13715         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13716         Uses all_objfiles.
13717         * solib.c (solib_read_symbols): Use all_objfiles
13718
13719 2019-01-09  Tom Tromey  <tom@tromey.com>
13720
13721         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13722         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13723         all_objfiles.
13724         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13725         * symmisc.c (print_symbol_bcache_statistics)
13726         (print_objfile_statistics, maintenance_print_objfiles)
13727         (maintenance_info_symtabs, maintenance_check_symtabs)
13728         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13729         all_objfiles.
13730         * source.c (forget_cached_source_info): Use all_objfiles.
13731         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13732         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13733         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13734         * objfiles.c (update_section_map): Use all_objfiles.
13735         (shared_objfile_contains_address_p): Likewise.
13736         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13737         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13738
13739 2019-01-09  Tom Tromey  <tom@tromey.com>
13740
13741         * common/next-iterator.h: New file.
13742         * objfiles.h (class all_objfiles): New.
13743         (struct objfile_iterator): New.
13744
13745 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13746
13747         * NEWS: Move the description of the changed "frame", "select-frame",
13748          and "info frame" commands to the Changed commands section.
13749
13750 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13751
13752         * gdbtypes.c (check_stub_method_group): Remove handling of old
13753         mangling schemes.
13754         * linespec.c (find_methods): Likewise.
13755         * stabsread.c (read_member_functions): Likewise.
13756         * valops.c (search_struct_method): Likewise.
13757         (value_struct_elt_for_reference): Likewise.
13758         * NEWS: Mention this change.
13759
13760 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13761
13762         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13763         print_source_lines.
13764         * source.c (print_source_lines_base): Update line number check.
13765         (print_source_lines): New function.
13766         (source_lines_range::source_lines_range): New function.
13767         * source.h (class source_lines_range): New class.
13768         (print_source_lines): New declaration.
13769
13770 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13771
13772         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13773
13774 2019-01-08  Tom Tromey  <tom@tromey.com>
13775             Simon Marchi  <simon.marchi@ericsson.com>
13776
13777         PR gdb/24060
13778         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13779         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13780         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13781         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13782         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13783         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13784
13785 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13786
13787         * source.c (select_source_symtab): Move header comment to
13788         declaration in source.h.
13789         (forget_cached_source_info_for_objfile): Likewise.
13790         (forget_cached_source_info): Likewise.
13791         (identify_source_line): Likewise.
13792         * source.h (identify_source_line): Move declaration from symtab.h
13793         and add comment from source.c
13794         (print_source_lines): Likewise.
13795         (forget_cached_source_info_for_objfile): Likewise.
13796         (forget_cached_source_info): Likewise.
13797         (select_source_symtab): Likewise.
13798         (enum print_source_lines_flag): Move definition from symtab.h.
13799         * symtab.h (identify_source_line): Move declaration to source.h.
13800         (print_source_lines): Likewise.
13801         (forget_cached_source_info_for_objfile): Likewise.
13802         (forget_cached_source_info): Likewise.
13803         (select_source_symtab): Likewise.
13804         (enum print_source_lines_flag): Move definition to source.h.
13805         * tui/tui-hooks.c: Add 'source.h' include.
13806
13807 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13808
13809         * source.c (print_source_lines_base): Handle requests to print
13810         reverse line number sequences, and guard against empty lines
13811         string.
13812
13813 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13814
13815         * source.c (print_source_lines_base): Fix skip of '\r' if next
13816         character is '\n'.
13817
13818 2019-01-06  Tom Tromey  <tom@tromey.com>
13819
13820         * c-exp.y (struct c_parse_state) <macro_original_text,
13821         expansion_obstack>: New member.
13822         (macro_original_text, expansion_obstack): Remove globals.
13823         (scan_macro_expansion, scanning_macro_expansion)
13824         (finished_macro_expansion): Update.
13825         (scan_macro_cleanup): Remove.
13826         (yylex, c_parse): Update.
13827
13828 2019-01-06  Tom Tromey  <tom@tromey.com>
13829
13830         * c-exp.y (struct c_parse_state) <strings>: New member.
13831         (operator_stoken): Update.
13832
13833 2019-01-06  Tom Tromey  <tom@tromey.com>
13834
13835         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13836         (union type_stack_elt) <typelist_val>: Now a pointer to
13837         std::vector.
13838         (type_stack_cleanup): Don't declare.
13839         (push_typelist): Update.
13840         * parse.c (pop_typelist): Return a std::vector.
13841         (push_typelist): Take a std::vector.
13842         (follow_types): Update.  Do not free args.
13843         (type_stack_cleanup): Remove.
13844         * c-exp.y (struct c_parse_state): New.
13845         (cpstate): New global.
13846         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13847         (nonempty_typelist): Update.
13848         (func_mod): Create a new vector.
13849         (c_parse): Create a c_parse_state.
13850         (check_parameter_typelist): Do not delete params.
13851         (function_method): Update.  Do not delete type_list.
13852
13853 2019-01-06  Tom Tromey  <tom@tromey.com>
13854
13855         PR gdb/28155:
13856         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13857         check_typedef.
13858         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13859         (print_return_value): Likewise.
13860
13861 2019-01-05  Tom Tromey  <tom@tromey.com>
13862
13863         * contrib/cleanup_check.py: Remove.
13864         * contrib/gcc-with-excheck: Remove.
13865         * contrib/exsummary.py: Remove.
13866         * contrib/excheck.py: Remove.
13867
13868 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13869
13870         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13871         NULL. Initialize tpprev to NULL instead of assigning it
13872         to NULL on the next statement.
13873         * windows-nat.c (windows_delete_thread): Remove check for
13874         main_thread_id before printing thread exit notifications.
13875         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13876         Remove thread ID check against main_thread_id.
13877         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13878         windows_delete_thread.
13879         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13880
13881 2019-01-04  Tom Tromey  <tom@tromey.com>
13882
13883         * compile/compile.c (_initialize_compile): Use upper case for
13884         metasyntactic variables.
13885         * symmisc.c (_initialize_symmisc): Use upper case for
13886         metasyntactic variables.
13887         * psymtab.c (_initialize_psymtab): Use upper case for
13888         metasyntactic variables.
13889         * demangle.c (demangle_command): Use upper case for metasyntactic
13890         variables.
13891         (_initialize_demangler): Likewise.
13892         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13893         variables.
13894
13895 2019-01-03  Tom Tromey  <tom@tromey.com>
13896
13897         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13898
13899 2019-01-03  Tom Tromey  <tom@tromey.com>
13900
13901         * python/py-symtab.c (salpy_str): Update.
13902         (struct salpy_sal_object) <symtab>: Now a PyObject.
13903         (salpy_dealloc): Update.
13904         (del_objfile_sal): Use gdbpy_ref.
13905
13906 2019-01-03  Tom Tromey  <tom@tromey.com>
13907
13908         * python/py-type.c (convert_field): Use new_reference.  Return
13909         gdbpy_ref.
13910         (make_fielditem): Return gdbpy_ref.
13911         (typy_fields): Update.
13912         (typy_getitem): Update.
13913         (field_name): Return gdbpy_ref.  Use new_reference.
13914         (typy_iterator_iternext): Update.
13915
13916 2019-01-03  Tom Tromey  <tom@tromey.com>
13917
13918         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13919
13920 2019-01-03  Tom Tromey  <tom@tromey.com>
13921
13922         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13923         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13924         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13925         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13926         (pspy_set_type_printers): Likewise.
13927         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13928         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13929         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13930         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13931         (objfpy_set_type_printers): Likewise.
13932
13933 2019-01-03  Tom Tromey  <tom@tromey.com>
13934
13935         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13936         (gdbpy_print_stack): Use gdbpy_err_fetch.
13937         * python/python-internal.h (class gdbpy_err_fetch): New class.
13938         (class gdbpy_enter) <m_error_type, m_error_value,
13939         m_error_traceback>: Remove.
13940         <m_error>: New member.
13941         (gdbpy_exception_to_string): Don't declare.
13942         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13943         * python/py-value.c (convert_value_from_python): Use
13944         gdbpy_err_fetch.
13945         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13946         gdbpy_exception_to_string.
13947         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13948         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13949         gdbpy_err_fetch.
13950
13951 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13952
13953         * linux-nat.c (delete_lwp_cleanup): Delete.
13954         (struct lwp_deleter): New struct.
13955         (lwp_info_up): New typedef.
13956         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13957         lwp_info_up.
13958
13959 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13960
13961         * linux-fork.c (class scoped_switch_fork_info): New class.
13962         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13963
13964 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13965
13966         * valops.c (find_overload_match): Remove use of null_cleanup, and
13967         calls to do_cleanups.
13968
13969 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13970
13971         * compile/compile-cplus-types.c
13972         (compile_cplus_instance::decl_name): Handle changes to
13973         cp_func_name.
13974         * cp-support.c (cp_func_name): Update header comment, update
13975         return type.
13976         * cp-support.h (cp_func_name): Update return type in declaration.
13977         * valops.c (find_overload_match): Move temp_func local to top
13978         level of function and change its type.  Use temp_func to hold and
13979         delete temporary string obtained from cp_func_name.
13980
13981 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13982
13983         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13984         gdb::char_vector, remove cleanup, and update uses of `msg`.
13985
13986 2019-01-03  Jim Wilson  <jimw@sifive.com>
13987
13988         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13989
13990 2019-01-02  Tom Tromey  <tom@tromey.com>
13991
13992         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13993         (tdesc_parse_xml): Remove cleanups.
13994         * target-descriptions.h (make_cleanup_free_target_description):
13995         Don't declare.
13996         (target_desc_deleter): New struct.
13997         (target_desc_up): New typedef.
13998         * target-descriptions.c (target_desc_deleter::operator()): Rename
13999         from free_target_description.
14000         (make_cleanup_free_target_description): Remove.
14001
14002 2019-01-02  Tom Tromey  <tom@tromey.com>
14003
14004         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14005         constructor, destructor.
14006         (linespec_parser): Remove typedef.
14007         (~linespec_parser): Rename from linespec_parser_delete.
14008         (linespec_lex_to_end, linespec_complete_label)
14009         (linespec_complete): Update.
14010         (decode_line_full): Remove cleanups.
14011         (decode_line_1): Update.
14012
14013 2019-01-02  Tom Tromey  <tom@tromey.com>
14014
14015         * python/python-internal.h (inferior_to_inferior_object): Change
14016         return type.
14017         * python/py-exitedevent.c (create_exited_event_object): Update.
14018         * python/py-inferior.c (inferior_to_inferior_object): Return
14019         gdbpy_ref.
14020         (python_new_inferior, python_inferior_deleted)
14021         (thread_to_thread_object, delete_thread_object)
14022         (build_inferior_list, gdbpy_selected_inferior): Update.
14023         * python/py-infthread.c (create_thread_object): Update.  Also fail
14024         if inferior_to_inferior_object fails.
14025
14026 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14027
14028         * inferior.h (class inferior) <displaced_step_state>: New field.
14029         * infrun.h (struct displaced_step_state): Move here from
14030         infrun.c.  Initialize fields, add constructor.
14031         <inf>: Remove field.
14032         <reset>: New method.
14033         * infrun.c (struct displaced_step_inferior_state): Move to
14034         infrun.h.
14035         (displaced_step_inferior_states): Remove.
14036         (get_displaced_stepping_state): Adust.
14037         (displaced_step_in_progress_any_inferior): Adjust.
14038         (displaced_step_in_progress_thread): Adjust.
14039         (displaced_step_in_progress): Adjust.
14040         (add_displaced_stepping_state): Remove.
14041         (get_displaced_step_closure_by_addr): Adjust.
14042         (remove_displaced_stepping_state): Remove.
14043         (infrun_inferior_exit): Call displaced_step_state.reset.
14044         (use_displaced_stepping): Don't check for NULL.
14045         (displaced_step_prepare_throw): Call
14046         get_displaced_stepping_state.
14047         (displaced_step_fixup): Don't check for NULL.
14048         (prepare_for_detach): Don't check for NULL.
14049
14050 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14051
14052         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14053          in case of call that did not complete.
14054
14055 2019-01-02  Andrey Utkin  <autkin@undo.io>
14056
14057         * symfile.c (find_separate_debug_file): Fix search of debug files for
14058         remote debuggee.
14059
14060 2019-01-02  Tom Tromey  <tom@tromey.com>
14061
14062         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14063         indentation.
14064         * python/py-frame.c (frapy_older): Remove cast.
14065         (frapy_newer): Likewise.
14066         * python/py-breakpoint.c (local_setattro): Remove cast.
14067         * python/py-arch.c (archpy_name): Remove local variable.
14068         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14069
14070 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14071
14072         * unittests/basic_string_view/element_access/char/empty.cc:
14073         Fix year range in copyright header.
14074
14075 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14076
14077         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14078         Delete.
14079         <operator==>: Update with for removed field.
14080         <hash>: Likewise.
14081         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14082         <isa_features>: ...this.
14083         <abi_features>: New field.
14084         (riscv_isa_flen): Update comment.
14085         (riscv_abi_xlen): New declaration.
14086         (riscv_abi_flen): New declaration.
14087         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14088         isa_features.
14089         (riscv_abi_xlen): New function.
14090         (riscv_isa_flen): Update to get answer from isa_features.
14091         (riscv_abi_flen): New function.
14092         (riscv_has_fp_abi): Update to get answer from abi_features.
14093         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14094         xlen and flen.
14095         (riscv_call_info) <xlen, flen>: Update comment.
14096         (riscv_call_arg_struct): Remove invalid assertions
14097         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14098         is removed.
14099         (riscv_gdbarch_init): Gather isa features and abi features
14100         separately, ensure both match on the gdbarch when reusing an old
14101         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14102         a target with 64-bit float hardware.
14103
14104 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14105
14106         * source.c (search_command_helper): Stop reverse search
14107         when line 1 has been searched.
14108
14109 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14110
14111         * record-full.c (record_full_base_target::close): Rewrite
14112         record_full_core_buf_list free logic.
14113
14114 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14115
14116         * break-catch-syscall.c (print_one_catch_syscall): xfree
14117         the last text.
14118
14119 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14120
14121         * top.c (print_gdb_version): Update Copyright year in version
14122         message.
14123
14124 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14125
14126         Update copyright year range in all GDB files.
14127
14128 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14129
14130         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14131
14132 For older changes see ChangeLog-2018.
14133 \f
14134 Local Variables:
14135 mode: change-log
14136 left-margin: 8
14137 fill-column: 74
14138 version-control: never
14139 coding: utf-8
14140 End:
14141