gdb/ChangeLog

   1 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   2
   3         * NEWS: Mention 'set|show print frame-info'.  Mention new
   4         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
   5         backtrace argument.  Mention that python frame filtering code
   6         is now consistent with what 'backtrace' command prints.
   7
   8 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
   9
  10         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
  11         comments.
  12         (print_frame_info_auto, print_frame_info_source_line,
  13         print_frame_info_location, print_frame_info_source_and_location,
  14         print_frame_info_location_and_address, print_frame_info_short_location):
  15         New declarations.
  16         (struct frame_print_options): New member print_frame_info.
  17         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
  18         * stack.h (get_user_print_what_frame_info): New declaration.
  19         (frame_show_address): New declaration.
  20         * stack.c (print_frame_arguments_choices): New value 'presence'.
  21         (print_frame_info_auto, print_frame_info_source_line,
  22         print_frame_info_location, print_frame_info_source_and_location,
  23         print_frame_info_location_and_address, print_frame_info_short_location,
  24         print_frame_info_choices, print_frame_info_print_what): New definitions.
  25         (print_frame_args): Only print dots for args if print frame-arguments
  26         is 'presence'.
  27         (frame_print_option_defs): New element for "frame-info".
  28         (get_user_print_what_frame_info): New function.
  29         (frame_show_address): Make non static.  Move comment to stack.h.
  30         (print_frame_info_to_print_what): New function.
  31         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
  32         to decide what to print.
  33         (backtrace_command_1): Handle the new print_frame_arguments_presence
  34         value.
  35         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
  36         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
  37         (py_print_frame): In non-mi mode, use LOCATION as default for
  38         print_what, similarly to frame information printed directly by
  39         backtrace command. Handle frame-info user option in non MI mode.
  40
  41 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  42
  43         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
  44         Add case for debugging 32-bit target on 64-bit host.  Revise
  45         comment.
  46
  47 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  48
  49         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
  50         instead of find_function_entry_range_from_pc.
  51
  52 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
  53
  54         * stack.c (find_frame_funname): Remove code which preferred
  55         minsym over symtab sym in "certain pathological cases".
  56
  57         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
  58         parameter.  Change type of "do_demangle" to bool.
  59         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  60         Pass suitable "prefer_sym_over_minsym" flag to
  61         build_address_symbolic().  Don't output "+" for negative offsets.
  62         * printcmd.c (print_address_symbolic): Update invocation of
  63         build_address_symbolic to include a "prefer_sym_over_minsym"
  64         flag.
  65         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
  66         Restrict cases in which use of minimal symbol is preferred to that
  67         of a found symbol.  Update comments.
  68
  69         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
  70         for entry pc when entry pc is out of range for that FDE.
  71
  72         * printcmd.c (print_address_symbolic): Print negative offsets.
  73         (build_address_symbolic): Force signed arithmetic when computing
  74         offset.
  75
  76 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
  77
  78         PR gdb/24839:
  79         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
  80         type.
  81
  82 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
  83
  84         * python/py-objfile.c (add_separate_debug_file): Fix comment about
  85         this function's Python signature.
  86
  87
  88 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
  89
  90         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
  91         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  92         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
  93         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
  94         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
  95
  96
  97 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
  98
  99         * h8300-tdep.c (h8300_register_name_common): New.
 100         h8300_register_name): Use h8300_register_name_common.
 101         (h8300s_register_name): Likewise.
 102         (h8300sx_register_name): Likewise.
 103         (h8300h_register_nam): New.
 104         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
 105
 106
 107 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
 108
 109         * arm-tdep.c (arm_skip_cmse_entry): New function.
 110         (arm_is_sgstubs_section): New function.
 111         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
 112
 113 2019-07-22  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
 116         Don't self-assign.
 117
 118 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 119
 120         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
 121         type_print.
 122
 123 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 124
 125         * symtab.c (search_symbols): Adjust msymbol matching type arrays
 126         so that GDB doesn't match any msymbols when searching in the
 127         TYPES_DOMAIN.
 128         (print_symbol_info): Print using typedef_print or type_print based
 129         on the type of the symbol.  Add updated FIXME comment moved from...
 130         (_initialize_symtab): ... move and update FIXME comment to above.
 131
 132 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 133
 134         * NEWS: Mention adding -q option to "info types".
 135         * symtab.c (struct info_types_options): New struct.
 136         (info_types_options_defs): New variable.
 137         (make_info_types_options_def_group): New function.
 138         (info_types_command): Use gdb::option framework to parse options.
 139         (info_types_command_completer): New function.
 140         (_initialize_symtab): Extend the help text on "info types" and
 141         register command completer.
 142
 143 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
 144
 145         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
 146         (lookup_symbol_in_objfile): Change int to block_enum and add a
 147         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
 148
 149 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
 150
 151         * MAINTAINERS (Write After Approval): Add self.
 152
 153 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
 154
 155         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
 156         instruction to the dummy code region.
 157
 158 2019-07-19  Tom Tromey  <tromey@adacore.com>
 159
 160         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
 161         (ARGSUSED, PARAMS, __func__): Remove rules.
 162
 163 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 164
 165         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
 166         * features/arm/arm-with-iwmmxt.c: Remove.
 167         * features/arm/arm-with-iwmmxt.xml: Remove.
 168         * features/arm/arm-with-m-fpa-layout.c: Remove.
 169         * features/arm/arm-with-m-fpa-layout.xml: Remove.
 170         * features/arm/arm-with-m-vfp-d16.c: Remove.
 171         * features/arm/arm-with-m-vfp-d16.xml: Remove.
 172         * features/arm/arm-with-m.c: Remove.
 173         * features/arm/arm-with-m.xml: Remove.
 174         * features/arm/arm-with-neon.c: Remove.
 175         * features/arm/arm-with-neon.xml: Remove.
 176         * features/arm/arm-with-vfpv2.c: Remove.
 177         * features/arm/arm-with-vfpv2.xml: Remove.
 178         * features/arm/arm-with-vfpv3.c: Remove.
 179         * features/arm/arm-with-vfpv3.xml: Remove.
 180
 181 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 182
 183         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
 184
 185 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 186
 187         * arch/aarch32.c (aarch32_create_target_description): Create
 188         target descriptions using features.
 189         * arch/arm.c (arm_create_target_description)
 190         (arm_create_mprofile_target_description): Likewise.
 191         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
 192
 193 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
 194
 195         * Makefile.in: Add new files.
 196         * aarch32-tdep.c: New file.
 197         * aarch32-tdep.h: New file.
 198         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
 199         Call aarch32_read_description.
 200         * arch/aarch32.c: New file.
 201         * arch/aarch32.h: New file.
 202         * arch/arm.c (arm_create_target_description)
 203         (arm_create_mprofile_target_description): New function.
 204         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
 205         (arm_create_target_description)
 206         (arm_create_mprofile_target_description): New declaration.
 207         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
 208         read_description functions.
 209         * arm-linux-nat.c (arm_linux_nat_target::read_description):
 210         Likewise.
 211         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
 212         * arm-tdep.c (tdesc_arm_list): New variable.
 213         (arm_register_g_packet_guesses): Call create description functions.
 214         (arm_read_description) (arm_read_mprofile_description): New
 215         function.
 216         * arm-tdep.h (arm_read_description)
 217         (arm_read_mprofile_description): Add declaration.
 218         * configure.tgt: Add new files.
 219
 220 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
 221
 222         * top.c (new_ui_command): Open specified terminal just once.
 223
 224 2019-07-18  Tom Tromey  <tromey@adacore.com>
 225
 226         * symtab.c (main_name): Constify return type.
 227         * symfile.c (set_initial_language): Update.
 228         * symtab.h (main_name): Constify return type.
 229
 230 2019-07-17  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui-winsource.c (tui_update_source_window)
 233         (tui_update_source_window_as_is)
 234         (tui_update_source_windows_with_line): Remove return.
 235         * tui/tui-disasm.c (tui_show_disassem)
 236         (tui_show_disassem_and_update_source): Remove return.
 237         * tui/tui.c (tui_reset): Remove return.
 238         * tui/tui-wingeneral.c
 239         (tui_check_and_display_highlight_if_needed): Remove return.
 240
 241 2019-07-17  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
 244
 245 2019-07-17  Tom Tromey  <tom@tromey.com>
 246
 247         * tui/tui-winsource.h (struct tui_exec_info_window)
 248         (struct tui_source_window_base): Move from tui-data.h.
 249         * tui/tui-winsource.c: Move many method definitions from
 250         elsewhere.  Remove "structuring" comments.
 251         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
 252         (tui_source_window_base::refresh_window): Move to
 253         tui-winsource.c.
 254         * tui/tui-win.c (tui_source_window_base::refresh_all)
 255         (tui_source_window_base::update_tab_width)
 256         (tui_source_window_base::set_new_height)
 257         (tui_source_window_base::do_make_visible_with_new_height): Move to
 258         tui-winsource.c.
 259         * tui/tui-source.h: Update.
 260         * tui/tui-source.c (tui_source_window_base::reset): Move to
 261         tui-winsource.c.
 262         * tui/tui-disasm.h: Update.
 263         * tui/tui-data.h (struct tui_exec_info_window): Move to
 264         tui-winsource.h.
 265         (struct tui_source_window_base): Likewise.
 266         * tui/tui-data.c (tui_source_window_base::clear_detail)
 267         (tui_source_window_base, ~tui_source_window_base): Move to
 268         tui-winsource.c.
 269
 270 2019-07-17  Tom Tromey  <tom@tromey.com>
 271
 272         * tui/tui-win.c (tui_resize_all)
 273         (tui_source_window_base::update_tab_width)
 274         (tui_adjust_win_heights): Update.
 275         (tui_win_info::make_invisible_and_set_new_height): Rename from
 276         make_invisible_and_set_new_height.
 277         * tui/tui-data.h (struct tui_win_info)
 278         <make_invisible_and_set_new_height>: New method.
 279
 280 2019-07-17  Tom Tromey  <tom@tromey.com>
 281
 282         * tui/tui.c: Update.
 283         * tui/tui-source.h (struct tui_source_window): Move from
 284         tui-data.h.
 285         * tui/tui-layout.c: Update.
 286         * tui/tui-disasm.c: Update.
 287         * tui/tui-data.h (struct tui_source_window): Move to
 288         tui-source.h.
 289
 290 2019-07-17  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-disasm.h (struct tui_disasm_window): Move from
 293         tui-data.h.
 294         * tui/tui-data.h (struct tui_disasm_window): Move to
 295         tui-disasm.h.
 296
 297 2019-07-17  Tom Tromey  <tom@tromey.com>
 298
 299         * tui/tui-regs.h (struct tui_data_item_window): Move from
 300         tui-data.h.
 301         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
 302         * tui/tui-data.h (struct tui_data_item_window): Move to
 303         tui-regs.h.
 304         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
 305
 306 2019-07-17  Tom Tromey  <tom@tromey.com>
 307
 308         * tui/tui.c: Update.
 309         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
 310         (tui_cmd_window::max_height): Move to tui-command.c.
 311         * tui/tui-layout.c: Update.
 312         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
 313         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
 314         tui-command.c.
 315         * tui/tui-command.h (struct tui_cmd_window): Move from
 316         tui-data.h.
 317         * tui/tui-command.c: Remove "structuring" comments.
 318         (tui_cmd_window::clear_detail)
 319         (tui_cmd_window::do_make_visible_with_new_height)
 320         (tui_cmd_window::max_height): Move from elsewhere.
 321
 322 2019-07-17  Tom Tromey  <tom@tromey.com>
 323
 324         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
 325         Now static.
 326         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
 327         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
 328
 329 2019-07-17  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui.c: Update.
 332         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
 333         tui-regs.c.
 334         * tui/tui-windata.h: Remove file.
 335         * tui/tui-windata.c: Remove file.
 336         * tui/tui-win.c (tui_data_window::set_new_height)
 337         (tui_data_window::do_make_visible_with_new_height): Move to
 338         tui-regs.c.
 339         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
 340         * tui/tui-regs.c: Remove "structuring" comments.
 341         (tui_data_window::first_data_item_displayed)
 342         (tui_data_window::delete_data_content_windows)
 343         (tui_data_window::erase_data_content)
 344         (tui_data_window::display_all_data)
 345         (tui_data_window::refresh_all)
 346         (tui_data_window::do_scroll_vertical)
 347         (tui_data_window::clear_detail, tui_data_window::set_new_height)
 348         (tui_data_window::do_make_visible_with_new_height)
 349         (tui_data_window::refresh_window): Move from elsewhere.
 350         (_initialize_tui_regs): Move to end of file.
 351         * tui/tui-layout.c: Update.
 352         * tui/tui-hooks.c: Update.
 353         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
 354         * tui/tui-data.c (tui_data_window::clear_detail): Move to
 355         tui-regs.c.
 356         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
 357
 358 2019-07-17  Tom Tromey  <tom@tromey.com>
 359
 360         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
 361         seen.
 362
 363 2019-07-17  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-win.c (tui_source_window_base::set_new_height)
 366         (tui_source_window_base::do_make_visible_with_new_height): Use
 367         m_has_locator field directly.
 368         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
 369         method.
 370         (struct tui_source_window_base) <has_locator>: Likewise.
 371
 372 2019-07-17  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
 375         Don't declare.
 376         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
 377         Remove.
 378         * tui/tui-win.c (tui_source_window_base::set_new_height)
 379         (tui_source_window_base::set_new_height)
 380         (make_invisible_and_set_new_height)
 381         (tui_source_window_base::do_make_visible_with_new_height)
 382         (tui_source_window_base::do_make_visible_with_new_height):
 383         Update.
 384         * tui/tui-layout.c (show_source_disasm_command, show_data)
 385         (show_source_or_disasm_and_command): Update.
 386         * tui/tui-layout.c (show_layout): Update.
 387
 388 2019-07-17  Tom Tromey  <tom@tromey.com>
 389
 390         * tui/tui-layout.c (make_data_window): Remove.
 391         (show_data): Unify creation and re-initialization cases.
 392
 393 2019-07-17  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-layout.c (make_source_window, make_disasm_window):
 396         Remove.
 397         (show_data): Unify creation and re-initialization cases.
 398
 399 2019-07-17  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-layout.c (make_command_window): Remove.
 402         (show_source_disasm_command, show_source_or_disasm_and_command):
 403         Unify creation and re-initialization cases.
 404
 405 2019-07-17  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
 408         creation and re-initialization cases.
 409
 410 2019-07-17  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-regs.c (tui_get_register): Return void.
 413
 414 2019-07-17  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
 417         Simplify.
 418
 419 2019-07-17  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-layout.c (show_source_disasm_command): Simplify window
 422         resetting.
 423
 424 2019-07-17  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui.h (tui_set_layout_by_name): Don't declare.
 427         * tui/tui-regs.c (tui_reg_layout): New function.
 428         (tui_show_registers, tui_reg_command): Use it.
 429         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
 430         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
 431         parameters.
 432         (tui_layout_command): Remove.
 433
 434 2019-07-17  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-layout.h (tui/tui-layout): Return void.
 437         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
 438
 439 2019-07-17  Tom Tromey  <tom@tromey.com>
 440
 441         * tui/tui-layout.c (show_source_disasm_command, show_data):
 442         Update.
 443         (reset_locator): Remove.
 444         (show_source_or_disasm_and_command): Update.
 445
 446 2019-07-17  Tom Tromey  <tom@tromey.com>
 447
 448         * tui/tui-source.c (tui_source_window_base::reset): Remove
 449         win_type parameter.
 450         * tui/tui-layout.c (make_command_window, make_source_window)
 451         (make_disasm_window, make_data_window)
 452         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
 453         (reset_locator, show_source_or_disasm_and_command): Update.
 454         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
 455         win_type parameter.
 456         (struct tui_source_window_base) <reset>: Likewise.
 457
 458 2019-07-17  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-layout.c (show_source_disasm_command): Use
 461         reset_locator.
 462         (reset_locator): New function.
 463         (init_and_make_win): Remove.
 464         (show_source_or_disasm_and_command): Use reset_locator.
 465
 466 2019-07-17  Tom Tromey  <tom@tromey.com>
 467
 468         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
 469         condition.
 470         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
 471         Remove condition.
 472         * tui/tui-source.c (tui_source_window_base::reset): New method.
 473         * tui/tui-layout.c (make_command_window): Don't call
 474         init_and_make_win.
 475         (make_source_window, make_disasm_window): Don't call
 476         make_source_or_disasm_window.
 477         (make_data_window): Don't call init_and_make_win.  Change calling
 478         convention.
 479         (show_source_disasm_command, show_data): Simplify.
 480         (make_source_or_disasm_window): Remove.
 481         (show_source_or_disasm_and_command): Simplify.
 482         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
 483         (struct tui_source_window_base) <reset>: Likewise.
 484         <execution_info>: Remove initializer.
 485         * tui/tui-data.c (tui_source_window_base): Initialize
 486         execution_info.
 487
 488 2019-07-17  Tom Tromey  <tom@tromey.com>
 489
 490         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
 491         variable.
 492
 493 2019-07-17  Tom Tromey  <tom@tromey.com>
 494
 495         * tui/tui.c (tui_rl_other_window): Update.
 496         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
 497         superclass method first.  Always iterate over regs_content.
 498         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
 499         method.
 500         * tui/tui-win.c (tui_set_focus_command): Update.
 501
 502 2019-07-17  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-win.c (tui_set_focus_command): Rename from
 505         tui_set_focus.  Call tui_enable.
 506         (tui_set_focus_command): Remove.
 507
 508 2019-07-17  Tom Tromey  <tom@tromey.com>
 509
 510         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
 511         refresh_window.
 512         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
 513         touchwin.
 514         (tui_data_window::refresh_window): Call refresh_window on data
 515         items.  Always call superclass refresh_window.
 516         (tui_win_info::refresh): Remove.
 517         (tui_source_window_base::refresh_window): Update.
 518         (tui_refresh_all): Update.
 519         * tui/tui-layout.c (show_source_disasm_command): Remove call to
 520         refresh_window.
 521         (show_source_or_disasm_and_command): Likewise.
 522         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
 523         (struct tui_source_window_base) <refresh>: Likewise.
 524
 525 2019-07-17  Tom Tromey  <tom@tromey.com>
 526
 527         * tui/tui-winsource.c (tui_clear_source_content)
 528         (tui_show_source_content): Update.
 529         * tui/tui-source.c (tui_source_window::showing_source_p): Check
 530         whether content is empty.
 531         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
 532         Remove.
 533
 534 2019-07-17  Tom Tromey  <tom@tromey.com>
 535
 536         * tui/tui-winsource.c (tui_erase_source_content): Clear the
 537         window's contents.
 538         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
 539         * tui/tui-source.c (tui_set_source_content_nil): Remove.
 540
 541 2019-07-17  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
 544         (struct tui_data_item_window): Update.
 545
 546 2019-07-17  Tom Tromey  <tom@tromey.com>
 547
 548         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
 549         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
 550         defines.
 551
 552 2019-07-17  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-winsource.h (tui_erase_source_content)
 555         (tui_clear_source_content): Remove "display_prompt" parameter.
 556         * tui/tui-winsource.c (tui_update_source_window_as_is)
 557         (tui_update_source_windows_with_addr): Update.
 558         (tui_clear_source_content): Remove "display_prompt" parameter.
 559         (tui_erase_source_content): Likewise.  Simplify.
 560         (tui_show_source_content): Update.
 561         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 562         * tui/tui-stack.c (tui_show_frame_info): Update.
 563         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
 564         Remove defines.
 565
 566 2019-07-17  Tom Tromey  <tom@tromey.com>
 567
 568         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 569         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
 570         parameter.
 571         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
 572         parameter.
 573
 574 2019-07-17  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-winsource.c (tui_clear_source_content)
 577         (tui_show_source_content, tui_show_exec_info_content)
 578         (tui_clear_exec_info_content): Update.
 579         * tui/tui-stack.c (tui_show_locator_content): Update.
 580         (tui_show_frame_info): Update.
 581         * tui/tui-source.h (tui_source_window): Don't declare.
 582         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
 583         from tui_source_is_displayed.
 584         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
 585         Remove field.
 586         (struct tui_source_window_base) <content_in_use>: New field.  Now
 587         bool.
 588         (struct tui_source_window) <showing_source_p>: New method.
 589         (TUI_SRC_WIN): Change cast.
 590         * tui/tui-data.c (tui_initialize_static_data): Update.
 591
 592 2019-07-17  Tom Tromey  <tom@tromey.com>
 593
 594         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
 595         location_matches_p.
 596         * tui/tui-source.c (tui_source_window::location_matches_p): New
 597         method.
 598         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
 599         method.
 600         * tui/tui-data.h (struct tui_source_window_base)
 601         <location_matches_p>: New method.
 602         (struct tui_source_window, struct tui_disasm_window)
 603         <location_matches_p>: Likewise.
 604
 605 2019-07-17  Tom Tromey  <tom@tromey.com>
 606
 607         * tui/tui-win.c (tui_set_win_height_command): Rename from
 608         tui_set_win_height.
 609         (tui_set_win_height_command): Remove.
 610
 611 2019-07-17  Tom Tromey  <tom@tromey.com>
 612
 613         * tui/tui-source.c (tui_source_window): New constructor.  Add
 614         observer.
 615         (~tui_source_window): New destructor.
 616         (tui_source_window::style_changed): New method.
 617         * tui/tui-hooks.c (tui_redisplay_source): Remove.
 618         (tui_attach_detach_observers): Update.
 619         * tui/tui-data.h (struct tui_source_window): Make constructor not
 620         inline.  Add destructor.
 621         (struct tui_source_window) <style_changed>: New method.
 622         <m_observable>: New member.
 623
 624 2019-07-17  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
 627         * tui/tui-win.c (tui_resize_all): Fix typo.
 628
 629 2019-07-17  Tom Tromey  <tom@tromey.com>
 630
 631         * tui/tui-wingeneral.h (tui_refresh_all): Update.
 632         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
 633         (tui_refresh_all): Remove "list" parameter.  Use foreach.
 634         * tui/tui-win.c (window_name_completer): Use foreach.
 635         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
 636         (update_tab_width): Likewise.
 637         * tui/tui-layout.c (show_layout): Update.
 638         * tui/tui-data.h (class tui_window_iterator): New.
 639         (struct all_tui_windows): New.
 640         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
 641
 642 2019-07-17  Tom Tromey  <tom@tromey.com>
 643
 644         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
 645         parameter.  Don't reference globals.
 646         (tui_reg_command): Update.
 647
 648 2019-07-17  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-regs.c (tui_show_registers): Simplify.
 651
 652 2019-07-17  Tom Tromey  <tom@tromey.com>
 653
 654         * tui/tui-regs.c (tui_show_registers): Update.
 655         (tui_show_register_group): Add win_info parameter.
 656
 657 2019-07-17  Tom Tromey  <tom@tromey.com>
 658
 659         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
 660         Rename from tui_display_reg_element_at_line.
 661         (tui_data_window::display_registers_from_line): Update.
 662         * tui/tui-data.h (struct tui_data_window)
 663         <display_reg_element_at_line>: New method.
 664
 665 2019-07-17  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-regs.h (tui_display_registers_from)
 668         (tui_display_registers_from_line): Don't declare.
 669         * tui/tui-windata.c (tui_data_window::display_all_data)
 670         (tui_data_window::refresh_all)
 671         (tui_data_window::do_scroll_vertical): Update.
 672         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
 673         from tui_display_registers_from.
 674         (tui_display_reg_element_at_line): Update.
 675         (tui_data_window::display_registers_from_line): Rename from
 676         tui_display_registers_from_line.
 677         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
 678         display_registers_from_line>: New methods.
 679
 680 2019-07-17  Tom Tromey  <tom@tromey.com>
 681
 682         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
 683         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
 684         from tui_erase_data_content.
 685         (tui_data_window::display_all_data)
 686         (tui_data_window::refresh_all)
 687         (tui_data_window::do_scroll_vertical): Update.
 688         * tui/tui-regs.c (tui_show_registers): Update.
 689         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
 690         New method.
 691
 692 2019-07-17  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
 695         declare.
 696         * tui/tui-windata.c
 697         (tui_data_window::delete_data_content_windows): Rename from
 698         tui_delete_data_content_windows.
 699         (tui_data_window::display_all_data)
 700         (tui_data_window::do_scroll_vertical): Update.
 701         * tui/tui-data.h (struct tui_data_window)
 702         <delete_data_content_windows>: New method.
 703
 704 2019-07-17  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
 707         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
 708
 709 2019-07-17  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-windata.h (tui_display_all_data): Don't declare.
 712         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
 713         from tui_display_all_data.
 714         * tui/tui-win.c
 715         (tui_data_window::do_make_visible_with_new_height): Update.
 716         * tui/tui-regs.c (tui_show_registers): Update.
 717         * tui/tui-layout.c (tui_set_layout): Update.
 718         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
 719         method.
 720
 721 2019-07-17  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-windata.h (tui_display_data_from): Don't declare.
 724         * tui/tui-windata.c (tui_display_data_from): Remove.
 725         (tui_data_window::refresh_all): Update.
 726
 727 2019-07-17  Tom Tromey  <tom@tromey.com>
 728
 729         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
 730         * tui/tui-windata.c (tui_display_data_from_line): Remove.
 731         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
 732         tui_display_registers_from_line.
 733         * tui/tui-regs.h (tui_display_registers_from_line): Update.
 734         * tui/tui-regs.c (tui_display_registers_from_line): Remove
 735         "force_display" parameter.
 736
 737 2019-07-17  Tom Tromey  <tom@tromey.com>
 738
 739         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
 740         declare.
 741         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
 742         Rename from tui_first_reg_element_no_inline.
 743         (tui_display_reg_element_at_line)
 744         (tui_display_registers_from_line): Update.
 745         * tui/tui-data.h (struct tui_data_window)
 746         <first_reg_element_no_inline>: New method.
 747
 748 2019-07-17  Tom Tromey  <tom@tromey.com>
 749
 750         * tui/tui-windata.c (tui_display_data_from)
 751         (tui_data_window::do_scroll_vertical): Update.
 752         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
 753         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
 754         Rename from tui_line_from_reg_element_no.
 755         (tui_display_registers_from_line): Update.
 756         * tui/tui-data.h (struct tui_data_window)
 757         <line_from_reg_element_no>: New method.
 758
 759 2019-07-17  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
 762         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
 763         tui_last_regs_line_no.
 764         (tui_display_reg_element_at_line)
 765         (tui_display_registers_from_line): Update.
 766         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
 767         method.
 768
 769 2019-07-17  Tom Tromey  <tom@tromey.com>
 770
 771         PR tui/24722:
 772         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
 773         (tui_update_breakpoint_info): Add "being_deleted" parameter.
 774         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
 775         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
 776         (tui_update_breakpoint_info): Likewise.
 777         * tui/tui-hooks.c (tui_event_create_breakpoint)
 778         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
 779         Update.
 780
 781 2019-07-17  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
 784
 785 2019-07-17  Tom Tromey  <tom@tromey.com>
 786
 787         * tui/tui-winsource.c (tui_update_source_window_as_is)
 788         (tui_update_source_windows_with_addr): Update.
 789         * tui/tui-source.h (tui_set_source_content)
 790         (tui_show_symtab_source): Add "win_info" parameter.
 791         * tui/tui-source.c (tui_set_source_content): Add "win_info"
 792         parameter.
 793         (tui_show_symtab_source): Likewise.
 794
 795 2019-07-17  Tom Tromey  <tom@tromey.com>
 796
 797         * tui/tui-wingeneral.c
 798         (tui_check_and_display_highlight_if_needed): Check can_highlight.
 799
 800 2019-07-17  Tom Tromey  <tom@tromey.com>
 801
 802         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
 803         (struct tui_cmd_window) <can_scroll>: New method.
 804         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
 805         method.
 806
 807 2019-07-17  Tom Tromey  <tromey@adacore.com>
 808
 809         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
 810         do_field_signed>: Rename.  Change type of "value".
 811         * ui-out.c (ui_out::field_signed): Rename from field_int.
 812         Change type of "value".
 813         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
 814         type of "value".
 815         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
 816         do_field_int.  Change type of "value".
 817         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
 818         do_field_int.  Change type of "value".
 819         * tracepoint.c (trace_status_mi, tfind_1)
 820         (print_one_static_tracepoint_marker): Update.
 821         * thread.c (print_thread_info_1, print_selected_thread_frame):
 822         Update.
 823         * stack.c (print_frame, print_frame_info): Update.
 824         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
 825         Update.
 826         * source.c (print_source_lines_base): Update.
 827         * skip.c (info_skip_command): Update.
 828         * record-btrace.c (btrace_ui_out_decode_error)
 829         (btrace_call_history_src_line): Update.
 830         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
 831         Update.
 832         * progspace.c (print_program_space): Update.
 833         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
 834         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
 835         do_field_int.  Change type of "value".
 836         * mi/mi-out.c (mi_ui_out::do_table_begin)
 837         (mi_ui_out::do_table_header): Update.
 838         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
 839         type of "value".
 840         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
 841         (mi_cmd_data_list_changed_registers, output_register)
 842         (mi_cmd_data_read_memory, mi_load_progress)
 843         (mi_cmd_trace_frame_collected): Update.
 844         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
 845         Update.
 846         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
 847         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
 848         (mi_cmd_var_list_children, varobj_update_one): Update.
 849         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
 850         (mi_cmd_stack_list_args, list_arg_or_local): Update.
 851         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
 852         * inferior.c (print_inferior): Update.
 853         * gdb_bfd.c (print_one_bfd): Update.
 854         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 855         Update.
 856         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
 857         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
 858         do_field_int.  Change type of "value".
 859         * cli-out.c (cli_ui_out::do_field_signed): Rename from
 860         do_field_int.  Change type of "value".
 861         * breakpoint.c (watchpoint_check, print_breakpoint_location)
 862         (print_one_breakpoint_location, print_it_catch_fork)
 863         (print_one_catch_fork, print_it_catch_vfork)
 864         (print_one_catch_vfork, print_it_catch_solib)
 865         (print_it_catch_exec, print_it_ranged_breakpoint)
 866         (print_mention_watchpoint, print_mention_masked_watchpoint)
 867         (bkpt_print_it, update_static_tracepoint): Update.
 868         * break-catch-throw.c (print_it_exception_catchpoint): Update.
 869         * break-catch-syscall.c (print_it_catch_syscall): Update.
 870         * ada-tasks.c (print_ada_task_info): Update.
 871         * ada-lang.c (print_it_exception, print_mention_exception):
 872         Update.
 873
 874 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 875
 876         PR breakpoints/24541
 877         * gdbarch.c: Regenerate.
 878         * gdbarch.h: Regenerate.
 879         * gdbarch.sh: Adjust return type and parameter types for
 880         'stap_adjust_register'.
 881         (i386_stap_adjust_register): Adjust signature and return new
 882         register name.
 883         * stap-probe.c (stap_parse_register_operand): Adjust use of
 884         'gdbarch_stap_adjust_register'.
 885
 886 2019-07-17  Tom Tromey  <tromey@adacore.com>
 887
 888         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
 889         declare VEC.
 890         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
 891         std::vector.
 892         (struct s390_process_info): Add initializers.
 893         (s390_add_process): Use new.
 894         (s390_linux_nat_target::low_forget_process): Use delete.
 895         (s390_linux_nat_target::low_new_fork)
 896         (s390_linux_nat_target::stopped_by_watchpoint)
 897         (s390_linux_nat_target::low_prepare_to_resume)
 898         (s390_linux_nat_target::insert_watchpoint)
 899         (s390_linux_nat_target::insert_hw_breakpoint)
 900         (s390_linux_nat_target::remove_watchpoint)
 901         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 902
 903 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 904
 905         * aarch64-fbsd-nat.c: Include regcache.h.
 906         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 907         argument.
 908         (aarch64_fbsd_nat_target::fetch_registers)
 909         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 910         variable.
 911         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 912
 913 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 914
 915         * fbsd-nat.c: Include gdbarch.h.
 916
 917 2019-07-15  Tom Tromey  <tromey@adacore.com>
 918
 919         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 920
 921 2019-07-15  Tom Tromey  <tromey@adacore.com>
 922
 923         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 924         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 925         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 926         * cli-out.c (cli_ui_out::do_field_int): New method.
 927         * ui-out.c (ui_out::field_unsigned): New method.
 928         * symfile.c (generic_load): Use field_unsigned.
 929         (print_transfer_performance): Likewise.
 930         * record-btrace.c (ui_out_field_uint): Remove.
 931         (btrace_call_history_insn_range, btrace_call_history): Use
 932         field_unsigned.
 933         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 934         field_unsigned.
 935         * ui-out.h (class ui_out) <field_unsigned>: New method.
 936         <do_field_unsigned>: Likewise.
 937
 938 2019-07-15  Tom Tromey  <tromey@adacore.com>
 939
 940         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 941         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 942         * target.c (flash_erase_command): Use field_string.
 943         * infrun.c (print_signal_received_reason): Use field_string.
 944         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 945         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 946         field_string.
 947         * ada-tasks.c (print_ada_task_info): Use field_string.
 948
 949 2019-07-15  Tom Tromey  <tromey@adacore.com>
 950
 951         * target.c (flash_erase_command): Use field_core_addr.
 952         * symfile.c (generic_load): Use field_core_addr.
 953         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 954         Use field_core_addr.
 955         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 956         field_core_addr.
 957
 958 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 961         value if its desired type is smaller than a CORE_ADDR and signed.
 962
 963 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 964
 965         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 966         of changes to field names, and use new is_reference field to
 967         decide if a property is a reference or not.
 968         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 969         field.
 970         (struct dwarf2_property_baton): Update header comment, rename
 971         'referenced_type' to 'property_type' and update comments.
 972         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 973         default property type, store in property baton, update to take
 974         accound of renamed field.
 975         (read_func_scope): Update call to attr_to_dynamic_prop.
 976         (read_array_type): Likewise.
 977         (dwarf2_per_cu_addr_sized_int_type): New function.
 978         (read_subrange_index_type): Move type finding code to
 979         dwarf2_per_cu_addr_sized_int_type.
 980         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 981         (dwarf2_per_cu_addr_type): New function.
 982         (set_die_type): Update calls to attr_to_dynamic_prop.
 983
 984 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 985
 986         * dwarf2read.c (read_subrange_index_type): New function.
 987         (read_subrange_type): Move code into new function and call it.
 988         * gdbtypes.c (create_range_type): Add some asserts.
 989
 990 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 991
 992         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 993         update return statements.
 994         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 995         declaration, and update comment to match.
 996         * gdbtypes.c (resolve_dynamic_array): Update call to
 997         dwarf2_evaluate_property to match new return type.
 998
 999 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1000
1001         * valarith.c (value_subscripted_rvalue): Change lowerbound
1002         parameter type from int to LONGEST.
1003         * value.h (value_subscripted_rvalue): Likewise in declaration.
1004
1005 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1006
1007         * cli/cli-utils.c (info_print_command_completer): New function.
1008         * cli/cli-utils.h: Add 'completer.h' include, and forward
1009         declaration for 'struct cmd_list_element'.
1010         (info_print_command_completer): Declare.
1011         * stack.c (_initialize_stack): Add completer for 'info locals' and
1012         'info args'.
1013         * symtab.c (_initialize_symtab): Add completer for 'info
1014         variables' and 'info functions'.
1015         * NEWS: Mention completion for additional info commands.
1016
1017 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * cli/cli-utils.c (extract_info_print_args): Delete.
1020         (extract_arg_maybe_quoted): Delete.
1021         (info_print_options_defs): New variable.
1022         (make_info_print_options_def_group): New function.
1023         (extract_info_print_options): Define new function.
1024         * cli/cli-utils.h (extract_info_print_args): Delete.
1025         (struct info_print_options): New structure.
1026         (extract_info_print_options): Declare new function.
1027         * stack.c (info_locals_command): Update to use new
1028         extract_info_print_options, also add a header comment.
1029         (info_args_command): Likewise.
1030         * symtab.c (info_variables_command): Likewise.
1031         (info_functions_command): Likewise.
1032
1033 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1034
1035         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
1036         to extract string arguments.
1037         * common/common-utils.c (extract_string_maybe_quoted): New function.
1038         * common/common-utils.h (extract_string_maybe_quoted): Declare.
1039
1040 2019-07-11  Tom Tromey  <tromey@adacore.com>
1041
1042         * main.c (get_init_files): Use GDBINIT, not gdbinit.
1043         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
1044         * top.h (gdbinit): Don't declare.
1045         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
1046         into...
1047         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
1048         * top.c (gdb_init): Don't call init_cli_cmds.
1049         (gdbinit): Remove.
1050         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
1051
1052 2019-07-11  Tom Tromey  <tromey@adacore.com>
1053
1054         * python/py-inferior.c (add_thread_object): Don't use thread_obj
1055         after it has been moved.
1056
1057 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1058
1059         * valops.c (value_must_coerce_to_target): Change return type to
1060         bool.
1061         * value.h (value_must_coerce_to_target): Likewise.
1062
1063 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
1064
1065         * breakpoint.c (is_hardware_watchpoint): Remove
1066         forward-declaration.
1067         (is_masked_watchpoint): Change return type to bool.
1068         (is_tracepoint): Likewise.
1069         (is_breakpoint): Likewise.
1070         (is_hardware_watchpoint): Likewise.
1071         (is_watchpoint): Likewise.
1072         (is_no_memory_software_watchpoint): Likewise.
1073         (is_catchpoint): Likewise.
1074         (breakpoint_1): Make FILTER parameter's return type bool.
1075         is_masked_watchpoint): Change return type to bool.
1076         (save_breakpoints): Make FILTER parameter's return type bool.
1077         * breakpoint.h (is_breakpoint): Change return type to bool.
1078         (is_watchpoint): Likewise.
1079         (is_catchpoint): Likewise.
1080         (is_tracepoint): Likewise.
1081
1082 2019-07-10  Tom Tromey  <tom@tromey.com>
1083
1084         * defs.h: Don't include gdbarch.h.
1085         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
1086         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
1087         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
1088         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
1089         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
1090         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
1091         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
1092         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
1093         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
1094         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
1095         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
1096         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
1097         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
1098         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
1099         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
1100         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
1101         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
1102         record-btrace.c, record.h, regcache-dump.c, regcache.h,
1103         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
1104         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
1105         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
1106         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
1107         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
1108         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
1109         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
1110         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
1111         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
1112
1113 2019-07-10  Tom Tromey  <tromey@adacore.com>
1114
1115         * ada-lang.h (is_ada_exception_catchpoint): Declare.
1116         * breakpoint.c (init_ada_exception_breakpoint): Register as
1117         bp_catchpoint.
1118         (print_one_breakpoint_location, print_one_breakpoint): Use
1119         is_ada_exception_catchpoint.
1120         * ada-lang.c (class ada_catchpoint_location): Pass
1121         bp_loc_software_breakpoint to bp_location constructor.
1122         (is_ada_exception_catchpoint): New function.
1123
1124 2019-07-10  Tom Tromey  <tromey@adacore.com>
1125
1126         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
1127         VEC.
1128         (struct arm_exidx_entry): New method operator<.
1129         (struct arm_exidx_data) <section_maps>: Change type.
1130         (arm_exidx_data_free): Remove.
1131         (arm_exidx_data_key): Change type.  Move lower.
1132         (arm_exidx_new_objfile): Update.
1133         (arm_compare_exidx_entries): Remove.
1134         (arm_find_exidx_entry, _initialize_arm_tdep)
1135
1136 2019-07-10  Tom Tromey  <tromey@adacore.com>
1137
1138         * solib-spu.c (ocl_program_data_key): Change type.
1139         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
1140         Update.
1141
1142 2019-07-10  Tom Tromey  <tromey@adacore.com>
1143
1144         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
1145         (struct solib_aix_inferior_data) <library_list>: Change type.
1146         (solib_aix_inferior_data_handle): Change type.
1147         (get_solib_aix_inferior_data): Update.
1148         (solib_aix_free_library_list): Remove.
1149         (library_list_start_library): Update.
1150         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
1151         return type.
1152         (solib_aix_get_library_list)
1153         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
1154         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
1155
1156 2019-07-10  Tom Tromey  <tromey@adacore.com>
1157
1158         * solib-dsbt.c (struct dsbt_info): Add initializers.
1159         (solib_dsbt_pspace_data): Change type.
1160         (dsbt_pspace_data_cleanup): Remove.
1161         (get_dsbt_info, _initialize_dsbt_solib): Update.
1162
1163 2019-07-10  Tom Tromey  <tromey@adacore.com>
1164
1165         * spu-tdep.c (spu_overlay_data): Change type.
1166         (spu_get_overlay_table, spu_overlay_new_objfile)
1167         (_initialize_spu_tdep): Update.
1168
1169 2019-07-10  Tom Tromey  <tromey@adacore.com>
1170
1171         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
1172         destructor.
1173         (dbx_objfile_data_key): Change type and declare later.
1174         (DBX_SYMFILE_INFO): Rewrite.
1175         * dbxread.c (dbx_objfile_data_key): Change type.
1176         (dbx_symfile_init): Update.
1177         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
1178         (coffstab_build_psymtabs, elfstab_build_psymtabs)
1179         (stabsect_build_psymtabs, _initialize_dbxread): Update.
1180
1181 2019-07-10  Tom Tromey  <tromey@adacore.com>
1182
1183         * jit.c (jit_program_space_key): Change type.  Move lower.
1184         (get_jit_program_space_data): Update.
1185         (jit_program_space_data_cleanup): Remove.
1186         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
1187         Update.
1188         (struct jit_program_space_data): Add initializers.
1189
1190 2019-07-10  Tom Tromey  <tromey@adacore.com>
1191
1192         * solib-darwin.c (struct darwin_info): Add initializers.
1193         (solib_darwin_pspace_data): Change type.
1194         (darwin_pspace_data_cleanup): Remove.
1195         (get_darwin_info, _initialize_darwin_solib): Update.
1196
1197 2019-07-10  Tom Tromey  <tromey@adacore.com>
1198
1199         * remote-sim.c (struct sim_inferior_data): Add initializers,
1200         constructor, and destructor.
1201         (sim_inferior_data_key): Change type.  Move lower.
1202         (check_for_duplicate_sim_descriptor): Update.
1203         (get_sim_inferior_data): Use new.  Update.
1204         (~sim_inferior_data_cleanup): Rename from
1205         sim_inferior_data_cleanup.  Simplify.
1206         (gdbsim_close_inferior, simulator_command)
1207         (sim_command_completer, _initialize_remote_sim): Update.
1208         (next_pid, INITIAL_PID): Move earlier.
1209
1210 2019-07-10  Tom Tromey  <tromey@adacore.com>
1211
1212         * python/python-internal.h (create_thread_object): Return
1213         gdbpy_ref.
1214         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
1215         * python/py-inferior.c (struct threadlist_entry): Add
1216         constructor.
1217         <thread_obj>: Now a gdbpy_ref.
1218         (thread_to_thread_object): Update.
1219         (add_thread_object): Use new.
1220         (delete_thread_object): Use delete.
1221         (infpy_threads): Update.
1222         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
1223         GIL.
1224
1225 2019-07-10  Tom Tromey  <tromey@adacore.com>
1226
1227         * valops.c (value_cast): Specialize error message for Ada.
1228
1229 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1230
1231         * breakpoint.c (breakpoint_1): Update doc and parameter names.
1232
1233 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
1234
1235         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
1236         bpstat_should_step): Return bool, adjust comments.
1237         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
1238         bpstat_should_step): Likewise.
1239
1240 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1241
1242         * features/Makefile: Use feature target descriptions for Arm.
1243         * features/arm/arm-core.c: Generate new file.
1244         * features/arm/arm-fpa.c: Likewise.
1245         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
1246         * features/arm/arm-m-profile.c: Likewise.
1247         * features/arm/arm-vfpv2.c: Likewise.
1248         * features/arm/arm-vfpv3.c: Likewise.
1249         * features/arm/xscale-iwmmxt.c: Likewise.
1250         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
1251
1252 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1253
1254         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
1255         ptrace earlier.
1256
1257 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
1258
1259         * features/aarch64-pauth.c: Regenerate.
1260
1261 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
1262
1263         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
1264         bool.
1265         (bpstat_what): Use false instead of 0.
1266
1267 2019-07-09  Pedro Alves  <palves@redhat.com>
1268
1269         * break-catch-throw.c (is_exception_catchpoint): New.
1270         * breakpoint.c (print_one_breakpoint_location): New parameter
1271         'raw_loc'.  Handle it.  Use
1272         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
1273         looking at the breakpoint's type.
1274         (print_one_breakpoint): If handling "maint info breakpoints", also
1275         print locations of exception catchpoints.
1276         * breakpoint.h (is_exception_catchpoint): Declare.
1277
1278 2019-07-09  Pedro Alves  <palves@redhat.com>
1279
1280         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
1281         "addr" field.
1282         (allocate_location_exception_catchpoint): New.
1283         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
1284         (initialize_throw_catchpoint_ops): Install
1285         allocate_location_exception_catchpoint as allocate_location
1286         method.
1287         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
1288         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
1289         bp_loc_other.
1290         (breakpoint_address_is_meaningful): Delete.
1291         (bl_address_is_meaningful): New.
1292         (breakpoint_locations_match): Adjust comment.
1293         (bp_location_from_bp_type): New, factored out of...
1294         (bp_location::bp_location(breakpoint *)): ... this.
1295         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
1296         factored out of...
1297         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
1298         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
1299         breakpoint_address_is_meaningful.
1300         (bp_locations_compare): Adjust comment.
1301         (update_global_location_list): Use bl_address_is_meaningful
1302         instead of breakpoint_address_is_meaningful.
1303         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
1304         explicit.
1305         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
1306         * python/py-breakpoint.c (bppy_get_location): No longer check
1307         whether location is null.
1308
1309 2019-07-09  Pedro Alves  <palves@redhat.com>
1310
1311         PR c++/15468
1312         * breakpoint.c (print_one_breakpoint_location): Remove
1313         single-location assert.
1314
1315 2019-07-09  Tom Tromey  <tom@tromey.com>
1316
1317         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
1318         * configure: Rebuild.
1319         * configure.ac: Change common to gdbsupport.
1320         * gdbsupport: Rename from common.
1321         * acinclude.m4: Change common to gdbsupport.
1322         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
1323         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
1324         gdbsupport.
1325         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
1326         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
1327         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
1328         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
1329         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
1330         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
1331         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
1332         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
1333         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
1334         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
1335         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
1336         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
1337         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
1338         coff-pe-read.c, command.h, compile/compile-c-support.c,
1339         compile/compile-c.h, compile/compile-cplus-symbols.c,
1340         compile/compile-cplus-types.c, compile/compile-cplus.h,
1341         compile/compile-loc2c.c, compile/compile.c, completer.c,
1342         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
1343         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
1344         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
1345         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
1346         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
1347         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
1348         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
1349         features/aarch64-core.c, features/aarch64-fpu.c,
1350         features/aarch64-pauth.c, features/aarch64-sve.c,
1351         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
1352         features/i386/32bit-core.c, features/i386/32bit-linux.c,
1353         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
1354         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
1355         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
1356         features/i386/64bit-core.c, features/i386/64bit-linux.c,
1357         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
1358         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
1359         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
1360         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
1361         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
1362         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
1363         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
1364         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
1365         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
1366         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
1367         go32-nat.c, guile/guile.c, guile/scm-ports.c,
1368         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
1369         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
1370         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
1371         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
1372         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
1373         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
1374         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
1375         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
1376         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
1377         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
1378         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
1379         minsyms.c, mips-linux-tdep.c, namespace.h,
1380         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
1381         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
1382         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
1383         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
1384         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
1385         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
1386         nat/linux-waitpid.c, nat/mips-linux-watch.c,
1387         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
1388         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
1389         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
1390         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
1391         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
1392         procfs.c, producer.c, progspace.h, psymtab.h,
1393         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
1394         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
1395         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
1396         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
1397         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
1398         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
1399         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
1400         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
1401         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
1402         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
1403         target-memory.c, target.c, target.h, target/waitstatus.c,
1404         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
1405         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
1406         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
1407         unittests/array-view-selftests.c,
1408         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
1409         unittests/common-utils-selftests.c,
1410         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
1411         unittests/format_pieces-selftests.c,
1412         unittests/function-view-selftests.c,
1413         unittests/lookup_name_info-selftests.c,
1414         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
1415         unittests/mkdir-recursive-selftests.c,
1416         unittests/observable-selftests.c,
1417         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
1418         unittests/parse-connection-spec-selftests.c,
1419         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
1420         unittests/scoped_fd-selftests.c,
1421         unittests/scoped_mmap-selftests.c,
1422         unittests/scoped_restore-selftests.c,
1423         unittests/string_view-selftests.c, unittests/style-selftests.c,
1424         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
1425         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
1426         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
1427         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
1428         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
1429         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
1430
1431 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1432
1433         * linespec.c (decode_digits_list_mode): Set explicit_line to a
1434         bool value.
1435         (decode_digits_ordinary): Set explicit_line field in sal.
1436         * symtab.c (skip_prologue_sal): Don't skip prologue for a
1437         symtab_and_line that was set on an explicit line number in
1438         assembler code.  Do always update the recorded symtab and line if
1439         we do skip the prologue.
1440
1441 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1442
1443         * breakpoint.c (set_breakpoint_location_function): Remove
1444         explicit_loc parameter.
1445         (momentary_breakpoint_from_master): Update call to
1446         set_breakpoint_location_function.
1447         (add_location_to_breakpoint): Likewise.
1448
1449 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1450
1451         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
1452         required features based on default bfd type when no specific bfd
1453         is present.
1454
1455 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1456
1457         * NEWS: Mention that GDB printf and eval commands can now print
1458         C-style and Ada-style convenience var strings without
1459         calling the inferior.
1460         * printcmd.c (printf_c_string): Locally print GDB internal var
1461         instead of transiting via the inferior.
1462         (printf_wide_c_string): Likewise.
1463
1464 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1465
1466         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
1467
1468 2019-07-04  Tom Tromey  <tom@tromey.com>
1469
1470         PR tui/24724:
1471         * tui/tui-winsource.c (tui_clear_source_content): Update.
1472         (tui_source_window_base::set_is_exec_point_at): Fix comment.
1473         (tui_update_breakpoint_info): Update.
1474         (tui_set_exec_info_content): Update.
1475         * tui/tui-source.c (tui_set_source_content_nil): Update.
1476         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
1477         has_break.
1478         * tui/tui-data.h (enum tui_bp_flag): New.
1479         (tui_bp_flags): New enum flags type.
1480         (struct tui_source_element) <break_mode>: Change type.  Rename
1481         from has_break.
1482         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
1483         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
1484         constants.
1485         * tui/tui-winsource.h: Fix comment.
1486
1487 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1488
1489         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
1490         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
1491         (store_fpregs_to_thread)
1492         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1493         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
1494         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
1495         (IWMMXT_REGS_SIZE): Add define.
1496         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
1497         (fetch_vfp_regs, store_vfp_regs)
1498         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
1499         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
1500
1501 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1502
1503         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
1504         defines.
1505         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
1506         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
1507         (ARM_INT_REGISTER_SIZE): ...to this.
1508         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
1509         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
1510         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
1511         (arm_linux_collect_gregset, supply_nwfpe_register)
1512         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
1513         defines.
1514         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
1515         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
1516         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
1517         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
1518         (arm_return_in_memory, arm_store_return_value)
1519         (arm_get_longjmp_target, arm_register_g_packet_guesses)
1520         (arm_record_ld_st_multiple): Likewise.
1521         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
1522         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
1523
1524 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1525
1526         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
1527         AARCH64_DISPLACED_MODIFIED_INSNS.
1528         * aarch64-tdep.c (struct aarch64_displaced_step_data)
1529         (aarch64_displaced_step_copy_insn): Likewise.
1530         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1531         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
1532         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
1533         ARM_DISPLACED_MODIFIED_INSNS.
1534         * arm-tdep.c (arm_gdbarch_init): Likewise.
1535         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
1536         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
1537         (struct arm_displaced_step_closure): Use
1538         ARM_DISPLACED_MODIFIED_INSNS.
1539
1540 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1541
1542         * features/Makefile: Remove unused xml files.
1543         * features/aarch64.xml: Remove.
1544         * features/i386/amd64-avx-avx512-linux.xml: Remove.
1545         * features/i386/amd64-avx-avx512.xml: Remove.
1546         * features/i386/amd64-avx-linux.xml: Remove.
1547         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
1548         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
1549         * features/i386/amd64-avx-mpx-linux.xml: Remove.
1550         * features/i386/amd64-avx-mpx.xml: Remove.
1551         * features/i386/amd64-avx.xml: Remove.
1552         * features/i386/amd64-linux.xml: Remove.
1553         * features/i386/amd64-mpx-linux.xml: Remove.
1554         * features/i386/amd64-mpx.xml: Remove.
1555         * features/i386/amd64.xml: Remove.
1556         * features/i386/i386-avx-avx512-linux.xml: Remove.
1557         * features/i386/i386-avx-avx512.xml: Remove.
1558         * features/i386/i386-avx-linux.xml: Remove.
1559         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
1560         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
1561         * features/i386/i386-avx-mpx-linux.xml: Remove.
1562         * features/i386/i386-avx-mpx.xml: Remove.
1563         * features/i386/i386-avx.xml: Remove.
1564         * features/i386/i386-linux.xml: Remove.
1565         * features/i386/i386-mmx-linux.xml: Remove.
1566         * features/i386/i386-mmx.xml: Remove.
1567         * features/i386/i386-mpx-linux.xml: Remove.
1568         * features/i386/i386-mpx.xml: Remove.
1569         * features/i386/i386.xml: Remove.
1570         * features/i386/x32-avx-avx512-linux.xml: Remove.
1571         * features/i386/x32-avx-linux.xml: Remove.
1572         * features/i386/x32-linux.xml: Remove.
1573
1574 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1575
1576         * regformats/aarch64.dat: Remove.
1577         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
1578         * regformats/i386/amd64-avx-linux.dat: Remove.
1579         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
1580         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
1581         * regformats/i386/amd64-linux.dat: Remove.
1582         * regformats/i386/amd64-mpx-linux.dat: Remove.
1583         * regformats/i386/amd64.dat: Remove.
1584         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
1585         * regformats/i386/i386-avx-linux.dat: Remove.
1586         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
1587         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
1588         * regformats/i386/i386-linux.dat: Remove.
1589         * regformats/i386/i386-mmx-linux.dat: Remove.
1590         * regformats/i386/i386-mpx-linux.dat: Remove.
1591         * regformats/i386/i386.dat: Remove.
1592         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
1593         * regformats/i386/x32-avx-linux.dat: Remove.
1594         * regformats/i386/x32-linux.dat: Remove.
1595
1596 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
1597
1598         * aarch64-tdep.c: Remove xml self tests.
1599         * amd64-linux-tdep.c: Likewise.
1600         * amd64-tdep.c: Likewise.
1601         * i386-linux-tdep.c: Likewise.
1602         * i386-tdep.c: Likewise.
1603
1604 2019-07-03  Pedro Alves  <palves@redhat.com>
1605
1606         PR cli/24732
1607         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
1608         (pipe_cmd_option_defs): New.
1609         (make_pipe_cmd_options_def_group): New.
1610         (pipe_command): Use gdb::option::process_options.
1611         (pipe_command_completer): New function.
1612         (_initialize_cli_cmds): Install completer for "pipe" command.
1613
1614 2019-07-03  Pedro Alves  <palves@redhat.com>
1615
1616         * cli/cli-option.c (union option_value) <string>: New field.
1617         (struct option_def_and_value): Add ctor, move ctor, dtor and
1618         use DISABLE_COPY_AND_ASSIGN.
1619         (option_def_and_value::clear_value): New.
1620         (parse_option, save_option_value_in_ctx, get_val_type_str)
1621         (add_setshow_cmds_for_options): Handle var_string.
1622         * cli-option.h (union option_def::var_address) <string>: New
1623         field.
1624         (struct string_option_def): New.
1625         * maint-test-options.c (struct test_options_opts): Add default
1626         ctor and use DISABLE_COPY_AND_ASSIGN.
1627         <string_opt>: New field.
1628         (test_options_opts::~test_options_opts): New.
1629         (test_options_opts::dump): Also dump "-string".
1630         (test_options_option_defs): Install "string.
1631
1632 2019-07-03  Pedro Alves  <palves@redhat.com>
1633
1634         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
1635         option_value with a null enumeration.
1636         (complete_options): Save the option values in the context.
1637         (save_option_value_in_ctx): New, factored out from ...
1638         (process_options): ... here.
1639         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
1640         of the function.
1641         * maint-test-options.c (test_options_opts::dump): New, factored
1642         out from ...
1643         (maintenance_test_options_command_mode): ... here.
1644         (maintenance_test_options_command_completion_result): Delete.
1645         (maintenance_test_options_command_completion_text): Update
1646         comment.
1647         (maintenance_show_test_options_completion_result): Change
1648         prototype.  Just print
1649         maintenance_test_options_command_completion_text.
1650         (save_completion_result): New.
1651         (maintenance_test_options_completer_mode): Pass options context to
1652         complete_options, and then save a dump.
1653         (_initialize_maint_test_options): Use add_cmd to install "maint
1654         show test-options-completion-result".
1655
1656 2019-07-03  Pedro Alves  <palves@redhat.com>
1657
1658         * NEWS (New commands): Mention "with" and "maint with".
1659         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
1660         (with_command, with_command_completer): New.
1661         (pipe_command): Adjust to new repeat_previous
1662         interface.
1663         (_initialize_cli_cmds): Install the "with" command and its "w"
1664         alias.
1665         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
1666         declarations.
1667         * cli/cli-setshow.c (parse_cli_var_uinteger)
1668         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
1669         argument strings for all var_types.
1670         (get_setshow_command_value_string): New, factored out from ...
1671         (do_show_command): ... this.
1672         * cli/cli-setshow.h: Include <string>.
1673         (get_setshow_command_value_string): Declare.
1674         * command.h (repeat_previous): Now returns const char *.  Adjust
1675         comment.
1676         * maint.c: Include "cli/cli-cmds.h".
1677         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
1678         (_initialize_maint_cmds): Register the "maintenance with" command.
1679         * top.c (repeat_previous): Move bits from pipe_command here:
1680         Return the saved command line, if any; error out if there's no
1681         command to relaunch.
1682
1683 2019-07-03  Pedro Alves  <palves@redhat.com>
1684
1685         * NEWS (New commands): Mention "maint set/show test-settings"
1686         instead of "maint test-settings".
1687         * maint-test-settings.c (maintenance_test_settings_list): Delete.
1688         (maintenance_test_settings_set_list): Rename to ...
1689         (maintenance_set_test_settings_list): ... this.
1690         (maintenance_test_settings_show_list): Rename to  ...
1691         (maintenance_show_test_settings_list): ... this.
1692         (maintenance_test_settings_cmd): Delete.
1693         (maintenance_test_settings_set_cmd): ...
1694         (maintenance_set_test_settings_cmd): ... this.
1695         (maintenance_test_settings_show_cmd): ...
1696         (maintenance_show_test_settings_cmd): ... this.
1697         (maintenance_test_settings_show_value_cmd):
1698         (maintenance_show_test_settings_value_cmd): ... this.
1699         (_initialize_maint_test_settings): No longer install the "maint
1700         test-settings" prefix command.  Rename "maint test-settings set"
1701         to "maint set test-settings", and "maint test-settings show" to
1702         "maint show test-settings".  Adjust all subcommands.
1703
1704 2019-07-03  Pedro Alves  <palves@redhat.com>
1705
1706         * maint-test-settings.c: Fix file's intro comment.  Replace all
1707         references to "test-options" with references to "test-settings",
1708         in comments.
1709
1710 2019-07-03  Pedro Alves  <palves@redhat.com>
1711
1712         * maint-test-settings.c (maintenance_test_settings_xxx)
1713         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
1714         New.
1715         (maintenance_test_settings_enums): Use them.
1716         (maintenance_test_settings_enum): Default to
1717         maintenance_test_settings_xxx.
1718         (_initialize_maint_test_settings): Initialize
1719         MAINTENANCE_TEST_SETTINGS_FILENAME.
1720
1721 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1722
1723         * breakpoint.h (remove_breakpoints_inf): Change return type to
1724         void, move function documentation here.
1725         * breakpoint.c (remove_breakpoints_inf): Change return type to
1726         void, move function documentation to header.
1727
1728 2019-07-02  Pedro Alves  <palves@redhat.com>
1729
1730         * NEWS (Completion improvements): Mention "info threads".
1731         * thread.c (struct info_threads_opts, info_threads_option_defs)
1732         (make_info_threads_options_def_group): New.
1733         (info_threads_command): Use gdb::option::process_options.
1734         (info_threads_command_completer): New.
1735         (_initialize_thread): Use gdb::option::build_help to build the
1736         help text for "info threads".
1737
1738 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
1739
1740         * defs.h (generic_load): Move from here...
1741         * symfile.h (generic_load): ... to here.  Rename name parameter
1742         to args.
1743         * symfile.c (generic_load): Add comment.
1744
1745 2019-07-01  Tom Tromey  <tromey@adacore.com>
1746
1747         * dwarf2read.c
1748         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
1749         declaration of without_params.  Fix formatting.
1750
1751 2019-07-01  Tom Tromey  <tromey@adacore.com>
1752
1753         * ada-exp.y (find_primitive_type): Update.
1754         * ada-lang.h (ada_lookup_symbol): Update.
1755         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
1756         parameter.
1757         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
1758
1759 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1760
1761         PR breakpoints/24541
1762         * gdbarch.c: Regenerate.
1763         * gdbarch.h: Regenerate.
1764         * gdbarch.sh: Add 'stap_adjust_register'.
1765         * i386-tdep.c: Include '<unordered_set>'.
1766         (i386_stap_adjust_register): New function.
1767         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
1768         * stap-probe.c (stap_parse_register_operand): Call
1769         'gdbarch_stap_adjust_register'.
1770
1771 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
1772
1773         PR python/24742
1774         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
1775         * python/python.c (do_start_initialization): Use 'xmalloc'
1776         instead of 'PyMem_Malloc'.
1777
1778 2019-06-28  Tom Tromey  <tromey@adacore.com>
1779
1780         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
1781         for Ada.
1782
1783 2019-06-27  Tom Tromey  <tromey@adacore.com>
1784
1785         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
1786         objfile_key.
1787         (arm_find_mapping_symbol, arm_record_special_symbol)
1788         (_initialize_arm_tdep): Update.
1789         (arm_objfile_data_free): Remove.
1790
1791 2019-06-27  Tom Tromey  <tromey@adacore.com>
1792
1793         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1794         to cp_print_static_field.
1795
1796 2019-06-26  Tom Tromey  <tromey@adacore.com>
1797
1798         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1799         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1800         declare.
1801
1802 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1803
1804         * features/aarch64-core.c (create_feature_aarch64_core):
1805         Regenerate.
1806         * features/aarch64-core.xml: Add cpsr flags.
1807
1808 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1809
1810         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1811         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1812
1813 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1814
1815         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1816         field.
1817         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1818         use.
1819         (arm_record_special_symbol): Don't insert new symbol in sorted
1820         position, push it at the end.
1821
1822 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1823
1824         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1825         (arm_mapping_symbol_s): Remove.
1826         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1827         (arm_mapping_symbol_vec): New typedef.
1828         (struct arm_per_objfile): Add constructor.
1829         <section_maps>: Change type to
1830         std::unique_ptr<arm_mapping_symbol_vec[]>.
1831         (arm_compare_mapping_symbols): Remove.
1832         (arm_find_mapping_symbol): Adjust to section_maps type change.
1833         (arm_objfile_data_free): Call delete on arm_per_objfile.
1834         (arm_record_special_symbol): Adjust to section_maps type change.
1835         Allocate arm_per_objfile with new.
1836
1837 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1838
1839         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1840         with the command prefix.
1841
1842 2019-06-25  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1845         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1846
1847 2019-06-25  Tom Tromey  <tom@tromey.com>
1848
1849         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1850         type.
1851         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1852         protected.
1853
1854 2019-06-25  Tom Tromey  <tom@tromey.com>
1855
1856         * tui/tui-winsource.c
1857         (tui_source_window_base::set_is_exec_point_at): Add check against
1858         LOA_ADDRESS.
1859
1860 2019-06-25  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-source.c (tui_set_source_content): Don't check before
1863         xfree.
1864         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1865
1866 2019-06-25  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-winsource.h (tui_update_source_window_as_is)
1869         (tui_alloc_source_buffer, tui_line_is_displayed)
1870         (tui_addr_is_displayed): Change type of win_info.
1871         * tui/tui-winsource.c (tui_update_source_window_as_is)
1872         (tui_clear_source_content, tui_show_source_line)
1873         (tui_show_source_content, tui_source_window_base::refill)
1874         (tui_source_window_base::set_is_exec_point_at)
1875         (tui_source_window_base::set_is_exec_point_at)
1876         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1877         (tui_alloc_source_buffer, tui_line_is_displayed)
1878         (tui_addr_is_displayed): Change type of win_info.  Update.
1879         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1880         (tui_source_window_base::do_make_visible_with_new_height):
1881         Update.
1882         * tui/tui-source.c (tui_set_source_content)
1883         (tui_set_source_content_nil)
1884         (tui_source_window::do_scroll_vertical): Update.
1885         * tui/tui-layout.c (show_layout): Update.
1886         * tui/tui-disasm.c (tui_set_disassem_content)
1887         (tui_disasm_window::do_scroll_vertical): Update.
1888         * tui/tui-data.h (tui_win_content): Remove.
1889         (struct tui_gen_win_info) <content, content_size>: Remove.
1890         (struct tui_source_element): Add initializers and destructor.
1891         (union tui_which_element, struct tui_win_element): Remove.
1892         (struct tui_source_window_base) <content>: New field.
1893         (struct tui_data_window): Remove destructor.
1894         (tui_alloc_content, tui_free_win_content)
1895         (tui_free_all_source_wins_content): Don't declare.
1896         * tui/tui-data.c (tui_initialize_static_data): Update.
1897         (init_content_element, tui_alloc_content): Remove.
1898         (~tui_gen_win_info): Update.
1899         (~tui_data_window, tui_free_all_source_wins_content)
1900         (tui_free_win_content, free_content, free_content_elements):
1901         Remove.
1902
1903 2019-06-25  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-winsource.h (tui_clear_source_content)
1906         (tui_erase_source_content, tui_show_source_content): Change type
1907         of win_info.
1908         * tui/tui-winsource.c (tui_clear_source_content)
1909         (tui_erase_source_content, tui_show_source_content): Change type
1910         of win_info.
1911         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1912         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1913         win_info.
1914         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1915         win_info.
1916         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1917
1918 2019-06-25  Tom Tromey  <tom@tromey.com>
1919
1920         * tui/tui-winsource.c (tui_clear_source_content)
1921         (tui_source_window_base::set_is_exec_point_at): Update.
1922         * tui/tui-source.c (tui_set_source_content_nil): Update.
1923         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1924         a bool.
1925         * tui/tui-data.c (init_content_element): Update.
1926
1927 2019-06-25  Tom Tromey  <tom@tromey.com>
1928
1929         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1930         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1931         * tui/tui-layout.c (init_and_make_win): Update.
1932         * tui/tui.h (enum tui_win_type): Update.
1933         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1934         tui_win_is_auxillary.
1935         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1936         tui_win_is_auxillary.
1937
1938 2019-06-25  Tom Tromey  <tom@tromey.com>
1939
1940         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1941         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1942         (tui_delete_data_content_windows, tui_display_all_data)
1943         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1944         Update.
1945         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1946         * tui/tui-regs.c (tui_last_regs_line_no)
1947         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1948         (tui_show_registers): Update.
1949         (tui_show_register_group): Return void.  Update.
1950         (tui_display_registers_from, tui_display_reg_element_at_line)
1951         (tui_display_registers_from_line, tui_check_register_values):
1952         Update.
1953         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1954         member.
1955         (struct tui_data_window) <regs_content>: Now a std::vector.
1956         <regs_content_count>: Remove.
1957         (tui_add_content_elements, tui_free_data_content): Don't declare.
1958         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1959         (init_content_element): Remove DATA_WIN case.  Add assert.
1960         (tui_add_content_elements): Remove.
1961         (tui_data_window): Update.
1962         (tui_free_data_content): Remove.
1963         (free_content_elements): Remove DATA_WIN case.
1964
1965 2019-06-25  Tom Tromey  <tom@tromey.com>
1966
1967         * tui/tui-data.c (tui_data_item_window): Update.
1968         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1969         * tui/tui-windata.c (tui_display_all_data)
1970         (tui_display_data_from_line): Update.
1971         (tui_check_data_values): Remove.
1972         * tui/tui-regs.c (tui_show_register_group)
1973         (tui_display_reg_element_at_line): Update.
1974         * tui/tui-hooks.c (tui_register_changed)
1975         (tui_refresh_frame_and_register_information): Call
1976         tui_check_register_values.
1977         * tui/tui-data.h (struct tui_data_window) <data_content,
1978         data_content_count, data_type>: Remove.
1979         (enum tui_data_type): Remove.
1980
1981         * tui/tui-data.c (tui_data_window::clear_detail)
1982         (~tui_data_window): Update.
1983
1984 2019-06-25  Tom Tromey  <tom@tromey.com>
1985
1986         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1987         declare.
1988         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1989         Rename from tui_first_data_item_displayed.  Update.
1990         (tui_data_window::refresh_all)
1991         (tui_data_window::do_scroll_vertical): Update.
1992         * tui/tui-data.h (struct tui_data_window)
1993         <first_data_item_displayed>: Declare new method.
1994
1995 2019-06-25  Tom Tromey  <tom@tromey.com>
1996
1997         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1998         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1999         contents...
2000         (tui_initialize_static_data): ...here.
2001
2002 2019-06-25  Tom Tromey  <tom@tromey.com>
2003
2004         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2005         (tui_display_registers_from, tui_check_register_values): Update.
2006         (tui_display_register): Remove win_info parameter; update.
2007         (tui_get_register): Change type of parameters.
2008         * tui/tui-data.h (struct tui_data_element): Remove.
2009         (union tui_which_element) <data>: Remove.
2010         <data_window>: Change type.
2011         (struct tui_data_item_window): New.
2012         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
2013         case.  Add assert.
2014         (~tui_data_item_window): New destructor.
2015         (free_content_elements): Remove DATA_ITEM_WIN case.
2016
2017 2019-06-25  Tom Tromey  <tom@tromey.com>
2018
2019         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
2020         Remove.
2021
2022 2019-06-25  Tom Tromey  <tom@tromey.com>
2023
2024         * tui/tui-data.h (struct tui_command_element): Remove.
2025         (union tui_which_element) <command>: Remove.
2026         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
2027         assert.
2028         (free_content_elements): Remove CMD_WIN case.
2029
2030 2019-06-25  Tom Tromey  <tom@tromey.com>
2031
2032         * tui/tui-layout.c (tui_set_layout): Update.
2033         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
2034         * tui/tui-data.c (layout_def): Update.
2035
2036 2019-06-25  Tom Tromey  <tom@tromey.com>
2037
2038         * tui/tui-wingeneral.c (tui_refresh_all): Update.
2039         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2040         (tui_source_window_base::set_new_height): Update.
2041         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
2042         Update.
2043         (tui_set_locator_fullname, tui_set_locator_info)
2044         (tui_show_frame_info): Update.
2045         * tui/tui-source.c (tui_set_source_content)
2046         (tui_source_is_displayed): Update.
2047         * tui/tui-layout.c (show_source_disasm_command, show_data)
2048         (show_source_or_disasm_and_command): Update.
2049         * tui/tui-disasm.c (tui_set_disassem_content)
2050         (tui_get_begin_asm_address): Update.
2051         * tui/tui-data.h (struct tui_locator_element): Remove.
2052         (union tui_which_element) <locator>: Remove.
2053         (struct tui_locator_window): New.
2054         (tui_locator_win_info_ptr): Change return type.
2055         * tui/tui-data.c (_locator): Change type.
2056         (tui_locator_win_info_ptr): Change return type.
2057         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
2058         (tui_alloc_content): Add assert.
2059
2060 2019-06-25  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-winsource.c
2063         (tui_exec_info_window::maybe_allocate_content): New method.
2064         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
2065         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
2066         (make_source_or_disasm_window): Add cast.
2067         * tui/tui-data.h (union tui_which_element) <simple_string>:
2068         Remove.
2069         (struct tui_source_info): New.
2070         (struct tui_source_window_base) <execution_info>: Change type.
2071         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
2072         case, and add assert.
2073         (tui_alloc_content): Add assert.
2074
2075 2019-06-25  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
2078         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
2079         * tui/tui-data.c (tui_alloc_win_info): Remove.
2080
2081 2019-06-25  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
2084         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
2085         can_highlight.
2086
2087 2019-06-25  Tom Tromey  <tom@tromey.com>
2088
2089         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
2090         make_visible_with_new_height method.
2091         (tui_win_info::make_visible_with_new_height): New method.
2092         (tui_source_window_base::do_make_visible_with_new_height)
2093         (tui_data_window::do_make_visible_with_new_height)
2094         (tui_cmd_window::do_make_visible_with_new_height): New methods.
2095         (make_visible_with_new_height): Remove.
2096         (tui_resize_all, tui_adjust_win_heights): Use
2097         make_visible_with_new_height method.
2098         * tui/tui-data.h (struct tui_win_info)
2099         <do_make_visible_with_new_height, make_visible_with_new_height>:
2100         New methods.
2101         (struct tui_source_window_base, struct tui_data_window)
2102         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
2103         methods.
2104
2105 2019-06-25  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
2108         method.
2109         (update_tab_width): Call update_tab_width method.
2110         * tui/tui-data.h (struct tui_win_info)
2111         (struct tui_source_window_base) <update_tab_width>: New methods.
2112
2113 2019-06-25  Tom Tromey  <tom@tromey.com>
2114
2115         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
2116         parameter.
2117         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
2118         parameter.
2119         (tui_gen_win_info::make_visible): Update.
2120         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
2121         parameter.
2122         * tui/tui-data.h (enum tui_box): New enum.
2123         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
2124
2125 2019-06-25  Tom Tromey  <tom@tromey.com>
2126
2127         * tui/tui-layout.c (make_source_or_disasm_window): Always use
2128         init_and_make_win for EXEC_INFO_WIN.
2129         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
2130         longer inline.
2131         (struct tui_win_info) <~tui_win_info>: Inline.
2132         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2133         Don't declare.
2134         * tui/tui-data.c (source_win, disasm_win): Remove globals.
2135         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2136         Remove.
2137         (tui_initialize_static_data): Update.
2138         (~tui_gen_win_info): Handle more cleanup here.
2139         (~tui_source_window_base): Delete "execution_info".
2140         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
2141
2142 2019-06-25  Tom Tromey  <tom@tromey.com>
2143
2144         * tui/tui-layout.c (make_command_window): Don't set
2145         can_highlight.
2146         (show_source_disasm_command): Call the reset method.
2147         (show_data): Don't set can_highlight.  Call the reset method.
2148         (tui_gen_win_info::reset): Rename from init_gen_win_info
2149         (init_and_make_win): Simplify.  Return tui_gen_win_info.
2150         (show_source_or_disasm_and_command): Call the reset method.
2151         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
2152         (struct tui_cmd_window): Set can_highlight.
2153
2154 2019-06-25  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
2157         from make_visible.
2158         (tui_make_visible, tui_make_invisible): Rewrite.
2159         (tui_win_info::make_visible): Remove.
2160         (tui_source_window_base::make_visible): Update.
2161         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
2162         method.  Moved from...
2163         (struct tui_win_info) <make_visible>: ...here.
2164
2165 2019-06-25  Tom Tromey  <tom@tromey.com>
2166
2167         * tui/tui-winsource.c
2168         (tui_source_window_base::do_scroll_horizontal): Remove direction
2169         parameter.
2170         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
2171         direction parameter.
2172         * tui/tui-win.c (tui_win_info::forward_scroll)
2173         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2174         (tui_win_info::right_scroll): Update.
2175         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
2176         direction parameter.
2177         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
2178         direction parameter.
2179         * tui/tui-data.h (enum tui_scroll_direction): Remove.
2180         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
2181         Remove direction parameter.
2182         (struct tui_source_window_base, struct tui_source_window)
2183         (struct tui_disasm_window, struct tui_data_window)
2184         (struct tui_cmd_window): Update.
2185
2186 2019-06-25  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-winsource.h (tui_set_exec_info_content)
2189         (tui_show_exec_info_content, tui_erase_exec_info_content)
2190         (tui_clear_exec_info_content, tui_update_exec_info): Change
2191         argument to tui_source_window_base.
2192         * tui/tui-winsource.c (tui_set_exec_info_content)
2193         (tui_show_exec_info_content, tui_erase_exec_info_content)
2194         (tui_clear_exec_info_content, tui_update_exec_info): Change
2195         argument to tui_source_window_base.
2196
2197 2019-06-25  Tom Tromey  <tom@tromey.com>
2198
2199         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
2200         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
2201
2202 2019-06-25  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
2205         check.
2206
2207 2019-06-25  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
2210         type to void.
2211         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
2212         type to void.
2213         * tui/tui-source.c (tui_set_source_content): Update.
2214         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2215
2216 2019-06-25  Tom Tromey  <tom@tromey.com>
2217
2218         * tui/tui-win.c (window_name_completer, tui_set_focus)
2219         (tui_all_windows_info): Use name method.
2220         * tui/tui-data.h (struct tui_gen_win_info)
2221         (struct tui_source_window, struct tui_disasm_window)
2222         (struct tui_data_window, struct tui_cmd_window) <name>: New
2223         method.
2224         (tui_win_name): Don't declare.
2225         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
2226         (tui_win_name): Remove.
2227
2228 2019-06-25  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-winsource.h (tui_update_source_window)
2231         (tui_update_source_window_as_is): Change parameter type.
2232         * tui/tui-winsource.c (tui_update_source_window): Change win_info
2233         to be a tui_source_window_base.
2234         (tui_update_source_window_as_is): Likewise.
2235         * tui/tui-win.c (make_visible_with_new_height): Update.
2236
2237 2019-06-25  Tom Tromey  <tom@tromey.com>
2238
2239         * tui/tui-winsource.c (tui_erase_source_content)
2240         (tui_show_source_content, tui_show_exec_info_content)
2241         (tui_erase_exec_info_content): Use refresh_window method.
2242         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
2243         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
2244         from tui_refresh_win.
2245         (tui_data_window::refresh_window): New method.
2246         (tui_win_info::refresh, tui_source_window_base::refresh)
2247         (tui_refresh_all): Use refresh_window method.
2248         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
2249         method.
2250         * tui/tui-regs.c (tui_display_register): Call refresh_window
2251         method.
2252         * tui/tui-layout.c (show_source_disasm_command)
2253         (show_source_or_disasm_and_command): Call refresh_window method.
2254         * tui/tui-data.h (struct tui_gen_win_info)
2255         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
2256         New method.
2257
2258 2019-06-25  Tom Tromey  <tom@tromey.com>
2259
2260         * tui/tui.c (tui_rl_other_window, tui_enable)
2261         (tui_is_window_visible, tui_get_command_dimension): Update.
2262         * tui/tui-winsource.c (tui_update_source_window_as_is)
2263         (tui_clear_source_content, tui_erase_source_content)
2264         (tui_show_source_line, tui_source_window_base::refill)
2265         (tui_source_window_base::do_scroll_horizontal)
2266         (tui_source_window_base::set_is_exec_point_at)
2267         (tui_update_breakpoint_info, tui_set_exec_info_content)
2268         (tui_alloc_source_buffer, tui_line_is_displayed)
2269         (tui_addr_is_displayed): Update.
2270         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2271         (tui_check_and_display_highlight_if_needed)
2272         (tui_win_info::make_visible, tui_win_info::refresh)
2273         (tui_refresh_all): Update.
2274         * tui/tui-windata.c (tui_first_data_item_displayed)
2275         (tui_delete_data_content_windows, tui_erase_data_content)
2276         (tui_display_all_data, tui_data_window::refresh_all)
2277         (tui_check_data_values): Update.
2278         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
2279         (tui_set_win_focus_to, tui_win_info::forward_scroll)
2280         (tui_win_info::backward_scroll, tui_refresh_all_win)
2281         (tui_resize_all, tui_set_focus, tui_all_windows_info)
2282         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
2283         (tui_source_window_base::set_new_height)
2284         (tui_data_window::set_new_height)
2285         (make_invisible_and_set_new_height)
2286         (make_visible_with_new_height, new_height_ok)
2287         (parse_scrolling_args): Update.
2288         * tui/tui-stack.c (tui_show_frame_info): Update.
2289         * tui/tui-source.c (tui_set_source_content)
2290         (tui_set_source_content_nil, tui_source_is_displayed)
2291         (tui_source_window::do_scroll_vertical): Update.
2292         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2293         (tui_display_registers_from, tui_display_reg_element_at_line)
2294         (tui_check_register_values, tui_reg_command): Update.
2295         * tui/tui-layout.c (tui_default_win_height)
2296         (show_source_disasm_command, show_data, init_and_make_win)
2297         (show_source_or_disasm_and_command): Update.
2298         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2299         (tui_redisplay_readline, tui_mld_flush)
2300         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
2301         (tui_getc): Update.
2302         * tui/tui-disasm.c (tui_set_disassem_content)
2303         (tui_disasm_window::do_scroll_vertical): Update.
2304         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
2305         Now virtual.
2306         (struct tui_win_info): Derive from tui_gen_win_info.
2307         <~tui_win_info>: Mark as override.
2308         <generic>: Remove member.
2309         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
2310         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
2311         (~tui_data_window, ~tui_win_info)
2312         (tui_free_all_source_wins_content): Update.
2313         * tui/tui-command.c (tui_refresh_cmd_win): Update.
2314
2315 2019-06-25  Tom Tromey  <tom@tromey.com>
2316
2317         * tui/tui-layout.c (init_and_make_win): Use new.
2318         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
2319         destructor, initializers.
2320         (tui_alloc_generic_win_info): Don't declare.
2321         * tui/tui-data.c (_locator): Add argument to constructor.
2322         (source_win, disasm_win): New globals.
2323         (exec_info): Remove.
2324         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
2325         Update.
2326         (tui_alloc_generic_win_info): Remove.
2327         (init_content_element): Use new.
2328         (tui_win_info::tui_win_info): Update.
2329         (free_content_elements) <case DATA_WIN>: Use delete.
2330
2331 2019-06-25  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-wingeneral.c (tui_refresh_win): Update.
2334         * tui/tui-windata.c (tui_first_data_item_displayed)
2335         (tui_delete_data_content_windows): Update.
2336         * tui/tui-win.c (tui_data_window::set_new_height): Update.
2337         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
2338         (tui_display_registers_from, tui_check_register_values): Update.
2339         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
2340         pointer.
2341         * tui/tui-data.c (init_content_element): Update.  Allocate the new
2342         window.
2343         (tui_free_data_content): Update.
2344         (free_content_elements) <case DATA_WIN>: Free the window.
2345
2346 2019-06-25  Tom Tromey  <tom@tromey.com>
2347
2348         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
2349         Update.
2350         * tui/tui-layout.c (make_command_window)
2351         (show_source_disasm_command, show_data, init_and_make_win)
2352         (show_source_or_disasm_and_command): Update.
2353         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
2354         method.
2355         <can_highight, is_highlighted>: Now bool.
2356         (tui_set_win_highlight): Don't declare.
2357         * tui/tui-data.c (tui_set_win_highlight): Remove.
2358
2359 2019-06-25  Tom Tromey  <tom@tromey.com>
2360
2361         * tui/tui-wingeneral.c (make_visible): Remove check of window
2362         type.
2363
2364 2019-06-25  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui-win.c (tui_win_info::max_height)
2367         (tui_cmd_window::max_height): New methods.
2368         (new_height_ok): Call max_height.
2369         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
2370         <max_height>: New method.
2371
2372 2019-06-25  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-win.c (tui_source_window_base::set_new_height)
2375         (tui_data_window::set_new_height): New methods.
2376         (make_invisible_and_set_new_height): Call set_new_height method.
2377         * tui/tui-data.h (struct tui_win_info)
2378         (struct tui_source_window_base, struct tui_data_window)
2379         <set_new_height>: New method.
2380
2381 2019-06-25  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
2384         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
2385         tui_refresh_data_win.
2386         * tui/tui-win.c (tui_source_window_base::refresh_all): New
2387         method.
2388         (tui_refresh_all_win): Call the refresh_all method.
2389         (tui_set_focus): Likewise.
2390         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
2391         (struct tui_source_window_base, struct tui_data_window) <refresh>:
2392         Likewise.
2393
2394 2019-06-25  Tom Tromey  <tom@tromey.com>
2395
2396         * tui/tui-winsource.h (tui_refill_source_window)
2397         (tui_set_is_exec_point_at): Don't declare.
2398         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2399         (tui_source_window_base::refill): Rename from
2400         tui_refill_source_window.
2401         (tui_source_window_base::do_scroll_horizontal): Update.
2402         (tui_source_window_base::set_is_exec_point_at): Rename from
2403         tui_set_is_exec_point_at.
2404         (tui_update_all_breakpoint_info): Update.
2405         * tui/tui-stack.c (tui_show_frame_info): Update.
2406         * tui/tui-layout.c (show_data): Add cast.
2407         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
2408         * tui/tui-data.h (struct tui_source_window_base) <refill,
2409         set_is_exec_point_at>: New methods.
2410         (tui_source_windows, tui_add_to_source_windows): Update types.
2411         (tui_add_to_source_windows): Remove redundant declaration.
2412         * tui/tui-data.c (source_windows): Store tui_source_window_base.
2413         (tui_source_windows): Change return type.
2414         (tui_clear_source_windows_detail): Update.
2415         (tui_add_to_source_windows): Change type of parameter.
2416         (tui_free_all_source_wins_content): Update.
2417
2418 2019-06-25  Tom Tromey  <tom@tromey.com>
2419
2420         * tui/tui-wingeneral.c (tui_win_info::refresh)
2421         (tui_source_window_base::refresh): New methods.
2422         (tui_refresh_all): Call the refresh method.
2423         * tui/tui-data.h (struct tui_win_info)
2424         (struct tui_source_window_base) <refresh>: New method.
2425
2426 2019-06-25  Tom Tromey  <tom@tromey.com>
2427
2428         * tui/tui.h (tui_is_window_visible): Return bool.
2429         * tui/tui.c (tui_is_window_visible): Return bool.
2430         * tui/tui-wingeneral.c (tui_make_window, make_visible)
2431         (tui_make_visible, tui_make_invisible)
2432         (tui_win_info::make_visible)
2433         (tui_source_window_base::make_visible, make_all_visible)
2434         (tui_make_all_visible, tui_make_all_invisible): Update.
2435         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
2436         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
2437         bool.
2438         (struct tui_win_info, struct tui_source_window_base)
2439         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
2440         * tui/tui-data.c (tui_init_generic_part): Update.
2441
2442 2019-06-25  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-wingeneral.c (tui_win_info::make_visible)
2445         (tui_source_window_base::make_visible): New methods.
2446         (make_all_visible): Make method call.
2447         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
2448         (struct tui_source_window_base, struct tui_cmd_window): Override
2449         make_visible.
2450         (tui_win_is_source_type): Don't declare.
2451         * tui/tui-data.c (tui_win_is_source_type): Remove.
2452
2453 2019-06-25  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
2456         NULL check.
2457
2458 2019-06-25  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
2461         Inline constructor.  Add initializers for members.
2462         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
2463         constructors; now inline in class.
2464
2465 2019-06-25  Tom Tromey  <tom@tromey.com>
2466
2467         * tui/tui-regs.c (tui_show_registers): Update.
2468         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
2469         bool.
2470         * tui/tui-data.c (tui_data_window::clear_detail)
2471         (tui_data_window): Update.
2472
2473 2019-06-25  Tom Tromey  <tom@tromey.com>
2474
2475         * tui/tui-windata.c (tui_display_all_data)
2476         (tui_display_data_from_line, tui_display_data_from)
2477         (tui_check_data_values, tui_data_window::do_scroll_vertical):
2478         Update.
2479         * tui/tui-regs.c (tui_last_regs_line_no)
2480         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
2481         (tui_show_registers, tui_show_register_group)
2482         (tui_display_registers_from, tui_display_reg_element_at_line)
2483         (tui_display_registers_from_line, tui_check_register_values)
2484         (tui_reg_next, tui_reg_prev): Update.
2485         * tui/tui-layout.c (tui_set_layout, show_data): Update.
2486         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
2487         tui_data_window.
2488         (struct tui_win_info) <detail>: Remove.  Add new fields from
2489         tui_data_info.
2490         (TUI_DATA_WIN): Add cast.
2491         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
2492         (~tui_data_window): Simplify.
2493
2494 2019-06-25  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-layout.c (show_source_disasm_command)
2497         (show_source_or_disasm_and_command): Update.
2498         * tui/tui-io.c (update_cmdwin_start_line)
2499         (tui_redisplay_readline): Update.
2500         * tui/tui-data.h (struct tui_command_info): Remove.
2501         (struct tui_win_info) <detail>: Remove command_info member.
2502         (struct tui_data_window) <start_line>: New member, from
2503         tui_command_info.
2504         (TUI_CMD_WIN): Add casts.
2505
2506 2019-06-25  Tom Tromey  <tom@tromey.com>
2507
2508         * tui/tui-winsource.c (tui_update_source_window)
2509         (tui_refill_source_window)
2510         (tui_source_window_base::do_scroll_horizontal)
2511         (tui_update_breakpoint_info, tui_set_exec_info_content)
2512         (tui_show_exec_info_content, tui_erase_exec_info_content)
2513         (tui_clear_exec_info_content): Update.
2514         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
2515         Update.
2516         * tui/tui-win.c (make_invisible_and_set_new_height)
2517         (make_visible_with_new_height): Update.
2518         * tui/tui-source.c (tui_set_source_content)
2519         (tui_show_symtab_source): Update.
2520         * tui/tui-layout.c (extract_display_start_addr)
2521         (show_source_disasm_command, show_data)
2522         (make_source_or_disasm_window)
2523         (show_source_or_disasm_and_command): Update.
2524         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
2525         (tui_disasm_window::do_scroll_vertical): Remove shadowing
2526         "gdbarch".
2527         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
2528         to tui_source_window_base.
2529         (struct tui_win_info) <detail>: Remove source_info member.
2530         (struct tui_source_window_base) <has_locator>: Inline.
2531         Move contents from tui_source_info; rename has_locator member to
2532         m_has_locator.
2533         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
2534         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
2535         header file.
2536         (tui_source_window_base::clear_detail, ~tui_source_window_base):
2537         Simplify.
2538         (tui_free_all_source_wins_content): Cast to
2539         tui_source_window_base.
2540
2541 2019-06-25  Tom Tromey  <tom@tromey.com>
2542
2543         * tui/tui-win.c (make_invisible_and_set_new_height)
2544         (make_visible_with_new_height): Call has_locator method.
2545         * tui/tui-layout.c (show_source_disasm_command, show_data)
2546         (show_source_or_disasm_and_command): Update for bool change.
2547         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
2548         (tui_win_info) <has_locator>: New method.
2549         (struct tui_source_window_base) <has_locator>: New method.
2550         (tui_win_has_locator): Don't declare.
2551         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
2552         from tui_win_has_locator.
2553         (tui_source_window_base): Use false, not FALSE.
2554
2555 2019-06-25  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
2558         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
2559         clear_detail method directly.
2560         (tui_clear_win_detail): Remove.
2561
2562 2019-06-25  Tom Tromey  <tom@tromey.com>
2563
2564         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
2565         "this", not TUI_DISASM_WIN.
2566
2567 2019-06-25  Tom Tromey  <tom@tromey.com>
2568
2569         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
2570         declare.
2571         * tui/tui-winsource.c
2572         (tui_source_window_base::do_scroll_horizontal): Rename from
2573         tui_horizontal_source_scroll.
2574         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
2575         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
2576         from tui_vertical_data_scroll.
2577         * tui/tui-win.h (tui_scroll): Don't declare.
2578         * tui/tui-win.c (tui_win_info::forward_scroll)
2579         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
2580         (tui_win_info::right_scroll): Rename and update.
2581         (tui_scroll_forward_command, tui_scroll_backward_command)
2582         (tui_scroll_left_command, tui_scroll_right_command): Update.
2583         (tui_scroll): Remove.
2584         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
2585         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
2586         from tui_vertical_source_scroll.
2587         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
2588         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
2589         from tui_vertical_disassem_scroll.
2590         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
2591         do_scroll_horizontal>: New methods.
2592         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
2593         Likewise.
2594         (struct tui_source_window_base): Add do_scroll_horizontal.
2595         (struct tui_source_window, struct tui_disasm_window): Add
2596         do_scroll_vertical.
2597         (struct tui_data_window, struct tui_cmd_window): Add
2598         do_scroll_horizontal and do_scroll_vertical.
2599         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
2600
2601 2019-06-25  Tom Tromey  <tom@tromey.com>
2602
2603         * tui/tui-data.h (struct tui_source_window_base): New struct.
2604         (struct tui_source_window): Derive from tui_source_window_base.
2605         (struct tui_disasm_window): New struct.
2606         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
2607         from tui_source_window::clear_detail.
2608         (tui_source_window_base): Rename from tui_source_window.
2609         (~tui_source_window_base): Rename from ~tui_source_window.
2610         (tui_alloc_win_info): Create a tui_disasm_window.
2611
2612 2019-06-25  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-data.h (struct tui_source_window)
2615         (struct tui_data_window): Declare destructors.
2616         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
2617         destructors.
2618         (tui_win_info): Simplify.
2619
2620 2019-06-25  Tom Tromey  <tom@tromey.com>
2621
2622         * tui/tui-winsource.c (tui_display_main)
2623         (tui_update_source_windows_with_addr)
2624         (tui_update_all_breakpoint_info): Update.
2625         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2626         (new_height_ok, parse_scrolling_args): Update.
2627         * tui/tui-stack.c (tui_show_frame_info): Update.
2628         * tui/tui-data.h (struct tui_list): Remove.
2629         (tui_source_windows): Return a reference to a std::vector.
2630         * tui/tui-data.c (source_windows): Now a std::vector.
2631         (tui_source_windows): Change return type.
2632         (tui_clear_source_windows): Rewrite.
2633         (tui_clear_source_windows_detail, tui_add_to_source_windows)
2634         (tui_free_all_source_wins_content): Rewrite.
2635
2636 2019-06-25  Tom Tromey  <tom@tromey.com>
2637
2638         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
2639         (struct tui_data_window, struct tui_cmd_window): Declare
2640         clear_detail method.
2641         * tui/tui-data.c (tui_source_window::clear_detail)
2642         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
2643         methods.
2644         (tui_clear_win_detail): Simplify.
2645
2646 2019-06-25  Tom Tromey  <tom@tromey.com>
2647
2648         * tui/tui-layout.c (make_source_window, make_disasm_window)
2649         (make_source_or_disasm_window): Remove win_info_ptr parameter.
2650         Return the new window.
2651         (show_source_disasm_command, show_data)
2652         (show_source_or_disasm_and_command): Update.
2653
2654 2019-06-25  Tom Tromey  <tom@tromey.com>
2655
2656         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
2657         parameter.  Return the new window.
2658         (show_source_disasm_command): Update and remove NULL check.
2659         (show_source_or_disasm_and_command): Update.
2660
2661 2019-06-25  Tom Tromey  <tom@tromey.com>
2662
2663         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
2664
2665 2019-06-25  Tom Tromey  <tom@tromey.com>
2666
2667         * tui/tui-data.h (struct tui_win_info): Make constructor
2668         protected.  Make destructor virtual.  Add initializers.
2669         (tui_source_window, tui_data_window, tui_cmd_window): New
2670         classes.
2671         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
2672         constructor.  Add "type" parameter.
2673         (tui_source_window, tui_data_window, tui_cmd_window): New
2674         constructors.
2675         (tui_alloc_win_info): Instantiate the appropriate subclass.
2676
2677 2019-06-25  Tom Tromey  <tom@tromey.com>
2678
2679         * tui/tui-win.c (tui_resize_all): Use delete.
2680         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
2681         destructor.
2682         (tui_free_window): Don't declare.
2683         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
2684         Update.
2685
2686 2019-06-25  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-data.h (struct tui_win_info): Add constructor.
2689         * tui/tui-data.c (tui_alloc_win_info): Use new.
2690         (tui_free_window): Use delete.
2691
2692 2019-06-22  Tom Tromey  <tom@tromey.com>
2693
2694         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
2695         declare.
2696         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
2697
2698 2019-06-22  Tom Tromey  <tom@tromey.com>
2699
2700         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
2701         declare.
2702         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
2703
2704 2019-06-22  Tom de Vries  <tdevries@suse.de>
2705
2706         * dwarf2read.c (create_addrmap_from_aranges)
2707         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
2708         instead of '%zu'.
2709
2710 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
2711
2712         * dwarf2read.h (dwarf2_section_info_def): Remove.
2713         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
2714         * dwarf2read.c (struct dwo_sections) <types>: Change type to
2715         std::vector<dwarf2_section_info>.
2716         (struct dwo_file) <~dwo_file>: Remove.
2717         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
2718         types field.
2719         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
2720         (dwarf2_read_debug_names): Likewise.
2721         (create_debug_types_hash_table): Change parameter type to
2722         array_view, adjust code accordingly.
2723         (dwarf2_locate_dwo_sections): Adjust to std::vector.
2724         (partial_die_info::fixup): Likewise.
2725         (determine_prefix): Likewise.
2726         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
2727
2728 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2729
2730         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
2731         gdb_bfd_ref_ptr.
2732         <~dwo_file>: Remove call to gdb_bfd_unref.
2733         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
2734         gdb_bfd_ref_ptr::get.
2735
2736 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2737
2738         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
2739         type to htab_up.
2740         * dwarf2read.c (struct dwo_file): Initialize fields.
2741         <~dwo_file>: New.
2742         (free_dwo_file): Remove, move content to ~dwo_file.
2743         (struct dwo_file_deleter): Remove.
2744         (dwo_file_up>: Remove custom deleter.
2745         (free_dwo_files): Remove.
2746         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
2747         dwo_files.
2748         (process_skeletonless_type_units): Call unique_ptr::get.
2749         (allocate_dwo_file_hash_table): Add deleter to created hash
2750         table.  Change return type to htab_up.
2751         (lookup_dwo_file_slot): Don't memset dwo_file, call
2752         unique_ptr::get.
2753         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
2754         (create_dwo_unit_in_dwp_v2): Likewise.
2755         (open_and_init_dwo_file): Likewise.
2756         (free_dwo_file_from_slot): Remove.
2757
2758 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
2759
2760         * dwarf2read.h (struct dwarf2_section_info) <readin,
2761         is_virtual>: Change type to bool.
2762         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
2763         true instead of 1.
2764
2765 2019-06-19  Tom Tromey  <tom@tromey.com>
2766
2767         * tui/tui-data.h (tui_init_content_element): Don't declare.
2768
2769 2019-06-19  Tom Tromey  <tom@tromey.com>
2770
2771         * tui/tui-data.h (tui_init_win_info): Don't declare.
2772
2773 2019-06-19  Tom de Vries  <tdevries@suse.de>
2774
2775         * dwarf2read.h (abstract_to_concrete): Change type to
2776         std::unordered_map<sect_offset, std::vector<sect_offset>,
2777         gdb::hash_enum<sect_offset>>.
2778
2779 2019-06-19  Tom Tromey  <tromey@adacore.com>
2780
2781         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
2782         EVAL_AVOID_SIDE_EFFECTS specially.
2783
2784 2019-06-19  Tom Tromey  <tromey@adacore.com>
2785
2786         * source-cache.c (highlighter): New global.
2787         (source_cache::get_source_lines): Create a highlighter on demand.
2788
2789 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * defs.h (deprecated_interactive_hook): Delete declaration.
2792         * interps.c (clear_interpreter_hooks): Remove use of
2793         deprecated_interactive_hook.
2794         * top.c (deprecated_interactive_hook): Delete definition.
2795         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2796
2797 2019-06-18  Tom de Vries  <tdevries@suse.de>
2798
2799         PR gdb/24515
2800         * dwarf2read.h (abstract_to_concrete): Change type from
2801         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2802         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2803         * dwarf2read.c (read_variable): Update.
2804         (dwarf2_fetch_die_loc_sect_off): Update.
2805
2806 2019-06-17  Tom de Vries  <tdevries@suse.de>
2807
2808         PR gdb/24617
2809         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2810         accessing parent[parent_len - 1].
2811
2812 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2813
2814         PR gdb/24364
2815         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2816         call dtrace_process_dof with NULL dof.
2817
2818 2019-06-16  Tom de Vries  <tdevries@suse.de>
2819
2820         PR gdb/24445
2821         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2822
2823 2019-06-16  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2826         (make_all_visible): Use address of member.
2827
2828 2019-06-16  Tom Tromey  <tom@tromey.com>
2829
2830         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2831         (tui_free_window, free_content, free_content_elements): Remove
2832         unnecessary cast.
2833         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2834         cast.
2835         * tui/tui-regs.c (tui_show_register_group)
2836         (tui_display_registers_from, tui_display_reg_element_at_line):
2837         Remove unnecessary cast.
2838
2839 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2840
2841         * linux-nat.c (normal_mask): Delete.
2842         (_initialize_linux_nat): Don't initialise normal_mask.
2843
2844 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2845
2846         PR gdb/24445
2847         * dwarf-index-write.h (write_psymtabs_to_index): Add
2848         dwz_basename parameter.
2849         * dwarf-index-write.c (write_gdbindex): Move file writing to
2850         write_gdbindex_1.  Change return type void.
2851         (assert_file_size): Move up, remove filename parameter.
2852         (write_gdbindex_1): New function.
2853         (write_debug_names): Change return type to void, call
2854         assert_file_size.
2855         (struct index_wip_file): New struct.
2856         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2857         file logic to index_wip_file.  Write index for dwz file if
2858         needed.
2859         (save_gdb_index_command): Pass basename of dwz file, if present.
2860         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2861         build-id of dwz file, if present.
2862         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2863         (dwarf2_get_dwz_file): Likewise.
2864         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2865         (dwarf2_get_dwz_file): Likewise.
2866
2867 2019-06-16  Tom Tromey  <tom@tromey.com>
2868
2869         * coffread.c (process_coff_symbol): Use xstrdup.
2870         * value.c (create_internalvar): Use xstrdup.
2871
2872 2019-06-16  Tom Tromey  <tom@tromey.com>
2873
2874         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2875         * breakpoint.c (stopin_command, stopat_command)
2876         (until_break_command, decode_location_default): Remove unnecessary
2877         cast.
2878         * utils.c (subset_compare): Remove unnecessary cast.
2879         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2880         cast.
2881         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2882         cast.
2883         * infcmd.c (path_command): Remove unnecessary cast.
2884         * coffread.c (decode_type): Remove unnecessary cast.
2885         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2886         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2887         * tui/tui-stack.c (tui_show_locator_content)
2888         (tui_show_frame_info): Remove unnecessary cast.
2889         * tui/tui-win.c (tui_scroll_forward_command)
2890         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2891         (parse_scrolling_args): Remove unnecessary cast.
2892         * tui/tui-data.c (init_win_info, tui_del_window)
2893         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2894         (free_content_elements): Remove unnecessary cast.
2895         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2896         unnecessary cast.
2897         * tui/tui-source.c (tui_set_source_content)
2898         (tui_vertical_source_scroll): Remove unnecessary cast.
2899         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2900         cast.
2901         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2902         * tui/tui-regs.c (tui_display_registers_from)
2903         (tui_display_register): Remove unnecessary cast.
2904         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2905         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2906         (make_visible): Remove unnecessary cast.
2907         * tui/tui-winsource.c (tui_erase_source_content)
2908         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2909         unnecessary cast.
2910         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2911         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2912         * stabsread.c (read_type, read_array_type, read_range_type):
2913         Remove unnecessary cast.
2914         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2915         (parse_symbol, parse_type, upgrade_type, parse_external)
2916         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2917         unnecessary cast.
2918         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2919
2920 2019-06-16  Tom Tromey  <tom@tromey.com>
2921
2922         * tui/tui-data.c (tui_alloc_generic_win_info)
2923         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2924         checks.
2925
2926 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2927             Andrew Burgess  <andrew.burgess@embecosm.com>
2928
2929         * f-typeprint.c (f_print_type): Don't return early for not
2930         associated or not allocated types.
2931         (f_type_print_varspec_suffix): Add print_rank parameter and print
2932         ranks of array types in case they dangling.
2933         (f_type_print_base): Add print_rank parameter.
2934
2935 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2936
2937         * NEWS: Mention new MI commands.
2938         * break-catch-throw.c (enum exception_event_kind): Move to
2939         breakpoint.h.
2940         (print_mention_exception_catchpoint): Output text as a single
2941         message.
2942         (catch_exception_command_1): Rename to...
2943         (catch_exception_event): ...this, make non-static, update header
2944         command, and change some parameter types.
2945         (catch_catch_command): Update for changes to
2946         catch_exception_command_1.
2947         (catch_throw_command): Likewise.
2948         (catch_rethrow_command): Likewise.
2949         * breakpoint.c (enum exception_event_kind): Delete.
2950         * breakpoint.h (enum exception_event_kind): Moved here from
2951         break-catch-throw.c.
2952         (catch_exception_event): Declare.
2953         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2954         (mi_cmd_catch_throw): New function.
2955         (mi_cmd_catch_rethrow): New function.
2956         (mi_cmd_catch_catch): New function.
2957         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2958         'catch-catch' entries.
2959         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2960         (mi_cmd_catch_rethrow): Declare.
2961         (mi_cmd_catch_catch): Declare.
2962
2963 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2964
2965         * annotate.c (annotate_source_line): Change return type to void,
2966         update implementation to match.
2967         * annotate.h (annotate_source_line): Change return type to void,
2968         update header comment.
2969         * stack.c (print_frame_info): Don't change what frame information
2970         is printed based on whether annotations are on or not.
2971
2972 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2973
2974         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2975         (annotate_source): Make static.
2976         (annotate_source_line): Moved from source.c and renamed from
2977         identify_source_line.  Update the return type.
2978         * annotate.h (annotate_source): Delete declaration.
2979         (annotate_source_line): Declaration moved from source.h, and
2980         renamed from identify_source_line.  Return type updated.
2981         * source.c (identify_source_line): Moved to annotate.c and renamed
2982         to annotate_source_line.
2983         (info_line_command): Remove check of annotation_level.
2984         * source.h (identify_source_line): Move declaration to annotate.h
2985         and rename to annotate_source_line.
2986         * stack.c: Add 'annotate.h' include.
2987         (print_frame_info): Remove check of annotation_level before
2988         calling annotate_source_line.
2989
2990 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * source-cache.c (source_cache::get_plain_source_lines): Use
2993         open_source_file_with_line_charpos instead of just
2994         open_source_file, remove call to find_source_lines.
2995         (source_cache::get_source_lines): Likewise.
2996         * source.c (find_source_lines): Make static.
2997         (get_filename_and_charpos): Renamed into...
2998         (open_source_file_with_line_charpos): ..this along with changes to
2999         return a scoped_fd, and some other minor clean ups.
3000         (identify_source_line): Use open_source_file_with_line_charpos.
3001         (search_command_helper): Use open_source_file_with_line_charpos
3002         instead of just open_source_file, remove call to
3003         find_source_lines.
3004         * source.h (open_source_file_with_line_charpos): Declare new
3005         function.
3006         (find_source_lines): Delete declaration.
3007
3008 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3009
3010         * source.c (get_filename_and_charpos): Remove fullname
3011         parameter.
3012         (identify_source_line): Update call to get_filename_and_charpos.
3013
3014 2019-06-14  Tom Tromey  <tromey@adacore.com>
3015
3016         PR gdb/24502:
3017         * ui-style.h (skip_ansi_escape): Update comment.
3018         * ui-file.h (class no_terminal_escape_file): New class.
3019         * ui-file.c (no_terminal_escape_file::write)
3020         (no_terminal_escape_file::puts): New methods.
3021         * cli/cli-logging.c (handle_redirections): Use
3022         no_terminal_escape_file.
3023
3024 2019-06-14  Tom Tromey  <tromey@adacore.com>
3025
3026         * NEWS: Move convenience variable news above Python news.
3027
3028 2019-06-14  Tom Tromey  <tom@tromey.com>
3029
3030         * gnulib: Move directory to top-level.
3031         * configure.ac: Don't configure gnulib.
3032         * configure: Rebuild.
3033         * common/common-defs.h: Use new path to gnulib.
3034         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
3035         (GNULIB_H): Remove.
3036         (INCGNU): Look in new gnulib location.
3037         (HFILES_NO_SRCDIR): Remove gnulib files.
3038         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
3039         (generated_files): Remove GNULIB_H.
3040         ($(LIBGNU), all-lib): Remove targets.
3041         (distclean): Don't mention GNULIB_BUILDDIR.
3042         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
3043
3044 2019-06-14  Tom Tromey  <tromey@adacore.com>
3045
3046         * symfile.c (add_symbol_file_command): Remove obsolete comment.
3047         Warn if symbol file does not provide any symbols.
3048
3049 2019-06-14  Tom Tromey  <tromey@adacore.com>
3050
3051         * source.c (find_and_open_source): Respect basenames_may_differ.
3052
3053 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
3054
3055         * annotate.c (annotate_breakpoints_invalid): Make use of
3056         scoped_restore_terminal_state.
3057         (annotate_frames_invalid): Likewise.
3058
3059 2019-06-14  Tom Tromey  <tromey@adacore.com>
3060
3061         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
3062         allow assignment to an internalvar.
3063
3064 2019-06-14  Tom Tromey  <tromey@adacore.com>
3065
3066         * ada-lex.l: Allow "_" in attribute names.
3067
3068 2019-06-14  Tom Tromey  <tromey@adacore.com>
3069
3070         PR gdb/24653:
3071         * regcache.c (registers_changed): Don't call alloca.
3072         * top.c (execute_command): Don't call alloca.
3073
3074 2019-06-13  Pedro Alves  <palves@redhat.com>
3075
3076         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
3077         'expression'.  When parsing an expression, error out if there's
3078         junk after "unlimited".
3079         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3080         (do_set_command): Adjust calls to is_unlimited_literal.
3081
3082 2019-06-13  Pedro Alves  <palves@redhat.com>
3083
3084         * compile/compile.c (make_compile_options_def_group): Add braces
3085         around array_view initializer.
3086         * thread.c (make_thread_apply_all_options_def_group)
3087         (make_thread_apply_all_options_def_group): Likewise.
3088
3089 2019-06-13  Pedro Alves  <palves@redhat.com>
3090
3091         * NEWS (New commands): Mention "maint test-options
3092         require-delimiter", "maint test-options unknown-is-error", "maint
3093         test-options unknown-is-operand" and "maint show
3094         test-options-completion-result".
3095         (New command options, command completion): New section.
3096         (Completion improvements): New section.
3097         Mention that you can abbreviate "unlimited".
3098
3099 2019-06-13  Pedro Alves  <palves@redhat.com>
3100
3101         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
3102         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
3103         * unittests/cli-utils-selftests.c (test_parse_flags)
3104         (test_parse_flags_qcs): Delete.
3105         (test_cli_utils): Don't call deleted functions.
3106
3107 2019-06-13  Pedro Alves  <palves@redhat.com>
3108
3109         * thread.c: Include "cli/cli-option.h".
3110         (tp_array_compar_ascending): Global.
3111         (tp_array_compar): Delete function.
3112         (tp_array_compar_ascending, tp_array_compar_descending): New
3113         functions.
3114         (ascending_option_def, qcs_flag_option_def)
3115         (thr_qcs_flags_option_defs)
3116         (make_thread_apply_all_options_def_group)
3117         (make_thread_apply_options_def_group): New.
3118         (thread_apply_all_command): Use gdb::option::process_options.
3119         (thread_apply_command_completer)
3120         (thread_apply_all_command_completer): New.
3121         (thread_apply_command): Use gdb::option::process_options.
3122         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
3123         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
3124         to generate help text of "thread apply".  Adjust "taas"'s help.
3125         * tid-parse.c (tid_range_parser::in_thread_range): New method.
3126         * tid-parse.h (tid_range_parser::in_thread_range): New method.
3127
3128 2019-06-13  Pedro Alves  <palves@redhat.com>
3129
3130         * thread.c (thread_apply_command): Check for invalid TID with
3131         isdigit instead of !isalpha.
3132
3133 2019-06-13  Pedro Alves  <palves@redhat.com>
3134
3135         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
3136         (validate_flags_qcs): New.
3137         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
3138         (validate_flags_qcs): Declare.
3139         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
3140         (make_frame_apply_options_def_group): New.
3141         (frame_apply_command_count): Process options with
3142         gdb::option::process_options.
3143         (frame_apply_completer): New.
3144         (frame_apply_level_completer, frame_apply_all_completer)
3145         (frame_apply_completer): New.
3146         (_initialize_stack): Update help of "frame apply", "frame apply
3147         level", "frame apply all" and "faas" to mention supported options
3148         and install command completers.
3149         * stack.h (frame_apply_all_completer): Declare.
3150         * thread.c: Include "stack.h".
3151         (tfaas_command): Add "--".
3152         (_initialize_thread): Update help "tfaas" to mention supported
3153         options and install command completer.
3154
3155 2019-06-13  Pedro Alves  <palves@redhat.com>
3156
3157         * completer.c (complete_nested_command_line): New.
3158         (gdb_completion_word_break_characters_throw): Add assertion.
3159         * completer.h (complete_nested_command_line): Declare.
3160
3161 2019-06-13  Pedro Alves  <palves@redhat.com>
3162
3163         * stack.c (parse_backtrace_qualifiers): New.
3164         (backtrace_command): Use it.
3165         (backtrace_command_completer): Complete on qualifiers.
3166
3167 2019-06-13  Pedro Alves  <palves@redhat.com>
3168
3169         * frame.c: Include "cli/cli-option.h.
3170         (user_set_backtrace_options): New.
3171         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
3172         Delete.
3173         (get_prev_frame): Adjust.
3174         (boolean_option_def, uinteger_option_def)
3175         (set_backtrace_option_defs): New.
3176         (_initialize_frame): Adjust and use
3177         gdb::option::add_setshow_cmds_for_options to install "set
3178         backtrace past-main" and "set backtrace past-entry".
3179         * frame.h: Include "cli/cli-option.h".
3180         (struct frame_print_options): Forward declare.
3181         (print_frame_arguments_all, print_frame_arguments_scalars)
3182         (print_frame_arguments_none): Declare.
3183         (print_entry_values): Delete declaration.
3184         (struct frame_print_options, user_frame_print_options): New.
3185         (struct set_backtrace_options): New.
3186         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
3187         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
3188         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
3189         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
3190         (list_args_or_locals): Add frame_print_options parameter.
3191         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3192         * python/py-framefilter.c (enumerate_args): Pass down
3193         USER_FRAME_PRINT_OPTIONS.
3194         * stack.c: Include "cli/cli-option.h".
3195         (print_frame_arguments_all, print_frame_arguments_scalars)
3196         (print_frame_arguments_none): Declare.
3197         (print_raw_frame_arguments, print_entry_values): Delete.
3198         (user_frame_print_options): New.
3199         (boolean_option_def, enum_option_def, frame_print_option_defs):
3200         New.
3201         (struct backtrace_cmd_options): New.
3202         (bt_flag_option_def): New.
3203         (backtrace_command_option_defs): New.
3204         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
3205         (print_frame_arg, read_frame_arg, print_frame_args)
3206         (print_frame_info, print_frame): Add frame_print_options parameter
3207         and use it.
3208         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
3209         (backtrace_command_1): Add frame_print_options and
3210         backtrace_cmd_options parameters and use them.
3211         (make_backtrace_options_def_group): New.
3212         (backtrace_command): Process command options with
3213         gdb::option::process_options.
3214         (backtrace_command_completer): New.
3215         (_initialize_stack): Extend "backtrace"'s help to mention
3216         supported options.  Install completer for "backtrace".
3217         Install some settings commands with add_setshow_cmds_for_options.
3218
3219 2019-06-13  Pedro Alves  <palves@redhat.com>
3220
3221         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
3222         and that "set/show print raw frame-arguments" are now deprecated.
3223
3224         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
3225         command.
3226         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
3227         * stack.c (_initialize_stack): Install "set/show print
3228         raw-frame-arguments", and deprecate "set/show print raw
3229         frame-arguments".
3230         * valprint.c (_initialize_valprint): Deprecate "set/show print
3231         raw".
3232
3233 2019-06-13  Pedro Alves  <palves@redhat.com>
3234
3235         * compile/compile.c (struct compile_options): New.
3236         (compile_flag_option_def, compile_command_option_defs)
3237         (make_compile_options_def_group): New.
3238         (compile_file_command): Handle options with
3239         gdb::option::process_options.
3240         (compile_file_command_completer): New function.
3241         (compile_code_command): Handle options with
3242         gdb::option::process_options.
3243         (compile_code_command_completer): New function.
3244         (_initialize_compiler): Install completers for "compile code" and
3245         "compile file".  Mention available options in "compile code" and
3246         "compile code"'s help.
3247         * completer.c (advance_to_completion_word): New, factored out from
3248         ...
3249         (advance_to_expression_complete_word_point): ... this.
3250         (advance_to_filename_complete_word_point): New.
3251         * completer.h (advance_to_filename_complete_word_point): New
3252         declaration.
3253
3254 2019-06-13  Pedro Alves  <palves@redhat.com>
3255
3256         * compile/compile.c: Include "cli/cli-option.h".
3257         (compile_print_value): Scope data pointer is now a
3258         value_print_options pointer; adjust.
3259         (compile_print_command): Process options.  Scope data pointer is
3260         now a value_print_options pointer; adjust.
3261         (_initialize_compile): Update "compile print"'s help to include
3262         supported options.  Install a completer for "compile print".
3263         * cp-valprint.c (show_vtblprint, show_objectprint)
3264         (show_static_field_print): Delete.
3265         (_initialize_cp_valprint): Don't install "set print
3266         static-members", "set print vtbl", "set print object" here.
3267         * printcmd.c: Include "cli/cli-option.h" and
3268         "common/gdb_optional.h".
3269         (print_command_parse_format): Rework to fill in a
3270         value_print_options instead of a format_data.
3271         (print_value): Change parameter type from format_data pointer to
3272         value_print_options reference.  Adjust.
3273         (print_command_1): Process options.  Adjust to pass down a
3274         value_print_options.
3275         (print_command_completer): New.
3276         (_initialize_printcmd): Install print_command_completer as
3277         handle_brkchars completer for the "print" command.  Update
3278         "print"'s help to include supported options.
3279         * valprint.c: Include "cli/cli-option.h".
3280         (show_vtblprint, show_objectprint, show_static_field_print): Moved
3281         here from cp-valprint.c.
3282         (boolean_option_def, uinteger_option_def)
3283         (value_print_option_defs, make_value_print_options_def_group):
3284         New.  Use gdb::option::add_setshow_cmds_for_options to install
3285         "set print elements", "set print null-stop", "set print repeats",
3286         "set print pretty", "set print union", "set print array", "set
3287         print address", "set print symbol", "set print array-indexes".
3288         * valprint.h: Include <string> and "cli/cli-option.h".
3289         (make_value_print_options_def_group): Declare.
3290         (print_value): Change parameter type from format_data pointer to
3291         value_print_options reference.
3292         (print_command_completer): Declare.
3293
3294 2019-06-13  Pedro Alves  <palves@redhat.com>
3295
3296         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
3297         (COMMON_SFILES): Add maint-test-settings.c.
3298         * cli/cli-decode.c (boolean_enums): New global, factored out from
3299         ...
3300         (add_setshow_boolean_cmd): ... here.
3301         * cli/cli-decode.h (boolean_enums): Declare.
3302         * cli/cli-option.c: New file.
3303         * cli/cli-option.h: New file.
3304         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
3305         factored out from ...
3306         (parse_cli_boolean_value(const char *)): ... this.
3307         (is_unlimited_literal): Change parameter type to pointer to
3308         pointer.  Adjust and advance ARG pointer.
3309         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3310         (parse_cli_var_enum): New, factored out from ...
3311         (do_set_command): ... this.  Adjust.
3312         * cli/cli-setshow.h (parse_cli_boolean_value)
3313         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
3314         (parse_cli_var_enum): Declare.
3315         * cli/cli-utils.c: Include "cli/cli-option.h".
3316         (get_ulongest): New.
3317         * cli/cli-utils.h (get_ulongest): Declare.
3318         (check_for_argument): New overloads.
3319         * maint-test-options.c: New file.
3320
3321 2019-06-13  Pedro Alves  <palves@redhat.com>
3322
3323         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
3324         parse a range if "-" is at the end of the string.
3325
3326 2019-06-13  Pedro Alves  <palves@redhat.com>
3327
3328         * cli/cli-setshow.c (parse_auto_binary_operation)
3329         (parse_cli_boolean_value): Don't allow "o".
3330
3331 2019-06-13  Pedro Alves  <palves@redhat.com>
3332
3333         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
3334         * NEWS: Mention maint test-settings KIND.
3335         * maint-test-settings.c: New file.
3336
3337 2019-06-13  Pedro Alves  <palves@redhat.com>
3338
3339         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
3340         completer.
3341         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
3342         "set" completers.
3343
3344 2019-06-13  Pedro Alves  <palves@redhat.com>
3345
3346         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
3347         after item.
3348
3349 2019-06-13  Pedro Alves  <palves@redhat.com>
3350
3351         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
3352
3353 2019-06-13  Pedro Alves <palves@redhat.com>
3354
3355         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
3356         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
3357         call.
3358         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
3359         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
3360         calls.
3361         (check_for_argument): Skip spaces after argument.
3362
3363 2019-06-13  Pedro Alves  <palves@redhat.com>
3364
3365         * thread.c (thread_apply_command): Adjust TID parsing.
3366         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
3367         detected before end of string.
3368         (tid_is_in_list): Error out if LIST is invalid.
3369
3370 2019-06-13  Pedro Alves  <palves@redhat.com>
3371
3372         * completer.c (complete_line_internal_1): Rewind completion word
3373         point.
3374         (completion_tracker::advance_custom_word_point_by): Change
3375         parameter type to int.
3376         * completer.h (completion_tracker::advance_custom_word_point_by):
3377         Likewise.
3378
3379 2019-06-13  Pedro Alves  <palves@redhat.com>
3380
3381         * completer.c (advance_to_completion_word): Handle delimiters.
3382
3383 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
3384
3385         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
3386
3387 2019-06-11  Tom Tromey  <tom@tromey.com>
3388
3389         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
3390         (xmalloc_failed): Move to alloc.c.
3391         * alloc.c: New file.
3392         * Makefile.in (COMMON_SFILES): Add alloc.c.
3393
3394 2019-06-11  Tom Tromey  <tom@tromey.com>
3395
3396         * nat/linux-waitpid.c: Don't include server.h.
3397         (linux_debug): Remove.
3398         (my_waitpid): Update.
3399
3400 2019-06-11  Tom Tromey  <tromey@adacore.com>
3401
3402         * infcall.c (_initialize_infcall): Remove trailing newline from
3403         help.
3404         * user-regs.c (_initialize_user_regs): Remove trailing newline
3405         from help.
3406         * typeprint.c (_initialize_typeprint): Remove trailing newline
3407         from help.
3408         * reverse.c (_initialize_reverse): Remove trailing newlines from
3409         help.
3410         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
3411         from help.
3412         * language.c (add_set_language_command): Remove trailing newline
3413         from help.
3414         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
3415         help.
3416         * disasm.c (_initialize_disasm): Remove trailing newline from
3417         help.
3418         * top.c (init_main): Remove trailing newline from help.
3419         * interps.c (_initialize_interpreter): Remove trailing newline
3420         from help.
3421         * btrace.c (_initialize_btrace): Remove trailing newlines from
3422         help.
3423         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
3424         from help.
3425         * python/python.c (_initialize_python): Remove trailing newline
3426         from help.
3427         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
3428         help.
3429         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
3430         from help.  Reformat some text.
3431         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
3432         from help.
3433         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
3434         newline from help.
3435
3436 2019-06-11  Tom Tromey  <tromey@adacore.com>
3437
3438         * darwin-nat.c (darwin_decode_exception_message)
3439         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
3440
3441 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * valops.c (value_slice): Check for not allocated or not
3444         associated values.
3445
3446 2019-06-10  Tom de Vries  <tdevries@suse.de>
3447
3448         PR gdb/24618
3449         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
3450         sure an empty slot (defined by a 32-bit zero pair) is recognized as
3451         invalid.
3452
3453 2019-06-10  Tom de Vries  <tdevries@suse.de>
3454
3455         PR gdb/24611
3456         * linespec.c (linespec_lexer_lex_string): Remove incorrect
3457         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
3458
3459 2019-06-10  Tom de Vries  <tdevries@suse.de>
3460
3461         PR symtab/24545
3462         * symtab.c (struct demangled_name_entry): Add language field.
3463         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
3464         static minimal symbol".  Set and use language field.
3465
3466 2019-06-10  Tom Tromey  <tromey@adacore.com>
3467
3468         * ada-lang.c (_initialize_ada_language): Update help text.
3469
3470 2019-06-10  Tom Tromey  <tromey@adacore.com>
3471
3472         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
3473         with a newline.
3474         * guile/guile.c (handle_boot_error): Don't end warning with a
3475         newline.
3476         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
3477         warning with a newline.
3478         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
3479         newline.
3480         (s12z_frame_cache): Likewise.
3481         * dwarf-index-cache.c (index_cache::store): Don't end warning with
3482         a newline.
3483         * solib-svr4.c (disable_probes_interface): Don't end warning with
3484         a newline.
3485         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
3486         newline.
3487         * python/python.c (do_finish_initialization): Don't end warning
3488         with a newline.
3489
3490 2019-06-10  Tom Tromey  <tom@tromey.com>
3491
3492         * python/py-breakpoint.c (gdbpy_breakpoint_created)
3493         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
3494         gdbpy_enter.
3495
3496 2019-06-10  Tom Tromey  <tromey@adacore.com>
3497
3498         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
3499         data.
3500         (elf_new_init): Don't call stabsread_new_init.
3501         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
3502         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
3503         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
3504
3505 2019-06-10  Tom de Vries  <tdevries@suse.de>
3506
3507         PR symtab/16264
3508         PR symtab/24517
3509         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
3510
3511 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
3512
3513         * source.c (find_and_open_source): Also rewrite relative file
3514         names.
3515
3516 2019-04-26  Amos Bird  <amosbird@gmail.com>
3517
3518         * annotate.c (annotate_thread_exited): Add "thread-exited"
3519         annotation.
3520
3521 2019-06-06  Tom Tromey  <tromey@adacore.com>
3522
3523         * maint.h (class scoped_command_stats): Use
3524         DISABLE_COPY_AND_ASSIGN.
3525         <print_time>: New method.
3526         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
3527         print_time.
3528         (scoped_command_stats::print_time): New method.
3529
3530 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
3531
3532         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
3533         instructions of lengths 6 or 8 bytes.
3534
3535 2019-06-04  Pedro Alves  <palves@redhat.com>
3536
3537         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
3538
3539         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
3540         * breakpoint.c (condition_completer): Likewise.
3541         * cli/cli-dump.c (scan_expression): Likewise.
3542         * common/filestuff.c (mkdir_recursive): Likewise.
3543         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
3544         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
3545         (gdb_abspath): Likewise.
3546         * compile/compile-cplus-types.c
3547         (compile_cplus_instance::decl_name): Likewise.
3548         * completer.c (complete_explicit_location):
3549         (signal_completer, reg_or_group_completer_1): Likewise.
3550         * cp-support.c (cp_remove_params_if_any): Likewise.
3551         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
3552         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
3553         * infcmd.c (strip_bg_char): Likewise.
3554         * linespec.c (copy_token_string): Likewise.
3555         * mi/mi-main.c (output_cores): Likewise.
3556         * psymtab.c (psymtab_search_name):
3557         * symfile.c (test_set_ext_lang_command): Likewise.
3558         * target.c (target_fileio_read_stralloc): Likewise.
3559         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
3560         * value.c (complete_internalvar): Likewise.
3561
3562 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
3563
3564         Add objfile property to gdb.Type.
3565         * NEWS: Mention Python API addition.
3566         * python/py-type.c (typy_get_objfile): New method.
3567
3568 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3569
3570         * NEWS: Mention the new set|show style [title|highlight].
3571         Mention changes to "show style", "help" and "apropos".
3572
3573 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3574
3575         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
3576         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
3577         instead of print_help_for_command.
3578         (print_doc_of_command): New function.
3579         (help_list): Add 'apropos -v word' suggestion.
3580         (print_help_for_command): Style the command name using title style.
3581         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
3582         (_initialize_cli_cmds): Describe -v in apropos_command help.
3583
3584 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3585
3586         * cli/cli-style.h (cli_style_option): Add name in constructor,
3587         add m_name class member, add constructor with intensity,
3588         add name class function.
3589         (cli_style_option::add_setshow_commands): Remove name argument.
3590         (highlight_style, title_style): New styles.
3591         * cli/cli-style.c (do_show): New function that shows a style
3592         characteristic styling the style name with itself.
3593         (set_style_name): New function.
3594         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
3595         Update all callers according to the changes in cli/cli-style.h.
3596         * utils.h (fputs_highlighted): New function.
3597         * utils.c (fputs_highlighted): Likewise.
3598
3599 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3600
3601         * NEWS: Mention new pipe command and new convenience variables.
3602
3603 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3604
3605         * cli/cli-cmds.c (pipe_command): New function.
3606         (_initialize_cli_cmds): Call add_com for pipe_command.
3607         Define | as an alias for pipe.
3608         (exit_status_set_internal_vars): New function.
3609         (shell_escape): Call exit_status_set_internal_vars.
3610         cli/cli-decode.c (find_command_name_length): Recognize | as
3611         a single character command.
3612
3613 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3614
3615         * gdbcmd.h (execute_command_to_ui_file): New declaration.
3616         top.c (execute_command_to_ui_file): New function, mostly a copy
3617         of execute_command_to_string.
3618         (execute_command_to_string): Implement by calling
3619         execute_command_to_ui_file.
3620
3621 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3622
3623         * top.h (saved_command_line): Remove declaration.
3624         * top.c (previous_saved_command_line, previous_repeat_arguments):
3625         New variables.
3626         (saved_command_line): Make static, define together with other
3627         'repeat variables'.
3628         (dont_repeat): Clear repeat_arguments.
3629         (repeat_previous, get_saved_command_line, save_command_line):
3630         New functions.
3631         (gdb_init): Initialize saved_command_line
3632         and previous_saved_command_line.
3633         * main.c (captured_main_1): Remove saved_command_line initialization.
3634         * event-top.c (handle_line_of_input): Update to use
3635         the new 'repeat' related functions instead of direct access to
3636         saved_command_line.
3637         * command.h (repeat_previous, get_saved_command_line,
3638         save_command_line): New declarations.
3639         (dont_repeat): Add comment.
3640
3641 2019-05-30  Tom Tromey  <tromey@adacore.com>
3642
3643         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
3644         Fix comment.
3645         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
3646
3647 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
3648
3649         PR cli/24587
3650         * completer.c (complete): Initialize variable word.
3651
3652 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
3653
3654         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3655         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
3656         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
3657         'body' is NULL to the outter 'if', protecting the '!is_define'
3658         situation as well.
3659
3660 2019-05-29  Tom Tromey  <tromey@adacore.com>
3661
3662         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
3663         (dwarf_unknown): New function.
3664         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
3665         (dwarf_type_encoding_name): Use dwarf_unknown.
3666
3667 2019-05-29  Tom Tromey  <tromey@adacore.com>
3668
3669         PR c++/20020:
3670         * cp-valprint.c (cp_print_value_fields): Call
3671         cp_print_static_field inside "try".
3672
3673 2019-05-29  Tom Tromey  <tromey@adacore.com>
3674
3675         * inflow.c (struct terminal_info): Add default operator=.
3676         * configure: Rebuild.
3677         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
3678         -Wdeprecated-copy-dtor, -Wredundant-move.
3679
3680 2019-05-29  Tom Tromey  <tromey@adacore.com>
3681
3682         * NEWS: Add entry.
3683         * infcmd.c (print_return_value_1): Handle finish_print
3684         option.
3685         (show_print_finish): New function.
3686         (_initialize_infcmd): Add "set/show print finish" commands.
3687         * valprint.c (user_print_options): Initialize new member.
3688         * valprint.h (struct value_print_options) <finish_print>: New
3689         member.
3690
3691 2019-05-28  Tom Tromey  <tromey@adacore.com>
3692
3693         * ada-lang.c (ada_remove_Xbn_suffix)
3694         (find_old_style_renaming_symbol)
3695         (parse_old_style_renaming): Remove.
3696         (ada_find_renaming_symbol): Don't call
3697         find_old_style_renaming_symbol.
3698         (ada_is_renaming_symbol): Rename from
3699         ada_find_renaming_symbol.  Remove "block" parameter.  Return
3700         bool.  Now static.
3701         (ada_read_var_value): Update and simplify.
3702         * ada-exp.y (write_var_or_type): Remove old code.
3703
3704 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
3705
3706         * event-top.c: Remove include comment.
3707         * inflow.c (class scoped_ignore_sigttou): Move from here...
3708         * inflow.h (class scoped_ignore_sigttou): ...to here.
3709         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
3710         * top.c:  Remove include comment.
3711
3712 2019-05-27  Tom Tromey  <tom@tromey.com>
3713
3714         * NEWS: Fix typo.
3715
3716 2019-05-22  Tom Tromey  <tromey@adacore.com>
3717
3718         * target.c (target_follow_exec): Constify parameter.
3719         * target-delegates.c: Rebuild.
3720         * remote.c (remote_target::follow_exec): Constify parameter.
3721         * infrun.c (follow_exec): Constify parameter.
3722         * target.h (struct target_ops) <follow_exec>: Constify parameter.
3723         (target_follow_exec): Likewise.
3724
3725 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3726
3727         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
3728         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
3729
3730 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
3731
3732         * NEWS: Add debugredirect and testsuite sections.
3733
3734 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
3735
3736         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
3737         target descriptions using exclusively floating point register name
3738         aliases.
3739
3740 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3741
3742         PR gdb/18644:
3743         * f-lang.c (build_fortran_types): Handle the case where
3744         gdbarch_floatformat_for_type returns a nullptr.
3745
3746 2019-05-21  Tom de Vries  <tdevries@suse.de>
3747
3748         PR cli/24587
3749         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
3750
3751 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3752
3753         PR gdb/18644:
3754         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
3755         16-byte floats.
3756         * i386-tdep.c (i386_floatformat_for_type): Use
3757         floatformats_ia64_quad for the 16-byte floating point component
3758         within a fortran 32-byte complex number.
3759
3760 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3761
3762         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
3763         delete default constructor.
3764         (find_partial_die): Update to return const struct.
3765         (partial_die_parent_scope): Move variable declaration into scope
3766         of its use and change its type to auto.
3767         (guess_partial_die_structure_name): Likewise.
3768         (partial_die_info::fixup): Likewise.
3769
3770 2019-05-17  Tom Tromey  <tromey@adacore.com>
3771
3772         * source.c (find_and_open_source): Remove cast.
3773
3774 2019-05-17  Tom Tromey  <tromey@adacore.com>
3775
3776         * annotate.c (annotate_source): Make "filename" const.
3777         * annotate.h (annotate_source): Use const.
3778
3779 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3780
3781         * disasm.c (set_disassembler_options): Send errors to stderr.
3782
3783 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3784
3785         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
3786         (cli_interp_base::set_logging): Check debug_redirect.
3787         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
3788         * cli/cli-logging.c (debug_redirect): Add static variable.
3789         (pop_output_files): Add default param.
3790         (handle_redirections): Print debug setting.
3791         (show_logging_command): Likewise.
3792         (_initialize_cli_logging): Add debugredirect command.
3793         * interps.c (current_interp_set_logging): Add debug_redirect
3794         parameter.
3795         * interps.h (set_logging): Add debug_redirect parameter.
3796         (current_interp_set_logging): Likewise.
3797         * mi/mi-common.h: Likewise.
3798         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3799
3800 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3801             Tom Tromey  <tromey@adacore.com>
3802
3803         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3804         directly.
3805         * cli/cli-interp.h (make_logging_output): Remove declaration.
3806         * cli/cli-logging.c (make_logging_output): Remove function.
3807         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3808         directly.
3809         * ui-file.c (tee_file::tee_file): Remove bools.
3810         (tee_file::~tee_file): Remove deletes.
3811         * ui-file.h (tee_file): Remove bools.
3812
3813 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3814
3815         * mi/mi-cmds.h (mi_cmd_complete): New function.
3816         * mi/mi-main.c (mi_cmd_complete): Likewise.
3817         * mi/mi-cmds.c: Define new MI command -complete.
3818         * NEWS: Mention new -complete command.
3819
3820 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3821
3822         * completer.h (complete): New function.
3823         * completer.c (complete): Likewise.
3824         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3825         function defined in completer.h.
3826
3827 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3828
3829         * MAINTAINERS (Write After Approval): Add myself.
3830
3831 2019-05-17  Tom de Vries  <tdevries@suse.de>
3832
3833         PR gdb/24094
3834         * dwarf2read.c (struct cu_partial_die_info): New struct.
3835         (find_partial_die): Return cu_partial_die_info.
3836         (partial_die_parent_scope, guess_partial_die_structure_name)
3837         (partial_die_info::fixup): Handle new return type of find_partial_die.
3838
3839 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3840
3841         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3842         "std::string", simplifying the algorithm.
3843
3844 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3845
3846         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3847         (stap_static_probe_ops::get_probes): Likewise.
3848
3849 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3850
3851         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3852         '-')" and "else if".
3853         (stap_parse_single_operand): Join checks for
3854         "gdbarch_stap_parse_special_token_p" and
3855         "gdbarch_stap_parse_special_token" in the same "if" statement.
3856         Invert check when verifying for operation on register
3857         displacement.
3858
3859 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3860
3861         * stap-probe.c (stap_get_opcode): Update comment.
3862         (stap_get_expected_argument_type): Likewise.
3863         (handle_stap_probe): Likewise.
3864
3865 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3866
3867         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3868         return type to 'bool'.  Adjust comment.  Use 'bool' when
3869         appropriate.
3870         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3871         * stap-probe.c (stap_parse_argument_1): Likewise.
3872         (stap_is_operator): Likewise.
3873         (stap_is_generic_prefix): Likewise.
3874         (stap_is_register_prefix): Likewise.
3875         (stap_is_register_indirection_prefix): Likewise.
3876         (stap_is_integer_prefix): Likewise.
3877         (stap_generic_check_suffix): Likewise.
3878         (stap_check_integer_suffix): Likewise.
3879         (stap_check_register_suffix): Likewise.
3880         (stap_check_register_indirection_suffix): Likewise.
3881         (stap_parse_register_operand): Likewise.
3882         (stap_parse_single_operand): Likewise.
3883         (stap_parse_argument_1): Likewise.
3884         (stap_probe::get_argument_count): Likewise.
3885         (stap_is_operator): Likewise.
3886
3887 2019-05-16  Tom Tromey  <tromey@adacore.com>
3888
3889         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3890         keyword to foreach.
3891
3892 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3893
3894         * linux-thread-db.c (try_thread_db_load_1): Change return type
3895         to bool.
3896         (try_thread_db_load): Likewise.
3897         (try_thread_db_load_from_pdir_1): Likewise.
3898         (try_thread_db_load_from_pdir): Likewise.
3899         (try_thread_db_load_from_sdir): Likewise.
3900         (try_thread_db_load_from_dir): Likewise.
3901         (thread_db_load_search): Likewise.
3902         (has_libpthread): Likewise.
3903         (thread_db_load): Likewise.
3904
3905 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3906
3907         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3908         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3909         NULL, and complain/return if that's the case.
3910
3911 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3912
3913         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3914         (advance, posn, abstract_read_memory): New functions.
3915         [struct mem_read_abstraction]: New struct.
3916         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3917
3918 2019-05-14  Tom Tromey  <tromey@adacore.com>
3919
3920         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3921         value is not lval_memory.
3922
3923 2019-05-14  Tom Tromey  <tromey@adacore.com>
3924
3925         * solib.c (info_sharedlibrary_command): Style the file name.
3926
3927 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3928
3929         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3930         (aarch64_vnv_type): Likewise.
3931         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3932         * common/tdesc.c: Likewise.
3933         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3934         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3935         * features/aarch64-fpu.xml: Add ieee half view.
3936         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3937         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3938         * gdbtypes.h (struct builtin_type): Likewise.
3939         (struct objfile_type): Likewise.
3940
3941 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3942
3943         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3944         typo.
3945         * location.h (string_to_event_location): Likewise.
3946
3947 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3948
3949         GDB 8.3 released.
3950
3951 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3952
3953         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3954         New variable declaration.
3955         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3956         New variable.
3957         (print_one_breakpoint): Use ui_out::test_flags and new global
3958         variable to compute use_fixed_output.
3959         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3960         Remove.
3961         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3962         (mi_multi_location_breakpoint_output_fixed): Remove.
3963         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3964         new variable.
3965         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3966         fix_multi_location_breakpoint_output flag if version >= 3.
3967         * ui-out.h (enum ui_out_flag)
3968         <fix_multi_location_breakpoint_output>: New enumerator.
3969
3970 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3971
3972         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3973
3974 2019-05-10  Tom Tromey  <tromey@adacore.com>
3975
3976         * ada-lang.c (catch_ada_completer): New function.
3977         (_initialize_ada_language): Use it.
3978
3979 2019-05-10  Tom Tromey  <tromey@adacore.com>
3980
3981         * thread.c (print_thread_info): Make "requested_threads" const.
3982         * gdbthread.h (print_thread_info): Make "requested_threads"
3983         const.
3984         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3985         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3986
3987 2019-05-08  Tom Tromey  <tom@tromey.com>
3988
3989         * gdbtypes.c (objfile_type_data): Change type.
3990         (objfile_type, _initialize_gdbtypes): Update.
3991
3992 2019-05-08  Tom Tromey  <tom@tromey.com>
3993
3994         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3995         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3996         (_initialize_dwarf2_frame): Update.
3997
3998 2019-05-08  Tom Tromey  <tom@tromey.com>
3999
4000         * objc-lang.c (objc_objfile_data): Change type.
4001         (find_methods): Update.
4002         (_initialize_objc_lang): Remove.
4003
4004 2019-05-08  Tom Tromey  <tom@tromey.com>
4005
4006         * stabsread.c (rs6000_builtin_type_data): Change type.
4007         (rs6000_builtin_type, _initialize_stabsread): Update.
4008
4009 2019-05-08  Tom Tromey  <tom@tromey.com>
4010
4011         * mips-tdep.c (mips_pdr_data): Remove.
4012         (_initialize_mips_tdep): Update.
4013
4014 2019-05-08  Tom Tromey  <tom@tromey.com>
4015
4016         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
4017         (hppa_init_objfile_priv_data, read_unwind_info)
4018         (find_unwind_entry, _initialize_hppa_tdep): Update.
4019
4020 2019-05-08  Tom Tromey  <tom@tromey.com>
4021
4022         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
4023         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
4024         on obstack.
4025         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
4026
4027 2019-05-08  Tom Tromey  <tom@tromey.com>
4028
4029         * mdebugread.c (basic_type_data): Change type.
4030         (basic_type, _initialize_mdebugread): Update.
4031
4032 2019-05-08  Tom Tromey  <tom@tromey.com>
4033
4034         * common/gdb_unique_ptr.h (struct noop_deleter): New.
4035
4036 2019-05-08  Tom Tromey  <tom@tromey.com>
4037
4038         * nto-tdep.c (nto_inferior_data_reg): Change type.
4039         (nto_inferior_data): Update.
4040         (nto_inferior_data_cleanup, nto_new_inferior_data)
4041         (_initialize_nto_tdep): Remove.
4042         * nto-tdep.h (struct nto_inferior_data): Add initializers.
4043
4044 2019-05-08  Tom Tromey  <tom@tromey.com>
4045
4046         * ada-lang.c (struct ada_inferior_data): Add initializers.
4047         (ada_inferior_data): Change type.
4048         (ada_inferior_data_cleanup): Remove.
4049         (get_ada_inferior_data, ada_inferior_exit)
4050         (struct ada_pspace_data): Add initializers, destructor.
4051         (ada_pspace_data_handle): Change type.
4052         (get_ada_pspace_data): Update.
4053         (ada_pspace_data_cleanup): Remove.
4054
4055 2019-05-08  Tom Tromey  <tom@tromey.com>
4056
4057         * coffread.c (struct coff_symfile_info): Add initializers.
4058         (coff_objfile_data_key): Move lower.  Change type.
4059         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
4060         Update.
4061         (coff_free_info): Remove.
4062
4063 2019-05-08  Tom Tromey  <tom@tromey.com>
4064
4065         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
4066         (fbsd_pspace_data_handle): Move lower.  Change type.
4067         (get_fbsd_pspace_data): Update.
4068         (fbsd_pspace_data_cleanup): Remove.
4069         (_initialize_fbsd_tdep): Update.
4070
4071 2019-05-08  Tom Tromey  <tom@tromey.com>
4072
4073         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
4074         (get_ada_tasks_pspace_data): Update.
4075         (ada_tasks_pspace_data_cleanup): Remove.
4076         (_initialize_tasks): Update.
4077         (ada_tasks_inferior_data_handle): Change type.
4078         (get_ada_tasks_inferior_data): Update.
4079         (ada_tasks_inferior_data_cleanup): Remove.
4080         (struct ada_tasks_pspace_data): Add initializers.
4081
4082 2019-05-08  Tom Tromey  <tom@tromey.com>
4083
4084         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
4085         * symfile-debug.c (debug_sym_get_probes): Change type.
4086         * stap-probe.c (handle_stap_probe):
4087         (stap_static_probe_ops::get_probes): Change type.
4088         * probe.h (class static_probe_ops) <get_probes>: Change type.
4089         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
4090         (parse_probes_in_pspace): Update.
4091         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
4092         Update.
4093         (any_static_probe_ops::get_probes): Change type.
4094         * elfread.c (elfread_data): New typedef.
4095         (probe_key): Change type.
4096         (elf_get_probes): Likewise.  Update.
4097         (probe_key_free): Remove.
4098         (_initialize_elfread): Update.
4099         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
4100         Change type.
4101         (dtrace_process_dof_probe, dtrace_process_dof)
4102         (dtrace_static_probe_ops::get_probe): Change type.
4103
4104 2019-05-08  Tom Tromey  <tom@tromey.com>
4105
4106         * xcoffread.c (struct xcoff_symfile_info): Rename from
4107         coff_symfile_info.  Add initializers.
4108         (xcoff_objfile_data_key): Move lower.  Change type.
4109         (XCOFF_DATA): Rewrite.
4110         (xcoff_free_info): Remove.
4111         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
4112         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
4113         (xcoff_initial_scan): Update.
4114
4115 2019-05-08  Tom Tromey  <tom@tromey.com>
4116
4117         * solib-svr4.c (struct svr4_info): Add initializers and
4118         destructor.
4119         <probes_table>: Now an htab_up.
4120         (solib_svr4_pspace_data): Change type.
4121         (free_probes_table): Simplify.
4122         (~svr4_info): Rename from svr4_pspace_data_cleanup.
4123         (get_svr4_info, probes_table_htab_remove_objfile_probes)
4124         (probes_table_remove_objfile_probes, register_solib_event_probe)
4125         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
4126         (_initialize_svr4_solib): Update.
4127
4128 2019-05-08  Tom Tromey  <tom@tromey.com>
4129
4130         * remote.c (remote_pspace_data): Change type.
4131         (remote_pspace_data_cleanup): Remove.
4132         (get_remote_exec_file, set_pspace_remote_exec_file)
4133         (_initialize_remote): Update.
4134
4135 2019-05-08  Tom Tromey  <tom@tromey.com>
4136
4137         * breakpoint.c (breakpoint_objfile_key): Change type.
4138         (get_breakpoint_objfile_data): Update.
4139         (free_breakpoint_objfile_data): Remove.
4140         (_initialize_breakpoint): Update.
4141
4142 2019-05-08  Tom Tromey  <tom@tromey.com>
4143
4144         * linux-tdep.c (struct linux_info): Add initializers.
4145         (linux_inferior_data): Move.  Change type.
4146         (invalidate_linux_cache_inf): Update.
4147         (linux_inferior_data_cleanup): Remove.
4148         (get_linux_inferior_data, _initialize_linux_tdep): Update.
4149
4150 2019-05-08  Tom Tromey  <tom@tromey.com>
4151
4152         * auxv.c (auxv_inferior_data): Move.  Change type.
4153         (auxv_inferior_data_cleanup): Remove.
4154         (invalidate_auxv_cache_inf): Rewrite.
4155         (get_auxv_inferior_data, _initialize_auxv): Update.
4156
4157 2019-05-08  Tom Tromey  <tom@tromey.com>
4158
4159         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
4160         (symfile_debug_objfile_data_key): Change type.
4161         (symfile_debug_installed, debug_qf_has_symbols)
4162         (debug_qf_find_last_source_symtab)
4163         (debug_qf_forget_cached_source_info)
4164         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
4165         (debug_qf_print_stats, debug_qf_dump)
4166         (debug_qf_expand_symtabs_for_function)
4167         (debug_qf_expand_all_symtabs)
4168         (debug_qf_expand_symtabs_with_fullname)
4169         (debug_qf_map_matching_symbols)
4170         (debug_qf_expand_symtabs_matching)
4171         (debug_qf_find_pc_sect_compunit_symtab)
4172         (debug_qf_map_symbol_filenames)
4173         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
4174         (debug_sym_new_init, debug_sym_init, debug_sym_read)
4175         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
4176         (debug_sym_read_linetable, debug_sym_relocate): Update.
4177         (symfile_debug_free_objfile): Remove.
4178         (install_symfile_debug_logging, _initialize_symfile_debug):
4179         Update.
4180
4181 2019-05-08  Tom Tromey  <tom@tromey.com>
4182
4183         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
4184         allocate_on_obstack.
4185         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
4186         (get_dwarf2_per_objfile): Update.
4187         (set_dwarf2_per_objfile): Remove.
4188         (dwarf2_has_info, dwarf2_get_section_info): Update.
4189         (dwarf2_free_objfile): Remove.
4190         (_initialize_dwarf2_read): Update.
4191
4192 2019-05-08  Tom Tromey  <tom@tromey.com>
4193
4194         * auto-load.c (struct auto_load_pspace_info): Add destructor and
4195         initializers.
4196         <unsupported_script_warning_printed,
4197         script_not_found_warning_printed>: Now bool.
4198         (auto_load_pspace_data): Change type.
4199         (~auto_load_pspace_info): Rename from
4200         auto_load_pspace_data_cleanup.
4201         (get_auto_load_pspace_data, init_loaded_scripts_info)
4202         (clear_section_scripts, maybe_print_unsupported_script_warning)
4203         (maybe_print_script_not_found_warning, _initialize_auto_load):
4204         Update.
4205
4206 2019-05-08  Tom Tromey  <tom@tromey.com>
4207
4208         * objfiles.c (objfile_pspace_info): Add destructor and
4209         initializers.
4210         (objfiles_pspace_data): Change type.
4211         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
4212         (get_objfile_pspace_data): Update.
4213         (objfiles_bfd_data): Change type.
4214         (get_objfile_bfd_data): Update.
4215         (objfile_bfd_data_free, _initialize_objfiles): Remove.
4216
4217 2019-05-08  Tom Tromey  <tom@tromey.com>
4218
4219         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
4220         Change type.
4221         (get_catch_syscall_inferior_data): Update.
4222         (catch_syscall_inferior_data_cleanup): Remove.
4223         (_initialize_break_catch_syscall): Update.
4224
4225 2019-05-08  Tom Tromey  <tom@tromey.com>
4226
4227         * inflow.c (struct terminal_info): Add destructor and
4228         initializers.
4229         (inflow_inferior_data): Change type.
4230         (~terminal_info): Rename from inflow_inferior_data_cleanup.
4231         (get_inflow_inferior_data, inflow_inferior_exit)
4232         (swap_terminal_info, _initialize_inflow): Update.
4233
4234 2019-05-08  Tom Tromey  <tom@tromey.com>
4235
4236         * target-dcache.c (target_dcache_cleanup): Remove.
4237         (target_dcache_aspace_key): Change type.
4238         (target_dcache_init_p, target_dcache_invalidate)
4239         (target_dcache_get, target_dcache_get_or_init)
4240         (_initialize_target_dcache): Update.
4241         * dcache.h (struct dcache_deleter): New.
4242
4243 2019-05-08  Tom Tromey  <tom@tromey.com>
4244
4245         * symtab.c (struct symbol_cache): Add destructor and
4246         initializers.
4247         (symbol_cache_key): Move.  Change type.
4248         (make_symbol_cache, free_symbol_cache): Remove.
4249         (get_symbol_cache): Update.
4250         (symbol_cache_cleanup): Remove.
4251         (ALL_PSPACES, symbol_cache_flush)
4252         (maintenance_print_symbol_cache)
4253         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
4254         Update.
4255
4256 2019-05-08  Tom Tromey  <tom@tromey.com>
4257
4258         * symtab.c (struct main_info): Add destructor and initializers.
4259         (main_progspace_key): Move.  Change type.
4260         (get_main_info): Update.
4261         (main_info_cleanup): Remove.
4262         (_initialize_symtab): Update.
4263
4264 2019-05-08  Tom Tromey  <tom@tromey.com>
4265
4266         * registry.h (DECLARE_REGISTRY): Define the _key class.
4267
4268 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
4269
4270         * NEWS: Merge two 'New commands' sections.
4271
4272 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
4273
4274         * ada-valprint.c (ada_val_print_gnat_array): Remove language
4275         parameter and use Ada language definition instead.
4276         (ada_val_print_ptr): Remove unused language parameter.
4277         (ada_val_print_num): Remove language parameter and use Ada language
4278         definition instead.
4279         (ada_val_print_enum, ada_val_print_flt): Remove unused language
4280         parameter.
4281         (ada_val_print_struct_union, ada_val_print_ref): Remove language
4282         parameter and use Ada language definition instead.
4283         (ada_val_print_1): Update all ada_val_print_xxx calls.
4284         Remove language parameter.
4285         (ada_val_print): Update ada_val_print_1 call.
4286
4287 2019-05-08  Tom Tromey  <tromey@adacore.com>
4288
4289         * remote.c (remote_hw_watchpoint_limit)
4290         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
4291         Now static.
4292
4293 2019-05-08  Tom Tromey  <tromey@adacore.com>
4294
4295         * maint.c (_initialize_maint_cmds): Move initialization code to
4296         remote.c.
4297         (watchdog, show_watchdog): Move to remote.c.
4298         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
4299         "watchdog" static.
4300         (_initialize_remote): Move initialization code from maint.c.
4301         * defs.h (watchdog): Don't declare.
4302
4303 2019-05-08  Tom Tromey  <tromey@adacore.com>
4304
4305         * tui/tui-interp.c: Include main.h.
4306         * interps.c: Include main.h.
4307         * main.h (interpreter_p): Declare.
4308         * defs.h (interpreter_p): Don't declare.
4309
4310 2019-05-08  Tom Tromey  <tromey@adacore.com>
4311
4312         * dwarf2loc.c: Include dwarf2read.h.
4313         * defs.h (read_unsigned_leb128): Don't declare.
4314         * dwarf2read.h (read_unsigned_leb128): Declare.
4315
4316 2019-05-08  Tom Tromey  <tromey@adacore.com>
4317
4318         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
4319         method.
4320
4321 2019-05-08  Tom Tromey  <tromey@adacore.com>
4322
4323         * utils.c (fputs_maybe_filtered): Reset style after paging, even
4324         when no wrap column is set.
4325
4326 2019-05-08  Tom Tromey  <tromey@adacore.com>
4327
4328         * c-lang.c (c_get_string): Handle non-C-style arrays.
4329
4330 2019-05-08  Tom Tromey  <tromey@adacore.com>
4331
4332         * typeprint.c (print_offset_data::update): Print the bit offset,
4333         not the number of bits remaining.
4334
4335 2019-05-08  Tom Tromey  <tromey@adacore.com>
4336
4337         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
4338         padding at end of comment.
4339
4340 2019-05-08  Tom Tromey  <tromey@adacore.com>
4341
4342         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
4343         Compare main types.
4344
4345 2019-05-06  Tom Tromey  <tom@tromey.com>
4346
4347         * common/scoped_mmap.c: Include common-defs.h.
4348         * common/scoped_mmap.h: Don't include config.h.
4349
4350 2019-05-04  Tom Tromey  <tom@tromey.com>
4351
4352         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
4353         (struct aarch64_call_info): Add initializers.
4354         <si>: Now a std::vector.
4355         (pass_on_stack, aarch64_push_dummy_call): Update.
4356
4357 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
4358             Tom Tromey  <tom@tromey.com>
4359
4360         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
4361         (ppc_threads): Now a std::vector.  Now static.
4362         (hwdebug_find_thread_points_by_tid)
4363         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
4364         Update.
4365
4366 2019-05-04  Tom Tromey  <tom@tromey.com>
4367
4368         * arc-tdep.c (arc_tdesc_init): Return bool.
4369
4370 2019-05-04  Tom Tromey  <tom@tromey.com>
4371
4372         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
4373         Use gdb_assert_not_reached.
4374
4375 2019-05-04  Tom Tromey  <tom@tromey.com>
4376
4377         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
4378         "false".
4379
4380 2019-05-04  Tom Tromey  <tom@tromey.com>
4381
4382         * arc-tdep.c (arc_tdesc_init): Use bool.
4383
4384 2019-05-04  Tom Tromey  <tom@tromey.com>
4385
4386         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
4387
4388 2019-05-04  Tom Tromey  <tom@tromey.com>
4389
4390         * cli/cli-cmds.c (valid_command_p): Return bool.
4391
4392 2019-05-04  Tom Tromey  <tom@tromey.com>
4393
4394         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
4395         * command.h (valid_user_defined_cmd_name_p): Channge return type.
4396
4397 2019-05-04  Raul Tambre  <raul@tambre.ee>
4398
4399         * python/lib/gdb/prompt.py (_ExtendedPrompt)
4400         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
4401         operator for comparison.
4402
4403 2019-05-04  Tom Tromey  <tom@tromey.com>
4404
4405         * psymtab.c (psymbol_name_matches, match_partial_symbol)
4406         (lookup_partial_symbol, print_partial_symbols)
4407         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
4408         (psymbol_compare): Update.
4409         (add_psymbol_to_bcache): Clear the entire psymbol.
4410         (maintenance_check_psymtabs): Update.
4411         * psympriv.h (struct partial_symbol): Don't derive from
4412         general_symbol_info.
4413         <obj_section, unrelocated_address, address,
4414         set_unrelocated_address>: Update.
4415         <ginfo>: New member.
4416         * dwarf-index-write.c (write_psymbols, debug_names::insert)
4417         (debug_names::write_psymbols): Update.
4418
4419 2019-05-04  Tom de Vries  <tdevries@suse.de>
4420
4421         * contrib/cc-with-tweaks.sh: Support -n arg.
4422
4423 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4424
4425         * corelow.c (core_target::detach): Ensure frame cache and
4426         register caches are cleared.
4427         inferior.c (exit_inferior_1): Likewise.
4428
4429 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
4430             Tom Tromey  <tom@tromey.com>
4431
4432         * dictionary.c (collate_pending_symbols_by_language): Remove
4433         "struct" from foreach.
4434         * symtab.c (lookup_global_symbol_from_objfile)
4435         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
4436         foreach.
4437         * ser-tcp.c (net_open): Remove "struct" from foreach.
4438         * objfiles.c (objfile_relocate, objfile_rebase)
4439         (objfile_has_symbols): Remove "struct" from foreach.
4440         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
4441         from foreach.
4442         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
4443         foreach.
4444         * darwin-nat.c (thread_info_from_private_thread_info): Remove
4445         "struct" from foreach.
4446         * ada-lang.c (create_excep_cond_exprs)
4447         (ada_exception_catchpoint_cond_string): Remove "struct" from
4448         foreach.
4449
4450 2019-05-03  Tom Tromey  <tromey@adacore.com>
4451
4452         * ada-exp.y (convert_char_literal): Check suffix of each
4453         enumerator.
4454
4455 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
4456
4457         PR ada/21406:
4458         * ada-exp.y (yywrap): Don't define.
4459         * ada-lex.l (%option): Add noyywrap
4460         (yywrap): Remove.
4461
4462 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
4463
4464         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
4465         _WIN32_WINNT to the XP level, unless already defined to a higher
4466         level.
4467
4468         * unittests/parse-connection-spec-selftests.c:
4469         * ser-tcp.c:
4470         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
4471         override.
4472
4473         * symfile.c (find_separate_debug_file): Remove colon from the
4474         drive spec of DOS/Windows file names of the target, so that the
4475         file name produced from DEBUGDIR and the target's directory will
4476         be valid on DOS/Windows systems.
4477
4478 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
4479
4480         * rust-lang.c (val_print_struct): Handle printing structures
4481         containing strings.
4482
4483 2019-05-02  Tom Tromey  <tromey@adacore.com>
4484
4485         * valarith.c (_initialize_valarith): Remove.
4486
4487 2019-05-01  Tom Tromey  <tromey@adacore.com>
4488
4489         * ada-lang.c (ada_value_primitive_field): Treat more fields as
4490         bitfields.
4491
4492 2019-05-01  Tom Tromey  <tromey@adacore.com>
4493
4494         * ada-lang.c (ada_value_assign): Correctly compute starting offset
4495         for big-endian copies.
4496
4497 2019-04-30  Ali Tamur  <tamur@google.com>
4498         * gdb/dwarf2read.c (read_3_bytes): New declaration.
4499         (read_attribute_value): Added DW_FORM_strx1-4 cases.
4500         (read_3_bytes): New function.
4501
4502 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4503
4504         * windows-nat.c (main_thread_id): Delete.
4505         (handle_output_debug_string): Replace main_thread_id by
4506         current_event.dwThreadId.
4507         (fake_create_process): Likewise.
4508         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
4509         Do not set main_thread_id.
4510         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
4511         current_event.dwThreadId.
4512         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
4513
4514 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
4515
4516         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
4517         Use current_event.dwThreadId instead of main_thread_id.
4518
4519 2019-04-30  Tom Tromey  <tromey@adacore.com>
4520
4521         * ada-lang.c (ada_lookup_simple_minsyms): New function.
4522         (create_excep_cond_exprs): Iterate over program spaces.
4523         (ada_exception_catchpoint_cond_string): Examine all minimal
4524         symbols for exception types.
4525
4526 2019-04-30  Tom Tromey  <tromey@adacore.com>
4527
4528         PR c++/24470:
4529         * dwarf2read.c (process_structure_scope): Handle case where type
4530         has template parameters but no symbol was created.
4531
4532 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4533             Chris January  <chris.january@arm.com>
4534
4535         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
4536         qualifier.
4537         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
4538
4539 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4540
4541         * f-typeprint.c (f_print_type): Update rules for printing
4542         whitespace.
4543         (f_type_print_varspec_suffix): Likewise.
4544
4545 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4546             Chris January  <chris.january@arm.com>
4547
4548         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
4549         function arguments.
4550
4551 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4552
4553         * f-lang.c (build_fortran_types): Change name of void type to
4554         lower case.
4555         * f-typeprint.c (f_type_print_base): Print the name of the void
4556         type, rather than a fixed string.
4557         * f-valprint.c (f_decorations): Use lower case void string.
4558
4559 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4560             Chris January  <chris.january@arm.com>
4561
4562         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
4563         types for Fortran.
4564
4565 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4566             Chris January  <chris.january@arm.com>
4567             David Lecomber  <david.lecomber@arm.com>
4568
4569         * f-exp.y (BINOP_INTRINSIC): New token.
4570         (exp): New parser rule handling BINOP_INTRINSIC.
4571         (f77_keywords): Add new builtin procedures.
4572         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
4573         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4574         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
4575         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4576         (print_unop_subexp_f): New function.
4577         (print_binop_subexp_f): New function.
4578         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4579         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
4580         (dump_subexp_body_f): Likewise.
4581         (operator_check_f): Likewise.
4582         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
4583         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
4584
4585 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4586
4587         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
4588         UNOP_KIND.
4589         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
4590         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
4591         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
4592         (operator_length_f): New fuction.
4593         (print_subexp_f): New function.
4594         (op_name_f): New function.
4595         (dump_subexp_body_f): New function.
4596         (operator_check_f): New function.
4597         (exp_descriptor_f): Replace standard expression handling functions
4598         with new functions.
4599         * gdb/fortran-operator.def: New file.
4600         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
4601         * gdb/std-operator.def: Remove UNOP_KIND.
4602
4603 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * std-operator.def: Remove unbalanced, stray double quote
4606         character.
4607
4608 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4609             Chris January  <chris.january@arm.com>
4610             Daniel Everett  <daniel.everett@arm.com>
4611             Nick Forrington  <nick.forrington@arm.com>
4612             Richard Bunt  <richard.bunt@arm.com>
4613
4614         * cp-valprint.c (cp_print_value_fields): Allow an additional level
4615         of depth when printing anonymous structs or unions.
4616         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
4617         Don't print either the top-level value, or the children if the
4618         max-depth is exceeded.
4619         (ppscm_print_children): When printing the key of a map, allow one
4620         extra level of depth.
4621         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
4622         print either the top-level value, or the children if the max-depth
4623         is exceeded.
4624         (print_children): When printing the key of a map, allow one extra
4625         level of depth.
4626         * python/py-value.c (valpy_format_string): Add max_depth keyword.
4627         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
4628         (user_print_options): Initialise max_depth field.
4629         (val_print_scalar_or_string_type_p): New function.
4630         (val_print): Check to see if the max depth has been reached.
4631         (val_print_check_max_depth): Define new function.
4632         (show_print_max_depth): New function.
4633         (_initialize_valprint): Add 'print max-depth' option.
4634         * valprint.h (struct value_print_options) <max_depth>: New field.
4635         (val_print_check_max_depth): Declare new function.
4636         * NEWS: Document new feature.
4637
4638 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4639
4640         * ada-lang.c (ada_language_defn): Initialise new field.
4641         * c-lang.c (c_is_string_type_p): New function.
4642         (c_language_defn): Initialise new field.
4643         (cplus_language_defn): Initialise new field.
4644         (asm_language_defn): Initialise new field.
4645         (minimal_language_defn): Initialise new field.
4646         * c-lang.h (c_is_string_type_p): Declare new function.
4647         * d-lang.c (d_language_defn): Initialise new field.
4648         * f-lang.c (f_is_string_type_p): New function.
4649         (f_language_defn): Initialise new field.
4650         * go-lang.c (go_is_string_type_p): New function.
4651         (go_language_defn): Initialise new field.
4652         * language.c (default_is_string_type_p): New function.
4653         (unknown_language_defn): Initialise new field.
4654         (auto_language_defn): Initialise new field.
4655         * language.h (struct language_defn) <la_is_string_type_p>: New
4656         member variable.
4657         (default_is_string_type_p): Declare new function.
4658         * m2-lang.c (m2_language_defn): Initialise new field.
4659         * objc-lang.c (objc_language_defn): Initialise new field.
4660         * opencl-lang.c (opencl_language_defn): Initialise new field.
4661         * p-lang.c (pascal_is_string_type_p): New function.
4662         (pascal_language_defn): Initialise new field.
4663         * rust-lang.c (rust_is_string_type_p): New function.
4664         (rust_language_defn): Initialise new field.
4665
4666 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4667
4668         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
4669         New field.
4670         * ada-lang.c (ada_language_defn): Initialise new field.
4671         * c-lang.c (c_language_defn): Likewise.
4672         (cplus_language_defn): Likewise.
4673         (asm_language_defn): Likewise.
4674         (minimal_language_defn): Likewise.
4675         * d-lang.c (d_language_defn): Likewise.
4676         * f-lang.c (f_language_defn): Likewise.
4677         * go-lang.c (go_language_defn): Likewise.
4678         * language.c (unknown_language_defn): Likewise.
4679         (auto_language_defn): Likewise.
4680         * m2-lang.c (m2_language_defn): Likewise.
4681         * objc-lang.c (objc_language_defn): Likewise.
4682         * opencl-lang.c (opencl_language_defn): Likewise.
4683         * p-lang.c (pascal_language_defn): Likewise.
4684         * rust-lang.c (rust_language_defn): Likewise.
4685
4686 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
4687
4688         * ada-lang.c (ada_is_character_type): Change return type to bool.
4689         (ada_is_string_type): Likewise.
4690         * ada-lang.h (ada_is_character_type): Update declaration
4691         (ada_is_string_type): Likewise.
4692
4693 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4694
4695         Support style in 'frame|thread apply'
4696
4697         * gdbcmd.h (execute_command_to_string): New term_out parameter.
4698         * record.c (record_start, record_stop): Update callers of
4699         execute_command_to_string with false.
4700         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
4701         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
4702         methods.
4703         (class string_file): New constructor with term_out parameter.
4704         Override methods term_out and can_emit_style_escape.  New member
4705         term_out.
4706         (class stdio_file): Override can_emit_style_escape.
4707         (class tee_file): Override term_out and can_emit_style_escape.
4708         * utils.h (can_emit_style_escape): Remove.
4709         * utils.c (can_emit_style_escape): Likewise.
4710         Update all callers of can_emit_style_escape (SOMESTREAM) to
4711         SOMESTREAM->can_emit_style_escape.
4712         * source-cache.c (source_cache::get_source_lines): Likewise.
4713         * stack.c (frame_apply_command_count): Call execute_command_to_string
4714         passing the term_out characteristic of the current gdb_stdout.
4715         * thread.c (thr_try_catch_cmd): Likewise.
4716         * top.c (execute_command_to_string): pass term_out parameter
4717         to construct the string_file for the command output.
4718         * ui-file.c (term_cli_styling): New function (most code moved
4719         from utils.c can_emit_style_escape).
4720         (string_file::string_file, string_file::can_emit_style_escape,
4721         stdio_file::can_emit_style_escape, tee_file::term_out,
4722         tee_file::can_emit_style_escape): New functions.
4723
4724 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4725
4726         * NEWS: Mention the new set|show may-call-functions.
4727         * infcall.c (may_call_functions_p): New variable.
4728         (show_may_call_functions_p): New function.
4729         (call_function_by_hand_dummy): Throws an error if not
4730         may-call-functions.
4731         (_initialize_infcall): Call add_setshow_boolean_cmd for
4732         may-call-functions.
4733
4734 2019-04-25  Keith Seitz  <keiths@redhat.com>
4735
4736         PR c++/24367
4737         * cp-support.c (inspect_type): Don't attempt substitutions
4738         of symbol with the same name.
4739
4740 2019-04-25  Tom Tromey  <tromey@adacore.com>
4741
4742         PR gdb/24475:
4743         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
4744         static.
4745
4746 2019-04-25  Tom Tromey  <tromey@adacore.com>
4747
4748         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
4749         rvalue reference.
4750         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
4751         (gdb_xml_parser::parse): Use std::move.
4752         * python/python-internal.h (gdbpy_convert_exception): Take a const
4753         reference.
4754         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
4755         std::move.
4756         * python/py-utils.c (gdbpy_convert_exception): Take a const
4757         reference.
4758         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4759         Use std::move.
4760         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4761         Use std::move.
4762         * mi/mi-main.c (mi_print_exception): Take a const reference.
4763         * main.c (handle_command_errors): Take a const reference.
4764         * linespec.c (parse_linespec): Use std::move.
4765         * infcall.c (run_inferior_call): Use std::move.
4766         (call_function_by_hand_dummy): Use std::move.
4767         * exec.c (try_open_exec_file): Use std::move.
4768         * exceptions.h (exception_print, exception_fprintf)
4769         (exception_print_same): Update.
4770         * exceptions.c (print_exception, exception_print)
4771         (exception_fprintf, exception_print_same): Change parameters to
4772         const reference.
4773         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
4774         * common/new-op.c: Use std::move.
4775         * common/common-exceptions.h (struct gdb_exception): Add move
4776         constructor.
4777         (struct gdb_exception_error, struct gdb_exception_quit, struct
4778         gdb_quit_bad_alloc): Change constructor to move constructor.
4779         (throw_exception): Change parameter to rvalue reference.
4780         * common/common-exceptions.c (throw_exception): Take rvalue
4781         reference.
4782         * cli/cli-interp.c (safe_execute_command): Use std::move.
4783         * breakpoint.c (insert_bp_location, location_to_sals): Use
4784         std::move.
4785
4786 2019-04-25  Tom Tromey  <tromey@adacore.com>
4787
4788         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
4789         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
4790         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
4791         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
4792         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
4793         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4794         guile/scm-value.c: Use unpack.
4795         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4796         gdbscm_gdb_exception.
4797         (gdbscm_throw_gdb_exception): Likewise.
4798         (struct gdbscm_gdb_exception): New.
4799         (unpack): New function.
4800         (gdbscm_wrap): Use unpack.
4801
4802 2019-04-25  Tom Tromey  <tromey@adacore.com>
4803
4804         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4805         (gdb_rl_callback_handler): Use std::move.
4806         * common/common-exceptions.h (struct gdb_exception): Add move
4807         assignment operator.
4808         (throw_exception_sjlj): Change "exception" to const reference.
4809         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4810         (throw_exception_sjlj): Change "exception" to const reference.
4811
4812 2019-04-25  Tom Tromey  <tromey@adacore.com>
4813
4814         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4815         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4816         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4817         Update.
4818         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4819         Update.
4820         * mi/mi-interp.c (mi_interp::exec): Update.
4821         * linespec.c (parse_linespec): Update.
4822         * infcall.c (run_inferior_call): Update.
4823         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4824         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4825         (gdbscm_lookup_global_symbol): Update.
4826         * guile/scm-param.c (gdbscm_parameter_value): Update.
4827         * guile/scm-frame.c (gdbscm_frame_read_register)
4828         (gdbscm_frame_read_var): Update.
4829         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4830         * exec.c (try_open_exec_file): Update.
4831         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4832         (gdb_rl_callback_handler): Update.
4833         * common/common-exceptions.h (exception_none): Don't declare.
4834         * common/common-exceptions.c (exception_none): Don't define.
4835         (struct catcher) <exception>: Update.
4836         * cli/cli-interp.c (safe_execute_command): Update.
4837         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4838
4839 2019-04-25  Ali Tamur  <tamur@google.com>
4840
4841         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4842         (read_attribute_value): Likewise.
4843         (dwarf2_read_addr_index): Update comment.
4844         (read_str_index): Add DW_FORM_strx.
4845         (dwarf2_string_attr): Likewise.
4846         (dwarf2_const_value_attr): Likewise.
4847         (dump_die_shallow): Likewise.
4848         (dwarf2_fetch_constant_bytes): Likewise.
4849         (skip_form_bytes): Likewise.
4850         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4851
4852 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4853
4854         PR corefiles/11608
4855         PR corefiles/18187
4856         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4857         OFFSET.  Verify if current mapping contains an ELF header.
4858         (linux_find_memory_regions_full): Adjust call to
4859         dump_mapping_p.
4860
4861 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4862             Kang Li <kanglictf@gmail.com>
4863
4864         PR gdb/21600
4865
4866         * dwarf2-frame.c (read_initial_length): Be consistent about using
4867         unsigned representation of length.
4868         (decode_frame_entry_1): Likewise.  Check for wraparound of
4869         end pointer as well as buffer overflow.
4870
4871 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4872
4873         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4874         "vq".
4875
4876 2019-04-24  Tom Tromey  <tromey@adacore.com>
4877
4878         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4879
4880 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4881
4882         * s12z-tdep.c (s12z_unwind_pc): Delete.
4883         (s12z_unwind_sp): Delete.
4884         (s12z_gdbarch_init): Don't register deleted functions with
4885         gdbarch.
4886
4887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4888
4889         * rl78-tdep.c (rl78_unwind_sp): Delete.
4890         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4891
4892 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4893
4894         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4895         (xstormy16_unwind_pc): Delete.
4896         (xstormy16_dummy_id): Delete.
4897         (xstormy16_gdbarch_init): Don't register deleted functions with
4898         gdbarch.
4899
4900 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4901
4902         * vax-tdep.c (vax_unwind_pc): Delete.
4903         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4904
4905 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4906
4907         * v850-tdep.c (v850_unwind_sp): Delete.
4908         (v850_unwind_pc): Delete.
4909         (v850_dummy_id): Delete.
4910         (v850_gdbarch_init): Don't register deleted functions with
4911         gdbarch.
4912
4913 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4914
4915         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4916         (tilegx_unwind_pc): Delete.
4917         (tilegx_unwind_dummy_id): Delete.
4918         (tilegx_gdbarch_init): Don't register deleted functions with
4919         gdbarch.
4920
4921 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4922
4923         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4924         (tic6x_dummy_id): Delete.
4925         (tic6x_gdbarch_init): Don't register deleted functions with
4926         gdbarch.
4927
4928 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4929
4930         * sparc-tdep.c (sparc_unwind_pc): Delete.
4931         (sparc32_gdbarch_init): Don't register deleted function with
4932         gdbarch.
4933
4934 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4935
4936         * sh-tdep.c (sh_unwind_sp): Delete.
4937         (sh_unwind_pc): Delete.
4938         (sh_dummy_id): Delete.
4939         (sh_gdbarch_init): Don't register deleted functions with
4940         gdbarch.
4941
4942 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4943
4944         * score-tdep.c (score_unwind_sp): Delete.
4945         (score_unwind_pc): Delete.
4946         (score_dummy_id): Delete.
4947         (score_gdbarch_init): Don't register deleted functions with
4948         gdbarch.
4949
4950 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4951
4952         * rx-tdep.c (rx_unwind_pc): Delete.
4953         (rx_unwind_sp): Delete.
4954         (rx_dummy_id): Delete.
4955         (rx_gdbarch_init): Don't register deleted functions with
4956         gdbarch.  Update comment.
4957
4958 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4959
4960         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4961         (rs6000_dummy_id): Delete.
4962         (rs6000_gdbarch_init): Don't register deleted functions with
4963         gdbarch.
4964
4965 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4966
4967         * or1k-tdep.c (or1k_dummy_id): Delete.
4968         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4969
4970 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4971
4972         * nios2-tdep.c (nios2_dummy_id): Delete.
4973         (nios2_unwind_sp): Delete.
4974         (nios2_gdbarch_init): Don't register deleted functions with
4975         gdbarch.
4976
4977 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4978
4979         * nds32-tdep.c (nds32_dummy_id): Delete.
4980         (nds32_unwind_pc): Delete.
4981         (nds32_unwind_sp): Delete.
4982         (nds32_gdbarch_init): Don't register deleted functions with
4983         gdbarch.
4984
4985 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4986
4987         * msp430-tdep.c (msp430_unwind_pc): Delete.
4988         (msp430_unwind_sp): Delete.
4989         (msp430_dummy_id): Delete.
4990         (msp430_gdbarch_init): Don't register deleted functions with
4991         gdbarch.
4992
4993 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4994
4995         * moxie-tdep.c (moxie_unwind_sp): Delete.
4996         (moxie_unwind_pc): Delete.
4997         (moxie_dummy_id): Delete.
4998         (moxie_gdbarch_init): Don't register deleted functions with
4999         gdbarch.
5000
5001 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5002
5003         * mn10300-tdep.c (mn10300_dummy_id): Delete.
5004         (mn10300_unwind_pc): Delete.
5005         (mn10300_unwind_sp): Delete.
5006         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
5007         mn10300_unwind_sp.
5008         (mn10300_frame_unwind_init): Don't register deleted functions with
5009         gdbarch.
5010
5011 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5012
5013         * mep-tdep.c (mep_unwind_pc): Delete.
5014         (mep_unwind_sp): Delete.
5015         (mep_dummy_id): Delete.
5016         (mep_gdbarch_init): Don't register deleted functions with
5017         gdbarch.
5018
5019 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5020
5021         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
5022         (m68hc11_unwind_sp): Delete.
5023         (m68hc11_gdbarch_init): Don't register deleted functions with
5024         gdbarch.
5025
5026 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5027
5028         * m32r-tdep.c (m32r_unwind_sp): Delete.
5029         (m32r_unwind_pc): Delete.
5030         (m32r_dummy_id): Delete.
5031         (m32r_gdbarch_init): Don't register deleted functions with
5032         gdbarch.
5033
5034 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5035
5036         * m32c-tdep.c (m32c_unwind_pc): Delete.
5037         (m32c_unwind_sp): Delete.
5038         (m32c_dummy_id): Delete.
5039         (m32c_gdbarch_init): Don't register deleted functions with
5040         gdbarch.
5041
5042 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5043
5044         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
5045         (lm32_unwind_pc): Delete.
5046         (lm32_dummy_id): Delete.
5047         (lm32_gdbarch_init): Don't register deleted functions with
5048         gdbarch.
5049
5050 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5051
5052         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
5053         (iq2000_unwind_pc): Delete.
5054         (iq2000_dummy_id): Delete.
5055         (iq2000_gdbarch_init): Don't register deleted functions with
5056         gdbarch.
5057
5058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * nds32-tdep.c (nds32_type_align): Delete.
5061         (nds32_push_dummy_call): Use type_align instead.
5062
5063 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5064
5065         * arm-tdep.c (arm_type_align): Only handle vector override case.
5066         (arm_push_dummy_call): Use type_align.
5067         (arm_gdbarch_init): Register arm_type_align gdbarch function.
5068
5069 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
5070
5071         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
5072         case.
5073         (pass_on_stack): Use type_align.
5074         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
5075         function.
5076
5077 2019-04-23  Tom Tromey  <tromey@adacore.com>
5078
5079         * dwarf2read.c (line_header::file_name_at): Remove unused
5080         overload.
5081
5082 2019-04-23  Tom de Vries  <tdevries@suse.de>
5083
5084         PR gdb/24438
5085         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
5086         invocation.
5087
5088
5089 2019-03-27  Ali Tamur  <tamur@google.com>
5090
5091         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
5092         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
5093         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
5094         (dwarf_expr_context::get_addr_index): Likewise
5095         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
5096         (symbol_needs_eval_context::get_addr_index): Likewise
5097         (disassemble_dwarf_expression): Add DW_OP_addrx
5098         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
5099         (read_cutu_die_from_dwo): Update comment
5100         (skip_one_die): Add DW_FORM_addrx
5101         (read_attribute_value): Likewise
5102         (var_decode_location): Add DW_OP_addrx
5103         (dwarf2_const_value_attr): Add DW_FORM_addrx
5104         (dump_die_shallow): Likewise
5105         (dwarf2_fetch_constant_bytes): Likewise
5106         (decode_locdesc): Add DW_OP_addrx
5107         (skip_form_bytes): Add DW_FORM_addrx
5108
5109 2019-04-22  Ali Tamur  <tamur@google.com>
5110
5111         * MAINTAINERS (Write After Approval): Add self.
5112
5113 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
5114
5115         * solib-svr4.c (get_svr4_info): Add pspace parameter.
5116         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
5117         (open_symbol_file_object): Likewise.
5118         (svr4_default_sos): Add info parameter.
5119         (svr4_read_so_list): Likewise.
5120         (svr4_current_sos_direct): Adjust functions calls to pass down
5121         info.
5122         (svr4_current_sos_1): Add info parameter.
5123         (svr4_current_sos): Call get_svr4_info, pass info down to
5124         svr4_current_sos_1.
5125         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
5126         get_svr4_info.
5127         (svr4_in_dynsym_resolve_code): Pass current_program_space to
5128         get_svr4_info.
5129         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
5130         to get_svr4_info.
5131         (probes_table_remove_objfile_probes): Likewise.
5132         (register_solib_event_probe): Add info parameter.
5133         (solist_update_incremental): Pass info parameter down to
5134         svr4_read_so_list.
5135         (disable_probes_interface): Add info parameter.
5136         (svr4_handle_solib_event): Pass current_program_space to
5137         get_svr4_info.  Adjust disable_probes_interface cleanup.
5138         (svr4_create_probe_breakpoints): Add info parameter, pass it
5139         down to register_solib_event_probe.
5140         (svr4_create_solib_event_breakpoints): Add info parameter,
5141         pass it down to svr4_create_probe_breakpoints.
5142         (enable_break): Pass info down to
5143         svr4_create_solib_event_breakpoints.
5144         (svr4_solib_create_inferior_hook): Pass current_program_space to
5145         get_svr4_info.
5146         (svr4_clear_solib): Likewise.
5147
5148 2019-04-22  Pedro Alves  <palves@redhat.com>
5149
5150         * solib-svr4.c (svr4_free_objfile_observer): New.
5151         (probe_and_action::objfile): New field.
5152         (probes_table_htab_remove_objfile_probes)
5153         (probes_table_remove_objfile_probes): New functions.
5154         (register_solib_event_probe): Add 'objfile' parameter.  Store it
5155         in the new probe_and_action.  Don't store the probe in 'lookup'.
5156         (svr4_create_probe_breakpoints): Pass objfile to
5157         register_solib_event_probe.
5158         (_initialize_svr4_solib): Register a free_objfile observer.
5159
5160 2019-04-19  Tom Tromey  <tom@tromey.com>
5161
5162         * common/queue.h: Remove.
5163
5164 2019-04-19  Tom Tromey  <tom@tromey.com>
5165
5166         * event-loop.c: Don't include "common/queue.h".
5167
5168 2019-04-19  Tom Tromey  <tom@tromey.com>
5169
5170         * remote.c (remote_target): Use delete.
5171         * remote-notif.h: Include <list>, not "common/queue.h".
5172         (notif_client_p): Remove typedef.
5173         (remote_notif_state): Add constructor, destructor, initializer.
5174         <notif_queue>: Now a std::list.
5175         (remote_notif_state_xfree): Don't declare.
5176         * remote-notif.c (remote_notif_process, handle_notification)
5177         (remote_notif_state_allocate): Update.
5178         (~remote_notif_state): Rename from remote_notif_state_xfree.
5179
5180 2019-04-19  Tom Tromey  <tom@tromey.com>
5181
5182         * symfile.c (reread_symbols): Update.
5183         * objfiles.c (objfile_register_static_link)
5184         (objfile_lookup_static_link): Update
5185         (~objfile) Don't delete static_links.
5186         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
5187
5188 2019-04-19  Tom Tromey  <tom@tromey.com>
5189
5190         * type-stack.h (struct type_stack) <insert>: Constify string.
5191         * type-stack.c (type_stack::insert): Constify string.
5192         * gdbtypes.h (lookup_template_type): Update.
5193         (address_space_name_to_int): Update.
5194         * gdbtypes.c (address_space_name_to_int): Make space_identifier
5195         const.
5196         (lookup_template_type): Make name const.
5197         * c-exp.y: Update rules.
5198         (lex_one_token, classify_name, classify_inner_name)
5199         (c_print_token): Update.
5200         * p-exp.y: Update rules.
5201         (yylex): Update.
5202         * f-exp.y: Update rules.
5203         (yylex): Update.
5204         * d-exp.y: Update rules.
5205         (lex_one_token, classify_name, classify_inner_name): Update.
5206         * parse.c (write_dollar_variable, copy_name): Return std::string.
5207         * parser-defs.h (copy_name): Change return type.
5208         * m2-exp.y: Update rules.
5209         (yylex): Update.
5210         * go-exp.y (lex_one_token): Update.
5211         Update rules.
5212         (classify_unsafe_function, classify_packaged_name)
5213         (classify_name, yylex): Update.
5214
5215 2019-04-19  Sergei Trofimovich <siarheit@google.com>
5216
5217         * configure.ac: add --enable-source-highlight switch.
5218         * configure: Regenerate.
5219         * top.c (print_gdb_version): plumb --enable-source-highlight
5220         status to "show configuration".
5221
5222 2019-04-19  Tom Tromey  <tromey@adacore.com>
5223
5224         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
5225         Check ADA_TYPE_P.
5226         (empty_record, ada_template_to_fixed_record_type_1)
5227         (template_to_static_fixed_type)
5228         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
5229         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
5230         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
5231         macros.
5232
5233 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
5234
5235         PR symtab/24423:
5236         * source.c (print_source_lines_base): Advance "iter" when a
5237         control character is seen.
5238
5239 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5240
5241         * inferior.h (struct infcall_suspend_state_deleter):
5242         Catch exception in destructor to avoid crash.
5243
5244 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5245
5246         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
5247         close to the add_com "shell".
5248
5249 2019-04-18  Tom Tromey  <tromey@adacore.com>
5250
5251         * process-stratum-target.h (class process_stratum_target)
5252         <stratum>: Add "final".
5253
5254 2019-04-17  Tom Tromey  <tromey@adacore.com>
5255
5256         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
5257         against nullptr before use.
5258
5259 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
5260
5261         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
5262
5263 2019-04-17  Jim Wilson  <jimw@sifive.com>
5264             Andrew Burgess  <andrew.burgess@embecosm.com>
5265
5266         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
5267         code read might fail, assume 4-byte breakpoint in that case.
5268
5269 2019-04-15  Leszek Swirski  <leszeks@google.com>
5270
5271         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
5272         rather than a hand-rolled POD check when checking for forced MEMORY
5273         classification.
5274
5275 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5276
5277         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
5278         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
5279         function.
5280         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
5281         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
5282         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
5283         declaration.
5284
5285 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5286
5287         * aarch64-linux-nat.c
5288         (aarch64_linux_nat_target::thread_architecture): Add override.
5289         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
5290         each VQ.
5291
5292 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
5293
5294         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
5295
5296 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5297
5298         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
5299         target types of size 96-bits, add some additional comments, and
5300         check that the builtin type we found was the correct size.
5301
5302 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
5303
5304         * utils.c (prompt_for_continue): Don't restore the styling at the
5305         end, as applied_style has the wrong value.  This fixes styling in
5306         long lists of file names that are interrupted by the "Continue?"
5307         prompt.
5308
5309 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
5310
5311         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
5312         * c-lang.c (c_language_defn): Likewise.
5313         (cplus_language_defn): Likewise.
5314         (asm_language_defn): Likewise.
5315         (minimal_language_defn): Likewise.
5316         * d-lang.c (d_language_defn): Likewise.
5317         * f-lang.c (f_language_defn): Likewise.
5318         * go-lang.c (go_language_defn): Likewise.
5319         * language.c (unknown_language_defn): Likewise.
5320         (auto_language_defn): Likewise.
5321         * language.h (struct language_defn): Remove la_magic field.
5322         (LANG_MAGIC): Delete.
5323         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
5324         * objc-lang.c (objc_language_defn): Likewise.
5325         * opencl-lang.c (opencl_language_defn): Likewise.
5326         * p-lang.c (pascal_language_defn): Likewise.
5327         * rust-lang.c (rust_language_defn): Likewise.
5328
5329 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5330
5331         * riscv-tdep.c (riscv_type_align): New function.
5332         (riscv_type_alignment): Delete.
5333         (riscv_arg_location): Use 'type_align'.
5334         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
5335
5336 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5337
5338         * gdbtypes.c (type_align): A struct with no non-static fields also
5339         has alignment of 1.
5340
5341 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
5342
5343         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
5344         component to 0.
5345         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
5346         member.
5347         (riscv_struct_info::analyse): New implementation using new
5348         analyse_inner member function.
5349         (riscv_struct_info::field_offset): New member function.
5350         (riscv_struct_info::m_offsets): New member variable.
5351         (riscv_struct_info::analyse_inner): New private member function,
5352         takes the old implementation of riscv_struct_info::analyse but
5353         extended to track field offsets.
5354         (riscv_call_arg_struct): Update the struct folding special cases
5355         to handle cases where empty C++ structs, which are non-zero
5356         length, are found.
5357         (riscv_arg_location): Initialise the length of each location, a
5358         non-zero length now indicates the location is in use.
5359         (riscv_push_dummy_call): Allow for the first location having a
5360         non-zero offset when setting up arguments.
5361         (riscv_return_value): Likewise, but for return values.
5362
5363 2019-04-11  Tom Tromey  <tromey@adacore.com>
5364
5365         * utils.c (internal_vproblem): Make "msg" const.
5366
5367 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
5368
5369         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
5370         * trad-frame.c (trad_frame_reset_saved_regs): New function.
5371         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
5372         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
5373
5374 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
5375
5376         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
5377         function.
5378         (fill_gregset): Call amd64_linux_collect_native_gregset instead
5379         of amd64_collect_native_gregset.
5380         (amd64_linux_nat_target::store_registers): Likewise.
5381
5382 2019-04-10  Tom Tromey  <tom@tromey.com>
5383
5384         * symtab.c (lookup_global_symbol_from_objfile)
5385         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
5386         * objfiles.h (class separate_debug_iterator): New.
5387         (class separate_debug_range): New.
5388         (struct objfile) <separate_debug_objfiles>: New method.
5389         (objfile_separate_debug_iterate): Don't declare.
5390         * objfiles.c (separate_debug_iterator::operator++): Rename from
5391         objfile_separate_debug_iterate.
5392         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
5393         iterator.
5394         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
5395         iterator.
5396
5397 2019-04-10  Tom Tromey  <tom@tromey.com>
5398
5399         * symfile.c (reread_symbols): Remove old comment.
5400         * objfiles.c (free_all_objfiles): Fix a typo.
5401
5402 2019-04-10  Tom Tromey  <tom@tromey.com>
5403
5404         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
5405         * minsyms.c (lookup_minimal_symbol): Use foreach.
5406         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
5407         (lookup_minimal_symbol_solib_trampoline): Likewise.
5408         * symfile.c (reread_symbols): Use foreach.
5409
5410 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
5411             Tom Tromey  <tromey@adacore.com>
5412
5413         PR rust/24414:
5414         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
5415         (rust_lex_int_test): Change "value" to be LONGEST.
5416         (rust_lex_tests): Add test for long integer literal.
5417
5418 2019-04-09  Tom Tromey  <tromey@adacore.com>
5419
5420         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
5421         to bool.
5422         (extended_remote_target::attach): Update.
5423         (remote_target::remote_notice_new_inferior): Update.
5424         (remote_target::add_current_inferior_and_thread): Update.
5425         * inferior.c (exit_inferior_1): Use "false".
5426         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
5427
5428 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
5429
5430         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
5431         the "start" command.
5432
5433 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5434
5435         * python/py-inferior.c (infpy_thread_from_thread_handle):
5436         Adjust comments to reflect renaming of thread_from_thread_handle
5437         to thread_from_handle.  Adjust keywords.  Fix type error message.
5438         (inferior_object_methods): Add thread_from_handle.  Retain
5439         thread_from_thread_handle, but mark it as deprecated.
5440
5441 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5442
5443         * gdbthread.h (find_thread_by_handle): Revise declaration.
5444         * thread.c (find_thread_by_handle): Likewise.  Adjust
5445         implementation too.
5446         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
5447         support for buffer objects as handles.
5448
5449 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5450
5451         * python/py-infthread.c (thpy_thread_handle): New function.
5452         (thread_object_methods): Register thpy_thread_handle.
5453
5454 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
5455
5456         * gdbthread.h (thread_to_thread_handle): Declare.
5457         * thread.c (gdbtypes.h): Include.
5458         (thread_to_thread_handle): New function.
5459
5460         * target.h (struct target_ops): Add thread_info_to_thread_handle.
5461         (target_thread_info_to_thread_handle): Declare.
5462         * target.c (target_thread_info_to_thread_handle): New function.
5463         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
5464         * target-delegates.c: Regenerate.
5465
5466         * linux-thread-db.c (class thread_db_target): Add method
5467         thread_info_to_thread_handle.
5468         (thread_db_target::thread_info_to_thread_handle): Define.
5469         * remote.c (class remote_target): Add new method
5470         thread_info_to_thread_handle.
5471         (remote_target::thread_info_to_thread_handle): Define.
5472
5473 2019-04-08  Pedro Alves  <palves@redhat.com>
5474
5475         * common/common-exceptions.c (throw_exception): Don't create
5476         named object to throw; throw directly.
5477         (throw_it): Likewise.  Don't initialize gdb_exception::message
5478         here, with new; pass FMT and AP to the ctor instead.
5479         * common/common-exceptions.h: Include <string>.
5480         (gdb_exception::gdb_exception(enum return_reason, enum errors,
5481         const char *, va_list)): New ctor.  Use std::make_shared.
5482         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
5483         errors)): Delete.
5484         (gdb_exception_error::gdb_exception_error(enum errors, const char
5485         *, va_list)): New.
5486         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
5487         Add assertion.
5488         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
5489         errors)): Delete.
5490         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
5491         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
5492         Add assertion.
5493
5494 2019-04-08  Tom Tromey  <tom@tromey.com>
5495
5496         * valops.c (value_rtti_indirect_type): Replace throw_exception
5497         with throw.
5498         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
5499         with throw.
5500         * thread.c (thr_try_catch_cmd): Replace throw_exception with
5501         throw.
5502         * target.c (target_translate_tls_address): Replace throw_exception
5503         with throw.
5504         * stack.c (frame_apply_command_count): Replace throw_exception
5505         with throw.
5506         * solib-spu.c (append_ocl_sos): Replace throw_exception with
5507         throw.
5508         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
5509         with throw.
5510         * rs6000-tdep.c (rs6000_frame_cache)
5511         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
5512         * remote.c: Replace throw_exception with throw.
5513         * record-full.c (record_full_message, record_full_wait_1)
5514         (record_full_restore): Replace throw_exception with throw.
5515         * record-btrace.c:
5516         (get_thread_current_frame_id, record_btrace_start_replaying)
5517         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
5518         (cmd_record_btrace_start): Replace throw_exception with throw.
5519         * parse.c (parse_exp_in_context_1): Replace throw_exception with
5520         throw.
5521         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
5522         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
5523         * linespec.c:
5524         (find_linespec_symbols): Replace throw_exception with throw.
5525         * infrun.c (displaced_step_prepare, resume): Replace
5526         throw_exception with throw.
5527         * infcmd.c (post_create_inferior): Replace throw_exception with
5528         throw.
5529         * inf-loop.c (inferior_event_handler): Replace throw_exception
5530         with throw.
5531         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
5532         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
5533         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
5534         (get_prev_frame_always, get_frame_pc_if_available)
5535         (get_frame_address_in_block_if_available, get_frame_language):
5536         Replace throw_exception with throw.
5537         * frame-unwind.c (frame_unwind_try_unwinder): Replace
5538         throw_exception with throw.
5539         * eval.c (fetch_subexp_value, evaluate_var_value)
5540         (evaluate_funcall, evaluate_subexp_standard): Replace
5541         throw_exception with throw.
5542         * dwarf2loc.c (call_site_find_chain)
5543         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
5544         Replace throw_exception with throw.
5545         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
5546         with throw.
5547         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
5548         throw.
5549         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
5550         * completer.c (complete_line_internal): Replace throw_exception
5551         with throw.
5552         * compile/compile-object-run.c (compile_object_run): Replace
5553         throw_exception with throw.
5554         * cli/cli-script.c (process_next_line): Replace throw_exception
5555         with throw.
5556         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
5557         (btrace_enable, btrace_maint_update_pt_packets): Replace
5558         throw_exception with throw.
5559         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
5560         throw_exception with throw.
5561         * break-catch-throw.c (re_set_exception_catchpoint): Replace
5562         throw_exception with throw.
5563         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
5564         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
5565         * aarch64-tdep.c (aarch64_make_prologue_cache)
5566         (aarch64_make_stub_cache): Replace throw_exception with throw.
5567
5568 2019-04-08  Tom Tromey  <tom@tromey.com>
5569
5570         * common/common-exceptions.c (throw_exception): Rename from
5571         throw_exception_cxx.  Remove old copy.  Make argument const.
5572         (throw_it): Create and throw exception objects directly.
5573         * common/common-exceptions.h (throw_exception): Make argument
5574         const.
5575         (struct gdb_exception_error): Add constructor.
5576         (struct gdb_exception_quit): Add constructor.
5577
5578 2019-04-08  Tom Tromey  <tom@tromey.com>
5579
5580         * common/common-exceptions.h (exception_rethrow): Don't declare.
5581         (TRY_SJLJ): Update comment.
5582         (TRY, CATCH, END_CATCH): Remove.
5583         * common/common-exceptions.c (exception_rethrow): Remove.
5584
5585 2019-04-08  Tom Tromey  <tom@tromey.com>
5586
5587         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
5588         Remove.
5589         (gdb_exception_error): Rename from
5590         gdb_exception_RETURN_MASK_ERROR.
5591         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
5592         (gdb_quit_bad_alloc): Update.
5593         * aarch64-tdep.c: Update.
5594         * ada-lang.c: Update.
5595         * ada-typeprint.c: Update.
5596         * ada-valprint.c: Update.
5597         * amd64-tdep.c: Update.
5598         * arch-utils.c: Update.
5599         * break-catch-throw.c: Update.
5600         * breakpoint.c: Update.
5601         * btrace.c: Update.
5602         * c-varobj.c: Update.
5603         * cli/cli-cmds.c: Update.
5604         * cli/cli-interp.c: Update.
5605         * cli/cli-script.c: Update.
5606         * common/common-exceptions.c: Update.
5607         * common/new-op.c: Update.
5608         * common/selftest.c: Update.
5609         * compile/compile-c-symbols.c: Update.
5610         * compile/compile-cplus-symbols.c: Update.
5611         * compile/compile-object-load.c: Update.
5612         * compile/compile-object-run.c: Update.
5613         * completer.c: Update.
5614         * corelow.c: Update.
5615         * cp-abi.c: Update.
5616         * cp-support.c: Update.
5617         * cp-valprint.c: Update.
5618         * darwin-nat.c: Update.
5619         * disasm-selftests.c: Update.
5620         * dtrace-probe.c: Update.
5621         * dwarf-index-cache.c: Update.
5622         * dwarf-index-write.c: Update.
5623         * dwarf2-frame-tailcall.c: Update.
5624         * dwarf2-frame.c: Update.
5625         * dwarf2loc.c: Update.
5626         * dwarf2read.c: Update.
5627         * eval.c: Update.
5628         * event-loop.c: Update.
5629         * event-top.c: Update.
5630         * exec.c: Update.
5631         * f-valprint.c: Update.
5632         * fbsd-tdep.c: Update.
5633         * frame-unwind.c: Update.
5634         * frame.c: Update.
5635         * gdbtypes.c: Update.
5636         * gnu-v3-abi.c: Update.
5637         * guile/guile-internal.h: Update.
5638         * guile/scm-block.c: Update.
5639         * guile/scm-breakpoint.c: Update.
5640         * guile/scm-cmd.c: Update.
5641         * guile/scm-disasm.c: Update.
5642         * guile/scm-frame.c: Update.
5643         * guile/scm-lazy-string.c: Update.
5644         * guile/scm-math.c: Update.
5645         * guile/scm-param.c: Update.
5646         * guile/scm-ports.c: Update.
5647         * guile/scm-pretty-print.c: Update.
5648         * guile/scm-symbol.c: Update.
5649         * guile/scm-symtab.c: Update.
5650         * guile/scm-type.c: Update.
5651         * guile/scm-value.c: Update.
5652         * i386-linux-tdep.c: Update.
5653         * i386-tdep.c: Update.
5654         * inf-loop.c: Update.
5655         * infcall.c: Update.
5656         * infcmd.c: Update.
5657         * infrun.c: Update.
5658         * jit.c: Update.
5659         * language.c: Update.
5660         * linespec.c: Update.
5661         * linux-fork.c: Update.
5662         * linux-nat.c: Update.
5663         * linux-tdep.c: Update.
5664         * linux-thread-db.c: Update.
5665         * main.c: Update.
5666         * mi/mi-cmd-break.c: Update.
5667         * mi/mi-cmd-stack.c: Update.
5668         * mi/mi-interp.c: Update.
5669         * mi/mi-main.c: Update.
5670         * objc-lang.c: Update.
5671         * p-valprint.c: Update.
5672         * parse.c: Update.
5673         * ppc-linux-tdep.c: Update.
5674         * printcmd.c: Update.
5675         * python/py-arch.c: Update.
5676         * python/py-breakpoint.c: Update.
5677         * python/py-cmd.c: Update.
5678         * python/py-finishbreakpoint.c: Update.
5679         * python/py-frame.c: Update.
5680         * python/py-framefilter.c: Update.
5681         * python/py-gdb-readline.c: Update.
5682         * python/py-inferior.c: Update.
5683         * python/py-infthread.c: Update.
5684         * python/py-lazy-string.c: Update.
5685         * python/py-linetable.c: Update.
5686         * python/py-objfile.c: Update.
5687         * python/py-param.c: Update.
5688         * python/py-prettyprint.c: Update.
5689         * python/py-progspace.c: Update.
5690         * python/py-record-btrace.c: Update.
5691         * python/py-record.c: Update.
5692         * python/py-symbol.c: Update.
5693         * python/py-type.c: Update.
5694         * python/py-unwind.c: Update.
5695         * python/py-utils.c: Update.
5696         * python/py-value.c: Update.
5697         * python/python.c: Update.
5698         * record-btrace.c: Update.
5699         * record-full.c: Update.
5700         * remote-fileio.c: Update.
5701         * remote.c: Update.
5702         * riscv-tdep.c: Update.
5703         * rs6000-aix-tdep.c: Update.
5704         * rs6000-tdep.c: Update.
5705         * rust-exp.y: Update.
5706         * rust-lang.c: Update.
5707         * s390-tdep.c: Update.
5708         * selftest-arch.c: Update.
5709         * solib-dsbt.c: Update.
5710         * solib-frv.c: Update.
5711         * solib-spu.c: Update.
5712         * solib-svr4.c: Update.
5713         * solib.c: Update.
5714         * sparc64-linux-tdep.c: Update.
5715         * stack.c: Update.
5716         * symfile-mem.c: Update.
5717         * symmisc.c: Update.
5718         * target.c: Update.
5719         * thread.c: Update.
5720         * top.c: Update.
5721         * tracefile-tfile.c: Update.
5722         * tui/tui.c: Update.
5723         * typeprint.c: Update.
5724         * unittests/cli-utils-selftests.c: Update.
5725         * unittests/parse-connection-spec-selftests.c: Update.
5726         * valops.c: Update.
5727         * valprint.c: Update.
5728         * value.c: Update.
5729         * varobj.c: Update.
5730         * windows-nat.c: Update.
5731         * x86-linux-nat.c: Update.
5732         * xml-support.c: Update.
5733
5734 2019-04-08  Tom Tromey  <tom@tromey.com>
5735
5736         * xml-support.c: Use C++ exception handling.
5737         * x86-linux-nat.c: Use C++ exception handling.
5738         * windows-nat.c: Use C++ exception handling.
5739         * varobj.c: Use C++ exception handling.
5740         * value.c: Use C++ exception handling.
5741         * valprint.c: Use C++ exception handling.
5742         * valops.c: Use C++ exception handling.
5743         * unittests/parse-connection-spec-selftests.c: Use C++ exception
5744         handling.
5745         * unittests/cli-utils-selftests.c: Use C++ exception handling.
5746         * typeprint.c: Use C++ exception handling.
5747         * tui/tui.c: Use C++ exception handling.
5748         * tracefile-tfile.c: Use C++ exception handling.
5749         * top.c: Use C++ exception handling.
5750         * thread.c: Use C++ exception handling.
5751         * target.c: Use C++ exception handling.
5752         * symmisc.c: Use C++ exception handling.
5753         * symfile-mem.c: Use C++ exception handling.
5754         * stack.c: Use C++ exception handling.
5755         * sparc64-linux-tdep.c: Use C++ exception handling.
5756         * solib.c: Use C++ exception handling.
5757         * solib-svr4.c: Use C++ exception handling.
5758         * solib-spu.c: Use C++ exception handling.
5759         * solib-frv.c: Use C++ exception handling.
5760         * solib-dsbt.c: Use C++ exception handling.
5761         * selftest-arch.c: Use C++ exception handling.
5762         * s390-tdep.c: Use C++ exception handling.
5763         * rust-lang.c: Use C++ exception handling.
5764         * rust-exp.y: Use C++ exception handling.
5765         * rs6000-tdep.c: Use C++ exception handling.
5766         * rs6000-aix-tdep.c: Use C++ exception handling.
5767         * riscv-tdep.c: Use C++ exception handling.
5768         * remote.c: Use C++ exception handling.
5769         * remote-fileio.c: Use C++ exception handling.
5770         * record-full.c: Use C++ exception handling.
5771         * record-btrace.c: Use C++ exception handling.
5772         * python/python.c: Use C++ exception handling.
5773         * python/py-value.c: Use C++ exception handling.
5774         * python/py-utils.c: Use C++ exception handling.
5775         * python/py-unwind.c: Use C++ exception handling.
5776         * python/py-type.c: Use C++ exception handling.
5777         * python/py-symbol.c: Use C++ exception handling.
5778         * python/py-record.c: Use C++ exception handling.
5779         * python/py-record-btrace.c: Use C++ exception handling.
5780         * python/py-progspace.c: Use C++ exception handling.
5781         * python/py-prettyprint.c: Use C++ exception handling.
5782         * python/py-param.c: Use C++ exception handling.
5783         * python/py-objfile.c: Use C++ exception handling.
5784         * python/py-linetable.c: Use C++ exception handling.
5785         * python/py-lazy-string.c: Use C++ exception handling.
5786         * python/py-infthread.c: Use C++ exception handling.
5787         * python/py-inferior.c: Use C++ exception handling.
5788         * python/py-gdb-readline.c: Use C++ exception handling.
5789         * python/py-framefilter.c: Use C++ exception handling.
5790         * python/py-frame.c: Use C++ exception handling.
5791         * python/py-finishbreakpoint.c: Use C++ exception handling.
5792         * python/py-cmd.c: Use C++ exception handling.
5793         * python/py-breakpoint.c: Use C++ exception handling.
5794         * python/py-arch.c: Use C++ exception handling.
5795         * printcmd.c: Use C++ exception handling.
5796         * ppc-linux-tdep.c: Use C++ exception handling.
5797         * parse.c: Use C++ exception handling.
5798         * p-valprint.c: Use C++ exception handling.
5799         * objc-lang.c: Use C++ exception handling.
5800         * mi/mi-main.c: Use C++ exception handling.
5801         * mi/mi-interp.c: Use C++ exception handling.
5802         * mi/mi-cmd-stack.c: Use C++ exception handling.
5803         * mi/mi-cmd-break.c: Use C++ exception handling.
5804         * main.c: Use C++ exception handling.
5805         * linux-thread-db.c: Use C++ exception handling.
5806         * linux-tdep.c: Use C++ exception handling.
5807         * linux-nat.c: Use C++ exception handling.
5808         * linux-fork.c: Use C++ exception handling.
5809         * linespec.c: Use C++ exception handling.
5810         * language.c: Use C++ exception handling.
5811         * jit.c: Use C++ exception handling.
5812         * infrun.c: Use C++ exception handling.
5813         * infcmd.c: Use C++ exception handling.
5814         * infcall.c: Use C++ exception handling.
5815         * inf-loop.c: Use C++ exception handling.
5816         * i386-tdep.c: Use C++ exception handling.
5817         * i386-linux-tdep.c: Use C++ exception handling.
5818         * guile/scm-value.c: Use C++ exception handling.
5819         * guile/scm-type.c: Use C++ exception handling.
5820         * guile/scm-symtab.c: Use C++ exception handling.
5821         * guile/scm-symbol.c: Use C++ exception handling.
5822         * guile/scm-pretty-print.c: Use C++ exception handling.
5823         * guile/scm-ports.c: Use C++ exception handling.
5824         * guile/scm-param.c: Use C++ exception handling.
5825         * guile/scm-math.c: Use C++ exception handling.
5826         * guile/scm-lazy-string.c: Use C++ exception handling.
5827         * guile/scm-frame.c: Use C++ exception handling.
5828         * guile/scm-disasm.c: Use C++ exception handling.
5829         * guile/scm-cmd.c: Use C++ exception handling.
5830         * guile/scm-breakpoint.c: Use C++ exception handling.
5831         * guile/scm-block.c: Use C++ exception handling.
5832         * guile/guile-internal.h: Use C++ exception handling.
5833         * gnu-v3-abi.c: Use C++ exception handling.
5834         * gdbtypes.c: Use C++ exception handling.
5835         * frame.c: Use C++ exception handling.
5836         * frame-unwind.c: Use C++ exception handling.
5837         * fbsd-tdep.c: Use C++ exception handling.
5838         * f-valprint.c: Use C++ exception handling.
5839         * exec.c: Use C++ exception handling.
5840         * event-top.c: Use C++ exception handling.
5841         * event-loop.c: Use C++ exception handling.
5842         * eval.c: Use C++ exception handling.
5843         * dwarf2read.c: Use C++ exception handling.
5844         * dwarf2loc.c: Use C++ exception handling.
5845         * dwarf2-frame.c: Use C++ exception handling.
5846         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5847         * dwarf-index-write.c: Use C++ exception handling.
5848         * dwarf-index-cache.c: Use C++ exception handling.
5849         * dtrace-probe.c: Use C++ exception handling.
5850         * disasm-selftests.c: Use C++ exception handling.
5851         * darwin-nat.c: Use C++ exception handling.
5852         * cp-valprint.c: Use C++ exception handling.
5853         * cp-support.c: Use C++ exception handling.
5854         * cp-abi.c: Use C++ exception handling.
5855         * corelow.c: Use C++ exception handling.
5856         * completer.c: Use C++ exception handling.
5857         * compile/compile-object-run.c: Use C++ exception handling.
5858         * compile/compile-object-load.c: Use C++ exception handling.
5859         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5860         * compile/compile-c-symbols.c: Use C++ exception handling.
5861         * common/selftest.c: Use C++ exception handling.
5862         * common/new-op.c: Use C++ exception handling.
5863         * cli/cli-script.c: Use C++ exception handling.
5864         * cli/cli-interp.c: Use C++ exception handling.
5865         * cli/cli-cmds.c: Use C++ exception handling.
5866         * c-varobj.c: Use C++ exception handling.
5867         * btrace.c: Use C++ exception handling.
5868         * breakpoint.c: Use C++ exception handling.
5869         * break-catch-throw.c: Use C++ exception handling.
5870         * arch-utils.c: Use C++ exception handling.
5871         * amd64-tdep.c: Use C++ exception handling.
5872         * ada-valprint.c: Use C++ exception handling.
5873         * ada-typeprint.c: Use C++ exception handling.
5874         * ada-lang.c: Use C++ exception handling.
5875         * aarch64-tdep.c: Use C++ exception handling.
5876
5877 2019-04-08  Tom Tromey  <tom@tromey.com>
5878
5879         * xml-support.c (gdb_xml_parser::parse): Update.
5880         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5881         * value.c (show_convenience): Update.
5882         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5883         (test_parse_flags_qcs): Update.
5884         * thread.c (thr_try_catch_cmd): Update.
5885         * target.c (target_translate_tls_address): Update.
5886         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5887         (info_frame_command_core, frame_apply_command_count): Update.
5888         * rust-exp.y (rust_lex_exception_test): Update.
5889         * riscv-tdep.c (riscv_print_one_register_info): Update.
5890         * remote.c (remote_target::enable_btrace): Update.
5891         * record-btrace.c (record_btrace_enable_warn): Update.
5892         * python/py-utils.c (gdbpy_convert_exception): Update.
5893         * printcmd.c (do_one_display, print_variable_and_value): Update.
5894         * mi/mi-main.c (mi_print_exception): Update.
5895         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5896         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5897         * linux-nat.c (linux_nat_target::attach): Update.
5898         * linux-fork.c (class scoped_switch_fork_info): Update.
5899         * infrun.c (displaced_step_prepare): Update.
5900         * infcall.c (call_function_by_hand_dummy): Update.
5901         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5902         * gnu-v3-abi.c (print_one_vtable): Update.
5903         * frame.c (get_prev_frame_always): Update.
5904         * f-valprint.c (info_common_command_for_block): Update.
5905         * exec.c (try_open_exec_file): Update.
5906         * exceptions.c (print_exception, exception_print)
5907         (exception_fprintf, exception_print_same): Update.
5908         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5909         * dwarf-index-cache.c (index_cache::store)
5910         (index_cache::lookup_gdb_index): Update.
5911         * darwin-nat.c (maybe_cache_shell): Update.
5912         * cp-valprint.c (cp_print_value_fields): Update.
5913         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5914         (gcc_cplus_symbol_address): Update.
5915         * compile/compile-c-symbols.c (gcc_convert_symbol)
5916         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5917         * common/selftest.c: Update.
5918         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5919         a std::string.
5920         (exception_try_scope_entry, exception_try_scope_exit): Don't
5921         declare.
5922         (struct exception_try_scope): Remove.
5923         (TRY): Don't use exception_try_scope.
5924         (struct gdb_exception): Add constructor, operator=.
5925         <what>: New method.
5926         (struct gdb_exception_RETURN_MASK_ALL)
5927         (struct gdb_exception_RETURN_MASK_ERROR)
5928         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5929         (struct gdb_quit_bad_alloc): Update.
5930         * common/common-exceptions.c (exception_none): Change
5931         initializer.
5932         (struct catcher) <state, exception>: Initialize inline.
5933         <prev>: Remove member.
5934         (current_catcher): Remove.
5935         (catchers): New global.
5936         (exceptions_state_mc_init): Simplify.
5937         (catcher_pop): Remove.
5938         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5939         (try_scope_depth, exception_try_scope_entry)
5940         (exception_try_scope_exit): Remove.
5941         (throw_exception_sjlj): Update.
5942         (exception_messages, exception_messages_size): Remove.
5943         (throw_it): Simplify.
5944         (gdb_exception_sliced_copy): Remove.
5945         (throw_exception_cxx): Update.
5946         * cli/cli-script.c (script_from_file): Update.
5947         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5948         Update.
5949         * ada-valprint.c (ada_val_print): Update.
5950         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5951         (create_excep_cond_exprs): Update.
5952
5953 2019-04-08  Tom Tromey  <tom@tromey.com>
5954
5955         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5956         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5957         (TRY, CATCH, END_CATCH): Remove some definitions.
5958         * common/common-exceptions.c: Don't use GDB_XCPT.
5959         (catcher_list_size): Remove.
5960         (throw_exception, throw_it): Simplify.
5961
5962 2019-04-05  Tom Tromey  <tom@tromey.com>
5963
5964         Revert the header-sorting patch.
5965         * ft32-tdep.c: Revert.
5966         * frv-tdep.c: Revert.
5967         * frv-linux-tdep.c: Revert.
5968         * frame.c: Revert.
5969         * frame-unwind.c: Revert.
5970         * frame-base.c: Revert.
5971         * fork-child.c: Revert.
5972         * findvar.c: Revert.
5973         * findcmd.c: Revert.
5974         * filesystem.c: Revert.
5975         * filename-seen-cache.h: Revert.
5976         * filename-seen-cache.c: Revert.
5977         * fbsd-tdep.c: Revert.
5978         * fbsd-nat.h: Revert.
5979         * fbsd-nat.c: Revert.
5980         * f-valprint.c: Revert.
5981         * f-typeprint.c: Revert.
5982         * f-lang.c: Revert.
5983         * extension.h: Revert.
5984         * extension.c: Revert.
5985         * extension-priv.h: Revert.
5986         * expprint.c: Revert.
5987         * exec.h: Revert.
5988         * exec.c: Revert.
5989         * exceptions.c: Revert.
5990         * event-top.c: Revert.
5991         * event-loop.c: Revert.
5992         * eval.c: Revert.
5993         * elfread.c: Revert.
5994         * dwarf2read.h: Revert.
5995         * dwarf2read.c: Revert.
5996         * dwarf2loc.c: Revert.
5997         * dwarf2expr.h: Revert.
5998         * dwarf2expr.c: Revert.
5999         * dwarf2-frame.c: Revert.
6000         * dwarf2-frame-tailcall.c: Revert.
6001         * dwarf-index-write.h: Revert.
6002         * dwarf-index-write.c: Revert.
6003         * dwarf-index-common.c: Revert.
6004         * dwarf-index-cache.h: Revert.
6005         * dwarf-index-cache.c: Revert.
6006         * dummy-frame.c: Revert.
6007         * dtrace-probe.c: Revert.
6008         * disasm.h: Revert.
6009         * disasm.c: Revert.
6010         * disasm-selftests.c: Revert.
6011         * dictionary.c: Revert.
6012         * dicos-tdep.c: Revert.
6013         * demangle.c: Revert.
6014         * dcache.h: Revert.
6015         * dcache.c: Revert.
6016         * darwin-nat.h: Revert.
6017         * darwin-nat.c: Revert.
6018         * darwin-nat-info.c: Revert.
6019         * d-valprint.c: Revert.
6020         * d-namespace.c: Revert.
6021         * d-lang.c: Revert.
6022         * ctf.c: Revert.
6023         * csky-tdep.c: Revert.
6024         * csky-linux-tdep.c: Revert.
6025         * cris-tdep.c: Revert.
6026         * cris-linux-tdep.c: Revert.
6027         * cp-valprint.c: Revert.
6028         * cp-support.c: Revert.
6029         * cp-namespace.c: Revert.
6030         * cp-abi.c: Revert.
6031         * corelow.c: Revert.
6032         * corefile.c: Revert.
6033         * continuations.c: Revert.
6034         * completer.h: Revert.
6035         * completer.c: Revert.
6036         * complaints.c: Revert.
6037         * coffread.c: Revert.
6038         * coff-pe-read.c: Revert.
6039         * cli-out.h: Revert.
6040         * cli-out.c: Revert.
6041         * charset.c: Revert.
6042         * c-varobj.c: Revert.
6043         * c-valprint.c: Revert.
6044         * c-typeprint.c: Revert.
6045         * c-lang.c: Revert.
6046         * buildsym.c: Revert.
6047         * buildsym-legacy.c: Revert.
6048         * build-id.h: Revert.
6049         * build-id.c: Revert.
6050         * btrace.c: Revert.
6051         * bsd-uthread.c: Revert.
6052         * breakpoint.h: Revert.
6053         * breakpoint.c: Revert.
6054         * break-catch-throw.c: Revert.
6055         * break-catch-syscall.c: Revert.
6056         * break-catch-sig.c: Revert.
6057         * blockframe.c: Revert.
6058         * block.c: Revert.
6059         * bfin-tdep.c: Revert.
6060         * bfin-linux-tdep.c: Revert.
6061         * bfd-target.c: Revert.
6062         * bcache.c: Revert.
6063         * ax-general.c: Revert.
6064         * ax-gdb.h: Revert.
6065         * ax-gdb.c: Revert.
6066         * avr-tdep.c: Revert.
6067         * auxv.c: Revert.
6068         * auto-load.c: Revert.
6069         * arm-wince-tdep.c: Revert.
6070         * arm-tdep.c: Revert.
6071         * arm-symbian-tdep.c: Revert.
6072         * arm-pikeos-tdep.c: Revert.
6073         * arm-obsd-tdep.c: Revert.
6074         * arm-nbsd-tdep.c: Revert.
6075         * arm-nbsd-nat.c: Revert.
6076         * arm-linux-tdep.c: Revert.
6077         * arm-linux-nat.c: Revert.
6078         * arm-fbsd-tdep.c: Revert.
6079         * arm-fbsd-nat.c: Revert.
6080         * arm-bsd-tdep.c: Revert.
6081         * arch-utils.c: Revert.
6082         * arc-tdep.c: Revert.
6083         * arc-newlib-tdep.c: Revert.
6084         * annotate.h: Revert.
6085         * annotate.c: Revert.
6086         * amd64-windows-tdep.c: Revert.
6087         * amd64-windows-nat.c: Revert.
6088         * amd64-tdep.c: Revert.
6089         * amd64-sol2-tdep.c: Revert.
6090         * amd64-obsd-tdep.c: Revert.
6091         * amd64-obsd-nat.c: Revert.
6092         * amd64-nbsd-tdep.c: Revert.
6093         * amd64-nbsd-nat.c: Revert.
6094         * amd64-nat.c: Revert.
6095         * amd64-linux-tdep.c: Revert.
6096         * amd64-linux-nat.c: Revert.
6097         * amd64-fbsd-tdep.c: Revert.
6098         * amd64-fbsd-nat.c: Revert.
6099         * amd64-dicos-tdep.c: Revert.
6100         * amd64-darwin-tdep.c: Revert.
6101         * amd64-bsd-nat.c: Revert.
6102         * alpha-tdep.c: Revert.
6103         * alpha-obsd-tdep.c: Revert.
6104         * alpha-nbsd-tdep.c: Revert.
6105         * alpha-mdebug-tdep.c: Revert.
6106         * alpha-linux-tdep.c: Revert.
6107         * alpha-linux-nat.c: Revert.
6108         * alpha-bsd-tdep.c: Revert.
6109         * alpha-bsd-nat.c: Revert.
6110         * aix-thread.c: Revert.
6111         * agent.c: Revert.
6112         * addrmap.c: Revert.
6113         * ada-varobj.c: Revert.
6114         * ada-valprint.c: Revert.
6115         * ada-typeprint.c: Revert.
6116         * ada-tasks.c: Revert.
6117         * ada-lang.c: Revert.
6118         * aarch64-tdep.c: Revert.
6119         * aarch64-ravenscar-thread.c: Revert.
6120         * aarch64-newlib-tdep.c: Revert.
6121         * aarch64-linux-tdep.c: Revert.
6122         * aarch64-linux-nat.c: Revert.
6123         * aarch64-fbsd-tdep.c: Revert.
6124         * aarch64-fbsd-nat.c: Revert.
6125         * aarch32-linux-nat.c: Revert.
6126
6127 2019-04-05  Tom Tromey  <tom@tromey.com>
6128
6129         * ft32-tdep.c: Sort headers.
6130         * frv-tdep.c: Sort headers.
6131         * frv-linux-tdep.c: Sort headers.
6132         * frame.c: Sort headers.
6133         * frame-unwind.c: Sort headers.
6134         * frame-base.c: Sort headers.
6135         * fork-child.c: Sort headers.
6136         * findvar.c: Sort headers.
6137         * findcmd.c: Sort headers.
6138         * filesystem.c: Sort headers.
6139         * filename-seen-cache.h: Sort headers.
6140         * filename-seen-cache.c: Sort headers.
6141         * fbsd-tdep.c: Sort headers.
6142         * fbsd-nat.h: Sort headers.
6143         * fbsd-nat.c: Sort headers.
6144         * f-valprint.c: Sort headers.
6145         * f-typeprint.c: Sort headers.
6146         * f-lang.c: Sort headers.
6147         * extension.h: Sort headers.
6148         * extension.c: Sort headers.
6149         * extension-priv.h: Sort headers.
6150         * expprint.c: Sort headers.
6151         * exec.h: Sort headers.
6152         * exec.c: Sort headers.
6153         * exceptions.c: Sort headers.
6154         * event-top.c: Sort headers.
6155         * event-loop.c: Sort headers.
6156         * eval.c: Sort headers.
6157         * elfread.c: Sort headers.
6158         * dwarf2read.h: Sort headers.
6159         * dwarf2read.c: Sort headers.
6160         * dwarf2loc.c: Sort headers.
6161         * dwarf2expr.h: Sort headers.
6162         * dwarf2expr.c: Sort headers.
6163         * dwarf2-frame.c: Sort headers.
6164         * dwarf2-frame-tailcall.c: Sort headers.
6165         * dwarf-index-write.h: Sort headers.
6166         * dwarf-index-write.c: Sort headers.
6167         * dwarf-index-common.c: Sort headers.
6168         * dwarf-index-cache.h: Sort headers.
6169         * dwarf-index-cache.c: Sort headers.
6170         * dummy-frame.c: Sort headers.
6171         * dtrace-probe.c: Sort headers.
6172         * disasm.h: Sort headers.
6173         * disasm.c: Sort headers.
6174         * disasm-selftests.c: Sort headers.
6175         * dictionary.c: Sort headers.
6176         * dicos-tdep.c: Sort headers.
6177         * demangle.c: Sort headers.
6178         * dcache.h: Sort headers.
6179         * dcache.c: Sort headers.
6180         * darwin-nat.h: Sort headers.
6181         * darwin-nat.c: Sort headers.
6182         * darwin-nat-info.c: Sort headers.
6183         * d-valprint.c: Sort headers.
6184         * d-namespace.c: Sort headers.
6185         * d-lang.c: Sort headers.
6186         * ctf.c: Sort headers.
6187         * csky-tdep.c: Sort headers.
6188         * csky-linux-tdep.c: Sort headers.
6189         * cris-tdep.c: Sort headers.
6190         * cris-linux-tdep.c: Sort headers.
6191         * cp-valprint.c: Sort headers.
6192         * cp-support.c: Sort headers.
6193         * cp-namespace.c: Sort headers.
6194         * cp-abi.c: Sort headers.
6195         * corelow.c: Sort headers.
6196         * corefile.c: Sort headers.
6197         * continuations.c: Sort headers.
6198         * completer.h: Sort headers.
6199         * completer.c: Sort headers.
6200         * complaints.c: Sort headers.
6201         * coffread.c: Sort headers.
6202         * coff-pe-read.c: Sort headers.
6203         * cli-out.h: Sort headers.
6204         * cli-out.c: Sort headers.
6205         * charset.c: Sort headers.
6206         * c-varobj.c: Sort headers.
6207         * c-valprint.c: Sort headers.
6208         * c-typeprint.c: Sort headers.
6209         * c-lang.c: Sort headers.
6210         * buildsym.c: Sort headers.
6211         * buildsym-legacy.c: Sort headers.
6212         * build-id.h: Sort headers.
6213         * build-id.c: Sort headers.
6214         * btrace.c: Sort headers.
6215         * bsd-uthread.c: Sort headers.
6216         * breakpoint.h: Sort headers.
6217         * breakpoint.c: Sort headers.
6218         * break-catch-throw.c: Sort headers.
6219         * break-catch-syscall.c: Sort headers.
6220         * break-catch-sig.c: Sort headers.
6221         * blockframe.c: Sort headers.
6222         * block.c: Sort headers.
6223         * bfin-tdep.c: Sort headers.
6224         * bfin-linux-tdep.c: Sort headers.
6225         * bfd-target.c: Sort headers.
6226         * bcache.c: Sort headers.
6227         * ax-general.c: Sort headers.
6228         * ax-gdb.h: Sort headers.
6229         * ax-gdb.c: Sort headers.
6230         * avr-tdep.c: Sort headers.
6231         * auxv.c: Sort headers.
6232         * auto-load.c: Sort headers.
6233         * arm-wince-tdep.c: Sort headers.
6234         * arm-tdep.c: Sort headers.
6235         * arm-symbian-tdep.c: Sort headers.
6236         * arm-pikeos-tdep.c: Sort headers.
6237         * arm-obsd-tdep.c: Sort headers.
6238         * arm-nbsd-tdep.c: Sort headers.
6239         * arm-nbsd-nat.c: Sort headers.
6240         * arm-linux-tdep.c: Sort headers.
6241         * arm-linux-nat.c: Sort headers.
6242         * arm-fbsd-tdep.c: Sort headers.
6243         * arm-fbsd-nat.c: Sort headers.
6244         * arm-bsd-tdep.c: Sort headers.
6245         * arch-utils.c: Sort headers.
6246         * arc-tdep.c: Sort headers.
6247         * arc-newlib-tdep.c: Sort headers.
6248         * annotate.h: Sort headers.
6249         * annotate.c: Sort headers.
6250         * amd64-windows-tdep.c: Sort headers.
6251         * amd64-windows-nat.c: Sort headers.
6252         * amd64-tdep.c: Sort headers.
6253         * amd64-sol2-tdep.c: Sort headers.
6254         * amd64-obsd-tdep.c: Sort headers.
6255         * amd64-obsd-nat.c: Sort headers.
6256         * amd64-nbsd-tdep.c: Sort headers.
6257         * amd64-nbsd-nat.c: Sort headers.
6258         * amd64-nat.c: Sort headers.
6259         * amd64-linux-tdep.c: Sort headers.
6260         * amd64-linux-nat.c: Sort headers.
6261         * amd64-fbsd-tdep.c: Sort headers.
6262         * amd64-fbsd-nat.c: Sort headers.
6263         * amd64-dicos-tdep.c: Sort headers.
6264         * amd64-darwin-tdep.c: Sort headers.
6265         * amd64-bsd-nat.c: Sort headers.
6266         * alpha-tdep.c: Sort headers.
6267         * alpha-obsd-tdep.c: Sort headers.
6268         * alpha-nbsd-tdep.c: Sort headers.
6269         * alpha-mdebug-tdep.c: Sort headers.
6270         * alpha-linux-tdep.c: Sort headers.
6271         * alpha-linux-nat.c: Sort headers.
6272         * alpha-bsd-tdep.c: Sort headers.
6273         * alpha-bsd-nat.c: Sort headers.
6274         * aix-thread.c: Sort headers.
6275         * agent.c: Sort headers.
6276         * addrmap.c: Sort headers.
6277         * ada-varobj.c: Sort headers.
6278         * ada-valprint.c: Sort headers.
6279         * ada-typeprint.c: Sort headers.
6280         * ada-tasks.c: Sort headers.
6281         * ada-lang.c: Sort headers.
6282         * aarch64-tdep.c: Sort headers.
6283         * aarch64-ravenscar-thread.c: Sort headers.
6284         * aarch64-newlib-tdep.c: Sort headers.
6285         * aarch64-linux-tdep.c: Sort headers.
6286         * aarch64-linux-nat.c: Sort headers.
6287         * aarch64-fbsd-tdep.c: Sort headers.
6288         * aarch64-fbsd-nat.c: Sort headers.
6289         * aarch32-linux-nat.c: Sort headers.
6290
6291 2019-04-04  Tom Tromey  <tom@tromey.com>
6292
6293         * varobj.c (varobj_create): Update.
6294         * rust-exp.y (struct rust_parser) <update_innermost_block,
6295         lookup_symbol>: New methods.
6296         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
6297         Rename.
6298         (rust_parser::rust_lookup_type)
6299         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6300         * printcmd.c (display_command, do_one_display): Update.
6301         * parser-defs.h (struct parser_state) <parser_state>: Add
6302         "tracker" parameter.
6303         (block_tracker): New member.
6304         (class innermost_block_tracker) <innermost_block_tracker>: Add
6305         "types" parameter.
6306         <reset>: Remove method.
6307         (innermost_block): Don't declare.
6308         (null_post_parser): Update.
6309         * parse.c (innermost_block): Remove global.
6310         (write_dollar_variable): Update.
6311         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
6312         Remove "tracker_types" parameter.
6313         (parse_expression): Add "tracker" parameter.
6314         (parse_expression_for_completion): Update.
6315         (null_post_parser): Add "tracker" parameter.
6316         * p-exp.y: Update rules.
6317         * m2-exp.y: Update rules.
6318         * language.h (struct language_defn) <la_post_parser>: Add
6319         "tracker" parameter.
6320         * go-exp.y: Update rules.
6321         * f-exp.y: Update rules.
6322         * expression.h (parse_expression, parse_exp_1): Add "tracker"
6323         parameter.
6324         * d-exp.y: Update rules.
6325         * c-exp.y: Update rules.
6326         * breakpoint.c (set_breakpoint_condition): Create an
6327         innermost_block_tracker.
6328         (watch_command_1): Likewise.
6329         * ada-lang.c (resolve): Add "tracker" parameter.
6330         (resolve_subexp): Likewise.
6331         * ada-exp.y (write_var_from_sym): Update.
6332
6333 2019-04-04  Tom Tromey  <tom@tromey.com>
6334
6335         * type-stack.h: New file.
6336         * type-stack.c: New file.
6337         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
6338         type-stack.h.
6339         (insert_into_type_stack, insert_type, push_type, push_type_int)
6340         (insert_type_address_space, pop_type, pop_type_int)
6341         (pop_typelist, pop_type_stack, append_type_stack)
6342         (push_type_stack, get_type_stack, push_typelist)
6343         (follow_type_instance_flags, follow_types): Don't declare.
6344         * parse.c (type_stack): Remove global.
6345         (parse_exp_in_context): Update.
6346         (insert_into_type_stack, insert_type, push_type, push_type_int)
6347         (insert_type_address_space, pop_type, pop_type_int)
6348         (pop_typelist, pop_type_stack, append_type_stack)
6349         (push_type_stack, get_type_stack, push_typelist)
6350         (follow_type_instance_flags, follow_types): Remove (moved to
6351         type-stack.c).
6352         * f-exp.y (type_stack): New global.
6353         Update rules.
6354         (push_kind_type, f_parse): Update.
6355         * d-exp.y (type_stack): New global.
6356         Update rules.
6357         (d_parse): Update.
6358         * c-exp.y (struct c_parse_state) <type_stack>: New member.
6359         Update rules.
6360         * Makefile.in (COMMON_SFILES): Add type-stack.c.
6361         (HFILES_NO_SRCDIR): Add type-stack.h.
6362
6363 2019-04-04  Tom Tromey  <tom@tromey.com>
6364
6365         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
6366         (rust_parser::convert_ast_to_expression, rust_parse)
6367         (rust_lex_test_completion, rust_lex_tests): Update.
6368         * parser-defs.h (struct expr_completion_state): New.
6369         (struct parser_state) <parser_state>: Add completion parameter.
6370         <mark_struct_expression, mark_completion_tag>: New methods.
6371         <parse_completion, m_completion_state>: New members.
6372         (prefixify_expression, null_post_parser): Update.
6373         (mark_struct_expression, mark_completion_tag): Don't declare.
6374         * parse.c (parse_completion, expout_last_struct)
6375         (expout_tag_completion_type, expout_completion_name): Remove
6376         globals.
6377         (parser_state::mark_struct_expression)
6378         (parser_state::mark_completion_tag): Now methods.
6379         (prefixify_expression): Add last_struct parameter.
6380         (prefixify_subexp): Likewise.
6381         (parse_exp_1): Update.
6382         (parse_exp_in_context): Add cstate parameter.  Update.
6383         (parse_expression_for_completion): Create an
6384         expr_completion_state.
6385         (null_post_parser): Add "completion" parameter.
6386         * p-exp.y: Update rules.
6387         (yylex): Update.
6388         * language.h (struct language_defn) <la_post_parser>: Add
6389         "completing" parameter.
6390         * go-exp.y: Update rules.
6391         (lex_one_token): Update.
6392         * expression.h (parse_completion): Don't declare.
6393         * d-exp.y: Update rules.
6394         (lex_one_token): Update rules.
6395         * c-exp.y: Update rules.
6396         (lex_one_token): Update.
6397         * ada-lang.c (resolve): Add "parse_completion" parameter.
6398         (resolve_subexp): Likewise.
6399         (ada_resolve_function): Likewise.
6400
6401 2019-04-04  Tom Tromey  <tom@tromey.com>
6402
6403         * parser-defs.h (struct parser_state) <start_arglist,
6404         end_arglist>: New methods.
6405         <arglist_len, m_funcall_chain>: New members.
6406         (arglist_len, start_arglist, end_arglist): Don't declare.
6407         * parse.c (arglist_len, funcall_chain): Remove global.
6408         (start_arglist, end_arglist): Remove functions.
6409         (parse_exp_in_context): Update.
6410         * p-exp.y: Update rules.
6411         * m2-exp.y: Update rules.
6412         * go-exp.y: Update rules.
6413         * f-exp.y: Update rules.
6414         * d-exp.y: Update rules.
6415         * c-exp.y: Update rules.
6416
6417 2019-04-04  Tom Tromey  <tom@tromey.com>
6418
6419         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
6420         lex_operator, push_back>: New methods.
6421         Update all rules.
6422         (rust_parser::lex_hex, lex_escape): Rename and update.
6423         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
6424         (rust_parser::lex_operator): Rename and update.
6425         (rust_parser::lex_number, rustyylex, rustyyerror)
6426         (rust_lex_test_init, rust_lex_test_sequence)
6427         (rust_lex_test_push_back, rust_lex_tests): Update.
6428         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
6429         parameter.
6430         <lexptr, prev_lexptr>: New members.
6431         (lexptr, prev_lexptr): Don't declare.
6432         * parse.c (lexptr, prev_lexptr): Remove globals.
6433         (parse_exp_in_context): Update.
6434         * p-exp.y (yylex, yyerror): Update.
6435         * m2-exp.y (parse_number, yylex, yyerror): Update.
6436         * go-exp.y (lex_one_token, yyerror): Update.
6437         * f-exp.y (match_string_literal, yylex, yyerror): Update.
6438         * d-exp.y (lex_one_token, yyerror): Update.
6439         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
6440         (lex_one_token, yyerror): Update.
6441         * ada-lex.l (YY_INPUT): Update.
6442         (rewind_to_char): Update.
6443         * ada-exp.y (yyerror): Update.
6444
6445 2019-04-04  Tom Tromey  <tom@tromey.com>
6446
6447         * rust-exp.y (rustyylex, rust_lex_tests): Update.
6448         * parser-defs.h (struct parser_state) <parser_state>: Add new
6449         parameter.
6450         <comma_terminates>: New member.
6451         (comma_terminates): Don't declare global.
6452         * parse.c (comma_terminates): Remove global.
6453         (parse_exp_in_context): Update.
6454         * p-exp.y (yylex): Update.
6455         * m2-exp.y (yylex): Update.
6456         * go-exp.y (lex_one_token): Update.
6457         * f-exp.y (yylex): Update.
6458         * d-exp.y (lex_one_token): Update.
6459         * c-exp.y (lex_one_token): Update.
6460         * ada-lex.l: Update.
6461
6462 2019-04-04  Tom Tromey  <tom@tromey.com>
6463
6464         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
6465         (rustyylex, rust_lex_test_init, rust_lex_test_one)
6466         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
6467         * parser-defs.h (paren_depth): Don't declare.
6468         * parse.c (paren_depth): Remove global.
6469         (parse_exp_in_context): Update.
6470         * p-exp.y (paren_depth): New global.
6471         (pascal_parse): Initialize it.
6472         * m2-exp.y (paren_depth): New global.
6473         (m2_parse): Initialize it.
6474         * go-exp.y (paren_depth): New global.
6475         (go_parse): Initialize it.
6476         * f-exp.y (paren_depth): New global.
6477         (f_parse): Initialize it.
6478         * d-exp.y (paren_depth): New global.
6479         (d_parse): Initialize it.
6480         * c-exp.y (paren_depth): New global.
6481         (c_parse): Initialize it.
6482         * ada-lex.l (paren_depth): New global.
6483         (lexer_init): Initialize it.
6484
6485 2019-04-04  Tom Tromey  <tom@tromey.com>
6486
6487         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
6488         (rust_parser::convert_ast_to_type)
6489         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
6490         * parser-defs.h (struct parser_state) <parser_state>: Add
6491         parameters.  Initialize new members.
6492         <expression_context_block, expression_context_pc>: New members.
6493         * parse.c (expression_context_block, expression_context_pc):
6494         Remove globals.
6495         (parse_exp_in_context): Update.
6496         * p-exp.y: Update all rules.
6497         (yylex): Update.
6498         * m2-exp.y: Update all rules.
6499         (yylex): Update.
6500         * go-exp.y (yylex): Update.
6501         * f-exp.y (yylex): Update.
6502         * d-exp.y: Update all rules.
6503         (yylex): Update.
6504         * c-exp.y: Update all rules.
6505         (lex_one_token, classify_name, yylex, c_parse): Update.
6506         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
6507
6508 2019-04-04  Tom Tromey  <tom@tromey.com>
6509
6510         * gdbarch.h, gdbarch.c: Rebuild.
6511         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
6512         * stap-probe.h:
6513         (struct stap_parse_info): Replace "parser_state" with
6514         "expr_builder".
6515         * parser-defs.h (struct expr_builder): Rename from "parser_state".
6516         (parser_state): New class.
6517         * parse.c (expr_builder): Rename.
6518         (expr_builder::release): Rename.
6519         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
6520         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
6521         (write_exp_elt_longcst, write_exp_elt_floatcst)
6522         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
6523         (write_exp_string_vector, write_exp_bitstring)
6524         (write_exp_msymbol, mark_struct_expression)
6525         (write_dollar_variable)
6526         (insert_type_address_space, increase_expout_size): Replace
6527         "parser_state" with "expr_builder".
6528         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
6529         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
6530         "parser_state" with "expr_builder".
6531
6532 2019-04-04  Tom Tromey  <tom@tromey.com>
6533
6534         * rust-exp.y: Replace "parse_language" with method call.
6535         * p-exp.y:
6536         (yylex): Replace "parse_language" with method call.
6537         * m2-exp.y:
6538         (yylex): Replace "parse_language" with method call.
6539         * go-exp.y (classify_name): Replace "parse_language" with method
6540         call.
6541         * f-exp.y (yylex): Replace "parse_language" with method call.
6542         * d-exp.y (lex_one_token): Replace "parse_language" with method
6543         call.
6544         * c-exp.y:
6545         (lex_one_token, classify_name, yylex): Replace "parse_language"
6546         with method call.
6547         * ada-exp.y (find_primitive_type, type_char)
6548         (type_system_address): Replace "parse_language" with method call.
6549
6550 2019-04-04  Tom Tromey  <tom@tromey.com>
6551
6552         * rust-exp.y: Replace "parse_gdbarch" with method call.
6553         * parse.c (write_dollar_variable, insert_type_address_space):
6554         Replace "parse_gdbarch" with method call.
6555         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
6556         call.
6557         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
6558         call.
6559         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
6560         "parse_gdbarch" with method call.
6561         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
6562         with method call.
6563         * f-exp.y (parse_type, parse_f_type, yylex): Replace
6564         "parse_gdbarch" with method call.
6565         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
6566         "parse_gdbarch" with method call.
6567         * c-exp.y (parse_type, parse_number, classify_name): Replace
6568         "parse_gdbarch" with method call.
6569         * ada-lex.l: Replace "parse_gdbarch" with method call.
6570         * ada-exp.y (parse_type, find_primitive_type, type_char)
6571         (type_system_address): Replace "parse_gdbarch" with method call.
6572
6573 2019-04-04  Tom Tromey  <tom@tromey.com>
6574
6575         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
6576         * stap-probe.c (stap_parse_argument): Update.
6577         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
6578         initial_size parameter.
6579         * rust-exp.y (rust_lex_tests): Update.
6580         * parse.c (parser_state): Update.
6581         (parse_exp_in_context): Update.
6582         * parser-defs.h (struct parser_state) <parser_state>: Remove
6583         "initial_size" parameter.
6584
6585 2019-04-04  Tom Tromey  <tom@tromey.com>
6586
6587         * parser-defs.h (increase_expout_size): Don't declare.
6588         * parse.c (increase_expout_size): Now static.
6589
6590 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
6591
6592         * gnu-nat.c (gnu_nat_target::wait): Fix
6593         target_waitstatus_to_string call.
6594
6595 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6596
6597         * eval.c (evaluate_subexp_standard): Handle internal functions
6598         during Fortran function call handling.
6599
6600 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6601
6602         * NEWS: Mention new internal functions.
6603         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
6604         (read_base_type): Use dwarf2_init_complex_target_type.
6605         * value.c (creal_internal_fn): New function.
6606         (cimag_internal_fn): New function.
6607         (_initialize_values): Register new internal functions.
6608
6609 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6610
6611         * infrun.c (stop_all_threads): If debug_infrun, always
6612         trace the wait status after wait_one, using
6613         target_waitstatus_to_string and target_pid_to_str.
6614         (handle_inferior_event): Replace various trace of
6615         wait status kind by a single trace.
6616         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
6617         wait status kind image by target_waitstatus_to_string.
6618         * target/waitstatus.c (target_waitstatus_to_string): Fix
6619         obsolete comment.
6620
6621 2019-04-01  Tom Tromey  <tromey@adacore.com>
6622
6623         PR symtab/23331:
6624         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
6625
6626 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
6627             Pedro Alves  <palves@redhat.com>
6628
6629         * top.c (quit_force): Call 'finalize_values'.
6630         * value.c (finalize_values): New function.
6631         * value.h (finalize_values): Declare.
6632
6633 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
6634
6635         * NEWS: Announce $_gdb_major and $_gdb_minor.
6636
6637         * top.c (init_gdb_version_vars): New function.
6638         (gdb_init): Call init_gdb_version_vars.
6639
6640 2019-03-29  Tom Tromey  <tromey@adacore.com>
6641
6642         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
6643         help text.  Remove dead code.
6644
6645 2019-03-29  Keith Seitz  <keiths@redhat.com>
6646
6647         From Siddhesh Poyarekar:
6648         * f-lang.h (f77_get_upperbound): Return LONGEST.
6649         (f77_get_lowerbound): Likewise.
6650         * f-typeprint.c (f_type_print_varspec_suffix): Expand
6651         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
6652         print them.
6653         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
6654         plongest to format print it.
6655         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
6656         (f77_get_upperbound): Likewise.
6657         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
6658         LOWER_BOUND to LONGEST.
6659         (f77_create_arrayprint_offset_tbl): Likewise.
6660
6661 2019-03-29  Keith Seitz  <keiths@redhat.com>
6662
6663         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
6664         %s/pulongest for TYPE_LENGTH instead of %d in format
6665         strings.
6666         * ada-typerint.c (ada_print_type): Likewise.
6667         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
6668         * compile/compile-c-support.c (generate_register_struct): Likewise.
6669         * gdbtypes.c (recursive_dump_type): Likewise.
6670         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
6671         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
6672         instead of %d in format strings.
6673         * riscv-tdep.c (riscv_type_alignment): Cast second argument
6674         to std::min to ULONGEST.
6675         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
6676         instead of %d in format strings.
6677         * tracepoint.c (info_scope_command): Likewise.
6678         * typeprint.c (print_offset_data::update)
6679         (print_offset_data::finish): Likewise.
6680         * xtensa-tdep.c (xtensa_store_return_value)
6681         (xtensa_push_dummy_call): Likewise.
6682
6683 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
6684
6685         * windows-nat.c (display_selector): Fixed format specifications
6686         for 64-bit Cygwin.
6687
6688 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6689
6690         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
6691
6692 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
6693
6694         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
6695         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
6696         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
6697         (nios2_linux_init_abi): Install it.
6698
6699 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6700
6701         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
6702
6703 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
6704
6705         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
6706
6707 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6708             Tom Tromey  <tromey@adacore.com>
6709
6710         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
6711
6712 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
6713
6714         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
6715         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
6716         method to compute the bounds of range types. Also print "[evaluated]"
6717         if the bounds' values come from a dynamic evaluation.
6718
6719 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6720
6721         * cp-valprint.c (cp_print_value_fields): Don't print trailing
6722         whitespace when pretty printing is on.
6723
6724 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6725
6726         * ppc-linux-nat.c: Add include.
6727
6728 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6729
6730         * NEWS: Mention AArch64 Pointer Authentication.
6731
6732 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
6733
6734         * arm-linux-nat.c: Add include.
6735
6736 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
6737
6738         * source-cache.c (source_cache::get_source_lines): Re-read
6739         fullname after calling open_source_file.
6740
6741 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
6742
6743         * NEWS: Mention TLS support for FreeBSD.
6744
6745 2019-03-25  Tom Tromey  <tromey@adacore.com>
6746
6747         * minsyms.c (BUNCH_SIZE): Update comment.
6748         (~minimal_symbol_reader): Remove old comment.
6749         (compact_minimal_symbols): Update comment.
6750         (minimal_symbol_reader::install): Remove old comment.  Update
6751         other comments.
6752
6753 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6754
6755         * s390-linux-nat.c: Add include.
6756
6757 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
6758
6759         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6760         Call linux_get_hwcap.
6761         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
6762         Likewise.
6763         (aarch64_linux_get_hwcap): Remove function.
6764         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
6765         declaration.
6766         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
6767         linux_get_hwcap.
6768         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6769         * linux-tdep.c (linux_get_hwcap): Add function.
6770         (linux_get_hwcap2): Likewise.
6771         * linux-tdep.h (linux_get_hwcap): Add declaration.
6772         (linux_get_hwcap2): Likewise.
6773         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
6774         (ppc_linux_get_hwcap2): Likewise.
6775         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
6776         linux_get_hwcap.
6777         (ppc_linux_nat_target::insert_watchpoint): Likewise.
6778         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
6779         (ppc_linux_nat_target::read_description): Likewise.
6780         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
6781         * s390-linux-nat.c: Likewise.
6782         * s390-linux-tdep.c (s390_core_read_description): Likewise.
6783
6784 2019-03-24  Tom Tromey  <tom@tromey.com>
6785
6786         * ada-lang.c (standard_lookup): Simplify initialization.
6787         (ada_lookup_symbol_nonlocal): Simplify return.
6788         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
6789         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
6790         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
6791         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
6792         initialization.
6793         * solib.c (solib_global_lookup): Simplify.
6794         * symtab.c (null_block_symbol): Remove.
6795         (symbol_cache_lookup): Simplify returns.
6796         (lookup_language_this): Simplify returns.
6797         (lookup_symbol_aux): Simplify return.
6798         (lookup_local_symbol): Simplify returns.
6799         (lookup_global_symbol_from_objfile): Simplify return.
6800         (lookup_symbol_in_objfile_symtabs)
6801         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6802         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6803         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6804         * cp-namespace.c (cp_lookup_bare_symbol)
6805         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6806         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6807         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6808         (cp_lookup_symbol_via_imports): Simplify initialization.
6809         (find_symbol_in_baseclass): Likewise.
6810         * symtab.h (null_block_symbol): Remove.
6811         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6812         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6813         (d_lookup_symbol_module): Likewise.
6814         (find_symbol_in_baseclass): Simplify initialization.
6815
6816 2019-03-24  Tom Tromey  <tom@tromey.com>
6817
6818         * expression.h: Don't include symtab.h.
6819         (struct block): Forward declare.
6820
6821 2019-03-24  Tom Tromey  <tom@tromey.com>
6822
6823         * c-exp.y (typebase): Remove casts.
6824         * gdbtypes.c (lookup_unsigned_typename, )
6825         (lookup_signed_typename): Remove cast.
6826         * eval.c (parse_to_comma_and_eval): Remove cast.
6827         * parse.c (write_dollar_variable): Remove cast.
6828         * block.h (struct block) <superblock>: Now const.
6829         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6830         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6831         (map_block): Make "block" const.
6832         * symfile.h (struct quick_symbol_functions)
6833         <map_matching_symbols>: Constify block argument to "callback".
6834         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6835         const.
6836         (find_pc_sect_compunit_symtab): Make "b" const.
6837         (find_symbol_at_address): Likewise.
6838         (search_symbols): Likewise.
6839         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6840         (dw2_debug_names_lookup_symbol): Likewise.
6841         (dw2_map_matching_symbols): Update.
6842         * p-valprint.c (pascal_val_print): Remove "block".
6843         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6844         (aux_add_nonlocal_symbols): Make "block" const.
6845         (resolve_subexp): Remove cast.
6846         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6847         const.
6848         (iterate_over_file_blocks): Likewise.
6849         * f-exp.y (%union) <bval>: Remove.
6850         * coffread.c (patch_opaque_types): Make "b" const.
6851         * spu-tdep.c (spu_catch_start): Make "block" const.
6852         * c-valprint.c (print_unpacked_pointer): Remove "block".
6853         * symmisc.c (dump_symtab_1): Make "b" const.
6854         (block_depth): Make "block" const.
6855         * d-exp.y (%union) <bval>: Remove.
6856         * cp-support.h (cp_lookup_rtti_type): Update.
6857         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6858         * psymtab.c (psym_lookup_symbol): Make "block" const.
6859         (maintenance_check_psymtabs): Make "b" const.
6860         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6861         (enumerate_locals, enumerate_args): Update.
6862         * python/py-symtab.c (stpy_global_block): Make "block" const.
6863         (stpy_static_block): Likewise.
6864         * inline-frame.c (block_starting_point_at): Make "new_block"
6865         const.
6866         * block.c (find_block_in_blockvector): Make return type const.
6867         (blockvector_for_pc_sect): Make "b" const.
6868         (find_block_in_blockvector): Make "b" const.
6869
6870 2019-03-23  Tom Tromey  <tom@tromey.com>
6871
6872         * varobj.c (varobj_create): Update.
6873         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6874         * printcmd.c (display_command, do_one_display): Don't reset
6875         innermost_block.
6876         * parser-defs.h (enum innermost_block_tracker_type): Move to
6877         expression.h.
6878         (innermost_block): Update comment.
6879         * parse.c (parse_exp_1): Add tracker_types parameter.
6880         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6881         tracker_types parameter.  Reset innermost_block.
6882         (parse_exp_in_context): Remove.
6883         (parse_expression_for_completion): Update.
6884         * objfiles.c (~objfile): Don't reset expression_context_block or
6885         innermost_block.
6886         * expression.h (enum innermost_block_tracker_type): Move from
6887         parser-defs.h.
6888         (parse_exp_1): Add tracker_types parameter.
6889         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6890         reset innermost_block.
6891
6892 2019-03-23  Tom Tromey  <tom@tromey.com>
6893
6894         * objfiles.h: Include bcache.h.
6895
6896 2019-03-23  Tom Tromey  <tom@tromey.com>
6897
6898         * linespec.c (get_current_search_block): Use
6899         scoped_restore_current_language.
6900         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6901
6902 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6903             Jiong Wang  <jiong.wang@arm.com>
6904
6905         * aarch64-linux-tdep.c
6906         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6907         section.
6908         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6909
6910 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6911             Jiong Wang  <jiong.wang@arm.com>
6912
6913         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6914         instructions.
6915         (aarch64_analyze_prologue_test): Add PACIASP test.
6916         (aarch64_prologue_prev_register): Unmask PC value.
6917
6918 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6919             Jiong Wang  <jiong.wang@arm.com>
6920
6921         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6922         (aarch64_dwarf2_prev_register): Unmask PC value.
6923         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6924         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6925         DW_CFA_AARCH64_negate_ra_state.
6926         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6927
6928 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6929             Jiong Wang  <jiong.wang@arm.com>
6930
6931         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6932         registers.
6933         (aarch64_pseudo_register_name): Likewise.
6934         (aarch64_pseudo_register_type): Likewise.
6935         (aarch64_pseudo_register_reggroup_p): Likewise.
6936         (aarch64_gdbarch_init): Add pauth registers.
6937         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6938         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6939         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6940         (struct gdbarch_tdep): Add regnum for ra_state.
6941
6942 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6943             Jiong Wang  <jiong.wang@arm.com>
6944
6945         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6946
6947 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6948             Jiong Wang  <jiong.wang@arm.com>
6949
6950         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6951         function.
6952         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6953         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6954         (aarch64_gdbarch_init): Add puth registers.
6955         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6956         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6957         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6958
6959 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6960             Jiong Wang  <jiong.wang@arm.com>
6961
6962         * aarch64-linux-nat.c
6963         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6964         * aarch64-linux-tdep.c
6965         (aarch64_linux_core_read_description): Likewise.
6966         (aarch64_linux_get_hwcap): New function.
6967         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6968         (aarch64_linux_get_hwcap): New declaration.
6969
6970 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6971             Jiong Wang  <jiong.wang@arm.com>
6972
6973         * aarch64-linux-nat.c
6974         (aarch64_linux_nat_target::read_description): Add pauth param.
6975         * aarch64-linux-tdep.c
6976         (aarch64_linux_core_read_description): Likewise.
6977         * aarch64-tdep.c (struct target_desc): Add in pauth.
6978         (aarch64_read_description): Add pauth param.
6979         (aarch64_gdbarch_init): Likewise.
6980         * aarch64-tdep.h (aarch64_read_description): Likewise.
6981         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6982         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6983         * features/Makefile: Add new files.
6984         * features/aarch64-pauth.c: New file.
6985         * features/aarch64-pauth.xml: New file.
6986
6987 2019-03-20  Tom Tromey  <tromey@adacore.com>
6988
6989         * infrun.c (handle_inferior_event): Rename from
6990         handle_inferior_event_1.  Create a scoped_value_mark.
6991         (handle_inferior_event): Remove.
6992
6993 2019-03-19  Tom Tromey  <tromey@adacore.com>
6994
6995         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6996         * infrun.h (print_stop_event): Add "displays" parameter.
6997         * infrun.c (print_stop_event): Add "displays" parameter.
6998
6999 2019-03-19  Pedro Alves  <palves@redhat.com>
7000
7001         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
7002         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
7003         to -1.  Fix TABs vs spaces.
7004         (tui_ui_out::tui_ui_out): Don't initialize fields here.
7005         * tui/tui-out.h (tui_ui_out) Add intro comments.
7006         <m_line, m_start_of_line>: In-class initialize, and add describing
7007         comment.
7008
7009 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
7010
7011         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
7012         variable names.
7013         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
7014
7015 2019-03-18  Pedro Alves  <palves@redhat.com>
7016             Eli Zaretskii <eliz@gnu.org>
7017
7018         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
7019         m_line and m_start_of_line.
7020
7021 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
7022
7023         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
7024         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
7025         it returns a newline.  This fixes a regression in TU mode, whereby
7026         the next line is output on the same screen line as the user input.
7027
7028 2019-03-18  Tom Tromey  <tromey@adacore.com>
7029
7030         * minsyms.c (minimal_symbol_reader::install): Remove call to
7031         obstack_blank.
7032
7033 2019-03-18  Pedro Alves  <palves@redhat.com>
7034
7035         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
7036         New globals.
7037         (apply_style): New, factored out from ...
7038         (apply_ansi_escape): ... this.  Handle reverse video mode.
7039         (tui_set_reverse_mode): New function.
7040         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
7041         * tui/tui-winsource.c (tui_show_source_line): Use
7042         tui_set_reverse_mode instead of setting A_STANDOUT.
7043         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
7044         New setter methods.
7045
7046 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
7047
7048         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
7049         Handle tabs.
7050
7051 2019-03-18  Tom Tromey  <tromey@adacore.com>
7052
7053         * ada-lang.c (empty_array): Add "high" parameter.
7054         (ada_evaluate_subexp): Update.
7055
7056 2019-03-17  Sergei Trofimovich <siarheit@google.com>
7057
7058         * unittests/string_view-selftests.c: Define
7059         _initialize_string_view_selftests unconditionally.
7060
7061 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7062
7063         PR gdb/24350
7064         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
7065
7066 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
7067
7068         PR gdb/24351
7069         * windows-nat.c (display_selector): Fix format specifiers.
7070
7071 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
7072
7073         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
7074         tui_refill_source_window instead of tui_refresh_win, to update the
7075         current execution line.  This fixes redisplay of the current line
7076         when stepping through the code with "next" or "step".
7077
7078 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7079
7080         * source-cache.c (source_cache::get_source_lines): Call
7081         find_source_lines to initialize s->nlines.  This fixes vertical
7082         scrolling of TUI source window when the DOWN arrow is pressed.
7083
7084 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7085
7086         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
7087         linux-thread-db.c (_initialize_thread_db): Likewise.
7088
7089 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
7090
7091         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
7092         wclrtoeol in tui_show_source_line".  This reverts changes made in
7093         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
7094
7095 2019-03-15  Tom Tromey  <tom@tromey.com>
7096
7097         * symtab.h (struct minimal_symbol): Derive from
7098         general_symbol_info.
7099         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
7100         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
7101         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
7102         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
7103         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
7104         (MSYMBOL_SEARCH_NAME): Update.
7105         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
7106         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
7107         * minsyms.c (minimal_symbol_reader::record_full): Update.
7108
7109 2019-03-15  Tom Tromey  <tom@tromey.com>
7110
7111         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
7112
7113 2019-03-15  Tom Tromey  <tom@tromey.com>
7114
7115         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
7116         unique_xmalloc_ptr.
7117         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
7118         Update.
7119         * minsyms.c (lookup_minimal_symbol_by_pc_section)
7120         (build_minimal_symbol_hash_tables)
7121         (minimal_symbol_reader::install): Update.
7122
7123 2019-03-15  Tom Tromey  <tom@tromey.com>
7124
7125         * symtab.c (create_demangled_names_hash): Update.
7126         (symbol_set_names): Update.
7127         * objfiles.h (struct objfile_per_bfd_storage)
7128         <demangled_names_hash>: Now an htab_up.
7129         * objfiles.c (objfile_per_bfd_storage): Simplify.
7130
7131 2019-03-15  Tom Tromey  <tom@tromey.com>
7132
7133         * objfiles.h (struct objfile_per_bfd_storage): Declare
7134         destructor.
7135         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
7136         New.
7137         (get_objfile_bfd_data): Use new.  Don't initialize
7138         language_of_main.
7139         (free_objfile_per_bfd_storage): Remove.
7140         (objfile_bfd_data_free, objfile::~objfile): Use delete.
7141
7142 2019-03-15  Tom Tromey  <tom@tromey.com>
7143
7144         * symfile.c (reread_symbols): Update.
7145         * objfiles.c (objfile::objfile): Update.
7146         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
7147         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
7148         comment.
7149         (minimal_symbol_reader::install): Update.
7150         (terminate_minimal_symbol_table): Remove.
7151         * jit.c (jit_object_close_impl): Update.
7152
7153 2019-03-15  Tom Tromey  <tom@tromey.com>
7154
7155         * minsyms.c (minimal_symbol_reader::record_full): Remove some
7156         initializations.
7157
7158 2019-03-15  Tom Tromey  <tom@tromey.com>
7159
7160         * objfiles.h (struct objfile_per_bfd_storage)
7161         <demangled_hash_languages>: Now a bitset.
7162         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
7163         (lookup_minimal_symbol): Update.
7164
7165 2019-03-15  Tom Tromey  <tom@tromey.com>
7166
7167         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
7168         Don't return the symbol.
7169         * coffread.c (record_minimal_symbol): Use record_full.
7170
7171 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
7172
7173         The MS-Windows port of ncurses fails to switch to a color pair if
7174         one or both of the colors are the implicit default colors.  This
7175         change records the default colors when TUI is initialized, and
7176         then specifies them explicitly when a color pair uses the default
7177         colors.  This allows color styling in TUI mode on MS-Windows.
7178
7179         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
7180         ncurses_norm_attr.
7181         (tui_initialize_io) [__MINGW32__]: Record the default terminal
7182         colors in ncurses_norm_attr.
7183         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
7184         "none", replace it with the default color recorded in
7185         ncurses_norm_attr.
7186
7187 2019-03-14  Tom Tromey  <tromey@adacore.com>
7188
7189         * source-cache.h (class source_cache) <get_source_lines>: Return
7190         std::string.
7191         * source-cache.c (source_cache::extract_lines): Handle case where
7192         first_pos==npos.  Return std::string.
7193         (source_cache::get_source_lines): Update.
7194
7195 2019-03-14  Tom Tromey  <tromey@adacore.com>
7196
7197         * NEWS: Add item for "style sources" commands.
7198         * source-cache.c (source_cache::get_source_lines): Check
7199         source_styling.
7200         * cli/cli-style.c (source_styling): New global.
7201         (_initialize_cli_style): Add "style sources" commands.
7202         (show_style_sources): New function.
7203         * cli/cli-style.h (source_styling): Declare.
7204
7205 2019-03-14  Pedro Alves  <palves@redhat.com>
7206             Tom Tromey  <tromey@adacore.com>
7207
7208         * tui/tui-winsource.h (tui_refill_source_window): Declare.
7209         * tui/tui-winsource.c (tui_refill_source_window): New function,
7210         from...
7211         (tui_horizontal_source_scroll): ... here.  Move some logic.
7212         * cli/cli-style.c (set_style_enabled): Notify new observable.
7213         * tui/tui-hooks.c (tui_redisplay_source): New function.
7214         (tui_attach_detach_observers): Attach or detach
7215         tui_redisplay_source.
7216         * observable.h (source_styling_changed): New observable.
7217         * observable.c: Define source_styling_changed observable.
7218
7219 2019-03-13  Tom Tromey  <tromey@adacore.com>
7220
7221         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
7222         (i386_gnu_nat_target::store_registers): Update.
7223         * target-debug.h (target_debug_print_std_string): New macro.
7224         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7225         * windows-tdep.c (display_one_tib): Update.
7226         * tui/tui-stack.c (tui_make_status_line): Update.
7227         * top.c (print_inferior_quit_action): Update.
7228         * thread.c (thr_try_catch_cmd): Update.
7229         (add_thread_with_info): Update.
7230         (thread_target_id_str): Update.
7231         (thr_try_catch_cmd): Update.
7232         (thread_command): Update.
7233         (thread_find_command): Update.
7234         * record-btrace.c (record_btrace_target::info_record)
7235         (record_btrace_resume_thread, record_btrace_target::resume)
7236         (record_btrace_cancel_resume, record_btrace_step_thread)
7237         (record_btrace_target::wait, record_btrace_target::wait)
7238         (record_btrace_target::wait, record_btrace_target::stop): Update.
7239         * progspace.c (print_program_space): Update.
7240         * process-stratum-target.c
7241         (process_stratum_target::thread_address_space): Update.
7242         * linux-fork.c (linux_fork_mourn_inferior)
7243         (detach_checkpoint_command, info_checkpoints_command)
7244         (linux_fork_context): Update.
7245         (linux_fork_detach): Update.
7246         (class scoped_switch_fork_info): Update.
7247         (delete_checkpoint_command): Update.
7248         * infrun.c (follow_fork_inferior): Update.
7249         (follow_fork_inferior): Update.
7250         (proceed_after_vfork_done): Update.
7251         (handle_vfork_child_exec_or_exit): Update.
7252         (follow_exec): Update.
7253         (displaced_step_prepare_throw): Update.
7254         (displaced_step_restore): Update.
7255         (start_step_over): Update.
7256         (resume_1): Update.
7257         (clear_proceed_status_thread): Update.
7258         (proceed): Update.
7259         (print_target_wait_results): Update.
7260         (do_target_wait): Update.
7261         (context_switch): Update.
7262         (stop_all_threads): Update.
7263         (restart_threads): Update.
7264         (finish_step_over): Update.
7265         (handle_signal_stop): Update.
7266         (switch_back_to_stepped_thread): Update.
7267         (keep_going_pass_signal): Update.
7268         (print_exited_reason): Update.
7269         (normal_stop): Update.
7270         * inferior.c (inferior_pid_to_str): Change return type.
7271         (print_selected_inferior): Update.
7272         (add_inferior): Update.
7273         (detach_inferior): Update.
7274         * dummy-frame.c (fprint_dummy_frames): Update.
7275         * dcache.c (dcache_info_1): Update.
7276         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
7277         (btrace_fetch, btrace_clear): Update.
7278         * linux-tdep.c (linux_core_pid_to_str): Change return type.
7279         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
7280         type.
7281         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
7282         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
7283         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
7284         * gdbarch.c, gdbarch.h: Rebuild.
7285         * gdbarch.sh (core_pid_to_str): Change return type.
7286         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
7287         return type.
7288         (windows_nat_target::pid_to_str): Change return type.
7289         (windows_delete_thread): Update.
7290         (windows_nat_target::attach): Update.
7291         (windows_nat_target::files_info): Update.
7292         * target-delegates.c: Rebuild.
7293         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
7294         return type.
7295         (sol_thread_target::pid_to_str): Change return type.
7296         * remote.c (class remote_target) <pid_to_str>: Change return
7297         type.
7298         (remote_target::pid_to_str): Change return type.
7299         (extended_remote_target::attach, remote_target::remote_stop_ns)
7300         (remote_target::remote_notif_remove_queued_reply)
7301         (remote_target::push_stop_reply, remote_target::disable_btrace):
7302         Update.
7303         (extended_remote_target::attach): Update.
7304         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
7305         type.
7306         (gdbsim_target::pid_to_str): Change return type.
7307         * ravenscar-thread.c (struct ravenscar_thread_target)
7308         <pid_to_str>: Change return type.
7309         (ravenscar_thread_target::pid_to_str): Change return type.
7310         * procfs.c (class procfs_target) <pid_to_str>: Change return
7311         type.
7312         (procfs_target::pid_to_str): Change return type.
7313         (procfs_target::attach): Update.
7314         (procfs_target::detach): Update.
7315         (procfs_target::fetch_registers): Update.
7316         (procfs_target::store_registers): Update.
7317         (procfs_target::wait): Update.
7318         (procfs_target::files_info): Update.
7319         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
7320         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
7321         return type.
7322         (nto_procfs_target::pid_to_str): Change return type.
7323         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
7324         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
7325         return type.
7326         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
7327         (exit_lwp): Update.
7328         (attach_proc_task_lwp_callback, get_detach_signal)
7329         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
7330         (linux_nat_target::resume, wait_lwp, stop_callback)
7331         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
7332         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
7333         (linux_nat_wait_1, resume_stopped_resumed_lwps)
7334         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
7335         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
7336         type.
7337         (inf_ptrace_target::attach): Update.
7338         (inf_ptrace_target::files_info): Update.
7339         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
7340         type.
7341         (go32_nat_target::pid_to_str): Change return type.
7342         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
7343         (gnu_nat_target::wait): Update.
7344         (gnu_nat_target::wait): Update.
7345         (gnu_nat_target::resume): Update.
7346         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
7347         (fbsd_nat_target::wait): Update.
7348         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
7349         type.
7350         (darwin_nat_target::attach): Update.
7351         * corelow.c (class core_target) <pid_to_str>: Change return type.
7352         (core_target::pid_to_str): Change return type.
7353         * target.c (normal_pid_to_str): Change return type.
7354         (default_pid_to_str): Likewise.
7355         (target_pid_to_str): Change return type.
7356         (target_translate_tls_address): Update.
7357         (target_announce_detach): Update.
7358         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
7359         return type.
7360         (bsd_uthread_target::pid_to_str): Change return type.
7361         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
7362         type.
7363         (bsd_kvm_target::pid_to_str): Change return type.
7364         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
7365         return type.
7366         (aix_thread_target::pid_to_str): Change return type.
7367         * target.h (struct target_ops) <pid_to_str>: Change return type.
7368         (target_pid_to_str, normal_pid_to_str): Likewise.
7369         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
7370         type.
7371         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
7372         type.
7373         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
7374         return type.
7375         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
7376         type.
7377         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
7378         type.
7379         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
7380         return type.
7381
7382 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
7383
7384         * NEWS: Mention that the new default MI version is 3.  Mention
7385         changes to the output of commands and events that deal with
7386         multi-location breakpoints.
7387         * breakpoint.c: Include "mi/mi-out.h".
7388         (print_one_breakpoint): Change output syntax if using MI version
7389         >= 3.
7390         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
7391         New.
7392         (mi_multi_location_breakpoint_output_fixed): New.
7393         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
7394         (mi_cmd_fix_multi_location_breakpoint_output): New.
7395         (mi_multi_location_breakpoint_output_fixed): New.
7396         * mi/mi-cmds.c (mi_cmds): Register command
7397         -fix-multi-location-breakpoint-output.
7398         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
7399         interpreter "mi".
7400
7401 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
7402
7403         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
7404         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
7405         instantiate mi_ui_out based on interpreter name.
7406         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
7407         * mi/mi-main.c (mi_load_progress): Likewise.
7408
7409 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7410
7411         * NEWS: Combine separate "New targets" sections for 8.3.
7412
7413 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7414
7415         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
7416         (ppcfbsd_init_abi): Install gdbarch
7417         "fetch_tls_load_module_address" and "get_thread_local_address"
7418         methods.
7419
7420 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7421
7422         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
7423         (riscv_fbsd_init_abi): Install gdbarch
7424         "fetch_tls_load_module_address" and "get_thread_local_address"
7425         methods.
7426
7427 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7428
7429         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
7430         (i386fbsd_init_abi): Install gdbarch
7431         "fetch_tls_load_module_address" and "get_thread_local_address"
7432         methods.
7433
7434 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7435
7436         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
7437         (amd64fbsd_init_abi): Install gdbarch
7438         "fetch_tls_load_module_address" and "get_thread_local_address"
7439         methods.
7440
7441 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7442
7443         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
7444         (struct fbsd_pspace_data): New type.
7445         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
7446         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
7447         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
7448         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
7449         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
7450
7451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7452
7453         * gdbtypes.c (lookup_struct_elt): New function.
7454         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
7455         * gdbtypes.h (struct struct_elt): New type.
7456         (lookup_struct_elt): New prototype.
7457
7458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7459
7460         * gdbtypes.c (lookup_struct_elt_type): Update comment and
7461         remove disabled code block.
7462
7463 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7464
7465         * gdbarch.sh (get_thread_local_address): New method.
7466         * gdbarch.h, gdbarch.c: Regenerate.
7467         * target.c (target_translate_tls_address): Use
7468         gdbarch_get_thread_local_address if present instead of
7469         target::get_thread_local_address.
7470
7471 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7472
7473         * target.h (target::get_thread_local_address): Update comment.
7474
7475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7476
7477         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
7478         objfile->separate_debug_objfile_backlink if not NULL.
7479
7480 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7481
7482         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
7483         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
7484         (amd64bsd_store_inferior_registers): Likewise.
7485         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7486         Enable segment base registers.
7487         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
7488         PT_GETFSBASE and PT_GETGSBASE.
7489         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
7490         PT_SETGSBASE.
7491         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
7492         segment base registers.
7493         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7494
7495 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
7496
7497         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
7498         Update calls to i386_target_description to add 'segments'
7499         parameter.
7500         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
7501         add segment base registers.
7502         * arch/i386.c (i386_create_target_description): Add 'segments'
7503         parameter to enable segment base registers.
7504         * arch/i386.h (i386_create_target_description): Likewise.
7505         * features/i386/32bit-segments.xml: New file.
7506         * features/i386/32bit-segments.c: Generate.
7507         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
7508         call to i386_target_description to add 'segments' parameter.
7509         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
7510         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
7511         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
7512         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
7513         if feature is present.
7514         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
7515         Add 'segments' parameter to call to i386_target_description.
7516         (i386_target_description): Add 'segments' parameter to enable
7517         segment base registers.
7518         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
7519         to call to i386_target_description.
7520         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
7521         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
7522         Define I386_NUM_REGS.
7523         (i386_target_description): Add 'segments' parameter to enable
7524         segment base registers.
7525
7526 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
7527
7528         PR/24325
7529         * source-cache.c: #undef open and close, to avoid unresolved
7530         externals during linking.
7531
7532 2019-03-12  Tom Tromey  <tromey@adacore.com>
7533
7534         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
7535         const.  Add initializers.
7536         (_initialize_remote): Don't initialize ptid globals.
7537
7538 2019-03-12  Pedro Alves  <palves@redhat.com>
7539
7540         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
7541
7542 2019-03-12  Pedro Alves  <palves@redhat.com>
7543
7544         * cp-name-parser.y (main): Remove unused 'len' variable.
7545
7546 2019-03-12  Tom Tromey  <tromey@adacore.com>
7547
7548         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
7549         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
7550
7551 2019-03-12  Tom Tromey  <tromey@adacore.com>
7552
7553         * linux-nat.c (iterate_over_lwps): Update.
7554         (stop_callback): Remove parameter.
7555         (stop_wait_callback, detach_callback, resume_set_callback)
7556         (select_singlestep_lwp_callback, set_ignore_sigint)
7557         (status_callback, resumed_callback, resume_clear_callback)
7558         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
7559         data parameter.
7560         (linux_nat_target::detach, linux_nat_target::resume)
7561         (linux_stop_and_wait_all_lwps, select_event_lwp)
7562         (linux_nat_filter_event, linux_nat_wait_1)
7563         (linux_nat_target::kill, linux_nat_target::stop)
7564         (linux_nat_target::stop): Update.
7565         (linux_nat_resume_callback): Change type.
7566         (resume_stopped_resumed_lwps, count_events_callback)
7567         (select_event_lwp_callback): Likewise.
7568         (linux_stop_lwp, linux_nat_stop_lwp): Update.
7569         * arm-linux-nat.c (struct update_registers_data): Remove.
7570         (update_registers_callback): Change type.
7571         (arm_linux_insert_hw_breakpoint1): Update.
7572         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
7573         parameter.
7574         (x86_linux_dr_set_addr): Update.
7575         (x86_linux_dr_set_control): Update.
7576         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
7577         (iterate_over_lwps): Use gdb::function_view.
7578         * nat/aarch64-linux-hw-point.c (struct
7579         aarch64_dr_update_callback_param): Remove.
7580         (debug_reg_change_callback): Change type.
7581         (aarch64_notify_debug_reg_change): Update.
7582         * s390-linux-nat.c (s390_refresh_per_info): Update.
7583
7584 2019-03-11  Tom Tromey  <tromey@adacore.com>
7585
7586         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
7587         redundant assignment to "this_cu".
7588
7589 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7590
7591         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
7592
7593 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7594
7595         * gdbtypes.c (rank_one_type_parm_set): New function extracted
7596         from...
7597         (rank_one_type): ... this.
7598
7599 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7600
7601         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
7602         from...
7603         (rank_one_type): ... this.
7604
7605 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7606
7607         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
7608         from...
7609         (rank_one_type): ... this.
7610
7611 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7612
7613         * gdbtypes.c (rank_one_type_parm_float): New function extracted
7614         from...
7615         (rank_one_type): ... this.
7616
7617 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7618
7619         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
7620         from...
7621         (rank_one_type): ... this.
7622
7623 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7624
7625         * gdbtypes.c (rank_one_type_parm_range): New function extracted
7626         from...
7627         (rank_one_type): ... this.
7628
7629 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7630
7631         * gdbtypes.c (rank_one_type_parm_char): New function extracted
7632         from...
7633         (rank_one_type): ... this.
7634
7635 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7636
7637         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
7638         from...
7639         (rank_one_type): ... this.
7640
7641 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7642
7643         * gdbtypes.c (rank_one_type_parm_int): New function extracted
7644         from...
7645         (rank_one_type): ... this.
7646
7647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7648
7649         * gdbtypes.c (rank_one_type_parm_func): New function extracted
7650         from...
7651         (rank_one_type): ... this.
7652
7653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7654
7655         * gdbtypes.c (rank_one_type_parm_array): New function extracted
7656         from...
7657         (rank_one_type): ... this.
7658
7659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
7660
7661         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
7662         from...
7663         (rank_one_type): ... this.
7664
7665 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7666
7667         * inferior.c (initialize_inferiors): Ensure 'help set/show print
7668         inferior-events' shows the example events.
7669
7670 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
7671
7672         Support styling on native MS-Windows console
7673
7674         PR/24315
7675         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
7676         on MS-Windows if $TERM is not defined.
7677
7678         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
7679
7680         * posix-hdep.c (gdb_console_fputs):
7681         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
7682         functions.
7683         * ui-file.h (gdb_console_fputs): Add prototype.
7684
7685         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
7686         back to fputs only if the former returns zero.
7687
7688 2019-03-07  Tom Tromey  <tom@tromey.com>
7689
7690         * symmisc.c (print_symbol_bcache_statistics): Update.
7691         (print_objfile_statistics): Update.
7692         * symfile.c (allocate_symtab): Update.
7693         * stabsread.c: Don't include bcache.h.
7694         * psymtab.h (struct psymbol_bcache): Don't declare.
7695         (class psymtab_storage) <psymbol_cache>: Now a bcache.
7696         (psymbol_bcache_init, psymbol_bcache_free)
7697         (psymbol_bcache_get_bcache): Don't declare.
7698         * psymtab.c (struct psymbol_bcache): Remove.
7699         (psymtab_storage::psymtab_storage): Update.
7700         (psymtab_storage::~psymtab_storage): Update.
7701         (psymbol_bcache_init, psymbol_bcache_free)
7702         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
7703         (add_psymbol_to_bcache): Update.
7704         (allocate_psymtab): Update.
7705         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7706         macro_cache>: No longer pointers.
7707         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
7708         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
7709         * macrotab.c (macro_bcache): Update.
7710         * macroexp.c: Don't include bcache.h.
7711         * gdbtypes.c (check_types_worklist): Update.
7712         (types_deeply_equal): Remove TRY/CATCH.  Update.
7713         * elfread.c (elf_symtab_read): Update.
7714         * dwarf2read.c: Don't include bcache.h.
7715         * buildsym.c (buildsym_compunit::get_macro_table): Update.
7716         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
7717         (print_bcache_statistics, bcache_memory_used): Don't declare.
7718         (struct bcache): Move from bcache.c.  Add constructor, destructor,
7719         methods.  Rename all data members.
7720         * bcache.c (struct bcache): Move to bcache.h.
7721         (bcache::expand_hash_table): Rename from expand_hash_table.
7722         (bcache): Remove.
7723         (bcache::insert): Rename from bcache_full.
7724         (bcache::compare): Rename from bcache_compare.
7725         (bcache_xmalloc): Remove.
7726         (bcache::~bcache): Rename from bcache_xfree.
7727         (bcache::print_statistics): Rename from print_bcache_statistics.
7728         (bcache::memory_used): Rename from bcache_memory_used.
7729
7730 2019-03-07  Pedro Alves  <palves@redhat.com>
7731
7732         * infrun.c (normal_stop): Also check for
7733         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
7734
7735 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * f-lang.c (value_from_host_double): Moved to...
7738         * value.c (value_from_host_double): ...here.
7739         * value.h (value_from_host_double): Declare.
7740         * guile/scm-math.c (vlscm_convert_typed_number): Use
7741         value_from_host_double.
7742         (vlscm_convert_number): Likewise.
7743         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
7744         * python/py-value.c (convert_value_from_python): Likewise.
7745
7746 2019-03-06  Tom Tromey  <tom@tromey.com>
7747
7748         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
7749
7750 2019-03-06  Tom Tromey  <tom@tromey.com>
7751
7752         * utils.h (free_current_contents): Don't declare.
7753         * utils.c (free_current_contents): Remove.
7754
7755 2019-03-06  Tom Tromey  <tom@tromey.com>
7756
7757         * top.c (quit_force): Update.
7758         * main.c (captured_command_loop): Update.
7759         * common/new-op.c (operator new): Update.
7760         * common/common-exceptions.c (struct catcher)
7761         <save_cleanup_chain>: Remove member.
7762         (exceptions_state_mc_init): Update.
7763         (exception_try_scope_entry): Return nullptr.
7764         (exception_try_scope_exit, exception_rethrow)
7765         (throw_exception_sjlj, throw_exception_cxx): Update.
7766         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
7767         (all_cleanups, do_cleanups, discard_cleanups)
7768         (discard_final_cleanups, save_cleanups, save_final_cleanups)
7769         (restore_cleanups, restore_final_cleanups): Don't declare.
7770         (do_final_cleanups): Remove parameter.
7771         * common/cleanups.c (cleanup_chain, make_cleanup)
7772         (make_cleanup_dtor, all_cleanups, do_cleanups)
7773         (discard_my_cleanups, discard_cleanups)
7774         (discard_final_cleanups, save_my_cleanups, save_cleanups)
7775         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
7776         (null_cleanup): Remove.
7777         (do_final_cleanups): Remove parameter.
7778
7779 2019-03-06  Tom Tromey  <tom@tromey.com>
7780
7781         * remote.c (remote_target::remote_parse_stop_reply): Use
7782         unique_xmalloc_ptr.
7783
7784 2019-03-06  Tom Tromey  <tom@tromey.com>
7785
7786         * stabsread.c (struct stabs_field_info): Rename from field_info.
7787         <list, fnlist>: Add initializers.
7788         <obstack>: New member.
7789         (read_member_functions, read_struct_fields, read_baseclasses):
7790         Allocate on obstack.  Don't use cleanups.
7791         (read_one_struct_field, read_member_functions, read_struct_fields)
7792         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
7793         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7794         (read_struct_type): Update.
7795
7796 2019-03-06  Tom Tromey  <tom@tromey.com>
7797
7798         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7799         * common/filestuff.h (make_cleanup_close): Don't declare.
7800         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7801         Remove.
7802
7803 2019-03-06  Tom Tromey  <tom@tromey.com>
7804
7805         * solib-aix.c: Use make_scope_exit.
7806
7807 2019-03-06  Tom Tromey  <tom@tromey.com>
7808
7809         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7810         Use make_scope_exit.
7811
7812 2019-03-06  Tom Tromey  <tom@tromey.com>
7813
7814         * solib-svr4.c (disable_probes_interface): Remove parameter.
7815         (svr4_handle_solib_event): Use make_scope_exit.
7816
7817 2019-03-06  Tom Tromey  <tom@tromey.com>
7818
7819         * remote.c (struct stop_reply_deleter): Remove.
7820         (stop_reply_up): Update.
7821         (struct stop_reply): Derive from notif_event.  Don't typedef.
7822         <regcache>: Now a std::vector.
7823         (stop_reply_xfree): Remove.
7824         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7825         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7826         (remote_target::discard_pending_stop_replies): Use delete.
7827         (remote_target::remote_parse_stop_reply): Update.
7828         (remote_target::process_stop_reply): Update.
7829         * remote-notif.h (struct notif_event): Add virtual destructor.
7830         Remove "dtr" member.
7831         (struct notif_client) <alloc_event>: Return a unique_ptr.
7832         (notif_event_xfree): Don't declare.
7833         (notif_event_up): New typedef.
7834         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7835         (notif_event_xfree, do_notif_event_xfree): Remove.
7836         (remote_notif_state_xfree): Update.
7837
7838 2019-03-06  Tom Tromey  <tom@tromey.com>
7839
7840         * infrun.c (displaced_step_clear_cleanup): Now a
7841         forward_scope_exit type.
7842         (displaced_step_prepare_throw): Update.
7843         (displaced_step_fixup): Update.
7844
7845 2019-03-06  Tom Tromey  <tom@tromey.com>
7846
7847         * inferior.h (class inferior): Update comment.
7848         * gdbthread.h (class thread_info): Update comment.
7849
7850 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7851             Tom Tromey  <tom@tromey.com>
7852
7853         * stabsread.h (struct stab_section_list): Remove.
7854         (coffstab_build_psymtabs): Update.
7855         * dbxread.c (symbuf_sections): Now a std::vector.
7856         (sect_idx): New global.
7857         (fill_symbuf): Update.
7858         (coffstab_build_psymtabs): Change type of stabsects parameter.
7859         Update.
7860         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7861         std::vector.
7862         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7863         (coff_locate_sections): Update.
7864         (coff_symfile_read): Remove cleanups.  Update.
7865         (init_stringtab): Add storage parameter.
7866         (free_stringtab, free_stringtab_cleanup): Remove.
7867         (init_lineno): Add storage parameter.
7868         (free_linetab, free_linetab_cleanup): Remove.
7869
7870 2019-03-06  Pedro Alves  <palves@redhat.com>
7871
7872         * linux-fork.c (fork_info::clobber_regs): Delete.
7873         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7874         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7875         comment.  Adjust.
7876         (scoped_switch_fork_info::scoped_switch_fork_info)
7877         (checkpoint_command, linux_fork_context): Adjust
7878         fork_save_infrun_state calls.
7879
7880 2019-03-06  Pedro Alves  <palves@redhat.com>
7881
7882         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7883         (inf_has_multiple_threads): Return 'bool' and rewrite using
7884         inferior_info::threads().
7885
7886 2019-03-06  Pedro Alves  <palves@redhat.com>
7887
7888         * linux-fork.c: Include <list>.
7889         (fork_list): Now a std::list instance.
7890         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7891         (forks_exist_p, find_last_fork): Adjust.
7892         (new_fork): Delete.
7893         (one_fork_p): New.
7894         (add_fork): Adjust.
7895         (free_fork): Delete, folded into fork_info::~fork_info().
7896         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7897         Adjust.
7898         (init_fork_list): Delete.
7899         (linux_fork_killall, linux_fork_mourn_inferior)
7900         (linux_fork_detach, info_checkpoints_command): Adjust.
7901         (_initialize_linux_fork): No longer call init_fork_list.
7902
7903 2019-03-06  Pedro Alves  <palves@redhat.com>
7904
7905         * linux-fork.c (new_fork): New, split out of ...
7906         (add_fork): ... this.  Return void.  Move "first fork" special
7907         case from here, to ...
7908         (checkpoint_command): ... here.
7909         * linux-linux.h (add_fork): Return void.
7910
7911 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7912
7913         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7914
7915 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7916             Chris January  <chris.january@arm.com>
7917             David Lecomber  <david.lecomber@arm.com>
7918
7919         * f-exp.y: New token, UNOP_INTRINSIC.
7920         (exp): New pattern using UNOP_INTRINSIC token.
7921         (f77_keywords): Add 'abs' keyword.
7922         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7923         (value_from_host_double): New function.
7924         (evaluate_subexp_f): Support UNOP_ABS.
7925
7926 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7927
7928         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7929         types.
7930
7931 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7932
7933         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7934         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7935         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7936
7937 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7938
7939         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7940
7941 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7942             Chris January  <chris.january@arm.com>
7943
7944         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7945         * f-exp.y: Define 'KIND' token.
7946         (exp): New pattern for KIND expressions.
7947         (ptype): Handle types with a kind extension.
7948         (direct_abs_decl): Extend to spot kind extensions.
7949         (f77_keywords): Add 'kind' to the list.
7950         (push_kind_type): New function.
7951         (convert_to_kind_type): New function.
7952         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7953         * parse.c (operator_length_standard): Likewise.
7954         * parser-defs.h (enum type_pieces): Add tp_kind.
7955         * std-operator.def: Add UNOP_KIND.
7956
7957 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7958
7959         * f-exp.y (f_parse): Set yydebug.
7960
7961 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7962
7963         * f-lang.c (evaluate_subexp_f): New function.
7964         (exp_descriptor_f): New global.
7965         (f_language_defn): Use exp_descriptor_f instead of
7966         exp_descriptor_standard.
7967
7968 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7969
7970         * f-exp.y (struct token): Add comments.
7971         (dot_ops): Remove uppercase versions and the end marker.
7972         (f77_keywords): Likewise.
7973         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7974         entries in the dot_ops array are case insensitive, and use
7975         strncasecmp to compare strings.  Also some whitespace cleanup in
7976         this area.  Similar for the f77_keywords array, except entries in
7977         this list might be case sensitive.
7978
7979 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7980
7981         * f-exp.y (struct f77_boolean_val): Add comments.
7982         (boolean_values): Remove uppercase versions, and end marker.
7983         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7984         and use strncasecmp to achieve case insensitivity.  Additionally,
7985         perform whitespace cleanup around this code.
7986
7987 2019-03-06  Tom Tromey  <tromey@adacore.com>
7988
7989         * remote-sim.c (gdbsim_target_open): Use result of
7990         gdb_argv::release.
7991
7992 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7993         Dirk Schubert  <dirk.schubert@arm.com>
7994         Chris January  <chris.january@arm.com>
7995
7996         * eval.c (evaluate_subexp_standard): Call Fortran argument
7997         wrapping logic.
7998         * f-lang.c (struct value): A value which can be passed into a
7999         Fortran function call.
8000         (fortran_argument_convert): Wrap Fortran arguments in a pointer
8001         where appropriate.
8002         (struct type): Value ready for a Fortran function call.
8003         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
8004         is needed.
8005         * f-lang.h (fortran_argument_convert): Declaration.
8006         (fortran_preserve_arg_pointer): Declaration.
8007         * infcall.c (value_arg_coerce): Call Fortran argument logic.
8008
8009 2019-03-05  Tom Tromey  <tromey@adacore.com>
8010
8011         * python/py-prettyprint.c (print_string_repr): Remove #if.
8012         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
8013
8014 2019-03-05  Tom Tromey  <tromey@adacore.com>
8015
8016         * target.c (the_dummy_target): Move later.  Change type to
8017         "dummy_target".
8018         (initialize_targets): Don't initialize the_dummy_target.
8019
8020 2019-03-05  Tom Tromey  <tromey@adacore.com>
8021
8022         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
8023         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
8024
8025 2019-03-05  Tom Tromey  <tromey@adacore.com>
8026
8027         * windows-nat.c (windows_nat_target::attach)
8028         (windows_nat_target::detach): Don't call gdb_flush.
8029         * valprint.c (generic_val_print, val_print, val_print_string):
8030         Don't call gdb_flush.
8031         * utils.c (defaulted_query): Don't call gdb_flush.
8032         * typeprint.c (print_type_scalar): Don't call gdb_flush.
8033         * target.c (target_announce_detach): Don't call gdb_flush.
8034         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
8035         * remote.c (extended_remote_target::attach): Don't call
8036         gdb_flush.
8037         * procfs.c (procfs_target::detach): Don't call gdb_flush.
8038         * printcmd.c (do_examine): Don't call gdb_flush.
8039         (info_display_command): Don't call gdb_flush.
8040         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
8041         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
8042         * memattr.c (info_mem_command): Don't call gdb_flush.
8043         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
8044         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
8045         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
8046         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
8047         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
8048         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
8049         (gnu_nat_target::detach): Don't call gdb_flush.
8050         * f-valprint.c (f_val_print): Don't call gdb_flush.
8051         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
8052         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
8053         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
8054         gdb_flush.
8055         * c-valprint.c (c_val_print): Don't call gdb_flush.
8056         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
8057
8058 2019-03-05  Tom Tromey  <tromey@adacore.com>
8059
8060         * varobj.c (update_dynamic_varobj_children): Update.
8061         (install_default_visualizer): Use reset, not release.
8062         * value.c (set_internalvar): Update.
8063         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
8064         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
8065         ATTRIBUTE_UNUSED_RESULT.
8066
8067 2019-03-05  Tom Tromey  <tromey@adacore.com>
8068
8069         * remote.c (class scoped_remote_fd) <release>: Add
8070         ATTRIBUTE_UNUSED_RESULT.
8071
8072 2019-03-05  Tom Tromey  <tromey@adacore.com>
8073
8074         * macroexp.c (struct macro_buffer) <release>: Add
8075         ATTRIBUTE_UNUSED_RESULT.
8076
8077 2019-03-05  Tom Tromey  <tromey@adacore.com>
8078
8079         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
8080         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
8081         ATTRIBUTE_UNUSED_RESULT.
8082
8083 2019-03-05  Tom Tromey  <tromey@adacore.com>
8084
8085         * common/scoped_fd.h (class scoped_fd) <release>: Add
8086         ATTRIBUTE_UNUSED_RESULT.
8087
8088 2019-03-05  Tom Tromey  <tromey@adacore.com>
8089
8090         * parser-defs.h (struct parser_state) <release>: Add
8091         ATTRIBUTE_UNUSED_RESULT.
8092
8093 2019-03-05  Tom Tromey  <tromey@adacore.com>
8094
8095         * utils.h (class gdb_argv) <release>: Add
8096         ATTRIBUTE_UNUSED_RESULT.
8097         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
8098
8099 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
8100
8101         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
8102         for-loop range, to avoid compiler warnings.
8103
8104         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
8105         avoid compiler warnings about unused variables.
8106
8107         * NEWS: Mention end of support for native debugging on MS-Windows
8108         before XP.
8109
8110         PR gdb/24292
8111         * common/netstuff.c:
8112         * gdbserver/gdbreplay.c
8113         * gdbserver/remote-utils.c:
8114         * ser-tcp.c:
8115         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
8116         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
8117         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
8118         'getaddrinfo' and 'freeaddrinfo' were not available before
8119         Windows XP, and mingw.org's MinGW headers by default define
8120         _WIN32_WINNT to 0x500.
8121
8122 2019-03-01  Gary Benson <gbenson@redhat.com>
8123
8124         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
8125
8126 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
8127             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
8128
8129         PR gdb/8527
8130         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
8131         set_sigint_trap, clear_sigint_trap.
8132
8133 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8134
8135         * target.c (target_detach): Clear the regcache and the
8136         frame cache.
8137
8138 2019-02-27  Pedro Alves  <palves@redhat.com>
8139
8140         * utils.c (set_screen_size): When we cap the height/width sizes,
8141         tweak the corresponding command variable to show "unlimited":
8142
8143 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
8144             Pedro Alves  <palves@redhat.com>
8145
8146         * utils.c (set_screen_size): Reduce "infinite" rows and columns
8147         before calling rl_set_screen_size.
8148
8149 2019-02-27  Tom Tromey  <tromey@adacore.com>
8150
8151         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
8152         define.
8153         * python/py-value.c: Remove Python 2.4 workaround.
8154         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
8155         workaround.
8156         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
8157         Python 2.4 workaround.
8158         * python/python-internal.h: Remove Python 2.4 comment.
8159         (Py_ssize_t): Don't define.
8160         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
8161         (gdb_Py_DECREF): Remove Python 2.4 workaround.
8162         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
8163         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
8164         * python/python.c (do_start_initialization): Remove Python 2.4
8165         workaround.
8166         * python/py-prettyprint.c (class dummy_python_frame): Remove.
8167         (print_children): Remove Python 2.4 workaround.
8168         * python/py-inferior.c (buffer_procs): Remove Python 2.4
8169         workaround.
8170         (CHARBUFFERPROC_NAME): Remove.
8171         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
8172         Python 2.4 workaround.
8173
8174 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8175
8176         * NEWS: Note minimum Python version.
8177
8178 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
8179
8180         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
8181         code from these functions.  Remove corresponding ifdefs.  Use
8182         Py_buffer_up instead of explicit calls to PyBuffer_Release.
8183         Remove gotos and target of gotos.
8184         (infpy_search_memory): Likewise.
8185
8186 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8187
8188         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
8189         (hppa_gdbarch_init): Don't register deleted functions with
8190         gdbarch.
8191
8192 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8193
8194         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
8195         (h8300_unwind_sp): Delete.
8196         (h8300_dummy_id): Delete.
8197         (h8300_gdbarch_init): Don't register deleted functions with
8198         gdbarch.
8199
8200 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8201
8202         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
8203         (ft32_unwind_pc): Delete.
8204         (ft32_unwind_sp): Delete.
8205         (ft32_gdbarch_init): Don't register deleted functions with
8206         gdbarch.
8207
8208 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8209
8210         * gdb/frv-tdep.c (frv_dummy_id): Delete.
8211         (frv_unwind_pc): Delete.
8212         (frv_unwind_sp): Delete.
8213         (frv_gdbarch_init): Don't register deleted functions with
8214         gdbarch.
8215
8216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8217
8218         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
8219         (riscv_unwind_pc): Delete.
8220         (riscv_unwind_sp): Delete.
8221         (riscv_gdbarch_init): Don't register deleted functions with
8222         gdbarch.
8223
8224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8225
8226         * gdb/csky-tdep.c (csky_dummy_id): Delete.
8227         (csky_unwind_pc): Delete.
8228         (csky_unwind_sp): Delete.
8229         (csky_gdbarch_init): Don't register deleted functions with
8230         gdbarch.
8231
8232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8233
8234         * gdb/cris-tdep.c (cris_dummy_id): Delete.
8235         (cris_unwind_pc): Delete.
8236         (cris_unwind_sp): Delete.
8237         (cris_gdbarch_init): Don't register deleted functions with
8238         gdbarch.
8239
8240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8241
8242         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
8243         (bfin_unwind_pc): Delete.
8244         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
8245
8246 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8247
8248         * gdb/arm-tdep.c (arm_dummy_id): Delete.
8249         (arm_unwind_pc): Delete.
8250         (arm_unwind_sp): Delete.
8251         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
8252
8253 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8254
8255         * gdb/arc-tdep.c (arc_dummy_id): Delete.
8256         (arc_unwind_pc): Delete.
8257         (arc_unwind_sp): Delete.
8258         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
8259
8260 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8261
8262         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
8263         (alpha_unwind_pc): Delete.
8264         (alpha_gdbarch_init): Don't register deleted functions with
8265         gdbarch.
8266
8267 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8268
8269         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
8270         (aarch64_unwind_pc): Delete.
8271         (aarch64_unwind_sp): Delete.
8272         (aarch64_gdbarch_init): Don't register deleted functions with
8273         gdbarch.
8274
8275 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8276
8277         * gdbtypes.c (type_align): Don't consider static members when
8278         computing structure alignment.
8279
8280 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
8281
8282         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
8283         return 0 for other types.
8284         * arch-utils.c (default_type_align): Always return 0.
8285         * gdbarch.h: Regenerate.
8286         * gdbarch.sh (type_align): Extend comment.
8287         * gdbtypes.c (type_align): Add additional comments, always call
8288         gdbarch_type_align before applying the default rules.
8289         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
8290         generic code will then apply a suitable default.
8291         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
8292         types, return 0 for other types.
8293
8294 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8295
8296         * NEWS: Create a new section for the next release branch.
8297         Rename the section of the current branch, now that it has
8298         been cut.
8299
8300 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
8301
8302         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
8303         * version.in: Bump version to 8.3.50.DATE-git.
8304
8305 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
8306
8307         * aix-thread.c (ptid_cmp): Remove unused variable.
8308         (get_signaled_thread): Likewise.
8309         (store_regs_user_thread): Likewise.
8310         (store_regs_kernel_thread): Likewise.
8311         (fetch_regs_kernel_thread): Remove shadowed variable.
8312
8313 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8314
8315         * features/riscv/32bit-cpu.xml: Add register numbers.
8316         * features/riscv/32bit-fpu.c: Regenerate.
8317         * features/riscv/32bit-fpu.xml: Add register numbers.
8318         * features/riscv/64bit-cpu.xml: Add register numbers.
8319         * features/riscv/64bit-fpu.c: Regenerate.
8320         * features/riscv/64bit-fpu.xml: Add register numbers.
8321
8322 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
8323
8324         * NEWS: Mention two argument form of gdb.Value constructor.
8325         * python/py-value.c (convert_buffer_and_type_to_value): New
8326         function.
8327         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
8328         Add support for handling an optional second argument.  Call
8329         convert_buffer_and_type_to_value as appropriate.
8330         * python/python-internal.h (Py_buffer_deleter): New struct.
8331         (Py_buffer_up): New typedef.
8332
8333 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
8334
8335         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
8336         instead of releasing ownership.
8337
8338 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
8339
8340         * dwarf2read.c (open_and_init_dwp_file): Call
8341         elf_numsections instead of bfd_count_sections to initialize
8342         dwp_file->num_sections.
8343
8344 2019-02-25  Tom Tromey  <tromey@adacore.com>
8345
8346         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
8347
8348 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
8349
8350         * gcore.in: Add '--readnever' option when invoking GDB.
8351
8352 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8353
8354         * MAINTAINERS: Update my email address.
8355
8356 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
8357
8358         * build-id.c (build_id_to_debug_bfd_1): New function.
8359         (build_id_to_debug_bfd): Look for separate debug file in
8360         sysroot.
8361
8362 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
8363
8364         * gdbarch.sh: Update the copyright year range that is placed into
8365         generated files.
8366
8367 2019-02-22  Keith Seitz  <keiths@redhat.com>
8368
8369         PR symtab/23853
8370         * linespec.c (create_sals_line_offset): Search for the default
8371         symtab's filename instead of its fullname.
8372
8373 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8374
8375         * NEWS: Update style defaults.
8376
8377 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
8378
8379         * main.c (captured_main_1): Disable styling in batch mode.
8380
8381 2019-02-20  Tom Tromey  <tom@tromey.com>
8382
8383         * symtab.c (symtab_symbol_info): Fix typos.
8384
8385 2019-02-20  Tom Tromey  <tromey@adacore.com>
8386
8387         * findcmd.c (_initialize_mem_search): Use upper case for
8388         metasyntactic variables.
8389
8390 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
8391
8392         * aarch64-tdep.c (aarch64_add_reggroups): New function.
8393         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
8394
8395 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
8396
8397         * top.h (source_file_name): Change to std::string.
8398         * top.c (source_file_name): Likewise.
8399         (command_line_input): Adjust.
8400         * cli/cli-script.c (script_from_file): Adjust.
8401
8402 2019-02-19  Tom Tromey  <tromey@adacore.com>
8403
8404         * ravenscar-thread.c
8405         (ravenscar_thread_target::update_thread_list): Don't call
8406         ada_build_task_list.
8407         * ada-lang.h (ada_build_task_list): Don't declare.
8408         * ada-tasks.c (struct ada_tasks_inferior_data)
8409         <task_list_valid_p>: Now bool.
8410         (read_known_tasks, ada_task_list_changed)
8411         (ada_tasks_invalidate_inferior_data): Update.
8412         (read_known_tasks_array): Return bool.
8413         (read_known_tasks_list): Likewise.
8414         (read_known_tasks): Return void.
8415         (ada_build_task_list): Now static.
8416
8417 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8418
8419         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
8420         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
8421
8422 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8423
8424         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
8425         variant for ada_tasks_pspace_data_handle and
8426         ada_tasks_inferior_data_handle.
8427         (ada_tasks_pspace_data_cleanup): New function.
8428         (ada_tasks_inferior_data_cleanup): New function.
8429
8430 2019-02-17  Tom Tromey  <tom@tromey.com>
8431
8432         * macrotab.h (macro_source_fullname): Return a std::string.
8433         * macrotab.c (macro_include, check_for_redefinition)
8434         (macro_undef, macro_lookup_definition, foreach_macro)
8435         (foreach_macro_in_scope): Update.
8436         (macro_source_fullname): Return a std::string.
8437         * macrocmd.c (show_pp_source_pos): Update.
8438
8439 2019-02-17  Tom Tromey  <tom@tromey.com>
8440
8441         * macrocmd.c (show_pp_source_pos): Style the file names.
8442
8443 2019-02-17  Tom Tromey  <tom@tromey.com>
8444
8445         PR tui/24197:
8446         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
8447
8448 2019-02-17  Tom Tromey  <tom@tromey.com>
8449
8450         * ada-lang.c (user_select_syms): Use filtered printing.
8451         * utils.c (wrap_style): New global.
8452         (desired_style): Remove.
8453         (emit_style_escape): Add stream parameter.
8454         (set_output_style, reset_terminal_style, prompt_for_continue):
8455         Update.
8456         (flush_wrap_buffer): Only flush gdb_stdout.
8457         (wrap_here): Set wrap_style.
8458         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
8459         treat escape sequences as a character.  Change when wrap buffer is
8460         flushed.
8461         (fputs_styled): Do not set the output style when the default is
8462         requested.
8463         * ui-style.h (struct ui_file_style) <is_default>: New method.
8464         * source.c (print_source_lines_base): Emit escape sequences in one
8465         piece.
8466
8467 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8468
8469         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
8470         integers and enumeration types.
8471
8472 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
8473
8474         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
8475         instead of lookup_symbol_in_language
8476         (do_exact_match): New function.
8477         (ada_get_symbol_name_matcher): Return do_exact_match when
8478         doing a verbatim match.
8479
8480 2019-02-15  Tom Tromey  <tromey@adacore.com>
8481
8482         * ravenscar-thread.c (ravenscar_thread_target::resume)
8483         (ravenscar_thread_target::wait): Special case wildcard requests.
8484
8485 2019-02-15  Tom Tromey  <tromey@adacore.com>
8486
8487         * ravenscar-thread.c (base_ptid): Remove.
8488         (struct ravenscar_thread_target) <close>: New method.
8489         <m_base_ptid>: New member.
8490         <update_inferior_ptid, active_task, task_is_currently_active,
8491         runtime_initialized>: Declare methods.
8492         <ravenscar_thread_target>: Add constructor.
8493         (ravenscar_thread_target::task_is_currently_active)
8494         (ravenscar_thread_target::update_inferior_ptid)
8495         (ravenscar_runtime_initialized): Rename.  Now methods.
8496         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
8497         (ravenscar_thread_target::update_thread_list): Update.
8498         (ravenscar_thread_target::active_task): Now method.
8499         (ravenscar_thread_target::store_registers)
8500         (ravenscar_thread_target::prepare_to_store)
8501         (ravenscar_thread_target::prepare_to_store)
8502         (ravenscar_thread_target::mourn_inferior): Update.
8503         (ravenscar_inferior_created): Use "new" to create target.
8504         (ravenscar_thread_target::get_ada_task_ptid): Update.
8505         (_initialize_ravenscar): Don't initialize base_ptid.
8506         (ravenscar_ops): Remove global.
8507
8508 2019-02-15  Tom Tromey  <tromey@adacore.com>
8509
8510         * target.h (push_target): Declare new overload.
8511         * target.c (push_target): New overload, taking an rvalue reference.
8512         * remote.c (remote_target::open_1): Use push_target overload.
8513         * corelow.c (core_target_open): Use push_target overload.
8514
8515 2019-02-15  Tom Tromey  <tromey@adacore.com>
8516
8517         * ravenscar-thread.c (is_ravenscar_task)
8518         (ravenscar_task_is_currently_active): Return bool.
8519         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
8520         (_initialize_ravenscar): Remove "(void)".
8521         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
8522         Return bool.
8523
8524 2019-02-15  Tom Tromey  <tromey@adacore.com>
8525
8526         * ravenscar-thread.c (ravenscar_runtime_initializer)
8527         (has_ravenscar_runtime, get_running_thread_id)
8528         (ravenscar_thread_target::resume): Fix indentation.
8529
8530 2019-02-15  Tom Tromey  <tromey@adacore.com>
8531
8532         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
8533         from ravenscar_arch_ops.
8534         (sparc_ravenscar_ops::fetch_registers)
8535         (sparc_ravenscar_ops::store_registers): Now methods.
8536         (sparc_ravenscar_prepare_to_store): Remove.
8537         (sparc_ravenscar_ops): Redefine.
8538         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
8539         methods and destructor.  Remove members.
8540         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
8541         (ravenscar_thread_target::store_registers)
8542         (ravenscar_thread_target::prepare_to_store): Update.
8543         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
8544         Remove.
8545         (struct ppc_ravenscar_powerpc_ops): Derive from
8546         ravenscar_arch_ops.
8547         (ppc_ravenscar_powerpc_ops::fetch_registers)
8548         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
8549         (ppc_ravenscar_powerpc_ops): Redefine.
8550         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
8551         (ppc_ravenscar_e500_ops::fetch_registers)
8552         (ppc_ravenscar_e500_ops::store_registers): Now methods.
8553         (ppc_ravenscar_e500_ops): Redefine.
8554         * aarch64-ravenscar-thread.c
8555         (aarch64_ravenscar_generic_prepare_to_store): Remove.
8556         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
8557         (aarch64_ravenscar_fetch_registers)
8558         (aarch64_ravenscar_store_registers): Now methods.
8559         (aarch64_ravenscar_ops): Redefine.
8560
8561 2019-02-15  Tom Tromey  <tromey@adacore.com>
8562
8563         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
8564         (ravenscar_thread_target::stopped_by_hw_breakpoint)
8565         (ravenscar_thread_target::stopped_by_watchpoint)
8566         (ravenscar_thread_target::stopped_data_address)
8567         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
8568
8569 2019-02-15  Tom Tromey  <tromey@adacore.com>
8570
8571         * ravenscar-thread.c: Fix some typos.
8572
8573 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8574             Tom Tromey  <tromey@adacore.com>
8575
8576         * ada-lang.c (ada_exception_sal): Change addr_string to a
8577         std::string.
8578         (create_ada_exception_catchpoint): Update.
8579
8580 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8581             Tom Tromey  <tromey@adacore.com>
8582
8583         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
8584         (bp_location_ops): Remove.
8585         (base_breakpoint_allocate_location): Update.
8586         (free_bp_location): Update.
8587         * ada-lang.c (class ada_catchpoint_location)
8588         <ada_catchpoint_location>: Remove ops parameter.
8589         (ada_catchpoint_location_dtor): Remove.
8590         (ada_catchpoint_location_ops): Remove.
8591         (allocate_location_exception): Update.
8592         * breakpoint.h (struct bp_location_ops): Remove.
8593         (class bp_location) <bp_location>: Remove bp_location_ops
8594         parameter.
8595         <~bp_location>: Add destructor.
8596         <ops>: Remove.
8597
8598 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8599             Pedro Alves  <palves@redhat.com>
8600
8601         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
8602         'PATH_MAX'.
8603
8604 2019-02-14  David Michael  <fedora.dm0@gmail.com>
8605             Samuel Thibault  <samuel.thibault@gnu.org>
8606             Thomas Schwinge  <thomas@codesourcery.com>
8607
8608         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
8609         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
8610
8611 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
8612
8613         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
8614         (check_empty): Use "const char *".
8615
8616         * gnu-nat.c (gnu_nat_target::detach): Instead of
8617         'detach_inferior (pid)' call
8618         'detach_inferior (find_inferior_pid (pid))'.
8619
8620         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
8621         'nat/fork-inferior.o'.
8622         * gnu-nat.c: #include "nat/fork-inferior.h".
8623
8624         * gnu-nat.c (gnu_nat_target::detach): Instead of
8625         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
8626         * gnu-nat.h: #include "inf-child.h".
8627         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
8628         'i386_gnu_nat_target::fetch_registers'.
8629         (gnu_store_registers): Rename/move to
8630         'i386_gnu_nat_target::store_registers'.
8631
8632         * config/i386/nm-i386gnu.h: Don't "#include" any files.
8633         * gnu-nat.h (mach_thread_info): New function.
8634         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
8635
8636         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
8637
8638 2019-02-14  Frederic Konrad  <konrad@adacore.com>
8639
8640         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
8641
8642 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
8643
8644         * windows-nat.c (windows_add_thread): Add new parameter
8645         "main_thread_p" with default value set to false.  Update
8646         function documentation as well as all callers.
8647         (windows_delete_thread): Likewise.
8648         (fake_create_process): Update call to windows_add_thread.
8649         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
8650         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
8651         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
8652         call to windows_delete_thread.
8653
8654 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
8655
8656         * MAINTAINERS: Add Andrew Burgess as global maintainer.
8657
8658 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8659
8660         * symfile.c (find_separate_debug_file): Use canonical path of
8661         sysroot with child_path instead of gdb_sysroot if it is valid.
8662
8663 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8664
8665         * symfile.c (find_separate_debug_file): Use child_path to
8666         determine if an object file is under a sysroot.
8667
8668 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8669
8670         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
8671         unittests/child-path-selftests.c.
8672         * common/pathstuff.c (child_path): New function.
8673         * common/pathstuff.h (child_path): New prototype.
8674         * unittests/child-path-selftests.c: New file.
8675
8676 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
8677
8678         * symfile.c (find_separate_debug_file): Look for separate debug
8679         files in debug directories under the sysroot.
8680
8681 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8682
8683         * symtab.h (struct minimal_symbol data_p): New const method.
8684         (struct minimal_symbol text_p): Likewise.
8685         * symtab.c (output_source_filename): Use file name style
8686         to print file name.
8687         (print_symbol_info): Likewise.
8688         (print_msymbol_info): Use address style to print addresses.
8689         Use function name style to print executable text symbols.
8690         (expand_symtab_containing_pc): Use data_p.
8691         (find_pc_sect_compunit_symtab): Likewise.
8692
8693 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8694
8695         * breakpoint.c (describe_other_breakpoints): Use address style
8696         to print addresses.
8697         (say_where): Likewise.
8698
8699 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8700
8701         * ada-typeprint.c (print_func_type): Print function name
8702         style to print function name.
8703         * c-typeprint.c (c_print_type_1): Likewise.
8704
8705 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
8706
8707         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
8708         for execve.
8709
8710 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8711
8712         * c-exp.y (direct_abs_decl): Use emplace_back to record the
8713         type_stack.
8714
8715 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
8716
8717         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
8718         TYPE_CODE_REF types.
8719
8720 2019-02-08  Jim Wilson  <jimw@sifive.com>
8721
8722         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
8723         (riscv_linux_fregset): New.
8724         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
8725
8726 2019-02-07  Tom Tromey  <tom@tromey.com>
8727
8728         * thread.c (thread_cancel_execution_command): Update.
8729         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
8730         methods.
8731         (struct thread_fsm_ops): Remove.
8732         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
8733         (thread_fsm_should_stop, thread_fsm_return_value)
8734         (thread_fsm_set_finished, thread_fsm_finished_p)
8735         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
8736         Don't declare.
8737         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
8738         * infrun.c (clear_proceed_status_thread)
8739         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
8740         (print_stop_event): Update.
8741         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
8742         Add constructor.
8743         (step_command_fsm_ops): Remove.
8744         (new_step_command_fsm): Remove.
8745         (step_1): Update.
8746         (step_command_fsm::should_stop): Rename from
8747         step_command_fsm_should_stop.
8748         (step_command_fsm::clean_up): Rename from
8749         step_command_fsm_clean_up.
8750         (step_command_fsm::do_async_reply_reason): Rename from
8751         step_command_fsm_async_reply_reason.
8752         (struct until_next_fsm): Inherit from thread_fsm.  Add
8753         constructor.
8754         (until_next_fsm_ops): Remove.
8755         (new_until_next_fsm): Remove.
8756         (until_next_fsm::should_stop): Rename from
8757         until_next_fsm_should_stop.
8758         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
8759         (until_next_fsm::do_async_reply_reason): Rename from
8760         until_next_fsm_async_reply_reason.
8761         (struct finish_command_fsm): Inherit from thread_fsm.  Add
8762         constructor.  Change type of breakpoint.
8763         (finish_command_fsm_ops): Remove.
8764         (new_finish_command_fsm): Remove.
8765         (finish_command_fsm::should_stop): Rename from
8766         finish_command_fsm_should_stop.
8767         (finish_command_fsm::clean_up): Rename from
8768         finish_command_fsm_clean_up.
8769         (finish_command_fsm::return_value): Rename from
8770         finish_command_fsm_return_value.
8771         (finish_command_fsm::do_async_reply_reason): Rename from
8772         finish_command_fsm_async_reply_reason.
8773         (finish_command): Update.
8774         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
8775         Add constructor.
8776         (call_thread_fsm_ops): Remove.
8777         (call_thread_fsm::call_thread_fsm): Rename from
8778         new_call_thread_fsm.
8779         (call_thread_fsm::should_stop): Rename from
8780         call_thread_fsm_should_stop.
8781         (call_thread_fsm::should_notify_stop): Rename from
8782         call_thread_fsm_should_notify_stop.
8783         (run_inferior_call, call_function_by_hand_dummy): Update.
8784         * cli/cli-interp.c (should_print_stop_to_console): Update.
8785         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
8786         Add constructor.  Change type of location_breakpoint,
8787         caller_breakpoint.
8788         (until_break_fsm_ops): Remove.
8789         (new_until_break_fsm): Remove.
8790         (until_break_fsm::should_stop): Rename from
8791         until_break_fsm_should_stop.
8792         (until_break_fsm::clean_up): Rename from
8793         until_break_fsm_clean_up.
8794         (until_break_fsm::do_async_reply_reason): Rename from
8795         until_break_fsm_async_reply_reason.
8796         (until_break_command): Update.
8797         * thread-fsm.c: Remove.
8798         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8799
8800 2019-02-07  Tom Tromey  <tom@tromey.com>
8801
8802         * yy-remap.h: Add include guard.
8803         * xtensa-tdep.h: Add include guard.
8804         * xcoffread.h: Rename include guard.
8805         * varobj-iter.h: Add include guard.
8806         * tui/tui.h: Rename include guard.
8807         * tui/tui-winsource.h: Rename include guard.
8808         * tui/tui-wingeneral.h: Rename include guard.
8809         * tui/tui-windata.h: Rename include guard.
8810         * tui/tui-win.h: Rename include guard.
8811         * tui/tui-stack.h: Rename include guard.
8812         * tui/tui-source.h: Rename include guard.
8813         * tui/tui-regs.h: Rename include guard.
8814         * tui/tui-out.h: Rename include guard.
8815         * tui/tui-layout.h: Rename include guard.
8816         * tui/tui-io.h: Rename include guard.
8817         * tui/tui-hooks.h: Rename include guard.
8818         * tui/tui-file.h: Rename include guard.
8819         * tui/tui-disasm.h: Rename include guard.
8820         * tui/tui-data.h: Rename include guard.
8821         * tui/tui-command.h: Rename include guard.
8822         * tic6x-tdep.h: Add include guard.
8823         * target/waitstatus.h: Rename include guard.
8824         * target/wait.h: Rename include guard.
8825         * target/target.h: Rename include guard.
8826         * target/resume.h: Rename include guard.
8827         * target-float.h: Rename include guard.
8828         * stabsread.h: Add include guard.
8829         * rs6000-tdep.h: Add include guard.
8830         * riscv-fbsd-tdep.h: Add include guard.
8831         * regformats/regdef.h: Rename include guard.
8832         * record.h: Rename include guard.
8833         * python/python.h: Rename include guard.
8834         * python/python-internal.h: Rename include guard.
8835         * python/py-stopevent.h: Rename include guard.
8836         * python/py-ref.h: Rename include guard.
8837         * python/py-record.h: Rename include guard.
8838         * python/py-record-full.h: Rename include guard.
8839         * python/py-record-btrace.h: Rename include guard.
8840         * python/py-instruction.h: Rename include guard.
8841         * python/py-events.h: Rename include guard.
8842         * python/py-event.h: Rename include guard.
8843         * procfs.h: Add include guard.
8844         * proc-utils.h: Add include guard.
8845         * p-lang.h: Add include guard.
8846         * or1k-tdep.h: Rename include guard.
8847         * observable.h: Rename include guard.
8848         * nto-tdep.h: Rename include guard.
8849         * nat/x86-linux.h: Rename include guard.
8850         * nat/x86-linux-dregs.h: Rename include guard.
8851         * nat/x86-gcc-cpuid.h: Add include guard.
8852         * nat/x86-dregs.h: Rename include guard.
8853         * nat/x86-cpuid.h: Rename include guard.
8854         * nat/ppc-linux.h: Rename include guard.
8855         * nat/mips-linux-watch.h: Rename include guard.
8856         * nat/linux-waitpid.h: Rename include guard.
8857         * nat/linux-ptrace.h: Rename include guard.
8858         * nat/linux-procfs.h: Rename include guard.
8859         * nat/linux-osdata.h: Rename include guard.
8860         * nat/linux-nat.h: Rename include guard.
8861         * nat/linux-namespaces.h: Rename include guard.
8862         * nat/linux-btrace.h: Rename include guard.
8863         * nat/glibc_thread_db.h: Rename include guard.
8864         * nat/gdb_thread_db.h: Rename include guard.
8865         * nat/gdb_ptrace.h: Rename include guard.
8866         * nat/fork-inferior.h: Rename include guard.
8867         * nat/amd64-linux-siginfo.h: Rename include guard.
8868         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8869         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8870         * nat/aarch64-linux.h: Rename include guard.
8871         * nat/aarch64-linux-hw-point.h: Rename include guard.
8872         * mn10300-tdep.h: Add include guard.
8873         * mips-linux-tdep.h: Add include guard.
8874         * mi/mi-parse.h: Rename include guard.
8875         * mi/mi-out.h: Rename include guard.
8876         * mi/mi-main.h: Rename include guard.
8877         * mi/mi-interp.h: Rename include guard.
8878         * mi/mi-getopt.h: Rename include guard.
8879         * mi/mi-console.h: Rename include guard.
8880         * mi/mi-common.h: Rename include guard.
8881         * mi/mi-cmds.h: Rename include guard.
8882         * mi/mi-cmd-break.h: Rename include guard.
8883         * m2-lang.h: Add include guard.
8884         * location.h: Rename include guard.
8885         * linux-record.h: Rename include guard.
8886         * linux-nat.h: Add include guard.
8887         * linux-fork.h: Add include guard.
8888         * i386-darwin-tdep.h: Rename include guard.
8889         * hppa-linux-offsets.h: Add include guard.
8890         * guile/guile.h: Rename include guard.
8891         * guile/guile-internal.h: Rename include guard.
8892         * gnu-nat.h: Rename include guard.
8893         * gdb-stabs.h: Rename include guard.
8894         * frv-tdep.h: Add include guard.
8895         * f-lang.h: Add include guard.
8896         * event-loop.h: Add include guard.
8897         * darwin-nat.h: Rename include guard.
8898         * cp-abi.h: Rename include guard.
8899         * config/sparc/nm-sol2.h: Rename include guard.
8900         * config/nm-nto.h: Rename include guard.
8901         * config/nm-linux.h: Add include guard.
8902         * config/i386/nm-i386gnu.h: Rename include guard.
8903         * config/djgpp/nl_types.h: Rename include guard.
8904         * config/djgpp/langinfo.h: Rename include guard.
8905         * compile/gcc-cp-plugin.h: Add include guard.
8906         * compile/gcc-c-plugin.h: Add include guard.
8907         * compile/compile.h: Rename include guard.
8908         * compile/compile-object-run.h: Rename include guard.
8909         * compile/compile-object-load.h: Rename include guard.
8910         * compile/compile-internal.h: Rename include guard.
8911         * compile/compile-cplus.h: Rename include guard.
8912         * compile/compile-c.h: Rename include guard.
8913         * common/xml-utils.h: Rename include guard.
8914         * common/x86-xstate.h: Rename include guard.
8915         * common/version.h: Rename include guard.
8916         * common/vec.h: Rename include guard.
8917         * common/tdesc.h: Rename include guard.
8918         * common/selftest.h: Rename include guard.
8919         * common/scoped_restore.h: Rename include guard.
8920         * common/scoped_mmap.h: Rename include guard.
8921         * common/scoped_fd.h: Rename include guard.
8922         * common/safe-iterator.h: Rename include guard.
8923         * common/run-time-clock.h: Rename include guard.
8924         * common/refcounted-object.h: Rename include guard.
8925         * common/queue.h: Rename include guard.
8926         * common/ptid.h: Rename include guard.
8927         * common/print-utils.h: Rename include guard.
8928         * common/preprocessor.h: Rename include guard.
8929         * common/pathstuff.h: Rename include guard.
8930         * common/observable.h: Rename include guard.
8931         * common/netstuff.h: Rename include guard.
8932         * common/job-control.h: Rename include guard.
8933         * common/host-defs.h: Rename include guard.
8934         * common/gdb_wait.h: Rename include guard.
8935         * common/gdb_vecs.h: Rename include guard.
8936         * common/gdb_unlinker.h: Rename include guard.
8937         * common/gdb_unique_ptr.h: Rename include guard.
8938         * common/gdb_tilde_expand.h: Rename include guard.
8939         * common/gdb_sys_time.h: Rename include guard.
8940         * common/gdb_string_view.h: Rename include guard.
8941         * common/gdb_splay_tree.h: Rename include guard.
8942         * common/gdb_setjmp.h: Rename include guard.
8943         * common/gdb_ref_ptr.h: Rename include guard.
8944         * common/gdb_optional.h: Rename include guard.
8945         * common/gdb_locale.h: Rename include guard.
8946         * common/gdb_assert.h: Rename include guard.
8947         * common/filtered-iterator.h: Rename include guard.
8948         * common/filestuff.h: Rename include guard.
8949         * common/fileio.h: Rename include guard.
8950         * common/environ.h: Rename include guard.
8951         * common/common-utils.h: Rename include guard.
8952         * common/common-types.h: Rename include guard.
8953         * common/common-regcache.h: Rename include guard.
8954         * common/common-inferior.h: Rename include guard.
8955         * common/common-gdbthread.h: Rename include guard.
8956         * common/common-exceptions.h: Rename include guard.
8957         * common/common-defs.h: Rename include guard.
8958         * common/common-debug.h: Rename include guard.
8959         * common/cleanups.h: Rename include guard.
8960         * common/buffer.h: Rename include guard.
8961         * common/btrace-common.h: Rename include guard.
8962         * common/break-common.h: Rename include guard.
8963         * cli/cli-utils.h: Rename include guard.
8964         * cli/cli-style.h: Rename include guard.
8965         * cli/cli-setshow.h: Rename include guard.
8966         * cli/cli-script.h: Rename include guard.
8967         * cli/cli-interp.h: Rename include guard.
8968         * cli/cli-decode.h: Rename include guard.
8969         * cli/cli-cmds.h: Rename include guard.
8970         * charset-list.h: Add include guard.
8971         * buildsym-legacy.h: Rename include guard.
8972         * bfin-tdep.h: Add include guard.
8973         * ax.h: Rename include guard.
8974         * arm-linux-tdep.h: Add include guard.
8975         * arm-fbsd-tdep.h: Add include guard.
8976         * arch/xtensa.h: Rename include guard.
8977         * arch/tic6x.h: Add include guard.
8978         * arch/i386.h: Add include guard.
8979         * arch/arm.h: Rename include guard.
8980         * arch/arm-linux.h: Rename include guard.
8981         * arch/arm-get-next-pcs.h: Rename include guard.
8982         * arch/amd64.h: Add include guard.
8983         * arch/aarch64-insn.h: Rename include guard.
8984         * arch-utils.h: Rename include guard.
8985         * annotate.h: Add include guard.
8986         * amd64-darwin-tdep.h: Rename include guard.
8987         * aarch64-linux-tdep.h: Add include guard.
8988         * aarch64-fbsd-tdep.h: Add include guard.
8989         * aarch32-linux-nat.h: Add include guard.
8990
8991 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8992
8993         * macrotab.c (macro_define_internal): New function that
8994         factorizes macro_define_object_internal and macro_define_function
8995         code.
8996         (macro_define_object_internal): Use macro_define_internal.
8997         (macro_define_function): Likewise.
8998
8999 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9000
9001         * macrocmd.c (extract_identifier): Return
9002         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
9003         callers.
9004
9005 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
9006
9007         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
9008
9009 2019-02-05  Tom Tromey  <tom@tromey.com>
9010
9011         * target.c (target_stack::unpush): Move assertion earlier.
9012
9013 2019-01-30  Tom Tromey  <tom@tromey.com>
9014
9015         PR python/23615:
9016         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
9017         (gdbpy_parse_and_eval): Likewise.
9018         * python/python-internal.h (gdbpy_allow_threads): New class.
9019
9020 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
9021
9022         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
9023         (aarch64_fbsd_fpregmap): Move earlier.
9024         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
9025         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9026         instead of individual calls to trad_frame_set_reg_addr.
9027         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
9028         earlier.
9029         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
9030         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
9031         instead of individual calls to trad_frame_set_reg_addr.
9032
9033 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
9034
9035         * CONTRIBUTE: Replace contribution list with wiki link.
9036
9037 2019-01-25  Tom Tromey  <tom@tromey.com>
9038
9039         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
9040
9041 2019-01-25  Tom Tromey  <tom@tromey.com>
9042
9043         * xtensa-linux-nat.c: Fix common/ includes.
9044         * xml-support.h: Fix common/ includes.
9045         * xml-support.c: Fix common/ includes.
9046         * x86-linux-nat.c: Fix common/ includes.
9047         * windows-nat.c: Fix common/ includes.
9048         * varobj.h: Fix common/ includes.
9049         * varobj.c: Fix common/ includes.
9050         * value.c: Fix common/ includes.
9051         * valops.c: Fix common/ includes.
9052         * utils.c: Fix common/ includes.
9053         * unittests/xml-utils-selftests.c: Fix common/ includes.
9054         * unittests/utils-selftests.c: Fix common/ includes.
9055         * unittests/unpack-selftests.c: Fix common/ includes.
9056         * unittests/tracepoint-selftests.c: Fix common/ includes.
9057         * unittests/style-selftests.c: Fix common/ includes.
9058         * unittests/string_view-selftests.c: Fix common/ includes.
9059         * unittests/scoped_restore-selftests.c: Fix common/ includes.
9060         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
9061         * unittests/scoped_fd-selftests.c: Fix common/ includes.
9062         * unittests/rsp-low-selftests.c: Fix common/ includes.
9063         * unittests/parse-connection-spec-selftests.c: Fix common/
9064         includes.
9065         * unittests/optional-selftests.c: Fix common/ includes.
9066         * unittests/offset-type-selftests.c: Fix common/ includes.
9067         * unittests/observable-selftests.c: Fix common/ includes.
9068         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
9069         * unittests/memrange-selftests.c: Fix common/ includes.
9070         * unittests/memory-map-selftests.c: Fix common/ includes.
9071         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
9072         * unittests/function-view-selftests.c: Fix common/ includes.
9073         * unittests/environ-selftests.c: Fix common/ includes.
9074         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
9075         * unittests/common-utils-selftests.c: Fix common/ includes.
9076         * unittests/cli-utils-selftests.c: Fix common/ includes.
9077         * unittests/array-view-selftests.c: Fix common/ includes.
9078         * ui-file.c: Fix common/ includes.
9079         * tui/tui-io.c: Fix common/ includes.
9080         * tracepoint.h: Fix common/ includes.
9081         * tracepoint.c: Fix common/ includes.
9082         * tracefile-tfile.c: Fix common/ includes.
9083         * top.h: Fix common/ includes.
9084         * top.c: Fix common/ includes.
9085         * thread.c: Fix common/ includes.
9086         * target/waitstatus.h: Fix common/ includes.
9087         * target/waitstatus.c: Fix common/ includes.
9088         * target.h: Fix common/ includes.
9089         * target.c: Fix common/ includes.
9090         * target-memory.c: Fix common/ includes.
9091         * target-descriptions.c: Fix common/ includes.
9092         * symtab.h: Fix common/ includes.
9093         * symfile.c: Fix common/ includes.
9094         * stap-probe.c: Fix common/ includes.
9095         * spu-linux-nat.c: Fix common/ includes.
9096         * sparc-nat.c: Fix common/ includes.
9097         * source.c: Fix common/ includes.
9098         * solib.c: Fix common/ includes.
9099         * solib-target.c: Fix common/ includes.
9100         * ser-unix.c: Fix common/ includes.
9101         * ser-tcp.c: Fix common/ includes.
9102         * ser-pipe.c: Fix common/ includes.
9103         * ser-base.c: Fix common/ includes.
9104         * selftest-arch.c: Fix common/ includes.
9105         * s12z-tdep.c: Fix common/ includes.
9106         * rust-exp.y: Fix common/ includes.
9107         * rs6000-aix-tdep.c: Fix common/ includes.
9108         * riscv-tdep.c: Fix common/ includes.
9109         * remote.c: Fix common/ includes.
9110         * remote-notif.h: Fix common/ includes.
9111         * remote-fileio.h: Fix common/ includes.
9112         * remote-fileio.c: Fix common/ includes.
9113         * regcache.h: Fix common/ includes.
9114         * regcache.c: Fix common/ includes.
9115         * record-btrace.c: Fix common/ includes.
9116         * python/python.c: Fix common/ includes.
9117         * python/py-type.c: Fix common/ includes.
9118         * python/py-inferior.c: Fix common/ includes.
9119         * progspace.h: Fix common/ includes.
9120         * producer.c: Fix common/ includes.
9121         * procfs.c: Fix common/ includes.
9122         * proc-api.c: Fix common/ includes.
9123         * printcmd.c: Fix common/ includes.
9124         * ppc-linux-nat.c: Fix common/ includes.
9125         * parser-defs.h: Fix common/ includes.
9126         * osdata.c: Fix common/ includes.
9127         * obsd-nat.c: Fix common/ includes.
9128         * nat/x86-linux.c: Fix common/ includes.
9129         * nat/x86-linux-dregs.c: Fix common/ includes.
9130         * nat/x86-dregs.h: Fix common/ includes.
9131         * nat/x86-dregs.c: Fix common/ includes.
9132         * nat/ppc-linux.c: Fix common/ includes.
9133         * nat/mips-linux-watch.h: Fix common/ includes.
9134         * nat/mips-linux-watch.c: Fix common/ includes.
9135         * nat/linux-waitpid.c: Fix common/ includes.
9136         * nat/linux-ptrace.h: Fix common/ includes.
9137         * nat/linux-ptrace.c: Fix common/ includes.
9138         * nat/linux-procfs.c: Fix common/ includes.
9139         * nat/linux-personality.c: Fix common/ includes.
9140         * nat/linux-osdata.c: Fix common/ includes.
9141         * nat/linux-namespaces.c: Fix common/ includes.
9142         * nat/linux-btrace.h: Fix common/ includes.
9143         * nat/linux-btrace.c: Fix common/ includes.
9144         * nat/fork-inferior.c: Fix common/ includes.
9145         * nat/amd64-linux-siginfo.c: Fix common/ includes.
9146         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
9147         * nat/aarch64-linux.c: Fix common/ includes.
9148         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
9149         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
9150         * namespace.h: Fix common/ includes.
9151         * mips-linux-tdep.c: Fix common/ includes.
9152         * minsyms.c: Fix common/ includes.
9153         * mi/mi-parse.h: Fix common/ includes.
9154         * mi/mi-main.c: Fix common/ includes.
9155         * mi/mi-cmd-env.c: Fix common/ includes.
9156         * memrange.h: Fix common/ includes.
9157         * memattr.c: Fix common/ includes.
9158         * maint.h: Fix common/ includes.
9159         * maint.c: Fix common/ includes.
9160         * main.c: Fix common/ includes.
9161         * machoread.c: Fix common/ includes.
9162         * location.c: Fix common/ includes.
9163         * linux-thread-db.c: Fix common/ includes.
9164         * linux-nat.c: Fix common/ includes.
9165         * linux-fork.c: Fix common/ includes.
9166         * inline-frame.c: Fix common/ includes.
9167         * infrun.c: Fix common/ includes.
9168         * inflow.c: Fix common/ includes.
9169         * inferior.h: Fix common/ includes.
9170         * inferior.c: Fix common/ includes.
9171         * infcmd.c: Fix common/ includes.
9172         * inf-ptrace.c: Fix common/ includes.
9173         * inf-child.c: Fix common/ includes.
9174         * ia64-linux-nat.c: Fix common/ includes.
9175         * i387-tdep.c: Fix common/ includes.
9176         * i386-tdep.c: Fix common/ includes.
9177         * i386-linux-tdep.c: Fix common/ includes.
9178         * i386-linux-nat.c: Fix common/ includes.
9179         * i386-go32-tdep.c: Fix common/ includes.
9180         * i386-fbsd-tdep.c: Fix common/ includes.
9181         * i386-fbsd-nat.c: Fix common/ includes.
9182         * guile/scm-type.c: Fix common/ includes.
9183         * guile/guile.c: Fix common/ includes.
9184         * go32-nat.c: Fix common/ includes.
9185         * gnu-nat.c: Fix common/ includes.
9186         * gdbthread.h: Fix common/ includes.
9187         * gdbarch-selftests.c: Fix common/ includes.
9188         * gdb_usleep.c: Fix common/ includes.
9189         * gdb_select.h: Fix common/ includes.
9190         * gdb_bfd.c: Fix common/ includes.
9191         * gcore.c: Fix common/ includes.
9192         * fork-child.c: Fix common/ includes.
9193         * findvar.c: Fix common/ includes.
9194         * fbsd-nat.c: Fix common/ includes.
9195         * event-top.c: Fix common/ includes.
9196         * event-loop.c: Fix common/ includes.
9197         * dwarf2read.c: Fix common/ includes.
9198         * dwarf2loc.c: Fix common/ includes.
9199         * dwarf2-frame.c: Fix common/ includes.
9200         * dwarf-index-cache.c: Fix common/ includes.
9201         * dtrace-probe.c: Fix common/ includes.
9202         * disasm-selftests.c: Fix common/ includes.
9203         * defs.h: Fix common/ includes.
9204         * csky-tdep.c: Fix common/ includes.
9205         * cp-valprint.c: Fix common/ includes.
9206         * cp-support.h: Fix common/ includes.
9207         * cp-support.c: Fix common/ includes.
9208         * corelow.c: Fix common/ includes.
9209         * completer.h: Fix common/ includes.
9210         * completer.c: Fix common/ includes.
9211         * compile/compile.c: Fix common/ includes.
9212         * compile/compile-loc2c.c: Fix common/ includes.
9213         * compile/compile-cplus-types.c: Fix common/ includes.
9214         * compile/compile-cplus-symbols.c: Fix common/ includes.
9215         * command.h: Fix common/ includes.
9216         * cli/cli-dump.c: Fix common/ includes.
9217         * cli/cli-cmds.c: Fix common/ includes.
9218         * charset.c: Fix common/ includes.
9219         * build-id.c: Fix common/ includes.
9220         * btrace.h: Fix common/ includes.
9221         * btrace.c: Fix common/ includes.
9222         * breakpoint.h: Fix common/ includes.
9223         * breakpoint.c: Fix common/ includes.
9224         * ax.h:
9225         (enum agent_op): Fix common/ includes.
9226         * ax-general.c (struct aop_map): Fix common/ includes.
9227         * ax-gdb.c: Fix common/ includes.
9228         * auxv.c: Fix common/ includes.
9229         * auto-load.c: Fix common/ includes.
9230         * arm-tdep.c: Fix common/ includes.
9231         * arch/riscv.c: Fix common/ includes.
9232         * arch/ppc-linux-common.c: Fix common/ includes.
9233         * arch/i386.c: Fix common/ includes.
9234         * arch/arm.c: Fix common/ includes.
9235         * arch/arm-linux.c: Fix common/ includes.
9236         * arch/arm-get-next-pcs.c: Fix common/ includes.
9237         * arch/amd64.c: Fix common/ includes.
9238         * arch/aarch64.c: Fix common/ includes.
9239         * arch/aarch64-insn.c: Fix common/ includes.
9240         * arch-utils.c: Fix common/ includes.
9241         * amd64-windows-tdep.c: Fix common/ includes.
9242         * amd64-tdep.c: Fix common/ includes.
9243         * amd64-sol2-tdep.c: Fix common/ includes.
9244         * amd64-obsd-tdep.c: Fix common/ includes.
9245         * amd64-nbsd-tdep.c: Fix common/ includes.
9246         * amd64-linux-tdep.c: Fix common/ includes.
9247         * amd64-linux-nat.c: Fix common/ includes.
9248         * amd64-fbsd-tdep.c: Fix common/ includes.
9249         * amd64-fbsd-nat.c: Fix common/ includes.
9250         * amd64-dicos-tdep.c: Fix common/ includes.
9251         * amd64-darwin-tdep.c: Fix common/ includes.
9252         * agent.c: Fix common/ includes.
9253         * ada-lang.h: Fix common/ includes.
9254         * ada-lang.c: Fix common/ includes.
9255         * aarch64-tdep.c: Fix common/ includes.
9256
9257 2019-01-25  Tom Tromey  <tom@tromey.com>
9258
9259         * common/create-version.sh: Use common/version.h.
9260
9261 2019-01-24  Pedro Alves  <palves@redhat.com>
9262
9263         * infrun.c (signal_stop, signal_print, signal_program)
9264         (signal_catch, signal_pass): Now arrays instead of pointers.
9265         (update_signals_program_target, do_target_resume)
9266         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
9267         * linux-nat.c (linux_nat_target::pass_signals)
9268         (linux_nat_target::create_inferior, linux_nat_target::attach):
9269         Adjust.
9270         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
9271         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
9272         * procfs.c (procfs_target::pass_signals): Adjust.
9273         * record-full.c (record_full_target::resume): Adjust.
9274         * remote.c (remote_target::pass_signals)
9275         (remote_target::program_signals): Adjust.
9276         * target-debug.h (target_debug_print_signals): Now takes a
9277         gdb::array_view as parameter.  Adjust.
9278         * target.h (target_ops) <pass_signals, program_signals>: Replace
9279         pointer and length parameters with gdb::array_view.
9280         (target_pass_signals, target_program_signals): Likewise.
9281         * target-delegates.c: Regenerate.
9282
9283 2019-01-24  Pedro Alves  <palves@redhat.com>
9284
9285         * common/forward-scope-exit.h
9286         (forward_scope_exit::forward_scope_exit): Pass arguments to
9287         m_bind_function directly, instead of creating a std::bind and
9288         copying that.
9289
9290 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
9291
9292         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9293         for static members.
9294         (pass_in_v_vfp_candidate): Likewise.
9295
9296 2019-01-23  Tom Tromey  <tom@tromey.com>
9297             Pedro Alves  <palves@redhat.com>
9298
9299         * regcache.c (class regcache_invalidator): Remove.
9300         (regcache::raw_write): Use make_scope_exit.
9301
9302 2019-01-23  Tom Tromey  <tom@tromey.com>
9303
9304         * ui-out.h (class ui_out_emit_type): Update comment.
9305
9306 2019-01-23  Tom Tromey  <tom@tromey.com>
9307
9308         * infrun.c (fetch_inferior_event): Update comment.
9309
9310 2019-01-23  Tom Tromey  <tom@tromey.com>
9311             Pedro Alves  <palves@redhat.com>
9312
9313         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
9314         parameter.
9315         (fetch_inferior_event): Use SCOPE_EXIT.
9316
9317
9318 2019-01-23  Tom Tromey  <tom@tromey.com>
9319             Pedro Alves  <palves@redhat.com>
9320
9321         * infrun.c (disable_thread_events): Delete.
9322         (stop_all_threads): Use SCOPE_EXIT.
9323
9324 2019-01-23  Tom Tromey  <tom@tromey.com>
9325             Pedro Alves  <palves@redhat.com>
9326
9327         * symfile.c: Include forward-scope-exit.h.
9328         (clear_symtab_users_cleanup): Replace forward declaration with
9329         a FORWARD_SCOPE_EXIT.
9330         (syms_from_objfile_1): Use the forward_scope_exit and
9331         gdb::optional instead of cleanup_function.
9332         (reread_symbols): Use the forward_scope_exit instead of
9333         cleanup_function.
9334         (clear_symtab_users_cleanup): Remove function.
9335
9336 2019-01-23  Tom Tromey  <tom@tromey.com>
9337             Pedro Alves  <palves@redhat.com>
9338
9339         * linux-nat.c: Include scope-exit.h.
9340         (cleanup_target_stop): Remove.
9341         (linux_nat_target::static_tracepoint_markers_by_strid): Use
9342         SCOPE_EXIT.
9343
9344 2019-01-23  Tom Tromey  <tom@tromey.com>
9345             Pedro Alves  <palves@redhat.com>
9346
9347         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
9348         (call_function_by_hand_dummy): Use SCOPE_EXIT.
9349
9350 2019-01-23  Tom Tromey  <tom@tromey.com>
9351             Andrew Burgess  <andrew.burgess@embecosm.com>
9352             Pedro Alves  <palves@redhat.com>
9353
9354         * infrun.c (fetch_inferior_event): Use scope_exit.
9355         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
9356         * top.c (execute_command): Use scope_exit.
9357         * breakpoint.c (bpstat_do_actions): Use scope_exit.
9358         * utils.c (do_bpstat_clear_actions_cleanup)
9359         (make_bpstat_clear_actions_cleanup): Remove.
9360
9361 2019-01-23  Tom Tromey  <tom@tromey.com>
9362             Pedro Alves  <palves@redhat.com>
9363
9364         * infrun.c: Include "common/scope-exit.h"
9365         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
9366         (wait_for_inferior): Use SCOPE_EXIT.
9367         (fetch_inferior_event): Use scope_exit.
9368
9369 2019-01-23  Tom Tromey  <tom@tromey.com>
9370             Pedro Alves  <palves@redhat.com>
9371
9372         * breakpoint.c (create_breakpoint): Remove cleanup.
9373
9374 2019-01-23  Tom Tromey  <tom@tromey.com>
9375             Andrew Burgess  <andrew.burgess@embecosm.com>
9376             Pedro Alves  <palves@redhat.com>
9377
9378 2019-01-23  Pedro Alves  <palves@redhat.com>
9379
9380         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
9381
9382 2019-01-23  Pedro Alves  <palves@redhat.com>
9383             Andrew Burgess  <andrew.burgess@embecosm.com>
9384
9385         * gdbthread.h: Include "common/forward-scope-exit.h".
9386         (scoped_finish_thread_state): Redefine custom class in terms of
9387         forward_scope_exit.
9388
9389 2019-01-23  Pedro Alves  <palves@redhat.com>
9390             Andrew Burgess  <andrew.burgess@embecosm.com>
9391
9392         * common/forward-scope-exit.h: New file.
9393
9394 2019-01-23  Pedro Alves  <palves@redhat.com>
9395             Andrew Burgess  <andrew.burgess@embecosm.com>
9396             Tom Tromey  <tom@tromey.com>
9397
9398         * common/scope-exit.h: New file.
9399
9400 2019-01-23  Pedro Alves  <palves@redhat.com>
9401
9402         * common/preprocessor.h (ESC): Rename to ...
9403         (ESC_PARENS): ... this.
9404         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
9405         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
9406
9407 2019-01-23  Tom Tromey  <tom@tromey.com>
9408
9409         * language.h (class scoped_switch_to_sym_language_if_auto):
9410         Initialize m_lang in both cases.
9411
9412 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
9413
9414         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
9415         with XCNEW.
9416
9417 2019-01-22  Tom Tromey  <tom@tromey.com>
9418
9419         * corelow.c: Do not include sys/file.h.
9420
9421 2019-01-22  Tom Tromey  <tom@tromey.com>
9422
9423         * tui/tui-wingeneral.h: Include gdb_curses.h.
9424
9425 2019-01-22  Tom Tromey  <tom@tromey.com>
9426
9427         * source-cache.h (class source_cache) <get_source_lines,
9428         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
9429
9430 2019-01-22  Tom Tromey  <tom@tromey.com>
9431
9432         * remote-fileio.h (struct remote_target): Declare.
9433
9434 2019-01-22  Tom Tromey  <tom@tromey.com>
9435
9436         * python/py-arch.c: Do not include py-ref.h.
9437         * python/py-bpevent.c: Do not include py-ref.h.
9438         * python/py-cmd.c: Do not include py-ref.h.
9439         * python/py-continueevent.c: Do not include py-ref.h.
9440         * python/py-event.h: Do not include py-ref.h.
9441         * python/py-evtregistry.c: Do not include py-ref.h.
9442         * python/py-finishbreakpoint.c: Do not include py-ref.h.
9443         * python/py-frame.c: Do not include py-ref.h.
9444         * python/py-framefilter.c: Do not include py-ref.h.
9445         * python/py-function.c: Do not include py-ref.h.
9446         * python/py-infevents.c: Do not include py-ref.h.
9447         * python/py-linetable.c: Do not include py-ref.h.
9448         * python/py-objfile.c: Do not include py-ref.h.
9449         * python/py-param.c: Do not include py-ref.h.
9450         * python/py-prettyprint.c: Do not include py-ref.h.
9451         * python/py-progspace.c: Do not include py-ref.h.
9452         * python/py-symbol.c: Do not include py-ref.h.
9453         * python/py-symtab.c: Do not include py-ref.h.
9454         * python/py-type.c: Do not include py-ref.h.
9455         * python/py-unwind.c: Do not include py-ref.h.
9456         * python/py-utils.c: Do not include py-ref.h.
9457         * python/py-value.c: Do not include py-ref.h.
9458         * python/py-varobj.c: Do not include py-ref.h.
9459         * python/py-xmethods.c: Do not include py-ref.h.
9460         * python/python.c: Do not include py-ref.h.
9461         * varobj.c: Do not include py-ref.h.
9462
9463 2019-01-22  Tom Tromey  <tom@tromey.com>
9464
9465         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
9466         keyword for bcache.
9467
9468 2019-01-22  Tom Tromey  <tom@tromey.com>
9469
9470         * compile/compile-cplus-types.c: Remove a comment by #include.
9471
9472 2019-01-22  Tom Tromey  <tom@tromey.com>
9473
9474         * compile/gcc-c-plugin.h: Include compile-internal.h.
9475
9476 2019-01-22  Tom Tromey  <tom@tromey.com>
9477
9478         * stabsread.c (EXTERN): Do not define.
9479         (symnum, next_symbol_text_func, processing_gcc_compilation)
9480         (within_function, global_sym_chain, global_stabs)
9481         (previous_stab_code, this_object_header_files)
9482         (n_this_object_header_files)
9483         (n_allocated_this_object_header_files): Define.
9484         * stabsread.h (EXTERN): Never define.  Use "extern".
9485
9486 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9487
9488         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
9489         history_value.
9490
9491 2019-01-21  Tom Tromey  <tom@tromey.com>
9492
9493         * ui-out.c: Fix includes.
9494         * tui/tui-source.c: Fix includes.
9495         * target.c: Fix includes.
9496         * remote.c: Fix includes.
9497         * regcache.c: Fix includes.
9498         * python/py-block.c: Fix includes.
9499         * printcmd.c: Fix includes.
9500         * or1k-tdep.c: Fix includes.
9501         * mi/mi-main.c: Fix includes.
9502         * m32r-tdep.c: Fix includes.
9503         * csky-tdep.c: Fix includes.
9504         * compile/compile-cplus-types.c: Fix includes.
9505         * cli/cli-interp.c: Fix includes.
9506
9507 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
9508
9509         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
9510         for padding.
9511
9512 2019-01-16  Tom Tromey  <tom@tromey.com>
9513
9514         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
9515         earlier.
9516         (struct objfile) <msymbols_range>: Move from top level.
9517         <msymbols>: New method.
9518         (class objfile_msymbols): Remove.
9519         * symtab.c (default_collect_symbol_completion_matches_break_on):
9520         Update.
9521         * symmisc.c (dump_msymbols): Update.
9522         * stabsread.c (scan_file_globals): Update.
9523         * objc-lang.c (info_selectors_command, info_classes_command)
9524         (find_methods): Update.
9525         * minsyms.c (find_solib_trampoline_target): Update.
9526         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
9527         * coffread.c (coff_symfile_read): Update.
9528         * ada-lang.c (ada_lookup_simple_minsym)
9529         (ada_collect_symbol_completion_matches): Update.
9530
9531 2019-01-16  Tom Tromey  <tom@tromey.com>
9532
9533         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
9534         type.  Remove no-argument constructor.
9535         <iterator::operator++>: Simplify.
9536         <begin>: Update.
9537         <end>: Use minimal_symbol_count.
9538
9539 2019-01-16  Tom Tromey  <tom@tromey.com>
9540
9541         * objfiles.h (struct objfile) <psymtabs>: New method.
9542         (class objfile_psymtabs): Remove.
9543         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
9544         typedef.
9545         <range>: New method.
9546         (require_partial_symbols): Change return type.
9547         * psymtab.c (require_partial_symbols)
9548         (psym_expand_symtabs_matching): Update.
9549         * mdebugread.c (parse_partial_symbols): Update.
9550         * dbxread.c (dbx_end_psymtab): Update.
9551
9552 2019-01-15  Tom Tromey  <tom@tromey.com>
9553
9554         * symtab.c (lookup_objfile_from_block)
9555         (lookup_symbol_in_objfile_symtabs)
9556         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
9557         (find_line_symtab, info_sources_command)
9558         (default_collect_symbol_completion_matches_break_on)
9559         (make_source_files_completion_list): Update.
9560         * symmisc.c (print_objfile_statistics, dump_objfile)
9561         (maintenance_print_symbols, maintenance_info_symtabs)
9562         (maintenance_check_symtabs, maintenance_info_line_tables):
9563         Update.
9564         * source.c (select_source_symtab)
9565         (forget_cached_source_info_for_objfile): Update.
9566         * objfiles.h (class objfile_compunits): Remove.
9567         (struct objfile) <compunits_range>: New typedef.
9568         (compunits): New method.
9569         * objfiles.c (objfile_relocate1): Update.
9570         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9571         * maint.c (count_symtabs_and_blocks): Update.
9572         * linespec.c (iterate_over_all_matching_symtabs): Update.
9573         * cp-support.c (add_symbol_overload_list_qualified): Update.
9574         * coffread.c (coff_symtab_read): Update.
9575         * ada-lang.c (add_nonlocal_symbols)
9576         (ada_collect_symbol_completion_matches)
9577         (ada_add_global_exceptions): Update.
9578
9579 2019-01-15  Tom Tromey  <tom@tromey.com>
9580
9581         * progspace.h (program_space) <objfiles_safe_range>: New
9582         typedef.
9583         <objfiles_safe>: New method.
9584         * objfiles.h (class all_objfiles_safe): Remove.
9585         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
9586         * jit.c (jit_inferior_exit_hook): Update.
9587
9588 2019-01-17  Tom Tromey  <tom@tromey.com>
9589
9590         * progspace.h (program_space) <objfiles_range>: New typedef.
9591         <objfiles>: New method.
9592         <objfiles_head>: Rename from objfiles.
9593         (object_files): Update.
9594         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
9595         * guile/scm-pretty-print.c
9596         (ppscm_find_pretty_printer_from_objfiles): Update.
9597         * guile/scm-objfile.c (gdbscm_objfiles): Update.
9598         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
9599         Update.
9600         * python/py-progspace.c (pspy_get_objfiles): Update.
9601         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9602         Update.
9603         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9604         (objfpy_lookup_objfile_by_build_id): Update.
9605         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
9606         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9607         Update.
9608         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9609         (expand_symtab_containing_pc, lookup_objfile_from_block)
9610         (lookup_static_symbol, basic_lookup_transparent_type)
9611         (find_pc_sect_compunit_symtab, find_symbol_at_address)
9612         (find_line_symtab, info_sources_command)
9613         (default_collect_symbol_completion_matches_break_on)
9614         (make_source_files_completion_list, find_main_name): Update.
9615         * symmisc.c (print_symbol_bcache_statistics)
9616         (print_objfile_statistics, maintenance_print_symbols)
9617         (maintenance_print_msymbols, maintenance_print_objfiles)
9618         (maintenance_info_symtabs, maintenance_check_symtabs)
9619         (maintenance_expand_symtabs, maintenance_info_line_tables):
9620         Update.
9621         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
9622         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
9623         (map_overlay_command, unmap_overlay_command)
9624         (simple_overlay_update, expand_symtabs_matching)
9625         (map_symbol_filenames): Update.
9626         * symfile-debug.c (set_debug_symfile): Update.
9627         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
9628         Update.
9629         * source.c (select_source_symtab, forget_cached_source_info):
9630         Update.
9631         * solib.c (solib_read_symbols): Update.
9632         * solib-spu.c (append_ocl_sos): Update.
9633         * psymtab.c (maintenance_print_psymbols)
9634         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
9635         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
9636         * printcmd.c (info_symbol_command): Update.
9637         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
9638         Update.
9639         * objfiles.h (class all_objfiles): Remove.
9640         * objfiles.c (have_partial_symbols, have_full_symbols)
9641         (have_minimal_symbols, qsort_cmp, update_section_map)
9642         (shared_objfile_contains_address_p)
9643         (default_iterate_over_objfiles_in_search_order): Update.
9644         * objc-lang.c (info_selectors_command, info_classes_command)
9645         (find_methods): Update.
9646         * minsyms.c (find_solib_trampoline_target): Update.
9647         * maint.c (maintenance_info_sections)
9648         (maintenance_translate_address, count_symtabs_and_blocks):
9649         Update.
9650         * main.c (captured_main_1): Update.
9651         * linux-thread-db.c (try_thread_db_load_from_pdir)
9652         (has_libpthread): Update.
9653         * linespec.c (iterate_over_all_matching_symtabs)
9654         (search_minsyms_for_name): Update.
9655         * jit.c (jit_find_objf_with_entry_addr): Update.
9656         * hppa-tdep.c (find_unwind_entry)
9657         (hppa_lookup_stub_minimal_symbol): Update.
9658         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
9659         Update.
9660         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9661         (elf_gnu_ifunc_resolve_by_got): Update.
9662         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
9663         * dwarf-index-write.c (save_gdb_index_command): Update.
9664         * cp-support.c (add_symbol_overload_list_qualified): Update.
9665         * breakpoint.c (create_overlay_event_breakpoint)
9666         (create_longjmp_master_breakpoint)
9667         (create_std_terminate_master_breakpoint)
9668         (create_exception_master_breakpoint): Update.
9669         * blockframe.c (find_pc_partial_function): Update.
9670         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
9671         (ada_collect_symbol_completion_matches)
9672         (ada_add_global_exceptions): Update.
9673
9674 2019-01-17  Tom Tromey  <tom@tromey.com>
9675
9676         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
9677         declare VEC.
9678         (solib_target_parse_libraries): Change return type.
9679         (library_list_start_segment, library_list_start_section)
9680         (library_list_end_library, library_list_start_library); Update.
9681         (solib_target_free_library_list): Remove.
9682         (solib_target_parse_libraries): Remove cleanup.  Change return
9683         type.
9684         (solib_target_current_sos): Update.
9685
9686 2019-01-17  Tom Tromey  <tromey@bapiya>
9687
9688         * valprint.c: Replace "the the" with "the".
9689         * symtab.c: Replace "the the" with "the".
9690         * solib.c: Replace "the the" with "the".
9691         * solib-dsbt.c: Replace "the the" with "the".
9692         * linespec.c: Replace "the the" with "the".
9693         * dwarf2loc.h: Replace "the the" with "the".
9694         * amd64-windows-tdep.c: Replace "the the" with "the".
9695         * aarch64-tdep.c: Replace "the the" with "the".
9696
9697 2019-01-16  Keith Seitz  <keiths@redhat.com>
9698
9699         PR gdb/23773
9700         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
9701         <builder>: Rename to ..
9702         <m_builder>: ... this and make private.
9703         (dwarf2_cu::get_builder): New method.  Change all users of
9704         `builder' to use this method.
9705         (dwarf2_start_symtab): Move to ...
9706         (dwarf2_cu::start_symtab): ... here.  Update all callers
9707         (setup_type_unit_groups): Move to ...
9708         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
9709         callers.
9710         (dwarf2_cu::reset_builder): New method.
9711         (process_full_compunit, process_full_type_unit): Use
9712         dwarf2_cu::reset_builder.
9713         (follow_die_offset): Record the ancestor CU if it is different
9714         from the followed DIE's CU.
9715         (follow_die_sig_1): Likewise.
9716
9717 2019-01-15  Tom Tromey  <tom@tromey.com>
9718
9719         * remote.c (class remote_state) <buf>: Now a char_vector.
9720         <buf_size>: Remove.
9721         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
9722         parameter.
9723         (remote_target::getpkt_or_notif_sane_1)
9724         (remote_target::getpkt_sane)
9725         (remote_target::getpkt_or_notif_sane): Likewise.
9726         (class remote_target) <putpkt>: New overload.
9727         (remote_target::read_frame): Change type of "buf_p".  Remove
9728         sizeof_p parameter.
9729         (packet_ok): New overload.
9730         (packet_check_result): New overload.
9731         Update all uses.
9732
9733 2019-01-14  Tom Tromey  <tom@tromey.com>
9734
9735         * remote-notif.c (handle_notification, remote_notif_ack)
9736         (remote_notif_parse): Make "buf" const.
9737         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
9738         const.
9739         (remote_notif_parse, remote_notif_ack, handle_notification):
9740         Likewise.
9741         * remote.c (remote_notif_stop_parse): Make "buf" const.
9742         (remote_target::remote_parse_stop_reply): Make "buf" const.
9743         (remote_notif_stop_ack): Make "buf" const.
9744
9745 2019-01-14  Tom Tromey  <tom@tromey.com>
9746
9747         * remote.c (remote_console_output): Make parameter const.
9748
9749 2019-01-14  Tom Tromey  <tom@tromey.com>
9750
9751         * target-debug.h (target_debug_print_signals): Constify.
9752         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
9753         * procfs.c (procfs_target::pass_signals): Update.
9754         * linux-nat.c (linux_nat_target::pass_signals): Update.
9755         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
9756         * target-delegates.c: Rebuild.
9757         * remote.c (remote_target::program_signals): Update.
9758         (remote_target::pass_signals): Update.
9759         * target.c (target_pass_signals): Constify argument.
9760         (target_program_signals): Likewise.
9761         * target.h (struct target_ops) <pass_signals, program_signals>:
9762         Constify argument.
9763         (target_pass_signals, target_program_signals): Constify argument.
9764
9765 2019-01-14  Tom Tromey  <tom@tromey.com>
9766
9767         PR tui/28819:
9768         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
9769
9770 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
9771
9772         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
9773         field.
9774         * rs6000-tdep.c: Include reggroups.h.
9775         (IS_V_ALIAS_PSEUDOREG): Define.
9776         (rs6000_register_name): Return names for the "vX" aliases.
9777         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
9778         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
9779         aliases.  Call default_register_reggroup_p for all other
9780         pseudo-registers.
9781         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
9782         New functions.
9783         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
9784         Handle "vX" aliases.
9785         (v_alias_pseudo_register_collect): New function.
9786         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
9787         (rs6000_gdbarch_init): Initialize "vX" aliases as
9788         pseudo-registers.  Restore registration of
9789         rs6000_pseudo_register_reggroup_p with
9790         set_tdesc_pseudo_register_reggroup_p.
9791
9792 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
9793
9794         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9795         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9796         set_gdbarch_num_pseudo_regs.
9797
9798 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9799
9800         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9801         Remove arg prefixname, add do_set and do_show.
9802         Add member functions set_list and show_list.
9803         * cli/cli-style.c (class cli_style_option): Update accordingly.
9804         (style_set_list): Move to file scope.
9805         (style_show_list): Likewise.
9806         (set_style): Call help_list.
9807         (show_style): Call cmd_show_list.
9808         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9809         Update to use the new macro.
9810
9811 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9812
9813         * ada-lang.c (_initialize_ada_language): Expand the help text
9814         for the "catch exception" command.
9815
9816 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9817
9818         * symtab.c (matching_obj_sections): Initialize obj,
9819         declare it closer to its usage.
9820
9821 2019-01-10  Tom Tromey  <tom@tromey.com>
9822
9823         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9824         (basic_inf_threads_range): Remove.
9825         (inf_threads_range, inf_non_exited_threads_range)
9826         (safe_inf_threads_range): Use next_adapter.
9827
9828 2019-01-10  Keith Seitz  <keiths@redhat.com>
9829
9830         PR gdb/23712
9831         PR symtab/23010
9832         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9833         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9834
9835 2019-01-10  Keith Seitz  <keiths@redhat.com>
9836
9837         PR gdb/23712
9838         PR symtab/23010
9839         * dictionary.c (pending_to_vector): Remove.
9840         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9841         Remove _1 suffix, replacing functions of the same name.  Update
9842         all callers.
9843         (dict_create_hashed, dict_create_hashed_expandable)
9844         (dict_create_linear, dict_create_linear_expandable, dict_free)
9845         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9846         Make functions static.
9847
9848 2019-01-10  Keith Seitz  <keiths@redhat.com>
9849
9850         PR gdb/23712
9851         PR symtab/23010
9852         * dictionary.h (struct dictionary): Replace declaration with
9853         multidictionary.
9854         (dict_create_hashed, dict_create_hashed_expandable)
9855         (dict_create_linear, dict_create_linear_expandable)
9856         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9857         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9858         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9859         taking multidictionary argument.
9860         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9861         * block.h (struct block) <dict>: Change to multidictionary
9862         and rename `multidict'.
9863         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9864         symmisc.c: Update all dictionary references to multidictionary.
9865
9866 2019-01-10  Keith Seitz  <keiths@redhat.com>
9867
9868         PR gdb/23712
9869         PR symtab/23010
9870         * dictionary.c: Include unordered_map.
9871         (pending_to_vector): New function.
9872         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9873         Rewrite the non-"_1" functions to take vector instead
9874         of linked list.
9875         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9876         "new" _1 versions of the same name.
9877         (multidictionary): Define.
9878         (std::hash<enum language): New definition.
9879         (collate_pending_symbols_by_language, mdict_create_hashed)
9880         (mdict_create_hashed_expandable, mdict_create_linear)
9881         (mdict_create_linear_expandable, mdict_free)
9882         (find_language_dictionary, create_new_language_dictionary)
9883         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9884         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9885         (mdict_size, mdict_empty): New functions.
9886         * dictionary.h (mdict_iterator): Define.
9887
9888 2019-01-10  Pedro Alves  <palves@redhat.com>
9889
9890         * breakpoint.c (read_uploaded_action)
9891         (create_tracepoint_from_upload): Adjust to use
9892         gdb::unique_xmalloc_ptr.
9893         * ctf.c (ctf_write_uploaded_tp):
9894         (SET_ARRAY_FIELD): Use emplace_back.
9895         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9896         * tracefile-tfile.c (tfile_write_uploaded_tp):
9897         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9898         gdb::unique_xmalloc_ptr.
9899         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9900         at_string, cond_string, cmd_strings>: Replace char pointers
9901         with gdb::unique_xmalloc_ptr.
9902
9903 2019-01-10  Pedro Alves  <palves@redhat.com>
9904
9905         * solib-target.c (library_list_start_library): Don't xstrdup name.
9906
9907 2019-01-10  Pedro Alves  <palves@redhat.com>
9908
9909         * mdebugread.c (parse_partial_symbols): Use
9910         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9911
9912 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9913
9914         * linux-fork.c (scoped_switch_fork_info)
9915         <~scoped_switch_fork_info>: Fix incorrect variable name.
9916
9917 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9918
9919         * linux-fork.c (scoped_switch_fork_info)
9920         <scoped_switch_fork_info>: Make explicit.
9921         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9922
9923 2019-01-10  Tom Tromey  <tom@tromey.com>
9924
9925         * objfiles.h (objfile::reset_psymtabs): Update.
9926         * objfiles.c (objfile::objfile): Update.
9927         * psymtab.h (psymtab_storage::obstack): Update.
9928         (psymtab_storage::m_obstack): Use gdb::optional.
9929         (class psymtab_storage): Update comment.  Remove objfile
9930         parameter.
9931         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9932
9933 2019-01-10  Tom Tromey  <tom@tromey.com>
9934
9935         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9936         <free_psymtabs>: Now private.
9937         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9938         (allocate_psymtab): Use new method.
9939
9940 2019-01-10  Tom Tromey  <tom@tromey.com>
9941
9942         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9943         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9944         * mdebugread.c (parse_partial_symbols): Use
9945         allocate_dependencies.
9946         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9947         allocate_dependencies.
9948         (process_psymtab_comp_unit_reader)
9949         (build_type_psymtab_dependencies): Likewise.
9950         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9951
9952 2019-01-10  Tom Tromey  <tom@tromey.com>
9953
9954         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9955         PSYMBOL_SET_LANGUAGE.
9956         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9957
9958 2019-01-10  Tom Tromey  <tom@tromey.com>
9959
9960         * psymtab.h (psymtab_storage::obstack): New method.
9961         <m_obstack>: Rename from obstack; now private.
9962         * psymtab.c (psymtab_storage): Update.
9963         * dwarf2read.c (create_addrmap_from_index)
9964         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9965         Update.
9966
9967 2019-01-10  Tom Tromey  <tom@tromey.com>
9968
9969         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9970         * objfiles.h (objfile::reset_psymtabs): New method.
9971
9972 2019-01-10  Tom Tromey  <tom@tromey.com>
9973
9974         * symmisc.c (print_symbol_bcache_statistics): Update.
9975         (print_objfile_statistics): Update.
9976         * symfile.c (reread_symbols): Update.
9977         * psymtab.h (class psymtab_storage): New.
9978         * psymtab.c (psymtab_storage): New constructor.
9979         (~psymtab_storage): New destructor.
9980         (require_partial_symbols): Update.
9981         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9982         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9983         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9984         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9985         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9986         (start_psymtab_common, end_psymtab_common)
9987         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9988         (allocate_psymtab): Update.
9989         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9990         Update.
9991         (dump_psymtab_addrmap, maintenance_print_psymbols)
9992         (maintenance_check_psymtabs): Update.
9993         (class objfile_psymtabs): Move to objfiles.h.
9994         * psympriv.h (discard_psymtab): Now inline.
9995         (psymtab_discarder::psymtab_discarder): Update.
9996         (psymtab_discarder::~psymtab_discarder): Update.
9997         (ALL_OBJFILE_PSYMTABS): Rewrite.
9998         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9999         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
10000         Remove fields.
10001         <partial_symtabs>: New field.
10002         (class objfile_psymtabs): Move from psymtab.h.  Update.
10003         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
10004         psymbol_cache.
10005         (objfile::~objfile): Don't destroy psymbol_cache.
10006         * mdebugread.c (parse_partial_symbols): Update.
10007         * dwarf2read.c (create_addrmap_from_index)
10008         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10009         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
10010         (add_partial_subprogram, dwarf2_ranges_read): Update.
10011         * dwarf-index-write.c (write_address_map)
10012         (write_one_signatured_type, recursively_write_psymbols)
10013         (class debug_names, class debug_names, write_psymtabs_to_index):
10014         Update.
10015
10016 2019-01-10  Tom Tromey  <tom@tromey.com>
10017
10018         * symtab.h (SYMBOL_SET_NAMES): Update.
10019         (symbol_set_names): Update.
10020         (MSYMBOL_SET_NAMES): Update.
10021         * symtab.c (symbol_set_names): Change argument to be an
10022         objfile_per_bfd_storage.
10023         * psymtab.c (add_psymbol_to_bcache): Update.
10024         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
10025
10026 2019-01-10  Tom Tromey  <tom@tromey.com>
10027
10028         * symtab.c (create_demangled_names_hash): Change argument to be an
10029         objfile_per_bfd_storage.
10030         (symbol_set_names): Update.
10031
10032 2019-01-10  Tom Tromey  <tom@tromey.com>
10033
10034         * xcoffread.c (xcoff_initial_scan): Unconditionally call
10035         init_psymbol_list.
10036         * psymtab.c (init_psymbol_list): Do nothing if already called.
10037         * psympriv.h (init_psymbol_list): Add comment.
10038         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
10039         init_psymbol_list.
10040         * dbxread.c (dbx_symfile_read): Unconditionally call
10041         init_psymbol_list.
10042
10043 2019-01-10  Tom Tromey  <tom@tromey.com>
10044
10045         * xcoffread.c (scan_xcoff_symtab): Update.
10046         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
10047         "where".
10048         * mdebugread.c (parse_partial_symbols)
10049         (handle_psymbol_enumerators): Update.
10050         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
10051         * dbxread.c (read_dbx_symtab): Update.
10052         * psympriv.h (psymbol_placement): New enum.
10053         (add_psymbol_to_list): Update.
10054
10055 2019-01-10  Tom Tromey  <tom@tromey.com>
10056
10057         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
10058         static_psymbols parameters.
10059         (scan_xcoff_symtab): Update.
10060         * psymtab.c (start_psymtab_common): Remove global_psymbols and
10061         static_psymbols parameters.
10062         * psympriv.h (start_psymtab_common): Update.
10063         * mdebugread.c (parse_partial_symbols): Update.
10064         * dwarf2read.c (create_partial_symtab): Update.
10065         * dbxread.c (read_dbx_symtab): Update.
10066         (start_psymtab): Remove global_psymbols and static_psymbols
10067         parameters.
10068
10069 2019-01-10  Tom Tromey  <tom@tromey.com>
10070
10071         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
10072         * psymtab.c (allocate_psymtab): Add comment.
10073         * psympriv.h (allocate_psymtab): Add comment.
10074         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
10075         initializations.
10076         * dbxread.c (dbx_end_psymtab): Remove some initializations.
10077
10078 2019-01-10  Tom Tromey  <tom@tromey.com>
10079
10080         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10081         Don't declare.
10082         * mipsread.c: Include mdebugread.h.
10083         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
10084         Declare.
10085         * elfread.c: Include mdebugread.h.
10086
10087 2019-01-09  Tom Tromey  <tom@tromey.com>
10088
10089         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
10090         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
10091         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
10092         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
10093         (psym_lookup_symbol, psym_find_last_source_symtab)
10094         (psym_forget_cached_source_info, psym_print_stats)
10095         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
10096         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
10097         (psym_map_matching_symbols, psym_expand_symtabs_matching)
10098         (psym_find_compunit_symtab_by_address)
10099         (maintenance_print_psymbols, maintenance_info_psymtabs)
10100         (maintenance_check_psymtabs): Use ranged for.
10101         * psymtab.h (class objfile_psymtabs): New.
10102         (require_partial_symbols): Return objfile_psymtabs.
10103         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
10104
10105 2019-01-09  Tom Tromey  <tom@tromey.com>
10106
10107         * symfile.c (overlay_invalidate_all, find_pc_overlay)
10108         (find_pc_mapped_section, list_overlays_command)
10109         (map_overlay_command, unmap_overlay_command)
10110         (simple_overlay_update): Use all_objfiles.
10111         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
10112         * printcmd.c (info_symbol_command): Use all_objfiles.
10113         * objfiles.h (ALL_OBJSECTIONS): Remove.
10114         * maint.c (maintenance_translate_address): Use all_objfiles.
10115         * gcore.c (gcore_create_callback): Use all_objfiles.
10116         (objfile_find_memory_regions): Likewise.
10117
10118 2019-01-09  Tom Tromey  <tom@tromey.com>
10119
10120         * symtab.c (find_line_symtab, info_sources_command)
10121         (make_source_files_completion_list): Use objfile_compunits.
10122         * source.c (select_source_symtab): Use objfile_compunits.
10123         * objfiles.h (struct objfile): Update comment.
10124         (ALL_OBJFILES): Remove.
10125         (ALL_FILETABS): Remove.
10126         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
10127         objfile_compunits.
10128
10129 2019-01-09  Tom Tromey  <tom@tromey.com>
10130
10131         * symmisc.c (print_objfile_statistics, dump_objfile)
10132         (maintenance_print_symbols): Use compunit_filetabs.
10133         * source.c (forget_cached_source_info_for_objfile): Use
10134         compunit_filetabs.
10135         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
10136         (ALL_FILETABS): Use compunit_filetabs.
10137         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
10138         * coffread.c (coff_symtab_read): Use compunit_filetabs.
10139
10140 2019-01-09  Tom Tromey  <tom@tromey.com>
10141
10142         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
10143         (compunit_filetabs): New.
10144         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
10145         compunit_filetabs.
10146         (info_sources_command, make_source_files_completion_list): Remove
10147         declaration.
10148         * symmisc.c (print_objfile_statistics, dump_objfile)
10149         (maintenance_print_symbols): Remove declaration.
10150         (maintenance_info_symtabs): Use compunit_filetabs.
10151         (maintenance_info_line_tables): Likewise.
10152         * source.c (select_source_symtab): Change local variable name.
10153         (forget_cached_source_info_for_objfile): Remove declaration.
10154         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
10155         * objfiles.c (objfile_relocate1): Remove declaration.
10156         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10157         declaration.
10158         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
10159         * coffread.c (coff_symtab_read): Remove declaration.
10160         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
10161         compunit_filetabs.
10162
10163 2019-01-09  Tom Tromey  <tom@tromey.com>
10164
10165         * symtab.c (lookup_objfile_from_block)
10166         (find_pc_sect_compunit_symtab, search_symbols)
10167         (default_collect_symbol_completion_matches_break_on): Use
10168         objfile_compunits.
10169         * objfiles.h (ALL_COMPUNITS): Remove.
10170         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
10171         * cp-support.c (add_symbol_overload_list_qualified): Use
10172         objfile_compunits.
10173         * ada-lang.c (ada_collect_symbol_completion_matches)
10174         (ada_add_global_exceptions): Use objfile_compunits.
10175
10176 2019-01-09  Tom Tromey  <tom@tromey.com>
10177
10178         * source.c (select_source_symtab)
10179         (forget_cached_source_info_for_objfile): Remove declaration.
10180         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
10181         declaration.
10182         * maint.c (count_symtabs_and_blocks): Remove declaration.
10183         * cp-support.c (add_symbol_overload_list_qualified): Remove
10184         declaration.
10185         * coffread.c (coff_symtab_read): Remove declaration.
10186         * symtab.c (lookup_symbol_in_objfile_symtabs)
10187         (basic_lookup_transparent_type_1): Use objfile_compunits.
10188         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
10189         (info_sources_command, search_symbols)
10190         (default_collect_symbol_completion_matches_break_on)
10191         (make_source_files_completion_list): Remove declaration.
10192         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
10193         (ada_collect_symbol_completion_matches)
10194         (ada_add_global_exceptions): Remove declaration.
10195         * linespec.c (iterate_over_all_matching_symtabs): Use
10196         objfile_compunits.
10197         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
10198         (class objfile_compunits): New.
10199         (ALL_COMPUNITS): Use objfile_compunits.
10200         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
10201         (maintenance_check_symtabs, maintenance_info_line_tables): Use
10202         objfile_compunits.
10203         * objfiles.c (objfile_relocate1): Use objfile_compunits.
10204
10205 2019-01-09  Tom Tromey  <tom@tromey.com>
10206
10207         * symtab.c (search_symbols)
10208         (default_collect_symbol_completion_matches_break_on): Use
10209         objfile_msymbols.
10210         * ada-lang.c (ada_lookup_simple_minsym)
10211         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
10212         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
10213         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
10214         objfile_msymbols.
10215         * coffread.c (coff_symfile_read): Use objfile_msymbols.
10216         * symmisc.c (dump_msymbols): Use objfile_msymbols.
10217         * objc-lang.c (find_methods): Use objfile_msymbols.
10218         (info_selectors_command, info_classes_command): Likewise.
10219         * stabsread.c (scan_file_globals): Use objfile_msymbols.
10220         * objfiles.h (class objfile_msymbols): New.
10221         (ALL_OBJFILE_MSYMBOLS): Remove.
10222         (ALL_MSYMBOLS): Remove.
10223
10224 2019-01-09  Tom Tromey  <tom@tromey.com>
10225
10226         * common/next-iterator.h (next_adapter): Add Iterator template
10227         parameter.
10228         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
10229         (class all_objfiles_safe): New.
10230         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
10231         * objfiles.c (put_objfile_before): Update comment.
10232         (add_separate_debug_objfile): Likewise.
10233         (free_all_objfiles): Use all_objfiles_safe.
10234         (objfile_purge_solibs): Likewise.
10235
10236 2019-01-09  Tom Tromey  <tom@tromey.com>
10237
10238         * symtab.c (iterate_over_symtabs, matching_obj_sections)
10239         (expand_symtab_containing_pc, lookup_static_symbol)
10240         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
10241         (find_symbol_at_address, find_line_symtab, find_main_name): Use
10242         all_objfiles.
10243         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
10244         * breakpoint.c (create_overlay_event_breakpoint)
10245         (create_longjmp_master_breakpoint)
10246         (create_std_terminate_master_breakpoint)
10247         (create_exception_master_breakpoint): Use all_objfiles.
10248         * linux-thread-db.c (try_thread_db_load_from_pdir)
10249         (has_libpthread): Use all_objfiles.
10250         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
10251         * linespec.c (iterate_over_all_matching_symtabs)
10252         (search_minsyms_for_name): Use all_objfiles.
10253         * maint.c (maintenance_info_sections): Use all_objfiles.
10254         * main.c (captured_main_1): Use all_objfiles.
10255         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
10256         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
10257         * guile/scm-pretty-print.c
10258         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
10259         * solib-spu.c (append_ocl_sos): Use all_objfiles.
10260         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
10261         (maintenance_print_msymbols): Use all_objfiles.
10262         * source.c (select_source_symtab): Use all_objfiles.
10263         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
10264         * symfile.c (remove_symbol_file_command)
10265         (expand_symtabs_matching, map_symbol_filenames): Use
10266         all_objfiles.
10267         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
10268         all_objfiles.
10269         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
10270         * objc-lang.c (find_methods): Use all_objfiles.
10271         * objfiles.c (have_partial_symbols, have_full_symbols)
10272         (have_minimal_symbols, qsort_cmp)
10273         (default_iterate_over_objfiles_in_search_order): Use
10274         all_objfiles.
10275         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
10276         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
10277         (maintenance_check_psymtabs): Use all_objfiles.
10278         (ALL_PSYMTABS): Remove.
10279         * compile/compile-object-run.c (do_module_cleanup): Use
10280         all_objfiles.
10281         * blockframe.c (find_pc_partial_function): Use all_objfiles.
10282         * cp-support.c (add_symbol_overload_list_qualified): Use
10283         all_objfiles.
10284         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
10285         Use all_objfiles.
10286         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
10287         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
10288         all_objfiles.
10289         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
10290         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
10291         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
10292         Uses all_objfiles.
10293         * solib.c (solib_read_symbols): Use all_objfiles
10294
10295 2019-01-09  Tom Tromey  <tom@tromey.com>
10296
10297         * probe.c (parse_probes_in_pspace): Use all_objfiles.
10298         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
10299         all_objfiles.
10300         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
10301         * symmisc.c (print_symbol_bcache_statistics)
10302         (print_objfile_statistics, maintenance_print_objfiles)
10303         (maintenance_info_symtabs, maintenance_check_symtabs)
10304         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
10305         all_objfiles.
10306         * source.c (forget_cached_source_info): Use all_objfiles.
10307         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
10308         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
10309         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
10310         * objfiles.c (update_section_map): Use all_objfiles.
10311         (shared_objfile_contains_address_p): Likewise.
10312         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
10313         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
10314
10315 2019-01-09  Tom Tromey  <tom@tromey.com>
10316
10317         * common/next-iterator.h: New file.
10318         * objfiles.h (class all_objfiles): New.
10319         (struct objfile_iterator): New.
10320
10321 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10322
10323         * NEWS: Move the description of the changed "frame", "select-frame",
10324          and "info frame" commands to the Changed commands section.
10325
10326 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
10327
10328         * gdbtypes.c (check_stub_method_group): Remove handling of old
10329         mangling schemes.
10330         * linespec.c (find_methods): Likewise.
10331         * stabsread.c (read_member_functions): Likewise.
10332         * valops.c (search_struct_method): Likewise.
10333         (value_struct_elt_for_reference): Likewise.
10334         * NEWS: Mention this change.
10335
10336 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10337
10338         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
10339         print_source_lines.
10340         * source.c (print_source_lines_base): Update line number check.
10341         (print_source_lines): New function.
10342         (source_lines_range::source_lines_range): New function.
10343         * source.h (class source_lines_range): New class.
10344         (print_source_lines): New declaration.
10345
10346 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10347
10348         * linespec.c (linespec_state_destructor): Free self->canonical_names.
10349
10350 2019-01-08  Tom Tromey  <tom@tromey.com>
10351             Simon Marchi  <simon.marchi@ericsson.com>
10352
10353         PR gdb/24060
10354         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
10355         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
10356         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10357         * f-exp.y (DOLLAR_VARIABLE): Likewise.
10358         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
10359         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
10360
10361 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10362
10363         * source.c (select_source_symtab): Move header comment to
10364         declaration in source.h.
10365         (forget_cached_source_info_for_objfile): Likewise.
10366         (forget_cached_source_info): Likewise.
10367         (identify_source_line): Likewise.
10368         * source.h (identify_source_line): Move declaration from symtab.h
10369         and add comment from source.c
10370         (print_source_lines): Likewise.
10371         (forget_cached_source_info_for_objfile): Likewise.
10372         (forget_cached_source_info): Likewise.
10373         (select_source_symtab): Likewise.
10374         (enum print_source_lines_flag): Move definition from symtab.h.
10375         * symtab.h (identify_source_line): Move declaration to source.h.
10376         (print_source_lines): Likewise.
10377         (forget_cached_source_info_for_objfile): Likewise.
10378         (forget_cached_source_info): Likewise.
10379         (select_source_symtab): Likewise.
10380         (enum print_source_lines_flag): Move definition to source.h.
10381         * tui/tui-hooks.c: Add 'source.h' include.
10382
10383 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10384
10385         * source.c (print_source_lines_base): Handle requests to print
10386         reverse line number sequences, and guard against empty lines
10387         string.
10388
10389 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10390
10391         * source.c (print_source_lines_base): Fix skip of '\r' if next
10392         character is '\n'.
10393
10394 2019-01-06  Tom Tromey  <tom@tromey.com>
10395
10396         * c-exp.y (struct c_parse_state) <macro_original_text,
10397         expansion_obstack>: New member.
10398         (macro_original_text, expansion_obstack): Remove globals.
10399         (scan_macro_expansion, scanning_macro_expansion)
10400         (finished_macro_expansion): Update.
10401         (scan_macro_cleanup): Remove.
10402         (yylex, c_parse): Update.
10403
10404 2019-01-06  Tom Tromey  <tom@tromey.com>
10405
10406         * c-exp.y (struct c_parse_state) <strings>: New member.
10407         (operator_stoken): Update.
10408
10409 2019-01-06  Tom Tromey  <tom@tromey.com>
10410
10411         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
10412         (union type_stack_elt) <typelist_val>: Now a pointer to
10413         std::vector.
10414         (type_stack_cleanup): Don't declare.
10415         (push_typelist): Update.
10416         * parse.c (pop_typelist): Return a std::vector.
10417         (push_typelist): Take a std::vector.
10418         (follow_types): Update.  Do not free args.
10419         (type_stack_cleanup): Remove.
10420         * c-exp.y (struct c_parse_state): New.
10421         (cpstate): New global.
10422         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
10423         (nonempty_typelist): Update.
10424         (func_mod): Create a new vector.
10425         (c_parse): Create a c_parse_state.
10426         (check_parameter_typelist): Do not delete params.
10427         (function_method): Update.  Do not delete type_list.
10428
10429 2019-01-06  Tom Tromey  <tom@tromey.com>
10430
10431         PR gdb/28155:
10432         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
10433         check_typedef.
10434         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
10435         (print_return_value): Likewise.
10436
10437 2019-01-05  Tom Tromey  <tom@tromey.com>
10438
10439         * contrib/cleanup_check.py: Remove.
10440         * contrib/gcc-with-excheck: Remove.
10441         * contrib/exsummary.py: Remove.
10442         * contrib/excheck.py: Remove.
10443
10444 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
10445
10446         * thread.c (delete_thread_1): Add gdb_assert that THR is not
10447         NULL. Initialize tpprev to NULL instead of assigning it
10448         to NULL on the next statement.
10449         * windows-nat.c (windows_delete_thread): Remove check for
10450         main_thread_id before printing thread exit notifications.
10451         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
10452         Remove thread ID check against main_thread_id.
10453         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
10454         windows_delete_thread.
10455         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
10456
10457 2019-01-04  Tom Tromey  <tom@tromey.com>
10458
10459         * compile/compile.c (_initialize_compile): Use upper case for
10460         metasyntactic variables.
10461         * symmisc.c (_initialize_symmisc): Use upper case for
10462         metasyntactic variables.
10463         * psymtab.c (_initialize_psymtab): Use upper case for
10464         metasyntactic variables.
10465         * demangle.c (demangle_command): Use upper case for metasyntactic
10466         variables.
10467         (_initialize_demangler): Likewise.
10468         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
10469         variables.
10470
10471 2019-01-03  Tom Tromey  <tom@tromey.com>
10472
10473         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
10474
10475 2019-01-03  Tom Tromey  <tom@tromey.com>
10476
10477         * python/py-symtab.c (salpy_str): Update.
10478         (struct salpy_sal_object) <symtab>: Now a PyObject.
10479         (salpy_dealloc): Update.
10480         (del_objfile_sal): Use gdbpy_ref.
10481
10482 2019-01-03  Tom Tromey  <tom@tromey.com>
10483
10484         * python/py-type.c (convert_field): Use new_reference.  Return
10485         gdbpy_ref.
10486         (make_fielditem): Return gdbpy_ref.
10487         (typy_fields): Update.
10488         (typy_getitem): Update.
10489         (field_name): Return gdbpy_ref.  Use new_reference.
10490         (typy_iterator_iternext): Update.
10491
10492 2019-01-03  Tom Tromey  <tom@tromey.com>
10493
10494         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
10495
10496 2019-01-03  Tom Tromey  <tom@tromey.com>
10497
10498         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
10499         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
10500         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
10501         (pspy_set_frame_filters, pspy_set_frame_unwinders)
10502         (pspy_set_type_printers): Likewise.
10503         * python/py-function.c (fnpy_init): Use gdbpy_ref.
10504         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
10505         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
10506         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
10507         (objfpy_set_type_printers): Likewise.
10508
10509 2019-01-03  Tom Tromey  <tom@tromey.com>
10510
10511         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
10512         (gdbpy_print_stack): Use gdbpy_err_fetch.
10513         * python/python-internal.h (class gdbpy_err_fetch): New class.
10514         (class gdbpy_enter) <m_error_type, m_error_value,
10515         m_error_traceback>: Remove.
10516         <m_error>: New member.
10517         (gdbpy_exception_to_string): Don't declare.
10518         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
10519         * python/py-value.c (convert_value_from_python): Use
10520         gdbpy_err_fetch.
10521         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
10522         gdbpy_exception_to_string.
10523         (gdbpy_handle_exception): Use gdbpy_err_fetch.
10524         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
10525         gdbpy_err_fetch.
10526
10527 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10528
10529         * linux-nat.c (delete_lwp_cleanup): Delete.
10530         (struct lwp_deleter): New struct.
10531         (lwp_info_up): New typedef.
10532         (linux_nat_target::follow_fork): Delete cleanup, and make use of
10533         lwp_info_up.
10534
10535 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10536
10537         * linux-fork.c (class scoped_switch_fork_info): New class.
10538         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
10539
10540 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10541
10542         * valops.c (find_overload_match): Remove use of null_cleanup, and
10543         calls to do_cleanups.
10544
10545 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10546
10547         * compile/compile-cplus-types.c
10548         (compile_cplus_instance::decl_name): Handle changes to
10549         cp_func_name.
10550         * cp-support.c (cp_func_name): Update header comment, update
10551         return type.
10552         * cp-support.h (cp_func_name): Update return type in declaration.
10553         * valops.c (find_overload_match): Move temp_func local to top
10554         level of function and change its type.  Use temp_func to hold and
10555         delete temporary string obtained from cp_func_name.
10556
10557 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
10558
10559         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
10560         gdb::char_vector, remove cleanup, and update uses of `msg`.
10561
10562 2019-01-03  Jim Wilson  <jimw@sifive.com>
10563
10564         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
10565
10566 2019-01-02  Tom Tromey  <tom@tromey.com>
10567
10568         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
10569         (tdesc_parse_xml): Remove cleanups.
10570         * target-descriptions.h (make_cleanup_free_target_description):
10571         Don't declare.
10572         (target_desc_deleter): New struct.
10573         (target_desc_up): New typedef.
10574         * target-descriptions.c (target_desc_deleter::operator()): Rename
10575         from free_target_description.
10576         (make_cleanup_free_target_description): Remove.
10577
10578 2019-01-02  Tom Tromey  <tom@tromey.com>
10579
10580         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
10581         constructor, destructor.
10582         (linespec_parser): Remove typedef.
10583         (~linespec_parser): Rename from linespec_parser_delete.
10584         (linespec_lex_to_end, linespec_complete_label)
10585         (linespec_complete): Update.
10586         (decode_line_full): Remove cleanups.
10587         (decode_line_1): Update.
10588
10589 2019-01-02  Tom Tromey  <tom@tromey.com>
10590
10591         * python/python-internal.h (inferior_to_inferior_object): Change
10592         return type.
10593         * python/py-exitedevent.c (create_exited_event_object): Update.
10594         * python/py-inferior.c (inferior_to_inferior_object): Return
10595         gdbpy_ref.
10596         (python_new_inferior, python_inferior_deleted)
10597         (thread_to_thread_object, delete_thread_object)
10598         (build_inferior_list, gdbpy_selected_inferior): Update.
10599         * python/py-infthread.c (create_thread_object): Update.  Also fail
10600         if inferior_to_inferior_object fails.
10601
10602 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
10603
10604         * inferior.h (class inferior) <displaced_step_state>: New field.
10605         * infrun.h (struct displaced_step_state): Move here from
10606         infrun.c.  Initialize fields, add constructor.
10607         <inf>: Remove field.
10608         <reset>: New method.
10609         * infrun.c (struct displaced_step_inferior_state): Move to
10610         infrun.h.
10611         (displaced_step_inferior_states): Remove.
10612         (get_displaced_stepping_state): Adust.
10613         (displaced_step_in_progress_any_inferior): Adjust.
10614         (displaced_step_in_progress_thread): Adjust.
10615         (displaced_step_in_progress): Adjust.
10616         (add_displaced_stepping_state): Remove.
10617         (get_displaced_step_closure_by_addr): Adjust.
10618         (remove_displaced_stepping_state): Remove.
10619         (infrun_inferior_exit): Call displaced_step_state.reset.
10620         (use_displaced_stepping): Don't check for NULL.
10621         (displaced_step_prepare_throw): Call
10622         get_displaced_stepping_state.
10623         (displaced_step_fixup): Don't check for NULL.
10624         (prepare_for_detach): Don't check for NULL.
10625
10626 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10627
10628         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
10629          in case of call that did not complete.
10630
10631 2019-01-02  Andrey Utkin  <autkin@undo.io>
10632
10633         * symfile.c (find_separate_debug_file): Fix search of debug files for
10634         remote debuggee.
10635
10636 2019-01-02  Tom Tromey  <tom@tromey.com>
10637
10638         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
10639         indentation.
10640         * python/py-frame.c (frapy_older): Remove cast.
10641         (frapy_newer): Likewise.
10642         * python/py-breakpoint.c (local_setattro): Remove cast.
10643         * python/py-arch.c (archpy_name): Remove local variable.
10644         * python/py-type.c (gdbpy_lookup_type): Remove cast.
10645
10646 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
10647
10648         * unittests/basic_string_view/element_access/char/empty.cc:
10649         Fix year range in copyright header.
10650
10651 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10652
10653         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
10654         Delete.
10655         <operator==>: Update with for removed field.
10656         <hash>: Likewise.
10657         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
10658         <isa_features>: ...this.
10659         <abi_features>: New field.
10660         (riscv_isa_flen): Update comment.
10661         (riscv_abi_xlen): New declaration.
10662         (riscv_abi_flen): New declaration.
10663         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
10664         isa_features.
10665         (riscv_abi_xlen): New function.
10666         (riscv_isa_flen): Update to get answer from isa_features.
10667         (riscv_abi_flen): New function.
10668         (riscv_has_fp_abi): Update to get answer from abi_features.
10669         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
10670         xlen and flen.
10671         (riscv_call_info) <xlen, flen>: Update comment.
10672         (riscv_call_arg_struct): Remove invalid assertions
10673         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
10674         is removed.
10675         (riscv_gdbarch_init): Gather isa features and abi features
10676         separately, ensure both match on the gdbarch when reusing an old
10677         gdbarch.  Relax an error check to allow 32-bit abi float to run on
10678         a target with 64-bit float hardware.
10679
10680 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10681
10682         * source.c (search_command_helper): Stop reverse search
10683         when line 1 has been searched.
10684
10685 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10686
10687         * record-full.c (record_full_base_target::close): Rewrite
10688         record_full_core_buf_list free logic.
10689
10690 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10691
10692         * break-catch-syscall.c (print_one_catch_syscall): xfree
10693         the last text.
10694
10695 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10696
10697         * top.c (print_gdb_version): Update Copyright year in version
10698         message.
10699
10700 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
10701
10702         Update copyright year range in all GDB files.
10703
10704 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
10705
10706         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
10707
10708 For older changes see ChangeLog-2018.
10709 \f
10710 Local Variables:
10711 mode: change-log
10712 left-margin: 8
10713 fill-column: 74
10714 version-control: never
10715 coding: utf-8
10716 End:
10717