gdb/ChangeLog

   1 2019-10-01  Tom Tromey  <tom@tromey.com>
   2
   3         * ui-out.h (enum class ui_out_style_kind): Remove.
   4         (class ui_out) <field_string, field_stsream, do_field_string>:
   5         Change type of "style".
   6         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
   7         (ui_out::field_string): Update.
   8         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
   9         of "style".
  10         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
  11         * tracepoint.c (print_one_static_tracepoint_marker): Update.
  12         * stack.c (print_frame_arg, print_frame_info, print_frame):
  13         Update.
  14         * source.c (print_source_lines_base): Update.
  15         * solib.c (info_sharedlibrary_command): Update.
  16         * skip.c (info_skip_command): Update.
  17         * record-btrace.c (btrace_call_history_src_line)
  18         (btrace_call_history): Update.
  19         * python/py-framefilter.c (py_print_frame): Update.
  20         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
  21         "style".
  22         * mi/mi-out.c (mi_ui_out::do_table_header)
  23         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
  24         (mi_ui_out::do_field_string): Update.
  25         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  26         Update.
  27         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
  28         "style".
  29         * cli-out.c (cli_ui_out::do_table_header)
  30         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
  31         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
  32         (cli_ui_out::do_field_fmt): Update.
  33         * breakpoint.c (print_breakpoint_location): Update.
  34         (update_static_tracepoint): Update.
  35
  36 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  37
  38         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
  39         conversion of gdb_datadir.
  40         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
  41         remove not needed c_str ().
  42
  43 2019-09-30  Ali Tamur <tamur@google.com>
  44
  45         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
  46         (dwarf2_string_attr): Likewise.
  47
  48 2019-09-30  Ali Tamur <tamur@google.com>
  49
  50         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
  51         (process_full_type_unit): Likewise.
  52         (dump_die_shallow): Likewise.
  53         (cu_debug_loc_section): Likewise.
  54
  55 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
  56
  57         * minsyms.c (compare_minimal_symbols): Rename to...
  58         (minimal_symbol_is_less_than): ...this, and adjust to STL
  59         conventions (return bool, take arguments as references)
  60         (minimal_symbol_reader::install): Call std::sort instead
  61         of qsort.
  62
  63 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
  64
  65         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
  66         hash and why.
  67         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
  68         msymbol_hash, msymbol_demangled_hash>: Improve comments.
  69
  70 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
  71
  72         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
  73         * psympriv.h (add_psymbol_to_list): Move comment here and update
  74         it.
  75
  76 2019-09-29  Tom de Vries  <tdevries@suse.de>
  77
  78         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
  79         Use $tmpdir/$(basename "$output_file").dwz instead of
  80         "${output_file}.dwz".
  81
  82 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
  83
  84         PR gdb/25045
  85         * hppa-linux-nat.c: Include gdbarch.h.
  86
  87 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
  88
  89         * blockframe.c (find_pc_partial_function): Change return type to bool.
  90         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
  91         * minsyms.c (in_gnu_ifunc_stub): Likewise.
  92         (stub_gnu_ifunc_resolve_name): Likewise.
  93         * symtab.c (compare_filenames_for_search): Likewise.
  94         (compare_glob_filenames_for_search): Likewise.
  95         (matching_obj_sections): Likewise.
  96         (symbol_matches_domain): Likewise.
  97         (find_line_symtab): Change out param EXACT_MATCH to bool *.
  98         (find_line_pc): Change return type to bool.
  99         (find_line_pc_range): Likewise.
 100         (producer_is_realview): Likewise.
 101         * symtab.h (symbol_matches_domain): Likewise.
 102         (find_pc_partial_function): Likewise.
 103         (find_pc_line_pc_range): Likewise.
 104         (in_gnu_ifunc_stub): Likewise.
 105         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 106         (find_line_pc): Likewise.
 107         (find_line_pc_range): Likewise.
 108         (matching_obj_sections): Likewise.
 109         (find_line_symtab): Change out parameter to bool.
 110         (producer_is_realview): Change return type to bool.
 111         (compare_filenames_for_search): Likewise.
 112         (compare_glob_filenames_for_search): Likewise.
 113
 114 2019-09-26  Tom Tromey  <tom@tromey.com>
 115
 116         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 117         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 118         * gdb_usleep.h: Remove.
 119         * gdb_usleep.c: Remove.
 120         * utils.c: Don't include gdb_usleep.h.
 121
 122 2019-09-26  Tom Tromey  <tromey@adacore.com>
 123
 124         * python/py-type.c (type_to_type_object): Call check_typedef
 125         for stub types.
 126
 127 2019-09-26  Tom Tromey  <tom@tromey.com>
 128
 129         * utils.h (initialize_utils): Don't declare.
 130         * top.c (gdb_init): Don't call initialize_utils.
 131         * utils.c (initialize_utils): Remove.  Move contents...
 132         (_initialize_utils): ... here.
 133
 134 2019-09-25  Tom Tromey  <tom@tromey.com>
 135
 136         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 137         * utils.h (make_hex_string): Don't declare.
 138         * utils.c (make_hex_string): Remove.
 139
 140 2019-09-24  Tom de Vries  <tdevries@suse.de>
 141
 142         PR gdb/23815
 143         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 144         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 145
 146 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 147
 148         * NEWS: Mention new simulator port for PRU.
 149
 150 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 151
 152         * ada-exp.y (write_object_remaining): Update.
 153         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 154         and eliminate the static buffer.
 155         (ada_decode_symbol): Update.
 156         (ada_la_decode): Update.
 157         (ada_sniff_from_mangled_name): Update.
 158         (is_valid_name_for_wild_match): Update.
 159         (ada_lookup_name_info::matches): Update and simplify.
 160         (name_matches_regex): Update.
 161         (ada_add_global_exceptions): Update.
 162         * ada-lang.h (ada_decode): Update signature.
 163         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 164         * dwarf-index-write.c (debug_names::insert): Update.
 165
 166 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 167
 168         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 169         formatting.
 170
 171 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 172
 173         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 174         Change "nonzero" to "true" in documentation.
 175
 176 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 177
 178         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 179         (_initialize_darwin_solib): Don't set
 180         darwin_so_ops.lookup_lib_global_symbol.
 181         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 182         set_gdbarch_iterate_over_objfiles_in_search_order.
 183         (elf_lookup_lib_symbol): Rename to...
 184         (svr4_iterate_over_objfiles_in_search_order): this, and update
 185         to iterate semantics.
 186         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 187         * solib.c (solib_global_lookup): Remove.
 188         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 189         (solib_global_lookup): Remove.
 190         * symtab.c (lookup_global_or_static_symbol): Remove call to
 191         solib_global_lookup.
 192
 193 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 194
 195         * NEWS: Move entries about default MI version now being
 196         version 3, and about the GDB/MI fix for multi-location
 197         breakpoints to the "since GDB 8.3" section.
 198
 199 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 200
 201         GDB 8.3.1 released.
 202
 203 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 204
 205         * NEWS: Mention that Cell/B.E. debugging support was removed.
 206         * MAINTAINERS: Remove spu target.
 207
 208         * config/djgpp/fnchange.lst: Remove entries for removed files.
 209
 210         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 211         spu-multiarch.o, and spu-tdep.o.
 212         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 213         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 214         spu-multiarch.c, and spu-tdep.c.
 215         * spu-linux-nat.c: Remove file.
 216         * spu-multiarch.c: Remove file.
 217         * spu-tdep.c: Remove file.
 218         * spu-tdep.h: Remove file.
 219         * solib-spu.c: Remove file.
 220         * solib-spu.h: Remove file.
 221
 222         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 223         * configure.nat (spu-linux): Remove.
 224         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 225         solib-multiarch.o from gdb_target_obs.
 226         (spu*-*-*): Remove.
 227
 228         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 229         feature flag.
 230         (ppc_linux_no_features): Update.
 231         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 232         Cell/B.E. support.
 233         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 234         (tdesc_powerpc_cell64l): Likewise.
 235         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 236         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 237         Cell/B.E. support.
 238         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 239         Do not include "features/rs6000/powerpc-cell32l.c" or
 240         "features/rs6000/powerpc-cell64l.c".
 241         (ppc_linux_spu_section): Remove.
 242         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 243         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 244         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 245         (ppc_linux_spe_context_lookup): Remove.
 246         (ppc_linux_spe_context_inferior_created): Remove.
 247         (ppc_linux_spe_context_solib_loaded): Remove.
 248         (ppc_linux_spe_context_solib_unloaded): Remove.
 249         (ppc_linux_spe_context): Remove.
 250         (struct ppu2spu_cache): Remove.
 251         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 252         (struct ppu2spu_data): Remove.
 253         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 254         ppu2spu_unwind): Remove.
 255         (ppc_linux_init_abi): Remove Cell/B.E. support.
 256         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 257
 258         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 259         (rs6000/powerpc-cell64l-expedite): Likewise
 260         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 261         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 262         rs6000/powerpc-cell64l.xml.
 263         * features/rs6000/powerpc-cell32l.xml: Remove.
 264         * features/rs6000/powerpc-cell64l.xml: Likewise.
 265         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 266         * features/rs6000/powerpc-cell64l.c: Likewise.
 267         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 268         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 269         * regformats/reg-spu.dat: Remove.
 270
 271         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 272         * corelow.c (struct spuid_list): Remove.
 273         (add_to_spuid_list): Remove.
 274         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 275         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 276         (remote_protocol_features): Remove associated entries.
 277         (_initialize_remote): No longer initialize them.
 278         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 279         * linux-nat.c (SPUFS_MAGIC): Remove.
 280         (linux_proc_xfer_spu): Remove.
 281         (spu_enumerate_spu_ids): Remove.
 282         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 283         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 284         (linux_make_corefile_notes): No longer call it.
 285
 286         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 287         (cooked_write_test): Likewise.
 288
 289 2019-09-20  Tom Tromey  <tom@tromey.com>
 290
 291         * NEWS: Mention case-sensitivity of TUI commands.
 292         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 293         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 294         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 295
 296 2019-09-20  Tom Tromey  <tom@tromey.com>
 297
 298         * tui/tui-source.c (tui_source_window::set_contents): Use
 299         make_unique_xstrdup.
 300         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 301         make_unique_xstrdup.
 302
 303 2019-09-20  Tom Tromey  <tom@tromey.com>
 304
 305         * tui/tui-data.c: Remove separator comments.
 306         * tui/tui-layout.c: Remove separator comments.
 307         * tui/tui-win.c: Remove separator comments.
 308         * tui/tui-wingeneral.c: Remove separator comments.
 309
 310 2019-09-20  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui.h (strcat_to_buf): Don't declare.
 313         * tui/tui.c (strcat_to_buf): Remove.
 314
 315 2019-09-20  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 318         from "fullname".
 319         * tui/tui-source.c (tui_source_window::set_contents)
 320         (tui_source_window::location_matches_p)
 321         (tui_source_window::maybe_update): Update.
 322
 323 2019-09-20  Tom Tromey  <tom@tromey.com>
 324
 325         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 326         Update.
 327         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 328         prefix.
 329         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 330         (tui_data_window::line_from_reg_element_no)
 331         (tui_data_window::first_reg_element_no_inline)
 332         (tui_data_window::show_registers)
 333         (tui_data_window::show_register_group)
 334         (tui_data_window::display_registers_from)
 335         (tui_data_window::display_registers_from_line)
 336         (tui_data_window::first_data_item_displayed)
 337         (tui_data_window::delete_data_content_windows)
 338         (tui_data_window::erase_data_content)
 339         (tui_data_window::do_scroll_vertical)
 340         (tui_data_window::refresh_window)
 341         (tui_data_window::check_register_values): Update.
 342
 343 2019-09-20  Tom Tromey  <tom@tromey.com>
 344
 345         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 346         (struct tui_locator_window) <full_name, proc_name>: Now
 347         std::string.
 348         * tui/tui-stack.c (tui_locator_window::make_status_line)
 349         (tui_locator_window::set_locator_fullname)
 350         (tui_locator_window::set_locator_info): Update.
 351         * tui/tui-source.c (tui_source_window::set_contents)
 352         (tui_source_window::showing_source_p): Update.
 353
 354 2019-09-20  Tom Tromey  <tom@tromey.com>
 355
 356         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 357         Don't call tui_locator_win_info_ptr.
 358
 359 2019-09-20  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 362
 363 2019-09-20  Tom Tromey  <tom@tromey.com>
 364
 365         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 366         height for locator.
 367         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 368         * tui/tui-layout.c (show_source_disasm_command, show_data)
 369         (show_source_or_disasm_and_command): Use 1 as height for locator.
 370
 371 2019-09-20  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui.c (tui_enable): Update.
 374         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 375         Update.
 376         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 377         Update.
 378         * tui/tui-data.c (win_resized): Now bool.
 379         (tui_win_resized): Return bool.
 380         (tui_set_win_resized_to): Accept a bool.
 381
 382 2019-09-20  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 385         Change type of "refresh_values_only".
 386         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 387         type of "refresh_values_only".
 388
 389 2019-09-20  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 392         std::string.
 393         (tui_disassemble): Add "pos" parameter.
 394         (tui_disasm_window::set_contents): Simplify.
 395
 396 2019-09-20  Tom Tromey  <tom@tromey.com>
 397
 398         * tui/tui-winsource.h (struct tui_source_window_base)
 399         <show_source_content>: Now private.
 400         * tui/tui-winsource.c
 401         (tui_source_window_base::show_source_content): Don't handle empty
 402         content case.
 403
 404 2019-09-20  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui-layout.c (show_source_disasm_command)
 407         (show_source_or_disasm_and_command): Don't call
 408         show_source_content.
 409
 410 2019-09-20  Tom Tromey  <tom@tromey.com>
 411
 412         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 413         Declare.
 414         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 415         from tui_make_status_line.
 416         (tui_locator_window::rerender): Update.
 417
 418 2019-09-20  Tom Tromey  <tom@tromey.com>
 419
 420         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 421         (tui_locator_window::rerender): Update.
 422
 423 2019-09-20  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-winsource.h (struct tui_source_window_base)
 426         <~tui_source_window_base>: Don't declare.
 427         <fullname>: Remove.
 428         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 429         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 430         member.
 431         * tui/tui-source.c (tui_source_window::set_contents): Update.
 432         (tui_source_window::location_matches_p)
 433         (tui_source_window::maybe_update): Update.
 434
 435 2019-09-20  Tom Tromey  <tom@tromey.com>
 436
 437         * tui/tui-winsource.h (~tui_source_element): Remove.
 438         (tui_source_element): Update.
 439         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 440         * tui/tui-winsource.c (tui_show_source_line): Update.
 441         * tui/tui-source.c (tui_source_window::set_contents): Update.
 442         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 443
 444 2019-09-20  Tom Tromey  <tom@tromey.com>
 445
 446         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 447         declare.
 448         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 449         tui_clear_source_windows_detail.
 450         * tui/tui-winsource.h (struct tui_source_window_base)
 451         <clear_detail>: Don't declare.
 452         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 453         Remove.
 454         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 455
 456 2019-09-20  Tom Tromey  <tromey@adacore.com>
 457
 458         PR ada/24919:
 459         * block.c (contained_in): Fix final return value.
 460
 461 2019-09-20  Alan Modra  <amodra@gmail.com>
 462
 463         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 464         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 465         (read_indirect_string_from_dwz): Use bfd accessor.
 466         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 467         * machoread.c (macho_symfile_read_all_oso): Likewise.
 468         * solib.c (solib_bfd_open): Likewise.
 469
 470 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 471
 472         * eval.c: Move declaration of overload_resolution to...
 473         * value.h: ...here.
 474
 475 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 476
 477         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 478         * arm-linux-tdep.c: Likewise.
 479         * arm-nbsd-nat.c: Likewise.
 480         * arm-tdep.h: Declare arm_apcs_32.
 481         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 482
 483 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 484
 485         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 486         * dwarf2read.h: Declare dwarf_always_disassemble.
 487
 488 2019-09-19  Tom de Vries  <tdevries@suse.de>
 489
 490         PR gdb/25009
 491         * source-cache.c (source_cache::ensure): Catch exception thrown during
 492         construction of the highlighter.
 493
 494 2019-09-18  Alan Modra  <amodra@gmail.com>
 495
 496         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 497         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 498         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 499         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 500         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 501         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 502         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 503         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 504         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 505         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 506         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 507         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 508         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 509         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 510         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 511         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 512         * mi/mi-interp.c: Update throughout for bfd section macro and
 513         function changes.
 514         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 515         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 516
 517 2019-09-18  Tom Tromey  <tom@tromey.com>
 518
 519         * NEWS: Add entry.
 520         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 521         call rl_initialize.
 522         (tui_enable): Do not call rl_initialize.
 523
 524 2019-09-18  Christian Groessler  <chris@groessler.org>
 525
 526         * alpha-linux-nat.c: Include gdbarch.h.
 527
 528 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 529
 530         * ui-file.c: Include cli/cli-style.h.
 531         (term_cli_styling): Remove cli_styling declaration.
 532
 533 2019-09-18  Alan Modra  <amodra@gmail.com>
 534
 535         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 536         to bfd_asymbol_section.
 537
 538 2019-09-18  Alan Modra  <amodra@gmail.com>
 539
 540         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 541         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 542         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 543
 544 2019-09-18  Alan Modra  <amodra@gmail.com>
 545
 546         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 547         * spu-linux-nat.c (spu_bfd_open): Likewise.
 548
 549 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 550
 551         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 552         to bool to match definition in dwarf2read.c.
 553
 554 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 555
 556         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 557         (print_signatures): Likewise.
 558         (trust_pad_over_xvs): Likewise.
 559         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 560         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 561         * arm-linux-nat.c (arm_apcs_32): Likewise.
 562         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 563         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 564         * arm-tdep.c (arm_debug): Likewise.
 565         (arm_apcs_32): Likewise.
 566         * auto-load.c (debug_auto_load): Likewise.
 567         (auto_load_gdb_scripts): Likewise.
 568         (global_auto_load): Likewise.
 569         (auto_load_local_gdbinit): Likewise.
 570         (auto_load_local_gdbinit_loaded): Likewise.
 571         * auto-load.h (global_auto_load): Likewise.
 572         (auto_load_local_gdbinit): Likewise.
 573         (auto_load_local_gdbinit_loaded): Likewise.
 574         * breakpoint.c (disconnected_dprintf): Likewise.
 575         (breakpoint_proceeded): Likewise.
 576         (automatic_hardware_breakpoints): Likewise.
 577         (always_inserted_mode): Likewise.
 578         (target_exact_watchpoints): Likewise.
 579         (_initialize_breakpoint): Update.
 580         * breakpoint.h (target_exact_watchpoints): Change to bool.
 581         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 582         * cli/cli-cmds.c (trace_commands): Likewise.
 583         * cli/cli-cmds.h (trace_commands): Likewise.
 584         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 585         to bool*.
 586         * cli/cli-logging.c (logging_overwrite): Change to bool.
 587         (logging_redirect): Likewise.
 588         (debug_redirect): Likewise.
 589         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 590         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 591         to bool.
 592         <boolean_option_def>: Update.
 593         (struct flag_option_def): Change default type of Context to bool
 594         from int.
 595         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 596         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 597         (get_setshow_command_value_string): Likewise.
 598         * cli/cli-style.c (cli_styling): Change to bool.
 599         (source_styling): Likewise.
 600         * cli/cli-style.h (source_styling): Likewise.
 601         (cli_styling): Likewise.
 602         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 603         to bool.
 604         * command.h (var_types): Update comment.
 605         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 606         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 607         bool.
 608         (debug_compile_cplus_scopes): Likewise.
 609         * compile/compile-internal.h (compile_debug): Likewise.
 610         * compile/compile.c (compile_debug): Likewise.
 611         (struct compile_options) <raw>: Likewise.
 612         * cp-support.c (catch_demangler_crashes): Likewise.
 613         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 614         (usr_cmd_cris_dwarf2_cfi): Likewise.
 615         * csky-tdep.c (csky_debug): Likewise.
 616         * darwin-nat.c (enable_mach_exceptions): Likewise.
 617         * dcache.c (dcache_enabled_p): Likewise.
 618         * defs.h (info_verbose): Likewise.
 619         * demangle.c (demangle): Likewise.
 620         (asm_demangle): Likewise.
 621         * dwarf-index-cache.c (debug_index_cache): Likewise.
 622         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 623         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 624         * dwarf2read.c (check_physname): Likewise.
 625         (use_deprecated_index_sections): Likewise.
 626         (dwarf_always_disassemble): Likewise.
 627         * eval.c (overload_resolution): Likewise.
 628         * event-top.c (set_editing_cmd_var): Likewise.
 629         (exec_done_display_p): Likewise.
 630         * event-top.h (set_editing_cmd_var): Likewise.
 631         (exec_done_display_p): Likewise.
 632         * exec.c (write_files): Likewise.
 633         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 634         (debug_fbsd_nat): Likewise.
 635         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 636         Likewise.
 637         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 638         <backtrace_past_entry> Likewise.
 639         * gdb-demangle.h (demangle): Likewise.
 640         (asm_demangle): Likewise.
 641         * gdb_bfd.c (bfd_sharing): Likewise.
 642         * gdbcore.h (write_files): Likewise.
 643         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 644         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 645         * gdbthread.h (print_thread_events): Likewise.
 646         * gdbtypes.c (opaque_type_resolution): Likewise.
 647         (strict_type_checking): Likewise.
 648         * gnu-nat.c (gnu_debug_flag): Likewise.
 649         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 650         * guile/scm-param.c (pascm_variable): Add boolval.
 651         (add_setshow_generic): Update.
 652         (pascm_param_value): Update.
 653         (pascm_set_param_value_x): Update.
 654         * hppa-tdep.c (hppa_debug): Change to bool..
 655         * infcall.c (may_call_functions_p): Likewise.
 656         (coerce_float_to_double_p): Likewise.
 657         (unwind_on_signal_p): Likewise.
 658         (unwind_on_terminating_exception_p): Likewise.
 659         * infcmd.c (startup_with_shell): Likewise.
 660         * inferior.c (print_inferior_events): Likewise.
 661         * inferior.h (startup_with_shell): Likewise.
 662         (print_inferior_events): Likewise.
 663         * infrun.c (step_stop_if_no_debug): Likewise.
 664         (detach_fork): Likewise.
 665         (debug_displaced): Likewise.
 666         (disable_randomization): Likewise.
 667         (non_stop): Likewise.
 668         (non_stop_1): Likewise.
 669         (observer_mode): Likewise.
 670         (observer_mode_1): Likewise.
 671         (set_observer_mode): Update.
 672         (sched_multi): Change to bool.
 673         * infrun.h (debug_displaced): Likewise.
 674         (sched_multi): Likewise.
 675         (step_stop_if_no_debug): Likewise.
 676         (non_stop): Likewise.
 677         (disable_randomization): Likewise.
 678         * linux-tdep.c (use_coredump_filter): Likewise.
 679         (dump_excluded_mappings): Likewise.
 680         * linux-thread-db.c (auto_load_thread_db): Likewise.
 681         (check_thread_db_on_load): Likewise.
 682         * main.c (captured_main_1): Update.
 683         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 684         xx2_opt, boolean_opt>: Change to bool.
 685         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 686         * maint.c (maintenance_profile_p): Likewise.
 687         (per_command_time): Likewise.
 688         (per_command_space): Likewise.
 689         (per_command_symtab): Likewise.
 690         * memattr.c (inaccessible_by_default): Likewise.
 691         * mi/mi-main.c (mi_async): Likewise.
 692         (mi_async_1): Likewise.
 693         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 694         * nat/fork-inferior.h (startup_with_shell): Likewise.
 695         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 696         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 697         * nios2-tdep.c (nios2_debug): Likewise.
 698         * or1k-tdep.c (or1k_debug): Likewise.
 699         * parse.c (parser_debug): Likewise.
 700         * parser-defs.h (parser_debug): Likewise.
 701         * printcmd.c (print_symbol_filename): Likewise.
 702         * proc-api.c (procfs_trace): Likewise.
 703         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 704         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 705         (set_parameter_value): Update.
 706         (add_setshow_generic): Update.
 707         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 708         to bool*.
 709         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 710         int*.
 711         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 712         * record-btrace.c (record_btrace_target::store_registers): Update.
 713         * record-full.c (record_full_memory_query): Change to bool.
 714         (record_full_stop_at_limit): Likewise.
 715         * record-full.h (record_full_memory_query): Likewise.
 716         * remote-notif.c (notif_debug): Likewise.
 717         * remote-notif.h (notif_debug): Likewise.
 718         * remote.c (use_range_stepping): Likewise.
 719         (interrupt_on_connect): Likewise.
 720         (remote_break): Likewise.
 721         * ser-tcp.c (tcp_auto_retry): Likewise.
 722         * ser-unix.c (serial_hwflow): Likewise.
 723         * skip.c (debug_skip): Likewise.
 724         * solib-aix.c (solib_aix_debug): Likewise.
 725         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 726         (spu_auto_flush_cache_p): Likewise.
 727         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 728         Likewise.
 729         (struct info_print_options) <quiet>: Likewise.
 730         * symfile-debug.c (debug_symfile): Likewise.
 731         * symfile.c (auto_solib_add): Likewise.
 732         (separate_debug_file_debug): Likewise.
 733         * symfile.h (auto_solib_add): Likewise.
 734         (separate_debug_file_debug): Likewise.
 735         * symtab.c (basenames_may_differ): Likewise.
 736         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 737         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 738         (struct info_types_options) <quiet>: Likewise.
 739         * symtab.h (demangle): Likewise.
 740         (basenames_may_differ): Likewise.
 741         * target-dcache.c (stack_cache_enabled_1): Likewise.
 742         (code_cache_enabled_1): Likewise.
 743         * target.c (trust_readonly): Likewise.
 744         (may_write_registers): Likewise.
 745         (may_write_memory): Likewise.
 746         (may_insert_breakpoints): Likewise.
 747         (may_insert_tracepoints): Likewise.
 748         (may_insert_fast_tracepoints): Likewise.
 749         (may_stop): Likewise.
 750         (auto_connect_native_target): Likewise.
 751         (target_stop_and_wait): Update.
 752         (target_async_permitted): Change to bool.
 753         (target_async_permitted_1): Likewise.
 754         (may_write_registers_1): Likewise.
 755         (may_write_memory_1): Likewise.
 756         (may_insert_breakpoints_1): Likewise.
 757         (may_insert_tracepoints_1): Likewise.
 758         (may_insert_fast_tracepoints_1): Likewise.
 759         (may_stop_1): Likewise.
 760         * target.h (target_async_permitted): Likewise.
 761         (may_write_registers): Likewise.
 762         (may_write_memory): Likewise.
 763         (may_insert_breakpoints): Likewise.
 764         (may_insert_tracepoints): Likewise.
 765         (may_insert_fast_tracepoints): Likewise.
 766         (may_stop): Likewise.
 767         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 768         (make_thread_apply_all_options_def_group): Change argument from int*
 769         to bool*.
 770         (thread_apply_all_command): Update.
 771         (print_thread_events): Change to bool.
 772         * top.c (confirm): Likewise.
 773         (command_editing_p): Likewise.
 774         (history_expansion_p): Likewise.
 775         (write_history_p): Likewise.
 776         (info_verbose): Likewise.
 777         * top.h (confirm): Likewise.
 778         (history_expansion_p): Likewise.
 779         * tracepoint.c (disconnected_tracing): Likewise.
 780         (circular_trace_buffer): Likewise.
 781         * typeprint.c (print_methods): Likewise.
 782         (print_typedefs): Likewise.
 783         * utils.c (debug_timestamp): Likewise.
 784         (sevenbit_strings): Likewise.
 785         (pagination_enabled): Likewise.
 786         * utils.h (sevenbit_strings): Likewise.
 787         (pagination_enabled): Likewise.
 788         * valops.c (overload_resolution): Likewise.
 789         * valprint.h (struct value_print_options) <prettyformat_arrays,
 790         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 791         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 792         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 793         Likewise.
 794         * windows-nat.c (new_console): Likewise.
 795         (cygwin_exceptions): Likewise.
 796         (new_group): Likewise.
 797         (debug_exec): Likewise.
 798         (debug_events): Likewise.
 799         (debug_memory): Likewise.
 800         (debug_exceptions): Likewise.
 801         (useshell): Likewise.
 802         * windows-tdep.c (maint_display_all_tib): Likewise.
 803         * xml-support.c (debug_xml): Likewise.
 804
 805 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 806
 807         * source.c (prepare_path_for_appending): New function.
 808         (openp): Make use of new function.
 809         (find_and_open_source): Search for the compilation directory and
 810         source file as a relative path beneath the directory search path.
 811
 812 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 813
 814         * source-cache.c (source_cache::get_line_charpos): Catch
 815         exceptions and return false, this matches the behaviour documented
 816         in the header file.
 817
 818 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 819
 820         * ada-tasks.c (info_task): Remove quoting of the task's name.
 821
 822 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 823
 824         * symfile.c (auto_solib_add): Replace comment with a reference
 825         to the header file.
 826
 827 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 828
 829         * NEWS: Mention that gdb can now be compiled with Python 3
 830         on Windows.
 831
 832 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 833
 834         * maint.c (maint_print_section_data::maint_print_section_data):
 835         Force use of 'float log10 (float)' by casting the argument to
 836         float.
 837
 838 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 839
 840         * maint.c: Add 'cmath' include.
 841         (struct maint_print_section_data): New structure.
 842         (print_section_index): New function.
 843         (print_bfd_section_info): Add header comment, small whitespace
 844         cleanup, and update to call new print_section_index function.
 845         (print_objfile_section_info): Likewise.
 846         (maint_obj_section_from_bfd_section): New function.
 847         (print_bfd_section_info_maybe_relocated): New function.
 848         (maintenance_info_sections): Add header comment, always use
 849         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 850
 851 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 852
 853         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 854         inner scope, add check that the objfile has psymtabs before
 855         checking psymtabs_addrmap.
 856         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 857
 858 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 859
 860         * NEWS: Announce that Ada task names are now shown at more places,
 861         and between quotes (except in info task output).
 862         * gdb/ada-tasks.c (task_to_str): New function.
 863         (display_current_task_id): Call task_to_str.
 864         (task_command_1): Likewise.
 865         (print_ada_task_info): In non-mi mode, Properly align headers and data
 866         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 867
 868 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 869
 870         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 871         prstatus.pr_lwp.pr_info instead of making it up.
 872
 873 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 874
 875         * auto-load.c (auto_load_expand_dir_vars): Update.
 876         * defs.h (gdb_datadir): Change to std::string.
 877         (python_libdir): Likewise.
 878         (relocate_gdb_directory): Change return type to std::string.
 879         * guile/guile.c (gdbscm_data_directory): Update.
 880         (initialize_scheme_side): Update.
 881         * jit.c (jit_reader_dir): Change to std::string.
 882         (jit_reader_load_command): Update.
 883         * main.c (gdb_datadir): Change to std::string.
 884         (python_libdir): Likewise.
 885         (set_gdb_data_directory): Update.
 886         (relocate_path): Change to return std::string.
 887         (relocate_gdb_directory): Change to return std::string.
 888         (relocate_gdbinit_path_maybe_in_datadir): Update.
 889         (captured_main_1): Update.
 890         * python/python.c (do_start_initialization): Update.
 891         * top.c (show_gdb_datadir): Update.
 892         * xml-syscall.c (xml_init_syscalls_info): Update.
 893         (init_syscalls_info): Update.
 894
 895 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 896
 897         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 898         out of get_init_files.
 899         (get_init_files): Update.
 900
 901 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 902
 903         * main.c (get_init_files): Change to use std::string.
 904         (captured_main_1): Update.
 905         (print_gdb_help): Update.
 906
 907 2019-09-11  Ali Tamur  <tamur@google.com>
 908
 909         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 910         implementation.
 911
 912 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 913
 914         * dbxread.c (read_dbx_symtab): Update.
 915         * dwarf2read.c (load_partial_dies): Update.
 916         * mdebugread.c (parse_partial_symbols): Update.
 917         (handle_psymbol_enumerators): Update.
 918         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 919         * psymtab.c (add_psymbol_to_bcache): Likewise.
 920         (add_psymbol_to_list): Likewise.
 921         * symtab.c (symbol_set_names): Likewise.
 922         * symtab.h (symbol_set_names): Likewise.
 923         * xcoffread.c (scan_xcoff_symtab): Update.
 924
 925 2019-09-11  Tom Tromey  <tom@tromey.com>
 926
 927         * symfile-mem.c (symbol_file_add_from_memory): Use
 928         bfd_set_filename.
 929         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 930         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 931
 932 2019-09-10  Tom Tromey  <tromey@adacore.com>
 933
 934         * dwarf-index-write.c (write_psymbols): Extend error message.
 935         (debug_names::insert): Add Ada code.
 936         (debug_names::write_psymbols): Remove Ada check.
 937         (debug_names) <m_string_obstack>: New member.
 938         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 939         (gdb_index_symbol_name_matcher::matches): Remove.
 940         (mapped_index_base::find_name_components_bounds): Add "lang"
 941         parameter.
 942         (mapped_index_base::build_name_components): Also split names
 943         according to Ada syntax.
 944         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 945         type of "match_callback".
 946         (check_match, check_find_bounds_finds)
 947         (dw2_expand_symtabs_matching): Update.
 948         (dw2_debug_names_iterator): Add new constructor.
 949         (dw2_debug_names_map_matching_symbols): New function.
 950         (dw2_debug_names_expand_symtabs_matching): Update.
 951         (dwarf2_debug_names_functions): Use
 952         dw2_debug_names_map_matching_symbols.
 953
 954 2019-09-10  Tom Tromey  <tromey@adacore.com>
 955
 956         * dwarf2read.c (dw2_get_file_names_reader): Add the
 957         CU's file name to the results.
 958
 959 2019-09-10  Tom Tromey  <tromey@adacore.com>
 960
 961         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 962         map_matching_symbols.  Update.
 963         * dwarf2read.c (dw2_map_matching_symbols): Update.
 964         * psymtab.c (match_partial_symbol): Change type; update.
 965         (psym_map_matching_symbols): Likewise.
 966         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 967         type; update.
 968         * symfile.h (struct quick_symbol_functions)
 969         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 970         Remove "match".
 971
 972 2019-09-10  Tom Tromey  <tromey@adacore.com>
 973
 974         * psymtab.c (map_block): Remove.
 975         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 976         * symtab.c (iterate_over_symbols_terminated): New function.
 977         * symtab.c (iterate_over_symbols_terminated): Declare.
 978
 979 2019-09-10  Tom Tromey  <tromey@adacore.com>
 980
 981         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 982         * language.h (struct language_defn) <la_iterate_over_symbols>:
 983         Return bool.
 984         * symtab.c (iterate_over_symbols): Return bool.
 985         * symtab.h (iterate_over_symbols): Return bool.
 986
 987 2019-09-10  Tom Tromey  <tromey@adacore.com>
 988
 989         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 990         (add_nonlocal_symbols): Update.
 991         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 992         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 993         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 994         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 995         Change type of "callback".  Remove "data".
 996
 997
 998 2019-09-09  Ali Tamur  <tamur@google.com>
 999
1000         * dwarf2read.c (comp_unit_head): Update comment.
1001         (dwarf2_dwo_name): New function declaration.
1002         (dwarf_unit_type_name): New function declaration.
1003         (read_comp_unit_head): Add support for new compilation units,
1004         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1005         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1006         (currently named as "signature") in their header. Also clarify error
1007         messages.
1008         (lookup_dwo_id): New function. Returns the dwo id of the given
1009         compile unit.
1010         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1011         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1012         functions.
1013         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1014         (dwarf2_dwo_name): Get the dwo name if present.
1015         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1016         purposes.
1017
1018 2019-09-09  Tom Tromey  <tom@tromey.com>
1019
1020         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1021
1022 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1023
1024         * python/python.c (do_start_initialization): Make progname_copy static,
1025         to avoid a leak report.
1026
1027 2019-09-08  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1030
1031 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1032
1033         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1034         Change type to gdb::optional<block_enum>.
1035         (dw2_symtab_iter_init): Change block_index parameter type
1036         to gdb::optional<block_enum>.
1037         (dw2_lookup_symbol): Change block_index parameter
1038         type to block_enum.c
1039         (dw2_debug_names_lookup_symbol): Likewise.
1040         * psymtab.c (psym_lookup_symbol): Likewise.
1041         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1042         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1043         Likewise.
1044
1045 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1046
1047         * defs.h (relocate_gdb_directory): Change int to bool in
1048         signature and rename flag to relocatable.
1049         * main.c (relocate_path): Likewise.
1050         (relocate_gdb_directory): Likewise.
1051
1052 2019-09-06  Alan Modra  <amodra@gmail.com>
1053
1054         * coffread.c (coff_symfile_read): Constify filename variable.
1055         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1056         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1057         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1058         * solib.c (reload_shared_libraries_1): Likewise.
1059         * symfile.c (reread_symbols): Likewise.
1060         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1061         * solib-darwin.c (darwin_bfd_open): Likewise.
1062         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1063
1064 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1067         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1068
1069 2019-09-03  Tom Tromey  <tromey@adacore.com>
1070
1071         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1072         types.
1073         (has_negatives): Unbias a range type bound.
1074         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1075         * gdbtypes.c (operator==): Handle new field.
1076         (create_range_type): Add "bias" parameter.
1077         (create_static_range_type, resolve_dynamic_range): Update.
1078         * gdbtypes.h (struct range_bounds) <bias>: New member.
1079         (create_range_type): Add bias parameter.
1080         * printcmd.c (print_scalar_formatted): Unbias range types.
1081         * value.c (unpack_long): Unbias range types.
1082         (pack_long): Bias range types.
1083
1084 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1085
1086         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1087         probe arguments.
1088
1089 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1090
1091         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1092         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1093         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1094         (compile_probe_arg): Likewise.
1095         * probe.h (get_argument_count): Likewise.
1096         * solib-svr4.c (solib_event_probe_action): Likewise.
1097         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1098
1099 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1100
1101         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1102         code to here...
1103         (svr4_create_solib_event_breakpoints): ...from here.
1104
1105 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1106
1107         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1108         suffix from warning message.
1109
1110 2019-08-30  Tom Tromey  <tom@tromey.com>
1111
1112         * tui/tui-winsource.h (struct tui_source_window_base)
1113         <refresh_all>: Don't declare.
1114         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1115         Remove.
1116         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1117         tui_show_locator_content.
1118         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1119         declare.
1120         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1121         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1122         declare.
1123
1124 2019-08-30  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1127
1128 2019-08-30  Tom Tromey  <tom@tromey.com>
1129
1130         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1131         Remove unnecessary forward declarations.
1132
1133 2019-08-30  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1136         rerender.
1137         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1138         tui_show_locator_content.
1139
1140 2019-08-30  Tom Tromey  <tom@tromey.com>
1141
1142         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1143         (tui_locator_window::rerender): Rewrite using body of previous
1144         tui_show_locator_content.
1145
1146 2019-08-30  Tom Tromey  <tom@tromey.com>
1147
1148         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1149         set_locator_fullname>: New methods.
1150         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1151         Rename from tui_set_locator_fullname.
1152         (tui_locator_window::set_locator_info): Rename from
1153         tui_set_locator_info.  Return bool.
1154         (tui_update_locator_fullname, tui_show_frame_info): Update.
1155
1156 2019-08-30  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1159
1160 2019-08-30  Tom Tromey  <tom@tromey.com>
1161
1162         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1163         call touchwin.
1164
1165 2019-08-30  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-wingeneral.c (box_win): Assume win_info and
1168         win_info->handle cannot be NULL.
1169
1170 2019-08-30  Tom Tromey  <tom@tromey.com>
1171
1172         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1173         refresh_window>: Declare.
1174         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1175         resize.
1176         (tui_data_item_window::rerender): Rename from
1177         tui_display_register.
1178         (tui_data_item_window::refresh_window): New method.
1179         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1180         no-op.
1181
1182 2019-08-30  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1185         regs_column_count, current_group>: Move later.  Now private.
1186         <get_current_group>: New method.
1187         * tui/tui-regs.c (tui_reg_command): Update.
1188         * tui/tui-layout.c (tui_set_layout): Update.
1189
1190 2019-08-30  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1193         (tui_data_window::rerender): Don't call
1194         check_and_display_highlight_if_needed.
1195         (tui_data_window::refresh_all): Remove call to
1196         erase_data_content.
1197
1198 2019-08-30  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1201         (tui_data_window::display_registers_from)
1202         (tui_data_window::display_reg_element_at_line)
1203         (tui_data_window::display_registers_from_line): Remove checks of
1204         "empty".
1205
1206 2019-08-30  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1209         Don't declare.
1210         * tui/tui-regs.c (tui_data_window::show_registers): Call
1211         rerender.
1212         (tui_data_window::rerender): Rename from display_all_data.
1213         (tui_data_window::rerender): Remove old implementation.
1214
1215 2019-08-30  Tom Tromey  <tom@tromey.com>
1216
1217         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1218         text.
1219         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1220
1221 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1222             Sergio Durigan Junior  <sergiodj@redhat.com>
1223
1224         PR win32/24284
1225         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1226
1227 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1228
1229         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1230         when searching for types.
1231
1232 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1233
1234         * f-lang.c (f_language_defn): Use f_print_typedef.
1235         * f-lang.h (f_print_typedef): Declare.
1236         * f-typeprint.c (f_print_typedef): Define.
1237
1238 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1239
1240         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1241
1242 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * cli/cli-utils.c (info_print_options_defs): Delete.
1245         (make_info_print_options_def_group): Delete.
1246         (extract_info_print_options): Delete.
1247         (info_print_command_completer): Delete.
1248         (info_print_args_help): Add extra parameter, and optionally
1249         include text about -n flag.
1250         * cli/cli-utils.h (struct info_print_options): Delete.
1251         (extract_info_print_options): Delete declaration.
1252         (info_print_command_completer): Delete declaration.
1253         (info_print_args_help): Add extra parameter, extend header
1254         comment.
1255         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1256         search_symbols.
1257         * stack.c (struct info_print_options): New type.
1258         (info_print_options_defs): New file scoped variable.
1259         (make_info_print_options_def_group): New static function.
1260         (info_print_command_completer): New static function.
1261         (info_locals_command): Update to use new local functions.
1262         (info_args_command): Likewise.
1263         (_initialize_stack): Add extra parameter to calls to
1264         info_print_args_help.
1265         * symtab.c (search_symbols): Add extra parameter, use this to
1266         possibly excluse non-debug symbols.
1267         (symtab_symbol_info): Add extra parameter, which is passed on to
1268         search_symbols.
1269         (struct info_print_options): New type.
1270         (info_print_options_defs): New file scoped variable.
1271         (make_info_print_options_def_group): New static function.
1272         (info_print_command_completer): New static function.
1273         (info_variables_command): Update to use local functions, and pass
1274         extra parameter through to symtab_symbol_info.
1275         (info_functions_command): Likewise.
1276         (info_types_command): Pass additional argument through to
1277         symtab_symbol_info.
1278         (rbreak_command): Pass extra argument to search_symbols.
1279         (_initialize_symtab): Add extra arguments for calls to
1280         info_print_args_help, and update help text for 'info variables',
1281         'whereis', and 'info functions' commands.
1282         * symtab.h (search_symbols): Add extra argument to declaration.
1283         * NEWS: Mention new flags.
1284
1285 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1286
1287         * symtab.c (lookup_static_symbol): Call the new function (and move
1288         it down to be next to lookup_global_symbol).
1289         (struct global_sym_lookup_data): Add block_enum member and rename to...
1290         (struct global_or_static_sym_lookup_data): ...this.
1291         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1292         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1293         (lookup_symbol_global_or_static_iterator_cb): ...this.
1294         (lookup_global_or_static_symbol): New function.
1295         (lookup_global_symbol): Call new function.
1296
1297 2019-08-26  Tom de Vries  <tdevries@suse.de>
1298
1299         PR c++/24852
1300         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1301         when pc_probe.prob == NULL.
1302
1303 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1304
1305         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1306         variable symbol_linkage to symbol_linkage_.
1307
1308 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1309
1310         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1311         represent whether the symbol is static, dynamic, or we don't
1312         know.
1313
1314 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1315
1316         * gdb/rx-tdep.c (rx_register_names): New.
1317         (rx_register_name): Delete.
1318         (rx_psw_type): Delete.
1319         (rx_fpsw_type): Delete.
1320         (rx_register_type): Delete.
1321         (rx_gdbarch_init): Convert target-descriptions.
1322         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1323         * gdb/features/Makefile: Add rx.xml.
1324         * gdb/features/rx.xml: New.
1325         * gdb/features/rx.c: Generated.
1326         * gdb/NEWS: Mention target description support.
1327
1328 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1329
1330         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1331         *slot_ptr.
1332
1333 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1334
1335         * configure.ac: Don't check for 'dlfcn.h' (moved to
1336         gdbsupport/common.m4).
1337         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1338         'gdbsupport/'.
1339         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1340         * compile/compile-c-support.c: Include
1341         'gdbsupport/gdb-dlfcn.h'.
1342         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1343         * gdb-dlfcn.c: Move to...
1344         * gdbsupport/gdb-dlfcn.c: ... here.
1345         * gdb-dlfcn.h: Move to...
1346         * gdbsupport/gdb-dlfcn.h: ... here.
1347
1348 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1349
1350         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1351         the offset field signed.
1352
1353 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1354
1355         * python/lib/gdb/__init__.py (_execute_file): New function.
1356         * python/python.c (python_run_simple_file): Call gdb._execute_file
1357         on Windows.
1358
1359 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1360
1361         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1362         all uses as this was never set to anything but a zero value.
1363
1364 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1365
1366         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1367
1368 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1369
1370         * tui/tui-data.h (tui_gen_win_info): Add an =default
1371         move constructor, required by some GCC versions.
1372
1373 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1374
1375         * go32-nat.c (go32_sysinfo): Add hygon_p.
1376
1377 2019-08-20  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1380         line_from_reg_element_no, first_reg_element_no_inline,
1381         display_all_data, delete_data_content_windows,
1382         erase_data_content>: Now private.
1383
1384 2019-08-20  Tom Tromey  <tom@tromey.com>
1385
1386         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1387         (tui_unhighlight_win, tui_highlight_win)
1388         (tui_win_info::make_window): Update.
1389         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1390
1391 2019-08-20  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1394         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1395         (MAX_PID_WIDTH): Move to tui-stack.c.
1396         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1397         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1398         (MAX_PID_WIDTH): Move from tui-data.h.
1399
1400 2019-08-20  Tom Tromey  <tom@tromey.com>
1401
1402         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1403         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1404         (box_win): Update.
1405         (tui_gen_win_info::make_window): Rename from tui_make_window.
1406         (tui_win_info::make_window): New method.
1407         (tui_gen_win_info::make_visible): Update.
1408         * tui/tui-source.c (tui_source_window::set_contents): Update.
1409         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1410         (tui_data_window::display_registers_from): Update.
1411         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1412         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1413         Declare.
1414         <can_box>: Remove.
1415         <title>: Remove.
1416         (struct tui_win_info) <make_window>: Declare.
1417         <can_box>: Now virtual.
1418         <title>: New member.
1419         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1420         * tui/tui-command.c (tui_cmd_window::resize): Update.
1421
1422 2019-08-20  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1425         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1426         (tui_data_window::check_register_values): Update.
1427
1428 2019-08-20  Tom Tromey  <tom@tromey.com>
1429
1430         * tui/tui-regs.h (struct tui_data_window): Use
1431         DISABLE_COPY_AND_ASSIGN.
1432         <regs_content>: Change type, removing unique_ptr.
1433         <tui_data_window>: Add move constructor.
1434         * tui/tui-regs.c (tui_data_window::show_registers)
1435         (tui_data_window::show_register_group)
1436         (tui_data_window::display_registers_from)
1437         (tui_data_window::display_registers_from)
1438         (tui_data_window::first_data_item_displayed)
1439         (tui_data_window::delete_data_content_windows)
1440         (tui_data_window::rerender, tui_data_window::refresh_window)
1441         (tui_data_window::check_register_values): Update.
1442
1443 2019-08-20  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1446         show_register_group>: Declare.
1447         (tui_show_register_group): Don't declare.
1448         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1449         tui_show_registers.
1450         (tui_data_window::show_register_group): Rename from
1451         tui_show_register_group.
1452         (tui_data_window::check_register_values, tui_reg_command):
1453         Update.
1454         * tui/tui-layout.c (tui_set_layout): Update.
1455
1456 2019-08-20  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1459         Declare.
1460         (tui_check_register_values): Don't declare.
1461         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1462         from tui_check_register_values.
1463         * tui/tui-hooks.c (tui_register_changed): Update.
1464
1465 2019-08-20  Tom Tromey  <tom@tromey.com>
1466
1467         * tui/tui-regs.c (tui_reg_layout): Move later.
1468         (tui_show_registers): Don't enable TUI mode or change layout.
1469
1470 2019-08-20  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-regs.h (struct tui_data_item_window)
1473         <~tui_data_item_window>: Remove.
1474         <content>: Now a unique_xmalloc_ptr.
1475         * tui/tui-regs.c (tui_register_format): Return a
1476         unique_xmalloc_ptr.
1477         (tui_get_register): Update.
1478         (~tui_data_item_window): Remove.
1479         (tui_data_window::display_registers_from, tui_display_register):
1480         Update.
1481         * tui/tui-io.h (tui_expand_tabs): Update.
1482         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1483         Remove "col" parameter.
1484
1485 2019-08-20  Tom Tromey  <tom@tromey.com>
1486
1487         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1488         field.
1489         * tui/tui-regs.c (~tui_data_item_window): Update.
1490
1491 2019-08-20  Tom Tromey  <tom@tromey.com>
1492
1493         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1494         earlier.
1495
1496 2019-08-20  Tom Tromey  <tom@tromey.com>
1497
1498         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1499
1500 2019-08-20  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-source.h (struct tui_source_window): Update.
1503         * tui/tui-regs.c (tui_show_registers): Update.
1504         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1505         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1506         (NO_REGS_STRING): Remove defines.
1507
1508 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1509
1510         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1511         unnecessary thread walk if remote doesn't support the packet.
1512
1513 2019-08-19  Tom Tromey  <tromey@adacore.com>
1514
1515         * python/py-value.c (value_has_field): Fix indentation.
1516
1517 2019-08-19  Tom Tromey  <tromey@adacore.com>
1518
1519         * printcmd.c (do_one_display, info_display_command): Update.
1520         * block.h (contained_in): Return bool.  Add allow_nested
1521         parameter.
1522         * block.c (contained_in): Return bool.  Add allow_nested
1523         parameter.
1524
1525 2019-08-19  Tom Tromey  <tom@tromey.com>
1526
1527         * configure: Rebuild.
1528         * configure.ac: Disallow the combination of -static-libstdc++ and
1529         source highlight.
1530         * source-cache.c (get_language_name): Handle rust.
1531         (source_cache::get_source_lines): Ignore highlighting exceptions.
1532
1533 2019-08-16  Tom Tromey  <tom@tromey.com>
1534
1535         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1536         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1537         (struct tui_source_window_base) <make_visible, refresh_window,
1538         resize>: Remove methods.
1539         <execution_info>: Remove field.
1540         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1541         (tui_show_source_line, tui_source_window_base)
1542         (~tui_source_window_base): Update.
1543         (tui_source_window_base::resize)
1544         (tui_source_window_base::make_visible)
1545         (tui_source_window_base::refresh_window): Remove.
1546         (tui_source_window_base::update_exec_info): Update.
1547         * tui/tui-source.c (tui_source_window::set_contents): Update.
1548         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1549
1550 2019-08-16  Tom Tromey  <tom@tromey.com>
1551
1552         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1553         deprecated_query_hook.
1554
1555 2019-08-16  Tom Tromey  <tom@tromey.com>
1556
1557         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1558         (tui_update_source_windows_with_line): Update.
1559         * tui/tui-source.h (struct tui_source_window)
1560         <show_symtab_source>: Declare.
1561         (tui_show_symtab_source): Don't declare.
1562         * tui/tui-source.c (tui_show_symtab_source): Rename from
1563         tui_show_symtab_source.
1564
1565 2019-08-16  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-winsource.h (struct tui_source_window_base)
1568         <set_contents>: Declare.
1569         * tui/tui-winsource.c
1570         (tui_source_window_base::update_source_window_as_is): Update.
1571         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1572         Declare.
1573         (tui_set_source_content): Don't declare.
1574         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1575         tui_set_source_content.
1576         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1577         Declare.
1578         (tui_set_disassem_content): Don't declare.
1579         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1580         tui_set_disassem_content.
1581
1582 2019-08-16  Tom Tromey  <tom@tromey.com>
1583
1584         * tui/tui-winsource.h (struct tui_source_window_base)
1585         <update_breakpoint_info>: Declare.
1586         (tui_update_breakpoint_info): Don't declare.
1587         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1588         (tui_update_all_breakpoint_info): Update.
1589         (tui_source_window_base::update_breakpoint_info): Rename from
1590         tui_update_breakpoint_info.
1591         (tui_source_window_base::update_exec_info): Update.
1592
1593 2019-08-16  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-winsource.h (struct tui_source_window_base)
1596         <update_source_window>: Declare.
1597         (tui_update_source_window): Don't declare.
1598         * tui/tui-winsource.c
1599         (tui_source_window_base::update_source_window): Rename from
1600         tui_update_source_window.
1601         (tui_source_window_base::rerender): Update.
1602         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1603         * tui/tui-disasm.c (tui_show_disassem)
1604         (tui_show_disassem_and_update_source)
1605         (tui_disasm_window::maybe_update): Update.
1606
1607 2019-08-16  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-winsource.h (struct tui_source_window_base)
1610         <update_source_window_as_is>: Declare.
1611         (tui_update_source_window_as_is): Don't declare.
1612         * tui/tui-winsource.c (tui_update_source_window): Update
1613         (tui_source_window_base::update_source_window_as_is): Rename from
1614         tui_update_source_window_as_is.
1615         (tui_source_window_base::refill): Update.
1616         * tui/tui-source.c (tui_show_symtab_source): Update.
1617         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1618         Update.
1619
1620 2019-08-16  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-winsource.h (tui_update_source_window)
1623         (tui_update_source_window_as_is): Remove "noerror" parameter.
1624         * tui/tui-winsource.c (tui_update_source_window)
1625         (tui_update_source_window_as_is): Remove "noerror" parameter.
1626         (tui_update_source_windows_with_addr)
1627         (tui_update_source_windows_with_line)
1628         (tui_source_window_base::rerender)
1629         (tui_source_window_base::refill): Update.
1630         * tui/tui-source.h (tui_set_source_content)
1631         (tui_show_symtab_source): Remove "noerror" parameter.
1632         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1633         parameter.
1634         (tui_show_symtab_source): Likewise.
1635         (tui_source_window::maybe_update): Update.
1636         * tui/tui-disasm.c (tui_show_disassem)
1637         (tui_show_disassem_and_update_source)
1638         (tui_disasm_window::do_scroll_vertical)
1639         (tui_disasm_window::maybe_update): Update.
1640
1641 2019-08-16  Tom Tromey  <tom@tromey.com>
1642
1643         * tui/tui.c (tui_is_window_visible): Update.
1644         * tui/tui-wingeneral.c (tui_make_window)
1645         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1646         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1647         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1648         (tui_set_win_height_command, parse_scrolling_args): Update.
1649         * tui/tui-source.c (tui_source_window::style_changed): Update.
1650         * tui/tui-regs.c (tui_show_registers)
1651         (tui_data_window::first_data_item_displayed)
1652         (tui_data_window::delete_data_content_windows)
1653         (tui_check_register_values, tui_reg_command): Update.
1654         * tui/tui-disasm.c (tui_show_disassem): Update.
1655         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1656         method.
1657         <is_visible>: Remove field.
1658         * tui/tui-data.c (tui_next_win, tui_prev_win)
1659         (tui_delete_invisible_windows): Update.
1660
1661 2019-08-16  Tom Tromey  <tom@tromey.com>
1662
1663         * tui/tui-winsource.h (struct tui_source_window_base)
1664         <m_has_locator>: Remove.
1665         * tui/tui-layout.c (show_source_disasm_command, show_data)
1666         (show_source_or_disasm_and_command): Update.
1667
1668 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1669
1670         * NEWS (Other MI changes): New subsection.
1671         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1672         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1673         * arch-utils.c (default_get_pc_address_flags): New function.
1674         * arch-utils.h (default_get_pc_address_flags): New declaration.
1675         * gdbarch.sh: Add get_pc_address_flags.
1676         * gdbarch.c: Regenerate.
1677         * gdbarch.h: Likewise.
1678         * stack.c (print_pc): New function.
1679         (print_frame_info) (print_frame): Call print_pc.
1680
1681 2019-08-16  Tom de Vries  <tdevries@suse.de>
1682
1683         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1684         print_objfile_section_info.
1685
1686 2019-08-15  Tom Tromey  <tom@tromey.com>
1687
1688         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1689         calling update_cmdwin_start_line.
1690         * tui/tui-winsource.h (struct tui_source_window_base)
1691         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1692         <rerender>: Declare.
1693         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1694         Call rerender.
1695         (tui_source_window_base::set_new_height): Remove.
1696         (tui_source_window_base::rerender): Rename from
1697         do_make_visible_with_new_height.
1698         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1699         resize method.
1700         (tui_win_info::make_invisible_and_set_new_height)
1701         (tui_win_info::make_visible_with_new_height): Remove.
1702         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1703         Declare.
1704         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1705         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1706         do_make_visible_with_new_height>: Don't declare.
1707         <rerender>: Declare.
1708         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1709         set_new_height.
1710         (tui_data_window::do_make_visible_with_new_height): Remove.
1711         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1712         call tui_show_locator_content.
1713         (tui_gen_win_info::resize): Call rerender.
1714         (show_source_or_disasm_and_command): Don't call
1715         tui_show_locator_content.
1716         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1717         method.
1718         (struct tui_win_info) <rerender>: Declare.
1719         <set_new_height, make_invisible_and_set_new_height,
1720         make_visible_with_new_height>: Don't declare.
1721         * tui/tui-data.c (tui_win_list::rerender): New method.
1722         * tui/tui-command.h (struct tui_cmd_window)
1723         <do_make_visible_with_new_height>: Don't declare.
1724         * tui/tui-command.c
1725         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1726
1727 2019-08-15  Tom Tromey  <tromey@adacore.com>
1728
1729         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1730         * ada-lang.c (ada_enum_name): Likewise.
1731
1732 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1733
1734         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1735         leading underscore.
1736         (GdbOutputErrorFile): Likewise.
1737         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1738         accordingly.
1739         (execute_unwinders): Rename to have a leading underscore.
1740         (auto_load_packages): Likewise.
1741         (global scope): Adjust call to auto_load_packages accordingly.
1742         (GdbSetPythonDirectory): Likewise.
1743         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1744         instead of execute_unwinders.
1745
1746 2019-08-15  Tom Tromey  <tom@tromey.com>
1747
1748         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1749         (show_data): Don't change window visibility.
1750         (tui_gen_win_info::resize): Remove special case for command
1751         window.  Use wresize, when available.
1752         (show_source_or_disasm_and_command): Don't change window
1753         visibility.
1754         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1755         <make_visible>: New method.
1756         * tui/tui-command.c (tui_cmd_window::resize): New method.
1757
1758 2019-08-15  Tom Tromey  <tom@tromey.com>
1759
1760         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1761         (struct tui_source_windows): New.
1762         * tui/tui-winsource.c (tui_display_main): Update.
1763         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1764         (new_height_ok, parse_scrolling_args): Update.
1765         * tui/tui-layout.c (show_layout, show_data): Update.
1766         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1767         (tui_add_to_source_windows): Don't declare.
1768         * tui/tui-data.c (source_windows, tui_source_windows)
1769         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1770
1771 2019-08-15  Tom Tromey  <tom@tromey.com>
1772
1773         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1774         Rename from reset.
1775         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1776         * tui/tui-layout.c (show_source_disasm_command, show_data):
1777         Update.
1778         (tui_gen_win_info::resize): Rename.
1779         (show_source_or_disasm_and_command): Update.
1780         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1781         reset.
1782
1783 2019-08-15  Tom Tromey  <tom@tromey.com>
1784
1785         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1786         * tui/tui-interp.c (tui_interp::init): Don't call
1787         tui_initialize_static_data.
1788         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1789
1790 2019-08-15  Tom Tromey  <tom@tromey.com>
1791
1792         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1793         examine tui_win_list.
1794
1795 2019-08-15  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1798         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1799         tui_clear_source_content.
1800         (tui_clear_source_content): Remove.
1801         (tui_source_window_base::do_erase_source_content): Hoist call to
1802         content.clear().
1803         * tui/tui-stack.c (tui_show_frame_info): Don't call
1804         tui_clear_source_content.
1805
1806 2019-08-15  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-winsource.h (struct tui_source_window_base)
1809         <do_erase_source_content>: New method.
1810         <erase_source_content>: New method.
1811         (tui_erase_source_content): Don't declare.
1812         * tui/tui-winsource.c (tui_clear_source_content): Update.
1813         (tui_source_window_base::do_erase_source_content): Rename from
1814         tui_erase_source_content.
1815         (tui_source_window_base::show_source_content): Update.
1816         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1817         * tui/tui-source.h (struct tui_source_window)
1818         <erase_source_content>: New method.
1819         * tui/tui-disasm.h (struct tui_disasm_window)
1820         <erase_source_content>: New method.
1821
1822 2019-08-15  Tom Tromey  <tom@tromey.com>
1823
1824         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1825         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1826         constructor.
1827         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1828         * tui/tui-source.c (tui_set_source_content): Update.
1829         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1830
1831 2019-08-15  Tom Tromey  <tom@tromey.com>
1832
1833         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1834         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1835         tui-source.c.
1836         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1837         Declare.
1838         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1839         method.
1840         (tui_source_window::maybe_update): Update.
1841
1842 2019-08-15  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1845         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1846         tui-disasm.c.
1847         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1848         Declare.
1849         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1850         method.
1851         (tui_disasm_window::maybe_update): Update.
1852
1853 2019-08-15  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-winsource.h (struct tui_source_window_base)
1856         <maybe_update>: Declare.
1857         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1858         method.
1859         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1860         Declare.
1861         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1862         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1863         Declare.
1864         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1865
1866 2019-08-15  Tom Tromey  <tom@tromey.com>
1867
1868         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1869
1870 2019-08-15  Tom Tromey  <tom@tromey.com>
1871
1872         * tui/tui-wingeneral.c: Include tui-stack.h.
1873         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1874         (struct tui_locator_window): Move from tui-data.h.
1875         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1876         (tui_initialize_static_data): Move from tui-data.c.
1877         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1878         (struct tui_locator_window): Move to tui-stack.c.
1879         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1880         (tui_initialize_static_data): Move to tui-stack.c.
1881
1882 2019-08-15  Tom Tromey  <tom@tromey.com>
1883
1884         * tui/tui-layout.c (show_source_disasm_command)
1885         (show_source_or_disasm_and_command): Use make_visible method, not
1886         tui_make_window.
1887         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1888         Remove.
1889
1890 2019-08-15  Tom Tromey  <tom@tromey.com>
1891
1892         * tui/tui-wingeneral.h (tui_make_window): Update.
1893         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1894         parameter.
1895         (tui_gen_win_info::make_visible): Update.
1896         * tui/tui-regs.c (tui_data_window::display_registers_from):
1897         Update.
1898         * tui/tui-layout.c (show_source_disasm_command)
1899         (show_source_or_disasm_and_command): Update.
1900         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1901         (enum tui_box): Remove.
1902         (struct tui_win_info) <can_box>: New method.
1903         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1904         method.
1905
1906 2019-08-15  Tom de Vries  <tdevries@suse.de>
1907
1908         * linux-nat-trad.c: Include gdbarch.h.
1909
1910 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1911
1912         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1913         register sizes.
1914
1915 2019-08-14  Tom Tromey  <tromey@adacore.com>
1916
1917         * darwin-nat.c: Include gdbarch.h.
1918         * darwin-nat-info.c: Include gdbarch.h.
1919
1920 2019-08-13  Tom Tromey  <tom@tromey.com>
1921
1922         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1923         Remove.
1924         * tui/tui-data.c (tui_initialize_static_data): Update.
1925
1926 2019-08-13  Tom Tromey  <tom@tromey.com>
1927
1928         * tui/tui-winsource.h (struct tui_exec_info_window)
1929         <~tui_exec_info_window, maybe_allocate_content, get_content,
1930         m_content>: Remove.
1931         (struct tui_source_window_base) <set_exec_info_content,
1932         show_exec_info_content>: Don't declare.
1933         * tui/tui-winsource.c
1934         (tui_exec_info_window::maybe_allocate_content): Remove.
1935         (tui_source_window_base::update_exec_info): Rename from
1936         set_exec_info_content.
1937         (tui_source_window_base::show_exec_info_content)
1938         (tui_source_window_base::update_exec_info): Remove.
1939
1940 2019-08-13  Tom Tromey  <tom@tromey.com>
1941
1942         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1943         declare.
1944         * tui/tui-winsource.c (tui_update_source_window_as_is)
1945         (tui_update_source_windows_with_addr, tui_erase_source_content):
1946         Update.
1947         (tui_clear_exec_info_content): Remove.
1948
1949 2019-08-13  Tom Tromey  <tom@tromey.com>
1950
1951         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1952         declare.
1953         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1954         call tui_erase_exec_info_content.
1955         (tui_clear_exec_info_content): Rename from
1956         tui_erase_exec_info_content.
1957         (tui_clear_exec_info_content): Delete.
1958
1959 2019-08-13  Tom Tromey  <tom@tromey.com>
1960
1961         * tui/tui-winsource.h (struct tui_source_window_base)
1962         <show_exec_info_content>: Declare.
1963         (tui_show_exec_info_content): Don't declare.
1964         * tui/tui-winsource.c
1965         (tui_source_window_base::show_exec_info_content): Rename from
1966         tui_show_exec_info_content.
1967         (tui_source_window_base::update_exec_info): Update.
1968
1969 2019-08-13  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1972         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1973         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1974         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1975         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1976         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1977         ... here.
1978
1979 2019-08-13  Tom Tromey  <tom@tromey.com>
1980
1981         * tui/tui-winsource.h (struct tui_source_window_base)
1982         <update_exec_info>: Declare.
1983         (tui_update_exec_info): Don't declare.
1984         * tui/tui-winsource.c (tui_update_source_window_as_is)
1985         (tui_source_window_base::refresh_all)
1986         (tui_update_all_breakpoint_info): Update.
1987         (tui_source_window_base::update_exec_info): Rename from
1988         tui_update_exec_info.
1989         * tui/tui-stack.c (tui_show_frame_info): Update.
1990
1991 2019-08-13  Tom Tromey  <tom@tromey.com>
1992
1993         * tui/tui-winsource.h (struct tui_source_window_base)
1994         <set_exec_info_content>: Declare.
1995         (tui_set_exec_info_content): Don't declare.
1996         * tui/tui-winsource.c
1997         (tui_source_window_base::set_exec_info_content): Rename from
1998         tui_set_exec_info_content.
1999         (tui_update_exec_info): Update.
2000
2001 2019-08-13  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-winsource.h (struct tui_source_window_base)
2004         <show_source_content>: Declare.
2005         (tui_show_source_content): Don't declare.
2006         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2007         (tui_source_window_base::show_source_content): Rename from
2008         tui_show_source_content.
2009         (tui_source_window_base::refresh_all): Update.
2010         * tui/tui-layout.c (show_source_disasm_command)
2011         (show_source_or_disasm_and_command): Update.
2012
2013 2019-08-13  Tom Tromey  <tom@tromey.com>
2014
2015         * tui/tui-winsource.c (tui_erase_source_content)
2016         (tui_show_source_content, tui_source_window_base::refresh_all):
2017         Update.
2018         * tui/tui-wingeneral.h
2019         (tui_check_and_display_highlight_if_needed): Don't declare.
2020         * tui/tui-wingeneral.c
2021         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2022         check_and_display_highlight_if_needed.
2023         * tui/tui-win.c (tui_rehighlight_all)
2024         (tui_win_info::make_visible_with_new_height): Update.
2025         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2026         (tui_data_window::erase_data_content)
2027         (tui_data_window::display_all_data): Update.
2028         * tui/tui-data.h (struct tui_win_info)
2029         <check_and_display_highlight_if_needed>: Declare.
2030
2031 2019-08-13  Tom Tromey  <tom@tromey.com>
2032
2033         * tui/tui-win.c (tui_resize_all): Call
2034         tui_delete_invisible_windows.
2035         * tui/tui-layout.c (show_layout): Call
2036         tui_delete_invisible_windows.
2037         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2038         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2039
2040 2019-08-13  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2043         tui_add_win_to_layout.
2044
2045 2019-08-13  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2048         * tui/tui-layout.c (tui_default_win_height): Now static.
2049
2050 2019-08-13  Tom Tromey  <tom@tromey.com>
2051
2052         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2053         single switch.
2054         (show_source_disasm_command, show_source_or_disasm_and_command):
2055         Don't check current layout.
2056
2057 2019-08-13  Tom Tromey  <tom@tromey.com>
2058
2059         * tui/tui-wingeneral.c (make_all_visible): Remove.
2060         (tui_make_all_invisible): Simplify.
2061         * tui/tui-layout.c (tui_make_all_invisible): Move from
2062         tui-wingeneral.c; simplify.
2063         (show_layout): Hoist call to tui_make_all_invisible.
2064         (show_data): Don't call tui_make_all_invisible.
2065
2066 2019-08-13  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2069         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2070
2071 2019-08-13  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2074         tui-data.c.
2075         (show_source_disasm_command, show_data)
2076         (show_source_or_disasm_and_command): Don't use
2077         tui_set_current_layout_to.
2078         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2079         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2080         tui-layout.c.
2081         (tui_set_current_layout_to): Remove.
2082
2083 2019-08-13  Tom Tromey  <tom@tromey.com>
2084
2085         * tui/tui-layout.c (tui_set_layout): Update.
2086         * tui/tui-data.h (struct tui_layout_def): Remove.
2087         (tui_layout_def): Don't declare.
2088         * tui/tui-data.c (layout_def): Remove.
2089         (tui_layout_def): Remove.
2090
2091 2019-08-13  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-winsource.h (struct tui_source_window_base)
2094         <clear_detail>: No longer "override".
2095         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2096         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2097         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2098         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2099         Remove.
2100         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2101
2102 2019-08-13  Tom Tromey  <tromey@adacore.com>
2103
2104         * tracepoint.c: Don't include readline.h or history.h.
2105
2106 2019-08-12  Tom Tromey  <tom@tromey.com>
2107
2108         * configure: Rebuild.
2109         * configure.ac: Check for readline 7.
2110         * NEWS: Mention readline 7 requirement.
2111         * README: Update.
2112
2113 2019-08-12  Tom Tromey  <tom@tromey.com>
2114
2115         * mingw-hdep.c (gdb_select): Remove readline hack.
2116
2117 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2118
2119         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2120         when the function fails.
2121
2122 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2123
2124         * s390-tdep.c (s390_type_align): New function.
2125         (s390_gdbarch_init): Set it as type_align gdbarch method.
2126
2127 2019-08-09  Tom de Vries  <tdevries@suse.de>
2128
2129         PR gdb/24591
2130         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2131         pc_low with relocation offset.
2132
2133 2019-08-07  Tom Tromey  <tromey@adacore.com>
2134
2135         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2136         (print_frame_args): Update.
2137         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2138         Update.
2139         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2140         * frame.h (struct frame_arg): Add initializers.
2141         <error>: Now a unique_xmalloc_ptr.
2142
2143 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2144
2145         * NEWS: Expand the Pointer Authentication entry.
2146         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2147         (aarch64_frame_unmask_lr): ... to this.
2148         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2149         Call aarch64_frame_unmask_lr.
2150         * frame.c (struct frame_info): Add "masked" variable.
2151         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2152         (fprint_frame): Check for masked pc.
2153         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2154         declarations.
2155         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2156         * stack.c (print_frame): Check for masked pc.
2157
2158 2019-08-06  Tom Tromey  <tom@tromey.com>
2159
2160         * stabsread.c (patch_block_stabs, read_one_struct_field)
2161         (read_enum_type): Use obstack_strndup.
2162         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2163         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2164         * dwarf2read.c (guess_full_die_structure_name)
2165         (anonymous_struct_prefix): Use obstack_strndup.
2166         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2167         * c-exp.y (yylex): Use obstack_strndup.
2168         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2169         (write_var_or_type): Use obstack_strndup.
2170
2171 2019-08-06  Tom Tromey  <tom@tromey.com>
2172
2173         * symfile.c (reread_symbols): Use obstack_strdup.
2174         * stabsread.c (read_type): Use obstack_strdup.
2175         * gdb_obstack.h (obstack_strdup): New overload.
2176         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2177         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2178         (dwarf2_canonicalize_name): Use obstack_strdup.
2179         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2180         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2181         Use obstack_strdup.
2182
2183 2019-08-06  Tom Tromey  <tom@tromey.com>
2184
2185         * gdb_obstack.h (obstack_strdup): Define.
2186         * gdb_obstack.c (obstack_strdup): Don't define.
2187
2188 2019-08-06  Tom Tromey  <tom@tromey.com>
2189
2190         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2191         obstack_strdup.
2192         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2193         obstack_strdup.
2194         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2195         * stabsread.c (common_block_start): Use obstack_strdup.
2196         * objfiles.c (set_objfile_main_name, objfile): Use
2197         obstack_strdup.
2198         * namespace.c (add_using_directive): Use obstack_strdup.
2199         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2200         * jit.c (finalize_symtab): Use obstack_strdup.
2201         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2202         (guess_partial_die_structure_name, partial_die_info::fixup)
2203         (dwarf2_name): Use obstack_strdup.
2204         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2205         obstack_strdup.
2206         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2207         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2208         obstack_strdup.
2209         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2210
2211 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2212
2213         * unittests/help-doc-selftests.c: New file.
2214         * Makefile.in: Add the new file.
2215
2216 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2217
2218         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2219         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2220         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2221         the trailing '.' is not output, and the first character is uppercased.
2222         (print_help_for_command): Update call to print_doc_line.
2223         (print_doc_of_command): Likewise.
2224         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2225         * cli/cli-option.c (append_indented_doc): Do not append newline.
2226         (build_help_option): Append newline after first appended_indented_doc
2227         only if a second call is done.
2228         (build_help): Append 2 new lines before each option, except the first
2229         one.
2230         * compile/compile.c (_initialize_compile): Add new lines after
2231         %OPTIONS%, when not at the end of the help.
2232         Change help doc or code
2233         producing the help doc to respect the invariants.
2234         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2235         Also removed the new line after 'Options:', as all other commands
2236         do not put an empty line between 'Options:' and the first option.
2237         * printcmd.c (_initialize_printcmd): Likewise.
2238         * stack.c (_initialize_stack): Likewise.
2239         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2240         incorrectly telling COMMAND is optional.
2241         * ada-lang.c (_initialize_ada_language): Change help doc or code
2242         producing the help doc to respect the invariants.
2243         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2244         * breakpoint.c (_initialize_breakpoint): Likewise.
2245         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2246         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2247         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2248         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2249         _initialize_cli_style): Likewise.
2250         * corelow.c (core_target_info): Likewise.
2251         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2252         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2253         * filesystem.c (_initialize_filesystem): Likewise.
2254         * frame.c (_initialize_frame): Likewise.
2255         * gnu-nat.c (add_task_commands): Likewise.
2256         * infcall.c (_initialize_infcall): Likewise.
2257         * infcmd.c (_initialize_infcmd): Likewise.
2258         * interps.c (_initialize_interpreter): Likewise.
2259         * language.c (_initialize_language): Likewise.
2260         * linux-fork.c (_initialize_linux_fork): Likewise.
2261         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2262         * maint.c (_initialize_maint_cmds): Likewise.
2263         * memattr.c (_initialize_mem): Likewise.
2264         * printcmd.c (_initialize_printcmd): Likewise.
2265         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2266         _RegEx): Likewise.
2267         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2268         * record-btrace.c (_initialize_record_btrace): Likewise.
2269         * record-full.c (_initialize_record_full): Likewise.
2270         * record.c (_initialize_record): Likewise.
2271         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2272         * regcache.c (_initialize_regcache): Likewise.
2273         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2274         _initialize_remote): Likewise.
2275         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2276         * serial.c (_initialize_serial): Likewise.
2277         * skip.c (_initialize_step_skip): Likewise.
2278         * source.c (_initialize_source): Likewise.
2279         * stack.c (_initialize_stack): Likewise.
2280         * symfile.c (_initialize_symfile): Likewise.
2281         * symtab.c (_initialize_symtab): Likewise.
2282         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2283         * top.c (init_main): Likewise.
2284         * tracefile-tfile.c (tfile_target_info): Likewise.
2285         * tracepoint.c (_initialize_tracepoint): Likewise.
2286         * tui/tui-win.c (_initialize_tui_win): Likewise.
2287         * utils.c (add_internal_problem_command): Likewise.
2288         * valprint.c (value_print_option_defs): Likewise.
2289
2290 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2291
2292         PR build/24886
2293         * configure.ac: Drop enable-libmcheck support.
2294         * configure, config.in: Rebuild.
2295         * libmcheck.m4: Remove.
2296         * acinclude.m4: Don't include it.
2297         * Makefile.in: Don't distribute it.
2298         * top.c (print_gdb_configuration): Don't mention it.
2299
2300 2019-08-06  Tom Tromey  <tom@tromey.com>
2301
2302         * utils.c (set_output_style): Sometimes pass stream to
2303         emit_style_escape.
2304         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2305         * record-btrace.c (btrace_insn_history): Update.
2306         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2307         method.
2308         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2309         Update initializers.
2310         <m_uiout>: New field.
2311         <m_di>: Move lower.
2312         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2313         Remove "uiout" parameter.
2314         (dump_insns): Update.
2315         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2316         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2317
2318 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2319
2320         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2321         (error_in_psymtab_expansion): Likewise.
2322         (lookup_symbol_via_quick_fns): Likewise.
2323         (basic_lookup_transparent_type_quick): Likewise.
2324         (basic_lookup_transparent_type_1): Likewise.
2325
2326 2019-08-06  Tom Tromey  <tromey@adacore.com>
2327
2328         * source.c (last_source_error): Now bool.
2329         (print_source_lines_base): Make "noprint" bool.  Only open
2330         source file when last_source_visited changes.
2331
2332 2019-08-06  Tom Tromey  <tromey@adacore.com>
2333
2334         * annotate.c (annotate_source_line): Use g_source_cache.
2335         * source-cache.c (source_cache::get_plain_source_lines): Change
2336         parameters.  Populate m_offset_cache.
2337         (source_cache::ensure): New method.
2338         (source_cache::get_line_charpos): New method.
2339         (extract_lines): Move lower.  Change parameters.
2340         (source_cache::get_source_lines): Move lower.
2341         * source-cache.h (class source_cache): Update comment.
2342         <get_line_charpos>: New method.
2343         <get_source_lines>: Update comment.
2344         <clear>: Clear m_offset_cache.
2345         <get_plain_source_lines>: Change parameters.
2346         <ensure>: New method
2347         <m_offset_cache>: New member.
2348         * source.c (forget_cached_source_info_for_objfile): Update.
2349         (info_source_command): Use g_source_cache.
2350         (find_source_lines, open_source_file_with_line_charpos): Remove.
2351         (print_source_lines_base, search_command_helper): Use g_source_cache.
2352         * source.h (open_source_file_with_line_charpos): Don't declare.
2353         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2354         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2355         Use g_source_cache.
2356
2357 2019-08-06  Tom Tromey  <tromey@adacore.com>
2358
2359         * source-cache.c (source_cache::get_plain_source_lines):
2360         Remove "first_line" and "last_line" parameters.
2361         (source_cache::get_source_lines): Cache plain text.
2362         * source-cache.h (class source_cache)
2363         <get_plain_source_lines>: Update.
2364
2365 2019-08-06  Tom Tromey  <tromey@adacore.com>
2366
2367         * source-cache.c (extract_lines): No longer a method.
2368         Changed type of parameter.  Include final newline.
2369         (selftests::extract_lines_test): New function.
2370         (_initialize_source_cache): Likewise.
2371         * source-cache.h (class source_cache)
2372         <extract_lines>: Don't declare.
2373
2374 2019-08-06  Tom Tromey  <tromey@adacore.com>
2375
2376         * breakpoint.c (init_breakpoint_sal): Update.
2377         (breakpoint): Update.
2378         * breakpoint.h (struct breakpoint) <filter>: Now a
2379         unique_xmalloc_ptr.
2380
2381 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2382
2383         * NEWS: Mention dictionary access on blocks.
2384         * python/py-block.c (blpy_getitem): New function.
2385         (block_object_as_mapping): New struct.
2386         (block_object_type): Use new struct for tp_as_mapping field.
2387
2388 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2389
2390         * objfiles.h (objfile): Add a comment describing partial symbols.
2391
2392 2019-08-05  Tom Tromey  <tromey@adacore.com>
2393
2394         * compile/compile.c (_initialize_compile): Use _(), not N_().
2395         * thread.c (_initialize_thread): Use _(), not N_().
2396         * stack.c (_initialize_stack): Use _(), not N_().
2397         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2398
2399 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2400
2401         * dwarf2read.c (struct dw2_symtab_iterator):
2402         <want_specific_block>: Remove.
2403         <block_index>: Change type to gdb::optional.
2404         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2405         change type of BLOCK_INDEX parameter to gdb::optional.
2406         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2407         (dw2_lookup_symbol): Don't pass argument for
2408         WANT_SPECIFIC_BLOCK.
2409         (dw2_expand_symtabs_for_function): Don't pass argument for
2410         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2411         (class dw2_debug_names_iterator)
2412         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2413         parameter, change BLOCK_INDEX type to gdb::optional.
2414         <m_want_specific_block>: Remove.
2415         <m_block_index>: Change type to gdb::optional.
2416         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2417         gdb::optional.  Re-write in function of gdb::optional.
2418         (dw2_debug_names_lookup_symbol): Don't pass argument for
2419         WANT_SPECIFIC_BLOCK.
2420         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2421         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2422         BLOCK_INDEX.
2423
2424 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2425
2426         * NEWS: Mention changes to "info sources" command.
2427
2428 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2429
2430         * symtab.c (filename_partial_match_opts): New struct type.
2431         (struct output_source_filename_data): New members
2432         regexp, c_regexp, partial_match.
2433         (output_source_filename): Use new members to decide to print file.
2434         (info_sources_option_defs): New variable.
2435         (make_info_sources_options_def_group, print_info_sources_header,
2436         info_sources_command_completer):
2437         New functions.
2438         (info_sources_command): Read new optional arguments.
2439         (_initialize_symtab): Update info sources help.
2440
2441 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2442
2443         * ada-lang.c (exception_support_info_v0): Renamed from...
2444         (default_exception_support_info): ... this.  Create new
2445         definition for v1.
2446         (ada_has_this_exception_support): Look up catch_handlers_sym.
2447         (ada_exception_support_info_sniffer): Try v0 after default.
2448
2449 2019-08-01  Tom Tromey  <tromey@adacore.com>
2450
2451         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2452         gdbarch.h.
2453
2454 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2455
2456         * s12z-tdep.c: Fix include path for s12z-opc.h.
2457
2458 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2459
2460         * NEWS: Require GNU make 3.82.
2461
2462 2019-07-16  Tom Tromey  <tom@tromey.com>
2463
2464         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2465         declare.
2466
2467 2019-07-30  Tom Tromey  <tromey@adacore.com>
2468
2469         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2470
2471 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2472
2473         * printcmd.c (print_address_symbolic): Print negative offsets.
2474         (build_address_symbolic): Force signed arithmetic when computing
2475         offset.
2476
2477 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2478
2479         PR/24474: Add a function to lookup static variables.
2480         * NEWS: Mention this new function.
2481         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2482         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2483         * python/python.c (python_GdbMethods): Add new function.
2484
2485 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2486
2487         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2488         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2489         (objfpy_lookup_static_symbol): New function.
2490         (objfile_object_methods): Add new functions.
2491
2492 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2493
2494         * NEWS: Mention 'set|show print frame-info'.  Mention new
2495         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2496         backtrace argument.  Mention that python frame filtering code
2497         is now consistent with what 'backtrace' command prints.
2498
2499 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2500
2501         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2502         comments.
2503         (print_frame_info_auto, print_frame_info_source_line,
2504         print_frame_info_location, print_frame_info_source_and_location,
2505         print_frame_info_location_and_address, print_frame_info_short_location):
2506         New declarations.
2507         (struct frame_print_options): New member print_frame_info.
2508         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2509         * stack.h (get_user_print_what_frame_info): New declaration.
2510         (frame_show_address): New declaration.
2511         * stack.c (print_frame_arguments_choices): New value 'presence'.
2512         (print_frame_info_auto, print_frame_info_source_line,
2513         print_frame_info_location, print_frame_info_source_and_location,
2514         print_frame_info_location_and_address, print_frame_info_short_location,
2515         print_frame_info_choices, print_frame_info_print_what): New definitions.
2516         (print_frame_args): Only print dots for args if print frame-arguments
2517         is 'presence'.
2518         (frame_print_option_defs): New element for "frame-info".
2519         (get_user_print_what_frame_info): New function.
2520         (frame_show_address): Make non static.  Move comment to stack.h.
2521         (print_frame_info_to_print_what): New function.
2522         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2523         to decide what to print.
2524         (backtrace_command_1): Handle the new print_frame_arguments_presence
2525         value.
2526         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2527         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2528         (py_print_frame): In non-mi mode, use LOCATION as default for
2529         print_what, similarly to frame information printed directly by
2530         backtrace command. Handle frame-info user option in non MI mode.
2531
2532 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2533
2534         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2535         Add case for debugging 32-bit target on 64-bit host.  Revise
2536         comment.
2537
2538 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2539
2540         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2541         instead of find_function_entry_range_from_pc.
2542
2543 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2544
2545         * stack.c (find_frame_funname): Remove code which preferred
2546         minsym over symtab sym in "certain pathological cases".
2547
2548         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2549         parameter.  Change type of "do_demangle" to bool.
2550         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2551         Pass suitable "prefer_sym_over_minsym" flag to
2552         build_address_symbolic().  Don't output "+" for negative offsets.
2553         * printcmd.c (print_address_symbolic): Update invocation of
2554         build_address_symbolic to include a "prefer_sym_over_minsym"
2555         flag.
2556         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2557         Restrict cases in which use of minimal symbol is preferred to that
2558         of a found symbol.  Update comments.
2559
2560         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2561         for entry pc when entry pc is out of range for that FDE.
2562
2563 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2564
2565         PR gdb/24839:
2566         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2567         type.
2568
2569 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2570
2571         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2572         this function's Python signature.
2573
2574
2575 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2576
2577         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2578         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2579         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2580         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2581         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2582
2583
2584 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2585
2586         * h8300-tdep.c (h8300_register_name_common): New.
2587         h8300_register_name): Use h8300_register_name_common.
2588         (h8300s_register_name): Likewise.
2589         (h8300sx_register_name): Likewise.
2590         (h8300h_register_nam): New.
2591         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2592
2593
2594 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2595
2596         * arm-tdep.c (arm_skip_cmse_entry): New function.
2597         (arm_is_sgstubs_section): New function.
2598         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2599
2600 2019-07-22  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2603         Don't self-assign.
2604
2605 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2606
2607         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2608         type_print.
2609
2610 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2611
2612         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2613         so that GDB doesn't match any msymbols when searching in the
2614         TYPES_DOMAIN.
2615         (print_symbol_info): Print using typedef_print or type_print based
2616         on the type of the symbol.  Add updated FIXME comment moved from...
2617         (_initialize_symtab): ... move and update FIXME comment to above.
2618
2619 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * NEWS: Mention adding -q option to "info types".
2622         * symtab.c (struct info_types_options): New struct.
2623         (info_types_options_defs): New variable.
2624         (make_info_types_options_def_group): New function.
2625         (info_types_command): Use gdb::option framework to parse options.
2626         (info_types_command_completer): New function.
2627         (_initialize_symtab): Extend the help text on "info types" and
2628         register command completer.
2629
2630 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2631
2632         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2633         (lookup_symbol_in_objfile): Change int to block_enum and add a
2634         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2635
2636 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2637
2638         * MAINTAINERS (Write After Approval): Add self.
2639
2640 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2641
2642         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2643         instruction to the dummy code region.
2644
2645 2019-07-19  Tom Tromey  <tromey@adacore.com>
2646
2647         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2648         (ARGSUSED, PARAMS, __func__): Remove rules.
2649
2650 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2651
2652         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2653         * features/arm/arm-with-iwmmxt.c: Remove.
2654         * features/arm/arm-with-iwmmxt.xml: Remove.
2655         * features/arm/arm-with-m-fpa-layout.c: Remove.
2656         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2657         * features/arm/arm-with-m-vfp-d16.c: Remove.
2658         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2659         * features/arm/arm-with-m.c: Remove.
2660         * features/arm/arm-with-m.xml: Remove.
2661         * features/arm/arm-with-neon.c: Remove.
2662         * features/arm/arm-with-neon.xml: Remove.
2663         * features/arm/arm-with-vfpv2.c: Remove.
2664         * features/arm/arm-with-vfpv2.xml: Remove.
2665         * features/arm/arm-with-vfpv3.c: Remove.
2666         * features/arm/arm-with-vfpv3.xml: Remove.
2667
2668 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2669
2670         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2671
2672 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2673
2674         * arch/aarch32.c (aarch32_create_target_description): Create
2675         target descriptions using features.
2676         * arch/arm.c (arm_create_target_description)
2677         (arm_create_mprofile_target_description): Likewise.
2678         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2679
2680 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2681
2682         * Makefile.in: Add new files.
2683         * aarch32-tdep.c: New file.
2684         * aarch32-tdep.h: New file.
2685         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2686         Call aarch32_read_description.
2687         * arch/aarch32.c: New file.
2688         * arch/aarch32.h: New file.
2689         * arch/arm.c (arm_create_target_description)
2690         (arm_create_mprofile_target_description): New function.
2691         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2692         (arm_create_target_description)
2693         (arm_create_mprofile_target_description): New declaration.
2694         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2695         read_description functions.
2696         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2697         Likewise.
2698         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2699         * arm-tdep.c (tdesc_arm_list): New variable.
2700         (arm_register_g_packet_guesses): Call create description functions.
2701         (arm_read_description) (arm_read_mprofile_description): New
2702         function.
2703         * arm-tdep.h (arm_read_description)
2704         (arm_read_mprofile_description): Add declaration.
2705         * configure.tgt: Add new files.
2706
2707 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2708
2709         * top.c (new_ui_command): Open specified terminal just once.
2710
2711 2019-07-18  Tom Tromey  <tromey@adacore.com>
2712
2713         * symtab.c (main_name): Constify return type.
2714         * symfile.c (set_initial_language): Update.
2715         * symtab.h (main_name): Constify return type.
2716
2717 2019-07-17  Tom Tromey  <tom@tromey.com>
2718
2719         * tui/tui-winsource.c (tui_update_source_window)
2720         (tui_update_source_window_as_is)
2721         (tui_update_source_windows_with_line): Remove return.
2722         * tui/tui-disasm.c (tui_show_disassem)
2723         (tui_show_disassem_and_update_source): Remove return.
2724         * tui/tui.c (tui_reset): Remove return.
2725         * tui/tui-wingeneral.c
2726         (tui_check_and_display_highlight_if_needed): Remove return.
2727
2728 2019-07-17  Tom Tromey  <tom@tromey.com>
2729
2730         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2731
2732 2019-07-17  Tom Tromey  <tom@tromey.com>
2733
2734         * tui/tui-winsource.h (struct tui_exec_info_window)
2735         (struct tui_source_window_base): Move from tui-data.h.
2736         * tui/tui-winsource.c: Move many method definitions from
2737         elsewhere.  Remove "structuring" comments.
2738         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2739         (tui_source_window_base::refresh_window): Move to
2740         tui-winsource.c.
2741         * tui/tui-win.c (tui_source_window_base::refresh_all)
2742         (tui_source_window_base::update_tab_width)
2743         (tui_source_window_base::set_new_height)
2744         (tui_source_window_base::do_make_visible_with_new_height): Move to
2745         tui-winsource.c.
2746         * tui/tui-source.h: Update.
2747         * tui/tui-source.c (tui_source_window_base::reset): Move to
2748         tui-winsource.c.
2749         * tui/tui-disasm.h: Update.
2750         * tui/tui-data.h (struct tui_exec_info_window): Move to
2751         tui-winsource.h.
2752         (struct tui_source_window_base): Likewise.
2753         * tui/tui-data.c (tui_source_window_base::clear_detail)
2754         (tui_source_window_base, ~tui_source_window_base): Move to
2755         tui-winsource.c.
2756
2757 2019-07-17  Tom Tromey  <tom@tromey.com>
2758
2759         * tui/tui-win.c (tui_resize_all)
2760         (tui_source_window_base::update_tab_width)
2761         (tui_adjust_win_heights): Update.
2762         (tui_win_info::make_invisible_and_set_new_height): Rename from
2763         make_invisible_and_set_new_height.
2764         * tui/tui-data.h (struct tui_win_info)
2765         <make_invisible_and_set_new_height>: New method.
2766
2767 2019-07-17  Tom Tromey  <tom@tromey.com>
2768
2769         * tui/tui.c: Update.
2770         * tui/tui-source.h (struct tui_source_window): Move from
2771         tui-data.h.
2772         * tui/tui-layout.c: Update.
2773         * tui/tui-disasm.c: Update.
2774         * tui/tui-data.h (struct tui_source_window): Move to
2775         tui-source.h.
2776
2777 2019-07-17  Tom Tromey  <tom@tromey.com>
2778
2779         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2780         tui-data.h.
2781         * tui/tui-data.h (struct tui_disasm_window): Move to
2782         tui-disasm.h.
2783
2784 2019-07-17  Tom Tromey  <tom@tromey.com>
2785
2786         * tui/tui-regs.h (struct tui_data_item_window): Move from
2787         tui-data.h.
2788         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2789         * tui/tui-data.h (struct tui_data_item_window): Move to
2790         tui-regs.h.
2791         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2792
2793 2019-07-17  Tom Tromey  <tom@tromey.com>
2794
2795         * tui/tui.c: Update.
2796         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2797         (tui_cmd_window::max_height): Move to tui-command.c.
2798         * tui/tui-layout.c: Update.
2799         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2800         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2801         tui-command.c.
2802         * tui/tui-command.h (struct tui_cmd_window): Move from
2803         tui-data.h.
2804         * tui/tui-command.c: Remove "structuring" comments.
2805         (tui_cmd_window::clear_detail)
2806         (tui_cmd_window::do_make_visible_with_new_height)
2807         (tui_cmd_window::max_height): Move from elsewhere.
2808
2809 2019-07-17  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2812         Now static.
2813         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2814         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2815
2816 2019-07-17  Tom Tromey  <tom@tromey.com>
2817
2818         * tui/tui.c: Update.
2819         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2820         tui-regs.c.
2821         * tui/tui-windata.h: Remove file.
2822         * tui/tui-windata.c: Remove file.
2823         * tui/tui-win.c (tui_data_window::set_new_height)
2824         (tui_data_window::do_make_visible_with_new_height): Move to
2825         tui-regs.c.
2826         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2827         * tui/tui-regs.c: Remove "structuring" comments.
2828         (tui_data_window::first_data_item_displayed)
2829         (tui_data_window::delete_data_content_windows)
2830         (tui_data_window::erase_data_content)
2831         (tui_data_window::display_all_data)
2832         (tui_data_window::refresh_all)
2833         (tui_data_window::do_scroll_vertical)
2834         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2835         (tui_data_window::do_make_visible_with_new_height)
2836         (tui_data_window::refresh_window): Move from elsewhere.
2837         (_initialize_tui_regs): Move to end of file.
2838         * tui/tui-layout.c: Update.
2839         * tui/tui-hooks.c: Update.
2840         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2841         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2842         tui-regs.c.
2843         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2844
2845 2019-07-17  Tom Tromey  <tom@tromey.com>
2846
2847         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2848         seen.
2849
2850 2019-07-17  Tom Tromey  <tom@tromey.com>
2851
2852         * tui/tui-win.c (tui_source_window_base::set_new_height)
2853         (tui_source_window_base::do_make_visible_with_new_height): Use
2854         m_has_locator field directly.
2855         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2856         method.
2857         (struct tui_source_window_base) <has_locator>: Likewise.
2858
2859 2019-07-17  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2862         Don't declare.
2863         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2864         Remove.
2865         * tui/tui-win.c (tui_source_window_base::set_new_height)
2866         (tui_source_window_base::set_new_height)
2867         (make_invisible_and_set_new_height)
2868         (tui_source_window_base::do_make_visible_with_new_height)
2869         (tui_source_window_base::do_make_visible_with_new_height):
2870         Update.
2871         * tui/tui-layout.c (show_source_disasm_command, show_data)
2872         (show_source_or_disasm_and_command): Update.
2873         * tui/tui-layout.c (show_layout): Update.
2874
2875 2019-07-17  Tom Tromey  <tom@tromey.com>
2876
2877         * tui/tui-layout.c (make_data_window): Remove.
2878         (show_data): Unify creation and re-initialization cases.
2879
2880 2019-07-17  Tom Tromey  <tom@tromey.com>
2881
2882         * tui/tui-layout.c (make_source_window, make_disasm_window):
2883         Remove.
2884         (show_data): Unify creation and re-initialization cases.
2885
2886 2019-07-17  Tom Tromey  <tom@tromey.com>
2887
2888         * tui/tui-layout.c (make_command_window): Remove.
2889         (show_source_disasm_command, show_source_or_disasm_and_command):
2890         Unify creation and re-initialization cases.
2891
2892 2019-07-17  Tom Tromey  <tom@tromey.com>
2893
2894         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2895         creation and re-initialization cases.
2896
2897 2019-07-17  Tom Tromey  <tom@tromey.com>
2898
2899         * tui/tui-regs.c (tui_get_register): Return void.
2900
2901 2019-07-17  Tom Tromey  <tom@tromey.com>
2902
2903         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2904         Simplify.
2905
2906 2019-07-17  Tom Tromey  <tom@tromey.com>
2907
2908         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2909         resetting.
2910
2911 2019-07-17  Tom Tromey  <tom@tromey.com>
2912
2913         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2914         * tui/tui-regs.c (tui_reg_layout): New function.
2915         (tui_show_registers, tui_reg_command): Use it.
2916         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2917         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2918         parameters.
2919         (tui_layout_command): Remove.
2920
2921 2019-07-17  Tom Tromey  <tom@tromey.com>
2922
2923         * tui/tui-layout.h (tui/tui-layout): Return void.
2924         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2925
2926 2019-07-17  Tom Tromey  <tom@tromey.com>
2927
2928         * tui/tui-layout.c (show_source_disasm_command, show_data):
2929         Update.
2930         (reset_locator): Remove.
2931         (show_source_or_disasm_and_command): Update.
2932
2933 2019-07-17  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-source.c (tui_source_window_base::reset): Remove
2936         win_type parameter.
2937         * tui/tui-layout.c (make_command_window, make_source_window)
2938         (make_disasm_window, make_data_window)
2939         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2940         (reset_locator, show_source_or_disasm_and_command): Update.
2941         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2942         win_type parameter.
2943         (struct tui_source_window_base) <reset>: Likewise.
2944
2945 2019-07-17  Tom Tromey  <tom@tromey.com>
2946
2947         * tui/tui-layout.c (show_source_disasm_command): Use
2948         reset_locator.
2949         (reset_locator): New function.
2950         (init_and_make_win): Remove.
2951         (show_source_or_disasm_and_command): Use reset_locator.
2952
2953 2019-07-17  Tom Tromey  <tom@tromey.com>
2954
2955         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2956         condition.
2957         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2958         Remove condition.
2959         * tui/tui-source.c (tui_source_window_base::reset): New method.
2960         * tui/tui-layout.c (make_command_window): Don't call
2961         init_and_make_win.
2962         (make_source_window, make_disasm_window): Don't call
2963         make_source_or_disasm_window.
2964         (make_data_window): Don't call init_and_make_win.  Change calling
2965         convention.
2966         (show_source_disasm_command, show_data): Simplify.
2967         (make_source_or_disasm_window): Remove.
2968         (show_source_or_disasm_and_command): Simplify.
2969         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2970         (struct tui_source_window_base) <reset>: Likewise.
2971         <execution_info>: Remove initializer.
2972         * tui/tui-data.c (tui_source_window_base): Initialize
2973         execution_info.
2974
2975 2019-07-17  Tom Tromey  <tom@tromey.com>
2976
2977         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2978         variable.
2979
2980 2019-07-17  Tom Tromey  <tom@tromey.com>
2981
2982         * tui/tui.c (tui_rl_other_window): Update.
2983         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2984         superclass method first.  Always iterate over regs_content.
2985         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2986         method.
2987         * tui/tui-win.c (tui_set_focus_command): Update.
2988
2989 2019-07-17  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-win.c (tui_set_focus_command): Rename from
2992         tui_set_focus.  Call tui_enable.
2993         (tui_set_focus_command): Remove.
2994
2995 2019-07-17  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2998         refresh_window.
2999         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3000         touchwin.
3001         (tui_data_window::refresh_window): Call refresh_window on data
3002         items.  Always call superclass refresh_window.
3003         (tui_win_info::refresh): Remove.
3004         (tui_source_window_base::refresh_window): Update.
3005         (tui_refresh_all): Update.
3006         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3007         refresh_window.
3008         (show_source_or_disasm_and_command): Likewise.
3009         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3010         (struct tui_source_window_base) <refresh>: Likewise.
3011
3012 2019-07-17  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-winsource.c (tui_clear_source_content)
3015         (tui_show_source_content): Update.
3016         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3017         whether content is empty.
3018         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3019         Remove.
3020
3021 2019-07-17  Tom Tromey  <tom@tromey.com>
3022
3023         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3024         window's contents.
3025         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3026         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3027
3028 2019-07-17  Tom Tromey  <tom@tromey.com>
3029
3030         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3031         (struct tui_data_item_window): Update.
3032
3033 2019-07-17  Tom Tromey  <tom@tromey.com>
3034
3035         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3036         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3037         defines.
3038
3039 2019-07-17  Tom Tromey  <tom@tromey.com>
3040
3041         * tui/tui-winsource.h (tui_erase_source_content)
3042         (tui_clear_source_content): Remove "display_prompt" parameter.
3043         * tui/tui-winsource.c (tui_update_source_window_as_is)
3044         (tui_update_source_windows_with_addr): Update.
3045         (tui_clear_source_content): Remove "display_prompt" parameter.
3046         (tui_erase_source_content): Likewise.  Simplify.
3047         (tui_show_source_content): Update.
3048         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3049         * tui/tui-stack.c (tui_show_frame_info): Update.
3050         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3051         Remove defines.
3052
3053 2019-07-17  Tom Tromey  <tom@tromey.com>
3054
3055         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3056         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3057         parameter.
3058         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3059         parameter.
3060
3061 2019-07-17  Tom Tromey  <tom@tromey.com>
3062
3063         * tui/tui-winsource.c (tui_clear_source_content)
3064         (tui_show_source_content, tui_show_exec_info_content)
3065         (tui_clear_exec_info_content): Update.
3066         * tui/tui-stack.c (tui_show_locator_content): Update.
3067         (tui_show_frame_info): Update.
3068         * tui/tui-source.h (tui_source_window): Don't declare.
3069         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3070         from tui_source_is_displayed.
3071         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3072         Remove field.
3073         (struct tui_source_window_base) <content_in_use>: New field.  Now
3074         bool.
3075         (struct tui_source_window) <showing_source_p>: New method.
3076         (TUI_SRC_WIN): Change cast.
3077         * tui/tui-data.c (tui_initialize_static_data): Update.
3078
3079 2019-07-17  Tom Tromey  <tom@tromey.com>
3080
3081         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3082         location_matches_p.
3083         * tui/tui-source.c (tui_source_window::location_matches_p): New
3084         method.
3085         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3086         method.
3087         * tui/tui-data.h (struct tui_source_window_base)
3088         <location_matches_p>: New method.
3089         (struct tui_source_window, struct tui_disasm_window)
3090         <location_matches_p>: Likewise.
3091
3092 2019-07-17  Tom Tromey  <tom@tromey.com>
3093
3094         * tui/tui-win.c (tui_set_win_height_command): Rename from
3095         tui_set_win_height.
3096         (tui_set_win_height_command): Remove.
3097
3098 2019-07-17  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-source.c (tui_source_window): New constructor.  Add
3101         observer.
3102         (~tui_source_window): New destructor.
3103         (tui_source_window::style_changed): New method.
3104         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3105         (tui_attach_detach_observers): Update.
3106         * tui/tui-data.h (struct tui_source_window): Make constructor not
3107         inline.  Add destructor.
3108         (struct tui_source_window) <style_changed>: New method.
3109         <m_observable>: New member.
3110
3111 2019-07-17  Tom Tromey  <tom@tromey.com>
3112
3113         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3114         * tui/tui-win.c (tui_resize_all): Fix typo.
3115
3116 2019-07-17  Tom Tromey  <tom@tromey.com>
3117
3118         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3119         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3120         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3121         * tui/tui-win.c (window_name_completer): Use foreach.
3122         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3123         (update_tab_width): Likewise.
3124         * tui/tui-layout.c (show_layout): Update.
3125         * tui/tui-data.h (class tui_window_iterator): New.
3126         (struct all_tui_windows): New.
3127         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3128
3129 2019-07-17  Tom Tromey  <tom@tromey.com>
3130
3131         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3132         parameter.  Don't reference globals.
3133         (tui_reg_command): Update.
3134
3135 2019-07-17  Tom Tromey  <tom@tromey.com>
3136
3137         * tui/tui-regs.c (tui_show_registers): Simplify.
3138
3139 2019-07-17  Tom Tromey  <tom@tromey.com>
3140
3141         * tui/tui-regs.c (tui_show_registers): Update.
3142         (tui_show_register_group): Add win_info parameter.
3143
3144 2019-07-17  Tom Tromey  <tom@tromey.com>
3145
3146         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3147         Rename from tui_display_reg_element_at_line.
3148         (tui_data_window::display_registers_from_line): Update.
3149         * tui/tui-data.h (struct tui_data_window)
3150         <display_reg_element_at_line>: New method.
3151
3152 2019-07-17  Tom Tromey  <tom@tromey.com>
3153
3154         * tui/tui-regs.h (tui_display_registers_from)
3155         (tui_display_registers_from_line): Don't declare.
3156         * tui/tui-windata.c (tui_data_window::display_all_data)
3157         (tui_data_window::refresh_all)
3158         (tui_data_window::do_scroll_vertical): Update.
3159         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3160         from tui_display_registers_from.
3161         (tui_display_reg_element_at_line): Update.
3162         (tui_data_window::display_registers_from_line): Rename from
3163         tui_display_registers_from_line.
3164         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3165         display_registers_from_line>: New methods.
3166
3167 2019-07-17  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3170         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3171         from tui_erase_data_content.
3172         (tui_data_window::display_all_data)
3173         (tui_data_window::refresh_all)
3174         (tui_data_window::do_scroll_vertical): Update.
3175         * tui/tui-regs.c (tui_show_registers): Update.
3176         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3177         New method.
3178
3179 2019-07-17  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3182         declare.
3183         * tui/tui-windata.c
3184         (tui_data_window::delete_data_content_windows): Rename from
3185         tui_delete_data_content_windows.
3186         (tui_data_window::display_all_data)
3187         (tui_data_window::do_scroll_vertical): Update.
3188         * tui/tui-data.h (struct tui_data_window)
3189         <delete_data_content_windows>: New method.
3190
3191 2019-07-17  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3194         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3195
3196 2019-07-17  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3199         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3200         from tui_display_all_data.
3201         * tui/tui-win.c
3202         (tui_data_window::do_make_visible_with_new_height): Update.
3203         * tui/tui-regs.c (tui_show_registers): Update.
3204         * tui/tui-layout.c (tui_set_layout): Update.
3205         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3206         method.
3207
3208 2019-07-17  Tom Tromey  <tom@tromey.com>
3209
3210         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3211         * tui/tui-windata.c (tui_display_data_from): Remove.
3212         (tui_data_window::refresh_all): Update.
3213
3214 2019-07-17  Tom Tromey  <tom@tromey.com>
3215
3216         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3217         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3218         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3219         tui_display_registers_from_line.
3220         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3221         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3222         "force_display" parameter.
3223
3224 2019-07-17  Tom Tromey  <tom@tromey.com>
3225
3226         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3227         declare.
3228         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3229         Rename from tui_first_reg_element_no_inline.
3230         (tui_display_reg_element_at_line)
3231         (tui_display_registers_from_line): Update.
3232         * tui/tui-data.h (struct tui_data_window)
3233         <first_reg_element_no_inline>: New method.
3234
3235 2019-07-17  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui-windata.c (tui_display_data_from)
3238         (tui_data_window::do_scroll_vertical): Update.
3239         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3240         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3241         Rename from tui_line_from_reg_element_no.
3242         (tui_display_registers_from_line): Update.
3243         * tui/tui-data.h (struct tui_data_window)
3244         <line_from_reg_element_no>: New method.
3245
3246 2019-07-17  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3249         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3250         tui_last_regs_line_no.
3251         (tui_display_reg_element_at_line)
3252         (tui_display_registers_from_line): Update.
3253         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3254         method.
3255
3256 2019-07-17  Tom Tromey  <tom@tromey.com>
3257
3258         PR tui/24722:
3259         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3260         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3261         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3262         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3263         (tui_update_breakpoint_info): Likewise.
3264         * tui/tui-hooks.c (tui_event_create_breakpoint)
3265         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3266         Update.
3267
3268 2019-07-17  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3271
3272 2019-07-17  Tom Tromey  <tom@tromey.com>
3273
3274         * tui/tui-winsource.c (tui_update_source_window_as_is)
3275         (tui_update_source_windows_with_addr): Update.
3276         * tui/tui-source.h (tui_set_source_content)
3277         (tui_show_symtab_source): Add "win_info" parameter.
3278         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3279         parameter.
3280         (tui_show_symtab_source): Likewise.
3281
3282 2019-07-17  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-wingeneral.c
3285         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3286
3287 2019-07-17  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3290         (struct tui_cmd_window) <can_scroll>: New method.
3291         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3292         method.
3293
3294 2019-07-17  Tom Tromey  <tromey@adacore.com>
3295
3296         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3297         do_field_signed>: Rename.  Change type of "value".
3298         * ui-out.c (ui_out::field_signed): Rename from field_int.
3299         Change type of "value".
3300         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3301         type of "value".
3302         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3303         do_field_int.  Change type of "value".
3304         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3305         do_field_int.  Change type of "value".
3306         * tracepoint.c (trace_status_mi, tfind_1)
3307         (print_one_static_tracepoint_marker): Update.
3308         * thread.c (print_thread_info_1, print_selected_thread_frame):
3309         Update.
3310         * stack.c (print_frame, print_frame_info): Update.
3311         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3312         Update.
3313         * source.c (print_source_lines_base): Update.
3314         * skip.c (info_skip_command): Update.
3315         * record-btrace.c (btrace_ui_out_decode_error)
3316         (btrace_call_history_src_line): Update.
3317         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3318         Update.
3319         * progspace.c (print_program_space): Update.
3320         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3321         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3322         do_field_int.  Change type of "value".
3323         * mi/mi-out.c (mi_ui_out::do_table_begin)
3324         (mi_ui_out::do_table_header): Update.
3325         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3326         type of "value".
3327         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3328         (mi_cmd_data_list_changed_registers, output_register)
3329         (mi_cmd_data_read_memory, mi_load_progress)
3330         (mi_cmd_trace_frame_collected): Update.
3331         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3332         Update.
3333         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3334         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3335         (mi_cmd_var_list_children, varobj_update_one): Update.
3336         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3337         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3338         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3339         * inferior.c (print_inferior): Update.
3340         * gdb_bfd.c (print_one_bfd): Update.
3341         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3342         Update.
3343         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3344         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3345         do_field_int.  Change type of "value".
3346         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3347         do_field_int.  Change type of "value".
3348         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3349         (print_one_breakpoint_location, print_it_catch_fork)
3350         (print_one_catch_fork, print_it_catch_vfork)
3351         (print_one_catch_vfork, print_it_catch_solib)
3352         (print_it_catch_exec, print_it_ranged_breakpoint)
3353         (print_mention_watchpoint, print_mention_masked_watchpoint)
3354         (bkpt_print_it, update_static_tracepoint): Update.
3355         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3356         * break-catch-syscall.c (print_it_catch_syscall): Update.
3357         * ada-tasks.c (print_ada_task_info): Update.
3358         * ada-lang.c (print_it_exception, print_mention_exception):
3359         Update.
3360
3361 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         PR breakpoints/24541
3364         * gdbarch.c: Regenerate.
3365         * gdbarch.h: Regenerate.
3366         * gdbarch.sh: Adjust return type and parameter types for
3367         'stap_adjust_register'.
3368         (i386_stap_adjust_register): Adjust signature and return new
3369         register name.
3370         * stap-probe.c (stap_parse_register_operand): Adjust use of
3371         'gdbarch_stap_adjust_register'.
3372
3373 2019-07-17  Tom Tromey  <tromey@adacore.com>
3374
3375         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3376         declare VEC.
3377         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3378         std::vector.
3379         (struct s390_process_info): Add initializers.
3380         (s390_add_process): Use new.
3381         (s390_linux_nat_target::low_forget_process): Use delete.
3382         (s390_linux_nat_target::low_new_fork)
3383         (s390_linux_nat_target::stopped_by_watchpoint)
3384         (s390_linux_nat_target::low_prepare_to_resume)
3385         (s390_linux_nat_target::insert_watchpoint)
3386         (s390_linux_nat_target::insert_hw_breakpoint)
3387         (s390_linux_nat_target::remove_watchpoint)
3388         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3389
3390 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3391
3392         * aarch64-fbsd-nat.c: Include regcache.h.
3393         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3394         argument.
3395         (aarch64_fbsd_nat_target::fetch_registers)
3396         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3397         variable.
3398         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3399
3400 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3401
3402         * fbsd-nat.c: Include gdbarch.h.
3403
3404 2019-07-15  Tom Tromey  <tromey@adacore.com>
3405
3406         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3407
3408 2019-07-15  Tom Tromey  <tromey@adacore.com>
3409
3410         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3411         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3412         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3413         * cli-out.c (cli_ui_out::do_field_int): New method.
3414         * ui-out.c (ui_out::field_unsigned): New method.
3415         * symfile.c (generic_load): Use field_unsigned.
3416         (print_transfer_performance): Likewise.
3417         * record-btrace.c (ui_out_field_uint): Remove.
3418         (btrace_call_history_insn_range, btrace_call_history): Use
3419         field_unsigned.
3420         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3421         field_unsigned.
3422         * ui-out.h (class ui_out) <field_unsigned>: New method.
3423         <do_field_unsigned>: Likewise.
3424
3425 2019-07-15  Tom Tromey  <tromey@adacore.com>
3426
3427         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3428         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3429         * target.c (flash_erase_command): Use field_string.
3430         * infrun.c (print_signal_received_reason): Use field_string.
3431         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3432         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3433         field_string.
3434         * ada-tasks.c (print_ada_task_info): Use field_string.
3435
3436 2019-07-15  Tom Tromey  <tromey@adacore.com>
3437
3438         * target.c (flash_erase_command): Use field_core_addr.
3439         * symfile.c (generic_load): Use field_core_addr.
3440         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3441         Use field_core_addr.
3442         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3443         field_core_addr.
3444
3445 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3446
3447         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3448         value if its desired type is smaller than a CORE_ADDR and signed.
3449
3450 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3453         of changes to field names, and use new is_reference field to
3454         decide if a property is a reference or not.
3455         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3456         field.
3457         (struct dwarf2_property_baton): Update header comment, rename
3458         'referenced_type' to 'property_type' and update comments.
3459         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3460         default property type, store in property baton, update to take
3461         accound of renamed field.
3462         (read_func_scope): Update call to attr_to_dynamic_prop.
3463         (read_array_type): Likewise.
3464         (dwarf2_per_cu_addr_sized_int_type): New function.
3465         (read_subrange_index_type): Move type finding code to
3466         dwarf2_per_cu_addr_sized_int_type.
3467         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3468         (dwarf2_per_cu_addr_type): New function.
3469         (set_die_type): Update calls to attr_to_dynamic_prop.
3470
3471 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3472
3473         * dwarf2read.c (read_subrange_index_type): New function.
3474         (read_subrange_type): Move code into new function and call it.
3475         * gdbtypes.c (create_range_type): Add some asserts.
3476
3477 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3478
3479         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3480         update return statements.
3481         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3482         declaration, and update comment to match.
3483         * gdbtypes.c (resolve_dynamic_array): Update call to
3484         dwarf2_evaluate_property to match new return type.
3485
3486 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3487
3488         * valarith.c (value_subscripted_rvalue): Change lowerbound
3489         parameter type from int to LONGEST.
3490         * value.h (value_subscripted_rvalue): Likewise in declaration.
3491
3492 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3493
3494         * cli/cli-utils.c (info_print_command_completer): New function.
3495         * cli/cli-utils.h: Add 'completer.h' include, and forward
3496         declaration for 'struct cmd_list_element'.
3497         (info_print_command_completer): Declare.
3498         * stack.c (_initialize_stack): Add completer for 'info locals' and
3499         'info args'.
3500         * symtab.c (_initialize_symtab): Add completer for 'info
3501         variables' and 'info functions'.
3502         * NEWS: Mention completion for additional info commands.
3503
3504 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3505
3506         * cli/cli-utils.c (extract_info_print_args): Delete.
3507         (extract_arg_maybe_quoted): Delete.
3508         (info_print_options_defs): New variable.
3509         (make_info_print_options_def_group): New function.
3510         (extract_info_print_options): Define new function.
3511         * cli/cli-utils.h (extract_info_print_args): Delete.
3512         (struct info_print_options): New structure.
3513         (extract_info_print_options): Declare new function.
3514         * stack.c (info_locals_command): Update to use new
3515         extract_info_print_options, also add a header comment.
3516         (info_args_command): Likewise.
3517         * symtab.c (info_variables_command): Likewise.
3518         (info_functions_command): Likewise.
3519
3520 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3521
3522         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3523         to extract string arguments.
3524         * common/common-utils.c (extract_string_maybe_quoted): New function.
3525         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3526
3527 2019-07-11  Tom Tromey  <tromey@adacore.com>
3528
3529         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3530         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3531         * top.h (gdbinit): Don't declare.
3532         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3533         into...
3534         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3535         * top.c (gdb_init): Don't call init_cli_cmds.
3536         (gdbinit): Remove.
3537         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3538
3539 2019-07-11  Tom Tromey  <tromey@adacore.com>
3540
3541         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3542         after it has been moved.
3543
3544 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3545
3546         * valops.c (value_must_coerce_to_target): Change return type to
3547         bool.
3548         * value.h (value_must_coerce_to_target): Likewise.
3549
3550 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3551
3552         * breakpoint.c (is_hardware_watchpoint): Remove
3553         forward-declaration.
3554         (is_masked_watchpoint): Change return type to bool.
3555         (is_tracepoint): Likewise.
3556         (is_breakpoint): Likewise.
3557         (is_hardware_watchpoint): Likewise.
3558         (is_watchpoint): Likewise.
3559         (is_no_memory_software_watchpoint): Likewise.
3560         (is_catchpoint): Likewise.
3561         (breakpoint_1): Make FILTER parameter's return type bool.
3562         is_masked_watchpoint): Change return type to bool.
3563         (save_breakpoints): Make FILTER parameter's return type bool.
3564         * breakpoint.h (is_breakpoint): Change return type to bool.
3565         (is_watchpoint): Likewise.
3566         (is_catchpoint): Likewise.
3567         (is_tracepoint): Likewise.
3568
3569 2019-07-10  Tom Tromey  <tom@tromey.com>
3570
3571         * defs.h: Don't include gdbarch.h.
3572         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3573         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3574         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3575         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3576         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3577         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3578         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3579         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3580         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3581         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3582         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3583         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3584         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3585         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3586         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3587         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3588         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3589         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3590         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3591         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3592         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3593         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3594         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3595         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3596         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3597         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3598         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3599
3600 2019-07-10  Tom Tromey  <tromey@adacore.com>
3601
3602         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3603         * breakpoint.c (init_ada_exception_breakpoint): Register as
3604         bp_catchpoint.
3605         (print_one_breakpoint_location, print_one_breakpoint): Use
3606         is_ada_exception_catchpoint.
3607         * ada-lang.c (class ada_catchpoint_location): Pass
3608         bp_loc_software_breakpoint to bp_location constructor.
3609         (is_ada_exception_catchpoint): New function.
3610
3611 2019-07-10  Tom Tromey  <tromey@adacore.com>
3612
3613         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3614         VEC.
3615         (struct arm_exidx_entry): New method operator<.
3616         (struct arm_exidx_data) <section_maps>: Change type.
3617         (arm_exidx_data_free): Remove.
3618         (arm_exidx_data_key): Change type.  Move lower.
3619         (arm_exidx_new_objfile): Update.
3620         (arm_compare_exidx_entries): Remove.
3621         (arm_find_exidx_entry, _initialize_arm_tdep)
3622
3623 2019-07-10  Tom Tromey  <tromey@adacore.com>
3624
3625         * solib-spu.c (ocl_program_data_key): Change type.
3626         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3627         Update.
3628
3629 2019-07-10  Tom Tromey  <tromey@adacore.com>
3630
3631         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3632         (struct solib_aix_inferior_data) <library_list>: Change type.
3633         (solib_aix_inferior_data_handle): Change type.
3634         (get_solib_aix_inferior_data): Update.
3635         (solib_aix_free_library_list): Remove.
3636         (library_list_start_library): Update.
3637         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3638         return type.
3639         (solib_aix_get_library_list)
3640         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3641         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3642
3643 2019-07-10  Tom Tromey  <tromey@adacore.com>
3644
3645         * solib-dsbt.c (struct dsbt_info): Add initializers.
3646         (solib_dsbt_pspace_data): Change type.
3647         (dsbt_pspace_data_cleanup): Remove.
3648         (get_dsbt_info, _initialize_dsbt_solib): Update.
3649
3650 2019-07-10  Tom Tromey  <tromey@adacore.com>
3651
3652         * spu-tdep.c (spu_overlay_data): Change type.
3653         (spu_get_overlay_table, spu_overlay_new_objfile)
3654         (_initialize_spu_tdep): Update.
3655
3656 2019-07-10  Tom Tromey  <tromey@adacore.com>
3657
3658         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3659         destructor.
3660         (dbx_objfile_data_key): Change type and declare later.
3661         (DBX_SYMFILE_INFO): Rewrite.
3662         * dbxread.c (dbx_objfile_data_key): Change type.
3663         (dbx_symfile_init): Update.
3664         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3665         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3666         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3667
3668 2019-07-10  Tom Tromey  <tromey@adacore.com>
3669
3670         * jit.c (jit_program_space_key): Change type.  Move lower.
3671         (get_jit_program_space_data): Update.
3672         (jit_program_space_data_cleanup): Remove.
3673         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3674         Update.
3675         (struct jit_program_space_data): Add initializers.
3676
3677 2019-07-10  Tom Tromey  <tromey@adacore.com>
3678
3679         * solib-darwin.c (struct darwin_info): Add initializers.
3680         (solib_darwin_pspace_data): Change type.
3681         (darwin_pspace_data_cleanup): Remove.
3682         (get_darwin_info, _initialize_darwin_solib): Update.
3683
3684 2019-07-10  Tom Tromey  <tromey@adacore.com>
3685
3686         * remote-sim.c (struct sim_inferior_data): Add initializers,
3687         constructor, and destructor.
3688         (sim_inferior_data_key): Change type.  Move lower.
3689         (check_for_duplicate_sim_descriptor): Update.
3690         (get_sim_inferior_data): Use new.  Update.
3691         (~sim_inferior_data_cleanup): Rename from
3692         sim_inferior_data_cleanup.  Simplify.
3693         (gdbsim_close_inferior, simulator_command)
3694         (sim_command_completer, _initialize_remote_sim): Update.
3695         (next_pid, INITIAL_PID): Move earlier.
3696
3697 2019-07-10  Tom Tromey  <tromey@adacore.com>
3698
3699         * python/python-internal.h (create_thread_object): Return
3700         gdbpy_ref.
3701         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3702         * python/py-inferior.c (struct threadlist_entry): Add
3703         constructor.
3704         <thread_obj>: Now a gdbpy_ref.
3705         (thread_to_thread_object): Update.
3706         (add_thread_object): Use new.
3707         (delete_thread_object): Use delete.
3708         (infpy_threads): Update.
3709         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3710         GIL.
3711
3712 2019-07-10  Tom Tromey  <tromey@adacore.com>
3713
3714         * valops.c (value_cast): Specialize error message for Ada.
3715
3716 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3717
3718         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3719
3720 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3721
3722         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3723         bpstat_should_step): Return bool, adjust comments.
3724         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3725         bpstat_should_step): Likewise.
3726
3727 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3728
3729         * features/Makefile: Use feature target descriptions for Arm.
3730         * features/arm/arm-core.c: Generate new file.
3731         * features/arm/arm-fpa.c: Likewise.
3732         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3733         * features/arm/arm-m-profile.c: Likewise.
3734         * features/arm/arm-vfpv2.c: Likewise.
3735         * features/arm/arm-vfpv3.c: Likewise.
3736         * features/arm/xscale-iwmmxt.c: Likewise.
3737         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3738
3739 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3740
3741         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3742         ptrace earlier.
3743
3744 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3745
3746         * features/aarch64-pauth.c: Regenerate.
3747
3748 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3749
3750         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3751         bool.
3752         (bpstat_what): Use false instead of 0.
3753
3754 2019-07-09  Pedro Alves  <palves@redhat.com>
3755
3756         * break-catch-throw.c (is_exception_catchpoint): New.
3757         * breakpoint.c (print_one_breakpoint_location): New parameter
3758         'raw_loc'.  Handle it.  Use
3759         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3760         looking at the breakpoint's type.
3761         (print_one_breakpoint): If handling "maint info breakpoints", also
3762         print locations of exception catchpoints.
3763         * breakpoint.h (is_exception_catchpoint): Declare.
3764
3765 2019-07-09  Pedro Alves  <palves@redhat.com>
3766
3767         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3768         "addr" field.
3769         (allocate_location_exception_catchpoint): New.
3770         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3771         (initialize_throw_catchpoint_ops): Install
3772         allocate_location_exception_catchpoint as allocate_location
3773         method.
3774         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3775         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3776         bp_loc_other.
3777         (breakpoint_address_is_meaningful): Delete.
3778         (bl_address_is_meaningful): New.
3779         (breakpoint_locations_match): Adjust comment.
3780         (bp_location_from_bp_type): New, factored out of...
3781         (bp_location::bp_location(breakpoint *)): ... this.
3782         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3783         factored out of...
3784         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3785         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3786         breakpoint_address_is_meaningful.
3787         (bp_locations_compare): Adjust comment.
3788         (update_global_location_list): Use bl_address_is_meaningful
3789         instead of breakpoint_address_is_meaningful.
3790         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3791         explicit.
3792         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3793         * python/py-breakpoint.c (bppy_get_location): No longer check
3794         whether location is null.
3795
3796 2019-07-09  Pedro Alves  <palves@redhat.com>
3797
3798         PR c++/15468
3799         * breakpoint.c (print_one_breakpoint_location): Remove
3800         single-location assert.
3801
3802 2019-07-09  Tom Tromey  <tom@tromey.com>
3803
3804         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3805         * configure: Rebuild.
3806         * configure.ac: Change common to gdbsupport.
3807         * gdbsupport: Rename from common.
3808         * acinclude.m4: Change common to gdbsupport.
3809         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3810         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3811         gdbsupport.
3812         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3813         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3814         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3815         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3816         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3817         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3818         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3819         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3820         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3821         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3822         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3823         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3824         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3825         coff-pe-read.c, command.h, compile/compile-c-support.c,
3826         compile/compile-c.h, compile/compile-cplus-symbols.c,
3827         compile/compile-cplus-types.c, compile/compile-cplus.h,
3828         compile/compile-loc2c.c, compile/compile.c, completer.c,
3829         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3830         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3831         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3832         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3833         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3834         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3835         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3836         features/aarch64-core.c, features/aarch64-fpu.c,
3837         features/aarch64-pauth.c, features/aarch64-sve.c,
3838         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3839         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3840         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3841         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3842         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3843         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3844         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3845         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3846         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3847         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3848         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3849         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3850         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3851         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3852         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3853         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3854         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3855         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3856         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3857         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3858         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3859         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3860         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3861         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3862         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3863         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3864         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3865         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3866         minsyms.c, mips-linux-tdep.c, namespace.h,
3867         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3868         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3869         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3870         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3871         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3872         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3873         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3874         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3875         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3876         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3877         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3878         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3879         procfs.c, producer.c, progspace.h, psymtab.h,
3880         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3881         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3882         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3883         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3884         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3885         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3886         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3887         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3888         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3889         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3890         target-memory.c, target.c, target.h, target/waitstatus.c,
3891         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3892         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3893         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3894         unittests/array-view-selftests.c,
3895         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3896         unittests/common-utils-selftests.c,
3897         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3898         unittests/format_pieces-selftests.c,
3899         unittests/function-view-selftests.c,
3900         unittests/lookup_name_info-selftests.c,
3901         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3902         unittests/mkdir-recursive-selftests.c,
3903         unittests/observable-selftests.c,
3904         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3905         unittests/parse-connection-spec-selftests.c,
3906         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3907         unittests/scoped_fd-selftests.c,
3908         unittests/scoped_mmap-selftests.c,
3909         unittests/scoped_restore-selftests.c,
3910         unittests/string_view-selftests.c, unittests/style-selftests.c,
3911         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3912         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3913         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3914         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3915         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3916         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3917
3918 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3919
3920         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3921         bool value.
3922         (decode_digits_ordinary): Set explicit_line field in sal.
3923         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3924         symtab_and_line that was set on an explicit line number in
3925         assembler code.  Do always update the recorded symtab and line if
3926         we do skip the prologue.
3927
3928 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * breakpoint.c (set_breakpoint_location_function): Remove
3931         explicit_loc parameter.
3932         (momentary_breakpoint_from_master): Update call to
3933         set_breakpoint_location_function.
3934         (add_location_to_breakpoint): Likewise.
3935
3936 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3937
3938         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3939         required features based on default bfd type when no specific bfd
3940         is present.
3941
3942 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3943
3944         * NEWS: Mention that GDB printf and eval commands can now print
3945         C-style and Ada-style convenience var strings without
3946         calling the inferior.
3947         * printcmd.c (printf_c_string): Locally print GDB internal var
3948         instead of transiting via the inferior.
3949         (printf_wide_c_string): Likewise.
3950
3951 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3952
3953         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3954
3955 2019-07-04  Tom Tromey  <tom@tromey.com>
3956
3957         PR tui/24724:
3958         * tui/tui-winsource.c (tui_clear_source_content): Update.
3959         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3960         (tui_update_breakpoint_info): Update.
3961         (tui_set_exec_info_content): Update.
3962         * tui/tui-source.c (tui_set_source_content_nil): Update.
3963         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3964         has_break.
3965         * tui/tui-data.h (enum tui_bp_flag): New.
3966         (tui_bp_flags): New enum flags type.
3967         (struct tui_source_element) <break_mode>: Change type.  Rename
3968         from has_break.
3969         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3970         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3971         constants.
3972         * tui/tui-winsource.h: Fix comment.
3973
3974 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3975
3976         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3977         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3978         (store_fpregs_to_thread)
3979         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3980         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3981         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3982         (IWMMXT_REGS_SIZE): Add define.
3983         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3984         (fetch_vfp_regs, store_vfp_regs)
3985         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3986         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3987
3988 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3989
3990         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3991         defines.
3992         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3993         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3994         (ARM_INT_REGISTER_SIZE): ...to this.
3995         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3996         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3997         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3998         (arm_linux_collect_gregset, supply_nwfpe_register)
3999         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4000         defines.
4001         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4002         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4003         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4004         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4005         (arm_return_in_memory, arm_store_return_value)
4006         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4007         (arm_record_ld_st_multiple): Likewise.
4008         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4009         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4010
4011 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4012
4013         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4014         AARCH64_DISPLACED_MODIFIED_INSNS.
4015         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4016         (aarch64_displaced_step_copy_insn): Likewise.
4017         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4018         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4019         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4020         ARM_DISPLACED_MODIFIED_INSNS.
4021         * arm-tdep.c (arm_gdbarch_init): Likewise.
4022         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4023         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4024         (struct arm_displaced_step_closure): Use
4025         ARM_DISPLACED_MODIFIED_INSNS.
4026
4027 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4028
4029         * features/Makefile: Remove unused xml files.
4030         * features/aarch64.xml: Remove.
4031         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4032         * features/i386/amd64-avx-avx512.xml: Remove.
4033         * features/i386/amd64-avx-linux.xml: Remove.
4034         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4035         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4036         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4037         * features/i386/amd64-avx-mpx.xml: Remove.
4038         * features/i386/amd64-avx.xml: Remove.
4039         * features/i386/amd64-linux.xml: Remove.
4040         * features/i386/amd64-mpx-linux.xml: Remove.
4041         * features/i386/amd64-mpx.xml: Remove.
4042         * features/i386/amd64.xml: Remove.
4043         * features/i386/i386-avx-avx512-linux.xml: Remove.
4044         * features/i386/i386-avx-avx512.xml: Remove.
4045         * features/i386/i386-avx-linux.xml: Remove.
4046         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4047         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4048         * features/i386/i386-avx-mpx-linux.xml: Remove.
4049         * features/i386/i386-avx-mpx.xml: Remove.
4050         * features/i386/i386-avx.xml: Remove.
4051         * features/i386/i386-linux.xml: Remove.
4052         * features/i386/i386-mmx-linux.xml: Remove.
4053         * features/i386/i386-mmx.xml: Remove.
4054         * features/i386/i386-mpx-linux.xml: Remove.
4055         * features/i386/i386-mpx.xml: Remove.
4056         * features/i386/i386.xml: Remove.
4057         * features/i386/x32-avx-avx512-linux.xml: Remove.
4058         * features/i386/x32-avx-linux.xml: Remove.
4059         * features/i386/x32-linux.xml: Remove.
4060
4061 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4062
4063         * regformats/aarch64.dat: Remove.
4064         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4065         * regformats/i386/amd64-avx-linux.dat: Remove.
4066         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4067         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4068         * regformats/i386/amd64-linux.dat: Remove.
4069         * regformats/i386/amd64-mpx-linux.dat: Remove.
4070         * regformats/i386/amd64.dat: Remove.
4071         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4072         * regformats/i386/i386-avx-linux.dat: Remove.
4073         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4074         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4075         * regformats/i386/i386-linux.dat: Remove.
4076         * regformats/i386/i386-mmx-linux.dat: Remove.
4077         * regformats/i386/i386-mpx-linux.dat: Remove.
4078         * regformats/i386/i386.dat: Remove.
4079         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4080         * regformats/i386/x32-avx-linux.dat: Remove.
4081         * regformats/i386/x32-linux.dat: Remove.
4082
4083 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4084
4085         * aarch64-tdep.c: Remove xml self tests.
4086         * amd64-linux-tdep.c: Likewise.
4087         * amd64-tdep.c: Likewise.
4088         * i386-linux-tdep.c: Likewise.
4089         * i386-tdep.c: Likewise.
4090
4091 2019-07-03  Pedro Alves  <palves@redhat.com>
4092
4093         PR cli/24732
4094         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4095         (pipe_cmd_option_defs): New.
4096         (make_pipe_cmd_options_def_group): New.
4097         (pipe_command): Use gdb::option::process_options.
4098         (pipe_command_completer): New function.
4099         (_initialize_cli_cmds): Install completer for "pipe" command.
4100
4101 2019-07-03  Pedro Alves  <palves@redhat.com>
4102
4103         * cli/cli-option.c (union option_value) <string>: New field.
4104         (struct option_def_and_value): Add ctor, move ctor, dtor and
4105         use DISABLE_COPY_AND_ASSIGN.
4106         (option_def_and_value::clear_value): New.
4107         (parse_option, save_option_value_in_ctx, get_val_type_str)
4108         (add_setshow_cmds_for_options): Handle var_string.
4109         * cli-option.h (union option_def::var_address) <string>: New
4110         field.
4111         (struct string_option_def): New.
4112         * maint-test-options.c (struct test_options_opts): Add default
4113         ctor and use DISABLE_COPY_AND_ASSIGN.
4114         <string_opt>: New field.
4115         (test_options_opts::~test_options_opts): New.
4116         (test_options_opts::dump): Also dump "-string".
4117         (test_options_option_defs): Install "string.
4118
4119 2019-07-03  Pedro Alves  <palves@redhat.com>
4120
4121         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4122         option_value with a null enumeration.
4123         (complete_options): Save the option values in the context.
4124         (save_option_value_in_ctx): New, factored out from ...
4125         (process_options): ... here.
4126         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4127         of the function.
4128         * maint-test-options.c (test_options_opts::dump): New, factored
4129         out from ...
4130         (maintenance_test_options_command_mode): ... here.
4131         (maintenance_test_options_command_completion_result): Delete.
4132         (maintenance_test_options_command_completion_text): Update
4133         comment.
4134         (maintenance_show_test_options_completion_result): Change
4135         prototype.  Just print
4136         maintenance_test_options_command_completion_text.
4137         (save_completion_result): New.
4138         (maintenance_test_options_completer_mode): Pass options context to
4139         complete_options, and then save a dump.
4140         (_initialize_maint_test_options): Use add_cmd to install "maint
4141         show test-options-completion-result".
4142
4143 2019-07-03  Pedro Alves  <palves@redhat.com>
4144
4145         * NEWS (New commands): Mention "with" and "maint with".
4146         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4147         (with_command, with_command_completer): New.
4148         (pipe_command): Adjust to new repeat_previous
4149         interface.
4150         (_initialize_cli_cmds): Install the "with" command and its "w"
4151         alias.
4152         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4153         declarations.
4154         * cli/cli-setshow.c (parse_cli_var_uinteger)
4155         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4156         argument strings for all var_types.
4157         (get_setshow_command_value_string): New, factored out from ...
4158         (do_show_command): ... this.
4159         * cli/cli-setshow.h: Include <string>.
4160         (get_setshow_command_value_string): Declare.
4161         * command.h (repeat_previous): Now returns const char *.  Adjust
4162         comment.
4163         * maint.c: Include "cli/cli-cmds.h".
4164         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4165         (_initialize_maint_cmds): Register the "maintenance with" command.
4166         * top.c (repeat_previous): Move bits from pipe_command here:
4167         Return the saved command line, if any; error out if there's no
4168         command to relaunch.
4169
4170 2019-07-03  Pedro Alves  <palves@redhat.com>
4171
4172         * NEWS (New commands): Mention "maint set/show test-settings"
4173         instead of "maint test-settings".
4174         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4175         (maintenance_test_settings_set_list): Rename to ...
4176         (maintenance_set_test_settings_list): ... this.
4177         (maintenance_test_settings_show_list): Rename to  ...
4178         (maintenance_show_test_settings_list): ... this.
4179         (maintenance_test_settings_cmd): Delete.
4180         (maintenance_test_settings_set_cmd): ...
4181         (maintenance_set_test_settings_cmd): ... this.
4182         (maintenance_test_settings_show_cmd): ...
4183         (maintenance_show_test_settings_cmd): ... this.
4184         (maintenance_test_settings_show_value_cmd):
4185         (maintenance_show_test_settings_value_cmd): ... this.
4186         (_initialize_maint_test_settings): No longer install the "maint
4187         test-settings" prefix command.  Rename "maint test-settings set"
4188         to "maint set test-settings", and "maint test-settings show" to
4189         "maint show test-settings".  Adjust all subcommands.
4190
4191 2019-07-03  Pedro Alves  <palves@redhat.com>
4192
4193         * maint-test-settings.c: Fix file's intro comment.  Replace all
4194         references to "test-options" with references to "test-settings",
4195         in comments.
4196
4197 2019-07-03  Pedro Alves  <palves@redhat.com>
4198
4199         * maint-test-settings.c (maintenance_test_settings_xxx)
4200         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4201         New.
4202         (maintenance_test_settings_enums): Use them.
4203         (maintenance_test_settings_enum): Default to
4204         maintenance_test_settings_xxx.
4205         (_initialize_maint_test_settings): Initialize
4206         MAINTENANCE_TEST_SETTINGS_FILENAME.
4207
4208 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4209
4210         * breakpoint.h (remove_breakpoints_inf): Change return type to
4211         void, move function documentation here.
4212         * breakpoint.c (remove_breakpoints_inf): Change return type to
4213         void, move function documentation to header.
4214
4215 2019-07-02  Pedro Alves  <palves@redhat.com>
4216
4217         * NEWS (Completion improvements): Mention "info threads".
4218         * thread.c (struct info_threads_opts, info_threads_option_defs)
4219         (make_info_threads_options_def_group): New.
4220         (info_threads_command): Use gdb::option::process_options.
4221         (info_threads_command_completer): New.
4222         (_initialize_thread): Use gdb::option::build_help to build the
4223         help text for "info threads".
4224
4225 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4226
4227         * defs.h (generic_load): Move from here...
4228         * symfile.h (generic_load): ... to here.  Rename name parameter
4229         to args.
4230         * symfile.c (generic_load): Add comment.
4231
4232 2019-07-01  Tom Tromey  <tromey@adacore.com>
4233
4234         * dwarf2read.c
4235         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4236         declaration of without_params.  Fix formatting.
4237
4238 2019-07-01  Tom Tromey  <tromey@adacore.com>
4239
4240         * ada-exp.y (find_primitive_type): Update.
4241         * ada-lang.h (ada_lookup_symbol): Update.
4242         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4243         parameter.
4244         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4245
4246 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4247
4248         PR breakpoints/24541
4249         * gdbarch.c: Regenerate.
4250         * gdbarch.h: Regenerate.
4251         * gdbarch.sh: Add 'stap_adjust_register'.
4252         * i386-tdep.c: Include '<unordered_set>'.
4253         (i386_stap_adjust_register): New function.
4254         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4255         * stap-probe.c (stap_parse_register_operand): Call
4256         'gdbarch_stap_adjust_register'.
4257
4258 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4259
4260         PR python/24742
4261         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4262         * python/python.c (do_start_initialization): Use 'xmalloc'
4263         instead of 'PyMem_Malloc'.
4264
4265 2019-06-28  Tom Tromey  <tromey@adacore.com>
4266
4267         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4268         for Ada.
4269
4270 2019-06-27  Tom Tromey  <tromey@adacore.com>
4271
4272         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4273         objfile_key.
4274         (arm_find_mapping_symbol, arm_record_special_symbol)
4275         (_initialize_arm_tdep): Update.
4276         (arm_objfile_data_free): Remove.
4277
4278 2019-06-27  Tom Tromey  <tromey@adacore.com>
4279
4280         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4281         to cp_print_static_field.
4282
4283 2019-06-26  Tom Tromey  <tromey@adacore.com>
4284
4285         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4286         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4287         declare.
4288
4289 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4290
4291         * features/aarch64-core.c (create_feature_aarch64_core):
4292         Regenerate.
4293         * features/aarch64-core.xml: Add cpsr flags.
4294
4295 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4296
4297         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4298         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4299
4300 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4301
4302         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4303         field.
4304         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4305         use.
4306         (arm_record_special_symbol): Don't insert new symbol in sorted
4307         position, push it at the end.
4308
4309 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4310
4311         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4312         (arm_mapping_symbol_s): Remove.
4313         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4314         (arm_mapping_symbol_vec): New typedef.
4315         (struct arm_per_objfile): Add constructor.
4316         <section_maps>: Change type to
4317         std::unique_ptr<arm_mapping_symbol_vec[]>.
4318         (arm_compare_mapping_symbols): Remove.
4319         (arm_find_mapping_symbol): Adjust to section_maps type change.
4320         (arm_objfile_data_free): Call delete on arm_per_objfile.
4321         (arm_record_special_symbol): Adjust to section_maps type change.
4322         Allocate arm_per_objfile with new.
4323
4324 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4325
4326         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4327         with the command prefix.
4328
4329 2019-06-25  Tom Tromey  <tom@tromey.com>
4330
4331         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4332         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4333
4334 2019-06-25  Tom Tromey  <tom@tromey.com>
4335
4336         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4337         type.
4338         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4339         protected.
4340
4341 2019-06-25  Tom Tromey  <tom@tromey.com>
4342
4343         * tui/tui-winsource.c
4344         (tui_source_window_base::set_is_exec_point_at): Add check against
4345         LOA_ADDRESS.
4346
4347 2019-06-25  Tom Tromey  <tom@tromey.com>
4348
4349         * tui/tui-source.c (tui_set_source_content): Don't check before
4350         xfree.
4351         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4352
4353 2019-06-25  Tom Tromey  <tom@tromey.com>
4354
4355         * tui/tui-winsource.h (tui_update_source_window_as_is)
4356         (tui_alloc_source_buffer, tui_line_is_displayed)
4357         (tui_addr_is_displayed): Change type of win_info.
4358         * tui/tui-winsource.c (tui_update_source_window_as_is)
4359         (tui_clear_source_content, tui_show_source_line)
4360         (tui_show_source_content, tui_source_window_base::refill)
4361         (tui_source_window_base::set_is_exec_point_at)
4362         (tui_source_window_base::set_is_exec_point_at)
4363         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4364         (tui_alloc_source_buffer, tui_line_is_displayed)
4365         (tui_addr_is_displayed): Change type of win_info.  Update.
4366         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4367         (tui_source_window_base::do_make_visible_with_new_height):
4368         Update.
4369         * tui/tui-source.c (tui_set_source_content)
4370         (tui_set_source_content_nil)
4371         (tui_source_window::do_scroll_vertical): Update.
4372         * tui/tui-layout.c (show_layout): Update.
4373         * tui/tui-disasm.c (tui_set_disassem_content)
4374         (tui_disasm_window::do_scroll_vertical): Update.
4375         * tui/tui-data.h (tui_win_content): Remove.
4376         (struct tui_gen_win_info) <content, content_size>: Remove.
4377         (struct tui_source_element): Add initializers and destructor.
4378         (union tui_which_element, struct tui_win_element): Remove.
4379         (struct tui_source_window_base) <content>: New field.
4380         (struct tui_data_window): Remove destructor.
4381         (tui_alloc_content, tui_free_win_content)
4382         (tui_free_all_source_wins_content): Don't declare.
4383         * tui/tui-data.c (tui_initialize_static_data): Update.
4384         (init_content_element, tui_alloc_content): Remove.
4385         (~tui_gen_win_info): Update.
4386         (~tui_data_window, tui_free_all_source_wins_content)
4387         (tui_free_win_content, free_content, free_content_elements):
4388         Remove.
4389
4390 2019-06-25  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-winsource.h (tui_clear_source_content)
4393         (tui_erase_source_content, tui_show_source_content): Change type
4394         of win_info.
4395         * tui/tui-winsource.c (tui_clear_source_content)
4396         (tui_erase_source_content, tui_show_source_content): Change type
4397         of win_info.
4398         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4399         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4400         win_info.
4401         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4402         win_info.
4403         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4404
4405 2019-06-25  Tom Tromey  <tom@tromey.com>
4406
4407         * tui/tui-winsource.c (tui_clear_source_content)
4408         (tui_source_window_base::set_is_exec_point_at): Update.
4409         * tui/tui-source.c (tui_set_source_content_nil): Update.
4410         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4411         a bool.
4412         * tui/tui-data.c (init_content_element): Update.
4413
4414 2019-06-25  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4417         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4418         * tui/tui-layout.c (init_and_make_win): Update.
4419         * tui/tui.h (enum tui_win_type): Update.
4420         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4421         tui_win_is_auxillary.
4422         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4423         tui_win_is_auxillary.
4424
4425 2019-06-25  Tom Tromey  <tom@tromey.com>
4426
4427         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4428         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4429         (tui_delete_data_content_windows, tui_display_all_data)
4430         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4431         Update.
4432         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4433         * tui/tui-regs.c (tui_last_regs_line_no)
4434         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4435         (tui_show_registers): Update.
4436         (tui_show_register_group): Return void.  Update.
4437         (tui_display_registers_from, tui_display_reg_element_at_line)
4438         (tui_display_registers_from_line, tui_check_register_values):
4439         Update.
4440         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4441         member.
4442         (struct tui_data_window) <regs_content>: Now a std::vector.
4443         <regs_content_count>: Remove.
4444         (tui_add_content_elements, tui_free_data_content): Don't declare.
4445         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4446         (init_content_element): Remove DATA_WIN case.  Add assert.
4447         (tui_add_content_elements): Remove.
4448         (tui_data_window): Update.
4449         (tui_free_data_content): Remove.
4450         (free_content_elements): Remove DATA_WIN case.
4451
4452 2019-06-25  Tom Tromey  <tom@tromey.com>
4453
4454         * tui/tui-data.c (tui_data_item_window): Update.
4455         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4456         * tui/tui-windata.c (tui_display_all_data)
4457         (tui_display_data_from_line): Update.
4458         (tui_check_data_values): Remove.
4459         * tui/tui-regs.c (tui_show_register_group)
4460         (tui_display_reg_element_at_line): Update.
4461         * tui/tui-hooks.c (tui_register_changed)
4462         (tui_refresh_frame_and_register_information): Call
4463         tui_check_register_values.
4464         * tui/tui-data.h (struct tui_data_window) <data_content,
4465         data_content_count, data_type>: Remove.
4466         (enum tui_data_type): Remove.
4467
4468         * tui/tui-data.c (tui_data_window::clear_detail)
4469         (~tui_data_window): Update.
4470
4471 2019-06-25  Tom Tromey  <tom@tromey.com>
4472
4473         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4474         declare.
4475         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4476         Rename from tui_first_data_item_displayed.  Update.
4477         (tui_data_window::refresh_all)
4478         (tui_data_window::do_scroll_vertical): Update.
4479         * tui/tui-data.h (struct tui_data_window)
4480         <first_data_item_displayed>: Declare new method.
4481
4482 2019-06-25  Tom Tromey  <tom@tromey.com>
4483
4484         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4485         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4486         contents...
4487         (tui_initialize_static_data): ...here.
4488
4489 2019-06-25  Tom Tromey  <tom@tromey.com>
4490
4491         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4492         (tui_display_registers_from, tui_check_register_values): Update.
4493         (tui_display_register): Remove win_info parameter; update.
4494         (tui_get_register): Change type of parameters.
4495         * tui/tui-data.h (struct tui_data_element): Remove.
4496         (union tui_which_element) <data>: Remove.
4497         <data_window>: Change type.
4498         (struct tui_data_item_window): New.
4499         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4500         case.  Add assert.
4501         (~tui_data_item_window): New destructor.
4502         (free_content_elements): Remove DATA_ITEM_WIN case.
4503
4504 2019-06-25  Tom Tromey  <tom@tromey.com>
4505
4506         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4507         Remove.
4508
4509 2019-06-25  Tom Tromey  <tom@tromey.com>
4510
4511         * tui/tui-data.h (struct tui_command_element): Remove.
4512         (union tui_which_element) <command>: Remove.
4513         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4514         assert.
4515         (free_content_elements): Remove CMD_WIN case.
4516
4517 2019-06-25  Tom Tromey  <tom@tromey.com>
4518
4519         * tui/tui-layout.c (tui_set_layout): Update.
4520         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4521         * tui/tui-data.c (layout_def): Update.
4522
4523 2019-06-25  Tom Tromey  <tom@tromey.com>
4524
4525         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4526         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4527         (tui_source_window_base::set_new_height): Update.
4528         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4529         Update.
4530         (tui_set_locator_fullname, tui_set_locator_info)
4531         (tui_show_frame_info): Update.
4532         * tui/tui-source.c (tui_set_source_content)
4533         (tui_source_is_displayed): Update.
4534         * tui/tui-layout.c (show_source_disasm_command, show_data)
4535         (show_source_or_disasm_and_command): Update.
4536         * tui/tui-disasm.c (tui_set_disassem_content)
4537         (tui_get_begin_asm_address): Update.
4538         * tui/tui-data.h (struct tui_locator_element): Remove.
4539         (union tui_which_element) <locator>: Remove.
4540         (struct tui_locator_window): New.
4541         (tui_locator_win_info_ptr): Change return type.
4542         * tui/tui-data.c (_locator): Change type.
4543         (tui_locator_win_info_ptr): Change return type.
4544         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4545         (tui_alloc_content): Add assert.
4546
4547 2019-06-25  Tom Tromey  <tom@tromey.com>
4548
4549         * tui/tui-winsource.c
4550         (tui_exec_info_window::maybe_allocate_content): New method.
4551         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4552         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4553         (make_source_or_disasm_window): Add cast.
4554         * tui/tui-data.h (union tui_which_element) <simple_string>:
4555         Remove.
4556         (struct tui_source_info): New.
4557         (struct tui_source_window_base) <execution_info>: Change type.
4558         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4559         case, and add assert.
4560         (tui_alloc_content): Add assert.
4561
4562 2019-06-25  Tom Tromey  <tom@tromey.com>
4563
4564         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4565         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4566         * tui/tui-data.c (tui_alloc_win_info): Remove.
4567
4568 2019-06-25  Tom Tromey  <tom@tromey.com>
4569
4570         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4571         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4572         can_highlight.
4573
4574 2019-06-25  Tom Tromey  <tom@tromey.com>
4575
4576         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4577         make_visible_with_new_height method.
4578         (tui_win_info::make_visible_with_new_height): New method.
4579         (tui_source_window_base::do_make_visible_with_new_height)
4580         (tui_data_window::do_make_visible_with_new_height)
4581         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4582         (make_visible_with_new_height): Remove.
4583         (tui_resize_all, tui_adjust_win_heights): Use
4584         make_visible_with_new_height method.
4585         * tui/tui-data.h (struct tui_win_info)
4586         <do_make_visible_with_new_height, make_visible_with_new_height>:
4587         New methods.
4588         (struct tui_source_window_base, struct tui_data_window)
4589         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4590         methods.
4591
4592 2019-06-25  Tom Tromey  <tom@tromey.com>
4593
4594         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4595         method.
4596         (update_tab_width): Call update_tab_width method.
4597         * tui/tui-data.h (struct tui_win_info)
4598         (struct tui_source_window_base) <update_tab_width>: New methods.
4599
4600 2019-06-25  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4603         parameter.
4604         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4605         parameter.
4606         (tui_gen_win_info::make_visible): Update.
4607         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4608         parameter.
4609         * tui/tui-data.h (enum tui_box): New enum.
4610         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4611
4612 2019-06-25  Tom Tromey  <tom@tromey.com>
4613
4614         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4615         init_and_make_win for EXEC_INFO_WIN.
4616         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4617         longer inline.
4618         (struct tui_win_info) <~tui_win_info>: Inline.
4619         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4620         Don't declare.
4621         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4622         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4623         Remove.
4624         (tui_initialize_static_data): Update.
4625         (~tui_gen_win_info): Handle more cleanup here.
4626         (~tui_source_window_base): Delete "execution_info".
4627         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4628
4629 2019-06-25  Tom Tromey  <tom@tromey.com>
4630
4631         * tui/tui-layout.c (make_command_window): Don't set
4632         can_highlight.
4633         (show_source_disasm_command): Call the reset method.
4634         (show_data): Don't set can_highlight.  Call the reset method.
4635         (tui_gen_win_info::reset): Rename from init_gen_win_info
4636         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4637         (show_source_or_disasm_and_command): Call the reset method.
4638         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4639         (struct tui_cmd_window): Set can_highlight.
4640
4641 2019-06-25  Tom Tromey  <tom@tromey.com>
4642
4643         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4644         from make_visible.
4645         (tui_make_visible, tui_make_invisible): Rewrite.
4646         (tui_win_info::make_visible): Remove.
4647         (tui_source_window_base::make_visible): Update.
4648         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4649         method.  Moved from...
4650         (struct tui_win_info) <make_visible>: ...here.
4651
4652 2019-06-25  Tom Tromey  <tom@tromey.com>
4653
4654         * tui/tui-winsource.c
4655         (tui_source_window_base::do_scroll_horizontal): Remove direction
4656         parameter.
4657         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4658         direction parameter.
4659         * tui/tui-win.c (tui_win_info::forward_scroll)
4660         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4661         (tui_win_info::right_scroll): Update.
4662         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4663         direction parameter.
4664         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4665         direction parameter.
4666         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4667         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4668         Remove direction parameter.
4669         (struct tui_source_window_base, struct tui_source_window)
4670         (struct tui_disasm_window, struct tui_data_window)
4671         (struct tui_cmd_window): Update.
4672
4673 2019-06-25  Tom Tromey  <tom@tromey.com>
4674
4675         * tui/tui-winsource.h (tui_set_exec_info_content)
4676         (tui_show_exec_info_content, tui_erase_exec_info_content)
4677         (tui_clear_exec_info_content, tui_update_exec_info): Change
4678         argument to tui_source_window_base.
4679         * tui/tui-winsource.c (tui_set_exec_info_content)
4680         (tui_show_exec_info_content, tui_erase_exec_info_content)
4681         (tui_clear_exec_info_content, tui_update_exec_info): Change
4682         argument to tui_source_window_base.
4683
4684 2019-06-25  Tom Tromey  <tom@tromey.com>
4685
4686         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4687         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4688
4689 2019-06-25  Tom Tromey  <tom@tromey.com>
4690
4691         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4692         check.
4693
4694 2019-06-25  Tom Tromey  <tom@tromey.com>
4695
4696         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4697         type to void.
4698         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4699         type to void.
4700         * tui/tui-source.c (tui_set_source_content): Update.
4701         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4702
4703 2019-06-25  Tom Tromey  <tom@tromey.com>
4704
4705         * tui/tui-win.c (window_name_completer, tui_set_focus)
4706         (tui_all_windows_info): Use name method.
4707         * tui/tui-data.h (struct tui_gen_win_info)
4708         (struct tui_source_window, struct tui_disasm_window)
4709         (struct tui_data_window, struct tui_cmd_window) <name>: New
4710         method.
4711         (tui_win_name): Don't declare.
4712         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4713         (tui_win_name): Remove.
4714
4715 2019-06-25  Tom Tromey  <tom@tromey.com>
4716
4717         * tui/tui-winsource.h (tui_update_source_window)
4718         (tui_update_source_window_as_is): Change parameter type.
4719         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4720         to be a tui_source_window_base.
4721         (tui_update_source_window_as_is): Likewise.
4722         * tui/tui-win.c (make_visible_with_new_height): Update.
4723
4724 2019-06-25  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-winsource.c (tui_erase_source_content)
4727         (tui_show_source_content, tui_show_exec_info_content)
4728         (tui_erase_exec_info_content): Use refresh_window method.
4729         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4730         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4731         from tui_refresh_win.
4732         (tui_data_window::refresh_window): New method.
4733         (tui_win_info::refresh, tui_source_window_base::refresh)
4734         (tui_refresh_all): Use refresh_window method.
4735         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4736         method.
4737         * tui/tui-regs.c (tui_display_register): Call refresh_window
4738         method.
4739         * tui/tui-layout.c (show_source_disasm_command)
4740         (show_source_or_disasm_and_command): Call refresh_window method.
4741         * tui/tui-data.h (struct tui_gen_win_info)
4742         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4743         New method.
4744
4745 2019-06-25  Tom Tromey  <tom@tromey.com>
4746
4747         * tui/tui.c (tui_rl_other_window, tui_enable)
4748         (tui_is_window_visible, tui_get_command_dimension): Update.
4749         * tui/tui-winsource.c (tui_update_source_window_as_is)
4750         (tui_clear_source_content, tui_erase_source_content)
4751         (tui_show_source_line, tui_source_window_base::refill)
4752         (tui_source_window_base::do_scroll_horizontal)
4753         (tui_source_window_base::set_is_exec_point_at)
4754         (tui_update_breakpoint_info, tui_set_exec_info_content)
4755         (tui_alloc_source_buffer, tui_line_is_displayed)
4756         (tui_addr_is_displayed): Update.
4757         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4758         (tui_check_and_display_highlight_if_needed)
4759         (tui_win_info::make_visible, tui_win_info::refresh)
4760         (tui_refresh_all): Update.
4761         * tui/tui-windata.c (tui_first_data_item_displayed)
4762         (tui_delete_data_content_windows, tui_erase_data_content)
4763         (tui_display_all_data, tui_data_window::refresh_all)
4764         (tui_check_data_values): Update.
4765         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4766         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4767         (tui_win_info::backward_scroll, tui_refresh_all_win)
4768         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4769         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4770         (tui_source_window_base::set_new_height)
4771         (tui_data_window::set_new_height)
4772         (make_invisible_and_set_new_height)
4773         (make_visible_with_new_height, new_height_ok)
4774         (parse_scrolling_args): Update.
4775         * tui/tui-stack.c (tui_show_frame_info): Update.
4776         * tui/tui-source.c (tui_set_source_content)
4777         (tui_set_source_content_nil, tui_source_is_displayed)
4778         (tui_source_window::do_scroll_vertical): Update.
4779         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4780         (tui_display_registers_from, tui_display_reg_element_at_line)
4781         (tui_check_register_values, tui_reg_command): Update.
4782         * tui/tui-layout.c (tui_default_win_height)
4783         (show_source_disasm_command, show_data, init_and_make_win)
4784         (show_source_or_disasm_and_command): Update.
4785         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4786         (tui_redisplay_readline, tui_mld_flush)
4787         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4788         (tui_getc): Update.
4789         * tui/tui-disasm.c (tui_set_disassem_content)
4790         (tui_disasm_window::do_scroll_vertical): Update.
4791         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4792         Now virtual.
4793         (struct tui_win_info): Derive from tui_gen_win_info.
4794         <~tui_win_info>: Mark as override.
4795         <generic>: Remove member.
4796         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4797         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4798         (~tui_data_window, ~tui_win_info)
4799         (tui_free_all_source_wins_content): Update.
4800         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4801
4802 2019-06-25  Tom Tromey  <tom@tromey.com>
4803
4804         * tui/tui-layout.c (init_and_make_win): Use new.
4805         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4806         destructor, initializers.
4807         (tui_alloc_generic_win_info): Don't declare.
4808         * tui/tui-data.c (_locator): Add argument to constructor.
4809         (source_win, disasm_win): New globals.
4810         (exec_info): Remove.
4811         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4812         Update.
4813         (tui_alloc_generic_win_info): Remove.
4814         (init_content_element): Use new.
4815         (tui_win_info::tui_win_info): Update.
4816         (free_content_elements) <case DATA_WIN>: Use delete.
4817
4818 2019-06-25  Tom Tromey  <tom@tromey.com>
4819
4820         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4821         * tui/tui-windata.c (tui_first_data_item_displayed)
4822         (tui_delete_data_content_windows): Update.
4823         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4824         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4825         (tui_display_registers_from, tui_check_register_values): Update.
4826         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4827         pointer.
4828         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4829         window.
4830         (tui_free_data_content): Update.
4831         (free_content_elements) <case DATA_WIN>: Free the window.
4832
4833 2019-06-25  Tom Tromey  <tom@tromey.com>
4834
4835         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4836         Update.
4837         * tui/tui-layout.c (make_command_window)
4838         (show_source_disasm_command, show_data, init_and_make_win)
4839         (show_source_or_disasm_and_command): Update.
4840         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4841         method.
4842         <can_highight, is_highlighted>: Now bool.
4843         (tui_set_win_highlight): Don't declare.
4844         * tui/tui-data.c (tui_set_win_highlight): Remove.
4845
4846 2019-06-25  Tom Tromey  <tom@tromey.com>
4847
4848         * tui/tui-wingeneral.c (make_visible): Remove check of window
4849         type.
4850
4851 2019-06-25  Tom Tromey  <tom@tromey.com>
4852
4853         * tui/tui-win.c (tui_win_info::max_height)
4854         (tui_cmd_window::max_height): New methods.
4855         (new_height_ok): Call max_height.
4856         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4857         <max_height>: New method.
4858
4859 2019-06-25  Tom Tromey  <tom@tromey.com>
4860
4861         * tui/tui-win.c (tui_source_window_base::set_new_height)
4862         (tui_data_window::set_new_height): New methods.
4863         (make_invisible_and_set_new_height): Call set_new_height method.
4864         * tui/tui-data.h (struct tui_win_info)
4865         (struct tui_source_window_base, struct tui_data_window)
4866         <set_new_height>: New method.
4867
4868 2019-06-25  Tom Tromey  <tom@tromey.com>
4869
4870         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4871         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4872         tui_refresh_data_win.
4873         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4874         method.
4875         (tui_refresh_all_win): Call the refresh_all method.
4876         (tui_set_focus): Likewise.
4877         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4878         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4879         Likewise.
4880
4881 2019-06-25  Tom Tromey  <tom@tromey.com>
4882
4883         * tui/tui-winsource.h (tui_refill_source_window)
4884         (tui_set_is_exec_point_at): Don't declare.
4885         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4886         (tui_source_window_base::refill): Rename from
4887         tui_refill_source_window.
4888         (tui_source_window_base::do_scroll_horizontal): Update.
4889         (tui_source_window_base::set_is_exec_point_at): Rename from
4890         tui_set_is_exec_point_at.
4891         (tui_update_all_breakpoint_info): Update.
4892         * tui/tui-stack.c (tui_show_frame_info): Update.
4893         * tui/tui-layout.c (show_data): Add cast.
4894         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4895         * tui/tui-data.h (struct tui_source_window_base) <refill,
4896         set_is_exec_point_at>: New methods.
4897         (tui_source_windows, tui_add_to_source_windows): Update types.
4898         (tui_add_to_source_windows): Remove redundant declaration.
4899         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4900         (tui_source_windows): Change return type.
4901         (tui_clear_source_windows_detail): Update.
4902         (tui_add_to_source_windows): Change type of parameter.
4903         (tui_free_all_source_wins_content): Update.
4904
4905 2019-06-25  Tom Tromey  <tom@tromey.com>
4906
4907         * tui/tui-wingeneral.c (tui_win_info::refresh)
4908         (tui_source_window_base::refresh): New methods.
4909         (tui_refresh_all): Call the refresh method.
4910         * tui/tui-data.h (struct tui_win_info)
4911         (struct tui_source_window_base) <refresh>: New method.
4912
4913 2019-06-25  Tom Tromey  <tom@tromey.com>
4914
4915         * tui/tui.h (tui_is_window_visible): Return bool.
4916         * tui/tui.c (tui_is_window_visible): Return bool.
4917         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4918         (tui_make_visible, tui_make_invisible)
4919         (tui_win_info::make_visible)
4920         (tui_source_window_base::make_visible, make_all_visible)
4921         (tui_make_all_visible, tui_make_all_invisible): Update.
4922         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4923         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4924         bool.
4925         (struct tui_win_info, struct tui_source_window_base)
4926         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4927         * tui/tui-data.c (tui_init_generic_part): Update.
4928
4929 2019-06-25  Tom Tromey  <tom@tromey.com>
4930
4931         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4932         (tui_source_window_base::make_visible): New methods.
4933         (make_all_visible): Make method call.
4934         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4935         (struct tui_source_window_base, struct tui_cmd_window): Override
4936         make_visible.
4937         (tui_win_is_source_type): Don't declare.
4938         * tui/tui-data.c (tui_win_is_source_type): Remove.
4939
4940 2019-06-25  Tom Tromey  <tom@tromey.com>
4941
4942         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4943         NULL check.
4944
4945 2019-06-25  Tom Tromey  <tom@tromey.com>
4946
4947         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4948         Inline constructor.  Add initializers for members.
4949         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4950         constructors; now inline in class.
4951
4952 2019-06-25  Tom Tromey  <tom@tromey.com>
4953
4954         * tui/tui-regs.c (tui_show_registers): Update.
4955         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4956         bool.
4957         * tui/tui-data.c (tui_data_window::clear_detail)
4958         (tui_data_window): Update.
4959
4960 2019-06-25  Tom Tromey  <tom@tromey.com>
4961
4962         * tui/tui-windata.c (tui_display_all_data)
4963         (tui_display_data_from_line, tui_display_data_from)
4964         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4965         Update.
4966         * tui/tui-regs.c (tui_last_regs_line_no)
4967         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4968         (tui_show_registers, tui_show_register_group)
4969         (tui_display_registers_from, tui_display_reg_element_at_line)
4970         (tui_display_registers_from_line, tui_check_register_values)
4971         (tui_reg_next, tui_reg_prev): Update.
4972         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4973         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4974         tui_data_window.
4975         (struct tui_win_info) <detail>: Remove.  Add new fields from
4976         tui_data_info.
4977         (TUI_DATA_WIN): Add cast.
4978         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4979         (~tui_data_window): Simplify.
4980
4981 2019-06-25  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-layout.c (show_source_disasm_command)
4984         (show_source_or_disasm_and_command): Update.
4985         * tui/tui-io.c (update_cmdwin_start_line)
4986         (tui_redisplay_readline): Update.
4987         * tui/tui-data.h (struct tui_command_info): Remove.
4988         (struct tui_win_info) <detail>: Remove command_info member.
4989         (struct tui_data_window) <start_line>: New member, from
4990         tui_command_info.
4991         (TUI_CMD_WIN): Add casts.
4992
4993 2019-06-25  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-winsource.c (tui_update_source_window)
4996         (tui_refill_source_window)
4997         (tui_source_window_base::do_scroll_horizontal)
4998         (tui_update_breakpoint_info, tui_set_exec_info_content)
4999         (tui_show_exec_info_content, tui_erase_exec_info_content)
5000         (tui_clear_exec_info_content): Update.
5001         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5002         Update.
5003         * tui/tui-win.c (make_invisible_and_set_new_height)
5004         (make_visible_with_new_height): Update.
5005         * tui/tui-source.c (tui_set_source_content)
5006         (tui_show_symtab_source): Update.
5007         * tui/tui-layout.c (extract_display_start_addr)
5008         (show_source_disasm_command, show_data)
5009         (make_source_or_disasm_window)
5010         (show_source_or_disasm_and_command): Update.
5011         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5012         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5013         "gdbarch".
5014         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5015         to tui_source_window_base.
5016         (struct tui_win_info) <detail>: Remove source_info member.
5017         (struct tui_source_window_base) <has_locator>: Inline.
5018         Move contents from tui_source_info; rename has_locator member to
5019         m_has_locator.
5020         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5021         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5022         header file.
5023         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5024         Simplify.
5025         (tui_free_all_source_wins_content): Cast to
5026         tui_source_window_base.
5027
5028 2019-06-25  Tom Tromey  <tom@tromey.com>
5029
5030         * tui/tui-win.c (make_invisible_and_set_new_height)
5031         (make_visible_with_new_height): Call has_locator method.
5032         * tui/tui-layout.c (show_source_disasm_command, show_data)
5033         (show_source_or_disasm_and_command): Update for bool change.
5034         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5035         (tui_win_info) <has_locator>: New method.
5036         (struct tui_source_window_base) <has_locator>: New method.
5037         (tui_win_has_locator): Don't declare.
5038         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5039         from tui_win_has_locator.
5040         (tui_source_window_base): Use false, not FALSE.
5041
5042 2019-06-25  Tom Tromey  <tom@tromey.com>
5043
5044         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5045         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5046         clear_detail method directly.
5047         (tui_clear_win_detail): Remove.
5048
5049 2019-06-25  Tom Tromey  <tom@tromey.com>
5050
5051         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5052         "this", not TUI_DISASM_WIN.
5053
5054 2019-06-25  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5057         declare.
5058         * tui/tui-winsource.c
5059         (tui_source_window_base::do_scroll_horizontal): Rename from
5060         tui_horizontal_source_scroll.
5061         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5062         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5063         from tui_vertical_data_scroll.
5064         * tui/tui-win.h (tui_scroll): Don't declare.
5065         * tui/tui-win.c (tui_win_info::forward_scroll)
5066         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5067         (tui_win_info::right_scroll): Rename and update.
5068         (tui_scroll_forward_command, tui_scroll_backward_command)
5069         (tui_scroll_left_command, tui_scroll_right_command): Update.
5070         (tui_scroll): Remove.
5071         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5072         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5073         from tui_vertical_source_scroll.
5074         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5075         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5076         from tui_vertical_disassem_scroll.
5077         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5078         do_scroll_horizontal>: New methods.
5079         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5080         Likewise.
5081         (struct tui_source_window_base): Add do_scroll_horizontal.
5082         (struct tui_source_window, struct tui_disasm_window): Add
5083         do_scroll_vertical.
5084         (struct tui_data_window, struct tui_cmd_window): Add
5085         do_scroll_horizontal and do_scroll_vertical.
5086         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5087
5088 2019-06-25  Tom Tromey  <tom@tromey.com>
5089
5090         * tui/tui-data.h (struct tui_source_window_base): New struct.
5091         (struct tui_source_window): Derive from tui_source_window_base.
5092         (struct tui_disasm_window): New struct.
5093         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5094         from tui_source_window::clear_detail.
5095         (tui_source_window_base): Rename from tui_source_window.
5096         (~tui_source_window_base): Rename from ~tui_source_window.
5097         (tui_alloc_win_info): Create a tui_disasm_window.
5098
5099 2019-06-25  Tom Tromey  <tom@tromey.com>
5100
5101         * tui/tui-data.h (struct tui_source_window)
5102         (struct tui_data_window): Declare destructors.
5103         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5104         destructors.
5105         (tui_win_info): Simplify.
5106
5107 2019-06-25  Tom Tromey  <tom@tromey.com>
5108
5109         * tui/tui-winsource.c (tui_display_main)
5110         (tui_update_source_windows_with_addr)
5111         (tui_update_all_breakpoint_info): Update.
5112         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5113         (new_height_ok, parse_scrolling_args): Update.
5114         * tui/tui-stack.c (tui_show_frame_info): Update.
5115         * tui/tui-data.h (struct tui_list): Remove.
5116         (tui_source_windows): Return a reference to a std::vector.
5117         * tui/tui-data.c (source_windows): Now a std::vector.
5118         (tui_source_windows): Change return type.
5119         (tui_clear_source_windows): Rewrite.
5120         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5121         (tui_free_all_source_wins_content): Rewrite.
5122
5123 2019-06-25  Tom Tromey  <tom@tromey.com>
5124
5125         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5126         (struct tui_data_window, struct tui_cmd_window): Declare
5127         clear_detail method.
5128         * tui/tui-data.c (tui_source_window::clear_detail)
5129         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5130         methods.
5131         (tui_clear_win_detail): Simplify.
5132
5133 2019-06-25  Tom Tromey  <tom@tromey.com>
5134
5135         * tui/tui-layout.c (make_source_window, make_disasm_window)
5136         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5137         Return the new window.
5138         (show_source_disasm_command, show_data)
5139         (show_source_or_disasm_and_command): Update.
5140
5141 2019-06-25  Tom Tromey  <tom@tromey.com>
5142
5143         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5144         parameter.  Return the new window.
5145         (show_source_disasm_command): Update and remove NULL check.
5146         (show_source_or_disasm_and_command): Update.
5147
5148 2019-06-25  Tom Tromey  <tom@tromey.com>
5149
5150         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5151
5152 2019-06-25  Tom Tromey  <tom@tromey.com>
5153
5154         * tui/tui-data.h (struct tui_win_info): Make constructor
5155         protected.  Make destructor virtual.  Add initializers.
5156         (tui_source_window, tui_data_window, tui_cmd_window): New
5157         classes.
5158         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5159         constructor.  Add "type" parameter.
5160         (tui_source_window, tui_data_window, tui_cmd_window): New
5161         constructors.
5162         (tui_alloc_win_info): Instantiate the appropriate subclass.
5163
5164 2019-06-25  Tom Tromey  <tom@tromey.com>
5165
5166         * tui/tui-win.c (tui_resize_all): Use delete.
5167         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5168         destructor.
5169         (tui_free_window): Don't declare.
5170         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5171         Update.
5172
5173 2019-06-25  Tom Tromey  <tom@tromey.com>
5174
5175         * tui/tui-data.h (struct tui_win_info): Add constructor.
5176         * tui/tui-data.c (tui_alloc_win_info): Use new.
5177         (tui_free_window): Use delete.
5178
5179 2019-06-22  Tom Tromey  <tom@tromey.com>
5180
5181         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5182         declare.
5183         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5184
5185 2019-06-22  Tom Tromey  <tom@tromey.com>
5186
5187         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5188         declare.
5189         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5190
5191 2019-06-22  Tom de Vries  <tdevries@suse.de>
5192
5193         * dwarf2read.c (create_addrmap_from_aranges)
5194         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5195         instead of '%zu'.
5196
5197 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5198
5199         * dwarf2read.h (dwarf2_section_info_def): Remove.
5200         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5201         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5202         std::vector<dwarf2_section_info>.
5203         (struct dwo_file) <~dwo_file>: Remove.
5204         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5205         types field.
5206         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5207         (dwarf2_read_debug_names): Likewise.
5208         (create_debug_types_hash_table): Change parameter type to
5209         array_view, adjust code accordingly.
5210         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5211         (partial_die_info::fixup): Likewise.
5212         (determine_prefix): Likewise.
5213         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5214
5215 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5216
5217         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5218         gdb_bfd_ref_ptr.
5219         <~dwo_file>: Remove call to gdb_bfd_unref.
5220         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5221         gdb_bfd_ref_ptr::get.
5222
5223 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5224
5225         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5226         type to htab_up.
5227         * dwarf2read.c (struct dwo_file): Initialize fields.
5228         <~dwo_file>: New.
5229         (free_dwo_file): Remove, move content to ~dwo_file.
5230         (struct dwo_file_deleter): Remove.
5231         (dwo_file_up>: Remove custom deleter.
5232         (free_dwo_files): Remove.
5233         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5234         dwo_files.
5235         (process_skeletonless_type_units): Call unique_ptr::get.
5236         (allocate_dwo_file_hash_table): Add deleter to created hash
5237         table.  Change return type to htab_up.
5238         (lookup_dwo_file_slot): Don't memset dwo_file, call
5239         unique_ptr::get.
5240         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5241         (create_dwo_unit_in_dwp_v2): Likewise.
5242         (open_and_init_dwo_file): Likewise.
5243         (free_dwo_file_from_slot): Remove.
5244
5245 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5246
5247         * dwarf2read.h (struct dwarf2_section_info) <readin,
5248         is_virtual>: Change type to bool.
5249         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5250         true instead of 1.
5251
5252 2019-06-19  Tom Tromey  <tom@tromey.com>
5253
5254         * tui/tui-data.h (tui_init_content_element): Don't declare.
5255
5256 2019-06-19  Tom Tromey  <tom@tromey.com>
5257
5258         * tui/tui-data.h (tui_init_win_info): Don't declare.
5259
5260 2019-06-19  Tom de Vries  <tdevries@suse.de>
5261
5262         * dwarf2read.h (abstract_to_concrete): Change type to
5263         std::unordered_map<sect_offset, std::vector<sect_offset>,
5264         gdb::hash_enum<sect_offset>>.
5265
5266 2019-06-19  Tom Tromey  <tromey@adacore.com>
5267
5268         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5269         EVAL_AVOID_SIDE_EFFECTS specially.
5270
5271 2019-06-19  Tom Tromey  <tromey@adacore.com>
5272
5273         * source-cache.c (highlighter): New global.
5274         (source_cache::get_source_lines): Create a highlighter on demand.
5275
5276 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5277
5278         * defs.h (deprecated_interactive_hook): Delete declaration.
5279         * interps.c (clear_interpreter_hooks): Remove use of
5280         deprecated_interactive_hook.
5281         * top.c (deprecated_interactive_hook): Delete definition.
5282         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5283
5284 2019-06-18  Tom de Vries  <tdevries@suse.de>
5285
5286         PR gdb/24515
5287         * dwarf2read.h (abstract_to_concrete): Change type from
5288         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5289         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5290         * dwarf2read.c (read_variable): Update.
5291         (dwarf2_fetch_die_loc_sect_off): Update.
5292
5293 2019-06-17  Tom de Vries  <tdevries@suse.de>
5294
5295         PR gdb/24617
5296         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5297         accessing parent[parent_len - 1].
5298
5299 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5300
5301         PR gdb/24364
5302         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5303         call dtrace_process_dof with NULL dof.
5304
5305 2019-06-16  Tom de Vries  <tdevries@suse.de>
5306
5307         PR gdb/24445
5308         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5309
5310 2019-06-16  Tom Tromey  <tom@tromey.com>
5311
5312         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5313         (make_all_visible): Use address of member.
5314
5315 2019-06-16  Tom Tromey  <tom@tromey.com>
5316
5317         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5318         (tui_free_window, free_content, free_content_elements): Remove
5319         unnecessary cast.
5320         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5321         cast.
5322         * tui/tui-regs.c (tui_show_register_group)
5323         (tui_display_registers_from, tui_display_reg_element_at_line):
5324         Remove unnecessary cast.
5325
5326 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5327
5328         * linux-nat.c (normal_mask): Delete.
5329         (_initialize_linux_nat): Don't initialise normal_mask.
5330
5331 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5332
5333         PR gdb/24445
5334         * dwarf-index-write.h (write_psymtabs_to_index): Add
5335         dwz_basename parameter.
5336         * dwarf-index-write.c (write_gdbindex): Move file writing to
5337         write_gdbindex_1.  Change return type void.
5338         (assert_file_size): Move up, remove filename parameter.
5339         (write_gdbindex_1): New function.
5340         (write_debug_names): Change return type to void, call
5341         assert_file_size.
5342         (struct index_wip_file): New struct.
5343         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5344         file logic to index_wip_file.  Write index for dwz file if
5345         needed.
5346         (save_gdb_index_command): Pass basename of dwz file, if present.
5347         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5348         build-id of dwz file, if present.
5349         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5350         (dwarf2_get_dwz_file): Likewise.
5351         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5352         (dwarf2_get_dwz_file): Likewise.
5353
5354 2019-06-16  Tom Tromey  <tom@tromey.com>
5355
5356         * coffread.c (process_coff_symbol): Use xstrdup.
5357         * value.c (create_internalvar): Use xstrdup.
5358
5359 2019-06-16  Tom Tromey  <tom@tromey.com>
5360
5361         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5362         * breakpoint.c (stopin_command, stopat_command)
5363         (until_break_command, decode_location_default): Remove unnecessary
5364         cast.
5365         * utils.c (subset_compare): Remove unnecessary cast.
5366         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5367         cast.
5368         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5369         cast.
5370         * infcmd.c (path_command): Remove unnecessary cast.
5371         * coffread.c (decode_type): Remove unnecessary cast.
5372         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5373         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5374         * tui/tui-stack.c (tui_show_locator_content)
5375         (tui_show_frame_info): Remove unnecessary cast.
5376         * tui/tui-win.c (tui_scroll_forward_command)
5377         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5378         (parse_scrolling_args): Remove unnecessary cast.
5379         * tui/tui-data.c (init_win_info, tui_del_window)
5380         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5381         (free_content_elements): Remove unnecessary cast.
5382         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5383         unnecessary cast.
5384         * tui/tui-source.c (tui_set_source_content)
5385         (tui_vertical_source_scroll): Remove unnecessary cast.
5386         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5387         cast.
5388         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5389         * tui/tui-regs.c (tui_display_registers_from)
5390         (tui_display_register): Remove unnecessary cast.
5391         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5392         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5393         (make_visible): Remove unnecessary cast.
5394         * tui/tui-winsource.c (tui_erase_source_content)
5395         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5396         unnecessary cast.
5397         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5398         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5399         * stabsread.c (read_type, read_array_type, read_range_type):
5400         Remove unnecessary cast.
5401         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5402         (parse_symbol, parse_type, upgrade_type, parse_external)
5403         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5404         unnecessary cast.
5405         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5406
5407 2019-06-16  Tom Tromey  <tom@tromey.com>
5408
5409         * tui/tui-data.c (tui_alloc_generic_win_info)
5410         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5411         checks.
5412
5413 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5414             Andrew Burgess  <andrew.burgess@embecosm.com>
5415
5416         * f-typeprint.c (f_print_type): Don't return early for not
5417         associated or not allocated types.
5418         (f_type_print_varspec_suffix): Add print_rank parameter and print
5419         ranks of array types in case they dangling.
5420         (f_type_print_base): Add print_rank parameter.
5421
5422 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5423
5424         * NEWS: Mention new MI commands.
5425         * break-catch-throw.c (enum exception_event_kind): Move to
5426         breakpoint.h.
5427         (print_mention_exception_catchpoint): Output text as a single
5428         message.
5429         (catch_exception_command_1): Rename to...
5430         (catch_exception_event): ...this, make non-static, update header
5431         command, and change some parameter types.
5432         (catch_catch_command): Update for changes to
5433         catch_exception_command_1.
5434         (catch_throw_command): Likewise.
5435         (catch_rethrow_command): Likewise.
5436         * breakpoint.c (enum exception_event_kind): Delete.
5437         * breakpoint.h (enum exception_event_kind): Moved here from
5438         break-catch-throw.c.
5439         (catch_exception_event): Declare.
5440         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5441         (mi_cmd_catch_throw): New function.
5442         (mi_cmd_catch_rethrow): New function.
5443         (mi_cmd_catch_catch): New function.
5444         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5445         'catch-catch' entries.
5446         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5447         (mi_cmd_catch_rethrow): Declare.
5448         (mi_cmd_catch_catch): Declare.
5449
5450 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5451
5452         * annotate.c (annotate_source_line): Change return type to void,
5453         update implementation to match.
5454         * annotate.h (annotate_source_line): Change return type to void,
5455         update header comment.
5456         * stack.c (print_frame_info): Don't change what frame information
5457         is printed based on whether annotations are on or not.
5458
5459 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5460
5461         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5462         (annotate_source): Make static.
5463         (annotate_source_line): Moved from source.c and renamed from
5464         identify_source_line.  Update the return type.
5465         * annotate.h (annotate_source): Delete declaration.
5466         (annotate_source_line): Declaration moved from source.h, and
5467         renamed from identify_source_line.  Return type updated.
5468         * source.c (identify_source_line): Moved to annotate.c and renamed
5469         to annotate_source_line.
5470         (info_line_command): Remove check of annotation_level.
5471         * source.h (identify_source_line): Move declaration to annotate.h
5472         and rename to annotate_source_line.
5473         * stack.c: Add 'annotate.h' include.
5474         (print_frame_info): Remove check of annotation_level before
5475         calling annotate_source_line.
5476
5477 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5478
5479         * source-cache.c (source_cache::get_plain_source_lines): Use
5480         open_source_file_with_line_charpos instead of just
5481         open_source_file, remove call to find_source_lines.
5482         (source_cache::get_source_lines): Likewise.
5483         * source.c (find_source_lines): Make static.
5484         (get_filename_and_charpos): Renamed into...
5485         (open_source_file_with_line_charpos): ..this along with changes to
5486         return a scoped_fd, and some other minor clean ups.
5487         (identify_source_line): Use open_source_file_with_line_charpos.
5488         (search_command_helper): Use open_source_file_with_line_charpos
5489         instead of just open_source_file, remove call to
5490         find_source_lines.
5491         * source.h (open_source_file_with_line_charpos): Declare new
5492         function.
5493         (find_source_lines): Delete declaration.
5494
5495 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5496
5497         * source.c (get_filename_and_charpos): Remove fullname
5498         parameter.
5499         (identify_source_line): Update call to get_filename_and_charpos.
5500
5501 2019-06-14  Tom Tromey  <tromey@adacore.com>
5502
5503         PR gdb/24502:
5504         * ui-style.h (skip_ansi_escape): Update comment.
5505         * ui-file.h (class no_terminal_escape_file): New class.
5506         * ui-file.c (no_terminal_escape_file::write)
5507         (no_terminal_escape_file::puts): New methods.
5508         * cli/cli-logging.c (handle_redirections): Use
5509         no_terminal_escape_file.
5510
5511 2019-06-14  Tom Tromey  <tromey@adacore.com>
5512
5513         * NEWS: Move convenience variable news above Python news.
5514
5515 2019-06-14  Tom Tromey  <tom@tromey.com>
5516
5517         * gnulib: Move directory to top-level.
5518         * configure.ac: Don't configure gnulib.
5519         * configure: Rebuild.
5520         * common/common-defs.h: Use new path to gnulib.
5521         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5522         (GNULIB_H): Remove.
5523         (INCGNU): Look in new gnulib location.
5524         (HFILES_NO_SRCDIR): Remove gnulib files.
5525         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5526         (generated_files): Remove GNULIB_H.
5527         ($(LIBGNU), all-lib): Remove targets.
5528         (distclean): Don't mention GNULIB_BUILDDIR.
5529         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5530
5531 2019-06-14  Tom Tromey  <tromey@adacore.com>
5532
5533         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5534         Warn if symbol file does not provide any symbols.
5535
5536 2019-06-14  Tom Tromey  <tromey@adacore.com>
5537
5538         * source.c (find_and_open_source): Respect basenames_may_differ.
5539
5540 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * annotate.c (annotate_breakpoints_invalid): Make use of
5543         scoped_restore_terminal_state.
5544         (annotate_frames_invalid): Likewise.
5545
5546 2019-06-14  Tom Tromey  <tromey@adacore.com>
5547
5548         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5549         allow assignment to an internalvar.
5550
5551 2019-06-14  Tom Tromey  <tromey@adacore.com>
5552
5553         * ada-lex.l: Allow "_" in attribute names.
5554
5555 2019-06-14  Tom Tromey  <tromey@adacore.com>
5556
5557         PR gdb/24653:
5558         * regcache.c (registers_changed): Don't call alloca.
5559         * top.c (execute_command): Don't call alloca.
5560
5561 2019-06-13  Pedro Alves  <palves@redhat.com>
5562
5563         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5564         'expression'.  When parsing an expression, error out if there's
5565         junk after "unlimited".
5566         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5567         (do_set_command): Adjust calls to is_unlimited_literal.
5568
5569 2019-06-13  Pedro Alves  <palves@redhat.com>
5570
5571         * compile/compile.c (make_compile_options_def_group): Add braces
5572         around array_view initializer.
5573         * thread.c (make_thread_apply_all_options_def_group)
5574         (make_thread_apply_all_options_def_group): Likewise.
5575
5576 2019-06-13  Pedro Alves  <palves@redhat.com>
5577
5578         * NEWS (New commands): Mention "maint test-options
5579         require-delimiter", "maint test-options unknown-is-error", "maint
5580         test-options unknown-is-operand" and "maint show
5581         test-options-completion-result".
5582         (New command options, command completion): New section.
5583         (Completion improvements): New section.
5584         Mention that you can abbreviate "unlimited".
5585
5586 2019-06-13  Pedro Alves  <palves@redhat.com>
5587
5588         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5589         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5590         * unittests/cli-utils-selftests.c (test_parse_flags)
5591         (test_parse_flags_qcs): Delete.
5592         (test_cli_utils): Don't call deleted functions.
5593
5594 2019-06-13  Pedro Alves  <palves@redhat.com>
5595
5596         * thread.c: Include "cli/cli-option.h".
5597         (tp_array_compar_ascending): Global.
5598         (tp_array_compar): Delete function.
5599         (tp_array_compar_ascending, tp_array_compar_descending): New
5600         functions.
5601         (ascending_option_def, qcs_flag_option_def)
5602         (thr_qcs_flags_option_defs)
5603         (make_thread_apply_all_options_def_group)
5604         (make_thread_apply_options_def_group): New.
5605         (thread_apply_all_command): Use gdb::option::process_options.
5606         (thread_apply_command_completer)
5607         (thread_apply_all_command_completer): New.
5608         (thread_apply_command): Use gdb::option::process_options.
5609         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5610         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5611         to generate help text of "thread apply".  Adjust "taas"'s help.
5612         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5613         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5614
5615 2019-06-13  Pedro Alves  <palves@redhat.com>
5616
5617         * thread.c (thread_apply_command): Check for invalid TID with
5618         isdigit instead of !isalpha.
5619
5620 2019-06-13  Pedro Alves  <palves@redhat.com>
5621
5622         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5623         (validate_flags_qcs): New.
5624         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5625         (validate_flags_qcs): Declare.
5626         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5627         (make_frame_apply_options_def_group): New.
5628         (frame_apply_command_count): Process options with
5629         gdb::option::process_options.
5630         (frame_apply_completer): New.
5631         (frame_apply_level_completer, frame_apply_all_completer)
5632         (frame_apply_completer): New.
5633         (_initialize_stack): Update help of "frame apply", "frame apply
5634         level", "frame apply all" and "faas" to mention supported options
5635         and install command completers.
5636         * stack.h (frame_apply_all_completer): Declare.
5637         * thread.c: Include "stack.h".
5638         (tfaas_command): Add "--".
5639         (_initialize_thread): Update help "tfaas" to mention supported
5640         options and install command completer.
5641
5642 2019-06-13  Pedro Alves  <palves@redhat.com>
5643
5644         * completer.c (complete_nested_command_line): New.
5645         (gdb_completion_word_break_characters_throw): Add assertion.
5646         * completer.h (complete_nested_command_line): Declare.
5647
5648 2019-06-13  Pedro Alves  <palves@redhat.com>
5649
5650         * stack.c (parse_backtrace_qualifiers): New.
5651         (backtrace_command): Use it.
5652         (backtrace_command_completer): Complete on qualifiers.
5653
5654 2019-06-13  Pedro Alves  <palves@redhat.com>
5655
5656         * frame.c: Include "cli/cli-option.h.
5657         (user_set_backtrace_options): New.
5658         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5659         Delete.
5660         (get_prev_frame): Adjust.
5661         (boolean_option_def, uinteger_option_def)
5662         (set_backtrace_option_defs): New.
5663         (_initialize_frame): Adjust and use
5664         gdb::option::add_setshow_cmds_for_options to install "set
5665         backtrace past-main" and "set backtrace past-entry".
5666         * frame.h: Include "cli/cli-option.h".
5667         (struct frame_print_options): Forward declare.
5668         (print_frame_arguments_all, print_frame_arguments_scalars)
5669         (print_frame_arguments_none): Declare.
5670         (print_entry_values): Delete declaration.
5671         (struct frame_print_options, user_frame_print_options): New.
5672         (struct set_backtrace_options): New.
5673         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5674         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5675         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5676         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5677         (list_args_or_locals): Add frame_print_options parameter.
5678         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5679         * python/py-framefilter.c (enumerate_args): Pass down
5680         USER_FRAME_PRINT_OPTIONS.
5681         * stack.c: Include "cli/cli-option.h".
5682         (print_frame_arguments_all, print_frame_arguments_scalars)
5683         (print_frame_arguments_none): Declare.
5684         (print_raw_frame_arguments, print_entry_values): Delete.
5685         (user_frame_print_options): New.
5686         (boolean_option_def, enum_option_def, frame_print_option_defs):
5687         New.
5688         (struct backtrace_cmd_options): New.
5689         (bt_flag_option_def): New.
5690         (backtrace_command_option_defs): New.
5691         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5692         (print_frame_arg, read_frame_arg, print_frame_args)
5693         (print_frame_info, print_frame): Add frame_print_options parameter
5694         and use it.
5695         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5696         (backtrace_command_1): Add frame_print_options and
5697         backtrace_cmd_options parameters and use them.
5698         (make_backtrace_options_def_group): New.
5699         (backtrace_command): Process command options with
5700         gdb::option::process_options.
5701         (backtrace_command_completer): New.
5702         (_initialize_stack): Extend "backtrace"'s help to mention
5703         supported options.  Install completer for "backtrace".
5704         Install some settings commands with add_setshow_cmds_for_options.
5705
5706 2019-06-13  Pedro Alves  <palves@redhat.com>
5707
5708         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5709         and that "set/show print raw frame-arguments" are now deprecated.
5710
5711         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5712         command.
5713         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5714         * stack.c (_initialize_stack): Install "set/show print
5715         raw-frame-arguments", and deprecate "set/show print raw
5716         frame-arguments".
5717         * valprint.c (_initialize_valprint): Deprecate "set/show print
5718         raw".
5719
5720 2019-06-13  Pedro Alves  <palves@redhat.com>
5721
5722         * compile/compile.c (struct compile_options): New.
5723         (compile_flag_option_def, compile_command_option_defs)
5724         (make_compile_options_def_group): New.
5725         (compile_file_command): Handle options with
5726         gdb::option::process_options.
5727         (compile_file_command_completer): New function.
5728         (compile_code_command): Handle options with
5729         gdb::option::process_options.
5730         (compile_code_command_completer): New function.
5731         (_initialize_compiler): Install completers for "compile code" and
5732         "compile file".  Mention available options in "compile code" and
5733         "compile code"'s help.
5734         * completer.c (advance_to_completion_word): New, factored out from
5735         ...
5736         (advance_to_expression_complete_word_point): ... this.
5737         (advance_to_filename_complete_word_point): New.
5738         * completer.h (advance_to_filename_complete_word_point): New
5739         declaration.
5740
5741 2019-06-13  Pedro Alves  <palves@redhat.com>
5742
5743         * compile/compile.c: Include "cli/cli-option.h".
5744         (compile_print_value): Scope data pointer is now a
5745         value_print_options pointer; adjust.
5746         (compile_print_command): Process options.  Scope data pointer is
5747         now a value_print_options pointer; adjust.
5748         (_initialize_compile): Update "compile print"'s help to include
5749         supported options.  Install a completer for "compile print".
5750         * cp-valprint.c (show_vtblprint, show_objectprint)
5751         (show_static_field_print): Delete.
5752         (_initialize_cp_valprint): Don't install "set print
5753         static-members", "set print vtbl", "set print object" here.
5754         * printcmd.c: Include "cli/cli-option.h" and
5755         "common/gdb_optional.h".
5756         (print_command_parse_format): Rework to fill in a
5757         value_print_options instead of a format_data.
5758         (print_value): Change parameter type from format_data pointer to
5759         value_print_options reference.  Adjust.
5760         (print_command_1): Process options.  Adjust to pass down a
5761         value_print_options.
5762         (print_command_completer): New.
5763         (_initialize_printcmd): Install print_command_completer as
5764         handle_brkchars completer for the "print" command.  Update
5765         "print"'s help to include supported options.
5766         * valprint.c: Include "cli/cli-option.h".
5767         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5768         here from cp-valprint.c.
5769         (boolean_option_def, uinteger_option_def)
5770         (value_print_option_defs, make_value_print_options_def_group):
5771         New.  Use gdb::option::add_setshow_cmds_for_options to install
5772         "set print elements", "set print null-stop", "set print repeats",
5773         "set print pretty", "set print union", "set print array", "set
5774         print address", "set print symbol", "set print array-indexes".
5775         * valprint.h: Include <string> and "cli/cli-option.h".
5776         (make_value_print_options_def_group): Declare.
5777         (print_value): Change parameter type from format_data pointer to
5778         value_print_options reference.
5779         (print_command_completer): Declare.
5780
5781 2019-06-13  Pedro Alves  <palves@redhat.com>
5782
5783         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5784         (COMMON_SFILES): Add maint-test-settings.c.
5785         * cli/cli-decode.c (boolean_enums): New global, factored out from
5786         ...
5787         (add_setshow_boolean_cmd): ... here.
5788         * cli/cli-decode.h (boolean_enums): Declare.
5789         * cli/cli-option.c: New file.
5790         * cli/cli-option.h: New file.
5791         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5792         factored out from ...
5793         (parse_cli_boolean_value(const char *)): ... this.
5794         (is_unlimited_literal): Change parameter type to pointer to
5795         pointer.  Adjust and advance ARG pointer.
5796         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5797         (parse_cli_var_enum): New, factored out from ...
5798         (do_set_command): ... this.  Adjust.
5799         * cli/cli-setshow.h (parse_cli_boolean_value)
5800         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5801         (parse_cli_var_enum): Declare.
5802         * cli/cli-utils.c: Include "cli/cli-option.h".
5803         (get_ulongest): New.
5804         * cli/cli-utils.h (get_ulongest): Declare.
5805         (check_for_argument): New overloads.
5806         * maint-test-options.c: New file.
5807
5808 2019-06-13  Pedro Alves  <palves@redhat.com>
5809
5810         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5811         parse a range if "-" is at the end of the string.
5812
5813 2019-06-13  Pedro Alves  <palves@redhat.com>
5814
5815         * cli/cli-setshow.c (parse_auto_binary_operation)
5816         (parse_cli_boolean_value): Don't allow "o".
5817
5818 2019-06-13  Pedro Alves  <palves@redhat.com>
5819
5820         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5821         * NEWS: Mention maint test-settings KIND.
5822         * maint-test-settings.c: New file.
5823
5824 2019-06-13  Pedro Alves  <palves@redhat.com>
5825
5826         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5827         completer.
5828         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5829         "set" completers.
5830
5831 2019-06-13  Pedro Alves  <palves@redhat.com>
5832
5833         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5834         after item.
5835
5836 2019-06-13  Pedro Alves  <palves@redhat.com>
5837
5838         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5839
5840 2019-06-13  Pedro Alves <palves@redhat.com>
5841
5842         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5843         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5844         call.
5845         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5846         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5847         calls.
5848         (check_for_argument): Skip spaces after argument.
5849
5850 2019-06-13  Pedro Alves  <palves@redhat.com>
5851
5852         * thread.c (thread_apply_command): Adjust TID parsing.
5853         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5854         detected before end of string.
5855         (tid_is_in_list): Error out if LIST is invalid.
5856
5857 2019-06-13  Pedro Alves  <palves@redhat.com>
5858
5859         * completer.c (complete_line_internal_1): Rewind completion word
5860         point.
5861         (completion_tracker::advance_custom_word_point_by): Change
5862         parameter type to int.
5863         * completer.h (completion_tracker::advance_custom_word_point_by):
5864         Likewise.
5865
5866 2019-06-13  Pedro Alves  <palves@redhat.com>
5867
5868         * completer.c (advance_to_completion_word): Handle delimiters.
5869
5870 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5871
5872         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5873
5874 2019-06-11  Tom Tromey  <tom@tromey.com>
5875
5876         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5877         (xmalloc_failed): Move to alloc.c.
5878         * alloc.c: New file.
5879         * Makefile.in (COMMON_SFILES): Add alloc.c.
5880
5881 2019-06-11  Tom Tromey  <tom@tromey.com>
5882
5883         * nat/linux-waitpid.c: Don't include server.h.
5884         (linux_debug): Remove.
5885         (my_waitpid): Update.
5886
5887 2019-06-11  Tom Tromey  <tromey@adacore.com>
5888
5889         * infcall.c (_initialize_infcall): Remove trailing newline from
5890         help.
5891         * user-regs.c (_initialize_user_regs): Remove trailing newline
5892         from help.
5893         * typeprint.c (_initialize_typeprint): Remove trailing newline
5894         from help.
5895         * reverse.c (_initialize_reverse): Remove trailing newlines from
5896         help.
5897         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5898         from help.
5899         * language.c (add_set_language_command): Remove trailing newline
5900         from help.
5901         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5902         help.
5903         * disasm.c (_initialize_disasm): Remove trailing newline from
5904         help.
5905         * top.c (init_main): Remove trailing newline from help.
5906         * interps.c (_initialize_interpreter): Remove trailing newline
5907         from help.
5908         * btrace.c (_initialize_btrace): Remove trailing newlines from
5909         help.
5910         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5911         from help.
5912         * python/python.c (_initialize_python): Remove trailing newline
5913         from help.
5914         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5915         help.
5916         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5917         from help.  Reformat some text.
5918         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5919         from help.
5920         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5921         newline from help.
5922
5923 2019-06-11  Tom Tromey  <tromey@adacore.com>
5924
5925         * darwin-nat.c (darwin_decode_exception_message)
5926         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5927
5928 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5929
5930         * valops.c (value_slice): Check for not allocated or not
5931         associated values.
5932
5933 2019-06-10  Tom de Vries  <tdevries@suse.de>
5934
5935         PR gdb/24618
5936         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5937         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5938         invalid.
5939
5940 2019-06-10  Tom de Vries  <tdevries@suse.de>
5941
5942         PR gdb/24611
5943         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5944         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5945
5946 2019-06-10  Tom de Vries  <tdevries@suse.de>
5947
5948         PR symtab/24545
5949         * symtab.c (struct demangled_name_entry): Add language field.
5950         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5951         static minimal symbol".  Set and use language field.
5952
5953 2019-06-10  Tom Tromey  <tromey@adacore.com>
5954
5955         * ada-lang.c (_initialize_ada_language): Update help text.
5956
5957 2019-06-10  Tom Tromey  <tromey@adacore.com>
5958
5959         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5960         with a newline.
5961         * guile/guile.c (handle_boot_error): Don't end warning with a
5962         newline.
5963         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5964         warning with a newline.
5965         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5966         newline.
5967         (s12z_frame_cache): Likewise.
5968         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5969         a newline.
5970         * solib-svr4.c (disable_probes_interface): Don't end warning with
5971         a newline.
5972         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5973         newline.
5974         * python/python.c (do_finish_initialization): Don't end warning
5975         with a newline.
5976
5977 2019-06-10  Tom Tromey  <tom@tromey.com>
5978
5979         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5980         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5981         gdbpy_enter.
5982
5983 2019-06-10  Tom Tromey  <tromey@adacore.com>
5984
5985         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5986         data.
5987         (elf_new_init): Don't call stabsread_new_init.
5988         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5989         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5990         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5991
5992 2019-06-10  Tom de Vries  <tdevries@suse.de>
5993
5994         PR symtab/16264
5995         PR symtab/24517
5996         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5997
5998 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5999
6000         * source.c (find_and_open_source): Also rewrite relative file
6001         names.
6002
6003 2019-04-26  Amos Bird  <amosbird@gmail.com>
6004
6005         * annotate.c (annotate_thread_exited): Add "thread-exited"
6006         annotation.
6007
6008 2019-06-06  Tom Tromey  <tromey@adacore.com>
6009
6010         * maint.h (class scoped_command_stats): Use
6011         DISABLE_COPY_AND_ASSIGN.
6012         <print_time>: New method.
6013         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6014         print_time.
6015         (scoped_command_stats::print_time): New method.
6016
6017 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6018
6019         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6020         instructions of lengths 6 or 8 bytes.
6021
6022 2019-06-04  Pedro Alves  <palves@redhat.com>
6023
6024         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6025
6026         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6027         * breakpoint.c (condition_completer): Likewise.
6028         * cli/cli-dump.c (scan_expression): Likewise.
6029         * common/filestuff.c (mkdir_recursive): Likewise.
6030         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6031         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6032         (gdb_abspath): Likewise.
6033         * compile/compile-cplus-types.c
6034         (compile_cplus_instance::decl_name): Likewise.
6035         * completer.c (complete_explicit_location):
6036         (signal_completer, reg_or_group_completer_1): Likewise.
6037         * cp-support.c (cp_remove_params_if_any): Likewise.
6038         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6039         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6040         * infcmd.c (strip_bg_char): Likewise.
6041         * linespec.c (copy_token_string): Likewise.
6042         * mi/mi-main.c (output_cores): Likewise.
6043         * psymtab.c (psymtab_search_name):
6044         * symfile.c (test_set_ext_lang_command): Likewise.
6045         * target.c (target_fileio_read_stralloc): Likewise.
6046         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6047         * value.c (complete_internalvar): Likewise.
6048
6049 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6050
6051         Add objfile property to gdb.Type.
6052         * NEWS: Mention Python API addition.
6053         * python/py-type.c (typy_get_objfile): New method.
6054
6055 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6056
6057         * NEWS: Mention the new set|show style [title|highlight].
6058         Mention changes to "show style", "help" and "apropos".
6059
6060 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6061
6062         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6063         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6064         instead of print_help_for_command.
6065         (print_doc_of_command): New function.
6066         (help_list): Add 'apropos -v word' suggestion.
6067         (print_help_for_command): Style the command name using title style.
6068         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6069         (_initialize_cli_cmds): Describe -v in apropos_command help.
6070
6071 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6072
6073         * cli/cli-style.h (cli_style_option): Add name in constructor,
6074         add m_name class member, add constructor with intensity,
6075         add name class function.
6076         (cli_style_option::add_setshow_commands): Remove name argument.
6077         (highlight_style, title_style): New styles.
6078         * cli/cli-style.c (do_show): New function that shows a style
6079         characteristic styling the style name with itself.
6080         (set_style_name): New function.
6081         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6082         Update all callers according to the changes in cli/cli-style.h.
6083         * utils.h (fputs_highlighted): New function.
6084         * utils.c (fputs_highlighted): Likewise.
6085
6086 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6087
6088         * NEWS: Mention new pipe command and new convenience variables.
6089
6090 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6091
6092         * cli/cli-cmds.c (pipe_command): New function.
6093         (_initialize_cli_cmds): Call add_com for pipe_command.
6094         Define | as an alias for pipe.
6095         (exit_status_set_internal_vars): New function.
6096         (shell_escape): Call exit_status_set_internal_vars.
6097         cli/cli-decode.c (find_command_name_length): Recognize | as
6098         a single character command.
6099
6100 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6101
6102         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6103         top.c (execute_command_to_ui_file): New function, mostly a copy
6104         of execute_command_to_string.
6105         (execute_command_to_string): Implement by calling
6106         execute_command_to_ui_file.
6107
6108 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6109
6110         * top.h (saved_command_line): Remove declaration.
6111         * top.c (previous_saved_command_line, previous_repeat_arguments):
6112         New variables.
6113         (saved_command_line): Make static, define together with other
6114         'repeat variables'.
6115         (dont_repeat): Clear repeat_arguments.
6116         (repeat_previous, get_saved_command_line, save_command_line):
6117         New functions.
6118         (gdb_init): Initialize saved_command_line
6119         and previous_saved_command_line.
6120         * main.c (captured_main_1): Remove saved_command_line initialization.
6121         * event-top.c (handle_line_of_input): Update to use
6122         the new 'repeat' related functions instead of direct access to
6123         saved_command_line.
6124         * command.h (repeat_previous, get_saved_command_line,
6125         save_command_line): New declarations.
6126         (dont_repeat): Add comment.
6127
6128 2019-05-30  Tom Tromey  <tromey@adacore.com>
6129
6130         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6131         Fix comment.
6132         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6133
6134 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6135
6136         PR cli/24587
6137         * completer.c (complete): Initialize variable word.
6138
6139 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6140
6141         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6142         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6143         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6144         'body' is NULL to the outter 'if', protecting the '!is_define'
6145         situation as well.
6146
6147 2019-05-29  Tom Tromey  <tromey@adacore.com>
6148
6149         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6150         (dwarf_unknown): New function.
6151         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6152         (dwarf_type_encoding_name): Use dwarf_unknown.
6153
6154 2019-05-29  Tom Tromey  <tromey@adacore.com>
6155
6156         PR c++/20020:
6157         * cp-valprint.c (cp_print_value_fields): Call
6158         cp_print_static_field inside "try".
6159
6160 2019-05-29  Tom Tromey  <tromey@adacore.com>
6161
6162         * inflow.c (struct terminal_info): Add default operator=.
6163         * configure: Rebuild.
6164         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6165         -Wdeprecated-copy-dtor, -Wredundant-move.
6166
6167 2019-05-29  Tom Tromey  <tromey@adacore.com>
6168
6169         * NEWS: Add entry.
6170         * infcmd.c (print_return_value_1): Handle finish_print
6171         option.
6172         (show_print_finish): New function.
6173         (_initialize_infcmd): Add "set/show print finish" commands.
6174         * valprint.c (user_print_options): Initialize new member.
6175         * valprint.h (struct value_print_options) <finish_print>: New
6176         member.
6177
6178 2019-05-28  Tom Tromey  <tromey@adacore.com>
6179
6180         * ada-lang.c (ada_remove_Xbn_suffix)
6181         (find_old_style_renaming_symbol)
6182         (parse_old_style_renaming): Remove.
6183         (ada_find_renaming_symbol): Don't call
6184         find_old_style_renaming_symbol.
6185         (ada_is_renaming_symbol): Rename from
6186         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6187         bool.  Now static.
6188         (ada_read_var_value): Update and simplify.
6189         * ada-exp.y (write_var_or_type): Remove old code.
6190
6191 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6192
6193         * event-top.c: Remove include comment.
6194         * inflow.c (class scoped_ignore_sigttou): Move from here...
6195         * inflow.h (class scoped_ignore_sigttou): ...to here.
6196         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6197         * top.c:  Remove include comment.
6198
6199 2019-05-27  Tom Tromey  <tom@tromey.com>
6200
6201         * NEWS: Fix typo.
6202
6203 2019-05-22  Tom Tromey  <tromey@adacore.com>
6204
6205         * target.c (target_follow_exec): Constify parameter.
6206         * target-delegates.c: Rebuild.
6207         * remote.c (remote_target::follow_exec): Constify parameter.
6208         * infrun.c (follow_exec): Constify parameter.
6209         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6210         (target_follow_exec): Likewise.
6211
6212 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6213
6214         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6215         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6216
6217 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6218
6219         * NEWS: Add debugredirect and testsuite sections.
6220
6221 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6222
6223         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6224         target descriptions using exclusively floating point register name
6225         aliases.
6226
6227 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6228
6229         PR gdb/18644:
6230         * f-lang.c (build_fortran_types): Handle the case where
6231         gdbarch_floatformat_for_type returns a nullptr.
6232
6233 2019-05-21  Tom de Vries  <tdevries@suse.de>
6234
6235         PR cli/24587
6236         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6237
6238 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6239
6240         PR gdb/18644:
6241         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6242         16-byte floats.
6243         * i386-tdep.c (i386_floatformat_for_type): Use
6244         floatformats_ia64_quad for the 16-byte floating point component
6245         within a fortran 32-byte complex number.
6246
6247 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6248
6249         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6250         delete default constructor.
6251         (find_partial_die): Update to return const struct.
6252         (partial_die_parent_scope): Move variable declaration into scope
6253         of its use and change its type to auto.
6254         (guess_partial_die_structure_name): Likewise.
6255         (partial_die_info::fixup): Likewise.
6256
6257 2019-05-17  Tom Tromey  <tromey@adacore.com>
6258
6259         * source.c (find_and_open_source): Remove cast.
6260
6261 2019-05-17  Tom Tromey  <tromey@adacore.com>
6262
6263         * annotate.c (annotate_source): Make "filename" const.
6264         * annotate.h (annotate_source): Use const.
6265
6266 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6267
6268         * disasm.c (set_disassembler_options): Send errors to stderr.
6269
6270 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6271
6272         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6273         (cli_interp_base::set_logging): Check debug_redirect.
6274         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6275         * cli/cli-logging.c (debug_redirect): Add static variable.
6276         (pop_output_files): Add default param.
6277         (handle_redirections): Print debug setting.
6278         (show_logging_command): Likewise.
6279         (_initialize_cli_logging): Add debugredirect command.
6280         * interps.c (current_interp_set_logging): Add debug_redirect
6281         parameter.
6282         * interps.h (set_logging): Add debug_redirect parameter.
6283         (current_interp_set_logging): Likewise.
6284         * mi/mi-common.h: Likewise.
6285         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6286
6287 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6288             Tom Tromey  <tromey@adacore.com>
6289
6290         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6291         directly.
6292         * cli/cli-interp.h (make_logging_output): Remove declaration.
6293         * cli/cli-logging.c (make_logging_output): Remove function.
6294         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6295         directly.
6296         * ui-file.c (tee_file::tee_file): Remove bools.
6297         (tee_file::~tee_file): Remove deletes.
6298         * ui-file.h (tee_file): Remove bools.
6299
6300 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6301
6302         * mi/mi-cmds.h (mi_cmd_complete): New function.
6303         * mi/mi-main.c (mi_cmd_complete): Likewise.
6304         * mi/mi-cmds.c: Define new MI command -complete.
6305         * NEWS: Mention new -complete command.
6306
6307 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6308
6309         * completer.h (complete): New function.
6310         * completer.c (complete): Likewise.
6311         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6312         function defined in completer.h.
6313
6314 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6315
6316         * MAINTAINERS (Write After Approval): Add myself.
6317
6318 2019-05-17  Tom de Vries  <tdevries@suse.de>
6319
6320         PR gdb/24094
6321         * dwarf2read.c (struct cu_partial_die_info): New struct.
6322         (find_partial_die): Return cu_partial_die_info.
6323         (partial_die_parent_scope, guess_partial_die_structure_name)
6324         (partial_die_info::fixup): Handle new return type of find_partial_die.
6325
6326 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6327
6328         PR breakpoints/24541
6329         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6330         "std::string", simplifying the algorithm.
6331
6332 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6333
6334         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6335         (stap_static_probe_ops::get_probes): Likewise.
6336
6337 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6338
6339         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6340         '-')" and "else if".
6341         (stap_parse_single_operand): Join checks for
6342         "gdbarch_stap_parse_special_token_p" and
6343         "gdbarch_stap_parse_special_token" in the same "if" statement.
6344         Invert check when verifying for operation on register
6345         displacement.
6346
6347 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6348
6349         * stap-probe.c (stap_get_opcode): Update comment.
6350         (stap_get_expected_argument_type): Likewise.
6351         (handle_stap_probe): Likewise.
6352
6353 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6354
6355         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6356         return type to 'bool'.  Adjust comment.  Use 'bool' when
6357         appropriate.
6358         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6359         * stap-probe.c (stap_parse_argument_1): Likewise.
6360         (stap_is_operator): Likewise.
6361         (stap_is_generic_prefix): Likewise.
6362         (stap_is_register_prefix): Likewise.
6363         (stap_is_register_indirection_prefix): Likewise.
6364         (stap_is_integer_prefix): Likewise.
6365         (stap_generic_check_suffix): Likewise.
6366         (stap_check_integer_suffix): Likewise.
6367         (stap_check_register_suffix): Likewise.
6368         (stap_check_register_indirection_suffix): Likewise.
6369         (stap_parse_register_operand): Likewise.
6370         (stap_parse_single_operand): Likewise.
6371         (stap_parse_argument_1): Likewise.
6372         (stap_probe::get_argument_count): Likewise.
6373         (stap_is_operator): Likewise.
6374
6375 2019-05-16  Tom Tromey  <tromey@adacore.com>
6376
6377         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6378         keyword to foreach.
6379
6380 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6381
6382         * linux-thread-db.c (try_thread_db_load_1): Change return type
6383         to bool.
6384         (try_thread_db_load): Likewise.
6385         (try_thread_db_load_from_pdir_1): Likewise.
6386         (try_thread_db_load_from_pdir): Likewise.
6387         (try_thread_db_load_from_sdir): Likewise.
6388         (try_thread_db_load_from_dir): Likewise.
6389         (thread_db_load_search): Likewise.
6390         (has_libpthread): Likewise.
6391         (thread_db_load): Likewise.
6392
6393 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6394
6395         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6396         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6397         NULL, and complain/return if that's the case.
6398
6399 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6400
6401         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6402         (advance, posn, abstract_read_memory): New functions.
6403         [struct mem_read_abstraction]: New struct.
6404         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6405
6406 2019-05-14  Tom Tromey  <tromey@adacore.com>
6407
6408         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6409         value is not lval_memory.
6410
6411 2019-05-14  Tom Tromey  <tromey@adacore.com>
6412
6413         * solib.c (info_sharedlibrary_command): Style the file name.
6414
6415 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6416
6417         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6418         (aarch64_vnv_type): Likewise.
6419         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6420         * common/tdesc.c: Likewise.
6421         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6422         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6423         * features/aarch64-fpu.xml: Add ieee half view.
6424         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6425         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6426         * gdbtypes.h (struct builtin_type): Likewise.
6427         (struct objfile_type): Likewise.
6428
6429 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6430
6431         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6432         typo.
6433         * location.h (string_to_event_location): Likewise.
6434
6435 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6436
6437         GDB 8.3 released.
6438
6439 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6440
6441         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6442         New variable declaration.
6443         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6444         New variable.
6445         (print_one_breakpoint): Use ui_out::test_flags and new global
6446         variable to compute use_fixed_output.
6447         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6448         Remove.
6449         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6450         (mi_multi_location_breakpoint_output_fixed): Remove.
6451         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6452         new variable.
6453         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6454         fix_multi_location_breakpoint_output flag if version >= 3.
6455         * ui-out.h (enum ui_out_flag)
6456         <fix_multi_location_breakpoint_output>: New enumerator.
6457
6458 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6459
6460         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6461
6462 2019-05-10  Tom Tromey  <tromey@adacore.com>
6463
6464         * ada-lang.c (catch_ada_completer): New function.
6465         (_initialize_ada_language): Use it.
6466
6467 2019-05-10  Tom Tromey  <tromey@adacore.com>
6468
6469         * thread.c (print_thread_info): Make "requested_threads" const.
6470         * gdbthread.h (print_thread_info): Make "requested_threads"
6471         const.
6472         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6473         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6474
6475 2019-05-08  Tom Tromey  <tom@tromey.com>
6476
6477         * gdbtypes.c (objfile_type_data): Change type.
6478         (objfile_type, _initialize_gdbtypes): Update.
6479
6480 2019-05-08  Tom Tromey  <tom@tromey.com>
6481
6482         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6483         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6484         (_initialize_dwarf2_frame): Update.
6485
6486 2019-05-08  Tom Tromey  <tom@tromey.com>
6487
6488         * objc-lang.c (objc_objfile_data): Change type.
6489         (find_methods): Update.
6490         (_initialize_objc_lang): Remove.
6491
6492 2019-05-08  Tom Tromey  <tom@tromey.com>
6493
6494         * stabsread.c (rs6000_builtin_type_data): Change type.
6495         (rs6000_builtin_type, _initialize_stabsread): Update.
6496
6497 2019-05-08  Tom Tromey  <tom@tromey.com>
6498
6499         * mips-tdep.c (mips_pdr_data): Remove.
6500         (_initialize_mips_tdep): Update.
6501
6502 2019-05-08  Tom Tromey  <tom@tromey.com>
6503
6504         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6505         (hppa_init_objfile_priv_data, read_unwind_info)
6506         (find_unwind_entry, _initialize_hppa_tdep): Update.
6507
6508 2019-05-08  Tom Tromey  <tom@tromey.com>
6509
6510         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6511         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6512         on obstack.
6513         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6514
6515 2019-05-08  Tom Tromey  <tom@tromey.com>
6516
6517         * mdebugread.c (basic_type_data): Change type.
6518         (basic_type, _initialize_mdebugread): Update.
6519
6520 2019-05-08  Tom Tromey  <tom@tromey.com>
6521
6522         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6523
6524 2019-05-08  Tom Tromey  <tom@tromey.com>
6525
6526         * nto-tdep.c (nto_inferior_data_reg): Change type.
6527         (nto_inferior_data): Update.
6528         (nto_inferior_data_cleanup, nto_new_inferior_data)
6529         (_initialize_nto_tdep): Remove.
6530         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6531
6532 2019-05-08  Tom Tromey  <tom@tromey.com>
6533
6534         * ada-lang.c (struct ada_inferior_data): Add initializers.
6535         (ada_inferior_data): Change type.
6536         (ada_inferior_data_cleanup): Remove.
6537         (get_ada_inferior_data, ada_inferior_exit)
6538         (struct ada_pspace_data): Add initializers, destructor.
6539         (ada_pspace_data_handle): Change type.
6540         (get_ada_pspace_data): Update.
6541         (ada_pspace_data_cleanup): Remove.
6542
6543 2019-05-08  Tom Tromey  <tom@tromey.com>
6544
6545         * coffread.c (struct coff_symfile_info): Add initializers.
6546         (coff_objfile_data_key): Move lower.  Change type.
6547         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6548         Update.
6549         (coff_free_info): Remove.
6550
6551 2019-05-08  Tom Tromey  <tom@tromey.com>
6552
6553         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6554         (fbsd_pspace_data_handle): Move lower.  Change type.
6555         (get_fbsd_pspace_data): Update.
6556         (fbsd_pspace_data_cleanup): Remove.
6557         (_initialize_fbsd_tdep): Update.
6558
6559 2019-05-08  Tom Tromey  <tom@tromey.com>
6560
6561         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6562         (get_ada_tasks_pspace_data): Update.
6563         (ada_tasks_pspace_data_cleanup): Remove.
6564         (_initialize_tasks): Update.
6565         (ada_tasks_inferior_data_handle): Change type.
6566         (get_ada_tasks_inferior_data): Update.
6567         (ada_tasks_inferior_data_cleanup): Remove.
6568         (struct ada_tasks_pspace_data): Add initializers.
6569
6570 2019-05-08  Tom Tromey  <tom@tromey.com>
6571
6572         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6573         * symfile-debug.c (debug_sym_get_probes): Change type.
6574         * stap-probe.c (handle_stap_probe):
6575         (stap_static_probe_ops::get_probes): Change type.
6576         * probe.h (class static_probe_ops) <get_probes>: Change type.
6577         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6578         (parse_probes_in_pspace): Update.
6579         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6580         Update.
6581         (any_static_probe_ops::get_probes): Change type.
6582         * elfread.c (elfread_data): New typedef.
6583         (probe_key): Change type.
6584         (elf_get_probes): Likewise.  Update.
6585         (probe_key_free): Remove.
6586         (_initialize_elfread): Update.
6587         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6588         Change type.
6589         (dtrace_process_dof_probe, dtrace_process_dof)
6590         (dtrace_static_probe_ops::get_probe): Change type.
6591
6592 2019-05-08  Tom Tromey  <tom@tromey.com>
6593
6594         * xcoffread.c (struct xcoff_symfile_info): Rename from
6595         coff_symfile_info.  Add initializers.
6596         (xcoff_objfile_data_key): Move lower.  Change type.
6597         (XCOFF_DATA): Rewrite.
6598         (xcoff_free_info): Remove.
6599         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6600         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6601         (xcoff_initial_scan): Update.
6602
6603 2019-05-08  Tom Tromey  <tom@tromey.com>
6604
6605         * solib-svr4.c (struct svr4_info): Add initializers and
6606         destructor.
6607         <probes_table>: Now an htab_up.
6608         (solib_svr4_pspace_data): Change type.
6609         (free_probes_table): Simplify.
6610         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6611         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6612         (probes_table_remove_objfile_probes, register_solib_event_probe)
6613         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6614         (_initialize_svr4_solib): Update.
6615
6616 2019-05-08  Tom Tromey  <tom@tromey.com>
6617
6618         * remote.c (remote_pspace_data): Change type.
6619         (remote_pspace_data_cleanup): Remove.
6620         (get_remote_exec_file, set_pspace_remote_exec_file)
6621         (_initialize_remote): Update.
6622
6623 2019-05-08  Tom Tromey  <tom@tromey.com>
6624
6625         * breakpoint.c (breakpoint_objfile_key): Change type.
6626         (get_breakpoint_objfile_data): Update.
6627         (free_breakpoint_objfile_data): Remove.
6628         (_initialize_breakpoint): Update.
6629
6630 2019-05-08  Tom Tromey  <tom@tromey.com>
6631
6632         * linux-tdep.c (struct linux_info): Add initializers.
6633         (linux_inferior_data): Move.  Change type.
6634         (invalidate_linux_cache_inf): Update.
6635         (linux_inferior_data_cleanup): Remove.
6636         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6637
6638 2019-05-08  Tom Tromey  <tom@tromey.com>
6639
6640         * auxv.c (auxv_inferior_data): Move.  Change type.
6641         (auxv_inferior_data_cleanup): Remove.
6642         (invalidate_auxv_cache_inf): Rewrite.
6643         (get_auxv_inferior_data, _initialize_auxv): Update.
6644
6645 2019-05-08  Tom Tromey  <tom@tromey.com>
6646
6647         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6648         (symfile_debug_objfile_data_key): Change type.
6649         (symfile_debug_installed, debug_qf_has_symbols)
6650         (debug_qf_find_last_source_symtab)
6651         (debug_qf_forget_cached_source_info)
6652         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6653         (debug_qf_print_stats, debug_qf_dump)
6654         (debug_qf_expand_symtabs_for_function)
6655         (debug_qf_expand_all_symtabs)
6656         (debug_qf_expand_symtabs_with_fullname)
6657         (debug_qf_map_matching_symbols)
6658         (debug_qf_expand_symtabs_matching)
6659         (debug_qf_find_pc_sect_compunit_symtab)
6660         (debug_qf_map_symbol_filenames)
6661         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6662         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6663         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6664         (debug_sym_read_linetable, debug_sym_relocate): Update.
6665         (symfile_debug_free_objfile): Remove.
6666         (install_symfile_debug_logging, _initialize_symfile_debug):
6667         Update.
6668
6669 2019-05-08  Tom Tromey  <tom@tromey.com>
6670
6671         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6672         allocate_on_obstack.
6673         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6674         (get_dwarf2_per_objfile): Update.
6675         (set_dwarf2_per_objfile): Remove.
6676         (dwarf2_has_info, dwarf2_get_section_info): Update.
6677         (dwarf2_free_objfile): Remove.
6678         (_initialize_dwarf2_read): Update.
6679
6680 2019-05-08  Tom Tromey  <tom@tromey.com>
6681
6682         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6683         initializers.
6684         <unsupported_script_warning_printed,
6685         script_not_found_warning_printed>: Now bool.
6686         (auto_load_pspace_data): Change type.
6687         (~auto_load_pspace_info): Rename from
6688         auto_load_pspace_data_cleanup.
6689         (get_auto_load_pspace_data, init_loaded_scripts_info)
6690         (clear_section_scripts, maybe_print_unsupported_script_warning)
6691         (maybe_print_script_not_found_warning, _initialize_auto_load):
6692         Update.
6693
6694 2019-05-08  Tom Tromey  <tom@tromey.com>
6695
6696         * objfiles.c (objfile_pspace_info): Add destructor and
6697         initializers.
6698         (objfiles_pspace_data): Change type.
6699         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6700         (get_objfile_pspace_data): Update.
6701         (objfiles_bfd_data): Change type.
6702         (get_objfile_bfd_data): Update.
6703         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6704
6705 2019-05-08  Tom Tromey  <tom@tromey.com>
6706
6707         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6708         Change type.
6709         (get_catch_syscall_inferior_data): Update.
6710         (catch_syscall_inferior_data_cleanup): Remove.
6711         (_initialize_break_catch_syscall): Update.
6712
6713 2019-05-08  Tom Tromey  <tom@tromey.com>
6714
6715         * inflow.c (struct terminal_info): Add destructor and
6716         initializers.
6717         (inflow_inferior_data): Change type.
6718         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6719         (get_inflow_inferior_data, inflow_inferior_exit)
6720         (swap_terminal_info, _initialize_inflow): Update.
6721
6722 2019-05-08  Tom Tromey  <tom@tromey.com>
6723
6724         * target-dcache.c (target_dcache_cleanup): Remove.
6725         (target_dcache_aspace_key): Change type.
6726         (target_dcache_init_p, target_dcache_invalidate)
6727         (target_dcache_get, target_dcache_get_or_init)
6728         (_initialize_target_dcache): Update.
6729         * dcache.h (struct dcache_deleter): New.
6730
6731 2019-05-08  Tom Tromey  <tom@tromey.com>
6732
6733         * symtab.c (struct symbol_cache): Add destructor and
6734         initializers.
6735         (symbol_cache_key): Move.  Change type.
6736         (make_symbol_cache, free_symbol_cache): Remove.
6737         (get_symbol_cache): Update.
6738         (symbol_cache_cleanup): Remove.
6739         (ALL_PSPACES, symbol_cache_flush)
6740         (maintenance_print_symbol_cache)
6741         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6742         Update.
6743
6744 2019-05-08  Tom Tromey  <tom@tromey.com>
6745
6746         * symtab.c (struct main_info): Add destructor and initializers.
6747         (main_progspace_key): Move.  Change type.
6748         (get_main_info): Update.
6749         (main_info_cleanup): Remove.
6750         (_initialize_symtab): Update.
6751
6752 2019-05-08  Tom Tromey  <tom@tromey.com>
6753
6754         * registry.h (DECLARE_REGISTRY): Define the _key class.
6755
6756 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6757
6758         * NEWS: Merge two 'New commands' sections.
6759
6760 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6761
6762         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6763         parameter and use Ada language definition instead.
6764         (ada_val_print_ptr): Remove unused language parameter.
6765         (ada_val_print_num): Remove language parameter and use Ada language
6766         definition instead.
6767         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6768         parameter.
6769         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6770         parameter and use Ada language definition instead.
6771         (ada_val_print_1): Update all ada_val_print_xxx calls.
6772         Remove language parameter.
6773         (ada_val_print): Update ada_val_print_1 call.
6774
6775 2019-05-08  Tom Tromey  <tromey@adacore.com>
6776
6777         * remote.c (remote_hw_watchpoint_limit)
6778         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6779         Now static.
6780
6781 2019-05-08  Tom Tromey  <tromey@adacore.com>
6782
6783         * maint.c (_initialize_maint_cmds): Move initialization code to
6784         remote.c.
6785         (watchdog, show_watchdog): Move to remote.c.
6786         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6787         "watchdog" static.
6788         (_initialize_remote): Move initialization code from maint.c.
6789         * defs.h (watchdog): Don't declare.
6790
6791 2019-05-08  Tom Tromey  <tromey@adacore.com>
6792
6793         * tui/tui-interp.c: Include main.h.
6794         * interps.c: Include main.h.
6795         * main.h (interpreter_p): Declare.
6796         * defs.h (interpreter_p): Don't declare.
6797
6798 2019-05-08  Tom Tromey  <tromey@adacore.com>
6799
6800         * dwarf2loc.c: Include dwarf2read.h.
6801         * defs.h (read_unsigned_leb128): Don't declare.
6802         * dwarf2read.h (read_unsigned_leb128): Declare.
6803
6804 2019-05-08  Tom Tromey  <tromey@adacore.com>
6805
6806         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6807         method.
6808
6809 2019-05-08  Tom Tromey  <tromey@adacore.com>
6810
6811         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6812         when no wrap column is set.
6813
6814 2019-05-08  Tom Tromey  <tromey@adacore.com>
6815
6816         * c-lang.c (c_get_string): Handle non-C-style arrays.
6817
6818 2019-05-08  Tom Tromey  <tromey@adacore.com>
6819
6820         * typeprint.c (print_offset_data::update): Print the bit offset,
6821         not the number of bits remaining.
6822
6823 2019-05-08  Tom Tromey  <tromey@adacore.com>
6824
6825         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6826         padding at end of comment.
6827
6828 2019-05-08  Tom Tromey  <tromey@adacore.com>
6829
6830         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6831         Compare main types.
6832
6833 2019-05-06  Tom Tromey  <tom@tromey.com>
6834
6835         * common/scoped_mmap.c: Include common-defs.h.
6836         * common/scoped_mmap.h: Don't include config.h.
6837
6838 2019-05-04  Tom Tromey  <tom@tromey.com>
6839
6840         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6841         (struct aarch64_call_info): Add initializers.
6842         <si>: Now a std::vector.
6843         (pass_on_stack, aarch64_push_dummy_call): Update.
6844
6845 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6846             Tom Tromey  <tom@tromey.com>
6847
6848         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6849         (ppc_threads): Now a std::vector.  Now static.
6850         (hwdebug_find_thread_points_by_tid)
6851         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6852         Update.
6853
6854 2019-05-04  Tom Tromey  <tom@tromey.com>
6855
6856         * arc-tdep.c (arc_tdesc_init): Return bool.
6857
6858 2019-05-04  Tom Tromey  <tom@tromey.com>
6859
6860         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6861         Use gdb_assert_not_reached.
6862
6863 2019-05-04  Tom Tromey  <tom@tromey.com>
6864
6865         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6866         "false".
6867
6868 2019-05-04  Tom Tromey  <tom@tromey.com>
6869
6870         * arc-tdep.c (arc_tdesc_init): Use bool.
6871
6872 2019-05-04  Tom Tromey  <tom@tromey.com>
6873
6874         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6875
6876 2019-05-04  Tom Tromey  <tom@tromey.com>
6877
6878         * cli/cli-cmds.c (valid_command_p): Return bool.
6879
6880 2019-05-04  Tom Tromey  <tom@tromey.com>
6881
6882         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6883         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6884
6885 2019-05-04  Raul Tambre  <raul@tambre.ee>
6886
6887         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6888         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6889         operator for comparison.
6890
6891 2019-05-04  Tom Tromey  <tom@tromey.com>
6892
6893         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6894         (lookup_partial_symbol, print_partial_symbols)
6895         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6896         (psymbol_compare): Update.
6897         (add_psymbol_to_bcache): Clear the entire psymbol.
6898         (maintenance_check_psymtabs): Update.
6899         * psympriv.h (struct partial_symbol): Don't derive from
6900         general_symbol_info.
6901         <obj_section, unrelocated_address, address,
6902         set_unrelocated_address>: Update.
6903         <ginfo>: New member.
6904         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6905         (debug_names::write_psymbols): Update.
6906
6907 2019-05-04  Tom de Vries  <tdevries@suse.de>
6908
6909         * contrib/cc-with-tweaks.sh: Support -n arg.
6910
6911 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6912
6913         * corelow.c (core_target::detach): Ensure frame cache and
6914         register caches are cleared.
6915         inferior.c (exit_inferior_1): Likewise.
6916
6917 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6918             Tom Tromey  <tom@tromey.com>
6919
6920         * dictionary.c (collate_pending_symbols_by_language): Remove
6921         "struct" from foreach.
6922         * symtab.c (lookup_global_symbol_from_objfile)
6923         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6924         foreach.
6925         * ser-tcp.c (net_open): Remove "struct" from foreach.
6926         * objfiles.c (objfile_relocate, objfile_rebase)
6927         (objfile_has_symbols): Remove "struct" from foreach.
6928         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6929         from foreach.
6930         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6931         foreach.
6932         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6933         "struct" from foreach.
6934         * ada-lang.c (create_excep_cond_exprs)
6935         (ada_exception_catchpoint_cond_string): Remove "struct" from
6936         foreach.
6937
6938 2019-05-03  Tom Tromey  <tromey@adacore.com>
6939
6940         * ada-exp.y (convert_char_literal): Check suffix of each
6941         enumerator.
6942
6943 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6944
6945         PR ada/21406:
6946         * ada-exp.y (yywrap): Don't define.
6947         * ada-lex.l (%option): Add noyywrap
6948         (yywrap): Remove.
6949
6950 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6951
6952         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6953         _WIN32_WINNT to the XP level, unless already defined to a higher
6954         level.
6955
6956         * unittests/parse-connection-spec-selftests.c:
6957         * ser-tcp.c:
6958         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6959         override.
6960
6961         * symfile.c (find_separate_debug_file): Remove colon from the
6962         drive spec of DOS/Windows file names of the target, so that the
6963         file name produced from DEBUGDIR and the target's directory will
6964         be valid on DOS/Windows systems.
6965
6966 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6967
6968         * rust-lang.c (val_print_struct): Handle printing structures
6969         containing strings.
6970
6971 2019-05-02  Tom Tromey  <tromey@adacore.com>
6972
6973         * valarith.c (_initialize_valarith): Remove.
6974
6975 2019-05-01  Tom Tromey  <tromey@adacore.com>
6976
6977         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6978         bitfields.
6979
6980 2019-05-01  Tom Tromey  <tromey@adacore.com>
6981
6982         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6983         for big-endian copies.
6984
6985 2019-04-30  Ali Tamur  <tamur@google.com>
6986         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6987         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6988         (read_3_bytes): New function.
6989
6990 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6991
6992         * windows-nat.c (main_thread_id): Delete.
6993         (handle_output_debug_string): Replace main_thread_id by
6994         current_event.dwThreadId.
6995         (fake_create_process): Likewise.
6996         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6997         Do not set main_thread_id.
6998         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6999         current_event.dwThreadId.
7000         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7001
7002 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7003
7004         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7005         Use current_event.dwThreadId instead of main_thread_id.
7006
7007 2019-04-30  Tom Tromey  <tromey@adacore.com>
7008
7009         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7010         (create_excep_cond_exprs): Iterate over program spaces.
7011         (ada_exception_catchpoint_cond_string): Examine all minimal
7012         symbols for exception types.
7013
7014 2019-04-30  Tom Tromey  <tromey@adacore.com>
7015
7016         PR c++/24470:
7017         * dwarf2read.c (process_structure_scope): Handle case where type
7018         has template parameters but no symbol was created.
7019
7020 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7021             Chris January  <chris.january@arm.com>
7022
7023         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7024         qualifier.
7025         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7026
7027 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7028
7029         * f-typeprint.c (f_print_type): Update rules for printing
7030         whitespace.
7031         (f_type_print_varspec_suffix): Likewise.
7032
7033 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7034             Chris January  <chris.january@arm.com>
7035
7036         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7037         function arguments.
7038
7039 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7040
7041         * f-lang.c (build_fortran_types): Change name of void type to
7042         lower case.
7043         * f-typeprint.c (f_type_print_base): Print the name of the void
7044         type, rather than a fixed string.
7045         * f-valprint.c (f_decorations): Use lower case void string.
7046
7047 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7048             Chris January  <chris.january@arm.com>
7049
7050         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7051         types for Fortran.
7052
7053 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7054             Chris January  <chris.january@arm.com>
7055             David Lecomber  <david.lecomber@arm.com>
7056
7057         * f-exp.y (BINOP_INTRINSIC): New token.
7058         (exp): New parser rule handling BINOP_INTRINSIC.
7059         (f77_keywords): Add new builtin procedures.
7060         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7061         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7062         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7063         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7064         (print_unop_subexp_f): New function.
7065         (print_binop_subexp_f): New function.
7066         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7067         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7068         (dump_subexp_body_f): Likewise.
7069         (operator_check_f): Likewise.
7070         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7071         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7072
7073 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7074
7075         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7076         UNOP_KIND.
7077         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7078         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7079         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7080         (operator_length_f): New fuction.
7081         (print_subexp_f): New function.
7082         (op_name_f): New function.
7083         (dump_subexp_body_f): New function.
7084         (operator_check_f): New function.
7085         (exp_descriptor_f): Replace standard expression handling functions
7086         with new functions.
7087         * gdb/fortran-operator.def: New file.
7088         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7089         * gdb/std-operator.def: Remove UNOP_KIND.
7090
7091 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7092
7093         * std-operator.def: Remove unbalanced, stray double quote
7094         character.
7095
7096 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7097             Chris January  <chris.january@arm.com>
7098             Daniel Everett  <daniel.everett@arm.com>
7099             Nick Forrington  <nick.forrington@arm.com>
7100             Richard Bunt  <richard.bunt@arm.com>
7101
7102         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7103         of depth when printing anonymous structs or unions.
7104         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7105         Don't print either the top-level value, or the children if the
7106         max-depth is exceeded.
7107         (ppscm_print_children): When printing the key of a map, allow one
7108         extra level of depth.
7109         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7110         print either the top-level value, or the children if the max-depth
7111         is exceeded.
7112         (print_children): When printing the key of a map, allow one extra
7113         level of depth.
7114         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7115         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7116         (user_print_options): Initialise max_depth field.
7117         (val_print_scalar_or_string_type_p): New function.
7118         (val_print): Check to see if the max depth has been reached.
7119         (val_print_check_max_depth): Define new function.
7120         (show_print_max_depth): New function.
7121         (_initialize_valprint): Add 'print max-depth' option.
7122         * valprint.h (struct value_print_options) <max_depth>: New field.
7123         (val_print_check_max_depth): Declare new function.
7124         * NEWS: Document new feature.
7125
7126 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7127
7128         * ada-lang.c (ada_language_defn): Initialise new field.
7129         * c-lang.c (c_is_string_type_p): New function.
7130         (c_language_defn): Initialise new field.
7131         (cplus_language_defn): Initialise new field.
7132         (asm_language_defn): Initialise new field.
7133         (minimal_language_defn): Initialise new field.
7134         * c-lang.h (c_is_string_type_p): Declare new function.
7135         * d-lang.c (d_language_defn): Initialise new field.
7136         * f-lang.c (f_is_string_type_p): New function.
7137         (f_language_defn): Initialise new field.
7138         * go-lang.c (go_is_string_type_p): New function.
7139         (go_language_defn): Initialise new field.
7140         * language.c (default_is_string_type_p): New function.
7141         (unknown_language_defn): Initialise new field.
7142         (auto_language_defn): Initialise new field.
7143         * language.h (struct language_defn) <la_is_string_type_p>: New
7144         member variable.
7145         (default_is_string_type_p): Declare new function.
7146         * m2-lang.c (m2_language_defn): Initialise new field.
7147         * objc-lang.c (objc_language_defn): Initialise new field.
7148         * opencl-lang.c (opencl_language_defn): Initialise new field.
7149         * p-lang.c (pascal_is_string_type_p): New function.
7150         (pascal_language_defn): Initialise new field.
7151         * rust-lang.c (rust_is_string_type_p): New function.
7152         (rust_language_defn): Initialise new field.
7153
7154 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7155
7156         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7157         New field.
7158         * ada-lang.c (ada_language_defn): Initialise new field.
7159         * c-lang.c (c_language_defn): Likewise.
7160         (cplus_language_defn): Likewise.
7161         (asm_language_defn): Likewise.
7162         (minimal_language_defn): Likewise.
7163         * d-lang.c (d_language_defn): Likewise.
7164         * f-lang.c (f_language_defn): Likewise.
7165         * go-lang.c (go_language_defn): Likewise.
7166         * language.c (unknown_language_defn): Likewise.
7167         (auto_language_defn): Likewise.
7168         * m2-lang.c (m2_language_defn): Likewise.
7169         * objc-lang.c (objc_language_defn): Likewise.
7170         * opencl-lang.c (opencl_language_defn): Likewise.
7171         * p-lang.c (pascal_language_defn): Likewise.
7172         * rust-lang.c (rust_language_defn): Likewise.
7173
7174 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7175
7176         * ada-lang.c (ada_is_character_type): Change return type to bool.
7177         (ada_is_string_type): Likewise.
7178         * ada-lang.h (ada_is_character_type): Update declaration
7179         (ada_is_string_type): Likewise.
7180
7181 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7182
7183         Support style in 'frame|thread apply'
7184
7185         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7186         * record.c (record_start, record_stop): Update callers of
7187         execute_command_to_string with false.
7188         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7189         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7190         methods.
7191         (class string_file): New constructor with term_out parameter.
7192         Override methods term_out and can_emit_style_escape.  New member
7193         term_out.
7194         (class stdio_file): Override can_emit_style_escape.
7195         (class tee_file): Override term_out and can_emit_style_escape.
7196         * utils.h (can_emit_style_escape): Remove.
7197         * utils.c (can_emit_style_escape): Likewise.
7198         Update all callers of can_emit_style_escape (SOMESTREAM) to
7199         SOMESTREAM->can_emit_style_escape.
7200         * source-cache.c (source_cache::get_source_lines): Likewise.
7201         * stack.c (frame_apply_command_count): Call execute_command_to_string
7202         passing the term_out characteristic of the current gdb_stdout.
7203         * thread.c (thr_try_catch_cmd): Likewise.
7204         * top.c (execute_command_to_string): pass term_out parameter
7205         to construct the string_file for the command output.
7206         * ui-file.c (term_cli_styling): New function (most code moved
7207         from utils.c can_emit_style_escape).
7208         (string_file::string_file, string_file::can_emit_style_escape,
7209         stdio_file::can_emit_style_escape, tee_file::term_out,
7210         tee_file::can_emit_style_escape): New functions.
7211
7212 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7213
7214         * NEWS: Mention the new set|show may-call-functions.
7215         * infcall.c (may_call_functions_p): New variable.
7216         (show_may_call_functions_p): New function.
7217         (call_function_by_hand_dummy): Throws an error if not
7218         may-call-functions.
7219         (_initialize_infcall): Call add_setshow_boolean_cmd for
7220         may-call-functions.
7221
7222 2019-04-25  Keith Seitz  <keiths@redhat.com>
7223
7224         PR c++/24367
7225         * cp-support.c (inspect_type): Don't attempt substitutions
7226         of symbol with the same name.
7227
7228 2019-04-25  Tom Tromey  <tromey@adacore.com>
7229
7230         PR gdb/24475:
7231         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7232         static.
7233
7234 2019-04-25  Tom Tromey  <tromey@adacore.com>
7235
7236         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7237         rvalue reference.
7238         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7239         (gdb_xml_parser::parse): Use std::move.
7240         * python/python-internal.h (gdbpy_convert_exception): Take a const
7241         reference.
7242         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7243         std::move.
7244         * python/py-utils.c (gdbpy_convert_exception): Take a const
7245         reference.
7246         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7247         Use std::move.
7248         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7249         Use std::move.
7250         * mi/mi-main.c (mi_print_exception): Take a const reference.
7251         * main.c (handle_command_errors): Take a const reference.
7252         * linespec.c (parse_linespec): Use std::move.
7253         * infcall.c (run_inferior_call): Use std::move.
7254         (call_function_by_hand_dummy): Use std::move.
7255         * exec.c (try_open_exec_file): Use std::move.
7256         * exceptions.h (exception_print, exception_fprintf)
7257         (exception_print_same): Update.
7258         * exceptions.c (print_exception, exception_print)
7259         (exception_fprintf, exception_print_same): Change parameters to
7260         const reference.
7261         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7262         * common/new-op.c: Use std::move.
7263         * common/common-exceptions.h (struct gdb_exception): Add move
7264         constructor.
7265         (struct gdb_exception_error, struct gdb_exception_quit, struct
7266         gdb_quit_bad_alloc): Change constructor to move constructor.
7267         (throw_exception): Change parameter to rvalue reference.
7268         * common/common-exceptions.c (throw_exception): Take rvalue
7269         reference.
7270         * cli/cli-interp.c (safe_execute_command): Use std::move.
7271         * breakpoint.c (insert_bp_location, location_to_sals): Use
7272         std::move.
7273
7274 2019-04-25  Tom Tromey  <tromey@adacore.com>
7275
7276         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7277         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7278         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7279         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7280         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7281         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7282         guile/scm-value.c: Use unpack.
7283         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7284         gdbscm_gdb_exception.
7285         (gdbscm_throw_gdb_exception): Likewise.
7286         (struct gdbscm_gdb_exception): New.
7287         (unpack): New function.
7288         (gdbscm_wrap): Use unpack.
7289
7290 2019-04-25  Tom Tromey  <tromey@adacore.com>
7291
7292         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7293         (gdb_rl_callback_handler): Use std::move.
7294         * common/common-exceptions.h (struct gdb_exception): Add move
7295         assignment operator.
7296         (throw_exception_sjlj): Change "exception" to const reference.
7297         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7298         (throw_exception_sjlj): Change "exception" to const reference.
7299
7300 2019-04-25  Tom Tromey  <tromey@adacore.com>
7301
7302         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7303         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7304         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7305         Update.
7306         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7307         Update.
7308         * mi/mi-interp.c (mi_interp::exec): Update.
7309         * linespec.c (parse_linespec): Update.
7310         * infcall.c (run_inferior_call): Update.
7311         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7312         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7313         (gdbscm_lookup_global_symbol): Update.
7314         * guile/scm-param.c (gdbscm_parameter_value): Update.
7315         * guile/scm-frame.c (gdbscm_frame_read_register)
7316         (gdbscm_frame_read_var): Update.
7317         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7318         * exec.c (try_open_exec_file): Update.
7319         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7320         (gdb_rl_callback_handler): Update.
7321         * common/common-exceptions.h (exception_none): Don't declare.
7322         * common/common-exceptions.c (exception_none): Don't define.
7323         (struct catcher) <exception>: Update.
7324         * cli/cli-interp.c (safe_execute_command): Update.
7325         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7326
7327 2019-04-25  Ali Tamur  <tamur@google.com>
7328
7329         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7330         (read_attribute_value): Likewise.
7331         (dwarf2_read_addr_index): Update comment.
7332         (read_str_index): Add DW_FORM_strx.
7333         (dwarf2_string_attr): Likewise.
7334         (dwarf2_const_value_attr): Likewise.
7335         (dump_die_shallow): Likewise.
7336         (dwarf2_fetch_constant_bytes): Likewise.
7337         (skip_form_bytes): Likewise.
7338         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7339
7340 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7341
7342         PR corefiles/11608
7343         PR corefiles/18187
7344         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7345         OFFSET.  Verify if current mapping contains an ELF header.
7346         (linux_find_memory_regions_full): Adjust call to
7347         dump_mapping_p.
7348
7349 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7350             Kang Li <kanglictf@gmail.com>
7351
7352         PR gdb/21600
7353
7354         * dwarf2-frame.c (read_initial_length): Be consistent about using
7355         unsigned representation of length.
7356         (decode_frame_entry_1): Likewise.  Check for wraparound of
7357         end pointer as well as buffer overflow.
7358
7359 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7360
7361         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7362         "vq".
7363
7364 2019-04-24  Tom Tromey  <tromey@adacore.com>
7365
7366         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7367
7368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7369
7370         * s12z-tdep.c (s12z_unwind_pc): Delete.
7371         (s12z_unwind_sp): Delete.
7372         (s12z_gdbarch_init): Don't register deleted functions with
7373         gdbarch.
7374
7375 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7376
7377         * rl78-tdep.c (rl78_unwind_sp): Delete.
7378         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7379
7380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7381
7382         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7383         (xstormy16_unwind_pc): Delete.
7384         (xstormy16_dummy_id): Delete.
7385         (xstormy16_gdbarch_init): Don't register deleted functions with
7386         gdbarch.
7387
7388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7389
7390         * vax-tdep.c (vax_unwind_pc): Delete.
7391         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7392
7393 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7394
7395         * v850-tdep.c (v850_unwind_sp): Delete.
7396         (v850_unwind_pc): Delete.
7397         (v850_dummy_id): Delete.
7398         (v850_gdbarch_init): Don't register deleted functions with
7399         gdbarch.
7400
7401 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7402
7403         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7404         (tilegx_unwind_pc): Delete.
7405         (tilegx_unwind_dummy_id): Delete.
7406         (tilegx_gdbarch_init): Don't register deleted functions with
7407         gdbarch.
7408
7409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7410
7411         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7412         (tic6x_dummy_id): Delete.
7413         (tic6x_gdbarch_init): Don't register deleted functions with
7414         gdbarch.
7415
7416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7417
7418         * sparc-tdep.c (sparc_unwind_pc): Delete.
7419         (sparc32_gdbarch_init): Don't register deleted function with
7420         gdbarch.
7421
7422 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7423
7424         * sh-tdep.c (sh_unwind_sp): Delete.
7425         (sh_unwind_pc): Delete.
7426         (sh_dummy_id): Delete.
7427         (sh_gdbarch_init): Don't register deleted functions with
7428         gdbarch.
7429
7430 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7431
7432         * score-tdep.c (score_unwind_sp): Delete.
7433         (score_unwind_pc): Delete.
7434         (score_dummy_id): Delete.
7435         (score_gdbarch_init): Don't register deleted functions with
7436         gdbarch.
7437
7438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7439
7440         * rx-tdep.c (rx_unwind_pc): Delete.
7441         (rx_unwind_sp): Delete.
7442         (rx_dummy_id): Delete.
7443         (rx_gdbarch_init): Don't register deleted functions with
7444         gdbarch.  Update comment.
7445
7446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7449         (rs6000_dummy_id): Delete.
7450         (rs6000_gdbarch_init): Don't register deleted functions with
7451         gdbarch.
7452
7453 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7454
7455         * or1k-tdep.c (or1k_dummy_id): Delete.
7456         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7457
7458 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7459
7460         * nios2-tdep.c (nios2_dummy_id): Delete.
7461         (nios2_unwind_sp): Delete.
7462         (nios2_gdbarch_init): Don't register deleted functions with
7463         gdbarch.
7464
7465 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7466
7467         * nds32-tdep.c (nds32_dummy_id): Delete.
7468         (nds32_unwind_pc): Delete.
7469         (nds32_unwind_sp): Delete.
7470         (nds32_gdbarch_init): Don't register deleted functions with
7471         gdbarch.
7472
7473 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7474
7475         * msp430-tdep.c (msp430_unwind_pc): Delete.
7476         (msp430_unwind_sp): Delete.
7477         (msp430_dummy_id): Delete.
7478         (msp430_gdbarch_init): Don't register deleted functions with
7479         gdbarch.
7480
7481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * moxie-tdep.c (moxie_unwind_sp): Delete.
7484         (moxie_unwind_pc): Delete.
7485         (moxie_dummy_id): Delete.
7486         (moxie_gdbarch_init): Don't register deleted functions with
7487         gdbarch.
7488
7489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7490
7491         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7492         (mn10300_unwind_pc): Delete.
7493         (mn10300_unwind_sp): Delete.
7494         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7495         mn10300_unwind_sp.
7496         (mn10300_frame_unwind_init): Don't register deleted functions with
7497         gdbarch.
7498
7499 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7500
7501         * mep-tdep.c (mep_unwind_pc): Delete.
7502         (mep_unwind_sp): Delete.
7503         (mep_dummy_id): Delete.
7504         (mep_gdbarch_init): Don't register deleted functions with
7505         gdbarch.
7506
7507 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7508
7509         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7510         (m68hc11_unwind_sp): Delete.
7511         (m68hc11_gdbarch_init): Don't register deleted functions with
7512         gdbarch.
7513
7514 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7515
7516         * m32r-tdep.c (m32r_unwind_sp): Delete.
7517         (m32r_unwind_pc): Delete.
7518         (m32r_dummy_id): Delete.
7519         (m32r_gdbarch_init): Don't register deleted functions with
7520         gdbarch.
7521
7522 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7523
7524         * m32c-tdep.c (m32c_unwind_pc): Delete.
7525         (m32c_unwind_sp): Delete.
7526         (m32c_dummy_id): Delete.
7527         (m32c_gdbarch_init): Don't register deleted functions with
7528         gdbarch.
7529
7530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7531
7532         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7533         (lm32_unwind_pc): Delete.
7534         (lm32_dummy_id): Delete.
7535         (lm32_gdbarch_init): Don't register deleted functions with
7536         gdbarch.
7537
7538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7539
7540         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7541         (iq2000_unwind_pc): Delete.
7542         (iq2000_dummy_id): Delete.
7543         (iq2000_gdbarch_init): Don't register deleted functions with
7544         gdbarch.
7545
7546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7547
7548         * nds32-tdep.c (nds32_type_align): Delete.
7549         (nds32_push_dummy_call): Use type_align instead.
7550
7551 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7552
7553         * arm-tdep.c (arm_type_align): Only handle vector override case.
7554         (arm_push_dummy_call): Use type_align.
7555         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7556
7557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7558
7559         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7560         case.
7561         (pass_on_stack): Use type_align.
7562         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7563         function.
7564
7565 2019-04-23  Tom Tromey  <tromey@adacore.com>
7566
7567         * dwarf2read.c (line_header::file_name_at): Remove unused
7568         overload.
7569
7570 2019-04-23  Tom de Vries  <tdevries@suse.de>
7571
7572         PR gdb/24438
7573         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7574         invocation.
7575
7576
7577 2019-03-27  Ali Tamur  <tamur@google.com>
7578
7579         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7580         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7581         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7582         (dwarf_expr_context::get_addr_index): Likewise
7583         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7584         (symbol_needs_eval_context::get_addr_index): Likewise
7585         (disassemble_dwarf_expression): Add DW_OP_addrx
7586         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7587         (read_cutu_die_from_dwo): Update comment
7588         (skip_one_die): Add DW_FORM_addrx
7589         (read_attribute_value): Likewise
7590         (var_decode_location): Add DW_OP_addrx
7591         (dwarf2_const_value_attr): Add DW_FORM_addrx
7592         (dump_die_shallow): Likewise
7593         (dwarf2_fetch_constant_bytes): Likewise
7594         (decode_locdesc): Add DW_OP_addrx
7595         (skip_form_bytes): Add DW_FORM_addrx
7596
7597 2019-04-22  Ali Tamur  <tamur@google.com>
7598
7599         * MAINTAINERS (Write After Approval): Add self.
7600
7601 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7602
7603         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7604         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7605         (open_symbol_file_object): Likewise.
7606         (svr4_default_sos): Add info parameter.
7607         (svr4_read_so_list): Likewise.
7608         (svr4_current_sos_direct): Adjust functions calls to pass down
7609         info.
7610         (svr4_current_sos_1): Add info parameter.
7611         (svr4_current_sos): Call get_svr4_info, pass info down to
7612         svr4_current_sos_1.
7613         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7614         get_svr4_info.
7615         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7616         get_svr4_info.
7617         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7618         to get_svr4_info.
7619         (probes_table_remove_objfile_probes): Likewise.
7620         (register_solib_event_probe): Add info parameter.
7621         (solist_update_incremental): Pass info parameter down to
7622         svr4_read_so_list.
7623         (disable_probes_interface): Add info parameter.
7624         (svr4_handle_solib_event): Pass current_program_space to
7625         get_svr4_info.  Adjust disable_probes_interface cleanup.
7626         (svr4_create_probe_breakpoints): Add info parameter, pass it
7627         down to register_solib_event_probe.
7628         (svr4_create_solib_event_breakpoints): Add info parameter,
7629         pass it down to svr4_create_probe_breakpoints.
7630         (enable_break): Pass info down to
7631         svr4_create_solib_event_breakpoints.
7632         (svr4_solib_create_inferior_hook): Pass current_program_space to
7633         get_svr4_info.
7634         (svr4_clear_solib): Likewise.
7635
7636 2019-04-22  Pedro Alves  <palves@redhat.com>
7637
7638         * solib-svr4.c (svr4_free_objfile_observer): New.
7639         (probe_and_action::objfile): New field.
7640         (probes_table_htab_remove_objfile_probes)
7641         (probes_table_remove_objfile_probes): New functions.
7642         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7643         in the new probe_and_action.  Don't store the probe in 'lookup'.
7644         (svr4_create_probe_breakpoints): Pass objfile to
7645         register_solib_event_probe.
7646         (_initialize_svr4_solib): Register a free_objfile observer.
7647
7648 2019-04-19  Tom Tromey  <tom@tromey.com>
7649
7650         * common/queue.h: Remove.
7651
7652 2019-04-19  Tom Tromey  <tom@tromey.com>
7653
7654         * event-loop.c: Don't include "common/queue.h".
7655
7656 2019-04-19  Tom Tromey  <tom@tromey.com>
7657
7658         * remote.c (remote_target): Use delete.
7659         * remote-notif.h: Include <list>, not "common/queue.h".
7660         (notif_client_p): Remove typedef.
7661         (remote_notif_state): Add constructor, destructor, initializer.
7662         <notif_queue>: Now a std::list.
7663         (remote_notif_state_xfree): Don't declare.
7664         * remote-notif.c (remote_notif_process, handle_notification)
7665         (remote_notif_state_allocate): Update.
7666         (~remote_notif_state): Rename from remote_notif_state_xfree.
7667
7668 2019-04-19  Tom Tromey  <tom@tromey.com>
7669
7670         * symfile.c (reread_symbols): Update.
7671         * objfiles.c (objfile_register_static_link)
7672         (objfile_lookup_static_link): Update
7673         (~objfile) Don't delete static_links.
7674         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7675
7676 2019-04-19  Tom Tromey  <tom@tromey.com>
7677
7678         * type-stack.h (struct type_stack) <insert>: Constify string.
7679         * type-stack.c (type_stack::insert): Constify string.
7680         * gdbtypes.h (lookup_template_type): Update.
7681         (address_space_name_to_int): Update.
7682         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7683         const.
7684         (lookup_template_type): Make name const.
7685         * c-exp.y: Update rules.
7686         (lex_one_token, classify_name, classify_inner_name)
7687         (c_print_token): Update.
7688         * p-exp.y: Update rules.
7689         (yylex): Update.
7690         * f-exp.y: Update rules.
7691         (yylex): Update.
7692         * d-exp.y: Update rules.
7693         (lex_one_token, classify_name, classify_inner_name): Update.
7694         * parse.c (write_dollar_variable, copy_name): Return std::string.
7695         * parser-defs.h (copy_name): Change return type.
7696         * m2-exp.y: Update rules.
7697         (yylex): Update.
7698         * go-exp.y (lex_one_token): Update.
7699         Update rules.
7700         (classify_unsafe_function, classify_packaged_name)
7701         (classify_name, yylex): Update.
7702
7703 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7704
7705         * configure.ac: add --enable-source-highlight switch.
7706         * configure: Regenerate.
7707         * top.c (print_gdb_version): plumb --enable-source-highlight
7708         status to "show configuration".
7709
7710 2019-04-19  Tom Tromey  <tromey@adacore.com>
7711
7712         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7713         Check ADA_TYPE_P.
7714         (empty_record, ada_template_to_fixed_record_type_1)
7715         (template_to_static_fixed_type)
7716         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7717         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7718         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7719         macros.
7720
7721 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7722
7723         PR symtab/24423:
7724         * source.c (print_source_lines_base): Advance "iter" when a
7725         control character is seen.
7726
7727 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7728
7729         * inferior.h (struct infcall_suspend_state_deleter):
7730         Catch exception in destructor to avoid crash.
7731
7732 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7733
7734         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7735         close to the add_com "shell".
7736
7737 2019-04-18  Tom Tromey  <tromey@adacore.com>
7738
7739         * process-stratum-target.h (class process_stratum_target)
7740         <stratum>: Add "final".
7741
7742 2019-04-17  Tom Tromey  <tromey@adacore.com>
7743
7744         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7745         against nullptr before use.
7746
7747 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7748
7749         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7750
7751 2019-04-17  Jim Wilson  <jimw@sifive.com>
7752             Andrew Burgess  <andrew.burgess@embecosm.com>
7753
7754         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7755         code read might fail, assume 4-byte breakpoint in that case.
7756
7757 2019-04-15  Leszek Swirski  <leszeks@google.com>
7758
7759         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7760         rather than a hand-rolled POD check when checking for forced MEMORY
7761         classification.
7762
7763 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7764
7765         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7766         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7767         function.
7768         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7769         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7770         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7771         declaration.
7772
7773 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7774
7775         * aarch64-linux-nat.c
7776         (aarch64_linux_nat_target::thread_architecture): Add override.
7777         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7778         each VQ.
7779
7780 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7781
7782         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7783
7784 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7785
7786         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7787         target types of size 96-bits, add some additional comments, and
7788         check that the builtin type we found was the correct size.
7789
7790 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7791
7792         * utils.c (prompt_for_continue): Don't restore the styling at the
7793         end, as applied_style has the wrong value.  This fixes styling in
7794         long lists of file names that are interrupted by the "Continue?"
7795         prompt.
7796
7797 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7798
7799         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7800         * c-lang.c (c_language_defn): Likewise.
7801         (cplus_language_defn): Likewise.
7802         (asm_language_defn): Likewise.
7803         (minimal_language_defn): Likewise.
7804         * d-lang.c (d_language_defn): Likewise.
7805         * f-lang.c (f_language_defn): Likewise.
7806         * go-lang.c (go_language_defn): Likewise.
7807         * language.c (unknown_language_defn): Likewise.
7808         (auto_language_defn): Likewise.
7809         * language.h (struct language_defn): Remove la_magic field.
7810         (LANG_MAGIC): Delete.
7811         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7812         * objc-lang.c (objc_language_defn): Likewise.
7813         * opencl-lang.c (opencl_language_defn): Likewise.
7814         * p-lang.c (pascal_language_defn): Likewise.
7815         * rust-lang.c (rust_language_defn): Likewise.
7816
7817 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7818
7819         * riscv-tdep.c (riscv_type_align): New function.
7820         (riscv_type_alignment): Delete.
7821         (riscv_arg_location): Use 'type_align'.
7822         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7823
7824 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * gdbtypes.c (type_align): A struct with no non-static fields also
7827         has alignment of 1.
7828
7829 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7830
7831         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7832         component to 0.
7833         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7834         member.
7835         (riscv_struct_info::analyse): New implementation using new
7836         analyse_inner member function.
7837         (riscv_struct_info::field_offset): New member function.
7838         (riscv_struct_info::m_offsets): New member variable.
7839         (riscv_struct_info::analyse_inner): New private member function,
7840         takes the old implementation of riscv_struct_info::analyse but
7841         extended to track field offsets.
7842         (riscv_call_arg_struct): Update the struct folding special cases
7843         to handle cases where empty C++ structs, which are non-zero
7844         length, are found.
7845         (riscv_arg_location): Initialise the length of each location, a
7846         non-zero length now indicates the location is in use.
7847         (riscv_push_dummy_call): Allow for the first location having a
7848         non-zero offset when setting up arguments.
7849         (riscv_return_value): Likewise, but for return values.
7850
7851 2019-04-11  Tom Tromey  <tromey@adacore.com>
7852
7853         * utils.c (internal_vproblem): Make "msg" const.
7854
7855 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7856
7857         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7858         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7859         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7860         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7861
7862 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7863
7864         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7865         function.
7866         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7867         of amd64_collect_native_gregset.
7868         (amd64_linux_nat_target::store_registers): Likewise.
7869
7870 2019-04-10  Tom Tromey  <tom@tromey.com>
7871
7872         * symtab.c (lookup_global_symbol_from_objfile)
7873         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7874         * objfiles.h (class separate_debug_iterator): New.
7875         (class separate_debug_range): New.
7876         (struct objfile) <separate_debug_objfiles>: New method.
7877         (objfile_separate_debug_iterate): Don't declare.
7878         * objfiles.c (separate_debug_iterator::operator++): Rename from
7879         objfile_separate_debug_iterate.
7880         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7881         iterator.
7882         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7883         iterator.
7884
7885 2019-04-10  Tom Tromey  <tom@tromey.com>
7886
7887         * symfile.c (reread_symbols): Remove old comment.
7888         * objfiles.c (free_all_objfiles): Fix a typo.
7889
7890 2019-04-10  Tom Tromey  <tom@tromey.com>
7891
7892         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7893         * minsyms.c (lookup_minimal_symbol): Use foreach.
7894         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7895         (lookup_minimal_symbol_solib_trampoline): Likewise.
7896         * symfile.c (reread_symbols): Use foreach.
7897
7898 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7899             Tom Tromey  <tromey@adacore.com>
7900
7901         PR rust/24414:
7902         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7903         (rust_lex_int_test): Change "value" to be LONGEST.
7904         (rust_lex_tests): Add test for long integer literal.
7905
7906 2019-04-09  Tom Tromey  <tromey@adacore.com>
7907
7908         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7909         to bool.
7910         (extended_remote_target::attach): Update.
7911         (remote_target::remote_notice_new_inferior): Update.
7912         (remote_target::add_current_inferior_and_thread): Update.
7913         * inferior.c (exit_inferior_1): Use "false".
7914         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7915
7916 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7917
7918         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7919         the "start" command.
7920
7921 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7922
7923         * python/py-inferior.c (infpy_thread_from_thread_handle):
7924         Adjust comments to reflect renaming of thread_from_thread_handle
7925         to thread_from_handle.  Adjust keywords.  Fix type error message.
7926         (inferior_object_methods): Add thread_from_handle.  Retain
7927         thread_from_thread_handle, but mark it as deprecated.
7928
7929 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7930
7931         * gdbthread.h (find_thread_by_handle): Revise declaration.
7932         * thread.c (find_thread_by_handle): Likewise.  Adjust
7933         implementation too.
7934         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7935         support for buffer objects as handles.
7936
7937 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7938
7939         * python/py-infthread.c (thpy_thread_handle): New function.
7940         (thread_object_methods): Register thpy_thread_handle.
7941
7942 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7943
7944         * gdbthread.h (thread_to_thread_handle): Declare.
7945         * thread.c (gdbtypes.h): Include.
7946         (thread_to_thread_handle): New function.
7947
7948         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7949         (target_thread_info_to_thread_handle): Declare.
7950         * target.c (target_thread_info_to_thread_handle): New function.
7951         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7952         * target-delegates.c: Regenerate.
7953
7954         * linux-thread-db.c (class thread_db_target): Add method
7955         thread_info_to_thread_handle.
7956         (thread_db_target::thread_info_to_thread_handle): Define.
7957         * remote.c (class remote_target): Add new method
7958         thread_info_to_thread_handle.
7959         (remote_target::thread_info_to_thread_handle): Define.
7960
7961 2019-04-08  Pedro Alves  <palves@redhat.com>
7962
7963         * common/common-exceptions.c (throw_exception): Don't create
7964         named object to throw; throw directly.
7965         (throw_it): Likewise.  Don't initialize gdb_exception::message
7966         here, with new; pass FMT and AP to the ctor instead.
7967         * common/common-exceptions.h: Include <string>.
7968         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7969         const char *, va_list)): New ctor.  Use std::make_shared.
7970         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7971         errors)): Delete.
7972         (gdb_exception_error::gdb_exception_error(enum errors, const char
7973         *, va_list)): New.
7974         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7975         Add assertion.
7976         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7977         errors)): Delete.
7978         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7979         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7980         Add assertion.
7981
7982 2019-04-08  Tom Tromey  <tom@tromey.com>
7983
7984         * valops.c (value_rtti_indirect_type): Replace throw_exception
7985         with throw.
7986         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7987         with throw.
7988         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7989         throw.
7990         * target.c (target_translate_tls_address): Replace throw_exception
7991         with throw.
7992         * stack.c (frame_apply_command_count): Replace throw_exception
7993         with throw.
7994         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7995         throw.
7996         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7997         with throw.
7998         * rs6000-tdep.c (rs6000_frame_cache)
7999         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8000         * remote.c: Replace throw_exception with throw.
8001         * record-full.c (record_full_message, record_full_wait_1)
8002         (record_full_restore): Replace throw_exception with throw.
8003         * record-btrace.c:
8004         (get_thread_current_frame_id, record_btrace_start_replaying)
8005         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8006         (cmd_record_btrace_start): Replace throw_exception with throw.
8007         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8008         throw.
8009         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8010         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8011         * linespec.c:
8012         (find_linespec_symbols): Replace throw_exception with throw.
8013         * infrun.c (displaced_step_prepare, resume): Replace
8014         throw_exception with throw.
8015         * infcmd.c (post_create_inferior): Replace throw_exception with
8016         throw.
8017         * inf-loop.c (inferior_event_handler): Replace throw_exception
8018         with throw.
8019         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8020         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8021         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8022         (get_prev_frame_always, get_frame_pc_if_available)
8023         (get_frame_address_in_block_if_available, get_frame_language):
8024         Replace throw_exception with throw.
8025         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8026         throw_exception with throw.
8027         * eval.c (fetch_subexp_value, evaluate_var_value)
8028         (evaluate_funcall, evaluate_subexp_standard): Replace
8029         throw_exception with throw.
8030         * dwarf2loc.c (call_site_find_chain)
8031         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8032         Replace throw_exception with throw.
8033         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8034         with throw.
8035         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8036         throw.
8037         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8038         * completer.c (complete_line_internal): Replace throw_exception
8039         with throw.
8040         * compile/compile-object-run.c (compile_object_run): Replace
8041         throw_exception with throw.
8042         * cli/cli-script.c (process_next_line): Replace throw_exception
8043         with throw.
8044         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8045         (btrace_enable, btrace_maint_update_pt_packets): Replace
8046         throw_exception with throw.
8047         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8048         throw_exception with throw.
8049         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8050         throw_exception with throw.
8051         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8052         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8053         * aarch64-tdep.c (aarch64_make_prologue_cache)
8054         (aarch64_make_stub_cache): Replace throw_exception with throw.
8055
8056 2019-04-08  Tom Tromey  <tom@tromey.com>
8057
8058         * common/common-exceptions.c (throw_exception): Rename from
8059         throw_exception_cxx.  Remove old copy.  Make argument const.
8060         (throw_it): Create and throw exception objects directly.
8061         * common/common-exceptions.h (throw_exception): Make argument
8062         const.
8063         (struct gdb_exception_error): Add constructor.
8064         (struct gdb_exception_quit): Add constructor.
8065
8066 2019-04-08  Tom Tromey  <tom@tromey.com>
8067
8068         * common/common-exceptions.h (exception_rethrow): Don't declare.
8069         (TRY_SJLJ): Update comment.
8070         (TRY, CATCH, END_CATCH): Remove.
8071         * common/common-exceptions.c (exception_rethrow): Remove.
8072
8073 2019-04-08  Tom Tromey  <tom@tromey.com>
8074
8075         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8076         Remove.
8077         (gdb_exception_error): Rename from
8078         gdb_exception_RETURN_MASK_ERROR.
8079         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8080         (gdb_quit_bad_alloc): Update.
8081         * aarch64-tdep.c: Update.
8082         * ada-lang.c: Update.
8083         * ada-typeprint.c: Update.
8084         * ada-valprint.c: Update.
8085         * amd64-tdep.c: Update.
8086         * arch-utils.c: Update.
8087         * break-catch-throw.c: Update.
8088         * breakpoint.c: Update.
8089         * btrace.c: Update.
8090         * c-varobj.c: Update.
8091         * cli/cli-cmds.c: Update.
8092         * cli/cli-interp.c: Update.
8093         * cli/cli-script.c: Update.
8094         * common/common-exceptions.c: Update.
8095         * common/new-op.c: Update.
8096         * common/selftest.c: Update.
8097         * compile/compile-c-symbols.c: Update.
8098         * compile/compile-cplus-symbols.c: Update.
8099         * compile/compile-object-load.c: Update.
8100         * compile/compile-object-run.c: Update.
8101         * completer.c: Update.
8102         * corelow.c: Update.
8103         * cp-abi.c: Update.
8104         * cp-support.c: Update.
8105         * cp-valprint.c: Update.
8106         * darwin-nat.c: Update.
8107         * disasm-selftests.c: Update.
8108         * dtrace-probe.c: Update.
8109         * dwarf-index-cache.c: Update.
8110         * dwarf-index-write.c: Update.
8111         * dwarf2-frame-tailcall.c: Update.
8112         * dwarf2-frame.c: Update.
8113         * dwarf2loc.c: Update.
8114         * dwarf2read.c: Update.
8115         * eval.c: Update.
8116         * event-loop.c: Update.
8117         * event-top.c: Update.
8118         * exec.c: Update.
8119         * f-valprint.c: Update.
8120         * fbsd-tdep.c: Update.
8121         * frame-unwind.c: Update.
8122         * frame.c: Update.
8123         * gdbtypes.c: Update.
8124         * gnu-v3-abi.c: Update.
8125         * guile/guile-internal.h: Update.
8126         * guile/scm-block.c: Update.
8127         * guile/scm-breakpoint.c: Update.
8128         * guile/scm-cmd.c: Update.
8129         * guile/scm-disasm.c: Update.
8130         * guile/scm-frame.c: Update.
8131         * guile/scm-lazy-string.c: Update.
8132         * guile/scm-math.c: Update.
8133         * guile/scm-param.c: Update.
8134         * guile/scm-ports.c: Update.
8135         * guile/scm-pretty-print.c: Update.
8136         * guile/scm-symbol.c: Update.
8137         * guile/scm-symtab.c: Update.
8138         * guile/scm-type.c: Update.
8139         * guile/scm-value.c: Update.
8140         * i386-linux-tdep.c: Update.
8141         * i386-tdep.c: Update.
8142         * inf-loop.c: Update.
8143         * infcall.c: Update.
8144         * infcmd.c: Update.
8145         * infrun.c: Update.
8146         * jit.c: Update.
8147         * language.c: Update.
8148         * linespec.c: Update.
8149         * linux-fork.c: Update.
8150         * linux-nat.c: Update.
8151         * linux-tdep.c: Update.
8152         * linux-thread-db.c: Update.
8153         * main.c: Update.
8154         * mi/mi-cmd-break.c: Update.
8155         * mi/mi-cmd-stack.c: Update.
8156         * mi/mi-interp.c: Update.
8157         * mi/mi-main.c: Update.
8158         * objc-lang.c: Update.
8159         * p-valprint.c: Update.
8160         * parse.c: Update.
8161         * ppc-linux-tdep.c: Update.
8162         * printcmd.c: Update.
8163         * python/py-arch.c: Update.
8164         * python/py-breakpoint.c: Update.
8165         * python/py-cmd.c: Update.
8166         * python/py-finishbreakpoint.c: Update.
8167         * python/py-frame.c: Update.
8168         * python/py-framefilter.c: Update.
8169         * python/py-gdb-readline.c: Update.
8170         * python/py-inferior.c: Update.
8171         * python/py-infthread.c: Update.
8172         * python/py-lazy-string.c: Update.
8173         * python/py-linetable.c: Update.
8174         * python/py-objfile.c: Update.
8175         * python/py-param.c: Update.
8176         * python/py-prettyprint.c: Update.
8177         * python/py-progspace.c: Update.
8178         * python/py-record-btrace.c: Update.
8179         * python/py-record.c: Update.
8180         * python/py-symbol.c: Update.
8181         * python/py-type.c: Update.
8182         * python/py-unwind.c: Update.
8183         * python/py-utils.c: Update.
8184         * python/py-value.c: Update.
8185         * python/python.c: Update.
8186         * record-btrace.c: Update.
8187         * record-full.c: Update.
8188         * remote-fileio.c: Update.
8189         * remote.c: Update.
8190         * riscv-tdep.c: Update.
8191         * rs6000-aix-tdep.c: Update.
8192         * rs6000-tdep.c: Update.
8193         * rust-exp.y: Update.
8194         * rust-lang.c: Update.
8195         * s390-tdep.c: Update.
8196         * selftest-arch.c: Update.
8197         * solib-dsbt.c: Update.
8198         * solib-frv.c: Update.
8199         * solib-spu.c: Update.
8200         * solib-svr4.c: Update.
8201         * solib.c: Update.
8202         * sparc64-linux-tdep.c: Update.
8203         * stack.c: Update.
8204         * symfile-mem.c: Update.
8205         * symmisc.c: Update.
8206         * target.c: Update.
8207         * thread.c: Update.
8208         * top.c: Update.
8209         * tracefile-tfile.c: Update.
8210         * tui/tui.c: Update.
8211         * typeprint.c: Update.
8212         * unittests/cli-utils-selftests.c: Update.
8213         * unittests/parse-connection-spec-selftests.c: Update.
8214         * valops.c: Update.
8215         * valprint.c: Update.
8216         * value.c: Update.
8217         * varobj.c: Update.
8218         * windows-nat.c: Update.
8219         * x86-linux-nat.c: Update.
8220         * xml-support.c: Update.
8221
8222 2019-04-08  Tom Tromey  <tom@tromey.com>
8223
8224         * xml-support.c: Use C++ exception handling.
8225         * x86-linux-nat.c: Use C++ exception handling.
8226         * windows-nat.c: Use C++ exception handling.
8227         * varobj.c: Use C++ exception handling.
8228         * value.c: Use C++ exception handling.
8229         * valprint.c: Use C++ exception handling.
8230         * valops.c: Use C++ exception handling.
8231         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8232         handling.
8233         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8234         * typeprint.c: Use C++ exception handling.
8235         * tui/tui.c: Use C++ exception handling.
8236         * tracefile-tfile.c: Use C++ exception handling.
8237         * top.c: Use C++ exception handling.
8238         * thread.c: Use C++ exception handling.
8239         * target.c: Use C++ exception handling.
8240         * symmisc.c: Use C++ exception handling.
8241         * symfile-mem.c: Use C++ exception handling.
8242         * stack.c: Use C++ exception handling.
8243         * sparc64-linux-tdep.c: Use C++ exception handling.
8244         * solib.c: Use C++ exception handling.
8245         * solib-svr4.c: Use C++ exception handling.
8246         * solib-spu.c: Use C++ exception handling.
8247         * solib-frv.c: Use C++ exception handling.
8248         * solib-dsbt.c: Use C++ exception handling.
8249         * selftest-arch.c: Use C++ exception handling.
8250         * s390-tdep.c: Use C++ exception handling.
8251         * rust-lang.c: Use C++ exception handling.
8252         * rust-exp.y: Use C++ exception handling.
8253         * rs6000-tdep.c: Use C++ exception handling.
8254         * rs6000-aix-tdep.c: Use C++ exception handling.
8255         * riscv-tdep.c: Use C++ exception handling.
8256         * remote.c: Use C++ exception handling.
8257         * remote-fileio.c: Use C++ exception handling.
8258         * record-full.c: Use C++ exception handling.
8259         * record-btrace.c: Use C++ exception handling.
8260         * python/python.c: Use C++ exception handling.
8261         * python/py-value.c: Use C++ exception handling.
8262         * python/py-utils.c: Use C++ exception handling.
8263         * python/py-unwind.c: Use C++ exception handling.
8264         * python/py-type.c: Use C++ exception handling.
8265         * python/py-symbol.c: Use C++ exception handling.
8266         * python/py-record.c: Use C++ exception handling.
8267         * python/py-record-btrace.c: Use C++ exception handling.
8268         * python/py-progspace.c: Use C++ exception handling.
8269         * python/py-prettyprint.c: Use C++ exception handling.
8270         * python/py-param.c: Use C++ exception handling.
8271         * python/py-objfile.c: Use C++ exception handling.
8272         * python/py-linetable.c: Use C++ exception handling.
8273         * python/py-lazy-string.c: Use C++ exception handling.
8274         * python/py-infthread.c: Use C++ exception handling.
8275         * python/py-inferior.c: Use C++ exception handling.
8276         * python/py-gdb-readline.c: Use C++ exception handling.
8277         * python/py-framefilter.c: Use C++ exception handling.
8278         * python/py-frame.c: Use C++ exception handling.
8279         * python/py-finishbreakpoint.c: Use C++ exception handling.
8280         * python/py-cmd.c: Use C++ exception handling.
8281         * python/py-breakpoint.c: Use C++ exception handling.
8282         * python/py-arch.c: Use C++ exception handling.
8283         * printcmd.c: Use C++ exception handling.
8284         * ppc-linux-tdep.c: Use C++ exception handling.
8285         * parse.c: Use C++ exception handling.
8286         * p-valprint.c: Use C++ exception handling.
8287         * objc-lang.c: Use C++ exception handling.
8288         * mi/mi-main.c: Use C++ exception handling.
8289         * mi/mi-interp.c: Use C++ exception handling.
8290         * mi/mi-cmd-stack.c: Use C++ exception handling.
8291         * mi/mi-cmd-break.c: Use C++ exception handling.
8292         * main.c: Use C++ exception handling.
8293         * linux-thread-db.c: Use C++ exception handling.
8294         * linux-tdep.c: Use C++ exception handling.
8295         * linux-nat.c: Use C++ exception handling.
8296         * linux-fork.c: Use C++ exception handling.
8297         * linespec.c: Use C++ exception handling.
8298         * language.c: Use C++ exception handling.
8299         * jit.c: Use C++ exception handling.
8300         * infrun.c: Use C++ exception handling.
8301         * infcmd.c: Use C++ exception handling.
8302         * infcall.c: Use C++ exception handling.
8303         * inf-loop.c: Use C++ exception handling.
8304         * i386-tdep.c: Use C++ exception handling.
8305         * i386-linux-tdep.c: Use C++ exception handling.
8306         * guile/scm-value.c: Use C++ exception handling.
8307         * guile/scm-type.c: Use C++ exception handling.
8308         * guile/scm-symtab.c: Use C++ exception handling.
8309         * guile/scm-symbol.c: Use C++ exception handling.
8310         * guile/scm-pretty-print.c: Use C++ exception handling.
8311         * guile/scm-ports.c: Use C++ exception handling.
8312         * guile/scm-param.c: Use C++ exception handling.
8313         * guile/scm-math.c: Use C++ exception handling.
8314         * guile/scm-lazy-string.c: Use C++ exception handling.
8315         * guile/scm-frame.c: Use C++ exception handling.
8316         * guile/scm-disasm.c: Use C++ exception handling.
8317         * guile/scm-cmd.c: Use C++ exception handling.
8318         * guile/scm-breakpoint.c: Use C++ exception handling.
8319         * guile/scm-block.c: Use C++ exception handling.
8320         * guile/guile-internal.h: Use C++ exception handling.
8321         * gnu-v3-abi.c: Use C++ exception handling.
8322         * gdbtypes.c: Use C++ exception handling.
8323         * frame.c: Use C++ exception handling.
8324         * frame-unwind.c: Use C++ exception handling.
8325         * fbsd-tdep.c: Use C++ exception handling.
8326         * f-valprint.c: Use C++ exception handling.
8327         * exec.c: Use C++ exception handling.
8328         * event-top.c: Use C++ exception handling.
8329         * event-loop.c: Use C++ exception handling.
8330         * eval.c: Use C++ exception handling.
8331         * dwarf2read.c: Use C++ exception handling.
8332         * dwarf2loc.c: Use C++ exception handling.
8333         * dwarf2-frame.c: Use C++ exception handling.
8334         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8335         * dwarf-index-write.c: Use C++ exception handling.
8336         * dwarf-index-cache.c: Use C++ exception handling.
8337         * dtrace-probe.c: Use C++ exception handling.
8338         * disasm-selftests.c: Use C++ exception handling.
8339         * darwin-nat.c: Use C++ exception handling.
8340         * cp-valprint.c: Use C++ exception handling.
8341         * cp-support.c: Use C++ exception handling.
8342         * cp-abi.c: Use C++ exception handling.
8343         * corelow.c: Use C++ exception handling.
8344         * completer.c: Use C++ exception handling.
8345         * compile/compile-object-run.c: Use C++ exception handling.
8346         * compile/compile-object-load.c: Use C++ exception handling.
8347         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8348         * compile/compile-c-symbols.c: Use C++ exception handling.
8349         * common/selftest.c: Use C++ exception handling.
8350         * common/new-op.c: Use C++ exception handling.
8351         * cli/cli-script.c: Use C++ exception handling.
8352         * cli/cli-interp.c: Use C++ exception handling.
8353         * cli/cli-cmds.c: Use C++ exception handling.
8354         * c-varobj.c: Use C++ exception handling.
8355         * btrace.c: Use C++ exception handling.
8356         * breakpoint.c: Use C++ exception handling.
8357         * break-catch-throw.c: Use C++ exception handling.
8358         * arch-utils.c: Use C++ exception handling.
8359         * amd64-tdep.c: Use C++ exception handling.
8360         * ada-valprint.c: Use C++ exception handling.
8361         * ada-typeprint.c: Use C++ exception handling.
8362         * ada-lang.c: Use C++ exception handling.
8363         * aarch64-tdep.c: Use C++ exception handling.
8364
8365 2019-04-08  Tom Tromey  <tom@tromey.com>
8366
8367         * xml-support.c (gdb_xml_parser::parse): Update.
8368         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8369         * value.c (show_convenience): Update.
8370         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8371         (test_parse_flags_qcs): Update.
8372         * thread.c (thr_try_catch_cmd): Update.
8373         * target.c (target_translate_tls_address): Update.
8374         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8375         (info_frame_command_core, frame_apply_command_count): Update.
8376         * rust-exp.y (rust_lex_exception_test): Update.
8377         * riscv-tdep.c (riscv_print_one_register_info): Update.
8378         * remote.c (remote_target::enable_btrace): Update.
8379         * record-btrace.c (record_btrace_enable_warn): Update.
8380         * python/py-utils.c (gdbpy_convert_exception): Update.
8381         * printcmd.c (do_one_display, print_variable_and_value): Update.
8382         * mi/mi-main.c (mi_print_exception): Update.
8383         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8384         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8385         * linux-nat.c (linux_nat_target::attach): Update.
8386         * linux-fork.c (class scoped_switch_fork_info): Update.
8387         * infrun.c (displaced_step_prepare): Update.
8388         * infcall.c (call_function_by_hand_dummy): Update.
8389         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8390         * gnu-v3-abi.c (print_one_vtable): Update.
8391         * frame.c (get_prev_frame_always): Update.
8392         * f-valprint.c (info_common_command_for_block): Update.
8393         * exec.c (try_open_exec_file): Update.
8394         * exceptions.c (print_exception, exception_print)
8395         (exception_fprintf, exception_print_same): Update.
8396         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8397         * dwarf-index-cache.c (index_cache::store)
8398         (index_cache::lookup_gdb_index): Update.
8399         * darwin-nat.c (maybe_cache_shell): Update.
8400         * cp-valprint.c (cp_print_value_fields): Update.
8401         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8402         (gcc_cplus_symbol_address): Update.
8403         * compile/compile-c-symbols.c (gcc_convert_symbol)
8404         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8405         * common/selftest.c: Update.
8406         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8407         a std::string.
8408         (exception_try_scope_entry, exception_try_scope_exit): Don't
8409         declare.
8410         (struct exception_try_scope): Remove.
8411         (TRY): Don't use exception_try_scope.
8412         (struct gdb_exception): Add constructor, operator=.
8413         <what>: New method.
8414         (struct gdb_exception_RETURN_MASK_ALL)
8415         (struct gdb_exception_RETURN_MASK_ERROR)
8416         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8417         (struct gdb_quit_bad_alloc): Update.
8418         * common/common-exceptions.c (exception_none): Change
8419         initializer.
8420         (struct catcher) <state, exception>: Initialize inline.
8421         <prev>: Remove member.
8422         (current_catcher): Remove.
8423         (catchers): New global.
8424         (exceptions_state_mc_init): Simplify.
8425         (catcher_pop): Remove.
8426         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8427         (try_scope_depth, exception_try_scope_entry)
8428         (exception_try_scope_exit): Remove.
8429         (throw_exception_sjlj): Update.
8430         (exception_messages, exception_messages_size): Remove.
8431         (throw_it): Simplify.
8432         (gdb_exception_sliced_copy): Remove.
8433         (throw_exception_cxx): Update.
8434         * cli/cli-script.c (script_from_file): Update.
8435         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8436         Update.
8437         * ada-valprint.c (ada_val_print): Update.
8438         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8439         (create_excep_cond_exprs): Update.
8440
8441 2019-04-08  Tom Tromey  <tom@tromey.com>
8442
8443         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8444         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8445         (TRY, CATCH, END_CATCH): Remove some definitions.
8446         * common/common-exceptions.c: Don't use GDB_XCPT.
8447         (catcher_list_size): Remove.
8448         (throw_exception, throw_it): Simplify.
8449
8450 2019-04-05  Tom Tromey  <tom@tromey.com>
8451
8452         Revert the header-sorting patch.
8453         * ft32-tdep.c: Revert.
8454         * frv-tdep.c: Revert.
8455         * frv-linux-tdep.c: Revert.
8456         * frame.c: Revert.
8457         * frame-unwind.c: Revert.
8458         * frame-base.c: Revert.
8459         * fork-child.c: Revert.
8460         * findvar.c: Revert.
8461         * findcmd.c: Revert.
8462         * filesystem.c: Revert.
8463         * filename-seen-cache.h: Revert.
8464         * filename-seen-cache.c: Revert.
8465         * fbsd-tdep.c: Revert.
8466         * fbsd-nat.h: Revert.
8467         * fbsd-nat.c: Revert.
8468         * f-valprint.c: Revert.
8469         * f-typeprint.c: Revert.
8470         * f-lang.c: Revert.
8471         * extension.h: Revert.
8472         * extension.c: Revert.
8473         * extension-priv.h: Revert.
8474         * expprint.c: Revert.
8475         * exec.h: Revert.
8476         * exec.c: Revert.
8477         * exceptions.c: Revert.
8478         * event-top.c: Revert.
8479         * event-loop.c: Revert.
8480         * eval.c: Revert.
8481         * elfread.c: Revert.
8482         * dwarf2read.h: Revert.
8483         * dwarf2read.c: Revert.
8484         * dwarf2loc.c: Revert.
8485         * dwarf2expr.h: Revert.
8486         * dwarf2expr.c: Revert.
8487         * dwarf2-frame.c: Revert.
8488         * dwarf2-frame-tailcall.c: Revert.
8489         * dwarf-index-write.h: Revert.
8490         * dwarf-index-write.c: Revert.
8491         * dwarf-index-common.c: Revert.
8492         * dwarf-index-cache.h: Revert.
8493         * dwarf-index-cache.c: Revert.
8494         * dummy-frame.c: Revert.
8495         * dtrace-probe.c: Revert.
8496         * disasm.h: Revert.
8497         * disasm.c: Revert.
8498         * disasm-selftests.c: Revert.
8499         * dictionary.c: Revert.
8500         * dicos-tdep.c: Revert.
8501         * demangle.c: Revert.
8502         * dcache.h: Revert.
8503         * dcache.c: Revert.
8504         * darwin-nat.h: Revert.
8505         * darwin-nat.c: Revert.
8506         * darwin-nat-info.c: Revert.
8507         * d-valprint.c: Revert.
8508         * d-namespace.c: Revert.
8509         * d-lang.c: Revert.
8510         * ctf.c: Revert.
8511         * csky-tdep.c: Revert.
8512         * csky-linux-tdep.c: Revert.
8513         * cris-tdep.c: Revert.
8514         * cris-linux-tdep.c: Revert.
8515         * cp-valprint.c: Revert.
8516         * cp-support.c: Revert.
8517         * cp-namespace.c: Revert.
8518         * cp-abi.c: Revert.
8519         * corelow.c: Revert.
8520         * corefile.c: Revert.
8521         * continuations.c: Revert.
8522         * completer.h: Revert.
8523         * completer.c: Revert.
8524         * complaints.c: Revert.
8525         * coffread.c: Revert.
8526         * coff-pe-read.c: Revert.
8527         * cli-out.h: Revert.
8528         * cli-out.c: Revert.
8529         * charset.c: Revert.
8530         * c-varobj.c: Revert.
8531         * c-valprint.c: Revert.
8532         * c-typeprint.c: Revert.
8533         * c-lang.c: Revert.
8534         * buildsym.c: Revert.
8535         * buildsym-legacy.c: Revert.
8536         * build-id.h: Revert.
8537         * build-id.c: Revert.
8538         * btrace.c: Revert.
8539         * bsd-uthread.c: Revert.
8540         * breakpoint.h: Revert.
8541         * breakpoint.c: Revert.
8542         * break-catch-throw.c: Revert.
8543         * break-catch-syscall.c: Revert.
8544         * break-catch-sig.c: Revert.
8545         * blockframe.c: Revert.
8546         * block.c: Revert.
8547         * bfin-tdep.c: Revert.
8548         * bfin-linux-tdep.c: Revert.
8549         * bfd-target.c: Revert.
8550         * bcache.c: Revert.
8551         * ax-general.c: Revert.
8552         * ax-gdb.h: Revert.
8553         * ax-gdb.c: Revert.
8554         * avr-tdep.c: Revert.
8555         * auxv.c: Revert.
8556         * auto-load.c: Revert.
8557         * arm-wince-tdep.c: Revert.
8558         * arm-tdep.c: Revert.
8559         * arm-symbian-tdep.c: Revert.
8560         * arm-pikeos-tdep.c: Revert.
8561         * arm-obsd-tdep.c: Revert.
8562         * arm-nbsd-tdep.c: Revert.
8563         * arm-nbsd-nat.c: Revert.
8564         * arm-linux-tdep.c: Revert.
8565         * arm-linux-nat.c: Revert.
8566         * arm-fbsd-tdep.c: Revert.
8567         * arm-fbsd-nat.c: Revert.
8568         * arm-bsd-tdep.c: Revert.
8569         * arch-utils.c: Revert.
8570         * arc-tdep.c: Revert.
8571         * arc-newlib-tdep.c: Revert.
8572         * annotate.h: Revert.
8573         * annotate.c: Revert.
8574         * amd64-windows-tdep.c: Revert.
8575         * amd64-windows-nat.c: Revert.
8576         * amd64-tdep.c: Revert.
8577         * amd64-sol2-tdep.c: Revert.
8578         * amd64-obsd-tdep.c: Revert.
8579         * amd64-obsd-nat.c: Revert.
8580         * amd64-nbsd-tdep.c: Revert.
8581         * amd64-nbsd-nat.c: Revert.
8582         * amd64-nat.c: Revert.
8583         * amd64-linux-tdep.c: Revert.
8584         * amd64-linux-nat.c: Revert.
8585         * amd64-fbsd-tdep.c: Revert.
8586         * amd64-fbsd-nat.c: Revert.
8587         * amd64-dicos-tdep.c: Revert.
8588         * amd64-darwin-tdep.c: Revert.
8589         * amd64-bsd-nat.c: Revert.
8590         * alpha-tdep.c: Revert.
8591         * alpha-obsd-tdep.c: Revert.
8592         * alpha-nbsd-tdep.c: Revert.
8593         * alpha-mdebug-tdep.c: Revert.
8594         * alpha-linux-tdep.c: Revert.
8595         * alpha-linux-nat.c: Revert.
8596         * alpha-bsd-tdep.c: Revert.
8597         * alpha-bsd-nat.c: Revert.
8598         * aix-thread.c: Revert.
8599         * agent.c: Revert.
8600         * addrmap.c: Revert.
8601         * ada-varobj.c: Revert.
8602         * ada-valprint.c: Revert.
8603         * ada-typeprint.c: Revert.
8604         * ada-tasks.c: Revert.
8605         * ada-lang.c: Revert.
8606         * aarch64-tdep.c: Revert.
8607         * aarch64-ravenscar-thread.c: Revert.
8608         * aarch64-newlib-tdep.c: Revert.
8609         * aarch64-linux-tdep.c: Revert.
8610         * aarch64-linux-nat.c: Revert.
8611         * aarch64-fbsd-tdep.c: Revert.
8612         * aarch64-fbsd-nat.c: Revert.
8613         * aarch32-linux-nat.c: Revert.
8614
8615 2019-04-05  Tom Tromey  <tom@tromey.com>
8616
8617         * ft32-tdep.c: Sort headers.
8618         * frv-tdep.c: Sort headers.
8619         * frv-linux-tdep.c: Sort headers.
8620         * frame.c: Sort headers.
8621         * frame-unwind.c: Sort headers.
8622         * frame-base.c: Sort headers.
8623         * fork-child.c: Sort headers.
8624         * findvar.c: Sort headers.
8625         * findcmd.c: Sort headers.
8626         * filesystem.c: Sort headers.
8627         * filename-seen-cache.h: Sort headers.
8628         * filename-seen-cache.c: Sort headers.
8629         * fbsd-tdep.c: Sort headers.
8630         * fbsd-nat.h: Sort headers.
8631         * fbsd-nat.c: Sort headers.
8632         * f-valprint.c: Sort headers.
8633         * f-typeprint.c: Sort headers.
8634         * f-lang.c: Sort headers.
8635         * extension.h: Sort headers.
8636         * extension.c: Sort headers.
8637         * extension-priv.h: Sort headers.
8638         * expprint.c: Sort headers.
8639         * exec.h: Sort headers.
8640         * exec.c: Sort headers.
8641         * exceptions.c: Sort headers.
8642         * event-top.c: Sort headers.
8643         * event-loop.c: Sort headers.
8644         * eval.c: Sort headers.
8645         * elfread.c: Sort headers.
8646         * dwarf2read.h: Sort headers.
8647         * dwarf2read.c: Sort headers.
8648         * dwarf2loc.c: Sort headers.
8649         * dwarf2expr.h: Sort headers.
8650         * dwarf2expr.c: Sort headers.
8651         * dwarf2-frame.c: Sort headers.
8652         * dwarf2-frame-tailcall.c: Sort headers.
8653         * dwarf-index-write.h: Sort headers.
8654         * dwarf-index-write.c: Sort headers.
8655         * dwarf-index-common.c: Sort headers.
8656         * dwarf-index-cache.h: Sort headers.
8657         * dwarf-index-cache.c: Sort headers.
8658         * dummy-frame.c: Sort headers.
8659         * dtrace-probe.c: Sort headers.
8660         * disasm.h: Sort headers.
8661         * disasm.c: Sort headers.
8662         * disasm-selftests.c: Sort headers.
8663         * dictionary.c: Sort headers.
8664         * dicos-tdep.c: Sort headers.
8665         * demangle.c: Sort headers.
8666         * dcache.h: Sort headers.
8667         * dcache.c: Sort headers.
8668         * darwin-nat.h: Sort headers.
8669         * darwin-nat.c: Sort headers.
8670         * darwin-nat-info.c: Sort headers.
8671         * d-valprint.c: Sort headers.
8672         * d-namespace.c: Sort headers.
8673         * d-lang.c: Sort headers.
8674         * ctf.c: Sort headers.
8675         * csky-tdep.c: Sort headers.
8676         * csky-linux-tdep.c: Sort headers.
8677         * cris-tdep.c: Sort headers.
8678         * cris-linux-tdep.c: Sort headers.
8679         * cp-valprint.c: Sort headers.
8680         * cp-support.c: Sort headers.
8681         * cp-namespace.c: Sort headers.
8682         * cp-abi.c: Sort headers.
8683         * corelow.c: Sort headers.
8684         * corefile.c: Sort headers.
8685         * continuations.c: Sort headers.
8686         * completer.h: Sort headers.
8687         * completer.c: Sort headers.
8688         * complaints.c: Sort headers.
8689         * coffread.c: Sort headers.
8690         * coff-pe-read.c: Sort headers.
8691         * cli-out.h: Sort headers.
8692         * cli-out.c: Sort headers.
8693         * charset.c: Sort headers.
8694         * c-varobj.c: Sort headers.
8695         * c-valprint.c: Sort headers.
8696         * c-typeprint.c: Sort headers.
8697         * c-lang.c: Sort headers.
8698         * buildsym.c: Sort headers.
8699         * buildsym-legacy.c: Sort headers.
8700         * build-id.h: Sort headers.
8701         * build-id.c: Sort headers.
8702         * btrace.c: Sort headers.
8703         * bsd-uthread.c: Sort headers.
8704         * breakpoint.h: Sort headers.
8705         * breakpoint.c: Sort headers.
8706         * break-catch-throw.c: Sort headers.
8707         * break-catch-syscall.c: Sort headers.
8708         * break-catch-sig.c: Sort headers.
8709         * blockframe.c: Sort headers.
8710         * block.c: Sort headers.
8711         * bfin-tdep.c: Sort headers.
8712         * bfin-linux-tdep.c: Sort headers.
8713         * bfd-target.c: Sort headers.
8714         * bcache.c: Sort headers.
8715         * ax-general.c: Sort headers.
8716         * ax-gdb.h: Sort headers.
8717         * ax-gdb.c: Sort headers.
8718         * avr-tdep.c: Sort headers.
8719         * auxv.c: Sort headers.
8720         * auto-load.c: Sort headers.
8721         * arm-wince-tdep.c: Sort headers.
8722         * arm-tdep.c: Sort headers.
8723         * arm-symbian-tdep.c: Sort headers.
8724         * arm-pikeos-tdep.c: Sort headers.
8725         * arm-obsd-tdep.c: Sort headers.
8726         * arm-nbsd-tdep.c: Sort headers.
8727         * arm-nbsd-nat.c: Sort headers.
8728         * arm-linux-tdep.c: Sort headers.
8729         * arm-linux-nat.c: Sort headers.
8730         * arm-fbsd-tdep.c: Sort headers.
8731         * arm-fbsd-nat.c: Sort headers.
8732         * arm-bsd-tdep.c: Sort headers.
8733         * arch-utils.c: Sort headers.
8734         * arc-tdep.c: Sort headers.
8735         * arc-newlib-tdep.c: Sort headers.
8736         * annotate.h: Sort headers.
8737         * annotate.c: Sort headers.
8738         * amd64-windows-tdep.c: Sort headers.
8739         * amd64-windows-nat.c: Sort headers.
8740         * amd64-tdep.c: Sort headers.
8741         * amd64-sol2-tdep.c: Sort headers.
8742         * amd64-obsd-tdep.c: Sort headers.
8743         * amd64-obsd-nat.c: Sort headers.
8744         * amd64-nbsd-tdep.c: Sort headers.
8745         * amd64-nbsd-nat.c: Sort headers.
8746         * amd64-nat.c: Sort headers.
8747         * amd64-linux-tdep.c: Sort headers.
8748         * amd64-linux-nat.c: Sort headers.
8749         * amd64-fbsd-tdep.c: Sort headers.
8750         * amd64-fbsd-nat.c: Sort headers.
8751         * amd64-dicos-tdep.c: Sort headers.
8752         * amd64-darwin-tdep.c: Sort headers.
8753         * amd64-bsd-nat.c: Sort headers.
8754         * alpha-tdep.c: Sort headers.
8755         * alpha-obsd-tdep.c: Sort headers.
8756         * alpha-nbsd-tdep.c: Sort headers.
8757         * alpha-mdebug-tdep.c: Sort headers.
8758         * alpha-linux-tdep.c: Sort headers.
8759         * alpha-linux-nat.c: Sort headers.
8760         * alpha-bsd-tdep.c: Sort headers.
8761         * alpha-bsd-nat.c: Sort headers.
8762         * aix-thread.c: Sort headers.
8763         * agent.c: Sort headers.
8764         * addrmap.c: Sort headers.
8765         * ada-varobj.c: Sort headers.
8766         * ada-valprint.c: Sort headers.
8767         * ada-typeprint.c: Sort headers.
8768         * ada-tasks.c: Sort headers.
8769         * ada-lang.c: Sort headers.
8770         * aarch64-tdep.c: Sort headers.
8771         * aarch64-ravenscar-thread.c: Sort headers.
8772         * aarch64-newlib-tdep.c: Sort headers.
8773         * aarch64-linux-tdep.c: Sort headers.
8774         * aarch64-linux-nat.c: Sort headers.
8775         * aarch64-fbsd-tdep.c: Sort headers.
8776         * aarch64-fbsd-nat.c: Sort headers.
8777         * aarch32-linux-nat.c: Sort headers.
8778
8779 2019-04-04  Tom Tromey  <tom@tromey.com>
8780
8781         * varobj.c (varobj_create): Update.
8782         * rust-exp.y (struct rust_parser) <update_innermost_block,
8783         lookup_symbol>: New methods.
8784         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8785         Rename.
8786         (rust_parser::rust_lookup_type)
8787         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8788         * printcmd.c (display_command, do_one_display): Update.
8789         * parser-defs.h (struct parser_state) <parser_state>: Add
8790         "tracker" parameter.
8791         (block_tracker): New member.
8792         (class innermost_block_tracker) <innermost_block_tracker>: Add
8793         "types" parameter.
8794         <reset>: Remove method.
8795         (innermost_block): Don't declare.
8796         (null_post_parser): Update.
8797         * parse.c (innermost_block): Remove global.
8798         (write_dollar_variable): Update.
8799         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8800         Remove "tracker_types" parameter.
8801         (parse_expression): Add "tracker" parameter.
8802         (parse_expression_for_completion): Update.
8803         (null_post_parser): Add "tracker" parameter.
8804         * p-exp.y: Update rules.
8805         * m2-exp.y: Update rules.
8806         * language.h (struct language_defn) <la_post_parser>: Add
8807         "tracker" parameter.
8808         * go-exp.y: Update rules.
8809         * f-exp.y: Update rules.
8810         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8811         parameter.
8812         * d-exp.y: Update rules.
8813         * c-exp.y: Update rules.
8814         * breakpoint.c (set_breakpoint_condition): Create an
8815         innermost_block_tracker.
8816         (watch_command_1): Likewise.
8817         * ada-lang.c (resolve): Add "tracker" parameter.
8818         (resolve_subexp): Likewise.
8819         * ada-exp.y (write_var_from_sym): Update.
8820
8821 2019-04-04  Tom Tromey  <tom@tromey.com>
8822
8823         * type-stack.h: New file.
8824         * type-stack.c: New file.
8825         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8826         type-stack.h.
8827         (insert_into_type_stack, insert_type, push_type, push_type_int)
8828         (insert_type_address_space, pop_type, pop_type_int)
8829         (pop_typelist, pop_type_stack, append_type_stack)
8830         (push_type_stack, get_type_stack, push_typelist)
8831         (follow_type_instance_flags, follow_types): Don't declare.
8832         * parse.c (type_stack): Remove global.
8833         (parse_exp_in_context): Update.
8834         (insert_into_type_stack, insert_type, push_type, push_type_int)
8835         (insert_type_address_space, pop_type, pop_type_int)
8836         (pop_typelist, pop_type_stack, append_type_stack)
8837         (push_type_stack, get_type_stack, push_typelist)
8838         (follow_type_instance_flags, follow_types): Remove (moved to
8839         type-stack.c).
8840         * f-exp.y (type_stack): New global.
8841         Update rules.
8842         (push_kind_type, f_parse): Update.
8843         * d-exp.y (type_stack): New global.
8844         Update rules.
8845         (d_parse): Update.
8846         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8847         Update rules.
8848         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8849         (HFILES_NO_SRCDIR): Add type-stack.h.
8850
8851 2019-04-04  Tom Tromey  <tom@tromey.com>
8852
8853         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8854         (rust_parser::convert_ast_to_expression, rust_parse)
8855         (rust_lex_test_completion, rust_lex_tests): Update.
8856         * parser-defs.h (struct expr_completion_state): New.
8857         (struct parser_state) <parser_state>: Add completion parameter.
8858         <mark_struct_expression, mark_completion_tag>: New methods.
8859         <parse_completion, m_completion_state>: New members.
8860         (prefixify_expression, null_post_parser): Update.
8861         (mark_struct_expression, mark_completion_tag): Don't declare.
8862         * parse.c (parse_completion, expout_last_struct)
8863         (expout_tag_completion_type, expout_completion_name): Remove
8864         globals.
8865         (parser_state::mark_struct_expression)
8866         (parser_state::mark_completion_tag): Now methods.
8867         (prefixify_expression): Add last_struct parameter.
8868         (prefixify_subexp): Likewise.
8869         (parse_exp_1): Update.
8870         (parse_exp_in_context): Add cstate parameter.  Update.
8871         (parse_expression_for_completion): Create an
8872         expr_completion_state.
8873         (null_post_parser): Add "completion" parameter.
8874         * p-exp.y: Update rules.
8875         (yylex): Update.
8876         * language.h (struct language_defn) <la_post_parser>: Add
8877         "completing" parameter.
8878         * go-exp.y: Update rules.
8879         (lex_one_token): Update.
8880         * expression.h (parse_completion): Don't declare.
8881         * d-exp.y: Update rules.
8882         (lex_one_token): Update rules.
8883         * c-exp.y: Update rules.
8884         (lex_one_token): Update.
8885         * ada-lang.c (resolve): Add "parse_completion" parameter.
8886         (resolve_subexp): Likewise.
8887         (ada_resolve_function): Likewise.
8888
8889 2019-04-04  Tom Tromey  <tom@tromey.com>
8890
8891         * parser-defs.h (struct parser_state) <start_arglist,
8892         end_arglist>: New methods.
8893         <arglist_len, m_funcall_chain>: New members.
8894         (arglist_len, start_arglist, end_arglist): Don't declare.
8895         * parse.c (arglist_len, funcall_chain): Remove global.
8896         (start_arglist, end_arglist): Remove functions.
8897         (parse_exp_in_context): Update.
8898         * p-exp.y: Update rules.
8899         * m2-exp.y: Update rules.
8900         * go-exp.y: Update rules.
8901         * f-exp.y: Update rules.
8902         * d-exp.y: Update rules.
8903         * c-exp.y: Update rules.
8904
8905 2019-04-04  Tom Tromey  <tom@tromey.com>
8906
8907         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8908         lex_operator, push_back>: New methods.
8909         Update all rules.
8910         (rust_parser::lex_hex, lex_escape): Rename and update.
8911         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8912         (rust_parser::lex_operator): Rename and update.
8913         (rust_parser::lex_number, rustyylex, rustyyerror)
8914         (rust_lex_test_init, rust_lex_test_sequence)
8915         (rust_lex_test_push_back, rust_lex_tests): Update.
8916         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8917         parameter.
8918         <lexptr, prev_lexptr>: New members.
8919         (lexptr, prev_lexptr): Don't declare.
8920         * parse.c (lexptr, prev_lexptr): Remove globals.
8921         (parse_exp_in_context): Update.
8922         * p-exp.y (yylex, yyerror): Update.
8923         * m2-exp.y (parse_number, yylex, yyerror): Update.
8924         * go-exp.y (lex_one_token, yyerror): Update.
8925         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8926         * d-exp.y (lex_one_token, yyerror): Update.
8927         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8928         (lex_one_token, yyerror): Update.
8929         * ada-lex.l (YY_INPUT): Update.
8930         (rewind_to_char): Update.
8931         * ada-exp.y (yyerror): Update.
8932
8933 2019-04-04  Tom Tromey  <tom@tromey.com>
8934
8935         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8936         * parser-defs.h (struct parser_state) <parser_state>: Add new
8937         parameter.
8938         <comma_terminates>: New member.
8939         (comma_terminates): Don't declare global.
8940         * parse.c (comma_terminates): Remove global.
8941         (parse_exp_in_context): Update.
8942         * p-exp.y (yylex): Update.
8943         * m2-exp.y (yylex): Update.
8944         * go-exp.y (lex_one_token): Update.
8945         * f-exp.y (yylex): Update.
8946         * d-exp.y (lex_one_token): Update.
8947         * c-exp.y (lex_one_token): Update.
8948         * ada-lex.l: Update.
8949
8950 2019-04-04  Tom Tromey  <tom@tromey.com>
8951
8952         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8953         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8954         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8955         * parser-defs.h (paren_depth): Don't declare.
8956         * parse.c (paren_depth): Remove global.
8957         (parse_exp_in_context): Update.
8958         * p-exp.y (paren_depth): New global.
8959         (pascal_parse): Initialize it.
8960         * m2-exp.y (paren_depth): New global.
8961         (m2_parse): Initialize it.
8962         * go-exp.y (paren_depth): New global.
8963         (go_parse): Initialize it.
8964         * f-exp.y (paren_depth): New global.
8965         (f_parse): Initialize it.
8966         * d-exp.y (paren_depth): New global.
8967         (d_parse): Initialize it.
8968         * c-exp.y (paren_depth): New global.
8969         (c_parse): Initialize it.
8970         * ada-lex.l (paren_depth): New global.
8971         (lexer_init): Initialize it.
8972
8973 2019-04-04  Tom Tromey  <tom@tromey.com>
8974
8975         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8976         (rust_parser::convert_ast_to_type)
8977         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8978         * parser-defs.h (struct parser_state) <parser_state>: Add
8979         parameters.  Initialize new members.
8980         <expression_context_block, expression_context_pc>: New members.
8981         * parse.c (expression_context_block, expression_context_pc):
8982         Remove globals.
8983         (parse_exp_in_context): Update.
8984         * p-exp.y: Update all rules.
8985         (yylex): Update.
8986         * m2-exp.y: Update all rules.
8987         (yylex): Update.
8988         * go-exp.y (yylex): Update.
8989         * f-exp.y (yylex): Update.
8990         * d-exp.y: Update all rules.
8991         (yylex): Update.
8992         * c-exp.y: Update all rules.
8993         (lex_one_token, classify_name, yylex, c_parse): Update.
8994         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8995
8996 2019-04-04  Tom Tromey  <tom@tromey.com>
8997
8998         * gdbarch.h, gdbarch.c: Rebuild.
8999         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9000         * stap-probe.h:
9001         (struct stap_parse_info): Replace "parser_state" with
9002         "expr_builder".
9003         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9004         (parser_state): New class.
9005         * parse.c (expr_builder): Rename.
9006         (expr_builder::release): Rename.
9007         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9008         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9009         (write_exp_elt_longcst, write_exp_elt_floatcst)
9010         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9011         (write_exp_string_vector, write_exp_bitstring)
9012         (write_exp_msymbol, mark_struct_expression)
9013         (write_dollar_variable)
9014         (insert_type_address_space, increase_expout_size): Replace
9015         "parser_state" with "expr_builder".
9016         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9017         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9018         "parser_state" with "expr_builder".
9019
9020 2019-04-04  Tom Tromey  <tom@tromey.com>
9021
9022         * rust-exp.y: Replace "parse_language" with method call.
9023         * p-exp.y:
9024         (yylex): Replace "parse_language" with method call.
9025         * m2-exp.y:
9026         (yylex): Replace "parse_language" with method call.
9027         * go-exp.y (classify_name): Replace "parse_language" with method
9028         call.
9029         * f-exp.y (yylex): Replace "parse_language" with method call.
9030         * d-exp.y (lex_one_token): Replace "parse_language" with method
9031         call.
9032         * c-exp.y:
9033         (lex_one_token, classify_name, yylex): Replace "parse_language"
9034         with method call.
9035         * ada-exp.y (find_primitive_type, type_char)
9036         (type_system_address): Replace "parse_language" with method call.
9037
9038 2019-04-04  Tom Tromey  <tom@tromey.com>
9039
9040         * rust-exp.y: Replace "parse_gdbarch" with method call.
9041         * parse.c (write_dollar_variable, insert_type_address_space):
9042         Replace "parse_gdbarch" with method call.
9043         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9044         call.
9045         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9046         call.
9047         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9048         "parse_gdbarch" with method call.
9049         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9050         with method call.
9051         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9052         "parse_gdbarch" with method call.
9053         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9054         "parse_gdbarch" with method call.
9055         * c-exp.y (parse_type, parse_number, classify_name): Replace
9056         "parse_gdbarch" with method call.
9057         * ada-lex.l: Replace "parse_gdbarch" with method call.
9058         * ada-exp.y (parse_type, find_primitive_type, type_char)
9059         (type_system_address): Replace "parse_gdbarch" with method call.
9060
9061 2019-04-04  Tom Tromey  <tom@tromey.com>
9062
9063         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9064         * stap-probe.c (stap_parse_argument): Update.
9065         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9066         initial_size parameter.
9067         * rust-exp.y (rust_lex_tests): Update.
9068         * parse.c (parser_state): Update.
9069         (parse_exp_in_context): Update.
9070         * parser-defs.h (struct parser_state) <parser_state>: Remove
9071         "initial_size" parameter.
9072
9073 2019-04-04  Tom Tromey  <tom@tromey.com>
9074
9075         * parser-defs.h (increase_expout_size): Don't declare.
9076         * parse.c (increase_expout_size): Now static.
9077
9078 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9079
9080         * gnu-nat.c (gnu_nat_target::wait): Fix
9081         target_waitstatus_to_string call.
9082
9083 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9084
9085         * eval.c (evaluate_subexp_standard): Handle internal functions
9086         during Fortran function call handling.
9087
9088 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9089
9090         * NEWS: Mention new internal functions.
9091         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9092         (read_base_type): Use dwarf2_init_complex_target_type.
9093         * value.c (creal_internal_fn): New function.
9094         (cimag_internal_fn): New function.
9095         (_initialize_values): Register new internal functions.
9096
9097 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9098
9099         * infrun.c (stop_all_threads): If debug_infrun, always
9100         trace the wait status after wait_one, using
9101         target_waitstatus_to_string and target_pid_to_str.
9102         (handle_inferior_event): Replace various trace of
9103         wait status kind by a single trace.
9104         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9105         wait status kind image by target_waitstatus_to_string.
9106         * target/waitstatus.c (target_waitstatus_to_string): Fix
9107         obsolete comment.
9108
9109 2019-04-01  Tom Tromey  <tromey@adacore.com>
9110
9111         PR symtab/23331:
9112         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9113
9114 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9115             Pedro Alves  <palves@redhat.com>
9116
9117         * top.c (quit_force): Call 'finalize_values'.
9118         * value.c (finalize_values): New function.
9119         * value.h (finalize_values): Declare.
9120
9121 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9122
9123         * NEWS: Announce $_gdb_major and $_gdb_minor.
9124
9125         * top.c (init_gdb_version_vars): New function.
9126         (gdb_init): Call init_gdb_version_vars.
9127
9128 2019-03-29  Tom Tromey  <tromey@adacore.com>
9129
9130         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9131         help text.  Remove dead code.
9132
9133 2019-03-29  Keith Seitz  <keiths@redhat.com>
9134
9135         From Siddhesh Poyarekar:
9136         * f-lang.h (f77_get_upperbound): Return LONGEST.
9137         (f77_get_lowerbound): Likewise.
9138         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9139         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9140         print them.
9141         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9142         plongest to format print it.
9143         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9144         (f77_get_upperbound): Likewise.
9145         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9146         LOWER_BOUND to LONGEST.
9147         (f77_create_arrayprint_offset_tbl): Likewise.
9148
9149 2019-03-29  Keith Seitz  <keiths@redhat.com>
9150
9151         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9152         %s/pulongest for TYPE_LENGTH instead of %d in format
9153         strings.
9154         * ada-typerint.c (ada_print_type): Likewise.
9155         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9156         * compile/compile-c-support.c (generate_register_struct): Likewise.
9157         * gdbtypes.c (recursive_dump_type): Likewise.
9158         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9159         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9160         instead of %d in format strings.
9161         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9162         to std::min to ULONGEST.
9163         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9164         instead of %d in format strings.
9165         * tracepoint.c (info_scope_command): Likewise.
9166         * typeprint.c (print_offset_data::update)
9167         (print_offset_data::finish): Likewise.
9168         * xtensa-tdep.c (xtensa_store_return_value)
9169         (xtensa_push_dummy_call): Likewise.
9170
9171 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9172
9173         * windows-nat.c (display_selector): Fixed format specifications
9174         for 64-bit Cygwin.
9175
9176 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9177
9178         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9179
9180 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9181
9182         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9183         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9184         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9185         (nios2_linux_init_abi): Install it.
9186
9187 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9188
9189         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9190
9191 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9192
9193         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9194
9195 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9196             Tom Tromey  <tromey@adacore.com>
9197
9198         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9199
9200 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9201
9202         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9203         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9204         method to compute the bounds of range types. Also print "[evaluated]"
9205         if the bounds' values come from a dynamic evaluation.
9206
9207 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9208
9209         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9210         whitespace when pretty printing is on.
9211
9212 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9213
9214         * ppc-linux-nat.c: Add include.
9215
9216 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9217
9218         * NEWS: Mention AArch64 Pointer Authentication.
9219
9220 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9221
9222         * arm-linux-nat.c: Add include.
9223
9224 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9225
9226         * source-cache.c (source_cache::get_source_lines): Re-read
9227         fullname after calling open_source_file.
9228
9229 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9230
9231         * NEWS: Mention TLS support for FreeBSD.
9232
9233 2019-03-25  Tom Tromey  <tromey@adacore.com>
9234
9235         * minsyms.c (BUNCH_SIZE): Update comment.
9236         (~minimal_symbol_reader): Remove old comment.
9237         (compact_minimal_symbols): Update comment.
9238         (minimal_symbol_reader::install): Remove old comment.  Update
9239         other comments.
9240
9241 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9242
9243         * s390-linux-nat.c: Add include.
9244
9245 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9246
9247         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9248         Call linux_get_hwcap.
9249         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9250         Likewise.
9251         (aarch64_linux_get_hwcap): Remove function.
9252         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9253         declaration.
9254         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9255         linux_get_hwcap.
9256         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9257         * linux-tdep.c (linux_get_hwcap): Add function.
9258         (linux_get_hwcap2): Likewise.
9259         * linux-tdep.h (linux_get_hwcap): Add declaration.
9260         (linux_get_hwcap2): Likewise.
9261         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9262         (ppc_linux_get_hwcap2): Likewise.
9263         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9264         linux_get_hwcap.
9265         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9266         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9267         (ppc_linux_nat_target::read_description): Likewise.
9268         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9269         * s390-linux-nat.c: Likewise.
9270         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9271
9272 2019-03-24  Tom Tromey  <tom@tromey.com>
9273
9274         * ada-lang.c (standard_lookup): Simplify initialization.
9275         (ada_lookup_symbol_nonlocal): Simplify return.
9276         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9277         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9278         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9279         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9280         initialization.
9281         * solib.c (solib_global_lookup): Simplify.
9282         * symtab.c (null_block_symbol): Remove.
9283         (symbol_cache_lookup): Simplify returns.
9284         (lookup_language_this): Simplify returns.
9285         (lookup_symbol_aux): Simplify return.
9286         (lookup_local_symbol): Simplify returns.
9287         (lookup_global_symbol_from_objfile): Simplify return.
9288         (lookup_symbol_in_objfile_symtabs)
9289         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9290         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9291         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9292         * cp-namespace.c (cp_lookup_bare_symbol)
9293         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9294         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9295         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9296         (cp_lookup_symbol_via_imports): Simplify initialization.
9297         (find_symbol_in_baseclass): Likewise.
9298         * symtab.h (null_block_symbol): Remove.
9299         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9300         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9301         (d_lookup_symbol_module): Likewise.
9302         (find_symbol_in_baseclass): Simplify initialization.
9303
9304 2019-03-24  Tom Tromey  <tom@tromey.com>
9305
9306         * expression.h: Don't include symtab.h.
9307         (struct block): Forward declare.
9308
9309 2019-03-24  Tom Tromey  <tom@tromey.com>
9310
9311         * c-exp.y (typebase): Remove casts.
9312         * gdbtypes.c (lookup_unsigned_typename, )
9313         (lookup_signed_typename): Remove cast.
9314         * eval.c (parse_to_comma_and_eval): Remove cast.
9315         * parse.c (write_dollar_variable): Remove cast.
9316         * block.h (struct block) <superblock>: Now const.
9317         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9318         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9319         (map_block): Make "block" const.
9320         * symfile.h (struct quick_symbol_functions)
9321         <map_matching_symbols>: Constify block argument to "callback".
9322         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9323         const.
9324         (find_pc_sect_compunit_symtab): Make "b" const.
9325         (find_symbol_at_address): Likewise.
9326         (search_symbols): Likewise.
9327         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9328         (dw2_debug_names_lookup_symbol): Likewise.
9329         (dw2_map_matching_symbols): Update.
9330         * p-valprint.c (pascal_val_print): Remove "block".
9331         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9332         (aux_add_nonlocal_symbols): Make "block" const.
9333         (resolve_subexp): Remove cast.
9334         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9335         const.
9336         (iterate_over_file_blocks): Likewise.
9337         * f-exp.y (%union) <bval>: Remove.
9338         * coffread.c (patch_opaque_types): Make "b" const.
9339         * spu-tdep.c (spu_catch_start): Make "block" const.
9340         * c-valprint.c (print_unpacked_pointer): Remove "block".
9341         * symmisc.c (dump_symtab_1): Make "b" const.
9342         (block_depth): Make "block" const.
9343         * d-exp.y (%union) <bval>: Remove.
9344         * cp-support.h (cp_lookup_rtti_type): Update.
9345         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9346         * psymtab.c (psym_lookup_symbol): Make "block" const.
9347         (maintenance_check_psymtabs): Make "b" const.
9348         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9349         (enumerate_locals, enumerate_args): Update.
9350         * python/py-symtab.c (stpy_global_block): Make "block" const.
9351         (stpy_static_block): Likewise.
9352         * inline-frame.c (block_starting_point_at): Make "new_block"
9353         const.
9354         * block.c (find_block_in_blockvector): Make return type const.
9355         (blockvector_for_pc_sect): Make "b" const.
9356         (find_block_in_blockvector): Make "b" const.
9357
9358 2019-03-23  Tom Tromey  <tom@tromey.com>
9359
9360         * varobj.c (varobj_create): Update.
9361         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9362         * printcmd.c (display_command, do_one_display): Don't reset
9363         innermost_block.
9364         * parser-defs.h (enum innermost_block_tracker_type): Move to
9365         expression.h.
9366         (innermost_block): Update comment.
9367         * parse.c (parse_exp_1): Add tracker_types parameter.
9368         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9369         tracker_types parameter.  Reset innermost_block.
9370         (parse_exp_in_context): Remove.
9371         (parse_expression_for_completion): Update.
9372         * objfiles.c (~objfile): Don't reset expression_context_block or
9373         innermost_block.
9374         * expression.h (enum innermost_block_tracker_type): Move from
9375         parser-defs.h.
9376         (parse_exp_1): Add tracker_types parameter.
9377         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9378         reset innermost_block.
9379
9380 2019-03-23  Tom Tromey  <tom@tromey.com>
9381
9382         * objfiles.h: Include bcache.h.
9383
9384 2019-03-23  Tom Tromey  <tom@tromey.com>
9385
9386         * linespec.c (get_current_search_block): Use
9387         scoped_restore_current_language.
9388         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9389
9390 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9391             Jiong Wang  <jiong.wang@arm.com>
9392
9393         * aarch64-linux-tdep.c
9394         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9395         section.
9396         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9397
9398 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9399             Jiong Wang  <jiong.wang@arm.com>
9400
9401         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9402         instructions.
9403         (aarch64_analyze_prologue_test): Add PACIASP test.
9404         (aarch64_prologue_prev_register): Unmask PC value.
9405
9406 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9407             Jiong Wang  <jiong.wang@arm.com>
9408
9409         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9410         (aarch64_dwarf2_prev_register): Unmask PC value.
9411         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9412         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9413         DW_CFA_AARCH64_negate_ra_state.
9414         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9415
9416 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9417             Jiong Wang  <jiong.wang@arm.com>
9418
9419         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9420         registers.
9421         (aarch64_pseudo_register_name): Likewise.
9422         (aarch64_pseudo_register_type): Likewise.
9423         (aarch64_pseudo_register_reggroup_p): Likewise.
9424         (aarch64_gdbarch_init): Add pauth registers.
9425         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9426         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9427         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9428         (struct gdbarch_tdep): Add regnum for ra_state.
9429
9430 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9431             Jiong Wang  <jiong.wang@arm.com>
9432
9433         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9434
9435 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9436             Jiong Wang  <jiong.wang@arm.com>
9437
9438         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9439         function.
9440         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9441         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9442         (aarch64_gdbarch_init): Add puth registers.
9443         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9444         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9445         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9446
9447 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9448             Jiong Wang  <jiong.wang@arm.com>
9449
9450         * aarch64-linux-nat.c
9451         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9452         * aarch64-linux-tdep.c
9453         (aarch64_linux_core_read_description): Likewise.
9454         (aarch64_linux_get_hwcap): New function.
9455         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9456         (aarch64_linux_get_hwcap): New declaration.
9457
9458 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9459             Jiong Wang  <jiong.wang@arm.com>
9460
9461         * aarch64-linux-nat.c
9462         (aarch64_linux_nat_target::read_description): Add pauth param.
9463         * aarch64-linux-tdep.c
9464         (aarch64_linux_core_read_description): Likewise.
9465         * aarch64-tdep.c (struct target_desc): Add in pauth.
9466         (aarch64_read_description): Add pauth param.
9467         (aarch64_gdbarch_init): Likewise.
9468         * aarch64-tdep.h (aarch64_read_description): Likewise.
9469         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9470         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9471         * features/Makefile: Add new files.
9472         * features/aarch64-pauth.c: New file.
9473         * features/aarch64-pauth.xml: New file.
9474
9475 2019-03-20  Tom Tromey  <tromey@adacore.com>
9476
9477         * infrun.c (handle_inferior_event): Rename from
9478         handle_inferior_event_1.  Create a scoped_value_mark.
9479         (handle_inferior_event): Remove.
9480
9481 2019-03-19  Tom Tromey  <tromey@adacore.com>
9482
9483         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9484         * infrun.h (print_stop_event): Add "displays" parameter.
9485         * infrun.c (print_stop_event): Add "displays" parameter.
9486
9487 2019-03-19  Pedro Alves  <palves@redhat.com>
9488
9489         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9490         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9491         to -1.  Fix TABs vs spaces.
9492         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9493         * tui/tui-out.h (tui_ui_out) Add intro comments.
9494         <m_line, m_start_of_line>: In-class initialize, and add describing
9495         comment.
9496
9497 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9498
9499         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9500         variable names.
9501         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9502
9503 2019-03-18  Pedro Alves  <palves@redhat.com>
9504             Eli Zaretskii <eliz@gnu.org>
9505
9506         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9507         m_line and m_start_of_line.
9508
9509 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9510
9511         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9512         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9513         it returns a newline.  This fixes a regression in TU mode, whereby
9514         the next line is output on the same screen line as the user input.
9515
9516 2019-03-18  Tom Tromey  <tromey@adacore.com>
9517
9518         * minsyms.c (minimal_symbol_reader::install): Remove call to
9519         obstack_blank.
9520
9521 2019-03-18  Pedro Alves  <palves@redhat.com>
9522
9523         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9524         New globals.
9525         (apply_style): New, factored out from ...
9526         (apply_ansi_escape): ... this.  Handle reverse video mode.
9527         (tui_set_reverse_mode): New function.
9528         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9529         * tui/tui-winsource.c (tui_show_source_line): Use
9530         tui_set_reverse_mode instead of setting A_STANDOUT.
9531         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9532         New setter methods.
9533
9534 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9535
9536         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9537         Handle tabs.
9538
9539 2019-03-18  Tom Tromey  <tromey@adacore.com>
9540
9541         * ada-lang.c (empty_array): Add "high" parameter.
9542         (ada_evaluate_subexp): Update.
9543
9544 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9545
9546         * unittests/string_view-selftests.c: Define
9547         _initialize_string_view_selftests unconditionally.
9548
9549 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9550
9551         PR gdb/24350
9552         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9553
9554 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9555
9556         PR gdb/24351
9557         * windows-nat.c (display_selector): Fix format specifiers.
9558
9559 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9560
9561         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9562         tui_refill_source_window instead of tui_refresh_win, to update the
9563         current execution line.  This fixes redisplay of the current line
9564         when stepping through the code with "next" or "step".
9565
9566 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9567
9568         * source-cache.c (source_cache::get_source_lines): Call
9569         find_source_lines to initialize s->nlines.  This fixes vertical
9570         scrolling of TUI source window when the DOWN arrow is pressed.
9571
9572 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9573
9574         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9575         linux-thread-db.c (_initialize_thread_db): Likewise.
9576
9577 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9578
9579         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9580         wclrtoeol in tui_show_source_line".  This reverts changes made in
9581         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9582
9583 2019-03-15  Tom Tromey  <tom@tromey.com>
9584
9585         * symtab.h (struct minimal_symbol): Derive from
9586         general_symbol_info.
9587         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9588         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9589         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9590         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9591         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9592         (MSYMBOL_SEARCH_NAME): Update.
9593         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9594         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9595         * minsyms.c (minimal_symbol_reader::record_full): Update.
9596
9597 2019-03-15  Tom Tromey  <tom@tromey.com>
9598
9599         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9600
9601 2019-03-15  Tom Tromey  <tom@tromey.com>
9602
9603         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9604         unique_xmalloc_ptr.
9605         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9606         Update.
9607         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9608         (build_minimal_symbol_hash_tables)
9609         (minimal_symbol_reader::install): Update.
9610
9611 2019-03-15  Tom Tromey  <tom@tromey.com>
9612
9613         * symtab.c (create_demangled_names_hash): Update.
9614         (symbol_set_names): Update.
9615         * objfiles.h (struct objfile_per_bfd_storage)
9616         <demangled_names_hash>: Now an htab_up.
9617         * objfiles.c (objfile_per_bfd_storage): Simplify.
9618
9619 2019-03-15  Tom Tromey  <tom@tromey.com>
9620
9621         * objfiles.h (struct objfile_per_bfd_storage): Declare
9622         destructor.
9623         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9624         New.
9625         (get_objfile_bfd_data): Use new.  Don't initialize
9626         language_of_main.
9627         (free_objfile_per_bfd_storage): Remove.
9628         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9629
9630 2019-03-15  Tom Tromey  <tom@tromey.com>
9631
9632         * symfile.c (reread_symbols): Update.
9633         * objfiles.c (objfile::objfile): Update.
9634         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9635         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9636         comment.
9637         (minimal_symbol_reader::install): Update.
9638         (terminate_minimal_symbol_table): Remove.
9639         * jit.c (jit_object_close_impl): Update.
9640
9641 2019-03-15  Tom Tromey  <tom@tromey.com>
9642
9643         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9644         initializations.
9645
9646 2019-03-15  Tom Tromey  <tom@tromey.com>
9647
9648         * objfiles.h (struct objfile_per_bfd_storage)
9649         <demangled_hash_languages>: Now a bitset.
9650         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9651         (lookup_minimal_symbol): Update.
9652
9653 2019-03-15  Tom Tromey  <tom@tromey.com>
9654
9655         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9656         Don't return the symbol.
9657         * coffread.c (record_minimal_symbol): Use record_full.
9658
9659 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9660
9661         The MS-Windows port of ncurses fails to switch to a color pair if
9662         one or both of the colors are the implicit default colors.  This
9663         change records the default colors when TUI is initialized, and
9664         then specifies them explicitly when a color pair uses the default
9665         colors.  This allows color styling in TUI mode on MS-Windows.
9666
9667         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9668         ncurses_norm_attr.
9669         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9670         colors in ncurses_norm_attr.
9671         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9672         "none", replace it with the default color recorded in
9673         ncurses_norm_attr.
9674
9675 2019-03-14  Tom Tromey  <tromey@adacore.com>
9676
9677         * source-cache.h (class source_cache) <get_source_lines>: Return
9678         std::string.
9679         * source-cache.c (source_cache::extract_lines): Handle case where
9680         first_pos==npos.  Return std::string.
9681         (source_cache::get_source_lines): Update.
9682
9683 2019-03-14  Tom Tromey  <tromey@adacore.com>
9684
9685         * NEWS: Add item for "style sources" commands.
9686         * source-cache.c (source_cache::get_source_lines): Check
9687         source_styling.
9688         * cli/cli-style.c (source_styling): New global.
9689         (_initialize_cli_style): Add "style sources" commands.
9690         (show_style_sources): New function.
9691         * cli/cli-style.h (source_styling): Declare.
9692
9693 2019-03-14  Pedro Alves  <palves@redhat.com>
9694             Tom Tromey  <tromey@adacore.com>
9695
9696         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9697         * tui/tui-winsource.c (tui_refill_source_window): New function,
9698         from...
9699         (tui_horizontal_source_scroll): ... here.  Move some logic.
9700         * cli/cli-style.c (set_style_enabled): Notify new observable.
9701         * tui/tui-hooks.c (tui_redisplay_source): New function.
9702         (tui_attach_detach_observers): Attach or detach
9703         tui_redisplay_source.
9704         * observable.h (source_styling_changed): New observable.
9705         * observable.c: Define source_styling_changed observable.
9706
9707 2019-03-13  Tom Tromey  <tromey@adacore.com>
9708
9709         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9710         (i386_gnu_nat_target::store_registers): Update.
9711         * target-debug.h (target_debug_print_std_string): New macro.
9712         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9713         * windows-tdep.c (display_one_tib): Update.
9714         * tui/tui-stack.c (tui_make_status_line): Update.
9715         * top.c (print_inferior_quit_action): Update.
9716         * thread.c (thr_try_catch_cmd): Update.
9717         (add_thread_with_info): Update.
9718         (thread_target_id_str): Update.
9719         (thr_try_catch_cmd): Update.
9720         (thread_command): Update.
9721         (thread_find_command): Update.
9722         * record-btrace.c (record_btrace_target::info_record)
9723         (record_btrace_resume_thread, record_btrace_target::resume)
9724         (record_btrace_cancel_resume, record_btrace_step_thread)
9725         (record_btrace_target::wait, record_btrace_target::wait)
9726         (record_btrace_target::wait, record_btrace_target::stop): Update.
9727         * progspace.c (print_program_space): Update.
9728         * process-stratum-target.c
9729         (process_stratum_target::thread_address_space): Update.
9730         * linux-fork.c (linux_fork_mourn_inferior)
9731         (detach_checkpoint_command, info_checkpoints_command)
9732         (linux_fork_context): Update.
9733         (linux_fork_detach): Update.
9734         (class scoped_switch_fork_info): Update.
9735         (delete_checkpoint_command): Update.
9736         * infrun.c (follow_fork_inferior): Update.
9737         (follow_fork_inferior): Update.
9738         (proceed_after_vfork_done): Update.
9739         (handle_vfork_child_exec_or_exit): Update.
9740         (follow_exec): Update.
9741         (displaced_step_prepare_throw): Update.
9742         (displaced_step_restore): Update.
9743         (start_step_over): Update.
9744         (resume_1): Update.
9745         (clear_proceed_status_thread): Update.
9746         (proceed): Update.
9747         (print_target_wait_results): Update.
9748         (do_target_wait): Update.
9749         (context_switch): Update.
9750         (stop_all_threads): Update.
9751         (restart_threads): Update.
9752         (finish_step_over): Update.
9753         (handle_signal_stop): Update.
9754         (switch_back_to_stepped_thread): Update.
9755         (keep_going_pass_signal): Update.
9756         (print_exited_reason): Update.
9757         (normal_stop): Update.
9758         * inferior.c (inferior_pid_to_str): Change return type.
9759         (print_selected_inferior): Update.
9760         (add_inferior): Update.
9761         (detach_inferior): Update.
9762         * dummy-frame.c (fprint_dummy_frames): Update.
9763         * dcache.c (dcache_info_1): Update.
9764         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9765         (btrace_fetch, btrace_clear): Update.
9766         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9767         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9768         type.
9769         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9770         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9771         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9772         * gdbarch.c, gdbarch.h: Rebuild.
9773         * gdbarch.sh (core_pid_to_str): Change return type.
9774         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9775         return type.
9776         (windows_nat_target::pid_to_str): Change return type.
9777         (windows_delete_thread): Update.
9778         (windows_nat_target::attach): Update.
9779         (windows_nat_target::files_info): Update.
9780         * target-delegates.c: Rebuild.
9781         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9782         return type.
9783         (sol_thread_target::pid_to_str): Change return type.
9784         * remote.c (class remote_target) <pid_to_str>: Change return
9785         type.
9786         (remote_target::pid_to_str): Change return type.
9787         (extended_remote_target::attach, remote_target::remote_stop_ns)
9788         (remote_target::remote_notif_remove_queued_reply)
9789         (remote_target::push_stop_reply, remote_target::disable_btrace):
9790         Update.
9791         (extended_remote_target::attach): Update.
9792         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9793         type.
9794         (gdbsim_target::pid_to_str): Change return type.
9795         * ravenscar-thread.c (struct ravenscar_thread_target)
9796         <pid_to_str>: Change return type.
9797         (ravenscar_thread_target::pid_to_str): Change return type.
9798         * procfs.c (class procfs_target) <pid_to_str>: Change return
9799         type.
9800         (procfs_target::pid_to_str): Change return type.
9801         (procfs_target::attach): Update.
9802         (procfs_target::detach): Update.
9803         (procfs_target::fetch_registers): Update.
9804         (procfs_target::store_registers): Update.
9805         (procfs_target::wait): Update.
9806         (procfs_target::files_info): Update.
9807         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9808         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9809         return type.
9810         (nto_procfs_target::pid_to_str): Change return type.
9811         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9812         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9813         return type.
9814         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9815         (exit_lwp): Update.
9816         (attach_proc_task_lwp_callback, get_detach_signal)
9817         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9818         (linux_nat_target::resume, wait_lwp, stop_callback)
9819         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9820         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9821         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9822         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9823         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9824         type.
9825         (inf_ptrace_target::attach): Update.
9826         (inf_ptrace_target::files_info): Update.
9827         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9828         type.
9829         (go32_nat_target::pid_to_str): Change return type.
9830         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9831         (gnu_nat_target::wait): Update.
9832         (gnu_nat_target::wait): Update.
9833         (gnu_nat_target::resume): Update.
9834         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9835         (fbsd_nat_target::wait): Update.
9836         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9837         type.
9838         (darwin_nat_target::attach): Update.
9839         * corelow.c (class core_target) <pid_to_str>: Change return type.
9840         (core_target::pid_to_str): Change return type.
9841         * target.c (normal_pid_to_str): Change return type.
9842         (default_pid_to_str): Likewise.
9843         (target_pid_to_str): Change return type.
9844         (target_translate_tls_address): Update.
9845         (target_announce_detach): Update.
9846         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9847         return type.
9848         (bsd_uthread_target::pid_to_str): Change return type.
9849         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9850         type.
9851         (bsd_kvm_target::pid_to_str): Change return type.
9852         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9853         return type.
9854         (aix_thread_target::pid_to_str): Change return type.
9855         * target.h (struct target_ops) <pid_to_str>: Change return type.
9856         (target_pid_to_str, normal_pid_to_str): Likewise.
9857         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9858         type.
9859         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9860         type.
9861         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9862         return type.
9863         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9864         type.
9865         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9866         type.
9867         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9868         return type.
9869
9870 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9871
9872         * NEWS: Mention that the new default MI version is 3.  Mention
9873         changes to the output of commands and events that deal with
9874         multi-location breakpoints.
9875         * breakpoint.c: Include "mi/mi-out.h".
9876         (print_one_breakpoint): Change output syntax if using MI version
9877         >= 3.
9878         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9879         New.
9880         (mi_multi_location_breakpoint_output_fixed): New.
9881         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9882         (mi_cmd_fix_multi_location_breakpoint_output): New.
9883         (mi_multi_location_breakpoint_output_fixed): New.
9884         * mi/mi-cmds.c (mi_cmds): Register command
9885         -fix-multi-location-breakpoint-output.
9886         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9887         interpreter "mi".
9888
9889 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9890
9891         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9892         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9893         instantiate mi_ui_out based on interpreter name.
9894         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9895         * mi/mi-main.c (mi_load_progress): Likewise.
9896
9897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9898
9899         * NEWS: Combine separate "New targets" sections for 8.3.
9900
9901 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9902
9903         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9904         (ppcfbsd_init_abi): Install gdbarch
9905         "fetch_tls_load_module_address" and "get_thread_local_address"
9906         methods.
9907
9908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9909
9910         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9911         (riscv_fbsd_init_abi): Install gdbarch
9912         "fetch_tls_load_module_address" and "get_thread_local_address"
9913         methods.
9914
9915 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9916
9917         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9918         (i386fbsd_init_abi): Install gdbarch
9919         "fetch_tls_load_module_address" and "get_thread_local_address"
9920         methods.
9921
9922 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9923
9924         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9925         (amd64fbsd_init_abi): Install gdbarch
9926         "fetch_tls_load_module_address" and "get_thread_local_address"
9927         methods.
9928
9929 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9930
9931         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9932         (struct fbsd_pspace_data): New type.
9933         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9934         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9935         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9936         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9937         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9938
9939 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9940
9941         * gdbtypes.c (lookup_struct_elt): New function.
9942         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9943         * gdbtypes.h (struct struct_elt): New type.
9944         (lookup_struct_elt): New prototype.
9945
9946 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9947
9948         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9949         remove disabled code block.
9950
9951 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9952
9953         * gdbarch.sh (get_thread_local_address): New method.
9954         * gdbarch.h, gdbarch.c: Regenerate.
9955         * target.c (target_translate_tls_address): Use
9956         gdbarch_get_thread_local_address if present instead of
9957         target::get_thread_local_address.
9958
9959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9960
9961         * target.h (target::get_thread_local_address): Update comment.
9962
9963 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9964
9965         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9966         objfile->separate_debug_objfile_backlink if not NULL.
9967
9968 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9969
9970         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9971         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9972         (amd64bsd_store_inferior_registers): Likewise.
9973         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9974         Enable segment base registers.
9975         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9976         PT_GETFSBASE and PT_GETGSBASE.
9977         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9978         PT_SETGSBASE.
9979         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9980         segment base registers.
9981         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9982
9983 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9984
9985         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9986         Update calls to i386_target_description to add 'segments'
9987         parameter.
9988         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9989         add segment base registers.
9990         * arch/i386.c (i386_create_target_description): Add 'segments'
9991         parameter to enable segment base registers.
9992         * arch/i386.h (i386_create_target_description): Likewise.
9993         * features/i386/32bit-segments.xml: New file.
9994         * features/i386/32bit-segments.c: Generate.
9995         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9996         call to i386_target_description to add 'segments' parameter.
9997         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9998         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9999         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10000         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10001         if feature is present.
10002         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10003         Add 'segments' parameter to call to i386_target_description.
10004         (i386_target_description): Add 'segments' parameter to enable
10005         segment base registers.
10006         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10007         to call to i386_target_description.
10008         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10009         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10010         Define I386_NUM_REGS.
10011         (i386_target_description): Add 'segments' parameter to enable
10012         segment base registers.
10013
10014 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10015
10016         PR/24325
10017         * source-cache.c: #undef open and close, to avoid unresolved
10018         externals during linking.
10019
10020 2019-03-12  Tom Tromey  <tromey@adacore.com>
10021
10022         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10023         const.  Add initializers.
10024         (_initialize_remote): Don't initialize ptid globals.
10025
10026 2019-03-12  Pedro Alves  <palves@redhat.com>
10027
10028         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10029
10030 2019-03-12  Pedro Alves  <palves@redhat.com>
10031
10032         * cp-name-parser.y (main): Remove unused 'len' variable.
10033
10034 2019-03-12  Tom Tromey  <tromey@adacore.com>
10035
10036         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10037         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10038
10039 2019-03-12  Tom Tromey  <tromey@adacore.com>
10040
10041         * linux-nat.c (iterate_over_lwps): Update.
10042         (stop_callback): Remove parameter.
10043         (stop_wait_callback, detach_callback, resume_set_callback)
10044         (select_singlestep_lwp_callback, set_ignore_sigint)
10045         (status_callback, resumed_callback, resume_clear_callback)
10046         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10047         data parameter.
10048         (linux_nat_target::detach, linux_nat_target::resume)
10049         (linux_stop_and_wait_all_lwps, select_event_lwp)
10050         (linux_nat_filter_event, linux_nat_wait_1)
10051         (linux_nat_target::kill, linux_nat_target::stop)
10052         (linux_nat_target::stop): Update.
10053         (linux_nat_resume_callback): Change type.
10054         (resume_stopped_resumed_lwps, count_events_callback)
10055         (select_event_lwp_callback): Likewise.
10056         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10057         * arm-linux-nat.c (struct update_registers_data): Remove.
10058         (update_registers_callback): Change type.
10059         (arm_linux_insert_hw_breakpoint1): Update.
10060         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10061         parameter.
10062         (x86_linux_dr_set_addr): Update.
10063         (x86_linux_dr_set_control): Update.
10064         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10065         (iterate_over_lwps): Use gdb::function_view.
10066         * nat/aarch64-linux-hw-point.c (struct
10067         aarch64_dr_update_callback_param): Remove.
10068         (debug_reg_change_callback): Change type.
10069         (aarch64_notify_debug_reg_change): Update.
10070         * s390-linux-nat.c (s390_refresh_per_info): Update.
10071
10072 2019-03-11  Tom Tromey  <tromey@adacore.com>
10073
10074         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10075         redundant assignment to "this_cu".
10076
10077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10078
10079         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10080
10081 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10082
10083         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10084         from...
10085         (rank_one_type): ... this.
10086
10087 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10088
10089         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10090         from...
10091         (rank_one_type): ... this.
10092
10093 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10094
10095         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10096         from...
10097         (rank_one_type): ... this.
10098
10099 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10100
10101         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10102         from...
10103         (rank_one_type): ... this.
10104
10105 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10106
10107         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10108         from...
10109         (rank_one_type): ... this.
10110
10111 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10112
10113         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10114         from...
10115         (rank_one_type): ... this.
10116
10117 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10118
10119         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10120         from...
10121         (rank_one_type): ... this.
10122
10123 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10124
10125         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10126         from...
10127         (rank_one_type): ... this.
10128
10129 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10130
10131         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10132         from...
10133         (rank_one_type): ... this.
10134
10135 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10136
10137         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10138         from...
10139         (rank_one_type): ... this.
10140
10141 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10142
10143         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10144         from...
10145         (rank_one_type): ... this.
10146
10147 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10148
10149         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10150         from...
10151         (rank_one_type): ... this.
10152
10153 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10154
10155         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10156         inferior-events' shows the example events.
10157
10158 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10159
10160         Support styling on native MS-Windows console
10161
10162         PR/24315
10163         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10164         on MS-Windows if $TERM is not defined.
10165
10166         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10167
10168         * posix-hdep.c (gdb_console_fputs):
10169         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10170         functions.
10171         * ui-file.h (gdb_console_fputs): Add prototype.
10172
10173         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10174         back to fputs only if the former returns zero.
10175
10176 2019-03-07  Tom Tromey  <tom@tromey.com>
10177
10178         * symmisc.c (print_symbol_bcache_statistics): Update.
10179         (print_objfile_statistics): Update.
10180         * symfile.c (allocate_symtab): Update.
10181         * stabsread.c: Don't include bcache.h.
10182         * psymtab.h (struct psymbol_bcache): Don't declare.
10183         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10184         (psymbol_bcache_init, psymbol_bcache_free)
10185         (psymbol_bcache_get_bcache): Don't declare.
10186         * psymtab.c (struct psymbol_bcache): Remove.
10187         (psymtab_storage::psymtab_storage): Update.
10188         (psymtab_storage::~psymtab_storage): Update.
10189         (psymbol_bcache_init, psymbol_bcache_free)
10190         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10191         (add_psymbol_to_bcache): Update.
10192         (allocate_psymtab): Update.
10193         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10194         macro_cache>: No longer pointers.
10195         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10196         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10197         * macrotab.c (macro_bcache): Update.
10198         * macroexp.c: Don't include bcache.h.
10199         * gdbtypes.c (check_types_worklist): Update.
10200         (types_deeply_equal): Remove TRY/CATCH.  Update.
10201         * elfread.c (elf_symtab_read): Update.
10202         * dwarf2read.c: Don't include bcache.h.
10203         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10204         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10205         (print_bcache_statistics, bcache_memory_used): Don't declare.
10206         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10207         methods.  Rename all data members.
10208         * bcache.c (struct bcache): Move to bcache.h.
10209         (bcache::expand_hash_table): Rename from expand_hash_table.
10210         (bcache): Remove.
10211         (bcache::insert): Rename from bcache_full.
10212         (bcache::compare): Rename from bcache_compare.
10213         (bcache_xmalloc): Remove.
10214         (bcache::~bcache): Rename from bcache_xfree.
10215         (bcache::print_statistics): Rename from print_bcache_statistics.
10216         (bcache::memory_used): Rename from bcache_memory_used.
10217
10218 2019-03-07  Pedro Alves  <palves@redhat.com>
10219
10220         * infrun.c (normal_stop): Also check for
10221         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10222
10223 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10224
10225         * f-lang.c (value_from_host_double): Moved to...
10226         * value.c (value_from_host_double): ...here.
10227         * value.h (value_from_host_double): Declare.
10228         * guile/scm-math.c (vlscm_convert_typed_number): Use
10229         value_from_host_double.
10230         (vlscm_convert_number): Likewise.
10231         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10232         * python/py-value.c (convert_value_from_python): Likewise.
10233
10234 2019-03-06  Tom Tromey  <tom@tromey.com>
10235
10236         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10237
10238 2019-03-06  Tom Tromey  <tom@tromey.com>
10239
10240         * utils.h (free_current_contents): Don't declare.
10241         * utils.c (free_current_contents): Remove.
10242
10243 2019-03-06  Tom Tromey  <tom@tromey.com>
10244
10245         * top.c (quit_force): Update.
10246         * main.c (captured_command_loop): Update.
10247         * common/new-op.c (operator new): Update.
10248         * common/common-exceptions.c (struct catcher)
10249         <save_cleanup_chain>: Remove member.
10250         (exceptions_state_mc_init): Update.
10251         (exception_try_scope_entry): Return nullptr.
10252         (exception_try_scope_exit, exception_rethrow)
10253         (throw_exception_sjlj, throw_exception_cxx): Update.
10254         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10255         (all_cleanups, do_cleanups, discard_cleanups)
10256         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10257         (restore_cleanups, restore_final_cleanups): Don't declare.
10258         (do_final_cleanups): Remove parameter.
10259         * common/cleanups.c (cleanup_chain, make_cleanup)
10260         (make_cleanup_dtor, all_cleanups, do_cleanups)
10261         (discard_my_cleanups, discard_cleanups)
10262         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10263         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10264         (null_cleanup): Remove.
10265         (do_final_cleanups): Remove parameter.
10266
10267 2019-03-06  Tom Tromey  <tom@tromey.com>
10268
10269         * remote.c (remote_target::remote_parse_stop_reply): Use
10270         unique_xmalloc_ptr.
10271
10272 2019-03-06  Tom Tromey  <tom@tromey.com>
10273
10274         * stabsread.c (struct stabs_field_info): Rename from field_info.
10275         <list, fnlist>: Add initializers.
10276         <obstack>: New member.
10277         (read_member_functions, read_struct_fields, read_baseclasses):
10278         Allocate on obstack.  Don't use cleanups.
10279         (read_one_struct_field, read_member_functions, read_struct_fields)
10280         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10281         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10282         (read_struct_type): Update.
10283
10284 2019-03-06  Tom Tromey  <tom@tromey.com>
10285
10286         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10287         * common/filestuff.h (make_cleanup_close): Don't declare.
10288         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10289         Remove.
10290
10291 2019-03-06  Tom Tromey  <tom@tromey.com>
10292
10293         * solib-aix.c: Use make_scope_exit.
10294
10295 2019-03-06  Tom Tromey  <tom@tromey.com>
10296
10297         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10298         Use make_scope_exit.
10299
10300 2019-03-06  Tom Tromey  <tom@tromey.com>
10301
10302         * solib-svr4.c (disable_probes_interface): Remove parameter.
10303         (svr4_handle_solib_event): Use make_scope_exit.
10304
10305 2019-03-06  Tom Tromey  <tom@tromey.com>
10306
10307         * remote.c (struct stop_reply_deleter): Remove.
10308         (stop_reply_up): Update.
10309         (struct stop_reply): Derive from notif_event.  Don't typedef.
10310         <regcache>: Now a std::vector.
10311         (stop_reply_xfree): Remove.
10312         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10313         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10314         (remote_target::discard_pending_stop_replies): Use delete.
10315         (remote_target::remote_parse_stop_reply): Update.
10316         (remote_target::process_stop_reply): Update.
10317         * remote-notif.h (struct notif_event): Add virtual destructor.
10318         Remove "dtr" member.
10319         (struct notif_client) <alloc_event>: Return a unique_ptr.
10320         (notif_event_xfree): Don't declare.
10321         (notif_event_up): New typedef.
10322         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10323         (notif_event_xfree, do_notif_event_xfree): Remove.
10324         (remote_notif_state_xfree): Update.
10325
10326 2019-03-06  Tom Tromey  <tom@tromey.com>
10327
10328         * infrun.c (displaced_step_clear_cleanup): Now a
10329         forward_scope_exit type.
10330         (displaced_step_prepare_throw): Update.
10331         (displaced_step_fixup): Update.
10332
10333 2019-03-06  Tom Tromey  <tom@tromey.com>
10334
10335         * inferior.h (class inferior): Update comment.
10336         * gdbthread.h (class thread_info): Update comment.
10337
10338 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10339             Tom Tromey  <tom@tromey.com>
10340
10341         * stabsread.h (struct stab_section_list): Remove.
10342         (coffstab_build_psymtabs): Update.
10343         * dbxread.c (symbuf_sections): Now a std::vector.
10344         (sect_idx): New global.
10345         (fill_symbuf): Update.
10346         (coffstab_build_psymtabs): Change type of stabsects parameter.
10347         Update.
10348         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10349         std::vector.
10350         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10351         (coff_locate_sections): Update.
10352         (coff_symfile_read): Remove cleanups.  Update.
10353         (init_stringtab): Add storage parameter.
10354         (free_stringtab, free_stringtab_cleanup): Remove.
10355         (init_lineno): Add storage parameter.
10356         (free_linetab, free_linetab_cleanup): Remove.
10357
10358 2019-03-06  Pedro Alves  <palves@redhat.com>
10359
10360         * linux-fork.c (fork_info::clobber_regs): Delete.
10361         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10362         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10363         comment.  Adjust.
10364         (scoped_switch_fork_info::scoped_switch_fork_info)
10365         (checkpoint_command, linux_fork_context): Adjust
10366         fork_save_infrun_state calls.
10367
10368 2019-03-06  Pedro Alves  <palves@redhat.com>
10369
10370         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10371         (inf_has_multiple_threads): Return 'bool' and rewrite using
10372         inferior_info::threads().
10373
10374 2019-03-06  Pedro Alves  <palves@redhat.com>
10375
10376         * linux-fork.c: Include <list>.
10377         (fork_list): Now a std::list instance.
10378         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10379         (forks_exist_p, find_last_fork): Adjust.
10380         (new_fork): Delete.
10381         (one_fork_p): New.
10382         (add_fork): Adjust.
10383         (free_fork): Delete, folded into fork_info::~fork_info().
10384         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10385         Adjust.
10386         (init_fork_list): Delete.
10387         (linux_fork_killall, linux_fork_mourn_inferior)
10388         (linux_fork_detach, info_checkpoints_command): Adjust.
10389         (_initialize_linux_fork): No longer call init_fork_list.
10390
10391 2019-03-06  Pedro Alves  <palves@redhat.com>
10392
10393         * linux-fork.c (new_fork): New, split out of ...
10394         (add_fork): ... this.  Return void.  Move "first fork" special
10395         case from here, to ...
10396         (checkpoint_command): ... here.
10397         * linux-linux.h (add_fork): Return void.
10398
10399 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10400
10401         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10402
10403 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10404             Chris January  <chris.january@arm.com>
10405             David Lecomber  <david.lecomber@arm.com>
10406
10407         * f-exp.y: New token, UNOP_INTRINSIC.
10408         (exp): New pattern using UNOP_INTRINSIC token.
10409         (f77_keywords): Add 'abs' keyword.
10410         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10411         (value_from_host_double): New function.
10412         (evaluate_subexp_f): Support UNOP_ABS.
10413
10414 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10415
10416         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10417         types.
10418
10419 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10420
10421         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10422         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10423         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10424
10425 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10426
10427         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10428
10429 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10430             Chris January  <chris.january@arm.com>
10431
10432         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10433         * f-exp.y: Define 'KIND' token.
10434         (exp): New pattern for KIND expressions.
10435         (ptype): Handle types with a kind extension.
10436         (direct_abs_decl): Extend to spot kind extensions.
10437         (f77_keywords): Add 'kind' to the list.
10438         (push_kind_type): New function.
10439         (convert_to_kind_type): New function.
10440         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10441         * parse.c (operator_length_standard): Likewise.
10442         * parser-defs.h (enum type_pieces): Add tp_kind.
10443         * std-operator.def: Add UNOP_KIND.
10444
10445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10446
10447         * f-exp.y (f_parse): Set yydebug.
10448
10449 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10450
10451         * f-lang.c (evaluate_subexp_f): New function.
10452         (exp_descriptor_f): New global.
10453         (f_language_defn): Use exp_descriptor_f instead of
10454         exp_descriptor_standard.
10455
10456 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10457
10458         * f-exp.y (struct token): Add comments.
10459         (dot_ops): Remove uppercase versions and the end marker.
10460         (f77_keywords): Likewise.
10461         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10462         entries in the dot_ops array are case insensitive, and use
10463         strncasecmp to compare strings.  Also some whitespace cleanup in
10464         this area.  Similar for the f77_keywords array, except entries in
10465         this list might be case sensitive.
10466
10467 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10468
10469         * f-exp.y (struct f77_boolean_val): Add comments.
10470         (boolean_values): Remove uppercase versions, and end marker.
10471         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10472         and use strncasecmp to achieve case insensitivity.  Additionally,
10473         perform whitespace cleanup around this code.
10474
10475 2019-03-06  Tom Tromey  <tromey@adacore.com>
10476
10477         * remote-sim.c (gdbsim_target_open): Use result of
10478         gdb_argv::release.
10479
10480 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10481         Dirk Schubert  <dirk.schubert@arm.com>
10482         Chris January  <chris.january@arm.com>
10483
10484         * eval.c (evaluate_subexp_standard): Call Fortran argument
10485         wrapping logic.
10486         * f-lang.c (struct value): A value which can be passed into a
10487         Fortran function call.
10488         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10489         where appropriate.
10490         (struct type): Value ready for a Fortran function call.
10491         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10492         is needed.
10493         * f-lang.h (fortran_argument_convert): Declaration.
10494         (fortran_preserve_arg_pointer): Declaration.
10495         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10496
10497 2019-03-05  Tom Tromey  <tromey@adacore.com>
10498
10499         * python/py-prettyprint.c (print_string_repr): Remove #if.
10500         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10501
10502 2019-03-05  Tom Tromey  <tromey@adacore.com>
10503
10504         * target.c (the_dummy_target): Move later.  Change type to
10505         "dummy_target".
10506         (initialize_targets): Don't initialize the_dummy_target.
10507
10508 2019-03-05  Tom Tromey  <tromey@adacore.com>
10509
10510         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10511         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10512
10513 2019-03-05  Tom Tromey  <tromey@adacore.com>
10514
10515         * windows-nat.c (windows_nat_target::attach)
10516         (windows_nat_target::detach): Don't call gdb_flush.
10517         * valprint.c (generic_val_print, val_print, val_print_string):
10518         Don't call gdb_flush.
10519         * utils.c (defaulted_query): Don't call gdb_flush.
10520         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10521         * target.c (target_announce_detach): Don't call gdb_flush.
10522         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10523         * remote.c (extended_remote_target::attach): Don't call
10524         gdb_flush.
10525         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10526         * printcmd.c (do_examine): Don't call gdb_flush.
10527         (info_display_command): Don't call gdb_flush.
10528         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10529         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10530         * memattr.c (info_mem_command): Don't call gdb_flush.
10531         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10532         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10533         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10534         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10535         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10536         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10537         (gnu_nat_target::detach): Don't call gdb_flush.
10538         * f-valprint.c (f_val_print): Don't call gdb_flush.
10539         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10540         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10541         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10542         gdb_flush.
10543         * c-valprint.c (c_val_print): Don't call gdb_flush.
10544         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10545
10546 2019-03-05  Tom Tromey  <tromey@adacore.com>
10547
10548         * varobj.c (update_dynamic_varobj_children): Update.
10549         (install_default_visualizer): Use reset, not release.
10550         * value.c (set_internalvar): Update.
10551         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10552         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10553         ATTRIBUTE_UNUSED_RESULT.
10554
10555 2019-03-05  Tom Tromey  <tromey@adacore.com>
10556
10557         * remote.c (class scoped_remote_fd) <release>: Add
10558         ATTRIBUTE_UNUSED_RESULT.
10559
10560 2019-03-05  Tom Tromey  <tromey@adacore.com>
10561
10562         * macroexp.c (struct macro_buffer) <release>: Add
10563         ATTRIBUTE_UNUSED_RESULT.
10564
10565 2019-03-05  Tom Tromey  <tromey@adacore.com>
10566
10567         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10568         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10569         ATTRIBUTE_UNUSED_RESULT.
10570
10571 2019-03-05  Tom Tromey  <tromey@adacore.com>
10572
10573         * common/scoped_fd.h (class scoped_fd) <release>: Add
10574         ATTRIBUTE_UNUSED_RESULT.
10575
10576 2019-03-05  Tom Tromey  <tromey@adacore.com>
10577
10578         * parser-defs.h (struct parser_state) <release>: Add
10579         ATTRIBUTE_UNUSED_RESULT.
10580
10581 2019-03-05  Tom Tromey  <tromey@adacore.com>
10582
10583         * utils.h (class gdb_argv) <release>: Add
10584         ATTRIBUTE_UNUSED_RESULT.
10585         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10586
10587 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10588
10589         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10590         for-loop range, to avoid compiler warnings.
10591
10592         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10593         avoid compiler warnings about unused variables.
10594
10595         * NEWS: Mention end of support for native debugging on MS-Windows
10596         before XP.
10597
10598         PR gdb/24292
10599         * common/netstuff.c:
10600         * gdbserver/gdbreplay.c
10601         * gdbserver/remote-utils.c:
10602         * ser-tcp.c:
10603         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10604         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10605         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10606         'getaddrinfo' and 'freeaddrinfo' were not available before
10607         Windows XP, and mingw.org's MinGW headers by default define
10608         _WIN32_WINNT to 0x500.
10609
10610 2019-03-01  Gary Benson <gbenson@redhat.com>
10611
10612         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10613
10614 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10615             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10616
10617         PR gdb/8527
10618         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10619         set_sigint_trap, clear_sigint_trap.
10620
10621 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10622
10623         * target.c (target_detach): Clear the regcache and the
10624         frame cache.
10625
10626 2019-02-27  Pedro Alves  <palves@redhat.com>
10627
10628         * utils.c (set_screen_size): When we cap the height/width sizes,
10629         tweak the corresponding command variable to show "unlimited":
10630
10631 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10632             Pedro Alves  <palves@redhat.com>
10633
10634         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10635         before calling rl_set_screen_size.
10636
10637 2019-02-27  Tom Tromey  <tromey@adacore.com>
10638
10639         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10640         define.
10641         * python/py-value.c: Remove Python 2.4 workaround.
10642         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10643         workaround.
10644         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10645         Python 2.4 workaround.
10646         * python/python-internal.h: Remove Python 2.4 comment.
10647         (Py_ssize_t): Don't define.
10648         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10649         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10650         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10651         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10652         * python/python.c (do_start_initialization): Remove Python 2.4
10653         workaround.
10654         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10655         (print_children): Remove Python 2.4 workaround.
10656         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10657         workaround.
10658         (CHARBUFFERPROC_NAME): Remove.
10659         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10660         Python 2.4 workaround.
10661
10662 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10663
10664         * NEWS: Note minimum Python version.
10665
10666 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10667
10668         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10669         code from these functions.  Remove corresponding ifdefs.  Use
10670         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10671         Remove gotos and target of gotos.
10672         (infpy_search_memory): Likewise.
10673
10674 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10675
10676         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10677         (hppa_gdbarch_init): Don't register deleted functions with
10678         gdbarch.
10679
10680 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10681
10682         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10683         (h8300_unwind_sp): Delete.
10684         (h8300_dummy_id): Delete.
10685         (h8300_gdbarch_init): Don't register deleted functions with
10686         gdbarch.
10687
10688 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10689
10690         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10691         (ft32_unwind_pc): Delete.
10692         (ft32_unwind_sp): Delete.
10693         (ft32_gdbarch_init): Don't register deleted functions with
10694         gdbarch.
10695
10696 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10697
10698         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10699         (frv_unwind_pc): Delete.
10700         (frv_unwind_sp): Delete.
10701         (frv_gdbarch_init): Don't register deleted functions with
10702         gdbarch.
10703
10704 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10705
10706         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10707         (riscv_unwind_pc): Delete.
10708         (riscv_unwind_sp): Delete.
10709         (riscv_gdbarch_init): Don't register deleted functions with
10710         gdbarch.
10711
10712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10713
10714         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10715         (csky_unwind_pc): Delete.
10716         (csky_unwind_sp): Delete.
10717         (csky_gdbarch_init): Don't register deleted functions with
10718         gdbarch.
10719
10720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10721
10722         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10723         (cris_unwind_pc): Delete.
10724         (cris_unwind_sp): Delete.
10725         (cris_gdbarch_init): Don't register deleted functions with
10726         gdbarch.
10727
10728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10729
10730         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10731         (bfin_unwind_pc): Delete.
10732         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10733
10734 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10735
10736         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10737         (arm_unwind_pc): Delete.
10738         (arm_unwind_sp): Delete.
10739         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10740
10741 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10742
10743         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10744         (arc_unwind_pc): Delete.
10745         (arc_unwind_sp): Delete.
10746         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10747
10748 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10749
10750         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10751         (alpha_unwind_pc): Delete.
10752         (alpha_gdbarch_init): Don't register deleted functions with
10753         gdbarch.
10754
10755 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10756
10757         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10758         (aarch64_unwind_pc): Delete.
10759         (aarch64_unwind_sp): Delete.
10760         (aarch64_gdbarch_init): Don't register deleted functions with
10761         gdbarch.
10762
10763 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10764
10765         * gdbtypes.c (type_align): Don't consider static members when
10766         computing structure alignment.
10767
10768 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10769
10770         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10771         return 0 for other types.
10772         * arch-utils.c (default_type_align): Always return 0.
10773         * gdbarch.h: Regenerate.
10774         * gdbarch.sh (type_align): Extend comment.
10775         * gdbtypes.c (type_align): Add additional comments, always call
10776         gdbarch_type_align before applying the default rules.
10777         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10778         generic code will then apply a suitable default.
10779         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10780         types, return 0 for other types.
10781
10782 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10783
10784         * NEWS: Create a new section for the next release branch.
10785         Rename the section of the current branch, now that it has
10786         been cut.
10787
10788 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10789
10790         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10791         * version.in: Bump version to 8.3.50.DATE-git.
10792
10793 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10794
10795         * aix-thread.c (ptid_cmp): Remove unused variable.
10796         (get_signaled_thread): Likewise.
10797         (store_regs_user_thread): Likewise.
10798         (store_regs_kernel_thread): Likewise.
10799         (fetch_regs_kernel_thread): Remove shadowed variable.
10800
10801 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10802
10803         * features/riscv/32bit-cpu.xml: Add register numbers.
10804         * features/riscv/32bit-fpu.c: Regenerate.
10805         * features/riscv/32bit-fpu.xml: Add register numbers.
10806         * features/riscv/64bit-cpu.xml: Add register numbers.
10807         * features/riscv/64bit-fpu.c: Regenerate.
10808         * features/riscv/64bit-fpu.xml: Add register numbers.
10809
10810 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10811
10812         * NEWS: Mention two argument form of gdb.Value constructor.
10813         * python/py-value.c (convert_buffer_and_type_to_value): New
10814         function.
10815         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10816         Add support for handling an optional second argument.  Call
10817         convert_buffer_and_type_to_value as appropriate.
10818         * python/python-internal.h (Py_buffer_deleter): New struct.
10819         (Py_buffer_up): New typedef.
10820
10821 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10822
10823         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10824         instead of releasing ownership.
10825
10826 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10827
10828         * dwarf2read.c (open_and_init_dwp_file): Call
10829         elf_numsections instead of bfd_count_sections to initialize
10830         dwp_file->num_sections.
10831
10832 2019-02-25  Tom Tromey  <tromey@adacore.com>
10833
10834         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10835
10836 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10837
10838         * gcore.in: Add '--readnever' option when invoking GDB.
10839
10840 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10841
10842         * MAINTAINERS: Update my email address.
10843
10844 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10845
10846         * build-id.c (build_id_to_debug_bfd_1): New function.
10847         (build_id_to_debug_bfd): Look for separate debug file in
10848         sysroot.
10849
10850 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10851
10852         * gdbarch.sh: Update the copyright year range that is placed into
10853         generated files.
10854
10855 2019-02-22  Keith Seitz  <keiths@redhat.com>
10856
10857         PR symtab/23853
10858         * linespec.c (create_sals_line_offset): Search for the default
10859         symtab's filename instead of its fullname.
10860
10861 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10862
10863         * NEWS: Update style defaults.
10864
10865 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10866
10867         * main.c (captured_main_1): Disable styling in batch mode.
10868
10869 2019-02-20  Tom Tromey  <tom@tromey.com>
10870
10871         * symtab.c (symtab_symbol_info): Fix typos.
10872
10873 2019-02-20  Tom Tromey  <tromey@adacore.com>
10874
10875         * findcmd.c (_initialize_mem_search): Use upper case for
10876         metasyntactic variables.
10877
10878 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10879
10880         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10881         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10882
10883 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10884
10885         * top.h (source_file_name): Change to std::string.
10886         * top.c (source_file_name): Likewise.
10887         (command_line_input): Adjust.
10888         * cli/cli-script.c (script_from_file): Adjust.
10889
10890 2019-02-19  Tom Tromey  <tromey@adacore.com>
10891
10892         * ravenscar-thread.c
10893         (ravenscar_thread_target::update_thread_list): Don't call
10894         ada_build_task_list.
10895         * ada-lang.h (ada_build_task_list): Don't declare.
10896         * ada-tasks.c (struct ada_tasks_inferior_data)
10897         <task_list_valid_p>: Now bool.
10898         (read_known_tasks, ada_task_list_changed)
10899         (ada_tasks_invalidate_inferior_data): Update.
10900         (read_known_tasks_array): Return bool.
10901         (read_known_tasks_list): Likewise.
10902         (read_known_tasks): Return void.
10903         (ada_build_task_list): Now static.
10904
10905 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10906
10907         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10908         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10909
10910 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10911
10912         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10913         variant for ada_tasks_pspace_data_handle and
10914         ada_tasks_inferior_data_handle.
10915         (ada_tasks_pspace_data_cleanup): New function.
10916         (ada_tasks_inferior_data_cleanup): New function.
10917
10918 2019-02-17  Tom Tromey  <tom@tromey.com>
10919
10920         * macrotab.h (macro_source_fullname): Return a std::string.
10921         * macrotab.c (macro_include, check_for_redefinition)
10922         (macro_undef, macro_lookup_definition, foreach_macro)
10923         (foreach_macro_in_scope): Update.
10924         (macro_source_fullname): Return a std::string.
10925         * macrocmd.c (show_pp_source_pos): Update.
10926
10927 2019-02-17  Tom Tromey  <tom@tromey.com>
10928
10929         * macrocmd.c (show_pp_source_pos): Style the file names.
10930
10931 2019-02-17  Tom Tromey  <tom@tromey.com>
10932
10933         PR tui/24197:
10934         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10935
10936 2019-02-17  Tom Tromey  <tom@tromey.com>
10937
10938         * ada-lang.c (user_select_syms): Use filtered printing.
10939         * utils.c (wrap_style): New global.
10940         (desired_style): Remove.
10941         (emit_style_escape): Add stream parameter.
10942         (set_output_style, reset_terminal_style, prompt_for_continue):
10943         Update.
10944         (flush_wrap_buffer): Only flush gdb_stdout.
10945         (wrap_here): Set wrap_style.
10946         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10947         treat escape sequences as a character.  Change when wrap buffer is
10948         flushed.
10949         (fputs_styled): Do not set the output style when the default is
10950         requested.
10951         * ui-style.h (struct ui_file_style) <is_default>: New method.
10952         * source.c (print_source_lines_base): Emit escape sequences in one
10953         piece.
10954
10955 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10956
10957         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10958         integers and enumeration types.
10959
10960 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10961
10962         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10963         instead of lookup_symbol_in_language
10964         (do_exact_match): New function.
10965         (ada_get_symbol_name_matcher): Return do_exact_match when
10966         doing a verbatim match.
10967
10968 2019-02-15  Tom Tromey  <tromey@adacore.com>
10969
10970         * ravenscar-thread.c (ravenscar_thread_target::resume)
10971         (ravenscar_thread_target::wait): Special case wildcard requests.
10972
10973 2019-02-15  Tom Tromey  <tromey@adacore.com>
10974
10975         * ravenscar-thread.c (base_ptid): Remove.
10976         (struct ravenscar_thread_target) <close>: New method.
10977         <m_base_ptid>: New member.
10978         <update_inferior_ptid, active_task, task_is_currently_active,
10979         runtime_initialized>: Declare methods.
10980         <ravenscar_thread_target>: Add constructor.
10981         (ravenscar_thread_target::task_is_currently_active)
10982         (ravenscar_thread_target::update_inferior_ptid)
10983         (ravenscar_runtime_initialized): Rename.  Now methods.
10984         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10985         (ravenscar_thread_target::update_thread_list): Update.
10986         (ravenscar_thread_target::active_task): Now method.
10987         (ravenscar_thread_target::store_registers)
10988         (ravenscar_thread_target::prepare_to_store)
10989         (ravenscar_thread_target::prepare_to_store)
10990         (ravenscar_thread_target::mourn_inferior): Update.
10991         (ravenscar_inferior_created): Use "new" to create target.
10992         (ravenscar_thread_target::get_ada_task_ptid): Update.
10993         (_initialize_ravenscar): Don't initialize base_ptid.
10994         (ravenscar_ops): Remove global.
10995
10996 2019-02-15  Tom Tromey  <tromey@adacore.com>
10997
10998         * target.h (push_target): Declare new overload.
10999         * target.c (push_target): New overload, taking an rvalue reference.
11000         * remote.c (remote_target::open_1): Use push_target overload.
11001         * corelow.c (core_target_open): Use push_target overload.
11002
11003 2019-02-15  Tom Tromey  <tromey@adacore.com>
11004
11005         * ravenscar-thread.c (is_ravenscar_task)
11006         (ravenscar_task_is_currently_active): Return bool.
11007         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11008         (_initialize_ravenscar): Remove "(void)".
11009         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11010         Return bool.
11011
11012 2019-02-15  Tom Tromey  <tromey@adacore.com>
11013
11014         * ravenscar-thread.c (ravenscar_runtime_initializer)
11015         (has_ravenscar_runtime, get_running_thread_id)
11016         (ravenscar_thread_target::resume): Fix indentation.
11017
11018 2019-02-15  Tom Tromey  <tromey@adacore.com>
11019
11020         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11021         from ravenscar_arch_ops.
11022         (sparc_ravenscar_ops::fetch_registers)
11023         (sparc_ravenscar_ops::store_registers): Now methods.
11024         (sparc_ravenscar_prepare_to_store): Remove.
11025         (sparc_ravenscar_ops): Redefine.
11026         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11027         methods and destructor.  Remove members.
11028         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11029         (ravenscar_thread_target::store_registers)
11030         (ravenscar_thread_target::prepare_to_store): Update.
11031         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11032         Remove.
11033         (struct ppc_ravenscar_powerpc_ops): Derive from
11034         ravenscar_arch_ops.
11035         (ppc_ravenscar_powerpc_ops::fetch_registers)
11036         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11037         (ppc_ravenscar_powerpc_ops): Redefine.
11038         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11039         (ppc_ravenscar_e500_ops::fetch_registers)
11040         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11041         (ppc_ravenscar_e500_ops): Redefine.
11042         * aarch64-ravenscar-thread.c
11043         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11044         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11045         (aarch64_ravenscar_fetch_registers)
11046         (aarch64_ravenscar_store_registers): Now methods.
11047         (aarch64_ravenscar_ops): Redefine.
11048
11049 2019-02-15  Tom Tromey  <tromey@adacore.com>
11050
11051         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11052         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11053         (ravenscar_thread_target::stopped_by_watchpoint)
11054         (ravenscar_thread_target::stopped_data_address)
11055         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11056
11057 2019-02-15  Tom Tromey  <tromey@adacore.com>
11058
11059         * ravenscar-thread.c: Fix some typos.
11060
11061 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11062             Tom Tromey  <tromey@adacore.com>
11063
11064         * ada-lang.c (ada_exception_sal): Change addr_string to a
11065         std::string.
11066         (create_ada_exception_catchpoint): Update.
11067
11068 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11069             Tom Tromey  <tromey@adacore.com>
11070
11071         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11072         (bp_location_ops): Remove.
11073         (base_breakpoint_allocate_location): Update.
11074         (free_bp_location): Update.
11075         * ada-lang.c (class ada_catchpoint_location)
11076         <ada_catchpoint_location>: Remove ops parameter.
11077         (ada_catchpoint_location_dtor): Remove.
11078         (ada_catchpoint_location_ops): Remove.
11079         (allocate_location_exception): Update.
11080         * breakpoint.h (struct bp_location_ops): Remove.
11081         (class bp_location) <bp_location>: Remove bp_location_ops
11082         parameter.
11083         <~bp_location>: Add destructor.
11084         <ops>: Remove.
11085
11086 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11087             Pedro Alves  <palves@redhat.com>
11088
11089         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11090         'PATH_MAX'.
11091
11092 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11093             Samuel Thibault  <samuel.thibault@gnu.org>
11094             Thomas Schwinge  <thomas@codesourcery.com>
11095
11096         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11097         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11098
11099 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11100
11101         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11102         (check_empty): Use "const char *".
11103
11104         * gnu-nat.c (gnu_nat_target::detach): Instead of
11105         'detach_inferior (pid)' call
11106         'detach_inferior (find_inferior_pid (pid))'.
11107
11108         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11109         'nat/fork-inferior.o'.
11110         * gnu-nat.c: #include "nat/fork-inferior.h".
11111
11112         * gnu-nat.c (gnu_nat_target::detach): Instead of
11113         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11114         * gnu-nat.h: #include "inf-child.h".
11115         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11116         'i386_gnu_nat_target::fetch_registers'.
11117         (gnu_store_registers): Rename/move to
11118         'i386_gnu_nat_target::store_registers'.
11119
11120         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11121         * gnu-nat.h (mach_thread_info): New function.
11122         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11123
11124         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11125
11126 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11127
11128         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11129
11130 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11131
11132         * windows-nat.c (windows_add_thread): Add new parameter
11133         "main_thread_p" with default value set to false.  Update
11134         function documentation as well as all callers.
11135         (windows_delete_thread): Likewise.
11136         (fake_create_process): Update call to windows_add_thread.
11137         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11138         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11139         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11140         call to windows_delete_thread.
11141
11142 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11143
11144         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11145
11146 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11147
11148         * symfile.c (find_separate_debug_file): Use canonical path of
11149         sysroot with child_path instead of gdb_sysroot if it is valid.
11150
11151 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11152
11153         * symfile.c (find_separate_debug_file): Use child_path to
11154         determine if an object file is under a sysroot.
11155
11156 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11157
11158         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11159         unittests/child-path-selftests.c.
11160         * common/pathstuff.c (child_path): New function.
11161         * common/pathstuff.h (child_path): New prototype.
11162         * unittests/child-path-selftests.c: New file.
11163
11164 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11165
11166         * symfile.c (find_separate_debug_file): Look for separate debug
11167         files in debug directories under the sysroot.
11168
11169 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11170
11171         * symtab.h (struct minimal_symbol data_p): New const method.
11172         (struct minimal_symbol text_p): Likewise.
11173         * symtab.c (output_source_filename): Use file name style
11174         to print file name.
11175         (print_symbol_info): Likewise.
11176         (print_msymbol_info): Use address style to print addresses.
11177         Use function name style to print executable text symbols.
11178         (expand_symtab_containing_pc): Use data_p.
11179         (find_pc_sect_compunit_symtab): Likewise.
11180
11181 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11182
11183         * breakpoint.c (describe_other_breakpoints): Use address style
11184         to print addresses.
11185         (say_where): Likewise.
11186
11187 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11188
11189         * ada-typeprint.c (print_func_type): Print function name
11190         style to print function name.
11191         * c-typeprint.c (c_print_type_1): Likewise.
11192
11193 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11194
11195         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11196         for execve.
11197
11198 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11199
11200         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11201         type_stack.
11202
11203 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11204
11205         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11206         TYPE_CODE_REF types.
11207
11208 2019-02-08  Jim Wilson  <jimw@sifive.com>
11209
11210         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11211         (riscv_linux_fregset): New.
11212         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11213
11214 2019-02-07  Tom Tromey  <tom@tromey.com>
11215
11216         * thread.c (thread_cancel_execution_command): Update.
11217         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11218         methods.
11219         (struct thread_fsm_ops): Remove.
11220         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11221         (thread_fsm_should_stop, thread_fsm_return_value)
11222         (thread_fsm_set_finished, thread_fsm_finished_p)
11223         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11224         Don't declare.
11225         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11226         * infrun.c (clear_proceed_status_thread)
11227         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11228         (print_stop_event): Update.
11229         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11230         Add constructor.
11231         (step_command_fsm_ops): Remove.
11232         (new_step_command_fsm): Remove.
11233         (step_1): Update.
11234         (step_command_fsm::should_stop): Rename from
11235         step_command_fsm_should_stop.
11236         (step_command_fsm::clean_up): Rename from
11237         step_command_fsm_clean_up.
11238         (step_command_fsm::do_async_reply_reason): Rename from
11239         step_command_fsm_async_reply_reason.
11240         (struct until_next_fsm): Inherit from thread_fsm.  Add
11241         constructor.
11242         (until_next_fsm_ops): Remove.
11243         (new_until_next_fsm): Remove.
11244         (until_next_fsm::should_stop): Rename from
11245         until_next_fsm_should_stop.
11246         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11247         (until_next_fsm::do_async_reply_reason): Rename from
11248         until_next_fsm_async_reply_reason.
11249         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11250         constructor.  Change type of breakpoint.
11251         (finish_command_fsm_ops): Remove.
11252         (new_finish_command_fsm): Remove.
11253         (finish_command_fsm::should_stop): Rename from
11254         finish_command_fsm_should_stop.
11255         (finish_command_fsm::clean_up): Rename from
11256         finish_command_fsm_clean_up.
11257         (finish_command_fsm::return_value): Rename from
11258         finish_command_fsm_return_value.
11259         (finish_command_fsm::do_async_reply_reason): Rename from
11260         finish_command_fsm_async_reply_reason.
11261         (finish_command): Update.
11262         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11263         Add constructor.
11264         (call_thread_fsm_ops): Remove.
11265         (call_thread_fsm::call_thread_fsm): Rename from
11266         new_call_thread_fsm.
11267         (call_thread_fsm::should_stop): Rename from
11268         call_thread_fsm_should_stop.
11269         (call_thread_fsm::should_notify_stop): Rename from
11270         call_thread_fsm_should_notify_stop.
11271         (run_inferior_call, call_function_by_hand_dummy): Update.
11272         * cli/cli-interp.c (should_print_stop_to_console): Update.
11273         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11274         Add constructor.  Change type of location_breakpoint,
11275         caller_breakpoint.
11276         (until_break_fsm_ops): Remove.
11277         (new_until_break_fsm): Remove.
11278         (until_break_fsm::should_stop): Rename from
11279         until_break_fsm_should_stop.
11280         (until_break_fsm::clean_up): Rename from
11281         until_break_fsm_clean_up.
11282         (until_break_fsm::do_async_reply_reason): Rename from
11283         until_break_fsm_async_reply_reason.
11284         (until_break_command): Update.
11285         * thread-fsm.c: Remove.
11286         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11287
11288 2019-02-07  Tom Tromey  <tom@tromey.com>
11289
11290         * yy-remap.h: Add include guard.
11291         * xtensa-tdep.h: Add include guard.
11292         * xcoffread.h: Rename include guard.
11293         * varobj-iter.h: Add include guard.
11294         * tui/tui.h: Rename include guard.
11295         * tui/tui-winsource.h: Rename include guard.
11296         * tui/tui-wingeneral.h: Rename include guard.
11297         * tui/tui-windata.h: Rename include guard.
11298         * tui/tui-win.h: Rename include guard.
11299         * tui/tui-stack.h: Rename include guard.
11300         * tui/tui-source.h: Rename include guard.
11301         * tui/tui-regs.h: Rename include guard.
11302         * tui/tui-out.h: Rename include guard.
11303         * tui/tui-layout.h: Rename include guard.
11304         * tui/tui-io.h: Rename include guard.
11305         * tui/tui-hooks.h: Rename include guard.
11306         * tui/tui-file.h: Rename include guard.
11307         * tui/tui-disasm.h: Rename include guard.
11308         * tui/tui-data.h: Rename include guard.
11309         * tui/tui-command.h: Rename include guard.
11310         * tic6x-tdep.h: Add include guard.
11311         * target/waitstatus.h: Rename include guard.
11312         * target/wait.h: Rename include guard.
11313         * target/target.h: Rename include guard.
11314         * target/resume.h: Rename include guard.
11315         * target-float.h: Rename include guard.
11316         * stabsread.h: Add include guard.
11317         * rs6000-tdep.h: Add include guard.
11318         * riscv-fbsd-tdep.h: Add include guard.
11319         * regformats/regdef.h: Rename include guard.
11320         * record.h: Rename include guard.
11321         * python/python.h: Rename include guard.
11322         * python/python-internal.h: Rename include guard.
11323         * python/py-stopevent.h: Rename include guard.
11324         * python/py-ref.h: Rename include guard.
11325         * python/py-record.h: Rename include guard.
11326         * python/py-record-full.h: Rename include guard.
11327         * python/py-record-btrace.h: Rename include guard.
11328         * python/py-instruction.h: Rename include guard.
11329         * python/py-events.h: Rename include guard.
11330         * python/py-event.h: Rename include guard.
11331         * procfs.h: Add include guard.
11332         * proc-utils.h: Add include guard.
11333         * p-lang.h: Add include guard.
11334         * or1k-tdep.h: Rename include guard.
11335         * observable.h: Rename include guard.
11336         * nto-tdep.h: Rename include guard.
11337         * nat/x86-linux.h: Rename include guard.
11338         * nat/x86-linux-dregs.h: Rename include guard.
11339         * nat/x86-gcc-cpuid.h: Add include guard.
11340         * nat/x86-dregs.h: Rename include guard.
11341         * nat/x86-cpuid.h: Rename include guard.
11342         * nat/ppc-linux.h: Rename include guard.
11343         * nat/mips-linux-watch.h: Rename include guard.
11344         * nat/linux-waitpid.h: Rename include guard.
11345         * nat/linux-ptrace.h: Rename include guard.
11346         * nat/linux-procfs.h: Rename include guard.
11347         * nat/linux-osdata.h: Rename include guard.
11348         * nat/linux-nat.h: Rename include guard.
11349         * nat/linux-namespaces.h: Rename include guard.
11350         * nat/linux-btrace.h: Rename include guard.
11351         * nat/glibc_thread_db.h: Rename include guard.
11352         * nat/gdb_thread_db.h: Rename include guard.
11353         * nat/gdb_ptrace.h: Rename include guard.
11354         * nat/fork-inferior.h: Rename include guard.
11355         * nat/amd64-linux-siginfo.h: Rename include guard.
11356         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11357         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11358         * nat/aarch64-linux.h: Rename include guard.
11359         * nat/aarch64-linux-hw-point.h: Rename include guard.
11360         * mn10300-tdep.h: Add include guard.
11361         * mips-linux-tdep.h: Add include guard.
11362         * mi/mi-parse.h: Rename include guard.
11363         * mi/mi-out.h: Rename include guard.
11364         * mi/mi-main.h: Rename include guard.
11365         * mi/mi-interp.h: Rename include guard.
11366         * mi/mi-getopt.h: Rename include guard.
11367         * mi/mi-console.h: Rename include guard.
11368         * mi/mi-common.h: Rename include guard.
11369         * mi/mi-cmds.h: Rename include guard.
11370         * mi/mi-cmd-break.h: Rename include guard.
11371         * m2-lang.h: Add include guard.
11372         * location.h: Rename include guard.
11373         * linux-record.h: Rename include guard.
11374         * linux-nat.h: Add include guard.
11375         * linux-fork.h: Add include guard.
11376         * i386-darwin-tdep.h: Rename include guard.
11377         * hppa-linux-offsets.h: Add include guard.
11378         * guile/guile.h: Rename include guard.
11379         * guile/guile-internal.h: Rename include guard.
11380         * gnu-nat.h: Rename include guard.
11381         * gdb-stabs.h: Rename include guard.
11382         * frv-tdep.h: Add include guard.
11383         * f-lang.h: Add include guard.
11384         * event-loop.h: Add include guard.
11385         * darwin-nat.h: Rename include guard.
11386         * cp-abi.h: Rename include guard.
11387         * config/sparc/nm-sol2.h: Rename include guard.
11388         * config/nm-nto.h: Rename include guard.
11389         * config/nm-linux.h: Add include guard.
11390         * config/i386/nm-i386gnu.h: Rename include guard.
11391         * config/djgpp/nl_types.h: Rename include guard.
11392         * config/djgpp/langinfo.h: Rename include guard.
11393         * compile/gcc-cp-plugin.h: Add include guard.
11394         * compile/gcc-c-plugin.h: Add include guard.
11395         * compile/compile.h: Rename include guard.
11396         * compile/compile-object-run.h: Rename include guard.
11397         * compile/compile-object-load.h: Rename include guard.
11398         * compile/compile-internal.h: Rename include guard.
11399         * compile/compile-cplus.h: Rename include guard.
11400         * compile/compile-c.h: Rename include guard.
11401         * common/xml-utils.h: Rename include guard.
11402         * common/x86-xstate.h: Rename include guard.
11403         * common/version.h: Rename include guard.
11404         * common/vec.h: Rename include guard.
11405         * common/tdesc.h: Rename include guard.
11406         * common/selftest.h: Rename include guard.
11407         * common/scoped_restore.h: Rename include guard.
11408         * common/scoped_mmap.h: Rename include guard.
11409         * common/scoped_fd.h: Rename include guard.
11410         * common/safe-iterator.h: Rename include guard.
11411         * common/run-time-clock.h: Rename include guard.
11412         * common/refcounted-object.h: Rename include guard.
11413         * common/queue.h: Rename include guard.
11414         * common/ptid.h: Rename include guard.
11415         * common/print-utils.h: Rename include guard.
11416         * common/preprocessor.h: Rename include guard.
11417         * common/pathstuff.h: Rename include guard.
11418         * common/observable.h: Rename include guard.
11419         * common/netstuff.h: Rename include guard.
11420         * common/job-control.h: Rename include guard.
11421         * common/host-defs.h: Rename include guard.
11422         * common/gdb_wait.h: Rename include guard.
11423         * common/gdb_vecs.h: Rename include guard.
11424         * common/gdb_unlinker.h: Rename include guard.
11425         * common/gdb_unique_ptr.h: Rename include guard.
11426         * common/gdb_tilde_expand.h: Rename include guard.
11427         * common/gdb_sys_time.h: Rename include guard.
11428         * common/gdb_string_view.h: Rename include guard.
11429         * common/gdb_splay_tree.h: Rename include guard.
11430         * common/gdb_setjmp.h: Rename include guard.
11431         * common/gdb_ref_ptr.h: Rename include guard.
11432         * common/gdb_optional.h: Rename include guard.
11433         * common/gdb_locale.h: Rename include guard.
11434         * common/gdb_assert.h: Rename include guard.
11435         * common/filtered-iterator.h: Rename include guard.
11436         * common/filestuff.h: Rename include guard.
11437         * common/fileio.h: Rename include guard.
11438         * common/environ.h: Rename include guard.
11439         * common/common-utils.h: Rename include guard.
11440         * common/common-types.h: Rename include guard.
11441         * common/common-regcache.h: Rename include guard.
11442         * common/common-inferior.h: Rename include guard.
11443         * common/common-gdbthread.h: Rename include guard.
11444         * common/common-exceptions.h: Rename include guard.
11445         * common/common-defs.h: Rename include guard.
11446         * common/common-debug.h: Rename include guard.
11447         * common/cleanups.h: Rename include guard.
11448         * common/buffer.h: Rename include guard.
11449         * common/btrace-common.h: Rename include guard.
11450         * common/break-common.h: Rename include guard.
11451         * cli/cli-utils.h: Rename include guard.
11452         * cli/cli-style.h: Rename include guard.
11453         * cli/cli-setshow.h: Rename include guard.
11454         * cli/cli-script.h: Rename include guard.
11455         * cli/cli-interp.h: Rename include guard.
11456         * cli/cli-decode.h: Rename include guard.
11457         * cli/cli-cmds.h: Rename include guard.
11458         * charset-list.h: Add include guard.
11459         * buildsym-legacy.h: Rename include guard.
11460         * bfin-tdep.h: Add include guard.
11461         * ax.h: Rename include guard.
11462         * arm-linux-tdep.h: Add include guard.
11463         * arm-fbsd-tdep.h: Add include guard.
11464         * arch/xtensa.h: Rename include guard.
11465         * arch/tic6x.h: Add include guard.
11466         * arch/i386.h: Add include guard.
11467         * arch/arm.h: Rename include guard.
11468         * arch/arm-linux.h: Rename include guard.
11469         * arch/arm-get-next-pcs.h: Rename include guard.
11470         * arch/amd64.h: Add include guard.
11471         * arch/aarch64-insn.h: Rename include guard.
11472         * arch-utils.h: Rename include guard.
11473         * annotate.h: Add include guard.
11474         * amd64-darwin-tdep.h: Rename include guard.
11475         * aarch64-linux-tdep.h: Add include guard.
11476         * aarch64-fbsd-tdep.h: Add include guard.
11477         * aarch32-linux-nat.h: Add include guard.
11478
11479 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11480
11481         * macrotab.c (macro_define_internal): New function that
11482         factorizes macro_define_object_internal and macro_define_function
11483         code.
11484         (macro_define_object_internal): Use macro_define_internal.
11485         (macro_define_function): Likewise.
11486
11487 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11488
11489         * macrocmd.c (extract_identifier): Return
11490         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11491         callers.
11492
11493 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11494
11495         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11496
11497 2019-02-05  Tom Tromey  <tom@tromey.com>
11498
11499         * target.c (target_stack::unpush): Move assertion earlier.
11500
11501 2019-01-30  Tom Tromey  <tom@tromey.com>
11502
11503         PR python/23615:
11504         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11505         (gdbpy_parse_and_eval): Likewise.
11506         * python/python-internal.h (gdbpy_allow_threads): New class.
11507
11508 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11509
11510         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11511         (aarch64_fbsd_fpregmap): Move earlier.
11512         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11513         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11514         instead of individual calls to trad_frame_set_reg_addr.
11515         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11516         earlier.
11517         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11518         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11519         instead of individual calls to trad_frame_set_reg_addr.
11520
11521 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11522
11523         * CONTRIBUTE: Replace contribution list with wiki link.
11524
11525 2019-01-25  Tom Tromey  <tom@tromey.com>
11526
11527         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11528
11529 2019-01-25  Tom Tromey  <tom@tromey.com>
11530
11531         * xtensa-linux-nat.c: Fix common/ includes.
11532         * xml-support.h: Fix common/ includes.
11533         * xml-support.c: Fix common/ includes.
11534         * x86-linux-nat.c: Fix common/ includes.
11535         * windows-nat.c: Fix common/ includes.
11536         * varobj.h: Fix common/ includes.
11537         * varobj.c: Fix common/ includes.
11538         * value.c: Fix common/ includes.
11539         * valops.c: Fix common/ includes.
11540         * utils.c: Fix common/ includes.
11541         * unittests/xml-utils-selftests.c: Fix common/ includes.
11542         * unittests/utils-selftests.c: Fix common/ includes.
11543         * unittests/unpack-selftests.c: Fix common/ includes.
11544         * unittests/tracepoint-selftests.c: Fix common/ includes.
11545         * unittests/style-selftests.c: Fix common/ includes.
11546         * unittests/string_view-selftests.c: Fix common/ includes.
11547         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11548         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11549         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11550         * unittests/rsp-low-selftests.c: Fix common/ includes.
11551         * unittests/parse-connection-spec-selftests.c: Fix common/
11552         includes.
11553         * unittests/optional-selftests.c: Fix common/ includes.
11554         * unittests/offset-type-selftests.c: Fix common/ includes.
11555         * unittests/observable-selftests.c: Fix common/ includes.
11556         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11557         * unittests/memrange-selftests.c: Fix common/ includes.
11558         * unittests/memory-map-selftests.c: Fix common/ includes.
11559         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11560         * unittests/function-view-selftests.c: Fix common/ includes.
11561         * unittests/environ-selftests.c: Fix common/ includes.
11562         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11563         * unittests/common-utils-selftests.c: Fix common/ includes.
11564         * unittests/cli-utils-selftests.c: Fix common/ includes.
11565         * unittests/array-view-selftests.c: Fix common/ includes.
11566         * ui-file.c: Fix common/ includes.
11567         * tui/tui-io.c: Fix common/ includes.
11568         * tracepoint.h: Fix common/ includes.
11569         * tracepoint.c: Fix common/ includes.
11570         * tracefile-tfile.c: Fix common/ includes.
11571         * top.h: Fix common/ includes.
11572         * top.c: Fix common/ includes.
11573         * thread.c: Fix common/ includes.
11574         * target/waitstatus.h: Fix common/ includes.
11575         * target/waitstatus.c: Fix common/ includes.
11576         * target.h: Fix common/ includes.
11577         * target.c: Fix common/ includes.
11578         * target-memory.c: Fix common/ includes.
11579         * target-descriptions.c: Fix common/ includes.
11580         * symtab.h: Fix common/ includes.
11581         * symfile.c: Fix common/ includes.
11582         * stap-probe.c: Fix common/ includes.
11583         * spu-linux-nat.c: Fix common/ includes.
11584         * sparc-nat.c: Fix common/ includes.
11585         * source.c: Fix common/ includes.
11586         * solib.c: Fix common/ includes.
11587         * solib-target.c: Fix common/ includes.
11588         * ser-unix.c: Fix common/ includes.
11589         * ser-tcp.c: Fix common/ includes.
11590         * ser-pipe.c: Fix common/ includes.
11591         * ser-base.c: Fix common/ includes.
11592         * selftest-arch.c: Fix common/ includes.
11593         * s12z-tdep.c: Fix common/ includes.
11594         * rust-exp.y: Fix common/ includes.
11595         * rs6000-aix-tdep.c: Fix common/ includes.
11596         * riscv-tdep.c: Fix common/ includes.
11597         * remote.c: Fix common/ includes.
11598         * remote-notif.h: Fix common/ includes.
11599         * remote-fileio.h: Fix common/ includes.
11600         * remote-fileio.c: Fix common/ includes.
11601         * regcache.h: Fix common/ includes.
11602         * regcache.c: Fix common/ includes.
11603         * record-btrace.c: Fix common/ includes.
11604         * python/python.c: Fix common/ includes.
11605         * python/py-type.c: Fix common/ includes.
11606         * python/py-inferior.c: Fix common/ includes.
11607         * progspace.h: Fix common/ includes.
11608         * producer.c: Fix common/ includes.
11609         * procfs.c: Fix common/ includes.
11610         * proc-api.c: Fix common/ includes.
11611         * printcmd.c: Fix common/ includes.
11612         * ppc-linux-nat.c: Fix common/ includes.
11613         * parser-defs.h: Fix common/ includes.
11614         * osdata.c: Fix common/ includes.
11615         * obsd-nat.c: Fix common/ includes.
11616         * nat/x86-linux.c: Fix common/ includes.
11617         * nat/x86-linux-dregs.c: Fix common/ includes.
11618         * nat/x86-dregs.h: Fix common/ includes.
11619         * nat/x86-dregs.c: Fix common/ includes.
11620         * nat/ppc-linux.c: Fix common/ includes.
11621         * nat/mips-linux-watch.h: Fix common/ includes.
11622         * nat/mips-linux-watch.c: Fix common/ includes.
11623         * nat/linux-waitpid.c: Fix common/ includes.
11624         * nat/linux-ptrace.h: Fix common/ includes.
11625         * nat/linux-ptrace.c: Fix common/ includes.
11626         * nat/linux-procfs.c: Fix common/ includes.
11627         * nat/linux-personality.c: Fix common/ includes.
11628         * nat/linux-osdata.c: Fix common/ includes.
11629         * nat/linux-namespaces.c: Fix common/ includes.
11630         * nat/linux-btrace.h: Fix common/ includes.
11631         * nat/linux-btrace.c: Fix common/ includes.
11632         * nat/fork-inferior.c: Fix common/ includes.
11633         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11634         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11635         * nat/aarch64-linux.c: Fix common/ includes.
11636         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11637         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11638         * namespace.h: Fix common/ includes.
11639         * mips-linux-tdep.c: Fix common/ includes.
11640         * minsyms.c: Fix common/ includes.
11641         * mi/mi-parse.h: Fix common/ includes.
11642         * mi/mi-main.c: Fix common/ includes.
11643         * mi/mi-cmd-env.c: Fix common/ includes.
11644         * memrange.h: Fix common/ includes.
11645         * memattr.c: Fix common/ includes.
11646         * maint.h: Fix common/ includes.
11647         * maint.c: Fix common/ includes.
11648         * main.c: Fix common/ includes.
11649         * machoread.c: Fix common/ includes.
11650         * location.c: Fix common/ includes.
11651         * linux-thread-db.c: Fix common/ includes.
11652         * linux-nat.c: Fix common/ includes.
11653         * linux-fork.c: Fix common/ includes.
11654         * inline-frame.c: Fix common/ includes.
11655         * infrun.c: Fix common/ includes.
11656         * inflow.c: Fix common/ includes.
11657         * inferior.h: Fix common/ includes.
11658         * inferior.c: Fix common/ includes.
11659         * infcmd.c: Fix common/ includes.
11660         * inf-ptrace.c: Fix common/ includes.
11661         * inf-child.c: Fix common/ includes.
11662         * ia64-linux-nat.c: Fix common/ includes.
11663         * i387-tdep.c: Fix common/ includes.
11664         * i386-tdep.c: Fix common/ includes.
11665         * i386-linux-tdep.c: Fix common/ includes.
11666         * i386-linux-nat.c: Fix common/ includes.
11667         * i386-go32-tdep.c: Fix common/ includes.
11668         * i386-fbsd-tdep.c: Fix common/ includes.
11669         * i386-fbsd-nat.c: Fix common/ includes.
11670         * guile/scm-type.c: Fix common/ includes.
11671         * guile/guile.c: Fix common/ includes.
11672         * go32-nat.c: Fix common/ includes.
11673         * gnu-nat.c: Fix common/ includes.
11674         * gdbthread.h: Fix common/ includes.
11675         * gdbarch-selftests.c: Fix common/ includes.
11676         * gdb_usleep.c: Fix common/ includes.
11677         * gdb_select.h: Fix common/ includes.
11678         * gdb_bfd.c: Fix common/ includes.
11679         * gcore.c: Fix common/ includes.
11680         * fork-child.c: Fix common/ includes.
11681         * findvar.c: Fix common/ includes.
11682         * fbsd-nat.c: Fix common/ includes.
11683         * event-top.c: Fix common/ includes.
11684         * event-loop.c: Fix common/ includes.
11685         * dwarf2read.c: Fix common/ includes.
11686         * dwarf2loc.c: Fix common/ includes.
11687         * dwarf2-frame.c: Fix common/ includes.
11688         * dwarf-index-cache.c: Fix common/ includes.
11689         * dtrace-probe.c: Fix common/ includes.
11690         * disasm-selftests.c: Fix common/ includes.
11691         * defs.h: Fix common/ includes.
11692         * csky-tdep.c: Fix common/ includes.
11693         * cp-valprint.c: Fix common/ includes.
11694         * cp-support.h: Fix common/ includes.
11695         * cp-support.c: Fix common/ includes.
11696         * corelow.c: Fix common/ includes.
11697         * completer.h: Fix common/ includes.
11698         * completer.c: Fix common/ includes.
11699         * compile/compile.c: Fix common/ includes.
11700         * compile/compile-loc2c.c: Fix common/ includes.
11701         * compile/compile-cplus-types.c: Fix common/ includes.
11702         * compile/compile-cplus-symbols.c: Fix common/ includes.
11703         * command.h: Fix common/ includes.
11704         * cli/cli-dump.c: Fix common/ includes.
11705         * cli/cli-cmds.c: Fix common/ includes.
11706         * charset.c: Fix common/ includes.
11707         * build-id.c: Fix common/ includes.
11708         * btrace.h: Fix common/ includes.
11709         * btrace.c: Fix common/ includes.
11710         * breakpoint.h: Fix common/ includes.
11711         * breakpoint.c: Fix common/ includes.
11712         * ax.h:
11713         (enum agent_op): Fix common/ includes.
11714         * ax-general.c (struct aop_map): Fix common/ includes.
11715         * ax-gdb.c: Fix common/ includes.
11716         * auxv.c: Fix common/ includes.
11717         * auto-load.c: Fix common/ includes.
11718         * arm-tdep.c: Fix common/ includes.
11719         * arch/riscv.c: Fix common/ includes.
11720         * arch/ppc-linux-common.c: Fix common/ includes.
11721         * arch/i386.c: Fix common/ includes.
11722         * arch/arm.c: Fix common/ includes.
11723         * arch/arm-linux.c: Fix common/ includes.
11724         * arch/arm-get-next-pcs.c: Fix common/ includes.
11725         * arch/amd64.c: Fix common/ includes.
11726         * arch/aarch64.c: Fix common/ includes.
11727         * arch/aarch64-insn.c: Fix common/ includes.
11728         * arch-utils.c: Fix common/ includes.
11729         * amd64-windows-tdep.c: Fix common/ includes.
11730         * amd64-tdep.c: Fix common/ includes.
11731         * amd64-sol2-tdep.c: Fix common/ includes.
11732         * amd64-obsd-tdep.c: Fix common/ includes.
11733         * amd64-nbsd-tdep.c: Fix common/ includes.
11734         * amd64-linux-tdep.c: Fix common/ includes.
11735         * amd64-linux-nat.c: Fix common/ includes.
11736         * amd64-fbsd-tdep.c: Fix common/ includes.
11737         * amd64-fbsd-nat.c: Fix common/ includes.
11738         * amd64-dicos-tdep.c: Fix common/ includes.
11739         * amd64-darwin-tdep.c: Fix common/ includes.
11740         * agent.c: Fix common/ includes.
11741         * ada-lang.h: Fix common/ includes.
11742         * ada-lang.c: Fix common/ includes.
11743         * aarch64-tdep.c: Fix common/ includes.
11744
11745 2019-01-25  Tom Tromey  <tom@tromey.com>
11746
11747         * common/create-version.sh: Use common/version.h.
11748
11749 2019-01-24  Pedro Alves  <palves@redhat.com>
11750
11751         * infrun.c (signal_stop, signal_print, signal_program)
11752         (signal_catch, signal_pass): Now arrays instead of pointers.
11753         (update_signals_program_target, do_target_resume)
11754         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11755         * linux-nat.c (linux_nat_target::pass_signals)
11756         (linux_nat_target::create_inferior, linux_nat_target::attach):
11757         Adjust.
11758         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11759         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11760         * procfs.c (procfs_target::pass_signals): Adjust.
11761         * record-full.c (record_full_target::resume): Adjust.
11762         * remote.c (remote_target::pass_signals)
11763         (remote_target::program_signals): Adjust.
11764         * target-debug.h (target_debug_print_signals): Now takes a
11765         gdb::array_view as parameter.  Adjust.
11766         * target.h (target_ops) <pass_signals, program_signals>: Replace
11767         pointer and length parameters with gdb::array_view.
11768         (target_pass_signals, target_program_signals): Likewise.
11769         * target-delegates.c: Regenerate.
11770
11771 2019-01-24  Pedro Alves  <palves@redhat.com>
11772
11773         * common/forward-scope-exit.h
11774         (forward_scope_exit::forward_scope_exit): Pass arguments to
11775         m_bind_function directly, instead of creating a std::bind and
11776         copying that.
11777
11778 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11779
11780         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11781         for static members.
11782         (pass_in_v_vfp_candidate): Likewise.
11783
11784 2019-01-23  Tom Tromey  <tom@tromey.com>
11785             Pedro Alves  <palves@redhat.com>
11786
11787         * regcache.c (class regcache_invalidator): Remove.
11788         (regcache::raw_write): Use make_scope_exit.
11789
11790 2019-01-23  Tom Tromey  <tom@tromey.com>
11791
11792         * ui-out.h (class ui_out_emit_type): Update comment.
11793
11794 2019-01-23  Tom Tromey  <tom@tromey.com>
11795
11796         * infrun.c (fetch_inferior_event): Update comment.
11797
11798 2019-01-23  Tom Tromey  <tom@tromey.com>
11799             Pedro Alves  <palves@redhat.com>
11800
11801         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11802         parameter.
11803         (fetch_inferior_event): Use SCOPE_EXIT.
11804
11805
11806 2019-01-23  Tom Tromey  <tom@tromey.com>
11807             Pedro Alves  <palves@redhat.com>
11808
11809         * infrun.c (disable_thread_events): Delete.
11810         (stop_all_threads): Use SCOPE_EXIT.
11811
11812 2019-01-23  Tom Tromey  <tom@tromey.com>
11813             Pedro Alves  <palves@redhat.com>
11814
11815         * symfile.c: Include forward-scope-exit.h.
11816         (clear_symtab_users_cleanup): Replace forward declaration with
11817         a FORWARD_SCOPE_EXIT.
11818         (syms_from_objfile_1): Use the forward_scope_exit and
11819         gdb::optional instead of cleanup_function.
11820         (reread_symbols): Use the forward_scope_exit instead of
11821         cleanup_function.
11822         (clear_symtab_users_cleanup): Remove function.
11823
11824 2019-01-23  Tom Tromey  <tom@tromey.com>
11825             Pedro Alves  <palves@redhat.com>
11826
11827         * linux-nat.c: Include scope-exit.h.
11828         (cleanup_target_stop): Remove.
11829         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11830         SCOPE_EXIT.
11831
11832 2019-01-23  Tom Tromey  <tom@tromey.com>
11833             Pedro Alves  <palves@redhat.com>
11834
11835         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11836         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11837
11838 2019-01-23  Tom Tromey  <tom@tromey.com>
11839             Andrew Burgess  <andrew.burgess@embecosm.com>
11840             Pedro Alves  <palves@redhat.com>
11841
11842         * infrun.c (fetch_inferior_event): Use scope_exit.
11843         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11844         * top.c (execute_command): Use scope_exit.
11845         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11846         * utils.c (do_bpstat_clear_actions_cleanup)
11847         (make_bpstat_clear_actions_cleanup): Remove.
11848
11849 2019-01-23  Tom Tromey  <tom@tromey.com>
11850             Pedro Alves  <palves@redhat.com>
11851
11852         * infrun.c: Include "common/scope-exit.h"
11853         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11854         (wait_for_inferior): Use SCOPE_EXIT.
11855         (fetch_inferior_event): Use scope_exit.
11856
11857 2019-01-23  Tom Tromey  <tom@tromey.com>
11858             Pedro Alves  <palves@redhat.com>
11859
11860         * breakpoint.c (create_breakpoint): Remove cleanup.
11861
11862 2019-01-23  Tom Tromey  <tom@tromey.com>
11863             Andrew Burgess  <andrew.burgess@embecosm.com>
11864             Pedro Alves  <palves@redhat.com>
11865
11866 2019-01-23  Pedro Alves  <palves@redhat.com>
11867
11868         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11869
11870 2019-01-23  Pedro Alves  <palves@redhat.com>
11871             Andrew Burgess  <andrew.burgess@embecosm.com>
11872
11873         * gdbthread.h: Include "common/forward-scope-exit.h".
11874         (scoped_finish_thread_state): Redefine custom class in terms of
11875         forward_scope_exit.
11876
11877 2019-01-23  Pedro Alves  <palves@redhat.com>
11878             Andrew Burgess  <andrew.burgess@embecosm.com>
11879
11880         * common/forward-scope-exit.h: New file.
11881
11882 2019-01-23  Pedro Alves  <palves@redhat.com>
11883             Andrew Burgess  <andrew.burgess@embecosm.com>
11884             Tom Tromey  <tom@tromey.com>
11885
11886         * common/scope-exit.h: New file.
11887
11888 2019-01-23  Pedro Alves  <palves@redhat.com>
11889
11890         * common/preprocessor.h (ESC): Rename to ...
11891         (ESC_PARENS): ... this.
11892         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11893         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11894
11895 2019-01-23  Tom Tromey  <tom@tromey.com>
11896
11897         * language.h (class scoped_switch_to_sym_language_if_auto):
11898         Initialize m_lang in both cases.
11899
11900 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11901
11902         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11903         with XCNEW.
11904
11905 2019-01-22  Tom Tromey  <tom@tromey.com>
11906
11907         * corelow.c: Do not include sys/file.h.
11908
11909 2019-01-22  Tom Tromey  <tom@tromey.com>
11910
11911         * tui/tui-wingeneral.h: Include gdb_curses.h.
11912
11913 2019-01-22  Tom Tromey  <tom@tromey.com>
11914
11915         * source-cache.h (class source_cache) <get_source_lines,
11916         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11917
11918 2019-01-22  Tom Tromey  <tom@tromey.com>
11919
11920         * remote-fileio.h (struct remote_target): Declare.
11921
11922 2019-01-22  Tom Tromey  <tom@tromey.com>
11923
11924         * python/py-arch.c: Do not include py-ref.h.
11925         * python/py-bpevent.c: Do not include py-ref.h.
11926         * python/py-cmd.c: Do not include py-ref.h.
11927         * python/py-continueevent.c: Do not include py-ref.h.
11928         * python/py-event.h: Do not include py-ref.h.
11929         * python/py-evtregistry.c: Do not include py-ref.h.
11930         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11931         * python/py-frame.c: Do not include py-ref.h.
11932         * python/py-framefilter.c: Do not include py-ref.h.
11933         * python/py-function.c: Do not include py-ref.h.
11934         * python/py-infevents.c: Do not include py-ref.h.
11935         * python/py-linetable.c: Do not include py-ref.h.
11936         * python/py-objfile.c: Do not include py-ref.h.
11937         * python/py-param.c: Do not include py-ref.h.
11938         * python/py-prettyprint.c: Do not include py-ref.h.
11939         * python/py-progspace.c: Do not include py-ref.h.
11940         * python/py-symbol.c: Do not include py-ref.h.
11941         * python/py-symtab.c: Do not include py-ref.h.
11942         * python/py-type.c: Do not include py-ref.h.
11943         * python/py-unwind.c: Do not include py-ref.h.
11944         * python/py-utils.c: Do not include py-ref.h.
11945         * python/py-value.c: Do not include py-ref.h.
11946         * python/py-varobj.c: Do not include py-ref.h.
11947         * python/py-xmethods.c: Do not include py-ref.h.
11948         * python/python.c: Do not include py-ref.h.
11949         * varobj.c: Do not include py-ref.h.
11950
11951 2019-01-22  Tom Tromey  <tom@tromey.com>
11952
11953         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11954         keyword for bcache.
11955
11956 2019-01-22  Tom Tromey  <tom@tromey.com>
11957
11958         * compile/compile-cplus-types.c: Remove a comment by #include.
11959
11960 2019-01-22  Tom Tromey  <tom@tromey.com>
11961
11962         * compile/gcc-c-plugin.h: Include compile-internal.h.
11963
11964 2019-01-22  Tom Tromey  <tom@tromey.com>
11965
11966         * stabsread.c (EXTERN): Do not define.
11967         (symnum, next_symbol_text_func, processing_gcc_compilation)
11968         (within_function, global_sym_chain, global_stabs)
11969         (previous_stab_code, this_object_header_files)
11970         (n_this_object_header_files)
11971         (n_allocated_this_object_header_files): Define.
11972         * stabsread.h (EXTERN): Never define.  Use "extern".
11973
11974 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11975
11976         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11977         history_value.
11978
11979 2019-01-21  Tom Tromey  <tom@tromey.com>
11980
11981         * ui-out.c: Fix includes.
11982         * tui/tui-source.c: Fix includes.
11983         * target.c: Fix includes.
11984         * remote.c: Fix includes.
11985         * regcache.c: Fix includes.
11986         * python/py-block.c: Fix includes.
11987         * printcmd.c: Fix includes.
11988         * or1k-tdep.c: Fix includes.
11989         * mi/mi-main.c: Fix includes.
11990         * m32r-tdep.c: Fix includes.
11991         * csky-tdep.c: Fix includes.
11992         * compile/compile-cplus-types.c: Fix includes.
11993         * cli/cli-interp.c: Fix includes.
11994
11995 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11996
11997         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11998         for padding.
11999
12000 2019-01-16  Tom Tromey  <tom@tromey.com>
12001
12002         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12003         earlier.
12004         (struct objfile) <msymbols_range>: Move from top level.
12005         <msymbols>: New method.
12006         (class objfile_msymbols): Remove.
12007         * symtab.c (default_collect_symbol_completion_matches_break_on):
12008         Update.
12009         * symmisc.c (dump_msymbols): Update.
12010         * stabsread.c (scan_file_globals): Update.
12011         * objc-lang.c (info_selectors_command, info_classes_command)
12012         (find_methods): Update.
12013         * minsyms.c (find_solib_trampoline_target): Update.
12014         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12015         * coffread.c (coff_symfile_read): Update.
12016         * ada-lang.c (ada_lookup_simple_minsym)
12017         (ada_collect_symbol_completion_matches): Update.
12018
12019 2019-01-16  Tom Tromey  <tom@tromey.com>
12020
12021         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12022         type.  Remove no-argument constructor.
12023         <iterator::operator++>: Simplify.
12024         <begin>: Update.
12025         <end>: Use minimal_symbol_count.
12026
12027 2019-01-16  Tom Tromey  <tom@tromey.com>
12028
12029         * objfiles.h (struct objfile) <psymtabs>: New method.
12030         (class objfile_psymtabs): Remove.
12031         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12032         typedef.
12033         <range>: New method.
12034         (require_partial_symbols): Change return type.
12035         * psymtab.c (require_partial_symbols)
12036         (psym_expand_symtabs_matching): Update.
12037         * mdebugread.c (parse_partial_symbols): Update.
12038         * dbxread.c (dbx_end_psymtab): Update.
12039
12040 2019-01-15  Tom Tromey  <tom@tromey.com>
12041
12042         * symtab.c (lookup_objfile_from_block)
12043         (lookup_symbol_in_objfile_symtabs)
12044         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12045         (find_line_symtab, info_sources_command)
12046         (default_collect_symbol_completion_matches_break_on)
12047         (make_source_files_completion_list): Update.
12048         * symmisc.c (print_objfile_statistics, dump_objfile)
12049         (maintenance_print_symbols, maintenance_info_symtabs)
12050         (maintenance_check_symtabs, maintenance_info_line_tables):
12051         Update.
12052         * source.c (select_source_symtab)
12053         (forget_cached_source_info_for_objfile): Update.
12054         * objfiles.h (class objfile_compunits): Remove.
12055         (struct objfile) <compunits_range>: New typedef.
12056         (compunits): New method.
12057         * objfiles.c (objfile_relocate1): Update.
12058         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12059         * maint.c (count_symtabs_and_blocks): Update.
12060         * linespec.c (iterate_over_all_matching_symtabs): Update.
12061         * cp-support.c (add_symbol_overload_list_qualified): Update.
12062         * coffread.c (coff_symtab_read): Update.
12063         * ada-lang.c (add_nonlocal_symbols)
12064         (ada_collect_symbol_completion_matches)
12065         (ada_add_global_exceptions): Update.
12066
12067 2019-01-15  Tom Tromey  <tom@tromey.com>
12068
12069         * progspace.h (program_space) <objfiles_safe_range>: New
12070         typedef.
12071         <objfiles_safe>: New method.
12072         * objfiles.h (class all_objfiles_safe): Remove.
12073         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12074         * jit.c (jit_inferior_exit_hook): Update.
12075
12076 2019-01-17  Tom Tromey  <tom@tromey.com>
12077
12078         * progspace.h (program_space) <objfiles_range>: New typedef.
12079         <objfiles>: New method.
12080         <objfiles_head>: Rename from objfiles.
12081         (object_files): Update.
12082         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12083         * guile/scm-pretty-print.c
12084         (ppscm_find_pretty_printer_from_objfiles): Update.
12085         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12086         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12087         Update.
12088         * python/py-progspace.c (pspy_get_objfiles): Update.
12089         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12090         Update.
12091         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12092         (objfpy_lookup_objfile_by_build_id): Update.
12093         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12094         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12095         Update.
12096         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12097         (expand_symtab_containing_pc, lookup_objfile_from_block)
12098         (lookup_static_symbol, basic_lookup_transparent_type)
12099         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12100         (find_line_symtab, info_sources_command)
12101         (default_collect_symbol_completion_matches_break_on)
12102         (make_source_files_completion_list, find_main_name): Update.
12103         * symmisc.c (print_symbol_bcache_statistics)
12104         (print_objfile_statistics, maintenance_print_symbols)
12105         (maintenance_print_msymbols, maintenance_print_objfiles)
12106         (maintenance_info_symtabs, maintenance_check_symtabs)
12107         (maintenance_expand_symtabs, maintenance_info_line_tables):
12108         Update.
12109         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12110         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12111         (map_overlay_command, unmap_overlay_command)
12112         (simple_overlay_update, expand_symtabs_matching)
12113         (map_symbol_filenames): Update.
12114         * symfile-debug.c (set_debug_symfile): Update.
12115         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12116         Update.
12117         * source.c (select_source_symtab, forget_cached_source_info):
12118         Update.
12119         * solib.c (solib_read_symbols): Update.
12120         * solib-spu.c (append_ocl_sos): Update.
12121         * psymtab.c (maintenance_print_psymbols)
12122         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12123         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12124         * printcmd.c (info_symbol_command): Update.
12125         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12126         Update.
12127         * objfiles.h (class all_objfiles): Remove.
12128         * objfiles.c (have_partial_symbols, have_full_symbols)
12129         (have_minimal_symbols, qsort_cmp, update_section_map)
12130         (shared_objfile_contains_address_p)
12131         (default_iterate_over_objfiles_in_search_order): Update.
12132         * objc-lang.c (info_selectors_command, info_classes_command)
12133         (find_methods): Update.
12134         * minsyms.c (find_solib_trampoline_target): Update.
12135         * maint.c (maintenance_info_sections)
12136         (maintenance_translate_address, count_symtabs_and_blocks):
12137         Update.
12138         * main.c (captured_main_1): Update.
12139         * linux-thread-db.c (try_thread_db_load_from_pdir)
12140         (has_libpthread): Update.
12141         * linespec.c (iterate_over_all_matching_symtabs)
12142         (search_minsyms_for_name): Update.
12143         * jit.c (jit_find_objf_with_entry_addr): Update.
12144         * hppa-tdep.c (find_unwind_entry)
12145         (hppa_lookup_stub_minimal_symbol): Update.
12146         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12147         Update.
12148         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12149         (elf_gnu_ifunc_resolve_by_got): Update.
12150         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12151         * dwarf-index-write.c (save_gdb_index_command): Update.
12152         * cp-support.c (add_symbol_overload_list_qualified): Update.
12153         * breakpoint.c (create_overlay_event_breakpoint)
12154         (create_longjmp_master_breakpoint)
12155         (create_std_terminate_master_breakpoint)
12156         (create_exception_master_breakpoint): Update.
12157         * blockframe.c (find_pc_partial_function): Update.
12158         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12159         (ada_collect_symbol_completion_matches)
12160         (ada_add_global_exceptions): Update.
12161
12162 2019-01-17  Tom Tromey  <tom@tromey.com>
12163
12164         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12165         declare VEC.
12166         (solib_target_parse_libraries): Change return type.
12167         (library_list_start_segment, library_list_start_section)
12168         (library_list_end_library, library_list_start_library); Update.
12169         (solib_target_free_library_list): Remove.
12170         (solib_target_parse_libraries): Remove cleanup.  Change return
12171         type.
12172         (solib_target_current_sos): Update.
12173
12174 2019-01-17  Tom Tromey  <tromey@bapiya>
12175
12176         * valprint.c: Replace "the the" with "the".
12177         * symtab.c: Replace "the the" with "the".
12178         * solib.c: Replace "the the" with "the".
12179         * solib-dsbt.c: Replace "the the" with "the".
12180         * linespec.c: Replace "the the" with "the".
12181         * dwarf2loc.h: Replace "the the" with "the".
12182         * amd64-windows-tdep.c: Replace "the the" with "the".
12183         * aarch64-tdep.c: Replace "the the" with "the".
12184
12185 2019-01-16  Keith Seitz  <keiths@redhat.com>
12186
12187         PR gdb/23773
12188         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12189         <builder>: Rename to ..
12190         <m_builder>: ... this and make private.
12191         (dwarf2_cu::get_builder): New method.  Change all users of
12192         `builder' to use this method.
12193         (dwarf2_start_symtab): Move to ...
12194         (dwarf2_cu::start_symtab): ... here.  Update all callers
12195         (setup_type_unit_groups): Move to ...
12196         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12197         callers.
12198         (dwarf2_cu::reset_builder): New method.
12199         (process_full_compunit, process_full_type_unit): Use
12200         dwarf2_cu::reset_builder.
12201         (follow_die_offset): Record the ancestor CU if it is different
12202         from the followed DIE's CU.
12203         (follow_die_sig_1): Likewise.
12204
12205 2019-01-15  Tom Tromey  <tom@tromey.com>
12206
12207         * remote.c (class remote_state) <buf>: Now a char_vector.
12208         <buf_size>: Remove.
12209         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12210         parameter.
12211         (remote_target::getpkt_or_notif_sane_1)
12212         (remote_target::getpkt_sane)
12213         (remote_target::getpkt_or_notif_sane): Likewise.
12214         (class remote_target) <putpkt>: New overload.
12215         (remote_target::read_frame): Change type of "buf_p".  Remove
12216         sizeof_p parameter.
12217         (packet_ok): New overload.
12218         (packet_check_result): New overload.
12219         Update all uses.
12220
12221 2019-01-14  Tom Tromey  <tom@tromey.com>
12222
12223         * remote-notif.c (handle_notification, remote_notif_ack)
12224         (remote_notif_parse): Make "buf" const.
12225         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12226         const.
12227         (remote_notif_parse, remote_notif_ack, handle_notification):
12228         Likewise.
12229         * remote.c (remote_notif_stop_parse): Make "buf" const.
12230         (remote_target::remote_parse_stop_reply): Make "buf" const.
12231         (remote_notif_stop_ack): Make "buf" const.
12232
12233 2019-01-14  Tom Tromey  <tom@tromey.com>
12234
12235         * remote.c (remote_console_output): Make parameter const.
12236
12237 2019-01-14  Tom Tromey  <tom@tromey.com>
12238
12239         * target-debug.h (target_debug_print_signals): Constify.
12240         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12241         * procfs.c (procfs_target::pass_signals): Update.
12242         * linux-nat.c (linux_nat_target::pass_signals): Update.
12243         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12244         * target-delegates.c: Rebuild.
12245         * remote.c (remote_target::program_signals): Update.
12246         (remote_target::pass_signals): Update.
12247         * target.c (target_pass_signals): Constify argument.
12248         (target_program_signals): Likewise.
12249         * target.h (struct target_ops) <pass_signals, program_signals>:
12250         Constify argument.
12251         (target_pass_signals, target_program_signals): Constify argument.
12252
12253 2019-01-14  Tom Tromey  <tom@tromey.com>
12254
12255         PR tui/28819:
12256         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12257
12258 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12259
12260         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12261         field.
12262         * rs6000-tdep.c: Include reggroups.h.
12263         (IS_V_ALIAS_PSEUDOREG): Define.
12264         (rs6000_register_name): Return names for the "vX" aliases.
12265         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12266         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12267         aliases.  Call default_register_reggroup_p for all other
12268         pseudo-registers.
12269         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12270         New functions.
12271         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12272         Handle "vX" aliases.
12273         (v_alias_pseudo_register_collect): New function.
12274         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12275         (rs6000_gdbarch_init): Initialize "vX" aliases as
12276         pseudo-registers.  Restore registration of
12277         rs6000_pseudo_register_reggroup_p with
12278         set_tdesc_pseudo_register_reggroup_p.
12279
12280 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12281
12282         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12283         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12284         set_gdbarch_num_pseudo_regs.
12285
12286 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12287
12288         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12289         Remove arg prefixname, add do_set and do_show.
12290         Add member functions set_list and show_list.
12291         * cli/cli-style.c (class cli_style_option): Update accordingly.
12292         (style_set_list): Move to file scope.
12293         (style_show_list): Likewise.
12294         (set_style): Call help_list.
12295         (show_style): Call cmd_show_list.
12296         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12297         Update to use the new macro.
12298
12299 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12300
12301         * ada-lang.c (_initialize_ada_language): Expand the help text
12302         for the "catch exception" command.
12303
12304 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12305
12306         * symtab.c (matching_obj_sections): Initialize obj,
12307         declare it closer to its usage.
12308
12309 2019-01-10  Tom Tromey  <tom@tromey.com>
12310
12311         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12312         (basic_inf_threads_range): Remove.
12313         (inf_threads_range, inf_non_exited_threads_range)
12314         (safe_inf_threads_range): Use next_adapter.
12315
12316 2019-01-10  Keith Seitz  <keiths@redhat.com>
12317
12318         PR gdb/23712
12319         PR symtab/23010
12320         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12321         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12322
12323 2019-01-10  Keith Seitz  <keiths@redhat.com>
12324
12325         PR gdb/23712
12326         PR symtab/23010
12327         * dictionary.c (pending_to_vector): Remove.
12328         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12329         Remove _1 suffix, replacing functions of the same name.  Update
12330         all callers.
12331         (dict_create_hashed, dict_create_hashed_expandable)
12332         (dict_create_linear, dict_create_linear_expandable, dict_free)
12333         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12334         Make functions static.
12335
12336 2019-01-10  Keith Seitz  <keiths@redhat.com>
12337
12338         PR gdb/23712
12339         PR symtab/23010
12340         * dictionary.h (struct dictionary): Replace declaration with
12341         multidictionary.
12342         (dict_create_hashed, dict_create_hashed_expandable)
12343         (dict_create_linear, dict_create_linear_expandable)
12344         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12345         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12346         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12347         taking multidictionary argument.
12348         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12349         * block.h (struct block) <dict>: Change to multidictionary
12350         and rename `multidict'.
12351         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12352         symmisc.c: Update all dictionary references to multidictionary.
12353
12354 2019-01-10  Keith Seitz  <keiths@redhat.com>
12355
12356         PR gdb/23712
12357         PR symtab/23010
12358         * dictionary.c: Include unordered_map.
12359         (pending_to_vector): New function.
12360         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12361         Rewrite the non-"_1" functions to take vector instead
12362         of linked list.
12363         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12364         "new" _1 versions of the same name.
12365         (multidictionary): Define.
12366         (std::hash<enum language): New definition.
12367         (collate_pending_symbols_by_language, mdict_create_hashed)
12368         (mdict_create_hashed_expandable, mdict_create_linear)
12369         (mdict_create_linear_expandable, mdict_free)
12370         (find_language_dictionary, create_new_language_dictionary)
12371         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12372         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12373         (mdict_size, mdict_empty): New functions.
12374         * dictionary.h (mdict_iterator): Define.
12375
12376 2019-01-10  Pedro Alves  <palves@redhat.com>
12377
12378         * breakpoint.c (read_uploaded_action)
12379         (create_tracepoint_from_upload): Adjust to use
12380         gdb::unique_xmalloc_ptr.
12381         * ctf.c (ctf_write_uploaded_tp):
12382         (SET_ARRAY_FIELD): Use emplace_back.
12383         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12384         * tracefile-tfile.c (tfile_write_uploaded_tp):
12385         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12386         gdb::unique_xmalloc_ptr.
12387         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12388         at_string, cond_string, cmd_strings>: Replace char pointers
12389         with gdb::unique_xmalloc_ptr.
12390
12391 2019-01-10  Pedro Alves  <palves@redhat.com>
12392
12393         * solib-target.c (library_list_start_library): Don't xstrdup name.
12394
12395 2019-01-10  Pedro Alves  <palves@redhat.com>
12396
12397         * mdebugread.c (parse_partial_symbols): Use
12398         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12399
12400 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12401
12402         * linux-fork.c (scoped_switch_fork_info)
12403         <~scoped_switch_fork_info>: Fix incorrect variable name.
12404
12405 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12406
12407         * linux-fork.c (scoped_switch_fork_info)
12408         <scoped_switch_fork_info>: Make explicit.
12409         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12410
12411 2019-01-10  Tom Tromey  <tom@tromey.com>
12412
12413         * objfiles.h (objfile::reset_psymtabs): Update.
12414         * objfiles.c (objfile::objfile): Update.
12415         * psymtab.h (psymtab_storage::obstack): Update.
12416         (psymtab_storage::m_obstack): Use gdb::optional.
12417         (class psymtab_storage): Update comment.  Remove objfile
12418         parameter.
12419         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12420
12421 2019-01-10  Tom Tromey  <tom@tromey.com>
12422
12423         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12424         <free_psymtabs>: Now private.
12425         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12426         (allocate_psymtab): Use new method.
12427
12428 2019-01-10  Tom Tromey  <tom@tromey.com>
12429
12430         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12431         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12432         * mdebugread.c (parse_partial_symbols): Use
12433         allocate_dependencies.
12434         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12435         allocate_dependencies.
12436         (process_psymtab_comp_unit_reader)
12437         (build_type_psymtab_dependencies): Likewise.
12438         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12439
12440 2019-01-10  Tom Tromey  <tom@tromey.com>
12441
12442         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12443         PSYMBOL_SET_LANGUAGE.
12444         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12445
12446 2019-01-10  Tom Tromey  <tom@tromey.com>
12447
12448         * psymtab.h (psymtab_storage::obstack): New method.
12449         <m_obstack>: Rename from obstack; now private.
12450         * psymtab.c (psymtab_storage): Update.
12451         * dwarf2read.c (create_addrmap_from_index)
12452         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12453         Update.
12454
12455 2019-01-10  Tom Tromey  <tom@tromey.com>
12456
12457         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12458         * objfiles.h (objfile::reset_psymtabs): New method.
12459
12460 2019-01-10  Tom Tromey  <tom@tromey.com>
12461
12462         * symmisc.c (print_symbol_bcache_statistics): Update.
12463         (print_objfile_statistics): Update.
12464         * symfile.c (reread_symbols): Update.
12465         * psymtab.h (class psymtab_storage): New.
12466         * psymtab.c (psymtab_storage): New constructor.
12467         (~psymtab_storage): New destructor.
12468         (require_partial_symbols): Update.
12469         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12470         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12471         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12472         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12473         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12474         (start_psymtab_common, end_psymtab_common)
12475         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12476         (allocate_psymtab): Update.
12477         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12478         Update.
12479         (dump_psymtab_addrmap, maintenance_print_psymbols)
12480         (maintenance_check_psymtabs): Update.
12481         (class objfile_psymtabs): Move to objfiles.h.
12482         * psympriv.h (discard_psymtab): Now inline.
12483         (psymtab_discarder::psymtab_discarder): Update.
12484         (psymtab_discarder::~psymtab_discarder): Update.
12485         (ALL_OBJFILE_PSYMTABS): Rewrite.
12486         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12487         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12488         Remove fields.
12489         <partial_symtabs>: New field.
12490         (class objfile_psymtabs): Move from psymtab.h.  Update.
12491         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12492         psymbol_cache.
12493         (objfile::~objfile): Don't destroy psymbol_cache.
12494         * mdebugread.c (parse_partial_symbols): Update.
12495         * dwarf2read.c (create_addrmap_from_index)
12496         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12497         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12498         (add_partial_subprogram, dwarf2_ranges_read): Update.
12499         * dwarf-index-write.c (write_address_map)
12500         (write_one_signatured_type, recursively_write_psymbols)
12501         (class debug_names, class debug_names, write_psymtabs_to_index):
12502         Update.
12503
12504 2019-01-10  Tom Tromey  <tom@tromey.com>
12505
12506         * symtab.h (SYMBOL_SET_NAMES): Update.
12507         (symbol_set_names): Update.
12508         (MSYMBOL_SET_NAMES): Update.
12509         * symtab.c (symbol_set_names): Change argument to be an
12510         objfile_per_bfd_storage.
12511         * psymtab.c (add_psymbol_to_bcache): Update.
12512         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12513
12514 2019-01-10  Tom Tromey  <tom@tromey.com>
12515
12516         * symtab.c (create_demangled_names_hash): Change argument to be an
12517         objfile_per_bfd_storage.
12518         (symbol_set_names): Update.
12519
12520 2019-01-10  Tom Tromey  <tom@tromey.com>
12521
12522         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12523         init_psymbol_list.
12524         * psymtab.c (init_psymbol_list): Do nothing if already called.
12525         * psympriv.h (init_psymbol_list): Add comment.
12526         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12527         init_psymbol_list.
12528         * dbxread.c (dbx_symfile_read): Unconditionally call
12529         init_psymbol_list.
12530
12531 2019-01-10  Tom Tromey  <tom@tromey.com>
12532
12533         * xcoffread.c (scan_xcoff_symtab): Update.
12534         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12535         "where".
12536         * mdebugread.c (parse_partial_symbols)
12537         (handle_psymbol_enumerators): Update.
12538         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12539         * dbxread.c (read_dbx_symtab): Update.
12540         * psympriv.h (psymbol_placement): New enum.
12541         (add_psymbol_to_list): Update.
12542
12543 2019-01-10  Tom Tromey  <tom@tromey.com>
12544
12545         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12546         static_psymbols parameters.
12547         (scan_xcoff_symtab): Update.
12548         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12549         static_psymbols parameters.
12550         * psympriv.h (start_psymtab_common): Update.
12551         * mdebugread.c (parse_partial_symbols): Update.
12552         * dwarf2read.c (create_partial_symtab): Update.
12553         * dbxread.c (read_dbx_symtab): Update.
12554         (start_psymtab): Remove global_psymbols and static_psymbols
12555         parameters.
12556
12557 2019-01-10  Tom Tromey  <tom@tromey.com>
12558
12559         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12560         * psymtab.c (allocate_psymtab): Add comment.
12561         * psympriv.h (allocate_psymtab): Add comment.
12562         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12563         initializations.
12564         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12565
12566 2019-01-10  Tom Tromey  <tom@tromey.com>
12567
12568         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12569         Don't declare.
12570         * mipsread.c: Include mdebugread.h.
12571         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12572         Declare.
12573         * elfread.c: Include mdebugread.h.
12574
12575 2019-01-09  Tom Tromey  <tom@tromey.com>
12576
12577         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12578         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12579         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12580         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12581         (psym_lookup_symbol, psym_find_last_source_symtab)
12582         (psym_forget_cached_source_info, psym_print_stats)
12583         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12584         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12585         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12586         (psym_find_compunit_symtab_by_address)
12587         (maintenance_print_psymbols, maintenance_info_psymtabs)
12588         (maintenance_check_psymtabs): Use ranged for.
12589         * psymtab.h (class objfile_psymtabs): New.
12590         (require_partial_symbols): Return objfile_psymtabs.
12591         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12592
12593 2019-01-09  Tom Tromey  <tom@tromey.com>
12594
12595         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12596         (find_pc_mapped_section, list_overlays_command)
12597         (map_overlay_command, unmap_overlay_command)
12598         (simple_overlay_update): Use all_objfiles.
12599         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12600         * printcmd.c (info_symbol_command): Use all_objfiles.
12601         * objfiles.h (ALL_OBJSECTIONS): Remove.
12602         * maint.c (maintenance_translate_address): Use all_objfiles.
12603         * gcore.c (gcore_create_callback): Use all_objfiles.
12604         (objfile_find_memory_regions): Likewise.
12605
12606 2019-01-09  Tom Tromey  <tom@tromey.com>
12607
12608         * symtab.c (find_line_symtab, info_sources_command)
12609         (make_source_files_completion_list): Use objfile_compunits.
12610         * source.c (select_source_symtab): Use objfile_compunits.
12611         * objfiles.h (struct objfile): Update comment.
12612         (ALL_OBJFILES): Remove.
12613         (ALL_FILETABS): Remove.
12614         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12615         objfile_compunits.
12616
12617 2019-01-09  Tom Tromey  <tom@tromey.com>
12618
12619         * symmisc.c (print_objfile_statistics, dump_objfile)
12620         (maintenance_print_symbols): Use compunit_filetabs.
12621         * source.c (forget_cached_source_info_for_objfile): Use
12622         compunit_filetabs.
12623         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12624         (ALL_FILETABS): Use compunit_filetabs.
12625         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12626         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12627
12628 2019-01-09  Tom Tromey  <tom@tromey.com>
12629
12630         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12631         (compunit_filetabs): New.
12632         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12633         compunit_filetabs.
12634         (info_sources_command, make_source_files_completion_list): Remove
12635         declaration.
12636         * symmisc.c (print_objfile_statistics, dump_objfile)
12637         (maintenance_print_symbols): Remove declaration.
12638         (maintenance_info_symtabs): Use compunit_filetabs.
12639         (maintenance_info_line_tables): Likewise.
12640         * source.c (select_source_symtab): Change local variable name.
12641         (forget_cached_source_info_for_objfile): Remove declaration.
12642         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12643         * objfiles.c (objfile_relocate1): Remove declaration.
12644         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12645         declaration.
12646         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12647         * coffread.c (coff_symtab_read): Remove declaration.
12648         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12649         compunit_filetabs.
12650
12651 2019-01-09  Tom Tromey  <tom@tromey.com>
12652
12653         * symtab.c (lookup_objfile_from_block)
12654         (find_pc_sect_compunit_symtab, search_symbols)
12655         (default_collect_symbol_completion_matches_break_on): Use
12656         objfile_compunits.
12657         * objfiles.h (ALL_COMPUNITS): Remove.
12658         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12659         * cp-support.c (add_symbol_overload_list_qualified): Use
12660         objfile_compunits.
12661         * ada-lang.c (ada_collect_symbol_completion_matches)
12662         (ada_add_global_exceptions): Use objfile_compunits.
12663
12664 2019-01-09  Tom Tromey  <tom@tromey.com>
12665
12666         * source.c (select_source_symtab)
12667         (forget_cached_source_info_for_objfile): Remove declaration.
12668         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12669         declaration.
12670         * maint.c (count_symtabs_and_blocks): Remove declaration.
12671         * cp-support.c (add_symbol_overload_list_qualified): Remove
12672         declaration.
12673         * coffread.c (coff_symtab_read): Remove declaration.
12674         * symtab.c (lookup_symbol_in_objfile_symtabs)
12675         (basic_lookup_transparent_type_1): Use objfile_compunits.
12676         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12677         (info_sources_command, search_symbols)
12678         (default_collect_symbol_completion_matches_break_on)
12679         (make_source_files_completion_list): Remove declaration.
12680         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12681         (ada_collect_symbol_completion_matches)
12682         (ada_add_global_exceptions): Remove declaration.
12683         * linespec.c (iterate_over_all_matching_symtabs): Use
12684         objfile_compunits.
12685         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12686         (class objfile_compunits): New.
12687         (ALL_COMPUNITS): Use objfile_compunits.
12688         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12689         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12690         objfile_compunits.
12691         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12692
12693 2019-01-09  Tom Tromey  <tom@tromey.com>
12694
12695         * symtab.c (search_symbols)
12696         (default_collect_symbol_completion_matches_break_on): Use
12697         objfile_msymbols.
12698         * ada-lang.c (ada_lookup_simple_minsym)
12699         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12700         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12701         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12702         objfile_msymbols.
12703         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12704         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12705         * objc-lang.c (find_methods): Use objfile_msymbols.
12706         (info_selectors_command, info_classes_command): Likewise.
12707         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12708         * objfiles.h (class objfile_msymbols): New.
12709         (ALL_OBJFILE_MSYMBOLS): Remove.
12710         (ALL_MSYMBOLS): Remove.
12711
12712 2019-01-09  Tom Tromey  <tom@tromey.com>
12713
12714         * common/next-iterator.h (next_adapter): Add Iterator template
12715         parameter.
12716         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12717         (class all_objfiles_safe): New.
12718         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12719         * objfiles.c (put_objfile_before): Update comment.
12720         (add_separate_debug_objfile): Likewise.
12721         (free_all_objfiles): Use all_objfiles_safe.
12722         (objfile_purge_solibs): Likewise.
12723
12724 2019-01-09  Tom Tromey  <tom@tromey.com>
12725
12726         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12727         (expand_symtab_containing_pc, lookup_static_symbol)
12728         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12729         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12730         all_objfiles.
12731         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12732         * breakpoint.c (create_overlay_event_breakpoint)
12733         (create_longjmp_master_breakpoint)
12734         (create_std_terminate_master_breakpoint)
12735         (create_exception_master_breakpoint): Use all_objfiles.
12736         * linux-thread-db.c (try_thread_db_load_from_pdir)
12737         (has_libpthread): Use all_objfiles.
12738         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12739         * linespec.c (iterate_over_all_matching_symtabs)
12740         (search_minsyms_for_name): Use all_objfiles.
12741         * maint.c (maintenance_info_sections): Use all_objfiles.
12742         * main.c (captured_main_1): Use all_objfiles.
12743         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12744         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12745         * guile/scm-pretty-print.c
12746         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12747         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12748         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12749         (maintenance_print_msymbols): Use all_objfiles.
12750         * source.c (select_source_symtab): Use all_objfiles.
12751         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12752         * symfile.c (remove_symbol_file_command)
12753         (expand_symtabs_matching, map_symbol_filenames): Use
12754         all_objfiles.
12755         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12756         all_objfiles.
12757         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12758         * objc-lang.c (find_methods): Use all_objfiles.
12759         * objfiles.c (have_partial_symbols, have_full_symbols)
12760         (have_minimal_symbols, qsort_cmp)
12761         (default_iterate_over_objfiles_in_search_order): Use
12762         all_objfiles.
12763         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12764         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12765         (maintenance_check_psymtabs): Use all_objfiles.
12766         (ALL_PSYMTABS): Remove.
12767         * compile/compile-object-run.c (do_module_cleanup): Use
12768         all_objfiles.
12769         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12770         * cp-support.c (add_symbol_overload_list_qualified): Use
12771         all_objfiles.
12772         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12773         Use all_objfiles.
12774         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12775         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12776         all_objfiles.
12777         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12778         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12779         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12780         Uses all_objfiles.
12781         * solib.c (solib_read_symbols): Use all_objfiles
12782
12783 2019-01-09  Tom Tromey  <tom@tromey.com>
12784
12785         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12786         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12787         all_objfiles.
12788         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12789         * symmisc.c (print_symbol_bcache_statistics)
12790         (print_objfile_statistics, maintenance_print_objfiles)
12791         (maintenance_info_symtabs, maintenance_check_symtabs)
12792         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12793         all_objfiles.
12794         * source.c (forget_cached_source_info): Use all_objfiles.
12795         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12796         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12797         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12798         * objfiles.c (update_section_map): Use all_objfiles.
12799         (shared_objfile_contains_address_p): Likewise.
12800         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12801         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12802
12803 2019-01-09  Tom Tromey  <tom@tromey.com>
12804
12805         * common/next-iterator.h: New file.
12806         * objfiles.h (class all_objfiles): New.
12807         (struct objfile_iterator): New.
12808
12809 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12810
12811         * NEWS: Move the description of the changed "frame", "select-frame",
12812          and "info frame" commands to the Changed commands section.
12813
12814 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12815
12816         * gdbtypes.c (check_stub_method_group): Remove handling of old
12817         mangling schemes.
12818         * linespec.c (find_methods): Likewise.
12819         * stabsread.c (read_member_functions): Likewise.
12820         * valops.c (search_struct_method): Likewise.
12821         (value_struct_elt_for_reference): Likewise.
12822         * NEWS: Mention this change.
12823
12824 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12825
12826         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12827         print_source_lines.
12828         * source.c (print_source_lines_base): Update line number check.
12829         (print_source_lines): New function.
12830         (source_lines_range::source_lines_range): New function.
12831         * source.h (class source_lines_range): New class.
12832         (print_source_lines): New declaration.
12833
12834 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12835
12836         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12837
12838 2019-01-08  Tom Tromey  <tom@tromey.com>
12839             Simon Marchi  <simon.marchi@ericsson.com>
12840
12841         PR gdb/24060
12842         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12843         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12844         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12845         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12846         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12847         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12848
12849 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12850
12851         * source.c (select_source_symtab): Move header comment to
12852         declaration in source.h.
12853         (forget_cached_source_info_for_objfile): Likewise.
12854         (forget_cached_source_info): Likewise.
12855         (identify_source_line): Likewise.
12856         * source.h (identify_source_line): Move declaration from symtab.h
12857         and add comment from source.c
12858         (print_source_lines): Likewise.
12859         (forget_cached_source_info_for_objfile): Likewise.
12860         (forget_cached_source_info): Likewise.
12861         (select_source_symtab): Likewise.
12862         (enum print_source_lines_flag): Move definition from symtab.h.
12863         * symtab.h (identify_source_line): Move declaration to source.h.
12864         (print_source_lines): Likewise.
12865         (forget_cached_source_info_for_objfile): Likewise.
12866         (forget_cached_source_info): Likewise.
12867         (select_source_symtab): Likewise.
12868         (enum print_source_lines_flag): Move definition to source.h.
12869         * tui/tui-hooks.c: Add 'source.h' include.
12870
12871 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12872
12873         * source.c (print_source_lines_base): Handle requests to print
12874         reverse line number sequences, and guard against empty lines
12875         string.
12876
12877 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12878
12879         * source.c (print_source_lines_base): Fix skip of '\r' if next
12880         character is '\n'.
12881
12882 2019-01-06  Tom Tromey  <tom@tromey.com>
12883
12884         * c-exp.y (struct c_parse_state) <macro_original_text,
12885         expansion_obstack>: New member.
12886         (macro_original_text, expansion_obstack): Remove globals.
12887         (scan_macro_expansion, scanning_macro_expansion)
12888         (finished_macro_expansion): Update.
12889         (scan_macro_cleanup): Remove.
12890         (yylex, c_parse): Update.
12891
12892 2019-01-06  Tom Tromey  <tom@tromey.com>
12893
12894         * c-exp.y (struct c_parse_state) <strings>: New member.
12895         (operator_stoken): Update.
12896
12897 2019-01-06  Tom Tromey  <tom@tromey.com>
12898
12899         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12900         (union type_stack_elt) <typelist_val>: Now a pointer to
12901         std::vector.
12902         (type_stack_cleanup): Don't declare.
12903         (push_typelist): Update.
12904         * parse.c (pop_typelist): Return a std::vector.
12905         (push_typelist): Take a std::vector.
12906         (follow_types): Update.  Do not free args.
12907         (type_stack_cleanup): Remove.
12908         * c-exp.y (struct c_parse_state): New.
12909         (cpstate): New global.
12910         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12911         (nonempty_typelist): Update.
12912         (func_mod): Create a new vector.
12913         (c_parse): Create a c_parse_state.
12914         (check_parameter_typelist): Do not delete params.
12915         (function_method): Update.  Do not delete type_list.
12916
12917 2019-01-06  Tom Tromey  <tom@tromey.com>
12918
12919         PR gdb/28155:
12920         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12921         check_typedef.
12922         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12923         (print_return_value): Likewise.
12924
12925 2019-01-05  Tom Tromey  <tom@tromey.com>
12926
12927         * contrib/cleanup_check.py: Remove.
12928         * contrib/gcc-with-excheck: Remove.
12929         * contrib/exsummary.py: Remove.
12930         * contrib/excheck.py: Remove.
12931
12932 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12933
12934         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12935         NULL. Initialize tpprev to NULL instead of assigning it
12936         to NULL on the next statement.
12937         * windows-nat.c (windows_delete_thread): Remove check for
12938         main_thread_id before printing thread exit notifications.
12939         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12940         Remove thread ID check against main_thread_id.
12941         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12942         windows_delete_thread.
12943         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12944
12945 2019-01-04  Tom Tromey  <tom@tromey.com>
12946
12947         * compile/compile.c (_initialize_compile): Use upper case for
12948         metasyntactic variables.
12949         * symmisc.c (_initialize_symmisc): Use upper case for
12950         metasyntactic variables.
12951         * psymtab.c (_initialize_psymtab): Use upper case for
12952         metasyntactic variables.
12953         * demangle.c (demangle_command): Use upper case for metasyntactic
12954         variables.
12955         (_initialize_demangler): Likewise.
12956         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12957         variables.
12958
12959 2019-01-03  Tom Tromey  <tom@tromey.com>
12960
12961         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12962
12963 2019-01-03  Tom Tromey  <tom@tromey.com>
12964
12965         * python/py-symtab.c (salpy_str): Update.
12966         (struct salpy_sal_object) <symtab>: Now a PyObject.
12967         (salpy_dealloc): Update.
12968         (del_objfile_sal): Use gdbpy_ref.
12969
12970 2019-01-03  Tom Tromey  <tom@tromey.com>
12971
12972         * python/py-type.c (convert_field): Use new_reference.  Return
12973         gdbpy_ref.
12974         (make_fielditem): Return gdbpy_ref.
12975         (typy_fields): Update.
12976         (typy_getitem): Update.
12977         (field_name): Return gdbpy_ref.  Use new_reference.
12978         (typy_iterator_iternext): Update.
12979
12980 2019-01-03  Tom Tromey  <tom@tromey.com>
12981
12982         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12983
12984 2019-01-03  Tom Tromey  <tom@tromey.com>
12985
12986         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12987         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12988         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12989         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12990         (pspy_set_type_printers): Likewise.
12991         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12992         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12993         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12994         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12995         (objfpy_set_type_printers): Likewise.
12996
12997 2019-01-03  Tom Tromey  <tom@tromey.com>
12998
12999         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13000         (gdbpy_print_stack): Use gdbpy_err_fetch.
13001         * python/python-internal.h (class gdbpy_err_fetch): New class.
13002         (class gdbpy_enter) <m_error_type, m_error_value,
13003         m_error_traceback>: Remove.
13004         <m_error>: New member.
13005         (gdbpy_exception_to_string): Don't declare.
13006         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13007         * python/py-value.c (convert_value_from_python): Use
13008         gdbpy_err_fetch.
13009         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13010         gdbpy_exception_to_string.
13011         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13012         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13013         gdbpy_err_fetch.
13014
13015 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13016
13017         * linux-nat.c (delete_lwp_cleanup): Delete.
13018         (struct lwp_deleter): New struct.
13019         (lwp_info_up): New typedef.
13020         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13021         lwp_info_up.
13022
13023 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13024
13025         * linux-fork.c (class scoped_switch_fork_info): New class.
13026         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13027
13028 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13029
13030         * valops.c (find_overload_match): Remove use of null_cleanup, and
13031         calls to do_cleanups.
13032
13033 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13034
13035         * compile/compile-cplus-types.c
13036         (compile_cplus_instance::decl_name): Handle changes to
13037         cp_func_name.
13038         * cp-support.c (cp_func_name): Update header comment, update
13039         return type.
13040         * cp-support.h (cp_func_name): Update return type in declaration.
13041         * valops.c (find_overload_match): Move temp_func local to top
13042         level of function and change its type.  Use temp_func to hold and
13043         delete temporary string obtained from cp_func_name.
13044
13045 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13046
13047         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13048         gdb::char_vector, remove cleanup, and update uses of `msg`.
13049
13050 2019-01-03  Jim Wilson  <jimw@sifive.com>
13051
13052         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13053
13054 2019-01-02  Tom Tromey  <tom@tromey.com>
13055
13056         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13057         (tdesc_parse_xml): Remove cleanups.
13058         * target-descriptions.h (make_cleanup_free_target_description):
13059         Don't declare.
13060         (target_desc_deleter): New struct.
13061         (target_desc_up): New typedef.
13062         * target-descriptions.c (target_desc_deleter::operator()): Rename
13063         from free_target_description.
13064         (make_cleanup_free_target_description): Remove.
13065
13066 2019-01-02  Tom Tromey  <tom@tromey.com>
13067
13068         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13069         constructor, destructor.
13070         (linespec_parser): Remove typedef.
13071         (~linespec_parser): Rename from linespec_parser_delete.
13072         (linespec_lex_to_end, linespec_complete_label)
13073         (linespec_complete): Update.
13074         (decode_line_full): Remove cleanups.
13075         (decode_line_1): Update.
13076
13077 2019-01-02  Tom Tromey  <tom@tromey.com>
13078
13079         * python/python-internal.h (inferior_to_inferior_object): Change
13080         return type.
13081         * python/py-exitedevent.c (create_exited_event_object): Update.
13082         * python/py-inferior.c (inferior_to_inferior_object): Return
13083         gdbpy_ref.
13084         (python_new_inferior, python_inferior_deleted)
13085         (thread_to_thread_object, delete_thread_object)
13086         (build_inferior_list, gdbpy_selected_inferior): Update.
13087         * python/py-infthread.c (create_thread_object): Update.  Also fail
13088         if inferior_to_inferior_object fails.
13089
13090 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13091
13092         * inferior.h (class inferior) <displaced_step_state>: New field.
13093         * infrun.h (struct displaced_step_state): Move here from
13094         infrun.c.  Initialize fields, add constructor.
13095         <inf>: Remove field.
13096         <reset>: New method.
13097         * infrun.c (struct displaced_step_inferior_state): Move to
13098         infrun.h.
13099         (displaced_step_inferior_states): Remove.
13100         (get_displaced_stepping_state): Adust.
13101         (displaced_step_in_progress_any_inferior): Adjust.
13102         (displaced_step_in_progress_thread): Adjust.
13103         (displaced_step_in_progress): Adjust.
13104         (add_displaced_stepping_state): Remove.
13105         (get_displaced_step_closure_by_addr): Adjust.
13106         (remove_displaced_stepping_state): Remove.
13107         (infrun_inferior_exit): Call displaced_step_state.reset.
13108         (use_displaced_stepping): Don't check for NULL.
13109         (displaced_step_prepare_throw): Call
13110         get_displaced_stepping_state.
13111         (displaced_step_fixup): Don't check for NULL.
13112         (prepare_for_detach): Don't check for NULL.
13113
13114 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13115
13116         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13117          in case of call that did not complete.
13118
13119 2019-01-02  Andrey Utkin  <autkin@undo.io>
13120
13121         * symfile.c (find_separate_debug_file): Fix search of debug files for
13122         remote debuggee.
13123
13124 2019-01-02  Tom Tromey  <tom@tromey.com>
13125
13126         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13127         indentation.
13128         * python/py-frame.c (frapy_older): Remove cast.
13129         (frapy_newer): Likewise.
13130         * python/py-breakpoint.c (local_setattro): Remove cast.
13131         * python/py-arch.c (archpy_name): Remove local variable.
13132         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13133
13134 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13135
13136         * unittests/basic_string_view/element_access/char/empty.cc:
13137         Fix year range in copyright header.
13138
13139 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13140
13141         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13142         Delete.
13143         <operator==>: Update with for removed field.
13144         <hash>: Likewise.
13145         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13146         <isa_features>: ...this.
13147         <abi_features>: New field.
13148         (riscv_isa_flen): Update comment.
13149         (riscv_abi_xlen): New declaration.
13150         (riscv_abi_flen): New declaration.
13151         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13152         isa_features.
13153         (riscv_abi_xlen): New function.
13154         (riscv_isa_flen): Update to get answer from isa_features.
13155         (riscv_abi_flen): New function.
13156         (riscv_has_fp_abi): Update to get answer from abi_features.
13157         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13158         xlen and flen.
13159         (riscv_call_info) <xlen, flen>: Update comment.
13160         (riscv_call_arg_struct): Remove invalid assertions
13161         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13162         is removed.
13163         (riscv_gdbarch_init): Gather isa features and abi features
13164         separately, ensure both match on the gdbarch when reusing an old
13165         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13166         a target with 64-bit float hardware.
13167
13168 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13169
13170         * source.c (search_command_helper): Stop reverse search
13171         when line 1 has been searched.
13172
13173 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13174
13175         * record-full.c (record_full_base_target::close): Rewrite
13176         record_full_core_buf_list free logic.
13177
13178 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13179
13180         * break-catch-syscall.c (print_one_catch_syscall): xfree
13181         the last text.
13182
13183 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13184
13185         * top.c (print_gdb_version): Update Copyright year in version
13186         message.
13187
13188 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13189
13190         Update copyright year range in all GDB files.
13191
13192 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13193
13194         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13195
13196 For older changes see ChangeLog-2018.
13197 \f
13198 Local Variables:
13199 mode: change-log
13200 left-margin: 8
13201 fill-column: 74
13202 version-control: never
13203 coding: utf-8
13204 End:
13205