gdb/ChangeLog

   1 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
   4         (get_dyn_prop): Remove.  Update all users to use
   5         type::dyn_prop.
   6         * gdbtypes.c (get_dyn_prop): Rename to...
   7         (type::dyn_prop): ... this.
   8
   9 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
  10
  11         * gdbtypes.h (struct main_type) <flag_static>: Remove.
  12
  13 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
  14
  15         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
  16         instruction, skip it if it's there.
  17
  18 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
  19
  20         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
  21
  22 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
  23
  24         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
  25         * gdbtypes.c (recursive_dump_type): Remove use of
  26         TYPE_INCOMPLETE.
  27
  28 2020-05-03  Tom Tromey  <tom@tromey.com>
  29
  30         * breakpoint.c (catch_command, tcatch_command): Remove.
  31         (_initialize_breakpoint): Use add_basic_prefix_cmd,
  32         add_show_prefix_cmd.
  33         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
  34         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
  35         Remove.
  36         (add_internal_problem_command): Use add_basic_prefix_cmd,
  37         add_show_prefix_cmd.
  38         * mips-tdep.c (set_mipsfpu_command): Remove.
  39         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
  40         * dwarf2/index-cache.c (set_index_cache_command): Remove.
  41         (_initialize_index_cache): Use add_basic_prefix_cmd.
  42         * memattr.c (dummy_cmd): Remove.
  43         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
  44         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
  45         (_initialize_tui_win): Use add_basic_prefix_cmd,
  46         add_show_prefix_cmd.
  47         * cli/cli-logging.c (set_logging_command): Remove.
  48         (_initialize_cli_logging): Use add_basic_prefix_cmd,
  49         add_show_prefix_cmd.
  50         (show_logging_command): Remove.
  51         * target.c (target_command): Remove.
  52         (add_target): Use add_basic_prefix_cmd.
  53
  54 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
  55
  56         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
  57
  58 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  59
  60         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
  61         info_command.
  62
  63 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
  64
  65         * nbsd-nat.c (nbsd_enable_proc_events)
  66         (nbsd_nat_target::post_startup_inferior): Add.
  67         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
  68         (nbsd_nat_target::update_thread_list): Rewrite.
  69         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
  70         "PTRACE_LWP_CREATE".
  71         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
  72
  73 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  74
  75         * stack.c (_initialize_stack): Remove duplicated creation
  76         of "frame" command and "f" alias.
  77
  78 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
  79
  80         PR gdb/18706
  81         * gdbtypes.c (check_typedef): Calculate size of array of
  82         stubbed type.
  83
  84 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
  85
  86         PR gdb/15559
  87         * i386-tdep.c (i386_push_dummy_call): Call
  88         i386_thiscall_push_dummy_call.
  89         (i386_thiscall_push_dummy_call): New function.
  90         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
  91         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
  92         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
  93
  94 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
  95
  96         * gdbarch.sh (do_read): Add shellcheck disable directive for
  97         warning SC2162.
  98
  99 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 100
 101         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
 102         "referenced but not assigned" warning.
 103
 104 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 105
 106         * gdbarch.sh: Remove code that sets fallbackdefault.
 107
 108 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 109
 110         * gdbarch.sh: Use shell operators && and || instead of
 111         -a and -o.
 112
 113 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 114
 115         * gdbarch.sh: Use $(...) instead of `...`.
 116
 117 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 118
 119         * gdbarch.sh: Use double quotes around variables.
 120
 121 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 122
 123         * gdbarch.sh: Use %s with printf, instead of variables in the
 124         format string.
 125
 126 2020-04-29  Tom Tromey  <tromey@adacore.com>
 127
 128         PR ada/25875:
 129         * dwarf2/read.c (update_enumeration_type_from_children): Compute
 130         type fields here.
 131         (read_enumeration_type): Call
 132         update_enumeration_type_from_children later.  Update comments.
 133         (process_enumeration_scope): Don't create type fields.
 134
 135 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 136
 137         * nbsd-tdep.c: Include "xml-syscall.h".
 138         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
 139
 140 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 141
 142         * nbsd-nat.c: Include "sys/wait.h".
 143         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
 144         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
 145         (nbsd_nat_target::remove_exec_catchpoint)
 146         (nbsd_nat_target::set_syscall_catchpoint): Add.
 147         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
 148         (nbsd_nat_target::insert_exec_catchpoint)
 149         (nbsd_nat_target::remove_exec_catchpoint)
 150         (nbsd_nat_target::set_syscall_catchpoint): Add.
 151         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
 152         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
 153         `nbsd_get_syscall_number'.
 154
 155 2020-04-29  Tom Tromey  <tom@tromey.com>
 156
 157         * stack.c (print_block_frame_labels): Remove.
 158
 159 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 160
 161         PR gdb/17320
 162         * ada-valprint.c (val_print_packed_array_elements): Move array
 163         end bracket to new line.
 164         (ada_val_print_string): Remove extra spaces before first array
 165         element.
 166         * c-valprint.c (c_value_print_array): Likewise.
 167         * m2-valprint.c (m2_print_array_contents): Likewise.
 168         (m2_value_print_inner): Likewise.
 169         * p-valprint.c (pascal_value_print_inner): Likewise.
 170         * valprint.c (generic_val_print_array): Likewise.
 171         (value_print_array_elements): Move first array element and array
 172         end bracket to new line.
 173
 174 2020-04-29  Tom de Vries  <tdevries@suse.de>
 175
 176         PR symtab/25889
 177         * linespec.c (find_method): Fix ix calculation.
 178
 179 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
 180
 181         * syscalls/update-netbsd.sh: New file.
 182         * syscalls/netbsd.xml: Regenerate.
 183         * data-directory/Makefile.in: Register `netbsd.xml' in
 184         `SYSCALLS_FILES'.
 185
 186 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 187
 188         * syscalls/update-freebsd.sh: Add double quotes.
 189
 190 2020-04-28  Tom Tromey  <tom@tromey.com>
 191
 192         * NEWS: Update.
 193         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
 194         (cmdpy_init): Allow class_tui.
 195
 196 2020-04-28 Mark Williams <mark@myosotissp.com>
 197
 198         PR gdb/24480
 199         * dwarf2read.c: Add missing assingments to list_in_scope when
 200         start_symtab was already called.
 201
 202 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 203
 204         PR gdb/25881
 205         * dwarf2/read.c (offset_map_type): Use
 206         gdb:hash_enum<sect_offset> as hash function.
 207
 208 2020-04-28  Tom de Vries  <tdevries@suse.de>
 209
 210         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
 211         with DW_AT_signature.
 212
 213 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
 214
 215         * configure.ac: Remove check for fs_base/gs_base in
 216         user_regs_struct.
 217         * configure: Re-generate.
 218         * config.in: Re-generate.
 219         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
 220         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
 221         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
 222
 223 2020-04-27  Luis Machado  <luis.machado@linaro.org>
 224
 225         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
 226         problematic inline frame unwinding situation.
 227         * frame.c (frame_id_computed_p): New function.
 228         * frame.h (frame_id_computed_p): New prototype.
 229
 230 2020-04-26  Tom Tromey  <tom@tromey.com>
 231
 232         * command.h (enum command_class) <class_pseudo>: Remove.
 233
 234 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 235
 236         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
 237         and whitespace.
 238
 239 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
 240
 241        * inf-ptrace.c (inf_ptrace_target::wait): Remove
 242        `PT_GET_PROCESS_STATE' block.
 243
 244 2020-04-24  Tom Tromey  <tom@tromey.com>
 245
 246         * symtab.h (symbol_get_demangled_name): Don't declare.
 247         * symtab.c (symbol_get_demangled_name): Remove.
 248         (general_symbol_info::natural_name)
 249         (general_symbol_info::demangled_name): Update.
 250
 251 2020-04-24  Tom Tromey  <tom@tromey.com>
 252
 253         PR rust/25025:
 254         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
 255
 256 2020-04-24  Tom Tromey  <tom@tromey.com>
 257
 258         PR symtab/12707:
 259         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
 260         exists.
 261         (new_symbol): Likewise.
 262         * compile/compile-object-load.c (get_out_value_type): Use
 263         symbol_matches_search_name.
 264
 265 2020-04-24  Tom Tromey  <tom@tromey.com>
 266
 267         * dwarf2/read.c (add_partial_symbol): Do not call
 268         compute_and_set_names.
 269
 270 2020-04-24  Tom Tromey  <tom@tromey.com>
 271
 272         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
 273         overload.
 274
 275 2020-04-24  Tom Tromey  <tom@tromey.com>
 276
 277         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
 278         (add_psymbol_to_list): New overload.  Make old overload call new
 279         one.
 280         * psympriv.h (add_psymbol_to_list): New overload.
 281
 282 2020-04-24  Tom Tromey  <tom@tromey.com>
 283
 284         * dwarf2/read.c (partial_die_info::read) <case
 285         DW_AT_linkage_name>: Use value_as_string.
 286         (dwarf2_string_attr): Use value_as_string.
 287         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
 288         method.
 289         * dwarf2/attribute.c (attribute::value_as_string): New method.
 290
 291 2020-04-24  Tom Tromey  <tom@tromey.com>
 292
 293         * symtab.c (general_symbol_info::natural_name)
 294         (general_symbol_info::demangled_name): Check for language_rust.
 295
 296 2020-04-24  Tom Tromey  <tom@tromey.com>
 297
 298         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 299         (dwarf2_physname): ... from here.
 300         (partial_die_info::read): Add Rust "{" hack.
 301
 302 2020-04-24  Tom Tromey  <tom@tromey.com>
 303
 304         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 305         method.
 306         (symbol_set_demangled_name): Don't declare.
 307         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 308         symbol_set_demangled_name.
 309         (general_symbol_info::set_language)
 310         (general_symbol_info::compute_and_set_names): Update.
 311         * minsyms.c (minimal_symbol_reader::install): Update.
 312         * dwarf2/read.c (new_symbol): Update.
 313
 314 2020-04-24  Tom Tromey  <tromey@adacore.com>
 315
 316         PR python/23662:
 317         * python/py-type.c (convert_field): Handle
 318         FIELD_LOC_KIND_DWARF_BLOCK.
 319         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 320         (typy_get_dynamic): Nw function.
 321         (type_object_getset): Add "dynamic".
 322         * NEWS: Add entry.
 323
 324 2020-04-24  Tom Tromey  <tromey@adacore.com>
 325
 326         * ada-typeprint.c (print_choices, print_variant_part)
 327         (print_record_field_types_dynamic): New functions.
 328         (print_record_field_types): Use print_record_field_types_dynamic.
 329
 330 2020-04-24  Tom Tromey  <tromey@adacore.com>
 331
 332         * dwarf2/read.c (handle_data_member_location): New overload.
 333         (dwarf2_add_field): Use it.
 334         (decode_locdesc): Add "computed" parameter.  Update comment.
 335         * gdbtypes.c (is_dynamic_type_internal): Also look for
 336         FIELD_LOC_KIND_DWARF_BLOCK.
 337         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 338         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 339         virtual base classes.
 340         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 341         FIELD_LOC_KIND_DWARF_BLOCK.
 342
 343 2020-04-24  Tom Tromey  <tromey@adacore.com>
 344
 345         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 346         * gdbtypes.c (is_dynamic_type_internal): Check
 347         TYPE_HAS_DYNAMIC_LENGTH.
 348         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 349         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 350         New macros.
 351         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 352         constant.
 353
 354 2020-04-24  Tom Tromey  <tromey@adacore.com>
 355
 356         * dwarf2/read.c (struct variant_field): Rewrite.
 357         (struct variant_part_builder): New.
 358         (struct nextfield): Remove "variant" field.  Add "offset".
 359         (struct field_info): Add "current_variant_part" and
 360         "variant_parts".
 361         (alloc_discriminant_info): Remove.
 362         (alloc_rust_variant): New function.
 363         (quirk_rust_enum): Update.
 364         (dwarf2_add_field): Set "offset" member.  Don't handle
 365         DW_TAG_variant_part.
 366         (offset_map_type): New typedef.
 367         (convert_variant_range, create_one_variant)
 368         (create_one_variant_part, create_variant_parts)
 369         (add_variant_property): New functions.
 370         (dwarf2_attach_fields_to_type): Call add_variant_property.
 371         (read_structure_type): Don't handle DW_TAG_variant_part.
 372         (handle_variant_part, handle_variant): New functions.
 373         (handle_struct_member_die): Use them.
 374         (process_structure_scope): Don't handle variant parts.
 375         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 376         (struct discriminant_info): Remove.
 377         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 378         (struct main_type) <flag_discriminated_union>: Remove.
 379         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 380         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 381         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 382         Update.
 383         * valops.c (value_union_variant): Remove.
 384         * value.h (value_union_variant): Don't declare.
 385
 386 2020-04-24  Tom Tromey  <tromey@adacore.com>
 387
 388         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 389         (ada_value_primitive_packed_val): Update.
 390         * ada-valprint.c (ada_value_print_1): Update.
 391         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 392         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 393         just an address.  Use evaluate_for_locexpr_baton.
 394         (dwarf2_evaluate_property): Update.
 395         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 396         array_view.
 397         * findvar.c (default_read_var_value): Update.
 398         * gdbtypes.c (compute_variant_fields_inner)
 399         (resolve_dynamic_type_internal): Update.
 400         (resolve_dynamic_type): Change type of valaddr parameter.
 401         * gdbtypes.h (resolve_dynamic_type): Update.
 402         * valarith.c (value_subscripted_rvalue): Update.
 403         * value.c (value_from_contents_and_address): Update.
 404
 405 2020-04-24  Tom Tromey  <tromey@adacore.com>
 406
 407         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 408         "push_initial_value" parameter.
 409         (dwarf2_evaluate_property): Likewise.
 410         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 411
 412 2020-04-24  Tom Tromey  <tromey@adacore.com>
 413
 414         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 415         (variant::matches, compute_variant_fields_recurse)
 416         (compute_variant_fields_inner, compute_variant_fields): New
 417         functions.
 418         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 419         Use resolved_type after type is made.
 420         (operator==): Add new cases.
 421         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 422         (struct discriminant_range, struct variant, struct variant_part):
 423         New.
 424         (union dynamic_prop_data) <variant_parts, original_type>: New
 425         members.
 426         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 427         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 428         constants.
 429         * value.c (unpack_bits_as_long): Now public.
 430         * value.h (unpack_bits_as_long): Declare.
 431
 432 2020-04-24  Tom Tromey  <tromey@adacore.com>
 433
 434         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 435         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 436
 437 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 438
 439         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 440
 441 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 442
 443         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 444         (remove_fork_catchpoint, post_startup_inferior)
 445         (post_attach): Move...
 446         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 447         (remove_fork_catchpoint, post_startup_inferior)
 448         (post_attach): ...here.
 449         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 450         (remove_fork_catchpoint, post_startup_inferior)
 451         (post_attach): Move...
 452         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 453         (remove_fork_catchpoint, post_startup_inferior)
 454         (post_attach): ...here.
 455
 456 2020-04-24  Tom Tromey  <tromey@adacore.com>
 457
 458         * nat/windows-nat.h (struct windows_thread_info)
 459         <pc_adjusted>: New member.
 460         * windows-nat.c (windows_fetch_one_register): Check
 461         pc_adjusted.
 462         (windows_nat_target::get_windows_debug_event)
 463         (windows_nat_target::wait): Set pc_adjusted.
 464
 465 2020-04-24  Tom de Vries  <tdevries@suse.de>
 466
 467         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
 468         Run gdb-add-index inside temp dir.
 469
 470 2020-04-23  Tom Tromey  <tromey@adacore.com>
 471
 472         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
 473         in loop.
 474
 475 2020-04-23  Luis Machado  <luis.machado@linaro.org>
 476
 477         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
 478         get_frame_register instead of gdbarch_unwind_pc.
 479
 480 2020-04-23  Tom de Vries  <tdevries@suse.de>
 481
 482         * symtab.c (lookup_global_symbol): Prefer def over decl.
 483
 484 2020-04-23  Tom de Vries  <tdevries@suse.de>
 485
 486         PR symtab/25807
 487         * block.c (best_symbol, better_symbol): Promote to external.
 488         * block.h (best_symbol, better_symbol): Declare.
 489         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
 490         decl.
 491
 492 2020-04-23  Tom Tromey  <tromey@adacore.com>
 493
 494         PR ada/25837:
 495         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
 496         "const char *", not a "const std::string &".
 497         <name_and_matcher::operator==>: Update.
 498         * unittests/lookup_name_info-selftests.c: Change type of
 499         "result".
 500
 501 2020-04-23  Tom Tromey  <tom@tromey.com>
 502
 503         * inferior.h (iterate_over_inferiors): Don't declare.
 504         * inferior.c (iterate_over_inferiors): Remove.
 505         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
 506         Remove.
 507         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
 508         use iterate_over_inferiors.
 509         (darwin_resume_inferior_it)
 510         (struct resume_inferior_threads_param)
 511         (darwin_resume_inferior_threads_it): Remove.
 512         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
 513
 514 2020-04-23  Tom de Vries  <tdevries@suse.de>
 515
 516         * blockframe.c (find_pc_partial_function): Use
 517         find_pc_sect_compunit_symtab rather than
 518         objfile->sf->qf->find_pc_sect_compunit_symtab.
 519
 520 2020-04-22  Tom de Vries  <tdevries@suse.de>
 521
 522         PR symtab/25764
 523         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
 524         in psymtabs.
 525
 526 2020-04-22  Tom de Vries  <tdevries@suse.de>
 527
 528         PR symtab/25801
 529         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
 530         symtabs.
 531
 532 2020-04-22  Tom de Vries  <tdevries@suse.de>
 533
 534         PR symtab/25700
 535         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
 536         CU if already created.
 537
 538 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 539
 540         * infrun.c (displaced_step_fixup): Switch to the event_thread
 541         before calling displaced_step_restore, not after.
 542
 543 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 544
 545         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
 546         its inferior is not recorded by us.
 547         (record_btrace_target_open): Replace call to
 548         all_non_exited_threads () with call to current_inferior
 549         ()->non_exited_threads ().
 550         (record_btrace_target::stop_recording): Likewise.
 551         (record_btrace_target::close): Likewise.
 552         (record_btrace_target::wait): Likewise.
 553         (record_btrace_target::record_stop_replaying): Likewise.
 554
 555 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 556
 557         * btrace.c (btrace_enable): Throw an error on double enables and
 558         when enabling recording fails.
 559         (btrace_disable): Throw an error if the thread is not recorded.
 560
 561 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 562
 563         * record-btrace.c (record_btrace_target::fetch_registers): Forward
 564         request if we do not have a thread_info.
 565
 566 2020-04-21  Tom de Vries  <tdevries@suse.de>
 567
 568         PR gdb/25471
 569         * thread.c
 570         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
 571         exception in get_frame_id.
 572
 573 2020-04-20  Tom Tromey  <tromey@adacore.com>
 574
 575         * python/python.c (struct gdbpy_event): Mark move constructor as
 576         noexcept.
 577         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
 578         constructor as noexcept.
 579         * completer.h (struct completion_result): Mark move constructor as
 580         noexcept.
 581         * completer.c (completion_result::completion_result): Use
 582         initialization style.  Don't call reset_match_list.
 583
 584 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
 585
 586         * MAINTAINERS (Write After Approval): Add myself.
 587
 588 2020-04-18  Tom Tromey  <tom@tromey.com>
 589
 590         * windows-tdep.c (init_w32_command_list)
 591         (w32_prefix_command_valid): Restore.
 592         (_initialize_windows_tdep): Call init_w32_command_list.
 593
 594 2020-04-18  Tom Tromey  <tom@tromey.com>
 595
 596         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
 597         * value.c (value_fn_field): Update.
 598         * valops.c (find_function_in_inferior)
 599         (value_allocate_space_in_inferior): Update.
 600         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 601         Update.
 602         * tui/tui-source.c (tui_source_window::set_contents): Update.
 603         * symtab.c (lookup_global_or_static_symbol)
 604         (find_function_start_sal_1, skip_prologue_sal)
 605         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
 606         * symmisc.c (dump_msymbols, dump_symtab_1)
 607         (maintenance_print_one_line_table): Update.
 608         * symfile.c (init_entry_point_info, section_is_mapped)
 609         (list_overlays_command, simple_read_overlay_table)
 610         (simple_overlay_update_1): Update.
 611         * stap-probe.c (handle_stap_probe): Update.
 612         * stabsread.c (dbx_init_float_type, define_symbol)
 613         (read_one_struct_field, read_enum_type, read_range_type): Update.
 614         * source.c (info_line_command): Update.
 615         * python/python.c (gdbpy_source_objfile_script)
 616         (gdbpy_execute_objfile_script): Update.
 617         * python/py-type.c (save_objfile_types): Update.
 618         * python/py-objfile.c (py_free_objfile): Update.
 619         * python/py-inferior.c (python_new_objfile): Update.
 620         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
 621         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
 622         (maintenance_check_psymtabs): Update.
 623         * printcmd.c (info_address_command): Update.
 624         * objfiles.h (struct objfile) <arch>: New method, from
 625         get_objfile_arch.
 626         (get_objfile_arch): Don't declare.
 627         * objfiles.c (get_objfile_arch): Remove.
 628         (filter_overlapping_sections): Update.
 629         * minsyms.c (msymbol_is_function): Update.
 630         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
 631         (output_nondebug_symbol): Update.
 632         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
 633         (mdebug_expand_psymtab): Update.
 634         * machoread.c (macho_add_oso_symfile): Update.
 635         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
 636         Update.
 637         * linux-fork.c (checkpoint_command): Update.
 638         * linespec.c (convert_linespec_to_sals): Update.
 639         * jit.c (finalize_symtab): Update.
 640         * infrun.c (insert_exception_resume_from_probe): Update.
 641         * ia64-tdep.c (ia64_find_unwind_table): Update.
 642         * hppa-tdep.c (internalize_unwinds): Update.
 643         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
 644         Update.
 645         * gcore.c (call_target_sbrk): Update.
 646         * elfread.c (record_minimal_symbol, elf_symtab_read)
 647         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
 648         (elf_gnu_ifunc_resolve_by_got): Update.
 649         * dwarf2/read.c (create_addrmap_from_index)
 650         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 651         (read_debug_names_from_section)
 652         (process_psymtab_comp_unit_reader, add_partial_symbol)
 653         (add_partial_subprogram, process_full_comp_unit)
 654         (read_file_scope, read_func_scope, read_lexical_block_scope)
 655         (read_call_site_scope, dwarf2_ranges_read)
 656         (dwarf2_record_block_ranges, dwarf2_add_field)
 657         (mark_common_block_symbol_computed, read_tag_pointer_type)
 658         (read_tag_string_type, dwarf2_init_float_type)
 659         (dwarf2_init_complex_target_type, read_base_type)
 660         (partial_die_info::read, partial_die_info::read)
 661         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
 662         (dwarf2_fetch_die_loc_sect_off): Update.
 663         * dwarf2/loc.c (dwarf2_find_location_expression)
 664         (class dwarf_evaluate_loc_desc, rw_pieced_value)
 665         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
 666         (dwarf2_loc_desc_get_symbol_read_needs)
 667         (locexpr_describe_location_piece, locexpr_describe_location_1)
 668         (loclist_describe_location): Update.
 669         * dwarf2/index-write.c (write_debug_names): Update.
 670         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
 671         * dtrace-probe.c (dtrace_process_dof): Update.
 672         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
 673         (process_one_symbol): Update.
 674         * ctfread.c (ctf_init_float_type, read_base_type): Update.
 675         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
 676         (coff_read_enum_type): Update.
 677         * cli/cli-cmds.c (edit_command, list_command): Update.
 678         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
 679         * breakpoint.c (create_overlay_event_breakpoint)
 680         (create_longjmp_master_breakpoint)
 681         (create_std_terminate_master_breakpoint)
 682         (create_exception_master_breakpoint, get_sal_arch): Update.
 683         * block.c (block_gdbarch): Update.
 684         * annotate.c (annotate_source_line): Update.
 685
 686 2020-04-17  Tom Tromey  <tromey@adacore.com>
 687
 688         * auto-load.c (show_auto_load_cmd): Remove.
 689         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
 690         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
 691         (maintenance_print_arc_command): Remove.
 692         * tui/tui-win.c (tui_command): Remove.
 693         (tui_get_cmd_list): Use add_basic_prefix_cmd.
 694         * tui/tui-layout.c (tui_layout_command): Remove.
 695         (_initialize_tui_layout): Use add_basic_prefix_cmd.
 696         * python/python.c (user_set_python, user_show_python): Remove.
 697         (_initialize_python): Use add_basic_prefix_cmd,
 698         add_show_prefix_cmd.
 699         * guile/guile.c (set_guile_command, show_guile_command): Remove.
 700         (install_gdb_commands): Use add_basic_prefix_cmd,
 701         add_show_prefix_cmd.
 702         (info_guile_command): Remove.
 703         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
 704         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
 705         add_show_prefix_cmd.
 706         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 707         Remove do_set and do_show parameters.
 708         * cli/cli-style.c (set_style, show_style): Remove.
 709         (_initialize_cli_style): Use add_basic_prefix_cmd,
 710         add_show_prefix_cmd.
 711         (cli_style_option::add_setshow_commands): Remove do_set and
 712         do_show parameters.
 713         (cli_style_option::add_setshow_commands): Use
 714         add_basic_prefix_cmd, add_show_prefix_cmd.
 715         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
 716         (set_style_name): Remove.
 717         * cli/cli-dump.c (dump_command, append_command): Remove.
 718         (srec_dump_command, ihex_dump_command, verilog_dump_command)
 719         (tekhex_dump_command, binary_dump_command)
 720         (binary_append_command): Remove.
 721         (_initialize_cli_dump): Use add_basic_prefix_cmd.
 722         * windows-tdep.c (w32_prefix_command_valid): Remove global.
 723         (init_w32_command_list): Remove; move into ...
 724         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
 725         * valprint.c (set_print, show_print, set_print_raw)
 726         (show_print_raw): Remove.
 727         (_initialize_valprint): Use add_basic_prefix_cmd,
 728         add_show_prefix_cmd.
 729         * typeprint.c (set_print_type, show_print_type): Remove.
 730         (_initialize_typeprint): Use add_basic_prefix_cmd,
 731         add_show_prefix_cmd.
 732         * record.c (set_record_command, show_record_command): Remove.
 733         (_initialize_record): Use add_basic_prefix_cmd,
 734         add_show_prefix_cmd.
 735         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
 736         add_show_prefix_cmd.
 737         (info_command, show_command, set_debug, show_debug): Remove.
 738         * top.h (set_history, show_history): Don't declare.
 739         * top.c (set_history, show_history): Remove.
 740         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
 741         (unset_tdesc_cmd): Remove.
 742         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
 743         add_show_prefix_cmd.
 744         * symtab.c (info_module_command): Remove.
 745         (_initialize_symtab): Use add_basic_prefix_cmd.
 746         * symfile.c (overlay_command): Remove.
 747         (_initialize_symfile): Use add_basic_prefix_cmd.
 748         * sparc64-tdep.c (info_adi_command): Remove.
 749         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
 750         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
 751         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
 752         add_show_prefix_cmd.
 753         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
 754         (_initialize_serial): Use add_basic_prefix_cmd,
 755         add_show_prefix_cmd.
 756         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
 757         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
 758         add_show_prefix_cmd.
 759         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
 760         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
 761         add_show_prefix_cmd.
 762         * riscv-tdep.c (show_riscv_command, set_riscv_command)
 763         (show_debug_riscv_command, set_debug_riscv_command): Remove.
 764         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
 765         add_show_prefix_cmd.
 766         * remote.c (remote_command, set_remote_cmd): Remove.
 767         (_initialize_remote): Use add_basic_prefix_cmd.
 768         * record-full.c (set_record_full_command)
 769         (show_record_full_command): Remove.
 770         (_initialize_record_full): Use add_basic_prefix_cmd,
 771         add_show_prefix_cmd.
 772         * record-btrace.c (cmd_set_record_btrace)
 773         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
 774         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
 775         (cmd_show_record_btrace_pt): Remove.
 776         (_initialize_record_btrace): Use add_basic_prefix_cmd,
 777         add_show_prefix_cmd.
 778         * ravenscar-thread.c (set_ravenscar_command)
 779         (show_ravenscar_command): Remove.
 780         (_initialize_ravenscar): Use add_basic_prefix_cmd,
 781         add_show_prefix_cmd.
 782         * mips-tdep.c (show_mips_command, set_mips_command)
 783         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
 784         add_show_prefix_cmd.
 785         * maint.c (maintenance_command, maintenance_info_command)
 786         (maintenance_check_command, maintenance_print_command)
 787         (maintenance_set_cmd, maintenance_show_cmd): Remove.
 788         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
 789         add_show_prefix_cmd.
 790         (show_per_command_cmd): Remove.
 791         * maint-test-settings.c (maintenance_set_test_settings_cmd):
 792         Remove.
 793         (maintenance_show_test_settings_cmd): Remove.
 794         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
 795         add_show_prefix_cmd.
 796         * maint-test-options.c (maintenance_test_options_command):
 797         Remove.
 798         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
 799         * macrocmd.c (macro_command): Remove
 800         (_initialize_macrocmd): Use add_basic_prefix_cmd.
 801         * language.c (set_check, show_check): Remove.
 802         (_initialize_language): Use add_basic_prefix_cmd,
 803         add_show_prefix_cmd.
 804         * infcmd.c (unset_command): Remove.
 805         (_initialize_infcmd): Use add_basic_prefix_cmd.
 806         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
 807         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
 808         add_show_prefix_cmd.
 809         * go32-nat.c (go32_info_dos_command): Remove.
 810         (_initialize_go32_nat): Use add_basic_prefix_cmd.
 811         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
 812         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
 813         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
 814         (_initialize_frame): Use add_basic_prefix_cmd,
 815         add_show_prefix_cmd.
 816         * dcache.c (set_dcache_command, show_dcache_command): Remove.
 817         (_initialize_dcache): Use add_basic_prefix_cmd,
 818         add_show_prefix_cmd.
 819         * cp-support.c (maint_cplus_command): Remove.
 820         (_initialize_cp_support): Use add_basic_prefix_cmd.
 821         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
 822         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
 823         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
 824         add_basic_prefix_cmd, add_show_prefix_cmd.
 825         * breakpoint.c (save_command): Remove.
 826         (_initialize_breakpoint): Use add_basic_prefix_cmd.
 827         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
 828         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
 829         add_show_prefix_cmd.
 830         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
 831         (set_ada_command, show_ada_command): Remove.
 832         (_initialize_ada_language): Use add_basic_prefix_cmd,
 833         add_show_prefix_cmd.
 834         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
 835
 836 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
 837
 838         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
 839         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
 840
 841 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 842
 843         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
 844         warning messages.
 845
 846 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 847
 848         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
 849         import table is not at beginning of .idata section.
 850
 851 2020-04-16  Pedro Alves  <palves@redhat.com>
 852
 853         * inferior.c (delete_inferior): Use delete operator directly
 854         instead of delete_program_space.
 855         * progspace.c (add_program_space): New, factored out from
 856         program_space::program_space.
 857         (remove_program_space): New, factored out from
 858         delete_program_space.
 859         (program_space::program_space): Remove intro comment.  Rewrite.
 860         (program_space::~program_space): Remove intro comment.  Call
 861         remove_program_space.
 862         (delete_program_space): Delete.
 863         * progspace.h (program_space::program_space): Make explicit.  Move
 864         intro comment here, adjusted.
 865         (program_space::~program_space): Move intro comment here,
 866         adjusted.
 867         (delete_program_space): Remove.
 868
 869 2020-04-16  Tom Tromey  <tromey@adacore.com>
 870
 871         * windows-nat.c (windows_nat::handle_access_violation): New
 872         function.
 873         * nat/windows-nat.h (handle_access_violation): Declare.
 874         * nat/windows-nat.c (handle_exception): Move Cygwin code to
 875         windows-nat.c.  Call handle_access_violation.
 876
 877 2020-04-16  Tom de Vries  <tdevries@suse.de>
 878
 879         PR symtab/25791
 880         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
 881         CUs without psymtab.
 882
 883 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
 884
 885         * python/python.c (do_start_initialization): Don't call
 886         PyEval_InitThreads for Python 3.9 and beyond.
 887
 888 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
 889
 890         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
 891         thread functions.
 892         (obsd_nat_target::wait): Likewise.
 893
 894 2020-04-15  Tom Tromey  <tromey@adacore.com>
 895
 896         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
 897         (DEBUG_EXCEPT): Use debug_printf.
 898
 899 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 900
 901         * completer.c (class completion_tracker::completion_hash_entry)
 902         <hash_name>: New member function.
 903         (completion_tracker::discard_completions): New callback to hash a
 904         completion_hash_entry, pass this to htab_create_alloc.
 905
 906 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
 907
 908         * windows-nat.c (windows_make_so): Warn rather than stopping with
 909         an error if realpath() fails.
 910
 911 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
 912
 913         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
 914         (nbsd_nat_target::info_proc): Add do_status.
 915
 916 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
 917             Tom de Vries  <tdevries@suse.de>
 918
 919         PR symtab/25718
 920         * psympriv.h (struct partial_symtab::read_symtab)
 921         (struct partial_symtab::expand_psymtab)
 922         (struct partial_symtab::read_dependencies): Update comments.
 923         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
 924         read_symtab for includer.
 925         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
 926         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
 927         (struct dwarf2_include_psymtab::m_readin): Remove.
 928         (struct dwarf2_include_psymtab::includer): New member function.
 929         (dwarf2_psymtab::expand_psymtab): Assert !readin.
 930
 931 2020-04-14  Tom de Vries  <tdevries@suse.de>
 932
 933         PR symtab/25720
 934         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
 935         with NULL symbol_matcher and lookup_name.
 936         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
 937         and lookup_name.
 938         * dwarf2/read.c (dw2_expand_symtabs_matching)
 939         (dw2_debug_names_expand_symtabs_matching): Same.
 940         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
 941         Make lookup_name a pointer.  Update comment.
 942         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
 943         lookup_name being a pointer.
 944         * symfile.c (expand_symtabs_matching): Same.
 945         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
 946         * linespec.c (iterate_over_all_matching_symtabs): Same.
 947
 948 2020-04-13  Tom Tromey  <tom@tromey.com>
 949
 950         * run-on-main-thread.c: Update include.
 951         * unittests/main-thread-selftests.c: Update include.
 952         * tui/tui-win.c: Update include.
 953         * tui/tui-io.c: Update include.
 954         * tui/tui-interp.c: Update include.
 955         * tui/tui-hooks.c: Update include.
 956         * top.h: Update include.
 957         * top.c: Update include.
 958         * ser-base.c: Update include.
 959         * remote.c: Update include.
 960         * remote-notif.c: Update include.
 961         * remote-fileio.c: Update include.
 962         * record-full.c: Update include.
 963         * record-btrace.c: Update include.
 964         * python/python.c: Update include.
 965         * posix-hdep.c: Update include.
 966         * mingw-hdep.c: Update include.
 967         * mi/mi-main.c: Update include.
 968         * mi/mi-interp.c: Update include.
 969         * main.c: Update include.
 970         * linux-nat.c: Update include.
 971         * interps.c: Update include.
 972         * infrun.c: Update include.
 973         * inf-loop.c: Update include.
 974         * event-top.c: Update include.
 975         * event-loop.c: Move to ../gdbsupport/.
 976         * event-loop.h: Move to ../gdbsupport/.
 977         * async-event.h: Update include.
 978         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
 979
 980 2020-04-13  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui-win.c: Include async-event.h.
 983         * remote.c: Include async-event.h.
 984         * remote-notif.c: Include async-event.h.
 985         * record-full.c: Include async-event.h.
 986         * record-btrace.c: Include async-event.h.
 987         * infrun.c: Include async-event.h.
 988         * event-top.c: Include async-event.h.
 989         * event-loop.h: Move some declarations to async-event.h.
 990         * event-loop.c: Don't include ser-event.h or top.h.  Move some
 991         code to async-event.c.
 992         * async-event.h: New file.
 993         * async-event.c: New file.
 994         * Makefile.in (COMMON_SFILES): Add async-event.c.
 995         (HFILES_NO_SRCDIR): Add async-event.h.
 996
 997 2020-04-13  Tom Tromey  <tom@tromey.com>
 998
 999         * utils.c (flush_streams): New function.
1000         * event-loop.c (gdb_wait_for_event): Call flush_streams.
1001
1002 2020-04-13  Tom Tromey  <tom@tromey.com>
1003
1004         * event-loop.c (handle_file_event): Use warning, not
1005         printf_unfiltered.
1006
1007 2020-04-13  Tom Tromey  <tom@tromey.com>
1008
1009         * event-loop.c: Include <chrono>.
1010
1011 2020-04-13  Tom Tromey  <tom@tromey.com>
1012
1013         * gdb_select.h: Move to ../gdbsupport/.
1014         * event-loop.c: Update include path.
1015         * top.c: Update include path.
1016         * ser-base.c: Update include path.
1017         * ui-file.c: Update include path.
1018         * ser-tcp.c: Update include path.
1019         * guile/scm-ports.c: Update include path.
1020         * posix-hdep.c: Update include path.
1021         * ser-unix.c: Update include path.
1022         * gdb_usleep.c: Update include path.
1023         * mingw-hdep.c: Update include path.
1024         * inflow.c: Update include path.
1025         * infrun.c: Update include path.
1026         * event-top.c: Update include path.
1027
1028 2020-04-13  Tom Tromey  <tom@tromey.com>
1029
1030         * configure: Rebuild.
1031         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1032
1033 2020-04-13  Tom Tromey  <tom@tromey.com>
1034
1035         * event-loop.h (start_event_loop): Don't declare.
1036         * event-loop.c (start_event_loop): Move...
1037         * main.c (start_event_loop): ...here.  Now static.
1038
1039 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1040
1041         * MAINTAINERS: Update my email address.
1042
1043 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1044
1045         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1046         IP_ALL.
1047
1048 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1049
1050         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1051         (nbsd_nat_target::info_proc): Add do_cmdline.
1052
1053 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1054
1055         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1056         (nbsd_nat_target::info_proc): Add do_cwd.
1057
1058 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1059
1060         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
1061
1062 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
1063
1064         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
1065         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
1066         (nbsd_nat_target::info_proc): New functions.
1067         * nbsd-nat.c (kinfo_get_vmmap): New function.
1068         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
1069         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
1070         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
1071         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
1072         functions.
1073         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
1074         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
1075         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
1076         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
1077         (KINFO_VME_FLAG_GROWS_DOWN): New.
1078
1079 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
1080
1081         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
1082         bit shift.
1083
1084 2020-04-10  Tom Tromey  <tromey@adacore.com>
1085
1086         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
1087
1088 2020-04-10  Tom Tromey  <tromey@adacore.com>
1089
1090         * symtab.c (get_symbol_address, get_msymbol_address): Skip
1091         separate debug files.
1092
1093 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
1094
1095         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1096         Move to...
1097         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1098         ... here.
1099         * windows-nat.c (windows_nat_target::get_windows_debug_event):
1100         Check for STATUS_WX86_BREAKPOINT.
1101         (windows_nat_target::wait): Same.
1102
1103 2020-04-10  Tom de Vries  <tdevries@suse.de>
1104
1105         PR cli/25808
1106         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
1107
1108 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1109
1110         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
1111         (Write After Approval): Remove Tom de Vries.
1112
1113 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1114
1115         revert partially:
1116         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1117
1118         * buildsym.c (record_line): Fix undefined behavior and preserve
1119         lines at eof.
1120
1121 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
1122
1123         * auxv.h (svr4_auxv_parse): New.
1124         * auxv.c (default_auxv_parse): Split into default_auxv_parse
1125         and generic_auxv_parse.
1126         (svr4_auxv_parse): Add.
1127         * obsd-tdep.c: Include "auxv.h".
1128         (obsd_auxv_parse): Remove.
1129         (obsd_init_abi): Remove comment.
1130         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
1131         from `obsd_auxv_parse' to `svr4_auxv_parse'.
1132         * nbsd-tdep.c: Include "auxv.h".
1133         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
1134
1135 2020-04-08  Tom Tromey  <tromey@adacore.com>
1136
1137         * nat/windows-nat.h (last_wait_event): Don't declare.
1138         (wait_for_debug_event): Update comment.
1139         * nat/windows-nat.c (last_wait_event): Now static.
1140
1141 2020-04-08  Tom Tromey  <tromey@adacore.com>
1142
1143         * windows-nat.c (wait_for_debug_event): Move to
1144         nat/windows-nat.c.
1145         * nat/windows-nat.h (wait_for_debug_event): Declare.
1146         * nat/windows-nat.c (wait_for_debug_event): Move from
1147         windows-nat.c.  No longer static.
1148
1149 2020-04-08  Tom Tromey  <tromey@adacore.com>
1150
1151         * windows-nat.c (get_windows_debug_event): Use
1152         fetch_pending_stop.
1153         * nat/windows-nat.h (fetch_pending_stop): Declare.
1154         * nat/windows-nat.c (fetch_pending_stop): New function.
1155
1156 2020-04-08  Tom Tromey  <tromey@adacore.com>
1157
1158         * windows-nat.c (windows_continue): Use matching_pending_stop and
1159         continue_last_debug_event.
1160         * nat/windows-nat.h (matching_pending_stop)
1161         (continue_last_debug_event): Declare.
1162         * nat/windows-nat.c (DEBUG_EVENTS): New define.
1163         (matching_pending_stop, continue_last_debug_event): New
1164         functions.
1165
1166 2020-04-08  Tom Tromey  <tromey@adacore.com>
1167
1168         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
1169         (handle_exception_result): Move to nat/windows-nat.h.
1170         (DEBUG_EXCEPTION_SIMPLE): Remove.
1171         (windows_nat::handle_ms_vc_exception): New function.
1172         (handle_exception): Move to nat/windows-nat.c.
1173         (get_windows_debug_event): Update.
1174         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
1175         nat/windows-nat.c.
1176         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
1177         (handle_exception_result): Move from windows-nat.c.
1178         (handle_exception): Declare.
1179         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
1180         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
1181         windows-nat.c.
1182
1183 2020-04-08  Tom Tromey  <tromey@adacore.com>
1184
1185         * windows-nat.c (exception_count, event_count): Remove.
1186         (handle_exception, get_windows_debug_event)
1187         (do_initial_windows_stuff): Update.
1188
1189 2020-04-08  Tom Tromey  <tromey@adacore.com>
1190
1191         * windows-nat.c (windows_nat::handle_load_dll)
1192         (windows_nat::handle_unload_dll): Rename.  No longer static.
1193         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1194         Declare.
1195
1196 2020-04-08  Tom Tromey  <tromey@adacore.com>
1197
1198         * complaints.h (stop_whining): Declare at top-level.
1199         (complaint): Don't declare stop_whining.
1200
1201 2020-04-08  Tom Tromey  <tromey@adacore.com>
1202
1203         * windows-nat.c (windows_nat::handle_output_debug_string):
1204         Rename.  No longer static.
1205         * nat/windows-nat.h (handle_output_debug_string): Declare.
1206
1207 2020-04-08  Tom Tromey  <tromey@adacore.com>
1208
1209         * windows-nat.c (current_process_handle, current_process_id)
1210         (main_thread_id, last_sig, current_event, last_wait_event)
1211         (current_windows_thread, desired_stop_thread_id, pending_stops)
1212         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1213         (display_selectors, fake_create_process)
1214         (get_windows_debug_event): Update.
1215         * nat/windows-nat.h (current_process_handle, current_process_id)
1216         (main_thread_id, last_sig, current_event, last_wait_event)
1217         (current_windows_thread, desired_stop_thread_id, pending_stops)
1218         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1219         * nat/windows-nat.c (current_process_handle, current_process_id)
1220         (main_thread_id, last_sig, current_event, last_wait_event)
1221         (current_windows_thread, desired_stop_thread_id, pending_stops)
1222         (siginfo_er): New globals.  Move from windows-nat.c.
1223
1224 2020-04-08  Tom Tromey  <tromey@adacore.com>
1225
1226         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1227         (handle_load_dll): Update.
1228         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1229
1230 2020-04-08  Tom Tromey  <tromey@adacore.com>
1231
1232         * windows-nat.c (enum thread_disposition_type): Move to
1233         nat/windows-nat.h.
1234         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1235         static.
1236         (windows_add_thread, windows_nat_target::fetch_registers)
1237         (windows_nat_target::store_registers, handle_exception)
1238         (windows_nat_target::resume, get_windows_debug_event)
1239         (windows_nat_target::get_tib_address)
1240         (windows_nat_target::thread_name)
1241         (windows_nat_target::thread_alive): Update.
1242         * nat/windows-nat.h (enum thread_disposition_type): Move from
1243         windows-nat.c.
1244         (thread_rec): Declare.
1245
1246 2020-04-08  Tom Tromey  <tromey@adacore.com>
1247
1248         * windows-nat.c: Add "using namespace".
1249         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1250         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1251
1252 2020-04-08  Tom Tromey  <tromey@adacore.com>
1253
1254         * nat/windows-nat.h (struct windows_thread_info): Declare
1255         destructor.
1256         * nat/windows-nat.c (~windows_thread_info): New.
1257
1258 2020-04-08  Tom Tromey  <tromey@adacore.com>
1259
1260         PR gdb/22992
1261         * windows-nat.c (current_event): Update comment.
1262         (last_wait_event, desired_stop_thread_id): New globals.
1263         (struct pending_stop): New.
1264         (pending_stops): New global.
1265         (windows_nat_target) <stopped_by_sw_breakpoint>
1266         <supports_stopped_by_sw_breakpoint>: New methods.
1267         (windows_fetch_one_register): Add assertions.  Adjust PC.
1268         (windows_continue): Handle pending stops.  Suspend other threads
1269         when stepping.  Use last_wait_event
1270         (wait_for_debug_event): New function.
1271         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1272         pending stops.  Queue spurious stops.
1273         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1274         (windows_nat_target::kill): Use wait_for_debug_event.
1275         * nat/windows-nat.h (struct windows_thread_info)
1276         <stopped_at_software_breakpoint>: New field.
1277         * nat/windows-nat.c (windows_thread_info::resume): Clear
1278         stopped_at_software_breakpoint.
1279
1280 2020-04-08  Tom Tromey  <tromey@adacore.com>
1281
1282         * windows-nat.c (enum thread_disposition_type): New.
1283         (thread_rec): Replace "get_context" parameter with "disposition";
1284         change type.
1285         (windows_add_thread, windows_nat_target::fetch_registers)
1286         (windows_nat_target::store_registers, handle_exception)
1287         (windows_nat_target::resume, get_windows_debug_event)
1288         (windows_nat_target::get_tib_address)
1289         (windows_nat_target::thread_name)
1290         (windows_nat_target::thread_alive): Update.
1291
1292 2020-04-08  Tom Tromey  <tromey@adacore.com>
1293
1294         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1295         (windows_continue): Use windows_continue::resume.
1296         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1297         resume>: Declare new methods.
1298         * nat/windows-nat.c: New file.
1299         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1300
1301 2020-04-08  Tom Tromey  <tromey@adacore.com>
1302
1303         * windows-nat.c (windows_add_thread, windows_delete_thread)
1304         (windows_nat_target::fetch_registers)
1305         (windows_nat_target::store_registers, fake_create_process)
1306         (windows_nat_target::resume, windows_nat_target::resume)
1307         (get_windows_debug_event, windows_nat_target::wait)
1308         (windows_nat_target::pid_to_str)
1309         (windows_nat_target::get_tib_address)
1310         (windows_nat_target::get_ada_task_ptid)
1311         (windows_nat_target::thread_name)
1312         (windows_nat_target::thread_alive): Use lwp, not tid.
1313
1314 2020-04-08  Tom Tromey  <tromey@adacore.com>
1315
1316         * windows-nat.c (handle_exception)
1317         (windows_nat_target::thread_name): Update.
1318         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1319         <name>: Now unique_xmalloc_ptr.
1320
1321 2020-04-08  Tom Tromey  <tromey@adacore.com>
1322
1323         * windows-nat.c (thread_rec)
1324         (windows_nat_target::fetch_registers): Update.
1325         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1326         Update comment.
1327         <debug_registers_changed, reload_context>: Now bool.
1328
1329 2020-04-08  Tom Tromey  <tromey@adacore.com>
1330
1331         * windows-nat.c (windows_add_thread): Use new.
1332         (windows_init_thread_list, windows_delete_thread): Use delete.
1333         (get_windows_debug_event): Update.
1334         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1335         destructor, and initializers.
1336
1337 2020-04-08  Tom Tromey  <tromey@adacore.com>
1338
1339         * windows-nat.c (struct windows_thread_info): Remove.
1340         * nat/windows-nat.h: New file.
1341
1342 2020-04-08  Tom Tromey  <tromey@adacore.com>
1343
1344         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1345         (thread_rec, windows_add_thread, windows_delete_thread)
1346         (windows_continue): Update.
1347
1348 2020-04-08  Tom Tromey  <tromey@adacore.com>
1349
1350         * windows-nat.c (struct windows_thread_info): Remove typedef.
1351         (thread_head): Remove.
1352         (thread_list): New global.
1353         (thread_rec, windows_add_thread, windows_init_thread_list)
1354         (windows_delete_thread, windows_continue): Update.
1355
1356 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1357
1358         * windows-tdep.h (windows_init_abi): Add comment.
1359         (cygwin_init_abi): New declaration.
1360         * windows-tdep.c: Split signal enumeration in two, one for
1361         Windows and one for Cygwin.
1362         (windows_gdb_signal_to_target): Only deal with signal of the
1363         Windows OS ABI.
1364         (cygwin_gdb_signal_to_target): New function.
1365         (windows_init_abi): Rename to windows_init_abi_common, don't set
1366         gdb_signal_to_target gdbarch method.  Add new new function with
1367         this name.
1368         (cygwin_init_abi): New function.
1369         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1370         comment.  Don't call windows_init_abi.
1371         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1372         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1373         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1374         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1375         a new function of this name.
1376         (i386_cygwin_init_abi): New function.
1377         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1378         OS ABI Cygwin.
1379
1380 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1381
1382         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1383         parameter.c.
1384         (dwarf2_read_gdb_index): Update.
1385
1386 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1387
1388         * nbsd-tdep.c: Include "objfiles.h".
1389         (nbsd_skip_solib_resolver): New.
1390         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1391
1392 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1393
1394         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1395         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1396         with DW_LLE_base_addressx are being emitted in DWARFv5.
1397         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1398         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1399         unsigned integer.
1400
1401 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1402
1403         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1404         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1405         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1406         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1407         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1408         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1409         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1410
1411
1412 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1413
1414         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1415         (read_loclist_index): New function definition.
1416         (lookup_loclist_base): New function definition.
1417         (read_loclist_header): New function definition.
1418         (dwarf2_cu): Add loclist_base and loclist_header field.
1419         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1420         (read_full_die_1): Read the value of DW_AT_loclists_base.
1421         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1422         (read_attribute_value): Handle DW_FORM_loclistx.
1423         (skip_one_die): Handle DW_FORM_loclistx.
1424         (loclist_header): New structure declaration.
1425         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1426
1427 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1428
1429         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1430         constructor.  Remove `addr` parameter from other constructor and
1431         add `per_cu` parameter.
1432         * dwarf2/read.c (create_partial_symtab): Update.
1433
1434 2020-04-07  Tom de Vries  <tdevries@suse.de>
1435
1436         PR symtab/25796
1437         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1438         (partial_die_info::fixup): Inherit has_const_value.
1439
1440 2020-04-07  Tom de Vries  <tdevries@suse.de>
1441
1442         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1443         symbols without address.
1444
1445 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1446
1447         * nbsd-nat.h (struct thread_info): Add forward declaration.
1448         (nbsd_nat_target::thread_alive): Add.
1449         (nbsd_nat_target::thread_name): Likewise.
1450         (nbsd_nat_target::update_thread_list): Likewise.
1451         (update_thread_list::post_attach): Likewise.
1452         (post_attach::pid_to_str): Likewise.
1453         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1454         (nbsd_thread_lister): Add.
1455         (nbsd_nat_target::thread_alive): Likewise.
1456         (nbsd_nat_target::thread_name): Likewise.
1457         (nbsd_add_threads): Likewise.
1458         (update_thread_list::post_attach): Likewise.
1459         (nbsd_nat_target::update_thread_list): Likewise.
1460         (post_attach::pid_to_str): Likewise.
1461
1462 2020-04-06  Tom Tromey  <tromey@adacore.com>
1463
1464         * ada-valprint.c (print_variant_part): Extract the variant field.
1465         (print_field_values): Use the field as the outer value when
1466         recursing.
1467
1468 2020-04-06  Tom Tromey  <tromey@adacore.com>
1469
1470         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
1471         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
1472         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
1473         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
1474         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
1475
1476 2020-04-06  Tom Tromey  <tromey@adacore.com>
1477
1478         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
1479         TYPE_CODE_ERROR.
1480
1481 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1482
1483         * nbsd-tdep.c: Include "gdbarch.h".
1484         Define enum with NetBSD signal numbers.
1485         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
1486         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
1487         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1488         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
1489         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
1490         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
1491         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
1492         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
1493         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
1494         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
1495         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
1496         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
1497
1498 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
1499
1500         PR gdb/25325
1501         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
1502
1503 2020-04-03  Tom Tromey  <tromey@adacore.com>
1504
1505         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
1506         Read constant block.
1507
1508 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1509
1510         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
1511         (gdb_bfd_get_full_section_contents): New declaration.
1512         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
1513         * windows-tdep.c (is_linked_with_cygwin_dll): Use
1514         gdb_bfd_get_full_section_contents.
1515
1516 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1517
1518         * exec.c (build_section_table): Replace internal_error with
1519         gdb_assert.
1520         (section_table_xfer_memory_partial): Likewise.
1521         * mdebugread.c (parse_partial_symbols): Likewise.
1522         * psymtab.c (lookup_partial_symbol): Likewise.
1523         * utils.c (wrap_here): Likewise.
1524
1525 2020-04-02  Tom Tromey  <tromey@adacore.com>
1526
1527         * f-lang.c (build_fortran_types): Use arch_type to initialize
1528         builtin_complex_s32 in the TYPE_CODE_ERROR case.
1529
1530 2020-04-02  Tom Tromey  <tromey@adacore.com>
1531
1532         * dwarf2/read.c (partial_die_info::read): Do not create a vector
1533         of attributes.
1534
1535 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1536             Bernd Edlinger <bernd.edlinger@hotmail.de>
1537             Tom Tromey  <tromey@adacore.com>
1538
1539         * buildsym.c (buildsym_compunit::record_line): Remove
1540         deduplication code.
1541
1542 2020-04-02  Tom de Vries  <tdevries@suse.de>
1543
1544         PR ada/24671
1545         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1546
1547 2020-04-02  Tom de Vries  <tdevries@suse.de>
1548
1549         * dwarf2/read.c (dwarf2_gdb_index_functions,
1550         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1551         NULL.
1552         * psymtab.c (psym_lookup_global_symbol_language): New function.
1553         (psym_functions): Init psym_lookup_global_symbol_language with
1554         psym_lookup_global_symbol_language.
1555         * symfile-debug.c (debug_sym_quick_functions): Init
1556         lookup_global_symbol_language with NULL.
1557         * symfile.c (set_initial_language): Remove fixme comment.
1558         * symfile.h (struct quick_symbol_functions): Add
1559         lookup_global_symbol_language.
1560         * symtab.c (find_quick_global_symbol_language): New function.
1561         (find_main_name): Use find_quick_global_symbol_language.
1562
1563 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1564
1565         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1566
1567 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1568
1569         * buildsym.c (record_line): Fix undefined behavior and preserve
1570         lines at eof.
1571
1572 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1573
1574         * buildsym.c (record_line): Fix the resizing condition.
1575
1576 2020-04-01  Tom Tromey  <tom@tromey.com>
1577
1578         * value.h (value_literal_complex): Add comment.
1579         * valops.c (value_literal_complex): Refer to value.h.
1580
1581 2020-04-01  Tom Tromey  <tom@tromey.com>
1582
1583         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1584         (scalar_type): New rule, from typebase.
1585         (typebase): Use scalar_type.  Recognize complex types.
1586         (field_name): Handle FLOAT_KEYWORD.
1587         (ident_tokens): Add _Complex and __complex__.
1588
1589 2020-04-01  Tom Tromey  <tom@tromey.com>
1590
1591         PR exp/25299:
1592         * valarith.c (promotion_type, complex_binop): New functions.
1593         (scalar_binop): Handle complex numbers.  Use promotion_type.
1594         (value_pos, value_neg, value_complement): Handle complex numbers.
1595
1596 2020-04-01  Tom Tromey  <tom@tromey.com>
1597
1598         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1599         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1600         (parse_number): Handle complex numbers.
1601
1602 2020-04-01  Tom Tromey  <tom@tromey.com>
1603
1604         * c-valprint.c (c_decorations): Change complex suffix to "i".
1605
1606 2020-04-01  Tom Tromey  <tom@tromey.com>
1607
1608         * valprint.c (generic_value_print_complex): Use accessors.
1609         * value.h (value_real_part, value_imaginary_part): Declare.
1610         * valops.c (value_real_part, value_imaginary_part): New
1611         functions.
1612         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
1613
1614 2020-04-01  Tom Tromey  <tom@tromey.com>
1615
1616         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
1617         (read_range_type): Update.
1618         * mdebugread.c (basic_type): Update.
1619         * go-lang.c (build_go_types): Use init_complex_type.
1620         * gdbtypes.h (struct main_type) <complex_type>: New member.
1621         (init_complex_type): Update.
1622         (arch_complex_type): Don't declare.
1623         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
1624         Make name if none given.  Use alloc_type_copy.  Look for cached
1625         complex type.
1626         (arch_complex_type): Remove.
1627         (gdbtypes_post_init): Use init_complex_type.
1628         * f-lang.c (build_fortran_types): Use init_complex_type.
1629         * dwarf2/read.c (read_base_type): Update.
1630         * d-lang.c (build_d_types): Use init_complex_type.
1631         * ctfread.c (read_base_type): Update.
1632
1633 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1634
1635         * infrun.c (stop_all_threads): Update assertion, plus when
1636         stopping threads, take into account that we might be trying
1637         to stop an all-stop target.
1638         (stop_waiting): Call 'stop_all_threads' if there exists a
1639         non-stop target.
1640
1641 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1642
1643         * target.h (exists_non_stop_target): New function declaration.
1644         * target.c (exists_non_stop_target): New function.
1645
1646 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
1647
1648         PR gdb/24789
1649         * eval.c (is_integral_or_integral_reference): New function.
1650         (evaluate_subexp_standard): Allow integer references in
1651         pointer arithmetic.
1652
1653 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1654
1655         * remote.c (remote_target::remote_parse_stop_reply): Remove the
1656         check for no ptid in the stop reply when the target is non-stop.
1657
1658 2020-04-01  Tom Tromey  <tromey@adacore.com>
1659
1660         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
1661         "name" parameter to rvalue reference.  Initialize m_name_holder.
1662         <lookup_name_info>: New overloads.
1663         <name>: Return gdb::string_view.
1664         <c_str>: New method.
1665         <make_ignore_params>: Update.
1666         <search_name_hash>: Update.
1667         <language_lookup_name>: Return const char *.
1668         <m_name>: Change type.
1669         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
1670         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
1671         (lookup_name_info::match_any): Update.
1672         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
1673         Update.
1674         * minsyms.c (linkage_name_str): Update.
1675         * language.c (default_symbol_name_matcher): Update.
1676         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
1677         Update.
1678         * ada-lang.c (ada_fold_name): Change parameter to string_view.
1679         (ada_lookup_name_info::ada_lookup_name_info): Update.
1680         (literal_symbol_name_matcher): Update.
1681
1682 2020-04-01  Tom Tromey  <tromey@adacore.com>
1683
1684         * psymtab.c (psymtab_search_name): Remove function.
1685         (psym_lookup_symbol): Create search name and lookup name here.
1686         (lookup_partial_symbol): Remove "name" parameter; add
1687         lookup_name.
1688         (psym_expand_symtabs_for_function): Update.
1689
1690 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
1691
1692         PR tui/25597:
1693         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
1694
1695 2020-03-31  Tom Tromey  <tromey@adacore.com>
1696
1697         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
1698         memcpy.
1699
1700 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
1701
1702         * features/riscv/32bit-csr.xml: Regenerated.
1703         * features/riscv/64bit-csr.xml: Regenerated.
1704
1705 2020-03-30  Tom Tromey  <tromey@adacore.com>
1706
1707         * ada-valprint.c (print_variant_part): Update.
1708         * ada-lang.h (ada_which_variant_applies): Update.
1709         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
1710         outer_valaddr parameters; replace with "outer" value parameter.
1711         (to_fixed_variant_branch_type): Update.
1712
1713 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1714
1715         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
1716         <list>.  Remove inclusion of observable.h.
1717         (PPC_DEBUG_CURRENT_VERSION): Move up define.
1718         (struct arch_lwp_info): New struct.
1719         (class ppc_linux_dreg_interface): New class.
1720         (struct ppc_linux_process_info): New struct.
1721         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
1722         <low_new_clone, low_forget_process, low_prepare_to_resume>
1723         <copy_thread_dreg_state, mark_thread_stale>
1724         <mark_debug_registers_changed, register_hw_breakpoint>
1725         <clear_hw_breakpoint, register_wp, clear_wp>
1726         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
1727         <num_memory_accesses, get_trigger_type>
1728         <create_watchpoint_request, hwdebug_point_cmp>
1729         <init_arch_lwp_info, get_arch_lwp_info>
1730         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
1731         methods.
1732         <struct ptid_hash>: New inner struct.
1733         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
1734         members.
1735         (saved_dabr_value, hwdebug_info, max_slots_number)
1736         (struct hw_break_tuple, struct thread_points, ppc_threads)
1737         (have_ptrace_hwdebug_interface)
1738         (hwdebug_find_thread_points_by_tid)
1739         (hwdebug_insert_point, hwdebug_remove_point): Remove.
1740         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
1741         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
1742         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
1743         use m_dreg_interface.
1744         (hwdebug_point_cmp): Change to...
1745         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
1746         reference arguments instead of pointers.
1747         (ppc_linux_nat_target::ranged_break_num_registers): Use
1748         m_dreg_interface.
1749         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
1750         m_dreg_interface.  Call register_hw_breakpoint.
1751         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
1752         m_dreg_interface.  Call clear_hw_breakpoint.
1753         (get_trigger_type): Change to...
1754         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
1755         comment.
1756         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
1757         use m_dreg_interface.  Call register_hw_breakpoint.
1758         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
1759         use m_dreg_interface.  Call clear_hw_breakpoint.
1760         (can_use_watchpoint_cond_accel): Change to...
1761         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
1762         method.  Update comment, use m_dreg_interface and
1763         m_process_info.
1764         (calculate_dvc): Change to...
1765         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
1766         m_dreg_interface.
1767         (num_memory_accesses): Change to...
1768         (ppc_linux_nat_target::num_memory_accesses): ...this method.
1769         (check_condition): Change to...
1770         (ppc_linux_nat_target::check_condition): ...this method.
1771         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
1772         comment, use m_dreg_interface.
1773         (create_watchpoint_request): Change to...
1774         (ppc_linux_nat_target::create_watchpoint_request): ...this
1775         method.  Use m_dreg_interface.
1776         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
1777         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
1778         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
1779         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
1780         (ppc_linux_nat_target::low_forget_process)
1781         (ppc_linux_nat_target::low_new_fork)
1782         (ppc_linux_nat_target::low_new_clone)
1783         (ppc_linux_nat_target::low_delete_thread)
1784         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
1785         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
1786         only call mark_thread_stale.
1787         (ppc_linux_thread_exit): Remove.
1788         (ppc_linux_nat_target::stopped_data_address): Change to...
1789         (ppc_linux_nat_target::low_stopped_data_address): This. Add
1790         comment, use m_dreg_interface and m_thread_hw_breakpoints.
1791         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
1792         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
1793         comment.  Call low_stopped_data_address.
1794         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
1795         m_dreg_interface.
1796         (ppc_linux_nat_target::masked_watch_num_registers): Use
1797         m_dreg_interface.
1798         (ppc_linux_nat_target::copy_thread_dreg_state)
1799         (ppc_linux_nat_target::mark_thread_stale)
1800         (ppc_linux_nat_target::mark_debug_registers_changed)
1801         (ppc_linux_nat_target::register_hw_breakpoint)
1802         (ppc_linux_nat_target::clear_hw_breakpoint)
1803         (ppc_linux_nat_target::register_wp)
1804         (ppc_linux_nat_target::clear_wp)
1805         (ppc_linux_nat_target::init_arch_lwp_info)
1806         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
1807         (_initialize_ppc_linux_nat): Remove observer callback.
1808
1809 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1810
1811         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
1812         (ppc_linux_nat_target::auxv_parse)
1813         (ppc_linux_nat_target::read_description)
1814         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
1815         Move up.
1816
1817 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1818
1819         * linux-nat.h (low_new_clone): New method.
1820         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
1821
1822 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1823
1824         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
1825         (dbx_expand_psymtab): ... this.
1826         (start_psymtab): Update.
1827         * mdebugread.c (psymtab_to_symtab_1): Rename to...
1828         (mdebug_expand_psymtab): ... this.
1829         (parse_partial_symbols): Update.
1830         (new_psymtab): Update.
1831         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
1832         (xcoff_expand_psymtab): ... this.
1833         (xcoff_start_psymtab): Update.
1834
1835 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1836
1837         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
1838         <expand_dependencies>: ... this.
1839         * psymtab.c (partial_symtab::read_dependencies): Rename to...
1840         (partial_symtab::expand_dependencies): ... this.
1841         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
1842         Update.
1843         (dwarf2_psymtab::expand_psymtab): Update.
1844         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1845         * mdebugread.c (psymtab_to_symtab_1): Update.
1846         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1847
1848 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1849
1850         * psympriv.h (discard_psymtab): Remove.
1851         * dbxread.c (dbx_end_psymtab): Update.
1852         * xcoffread.c (xcoff_end_psymtab): Update.
1853
1854 2020-03-28  Tom Tromey  <tom@tromey.com>
1855
1856         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
1857         comment.
1858
1859 2020-03-28  Tom Tromey  <tom@tromey.com>
1860
1861         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
1862
1863 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
1864
1865         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
1866
1867 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
1868
1869         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
1870
1871 2020-03-26  Tom Tromey  <tom@tromey.com>
1872
1873         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
1874         (mark_common_block_symbol_computed, read_tag_string_type)
1875         (attr_to_dynamic_prop, read_subrange_type): Update.
1876         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
1877         to be methods on struct attribute.
1878         (skip_one_die, process_imported_unit_die, read_namespace_alias)
1879         (read_call_site_scope, partial_die_info::read)
1880         (partial_die_info::read, lookup_die_type, follow_die_ref):
1881         Update.
1882         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
1883         from dwarf2_get_ref_die_offset.
1884         (attribute::constant_value): New method, from
1885         dwarf2_get_attr_constant_value.
1886         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
1887         Declare method.
1888         <constant_value>: New method.
1889
1890 2020-03-26  Tom Tromey  <tom@tromey.com>
1891
1892         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
1893         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
1894         (dwarf_type_encoding_name): Move to stringify.c.
1895         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
1896         * dwarf2/stringify.c: New file.
1897         * dwarf2/stringify.h: New file.
1898
1899 2020-03-26  Tom Tromey  <tom@tromey.com>
1900
1901         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
1902         Rewrite.
1903
1904 2020-03-26  Tom Tromey  <tom@tromey.com>
1905
1906         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
1907         methods.
1908         * dwarf2/read.c (lookup_addr_base): Move to die.h.
1909         (lookup_ranges_base): Likewise.
1910         (read_cutu_die_from_dwo, read_full_die_1): Update.
1911
1912 2020-03-26  Tom Tromey  <tom@tromey.com>
1913
1914         * dwarf2/read.c (read_import_statement, read_file_scope)
1915         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
1916         (read_lexical_block_scope, read_call_site_scope)
1917         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
1918         (handle_struct_member_die, process_structure_scope)
1919         (update_enumeration_type_from_children)
1920         (process_enumeration_scope, read_array_type, read_common_block)
1921         (read_namespace, read_module, read_subroutine_type): Update.
1922         (sibling_die): Remove.
1923
1924 2020-03-26  Tom Tromey  <tom@tromey.com>
1925
1926         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
1927         (build_type_psymtabs_reader, read_structure_type)
1928         (read_enumeration_type, read_full_die_1): Update.
1929         (dwarf2_attr_no_follow): Move to die.h.
1930         * dwarf2/die.h (struct die_info) <attr>: New method.
1931
1932 2020-03-26  Tom Tromey  <tom@tromey.com>
1933
1934         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
1935         <base_address>: Now an optional.
1936         (dwarf2_find_base_address, dwarf2_rnglists_process)
1937         (dwarf2_ranges_process, fill_in_loclist_baton)
1938         (dwarf2_symbol_mark_computed): Update.
1939
1940 2020-03-26  Tom Tromey  <tom@tromey.com>
1941
1942         * dwarf2/read.c (struct die_info): Move to die.h.
1943         * dwarf2/die.h: New file.
1944
1945 2020-03-26  Tom Tromey  <tom@tromey.com>
1946
1947         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
1948         * dwarf2/read.c
1949         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1950         Move to line-header.c.
1951         (read_checked_initial_length_and_offset, read_formatted_entries):
1952         Likewise.
1953         (dwarf_decode_line_header): Split into two.
1954         * dwarf2/line-header.c
1955         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1956         Move from read.c.
1957         (read_checked_initial_length_and_offset, read_formatted_entries):
1958         Likewise.
1959         (dwarf_decode_line_header): New function, split from read.c.
1960
1961 2020-03-26  Tom Tromey  <tom@tromey.com>
1962
1963         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
1964         Declare method.
1965         * dwarf2/read.c (read_attribute_value): Update.
1966         (dwarf2_per_objfile::read_line_string): Rename from
1967         read_indirect_line_string.
1968         (read_formatted_entries): Update.
1969
1970 2020-03-26  Tom Tromey  <tom@tromey.com>
1971
1972         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
1973         variable.
1974
1975 2020-03-26  Tom Tromey  <tom@tromey.com>
1976
1977         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
1978         const.
1979         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
1980         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
1981         parameter const.
1982
1983 2020-03-26  Tom Tromey  <tom@tromey.com>
1984
1985         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
1986         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
1987         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
1988         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
1989
1990 2020-03-26  Tom Tromey  <tom@tromey.com>
1991
1992         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
1993         file_names_size, file_full_name, file_file_name>: Use const.
1994         <file_name_at, file_names>: Add const overload.
1995         * dwarf2/line-header.c (line_header::file_file_name)
1996         (line_header::file_full_name): Update.
1997
1998 2020-03-26  Tom Tromey  <tom@tromey.com>
1999
2000         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
2001         (macro_start_file, consume_improper_spaces)
2002         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
2003         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
2004         (dwarf_decode_macros): Move to macro.c.
2005         * dwarf2/macro.c: New file.
2006         * dwarf2/macro.h: New file.
2007         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
2008
2009 2020-03-26  Tom Tromey  <tom@tromey.com>
2010
2011         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2012         method.
2013         * dwarf2/section.c: New method.  From
2014         read_indirect_string_at_offset_from.
2015         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2016         (read_indirect_string_at_offset_from): Move to section.c.
2017         (read_indirect_string_at_offset): Rewrite.
2018         (read_indirect_line_string_at_offset): Remove.
2019         (read_indirect_string, read_indirect_line_string)
2020         (dwarf_decode_macro_bytes): Update.
2021
2022 2020-03-26  Tom Tromey  <tom@tromey.com>
2023
2024         * dwarf2/section.h (struct dwarf2_section_info)
2025         <overload_complaint>: Declare.
2026         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2027         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2028         Rename from dwarf2_section_buffer_overflow_complaint.
2029         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2030         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2031
2032 2020-03-26  Tom Tromey  <tom@tromey.com>
2033
2034         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2035         Declare.
2036         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2037         Move from read.c.
2038         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2039         to section.c.
2040
2041 2020-03-26  Tom Tromey  <tom@tromey.com>
2042
2043         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2044
2045 2020-03-26  Tom Tromey  <tom@tromey.com>
2046
2047         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2048         "builder".
2049         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2050         parameter.
2051         (dwarf_decode_macros): Update.
2052
2053 2020-03-26  Tom Tromey  <tom@tromey.com>
2054
2055         * dwarf2/read.c (read_attribute_value): Update.
2056         (read_indirect_string_from_dwz): Move to dwz.c; change into
2057         method.
2058         (dwarf_decode_macro_bytes): Update.
2059         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
2060         * dwarf2/dwz.c: New file.
2061         * Makefile.in (COMMON_SFILES): Add dwz.c.
2062
2063 2020-03-26  Tom Tromey  <tom@tromey.com>
2064
2065         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
2066         * dwarf2/read.c: Add include.
2067         * dwarf2/index-write.c: Add include.
2068         * dwarf2/index-cache.c: Add include.
2069         * dwarf2/dwz.h: New file.
2070
2071 2020-03-25  Tom Tromey  <tom@tromey.com>
2072
2073         * compile/compile-object-load.c (get_out_value_type): Mention
2074         correct symbol name in error message.
2075
2076 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
2077
2078         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2079
2080 2020-03-25  Tom de Vries  <tdevries@suse.de>
2081
2082         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
2083         * symmisc.c (dump_symtab_1): Print user and includes fields.
2084         (maintenance_info_symtabs): Same.
2085
2086 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2087
2088         PR gdb/25534
2089         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
2090         (riscv_regcache_cooked_write): New function.
2091         (riscv_push_dummy_call): Use new function.
2092         (riscv_return_value): Likewise.
2093
2094 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
2095
2096         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
2097         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
2098         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
2099         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
2100         * infrun.c (follow_fork): Likewise.
2101         (follow_fork_inferior): Likewise.
2102         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
2103         * linux-nat.h (class linux_nat_target): Likewise.
2104         * remote.c (class remote_target) <follow_fork>: Likewise.
2105         (remote_target::follow_fork): Likewise.
2106         * target-delegates.c: Re-generate.
2107         * target.c (default_follow_fork): Likewise.
2108         (target_follow_fork): Likewise.
2109         * target.h (struct target_ops) <follow_fork>: Likewise.
2110         (target_follow_fork): Likewise.
2111
2112 2020-03-24  Tom de Vries  <tdevries@suse.de>
2113
2114         * psymtab.c (maintenance_info_psymtabs): Print user field.
2115
2116 2020-03-20  Tom Tromey  <tromey@adacore.com>
2117
2118         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
2119         const.
2120         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
2121         const.
2122
2123 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
2124
2125         * ptrace.m4: Don't check for ptrace declaration.
2126         * config.in: Re-generate.
2127         * configure: Re-generate.
2128         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
2129         not defined.
2130
2131 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2132
2133         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
2134         `PTRACE_TYPE_RET'.
2135         * i386-bsd-nat.c (gdb_ptrace): Likewise.
2136         * sparc-nat.c (gdb_ptrace): Likewise.
2137         * x86-bsd-nat.c (gdb_ptrace): Likewise.
2138
2139 2020-03-20  Tom Tromey  <tromey@adacore.com>
2140
2141         * c-exp.y (lex_one_token): Fix assert.
2142
2143 2020-03-20  Tom Tromey  <tromey@adacore.com>
2144
2145         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
2146         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
2147         strncpy call.
2148
2149 2020-03-20  Tom Tromey  <tromey@adacore.com>
2150
2151         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
2152
2153 2020-03-20  Tom Tromey  <tromey@adacore.com>
2154
2155         * ada-valprint.c (print_variant_part): Remove parameters; switch
2156         to value-based API.
2157         (print_field_values): Likewise.
2158         (ada_val_print_struct_union): Likewise.
2159         (ada_value_print_1): Update.
2160
2161 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2162
2163         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
2164         nbsd_nat_target instead of inf_ptrace_target.
2165         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2166         nbsd_nat_target.
2167
2168 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2169
2170         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
2171         it to the ptrace call.
2172         * (store_registers): Likewise.
2173
2174 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2175
2176         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
2177         it to the ptrace call.
2178         * (store_registers): Likewise.
2179
2180 2020-03-19  Luis Machado  <luis.machado@linaro.org>
2181
2182         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
2183         valid, fetch vg value from ptrace.
2184
2185 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2186         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
2187         * inf-ptrace.c: Likewise.
2188         * (gdb_ptrace): Add.
2189         * (inf_ptrace_target::resume): Update.
2190         * (inf_ptrace_target::xfer_partial): Likewise.
2191         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2192         * (inf_ptrace_peek_poke): Update.
2193
2194 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2195
2196         * x86-bsd-nat.c (gdb_ptrace): New.
2197         * (x86bsd_dr_set): Add new argument `ptid'.
2198         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2199         x86bsd_dr_set_addr): Update.
2200
2201 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * remote.c (remote_target::process_stop_reply): Handle events for
2204         all threads differently.
2205
2206 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2207
2208         * completer.c (completion_tracker::remove_completion): Define new
2209         function.
2210         * completer.h (completion_tracker::remove_completion): Declare new
2211         function.
2212         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2213         when adding a C++ function symbol.
2214
2215 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * completer.c (completion_tracker::completion_hash_entry): Define
2218         new class.
2219         (advance_to_filename_complete_word_point): Call
2220         recompute_lowest_common_denominator.
2221         (completion_tracker::completion_tracker): Call discard_completions
2222         to setup the hash table.
2223         (completion_tracker::discard_completions): Allow for being called
2224         from the constructor, pass new equal function, and element deleter
2225         when constructing the hash table.  Initialise new class member
2226         variables.
2227         (completion_tracker::maybe_add_completion): Remove use of
2228         m_entries_vec, and store more information into m_entries_hash.
2229         (completion_tracker::recompute_lcd_visitor): New function, most
2230         content taken from...
2231         (completion_tracker::recompute_lowest_common_denominator):
2232         ...here, this now just visits each item in the hash calling the
2233         above visitor.
2234         (completion_tracker::build_completion_result): Remove use of
2235         m_entries_vec, call recompute_lowest_common_denominator.
2236         * completer.h (completion_tracker::have_completions): Remove use
2237         of m_entries_vec.
2238         (completion_tracker::completion_hash_entry): Declare new class.
2239         (completion_tracker::recompute_lowest_common_denominator): Change
2240         function signature.
2241         (completion_tracker::recompute_lcd_visitor): Declare new function.
2242         (completion_tracker::m_entries_vec): Delete.
2243         (completion_tracker::m_entries_hash): Initialize to NULL.
2244         (completion_tracker::m_lowest_common_denominator_valid): New
2245         member variable.
2246         (completion_tracker::m_lowest_common_denominator_max_length): New
2247         member variable.
2248
2249 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2250
2251         * regformats/regdef.h: Put reg in gdb namespace.
2252
2253 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2254
2255         * i386-bsd-nat.c (gdb_ptrace): New.
2256         * (i386bsd_fetch_inferior_registers,
2257         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2258         * (i386bsd_fetch_inferior_registers,
2259         i386bsd_store_inferior_registers) Use gdb_ptrace.
2260
2261 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2262
2263         * amd64-bsd-nat.c (gdb_ptrace): New.
2264         * (amd64bsd_fetch_inferior_registers,
2265         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2266         * (amd64bsd_fetch_inferior_registers,
2267         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2268
2269 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2270
2271         * user-regs.c (user_reg::read): Rename to...
2272         (user_reg::xread): ...this.
2273         * (append_user_reg): Rename argument `read' to `xread'.
2274         * (user_reg_add_builtin): Likewise.
2275         * (user_reg_add): Likewise.
2276         * (value_of_user_reg): Likewise.
2277
2278 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2279
2280         * sparc-nat.c (gdb_ptrace): New.
2281         * sparc-nat.c (sparc_fetch_inferior_registers)
2282         (sparc_store_inferior_registers) Remove obsolete comment.
2283         * sparc-nat.c (sparc_fetch_inferior_registers)
2284         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2285         * sparc-nat.c (sparc_fetch_inferior_registers)
2286         (sparc_store_inferior_registers) Use gdb_ptrace.
2287
2288 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2289
2290         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2291         it to the ptrace call.
2292         * sh-nbsd-nat.c (store_registers): Likewise.
2293
2294 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2295
2296         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2297         nbsd_nat_target instead of inf_ptrace_target.
2298         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2299         nbsd_nat_target.
2300
2301 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2302
2303         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2304
2305 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2306
2307         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2308         <sys/sysctl.h>.
2309         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2310
2311 2020-03-17  Tom de Vries  <tdevries@suse.de>
2312
2313         PR gdb/23710
2314         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2315         fields.
2316         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2317         fields.
2318         (process_imported_unit_die): Skip import of c++ CUs.
2319
2320 2020-03-16  Tom Tromey  <tom@tromey.com>
2321
2322         * p-valprint.c (pascal_object_print_value): Initialize
2323         base_value.
2324
2325 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2326             Shahab Vahedi  <shahab@synopsys.com>
2327
2328         * Makefile.in: Add arch/arc.o
2329         * configure.tgt: Likewise.
2330         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2331         (_initialize_arc_tdep): Don't initialize old target descriptions.
2332         (arc_read_description): New function to cache target descriptions.
2333         * arc-tdep.h (arc_read_description): Add proto type.
2334         * arch/arc.c: New file.
2335         * arch/arc.h: Likewise.
2336         * features/Makefile: Replace old target descriptions with new.
2337         * features/arc-arcompact.c: Remove.
2338         * features/arc-arcompact.xml: Likewise.
2339         * features/arc-v2.c: Likewise
2340         * features/arc-v2.xml: Likewise
2341         * features/arc/aux-arcompact.xml: New file.
2342         * features/arc/aux-v2.xml: Likewise.
2343         * features/arc/core-arcompact.xml: Likewise.
2344         * features/arc/core-v2.xml: Likewise.
2345         * features/arc/aux-arcompact.c: Generate.
2346         * features/arc/aux-v2.c: Likewise.
2347         * features/arc/core-arcompact.c: Likewise.
2348         * features/arc/core-v2.c: Likewise.
2349         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2350
2351 2020-03-16  Tom Tromey  <tromey@adacore.com>
2352
2353         PR gdb/25663:
2354         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2355         putting value into bcache.
2356
2357 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2358
2359         PR gdb/21500
2360         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2361         to...
2362         (amd64_windows_init_abi_common): ... this.  Don't set size of
2363         long type.
2364         (amd64_windows_init_abi): New function.
2365         (amd64_cygwin_init_abi): New function.
2366         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2367         the Cygwin OS ABI.
2368         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2369         comment.
2370
2371 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2372
2373         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2374         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2375         (pe_import_directory_entry): New struct type.
2376         (is_linked_with_cygwin_dll): New function.
2377         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2378         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2379         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2380
2381 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2382
2383         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2384         i386_cygwin_core_osabi_sniffer.
2385
2386 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2387
2388         * i386-cygwin-tdep.c: Rename to...
2389         * i386-windows-tdep.c: ... this.
2390         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2391         i386-windows-tdep.c.
2392         * configure.tgt: Likewise.
2393
2394 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2395
2396         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2397         * osabi.c (gdb_osabi_names): Add "Windows".
2398         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2399         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2400         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2401         i386_cygwin_osabi_sniffer.
2402         (_initialize_i386_cygwin_tdep): Register OS ABI
2403         GDB_OSABI_WINDOWS for i386.
2404         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2405         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2406         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2407         for x86-64.
2408         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2409         when the target matches '*-*-mingw*'.
2410
2411 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2412
2413         * defs.h (enum gdb_osabi): Move to...
2414         * osabi.h (enum gdb_osabi): ... here.
2415         * gdbarch.sh: Include osabi.h in gdbarch.h.
2416         * gdbarch.h: Re-generate.
2417
2418 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2419
2420         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2421         function.
2422         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2423
2424 2020-03-14  Tom Tromey  <tom@tromey.com>
2425
2426         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2427         for C++.
2428         (c_type_print_modifier): Likewise.  Add "language" parameter.
2429         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2430         (c_type_print_base_1): Update.
2431         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2432         constants.
2433         * type-stack.c (type_stack::insert): Handle tp_atomic and
2434         tp_restrict.
2435         (type_stack::follow_type_instance_flags): Likewise.
2436         (type_stack::follow_types): Likewise.  Merge type-following code.
2437         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2438         (space_identifier, cv_with_space_id)
2439         (const_or_volatile_or_space_identifier_noopt)
2440         (const_or_volatile_or_space_identifier): Remove.
2441         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2442         rules.
2443         (ptr_operator, typebase): Update.
2444         (enum token_flag) <FLAG_C>: New constant.
2445         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2446         "_Atomic".
2447         (lex_one_token): Handle FLAG_C.
2448
2449 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2450
2451         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2452         it to the ptrace call.
2453         * m68k-bsd-nat.c (store_registers): Likewise.
2454
2455 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2456
2457         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
2458         gdb_byte *.
2459         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
2460         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
2461         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
2462
2463 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2464
2465         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
2466         nbsd_nat_target instead of inf_ptrace_target.
2467         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2468         nbsd_nat_target.
2469
2470 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2471
2472         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
2473         register_t.
2474
2475 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2476
2477         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
2478         it to the ptrace call.
2479         * alpha-bsd-nat.c (store_registers): Likewise.
2480
2481 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2482
2483         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
2484         includes.
2485         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
2486         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
2487         fill_fpregset): Likewise.
2488
2489 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2490
2491         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
2492         nbsd_nat_target instead of inf_ptrace_target.
2493         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2494         nbsd_nat_target.
2495
2496 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2497
2498         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
2499         register_t.
2500
2501 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2502
2503         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
2504         it to the ptrace call.
2505         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
2506         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
2507         * arm-nbsd-nat.c (store_register): Likewise.
2508         * arm-nbsd-nat.c (store_regs): Likewise.
2509         * arm-nbsd-nat.c (store_fp_register): Likewise.
2510         * arm-nbsd-nat.c (store_fp_regs): Likewise.
2511
2512 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2513
2514         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
2515         nbsd_nat_target instead of inf_ptrace_target.
2516         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2517         nbsd_nat_target.
2518
2519 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2520
2521         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
2522         it to the ptrace call.
2523         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
2524
2525 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2526
2527         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
2528         it to the ptrace call.
2529         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
2530
2531 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2532
2533         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
2534         gdb_byte *.
2535         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
2536
2537 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2538
2539         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2540         instead of inf_ptrace_target.
2541         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2542         nbsd_nat_target.
2543
2544 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2545
2546         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2547         register_t.
2548
2549 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2550
2551         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2552         register_t.
2553
2554 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2555
2556         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2557         register_t.
2558
2559 2020-03-13  Tom Tromey  <tom@tromey.com>
2560
2561         * value.h (val_print): Don't declare.
2562         * valprint.h (val_print_array_elements)
2563         (val_print_scalar_formatted, generic_val_print): Don't declare.
2564         * valprint.c (generic_val_print_array): Take a struct value.
2565         (generic_val_print_ptr, generic_val_print_memberptr)
2566         (generic_val_print_bool, generic_val_print_int)
2567         (generic_val_print_char, generic_val_print_complex)
2568         (generic_val_print): Remove.
2569         (generic_value_print): Update.
2570         (do_val_print): Remove unused parameters.  Don't call
2571         la_val_print.
2572         (val_print): Remove.
2573         (common_val_print): Update.  Don't call value_check_printable.
2574         (val_print_scalar_formatted, val_print_array_elements): Remove.
2575         * rust-lang.c (rust_val_print): Remove.
2576         (rust_language_defn): Update.
2577         * p-valprint.c (pascal_val_print): Remove.
2578         (pascal_value_print_inner): Update.
2579         (pascal_object_print_val_fields, pascal_object_print_val):
2580         Remove.
2581         (pascal_object_print_static_field): Update.
2582         * p-lang.h (pascal_val_print): Don't declare.
2583         * p-lang.c (pascal_language_defn): Update.
2584         * opencl-lang.c (opencl_language_defn): Update.
2585         * objc-lang.c (objc_language_defn): Update.
2586         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2587         * m2-lang.h (m2_val_print): Don't declare.
2588         * m2-lang.c (m2_language_defn): Update.
2589         * language.h (struct language_defn) <la_val_print>: Remove.
2590         * language.c (unk_lang_value_print_inner): Rename.  Change
2591         argument types.
2592         (unknown_language_defn, auto_language_defn): Update.
2593         * go-valprint.c (go_val_print): Remove.
2594         * go-lang.h (go_val_print): Don't declare.
2595         * go-lang.c (go_language_defn): Update.
2596         * f-valprint.c (f_val_print): Remove.
2597         * f-lang.h (f_value_print): Don't declare.
2598         * f-lang.c (f_language_defn): Update.
2599         * d-valprint.c (d_val_print): Remove.
2600         * d-lang.h (d_value_print): Don't declare.
2601         * d-lang.c (d_language_defn): Update.
2602         * cp-valprint.c (cp_print_value_fields)
2603         (cp_print_value_fields_rtti, cp_print_value): Remove.
2604         (cp_print_static_field): Update.
2605         * c-valprint.c (c_val_print_array, c_val_print_ptr)
2606         (c_val_print_struct, c_val_print_union, c_val_print_int)
2607         (c_val_print_memberptr, c_val_print): Remove.
2608         * c-lang.h (c_val_print_array, cp_print_value_fields)
2609         (cp_print_value_fields_rtti): Don't declare.
2610         * c-lang.c (c_language_defn, cplus_language_defn)
2611         (asm_language_defn, minimal_language_defn): Update.
2612         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
2613         (ada_val_print_enum): Take a struct value.
2614         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
2615         (ada_val_print): Remove.
2616         (ada_value_print_1): Update.
2617         (printable_val_type): Remove.
2618         * ada-lang.h (ada_val_print): Don't declare.
2619         * ada-lang.c (ada_language_defn): Update.
2620
2621 2020-03-13  Tom Tromey  <tom@tromey.com>
2622
2623         * valprint.c (do_val_print): Update.
2624         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
2625         a struct value.
2626         (value_to_value_object_no_release): Declare.
2627         * python/py-value.c (value_to_value_object_no_release): New
2628         function.
2629         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
2630         struct value.
2631         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
2632         function.
2633         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
2634         a struct value.
2635         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
2636         Declare.
2637         (gdbscm_apply_val_pretty_printer): Take a struct value.
2638         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
2639         value.
2640         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
2641         value.
2642         * extension-priv.h (struct extension_language_ops)
2643         <apply_val_pretty_printer>: Take a struct value.
2644         * cp-valprint.c (cp_print_value): Create a struct value.
2645         (cp_print_value): Update.
2646
2647 2020-03-13  Tom Tromey  <tom@tromey.com>
2648
2649         * ada-valprint.c (print_field_values): Call common_val_print.
2650
2651 2020-03-13  Tom Tromey  <tom@tromey.com>
2652
2653         * ada-valprint.c (val_print_packed_array_elements): Remove
2654         bitoffset and val parameters.  Call common_val_print.
2655         (ada_val_print_string): Remove offset, address, and original_value
2656         parameters.
2657         (ada_val_print_array): Update.
2658         (ada_value_print_array): New function.
2659         (ada_value_print_1): Call it.
2660
2661 2020-03-13  Tom Tromey  <tom@tromey.com>
2662
2663         * ada-valprint.c (ada_value_print): Use common_val_print.
2664
2665 2020-03-13  Tom Tromey  <tom@tromey.com>
2666
2667         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
2668
2669 2020-03-13  Tom Tromey  <tom@tromey.com>
2670
2671         * ada-valprint.c (ada_value_print_num): New function.
2672         (ada_value_print_1): Use it.
2673
2674 2020-03-13  Tom Tromey  <tom@tromey.com>
2675
2676         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
2677
2678 2020-03-13  Tom Tromey  <tom@tromey.com>
2679
2680         * ada-valprint.c (ada_value_print_ptr): New function.
2681         (ada_value_print_1): Use it.
2682
2683 2020-03-13  Tom Tromey  <tom@tromey.com>
2684
2685         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
2686         call common_val_print.
2687         (ada_val_print_1): Update.
2688         (ada_value_print_1): New function.
2689         (ada_value_print_inner): Rewrite.
2690
2691 2020-03-13  Tom Tromey  <tom@tromey.com>
2692
2693         * cp-valprint.c (cp_print_value_fields): Update.
2694         (cp_print_value): New function.
2695
2696 2020-03-13  Tom Tromey  <tom@tromey.com>
2697
2698         * m2-valprint.c (m2_value_print_inner): Use
2699         cp_print_value_fields.
2700         * cp-valprint.c (cp_print_value_fields): New function.
2701         * c-valprint.c (c_value_print_struct): New function.
2702         (c_value_print_inner): Use c_value_print_struct.
2703         * c-lang.h (cp_print_value_fields): Declare.
2704
2705 2020-03-13  Tom Tromey  <tom@tromey.com>
2706
2707         * c-valprint.c (c_value_print_array): New function.
2708         (c_value_print_inner): Use it.
2709
2710 2020-03-13  Tom Tromey  <tom@tromey.com>
2711
2712         * c-valprint.c (c_value_print_memberptr): New function.
2713         (c_value_print_inner): Use it.
2714
2715 2020-03-13  Tom Tromey  <tom@tromey.com>
2716
2717         * c-valprint.c (c_value_print_int): New function.
2718         (c_value_print_inner): Use it.
2719
2720 2020-03-13  Tom Tromey  <tom@tromey.com>
2721
2722         * c-valprint.c (c_value_print_ptr): New function.
2723         (c_value_print_inner): Use it.
2724
2725 2020-03-13  Tom Tromey  <tom@tromey.com>
2726
2727         * c-valprint.c (c_value_print_inner): Rewrite.
2728
2729 2020-03-13  Tom Tromey  <tom@tromey.com>
2730
2731         * valprint.c (generic_value_print_complex): New function.
2732         (generic_value_print): Use it.
2733
2734 2020-03-13  Tom Tromey  <tom@tromey.com>
2735
2736         * valprint.c (generic_val_print_float): Don't call
2737         val_print_scalar_formatted.
2738         (generic_val_print, generic_value_print): Update.
2739
2740 2020-03-13  Tom Tromey  <tom@tromey.com>
2741
2742         * valprint.c (generic_value_print_char): New function
2743         (generic_value_print): Use it.
2744
2745 2020-03-13  Tom Tromey  <tom@tromey.com>
2746
2747         * valprint.c (generic_value_print_int): New function.
2748         (generic_value_print): Use it.
2749
2750 2020-03-13  Tom Tromey  <tom@tromey.com>
2751
2752         * valprint.c (generic_value_print_bool): New function.
2753         (generic_value_print): Use it.
2754
2755 2020-03-13  Tom Tromey  <tom@tromey.com>
2756
2757         * valprint.c (generic_val_print_func): Simplify.
2758         (generic_val_print, generic_value_print): Update.
2759
2760 2020-03-13  Tom Tromey  <tom@tromey.com>
2761
2762         * valprint.c (generic_val_print_flags): Remove.
2763         (generic_val_print, generic_value_print): Update.
2764         (val_print_type_code_flags): Add original_value parameter.
2765
2766 2020-03-13  Tom Tromey  <tom@tromey.com>
2767
2768         * valprint.c (generic_val_print): Update.
2769         (generic_value_print): Update.
2770         * valprint.c (generic_val_print_enum): Don't call
2771         val_print_scalar_formatted.
2772
2773 2020-03-13  Tom Tromey  <tom@tromey.com>
2774
2775         * valprint.c (generic_value_print): Call generic_value_print_ptr.
2776         * valprint.c (generic_value_print_ptr): New function.
2777
2778 2020-03-13  Tom Tromey  <tom@tromey.com>
2779
2780         * valprint.c (generic_value_print): Rewrite.
2781
2782 2020-03-13  Tom Tromey  <tom@tromey.com>
2783
2784         * p-valprint.c (pascal_object_print_value_fields)
2785         (pascal_object_print_value): New functions.
2786
2787 2020-03-13  Tom Tromey  <tom@tromey.com>
2788
2789         * p-valprint.c (pascal_value_print_inner): Rewrite.
2790
2791 2020-03-13  Tom Tromey  <tom@tromey.com>
2792
2793         * f-valprint.c (f_value_print_innner): Rewrite.
2794
2795 2020-03-13  Tom Tromey  <tom@tromey.com>
2796
2797         * m2-valprint.c (m2_print_unbounded_array): New overload.
2798         (m2_print_unbounded_array): Update.
2799         (m2_print_array_contents): Take a struct value.
2800         (m2_value_print_inner): Rewrite.
2801
2802 2020-03-13  Tom Tromey  <tom@tromey.com>
2803
2804         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
2805         (d_value_print_inner): New function.
2806         * d-lang.h (d_value_print_inner): Declare.
2807         * d-lang.c (d_language_defn): Use d_value_print_inner.
2808
2809 2020-03-13  Tom Tromey  <tom@tromey.com>
2810
2811         * go-valprint.c (go_value_print_inner): New function.
2812         * go-lang.h (go_value_print_inner): Declare.
2813         * go-lang.c (go_language_defn): Use go_value_print_inner.
2814
2815 2020-03-13  Tom Tromey  <tom@tromey.com>
2816
2817         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
2818         API.
2819         (rust_val_print): Rewrite.
2820         (rust_value_print_inner): New function, from rust_val_print.
2821         (rust_language_defn): Use rust_value_print_inner.
2822
2823 2020-03-13  Tom Tromey  <tom@tromey.com>
2824
2825         * ada-valprint.c (ada_value_print_inner): New function.
2826         * ada-lang.h (ada_value_print_inner): Declare.
2827         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
2828
2829 2020-03-13  Tom Tromey  <tom@tromey.com>
2830
2831         * f-valprint.c (f_value_print_innner): New function.
2832         * f-lang.h (f_value_print_innner): Declare.
2833         * f-lang.c (f_language_defn): Use f_value_print_innner.
2834
2835 2020-03-13  Tom Tromey  <tom@tromey.com>
2836
2837         * p-valprint.c (pascal_value_print_inner): New function.
2838         * p-lang.h (pascal_value_print_inner): Declare.
2839         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
2840
2841 2020-03-13  Tom Tromey  <tom@tromey.com>
2842
2843         * m2-valprint.c (m2_value_print_inner): New function.
2844         * m2-lang.h (m2_value_print_inner): Declare.
2845         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
2846
2847 2020-03-13  Tom Tromey  <tom@tromey.com>
2848
2849         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
2850         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
2851         * c-valprint.c (c_value_print_inner): New function.
2852         * c-lang.h (c_value_print_inner): Declare.
2853         * c-lang.c (c_language_defn, cplus_language_defn)
2854         (asm_language_defn, minimal_language_defn): Use
2855         c_value_print_inner.
2856
2857 2020-03-13  Tom Tromey  <tom@tromey.com>
2858
2859         * p-valprint.c (pascal_object_print_value_fields): Now static.
2860         * p-lang.h (pascal_object_print_value_fields): Don't declare.
2861
2862 2020-03-13  Tom Tromey  <tom@tromey.com>
2863
2864         * c-valprint.c (c_val_print_array): Simplify.
2865
2866 2020-03-13  Tom Tromey  <tom@tromey.com>
2867
2868         * valprint.c (value_print_array_elements): New function.
2869         * valprint.h (value_print_array_elements): Declare.
2870
2871 2020-03-13  Tom Tromey  <tom@tromey.com>
2872
2873         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
2874         * mips-tdep.c (mips_print_register): Use
2875         value_print_scalar_formatted.
2876
2877 2020-03-13  Tom Tromey  <tom@tromey.com>
2878
2879         * valprint.h (value_print_scalar_formatted): Declare.
2880         * valprint.c (value_print_scalar_formatted): New function.
2881
2882 2020-03-13  Tom Tromey  <tom@tromey.com>
2883
2884         * valprint.h (generic_value_print): Declare.
2885         * valprint.c (generic_value_print): New function.
2886
2887 2020-03-13  Tom Tromey  <tom@tromey.com>
2888
2889         * valprint.c (do_val_print): Call la_value_print_inner, if
2890         available.
2891         * rust-lang.c (rust_language_defn): Update.
2892         * p-lang.c (pascal_language_defn): Update.
2893         * opencl-lang.c (opencl_language_defn): Update.
2894         * objc-lang.c (objc_language_defn): Update.
2895         * m2-lang.c (m2_language_defn): Update.
2896         * language.h (struct language_defn) <la_value_print_inner>: New
2897         member.
2898         * language.c (unknown_language_defn, auto_language_defn): Update.
2899         * go-lang.c (go_language_defn): Update.
2900         * f-lang.c (f_language_defn): Update.
2901         * d-lang.c (d_language_defn): Update.
2902         * c-lang.c (c_language_defn, cplus_language_defn)
2903         (asm_language_defn, minimal_language_defn): Update.
2904         * ada-lang.c (ada_language_defn): Update.
2905
2906 2020-03-13  Tom Tromey  <tom@tromey.com>
2907
2908         * c-valprint.c (c_value_print): Use common_val_print.
2909
2910 2020-03-13  Tom Tromey  <tom@tromey.com>
2911
2912         * cp-valprint.c (cp_print_static_field): Use common_val_print.
2913
2914 2020-03-13  Tom Tromey  <tom@tromey.com>
2915
2916         * f-valprint.c (f77_print_array_1, f_val_print): Use
2917         common_val_print.
2918
2919 2020-03-13  Tom Tromey  <tom@tromey.com>
2920
2921         * riscv-tdep.c (riscv_print_one_register_info): Use
2922         common_val_print.
2923
2924 2020-03-13  Tom Tromey  <tom@tromey.com>
2925
2926         * mi/mi-main.c (output_register): Use common_val_print.
2927
2928 2020-03-13  Tom Tromey  <tom@tromey.com>
2929
2930         * infcmd.c (default_print_one_register_info): Use
2931         common_val_print.
2932
2933 2020-03-13  Tom Tromey  <tom@tromey.com>
2934
2935         * valprint.h (common_val_print_checked): Declare.
2936         * valprint.c (common_val_print_checked): New function.
2937         * stack.c (print_frame_arg): Use common_val_print_checked.
2938
2939 2020-03-13  Tom Tromey  <tom@tromey.com>
2940
2941         * valprint.c (do_val_print): New function, from val_print.
2942         (val_print): Use do_val_print.
2943         (common_val_print): Use do_val_print.
2944
2945 2020-03-13  Tom Tromey  <tom@tromey.com>
2946
2947         * valprint.c (value_print): Use scoped_value_mark.
2948
2949 2020-03-13  Tom de Vries  <tdevries@suse.de>
2950
2951         PR symtab/25646
2952         * psymtab.c (partial_symtab::partial_symtab): Don't set
2953         globals_offset and statics_offset.  Push element onto
2954         current_global_psymbols and current_static_psymbols stacks.
2955         (concat): New function.
2956         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
2957         element from current_global_psymbols and current_static_psymbols
2958         stacks.  Concat popped elements to global_psymbols and
2959         static_symbols.
2960         (add_psymbol_to_list): Use current_global_psymbols and
2961         current_static_psymbols stacks.
2962         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
2963         current_static_psymbols fields.
2964
2965 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
2966
2967         * corelow.c (sniff_core_bfd): Remove.
2968         (class core_target) <m_core_vec>: Remove.
2969         (core_target::core_target): Update.
2970         (core_file_fns): Remove.
2971         (deprecated_add_core_fns): Remove.
2972         (default_core_sniffer): Remove.
2973         (sniff_core_bfd): Remove.
2974         (default_check_format): Remove.
2975         (gdb_check_format): Remove.
2976         (core_target_open): Update.
2977         (core_target::get_core_register_section): Update.
2978         (get_core_registers_cb): Update.
2979         (core_target::fetch_registers): Update.
2980         * gdbcore.h (struct core_fns): Remove.
2981         (deprecated_add_core_fns): Remove.
2982         (default_core_sniffer): Remove.
2983         (default_check_format): Remove.
2984
2985 2020-03-12  Tom Tromey  <tom@tromey.com>
2986
2987         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
2988         CORE_ADDR.
2989         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
2990
2991 2020-03-12  Tom Tromey  <tom@tromey.com>
2992
2993         * remote.c (remote_target::download_tracepoint)
2994         (remote_target::enable_tracepoint)
2995         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
2996         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
2997         sprintf_vma.
2998
2999 2020-03-12  Tom Tromey  <tom@tromey.com>
3000
3001         * symfile-mem.c: Update CORE_ADDR size assert.
3002
3003 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3004
3005         * selftest.m4: Move to gdbsupport/.
3006         * acinclude.m4: Update path to selftest.m4.
3007
3008 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3009
3010         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
3011         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3012         gdbarch-selfselftests.c and selftest-arch.c.
3013         (SUBDIR_UNITTESTS_OBS): Rename to...
3014         (SELFTESTS_OBS): ... this.
3015         (COMMON_SFILES): Remove disasm-selftests.c and
3016         gdbarch-selftests.c.
3017         * configure.ac: Don't add selftest-arch.{c,o} to
3018         CONFIG_{SRCS,OBS}.
3019         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3020         preprocessor conditions.
3021
3022 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3023
3024         * configure.ac: Don't source bfd/development.sh.
3025         * selftest.m4: Modify comment.
3026         * configure: Re-generate.
3027
3028 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3029
3030         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3031         not "true" or "false".
3032         * configure: Re-generate.
3033
3034 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3035
3036         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3037         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3038         renamed to arm_nbsd_supply_gregset.
3039         (fetch_register): Update to call arm_nbsd_supply_gregset.
3040         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3041         (arm_netbsd_nat_target::fetch_registers): Update.
3042         (fetch_elfcore_registers): Removed.
3043         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3044         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3045         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3046         not require NetBSD system headers.
3047         (arm_nbsd_regset): New struct.
3048         (arm_nbsd_iterate_over_regset_sections): New function.
3049         (arm_netbsd_init_abi_common): Updated to call
3050         set_gdbarch_iterate_over_regset_sections.
3051         * arm-nbsd-tdep.h: New file.
3052
3053 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3054
3055         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3056         recursion.
3057
3058 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
3059
3060         * configure: Re-generate.
3061
3062 2020-03-11  Tom Tromey  <tromey@adacore.com>
3063
3064         * ada-typeprint.c (print_choices): Fix comment.
3065
3066 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3067
3068         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
3069         previous item in the list, when the list has no items.
3070
3071 2020-03-11  Tom de Vries  <tdevries@suse.de>
3072
3073         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
3074         PROP_LOCLIST handling code.
3075
3076 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3077
3078         * buildsym-legacy.c (record_line): Pass extra parameter to
3079         record_line.
3080         * buildsym.c (buildsym_compunit::record_line): Take an extra
3081         parameter, reduce duplication in the line table, and record the
3082         is_stmt flag in the line table.
3083         * buildsym.h (buildsym_compunit::record_line): Add extra
3084         parameter.
3085         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
3086         non-statement lines.
3087         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
3088         this to the symtab builder.
3089         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
3090         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
3091         through to dwarf_record_line_1.
3092         * infrun.c (process_event_stop_test): When stepping, don't stop at
3093         a non-statement instruction, and only refresh the step info when
3094         we land in the middle of a line's range.  Also add an extra
3095         comment.
3096         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
3097         field.
3098         * record-btrace.c (btrace_find_line_range): Only record lines
3099         marked as is-statement.
3100         * stack.c (frame_show_address): Show the frame address if we are
3101         in a non-statement sal.
3102         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
3103         (maintenance_print_one_line_table): Print a header for the is_stmt
3104         column, and include is_stmt information in the output.
3105         * symtab.c (find_pc_sect_line): Find lines marked as statements in
3106         preference to non-statements.
3107         (find_pcs_for_symtab_line): Prefer is-statement entries.
3108         (find_line_common): Likewise.
3109         * symtab.h (struct linetable_entry): Add is_stmt field.
3110         (struct symtab_and_line): Likewise.
3111         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
3112         arranging the line table.
3113
3114 2020-03-07  Tom de Vries  <tdevries@suse.de>
3115
3116         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
3117         DIE.
3118
3119 2020-03-07  Tom Tromey  <tom@tromey.com>
3120
3121         * valops.c (value_literal_complex): Remove obsolete comment.
3122         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
3123         comment.
3124
3125 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3126
3127         * infrun.h: Forward-declare thread_info.
3128         (set_step_info): Add thread_info parameter, add doc.
3129         * infrun.c (set_step_info): Add thread_info parameter, move doc
3130         to header.
3131         * infrun.c (process_event_stop_test): Pass thread to
3132         set_step_info call.
3133         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
3134         set_step_info.
3135         (prepare_one_step): Add thread_info parameter, pass it to
3136         set_step_frame and prepare_one_step (recursive) call.
3137         (step_1): Pass thread to prepare_one_step call.
3138         (step_command_fsm::should_stop): Pass thread to
3139         prepare_one_step.
3140         (until_next_fsm): Pass thread to set_step_frame call.
3141         (finish_command): Pass thread to set_step_info call.
3142
3143 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
3144
3145         * windows-tdep.c (windows_solib_create_inferior_hook):
3146         Check if inferior is running.
3147
3148 2020-03-06  Tom de Vries  <tdevries@suse.de>
3149
3150         * NEWS: Fix "the the".
3151         * ctfread.c: Same.
3152
3153 2020-03-06  Tom de Vries  <tdevries@suse.de>
3154
3155         * psymtab.c (psymtab_to_symtab): Don't print "done.".
3156
3157 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3158
3159         * .dir-locals.el: Add a comment referencing the other copies of
3160         this file.
3161
3162 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
3163
3164         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
3165         psargs.
3166
3167 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3168
3169         * .gitattributes: New file.
3170
3171 2020-03-04  Tom Tromey  <tom@tromey.com>
3172
3173         * symmisc.c (print_symbol_bcache_statistics)
3174         (print_objfile_statistics): Update.
3175         * symfile.c (allocate_symtab): Use intern.
3176         * psymtab.c (partial_symtab::partial_symtab): Use intern.
3177         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3178         macro_cache>: Remove.
3179         <string_cache>: New member.
3180         (struct objfile) <intern>: New methods.
3181         * elfread.c (elf_symtab_read): Use intern.
3182         * dwarf2/read.c (fixup_go_packaging): Intern package name.
3183         (dwarf2_compute_name, dwarf2_physname)
3184         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
3185         names.
3186         (guess_partial_die_structure_name): Update.
3187         (partial_die_info::fixup): Intern name.
3188         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3189         name.
3190         (dwarf2_name): Intern name.  Update.
3191         * buildsym.c (buildsym_compunit::get_macro_table): Use
3192         string_cache.
3193
3194 2020-03-04  Tom Tromey  <tom@tromey.com>
3195
3196         * jit.c (bfd_open_from_target_memory): Make "target" const.
3197         * corefile.c (gnutarget): Now const.
3198         * gdbcore.h (gnutarget): Now const.
3199
3200 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3201
3202         * NEWS: Mention support for WOW64 processes.
3203         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3204         (amd64_windows_segment_register_p): Remove static.
3205         (_initialize_amd64_windows_nat): Update.
3206         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3207         * i386-windows-nat.c (context_offset): Update.
3208         (i386_mappings): Rename and remove static.
3209         (i386_windows_segment_register_p): Remove static.
3210         (_initialize_i386_windows_nat): Update.
3211         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3212         (STATUS_WX86_SINGLE_STEP): New macro.
3213         (EnumProcessModulesEx): New macro.
3214         (Wow64SuspendThread): New macro.
3215         (Wow64GetThreadContext): New macro.
3216         (Wow64SetThreadContext): New macro.
3217         (Wow64GetThreadSelectorEntry): New macro.
3218         (windows_set_context_register_offsets): Add static.
3219         (windows_set_segment_register_p): Likewise.
3220         (windows_add_thread): Adapt for WOW64 processes.
3221         (windows_fetch_one_register): Likewise.
3222         (windows_nat_target::fetch_registers): Likewise.
3223         (windows_store_one_register): Likewise.
3224         (display_selector): Likewise.
3225         (display_selectors): Likewise.
3226         (handle_exception): Likewise.
3227         (windows_continue): Likewise.
3228         (windows_nat_target::resume): Likewise.
3229         (windows_add_all_dlls): Likewise.
3230         (do_initial_windows_stuff): Likewise.
3231         (windows_nat_target::attach): Likewise.
3232         (windows_get_exec_module_filename): Likewise.
3233         (windows_nat_target::create_inferior): Likewise.
3234         (windows_xfer_siginfo): Likewise.
3235         (_initialize_loadable): Initialize Wow64SuspendThread,
3236         Wow64GetThreadContext, Wow64SetThreadContext,
3237         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3238         * windows-nat.h (windows_set_context_register_offsets):
3239         Remove declaration.
3240         (windows_set_segment_register_p): Likewise.
3241         (i386_windows_segment_register_p): Add declaration.
3242         (amd64_windows_segment_register_p): Likewise.
3243
3244 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3245
3246         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3247         in "info registers" for AArch64/ARM.
3248
3249         The change caused "info registers" to not print GPR's.
3250
3251         gdb/ChangeLog:
3252
3253         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3254
3255         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3256         when reg->group is empty and reggroup is not.
3257
3258 2020-03-03  Tom Tromey  <tromey@adacore.com>
3259
3260         * dwarf2/frame.c (struct dwarf2_frame_cache)
3261         <checked_tailcall_bottom, entry_cfa_sp_offset,
3262         entry_cfa_sp_offset_p>: Remove members.
3263         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3264         (dwarf2_frame_prev_register): Don't call
3265         dwarf2_tailcall_sniffer_first.
3266         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3267         * frame-unwind.c (add_unwinder): New fuction.
3268         (frame_unwind_init): Use it.  Add tailcall unwinder.
3269
3270 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3271             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3272
3273         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3274         value should be printed as true.
3275
3276 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3277
3278         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3279         (windows_init_abi): Set and use windows_so_ops.
3280
3281 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3282
3283         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3284         when verifying if dealing with a convenience variable.
3285
3286 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3287
3288         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3289
3290 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3291
3292         * infrun.c (gdbarch_supports_displaced_stepping): New.
3293         (use_displaced_stepping): Break up conditions in smaller pieces.
3294         Use gdbarch_supports_displaced_stepping.
3295         (displaced_step_prepare_throw): Use
3296         gdbarch_supports_displaced_stepping.
3297
3298 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3299
3300         * NEWS: Mention new behaviour of the history filename.
3301         * top.c (write_history_p): Add comment.
3302         (show_write_history_p): Add header comment, give a different
3303         message when history writing is on, but the history filename is
3304         empty.
3305         (history_filename): Add comment.
3306         (history_filename_empty): New function.
3307         (show_history_filename): Add header comment, give a different
3308         message when the filename is empty.
3309         (init_history): Compare history_filename against nullptr, and only
3310         read history if the filename is not empty.
3311         (set_history_filename): Add header comment, and only make
3312         non-empty filenames absolute.
3313         (init_main): Make the filename argument to 'set history filename'
3314         optional.
3315
3316 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3317
3318         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3319         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3320         (fetch_fp_register): Update.
3321         (fetch_fp_regs): Update.
3322         (store_fp_register): Update.
3323         (store_fp_regs): Update.
3324         (arm_netbsd_nat_target::read_description): New function.
3325         (fetch_elfcore_registers): Update.
3326
3327 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3328
3329         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3330         general_thread if the stop reply is missing a thread-id.
3331         (remote_target::process_stop_reply): Use the first non-exited
3332         thread if the target didn't pass a thread-id.
3333         * infrun.c (do_target_wait): Move call to
3334         switch_to_inferior_no_thread to ....
3335         (do_target_wait_1): ... here.
3336
3337 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3338
3339         * debuginfod-support.c: Include defs.h first.
3340
3341 2020-02-28  Tom de Vries  <tdevries@suse.de>
3342
3343         * symfile.c (set_initial_language): Use default language for lookup.
3344
3345 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3346
3347         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3348         reader variable, pass `this` to read_cutu_die_from_dwo.
3349
3350 2020-02-27  Aaron Merey  <amerey@redhat.com>
3351
3352         * source.c (open_source_file): Check for nullptr when computing
3353         srcpath.
3354
3355 2020-02-27  Tom Tromey  <tromey@adacore.com>
3356
3357         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3358         member.
3359         (dwarf2_add_field): Don't update nfields.
3360         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3361
3362 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3363
3364         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3365         abs.
3366
3367 2020-02-26  Tom Tromey  <tom@tromey.com>
3368
3369         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3370         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3371         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3372         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3373         per_cu_data.
3374
3375 2020-02-26  Tom Tromey  <tom@tromey.com>
3376
3377         * dwarf2/index-write.c (psym_index_map): Change type.
3378         (add_address_entry_worker, write_one_signatured_type)
3379         (recursively_count_psymbols, recursively_write_psymbols)
3380         (class debug_names, psyms_seen_size, write_gdbindex)
3381         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3382
3383 2020-02-26  Aaron Merey  <amerey@redhat.com>
3384
3385         * Makefile.in: Handle optional debuginfod support.
3386         * NEWS: Update.
3387         * README: Add --with-debuginfod summary.
3388         * config.in: Regenerate.
3389         * configure: Regenerate.
3390         * configure.ac: Handle optional debuginfod support.
3391         * debuginfod-support.c: debuginfod helper functions.
3392         * debuginfod-support.h: Ditto.
3393         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3394         summary.
3395         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3396         when a dwz file cannot be found.
3397         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3398         debuginfo file cannot be found.
3399         * source.c (open_source_file): Query debuginfod servers when a
3400         source file cannot be found.
3401         * top.c (print_gdb_configuration): Include
3402         --{with,without}-debuginfod in the output.
3403
3404 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3405
3406         * thread.c (thr_try_catch_cmd): Print thread name.
3407
3408 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3409
3410         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3411         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3412         dwarf2_fetch_die_type_sect_off): Move to...
3413         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3414         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3415         dwarf2_fetch_die_type_sect_off): ... here.
3416         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3417         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3418         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3419
3420 2020-02-26  Tom de Vries  <tdevries@suse.de>
3421
3422         PR gdb/25603
3423         * symfile.c (set_initial_language): Exit-early if
3424         language_mode == language_mode_manual.
3425
3426 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3427
3428         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3429         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3430         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3431
3432 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3433
3434         * gdbtypes.c (create_array_type_with_stride): Handle negative
3435         array strides.
3436         * valarith.c (value_subscripted_rvalue): Likewise.
3437
3438 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3439
3440         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3441
3442 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3443
3444         * loc.h (dwarf2_get_die_type): Move to...
3445         * read.h (dwarf2_get_die_type): ... here.
3446         * read.c (dwarf2_get_die_type): Move doc to header.
3447
3448 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3449
3450         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3451         'gnulib/Makefile.in' to the list.
3452
3453 2020-02-24  Tom Tromey  <tom@tromey.com>
3454
3455         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
3456         Remove.
3457         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
3458         XOBNEWVEC.
3459
3460 2020-02-24  Tom Tromey  <tom@tromey.com>
3461
3462         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
3463         New method.
3464         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
3465         (dw2_do_instantiate_symtab, dw2_get_file_names)
3466         (build_type_psymtab_dependencies, load_full_type_unit): Update.
3467
3468 2020-02-24  Tom Tromey  <tom@tromey.com>
3469
3470         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
3471         make_scoped_restore.
3472         (dwarf2_psymtab::read_symtab): Don't clear
3473         reading_partial_symbols.
3474
3475 2020-02-24  Tom de Vries  <tdevries@suse.de>
3476
3477         PR gdb/25592
3478         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
3479
3480 2020-02-24  Tom de Vries  <tdevries@suse.de>
3481
3482         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
3483         commands layout next/prev/regs.
3484
3485 2020-02-22  Tom Tromey  <tom@tromey.com>
3486
3487         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
3488         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
3489
3490 2020-02-22  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
3493
3494 2020-02-22  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-win.c (_initialize_tui_win): Add usage text.
3497         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
3498         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
3499         * tui/tui.c (_initialize_tui): Add usage text.
3500
3501 2020-02-22  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui-win.c (tui_set_focus_command)
3504         (tui_set_win_height_command): Use error_no_arg.
3505         (_initialize_tui_win): Update help text.
3506         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
3507
3508 2020-02-22  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
3511         * tui/tui-disasm.h (struct tui_disasm_window)
3512         <display_start_addr>: Declare.
3513         * tui/tui-source.h (struct tui_source_window)
3514         <display_start_addr>: Declare.
3515         * tui/tui-winsource.h (struct tui_source_window_base)
3516         <show_source_line, display_start_addr>: New methods.
3517         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
3518         Rename and move to protected section.
3519         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
3520         (tui_source_window_base::do_erase_source_content): Update.
3521         (tui_source_window_base::show_source_line): Now a method.
3522         (tui_source_window_base::show_source_content)
3523         (tui_source_window_base::tui_source_window_base)
3524         (tui_source_window_base::rerender)
3525         (tui_source_window_base::refill)
3526         (tui_source_window_base::do_scroll_horizontal)
3527         (tui_source_window_base::set_is_exec_point_at)
3528         (tui_source_window_base::update_breakpoint_info)
3529         (tui_source_window_base::update_exec_info): Update.
3530         * tui/tui-source.c (tui_source_window::set_contents)
3531         (tui_source_window::showing_source_p)
3532         (tui_source_window::do_scroll_vertical)
3533         (tui_source_window::location_matches_p)
3534         (tui_source_window::line_is_displayed): Update.
3535         (tui_source_window::display_start_addr): New method.
3536         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3537         (tui_disasm_window::do_scroll_vertical)
3538         (tui_disasm_window::location_matches_p): Update.
3539         (tui_disasm_window::display_start_addr): New method.
3540
3541 2020-02-22  Tom Tromey  <tom@tromey.com>
3542
3543         * NEWS: Add entry for gdb.register_window_type.
3544         * tui/tui-layout.h (window_factory): New typedef.
3545         (tui_register_window): Declare.
3546         * tui/tui-layout.c (saved_tui_windows): New global.
3547         (tui_apply_current_layout): Use it.
3548         (tui_register_window): New function.
3549         * python/python.c (do_start_initialization): Call
3550         gdbpy_initialize_tui.
3551         (python_GdbMethods): Add "register_window_type" function.
3552         * python/python-internal.h (gdbpy_register_tui_window)
3553         (gdbpy_initialize_tui): Declare.
3554         * python/py-tui.c: New file.
3555         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3556
3557 2020-02-22  Tom Tromey  <tom@tromey.com>
3558
3559         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3560
3561 2020-02-22  Tom Tromey  <tom@tromey.com>
3562
3563         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3564         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3565         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3566         (tui_set_win_focus_to): Move from tui-win.c.
3567
3568 2020-02-22  Tom Tromey  <tom@tromey.com>
3569
3570         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3571         functions.
3572         (known_window_types): New global.
3573         (tui_get_window_by_name): Reimplement.
3574         (initialize_known_windows): New function.
3575         (validate_window_name): Rewrite.
3576         (_initialize_tui_layout): Call initialize_known_windows.
3577
3578 2020-02-22  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3581         Remove constants.
3582         * tui/tui-winsource.h (struct tui_source_window_base)
3583         <tui_source_window_base>: Remove parameter.
3584         * tui/tui-winsource.c
3585         (tui_source_window_base::tui_source_window_base): Remove
3586         parameter.
3587         (tui_source_window_base::refill): Update.
3588         * tui/tui-stack.h (struct tui_locator_window)
3589         <tui_locator_window>: Update.
3590         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3591         Default the constructor.
3592         * tui/tui-regs.h (struct tui_data_item_window)
3593         <tui_data_item_window>: Default the constructor.
3594         (struct tui_data_window) <tui_data_window>: Likewise.
3595         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3596         Default the constructor.
3597         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3598         Default the constructor.
3599         <type>: Remove.
3600         (struct tui_win_info) <tui_win_info>: Default the constructor.
3601         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3602         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3603         Default the constructor.
3604
3605 2020-02-22  Tom Tromey  <tom@tromey.com>
3606
3607         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
3608         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
3609         * tui/tui-win.c (tui_resize_all): Don't call
3610         tui_delete_invisible_windows.
3611         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
3612         done.
3613         (tui_set_layout): Update.
3614         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
3615         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
3616         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
3617
3618 2020-02-22  Tom Tromey  <tom@tromey.com>
3619
3620         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
3621         correctly.
3622
3623 2020-02-22  Tom Tromey  <tom@tromey.com>
3624
3625         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
3626
3627 2020-02-22  Tom Tromey  <tom@tromey.com>
3628
3629         * tui/tui-winsource.h (struct tui_source_window_iterator)
3630         <inner_iterator>: New etytypedef.
3631         <tui_source_window_iterator>: Take "end" parameter.
3632         <tui_source_window_iterator>: Take iterator.
3633         <operator*, advance>: Update.
3634         <m_iter>: Change type.
3635         <m_end>: New field.
3636         (struct tui_source_windows) <begin, end>: Update.
3637         * tui/tui-layout.c (tui_windows): New global.
3638         (tui_apply_current_layout): Clear tui_windows.
3639         (tui_layout_window::apply): Update tui_windows.
3640         * tui/tui-data.h (tui_windows): Declare.
3641         (all_tui_windows): Now inline function.
3642         (class tui_window_iterator, struct all_tui_windows): Remove.
3643
3644 2020-02-22  Tom Tromey  <tom@tromey.com>
3645
3646         PR tui/17850:
3647         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
3648         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
3649         "height" argument.
3650         (class tui_layout_window) <get_sizes>: Likewise.
3651         (class tui_layout_split) <tui_layout_split>: Add "vertical"
3652         argument.
3653         <get_sizes>: Add "height" argument.
3654         <m_vertical>: New field.
3655         * tui/tui-layout.c (tui_layout_split::clone): Update.
3656         (tui_layout_split::get_sizes): Add "height" argument.
3657         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
3658         (tui_new_layout_command): Parse "-horizontal".
3659         (_initialize_tui_layout): Update help string.
3660         (tui_layout_split::specification): Add "-horizontal" when needed.
3661         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
3662         argument.
3663         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
3664         New methods.
3665
3666 2020-02-22  Tom Tromey  <tom@tromey.com>
3667
3668         * tui/tui-layout.h (enum tui_adjust_result): New.
3669         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
3670         (class tui_layout_window) <adjust_size>: Return
3671         tui_adjust_result.  Rewrite.
3672         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
3673         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
3674
3675 2020-02-22  Tom Tromey  <tom@tromey.com>
3676
3677         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
3678         parameter and return types.
3679         (class tui_layout_base) <specification>: Add "depth".
3680         (class tui_layout_window) <specification>: Add "depth".
3681         (class tui_layout_split) <specification>: Add "depth".
3682         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
3683         and return types.
3684         (tui_new_layout_command): Parse sub-layouts.
3685         (_initialize_tui_layout): Update help string.
3686         (tui_layout_window::specification): Add "depth".
3687         (add_layout_command): Update.
3688
3689 2020-02-22  Tom Tromey  <tom@tromey.com>
3690
3691         * NEWS: Add "tui new-layout" item.
3692         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
3693         Add new-layout command to help text.
3694         (validate_window_name): New function.
3695         (tui_new_layout_command): New function.
3696         (_initialize_tui_layout): Register "new-layout".
3697         (tui_layout_window::specification): New method.
3698         (tui_layout_window::specification): New method.
3699         * tui/tui-layout.h (class tui_layout_base) <specification>: New
3700         method.
3701         (class tui_layout_window) <specification>: New method.
3702         (class tui_layout_split) <specification>: New method.
3703
3704 2020-02-22  Tom Tromey  <tom@tromey.com>
3705
3706         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
3707         * tui/tui-win.c (window_name_completer): Update comment.
3708         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
3709         Declare method.
3710         (class tui_layout_window) <replace_window>: Likewise.
3711         (class tui_layout_split) <replace_window>: Likewise.
3712         (tui_set_layout): Don't declare.
3713         (tui_set_initial_layout): Declare function.
3714         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
3715         (asm_regs_layout): New globals.
3716         (tui_current_layout, show_layout): Remove.
3717         (tui_set_layout, tui_add_win_to_layout): Rewrite.
3718         (find_layout, tui_apply_layout): New function.
3719         (layout_completer): Remove.
3720         (tui_next_layout): Reimplement.
3721         (tui_next_layout_command): New function.
3722         (tui_set_initial_layout, tui_prev_layout_command): New functions.
3723         (tui_regs_layout): Reimplement.
3724         (tui_regs_layout_command): New function.
3725         (extract_display_start_addr): Rewrite.
3726         (next_layout, prev_layout): Remove.
3727         (tui_layout_window::replace_window): New method.
3728         (tui_layout_split::replace_window): New method.
3729         (destroy_layout): New function.
3730         (layout_list): New global.
3731         (add_layout_command): New function.
3732         (initialize_layouts): Update.
3733         (tui_layout_command): New function.
3734         (_initialize_tui_layout): Install "layout" commands.
3735         * tui/tui-data.h (enum tui_layout_type): Remove.
3736         (tui_current_layout): Don't declare.
3737
3738 2020-02-22  Tom Tromey  <tom@tromey.com>
3739
3740         * tui/tui-regs.c (tui_reg_layout): Remove.
3741         (tui_reg_command): Use tui_regs_layout.
3742         * tui/tui-layout.h (tui_reg_command): Declare.
3743         * tui/tui-layout.c (tui_reg_command): New function.
3744
3745 2020-02-22  Tom Tromey  <tom@tromey.com>
3746
3747         * tui/tui.c (tui_rl_delete_other_windows): Call
3748         tui_remove_some_windows.
3749         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
3750         Declare method.
3751         (class tui_layout_window) <remove_windows>: New method.
3752         (class tui_layout_split) <remove_windows>: Declare.
3753         (tui_remove_some_windows): Declare.
3754         * tui/tui-layout.c (tui_remove_some_windows): New function.
3755         (tui_layout_split::remove_windows): New method.
3756
3757 2020-02-22  Tom Tromey  <tom@tromey.com>
3758
3759         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
3760         * tui/tui-layout.h (tui_next_layout): Declare.
3761         * tui/tui-layout.c (tui_next_layout): New function.
3762
3763 2020-02-22  Tom Tromey  <tom@tromey.com>
3764
3765         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
3766         correct coordinates.
3767
3768 2020-02-22  Tom Tromey  <tom@tromey.com>
3769
3770         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
3771         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
3772         DATA_WIN case.
3773
3774 2020-02-22  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
3777         TUI_DISASM_WIN, not tui_win_list.
3778
3779 2020-02-22  Tom Tromey  <tom@tromey.com>
3780
3781         * valprint.c (generic_val_print_enum_1)
3782         (val_print_type_code_flags): Style member names.
3783         * rust-lang.c (val_print_struct, rust_print_enum)
3784         (rust_print_struct_def, rust_internal_print_type): Style member
3785         names.
3786         * p-valprint.c (pascal_object_print_value_fields): Style member
3787         names.  Only call fprintf_symbol_filtered for static members.
3788         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
3789         * f-valprint.c (f_val_print): Style member names.
3790         * f-typeprint.c (f_type_print_base): Style member names.
3791         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
3792         call fprintf_symbol_filtered for static members.
3793         (cp_print_class_member): Style member names.
3794         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
3795         member names.
3796         * ada-valprint.c (ada_print_scalar): Style enum names.
3797         (ada_val_print_enum): Likewise.
3798         * ada-typeprint.c (print_enum_type): Style enum names.
3799
3800 2020-02-21  Tom Tromey  <tom@tromey.com>
3801
3802         * psympriv.h (struct partial_symtab): Update comment.
3803
3804 2020-02-21  Tom Tromey  <tromey@adacore.com>
3805
3806         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
3807         type is CORE_ADDR.
3808
3809 2020-02-21  Tom de Vries  <tdevries@suse.de>
3810
3811         PR gdb/25534
3812         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
3813         if dependencies[i]->user != NULL.
3814
3815 2020-02-21  Ali Tamur  <tamur@google.com>
3816
3817         * dwarf2/read.c (dwarf2_name): Add null check.
3818
3819 2020-02-20  Tom Tromey  <tom@tromey.com>
3820
3821         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
3822         ">=", in binary search.
3823         (dwarf2_find_containing_comp_unit): New overload.
3824         (run_test): New self-test.
3825         (_initialize_dwarf2_read): Register new test.
3826
3827 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
3828
3829         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
3830         * riscv-tdep.h: Likewise.
3831         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
3832         rv32-only CSR.
3833         * features/riscv/64bit-csr.xml: Regenerated.
3834
3835 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
3836             Tom Tromey  <tom@tromey.com>
3837
3838         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
3839         of 'fputc_unfiltered'.
3840         (putchar_unfiltered): Call 'fputc_unfiltered'.
3841         (fputc_unfiltered): Call 'fputs_unfiltered'.
3842
3843 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
3844
3845         * config.in: Regenerate.
3846         * configure: Regenerate.
3847         * configure.ac: Add --with-python-libdir option.
3848         * main.c: Use WITH_PYTHON_LIBDIR.
3849
3850 2020-02-19  Tom Tromey  <tom@tromey.com>
3851
3852         * symtab.c (general_symbol_info::compute_and_set_names): Use
3853         obstack_strndup.  Simplify call to symbol_set_demangled_name.
3854
3855 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
3856
3857         * dwarf2/read.c (allocate_signatured_type_table,
3858         allocate_dwo_unit_table, allocate_type_unit_groups_table,
3859         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
3860         Remove objfile parameter, update all callers.
3861
3862 2020-02-19  Doug Evans  <dje@google.com>
3863
3864         PR rust/25535
3865         * rust-lang.c (rust_print_enum): Apply embedded_offset to
3866         rust_enum_variant calculation.
3867
3868 2020-02-19  Tom Tromey  <tromey@adacore.com>
3869
3870         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
3871
3872 2020-02-19  Tom Tromey  <tromey@adacore.com>
3873
3874         * ada-lang.c (cache_symbol): Use obstack_strdup.
3875
3876 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3877
3878         * configure: Regenerate.
3879
3880 2020-02-19  Tom Tromey  <tromey@adacore.com>
3881
3882         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
3883         NULL check.
3884
3885 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
3886
3887         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
3888
3889 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3890
3891         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
3892         if GDBSERVER is not defined.
3893         (riscv_tdesc_cache): Likewise, also store const target_desc.
3894         (STATIC_IN_GDB): Define.
3895         (riscv_create_target_description): Update declaration with
3896         STATIC_IN_GDB.
3897         (riscv_lookup_target_description): New function, only define if
3898         GDBSERVER is not defined.
3899         * arch/riscv.h (riscv_create_target_description): Declare only
3900         when GDBSERVER is defined.
3901         (riscv_lookup_target_description): New declaration when GDBSERVER
3902         is not defined.
3903         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
3904         (riscv_linux_read_features): ...this, and return
3905         riscv_gdbarch_features instead of target_desc.
3906         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
3907         (riscv_linux_read_description): Rename to...
3908         (riscv_linux_read_features): ...this.
3909         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3910         Update to use riscv_gdbarch_features and
3911         riscv_lookup_target_description.
3912         * riscv-tdep.c (riscv_find_default_target_description): Use
3913         riscv_lookup_target_description instead of
3914         riscv_create_target_description.
3915
3916 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3917
3918         * valprint.c (generic_val_print_enum_1): When printing a flag
3919         enum with value 0 and there is no enumerator with value 0, print
3920         just "0" instead of "(unknown: 0x0)".
3921
3922 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3923
3924         * valprint.c (generic_val_print_enum_1): Print unknown part of
3925         flag enum in hex.
3926
3927 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3928
3929         * dwarf2/read.c (update_enumeration_type_from_children): Allow
3930         flag enums to contain duplicate enumerators.
3931         * valprint.c (generic_val_print_enum_1): Update comment.
3932
3933 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3934
3935         * dwarf2/read.c: Include "count-one-bits.h".
3936         (update_enumeration_type_from_children): If an enumerator has
3937         multiple bits set, don't treat the enumeration as a "flag enum".
3938         * valprint.c (generic_val_print_enum_1): Assert that enumerators
3939         of flag enums have 0 or 1 bit set.
3940
3941 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3942
3943         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
3944         conversion.
3945         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3946         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3947         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3948         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3949         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3950
3951 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3952
3953         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
3954
3955 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3956
3957         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
3958         displaced_step_closure_up.
3959         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3960         (struct displaced_step_closure_up):
3961         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3962         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3963         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
3964         Likewise.
3965         * gdbarch.sh (displaced_step_copy_insn): Likewise.
3966         * gdbarch.c, gdbarch.h: Re-generate.
3967         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
3968         displaced_step_closure_up.
3969         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3970         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
3971         * infrun.h (displaced_step_closure_up): New type alias.
3972         (struct displaced_step_inferior_state) <step_closure>: Change
3973         type to displaced_step_closure_up.
3974         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
3975         displaced_step_closure_up.
3976         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3977
3978 2020-02-14  Tom Tromey  <tom@tromey.com>
3979
3980         * minidebug.c (gnu_debug_key): New global.
3981         (find_separate_debug_file_in_section): Use it.
3982
3983 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3984
3985         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
3986         std::unique_ptr.
3987         * gdbarch.c: Re-generate.
3988         * gdbarch.h: Re-generate.
3989         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
3990         change.
3991         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
3992         type to std::unique_ptr.
3993         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3994         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3995         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3996         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3997         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
3998         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3999         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4000         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4001         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4002
4003 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4004
4005         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
4006         std::unique_ptr.
4007         (displaced_step_clear): Rename to...
4008         (displaced_step_reset): ... this.  Just call displaced->reset ().
4009         (displaced_step_clear_cleanup): Rename to...
4010         (displaced_step_reset_cleanup): ... this.
4011         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4012         (displaced_step_fixup): Likewise.
4013         (resume_1): Likewise.
4014         (handle_inferior_event): Restore child's memory before calling
4015         displaced_step_fixup on the parent.
4016         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4017         to std::unique_ptr.
4018         <step_closure>: Change type to std::unique_ptr.
4019
4020 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4021
4022         * arm-tdep.c: Include count-one-bits.h.
4023         (cleanup_block_store_pc): Use count_one_bits.
4024         (cleanup_block_load_pc): Use count_one_bits.
4025         (arm_copy_block_xfer): Use count_one_bits.
4026         (thumb2_copy_block_xfer): Use count_one_bits.
4027         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4028         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4029         (thumb_get_next_pcs_raw): Use count_one_bits.
4030         (arm_get_next_pcs_raw): Use count_one_bits_l.
4031         * arch/arm.c (bitcount): Remove.
4032         * arch/arm.h (bitcount): Remove.
4033
4034 2020-02-14  Tom Tromey  <tromey@adacore.com>
4035
4036         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4037         Update.
4038         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4039         * dwarf2/loc.c (call_site_find_chain_1): Return
4040         unique_xmalloc_ptr.
4041         (call_site_find_chain): Likewise.
4042
4043 2020-02-14  Richard Biener  <rguenther@suse.de>
4044
4045         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4046         on expression with division operators.
4047
4048 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4049
4050         * MAINTAINERS (Write After Approval): Adding myself.
4051
4052 2020-02-12  Tom Tromey  <tom@tromey.com>
4053
4054         * event-loop.c (event_data, gdb_event, event_handler_func):
4055         Remove.
4056
4057 2020-02-12  Tom Tromey  <tom@tromey.com>
4058
4059         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
4060         (dwarf2_frame_objfile_data): Add comment.
4061         (find_comp_unit, set_comp_unit): New functions.
4062         (dwarf2_frame_find_fde): Use find_comp_unit.
4063         (dwarf2_build_frame_info): Use set_comp_unit.
4064
4065 2020-02-12  Tom Tromey  <tom@tromey.com>
4066
4067         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
4068         (comp_unit): Don't initialize objfile.
4069         (execute_cfa_program): Add text_offset parameter.
4070         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
4071         (dwarf2_frame_cache): Update.
4072         (dwarf2_build_frame_info): Don't set "objfile" member.
4073
4074 2020-02-12  Tom Tromey  <tom@tromey.com>
4075
4076         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
4077         (decode_frame_entry): Likewise.
4078         (dwarf2_build_frame_info): Update.
4079
4080 2020-02-12  Tom Tromey  <tom@tromey.com>
4081
4082         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
4083         (decode_frame_entry_1): Use the comp_unit obstack.
4084
4085 2020-02-12  Tom Tromey  <tom@tromey.com>
4086
4087         * dwarf2/frame.c (struct comp_unit): Add initializers and
4088         constructor.
4089         (dwarf2_frame_objfile_data): Store a comp_unit.
4090         (dwarf2_frame_find_fde): Update.
4091         (dwarf2_build_frame_info): Use "new".
4092
4093 2020-02-12  Tom Tromey  <tom@tromey.com>
4094
4095         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
4096         (dwarf2_fde_table): Typedef for std::vector.
4097         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
4098         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
4099         (decode_frame_entry): Update.
4100         (dwarf2_build_frame_info): Use "new".
4101
4102 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4103
4104         * arm-tdep.c (arm_gdbarch_init): Update.
4105         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
4106         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
4107         have_neon, is_m>: Change to bool.
4108
4109 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4110
4111         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
4112
4113 2020-02-12  Tom Tromey  <tom@tromey.com>
4114
4115         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
4116
4117 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
4118
4119         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
4120         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
4121
4122 2020-02-11  Tom Tromey  <tom@tromey.com>
4123
4124         * psymtab.h: Update comment.
4125
4126 2020-02-11  Tom Tromey  <tom@tromey.com>
4127
4128         * gdb_obstack.h (struct auto_obstack): Use
4129         DISABLE_COPY_AND_ASSIGN.
4130
4131 2020-02-11  Tom Tromey  <tom@tromey.com>
4132
4133         * dwarf2/frame.h (struct objfile): Don't forward declare.
4134
4135 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4136
4137         * cris-tdep.c (cris_supply_gregset): Change signature to match
4138         what struct regset expects.
4139         (cris_regset): New struct.
4140         (fetch_core_registers): Remove.
4141         (cris_iterate_over_regset_sections): New function.
4142         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
4143         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
4144
4145 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4146
4147         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
4148         registers.
4149
4150 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4151
4152         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
4153
4154 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4155
4156         * configure: Re-generate.
4157
4158 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4159
4160         * configure: Re-generate.
4161
4162 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4163
4164         * acinclude: Update warning.m4 path.
4165         * warning.m4: Move to gdbsupport.
4166
4167 2020-02-11  Tom Tromey  <tromey@adacore.com>
4168
4169         * remote.c (remote_console_output): Update.
4170         * printcmd.c (printf_command): Update.
4171         * event-loop.c (gdb_wait_for_event): Update.
4172         * linux-nat.c (sigchld_handler): Update.
4173         * remote-sim.c (gdb_os_write_stdout): Update.
4174         (gdb_os_flush_stdout): Update.
4175         (gdb_os_flush_stderr): Update.
4176         (gdb_os_write_stderr): Update.
4177         * exceptions.c (print_exception): Update.
4178         * remote-fileio.c (remote_fileio_func_read): Update.
4179         (remote_fileio_func_write): Update.
4180         * tui/tui.c (tui_enable): Update.
4181         * tui/tui-interp.c (tui_interp::init): Update.
4182         * utils.c (init_page_info): Update.
4183         (putchar_unfiltered, fputc_unfiltered): Update.
4184         (gdb_flush): Update.
4185         (emit_style_escape): Update.
4186         (flush_wrap_buffer, fputs_maybe_filtered): Update.
4187         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
4188         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4189         (stderr_file::write): Update.
4190         (stderr_file::puts): Update.
4191         * ui-file.h (ui_file_isatty, ui_file_write)
4192         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4193         (ui_file_puts): Don't declare.
4194
4195 2020-02-10  Tom de Vries  <tdevries@suse.de>
4196
4197         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4198         sentinel to char *.
4199
4200 2020-02-09  Tom de Vries  <tdevries@suse.de>
4201
4202         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4203         filename if it matches "<artificial>".
4204
4205 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4206
4207         * windows-tdep.c (struct enum_value_name): New struct.
4208         (create_enum): New function.
4209         (windows_get_siginfo_type): Create and use enum types.
4210
4211 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4212
4213         * NEWS: Mention $_siginfo support for Windows.
4214         * windows-nat.c (handle_exception): Set siginfo_er.
4215         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4216         (windows_xfer_siginfo): New function.
4217         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4218         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4219         (init_windows_gdbarch_data): New function.
4220         (get_windows_gdbarch_data): New function.
4221         (windows_get_siginfo_type): New function.
4222         (windows_init_abi): Register windows_get_siginfo_type.
4223         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4224
4225 2020-02-08  Tom Tromey  <tom@tromey.com>
4226
4227         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4228         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4229         <keep>: Declare method.
4230         <m_keep>: Remove member.
4231         <~cutu_reader>: Remove.
4232         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4233         (cutu_reader::cutu_reader): Update.
4234         (cutu_reader::keep): Rename from ~cutu_reader.
4235         (process_psymtab_comp_unit, build_type_psymtabs_1)
4236         (process_skeletonless_type_unit, load_partial_comp_unit)
4237         (load_full_comp_unit, dwarf2_read_addr_index)
4238         (read_signatured_type): Update.
4239
4240 2020-02-08  Tom Tromey  <tom@tromey.com>
4241
4242         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4243         "want_partial_unit" parameter.
4244         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4245         Inline check for DW_TAG_partial_unit.
4246         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4247
4248 2020-02-08  Tom Tromey  <tom@tromey.com>
4249
4250         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4251         read.c.
4252         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4253         read.c.
4254
4255 2020-02-08  Tom Tromey  <tom@tromey.com>
4256
4257         * dwarf2/read.c (read_address): Move to comp-unit.c.
4258         (dwarf2_rnglists_process, dwarf2_ranges_process)
4259         (read_attribute_value, dwarf_decode_lines_1)
4260         (var_decode_location, decode_locdesc): Update.
4261         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4262         read.c.  Remove "cu" parameter.
4263         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4264         method.
4265
4266 2020-02-08  Tom Tromey  <tom@tromey.com>
4267
4268         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4269         (read_indirect_line_string): Update.
4270         * dwarf2/comp-unit.c (read_offset): Remove.
4271         (read_comp_unit_head): Update.
4272         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4273         method.
4274         (read_offset): Don't declare.
4275
4276 2020-02-08  Tom Tromey  <tom@tromey.com>
4277
4278         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4279         * dwarf2/read.c (struct comp_unit_head): Move to
4280         dwarf2/comp-unit.h.
4281         (enum class rcuh_kind): Move to comp-unit.h.
4282         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4283         (read_comp_unit_head, error_check_comp_unit_head)
4284         (read_and_check_comp_unit_head): Move to comp-unit.c.
4285         (read_offset, dwarf_unit_type_name): Likewise.
4286         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4287         (cutu_reader::cutu_reader, read_call_site_scope)
4288         (find_partial_die, follow_die_offset): Update.
4289         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4290
4291 2020-02-08  Tom Tromey  <tom@tromey.com>
4292
4293         * dwarf2/read.c (read_offset_1): Move to leb.c.
4294         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4295         (dwarf_decode_macro_bytes): Update.
4296         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4297         * dwarf2/leb.h (read_offset): Declare.
4298
4299 2020-02-08  Tom Tromey  <tom@tromey.com>
4300
4301         * dwarf2/read.c (dwarf2_section_size): Remove.
4302         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4303         Update.
4304         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4305
4306 2020-02-08  Tom Tromey  <tom@tromey.com>
4307
4308         * dwarf2/read.c (read_initial_length): Move to leb.c.
4309         * dwarf2/leb.h (read_initial_length): Declare.
4310         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4311         handle_nonstd parameter.
4312         * dwarf2/frame.c (read_initial_length): Remove.
4313         (decode_frame_entry_1): Update.
4314
4315 2020-02-08  Tom Tromey  <tom@tromey.com>
4316
4317         * dwarf2/loc.c (dwarf2_find_location_expression)
4318         (dwarf_evaluate_loc_desc::get_tls_address)
4319         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4320         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4321         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4322         (dwarf2_compile_property_to_c)
4323         (dwarf2_loc_desc_get_symbol_read_needs)
4324         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4325         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4326         (loclist_describe_location, loclist_tracepoint_var_ref)
4327         (loclist_generate_c_location): Update.
4328         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4329         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4330         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4331         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4332         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4333         (dwarf2_per_cu_data::addr_size)
4334         (dwarf2_per_cu_data::ref_addr_size)
4335         (dwarf2_per_cu_data::text_offset)
4336         (dwarf2_per_cu_data::addr_type): Now methods.
4337         (per_cu_header_read_in): Make per_cu "const".
4338         (dwarf2_version): Remove.
4339         (dwarf2_per_cu_data::int_type): Now a method.
4340         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4341         (set_die_type, read_array_type, read_subrange_index_type)
4342         (read_tag_string_type, read_subrange_type): Update.
4343         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4344         offset_size, ref_addr_size, text_offset, addr_type, version,
4345         objfile, int_type, addr_sized_int_type>: Declare methods.
4346
4347 2020-02-08  Tom Tromey  <tom@tromey.com>
4348
4349         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4350         Move earlier.
4351
4352 2020-02-08  Tom Tromey  <tom@tromey.com>
4353
4354         * dwarf2/read.h (dwarf_line_debug): Declare.
4355         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4356         * dwarf2/read.c: Move line_header code to new files.
4357         (dwarf_line_debug): No longer static.
4358         * dwarf2/line-header.c: New file.
4359         * dwarf2/line-header.h: New file.
4360
4361 2020-02-08  Tom Tromey  <tom@tromey.com>
4362
4363         * dwarf2/read.c (struct line_header) <file_full_name,
4364         file_file_name>: Return unique_xmalloc_ptr.
4365         (line_header::file_file_name): Update.
4366         (line_header::file_full_name): Update.
4367         (dw2_get_file_names_reader): Update.
4368         (macro_start_file): Update.
4369
4370 2020-02-08  Tom Tromey  <tom@tromey.com>
4371
4372         * dwarf2/read.c (struct line_header) <file_full_name,
4373         file_file_name>: Declare methods.
4374         (dw2_get_file_names_reader): Update.
4375         (file_file_name): Now a method.
4376         (file_full_name): Likewise.
4377         (macro_start_file): Update.
4378
4379 2020-02-08  Tom Tromey  <tom@tromey.com>
4380
4381         * dwarf2/read.c (dwarf_always_disassemble)
4382         (show_dwarf_always_disassemble): Move to loc.c.
4383         (_initialize_dwarf2_read): Move "always-disassemble" registration
4384         to loc.c.
4385         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4386         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4387         static.
4388         (show_dwarf_always_disassemble): Move from read.c.
4389         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4390
4391 2020-02-08  Tom Tromey  <tom@tromey.com>
4392
4393         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4394         (create_quick_file_names_table): Return htab_up.
4395         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4396         Update.
4397         * dwarf2/read.h (struct dwarf2_per_objfile)
4398         <quick_file_names_table>: Now htab_up.
4399
4400 2020-02-08  Tom Tromey  <tom@tromey.com>
4401
4402         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4403
4404 2020-02-08  Tom Tromey  <tom@tromey.com>
4405
4406         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4407         Rewrite.
4408         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4409         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4410         (abbrev_table::abbrev_table): No longer inline.
4411         (ABBREV_HASH_SIZE): Remove.
4412         (abbrev_table::m_abbrevs): Now an htab_up.
4413
4414 2020-02-08  Tom Tromey  <tom@tromey.com>
4415
4416         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4417         (cutu_reader): Update.
4418         (build_type_psymtabs_1): Update.
4419         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4420         (abbrev_table::alloc_abbrev): Update.
4421         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4422         (abbrev_table::read): New static method, renamed from
4423         abbrev_table_read_table.
4424         (abbrev_table::alloc_abbrev)
4425         (abbrev_table::add_abbrev): Now private.
4426         (abbrev_table::abbrev_table): Now private.
4427         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4428
4429 2020-02-08  Tom Tromey  <tom@tromey.com>
4430
4431         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4432         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4433         htab_up.
4434
4435 2020-02-08  Tom Tromey  <tom@tromey.com>
4436
4437         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4438         htab_up.
4439         (lookup_dwo_unit_in_dwp): Update.
4440         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4441         on obstack.
4442
4443 2020-02-08  Tom Tromey  <tom@tromey.com>
4444
4445         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4446         obstack.
4447
4448 2020-02-08  Tom Tromey  <tom@tromey.com>
4449
4450         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4451         line_header_hash.
4452         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4453         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4454         Change type to htab_up.
4455
4456 2020-02-08  Tom Tromey  <tom@tromey.com>
4457
4458         * dwarf2/read.c (allocate_type_unit_groups_table): Return
4459         htab_up.  Don't allocate on obstack.
4460         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
4461         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
4462         Change type to htab_up.
4463
4464 2020-02-08  Tom Tromey  <tom@tromey.com>
4465
4466         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
4467         Change type to htab_up.
4468         * dwarf2/read.c (create_signatured_type_table_from_index)
4469         (create_signatured_type_table_from_debug_names)
4470         (create_all_type_units, add_type_unit)
4471         (lookup_dwo_signatured_type, lookup_signatured_type)
4472         (process_skeletonless_type_unit): Update.
4473         (create_debug_type_hash_table, create_debug_types_hash_table):
4474         Change type of types_htab.
4475         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
4476         htab_up.  Don't allocate on obstack.
4477         (create_cus_hash_table): Change type of cus_htab parameter.
4478         (struct dwo_file) <cus, tus>: Now htab_up.
4479         (lookup_dwo_signatured_type, lookup_dwo_cutu)
4480         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
4481         (queue_and_load_all_dwo_tus): Update.
4482         * dwarf2/index-write.c (write_gdbindex): Update.
4483         (write_debug_names): Update.
4484
4485 2020-02-08  Tom Tromey  <tom@tromey.com>
4486
4487         * dwarf2/read.h (struct dwarf2_queue_item): Move from
4488         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
4489         destructor.
4490         (struct dwarf2_per_objfile) <queue>: New member.
4491         * dwarf2/read.c (struct dwarf2_queue_item): Move to
4492         dwarf2/read.h.
4493         (dwarf2_queue, dwarf2_queue_tail): Remove.
4494         (class dwarf2_queue_guard): Add parameter to constructor.  Use
4495         DISABLE_COPY_AND_ASSIGN.
4496         <m_per_objfile>: New member.
4497         <~dwarf2_queue_guard>: Rewrite.
4498         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
4499         Update.
4500         (~dwarf2_queue_item): New.
4501
4502 2020-02-08  Tom Tromey  <tom@tromey.com>
4503
4504         * dwarf2/read.c (struct die_info) <has_children>: New member.
4505         (dw2_get_file_names_reader): Remove has_children.
4506         (dw2_get_file_names): Update.
4507         (read_cutu_die_from_dwo): Remove has_children.
4508         (cutu_reader::init_tu_and_read_dwo_dies)
4509         (cutu_reader::cutu_reader): Update.
4510         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
4511         Remove has_children.
4512         (build_type_psymtabs_1, process_skeletonless_type_unit)
4513         (load_partial_comp_unit, load_full_comp_unit): Update.
4514         (create_dwo_cu_reader): Remove has_children.
4515         (create_cus_hash_table, read_die_and_children): Update.
4516         (read_full_die_1,read_full_die): Remove has_children.
4517         (read_signatured_type): Update.
4518         (class cutu_reader) <has_children>: Remove.
4519
4520 2020-02-08  Tom Tromey  <tom@tromey.com>
4521
4522         * dwarf2/expr.c: Rename from dwarf2expr.c.
4523         * dwarf2/expr.h: Rename from dwarf2expr.h.
4524         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
4525         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
4526         * dwarf2/frame.c: Rename from dwarf2-frame.c.
4527         * dwarf2/frame.h: Rename from dwarf2-frame.h.
4528         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
4529         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
4530         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
4531         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
4532         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
4533         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
4534         * dwarf2/loc.c: Rename from dwarf2loc.c.
4535         * dwarf2/loc.h: Rename from dwarf2loc.h.
4536         * dwarf2/read.c: Rename from dwarf2read.c.
4537         * dwarf2/read.h: Rename from dwarf2read.h.
4538         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4539         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4540         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4541         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4542         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4543         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4544         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4545         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4546         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4547         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4548         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4549         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4550         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4551         Update.
4552         * Makefile.in (COMMON_SFILES): Update.
4553         (HFILES_NO_SRCDIR): Update.
4554
4555 2020-02-08  Tom Tromey  <tom@tromey.com>
4556
4557         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4558         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4559
4560 2020-02-08  Tom Tromey  <tom@tromey.com>
4561
4562         * dwarf2read.h (struct die_info): Don't declare.
4563
4564 2020-02-08  Tom Tromey  <tom@tromey.com>
4565
4566         * dwarf2read.h (die_info_ptr): Remove typedef.
4567
4568 2020-02-08  Tom Tromey  <tom@tromey.com>
4569
4570         * dwarf2read.c (read_call_site_scope)
4571         (handle_data_member_location, dwarf2_add_member_fn)
4572         (mark_common_block_symbol_computed, read_common_block)
4573         (attr_to_dynamic_prop, partial_die_info::read)
4574         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4575         (dwarf2_symbol_mark_computed, set_die_type): Update.
4576         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4577         method.
4578         (attr_form_is_block): Don't declare.
4579         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4580
4581 2020-02-08  Tom Tromey  <tom@tromey.com>
4582
4583         * dwarf2read.c (dwarf2_find_base_address, )
4584         (read_call_site_scope, rust_containing_type)
4585         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4586         (handle_data_member_location, dwarf2_add_member_fn)
4587         (get_alignment, read_structure_type, process_structure_scope)
4588         (mark_common_block_symbol_computed, read_common_block)
4589         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4590         (partial_die_info::read, read_attribute_value, new_symbol)
4591         (lookup_die_type, dwarf2_get_ref_die_offset)
4592         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4593         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4594         (dwarf2_symbol_mark_computed): Update.
4595         * dwarf2/attribute.h (struct attribute) <value_as_address,
4596         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4597         methods.
4598         (value_as_address, attr_form_is_section_offset)
4599         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4600         * dwarf2/attribute.c (attribute::value_as_address)
4601         (attribute::form_is_section_offset, attribute::form_is_constant)
4602         (attribute::form_is_ref): Now methods.
4603
4604 2020-02-08  Tom Tromey  <tom@tromey.com>
4605
4606         * dwarf2read.c (struct attribute, DW_STRING)
4607         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
4608         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
4609         (attr_form_is_block, attr_form_is_section_offset)
4610         (attr_form_is_constant, attr_form_is_ref): Move.
4611         * dwarf2/attribute.h: New file.
4612         * dwarf2/attribute.c: New file, from dwarf2read.c.
4613         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
4614
4615 2020-02-08  Tom Tromey  <tom@tromey.com>
4616
4617         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
4618         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
4619         Move.
4620         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
4621         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
4622         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
4623         abbrev.c.
4624         * dwarf2/abbrev.h: New file.
4625         * dwarf2/abbrev.c: New file, from dwarf2read.c.
4626         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
4627
4628 2020-02-08  Tom Tromey  <tom@tromey.com>
4629
4630         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
4631         (dwarf2_section_size, dwarf2_get_section_info)
4632         (create_signatured_type_table_from_debug_names)
4633         (create_addrmap_from_aranges, read_debug_names_from_section)
4634         (get_gdb_index_contents_from_section, read_comp_unit_head)
4635         (error_check_comp_unit_head, read_abbrev_offset)
4636         (create_debug_type_hash_table, init_cu_die_reader)
4637         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
4638         (read_comp_units_from_section, create_cus_hash_table)
4639         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4640         (create_dwp_v2_section, dwarf2_rnglists_process)
4641         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
4642         (abbrev_table_read_table, read_indirect_string_at_offset_from)
4643         (read_indirect_string_from_dwz, read_addr_index_1)
4644         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
4645         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4646         (fill_in_loclist_baton): Update.
4647         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
4648         get_containing_section, get_bfd_owner, get_bfd_section,
4649         get_file_name, get_id, get_flags, empty, read>: Declare methods.
4650         (dwarf2_read_section, get_section_name, get_section_file_name)
4651         (get_containing_section, get_section_bfd_owner)
4652         (get_section_bfd_section, get_section_name, get_section_file_name)
4653         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
4654         declare.
4655         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
4656         (dwarf2_section_info::get_bfd_owner)
4657         (dwarf2_section_info::get_bfd_section)
4658         (dwarf2_section_info::get_name)
4659         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
4660         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
4661         (dwarf2_section_info::read): Now methods.
4662         * dwarf-index-write.c (class debug_names): Update.
4663
4664 2020-02-08  Tom Tromey  <tom@tromey.com>
4665
4666         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
4667         Move to dwarf2/section.h.
4668         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
4669         (get_section_bfd_section, get_section_name)
4670         (get_section_file_name, get_section_id, get_section_flags)
4671         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
4672         dwarf2/section.c.
4673         * dwarf2/section.h: New file.
4674         * dwarf2/section.c: New file, from dwarf2read.c.
4675         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
4676
4677 2020-02-08  Tom Tromey  <tom@tromey.com>
4678
4679         * dwarf2read.h (read_unsigned_leb128): Don't declare.
4680         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
4681         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
4682         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
4683         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
4684         * dwarf2/leb.h: New file, from dwarf2read.c.
4685         * dwarf2/leb.c: New file, from dwarf2read.c.
4686         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
4687         Remove.
4688         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
4689         (COMMON_SFILES): Add dwarf2/leb.c.
4690
4691 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
4692
4693         GDB 9.1 released.
4694
4695 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4696
4697         PR gdb/25190:
4698         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
4699         * gdb/remote.c (remote_console_output): Update.
4700         * gdb/ui-file.c (fputs_unfiltered): Rename to...
4701         (ui_file_puts): ...this.
4702         * gdb/ui-file.h (ui_file_puts): Add declaration.
4703         * gdb/utils.c (emit_style_escape): Update.
4704         (flush_wrap_buffer): Update.
4705         (fputs_maybe_filtered): Update.
4706         (fputs_unfiltered): Add function.
4707
4708 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4709
4710         * gdb/event-loop.c (gdb_wait_for_event): Update.
4711         * gdb/printcmd.c (printf_command): Update.
4712         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
4713         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
4714         (gdb_os_flush_stderr): Update.
4715         * gdb/remote.c (remote_console_output): Update.
4716         * gdb/ui-file.c (gdb_flush): Rename to...
4717         (ui_file_flush): ...this.
4718         (stderr_file::write): Update.
4719         (stderr_file::puts): Update.
4720         * gdb/ui-file.h (gdb_flush): Rename to...
4721         (ui_file_flush): ...this.
4722         * gdb/utils.c (gdb_flush): Add function.
4723         * gdb/utils.h (gdb_flush): Add declaration.
4724
4725 2020-02-07  Tom Tromey  <tromey@adacore.com>
4726
4727         PR breakpoints/24915:
4728         * source.c (find_and_open_source): Do not check basenames_may_differ.
4729
4730 2020-02-07  Tom Tromey  <tom@tromey.com>
4731
4732         * README: Update gdbserver documentation.
4733         * gdbserver: Move to top level.
4734         * configure.tgt (build_gdbserver): Remove.
4735         * configure.ac: Remove --enable-gdbserver.
4736         * configure: Rebuild.
4737         * Makefile.in (distclean): Don't mention gdbserver.
4738
4739 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4740
4741         * source-cache.c (source_cache::ensure): Surround
4742         get_plain_source_lines with a try/catch.
4743         (source_cache::get_line_charpos): Get rid of try/catch
4744         and only check for the return value of "ensure".
4745         * tui/tui-source.c (tui_source_window::set_contents):
4746         Simplify "nlines" calculation.
4747
4748 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4749
4750         * MAINTAINERS (Write After Approval): Add myself.
4751
4752 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4753
4754         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
4755         function call.
4756
4757 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4758
4759         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
4760
4761 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
4762
4763         * nat/riscv-linux-tdesc.h: New file.
4764         * nat/riscv-linux-tdesc.c: New file, taking code from...
4765         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4766         ... here.
4767         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
4768         NATDEPFILES.
4769
4770 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
4771
4772         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
4773         we don't set the fake simulator ptid to the null_ptid.
4774
4775 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
4776
4777         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
4778         * gdbthread.h (class thread_info) <resumed>: Likewise.
4779         * infrun.c (resume_1): Likewise.
4780         (proceed): Likewise.
4781         (infrun_thread_stop_requested): Likewise.
4782         (stop_all_threads): Likewise.
4783         (handle_inferior_event): Likewise.
4784         (restart_threads): Likewise.
4785         (finish_step_over): Likewise.
4786         (keep_going_stepped_thread): Likewise.
4787         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
4788         (linux_handle_extended_wait): Likewise.
4789         * record-btrace.c (get_thread_current_frame_id): Likewise.
4790         * record-full.c (record_full_wait_1): Likewise.
4791         * remote.c (remote_target::process_initial_stop_replies): Likewise.
4792         * target.c (target_resume): Likewise.
4793         * thread.c (set_running_thread): Likewise.
4794
4795 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4796
4797         * f-valprint.c (f77_print_array_1): Changed datatype of index
4798         variable to LONGEST from int to enable it to contain bound
4799         values correctly.
4800
4801 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
4802
4803         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
4804         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
4805         offsets according to FLEN determined.
4806         (riscv_linux_nat_target::read_description): Determine FLEN
4807         dynamically.
4808         (riscv_linux_nat_target::fetch_registers): Size regset buffer
4809         according to FLEN determined.
4810         (riscv_linux_nat_target::store_registers): Likewise.
4811
4812 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
4813
4814         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
4815         when reg->group is empty and reggroup is not.
4816
4817 2020-01-31  Tom Tromey  <tromey@adacore.com>
4818
4819         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
4820         Call beneath target's mourn_inferior after unpushing.
4821
4822 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4823
4824         PR tui/9765
4825         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
4826         have enough lines to fill the screen, still return the lowest
4827         address we found.
4828
4829 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4830
4831         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
4832         '-', '<', and '>' commands.
4833
4834 2020-01-29  Pedro Alves  <palves@redhat.com>
4835             Sergio Durigan Junior  <sergiodj@redhat.com>
4836
4837         * infcmd.c (construct_inferior_arguments): Assert that
4838         'argc' is greater than 0.
4839
4840 2020-01-29  Luis Machado  <luis.machado@linaro.org>
4841
4842         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
4843         (BRK_INSN_MASK): Define to 0xd4200000.
4844         (aarch64_program_breakpoint_here_p): New function.
4845         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
4846         * arch-utils.c (default_program_breakpoint_here_p): Moved from
4847         breakpoint.c.
4848         * arch-utils.h (default_program_breakpoint_here_p): Moved from
4849         breakpoint.h
4850         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
4851         call gdbarch_program_breakpoint_here_p.
4852         (program_breakpoint_here): Moved to arch-utils.c, renamed to
4853         default_program_breakpoint_here_p, changed return type to bool and
4854         simplified.
4855         * breakpoint.h (program_breakpoint_here): Moved prototype to
4856         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
4857         return type to bool.
4858         * gdbarch.c: Regenerate.
4859         * gdbarch.h: Regenerate.
4860         * gdbarch.sh (program_breakpoint_here_p): New method.
4861         * infrun.c (handle_signal_stop): Call
4862         gdbarch_program_breakpoint_here_p.
4863
4864 2020-01-26  Tom Tromey  <tom@tromey.com>
4865
4866         * ctfread.c (struct ctf_fp_info): Reindent.
4867         (_initialize_ctfread): Remove.
4868
4869 2020-01-26  Tom Tromey  <tom@tromey.com>
4870
4871         * psymtab.c (partial_map_expand_apply)
4872         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4873         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4874         (psym_print_stats, psym_expand_symtabs_for_function)
4875         (psym_map_symbol_filenames, psym_map_matching_symbols)
4876         (psym_expand_symtabs_matching)
4877         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4878         (maintenance_check_psymtabs): Use new methods.
4879         * psympriv.h (struct partial_symtab) <readin_p,
4880         get_compunit_symtab>: New methods.
4881         <readin, compunit_symtab>: Remove members.
4882         (struct standard_psymtab): New.
4883         (struct legacy_psymtab): Derive from standard_psymtab.
4884         * dwarf2read.h (struct dwarf2_psymtab): Derive from
4885         standard_psymtab.
4886         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
4887
4888 2020-01-26  Tom Tromey  <tom@tromey.com>
4889
4890         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
4891         read_dependencies.  Add assert.
4892         * psymtab.c (partial_symtab::read_dependencies): New method.
4893         * psympriv.h (struct partial_symtab) <read_dependencies>: New
4894         method.
4895         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
4896         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
4897         read_dependencies.
4898         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
4899         Add assert.
4900
4901 2020-01-26  Tom Tromey  <tom@tromey.com>
4902
4903         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
4904         Call expand_psymtab.
4905         (xcoff_read_symtab): Call expand_psymtab.
4906         (xcoff_start_psymtab, xcoff_end_psymtab): Set
4907         legacy_expand_psymtab.
4908         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
4909         method.
4910         (struct legacy_psymtab) <expand_psymtab>: Implement.
4911         <legacy_expand_psymtab>: New member.
4912         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
4913         (parse_partial_symbols): Set legacy_expand_psymtab.
4914         (psymtab_to_symtab_1): Change argument order.  Call
4915         expand_psymtab.
4916         (new_psymtab): Set legacy_expand_psymtab.
4917         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
4918         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
4919         expand_psymtab.
4920         (dwarf2_psymtab::expand_psymtab): Rename from
4921         psymtab_to_symtab_1.  Call expand_psymtab.
4922         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
4923         (dbx_end_psymtab): Likewise.
4924         (dbx_psymtab_to_symtab_1): Change argument order. Call
4925         expand_psymtab.
4926         (dbx_read_symtab): Call expand_psymtab.
4927         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
4928         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
4929         (ctf_psymtab::read_symtab): Call expand_psymtab.
4930
4931 2020-01-26  Tom Tromey  <tom@tromey.com>
4932
4933         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
4934         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
4935         messages.
4936         * mdebugread.c (mdebug_read_symtab): Remove prints.
4937         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
4938         assert.
4939         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
4940
4941 2020-01-26  Tom Tromey  <tom@tromey.com>
4942
4943         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
4944         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
4945         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
4946         legacy_symtab.
4947         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
4948         * psymtab.c (psymtab_to_symtab): Call method.
4949         (dump_psymtab): Update.
4950         * psympriv.h (struct partial_symtab): Add virtual destructor.
4951         <read_symtab>: New method.
4952         (struct legacy_symtab): New.
4953         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
4954         (struct pst_map) <pst>: Now a legacy_psymtab.
4955         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
4956         (new_psymtab): Use legacy_psymtab.
4957         * dwarf2read.h (struct dwarf2_psymtab): New.
4958         (struct dwarf2_per_cu_data) <psymtab>: Use it.
4959         * dwarf2read.c (dwarf2_create_include_psymtab)
4960         (dwarf2_build_include_psymtabs, create_type_unit_group)
4961         (create_partial_symtab, process_psymtab_comp_unit_reader)
4962         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
4963         (set_partial_user): Use dwarf2_psymtab.
4964         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
4965         (psymtab_to_symtab_1, process_full_comp_unit)
4966         (process_full_type_unit, dwarf2_ranges_read)
4967         (dwarf2_get_pc_bounds, psymtab_include_file_name)
4968         (dwarf_decode_lines): Use dwarf2_psymtab.
4969         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
4970         (add_address_entry_worker, write_one_signatured_type)
4971         (recursively_count_psymbols, recursively_write_psymbols)
4972         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
4973         (write_debug_names): Likewise.
4974         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
4975         <pst>: Now a legacy_psymtab.
4976         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
4977         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
4978         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
4979         * ctfread.c (struct ctf_psymtab): New.
4980         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
4981         ctf_psymtab.
4982         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
4983         (create_partial_symtab): Return a ctf_psymtab.
4984         (scan_partial_symbols): Update.
4985
4986 2020-01-26  Tom Tromey  <tom@tromey.com>
4987
4988         * xcoffread.c (xcoff_start_psymtab): Use new.
4989         * psymtab.c (partial_symtab::partial_symtab): New constructor,
4990         renamed from start_psymtab_common.
4991         * psympriv.h (struct partial_symtab): Add new constructor.
4992         (start_psymtab_common): Don't declare.
4993         * mdebugread.c (parse_partial_symbols): Use new.
4994         * dwarf2read.c (create_partial_symtab): Use new.
4995         * dbxread.c (start_psymtab): Use new.
4996         * ctfread.c (create_partial_symtab): Use new.
4997
4998 2020-01-26  Tom Tromey  <tom@tromey.com>
4999
5000         * xcoffread.c (xcoff_end_psymtab): Use new.
5001         * psymtab.c (start_psymtab_common): Use new.
5002         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
5003         Update.
5004         * psympriv.h (struct partial_symtab): Add parameters to
5005         constructor.  Don't inline.
5006         (allocate_psymtab): Don't declare.
5007         * mdebugread.c (new_psymtab): Use new.
5008         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
5009         * dbxread.c (dbx_end_psymtab): Use new.
5010
5011 2020-01-26  Tom Tromey  <tom@tromey.com>
5012
5013         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5014         allocate_psymtab.  Update documentation.
5015         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5016         allocate_psymtab.  Do not use new.
5017         (allocate_psymtab): Use new.  Update.
5018
5019 2020-01-26  Tom Tromey  <tom@tromey.com>
5020
5021         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5022         * psymtab.c (psym_print_stats): Update.
5023         * psympriv.h (struct partial_symtab) <readin,
5024         psymtabs_addrmap_supported, anonymous>: Now bool.
5025         * mdebugread.c (psymtab_to_symtab_1): Update.
5026         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5027         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5028         (process_full_comp_unit, process_full_type_unit): Update.
5029         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5030         * ctfread.c (psymtab_to_symtab): Update.
5031
5032 2020-01-26  Tom Tromey  <tom@tromey.com>
5033
5034         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5035         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5036         * psymtab.c (psymtab_storage): Delete psymtabs.
5037         (psymtab_storage::allocate_psymtab): Use new.
5038         (psymtab_storage::discard_psymtab): Use delete.
5039         * psympriv.h (struct partial_symtab): Add constructor and
5040         initializers.
5041
5042 2020-01-26  Tom Tromey  <tom@tromey.com>
5043
5044         * machoread.c: Do not include psympriv.h.
5045
5046 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5047
5048         * NEWS: Mention the new option and the set/show commands.
5049
5050 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5051
5052         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5053         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5054         (validate_exec_file): New variables, enums, functions.
5055         (exec_file_locate_attach, print_section_info): Style the filenames.
5056         (_initialize_exec): Install show_exec_file_mismatch_command and
5057          set_exec_file_mismatch_command.
5058         * gdbcore.h (validate_exec_file): Declare.
5059         * infcmd.c (attach_command): Call validate_exec_file.
5060         * remote.c ( remote_target::remote_add_inferior): Likewise.
5061
5062 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5063
5064         * frame.c (find_frame_sal): Move call to get_next_frame into more
5065         inner scope.
5066         * inline-frame.c (inilne_state) <inline_state>: Update argument
5067         types.
5068         (inilne_state) <skipped_symbol>: Rename to...
5069         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
5070         (skip_inline_frames): Build vector of skipped symbols and use this
5071         to reate the inline_state.
5072         (inline_skipped_symbol): Add a comment and some assertions, fetch
5073         skipped symbol from the list.
5074
5075 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5076
5077         * buildsym.c (lte_is_less_than): Delete.
5078         (buildsym_compunit::end_symtab_with_blockvector): Create local
5079         lambda function to sort line table entries, and use
5080         std::stable_sort instead of std::sort.
5081         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
5082         markers when looking for a previous line.
5083
5084 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * dwarf2read.c (lnp_state_machine::record_line): Include
5087         end_sequence parameter in debug print out.  Record the line if we
5088         are at an end_sequence marker even if it's not the start of a
5089         statement.
5090         * symmisc.c (maintenance_print_one_line_table): Print end of
5091         sequence markers with 'END' not '0'.
5092
5093 2020-01-24  Pedro Alves  <palves@redhat.com>
5094
5095         PR gdb/25410
5096         * thread.c (scoped_restore_current_thread::restore): Use
5097         switch_to_inferior_no_thread.
5098         * exec.c: Include "progspace-and-thread.h".
5099         (add_target_sections, remove_target_sections):
5100         scoped_restore_current_pspace_and_thread instead of
5101         scoped_restore_current_thread.
5102         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
5103         and aspace to the inferior before calling clone_program_space.
5104         Remove stale comment.
5105
5106 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5107
5108         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
5109         (arm_netbsd_nat_target::fetch_registers): ...this.
5110         (arm_nbsd_nat_target::store_registers): Rename to...
5111         (arm_netbsd_nat_target::store_registers): ...this.
5112
5113 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5114
5115         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5116         register_t.
5117
5118 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5119
5120         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
5121         Update comment.
5122         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
5123         Likewise.
5124         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
5125         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
5126         the correct replacement (iterate_over_regset_sections).
5127         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
5128         Update comment.
5129
5130 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
5131
5132         PR gdb/23718
5133         * gdb/python/python.c (execute_gdb_command): Call
5134         async_enable_stdin in catch block.
5135
5136 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5137
5138         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
5139         SWITCH_THRU_ALL_UIS.
5140
5141 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5142
5143         PR tui/9765
5144         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
5145         comment, add extra parameter, and update to store previous symbol
5146         when appropriate.
5147         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
5148         add extra parameter.
5149         * tui/tui-disasm.c (tui_disassemble): Update header comment,
5150         remove unneeded parameter, add try/catch around gdb_print_insn,
5151         rewrite to add items to asm_lines vector.
5152         (tui_find_backward_disassembly_start_address): New function.
5153         (tui_find_disassembly_address): Updated throughout.
5154         (tui_disasm_window::set_contents): Update for changes to
5155         tui_disassemble.
5156         (tui_disasm_window::do_scroll_vertical): No need to adjust the
5157         number of lines to scroll.
5158
5159 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
5160
5161         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
5162         (SECT_OFF_DATA): Likewise.
5163         (SECT_OFF_RODATA): Likewise.
5164         (SECT_OFF_TEXT): Likewise.
5165         (SECT_OFF_BSS): Likewise.
5166         (struct objfile) <text_section_offset, data_section_offset>: New
5167         methods.
5168         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
5169         objfile::text_section_offset.
5170         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
5171         * coffread.c (coff_symtab_read): Likewise.
5172         (enter_linenos): Likewise.
5173         (process_coff_symbol): Likewise.
5174         * ctfread.c (get_objfile_text_range): Likewise.
5175         * dtrace-probe.c (dtrace_probe::get_relocated_address):
5176         Use objfile::data_section_offset.
5177         * dwarf2-frame.c (execute_cfa_program): Use
5178         objfile::text_section_offset.
5179         (dwarf2_frame_find_fde): Likewise.
5180         * dwarf2read.c (create_addrmap_from_index): Likewise.
5181         (create_addrmap_from_aranges): Likewise.
5182         (dw2_find_pc_sect_compunit_symtab): Likewise.
5183         (process_psymtab_comp_unit_reader): Likewise.
5184         (add_partial_symbol): Likewise.
5185         (add_partial_subprogram): Likewise.
5186         (process_full_comp_unit): Likewise.
5187         (read_file_scope): Likewise.
5188         (read_func_scope): Likewise.
5189         (read_lexical_block_scope): Likewise.
5190         (read_call_site_scope): Likewise.
5191         (dwarf2_rnglists_process): Likewise.
5192         (dwarf2_ranges_process): Likewise.
5193         (dwarf2_ranges_read): Likewise.
5194         (dwarf_decode_lines_1): Likewise.
5195         (new_symbol): Likewise.
5196         (dwarf2_fetch_die_loc_sect_off): Likewise.
5197         (dwarf2_per_cu_text_offset): Likewise.
5198         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5199         * hppa-tdep.c (read_unwind_info): Likewise.
5200         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5201         * psympriv.h (struct partial_symtab): Likewise.
5202         * psymtab.c (find_pc_sect_psymtab): Likewise.
5203         * solib-svr4.c (enable_break): Likewise.
5204         * stap-probe.c (relocate_address): Use
5205         objfile::data_section_offset.
5206         * xcoffread.c (enter_line_range): Use
5207         objfile::text_section_offset.
5208         (read_xcoff_symtab): Likewise.
5209
5210 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5211
5212         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5213         declaration to narrower scopes.
5214
5215 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5216
5217         * darwin-nat.h (struct darwin_exception_msg, enum
5218         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5219         Move up.
5220         (class darwin_nat_target) <wait_1, check_new_threads,
5221         decode_exception_message, decode_message, stop_inferior,
5222         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5223         * darwin-nat.c (darwin_check_new_threads): Rename to...
5224         (darwin_nat_target::check_new_threads): ... this.
5225         (darwin_suspend_inferior_it): Remove.
5226         (darwin_decode_exception_message): Rename to...
5227         (darwin_nat_target::decode_exception_message): ... this.
5228         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5229         (darwin_decode_message): Rename to...
5230         (darwin_nat_target::decode_message): ... this.
5231         (cancel_breakpoint): Rename to...
5232         (darwin_nat_target::cancel_breakpoint): ... this.
5233         (darwin_wait): Rename to...
5234         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5235         instead of iterate_over_inferiors.
5236         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5237         (darwin_stop_inferior): Rename to...
5238         (darwin_nat_target::stop_inferior): ... this.
5239         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5240         (darwin_init_thread_list): Rename to...
5241         (darwin_nat_target::init_thread_list): ... this.
5242         (darwin_ptrace_him): Rename to...
5243         (darwin_nat_target::ptrace_him): ... this.
5244         (darwin_nat_target::create_inferior): Pass lambda function to
5245         fork_inferior.
5246         (darwin_nat_target::detach): Call stop_inferior instead of
5247         darwin_stop_inferior.
5248         * fork-inferior.h (fork_inferior): Change init_trace_fun
5249         parameter to gdb::function_view.
5250         * fork-inferior.c (fork_inferior): Likewise.
5251
5252 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5253
5254         * i386-cygwin-tdep.c (core_process_module_section): Update.
5255         * windows-nat.c (struct lm_info_windows): Add text_offset.
5256         (windows_xfer_shared_libraries): Update.
5257         * windows-tdep.c (windows_xfer_shared_library):
5258         Add text_offset_cached argument.
5259         * windows-tdep.h (windows_xfer_shared_library): Update.
5260
5261 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5262
5263         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5264
5265 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5266
5267         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5268         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5269         replace with range-based for.
5270         (gdbsim_interrupt_inferior): Remove.
5271         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5272         with a range-based for.  Inline code from
5273         gdbsim_interrupt_inferior.
5274
5275 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5276
5277         * infrun.c (proceed): Fix indentation.
5278
5279 2020-01-21  Tom Tromey  <tromey@adacore.com>
5280
5281         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5282         * python/python.c (python_extension_ops): Update.
5283         (gdbpy_colorize): New function.
5284         * python/lib/gdb/__init__.py (colorize): New function.
5285         * extension.h (ext_lang_colorize): Declare.
5286         * extension.c (ext_lang_colorize): New function.
5287         * extension-priv.h (struct extension_language_ops) <colorize>: New
5288         member.
5289         * cli/cli-style.c (_initialize_cli_style): Update help text.
5290
5291 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5292
5293         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5294         <cond>: Change type to bool.
5295         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5296         (aarch64_displaced_step_cb): Likewise.
5297         (aarch64_displaced_step_tb): Likewise.
5298
5299 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5300
5301         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5302         output.
5303
5304 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5305
5306         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5307         <pc_adjust>: Adjust the documentation.
5308         (aarch64_displaced_step_fixup): Check if PC really moved before
5309         adjusting it.
5310
5311 2020-01-19  Tom Tromey  <tom@tromey.com>
5312
5313         * disasm.c (~gdb_disassembler): New destructor.
5314         (gdb_buffered_insn_length): Call disassemble_free_target.
5315         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5316         DISABLE_COPY_AND_ASSIGN.
5317
5318 2020-01-19  Tom Tromey  <tom@tromey.com>
5319
5320         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5321         (die_reader_func_ftype): Remove.
5322         (cutu_reader): New class.
5323         (dw2_get_file_names_reader): Remove "data" parameter.
5324         (dw2_get_file_names): Use cutu_reader.
5325         (create_debug_type_hash_table): Update.
5326         (read_cutu_die_from_dwo): Update comment.
5327         (lookup_dwo_unit): Add dwo_name parameter.
5328         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5329         die_reader_func_ftype and data parameters.
5330         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5331         Remove die_reader_func_ftype and data parameters.
5332         (~cutu_reader): New; from init_cutu_and_read_dies.
5333         (cutu_reader::cutu_reader): Rename from
5334         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5335         and data parameters.
5336         (init_cutu_and_read_dies_simple): Remove.
5337         (struct process_psymtab_comp_unit_data): Remove.
5338         (process_psymtab_comp_unit_reader): Remove data parameter; add
5339         want_partial_unit and pretend_language parameters.
5340         (process_psymtab_comp_unit): Use cutu_reader.
5341         (build_type_psymtabs_reader): Remove data parameter.
5342         (build_type_psymtabs_1): Use cutu_reader.
5343         (process_skeletonless_type_unit): Likewise.
5344         (load_partial_comp_unit_reader): Remove.
5345         (load_partial_comp_unit): Use cutu_reader.
5346         (load_full_comp_unit_reader): Remove.
5347         (load_full_comp_unit): Use cutu_reader.
5348         (struct create_dwo_cu_data): Remove.
5349         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5350         dwo_unit parameters.
5351         (create_cus_hash_table): Use cutu_reader.
5352         (struct dwarf2_read_addr_index_data): Remove.
5353         (dwarf2_read_addr_index_reader): Remove.
5354         (dwarf2_read_addr_index): Use cutu_reader.
5355         (read_signatured_type_reader): Remove.
5356         (read_signatured_type): Use cutu_reader.
5357
5358 2020-01-19  Tom Tromey  <tom@tromey.com>
5359
5360         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5361         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5362         (tui_wrefresh): Declare.
5363         * tui/tui-wingeneral.c (suppress_output): New global.
5364         (tui_suppress_output, ~tui_suppress_output): New constructor and
5365         destructor.
5366         (tui_wrefresh): New function.
5367         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5368         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5369         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5370         method.
5371         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5372         tui_wrefresh.
5373         (tui_data_window::no_refresh): New method.
5374         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5375         (tui_reg_command): Use tui_suppress_output
5376         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5377         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5378         method.
5379         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5380
5381 2020-01-19  Tom Tromey  <tom@tromey.com>
5382
5383         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5384         Handle case where symtab is null.
5385
5386 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5387
5388         * linux-fork.c (one_fork_p): Simplify.
5389
5390 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5391
5392         * top.c (struct qt_args): Remove.
5393         (kill_or_detach): Change return type to void, replace `void *`
5394         parameter with a proper one.
5395         (print_inferior_quit_action):  Likewise.
5396         (quit_confirm): Use range-based for loop to iterate over inferiors.
5397         (quit_force): Likewise.
5398
5399 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5400
5401         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5402         `void *` parameter with proper parameters.
5403         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5404         (print_one_inferior): Change return type to void, replace `void *`
5405         parameter with proper parameters.
5406         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5407         inferiors.
5408         (get_other_inferior): Remove.
5409         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5410         inferiors.
5411
5412 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5413
5414         * mi/mi-interp.c (report_initial_inferior): Remove.
5415         (mi_interp::init): Use range-based for to iterate over inferiors.
5416
5417 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5418
5419         * python/py-inferior.c (build_inferior_list): Remove.
5420         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5421
5422 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5423
5424         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5425         (btrace_stitch_trace): Likewise.
5426         * charset.c (intermediate_encoding): Likewise (vaild).
5427         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5428         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5429         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5430
5431 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5432
5433         * windows-tdep.c (windows_get_tlb_type):
5434         Add rtl_user_process_parameters type.
5435
5436 2020-01-16  Pedro Alves  <palves@redhat.com>
5437             Norbert Lange  <nolange79@gmail.com>
5438
5439         PR build/24805
5440         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5441         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5442         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5443         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5444         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5445         (ps_plog): Redeclare exported functions with default visibility.
5446
5447 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5448
5449         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5450         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5451
5452 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5453
5454         * infcmd.c (post_create_inferior): Use get_thread_regcache
5455         instead of get_current_regcache.
5456
5457 2020-01-14  Tom Tromey  <tom@tromey.com>
5458
5459         PR symtab/12535:
5460         * python/python.c (gdbpy_decode_line): Treat empty string the same
5461         as no argument.
5462
5463 2020-01-14  Tom Tromey  <tom@tromey.com>
5464
5465         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
5466
5467 2020-01-14  Tom Tromey  <tom@tromey.com>
5468
5469         * nat/linux-btrace.c: Don't include <config.h>.
5470         * nat/linux-ptrace.c: Don't include <config.h>.
5471         * nat/x86-linux-dregs.c: Don't include <config.h>.
5472
5473 2020-01-14  Tom Tromey  <tom@tromey.com>
5474
5475         * configure: Rebuild.
5476         * configure.ac: Move many checks to ../gdbsupport/common.m4.
5477
5478 2020-01-14  Tom Tromey  <tom@tromey.com>
5479
5480         * nat/x86-linux-dregs.c: Include configh.h.
5481         * nat/linux-ptrace.c: Include configh.h.
5482         * nat/linux-btrace.c: Include configh.h.
5483         * defs.h: Include config.h, bfd.h.
5484         * configure.ac: Don't source common.host.
5485         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
5486         * configure: Rebuild.
5487         * acinclude.m4: Update path.
5488         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
5489         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
5490         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
5491         (CLIBS): Add LIBSUPPORT.
5492         (CDEPS): Likewise.
5493         (COMMON_SFILES): Remove gdbsupport files.
5494         (HFILES_NO_SRCDIR): Likewise.
5495         (stamp-version): Update path to create-version.sh.
5496         (ALLDEPFILES): Remove gdbsupport files.
5497
5498 2020-01-14  Tom Tromey  <tom@tromey.com>
5499
5500         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
5501         USE_WIN32API when needed.
5502         * configure.ac (USE_WIN32API): Don't define.
5503         (WIN32LIBS): Use WIN32APILIBS.
5504         * configure: Rebuild.
5505
5506 2020-01-14  Tom Tromey  <tom@tromey.com>
5507
5508         * configure: Rebuild.
5509         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
5510
5511 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5512
5513         * skip.c (skip_function_command): Make skip w/o arguments use the
5514         name of the inlined function if pc is inside any inlined function.
5515
5516 2020-01-14  Luis Machado  <luis.machado@linaro.org>
5517
5518         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
5519         * infrun.c (resume_1): Likewise.
5520         (handle_inferior_event): Remove stale comment.
5521         * linux-nat.c (linux_nat_target::resume): Update comments.
5522         (save_stop_reason): Likewise.
5523         (linux_nat_filter_event): Likewise.
5524         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
5525
5526 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5527
5528         * elfread.c (record_minimal_symbol): Set section index to 0 for
5529         non-allocatable sections.
5530
5531
5532 2020-01-13  Ali Tamur <tamur@google.com>
5533
5534         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
5535         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
5536         to gdb::optional.  Update comments.
5537         (dwo_file): Update comments.
5538         (read_attribute): Update API to take an additional out parameter,
5539         need_reprocess.  This is used to mark attributes that need other
5540         attributes (e.g. str_offsets_base) for correct computation which may not
5541         have been read yet.
5542         (read_attribute_reprocess): New function declaration.
5543         (read_addr_index): Likewise.
5544         (read_dwo_str_index): Likewise.
5545         (read_stub_str_index): Likewise.
5546         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5547         (lookup_addr_base): New function definition.
5548         (lookup_ranges_base): Likewise.
5549         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5550         lookup_ranges_base.
5551         (init_cutu_and_read_dies): Update comments.
5552         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5553         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5554         Update comments.
5555         (init_cutu_and_read_dies_simple): Reflect API changes.
5556         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5557         (create_cus_hash_table): Change API to take parent compile unit.
5558         Reflect API changes.
5559         (open_and_init_dwo_file): Reflect API changes.
5560         (dwarf2_get_pc_bounds): Update comments.
5561         (dwarf2_record_block_ranges): Likewise.
5562         (read_full_die_1): Change implementation to reprocess attributes that
5563         need str_offsets_base and addr_base.
5564         (partial_die_info::read): Likewise.
5565         (read_attribute_reprocess): New function definition.
5566         (read_attribute_value): Change API to take an additional out parameter,
5567         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5568         when a non-dwo compile unit has index based attributes.
5569         (read_attribute): Reflect API changes.
5570         (read_addr_index_1): Reflect API changes.  Update comments.
5571         (dwarf2_read_addr_index_data): Reflect API changes.
5572         (dwarf2_read_addr_index): Likewise.
5573         (read_str_index): Change API and implementation.  This becomes a helper
5574         to be used by the new string index related methods.  Update error
5575         message and comments.
5576         (read_dwo_str_index): New function definition.
5577         (read_stub_str_index): Likewise.
5578         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5579         * symfile.h (dwarf2_debug_sections): Likewise.
5580         * xcoffread.c (dwarf2_debug_sections): Likewise.
5581
5582 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5583
5584         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5585         core_reg_sect type to gdb_byte *.
5586         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5587         * cris-tdep.c (fetch_core_registers): Likewise.
5588         * corelow.c (core_target::get_core_register_section): Change
5589         type of `contents` to gdb::byte_vector.
5590
5591 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5592
5593         * tui/tui-wingeneral.c (box_win): Position the title in the center
5594         of the border.
5595
5596 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5597
5598         * corelow.c (core_target::get_core_register_section): Use
5599           std::vector instead of alloca.
5600
5601 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5602
5603         * warning.m4: Add -Wmissing-declarations to build_warnings.
5604         * configure: Re-generate.
5605
5606 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5607
5608         * python/python.c (init__gdb_module): Add declaration.
5609
5610 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5611
5612         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
5613         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
5614         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
5615         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
5616         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
5617         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
5618         * ada-exp.y (_initialize_ada_exp): Add declaration.
5619         * ada-lang.c (_initialize_ada_language): Add declaration.
5620         * ada-tasks.c (_initialize_tasks): Add declaration.
5621         * agent.c (_initialize_agent): Add declaration.
5622         * aix-thread.c (_initialize_aix_thread): Add declaration.
5623         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
5624         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
5625         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
5626         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
5627         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
5628         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
5629         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
5630         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
5631         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
5632         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
5633         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
5634         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
5635         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
5636         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
5637         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
5638         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
5639         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
5640         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
5641         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
5642         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
5643         * annotate.c (_initialize_annotate): Add declaration.
5644         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
5645         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
5646         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
5647         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
5648         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
5649         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
5650         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
5651         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
5652         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
5653         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
5654         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
5655         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
5656         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
5657         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
5658         * auto-load.c (_initialize_auto_load): Add declaration.
5659         * auxv.c (_initialize_auxv): Add declaration.
5660         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
5661         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
5662         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
5663         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
5664         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
5665         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
5666         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
5667         * breakpoint.c (_initialize_breakpoint): Add declaration.
5668         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
5669         * btrace.c (_initialize_btrace): Add declaration.
5670         * charset.c (_initialize_charset): Add declaration.
5671         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
5672         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
5673         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
5674         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
5675         * cli/cli-script.c (_initialize_cli_script): Add declaration.
5676         * cli/cli-style.c (_initialize_cli_style): Add declaration.
5677         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
5678         * coffread.c (_initialize_coffread): Add declaration.
5679         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
5680         * compile/compile.c (_initialize_compile): Add declaration.
5681         * complaints.c (_initialize_complaints): Add declaration.
5682         * completer.c (_initialize_completer): Add declaration.
5683         * copying.c (_initialize_copying): Add declaration.
5684         * corefile.c (_initialize_core): Add declaration.
5685         * corelow.c (_initialize_corelow): Add declaration.
5686         * cp-abi.c (_initialize_cp_abi): Add declaration.
5687         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
5688         * cp-support.c (_initialize_cp_support): Add declaration.
5689         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
5690         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
5691         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
5692         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
5693         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
5694         * ctfread.c (_initialize_ctfread): Add declaration.
5695         * d-lang.c (_initialize_d_language): Add declaration.
5696         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
5697         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
5698         * dbxread.c (_initialize_dbxread): Add declaration.
5699         * dcache.c (_initialize_dcache): Add declaration.
5700         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
5701         * disasm.c (_initialize_disasm): Add declaration.
5702         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
5703         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
5704         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
5705         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
5706         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
5707         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
5708         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
5709         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
5710         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
5711         * elfread.c (_initialize_elfread): Add declaration.
5712         * exec.c (_initialize_exec): Add declaration.
5713         * extension.c (_initialize_extension): Add declaration.
5714         * f-lang.c (_initialize_f_language): Add declaration.
5715         * f-valprint.c (_initialize_f_valprint): Add declaration.
5716         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
5717         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
5718         * filesystem.c (_initialize_filesystem): Add declaration.
5719         * findcmd.c (_initialize_mem_search): Add declaration.
5720         * findvar.c (_initialize_findvar): Add declaration.
5721         * fork-child.c (_initialize_fork_child): Add declaration.
5722         * frame-base.c (_initialize_frame_base): Add declaration.
5723         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
5724         * frame.c (_initialize_frame): Add declaration.
5725         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
5726         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
5727         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
5728         * gcore.c (_initialize_gcore): Add declaration.
5729         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
5730         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
5731         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
5732         * gdbarch.c (_initialize_gdbarch): Add declaration.
5733         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
5734         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
5735         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
5736         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
5737         * go-lang.c (_initialize_go_language): Add declaration.
5738         * go32-nat.c (_initialize_go32_nat): Add declaration.
5739         * guile/guile.c (_initialize_guile): Add declaration.
5740         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
5741         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
5742         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
5743         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
5744         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
5745         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
5746         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
5747         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
5748         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
5749         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
5750         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
5751         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
5752         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
5753         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
5754         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
5755         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
5756         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
5757         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
5758         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
5759         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
5760         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
5761         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
5762         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
5763         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
5764         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
5765         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
5766         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
5767         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
5768         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
5769         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
5770         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
5771         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
5772         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
5773         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
5774         * infcall.c (_initialize_infcall): Add declaration.
5775         * infcmd.c (_initialize_infcmd): Add declaration.
5776         * inflow.c (_initialize_inflow): Add declaration.
5777         * infrun.c (_initialize_infrun): Add declaration.
5778         * interps.c (_initialize_interpreter): Add declaration.
5779         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
5780         * jit.c (_initialize_jit): Add declaration.
5781         * language.c (_initialize_language): Add declaration.
5782         * linux-fork.c (_initialize_linux_fork): Add declaration.
5783         * linux-nat.c (_initialize_linux_nat): Add declaration.
5784         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
5785         * linux-thread-db.c (_initialize_thread_db): Add declaration.
5786         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
5787         * m2-lang.c (_initialize_m2_language): Add declaration.
5788         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
5789         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
5790         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
5791         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
5792         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
5793         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
5794         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
5795         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
5796         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
5797         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
5798         * machoread.c (_initialize_machoread): Add declaration.
5799         * macrocmd.c (_initialize_macrocmd): Add declaration.
5800         * macroscope.c (_initialize_macroscope): Add declaration.
5801         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
5802         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
5803         * maint.c (_initialize_maint_cmds): Add declaration.
5804         * mdebugread.c (_initialize_mdebugread): Add declaration.
5805         * memattr.c (_initialize_mem): Add declaration.
5806         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
5807         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
5808         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
5809         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
5810         * mi/mi-main.c (_initialize_mi_main): Add declaration.
5811         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
5812         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
5813         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
5814         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
5815         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
5816         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
5817         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
5818         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
5819         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
5820         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
5821         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
5822         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
5823         * mipsread.c (_initialize_mipsread): Add declaration.
5824         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
5825         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
5826         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
5827         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
5828         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
5829         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
5830         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
5831         * nto-procfs.c (_initialize_procfs): Add declaration.
5832         * objc-lang.c (_initialize_objc_language): Add declaration.
5833         * observable.c (_initialize_observer): Add declaration.
5834         * opencl-lang.c (_initialize_opencl_language): Add declaration.
5835         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
5836         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
5837         * osabi.c (_initialize_gdb_osabi): Add declaration.
5838         * osdata.c (_initialize_osdata): Add declaration.
5839         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
5840         * parse.c (_initialize_parse): Add declaration.
5841         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
5842         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
5843         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
5844         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
5845         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
5846         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
5847         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
5848         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
5849         * printcmd.c (_initialize_printcmd): Add declaration.
5850         * probe.c (_initialize_probe): Add declaration.
5851         * proc-api.c (_initialize_proc_api): Add declaration.
5852         * proc-events.c (_initialize_proc_events): Add declaration.
5853         * proc-service.c (_initialize_proc_service): Add declaration.
5854         * procfs.c (_initialize_procfs): Add declaration.
5855         * producer.c (_initialize_producer): Add declaration.
5856         * psymtab.c (_initialize_psymtab): Add declaration.
5857         * python/python.c (_initialize_python): Add declaration.
5858         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
5859         * record-btrace.c (_initialize_record_btrace): Add declaration.
5860         * record-full.c (_initialize_record_full): Add declaration.
5861         * record.c (_initialize_record): Add declaration.
5862         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
5863         * regcache.c (_initialize_regcache): Add declaration.
5864         * reggroups.c (_initialize_reggroup): Add declaration.
5865         * remote-notif.c (_initialize_notif): Add declaration.
5866         * remote-sim.c (_initialize_remote_sim): Add declaration.
5867         * remote.c (_initialize_remote): Add declaration.
5868         * reverse.c (_initialize_reverse): Add declaration.
5869         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
5870         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
5871         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
5872         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
5873         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
5874         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
5875         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
5876         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
5877         Add declaration.
5878         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
5879         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
5880         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
5881         * rust-exp.y (_initialize_rust_exp): Add declaration.
5882         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
5883         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
5884         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
5885         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
5886         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
5887         * score-tdep.c (_initialize_score_tdep): Add declaration.
5888         * ser-go32.c (_initialize_ser_dos): Add declaration.
5889         * ser-mingw.c (_initialize_ser_windows): Add declaration.
5890         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
5891         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
5892         * ser-uds.c (_initialize_ser_socket): Add declaration.
5893         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
5894         * serial.c (_initialize_serial): Add declaration.
5895         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
5896         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
5897         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
5898         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
5899         * skip.c (_initialize_step_skip): Add declaration.
5900         * sol-thread.c (_initialize_sol_thread): Add declaration.
5901         * solib-aix.c (_initialize_solib_aix): Add declaration.
5902         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
5903         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
5904         * solib-frv.c (_initialize_frv_solib): Add declaration.
5905         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
5906         * solib-target.c (_initialize_solib_target): Add declaration.
5907         * solib.c (_initialize_solib): Add declaration.
5908         * source-cache.c (_initialize_source_cache): Add declaration.
5909         * source.c (_initialize_source): Add declaration.
5910         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
5911         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
5912         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
5913         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
5914         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
5915         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
5916         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
5917         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
5918         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
5919         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
5920         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
5921         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
5922         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
5923         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
5924         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
5925         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
5926         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
5927         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
5928         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
5929         * stabsread.c (_initialize_stabsread): Add declaration.
5930         * stack.c (_initialize_stack): Add declaration.
5931         * stap-probe.c (_initialize_stap_probe): Add declaration.
5932         * std-regs.c (_initialize_frame_reg): Add declaration.
5933         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
5934         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
5935         * symfile.c (_initialize_symfile): Add declaration.
5936         * symmisc.c (_initialize_symmisc): Add declaration.
5937         * symtab.c (_initialize_symtab): Add declaration.
5938         * target.c (_initialize_target): Add declaration.
5939         * target-connection.c (_initialize_target_connection): Add
5940         declaration.
5941         * target-dcache.c (_initialize_target_dcache): Add declaration.
5942         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
5943         * thread.c (_initialize_thread): Add declaration.
5944         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
5945         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
5946         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
5947         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
5948         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
5949         * tracectf.c (_initialize_ctf): Add declaration.
5950         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
5951         * tracefile.c (_initialize_tracefile): Add declaration.
5952         * tracepoint.c (_initialize_tracepoint): Add declaration.
5953         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
5954         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
5955         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
5956         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
5957         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
5958         * tui/tui-win.c (_initialize_tui_win): Add declaration.
5959         * tui/tui.c (_initialize_tui): Add declaration.
5960         * typeprint.c (_initialize_typeprint): Add declaration.
5961         * ui-style.c (_initialize_ui_style): Add declaration.
5962         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
5963         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
5964         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
5965         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
5966         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
5967         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
5968         * unittests/filtered_iterator-selftests.c
5969         (_initialize_filtered_iterator_selftests): Add declaration.
5970         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
5971         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
5972         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
5973         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
5974         * unittests/main-thread-selftests.c
5975         (_initialize_main_thread_selftests): Add declaration.
5976         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
5977         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
5978         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
5979         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
5980         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
5981         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
5982         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
5983         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
5984         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
5985         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
5986         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
5987         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
5988         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
5989         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
5990         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
5991         declaration.
5992         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
5993         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
5994         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
5995         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
5996         * user-regs.c (_initialize_user_regs): Add declaration.
5997         * utils.c (_initialize_utils): Add declaration.
5998         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
5999         * valops.c (_initialize_valops): Add declaration.
6000         * valprint.c (_initialize_valprint): Add declaration.
6001         * value.c (_initialize_values): Add declaration.
6002         * varobj.c (_initialize_varobj): Add declaration.
6003         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
6004         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
6005         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
6006         * windows-nat.c (_initialize_windows_nat): Add declaration.
6007         (_initialize_check_for_gdb_ini): Add declaration.
6008         (_initialize_loadable): Add declaration.
6009         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
6010         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
6011         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6012         * xcoffread.c (_initialize_xcoffread): Add declaration.
6013         * xml-support.c (_initialize_xml_support): Add declaration.
6014         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6015         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6016         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6017         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6018
6019 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6020
6021         * regformats/regdat.sh: Generate declaration for init function.
6022
6023 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6024
6025         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6026         up.
6027         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6028         close_one_inferior>: New methods.
6029         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6030         pass down target to find_inferior_pid.
6031         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6032         Pass down target to find_inferior_ptid.
6033         (gdbsim_target::create_inferior): Pass down target to
6034         add_thread_silent.
6035         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6036         target down to find_inferior_ptid and switch_to_thread.
6037         (gdbsim_target::close): Update to call close_one_inferior.
6038         (struct resume_data): Remove.
6039         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6040         directly, rather than through a void pointer.
6041         (gdbsim_target::resume): Update to call resume_one_inferior.
6042
6043 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6044
6045         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6046
6047 2020-01-12  Pedro Alves  <palves@redhat.com>
6048
6049         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6050         directly for the current inferior instead of
6051         discard_all_inferiors.
6052         (discard_all_inferiors): Delete.
6053
6054 2020-01-11  Tom Tromey  <tom@tromey.com>
6055
6056         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6057         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6058         deprecated_safe_get_selected_frame.
6059
6060 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6061
6062         * inferior.c (print_inferior): Switch inferior before printing it.
6063
6064 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
6065             Pedro Alves  <palves@redhat.com>
6066
6067         * progspace-and-thread.c (switch_to_program_space_and_thread):
6068         Assert there's an inferior for PSPACE.  Use
6069         switch_to_inferior_no_thread to switch the inferior too.
6070         * progspace.c (program_space::~program_space): Call
6071         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
6072         (program_space::free_all_objfiles): Don't call clear_symtab_users
6073         here.
6074         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
6075
6076 2020-01-10  Pedro Alves  <palves@redhat.com>
6077
6078         * NEWS: Mention multi-target debugging, "info connections", and
6079         "add-inferior -no-connection".
6080
6081 2020-01-10  Pedro Alves  <palves@redhat.com>
6082
6083         * infrun.c: Include "target-connection.h".
6084         (check_multi_target_resumption): New.
6085         (proceed): Call it.
6086         * target-connection.c (make_target_connection_string): Make
6087         extern.
6088         * target-connection.h (make_target_connection_string): Declare.
6089
6090 2020-01-10  Pedro Alves  <palves@redhat.com>
6091
6092         * Makefile.in (COMMON_SFILES): Add target-connection.c.
6093         * inferior.c (uiout_field_connection): New function.
6094         (print_inferior): Add new "connection-id" column.
6095         (add_inferior_command): Show connection number/string of added
6096         inferior.
6097         * process-stratum-target.h
6098         (process_stratum_target::connection_string): New virtual method.
6099         (process_stratum_target::connection_number): New field.
6100         * remote.c (remote_target::connection_string): New override.
6101         * target-connection.c: New file.
6102         * target-connection.h: New file.
6103         * target.c (decref_target): Remove process_stratum targets from
6104         the connection list.
6105         (target_stack::push): Add process_stratum targets to the
6106         connection list.
6107
6108 2020-01-10  Pedro Alves  <palves@redhat.com>
6109
6110         Revert:
6111         2016-04-12  Pedro Alves  <palves@redhat.com>
6112         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
6113         Remove references to name.
6114         * serial.h (struct serial) <name>: Delete.
6115
6116 2020-01-10  Pedro Alves  <palves@redhat.com>
6117
6118         * gdbarch-selftests.c (register_to_value_test): Remove "target
6119         already pushed" check.
6120
6121 2020-01-10  Pedro Alves  <palves@redhat.com>
6122             John Baldwin  <jhb@FreeBSD.org>
6123
6124         * aarch64-linux-nat.c
6125         (aarch64_linux_nat_target::thread_architecture): Adjust.
6126         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
6127         (task_command_1): Likewise.
6128         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
6129         (aix_thread_target::wait, aix_thread_target::fetch_registers)
6130         (aix_thread_target::store_registers)
6131         (aix_thread_target::thread_alive): Adjust.
6132         * amd64-fbsd-tdep.c: Include "inferior.h".
6133         (amd64fbsd_get_thread_local_address): Pass down target.
6134         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
6135         thread's gdbarch instead of target_gdbarch.
6136         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
6137         get_last_target_status.
6138         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
6139         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
6140         inferiors.
6141         (update_inserted_breakpoint_locations): Skip if inferiors with no
6142         execution.
6143         (update_global_location_list): When handling moribund locations,
6144         find representative inferior for location's pspace, and use thread
6145         count of its process_stratum target.
6146         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
6147         * bsd-uthread.c (bsd_uthread_target::wait): Use
6148         as_process_stratum_target and adjust thread_change_ptid and
6149         add_thread calls.
6150         (bsd_uthread_target::update_thread_list): Use
6151         as_process_stratum_target and adjust find_thread_ptid,
6152         thread_change_ptid and add_thread calls.
6153         * btrace.c (maint_btrace_packet_history_cmd): Adjust
6154         find_thread_ptid call.
6155         * corelow.c (add_to_thread_list): Adjust add_thread call.
6156         (core_target_open): Adjust add_thread_silent and thread_count
6157         calls.
6158         (core_target::pid_to_str): Adjust find_inferior_ptid call.
6159         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
6160         * event-top.c (async_disconnect): Pop targets from all inferiors.
6161         * exec.c (add_target_sections): Push exec target on all inferiors
6162         sharing the program space.
6163         (remove_target_sections): Remove the exec target from all
6164         inferiors sharing the program space.
6165         (exec_on_vfork): New.
6166         * exec.h (exec_on_vfork): Declare.
6167         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
6168         Pass it down.
6169         (fbsd_nat_target::update_thread_list): Adjust.
6170         (fbsd_nat_target::resume): Adjust.
6171         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
6172         down.
6173         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
6174         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
6175         get_thread_arch_regcache call.
6176         * fork-child.c (gdb_startup_inferior): Pass target down to
6177         startup_inferior and set_executing.
6178         * gdbthread.h (struct process_stratum_target): Forward declare.
6179         (add_thread, add_thread_silent, add_thread_with_info)
6180         (in_thread_list): Add process_stratum_target parameter.
6181         (find_thread_ptid(inferior*, ptid_t)): New overload.
6182         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
6183         parameter.
6184         (all_threads()): Delete overload.
6185         (all_threads, all_non_exited_threads): Add process_stratum_target
6186         parameter.
6187         (all_threads_safe): Use brace initialization.
6188         (thread_count): Add process_stratum_target parameter.
6189         (set_resumed, set_running, set_stop_requested, set_executing)
6190         (threads_are_executing, finish_thread_state): Add
6191         process_stratum_target parameter.
6192         (switch_to_thread): Use is_current_thread.
6193         * i386-fbsd-tdep.c: Include "inferior.h".
6194         (i386fbsd_get_thread_local_address): Pass down target.
6195         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6196         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6197         have_inferiors check.
6198         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6199         (inf_ptrace_target::attach): Adjust.
6200         * infcall.c (run_inferior_call): Adjust.
6201         * infcmd.c (run_command_1): Pass target to
6202         scoped_finish_thread_state.
6203         (proceed_thread_callback): Skip inferiors with no execution.
6204         (continue_command): Rename 'all_threads' local to avoid hiding
6205         'all_threads' function.  Adjust get_last_target_status call.
6206         (prepare_one_step): Adjust set_running call.
6207         (signal_command): Use user_visible_resume_target.  Compare thread
6208         pointers instead of inferior_ptid.
6209         (info_program_command): Adjust to pass down target.
6210         (attach_command): Mark target's 'thread_executing' flag.
6211         (stop_current_target_threads_ns): New, factored out from ...
6212         (interrupt_target_1): ... this.  Switch inferior before making
6213         target calls.
6214         * inferior-iter.h
6215         (struct all_inferiors_iterator, struct all_inferiors_range)
6216         (struct all_inferiors_safe_range)
6217         (struct all_non_exited_inferiors_range): Filter on
6218         process_stratum_target too.  Remove explicit.
6219         * inferior.c (inferior::inferior): Push dummy target on target
6220         stack.
6221         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6222         Add process_stratum_target parameter, and pass it down.
6223         (have_live_inferiors): Adjust.
6224         (switch_to_inferior_and_push_target): New.
6225         (add_inferior_command, clone_inferior_command): Handle
6226         "-no-connection" parameter.  Use
6227         switch_to_inferior_and_push_target.
6228         (_initialize_inferior): Mention "-no-connection" option in
6229         the help of "add-inferior" and "clone-inferior" commands.
6230         * inferior.h: Include "process-stratum-target.h".
6231         (interrupt_target_1): Use bool.
6232         (struct inferior) <push_target, unpush_target, target_is_pushed,
6233         find_target_beneath, top_target, process_target, target_at,
6234         m_stack>: New.
6235         (discard_all_inferiors): Delete.
6236         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6237         (all_inferiors, all_non_exited_inferiors): Add
6238         process_stratum_target parameter.
6239         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6240         (target_last_proc_target): New global.
6241         (follow_fork_inferior): Push target on new inferior.  Pass target
6242         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6243         reference count.
6244         (follow_fork): Adjust get_last_target_status call.  Also consider
6245         target.
6246         (follow_exec): Push target on new inferior.
6247         (struct execution_control_state) <target>: New field.
6248         (user_visible_resume_target): New.
6249         (do_target_resume): Call target_async.
6250         (resume_1): Set target's threads_executing flag.  Consider resume
6251         target.
6252         (commit_resume_all_targets): New.
6253         (proceed): Also consider resume target.  Skip threads of inferiors
6254         with no execution.  Commit resumtion in all targets.
6255         (start_remote): Pass current inferior to wait_for_inferior.
6256         (infrun_thread_stop_requested): Consider target as well.  Pass
6257         thread_info pointer to clear_inline_frame_state instead of ptid.
6258         (infrun_thread_thread_exit): Consider target as well.
6259         (random_pending_event_thread): New inferior parameter.  Use it.
6260         (do_target_wait): Rename to ...
6261         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6262         down.
6263         (threads_are_resumed_pending_p, do_target_wait): New.
6264         (prepare_for_detach): Adjust calls.
6265         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6266         do_target_wait_1 instead of do_target_wait.
6267         (fetch_inferior_event): Adjust.  Switch to representative
6268         inferior.  Pass target down.
6269         (set_last_target_status): Add process_stratum_target parameter.
6270         Save target in global.
6271         (get_last_target_status): Add process_stratum_target parameter and
6272         handle it.
6273         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6274         (context_switch): Check inferior_ptid == null_ptid before calling
6275         inferior_thread().
6276         (get_inferior_stop_soon): Pass down target.
6277         (wait_one): Rename to ...
6278         (poll_one_curr_target): ... this.
6279         (struct wait_one_event): New.
6280         (wait_one): New.
6281         (stop_all_threads): Adjust.
6282         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6283         event's target.
6284         (switch_back_to_stepped_thread): Also consider target.
6285         (print_stop_event): Update.
6286         (normal_stop): Update.  Also consider the resume target.
6287         * infrun.h (wait_for_inferior): Remove declaration.
6288         (user_visible_resume_target): New declaration.
6289         (get_last_target_status, set_last_target_status): New
6290         process_stratum_target parameter.
6291         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6292         process_stratum_target parameter, and use it.
6293         (clear_inline_frame_state (thread_info*)): New.
6294         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6295         process_stratum_target parameter.
6296         (clear_inline_frame_state (thread_info*)): Declare.
6297         * linux-fork.c (delete_checkpoint_command): Pass target down to
6298         find_thread_ptid.
6299         (checkpoint_command): Adjust.
6300         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6301         instead of just tweaking inferior_ptid.
6302         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6303         (exit_lwp): Pass target down to find_thread_ptid.
6304         (attach_proc_task_lwp_callback): Pass target down to
6305         add_thread/set_running/set_executing.
6306         (linux_nat_target::attach): Pass target down to
6307         thread_change_ptid.
6308         (get_detach_signal): Pass target down to find_thread_ptid.
6309         Consider last target status's target.
6310         (linux_resume_one_lwp_throw, resume_lwp)
6311         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6312         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6313         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6314         (linux_nat_target::async_wait_fd): New.
6315         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6316         target down.
6317         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6318         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6319         * linux-thread-db.c (struct thread_db_info::process_target): New
6320         field.
6321         (add_thread_db_info): Save target.
6322         (get_thread_db_info): New process_stratum_target parameter.  Also
6323         match target.
6324         (delete_thread_db_info): New process_stratum_target parameter.
6325         Also match target.
6326         (thread_from_lwp): Adjust to pass down target.
6327         (thread_db_notice_clone): Pass down target.
6328         (check_thread_db_callback): Pass down target.
6329         (try_thread_db_load_1): Always push the thread_db target.
6330         (try_thread_db_load, record_thread): Pass target down.
6331         (thread_db_target::detach): Pass target down.  Always unpush the
6332         thread_db target.
6333         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6334         target down.  Always unpush the thread_db target.
6335         (find_new_threads_callback, thread_db_find_new_threads_2)
6336         (thread_db_target::update_thread_list): Pass target down.
6337         (thread_db_target::pid_to_str): Pass current inferior down.
6338         (thread_db_target::get_thread_local_address): Pass target down.
6339         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6340         target down.
6341         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6342         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6343         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6344         (procfs_init_inferior): Rename to ...
6345         (procfs_target::procfs_init_inferior): ... this and adjust.
6346         (procfs_target::create_inferior, procfs_notice_thread)
6347         (procfs_do_thread_registers): Adjust.
6348         * ppc-fbsd-tdep.c: Include "inferior.h".
6349         (ppcfbsd_get_thread_local_address): Pass down target.
6350         * proc-service.c (ps_xfer_memory): Switch current inferior and
6351         program space as well.
6352         (get_ps_regcache): Pass target down.
6353         * process-stratum-target.c
6354         (process_stratum_target::thread_address_space)
6355         (process_stratum_target::thread_architecture): Pass target down.
6356         * process-stratum-target.h
6357         (process_stratum_target::threads_executing): New field.
6358         (as_process_stratum_target): New.
6359         * ravenscar-thread.c
6360         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6361         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6362         down.
6363         * record-btrace.c (record_btrace_target::info_record): Adjust.
6364         (record_btrace_target::record_method)
6365         (record_btrace_target::record_is_replaying)
6366         (record_btrace_target::fetch_registers)
6367         (get_thread_current_frame_id, record_btrace_target::resume)
6368         (record_btrace_target::wait, record_btrace_target::stop): Pass
6369         target down.
6370         * record-full.c (record_full_wait_1): Switch to event thread.
6371         Pass target down.
6372         * regcache.c (regcache::regcache)
6373         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6374         process_stratum_target parameter and handle it.
6375         (current_thread_target): New global.
6376         (get_thread_regcache): Add process_stratum_target parameter and
6377         handle it.  Switch inferior before calling target method.
6378         (get_thread_regcache): Pass target down.
6379         (get_thread_regcache_for_ptid): Pass target down.
6380         (registers_changed_ptid): Add process_stratum_target parameter and
6381         handle it.
6382         (registers_changed_thread, registers_changed): Pass target down.
6383         (test_get_thread_arch_aspace_regcache): New.
6384         (current_regcache_test): Define a couple local test_target_ops
6385         instances and use them for testing.
6386         (readwrite_regcache): Pass process_stratum_target parameter.
6387         (cooked_read_test, cooked_write_test): Pass mock_target down.
6388         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6389         (get_thread_arch_aspace_regcache): Add process_stratum_target
6390         parameter.
6391         (regcache::target): New method.
6392         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6393         (regcache::registers_changed_ptid): Add process_stratum_target
6394         parameter.
6395         (regcache::m_target): New field.
6396         (registers_changed_ptid): Add process_stratum_target parameter.
6397         * remote.c (remote_state::supports_vCont_probed): New field.
6398         (remote_target::async_wait_fd): New method.
6399         (remote_unpush_and_throw): Add remote_target parameter.
6400         (get_current_remote_target): Adjust.
6401         (remote_target::remote_add_inferior): Push target.
6402         (remote_target::remote_add_thread)
6403         (remote_target::remote_notice_new_inferior)
6404         (get_remote_thread_info): Pass target down.
6405         (remote_target::update_thread_list): Skip threads of inferiors
6406         bound to other targets.  (remote_target::close): Don't discard
6407         inferiors.  (remote_target::add_current_inferior_and_thread)
6408         (remote_target::process_initial_stop_replies)
6409         (remote_target::start_remote)
6410         (remote_target::remote_serial_quit_handler): Pass down target.
6411         (remote_target::remote_unpush_target): New remote_target
6412         parameter.  Unpush the target from all inferiors.
6413         (remote_target::remote_unpush_and_throw): New remote_target
6414         parameter.  Pass it down.
6415         (remote_target::open_1): Check whether the current inferior has
6416         execution instead of checking whether any inferior is live.  Pass
6417         target down.
6418         (remote_target::remote_detach_1): Pass down target.  Use
6419         remote_unpush_target.
6420         (extended_remote_target::attach): Pass down target.
6421         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6422         (remote_target::append_resumption): Pass down target.
6423         (remote_target::append_pending_thread_resumptions)
6424         (remote_target::remote_resume_with_hc, remote_target::resume)
6425         (remote_target::commit_resume): Pass down target.
6426         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6427         (remote_target::interrupt_query)
6428         (remote_target::remove_new_fork_children)
6429         (remote_target::check_pending_events_prevent_wildcard_vcont)
6430         (remote_target::remote_parse_stop_reply)
6431         (remote_target::process_stop_reply): Pass down target.
6432         (first_remote_resumed_thread): New remote_target parameter.  Pass
6433         it down.
6434         (remote_target::wait_as): Pass down target.
6435         (unpush_and_perror): New remote_target parameter.  Pass it down.
6436         (remote_target::readchar, remote_target::remote_serial_write)
6437         (remote_target::getpkt_or_notif_sane_1)
6438         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6439         down target.
6440         (remote_target::mourn_inferior): Pass down target.  Use
6441         remote_unpush_target.
6442         (remote_target::core_of_thread)
6443         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6444         (remote_target::pid_to_exec_file)
6445         (remote_target::thread_handle_to_thread_info): Pass down target.
6446         (remote_target::async_wait_fd): New.
6447         * riscv-fbsd-tdep.c: Include "inferior.h".
6448         (riscv_fbsd_get_thread_local_address): Pass down target.
6449         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6450         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6451         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6452         Adjust.
6453         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6454         * solib-svr4.c (enable_break): Pass down target.
6455         * spu-multiarch.c (parse_spufs_run): Pass down target.
6456         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
6457         * target-delegates.c: Regenerate.
6458         * target.c (g_target_stack): Delete.
6459         (current_top_target): Return the current inferior's top target.
6460         (target_has_execution_1): Refer to the passed-in inferior's top
6461         target.
6462         (target_supports_terminal_ours): Check whether the initial
6463         inferior was already created.
6464         (decref_target): New.
6465         (target_stack::push): Incref/decref the target.
6466         (push_target, push_target, unpush_target): Adjust.
6467         (target_stack::unpush): Defref target.
6468         (target_is_pushed): Return bool.  Adjust to refer to the current
6469         inferior's target stack.
6470         (dispose_inferior): Delete, and inline parts ...
6471         (target_preopen): ... here.  Only dispose of the current inferior.
6472         (target_detach): Hold strong target reference while detaching.
6473         Pass target down.
6474         (target_thread_name): Add assertion.
6475         (target_resume): Pass down target.
6476         (target_ops::beneath, find_target_at): Adjust to refer to the
6477         current inferior's target stack.
6478         (get_dummy_target): New.
6479         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
6480         has a thread running.
6481         (initialize_targets): Rename to ...
6482         (_initialize_target): ... this.
6483         * target.h: Include "gdbsupport/refcounted-object.h".
6484         (struct target_ops): Inherit refcounted_object.
6485         (target_ops::shortname, target_ops::longname): Make const.
6486         (target_ops::async_wait_fd): New method.
6487         (decref_target): Declare.
6488         (struct target_ops_ref_policy): New.
6489         (target_ops_ref): New typedef.
6490         (get_dummy_target): Declare function.
6491         (target_is_pushed): Return bool.
6492         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
6493         (all_matching_threads_iterator::all_matching_threads_iterator):
6494         Handle filter target.
6495         * thread-iter.h (struct all_matching_threads_iterator, struct
6496         all_matching_threads_range, class all_non_exited_threads_range):
6497         Filter by target too.  Remove explicit.
6498         * thread.c (threads_executing): Delete.
6499         (inferior_thread): Pass down current inferior.
6500         (clear_thread_inferior_resources): Pass down thread pointer
6501         instead of ptid_t.
6502         (add_thread_silent, add_thread_with_info, add_thread): Add
6503         process_stratum_target parameter.  Use it for thread and inferior
6504         searches.
6505         (is_current_thread): New.
6506         (thread_info::deletable): Use it.
6507         (find_thread_ptid, thread_count, in_thread_list)
6508         (thread_change_ptid, set_resumed, set_running): New
6509         process_stratum_target parameter.  Pass it down.
6510         (set_executing): New process_stratum_target parameter.  Pass it
6511         down.  Adjust reference to 'threads_executing'.
6512         (threads_are_executing): New process_stratum_target parameter.
6513         Adjust reference to 'threads_executing'.
6514         (set_stop_requested, finish_thread_state): New
6515         process_stratum_target parameter.  Pass it down.
6516         (switch_to_thread): Also match inferior.
6517         (switch_to_thread): New process_stratum_target parameter.  Pass it
6518         down.
6519         (update_threads_executing): Reimplement.
6520         * top.c (quit_force): Pop targets from all inferior.
6521         (gdb_init): Don't call initialize_targets.
6522         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
6523         Declare.
6524         (windows_add_thread, windows_delete_thread): Adjust.
6525         (get_windows_debug_event): Rename to ...
6526         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
6527         * tracefile-tfile.c (tfile_target_open): Pass down target.
6528         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
6529         Forward declare.
6530         (switch_to_thread): Add process_stratum_target parameter.
6531         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
6532         parameter.  Use it.
6533         (mi_on_resume): Pass target down.
6534         * nat/fork-inferior.c (startup_inferior): Add
6535         process_stratum_target parameter.  Pass it down.
6536         * nat/fork-inferior.h (startup_inferior): Add
6537         process_stratum_target parameter.
6538         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6539
6540 2020-01-10  Pedro Alves  <palves@redhat.com>
6541
6542         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6543         directly.  Instead find the first thread in the thread list and
6544         use switch_to_thread.
6545
6546 2020-01-10  Pedro Alves  <palves@redhat.com>
6547
6548         * remote.c (remote_target::remote_add_inferior): Don't bind a
6549         process to the current inferior if the current inferior is already
6550         bound to a process.
6551
6552 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6553             Pedro Alves  <palves@redhat.com>
6554
6555         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6556         If no process is specified, return null_ptid instead of
6557         inferior_ptid.
6558         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6559         TARGET_WAITKIND_SIGNALLED with no pid.
6560
6561 2020-01-10  Pedro Alves  <palves@redhat.com>
6562
6563         * remote.c (first_remote_resumed_thread): New.
6564         (remote_target::wait_as): Use it as default event_ptid instead of
6565         inferior_ptid.
6566
6567 2020-01-10  Pedro Alves  <palves@redhat.com>
6568
6569         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6570
6571 2020-01-10  Pedro Alves  <palves@redhat.com>
6572
6573         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6574         not -1.
6575
6576 2020-01-10  Pedro Alves  <palves@redhat.com>
6577
6578         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6579         ptid to get_last_target_status.
6580         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6581         ptid to get_last_target_status.
6582         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6583         get_last_target_status.
6584         (info_program_command): Don't pass a target_waitstatus to
6585         get_last_target_status.
6586         * infrun.c (init_wait_for_inferior): Use
6587         nullify_last_target_wait_ptid.
6588         (get_last_target_status): Handle nullptr arguments.
6589         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6590         (print_stop_event): Don't pass a ptid to get_last_target_status.
6591         (normal_stop): Don't pass a ptid to get_last_target_status.
6592         * infrun.h (get_last_target_status, set_last_target_status): Move
6593         comments here and update.
6594         (nullify_last_target_wait_ptid): Declare.
6595         * linux-fork.c (fork_load_infrun_state): Remove local extern
6596         declaration of nullify_last_target_wait_ptid.
6597         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6598         to get_last_target_status.
6599
6600 2020-01-10  Pedro Alves  <palves@redhat.com>
6601
6602         * gdbthread.h (scoped_restore_current_thread)
6603         <dont_restore, restore, m_dont_restore>: Declare.
6604         * thread.c (thread_alive): Add assertion.  Return bool.
6605         (switch_to_thread_if_alive): New.
6606         (prune_threads): Switch inferior/thread.
6607         (print_thread_info_1): Switch thread before calling target methods.
6608         (scoped_restore_current_thread::restore): New, factored out from
6609         ...
6610         (scoped_restore_current_thread::~scoped_restore_current_thread):
6611         ... this.
6612         (scoped_restore_current_thread::scoped_restore_current_thread):
6613         Add assertion.
6614         (thread_apply_all_command, thread_select): Use
6615         switch_to_thread_if_alive.
6616         * infrun.c (proceed, restart_threads, handle_signal_stop)
6617         (switch_back_to_stepped_thread): Switch current thread before
6618         calling target methods.
6619
6620 2020-01-10  Pedro Alves <palves@redhat.com>
6621
6622         * inferior.c (switch_to_inferior_no_thread): New function,
6623         factored out from ...
6624         (inferior_command): ... here.
6625         * inferior.h (switch_to_inferior_no_thread): Declare.
6626         * mi/mi-main.c (run_one_inferior): Use
6627         switch_to_inferior_no_thread.
6628
6629 2020-01-10  Pedro Alves  <palves@redhat.com>
6630
6631         * infcmd.c (kill_command): Remove dead code.
6632
6633 2020-01-10  Pedro Alves  <palves@redhat.com>
6634
6635         * remote.c (remote_target::mourn_inferior): No longer check
6636         whether the target is running.
6637
6638 2020-01-10  Pedro Alves  <palves@redhat.com>
6639
6640         * corelow.c (core_target::has_execution): Change parameter type to
6641         inferior pointer.
6642         * inferior.c (number_of_live_inferiors): Use
6643         inferior::has_execution instead of target_has_execution_1.
6644         * inferior.h (inferior::has_execution): New.
6645         * linux-thread-db.c (thread_db_target::update_thread_list): Use
6646         inferior::has_execution instead of target_has_execution_1.
6647         * process-stratum-target.c
6648         (process_stratum_target::has_execution): Change parameter type to
6649         inferior pointer.  Check the inferior's PID instead of
6650         inferior_ptid.
6651         * process-stratum-target.h
6652         (process_stratum_target::has_execution): Change parameter type to
6653         inferior pointer.
6654         * record-full.c (record_full_core_target::has_execution): Change
6655         parameter type to inferior pointer.
6656         * target.c (target_has_execution_1): Change parameter type to
6657         inferior pointer.
6658         (target_has_execution_current): Adjust.
6659         * target.h (target_ops::has_execution): Change parameter type to
6660         inferior pointer.
6661         (target_has_execution_1): Change parameter type to inferior
6662         pointer.  Change return type to bool.
6663         * tracefile.h (tracefile_target::has_execution): Change parameter
6664         type to inferior pointer.
6665
6666 2020-01-10  Pedro Alves  <palves@redhat.com>
6667
6668         * exceptions.c (print_flush): Remove current_top_target() check.
6669
6670 2020-01-10  Pedro Alves  <palves@redhat.com>
6671
6672         * remote.c (show_remote_exec_file): Show the current inferior's
6673         exec-file instead of the command variable's value.
6674
6675 2020-01-10  Pedro Alves  <palves@redhat.com>
6676
6677         * record-full.c (record_full_resume_ptid): New global.
6678         (record_full_target::resume): Set it.
6679         (record_full_wait_1): Use record_full_resume_ptid instead of
6680         inferior_ptid.
6681
6682 2020-01-10  Pedro Alves  <palves@redhat.com>
6683
6684         * gdbthread.h (scoped_restore_current_thread)
6685         <dont_restore, restore, m_dont_restore>: Declare.
6686         * thread.c (thread_alive): Add assertion.  Return bool.
6687         (switch_to_thread_if_alive): New.
6688         (prune_threads): Switch inferior/thread.
6689         (print_thread_info_1): Switch thread before calling target methods.
6690         (scoped_restore_current_thread::restore): New, factored out from
6691         ...
6692         (scoped_restore_current_thread::~scoped_restore_current_thread):
6693         ... this.
6694         (scoped_restore_current_thread::scoped_restore_current_thread):
6695         Add assertion.
6696         (thread_apply_all_command, thread_select): Use
6697         switch_to_thread_if_alive.
6698
6699 2020-01-10  George Barrett  <bob@bob131.so>
6700
6701         * stap-probe.c (stap_modify_semaphore): Don't check for null
6702         semaphores.
6703         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
6704         for null semaphores.
6705
6706 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6707
6708         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
6709         all source windows, and maintain horizontal scroll status while
6710         doing so.
6711
6712 2020-01-09  Tom Tromey  <tom@tromey.com>
6713
6714         PR tui/18932:
6715         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
6716         update_source_window, not print_source_lines.
6717
6718 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6719
6720         * tui/tui.c (tui_enable): Register tui hooks after calling
6721         tui_display_main.
6722
6723 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6724
6725         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
6726
6727 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
6728
6729         * thread.c (print_thread_info_1): Fix indentation.
6730
6731 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6732
6733         * symtab.c (general_symbol_info::compute_and_set_names): Move the
6734         unique_xmalloc_ptr outside the if to always free the demangled name.
6735
6736 2020-01-08  Tom Tromey  <tromey@adacore.com>
6737
6738         * xcoffread.c (enter_line_range, read_xcoff_symtab)
6739         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
6740         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
6741         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
6742         Remove.
6743         (section_offsets): New typedef.
6744         * symtab.c (fixup_section, get_msymbol_address): Update.
6745         * symmisc.c (dump_msymbols): Update.
6746         * symfile.h (relative_addr_info_to_section_offsets)
6747         (symfile_map_offsets_to_segments): Update.
6748         * symfile.c (build_section_addr_info_from_objfile)
6749         (init_objfile_sect_indices): Update.
6750         (struct place_section_arg): Change type of "offsets".
6751         (place_section): Update.
6752         (relative_addr_info_to_section_offsets): Change type of
6753         "section_offsets".  Remove "num_sections" parameter.
6754         (default_symfile_offsets, syms_from_objfile_1)
6755         (set_objfile_default_section_offset): Update.
6756         (reread_symbols): No need to preserve section offsets by hand.
6757         (symfile_map_offsets_to_segments): Change type of "offsets".
6758         * stap-probe.c (relocate_address): Update.
6759         * stabsread.h (process_one_symbol): Update.
6760         * solib-target.c (struct lm_info_target) <offsets>: Change type.
6761         (solib_target_relocate_section_addresses): Update.
6762         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
6763         Update.
6764         * solib-frv.c (frv_relocate_main_executable): Update.
6765         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
6766         * solib-aix.c (solib_aix_get_section_offsets): Change return
6767         type.
6768         (solib_aix_solib_create_inferior_hook): Update.
6769         * remote.c (remote_target::get_offsets): Update.
6770         * psymtab.c (find_pc_sect_psymtab): Update.
6771         * psympriv.h (struct partial_symbol) <address, text_low,
6772         text_high>: Update.
6773         * objfiles.h (obj_section_offset): Update.
6774         (struct objfile) <section_offsets>: Change type.
6775         <num_sections>: Remove.
6776         (objfile_relocate): Update.
6777         * objfiles.c (entry_point_address_query): Update
6778         (relocate_one_symbol): Change type of "section_offsets".
6779         (objfile_relocate1, objfile_relocate1): Change type of
6780         "new_offsets".
6781         (objfile_rebase1): Update.
6782         * mipsread.c (mipscoff_symfile_read): Update.
6783         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
6784         parameter.
6785         * mdebugread.c (parse_symbol): Change type of "section_offsets".
6786         (parse_external, psymtab_to_symtab_1): Update.
6787         * machoread.c (macho_symfile_offsets): Update.
6788         * ia64-tdep.c (ia64_find_unwind_table): Update.
6789         * hppa-tdep.c (read_unwind_info): Update.
6790         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
6791         * dwarf2read.c (create_addrmap_from_index)
6792         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6793         (process_psymtab_comp_unit_reader, add_partial_symbol)
6794         (add_partial_subprogram, process_full_comp_unit)
6795         (read_file_scope, read_func_scope, read_lexical_block_scope)
6796         (read_call_site_scope, dwarf2_rnglists_process)
6797         (dwarf2_ranges_process, dwarf2_ranges_read)
6798         (dwarf_decode_lines_1, var_decode_location, new_symbol)
6799         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
6800         Update.
6801         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
6802         Update.
6803         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
6804         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
6805         (process_one_symbol): Change type of "section_offsets".
6806         * ctfread.c (get_objfile_text_range): Update.
6807         * coffread.c (coff_symtab_read, enter_linenos)
6808         (process_coff_symbol): Update.
6809         * coff-pe-read.c (add_pe_forwarded_sym): Update.
6810         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
6811
6812 2020-01-08  Tom Tromey  <tromey@adacore.com>
6813
6814         * dwarf2read.c (parse_macro_definition): Use std::string.
6815         (parse_macro_definition): Likewise.
6816
6817 2020-01-08  Tom Tromey  <tromey@adacore.com>
6818
6819         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
6820         (ATTR_ALLOC_CHUNK): Remove.
6821
6822 2020-01-08  Tom Tromey  <tromey@adacore.com>
6823
6824         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
6825
6826 2020-01-08  Tom Tromey  <tromey@adacore.com>
6827
6828         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
6829         (dwarf2_compute_name, open_dwo_file): Likewise.
6830         (process_enumeration_scope): Use std::vector.
6831         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
6832         (partial_die_info::fixup, dwarf2_start_subfile)
6833         (guess_full_die_structure_name, dwarf2_name): Likewise.
6834         (determine_prefix): Update.
6835         (guess_full_die_structure_name): Make return type const.
6836         (partial_die_full_name): Return unique_xmalloc_ptr.
6837         (DW_FIELD_ALLOC_CHUNK): Remove.
6838
6839 2020-01-07  Tom Tromey  <tromey@adacore.com>
6840
6841         PR build/24937:
6842         * stap-probe.c (class stap_static_probe_ops): Add constructor.
6843
6844 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6845
6846         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
6847
6848 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6849
6850         * stack.c (print_frame_info): Move disassemble_next_line code
6851         inside source_print block.
6852
6853 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6854
6855         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
6856         gdb/signals.h, as we are now using native signal symbols.
6857
6858 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6859
6860         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
6861         overflow by an early check of content vs threshold.
6862         * tui/tui-source.c (tui_source_window::line_is_displayed):
6863         Likewise.
6864
6865 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6866
6867         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
6868
6869 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6870
6871         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
6872         export table if no section contains it's RVA.
6873
6874 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6875
6876         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
6877
6878 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
6879
6880         * source.c (print_source_lines_base): Set last_line_listed.
6881
6882 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6883
6884         * tui/tui-disasm.c: Remove trailing spaces.
6885
6886 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6887             Pedro Alves  <palves@redhat.com>
6888
6889         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
6890         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
6891         (windows_gdb_signal_to_target): New function, uses the above
6892         enumeration to convert GDB internal signal codes to equivalent
6893         Windows codes.
6894         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
6895         * windows-nat.c: Include "gdb_wait.h".
6896         (get_windows_debug_event): Extract the fatal exception from the
6897         exit status and convert to the equivalent Posix signal number.
6898         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
6899         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
6900         * gdbsupport/gdb_wait.c: New file, implements
6901         windows_status_to_termsig.
6902         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
6903         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
6904
6905 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6906
6907         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
6908         show_layout.
6909
6910 2020-01-05  Luis Machado  <luis.machado@linaro.org>
6911
6912         * aarch64-linux-nat.c
6913         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
6914         and bfd_mach_aarch64.
6915
6916 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6917
6918         * ui-file.c (stdio_file::can_emit_style_escape)
6919         (tee_file::can_emit_style_escape): Ensure style is used also on
6920         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
6921         to gdb_stdout.
6922         * main.c (set_gdb_data_directory): Use file style to output the
6923         warning that the given pathname is not a directory.
6924         * top.c (show_history_filename, gdb_safe_append_history)
6925         (show_gdb_datadir): Use file style.
6926
6927 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6928
6929         * solib-target.c (struct lm_info_target):
6930         Change offsets to be a unique_xmalloc_ptr.
6931         (solib_target_relocate_section_addresses): Update.
6932
6933 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6934
6935         * windows-nat.c (windows_clear_solib): Free so_list linked list.
6936
6937 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6938
6939         * MAINTAINERS (Write After Approval): Add myself.
6940
6941 2020-01-02  Luis Machado  <luis.machado@linaro.org>
6942
6943         * proc-service.c (get_ps_regcache): Remove reference to obsolete
6944         Cell BE architecture.
6945         * target.h (struct target_ops) <thread_architecture>: Likewise.
6946
6947 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6948
6949         * Makefile.in: Use INSTALL_PROGRAM_ENV.
6950
6951 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6952
6953         * MAINTAINERS (Write After Approval): Add myself.
6954
6955 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6956
6957         * gdbarch.sh: Update copyright year range of generated files.
6958
6959 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6960
6961         Update copyright year range in all GDB files.
6962
6963 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6964
6965         * copyright.py: Convert to Python 3.
6966
6967 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6968
6969         * copyright.py: Adapt after move of gnulib directory from gdb
6970         directory to toplevel directory.
6971
6972 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6973
6974         * copyright.py (main): Exit if run from the wrong directory.
6975
6976 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6977
6978         * top.c (print_gdb_version): Change copyright year to 2020.
6979
6980 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6981
6982         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
6983
6984 For older changes see ChangeLog-2019.
6985 \f
6986 Local Variables:
6987 mode: change-log
6988 left-margin: 8
6989 fill-column: 74
6990 version-control: never
6991 coding: utf-8
6992 End: