gdb/ChangeLog

   1 2019-05-08  Tom Tromey  <tom@tromey.com>
   2
   3         * inflow.c (struct terminal_info): Add destructor and
   4         initializers.
   5         (inflow_inferior_data): Change type.
   6         (~terminal_info): Rename from inflow_inferior_data_cleanup.
   7         (get_inflow_inferior_data, inflow_inferior_exit)
   8         (swap_terminal_info, _initialize_inflow): Update.
   9
  10 2019-05-08  Tom Tromey  <tom@tromey.com>
  11
  12         * target-dcache.c (target_dcache_cleanup): Remove.
  13         (target_dcache_aspace_key): Change type.
  14         (target_dcache_init_p, target_dcache_invalidate)
  15         (target_dcache_get, target_dcache_get_or_init)
  16         (_initialize_target_dcache): Update.
  17         * dcache.h (struct dcache_deleter): New.
  18
  19 2019-05-08  Tom Tromey  <tom@tromey.com>
  20
  21         * symtab.c (struct symbol_cache): Add destructor and
  22         initializers.
  23         (symbol_cache_key): Move.  Change type.
  24         (make_symbol_cache, free_symbol_cache): Remove.
  25         (get_symbol_cache): Update.
  26         (symbol_cache_cleanup): Remove.
  27         (ALL_PSPACES, symbol_cache_flush)
  28         (maintenance_print_symbol_cache)
  29         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
  30         Update.
  31
  32 2019-05-08  Tom Tromey  <tom@tromey.com>
  33
  34         * symtab.c (struct main_info): Add destructor and initializers.
  35         (main_progspace_key): Move.  Change type.
  36         (get_main_info): Update.
  37         (main_info_cleanup): Remove.
  38         (_initialize_symtab): Update.
  39
  40 2019-05-08  Tom Tromey  <tom@tromey.com>
  41
  42         * registry.h (DECLARE_REGISTRY): Define the _key class.
  43
  44 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
  45
  46         * NEWS: Merge two 'New commands' sections.
  47
  48 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
  49
  50         * ada-valprint.c (ada_val_print_gnat_array): Remove language
  51         parameter and use Ada language definition instead.
  52         (ada_val_print_ptr): Remove unused language parameter.
  53         (ada_val_print_num): Remove language parameter and use Ada language
  54         definition instead.
  55         (ada_val_print_enum, ada_val_print_flt): Remove unused language
  56         parameter.
  57         (ada_val_print_struct_union, ada_val_print_ref): Remove language
  58         parameter and use Ada language definition instead.
  59         (ada_val_print_1): Update all ada_val_print_xxx calls.
  60         Remove language parameter.
  61         (ada_val_print): Update ada_val_print_1 call.
  62
  63 2019-05-08  Tom Tromey  <tromey@adacore.com>
  64
  65         * remote.c (remote_hw_watchpoint_limit)
  66         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
  67         Now static.
  68
  69 2019-05-08  Tom Tromey  <tromey@adacore.com>
  70
  71         * maint.c (_initialize_maint_cmds): Move initialization code to
  72         remote.c.
  73         (watchdog, show_watchdog): Move to remote.c.
  74         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
  75         "watchdog" static.
  76         (_initialize_remote): Move initialization code from maint.c.
  77         * defs.h (watchdog): Don't declare.
  78
  79 2019-05-08  Tom Tromey  <tromey@adacore.com>
  80
  81         * tui/tui-interp.c: Include main.h.
  82         * interps.c: Include main.h.
  83         * main.h (interpreter_p): Declare.
  84         * defs.h (interpreter_p): Don't declare.
  85
  86 2019-05-08  Tom Tromey  <tromey@adacore.com>
  87
  88         * dwarf2loc.c: Include dwarf2read.h.
  89         * defs.h (read_unsigned_leb128): Don't declare.
  90         * dwarf2read.h (read_unsigned_leb128): Declare.
  91
  92 2019-05-08  Tom Tromey  <tromey@adacore.com>
  93
  94         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
  95         method.
  96
  97 2019-05-08  Tom Tromey  <tromey@adacore.com>
  98
  99         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 100         when no wrap column is set.
 101
 102 2019-05-08  Tom Tromey  <tromey@adacore.com>
 103
 104         * c-lang.c (c_get_string): Handle non-C-style arrays.
 105
 106 2019-05-08  Tom Tromey  <tromey@adacore.com>
 107
 108         * typeprint.c (print_offset_data::update): Print the bit offset,
 109         not the number of bits remaining.
 110
 111 2019-05-08  Tom Tromey  <tromey@adacore.com>
 112
 113         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 114         padding at end of comment.
 115
 116 2019-05-08  Tom Tromey  <tromey@adacore.com>
 117
 118         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
 119         Compare main types.
 120
 121 2019-05-06  Tom Tromey  <tom@tromey.com>
 122
 123         * common/scoped_mmap.c: Include common-defs.h.
 124         * common/scoped_mmap.h: Don't include config.h.
 125
 126 2019-05-04  Tom Tromey  <tom@tromey.com>
 127
 128         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
 129         (struct aarch64_call_info): Add initializers.
 130         <si>: Now a std::vector.
 131         (pass_on_stack, aarch64_push_dummy_call): Update.
 132
 133 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
 134             Tom Tromey  <tom@tromey.com>
 135
 136         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
 137         (ppc_threads): Now a std::vector.  Now static.
 138         (hwdebug_find_thread_points_by_tid)
 139         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
 140         Update.
 141
 142 2019-05-04  Tom Tromey  <tom@tromey.com>
 143
 144         * arc-tdep.c (arc_tdesc_init): Return bool.
 145
 146 2019-05-04  Tom Tromey  <tom@tromey.com>
 147
 148         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
 149         Use gdb_assert_not_reached.
 150
 151 2019-05-04  Tom Tromey  <tom@tromey.com>
 152
 153         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
 154         "false".
 155
 156 2019-05-04  Tom Tromey  <tom@tromey.com>
 157
 158         * arc-tdep.c (arc_tdesc_init): Use bool.
 159
 160 2019-05-04  Tom Tromey  <tom@tromey.com>
 161
 162         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
 163
 164 2019-05-04  Tom Tromey  <tom@tromey.com>
 165
 166         * cli/cli-cmds.c (valid_command_p): Return bool.
 167
 168 2019-05-04  Tom Tromey  <tom@tromey.com>
 169
 170         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
 171         * command.h (valid_user_defined_cmd_name_p): Channge return type.
 172
 173 2019-05-04  Raul Tambre  <raul@tambre.ee>
 174
 175         * python/lib/gdb/prompt.py (_ExtendedPrompt)
 176         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
 177         operator for comparison.
 178
 179 2019-05-04  Tom Tromey  <tom@tromey.com>
 180
 181         * psymtab.c (psymbol_name_matches, match_partial_symbol)
 182         (lookup_partial_symbol, print_partial_symbols)
 183         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
 184         (psymbol_compare): Update.
 185         (add_psymbol_to_bcache): Clear the entire psymbol.
 186         (maintenance_check_psymtabs): Update.
 187         * psympriv.h (struct partial_symbol): Don't derive from
 188         general_symbol_info.
 189         <obj_section, unrelocated_address, address,
 190         set_unrelocated_address>: Update.
 191         <ginfo>: New member.
 192         * dwarf-index-write.c (write_psymbols, debug_names::insert)
 193         (debug_names::write_psymbols): Update.
 194
 195 2019-05-04  Tom de Vries  <tdevries@suse.de>
 196
 197         * contrib/cc-with-tweaks.sh: Support -n arg.
 198
 199 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 200
 201         * corelow.c (core_target::detach): Ensure frame cache and
 202         register caches are cleared.
 203         inferior.c (exit_inferior_1): Likewise.
 204
 205 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
 206             Tom Tromey  <tom@tromey.com>
 207
 208         * dictionary.c (collate_pending_symbols_by_language): Remove
 209         "struct" from foreach.
 210         * symtab.c (lookup_global_symbol_from_objfile)
 211         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
 212         foreach.
 213         * ser-tcp.c (net_open): Remove "struct" from foreach.
 214         * objfiles.c (objfile_relocate, objfile_rebase)
 215         (objfile_has_symbols): Remove "struct" from foreach.
 216         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
 217         from foreach.
 218         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
 219         foreach.
 220         * darwin-nat.c (thread_info_from_private_thread_info): Remove
 221         "struct" from foreach.
 222         * ada-lang.c (create_excep_cond_exprs)
 223         (ada_exception_catchpoint_cond_string): Remove "struct" from
 224         foreach.
 225
 226 2019-05-03  Tom Tromey  <tromey@adacore.com>
 227
 228         * ada-exp.y (convert_char_literal): Check suffix of each
 229         enumerator.
 230
 231 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
 232
 233         PR ada/21406:
 234         * ada-exp.y (yywrap): Don't define.
 235         * ada-lex.l (%option): Add noyywrap
 236         (yywrap): Remove.
 237
 238 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
 239
 240         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
 241         _WIN32_WINNT to the XP level, unless already defined to a higher
 242         level.
 243
 244         * unittests/parse-connection-spec-selftests.c:
 245         * ser-tcp.c:
 246         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
 247         override.
 248
 249         * symfile.c (find_separate_debug_file): Remove colon from the
 250         drive spec of DOS/Windows file names of the target, so that the
 251         file name produced from DEBUGDIR and the target's directory will
 252         be valid on DOS/Windows systems.
 253
 254 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 255
 256         * rust-lang.c (val_print_struct): Handle printing structures
 257         containing strings.
 258
 259 2019-05-02  Tom Tromey  <tromey@adacore.com>
 260
 261         * valarith.c (_initialize_valarith): Remove.
 262
 263 2019-05-01  Tom Tromey  <tromey@adacore.com>
 264
 265         * ada-lang.c (ada_value_primitive_field): Treat more fields as
 266         bitfields.
 267
 268 2019-05-01  Tom Tromey  <tromey@adacore.com>
 269
 270         * ada-lang.c (ada_value_assign): Correctly compute starting offset
 271         for big-endian copies.
 272
 273 2019-04-30  Ali Tamur  <tamur@google.com>
 274         * gdb/dwarf2read.c (read_3_bytes): New declaration.
 275         (read_attribute_value): Added DW_FORM_strx1-4 cases.
 276         (read_3_bytes): New function.
 277
 278 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 279
 280         * windows-nat.c (main_thread_id): Delete.
 281         (handle_output_debug_string): Replace main_thread_id by
 282         current_event.dwThreadId.
 283         (fake_create_process): Likewise.
 284         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
 285         Do not set main_thread_id.
 286         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
 287         current_event.dwThreadId.
 288         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
 289
 290 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
 291
 292         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
 293         Use current_event.dwThreadId instead of main_thread_id.
 294
 295 2019-04-30  Tom Tromey  <tromey@adacore.com>
 296
 297         * ada-lang.c (ada_lookup_simple_minsyms): New function.
 298         (create_excep_cond_exprs): Iterate over program spaces.
 299         (ada_exception_catchpoint_cond_string): Examine all minimal
 300         symbols for exception types.
 301
 302 2019-04-30  Tom Tromey  <tromey@adacore.com>
 303
 304         PR c++/24470:
 305         * dwarf2read.c (process_structure_scope): Handle case where type
 306         has template parameters but no symbol was created.
 307
 308 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 309             Chris January  <chris.january@arm.com>
 310
 311         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
 312         qualifier.
 313         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
 314
 315 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 316
 317         * f-typeprint.c (f_print_type): Update rules for printing
 318         whitespace.
 319         (f_type_print_varspec_suffix): Likewise.
 320
 321 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 322             Chris January  <chris.january@arm.com>
 323
 324         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
 325         function arguments.
 326
 327 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 328
 329         * f-lang.c (build_fortran_types): Change name of void type to
 330         lower case.
 331         * f-typeprint.c (f_type_print_base): Print the name of the void
 332         type, rather than a fixed string.
 333         * f-valprint.c (f_decorations): Use lower case void string.
 334
 335 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 336             Chris January  <chris.january@arm.com>
 337
 338         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
 339         types for Fortran.
 340
 341 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 342             Chris January  <chris.january@arm.com>
 343             David Lecomber  <david.lecomber@arm.com>
 344
 345         * f-exp.y (BINOP_INTRINSIC): New token.
 346         (exp): New parser rule handling BINOP_INTRINSIC.
 347         (f77_keywords): Add new builtin procedures.
 348         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
 349         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 350         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
 351         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 352         (print_unop_subexp_f): New function.
 353         (print_binop_subexp_f): New function.
 354         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 355         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
 356         (dump_subexp_body_f): Likewise.
 357         (operator_check_f): Likewise.
 358         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
 359         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
 360
 361 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
 364         UNOP_KIND.
 365         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
 366         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
 367         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
 368         (operator_length_f): New fuction.
 369         (print_subexp_f): New function.
 370         (op_name_f): New function.
 371         (dump_subexp_body_f): New function.
 372         (operator_check_f): New function.
 373         (exp_descriptor_f): Replace standard expression handling functions
 374         with new functions.
 375         * gdb/fortran-operator.def: New file.
 376         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 377         * gdb/std-operator.def: Remove UNOP_KIND.
 378
 379 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 380
 381         * std-operator.def: Remove unbalanced, stray double quote
 382         character.
 383
 384 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 385             Chris January  <chris.january@arm.com>
 386             Daniel Everett  <daniel.everett@arm.com>
 387             Nick Forrington  <nick.forrington@arm.com>
 388             Richard Bunt  <richard.bunt@arm.com>
 389
 390         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 391         of depth when printing anonymous structs or unions.
 392         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 393         Don't print either the top-level value, or the children if the
 394         max-depth is exceeded.
 395         (ppscm_print_children): When printing the key of a map, allow one
 396         extra level of depth.
 397         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 398         print either the top-level value, or the children if the max-depth
 399         is exceeded.
 400         (print_children): When printing the key of a map, allow one extra
 401         level of depth.
 402         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 403         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 404         (user_print_options): Initialise max_depth field.
 405         (val_print_scalar_or_string_type_p): New function.
 406         (val_print): Check to see if the max depth has been reached.
 407         (val_print_check_max_depth): Define new function.
 408         (show_print_max_depth): New function.
 409         (_initialize_valprint): Add 'print max-depth' option.
 410         * valprint.h (struct value_print_options) <max_depth>: New field.
 411         (val_print_check_max_depth): Declare new function.
 412         * NEWS: Document new feature.
 413
 414 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 415
 416         * ada-lang.c (ada_language_defn): Initialise new field.
 417         * c-lang.c (c_is_string_type_p): New function.
 418         (c_language_defn): Initialise new field.
 419         (cplus_language_defn): Initialise new field.
 420         (asm_language_defn): Initialise new field.
 421         (minimal_language_defn): Initialise new field.
 422         * c-lang.h (c_is_string_type_p): Declare new function.
 423         * d-lang.c (d_language_defn): Initialise new field.
 424         * f-lang.c (f_is_string_type_p): New function.
 425         (f_language_defn): Initialise new field.
 426         * go-lang.c (go_is_string_type_p): New function.
 427         (go_language_defn): Initialise new field.
 428         * language.c (default_is_string_type_p): New function.
 429         (unknown_language_defn): Initialise new field.
 430         (auto_language_defn): Initialise new field.
 431         * language.h (struct language_defn) <la_is_string_type_p>: New
 432         member variable.
 433         (default_is_string_type_p): Declare new function.
 434         * m2-lang.c (m2_language_defn): Initialise new field.
 435         * objc-lang.c (objc_language_defn): Initialise new field.
 436         * opencl-lang.c (opencl_language_defn): Initialise new field.
 437         * p-lang.c (pascal_is_string_type_p): New function.
 438         (pascal_language_defn): Initialise new field.
 439         * rust-lang.c (rust_is_string_type_p): New function.
 440         (rust_language_defn): Initialise new field.
 441
 442 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 443
 444         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 445         New field.
 446         * ada-lang.c (ada_language_defn): Initialise new field.
 447         * c-lang.c (c_language_defn): Likewise.
 448         (cplus_language_defn): Likewise.
 449         (asm_language_defn): Likewise.
 450         (minimal_language_defn): Likewise.
 451         * d-lang.c (d_language_defn): Likewise.
 452         * f-lang.c (f_language_defn): Likewise.
 453         * go-lang.c (go_language_defn): Likewise.
 454         * language.c (unknown_language_defn): Likewise.
 455         (auto_language_defn): Likewise.
 456         * m2-lang.c (m2_language_defn): Likewise.
 457         * objc-lang.c (objc_language_defn): Likewise.
 458         * opencl-lang.c (opencl_language_defn): Likewise.
 459         * p-lang.c (pascal_language_defn): Likewise.
 460         * rust-lang.c (rust_language_defn): Likewise.
 461
 462 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 463
 464         * ada-lang.c (ada_is_character_type): Change return type to bool.
 465         (ada_is_string_type): Likewise.
 466         * ada-lang.h (ada_is_character_type): Update declaration
 467         (ada_is_string_type): Likewise.
 468
 469 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 470
 471         Support style in 'frame|thread apply'
 472
 473         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 474         * record.c (record_start, record_stop): Update callers of
 475         execute_command_to_string with false.
 476         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 477         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 478         methods.
 479         (class string_file): New constructor with term_out parameter.
 480         Override methods term_out and can_emit_style_escape.  New member
 481         term_out.
 482         (class stdio_file): Override can_emit_style_escape.
 483         (class tee_file): Override term_out and can_emit_style_escape.
 484         * utils.h (can_emit_style_escape): Remove.
 485         * utils.c (can_emit_style_escape): Likewise.
 486         Update all callers of can_emit_style_escape (SOMESTREAM) to
 487         SOMESTREAM->can_emit_style_escape.
 488         * source-cache.c (source_cache::get_source_lines): Likewise.
 489         * stack.c (frame_apply_command_count): Call execute_command_to_string
 490         passing the term_out characteristic of the current gdb_stdout.
 491         * thread.c (thr_try_catch_cmd): Likewise.
 492         * top.c (execute_command_to_string): pass term_out parameter
 493         to construct the string_file for the command output.
 494         * ui-file.c (term_cli_styling): New function (most code moved
 495         from utils.c can_emit_style_escape).
 496         (string_file::string_file, string_file::can_emit_style_escape,
 497         stdio_file::can_emit_style_escape, tee_file::term_out,
 498         tee_file::can_emit_style_escape): New functions.
 499
 500 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 501
 502         * NEWS: Mention the new set|show may-call-functions.
 503         * infcall.c (may_call_functions_p): New variable.
 504         (show_may_call_functions_p): New function.
 505         (call_function_by_hand_dummy): Throws an error if not
 506         may-call-functions.
 507         (_initialize_infcall): Call add_setshow_boolean_cmd for
 508         may-call-functions.
 509
 510 2019-04-25  Keith Seitz  <keiths@redhat.com>
 511
 512         PR c++/24367
 513         * cp-support.c (inspect_type): Don't attempt substitutions
 514         of symbol with the same name.
 515
 516 2019-04-25  Tom Tromey  <tromey@adacore.com>
 517
 518         PR gdb/24475:
 519         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 520         static.
 521
 522 2019-04-25  Tom Tromey  <tromey@adacore.com>
 523
 524         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 525         rvalue reference.
 526         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 527         (gdb_xml_parser::parse): Use std::move.
 528         * python/python-internal.h (gdbpy_convert_exception): Take a const
 529         reference.
 530         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 531         std::move.
 532         * python/py-utils.c (gdbpy_convert_exception): Take a const
 533         reference.
 534         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 535         Use std::move.
 536         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 537         Use std::move.
 538         * mi/mi-main.c (mi_print_exception): Take a const reference.
 539         * main.c (handle_command_errors): Take a const reference.
 540         * linespec.c (parse_linespec): Use std::move.
 541         * infcall.c (run_inferior_call): Use std::move.
 542         (call_function_by_hand_dummy): Use std::move.
 543         * exec.c (try_open_exec_file): Use std::move.
 544         * exceptions.h (exception_print, exception_fprintf)
 545         (exception_print_same): Update.
 546         * exceptions.c (print_exception, exception_print)
 547         (exception_fprintf, exception_print_same): Change parameters to
 548         const reference.
 549         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 550         * common/new-op.c: Use std::move.
 551         * common/common-exceptions.h (struct gdb_exception): Add move
 552         constructor.
 553         (struct gdb_exception_error, struct gdb_exception_quit, struct
 554         gdb_quit_bad_alloc): Change constructor to move constructor.
 555         (throw_exception): Change parameter to rvalue reference.
 556         * common/common-exceptions.c (throw_exception): Take rvalue
 557         reference.
 558         * cli/cli-interp.c (safe_execute_command): Use std::move.
 559         * breakpoint.c (insert_bp_location, location_to_sals): Use
 560         std::move.
 561
 562 2019-04-25  Tom Tromey  <tromey@adacore.com>
 563
 564         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 565         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 566         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 567         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 568         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 569         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 570         guile/scm-value.c: Use unpack.
 571         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 572         gdbscm_gdb_exception.
 573         (gdbscm_throw_gdb_exception): Likewise.
 574         (struct gdbscm_gdb_exception): New.
 575         (unpack): New function.
 576         (gdbscm_wrap): Use unpack.
 577
 578 2019-04-25  Tom Tromey  <tromey@adacore.com>
 579
 580         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 581         (gdb_rl_callback_handler): Use std::move.
 582         * common/common-exceptions.h (struct gdb_exception): Add move
 583         assignment operator.
 584         (throw_exception_sjlj): Change "exception" to const reference.
 585         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 586         (throw_exception_sjlj): Change "exception" to const reference.
 587
 588 2019-04-25  Tom Tromey  <tromey@adacore.com>
 589
 590         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 591         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 592         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 593         Update.
 594         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 595         Update.
 596         * mi/mi-interp.c (mi_interp::exec): Update.
 597         * linespec.c (parse_linespec): Update.
 598         * infcall.c (run_inferior_call): Update.
 599         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 600         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 601         (gdbscm_lookup_global_symbol): Update.
 602         * guile/scm-param.c (gdbscm_parameter_value): Update.
 603         * guile/scm-frame.c (gdbscm_frame_read_register)
 604         (gdbscm_frame_read_var): Update.
 605         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 606         * exec.c (try_open_exec_file): Update.
 607         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 608         (gdb_rl_callback_handler): Update.
 609         * common/common-exceptions.h (exception_none): Don't declare.
 610         * common/common-exceptions.c (exception_none): Don't define.
 611         (struct catcher) <exception>: Update.
 612         * cli/cli-interp.c (safe_execute_command): Update.
 613         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 614
 615 2019-04-25  Ali Tamur  <tamur@google.com>
 616
 617         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 618         (read_attribute_value): Likewise.
 619         (dwarf2_read_addr_index): Update comment.
 620         (read_str_index): Add DW_FORM_strx.
 621         (dwarf2_string_attr): Likewise.
 622         (dwarf2_const_value_attr): Likewise.
 623         (dump_die_shallow): Likewise.
 624         (dwarf2_fetch_constant_bytes): Likewise.
 625         (skip_form_bytes): Likewise.
 626         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 627
 628 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 629
 630         PR corefiles/11608
 631         PR corefiles/18187
 632         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 633         OFFSET.  Verify if current mapping contains an ELF header.
 634         (linux_find_memory_regions_full): Adjust call to
 635         dump_mapping_p.
 636
 637 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 638             Kang Li <kanglictf@gmail.com>
 639
 640         PR gdb/21600
 641
 642         * dwarf2-frame.c (read_initial_length): Be consistent about using
 643         unsigned representation of length.
 644         (decode_frame_entry_1): Likewise.  Check for wraparound of
 645         end pointer as well as buffer overflow.
 646
 647 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 648
 649         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 650         "vq".
 651
 652 2019-04-24  Tom Tromey  <tromey@adacore.com>
 653
 654         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 655
 656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 657
 658         * s12z-tdep.c (s12z_unwind_pc): Delete.
 659         (s12z_unwind_sp): Delete.
 660         (s12z_gdbarch_init): Don't register deleted functions with
 661         gdbarch.
 662
 663 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 664
 665         * rl78-tdep.c (rl78_unwind_sp): Delete.
 666         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 667
 668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 669
 670         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 671         (xstormy16_unwind_pc): Delete.
 672         (xstormy16_dummy_id): Delete.
 673         (xstormy16_gdbarch_init): Don't register deleted functions with
 674         gdbarch.
 675
 676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 677
 678         * vax-tdep.c (vax_unwind_pc): Delete.
 679         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 680
 681 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 682
 683         * v850-tdep.c (v850_unwind_sp): Delete.
 684         (v850_unwind_pc): Delete.
 685         (v850_dummy_id): Delete.
 686         (v850_gdbarch_init): Don't register deleted functions with
 687         gdbarch.
 688
 689 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 690
 691         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 692         (tilegx_unwind_pc): Delete.
 693         (tilegx_unwind_dummy_id): Delete.
 694         (tilegx_gdbarch_init): Don't register deleted functions with
 695         gdbarch.
 696
 697 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 698
 699         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 700         (tic6x_dummy_id): Delete.
 701         (tic6x_gdbarch_init): Don't register deleted functions with
 702         gdbarch.
 703
 704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 705
 706         * sparc-tdep.c (sparc_unwind_pc): Delete.
 707         (sparc32_gdbarch_init): Don't register deleted function with
 708         gdbarch.
 709
 710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 711
 712         * sh-tdep.c (sh_unwind_sp): Delete.
 713         (sh_unwind_pc): Delete.
 714         (sh_dummy_id): Delete.
 715         (sh_gdbarch_init): Don't register deleted functions with
 716         gdbarch.
 717
 718 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 719
 720         * score-tdep.c (score_unwind_sp): Delete.
 721         (score_unwind_pc): Delete.
 722         (score_dummy_id): Delete.
 723         (score_gdbarch_init): Don't register deleted functions with
 724         gdbarch.
 725
 726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 727
 728         * rx-tdep.c (rx_unwind_pc): Delete.
 729         (rx_unwind_sp): Delete.
 730         (rx_dummy_id): Delete.
 731         (rx_gdbarch_init): Don't register deleted functions with
 732         gdbarch.  Update comment.
 733
 734 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 735
 736         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 737         (rs6000_dummy_id): Delete.
 738         (rs6000_gdbarch_init): Don't register deleted functions with
 739         gdbarch.
 740
 741 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 742
 743         * or1k-tdep.c (or1k_dummy_id): Delete.
 744         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 745
 746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 747
 748         * nios2-tdep.c (nios2_dummy_id): Delete.
 749         (nios2_unwind_sp): Delete.
 750         (nios2_gdbarch_init): Don't register deleted functions with
 751         gdbarch.
 752
 753 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 754
 755         * nds32-tdep.c (nds32_dummy_id): Delete.
 756         (nds32_unwind_pc): Delete.
 757         (nds32_unwind_sp): Delete.
 758         (nds32_gdbarch_init): Don't register deleted functions with
 759         gdbarch.
 760
 761 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 762
 763         * msp430-tdep.c (msp430_unwind_pc): Delete.
 764         (msp430_unwind_sp): Delete.
 765         (msp430_dummy_id): Delete.
 766         (msp430_gdbarch_init): Don't register deleted functions with
 767         gdbarch.
 768
 769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 770
 771         * moxie-tdep.c (moxie_unwind_sp): Delete.
 772         (moxie_unwind_pc): Delete.
 773         (moxie_dummy_id): Delete.
 774         (moxie_gdbarch_init): Don't register deleted functions with
 775         gdbarch.
 776
 777 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 778
 779         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 780         (mn10300_unwind_pc): Delete.
 781         (mn10300_unwind_sp): Delete.
 782         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 783         mn10300_unwind_sp.
 784         (mn10300_frame_unwind_init): Don't register deleted functions with
 785         gdbarch.
 786
 787 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 788
 789         * mep-tdep.c (mep_unwind_pc): Delete.
 790         (mep_unwind_sp): Delete.
 791         (mep_dummy_id): Delete.
 792         (mep_gdbarch_init): Don't register deleted functions with
 793         gdbarch.
 794
 795 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 796
 797         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 798         (m68hc11_unwind_sp): Delete.
 799         (m68hc11_gdbarch_init): Don't register deleted functions with
 800         gdbarch.
 801
 802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 803
 804         * m32r-tdep.c (m32r_unwind_sp): Delete.
 805         (m32r_unwind_pc): Delete.
 806         (m32r_dummy_id): Delete.
 807         (m32r_gdbarch_init): Don't register deleted functions with
 808         gdbarch.
 809
 810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * m32c-tdep.c (m32c_unwind_pc): Delete.
 813         (m32c_unwind_sp): Delete.
 814         (m32c_dummy_id): Delete.
 815         (m32c_gdbarch_init): Don't register deleted functions with
 816         gdbarch.
 817
 818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 819
 820         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 821         (lm32_unwind_pc): Delete.
 822         (lm32_dummy_id): Delete.
 823         (lm32_gdbarch_init): Don't register deleted functions with
 824         gdbarch.
 825
 826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 827
 828         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 829         (iq2000_unwind_pc): Delete.
 830         (iq2000_dummy_id): Delete.
 831         (iq2000_gdbarch_init): Don't register deleted functions with
 832         gdbarch.
 833
 834 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 835
 836         * nds32-tdep.c (nds32_type_align): Delete.
 837         (nds32_push_dummy_call): Use type_align instead.
 838
 839 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 840
 841         * arm-tdep.c (arm_type_align): Only handle vector override case.
 842         (arm_push_dummy_call): Use type_align.
 843         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 844
 845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 848         case.
 849         (pass_on_stack): Use type_align.
 850         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 851         function.
 852
 853 2019-04-23  Tom Tromey  <tromey@adacore.com>
 854
 855         * dwarf2read.c (line_header::file_name_at): Remove unused
 856         overload.
 857
 858 2019-04-23  Tom de Vries  <tdevries@suse.de>
 859
 860         PR gdb/24438
 861         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 862         invocation.
 863
 864
 865 2019-03-27  Ali Tamur  <tamur@google.com>
 866
 867         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 868         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 869         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 870         (dwarf_expr_context::get_addr_index): Likewise
 871         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 872         (symbol_needs_eval_context::get_addr_index): Likewise
 873         (disassemble_dwarf_expression): Add DW_OP_addrx
 874         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 875         (read_cutu_die_from_dwo): Update comment
 876         (skip_one_die): Add DW_FORM_addrx
 877         (read_attribute_value): Likewise
 878         (var_decode_location): Add DW_OP_addrx
 879         (dwarf2_const_value_attr): Add DW_FORM_addrx
 880         (dump_die_shallow): Likewise
 881         (dwarf2_fetch_constant_bytes): Likewise
 882         (decode_locdesc): Add DW_OP_addrx
 883         (skip_form_bytes): Add DW_FORM_addrx
 884
 885 2019-04-22  Ali Tamur  <tamur@google.com>
 886
 887         * MAINTAINERS (Write After Approval): Add self.
 888
 889 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 890
 891         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 892         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 893         (open_symbol_file_object): Likewise.
 894         (svr4_default_sos): Add info parameter.
 895         (svr4_read_so_list): Likewise.
 896         (svr4_current_sos_direct): Adjust functions calls to pass down
 897         info.
 898         (svr4_current_sos_1): Add info parameter.
 899         (svr4_current_sos): Call get_svr4_info, pass info down to
 900         svr4_current_sos_1.
 901         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 902         get_svr4_info.
 903         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 904         get_svr4_info.
 905         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 906         to get_svr4_info.
 907         (probes_table_remove_objfile_probes): Likewise.
 908         (register_solib_event_probe): Add info parameter.
 909         (solist_update_incremental): Pass info parameter down to
 910         svr4_read_so_list.
 911         (disable_probes_interface): Add info parameter.
 912         (svr4_handle_solib_event): Pass current_program_space to
 913         get_svr4_info.  Adjust disable_probes_interface cleanup.
 914         (svr4_create_probe_breakpoints): Add info parameter, pass it
 915         down to register_solib_event_probe.
 916         (svr4_create_solib_event_breakpoints): Add info parameter,
 917         pass it down to svr4_create_probe_breakpoints.
 918         (enable_break): Pass info down to
 919         svr4_create_solib_event_breakpoints.
 920         (svr4_solib_create_inferior_hook): Pass current_program_space to
 921         get_svr4_info.
 922         (svr4_clear_solib): Likewise.
 923
 924 2019-04-22  Pedro Alves  <palves@redhat.com>
 925
 926         * solib-svr4.c (svr4_free_objfile_observer): New.
 927         (probe_and_action::objfile): New field.
 928         (probes_table_htab_remove_objfile_probes)
 929         (probes_table_remove_objfile_probes): New functions.
 930         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 931         in the new probe_and_action.  Don't store the probe in 'lookup'.
 932         (svr4_create_probe_breakpoints): Pass objfile to
 933         register_solib_event_probe.
 934         (_initialize_svr4_solib): Register a free_objfile observer.
 935
 936 2019-04-19  Tom Tromey  <tom@tromey.com>
 937
 938         * common/queue.h: Remove.
 939
 940 2019-04-19  Tom Tromey  <tom@tromey.com>
 941
 942         * event-loop.c: Don't include "common/queue.h".
 943
 944 2019-04-19  Tom Tromey  <tom@tromey.com>
 945
 946         * remote.c (remote_target): Use delete.
 947         * remote-notif.h: Include <list>, not "common/queue.h".
 948         (notif_client_p): Remove typedef.
 949         (remote_notif_state): Add constructor, destructor, initializer.
 950         <notif_queue>: Now a std::list.
 951         (remote_notif_state_xfree): Don't declare.
 952         * remote-notif.c (remote_notif_process, handle_notification)
 953         (remote_notif_state_allocate): Update.
 954         (~remote_notif_state): Rename from remote_notif_state_xfree.
 955
 956 2019-04-19  Tom Tromey  <tom@tromey.com>
 957
 958         * symfile.c (reread_symbols): Update.
 959         * objfiles.c (objfile_register_static_link)
 960         (objfile_lookup_static_link): Update
 961         (~objfile) Don't delete static_links.
 962         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 963
 964 2019-04-19  Tom Tromey  <tom@tromey.com>
 965
 966         * type-stack.h (struct type_stack) <insert>: Constify string.
 967         * type-stack.c (type_stack::insert): Constify string.
 968         * gdbtypes.h (lookup_template_type): Update.
 969         (address_space_name_to_int): Update.
 970         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 971         const.
 972         (lookup_template_type): Make name const.
 973         * c-exp.y: Update rules.
 974         (lex_one_token, classify_name, classify_inner_name)
 975         (c_print_token): Update.
 976         * p-exp.y: Update rules.
 977         (yylex): Update.
 978         * f-exp.y: Update rules.
 979         (yylex): Update.
 980         * d-exp.y: Update rules.
 981         (lex_one_token, classify_name, classify_inner_name): Update.
 982         * parse.c (write_dollar_variable, copy_name): Return std::string.
 983         * parser-defs.h (copy_name): Change return type.
 984         * m2-exp.y: Update rules.
 985         (yylex): Update.
 986         * go-exp.y (lex_one_token): Update.
 987         Update rules.
 988         (classify_unsafe_function, classify_packaged_name)
 989         (classify_name, yylex): Update.
 990
 991 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 992
 993         * configure.ac: add --enable-source-highlight switch.
 994         * configure: Regenerate.
 995         * top.c (print_gdb_version): plumb --enable-source-highlight
 996         status to "show configuration".
 997
 998 2019-04-19  Tom Tromey  <tromey@adacore.com>
 999
1000         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1001         Check ADA_TYPE_P.
1002         (empty_record, ada_template_to_fixed_record_type_1)
1003         (template_to_static_fixed_type)
1004         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1005         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1006         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1007         macros.
1008
1009 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1010
1011         PR symtab/24423:
1012         * source.c (print_source_lines_base): Advance "iter" when a
1013         control character is seen.
1014
1015 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1016
1017         * inferior.h (struct infcall_suspend_state_deleter):
1018         Catch exception in destructor to avoid crash.
1019
1020 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1021
1022         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1023         close to the add_com "shell".
1024
1025 2019-04-18  Tom Tromey  <tromey@adacore.com>
1026
1027         * process-stratum-target.h (class process_stratum_target)
1028         <stratum>: Add "final".
1029
1030 2019-04-17  Tom Tromey  <tromey@adacore.com>
1031
1032         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1033         against nullptr before use.
1034
1035 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1036
1037         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1038
1039 2019-04-17  Jim Wilson  <jimw@sifive.com>
1040             Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1043         code read might fail, assume 4-byte breakpoint in that case.
1044
1045 2019-04-15  Leszek Swirski  <leszeks@google.com>
1046
1047         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1048         rather than a hand-rolled POD check when checking for forced MEMORY
1049         classification.
1050
1051 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1052
1053         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1054         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1055         function.
1056         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1057         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1058         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1059         declaration.
1060
1061 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1062
1063         * aarch64-linux-nat.c
1064         (aarch64_linux_nat_target::thread_architecture): Add override.
1065         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1066         each VQ.
1067
1068 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1069
1070         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1071
1072 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1073
1074         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1075         target types of size 96-bits, add some additional comments, and
1076         check that the builtin type we found was the correct size.
1077
1078 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1079
1080         * utils.c (prompt_for_continue): Don't restore the styling at the
1081         end, as applied_style has the wrong value.  This fixes styling in
1082         long lists of file names that are interrupted by the "Continue?"
1083         prompt.
1084
1085 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1086
1087         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1088         * c-lang.c (c_language_defn): Likewise.
1089         (cplus_language_defn): Likewise.
1090         (asm_language_defn): Likewise.
1091         (minimal_language_defn): Likewise.
1092         * d-lang.c (d_language_defn): Likewise.
1093         * f-lang.c (f_language_defn): Likewise.
1094         * go-lang.c (go_language_defn): Likewise.
1095         * language.c (unknown_language_defn): Likewise.
1096         (auto_language_defn): Likewise.
1097         * language.h (struct language_defn): Remove la_magic field.
1098         (LANG_MAGIC): Delete.
1099         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1100         * objc-lang.c (objc_language_defn): Likewise.
1101         * opencl-lang.c (opencl_language_defn): Likewise.
1102         * p-lang.c (pascal_language_defn): Likewise.
1103         * rust-lang.c (rust_language_defn): Likewise.
1104
1105 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1106
1107         * riscv-tdep.c (riscv_type_align): New function.
1108         (riscv_type_alignment): Delete.
1109         (riscv_arg_location): Use 'type_align'.
1110         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1111
1112 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1113
1114         * gdbtypes.c (type_align): A struct with no non-static fields also
1115         has alignment of 1.
1116
1117 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1118
1119         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
1120         component to 0.
1121         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
1122         member.
1123         (riscv_struct_info::analyse): New implementation using new
1124         analyse_inner member function.
1125         (riscv_struct_info::field_offset): New member function.
1126         (riscv_struct_info::m_offsets): New member variable.
1127         (riscv_struct_info::analyse_inner): New private member function,
1128         takes the old implementation of riscv_struct_info::analyse but
1129         extended to track field offsets.
1130         (riscv_call_arg_struct): Update the struct folding special cases
1131         to handle cases where empty C++ structs, which are non-zero
1132         length, are found.
1133         (riscv_arg_location): Initialise the length of each location, a
1134         non-zero length now indicates the location is in use.
1135         (riscv_push_dummy_call): Allow for the first location having a
1136         non-zero offset when setting up arguments.
1137         (riscv_return_value): Likewise, but for return values.
1138
1139 2019-04-11  Tom Tromey  <tromey@adacore.com>
1140
1141         * utils.c (internal_vproblem): Make "msg" const.
1142
1143 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
1144
1145         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
1146         * trad-frame.c (trad_frame_reset_saved_regs): New function.
1147         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
1148         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
1149
1150 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
1151
1152         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
1153         function.
1154         (fill_gregset): Call amd64_linux_collect_native_gregset instead
1155         of amd64_collect_native_gregset.
1156         (amd64_linux_nat_target::store_registers): Likewise.
1157
1158 2019-04-10  Tom Tromey  <tom@tromey.com>
1159
1160         * symtab.c (lookup_global_symbol_from_objfile)
1161         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
1162         * objfiles.h (class separate_debug_iterator): New.
1163         (class separate_debug_range): New.
1164         (struct objfile) <separate_debug_objfiles>: New method.
1165         (objfile_separate_debug_iterate): Don't declare.
1166         * objfiles.c (separate_debug_iterator::operator++): Rename from
1167         objfile_separate_debug_iterate.
1168         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
1169         iterator.
1170         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
1171         iterator.
1172
1173 2019-04-10  Tom Tromey  <tom@tromey.com>
1174
1175         * symfile.c (reread_symbols): Remove old comment.
1176         * objfiles.c (free_all_objfiles): Fix a typo.
1177
1178 2019-04-10  Tom Tromey  <tom@tromey.com>
1179
1180         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
1181         * minsyms.c (lookup_minimal_symbol): Use foreach.
1182         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
1183         (lookup_minimal_symbol_solib_trampoline): Likewise.
1184         * symfile.c (reread_symbols): Use foreach.
1185
1186 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
1187             Tom Tromey  <tromey@adacore.com>
1188
1189         PR rust/24414:
1190         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
1191         (rust_lex_int_test): Change "value" to be LONGEST.
1192         (rust_lex_tests): Add test for long integer literal.
1193
1194 2019-04-09  Tom Tromey  <tromey@adacore.com>
1195
1196         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
1197         to bool.
1198         (extended_remote_target::attach): Update.
1199         (remote_target::remote_notice_new_inferior): Update.
1200         (remote_target::add_current_inferior_and_thread): Update.
1201         * inferior.c (exit_inferior_1): Use "false".
1202         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
1203
1204 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
1205
1206         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
1207         the "start" command.
1208
1209 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1210
1211         * python/py-inferior.c (infpy_thread_from_thread_handle):
1212         Adjust comments to reflect renaming of thread_from_thread_handle
1213         to thread_from_handle.  Adjust keywords.  Fix type error message.
1214         (inferior_object_methods): Add thread_from_handle.  Retain
1215         thread_from_thread_handle, but mark it as deprecated.
1216
1217 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1218
1219         * gdbthread.h (find_thread_by_handle): Revise declaration.
1220         * thread.c (find_thread_by_handle): Likewise.  Adjust
1221         implementation too.
1222         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
1223         support for buffer objects as handles.
1224
1225 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1226
1227         * python/py-infthread.c (thpy_thread_handle): New function.
1228         (thread_object_methods): Register thpy_thread_handle.
1229
1230 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
1231
1232         * gdbthread.h (thread_to_thread_handle): Declare.
1233         * thread.c (gdbtypes.h): Include.
1234         (thread_to_thread_handle): New function.
1235
1236         * target.h (struct target_ops): Add thread_info_to_thread_handle.
1237         (target_thread_info_to_thread_handle): Declare.
1238         * target.c (target_thread_info_to_thread_handle): New function.
1239         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
1240         * target-delegates.c: Regenerate.
1241
1242         * linux-thread-db.c (class thread_db_target): Add method
1243         thread_info_to_thread_handle.
1244         (thread_db_target::thread_info_to_thread_handle): Define.
1245         * remote.c (class remote_target): Add new method
1246         thread_info_to_thread_handle.
1247         (remote_target::thread_info_to_thread_handle): Define.
1248
1249 2019-04-08  Pedro Alves  <palves@redhat.com>
1250
1251         * common/common-exceptions.c (throw_exception): Don't create
1252         named object to throw; throw directly.
1253         (throw_it): Likewise.  Don't initialize gdb_exception::message
1254         here, with new; pass FMT and AP to the ctor instead.
1255         * common/common-exceptions.h: Include <string>.
1256         (gdb_exception::gdb_exception(enum return_reason, enum errors,
1257         const char *, va_list)): New ctor.  Use std::make_shared.
1258         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
1259         errors)): Delete.
1260         (gdb_exception_error::gdb_exception_error(enum errors, const char
1261         *, va_list)): New.
1262         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
1263         Add assertion.
1264         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
1265         errors)): Delete.
1266         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
1267         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
1268         Add assertion.
1269
1270 2019-04-08  Tom Tromey  <tom@tromey.com>
1271
1272         * valops.c (value_rtti_indirect_type): Replace throw_exception
1273         with throw.
1274         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1275         with throw.
1276         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1277         throw.
1278         * target.c (target_translate_tls_address): Replace throw_exception
1279         with throw.
1280         * stack.c (frame_apply_command_count): Replace throw_exception
1281         with throw.
1282         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1283         throw.
1284         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1285         with throw.
1286         * rs6000-tdep.c (rs6000_frame_cache)
1287         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1288         * remote.c: Replace throw_exception with throw.
1289         * record-full.c (record_full_message, record_full_wait_1)
1290         (record_full_restore): Replace throw_exception with throw.
1291         * record-btrace.c:
1292         (get_thread_current_frame_id, record_btrace_start_replaying)
1293         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1294         (cmd_record_btrace_start): Replace throw_exception with throw.
1295         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1296         throw.
1297         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1298         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1299         * linespec.c:
1300         (find_linespec_symbols): Replace throw_exception with throw.
1301         * infrun.c (displaced_step_prepare, resume): Replace
1302         throw_exception with throw.
1303         * infcmd.c (post_create_inferior): Replace throw_exception with
1304         throw.
1305         * inf-loop.c (inferior_event_handler): Replace throw_exception
1306         with throw.
1307         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1308         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1309         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1310         (get_prev_frame_always, get_frame_pc_if_available)
1311         (get_frame_address_in_block_if_available, get_frame_language):
1312         Replace throw_exception with throw.
1313         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1314         throw_exception with throw.
1315         * eval.c (fetch_subexp_value, evaluate_var_value)
1316         (evaluate_funcall, evaluate_subexp_standard): Replace
1317         throw_exception with throw.
1318         * dwarf2loc.c (call_site_find_chain)
1319         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1320         Replace throw_exception with throw.
1321         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1322         with throw.
1323         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1324         throw.
1325         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1326         * completer.c (complete_line_internal): Replace throw_exception
1327         with throw.
1328         * compile/compile-object-run.c (compile_object_run): Replace
1329         throw_exception with throw.
1330         * cli/cli-script.c (process_next_line): Replace throw_exception
1331         with throw.
1332         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1333         (btrace_enable, btrace_maint_update_pt_packets): Replace
1334         throw_exception with throw.
1335         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1336         throw_exception with throw.
1337         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1338         throw_exception with throw.
1339         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1340         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1341         * aarch64-tdep.c (aarch64_make_prologue_cache)
1342         (aarch64_make_stub_cache): Replace throw_exception with throw.
1343
1344 2019-04-08  Tom Tromey  <tom@tromey.com>
1345
1346         * common/common-exceptions.c (throw_exception): Rename from
1347         throw_exception_cxx.  Remove old copy.  Make argument const.
1348         (throw_it): Create and throw exception objects directly.
1349         * common/common-exceptions.h (throw_exception): Make argument
1350         const.
1351         (struct gdb_exception_error): Add constructor.
1352         (struct gdb_exception_quit): Add constructor.
1353
1354 2019-04-08  Tom Tromey  <tom@tromey.com>
1355
1356         * common/common-exceptions.h (exception_rethrow): Don't declare.
1357         (TRY_SJLJ): Update comment.
1358         (TRY, CATCH, END_CATCH): Remove.
1359         * common/common-exceptions.c (exception_rethrow): Remove.
1360
1361 2019-04-08  Tom Tromey  <tom@tromey.com>
1362
1363         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1364         Remove.
1365         (gdb_exception_error): Rename from
1366         gdb_exception_RETURN_MASK_ERROR.
1367         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1368         (gdb_quit_bad_alloc): Update.
1369         * aarch64-tdep.c: Update.
1370         * ada-lang.c: Update.
1371         * ada-typeprint.c: Update.
1372         * ada-valprint.c: Update.
1373         * amd64-tdep.c: Update.
1374         * arch-utils.c: Update.
1375         * break-catch-throw.c: Update.
1376         * breakpoint.c: Update.
1377         * btrace.c: Update.
1378         * c-varobj.c: Update.
1379         * cli/cli-cmds.c: Update.
1380         * cli/cli-interp.c: Update.
1381         * cli/cli-script.c: Update.
1382         * common/common-exceptions.c: Update.
1383         * common/new-op.c: Update.
1384         * common/selftest.c: Update.
1385         * compile/compile-c-symbols.c: Update.
1386         * compile/compile-cplus-symbols.c: Update.
1387         * compile/compile-object-load.c: Update.
1388         * compile/compile-object-run.c: Update.
1389         * completer.c: Update.
1390         * corelow.c: Update.
1391         * cp-abi.c: Update.
1392         * cp-support.c: Update.
1393         * cp-valprint.c: Update.
1394         * darwin-nat.c: Update.
1395         * disasm-selftests.c: Update.
1396         * dtrace-probe.c: Update.
1397         * dwarf-index-cache.c: Update.
1398         * dwarf-index-write.c: Update.
1399         * dwarf2-frame-tailcall.c: Update.
1400         * dwarf2-frame.c: Update.
1401         * dwarf2loc.c: Update.
1402         * dwarf2read.c: Update.
1403         * eval.c: Update.
1404         * event-loop.c: Update.
1405         * event-top.c: Update.
1406         * exec.c: Update.
1407         * f-valprint.c: Update.
1408         * fbsd-tdep.c: Update.
1409         * frame-unwind.c: Update.
1410         * frame.c: Update.
1411         * gdbtypes.c: Update.
1412         * gnu-v3-abi.c: Update.
1413         * guile/guile-internal.h: Update.
1414         * guile/scm-block.c: Update.
1415         * guile/scm-breakpoint.c: Update.
1416         * guile/scm-cmd.c: Update.
1417         * guile/scm-disasm.c: Update.
1418         * guile/scm-frame.c: Update.
1419         * guile/scm-lazy-string.c: Update.
1420         * guile/scm-math.c: Update.
1421         * guile/scm-param.c: Update.
1422         * guile/scm-ports.c: Update.
1423         * guile/scm-pretty-print.c: Update.
1424         * guile/scm-symbol.c: Update.
1425         * guile/scm-symtab.c: Update.
1426         * guile/scm-type.c: Update.
1427         * guile/scm-value.c: Update.
1428         * i386-linux-tdep.c: Update.
1429         * i386-tdep.c: Update.
1430         * inf-loop.c: Update.
1431         * infcall.c: Update.
1432         * infcmd.c: Update.
1433         * infrun.c: Update.
1434         * jit.c: Update.
1435         * language.c: Update.
1436         * linespec.c: Update.
1437         * linux-fork.c: Update.
1438         * linux-nat.c: Update.
1439         * linux-tdep.c: Update.
1440         * linux-thread-db.c: Update.
1441         * main.c: Update.
1442         * mi/mi-cmd-break.c: Update.
1443         * mi/mi-cmd-stack.c: Update.
1444         * mi/mi-interp.c: Update.
1445         * mi/mi-main.c: Update.
1446         * objc-lang.c: Update.
1447         * p-valprint.c: Update.
1448         * parse.c: Update.
1449         * ppc-linux-tdep.c: Update.
1450         * printcmd.c: Update.
1451         * python/py-arch.c: Update.
1452         * python/py-breakpoint.c: Update.
1453         * python/py-cmd.c: Update.
1454         * python/py-finishbreakpoint.c: Update.
1455         * python/py-frame.c: Update.
1456         * python/py-framefilter.c: Update.
1457         * python/py-gdb-readline.c: Update.
1458         * python/py-inferior.c: Update.
1459         * python/py-infthread.c: Update.
1460         * python/py-lazy-string.c: Update.
1461         * python/py-linetable.c: Update.
1462         * python/py-objfile.c: Update.
1463         * python/py-param.c: Update.
1464         * python/py-prettyprint.c: Update.
1465         * python/py-progspace.c: Update.
1466         * python/py-record-btrace.c: Update.
1467         * python/py-record.c: Update.
1468         * python/py-symbol.c: Update.
1469         * python/py-type.c: Update.
1470         * python/py-unwind.c: Update.
1471         * python/py-utils.c: Update.
1472         * python/py-value.c: Update.
1473         * python/python.c: Update.
1474         * record-btrace.c: Update.
1475         * record-full.c: Update.
1476         * remote-fileio.c: Update.
1477         * remote.c: Update.
1478         * riscv-tdep.c: Update.
1479         * rs6000-aix-tdep.c: Update.
1480         * rs6000-tdep.c: Update.
1481         * rust-exp.y: Update.
1482         * rust-lang.c: Update.
1483         * s390-tdep.c: Update.
1484         * selftest-arch.c: Update.
1485         * solib-dsbt.c: Update.
1486         * solib-frv.c: Update.
1487         * solib-spu.c: Update.
1488         * solib-svr4.c: Update.
1489         * solib.c: Update.
1490         * sparc64-linux-tdep.c: Update.
1491         * stack.c: Update.
1492         * symfile-mem.c: Update.
1493         * symmisc.c: Update.
1494         * target.c: Update.
1495         * thread.c: Update.
1496         * top.c: Update.
1497         * tracefile-tfile.c: Update.
1498         * tui/tui.c: Update.
1499         * typeprint.c: Update.
1500         * unittests/cli-utils-selftests.c: Update.
1501         * unittests/parse-connection-spec-selftests.c: Update.
1502         * valops.c: Update.
1503         * valprint.c: Update.
1504         * value.c: Update.
1505         * varobj.c: Update.
1506         * windows-nat.c: Update.
1507         * x86-linux-nat.c: Update.
1508         * xml-support.c: Update.
1509
1510 2019-04-08  Tom Tromey  <tom@tromey.com>
1511
1512         * xml-support.c: Use C++ exception handling.
1513         * x86-linux-nat.c: Use C++ exception handling.
1514         * windows-nat.c: Use C++ exception handling.
1515         * varobj.c: Use C++ exception handling.
1516         * value.c: Use C++ exception handling.
1517         * valprint.c: Use C++ exception handling.
1518         * valops.c: Use C++ exception handling.
1519         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1520         handling.
1521         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1522         * typeprint.c: Use C++ exception handling.
1523         * tui/tui.c: Use C++ exception handling.
1524         * tracefile-tfile.c: Use C++ exception handling.
1525         * top.c: Use C++ exception handling.
1526         * thread.c: Use C++ exception handling.
1527         * target.c: Use C++ exception handling.
1528         * symmisc.c: Use C++ exception handling.
1529         * symfile-mem.c: Use C++ exception handling.
1530         * stack.c: Use C++ exception handling.
1531         * sparc64-linux-tdep.c: Use C++ exception handling.
1532         * solib.c: Use C++ exception handling.
1533         * solib-svr4.c: Use C++ exception handling.
1534         * solib-spu.c: Use C++ exception handling.
1535         * solib-frv.c: Use C++ exception handling.
1536         * solib-dsbt.c: Use C++ exception handling.
1537         * selftest-arch.c: Use C++ exception handling.
1538         * s390-tdep.c: Use C++ exception handling.
1539         * rust-lang.c: Use C++ exception handling.
1540         * rust-exp.y: Use C++ exception handling.
1541         * rs6000-tdep.c: Use C++ exception handling.
1542         * rs6000-aix-tdep.c: Use C++ exception handling.
1543         * riscv-tdep.c: Use C++ exception handling.
1544         * remote.c: Use C++ exception handling.
1545         * remote-fileio.c: Use C++ exception handling.
1546         * record-full.c: Use C++ exception handling.
1547         * record-btrace.c: Use C++ exception handling.
1548         * python/python.c: Use C++ exception handling.
1549         * python/py-value.c: Use C++ exception handling.
1550         * python/py-utils.c: Use C++ exception handling.
1551         * python/py-unwind.c: Use C++ exception handling.
1552         * python/py-type.c: Use C++ exception handling.
1553         * python/py-symbol.c: Use C++ exception handling.
1554         * python/py-record.c: Use C++ exception handling.
1555         * python/py-record-btrace.c: Use C++ exception handling.
1556         * python/py-progspace.c: Use C++ exception handling.
1557         * python/py-prettyprint.c: Use C++ exception handling.
1558         * python/py-param.c: Use C++ exception handling.
1559         * python/py-objfile.c: Use C++ exception handling.
1560         * python/py-linetable.c: Use C++ exception handling.
1561         * python/py-lazy-string.c: Use C++ exception handling.
1562         * python/py-infthread.c: Use C++ exception handling.
1563         * python/py-inferior.c: Use C++ exception handling.
1564         * python/py-gdb-readline.c: Use C++ exception handling.
1565         * python/py-framefilter.c: Use C++ exception handling.
1566         * python/py-frame.c: Use C++ exception handling.
1567         * python/py-finishbreakpoint.c: Use C++ exception handling.
1568         * python/py-cmd.c: Use C++ exception handling.
1569         * python/py-breakpoint.c: Use C++ exception handling.
1570         * python/py-arch.c: Use C++ exception handling.
1571         * printcmd.c: Use C++ exception handling.
1572         * ppc-linux-tdep.c: Use C++ exception handling.
1573         * parse.c: Use C++ exception handling.
1574         * p-valprint.c: Use C++ exception handling.
1575         * objc-lang.c: Use C++ exception handling.
1576         * mi/mi-main.c: Use C++ exception handling.
1577         * mi/mi-interp.c: Use C++ exception handling.
1578         * mi/mi-cmd-stack.c: Use C++ exception handling.
1579         * mi/mi-cmd-break.c: Use C++ exception handling.
1580         * main.c: Use C++ exception handling.
1581         * linux-thread-db.c: Use C++ exception handling.
1582         * linux-tdep.c: Use C++ exception handling.
1583         * linux-nat.c: Use C++ exception handling.
1584         * linux-fork.c: Use C++ exception handling.
1585         * linespec.c: Use C++ exception handling.
1586         * language.c: Use C++ exception handling.
1587         * jit.c: Use C++ exception handling.
1588         * infrun.c: Use C++ exception handling.
1589         * infcmd.c: Use C++ exception handling.
1590         * infcall.c: Use C++ exception handling.
1591         * inf-loop.c: Use C++ exception handling.
1592         * i386-tdep.c: Use C++ exception handling.
1593         * i386-linux-tdep.c: Use C++ exception handling.
1594         * guile/scm-value.c: Use C++ exception handling.
1595         * guile/scm-type.c: Use C++ exception handling.
1596         * guile/scm-symtab.c: Use C++ exception handling.
1597         * guile/scm-symbol.c: Use C++ exception handling.
1598         * guile/scm-pretty-print.c: Use C++ exception handling.
1599         * guile/scm-ports.c: Use C++ exception handling.
1600         * guile/scm-param.c: Use C++ exception handling.
1601         * guile/scm-math.c: Use C++ exception handling.
1602         * guile/scm-lazy-string.c: Use C++ exception handling.
1603         * guile/scm-frame.c: Use C++ exception handling.
1604         * guile/scm-disasm.c: Use C++ exception handling.
1605         * guile/scm-cmd.c: Use C++ exception handling.
1606         * guile/scm-breakpoint.c: Use C++ exception handling.
1607         * guile/scm-block.c: Use C++ exception handling.
1608         * guile/guile-internal.h: Use C++ exception handling.
1609         * gnu-v3-abi.c: Use C++ exception handling.
1610         * gdbtypes.c: Use C++ exception handling.
1611         * frame.c: Use C++ exception handling.
1612         * frame-unwind.c: Use C++ exception handling.
1613         * fbsd-tdep.c: Use C++ exception handling.
1614         * f-valprint.c: Use C++ exception handling.
1615         * exec.c: Use C++ exception handling.
1616         * event-top.c: Use C++ exception handling.
1617         * event-loop.c: Use C++ exception handling.
1618         * eval.c: Use C++ exception handling.
1619         * dwarf2read.c: Use C++ exception handling.
1620         * dwarf2loc.c: Use C++ exception handling.
1621         * dwarf2-frame.c: Use C++ exception handling.
1622         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1623         * dwarf-index-write.c: Use C++ exception handling.
1624         * dwarf-index-cache.c: Use C++ exception handling.
1625         * dtrace-probe.c: Use C++ exception handling.
1626         * disasm-selftests.c: Use C++ exception handling.
1627         * darwin-nat.c: Use C++ exception handling.
1628         * cp-valprint.c: Use C++ exception handling.
1629         * cp-support.c: Use C++ exception handling.
1630         * cp-abi.c: Use C++ exception handling.
1631         * corelow.c: Use C++ exception handling.
1632         * completer.c: Use C++ exception handling.
1633         * compile/compile-object-run.c: Use C++ exception handling.
1634         * compile/compile-object-load.c: Use C++ exception handling.
1635         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1636         * compile/compile-c-symbols.c: Use C++ exception handling.
1637         * common/selftest.c: Use C++ exception handling.
1638         * common/new-op.c: Use C++ exception handling.
1639         * cli/cli-script.c: Use C++ exception handling.
1640         * cli/cli-interp.c: Use C++ exception handling.
1641         * cli/cli-cmds.c: Use C++ exception handling.
1642         * c-varobj.c: Use C++ exception handling.
1643         * btrace.c: Use C++ exception handling.
1644         * breakpoint.c: Use C++ exception handling.
1645         * break-catch-throw.c: Use C++ exception handling.
1646         * arch-utils.c: Use C++ exception handling.
1647         * amd64-tdep.c: Use C++ exception handling.
1648         * ada-valprint.c: Use C++ exception handling.
1649         * ada-typeprint.c: Use C++ exception handling.
1650         * ada-lang.c: Use C++ exception handling.
1651         * aarch64-tdep.c: Use C++ exception handling.
1652
1653 2019-04-08  Tom Tromey  <tom@tromey.com>
1654
1655         * xml-support.c (gdb_xml_parser::parse): Update.
1656         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1657         * value.c (show_convenience): Update.
1658         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1659         (test_parse_flags_qcs): Update.
1660         * thread.c (thr_try_catch_cmd): Update.
1661         * target.c (target_translate_tls_address): Update.
1662         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1663         (info_frame_command_core, frame_apply_command_count): Update.
1664         * rust-exp.y (rust_lex_exception_test): Update.
1665         * riscv-tdep.c (riscv_print_one_register_info): Update.
1666         * remote.c (remote_target::enable_btrace): Update.
1667         * record-btrace.c (record_btrace_enable_warn): Update.
1668         * python/py-utils.c (gdbpy_convert_exception): Update.
1669         * printcmd.c (do_one_display, print_variable_and_value): Update.
1670         * mi/mi-main.c (mi_print_exception): Update.
1671         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1672         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1673         * linux-nat.c (linux_nat_target::attach): Update.
1674         * linux-fork.c (class scoped_switch_fork_info): Update.
1675         * infrun.c (displaced_step_prepare): Update.
1676         * infcall.c (call_function_by_hand_dummy): Update.
1677         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1678         * gnu-v3-abi.c (print_one_vtable): Update.
1679         * frame.c (get_prev_frame_always): Update.
1680         * f-valprint.c (info_common_command_for_block): Update.
1681         * exec.c (try_open_exec_file): Update.
1682         * exceptions.c (print_exception, exception_print)
1683         (exception_fprintf, exception_print_same): Update.
1684         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1685         * dwarf-index-cache.c (index_cache::store)
1686         (index_cache::lookup_gdb_index): Update.
1687         * darwin-nat.c (maybe_cache_shell): Update.
1688         * cp-valprint.c (cp_print_value_fields): Update.
1689         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1690         (gcc_cplus_symbol_address): Update.
1691         * compile/compile-c-symbols.c (gcc_convert_symbol)
1692         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1693         * common/selftest.c: Update.
1694         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1695         a std::string.
1696         (exception_try_scope_entry, exception_try_scope_exit): Don't
1697         declare.
1698         (struct exception_try_scope): Remove.
1699         (TRY): Don't use exception_try_scope.
1700         (struct gdb_exception): Add constructor, operator=.
1701         <what>: New method.
1702         (struct gdb_exception_RETURN_MASK_ALL)
1703         (struct gdb_exception_RETURN_MASK_ERROR)
1704         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1705         (struct gdb_quit_bad_alloc): Update.
1706         * common/common-exceptions.c (exception_none): Change
1707         initializer.
1708         (struct catcher) <state, exception>: Initialize inline.
1709         <prev>: Remove member.
1710         (current_catcher): Remove.
1711         (catchers): New global.
1712         (exceptions_state_mc_init): Simplify.
1713         (catcher_pop): Remove.
1714         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1715         (try_scope_depth, exception_try_scope_entry)
1716         (exception_try_scope_exit): Remove.
1717         (throw_exception_sjlj): Update.
1718         (exception_messages, exception_messages_size): Remove.
1719         (throw_it): Simplify.
1720         (gdb_exception_sliced_copy): Remove.
1721         (throw_exception_cxx): Update.
1722         * cli/cli-script.c (script_from_file): Update.
1723         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1724         Update.
1725         * ada-valprint.c (ada_val_print): Update.
1726         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1727         (create_excep_cond_exprs): Update.
1728
1729 2019-04-08  Tom Tromey  <tom@tromey.com>
1730
1731         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1732         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1733         (TRY, CATCH, END_CATCH): Remove some definitions.
1734         * common/common-exceptions.c: Don't use GDB_XCPT.
1735         (catcher_list_size): Remove.
1736         (throw_exception, throw_it): Simplify.
1737
1738 2019-04-05  Tom Tromey  <tom@tromey.com>
1739
1740         Revert the header-sorting patch.
1741         * ft32-tdep.c: Revert.
1742         * frv-tdep.c: Revert.
1743         * frv-linux-tdep.c: Revert.
1744         * frame.c: Revert.
1745         * frame-unwind.c: Revert.
1746         * frame-base.c: Revert.
1747         * fork-child.c: Revert.
1748         * findvar.c: Revert.
1749         * findcmd.c: Revert.
1750         * filesystem.c: Revert.
1751         * filename-seen-cache.h: Revert.
1752         * filename-seen-cache.c: Revert.
1753         * fbsd-tdep.c: Revert.
1754         * fbsd-nat.h: Revert.
1755         * fbsd-nat.c: Revert.
1756         * f-valprint.c: Revert.
1757         * f-typeprint.c: Revert.
1758         * f-lang.c: Revert.
1759         * extension.h: Revert.
1760         * extension.c: Revert.
1761         * extension-priv.h: Revert.
1762         * expprint.c: Revert.
1763         * exec.h: Revert.
1764         * exec.c: Revert.
1765         * exceptions.c: Revert.
1766         * event-top.c: Revert.
1767         * event-loop.c: Revert.
1768         * eval.c: Revert.
1769         * elfread.c: Revert.
1770         * dwarf2read.h: Revert.
1771         * dwarf2read.c: Revert.
1772         * dwarf2loc.c: Revert.
1773         * dwarf2expr.h: Revert.
1774         * dwarf2expr.c: Revert.
1775         * dwarf2-frame.c: Revert.
1776         * dwarf2-frame-tailcall.c: Revert.
1777         * dwarf-index-write.h: Revert.
1778         * dwarf-index-write.c: Revert.
1779         * dwarf-index-common.c: Revert.
1780         * dwarf-index-cache.h: Revert.
1781         * dwarf-index-cache.c: Revert.
1782         * dummy-frame.c: Revert.
1783         * dtrace-probe.c: Revert.
1784         * disasm.h: Revert.
1785         * disasm.c: Revert.
1786         * disasm-selftests.c: Revert.
1787         * dictionary.c: Revert.
1788         * dicos-tdep.c: Revert.
1789         * demangle.c: Revert.
1790         * dcache.h: Revert.
1791         * dcache.c: Revert.
1792         * darwin-nat.h: Revert.
1793         * darwin-nat.c: Revert.
1794         * darwin-nat-info.c: Revert.
1795         * d-valprint.c: Revert.
1796         * d-namespace.c: Revert.
1797         * d-lang.c: Revert.
1798         * ctf.c: Revert.
1799         * csky-tdep.c: Revert.
1800         * csky-linux-tdep.c: Revert.
1801         * cris-tdep.c: Revert.
1802         * cris-linux-tdep.c: Revert.
1803         * cp-valprint.c: Revert.
1804         * cp-support.c: Revert.
1805         * cp-namespace.c: Revert.
1806         * cp-abi.c: Revert.
1807         * corelow.c: Revert.
1808         * corefile.c: Revert.
1809         * continuations.c: Revert.
1810         * completer.h: Revert.
1811         * completer.c: Revert.
1812         * complaints.c: Revert.
1813         * coffread.c: Revert.
1814         * coff-pe-read.c: Revert.
1815         * cli-out.h: Revert.
1816         * cli-out.c: Revert.
1817         * charset.c: Revert.
1818         * c-varobj.c: Revert.
1819         * c-valprint.c: Revert.
1820         * c-typeprint.c: Revert.
1821         * c-lang.c: Revert.
1822         * buildsym.c: Revert.
1823         * buildsym-legacy.c: Revert.
1824         * build-id.h: Revert.
1825         * build-id.c: Revert.
1826         * btrace.c: Revert.
1827         * bsd-uthread.c: Revert.
1828         * breakpoint.h: Revert.
1829         * breakpoint.c: Revert.
1830         * break-catch-throw.c: Revert.
1831         * break-catch-syscall.c: Revert.
1832         * break-catch-sig.c: Revert.
1833         * blockframe.c: Revert.
1834         * block.c: Revert.
1835         * bfin-tdep.c: Revert.
1836         * bfin-linux-tdep.c: Revert.
1837         * bfd-target.c: Revert.
1838         * bcache.c: Revert.
1839         * ax-general.c: Revert.
1840         * ax-gdb.h: Revert.
1841         * ax-gdb.c: Revert.
1842         * avr-tdep.c: Revert.
1843         * auxv.c: Revert.
1844         * auto-load.c: Revert.
1845         * arm-wince-tdep.c: Revert.
1846         * arm-tdep.c: Revert.
1847         * arm-symbian-tdep.c: Revert.
1848         * arm-pikeos-tdep.c: Revert.
1849         * arm-obsd-tdep.c: Revert.
1850         * arm-nbsd-tdep.c: Revert.
1851         * arm-nbsd-nat.c: Revert.
1852         * arm-linux-tdep.c: Revert.
1853         * arm-linux-nat.c: Revert.
1854         * arm-fbsd-tdep.c: Revert.
1855         * arm-fbsd-nat.c: Revert.
1856         * arm-bsd-tdep.c: Revert.
1857         * arch-utils.c: Revert.
1858         * arc-tdep.c: Revert.
1859         * arc-newlib-tdep.c: Revert.
1860         * annotate.h: Revert.
1861         * annotate.c: Revert.
1862         * amd64-windows-tdep.c: Revert.
1863         * amd64-windows-nat.c: Revert.
1864         * amd64-tdep.c: Revert.
1865         * amd64-sol2-tdep.c: Revert.
1866         * amd64-obsd-tdep.c: Revert.
1867         * amd64-obsd-nat.c: Revert.
1868         * amd64-nbsd-tdep.c: Revert.
1869         * amd64-nbsd-nat.c: Revert.
1870         * amd64-nat.c: Revert.
1871         * amd64-linux-tdep.c: Revert.
1872         * amd64-linux-nat.c: Revert.
1873         * amd64-fbsd-tdep.c: Revert.
1874         * amd64-fbsd-nat.c: Revert.
1875         * amd64-dicos-tdep.c: Revert.
1876         * amd64-darwin-tdep.c: Revert.
1877         * amd64-bsd-nat.c: Revert.
1878         * alpha-tdep.c: Revert.
1879         * alpha-obsd-tdep.c: Revert.
1880         * alpha-nbsd-tdep.c: Revert.
1881         * alpha-mdebug-tdep.c: Revert.
1882         * alpha-linux-tdep.c: Revert.
1883         * alpha-linux-nat.c: Revert.
1884         * alpha-bsd-tdep.c: Revert.
1885         * alpha-bsd-nat.c: Revert.
1886         * aix-thread.c: Revert.
1887         * agent.c: Revert.
1888         * addrmap.c: Revert.
1889         * ada-varobj.c: Revert.
1890         * ada-valprint.c: Revert.
1891         * ada-typeprint.c: Revert.
1892         * ada-tasks.c: Revert.
1893         * ada-lang.c: Revert.
1894         * aarch64-tdep.c: Revert.
1895         * aarch64-ravenscar-thread.c: Revert.
1896         * aarch64-newlib-tdep.c: Revert.
1897         * aarch64-linux-tdep.c: Revert.
1898         * aarch64-linux-nat.c: Revert.
1899         * aarch64-fbsd-tdep.c: Revert.
1900         * aarch64-fbsd-nat.c: Revert.
1901         * aarch32-linux-nat.c: Revert.
1902
1903 2019-04-05  Tom Tromey  <tom@tromey.com>
1904
1905         * ft32-tdep.c: Sort headers.
1906         * frv-tdep.c: Sort headers.
1907         * frv-linux-tdep.c: Sort headers.
1908         * frame.c: Sort headers.
1909         * frame-unwind.c: Sort headers.
1910         * frame-base.c: Sort headers.
1911         * fork-child.c: Sort headers.
1912         * findvar.c: Sort headers.
1913         * findcmd.c: Sort headers.
1914         * filesystem.c: Sort headers.
1915         * filename-seen-cache.h: Sort headers.
1916         * filename-seen-cache.c: Sort headers.
1917         * fbsd-tdep.c: Sort headers.
1918         * fbsd-nat.h: Sort headers.
1919         * fbsd-nat.c: Sort headers.
1920         * f-valprint.c: Sort headers.
1921         * f-typeprint.c: Sort headers.
1922         * f-lang.c: Sort headers.
1923         * extension.h: Sort headers.
1924         * extension.c: Sort headers.
1925         * extension-priv.h: Sort headers.
1926         * expprint.c: Sort headers.
1927         * exec.h: Sort headers.
1928         * exec.c: Sort headers.
1929         * exceptions.c: Sort headers.
1930         * event-top.c: Sort headers.
1931         * event-loop.c: Sort headers.
1932         * eval.c: Sort headers.
1933         * elfread.c: Sort headers.
1934         * dwarf2read.h: Sort headers.
1935         * dwarf2read.c: Sort headers.
1936         * dwarf2loc.c: Sort headers.
1937         * dwarf2expr.h: Sort headers.
1938         * dwarf2expr.c: Sort headers.
1939         * dwarf2-frame.c: Sort headers.
1940         * dwarf2-frame-tailcall.c: Sort headers.
1941         * dwarf-index-write.h: Sort headers.
1942         * dwarf-index-write.c: Sort headers.
1943         * dwarf-index-common.c: Sort headers.
1944         * dwarf-index-cache.h: Sort headers.
1945         * dwarf-index-cache.c: Sort headers.
1946         * dummy-frame.c: Sort headers.
1947         * dtrace-probe.c: Sort headers.
1948         * disasm.h: Sort headers.
1949         * disasm.c: Sort headers.
1950         * disasm-selftests.c: Sort headers.
1951         * dictionary.c: Sort headers.
1952         * dicos-tdep.c: Sort headers.
1953         * demangle.c: Sort headers.
1954         * dcache.h: Sort headers.
1955         * dcache.c: Sort headers.
1956         * darwin-nat.h: Sort headers.
1957         * darwin-nat.c: Sort headers.
1958         * darwin-nat-info.c: Sort headers.
1959         * d-valprint.c: Sort headers.
1960         * d-namespace.c: Sort headers.
1961         * d-lang.c: Sort headers.
1962         * ctf.c: Sort headers.
1963         * csky-tdep.c: Sort headers.
1964         * csky-linux-tdep.c: Sort headers.
1965         * cris-tdep.c: Sort headers.
1966         * cris-linux-tdep.c: Sort headers.
1967         * cp-valprint.c: Sort headers.
1968         * cp-support.c: Sort headers.
1969         * cp-namespace.c: Sort headers.
1970         * cp-abi.c: Sort headers.
1971         * corelow.c: Sort headers.
1972         * corefile.c: Sort headers.
1973         * continuations.c: Sort headers.
1974         * completer.h: Sort headers.
1975         * completer.c: Sort headers.
1976         * complaints.c: Sort headers.
1977         * coffread.c: Sort headers.
1978         * coff-pe-read.c: Sort headers.
1979         * cli-out.h: Sort headers.
1980         * cli-out.c: Sort headers.
1981         * charset.c: Sort headers.
1982         * c-varobj.c: Sort headers.
1983         * c-valprint.c: Sort headers.
1984         * c-typeprint.c: Sort headers.
1985         * c-lang.c: Sort headers.
1986         * buildsym.c: Sort headers.
1987         * buildsym-legacy.c: Sort headers.
1988         * build-id.h: Sort headers.
1989         * build-id.c: Sort headers.
1990         * btrace.c: Sort headers.
1991         * bsd-uthread.c: Sort headers.
1992         * breakpoint.h: Sort headers.
1993         * breakpoint.c: Sort headers.
1994         * break-catch-throw.c: Sort headers.
1995         * break-catch-syscall.c: Sort headers.
1996         * break-catch-sig.c: Sort headers.
1997         * blockframe.c: Sort headers.
1998         * block.c: Sort headers.
1999         * bfin-tdep.c: Sort headers.
2000         * bfin-linux-tdep.c: Sort headers.
2001         * bfd-target.c: Sort headers.
2002         * bcache.c: Sort headers.
2003         * ax-general.c: Sort headers.
2004         * ax-gdb.h: Sort headers.
2005         * ax-gdb.c: Sort headers.
2006         * avr-tdep.c: Sort headers.
2007         * auxv.c: Sort headers.
2008         * auto-load.c: Sort headers.
2009         * arm-wince-tdep.c: Sort headers.
2010         * arm-tdep.c: Sort headers.
2011         * arm-symbian-tdep.c: Sort headers.
2012         * arm-pikeos-tdep.c: Sort headers.
2013         * arm-obsd-tdep.c: Sort headers.
2014         * arm-nbsd-tdep.c: Sort headers.
2015         * arm-nbsd-nat.c: Sort headers.
2016         * arm-linux-tdep.c: Sort headers.
2017         * arm-linux-nat.c: Sort headers.
2018         * arm-fbsd-tdep.c: Sort headers.
2019         * arm-fbsd-nat.c: Sort headers.
2020         * arm-bsd-tdep.c: Sort headers.
2021         * arch-utils.c: Sort headers.
2022         * arc-tdep.c: Sort headers.
2023         * arc-newlib-tdep.c: Sort headers.
2024         * annotate.h: Sort headers.
2025         * annotate.c: Sort headers.
2026         * amd64-windows-tdep.c: Sort headers.
2027         * amd64-windows-nat.c: Sort headers.
2028         * amd64-tdep.c: Sort headers.
2029         * amd64-sol2-tdep.c: Sort headers.
2030         * amd64-obsd-tdep.c: Sort headers.
2031         * amd64-obsd-nat.c: Sort headers.
2032         * amd64-nbsd-tdep.c: Sort headers.
2033         * amd64-nbsd-nat.c: Sort headers.
2034         * amd64-nat.c: Sort headers.
2035         * amd64-linux-tdep.c: Sort headers.
2036         * amd64-linux-nat.c: Sort headers.
2037         * amd64-fbsd-tdep.c: Sort headers.
2038         * amd64-fbsd-nat.c: Sort headers.
2039         * amd64-dicos-tdep.c: Sort headers.
2040         * amd64-darwin-tdep.c: Sort headers.
2041         * amd64-bsd-nat.c: Sort headers.
2042         * alpha-tdep.c: Sort headers.
2043         * alpha-obsd-tdep.c: Sort headers.
2044         * alpha-nbsd-tdep.c: Sort headers.
2045         * alpha-mdebug-tdep.c: Sort headers.
2046         * alpha-linux-tdep.c: Sort headers.
2047         * alpha-linux-nat.c: Sort headers.
2048         * alpha-bsd-tdep.c: Sort headers.
2049         * alpha-bsd-nat.c: Sort headers.
2050         * aix-thread.c: Sort headers.
2051         * agent.c: Sort headers.
2052         * addrmap.c: Sort headers.
2053         * ada-varobj.c: Sort headers.
2054         * ada-valprint.c: Sort headers.
2055         * ada-typeprint.c: Sort headers.
2056         * ada-tasks.c: Sort headers.
2057         * ada-lang.c: Sort headers.
2058         * aarch64-tdep.c: Sort headers.
2059         * aarch64-ravenscar-thread.c: Sort headers.
2060         * aarch64-newlib-tdep.c: Sort headers.
2061         * aarch64-linux-tdep.c: Sort headers.
2062         * aarch64-linux-nat.c: Sort headers.
2063         * aarch64-fbsd-tdep.c: Sort headers.
2064         * aarch64-fbsd-nat.c: Sort headers.
2065         * aarch32-linux-nat.c: Sort headers.
2066
2067 2019-04-04  Tom Tromey  <tom@tromey.com>
2068
2069         * varobj.c (varobj_create): Update.
2070         * rust-exp.y (struct rust_parser) <update_innermost_block,
2071         lookup_symbol>: New methods.
2072         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2073         Rename.
2074         (rust_parser::rust_lookup_type)
2075         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2076         * printcmd.c (display_command, do_one_display): Update.
2077         * parser-defs.h (struct parser_state) <parser_state>: Add
2078         "tracker" parameter.
2079         (block_tracker): New member.
2080         (class innermost_block_tracker) <innermost_block_tracker>: Add
2081         "types" parameter.
2082         <reset>: Remove method.
2083         (innermost_block): Don't declare.
2084         (null_post_parser): Update.
2085         * parse.c (innermost_block): Remove global.
2086         (write_dollar_variable): Update.
2087         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2088         Remove "tracker_types" parameter.
2089         (parse_expression): Add "tracker" parameter.
2090         (parse_expression_for_completion): Update.
2091         (null_post_parser): Add "tracker" parameter.
2092         * p-exp.y: Update rules.
2093         * m2-exp.y: Update rules.
2094         * language.h (struct language_defn) <la_post_parser>: Add
2095         "tracker" parameter.
2096         * go-exp.y: Update rules.
2097         * f-exp.y: Update rules.
2098         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2099         parameter.
2100         * d-exp.y: Update rules.
2101         * c-exp.y: Update rules.
2102         * breakpoint.c (set_breakpoint_condition): Create an
2103         innermost_block_tracker.
2104         (watch_command_1): Likewise.
2105         * ada-lang.c (resolve): Add "tracker" parameter.
2106         (resolve_subexp): Likewise.
2107         * ada-exp.y (write_var_from_sym): Update.
2108
2109 2019-04-04  Tom Tromey  <tom@tromey.com>
2110
2111         * type-stack.h: New file.
2112         * type-stack.c: New file.
2113         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2114         type-stack.h.
2115         (insert_into_type_stack, insert_type, push_type, push_type_int)
2116         (insert_type_address_space, pop_type, pop_type_int)
2117         (pop_typelist, pop_type_stack, append_type_stack)
2118         (push_type_stack, get_type_stack, push_typelist)
2119         (follow_type_instance_flags, follow_types): Don't declare.
2120         * parse.c (type_stack): Remove global.
2121         (parse_exp_in_context): Update.
2122         (insert_into_type_stack, insert_type, push_type, push_type_int)
2123         (insert_type_address_space, pop_type, pop_type_int)
2124         (pop_typelist, pop_type_stack, append_type_stack)
2125         (push_type_stack, get_type_stack, push_typelist)
2126         (follow_type_instance_flags, follow_types): Remove (moved to
2127         type-stack.c).
2128         * f-exp.y (type_stack): New global.
2129         Update rules.
2130         (push_kind_type, f_parse): Update.
2131         * d-exp.y (type_stack): New global.
2132         Update rules.
2133         (d_parse): Update.
2134         * c-exp.y (struct c_parse_state) <type_stack>: New member.
2135         Update rules.
2136         * Makefile.in (COMMON_SFILES): Add type-stack.c.
2137         (HFILES_NO_SRCDIR): Add type-stack.h.
2138
2139 2019-04-04  Tom Tromey  <tom@tromey.com>
2140
2141         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
2142         (rust_parser::convert_ast_to_expression, rust_parse)
2143         (rust_lex_test_completion, rust_lex_tests): Update.
2144         * parser-defs.h (struct expr_completion_state): New.
2145         (struct parser_state) <parser_state>: Add completion parameter.
2146         <mark_struct_expression, mark_completion_tag>: New methods.
2147         <parse_completion, m_completion_state>: New members.
2148         (prefixify_expression, null_post_parser): Update.
2149         (mark_struct_expression, mark_completion_tag): Don't declare.
2150         * parse.c (parse_completion, expout_last_struct)
2151         (expout_tag_completion_type, expout_completion_name): Remove
2152         globals.
2153         (parser_state::mark_struct_expression)
2154         (parser_state::mark_completion_tag): Now methods.
2155         (prefixify_expression): Add last_struct parameter.
2156         (prefixify_subexp): Likewise.
2157         (parse_exp_1): Update.
2158         (parse_exp_in_context): Add cstate parameter.  Update.
2159         (parse_expression_for_completion): Create an
2160         expr_completion_state.
2161         (null_post_parser): Add "completion" parameter.
2162         * p-exp.y: Update rules.
2163         (yylex): Update.
2164         * language.h (struct language_defn) <la_post_parser>: Add
2165         "completing" parameter.
2166         * go-exp.y: Update rules.
2167         (lex_one_token): Update.
2168         * expression.h (parse_completion): Don't declare.
2169         * d-exp.y: Update rules.
2170         (lex_one_token): Update rules.
2171         * c-exp.y: Update rules.
2172         (lex_one_token): Update.
2173         * ada-lang.c (resolve): Add "parse_completion" parameter.
2174         (resolve_subexp): Likewise.
2175         (ada_resolve_function): Likewise.
2176
2177 2019-04-04  Tom Tromey  <tom@tromey.com>
2178
2179         * parser-defs.h (struct parser_state) <start_arglist,
2180         end_arglist>: New methods.
2181         <arglist_len, m_funcall_chain>: New members.
2182         (arglist_len, start_arglist, end_arglist): Don't declare.
2183         * parse.c (arglist_len, funcall_chain): Remove global.
2184         (start_arglist, end_arglist): Remove functions.
2185         (parse_exp_in_context): Update.
2186         * p-exp.y: Update rules.
2187         * m2-exp.y: Update rules.
2188         * go-exp.y: Update rules.
2189         * f-exp.y: Update rules.
2190         * d-exp.y: Update rules.
2191         * c-exp.y: Update rules.
2192
2193 2019-04-04  Tom Tromey  <tom@tromey.com>
2194
2195         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
2196         lex_operator, push_back>: New methods.
2197         Update all rules.
2198         (rust_parser::lex_hex, lex_escape): Rename and update.
2199         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
2200         (rust_parser::lex_operator): Rename and update.
2201         (rust_parser::lex_number, rustyylex, rustyyerror)
2202         (rust_lex_test_init, rust_lex_test_sequence)
2203         (rust_lex_test_push_back, rust_lex_tests): Update.
2204         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
2205         parameter.
2206         <lexptr, prev_lexptr>: New members.
2207         (lexptr, prev_lexptr): Don't declare.
2208         * parse.c (lexptr, prev_lexptr): Remove globals.
2209         (parse_exp_in_context): Update.
2210         * p-exp.y (yylex, yyerror): Update.
2211         * m2-exp.y (parse_number, yylex, yyerror): Update.
2212         * go-exp.y (lex_one_token, yyerror): Update.
2213         * f-exp.y (match_string_literal, yylex, yyerror): Update.
2214         * d-exp.y (lex_one_token, yyerror): Update.
2215         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
2216         (lex_one_token, yyerror): Update.
2217         * ada-lex.l (YY_INPUT): Update.
2218         (rewind_to_char): Update.
2219         * ada-exp.y (yyerror): Update.
2220
2221 2019-04-04  Tom Tromey  <tom@tromey.com>
2222
2223         * rust-exp.y (rustyylex, rust_lex_tests): Update.
2224         * parser-defs.h (struct parser_state) <parser_state>: Add new
2225         parameter.
2226         <comma_terminates>: New member.
2227         (comma_terminates): Don't declare global.
2228         * parse.c (comma_terminates): Remove global.
2229         (parse_exp_in_context): Update.
2230         * p-exp.y (yylex): Update.
2231         * m2-exp.y (yylex): Update.
2232         * go-exp.y (lex_one_token): Update.
2233         * f-exp.y (yylex): Update.
2234         * d-exp.y (lex_one_token): Update.
2235         * c-exp.y (lex_one_token): Update.
2236         * ada-lex.l: Update.
2237
2238 2019-04-04  Tom Tromey  <tom@tromey.com>
2239
2240         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
2241         (rustyylex, rust_lex_test_init, rust_lex_test_one)
2242         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
2243         * parser-defs.h (paren_depth): Don't declare.
2244         * parse.c (paren_depth): Remove global.
2245         (parse_exp_in_context): Update.
2246         * p-exp.y (paren_depth): New global.
2247         (pascal_parse): Initialize it.
2248         * m2-exp.y (paren_depth): New global.
2249         (m2_parse): Initialize it.
2250         * go-exp.y (paren_depth): New global.
2251         (go_parse): Initialize it.
2252         * f-exp.y (paren_depth): New global.
2253         (f_parse): Initialize it.
2254         * d-exp.y (paren_depth): New global.
2255         (d_parse): Initialize it.
2256         * c-exp.y (paren_depth): New global.
2257         (c_parse): Initialize it.
2258         * ada-lex.l (paren_depth): New global.
2259         (lexer_init): Initialize it.
2260
2261 2019-04-04  Tom Tromey  <tom@tromey.com>
2262
2263         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
2264         (rust_parser::convert_ast_to_type)
2265         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2266         * parser-defs.h (struct parser_state) <parser_state>: Add
2267         parameters.  Initialize new members.
2268         <expression_context_block, expression_context_pc>: New members.
2269         * parse.c (expression_context_block, expression_context_pc):
2270         Remove globals.
2271         (parse_exp_in_context): Update.
2272         * p-exp.y: Update all rules.
2273         (yylex): Update.
2274         * m2-exp.y: Update all rules.
2275         (yylex): Update.
2276         * go-exp.y (yylex): Update.
2277         * f-exp.y (yylex): Update.
2278         * d-exp.y: Update all rules.
2279         (yylex): Update.
2280         * c-exp.y: Update all rules.
2281         (lex_one_token, classify_name, yylex, c_parse): Update.
2282         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2283
2284 2019-04-04  Tom Tromey  <tom@tromey.com>
2285
2286         * gdbarch.h, gdbarch.c: Rebuild.
2287         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2288         * stap-probe.h:
2289         (struct stap_parse_info): Replace "parser_state" with
2290         "expr_builder".
2291         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2292         (parser_state): New class.
2293         * parse.c (expr_builder): Rename.
2294         (expr_builder::release): Rename.
2295         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2296         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2297         (write_exp_elt_longcst, write_exp_elt_floatcst)
2298         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2299         (write_exp_string_vector, write_exp_bitstring)
2300         (write_exp_msymbol, mark_struct_expression)
2301         (write_dollar_variable)
2302         (insert_type_address_space, increase_expout_size): Replace
2303         "parser_state" with "expr_builder".
2304         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2305         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2306         "parser_state" with "expr_builder".
2307
2308 2019-04-04  Tom Tromey  <tom@tromey.com>
2309
2310         * rust-exp.y: Replace "parse_language" with method call.
2311         * p-exp.y:
2312         (yylex): Replace "parse_language" with method call.
2313         * m2-exp.y:
2314         (yylex): Replace "parse_language" with method call.
2315         * go-exp.y (classify_name): Replace "parse_language" with method
2316         call.
2317         * f-exp.y (yylex): Replace "parse_language" with method call.
2318         * d-exp.y (lex_one_token): Replace "parse_language" with method
2319         call.
2320         * c-exp.y:
2321         (lex_one_token, classify_name, yylex): Replace "parse_language"
2322         with method call.
2323         * ada-exp.y (find_primitive_type, type_char)
2324         (type_system_address): Replace "parse_language" with method call.
2325
2326 2019-04-04  Tom Tromey  <tom@tromey.com>
2327
2328         * rust-exp.y: Replace "parse_gdbarch" with method call.
2329         * parse.c (write_dollar_variable, insert_type_address_space):
2330         Replace "parse_gdbarch" with method call.
2331         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2332         call.
2333         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2334         call.
2335         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2336         "parse_gdbarch" with method call.
2337         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2338         with method call.
2339         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2340         "parse_gdbarch" with method call.
2341         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2342         "parse_gdbarch" with method call.
2343         * c-exp.y (parse_type, parse_number, classify_name): Replace
2344         "parse_gdbarch" with method call.
2345         * ada-lex.l: Replace "parse_gdbarch" with method call.
2346         * ada-exp.y (parse_type, find_primitive_type, type_char)
2347         (type_system_address): Replace "parse_gdbarch" with method call.
2348
2349 2019-04-04  Tom Tromey  <tom@tromey.com>
2350
2351         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2352         * stap-probe.c (stap_parse_argument): Update.
2353         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2354         initial_size parameter.
2355         * rust-exp.y (rust_lex_tests): Update.
2356         * parse.c (parser_state): Update.
2357         (parse_exp_in_context): Update.
2358         * parser-defs.h (struct parser_state) <parser_state>: Remove
2359         "initial_size" parameter.
2360
2361 2019-04-04  Tom Tromey  <tom@tromey.com>
2362
2363         * parser-defs.h (increase_expout_size): Don't declare.
2364         * parse.c (increase_expout_size): Now static.
2365
2366 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2367
2368         * gnu-nat.c (gnu_nat_target::wait): Fix
2369         target_waitstatus_to_string call.
2370
2371 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2372
2373         * eval.c (evaluate_subexp_standard): Handle internal functions
2374         during Fortran function call handling.
2375
2376 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2377
2378         * NEWS: Mention new internal functions.
2379         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2380         (read_base_type): Use dwarf2_init_complex_target_type.
2381         * value.c (creal_internal_fn): New function.
2382         (cimag_internal_fn): New function.
2383         (_initialize_values): Register new internal functions.
2384
2385 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2386
2387         * infrun.c (stop_all_threads): If debug_infrun, always
2388         trace the wait status after wait_one, using
2389         target_waitstatus_to_string and target_pid_to_str.
2390         (handle_inferior_event): Replace various trace of
2391         wait status kind by a single trace.
2392         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2393         wait status kind image by target_waitstatus_to_string.
2394         * target/waitstatus.c (target_waitstatus_to_string): Fix
2395         obsolete comment.
2396
2397 2019-04-01  Tom Tromey  <tromey@adacore.com>
2398
2399         PR symtab/23331:
2400         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2401
2402 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2403             Pedro Alves  <palves@redhat.com>
2404
2405         * top.c (quit_force): Call 'finalize_values'.
2406         * value.c (finalize_values): New function.
2407         * value.h (finalize_values): Declare.
2408
2409 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2410
2411         * NEWS: Announce $_gdb_major and $_gdb_minor.
2412
2413         * top.c (init_gdb_version_vars): New function.
2414         (gdb_init): Call init_gdb_version_vars.
2415
2416 2019-03-29  Tom Tromey  <tromey@adacore.com>
2417
2418         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2419         help text.  Remove dead code.
2420
2421 2019-03-29  Keith Seitz  <keiths@redhat.com>
2422
2423         From Siddhesh Poyarekar:
2424         * f-lang.h (f77_get_upperbound): Return LONGEST.
2425         (f77_get_lowerbound): Likewise.
2426         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2427         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2428         print them.
2429         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2430         plongest to format print it.
2431         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2432         (f77_get_upperbound): Likewise.
2433         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2434         LOWER_BOUND to LONGEST.
2435         (f77_create_arrayprint_offset_tbl): Likewise.
2436
2437 2019-03-29  Keith Seitz  <keiths@redhat.com>
2438
2439         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2440         %s/pulongest for TYPE_LENGTH instead of %d in format
2441         strings.
2442         * ada-typerint.c (ada_print_type): Likewise.
2443         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2444         * compile/compile-c-support.c (generate_register_struct): Likewise.
2445         * gdbtypes.c (recursive_dump_type): Likewise.
2446         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2447         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2448         instead of %d in format strings.
2449         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2450         to std::min to ULONGEST.
2451         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2452         instead of %d in format strings.
2453         * tracepoint.c (info_scope_command): Likewise.
2454         * typeprint.c (print_offset_data::update)
2455         (print_offset_data::finish): Likewise.
2456         * xtensa-tdep.c (xtensa_store_return_value)
2457         (xtensa_push_dummy_call): Likewise.
2458
2459 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2460
2461         * windows-nat.c (display_selector): Fixed format specifications
2462         for 64-bit Cygwin.
2463
2464 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2465
2466         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2467
2468 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2469
2470         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2471         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2472         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2473         (nios2_linux_init_abi): Install it.
2474
2475 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2476
2477         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2478
2479 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2480
2481         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2482
2483 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2484             Tom Tromey  <tromey@adacore.com>
2485
2486         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2487
2488 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2489
2490         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2491         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2492         method to compute the bounds of range types. Also print "[evaluated]"
2493         if the bounds' values come from a dynamic evaluation.
2494
2495 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2496
2497         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2498         whitespace when pretty printing is on.
2499
2500 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2501
2502         * ppc-linux-nat.c: Add include.
2503
2504 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2505
2506         * NEWS: Mention AArch64 Pointer Authentication.
2507
2508 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2509
2510         * arm-linux-nat.c: Add include.
2511
2512 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2513
2514         * source-cache.c (source_cache::get_source_lines): Re-read
2515         fullname after calling open_source_file.
2516
2517 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2518
2519         * NEWS: Mention TLS support for FreeBSD.
2520
2521 2019-03-25  Tom Tromey  <tromey@adacore.com>
2522
2523         * minsyms.c (BUNCH_SIZE): Update comment.
2524         (~minimal_symbol_reader): Remove old comment.
2525         (compact_minimal_symbols): Update comment.
2526         (minimal_symbol_reader::install): Remove old comment.  Update
2527         other comments.
2528
2529 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2530
2531         * s390-linux-nat.c: Add include.
2532
2533 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2534
2535         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2536         Call linux_get_hwcap.
2537         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2538         Likewise.
2539         (aarch64_linux_get_hwcap): Remove function.
2540         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2541         declaration.
2542         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2543         linux_get_hwcap.
2544         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2545         * linux-tdep.c (linux_get_hwcap): Add function.
2546         (linux_get_hwcap2): Likewise.
2547         * linux-tdep.h (linux_get_hwcap): Add declaration.
2548         (linux_get_hwcap2): Likewise.
2549         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2550         (ppc_linux_get_hwcap2): Likewise.
2551         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2552         linux_get_hwcap.
2553         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2554         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2555         (ppc_linux_nat_target::read_description): Likewise.
2556         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2557         * s390-linux-nat.c: Likewise.
2558         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2559
2560 2019-03-24  Tom Tromey  <tom@tromey.com>
2561
2562         * ada-lang.c (standard_lookup): Simplify initialization.
2563         (ada_lookup_symbol_nonlocal): Simplify return.
2564         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2565         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2566         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2567         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2568         initialization.
2569         * solib.c (solib_global_lookup): Simplify.
2570         * symtab.c (null_block_symbol): Remove.
2571         (symbol_cache_lookup): Simplify returns.
2572         (lookup_language_this): Simplify returns.
2573         (lookup_symbol_aux): Simplify return.
2574         (lookup_local_symbol): Simplify returns.
2575         (lookup_global_symbol_from_objfile): Simplify return.
2576         (lookup_symbol_in_objfile_symtabs)
2577         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2578         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2579         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2580         * cp-namespace.c (cp_lookup_bare_symbol)
2581         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2582         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2583         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2584         (cp_lookup_symbol_via_imports): Simplify initialization.
2585         (find_symbol_in_baseclass): Likewise.
2586         * symtab.h (null_block_symbol): Remove.
2587         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2588         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2589         (d_lookup_symbol_module): Likewise.
2590         (find_symbol_in_baseclass): Simplify initialization.
2591
2592 2019-03-24  Tom Tromey  <tom@tromey.com>
2593
2594         * expression.h: Don't include symtab.h.
2595         (struct block): Forward declare.
2596
2597 2019-03-24  Tom Tromey  <tom@tromey.com>
2598
2599         * c-exp.y (typebase): Remove casts.
2600         * gdbtypes.c (lookup_unsigned_typename, )
2601         (lookup_signed_typename): Remove cast.
2602         * eval.c (parse_to_comma_and_eval): Remove cast.
2603         * parse.c (write_dollar_variable): Remove cast.
2604         * block.h (struct block) <superblock>: Now const.
2605         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2606         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2607         (map_block): Make "block" const.
2608         * symfile.h (struct quick_symbol_functions)
2609         <map_matching_symbols>: Constify block argument to "callback".
2610         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2611         const.
2612         (find_pc_sect_compunit_symtab): Make "b" const.
2613         (find_symbol_at_address): Likewise.
2614         (search_symbols): Likewise.
2615         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2616         (dw2_debug_names_lookup_symbol): Likewise.
2617         (dw2_map_matching_symbols): Update.
2618         * p-valprint.c (pascal_val_print): Remove "block".
2619         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2620         (aux_add_nonlocal_symbols): Make "block" const.
2621         (resolve_subexp): Remove cast.
2622         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2623         const.
2624         (iterate_over_file_blocks): Likewise.
2625         * f-exp.y (%union) <bval>: Remove.
2626         * coffread.c (patch_opaque_types): Make "b" const.
2627         * spu-tdep.c (spu_catch_start): Make "block" const.
2628         * c-valprint.c (print_unpacked_pointer): Remove "block".
2629         * symmisc.c (dump_symtab_1): Make "b" const.
2630         (block_depth): Make "block" const.
2631         * d-exp.y (%union) <bval>: Remove.
2632         * cp-support.h (cp_lookup_rtti_type): Update.
2633         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2634         * psymtab.c (psym_lookup_symbol): Make "block" const.
2635         (maintenance_check_psymtabs): Make "b" const.
2636         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2637         (enumerate_locals, enumerate_args): Update.
2638         * python/py-symtab.c (stpy_global_block): Make "block" const.
2639         (stpy_static_block): Likewise.
2640         * inline-frame.c (block_starting_point_at): Make "new_block"
2641         const.
2642         * block.c (find_block_in_blockvector): Make return type const.
2643         (blockvector_for_pc_sect): Make "b" const.
2644         (find_block_in_blockvector): Make "b" const.
2645
2646 2019-03-23  Tom Tromey  <tom@tromey.com>
2647
2648         * varobj.c (varobj_create): Update.
2649         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2650         * printcmd.c (display_command, do_one_display): Don't reset
2651         innermost_block.
2652         * parser-defs.h (enum innermost_block_tracker_type): Move to
2653         expression.h.
2654         (innermost_block): Update comment.
2655         * parse.c (parse_exp_1): Add tracker_types parameter.
2656         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2657         tracker_types parameter.  Reset innermost_block.
2658         (parse_exp_in_context): Remove.
2659         (parse_expression_for_completion): Update.
2660         * objfiles.c (~objfile): Don't reset expression_context_block or
2661         innermost_block.
2662         * expression.h (enum innermost_block_tracker_type): Move from
2663         parser-defs.h.
2664         (parse_exp_1): Add tracker_types parameter.
2665         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2666         reset innermost_block.
2667
2668 2019-03-23  Tom Tromey  <tom@tromey.com>
2669
2670         * objfiles.h: Include bcache.h.
2671
2672 2019-03-23  Tom Tromey  <tom@tromey.com>
2673
2674         * linespec.c (get_current_search_block): Use
2675         scoped_restore_current_language.
2676         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2677
2678 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2679             Jiong Wang  <jiong.wang@arm.com>
2680
2681         * aarch64-linux-tdep.c
2682         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2683         section.
2684         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2685
2686 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2687             Jiong Wang  <jiong.wang@arm.com>
2688
2689         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2690         instructions.
2691         (aarch64_analyze_prologue_test): Add PACIASP test.
2692         (aarch64_prologue_prev_register): Unmask PC value.
2693
2694 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2695             Jiong Wang  <jiong.wang@arm.com>
2696
2697         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2698         (aarch64_dwarf2_prev_register): Unmask PC value.
2699         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2700         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2701         DW_CFA_AARCH64_negate_ra_state.
2702         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2703
2704 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2705             Jiong Wang  <jiong.wang@arm.com>
2706
2707         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2708         registers.
2709         (aarch64_pseudo_register_name): Likewise.
2710         (aarch64_pseudo_register_type): Likewise.
2711         (aarch64_pseudo_register_reggroup_p): Likewise.
2712         (aarch64_gdbarch_init): Add pauth registers.
2713         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2714         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2715         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2716         (struct gdbarch_tdep): Add regnum for ra_state.
2717
2718 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2719             Jiong Wang  <jiong.wang@arm.com>
2720
2721         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2722
2723 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2724             Jiong Wang  <jiong.wang@arm.com>
2725
2726         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2727         function.
2728         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2729         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2730         (aarch64_gdbarch_init): Add puth registers.
2731         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2732         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2733         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2734
2735 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2736             Jiong Wang  <jiong.wang@arm.com>
2737
2738         * aarch64-linux-nat.c
2739         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2740         * aarch64-linux-tdep.c
2741         (aarch64_linux_core_read_description): Likewise.
2742         (aarch64_linux_get_hwcap): New function.
2743         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2744         (aarch64_linux_get_hwcap): New declaration.
2745
2746 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2747             Jiong Wang  <jiong.wang@arm.com>
2748
2749         * aarch64-linux-nat.c
2750         (aarch64_linux_nat_target::read_description): Add pauth param.
2751         * aarch64-linux-tdep.c
2752         (aarch64_linux_core_read_description): Likewise.
2753         * aarch64-tdep.c (struct target_desc): Add in pauth.
2754         (aarch64_read_description): Add pauth param.
2755         (aarch64_gdbarch_init): Likewise.
2756         * aarch64-tdep.h (aarch64_read_description): Likewise.
2757         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2758         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2759         * features/Makefile: Add new files.
2760         * features/aarch64-pauth.c: New file.
2761         * features/aarch64-pauth.xml: New file.
2762
2763 2019-03-20  Tom Tromey  <tromey@adacore.com>
2764
2765         * infrun.c (handle_inferior_event): Rename from
2766         handle_inferior_event_1.  Create a scoped_value_mark.
2767         (handle_inferior_event): Remove.
2768
2769 2019-03-19  Tom Tromey  <tromey@adacore.com>
2770
2771         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2772         * infrun.h (print_stop_event): Add "displays" parameter.
2773         * infrun.c (print_stop_event): Add "displays" parameter.
2774
2775 2019-03-19  Pedro Alves  <palves@redhat.com>
2776
2777         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2778         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2779         to -1.  Fix TABs vs spaces.
2780         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2781         * tui/tui-out.h (tui_ui_out) Add intro comments.
2782         <m_line, m_start_of_line>: In-class initialize, and add describing
2783         comment.
2784
2785 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2786
2787         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2788         variable names.
2789         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2790
2791 2019-03-18  Pedro Alves  <palves@redhat.com>
2792             Eli Zaretskii <eliz@gnu.org>
2793
2794         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2795         m_line and m_start_of_line.
2796
2797 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2798
2799         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2800         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2801         it returns a newline.  This fixes a regression in TU mode, whereby
2802         the next line is output on the same screen line as the user input.
2803
2804 2019-03-18  Tom Tromey  <tromey@adacore.com>
2805
2806         * minsyms.c (minimal_symbol_reader::install): Remove call to
2807         obstack_blank.
2808
2809 2019-03-18  Pedro Alves  <palves@redhat.com>
2810
2811         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2812         New globals.
2813         (apply_style): New, factored out from ...
2814         (apply_ansi_escape): ... this.  Handle reverse video mode.
2815         (tui_set_reverse_mode): New function.
2816         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2817         * tui/tui-winsource.c (tui_show_source_line): Use
2818         tui_set_reverse_mode instead of setting A_STANDOUT.
2819         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2820         New setter methods.
2821
2822 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2823
2824         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2825         Handle tabs.
2826
2827 2019-03-18  Tom Tromey  <tromey@adacore.com>
2828
2829         * ada-lang.c (empty_array): Add "high" parameter.
2830         (ada_evaluate_subexp): Update.
2831
2832 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2833
2834         * unittests/string_view-selftests.c: Define
2835         _initialize_string_view_selftests unconditionally.
2836
2837 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2838
2839         PR gdb/24350
2840         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2841
2842 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2843
2844         PR gdb/24351
2845         * windows-nat.c (display_selector): Fix format specifiers.
2846
2847 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2848
2849         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2850         tui_refill_source_window instead of tui_refresh_win, to update the
2851         current execution line.  This fixes redisplay of the current line
2852         when stepping through the code with "next" or "step".
2853
2854 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2855
2856         * source-cache.c (source_cache::get_source_lines): Call
2857         find_source_lines to initialize s->nlines.  This fixes vertical
2858         scrolling of TUI source window when the DOWN arrow is pressed.
2859
2860 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2861
2862         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2863         linux-thread-db.c (_initialize_thread_db): Likewise.
2864
2865 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2866
2867         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2868         wclrtoeol in tui_show_source_line".  This reverts changes made in
2869         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2870
2871 2019-03-15  Tom Tromey  <tom@tromey.com>
2872
2873         * symtab.h (struct minimal_symbol): Derive from
2874         general_symbol_info.
2875         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2876         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2877         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2878         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2879         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2880         (MSYMBOL_SEARCH_NAME): Update.
2881         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2882         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2883         * minsyms.c (minimal_symbol_reader::record_full): Update.
2884
2885 2019-03-15  Tom Tromey  <tom@tromey.com>
2886
2887         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2888
2889 2019-03-15  Tom Tromey  <tom@tromey.com>
2890
2891         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2892         unique_xmalloc_ptr.
2893         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2894         Update.
2895         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2896         (build_minimal_symbol_hash_tables)
2897         (minimal_symbol_reader::install): Update.
2898
2899 2019-03-15  Tom Tromey  <tom@tromey.com>
2900
2901         * symtab.c (create_demangled_names_hash): Update.
2902         (symbol_set_names): Update.
2903         * objfiles.h (struct objfile_per_bfd_storage)
2904         <demangled_names_hash>: Now an htab_up.
2905         * objfiles.c (objfile_per_bfd_storage): Simplify.
2906
2907 2019-03-15  Tom Tromey  <tom@tromey.com>
2908
2909         * objfiles.h (struct objfile_per_bfd_storage): Declare
2910         destructor.
2911         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2912         New.
2913         (get_objfile_bfd_data): Use new.  Don't initialize
2914         language_of_main.
2915         (free_objfile_per_bfd_storage): Remove.
2916         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2917
2918 2019-03-15  Tom Tromey  <tom@tromey.com>
2919
2920         * symfile.c (reread_symbols): Update.
2921         * objfiles.c (objfile::objfile): Update.
2922         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2923         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2924         comment.
2925         (minimal_symbol_reader::install): Update.
2926         (terminate_minimal_symbol_table): Remove.
2927         * jit.c (jit_object_close_impl): Update.
2928
2929 2019-03-15  Tom Tromey  <tom@tromey.com>
2930
2931         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2932         initializations.
2933
2934 2019-03-15  Tom Tromey  <tom@tromey.com>
2935
2936         * objfiles.h (struct objfile_per_bfd_storage)
2937         <demangled_hash_languages>: Now a bitset.
2938         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2939         (lookup_minimal_symbol): Update.
2940
2941 2019-03-15  Tom Tromey  <tom@tromey.com>
2942
2943         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2944         Don't return the symbol.
2945         * coffread.c (record_minimal_symbol): Use record_full.
2946
2947 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2948
2949         The MS-Windows port of ncurses fails to switch to a color pair if
2950         one or both of the colors are the implicit default colors.  This
2951         change records the default colors when TUI is initialized, and
2952         then specifies them explicitly when a color pair uses the default
2953         colors.  This allows color styling in TUI mode on MS-Windows.
2954
2955         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2956         ncurses_norm_attr.
2957         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2958         colors in ncurses_norm_attr.
2959         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2960         "none", replace it with the default color recorded in
2961         ncurses_norm_attr.
2962
2963 2019-03-14  Tom Tromey  <tromey@adacore.com>
2964
2965         * source-cache.h (class source_cache) <get_source_lines>: Return
2966         std::string.
2967         * source-cache.c (source_cache::extract_lines): Handle case where
2968         first_pos==npos.  Return std::string.
2969         (source_cache::get_source_lines): Update.
2970
2971 2019-03-14  Tom Tromey  <tromey@adacore.com>
2972
2973         * NEWS: Add item for "style sources" commands.
2974         * source-cache.c (source_cache::get_source_lines): Check
2975         source_styling.
2976         * cli/cli-style.c (source_styling): New global.
2977         (_initialize_cli_style): Add "style sources" commands.
2978         (show_style_sources): New function.
2979         * cli/cli-style.h (source_styling): Declare.
2980
2981 2019-03-14  Pedro Alves  <palves@redhat.com>
2982             Tom Tromey  <tromey@adacore.com>
2983
2984         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2985         * tui/tui-winsource.c (tui_refill_source_window): New function,
2986         from...
2987         (tui_horizontal_source_scroll): ... here.  Move some logic.
2988         * cli/cli-style.c (set_style_enabled): Notify new observable.
2989         * tui/tui-hooks.c (tui_redisplay_source): New function.
2990         (tui_attach_detach_observers): Attach or detach
2991         tui_redisplay_source.
2992         * observable.h (source_styling_changed): New observable.
2993         * observable.c: Define source_styling_changed observable.
2994
2995 2019-03-13  Tom Tromey  <tromey@adacore.com>
2996
2997         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2998         (i386_gnu_nat_target::store_registers): Update.
2999         * target-debug.h (target_debug_print_std_string): New macro.
3000         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3001         * windows-tdep.c (display_one_tib): Update.
3002         * tui/tui-stack.c (tui_make_status_line): Update.
3003         * top.c (print_inferior_quit_action): Update.
3004         * thread.c (thr_try_catch_cmd): Update.
3005         (add_thread_with_info): Update.
3006         (thread_target_id_str): Update.
3007         (thr_try_catch_cmd): Update.
3008         (thread_command): Update.
3009         (thread_find_command): Update.
3010         * record-btrace.c (record_btrace_target::info_record)
3011         (record_btrace_resume_thread, record_btrace_target::resume)
3012         (record_btrace_cancel_resume, record_btrace_step_thread)
3013         (record_btrace_target::wait, record_btrace_target::wait)
3014         (record_btrace_target::wait, record_btrace_target::stop): Update.
3015         * progspace.c (print_program_space): Update.
3016         * process-stratum-target.c
3017         (process_stratum_target::thread_address_space): Update.
3018         * linux-fork.c (linux_fork_mourn_inferior)
3019         (detach_checkpoint_command, info_checkpoints_command)
3020         (linux_fork_context): Update.
3021         (linux_fork_detach): Update.
3022         (class scoped_switch_fork_info): Update.
3023         (delete_checkpoint_command): Update.
3024         * infrun.c (follow_fork_inferior): Update.
3025         (follow_fork_inferior): Update.
3026         (proceed_after_vfork_done): Update.
3027         (handle_vfork_child_exec_or_exit): Update.
3028         (follow_exec): Update.
3029         (displaced_step_prepare_throw): Update.
3030         (displaced_step_restore): Update.
3031         (start_step_over): Update.
3032         (resume_1): Update.
3033         (clear_proceed_status_thread): Update.
3034         (proceed): Update.
3035         (print_target_wait_results): Update.
3036         (do_target_wait): Update.
3037         (context_switch): Update.
3038         (stop_all_threads): Update.
3039         (restart_threads): Update.
3040         (finish_step_over): Update.
3041         (handle_signal_stop): Update.
3042         (switch_back_to_stepped_thread): Update.
3043         (keep_going_pass_signal): Update.
3044         (print_exited_reason): Update.
3045         (normal_stop): Update.
3046         * inferior.c (inferior_pid_to_str): Change return type.
3047         (print_selected_inferior): Update.
3048         (add_inferior): Update.
3049         (detach_inferior): Update.
3050         * dummy-frame.c (fprint_dummy_frames): Update.
3051         * dcache.c (dcache_info_1): Update.
3052         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3053         (btrace_fetch, btrace_clear): Update.
3054         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3055         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3056         type.
3057         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3058         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3059         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3060         * gdbarch.c, gdbarch.h: Rebuild.
3061         * gdbarch.sh (core_pid_to_str): Change return type.
3062         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3063         return type.
3064         (windows_nat_target::pid_to_str): Change return type.
3065         (windows_delete_thread): Update.
3066         (windows_nat_target::attach): Update.
3067         (windows_nat_target::files_info): Update.
3068         * target-delegates.c: Rebuild.
3069         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3070         return type.
3071         (sol_thread_target::pid_to_str): Change return type.
3072         * remote.c (class remote_target) <pid_to_str>: Change return
3073         type.
3074         (remote_target::pid_to_str): Change return type.
3075         (extended_remote_target::attach, remote_target::remote_stop_ns)
3076         (remote_target::remote_notif_remove_queued_reply)
3077         (remote_target::push_stop_reply, remote_target::disable_btrace):
3078         Update.
3079         (extended_remote_target::attach): Update.
3080         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3081         type.
3082         (gdbsim_target::pid_to_str): Change return type.
3083         * ravenscar-thread.c (struct ravenscar_thread_target)
3084         <pid_to_str>: Change return type.
3085         (ravenscar_thread_target::pid_to_str): Change return type.
3086         * procfs.c (class procfs_target) <pid_to_str>: Change return
3087         type.
3088         (procfs_target::pid_to_str): Change return type.
3089         (procfs_target::attach): Update.
3090         (procfs_target::detach): Update.
3091         (procfs_target::fetch_registers): Update.
3092         (procfs_target::store_registers): Update.
3093         (procfs_target::wait): Update.
3094         (procfs_target::files_info): Update.
3095         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3096         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3097         return type.
3098         (nto_procfs_target::pid_to_str): Change return type.
3099         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3100         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3101         return type.
3102         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3103         (exit_lwp): Update.
3104         (attach_proc_task_lwp_callback, get_detach_signal)
3105         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3106         (linux_nat_target::resume, wait_lwp, stop_callback)
3107         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3108         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3109         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3110         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3111         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3112         type.
3113         (inf_ptrace_target::attach): Update.
3114         (inf_ptrace_target::files_info): Update.
3115         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3116         type.
3117         (go32_nat_target::pid_to_str): Change return type.
3118         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
3119         (gnu_nat_target::wait): Update.
3120         (gnu_nat_target::wait): Update.
3121         (gnu_nat_target::resume): Update.
3122         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
3123         (fbsd_nat_target::wait): Update.
3124         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
3125         type.
3126         (darwin_nat_target::attach): Update.
3127         * corelow.c (class core_target) <pid_to_str>: Change return type.
3128         (core_target::pid_to_str): Change return type.
3129         * target.c (normal_pid_to_str): Change return type.
3130         (default_pid_to_str): Likewise.
3131         (target_pid_to_str): Change return type.
3132         (target_translate_tls_address): Update.
3133         (target_announce_detach): Update.
3134         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
3135         return type.
3136         (bsd_uthread_target::pid_to_str): Change return type.
3137         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
3138         type.
3139         (bsd_kvm_target::pid_to_str): Change return type.
3140         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
3141         return type.
3142         (aix_thread_target::pid_to_str): Change return type.
3143         * target.h (struct target_ops) <pid_to_str>: Change return type.
3144         (target_pid_to_str, normal_pid_to_str): Likewise.
3145         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
3146         type.
3147         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
3148         type.
3149         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
3150         return type.
3151         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
3152         type.
3153         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
3154         type.
3155         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
3156         return type.
3157
3158 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
3159
3160         * NEWS: Mention that the new default MI version is 3.  Mention
3161         changes to the output of commands and events that deal with
3162         multi-location breakpoints.
3163         * breakpoint.c: Include "mi/mi-out.h".
3164         (print_one_breakpoint): Change output syntax if using MI version
3165         >= 3.
3166         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
3167         New.
3168         (mi_multi_location_breakpoint_output_fixed): New.
3169         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
3170         (mi_cmd_fix_multi_location_breakpoint_output): New.
3171         (mi_multi_location_breakpoint_output_fixed): New.
3172         * mi/mi-cmds.c (mi_cmds): Register command
3173         -fix-multi-location-breakpoint-output.
3174         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
3175         interpreter "mi".
3176
3177 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
3178
3179         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
3180         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
3181         instantiate mi_ui_out based on interpreter name.
3182         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
3183         * mi/mi-main.c (mi_load_progress): Likewise.
3184
3185 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3186
3187         * NEWS: Combine separate "New targets" sections for 8.3.
3188
3189 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3190
3191         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
3192         (ppcfbsd_init_abi): Install gdbarch
3193         "fetch_tls_load_module_address" and "get_thread_local_address"
3194         methods.
3195
3196 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3197
3198         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
3199         (riscv_fbsd_init_abi): Install gdbarch
3200         "fetch_tls_load_module_address" and "get_thread_local_address"
3201         methods.
3202
3203 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3204
3205         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
3206         (i386fbsd_init_abi): Install gdbarch
3207         "fetch_tls_load_module_address" and "get_thread_local_address"
3208         methods.
3209
3210 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3211
3212         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
3213         (amd64fbsd_init_abi): Install gdbarch
3214         "fetch_tls_load_module_address" and "get_thread_local_address"
3215         methods.
3216
3217 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3218
3219         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
3220         (struct fbsd_pspace_data): New type.
3221         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
3222         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
3223         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
3224         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
3225         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
3226
3227 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3228
3229         * gdbtypes.c (lookup_struct_elt): New function.
3230         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
3231         * gdbtypes.h (struct struct_elt): New type.
3232         (lookup_struct_elt): New prototype.
3233
3234 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3235
3236         * gdbtypes.c (lookup_struct_elt_type): Update comment and
3237         remove disabled code block.
3238
3239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3240
3241         * gdbarch.sh (get_thread_local_address): New method.
3242         * gdbarch.h, gdbarch.c: Regenerate.
3243         * target.c (target_translate_tls_address): Use
3244         gdbarch_get_thread_local_address if present instead of
3245         target::get_thread_local_address.
3246
3247 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3248
3249         * target.h (target::get_thread_local_address): Update comment.
3250
3251 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3252
3253         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
3254         objfile->separate_debug_objfile_backlink if not NULL.
3255
3256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3257
3258         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
3259         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
3260         (amd64bsd_store_inferior_registers): Likewise.
3261         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3262         Enable segment base registers.
3263         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
3264         PT_GETFSBASE and PT_GETGSBASE.
3265         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
3266         PT_SETGSBASE.
3267         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
3268         segment base registers.
3269         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3270
3271 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3272
3273         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3274         Update calls to i386_target_description to add 'segments'
3275         parameter.
3276         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3277         add segment base registers.
3278         * arch/i386.c (i386_create_target_description): Add 'segments'
3279         parameter to enable segment base registers.
3280         * arch/i386.h (i386_create_target_description): Likewise.
3281         * features/i386/32bit-segments.xml: New file.
3282         * features/i386/32bit-segments.c: Generate.
3283         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3284         call to i386_target_description to add 'segments' parameter.
3285         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3286         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3287         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3288         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3289         if feature is present.
3290         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3291         Add 'segments' parameter to call to i386_target_description.
3292         (i386_target_description): Add 'segments' parameter to enable
3293         segment base registers.
3294         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3295         to call to i386_target_description.
3296         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3297         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3298         Define I386_NUM_REGS.
3299         (i386_target_description): Add 'segments' parameter to enable
3300         segment base registers.
3301
3302 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3303
3304         PR/24325
3305         * source-cache.c: #undef open and close, to avoid unresolved
3306         externals during linking.
3307
3308 2019-03-12  Tom Tromey  <tromey@adacore.com>
3309
3310         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3311         const.  Add initializers.
3312         (_initialize_remote): Don't initialize ptid globals.
3313
3314 2019-03-12  Pedro Alves  <palves@redhat.com>
3315
3316         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3317
3318 2019-03-12  Pedro Alves  <palves@redhat.com>
3319
3320         * cp-name-parser.y (main): Remove unused 'len' variable.
3321
3322 2019-03-12  Tom Tromey  <tromey@adacore.com>
3323
3324         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3325         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3326
3327 2019-03-12  Tom Tromey  <tromey@adacore.com>
3328
3329         * linux-nat.c (iterate_over_lwps): Update.
3330         (stop_callback): Remove parameter.
3331         (stop_wait_callback, detach_callback, resume_set_callback)
3332         (select_singlestep_lwp_callback, set_ignore_sigint)
3333         (status_callback, resumed_callback, resume_clear_callback)
3334         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3335         data parameter.
3336         (linux_nat_target::detach, linux_nat_target::resume)
3337         (linux_stop_and_wait_all_lwps, select_event_lwp)
3338         (linux_nat_filter_event, linux_nat_wait_1)
3339         (linux_nat_target::kill, linux_nat_target::stop)
3340         (linux_nat_target::stop): Update.
3341         (linux_nat_resume_callback): Change type.
3342         (resume_stopped_resumed_lwps, count_events_callback)
3343         (select_event_lwp_callback): Likewise.
3344         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3345         * arm-linux-nat.c (struct update_registers_data): Remove.
3346         (update_registers_callback): Change type.
3347         (arm_linux_insert_hw_breakpoint1): Update.
3348         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3349         parameter.
3350         (x86_linux_dr_set_addr): Update.
3351         (x86_linux_dr_set_control): Update.
3352         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3353         (iterate_over_lwps): Use gdb::function_view.
3354         * nat/aarch64-linux-hw-point.c (struct
3355         aarch64_dr_update_callback_param): Remove.
3356         (debug_reg_change_callback): Change type.
3357         (aarch64_notify_debug_reg_change): Update.
3358         * s390-linux-nat.c (s390_refresh_per_info): Update.
3359
3360 2019-03-11  Tom Tromey  <tromey@adacore.com>
3361
3362         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3363         redundant assignment to "this_cu".
3364
3365 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3366
3367         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3368
3369 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3370
3371         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3372         from...
3373         (rank_one_type): ... this.
3374
3375 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3376
3377         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3378         from...
3379         (rank_one_type): ... this.
3380
3381 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3382
3383         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3384         from...
3385         (rank_one_type): ... this.
3386
3387 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3388
3389         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3390         from...
3391         (rank_one_type): ... this.
3392
3393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3394
3395         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3396         from...
3397         (rank_one_type): ... this.
3398
3399 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3400
3401         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3402         from...
3403         (rank_one_type): ... this.
3404
3405 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3406
3407         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3408         from...
3409         (rank_one_type): ... this.
3410
3411 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3412
3413         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3414         from...
3415         (rank_one_type): ... this.
3416
3417 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3418
3419         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3420         from...
3421         (rank_one_type): ... this.
3422
3423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3424
3425         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3426         from...
3427         (rank_one_type): ... this.
3428
3429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3430
3431         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3432         from...
3433         (rank_one_type): ... this.
3434
3435 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3436
3437         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3438         from...
3439         (rank_one_type): ... this.
3440
3441 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3442
3443         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3444         inferior-events' shows the example events.
3445
3446 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3447
3448         Support styling on native MS-Windows console
3449
3450         PR/24315
3451         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3452         on MS-Windows if $TERM is not defined.
3453
3454         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3455
3456         * posix-hdep.c (gdb_console_fputs):
3457         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3458         functions.
3459         * ui-file.h (gdb_console_fputs): Add prototype.
3460
3461         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3462         back to fputs only if the former returns zero.
3463
3464 2019-03-07  Tom Tromey  <tom@tromey.com>
3465
3466         * symmisc.c (print_symbol_bcache_statistics): Update.
3467         (print_objfile_statistics): Update.
3468         * symfile.c (allocate_symtab): Update.
3469         * stabsread.c: Don't include bcache.h.
3470         * psymtab.h (struct psymbol_bcache): Don't declare.
3471         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3472         (psymbol_bcache_init, psymbol_bcache_free)
3473         (psymbol_bcache_get_bcache): Don't declare.
3474         * psymtab.c (struct psymbol_bcache): Remove.
3475         (psymtab_storage::psymtab_storage): Update.
3476         (psymtab_storage::~psymtab_storage): Update.
3477         (psymbol_bcache_init, psymbol_bcache_free)
3478         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3479         (add_psymbol_to_bcache): Update.
3480         (allocate_psymtab): Update.
3481         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3482         macro_cache>: No longer pointers.
3483         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3484         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3485         * macrotab.c (macro_bcache): Update.
3486         * macroexp.c: Don't include bcache.h.
3487         * gdbtypes.c (check_types_worklist): Update.
3488         (types_deeply_equal): Remove TRY/CATCH.  Update.
3489         * elfread.c (elf_symtab_read): Update.
3490         * dwarf2read.c: Don't include bcache.h.
3491         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3492         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3493         (print_bcache_statistics, bcache_memory_used): Don't declare.
3494         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3495         methods.  Rename all data members.
3496         * bcache.c (struct bcache): Move to bcache.h.
3497         (bcache::expand_hash_table): Rename from expand_hash_table.
3498         (bcache): Remove.
3499         (bcache::insert): Rename from bcache_full.
3500         (bcache::compare): Rename from bcache_compare.
3501         (bcache_xmalloc): Remove.
3502         (bcache::~bcache): Rename from bcache_xfree.
3503         (bcache::print_statistics): Rename from print_bcache_statistics.
3504         (bcache::memory_used): Rename from bcache_memory_used.
3505
3506 2019-03-07  Pedro Alves  <palves@redhat.com>
3507
3508         * infrun.c (normal_stop): Also check for
3509         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3510
3511 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3512
3513         * f-lang.c (value_from_host_double): Moved to...
3514         * value.c (value_from_host_double): ...here.
3515         * value.h (value_from_host_double): Declare.
3516         * guile/scm-math.c (vlscm_convert_typed_number): Use
3517         value_from_host_double.
3518         (vlscm_convert_number): Likewise.
3519         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3520         * python/py-value.c (convert_value_from_python): Likewise.
3521
3522 2019-03-06  Tom Tromey  <tom@tromey.com>
3523
3524         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3525
3526 2019-03-06  Tom Tromey  <tom@tromey.com>
3527
3528         * utils.h (free_current_contents): Don't declare.
3529         * utils.c (free_current_contents): Remove.
3530
3531 2019-03-06  Tom Tromey  <tom@tromey.com>
3532
3533         * top.c (quit_force): Update.
3534         * main.c (captured_command_loop): Update.
3535         * common/new-op.c (operator new): Update.
3536         * common/common-exceptions.c (struct catcher)
3537         <save_cleanup_chain>: Remove member.
3538         (exceptions_state_mc_init): Update.
3539         (exception_try_scope_entry): Return nullptr.
3540         (exception_try_scope_exit, exception_rethrow)
3541         (throw_exception_sjlj, throw_exception_cxx): Update.
3542         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3543         (all_cleanups, do_cleanups, discard_cleanups)
3544         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3545         (restore_cleanups, restore_final_cleanups): Don't declare.
3546         (do_final_cleanups): Remove parameter.
3547         * common/cleanups.c (cleanup_chain, make_cleanup)
3548         (make_cleanup_dtor, all_cleanups, do_cleanups)
3549         (discard_my_cleanups, discard_cleanups)
3550         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3551         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3552         (null_cleanup): Remove.
3553         (do_final_cleanups): Remove parameter.
3554
3555 2019-03-06  Tom Tromey  <tom@tromey.com>
3556
3557         * remote.c (remote_target::remote_parse_stop_reply): Use
3558         unique_xmalloc_ptr.
3559
3560 2019-03-06  Tom Tromey  <tom@tromey.com>
3561
3562         * stabsread.c (struct stabs_field_info): Rename from field_info.
3563         <list, fnlist>: Add initializers.
3564         <obstack>: New member.
3565         (read_member_functions, read_struct_fields, read_baseclasses):
3566         Allocate on obstack.  Don't use cleanups.
3567         (read_one_struct_field, read_member_functions, read_struct_fields)
3568         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3569         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3570         (read_struct_type): Update.
3571
3572 2019-03-06  Tom Tromey  <tom@tromey.com>
3573
3574         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3575         * common/filestuff.h (make_cleanup_close): Don't declare.
3576         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3577         Remove.
3578
3579 2019-03-06  Tom Tromey  <tom@tromey.com>
3580
3581         * solib-aix.c: Use make_scope_exit.
3582
3583 2019-03-06  Tom Tromey  <tom@tromey.com>
3584
3585         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3586         Use make_scope_exit.
3587
3588 2019-03-06  Tom Tromey  <tom@tromey.com>
3589
3590         * solib-svr4.c (disable_probes_interface): Remove parameter.
3591         (svr4_handle_solib_event): Use make_scope_exit.
3592
3593 2019-03-06  Tom Tromey  <tom@tromey.com>
3594
3595         * remote.c (struct stop_reply_deleter): Remove.
3596         (stop_reply_up): Update.
3597         (struct stop_reply): Derive from notif_event.  Don't typedef.
3598         <regcache>: Now a std::vector.
3599         (stop_reply_xfree): Remove.
3600         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3601         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3602         (remote_target::discard_pending_stop_replies): Use delete.
3603         (remote_target::remote_parse_stop_reply): Update.
3604         (remote_target::process_stop_reply): Update.
3605         * remote-notif.h (struct notif_event): Add virtual destructor.
3606         Remove "dtr" member.
3607         (struct notif_client) <alloc_event>: Return a unique_ptr.
3608         (notif_event_xfree): Don't declare.
3609         (notif_event_up): New typedef.
3610         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3611         (notif_event_xfree, do_notif_event_xfree): Remove.
3612         (remote_notif_state_xfree): Update.
3613
3614 2019-03-06  Tom Tromey  <tom@tromey.com>
3615
3616         * infrun.c (displaced_step_clear_cleanup): Now a
3617         forward_scope_exit type.
3618         (displaced_step_prepare_throw): Update.
3619         (displaced_step_fixup): Update.
3620
3621 2019-03-06  Tom Tromey  <tom@tromey.com>
3622
3623         * inferior.h (class inferior): Update comment.
3624         * gdbthread.h (class thread_info): Update comment.
3625
3626 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3627             Tom Tromey  <tom@tromey.com>
3628
3629         * stabsread.h (struct stab_section_list): Remove.
3630         (coffstab_build_psymtabs): Update.
3631         * dbxread.c (symbuf_sections): Now a std::vector.
3632         (sect_idx): New global.
3633         (fill_symbuf): Update.
3634         (coffstab_build_psymtabs): Change type of stabsects parameter.
3635         Update.
3636         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3637         std::vector.
3638         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3639         (coff_locate_sections): Update.
3640         (coff_symfile_read): Remove cleanups.  Update.
3641         (init_stringtab): Add storage parameter.
3642         (free_stringtab, free_stringtab_cleanup): Remove.
3643         (init_lineno): Add storage parameter.
3644         (free_linetab, free_linetab_cleanup): Remove.
3645
3646 2019-03-06  Pedro Alves  <palves@redhat.com>
3647
3648         * linux-fork.c (fork_info::clobber_regs): Delete.
3649         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3650         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3651         comment.  Adjust.
3652         (scoped_switch_fork_info::scoped_switch_fork_info)
3653         (checkpoint_command, linux_fork_context): Adjust
3654         fork_save_infrun_state calls.
3655
3656 2019-03-06  Pedro Alves  <palves@redhat.com>
3657
3658         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3659         (inf_has_multiple_threads): Return 'bool' and rewrite using
3660         inferior_info::threads().
3661
3662 2019-03-06  Pedro Alves  <palves@redhat.com>
3663
3664         * linux-fork.c: Include <list>.
3665         (fork_list): Now a std::list instance.
3666         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3667         (forks_exist_p, find_last_fork): Adjust.
3668         (new_fork): Delete.
3669         (one_fork_p): New.
3670         (add_fork): Adjust.
3671         (free_fork): Delete, folded into fork_info::~fork_info().
3672         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3673         Adjust.
3674         (init_fork_list): Delete.
3675         (linux_fork_killall, linux_fork_mourn_inferior)
3676         (linux_fork_detach, info_checkpoints_command): Adjust.
3677         (_initialize_linux_fork): No longer call init_fork_list.
3678
3679 2019-03-06  Pedro Alves  <palves@redhat.com>
3680
3681         * linux-fork.c (new_fork): New, split out of ...
3682         (add_fork): ... this.  Return void.  Move "first fork" special
3683         case from here, to ...
3684         (checkpoint_command): ... here.
3685         * linux-linux.h (add_fork): Return void.
3686
3687 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3688
3689         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3690
3691 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3692             Chris January  <chris.january@arm.com>
3693             David Lecomber  <david.lecomber@arm.com>
3694
3695         * f-exp.y: New token, UNOP_INTRINSIC.
3696         (exp): New pattern using UNOP_INTRINSIC token.
3697         (f77_keywords): Add 'abs' keyword.
3698         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3699         (value_from_host_double): New function.
3700         (evaluate_subexp_f): Support UNOP_ABS.
3701
3702 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3703
3704         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3705         types.
3706
3707 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3708
3709         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3710         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3711         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3712
3713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3714
3715         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3716
3717 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3718             Chris January  <chris.january@arm.com>
3719
3720         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3721         * f-exp.y: Define 'KIND' token.
3722         (exp): New pattern for KIND expressions.
3723         (ptype): Handle types with a kind extension.
3724         (direct_abs_decl): Extend to spot kind extensions.
3725         (f77_keywords): Add 'kind' to the list.
3726         (push_kind_type): New function.
3727         (convert_to_kind_type): New function.
3728         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3729         * parse.c (operator_length_standard): Likewise.
3730         * parser-defs.h (enum type_pieces): Add tp_kind.
3731         * std-operator.def: Add UNOP_KIND.
3732
3733 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * f-exp.y (f_parse): Set yydebug.
3736
3737 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3738
3739         * f-lang.c (evaluate_subexp_f): New function.
3740         (exp_descriptor_f): New global.
3741         (f_language_defn): Use exp_descriptor_f instead of
3742         exp_descriptor_standard.
3743
3744 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         * f-exp.y (struct token): Add comments.
3747         (dot_ops): Remove uppercase versions and the end marker.
3748         (f77_keywords): Likewise.
3749         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3750         entries in the dot_ops array are case insensitive, and use
3751         strncasecmp to compare strings.  Also some whitespace cleanup in
3752         this area.  Similar for the f77_keywords array, except entries in
3753         this list might be case sensitive.
3754
3755 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         * f-exp.y (struct f77_boolean_val): Add comments.
3758         (boolean_values): Remove uppercase versions, and end marker.
3759         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3760         and use strncasecmp to achieve case insensitivity.  Additionally,
3761         perform whitespace cleanup around this code.
3762
3763 2019-03-06  Tom Tromey  <tromey@adacore.com>
3764
3765         * remote-sim.c (gdbsim_target_open): Use result of
3766         gdb_argv::release.
3767
3768 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3769         Dirk Schubert  <dirk.schubert@arm.com>
3770         Chris January  <chris.january@arm.com>
3771
3772         * eval.c (evaluate_subexp_standard): Call Fortran argument
3773         wrapping logic.
3774         * f-lang.c (struct value): A value which can be passed into a
3775         Fortran function call.
3776         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3777         where appropriate.
3778         (struct type): Value ready for a Fortran function call.
3779         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3780         is needed.
3781         * f-lang.h (fortran_argument_convert): Declaration.
3782         (fortran_preserve_arg_pointer): Declaration.
3783         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3784
3785 2019-03-05  Tom Tromey  <tromey@adacore.com>
3786
3787         * python/py-prettyprint.c (print_string_repr): Remove #if.
3788         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3789
3790 2019-03-05  Tom Tromey  <tromey@adacore.com>
3791
3792         * target.c (the_dummy_target): Move later.  Change type to
3793         "dummy_target".
3794         (initialize_targets): Don't initialize the_dummy_target.
3795
3796 2019-03-05  Tom Tromey  <tromey@adacore.com>
3797
3798         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3799         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3800
3801 2019-03-05  Tom Tromey  <tromey@adacore.com>
3802
3803         * windows-nat.c (windows_nat_target::attach)
3804         (windows_nat_target::detach): Don't call gdb_flush.
3805         * valprint.c (generic_val_print, val_print, val_print_string):
3806         Don't call gdb_flush.
3807         * utils.c (defaulted_query): Don't call gdb_flush.
3808         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3809         * target.c (target_announce_detach): Don't call gdb_flush.
3810         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3811         * remote.c (extended_remote_target::attach): Don't call
3812         gdb_flush.
3813         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3814         * printcmd.c (do_examine): Don't call gdb_flush.
3815         (info_display_command): Don't call gdb_flush.
3816         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3817         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3818         * memattr.c (info_mem_command): Don't call gdb_flush.
3819         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3820         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3821         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3822         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3823         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3824         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3825         (gnu_nat_target::detach): Don't call gdb_flush.
3826         * f-valprint.c (f_val_print): Don't call gdb_flush.
3827         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3828         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3829         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3830         gdb_flush.
3831         * c-valprint.c (c_val_print): Don't call gdb_flush.
3832         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3833
3834 2019-03-05  Tom Tromey  <tromey@adacore.com>
3835
3836         * varobj.c (update_dynamic_varobj_children): Update.
3837         (install_default_visualizer): Use reset, not release.
3838         * value.c (set_internalvar): Update.
3839         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3840         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3841         ATTRIBUTE_UNUSED_RESULT.
3842
3843 2019-03-05  Tom Tromey  <tromey@adacore.com>
3844
3845         * remote.c (class scoped_remote_fd) <release>: Add
3846         ATTRIBUTE_UNUSED_RESULT.
3847
3848 2019-03-05  Tom Tromey  <tromey@adacore.com>
3849
3850         * macroexp.c (struct macro_buffer) <release>: Add
3851         ATTRIBUTE_UNUSED_RESULT.
3852
3853 2019-03-05  Tom Tromey  <tromey@adacore.com>
3854
3855         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3856         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3857         ATTRIBUTE_UNUSED_RESULT.
3858
3859 2019-03-05  Tom Tromey  <tromey@adacore.com>
3860
3861         * common/scoped_fd.h (class scoped_fd) <release>: Add
3862         ATTRIBUTE_UNUSED_RESULT.
3863
3864 2019-03-05  Tom Tromey  <tromey@adacore.com>
3865
3866         * parser-defs.h (struct parser_state) <release>: Add
3867         ATTRIBUTE_UNUSED_RESULT.
3868
3869 2019-03-05  Tom Tromey  <tromey@adacore.com>
3870
3871         * utils.h (class gdb_argv) <release>: Add
3872         ATTRIBUTE_UNUSED_RESULT.
3873         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3874
3875 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3876
3877         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3878         for-loop range, to avoid compiler warnings.
3879
3880         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3881         avoid compiler warnings about unused variables.
3882
3883         * NEWS: Mention end of support for native debugging on MS-Windows
3884         before XP.
3885
3886         PR gdb/24292
3887         * common/netstuff.c:
3888         * gdbserver/gdbreplay.c
3889         * gdbserver/remote-utils.c:
3890         * ser-tcp.c:
3891         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3892         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3893         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3894         'getaddrinfo' and 'freeaddrinfo' were not available before
3895         Windows XP, and mingw.org's MinGW headers by default define
3896         _WIN32_WINNT to 0x500.
3897
3898 2019-03-01  Gary Benson <gbenson@redhat.com>
3899
3900         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3901
3902 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3903             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3904
3905         PR gdb/8527
3906         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3907         set_sigint_trap, clear_sigint_trap.
3908
3909 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3910
3911         * target.c (target_detach): Clear the regcache and the
3912         frame cache.
3913
3914 2019-02-27  Pedro Alves  <palves@redhat.com>
3915
3916         * utils.c (set_screen_size): When we cap the height/width sizes,
3917         tweak the corresponding command variable to show "unlimited":
3918
3919 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3920             Pedro Alves  <palves@redhat.com>
3921
3922         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3923         before calling rl_set_screen_size.
3924
3925 2019-02-27  Tom Tromey  <tromey@adacore.com>
3926
3927         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3928         define.
3929         * python/py-value.c: Remove Python 2.4 workaround.
3930         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3931         workaround.
3932         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3933         Python 2.4 workaround.
3934         * python/python-internal.h: Remove Python 2.4 comment.
3935         (Py_ssize_t): Don't define.
3936         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3937         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3938         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3939         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3940         * python/python.c (do_start_initialization): Remove Python 2.4
3941         workaround.
3942         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3943         (print_children): Remove Python 2.4 workaround.
3944         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3945         workaround.
3946         (CHARBUFFERPROC_NAME): Remove.
3947         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3948         Python 2.4 workaround.
3949
3950 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3951
3952         * NEWS: Note minimum Python version.
3953
3954 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3955
3956         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3957         code from these functions.  Remove corresponding ifdefs.  Use
3958         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3959         Remove gotos and target of gotos.
3960         (infpy_search_memory): Likewise.
3961
3962 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3963
3964         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3965         (hppa_gdbarch_init): Don't register deleted functions with
3966         gdbarch.
3967
3968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3969
3970         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3971         (h8300_unwind_sp): Delete.
3972         (h8300_dummy_id): Delete.
3973         (h8300_gdbarch_init): Don't register deleted functions with
3974         gdbarch.
3975
3976 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3977
3978         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3979         (ft32_unwind_pc): Delete.
3980         (ft32_unwind_sp): Delete.
3981         (ft32_gdbarch_init): Don't register deleted functions with
3982         gdbarch.
3983
3984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3985
3986         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3987         (frv_unwind_pc): Delete.
3988         (frv_unwind_sp): Delete.
3989         (frv_gdbarch_init): Don't register deleted functions with
3990         gdbarch.
3991
3992 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3993
3994         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3995         (riscv_unwind_pc): Delete.
3996         (riscv_unwind_sp): Delete.
3997         (riscv_gdbarch_init): Don't register deleted functions with
3998         gdbarch.
3999
4000 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4001
4002         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4003         (csky_unwind_pc): Delete.
4004         (csky_unwind_sp): Delete.
4005         (csky_gdbarch_init): Don't register deleted functions with
4006         gdbarch.
4007
4008 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4009
4010         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4011         (cris_unwind_pc): Delete.
4012         (cris_unwind_sp): Delete.
4013         (cris_gdbarch_init): Don't register deleted functions with
4014         gdbarch.
4015
4016 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4017
4018         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4019         (bfin_unwind_pc): Delete.
4020         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4021
4022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4023
4024         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4025         (arm_unwind_pc): Delete.
4026         (arm_unwind_sp): Delete.
4027         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4028
4029 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4030
4031         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4032         (arc_unwind_pc): Delete.
4033         (arc_unwind_sp): Delete.
4034         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4035
4036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4037
4038         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4039         (alpha_unwind_pc): Delete.
4040         (alpha_gdbarch_init): Don't register deleted functions with
4041         gdbarch.
4042
4043 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4044
4045         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4046         (aarch64_unwind_pc): Delete.
4047         (aarch64_unwind_sp): Delete.
4048         (aarch64_gdbarch_init): Don't register deleted functions with
4049         gdbarch.
4050
4051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4052
4053         * gdbtypes.c (type_align): Don't consider static members when
4054         computing structure alignment.
4055
4056 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4057
4058         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4059         return 0 for other types.
4060         * arch-utils.c (default_type_align): Always return 0.
4061         * gdbarch.h: Regenerate.
4062         * gdbarch.sh (type_align): Extend comment.
4063         * gdbtypes.c (type_align): Add additional comments, always call
4064         gdbarch_type_align before applying the default rules.
4065         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4066         generic code will then apply a suitable default.
4067         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4068         types, return 0 for other types.
4069
4070 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4071
4072         * NEWS: Create a new section for the next release branch.
4073         Rename the section of the current branch, now that it has
4074         been cut.
4075
4076 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4077
4078         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4079         * version.in: Bump version to 8.3.50.DATE-git.
4080
4081 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4082
4083         * aix-thread.c (ptid_cmp): Remove unused variable.
4084         (get_signaled_thread): Likewise.
4085         (store_regs_user_thread): Likewise.
4086         (store_regs_kernel_thread): Likewise.
4087         (fetch_regs_kernel_thread): Remove shadowed variable.
4088
4089 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4090
4091         * features/riscv/32bit-cpu.xml: Add register numbers.
4092         * features/riscv/32bit-fpu.c: Regenerate.
4093         * features/riscv/32bit-fpu.xml: Add register numbers.
4094         * features/riscv/64bit-cpu.xml: Add register numbers.
4095         * features/riscv/64bit-fpu.c: Regenerate.
4096         * features/riscv/64bit-fpu.xml: Add register numbers.
4097
4098 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4099
4100         * NEWS: Mention two argument form of gdb.Value constructor.
4101         * python/py-value.c (convert_buffer_and_type_to_value): New
4102         function.
4103         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4104         Add support for handling an optional second argument.  Call
4105         convert_buffer_and_type_to_value as appropriate.
4106         * python/python-internal.h (Py_buffer_deleter): New struct.
4107         (Py_buffer_up): New typedef.
4108
4109 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4110
4111         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4112         instead of releasing ownership.
4113
4114 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4115
4116         * dwarf2read.c (open_and_init_dwp_file): Call
4117         elf_numsections instead of bfd_count_sections to initialize
4118         dwp_file->num_sections.
4119
4120 2019-02-25  Tom Tromey  <tromey@adacore.com>
4121
4122         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
4123
4124 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4125
4126         * gcore.in: Add '--readnever' option when invoking GDB.
4127
4128 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4129
4130         * MAINTAINERS: Update my email address.
4131
4132 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
4133
4134         * build-id.c (build_id_to_debug_bfd_1): New function.
4135         (build_id_to_debug_bfd): Look for separate debug file in
4136         sysroot.
4137
4138 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4139
4140         * gdbarch.sh: Update the copyright year range that is placed into
4141         generated files.
4142
4143 2019-02-22  Keith Seitz  <keiths@redhat.com>
4144
4145         PR symtab/23853
4146         * linespec.c (create_sals_line_offset): Search for the default
4147         symtab's filename instead of its fullname.
4148
4149 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4150
4151         * NEWS: Update style defaults.
4152
4153 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
4154
4155         * main.c (captured_main_1): Disable styling in batch mode.
4156
4157 2019-02-20  Tom Tromey  <tom@tromey.com>
4158
4159         * symtab.c (symtab_symbol_info): Fix typos.
4160
4161 2019-02-20  Tom Tromey  <tromey@adacore.com>
4162
4163         * findcmd.c (_initialize_mem_search): Use upper case for
4164         metasyntactic variables.
4165
4166 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
4167
4168         * aarch64-tdep.c (aarch64_add_reggroups): New function.
4169         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
4170
4171 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
4172
4173         * top.h (source_file_name): Change to std::string.
4174         * top.c (source_file_name): Likewise.
4175         (command_line_input): Adjust.
4176         * cli/cli-script.c (script_from_file): Adjust.
4177
4178 2019-02-19  Tom Tromey  <tromey@adacore.com>
4179
4180         * ravenscar-thread.c
4181         (ravenscar_thread_target::update_thread_list): Don't call
4182         ada_build_task_list.
4183         * ada-lang.h (ada_build_task_list): Don't declare.
4184         * ada-tasks.c (struct ada_tasks_inferior_data)
4185         <task_list_valid_p>: Now bool.
4186         (read_known_tasks, ada_task_list_changed)
4187         (ada_tasks_invalidate_inferior_data): Update.
4188         (read_known_tasks_array): Return bool.
4189         (read_known_tasks_list): Likewise.
4190         (read_known_tasks): Return void.
4191         (ada_build_task_list): Now static.
4192
4193 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4194
4195         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
4196         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
4197
4198 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4199
4200         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
4201         variant for ada_tasks_pspace_data_handle and
4202         ada_tasks_inferior_data_handle.
4203         (ada_tasks_pspace_data_cleanup): New function.
4204         (ada_tasks_inferior_data_cleanup): New function.
4205
4206 2019-02-17  Tom Tromey  <tom@tromey.com>
4207
4208         * macrotab.h (macro_source_fullname): Return a std::string.
4209         * macrotab.c (macro_include, check_for_redefinition)
4210         (macro_undef, macro_lookup_definition, foreach_macro)
4211         (foreach_macro_in_scope): Update.
4212         (macro_source_fullname): Return a std::string.
4213         * macrocmd.c (show_pp_source_pos): Update.
4214
4215 2019-02-17  Tom Tromey  <tom@tromey.com>
4216
4217         * macrocmd.c (show_pp_source_pos): Style the file names.
4218
4219 2019-02-17  Tom Tromey  <tom@tromey.com>
4220
4221         PR tui/24197:
4222         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
4223
4224 2019-02-17  Tom Tromey  <tom@tromey.com>
4225
4226         * ada-lang.c (user_select_syms): Use filtered printing.
4227         * utils.c (wrap_style): New global.
4228         (desired_style): Remove.
4229         (emit_style_escape): Add stream parameter.
4230         (set_output_style, reset_terminal_style, prompt_for_continue):
4231         Update.
4232         (flush_wrap_buffer): Only flush gdb_stdout.
4233         (wrap_here): Set wrap_style.
4234         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
4235         treat escape sequences as a character.  Change when wrap buffer is
4236         flushed.
4237         (fputs_styled): Do not set the output style when the default is
4238         requested.
4239         * ui-style.h (struct ui_file_style) <is_default>: New method.
4240         * source.c (print_source_lines_base): Emit escape sequences in one
4241         piece.
4242
4243 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4244
4245         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
4246         integers and enumeration types.
4247
4248 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
4249
4250         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
4251         instead of lookup_symbol_in_language
4252         (do_exact_match): New function.
4253         (ada_get_symbol_name_matcher): Return do_exact_match when
4254         doing a verbatim match.
4255
4256 2019-02-15  Tom Tromey  <tromey@adacore.com>
4257
4258         * ravenscar-thread.c (ravenscar_thread_target::resume)
4259         (ravenscar_thread_target::wait): Special case wildcard requests.
4260
4261 2019-02-15  Tom Tromey  <tromey@adacore.com>
4262
4263         * ravenscar-thread.c (base_ptid): Remove.
4264         (struct ravenscar_thread_target) <close>: New method.
4265         <m_base_ptid>: New member.
4266         <update_inferior_ptid, active_task, task_is_currently_active,
4267         runtime_initialized>: Declare methods.
4268         <ravenscar_thread_target>: Add constructor.
4269         (ravenscar_thread_target::task_is_currently_active)
4270         (ravenscar_thread_target::update_inferior_ptid)
4271         (ravenscar_runtime_initialized): Rename.  Now methods.
4272         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4273         (ravenscar_thread_target::update_thread_list): Update.
4274         (ravenscar_thread_target::active_task): Now method.
4275         (ravenscar_thread_target::store_registers)
4276         (ravenscar_thread_target::prepare_to_store)
4277         (ravenscar_thread_target::prepare_to_store)
4278         (ravenscar_thread_target::mourn_inferior): Update.
4279         (ravenscar_inferior_created): Use "new" to create target.
4280         (ravenscar_thread_target::get_ada_task_ptid): Update.
4281         (_initialize_ravenscar): Don't initialize base_ptid.
4282         (ravenscar_ops): Remove global.
4283
4284 2019-02-15  Tom Tromey  <tromey@adacore.com>
4285
4286         * target.h (push_target): Declare new overload.
4287         * target.c (push_target): New overload, taking an rvalue reference.
4288         * remote.c (remote_target::open_1): Use push_target overload.
4289         * corelow.c (core_target_open): Use push_target overload.
4290
4291 2019-02-15  Tom Tromey  <tromey@adacore.com>
4292
4293         * ravenscar-thread.c (is_ravenscar_task)
4294         (ravenscar_task_is_currently_active): Return bool.
4295         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4296         (_initialize_ravenscar): Remove "(void)".
4297         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4298         Return bool.
4299
4300 2019-02-15  Tom Tromey  <tromey@adacore.com>
4301
4302         * ravenscar-thread.c (ravenscar_runtime_initializer)
4303         (has_ravenscar_runtime, get_running_thread_id)
4304         (ravenscar_thread_target::resume): Fix indentation.
4305
4306 2019-02-15  Tom Tromey  <tromey@adacore.com>
4307
4308         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4309         from ravenscar_arch_ops.
4310         (sparc_ravenscar_ops::fetch_registers)
4311         (sparc_ravenscar_ops::store_registers): Now methods.
4312         (sparc_ravenscar_prepare_to_store): Remove.
4313         (sparc_ravenscar_ops): Redefine.
4314         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4315         methods and destructor.  Remove members.
4316         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4317         (ravenscar_thread_target::store_registers)
4318         (ravenscar_thread_target::prepare_to_store): Update.
4319         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4320         Remove.
4321         (struct ppc_ravenscar_powerpc_ops): Derive from
4322         ravenscar_arch_ops.
4323         (ppc_ravenscar_powerpc_ops::fetch_registers)
4324         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4325         (ppc_ravenscar_powerpc_ops): Redefine.
4326         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4327         (ppc_ravenscar_e500_ops::fetch_registers)
4328         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4329         (ppc_ravenscar_e500_ops): Redefine.
4330         * aarch64-ravenscar-thread.c
4331         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4332         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4333         (aarch64_ravenscar_fetch_registers)
4334         (aarch64_ravenscar_store_registers): Now methods.
4335         (aarch64_ravenscar_ops): Redefine.
4336
4337 2019-02-15  Tom Tromey  <tromey@adacore.com>
4338
4339         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4340         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4341         (ravenscar_thread_target::stopped_by_watchpoint)
4342         (ravenscar_thread_target::stopped_data_address)
4343         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4344
4345 2019-02-15  Tom Tromey  <tromey@adacore.com>
4346
4347         * ravenscar-thread.c: Fix some typos.
4348
4349 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4350             Tom Tromey  <tromey@adacore.com>
4351
4352         * ada-lang.c (ada_exception_sal): Change addr_string to a
4353         std::string.
4354         (create_ada_exception_catchpoint): Update.
4355
4356 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4357             Tom Tromey  <tromey@adacore.com>
4358
4359         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4360         (bp_location_ops): Remove.
4361         (base_breakpoint_allocate_location): Update.
4362         (free_bp_location): Update.
4363         * ada-lang.c (class ada_catchpoint_location)
4364         <ada_catchpoint_location>: Remove ops parameter.
4365         (ada_catchpoint_location_dtor): Remove.
4366         (ada_catchpoint_location_ops): Remove.
4367         (allocate_location_exception): Update.
4368         * breakpoint.h (struct bp_location_ops): Remove.
4369         (class bp_location) <bp_location>: Remove bp_location_ops
4370         parameter.
4371         <~bp_location>: Add destructor.
4372         <ops>: Remove.
4373
4374 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4375             Pedro Alves  <palves@redhat.com>
4376
4377         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4378         'PATH_MAX'.
4379
4380 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4381             Samuel Thibault  <samuel.thibault@gnu.org>
4382             Thomas Schwinge  <thomas@codesourcery.com>
4383
4384         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4385         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4386
4387 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4388
4389         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4390         (check_empty): Use "const char *".
4391
4392         * gnu-nat.c (gnu_nat_target::detach): Instead of
4393         'detach_inferior (pid)' call
4394         'detach_inferior (find_inferior_pid (pid))'.
4395
4396         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4397         'nat/fork-inferior.o'.
4398         * gnu-nat.c: #include "nat/fork-inferior.h".
4399
4400         * gnu-nat.c (gnu_nat_target::detach): Instead of
4401         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4402         * gnu-nat.h: #include "inf-child.h".
4403         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4404         'i386_gnu_nat_target::fetch_registers'.
4405         (gnu_store_registers): Rename/move to
4406         'i386_gnu_nat_target::store_registers'.
4407
4408         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4409         * gnu-nat.h (mach_thread_info): New function.
4410         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4411
4412         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4413
4414 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4415
4416         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4417
4418 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4419
4420         * windows-nat.c (windows_add_thread): Add new parameter
4421         "main_thread_p" with default value set to false.  Update
4422         function documentation as well as all callers.
4423         (windows_delete_thread): Likewise.
4424         (fake_create_process): Update call to windows_add_thread.
4425         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4426         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4427         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4428         call to windows_delete_thread.
4429
4430 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4431
4432         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4433
4434 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4435
4436         * symfile.c (find_separate_debug_file): Use canonical path of
4437         sysroot with child_path instead of gdb_sysroot if it is valid.
4438
4439 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4440
4441         * symfile.c (find_separate_debug_file): Use child_path to
4442         determine if an object file is under a sysroot.
4443
4444 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4445
4446         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4447         unittests/child-path-selftests.c.
4448         * common/pathstuff.c (child_path): New function.
4449         * common/pathstuff.h (child_path): New prototype.
4450         * unittests/child-path-selftests.c: New file.
4451
4452 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4453
4454         * symfile.c (find_separate_debug_file): Look for separate debug
4455         files in debug directories under the sysroot.
4456
4457 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4458
4459         * symtab.h (struct minimal_symbol data_p): New const method.
4460         (struct minimal_symbol text_p): Likewise.
4461         * symtab.c (output_source_filename): Use file name style
4462         to print file name.
4463         (print_symbol_info): Likewise.
4464         (print_msymbol_info): Use address style to print addresses.
4465         Use function name style to print executable text symbols.
4466         (expand_symtab_containing_pc): Use data_p.
4467         (find_pc_sect_compunit_symtab): Likewise.
4468
4469 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4470
4471         * breakpoint.c (describe_other_breakpoints): Use address style
4472         to print addresses.
4473         (say_where): Likewise.
4474
4475 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4476
4477         * ada-typeprint.c (print_func_type): Print function name
4478         style to print function name.
4479         * c-typeprint.c (c_print_type_1): Likewise.
4480
4481 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4482
4483         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4484         for execve.
4485
4486 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4487
4488         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4489         type_stack.
4490
4491 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4492
4493         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4494         TYPE_CODE_REF types.
4495
4496 2019-02-08  Jim Wilson  <jimw@sifive.com>
4497
4498         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4499         (riscv_linux_fregset): New.
4500         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4501
4502 2019-02-07  Tom Tromey  <tom@tromey.com>
4503
4504         * thread.c (thread_cancel_execution_command): Update.
4505         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4506         methods.
4507         (struct thread_fsm_ops): Remove.
4508         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4509         (thread_fsm_should_stop, thread_fsm_return_value)
4510         (thread_fsm_set_finished, thread_fsm_finished_p)
4511         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4512         Don't declare.
4513         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4514         * infrun.c (clear_proceed_status_thread)
4515         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4516         (print_stop_event): Update.
4517         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4518         Add constructor.
4519         (step_command_fsm_ops): Remove.
4520         (new_step_command_fsm): Remove.
4521         (step_1): Update.
4522         (step_command_fsm::should_stop): Rename from
4523         step_command_fsm_should_stop.
4524         (step_command_fsm::clean_up): Rename from
4525         step_command_fsm_clean_up.
4526         (step_command_fsm::do_async_reply_reason): Rename from
4527         step_command_fsm_async_reply_reason.
4528         (struct until_next_fsm): Inherit from thread_fsm.  Add
4529         constructor.
4530         (until_next_fsm_ops): Remove.
4531         (new_until_next_fsm): Remove.
4532         (until_next_fsm::should_stop): Rename from
4533         until_next_fsm_should_stop.
4534         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4535         (until_next_fsm::do_async_reply_reason): Rename from
4536         until_next_fsm_async_reply_reason.
4537         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4538         constructor.  Change type of breakpoint.
4539         (finish_command_fsm_ops): Remove.
4540         (new_finish_command_fsm): Remove.
4541         (finish_command_fsm::should_stop): Rename from
4542         finish_command_fsm_should_stop.
4543         (finish_command_fsm::clean_up): Rename from
4544         finish_command_fsm_clean_up.
4545         (finish_command_fsm::return_value): Rename from
4546         finish_command_fsm_return_value.
4547         (finish_command_fsm::do_async_reply_reason): Rename from
4548         finish_command_fsm_async_reply_reason.
4549         (finish_command): Update.
4550         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4551         Add constructor.
4552         (call_thread_fsm_ops): Remove.
4553         (call_thread_fsm::call_thread_fsm): Rename from
4554         new_call_thread_fsm.
4555         (call_thread_fsm::should_stop): Rename from
4556         call_thread_fsm_should_stop.
4557         (call_thread_fsm::should_notify_stop): Rename from
4558         call_thread_fsm_should_notify_stop.
4559         (run_inferior_call, call_function_by_hand_dummy): Update.
4560         * cli/cli-interp.c (should_print_stop_to_console): Update.
4561         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4562         Add constructor.  Change type of location_breakpoint,
4563         caller_breakpoint.
4564         (until_break_fsm_ops): Remove.
4565         (new_until_break_fsm): Remove.
4566         (until_break_fsm::should_stop): Rename from
4567         until_break_fsm_should_stop.
4568         (until_break_fsm::clean_up): Rename from
4569         until_break_fsm_clean_up.
4570         (until_break_fsm::do_async_reply_reason): Rename from
4571         until_break_fsm_async_reply_reason.
4572         (until_break_command): Update.
4573         * thread-fsm.c: Remove.
4574         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4575
4576 2019-02-07  Tom Tromey  <tom@tromey.com>
4577
4578         * yy-remap.h: Add include guard.
4579         * xtensa-tdep.h: Add include guard.
4580         * xcoffread.h: Rename include guard.
4581         * varobj-iter.h: Add include guard.
4582         * tui/tui.h: Rename include guard.
4583         * tui/tui-winsource.h: Rename include guard.
4584         * tui/tui-wingeneral.h: Rename include guard.
4585         * tui/tui-windata.h: Rename include guard.
4586         * tui/tui-win.h: Rename include guard.
4587         * tui/tui-stack.h: Rename include guard.
4588         * tui/tui-source.h: Rename include guard.
4589         * tui/tui-regs.h: Rename include guard.
4590         * tui/tui-out.h: Rename include guard.
4591         * tui/tui-layout.h: Rename include guard.
4592         * tui/tui-io.h: Rename include guard.
4593         * tui/tui-hooks.h: Rename include guard.
4594         * tui/tui-file.h: Rename include guard.
4595         * tui/tui-disasm.h: Rename include guard.
4596         * tui/tui-data.h: Rename include guard.
4597         * tui/tui-command.h: Rename include guard.
4598         * tic6x-tdep.h: Add include guard.
4599         * target/waitstatus.h: Rename include guard.
4600         * target/wait.h: Rename include guard.
4601         * target/target.h: Rename include guard.
4602         * target/resume.h: Rename include guard.
4603         * target-float.h: Rename include guard.
4604         * stabsread.h: Add include guard.
4605         * rs6000-tdep.h: Add include guard.
4606         * riscv-fbsd-tdep.h: Add include guard.
4607         * regformats/regdef.h: Rename include guard.
4608         * record.h: Rename include guard.
4609         * python/python.h: Rename include guard.
4610         * python/python-internal.h: Rename include guard.
4611         * python/py-stopevent.h: Rename include guard.
4612         * python/py-ref.h: Rename include guard.
4613         * python/py-record.h: Rename include guard.
4614         * python/py-record-full.h: Rename include guard.
4615         * python/py-record-btrace.h: Rename include guard.
4616         * python/py-instruction.h: Rename include guard.
4617         * python/py-events.h: Rename include guard.
4618         * python/py-event.h: Rename include guard.
4619         * procfs.h: Add include guard.
4620         * proc-utils.h: Add include guard.
4621         * p-lang.h: Add include guard.
4622         * or1k-tdep.h: Rename include guard.
4623         * observable.h: Rename include guard.
4624         * nto-tdep.h: Rename include guard.
4625         * nat/x86-linux.h: Rename include guard.
4626         * nat/x86-linux-dregs.h: Rename include guard.
4627         * nat/x86-gcc-cpuid.h: Add include guard.
4628         * nat/x86-dregs.h: Rename include guard.
4629         * nat/x86-cpuid.h: Rename include guard.
4630         * nat/ppc-linux.h: Rename include guard.
4631         * nat/mips-linux-watch.h: Rename include guard.
4632         * nat/linux-waitpid.h: Rename include guard.
4633         * nat/linux-ptrace.h: Rename include guard.
4634         * nat/linux-procfs.h: Rename include guard.
4635         * nat/linux-osdata.h: Rename include guard.
4636         * nat/linux-nat.h: Rename include guard.
4637         * nat/linux-namespaces.h: Rename include guard.
4638         * nat/linux-btrace.h: Rename include guard.
4639         * nat/glibc_thread_db.h: Rename include guard.
4640         * nat/gdb_thread_db.h: Rename include guard.
4641         * nat/gdb_ptrace.h: Rename include guard.
4642         * nat/fork-inferior.h: Rename include guard.
4643         * nat/amd64-linux-siginfo.h: Rename include guard.
4644         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4645         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4646         * nat/aarch64-linux.h: Rename include guard.
4647         * nat/aarch64-linux-hw-point.h: Rename include guard.
4648         * mn10300-tdep.h: Add include guard.
4649         * mips-linux-tdep.h: Add include guard.
4650         * mi/mi-parse.h: Rename include guard.
4651         * mi/mi-out.h: Rename include guard.
4652         * mi/mi-main.h: Rename include guard.
4653         * mi/mi-interp.h: Rename include guard.
4654         * mi/mi-getopt.h: Rename include guard.
4655         * mi/mi-console.h: Rename include guard.
4656         * mi/mi-common.h: Rename include guard.
4657         * mi/mi-cmds.h: Rename include guard.
4658         * mi/mi-cmd-break.h: Rename include guard.
4659         * m2-lang.h: Add include guard.
4660         * location.h: Rename include guard.
4661         * linux-record.h: Rename include guard.
4662         * linux-nat.h: Add include guard.
4663         * linux-fork.h: Add include guard.
4664         * i386-darwin-tdep.h: Rename include guard.
4665         * hppa-linux-offsets.h: Add include guard.
4666         * guile/guile.h: Rename include guard.
4667         * guile/guile-internal.h: Rename include guard.
4668         * gnu-nat.h: Rename include guard.
4669         * gdb-stabs.h: Rename include guard.
4670         * frv-tdep.h: Add include guard.
4671         * f-lang.h: Add include guard.
4672         * event-loop.h: Add include guard.
4673         * darwin-nat.h: Rename include guard.
4674         * cp-abi.h: Rename include guard.
4675         * config/sparc/nm-sol2.h: Rename include guard.
4676         * config/nm-nto.h: Rename include guard.
4677         * config/nm-linux.h: Add include guard.
4678         * config/i386/nm-i386gnu.h: Rename include guard.
4679         * config/djgpp/nl_types.h: Rename include guard.
4680         * config/djgpp/langinfo.h: Rename include guard.
4681         * compile/gcc-cp-plugin.h: Add include guard.
4682         * compile/gcc-c-plugin.h: Add include guard.
4683         * compile/compile.h: Rename include guard.
4684         * compile/compile-object-run.h: Rename include guard.
4685         * compile/compile-object-load.h: Rename include guard.
4686         * compile/compile-internal.h: Rename include guard.
4687         * compile/compile-cplus.h: Rename include guard.
4688         * compile/compile-c.h: Rename include guard.
4689         * common/xml-utils.h: Rename include guard.
4690         * common/x86-xstate.h: Rename include guard.
4691         * common/version.h: Rename include guard.
4692         * common/vec.h: Rename include guard.
4693         * common/tdesc.h: Rename include guard.
4694         * common/selftest.h: Rename include guard.
4695         * common/scoped_restore.h: Rename include guard.
4696         * common/scoped_mmap.h: Rename include guard.
4697         * common/scoped_fd.h: Rename include guard.
4698         * common/safe-iterator.h: Rename include guard.
4699         * common/run-time-clock.h: Rename include guard.
4700         * common/refcounted-object.h: Rename include guard.
4701         * common/queue.h: Rename include guard.
4702         * common/ptid.h: Rename include guard.
4703         * common/print-utils.h: Rename include guard.
4704         * common/preprocessor.h: Rename include guard.
4705         * common/pathstuff.h: Rename include guard.
4706         * common/observable.h: Rename include guard.
4707         * common/netstuff.h: Rename include guard.
4708         * common/job-control.h: Rename include guard.
4709         * common/host-defs.h: Rename include guard.
4710         * common/gdb_wait.h: Rename include guard.
4711         * common/gdb_vecs.h: Rename include guard.
4712         * common/gdb_unlinker.h: Rename include guard.
4713         * common/gdb_unique_ptr.h: Rename include guard.
4714         * common/gdb_tilde_expand.h: Rename include guard.
4715         * common/gdb_sys_time.h: Rename include guard.
4716         * common/gdb_string_view.h: Rename include guard.
4717         * common/gdb_splay_tree.h: Rename include guard.
4718         * common/gdb_setjmp.h: Rename include guard.
4719         * common/gdb_ref_ptr.h: Rename include guard.
4720         * common/gdb_optional.h: Rename include guard.
4721         * common/gdb_locale.h: Rename include guard.
4722         * common/gdb_assert.h: Rename include guard.
4723         * common/filtered-iterator.h: Rename include guard.
4724         * common/filestuff.h: Rename include guard.
4725         * common/fileio.h: Rename include guard.
4726         * common/environ.h: Rename include guard.
4727         * common/common-utils.h: Rename include guard.
4728         * common/common-types.h: Rename include guard.
4729         * common/common-regcache.h: Rename include guard.
4730         * common/common-inferior.h: Rename include guard.
4731         * common/common-gdbthread.h: Rename include guard.
4732         * common/common-exceptions.h: Rename include guard.
4733         * common/common-defs.h: Rename include guard.
4734         * common/common-debug.h: Rename include guard.
4735         * common/cleanups.h: Rename include guard.
4736         * common/buffer.h: Rename include guard.
4737         * common/btrace-common.h: Rename include guard.
4738         * common/break-common.h: Rename include guard.
4739         * cli/cli-utils.h: Rename include guard.
4740         * cli/cli-style.h: Rename include guard.
4741         * cli/cli-setshow.h: Rename include guard.
4742         * cli/cli-script.h: Rename include guard.
4743         * cli/cli-interp.h: Rename include guard.
4744         * cli/cli-decode.h: Rename include guard.
4745         * cli/cli-cmds.h: Rename include guard.
4746         * charset-list.h: Add include guard.
4747         * buildsym-legacy.h: Rename include guard.
4748         * bfin-tdep.h: Add include guard.
4749         * ax.h: Rename include guard.
4750         * arm-linux-tdep.h: Add include guard.
4751         * arm-fbsd-tdep.h: Add include guard.
4752         * arch/xtensa.h: Rename include guard.
4753         * arch/tic6x.h: Add include guard.
4754         * arch/i386.h: Add include guard.
4755         * arch/arm.h: Rename include guard.
4756         * arch/arm-linux.h: Rename include guard.
4757         * arch/arm-get-next-pcs.h: Rename include guard.
4758         * arch/amd64.h: Add include guard.
4759         * arch/aarch64-insn.h: Rename include guard.
4760         * arch-utils.h: Rename include guard.
4761         * annotate.h: Add include guard.
4762         * amd64-darwin-tdep.h: Rename include guard.
4763         * aarch64-linux-tdep.h: Add include guard.
4764         * aarch64-fbsd-tdep.h: Add include guard.
4765         * aarch32-linux-nat.h: Add include guard.
4766
4767 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4768
4769         * macrotab.c (macro_define_internal): New function that
4770         factorizes macro_define_object_internal and macro_define_function
4771         code.
4772         (macro_define_object_internal): Use macro_define_internal.
4773         (macro_define_function): Likewise.
4774
4775 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4776
4777         * macrocmd.c (extract_identifier): Return
4778         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4779         callers.
4780
4781 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4782
4783         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4784
4785 2019-02-05  Tom Tromey  <tom@tromey.com>
4786
4787         * target.c (target_stack::unpush): Move assertion earlier.
4788
4789 2019-01-30  Tom Tromey  <tom@tromey.com>
4790
4791         PR python/23615:
4792         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4793         (gdbpy_parse_and_eval): Likewise.
4794         * python/python-internal.h (gdbpy_allow_threads): New class.
4795
4796 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4797
4798         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4799         (aarch64_fbsd_fpregmap): Move earlier.
4800         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4801         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4802         instead of individual calls to trad_frame_set_reg_addr.
4803         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4804         earlier.
4805         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4806         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4807         instead of individual calls to trad_frame_set_reg_addr.
4808
4809 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4810
4811         * CONTRIBUTE: Replace contribution list with wiki link.
4812
4813 2019-01-25  Tom Tromey  <tom@tromey.com>
4814
4815         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4816
4817 2019-01-25  Tom Tromey  <tom@tromey.com>
4818
4819         * xtensa-linux-nat.c: Fix common/ includes.
4820         * xml-support.h: Fix common/ includes.
4821         * xml-support.c: Fix common/ includes.
4822         * x86-linux-nat.c: Fix common/ includes.
4823         * windows-nat.c: Fix common/ includes.
4824         * varobj.h: Fix common/ includes.
4825         * varobj.c: Fix common/ includes.
4826         * value.c: Fix common/ includes.
4827         * valops.c: Fix common/ includes.
4828         * utils.c: Fix common/ includes.
4829         * unittests/xml-utils-selftests.c: Fix common/ includes.
4830         * unittests/utils-selftests.c: Fix common/ includes.
4831         * unittests/unpack-selftests.c: Fix common/ includes.
4832         * unittests/tracepoint-selftests.c: Fix common/ includes.
4833         * unittests/style-selftests.c: Fix common/ includes.
4834         * unittests/string_view-selftests.c: Fix common/ includes.
4835         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4836         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4837         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4838         * unittests/rsp-low-selftests.c: Fix common/ includes.
4839         * unittests/parse-connection-spec-selftests.c: Fix common/
4840         includes.
4841         * unittests/optional-selftests.c: Fix common/ includes.
4842         * unittests/offset-type-selftests.c: Fix common/ includes.
4843         * unittests/observable-selftests.c: Fix common/ includes.
4844         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4845         * unittests/memrange-selftests.c: Fix common/ includes.
4846         * unittests/memory-map-selftests.c: Fix common/ includes.
4847         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4848         * unittests/function-view-selftests.c: Fix common/ includes.
4849         * unittests/environ-selftests.c: Fix common/ includes.
4850         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4851         * unittests/common-utils-selftests.c: Fix common/ includes.
4852         * unittests/cli-utils-selftests.c: Fix common/ includes.
4853         * unittests/array-view-selftests.c: Fix common/ includes.
4854         * ui-file.c: Fix common/ includes.
4855         * tui/tui-io.c: Fix common/ includes.
4856         * tracepoint.h: Fix common/ includes.
4857         * tracepoint.c: Fix common/ includes.
4858         * tracefile-tfile.c: Fix common/ includes.
4859         * top.h: Fix common/ includes.
4860         * top.c: Fix common/ includes.
4861         * thread.c: Fix common/ includes.
4862         * target/waitstatus.h: Fix common/ includes.
4863         * target/waitstatus.c: Fix common/ includes.
4864         * target.h: Fix common/ includes.
4865         * target.c: Fix common/ includes.
4866         * target-memory.c: Fix common/ includes.
4867         * target-descriptions.c: Fix common/ includes.
4868         * symtab.h: Fix common/ includes.
4869         * symfile.c: Fix common/ includes.
4870         * stap-probe.c: Fix common/ includes.
4871         * spu-linux-nat.c: Fix common/ includes.
4872         * sparc-nat.c: Fix common/ includes.
4873         * source.c: Fix common/ includes.
4874         * solib.c: Fix common/ includes.
4875         * solib-target.c: Fix common/ includes.
4876         * ser-unix.c: Fix common/ includes.
4877         * ser-tcp.c: Fix common/ includes.
4878         * ser-pipe.c: Fix common/ includes.
4879         * ser-base.c: Fix common/ includes.
4880         * selftest-arch.c: Fix common/ includes.
4881         * s12z-tdep.c: Fix common/ includes.
4882         * rust-exp.y: Fix common/ includes.
4883         * rs6000-aix-tdep.c: Fix common/ includes.
4884         * riscv-tdep.c: Fix common/ includes.
4885         * remote.c: Fix common/ includes.
4886         * remote-notif.h: Fix common/ includes.
4887         * remote-fileio.h: Fix common/ includes.
4888         * remote-fileio.c: Fix common/ includes.
4889         * regcache.h: Fix common/ includes.
4890         * regcache.c: Fix common/ includes.
4891         * record-btrace.c: Fix common/ includes.
4892         * python/python.c: Fix common/ includes.
4893         * python/py-type.c: Fix common/ includes.
4894         * python/py-inferior.c: Fix common/ includes.
4895         * progspace.h: Fix common/ includes.
4896         * producer.c: Fix common/ includes.
4897         * procfs.c: Fix common/ includes.
4898         * proc-api.c: Fix common/ includes.
4899         * printcmd.c: Fix common/ includes.
4900         * ppc-linux-nat.c: Fix common/ includes.
4901         * parser-defs.h: Fix common/ includes.
4902         * osdata.c: Fix common/ includes.
4903         * obsd-nat.c: Fix common/ includes.
4904         * nat/x86-linux.c: Fix common/ includes.
4905         * nat/x86-linux-dregs.c: Fix common/ includes.
4906         * nat/x86-dregs.h: Fix common/ includes.
4907         * nat/x86-dregs.c: Fix common/ includes.
4908         * nat/ppc-linux.c: Fix common/ includes.
4909         * nat/mips-linux-watch.h: Fix common/ includes.
4910         * nat/mips-linux-watch.c: Fix common/ includes.
4911         * nat/linux-waitpid.c: Fix common/ includes.
4912         * nat/linux-ptrace.h: Fix common/ includes.
4913         * nat/linux-ptrace.c: Fix common/ includes.
4914         * nat/linux-procfs.c: Fix common/ includes.
4915         * nat/linux-personality.c: Fix common/ includes.
4916         * nat/linux-osdata.c: Fix common/ includes.
4917         * nat/linux-namespaces.c: Fix common/ includes.
4918         * nat/linux-btrace.h: Fix common/ includes.
4919         * nat/linux-btrace.c: Fix common/ includes.
4920         * nat/fork-inferior.c: Fix common/ includes.
4921         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4922         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4923         * nat/aarch64-linux.c: Fix common/ includes.
4924         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4925         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4926         * namespace.h: Fix common/ includes.
4927         * mips-linux-tdep.c: Fix common/ includes.
4928         * minsyms.c: Fix common/ includes.
4929         * mi/mi-parse.h: Fix common/ includes.
4930         * mi/mi-main.c: Fix common/ includes.
4931         * mi/mi-cmd-env.c: Fix common/ includes.
4932         * memrange.h: Fix common/ includes.
4933         * memattr.c: Fix common/ includes.
4934         * maint.h: Fix common/ includes.
4935         * maint.c: Fix common/ includes.
4936         * main.c: Fix common/ includes.
4937         * machoread.c: Fix common/ includes.
4938         * location.c: Fix common/ includes.
4939         * linux-thread-db.c: Fix common/ includes.
4940         * linux-nat.c: Fix common/ includes.
4941         * linux-fork.c: Fix common/ includes.
4942         * inline-frame.c: Fix common/ includes.
4943         * infrun.c: Fix common/ includes.
4944         * inflow.c: Fix common/ includes.
4945         * inferior.h: Fix common/ includes.
4946         * inferior.c: Fix common/ includes.
4947         * infcmd.c: Fix common/ includes.
4948         * inf-ptrace.c: Fix common/ includes.
4949         * inf-child.c: Fix common/ includes.
4950         * ia64-linux-nat.c: Fix common/ includes.
4951         * i387-tdep.c: Fix common/ includes.
4952         * i386-tdep.c: Fix common/ includes.
4953         * i386-linux-tdep.c: Fix common/ includes.
4954         * i386-linux-nat.c: Fix common/ includes.
4955         * i386-go32-tdep.c: Fix common/ includes.
4956         * i386-fbsd-tdep.c: Fix common/ includes.
4957         * i386-fbsd-nat.c: Fix common/ includes.
4958         * guile/scm-type.c: Fix common/ includes.
4959         * guile/guile.c: Fix common/ includes.
4960         * go32-nat.c: Fix common/ includes.
4961         * gnu-nat.c: Fix common/ includes.
4962         * gdbthread.h: Fix common/ includes.
4963         * gdbarch-selftests.c: Fix common/ includes.
4964         * gdb_usleep.c: Fix common/ includes.
4965         * gdb_select.h: Fix common/ includes.
4966         * gdb_bfd.c: Fix common/ includes.
4967         * gcore.c: Fix common/ includes.
4968         * fork-child.c: Fix common/ includes.
4969         * findvar.c: Fix common/ includes.
4970         * fbsd-nat.c: Fix common/ includes.
4971         * event-top.c: Fix common/ includes.
4972         * event-loop.c: Fix common/ includes.
4973         * dwarf2read.c: Fix common/ includes.
4974         * dwarf2loc.c: Fix common/ includes.
4975         * dwarf2-frame.c: Fix common/ includes.
4976         * dwarf-index-cache.c: Fix common/ includes.
4977         * dtrace-probe.c: Fix common/ includes.
4978         * disasm-selftests.c: Fix common/ includes.
4979         * defs.h: Fix common/ includes.
4980         * csky-tdep.c: Fix common/ includes.
4981         * cp-valprint.c: Fix common/ includes.
4982         * cp-support.h: Fix common/ includes.
4983         * cp-support.c: Fix common/ includes.
4984         * corelow.c: Fix common/ includes.
4985         * completer.h: Fix common/ includes.
4986         * completer.c: Fix common/ includes.
4987         * compile/compile.c: Fix common/ includes.
4988         * compile/compile-loc2c.c: Fix common/ includes.
4989         * compile/compile-cplus-types.c: Fix common/ includes.
4990         * compile/compile-cplus-symbols.c: Fix common/ includes.
4991         * command.h: Fix common/ includes.
4992         * cli/cli-dump.c: Fix common/ includes.
4993         * cli/cli-cmds.c: Fix common/ includes.
4994         * charset.c: Fix common/ includes.
4995         * build-id.c: Fix common/ includes.
4996         * btrace.h: Fix common/ includes.
4997         * btrace.c: Fix common/ includes.
4998         * breakpoint.h: Fix common/ includes.
4999         * breakpoint.c: Fix common/ includes.
5000         * ax.h:
5001         (enum agent_op): Fix common/ includes.
5002         * ax-general.c (struct aop_map): Fix common/ includes.
5003         * ax-gdb.c: Fix common/ includes.
5004         * auxv.c: Fix common/ includes.
5005         * auto-load.c: Fix common/ includes.
5006         * arm-tdep.c: Fix common/ includes.
5007         * arch/riscv.c: Fix common/ includes.
5008         * arch/ppc-linux-common.c: Fix common/ includes.
5009         * arch/i386.c: Fix common/ includes.
5010         * arch/arm.c: Fix common/ includes.
5011         * arch/arm-linux.c: Fix common/ includes.
5012         * arch/arm-get-next-pcs.c: Fix common/ includes.
5013         * arch/amd64.c: Fix common/ includes.
5014         * arch/aarch64.c: Fix common/ includes.
5015         * arch/aarch64-insn.c: Fix common/ includes.
5016         * arch-utils.c: Fix common/ includes.
5017         * amd64-windows-tdep.c: Fix common/ includes.
5018         * amd64-tdep.c: Fix common/ includes.
5019         * amd64-sol2-tdep.c: Fix common/ includes.
5020         * amd64-obsd-tdep.c: Fix common/ includes.
5021         * amd64-nbsd-tdep.c: Fix common/ includes.
5022         * amd64-linux-tdep.c: Fix common/ includes.
5023         * amd64-linux-nat.c: Fix common/ includes.
5024         * amd64-fbsd-tdep.c: Fix common/ includes.
5025         * amd64-fbsd-nat.c: Fix common/ includes.
5026         * amd64-dicos-tdep.c: Fix common/ includes.
5027         * amd64-darwin-tdep.c: Fix common/ includes.
5028         * agent.c: Fix common/ includes.
5029         * ada-lang.h: Fix common/ includes.
5030         * ada-lang.c: Fix common/ includes.
5031         * aarch64-tdep.c: Fix common/ includes.
5032
5033 2019-01-25  Tom Tromey  <tom@tromey.com>
5034
5035         * common/create-version.sh: Use common/version.h.
5036
5037 2019-01-24  Pedro Alves  <palves@redhat.com>
5038
5039         * infrun.c (signal_stop, signal_print, signal_program)
5040         (signal_catch, signal_pass): Now arrays instead of pointers.
5041         (update_signals_program_target, do_target_resume)
5042         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5043         * linux-nat.c (linux_nat_target::pass_signals)
5044         (linux_nat_target::create_inferior, linux_nat_target::attach):
5045         Adjust.
5046         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5047         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5048         * procfs.c (procfs_target::pass_signals): Adjust.
5049         * record-full.c (record_full_target::resume): Adjust.
5050         * remote.c (remote_target::pass_signals)
5051         (remote_target::program_signals): Adjust.
5052         * target-debug.h (target_debug_print_signals): Now takes a
5053         gdb::array_view as parameter.  Adjust.
5054         * target.h (target_ops) <pass_signals, program_signals>: Replace
5055         pointer and length parameters with gdb::array_view.
5056         (target_pass_signals, target_program_signals): Likewise.
5057         * target-delegates.c: Regenerate.
5058
5059 2019-01-24  Pedro Alves  <palves@redhat.com>
5060
5061         * common/forward-scope-exit.h
5062         (forward_scope_exit::forward_scope_exit): Pass arguments to
5063         m_bind_function directly, instead of creating a std::bind and
5064         copying that.
5065
5066 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5067
5068         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5069         for static members.
5070         (pass_in_v_vfp_candidate): Likewise.
5071
5072 2019-01-23  Tom Tromey  <tom@tromey.com>
5073             Pedro Alves  <palves@redhat.com>
5074
5075         * regcache.c (class regcache_invalidator): Remove.
5076         (regcache::raw_write): Use make_scope_exit.
5077
5078 2019-01-23  Tom Tromey  <tom@tromey.com>
5079
5080         * ui-out.h (class ui_out_emit_type): Update comment.
5081
5082 2019-01-23  Tom Tromey  <tom@tromey.com>
5083
5084         * infrun.c (fetch_inferior_event): Update comment.
5085
5086 2019-01-23  Tom Tromey  <tom@tromey.com>
5087             Pedro Alves  <palves@redhat.com>
5088
5089         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5090         parameter.
5091         (fetch_inferior_event): Use SCOPE_EXIT.
5092
5093
5094 2019-01-23  Tom Tromey  <tom@tromey.com>
5095             Pedro Alves  <palves@redhat.com>
5096
5097         * infrun.c (disable_thread_events): Delete.
5098         (stop_all_threads): Use SCOPE_EXIT.
5099
5100 2019-01-23  Tom Tromey  <tom@tromey.com>
5101             Pedro Alves  <palves@redhat.com>
5102
5103         * symfile.c: Include forward-scope-exit.h.
5104         (clear_symtab_users_cleanup): Replace forward declaration with
5105         a FORWARD_SCOPE_EXIT.
5106         (syms_from_objfile_1): Use the forward_scope_exit and
5107         gdb::optional instead of cleanup_function.
5108         (reread_symbols): Use the forward_scope_exit instead of
5109         cleanup_function.
5110         (clear_symtab_users_cleanup): Remove function.
5111
5112 2019-01-23  Tom Tromey  <tom@tromey.com>
5113             Pedro Alves  <palves@redhat.com>
5114
5115         * linux-nat.c: Include scope-exit.h.
5116         (cleanup_target_stop): Remove.
5117         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5118         SCOPE_EXIT.
5119
5120 2019-01-23  Tom Tromey  <tom@tromey.com>
5121             Pedro Alves  <palves@redhat.com>
5122
5123         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
5124         (call_function_by_hand_dummy): Use SCOPE_EXIT.
5125
5126 2019-01-23  Tom Tromey  <tom@tromey.com>
5127             Andrew Burgess  <andrew.burgess@embecosm.com>
5128             Pedro Alves  <palves@redhat.com>
5129
5130         * infrun.c (fetch_inferior_event): Use scope_exit.
5131         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
5132         * top.c (execute_command): Use scope_exit.
5133         * breakpoint.c (bpstat_do_actions): Use scope_exit.
5134         * utils.c (do_bpstat_clear_actions_cleanup)
5135         (make_bpstat_clear_actions_cleanup): Remove.
5136
5137 2019-01-23  Tom Tromey  <tom@tromey.com>
5138             Pedro Alves  <palves@redhat.com>
5139
5140         * infrun.c: Include "common/scope-exit.h"
5141         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
5142         (wait_for_inferior): Use SCOPE_EXIT.
5143         (fetch_inferior_event): Use scope_exit.
5144
5145 2019-01-23  Tom Tromey  <tom@tromey.com>
5146             Pedro Alves  <palves@redhat.com>
5147
5148         * breakpoint.c (create_breakpoint): Remove cleanup.
5149
5150 2019-01-23  Tom Tromey  <tom@tromey.com>
5151             Andrew Burgess  <andrew.burgess@embecosm.com>
5152             Pedro Alves  <palves@redhat.com>
5153
5154 2019-01-23  Pedro Alves  <palves@redhat.com>
5155
5156         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
5157
5158 2019-01-23  Pedro Alves  <palves@redhat.com>
5159             Andrew Burgess  <andrew.burgess@embecosm.com>
5160
5161         * gdbthread.h: Include "common/forward-scope-exit.h".
5162         (scoped_finish_thread_state): Redefine custom class in terms of
5163         forward_scope_exit.
5164
5165 2019-01-23  Pedro Alves  <palves@redhat.com>
5166             Andrew Burgess  <andrew.burgess@embecosm.com>
5167
5168         * common/forward-scope-exit.h: New file.
5169
5170 2019-01-23  Pedro Alves  <palves@redhat.com>
5171             Andrew Burgess  <andrew.burgess@embecosm.com>
5172             Tom Tromey  <tom@tromey.com>
5173
5174         * common/scope-exit.h: New file.
5175
5176 2019-01-23  Pedro Alves  <palves@redhat.com>
5177
5178         * common/preprocessor.h (ESC): Rename to ...
5179         (ESC_PARENS): ... this.
5180         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
5181         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
5182
5183 2019-01-23  Tom Tromey  <tom@tromey.com>
5184
5185         * language.h (class scoped_switch_to_sym_language_if_auto):
5186         Initialize m_lang in both cases.
5187
5188 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
5189
5190         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
5191         with XCNEW.
5192
5193 2019-01-22  Tom Tromey  <tom@tromey.com>
5194
5195         * corelow.c: Do not include sys/file.h.
5196
5197 2019-01-22  Tom Tromey  <tom@tromey.com>
5198
5199         * tui/tui-wingeneral.h: Include gdb_curses.h.
5200
5201 2019-01-22  Tom Tromey  <tom@tromey.com>
5202
5203         * source-cache.h (class source_cache) <get_source_lines,
5204         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
5205
5206 2019-01-22  Tom Tromey  <tom@tromey.com>
5207
5208         * remote-fileio.h (struct remote_target): Declare.
5209
5210 2019-01-22  Tom Tromey  <tom@tromey.com>
5211
5212         * python/py-arch.c: Do not include py-ref.h.
5213         * python/py-bpevent.c: Do not include py-ref.h.
5214         * python/py-cmd.c: Do not include py-ref.h.
5215         * python/py-continueevent.c: Do not include py-ref.h.
5216         * python/py-event.h: Do not include py-ref.h.
5217         * python/py-evtregistry.c: Do not include py-ref.h.
5218         * python/py-finishbreakpoint.c: Do not include py-ref.h.
5219         * python/py-frame.c: Do not include py-ref.h.
5220         * python/py-framefilter.c: Do not include py-ref.h.
5221         * python/py-function.c: Do not include py-ref.h.
5222         * python/py-infevents.c: Do not include py-ref.h.
5223         * python/py-linetable.c: Do not include py-ref.h.
5224         * python/py-objfile.c: Do not include py-ref.h.
5225         * python/py-param.c: Do not include py-ref.h.
5226         * python/py-prettyprint.c: Do not include py-ref.h.
5227         * python/py-progspace.c: Do not include py-ref.h.
5228         * python/py-symbol.c: Do not include py-ref.h.
5229         * python/py-symtab.c: Do not include py-ref.h.
5230         * python/py-type.c: Do not include py-ref.h.
5231         * python/py-unwind.c: Do not include py-ref.h.
5232         * python/py-utils.c: Do not include py-ref.h.
5233         * python/py-value.c: Do not include py-ref.h.
5234         * python/py-varobj.c: Do not include py-ref.h.
5235         * python/py-xmethods.c: Do not include py-ref.h.
5236         * python/python.c: Do not include py-ref.h.
5237         * varobj.c: Do not include py-ref.h.
5238
5239 2019-01-22  Tom Tromey  <tom@tromey.com>
5240
5241         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
5242         keyword for bcache.
5243
5244 2019-01-22  Tom Tromey  <tom@tromey.com>
5245
5246         * compile/compile-cplus-types.c: Remove a comment by #include.
5247
5248 2019-01-22  Tom Tromey  <tom@tromey.com>
5249
5250         * compile/gcc-c-plugin.h: Include compile-internal.h.
5251
5252 2019-01-22  Tom Tromey  <tom@tromey.com>
5253
5254         * stabsread.c (EXTERN): Do not define.
5255         (symnum, next_symbol_text_func, processing_gcc_compilation)
5256         (within_function, global_sym_chain, global_stabs)
5257         (previous_stab_code, this_object_header_files)
5258         (n_this_object_header_files)
5259         (n_allocated_this_object_header_files): Define.
5260         * stabsread.h (EXTERN): Never define.  Use "extern".
5261
5262 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5263
5264         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
5265         history_value.
5266
5267 2019-01-21  Tom Tromey  <tom@tromey.com>
5268
5269         * ui-out.c: Fix includes.
5270         * tui/tui-source.c: Fix includes.
5271         * target.c: Fix includes.
5272         * remote.c: Fix includes.
5273         * regcache.c: Fix includes.
5274         * python/py-block.c: Fix includes.
5275         * printcmd.c: Fix includes.
5276         * or1k-tdep.c: Fix includes.
5277         * mi/mi-main.c: Fix includes.
5278         * m32r-tdep.c: Fix includes.
5279         * csky-tdep.c: Fix includes.
5280         * compile/compile-cplus-types.c: Fix includes.
5281         * cli/cli-interp.c: Fix includes.
5282
5283 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5284
5285         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5286         for padding.
5287
5288 2019-01-16  Tom Tromey  <tom@tromey.com>
5289
5290         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5291         earlier.
5292         (struct objfile) <msymbols_range>: Move from top level.
5293         <msymbols>: New method.
5294         (class objfile_msymbols): Remove.
5295         * symtab.c (default_collect_symbol_completion_matches_break_on):
5296         Update.
5297         * symmisc.c (dump_msymbols): Update.
5298         * stabsread.c (scan_file_globals): Update.
5299         * objc-lang.c (info_selectors_command, info_classes_command)
5300         (find_methods): Update.
5301         * minsyms.c (find_solib_trampoline_target): Update.
5302         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5303         * coffread.c (coff_symfile_read): Update.
5304         * ada-lang.c (ada_lookup_simple_minsym)
5305         (ada_collect_symbol_completion_matches): Update.
5306
5307 2019-01-16  Tom Tromey  <tom@tromey.com>
5308
5309         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5310         type.  Remove no-argument constructor.
5311         <iterator::operator++>: Simplify.
5312         <begin>: Update.
5313         <end>: Use minimal_symbol_count.
5314
5315 2019-01-16  Tom Tromey  <tom@tromey.com>
5316
5317         * objfiles.h (struct objfile) <psymtabs>: New method.
5318         (class objfile_psymtabs): Remove.
5319         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5320         typedef.
5321         <range>: New method.
5322         (require_partial_symbols): Change return type.
5323         * psymtab.c (require_partial_symbols)
5324         (psym_expand_symtabs_matching): Update.
5325         * mdebugread.c (parse_partial_symbols): Update.
5326         * dbxread.c (dbx_end_psymtab): Update.
5327
5328 2019-01-15  Tom Tromey  <tom@tromey.com>
5329
5330         * symtab.c (lookup_objfile_from_block)
5331         (lookup_symbol_in_objfile_symtabs)
5332         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5333         (find_line_symtab, info_sources_command)
5334         (default_collect_symbol_completion_matches_break_on)
5335         (make_source_files_completion_list): Update.
5336         * symmisc.c (print_objfile_statistics, dump_objfile)
5337         (maintenance_print_symbols, maintenance_info_symtabs)
5338         (maintenance_check_symtabs, maintenance_info_line_tables):
5339         Update.
5340         * source.c (select_source_symtab)
5341         (forget_cached_source_info_for_objfile): Update.
5342         * objfiles.h (class objfile_compunits): Remove.
5343         (struct objfile) <compunits_range>: New typedef.
5344         (compunits): New method.
5345         * objfiles.c (objfile_relocate1): Update.
5346         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5347         * maint.c (count_symtabs_and_blocks): Update.
5348         * linespec.c (iterate_over_all_matching_symtabs): Update.
5349         * cp-support.c (add_symbol_overload_list_qualified): Update.
5350         * coffread.c (coff_symtab_read): Update.
5351         * ada-lang.c (add_nonlocal_symbols)
5352         (ada_collect_symbol_completion_matches)
5353         (ada_add_global_exceptions): Update.
5354
5355 2019-01-15  Tom Tromey  <tom@tromey.com>
5356
5357         * progspace.h (program_space) <objfiles_safe_range>: New
5358         typedef.
5359         <objfiles_safe>: New method.
5360         * objfiles.h (class all_objfiles_safe): Remove.
5361         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5362         * jit.c (jit_inferior_exit_hook): Update.
5363
5364 2019-01-17  Tom Tromey  <tom@tromey.com>
5365
5366         * progspace.h (program_space) <objfiles_range>: New typedef.
5367         <objfiles>: New method.
5368         <objfiles_head>: Rename from objfiles.
5369         (object_files): Update.
5370         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5371         * guile/scm-pretty-print.c
5372         (ppscm_find_pretty_printer_from_objfiles): Update.
5373         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5374         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5375         Update.
5376         * python/py-progspace.c (pspy_get_objfiles): Update.
5377         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5378         Update.
5379         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5380         (objfpy_lookup_objfile_by_build_id): Update.
5381         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5382         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5383         Update.
5384         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5385         (expand_symtab_containing_pc, lookup_objfile_from_block)
5386         (lookup_static_symbol, basic_lookup_transparent_type)
5387         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5388         (find_line_symtab, info_sources_command)
5389         (default_collect_symbol_completion_matches_break_on)
5390         (make_source_files_completion_list, find_main_name): Update.
5391         * symmisc.c (print_symbol_bcache_statistics)
5392         (print_objfile_statistics, maintenance_print_symbols)
5393         (maintenance_print_msymbols, maintenance_print_objfiles)
5394         (maintenance_info_symtabs, maintenance_check_symtabs)
5395         (maintenance_expand_symtabs, maintenance_info_line_tables):
5396         Update.
5397         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5398         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5399         (map_overlay_command, unmap_overlay_command)
5400         (simple_overlay_update, expand_symtabs_matching)
5401         (map_symbol_filenames): Update.
5402         * symfile-debug.c (set_debug_symfile): Update.
5403         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5404         Update.
5405         * source.c (select_source_symtab, forget_cached_source_info):
5406         Update.
5407         * solib.c (solib_read_symbols): Update.
5408         * solib-spu.c (append_ocl_sos): Update.
5409         * psymtab.c (maintenance_print_psymbols)
5410         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5411         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5412         * printcmd.c (info_symbol_command): Update.
5413         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5414         Update.
5415         * objfiles.h (class all_objfiles): Remove.
5416         * objfiles.c (have_partial_symbols, have_full_symbols)
5417         (have_minimal_symbols, qsort_cmp, update_section_map)
5418         (shared_objfile_contains_address_p)
5419         (default_iterate_over_objfiles_in_search_order): Update.
5420         * objc-lang.c (info_selectors_command, info_classes_command)
5421         (find_methods): Update.
5422         * minsyms.c (find_solib_trampoline_target): Update.
5423         * maint.c (maintenance_info_sections)
5424         (maintenance_translate_address, count_symtabs_and_blocks):
5425         Update.
5426         * main.c (captured_main_1): Update.
5427         * linux-thread-db.c (try_thread_db_load_from_pdir)
5428         (has_libpthread): Update.
5429         * linespec.c (iterate_over_all_matching_symtabs)
5430         (search_minsyms_for_name): Update.
5431         * jit.c (jit_find_objf_with_entry_addr): Update.
5432         * hppa-tdep.c (find_unwind_entry)
5433         (hppa_lookup_stub_minimal_symbol): Update.
5434         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5435         Update.
5436         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5437         (elf_gnu_ifunc_resolve_by_got): Update.
5438         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5439         * dwarf-index-write.c (save_gdb_index_command): Update.
5440         * cp-support.c (add_symbol_overload_list_qualified): Update.
5441         * breakpoint.c (create_overlay_event_breakpoint)
5442         (create_longjmp_master_breakpoint)
5443         (create_std_terminate_master_breakpoint)
5444         (create_exception_master_breakpoint): Update.
5445         * blockframe.c (find_pc_partial_function): Update.
5446         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5447         (ada_collect_symbol_completion_matches)
5448         (ada_add_global_exceptions): Update.
5449
5450 2019-01-17  Tom Tromey  <tom@tromey.com>
5451
5452         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5453         declare VEC.
5454         (solib_target_parse_libraries): Change return type.
5455         (library_list_start_segment, library_list_start_section)
5456         (library_list_end_library, library_list_start_library); Update.
5457         (solib_target_free_library_list): Remove.
5458         (solib_target_parse_libraries): Remove cleanup.  Change return
5459         type.
5460         (solib_target_current_sos): Update.
5461
5462 2019-01-17  Tom Tromey  <tromey@bapiya>
5463
5464         * valprint.c: Replace "the the" with "the".
5465         * symtab.c: Replace "the the" with "the".
5466         * solib.c: Replace "the the" with "the".
5467         * solib-dsbt.c: Replace "the the" with "the".
5468         * linespec.c: Replace "the the" with "the".
5469         * dwarf2loc.h: Replace "the the" with "the".
5470         * amd64-windows-tdep.c: Replace "the the" with "the".
5471         * aarch64-tdep.c: Replace "the the" with "the".
5472
5473 2019-01-16  Keith Seitz  <keiths@redhat.com>
5474
5475         PR gdb/23773
5476         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5477         <builder>: Rename to ..
5478         <m_builder>: ... this and make private.
5479         (dwarf2_cu::get_builder): New method.  Change all users of
5480         `builder' to use this method.
5481         (dwarf2_start_symtab): Move to ...
5482         (dwarf2_cu::start_symtab): ... here.  Update all callers
5483         (setup_type_unit_groups): Move to ...
5484         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5485         callers.
5486         (dwarf2_cu::reset_builder): New method.
5487         (process_full_compunit, process_full_type_unit): Use
5488         dwarf2_cu::reset_builder.
5489         (follow_die_offset): Record the ancestor CU if it is different
5490         from the followed DIE's CU.
5491         (follow_die_sig_1): Likewise.
5492
5493 2019-01-15  Tom Tromey  <tom@tromey.com>
5494
5495         * remote.c (class remote_state) <buf>: Now a char_vector.
5496         <buf_size>: Remove.
5497         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5498         parameter.
5499         (remote_target::getpkt_or_notif_sane_1)
5500         (remote_target::getpkt_sane)
5501         (remote_target::getpkt_or_notif_sane): Likewise.
5502         (class remote_target) <putpkt>: New overload.
5503         (remote_target::read_frame): Change type of "buf_p".  Remove
5504         sizeof_p parameter.
5505         (packet_ok): New overload.
5506         (packet_check_result): New overload.
5507         Update all uses.
5508
5509 2019-01-14  Tom Tromey  <tom@tromey.com>
5510
5511         * remote-notif.c (handle_notification, remote_notif_ack)
5512         (remote_notif_parse): Make "buf" const.
5513         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5514         const.
5515         (remote_notif_parse, remote_notif_ack, handle_notification):
5516         Likewise.
5517         * remote.c (remote_notif_stop_parse): Make "buf" const.
5518         (remote_target::remote_parse_stop_reply): Make "buf" const.
5519         (remote_notif_stop_ack): Make "buf" const.
5520
5521 2019-01-14  Tom Tromey  <tom@tromey.com>
5522
5523         * remote.c (remote_console_output): Make parameter const.
5524
5525 2019-01-14  Tom Tromey  <tom@tromey.com>
5526
5527         * target-debug.h (target_debug_print_signals): Constify.
5528         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5529         * procfs.c (procfs_target::pass_signals): Update.
5530         * linux-nat.c (linux_nat_target::pass_signals): Update.
5531         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5532         * target-delegates.c: Rebuild.
5533         * remote.c (remote_target::program_signals): Update.
5534         (remote_target::pass_signals): Update.
5535         * target.c (target_pass_signals): Constify argument.
5536         (target_program_signals): Likewise.
5537         * target.h (struct target_ops) <pass_signals, program_signals>:
5538         Constify argument.
5539         (target_pass_signals, target_program_signals): Constify argument.
5540
5541 2019-01-14  Tom Tromey  <tom@tromey.com>
5542
5543         PR tui/28819:
5544         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5545
5546 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5547
5548         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5549         field.
5550         * rs6000-tdep.c: Include reggroups.h.
5551         (IS_V_ALIAS_PSEUDOREG): Define.
5552         (rs6000_register_name): Return names for the "vX" aliases.
5553         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5554         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5555         aliases.  Call default_register_reggroup_p for all other
5556         pseudo-registers.
5557         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5558         New functions.
5559         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5560         Handle "vX" aliases.
5561         (v_alias_pseudo_register_collect): New function.
5562         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5563         (rs6000_gdbarch_init): Initialize "vX" aliases as
5564         pseudo-registers.  Restore registration of
5565         rs6000_pseudo_register_reggroup_p with
5566         set_tdesc_pseudo_register_reggroup_p.
5567
5568 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5569
5570         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5571         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5572         set_gdbarch_num_pseudo_regs.
5573
5574 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5575
5576         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5577         Remove arg prefixname, add do_set and do_show.
5578         Add member functions set_list and show_list.
5579         * cli/cli-style.c (class cli_style_option): Update accordingly.
5580         (style_set_list): Move to file scope.
5581         (style_show_list): Likewise.
5582         (set_style): Call help_list.
5583         (show_style): Call cmd_show_list.
5584         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5585         Update to use the new macro.
5586
5587 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5588
5589         * ada-lang.c (_initialize_ada_language): Expand the help text
5590         for the "catch exception" command.
5591
5592 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5593
5594         * symtab.c (matching_obj_sections): Initialize obj,
5595         declare it closer to its usage.
5596
5597 2019-01-10  Tom Tromey  <tom@tromey.com>
5598
5599         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5600         (basic_inf_threads_range): Remove.
5601         (inf_threads_range, inf_non_exited_threads_range)
5602         (safe_inf_threads_range): Use next_adapter.
5603
5604 2019-01-10  Keith Seitz  <keiths@redhat.com>
5605
5606         PR gdb/23712
5607         PR symtab/23010
5608         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5609         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5610
5611 2019-01-10  Keith Seitz  <keiths@redhat.com>
5612
5613         PR gdb/23712
5614         PR symtab/23010
5615         * dictionary.c (pending_to_vector): Remove.
5616         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5617         Remove _1 suffix, replacing functions of the same name.  Update
5618         all callers.
5619         (dict_create_hashed, dict_create_hashed_expandable)
5620         (dict_create_linear, dict_create_linear_expandable, dict_free)
5621         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5622         Make functions static.
5623
5624 2019-01-10  Keith Seitz  <keiths@redhat.com>
5625
5626         PR gdb/23712
5627         PR symtab/23010
5628         * dictionary.h (struct dictionary): Replace declaration with
5629         multidictionary.
5630         (dict_create_hashed, dict_create_hashed_expandable)
5631         (dict_create_linear, dict_create_linear_expandable)
5632         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5633         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5634         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5635         taking multidictionary argument.
5636         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5637         * block.h (struct block) <dict>: Change to multidictionary
5638         and rename `multidict'.
5639         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5640         symmisc.c: Update all dictionary references to multidictionary.
5641
5642 2019-01-10  Keith Seitz  <keiths@redhat.com>
5643
5644         PR gdb/23712
5645         PR symtab/23010
5646         * dictionary.c: Include unordered_map.
5647         (pending_to_vector): New function.
5648         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5649         Rewrite the non-"_1" functions to take vector instead
5650         of linked list.
5651         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5652         "new" _1 versions of the same name.
5653         (multidictionary): Define.
5654         (std::hash<enum language): New definition.
5655         (collate_pending_symbols_by_language, mdict_create_hashed)
5656         (mdict_create_hashed_expandable, mdict_create_linear)
5657         (mdict_create_linear_expandable, mdict_free)
5658         (find_language_dictionary, create_new_language_dictionary)
5659         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5660         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5661         (mdict_size, mdict_empty): New functions.
5662         * dictionary.h (mdict_iterator): Define.
5663
5664 2019-01-10  Pedro Alves  <palves@redhat.com>
5665
5666         * breakpoint.c (read_uploaded_action)
5667         (create_tracepoint_from_upload): Adjust to use
5668         gdb::unique_xmalloc_ptr.
5669         * ctf.c (ctf_write_uploaded_tp):
5670         (SET_ARRAY_FIELD): Use emplace_back.
5671         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5672         * tracefile-tfile.c (tfile_write_uploaded_tp):
5673         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5674         gdb::unique_xmalloc_ptr.
5675         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5676         at_string, cond_string, cmd_strings>: Replace char pointers
5677         with gdb::unique_xmalloc_ptr.
5678
5679 2019-01-10  Pedro Alves  <palves@redhat.com>
5680
5681         * solib-target.c (library_list_start_library): Don't xstrdup name.
5682
5683 2019-01-10  Pedro Alves  <palves@redhat.com>
5684
5685         * mdebugread.c (parse_partial_symbols): Use
5686         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5687
5688 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5689
5690         * linux-fork.c (scoped_switch_fork_info)
5691         <~scoped_switch_fork_info>: Fix incorrect variable name.
5692
5693 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5694
5695         * linux-fork.c (scoped_switch_fork_info)
5696         <scoped_switch_fork_info>: Make explicit.
5697         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5698
5699 2019-01-10  Tom Tromey  <tom@tromey.com>
5700
5701         * objfiles.h (objfile::reset_psymtabs): Update.
5702         * objfiles.c (objfile::objfile): Update.
5703         * psymtab.h (psymtab_storage::obstack): Update.
5704         (psymtab_storage::m_obstack): Use gdb::optional.
5705         (class psymtab_storage): Update comment.  Remove objfile
5706         parameter.
5707         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5708
5709 2019-01-10  Tom Tromey  <tom@tromey.com>
5710
5711         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5712         <free_psymtabs>: Now private.
5713         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5714         (allocate_psymtab): Use new method.
5715
5716 2019-01-10  Tom Tromey  <tom@tromey.com>
5717
5718         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5719         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5720         * mdebugread.c (parse_partial_symbols): Use
5721         allocate_dependencies.
5722         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5723         allocate_dependencies.
5724         (process_psymtab_comp_unit_reader)
5725         (build_type_psymtab_dependencies): Likewise.
5726         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5727
5728 2019-01-10  Tom Tromey  <tom@tromey.com>
5729
5730         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5731         PSYMBOL_SET_LANGUAGE.
5732         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5733
5734 2019-01-10  Tom Tromey  <tom@tromey.com>
5735
5736         * psymtab.h (psymtab_storage::obstack): New method.
5737         <m_obstack>: Rename from obstack; now private.
5738         * psymtab.c (psymtab_storage): Update.
5739         * dwarf2read.c (create_addrmap_from_index)
5740         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5741         Update.
5742
5743 2019-01-10  Tom Tromey  <tom@tromey.com>
5744
5745         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5746         * objfiles.h (objfile::reset_psymtabs): New method.
5747
5748 2019-01-10  Tom Tromey  <tom@tromey.com>
5749
5750         * symmisc.c (print_symbol_bcache_statistics): Update.
5751         (print_objfile_statistics): Update.
5752         * symfile.c (reread_symbols): Update.
5753         * psymtab.h (class psymtab_storage): New.
5754         * psymtab.c (psymtab_storage): New constructor.
5755         (~psymtab_storage): New destructor.
5756         (require_partial_symbols): Update.
5757         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5758         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5759         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5760         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5761         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5762         (start_psymtab_common, end_psymtab_common)
5763         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5764         (allocate_psymtab): Update.
5765         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5766         Update.
5767         (dump_psymtab_addrmap, maintenance_print_psymbols)
5768         (maintenance_check_psymtabs): Update.
5769         (class objfile_psymtabs): Move to objfiles.h.
5770         * psympriv.h (discard_psymtab): Now inline.
5771         (psymtab_discarder::psymtab_discarder): Update.
5772         (psymtab_discarder::~psymtab_discarder): Update.
5773         (ALL_OBJFILE_PSYMTABS): Rewrite.
5774         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5775         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5776         Remove fields.
5777         <partial_symtabs>: New field.
5778         (class objfile_psymtabs): Move from psymtab.h.  Update.
5779         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5780         psymbol_cache.
5781         (objfile::~objfile): Don't destroy psymbol_cache.
5782         * mdebugread.c (parse_partial_symbols): Update.
5783         * dwarf2read.c (create_addrmap_from_index)
5784         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5785         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5786         (add_partial_subprogram, dwarf2_ranges_read): Update.
5787         * dwarf-index-write.c (write_address_map)
5788         (write_one_signatured_type, recursively_write_psymbols)
5789         (class debug_names, class debug_names, write_psymtabs_to_index):
5790         Update.
5791
5792 2019-01-10  Tom Tromey  <tom@tromey.com>
5793
5794         * symtab.h (SYMBOL_SET_NAMES): Update.
5795         (symbol_set_names): Update.
5796         (MSYMBOL_SET_NAMES): Update.
5797         * symtab.c (symbol_set_names): Change argument to be an
5798         objfile_per_bfd_storage.
5799         * psymtab.c (add_psymbol_to_bcache): Update.
5800         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5801
5802 2019-01-10  Tom Tromey  <tom@tromey.com>
5803
5804         * symtab.c (create_demangled_names_hash): Change argument to be an
5805         objfile_per_bfd_storage.
5806         (symbol_set_names): Update.
5807
5808 2019-01-10  Tom Tromey  <tom@tromey.com>
5809
5810         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5811         init_psymbol_list.
5812         * psymtab.c (init_psymbol_list): Do nothing if already called.
5813         * psympriv.h (init_psymbol_list): Add comment.
5814         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5815         init_psymbol_list.
5816         * dbxread.c (dbx_symfile_read): Unconditionally call
5817         init_psymbol_list.
5818
5819 2019-01-10  Tom Tromey  <tom@tromey.com>
5820
5821         * xcoffread.c (scan_xcoff_symtab): Update.
5822         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5823         "where".
5824         * mdebugread.c (parse_partial_symbols)
5825         (handle_psymbol_enumerators): Update.
5826         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5827         * dbxread.c (read_dbx_symtab): Update.
5828         * psympriv.h (psymbol_placement): New enum.
5829         (add_psymbol_to_list): Update.
5830
5831 2019-01-10  Tom Tromey  <tom@tromey.com>
5832
5833         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5834         static_psymbols parameters.
5835         (scan_xcoff_symtab): Update.
5836         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5837         static_psymbols parameters.
5838         * psympriv.h (start_psymtab_common): Update.
5839         * mdebugread.c (parse_partial_symbols): Update.
5840         * dwarf2read.c (create_partial_symtab): Update.
5841         * dbxread.c (read_dbx_symtab): Update.
5842         (start_psymtab): Remove global_psymbols and static_psymbols
5843         parameters.
5844
5845 2019-01-10  Tom Tromey  <tom@tromey.com>
5846
5847         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5848         * psymtab.c (allocate_psymtab): Add comment.
5849         * psympriv.h (allocate_psymtab): Add comment.
5850         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5851         initializations.
5852         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5853
5854 2019-01-10  Tom Tromey  <tom@tromey.com>
5855
5856         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5857         Don't declare.
5858         * mipsread.c: Include mdebugread.h.
5859         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5860         Declare.
5861         * elfread.c: Include mdebugread.h.
5862
5863 2019-01-09  Tom Tromey  <tom@tromey.com>
5864
5865         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5866         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5867         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5868         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5869         (psym_lookup_symbol, psym_find_last_source_symtab)
5870         (psym_forget_cached_source_info, psym_print_stats)
5871         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5872         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5873         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5874         (psym_find_compunit_symtab_by_address)
5875         (maintenance_print_psymbols, maintenance_info_psymtabs)
5876         (maintenance_check_psymtabs): Use ranged for.
5877         * psymtab.h (class objfile_psymtabs): New.
5878         (require_partial_symbols): Return objfile_psymtabs.
5879         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5880
5881 2019-01-09  Tom Tromey  <tom@tromey.com>
5882
5883         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5884         (find_pc_mapped_section, list_overlays_command)
5885         (map_overlay_command, unmap_overlay_command)
5886         (simple_overlay_update): Use all_objfiles.
5887         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5888         * printcmd.c (info_symbol_command): Use all_objfiles.
5889         * objfiles.h (ALL_OBJSECTIONS): Remove.
5890         * maint.c (maintenance_translate_address): Use all_objfiles.
5891         * gcore.c (gcore_create_callback): Use all_objfiles.
5892         (objfile_find_memory_regions): Likewise.
5893
5894 2019-01-09  Tom Tromey  <tom@tromey.com>
5895
5896         * symtab.c (find_line_symtab, info_sources_command)
5897         (make_source_files_completion_list): Use objfile_compunits.
5898         * source.c (select_source_symtab): Use objfile_compunits.
5899         * objfiles.h (struct objfile): Update comment.
5900         (ALL_OBJFILES): Remove.
5901         (ALL_FILETABS): Remove.
5902         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5903         objfile_compunits.
5904
5905 2019-01-09  Tom Tromey  <tom@tromey.com>
5906
5907         * symmisc.c (print_objfile_statistics, dump_objfile)
5908         (maintenance_print_symbols): Use compunit_filetabs.
5909         * source.c (forget_cached_source_info_for_objfile): Use
5910         compunit_filetabs.
5911         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5912         (ALL_FILETABS): Use compunit_filetabs.
5913         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5914         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5915
5916 2019-01-09  Tom Tromey  <tom@tromey.com>
5917
5918         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5919         (compunit_filetabs): New.
5920         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5921         compunit_filetabs.
5922         (info_sources_command, make_source_files_completion_list): Remove
5923         declaration.
5924         * symmisc.c (print_objfile_statistics, dump_objfile)
5925         (maintenance_print_symbols): Remove declaration.
5926         (maintenance_info_symtabs): Use compunit_filetabs.
5927         (maintenance_info_line_tables): Likewise.
5928         * source.c (select_source_symtab): Change local variable name.
5929         (forget_cached_source_info_for_objfile): Remove declaration.
5930         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5931         * objfiles.c (objfile_relocate1): Remove declaration.
5932         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5933         declaration.
5934         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5935         * coffread.c (coff_symtab_read): Remove declaration.
5936         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5937         compunit_filetabs.
5938
5939 2019-01-09  Tom Tromey  <tom@tromey.com>
5940
5941         * symtab.c (lookup_objfile_from_block)
5942         (find_pc_sect_compunit_symtab, search_symbols)
5943         (default_collect_symbol_completion_matches_break_on): Use
5944         objfile_compunits.
5945         * objfiles.h (ALL_COMPUNITS): Remove.
5946         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5947         * cp-support.c (add_symbol_overload_list_qualified): Use
5948         objfile_compunits.
5949         * ada-lang.c (ada_collect_symbol_completion_matches)
5950         (ada_add_global_exceptions): Use objfile_compunits.
5951
5952 2019-01-09  Tom Tromey  <tom@tromey.com>
5953
5954         * source.c (select_source_symtab)
5955         (forget_cached_source_info_for_objfile): Remove declaration.
5956         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5957         declaration.
5958         * maint.c (count_symtabs_and_blocks): Remove declaration.
5959         * cp-support.c (add_symbol_overload_list_qualified): Remove
5960         declaration.
5961         * coffread.c (coff_symtab_read): Remove declaration.
5962         * symtab.c (lookup_symbol_in_objfile_symtabs)
5963         (basic_lookup_transparent_type_1): Use objfile_compunits.
5964         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5965         (info_sources_command, search_symbols)
5966         (default_collect_symbol_completion_matches_break_on)
5967         (make_source_files_completion_list): Remove declaration.
5968         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5969         (ada_collect_symbol_completion_matches)
5970         (ada_add_global_exceptions): Remove declaration.
5971         * linespec.c (iterate_over_all_matching_symtabs): Use
5972         objfile_compunits.
5973         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5974         (class objfile_compunits): New.
5975         (ALL_COMPUNITS): Use objfile_compunits.
5976         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5977         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5978         objfile_compunits.
5979         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5980
5981 2019-01-09  Tom Tromey  <tom@tromey.com>
5982
5983         * symtab.c (search_symbols)
5984         (default_collect_symbol_completion_matches_break_on): Use
5985         objfile_msymbols.
5986         * ada-lang.c (ada_lookup_simple_minsym)
5987         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5988         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5989         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5990         objfile_msymbols.
5991         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5992         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5993         * objc-lang.c (find_methods): Use objfile_msymbols.
5994         (info_selectors_command, info_classes_command): Likewise.
5995         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5996         * objfiles.h (class objfile_msymbols): New.
5997         (ALL_OBJFILE_MSYMBOLS): Remove.
5998         (ALL_MSYMBOLS): Remove.
5999
6000 2019-01-09  Tom Tromey  <tom@tromey.com>
6001
6002         * common/next-iterator.h (next_adapter): Add Iterator template
6003         parameter.
6004         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6005         (class all_objfiles_safe): New.
6006         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6007         * objfiles.c (put_objfile_before): Update comment.
6008         (add_separate_debug_objfile): Likewise.
6009         (free_all_objfiles): Use all_objfiles_safe.
6010         (objfile_purge_solibs): Likewise.
6011
6012 2019-01-09  Tom Tromey  <tom@tromey.com>
6013
6014         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6015         (expand_symtab_containing_pc, lookup_static_symbol)
6016         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6017         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6018         all_objfiles.
6019         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6020         * breakpoint.c (create_overlay_event_breakpoint)
6021         (create_longjmp_master_breakpoint)
6022         (create_std_terminate_master_breakpoint)
6023         (create_exception_master_breakpoint): Use all_objfiles.
6024         * linux-thread-db.c (try_thread_db_load_from_pdir)
6025         (has_libpthread): Use all_objfiles.
6026         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6027         * linespec.c (iterate_over_all_matching_symtabs)
6028         (search_minsyms_for_name): Use all_objfiles.
6029         * maint.c (maintenance_info_sections): Use all_objfiles.
6030         * main.c (captured_main_1): Use all_objfiles.
6031         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6032         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6033         * guile/scm-pretty-print.c
6034         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6035         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6036         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6037         (maintenance_print_msymbols): Use all_objfiles.
6038         * source.c (select_source_symtab): Use all_objfiles.
6039         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6040         * symfile.c (remove_symbol_file_command)
6041         (expand_symtabs_matching, map_symbol_filenames): Use
6042         all_objfiles.
6043         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6044         all_objfiles.
6045         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6046         * objc-lang.c (find_methods): Use all_objfiles.
6047         * objfiles.c (have_partial_symbols, have_full_symbols)
6048         (have_minimal_symbols, qsort_cmp)
6049         (default_iterate_over_objfiles_in_search_order): Use
6050         all_objfiles.
6051         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6052         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6053         (maintenance_check_psymtabs): Use all_objfiles.
6054         (ALL_PSYMTABS): Remove.
6055         * compile/compile-object-run.c (do_module_cleanup): Use
6056         all_objfiles.
6057         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6058         * cp-support.c (add_symbol_overload_list_qualified): Use
6059         all_objfiles.
6060         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6061         Use all_objfiles.
6062         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6063         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6064         all_objfiles.
6065         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6066         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6067         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6068         Uses all_objfiles.
6069         * solib.c (solib_read_symbols): Use all_objfiles
6070
6071 2019-01-09  Tom Tromey  <tom@tromey.com>
6072
6073         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6074         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6075         all_objfiles.
6076         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6077         * symmisc.c (print_symbol_bcache_statistics)
6078         (print_objfile_statistics, maintenance_print_objfiles)
6079         (maintenance_info_symtabs, maintenance_check_symtabs)
6080         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6081         all_objfiles.
6082         * source.c (forget_cached_source_info): Use all_objfiles.
6083         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6084         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6085         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6086         * objfiles.c (update_section_map): Use all_objfiles.
6087         (shared_objfile_contains_address_p): Likewise.
6088         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6089         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6090
6091 2019-01-09  Tom Tromey  <tom@tromey.com>
6092
6093         * common/next-iterator.h: New file.
6094         * objfiles.h (class all_objfiles): New.
6095         (struct objfile_iterator): New.
6096
6097 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6098
6099         * NEWS: Move the description of the changed "frame", "select-frame",
6100          and "info frame" commands to the Changed commands section.
6101
6102 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6103
6104         * gdbtypes.c (check_stub_method_group): Remove handling of old
6105         mangling schemes.
6106         * linespec.c (find_methods): Likewise.
6107         * stabsread.c (read_member_functions): Likewise.
6108         * valops.c (search_struct_method): Likewise.
6109         (value_struct_elt_for_reference): Likewise.
6110         * NEWS: Mention this change.
6111
6112 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6113
6114         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6115         print_source_lines.
6116         * source.c (print_source_lines_base): Update line number check.
6117         (print_source_lines): New function.
6118         (source_lines_range::source_lines_range): New function.
6119         * source.h (class source_lines_range): New class.
6120         (print_source_lines): New declaration.
6121
6122 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6123
6124         * linespec.c (linespec_state_destructor): Free self->canonical_names.
6125
6126 2019-01-08  Tom Tromey  <tom@tromey.com>
6127             Simon Marchi  <simon.marchi@ericsson.com>
6128
6129         PR gdb/24060
6130         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
6131         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
6132         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6133         * f-exp.y (DOLLAR_VARIABLE): Likewise.
6134         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
6135         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
6136
6137 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6138
6139         * source.c (select_source_symtab): Move header comment to
6140         declaration in source.h.
6141         (forget_cached_source_info_for_objfile): Likewise.
6142         (forget_cached_source_info): Likewise.
6143         (identify_source_line): Likewise.
6144         * source.h (identify_source_line): Move declaration from symtab.h
6145         and add comment from source.c
6146         (print_source_lines): Likewise.
6147         (forget_cached_source_info_for_objfile): Likewise.
6148         (forget_cached_source_info): Likewise.
6149         (select_source_symtab): Likewise.
6150         (enum print_source_lines_flag): Move definition from symtab.h.
6151         * symtab.h (identify_source_line): Move declaration to source.h.
6152         (print_source_lines): Likewise.
6153         (forget_cached_source_info_for_objfile): Likewise.
6154         (forget_cached_source_info): Likewise.
6155         (select_source_symtab): Likewise.
6156         (enum print_source_lines_flag): Move definition to source.h.
6157         * tui/tui-hooks.c: Add 'source.h' include.
6158
6159 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6160
6161         * source.c (print_source_lines_base): Handle requests to print
6162         reverse line number sequences, and guard against empty lines
6163         string.
6164
6165 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6166
6167         * source.c (print_source_lines_base): Fix skip of '\r' if next
6168         character is '\n'.
6169
6170 2019-01-06  Tom Tromey  <tom@tromey.com>
6171
6172         * c-exp.y (struct c_parse_state) <macro_original_text,
6173         expansion_obstack>: New member.
6174         (macro_original_text, expansion_obstack): Remove globals.
6175         (scan_macro_expansion, scanning_macro_expansion)
6176         (finished_macro_expansion): Update.
6177         (scan_macro_cleanup): Remove.
6178         (yylex, c_parse): Update.
6179
6180 2019-01-06  Tom Tromey  <tom@tromey.com>
6181
6182         * c-exp.y (struct c_parse_state) <strings>: New member.
6183         (operator_stoken): Update.
6184
6185 2019-01-06  Tom Tromey  <tom@tromey.com>
6186
6187         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
6188         (union type_stack_elt) <typelist_val>: Now a pointer to
6189         std::vector.
6190         (type_stack_cleanup): Don't declare.
6191         (push_typelist): Update.
6192         * parse.c (pop_typelist): Return a std::vector.
6193         (push_typelist): Take a std::vector.
6194         (follow_types): Update.  Do not free args.
6195         (type_stack_cleanup): Remove.
6196         * c-exp.y (struct c_parse_state): New.
6197         (cpstate): New global.
6198         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
6199         (nonempty_typelist): Update.
6200         (func_mod): Create a new vector.
6201         (c_parse): Create a c_parse_state.
6202         (check_parameter_typelist): Do not delete params.
6203         (function_method): Update.  Do not delete type_list.
6204
6205 2019-01-06  Tom Tromey  <tom@tromey.com>
6206
6207         PR gdb/28155:
6208         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
6209         check_typedef.
6210         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
6211         (print_return_value): Likewise.
6212
6213 2019-01-05  Tom Tromey  <tom@tromey.com>
6214
6215         * contrib/cleanup_check.py: Remove.
6216         * contrib/gcc-with-excheck: Remove.
6217         * contrib/exsummary.py: Remove.
6218         * contrib/excheck.py: Remove.
6219
6220 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
6221
6222         * thread.c (delete_thread_1): Add gdb_assert that THR is not
6223         NULL. Initialize tpprev to NULL instead of assigning it
6224         to NULL on the next statement.
6225         * windows-nat.c (windows_delete_thread): Remove check for
6226         main_thread_id before printing thread exit notifications.
6227         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
6228         Remove thread ID check against main_thread_id.
6229         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
6230         windows_delete_thread.
6231         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
6232
6233 2019-01-04  Tom Tromey  <tom@tromey.com>
6234
6235         * compile/compile.c (_initialize_compile): Use upper case for
6236         metasyntactic variables.
6237         * symmisc.c (_initialize_symmisc): Use upper case for
6238         metasyntactic variables.
6239         * psymtab.c (_initialize_psymtab): Use upper case for
6240         metasyntactic variables.
6241         * demangle.c (demangle_command): Use upper case for metasyntactic
6242         variables.
6243         (_initialize_demangler): Likewise.
6244         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
6245         variables.
6246
6247 2019-01-03  Tom Tromey  <tom@tromey.com>
6248
6249         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
6250
6251 2019-01-03  Tom Tromey  <tom@tromey.com>
6252
6253         * python/py-symtab.c (salpy_str): Update.
6254         (struct salpy_sal_object) <symtab>: Now a PyObject.
6255         (salpy_dealloc): Update.
6256         (del_objfile_sal): Use gdbpy_ref.
6257
6258 2019-01-03  Tom Tromey  <tom@tromey.com>
6259
6260         * python/py-type.c (convert_field): Use new_reference.  Return
6261         gdbpy_ref.
6262         (make_fielditem): Return gdbpy_ref.
6263         (typy_fields): Update.
6264         (typy_getitem): Update.
6265         (field_name): Return gdbpy_ref.  Use new_reference.
6266         (typy_iterator_iternext): Update.
6267
6268 2019-01-03  Tom Tromey  <tom@tromey.com>
6269
6270         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
6271
6272 2019-01-03  Tom Tromey  <tom@tromey.com>
6273
6274         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6275         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6276         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6277         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6278         (pspy_set_type_printers): Likewise.
6279         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6280         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6281         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6282         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6283         (objfpy_set_type_printers): Likewise.
6284
6285 2019-01-03  Tom Tromey  <tom@tromey.com>
6286
6287         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6288         (gdbpy_print_stack): Use gdbpy_err_fetch.
6289         * python/python-internal.h (class gdbpy_err_fetch): New class.
6290         (class gdbpy_enter) <m_error_type, m_error_value,
6291         m_error_traceback>: Remove.
6292         <m_error>: New member.
6293         (gdbpy_exception_to_string): Don't declare.
6294         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6295         * python/py-value.c (convert_value_from_python): Use
6296         gdbpy_err_fetch.
6297         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6298         gdbpy_exception_to_string.
6299         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6300         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6301         gdbpy_err_fetch.
6302
6303 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6304
6305         * linux-nat.c (delete_lwp_cleanup): Delete.
6306         (struct lwp_deleter): New struct.
6307         (lwp_info_up): New typedef.
6308         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6309         lwp_info_up.
6310
6311 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6312
6313         * linux-fork.c (class scoped_switch_fork_info): New class.
6314         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6315
6316 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6317
6318         * valops.c (find_overload_match): Remove use of null_cleanup, and
6319         calls to do_cleanups.
6320
6321 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6322
6323         * compile/compile-cplus-types.c
6324         (compile_cplus_instance::decl_name): Handle changes to
6325         cp_func_name.
6326         * cp-support.c (cp_func_name): Update header comment, update
6327         return type.
6328         * cp-support.h (cp_func_name): Update return type in declaration.
6329         * valops.c (find_overload_match): Move temp_func local to top
6330         level of function and change its type.  Use temp_func to hold and
6331         delete temporary string obtained from cp_func_name.
6332
6333 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6334
6335         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6336         gdb::char_vector, remove cleanup, and update uses of `msg`.
6337
6338 2019-01-03  Jim Wilson  <jimw@sifive.com>
6339
6340         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6341
6342 2019-01-02  Tom Tromey  <tom@tromey.com>
6343
6344         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6345         (tdesc_parse_xml): Remove cleanups.
6346         * target-descriptions.h (make_cleanup_free_target_description):
6347         Don't declare.
6348         (target_desc_deleter): New struct.
6349         (target_desc_up): New typedef.
6350         * target-descriptions.c (target_desc_deleter::operator()): Rename
6351         from free_target_description.
6352         (make_cleanup_free_target_description): Remove.
6353
6354 2019-01-02  Tom Tromey  <tom@tromey.com>
6355
6356         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6357         constructor, destructor.
6358         (linespec_parser): Remove typedef.
6359         (~linespec_parser): Rename from linespec_parser_delete.
6360         (linespec_lex_to_end, linespec_complete_label)
6361         (linespec_complete): Update.
6362         (decode_line_full): Remove cleanups.
6363         (decode_line_1): Update.
6364
6365 2019-01-02  Tom Tromey  <tom@tromey.com>
6366
6367         * python/python-internal.h (inferior_to_inferior_object): Change
6368         return type.
6369         * python/py-exitedevent.c (create_exited_event_object): Update.
6370         * python/py-inferior.c (inferior_to_inferior_object): Return
6371         gdbpy_ref.
6372         (python_new_inferior, python_inferior_deleted)
6373         (thread_to_thread_object, delete_thread_object)
6374         (build_inferior_list, gdbpy_selected_inferior): Update.
6375         * python/py-infthread.c (create_thread_object): Update.  Also fail
6376         if inferior_to_inferior_object fails.
6377
6378 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6379
6380         * inferior.h (class inferior) <displaced_step_state>: New field.
6381         * infrun.h (struct displaced_step_state): Move here from
6382         infrun.c.  Initialize fields, add constructor.
6383         <inf>: Remove field.
6384         <reset>: New method.
6385         * infrun.c (struct displaced_step_inferior_state): Move to
6386         infrun.h.
6387         (displaced_step_inferior_states): Remove.
6388         (get_displaced_stepping_state): Adust.
6389         (displaced_step_in_progress_any_inferior): Adjust.
6390         (displaced_step_in_progress_thread): Adjust.
6391         (displaced_step_in_progress): Adjust.
6392         (add_displaced_stepping_state): Remove.
6393         (get_displaced_step_closure_by_addr): Adjust.
6394         (remove_displaced_stepping_state): Remove.
6395         (infrun_inferior_exit): Call displaced_step_state.reset.
6396         (use_displaced_stepping): Don't check for NULL.
6397         (displaced_step_prepare_throw): Call
6398         get_displaced_stepping_state.
6399         (displaced_step_fixup): Don't check for NULL.
6400         (prepare_for_detach): Don't check for NULL.
6401
6402 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6403
6404         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6405          in case of call that did not complete.
6406
6407 2019-01-02  Andrey Utkin  <autkin@undo.io>
6408
6409         * symfile.c (find_separate_debug_file): Fix search of debug files for
6410         remote debuggee.
6411
6412 2019-01-02  Tom Tromey  <tom@tromey.com>
6413
6414         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6415         indentation.
6416         * python/py-frame.c (frapy_older): Remove cast.
6417         (frapy_newer): Likewise.
6418         * python/py-breakpoint.c (local_setattro): Remove cast.
6419         * python/py-arch.c (archpy_name): Remove local variable.
6420         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6421
6422 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6423
6424         * unittests/basic_string_view/element_access/char/empty.cc:
6425         Fix year range in copyright header.
6426
6427 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6428
6429         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6430         Delete.
6431         <operator==>: Update with for removed field.
6432         <hash>: Likewise.
6433         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6434         <isa_features>: ...this.
6435         <abi_features>: New field.
6436         (riscv_isa_flen): Update comment.
6437         (riscv_abi_xlen): New declaration.
6438         (riscv_abi_flen): New declaration.
6439         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6440         isa_features.
6441         (riscv_abi_xlen): New function.
6442         (riscv_isa_flen): Update to get answer from isa_features.
6443         (riscv_abi_flen): New function.
6444         (riscv_has_fp_abi): Update to get answer from abi_features.
6445         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6446         xlen and flen.
6447         (riscv_call_info) <xlen, flen>: Update comment.
6448         (riscv_call_arg_struct): Remove invalid assertions
6449         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6450         is removed.
6451         (riscv_gdbarch_init): Gather isa features and abi features
6452         separately, ensure both match on the gdbarch when reusing an old
6453         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6454         a target with 64-bit float hardware.
6455
6456 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6457
6458         * source.c (search_command_helper): Stop reverse search
6459         when line 1 has been searched.
6460
6461 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6462
6463         * record-full.c (record_full_base_target::close): Rewrite
6464         record_full_core_buf_list free logic.
6465
6466 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6467
6468         * break-catch-syscall.c (print_one_catch_syscall): xfree
6469         the last text.
6470
6471 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6472
6473         * top.c (print_gdb_version): Update Copyright year in version
6474         message.
6475
6476 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6477
6478         Update copyright year range in all GDB files.
6479
6480 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6481
6482         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6483
6484 For older changes see ChangeLog-2018.
6485 \f
6486 Local Variables:
6487 mode: change-log
6488 left-margin: 8
6489 fill-column: 74
6490 version-control: never
6491 coding: utf-8
6492 End:
6493