gdb/ChangeLog

   1 2019-12-01  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
   4         \0.
   5         * unittests/tui-selftests.c: New file.
   6         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
   7
   8 2019-12-01  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
  11
  12 2019-12-01  Tom Tromey  <tom@tromey.com>
  13
  14         * NEWS: Document new settings.
  15         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
  16         * tui/tui-win.c (_initialize_tui_win): Add border style
  17         observers.
  18         * tui/tui-io.h (tui_apply_style): Declare.
  19         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
  20         longer static.
  21         (apply_ansi_escape, tui_set_reverse_mode): Update.
  22         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
  23         Add "skip_intensity" parameter.
  24         <changed>: New member.
  25         <do_set_value>: Declare.
  26         (tui_border_style, tui_active_border_style): Declare.
  27         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
  28         globals.
  29         (cli_style_option): Initialize "changed".
  30         (cli_style_option::do_set_value): New function.
  31         (cli_style_option::add_setshow_commands): Add "skip_intensity"
  32         parameter.  Update.
  33         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
  34         (_initialize_cli_style): Update.  Create TUI border style
  35         commands.
  36
  37 2019-12-01  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
  40         parameter.
  41         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
  42         parameter.
  43         * tui/tui-win.h (compact_source): Declare.
  44         * tui/tui-win.c (compact_source): New global.
  45         (tui_set_compact_source, tui_show_compact_source): New functions.
  46         (_initialize_tui_win): Add "compact-source" setting.
  47         * tui/tui-source.c (tui_source_window::set_contents): Handle
  48         compact_source setting.
  49         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
  50         * NEWS: Document new setting.
  51
  52 2019-11-30  Tom Tromey  <tom@tromey.com>
  53
  54         * dwarf2read.c (dwarf2_add_field): Include field offset when
  55         computing variant part length.
  56
  57 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  58         * NEWS:  Mention define-prefix.  Tell that command names can now
  59         contain a . character.
  60
  61 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  62
  63         * command.h (valid_cmd_char_p): Declare.
  64         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
  65         the check of valid command char.
  66         (find_command_name_length, valid_user_defined_cmd_name_p): Use
  67         valid_cmd_char_p.
  68         * cli/cli-script.c (validate_comname): Likewise.
  69         * completer.c (gdb_completer_command_word_break_characters):
  70         Do not remove . from the word break char, update comments.
  71         (complete_line_internal_1): Use valid_cmd_char_p.
  72         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
  73         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
  74
  75 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  76
  77         * cli/cli-script.c (do_define_command): Ensure a redefined
  78         prefix command is kept as a prefix command.
  79         (define_prefix_command): New function.
  80         (show_user_1): Report user defined prefixes.
  81         (_initialize_cli_script):  Create the new 'define-prefix' command.
  82         Add completers for 'define' and 'document'.
  83         * top.c (execute_command):  If command is a user-defined prefix only
  84         command, report the list of commands for this prefix command.
  85
  86 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  87
  88         * valops.c (find_oload_champ): Improve debug output.
  89
  90 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  91
  92         * valops.c (find_oload_champ): Print part of debug messages
  93         before the badness vector is std::move'd.
  94
  95 2019-11-28  Tom Tromey  <tom@tromey.com>
  96
  97         * value.c (creal_internal_fn): Fix comment.
  98
  99 2019-11-28  Tom Tromey  <tom@tromey.com>
 100
 101         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
 102         flag_bound_evaluated>: Now unsigned.
 103
 104 2019-11-28  Tom Tromey  <tom@tromey.com>
 105
 106         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
 107         declare.
 108
 109 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
 110
 111         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
 112         debug output.
 113         * jit.c (jit_unregister_code): Add debug print to match
 114         `jit_register_code`.
 115
 116 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 117
 118         * NEWS: Mention the new multithreaded symbol loading.
 119
 120 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 121
 122         * maint.c (n_worker_threads): Default to 0.
 123         (worker_threads_disabled): New function.
 124         * maint.h (worker_threads_disabled): New function.
 125         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
 126         here if worker_threads_disabled () is true.
 127         (minimal_symbol_reader::install): Skip all threading if
 128         worker_threads_disabled () is true.
 129
 130 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 131
 132         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
 133         hash code if possible.
 134         (add_minsym_to_demangled_hash_table): Likewise.
 135         (minimal_symbol_reader::install): Compute the hash codes for msymbol
 136         on the background thread.
 137         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
 138         Add these fields.
 139
 140 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 141
 142         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
 143         of the mangled name on the background thread.
 144         * symtab.c (symbol_set_names): Allow passing in the hash of the
 145         linkage_name.
 146         * symtab.h (symbol_set_names): Likewise.
 147
 148 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
 149
 150         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
 151         physnames are computed for inherited DIEs.
 152
 153 2019-11-27  Tom Tromey  <tromey@adacore.com>
 154
 155         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
 156         backslashes.
 157         * cp-support.c: Remove unnecessary backslashes.
 158
 159 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
 160
 161         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
 162         with sym->set_linkage_name.
 163         * coffread.c (coff_read_enum_type): Likewise.
 164         * mdebugread.c (parse_symbol): Likewise.
 165         * stabsread.c (patch_block_stabs): Likewise.
 166         (define_symbol): Likewise.
 167         (read_enum_type): Likewise.
 168         (common_block_end): Likewise.
 169         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
 170         function.
 171         (SYMBOL_SET_LINKAGE_NAME): Remove.
 172         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
 173         with sym->set_linkage_name.
 174
 175 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 176
 177         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
 178         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
 179         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
 180         * NEWS: Mention new MI command.
 181
 182 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 183
 184         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
 185         '-symbol-info-types', and '-symbol-info-variables'.
 186         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
 187         (mi_cmd_symbol_info_types): Declare.
 188         (mi_cmd_symbol_info_variables): Declare.
 189         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
 190         (output_debug_symbol): New function.
 191         (output_nondebug_symbol): New function.
 192         (mi_symbol_info): New function.
 193         (mi_info_functions_or_variables): New function.
 194         (mi_cmd_symbol_info_functions): New function.
 195         (mi_cmd_symbol_info_types): New function.
 196         (mi_cmd_symbol_info_variables): New function.
 197         * NEWS: Mention new commands.
 198
 199 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 200
 201         * symtab.c (symbol_to_info_string): New function, most content
 202         moved from print_symbol_info, but updated to return a std::string.
 203         (print_symbol_info): Update to use symbol_to_info_string and print
 204         returned string.
 205         * symtab.h (symbol_to_info_string): Declare new function.
 206
 207 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 208
 209         * python/python.c (gdbpy_rbreak): Convert to using
 210         global_symbol_searcher.
 211         * symtab.c (file_matches): Convert return type to bool, change
 212         file list to std::vector, update header comment.
 213         (search_symbols): Rename to...
 214         (global_symbol_searcher::search): ...this and update now its
 215         a member function of global_symbol_searcher.  Take account of the
 216         changes to file_matches.
 217         (symtab_symbol_info): Convert to using global_symbol_searcher.
 218         (rbreak_command): Likewise.
 219         (search_module_symbols): Likewise.
 220         * symtab.h (enum symbol_search): Update comment.
 221         (search_symbols): Remove declaration.
 222         (class global_symbol_searcher): New class.
 223
 224 2019-11-26  Tom Tromey  <tromey@adacore.com>
 225
 226         * cp-support.c (_initialize_cp_support): Conditionally initialize
 227         gdb_demangle_attempt_core_dump.
 228
 229 2019-11-26  Tom Tromey  <tom@tromey.com>
 230
 231         * python/py-function.c (fnpy_init): Update.
 232         * value.h (add_internal_function): Adjust declaration.
 233         * value.c (function_destroyer): Remove.
 234         (do_add_internal_function): Don't set destroyer or copy name.
 235         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
 236         Set name_allocated.
 237         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
 238         (cmdpy_init): Set name_allocated.
 239         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
 240         member.
 241         (~cmd_list_element): Free "name" if needed.
 242
 243 2019-11-26  Tom Tromey  <tom@tromey.com>
 244
 245         * value.h (add_internal_function): Add new overload.  Move
 246         documentation from value.h.
 247         * value.c (do_add_internal_function): New function.
 248         (add_internal_function): Use it.  Add new overload.
 249         (function_destroyer): Don't free doc.
 250         * python/py-function.c (fnpy_init): Update.
 251
 252 2019-11-26  Tom Tromey  <tom@tromey.com>
 253
 254         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
 255         (cmdpy_init): Set "doc_allocated".
 256
 257 2019-11-26  Tom Tromey  <tom@tromey.com>
 258
 259         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
 260         name of worker thread.
 261         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 262         pthread_setname_np.
 263         * configure, config.in: Rebuild.
 264
 265 2019-11-26  Tom Tromey  <tom@tromey.com>
 266
 267         * python/python.c (class gdbpy_gil): New.
 268         (struct gdbpy_event): Add constructor, destructor, operator().
 269         (gdbpy_post_event): Use run_on_main_thread.
 270         (gdbpy_initialize_events): Remove.
 271         (do_start_initialization): Update.
 272
 273 2019-11-26  Tom Tromey  <tom@tromey.com>
 274
 275         * NEWS: Add entry.
 276         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
 277         commands.  Call update_thread_pool_size.
 278         (update_thread_pool_size, maintenance_set_worker_threads): New
 279         functions.
 280         (n_worker_threads): New global.
 281
 282 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 283             Tom Tromey  <tom@tromey.com>
 284
 285         * minsyms.c (minimal_symbol_reader::install): Use
 286         parallel_for_each.
 287         * gdbsupport/parallel-for.h: New file.
 288         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
 289
 290 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 291             Tom Tromey  <tom@tromey.com>
 292
 293         * gdbsupport/thread-pool.h: New file.
 294         * gdbsupport/thread-pool.c: New file.
 295         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
 296         (HFILES_NO_SRCDIR): Add thread-pool.h.
 297
 298 2019-11-26  Tom Tromey  <tom@tromey.com>
 299
 300         * event-top.h (thread_local_segv_handler): Declare.
 301         * event-top.c (thread_local_segv_handler): New global.
 302         (install_handle_sigsegv, handle_sigsegv): New functions.
 303         (async_init_signals): Install SIGSEGV handler.
 304         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
 305         thread-local.
 306         (report_failed_demangle): New function.
 307         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
 308         handler-setting code, instead use segv_handler.  Run warning code
 309         on main thread.
 310
 311 2019-11-26  Tom Tromey  <tom@tromey.com>
 312
 313         * run-on-main-thread.c: New file.
 314         * run-on-main-thread.h: New file.
 315         * unittests/main-thread-selftests.c: New file.
 316         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 317         main-thread-selftests.c.
 318         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
 319         (COMMON_SFILES): Add run-on-main-thread.c.
 320
 321 2019-11-26  Tom Tromey  <tom@tromey.com>
 322
 323         * main.c (setup_alternate_signal_stack): Remove.
 324         (captured_main_1): Use gdb::alternate_signal_stack.
 325         * gdbsupport/alt-stack.h: New file.
 326
 327 2019-11-26  Tom Tromey  <tom@tromey.com>
 328
 329         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
 330         Remove comment.
 331         (save_original_signals_state, restore_original_signals_state): Use
 332         gdb_sigmask.
 333         * linux-nat.c (block_child_signals, restore_child_signals_mask)
 334         (_initialize_linux_nat): Use gdb_sigmask.
 335         * guile/guile.c (_initialize_guile): Use block_signals.
 336         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
 337         * gdbsupport/gdb-sigmask.h: New file.
 338         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
 339         * cp-support.c (gdb_demangle): Use gdb_sigmask.
 340         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
 341         pthread_sigmask.
 342         * configure, config.in: Rebuild.
 343         * gdbsupport/block-signals.h: New file.
 344
 345 2019-11-26  Tom Tromey  <tom@tromey.com>
 346
 347         * acinclude.m4: Include ax_pthread.m4.
 348         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
 349         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
 350         (CLIBS): Use PTHREAD_LIBS.
 351         (aclocal_m4_deps): Add ax_pthread.m4.
 352         * config.in, configure: Rebuild.
 353         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
 354
 355 2019-11-26  Tom Tromey  <tom@tromey.com>
 356
 357         * symtab.h (struct minimal_symbol) <name_set>: New member.
 358         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
 359         Don't call symbol_set_names.
 360         (minimal_symbol_reader::install): Call symbol_set_names.
 361
 362 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 363
 364         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
 365         restore_active_ext_lang, as GIL is needed for (indirectly)
 366         called PyOS_InterruptOccurred.
 367
 368 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 369
 370         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
 371         definition.
 372
 373 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 374
 375         * remote-sim.c (simulator_command): Make static, remove
 376         declaration.
 377
 378 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 379
 380         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
 381         static.
 382         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
 383         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
 384         (main): Likewise.
 385         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
 386         (main): Likewise.
 387         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
 388         (main): Likewise.
 389         * unittests/basic_string_view/element_access/char/1.cc (test01):
 390         Likewise.
 391         (main): Likewise.
 392         * unittests/basic_string_view/element_access/char/empty.cc (main):
 393         Likewise.
 394         * unittests/basic_string_view/element_access/char/front_back.cc
 395         (test01): Likewise.
 396         (main): Likewise.
 397         * unittests/basic_string_view/inserters/char/2.cc (test05):
 398         Likewise.
 399         (main): Likewise.
 400         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
 401         (test01): Likewise.
 402         (main): Likewise.
 403         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
 404         (test01): Likewise.
 405         (main): Likewise.
 406         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
 407         Likewise.
 408         * unittests/basic_string_view/operations/compare/char/1.cc
 409         (test01): Likewise.
 410         (main): Likewise.
 411         * unittests/basic_string_view/operations/compare/char/13650.cc
 412         (test01): Likewise.
 413         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
 414         Likewise.
 415         (main): Likewise.
 416         * unittests/basic_string_view/operations/data/char/1.cc (test01):
 417         Likewise.
 418         (main): Likewise.
 419         * unittests/basic_string_view/operations/find/char/1.cc (test01):
 420         Likewise.
 421         (main): Likewise.
 422         * unittests/basic_string_view/operations/find/char/2.cc (test02):
 423         Likewise.
 424         (main): Likewise.
 425         * unittests/basic_string_view/operations/find/char/3.cc (test03):
 426         Likewise.
 427         (main): Likewise.
 428         * unittests/basic_string_view/operations/find/char/4.cc (main):
 429         Likewise.
 430         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
 431         Likewise.
 432         (main): Likewise.
 433         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
 434         Likewise.
 435         (main): Likewise.
 436         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
 437         Likewise.
 438         (main): Likewise.
 439         * unittests/basic_string_view/operations/substr/char/1.cc
 440         (test01): Likewise.
 441         (main): Likewise.
 442         * unittests/basic_string_view/operators/char/2.cc (main):
 443         Likewise.
 444         * unittests/optional/assignment/1.cc (test): Likewise.
 445         * unittests/optional/assignment/2.cc (test): Likewise.
 446         * unittests/optional/assignment/3.cc (test): Likewise.
 447         * unittests/optional/assignment/4.cc (test): Likewise.
 448         * unittests/optional/assignment/5.cc (test): Likewise.
 449         * unittests/optional/assignment/6.cc (test): Likewise.
 450         * unittests/optional/assignment/7.cc (test): Likewise.
 451         * unittests/optional/cons/copy.cc (test): Likewise.
 452         * unittests/optional/cons/default.cc (test): Likewise.
 453         * unittests/optional/cons/move.cc (test): Likewise.
 454         * unittests/optional/cons/value.cc (test): Likewise.
 455         * unittests/optional/in_place.cc (test): Likewise.
 456         * unittests/optional/observers/1.cc (test): Likewise.
 457         * unittests/optional/observers/2.cc (test): Likewise.
 458
 459 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 460
 461         * tui-win.h (tui_set_var_cmd): Remove.
 462         * tui-win.c (tui_set_var_cmd): Make static.
 463
 464 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 465
 466         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
 467         rbreak_command_wrapper): Remove.
 468         * symtab.c (rbreak_command_wrapper): Remove.
 469
 470 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 471
 472         * inferior.h (info_terminal_command): Remove declaration.
 473         * inflow.c (info_terminal_command): Make static.
 474
 475 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 476
 477         * inferior.c (exit_inferior_silent): Remove.
 478
 479 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 480
 481         * dictionary.c (dict_empty, mdict_empty): Remove.
 482         * dictionary.c (mdict_empty): Remove.
 483
 484 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 485
 486          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
 487          (arc_insn_get_memory_offset): Likewise.
 488          (arc_insn_dump): Likewise.
 489          * cp-support.c (test_cp_symbol_name_matches): Likewise.
 490          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
 491          * dictionary.c (dict_iterator_next): Likewise.
 492          (dict_iter_match_first): Likewise.
 493          (dict_iter_match_next): Likewise.
 494          * f-lang.c (evaluate_subexp_f): Likewise.
 495          * hppa-tdep.c (hppa_read_pc): Likewise.
 496          * i386-tdep.c (i386_floatformat_for_type): Likewise.
 497          * parse.c (write_exp_elt_msym): Likewise.
 498          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
 499          * remote.c (remote_packet_size): Likewise.
 500          (remote_notif_stop_parse): Likewise.
 501          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
 502          * s12z-tdep.c (s12z_disassemble_info): Likewise.
 503          * source.c (prepare_path_for_appending): Likewise.
 504          * sparc64-linux-tdep.c
 505          (sparc64_linux_handle_segmentation_fault); Likewise.
 506          * stack.c (frame_selection_by_function_completer): Likewise.
 507
 508 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 509
 510         * completer.c (set_gdb_completion_word_break_characters):
 511         Remove.
 512
 513 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 514
 515         * dwarf-index-write.c: Include dwarf-index-write.h.
 516         * mi/mi-interp.c: Include mi/mi-interp.h.
 517
 518 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
 519
 520         * aarch32-tdep.c: Include aarch32-tdep.h.
 521         * aarch32-tdep.h: Forward-declare struct target_desc.
 522
 523 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
 524
 525         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
 526         strerror.
 527         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
 528         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
 529
 530 2019-11-25  Tom de Vries  <tdevries@suse.de>
 531
 532         * contrib/words.sh: Add -c option.
 533
 534 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
 535
 536         * solib.c (solib_find_1): Change int to bool.
 537         (exec_file_find): Change int to bool.
 538         (solib_find): Change int to bool.
 539         (solib_read_symbols): Change int to bool.
 540         (solib_used): Change int to bool.
 541         (solib_add): Change int to bool.
 542         (info_sharedlibrary_command): Change int to bool.
 543         (solib_contains_address_p): Change int to bool.
 544         (solib_keep_data_in_core): Change int to bool.
 545         (in_solib_dynsym_resolve_code): Change int to bool.
 546         (reload_shared_libraries_1): Change int to bool.
 547         (gdb_sysroot_changed): Change int to bool.
 548         * solib.h (solib_read_symbols): Change int to bool.
 549         (solib_contains_address_p): Change int to bool.
 550         (solib_keep_data_in_core): Change int to bool.
 551         (in_solib_dynsym_resolve_code): Change int to bool.
 552         (libpthread_name_p): Change int to bool.
 553
 554 2019-11-25  Luis Machado  <luis.machado@linaro.org>
 555
 556         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
 557         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
 558         (remote_packet_max_chars): New static global.
 559         (show_remote_packet_max_chars): New function.
 560         (remote_target::putpkt_binary): Adjust to use new
 561         remote_packet_max_chars option.
 562         (remote_target::getpkt_or_notif_sane_1): Likewise.
 563         (_initialize_remote): Register new remote-packet-max-chars option.
 564
 565 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
 566
 567         * m68k-linux-nat.c: Include gdbarch.h.
 568
 569 2019-11-24  Tom Tromey  <tom@tromey.com>
 570
 571         * symfile.c (read_symbols): Update.
 572         * psymtab.c (require_partial_symbols): Change type of "verbose" to
 573         bool.
 574         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 575         (psym_lookup_symbol, psym_find_last_source_symtab)
 576         (psym_forget_cached_source_info, psym_print_stats)
 577         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 578         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 579         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 580         (psym_find_compunit_symtab_by_address)
 581         (maintenance_print_psymbols, maintenance_info_psymtabs)
 582         (maintenance_check_psymtabs): Update.
 583         * psymtab.h (require_partial_symbols): Change type of "verbose" to
 584         bool.
 585
 586 2019-11-22  Tom Tromey  <tom@tromey.com>
 587
 588         * observable.h: Update comments.
 589
 590 2019-11-22  Tom Tromey  <tromey@adacore.com>
 591
 592         * ada-tasks.c (ada_task_is_alive): Make parameter const.
 593         (print_ada_task_info): Don't try to fetch thread id if task is not
 594         alive.
 595
 596 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 597
 598         * ada-exp.y: Update.
 599         * ada-lang.c (sort_choices): Update.
 600         (ada_print_symbol_signature): Update.
 601         (resolve_subexp): Update.
 602         (ada_parse_renaming): Update.
 603         (ada_read_renaming_var_value): Update.
 604         (lesseq_defined_than): Update.
 605         (remove_extra_symbols): Update.
 606         (remove_irrelevant_renamings): Update.
 607         (ada_add_block_symbols): Update.
 608         (ada_collect_symbol_completion_matches): Update.
 609         (ada_is_renaming_symbol): Update.
 610         (aggregate_assign_from_choices): Update.
 611         (ada_evaluate_subexp): Update.
 612         (ada_has_this_exception_support): Update.
 613         (ada_is_non_standard_exception_sym): Update.
 614         (ada_add_exceptions_from_frame): Update.
 615         (ada_add_global_exceptions): Update.
 616         (ada_print_subexp): Update.
 617         * ax-gdb.c (gen_var_ref): Update.
 618         (gen_maybe_namespace_elt): Update.
 619         (gen_expr_for_cast): Update.
 620         (gen_expr): Update.
 621         * block.h: Update.
 622         * blockframe.c (find_pc_partial_function): Update.
 623         * breakpoint.c (print_breakpoint_location): Update.
 624         (update_static_tracepoint): Update.
 625         * btrace.c (ftrace_print_function_name): Update.
 626         (ftrace_function_switched): Update.
 627         * buildsym.c (find_symbol_in_list): Update.
 628         * c-exp.y: Update.
 629         * c-typeprint.c (c_print_typedef): Update.
 630         (c_type_print_template_args): Update.
 631         * cli/cli-cmds.c (edit_command): Update.
 632         (list_command): Update.
 633         (print_sal_location): Update.
 634         * coffread.c (patch_opaque_types): Update.
 635         (process_coff_symbol): Update.
 636         (coff_read_enum_type): Update.
 637         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
 638         (convert_one_symbol): Update.
 639         (hash_symname): Update.
 640         (eq_symname): Update.
 641         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
 642         * compile/compile-cplus-types.c (debug_print_scope): Update.
 643         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 644         * compile/compile-object-load.c (get_out_value_type): Update.
 645         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
 646         (search_symbol_list): Update.
 647         (cp_lookup_symbol_imports_or_template): Update.
 648         * cp-support.c (overload_list_add_symbol): Update.
 649         * ctfread.c (psymtab_to_symtab): Update.
 650         * dbxread.c (cp_set_block_scope): Update.
 651         * dictionary.c (iter_match_first_hashed): Update.
 652         (iter_match_next_hashed): Update.
 653         (insert_symbol_hashed): Update.
 654         (iter_match_next_linear): Update.
 655         * dictionary.h: Update.
 656         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
 657         (locexpr_describe_location_piece): Update.
 658         (locexpr_describe_location_1): Update.
 659         (locexpr_generate_c_location): Update.
 660         (loclist_describe_location): Update.
 661         (loclist_generate_c_location): Update.
 662         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
 663         (read_func_scope): Update.
 664         (process_enumeration_scope): Update.
 665         (new_symbol): Update.
 666         (dwarf2_const_value): Update.
 667         (dwarf2_symbol_mark_computed): Update.
 668         * eval.c (evaluate_funcall): Update.
 669         (evaluate_subexp_standard): Update.
 670         * expprint.c (print_subexp_standard): Update.
 671         (dump_subexp_body_standard): Update.
 672         * f-valprint.c (info_common_command_for_block): Update.
 673         * findvar.c (get_hosting_frame): Update.
 674         (default_read_var_value): Update.
 675         * go-lang.c (go_symbol_package_name): Update.
 676         * guile/scm-block.c (bkscm_print_block_smob): Update.
 677         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
 678         (gdbscm_symbol_name): Update.
 679         (gdbscm_symbol_linkage_name): Update.
 680         (gdbscm_symbol_print_name): Update.
 681         * infcall.c (get_function_name): Update.
 682         * infcmd.c (jump_command): Update.
 683         (finish_command): Update.
 684         * infrun.c (insert_exception_resume_breakpoint): Update.
 685         * linespec.c (canonicalize_linespec): Update.
 686         (create_sals_line_offset): Update.
 687         (convert_linespec_to_sals): Update.
 688         (complete_label): Update.
 689         (find_label_symbols_in_block): Update.
 690         * m2-typeprint.c (m2_print_typedef): Update.
 691         * mdebugread.c (mdebug_reg_to_regnum): Update.
 692         (parse_symbol): Update.
 693         (mylookup_symbol): Update.
 694         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 695         (list_args_or_locals): Update.
 696         * objc-lang.c (compare_selectors): Update.
 697         (info_selectors_command): Update.
 698         (compare_classes): Update.
 699         (info_classes_command): Update.
 700         (find_imps): Update.
 701         * p-typeprint.c (pascal_print_typedef): Update.
 702         * printcmd.c (build_address_symbolic): Update.
 703         (info_address_command): Update.
 704         (print_variable_and_value): Update.
 705         * python/py-framefilter.c (extract_sym): Update.
 706         (py_print_single_arg): Update.
 707         * python/py-symbol.c (sympy_str): Update.
 708         (sympy_get_name): Update.
 709         (sympy_get_linkage_name): Update.
 710         * python/python.c (gdbpy_rbreak): Update.
 711         * record-btrace.c (btrace_get_bfun_name): Update.
 712         (btrace_call_history): Update.
 713         * rust-lang.c (rust_print_typedef): Update.
 714         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
 715         * stabsread.c (stab_reg_to_regnum): Update.
 716         (define_symbol): Update.
 717         (read_enum_type): Update.
 718         (common_block_end): Update.
 719         (cleanup_undefined_types_1): Update.
 720         (scan_file_globals): Update.
 721         * stack.c (print_frame_arg): Update.
 722         (print_frame_args): Update.
 723         (find_frame_funname): Update.
 724         (info_frame_command_core): Update.
 725         (iterate_over_block_locals): Update.
 726         (print_block_frame_labels): Update.
 727         (do_print_variable_and_value): Update.
 728         (iterate_over_block_arg_vars): Update.
 729         (return_command): Update.
 730         * symmisc.c (dump_symtab_1): Update.
 731         (print_symbol): Update.
 732         * symtab.c (eq_symbol_entry): Update.
 733         (symbol_cache_dump): Update.
 734         (lookup_language_this): Update.
 735         (find_pc_sect_line): Update.
 736         (skip_prologue_sal): Update.
 737         (symbol_search::compare_search_syms): Update.
 738         (treg_matches_sym_type_name): Update.
 739         (search_symbols): Update.
 740         (print_symbol_info): Update.
 741         (rbreak_command): Update.
 742         (completion_list_add_symbol): Update.
 743         (find_gnu_ifunc): Update.
 744         (get_symbol_address): Update.
 745         (search_module_symbols): Update.
 746         (info_module_subcommand): Update.
 747         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
 748         (SYMBOL_LINKAGE_NAME): Remove.
 749         (SYMBOL_DEMANGLED_NAME): Remove.
 750         (SYMBOL_PRINT_NAME): Remove.
 751         (SYMBOL_SEARCH_NAME): Remove.
 752         * tracepoint.c (set_traceframe_context): Update.
 753         (validate_actionline): Update.
 754         (collection_list::collect_symbol): Update.
 755         (encode_actions_1): Update.
 756         (info_scope_command): Update.
 757         (print_one_static_tracepoint_marker): Update.
 758         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
 759         * valops.c (address_of_variable): Update.
 760         (find_overload_match): Update.
 761         (find_oload_champ): Update.
 762
 763 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 764
 765         * ada-lang.c (ada_lookup_simple_minsym): Update.
 766         (ada_collect_symbol_completion_matches): Update.
 767         * ada-tasks.c (read_atcb): Update.
 768         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
 769         (amd64_windows_skip_trampoline_code): Update.
 770         * arm-tdep.c (skip_prologue_function): Update.
 771         (arm_skip_stack_protector): Update.
 772         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
 773         (arm_wince_skip_main_prologue): Update.
 774         * ax-gdb.c (gen_expr): Update.
 775         * block.c (call_site_for_pc): Update.
 776         * blockframe.c (find_pc_partial_function): Update.
 777         * breakpoint.c (set_breakpoint_location_function): Update.
 778         * btrace.c (ftrace_print_function_name): Update.
 779         (ftrace_function_switched): Update.
 780         * c-valprint.c (print_unpacked_pointer): Update.
 781         * coffread.c (coff_symfile_read): Update.
 782         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
 783         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
 784         * dwarf-index-write.c (write_psymbols): Update.
 785         * dwarf2loc.c (call_site_to_target_addr): Update.
 786         (func_verify_no_selftailcall): Update.
 787         (tailcall_dump): Update.
 788         (call_site_find_chain_1): Update.
 789         (dwarf_expr_reg_to_entry_parameter): Update.
 790         * elfread.c (elf_gnu_ifunc_record_cache): Update.
 791         * eval.c (evaluate_funcall): Update.
 792         (evaluate_subexp_standard): Update.
 793         (evaluate_subexp_for_sizeof): Update.
 794         * expprint.c (print_subexp_standard): Update.
 795         (dump_subexp_body_standard): Update.
 796         * frame.c (get_prev_frame_always_1): Update.
 797         * frv-tdep.c (frv_skip_main_prologue): Update.
 798         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
 799         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
 800         (gnuv3_get_typename_from_type_info): Update.
 801         (gnuv3_skip_trampoline): Update.
 802         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 803         * i386-tdep.c (i386_skip_main_prologue): Update.
 804         (i386_pe_skip_trampoline_code): Update.
 805         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
 806         * infcall.c (get_function_name): Update.
 807         * linespec.c (minsym_found): Update.
 808         * linux-fork.c (info_checkpoints_command): Update.
 809         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
 810         (m32c_m16c_pointer_to_address): Update.
 811         * maint.c (maintenance_translate_address): Update.
 812         * minsyms.c (add_minsym_to_hash_table): Update.
 813         (add_minsym_to_demangled_hash_table): Update.
 814         (lookup_minimal_symbol_mangled): Update.
 815         (lookup_minimal_symbol_demangled): Update.
 816         (lookup_minimal_symbol_linkage): Update.
 817         (lookup_minimal_symbol_text): Update.
 818         (lookup_minimal_symbol_by_pc_name): Update.
 819         (minimal_symbol_is_less_than): Update.
 820         (compact_minimal_symbols): Update.
 821         (build_minimal_symbol_hash_tables): Update.
 822         (find_solib_trampoline_target): Update.
 823         * mips-tdep.c (mips_stub_frame_sniffer): Update.
 824         (mips_skip_pic_trampoline_code): Update.
 825         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
 826         * objc-lang.c (info_selectors_command): Update.
 827         (info_classes_command): Update.
 828         (find_methods): Update.
 829         (find_imps): Update.
 830         * p-valprint.c (pascal_val_print): Update.
 831         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
 832         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
 833         * printcmd.c (build_address_symbolic): Update.
 834         (info_symbol_command): Update.
 835         * psymtab.c (psymbol_name_matches): Update.
 836         (match_partial_symbol): Update.
 837         (lookup_partial_symbol): Update.
 838         (print_partial_symbols): Update.
 839         (sort_pst_symbols): Update.
 840         (maintenance_check_psymtabs): Update.
 841         * python/py-framefilter.c (py_print_frame): Update.
 842         * python/python.c (gdbpy_rbreak): Update.
 843         * record-btrace.c (btrace_get_bfun_name): Update.
 844         (btrace_call_history): Update.
 845         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
 846         (rs6000_skip_trampoline_code): Update.
 847         * sol-thread.c (info_cb): Update.
 848         * stabsread.c (scan_file_globals): Update.
 849         * stack.c (find_frame_funname): Update.
 850         (info_frame_command_core): Update.
 851         * symmisc.c (dump_msymbols): Update.
 852         * symtab.c (symbol_natural_name): Rename to..,
 853         (general_symbol_info::natural_name): ...this.
 854         (symbol_demangled_name): Rename to...
 855         (general_symbol_info::demangled_name): ...this.
 856         (symbol_search_name): Rename to...
 857         (general_symbol_info::search_name): ...this.
 858         (symbol_matches_search_name): Update.
 859         (find_pc_sect_line): Update.
 860         (skip_prologue_sal): Update.
 861         (search_symbols): Update.
 862         (print_msymbol_info): Update.
 863         (rbreak_command): Update.
 864         (completion_list_add_msymbol): Update.
 865         (completion_list_objc_symbol): Update.
 866         (get_msymbol_address): Update.
 867         * symtab.h (struct general_symbol_info): Add member functions
 868         natural_name (), linkage_name (), print_name (), demangled_name (),
 869         and search_name ().
 870         (SYMBOL_NATURAL_NAME): Update.
 871         (symbol_natural_name): Move to a member function on general_symbol_info.
 872         (SYMBOL_DEMANGLED_NAME): Update.
 873         (symbol_demangled_name): Move to a member function on
 874         general_symbol_info.
 875         (SYMBOL_SEARCH_NAME): Update.
 876         (symbol_search_name): Move to a member function on general_symbol_info.
 877         (MSYMBOL_NATURAL_NAME): Remove.
 878         (MSYMBOL_LINKAGE_NAME): Remove.
 879         (MSYMBOL_PRINT_NAME): Remove.
 880         (MSYMBOL_DEMANGLED_NAME): Remove.
 881         (MSYMBOL_SEARCH_NAME): Remove.
 882         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
 883
 884 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
 885
 886         * symtab.c (create_demangled_names_hash): Use per_bfd->
 887         minimal_symbol_count for computing the initial size, if greater
 888         than our default size.
 889
 890 2019-11-22  Tom de Vries  <tdevries@suse.de>
 891
 892         * contrib/words.sh: Improve words extraction.
 893
 894 2019-11-22  Tom de Vries  <tdevries@suse.de>
 895
 896         * contrib/words.sh: Combine sed invocations.
 897
 898 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
 899
 900         * Makefile.in: Update.
 901         * demangle.c: Rename to...
 902         * gdb-demangle.c: ..this.
 903         (is_cplus_marker): Change return type to bool.
 904         (_initialize_demangler): Rename to...
 905         (_initialize_gdb_demangle): ...this.
 906         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
 907         * symtab.h (demangle): Remove declaration; instead include
 908         gdb-demangle.h.
 909
 910 2019-11-21  Tom Tromey  <tromey@adacore.com>
 911
 912         * gdbsupport/format.c (format_pieces): Parse %I64d.
 913         * unittests/format_pieces-selftests.c (test_windows_formats): New
 914         function.
 915         (run_tests): Call it.
 916
 917 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
 918
 919         Byte reverse display of variables with DW_END_big, DW_END_little
 920         (DW_AT_endianity) dwarf attributes if different than the native
 921         byte order.
 922         * ada-lang.c (ada_value_binop):
 923         Use type_byte_order instead of gdbarch_byte_order.
 924         * ada-valprint.c (printstr):
 925         (ada_val_print_string):
 926         * ada-lang.c (value_pointer):
 927         (ada_value_binop):
 928         Use type_byte_order instead of gdbarch_byte_order.
 929         * c-lang.c (c_get_string):
 930         Use type_byte_order instead of gdbarch_byte_order.
 931         * c-valprint.c (c_val_print_array):
 932         Use type_byte_order instead of gdbarch_byte_order.
 933         * cp-valprint.c (cp_print_class_member):
 934         Use type_byte_order instead of gdbarch_byte_order.
 935         * dwarf2loc.c (rw_pieced_value):
 936         Use type_byte_order instead of gdbarch_byte_order.
 937         * dwarf2read.c (read_base_type): Handle DW_END_big,
 938         DW_END_little
 939         * f-lang.c (f_get_encoding):
 940         Use type_byte_order instead of gdbarch_byte_order.
 941         * findvar.c (default_read_var_value):
 942         Use type_byte_order instead of gdbarch_byte_order.
 943         * gdbtypes.c (check_types_equal):
 944         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
 945         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
 946         and TYPE_ENDIANITY_LITTLE if set.
 947         (type_byte_order): new function.
 948         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
 949         (struct main_type) <flag_endianity_not_default>:
 950         New field.
 951         (type_byte_order): New function.
 952         * infcmd.c (default_print_one_register_info):
 953         Use type_byte_order instead of gdbarch_byte_order.
 954         * p-lang.c (pascal_printstr):
 955         Use type_byte_order instead of gdbarch_byte_order.
 956         * p-valprint.c (pascal_val_print):
 957         Use type_byte_order instead of gdbarch_byte_order.
 958         * printcmd.c (print_scalar_formatted):
 959         Use type_byte_order instead of gdbarch_byte_order.
 960         * solib-darwin.c (darwin_current_sos):
 961         Use type_byte_order instead of gdbarch_byte_order.
 962         * solib-svr4.c (solib_svr4_r_ldsomap):
 963         Use type_byte_order instead of gdbarch_byte_order.
 964         * stap-probe.c (stap_modify_semaphore):
 965         Use type_byte_order instead of gdbarch_byte_order.
 966         * target-float.c (target_float_same_format_p):
 967         Use type_byte_order instead of gdbarch_byte_order.
 968         * valarith.c (scalar_binop):
 969         (value_bit_index):
 970         Use type_byte_order instead of gdbarch_byte_order.
 971         * valops.c (value_cast):
 972         Use type_byte_order instead of gdbarch_byte_order.
 973         * valprint.c (generic_emit_char):
 974         (generic_printstr):
 975         (val_print_string):
 976         Use type_byte_order instead of gdbarch_byte_order.
 977         * value.c (unpack_long):
 978         (unpack_bits_as_long):
 979         (unpack_value_bitfield):
 980         (modify_field):
 981         (pack_long):
 982         (pack_unsigned_long):
 983         Use type_byte_order instead of gdbarch_byte_order.
 984         * findvar.c (unsigned_pointer_to_address):
 985         (signed_pointer_to_address):
 986         (unsigned_address_to_pointer):
 987         (address_to_signed_pointer):
 988         (default_read_var_value):
 989         (default_value_from_register):
 990         Use type_byte_order instead of gdbarch_byte_order.
 991         * gnu-v3-abi.c (gnuv3_make_method_ptr):
 992         Use type_byte_order instead of gdbarch_byte_order.
 993         * riscv-tdep.c (riscv_print_one_register_info):
 994         Use type_byte_order instead of gdbarch_byte_order.
 995
 996 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
 997
 998         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
 999         (current_ui_gdb_stdin_ptr): Likewise.
1000         (current_ui_gdb_stderr_ptr): Likewise.
1001         (current_ui_gdb_stdlog_ptr): Likewise.
1002         (current_ui_current_uiout_ptr): Likewise.
1003         (gen_ret_current_ui_field_ptr): Remove.
1004
1005 2019-11-21  Tom de Vries  <tdevries@suse.de>
1006
1007         PR gdb/24956
1008         * cli/cli-script.c (execute_control_command): Only switch to
1009         INTERP_CONSOLE's ui_out when INTERP_MI is active.
1010
1011 2019-11-19  Tom Tromey  <tom@tromey.com>
1012
1013         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1014         Now static.  Change type of "name".
1015         (tui_set_win_height_command): Don't copy "arg".
1016         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1017         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1018
1019 2019-11-19  Ali Tamur <tamur@google.com>
1020
1021         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1022         "if (attr != nullptr)".
1023         (dwarf2_find_base_address): Likewise.
1024         (dwarf2_build_include_psymtabs): Likewise.
1025         (read_cutu_die_from_dwo): Likewise.
1026         (read_func_scope): Likewise.
1027         (read_call_site_scope): Likewise.
1028         (dwarf2_get_pc_bounds): Likewise.
1029         (dwarf2_record_block_ranges): Likewise.
1030         (dwarf2_add_field): Likewise.
1031         (dwarf2_add_member_fn): Likewise.
1032         (read_structure_type): Likewise.
1033         (read_enumeration_type): Likewise.
1034         (read_array_type): Likewise.
1035         (read_array_order): Likewise.
1036         (read_set_type): Likewise.
1037         (read_common_block): Likewise.
1038         (read_tag_reference_type): Likewise.
1039         (read_tag_string_type): Likewise.
1040         (read_subroutine_type): Likewise.
1041         (read_base_type): Likewise.
1042         (read_subrange_type): Likewise.
1043         (new_symbol): Likewise.
1044         (prepare_one_comp_unit): Likewise.
1045
1046 2019-11-19  Tom Tromey  <tromey@adacore.com>
1047
1048         * windows-nat.c (windows_nat_target::attach): Include GetLastError
1049         result in error when DebugActiveProcess fails.
1050
1051 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
1052             Pedro Alves  <palves@redhat.com>
1053
1054         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1055         * target.c (target_stack::push): Call 'unpush' if there's a
1056         target on top of the stack.
1057
1058 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1059
1060         * python/py-block.c (blpy_dealloc): Call tp_free.
1061         (blpy_block_syms_dealloc): Likewise.
1062         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1063         * python/py-inferior.c (infpy_dealloc): Likewise.
1064         * python/py-lazy-string.c (stpy_dealloc): Likewise.
1065         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1066         * python/py-symbol.c (sympy_dealloc): Likewise.
1067         * python/py-symtab.c (stpy_dealloc): Likewise.
1068         * python/py-type.c (typy_iterator_dealloc): Likewise.
1069
1070 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
1071
1072         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1073         constructor instead of using a class initializer.
1074
1075 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1076
1077         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1078         * configure: Regenerate.
1079         * configure.ac: Don't source common.host.
1080         * gdbsupport/common.host: Remove.
1081         * gdbsupport/mingw-strerror.c: Remove.
1082         * gdbsupport/posix-strerror.c: Rename to...
1083         * gdbsupport/safe-strerror.c: ...this.
1084
1085 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1086
1087         * maint.c (scoped_command_stats::print_time): Use localtime_r
1088         instead of localtime (provided through gnulib if necessary).
1089         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1090         of ctime.
1091
1092 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1093
1094         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1095         avoid compile errors.
1096
1097 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
1098
1099         * config.in: Regenerate.
1100         * configure: Regenerate.
1101         * gdbsupport/common.m4: No longer check for strerror_r.
1102         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1103         POSIX version of strerror_r, now that gnulib provides it if
1104         necessary.
1105
1106 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
1107
1108         * README (`configure' options): Update.
1109
1110 2019-11-14  Tom Tromey  <tromey@adacore.com>
1111
1112         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1113         expected type for the RHS if the LHS is a convenience variable.
1114
1115 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
1116
1117         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1118         Provide explicit default and copy constructor.
1119
1120 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1121
1122         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1123         only call Py_INCREF (newbp) in the bppy_pending_object case.
1124
1125 2019-11-13  Tom Tromey  <tromey@adacore.com>
1126
1127         PR build/25182:
1128         * psympriv.h (partial_symbol): Remove static assert.
1129         * symtab.h (general_symbol_info, symbol): Remove static assert.
1130
1131 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1132
1133         * gdbsupport/format.c (format_pieces::format_pieces): Support
1134         printf 'z' size modifier.
1135         * gdbsupport/format.h (enum argclass): Add size_t_arg.
1136         * printcmd.c (ui_printf):  Handle size_t_arg.
1137         * ui-out.c (ui_out::vmessage): Likewise.
1138         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1139         function.
1140         (run_tests): Call test_format_int_sizes.
1141
1142 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
1143
1144         * ada-exp.y (write_ambiguous_var): Update.
1145         * buildsym.c (add_symbol_to_list): Update.
1146         * dwarf2read.c (read_variable): Update.
1147         (new_symbol): Update.
1148         * jit.c (finalize_symtab): Update.
1149         * language.c (language_alloc_type_symbol): Update.
1150         * symtab.c (fixup_symbol_section): Update.
1151         (initialize_objfile_symbol_1): Move code to...
1152         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1153         (allocate_symbol): Update.
1154         (allocate_template_symbol): Update.
1155         (get_symbol_address): Update.
1156         * symtab.h (struct symbol): Inherit from general_symbol_info instead
1157         of having as a field, and add a constructor.
1158         (SYMBOL_VALUE): Update.
1159         (SYMBOL_VALUE_ADDRESS): Update.
1160         (SET_SYMBOL_VALUE_ADDRESS): Update.
1161         (SYMBOL_VALUE_BYTES): Update.
1162         (SYMBOL_VALUE_COMMON_BLOCK): Update.
1163         (SYMBOL_BLOCK_VALUE): Update.
1164         (SYMBOL_VALUE_CHAIN): Update.
1165         (SYMBOL_LANGUAGE): Update.
1166         (SYMBOL_SECTION): Update.
1167         (SYMBOL_OBJ_SECTION): Update.
1168         (SYMBOL_SET_LANGUAGE): Update.
1169         (SYMBOL_SET_LINKAGE_NAME): Update.
1170         (SYMBOL_SET_NAMES): Update.
1171         (SYMBOL_NATURAL_NAME): Update.
1172         (SYMBOL_LINKAGE_NAME): Update.
1173         (SYMBOL_DEMANGLED_NAME): Update.
1174         (SYMBOL_SEARCH_NAME): Update.
1175         (SYMBOL_MATCHES_SEARCH_NAME): Update.
1176         (struct symbol): Update.
1177         (struct template_symbol): Update.
1178         (struct rust_vtable_symbol): Update.
1179         * xcoffread.c (SYMBOL_DUP): Update.
1180
1181 2019-11-12  Tom Tromey  <tom@tromey.com>
1182
1183         * tui/tui-layout.c (show_layout): Set current_layout.
1184         (show_source_disasm_command, show_data)
1185         (show_source_or_disasm_and_command): Don't set current_layout.
1186
1187 2019-11-12  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1190
1191 2019-11-12  Tom Tromey  <tom@tromey.com>
1192
1193         * tui/tui-win.c (resize_message): New global.
1194         (show_tui_resize_message): New function.
1195         (tui_async_resize_screen): Print message if requested.
1196         (_initialize_tui_win): Add tui-resize-message setting.
1197         * NEWS: Add entry for new commands.
1198
1199 2019-11-11  Tom Tromey  <tom@tromey.com>
1200
1201         * tui/tui.c (tui_initialize_readline): Add new bindable readline
1202         functions.
1203
1204 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
1205
1206         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1207
1208 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1211         function.
1212         * python/python-internal.h (gdbpy_lookup_static_symbols):
1213         Declare new function.
1214         * python/python.c (python_GdbMethods): Add
1215         gdb.lookup_static_symbols method.
1216         * NEWS: Mention gdb.lookup_static_symbols.
1217
1218 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1219
1220         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1221         static block of current object file first.  Also fix typo in
1222         header comment.
1223
1224 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1225
1226         * stack.c (set_last_displayed_sal): Delete.
1227         (last_displayed_sal_valid): Delete.
1228         (last_displayed_pspace): Delete.
1229         (last_displayed_addr): Delete.
1230         (last_displayed_symtab): Delete.
1231         (last_displayed_line): Delete.
1232         (class last_displayed_symtab_info_type): New.
1233         (last_displayed_symtab_info): New static global variable.
1234         (print_frame_info): Call methods on last_displayed_symtab_info.
1235         (clear_last_displayed_sal): Update header comment, and make use of
1236         last_displayed_symtab_info.
1237         (last_displayed_sal_is_valid): Likewise.
1238         (get_last_displayed_pspace): Likewise.
1239         (get_last_displayed_addr): Likewise.
1240         (get_last_displayed_symtab): Likewise.
1241         (get_last_displayed_line): Likewise.
1242         (get_last_displayed_sal): Likewise.
1243         * stack.h (clear_last_displayed_sal): Update header comment.
1244         (last_displayed_sal_is_valid): Likewise.
1245         (get_last_displayed_pspace): Likewise.
1246         (get_last_displayed_addr): Likewise.
1247         (get_last_displayed_symtab): Likewise.
1248         (get_last_displayed_line): Likewise.
1249         (get_last_displayed_sal): Likewise.
1250
1251 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1252
1253         * stack.c (frame_show_address): Convert return type to bool.
1254         * stack.h (frame_show_address): Likewise, and update header
1255         comment.
1256
1257 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1258
1259         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1260         * unittests/vec-utils-selftests.c: New file.
1261         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1262
1263 2019-11-10  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1266         (tui_highlight_win): Likewise.
1267         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1268         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1269         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1270         Don't set can_highlight.
1271
1272 2019-11-10  Tom Tromey  <tom@tromey.com>
1273
1274         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1275         Remove unused declaration.
1276
1277 2019-11-08  Tom Tromey  <tromey@adacore.com>
1278
1279         * top.c (read_command_file): Update.
1280         (command_line_input): Make return type const.
1281         * python/py-gdb-readline.c: Update.
1282         * linespec.c (decode_line_2): Update.
1283         * defs.h (command_line_input): Make return type const.
1284         * cli/cli-script.c (read_next_line): Make return type const.
1285         * ada-lang.c (get_selections): Update.
1286
1287 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
1288
1289         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1290         * mi/mi-main.c (output_cores): Likewise.
1291         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1292         (linux_xfer_osdata_modules): Likewise.
1293         * remote.c (register_remote_support_xml): Likewise.
1294         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1295         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1296
1297 2019-11-06  Tom Tromey  <tom@tromey.com>
1298
1299         * tui/tui-interp.c: Don't include readline.h.
1300         * tui/tui-hooks.c: Don't include readline.h.
1301         * symmisc.c: Include tilde.h, not readline.h.
1302         * symfile.c: Include tilde.h, not readline.h.
1303         * source.c: Include tilde.h, not readline.h.
1304         * solib.c: Include tilde.h, not readline.h.
1305         * psymtab.c: Include tilde.h, not readline.h.
1306         * exec.c: Include tilde.h, not readline.h.
1307         * corelow.c: Include tilde.h, not readline.h.
1308         * cli/cli-dump.c: Include tilde.h, not readline.h.
1309         * cli/cli-cmds.c: Don't include readline.h.
1310
1311 2019-11-05  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1314         (tui_disassemble): Set addr_size.
1315         (tui_disasm_window::set_contents): Use addr_size.
1316
1317 2019-11-05  Tom Tromey  <tom@tromey.com>
1318
1319         * rust-lang.c (rust_language_defn): Update.
1320         * python/py-value.c (valpy_string): Call c_get_string.
1321         * p-lang.c (pascal_language_defn): Update.
1322         * opencl-lang.c (opencl_language_defn): Update.
1323         * objc-lang.c (objc_language_defn): Update.
1324         * m2-lang.c (m2_language_defn): Update.
1325         * language.c (unknown_language_defn, auto_language_defn): Update.
1326         (default_get_string): Remove.
1327         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1328         * go-lang.c (go_language_defn): Update.
1329         * f-lang.c (f_language_defn): Update.
1330         * d-lang.c (d_language_defn): Update.
1331         * c-lang.c (c_language_defn, cplus_language_defn)
1332         (asm_language_defn, minimal_language_defn): Update.
1333         * ada-lang.c (ada_language_defn): Update.
1334         * language.h (struct language_defn) <la_get_string>: Remove.
1335         (LA_GET_STRING): Remove.
1336         (default_get_string): Don't declare.
1337
1338 2019-11-05  Tom Tromey  <tom@tromey.com>
1339
1340         * tui/tui-source.h (struct tui_source_window): Inline
1341         constructor.  Remove destructor.
1342         <style_changed, m_observable>: Move to superclass.
1343         * tui/tui-winsource.h (tui_copy_source_line): Declare.
1344         (struct tui_source_window_base): Move private members to end.
1345         <style_changed, m_observable>: Move from tui_source_window.
1346         * tui/tui-winsource.c (tui_copy_source_line): Move from
1347         tui-source.c.  Rename from copy_source_line.  Add special handling
1348         for negative line number.
1349         (tui_source_window_base::style_changed): Move from
1350         tui_source_window.
1351         (tui_source_window_base): Register observer.
1352         (~tui_source_window_base): New.
1353         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1354         rename.
1355         (tui_source_window::set_contents): Use tui_copy_source_line.
1356         (tui_source_window::tui_source_window): Move to tui-source.h.
1357         (tui_source_window::~tui_source_window): Remove.
1358         (tui_source_window::style_changed): Move to superclass.
1359         * tui/tui-disasm.c (tui_disassemble): Create string file with
1360         styling, when possible.  Add "addr_size" parameter.
1361         (tui_disasm_window::set_contents): Use tui_copy_source_line.
1362         Don't compute maximum size.
1363         (len_without_escapes): New function
1364
1365 2019-11-05  Tom Tromey  <tom@tromey.com>
1366
1367         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1368         std::string.
1369         * tui/tui-winsource.c (tui_show_source_line): Update.
1370         * tui/tui-source.c (tui_source_window::set_contents): Update.
1371         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1372
1373 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
1374
1375         * symtab.h (gdb_static_assert): Put && operator at the beginning
1376         of the line instead of the end.
1377
1378 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
1379
1380         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1381         and sizeof (symbol).
1382         * symtab.h: Add a static_assert for sizeof (partial_symbol).
1383
1384 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1385
1386         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1387         * configure.host: Mark *-*-solaris2.10* obsolete.
1388         * configure.tgt: Mark Solaris < 11 obsolete.
1389         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1390         Update target triplet.
1391
1392 2019-11-01  Tom Tromey  <tromey@adacore.com>
1393
1394         * utils.c (print_sys_errmsg): Simplify.
1395
1396 2019-11-01  Tom Tromey  <tromey@adacore.com>
1397
1398         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1399
1400 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
1401
1402         * configure: Regenerate.
1403         * configure.ac: Remove check for strerror_r.
1404         * gdbsupport/common.m4: Check for strerror_r.
1405
1406 2019-11-01  Luis Machado  <luis.machado@linaro.org>
1407
1408         PR gdb/25124
1409
1410         * arm-tdep.c (arm_per_objfile): Rename to ...
1411         (arm_per_bfd): ... this.
1412         (arm_objfile_data_key): Rename to ...
1413         (arm_bfd_data_key): ... this.
1414         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1415         data.
1416         (arm_record_special_symbol): Likewise.
1417
1418 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1419
1420         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1421         end.
1422         * c-typeprint.c (c_print_typedef): Likewise.
1423         * f-typeprint.c (f_print_typedef): Likewise.
1424         * m2-typeprint.c (m2_print_typedef): Likewise.
1425         * p-typeprint.c (pascal_print_typedef): Likewise.
1426         * rust-lang.c (rust_print_typedef): Likewise.
1427         * symtab.c (print_symbol_info): Print a newline after calling
1428         typedef_print.
1429
1430 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1431
1432         * symtab.c (info_module_cmdlist): New variable.
1433         (info_module_command): New function.
1434         (search_module_symbols): New function.
1435         (info_module_subcommand): New function.
1436         (struct info_modules_var_func_options): New struct.
1437         (info_modules_var_func_options_defs): New variable.
1438         (make_info_modules_var_func_options_def_group): New function.
1439         (info_module_functions_command): New function.
1440         (info_module_variables_command): New function.
1441         (info_module_var_func_command_completer): New function.
1442         (_initialize_symtab): Register new 'info module functions' and
1443         'info module variables' commands.
1444         * symtab.h (typedef symbol_search_in_module): New typedef.
1445         (search_module_symbols): Declare new function.
1446         * NEWS: Mention new commands.
1447
1448 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1451         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1452         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1453         MODULES_DOMAIN.
1454         (scan_partial_symbols): Only create partial module symbols for non
1455         declarations.
1456         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1457         and MODULES_DOMAIN.
1458         * symtab.c (search_domain_name): Likewise.
1459         (search_symbols): Likewise.
1460         (print_symbol_info): Likewise.
1461         (symtab_symbol_info): Likewise.
1462         (info_modules_command): New function.
1463         (_initialize_symtab): Register 'info modules' command.
1464         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1465         * NEWS: Mention new 'info modules' command.
1466
1467 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1468
1469         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1470         and $_gdb_maint_setting_str.
1471
1472 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1473
1474         * cli/cli-cmds.c (setting_cmd, value_from_setting)
1475         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1476         (str_value_from_setting, gdb_setting_str_internal_fn)
1477         (gdb_maint_setting_str_internal_fn): New functions.
1478         (_initialize_cli_cmds): Define the new convenience functions.
1479         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1480         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1481
1482 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1483
1484         * agent.c (set_can_use_agent): When the setting is turned on,
1485         look up agent symbols if we don't have them yet.
1486         (agent_new_objfile): Don't look up agent symbols when the agent
1487         setting is off.
1488
1489 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1490
1491         * config.in: Regenerate.
1492
1493 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1494
1495         * configure: Regenerate.
1496         * configure.ac: Check for strerror_r.
1497         * gdbsupport/common-utils.h (safe_strerror): Change return value
1498         to const char * and document that this function is now threadsafe.
1499         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1500         thread_local and call strerror_r, if available.
1501         * utils.c (perror_string): Update.
1502         (print_sys_errmsg): Update.
1503
1504 2019-10-31  Luis Machado  <luis.machado@linaro.org>
1505
1506         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1507         objfile_key.
1508         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1509         objfile to fetch per-bfd data.
1510         (arm_find_exidx_entry): Likewise.
1511
1512 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
1513
1514         * gdbsupport/agent.c (debug_agent): Change type to bool.
1515         (use_agent): Likewise.
1516         (all_agent_symbols_look_up): Likewise.
1517         (agent_loaded_p): Change return value to bool.
1518         (agent_look_up_symbols): Update.
1519         (agent_capability_check): Change return value to bool.
1520         * gdbsupport/agent.h (agent_loaded_p): Likewise.
1521         (debug_agent): Change type to bool.
1522         (use_agent): Likewise.
1523         (agent_capability_check): Change return value to bool.
1524
1525 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
1526
1527         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1528         (build_minimal_symbol_hash_tables): Code to clear the table moved
1529         to clear_minimal_symbol_hash_tables.
1530         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1531         when needed.
1532
1533 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1534
1535         * infcmd.c: Remove includes.
1536         * infrun.c: Remove includes.
1537
1538 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1539
1540         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1541         (grow_vect): Remove declaration.
1542         (ada_type_of_array): Remove declaration.
1543         (ada_update_initial_language): Remove declaration.
1544         (ada_fold_name): Remove declaration.
1545         (ada_fill_in_ada_prototype): Remove declaration.
1546         (user_select_syms): Remove declaration.
1547         (get_selections): Remove declaration.
1548         (ada_tag_type): Remove declaration.
1549         (ada_value_tag): Remove declaration.
1550         (ada_is_others_clause): Remove declaration.
1551         (ada_in_variant): Remove declaration.
1552         (ada_value_struct_elt): Remove declaration.
1553         (ada_attribute_name): Remove declaration.
1554         (ada_system_address_type): Remove declaration.
1555         * ada-lang.c (ada_watch_location_expression): Make static.
1556         (GROW_VECT): Move here from ada-lang.h.
1557         (grow_vect): Make static.
1558         (ada_update_initial_language): Make static.
1559         (ada_fold_name): Make static.
1560         (ada_type_of_array): Make static.
1561         (encoded_ordered_before): Move up.
1562         (sort_choices): Move up.
1563         (print_signatures): Move up.
1564         (ada_print_symbol_signature): Move up.
1565         (get_selections): Move up and make static.
1566         (user_select_syms): Move up and make static.
1567         (ada_value_struct_elt): Move up and make static.
1568         (ada_tag_type): Make static.
1569         (ada_value_tag): Make static.
1570         (ada_is_others_clause): Make static.
1571         (ada_in_variant): Make static.
1572         (ada_attribute_name): Make static.
1573
1574 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
1575
1576         * ada-lang.c: Remove includes.
1577         * ada-typeprint.c: Remove includes.
1578         * ada-valprint.c: Remove includes.
1579
1580 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
1581
1582         * addrmap.c: Add static assertions of type size, moved from
1583         _initialize_addrmap.
1584         (_initialize_addrmap): Remove.
1585
1586 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1587
1588         * coffread.c (record_minimal_symbol): Update.
1589         (process_coff_symbol): Update.
1590         * dbxread.c (read_dbx_symtab): Update.
1591         * dwarf2read.c (add_partial_symbol): Update.
1592         (fixup_go_packaging): Update.
1593         (load_partial_dies): Update.
1594         (new_symbol): Update.
1595         * elfread.c (record_minimal_symbol): Change signature to use
1596         gdb::string_view instead of name+len.
1597         (elf_symtab_read): Update.
1598         (elf_rel_plt_read): Update.
1599         * mdebugread.c (parse_partial_symbols): Update.
1600         (handle_psymbol_enumerators): Update.
1601         (new_symbol): Update.
1602         * minsyms.c (minimal_symbol_reader::record_full): Change signature
1603         to use gdb::string_view instead of name+len.
1604         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1605         * psympriv.h (add_psymbol_to_list): Likewise.
1606         * psymtab.c (add_psymbol_to_bcache): Likewise.
1607         (add_psymbol_to_list): Likewise.
1608         * stabsread.c (define_symbol): Update.
1609         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1610         * symtab.h (SYMBOL_SET_NAMES): Likewise.
1611         (symbol_set_names): Likewise.
1612         * xcoffread.c (scan_xcoff_symtab): Update.
1613
1614 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1615
1616         * symtab.h (symbol_set_names): Document that copy_name must be
1617         set to true for non-nullterminated strings.
1618         * symtab.c (symbol_set_names): Only make a nullterminated copy of
1619         linkage_name if the entry was not found and we need to demangle.
1620
1621 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1622
1623         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1624         * dwarf2-frame.c (bsearch_fde_cmp): Update.
1625         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1626         * gdbsupport/gdb_binary_search.h: New file.
1627
1628 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
1629
1630         * NEWS: Mention new --with-system-gdbinit-dir option.
1631         * config.in: Regenerate.
1632         * configure: Regenerate.
1633         * configure.ac: Add new option --with-system-gdbinit-dir.
1634         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1635         for a ".gdb" suffix.
1636         * main.c (get_init_files): Change system_gdbinit argument to
1637         a vector and return the files in SYSTEM_GDBINIT_DIR in
1638         addition to SYSTEM_GDBINIT.
1639         (captured_main_1): Update.
1640         (print_gdb_help): Update.
1641         * top.c (print_gdb_configuration): Also print the value of
1642         SYSTEM_GDBINIT_DIR.
1643
1644 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
1645
1646         * gdbsupport/common-utils.h (startswith): Add an overloaded version
1647         that takes gdb::string_view arguments.
1648
1649 2019-10-26  Tom de Vries  <tdevries@suse.de>
1650
1651         * aarch64-linux-tdep.c: Fix typos in comments.
1652         * aarch64-tdep.c: Same.
1653         * ada-lang.c: Same.
1654         * amd64-nat.c: Same.
1655         * arc-tdep.c: Same.
1656         * arch/aarch64-insn.c: Same.
1657         * block.c: Same.
1658         * breakpoint.h: Same.
1659         * btrace.h: Same.
1660         * c-varobj.c: Same.
1661         * cli/cli-decode.c: Same.
1662         * cli/cli-script.c: Same.
1663         * cli/cli-utils.h: Same.
1664         * coff-pe-read.c: Same.
1665         * coffread.c: Same.
1666         * compile/compile-cplus-symbols.c: Same.
1667         * compile/compile-object-run.c: Same.
1668         * completer.c: Same.
1669         * corelow.c: Same.
1670         * cp-support.c: Same.
1671         * demangle.c: Same.
1672         * dwarf-index-write.c: Same.
1673         * dwarf2-frame.c: Same.
1674         * dwarf2-frame.h: Same.
1675         * eval.c: Same.
1676         * frame-base.h: Same.
1677         * frame.h: Same.
1678         * gdbcmd.h: Same.
1679         * gdbtypes.h: Same.
1680         * gnu-nat.c: Same.
1681         * guile/scm-objfile.c: Same.
1682         * i386-tdep.c: Same.
1683         * i386-tdep.h: Same.
1684         * infcall.c: Same.
1685         * infcall.h: Same.
1686         * linux-nat.c: Same.
1687         * m68k-tdep.c: Same.
1688         * macroexp.c: Same.
1689         * memattr.c: Same.
1690         * mi/mi-cmd-disas.c: Same.
1691         * mi/mi-getopt.h: Same.
1692         * mi/mi-main.c: Same.
1693         * minsyms.c: Same.
1694         * nat/aarch64-sve-linux-sigcontext.h: Same.
1695         * objfiles.h: Same.
1696         * ppc-linux-nat.c: Same.
1697         * ppc-linux-tdep.c: Same.
1698         * ppc-tdep.h: Same.
1699         * progspace.h: Same.
1700         * prologue-value.h: Same.
1701         * python/py-evtregistry.c: Same.
1702         * python/py-instruction.h: Same.
1703         * record-btrace.c: Same.
1704         * record-full.c: Same.
1705         * remote.c: Same.
1706         * rs6000-tdep.c: Same.
1707         * ser-tcp.c: Same.
1708         * sol-thread.c: Same.
1709         * sparc-sol2-tdep.c: Same.
1710         * sparc64-tdep.c: Same.
1711         * stabsread.c: Same.
1712         * symfile.c: Same.
1713         * symtab.h: Same.
1714         * target.c: Same.
1715         * tracepoint.c: Same.
1716         * tui/tui-data.h: Same.
1717         * tui/tui-io.c: Same.
1718         * tui/tui-win.c: Same.
1719         * tui/tui.c: Same.
1720         * unittests/rsp-low-selftests.c: Same.
1721         * user-regs.h: Same.
1722         * utils.c: Same.
1723         * utils.h: Same.
1724         * valarith.c: Same.
1725         * valops.c: Same.
1726         * valprint.c: Same.
1727         * valprint.h: Same.
1728         * value.c: Same.
1729         * value.h: Same.
1730         * varobj.c: Same.
1731         * x86-nat.h: Same.
1732         * xtensa-tdep.c: Same.
1733
1734 2019-10-25  Ali Tamur <tamur@google.com>
1735
1736         * charset.c (find_charset_names): Reflect API change.
1737
1738 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
1739
1740         * symtab.c (struct demangled_name_entry): Change demangled name
1741         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
1742         part of the struct anymore.
1743         (symbol_set_names): No longer obstack allocate + copy the demangled
1744         name, just store the allocated name from bfd.
1745
1746 2019-10-25  Tom Tromey  <tromey@adacore.com>
1747
1748         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
1749         (bsearch_cie_cmp, add_cie): Remove.
1750         (find_cie): Reimplement.
1751         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
1752         (dwarf2_build_frame_info): Update.
1753
1754 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
1755
1756         PR gdb/25126
1757         * symfile.c (reread_symbols): Call forget_cached_source_info to
1758         clear the stale source cache.
1759
1760 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1761
1762         * configure: Regenerate.
1763         * configure.ac: Remove code that sets python_has_threads.
1764
1765 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
1766
1767         * config.in: Regenerate.
1768         * configure: Regenerate.
1769         * configure.ac: Remove the code that uses sed to get the python
1770         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
1771
1772 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1773
1774         * python/py-progspace.c (pspy_block_for_pc): Return None for all
1775         error paths.
1776
1777 2019-10-23  Tom Tromey  <tom@tromey.com>
1778
1779         * arc-tdep.c: Remove ".." from include.
1780         * frv-tdep.c: Remove ".." from include.
1781         * lm32-tdep.c: Remove ".." from include.
1782         * microblaze-tdep.c: Remove ".." from include.
1783         * or1k-tdep.h: Remove ".." from include.
1784         * s12z-tdep.c: Remove ".." from include.
1785         * Makefile.in (OPCODES_CFLAGS): Add comment.
1786         (TOP_CFLAGS): New variable.
1787         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
1788
1789 2019-10-23  Tom Tromey  <tom@tromey.com>
1790
1791         * Makefile.in (READLINE_DIR): Update.
1792
1793 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1794
1795         * infcall.c (call_function_by_hand_dummy): Fix the function
1796         comment.  And extract out a code section into...
1797         (reserve_stack_space): ...this new function.
1798
1799 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1800
1801         * infcall.c (value_arg_coerce): Remove an unused parameter.
1802         (call_function_by_hand_dummy): Update the call to
1803         'value_arg_coerce'.
1804
1805 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1806
1807         * infcall.c (call_function_by_hand_dummy): Refactor.
1808
1809 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1810
1811         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
1812
1813 2019-10-23  Tom Tromey  <tom@tromey.com>
1814
1815         * configure: Rebuild.
1816         * configure.ac: Don't check for sigprocmask.
1817         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
1818
1819 2019-10-23  Tom Tromey  <tom@tromey.com>
1820
1821         * configure: Rebuild.
1822         * acinclude.m4: Use m4_include, not sinclude.
1823
1824 2019-10-23  Tom de Vries  <tdevries@suse.de>
1825
1826         PR breakpoints/24687
1827         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
1828
1829 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1830
1831         * symtab.c (struct demangled_name_entry) <language>: Change from
1832         bitfield to regular variable.
1833
1834 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1835
1836         * symtab.c (struct demangled_name_entry): Add a constructor.
1837         (free_demangled_name_entry): New function to call the destructor
1838         for demangled_name_entry.
1839         (create_demangled_names_hash): Pass free_demangled_name_entry to
1840         htab_create_alloc.
1841         (symbol_set_names): Call placement new for demangled_name_entry.
1842         * utils.c: No longer include xxhash.h here, now that fast_hash
1843         is inlined in the header.
1844         * utils.h: Instead, include it here.
1845
1846 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1847
1848         * Makefile.in: Link with libxxhash.
1849         * config.in: Regenerate.
1850         * configure: Regenerate.
1851         * configure.ac: Search for libxxhash.
1852         * utils.c (fast_hash): Use xxhash if present.
1853
1854 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1855
1856         * utils.h (fast_hash): New function.
1857         * symtab.c (hash_demangled_name_entry): Call new function
1858         fast_hash.
1859
1860 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
1861
1862         * symtab.c (struct demangled_name_entry): Change type of mangled
1863         to gdb::string_view. Also adds a constructor that takes the
1864         mangled name.
1865         (hash_demangled_name_entry): Update.
1866         (eq_demangled_name_entry): Update.
1867         (free_demangled_name_entry): New function to call the destructor
1868         now that this is not a POD anymore.
1869         (create_demangled_names_hash): Pass free_demangled_name_entry to
1870         htab_create_alloc.
1871         (symbol_set_names): Update.
1872
1873 2019-10-21  Ali Tamur  <tamu@google.com>
1874
1875         * dwarf2read.c (dir_index): Change type.
1876         (file_name_index): Likewise.
1877         (line_header::include_dir_at): Change comment and implementation on
1878         whether it is DWARF 5.
1879         (line_header::is_valid_file_index): New function.
1880         (line_header::file_name_at): Change comment and implementation on
1881         whether it is DWARF 5.
1882         (line_header::file_names): Change to private field renamed as
1883         m_file_names and introduce a new accessor method.
1884         (line_header::file_names_size): New method.
1885         (line_header::include_dirs): Change to private field and rename as
1886         m_include_dirs.
1887         (dw2_get_file_names_reader): Define local var at a smaller scope and
1888         reflect API change.
1889         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
1890         (process_structure_scope): Likewise.
1891         (line_header::add_include_dir): Change message and reflect renaming.
1892         (line_header::add_file_name): Likewise.
1893         (read_formatted_entries): Handle DW_FORM_data16.
1894         (dwarf_decode_line_header): Fix line header length calculation.
1895         (psymtab_include_file_name): Change comment and API.
1896         (lnp_state_machine::m_file): Update comment and reflect type change.
1897         (lnp_state_machine::record_line): Reflect type change.
1898         (dwarf_decode_lines): Reflect API change.
1899         (file_file_name): Likewise.
1900         (file_full_name): Likewise.
1901
1902 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
1905
1906 2019-10-21  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
1909
1910 2019-10-21  Tom Tromey  <tom@tromey.com>
1911
1912         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
1913         NM_H.   Use AC_CONFIG_LINKS.
1914         * configure: Rebuild.
1915         * Makefile.in (NM_H): New variable.
1916         (generated_files): Add NM_H.  Remove gcore.
1917         (nm.h, stamp-nmh): New targets.
1918
1919 2019-10-20  Tom Tromey  <tom@tromey.com>
1920
1921         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
1922         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
1923         obsolete comment.
1924         (put_objfile_before): Now static.
1925
1926 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
1927
1928         * gdbsupport/common-utils.h (startswith): Change return type to
1929         bool.
1930
1931 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
1932
1933         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
1934         * breakpoint.c (bp_locations_compare): Rename to...
1935         (bp_location_is_less_than): ...this, and change to std::sort semantics.
1936         (update_global_location_list): Use std::sort instead of qsort.
1937         * buildsym.c (compare_line_numbers): Rename to...
1938         (lte_is_less_than): ...this, and change to std::sort semantics.
1939         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
1940         instead of qsort.
1941         * disasm.c (compare_lines): Rename to...
1942         (line_is_less_than): ...this, and change to std::sort semantics.
1943         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
1944         of qsort.
1945         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
1946         (fde_is_less_than): ...this, and change to std::sort semantics.
1947         (dwarf2_build_frame_info): Call std::sort instead of qsort.
1948         * mdebugread.c (compare_blocks):
1949         (block_is_less_than): ...this, and change to std::sort semantics.
1950         (sort_blocks): Call std::sort instead of qsort.
1951         * objfiles.c (qsort_cmp): Rename to...
1952         (sort_cmp): ...this, and change to std::sort semantics.
1953         (update_section_map): Call std::sort instead of qsort.
1954         * remote.c (compare_pnums): Remove.
1955         (map_regcache_remote_table): Call std::sort instead of qsort.
1956         * utils.c (compare_positive_ints): Remove.
1957         * utils.h (compare_positive_ints): Remove.
1958         * xcoffread.c (compare_lte): Remove.
1959         (arrange_linetable): Call std::sort instead of qsort.
1960
1961 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
1962
1963         * symfile.c (init_entry_point_info): Fix typo.
1964         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
1965
1966 2019-10-18  Tom de Vries  <tdevries@suse.de>
1967
1968         * aarch64-tdep.c: Fix typos in comments.
1969         * ada-lang.c: Same.
1970         * ada-tasks.c: Same.
1971         * alpha-tdep.c: Same.
1972         * alpha-tdep.h: Same.
1973         * amd64-nat.c: Same.
1974         * amd64-windows-tdep.c: Same.
1975         * arc-tdep.c: Same.
1976         * arc-tdep.h: Same.
1977         * arch-utils.c: Same.
1978         * arm-nbsd-tdep.c: Same.
1979         * arm-tdep.c: Same.
1980         * ax-gdb.c: Same.
1981         * blockframe.c: Same.
1982         * btrace.c: Same.
1983         * c-varobj.c: Same.
1984         * coff-pe-read.c: Same.
1985         * coffread.c: Same.
1986         * cris-tdep.c: Same.
1987         * darwin-nat.c: Same.
1988         * dbxread.c: Same.
1989         * dcache.c: Same.
1990         * disasm.c: Same.
1991         * dtrace-probe.c: Same.
1992         * dwarf-index-write.c: Same.
1993         * dwarf2-frame-tailcall.c: Same.
1994         * dwarf2-frame.c: Same.
1995         * dwarf2read.c: Same.
1996         * eval.c: Same.
1997         * exceptions.c: Same.
1998         * fbsd-tdep.c: Same.
1999         * findvar.c: Same.
2000         * frame.c: Same.
2001         * frv-tdep.c: Same.
2002         * gnu-v3-abi.c: Same.
2003         * go32-nat.c: Same.
2004         * h8300-tdep.c: Same.
2005         * hppa-tdep.c: Same.
2006         * i386-linux-tdep.c: Same.
2007         * i386-tdep.c: Same.
2008         * ia64-libunwind-tdep.c: Same.
2009         * ia64-tdep.c: Same.
2010         * infcmd.c: Same.
2011         * infrun.c: Same.
2012         * linespec.c: Same.
2013         * linux-nat.c: Same.
2014         * linux-thread-db.c: Same.
2015         * machoread.c: Same.
2016         * mdebugread.c: Same.
2017         * mep-tdep.c: Same.
2018         * mn10300-tdep.c: Same.
2019         * namespace.c: Same.
2020         * objfiles.c: Same.
2021         * opencl-lang.c: Same.
2022         * or1k-tdep.c: Same.
2023         * osabi.c: Same.
2024         * ppc-linux-nat.c: Same.
2025         * ppc-linux-tdep.c: Same.
2026         * ppc-sysv-tdep.c: Same.
2027         * printcmd.c: Same.
2028         * procfs.c: Same.
2029         * record-btrace.c: Same.
2030         * record-full.c: Same.
2031         * remote-fileio.c: Same.
2032         * remote.c: Same.
2033         * rs6000-tdep.c: Same.
2034         * s12z-tdep.c: Same.
2035         * score-tdep.c: Same.
2036         * ser-base.c: Same.
2037         * ser-go32.c: Same.
2038         * skip.c: Same.
2039         * sol-thread.c: Same.
2040         * solib-svr4.c: Same.
2041         * solib.c: Same.
2042         * source.c: Same.
2043         * sparc-nat.c: Same.
2044         * sparc-sol2-tdep.c: Same.
2045         * sparc-tdep.c: Same.
2046         * sparc64-tdep.c: Same.
2047         * stabsread.c: Same.
2048         * stack.c: Same.
2049         * symfile.c: Same.
2050         * symtab.c: Same.
2051         * target-descriptions.c: Same.
2052         * target-float.c: Same.
2053         * thread.c: Same.
2054         * utils.c: Same.
2055         * valops.c: Same.
2056         * valprint.c: Same.
2057         * value.c: Same.
2058         * varobj.c: Same.
2059         * windows-nat.c: Same.
2060         * xcoffread.c: Same.
2061         * xstormy16-tdep.c: Same.
2062         * xtensa-tdep.c: Same.
2063
2064 2019-10-17  Tom Tromey  <tromey@adacore.com>
2065
2066         * configure: Rebuild.
2067         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
2068         in AC_CONFIG_FILES invocation.
2069         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2070         new-style config.status invocation.
2071
2072 2019-10-17  Tom de Vries  <tdevries@suse.de>
2073
2074         * arm-nbsd-nat.c: Fix typos in comments.
2075         * arm-tdep.c: Same.
2076         * darwin-nat-info.c: Same.
2077         * dwarf2read.c: Same.
2078         * elfread.c: Same.
2079         * event-top.c: Same.
2080         * findvar.c: Same.
2081         * gdbtypes.c: Same.
2082         * hppa-tdep.c: Same.
2083         * i386-tdep.c: Same.
2084         * jit.c: Same.
2085         * main.c: Same.
2086         * mdebugread.c: Same.
2087         * moxie-tdep.c: Same.
2088         * nto-procfs.c: Same.
2089         * osabi.c: Same.
2090         * ppc-linux-tdep.c: Same.
2091         * remote.c: Same.
2092         * riscv-tdep.c: Same.
2093         * s390-tdep.c: Same.
2094         * sh-tdep.c: Same.
2095         * sparc-linux-tdep.c: Same.
2096         * sparc-nat.c: Same.
2097         * stack.c: Same.
2098         * target-descriptions.c: Same.
2099         * top.c: Same.
2100         * varobj.c: Same.
2101
2102 2019-10-16  Tom Tromey  <tom@tromey.com>
2103
2104         * objfiles.h (struct objfile) <original_name>: Now const.
2105
2106 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2107
2108         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2109         pass on to sigsetjmp's second argument.
2110         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2111
2112 2019-10-16  Keith Seitz  <keiths@redhat.com>
2113
2114         PR gdb/23567
2115         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2116         sections whose size is greater than the file size.
2117
2118 2019-10-16  Jim Wilson  <jimw@sifive.com>
2119
2120         * riscv-tdep.c (riscv_gcc_target_options): New.
2121         (riscv_gnu_triplet_regexp): New.
2122         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2123         set_gdbarch_gnu_triplet_regexp.
2124
2125 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
2126
2127         * Makefile.in: Add xml-builtin.h.
2128         * features/feature_to_c.sh: Add an include for xml-builtin.h
2129         to ensure that the compiler checks that the types match.
2130         * xml-builtin.h: New file.
2131         * xml-support.c (fetch_xml_builtin): Add missing const.
2132         * xml-support.h: Remove declaration of xml_builtins.
2133
2134 2019-10-16  Tom de Vries  <tdevries@suse.de>
2135
2136         PR tdep/25096
2137         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2138         (amd64_classify_aggregate): ... here.
2139         (amd64_classify_aggregate_field): Handled fiels of nested structs
2140         recursively.
2141
2142 2019-10-16  Tom de Vries  <tdevries@suse.de>
2143
2144         PR tdep/24104
2145         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2146         that handles 'theclass'.
2147
2148 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         * linespec.c (decode_digits_ordinary): Update comment.
2151         * make-target-delegates: No longer need to handle VEC case.
2152         * memrange.c (normalize_mem_ranges): Update comment.
2153         * namespace.c (add_using_directive): Update comment.
2154         * objc-lang.c (uniquify_strings): Update comment.
2155         * ppc-linux-nat.c (struct thread_points): Update comment.
2156         * probe.h (find_probes_in_objfile): Update comment.
2157         * target.h (enum flash_preserve_mode): Update comment.
2158         * varobj.c (varobj_restrict_range): Update comment.
2159         * varobj.h (varobj_list_children): Update comment.
2160
2161 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2162
2163         * Makefile.in: Remove references to vec.h and vec.c.
2164         * aarch64-tdep.c: No longer include vec.h.
2165         * ada-lang.c: Likewise.
2166         * ada-lang.h: Likewise.
2167         * arm-tdep.c: Likewise.
2168         * ax.h: Likewise.
2169         * breakpoint.h: Likewise.
2170         * charset.c: Likewise.
2171         * cp-support.h: Likewise.
2172         * dtrace-probe.c: Likewise.
2173         * dwarf2read.c: Likewise.
2174         * extension.h: Likewise.
2175         * gdb_bfd.c: Likewise.
2176         * gdbsupport/gdb_vecs.h: Likewise.
2177         * gdbsupport/vec.c: Remove.
2178         * gdbsupport/vec.h: Remove.
2179         * gdbthread.h: Likewise.
2180         * guile/scm-type.c: Likewise.
2181         * inline-frame.c: Likewise.
2182         * machoread.c: Likewise.
2183         * memattr.c: Likewise.
2184         * memrange.h: Likewise.
2185         * namespace.h: Likewise.
2186         * nat/linux-btrace.h: Likewise.
2187         * osdata.c: Likewise.
2188         * parser-defs.h: Likewise.
2189         * progspace.h: Likewise.
2190         * python/py-type.c: Likewise.
2191         * record-btrace.c: Likewise.
2192         * rust-exp.y: Likewise.
2193         * solib-target.c: Likewise.
2194         * stap-probe.c: Likewise.
2195         * target-descriptions.c: Likewise.
2196         * target-memory.c: Likewise.
2197         * target.h: Likewise.
2198         * varobj.c: Likewise.
2199         * varobj.h: Likewise.
2200         * xml-support.h: Likewise.
2201
2202 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2203
2204         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2205         Update for new std::vector based implementation.
2206         (process_psymtab_comp_unit_reader): Likewise.
2207         (scan_partial_symbols): Likewise.
2208         (recursively_compute_inclusions): Likewise.
2209         (compute_compunit_symtab_includes): Likewise.
2210         (process_imported_unit_die): Likewise.
2211         (queue_and_load_dwo_tu): Likewise.
2212         (follow_die_sig_1): Likewise.
2213         * gdb/dwarf2read.h: Remove DEF_VEC_P.
2214         (typedef dwarf2_per_cu_ptr): Remove.
2215         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2216         function.
2217         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2218         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2219         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2220         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2221         std::vector.
2222
2223 2019-10-15  Tom Tromey  <tromey@adacore.com>
2224
2225         * windows-nat.c (windows_nat_target::resume): Use %x when logging
2226         TID.
2227
2228 2019-10-15  Tom Tromey  <tromey@adacore.com>
2229
2230         * windows-nat.c (windows_nat_target::fetch_registers)
2231         (windows_nat_target::store_registers): Rename "pid" to "tid".
2232
2233 2019-10-15  Tom Tromey  <tromey@adacore.com>
2234
2235         * gdbarch.h, gdbarch.c: Rebuild.
2236         * gdbarch.sh (gcc_target_options): Change return type to
2237         std::string.
2238         * compile/compile.c (get_args): Update.
2239         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2240         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2241         std::string.
2242         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2243         std::string.
2244         * arch-utils.c (default_gcc_target_options): Return std::string.
2245         * arch-utils.h (default_gcc_target_options): Return std::string.
2246         * s390-tdep.c (s390_gcc_target_options): Return std::string.
2247
2248 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2249
2250         * breakpoint.c (breakpoint_chain): Make static.
2251         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2252         of accessing breakpoint_chain.
2253
2254 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
2255
2256         * breakpoint.c (iterate_over_breakpoints): Change function pointer
2257         to a gdb::function_view and return value to bool.
2258         * breakpoint.h (iterate_over_breakpoints): Likewise.
2259         * dummy-frame.c (pop_dummy_frame_bpt): Update.
2260         (pop_dummy_frame): Update.
2261         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2262         (gdbscm_breakpoints): Update.
2263         * python/py-breakpoint.c (build_bp_list): Update.
2264         (gdbpy_breakpoints): Update.
2265         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2266         Update.
2267         (bpfinishpy_handle_stop): Update.
2268         (bpfinishpy_handle_exit): Update.
2269         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2270         (svr4_update_solib_event_breakpoints): Update.
2271
2272 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
2273
2274         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2275         when unwrapping single-field structs.
2276
2277 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
2278
2279         * dwarf2read.c: Remove includes.
2280
2281 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
2282
2283         * ui-out.c (ui_out::call_do_message): Silence
2284         -Wformat-nonliteral warning.
2285
2286 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
2287
2288         * breakpoint.c: Remove some includes: continuations.h, skip.h,
2289         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
2290         include: readline/tilde.h.
2291
2292 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2293
2294         * remote.c (remote_target::get_trace_status): Remove declaration of
2295         trace_regblock_size.
2296
2297 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
2298
2299         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2300         (show_user): Remove declaration of cmdlist.
2301         * cli/cli-cmds.h (max_user_call_depth): Declare.
2302         * cli/cli-script.c (execute_user_command): Remove declaration
2303         of max_user_call_depth.
2304
2305 2019-10-11  Jim Wilson  <jimw@sifive.com>
2306
2307         * gdbsupport/print-utils.h (pulongest): Fix comment.
2308         (plongest): Likewise.
2309         (phex): Add missing comment, mention leading zeros.
2310         (phex_nz): Add mention of no leading zeros to comment.
2311
2312         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2313         plongest instead of unsigned long long cast.
2314
2315 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2316
2317         * main.c (captured_main_1): Include gdbtk.h and remove declarations
2318         for external_editor_command and gdbtk_test.
2319
2320 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
2321
2322         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2323         * varobj.c (varobjdebug): Move comment to...
2324         * varobj.h (varobjdebug): ...here, and declare.
2325
2326 2019-10-09  Tom Tromey  <tom@tromey.com>
2327
2328         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2329         erase_data_content.
2330
2331 2019-10-09  Tom Tromey  <tom@tromey.com>
2332
2333         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2334         * tui/tui-stack.c (tui_locator_window::rerender): Update.
2335         * tui/tui-command.c (tui_cmd_window::resize)
2336         (tui_refresh_cmd_win): Update.
2337         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2338         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2339         * tui/tui-data.c (~tui_gen_win_info): Remove.
2340         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2341         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2342         (tui_redisplay_readline, tui_mld_flush)
2343         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2344         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2345         (tui_data_window::erase_data_content)
2346         (tui_data_item_window::rerender)
2347         (tui_data_item_window::refresh_window): Update.
2348         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2349         (box_win, tui_gen_win_info::make_window)
2350         (tui_gen_win_info::make_visible): Update.
2351         (tui_delete_win): Remove.
2352         * tui/tui-winsource.c
2353         (tui_source_window_base::do_erase_source_content): Update.
2354         (tui_show_source_line, tui_source_window_base::update_tab_width)
2355         (tui_source_window_base::update_exec_info): Update.
2356         * tui/tui-data.h (struct curses_deleter): New.
2357         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2358         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2359
2360 2019-10-09  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2363
2364 2019-10-09  Tom Tromey  <tom@tromey.com>
2365
2366         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2367         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2368
2369 2019-10-09  Tom Tromey  <tom@tromey.com>
2370
2371         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2372         window height directly.
2373         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2374         declare.
2375         * tui/tui-layout.c (tui_default_win_height): Remove.
2376         (tui_default_win_viewport_height): Remove.
2377
2378 2019-10-09  Tom Tromey  <tom@tromey.com>
2379
2380         * tui/tui.h: Remove comments.
2381
2382 2019-10-09  Tom de Vries  <tdevries@suse.de>
2383
2384         * python/lib/gdb/printer/bound_registers.py: Use
2385         '^builtin_type_bound128' as regexp argument for
2386         add_builtin_pretty_printer.
2387
2388 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
2389
2390         * guile/guile.c (guile_extension_script_ops): Remove forward
2391         declaration and mark as static.
2392         (guile_script_ops): Likewise.
2393         (extension_language_guile): Move further down in the file so
2394         it can reference the definitions for guile_{extension_,}script_ops.
2395
2396 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
2397
2398         * s390-tdep.c (390_process_record): Handle new arch13 instructions
2399         except SORTL, DFLTCC, and KDSA.
2400
2401 2019-10-08  Tom Tromey  <tromey@adacore.com>
2402
2403         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2404         (struct safe_symbol_file_add_args): Remove.
2405
2406 2019-10-08  Tom Tromey  <tromey@adacore.com>
2407
2408         * windows-nat.c: Don't include buildsym-legacy.h.
2409
2410 2019-10-08  Tom Tromey  <tromey@adacore.com>
2411
2412         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2413
2414 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2415
2416         * gdbtypes.c (overload_debug): Move comment to header.
2417         * gdbtypes.h (overload_debug): Declare.
2418         * valops.c: Remove declaration of overload_debug, instead
2419         include gdbtypes.h.
2420
2421 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
2422
2423         * language.c (show_language_command): Pass lang_frame_mismatch_warn
2424         through _().
2425         (lang_frame_mismatch_warn): Make const, mark with N_(), and
2426         move comment...
2427         * language.h (lang_frame_mismatch_warn): ... here. Also add
2428         declaration.
2429         * top.c (lang_frame_mismatch_warn): Remove declaration.
2430         (check_frame_language_change): Pass lang_frame_mismatch_warn
2431         through _().
2432
2433 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2434
2435         * c-lang.h (vtbl_ptr_name): Declare.
2436         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2437         it from the header.
2438         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2439
2440 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
2441
2442         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2443         gdb_static_assert.
2444
2445 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2446
2447         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2448         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2449         * ctfread.c: New file.
2450         * ctfread.h: New file.
2451         * elfread.c: Include ctfread.h.
2452         (struct elfinfo text_p): New member ctfsect.
2453         (elf_locate_sections): Mark CTF section.
2454         (elf_symfile_read): Call elfctf_build_psymtabs.
2455         * Makefile.in (LIBCTF): Add.
2456         (CLIBS): Use it.
2457         (CDEPS): Likewise.
2458         (DIST): Add ctfread.c.
2459
2460 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2461
2462         * ctfread.c (struct nextfield): Renamed to ...
2463         (struct ctf_nextfield): ... this.
2464         (struct field_info): Renamed to ...
2465         (strut ctf_field_info): ... this.
2466         (attach_fields_to_type): Update for renamed structures.
2467         (ctf_add_member_cb): Likewise.
2468         (ctf_add_enum_member_cb): Likewise.
2469         (process_struct_members): Likewise.
2470         (process_enum_type): Likewise.
2471
2472 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
2473
2474         * tracectf.h: Rename, was ctf.h.
2475         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2476         * tracefile.c: Likewise.
2477         * tracepoint.c: Remove unused include ctf.h.
2478         * mi/mi-main.c: Likewise.
2479         * Makefile.in Replace ctf.c with tracectf.c.
2480
2481 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
2482
2483         * version.in: Change version number to "9.0.50.DATE-git".
2484
2485 2019-10-03  Tom Tromey  <tom@tromey.com>
2486
2487         PR rust/24976:
2488         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2489
2490 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2491
2492         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2493         cp_search_name_hash.
2494         * NEWS: Add entry about nested function support.
2495
2496 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
2497             Andrew Burgess  <andrew.burgess@embecosm.com>
2498
2499         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2500         for nested static variables when searchin VAR_DOMAIN.
2501         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2502         global scope, update comment.
2503         (add_partial_subprogram): Call add_partial_subprogram recursively
2504         for nested subroutines when processinng Fortran.
2505         (load_partial_dies): Process the child entities of a subprogram
2506         when processing Fortran.
2507         (partial_die_parent_scope): Handle building scope
2508         for Fortran nested functions.
2509         (process_die): Record that nested functions have a scope.
2510         (new_symbol): Always record Fortran subprograms on the global
2511         symbol list.
2512         (determine_prefix): How to build the prefix for Fortran
2513         subprograms.
2514
2515 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2516
2517         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2518         have just sent the thread a SIGSTOP and are waiting for it to
2519         arrive.
2520
2521 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2522
2523         * btrace.c (btrace_add_pc): Remove whitespace before the template
2524         parameter in 'std::vector <...>'.
2525         (parse_xml_btrace_block): Likewise.
2526         (btrace_maint_decode_pt): Likewise.
2527         (btrace_maint_update_packets): Likewise.
2528         (btrace_maint_print_packets): Likewise.
2529         * btrace.h (struct btrace_maint_info): Likewise.
2530         * dwarf2read.c (struct type_unit_group): Likewise.
2531         (build_type_psymtabs_reader): Likewise.
2532         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2533         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2534         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2535
2536 2019-10-03  Tom de Vries  <tdevries@suse.de>
2537
2538         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2539         the first line of the help text for set/show style metadata.
2540
2541 2019-10-02  Tom Tromey  <tromey@adacore.com>
2542
2543         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2544         * gdbsupport/common-inferior.c: New file.
2545         * infcmd.c (startup_with_shell): Don't define.
2546         * nat/fork-inferior.h (startup_with_shell): Don't declare.
2547         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2548         * inferior.h (startup_with_shell): Don't declare.
2549
2550 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
2551
2552         * gdbsupport/gdb_assert.h: Include errors.h.
2553         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2554
2555 2019-10-02  Tom Tromey  <tromey@adacore.com>
2556
2557         * NEWS: Add $_ada_exception entry.
2558         * ada-lang.c (struct ada_catchpoint): Add constructor.
2559         <m_kind>: New member.
2560         (allocate_location_exception, re_set_exception): Remove
2561         "ex" parameter.
2562         (should_stop_exception): Compute $_ada_exception.
2563         (check_status_exception, print_it_exception)
2564         (print_one_exception, print_mention_exception): Remove
2565         "ex" parameter.
2566         (allocate_location_catch_exception, re_set_catch_exception)
2567         (check_status_exception, print_it_catch_exception)
2568         (print_one_catch_exception, print_mention_catch_exception)
2569         (print_recreate_catch_exception)
2570         (allocate_location_catch_exception_unhandled)
2571         (re_set_catch_exception_unhandled)
2572         (check_status_exception, print_it_catch_exception_unhandled)
2573         (print_one_catch_exception_unhandled)
2574         (print_mention_catch_exception_unhandled)
2575         (print_recreate_catch_exception_unhandled)
2576         (allocate_location_catch_assert, re_set_catch_assert)
2577         (check_status_assert, print_it_catch_assert)
2578         (print_one_catch_assert, print_mention_catch_assert)
2579         (print_recreate_catch_assert)
2580         (allocate_location_catch_handlers, re_set_catch_handlers)
2581         (check_status_handlers, print_it_catch_handlers)
2582         (print_one_catch_handlers, print_mention_catch_handlers)
2583         (print_recreate_catch_handlers): Remove.
2584         (create_ada_exception_catchpoint): Update.
2585         (initialize_ada_catchpoint_ops): Update.
2586
2587 2019-10-02  Tom Tromey  <tromey@adacore.com>
2588
2589         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2590         (create_excep_cond_exprs): Simplify exception string computation.
2591         (ada_exception_catchpoint_cond_string): Likewise.
2592
2593 2019-10-02  Tom Tromey  <tromey@adacore.com>
2594
2595         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2596         * ada-lang.c (lesseq_defined_than): Handle
2597         LOC_STATIC.
2598         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2599         parameter.
2600         (dwarf2_has_info): Likewise.
2601         (new_symbol): Set maybe_copied on symbol when
2602         appropriate.
2603         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2604         parameter.
2605         <can_copy>: New member.
2606         * elfread.c (record_minimal_symbol): Set maybe_copied
2607         on symbol when appropriate.
2608         (elf_symfile_read): Update call to dwarf2_has_info.
2609         * minsyms.c (lookup_minimal_symbol_linkage): New
2610         function.
2611         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2612         * symtab.c (get_symbol_address, get_msymbol_address):
2613         New functions.
2614         * symtab.h (get_symbol_address, get_msymbol_address):
2615         Declare.
2616         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2617         maybe_copied.
2618         (struct symbol, struct minimal_symbol) <maybe_copied>:
2619         New member.
2620
2621 2019-10-02  Tom Tromey  <tromey@adacore.com>
2622
2623         * source.c (struct current_source_location): New.
2624         (current_source_key): New global.
2625         (current_source_symtab, current_source_line)
2626         (current_source_pspace): Remove.
2627         (get_source_location): New function.
2628         (get_current_source_symtab_and_line)
2629         (set_default_source_symtab_and_line)
2630         (set_current_source_symtab_and_line)
2631         (clear_current_source_symtab_and_line, select_source_symtab)
2632         (info_source_command, print_source_lines_base)
2633         (info_line_command, search_command_helper, _initialize_source):
2634         Update.
2635
2636 2019-10-02  Tom Tromey  <tromey@adacore.com>
2637
2638         * source.c (select_source_symtab): Don't call
2639         decode_line_with_current_source.
2640
2641 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2642
2643         * symtab.c (lookup_global_symbol): Search global block.
2644
2645 2019-10-02  Tom Tromey  <tromey@adacore.com>
2646
2647         * coffread.c (process_coff_symbol): Update.
2648         * dwarf2read.c (var_decode_location, new_symbol): Update.
2649         * mdebugread.c (parse_symbol): Update.
2650         * objfiles.c (relocate_one_symbol): Update.
2651         * stabsread.c (define_symbol, fix_common_block)
2652         (scan_file_globals): Update.
2653         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2654         (SET_SYMBOL_VALUE_ADDRESS): New macro.
2655         * xcoffread.c (process_xcoff_symbol): Update.
2656
2657 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
2658
2659         * MAINTAINERS: Update my email address.
2660
2661 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2662
2663         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2664         std::vector.
2665         (build_type_psymtabs_reader): Update for std::vector.
2666         (build_type_psymtab_dependencies): Likewise.
2667         * dwarf2read.h: Remove use of DEF_VEC_P.
2668         (typedef sig_type_ptr): Delete.
2669
2670 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2671
2672         * btrace.c (btrace_maint_clear): Update to handle change from VEC
2673         to std::vector.
2674         (btrace_maint_decode_pt): Likewise, and move allocation of the
2675         vector outside of the loop.
2676         (btrace_maint_update_packets): Update to handle change from VEC to
2677         std::vector.
2678         (btrace_maint_print_packets): Likewise.
2679         (maint_info_btrace_cmd): Likewise.
2680         * btrace.h: Remove use of DEF_VEC_O.
2681         (typedef btrace_pt_packet_s): Delete.
2682         (struct btrace_maint_info) <packets>: Change fromm VEC to
2683         std::vector.
2684         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2685
2686 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2687
2688         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
2689         make accesses into the vector constant references.
2690         (btrace_add_pc): Update for std::vector.
2691         (btrace_stitch_bts): Likewise.
2692         (parse_xml_btrace_block): Likewise.
2693         (btrace_maint_update_packets): Likewise.
2694         (btrace_maint_print_packets): Likewise.
2695         (maint_info_btrace_cmd): Likewise.
2696         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
2697         std::vector.
2698         (btrace_data::empty): Likewise.
2699         (btrace_data_append): Likewise.
2700         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
2701         (typedef btrace_block_s): Delete.
2702         (struct btrace_block): Add constructor.
2703         (struct btrace_data_bts) <blocks>: Change to std::vector.
2704         * nat/linux-btrace.c (perf_event_read_bts): Update for
2705         std::vector.
2706         (linux_read_bts): Likewise.
2707
2708 2019-10-01  Tom Tromey  <tom@tromey.com>
2709
2710         * cli/cli-logging.c (show_logging_filename): Use styled_string.
2711
2712 2019-10-01  Tom Tromey  <tom@tromey.com>
2713
2714         * stack.c (print_frame, info_frame_command_core): Use
2715         styled_string.
2716         * linux-thread-db.c (try_thread_db_load_1)
2717         (try_thread_db_load_from_pdir_1): Use styled_string.
2718         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
2719         (auto_load_section_scripts, info_auto_load_local_gdbinit)
2720         (maybe_print_unsupported_script_warning)
2721         (maybe_print_script_not_found_warning): Use styled_string.
2722         * ada-lang.c (user_select_syms): Use styled_string.
2723
2724 2019-10-01  Tom Tromey  <tom@tromey.com>
2725
2726         * p-lang.c (pascal_printstr): Use metadata style.
2727         * value.c (show_convenience): Use metadata style.
2728         * valprint.c (valprint_check_validity, val_print_optimized_out)
2729         (val_print_not_saved, val_print_unavailable)
2730         (val_print_invalid_address, generic_val_print, val_print)
2731         (value_check_printable, val_print_array_elements): Use metadata
2732         style.
2733         * ui-out.h (class ui_out) <field_fmt>: New overload.
2734         <do_field_fmt>: Add style parameter.
2735         * ui-out.c (ui_out::field_fmt): New overload.
2736         * typeprint.c (type_print_unknown_return_type)
2737         (val_print_not_allocated, val_print_not_associated): Use metadata
2738         style.
2739         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
2740         parameter.
2741         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
2742         * tracepoint.c (tvariables_info_1): Use metadata style.
2743         * stack.c (print_frame_arg, print_frame_info, print_frame)
2744         (info_frame_command_core): Use metadata style.
2745         * skip.c (info_skip_command): Use metadata style.
2746         * rust-lang.c (rust_print_enum): Use metadata style.
2747         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
2748         metadata style.
2749         * python/py-framefilter.c (py_print_single_arg): Use metadata
2750         style.
2751         * printcmd.c (do_one_display, print_variable_and_value): Use
2752         metadata style.
2753         * p-valprint.c (pascal_val_print)
2754         (pascal_object_print_value_fields): Use metadata style.
2755         * p-typeprint.c (pascal_type_print_base): Use metadata style.
2756         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
2757         parameter.
2758         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
2759         * m2-valprint.c (m2_print_long_set): Use metadata style.
2760         * m2-typeprint.c (m2_print_type): Use metadata style.
2761         * infcmd.c (print_return_value_1): Use metadata style.
2762         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
2763         * f-valprint.c (info_common_command_for_block): Use metadata
2764         style.
2765         * f-typeprint.c (f_type_print_base): Use metadata style.
2766         * expprint.c (print_subexp_standard): Use metadata style.
2767         * cp-valprint.c (cp_print_value_fields): Use metadata style.
2768         * cli/cli-style.h (class cli_style_option): Add constructor.
2769         (metadata_style): Declare.
2770         * cli/cli-style.c (metadata_style): New global.
2771         (_initialize_cli_style): Register metadata style.
2772         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
2773         parameter.
2774         * cli-out.c (cli_ui_out::do_field_fmt): Update.
2775         * c-typeprint.c (c_type_print_base_struct_union)
2776         (c_type_print_base_1): Use metadata style.
2777         * breakpoint.c (watchpoint_value_print)
2778         (print_one_breakpoint_location): Use metadata style.
2779         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
2780         style.
2781         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
2782         style.
2783         * ada-valprint.c (val_print_packed_array_elements, printstr)
2784         (print_field_values, ada_val_print_ref, ada_val_print): Use
2785         metadata style.
2786         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
2787         style.
2788         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
2789         style.
2790         * ada-lang.c (user_select_syms): Use metadata style.
2791
2792 2019-10-01  Tom Tromey  <tom@tromey.com>
2793
2794         * cli/cli-cmds.c (pwd_command): Style output.
2795
2796 2019-10-01  Pedro Alves  <palves@redhat.com>
2797             Tom Tromey  <tom@tromey.com>
2798
2799         * symtab.c (print_symbol_info): Use %ps.
2800         (print_msymbol_info): Use %ps.
2801         * symfile.c (symbol_file_add_with_addrs): Use %ps.
2802         * printcmd.c (print_variable_and_value): Use %ps.
2803         * macrocmd.c (show_pp_source_pos): Use %ps.
2804         * infrun.c (print_exited_reason): Use ui_out::message.
2805         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
2806         (describe_other_breakpoints): Use ui_out::message and new
2807         formats.
2808         (say_where): Use new formats.
2809         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
2810         and new formats.
2811
2812 2019-10-01  Pedro Alves  <palves@redhat.com>
2813             Tom Tromey  <tom@tromey.com>
2814
2815         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
2816         (test_gdb_formats): New function.
2817         (run_tests): Call it.
2818         (test_format_specifier): Update.
2819         * utils.h (fputs_filtered): Update comment.
2820         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
2821         (fputs_styled_unfiltered): Declare.
2822         * utils.c (fputs_styled_unfiltered): New function.
2823         (vfprintf_maybe_filtered): Add gdbfmt parameter.
2824         (vfprintf_filtered): Update.
2825         (vfprintf_unfiltered, vprintf_filtered): Update.
2826         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
2827         * ui-out.h (enum ui_out_flag) <unfiltered_output,
2828         disallow_ui_out_field>: New constants.
2829         (enum class field_kind): New.
2830         (struct base_field_s, struct signed_field_s): New.
2831         (signed_field): New function.
2832         (struct string_field_s): New.
2833         (string_field): New function.
2834         (struct styled_string_s): New.
2835         (styled_string): New function.
2836         (class ui_out) <message>: Add comment.
2837         <vmessage, call_do_message>: New methods.
2838         <do_message>: Add style parameter.
2839         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
2840         methods.
2841         (ui_out::message): Rewrite.
2842         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
2843         parameter.
2844         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
2845         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
2846         gdb_extensions parameter.
2847         (class format_piece): Add parameter to constructor.
2848         (n_int_args): New field.
2849         * gdbsupport/format.c (format_pieces::format_pieces): Add
2850         gdb_extensions parameter.  Handle '*'.
2851         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
2852         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
2853         vfprintf_styled_no_gdbfmt.
2854         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
2855         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
2856         unfiltered output.
2857         * ui-style.h (struct ui_file_style) <ptr>: New method.
2858
2859 2019-10-01  Tom Tromey  <tom@tromey.com>
2860
2861         * unittests/format_pieces-selftests.c: Update.  Add final format.
2862         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
2863         empty literal pieces.
2864
2865 2019-10-01  Tom Tromey  <tom@tromey.com>
2866
2867         * ui-out.h (enum class ui_out_style_kind): Remove.
2868         (class ui_out) <field_string, field_stsream, do_field_string>:
2869         Change type of "style".
2870         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
2871         (ui_out::field_string): Update.
2872         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
2873         of "style".
2874         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
2875         * tracepoint.c (print_one_static_tracepoint_marker): Update.
2876         * stack.c (print_frame_arg, print_frame_info, print_frame):
2877         Update.
2878         * source.c (print_source_lines_base): Update.
2879         * solib.c (info_sharedlibrary_command): Update.
2880         * skip.c (info_skip_command): Update.
2881         * record-btrace.c (btrace_call_history_src_line)
2882         (btrace_call_history): Update.
2883         * python/py-framefilter.c (py_print_frame): Update.
2884         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
2885         "style".
2886         * mi/mi-out.c (mi_ui_out::do_table_header)
2887         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
2888         (mi_ui_out::do_field_string): Update.
2889         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2890         Update.
2891         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
2892         "style".
2893         * cli-out.c (cli_ui_out::do_table_header)
2894         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
2895         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
2896         (cli_ui_out::do_field_fmt): Update.
2897         * breakpoint.c (print_breakpoint_location): Update.
2898         (update_static_tracepoint): Update.
2899
2900 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2901
2902         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
2903         conversion of gdb_datadir.
2904         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
2905         remove not needed c_str ().
2906
2907 2019-09-30  Ali Tamur <tamur@google.com>
2908
2909         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
2910         (dwarf2_string_attr): Likewise.
2911
2912 2019-09-30  Ali Tamur <tamur@google.com>
2913
2914         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
2915         (process_full_type_unit): Likewise.
2916         (dump_die_shallow): Likewise.
2917         (cu_debug_loc_section): Likewise.
2918
2919 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
2920
2921         * minsyms.c (compare_minimal_symbols): Rename to...
2922         (minimal_symbol_is_less_than): ...this, and adjust to STL
2923         conventions (return bool, take arguments as references)
2924         (minimal_symbol_reader::install): Call std::sort instead
2925         of qsort.
2926
2927 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
2928
2929         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
2930         hash and why.
2931         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
2932         msymbol_hash, msymbol_demangled_hash>: Improve comments.
2933
2934 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
2935
2936         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
2937         * psympriv.h (add_psymbol_to_list): Move comment here and update
2938         it.
2939
2940 2019-09-29  Tom de Vries  <tdevries@suse.de>
2941
2942         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
2943         Use $tmpdir/$(basename "$output_file").dwz instead of
2944         "${output_file}.dwz".
2945
2946 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
2947
2948         PR gdb/25045
2949         * hppa-linux-nat.c: Include gdbarch.h.
2950
2951 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
2952
2953         * blockframe.c (find_pc_partial_function): Change return type to bool.
2954         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
2955         * minsyms.c (in_gnu_ifunc_stub): Likewise.
2956         (stub_gnu_ifunc_resolve_name): Likewise.
2957         * symtab.c (compare_filenames_for_search): Likewise.
2958         (compare_glob_filenames_for_search): Likewise.
2959         (matching_obj_sections): Likewise.
2960         (symbol_matches_domain): Likewise.
2961         (find_line_symtab): Change out param EXACT_MATCH to bool *.
2962         (find_line_pc): Change return type to bool.
2963         (find_line_pc_range): Likewise.
2964         (producer_is_realview): Likewise.
2965         * symtab.h (symbol_matches_domain): Likewise.
2966         (find_pc_partial_function): Likewise.
2967         (find_pc_line_pc_range): Likewise.
2968         (in_gnu_ifunc_stub): Likewise.
2969         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
2970         (find_line_pc): Likewise.
2971         (find_line_pc_range): Likewise.
2972         (matching_obj_sections): Likewise.
2973         (find_line_symtab): Change out parameter to bool.
2974         (producer_is_realview): Change return type to bool.
2975         (compare_filenames_for_search): Likewise.
2976         (compare_glob_filenames_for_search): Likewise.
2977
2978 2019-09-26  Tom Tromey  <tom@tromey.com>
2979
2980         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
2981         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
2982         * gdb_usleep.h: Remove.
2983         * gdb_usleep.c: Remove.
2984         * utils.c: Don't include gdb_usleep.h.
2985
2986 2019-09-26  Tom Tromey  <tromey@adacore.com>
2987
2988         * python/py-type.c (type_to_type_object): Call check_typedef
2989         for stub types.
2990
2991 2019-09-26  Tom Tromey  <tom@tromey.com>
2992
2993         * utils.h (initialize_utils): Don't declare.
2994         * top.c (gdb_init): Don't call initialize_utils.
2995         * utils.c (initialize_utils): Remove.  Move contents...
2996         (_initialize_utils): ... here.
2997
2998 2019-09-25  Tom Tromey  <tom@tromey.com>
2999
3000         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3001         * utils.h (make_hex_string): Don't declare.
3002         * utils.c (make_hex_string): Remove.
3003
3004 2019-09-24  Tom de Vries  <tdevries@suse.de>
3005
3006         PR gdb/23815
3007         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3008         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3009
3010 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
3011
3012         * NEWS: Mention new simulator port for PRU.
3013
3014 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
3015
3016         * ada-exp.y (write_object_remaining): Update.
3017         * ada-lang.c (ada_decode): Return a std::string instead of a char*
3018         and eliminate the static buffer.
3019         (ada_decode_symbol): Update.
3020         (ada_la_decode): Update.
3021         (ada_sniff_from_mangled_name): Update.
3022         (is_valid_name_for_wild_match): Update.
3023         (ada_lookup_name_info::matches): Update and simplify.
3024         (name_matches_regex): Update.
3025         (ada_add_global_exceptions): Update.
3026         * ada-lang.h (ada_decode): Update signature.
3027         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3028         * dwarf-index-write.c (debug_names::insert): Update.
3029
3030 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3031
3032         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3033         formatting.
3034
3035 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
3036
3037         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3038         Change "nonzero" to "true" in documentation.
3039
3040 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
3041
3042         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3043         (_initialize_darwin_solib): Don't set
3044         darwin_so_ops.lookup_lib_global_symbol.
3045         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3046         set_gdbarch_iterate_over_objfiles_in_search_order.
3047         (elf_lookup_lib_symbol): Rename to...
3048         (svr4_iterate_over_objfiles_in_search_order): this, and update
3049         to iterate semantics.
3050         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3051         * solib.c (solib_global_lookup): Remove.
3052         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3053         (solib_global_lookup): Remove.
3054         * symtab.c (lookup_global_or_static_symbol): Remove call to
3055         solib_global_lookup.
3056
3057 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3058
3059         * NEWS: Move entries about default MI version now being
3060         version 3, and about the GDB/MI fix for multi-location
3061         breakpoints to the "since GDB 8.3" section.
3062
3063 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
3064
3065         GDB 8.3.1 released.
3066
3067 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
3068
3069         * NEWS: Mention that Cell/B.E. debugging support was removed.
3070         * MAINTAINERS: Remove spu target.
3071
3072         * config/djgpp/fnchange.lst: Remove entries for removed files.
3073
3074         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3075         spu-multiarch.o, and spu-tdep.o.
3076         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3077         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3078         spu-multiarch.c, and spu-tdep.c.
3079         * spu-linux-nat.c: Remove file.
3080         * spu-multiarch.c: Remove file.
3081         * spu-tdep.c: Remove file.
3082         * spu-tdep.h: Remove file.
3083         * solib-spu.c: Remove file.
3084         * solib-spu.h: Remove file.
3085
3086         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3087         * configure.nat (spu-linux): Remove.
3088         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3089         solib-multiarch.o from gdb_target_obs.
3090         (spu*-*-*): Remove.
3091
3092         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3093         feature flag.
3094         (ppc_linux_no_features): Update.
3095         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3096         Cell/B.E. support.
3097         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3098         (tdesc_powerpc_cell64l): Likewise.
3099         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3100         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3101         Cell/B.E. support.
3102         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3103         Do not include "features/rs6000/powerpc-cell32l.c" or
3104         "features/rs6000/powerpc-cell64l.c".
3105         (ppc_linux_spu_section): Remove.
3106         (ppc_linux_core_read_description): Remove Cell/B.E. support.
3107         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3108         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3109         (ppc_linux_spe_context_lookup): Remove.
3110         (ppc_linux_spe_context_inferior_created): Remove.
3111         (ppc_linux_spe_context_solib_loaded): Remove.
3112         (ppc_linux_spe_context_solib_unloaded): Remove.
3113         (ppc_linux_spe_context): Remove.
3114         (struct ppu2spu_cache): Remove.
3115         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3116         (struct ppu2spu_data): Remove.
3117         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3118         ppu2spu_unwind): Remove.
3119         (ppc_linux_init_abi): Remove Cell/B.E. support.
3120         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3121
3122         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3123         (rs6000/powerpc-cell64l-expedite): Likewise
3124         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3125         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3126         rs6000/powerpc-cell64l.xml.
3127         * features/rs6000/powerpc-cell32l.xml: Remove.
3128         * features/rs6000/powerpc-cell64l.xml: Likewise.
3129         * features/rs6000/powerpc-cell32l.c: Remove generated file.
3130         * features/rs6000/powerpc-cell64l.c: Likewise.
3131         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3132         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3133         * regformats/reg-spu.dat: Remove.
3134
3135         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3136         * corelow.c (struct spuid_list): Remove.
3137         (add_to_spuid_list): Remove.
3138         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3139         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3140         (remote_protocol_features): Remove associated entries.
3141         (_initialize_remote): No longer initialize them.
3142         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3143         * linux-nat.c (SPUFS_MAGIC): Remove.
3144         (linux_proc_xfer_spu): Remove.
3145         (spu_enumerate_spu_ids): Remove.
3146         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3147         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3148         (linux_make_corefile_notes): No longer call it.
3149
3150         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3151         (cooked_write_test): Likewise.
3152
3153 2019-09-20  Tom Tromey  <tom@tromey.com>
3154
3155         * NEWS: Mention case-sensitivity of TUI commands.
3156         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3157         (tui_set_win_height_command, parse_scrolling_args): Likewise.
3158         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3159
3160 2019-09-20  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-source.c (tui_source_window::set_contents): Use
3163         make_unique_xstrdup.
3164         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3165         make_unique_xstrdup.
3166
3167 2019-09-20  Tom Tromey  <tom@tromey.com>
3168
3169         * tui/tui-data.c: Remove separator comments.
3170         * tui/tui-layout.c: Remove separator comments.
3171         * tui/tui-win.c: Remove separator comments.
3172         * tui/tui-wingeneral.c: Remove separator comments.
3173
3174 2019-09-20  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui.h (strcat_to_buf): Don't declare.
3177         * tui/tui.c (strcat_to_buf): Remove.
3178
3179 2019-09-20  Tom Tromey  <tom@tromey.com>
3180
3181         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3182         from "fullname".
3183         * tui/tui-source.c (tui_source_window::set_contents)
3184         (tui_source_window::location_matches_p)
3185         (tui_source_window::maybe_update): Update.
3186
3187 2019-09-20  Tom Tromey  <tom@tromey.com>
3188
3189         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3190         Update.
3191         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3192         prefix.
3193         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3194         (tui_data_window::line_from_reg_element_no)
3195         (tui_data_window::first_reg_element_no_inline)
3196         (tui_data_window::show_registers)
3197         (tui_data_window::show_register_group)
3198         (tui_data_window::display_registers_from)
3199         (tui_data_window::display_registers_from_line)
3200         (tui_data_window::first_data_item_displayed)
3201         (tui_data_window::delete_data_content_windows)
3202         (tui_data_window::erase_data_content)
3203         (tui_data_window::do_scroll_vertical)
3204         (tui_data_window::refresh_window)
3205         (tui_data_window::check_register_values): Update.
3206
3207 2019-09-20  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3210         (struct tui_locator_window) <full_name, proc_name>: Now
3211         std::string.
3212         * tui/tui-stack.c (tui_locator_window::make_status_line)
3213         (tui_locator_window::set_locator_fullname)
3214         (tui_locator_window::set_locator_info): Update.
3215         * tui/tui-source.c (tui_source_window::set_contents)
3216         (tui_source_window::showing_source_p): Update.
3217
3218 2019-09-20  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3221         Don't call tui_locator_win_info_ptr.
3222
3223 2019-09-20  Tom Tromey  <tom@tromey.com>
3224
3225         * tui/tui-win.c (tui_resize_all): Don't call refresh.
3226
3227 2019-09-20  Tom Tromey  <tom@tromey.com>
3228
3229         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3230         height for locator.
3231         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3232         * tui/tui-layout.c (show_source_disasm_command, show_data)
3233         (show_source_or_disasm_and_command): Use 1 as height for locator.
3234
3235 2019-09-20  Tom Tromey  <tom@tromey.com>
3236
3237         * tui/tui.c (tui_enable): Update.
3238         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3239         Update.
3240         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3241         Update.
3242         * tui/tui-data.c (win_resized): Now bool.
3243         (tui_win_resized): Return bool.
3244         (tui_set_win_resized_to): Accept a bool.
3245
3246 2019-09-20  Tom Tromey  <tom@tromey.com>
3247
3248         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3249         Change type of "refresh_values_only".
3250         * tui/tui-regs.c (tui_data_window::show_register_group): Change
3251         type of "refresh_values_only".
3252
3253 2019-09-20  Tom Tromey  <tom@tromey.com>
3254
3255         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3256         std::string.
3257         (tui_disassemble): Add "pos" parameter.
3258         (tui_disasm_window::set_contents): Simplify.
3259
3260 2019-09-20  Tom Tromey  <tom@tromey.com>
3261
3262         * tui/tui-winsource.h (struct tui_source_window_base)
3263         <show_source_content>: Now private.
3264         * tui/tui-winsource.c
3265         (tui_source_window_base::show_source_content): Don't handle empty
3266         content case.
3267
3268 2019-09-20  Tom Tromey  <tom@tromey.com>
3269
3270         * tui/tui-layout.c (show_source_disasm_command)
3271         (show_source_or_disasm_and_command): Don't call
3272         show_source_content.
3273
3274 2019-09-20  Tom Tromey  <tom@tromey.com>
3275
3276         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3277         Declare.
3278         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3279         from tui_make_status_line.
3280         (tui_locator_window::rerender): Update.
3281
3282 2019-09-20  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-stack.c (tui_make_status_line): Return std::string.
3285         (tui_locator_window::rerender): Update.
3286
3287 2019-09-20  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-winsource.h (struct tui_source_window_base)
3290         <~tui_source_window_base>: Don't declare.
3291         <fullname>: Remove.
3292         * tui/tui-winsource.c (~tui_source_window_base): Remove.
3293         * tui/tui-source.h (struct tui_source_window) <fullname>: New
3294         member.
3295         * tui/tui-source.c (tui_source_window::set_contents): Update.
3296         (tui_source_window::location_matches_p)
3297         (tui_source_window::maybe_update): Update.
3298
3299 2019-09-20  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-winsource.h (~tui_source_element): Remove.
3302         (tui_source_element): Update.
3303         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3304         * tui/tui-winsource.c (tui_show_source_line): Update.
3305         * tui/tui-source.c (tui_source_window::set_contents): Update.
3306         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3307
3308 2019-09-20  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3311         declare.
3312         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3313         tui_clear_source_windows_detail.
3314         * tui/tui-winsource.h (struct tui_source_window_base)
3315         <clear_detail>: Don't declare.
3316         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3317         Remove.
3318         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3319
3320 2019-09-20  Tom Tromey  <tromey@adacore.com>
3321
3322         PR ada/24919:
3323         * block.c (contained_in): Fix final return value.
3324
3325 2019-09-20  Alan Modra  <amodra@gmail.com>
3326
3327         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3328         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3329         (read_indirect_string_from_dwz): Use bfd accessor.
3330         * dwarf2read.h (struct dwz_file <filename>): Likewise.
3331         * machoread.c (macho_symfile_read_all_oso): Likewise.
3332         * solib.c (solib_bfd_open): Likewise.
3333
3334 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3335
3336         * eval.c: Move declaration of overload_resolution to...
3337         * value.h: ...here.
3338
3339 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3340
3341         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3342         * arm-linux-tdep.c: Likewise.
3343         * arm-nbsd-nat.c: Likewise.
3344         * arm-tdep.h: Declare arm_apcs_32.
3345         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3346
3347 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
3348
3349         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3350         * dwarf2read.h: Declare dwarf_always_disassemble.
3351
3352 2019-09-19  Tom de Vries  <tdevries@suse.de>
3353
3354         PR gdb/25009
3355         * source-cache.c (source_cache::ensure): Catch exception thrown during
3356         construction of the highlighter.
3357
3358 2019-09-18  Alan Modra  <amodra@gmail.com>
3359
3360         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3361         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3362         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3363         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3364         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3365         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3366         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3367         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3368         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3369         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3370         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3371         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3372         * solib-spu.c, * solib-svr4.c, * solib-target.c,
3373         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3374         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3375         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3376         * mi/mi-interp.c: Update throughout for bfd section macro and
3377         function changes.
3378         * gcore (gcore_create_callback): Use bfd_set_section_lma.
3379         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3380
3381 2019-09-18  Tom Tromey  <tom@tromey.com>
3382
3383         * NEWS: Add entry.
3384         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
3385         call rl_initialize.
3386         (tui_enable): Do not call rl_initialize.
3387
3388 2019-09-18  Christian Groessler  <chris@groessler.org>
3389
3390         * alpha-linux-nat.c: Include gdbarch.h.
3391
3392 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
3393
3394         * ui-file.c: Include cli/cli-style.h.
3395         (term_cli_styling): Remove cli_styling declaration.
3396
3397 2019-09-18  Alan Modra  <amodra@gmail.com>
3398
3399         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3400         to bfd_asymbol_section.
3401
3402 2019-09-18  Alan Modra  <amodra@gmail.com>
3403
3404         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3405         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3406         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3407
3408 2019-09-18  Alan Modra  <amodra@gmail.com>
3409
3410         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3411         * spu-linux-nat.c (spu_bfd_open): Likewise.
3412
3413 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
3414
3415         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3416         to bool to match definition in dwarf2read.c.
3417
3418 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
3419
3420         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3421         (print_signatures): Likewise.
3422         (trust_pad_over_xvs): Likewise.
3423         * arch/aarch64-insn.c (aarch64_debug): Likewise.
3424         * arch/aarch64-insn.h (aarch64_debug): Likewise.
3425         * arm-linux-nat.c (arm_apcs_32): Likewise.
3426         * arm-linux-tdep.c (arm_apcs_32): Likewise.
3427         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3428         * arm-tdep.c (arm_debug): Likewise.
3429         (arm_apcs_32): Likewise.
3430         * auto-load.c (debug_auto_load): Likewise.
3431         (auto_load_gdb_scripts): Likewise.
3432         (global_auto_load): Likewise.
3433         (auto_load_local_gdbinit): Likewise.
3434         (auto_load_local_gdbinit_loaded): Likewise.
3435         * auto-load.h (global_auto_load): Likewise.
3436         (auto_load_local_gdbinit): Likewise.
3437         (auto_load_local_gdbinit_loaded): Likewise.
3438         * breakpoint.c (disconnected_dprintf): Likewise.
3439         (breakpoint_proceeded): Likewise.
3440         (automatic_hardware_breakpoints): Likewise.
3441         (always_inserted_mode): Likewise.
3442         (target_exact_watchpoints): Likewise.
3443         (_initialize_breakpoint): Update.
3444         * breakpoint.h (target_exact_watchpoints): Change to bool.
3445         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3446         * cli/cli-cmds.c (trace_commands): Likewise.
3447         * cli/cli-cmds.h (trace_commands): Likewise.
3448         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3449         to bool*.
3450         * cli/cli-logging.c (logging_overwrite): Change to bool.
3451         (logging_redirect): Likewise.
3452         (debug_redirect): Likewise.
3453         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3454         (struct boolean_option_def) <get_var_address_cb_>: Change return type
3455         to bool.
3456         <boolean_option_def>: Update.
3457         (struct flag_option_def): Change default type of Context to bool
3458         from int.
3459         <flag_option_def>: Change return type of var_address_cb_ to bool*.
3460         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3461         (get_setshow_command_value_string): Likewise.
3462         * cli/cli-style.c (cli_styling): Change to bool.
3463         (source_styling): Likewise.
3464         * cli/cli-style.h (source_styling): Likewise.
3465         (cli_styling): Likewise.
3466         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3467         to bool.
3468         * command.h (var_types): Update comment.
3469         (add_setshow_boolean_cmd): Change int* var argument to bool*.
3470         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3471         bool.
3472         (debug_compile_cplus_scopes): Likewise.
3473         * compile/compile-internal.h (compile_debug): Likewise.
3474         * compile/compile.c (compile_debug): Likewise.
3475         (struct compile_options) <raw>: Likewise.
3476         * cp-support.c (catch_demangler_crashes): Likewise.
3477         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3478         (usr_cmd_cris_dwarf2_cfi): Likewise.
3479         * csky-tdep.c (csky_debug): Likewise.
3480         * darwin-nat.c (enable_mach_exceptions): Likewise.
3481         * dcache.c (dcache_enabled_p): Likewise.
3482         * defs.h (info_verbose): Likewise.
3483         * demangle.c (demangle): Likewise.
3484         (asm_demangle): Likewise.
3485         * dwarf-index-cache.c (debug_index_cache): Likewise.
3486         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3487         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3488         * dwarf2read.c (check_physname): Likewise.
3489         (use_deprecated_index_sections): Likewise.
3490         (dwarf_always_disassemble): Likewise.
3491         * eval.c (overload_resolution): Likewise.
3492         * event-top.c (set_editing_cmd_var): Likewise.
3493         (exec_done_display_p): Likewise.
3494         * event-top.h (set_editing_cmd_var): Likewise.
3495         (exec_done_display_p): Likewise.
3496         * exec.c (write_files): Likewise.
3497         * fbsd-nat.c (debug_fbsd_lwp): Likewise
3498         (debug_fbsd_nat): Likewise.
3499         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3500         Likewise.
3501         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3502         <backtrace_past_entry> Likewise.
3503         * gdb-demangle.h (demangle): Likewise.
3504         (asm_demangle): Likewise.
3505         * gdb_bfd.c (bfd_sharing): Likewise.
3506         * gdbcore.h (write_files): Likewise.
3507         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3508         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3509         * gdbthread.h (print_thread_events): Likewise.
3510         * gdbtypes.c (opaque_type_resolution): Likewise.
3511         (strict_type_checking): Likewise.
3512         * gnu-nat.c (gnu_debug_flag): Likewise.
3513         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3514         * guile/scm-param.c (pascm_variable): Add boolval.
3515         (add_setshow_generic): Update.
3516         (pascm_param_value): Update.
3517         (pascm_set_param_value_x): Update.
3518         * hppa-tdep.c (hppa_debug): Change to bool..
3519         * infcall.c (may_call_functions_p): Likewise.
3520         (coerce_float_to_double_p): Likewise.
3521         (unwind_on_signal_p): Likewise.
3522         (unwind_on_terminating_exception_p): Likewise.
3523         * infcmd.c (startup_with_shell): Likewise.
3524         * inferior.c (print_inferior_events): Likewise.
3525         * inferior.h (startup_with_shell): Likewise.
3526         (print_inferior_events): Likewise.
3527         * infrun.c (step_stop_if_no_debug): Likewise.
3528         (detach_fork): Likewise.
3529         (debug_displaced): Likewise.
3530         (disable_randomization): Likewise.
3531         (non_stop): Likewise.
3532         (non_stop_1): Likewise.
3533         (observer_mode): Likewise.
3534         (observer_mode_1): Likewise.
3535         (set_observer_mode): Update.
3536         (sched_multi): Change to bool.
3537         * infrun.h (debug_displaced): Likewise.
3538         (sched_multi): Likewise.
3539         (step_stop_if_no_debug): Likewise.
3540         (non_stop): Likewise.
3541         (disable_randomization): Likewise.
3542         * linux-tdep.c (use_coredump_filter): Likewise.
3543         (dump_excluded_mappings): Likewise.
3544         * linux-thread-db.c (auto_load_thread_db): Likewise.
3545         (check_thread_db_on_load): Likewise.
3546         * main.c (captured_main_1): Update.
3547         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3548         xx2_opt, boolean_opt>: Change to bool.
3549         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3550         * maint.c (maintenance_profile_p): Likewise.
3551         (per_command_time): Likewise.
3552         (per_command_space): Likewise.
3553         (per_command_symtab): Likewise.
3554         * memattr.c (inaccessible_by_default): Likewise.
3555         * mi/mi-main.c (mi_async): Likewise.
3556         (mi_async_1): Likewise.
3557         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3558         * nat/fork-inferior.h (startup_with_shell): Likewise.
3559         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3560         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3561         * nios2-tdep.c (nios2_debug): Likewise.
3562         * or1k-tdep.c (or1k_debug): Likewise.
3563         * parse.c (parser_debug): Likewise.
3564         * parser-defs.h (parser_debug): Likewise.
3565         * printcmd.c (print_symbol_filename): Likewise.
3566         * proc-api.c (procfs_trace): Likewise.
3567         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3568         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3569         (set_parameter_value): Update.
3570         (add_setshow_generic): Update.
3571         * python/py-value.c (copy_py_bool_obj): Change argument from int*
3572         to bool*.
3573         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3574         int*.
3575         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3576         * record-btrace.c (record_btrace_target::store_registers): Update.
3577         * record-full.c (record_full_memory_query): Change to bool.
3578         (record_full_stop_at_limit): Likewise.
3579         * record-full.h (record_full_memory_query): Likewise.
3580         * remote-notif.c (notif_debug): Likewise.
3581         * remote-notif.h (notif_debug): Likewise.
3582         * remote.c (use_range_stepping): Likewise.
3583         (interrupt_on_connect): Likewise.
3584         (remote_break): Likewise.
3585         * ser-tcp.c (tcp_auto_retry): Likewise.
3586         * ser-unix.c (serial_hwflow): Likewise.
3587         * skip.c (debug_skip): Likewise.
3588         * solib-aix.c (solib_aix_debug): Likewise.
3589         * spu-tdep.c (spu_stop_on_load_p): Likewise.
3590         (spu_auto_flush_cache_p): Likewise.
3591         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3592         Likewise.
3593         (struct info_print_options) <quiet>: Likewise.
3594         * symfile-debug.c (debug_symfile): Likewise.
3595         * symfile.c (auto_solib_add): Likewise.
3596         (separate_debug_file_debug): Likewise.
3597         * symfile.h (auto_solib_add): Likewise.
3598         (separate_debug_file_debug): Likewise.
3599         * symtab.c (basenames_may_differ): Likewise.
3600         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3601         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3602         (struct info_types_options) <quiet>: Likewise.
3603         * symtab.h (demangle): Likewise.
3604         (basenames_may_differ): Likewise.
3605         * target-dcache.c (stack_cache_enabled_1): Likewise.
3606         (code_cache_enabled_1): Likewise.
3607         * target.c (trust_readonly): Likewise.
3608         (may_write_registers): Likewise.
3609         (may_write_memory): Likewise.
3610         (may_insert_breakpoints): Likewise.
3611         (may_insert_tracepoints): Likewise.
3612         (may_insert_fast_tracepoints): Likewise.
3613         (may_stop): Likewise.
3614         (auto_connect_native_target): Likewise.
3615         (target_stop_and_wait): Update.
3616         (target_async_permitted): Change to bool.
3617         (target_async_permitted_1): Likewise.
3618         (may_write_registers_1): Likewise.
3619         (may_write_memory_1): Likewise.
3620         (may_insert_breakpoints_1): Likewise.
3621         (may_insert_tracepoints_1): Likewise.
3622         (may_insert_fast_tracepoints_1): Likewise.
3623         (may_stop_1): Likewise.
3624         * target.h (target_async_permitted): Likewise.
3625         (may_write_registers): Likewise.
3626         (may_write_memory): Likewise.
3627         (may_insert_breakpoints): Likewise.
3628         (may_insert_tracepoints): Likewise.
3629         (may_insert_fast_tracepoints): Likewise.
3630         (may_stop): Likewise.
3631         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3632         (make_thread_apply_all_options_def_group): Change argument from int*
3633         to bool*.
3634         (thread_apply_all_command): Update.
3635         (print_thread_events): Change to bool.
3636         * top.c (confirm): Likewise.
3637         (command_editing_p): Likewise.
3638         (history_expansion_p): Likewise.
3639         (write_history_p): Likewise.
3640         (info_verbose): Likewise.
3641         * top.h (confirm): Likewise.
3642         (history_expansion_p): Likewise.
3643         * tracepoint.c (disconnected_tracing): Likewise.
3644         (circular_trace_buffer): Likewise.
3645         * typeprint.c (print_methods): Likewise.
3646         (print_typedefs): Likewise.
3647         * utils.c (debug_timestamp): Likewise.
3648         (sevenbit_strings): Likewise.
3649         (pagination_enabled): Likewise.
3650         * utils.h (sevenbit_strings): Likewise.
3651         (pagination_enabled): Likewise.
3652         * valops.c (overload_resolution): Likewise.
3653         * valprint.h (struct value_print_options) <prettyformat_arrays,
3654         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3655         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3656         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3657         Likewise.
3658         * windows-nat.c (new_console): Likewise.
3659         (cygwin_exceptions): Likewise.
3660         (new_group): Likewise.
3661         (debug_exec): Likewise.
3662         (debug_events): Likewise.
3663         (debug_memory): Likewise.
3664         (debug_exceptions): Likewise.
3665         (useshell): Likewise.
3666         * windows-tdep.c (maint_display_all_tib): Likewise.
3667         * xml-support.c (debug_xml): Likewise.
3668
3669 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
3670
3671         * source.c (prepare_path_for_appending): New function.
3672         (openp): Make use of new function.
3673         (find_and_open_source): Search for the compilation directory and
3674         source file as a relative path beneath the directory search path.
3675
3676 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3677
3678         * source-cache.c (source_cache::get_line_charpos): Catch
3679         exceptions and return false, this matches the behaviour documented
3680         in the header file.
3681
3682 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
3683
3684         * ada-tasks.c (info_task): Remove quoting of the task's name.
3685
3686 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
3687
3688         * symfile.c (auto_solib_add): Replace comment with a reference
3689         to the header file.
3690
3691 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
3692
3693         * NEWS: Mention that gdb can now be compiled with Python 3
3694         on Windows.
3695
3696 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * maint.c (maint_print_section_data::maint_print_section_data):
3699         Force use of 'float log10 (float)' by casting the argument to
3700         float.
3701
3702 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3703
3704         * maint.c: Add 'cmath' include.
3705         (struct maint_print_section_data): New structure.
3706         (print_section_index): New function.
3707         (print_bfd_section_info): Add header comment, small whitespace
3708         cleanup, and update to call new print_section_index function.
3709         (print_objfile_section_info): Likewise.
3710         (maint_obj_section_from_bfd_section): New function.
3711         (print_bfd_section_info_maybe_relocated): New function.
3712         (maintenance_info_sections): Add header comment, always use
3713         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
3714
3715 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3716
3717         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
3718         inner scope, add check that the objfile has psymtabs before
3719         checking psymtabs_addrmap.
3720         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
3721
3722 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3723
3724         * NEWS: Announce that Ada task names are now shown at more places,
3725         and between quotes (except in info task output).
3726         * gdb/ada-tasks.c (task_to_str): New function.
3727         (display_current_task_id): Call task_to_str.
3728         (task_command_1): Likewise.
3729         (print_ada_task_info): In non-mi mode, Properly align headers and data
3730         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
3731
3732 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3733
3734         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
3735         prstatus.pr_lwp.pr_info instead of making it up.
3736
3737 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3738
3739         * auto-load.c (auto_load_expand_dir_vars): Update.
3740         * defs.h (gdb_datadir): Change to std::string.
3741         (python_libdir): Likewise.
3742         (relocate_gdb_directory): Change return type to std::string.
3743         * guile/guile.c (gdbscm_data_directory): Update.
3744         (initialize_scheme_side): Update.
3745         * jit.c (jit_reader_dir): Change to std::string.
3746         (jit_reader_load_command): Update.
3747         * main.c (gdb_datadir): Change to std::string.
3748         (python_libdir): Likewise.
3749         (set_gdb_data_directory): Update.
3750         (relocate_path): Change to return std::string.
3751         (relocate_gdb_directory): Change to return std::string.
3752         (relocate_gdbinit_path_maybe_in_datadir): Update.
3753         (captured_main_1): Update.
3754         * python/python.c (do_start_initialization): Update.
3755         * top.c (show_gdb_datadir): Update.
3756         * xml-syscall.c (xml_init_syscalls_info): Update.
3757         (init_syscalls_info): Update.
3758
3759 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3760
3761         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
3762         out of get_init_files.
3763         (get_init_files): Update.
3764
3765 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3766
3767         * main.c (get_init_files): Change to use std::string.
3768         (captured_main_1): Update.
3769         (print_gdb_help): Update.
3770
3771 2019-09-11  Ali Tamur  <tamur@google.com>
3772
3773         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
3774         implementation.
3775
3776 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
3777
3778         * dbxread.c (read_dbx_symtab): Update.
3779         * dwarf2read.c (load_partial_dies): Update.
3780         * mdebugread.c (parse_partial_symbols): Update.
3781         (handle_psymbol_enumerators): Update.
3782         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
3783         * psymtab.c (add_psymbol_to_bcache): Likewise.
3784         (add_psymbol_to_list): Likewise.
3785         * symtab.c (symbol_set_names): Likewise.
3786         * symtab.h (symbol_set_names): Likewise.
3787         * xcoffread.c (scan_xcoff_symtab): Update.
3788
3789 2019-09-11  Tom Tromey  <tom@tromey.com>
3790
3791         * symfile-mem.c (symbol_file_add_from_memory): Use
3792         bfd_set_filename.
3793         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
3794         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
3795
3796 2019-09-10  Tom Tromey  <tromey@adacore.com>
3797
3798         * dwarf-index-write.c (write_psymbols): Extend error message.
3799         (debug_names::insert): Add Ada code.
3800         (debug_names::write_psymbols): Remove Ada check.
3801         (debug_names) <m_string_obstack>: New member.
3802         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
3803         (gdb_index_symbol_name_matcher::matches): Remove.
3804         (mapped_index_base::find_name_components_bounds): Add "lang"
3805         parameter.
3806         (mapped_index_base::build_name_components): Also split names
3807         according to Ada syntax.
3808         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
3809         type of "match_callback".
3810         (check_match, check_find_bounds_finds)
3811         (dw2_expand_symtabs_matching): Update.
3812         (dw2_debug_names_iterator): Add new constructor.
3813         (dw2_debug_names_map_matching_symbols): New function.
3814         (dw2_debug_names_expand_symtabs_matching): Update.
3815         (dwarf2_debug_names_functions): Use
3816         dw2_debug_names_map_matching_symbols.
3817
3818 2019-09-10  Tom Tromey  <tromey@adacore.com>
3819
3820         * dwarf2read.c (dw2_get_file_names_reader): Add the
3821         CU's file name to the results.
3822
3823 2019-09-10  Tom Tromey  <tromey@adacore.com>
3824
3825         * ada-lang.c (add_nonlocal_symbols): Combine calls to
3826         map_matching_symbols.  Update.
3827         * dwarf2read.c (dw2_map_matching_symbols): Update.
3828         * psymtab.c (match_partial_symbol): Change type; update.
3829         (psym_map_matching_symbols): Likewise.
3830         * symfile-debug.c (debug_qf_map_matching_symbols): Change
3831         type; update.
3832         * symfile.h (struct quick_symbol_functions)
3833         <map_matching_symbols>: Change "name" to be a lookup_name_info.
3834         Remove "match".
3835
3836 2019-09-10  Tom Tromey  <tromey@adacore.com>
3837
3838         * psymtab.c (map_block): Remove.
3839         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
3840         * symtab.c (iterate_over_symbols_terminated): New function.
3841         * symtab.c (iterate_over_symbols_terminated): Declare.
3842
3843 2019-09-10  Tom Tromey  <tromey@adacore.com>
3844
3845         * ada-lang.c (ada_iterate_over_symbols): Return bool.
3846         * language.h (struct language_defn) <la_iterate_over_symbols>:
3847         Return bool.
3848         * symtab.c (iterate_over_symbols): Return bool.
3849         * symtab.h (iterate_over_symbols): Return bool.
3850
3851 2019-09-10  Tom Tromey  <tromey@adacore.com>
3852
3853         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
3854         (add_nonlocal_symbols): Update.
3855         * dwarf2read.c (dw2_map_matching_symbols): Change type.
3856         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
3857         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
3858         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
3859         Change type of "callback".  Remove "data".
3860
3861
3862 2019-09-09  Ali Tamur  <tamur@google.com>
3863
3864         * dwarf2read.c (comp_unit_head): Update comment.
3865         (dwarf2_dwo_name): New function declaration.
3866         (dwarf_unit_type_name): New function declaration.
3867         (read_comp_unit_head): Add support for new compilation units,
3868         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
3869         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
3870         (currently named as "signature") in their header. Also clarify error
3871         messages.
3872         (lookup_dwo_id): New function. Returns the dwo id of the given
3873         compile unit.
3874         (lookup_dwo_unit): Use the new lookup_dwo_id function.
3875         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
3876         functions.
3877         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
3878         (dwarf2_dwo_name): Get the dwo name if present.
3879         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
3880         purposes.
3881
3882 2019-09-09  Tom Tromey  <tom@tromey.com>
3883
3884         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
3885
3886 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3887
3888         * python/python.c (do_start_initialization): Make progname_copy static,
3889         to avoid a leak report.
3890
3891 2019-09-08  Tom Tromey  <tom@tromey.com>
3892
3893         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
3894
3895 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
3896
3897         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
3898         Change type to gdb::optional<block_enum>.
3899         (dw2_symtab_iter_init): Change block_index parameter type
3900         to gdb::optional<block_enum>.
3901         (dw2_lookup_symbol): Change block_index parameter
3902         type to block_enum.c
3903         (dw2_debug_names_lookup_symbol): Likewise.
3904         * psymtab.c (psym_lookup_symbol): Likewise.
3905         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
3906         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
3907         Likewise.
3908
3909 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
3910
3911         * defs.h (relocate_gdb_directory): Change int to bool in
3912         signature and rename flag to relocatable.
3913         * main.c (relocate_path): Likewise.
3914         (relocate_gdb_directory): Likewise.
3915
3916 2019-09-06  Alan Modra  <amodra@gmail.com>
3917
3918         * coffread.c (coff_symfile_read): Constify filename variable.
3919         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
3920         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
3921         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
3922         * solib.c (reload_shared_libraries_1): Likewise.
3923         * symfile.c (reread_symbols): Likewise.
3924         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
3925         * solib-darwin.c (darwin_bfd_open): Likewise.
3926         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
3927
3928 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3929
3930         * psymtab.c (print_partial_symbols): Handle missing domain_enum
3931         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
3932
3933 2019-09-03  Tom Tromey  <tromey@adacore.com>
3934
3935         * ada-valprint.c (ada_val_print_num): Don't recurse for range
3936         types.
3937         (has_negatives): Unbias a range type bound.
3938         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
3939         * gdbtypes.c (operator==): Handle new field.
3940         (create_range_type): Add "bias" parameter.
3941         (create_static_range_type, resolve_dynamic_range): Update.
3942         * gdbtypes.h (struct range_bounds) <bias>: New member.
3943         (create_range_type): Add bias parameter.
3944         * printcmd.c (print_scalar_formatted): Unbias range types.
3945         * value.c (unpack_long): Unbias range types.
3946         (pack_long): Bias range types.
3947
3948 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3949
3950         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
3951         probe arguments.
3952
3953 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3954
3955         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
3956         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
3957         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
3958         (compile_probe_arg): Likewise.
3959         * probe.h (get_argument_count): Likewise.
3960         * solib-svr4.c (solib_event_probe_action): Likewise.
3961         * stap-probe.c (stap_probe::get_argument_count): Likewise.
3962
3963 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
3964
3965         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
3966         code to here...
3967         (svr4_create_solib_event_breakpoints): ...from here.
3968
3969 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
3970
3971         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
3972         suffix from warning message.
3973
3974 2019-08-30  Tom Tromey  <tom@tromey.com>
3975
3976         * tui/tui-winsource.h (struct tui_source_window_base)
3977         <refresh_all>: Don't declare.
3978         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
3979         Remove.
3980         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
3981         tui_show_locator_content.
3982         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
3983         declare.
3984         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
3985         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
3986         declare.
3987
3988 2019-08-30  Tom Tromey  <tom@tromey.com>
3989
3990         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
3991
3992 2019-08-30  Tom Tromey  <tom@tromey.com>
3993
3994         * tui/tui-stack.c (_initialize_tui_stack): Move later.
3995         Remove unnecessary forward declarations.
3996
3997 2019-08-30  Tom Tromey  <tom@tromey.com>
3998
3999         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4000         rerender.
4001         (tui_update_locator_fullname, tui_show_frame_info): Don't call
4002         tui_show_locator_content.
4003
4004 2019-08-30  Tom Tromey  <tom@tromey.com>
4005
4006         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
4007         (tui_locator_window::rerender): Rewrite using body of previous
4008         tui_show_locator_content.
4009
4010 2019-08-30  Tom Tromey  <tom@tromey.com>
4011
4012         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4013         set_locator_fullname>: New methods.
4014         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4015         Rename from tui_set_locator_fullname.
4016         (tui_locator_window::set_locator_info): Rename from
4017         tui_set_locator_info.  Return bool.
4018         (tui_update_locator_fullname, tui_show_frame_info): Update.
4019
4020 2019-08-30  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4023
4024 2019-08-30  Tom Tromey  <tom@tromey.com>
4025
4026         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4027         call touchwin.
4028
4029 2019-08-30  Tom Tromey  <tom@tromey.com>
4030
4031         * tui/tui-wingeneral.c (box_win): Assume win_info and
4032         win_info->handle cannot be NULL.
4033
4034 2019-08-30  Tom Tromey  <tom@tromey.com>
4035
4036         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4037         refresh_window>: Declare.
4038         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4039         resize.
4040         (tui_data_item_window::rerender): Rename from
4041         tui_display_register.
4042         (tui_data_item_window::refresh_window): New method.
4043         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4044         no-op.
4045
4046 2019-08-30  Tom Tromey  <tom@tromey.com>
4047
4048         * tui/tui-regs.h (struct tui_data_window) <regs_content,
4049         regs_column_count, current_group>: Move later.  Now private.
4050         <get_current_group>: New method.
4051         * tui/tui-regs.c (tui_reg_command): Update.
4052         * tui/tui-layout.c (tui_set_layout): Update.
4053
4054 2019-08-30  Tom Tromey  <tom@tromey.com>
4055
4056         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4057         (tui_data_window::rerender): Don't call
4058         check_and_display_highlight_if_needed.
4059         (tui_data_window::refresh_all): Remove call to
4060         erase_data_content.
4061
4062 2019-08-30  Tom Tromey  <tom@tromey.com>
4063
4064         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4065         (tui_data_window::display_registers_from)
4066         (tui_data_window::display_reg_element_at_line)
4067         (tui_data_window::display_registers_from_line): Remove checks of
4068         "empty".
4069
4070 2019-08-30  Tom Tromey  <tom@tromey.com>
4071
4072         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4073         Don't declare.
4074         * tui/tui-regs.c (tui_data_window::show_registers): Call
4075         rerender.
4076         (tui_data_window::rerender): Rename from display_all_data.
4077         (tui_data_window::rerender): Remove old implementation.
4078
4079 2019-08-30  Tom Tromey  <tom@tromey.com>
4080
4081         * tui/tui-regs.c (tui_data_window::display_all_data): Change
4082         text.
4083         * tui/tui-data.h (NO_DATA_STRING): Remove define.
4084
4085 2019-08-29  Bernhard Wodok  <barto@gmx.net>
4086             Sergio Durigan Junior  <sergiodj@redhat.com>
4087
4088         PR win32/24284
4089         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4090
4091 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4092
4093         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4094         when searching for types.
4095
4096 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
4097
4098         * f-lang.c (f_language_defn): Use f_print_typedef.
4099         * f-lang.h (f_print_typedef): Declare.
4100         * f-typeprint.c (f_print_typedef): Define.
4101
4102 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
4103
4104         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4105
4106 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         * cli/cli-utils.c (info_print_options_defs): Delete.
4109         (make_info_print_options_def_group): Delete.
4110         (extract_info_print_options): Delete.
4111         (info_print_command_completer): Delete.
4112         (info_print_args_help): Add extra parameter, and optionally
4113         include text about -n flag.
4114         * cli/cli-utils.h (struct info_print_options): Delete.
4115         (extract_info_print_options): Delete declaration.
4116         (info_print_command_completer): Delete declaration.
4117         (info_print_args_help): Add extra parameter, extend header
4118         comment.
4119         * python/python.c (gdbpy_rbreak): Pass additional parameter to
4120         search_symbols.
4121         * stack.c (struct info_print_options): New type.
4122         (info_print_options_defs): New file scoped variable.
4123         (make_info_print_options_def_group): New static function.
4124         (info_print_command_completer): New static function.
4125         (info_locals_command): Update to use new local functions.
4126         (info_args_command): Likewise.
4127         (_initialize_stack): Add extra parameter to calls to
4128         info_print_args_help.
4129         * symtab.c (search_symbols): Add extra parameter, use this to
4130         possibly excluse non-debug symbols.
4131         (symtab_symbol_info): Add extra parameter, which is passed on to
4132         search_symbols.
4133         (struct info_print_options): New type.
4134         (info_print_options_defs): New file scoped variable.
4135         (make_info_print_options_def_group): New static function.
4136         (info_print_command_completer): New static function.
4137         (info_variables_command): Update to use local functions, and pass
4138         extra parameter through to symtab_symbol_info.
4139         (info_functions_command): Likewise.
4140         (info_types_command): Pass additional argument through to
4141         symtab_symbol_info.
4142         (rbreak_command): Pass extra argument to search_symbols.
4143         (_initialize_symtab): Add extra arguments for calls to
4144         info_print_args_help, and update help text for 'info variables',
4145         'whereis', and 'info functions' commands.
4146         * symtab.h (search_symbols): Add extra argument to declaration.
4147         * NEWS: Mention new flags.
4148
4149 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
4150
4151         * symtab.c (lookup_static_symbol): Call the new function (and move
4152         it down to be next to lookup_global_symbol).
4153         (struct global_sym_lookup_data): Add block_enum member and rename to...
4154         (struct global_or_static_sym_lookup_data): ...this.
4155         (lookup_symbol_global_iterator_cb): Pass block_index instead of
4156         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4157         (lookup_symbol_global_or_static_iterator_cb): ...this.
4158         (lookup_global_or_static_symbol): New function.
4159         (lookup_global_symbol): Call new function.
4160
4161 2019-08-26  Tom de Vries  <tdevries@suse.de>
4162
4163         PR c++/24852
4164         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4165         when pc_probe.prob == NULL.
4166
4167 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4168
4169         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4170         variable symbol_linkage to symbol_linkage_.
4171
4172 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
4173
4174         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4175         represent whether the symbol is static, dynamic, or we don't
4176         know.
4177
4178 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
4179
4180         * gdb/rx-tdep.c (rx_register_names): New.
4181         (rx_register_name): Delete.
4182         (rx_psw_type): Delete.
4183         (rx_fpsw_type): Delete.
4184         (rx_register_type): Delete.
4185         (rx_gdbarch_init): Convert target-descriptions.
4186         (_initialize_rx_tdep): Add initialize_tdesc_rx.
4187         * gdb/features/Makefile: Add rx.xml.
4188         * gdb/features/rx.xml: New.
4189         * gdb/features/rx.c: Generated.
4190         * gdb/NEWS: Mention target description support.
4191
4192 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4193
4194         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4195         *slot_ptr.
4196
4197 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
4198
4199         * configure.ac: Don't check for 'dlfcn.h' (moved to
4200         gdbsupport/common.m4).
4201         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4202         'gdbsupport/'.
4203         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4204         * compile/compile-c-support.c: Include
4205         'gdbsupport/gdb-dlfcn.h'.
4206         * gdbsupport/common.m4: Check for 'dlfcn.h'.
4207         * gdb-dlfcn.c: Move to...
4208         * gdbsupport/gdb-dlfcn.c: ... here.
4209         * gdb-dlfcn.h: Move to...
4210         * gdbsupport/gdb-dlfcn.h: ... here.
4211
4212 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
4213
4214         * nios2-tdep.c (struct reg_value): Improve comments.  Make
4215         the offset field signed.
4216
4217 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
4218
4219         * python/lib/gdb/__init__.py (_execute_file): New function.
4220         * python/python.c (python_run_simple_file): Call gdb._execute_file
4221         on Windows.
4222
4223 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
4224
4225         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4226         all uses as this was never set to anything but a zero value.
4227
4228 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
4229
4230         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4231
4232 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
4233
4234         * tui/tui-data.h (tui_gen_win_info): Add an =default
4235         move constructor, required by some GCC versions.
4236
4237 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
4238
4239         * go32-nat.c (go32_sysinfo): Add hygon_p.
4240
4241 2019-08-20  Tom Tromey  <tom@tromey.com>
4242
4243         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4244         line_from_reg_element_no, first_reg_element_no_inline,
4245         display_all_data, delete_data_content_windows,
4246         erase_data_content>: Now private.
4247
4248 2019-08-20  Tom Tromey  <tom@tromey.com>
4249
4250         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4251         (tui_unhighlight_win, tui_highlight_win)
4252         (tui_win_info::make_window): Update.
4253         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4254
4255 2019-08-20  Tom Tromey  <tom@tromey.com>
4256
4257         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4258         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4259         (MAX_PID_WIDTH): Move to tui-stack.c.
4260         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4261         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4262         (MAX_PID_WIDTH): Move from tui-data.h.
4263
4264 2019-08-20  Tom Tromey  <tom@tromey.com>
4265
4266         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4267         * tui/tui-wingeneral.c (box_win): Change type of win_info.
4268         (box_win): Update.
4269         (tui_gen_win_info::make_window): Rename from tui_make_window.
4270         (tui_win_info::make_window): New method.
4271         (tui_gen_win_info::make_visible): Update.
4272         * tui/tui-source.c (tui_source_window::set_contents): Update.
4273         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4274         (tui_data_window::display_registers_from): Update.
4275         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4276         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4277         Declare.
4278         <can_box>: Remove.
4279         <title>: Remove.
4280         (struct tui_win_info) <make_window>: Declare.
4281         <can_box>: Now virtual.
4282         <title>: New member.
4283         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4284         * tui/tui-command.c (tui_cmd_window::resize): Update.
4285
4286 2019-08-20  Tom Tromey  <tom@tromey.com>
4287
4288         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4289         * tui/tui-regs.c (tui_data_window::show_registers): Update.
4290         (tui_data_window::check_register_values): Update.
4291
4292 2019-08-20  Tom Tromey  <tom@tromey.com>
4293
4294         * tui/tui-regs.h (struct tui_data_window): Use
4295         DISABLE_COPY_AND_ASSIGN.
4296         <regs_content>: Change type, removing unique_ptr.
4297         <tui_data_window>: Add move constructor.
4298         * tui/tui-regs.c (tui_data_window::show_registers)
4299         (tui_data_window::show_register_group)
4300         (tui_data_window::display_registers_from)
4301         (tui_data_window::display_registers_from)
4302         (tui_data_window::first_data_item_displayed)
4303         (tui_data_window::delete_data_content_windows)
4304         (tui_data_window::rerender, tui_data_window::refresh_window)
4305         (tui_data_window::check_register_values): Update.
4306
4307 2019-08-20  Tom Tromey  <tom@tromey.com>
4308
4309         * tui/tui-regs.h (struct tui_data_window) <show_registers,
4310         show_register_group>: Declare.
4311         (tui_show_register_group): Don't declare.
4312         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4313         tui_show_registers.
4314         (tui_data_window::show_register_group): Rename from
4315         tui_show_register_group.
4316         (tui_data_window::check_register_values, tui_reg_command):
4317         Update.
4318         * tui/tui-layout.c (tui_set_layout): Update.
4319
4320 2019-08-20  Tom Tromey  <tom@tromey.com>
4321
4322         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4323         Declare.
4324         (tui_check_register_values): Don't declare.
4325         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4326         from tui_check_register_values.
4327         * tui/tui-hooks.c (tui_register_changed): Update.
4328
4329 2019-08-20  Tom Tromey  <tom@tromey.com>
4330
4331         * tui/tui-regs.c (tui_reg_layout): Move later.
4332         (tui_show_registers): Don't enable TUI mode or change layout.
4333
4334 2019-08-20  Tom Tromey  <tom@tromey.com>
4335
4336         * tui/tui-regs.h (struct tui_data_item_window)
4337         <~tui_data_item_window>: Remove.
4338         <content>: Now a unique_xmalloc_ptr.
4339         * tui/tui-regs.c (tui_register_format): Return a
4340         unique_xmalloc_ptr.
4341         (tui_get_register): Update.
4342         (~tui_data_item_window): Remove.
4343         (tui_data_window::display_registers_from, tui_display_register):
4344         Update.
4345         * tui/tui-io.h (tui_expand_tabs): Update.
4346         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4347         Remove "col" parameter.
4348
4349 2019-08-20  Tom Tromey  <tom@tromey.com>
4350
4351         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4352         field.
4353         * tui/tui-regs.c (~tui_data_item_window): Update.
4354
4355 2019-08-20  Tom Tromey  <tom@tromey.com>
4356
4357         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4358         earlier.
4359
4360 2019-08-20  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4363
4364 2019-08-20  Tom Tromey  <tom@tromey.com>
4365
4366         * tui/tui-source.h (struct tui_source_window): Update.
4367         * tui/tui-regs.c (tui_show_registers): Update.
4368         * tui/tui-disasm.h (struct tui_disasm_window): Update.
4369         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4370         (NO_REGS_STRING): Remove defines.
4371
4372 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
4373
4374         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4375         unnecessary thread walk if remote doesn't support the packet.
4376
4377 2019-08-19  Tom Tromey  <tromey@adacore.com>
4378
4379         * python/py-value.c (value_has_field): Fix indentation.
4380
4381 2019-08-19  Tom Tromey  <tromey@adacore.com>
4382
4383         * printcmd.c (do_one_display, info_display_command): Update.
4384         * block.h (contained_in): Return bool.  Add allow_nested
4385         parameter.
4386         * block.c (contained_in): Return bool.  Add allow_nested
4387         parameter.
4388
4389 2019-08-19  Tom Tromey  <tom@tromey.com>
4390
4391         * configure: Rebuild.
4392         * configure.ac: Disallow the combination of -static-libstdc++ and
4393         source highlight.
4394         * source-cache.c (get_language_name): Handle rust.
4395         (source_cache::get_source_lines): Ignore highlighting exceptions.
4396
4397 2019-08-16  Tom Tromey  <tom@tromey.com>
4398
4399         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4400         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4401         (struct tui_source_window_base) <make_visible, refresh_window,
4402         resize>: Remove methods.
4403         <execution_info>: Remove field.
4404         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4405         (tui_show_source_line, tui_source_window_base)
4406         (~tui_source_window_base): Update.
4407         (tui_source_window_base::resize)
4408         (tui_source_window_base::make_visible)
4409         (tui_source_window_base::refresh_window): Remove.
4410         (tui_source_window_base::update_exec_info): Update.
4411         * tui/tui-source.c (tui_source_window::set_contents): Update.
4412         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4413
4414 2019-08-16  Tom Tromey  <tom@tromey.com>
4415
4416         * tui/tui-hooks.c (tui_remove_hooks): Don't set
4417         deprecated_query_hook.
4418
4419 2019-08-16  Tom Tromey  <tom@tromey.com>
4420
4421         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4422         (tui_update_source_windows_with_line): Update.
4423         * tui/tui-source.h (struct tui_source_window)
4424         <show_symtab_source>: Declare.
4425         (tui_show_symtab_source): Don't declare.
4426         * tui/tui-source.c (tui_show_symtab_source): Rename from
4427         tui_show_symtab_source.
4428
4429 2019-08-16  Tom Tromey  <tom@tromey.com>
4430
4431         * tui/tui-winsource.h (struct tui_source_window_base)
4432         <set_contents>: Declare.
4433         * tui/tui-winsource.c
4434         (tui_source_window_base::update_source_window_as_is): Update.
4435         * tui/tui-source.h (struct tui_source_window) <set_contents>:
4436         Declare.
4437         (tui_set_source_content): Don't declare.
4438         * tui/tui-source.c (tui_source_window::set_contents): Rename from
4439         tui_set_source_content.
4440         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4441         Declare.
4442         (tui_set_disassem_content): Don't declare.
4443         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4444         tui_set_disassem_content.
4445
4446 2019-08-16  Tom Tromey  <tom@tromey.com>
4447
4448         * tui/tui-winsource.h (struct tui_source_window_base)
4449         <update_breakpoint_info>: Declare.
4450         (tui_update_breakpoint_info): Don't declare.
4451         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4452         (tui_update_all_breakpoint_info): Update.
4453         (tui_source_window_base::update_breakpoint_info): Rename from
4454         tui_update_breakpoint_info.
4455         (tui_source_window_base::update_exec_info): Update.
4456
4457 2019-08-16  Tom Tromey  <tom@tromey.com>
4458
4459         * tui/tui-winsource.h (struct tui_source_window_base)
4460         <update_source_window>: Declare.
4461         (tui_update_source_window): Don't declare.
4462         * tui/tui-winsource.c
4463         (tui_source_window_base::update_source_window): Rename from
4464         tui_update_source_window.
4465         (tui_source_window_base::rerender): Update.
4466         * tui/tui-source.c (tui_source_window::maybe_update): Update.
4467         * tui/tui-disasm.c (tui_show_disassem)
4468         (tui_show_disassem_and_update_source)
4469         (tui_disasm_window::maybe_update): Update.
4470
4471 2019-08-16  Tom Tromey  <tom@tromey.com>
4472
4473         * tui/tui-winsource.h (struct tui_source_window_base)
4474         <update_source_window_as_is>: Declare.
4475         (tui_update_source_window_as_is): Don't declare.
4476         * tui/tui-winsource.c (tui_update_source_window): Update
4477         (tui_source_window_base::update_source_window_as_is): Rename from
4478         tui_update_source_window_as_is.
4479         (tui_source_window_base::refill): Update.
4480         * tui/tui-source.c (tui_show_symtab_source): Update.
4481         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4482         Update.
4483
4484 2019-08-16  Tom Tromey  <tom@tromey.com>
4485
4486         * tui/tui-winsource.h (tui_update_source_window)
4487         (tui_update_source_window_as_is): Remove "noerror" parameter.
4488         * tui/tui-winsource.c (tui_update_source_window)
4489         (tui_update_source_window_as_is): Remove "noerror" parameter.
4490         (tui_update_source_windows_with_addr)
4491         (tui_update_source_windows_with_line)
4492         (tui_source_window_base::rerender)
4493         (tui_source_window_base::refill): Update.
4494         * tui/tui-source.h (tui_set_source_content)
4495         (tui_show_symtab_source): Remove "noerror" parameter.
4496         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4497         parameter.
4498         (tui_show_symtab_source): Likewise.
4499         (tui_source_window::maybe_update): Update.
4500         * tui/tui-disasm.c (tui_show_disassem)
4501         (tui_show_disassem_and_update_source)
4502         (tui_disasm_window::do_scroll_vertical)
4503         (tui_disasm_window::maybe_update): Update.
4504
4505 2019-08-16  Tom Tromey  <tom@tromey.com>
4506
4507         * tui/tui.c (tui_is_window_visible): Update.
4508         * tui/tui-wingeneral.c (tui_make_window)
4509         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4510         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4511         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4512         (tui_set_win_height_command, parse_scrolling_args): Update.
4513         * tui/tui-source.c (tui_source_window::style_changed): Update.
4514         * tui/tui-regs.c (tui_show_registers)
4515         (tui_data_window::first_data_item_displayed)
4516         (tui_data_window::delete_data_content_windows)
4517         (tui_check_register_values, tui_reg_command): Update.
4518         * tui/tui-disasm.c (tui_show_disassem): Update.
4519         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4520         method.
4521         <is_visible>: Remove field.
4522         * tui/tui-data.c (tui_next_win, tui_prev_win)
4523         (tui_delete_invisible_windows): Update.
4524
4525 2019-08-16  Tom Tromey  <tom@tromey.com>
4526
4527         * tui/tui-winsource.h (struct tui_source_window_base)
4528         <m_has_locator>: Remove.
4529         * tui/tui-layout.c (show_source_disasm_command, show_data)
4530         (show_source_or_disasm_and_command): Update.
4531
4532 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
4533
4534         * NEWS (Other MI changes): New subsection.
4535         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4536         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4537         * arch-utils.c (default_get_pc_address_flags): New function.
4538         * arch-utils.h (default_get_pc_address_flags): New declaration.
4539         * gdbarch.sh: Add get_pc_address_flags.
4540         * gdbarch.c: Regenerate.
4541         * gdbarch.h: Likewise.
4542         * stack.c (print_pc): New function.
4543         (print_frame_info) (print_frame): Call print_pc.
4544
4545 2019-08-16  Tom de Vries  <tdevries@suse.de>
4546
4547         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4548         print_objfile_section_info.
4549
4550 2019-08-15  Tom Tromey  <tom@tromey.com>
4551
4552         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4553         calling update_cmdwin_start_line.
4554         * tui/tui-winsource.h (struct tui_source_window_base)
4555         <do_make_visible_with_new_height, set_new_height>: Don't declare.
4556         <rerender>: Declare.
4557         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4558         Call rerender.
4559         (tui_source_window_base::set_new_height): Remove.
4560         (tui_source_window_base::rerender): Rename from
4561         do_make_visible_with_new_height.
4562         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4563         resize method.
4564         (tui_win_info::make_invisible_and_set_new_height)
4565         (tui_win_info::make_visible_with_new_height): Remove.
4566         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4567         Declare.
4568         * tui/tui-stack.c (tui_locator_window::rerender): New method.
4569         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4570         do_make_visible_with_new_height>: Don't declare.
4571         <rerender>: Declare.
4572         * tui/tui-regs.c (tui_data_window::rerender): Rename from
4573         set_new_height.
4574         (tui_data_window::do_make_visible_with_new_height): Remove.
4575         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4576         call tui_show_locator_content.
4577         (tui_gen_win_info::resize): Call rerender.
4578         (show_source_or_disasm_and_command): Don't call
4579         tui_show_locator_content.
4580         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4581         method.
4582         (struct tui_win_info) <rerender>: Declare.
4583         <set_new_height, make_invisible_and_set_new_height,
4584         make_visible_with_new_height>: Don't declare.
4585         * tui/tui-data.c (tui_win_list::rerender): New method.
4586         * tui/tui-command.h (struct tui_cmd_window)
4587         <do_make_visible_with_new_height>: Don't declare.
4588         * tui/tui-command.c
4589         (tui_cmd_window::do_make_visible_with_new_height): Remove.
4590
4591 2019-08-15  Tom Tromey  <tromey@adacore.com>
4592
4593         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4594         * ada-lang.c (ada_enum_name): Likewise.
4595
4596 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
4597
4598         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4599         leading underscore.
4600         (GdbOutputErrorFile): Likewise.
4601         (global scope): Adjust constructor calls to GdbOutput{,Error}File
4602         accordingly.
4603         (execute_unwinders): Rename to have a leading underscore.
4604         (auto_load_packages): Likewise.
4605         (global scope): Adjust call to auto_load_packages accordingly.
4606         (GdbSetPythonDirectory): Likewise.
4607         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4608         instead of execute_unwinders.
4609
4610 2019-08-15  Tom Tromey  <tom@tromey.com>
4611
4612         * tui/tui-layout.c (show_layout, show_source_disasm_command)
4613         (show_data): Don't change window visibility.
4614         (tui_gen_win_info::resize): Remove special case for command
4615         window.  Use wresize, when available.
4616         (show_source_or_disasm_and_command): Don't change window
4617         visibility.
4618         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4619         <make_visible>: New method.
4620         * tui/tui-command.c (tui_cmd_window::resize): New method.
4621
4622 2019-08-15  Tom Tromey  <tom@tromey.com>
4623
4624         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4625         (struct tui_source_windows): New.
4626         * tui/tui-winsource.c (tui_display_main): Update.
4627         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4628         (new_height_ok, parse_scrolling_args): Update.
4629         * tui/tui-layout.c (show_layout, show_data): Update.
4630         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4631         (tui_add_to_source_windows): Don't declare.
4632         * tui/tui-data.c (source_windows, tui_source_windows)
4633         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4634
4635 2019-08-15  Tom Tromey  <tom@tromey.com>
4636
4637         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4638         Rename from reset.
4639         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4640         * tui/tui-layout.c (show_source_disasm_command, show_data):
4641         Update.
4642         (tui_gen_win_info::resize): Rename.
4643         (show_source_or_disasm_and_command): Update.
4644         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4645         reset.
4646
4647 2019-08-15  Tom Tromey  <tom@tromey.com>
4648
4649         * tui/tui-stack.c (tui_initialize_static_data): Remove.
4650         * tui/tui-interp.c (tui_interp::init): Don't call
4651         tui_initialize_static_data.
4652         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4653
4654 2019-08-15  Tom Tromey  <tom@tromey.com>
4655
4656         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4657         examine tui_win_list.
4658
4659 2019-08-15  Tom Tromey  <tom@tromey.com>
4660
4661         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4662         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4663         tui_clear_source_content.
4664         (tui_clear_source_content): Remove.
4665         (tui_source_window_base::do_erase_source_content): Hoist call to
4666         content.clear().
4667         * tui/tui-stack.c (tui_show_frame_info): Don't call
4668         tui_clear_source_content.
4669
4670 2019-08-15  Tom Tromey  <tom@tromey.com>
4671
4672         * tui/tui-winsource.h (struct tui_source_window_base)
4673         <do_erase_source_content>: New method.
4674         <erase_source_content>: New method.
4675         (tui_erase_source_content): Don't declare.
4676         * tui/tui-winsource.c (tui_clear_source_content): Update.
4677         (tui_source_window_base::do_erase_source_content): Rename from
4678         tui_erase_source_content.
4679         (tui_source_window_base::show_source_content): Update.
4680         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4681         * tui/tui-source.h (struct tui_source_window)
4682         <erase_source_content>: New method.
4683         * tui/tui-disasm.h (struct tui_disasm_window)
4684         <erase_source_content>: New method.
4685
4686 2019-08-15  Tom Tromey  <tom@tromey.com>
4687
4688         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
4689         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
4690         constructor.
4691         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
4692         * tui/tui-source.c (tui_set_source_content): Update.
4693         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4694
4695 2019-08-15  Tom Tromey  <tom@tromey.com>
4696
4697         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
4698         * tui/tui-winsource.c (tui_line_is_displayed): Move to
4699         tui-source.c.
4700         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
4701         Declare.
4702         * tui/tui-source.c (tui_source_window::line_is_displayed): New
4703         method.
4704         (tui_source_window::maybe_update): Update.
4705
4706 2019-08-15  Tom Tromey  <tom@tromey.com>
4707
4708         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
4709         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
4710         tui-disasm.c.
4711         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
4712         Declare.
4713         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
4714         method.
4715         (tui_disasm_window::maybe_update): Update.
4716
4717 2019-08-15  Tom Tromey  <tom@tromey.com>
4718
4719         * tui/tui-winsource.h (struct tui_source_window_base)
4720         <maybe_update>: Declare.
4721         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
4722         method.
4723         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
4724         Declare.
4725         * tui/tui-source.c (tui_source_window::maybe_update): New method.
4726         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
4727         Declare.
4728         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
4729
4730 2019-08-15  Tom Tromey  <tom@tromey.com>
4731
4732         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
4733
4734 2019-08-15  Tom Tromey  <tom@tromey.com>
4735
4736         * tui/tui-wingeneral.c: Include tui-stack.h.
4737         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
4738         (struct tui_locator_window): Move from tui-data.h.
4739         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
4740         (tui_initialize_static_data): Move from tui-data.c.
4741         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
4742         (struct tui_locator_window): Move to tui-stack.c.
4743         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
4744         (tui_initialize_static_data): Move to tui-stack.c.
4745
4746 2019-08-15  Tom Tromey  <tom@tromey.com>
4747
4748         * tui/tui-layout.c (show_source_disasm_command)
4749         (show_source_or_disasm_and_command): Use make_visible method, not
4750         tui_make_window.
4751         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
4752         Remove.
4753
4754 2019-08-15  Tom Tromey  <tom@tromey.com>
4755
4756         * tui/tui-wingeneral.h (tui_make_window): Update.
4757         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
4758         parameter.
4759         (tui_gen_win_info::make_visible): Update.
4760         * tui/tui-regs.c (tui_data_window::display_registers_from):
4761         Update.
4762         * tui/tui-layout.c (show_source_disasm_command)
4763         (show_source_or_disasm_and_command): Update.
4764         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
4765         (enum tui_box): Remove.
4766         (struct tui_win_info) <can_box>: New method.
4767         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
4768         method.
4769
4770 2019-08-15  Tom de Vries  <tdevries@suse.de>
4771
4772         * linux-nat-trad.c: Include gdbarch.h.
4773
4774 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
4775
4776         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
4777         register sizes.
4778
4779 2019-08-14  Tom Tromey  <tromey@adacore.com>
4780
4781         * darwin-nat.c: Include gdbarch.h.
4782         * darwin-nat-info.c: Include gdbarch.h.
4783
4784 2019-08-13  Tom Tromey  <tom@tromey.com>
4785
4786         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
4787         Remove.
4788         * tui/tui-data.c (tui_initialize_static_data): Update.
4789
4790 2019-08-13  Tom Tromey  <tom@tromey.com>
4791
4792         * tui/tui-winsource.h (struct tui_exec_info_window)
4793         <~tui_exec_info_window, maybe_allocate_content, get_content,
4794         m_content>: Remove.
4795         (struct tui_source_window_base) <set_exec_info_content,
4796         show_exec_info_content>: Don't declare.
4797         * tui/tui-winsource.c
4798         (tui_exec_info_window::maybe_allocate_content): Remove.
4799         (tui_source_window_base::update_exec_info): Rename from
4800         set_exec_info_content.
4801         (tui_source_window_base::show_exec_info_content)
4802         (tui_source_window_base::update_exec_info): Remove.
4803
4804 2019-08-13  Tom Tromey  <tom@tromey.com>
4805
4806         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
4807         declare.
4808         * tui/tui-winsource.c (tui_update_source_window_as_is)
4809         (tui_update_source_windows_with_addr, tui_erase_source_content):
4810         Update.
4811         (tui_clear_exec_info_content): Remove.
4812
4813 2019-08-13  Tom Tromey  <tom@tromey.com>
4814
4815         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
4816         declare.
4817         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
4818         call tui_erase_exec_info_content.
4819         (tui_clear_exec_info_content): Rename from
4820         tui_erase_exec_info_content.
4821         (tui_clear_exec_info_content): Delete.
4822
4823 2019-08-13  Tom Tromey  <tom@tromey.com>
4824
4825         * tui/tui-winsource.h (struct tui_source_window_base)
4826         <show_exec_info_content>: Declare.
4827         (tui_show_exec_info_content): Don't declare.
4828         * tui/tui-winsource.c
4829         (tui_source_window_base::show_exec_info_content): Rename from
4830         tui_show_exec_info_content.
4831         (tui_source_window_base::update_exec_info): Update.
4832
4833 2019-08-13  Tom Tromey  <tom@tromey.com>
4834
4835         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
4836         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
4837         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
4838         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
4839         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
4840         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
4841         ... here.
4842
4843 2019-08-13  Tom Tromey  <tom@tromey.com>
4844
4845         * tui/tui-winsource.h (struct tui_source_window_base)
4846         <update_exec_info>: Declare.
4847         (tui_update_exec_info): Don't declare.
4848         * tui/tui-winsource.c (tui_update_source_window_as_is)
4849         (tui_source_window_base::refresh_all)
4850         (tui_update_all_breakpoint_info): Update.
4851         (tui_source_window_base::update_exec_info): Rename from
4852         tui_update_exec_info.
4853         * tui/tui-stack.c (tui_show_frame_info): Update.
4854
4855 2019-08-13  Tom Tromey  <tom@tromey.com>
4856
4857         * tui/tui-winsource.h (struct tui_source_window_base)
4858         <set_exec_info_content>: Declare.
4859         (tui_set_exec_info_content): Don't declare.
4860         * tui/tui-winsource.c
4861         (tui_source_window_base::set_exec_info_content): Rename from
4862         tui_set_exec_info_content.
4863         (tui_update_exec_info): Update.
4864
4865 2019-08-13  Tom Tromey  <tom@tromey.com>
4866
4867         * tui/tui-winsource.h (struct tui_source_window_base)
4868         <show_source_content>: Declare.
4869         (tui_show_source_content): Don't declare.
4870         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4871         (tui_source_window_base::show_source_content): Rename from
4872         tui_show_source_content.
4873         (tui_source_window_base::refresh_all): Update.
4874         * tui/tui-layout.c (show_source_disasm_command)
4875         (show_source_or_disasm_and_command): Update.
4876
4877 2019-08-13  Tom Tromey  <tom@tromey.com>
4878
4879         * tui/tui-winsource.c (tui_erase_source_content)
4880         (tui_show_source_content, tui_source_window_base::refresh_all):
4881         Update.
4882         * tui/tui-wingeneral.h
4883         (tui_check_and_display_highlight_if_needed): Don't declare.
4884         * tui/tui-wingeneral.c
4885         (tui_win_info::check_and_display_highlight_if_needed): Rename from
4886         check_and_display_highlight_if_needed.
4887         * tui/tui-win.c (tui_rehighlight_all)
4888         (tui_win_info::make_visible_with_new_height): Update.
4889         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4890         (tui_data_window::erase_data_content)
4891         (tui_data_window::display_all_data): Update.
4892         * tui/tui-data.h (struct tui_win_info)
4893         <check_and_display_highlight_if_needed>: Declare.
4894
4895 2019-08-13  Tom Tromey  <tom@tromey.com>
4896
4897         * tui/tui-win.c (tui_resize_all): Call
4898         tui_delete_invisible_windows.
4899         * tui/tui-layout.c (show_layout): Call
4900         tui_delete_invisible_windows.
4901         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
4902         * tui/tui-data.c (tui_delete_invisible_windows): New function.
4903
4904 2019-08-13  Tom Tromey  <tom@tromey.com>
4905
4906         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
4907         tui_add_win_to_layout.
4908
4909 2019-08-13  Tom Tromey  <tom@tromey.com>
4910
4911         * tui/tui-layout.h (tui_default_win_height): Don't declare.
4912         * tui/tui-layout.c (tui_default_win_height): Now static.
4913
4914 2019-08-13  Tom Tromey  <tom@tromey.com>
4915
4916         * tui/tui-layout.c (show_layout): Unify all layout cases into a
4917         single switch.
4918         (show_source_disasm_command, show_source_or_disasm_and_command):
4919         Don't check current layout.
4920
4921 2019-08-13  Tom Tromey  <tom@tromey.com>
4922
4923         * tui/tui-wingeneral.c (make_all_visible): Remove.
4924         (tui_make_all_invisible): Simplify.
4925         * tui/tui-layout.c (tui_make_all_invisible): Move from
4926         tui-wingeneral.c; simplify.
4927         (show_layout): Hoist call to tui_make_all_invisible.
4928         (show_data): Don't call tui_make_all_invisible.
4929
4930 2019-08-13  Tom Tromey  <tom@tromey.com>
4931
4932         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
4933         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
4934
4935 2019-08-13  Tom Tromey  <tom@tromey.com>
4936
4937         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
4938         tui-data.c.
4939         (show_source_disasm_command, show_data)
4940         (show_source_or_disasm_and_command): Don't use
4941         tui_set_current_layout_to.
4942         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
4943         * tui/tui-data.c (current_layout, tui_current_layout): Move to
4944         tui-layout.c.
4945         (tui_set_current_layout_to): Remove.
4946
4947 2019-08-13  Tom Tromey  <tom@tromey.com>
4948
4949         * tui/tui-layout.c (tui_set_layout): Update.
4950         * tui/tui-data.h (struct tui_layout_def): Remove.
4951         (tui_layout_def): Don't declare.
4952         * tui/tui-data.c (layout_def): Remove.
4953         (tui_layout_def): Remove.
4954
4955 2019-08-13  Tom Tromey  <tom@tromey.com>
4956
4957         * tui/tui-winsource.h (struct tui_source_window_base)
4958         <clear_detail>: No longer "override".
4959         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
4960         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
4961         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
4962         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
4963         Remove.
4964         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
4965
4966 2019-08-13  Tom Tromey  <tromey@adacore.com>
4967
4968         * tracepoint.c: Don't include readline.h or history.h.
4969
4970 2019-08-12  Tom Tromey  <tom@tromey.com>
4971
4972         * configure: Rebuild.
4973         * configure.ac: Check for readline 7.
4974         * NEWS: Mention readline 7 requirement.
4975         * README: Update.
4976
4977 2019-08-12  Tom Tromey  <tom@tromey.com>
4978
4979         * mingw-hdep.c (gdb_select): Remove readline hack.
4980
4981 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4982
4983         * blockframe.c (find_pc_partial_function): Set *block to nullptr
4984         when the function fails.
4985
4986 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
4987
4988         * s390-tdep.c (s390_type_align): New function.
4989         (s390_gdbarch_init): Set it as type_align gdbarch method.
4990
4991 2019-08-09  Tom de Vries  <tdevries@suse.de>
4992
4993         PR gdb/24591
4994         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
4995         pc_low with relocation offset.
4996
4997 2019-08-07  Tom Tromey  <tromey@adacore.com>
4998
4999         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5000         (print_frame_args): Update.
5001         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5002         Update.
5003         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5004         * frame.h (struct frame_arg): Add initializers.
5005         <error>: Now a unique_xmalloc_ptr.
5006
5007 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
5008
5009         * NEWS: Expand the Pointer Authentication entry.
5010         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5011         (aarch64_frame_unmask_lr): ... to this.
5012         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5013         Call aarch64_frame_unmask_lr.
5014         * frame.c (struct frame_info): Add "masked" variable.
5015         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5016         (fprint_frame): Check for masked pc.
5017         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5018         declarations.
5019         * python/py-framefilter.c (py_print_frame): Check for masked pc.
5020         * stack.c (print_frame): Check for masked pc.
5021
5022 2019-08-06  Tom Tromey  <tom@tromey.com>
5023
5024         * stabsread.c (patch_block_stabs, read_one_struct_field)
5025         (read_enum_type): Use obstack_strndup.
5026         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5027         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5028         * dwarf2read.c (guess_full_die_structure_name)
5029         (anonymous_struct_prefix): Use obstack_strndup.
5030         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5031         * c-exp.y (yylex): Use obstack_strndup.
5032         * ada-exp.y (write_object_renaming, write_ambiguous_var)
5033         (write_var_or_type): Use obstack_strndup.
5034
5035 2019-08-06  Tom Tromey  <tom@tromey.com>
5036
5037         * symfile.c (reread_symbols): Use obstack_strdup.
5038         * stabsread.c (read_type): Use obstack_strdup.
5039         * gdb_obstack.h (obstack_strdup): New overload.
5040         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5041         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5042         (dwarf2_canonicalize_name): Use obstack_strdup.
5043         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5044         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5045         Use obstack_strdup.
5046
5047 2019-08-06  Tom Tromey  <tom@tromey.com>
5048
5049         * gdb_obstack.h (obstack_strdup): Define.
5050         * gdb_obstack.c (obstack_strdup): Don't define.
5051
5052 2019-08-06  Tom Tromey  <tom@tromey.com>
5053
5054         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5055         obstack_strdup.
5056         * typeprint.c (typedef_hash_table::find_global_typedef): Use
5057         obstack_strdup.
5058         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5059         * stabsread.c (common_block_start): Use obstack_strdup.
5060         * objfiles.c (set_objfile_main_name, objfile): Use
5061         obstack_strdup.
5062         * namespace.c (add_using_directive): Use obstack_strdup.
5063         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5064         * jit.c (finalize_symtab): Use obstack_strdup.
5065         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5066         (guess_partial_die_structure_name, partial_die_info::fixup)
5067         (dwarf2_name): Use obstack_strdup.
5068         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5069         obstack_strdup.
5070         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5071         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5072         obstack_strdup.
5073         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5074
5075 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5076
5077         * unittests/help-doc-selftests.c: New file.
5078         * Makefile.in: Add the new file.
5079
5080 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5081
5082         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5083         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
5084         the full first line, except when FOR_VALUE_PREFIX.  In this case,
5085         the trailing '.' is not output, and the first character is uppercased.
5086         (print_help_for_command): Update call to print_doc_line.
5087         (print_doc_of_command): Likewise.
5088         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5089         * cli/cli-option.c (append_indented_doc): Do not append newline.
5090         (build_help_option): Append newline after first appended_indented_doc
5091         only if a second call is done.
5092         (build_help): Append 2 new lines before each option, except the first
5093         one.
5094         * compile/compile.c (_initialize_compile): Add new lines after
5095         %OPTIONS%, when not at the end of the help.
5096         Change help doc or code
5097         producing the help doc to respect the invariants.
5098         * maint-test-options.c (_initialize_maint_test_options): Likewise.
5099         Also removed the new line after 'Options:', as all other commands
5100         do not put an empty line between 'Options:' and the first option.
5101         * printcmd.c (_initialize_printcmd): Likewise.
5102         * stack.c (_initialize_stack): Likewise.
5103         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5104         incorrectly telling COMMAND is optional.
5105         * ada-lang.c (_initialize_ada_language): Change help doc or code
5106         producing the help doc to respect the invariants.
5107         * ada-tasks.c (_initialize_ada_tasks): Likewise.
5108         * breakpoint.c (_initialize_breakpoint): Likewise.
5109         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5110         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5111         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5112         * cli/cli-style.c (cli_style_option::add_setshow_commands,
5113         _initialize_cli_style): Likewise.
5114         * corelow.c (core_target_info): Likewise.
5115         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5116         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5117         * filesystem.c (_initialize_filesystem): Likewise.
5118         * frame.c (_initialize_frame): Likewise.
5119         * gnu-nat.c (add_task_commands): Likewise.
5120         * infcall.c (_initialize_infcall): Likewise.
5121         * infcmd.c (_initialize_infcmd): Likewise.
5122         * interps.c (_initialize_interpreter): Likewise.
5123         * language.c (_initialize_language): Likewise.
5124         * linux-fork.c (_initialize_linux_fork): Likewise.
5125         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5126         * maint.c (_initialize_maint_cmds): Likewise.
5127         * memattr.c (_initialize_mem): Likewise.
5128         * printcmd.c (_initialize_printcmd): Likewise.
5129         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5130         _RegEx): Likewise.
5131         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5132         * record-btrace.c (_initialize_record_btrace): Likewise.
5133         * record-full.c (_initialize_record_full): Likewise.
5134         * record.c (_initialize_record): Likewise.
5135         * regcache-dump.c (_initialize_regcache_dump): Likewise.
5136         * regcache.c (_initialize_regcache): Likewise.
5137         * remote.c (add_packet_config_cmd, init_remote_threadtests,
5138         _initialize_remote): Likewise.
5139         * ser-tcp.c (_initialize_ser_tcp): Likewise.
5140         * serial.c (_initialize_serial): Likewise.
5141         * skip.c (_initialize_step_skip): Likewise.
5142         * source.c (_initialize_source): Likewise.
5143         * stack.c (_initialize_stack): Likewise.
5144         * symfile.c (_initialize_symfile): Likewise.
5145         * symtab.c (_initialize_symtab): Likewise.
5146         * target-descriptions.c (_initialize_target_descriptions): Likewise.
5147         * top.c (init_main): Likewise.
5148         * tracefile-tfile.c (tfile_target_info): Likewise.
5149         * tracepoint.c (_initialize_tracepoint): Likewise.
5150         * tui/tui-win.c (_initialize_tui_win): Likewise.
5151         * utils.c (add_internal_problem_command): Likewise.
5152         * valprint.c (value_print_option_defs): Likewise.
5153
5154 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
5155
5156         PR build/24886
5157         * configure.ac: Drop enable-libmcheck support.
5158         * configure, config.in: Rebuild.
5159         * libmcheck.m4: Remove.
5160         * acinclude.m4: Don't include it.
5161         * Makefile.in: Don't distribute it.
5162         * top.c (print_gdb_configuration): Don't mention it.
5163
5164 2019-08-06  Tom Tromey  <tom@tromey.com>
5165
5166         * utils.c (set_output_style): Sometimes pass stream to
5167         emit_style_escape.
5168         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5169         * record-btrace.c (btrace_insn_history): Update.
5170         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5171         method.
5172         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5173         Update initializers.
5174         <m_uiout>: New field.
5175         <m_di>: Move lower.
5176         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5177         Remove "uiout" parameter.
5178         (dump_insns): Update.
5179         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5180         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5181
5182 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
5183
5184         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5185         (error_in_psymtab_expansion): Likewise.
5186         (lookup_symbol_via_quick_fns): Likewise.
5187         (basic_lookup_transparent_type_quick): Likewise.
5188         (basic_lookup_transparent_type_1): Likewise.
5189
5190 2019-08-06  Tom Tromey  <tromey@adacore.com>
5191
5192         * source.c (last_source_error): Now bool.
5193         (print_source_lines_base): Make "noprint" bool.  Only open
5194         source file when last_source_visited changes.
5195
5196 2019-08-06  Tom Tromey  <tromey@adacore.com>
5197
5198         * annotate.c (annotate_source_line): Use g_source_cache.
5199         * source-cache.c (source_cache::get_plain_source_lines): Change
5200         parameters.  Populate m_offset_cache.
5201         (source_cache::ensure): New method.
5202         (source_cache::get_line_charpos): New method.
5203         (extract_lines): Move lower.  Change parameters.
5204         (source_cache::get_source_lines): Move lower.
5205         * source-cache.h (class source_cache): Update comment.
5206         <get_line_charpos>: New method.
5207         <get_source_lines>: Update comment.
5208         <clear>: Clear m_offset_cache.
5209         <get_plain_source_lines>: Change parameters.
5210         <ensure>: New method
5211         <m_offset_cache>: New member.
5212         * source.c (forget_cached_source_info_for_objfile): Update.
5213         (info_source_command): Use g_source_cache.
5214         (find_source_lines, open_source_file_with_line_charpos): Remove.
5215         (print_source_lines_base, search_command_helper): Use g_source_cache.
5216         * source.h (open_source_file_with_line_charpos): Don't declare.
5217         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5218         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5219         Use g_source_cache.
5220
5221 2019-08-06  Tom Tromey  <tromey@adacore.com>
5222
5223         * source-cache.c (source_cache::get_plain_source_lines):
5224         Remove "first_line" and "last_line" parameters.
5225         (source_cache::get_source_lines): Cache plain text.
5226         * source-cache.h (class source_cache)
5227         <get_plain_source_lines>: Update.
5228
5229 2019-08-06  Tom Tromey  <tromey@adacore.com>
5230
5231         * source-cache.c (extract_lines): No longer a method.
5232         Changed type of parameter.  Include final newline.
5233         (selftests::extract_lines_test): New function.
5234         (_initialize_source_cache): Likewise.
5235         * source-cache.h (class source_cache)
5236         <extract_lines>: Don't declare.
5237
5238 2019-08-06  Tom Tromey  <tromey@adacore.com>
5239
5240         * breakpoint.c (init_breakpoint_sal): Update.
5241         (breakpoint): Update.
5242         * breakpoint.h (struct breakpoint) <filter>: Now a
5243         unique_xmalloc_ptr.
5244
5245 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5246
5247         * NEWS: Mention dictionary access on blocks.
5248         * python/py-block.c (blpy_getitem): New function.
5249         (block_object_as_mapping): New struct.
5250         (block_object_type): Use new struct for tp_as_mapping field.
5251
5252 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
5253
5254         * objfiles.h (objfile): Add a comment describing partial symbols.
5255
5256 2019-08-05  Tom Tromey  <tromey@adacore.com>
5257
5258         * compile/compile.c (_initialize_compile): Use _(), not N_().
5259         * thread.c (_initialize_thread): Use _(), not N_().
5260         * stack.c (_initialize_stack): Use _(), not N_().
5261         * printcmd.c (_initialize_printcmd): Use _(), not N_().
5262
5263 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
5264
5265         * dwarf2read.c (struct dw2_symtab_iterator):
5266         <want_specific_block>: Remove.
5267         <block_index>: Change type to gdb::optional.
5268         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5269         change type of BLOCK_INDEX parameter to gdb::optional.
5270         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5271         (dw2_lookup_symbol): Don't pass argument for
5272         WANT_SPECIFIC_BLOCK.
5273         (dw2_expand_symtabs_for_function): Don't pass argument for
5274         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5275         (class dw2_debug_names_iterator)
5276         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5277         parameter, change BLOCK_INDEX type to gdb::optional.
5278         <m_want_specific_block>: Remove.
5279         <m_block_index>: Change type to gdb::optional.
5280         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5281         gdb::optional.  Re-write in function of gdb::optional.
5282         (dw2_debug_names_lookup_symbol): Don't pass argument for
5283         WANT_SPECIFIC_BLOCK.
5284         (dw2_debug_names_expand_symtabs_for_function): Don't pass
5285         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5286         BLOCK_INDEX.
5287
5288 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5289
5290         * NEWS: Mention changes to "info sources" command.
5291
5292 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5293
5294         * symtab.c (filename_partial_match_opts): New struct type.
5295         (struct output_source_filename_data): New members
5296         regexp, c_regexp, partial_match.
5297         (output_source_filename): Use new members to decide to print file.
5298         (info_sources_option_defs): New variable.
5299         (make_info_sources_options_def_group, print_info_sources_header,
5300         info_sources_command_completer):
5301         New functions.
5302         (info_sources_command): Read new optional arguments.
5303         (_initialize_symtab): Update info sources help.
5304
5305 2019-08-02  Alexandre Oliva <oliva@adacore.com>
5306
5307         * ada-lang.c (exception_support_info_v0): Renamed from...
5308         (default_exception_support_info): ... this.  Create new
5309         definition for v1.
5310         (ada_has_this_exception_support): Look up catch_handlers_sym.
5311         (ada_exception_support_info_sniffer): Try v0 after default.
5312
5313 2019-08-01  Tom Tromey  <tromey@adacore.com>
5314
5315         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5316         gdbarch.h.
5317
5318 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
5319
5320         * s12z-tdep.c: Fix include path for s12z-opc.h.
5321
5322 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
5323
5324         * NEWS: Require GNU make 3.82.
5325
5326 2019-07-16  Tom Tromey  <tom@tromey.com>
5327
5328         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5329         declare.
5330
5331 2019-07-30  Tom Tromey  <tromey@adacore.com>
5332
5333         * block.c (contained_in): Remove BLOCK_FUNCTION check.
5334
5335 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
5336
5337         * printcmd.c (print_address_symbolic): Print negative offsets.
5338         (build_address_symbolic): Force signed arithmetic when computing
5339         offset.
5340
5341 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
5342
5343         PR/24474: Add a function to lookup static variables.
5344         * NEWS: Mention this new function.
5345         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5346         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5347         * python/python.c (python_GdbMethods): Add new function.
5348
5349 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
5350
5351         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5352         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5353         (objfpy_lookup_static_symbol): New function.
5354         (objfile_object_methods): Add new functions.
5355
5356 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5357
5358         * NEWS: Mention 'set|show print frame-info'.  Mention new
5359         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
5360         backtrace argument.  Mention that python frame filtering code
5361         is now consistent with what 'backtrace' command prints.
5362
5363 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5364
5365         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5366         comments.
5367         (print_frame_info_auto, print_frame_info_source_line,
5368         print_frame_info_location, print_frame_info_source_and_location,
5369         print_frame_info_location_and_address, print_frame_info_short_location):
5370         New declarations.
5371         (struct frame_print_options): New member print_frame_info.
5372         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5373         * stack.h (get_user_print_what_frame_info): New declaration.
5374         (frame_show_address): New declaration.
5375         * stack.c (print_frame_arguments_choices): New value 'presence'.
5376         (print_frame_info_auto, print_frame_info_source_line,
5377         print_frame_info_location, print_frame_info_source_and_location,
5378         print_frame_info_location_and_address, print_frame_info_short_location,
5379         print_frame_info_choices, print_frame_info_print_what): New definitions.
5380         (print_frame_args): Only print dots for args if print frame-arguments
5381         is 'presence'.
5382         (frame_print_option_defs): New element for "frame-info".
5383         (get_user_print_what_frame_info): New function.
5384         (frame_show_address): Make non static.  Move comment to stack.h.
5385         (print_frame_info_to_print_what): New function.
5386         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
5387         to decide what to print.
5388         (backtrace_command_1): Handle the new print_frame_arguments_presence
5389         value.
5390         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5391         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5392         (py_print_frame): In non-mi mode, use LOCATION as default for
5393         print_what, similarly to frame information printed directly by
5394         backtrace command. Handle frame-info user option in non MI mode.
5395
5396 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5397
5398         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5399         Add case for debugging 32-bit target on 64-bit host.  Revise
5400         comment.
5401
5402 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5403
5404         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5405         instead of find_function_entry_range_from_pc.
5406
5407 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
5408
5409         * stack.c (find_frame_funname): Remove code which preferred
5410         minsym over symtab sym in "certain pathological cases".
5411
5412         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5413         parameter.  Change type of "do_demangle" to bool.
5414         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5415         Pass suitable "prefer_sym_over_minsym" flag to
5416         build_address_symbolic().  Don't output "+" for negative offsets.
5417         * printcmd.c (print_address_symbolic): Update invocation of
5418         build_address_symbolic to include a "prefer_sym_over_minsym"
5419         flag.
5420         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5421         Restrict cases in which use of minimal symbol is preferred to that
5422         of a found symbol.  Update comments.
5423
5424         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5425         for entry pc when entry pc is out of range for that FDE.
5426
5427 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
5428
5429         PR gdb/24839:
5430         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5431         type.
5432
5433 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
5434
5435         * python/py-objfile.c (add_separate_debug_file): Fix comment about
5436         this function's Python signature.
5437
5438
5439 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
5440
5441         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5442         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5443         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5444         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5445         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5446
5447
5448 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
5449
5450         * h8300-tdep.c (h8300_register_name_common): New.
5451         h8300_register_name): Use h8300_register_name_common.
5452         (h8300s_register_name): Likewise.
5453         (h8300sx_register_name): Likewise.
5454         (h8300h_register_nam): New.
5455         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5456
5457
5458 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
5459
5460         * arm-tdep.c (arm_skip_cmse_entry): New function.
5461         (arm_is_sgstubs_section): New function.
5462         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5463
5464 2019-07-22  Tom Tromey  <tom@tromey.com>
5465
5466         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5467         Don't self-assign.
5468
5469 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5470
5471         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5472         type_print.
5473
5474 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5475
5476         * symtab.c (search_symbols): Adjust msymbol matching type arrays
5477         so that GDB doesn't match any msymbols when searching in the
5478         TYPES_DOMAIN.
5479         (print_symbol_info): Print using typedef_print or type_print based
5480         on the type of the symbol.  Add updated FIXME comment moved from...
5481         (_initialize_symtab): ... move and update FIXME comment to above.
5482
5483 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5484
5485         * NEWS: Mention adding -q option to "info types".
5486         * symtab.c (struct info_types_options): New struct.
5487         (info_types_options_defs): New variable.
5488         (make_info_types_options_def_group): New function.
5489         (info_types_command): Use gdb::option framework to parse options.
5490         (info_types_command_completer): New function.
5491         (_initialize_symtab): Extend the help text on "info types" and
5492         register command completer.
5493
5494 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
5495
5496         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5497         (lookup_symbol_in_objfile): Change int to block_enum and add a
5498         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5499
5500 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
5501
5502         * MAINTAINERS (Write After Approval): Add self.
5503
5504 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
5505
5506         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5507         instruction to the dummy code region.
5508
5509 2019-07-19  Tom Tromey  <tromey@adacore.com>
5510
5511         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5512         (ARGSUSED, PARAMS, __func__): Remove rules.
5513
5514 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5515
5516         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5517         * features/arm/arm-with-iwmmxt.c: Remove.
5518         * features/arm/arm-with-iwmmxt.xml: Remove.
5519         * features/arm/arm-with-m-fpa-layout.c: Remove.
5520         * features/arm/arm-with-m-fpa-layout.xml: Remove.
5521         * features/arm/arm-with-m-vfp-d16.c: Remove.
5522         * features/arm/arm-with-m-vfp-d16.xml: Remove.
5523         * features/arm/arm-with-m.c: Remove.
5524         * features/arm/arm-with-m.xml: Remove.
5525         * features/arm/arm-with-neon.c: Remove.
5526         * features/arm/arm-with-neon.xml: Remove.
5527         * features/arm/arm-with-vfpv2.c: Remove.
5528         * features/arm/arm-with-vfpv2.xml: Remove.
5529         * features/arm/arm-with-vfpv3.c: Remove.
5530         * features/arm/arm-with-vfpv3.xml: Remove.
5531
5532 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5533
5534         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5535
5536 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5537
5538         * arch/aarch32.c (aarch32_create_target_description): Create
5539         target descriptions using features.
5540         * arch/arm.c (arm_create_target_description)
5541         (arm_create_mprofile_target_description): Likewise.
5542         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5543
5544 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
5545
5546         * Makefile.in: Add new files.
5547         * aarch32-tdep.c: New file.
5548         * aarch32-tdep.h: New file.
5549         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5550         Call aarch32_read_description.
5551         * arch/aarch32.c: New file.
5552         * arch/aarch32.h: New file.
5553         * arch/arm.c (arm_create_target_description)
5554         (arm_create_mprofile_target_description): New function.
5555         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5556         (arm_create_target_description)
5557         (arm_create_mprofile_target_description): New declaration.
5558         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5559         read_description functions.
5560         * arm-linux-nat.c (arm_linux_nat_target::read_description):
5561         Likewise.
5562         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5563         * arm-tdep.c (tdesc_arm_list): New variable.
5564         (arm_register_g_packet_guesses): Call create description functions.
5565         (arm_read_description) (arm_read_mprofile_description): New
5566         function.
5567         * arm-tdep.h (arm_read_description)
5568         (arm_read_mprofile_description): Add declaration.
5569         * configure.tgt: Add new files.
5570
5571 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
5572
5573         * top.c (new_ui_command): Open specified terminal just once.
5574
5575 2019-07-18  Tom Tromey  <tromey@adacore.com>
5576
5577         * symtab.c (main_name): Constify return type.
5578         * symfile.c (set_initial_language): Update.
5579         * symtab.h (main_name): Constify return type.
5580
5581 2019-07-17  Tom Tromey  <tom@tromey.com>
5582
5583         * tui/tui-winsource.c (tui_update_source_window)
5584         (tui_update_source_window_as_is)
5585         (tui_update_source_windows_with_line): Remove return.
5586         * tui/tui-disasm.c (tui_show_disassem)
5587         (tui_show_disassem_and_update_source): Remove return.
5588         * tui/tui.c (tui_reset): Remove return.
5589         * tui/tui-wingeneral.c
5590         (tui_check_and_display_highlight_if_needed): Remove return.
5591
5592 2019-07-17  Tom Tromey  <tom@tromey.com>
5593
5594         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5595
5596 2019-07-17  Tom Tromey  <tom@tromey.com>
5597
5598         * tui/tui-winsource.h (struct tui_exec_info_window)
5599         (struct tui_source_window_base): Move from tui-data.h.
5600         * tui/tui-winsource.c: Move many method definitions from
5601         elsewhere.  Remove "structuring" comments.
5602         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5603         (tui_source_window_base::refresh_window): Move to
5604         tui-winsource.c.
5605         * tui/tui-win.c (tui_source_window_base::refresh_all)
5606         (tui_source_window_base::update_tab_width)
5607         (tui_source_window_base::set_new_height)
5608         (tui_source_window_base::do_make_visible_with_new_height): Move to
5609         tui-winsource.c.
5610         * tui/tui-source.h: Update.
5611         * tui/tui-source.c (tui_source_window_base::reset): Move to
5612         tui-winsource.c.
5613         * tui/tui-disasm.h: Update.
5614         * tui/tui-data.h (struct tui_exec_info_window): Move to
5615         tui-winsource.h.
5616         (struct tui_source_window_base): Likewise.
5617         * tui/tui-data.c (tui_source_window_base::clear_detail)
5618         (tui_source_window_base, ~tui_source_window_base): Move to
5619         tui-winsource.c.
5620
5621 2019-07-17  Tom Tromey  <tom@tromey.com>
5622
5623         * tui/tui-win.c (tui_resize_all)
5624         (tui_source_window_base::update_tab_width)
5625         (tui_adjust_win_heights): Update.
5626         (tui_win_info::make_invisible_and_set_new_height): Rename from
5627         make_invisible_and_set_new_height.
5628         * tui/tui-data.h (struct tui_win_info)
5629         <make_invisible_and_set_new_height>: New method.
5630
5631 2019-07-17  Tom Tromey  <tom@tromey.com>
5632
5633         * tui/tui.c: Update.
5634         * tui/tui-source.h (struct tui_source_window): Move from
5635         tui-data.h.
5636         * tui/tui-layout.c: Update.
5637         * tui/tui-disasm.c: Update.
5638         * tui/tui-data.h (struct tui_source_window): Move to
5639         tui-source.h.
5640
5641 2019-07-17  Tom Tromey  <tom@tromey.com>
5642
5643         * tui/tui-disasm.h (struct tui_disasm_window): Move from
5644         tui-data.h.
5645         * tui/tui-data.h (struct tui_disasm_window): Move to
5646         tui-disasm.h.
5647
5648 2019-07-17  Tom Tromey  <tom@tromey.com>
5649
5650         * tui/tui-regs.h (struct tui_data_item_window): Move from
5651         tui-data.h.
5652         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5653         * tui/tui-data.h (struct tui_data_item_window): Move to
5654         tui-regs.h.
5655         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5656
5657 2019-07-17  Tom Tromey  <tom@tromey.com>
5658
5659         * tui/tui.c: Update.
5660         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5661         (tui_cmd_window::max_height): Move to tui-command.c.
5662         * tui/tui-layout.c: Update.
5663         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5664         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5665         tui-command.c.
5666         * tui/tui-command.h (struct tui_cmd_window): Move from
5667         tui-data.h.
5668         * tui/tui-command.c: Remove "structuring" comments.
5669         (tui_cmd_window::clear_detail)
5670         (tui_cmd_window::do_make_visible_with_new_height)
5671         (tui_cmd_window::max_height): Move from elsewhere.
5672
5673 2019-07-17  Tom Tromey  <tom@tromey.com>
5674
5675         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5676         Now static.
5677         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5678         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5679
5680 2019-07-17  Tom Tromey  <tom@tromey.com>
5681
5682         * tui/tui.c: Update.
5683         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5684         tui-regs.c.
5685         * tui/tui-windata.h: Remove file.
5686         * tui/tui-windata.c: Remove file.
5687         * tui/tui-win.c (tui_data_window::set_new_height)
5688         (tui_data_window::do_make_visible_with_new_height): Move to
5689         tui-regs.c.
5690         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
5691         * tui/tui-regs.c: Remove "structuring" comments.
5692         (tui_data_window::first_data_item_displayed)
5693         (tui_data_window::delete_data_content_windows)
5694         (tui_data_window::erase_data_content)
5695         (tui_data_window::display_all_data)
5696         (tui_data_window::refresh_all)
5697         (tui_data_window::do_scroll_vertical)
5698         (tui_data_window::clear_detail, tui_data_window::set_new_height)
5699         (tui_data_window::do_make_visible_with_new_height)
5700         (tui_data_window::refresh_window): Move from elsewhere.
5701         (_initialize_tui_regs): Move to end of file.
5702         * tui/tui-layout.c: Update.
5703         * tui/tui-hooks.c: Update.
5704         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
5705         * tui/tui-data.c (tui_data_window::clear_detail): Move to
5706         tui-regs.c.
5707         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
5708
5709 2019-07-17  Tom Tromey  <tom@tromey.com>
5710
5711         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
5712         seen.
5713
5714 2019-07-17  Tom Tromey  <tom@tromey.com>
5715
5716         * tui/tui-win.c (tui_source_window_base::set_new_height)
5717         (tui_source_window_base::do_make_visible_with_new_height): Use
5718         m_has_locator field directly.
5719         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
5720         method.
5721         (struct tui_source_window_base) <has_locator>: Likewise.
5722
5723 2019-07-17  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
5726         Don't declare.
5727         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
5728         Remove.
5729         * tui/tui-win.c (tui_source_window_base::set_new_height)
5730         (tui_source_window_base::set_new_height)
5731         (make_invisible_and_set_new_height)
5732         (tui_source_window_base::do_make_visible_with_new_height)
5733         (tui_source_window_base::do_make_visible_with_new_height):
5734         Update.
5735         * tui/tui-layout.c (show_source_disasm_command, show_data)
5736         (show_source_or_disasm_and_command): Update.
5737         * tui/tui-layout.c (show_layout): Update.
5738
5739 2019-07-17  Tom Tromey  <tom@tromey.com>
5740
5741         * tui/tui-layout.c (make_data_window): Remove.
5742         (show_data): Unify creation and re-initialization cases.
5743
5744 2019-07-17  Tom Tromey  <tom@tromey.com>
5745
5746         * tui/tui-layout.c (make_source_window, make_disasm_window):
5747         Remove.
5748         (show_data): Unify creation and re-initialization cases.
5749
5750 2019-07-17  Tom Tromey  <tom@tromey.com>
5751
5752         * tui/tui-layout.c (make_command_window): Remove.
5753         (show_source_disasm_command, show_source_or_disasm_and_command):
5754         Unify creation and re-initialization cases.
5755
5756 2019-07-17  Tom Tromey  <tom@tromey.com>
5757
5758         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
5759         creation and re-initialization cases.
5760
5761 2019-07-17  Tom Tromey  <tom@tromey.com>
5762
5763         * tui/tui-regs.c (tui_get_register): Return void.
5764
5765 2019-07-17  Tom Tromey  <tom@tromey.com>
5766
5767         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
5768         Simplify.
5769
5770 2019-07-17  Tom Tromey  <tom@tromey.com>
5771
5772         * tui/tui-layout.c (show_source_disasm_command): Simplify window
5773         resetting.
5774
5775 2019-07-17  Tom Tromey  <tom@tromey.com>
5776
5777         * tui/tui.h (tui_set_layout_by_name): Don't declare.
5778         * tui/tui-regs.c (tui_reg_layout): New function.
5779         (tui_show_registers, tui_reg_command): Use it.
5780         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
5781         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
5782         parameters.
5783         (tui_layout_command): Remove.
5784
5785 2019-07-17  Tom Tromey  <tom@tromey.com>
5786
5787         * tui/tui-layout.h (tui/tui-layout): Return void.
5788         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
5789
5790 2019-07-17  Tom Tromey  <tom@tromey.com>
5791
5792         * tui/tui-layout.c (show_source_disasm_command, show_data):
5793         Update.
5794         (reset_locator): Remove.
5795         (show_source_or_disasm_and_command): Update.
5796
5797 2019-07-17  Tom Tromey  <tom@tromey.com>
5798
5799         * tui/tui-source.c (tui_source_window_base::reset): Remove
5800         win_type parameter.
5801         * tui/tui-layout.c (make_command_window, make_source_window)
5802         (make_disasm_window, make_data_window)
5803         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
5804         (reset_locator, show_source_or_disasm_and_command): Update.
5805         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
5806         win_type parameter.
5807         (struct tui_source_window_base) <reset>: Likewise.
5808
5809 2019-07-17  Tom Tromey  <tom@tromey.com>
5810
5811         * tui/tui-layout.c (show_source_disasm_command): Use
5812         reset_locator.
5813         (reset_locator): New function.
5814         (init_and_make_win): Remove.
5815         (show_source_or_disasm_and_command): Use reset_locator.
5816
5817 2019-07-17  Tom Tromey  <tom@tromey.com>
5818
5819         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
5820         condition.
5821         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
5822         Remove condition.
5823         * tui/tui-source.c (tui_source_window_base::reset): New method.
5824         * tui/tui-layout.c (make_command_window): Don't call
5825         init_and_make_win.
5826         (make_source_window, make_disasm_window): Don't call
5827         make_source_or_disasm_window.
5828         (make_data_window): Don't call init_and_make_win.  Change calling
5829         convention.
5830         (show_source_disasm_command, show_data): Simplify.
5831         (make_source_or_disasm_window): Remove.
5832         (show_source_or_disasm_and_command): Simplify.
5833         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
5834         (struct tui_source_window_base) <reset>: Likewise.
5835         <execution_info>: Remove initializer.
5836         * tui/tui-data.c (tui_source_window_base): Initialize
5837         execution_info.
5838
5839 2019-07-17  Tom Tromey  <tom@tromey.com>
5840
5841         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
5842         variable.
5843
5844 2019-07-17  Tom Tromey  <tom@tromey.com>
5845
5846         * tui/tui.c (tui_rl_other_window): Update.
5847         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
5848         superclass method first.  Always iterate over regs_content.
5849         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
5850         method.
5851         * tui/tui-win.c (tui_set_focus_command): Update.
5852
5853 2019-07-17  Tom Tromey  <tom@tromey.com>
5854
5855         * tui/tui-win.c (tui_set_focus_command): Rename from
5856         tui_set_focus.  Call tui_enable.
5857         (tui_set_focus_command): Remove.
5858
5859 2019-07-17  Tom Tromey  <tom@tromey.com>
5860
5861         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
5862         refresh_window.
5863         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
5864         touchwin.
5865         (tui_data_window::refresh_window): Call refresh_window on data
5866         items.  Always call superclass refresh_window.
5867         (tui_win_info::refresh): Remove.
5868         (tui_source_window_base::refresh_window): Update.
5869         (tui_refresh_all): Update.
5870         * tui/tui-layout.c (show_source_disasm_command): Remove call to
5871         refresh_window.
5872         (show_source_or_disasm_and_command): Likewise.
5873         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
5874         (struct tui_source_window_base) <refresh>: Likewise.
5875
5876 2019-07-17  Tom Tromey  <tom@tromey.com>
5877
5878         * tui/tui-winsource.c (tui_clear_source_content)
5879         (tui_show_source_content): Update.
5880         * tui/tui-source.c (tui_source_window::showing_source_p): Check
5881         whether content is empty.
5882         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
5883         Remove.
5884
5885 2019-07-17  Tom Tromey  <tom@tromey.com>
5886
5887         * tui/tui-winsource.c (tui_erase_source_content): Clear the
5888         window's contents.
5889         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
5890         * tui/tui-source.c (tui_set_source_content_nil): Remove.
5891
5892 2019-07-17  Tom Tromey  <tom@tromey.com>
5893
5894         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
5895         (struct tui_data_item_window): Update.
5896
5897 2019-07-17  Tom Tromey  <tom@tromey.com>
5898
5899         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
5900         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
5901         defines.
5902
5903 2019-07-17  Tom Tromey  <tom@tromey.com>
5904
5905         * tui/tui-winsource.h (tui_erase_source_content)
5906         (tui_clear_source_content): Remove "display_prompt" parameter.
5907         * tui/tui-winsource.c (tui_update_source_window_as_is)
5908         (tui_update_source_windows_with_addr): Update.
5909         (tui_clear_source_content): Remove "display_prompt" parameter.
5910         (tui_erase_source_content): Likewise.  Simplify.
5911         (tui_show_source_content): Update.
5912         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5913         * tui/tui-stack.c (tui_show_frame_info): Update.
5914         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
5915         Remove defines.
5916
5917 2019-07-17  Tom Tromey  <tom@tromey.com>
5918
5919         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5920         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
5921         parameter.
5922         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
5923         parameter.
5924
5925 2019-07-17  Tom Tromey  <tom@tromey.com>
5926
5927         * tui/tui-winsource.c (tui_clear_source_content)
5928         (tui_show_source_content, tui_show_exec_info_content)
5929         (tui_clear_exec_info_content): Update.
5930         * tui/tui-stack.c (tui_show_locator_content): Update.
5931         (tui_show_frame_info): Update.
5932         * tui/tui-source.h (tui_source_window): Don't declare.
5933         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
5934         from tui_source_is_displayed.
5935         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
5936         Remove field.
5937         (struct tui_source_window_base) <content_in_use>: New field.  Now
5938         bool.
5939         (struct tui_source_window) <showing_source_p>: New method.
5940         (TUI_SRC_WIN): Change cast.
5941         * tui/tui-data.c (tui_initialize_static_data): Update.
5942
5943 2019-07-17  Tom Tromey  <tom@tromey.com>
5944
5945         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
5946         location_matches_p.
5947         * tui/tui-source.c (tui_source_window::location_matches_p): New
5948         method.
5949         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
5950         method.
5951         * tui/tui-data.h (struct tui_source_window_base)
5952         <location_matches_p>: New method.
5953         (struct tui_source_window, struct tui_disasm_window)
5954         <location_matches_p>: Likewise.
5955
5956 2019-07-17  Tom Tromey  <tom@tromey.com>
5957
5958         * tui/tui-win.c (tui_set_win_height_command): Rename from
5959         tui_set_win_height.
5960         (tui_set_win_height_command): Remove.
5961
5962 2019-07-17  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui-source.c (tui_source_window): New constructor.  Add
5965         observer.
5966         (~tui_source_window): New destructor.
5967         (tui_source_window::style_changed): New method.
5968         * tui/tui-hooks.c (tui_redisplay_source): Remove.
5969         (tui_attach_detach_observers): Update.
5970         * tui/tui-data.h (struct tui_source_window): Make constructor not
5971         inline.  Add destructor.
5972         (struct tui_source_window) <style_changed>: New method.
5973         <m_observable>: New member.
5974
5975 2019-07-17  Tom Tromey  <tom@tromey.com>
5976
5977         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
5978         * tui/tui-win.c (tui_resize_all): Fix typo.
5979
5980 2019-07-17  Tom Tromey  <tom@tromey.com>
5981
5982         * tui/tui-wingeneral.h (tui_refresh_all): Update.
5983         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
5984         (tui_refresh_all): Remove "list" parameter.  Use foreach.
5985         * tui/tui-win.c (window_name_completer): Use foreach.
5986         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
5987         (update_tab_width): Likewise.
5988         * tui/tui-layout.c (show_layout): Update.
5989         * tui/tui-data.h (class tui_window_iterator): New.
5990         (struct all_tui_windows): New.
5991         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
5992
5993 2019-07-17  Tom Tromey  <tom@tromey.com>
5994
5995         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
5996         parameter.  Don't reference globals.
5997         (tui_reg_command): Update.
5998
5999 2019-07-17  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-regs.c (tui_show_registers): Simplify.
6002
6003 2019-07-17  Tom Tromey  <tom@tromey.com>
6004
6005         * tui/tui-regs.c (tui_show_registers): Update.
6006         (tui_show_register_group): Add win_info parameter.
6007
6008 2019-07-17  Tom Tromey  <tom@tromey.com>
6009
6010         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6011         Rename from tui_display_reg_element_at_line.
6012         (tui_data_window::display_registers_from_line): Update.
6013         * tui/tui-data.h (struct tui_data_window)
6014         <display_reg_element_at_line>: New method.
6015
6016 2019-07-17  Tom Tromey  <tom@tromey.com>
6017
6018         * tui/tui-regs.h (tui_display_registers_from)
6019         (tui_display_registers_from_line): Don't declare.
6020         * tui/tui-windata.c (tui_data_window::display_all_data)
6021         (tui_data_window::refresh_all)
6022         (tui_data_window::do_scroll_vertical): Update.
6023         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6024         from tui_display_registers_from.
6025         (tui_display_reg_element_at_line): Update.
6026         (tui_data_window::display_registers_from_line): Rename from
6027         tui_display_registers_from_line.
6028         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6029         display_registers_from_line>: New methods.
6030
6031 2019-07-17  Tom Tromey  <tom@tromey.com>
6032
6033         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6034         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6035         from tui_erase_data_content.
6036         (tui_data_window::display_all_data)
6037         (tui_data_window::refresh_all)
6038         (tui_data_window::do_scroll_vertical): Update.
6039         * tui/tui-regs.c (tui_show_registers): Update.
6040         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6041         New method.
6042
6043 2019-07-17  Tom Tromey  <tom@tromey.com>
6044
6045         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6046         declare.
6047         * tui/tui-windata.c
6048         (tui_data_window::delete_data_content_windows): Rename from
6049         tui_delete_data_content_windows.
6050         (tui_data_window::display_all_data)
6051         (tui_data_window::do_scroll_vertical): Update.
6052         * tui/tui-data.h (struct tui_data_window)
6053         <delete_data_content_windows>: New method.
6054
6055 2019-07-17  Tom Tromey  <tom@tromey.com>
6056
6057         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6058         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6059
6060 2019-07-17  Tom Tromey  <tom@tromey.com>
6061
6062         * tui/tui-windata.h (tui_display_all_data): Don't declare.
6063         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6064         from tui_display_all_data.
6065         * tui/tui-win.c
6066         (tui_data_window::do_make_visible_with_new_height): Update.
6067         * tui/tui-regs.c (tui_show_registers): Update.
6068         * tui/tui-layout.c (tui_set_layout): Update.
6069         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6070         method.
6071
6072 2019-07-17  Tom Tromey  <tom@tromey.com>
6073
6074         * tui/tui-windata.h (tui_display_data_from): Don't declare.
6075         * tui/tui-windata.c (tui_display_data_from): Remove.
6076         (tui_data_window::refresh_all): Update.
6077
6078 2019-07-17  Tom Tromey  <tom@tromey.com>
6079
6080         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6081         * tui/tui-windata.c (tui_display_data_from_line): Remove.
6082         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6083         tui_display_registers_from_line.
6084         * tui/tui-regs.h (tui_display_registers_from_line): Update.
6085         * tui/tui-regs.c (tui_display_registers_from_line): Remove
6086         "force_display" parameter.
6087
6088 2019-07-17  Tom Tromey  <tom@tromey.com>
6089
6090         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6091         declare.
6092         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6093         Rename from tui_first_reg_element_no_inline.
6094         (tui_display_reg_element_at_line)
6095         (tui_display_registers_from_line): Update.
6096         * tui/tui-data.h (struct tui_data_window)
6097         <first_reg_element_no_inline>: New method.
6098
6099 2019-07-17  Tom Tromey  <tom@tromey.com>
6100
6101         * tui/tui-windata.c (tui_display_data_from)
6102         (tui_data_window::do_scroll_vertical): Update.
6103         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6104         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6105         Rename from tui_line_from_reg_element_no.
6106         (tui_display_registers_from_line): Update.
6107         * tui/tui-data.h (struct tui_data_window)
6108         <line_from_reg_element_no>: New method.
6109
6110 2019-07-17  Tom Tromey  <tom@tromey.com>
6111
6112         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6113         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6114         tui_last_regs_line_no.
6115         (tui_display_reg_element_at_line)
6116         (tui_display_registers_from_line): Update.
6117         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6118         method.
6119
6120 2019-07-17  Tom Tromey  <tom@tromey.com>
6121
6122         PR tui/24722:
6123         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6124         (tui_update_breakpoint_info): Add "being_deleted" parameter.
6125         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6126         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6127         (tui_update_breakpoint_info): Likewise.
6128         * tui/tui-hooks.c (tui_event_create_breakpoint)
6129         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6130         Update.
6131
6132 2019-07-17  Tom Tromey  <tom@tromey.com>
6133
6134         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6135
6136 2019-07-17  Tom Tromey  <tom@tromey.com>
6137
6138         * tui/tui-winsource.c (tui_update_source_window_as_is)
6139         (tui_update_source_windows_with_addr): Update.
6140         * tui/tui-source.h (tui_set_source_content)
6141         (tui_show_symtab_source): Add "win_info" parameter.
6142         * tui/tui-source.c (tui_set_source_content): Add "win_info"
6143         parameter.
6144         (tui_show_symtab_source): Likewise.
6145
6146 2019-07-17  Tom Tromey  <tom@tromey.com>
6147
6148         * tui/tui-wingeneral.c
6149         (tui_check_and_display_highlight_if_needed): Check can_highlight.
6150
6151 2019-07-17  Tom Tromey  <tom@tromey.com>
6152
6153         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6154         (struct tui_cmd_window) <can_scroll>: New method.
6155         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6156         method.
6157
6158 2019-07-17  Tom Tromey  <tromey@adacore.com>
6159
6160         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6161         do_field_signed>: Rename.  Change type of "value".
6162         * ui-out.c (ui_out::field_signed): Rename from field_int.
6163         Change type of "value".
6164         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
6165         type of "value".
6166         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6167         do_field_int.  Change type of "value".
6168         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6169         do_field_int.  Change type of "value".
6170         * tracepoint.c (trace_status_mi, tfind_1)
6171         (print_one_static_tracepoint_marker): Update.
6172         * thread.c (print_thread_info_1, print_selected_thread_frame):
6173         Update.
6174         * stack.c (print_frame, print_frame_info): Update.
6175         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6176         Update.
6177         * source.c (print_source_lines_base): Update.
6178         * skip.c (info_skip_command): Update.
6179         * record-btrace.c (btrace_ui_out_decode_error)
6180         (btrace_call_history_src_line): Update.
6181         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6182         Update.
6183         * progspace.c (print_program_space): Update.
6184         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6185         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6186         do_field_int.  Change type of "value".
6187         * mi/mi-out.c (mi_ui_out::do_table_begin)
6188         (mi_ui_out::do_table_header): Update.
6189         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
6190         type of "value".
6191         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6192         (mi_cmd_data_list_changed_registers, output_register)
6193         (mi_cmd_data_read_memory, mi_load_progress)
6194         (mi_cmd_trace_frame_collected): Update.
6195         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6196         Update.
6197         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6198         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6199         (mi_cmd_var_list_children, varobj_update_one): Update.
6200         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6201         (mi_cmd_stack_list_args, list_arg_or_local): Update.
6202         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6203         * inferior.c (print_inferior): Update.
6204         * gdb_bfd.c (print_one_bfd): Update.
6205         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6206         Update.
6207         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6208         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6209         do_field_int.  Change type of "value".
6210         * cli-out.c (cli_ui_out::do_field_signed): Rename from
6211         do_field_int.  Change type of "value".
6212         * breakpoint.c (watchpoint_check, print_breakpoint_location)
6213         (print_one_breakpoint_location, print_it_catch_fork)
6214         (print_one_catch_fork, print_it_catch_vfork)
6215         (print_one_catch_vfork, print_it_catch_solib)
6216         (print_it_catch_exec, print_it_ranged_breakpoint)
6217         (print_mention_watchpoint, print_mention_masked_watchpoint)
6218         (bkpt_print_it, update_static_tracepoint): Update.
6219         * break-catch-throw.c (print_it_exception_catchpoint): Update.
6220         * break-catch-syscall.c (print_it_catch_syscall): Update.
6221         * ada-tasks.c (print_ada_task_info): Update.
6222         * ada-lang.c (print_it_exception, print_mention_exception):
6223         Update.
6224
6225 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
6226
6227         PR breakpoints/24541
6228         * gdbarch.c: Regenerate.
6229         * gdbarch.h: Regenerate.
6230         * gdbarch.sh: Adjust return type and parameter types for
6231         'stap_adjust_register'.
6232         (i386_stap_adjust_register): Adjust signature and return new
6233         register name.
6234         * stap-probe.c (stap_parse_register_operand): Adjust use of
6235         'gdbarch_stap_adjust_register'.
6236
6237 2019-07-17  Tom Tromey  <tromey@adacore.com>
6238
6239         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
6240         declare VEC.
6241         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6242         std::vector.
6243         (struct s390_process_info): Add initializers.
6244         (s390_add_process): Use new.
6245         (s390_linux_nat_target::low_forget_process): Use delete.
6246         (s390_linux_nat_target::low_new_fork)
6247         (s390_linux_nat_target::stopped_by_watchpoint)
6248         (s390_linux_nat_target::low_prepare_to_resume)
6249         (s390_linux_nat_target::insert_watchpoint)
6250         (s390_linux_nat_target::insert_hw_breakpoint)
6251         (s390_linux_nat_target::remove_watchpoint)
6252         (s390_linux_nat_target::remove_hw_breakpoint): Update.
6253
6254 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6255
6256         * aarch64-fbsd-nat.c: Include regcache.h.
6257         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6258         argument.
6259         (aarch64_fbsd_nat_target::fetch_registers)
6260         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6261         variable.
6262         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6263
6264 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
6265
6266         * fbsd-nat.c: Include gdbarch.h.
6267
6268 2019-07-15  Tom Tromey  <tromey@adacore.com>
6269
6270         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6271
6272 2019-07-15  Tom Tromey  <tromey@adacore.com>
6273
6274         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6275         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6276         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6277         * cli-out.c (cli_ui_out::do_field_int): New method.
6278         * ui-out.c (ui_out::field_unsigned): New method.
6279         * symfile.c (generic_load): Use field_unsigned.
6280         (print_transfer_performance): Likewise.
6281         * record-btrace.c (ui_out_field_uint): Remove.
6282         (btrace_call_history_insn_range, btrace_call_history): Use
6283         field_unsigned.
6284         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6285         field_unsigned.
6286         * ui-out.h (class ui_out) <field_unsigned>: New method.
6287         <do_field_unsigned>: Likewise.
6288
6289 2019-07-15  Tom Tromey  <tromey@adacore.com>
6290
6291         * mi/mi-main.c (list_available_thread_groups): Use field_string.
6292         * mi/mi-interp.c (mi_memory_changed): Use field_string.
6293         * target.c (flash_erase_command): Use field_string.
6294         * infrun.c (print_signal_received_reason): Use field_string.
6295         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6296         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6297         field_string.
6298         * ada-tasks.c (print_ada_task_info): Use field_string.
6299
6300 2019-07-15  Tom Tromey  <tromey@adacore.com>
6301
6302         * target.c (flash_erase_command): Use field_core_addr.
6303         * symfile.c (generic_load): Use field_core_addr.
6304         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6305         Use field_core_addr.
6306         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6307         field_core_addr.
6308
6309 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6310
6311         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6312         value if its desired type is smaller than a CORE_ADDR and signed.
6313
6314 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6315
6316         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6317         of changes to field names, and use new is_reference field to
6318         decide if a property is a reference or not.
6319         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6320         field.
6321         (struct dwarf2_property_baton): Update header comment, rename
6322         'referenced_type' to 'property_type' and update comments.
6323         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6324         default property type, store in property baton, update to take
6325         accound of renamed field.
6326         (read_func_scope): Update call to attr_to_dynamic_prop.
6327         (read_array_type): Likewise.
6328         (dwarf2_per_cu_addr_sized_int_type): New function.
6329         (read_subrange_index_type): Move type finding code to
6330         dwarf2_per_cu_addr_sized_int_type.
6331         (read_subrange_type): Update calls to attr_to_dynamic_prop.
6332         (dwarf2_per_cu_addr_type): New function.
6333         (set_die_type): Update calls to attr_to_dynamic_prop.
6334
6335 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6336
6337         * dwarf2read.c (read_subrange_index_type): New function.
6338         (read_subrange_type): Move code into new function and call it.
6339         * gdbtypes.c (create_range_type): Add some asserts.
6340
6341 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6342
6343         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6344         update return statements.
6345         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6346         declaration, and update comment to match.
6347         * gdbtypes.c (resolve_dynamic_array): Update call to
6348         dwarf2_evaluate_property to match new return type.
6349
6350 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6351
6352         * valarith.c (value_subscripted_rvalue): Change lowerbound
6353         parameter type from int to LONGEST.
6354         * value.h (value_subscripted_rvalue): Likewise in declaration.
6355
6356 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6357
6358         * cli/cli-utils.c (info_print_command_completer): New function.
6359         * cli/cli-utils.h: Add 'completer.h' include, and forward
6360         declaration for 'struct cmd_list_element'.
6361         (info_print_command_completer): Declare.
6362         * stack.c (_initialize_stack): Add completer for 'info locals' and
6363         'info args'.
6364         * symtab.c (_initialize_symtab): Add completer for 'info
6365         variables' and 'info functions'.
6366         * NEWS: Mention completion for additional info commands.
6367
6368 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6369
6370         * cli/cli-utils.c (extract_info_print_args): Delete.
6371         (extract_arg_maybe_quoted): Delete.
6372         (info_print_options_defs): New variable.
6373         (make_info_print_options_def_group): New function.
6374         (extract_info_print_options): Define new function.
6375         * cli/cli-utils.h (extract_info_print_args): Delete.
6376         (struct info_print_options): New structure.
6377         (extract_info_print_options): Declare new function.
6378         * stack.c (info_locals_command): Update to use new
6379         extract_info_print_options, also add a header comment.
6380         (info_args_command): Likewise.
6381         * symtab.c (info_variables_command): Likewise.
6382         (info_functions_command): Likewise.
6383
6384 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6385
6386         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6387         to extract string arguments.
6388         * common/common-utils.c (extract_string_maybe_quoted): New function.
6389         * common/common-utils.h (extract_string_maybe_quoted): Declare.
6390
6391 2019-07-11  Tom Tromey  <tromey@adacore.com>
6392
6393         * main.c (get_init_files): Use GDBINIT, not gdbinit.
6394         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6395         * top.h (gdbinit): Don't declare.
6396         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6397         into...
6398         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
6399         * top.c (gdb_init): Don't call init_cli_cmds.
6400         (gdbinit): Remove.
6401         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6402
6403 2019-07-11  Tom Tromey  <tromey@adacore.com>
6404
6405         * python/py-inferior.c (add_thread_object): Don't use thread_obj
6406         after it has been moved.
6407
6408 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6409
6410         * valops.c (value_must_coerce_to_target): Change return type to
6411         bool.
6412         * value.h (value_must_coerce_to_target): Likewise.
6413
6414 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
6415
6416         * breakpoint.c (is_hardware_watchpoint): Remove
6417         forward-declaration.
6418         (is_masked_watchpoint): Change return type to bool.
6419         (is_tracepoint): Likewise.
6420         (is_breakpoint): Likewise.
6421         (is_hardware_watchpoint): Likewise.
6422         (is_watchpoint): Likewise.
6423         (is_no_memory_software_watchpoint): Likewise.
6424         (is_catchpoint): Likewise.
6425         (breakpoint_1): Make FILTER parameter's return type bool.
6426         is_masked_watchpoint): Change return type to bool.
6427         (save_breakpoints): Make FILTER parameter's return type bool.
6428         * breakpoint.h (is_breakpoint): Change return type to bool.
6429         (is_watchpoint): Likewise.
6430         (is_catchpoint): Likewise.
6431         (is_tracepoint): Likewise.
6432
6433 2019-07-10  Tom Tromey  <tom@tromey.com>
6434
6435         * defs.h: Don't include gdbarch.h.
6436         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6437         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6438         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6439         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6440         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6441         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6442         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6443         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6444         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6445         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6446         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6447         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6448         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6449         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6450         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6451         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6452         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6453         record-btrace.c, record.h, regcache-dump.c, regcache.h,
6454         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6455         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6456         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6457         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6458         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6459         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6460         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6461         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6462         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6463
6464 2019-07-10  Tom Tromey  <tromey@adacore.com>
6465
6466         * ada-lang.h (is_ada_exception_catchpoint): Declare.
6467         * breakpoint.c (init_ada_exception_breakpoint): Register as
6468         bp_catchpoint.
6469         (print_one_breakpoint_location, print_one_breakpoint): Use
6470         is_ada_exception_catchpoint.
6471         * ada-lang.c (class ada_catchpoint_location): Pass
6472         bp_loc_software_breakpoint to bp_location constructor.
6473         (is_ada_exception_catchpoint): New function.
6474
6475 2019-07-10  Tom Tromey  <tromey@adacore.com>
6476
6477         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
6478         VEC.
6479         (struct arm_exidx_entry): New method operator<.
6480         (struct arm_exidx_data) <section_maps>: Change type.
6481         (arm_exidx_data_free): Remove.
6482         (arm_exidx_data_key): Change type.  Move lower.
6483         (arm_exidx_new_objfile): Update.
6484         (arm_compare_exidx_entries): Remove.
6485         (arm_find_exidx_entry, _initialize_arm_tdep)
6486
6487 2019-07-10  Tom Tromey  <tromey@adacore.com>
6488
6489         * solib-spu.c (ocl_program_data_key): Change type.
6490         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6491         Update.
6492
6493 2019-07-10  Tom Tromey  <tromey@adacore.com>
6494
6495         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
6496         (struct solib_aix_inferior_data) <library_list>: Change type.
6497         (solib_aix_inferior_data_handle): Change type.
6498         (get_solib_aix_inferior_data): Update.
6499         (solib_aix_free_library_list): Remove.
6500         (library_list_start_library): Update.
6501         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6502         return type.
6503         (solib_aix_get_library_list)
6504         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6505         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6506
6507 2019-07-10  Tom Tromey  <tromey@adacore.com>
6508
6509         * solib-dsbt.c (struct dsbt_info): Add initializers.
6510         (solib_dsbt_pspace_data): Change type.
6511         (dsbt_pspace_data_cleanup): Remove.
6512         (get_dsbt_info, _initialize_dsbt_solib): Update.
6513
6514 2019-07-10  Tom Tromey  <tromey@adacore.com>
6515
6516         * spu-tdep.c (spu_overlay_data): Change type.
6517         (spu_get_overlay_table, spu_overlay_new_objfile)
6518         (_initialize_spu_tdep): Update.
6519
6520 2019-07-10  Tom Tromey  <tromey@adacore.com>
6521
6522         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6523         destructor.
6524         (dbx_objfile_data_key): Change type and declare later.
6525         (DBX_SYMFILE_INFO): Rewrite.
6526         * dbxread.c (dbx_objfile_data_key): Change type.
6527         (dbx_symfile_init): Update.
6528         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
6529         (coffstab_build_psymtabs, elfstab_build_psymtabs)
6530         (stabsect_build_psymtabs, _initialize_dbxread): Update.
6531
6532 2019-07-10  Tom Tromey  <tromey@adacore.com>
6533
6534         * jit.c (jit_program_space_key): Change type.  Move lower.
6535         (get_jit_program_space_data): Update.
6536         (jit_program_space_data_cleanup): Remove.
6537         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6538         Update.
6539         (struct jit_program_space_data): Add initializers.
6540
6541 2019-07-10  Tom Tromey  <tromey@adacore.com>
6542
6543         * solib-darwin.c (struct darwin_info): Add initializers.
6544         (solib_darwin_pspace_data): Change type.
6545         (darwin_pspace_data_cleanup): Remove.
6546         (get_darwin_info, _initialize_darwin_solib): Update.
6547
6548 2019-07-10  Tom Tromey  <tromey@adacore.com>
6549
6550         * remote-sim.c (struct sim_inferior_data): Add initializers,
6551         constructor, and destructor.
6552         (sim_inferior_data_key): Change type.  Move lower.
6553         (check_for_duplicate_sim_descriptor): Update.
6554         (get_sim_inferior_data): Use new.  Update.
6555         (~sim_inferior_data_cleanup): Rename from
6556         sim_inferior_data_cleanup.  Simplify.
6557         (gdbsim_close_inferior, simulator_command)
6558         (sim_command_completer, _initialize_remote_sim): Update.
6559         (next_pid, INITIAL_PID): Move earlier.
6560
6561 2019-07-10  Tom Tromey  <tromey@adacore.com>
6562
6563         * python/python-internal.h (create_thread_object): Return
6564         gdbpy_ref.
6565         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6566         * python/py-inferior.c (struct threadlist_entry): Add
6567         constructor.
6568         <thread_obj>: Now a gdbpy_ref.
6569         (thread_to_thread_object): Update.
6570         (add_thread_object): Use new.
6571         (delete_thread_object): Use delete.
6572         (infpy_threads): Update.
6573         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
6574         GIL.
6575
6576 2019-07-10  Tom Tromey  <tromey@adacore.com>
6577
6578         * valops.c (value_cast): Specialize error message for Ada.
6579
6580 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6581
6582         * breakpoint.c (breakpoint_1): Update doc and parameter names.
6583
6584 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
6585
6586         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6587         bpstat_should_step): Return bool, adjust comments.
6588         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6589         bpstat_should_step): Likewise.
6590
6591 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6592
6593         * features/Makefile: Use feature target descriptions for Arm.
6594         * features/arm/arm-core.c: Generate new file.
6595         * features/arm/arm-fpa.c: Likewise.
6596         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6597         * features/arm/arm-m-profile.c: Likewise.
6598         * features/arm/arm-vfpv2.c: Likewise.
6599         * features/arm/arm-vfpv3.c: Likewise.
6600         * features/arm/xscale-iwmmxt.c: Likewise.
6601         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6602
6603 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6604
6605         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6606         ptrace earlier.
6607
6608 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
6609
6610         * features/aarch64-pauth.c: Regenerate.
6611
6612 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
6613
6614         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6615         bool.
6616         (bpstat_what): Use false instead of 0.
6617
6618 2019-07-09  Pedro Alves  <palves@redhat.com>
6619
6620         * break-catch-throw.c (is_exception_catchpoint): New.
6621         * breakpoint.c (print_one_breakpoint_location): New parameter
6622         'raw_loc'.  Handle it.  Use
6623         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6624         looking at the breakpoint's type.
6625         (print_one_breakpoint): If handling "maint info breakpoints", also
6626         print locations of exception catchpoints.
6627         * breakpoint.h (is_exception_catchpoint): Declare.
6628
6629 2019-07-09  Pedro Alves  <palves@redhat.com>
6630
6631         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6632         "addr" field.
6633         (allocate_location_exception_catchpoint): New.
6634         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6635         (initialize_throw_catchpoint_ops): Install
6636         allocate_location_exception_catchpoint as allocate_location
6637         method.
6638         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6639         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6640         bp_loc_other.
6641         (breakpoint_address_is_meaningful): Delete.
6642         (bl_address_is_meaningful): New.
6643         (breakpoint_locations_match): Adjust comment.
6644         (bp_location_from_bp_type): New, factored out of...
6645         (bp_location::bp_location(breakpoint *)): ... this.
6646         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6647         factored out of...
6648         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
6649         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6650         breakpoint_address_is_meaningful.
6651         (bp_locations_compare): Adjust comment.
6652         (update_global_location_list): Use bl_address_is_meaningful
6653         instead of breakpoint_address_is_meaningful.
6654         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6655         explicit.
6656         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6657         * python/py-breakpoint.c (bppy_get_location): No longer check
6658         whether location is null.
6659
6660 2019-07-09  Pedro Alves  <palves@redhat.com>
6661
6662         PR c++/15468
6663         * breakpoint.c (print_one_breakpoint_location): Remove
6664         single-location assert.
6665
6666 2019-07-09  Tom Tromey  <tom@tromey.com>
6667
6668         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6669         * configure: Rebuild.
6670         * configure.ac: Change common to gdbsupport.
6671         * gdbsupport: Rename from common.
6672         * acinclude.m4: Change common to gdbsupport.
6673         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6674         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6675         gdbsupport.
6676         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6677         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6678         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6679         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6680         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6681         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6682         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6683         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6684         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6685         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
6686         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
6687         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
6688         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
6689         coff-pe-read.c, command.h, compile/compile-c-support.c,
6690         compile/compile-c.h, compile/compile-cplus-symbols.c,
6691         compile/compile-cplus-types.c, compile/compile-cplus.h,
6692         compile/compile-loc2c.c, compile/compile.c, completer.c,
6693         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
6694         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
6695         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
6696         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
6697         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
6698         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
6699         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
6700         features/aarch64-core.c, features/aarch64-fpu.c,
6701         features/aarch64-pauth.c, features/aarch64-sve.c,
6702         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
6703         features/i386/32bit-core.c, features/i386/32bit-linux.c,
6704         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
6705         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
6706         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
6707         features/i386/64bit-core.c, features/i386/64bit-linux.c,
6708         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
6709         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
6710         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
6711         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
6712         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
6713         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
6714         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
6715         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
6716         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
6717         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
6718         go32-nat.c, guile/guile.c, guile/scm-ports.c,
6719         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
6720         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
6721         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
6722         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
6723         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
6724         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
6725         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
6726         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
6727         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
6728         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
6729         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
6730         minsyms.c, mips-linux-tdep.c, namespace.h,
6731         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
6732         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
6733         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
6734         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
6735         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
6736         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
6737         nat/linux-waitpid.c, nat/mips-linux-watch.c,
6738         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
6739         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
6740         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
6741         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
6742         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
6743         procfs.c, producer.c, progspace.h, psymtab.h,
6744         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
6745         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
6746         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
6747         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
6748         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
6749         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
6750         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
6751         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
6752         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
6753         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
6754         target-memory.c, target.c, target.h, target/waitstatus.c,
6755         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
6756         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
6757         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
6758         unittests/array-view-selftests.c,
6759         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
6760         unittests/common-utils-selftests.c,
6761         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
6762         unittests/format_pieces-selftests.c,
6763         unittests/function-view-selftests.c,
6764         unittests/lookup_name_info-selftests.c,
6765         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
6766         unittests/mkdir-recursive-selftests.c,
6767         unittests/observable-selftests.c,
6768         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
6769         unittests/parse-connection-spec-selftests.c,
6770         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
6771         unittests/scoped_fd-selftests.c,
6772         unittests/scoped_mmap-selftests.c,
6773         unittests/scoped_restore-selftests.c,
6774         unittests/string_view-selftests.c, unittests/style-selftests.c,
6775         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
6776         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
6777         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
6778         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
6779         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
6780         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
6781
6782 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6783
6784         * linespec.c (decode_digits_list_mode): Set explicit_line to a
6785         bool value.
6786         (decode_digits_ordinary): Set explicit_line field in sal.
6787         * symtab.c (skip_prologue_sal): Don't skip prologue for a
6788         symtab_and_line that was set on an explicit line number in
6789         assembler code.  Do always update the recorded symtab and line if
6790         we do skip the prologue.
6791
6792 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6793
6794         * breakpoint.c (set_breakpoint_location_function): Remove
6795         explicit_loc parameter.
6796         (momentary_breakpoint_from_master): Update call to
6797         set_breakpoint_location_function.
6798         (add_location_to_breakpoint): Likewise.
6799
6800 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6801
6802         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
6803         required features based on default bfd type when no specific bfd
6804         is present.
6805
6806 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6807
6808         * NEWS: Mention that GDB printf and eval commands can now print
6809         C-style and Ada-style convenience var strings without
6810         calling the inferior.
6811         * printcmd.c (printf_c_string): Locally print GDB internal var
6812         instead of transiting via the inferior.
6813         (printf_wide_c_string): Likewise.
6814
6815 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6816
6817         PR breakpoints/25011
6818         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
6819
6820 2019-07-04  Tom Tromey  <tom@tromey.com>
6821
6822         PR tui/24724:
6823         * tui/tui-winsource.c (tui_clear_source_content): Update.
6824         (tui_source_window_base::set_is_exec_point_at): Fix comment.
6825         (tui_update_breakpoint_info): Update.
6826         (tui_set_exec_info_content): Update.
6827         * tui/tui-source.c (tui_set_source_content_nil): Update.
6828         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
6829         has_break.
6830         * tui/tui-data.h (enum tui_bp_flag): New.
6831         (tui_bp_flags): New enum flags type.
6832         (struct tui_source_element) <break_mode>: Change type.  Rename
6833         from has_break.
6834         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
6835         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
6836         constants.
6837         * tui/tui-winsource.h: Fix comment.
6838
6839 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6840
6841         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
6842         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
6843         (store_fpregs_to_thread)
6844         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6845         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
6846         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
6847         (IWMMXT_REGS_SIZE): Add define.
6848         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
6849         (fetch_vfp_regs, store_vfp_regs)
6850         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
6851         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
6852
6853 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6854
6855         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
6856         defines.
6857         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
6858         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
6859         (ARM_INT_REGISTER_SIZE): ...to this.
6860         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
6861         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
6862         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
6863         (arm_linux_collect_gregset, supply_nwfpe_register)
6864         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
6865         defines.
6866         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
6867         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
6868         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
6869         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
6870         (arm_return_in_memory, arm_store_return_value)
6871         (arm_get_longjmp_target, arm_register_g_packet_guesses)
6872         (arm_record_ld_st_multiple): Likewise.
6873         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
6874         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
6875
6876 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6877
6878         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
6879         AARCH64_DISPLACED_MODIFIED_INSNS.
6880         * aarch64-tdep.c (struct aarch64_displaced_step_data)
6881         (aarch64_displaced_step_copy_insn): Likewise.
6882         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6883         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
6884         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
6885         ARM_DISPLACED_MODIFIED_INSNS.
6886         * arm-tdep.c (arm_gdbarch_init): Likewise.
6887         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
6888         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
6889         (struct arm_displaced_step_closure): Use
6890         ARM_DISPLACED_MODIFIED_INSNS.
6891
6892 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6893
6894         * features/Makefile: Remove unused xml files.
6895         * features/aarch64.xml: Remove.
6896         * features/i386/amd64-avx-avx512-linux.xml: Remove.
6897         * features/i386/amd64-avx-avx512.xml: Remove.
6898         * features/i386/amd64-avx-linux.xml: Remove.
6899         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
6900         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
6901         * features/i386/amd64-avx-mpx-linux.xml: Remove.
6902         * features/i386/amd64-avx-mpx.xml: Remove.
6903         * features/i386/amd64-avx.xml: Remove.
6904         * features/i386/amd64-linux.xml: Remove.
6905         * features/i386/amd64-mpx-linux.xml: Remove.
6906         * features/i386/amd64-mpx.xml: Remove.
6907         * features/i386/amd64.xml: Remove.
6908         * features/i386/i386-avx-avx512-linux.xml: Remove.
6909         * features/i386/i386-avx-avx512.xml: Remove.
6910         * features/i386/i386-avx-linux.xml: Remove.
6911         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
6912         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
6913         * features/i386/i386-avx-mpx-linux.xml: Remove.
6914         * features/i386/i386-avx-mpx.xml: Remove.
6915         * features/i386/i386-avx.xml: Remove.
6916         * features/i386/i386-linux.xml: Remove.
6917         * features/i386/i386-mmx-linux.xml: Remove.
6918         * features/i386/i386-mmx.xml: Remove.
6919         * features/i386/i386-mpx-linux.xml: Remove.
6920         * features/i386/i386-mpx.xml: Remove.
6921         * features/i386/i386.xml: Remove.
6922         * features/i386/x32-avx-avx512-linux.xml: Remove.
6923         * features/i386/x32-avx-linux.xml: Remove.
6924         * features/i386/x32-linux.xml: Remove.
6925
6926 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6927
6928         * regformats/aarch64.dat: Remove.
6929         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
6930         * regformats/i386/amd64-avx-linux.dat: Remove.
6931         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
6932         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
6933         * regformats/i386/amd64-linux.dat: Remove.
6934         * regformats/i386/amd64-mpx-linux.dat: Remove.
6935         * regformats/i386/amd64.dat: Remove.
6936         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
6937         * regformats/i386/i386-avx-linux.dat: Remove.
6938         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
6939         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
6940         * regformats/i386/i386-linux.dat: Remove.
6941         * regformats/i386/i386-mmx-linux.dat: Remove.
6942         * regformats/i386/i386-mpx-linux.dat: Remove.
6943         * regformats/i386/i386.dat: Remove.
6944         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
6945         * regformats/i386/x32-avx-linux.dat: Remove.
6946         * regformats/i386/x32-linux.dat: Remove.
6947
6948 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
6949
6950         * aarch64-tdep.c: Remove xml self tests.
6951         * amd64-linux-tdep.c: Likewise.
6952         * amd64-tdep.c: Likewise.
6953         * i386-linux-tdep.c: Likewise.
6954         * i386-tdep.c: Likewise.
6955
6956 2019-07-03  Pedro Alves  <palves@redhat.com>
6957
6958         PR cli/24732
6959         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
6960         (pipe_cmd_option_defs): New.
6961         (make_pipe_cmd_options_def_group): New.
6962         (pipe_command): Use gdb::option::process_options.
6963         (pipe_command_completer): New function.
6964         (_initialize_cli_cmds): Install completer for "pipe" command.
6965
6966 2019-07-03  Pedro Alves  <palves@redhat.com>
6967
6968         * cli/cli-option.c (union option_value) <string>: New field.
6969         (struct option_def_and_value): Add ctor, move ctor, dtor and
6970         use DISABLE_COPY_AND_ASSIGN.
6971         (option_def_and_value::clear_value): New.
6972         (parse_option, save_option_value_in_ctx, get_val_type_str)
6973         (add_setshow_cmds_for_options): Handle var_string.
6974         * cli-option.h (union option_def::var_address) <string>: New
6975         field.
6976         (struct string_option_def): New.
6977         * maint-test-options.c (struct test_options_opts): Add default
6978         ctor and use DISABLE_COPY_AND_ASSIGN.
6979         <string_opt>: New field.
6980         (test_options_opts::~test_options_opts): New.
6981         (test_options_opts::dump): Also dump "-string".
6982         (test_options_option_defs): Install "string.
6983
6984 2019-07-03  Pedro Alves  <palves@redhat.com>
6985
6986         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
6987         option_value with a null enumeration.
6988         (complete_options): Save the option values in the context.
6989         (save_option_value_in_ctx): New, factored out from ...
6990         (process_options): ... here.
6991         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
6992         of the function.
6993         * maint-test-options.c (test_options_opts::dump): New, factored
6994         out from ...
6995         (maintenance_test_options_command_mode): ... here.
6996         (maintenance_test_options_command_completion_result): Delete.
6997         (maintenance_test_options_command_completion_text): Update
6998         comment.
6999         (maintenance_show_test_options_completion_result): Change
7000         prototype.  Just print
7001         maintenance_test_options_command_completion_text.
7002         (save_completion_result): New.
7003         (maintenance_test_options_completer_mode): Pass options context to
7004         complete_options, and then save a dump.
7005         (_initialize_maint_test_options): Use add_cmd to install "maint
7006         show test-options-completion-result".
7007
7008 2019-07-03  Pedro Alves  <palves@redhat.com>
7009
7010         * NEWS (New commands): Mention "with" and "maint with".
7011         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7012         (with_command, with_command_completer): New.
7013         (pipe_command): Adjust to new repeat_previous
7014         interface.
7015         (_initialize_cli_cmds): Install the "with" command and its "w"
7016         alias.
7017         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7018         declarations.
7019         * cli/cli-setshow.c (parse_cli_var_uinteger)
7020         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7021         argument strings for all var_types.
7022         (get_setshow_command_value_string): New, factored out from ...
7023         (do_show_command): ... this.
7024         * cli/cli-setshow.h: Include <string>.
7025         (get_setshow_command_value_string): Declare.
7026         * command.h (repeat_previous): Now returns const char *.  Adjust
7027         comment.
7028         * maint.c: Include "cli/cli-cmds.h".
7029         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7030         (_initialize_maint_cmds): Register the "maintenance with" command.
7031         * top.c (repeat_previous): Move bits from pipe_command here:
7032         Return the saved command line, if any; error out if there's no
7033         command to relaunch.
7034
7035 2019-07-03  Pedro Alves  <palves@redhat.com>
7036
7037         * NEWS (New commands): Mention "maint set/show test-settings"
7038         instead of "maint test-settings".
7039         * maint-test-settings.c (maintenance_test_settings_list): Delete.
7040         (maintenance_test_settings_set_list): Rename to ...
7041         (maintenance_set_test_settings_list): ... this.
7042         (maintenance_test_settings_show_list): Rename to  ...
7043         (maintenance_show_test_settings_list): ... this.
7044         (maintenance_test_settings_cmd): Delete.
7045         (maintenance_test_settings_set_cmd): ...
7046         (maintenance_set_test_settings_cmd): ... this.
7047         (maintenance_test_settings_show_cmd): ...
7048         (maintenance_show_test_settings_cmd): ... this.
7049         (maintenance_test_settings_show_value_cmd):
7050         (maintenance_show_test_settings_value_cmd): ... this.
7051         (_initialize_maint_test_settings): No longer install the "maint
7052         test-settings" prefix command.  Rename "maint test-settings set"
7053         to "maint set test-settings", and "maint test-settings show" to
7054         "maint show test-settings".  Adjust all subcommands.
7055
7056 2019-07-03  Pedro Alves  <palves@redhat.com>
7057
7058         * maint-test-settings.c: Fix file's intro comment.  Replace all
7059         references to "test-options" with references to "test-settings",
7060         in comments.
7061
7062 2019-07-03  Pedro Alves  <palves@redhat.com>
7063
7064         * maint-test-settings.c (maintenance_test_settings_xxx)
7065         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7066         New.
7067         (maintenance_test_settings_enums): Use them.
7068         (maintenance_test_settings_enum): Default to
7069         maintenance_test_settings_xxx.
7070         (_initialize_maint_test_settings): Initialize
7071         MAINTENANCE_TEST_SETTINGS_FILENAME.
7072
7073 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7074
7075         * breakpoint.h (remove_breakpoints_inf): Change return type to
7076         void, move function documentation here.
7077         * breakpoint.c (remove_breakpoints_inf): Change return type to
7078         void, move function documentation to header.
7079
7080 2019-07-02  Pedro Alves  <palves@redhat.com>
7081
7082         * NEWS (Completion improvements): Mention "info threads".
7083         * thread.c (struct info_threads_opts, info_threads_option_defs)
7084         (make_info_threads_options_def_group): New.
7085         (info_threads_command): Use gdb::option::process_options.
7086         (info_threads_command_completer): New.
7087         (_initialize_thread): Use gdb::option::build_help to build the
7088         help text for "info threads".
7089
7090 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
7091
7092         * defs.h (generic_load): Move from here...
7093         * symfile.h (generic_load): ... to here.  Rename name parameter
7094         to args.
7095         * symfile.c (generic_load): Add comment.
7096
7097 2019-07-01  Tom Tromey  <tromey@adacore.com>
7098
7099         * dwarf2read.c
7100         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7101         declaration of without_params.  Fix formatting.
7102
7103 2019-07-01  Tom Tromey  <tromey@adacore.com>
7104
7105         * ada-exp.y (find_primitive_type): Update.
7106         * ada-lang.h (ada_lookup_symbol): Update.
7107         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7108         parameter.
7109         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7110
7111 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7112
7113         PR breakpoints/24541
7114         * gdbarch.c: Regenerate.
7115         * gdbarch.h: Regenerate.
7116         * gdbarch.sh: Add 'stap_adjust_register'.
7117         * i386-tdep.c: Include '<unordered_set>'.
7118         (i386_stap_adjust_register): New function.
7119         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7120         * stap-probe.c (stap_parse_register_operand): Call
7121         'gdbarch_stap_adjust_register'.
7122
7123 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
7124
7125         PR python/24742
7126         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7127         * python/python.c (do_start_initialization): Use 'xmalloc'
7128         instead of 'PyMem_Malloc'.
7129
7130 2019-06-28  Tom Tromey  <tromey@adacore.com>
7131
7132         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7133         for Ada.
7134
7135 2019-06-27  Tom Tromey  <tromey@adacore.com>
7136
7137         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
7138         objfile_key.
7139         (arm_find_mapping_symbol, arm_record_special_symbol)
7140         (_initialize_arm_tdep): Update.
7141         (arm_objfile_data_free): Remove.
7142
7143 2019-06-27  Tom Tromey  <tromey@adacore.com>
7144
7145         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7146         to cp_print_static_field.
7147
7148 2019-06-26  Tom Tromey  <tromey@adacore.com>
7149
7150         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7151         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7152         declare.
7153
7154 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7155
7156         * features/aarch64-core.c (create_feature_aarch64_core):
7157         Regenerate.
7158         * features/aarch64-core.xml: Add cpsr flags.
7159
7160 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
7161
7162         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7163         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7164
7165 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7166
7167         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7168         field.
7169         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7170         use.
7171         (arm_record_special_symbol): Don't insert new symbol in sorted
7172         position, push it at the end.
7173
7174 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
7175
7176         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7177         (arm_mapping_symbol_s): Remove.
7178         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7179         (arm_mapping_symbol_vec): New typedef.
7180         (struct arm_per_objfile): Add constructor.
7181         <section_maps>: Change type to
7182         std::unique_ptr<arm_mapping_symbol_vec[]>.
7183         (arm_compare_mapping_symbols): Remove.
7184         (arm_find_mapping_symbol): Adjust to section_maps type change.
7185         (arm_objfile_data_free): Call delete on arm_per_objfile.
7186         (arm_record_special_symbol): Adjust to section_maps type change.
7187         Allocate arm_per_objfile with new.
7188
7189 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7190
7191         * cli/cli-cmds.c (alias_command): Compare the alias prefix
7192         with the command prefix.
7193
7194 2019-06-25  Tom Tromey  <tom@tromey.com>
7195
7196         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7197         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7198
7199 2019-06-25  Tom Tromey  <tom@tromey.com>
7200
7201         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7202         type.
7203         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7204         protected.
7205
7206 2019-06-25  Tom Tromey  <tom@tromey.com>
7207
7208         * tui/tui-winsource.c
7209         (tui_source_window_base::set_is_exec_point_at): Add check against
7210         LOA_ADDRESS.
7211
7212 2019-06-25  Tom Tromey  <tom@tromey.com>
7213
7214         * tui/tui-source.c (tui_set_source_content): Don't check before
7215         xfree.
7216         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7217
7218 2019-06-25  Tom Tromey  <tom@tromey.com>
7219
7220         * tui/tui-winsource.h (tui_update_source_window_as_is)
7221         (tui_alloc_source_buffer, tui_line_is_displayed)
7222         (tui_addr_is_displayed): Change type of win_info.
7223         * tui/tui-winsource.c (tui_update_source_window_as_is)
7224         (tui_clear_source_content, tui_show_source_line)
7225         (tui_show_source_content, tui_source_window_base::refill)
7226         (tui_source_window_base::set_is_exec_point_at)
7227         (tui_source_window_base::set_is_exec_point_at)
7228         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7229         (tui_alloc_source_buffer, tui_line_is_displayed)
7230         (tui_addr_is_displayed): Change type of win_info.  Update.
7231         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7232         (tui_source_window_base::do_make_visible_with_new_height):
7233         Update.
7234         * tui/tui-source.c (tui_set_source_content)
7235         (tui_set_source_content_nil)
7236         (tui_source_window::do_scroll_vertical): Update.
7237         * tui/tui-layout.c (show_layout): Update.
7238         * tui/tui-disasm.c (tui_set_disassem_content)
7239         (tui_disasm_window::do_scroll_vertical): Update.
7240         * tui/tui-data.h (tui_win_content): Remove.
7241         (struct tui_gen_win_info) <content, content_size>: Remove.
7242         (struct tui_source_element): Add initializers and destructor.
7243         (union tui_which_element, struct tui_win_element): Remove.
7244         (struct tui_source_window_base) <content>: New field.
7245         (struct tui_data_window): Remove destructor.
7246         (tui_alloc_content, tui_free_win_content)
7247         (tui_free_all_source_wins_content): Don't declare.
7248         * tui/tui-data.c (tui_initialize_static_data): Update.
7249         (init_content_element, tui_alloc_content): Remove.
7250         (~tui_gen_win_info): Update.
7251         (~tui_data_window, tui_free_all_source_wins_content)
7252         (tui_free_win_content, free_content, free_content_elements):
7253         Remove.
7254
7255 2019-06-25  Tom Tromey  <tom@tromey.com>
7256
7257         * tui/tui-winsource.h (tui_clear_source_content)
7258         (tui_erase_source_content, tui_show_source_content): Change type
7259         of win_info.
7260         * tui/tui-winsource.c (tui_clear_source_content)
7261         (tui_erase_source_content, tui_show_source_content): Change type
7262         of win_info.
7263         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7264         * tui/tui-source.h (tui_set_source_content_nil): Change type of
7265         win_info.
7266         * tui/tui-source.c (tui_set_source_content_nil): Change type of
7267         win_info.
7268         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7269
7270 2019-06-25  Tom Tromey  <tom@tromey.com>
7271
7272         * tui/tui-winsource.c (tui_clear_source_content)
7273         (tui_source_window_base::set_is_exec_point_at): Update.
7274         * tui/tui-source.c (tui_set_source_content_nil): Update.
7275         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7276         a bool.
7277         * tui/tui-data.c (init_content_element): Update.
7278
7279 2019-06-25  Tom Tromey  <tom@tromey.com>
7280
7281         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7282         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7283         * tui/tui-layout.c (init_and_make_win): Update.
7284         * tui/tui.h (enum tui_win_type): Update.
7285         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7286         tui_win_is_auxillary.
7287         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7288         tui_win_is_auxillary.
7289
7290 2019-06-25  Tom Tromey  <tom@tromey.com>
7291
7292         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7293         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7294         (tui_delete_data_content_windows, tui_display_all_data)
7295         (tui_data_window::do_scroll_vertical, tui_display_data_from):
7296         Update.
7297         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7298         * tui/tui-regs.c (tui_last_regs_line_no)
7299         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7300         (tui_show_registers): Update.
7301         (tui_show_register_group): Return void.  Update.
7302         (tui_display_registers_from, tui_display_reg_element_at_line)
7303         (tui_display_registers_from_line, tui_check_register_values):
7304         Update.
7305         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7306         member.
7307         (struct tui_data_window) <regs_content>: Now a std::vector.
7308         <regs_content_count>: Remove.
7309         (tui_add_content_elements, tui_free_data_content): Don't declare.
7310         * tui/tui-data.c (tui_data_window::clear_detail): Update.
7311         (init_content_element): Remove DATA_WIN case.  Add assert.
7312         (tui_add_content_elements): Remove.
7313         (tui_data_window): Update.
7314         (tui_free_data_content): Remove.
7315         (free_content_elements): Remove DATA_WIN case.
7316
7317 2019-06-25  Tom Tromey  <tom@tromey.com>
7318
7319         * tui/tui-data.c (tui_data_item_window): Update.
7320         * tui/tui-windata.h (tui_check_data_values): Don't declare.
7321         * tui/tui-windata.c (tui_display_all_data)
7322         (tui_display_data_from_line): Update.
7323         (tui_check_data_values): Remove.
7324         * tui/tui-regs.c (tui_show_register_group)
7325         (tui_display_reg_element_at_line): Update.
7326         * tui/tui-hooks.c (tui_register_changed)
7327         (tui_refresh_frame_and_register_information): Call
7328         tui_check_register_values.
7329         * tui/tui-data.h (struct tui_data_window) <data_content,
7330         data_content_count, data_type>: Remove.
7331         (enum tui_data_type): Remove.
7332
7333         * tui/tui-data.c (tui_data_window::clear_detail)
7334         (~tui_data_window): Update.
7335
7336 2019-06-25  Tom Tromey  <tom@tromey.com>
7337
7338         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7339         declare.
7340         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7341         Rename from tui_first_data_item_displayed.  Update.
7342         (tui_data_window::refresh_all)
7343         (tui_data_window::do_scroll_vertical): Update.
7344         * tui/tui-data.h (struct tui_data_window)
7345         <first_data_item_displayed>: Declare new method.
7346
7347 2019-06-25  Tom Tromey  <tom@tromey.com>
7348
7349         * tui/tui-data.h (tui_init_generic_part): Don't declare.
7350         * tui/tui-data.c (tui_init_generic_part): Remove, moving
7351         contents...
7352         (tui_initialize_static_data): ...here.
7353
7354 2019-06-25  Tom Tromey  <tom@tromey.com>
7355
7356         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7357         (tui_display_registers_from, tui_check_register_values): Update.
7358         (tui_display_register): Remove win_info parameter; update.
7359         (tui_get_register): Change type of parameters.
7360         * tui/tui-data.h (struct tui_data_element): Remove.
7361         (union tui_which_element) <data>: Remove.
7362         <data_window>: Change type.
7363         (struct tui_data_item_window): New.
7364         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7365         case.  Add assert.
7366         (~tui_data_item_window): New destructor.
7367         (free_content_elements): Remove DATA_ITEM_WIN case.
7368
7369 2019-06-25  Tom Tromey  <tom@tromey.com>
7370
7371         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7372         Remove.
7373
7374 2019-06-25  Tom Tromey  <tom@tromey.com>
7375
7376         * tui/tui-data.h (struct tui_command_element): Remove.
7377         (union tui_which_element) <command>: Remove.
7378         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
7379         assert.
7380         (free_content_elements): Remove CMD_WIN case.
7381
7382 2019-06-25  Tom Tromey  <tom@tromey.com>
7383
7384         * tui/tui-layout.c (tui_set_layout): Update.
7385         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7386         * tui/tui-data.c (layout_def): Update.
7387
7388 2019-06-25  Tom Tromey  <tom@tromey.com>
7389
7390         * tui/tui-wingeneral.c (tui_refresh_all): Update.
7391         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7392         (tui_source_window_base::set_new_height): Update.
7393         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7394         Update.
7395         (tui_set_locator_fullname, tui_set_locator_info)
7396         (tui_show_frame_info): Update.
7397         * tui/tui-source.c (tui_set_source_content)
7398         (tui_source_is_displayed): Update.
7399         * tui/tui-layout.c (show_source_disasm_command, show_data)
7400         (show_source_or_disasm_and_command): Update.
7401         * tui/tui-disasm.c (tui_set_disassem_content)
7402         (tui_get_begin_asm_address): Update.
7403         * tui/tui-data.h (struct tui_locator_element): Remove.
7404         (union tui_which_element) <locator>: Remove.
7405         (struct tui_locator_window): New.
7406         (tui_locator_win_info_ptr): Change return type.
7407         * tui/tui-data.c (_locator): Change type.
7408         (tui_locator_win_info_ptr): Change return type.
7409         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
7410         (tui_alloc_content): Add assert.
7411
7412 2019-06-25  Tom Tromey  <tom@tromey.com>
7413
7414         * tui/tui-winsource.c
7415         (tui_exec_info_window::maybe_allocate_content): New method.
7416         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7417         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7418         (make_source_or_disasm_window): Add cast.
7419         * tui/tui-data.h (union tui_which_element) <simple_string>:
7420         Remove.
7421         (struct tui_source_info): New.
7422         (struct tui_source_window_base) <execution_info>: Change type.
7423         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7424         case, and add assert.
7425         (tui_alloc_content): Add assert.
7426
7427 2019-06-25  Tom Tromey  <tom@tromey.com>
7428
7429         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7430         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7431         * tui/tui-data.c (tui_alloc_win_info): Remove.
7432
7433 2019-06-25  Tom Tromey  <tom@tromey.com>
7434
7435         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7436         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7437         can_highlight.
7438
7439 2019-06-25  Tom Tromey  <tom@tromey.com>
7440
7441         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7442         make_visible_with_new_height method.
7443         (tui_win_info::make_visible_with_new_height): New method.
7444         (tui_source_window_base::do_make_visible_with_new_height)
7445         (tui_data_window::do_make_visible_with_new_height)
7446         (tui_cmd_window::do_make_visible_with_new_height): New methods.
7447         (make_visible_with_new_height): Remove.
7448         (tui_resize_all, tui_adjust_win_heights): Use
7449         make_visible_with_new_height method.
7450         * tui/tui-data.h (struct tui_win_info)
7451         <do_make_visible_with_new_height, make_visible_with_new_height>:
7452         New methods.
7453         (struct tui_source_window_base, struct tui_data_window)
7454         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7455         methods.
7456
7457 2019-06-25  Tom Tromey  <tom@tromey.com>
7458
7459         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7460         method.
7461         (update_tab_width): Call update_tab_width method.
7462         * tui/tui-data.h (struct tui_win_info)
7463         (struct tui_source_window_base) <update_tab_width>: New methods.
7464
7465 2019-06-25  Tom Tromey  <tom@tromey.com>
7466
7467         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7468         parameter.
7469         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7470         parameter.
7471         (tui_gen_win_info::make_visible): Update.
7472         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7473         parameter.
7474         * tui/tui-data.h (enum tui_box): New enum.
7475         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7476
7477 2019-06-25  Tom Tromey  <tom@tromey.com>
7478
7479         * tui/tui-layout.c (make_source_or_disasm_window): Always use
7480         init_and_make_win for EXEC_INFO_WIN.
7481         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7482         longer inline.
7483         (struct tui_win_info) <~tui_win_info>: Inline.
7484         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7485         Don't declare.
7486         * tui/tui-data.c (source_win, disasm_win): Remove globals.
7487         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7488         Remove.
7489         (tui_initialize_static_data): Update.
7490         (~tui_gen_win_info): Handle more cleanup here.
7491         (~tui_source_window_base): Delete "execution_info".
7492         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7493
7494 2019-06-25  Tom Tromey  <tom@tromey.com>
7495
7496         * tui/tui-layout.c (make_command_window): Don't set
7497         can_highlight.
7498         (show_source_disasm_command): Call the reset method.
7499         (show_data): Don't set can_highlight.  Call the reset method.
7500         (tui_gen_win_info::reset): Rename from init_gen_win_info
7501         (init_and_make_win): Simplify.  Return tui_gen_win_info.
7502         (show_source_or_disasm_and_command): Call the reset method.
7503         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7504         (struct tui_cmd_window): Set can_highlight.
7505
7506 2019-06-25  Tom Tromey  <tom@tromey.com>
7507
7508         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7509         from make_visible.
7510         (tui_make_visible, tui_make_invisible): Rewrite.
7511         (tui_win_info::make_visible): Remove.
7512         (tui_source_window_base::make_visible): Update.
7513         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7514         method.  Moved from...
7515         (struct tui_win_info) <make_visible>: ...here.
7516
7517 2019-06-25  Tom Tromey  <tom@tromey.com>
7518
7519         * tui/tui-winsource.c
7520         (tui_source_window_base::do_scroll_horizontal): Remove direction
7521         parameter.
7522         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7523         direction parameter.
7524         * tui/tui-win.c (tui_win_info::forward_scroll)
7525         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7526         (tui_win_info::right_scroll): Update.
7527         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7528         direction parameter.
7529         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7530         direction parameter.
7531         * tui/tui-data.h (enum tui_scroll_direction): Remove.
7532         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7533         Remove direction parameter.
7534         (struct tui_source_window_base, struct tui_source_window)
7535         (struct tui_disasm_window, struct tui_data_window)
7536         (struct tui_cmd_window): Update.
7537
7538 2019-06-25  Tom Tromey  <tom@tromey.com>
7539
7540         * tui/tui-winsource.h (tui_set_exec_info_content)
7541         (tui_show_exec_info_content, tui_erase_exec_info_content)
7542         (tui_clear_exec_info_content, tui_update_exec_info): Change
7543         argument to tui_source_window_base.
7544         * tui/tui-winsource.c (tui_set_exec_info_content)
7545         (tui_show_exec_info_content, tui_erase_exec_info_content)
7546         (tui_clear_exec_info_content, tui_update_exec_info): Change
7547         argument to tui_source_window_base.
7548
7549 2019-06-25  Tom Tromey  <tom@tromey.com>
7550
7551         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7552         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7553
7554 2019-06-25  Tom Tromey  <tom@tromey.com>
7555
7556         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7557         check.
7558
7559 2019-06-25  Tom Tromey  <tom@tromey.com>
7560
7561         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7562         type to void.
7563         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7564         type to void.
7565         * tui/tui-source.c (tui_set_source_content): Update.
7566         * tui/tui-disasm.c (tui_set_disassem_content): Update.
7567
7568 2019-06-25  Tom Tromey  <tom@tromey.com>
7569
7570         * tui/tui-win.c (window_name_completer, tui_set_focus)
7571         (tui_all_windows_info): Use name method.
7572         * tui/tui-data.h (struct tui_gen_win_info)
7573         (struct tui_source_window, struct tui_disasm_window)
7574         (struct tui_data_window, struct tui_cmd_window) <name>: New
7575         method.
7576         (tui_win_name): Don't declare.
7577         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7578         (tui_win_name): Remove.
7579
7580 2019-06-25  Tom Tromey  <tom@tromey.com>
7581
7582         * tui/tui-winsource.h (tui_update_source_window)
7583         (tui_update_source_window_as_is): Change parameter type.
7584         * tui/tui-winsource.c (tui_update_source_window): Change win_info
7585         to be a tui_source_window_base.
7586         (tui_update_source_window_as_is): Likewise.
7587         * tui/tui-win.c (make_visible_with_new_height): Update.
7588
7589 2019-06-25  Tom Tromey  <tom@tromey.com>
7590
7591         * tui/tui-winsource.c (tui_erase_source_content)
7592         (tui_show_source_content, tui_show_exec_info_content)
7593         (tui_erase_exec_info_content): Use refresh_window method.
7594         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7595         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7596         from tui_refresh_win.
7597         (tui_data_window::refresh_window): New method.
7598         (tui_win_info::refresh, tui_source_window_base::refresh)
7599         (tui_refresh_all): Use refresh_window method.
7600         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7601         method.
7602         * tui/tui-regs.c (tui_display_register): Call refresh_window
7603         method.
7604         * tui/tui-layout.c (show_source_disasm_command)
7605         (show_source_or_disasm_and_command): Call refresh_window method.
7606         * tui/tui-data.h (struct tui_gen_win_info)
7607         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7608         New method.
7609
7610 2019-06-25  Tom Tromey  <tom@tromey.com>
7611
7612         * tui/tui.c (tui_rl_other_window, tui_enable)
7613         (tui_is_window_visible, tui_get_command_dimension): Update.
7614         * tui/tui-winsource.c (tui_update_source_window_as_is)
7615         (tui_clear_source_content, tui_erase_source_content)
7616         (tui_show_source_line, tui_source_window_base::refill)
7617         (tui_source_window_base::do_scroll_horizontal)
7618         (tui_source_window_base::set_is_exec_point_at)
7619         (tui_update_breakpoint_info, tui_set_exec_info_content)
7620         (tui_alloc_source_buffer, tui_line_is_displayed)
7621         (tui_addr_is_displayed): Update.
7622         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7623         (tui_check_and_display_highlight_if_needed)
7624         (tui_win_info::make_visible, tui_win_info::refresh)
7625         (tui_refresh_all): Update.
7626         * tui/tui-windata.c (tui_first_data_item_displayed)
7627         (tui_delete_data_content_windows, tui_erase_data_content)
7628         (tui_display_all_data, tui_data_window::refresh_all)
7629         (tui_check_data_values): Update.
7630         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7631         (tui_set_win_focus_to, tui_win_info::forward_scroll)
7632         (tui_win_info::backward_scroll, tui_refresh_all_win)
7633         (tui_resize_all, tui_set_focus, tui_all_windows_info)
7634         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7635         (tui_source_window_base::set_new_height)
7636         (tui_data_window::set_new_height)
7637         (make_invisible_and_set_new_height)
7638         (make_visible_with_new_height, new_height_ok)
7639         (parse_scrolling_args): Update.
7640         * tui/tui-stack.c (tui_show_frame_info): Update.
7641         * tui/tui-source.c (tui_set_source_content)
7642         (tui_set_source_content_nil, tui_source_is_displayed)
7643         (tui_source_window::do_scroll_vertical): Update.
7644         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7645         (tui_display_registers_from, tui_display_reg_element_at_line)
7646         (tui_check_register_values, tui_reg_command): Update.
7647         * tui/tui-layout.c (tui_default_win_height)
7648         (show_source_disasm_command, show_data, init_and_make_win)
7649         (show_source_or_disasm_and_command): Update.
7650         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7651         (tui_redisplay_readline, tui_mld_flush)
7652         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7653         (tui_getc): Update.
7654         * tui/tui-disasm.c (tui_set_disassem_content)
7655         (tui_disasm_window::do_scroll_vertical): Update.
7656         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7657         Now virtual.
7658         (struct tui_win_info): Derive from tui_gen_win_info.
7659         <~tui_win_info>: Mark as override.
7660         <generic>: Remove member.
7661         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7662         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7663         (~tui_data_window, ~tui_win_info)
7664         (tui_free_all_source_wins_content): Update.
7665         * tui/tui-command.c (tui_refresh_cmd_win): Update.
7666
7667 2019-06-25  Tom Tromey  <tom@tromey.com>
7668
7669         * tui/tui-layout.c (init_and_make_win): Use new.
7670         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7671         destructor, initializers.
7672         (tui_alloc_generic_win_info): Don't declare.
7673         * tui/tui-data.c (_locator): Add argument to constructor.
7674         (source_win, disasm_win): New globals.
7675         (exec_info): Remove.
7676         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7677         Update.
7678         (tui_alloc_generic_win_info): Remove.
7679         (init_content_element): Use new.
7680         (tui_win_info::tui_win_info): Update.
7681         (free_content_elements) <case DATA_WIN>: Use delete.
7682
7683 2019-06-25  Tom Tromey  <tom@tromey.com>
7684
7685         * tui/tui-wingeneral.c (tui_refresh_win): Update.
7686         * tui/tui-windata.c (tui_first_data_item_displayed)
7687         (tui_delete_data_content_windows): Update.
7688         * tui/tui-win.c (tui_data_window::set_new_height): Update.
7689         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7690         (tui_display_registers_from, tui_check_register_values): Update.
7691         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
7692         pointer.
7693         * tui/tui-data.c (init_content_element): Update.  Allocate the new
7694         window.
7695         (tui_free_data_content): Update.
7696         (free_content_elements) <case DATA_WIN>: Free the window.
7697
7698 2019-06-25  Tom Tromey  <tom@tromey.com>
7699
7700         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
7701         Update.
7702         * tui/tui-layout.c (make_command_window)
7703         (show_source_disasm_command, show_data, init_and_make_win)
7704         (show_source_or_disasm_and_command): Update.
7705         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
7706         method.
7707         <can_highight, is_highlighted>: Now bool.
7708         (tui_set_win_highlight): Don't declare.
7709         * tui/tui-data.c (tui_set_win_highlight): Remove.
7710
7711 2019-06-25  Tom Tromey  <tom@tromey.com>
7712
7713         * tui/tui-wingeneral.c (make_visible): Remove check of window
7714         type.
7715
7716 2019-06-25  Tom Tromey  <tom@tromey.com>
7717
7718         * tui/tui-win.c (tui_win_info::max_height)
7719         (tui_cmd_window::max_height): New methods.
7720         (new_height_ok): Call max_height.
7721         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
7722         <max_height>: New method.
7723
7724 2019-06-25  Tom Tromey  <tom@tromey.com>
7725
7726         * tui/tui-win.c (tui_source_window_base::set_new_height)
7727         (tui_data_window::set_new_height): New methods.
7728         (make_invisible_and_set_new_height): Call set_new_height method.
7729         * tui/tui-data.h (struct tui_win_info)
7730         (struct tui_source_window_base, struct tui_data_window)
7731         <set_new_height>: New method.
7732
7733 2019-06-25  Tom Tromey  <tom@tromey.com>
7734
7735         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
7736         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
7737         tui_refresh_data_win.
7738         * tui/tui-win.c (tui_source_window_base::refresh_all): New
7739         method.
7740         (tui_refresh_all_win): Call the refresh_all method.
7741         (tui_set_focus): Likewise.
7742         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
7743         (struct tui_source_window_base, struct tui_data_window) <refresh>:
7744         Likewise.
7745
7746 2019-06-25  Tom Tromey  <tom@tromey.com>
7747
7748         * tui/tui-winsource.h (tui_refill_source_window)
7749         (tui_set_is_exec_point_at): Don't declare.
7750         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
7751         (tui_source_window_base::refill): Rename from
7752         tui_refill_source_window.
7753         (tui_source_window_base::do_scroll_horizontal): Update.
7754         (tui_source_window_base::set_is_exec_point_at): Rename from
7755         tui_set_is_exec_point_at.
7756         (tui_update_all_breakpoint_info): Update.
7757         * tui/tui-stack.c (tui_show_frame_info): Update.
7758         * tui/tui-layout.c (show_data): Add cast.
7759         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
7760         * tui/tui-data.h (struct tui_source_window_base) <refill,
7761         set_is_exec_point_at>: New methods.
7762         (tui_source_windows, tui_add_to_source_windows): Update types.
7763         (tui_add_to_source_windows): Remove redundant declaration.
7764         * tui/tui-data.c (source_windows): Store tui_source_window_base.
7765         (tui_source_windows): Change return type.
7766         (tui_clear_source_windows_detail): Update.
7767         (tui_add_to_source_windows): Change type of parameter.
7768         (tui_free_all_source_wins_content): Update.
7769
7770 2019-06-25  Tom Tromey  <tom@tromey.com>
7771
7772         * tui/tui-wingeneral.c (tui_win_info::refresh)
7773         (tui_source_window_base::refresh): New methods.
7774         (tui_refresh_all): Call the refresh method.
7775         * tui/tui-data.h (struct tui_win_info)
7776         (struct tui_source_window_base) <refresh>: New method.
7777
7778 2019-06-25  Tom Tromey  <tom@tromey.com>
7779
7780         * tui/tui.h (tui_is_window_visible): Return bool.
7781         * tui/tui.c (tui_is_window_visible): Return bool.
7782         * tui/tui-wingeneral.c (tui_make_window, make_visible)
7783         (tui_make_visible, tui_make_invisible)
7784         (tui_win_info::make_visible)
7785         (tui_source_window_base::make_visible, make_all_visible)
7786         (tui_make_all_visible, tui_make_all_invisible): Update.
7787         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
7788         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
7789         bool.
7790         (struct tui_win_info, struct tui_source_window_base)
7791         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
7792         * tui/tui-data.c (tui_init_generic_part): Update.
7793
7794 2019-06-25  Tom Tromey  <tom@tromey.com>
7795
7796         * tui/tui-wingeneral.c (tui_win_info::make_visible)
7797         (tui_source_window_base::make_visible): New methods.
7798         (make_all_visible): Make method call.
7799         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
7800         (struct tui_source_window_base, struct tui_cmd_window): Override
7801         make_visible.
7802         (tui_win_is_source_type): Don't declare.
7803         * tui/tui-data.c (tui_win_is_source_type): Remove.
7804
7805 2019-06-25  Tom Tromey  <tom@tromey.com>
7806
7807         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
7808         NULL check.
7809
7810 2019-06-25  Tom Tromey  <tom@tromey.com>
7811
7812         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
7813         Inline constructor.  Add initializers for members.
7814         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
7815         constructors; now inline in class.
7816
7817 2019-06-25  Tom Tromey  <tom@tromey.com>
7818
7819         * tui/tui-regs.c (tui_show_registers): Update.
7820         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
7821         bool.
7822         * tui/tui-data.c (tui_data_window::clear_detail)
7823         (tui_data_window): Update.
7824
7825 2019-06-25  Tom Tromey  <tom@tromey.com>
7826
7827         * tui/tui-windata.c (tui_display_all_data)
7828         (tui_display_data_from_line, tui_display_data_from)
7829         (tui_check_data_values, tui_data_window::do_scroll_vertical):
7830         Update.
7831         * tui/tui-regs.c (tui_last_regs_line_no)
7832         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7833         (tui_show_registers, tui_show_register_group)
7834         (tui_display_registers_from, tui_display_reg_element_at_line)
7835         (tui_display_registers_from_line, tui_check_register_values)
7836         (tui_reg_next, tui_reg_prev): Update.
7837         * tui/tui-layout.c (tui_set_layout, show_data): Update.
7838         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
7839         tui_data_window.
7840         (struct tui_win_info) <detail>: Remove.  Add new fields from
7841         tui_data_info.
7842         (TUI_DATA_WIN): Add cast.
7843         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
7844         (~tui_data_window): Simplify.
7845
7846 2019-06-25  Tom Tromey  <tom@tromey.com>
7847
7848         * tui/tui-layout.c (show_source_disasm_command)
7849         (show_source_or_disasm_and_command): Update.
7850         * tui/tui-io.c (update_cmdwin_start_line)
7851         (tui_redisplay_readline): Update.
7852         * tui/tui-data.h (struct tui_command_info): Remove.
7853         (struct tui_win_info) <detail>: Remove command_info member.
7854         (struct tui_data_window) <start_line>: New member, from
7855         tui_command_info.
7856         (TUI_CMD_WIN): Add casts.
7857
7858 2019-06-25  Tom Tromey  <tom@tromey.com>
7859
7860         * tui/tui-winsource.c (tui_update_source_window)
7861         (tui_refill_source_window)
7862         (tui_source_window_base::do_scroll_horizontal)
7863         (tui_update_breakpoint_info, tui_set_exec_info_content)
7864         (tui_show_exec_info_content, tui_erase_exec_info_content)
7865         (tui_clear_exec_info_content): Update.
7866         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
7867         Update.
7868         * tui/tui-win.c (make_invisible_and_set_new_height)
7869         (make_visible_with_new_height): Update.
7870         * tui/tui-source.c (tui_set_source_content)
7871         (tui_show_symtab_source): Update.
7872         * tui/tui-layout.c (extract_display_start_addr)
7873         (show_source_disasm_command, show_data)
7874         (make_source_or_disasm_window)
7875         (show_source_or_disasm_and_command): Update.
7876         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
7877         (tui_disasm_window::do_scroll_vertical): Remove shadowing
7878         "gdbarch".
7879         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
7880         to tui_source_window_base.
7881         (struct tui_win_info) <detail>: Remove source_info member.
7882         (struct tui_source_window_base) <has_locator>: Inline.
7883         Move contents from tui_source_info; rename has_locator member to
7884         m_has_locator.
7885         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
7886         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
7887         header file.
7888         (tui_source_window_base::clear_detail, ~tui_source_window_base):
7889         Simplify.
7890         (tui_free_all_source_wins_content): Cast to
7891         tui_source_window_base.
7892
7893 2019-06-25  Tom Tromey  <tom@tromey.com>
7894
7895         * tui/tui-win.c (make_invisible_and_set_new_height)
7896         (make_visible_with_new_height): Call has_locator method.
7897         * tui/tui-layout.c (show_source_disasm_command, show_data)
7898         (show_source_or_disasm_and_command): Update for bool change.
7899         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
7900         (tui_win_info) <has_locator>: New method.
7901         (struct tui_source_window_base) <has_locator>: New method.
7902         (tui_win_has_locator): Don't declare.
7903         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
7904         from tui_win_has_locator.
7905         (tui_source_window_base): Use false, not FALSE.
7906
7907 2019-06-25  Tom Tromey  <tom@tromey.com>
7908
7909         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
7910         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
7911         clear_detail method directly.
7912         (tui_clear_win_detail): Remove.
7913
7914 2019-06-25  Tom Tromey  <tom@tromey.com>
7915
7916         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
7917         "this", not TUI_DISASM_WIN.
7918
7919 2019-06-25  Tom Tromey  <tom@tromey.com>
7920
7921         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
7922         declare.
7923         * tui/tui-winsource.c
7924         (tui_source_window_base::do_scroll_horizontal): Rename from
7925         tui_horizontal_source_scroll.
7926         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
7927         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
7928         from tui_vertical_data_scroll.
7929         * tui/tui-win.h (tui_scroll): Don't declare.
7930         * tui/tui-win.c (tui_win_info::forward_scroll)
7931         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7932         (tui_win_info::right_scroll): Rename and update.
7933         (tui_scroll_forward_command, tui_scroll_backward_command)
7934         (tui_scroll_left_command, tui_scroll_right_command): Update.
7935         (tui_scroll): Remove.
7936         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
7937         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
7938         from tui_vertical_source_scroll.
7939         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
7940         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
7941         from tui_vertical_disassem_scroll.
7942         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
7943         do_scroll_horizontal>: New methods.
7944         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
7945         Likewise.
7946         (struct tui_source_window_base): Add do_scroll_horizontal.
7947         (struct tui_source_window, struct tui_disasm_window): Add
7948         do_scroll_vertical.
7949         (struct tui_data_window, struct tui_cmd_window): Add
7950         do_scroll_horizontal and do_scroll_vertical.
7951         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
7952
7953 2019-06-25  Tom Tromey  <tom@tromey.com>
7954
7955         * tui/tui-data.h (struct tui_source_window_base): New struct.
7956         (struct tui_source_window): Derive from tui_source_window_base.
7957         (struct tui_disasm_window): New struct.
7958         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
7959         from tui_source_window::clear_detail.
7960         (tui_source_window_base): Rename from tui_source_window.
7961         (~tui_source_window_base): Rename from ~tui_source_window.
7962         (tui_alloc_win_info): Create a tui_disasm_window.
7963
7964 2019-06-25  Tom Tromey  <tom@tromey.com>
7965
7966         * tui/tui-data.h (struct tui_source_window)
7967         (struct tui_data_window): Declare destructors.
7968         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
7969         destructors.
7970         (tui_win_info): Simplify.
7971
7972 2019-06-25  Tom Tromey  <tom@tromey.com>
7973
7974         * tui/tui-winsource.c (tui_display_main)
7975         (tui_update_source_windows_with_addr)
7976         (tui_update_all_breakpoint_info): Update.
7977         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7978         (new_height_ok, parse_scrolling_args): Update.
7979         * tui/tui-stack.c (tui_show_frame_info): Update.
7980         * tui/tui-data.h (struct tui_list): Remove.
7981         (tui_source_windows): Return a reference to a std::vector.
7982         * tui/tui-data.c (source_windows): Now a std::vector.
7983         (tui_source_windows): Change return type.
7984         (tui_clear_source_windows): Rewrite.
7985         (tui_clear_source_windows_detail, tui_add_to_source_windows)
7986         (tui_free_all_source_wins_content): Rewrite.
7987
7988 2019-06-25  Tom Tromey  <tom@tromey.com>
7989
7990         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
7991         (struct tui_data_window, struct tui_cmd_window): Declare
7992         clear_detail method.
7993         * tui/tui-data.c (tui_source_window::clear_detail)
7994         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
7995         methods.
7996         (tui_clear_win_detail): Simplify.
7997
7998 2019-06-25  Tom Tromey  <tom@tromey.com>
7999
8000         * tui/tui-layout.c (make_source_window, make_disasm_window)
8001         (make_source_or_disasm_window): Remove win_info_ptr parameter.
8002         Return the new window.
8003         (show_source_disasm_command, show_data)
8004         (show_source_or_disasm_and_command): Update.
8005
8006 2019-06-25  Tom Tromey  <tom@tromey.com>
8007
8008         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8009         parameter.  Return the new window.
8010         (show_source_disasm_command): Update and remove NULL check.
8011         (show_source_or_disasm_and_command): Update.
8012
8013 2019-06-25  Tom Tromey  <tom@tromey.com>
8014
8015         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8016
8017 2019-06-25  Tom Tromey  <tom@tromey.com>
8018
8019         * tui/tui-data.h (struct tui_win_info): Make constructor
8020         protected.  Make destructor virtual.  Add initializers.
8021         (tui_source_window, tui_data_window, tui_cmd_window): New
8022         classes.
8023         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
8024         constructor.  Add "type" parameter.
8025         (tui_source_window, tui_data_window, tui_cmd_window): New
8026         constructors.
8027         (tui_alloc_win_info): Instantiate the appropriate subclass.
8028
8029 2019-06-25  Tom Tromey  <tom@tromey.com>
8030
8031         * tui/tui-win.c (tui_resize_all): Use delete.
8032         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8033         destructor.
8034         (tui_free_window): Don't declare.
8035         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8036         Update.
8037
8038 2019-06-25  Tom Tromey  <tom@tromey.com>
8039
8040         * tui/tui-data.h (struct tui_win_info): Add constructor.
8041         * tui/tui-data.c (tui_alloc_win_info): Use new.
8042         (tui_free_window): Use delete.
8043
8044 2019-06-22  Tom Tromey  <tom@tromey.com>
8045
8046         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8047         declare.
8048         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8049
8050 2019-06-22  Tom Tromey  <tom@tromey.com>
8051
8052         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8053         declare.
8054         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8055
8056 2019-06-22  Tom de Vries  <tdevries@suse.de>
8057
8058         * dwarf2read.c (create_addrmap_from_aranges)
8059         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8060         instead of '%zu'.
8061
8062 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
8063
8064         * dwarf2read.h (dwarf2_section_info_def): Remove.
8065         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8066         * dwarf2read.c (struct dwo_sections) <types>: Change type to
8067         std::vector<dwarf2_section_info>.
8068         (struct dwo_file) <~dwo_file>: Remove.
8069         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8070         types field.
8071         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8072         (dwarf2_read_debug_names): Likewise.
8073         (create_debug_types_hash_table): Change parameter type to
8074         array_view, adjust code accordingly.
8075         (dwarf2_locate_dwo_sections): Adjust to std::vector.
8076         (partial_die_info::fixup): Likewise.
8077         (determine_prefix): Likewise.
8078         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8079
8080 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8081
8082         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8083         gdb_bfd_ref_ptr.
8084         <~dwo_file>: Remove call to gdb_bfd_unref.
8085         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8086         gdb_bfd_ref_ptr::get.
8087
8088 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8089
8090         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8091         type to htab_up.
8092         * dwarf2read.c (struct dwo_file): Initialize fields.
8093         <~dwo_file>: New.
8094         (free_dwo_file): Remove, move content to ~dwo_file.
8095         (struct dwo_file_deleter): Remove.
8096         (dwo_file_up>: Remove custom deleter.
8097         (free_dwo_files): Remove.
8098         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8099         dwo_files.
8100         (process_skeletonless_type_units): Call unique_ptr::get.
8101         (allocate_dwo_file_hash_table): Add deleter to created hash
8102         table.  Change return type to htab_up.
8103         (lookup_dwo_file_slot): Don't memset dwo_file, call
8104         unique_ptr::get.
8105         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8106         (create_dwo_unit_in_dwp_v2): Likewise.
8107         (open_and_init_dwo_file): Likewise.
8108         (free_dwo_file_from_slot): Remove.
8109
8110 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
8111
8112         * dwarf2read.h (struct dwarf2_section_info) <readin,
8113         is_virtual>: Change type to bool.
8114         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8115         true instead of 1.
8116
8117 2019-06-19  Tom Tromey  <tom@tromey.com>
8118
8119         * tui/tui-data.h (tui_init_content_element): Don't declare.
8120
8121 2019-06-19  Tom Tromey  <tom@tromey.com>
8122
8123         * tui/tui-data.h (tui_init_win_info): Don't declare.
8124
8125 2019-06-19  Tom de Vries  <tdevries@suse.de>
8126
8127         * dwarf2read.h (abstract_to_concrete): Change type to
8128         std::unordered_map<sect_offset, std::vector<sect_offset>,
8129         gdb::hash_enum<sect_offset>>.
8130
8131 2019-06-19  Tom Tromey  <tromey@adacore.com>
8132
8133         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8134         EVAL_AVOID_SIDE_EFFECTS specially.
8135
8136 2019-06-19  Tom Tromey  <tromey@adacore.com>
8137
8138         * source-cache.c (highlighter): New global.
8139         (source_cache::get_source_lines): Create a highlighter on demand.
8140
8141 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
8142
8143         * defs.h (deprecated_interactive_hook): Delete declaration.
8144         * interps.c (clear_interpreter_hooks): Remove use of
8145         deprecated_interactive_hook.
8146         * top.c (deprecated_interactive_hook): Delete definition.
8147         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8148
8149 2019-06-18  Tom de Vries  <tdevries@suse.de>
8150
8151         PR gdb/24515
8152         * dwarf2read.h (abstract_to_concrete): Change type from
8153         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8154         std::unordered_map<sect_offset, std::vector<sect_offset>>.
8155         * dwarf2read.c (read_variable): Update.
8156         (dwarf2_fetch_die_loc_sect_off): Update.
8157
8158 2019-06-17  Tom de Vries  <tdevries@suse.de>
8159
8160         PR gdb/24617
8161         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8162         accessing parent[parent_len - 1].
8163
8164 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
8165
8166         PR gdb/24364
8167         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8168         call dtrace_process_dof with NULL dof.
8169
8170 2019-06-16  Tom de Vries  <tdevries@suse.de>
8171
8172         PR gdb/24445
8173         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8174
8175 2019-06-16  Tom Tromey  <tom@tromey.com>
8176
8177         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8178         (make_all_visible): Use address of member.
8179
8180 2019-06-16  Tom Tromey  <tom@tromey.com>
8181
8182         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8183         (tui_free_window, free_content, free_content_elements): Remove
8184         unnecessary cast.
8185         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8186         cast.
8187         * tui/tui-regs.c (tui_show_register_group)
8188         (tui_display_registers_from, tui_display_reg_element_at_line):
8189         Remove unnecessary cast.
8190
8191 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
8192
8193         * linux-nat.c (normal_mask): Delete.
8194         (_initialize_linux_nat): Don't initialise normal_mask.
8195
8196 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
8197
8198         PR gdb/24445
8199         * dwarf-index-write.h (write_psymtabs_to_index): Add
8200         dwz_basename parameter.
8201         * dwarf-index-write.c (write_gdbindex): Move file writing to
8202         write_gdbindex_1.  Change return type void.
8203         (assert_file_size): Move up, remove filename parameter.
8204         (write_gdbindex_1): New function.
8205         (write_debug_names): Change return type to void, call
8206         assert_file_size.
8207         (struct index_wip_file): New struct.
8208         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
8209         file logic to index_wip_file.  Write index for dwz file if
8210         needed.
8211         (save_gdb_index_command): Pass basename of dwz file, if present.
8212         * dwarf-index-cache.c (index_cache::store): Obtain and pass
8213         build-id of dwz file, if present.
8214         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8215         (dwarf2_get_dwz_file): Likewise.
8216         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8217         (dwarf2_get_dwz_file): Likewise.
8218
8219 2019-06-16  Tom Tromey  <tom@tromey.com>
8220
8221         * coffread.c (process_coff_symbol): Use xstrdup.
8222         * value.c (create_internalvar): Use xstrdup.
8223
8224 2019-06-16  Tom Tromey  <tom@tromey.com>
8225
8226         * valops.c (value_cast, value_slice): Remove unnecessary cast.
8227         * breakpoint.c (stopin_command, stopat_command)
8228         (until_break_command, decode_location_default): Remove unnecessary
8229         cast.
8230         * utils.c (subset_compare): Remove unnecessary cast.
8231         * ada-lang.c (ada_update_initial_language): Remove unnecessary
8232         cast.
8233         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8234         cast.
8235         * infcmd.c (path_command): Remove unnecessary cast.
8236         * coffread.c (decode_type): Remove unnecessary cast.
8237         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8238         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8239         * tui/tui-stack.c (tui_show_locator_content)
8240         (tui_show_frame_info): Remove unnecessary cast.
8241         * tui/tui-win.c (tui_scroll_forward_command)
8242         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8243         (parse_scrolling_args): Remove unnecessary cast.
8244         * tui/tui-data.c (init_win_info, tui_del_window)
8245         (tui_free_window, tui_del_data_windows, tui_free_data_content)
8246         (free_content_elements): Remove unnecessary cast.
8247         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8248         unnecessary cast.
8249         * tui/tui-source.c (tui_set_source_content)
8250         (tui_vertical_source_scroll): Remove unnecessary cast.
8251         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8252         cast.
8253         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8254         * tui/tui-regs.c (tui_display_registers_from)
8255         (tui_display_register): Remove unnecessary cast.
8256         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8257         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8258         (make_visible): Remove unnecessary cast.
8259         * tui/tui-winsource.c (tui_erase_source_content)
8260         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8261         unnecessary cast.
8262         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8263         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8264         * stabsread.c (read_type, read_array_type, read_range_type):
8265         Remove unnecessary cast.
8266         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8267         (parse_symbol, parse_type, upgrade_type, parse_external)
8268         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8269         unnecessary cast.
8270         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8271
8272 2019-06-16  Tom Tromey  <tom@tromey.com>
8273
8274         * tui/tui-data.c (tui_alloc_generic_win_info)
8275         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8276         checks.
8277
8278 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
8279             Andrew Burgess  <andrew.burgess@embecosm.com>
8280
8281         * f-typeprint.c (f_print_type): Don't return early for not
8282         associated or not allocated types.
8283         (f_type_print_varspec_suffix): Add print_rank parameter and print
8284         ranks of array types in case they dangling.
8285         (f_type_print_base): Add print_rank parameter.
8286
8287 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8288
8289         * NEWS: Mention new MI commands.
8290         * break-catch-throw.c (enum exception_event_kind): Move to
8291         breakpoint.h.
8292         (print_mention_exception_catchpoint): Output text as a single
8293         message.
8294         (catch_exception_command_1): Rename to...
8295         (catch_exception_event): ...this, make non-static, update header
8296         command, and change some parameter types.
8297         (catch_catch_command): Update for changes to
8298         catch_exception_command_1.
8299         (catch_throw_command): Likewise.
8300         (catch_rethrow_command): Likewise.
8301         * breakpoint.c (enum exception_event_kind): Delete.
8302         * breakpoint.h (enum exception_event_kind): Moved here from
8303         break-catch-throw.c.
8304         (catch_exception_event): Declare.
8305         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8306         (mi_cmd_catch_throw): New function.
8307         (mi_cmd_catch_rethrow): New function.
8308         (mi_cmd_catch_catch): New function.
8309         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8310         'catch-catch' entries.
8311         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8312         (mi_cmd_catch_rethrow): Declare.
8313         (mi_cmd_catch_catch): Declare.
8314
8315 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8316
8317         * annotate.c (annotate_source_line): Change return type to void,
8318         update implementation to match.
8319         * annotate.h (annotate_source_line): Change return type to void,
8320         update header comment.
8321         * stack.c (print_frame_info): Don't change what frame information
8322         is printed based on whether annotations are on or not.
8323
8324 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8325
8326         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8327         (annotate_source): Make static.
8328         (annotate_source_line): Moved from source.c and renamed from
8329         identify_source_line.  Update the return type.
8330         * annotate.h (annotate_source): Delete declaration.
8331         (annotate_source_line): Declaration moved from source.h, and
8332         renamed from identify_source_line.  Return type updated.
8333         * source.c (identify_source_line): Moved to annotate.c and renamed
8334         to annotate_source_line.
8335         (info_line_command): Remove check of annotation_level.
8336         * source.h (identify_source_line): Move declaration to annotate.h
8337         and rename to annotate_source_line.
8338         * stack.c: Add 'annotate.h' include.
8339         (print_frame_info): Remove check of annotation_level before
8340         calling annotate_source_line.
8341
8342 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8343
8344         * source-cache.c (source_cache::get_plain_source_lines): Use
8345         open_source_file_with_line_charpos instead of just
8346         open_source_file, remove call to find_source_lines.
8347         (source_cache::get_source_lines): Likewise.
8348         * source.c (find_source_lines): Make static.
8349         (get_filename_and_charpos): Renamed into...
8350         (open_source_file_with_line_charpos): ..this along with changes to
8351         return a scoped_fd, and some other minor clean ups.
8352         (identify_source_line): Use open_source_file_with_line_charpos.
8353         (search_command_helper): Use open_source_file_with_line_charpos
8354         instead of just open_source_file, remove call to
8355         find_source_lines.
8356         * source.h (open_source_file_with_line_charpos): Declare new
8357         function.
8358         (find_source_lines): Delete declaration.
8359
8360 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
8361
8362         * source.c (get_filename_and_charpos): Remove fullname
8363         parameter.
8364         (identify_source_line): Update call to get_filename_and_charpos.
8365
8366 2019-06-14  Tom Tromey  <tromey@adacore.com>
8367
8368         PR gdb/24502:
8369         * ui-style.h (skip_ansi_escape): Update comment.
8370         * ui-file.h (class no_terminal_escape_file): New class.
8371         * ui-file.c (no_terminal_escape_file::write)
8372         (no_terminal_escape_file::puts): New methods.
8373         * cli/cli-logging.c (handle_redirections): Use
8374         no_terminal_escape_file.
8375
8376 2019-06-14  Tom Tromey  <tromey@adacore.com>
8377
8378         * NEWS: Move convenience variable news above Python news.
8379
8380 2019-06-14  Tom Tromey  <tom@tromey.com>
8381
8382         * gnulib: Move directory to top-level.
8383         * configure.ac: Don't configure gnulib.
8384         * configure: Rebuild.
8385         * common/common-defs.h: Use new path to gnulib.
8386         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8387         (GNULIB_H): Remove.
8388         (INCGNU): Look in new gnulib location.
8389         (HFILES_NO_SRCDIR): Remove gnulib files.
8390         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8391         (generated_files): Remove GNULIB_H.
8392         ($(LIBGNU), all-lib): Remove targets.
8393         (distclean): Don't mention GNULIB_BUILDDIR.
8394         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8395
8396 2019-06-14  Tom Tromey  <tromey@adacore.com>
8397
8398         * symfile.c (add_symbol_file_command): Remove obsolete comment.
8399         Warn if symbol file does not provide any symbols.
8400
8401 2019-06-14  Tom Tromey  <tromey@adacore.com>
8402
8403         * source.c (find_and_open_source): Respect basenames_may_differ.
8404
8405 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
8406
8407         * annotate.c (annotate_breakpoints_invalid): Make use of
8408         scoped_restore_terminal_state.
8409         (annotate_frames_invalid): Likewise.
8410
8411 2019-06-14  Tom Tromey  <tromey@adacore.com>
8412
8413         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8414         allow assignment to an internalvar.
8415
8416 2019-06-14  Tom Tromey  <tromey@adacore.com>
8417
8418         * ada-lex.l: Allow "_" in attribute names.
8419
8420 2019-06-14  Tom Tromey  <tromey@adacore.com>
8421
8422         PR gdb/24653:
8423         * regcache.c (registers_changed): Don't call alloca.
8424         * top.c (execute_command): Don't call alloca.
8425
8426 2019-06-13  Pedro Alves  <palves@redhat.com>
8427
8428         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8429         'expression'.  When parsing an expression, error out if there's
8430         junk after "unlimited".
8431         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8432         (do_set_command): Adjust calls to is_unlimited_literal.
8433
8434 2019-06-13  Pedro Alves  <palves@redhat.com>
8435
8436         * compile/compile.c (make_compile_options_def_group): Add braces
8437         around array_view initializer.
8438         * thread.c (make_thread_apply_all_options_def_group)
8439         (make_thread_apply_all_options_def_group): Likewise.
8440
8441 2019-06-13  Pedro Alves  <palves@redhat.com>
8442
8443         * NEWS (New commands): Mention "maint test-options
8444         require-delimiter", "maint test-options unknown-is-error", "maint
8445         test-options unknown-is-operand" and "maint show
8446         test-options-completion-result".
8447         (New command options, command completion): New section.
8448         (Completion improvements): New section.
8449         Mention that you can abbreviate "unlimited".
8450
8451 2019-06-13  Pedro Alves  <palves@redhat.com>
8452
8453         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8454         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8455         * unittests/cli-utils-selftests.c (test_parse_flags)
8456         (test_parse_flags_qcs): Delete.
8457         (test_cli_utils): Don't call deleted functions.
8458
8459 2019-06-13  Pedro Alves  <palves@redhat.com>
8460
8461         * thread.c: Include "cli/cli-option.h".
8462         (tp_array_compar_ascending): Global.
8463         (tp_array_compar): Delete function.
8464         (tp_array_compar_ascending, tp_array_compar_descending): New
8465         functions.
8466         (ascending_option_def, qcs_flag_option_def)
8467         (thr_qcs_flags_option_defs)
8468         (make_thread_apply_all_options_def_group)
8469         (make_thread_apply_options_def_group): New.
8470         (thread_apply_all_command): Use gdb::option::process_options.
8471         (thread_apply_command_completer)
8472         (thread_apply_all_command_completer): New.
8473         (thread_apply_command): Use gdb::option::process_options.
8474         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8475         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
8476         to generate help text of "thread apply".  Adjust "taas"'s help.
8477         * tid-parse.c (tid_range_parser::in_thread_range): New method.
8478         * tid-parse.h (tid_range_parser::in_thread_range): New method.
8479
8480 2019-06-13  Pedro Alves  <palves@redhat.com>
8481
8482         * thread.c (thread_apply_command): Check for invalid TID with
8483         isdigit instead of !isalpha.
8484
8485 2019-06-13  Pedro Alves  <palves@redhat.com>
8486
8487         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8488         (validate_flags_qcs): New.
8489         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8490         (validate_flags_qcs): Declare.
8491         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8492         (make_frame_apply_options_def_group): New.
8493         (frame_apply_command_count): Process options with
8494         gdb::option::process_options.
8495         (frame_apply_completer): New.
8496         (frame_apply_level_completer, frame_apply_all_completer)
8497         (frame_apply_completer): New.
8498         (_initialize_stack): Update help of "frame apply", "frame apply
8499         level", "frame apply all" and "faas" to mention supported options
8500         and install command completers.
8501         * stack.h (frame_apply_all_completer): Declare.
8502         * thread.c: Include "stack.h".
8503         (tfaas_command): Add "--".
8504         (_initialize_thread): Update help "tfaas" to mention supported
8505         options and install command completer.
8506
8507 2019-06-13  Pedro Alves  <palves@redhat.com>
8508
8509         * completer.c (complete_nested_command_line): New.
8510         (gdb_completion_word_break_characters_throw): Add assertion.
8511         * completer.h (complete_nested_command_line): Declare.
8512
8513 2019-06-13  Pedro Alves  <palves@redhat.com>
8514
8515         * stack.c (parse_backtrace_qualifiers): New.
8516         (backtrace_command): Use it.
8517         (backtrace_command_completer): Complete on qualifiers.
8518
8519 2019-06-13  Pedro Alves  <palves@redhat.com>
8520
8521         * frame.c: Include "cli/cli-option.h.
8522         (user_set_backtrace_options): New.
8523         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8524         Delete.
8525         (get_prev_frame): Adjust.
8526         (boolean_option_def, uinteger_option_def)
8527         (set_backtrace_option_defs): New.
8528         (_initialize_frame): Adjust and use
8529         gdb::option::add_setshow_cmds_for_options to install "set
8530         backtrace past-main" and "set backtrace past-entry".
8531         * frame.h: Include "cli/cli-option.h".
8532         (struct frame_print_options): Forward declare.
8533         (print_frame_arguments_all, print_frame_arguments_scalars)
8534         (print_frame_arguments_none): Declare.
8535         (print_entry_values): Delete declaration.
8536         (struct frame_print_options, user_frame_print_options): New.
8537         (struct set_backtrace_options): New.
8538         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8539         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8540         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8541         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8542         (list_args_or_locals): Add frame_print_options parameter.
8543         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8544         * python/py-framefilter.c (enumerate_args): Pass down
8545         USER_FRAME_PRINT_OPTIONS.
8546         * stack.c: Include "cli/cli-option.h".
8547         (print_frame_arguments_all, print_frame_arguments_scalars)
8548         (print_frame_arguments_none): Declare.
8549         (print_raw_frame_arguments, print_entry_values): Delete.
8550         (user_frame_print_options): New.
8551         (boolean_option_def, enum_option_def, frame_print_option_defs):
8552         New.
8553         (struct backtrace_cmd_options): New.
8554         (bt_flag_option_def): New.
8555         (backtrace_command_option_defs): New.
8556         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8557         (print_frame_arg, read_frame_arg, print_frame_args)
8558         (print_frame_info, print_frame): Add frame_print_options parameter
8559         and use it.
8560         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8561         (backtrace_command_1): Add frame_print_options and
8562         backtrace_cmd_options parameters and use them.
8563         (make_backtrace_options_def_group): New.
8564         (backtrace_command): Process command options with
8565         gdb::option::process_options.
8566         (backtrace_command_completer): New.
8567         (_initialize_stack): Extend "backtrace"'s help to mention
8568         supported options.  Install completer for "backtrace".
8569         Install some settings commands with add_setshow_cmds_for_options.
8570
8571 2019-06-13  Pedro Alves  <palves@redhat.com>
8572
8573         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8574         and that "set/show print raw frame-arguments" are now deprecated.
8575
8576         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8577         command.
8578         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8579         * stack.c (_initialize_stack): Install "set/show print
8580         raw-frame-arguments", and deprecate "set/show print raw
8581         frame-arguments".
8582         * valprint.c (_initialize_valprint): Deprecate "set/show print
8583         raw".
8584
8585 2019-06-13  Pedro Alves  <palves@redhat.com>
8586
8587         * compile/compile.c (struct compile_options): New.
8588         (compile_flag_option_def, compile_command_option_defs)
8589         (make_compile_options_def_group): New.
8590         (compile_file_command): Handle options with
8591         gdb::option::process_options.
8592         (compile_file_command_completer): New function.
8593         (compile_code_command): Handle options with
8594         gdb::option::process_options.
8595         (compile_code_command_completer): New function.
8596         (_initialize_compiler): Install completers for "compile code" and
8597         "compile file".  Mention available options in "compile code" and
8598         "compile code"'s help.
8599         * completer.c (advance_to_completion_word): New, factored out from
8600         ...
8601         (advance_to_expression_complete_word_point): ... this.
8602         (advance_to_filename_complete_word_point): New.
8603         * completer.h (advance_to_filename_complete_word_point): New
8604         declaration.
8605
8606 2019-06-13  Pedro Alves  <palves@redhat.com>
8607
8608         * compile/compile.c: Include "cli/cli-option.h".
8609         (compile_print_value): Scope data pointer is now a
8610         value_print_options pointer; adjust.
8611         (compile_print_command): Process options.  Scope data pointer is
8612         now a value_print_options pointer; adjust.
8613         (_initialize_compile): Update "compile print"'s help to include
8614         supported options.  Install a completer for "compile print".
8615         * cp-valprint.c (show_vtblprint, show_objectprint)
8616         (show_static_field_print): Delete.
8617         (_initialize_cp_valprint): Don't install "set print
8618         static-members", "set print vtbl", "set print object" here.
8619         * printcmd.c: Include "cli/cli-option.h" and
8620         "common/gdb_optional.h".
8621         (print_command_parse_format): Rework to fill in a
8622         value_print_options instead of a format_data.
8623         (print_value): Change parameter type from format_data pointer to
8624         value_print_options reference.  Adjust.
8625         (print_command_1): Process options.  Adjust to pass down a
8626         value_print_options.
8627         (print_command_completer): New.
8628         (_initialize_printcmd): Install print_command_completer as
8629         handle_brkchars completer for the "print" command.  Update
8630         "print"'s help to include supported options.
8631         * valprint.c: Include "cli/cli-option.h".
8632         (show_vtblprint, show_objectprint, show_static_field_print): Moved
8633         here from cp-valprint.c.
8634         (boolean_option_def, uinteger_option_def)
8635         (value_print_option_defs, make_value_print_options_def_group):
8636         New.  Use gdb::option::add_setshow_cmds_for_options to install
8637         "set print elements", "set print null-stop", "set print repeats",
8638         "set print pretty", "set print union", "set print array", "set
8639         print address", "set print symbol", "set print array-indexes".
8640         * valprint.h: Include <string> and "cli/cli-option.h".
8641         (make_value_print_options_def_group): Declare.
8642         (print_value): Change parameter type from format_data pointer to
8643         value_print_options reference.
8644         (print_command_completer): Declare.
8645
8646 2019-06-13  Pedro Alves  <palves@redhat.com>
8647
8648         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8649         (COMMON_SFILES): Add maint-test-settings.c.
8650         * cli/cli-decode.c (boolean_enums): New global, factored out from
8651         ...
8652         (add_setshow_boolean_cmd): ... here.
8653         * cli/cli-decode.h (boolean_enums): Declare.
8654         * cli/cli-option.c: New file.
8655         * cli/cli-option.h: New file.
8656         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8657         factored out from ...
8658         (parse_cli_boolean_value(const char *)): ... this.
8659         (is_unlimited_literal): Change parameter type to pointer to
8660         pointer.  Adjust and advance ARG pointer.
8661         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8662         (parse_cli_var_enum): New, factored out from ...
8663         (do_set_command): ... this.  Adjust.
8664         * cli/cli-setshow.h (parse_cli_boolean_value)
8665         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8666         (parse_cli_var_enum): Declare.
8667         * cli/cli-utils.c: Include "cli/cli-option.h".
8668         (get_ulongest): New.
8669         * cli/cli-utils.h (get_ulongest): Declare.
8670         (check_for_argument): New overloads.
8671         * maint-test-options.c: New file.
8672
8673 2019-06-13  Pedro Alves  <palves@redhat.com>
8674
8675         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8676         parse a range if "-" is at the end of the string.
8677
8678 2019-06-13  Pedro Alves  <palves@redhat.com>
8679
8680         * cli/cli-setshow.c (parse_auto_binary_operation)
8681         (parse_cli_boolean_value): Don't allow "o".
8682
8683 2019-06-13  Pedro Alves  <palves@redhat.com>
8684
8685         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
8686         * NEWS: Mention maint test-settings KIND.
8687         * maint-test-settings.c: New file.
8688
8689 2019-06-13  Pedro Alves  <palves@redhat.com>
8690
8691         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
8692         completer.
8693         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
8694         "set" completers.
8695
8696 2019-06-13  Pedro Alves  <palves@redhat.com>
8697
8698         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
8699         after item.
8700
8701 2019-06-13  Pedro Alves  <palves@redhat.com>
8702
8703         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
8704
8705 2019-06-13  Pedro Alves <palves@redhat.com>
8706
8707         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
8708         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
8709         call.
8710         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
8711         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
8712         calls.
8713         (check_for_argument): Skip spaces after argument.
8714
8715 2019-06-13  Pedro Alves  <palves@redhat.com>
8716
8717         * thread.c (thread_apply_command): Adjust TID parsing.
8718         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
8719         detected before end of string.
8720         (tid_is_in_list): Error out if LIST is invalid.
8721
8722 2019-06-13  Pedro Alves  <palves@redhat.com>
8723
8724         * completer.c (complete_line_internal_1): Rewind completion word
8725         point.
8726         (completion_tracker::advance_custom_word_point_by): Change
8727         parameter type to int.
8728         * completer.h (completion_tracker::advance_custom_word_point_by):
8729         Likewise.
8730
8731 2019-06-13  Pedro Alves  <palves@redhat.com>
8732
8733         * completer.c (advance_to_completion_word): Handle delimiters.
8734
8735 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
8736
8737         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
8738
8739 2019-06-11  Tom Tromey  <tom@tromey.com>
8740
8741         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
8742         (xmalloc_failed): Move to alloc.c.
8743         * alloc.c: New file.
8744         * Makefile.in (COMMON_SFILES): Add alloc.c.
8745
8746 2019-06-11  Tom Tromey  <tom@tromey.com>
8747
8748         * nat/linux-waitpid.c: Don't include server.h.
8749         (linux_debug): Remove.
8750         (my_waitpid): Update.
8751
8752 2019-06-11  Tom Tromey  <tromey@adacore.com>
8753
8754         * infcall.c (_initialize_infcall): Remove trailing newline from
8755         help.
8756         * user-regs.c (_initialize_user_regs): Remove trailing newline
8757         from help.
8758         * typeprint.c (_initialize_typeprint): Remove trailing newline
8759         from help.
8760         * reverse.c (_initialize_reverse): Remove trailing newlines from
8761         help.
8762         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
8763         from help.
8764         * language.c (add_set_language_command): Remove trailing newline
8765         from help.
8766         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
8767         help.
8768         * disasm.c (_initialize_disasm): Remove trailing newline from
8769         help.
8770         * top.c (init_main): Remove trailing newline from help.
8771         * interps.c (_initialize_interpreter): Remove trailing newline
8772         from help.
8773         * btrace.c (_initialize_btrace): Remove trailing newlines from
8774         help.
8775         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
8776         from help.
8777         * python/python.c (_initialize_python): Remove trailing newline
8778         from help.
8779         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
8780         help.
8781         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
8782         from help.  Reformat some text.
8783         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
8784         from help.
8785         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
8786         newline from help.
8787
8788 2019-06-11  Tom Tromey  <tromey@adacore.com>
8789
8790         * darwin-nat.c (darwin_decode_exception_message)
8791         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
8792
8793 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8794
8795         * valops.c (value_slice): Check for not allocated or not
8796         associated values.
8797
8798 2019-06-10  Tom de Vries  <tdevries@suse.de>
8799
8800         PR gdb/24618
8801         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
8802         sure an empty slot (defined by a 32-bit zero pair) is recognized as
8803         invalid.
8804
8805 2019-06-10  Tom de Vries  <tdevries@suse.de>
8806
8807         PR gdb/24611
8808         * linespec.c (linespec_lexer_lex_string): Remove incorrect
8809         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
8810
8811 2019-06-10  Tom de Vries  <tdevries@suse.de>
8812
8813         PR symtab/24545
8814         * symtab.c (struct demangled_name_entry): Add language field.
8815         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
8816         static minimal symbol".  Set and use language field.
8817
8818 2019-06-10  Tom Tromey  <tromey@adacore.com>
8819
8820         * ada-lang.c (_initialize_ada_language): Update help text.
8821
8822 2019-06-10  Tom Tromey  <tromey@adacore.com>
8823
8824         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
8825         with a newline.
8826         * guile/guile.c (handle_boot_error): Don't end warning with a
8827         newline.
8828         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
8829         warning with a newline.
8830         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
8831         newline.
8832         (s12z_frame_cache): Likewise.
8833         * dwarf-index-cache.c (index_cache::store): Don't end warning with
8834         a newline.
8835         * solib-svr4.c (disable_probes_interface): Don't end warning with
8836         a newline.
8837         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
8838         newline.
8839         * python/python.c (do_finish_initialization): Don't end warning
8840         with a newline.
8841
8842 2019-06-10  Tom Tromey  <tom@tromey.com>
8843
8844         * python/py-breakpoint.c (gdbpy_breakpoint_created)
8845         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
8846         gdbpy_enter.
8847
8848 2019-06-10  Tom Tromey  <tromey@adacore.com>
8849
8850         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
8851         data.
8852         (elf_new_init): Don't call stabsread_new_init.
8853         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
8854         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
8855         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
8856
8857 2019-06-10  Tom de Vries  <tdevries@suse.de>
8858
8859         PR symtab/16264
8860         PR symtab/24517
8861         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
8862
8863 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
8864
8865         * source.c (find_and_open_source): Also rewrite relative file
8866         names.
8867
8868 2019-04-26  Amos Bird  <amosbird@gmail.com>
8869
8870         * annotate.c (annotate_thread_exited): Add "thread-exited"
8871         annotation.
8872
8873 2019-06-06  Tom Tromey  <tromey@adacore.com>
8874
8875         * maint.h (class scoped_command_stats): Use
8876         DISABLE_COPY_AND_ASSIGN.
8877         <print_time>: New method.
8878         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
8879         print_time.
8880         (scoped_command_stats::print_time): New method.
8881
8882 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
8883
8884         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
8885         instructions of lengths 6 or 8 bytes.
8886
8887 2019-06-04  Pedro Alves  <palves@redhat.com>
8888
8889         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
8890
8891         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
8892         * breakpoint.c (condition_completer): Likewise.
8893         * cli/cli-dump.c (scan_expression): Likewise.
8894         * common/filestuff.c (mkdir_recursive): Likewise.
8895         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
8896         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
8897         (gdb_abspath): Likewise.
8898         * compile/compile-cplus-types.c
8899         (compile_cplus_instance::decl_name): Likewise.
8900         * completer.c (complete_explicit_location):
8901         (signal_completer, reg_or_group_completer_1): Likewise.
8902         * cp-support.c (cp_remove_params_if_any): Likewise.
8903         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
8904         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
8905         * infcmd.c (strip_bg_char): Likewise.
8906         * linespec.c (copy_token_string): Likewise.
8907         * mi/mi-main.c (output_cores): Likewise.
8908         * psymtab.c (psymtab_search_name):
8909         * symfile.c (test_set_ext_lang_command): Likewise.
8910         * target.c (target_fileio_read_stralloc): Likewise.
8911         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
8912         * value.c (complete_internalvar): Likewise.
8913
8914 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
8915
8916         Add objfile property to gdb.Type.
8917         * NEWS: Mention Python API addition.
8918         * python/py-type.c (typy_get_objfile): New method.
8919
8920 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8921
8922         * NEWS: Mention the new set|show style [title|highlight].
8923         Mention changes to "show style", "help" and "apropos".
8924
8925 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8926
8927         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
8928         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
8929         instead of print_help_for_command.
8930         (print_doc_of_command): New function.
8931         (help_list): Add 'apropos -v word' suggestion.
8932         (print_help_for_command): Style the command name using title style.
8933         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
8934         (_initialize_cli_cmds): Describe -v in apropos_command help.
8935
8936 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8937
8938         * cli/cli-style.h (cli_style_option): Add name in constructor,
8939         add m_name class member, add constructor with intensity,
8940         add name class function.
8941         (cli_style_option::add_setshow_commands): Remove name argument.
8942         (highlight_style, title_style): New styles.
8943         * cli/cli-style.c (do_show): New function that shows a style
8944         characteristic styling the style name with itself.
8945         (set_style_name): New function.
8946         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
8947         Update all callers according to the changes in cli/cli-style.h.
8948         * utils.h (fputs_highlighted): New function.
8949         * utils.c (fputs_highlighted): Likewise.
8950
8951 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8952
8953         * NEWS: Mention new pipe command and new convenience variables.
8954
8955 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8956
8957         * cli/cli-cmds.c (pipe_command): New function.
8958         (_initialize_cli_cmds): Call add_com for pipe_command.
8959         Define | as an alias for pipe.
8960         (exit_status_set_internal_vars): New function.
8961         (shell_escape): Call exit_status_set_internal_vars.
8962         cli/cli-decode.c (find_command_name_length): Recognize | as
8963         a single character command.
8964
8965 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8966
8967         * gdbcmd.h (execute_command_to_ui_file): New declaration.
8968         top.c (execute_command_to_ui_file): New function, mostly a copy
8969         of execute_command_to_string.
8970         (execute_command_to_string): Implement by calling
8971         execute_command_to_ui_file.
8972
8973 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8974
8975         * top.h (saved_command_line): Remove declaration.
8976         * top.c (previous_saved_command_line, previous_repeat_arguments):
8977         New variables.
8978         (saved_command_line): Make static, define together with other
8979         'repeat variables'.
8980         (dont_repeat): Clear repeat_arguments.
8981         (repeat_previous, get_saved_command_line, save_command_line):
8982         New functions.
8983         (gdb_init): Initialize saved_command_line
8984         and previous_saved_command_line.
8985         * main.c (captured_main_1): Remove saved_command_line initialization.
8986         * event-top.c (handle_line_of_input): Update to use
8987         the new 'repeat' related functions instead of direct access to
8988         saved_command_line.
8989         * command.h (repeat_previous, get_saved_command_line,
8990         save_command_line): New declarations.
8991         (dont_repeat): Add comment.
8992
8993 2019-05-30  Tom Tromey  <tromey@adacore.com>
8994
8995         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
8996         Fix comment.
8997         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
8998
8999 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
9000
9001         PR cli/24587
9002         * completer.c (complete): Initialize variable word.
9003
9004 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
9005
9006         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9007         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9008         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9009         'body' is NULL to the outter 'if', protecting the '!is_define'
9010         situation as well.
9011
9012 2019-05-29  Tom Tromey  <tromey@adacore.com>
9013
9014         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9015         (dwarf_unknown): New function.
9016         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9017         (dwarf_type_encoding_name): Use dwarf_unknown.
9018
9019 2019-05-29  Tom Tromey  <tromey@adacore.com>
9020
9021         PR c++/20020:
9022         * cp-valprint.c (cp_print_value_fields): Call
9023         cp_print_static_field inside "try".
9024
9025 2019-05-29  Tom Tromey  <tromey@adacore.com>
9026
9027         * inflow.c (struct terminal_info): Add default operator=.
9028         * configure: Rebuild.
9029         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9030         -Wdeprecated-copy-dtor, -Wredundant-move.
9031
9032 2019-05-29  Tom Tromey  <tromey@adacore.com>
9033
9034         * NEWS: Add entry.
9035         * infcmd.c (print_return_value_1): Handle finish_print
9036         option.
9037         (show_print_finish): New function.
9038         (_initialize_infcmd): Add "set/show print finish" commands.
9039         * valprint.c (user_print_options): Initialize new member.
9040         * valprint.h (struct value_print_options) <finish_print>: New
9041         member.
9042
9043 2019-05-28  Tom Tromey  <tromey@adacore.com>
9044
9045         * ada-lang.c (ada_remove_Xbn_suffix)
9046         (find_old_style_renaming_symbol)
9047         (parse_old_style_renaming): Remove.
9048         (ada_find_renaming_symbol): Don't call
9049         find_old_style_renaming_symbol.
9050         (ada_is_renaming_symbol): Rename from
9051         ada_find_renaming_symbol.  Remove "block" parameter.  Return
9052         bool.  Now static.
9053         (ada_read_var_value): Update and simplify.
9054         * ada-exp.y (write_var_or_type): Remove old code.
9055
9056 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
9057
9058         PR gdb/25010
9059         * event-top.c: Remove include comment.
9060         * inflow.c (class scoped_ignore_sigttou): Move from here...
9061         * inflow.h (class scoped_ignore_sigttou): ...to here.
9062         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9063         * top.c:  Remove include comment.
9064
9065 2019-05-27  Tom Tromey  <tom@tromey.com>
9066
9067         * NEWS: Fix typo.
9068
9069 2019-05-22  Tom Tromey  <tromey@adacore.com>
9070
9071         * target.c (target_follow_exec): Constify parameter.
9072         * target-delegates.c: Rebuild.
9073         * remote.c (remote_target::follow_exec): Constify parameter.
9074         * infrun.c (follow_exec): Constify parameter.
9075         * target.h (struct target_ops) <follow_exec>: Constify parameter.
9076         (target_follow_exec): Likewise.
9077
9078 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9079
9080         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9081         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9082
9083 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
9084
9085         * NEWS: Add debugredirect and testsuite sections.
9086
9087 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
9088
9089         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9090         target descriptions using exclusively floating point register name
9091         aliases.
9092
9093 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
9094
9095         PR gdb/18644:
9096         * f-lang.c (build_fortran_types): Handle the case where
9097         gdbarch_floatformat_for_type returns a nullptr.
9098
9099 2019-05-21  Tom de Vries  <tdevries@suse.de>
9100
9101         PR cli/24587
9102         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9103
9104 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9105
9106         PR gdb/18644:
9107         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9108         16-byte floats.
9109         * i386-tdep.c (i386_floatformat_for_type): Use
9110         floatformats_ia64_quad for the 16-byte floating point component
9111         within a fortran 32-byte complex number.
9112
9113 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9114
9115         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9116         delete default constructor.
9117         (find_partial_die): Update to return const struct.
9118         (partial_die_parent_scope): Move variable declaration into scope
9119         of its use and change its type to auto.
9120         (guess_partial_die_structure_name): Likewise.
9121         (partial_die_info::fixup): Likewise.
9122
9123 2019-05-17  Tom Tromey  <tromey@adacore.com>
9124
9125         * source.c (find_and_open_source): Remove cast.
9126
9127 2019-05-17  Tom Tromey  <tromey@adacore.com>
9128
9129         * annotate.c (annotate_source): Make "filename" const.
9130         * annotate.h (annotate_source): Use const.
9131
9132 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9133
9134         * disasm.c (set_disassembler_options): Send errors to stderr.
9135
9136 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9137
9138         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9139         (cli_interp_base::set_logging): Check debug_redirect.
9140         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9141         * cli/cli-logging.c (debug_redirect): Add static variable.
9142         (pop_output_files): Add default param.
9143         (handle_redirections): Print debug setting.
9144         (show_logging_command): Likewise.
9145         (_initialize_cli_logging): Add debugredirect command.
9146         * interps.c (current_interp_set_logging): Add debug_redirect
9147         parameter.
9148         * interps.h (set_logging): Add debug_redirect parameter.
9149         (current_interp_set_logging): Likewise.
9150         * mi/mi-common.h: Likewise.
9151         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9152
9153 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
9154             Tom Tromey  <tromey@adacore.com>
9155
9156         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9157         directly.
9158         * cli/cli-interp.h (make_logging_output): Remove declaration.
9159         * cli/cli-logging.c (make_logging_output): Remove function.
9160         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9161         directly.
9162         * ui-file.c (tee_file::tee_file): Remove bools.
9163         (tee_file::~tee_file): Remove deletes.
9164         * ui-file.h (tee_file): Remove bools.
9165
9166 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
9167
9168         * mi/mi-cmds.h (mi_cmd_complete): New function.
9169         * mi/mi-main.c (mi_cmd_complete): Likewise.
9170         * mi/mi-cmds.c: Define new MI command -complete.
9171         * NEWS: Mention new -complete command.
9172
9173 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
9174
9175         * completer.h (complete): New function.
9176         * completer.c (complete): Likewise.
9177         * cli/cli-cmds.c: (complete_command): Update to use new complete()
9178         function defined in completer.h.
9179
9180 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
9181
9182         * MAINTAINERS (Write After Approval): Add myself.
9183
9184 2019-05-17  Tom de Vries  <tdevries@suse.de>
9185
9186         PR gdb/24094
9187         * dwarf2read.c (struct cu_partial_die_info): New struct.
9188         (find_partial_die): Return cu_partial_die_info.
9189         (partial_die_parent_scope, guess_partial_die_structure_name)
9190         (partial_die_info::fixup): Handle new return type of find_partial_die.
9191
9192 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9193
9194         PR breakpoints/24541
9195         * stap-probe.c (stap_parse_register_operand): Make "regname" an
9196         "std::string", simplifying the algorithm.
9197
9198 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9199
9200         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9201         (stap_static_probe_ops::get_probes): Likewise.
9202
9203 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9204
9205         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9206         '-')" and "else if".
9207         (stap_parse_single_operand): Join checks for
9208         "gdbarch_stap_parse_special_token_p" and
9209         "gdbarch_stap_parse_special_token" in the same "if" statement.
9210         Invert check when verifying for operation on register
9211         displacement.
9212
9213 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9214
9215         * stap-probe.c (stap_get_opcode): Update comment.
9216         (stap_get_expected_argument_type): Likewise.
9217         (handle_stap_probe): Likewise.
9218
9219 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
9220
9221         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9222         return type to 'bool'.  Adjust comment.  Use 'bool' when
9223         appropriate.
9224         (i386_stap_parse_special_token_three_arg_disp): Likewise.
9225         * stap-probe.c (stap_parse_argument_1): Likewise.
9226         (stap_is_operator): Likewise.
9227         (stap_is_generic_prefix): Likewise.
9228         (stap_is_register_prefix): Likewise.
9229         (stap_is_register_indirection_prefix): Likewise.
9230         (stap_is_integer_prefix): Likewise.
9231         (stap_generic_check_suffix): Likewise.
9232         (stap_check_integer_suffix): Likewise.
9233         (stap_check_register_suffix): Likewise.
9234         (stap_check_register_indirection_suffix): Likewise.
9235         (stap_parse_register_operand): Likewise.
9236         (stap_parse_single_operand): Likewise.
9237         (stap_parse_argument_1): Likewise.
9238         (stap_probe::get_argument_count): Likewise.
9239         (stap_is_operator): Likewise.
9240
9241 2019-05-16  Tom Tromey  <tromey@adacore.com>
9242
9243         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9244         keyword to foreach.
9245
9246 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
9247
9248         * linux-thread-db.c (try_thread_db_load_1): Change return type
9249         to bool.
9250         (try_thread_db_load): Likewise.
9251         (try_thread_db_load_from_pdir_1): Likewise.
9252         (try_thread_db_load_from_pdir): Likewise.
9253         (try_thread_db_load_from_sdir): Likewise.
9254         (try_thread_db_load_from_dir): Likewise.
9255         (thread_db_load_search): Likewise.
9256         (has_libpthread): Likewise.
9257         (thread_db_load): Likewise.
9258
9259 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
9260
9261         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9262         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9263         NULL, and complain/return if that's the case.
9264
9265 2019-05-15  John Darrington <john@darrington.wattle.id.au>
9266
9267         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9268         (advance, posn, abstract_read_memory): New functions.
9269         [struct mem_read_abstraction]: New struct.
9270         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9271
9272 2019-05-14  Tom Tromey  <tromey@adacore.com>
9273
9274         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9275         value is not lval_memory.
9276
9277 2019-05-14  Tom Tromey  <tromey@adacore.com>
9278
9279         * solib.c (info_sharedlibrary_command): Style the file name.
9280
9281 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
9282
9283         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9284         (aarch64_vnv_type): Likewise.
9285         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9286         * common/tdesc.c: Likewise.
9287         * common/tdesc.h (enum tdesc_type_kind): Likewise.
9288         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9289         * features/aarch64-fpu.xml: Add ieee half view.
9290         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9291         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9292         * gdbtypes.h (struct builtin_type): Likewise.
9293         (struct objfile_type): Likewise.
9294
9295 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
9296
9297         * language.c (language_sniff_from_mangled_name): Fix "langauge"
9298         typo.
9299         * location.h (string_to_event_location): Likewise.
9300
9301 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
9302
9303         GDB 8.3 released.
9304
9305 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9306
9307         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9308         New variable declaration.
9309         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9310         New variable.
9311         (print_one_breakpoint): Use ui_out::test_flags and new global
9312         variable to compute use_fixed_output.
9313         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9314         Remove.
9315         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9316         (mi_multi_location_breakpoint_output_fixed): Remove.
9317         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9318         new variable.
9319         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9320         fix_multi_location_breakpoint_output flag if version >= 3.
9321         * ui-out.h (enum ui_out_flag)
9322         <fix_multi_location_breakpoint_output>: New enumerator.
9323
9324 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
9325
9326         * contrib/cc-with-tweaks.sh: Validate dwz's work.
9327
9328 2019-05-10  Tom Tromey  <tromey@adacore.com>
9329
9330         * ada-lang.c (catch_ada_completer): New function.
9331         (_initialize_ada_language): Use it.
9332
9333 2019-05-10  Tom Tromey  <tromey@adacore.com>
9334
9335         * thread.c (print_thread_info): Make "requested_threads" const.
9336         * gdbthread.h (print_thread_info): Make "requested_threads"
9337         const.
9338         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9339         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9340
9341 2019-05-08  Tom Tromey  <tom@tromey.com>
9342
9343         * gdbtypes.c (objfile_type_data): Change type.
9344         (objfile_type, _initialize_gdbtypes): Update.
9345
9346 2019-05-08  Tom Tromey  <tom@tromey.com>
9347
9348         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9349         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9350         (_initialize_dwarf2_frame): Update.
9351
9352 2019-05-08  Tom Tromey  <tom@tromey.com>
9353
9354         * objc-lang.c (objc_objfile_data): Change type.
9355         (find_methods): Update.
9356         (_initialize_objc_lang): Remove.
9357
9358 2019-05-08  Tom Tromey  <tom@tromey.com>
9359
9360         * stabsread.c (rs6000_builtin_type_data): Change type.
9361         (rs6000_builtin_type, _initialize_stabsread): Update.
9362
9363 2019-05-08  Tom Tromey  <tom@tromey.com>
9364
9365         * mips-tdep.c (mips_pdr_data): Remove.
9366         (_initialize_mips_tdep): Update.
9367
9368 2019-05-08  Tom Tromey  <tom@tromey.com>
9369
9370         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9371         (hppa_init_objfile_priv_data, read_unwind_info)
9372         (find_unwind_entry, _initialize_hppa_tdep): Update.
9373
9374 2019-05-08  Tom Tromey  <tom@tromey.com>
9375
9376         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9377         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
9378         on obstack.
9379         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9380
9381 2019-05-08  Tom Tromey  <tom@tromey.com>
9382
9383         * mdebugread.c (basic_type_data): Change type.
9384         (basic_type, _initialize_mdebugread): Update.
9385
9386 2019-05-08  Tom Tromey  <tom@tromey.com>
9387
9388         * common/gdb_unique_ptr.h (struct noop_deleter): New.
9389
9390 2019-05-08  Tom Tromey  <tom@tromey.com>
9391
9392         * nto-tdep.c (nto_inferior_data_reg): Change type.
9393         (nto_inferior_data): Update.
9394         (nto_inferior_data_cleanup, nto_new_inferior_data)
9395         (_initialize_nto_tdep): Remove.
9396         * nto-tdep.h (struct nto_inferior_data): Add initializers.
9397
9398 2019-05-08  Tom Tromey  <tom@tromey.com>
9399
9400         * ada-lang.c (struct ada_inferior_data): Add initializers.
9401         (ada_inferior_data): Change type.
9402         (ada_inferior_data_cleanup): Remove.
9403         (get_ada_inferior_data, ada_inferior_exit)
9404         (struct ada_pspace_data): Add initializers, destructor.
9405         (ada_pspace_data_handle): Change type.
9406         (get_ada_pspace_data): Update.
9407         (ada_pspace_data_cleanup): Remove.
9408
9409 2019-05-08  Tom Tromey  <tom@tromey.com>
9410
9411         * coffread.c (struct coff_symfile_info): Add initializers.
9412         (coff_objfile_data_key): Move lower.  Change type.
9413         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9414         Update.
9415         (coff_free_info): Remove.
9416
9417 2019-05-08  Tom Tromey  <tom@tromey.com>
9418
9419         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9420         (fbsd_pspace_data_handle): Move lower.  Change type.
9421         (get_fbsd_pspace_data): Update.
9422         (fbsd_pspace_data_cleanup): Remove.
9423         (_initialize_fbsd_tdep): Update.
9424
9425 2019-05-08  Tom Tromey  <tom@tromey.com>
9426
9427         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9428         (get_ada_tasks_pspace_data): Update.
9429         (ada_tasks_pspace_data_cleanup): Remove.
9430         (_initialize_tasks): Update.
9431         (ada_tasks_inferior_data_handle): Change type.
9432         (get_ada_tasks_inferior_data): Update.
9433         (ada_tasks_inferior_data_cleanup): Remove.
9434         (struct ada_tasks_pspace_data): Add initializers.
9435
9436 2019-05-08  Tom Tromey  <tom@tromey.com>
9437
9438         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9439         * symfile-debug.c (debug_sym_get_probes): Change type.
9440         * stap-probe.c (handle_stap_probe):
9441         (stap_static_probe_ops::get_probes): Change type.
9442         * probe.h (class static_probe_ops) <get_probes>: Change type.
9443         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9444         (parse_probes_in_pspace): Update.
9445         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9446         Update.
9447         (any_static_probe_ops::get_probes): Change type.
9448         * elfread.c (elfread_data): New typedef.
9449         (probe_key): Change type.
9450         (elf_get_probes): Likewise.  Update.
9451         (probe_key_free): Remove.
9452         (_initialize_elfread): Update.
9453         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9454         Change type.
9455         (dtrace_process_dof_probe, dtrace_process_dof)
9456         (dtrace_static_probe_ops::get_probe): Change type.
9457
9458 2019-05-08  Tom Tromey  <tom@tromey.com>
9459
9460         * xcoffread.c (struct xcoff_symfile_info): Rename from
9461         coff_symfile_info.  Add initializers.
9462         (xcoff_objfile_data_key): Move lower.  Change type.
9463         (XCOFF_DATA): Rewrite.
9464         (xcoff_free_info): Remove.
9465         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9466         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9467         (xcoff_initial_scan): Update.
9468
9469 2019-05-08  Tom Tromey  <tom@tromey.com>
9470
9471         * solib-svr4.c (struct svr4_info): Add initializers and
9472         destructor.
9473         <probes_table>: Now an htab_up.
9474         (solib_svr4_pspace_data): Change type.
9475         (free_probes_table): Simplify.
9476         (~svr4_info): Rename from svr4_pspace_data_cleanup.
9477         (get_svr4_info, probes_table_htab_remove_objfile_probes)
9478         (probes_table_remove_objfile_probes, register_solib_event_probe)
9479         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9480         (_initialize_svr4_solib): Update.
9481
9482 2019-05-08  Tom Tromey  <tom@tromey.com>
9483
9484         * remote.c (remote_pspace_data): Change type.
9485         (remote_pspace_data_cleanup): Remove.
9486         (get_remote_exec_file, set_pspace_remote_exec_file)
9487         (_initialize_remote): Update.
9488
9489 2019-05-08  Tom Tromey  <tom@tromey.com>
9490
9491         * breakpoint.c (breakpoint_objfile_key): Change type.
9492         (get_breakpoint_objfile_data): Update.
9493         (free_breakpoint_objfile_data): Remove.
9494         (_initialize_breakpoint): Update.
9495
9496 2019-05-08  Tom Tromey  <tom@tromey.com>
9497
9498         * linux-tdep.c (struct linux_info): Add initializers.
9499         (linux_inferior_data): Move.  Change type.
9500         (invalidate_linux_cache_inf): Update.
9501         (linux_inferior_data_cleanup): Remove.
9502         (get_linux_inferior_data, _initialize_linux_tdep): Update.
9503
9504 2019-05-08  Tom Tromey  <tom@tromey.com>
9505
9506         * auxv.c (auxv_inferior_data): Move.  Change type.
9507         (auxv_inferior_data_cleanup): Remove.
9508         (invalidate_auxv_cache_inf): Rewrite.
9509         (get_auxv_inferior_data, _initialize_auxv): Update.
9510
9511 2019-05-08  Tom Tromey  <tom@tromey.com>
9512
9513         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9514         (symfile_debug_objfile_data_key): Change type.
9515         (symfile_debug_installed, debug_qf_has_symbols)
9516         (debug_qf_find_last_source_symtab)
9517         (debug_qf_forget_cached_source_info)
9518         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9519         (debug_qf_print_stats, debug_qf_dump)
9520         (debug_qf_expand_symtabs_for_function)
9521         (debug_qf_expand_all_symtabs)
9522         (debug_qf_expand_symtabs_with_fullname)
9523         (debug_qf_map_matching_symbols)
9524         (debug_qf_expand_symtabs_matching)
9525         (debug_qf_find_pc_sect_compunit_symtab)
9526         (debug_qf_map_symbol_filenames)
9527         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9528         (debug_sym_new_init, debug_sym_init, debug_sym_read)
9529         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9530         (debug_sym_read_linetable, debug_sym_relocate): Update.
9531         (symfile_debug_free_objfile): Remove.
9532         (install_symfile_debug_logging, _initialize_symfile_debug):
9533         Update.
9534
9535 2019-05-08  Tom Tromey  <tom@tromey.com>
9536
9537         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9538         allocate_on_obstack.
9539         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9540         (get_dwarf2_per_objfile): Update.
9541         (set_dwarf2_per_objfile): Remove.
9542         (dwarf2_has_info, dwarf2_get_section_info): Update.
9543         (dwarf2_free_objfile): Remove.
9544         (_initialize_dwarf2_read): Update.
9545
9546 2019-05-08  Tom Tromey  <tom@tromey.com>
9547
9548         * auto-load.c (struct auto_load_pspace_info): Add destructor and
9549         initializers.
9550         <unsupported_script_warning_printed,
9551         script_not_found_warning_printed>: Now bool.
9552         (auto_load_pspace_data): Change type.
9553         (~auto_load_pspace_info): Rename from
9554         auto_load_pspace_data_cleanup.
9555         (get_auto_load_pspace_data, init_loaded_scripts_info)
9556         (clear_section_scripts, maybe_print_unsupported_script_warning)
9557         (maybe_print_script_not_found_warning, _initialize_auto_load):
9558         Update.
9559
9560 2019-05-08  Tom Tromey  <tom@tromey.com>
9561
9562         * objfiles.c (objfile_pspace_info): Add destructor and
9563         initializers.
9564         (objfiles_pspace_data): Change type.
9565         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9566         (get_objfile_pspace_data): Update.
9567         (objfiles_bfd_data): Change type.
9568         (get_objfile_bfd_data): Update.
9569         (objfile_bfd_data_free, _initialize_objfiles): Remove.
9570
9571 2019-05-08  Tom Tromey  <tom@tromey.com>
9572
9573         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9574         Change type.
9575         (get_catch_syscall_inferior_data): Update.
9576         (catch_syscall_inferior_data_cleanup): Remove.
9577         (_initialize_break_catch_syscall): Update.
9578
9579 2019-05-08  Tom Tromey  <tom@tromey.com>
9580
9581         * inflow.c (struct terminal_info): Add destructor and
9582         initializers.
9583         (inflow_inferior_data): Change type.
9584         (~terminal_info): Rename from inflow_inferior_data_cleanup.
9585         (get_inflow_inferior_data, inflow_inferior_exit)
9586         (swap_terminal_info, _initialize_inflow): Update.
9587
9588 2019-05-08  Tom Tromey  <tom@tromey.com>
9589
9590         * target-dcache.c (target_dcache_cleanup): Remove.
9591         (target_dcache_aspace_key): Change type.
9592         (target_dcache_init_p, target_dcache_invalidate)
9593         (target_dcache_get, target_dcache_get_or_init)
9594         (_initialize_target_dcache): Update.
9595         * dcache.h (struct dcache_deleter): New.
9596
9597 2019-05-08  Tom Tromey  <tom@tromey.com>
9598
9599         * symtab.c (struct symbol_cache): Add destructor and
9600         initializers.
9601         (symbol_cache_key): Move.  Change type.
9602         (make_symbol_cache, free_symbol_cache): Remove.
9603         (get_symbol_cache): Update.
9604         (symbol_cache_cleanup): Remove.
9605         (ALL_PSPACES, symbol_cache_flush)
9606         (maintenance_print_symbol_cache)
9607         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9608         Update.
9609
9610 2019-05-08  Tom Tromey  <tom@tromey.com>
9611
9612         * symtab.c (struct main_info): Add destructor and initializers.
9613         (main_progspace_key): Move.  Change type.
9614         (get_main_info): Update.
9615         (main_info_cleanup): Remove.
9616         (_initialize_symtab): Update.
9617
9618 2019-05-08  Tom Tromey  <tom@tromey.com>
9619
9620         * registry.h (DECLARE_REGISTRY): Define the _key class.
9621
9622 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9623
9624         * NEWS: Merge two 'New commands' sections.
9625
9626 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
9627
9628         * ada-valprint.c (ada_val_print_gnat_array): Remove language
9629         parameter and use Ada language definition instead.
9630         (ada_val_print_ptr): Remove unused language parameter.
9631         (ada_val_print_num): Remove language parameter and use Ada language
9632         definition instead.
9633         (ada_val_print_enum, ada_val_print_flt): Remove unused language
9634         parameter.
9635         (ada_val_print_struct_union, ada_val_print_ref): Remove language
9636         parameter and use Ada language definition instead.
9637         (ada_val_print_1): Update all ada_val_print_xxx calls.
9638         Remove language parameter.
9639         (ada_val_print): Update ada_val_print_1 call.
9640
9641 2019-05-08  Tom Tromey  <tromey@adacore.com>
9642
9643         * remote.c (remote_hw_watchpoint_limit)
9644         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9645         Now static.
9646
9647 2019-05-08  Tom Tromey  <tromey@adacore.com>
9648
9649         * maint.c (_initialize_maint_cmds): Move initialization code to
9650         remote.c.
9651         (watchdog, show_watchdog): Move to remote.c.
9652         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
9653         "watchdog" static.
9654         (_initialize_remote): Move initialization code from maint.c.
9655         * defs.h (watchdog): Don't declare.
9656
9657 2019-05-08  Tom Tromey  <tromey@adacore.com>
9658
9659         * tui/tui-interp.c: Include main.h.
9660         * interps.c: Include main.h.
9661         * main.h (interpreter_p): Declare.
9662         * defs.h (interpreter_p): Don't declare.
9663
9664 2019-05-08  Tom Tromey  <tromey@adacore.com>
9665
9666         * dwarf2loc.c: Include dwarf2read.h.
9667         * defs.h (read_unsigned_leb128): Don't declare.
9668         * dwarf2read.h (read_unsigned_leb128): Declare.
9669
9670 2019-05-08  Tom Tromey  <tromey@adacore.com>
9671
9672         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9673         method.
9674
9675 2019-05-08  Tom Tromey  <tromey@adacore.com>
9676
9677         * utils.c (fputs_maybe_filtered): Reset style after paging, even
9678         when no wrap column is set.
9679
9680 2019-05-08  Tom Tromey  <tromey@adacore.com>
9681
9682         * c-lang.c (c_get_string): Handle non-C-style arrays.
9683
9684 2019-05-08  Tom Tromey  <tromey@adacore.com>
9685
9686         * typeprint.c (print_offset_data::update): Print the bit offset,
9687         not the number of bits remaining.
9688
9689 2019-05-08  Tom Tromey  <tromey@adacore.com>
9690
9691         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
9692         padding at end of comment.
9693
9694 2019-05-08  Tom Tromey  <tromey@adacore.com>
9695
9696         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
9697         Compare main types.
9698
9699 2019-05-06  Tom Tromey  <tom@tromey.com>
9700
9701         * common/scoped_mmap.c: Include common-defs.h.
9702         * common/scoped_mmap.h: Don't include config.h.
9703
9704 2019-05-04  Tom Tromey  <tom@tromey.com>
9705
9706         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
9707         (struct aarch64_call_info): Add initializers.
9708         <si>: Now a std::vector.
9709         (pass_on_stack, aarch64_push_dummy_call): Update.
9710
9711 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
9712             Tom Tromey  <tom@tromey.com>
9713
9714         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
9715         (ppc_threads): Now a std::vector.  Now static.
9716         (hwdebug_find_thread_points_by_tid)
9717         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
9718         Update.
9719
9720 2019-05-04  Tom Tromey  <tom@tromey.com>
9721
9722         * arc-tdep.c (arc_tdesc_init): Return bool.
9723
9724 2019-05-04  Tom Tromey  <tom@tromey.com>
9725
9726         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
9727         Use gdb_assert_not_reached.
9728
9729 2019-05-04  Tom Tromey  <tom@tromey.com>
9730
9731         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
9732         "false".
9733
9734 2019-05-04  Tom Tromey  <tom@tromey.com>
9735
9736         * arc-tdep.c (arc_tdesc_init): Use bool.
9737
9738 2019-05-04  Tom Tromey  <tom@tromey.com>
9739
9740         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
9741
9742 2019-05-04  Tom Tromey  <tom@tromey.com>
9743
9744         * cli/cli-cmds.c (valid_command_p): Return bool.
9745
9746 2019-05-04  Tom Tromey  <tom@tromey.com>
9747
9748         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
9749         * command.h (valid_user_defined_cmd_name_p): Channge return type.
9750
9751 2019-05-04  Raul Tambre  <raul@tambre.ee>
9752
9753         * python/lib/gdb/prompt.py (_ExtendedPrompt)
9754         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
9755         operator for comparison.
9756
9757 2019-05-04  Tom Tromey  <tom@tromey.com>
9758
9759         * psymtab.c (psymbol_name_matches, match_partial_symbol)
9760         (lookup_partial_symbol, print_partial_symbols)
9761         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
9762         (psymbol_compare): Update.
9763         (add_psymbol_to_bcache): Clear the entire psymbol.
9764         (maintenance_check_psymtabs): Update.
9765         * psympriv.h (struct partial_symbol): Don't derive from
9766         general_symbol_info.
9767         <obj_section, unrelocated_address, address,
9768         set_unrelocated_address>: Update.
9769         <ginfo>: New member.
9770         * dwarf-index-write.c (write_psymbols, debug_names::insert)
9771         (debug_names::write_psymbols): Update.
9772
9773 2019-05-04  Tom de Vries  <tdevries@suse.de>
9774
9775         * contrib/cc-with-tweaks.sh: Support -n arg.
9776
9777 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9778
9779         * corelow.c (core_target::detach): Ensure frame cache and
9780         register caches are cleared.
9781         inferior.c (exit_inferior_1): Likewise.
9782
9783 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
9784             Tom Tromey  <tom@tromey.com>
9785
9786         * dictionary.c (collate_pending_symbols_by_language): Remove
9787         "struct" from foreach.
9788         * symtab.c (lookup_global_symbol_from_objfile)
9789         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
9790         foreach.
9791         * ser-tcp.c (net_open): Remove "struct" from foreach.
9792         * objfiles.c (objfile_relocate, objfile_rebase)
9793         (objfile_has_symbols): Remove "struct" from foreach.
9794         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
9795         from foreach.
9796         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
9797         foreach.
9798         * darwin-nat.c (thread_info_from_private_thread_info): Remove
9799         "struct" from foreach.
9800         * ada-lang.c (create_excep_cond_exprs)
9801         (ada_exception_catchpoint_cond_string): Remove "struct" from
9802         foreach.
9803
9804 2019-05-03  Tom Tromey  <tromey@adacore.com>
9805
9806         * ada-exp.y (convert_char_literal): Check suffix of each
9807         enumerator.
9808
9809 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
9810
9811         PR ada/21406:
9812         * ada-exp.y (yywrap): Don't define.
9813         * ada-lex.l (%option): Add noyywrap
9814         (yywrap): Remove.
9815
9816 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
9817
9818         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
9819         _WIN32_WINNT to the XP level, unless already defined to a higher
9820         level.
9821
9822         * unittests/parse-connection-spec-selftests.c:
9823         * ser-tcp.c:
9824         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
9825         override.
9826
9827         * symfile.c (find_separate_debug_file): Remove colon from the
9828         drive spec of DOS/Windows file names of the target, so that the
9829         file name produced from DEBUGDIR and the target's directory will
9830         be valid on DOS/Windows systems.
9831
9832 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
9833
9834         * rust-lang.c (val_print_struct): Handle printing structures
9835         containing strings.
9836
9837 2019-05-02  Tom Tromey  <tromey@adacore.com>
9838
9839         * valarith.c (_initialize_valarith): Remove.
9840
9841 2019-05-01  Tom Tromey  <tromey@adacore.com>
9842
9843         * ada-lang.c (ada_value_primitive_field): Treat more fields as
9844         bitfields.
9845
9846 2019-05-01  Tom Tromey  <tromey@adacore.com>
9847
9848         * ada-lang.c (ada_value_assign): Correctly compute starting offset
9849         for big-endian copies.
9850
9851 2019-04-30  Ali Tamur  <tamur@google.com>
9852         * gdb/dwarf2read.c (read_3_bytes): New declaration.
9853         (read_attribute_value): Added DW_FORM_strx1-4 cases.
9854         (read_3_bytes): New function.
9855
9856 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9857
9858         * windows-nat.c (main_thread_id): Delete.
9859         (handle_output_debug_string): Replace main_thread_id by
9860         current_event.dwThreadId.
9861         (fake_create_process): Likewise.
9862         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
9863         Do not set main_thread_id.
9864         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
9865         current_event.dwThreadId.
9866         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
9867
9868 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
9869
9870         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
9871         Use current_event.dwThreadId instead of main_thread_id.
9872
9873 2019-04-30  Tom Tromey  <tromey@adacore.com>
9874
9875         * ada-lang.c (ada_lookup_simple_minsyms): New function.
9876         (create_excep_cond_exprs): Iterate over program spaces.
9877         (ada_exception_catchpoint_cond_string): Examine all minimal
9878         symbols for exception types.
9879
9880 2019-04-30  Tom Tromey  <tromey@adacore.com>
9881
9882         PR c++/24470:
9883         * dwarf2read.c (process_structure_scope): Handle case where type
9884         has template parameters but no symbol was created.
9885
9886 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9887             Chris January  <chris.january@arm.com>
9888
9889         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
9890         qualifier.
9891         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
9892
9893 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9894
9895         * f-typeprint.c (f_print_type): Update rules for printing
9896         whitespace.
9897         (f_type_print_varspec_suffix): Likewise.
9898
9899 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9900             Chris January  <chris.january@arm.com>
9901
9902         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
9903         function arguments.
9904
9905 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9906
9907         * f-lang.c (build_fortran_types): Change name of void type to
9908         lower case.
9909         * f-typeprint.c (f_type_print_base): Print the name of the void
9910         type, rather than a fixed string.
9911         * f-valprint.c (f_decorations): Use lower case void string.
9912
9913 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9914             Chris January  <chris.january@arm.com>
9915
9916         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
9917         types for Fortran.
9918
9919 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9920             Chris January  <chris.january@arm.com>
9921             David Lecomber  <david.lecomber@arm.com>
9922
9923         * f-exp.y (BINOP_INTRINSIC): New token.
9924         (exp): New parser rule handling BINOP_INTRINSIC.
9925         (f77_keywords): Add new builtin procedures.
9926         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
9927         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9928         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
9929         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9930         (print_unop_subexp_f): New function.
9931         (print_binop_subexp_f): New function.
9932         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9933         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
9934         (dump_subexp_body_f): Likewise.
9935         (operator_check_f): Likewise.
9936         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
9937         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
9938
9939 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9940
9941         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
9942         UNOP_KIND.
9943         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
9944         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
9945         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
9946         (operator_length_f): New fuction.
9947         (print_subexp_f): New function.
9948         (op_name_f): New function.
9949         (dump_subexp_body_f): New function.
9950         (operator_check_f): New function.
9951         (exp_descriptor_f): Replace standard expression handling functions
9952         with new functions.
9953         * gdb/fortran-operator.def: New file.
9954         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
9955         * gdb/std-operator.def: Remove UNOP_KIND.
9956
9957 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
9958
9959         * std-operator.def: Remove unbalanced, stray double quote
9960         character.
9961
9962 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9963             Chris January  <chris.january@arm.com>
9964             Daniel Everett  <daniel.everett@arm.com>
9965             Nick Forrington  <nick.forrington@arm.com>
9966             Richard Bunt  <richard.bunt@arm.com>
9967
9968         * cp-valprint.c (cp_print_value_fields): Allow an additional level
9969         of depth when printing anonymous structs or unions.
9970         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
9971         Don't print either the top-level value, or the children if the
9972         max-depth is exceeded.
9973         (ppscm_print_children): When printing the key of a map, allow one
9974         extra level of depth.
9975         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
9976         print either the top-level value, or the children if the max-depth
9977         is exceeded.
9978         (print_children): When printing the key of a map, allow one extra
9979         level of depth.
9980         * python/py-value.c (valpy_format_string): Add max_depth keyword.
9981         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
9982         (user_print_options): Initialise max_depth field.
9983         (val_print_scalar_or_string_type_p): New function.
9984         (val_print): Check to see if the max depth has been reached.
9985         (val_print_check_max_depth): Define new function.
9986         (show_print_max_depth): New function.
9987         (_initialize_valprint): Add 'print max-depth' option.
9988         * valprint.h (struct value_print_options) <max_depth>: New field.
9989         (val_print_check_max_depth): Declare new function.
9990         * NEWS: Document new feature.
9991
9992 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
9993
9994         * ada-lang.c (ada_language_defn): Initialise new field.
9995         * c-lang.c (c_is_string_type_p): New function.
9996         (c_language_defn): Initialise new field.
9997         (cplus_language_defn): Initialise new field.
9998         (asm_language_defn): Initialise new field.
9999         (minimal_language_defn): Initialise new field.
10000         * c-lang.h (c_is_string_type_p): Declare new function.
10001         * d-lang.c (d_language_defn): Initialise new field.
10002         * f-lang.c (f_is_string_type_p): New function.
10003         (f_language_defn): Initialise new field.
10004         * go-lang.c (go_is_string_type_p): New function.
10005         (go_language_defn): Initialise new field.
10006         * language.c (default_is_string_type_p): New function.
10007         (unknown_language_defn): Initialise new field.
10008         (auto_language_defn): Initialise new field.
10009         * language.h (struct language_defn) <la_is_string_type_p>: New
10010         member variable.
10011         (default_is_string_type_p): Declare new function.
10012         * m2-lang.c (m2_language_defn): Initialise new field.
10013         * objc-lang.c (objc_language_defn): Initialise new field.
10014         * opencl-lang.c (opencl_language_defn): Initialise new field.
10015         * p-lang.c (pascal_is_string_type_p): New function.
10016         (pascal_language_defn): Initialise new field.
10017         * rust-lang.c (rust_is_string_type_p): New function.
10018         (rust_language_defn): Initialise new field.
10019
10020 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10021
10022         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10023         New field.
10024         * ada-lang.c (ada_language_defn): Initialise new field.
10025         * c-lang.c (c_language_defn): Likewise.
10026         (cplus_language_defn): Likewise.
10027         (asm_language_defn): Likewise.
10028         (minimal_language_defn): Likewise.
10029         * d-lang.c (d_language_defn): Likewise.
10030         * f-lang.c (f_language_defn): Likewise.
10031         * go-lang.c (go_language_defn): Likewise.
10032         * language.c (unknown_language_defn): Likewise.
10033         (auto_language_defn): Likewise.
10034         * m2-lang.c (m2_language_defn): Likewise.
10035         * objc-lang.c (objc_language_defn): Likewise.
10036         * opencl-lang.c (opencl_language_defn): Likewise.
10037         * p-lang.c (pascal_language_defn): Likewise.
10038         * rust-lang.c (rust_language_defn): Likewise.
10039
10040 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
10041
10042         * ada-lang.c (ada_is_character_type): Change return type to bool.
10043         (ada_is_string_type): Likewise.
10044         * ada-lang.h (ada_is_character_type): Update declaration
10045         (ada_is_string_type): Likewise.
10046
10047 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10048
10049         Support style in 'frame|thread apply'
10050
10051         * gdbcmd.h (execute_command_to_string): New term_out parameter.
10052         * record.c (record_start, record_stop): Update callers of
10053         execute_command_to_string with false.
10054         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10055         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10056         methods.
10057         (class string_file): New constructor with term_out parameter.
10058         Override methods term_out and can_emit_style_escape.  New member
10059         term_out.
10060         (class stdio_file): Override can_emit_style_escape.
10061         (class tee_file): Override term_out and can_emit_style_escape.
10062         * utils.h (can_emit_style_escape): Remove.
10063         * utils.c (can_emit_style_escape): Likewise.
10064         Update all callers of can_emit_style_escape (SOMESTREAM) to
10065         SOMESTREAM->can_emit_style_escape.
10066         * source-cache.c (source_cache::get_source_lines): Likewise.
10067         * stack.c (frame_apply_command_count): Call execute_command_to_string
10068         passing the term_out characteristic of the current gdb_stdout.
10069         * thread.c (thr_try_catch_cmd): Likewise.
10070         * top.c (execute_command_to_string): pass term_out parameter
10071         to construct the string_file for the command output.
10072         * ui-file.c (term_cli_styling): New function (most code moved
10073         from utils.c can_emit_style_escape).
10074         (string_file::string_file, string_file::can_emit_style_escape,
10075         stdio_file::can_emit_style_escape, tee_file::term_out,
10076         tee_file::can_emit_style_escape): New functions.
10077
10078 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10079
10080         * NEWS: Mention the new set|show may-call-functions.
10081         * infcall.c (may_call_functions_p): New variable.
10082         (show_may_call_functions_p): New function.
10083         (call_function_by_hand_dummy): Throws an error if not
10084         may-call-functions.
10085         (_initialize_infcall): Call add_setshow_boolean_cmd for
10086         may-call-functions.
10087
10088 2019-04-25  Keith Seitz  <keiths@redhat.com>
10089
10090         PR c++/24367
10091         * cp-support.c (inspect_type): Don't attempt substitutions
10092         of symbol with the same name.
10093
10094 2019-04-25  Tom Tromey  <tromey@adacore.com>
10095
10096         PR gdb/24475:
10097         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10098         static.
10099
10100 2019-04-25  Tom Tromey  <tromey@adacore.com>
10101
10102         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10103         rvalue reference.
10104         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10105         (gdb_xml_parser::parse): Use std::move.
10106         * python/python-internal.h (gdbpy_convert_exception): Take a const
10107         reference.
10108         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10109         std::move.
10110         * python/py-utils.c (gdbpy_convert_exception): Take a const
10111         reference.
10112         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10113         Use std::move.
10114         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10115         Use std::move.
10116         * mi/mi-main.c (mi_print_exception): Take a const reference.
10117         * main.c (handle_command_errors): Take a const reference.
10118         * linespec.c (parse_linespec): Use std::move.
10119         * infcall.c (run_inferior_call): Use std::move.
10120         (call_function_by_hand_dummy): Use std::move.
10121         * exec.c (try_open_exec_file): Use std::move.
10122         * exceptions.h (exception_print, exception_fprintf)
10123         (exception_print_same): Update.
10124         * exceptions.c (print_exception, exception_print)
10125         (exception_fprintf, exception_print_same): Change parameters to
10126         const reference.
10127         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10128         * common/new-op.c: Use std::move.
10129         * common/common-exceptions.h (struct gdb_exception): Add move
10130         constructor.
10131         (struct gdb_exception_error, struct gdb_exception_quit, struct
10132         gdb_quit_bad_alloc): Change constructor to move constructor.
10133         (throw_exception): Change parameter to rvalue reference.
10134         * common/common-exceptions.c (throw_exception): Take rvalue
10135         reference.
10136         * cli/cli-interp.c (safe_execute_command): Use std::move.
10137         * breakpoint.c (insert_bp_location, location_to_sals): Use
10138         std::move.
10139
10140 2019-04-25  Tom Tromey  <tromey@adacore.com>
10141
10142         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10143         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10144         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10145         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10146         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10147         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10148         guile/scm-value.c: Use unpack.
10149         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10150         gdbscm_gdb_exception.
10151         (gdbscm_throw_gdb_exception): Likewise.
10152         (struct gdbscm_gdb_exception): New.
10153         (unpack): New function.
10154         (gdbscm_wrap): Use unpack.
10155
10156 2019-04-25  Tom Tromey  <tromey@adacore.com>
10157
10158         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10159         (gdb_rl_callback_handler): Use std::move.
10160         * common/common-exceptions.h (struct gdb_exception): Add move
10161         assignment operator.
10162         (throw_exception_sjlj): Change "exception" to const reference.
10163         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10164         (throw_exception_sjlj): Change "exception" to const reference.
10165
10166 2019-04-25  Tom Tromey  <tromey@adacore.com>
10167
10168         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10169         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10170         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10171         Update.
10172         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10173         Update.
10174         * mi/mi-interp.c (mi_interp::exec): Update.
10175         * linespec.c (parse_linespec): Update.
10176         * infcall.c (run_inferior_call): Update.
10177         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10178         * guile/scm-symbol.c (gdbscm_lookup_symbol)
10179         (gdbscm_lookup_global_symbol): Update.
10180         * guile/scm-param.c (gdbscm_parameter_value): Update.
10181         * guile/scm-frame.c (gdbscm_frame_read_register)
10182         (gdbscm_frame_read_var): Update.
10183         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10184         * exec.c (try_open_exec_file): Update.
10185         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10186         (gdb_rl_callback_handler): Update.
10187         * common/common-exceptions.h (exception_none): Don't declare.
10188         * common/common-exceptions.c (exception_none): Don't define.
10189         (struct catcher) <exception>: Update.
10190         * cli/cli-interp.c (safe_execute_command): Update.
10191         * breakpoint.c (insert_bp_location, location_to_sals): Update.
10192
10193 2019-04-25  Ali Tamur  <tamur@google.com>
10194
10195         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10196         (read_attribute_value): Likewise.
10197         (dwarf2_read_addr_index): Update comment.
10198         (read_str_index): Add DW_FORM_strx.
10199         (dwarf2_string_attr): Likewise.
10200         (dwarf2_const_value_attr): Likewise.
10201         (dump_die_shallow): Likewise.
10202         (dwarf2_fetch_constant_bytes): Likewise.
10203         (skip_form_bytes): Likewise.
10204         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10205
10206 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
10207
10208         PR corefiles/11608
10209         PR corefiles/18187
10210         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10211         OFFSET.  Verify if current mapping contains an ELF header.
10212         (linux_find_memory_regions_full): Adjust call to
10213         dump_mapping_p.
10214
10215 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
10216             Kang Li <kanglictf@gmail.com>
10217
10218         PR gdb/21600
10219
10220         * dwarf2-frame.c (read_initial_length): Be consistent about using
10221         unsigned representation of length.
10222         (decode_frame_entry_1): Likewise.  Check for wraparound of
10223         end pointer as well as buffer overflow.
10224
10225 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
10226
10227         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10228         "vq".
10229
10230 2019-04-24  Tom Tromey  <tromey@adacore.com>
10231
10232         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10233
10234 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10235
10236         * s12z-tdep.c (s12z_unwind_pc): Delete.
10237         (s12z_unwind_sp): Delete.
10238         (s12z_gdbarch_init): Don't register deleted functions with
10239         gdbarch.
10240
10241 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10242
10243         * rl78-tdep.c (rl78_unwind_sp): Delete.
10244         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10245
10246 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10247
10248         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10249         (xstormy16_unwind_pc): Delete.
10250         (xstormy16_dummy_id): Delete.
10251         (xstormy16_gdbarch_init): Don't register deleted functions with
10252         gdbarch.
10253
10254 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10255
10256         * vax-tdep.c (vax_unwind_pc): Delete.
10257         (vax_gdbarch_init): Don't register deleted function with gdbarch.
10258
10259 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10260
10261         * v850-tdep.c (v850_unwind_sp): Delete.
10262         (v850_unwind_pc): Delete.
10263         (v850_dummy_id): Delete.
10264         (v850_gdbarch_init): Don't register deleted functions with
10265         gdbarch.
10266
10267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10268
10269         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10270         (tilegx_unwind_pc): Delete.
10271         (tilegx_unwind_dummy_id): Delete.
10272         (tilegx_gdbarch_init): Don't register deleted functions with
10273         gdbarch.
10274
10275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10276
10277         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10278         (tic6x_dummy_id): Delete.
10279         (tic6x_gdbarch_init): Don't register deleted functions with
10280         gdbarch.
10281
10282 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10283
10284         * sparc-tdep.c (sparc_unwind_pc): Delete.
10285         (sparc32_gdbarch_init): Don't register deleted function with
10286         gdbarch.
10287
10288 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10289
10290         * sh-tdep.c (sh_unwind_sp): Delete.
10291         (sh_unwind_pc): Delete.
10292         (sh_dummy_id): Delete.
10293         (sh_gdbarch_init): Don't register deleted functions with
10294         gdbarch.
10295
10296 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10297
10298         * score-tdep.c (score_unwind_sp): Delete.
10299         (score_unwind_pc): Delete.
10300         (score_dummy_id): Delete.
10301         (score_gdbarch_init): Don't register deleted functions with
10302         gdbarch.
10303
10304 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10305
10306         * rx-tdep.c (rx_unwind_pc): Delete.
10307         (rx_unwind_sp): Delete.
10308         (rx_dummy_id): Delete.
10309         (rx_gdbarch_init): Don't register deleted functions with
10310         gdbarch.  Update comment.
10311
10312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10313
10314         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10315         (rs6000_dummy_id): Delete.
10316         (rs6000_gdbarch_init): Don't register deleted functions with
10317         gdbarch.
10318
10319 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10320
10321         * or1k-tdep.c (or1k_dummy_id): Delete.
10322         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10323
10324 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10325
10326         * nios2-tdep.c (nios2_dummy_id): Delete.
10327         (nios2_unwind_sp): Delete.
10328         (nios2_gdbarch_init): Don't register deleted functions with
10329         gdbarch.
10330
10331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10332
10333         * nds32-tdep.c (nds32_dummy_id): Delete.
10334         (nds32_unwind_pc): Delete.
10335         (nds32_unwind_sp): Delete.
10336         (nds32_gdbarch_init): Don't register deleted functions with
10337         gdbarch.
10338
10339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10340
10341         * msp430-tdep.c (msp430_unwind_pc): Delete.
10342         (msp430_unwind_sp): Delete.
10343         (msp430_dummy_id): Delete.
10344         (msp430_gdbarch_init): Don't register deleted functions with
10345         gdbarch.
10346
10347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10348
10349         * moxie-tdep.c (moxie_unwind_sp): Delete.
10350         (moxie_unwind_pc): Delete.
10351         (moxie_dummy_id): Delete.
10352         (moxie_gdbarch_init): Don't register deleted functions with
10353         gdbarch.
10354
10355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10356
10357         * mn10300-tdep.c (mn10300_dummy_id): Delete.
10358         (mn10300_unwind_pc): Delete.
10359         (mn10300_unwind_sp): Delete.
10360         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10361         mn10300_unwind_sp.
10362         (mn10300_frame_unwind_init): Don't register deleted functions with
10363         gdbarch.
10364
10365 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10366
10367         * mep-tdep.c (mep_unwind_pc): Delete.
10368         (mep_unwind_sp): Delete.
10369         (mep_dummy_id): Delete.
10370         (mep_gdbarch_init): Don't register deleted functions with
10371         gdbarch.
10372
10373 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10374
10375         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10376         (m68hc11_unwind_sp): Delete.
10377         (m68hc11_gdbarch_init): Don't register deleted functions with
10378         gdbarch.
10379
10380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10381
10382         * m32r-tdep.c (m32r_unwind_sp): Delete.
10383         (m32r_unwind_pc): Delete.
10384         (m32r_dummy_id): Delete.
10385         (m32r_gdbarch_init): Don't register deleted functions with
10386         gdbarch.
10387
10388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10389
10390         * m32c-tdep.c (m32c_unwind_pc): Delete.
10391         (m32c_unwind_sp): Delete.
10392         (m32c_dummy_id): Delete.
10393         (m32c_gdbarch_init): Don't register deleted functions with
10394         gdbarch.
10395
10396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10397
10398         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10399         (lm32_unwind_pc): Delete.
10400         (lm32_dummy_id): Delete.
10401         (lm32_gdbarch_init): Don't register deleted functions with
10402         gdbarch.
10403
10404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10405
10406         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10407         (iq2000_unwind_pc): Delete.
10408         (iq2000_dummy_id): Delete.
10409         (iq2000_gdbarch_init): Don't register deleted functions with
10410         gdbarch.
10411
10412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10413
10414         * nds32-tdep.c (nds32_type_align): Delete.
10415         (nds32_push_dummy_call): Use type_align instead.
10416
10417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10418
10419         * arm-tdep.c (arm_type_align): Only handle vector override case.
10420         (arm_push_dummy_call): Use type_align.
10421         (arm_gdbarch_init): Register arm_type_align gdbarch function.
10422
10423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
10424
10425         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10426         case.
10427         (pass_on_stack): Use type_align.
10428         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10429         function.
10430
10431 2019-04-23  Tom Tromey  <tromey@adacore.com>
10432
10433         * dwarf2read.c (line_header::file_name_at): Remove unused
10434         overload.
10435
10436 2019-04-23  Tom de Vries  <tdevries@suse.de>
10437
10438         PR gdb/24438
10439         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10440         invocation.
10441
10442
10443 2019-03-27  Ali Tamur  <tamur@google.com>
10444
10445         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10446         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10447         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10448         (dwarf_expr_context::get_addr_index): Likewise
10449         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10450         (symbol_needs_eval_context::get_addr_index): Likewise
10451         (disassemble_dwarf_expression): Add DW_OP_addrx
10452         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10453         (read_cutu_die_from_dwo): Update comment
10454         (skip_one_die): Add DW_FORM_addrx
10455         (read_attribute_value): Likewise
10456         (var_decode_location): Add DW_OP_addrx
10457         (dwarf2_const_value_attr): Add DW_FORM_addrx
10458         (dump_die_shallow): Likewise
10459         (dwarf2_fetch_constant_bytes): Likewise
10460         (decode_locdesc): Add DW_OP_addrx
10461         (skip_form_bytes): Add DW_FORM_addrx
10462
10463 2019-04-22  Ali Tamur  <tamur@google.com>
10464
10465         * MAINTAINERS (Write After Approval): Add self.
10466
10467 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
10468
10469         * solib-svr4.c (get_svr4_info): Add pspace parameter.
10470         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10471         (open_symbol_file_object): Likewise.
10472         (svr4_default_sos): Add info parameter.
10473         (svr4_read_so_list): Likewise.
10474         (svr4_current_sos_direct): Adjust functions calls to pass down
10475         info.
10476         (svr4_current_sos_1): Add info parameter.
10477         (svr4_current_sos): Call get_svr4_info, pass info down to
10478         svr4_current_sos_1.
10479         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10480         get_svr4_info.
10481         (svr4_in_dynsym_resolve_code): Pass current_program_space to
10482         get_svr4_info.
10483         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10484         to get_svr4_info.
10485         (probes_table_remove_objfile_probes): Likewise.
10486         (register_solib_event_probe): Add info parameter.
10487         (solist_update_incremental): Pass info parameter down to
10488         svr4_read_so_list.
10489         (disable_probes_interface): Add info parameter.
10490         (svr4_handle_solib_event): Pass current_program_space to
10491         get_svr4_info.  Adjust disable_probes_interface cleanup.
10492         (svr4_create_probe_breakpoints): Add info parameter, pass it
10493         down to register_solib_event_probe.
10494         (svr4_create_solib_event_breakpoints): Add info parameter,
10495         pass it down to svr4_create_probe_breakpoints.
10496         (enable_break): Pass info down to
10497         svr4_create_solib_event_breakpoints.
10498         (svr4_solib_create_inferior_hook): Pass current_program_space to
10499         get_svr4_info.
10500         (svr4_clear_solib): Likewise.
10501
10502 2019-04-22  Pedro Alves  <palves@redhat.com>
10503
10504         * solib-svr4.c (svr4_free_objfile_observer): New.
10505         (probe_and_action::objfile): New field.
10506         (probes_table_htab_remove_objfile_probes)
10507         (probes_table_remove_objfile_probes): New functions.
10508         (register_solib_event_probe): Add 'objfile' parameter.  Store it
10509         in the new probe_and_action.  Don't store the probe in 'lookup'.
10510         (svr4_create_probe_breakpoints): Pass objfile to
10511         register_solib_event_probe.
10512         (_initialize_svr4_solib): Register a free_objfile observer.
10513
10514 2019-04-19  Tom Tromey  <tom@tromey.com>
10515
10516         * common/queue.h: Remove.
10517
10518 2019-04-19  Tom Tromey  <tom@tromey.com>
10519
10520         * event-loop.c: Don't include "common/queue.h".
10521
10522 2019-04-19  Tom Tromey  <tom@tromey.com>
10523
10524         * remote.c (remote_target): Use delete.
10525         * remote-notif.h: Include <list>, not "common/queue.h".
10526         (notif_client_p): Remove typedef.
10527         (remote_notif_state): Add constructor, destructor, initializer.
10528         <notif_queue>: Now a std::list.
10529         (remote_notif_state_xfree): Don't declare.
10530         * remote-notif.c (remote_notif_process, handle_notification)
10531         (remote_notif_state_allocate): Update.
10532         (~remote_notif_state): Rename from remote_notif_state_xfree.
10533
10534 2019-04-19  Tom Tromey  <tom@tromey.com>
10535
10536         * symfile.c (reread_symbols): Update.
10537         * objfiles.c (objfile_register_static_link)
10538         (objfile_lookup_static_link): Update
10539         (~objfile) Don't delete static_links.
10540         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10541
10542 2019-04-19  Tom Tromey  <tom@tromey.com>
10543
10544         * type-stack.h (struct type_stack) <insert>: Constify string.
10545         * type-stack.c (type_stack::insert): Constify string.
10546         * gdbtypes.h (lookup_template_type): Update.
10547         (address_space_name_to_int): Update.
10548         * gdbtypes.c (address_space_name_to_int): Make space_identifier
10549         const.
10550         (lookup_template_type): Make name const.
10551         * c-exp.y: Update rules.
10552         (lex_one_token, classify_name, classify_inner_name)
10553         (c_print_token): Update.
10554         * p-exp.y: Update rules.
10555         (yylex): Update.
10556         * f-exp.y: Update rules.
10557         (yylex): Update.
10558         * d-exp.y: Update rules.
10559         (lex_one_token, classify_name, classify_inner_name): Update.
10560         * parse.c (write_dollar_variable, copy_name): Return std::string.
10561         * parser-defs.h (copy_name): Change return type.
10562         * m2-exp.y: Update rules.
10563         (yylex): Update.
10564         * go-exp.y (lex_one_token): Update.
10565         Update rules.
10566         (classify_unsafe_function, classify_packaged_name)
10567         (classify_name, yylex): Update.
10568
10569 2019-04-19  Sergei Trofimovich <siarheit@google.com>
10570
10571         * configure.ac: add --enable-source-highlight switch.
10572         * configure: Regenerate.
10573         * top.c (print_gdb_version): plumb --enable-source-highlight
10574         status to "show configuration".
10575
10576 2019-04-19  Tom Tromey  <tromey@adacore.com>
10577
10578         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10579         Check ADA_TYPE_P.
10580         (empty_record, ada_template_to_fixed_record_type_1)
10581         (template_to_static_fixed_type)
10582         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10583         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10584         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10585         macros.
10586
10587 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
10588
10589         PR symtab/24423:
10590         * source.c (print_source_lines_base): Advance "iter" when a
10591         control character is seen.
10592
10593 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10594
10595         * inferior.h (struct infcall_suspend_state_deleter):
10596         Catch exception in destructor to avoid crash.
10597
10598 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10599
10600         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10601         close to the add_com "shell".
10602
10603 2019-04-18  Tom Tromey  <tromey@adacore.com>
10604
10605         * process-stratum-target.h (class process_stratum_target)
10606         <stratum>: Add "final".
10607
10608 2019-04-17  Tom Tromey  <tromey@adacore.com>
10609
10610         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10611         against nullptr before use.
10612
10613 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
10614
10615         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10616
10617 2019-04-17  Jim Wilson  <jimw@sifive.com>
10618             Andrew Burgess  <andrew.burgess@embecosm.com>
10619
10620         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10621         code read might fail, assume 4-byte breakpoint in that case.
10622
10623 2019-04-15  Leszek Swirski  <leszeks@google.com>
10624
10625         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10626         rather than a hand-rolled POD check when checking for forced MEMORY
10627         classification.
10628
10629 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10630
10631         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10632         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10633         function.
10634         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10635         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10636         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10637         declaration.
10638
10639 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10640
10641         * aarch64-linux-nat.c
10642         (aarch64_linux_nat_target::thread_architecture): Add override.
10643         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10644         each VQ.
10645
10646 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
10647
10648         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10649
10650 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
10651
10652         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10653         target types of size 96-bits, add some additional comments, and
10654         check that the builtin type we found was the correct size.
10655
10656 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
10657
10658         * utils.c (prompt_for_continue): Don't restore the styling at the
10659         end, as applied_style has the wrong value.  This fixes styling in
10660         long lists of file names that are interrupted by the "Continue?"
10661         prompt.
10662
10663 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
10664
10665         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10666         * c-lang.c (c_language_defn): Likewise.
10667         (cplus_language_defn): Likewise.
10668         (asm_language_defn): Likewise.
10669         (minimal_language_defn): Likewise.
10670         * d-lang.c (d_language_defn): Likewise.
10671         * f-lang.c (f_language_defn): Likewise.
10672         * go-lang.c (go_language_defn): Likewise.
10673         * language.c (unknown_language_defn): Likewise.
10674         (auto_language_defn): Likewise.
10675         * language.h (struct language_defn): Remove la_magic field.
10676         (LANG_MAGIC): Delete.
10677         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10678         * objc-lang.c (objc_language_defn): Likewise.
10679         * opencl-lang.c (opencl_language_defn): Likewise.
10680         * p-lang.c (pascal_language_defn): Likewise.
10681         * rust-lang.c (rust_language_defn): Likewise.
10682
10683 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10684
10685         * riscv-tdep.c (riscv_type_align): New function.
10686         (riscv_type_alignment): Delete.
10687         (riscv_arg_location): Use 'type_align'.
10688         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
10689
10690 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10691
10692         * gdbtypes.c (type_align): A struct with no non-static fields also
10693         has alignment of 1.
10694
10695 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
10696
10697         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
10698         component to 0.
10699         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
10700         member.
10701         (riscv_struct_info::analyse): New implementation using new
10702         analyse_inner member function.
10703         (riscv_struct_info::field_offset): New member function.
10704         (riscv_struct_info::m_offsets): New member variable.
10705         (riscv_struct_info::analyse_inner): New private member function,
10706         takes the old implementation of riscv_struct_info::analyse but
10707         extended to track field offsets.
10708         (riscv_call_arg_struct): Update the struct folding special cases
10709         to handle cases where empty C++ structs, which are non-zero
10710         length, are found.
10711         (riscv_arg_location): Initialise the length of each location, a
10712         non-zero length now indicates the location is in use.
10713         (riscv_push_dummy_call): Allow for the first location having a
10714         non-zero offset when setting up arguments.
10715         (riscv_return_value): Likewise, but for return values.
10716
10717 2019-04-11  Tom Tromey  <tromey@adacore.com>
10718
10719         * utils.c (internal_vproblem): Make "msg" const.
10720
10721 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
10722
10723         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
10724         * trad-frame.c (trad_frame_reset_saved_regs): New function.
10725         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
10726         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
10727
10728 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
10729
10730         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
10731         function.
10732         (fill_gregset): Call amd64_linux_collect_native_gregset instead
10733         of amd64_collect_native_gregset.
10734         (amd64_linux_nat_target::store_registers): Likewise.
10735
10736 2019-04-10  Tom Tromey  <tom@tromey.com>
10737
10738         * symtab.c (lookup_global_symbol_from_objfile)
10739         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
10740         * objfiles.h (class separate_debug_iterator): New.
10741         (class separate_debug_range): New.
10742         (struct objfile) <separate_debug_objfiles>: New method.
10743         (objfile_separate_debug_iterate): Don't declare.
10744         * objfiles.c (separate_debug_iterator::operator++): Rename from
10745         objfile_separate_debug_iterate.
10746         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
10747         iterator.
10748         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
10749         iterator.
10750
10751 2019-04-10  Tom Tromey  <tom@tromey.com>
10752
10753         * symfile.c (reread_symbols): Remove old comment.
10754         * objfiles.c (free_all_objfiles): Fix a typo.
10755
10756 2019-04-10  Tom Tromey  <tom@tromey.com>
10757
10758         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
10759         * minsyms.c (lookup_minimal_symbol): Use foreach.
10760         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
10761         (lookup_minimal_symbol_solib_trampoline): Likewise.
10762         * symfile.c (reread_symbols): Use foreach.
10763
10764 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
10765             Tom Tromey  <tromey@adacore.com>
10766
10767         PR rust/24414:
10768         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
10769         (rust_lex_int_test): Change "value" to be LONGEST.
10770         (rust_lex_tests): Add test for long integer literal.
10771
10772 2019-04-09  Tom Tromey  <tromey@adacore.com>
10773
10774         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
10775         to bool.
10776         (extended_remote_target::attach): Update.
10777         (remote_target::remote_notice_new_inferior): Update.
10778         (remote_target::add_current_inferior_and_thread): Update.
10779         * inferior.c (exit_inferior_1): Use "false".
10780         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
10781
10782 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
10783
10784         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
10785         the "start" command.
10786
10787 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10788
10789         * python/py-inferior.c (infpy_thread_from_thread_handle):
10790         Adjust comments to reflect renaming of thread_from_thread_handle
10791         to thread_from_handle.  Adjust keywords.  Fix type error message.
10792         (inferior_object_methods): Add thread_from_handle.  Retain
10793         thread_from_thread_handle, but mark it as deprecated.
10794
10795 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10796
10797         * gdbthread.h (find_thread_by_handle): Revise declaration.
10798         * thread.c (find_thread_by_handle): Likewise.  Adjust
10799         implementation too.
10800         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
10801         support for buffer objects as handles.
10802
10803 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10804
10805         * python/py-infthread.c (thpy_thread_handle): New function.
10806         (thread_object_methods): Register thpy_thread_handle.
10807
10808 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
10809
10810         * gdbthread.h (thread_to_thread_handle): Declare.
10811         * thread.c (gdbtypes.h): Include.
10812         (thread_to_thread_handle): New function.
10813
10814         * target.h (struct target_ops): Add thread_info_to_thread_handle.
10815         (target_thread_info_to_thread_handle): Declare.
10816         * target.c (target_thread_info_to_thread_handle): New function.
10817         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
10818         * target-delegates.c: Regenerate.
10819
10820         * linux-thread-db.c (class thread_db_target): Add method
10821         thread_info_to_thread_handle.
10822         (thread_db_target::thread_info_to_thread_handle): Define.
10823         * remote.c (class remote_target): Add new method
10824         thread_info_to_thread_handle.
10825         (remote_target::thread_info_to_thread_handle): Define.
10826
10827 2019-04-08  Pedro Alves  <palves@redhat.com>
10828
10829         * common/common-exceptions.c (throw_exception): Don't create
10830         named object to throw; throw directly.
10831         (throw_it): Likewise.  Don't initialize gdb_exception::message
10832         here, with new; pass FMT and AP to the ctor instead.
10833         * common/common-exceptions.h: Include <string>.
10834         (gdb_exception::gdb_exception(enum return_reason, enum errors,
10835         const char *, va_list)): New ctor.  Use std::make_shared.
10836         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
10837         errors)): Delete.
10838         (gdb_exception_error::gdb_exception_error(enum errors, const char
10839         *, va_list)): New.
10840         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
10841         Add assertion.
10842         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
10843         errors)): Delete.
10844         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
10845         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
10846         Add assertion.
10847
10848 2019-04-08  Tom Tromey  <tom@tromey.com>
10849
10850         * valops.c (value_rtti_indirect_type): Replace throw_exception
10851         with throw.
10852         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
10853         with throw.
10854         * thread.c (thr_try_catch_cmd): Replace throw_exception with
10855         throw.
10856         * target.c (target_translate_tls_address): Replace throw_exception
10857         with throw.
10858         * stack.c (frame_apply_command_count): Replace throw_exception
10859         with throw.
10860         * solib-spu.c (append_ocl_sos): Replace throw_exception with
10861         throw.
10862         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
10863         with throw.
10864         * rs6000-tdep.c (rs6000_frame_cache)
10865         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
10866         * remote.c: Replace throw_exception with throw.
10867         * record-full.c (record_full_message, record_full_wait_1)
10868         (record_full_restore): Replace throw_exception with throw.
10869         * record-btrace.c:
10870         (get_thread_current_frame_id, record_btrace_start_replaying)
10871         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
10872         (cmd_record_btrace_start): Replace throw_exception with throw.
10873         * parse.c (parse_exp_in_context_1): Replace throw_exception with
10874         throw.
10875         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
10876         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
10877         * linespec.c:
10878         (find_linespec_symbols): Replace throw_exception with throw.
10879         * infrun.c (displaced_step_prepare, resume): Replace
10880         throw_exception with throw.
10881         * infcmd.c (post_create_inferior): Replace throw_exception with
10882         throw.
10883         * inf-loop.c (inferior_event_handler): Replace throw_exception
10884         with throw.
10885         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
10886         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
10887         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
10888         (get_prev_frame_always, get_frame_pc_if_available)
10889         (get_frame_address_in_block_if_available, get_frame_language):
10890         Replace throw_exception with throw.
10891         * frame-unwind.c (frame_unwind_try_unwinder): Replace
10892         throw_exception with throw.
10893         * eval.c (fetch_subexp_value, evaluate_var_value)
10894         (evaluate_funcall, evaluate_subexp_standard): Replace
10895         throw_exception with throw.
10896         * dwarf2loc.c (call_site_find_chain)
10897         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
10898         Replace throw_exception with throw.
10899         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
10900         with throw.
10901         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
10902         throw.
10903         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
10904         * completer.c (complete_line_internal): Replace throw_exception
10905         with throw.
10906         * compile/compile-object-run.c (compile_object_run): Replace
10907         throw_exception with throw.
10908         * cli/cli-script.c (process_next_line): Replace throw_exception
10909         with throw.
10910         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
10911         (btrace_enable, btrace_maint_update_pt_packets): Replace
10912         throw_exception with throw.
10913         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
10914         throw_exception with throw.
10915         * break-catch-throw.c (re_set_exception_catchpoint): Replace
10916         throw_exception with throw.
10917         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
10918         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
10919         * aarch64-tdep.c (aarch64_make_prologue_cache)
10920         (aarch64_make_stub_cache): Replace throw_exception with throw.
10921
10922 2019-04-08  Tom Tromey  <tom@tromey.com>
10923
10924         * common/common-exceptions.c (throw_exception): Rename from
10925         throw_exception_cxx.  Remove old copy.  Make argument const.
10926         (throw_it): Create and throw exception objects directly.
10927         * common/common-exceptions.h (throw_exception): Make argument
10928         const.
10929         (struct gdb_exception_error): Add constructor.
10930         (struct gdb_exception_quit): Add constructor.
10931
10932 2019-04-08  Tom Tromey  <tom@tromey.com>
10933
10934         * common/common-exceptions.h (exception_rethrow): Don't declare.
10935         (TRY_SJLJ): Update comment.
10936         (TRY, CATCH, END_CATCH): Remove.
10937         * common/common-exceptions.c (exception_rethrow): Remove.
10938
10939 2019-04-08  Tom Tromey  <tom@tromey.com>
10940
10941         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
10942         Remove.
10943         (gdb_exception_error): Rename from
10944         gdb_exception_RETURN_MASK_ERROR.
10945         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
10946         (gdb_quit_bad_alloc): Update.
10947         * aarch64-tdep.c: Update.
10948         * ada-lang.c: Update.
10949         * ada-typeprint.c: Update.
10950         * ada-valprint.c: Update.
10951         * amd64-tdep.c: Update.
10952         * arch-utils.c: Update.
10953         * break-catch-throw.c: Update.
10954         * breakpoint.c: Update.
10955         * btrace.c: Update.
10956         * c-varobj.c: Update.
10957         * cli/cli-cmds.c: Update.
10958         * cli/cli-interp.c: Update.
10959         * cli/cli-script.c: Update.
10960         * common/common-exceptions.c: Update.
10961         * common/new-op.c: Update.
10962         * common/selftest.c: Update.
10963         * compile/compile-c-symbols.c: Update.
10964         * compile/compile-cplus-symbols.c: Update.
10965         * compile/compile-object-load.c: Update.
10966         * compile/compile-object-run.c: Update.
10967         * completer.c: Update.
10968         * corelow.c: Update.
10969         * cp-abi.c: Update.
10970         * cp-support.c: Update.
10971         * cp-valprint.c: Update.
10972         * darwin-nat.c: Update.
10973         * disasm-selftests.c: Update.
10974         * dtrace-probe.c: Update.
10975         * dwarf-index-cache.c: Update.
10976         * dwarf-index-write.c: Update.
10977         * dwarf2-frame-tailcall.c: Update.
10978         * dwarf2-frame.c: Update.
10979         * dwarf2loc.c: Update.
10980         * dwarf2read.c: Update.
10981         * eval.c: Update.
10982         * event-loop.c: Update.
10983         * event-top.c: Update.
10984         * exec.c: Update.
10985         * f-valprint.c: Update.
10986         * fbsd-tdep.c: Update.
10987         * frame-unwind.c: Update.
10988         * frame.c: Update.
10989         * gdbtypes.c: Update.
10990         * gnu-v3-abi.c: Update.
10991         * guile/guile-internal.h: Update.
10992         * guile/scm-block.c: Update.
10993         * guile/scm-breakpoint.c: Update.
10994         * guile/scm-cmd.c: Update.
10995         * guile/scm-disasm.c: Update.
10996         * guile/scm-frame.c: Update.
10997         * guile/scm-lazy-string.c: Update.
10998         * guile/scm-math.c: Update.
10999         * guile/scm-param.c: Update.
11000         * guile/scm-ports.c: Update.
11001         * guile/scm-pretty-print.c: Update.
11002         * guile/scm-symbol.c: Update.
11003         * guile/scm-symtab.c: Update.
11004         * guile/scm-type.c: Update.
11005         * guile/scm-value.c: Update.
11006         * i386-linux-tdep.c: Update.
11007         * i386-tdep.c: Update.
11008         * inf-loop.c: Update.
11009         * infcall.c: Update.
11010         * infcmd.c: Update.
11011         * infrun.c: Update.
11012         * jit.c: Update.
11013         * language.c: Update.
11014         * linespec.c: Update.
11015         * linux-fork.c: Update.
11016         * linux-nat.c: Update.
11017         * linux-tdep.c: Update.
11018         * linux-thread-db.c: Update.
11019         * main.c: Update.
11020         * mi/mi-cmd-break.c: Update.
11021         * mi/mi-cmd-stack.c: Update.
11022         * mi/mi-interp.c: Update.
11023         * mi/mi-main.c: Update.
11024         * objc-lang.c: Update.
11025         * p-valprint.c: Update.
11026         * parse.c: Update.
11027         * ppc-linux-tdep.c: Update.
11028         * printcmd.c: Update.
11029         * python/py-arch.c: Update.
11030         * python/py-breakpoint.c: Update.
11031         * python/py-cmd.c: Update.
11032         * python/py-finishbreakpoint.c: Update.
11033         * python/py-frame.c: Update.
11034         * python/py-framefilter.c: Update.
11035         * python/py-gdb-readline.c: Update.
11036         * python/py-inferior.c: Update.
11037         * python/py-infthread.c: Update.
11038         * python/py-lazy-string.c: Update.
11039         * python/py-linetable.c: Update.
11040         * python/py-objfile.c: Update.
11041         * python/py-param.c: Update.
11042         * python/py-prettyprint.c: Update.
11043         * python/py-progspace.c: Update.
11044         * python/py-record-btrace.c: Update.
11045         * python/py-record.c: Update.
11046         * python/py-symbol.c: Update.
11047         * python/py-type.c: Update.
11048         * python/py-unwind.c: Update.
11049         * python/py-utils.c: Update.
11050         * python/py-value.c: Update.
11051         * python/python.c: Update.
11052         * record-btrace.c: Update.
11053         * record-full.c: Update.
11054         * remote-fileio.c: Update.
11055         * remote.c: Update.
11056         * riscv-tdep.c: Update.
11057         * rs6000-aix-tdep.c: Update.
11058         * rs6000-tdep.c: Update.
11059         * rust-exp.y: Update.
11060         * rust-lang.c: Update.
11061         * s390-tdep.c: Update.
11062         * selftest-arch.c: Update.
11063         * solib-dsbt.c: Update.
11064         * solib-frv.c: Update.
11065         * solib-spu.c: Update.
11066         * solib-svr4.c: Update.
11067         * solib.c: Update.
11068         * sparc64-linux-tdep.c: Update.
11069         * stack.c: Update.
11070         * symfile-mem.c: Update.
11071         * symmisc.c: Update.
11072         * target.c: Update.
11073         * thread.c: Update.
11074         * top.c: Update.
11075         * tracefile-tfile.c: Update.
11076         * tui/tui.c: Update.
11077         * typeprint.c: Update.
11078         * unittests/cli-utils-selftests.c: Update.
11079         * unittests/parse-connection-spec-selftests.c: Update.
11080         * valops.c: Update.
11081         * valprint.c: Update.
11082         * value.c: Update.
11083         * varobj.c: Update.
11084         * windows-nat.c: Update.
11085         * x86-linux-nat.c: Update.
11086         * xml-support.c: Update.
11087
11088 2019-04-08  Tom Tromey  <tom@tromey.com>
11089
11090         * xml-support.c: Use C++ exception handling.
11091         * x86-linux-nat.c: Use C++ exception handling.
11092         * windows-nat.c: Use C++ exception handling.
11093         * varobj.c: Use C++ exception handling.
11094         * value.c: Use C++ exception handling.
11095         * valprint.c: Use C++ exception handling.
11096         * valops.c: Use C++ exception handling.
11097         * unittests/parse-connection-spec-selftests.c: Use C++ exception
11098         handling.
11099         * unittests/cli-utils-selftests.c: Use C++ exception handling.
11100         * typeprint.c: Use C++ exception handling.
11101         * tui/tui.c: Use C++ exception handling.
11102         * tracefile-tfile.c: Use C++ exception handling.
11103         * top.c: Use C++ exception handling.
11104         * thread.c: Use C++ exception handling.
11105         * target.c: Use C++ exception handling.
11106         * symmisc.c: Use C++ exception handling.
11107         * symfile-mem.c: Use C++ exception handling.
11108         * stack.c: Use C++ exception handling.
11109         * sparc64-linux-tdep.c: Use C++ exception handling.
11110         * solib.c: Use C++ exception handling.
11111         * solib-svr4.c: Use C++ exception handling.
11112         * solib-spu.c: Use C++ exception handling.
11113         * solib-frv.c: Use C++ exception handling.
11114         * solib-dsbt.c: Use C++ exception handling.
11115         * selftest-arch.c: Use C++ exception handling.
11116         * s390-tdep.c: Use C++ exception handling.
11117         * rust-lang.c: Use C++ exception handling.
11118         * rust-exp.y: Use C++ exception handling.
11119         * rs6000-tdep.c: Use C++ exception handling.
11120         * rs6000-aix-tdep.c: Use C++ exception handling.
11121         * riscv-tdep.c: Use C++ exception handling.
11122         * remote.c: Use C++ exception handling.
11123         * remote-fileio.c: Use C++ exception handling.
11124         * record-full.c: Use C++ exception handling.
11125         * record-btrace.c: Use C++ exception handling.
11126         * python/python.c: Use C++ exception handling.
11127         * python/py-value.c: Use C++ exception handling.
11128         * python/py-utils.c: Use C++ exception handling.
11129         * python/py-unwind.c: Use C++ exception handling.
11130         * python/py-type.c: Use C++ exception handling.
11131         * python/py-symbol.c: Use C++ exception handling.
11132         * python/py-record.c: Use C++ exception handling.
11133         * python/py-record-btrace.c: Use C++ exception handling.
11134         * python/py-progspace.c: Use C++ exception handling.
11135         * python/py-prettyprint.c: Use C++ exception handling.
11136         * python/py-param.c: Use C++ exception handling.
11137         * python/py-objfile.c: Use C++ exception handling.
11138         * python/py-linetable.c: Use C++ exception handling.
11139         * python/py-lazy-string.c: Use C++ exception handling.
11140         * python/py-infthread.c: Use C++ exception handling.
11141         * python/py-inferior.c: Use C++ exception handling.
11142         * python/py-gdb-readline.c: Use C++ exception handling.
11143         * python/py-framefilter.c: Use C++ exception handling.
11144         * python/py-frame.c: Use C++ exception handling.
11145         * python/py-finishbreakpoint.c: Use C++ exception handling.
11146         * python/py-cmd.c: Use C++ exception handling.
11147         * python/py-breakpoint.c: Use C++ exception handling.
11148         * python/py-arch.c: Use C++ exception handling.
11149         * printcmd.c: Use C++ exception handling.
11150         * ppc-linux-tdep.c: Use C++ exception handling.
11151         * parse.c: Use C++ exception handling.
11152         * p-valprint.c: Use C++ exception handling.
11153         * objc-lang.c: Use C++ exception handling.
11154         * mi/mi-main.c: Use C++ exception handling.
11155         * mi/mi-interp.c: Use C++ exception handling.
11156         * mi/mi-cmd-stack.c: Use C++ exception handling.
11157         * mi/mi-cmd-break.c: Use C++ exception handling.
11158         * main.c: Use C++ exception handling.
11159         * linux-thread-db.c: Use C++ exception handling.
11160         * linux-tdep.c: Use C++ exception handling.
11161         * linux-nat.c: Use C++ exception handling.
11162         * linux-fork.c: Use C++ exception handling.
11163         * linespec.c: Use C++ exception handling.
11164         * language.c: Use C++ exception handling.
11165         * jit.c: Use C++ exception handling.
11166         * infrun.c: Use C++ exception handling.
11167         * infcmd.c: Use C++ exception handling.
11168         * infcall.c: Use C++ exception handling.
11169         * inf-loop.c: Use C++ exception handling.
11170         * i386-tdep.c: Use C++ exception handling.
11171         * i386-linux-tdep.c: Use C++ exception handling.
11172         * guile/scm-value.c: Use C++ exception handling.
11173         * guile/scm-type.c: Use C++ exception handling.
11174         * guile/scm-symtab.c: Use C++ exception handling.
11175         * guile/scm-symbol.c: Use C++ exception handling.
11176         * guile/scm-pretty-print.c: Use C++ exception handling.
11177         * guile/scm-ports.c: Use C++ exception handling.
11178         * guile/scm-param.c: Use C++ exception handling.
11179         * guile/scm-math.c: Use C++ exception handling.
11180         * guile/scm-lazy-string.c: Use C++ exception handling.
11181         * guile/scm-frame.c: Use C++ exception handling.
11182         * guile/scm-disasm.c: Use C++ exception handling.
11183         * guile/scm-cmd.c: Use C++ exception handling.
11184         * guile/scm-breakpoint.c: Use C++ exception handling.
11185         * guile/scm-block.c: Use C++ exception handling.
11186         * guile/guile-internal.h: Use C++ exception handling.
11187         * gnu-v3-abi.c: Use C++ exception handling.
11188         * gdbtypes.c: Use C++ exception handling.
11189         * frame.c: Use C++ exception handling.
11190         * frame-unwind.c: Use C++ exception handling.
11191         * fbsd-tdep.c: Use C++ exception handling.
11192         * f-valprint.c: Use C++ exception handling.
11193         * exec.c: Use C++ exception handling.
11194         * event-top.c: Use C++ exception handling.
11195         * event-loop.c: Use C++ exception handling.
11196         * eval.c: Use C++ exception handling.
11197         * dwarf2read.c: Use C++ exception handling.
11198         * dwarf2loc.c: Use C++ exception handling.
11199         * dwarf2-frame.c: Use C++ exception handling.
11200         * dwarf2-frame-tailcall.c: Use C++ exception handling.
11201         * dwarf-index-write.c: Use C++ exception handling.
11202         * dwarf-index-cache.c: Use C++ exception handling.
11203         * dtrace-probe.c: Use C++ exception handling.
11204         * disasm-selftests.c: Use C++ exception handling.
11205         * darwin-nat.c: Use C++ exception handling.
11206         * cp-valprint.c: Use C++ exception handling.
11207         * cp-support.c: Use C++ exception handling.
11208         * cp-abi.c: Use C++ exception handling.
11209         * corelow.c: Use C++ exception handling.
11210         * completer.c: Use C++ exception handling.
11211         * compile/compile-object-run.c: Use C++ exception handling.
11212         * compile/compile-object-load.c: Use C++ exception handling.
11213         * compile/compile-cplus-symbols.c: Use C++ exception handling.
11214         * compile/compile-c-symbols.c: Use C++ exception handling.
11215         * common/selftest.c: Use C++ exception handling.
11216         * common/new-op.c: Use C++ exception handling.
11217         * cli/cli-script.c: Use C++ exception handling.
11218         * cli/cli-interp.c: Use C++ exception handling.
11219         * cli/cli-cmds.c: Use C++ exception handling.
11220         * c-varobj.c: Use C++ exception handling.
11221         * btrace.c: Use C++ exception handling.
11222         * breakpoint.c: Use C++ exception handling.
11223         * break-catch-throw.c: Use C++ exception handling.
11224         * arch-utils.c: Use C++ exception handling.
11225         * amd64-tdep.c: Use C++ exception handling.
11226         * ada-valprint.c: Use C++ exception handling.
11227         * ada-typeprint.c: Use C++ exception handling.
11228         * ada-lang.c: Use C++ exception handling.
11229         * aarch64-tdep.c: Use C++ exception handling.
11230
11231 2019-04-08  Tom Tromey  <tom@tromey.com>
11232
11233         * xml-support.c (gdb_xml_parser::parse): Update.
11234         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11235         * value.c (show_convenience): Update.
11236         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11237         (test_parse_flags_qcs): Update.
11238         * thread.c (thr_try_catch_cmd): Update.
11239         * target.c (target_translate_tls_address): Update.
11240         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11241         (info_frame_command_core, frame_apply_command_count): Update.
11242         * rust-exp.y (rust_lex_exception_test): Update.
11243         * riscv-tdep.c (riscv_print_one_register_info): Update.
11244         * remote.c (remote_target::enable_btrace): Update.
11245         * record-btrace.c (record_btrace_enable_warn): Update.
11246         * python/py-utils.c (gdbpy_convert_exception): Update.
11247         * printcmd.c (do_one_display, print_variable_and_value): Update.
11248         * mi/mi-main.c (mi_print_exception): Update.
11249         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11250         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11251         * linux-nat.c (linux_nat_target::attach): Update.
11252         * linux-fork.c (class scoped_switch_fork_info): Update.
11253         * infrun.c (displaced_step_prepare): Update.
11254         * infcall.c (call_function_by_hand_dummy): Update.
11255         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11256         * gnu-v3-abi.c (print_one_vtable): Update.
11257         * frame.c (get_prev_frame_always): Update.
11258         * f-valprint.c (info_common_command_for_block): Update.
11259         * exec.c (try_open_exec_file): Update.
11260         * exceptions.c (print_exception, exception_print)
11261         (exception_fprintf, exception_print_same): Update.
11262         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11263         * dwarf-index-cache.c (index_cache::store)
11264         (index_cache::lookup_gdb_index): Update.
11265         * darwin-nat.c (maybe_cache_shell): Update.
11266         * cp-valprint.c (cp_print_value_fields): Update.
11267         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11268         (gcc_cplus_symbol_address): Update.
11269         * compile/compile-c-symbols.c (gcc_convert_symbol)
11270         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11271         * common/selftest.c: Update.
11272         * common/common-exceptions.h (struct gdb_exception) <message>: Now
11273         a std::string.
11274         (exception_try_scope_entry, exception_try_scope_exit): Don't
11275         declare.
11276         (struct exception_try_scope): Remove.
11277         (TRY): Don't use exception_try_scope.
11278         (struct gdb_exception): Add constructor, operator=.
11279         <what>: New method.
11280         (struct gdb_exception_RETURN_MASK_ALL)
11281         (struct gdb_exception_RETURN_MASK_ERROR)
11282         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11283         (struct gdb_quit_bad_alloc): Update.
11284         * common/common-exceptions.c (exception_none): Change
11285         initializer.
11286         (struct catcher) <state, exception>: Initialize inline.
11287         <prev>: Remove member.
11288         (current_catcher): Remove.
11289         (catchers): New global.
11290         (exceptions_state_mc_init): Simplify.
11291         (catcher_pop): Remove.
11292         (exceptions_state_mc, exceptions_state_mc_catch): Update.
11293         (try_scope_depth, exception_try_scope_entry)
11294         (exception_try_scope_exit): Remove.
11295         (throw_exception_sjlj): Update.
11296         (exception_messages, exception_messages_size): Remove.
11297         (throw_it): Simplify.
11298         (gdb_exception_sliced_copy): Remove.
11299         (throw_exception_cxx): Update.
11300         * cli/cli-script.c (script_from_file): Update.
11301         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11302         Update.
11303         * ada-valprint.c (ada_val_print): Update.
11304         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11305         (create_excep_cond_exprs): Update.
11306
11307 2019-04-08  Tom Tromey  <tom@tromey.com>
11308
11309         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11310         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11311         (TRY, CATCH, END_CATCH): Remove some definitions.
11312         * common/common-exceptions.c: Don't use GDB_XCPT.
11313         (catcher_list_size): Remove.
11314         (throw_exception, throw_it): Simplify.
11315
11316 2019-04-05  Tom Tromey  <tom@tromey.com>
11317
11318         Revert the header-sorting patch.
11319         * ft32-tdep.c: Revert.
11320         * frv-tdep.c: Revert.
11321         * frv-linux-tdep.c: Revert.
11322         * frame.c: Revert.
11323         * frame-unwind.c: Revert.
11324         * frame-base.c: Revert.
11325         * fork-child.c: Revert.
11326         * findvar.c: Revert.
11327         * findcmd.c: Revert.
11328         * filesystem.c: Revert.
11329         * filename-seen-cache.h: Revert.
11330         * filename-seen-cache.c: Revert.
11331         * fbsd-tdep.c: Revert.
11332         * fbsd-nat.h: Revert.
11333         * fbsd-nat.c: Revert.
11334         * f-valprint.c: Revert.
11335         * f-typeprint.c: Revert.
11336         * f-lang.c: Revert.
11337         * extension.h: Revert.
11338         * extension.c: Revert.
11339         * extension-priv.h: Revert.
11340         * expprint.c: Revert.
11341         * exec.h: Revert.
11342         * exec.c: Revert.
11343         * exceptions.c: Revert.
11344         * event-top.c: Revert.
11345         * event-loop.c: Revert.
11346         * eval.c: Revert.
11347         * elfread.c: Revert.
11348         * dwarf2read.h: Revert.
11349         * dwarf2read.c: Revert.
11350         * dwarf2loc.c: Revert.
11351         * dwarf2expr.h: Revert.
11352         * dwarf2expr.c: Revert.
11353         * dwarf2-frame.c: Revert.
11354         * dwarf2-frame-tailcall.c: Revert.
11355         * dwarf-index-write.h: Revert.
11356         * dwarf-index-write.c: Revert.
11357         * dwarf-index-common.c: Revert.
11358         * dwarf-index-cache.h: Revert.
11359         * dwarf-index-cache.c: Revert.
11360         * dummy-frame.c: Revert.
11361         * dtrace-probe.c: Revert.
11362         * disasm.h: Revert.
11363         * disasm.c: Revert.
11364         * disasm-selftests.c: Revert.
11365         * dictionary.c: Revert.
11366         * dicos-tdep.c: Revert.
11367         * demangle.c: Revert.
11368         * dcache.h: Revert.
11369         * dcache.c: Revert.
11370         * darwin-nat.h: Revert.
11371         * darwin-nat.c: Revert.
11372         * darwin-nat-info.c: Revert.
11373         * d-valprint.c: Revert.
11374         * d-namespace.c: Revert.
11375         * d-lang.c: Revert.
11376         * ctf.c: Revert.
11377         * csky-tdep.c: Revert.
11378         * csky-linux-tdep.c: Revert.
11379         * cris-tdep.c: Revert.
11380         * cris-linux-tdep.c: Revert.
11381         * cp-valprint.c: Revert.
11382         * cp-support.c: Revert.
11383         * cp-namespace.c: Revert.
11384         * cp-abi.c: Revert.
11385         * corelow.c: Revert.
11386         * corefile.c: Revert.
11387         * continuations.c: Revert.
11388         * completer.h: Revert.
11389         * completer.c: Revert.
11390         * complaints.c: Revert.
11391         * coffread.c: Revert.
11392         * coff-pe-read.c: Revert.
11393         * cli-out.h: Revert.
11394         * cli-out.c: Revert.
11395         * charset.c: Revert.
11396         * c-varobj.c: Revert.
11397         * c-valprint.c: Revert.
11398         * c-typeprint.c: Revert.
11399         * c-lang.c: Revert.
11400         * buildsym.c: Revert.
11401         * buildsym-legacy.c: Revert.
11402         * build-id.h: Revert.
11403         * build-id.c: Revert.
11404         * btrace.c: Revert.
11405         * bsd-uthread.c: Revert.
11406         * breakpoint.h: Revert.
11407         * breakpoint.c: Revert.
11408         * break-catch-throw.c: Revert.
11409         * break-catch-syscall.c: Revert.
11410         * break-catch-sig.c: Revert.
11411         * blockframe.c: Revert.
11412         * block.c: Revert.
11413         * bfin-tdep.c: Revert.
11414         * bfin-linux-tdep.c: Revert.
11415         * bfd-target.c: Revert.
11416         * bcache.c: Revert.
11417         * ax-general.c: Revert.
11418         * ax-gdb.h: Revert.
11419         * ax-gdb.c: Revert.
11420         * avr-tdep.c: Revert.
11421         * auxv.c: Revert.
11422         * auto-load.c: Revert.
11423         * arm-wince-tdep.c: Revert.
11424         * arm-tdep.c: Revert.
11425         * arm-symbian-tdep.c: Revert.
11426         * arm-pikeos-tdep.c: Revert.
11427         * arm-obsd-tdep.c: Revert.
11428         * arm-nbsd-tdep.c: Revert.
11429         * arm-nbsd-nat.c: Revert.
11430         * arm-linux-tdep.c: Revert.
11431         * arm-linux-nat.c: Revert.
11432         * arm-fbsd-tdep.c: Revert.
11433         * arm-fbsd-nat.c: Revert.
11434         * arm-bsd-tdep.c: Revert.
11435         * arch-utils.c: Revert.
11436         * arc-tdep.c: Revert.
11437         * arc-newlib-tdep.c: Revert.
11438         * annotate.h: Revert.
11439         * annotate.c: Revert.
11440         * amd64-windows-tdep.c: Revert.
11441         * amd64-windows-nat.c: Revert.
11442         * amd64-tdep.c: Revert.
11443         * amd64-sol2-tdep.c: Revert.
11444         * amd64-obsd-tdep.c: Revert.
11445         * amd64-obsd-nat.c: Revert.
11446         * amd64-nbsd-tdep.c: Revert.
11447         * amd64-nbsd-nat.c: Revert.
11448         * amd64-nat.c: Revert.
11449         * amd64-linux-tdep.c: Revert.
11450         * amd64-linux-nat.c: Revert.
11451         * amd64-fbsd-tdep.c: Revert.
11452         * amd64-fbsd-nat.c: Revert.
11453         * amd64-dicos-tdep.c: Revert.
11454         * amd64-darwin-tdep.c: Revert.
11455         * amd64-bsd-nat.c: Revert.
11456         * alpha-tdep.c: Revert.
11457         * alpha-obsd-tdep.c: Revert.
11458         * alpha-nbsd-tdep.c: Revert.
11459         * alpha-mdebug-tdep.c: Revert.
11460         * alpha-linux-tdep.c: Revert.
11461         * alpha-linux-nat.c: Revert.
11462         * alpha-bsd-tdep.c: Revert.
11463         * alpha-bsd-nat.c: Revert.
11464         * aix-thread.c: Revert.
11465         * agent.c: Revert.
11466         * addrmap.c: Revert.
11467         * ada-varobj.c: Revert.
11468         * ada-valprint.c: Revert.
11469         * ada-typeprint.c: Revert.
11470         * ada-tasks.c: Revert.
11471         * ada-lang.c: Revert.
11472         * aarch64-tdep.c: Revert.
11473         * aarch64-ravenscar-thread.c: Revert.
11474         * aarch64-newlib-tdep.c: Revert.
11475         * aarch64-linux-tdep.c: Revert.
11476         * aarch64-linux-nat.c: Revert.
11477         * aarch64-fbsd-tdep.c: Revert.
11478         * aarch64-fbsd-nat.c: Revert.
11479         * aarch32-linux-nat.c: Revert.
11480
11481 2019-04-05  Tom Tromey  <tom@tromey.com>
11482
11483         * ft32-tdep.c: Sort headers.
11484         * frv-tdep.c: Sort headers.
11485         * frv-linux-tdep.c: Sort headers.
11486         * frame.c: Sort headers.
11487         * frame-unwind.c: Sort headers.
11488         * frame-base.c: Sort headers.
11489         * fork-child.c: Sort headers.
11490         * findvar.c: Sort headers.
11491         * findcmd.c: Sort headers.
11492         * filesystem.c: Sort headers.
11493         * filename-seen-cache.h: Sort headers.
11494         * filename-seen-cache.c: Sort headers.
11495         * fbsd-tdep.c: Sort headers.
11496         * fbsd-nat.h: Sort headers.
11497         * fbsd-nat.c: Sort headers.
11498         * f-valprint.c: Sort headers.
11499         * f-typeprint.c: Sort headers.
11500         * f-lang.c: Sort headers.
11501         * extension.h: Sort headers.
11502         * extension.c: Sort headers.
11503         * extension-priv.h: Sort headers.
11504         * expprint.c: Sort headers.
11505         * exec.h: Sort headers.
11506         * exec.c: Sort headers.
11507         * exceptions.c: Sort headers.
11508         * event-top.c: Sort headers.
11509         * event-loop.c: Sort headers.
11510         * eval.c: Sort headers.
11511         * elfread.c: Sort headers.
11512         * dwarf2read.h: Sort headers.
11513         * dwarf2read.c: Sort headers.
11514         * dwarf2loc.c: Sort headers.
11515         * dwarf2expr.h: Sort headers.
11516         * dwarf2expr.c: Sort headers.
11517         * dwarf2-frame.c: Sort headers.
11518         * dwarf2-frame-tailcall.c: Sort headers.
11519         * dwarf-index-write.h: Sort headers.
11520         * dwarf-index-write.c: Sort headers.
11521         * dwarf-index-common.c: Sort headers.
11522         * dwarf-index-cache.h: Sort headers.
11523         * dwarf-index-cache.c: Sort headers.
11524         * dummy-frame.c: Sort headers.
11525         * dtrace-probe.c: Sort headers.
11526         * disasm.h: Sort headers.
11527         * disasm.c: Sort headers.
11528         * disasm-selftests.c: Sort headers.
11529         * dictionary.c: Sort headers.
11530         * dicos-tdep.c: Sort headers.
11531         * demangle.c: Sort headers.
11532         * dcache.h: Sort headers.
11533         * dcache.c: Sort headers.
11534         * darwin-nat.h: Sort headers.
11535         * darwin-nat.c: Sort headers.
11536         * darwin-nat-info.c: Sort headers.
11537         * d-valprint.c: Sort headers.
11538         * d-namespace.c: Sort headers.
11539         * d-lang.c: Sort headers.
11540         * ctf.c: Sort headers.
11541         * csky-tdep.c: Sort headers.
11542         * csky-linux-tdep.c: Sort headers.
11543         * cris-tdep.c: Sort headers.
11544         * cris-linux-tdep.c: Sort headers.
11545         * cp-valprint.c: Sort headers.
11546         * cp-support.c: Sort headers.
11547         * cp-namespace.c: Sort headers.
11548         * cp-abi.c: Sort headers.
11549         * corelow.c: Sort headers.
11550         * corefile.c: Sort headers.
11551         * continuations.c: Sort headers.
11552         * completer.h: Sort headers.
11553         * completer.c: Sort headers.
11554         * complaints.c: Sort headers.
11555         * coffread.c: Sort headers.
11556         * coff-pe-read.c: Sort headers.
11557         * cli-out.h: Sort headers.
11558         * cli-out.c: Sort headers.
11559         * charset.c: Sort headers.
11560         * c-varobj.c: Sort headers.
11561         * c-valprint.c: Sort headers.
11562         * c-typeprint.c: Sort headers.
11563         * c-lang.c: Sort headers.
11564         * buildsym.c: Sort headers.
11565         * buildsym-legacy.c: Sort headers.
11566         * build-id.h: Sort headers.
11567         * build-id.c: Sort headers.
11568         * btrace.c: Sort headers.
11569         * bsd-uthread.c: Sort headers.
11570         * breakpoint.h: Sort headers.
11571         * breakpoint.c: Sort headers.
11572         * break-catch-throw.c: Sort headers.
11573         * break-catch-syscall.c: Sort headers.
11574         * break-catch-sig.c: Sort headers.
11575         * blockframe.c: Sort headers.
11576         * block.c: Sort headers.
11577         * bfin-tdep.c: Sort headers.
11578         * bfin-linux-tdep.c: Sort headers.
11579         * bfd-target.c: Sort headers.
11580         * bcache.c: Sort headers.
11581         * ax-general.c: Sort headers.
11582         * ax-gdb.h: Sort headers.
11583         * ax-gdb.c: Sort headers.
11584         * avr-tdep.c: Sort headers.
11585         * auxv.c: Sort headers.
11586         * auto-load.c: Sort headers.
11587         * arm-wince-tdep.c: Sort headers.
11588         * arm-tdep.c: Sort headers.
11589         * arm-symbian-tdep.c: Sort headers.
11590         * arm-pikeos-tdep.c: Sort headers.
11591         * arm-obsd-tdep.c: Sort headers.
11592         * arm-nbsd-tdep.c: Sort headers.
11593         * arm-nbsd-nat.c: Sort headers.
11594         * arm-linux-tdep.c: Sort headers.
11595         * arm-linux-nat.c: Sort headers.
11596         * arm-fbsd-tdep.c: Sort headers.
11597         * arm-fbsd-nat.c: Sort headers.
11598         * arm-bsd-tdep.c: Sort headers.
11599         * arch-utils.c: Sort headers.
11600         * arc-tdep.c: Sort headers.
11601         * arc-newlib-tdep.c: Sort headers.
11602         * annotate.h: Sort headers.
11603         * annotate.c: Sort headers.
11604         * amd64-windows-tdep.c: Sort headers.
11605         * amd64-windows-nat.c: Sort headers.
11606         * amd64-tdep.c: Sort headers.
11607         * amd64-sol2-tdep.c: Sort headers.
11608         * amd64-obsd-tdep.c: Sort headers.
11609         * amd64-obsd-nat.c: Sort headers.
11610         * amd64-nbsd-tdep.c: Sort headers.
11611         * amd64-nbsd-nat.c: Sort headers.
11612         * amd64-nat.c: Sort headers.
11613         * amd64-linux-tdep.c: Sort headers.
11614         * amd64-linux-nat.c: Sort headers.
11615         * amd64-fbsd-tdep.c: Sort headers.
11616         * amd64-fbsd-nat.c: Sort headers.
11617         * amd64-dicos-tdep.c: Sort headers.
11618         * amd64-darwin-tdep.c: Sort headers.
11619         * amd64-bsd-nat.c: Sort headers.
11620         * alpha-tdep.c: Sort headers.
11621         * alpha-obsd-tdep.c: Sort headers.
11622         * alpha-nbsd-tdep.c: Sort headers.
11623         * alpha-mdebug-tdep.c: Sort headers.
11624         * alpha-linux-tdep.c: Sort headers.
11625         * alpha-linux-nat.c: Sort headers.
11626         * alpha-bsd-tdep.c: Sort headers.
11627         * alpha-bsd-nat.c: Sort headers.
11628         * aix-thread.c: Sort headers.
11629         * agent.c: Sort headers.
11630         * addrmap.c: Sort headers.
11631         * ada-varobj.c: Sort headers.
11632         * ada-valprint.c: Sort headers.
11633         * ada-typeprint.c: Sort headers.
11634         * ada-tasks.c: Sort headers.
11635         * ada-lang.c: Sort headers.
11636         * aarch64-tdep.c: Sort headers.
11637         * aarch64-ravenscar-thread.c: Sort headers.
11638         * aarch64-newlib-tdep.c: Sort headers.
11639         * aarch64-linux-tdep.c: Sort headers.
11640         * aarch64-linux-nat.c: Sort headers.
11641         * aarch64-fbsd-tdep.c: Sort headers.
11642         * aarch64-fbsd-nat.c: Sort headers.
11643         * aarch32-linux-nat.c: Sort headers.
11644
11645 2019-04-04  Tom Tromey  <tom@tromey.com>
11646
11647         * varobj.c (varobj_create): Update.
11648         * rust-exp.y (struct rust_parser) <update_innermost_block,
11649         lookup_symbol>: New methods.
11650         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11651         Rename.
11652         (rust_parser::rust_lookup_type)
11653         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11654         * printcmd.c (display_command, do_one_display): Update.
11655         * parser-defs.h (struct parser_state) <parser_state>: Add
11656         "tracker" parameter.
11657         (block_tracker): New member.
11658         (class innermost_block_tracker) <innermost_block_tracker>: Add
11659         "types" parameter.
11660         <reset>: Remove method.
11661         (innermost_block): Don't declare.
11662         (null_post_parser): Update.
11663         * parse.c (innermost_block): Remove global.
11664         (write_dollar_variable): Update.
11665         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11666         Remove "tracker_types" parameter.
11667         (parse_expression): Add "tracker" parameter.
11668         (parse_expression_for_completion): Update.
11669         (null_post_parser): Add "tracker" parameter.
11670         * p-exp.y: Update rules.
11671         * m2-exp.y: Update rules.
11672         * language.h (struct language_defn) <la_post_parser>: Add
11673         "tracker" parameter.
11674         * go-exp.y: Update rules.
11675         * f-exp.y: Update rules.
11676         * expression.h (parse_expression, parse_exp_1): Add "tracker"
11677         parameter.
11678         * d-exp.y: Update rules.
11679         * c-exp.y: Update rules.
11680         * breakpoint.c (set_breakpoint_condition): Create an
11681         innermost_block_tracker.
11682         (watch_command_1): Likewise.
11683         * ada-lang.c (resolve): Add "tracker" parameter.
11684         (resolve_subexp): Likewise.
11685         * ada-exp.y (write_var_from_sym): Update.
11686
11687 2019-04-04  Tom Tromey  <tom@tromey.com>
11688
11689         * type-stack.h: New file.
11690         * type-stack.c: New file.
11691         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
11692         type-stack.h.
11693         (insert_into_type_stack, insert_type, push_type, push_type_int)
11694         (insert_type_address_space, pop_type, pop_type_int)
11695         (pop_typelist, pop_type_stack, append_type_stack)
11696         (push_type_stack, get_type_stack, push_typelist)
11697         (follow_type_instance_flags, follow_types): Don't declare.
11698         * parse.c (type_stack): Remove global.
11699         (parse_exp_in_context): Update.
11700         (insert_into_type_stack, insert_type, push_type, push_type_int)
11701         (insert_type_address_space, pop_type, pop_type_int)
11702         (pop_typelist, pop_type_stack, append_type_stack)
11703         (push_type_stack, get_type_stack, push_typelist)
11704         (follow_type_instance_flags, follow_types): Remove (moved to
11705         type-stack.c).
11706         * f-exp.y (type_stack): New global.
11707         Update rules.
11708         (push_kind_type, f_parse): Update.
11709         * d-exp.y (type_stack): New global.
11710         Update rules.
11711         (d_parse): Update.
11712         * c-exp.y (struct c_parse_state) <type_stack>: New member.
11713         Update rules.
11714         * Makefile.in (COMMON_SFILES): Add type-stack.c.
11715         (HFILES_NO_SRCDIR): Add type-stack.h.
11716
11717 2019-04-04  Tom Tromey  <tom@tromey.com>
11718
11719         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
11720         (rust_parser::convert_ast_to_expression, rust_parse)
11721         (rust_lex_test_completion, rust_lex_tests): Update.
11722         * parser-defs.h (struct expr_completion_state): New.
11723         (struct parser_state) <parser_state>: Add completion parameter.
11724         <mark_struct_expression, mark_completion_tag>: New methods.
11725         <parse_completion, m_completion_state>: New members.
11726         (prefixify_expression, null_post_parser): Update.
11727         (mark_struct_expression, mark_completion_tag): Don't declare.
11728         * parse.c (parse_completion, expout_last_struct)
11729         (expout_tag_completion_type, expout_completion_name): Remove
11730         globals.
11731         (parser_state::mark_struct_expression)
11732         (parser_state::mark_completion_tag): Now methods.
11733         (prefixify_expression): Add last_struct parameter.
11734         (prefixify_subexp): Likewise.
11735         (parse_exp_1): Update.
11736         (parse_exp_in_context): Add cstate parameter.  Update.
11737         (parse_expression_for_completion): Create an
11738         expr_completion_state.
11739         (null_post_parser): Add "completion" parameter.
11740         * p-exp.y: Update rules.
11741         (yylex): Update.
11742         * language.h (struct language_defn) <la_post_parser>: Add
11743         "completing" parameter.
11744         * go-exp.y: Update rules.
11745         (lex_one_token): Update.
11746         * expression.h (parse_completion): Don't declare.
11747         * d-exp.y: Update rules.
11748         (lex_one_token): Update rules.
11749         * c-exp.y: Update rules.
11750         (lex_one_token): Update.
11751         * ada-lang.c (resolve): Add "parse_completion" parameter.
11752         (resolve_subexp): Likewise.
11753         (ada_resolve_function): Likewise.
11754
11755 2019-04-04  Tom Tromey  <tom@tromey.com>
11756
11757         * parser-defs.h (struct parser_state) <start_arglist,
11758         end_arglist>: New methods.
11759         <arglist_len, m_funcall_chain>: New members.
11760         (arglist_len, start_arglist, end_arglist): Don't declare.
11761         * parse.c (arglist_len, funcall_chain): Remove global.
11762         (start_arglist, end_arglist): Remove functions.
11763         (parse_exp_in_context): Update.
11764         * p-exp.y: Update rules.
11765         * m2-exp.y: Update rules.
11766         * go-exp.y: Update rules.
11767         * f-exp.y: Update rules.
11768         * d-exp.y: Update rules.
11769         * c-exp.y: Update rules.
11770
11771 2019-04-04  Tom Tromey  <tom@tromey.com>
11772
11773         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
11774         lex_operator, push_back>: New methods.
11775         Update all rules.
11776         (rust_parser::lex_hex, lex_escape): Rename and update.
11777         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
11778         (rust_parser::lex_operator): Rename and update.
11779         (rust_parser::lex_number, rustyylex, rustyyerror)
11780         (rust_lex_test_init, rust_lex_test_sequence)
11781         (rust_lex_test_push_back, rust_lex_tests): Update.
11782         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
11783         parameter.
11784         <lexptr, prev_lexptr>: New members.
11785         (lexptr, prev_lexptr): Don't declare.
11786         * parse.c (lexptr, prev_lexptr): Remove globals.
11787         (parse_exp_in_context): Update.
11788         * p-exp.y (yylex, yyerror): Update.
11789         * m2-exp.y (parse_number, yylex, yyerror): Update.
11790         * go-exp.y (lex_one_token, yyerror): Update.
11791         * f-exp.y (match_string_literal, yylex, yyerror): Update.
11792         * d-exp.y (lex_one_token, yyerror): Update.
11793         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
11794         (lex_one_token, yyerror): Update.
11795         * ada-lex.l (YY_INPUT): Update.
11796         (rewind_to_char): Update.
11797         * ada-exp.y (yyerror): Update.
11798
11799 2019-04-04  Tom Tromey  <tom@tromey.com>
11800
11801         * rust-exp.y (rustyylex, rust_lex_tests): Update.
11802         * parser-defs.h (struct parser_state) <parser_state>: Add new
11803         parameter.
11804         <comma_terminates>: New member.
11805         (comma_terminates): Don't declare global.
11806         * parse.c (comma_terminates): Remove global.
11807         (parse_exp_in_context): Update.
11808         * p-exp.y (yylex): Update.
11809         * m2-exp.y (yylex): Update.
11810         * go-exp.y (lex_one_token): Update.
11811         * f-exp.y (yylex): Update.
11812         * d-exp.y (lex_one_token): Update.
11813         * c-exp.y (lex_one_token): Update.
11814         * ada-lex.l: Update.
11815
11816 2019-04-04  Tom Tromey  <tom@tromey.com>
11817
11818         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
11819         (rustyylex, rust_lex_test_init, rust_lex_test_one)
11820         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
11821         * parser-defs.h (paren_depth): Don't declare.
11822         * parse.c (paren_depth): Remove global.
11823         (parse_exp_in_context): Update.
11824         * p-exp.y (paren_depth): New global.
11825         (pascal_parse): Initialize it.
11826         * m2-exp.y (paren_depth): New global.
11827         (m2_parse): Initialize it.
11828         * go-exp.y (paren_depth): New global.
11829         (go_parse): Initialize it.
11830         * f-exp.y (paren_depth): New global.
11831         (f_parse): Initialize it.
11832         * d-exp.y (paren_depth): New global.
11833         (d_parse): Initialize it.
11834         * c-exp.y (paren_depth): New global.
11835         (c_parse): Initialize it.
11836         * ada-lex.l (paren_depth): New global.
11837         (lexer_init): Initialize it.
11838
11839 2019-04-04  Tom Tromey  <tom@tromey.com>
11840
11841         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
11842         (rust_parser::convert_ast_to_type)
11843         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11844         * parser-defs.h (struct parser_state) <parser_state>: Add
11845         parameters.  Initialize new members.
11846         <expression_context_block, expression_context_pc>: New members.
11847         * parse.c (expression_context_block, expression_context_pc):
11848         Remove globals.
11849         (parse_exp_in_context): Update.
11850         * p-exp.y: Update all rules.
11851         (yylex): Update.
11852         * m2-exp.y: Update all rules.
11853         (yylex): Update.
11854         * go-exp.y (yylex): Update.
11855         * f-exp.y (yylex): Update.
11856         * d-exp.y: Update all rules.
11857         (yylex): Update.
11858         * c-exp.y: Update all rules.
11859         (lex_one_token, classify_name, yylex, c_parse): Update.
11860         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
11861
11862 2019-04-04  Tom Tromey  <tom@tromey.com>
11863
11864         * gdbarch.h, gdbarch.c: Rebuild.
11865         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
11866         * stap-probe.h:
11867         (struct stap_parse_info): Replace "parser_state" with
11868         "expr_builder".
11869         * parser-defs.h (struct expr_builder): Rename from "parser_state".
11870         (parser_state): New class.
11871         * parse.c (expr_builder): Rename.
11872         (expr_builder::release): Rename.
11873         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
11874         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
11875         (write_exp_elt_longcst, write_exp_elt_floatcst)
11876         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
11877         (write_exp_string_vector, write_exp_bitstring)
11878         (write_exp_msymbol, mark_struct_expression)
11879         (write_dollar_variable)
11880         (insert_type_address_space, increase_expout_size): Replace
11881         "parser_state" with "expr_builder".
11882         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
11883         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
11884         "parser_state" with "expr_builder".
11885
11886 2019-04-04  Tom Tromey  <tom@tromey.com>
11887
11888         * rust-exp.y: Replace "parse_language" with method call.
11889         * p-exp.y:
11890         (yylex): Replace "parse_language" with method call.
11891         * m2-exp.y:
11892         (yylex): Replace "parse_language" with method call.
11893         * go-exp.y (classify_name): Replace "parse_language" with method
11894         call.
11895         * f-exp.y (yylex): Replace "parse_language" with method call.
11896         * d-exp.y (lex_one_token): Replace "parse_language" with method
11897         call.
11898         * c-exp.y:
11899         (lex_one_token, classify_name, yylex): Replace "parse_language"
11900         with method call.
11901         * ada-exp.y (find_primitive_type, type_char)
11902         (type_system_address): Replace "parse_language" with method call.
11903
11904 2019-04-04  Tom Tromey  <tom@tromey.com>
11905
11906         * rust-exp.y: Replace "parse_gdbarch" with method call.
11907         * parse.c (write_dollar_variable, insert_type_address_space):
11908         Replace "parse_gdbarch" with method call.
11909         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
11910         call.
11911         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
11912         call.
11913         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
11914         "parse_gdbarch" with method call.
11915         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
11916         with method call.
11917         * f-exp.y (parse_type, parse_f_type, yylex): Replace
11918         "parse_gdbarch" with method call.
11919         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
11920         "parse_gdbarch" with method call.
11921         * c-exp.y (parse_type, parse_number, classify_name): Replace
11922         "parse_gdbarch" with method call.
11923         * ada-lex.l: Replace "parse_gdbarch" with method call.
11924         * ada-exp.y (parse_type, find_primitive_type, type_char)
11925         (type_system_address): Replace "parse_gdbarch" with method call.
11926
11927 2019-04-04  Tom Tromey  <tom@tromey.com>
11928
11929         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
11930         * stap-probe.c (stap_parse_argument): Update.
11931         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
11932         initial_size parameter.
11933         * rust-exp.y (rust_lex_tests): Update.
11934         * parse.c (parser_state): Update.
11935         (parse_exp_in_context): Update.
11936         * parser-defs.h (struct parser_state) <parser_state>: Remove
11937         "initial_size" parameter.
11938
11939 2019-04-04  Tom Tromey  <tom@tromey.com>
11940
11941         * parser-defs.h (increase_expout_size): Don't declare.
11942         * parse.c (increase_expout_size): Now static.
11943
11944 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
11945
11946         * gnu-nat.c (gnu_nat_target::wait): Fix
11947         target_waitstatus_to_string call.
11948
11949 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11950
11951         * eval.c (evaluate_subexp_standard): Handle internal functions
11952         during Fortran function call handling.
11953
11954 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
11955
11956         * NEWS: Mention new internal functions.
11957         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
11958         (read_base_type): Use dwarf2_init_complex_target_type.
11959         * value.c (creal_internal_fn): New function.
11960         (cimag_internal_fn): New function.
11961         (_initialize_values): Register new internal functions.
11962
11963 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11964
11965         * infrun.c (stop_all_threads): If debug_infrun, always
11966         trace the wait status after wait_one, using
11967         target_waitstatus_to_string and target_pid_to_str.
11968         (handle_inferior_event): Replace various trace of
11969         wait status kind by a single trace.
11970         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
11971         wait status kind image by target_waitstatus_to_string.
11972         * target/waitstatus.c (target_waitstatus_to_string): Fix
11973         obsolete comment.
11974
11975 2019-04-01  Tom Tromey  <tromey@adacore.com>
11976
11977         PR symtab/23331:
11978         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
11979
11980 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
11981             Pedro Alves  <palves@redhat.com>
11982
11983         * top.c (quit_force): Call 'finalize_values'.
11984         * value.c (finalize_values): New function.
11985         * value.h (finalize_values): Declare.
11986
11987 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
11988
11989         * NEWS: Announce $_gdb_major and $_gdb_minor.
11990
11991         * top.c (init_gdb_version_vars): New function.
11992         (gdb_init): Call init_gdb_version_vars.
11993
11994 2019-03-29  Tom Tromey  <tromey@adacore.com>
11995
11996         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
11997         help text.  Remove dead code.
11998
11999 2019-03-29  Keith Seitz  <keiths@redhat.com>
12000
12001         From Siddhesh Poyarekar:
12002         * f-lang.h (f77_get_upperbound): Return LONGEST.
12003         (f77_get_lowerbound): Likewise.
12004         * f-typeprint.c (f_type_print_varspec_suffix): Expand
12005         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
12006         print them.
12007         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
12008         plongest to format print it.
12009         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12010         (f77_get_upperbound): Likewise.
12011         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12012         LOWER_BOUND to LONGEST.
12013         (f77_create_arrayprint_offset_tbl): Likewise.
12014
12015 2019-03-29  Keith Seitz  <keiths@redhat.com>
12016
12017         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12018         %s/pulongest for TYPE_LENGTH instead of %d in format
12019         strings.
12020         * ada-typerint.c (ada_print_type): Likewise.
12021         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12022         * compile/compile-c-support.c (generate_register_struct): Likewise.
12023         * gdbtypes.c (recursive_dump_type): Likewise.
12024         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12025         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
12026         instead of %d in format strings.
12027         * riscv-tdep.c (riscv_type_alignment): Cast second argument
12028         to std::min to ULONGEST.
12029         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12030         instead of %d in format strings.
12031         * tracepoint.c (info_scope_command): Likewise.
12032         * typeprint.c (print_offset_data::update)
12033         (print_offset_data::finish): Likewise.
12034         * xtensa-tdep.c (xtensa_store_return_value)
12035         (xtensa_push_dummy_call): Likewise.
12036
12037 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
12038
12039         * windows-nat.c (display_selector): Fixed format specifications
12040         for 64-bit Cygwin.
12041
12042 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12043
12044         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12045
12046 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
12047
12048         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12049         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12050         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12051         (nios2_linux_init_abi): Install it.
12052
12053 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12054
12055         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12056
12057 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
12058
12059         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12060
12061 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12062             Tom Tromey  <tromey@adacore.com>
12063
12064         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12065
12066 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
12067
12068         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12069         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12070         method to compute the bounds of range types. Also print "[evaluated]"
12071         if the bounds' values come from a dynamic evaluation.
12072
12073 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12074
12075         * cp-valprint.c (cp_print_value_fields): Don't print trailing
12076         whitespace when pretty printing is on.
12077
12078 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12079
12080         * ppc-linux-nat.c: Add include.
12081
12082 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12083
12084         * NEWS: Mention AArch64 Pointer Authentication.
12085
12086 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
12087
12088         * arm-linux-nat.c: Add include.
12089
12090 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
12091
12092         * source-cache.c (source_cache::get_source_lines): Re-read
12093         fullname after calling open_source_file.
12094
12095 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
12096
12097         * NEWS: Mention TLS support for FreeBSD.
12098
12099 2019-03-25  Tom Tromey  <tromey@adacore.com>
12100
12101         * minsyms.c (BUNCH_SIZE): Update comment.
12102         (~minimal_symbol_reader): Remove old comment.
12103         (compact_minimal_symbols): Update comment.
12104         (minimal_symbol_reader::install): Remove old comment.  Update
12105         other comments.
12106
12107 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12108
12109         * s390-linux-nat.c: Add include.
12110
12111 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
12112
12113         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12114         Call linux_get_hwcap.
12115         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12116         Likewise.
12117         (aarch64_linux_get_hwcap): Remove function.
12118         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12119         declaration.
12120         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12121         linux_get_hwcap.
12122         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12123         * linux-tdep.c (linux_get_hwcap): Add function.
12124         (linux_get_hwcap2): Likewise.
12125         * linux-tdep.h (linux_get_hwcap): Add declaration.
12126         (linux_get_hwcap2): Likewise.
12127         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12128         (ppc_linux_get_hwcap2): Likewise.
12129         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12130         linux_get_hwcap.
12131         (ppc_linux_nat_target::insert_watchpoint): Likewise.
12132         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12133         (ppc_linux_nat_target::read_description): Likewise.
12134         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12135         * s390-linux-nat.c: Likewise.
12136         * s390-linux-tdep.c (s390_core_read_description): Likewise.
12137
12138 2019-03-24  Tom Tromey  <tom@tromey.com>
12139
12140         * ada-lang.c (standard_lookup): Simplify initialization.
12141         (ada_lookup_symbol_nonlocal): Simplify return.
12142         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12143         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12144         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12145         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12146         initialization.
12147         * solib.c (solib_global_lookup): Simplify.
12148         * symtab.c (null_block_symbol): Remove.
12149         (symbol_cache_lookup): Simplify returns.
12150         (lookup_language_this): Simplify returns.
12151         (lookup_symbol_aux): Simplify return.
12152         (lookup_local_symbol): Simplify returns.
12153         (lookup_global_symbol_from_objfile): Simplify return.
12154         (lookup_symbol_in_objfile_symtabs)
12155         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12156         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12157         (lookup_static_symbol, lookup_global_symbol): Simplify return.
12158         * cp-namespace.c (cp_lookup_bare_symbol)
12159         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12160         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12161         (cp_lookup_nested_symbol): Don't use null_block_symbol.
12162         (cp_lookup_symbol_via_imports): Simplify initialization.
12163         (find_symbol_in_baseclass): Likewise.
12164         * symtab.h (null_block_symbol): Remove.
12165         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12166         (d_lookup_nested_symbol, d_lookup_symbol_imports)
12167         (d_lookup_symbol_module): Likewise.
12168         (find_symbol_in_baseclass): Simplify initialization.
12169
12170 2019-03-24  Tom Tromey  <tom@tromey.com>
12171
12172         * expression.h: Don't include symtab.h.
12173         (struct block): Forward declare.
12174
12175 2019-03-24  Tom Tromey  <tom@tromey.com>
12176
12177         * c-exp.y (typebase): Remove casts.
12178         * gdbtypes.c (lookup_unsigned_typename, )
12179         (lookup_signed_typename): Remove cast.
12180         * eval.c (parse_to_comma_and_eval): Remove cast.
12181         * parse.c (write_dollar_variable): Remove cast.
12182         * block.h (struct block) <superblock>: Now const.
12183         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12184         * psymtab.c (psym_map_matching_symbols): Make "block" const.
12185         (map_block): Make "block" const.
12186         * symfile.h (struct quick_symbol_functions)
12187         <map_matching_symbols>: Constify block argument to "callback".
12188         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12189         const.
12190         (find_pc_sect_compunit_symtab): Make "b" const.
12191         (find_symbol_at_address): Likewise.
12192         (search_symbols): Likewise.
12193         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12194         (dw2_debug_names_lookup_symbol): Likewise.
12195         (dw2_map_matching_symbols): Update.
12196         * p-valprint.c (pascal_val_print): Remove "block".
12197         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12198         (aux_add_nonlocal_symbols): Make "block" const.
12199         (resolve_subexp): Remove cast.
12200         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12201         const.
12202         (iterate_over_file_blocks): Likewise.
12203         * f-exp.y (%union) <bval>: Remove.
12204         * coffread.c (patch_opaque_types): Make "b" const.
12205         * spu-tdep.c (spu_catch_start): Make "block" const.
12206         * c-valprint.c (print_unpacked_pointer): Remove "block".
12207         * symmisc.c (dump_symtab_1): Make "b" const.
12208         (block_depth): Make "block" const.
12209         * d-exp.y (%union) <bval>: Remove.
12210         * cp-support.h (cp_lookup_rtti_type): Update.
12211         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12212         * psymtab.c (psym_lookup_symbol): Make "block" const.
12213         (maintenance_check_psymtabs): Make "b" const.
12214         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12215         (enumerate_locals, enumerate_args): Update.
12216         * python/py-symtab.c (stpy_global_block): Make "block" const.
12217         (stpy_static_block): Likewise.
12218         * inline-frame.c (block_starting_point_at): Make "new_block"
12219         const.
12220         * block.c (find_block_in_blockvector): Make return type const.
12221         (blockvector_for_pc_sect): Make "b" const.
12222         (find_block_in_blockvector): Make "b" const.
12223
12224 2019-03-23  Tom Tromey  <tom@tromey.com>
12225
12226         * varobj.c (varobj_create): Update.
12227         * symfile.c (clear_symtab_users): Don't reset innermost_block.
12228         * printcmd.c (display_command, do_one_display): Don't reset
12229         innermost_block.
12230         * parser-defs.h (enum innermost_block_tracker_type): Move to
12231         expression.h.
12232         (innermost_block): Update comment.
12233         * parse.c (parse_exp_1): Add tracker_types parameter.
12234         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
12235         tracker_types parameter.  Reset innermost_block.
12236         (parse_exp_in_context): Remove.
12237         (parse_expression_for_completion): Update.
12238         * objfiles.c (~objfile): Don't reset expression_context_block or
12239         innermost_block.
12240         * expression.h (enum innermost_block_tracker_type): Move from
12241         parser-defs.h.
12242         (parse_exp_1): Add tracker_types parameter.
12243         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12244         reset innermost_block.
12245
12246 2019-03-23  Tom Tromey  <tom@tromey.com>
12247
12248         * objfiles.h: Include bcache.h.
12249
12250 2019-03-23  Tom Tromey  <tom@tromey.com>
12251
12252         * linespec.c (get_current_search_block): Use
12253         scoped_restore_current_language.
12254         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12255
12256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12257             Jiong Wang  <jiong.wang@arm.com>
12258
12259         * aarch64-linux-tdep.c
12260         (aarch64_linux_iterate_over_regset_sections): Check for pauth
12261         section.
12262         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12263
12264 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12265             Jiong Wang  <jiong.wang@arm.com>
12266
12267         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12268         instructions.
12269         (aarch64_analyze_prologue_test): Add PACIASP test.
12270         (aarch64_prologue_prev_register): Unmask PC value.
12271
12272 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12273             Jiong Wang  <jiong.wang@arm.com>
12274
12275         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12276         (aarch64_dwarf2_prev_register): Unmask PC value.
12277         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12278         (aarch64_execute_dwarf_cfa_vendor_op): Check for
12279         DW_CFA_AARCH64_negate_ra_state.
12280         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12281
12282 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12283             Jiong Wang  <jiong.wang@arm.com>
12284
12285         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12286         registers.
12287         (aarch64_pseudo_register_name): Likewise.
12288         (aarch64_pseudo_register_type): Likewise.
12289         (aarch64_pseudo_register_reggroup_p): Likewise.
12290         (aarch64_gdbarch_init): Add pauth registers.
12291         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12292         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12293         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12294         (struct gdbarch_tdep): Add regnum for ra_state.
12295
12296 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12297             Jiong Wang  <jiong.wang@arm.com>
12298
12299         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12300
12301 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12302             Jiong Wang  <jiong.wang@arm.com>
12303
12304         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12305         function.
12306         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12307         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12308         (aarch64_gdbarch_init): Add puth registers.
12309         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12310         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12311         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12312
12313 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12314             Jiong Wang  <jiong.wang@arm.com>
12315
12316         * aarch64-linux-nat.c
12317         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12318         * aarch64-linux-tdep.c
12319         (aarch64_linux_core_read_description): Likewise.
12320         (aarch64_linux_get_hwcap): New function.
12321         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12322         (aarch64_linux_get_hwcap): New declaration.
12323
12324 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
12325             Jiong Wang  <jiong.wang@arm.com>
12326
12327         * aarch64-linux-nat.c
12328         (aarch64_linux_nat_target::read_description): Add pauth param.
12329         * aarch64-linux-tdep.c
12330         (aarch64_linux_core_read_description): Likewise.
12331         * aarch64-tdep.c (struct target_desc): Add in pauth.
12332         (aarch64_read_description): Add pauth param.
12333         (aarch64_gdbarch_init): Likewise.
12334         * aarch64-tdep.h (aarch64_read_description): Likewise.
12335         * arch/aarch64.c (aarch64_create_target_description): Likewise.
12336         * arch/aarch64.h (aarch64_create_target_description): Likewise.
12337         * features/Makefile: Add new files.
12338         * features/aarch64-pauth.c: New file.
12339         * features/aarch64-pauth.xml: New file.
12340
12341 2019-03-20  Tom Tromey  <tromey@adacore.com>
12342
12343         * infrun.c (handle_inferior_event): Rename from
12344         handle_inferior_event_1.  Create a scoped_value_mark.
12345         (handle_inferior_event): Remove.
12346
12347 2019-03-19  Tom Tromey  <tromey@adacore.com>
12348
12349         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12350         * infrun.h (print_stop_event): Add "displays" parameter.
12351         * infrun.c (print_stop_event): Add "displays" parameter.
12352
12353 2019-03-19  Pedro Alves  <palves@redhat.com>
12354
12355         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12356         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
12357         to -1.  Fix TABs vs spaces.
12358         (tui_ui_out::tui_ui_out): Don't initialize fields here.
12359         * tui/tui-out.h (tui_ui_out) Add intro comments.
12360         <m_line, m_start_of_line>: In-class initialize, and add describing
12361         comment.
12362
12363 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
12364
12365         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12366         variable names.
12367         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12368
12369 2019-03-18  Pedro Alves  <palves@redhat.com>
12370             Eli Zaretskii <eliz@gnu.org>
12371
12372         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12373         m_line and m_start_of_line.
12374
12375 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
12376
12377         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12378         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12379         it returns a newline.  This fixes a regression in TU mode, whereby
12380         the next line is output on the same screen line as the user input.
12381
12382 2019-03-18  Tom Tromey  <tromey@adacore.com>
12383
12384         * minsyms.c (minimal_symbol_reader::install): Remove call to
12385         obstack_blank.
12386
12387 2019-03-18  Pedro Alves  <palves@redhat.com>
12388
12389         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12390         New globals.
12391         (apply_style): New, factored out from ...
12392         (apply_ansi_escape): ... this.  Handle reverse video mode.
12393         (tui_set_reverse_mode): New function.
12394         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12395         * tui/tui-winsource.c (tui_show_source_line): Use
12396         tui_set_reverse_mode instead of setting A_STANDOUT.
12397         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12398         New setter methods.
12399
12400 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
12401
12402         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12403         Handle tabs.
12404
12405 2019-03-18  Tom Tromey  <tromey@adacore.com>
12406
12407         * ada-lang.c (empty_array): Add "high" parameter.
12408         (ada_evaluate_subexp): Update.
12409
12410 2019-03-17  Sergei Trofimovich <siarheit@google.com>
12411
12412         * unittests/string_view-selftests.c: Define
12413         _initialize_string_view_selftests unconditionally.
12414
12415 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12416
12417         PR gdb/24350
12418         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12419
12420 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
12421
12422         PR gdb/24351
12423         * windows-nat.c (display_selector): Fix format specifiers.
12424
12425 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
12426
12427         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12428         tui_refill_source_window instead of tui_refresh_win, to update the
12429         current execution line.  This fixes redisplay of the current line
12430         when stepping through the code with "next" or "step".
12431
12432 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12433
12434         * source-cache.c (source_cache::get_source_lines): Call
12435         find_source_lines to initialize s->nlines.  This fixes vertical
12436         scrolling of TUI source window when the DOWN arrow is pressed.
12437
12438 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12439
12440         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12441         linux-thread-db.c (_initialize_thread_db): Likewise.
12442
12443 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
12444
12445         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12446         wclrtoeol in tui_show_source_line".  This reverts changes made in
12447         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12448
12449 2019-03-15  Tom Tromey  <tom@tromey.com>
12450
12451         * symtab.h (struct minimal_symbol): Derive from
12452         general_symbol_info.
12453         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12454         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12455         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12456         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12457         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12458         (MSYMBOL_SEARCH_NAME): Update.
12459         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12460         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12461         * minsyms.c (minimal_symbol_reader::record_full): Update.
12462
12463 2019-03-15  Tom Tromey  <tom@tromey.com>
12464
12465         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12466
12467 2019-03-15  Tom Tromey  <tom@tromey.com>
12468
12469         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12470         unique_xmalloc_ptr.
12471         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12472         Update.
12473         * minsyms.c (lookup_minimal_symbol_by_pc_section)
12474         (build_minimal_symbol_hash_tables)
12475         (minimal_symbol_reader::install): Update.
12476
12477 2019-03-15  Tom Tromey  <tom@tromey.com>
12478
12479         * symtab.c (create_demangled_names_hash): Update.
12480         (symbol_set_names): Update.
12481         * objfiles.h (struct objfile_per_bfd_storage)
12482         <demangled_names_hash>: Now an htab_up.
12483         * objfiles.c (objfile_per_bfd_storage): Simplify.
12484
12485 2019-03-15  Tom Tromey  <tom@tromey.com>
12486
12487         * objfiles.h (struct objfile_per_bfd_storage): Declare
12488         destructor.
12489         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12490         New.
12491         (get_objfile_bfd_data): Use new.  Don't initialize
12492         language_of_main.
12493         (free_objfile_per_bfd_storage): Remove.
12494         (objfile_bfd_data_free, objfile::~objfile): Use delete.
12495
12496 2019-03-15  Tom Tromey  <tom@tromey.com>
12497
12498         * symfile.c (reread_symbols): Update.
12499         * objfiles.c (objfile::objfile): Update.
12500         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12501         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12502         comment.
12503         (minimal_symbol_reader::install): Update.
12504         (terminate_minimal_symbol_table): Remove.
12505         * jit.c (jit_object_close_impl): Update.
12506
12507 2019-03-15  Tom Tromey  <tom@tromey.com>
12508
12509         * minsyms.c (minimal_symbol_reader::record_full): Remove some
12510         initializations.
12511
12512 2019-03-15  Tom Tromey  <tom@tromey.com>
12513
12514         * objfiles.h (struct objfile_per_bfd_storage)
12515         <demangled_hash_languages>: Now a bitset.
12516         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12517         (lookup_minimal_symbol): Update.
12518
12519 2019-03-15  Tom Tromey  <tom@tromey.com>
12520
12521         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12522         Don't return the symbol.
12523         * coffread.c (record_minimal_symbol): Use record_full.
12524
12525 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
12526
12527         The MS-Windows port of ncurses fails to switch to a color pair if
12528         one or both of the colors are the implicit default colors.  This
12529         change records the default colors when TUI is initialized, and
12530         then specifies them explicitly when a color pair uses the default
12531         colors.  This allows color styling in TUI mode on MS-Windows.
12532
12533         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
12534         ncurses_norm_attr.
12535         (tui_initialize_io) [__MINGW32__]: Record the default terminal
12536         colors in ncurses_norm_attr.
12537         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12538         "none", replace it with the default color recorded in
12539         ncurses_norm_attr.
12540
12541 2019-03-14  Tom Tromey  <tromey@adacore.com>
12542
12543         * source-cache.h (class source_cache) <get_source_lines>: Return
12544         std::string.
12545         * source-cache.c (source_cache::extract_lines): Handle case where
12546         first_pos==npos.  Return std::string.
12547         (source_cache::get_source_lines): Update.
12548
12549 2019-03-14  Tom Tromey  <tromey@adacore.com>
12550
12551         * NEWS: Add item for "style sources" commands.
12552         * source-cache.c (source_cache::get_source_lines): Check
12553         source_styling.
12554         * cli/cli-style.c (source_styling): New global.
12555         (_initialize_cli_style): Add "style sources" commands.
12556         (show_style_sources): New function.
12557         * cli/cli-style.h (source_styling): Declare.
12558
12559 2019-03-14  Pedro Alves  <palves@redhat.com>
12560             Tom Tromey  <tromey@adacore.com>
12561
12562         * tui/tui-winsource.h (tui_refill_source_window): Declare.
12563         * tui/tui-winsource.c (tui_refill_source_window): New function,
12564         from...
12565         (tui_horizontal_source_scroll): ... here.  Move some logic.
12566         * cli/cli-style.c (set_style_enabled): Notify new observable.
12567         * tui/tui-hooks.c (tui_redisplay_source): New function.
12568         (tui_attach_detach_observers): Attach or detach
12569         tui_redisplay_source.
12570         * observable.h (source_styling_changed): New observable.
12571         * observable.c: Define source_styling_changed observable.
12572
12573 2019-03-13  Tom Tromey  <tromey@adacore.com>
12574
12575         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12576         (i386_gnu_nat_target::store_registers): Update.
12577         * target-debug.h (target_debug_print_std_string): New macro.
12578         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12579         * windows-tdep.c (display_one_tib): Update.
12580         * tui/tui-stack.c (tui_make_status_line): Update.
12581         * top.c (print_inferior_quit_action): Update.
12582         * thread.c (thr_try_catch_cmd): Update.
12583         (add_thread_with_info): Update.
12584         (thread_target_id_str): Update.
12585         (thr_try_catch_cmd): Update.
12586         (thread_command): Update.
12587         (thread_find_command): Update.
12588         * record-btrace.c (record_btrace_target::info_record)
12589         (record_btrace_resume_thread, record_btrace_target::resume)
12590         (record_btrace_cancel_resume, record_btrace_step_thread)
12591         (record_btrace_target::wait, record_btrace_target::wait)
12592         (record_btrace_target::wait, record_btrace_target::stop): Update.
12593         * progspace.c (print_program_space): Update.
12594         * process-stratum-target.c
12595         (process_stratum_target::thread_address_space): Update.
12596         * linux-fork.c (linux_fork_mourn_inferior)
12597         (detach_checkpoint_command, info_checkpoints_command)
12598         (linux_fork_context): Update.
12599         (linux_fork_detach): Update.
12600         (class scoped_switch_fork_info): Update.
12601         (delete_checkpoint_command): Update.
12602         * infrun.c (follow_fork_inferior): Update.
12603         (follow_fork_inferior): Update.
12604         (proceed_after_vfork_done): Update.
12605         (handle_vfork_child_exec_or_exit): Update.
12606         (follow_exec): Update.
12607         (displaced_step_prepare_throw): Update.
12608         (displaced_step_restore): Update.
12609         (start_step_over): Update.
12610         (resume_1): Update.
12611         (clear_proceed_status_thread): Update.
12612         (proceed): Update.
12613         (print_target_wait_results): Update.
12614         (do_target_wait): Update.
12615         (context_switch): Update.
12616         (stop_all_threads): Update.
12617         (restart_threads): Update.
12618         (finish_step_over): Update.
12619         (handle_signal_stop): Update.
12620         (switch_back_to_stepped_thread): Update.
12621         (keep_going_pass_signal): Update.
12622         (print_exited_reason): Update.
12623         (normal_stop): Update.
12624         * inferior.c (inferior_pid_to_str): Change return type.
12625         (print_selected_inferior): Update.
12626         (add_inferior): Update.
12627         (detach_inferior): Update.
12628         * dummy-frame.c (fprint_dummy_frames): Update.
12629         * dcache.c (dcache_info_1): Update.
12630         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12631         (btrace_fetch, btrace_clear): Update.
12632         * linux-tdep.c (linux_core_pid_to_str): Change return type.
12633         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12634         type.
12635         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12636         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12637         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12638         * gdbarch.c, gdbarch.h: Rebuild.
12639         * gdbarch.sh (core_pid_to_str): Change return type.
12640         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12641         return type.
12642         (windows_nat_target::pid_to_str): Change return type.
12643         (windows_delete_thread): Update.
12644         (windows_nat_target::attach): Update.
12645         (windows_nat_target::files_info): Update.
12646         * target-delegates.c: Rebuild.
12647         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12648         return type.
12649         (sol_thread_target::pid_to_str): Change return type.
12650         * remote.c (class remote_target) <pid_to_str>: Change return
12651         type.
12652         (remote_target::pid_to_str): Change return type.
12653         (extended_remote_target::attach, remote_target::remote_stop_ns)
12654         (remote_target::remote_notif_remove_queued_reply)
12655         (remote_target::push_stop_reply, remote_target::disable_btrace):
12656         Update.
12657         (extended_remote_target::attach): Update.
12658         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12659         type.
12660         (gdbsim_target::pid_to_str): Change return type.
12661         * ravenscar-thread.c (struct ravenscar_thread_target)
12662         <pid_to_str>: Change return type.
12663         (ravenscar_thread_target::pid_to_str): Change return type.
12664         * procfs.c (class procfs_target) <pid_to_str>: Change return
12665         type.
12666         (procfs_target::pid_to_str): Change return type.
12667         (procfs_target::attach): Update.
12668         (procfs_target::detach): Update.
12669         (procfs_target::fetch_registers): Update.
12670         (procfs_target::store_registers): Update.
12671         (procfs_target::wait): Update.
12672         (procfs_target::files_info): Update.
12673         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12674         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12675         return type.
12676         (nto_procfs_target::pid_to_str): Change return type.
12677         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12678         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12679         return type.
12680         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12681         (exit_lwp): Update.
12682         (attach_proc_task_lwp_callback, get_detach_signal)
12683         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12684         (linux_nat_target::resume, wait_lwp, stop_callback)
12685         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
12686         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
12687         (linux_nat_wait_1, resume_stopped_resumed_lwps)
12688         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
12689         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
12690         type.
12691         (inf_ptrace_target::attach): Update.
12692         (inf_ptrace_target::files_info): Update.
12693         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
12694         type.
12695         (go32_nat_target::pid_to_str): Change return type.
12696         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
12697         (gnu_nat_target::wait): Update.
12698         (gnu_nat_target::wait): Update.
12699         (gnu_nat_target::resume): Update.
12700         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
12701         (fbsd_nat_target::wait): Update.
12702         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
12703         type.
12704         (darwin_nat_target::attach): Update.
12705         * corelow.c (class core_target) <pid_to_str>: Change return type.
12706         (core_target::pid_to_str): Change return type.
12707         * target.c (normal_pid_to_str): Change return type.
12708         (default_pid_to_str): Likewise.
12709         (target_pid_to_str): Change return type.
12710         (target_translate_tls_address): Update.
12711         (target_announce_detach): Update.
12712         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
12713         return type.
12714         (bsd_uthread_target::pid_to_str): Change return type.
12715         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
12716         type.
12717         (bsd_kvm_target::pid_to_str): Change return type.
12718         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
12719         return type.
12720         (aix_thread_target::pid_to_str): Change return type.
12721         * target.h (struct target_ops) <pid_to_str>: Change return type.
12722         (target_pid_to_str, normal_pid_to_str): Likewise.
12723         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
12724         type.
12725         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
12726         type.
12727         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
12728         return type.
12729         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
12730         type.
12731         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
12732         type.
12733         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
12734         return type.
12735
12736 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
12737
12738         * NEWS: Mention that the new default MI version is 3.  Mention
12739         changes to the output of commands and events that deal with
12740         multi-location breakpoints.
12741         * breakpoint.c: Include "mi/mi-out.h".
12742         (print_one_breakpoint): Change output syntax if using MI version
12743         >= 3.
12744         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
12745         New.
12746         (mi_multi_location_breakpoint_output_fixed): New.
12747         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
12748         (mi_cmd_fix_multi_location_breakpoint_output): New.
12749         (mi_multi_location_breakpoint_output_fixed): New.
12750         * mi/mi-cmds.c (mi_cmds): Register command
12751         -fix-multi-location-breakpoint-output.
12752         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
12753         interpreter "mi".
12754
12755 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
12756
12757         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
12758         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
12759         instantiate mi_ui_out based on interpreter name.
12760         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
12761         * mi/mi-main.c (mi_load_progress): Likewise.
12762
12763 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12764
12765         * NEWS: Combine separate "New targets" sections for 8.3.
12766
12767 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12768
12769         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
12770         (ppcfbsd_init_abi): Install gdbarch
12771         "fetch_tls_load_module_address" and "get_thread_local_address"
12772         methods.
12773
12774 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12775
12776         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
12777         (riscv_fbsd_init_abi): Install gdbarch
12778         "fetch_tls_load_module_address" and "get_thread_local_address"
12779         methods.
12780
12781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12782
12783         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
12784         (i386fbsd_init_abi): Install gdbarch
12785         "fetch_tls_load_module_address" and "get_thread_local_address"
12786         methods.
12787
12788 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12789
12790         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
12791         (amd64fbsd_init_abi): Install gdbarch
12792         "fetch_tls_load_module_address" and "get_thread_local_address"
12793         methods.
12794
12795 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12796
12797         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
12798         (struct fbsd_pspace_data): New type.
12799         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
12800         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
12801         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
12802         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
12803         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
12804
12805 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12806
12807         * gdbtypes.c (lookup_struct_elt): New function.
12808         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
12809         * gdbtypes.h (struct struct_elt): New type.
12810         (lookup_struct_elt): New prototype.
12811
12812 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12813
12814         * gdbtypes.c (lookup_struct_elt_type): Update comment and
12815         remove disabled code block.
12816
12817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12818
12819         * gdbarch.sh (get_thread_local_address): New method.
12820         * gdbarch.h, gdbarch.c: Regenerate.
12821         * target.c (target_translate_tls_address): Use
12822         gdbarch_get_thread_local_address if present instead of
12823         target::get_thread_local_address.
12824
12825 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12826
12827         * target.h (target::get_thread_local_address): Update comment.
12828
12829 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12830
12831         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
12832         objfile->separate_debug_objfile_backlink if not NULL.
12833
12834 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12835
12836         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
12837         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
12838         (amd64bsd_store_inferior_registers): Likewise.
12839         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12840         Enable segment base registers.
12841         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
12842         PT_GETFSBASE and PT_GETGSBASE.
12843         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
12844         PT_SETGSBASE.
12845         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
12846         segment base registers.
12847         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12848
12849 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
12850
12851         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
12852         Update calls to i386_target_description to add 'segments'
12853         parameter.
12854         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
12855         add segment base registers.
12856         * arch/i386.c (i386_create_target_description): Add 'segments'
12857         parameter to enable segment base registers.
12858         * arch/i386.h (i386_create_target_description): Likewise.
12859         * features/i386/32bit-segments.xml: New file.
12860         * features/i386/32bit-segments.c: Generate.
12861         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
12862         call to i386_target_description to add 'segments' parameter.
12863         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
12864         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
12865         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
12866         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
12867         if feature is present.
12868         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
12869         Add 'segments' parameter to call to i386_target_description.
12870         (i386_target_description): Add 'segments' parameter to enable
12871         segment base registers.
12872         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
12873         to call to i386_target_description.
12874         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
12875         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
12876         Define I386_NUM_REGS.
12877         (i386_target_description): Add 'segments' parameter to enable
12878         segment base registers.
12879
12880 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
12881
12882         PR/24325
12883         * source-cache.c: #undef open and close, to avoid unresolved
12884         externals during linking.
12885
12886 2019-03-12  Tom Tromey  <tromey@adacore.com>
12887
12888         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
12889         const.  Add initializers.
12890         (_initialize_remote): Don't initialize ptid globals.
12891
12892 2019-03-12  Pedro Alves  <palves@redhat.com>
12893
12894         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
12895
12896 2019-03-12  Pedro Alves  <palves@redhat.com>
12897
12898         * cp-name-parser.y (main): Remove unused 'len' variable.
12899
12900 2019-03-12  Tom Tromey  <tromey@adacore.com>
12901
12902         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
12903         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
12904
12905 2019-03-12  Tom Tromey  <tromey@adacore.com>
12906
12907         * linux-nat.c (iterate_over_lwps): Update.
12908         (stop_callback): Remove parameter.
12909         (stop_wait_callback, detach_callback, resume_set_callback)
12910         (select_singlestep_lwp_callback, set_ignore_sigint)
12911         (status_callback, resumed_callback, resume_clear_callback)
12912         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
12913         data parameter.
12914         (linux_nat_target::detach, linux_nat_target::resume)
12915         (linux_stop_and_wait_all_lwps, select_event_lwp)
12916         (linux_nat_filter_event, linux_nat_wait_1)
12917         (linux_nat_target::kill, linux_nat_target::stop)
12918         (linux_nat_target::stop): Update.
12919         (linux_nat_resume_callback): Change type.
12920         (resume_stopped_resumed_lwps, count_events_callback)
12921         (select_event_lwp_callback): Likewise.
12922         (linux_stop_lwp, linux_nat_stop_lwp): Update.
12923         * arm-linux-nat.c (struct update_registers_data): Remove.
12924         (update_registers_callback): Change type.
12925         (arm_linux_insert_hw_breakpoint1): Update.
12926         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
12927         parameter.
12928         (x86_linux_dr_set_addr): Update.
12929         (x86_linux_dr_set_control): Update.
12930         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
12931         (iterate_over_lwps): Use gdb::function_view.
12932         * nat/aarch64-linux-hw-point.c (struct
12933         aarch64_dr_update_callback_param): Remove.
12934         (debug_reg_change_callback): Change type.
12935         (aarch64_notify_debug_reg_change): Update.
12936         * s390-linux-nat.c (s390_refresh_per_info): Update.
12937
12938 2019-03-11  Tom Tromey  <tromey@adacore.com>
12939
12940         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
12941         redundant assignment to "this_cu".
12942
12943 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12944
12945         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
12946
12947 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12948
12949         * gdbtypes.c (rank_one_type_parm_set): New function extracted
12950         from...
12951         (rank_one_type): ... this.
12952
12953 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12954
12955         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
12956         from...
12957         (rank_one_type): ... this.
12958
12959 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12960
12961         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
12962         from...
12963         (rank_one_type): ... this.
12964
12965 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12966
12967         * gdbtypes.c (rank_one_type_parm_float): New function extracted
12968         from...
12969         (rank_one_type): ... this.
12970
12971 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12972
12973         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
12974         from...
12975         (rank_one_type): ... this.
12976
12977 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12978
12979         * gdbtypes.c (rank_one_type_parm_range): New function extracted
12980         from...
12981         (rank_one_type): ... this.
12982
12983 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12984
12985         * gdbtypes.c (rank_one_type_parm_char): New function extracted
12986         from...
12987         (rank_one_type): ... this.
12988
12989 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12990
12991         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
12992         from...
12993         (rank_one_type): ... this.
12994
12995 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
12996
12997         * gdbtypes.c (rank_one_type_parm_int): New function extracted
12998         from...
12999         (rank_one_type): ... this.
13000
13001 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13002
13003         * gdbtypes.c (rank_one_type_parm_func): New function extracted
13004         from...
13005         (rank_one_type): ... this.
13006
13007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13008
13009         * gdbtypes.c (rank_one_type_parm_array): New function extracted
13010         from...
13011         (rank_one_type): ... this.
13012
13013 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
13014
13015         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13016         from...
13017         (rank_one_type): ... this.
13018
13019 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13020
13021         * inferior.c (initialize_inferiors): Ensure 'help set/show print
13022         inferior-events' shows the example events.
13023
13024 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
13025
13026         Support styling on native MS-Windows console
13027
13028         PR/24315
13029         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13030         on MS-Windows if $TERM is not defined.
13031
13032         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13033
13034         * posix-hdep.c (gdb_console_fputs):
13035         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13036         functions.
13037         * ui-file.h (gdb_console_fputs): Add prototype.
13038
13039         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13040         back to fputs only if the former returns zero.
13041
13042 2019-03-07  Tom Tromey  <tom@tromey.com>
13043
13044         * symmisc.c (print_symbol_bcache_statistics): Update.
13045         (print_objfile_statistics): Update.
13046         * symfile.c (allocate_symtab): Update.
13047         * stabsread.c: Don't include bcache.h.
13048         * psymtab.h (struct psymbol_bcache): Don't declare.
13049         (class psymtab_storage) <psymbol_cache>: Now a bcache.
13050         (psymbol_bcache_init, psymbol_bcache_free)
13051         (psymbol_bcache_get_bcache): Don't declare.
13052         * psymtab.c (struct psymbol_bcache): Remove.
13053         (psymtab_storage::psymtab_storage): Update.
13054         (psymtab_storage::~psymtab_storage): Update.
13055         (psymbol_bcache_init, psymbol_bcache_free)
13056         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13057         (add_psymbol_to_bcache): Update.
13058         (allocate_psymtab): Update.
13059         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13060         macro_cache>: No longer pointers.
13061         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13062         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13063         * macrotab.c (macro_bcache): Update.
13064         * macroexp.c: Don't include bcache.h.
13065         * gdbtypes.c (check_types_worklist): Update.
13066         (types_deeply_equal): Remove TRY/CATCH.  Update.
13067         * elfread.c (elf_symtab_read): Update.
13068         * dwarf2read.c: Don't include bcache.h.
13069         * buildsym.c (buildsym_compunit::get_macro_table): Update.
13070         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13071         (print_bcache_statistics, bcache_memory_used): Don't declare.
13072         (struct bcache): Move from bcache.c.  Add constructor, destructor,
13073         methods.  Rename all data members.
13074         * bcache.c (struct bcache): Move to bcache.h.
13075         (bcache::expand_hash_table): Rename from expand_hash_table.
13076         (bcache): Remove.
13077         (bcache::insert): Rename from bcache_full.
13078         (bcache::compare): Rename from bcache_compare.
13079         (bcache_xmalloc): Remove.
13080         (bcache::~bcache): Rename from bcache_xfree.
13081         (bcache::print_statistics): Rename from print_bcache_statistics.
13082         (bcache::memory_used): Rename from bcache_memory_used.
13083
13084 2019-03-07  Pedro Alves  <palves@redhat.com>
13085
13086         * infrun.c (normal_stop): Also check for
13087         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13088
13089 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
13090
13091         * f-lang.c (value_from_host_double): Moved to...
13092         * value.c (value_from_host_double): ...here.
13093         * value.h (value_from_host_double): Declare.
13094         * guile/scm-math.c (vlscm_convert_typed_number): Use
13095         value_from_host_double.
13096         (vlscm_convert_number): Likewise.
13097         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13098         * python/py-value.c (convert_value_from_python): Likewise.
13099
13100 2019-03-06  Tom Tromey  <tom@tromey.com>
13101
13102         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13103
13104 2019-03-06  Tom Tromey  <tom@tromey.com>
13105
13106         * utils.h (free_current_contents): Don't declare.
13107         * utils.c (free_current_contents): Remove.
13108
13109 2019-03-06  Tom Tromey  <tom@tromey.com>
13110
13111         * top.c (quit_force): Update.
13112         * main.c (captured_command_loop): Update.
13113         * common/new-op.c (operator new): Update.
13114         * common/common-exceptions.c (struct catcher)
13115         <save_cleanup_chain>: Remove member.
13116         (exceptions_state_mc_init): Update.
13117         (exception_try_scope_entry): Return nullptr.
13118         (exception_try_scope_exit, exception_rethrow)
13119         (throw_exception_sjlj, throw_exception_cxx): Update.
13120         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13121         (all_cleanups, do_cleanups, discard_cleanups)
13122         (discard_final_cleanups, save_cleanups, save_final_cleanups)
13123         (restore_cleanups, restore_final_cleanups): Don't declare.
13124         (do_final_cleanups): Remove parameter.
13125         * common/cleanups.c (cleanup_chain, make_cleanup)
13126         (make_cleanup_dtor, all_cleanups, do_cleanups)
13127         (discard_my_cleanups, discard_cleanups)
13128         (discard_final_cleanups, save_my_cleanups, save_cleanups)
13129         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13130         (null_cleanup): Remove.
13131         (do_final_cleanups): Remove parameter.
13132
13133 2019-03-06  Tom Tromey  <tom@tromey.com>
13134
13135         * remote.c (remote_target::remote_parse_stop_reply): Use
13136         unique_xmalloc_ptr.
13137
13138 2019-03-06  Tom Tromey  <tom@tromey.com>
13139
13140         * stabsread.c (struct stabs_field_info): Rename from field_info.
13141         <list, fnlist>: Add initializers.
13142         <obstack>: New member.
13143         (read_member_functions, read_struct_fields, read_baseclasses):
13144         Allocate on obstack.  Don't use cleanups.
13145         (read_one_struct_field, read_member_functions, read_struct_fields)
13146         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13147         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13148         (read_struct_type): Update.
13149
13150 2019-03-06  Tom Tromey  <tom@tromey.com>
13151
13152         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13153         * common/filestuff.h (make_cleanup_close): Don't declare.
13154         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13155         Remove.
13156
13157 2019-03-06  Tom Tromey  <tom@tromey.com>
13158
13159         * solib-aix.c: Use make_scope_exit.
13160
13161 2019-03-06  Tom Tromey  <tom@tromey.com>
13162
13163         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13164         Use make_scope_exit.
13165
13166 2019-03-06  Tom Tromey  <tom@tromey.com>
13167
13168         * solib-svr4.c (disable_probes_interface): Remove parameter.
13169         (svr4_handle_solib_event): Use make_scope_exit.
13170
13171 2019-03-06  Tom Tromey  <tom@tromey.com>
13172
13173         * remote.c (struct stop_reply_deleter): Remove.
13174         (stop_reply_up): Update.
13175         (struct stop_reply): Derive from notif_event.  Don't typedef.
13176         <regcache>: Now a std::vector.
13177         (stop_reply_xfree): Remove.
13178         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13179         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
13180         (remote_target::discard_pending_stop_replies): Use delete.
13181         (remote_target::remote_parse_stop_reply): Update.
13182         (remote_target::process_stop_reply): Update.
13183         * remote-notif.h (struct notif_event): Add virtual destructor.
13184         Remove "dtr" member.
13185         (struct notif_client) <alloc_event>: Return a unique_ptr.
13186         (notif_event_xfree): Don't declare.
13187         (notif_event_up): New typedef.
13188         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13189         (notif_event_xfree, do_notif_event_xfree): Remove.
13190         (remote_notif_state_xfree): Update.
13191
13192 2019-03-06  Tom Tromey  <tom@tromey.com>
13193
13194         * infrun.c (displaced_step_clear_cleanup): Now a
13195         forward_scope_exit type.
13196         (displaced_step_prepare_throw): Update.
13197         (displaced_step_fixup): Update.
13198
13199 2019-03-06  Tom Tromey  <tom@tromey.com>
13200
13201         * inferior.h (class inferior): Update comment.
13202         * gdbthread.h (class thread_info): Update comment.
13203
13204 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
13205             Tom Tromey  <tom@tromey.com>
13206
13207         * stabsread.h (struct stab_section_list): Remove.
13208         (coffstab_build_psymtabs): Update.
13209         * dbxread.c (symbuf_sections): Now a std::vector.
13210         (sect_idx): New global.
13211         (fill_symbuf): Update.
13212         (coffstab_build_psymtabs): Change type of stabsects parameter.
13213         Update.
13214         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13215         std::vector.
13216         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13217         (coff_locate_sections): Update.
13218         (coff_symfile_read): Remove cleanups.  Update.
13219         (init_stringtab): Add storage parameter.
13220         (free_stringtab, free_stringtab_cleanup): Remove.
13221         (init_lineno): Add storage parameter.
13222         (free_linetab, free_linetab_cleanup): Remove.
13223
13224 2019-03-06  Pedro Alves  <palves@redhat.com>
13225
13226         * linux-fork.c (fork_info::clobber_regs): Delete.
13227         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13228         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
13229         comment.  Adjust.
13230         (scoped_switch_fork_info::scoped_switch_fork_info)
13231         (checkpoint_command, linux_fork_context): Adjust
13232         fork_save_infrun_state calls.
13233
13234 2019-03-06  Pedro Alves  <palves@redhat.com>
13235
13236         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13237         (inf_has_multiple_threads): Return 'bool' and rewrite using
13238         inferior_info::threads().
13239
13240 2019-03-06  Pedro Alves  <palves@redhat.com>
13241
13242         * linux-fork.c: Include <list>.
13243         (fork_list): Now a std::list instance.
13244         (fork_info): Add ctor, dtor, and in-class initialize all fields.
13245         (forks_exist_p, find_last_fork): Adjust.
13246         (new_fork): Delete.
13247         (one_fork_p): New.
13248         (add_fork): Adjust.
13249         (free_fork): Delete, folded into fork_info::~fork_info().
13250         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13251         Adjust.
13252         (init_fork_list): Delete.
13253         (linux_fork_killall, linux_fork_mourn_inferior)
13254         (linux_fork_detach, info_checkpoints_command): Adjust.
13255         (_initialize_linux_fork): No longer call init_fork_list.
13256
13257 2019-03-06  Pedro Alves  <palves@redhat.com>
13258
13259         * linux-fork.c (new_fork): New, split out of ...
13260         (add_fork): ... this.  Return void.  Move "first fork" special
13261         case from here, to ...
13262         (checkpoint_command): ... here.
13263         * linux-linux.h (add_fork): Return void.
13264
13265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13266
13267         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13268
13269 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13270             Chris January  <chris.january@arm.com>
13271             David Lecomber  <david.lecomber@arm.com>
13272
13273         * f-exp.y: New token, UNOP_INTRINSIC.
13274         (exp): New pattern using UNOP_INTRINSIC token.
13275         (f77_keywords): Add 'abs' keyword.
13276         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13277         (value_from_host_double): New function.
13278         (evaluate_subexp_f): Support UNOP_ABS.
13279
13280 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13281
13282         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13283         types.
13284
13285 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13286
13287         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13288         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13289         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13290
13291 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13292
13293         * f-exp.y (convert_to_kind_type): Handle more type kinds.
13294
13295 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13296             Chris January  <chris.january@arm.com>
13297
13298         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13299         * f-exp.y: Define 'KIND' token.
13300         (exp): New pattern for KIND expressions.
13301         (ptype): Handle types with a kind extension.
13302         (direct_abs_decl): Extend to spot kind extensions.
13303         (f77_keywords): Add 'kind' to the list.
13304         (push_kind_type): New function.
13305         (convert_to_kind_type): New function.
13306         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13307         * parse.c (operator_length_standard): Likewise.
13308         * parser-defs.h (enum type_pieces): Add tp_kind.
13309         * std-operator.def: Add UNOP_KIND.
13310
13311 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13312
13313         * f-exp.y (f_parse): Set yydebug.
13314
13315 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13316
13317         * f-lang.c (evaluate_subexp_f): New function.
13318         (exp_descriptor_f): New global.
13319         (f_language_defn): Use exp_descriptor_f instead of
13320         exp_descriptor_standard.
13321
13322 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13323
13324         * f-exp.y (struct token): Add comments.
13325         (dot_ops): Remove uppercase versions and the end marker.
13326         (f77_keywords): Likewise.
13327         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13328         entries in the dot_ops array are case insensitive, and use
13329         strncasecmp to compare strings.  Also some whitespace cleanup in
13330         this area.  Similar for the f77_keywords array, except entries in
13331         this list might be case sensitive.
13332
13333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
13334
13335         * f-exp.y (struct f77_boolean_val): Add comments.
13336         (boolean_values): Remove uppercase versions, and end marker.
13337         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13338         and use strncasecmp to achieve case insensitivity.  Additionally,
13339         perform whitespace cleanup around this code.
13340
13341 2019-03-06  Tom Tromey  <tromey@adacore.com>
13342
13343         * remote-sim.c (gdbsim_target_open): Use result of
13344         gdb_argv::release.
13345
13346 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
13347         Dirk Schubert  <dirk.schubert@arm.com>
13348         Chris January  <chris.january@arm.com>
13349
13350         * eval.c (evaluate_subexp_standard): Call Fortran argument
13351         wrapping logic.
13352         * f-lang.c (struct value): A value which can be passed into a
13353         Fortran function call.
13354         (fortran_argument_convert): Wrap Fortran arguments in a pointer
13355         where appropriate.
13356         (struct type): Value ready for a Fortran function call.
13357         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13358         is needed.
13359         * f-lang.h (fortran_argument_convert): Declaration.
13360         (fortran_preserve_arg_pointer): Declaration.
13361         * infcall.c (value_arg_coerce): Call Fortran argument logic.
13362
13363 2019-03-05  Tom Tromey  <tromey@adacore.com>
13364
13365         * python/py-prettyprint.c (print_string_repr): Remove #if.
13366         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13367
13368 2019-03-05  Tom Tromey  <tromey@adacore.com>
13369
13370         * target.c (the_dummy_target): Move later.  Change type to
13371         "dummy_target".
13372         (initialize_targets): Don't initialize the_dummy_target.
13373
13374 2019-03-05  Tom Tromey  <tromey@adacore.com>
13375
13376         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13377         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13378
13379 2019-03-05  Tom Tromey  <tromey@adacore.com>
13380
13381         * windows-nat.c (windows_nat_target::attach)
13382         (windows_nat_target::detach): Don't call gdb_flush.
13383         * valprint.c (generic_val_print, val_print, val_print_string):
13384         Don't call gdb_flush.
13385         * utils.c (defaulted_query): Don't call gdb_flush.
13386         * typeprint.c (print_type_scalar): Don't call gdb_flush.
13387         * target.c (target_announce_detach): Don't call gdb_flush.
13388         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13389         * remote.c (extended_remote_target::attach): Don't call
13390         gdb_flush.
13391         * procfs.c (procfs_target::detach): Don't call gdb_flush.
13392         * printcmd.c (do_examine): Don't call gdb_flush.
13393         (info_display_command): Don't call gdb_flush.
13394         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13395         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13396         * memattr.c (info_mem_command): Don't call gdb_flush.
13397         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13398         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13399         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13400         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13401         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13402         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13403         (gnu_nat_target::detach): Don't call gdb_flush.
13404         * f-valprint.c (f_val_print): Don't call gdb_flush.
13405         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13406         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13407         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13408         gdb_flush.
13409         * c-valprint.c (c_val_print): Don't call gdb_flush.
13410         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13411
13412 2019-03-05  Tom Tromey  <tromey@adacore.com>
13413
13414         * varobj.c (update_dynamic_varobj_children): Update.
13415         (install_default_visualizer): Use reset, not release.
13416         * value.c (set_internalvar): Update.
13417         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13418         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13419         ATTRIBUTE_UNUSED_RESULT.
13420
13421 2019-03-05  Tom Tromey  <tromey@adacore.com>
13422
13423         * remote.c (class scoped_remote_fd) <release>: Add
13424         ATTRIBUTE_UNUSED_RESULT.
13425
13426 2019-03-05  Tom Tromey  <tromey@adacore.com>
13427
13428         * macroexp.c (struct macro_buffer) <release>: Add
13429         ATTRIBUTE_UNUSED_RESULT.
13430
13431 2019-03-05  Tom Tromey  <tromey@adacore.com>
13432
13433         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13434         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13435         ATTRIBUTE_UNUSED_RESULT.
13436
13437 2019-03-05  Tom Tromey  <tromey@adacore.com>
13438
13439         * common/scoped_fd.h (class scoped_fd) <release>: Add
13440         ATTRIBUTE_UNUSED_RESULT.
13441
13442 2019-03-05  Tom Tromey  <tromey@adacore.com>
13443
13444         * parser-defs.h (struct parser_state) <release>: Add
13445         ATTRIBUTE_UNUSED_RESULT.
13446
13447 2019-03-05  Tom Tromey  <tromey@adacore.com>
13448
13449         * utils.h (class gdb_argv) <release>: Add
13450         ATTRIBUTE_UNUSED_RESULT.
13451         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13452
13453 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
13454
13455         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13456         for-loop range, to avoid compiler warnings.
13457
13458         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13459         avoid compiler warnings about unused variables.
13460
13461         * NEWS: Mention end of support for native debugging on MS-Windows
13462         before XP.
13463
13464         PR gdb/24292
13465         * common/netstuff.c:
13466         * gdbserver/gdbreplay.c
13467         * gdbserver/remote-utils.c:
13468         * ser-tcp.c:
13469         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13470         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
13471         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13472         'getaddrinfo' and 'freeaddrinfo' were not available before
13473         Windows XP, and mingw.org's MinGW headers by default define
13474         _WIN32_WINNT to 0x500.
13475
13476 2019-03-01  Gary Benson <gbenson@redhat.com>
13477
13478         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13479
13480 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
13481             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
13482
13483         PR gdb/8527
13484         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13485         set_sigint_trap, clear_sigint_trap.
13486
13487 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13488
13489         * target.c (target_detach): Clear the regcache and the
13490         frame cache.
13491
13492 2019-02-27  Pedro Alves  <palves@redhat.com>
13493
13494         * utils.c (set_screen_size): When we cap the height/width sizes,
13495         tweak the corresponding command variable to show "unlimited":
13496
13497 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
13498             Pedro Alves  <palves@redhat.com>
13499
13500         * utils.c (set_screen_size): Reduce "infinite" rows and columns
13501         before calling rl_set_screen_size.
13502
13503 2019-02-27  Tom Tromey  <tromey@adacore.com>
13504
13505         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13506         define.
13507         * python/py-value.c: Remove Python 2.4 workaround.
13508         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13509         workaround.
13510         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13511         Python 2.4 workaround.
13512         * python/python-internal.h: Remove Python 2.4 comment.
13513         (Py_ssize_t): Don't define.
13514         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13515         (gdb_Py_DECREF): Remove Python 2.4 workaround.
13516         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13517         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13518         * python/python.c (do_start_initialization): Remove Python 2.4
13519         workaround.
13520         * python/py-prettyprint.c (class dummy_python_frame): Remove.
13521         (print_children): Remove Python 2.4 workaround.
13522         * python/py-inferior.c (buffer_procs): Remove Python 2.4
13523         workaround.
13524         (CHARBUFFERPROC_NAME): Remove.
13525         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13526         Python 2.4 workaround.
13527
13528 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13529
13530         * NEWS: Note minimum Python version.
13531
13532 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
13533
13534         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13535         code from these functions.  Remove corresponding ifdefs.  Use
13536         Py_buffer_up instead of explicit calls to PyBuffer_Release.
13537         Remove gotos and target of gotos.
13538         (infpy_search_memory): Likewise.
13539
13540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13541
13542         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13543         (hppa_gdbarch_init): Don't register deleted functions with
13544         gdbarch.
13545
13546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13547
13548         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13549         (h8300_unwind_sp): Delete.
13550         (h8300_dummy_id): Delete.
13551         (h8300_gdbarch_init): Don't register deleted functions with
13552         gdbarch.
13553
13554 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13555
13556         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13557         (ft32_unwind_pc): Delete.
13558         (ft32_unwind_sp): Delete.
13559         (ft32_gdbarch_init): Don't register deleted functions with
13560         gdbarch.
13561
13562 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13563
13564         * gdb/frv-tdep.c (frv_dummy_id): Delete.
13565         (frv_unwind_pc): Delete.
13566         (frv_unwind_sp): Delete.
13567         (frv_gdbarch_init): Don't register deleted functions with
13568         gdbarch.
13569
13570 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13571
13572         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13573         (riscv_unwind_pc): Delete.
13574         (riscv_unwind_sp): Delete.
13575         (riscv_gdbarch_init): Don't register deleted functions with
13576         gdbarch.
13577
13578 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13579
13580         * gdb/csky-tdep.c (csky_dummy_id): Delete.
13581         (csky_unwind_pc): Delete.
13582         (csky_unwind_sp): Delete.
13583         (csky_gdbarch_init): Don't register deleted functions with
13584         gdbarch.
13585
13586 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13587
13588         * gdb/cris-tdep.c (cris_dummy_id): Delete.
13589         (cris_unwind_pc): Delete.
13590         (cris_unwind_sp): Delete.
13591         (cris_gdbarch_init): Don't register deleted functions with
13592         gdbarch.
13593
13594 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13595
13596         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13597         (bfin_unwind_pc): Delete.
13598         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13599
13600 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13601
13602         * gdb/arm-tdep.c (arm_dummy_id): Delete.
13603         (arm_unwind_pc): Delete.
13604         (arm_unwind_sp): Delete.
13605         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13606
13607 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13608
13609         * gdb/arc-tdep.c (arc_dummy_id): Delete.
13610         (arc_unwind_pc): Delete.
13611         (arc_unwind_sp): Delete.
13612         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13613
13614 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13615
13616         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13617         (alpha_unwind_pc): Delete.
13618         (alpha_gdbarch_init): Don't register deleted functions with
13619         gdbarch.
13620
13621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13622
13623         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13624         (aarch64_unwind_pc): Delete.
13625         (aarch64_unwind_sp): Delete.
13626         (aarch64_gdbarch_init): Don't register deleted functions with
13627         gdbarch.
13628
13629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13630
13631         * gdbtypes.c (type_align): Don't consider static members when
13632         computing structure alignment.
13633
13634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
13635
13636         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13637         return 0 for other types.
13638         * arch-utils.c (default_type_align): Always return 0.
13639         * gdbarch.h: Regenerate.
13640         * gdbarch.sh (type_align): Extend comment.
13641         * gdbtypes.c (type_align): Add additional comments, always call
13642         gdbarch_type_align before applying the default rules.
13643         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13644         generic code will then apply a suitable default.
13645         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13646         types, return 0 for other types.
13647
13648 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13649
13650         * NEWS: Create a new section for the next release branch.
13651         Rename the section of the current branch, now that it has
13652         been cut.
13653
13654 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
13655
13656         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13657         * version.in: Bump version to 8.3.50.DATE-git.
13658
13659 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
13660
13661         * aix-thread.c (ptid_cmp): Remove unused variable.
13662         (get_signaled_thread): Likewise.
13663         (store_regs_user_thread): Likewise.
13664         (store_regs_kernel_thread): Likewise.
13665         (fetch_regs_kernel_thread): Remove shadowed variable.
13666
13667 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13668
13669         * features/riscv/32bit-cpu.xml: Add register numbers.
13670         * features/riscv/32bit-fpu.c: Regenerate.
13671         * features/riscv/32bit-fpu.xml: Add register numbers.
13672         * features/riscv/64bit-cpu.xml: Add register numbers.
13673         * features/riscv/64bit-fpu.c: Regenerate.
13674         * features/riscv/64bit-fpu.xml: Add register numbers.
13675
13676 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
13677
13678         * NEWS: Mention two argument form of gdb.Value constructor.
13679         * python/py-value.c (convert_buffer_and_type_to_value): New
13680         function.
13681         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13682         Add support for handling an optional second argument.  Call
13683         convert_buffer_and_type_to_value as appropriate.
13684         * python/python-internal.h (Py_buffer_deleter): New struct.
13685         (Py_buffer_up): New typedef.
13686
13687 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
13688
13689         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
13690         instead of releasing ownership.
13691
13692 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
13693
13694         * dwarf2read.c (open_and_init_dwp_file): Call
13695         elf_numsections instead of bfd_count_sections to initialize
13696         dwp_file->num_sections.
13697
13698 2019-02-25  Tom Tromey  <tromey@adacore.com>
13699
13700         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
13701
13702 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
13703
13704         * gcore.in: Add '--readnever' option when invoking GDB.
13705
13706 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13707
13708         * MAINTAINERS: Update my email address.
13709
13710 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
13711
13712         * build-id.c (build_id_to_debug_bfd_1): New function.
13713         (build_id_to_debug_bfd): Look for separate debug file in
13714         sysroot.
13715
13716 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
13717
13718         * gdbarch.sh: Update the copyright year range that is placed into
13719         generated files.
13720
13721 2019-02-22  Keith Seitz  <keiths@redhat.com>
13722
13723         PR symtab/23853
13724         * linespec.c (create_sals_line_offset): Search for the default
13725         symtab's filename instead of its fullname.
13726
13727 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13728
13729         * NEWS: Update style defaults.
13730
13731 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
13732
13733         * main.c (captured_main_1): Disable styling in batch mode.
13734
13735 2019-02-20  Tom Tromey  <tom@tromey.com>
13736
13737         * symtab.c (symtab_symbol_info): Fix typos.
13738
13739 2019-02-20  Tom Tromey  <tromey@adacore.com>
13740
13741         * findcmd.c (_initialize_mem_search): Use upper case for
13742         metasyntactic variables.
13743
13744 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
13745
13746         * aarch64-tdep.c (aarch64_add_reggroups): New function.
13747         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
13748
13749 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
13750
13751         * top.h (source_file_name): Change to std::string.
13752         * top.c (source_file_name): Likewise.
13753         (command_line_input): Adjust.
13754         * cli/cli-script.c (script_from_file): Adjust.
13755
13756 2019-02-19  Tom Tromey  <tromey@adacore.com>
13757
13758         * ravenscar-thread.c
13759         (ravenscar_thread_target::update_thread_list): Don't call
13760         ada_build_task_list.
13761         * ada-lang.h (ada_build_task_list): Don't declare.
13762         * ada-tasks.c (struct ada_tasks_inferior_data)
13763         <task_list_valid_p>: Now bool.
13764         (read_known_tasks, ada_task_list_changed)
13765         (ada_tasks_invalidate_inferior_data): Update.
13766         (read_known_tasks_array): Return bool.
13767         (read_known_tasks_list): Likewise.
13768         (read_known_tasks): Return void.
13769         (ada_build_task_list): Now static.
13770
13771 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
13772
13773         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
13774         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
13775
13776 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13777
13778         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
13779         variant for ada_tasks_pspace_data_handle and
13780         ada_tasks_inferior_data_handle.
13781         (ada_tasks_pspace_data_cleanup): New function.
13782         (ada_tasks_inferior_data_cleanup): New function.
13783
13784 2019-02-17  Tom Tromey  <tom@tromey.com>
13785
13786         * macrotab.h (macro_source_fullname): Return a std::string.
13787         * macrotab.c (macro_include, check_for_redefinition)
13788         (macro_undef, macro_lookup_definition, foreach_macro)
13789         (foreach_macro_in_scope): Update.
13790         (macro_source_fullname): Return a std::string.
13791         * macrocmd.c (show_pp_source_pos): Update.
13792
13793 2019-02-17  Tom Tromey  <tom@tromey.com>
13794
13795         * macrocmd.c (show_pp_source_pos): Style the file names.
13796
13797 2019-02-17  Tom Tromey  <tom@tromey.com>
13798
13799         PR tui/24197:
13800         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
13801
13802 2019-02-17  Tom Tromey  <tom@tromey.com>
13803
13804         * ada-lang.c (user_select_syms): Use filtered printing.
13805         * utils.c (wrap_style): New global.
13806         (desired_style): Remove.
13807         (emit_style_escape): Add stream parameter.
13808         (set_output_style, reset_terminal_style, prompt_for_continue):
13809         Update.
13810         (flush_wrap_buffer): Only flush gdb_stdout.
13811         (wrap_here): Set wrap_style.
13812         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
13813         treat escape sequences as a character.  Change when wrap buffer is
13814         flushed.
13815         (fputs_styled): Do not set the output style when the default is
13816         requested.
13817         * ui-style.h (struct ui_file_style) <is_default>: New method.
13818         * source.c (print_source_lines_base): Emit escape sequences in one
13819         piece.
13820
13821 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13822
13823         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
13824         integers and enumeration types.
13825
13826 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
13827
13828         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
13829         instead of lookup_symbol_in_language
13830         (do_exact_match): New function.
13831         (ada_get_symbol_name_matcher): Return do_exact_match when
13832         doing a verbatim match.
13833
13834 2019-02-15  Tom Tromey  <tromey@adacore.com>
13835
13836         * ravenscar-thread.c (ravenscar_thread_target::resume)
13837         (ravenscar_thread_target::wait): Special case wildcard requests.
13838
13839 2019-02-15  Tom Tromey  <tromey@adacore.com>
13840
13841         * ravenscar-thread.c (base_ptid): Remove.
13842         (struct ravenscar_thread_target) <close>: New method.
13843         <m_base_ptid>: New member.
13844         <update_inferior_ptid, active_task, task_is_currently_active,
13845         runtime_initialized>: Declare methods.
13846         <ravenscar_thread_target>: Add constructor.
13847         (ravenscar_thread_target::task_is_currently_active)
13848         (ravenscar_thread_target::update_inferior_ptid)
13849         (ravenscar_runtime_initialized): Rename.  Now methods.
13850         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
13851         (ravenscar_thread_target::update_thread_list): Update.
13852         (ravenscar_thread_target::active_task): Now method.
13853         (ravenscar_thread_target::store_registers)
13854         (ravenscar_thread_target::prepare_to_store)
13855         (ravenscar_thread_target::prepare_to_store)
13856         (ravenscar_thread_target::mourn_inferior): Update.
13857         (ravenscar_inferior_created): Use "new" to create target.
13858         (ravenscar_thread_target::get_ada_task_ptid): Update.
13859         (_initialize_ravenscar): Don't initialize base_ptid.
13860         (ravenscar_ops): Remove global.
13861
13862 2019-02-15  Tom Tromey  <tromey@adacore.com>
13863
13864         * target.h (push_target): Declare new overload.
13865         * target.c (push_target): New overload, taking an rvalue reference.
13866         * remote.c (remote_target::open_1): Use push_target overload.
13867         * corelow.c (core_target_open): Use push_target overload.
13868
13869 2019-02-15  Tom Tromey  <tromey@adacore.com>
13870
13871         * ravenscar-thread.c (is_ravenscar_task)
13872         (ravenscar_task_is_currently_active): Return bool.
13873         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
13874         (_initialize_ravenscar): Remove "(void)".
13875         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
13876         Return bool.
13877
13878 2019-02-15  Tom Tromey  <tromey@adacore.com>
13879
13880         * ravenscar-thread.c (ravenscar_runtime_initializer)
13881         (has_ravenscar_runtime, get_running_thread_id)
13882         (ravenscar_thread_target::resume): Fix indentation.
13883
13884 2019-02-15  Tom Tromey  <tromey@adacore.com>
13885
13886         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
13887         from ravenscar_arch_ops.
13888         (sparc_ravenscar_ops::fetch_registers)
13889         (sparc_ravenscar_ops::store_registers): Now methods.
13890         (sparc_ravenscar_prepare_to_store): Remove.
13891         (sparc_ravenscar_ops): Redefine.
13892         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
13893         methods and destructor.  Remove members.
13894         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
13895         (ravenscar_thread_target::store_registers)
13896         (ravenscar_thread_target::prepare_to_store): Update.
13897         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
13898         Remove.
13899         (struct ppc_ravenscar_powerpc_ops): Derive from
13900         ravenscar_arch_ops.
13901         (ppc_ravenscar_powerpc_ops::fetch_registers)
13902         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
13903         (ppc_ravenscar_powerpc_ops): Redefine.
13904         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
13905         (ppc_ravenscar_e500_ops::fetch_registers)
13906         (ppc_ravenscar_e500_ops::store_registers): Now methods.
13907         (ppc_ravenscar_e500_ops): Redefine.
13908         * aarch64-ravenscar-thread.c
13909         (aarch64_ravenscar_generic_prepare_to_store): Remove.
13910         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
13911         (aarch64_ravenscar_fetch_registers)
13912         (aarch64_ravenscar_store_registers): Now methods.
13913         (aarch64_ravenscar_ops): Redefine.
13914
13915 2019-02-15  Tom Tromey  <tromey@adacore.com>
13916
13917         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
13918         (ravenscar_thread_target::stopped_by_hw_breakpoint)
13919         (ravenscar_thread_target::stopped_by_watchpoint)
13920         (ravenscar_thread_target::stopped_data_address)
13921         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
13922
13923 2019-02-15  Tom Tromey  <tromey@adacore.com>
13924
13925         * ravenscar-thread.c: Fix some typos.
13926
13927 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13928             Tom Tromey  <tromey@adacore.com>
13929
13930         * ada-lang.c (ada_exception_sal): Change addr_string to a
13931         std::string.
13932         (create_ada_exception_catchpoint): Update.
13933
13934 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13935             Tom Tromey  <tromey@adacore.com>
13936
13937         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
13938         (bp_location_ops): Remove.
13939         (base_breakpoint_allocate_location): Update.
13940         (free_bp_location): Update.
13941         * ada-lang.c (class ada_catchpoint_location)
13942         <ada_catchpoint_location>: Remove ops parameter.
13943         (ada_catchpoint_location_dtor): Remove.
13944         (ada_catchpoint_location_ops): Remove.
13945         (allocate_location_exception): Update.
13946         * breakpoint.h (struct bp_location_ops): Remove.
13947         (class bp_location) <bp_location>: Remove bp_location_ops
13948         parameter.
13949         <~bp_location>: Add destructor.
13950         <ops>: Remove.
13951
13952 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13953             Pedro Alves  <palves@redhat.com>
13954
13955         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
13956         'PATH_MAX'.
13957
13958 2019-02-14  David Michael  <fedora.dm0@gmail.com>
13959             Samuel Thibault  <samuel.thibault@gnu.org>
13960             Thomas Schwinge  <thomas@codesourcery.com>
13961
13962         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
13963         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
13964
13965 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
13966
13967         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
13968         (check_empty): Use "const char *".
13969
13970         * gnu-nat.c (gnu_nat_target::detach): Instead of
13971         'detach_inferior (pid)' call
13972         'detach_inferior (find_inferior_pid (pid))'.
13973
13974         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
13975         'nat/fork-inferior.o'.
13976         * gnu-nat.c: #include "nat/fork-inferior.h".
13977
13978         * gnu-nat.c (gnu_nat_target::detach): Instead of
13979         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
13980         * gnu-nat.h: #include "inf-child.h".
13981         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
13982         'i386_gnu_nat_target::fetch_registers'.
13983         (gnu_store_registers): Rename/move to
13984         'i386_gnu_nat_target::store_registers'.
13985
13986         * config/i386/nm-i386gnu.h: Don't "#include" any files.
13987         * gnu-nat.h (mach_thread_info): New function.
13988         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
13989
13990         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
13991
13992 2019-02-14  Frederic Konrad  <konrad@adacore.com>
13993
13994         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
13995
13996 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
13997
13998         * windows-nat.c (windows_add_thread): Add new parameter
13999         "main_thread_p" with default value set to false.  Update
14000         function documentation as well as all callers.
14001         (windows_delete_thread): Likewise.
14002         (fake_create_process): Update call to windows_add_thread.
14003         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14004         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14005         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14006         call to windows_delete_thread.
14007
14008 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
14009
14010         * MAINTAINERS: Add Andrew Burgess as global maintainer.
14011
14012 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14013
14014         * symfile.c (find_separate_debug_file): Use canonical path of
14015         sysroot with child_path instead of gdb_sysroot if it is valid.
14016
14017 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14018
14019         * symfile.c (find_separate_debug_file): Use child_path to
14020         determine if an object file is under a sysroot.
14021
14022 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14023
14024         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14025         unittests/child-path-selftests.c.
14026         * common/pathstuff.c (child_path): New function.
14027         * common/pathstuff.h (child_path): New prototype.
14028         * unittests/child-path-selftests.c: New file.
14029
14030 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
14031
14032         * symfile.c (find_separate_debug_file): Look for separate debug
14033         files in debug directories under the sysroot.
14034
14035 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14036
14037         * symtab.h (struct minimal_symbol data_p): New const method.
14038         (struct minimal_symbol text_p): Likewise.
14039         * symtab.c (output_source_filename): Use file name style
14040         to print file name.
14041         (print_symbol_info): Likewise.
14042         (print_msymbol_info): Use address style to print addresses.
14043         Use function name style to print executable text symbols.
14044         (expand_symtab_containing_pc): Use data_p.
14045         (find_pc_sect_compunit_symtab): Likewise.
14046
14047 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14048
14049         * breakpoint.c (describe_other_breakpoints): Use address style
14050         to print addresses.
14051         (say_where): Likewise.
14052
14053 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14054
14055         * ada-typeprint.c (print_func_type): Print function name
14056         style to print function name.
14057         * c-typeprint.c (c_print_type_1): Likewise.
14058
14059 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
14060
14061         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14062         for execve.
14063
14064 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14065
14066         * c-exp.y (direct_abs_decl): Use emplace_back to record the
14067         type_stack.
14068
14069 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
14070
14071         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14072         TYPE_CODE_REF types.
14073
14074 2019-02-08  Jim Wilson  <jimw@sifive.com>
14075
14076         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14077         (riscv_linux_fregset): New.
14078         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14079
14080 2019-02-07  Tom Tromey  <tom@tromey.com>
14081
14082         * thread.c (thread_cancel_execution_command): Update.
14083         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14084         methods.
14085         (struct thread_fsm_ops): Remove.
14086         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14087         (thread_fsm_should_stop, thread_fsm_return_value)
14088         (thread_fsm_set_finished, thread_fsm_finished_p)
14089         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14090         Don't declare.
14091         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14092         * infrun.c (clear_proceed_status_thread)
14093         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14094         (print_stop_event): Update.
14095         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14096         Add constructor.
14097         (step_command_fsm_ops): Remove.
14098         (new_step_command_fsm): Remove.
14099         (step_1): Update.
14100         (step_command_fsm::should_stop): Rename from
14101         step_command_fsm_should_stop.
14102         (step_command_fsm::clean_up): Rename from
14103         step_command_fsm_clean_up.
14104         (step_command_fsm::do_async_reply_reason): Rename from
14105         step_command_fsm_async_reply_reason.
14106         (struct until_next_fsm): Inherit from thread_fsm.  Add
14107         constructor.
14108         (until_next_fsm_ops): Remove.
14109         (new_until_next_fsm): Remove.
14110         (until_next_fsm::should_stop): Rename from
14111         until_next_fsm_should_stop.
14112         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14113         (until_next_fsm::do_async_reply_reason): Rename from
14114         until_next_fsm_async_reply_reason.
14115         (struct finish_command_fsm): Inherit from thread_fsm.  Add
14116         constructor.  Change type of breakpoint.
14117         (finish_command_fsm_ops): Remove.
14118         (new_finish_command_fsm): Remove.
14119         (finish_command_fsm::should_stop): Rename from
14120         finish_command_fsm_should_stop.
14121         (finish_command_fsm::clean_up): Rename from
14122         finish_command_fsm_clean_up.
14123         (finish_command_fsm::return_value): Rename from
14124         finish_command_fsm_return_value.
14125         (finish_command_fsm::do_async_reply_reason): Rename from
14126         finish_command_fsm_async_reply_reason.
14127         (finish_command): Update.
14128         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14129         Add constructor.
14130         (call_thread_fsm_ops): Remove.
14131         (call_thread_fsm::call_thread_fsm): Rename from
14132         new_call_thread_fsm.
14133         (call_thread_fsm::should_stop): Rename from
14134         call_thread_fsm_should_stop.
14135         (call_thread_fsm::should_notify_stop): Rename from
14136         call_thread_fsm_should_notify_stop.
14137         (run_inferior_call, call_function_by_hand_dummy): Update.
14138         * cli/cli-interp.c (should_print_stop_to_console): Update.
14139         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14140         Add constructor.  Change type of location_breakpoint,
14141         caller_breakpoint.
14142         (until_break_fsm_ops): Remove.
14143         (new_until_break_fsm): Remove.
14144         (until_break_fsm::should_stop): Rename from
14145         until_break_fsm_should_stop.
14146         (until_break_fsm::clean_up): Rename from
14147         until_break_fsm_clean_up.
14148         (until_break_fsm::do_async_reply_reason): Rename from
14149         until_break_fsm_async_reply_reason.
14150         (until_break_command): Update.
14151         * thread-fsm.c: Remove.
14152         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14153
14154 2019-02-07  Tom Tromey  <tom@tromey.com>
14155
14156         * yy-remap.h: Add include guard.
14157         * xtensa-tdep.h: Add include guard.
14158         * xcoffread.h: Rename include guard.
14159         * varobj-iter.h: Add include guard.
14160         * tui/tui.h: Rename include guard.
14161         * tui/tui-winsource.h: Rename include guard.
14162         * tui/tui-wingeneral.h: Rename include guard.
14163         * tui/tui-windata.h: Rename include guard.
14164         * tui/tui-win.h: Rename include guard.
14165         * tui/tui-stack.h: Rename include guard.
14166         * tui/tui-source.h: Rename include guard.
14167         * tui/tui-regs.h: Rename include guard.
14168         * tui/tui-out.h: Rename include guard.
14169         * tui/tui-layout.h: Rename include guard.
14170         * tui/tui-io.h: Rename include guard.
14171         * tui/tui-hooks.h: Rename include guard.
14172         * tui/tui-file.h: Rename include guard.
14173         * tui/tui-disasm.h: Rename include guard.
14174         * tui/tui-data.h: Rename include guard.
14175         * tui/tui-command.h: Rename include guard.
14176         * tic6x-tdep.h: Add include guard.
14177         * target/waitstatus.h: Rename include guard.
14178         * target/wait.h: Rename include guard.
14179         * target/target.h: Rename include guard.
14180         * target/resume.h: Rename include guard.
14181         * target-float.h: Rename include guard.
14182         * stabsread.h: Add include guard.
14183         * rs6000-tdep.h: Add include guard.
14184         * riscv-fbsd-tdep.h: Add include guard.
14185         * regformats/regdef.h: Rename include guard.
14186         * record.h: Rename include guard.
14187         * python/python.h: Rename include guard.
14188         * python/python-internal.h: Rename include guard.
14189         * python/py-stopevent.h: Rename include guard.
14190         * python/py-ref.h: Rename include guard.
14191         * python/py-record.h: Rename include guard.
14192         * python/py-record-full.h: Rename include guard.
14193         * python/py-record-btrace.h: Rename include guard.
14194         * python/py-instruction.h: Rename include guard.
14195         * python/py-events.h: Rename include guard.
14196         * python/py-event.h: Rename include guard.
14197         * procfs.h: Add include guard.
14198         * proc-utils.h: Add include guard.
14199         * p-lang.h: Add include guard.
14200         * or1k-tdep.h: Rename include guard.
14201         * observable.h: Rename include guard.
14202         * nto-tdep.h: Rename include guard.
14203         * nat/x86-linux.h: Rename include guard.
14204         * nat/x86-linux-dregs.h: Rename include guard.
14205         * nat/x86-gcc-cpuid.h: Add include guard.
14206         * nat/x86-dregs.h: Rename include guard.
14207         * nat/x86-cpuid.h: Rename include guard.
14208         * nat/ppc-linux.h: Rename include guard.
14209         * nat/mips-linux-watch.h: Rename include guard.
14210         * nat/linux-waitpid.h: Rename include guard.
14211         * nat/linux-ptrace.h: Rename include guard.
14212         * nat/linux-procfs.h: Rename include guard.
14213         * nat/linux-osdata.h: Rename include guard.
14214         * nat/linux-nat.h: Rename include guard.
14215         * nat/linux-namespaces.h: Rename include guard.
14216         * nat/linux-btrace.h: Rename include guard.
14217         * nat/glibc_thread_db.h: Rename include guard.
14218         * nat/gdb_thread_db.h: Rename include guard.
14219         * nat/gdb_ptrace.h: Rename include guard.
14220         * nat/fork-inferior.h: Rename include guard.
14221         * nat/amd64-linux-siginfo.h: Rename include guard.
14222         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14223         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14224         * nat/aarch64-linux.h: Rename include guard.
14225         * nat/aarch64-linux-hw-point.h: Rename include guard.
14226         * mn10300-tdep.h: Add include guard.
14227         * mips-linux-tdep.h: Add include guard.
14228         * mi/mi-parse.h: Rename include guard.
14229         * mi/mi-out.h: Rename include guard.
14230         * mi/mi-main.h: Rename include guard.
14231         * mi/mi-interp.h: Rename include guard.
14232         * mi/mi-getopt.h: Rename include guard.
14233         * mi/mi-console.h: Rename include guard.
14234         * mi/mi-common.h: Rename include guard.
14235         * mi/mi-cmds.h: Rename include guard.
14236         * mi/mi-cmd-break.h: Rename include guard.
14237         * m2-lang.h: Add include guard.
14238         * location.h: Rename include guard.
14239         * linux-record.h: Rename include guard.
14240         * linux-nat.h: Add include guard.
14241         * linux-fork.h: Add include guard.
14242         * i386-darwin-tdep.h: Rename include guard.
14243         * hppa-linux-offsets.h: Add include guard.
14244         * guile/guile.h: Rename include guard.
14245         * guile/guile-internal.h: Rename include guard.
14246         * gnu-nat.h: Rename include guard.
14247         * gdb-stabs.h: Rename include guard.
14248         * frv-tdep.h: Add include guard.
14249         * f-lang.h: Add include guard.
14250         * event-loop.h: Add include guard.
14251         * darwin-nat.h: Rename include guard.
14252         * cp-abi.h: Rename include guard.
14253         * config/sparc/nm-sol2.h: Rename include guard.
14254         * config/nm-nto.h: Rename include guard.
14255         * config/nm-linux.h: Add include guard.
14256         * config/i386/nm-i386gnu.h: Rename include guard.
14257         * config/djgpp/nl_types.h: Rename include guard.
14258         * config/djgpp/langinfo.h: Rename include guard.
14259         * compile/gcc-cp-plugin.h: Add include guard.
14260         * compile/gcc-c-plugin.h: Add include guard.
14261         * compile/compile.h: Rename include guard.
14262         * compile/compile-object-run.h: Rename include guard.
14263         * compile/compile-object-load.h: Rename include guard.
14264         * compile/compile-internal.h: Rename include guard.
14265         * compile/compile-cplus.h: Rename include guard.
14266         * compile/compile-c.h: Rename include guard.
14267         * common/xml-utils.h: Rename include guard.
14268         * common/x86-xstate.h: Rename include guard.
14269         * common/version.h: Rename include guard.
14270         * common/vec.h: Rename include guard.
14271         * common/tdesc.h: Rename include guard.
14272         * common/selftest.h: Rename include guard.
14273         * common/scoped_restore.h: Rename include guard.
14274         * common/scoped_mmap.h: Rename include guard.
14275         * common/scoped_fd.h: Rename include guard.
14276         * common/safe-iterator.h: Rename include guard.
14277         * common/run-time-clock.h: Rename include guard.
14278         * common/refcounted-object.h: Rename include guard.
14279         * common/queue.h: Rename include guard.
14280         * common/ptid.h: Rename include guard.
14281         * common/print-utils.h: Rename include guard.
14282         * common/preprocessor.h: Rename include guard.
14283         * common/pathstuff.h: Rename include guard.
14284         * common/observable.h: Rename include guard.
14285         * common/netstuff.h: Rename include guard.
14286         * common/job-control.h: Rename include guard.
14287         * common/host-defs.h: Rename include guard.
14288         * common/gdb_wait.h: Rename include guard.
14289         * common/gdb_vecs.h: Rename include guard.
14290         * common/gdb_unlinker.h: Rename include guard.
14291         * common/gdb_unique_ptr.h: Rename include guard.
14292         * common/gdb_tilde_expand.h: Rename include guard.
14293         * common/gdb_sys_time.h: Rename include guard.
14294         * common/gdb_string_view.h: Rename include guard.
14295         * common/gdb_splay_tree.h: Rename include guard.
14296         * common/gdb_setjmp.h: Rename include guard.
14297         * common/gdb_ref_ptr.h: Rename include guard.
14298         * common/gdb_optional.h: Rename include guard.
14299         * common/gdb_locale.h: Rename include guard.
14300         * common/gdb_assert.h: Rename include guard.
14301         * common/filtered-iterator.h: Rename include guard.
14302         * common/filestuff.h: Rename include guard.
14303         * common/fileio.h: Rename include guard.
14304         * common/environ.h: Rename include guard.
14305         * common/common-utils.h: Rename include guard.
14306         * common/common-types.h: Rename include guard.
14307         * common/common-regcache.h: Rename include guard.
14308         * common/common-inferior.h: Rename include guard.
14309         * common/common-gdbthread.h: Rename include guard.
14310         * common/common-exceptions.h: Rename include guard.
14311         * common/common-defs.h: Rename include guard.
14312         * common/common-debug.h: Rename include guard.
14313         * common/cleanups.h: Rename include guard.
14314         * common/buffer.h: Rename include guard.
14315         * common/btrace-common.h: Rename include guard.
14316         * common/break-common.h: Rename include guard.
14317         * cli/cli-utils.h: Rename include guard.
14318         * cli/cli-style.h: Rename include guard.
14319         * cli/cli-setshow.h: Rename include guard.
14320         * cli/cli-script.h: Rename include guard.
14321         * cli/cli-interp.h: Rename include guard.
14322         * cli/cli-decode.h: Rename include guard.
14323         * cli/cli-cmds.h: Rename include guard.
14324         * charset-list.h: Add include guard.
14325         * buildsym-legacy.h: Rename include guard.
14326         * bfin-tdep.h: Add include guard.
14327         * ax.h: Rename include guard.
14328         * arm-linux-tdep.h: Add include guard.
14329         * arm-fbsd-tdep.h: Add include guard.
14330         * arch/xtensa.h: Rename include guard.
14331         * arch/tic6x.h: Add include guard.
14332         * arch/i386.h: Add include guard.
14333         * arch/arm.h: Rename include guard.
14334         * arch/arm-linux.h: Rename include guard.
14335         * arch/arm-get-next-pcs.h: Rename include guard.
14336         * arch/amd64.h: Add include guard.
14337         * arch/aarch64-insn.h: Rename include guard.
14338         * arch-utils.h: Rename include guard.
14339         * annotate.h: Add include guard.
14340         * amd64-darwin-tdep.h: Rename include guard.
14341         * aarch64-linux-tdep.h: Add include guard.
14342         * aarch64-fbsd-tdep.h: Add include guard.
14343         * aarch32-linux-nat.h: Add include guard.
14344
14345 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14346
14347         * macrotab.c (macro_define_internal): New function that
14348         factorizes macro_define_object_internal and macro_define_function
14349         code.
14350         (macro_define_object_internal): Use macro_define_internal.
14351         (macro_define_function): Likewise.
14352
14353 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14354
14355         * macrocmd.c (extract_identifier): Return
14356         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14357         callers.
14358
14359 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
14360
14361         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14362
14363 2019-02-05  Tom Tromey  <tom@tromey.com>
14364
14365         * target.c (target_stack::unpush): Move assertion earlier.
14366
14367 2019-01-30  Tom Tromey  <tom@tromey.com>
14368
14369         PR python/23615:
14370         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14371         (gdbpy_parse_and_eval): Likewise.
14372         * python/python-internal.h (gdbpy_allow_threads): New class.
14373
14374 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
14375
14376         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14377         (aarch64_fbsd_fpregmap): Move earlier.
14378         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14379         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14380         instead of individual calls to trad_frame_set_reg_addr.
14381         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14382         earlier.
14383         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14384         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14385         instead of individual calls to trad_frame_set_reg_addr.
14386
14387 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
14388
14389         * CONTRIBUTE: Replace contribution list with wiki link.
14390
14391 2019-01-25  Tom Tromey  <tom@tromey.com>
14392
14393         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14394
14395 2019-01-25  Tom Tromey  <tom@tromey.com>
14396
14397         * xtensa-linux-nat.c: Fix common/ includes.
14398         * xml-support.h: Fix common/ includes.
14399         * xml-support.c: Fix common/ includes.
14400         * x86-linux-nat.c: Fix common/ includes.
14401         * windows-nat.c: Fix common/ includes.
14402         * varobj.h: Fix common/ includes.
14403         * varobj.c: Fix common/ includes.
14404         * value.c: Fix common/ includes.
14405         * valops.c: Fix common/ includes.
14406         * utils.c: Fix common/ includes.
14407         * unittests/xml-utils-selftests.c: Fix common/ includes.
14408         * unittests/utils-selftests.c: Fix common/ includes.
14409         * unittests/unpack-selftests.c: Fix common/ includes.
14410         * unittests/tracepoint-selftests.c: Fix common/ includes.
14411         * unittests/style-selftests.c: Fix common/ includes.
14412         * unittests/string_view-selftests.c: Fix common/ includes.
14413         * unittests/scoped_restore-selftests.c: Fix common/ includes.
14414         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14415         * unittests/scoped_fd-selftests.c: Fix common/ includes.
14416         * unittests/rsp-low-selftests.c: Fix common/ includes.
14417         * unittests/parse-connection-spec-selftests.c: Fix common/
14418         includes.
14419         * unittests/optional-selftests.c: Fix common/ includes.
14420         * unittests/offset-type-selftests.c: Fix common/ includes.
14421         * unittests/observable-selftests.c: Fix common/ includes.
14422         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14423         * unittests/memrange-selftests.c: Fix common/ includes.
14424         * unittests/memory-map-selftests.c: Fix common/ includes.
14425         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14426         * unittests/function-view-selftests.c: Fix common/ includes.
14427         * unittests/environ-selftests.c: Fix common/ includes.
14428         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14429         * unittests/common-utils-selftests.c: Fix common/ includes.
14430         * unittests/cli-utils-selftests.c: Fix common/ includes.
14431         * unittests/array-view-selftests.c: Fix common/ includes.
14432         * ui-file.c: Fix common/ includes.
14433         * tui/tui-io.c: Fix common/ includes.
14434         * tracepoint.h: Fix common/ includes.
14435         * tracepoint.c: Fix common/ includes.
14436         * tracefile-tfile.c: Fix common/ includes.
14437         * top.h: Fix common/ includes.
14438         * top.c: Fix common/ includes.
14439         * thread.c: Fix common/ includes.
14440         * target/waitstatus.h: Fix common/ includes.
14441         * target/waitstatus.c: Fix common/ includes.
14442         * target.h: Fix common/ includes.
14443         * target.c: Fix common/ includes.
14444         * target-memory.c: Fix common/ includes.
14445         * target-descriptions.c: Fix common/ includes.
14446         * symtab.h: Fix common/ includes.
14447         * symfile.c: Fix common/ includes.
14448         * stap-probe.c: Fix common/ includes.
14449         * spu-linux-nat.c: Fix common/ includes.
14450         * sparc-nat.c: Fix common/ includes.
14451         * source.c: Fix common/ includes.
14452         * solib.c: Fix common/ includes.
14453         * solib-target.c: Fix common/ includes.
14454         * ser-unix.c: Fix common/ includes.
14455         * ser-tcp.c: Fix common/ includes.
14456         * ser-pipe.c: Fix common/ includes.
14457         * ser-base.c: Fix common/ includes.
14458         * selftest-arch.c: Fix common/ includes.
14459         * s12z-tdep.c: Fix common/ includes.
14460         * rust-exp.y: Fix common/ includes.
14461         * rs6000-aix-tdep.c: Fix common/ includes.
14462         * riscv-tdep.c: Fix common/ includes.
14463         * remote.c: Fix common/ includes.
14464         * remote-notif.h: Fix common/ includes.
14465         * remote-fileio.h: Fix common/ includes.
14466         * remote-fileio.c: Fix common/ includes.
14467         * regcache.h: Fix common/ includes.
14468         * regcache.c: Fix common/ includes.
14469         * record-btrace.c: Fix common/ includes.
14470         * python/python.c: Fix common/ includes.
14471         * python/py-type.c: Fix common/ includes.
14472         * python/py-inferior.c: Fix common/ includes.
14473         * progspace.h: Fix common/ includes.
14474         * producer.c: Fix common/ includes.
14475         * procfs.c: Fix common/ includes.
14476         * proc-api.c: Fix common/ includes.
14477         * printcmd.c: Fix common/ includes.
14478         * ppc-linux-nat.c: Fix common/ includes.
14479         * parser-defs.h: Fix common/ includes.
14480         * osdata.c: Fix common/ includes.
14481         * obsd-nat.c: Fix common/ includes.
14482         * nat/x86-linux.c: Fix common/ includes.
14483         * nat/x86-linux-dregs.c: Fix common/ includes.
14484         * nat/x86-dregs.h: Fix common/ includes.
14485         * nat/x86-dregs.c: Fix common/ includes.
14486         * nat/ppc-linux.c: Fix common/ includes.
14487         * nat/mips-linux-watch.h: Fix common/ includes.
14488         * nat/mips-linux-watch.c: Fix common/ includes.
14489         * nat/linux-waitpid.c: Fix common/ includes.
14490         * nat/linux-ptrace.h: Fix common/ includes.
14491         * nat/linux-ptrace.c: Fix common/ includes.
14492         * nat/linux-procfs.c: Fix common/ includes.
14493         * nat/linux-personality.c: Fix common/ includes.
14494         * nat/linux-osdata.c: Fix common/ includes.
14495         * nat/linux-namespaces.c: Fix common/ includes.
14496         * nat/linux-btrace.h: Fix common/ includes.
14497         * nat/linux-btrace.c: Fix common/ includes.
14498         * nat/fork-inferior.c: Fix common/ includes.
14499         * nat/amd64-linux-siginfo.c: Fix common/ includes.
14500         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14501         * nat/aarch64-linux.c: Fix common/ includes.
14502         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14503         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14504         * namespace.h: Fix common/ includes.
14505         * mips-linux-tdep.c: Fix common/ includes.
14506         * minsyms.c: Fix common/ includes.
14507         * mi/mi-parse.h: Fix common/ includes.
14508         * mi/mi-main.c: Fix common/ includes.
14509         * mi/mi-cmd-env.c: Fix common/ includes.
14510         * memrange.h: Fix common/ includes.
14511         * memattr.c: Fix common/ includes.
14512         * maint.h: Fix common/ includes.
14513         * maint.c: Fix common/ includes.
14514         * main.c: Fix common/ includes.
14515         * machoread.c: Fix common/ includes.
14516         * location.c: Fix common/ includes.
14517         * linux-thread-db.c: Fix common/ includes.
14518         * linux-nat.c: Fix common/ includes.
14519         * linux-fork.c: Fix common/ includes.
14520         * inline-frame.c: Fix common/ includes.
14521         * infrun.c: Fix common/ includes.
14522         * inflow.c: Fix common/ includes.
14523         * inferior.h: Fix common/ includes.
14524         * inferior.c: Fix common/ includes.
14525         * infcmd.c: Fix common/ includes.
14526         * inf-ptrace.c: Fix common/ includes.
14527         * inf-child.c: Fix common/ includes.
14528         * ia64-linux-nat.c: Fix common/ includes.
14529         * i387-tdep.c: Fix common/ includes.
14530         * i386-tdep.c: Fix common/ includes.
14531         * i386-linux-tdep.c: Fix common/ includes.
14532         * i386-linux-nat.c: Fix common/ includes.
14533         * i386-go32-tdep.c: Fix common/ includes.
14534         * i386-fbsd-tdep.c: Fix common/ includes.
14535         * i386-fbsd-nat.c: Fix common/ includes.
14536         * guile/scm-type.c: Fix common/ includes.
14537         * guile/guile.c: Fix common/ includes.
14538         * go32-nat.c: Fix common/ includes.
14539         * gnu-nat.c: Fix common/ includes.
14540         * gdbthread.h: Fix common/ includes.
14541         * gdbarch-selftests.c: Fix common/ includes.
14542         * gdb_usleep.c: Fix common/ includes.
14543         * gdb_select.h: Fix common/ includes.
14544         * gdb_bfd.c: Fix common/ includes.
14545         * gcore.c: Fix common/ includes.
14546         * fork-child.c: Fix common/ includes.
14547         * findvar.c: Fix common/ includes.
14548         * fbsd-nat.c: Fix common/ includes.
14549         * event-top.c: Fix common/ includes.
14550         * event-loop.c: Fix common/ includes.
14551         * dwarf2read.c: Fix common/ includes.
14552         * dwarf2loc.c: Fix common/ includes.
14553         * dwarf2-frame.c: Fix common/ includes.
14554         * dwarf-index-cache.c: Fix common/ includes.
14555         * dtrace-probe.c: Fix common/ includes.
14556         * disasm-selftests.c: Fix common/ includes.
14557         * defs.h: Fix common/ includes.
14558         * csky-tdep.c: Fix common/ includes.
14559         * cp-valprint.c: Fix common/ includes.
14560         * cp-support.h: Fix common/ includes.
14561         * cp-support.c: Fix common/ includes.
14562         * corelow.c: Fix common/ includes.
14563         * completer.h: Fix common/ includes.
14564         * completer.c: Fix common/ includes.
14565         * compile/compile.c: Fix common/ includes.
14566         * compile/compile-loc2c.c: Fix common/ includes.
14567         * compile/compile-cplus-types.c: Fix common/ includes.
14568         * compile/compile-cplus-symbols.c: Fix common/ includes.
14569         * command.h: Fix common/ includes.
14570         * cli/cli-dump.c: Fix common/ includes.
14571         * cli/cli-cmds.c: Fix common/ includes.
14572         * charset.c: Fix common/ includes.
14573         * build-id.c: Fix common/ includes.
14574         * btrace.h: Fix common/ includes.
14575         * btrace.c: Fix common/ includes.
14576         * breakpoint.h: Fix common/ includes.
14577         * breakpoint.c: Fix common/ includes.
14578         * ax.h:
14579         (enum agent_op): Fix common/ includes.
14580         * ax-general.c (struct aop_map): Fix common/ includes.
14581         * ax-gdb.c: Fix common/ includes.
14582         * auxv.c: Fix common/ includes.
14583         * auto-load.c: Fix common/ includes.
14584         * arm-tdep.c: Fix common/ includes.
14585         * arch/riscv.c: Fix common/ includes.
14586         * arch/ppc-linux-common.c: Fix common/ includes.
14587         * arch/i386.c: Fix common/ includes.
14588         * arch/arm.c: Fix common/ includes.
14589         * arch/arm-linux.c: Fix common/ includes.
14590         * arch/arm-get-next-pcs.c: Fix common/ includes.
14591         * arch/amd64.c: Fix common/ includes.
14592         * arch/aarch64.c: Fix common/ includes.
14593         * arch/aarch64-insn.c: Fix common/ includes.
14594         * arch-utils.c: Fix common/ includes.
14595         * amd64-windows-tdep.c: Fix common/ includes.
14596         * amd64-tdep.c: Fix common/ includes.
14597         * amd64-sol2-tdep.c: Fix common/ includes.
14598         * amd64-obsd-tdep.c: Fix common/ includes.
14599         * amd64-nbsd-tdep.c: Fix common/ includes.
14600         * amd64-linux-tdep.c: Fix common/ includes.
14601         * amd64-linux-nat.c: Fix common/ includes.
14602         * amd64-fbsd-tdep.c: Fix common/ includes.
14603         * amd64-fbsd-nat.c: Fix common/ includes.
14604         * amd64-dicos-tdep.c: Fix common/ includes.
14605         * amd64-darwin-tdep.c: Fix common/ includes.
14606         * agent.c: Fix common/ includes.
14607         * ada-lang.h: Fix common/ includes.
14608         * ada-lang.c: Fix common/ includes.
14609         * aarch64-tdep.c: Fix common/ includes.
14610
14611 2019-01-25  Tom Tromey  <tom@tromey.com>
14612
14613         * common/create-version.sh: Use common/version.h.
14614
14615 2019-01-24  Pedro Alves  <palves@redhat.com>
14616
14617         * infrun.c (signal_stop, signal_print, signal_program)
14618         (signal_catch, signal_pass): Now arrays instead of pointers.
14619         (update_signals_program_target, do_target_resume)
14620         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14621         * linux-nat.c (linux_nat_target::pass_signals)
14622         (linux_nat_target::create_inferior, linux_nat_target::attach):
14623         Adjust.
14624         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14625         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14626         * procfs.c (procfs_target::pass_signals): Adjust.
14627         * record-full.c (record_full_target::resume): Adjust.
14628         * remote.c (remote_target::pass_signals)
14629         (remote_target::program_signals): Adjust.
14630         * target-debug.h (target_debug_print_signals): Now takes a
14631         gdb::array_view as parameter.  Adjust.
14632         * target.h (target_ops) <pass_signals, program_signals>: Replace
14633         pointer and length parameters with gdb::array_view.
14634         (target_pass_signals, target_program_signals): Likewise.
14635         * target-delegates.c: Regenerate.
14636
14637 2019-01-24  Pedro Alves  <palves@redhat.com>
14638
14639         * common/forward-scope-exit.h
14640         (forward_scope_exit::forward_scope_exit): Pass arguments to
14641         m_bind_function directly, instead of creating a std::bind and
14642         copying that.
14643
14644 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
14645
14646         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14647         for static members.
14648         (pass_in_v_vfp_candidate): Likewise.
14649
14650 2019-01-23  Tom Tromey  <tom@tromey.com>
14651             Pedro Alves  <palves@redhat.com>
14652
14653         * regcache.c (class regcache_invalidator): Remove.
14654         (regcache::raw_write): Use make_scope_exit.
14655
14656 2019-01-23  Tom Tromey  <tom@tromey.com>
14657
14658         * ui-out.h (class ui_out_emit_type): Update comment.
14659
14660 2019-01-23  Tom Tromey  <tom@tromey.com>
14661
14662         * infrun.c (fetch_inferior_event): Update comment.
14663
14664 2019-01-23  Tom Tromey  <tom@tromey.com>
14665             Pedro Alves  <palves@redhat.com>
14666
14667         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14668         parameter.
14669         (fetch_inferior_event): Use SCOPE_EXIT.
14670
14671
14672 2019-01-23  Tom Tromey  <tom@tromey.com>
14673             Pedro Alves  <palves@redhat.com>
14674
14675         * infrun.c (disable_thread_events): Delete.
14676         (stop_all_threads): Use SCOPE_EXIT.
14677
14678 2019-01-23  Tom Tromey  <tom@tromey.com>
14679             Pedro Alves  <palves@redhat.com>
14680
14681         * symfile.c: Include forward-scope-exit.h.
14682         (clear_symtab_users_cleanup): Replace forward declaration with
14683         a FORWARD_SCOPE_EXIT.
14684         (syms_from_objfile_1): Use the forward_scope_exit and
14685         gdb::optional instead of cleanup_function.
14686         (reread_symbols): Use the forward_scope_exit instead of
14687         cleanup_function.
14688         (clear_symtab_users_cleanup): Remove function.
14689
14690 2019-01-23  Tom Tromey  <tom@tromey.com>
14691             Pedro Alves  <palves@redhat.com>
14692
14693         * linux-nat.c: Include scope-exit.h.
14694         (cleanup_target_stop): Remove.
14695         (linux_nat_target::static_tracepoint_markers_by_strid): Use
14696         SCOPE_EXIT.
14697
14698 2019-01-23  Tom Tromey  <tom@tromey.com>
14699             Pedro Alves  <palves@redhat.com>
14700
14701         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
14702         (call_function_by_hand_dummy): Use SCOPE_EXIT.
14703
14704 2019-01-23  Tom Tromey  <tom@tromey.com>
14705             Andrew Burgess  <andrew.burgess@embecosm.com>
14706             Pedro Alves  <palves@redhat.com>
14707
14708         * infrun.c (fetch_inferior_event): Use scope_exit.
14709         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
14710         * top.c (execute_command): Use scope_exit.
14711         * breakpoint.c (bpstat_do_actions): Use scope_exit.
14712         * utils.c (do_bpstat_clear_actions_cleanup)
14713         (make_bpstat_clear_actions_cleanup): Remove.
14714
14715 2019-01-23  Tom Tromey  <tom@tromey.com>
14716             Pedro Alves  <palves@redhat.com>
14717
14718         * infrun.c: Include "common/scope-exit.h"
14719         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
14720         (wait_for_inferior): Use SCOPE_EXIT.
14721         (fetch_inferior_event): Use scope_exit.
14722
14723 2019-01-23  Tom Tromey  <tom@tromey.com>
14724             Pedro Alves  <palves@redhat.com>
14725
14726         * breakpoint.c (create_breakpoint): Remove cleanup.
14727
14728 2019-01-23  Tom Tromey  <tom@tromey.com>
14729             Andrew Burgess  <andrew.burgess@embecosm.com>
14730             Pedro Alves  <palves@redhat.com>
14731
14732 2019-01-23  Pedro Alves  <palves@redhat.com>
14733
14734         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
14735
14736 2019-01-23  Pedro Alves  <palves@redhat.com>
14737             Andrew Burgess  <andrew.burgess@embecosm.com>
14738
14739         * gdbthread.h: Include "common/forward-scope-exit.h".
14740         (scoped_finish_thread_state): Redefine custom class in terms of
14741         forward_scope_exit.
14742
14743 2019-01-23  Pedro Alves  <palves@redhat.com>
14744             Andrew Burgess  <andrew.burgess@embecosm.com>
14745
14746         * common/forward-scope-exit.h: New file.
14747
14748 2019-01-23  Pedro Alves  <palves@redhat.com>
14749             Andrew Burgess  <andrew.burgess@embecosm.com>
14750             Tom Tromey  <tom@tromey.com>
14751
14752         * common/scope-exit.h: New file.
14753
14754 2019-01-23  Pedro Alves  <palves@redhat.com>
14755
14756         * common/preprocessor.h (ESC): Rename to ...
14757         (ESC_PARENS): ... this.
14758         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
14759         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
14760
14761 2019-01-23  Tom Tromey  <tom@tromey.com>
14762
14763         * language.h (class scoped_switch_to_sym_language_if_auto):
14764         Initialize m_lang in both cases.
14765
14766 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
14767
14768         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
14769         with XCNEW.
14770
14771 2019-01-22  Tom Tromey  <tom@tromey.com>
14772
14773         * corelow.c: Do not include sys/file.h.
14774
14775 2019-01-22  Tom Tromey  <tom@tromey.com>
14776
14777         * tui/tui-wingeneral.h: Include gdb_curses.h.
14778
14779 2019-01-22  Tom Tromey  <tom@tromey.com>
14780
14781         * source-cache.h (class source_cache) <get_source_lines,
14782         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
14783
14784 2019-01-22  Tom Tromey  <tom@tromey.com>
14785
14786         * remote-fileio.h (struct remote_target): Declare.
14787
14788 2019-01-22  Tom Tromey  <tom@tromey.com>
14789
14790         * python/py-arch.c: Do not include py-ref.h.
14791         * python/py-bpevent.c: Do not include py-ref.h.
14792         * python/py-cmd.c: Do not include py-ref.h.
14793         * python/py-continueevent.c: Do not include py-ref.h.
14794         * python/py-event.h: Do not include py-ref.h.
14795         * python/py-evtregistry.c: Do not include py-ref.h.
14796         * python/py-finishbreakpoint.c: Do not include py-ref.h.
14797         * python/py-frame.c: Do not include py-ref.h.
14798         * python/py-framefilter.c: Do not include py-ref.h.
14799         * python/py-function.c: Do not include py-ref.h.
14800         * python/py-infevents.c: Do not include py-ref.h.
14801         * python/py-linetable.c: Do not include py-ref.h.
14802         * python/py-objfile.c: Do not include py-ref.h.
14803         * python/py-param.c: Do not include py-ref.h.
14804         * python/py-prettyprint.c: Do not include py-ref.h.
14805         * python/py-progspace.c: Do not include py-ref.h.
14806         * python/py-symbol.c: Do not include py-ref.h.
14807         * python/py-symtab.c: Do not include py-ref.h.
14808         * python/py-type.c: Do not include py-ref.h.
14809         * python/py-unwind.c: Do not include py-ref.h.
14810         * python/py-utils.c: Do not include py-ref.h.
14811         * python/py-value.c: Do not include py-ref.h.
14812         * python/py-varobj.c: Do not include py-ref.h.
14813         * python/py-xmethods.c: Do not include py-ref.h.
14814         * python/python.c: Do not include py-ref.h.
14815         * varobj.c: Do not include py-ref.h.
14816
14817 2019-01-22  Tom Tromey  <tom@tromey.com>
14818
14819         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
14820         keyword for bcache.
14821
14822 2019-01-22  Tom Tromey  <tom@tromey.com>
14823
14824         * compile/compile-cplus-types.c: Remove a comment by #include.
14825
14826 2019-01-22  Tom Tromey  <tom@tromey.com>
14827
14828         * compile/gcc-c-plugin.h: Include compile-internal.h.
14829
14830 2019-01-22  Tom Tromey  <tom@tromey.com>
14831
14832         * stabsread.c (EXTERN): Do not define.
14833         (symnum, next_symbol_text_func, processing_gcc_compilation)
14834         (within_function, global_sym_chain, global_stabs)
14835         (previous_stab_code, this_object_header_files)
14836         (n_this_object_header_files)
14837         (n_allocated_this_object_header_files): Define.
14838         * stabsread.h (EXTERN): Never define.  Use "extern".
14839
14840 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14841
14842         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
14843         history_value.
14844
14845 2019-01-21  Tom Tromey  <tom@tromey.com>
14846
14847         * ui-out.c: Fix includes.
14848         * tui/tui-source.c: Fix includes.
14849         * target.c: Fix includes.
14850         * remote.c: Fix includes.
14851         * regcache.c: Fix includes.
14852         * python/py-block.c: Fix includes.
14853         * printcmd.c: Fix includes.
14854         * or1k-tdep.c: Fix includes.
14855         * mi/mi-main.c: Fix includes.
14856         * m32r-tdep.c: Fix includes.
14857         * csky-tdep.c: Fix includes.
14858         * compile/compile-cplus-types.c: Fix includes.
14859         * cli/cli-interp.c: Fix includes.
14860
14861 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
14862
14863         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14864         for padding.
14865
14866 2019-01-16  Tom Tromey  <tom@tromey.com>
14867
14868         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
14869         earlier.
14870         (struct objfile) <msymbols_range>: Move from top level.
14871         <msymbols>: New method.
14872         (class objfile_msymbols): Remove.
14873         * symtab.c (default_collect_symbol_completion_matches_break_on):
14874         Update.
14875         * symmisc.c (dump_msymbols): Update.
14876         * stabsread.c (scan_file_globals): Update.
14877         * objc-lang.c (info_selectors_command, info_classes_command)
14878         (find_methods): Update.
14879         * minsyms.c (find_solib_trampoline_target): Update.
14880         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
14881         * coffread.c (coff_symfile_read): Update.
14882         * ada-lang.c (ada_lookup_simple_minsym)
14883         (ada_collect_symbol_completion_matches): Update.
14884
14885 2019-01-16  Tom Tromey  <tom@tromey.com>
14886
14887         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
14888         type.  Remove no-argument constructor.
14889         <iterator::operator++>: Simplify.
14890         <begin>: Update.
14891         <end>: Use minimal_symbol_count.
14892
14893 2019-01-16  Tom Tromey  <tom@tromey.com>
14894
14895         * objfiles.h (struct objfile) <psymtabs>: New method.
14896         (class objfile_psymtabs): Remove.
14897         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
14898         typedef.
14899         <range>: New method.
14900         (require_partial_symbols): Change return type.
14901         * psymtab.c (require_partial_symbols)
14902         (psym_expand_symtabs_matching): Update.
14903         * mdebugread.c (parse_partial_symbols): Update.
14904         * dbxread.c (dbx_end_psymtab): Update.
14905
14906 2019-01-15  Tom Tromey  <tom@tromey.com>
14907
14908         * symtab.c (lookup_objfile_from_block)
14909         (lookup_symbol_in_objfile_symtabs)
14910         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
14911         (find_line_symtab, info_sources_command)
14912         (default_collect_symbol_completion_matches_break_on)
14913         (make_source_files_completion_list): Update.
14914         * symmisc.c (print_objfile_statistics, dump_objfile)
14915         (maintenance_print_symbols, maintenance_info_symtabs)
14916         (maintenance_check_symtabs, maintenance_info_line_tables):
14917         Update.
14918         * source.c (select_source_symtab)
14919         (forget_cached_source_info_for_objfile): Update.
14920         * objfiles.h (class objfile_compunits): Remove.
14921         (struct objfile) <compunits_range>: New typedef.
14922         (compunits): New method.
14923         * objfiles.c (objfile_relocate1): Update.
14924         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14925         * maint.c (count_symtabs_and_blocks): Update.
14926         * linespec.c (iterate_over_all_matching_symtabs): Update.
14927         * cp-support.c (add_symbol_overload_list_qualified): Update.
14928         * coffread.c (coff_symtab_read): Update.
14929         * ada-lang.c (add_nonlocal_symbols)
14930         (ada_collect_symbol_completion_matches)
14931         (ada_add_global_exceptions): Update.
14932
14933 2019-01-15  Tom Tromey  <tom@tromey.com>
14934
14935         * progspace.h (program_space) <objfiles_safe_range>: New
14936         typedef.
14937         <objfiles_safe>: New method.
14938         * objfiles.h (class all_objfiles_safe): Remove.
14939         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
14940         * jit.c (jit_inferior_exit_hook): Update.
14941
14942 2019-01-17  Tom Tromey  <tom@tromey.com>
14943
14944         * progspace.h (program_space) <objfiles_range>: New typedef.
14945         <objfiles>: New method.
14946         <objfiles_head>: Rename from objfiles.
14947         (object_files): Update.
14948         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
14949         * guile/scm-pretty-print.c
14950         (ppscm_find_pretty_printer_from_objfiles): Update.
14951         * guile/scm-objfile.c (gdbscm_objfiles): Update.
14952         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
14953         Update.
14954         * python/py-progspace.c (pspy_get_objfiles): Update.
14955         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
14956         Update.
14957         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
14958         (objfpy_lookup_objfile_by_build_id): Update.
14959         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
14960         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
14961         Update.
14962         * symtab.c (iterate_over_symtabs, matching_obj_sections)
14963         (expand_symtab_containing_pc, lookup_objfile_from_block)
14964         (lookup_static_symbol, basic_lookup_transparent_type)
14965         (find_pc_sect_compunit_symtab, find_symbol_at_address)
14966         (find_line_symtab, info_sources_command)
14967         (default_collect_symbol_completion_matches_break_on)
14968         (make_source_files_completion_list, find_main_name): Update.
14969         * symmisc.c (print_symbol_bcache_statistics)
14970         (print_objfile_statistics, maintenance_print_symbols)
14971         (maintenance_print_msymbols, maintenance_print_objfiles)
14972         (maintenance_info_symtabs, maintenance_check_symtabs)
14973         (maintenance_expand_symtabs, maintenance_info_line_tables):
14974         Update.
14975         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
14976         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
14977         (map_overlay_command, unmap_overlay_command)
14978         (simple_overlay_update, expand_symtabs_matching)
14979         (map_symbol_filenames): Update.
14980         * symfile-debug.c (set_debug_symfile): Update.
14981         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
14982         Update.
14983         * source.c (select_source_symtab, forget_cached_source_info):
14984         Update.
14985         * solib.c (solib_read_symbols): Update.
14986         * solib-spu.c (append_ocl_sos): Update.
14987         * psymtab.c (maintenance_print_psymbols)
14988         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
14989         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
14990         * printcmd.c (info_symbol_command): Update.
14991         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
14992         Update.
14993         * objfiles.h (class all_objfiles): Remove.
14994         * objfiles.c (have_partial_symbols, have_full_symbols)
14995         (have_minimal_symbols, qsort_cmp, update_section_map)
14996         (shared_objfile_contains_address_p)
14997         (default_iterate_over_objfiles_in_search_order): Update.
14998         * objc-lang.c (info_selectors_command, info_classes_command)
14999         (find_methods): Update.
15000         * minsyms.c (find_solib_trampoline_target): Update.
15001         * maint.c (maintenance_info_sections)
15002         (maintenance_translate_address, count_symtabs_and_blocks):
15003         Update.
15004         * main.c (captured_main_1): Update.
15005         * linux-thread-db.c (try_thread_db_load_from_pdir)
15006         (has_libpthread): Update.
15007         * linespec.c (iterate_over_all_matching_symtabs)
15008         (search_minsyms_for_name): Update.
15009         * jit.c (jit_find_objf_with_entry_addr): Update.
15010         * hppa-tdep.c (find_unwind_entry)
15011         (hppa_lookup_stub_minimal_symbol): Update.
15012         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15013         Update.
15014         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15015         (elf_gnu_ifunc_resolve_by_got): Update.
15016         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15017         * dwarf-index-write.c (save_gdb_index_command): Update.
15018         * cp-support.c (add_symbol_overload_list_qualified): Update.
15019         * breakpoint.c (create_overlay_event_breakpoint)
15020         (create_longjmp_master_breakpoint)
15021         (create_std_terminate_master_breakpoint)
15022         (create_exception_master_breakpoint): Update.
15023         * blockframe.c (find_pc_partial_function): Update.
15024         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15025         (ada_collect_symbol_completion_matches)
15026         (ada_add_global_exceptions): Update.
15027
15028 2019-01-17  Tom Tromey  <tom@tromey.com>
15029
15030         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
15031         declare VEC.
15032         (solib_target_parse_libraries): Change return type.
15033         (library_list_start_segment, library_list_start_section)
15034         (library_list_end_library, library_list_start_library); Update.
15035         (solib_target_free_library_list): Remove.
15036         (solib_target_parse_libraries): Remove cleanup.  Change return
15037         type.
15038         (solib_target_current_sos): Update.
15039
15040 2019-01-17  Tom Tromey  <tromey@bapiya>
15041
15042         * valprint.c: Replace "the the" with "the".
15043         * symtab.c: Replace "the the" with "the".
15044         * solib.c: Replace "the the" with "the".
15045         * solib-dsbt.c: Replace "the the" with "the".
15046         * linespec.c: Replace "the the" with "the".
15047         * dwarf2loc.h: Replace "the the" with "the".
15048         * amd64-windows-tdep.c: Replace "the the" with "the".
15049         * aarch64-tdep.c: Replace "the the" with "the".
15050
15051 2019-01-16  Keith Seitz  <keiths@redhat.com>
15052
15053         PR gdb/23773
15054         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15055         <builder>: Rename to ..
15056         <m_builder>: ... this and make private.
15057         (dwarf2_cu::get_builder): New method.  Change all users of
15058         `builder' to use this method.
15059         (dwarf2_start_symtab): Move to ...
15060         (dwarf2_cu::start_symtab): ... here.  Update all callers
15061         (setup_type_unit_groups): Move to ...
15062         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
15063         callers.
15064         (dwarf2_cu::reset_builder): New method.
15065         (process_full_compunit, process_full_type_unit): Use
15066         dwarf2_cu::reset_builder.
15067         (follow_die_offset): Record the ancestor CU if it is different
15068         from the followed DIE's CU.
15069         (follow_die_sig_1): Likewise.
15070
15071 2019-01-15  Tom Tromey  <tom@tromey.com>
15072
15073         * remote.c (class remote_state) <buf>: Now a char_vector.
15074         <buf_size>: Remove.
15075         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
15076         parameter.
15077         (remote_target::getpkt_or_notif_sane_1)
15078         (remote_target::getpkt_sane)
15079         (remote_target::getpkt_or_notif_sane): Likewise.
15080         (class remote_target) <putpkt>: New overload.
15081         (remote_target::read_frame): Change type of "buf_p".  Remove
15082         sizeof_p parameter.
15083         (packet_ok): New overload.
15084         (packet_check_result): New overload.
15085         Update all uses.
15086
15087 2019-01-14  Tom Tromey  <tom@tromey.com>
15088
15089         * remote-notif.c (handle_notification, remote_notif_ack)
15090         (remote_notif_parse): Make "buf" const.
15091         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15092         const.
15093         (remote_notif_parse, remote_notif_ack, handle_notification):
15094         Likewise.
15095         * remote.c (remote_notif_stop_parse): Make "buf" const.
15096         (remote_target::remote_parse_stop_reply): Make "buf" const.
15097         (remote_notif_stop_ack): Make "buf" const.
15098
15099 2019-01-14  Tom Tromey  <tom@tromey.com>
15100
15101         * remote.c (remote_console_output): Make parameter const.
15102
15103 2019-01-14  Tom Tromey  <tom@tromey.com>
15104
15105         * target-debug.h (target_debug_print_signals): Constify.
15106         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15107         * procfs.c (procfs_target::pass_signals): Update.
15108         * linux-nat.c (linux_nat_target::pass_signals): Update.
15109         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15110         * target-delegates.c: Rebuild.
15111         * remote.c (remote_target::program_signals): Update.
15112         (remote_target::pass_signals): Update.
15113         * target.c (target_pass_signals): Constify argument.
15114         (target_program_signals): Likewise.
15115         * target.h (struct target_ops) <pass_signals, program_signals>:
15116         Constify argument.
15117         (target_pass_signals, target_program_signals): Constify argument.
15118
15119 2019-01-14  Tom Tromey  <tom@tromey.com>
15120
15121         PR tui/28819:
15122         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15123
15124 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
15125
15126         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15127         field.
15128         * rs6000-tdep.c: Include reggroups.h.
15129         (IS_V_ALIAS_PSEUDOREG): Define.
15130         (rs6000_register_name): Return names for the "vX" aliases.
15131         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15132         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
15133         aliases.  Call default_register_reggroup_p for all other
15134         pseudo-registers.
15135         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15136         New functions.
15137         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15138         Handle "vX" aliases.
15139         (v_alias_pseudo_register_collect): New function.
15140         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15141         (rs6000_gdbarch_init): Initialize "vX" aliases as
15142         pseudo-registers.  Restore registration of
15143         rs6000_pseudo_register_reggroup_p with
15144         set_tdesc_pseudo_register_reggroup_p.
15145
15146 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
15147
15148         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15149         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15150         set_gdbarch_num_pseudo_regs.
15151
15152 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15153
15154         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15155         Remove arg prefixname, add do_set and do_show.
15156         Add member functions set_list and show_list.
15157         * cli/cli-style.c (class cli_style_option): Update accordingly.
15158         (style_set_list): Move to file scope.
15159         (style_show_list): Likewise.
15160         (set_style): Call help_list.
15161         (show_style): Call cmd_show_list.
15162         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15163         Update to use the new macro.
15164
15165 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
15166
15167         * ada-lang.c (_initialize_ada_language): Expand the help text
15168         for the "catch exception" command.
15169
15170 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15171
15172         * symtab.c (matching_obj_sections): Initialize obj,
15173         declare it closer to its usage.
15174
15175 2019-01-10  Tom Tromey  <tom@tromey.com>
15176
15177         * thread-iter.h (inf_threads_iterator): Use next_iterator.
15178         (basic_inf_threads_range): Remove.
15179         (inf_threads_range, inf_non_exited_threads_range)
15180         (safe_inf_threads_range): Use next_adapter.
15181
15182 2019-01-10  Keith Seitz  <keiths@redhat.com>
15183
15184         PR gdb/23712
15185         PR symtab/23010
15186         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15187         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15188
15189 2019-01-10  Keith Seitz  <keiths@redhat.com>
15190
15191         PR gdb/23712
15192         PR symtab/23010
15193         * dictionary.c (pending_to_vector): Remove.
15194         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15195         Remove _1 suffix, replacing functions of the same name.  Update
15196         all callers.
15197         (dict_create_hashed, dict_create_hashed_expandable)
15198         (dict_create_linear, dict_create_linear_expandable, dict_free)
15199         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15200         Make functions static.
15201
15202 2019-01-10  Keith Seitz  <keiths@redhat.com>
15203
15204         PR gdb/23712
15205         PR symtab/23010
15206         * dictionary.h (struct dictionary): Replace declaration with
15207         multidictionary.
15208         (dict_create_hashed, dict_create_hashed_expandable)
15209         (dict_create_linear, dict_create_linear_expandable)
15210         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15211         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15212         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15213         taking multidictionary argument.
15214         [ALL_DICT_SYMBOLS]: Update for multidictionary.
15215         * block.h (struct block) <dict>: Change to multidictionary
15216         and rename `multidict'.
15217         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15218         symmisc.c: Update all dictionary references to multidictionary.
15219
15220 2019-01-10  Keith Seitz  <keiths@redhat.com>
15221
15222         PR gdb/23712
15223         PR symtab/23010
15224         * dictionary.c: Include unordered_map.
15225         (pending_to_vector): New function.
15226         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15227         Rewrite the non-"_1" functions to take vector instead
15228         of linked list.
15229         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15230         "new" _1 versions of the same name.
15231         (multidictionary): Define.
15232         (std::hash<enum language): New definition.
15233         (collate_pending_symbols_by_language, mdict_create_hashed)
15234         (mdict_create_hashed_expandable, mdict_create_linear)
15235         (mdict_create_linear_expandable, mdict_free)
15236         (find_language_dictionary, create_new_language_dictionary)
15237         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15238         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15239         (mdict_size, mdict_empty): New functions.
15240         * dictionary.h (mdict_iterator): Define.
15241
15242 2019-01-10  Pedro Alves  <palves@redhat.com>
15243
15244         * breakpoint.c (read_uploaded_action)
15245         (create_tracepoint_from_upload): Adjust to use
15246         gdb::unique_xmalloc_ptr.
15247         * ctf.c (ctf_write_uploaded_tp):
15248         (SET_ARRAY_FIELD): Use emplace_back.
15249         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15250         * tracefile-tfile.c (tfile_write_uploaded_tp):
15251         * tracepoint.c (parse_tracepoint_definition): Adjust to use
15252         gdb::unique_xmalloc_ptr.
15253         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15254         at_string, cond_string, cmd_strings>: Replace char pointers
15255         with gdb::unique_xmalloc_ptr.
15256
15257 2019-01-10  Pedro Alves  <palves@redhat.com>
15258
15259         * solib-target.c (library_list_start_library): Don't xstrdup name.
15260
15261 2019-01-10  Pedro Alves  <palves@redhat.com>
15262
15263         * mdebugread.c (parse_partial_symbols): Use
15264         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15265
15266 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15267
15268         * linux-fork.c (scoped_switch_fork_info)
15269         <~scoped_switch_fork_info>: Fix incorrect variable name.
15270
15271 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
15272
15273         * linux-fork.c (scoped_switch_fork_info)
15274         <scoped_switch_fork_info>: Make explicit.
15275         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15276
15277 2019-01-10  Tom Tromey  <tom@tromey.com>
15278
15279         * objfiles.h (objfile::reset_psymtabs): Update.
15280         * objfiles.c (objfile::objfile): Update.
15281         * psymtab.h (psymtab_storage::obstack): Update.
15282         (psymtab_storage::m_obstack): Use gdb::optional.
15283         (class psymtab_storage): Update comment.  Remove objfile
15284         parameter.
15285         * psymtab.c (psymtab_storage::psymtab_storage): Update.
15286
15287 2019-01-10  Tom Tromey  <tom@tromey.com>
15288
15289         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15290         <free_psymtabs>: Now private.
15291         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15292         (allocate_psymtab): Use new method.
15293
15294 2019-01-10  Tom Tromey  <tom@tromey.com>
15295
15296         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15297         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15298         * mdebugread.c (parse_partial_symbols): Use
15299         allocate_dependencies.
15300         * dwarf2read.c (dwarf2_create_include_psymtab): Use
15301         allocate_dependencies.
15302         (process_psymtab_comp_unit_reader)
15303         (build_type_psymtab_dependencies): Likewise.
15304         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15305
15306 2019-01-10  Tom Tromey  <tom@tromey.com>
15307
15308         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15309         PSYMBOL_SET_LANGUAGE.
15310         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15311
15312 2019-01-10  Tom Tromey  <tom@tromey.com>
15313
15314         * psymtab.h (psymtab_storage::obstack): New method.
15315         <m_obstack>: Rename from obstack; now private.
15316         * psymtab.c (psymtab_storage): Update.
15317         * dwarf2read.c (create_addrmap_from_index)
15318         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15319         Update.
15320
15321 2019-01-10  Tom Tromey  <tom@tromey.com>
15322
15323         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15324         * objfiles.h (objfile::reset_psymtabs): New method.
15325
15326 2019-01-10  Tom Tromey  <tom@tromey.com>
15327
15328         * symmisc.c (print_symbol_bcache_statistics): Update.
15329         (print_objfile_statistics): Update.
15330         * symfile.c (reread_symbols): Update.
15331         * psymtab.h (class psymtab_storage): New.
15332         * psymtab.c (psymtab_storage): New constructor.
15333         (~psymtab_storage): New destructor.
15334         (require_partial_symbols): Update.
15335         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15336         (find_pc_sect_psymtab, find_pc_sect_psymbol)
15337         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15338         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15339         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15340         (start_psymtab_common, end_psymtab_common)
15341         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15342         (allocate_psymtab): Update.
15343         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15344         Update.
15345         (dump_psymtab_addrmap, maintenance_print_psymbols)
15346         (maintenance_check_psymtabs): Update.
15347         (class objfile_psymtabs): Move to objfiles.h.
15348         * psympriv.h (discard_psymtab): Now inline.
15349         (psymtab_discarder::psymtab_discarder): Update.
15350         (psymtab_discarder::~psymtab_discarder): Update.
15351         (ALL_OBJFILE_PSYMTABS): Rewrite.
15352         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15353         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15354         Remove fields.
15355         <partial_symtabs>: New field.
15356         (class objfile_psymtabs): Move from psymtab.h.  Update.
15357         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15358         psymbol_cache.
15359         (objfile::~objfile): Don't destroy psymbol_cache.
15360         * mdebugread.c (parse_partial_symbols): Update.
15361         * dwarf2read.c (create_addrmap_from_index)
15362         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15363         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15364         (add_partial_subprogram, dwarf2_ranges_read): Update.
15365         * dwarf-index-write.c (write_address_map)
15366         (write_one_signatured_type, recursively_write_psymbols)
15367         (class debug_names, class debug_names, write_psymtabs_to_index):
15368         Update.
15369
15370 2019-01-10  Tom Tromey  <tom@tromey.com>
15371
15372         * symtab.h (SYMBOL_SET_NAMES): Update.
15373         (symbol_set_names): Update.
15374         (MSYMBOL_SET_NAMES): Update.
15375         * symtab.c (symbol_set_names): Change argument to be an
15376         objfile_per_bfd_storage.
15377         * psymtab.c (add_psymbol_to_bcache): Update.
15378         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15379
15380 2019-01-10  Tom Tromey  <tom@tromey.com>
15381
15382         * symtab.c (create_demangled_names_hash): Change argument to be an
15383         objfile_per_bfd_storage.
15384         (symbol_set_names): Update.
15385
15386 2019-01-10  Tom Tromey  <tom@tromey.com>
15387
15388         * xcoffread.c (xcoff_initial_scan): Unconditionally call
15389         init_psymbol_list.
15390         * psymtab.c (init_psymbol_list): Do nothing if already called.
15391         * psympriv.h (init_psymbol_list): Add comment.
15392         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15393         init_psymbol_list.
15394         * dbxread.c (dbx_symfile_read): Unconditionally call
15395         init_psymbol_list.
15396
15397 2019-01-10  Tom Tromey  <tom@tromey.com>
15398
15399         * xcoffread.c (scan_xcoff_symtab): Update.
15400         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15401         "where".
15402         * mdebugread.c (parse_partial_symbols)
15403         (handle_psymbol_enumerators): Update.
15404         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15405         * dbxread.c (read_dbx_symtab): Update.
15406         * psympriv.h (psymbol_placement): New enum.
15407         (add_psymbol_to_list): Update.
15408
15409 2019-01-10  Tom Tromey  <tom@tromey.com>
15410
15411         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15412         static_psymbols parameters.
15413         (scan_xcoff_symtab): Update.
15414         * psymtab.c (start_psymtab_common): Remove global_psymbols and
15415         static_psymbols parameters.
15416         * psympriv.h (start_psymtab_common): Update.
15417         * mdebugread.c (parse_partial_symbols): Update.
15418         * dwarf2read.c (create_partial_symtab): Update.
15419         * dbxread.c (read_dbx_symtab): Update.
15420         (start_psymtab): Remove global_psymbols and static_psymbols
15421         parameters.
15422
15423 2019-01-10  Tom Tromey  <tom@tromey.com>
15424
15425         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15426         * psymtab.c (allocate_psymtab): Add comment.
15427         * psympriv.h (allocate_psymtab): Add comment.
15428         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15429         initializations.
15430         * dbxread.c (dbx_end_psymtab): Remove some initializations.
15431
15432 2019-01-10  Tom Tromey  <tom@tromey.com>
15433
15434         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15435         Don't declare.
15436         * mipsread.c: Include mdebugread.h.
15437         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15438         Declare.
15439         * elfread.c: Include mdebugread.h.
15440
15441 2019-01-09  Tom Tromey  <tom@tromey.com>
15442
15443         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15444         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15445         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15446         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15447         (psym_lookup_symbol, psym_find_last_source_symtab)
15448         (psym_forget_cached_source_info, psym_print_stats)
15449         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15450         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15451         (psym_map_matching_symbols, psym_expand_symtabs_matching)
15452         (psym_find_compunit_symtab_by_address)
15453         (maintenance_print_psymbols, maintenance_info_psymtabs)
15454         (maintenance_check_psymtabs): Use ranged for.
15455         * psymtab.h (class objfile_psymtabs): New.
15456         (require_partial_symbols): Return objfile_psymtabs.
15457         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15458
15459 2019-01-09  Tom Tromey  <tom@tromey.com>
15460
15461         * symfile.c (overlay_invalidate_all, find_pc_overlay)
15462         (find_pc_mapped_section, list_overlays_command)
15463         (map_overlay_command, unmap_overlay_command)
15464         (simple_overlay_update): Use all_objfiles.
15465         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15466         * printcmd.c (info_symbol_command): Use all_objfiles.
15467         * objfiles.h (ALL_OBJSECTIONS): Remove.
15468         * maint.c (maintenance_translate_address): Use all_objfiles.
15469         * gcore.c (gcore_create_callback): Use all_objfiles.
15470         (objfile_find_memory_regions): Likewise.
15471
15472 2019-01-09  Tom Tromey  <tom@tromey.com>
15473
15474         * symtab.c (find_line_symtab, info_sources_command)
15475         (make_source_files_completion_list): Use objfile_compunits.
15476         * source.c (select_source_symtab): Use objfile_compunits.
15477         * objfiles.h (struct objfile): Update comment.
15478         (ALL_OBJFILES): Remove.
15479         (ALL_FILETABS): Remove.
15480         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15481         objfile_compunits.
15482
15483 2019-01-09  Tom Tromey  <tom@tromey.com>
15484
15485         * symmisc.c (print_objfile_statistics, dump_objfile)
15486         (maintenance_print_symbols): Use compunit_filetabs.
15487         * source.c (forget_cached_source_info_for_objfile): Use
15488         compunit_filetabs.
15489         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15490         (ALL_FILETABS): Use compunit_filetabs.
15491         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15492         * coffread.c (coff_symtab_read): Use compunit_filetabs.
15493
15494 2019-01-09  Tom Tromey  <tom@tromey.com>
15495
15496         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15497         (compunit_filetabs): New.
15498         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15499         compunit_filetabs.
15500         (info_sources_command, make_source_files_completion_list): Remove
15501         declaration.
15502         * symmisc.c (print_objfile_statistics, dump_objfile)
15503         (maintenance_print_symbols): Remove declaration.
15504         (maintenance_info_symtabs): Use compunit_filetabs.
15505         (maintenance_info_line_tables): Likewise.
15506         * source.c (select_source_symtab): Change local variable name.
15507         (forget_cached_source_info_for_objfile): Remove declaration.
15508         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15509         * objfiles.c (objfile_relocate1): Remove declaration.
15510         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15511         declaration.
15512         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15513         * coffread.c (coff_symtab_read): Remove declaration.
15514         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15515         compunit_filetabs.
15516
15517 2019-01-09  Tom Tromey  <tom@tromey.com>
15518
15519         * symtab.c (lookup_objfile_from_block)
15520         (find_pc_sect_compunit_symtab, search_symbols)
15521         (default_collect_symbol_completion_matches_break_on): Use
15522         objfile_compunits.
15523         * objfiles.h (ALL_COMPUNITS): Remove.
15524         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15525         * cp-support.c (add_symbol_overload_list_qualified): Use
15526         objfile_compunits.
15527         * ada-lang.c (ada_collect_symbol_completion_matches)
15528         (ada_add_global_exceptions): Use objfile_compunits.
15529
15530 2019-01-09  Tom Tromey  <tom@tromey.com>
15531
15532         * source.c (select_source_symtab)
15533         (forget_cached_source_info_for_objfile): Remove declaration.
15534         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15535         declaration.
15536         * maint.c (count_symtabs_and_blocks): Remove declaration.
15537         * cp-support.c (add_symbol_overload_list_qualified): Remove
15538         declaration.
15539         * coffread.c (coff_symtab_read): Remove declaration.
15540         * symtab.c (lookup_symbol_in_objfile_symtabs)
15541         (basic_lookup_transparent_type_1): Use objfile_compunits.
15542         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15543         (info_sources_command, search_symbols)
15544         (default_collect_symbol_completion_matches_break_on)
15545         (make_source_files_completion_list): Remove declaration.
15546         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15547         (ada_collect_symbol_completion_matches)
15548         (ada_add_global_exceptions): Remove declaration.
15549         * linespec.c (iterate_over_all_matching_symtabs): Use
15550         objfile_compunits.
15551         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15552         (class objfile_compunits): New.
15553         (ALL_COMPUNITS): Use objfile_compunits.
15554         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15555         (maintenance_check_symtabs, maintenance_info_line_tables): Use
15556         objfile_compunits.
15557         * objfiles.c (objfile_relocate1): Use objfile_compunits.
15558
15559 2019-01-09  Tom Tromey  <tom@tromey.com>
15560
15561         * symtab.c (search_symbols)
15562         (default_collect_symbol_completion_matches_break_on): Use
15563         objfile_msymbols.
15564         * ada-lang.c (ada_lookup_simple_minsym)
15565         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15566         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15567         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15568         objfile_msymbols.
15569         * coffread.c (coff_symfile_read): Use objfile_msymbols.
15570         * symmisc.c (dump_msymbols): Use objfile_msymbols.
15571         * objc-lang.c (find_methods): Use objfile_msymbols.
15572         (info_selectors_command, info_classes_command): Likewise.
15573         * stabsread.c (scan_file_globals): Use objfile_msymbols.
15574         * objfiles.h (class objfile_msymbols): New.
15575         (ALL_OBJFILE_MSYMBOLS): Remove.
15576         (ALL_MSYMBOLS): Remove.
15577
15578 2019-01-09  Tom Tromey  <tom@tromey.com>
15579
15580         * common/next-iterator.h (next_adapter): Add Iterator template
15581         parameter.
15582         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15583         (class all_objfiles_safe): New.
15584         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15585         * objfiles.c (put_objfile_before): Update comment.
15586         (add_separate_debug_objfile): Likewise.
15587         (free_all_objfiles): Use all_objfiles_safe.
15588         (objfile_purge_solibs): Likewise.
15589
15590 2019-01-09  Tom Tromey  <tom@tromey.com>
15591
15592         * symtab.c (iterate_over_symtabs, matching_obj_sections)
15593         (expand_symtab_containing_pc, lookup_static_symbol)
15594         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15595         (find_symbol_at_address, find_line_symtab, find_main_name): Use
15596         all_objfiles.
15597         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15598         * breakpoint.c (create_overlay_event_breakpoint)
15599         (create_longjmp_master_breakpoint)
15600         (create_std_terminate_master_breakpoint)
15601         (create_exception_master_breakpoint): Use all_objfiles.
15602         * linux-thread-db.c (try_thread_db_load_from_pdir)
15603         (has_libpthread): Use all_objfiles.
15604         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15605         * linespec.c (iterate_over_all_matching_symtabs)
15606         (search_minsyms_for_name): Use all_objfiles.
15607         * maint.c (maintenance_info_sections): Use all_objfiles.
15608         * main.c (captured_main_1): Use all_objfiles.
15609         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15610         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15611         * guile/scm-pretty-print.c
15612         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15613         * solib-spu.c (append_ocl_sos): Use all_objfiles.
15614         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15615         (maintenance_print_msymbols): Use all_objfiles.
15616         * source.c (select_source_symtab): Use all_objfiles.
15617         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15618         * symfile.c (remove_symbol_file_command)
15619         (expand_symtabs_matching, map_symbol_filenames): Use
15620         all_objfiles.
15621         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15622         all_objfiles.
15623         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15624         * objc-lang.c (find_methods): Use all_objfiles.
15625         * objfiles.c (have_partial_symbols, have_full_symbols)
15626         (have_minimal_symbols, qsort_cmp)
15627         (default_iterate_over_objfiles_in_search_order): Use
15628         all_objfiles.
15629         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15630         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15631         (maintenance_check_psymtabs): Use all_objfiles.
15632         (ALL_PSYMTABS): Remove.
15633         * compile/compile-object-run.c (do_module_cleanup): Use
15634         all_objfiles.
15635         * blockframe.c (find_pc_partial_function): Use all_objfiles.
15636         * cp-support.c (add_symbol_overload_list_qualified): Use
15637         all_objfiles.
15638         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15639         Use all_objfiles.
15640         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15641         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15642         all_objfiles.
15643         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15644         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15645         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15646         Uses all_objfiles.
15647         * solib.c (solib_read_symbols): Use all_objfiles
15648
15649 2019-01-09  Tom Tromey  <tom@tromey.com>
15650
15651         * probe.c (parse_probes_in_pspace): Use all_objfiles.
15652         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15653         all_objfiles.
15654         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15655         * symmisc.c (print_symbol_bcache_statistics)
15656         (print_objfile_statistics, maintenance_print_objfiles)
15657         (maintenance_info_symtabs, maintenance_check_symtabs)
15658         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15659         all_objfiles.
15660         * source.c (forget_cached_source_info): Use all_objfiles.
15661         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15662         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15663         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15664         * objfiles.c (update_section_map): Use all_objfiles.
15665         (shared_objfile_contains_address_p): Likewise.
15666         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15667         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15668
15669 2019-01-09  Tom Tromey  <tom@tromey.com>
15670
15671         * common/next-iterator.h: New file.
15672         * objfiles.h (class all_objfiles): New.
15673         (struct objfile_iterator): New.
15674
15675 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15676
15677         * NEWS: Move the description of the changed "frame", "select-frame",
15678          and "info frame" commands to the Changed commands section.
15679
15680 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
15681
15682         * gdbtypes.c (check_stub_method_group): Remove handling of old
15683         mangling schemes.
15684         * linespec.c (find_methods): Likewise.
15685         * stabsread.c (read_member_functions): Likewise.
15686         * valops.c (search_struct_method): Likewise.
15687         (value_struct_elt_for_reference): Likewise.
15688         * NEWS: Mention this change.
15689
15690 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
15691
15692         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
15693         print_source_lines.
15694         * source.c (print_source_lines_base): Update line number check.
15695         (print_source_lines): New function.
15696         (source_lines_range::source_lines_range): New function.
15697         * source.h (class source_lines_range): New class.
15698         (print_source_lines): New declaration.
15699
15700 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15701
15702         * linespec.c (linespec_state_destructor): Free self->canonical_names.
15703
15704 2019-01-08  Tom Tromey  <tom@tromey.com>
15705             Simon Marchi  <simon.marchi@ericsson.com>
15706
15707         PR gdb/24060
15708         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
15709         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
15710         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15711         * f-exp.y (DOLLAR_VARIABLE): Likewise.
15712         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
15713         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
15714
15715 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15716
15717         * source.c (select_source_symtab): Move header comment to
15718         declaration in source.h.
15719         (forget_cached_source_info_for_objfile): Likewise.
15720         (forget_cached_source_info): Likewise.
15721         (identify_source_line): Likewise.
15722         * source.h (identify_source_line): Move declaration from symtab.h
15723         and add comment from source.c
15724         (print_source_lines): Likewise.
15725         (forget_cached_source_info_for_objfile): Likewise.
15726         (forget_cached_source_info): Likewise.
15727         (select_source_symtab): Likewise.
15728         (enum print_source_lines_flag): Move definition from symtab.h.
15729         * symtab.h (identify_source_line): Move declaration to source.h.
15730         (print_source_lines): Likewise.
15731         (forget_cached_source_info_for_objfile): Likewise.
15732         (forget_cached_source_info): Likewise.
15733         (select_source_symtab): Likewise.
15734         (enum print_source_lines_flag): Move definition to source.h.
15735         * tui/tui-hooks.c: Add 'source.h' include.
15736
15737 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15738
15739         * source.c (print_source_lines_base): Handle requests to print
15740         reverse line number sequences, and guard against empty lines
15741         string.
15742
15743 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
15744
15745         * source.c (print_source_lines_base): Fix skip of '\r' if next
15746         character is '\n'.
15747
15748 2019-01-06  Tom Tromey  <tom@tromey.com>
15749
15750         * c-exp.y (struct c_parse_state) <macro_original_text,
15751         expansion_obstack>: New member.
15752         (macro_original_text, expansion_obstack): Remove globals.
15753         (scan_macro_expansion, scanning_macro_expansion)
15754         (finished_macro_expansion): Update.
15755         (scan_macro_cleanup): Remove.
15756         (yylex, c_parse): Update.
15757
15758 2019-01-06  Tom Tromey  <tom@tromey.com>
15759
15760         * c-exp.y (struct c_parse_state) <strings>: New member.
15761         (operator_stoken): Update.
15762
15763 2019-01-06  Tom Tromey  <tom@tromey.com>
15764
15765         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
15766         (union type_stack_elt) <typelist_val>: Now a pointer to
15767         std::vector.
15768         (type_stack_cleanup): Don't declare.
15769         (push_typelist): Update.
15770         * parse.c (pop_typelist): Return a std::vector.
15771         (push_typelist): Take a std::vector.
15772         (follow_types): Update.  Do not free args.
15773         (type_stack_cleanup): Remove.
15774         * c-exp.y (struct c_parse_state): New.
15775         (cpstate): New global.
15776         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
15777         (nonempty_typelist): Update.
15778         (func_mod): Create a new vector.
15779         (c_parse): Create a c_parse_state.
15780         (check_parameter_typelist): Do not delete params.
15781         (function_method): Update.  Do not delete type_list.
15782
15783 2019-01-06  Tom Tromey  <tom@tromey.com>
15784
15785         PR gdb/28155:
15786         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
15787         check_typedef.
15788         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
15789         (print_return_value): Likewise.
15790
15791 2019-01-05  Tom Tromey  <tom@tromey.com>
15792
15793         * contrib/cleanup_check.py: Remove.
15794         * contrib/gcc-with-excheck: Remove.
15795         * contrib/exsummary.py: Remove.
15796         * contrib/excheck.py: Remove.
15797
15798 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
15799
15800         * thread.c (delete_thread_1): Add gdb_assert that THR is not
15801         NULL. Initialize tpprev to NULL instead of assigning it
15802         to NULL on the next statement.
15803         * windows-nat.c (windows_delete_thread): Remove check for
15804         main_thread_id before printing thread exit notifications.
15805         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
15806         Remove thread ID check against main_thread_id.
15807         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
15808         windows_delete_thread.
15809         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
15810
15811 2019-01-04  Tom Tromey  <tom@tromey.com>
15812
15813         * compile/compile.c (_initialize_compile): Use upper case for
15814         metasyntactic variables.
15815         * symmisc.c (_initialize_symmisc): Use upper case for
15816         metasyntactic variables.
15817         * psymtab.c (_initialize_psymtab): Use upper case for
15818         metasyntactic variables.
15819         * demangle.c (demangle_command): Use upper case for metasyntactic
15820         variables.
15821         (_initialize_demangler): Likewise.
15822         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
15823         variables.
15824
15825 2019-01-03  Tom Tromey  <tom@tromey.com>
15826
15827         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
15828
15829 2019-01-03  Tom Tromey  <tom@tromey.com>
15830
15831         * python/py-symtab.c (salpy_str): Update.
15832         (struct salpy_sal_object) <symtab>: Now a PyObject.
15833         (salpy_dealloc): Update.
15834         (del_objfile_sal): Use gdbpy_ref.
15835
15836 2019-01-03  Tom Tromey  <tom@tromey.com>
15837
15838         * python/py-type.c (convert_field): Use new_reference.  Return
15839         gdbpy_ref.
15840         (make_fielditem): Return gdbpy_ref.
15841         (typy_fields): Update.
15842         (typy_getitem): Update.
15843         (field_name): Return gdbpy_ref.  Use new_reference.
15844         (typy_iterator_iternext): Update.
15845
15846 2019-01-03  Tom Tromey  <tom@tromey.com>
15847
15848         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
15849
15850 2019-01-03  Tom Tromey  <tom@tromey.com>
15851
15852         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
15853         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
15854         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
15855         (pspy_set_frame_filters, pspy_set_frame_unwinders)
15856         (pspy_set_type_printers): Likewise.
15857         * python/py-function.c (fnpy_init): Use gdbpy_ref.
15858         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
15859         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
15860         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
15861         (objfpy_set_type_printers): Likewise.
15862
15863 2019-01-03  Tom Tromey  <tom@tromey.com>
15864
15865         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
15866         (gdbpy_print_stack): Use gdbpy_err_fetch.
15867         * python/python-internal.h (class gdbpy_err_fetch): New class.
15868         (class gdbpy_enter) <m_error_type, m_error_value,
15869         m_error_traceback>: Remove.
15870         <m_error>: New member.
15871         (gdbpy_exception_to_string): Don't declare.
15872         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
15873         * python/py-value.c (convert_value_from_python): Use
15874         gdbpy_err_fetch.
15875         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
15876         gdbpy_exception_to_string.
15877         (gdbpy_handle_exception): Use gdbpy_err_fetch.
15878         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
15879         gdbpy_err_fetch.
15880
15881 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15882
15883         * linux-nat.c (delete_lwp_cleanup): Delete.
15884         (struct lwp_deleter): New struct.
15885         (lwp_info_up): New typedef.
15886         (linux_nat_target::follow_fork): Delete cleanup, and make use of
15887         lwp_info_up.
15888
15889 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15890
15891         * linux-fork.c (class scoped_switch_fork_info): New class.
15892         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
15893
15894 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15895
15896         * valops.c (find_overload_match): Remove use of null_cleanup, and
15897         calls to do_cleanups.
15898
15899 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15900
15901         * compile/compile-cplus-types.c
15902         (compile_cplus_instance::decl_name): Handle changes to
15903         cp_func_name.
15904         * cp-support.c (cp_func_name): Update header comment, update
15905         return type.
15906         * cp-support.h (cp_func_name): Update return type in declaration.
15907         * valops.c (find_overload_match): Move temp_func local to top
15908         level of function and change its type.  Use temp_func to hold and
15909         delete temporary string obtained from cp_func_name.
15910
15911 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
15912
15913         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
15914         gdb::char_vector, remove cleanup, and update uses of `msg`.
15915
15916 2019-01-03  Jim Wilson  <jimw@sifive.com>
15917
15918         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
15919
15920 2019-01-02  Tom Tromey  <tom@tromey.com>
15921
15922         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
15923         (tdesc_parse_xml): Remove cleanups.
15924         * target-descriptions.h (make_cleanup_free_target_description):
15925         Don't declare.
15926         (target_desc_deleter): New struct.
15927         (target_desc_up): New typedef.
15928         * target-descriptions.c (target_desc_deleter::operator()): Rename
15929         from free_target_description.
15930         (make_cleanup_free_target_description): Remove.
15931
15932 2019-01-02  Tom Tromey  <tom@tromey.com>
15933
15934         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
15935         constructor, destructor.
15936         (linespec_parser): Remove typedef.
15937         (~linespec_parser): Rename from linespec_parser_delete.
15938         (linespec_lex_to_end, linespec_complete_label)
15939         (linespec_complete): Update.
15940         (decode_line_full): Remove cleanups.
15941         (decode_line_1): Update.
15942
15943 2019-01-02  Tom Tromey  <tom@tromey.com>
15944
15945         * python/python-internal.h (inferior_to_inferior_object): Change
15946         return type.
15947         * python/py-exitedevent.c (create_exited_event_object): Update.
15948         * python/py-inferior.c (inferior_to_inferior_object): Return
15949         gdbpy_ref.
15950         (python_new_inferior, python_inferior_deleted)
15951         (thread_to_thread_object, delete_thread_object)
15952         (build_inferior_list, gdbpy_selected_inferior): Update.
15953         * python/py-infthread.c (create_thread_object): Update.  Also fail
15954         if inferior_to_inferior_object fails.
15955
15956 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
15957
15958         * inferior.h (class inferior) <displaced_step_state>: New field.
15959         * infrun.h (struct displaced_step_state): Move here from
15960         infrun.c.  Initialize fields, add constructor.
15961         <inf>: Remove field.
15962         <reset>: New method.
15963         * infrun.c (struct displaced_step_inferior_state): Move to
15964         infrun.h.
15965         (displaced_step_inferior_states): Remove.
15966         (get_displaced_stepping_state): Adust.
15967         (displaced_step_in_progress_any_inferior): Adjust.
15968         (displaced_step_in_progress_thread): Adjust.
15969         (displaced_step_in_progress): Adjust.
15970         (add_displaced_stepping_state): Remove.
15971         (get_displaced_step_closure_by_addr): Adjust.
15972         (remove_displaced_stepping_state): Remove.
15973         (infrun_inferior_exit): Call displaced_step_state.reset.
15974         (use_displaced_stepping): Don't check for NULL.
15975         (displaced_step_prepare_throw): Call
15976         get_displaced_stepping_state.
15977         (displaced_step_fixup): Don't check for NULL.
15978         (prepare_for_detach): Don't check for NULL.
15979
15980 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15981
15982         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
15983          in case of call that did not complete.
15984
15985 2019-01-02  Andrey Utkin  <autkin@undo.io>
15986
15987         * symfile.c (find_separate_debug_file): Fix search of debug files for
15988         remote debuggee.
15989
15990 2019-01-02  Tom Tromey  <tom@tromey.com>
15991
15992         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
15993         indentation.
15994         * python/py-frame.c (frapy_older): Remove cast.
15995         (frapy_newer): Likewise.
15996         * python/py-breakpoint.c (local_setattro): Remove cast.
15997         * python/py-arch.c (archpy_name): Remove local variable.
15998         * python/py-type.c (gdbpy_lookup_type): Remove cast.
15999
16000 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
16001
16002         * unittests/basic_string_view/element_access/char/empty.cc:
16003         Fix year range in copyright header.
16004
16005 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
16006
16007         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16008         Delete.
16009         <operator==>: Update with for removed field.
16010         <hash>: Likewise.
16011         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16012         <isa_features>: ...this.
16013         <abi_features>: New field.
16014         (riscv_isa_flen): Update comment.
16015         (riscv_abi_xlen): New declaration.
16016         (riscv_abi_flen): New declaration.
16017         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16018         isa_features.
16019         (riscv_abi_xlen): New function.
16020         (riscv_isa_flen): Update to get answer from isa_features.
16021         (riscv_abi_flen): New function.
16022         (riscv_has_fp_abi): Update to get answer from abi_features.
16023         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16024         xlen and flen.
16025         (riscv_call_info) <xlen, flen>: Update comment.
16026         (riscv_call_arg_struct): Remove invalid assertions
16027         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16028         is removed.
16029         (riscv_gdbarch_init): Gather isa features and abi features
16030         separately, ensure both match on the gdbarch when reusing an old
16031         gdbarch.  Relax an error check to allow 32-bit abi float to run on
16032         a target with 64-bit float hardware.
16033
16034 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16035
16036         * source.c (search_command_helper): Stop reverse search
16037         when line 1 has been searched.
16038
16039 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16040
16041         * record-full.c (record_full_base_target::close): Rewrite
16042         record_full_core_buf_list free logic.
16043
16044 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16045
16046         * break-catch-syscall.c (print_one_catch_syscall): xfree
16047         the last text.
16048
16049 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16050
16051         * top.c (print_gdb_version): Update Copyright year in version
16052         message.
16053
16054 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
16055
16056         Update copyright year range in all GDB files.
16057
16058 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
16059
16060         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16061
16062 For older changes see ChangeLog-2018.
16063 \f
16064 Local Variables:
16065 mode: change-log
16066 left-margin: 8
16067 fill-column: 74
16068 version-control: never
16069 coding: utf-8
16070 End:
16071