gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_update_source_window)
   4         (tui_update_source_window_as_is): Change parameter type.
   5         * tui/tui-winsource.c (tui_update_source_window): Change win_info
   6         to be a tui_source_window_base.
   7         (tui_update_source_window_as_is): Likewise.
   8         * tui/tui-win.c (make_visible_with_new_height): Update.
   9
  10 2019-06-25  Tom Tromey  <tom@tromey.com>
  11
  12         * tui/tui-winsource.c (tui_erase_source_content)
  13         (tui_show_source_content, tui_show_exec_info_content)
  14         (tui_erase_exec_info_content): Use refresh_window method.
  15         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
  16         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
  17         from tui_refresh_win.
  18         (tui_data_window::refresh_window): New method.
  19         (tui_win_info::refresh, tui_source_window_base::refresh)
  20         (tui_refresh_all): Use refresh_window method.
  21         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
  22         method.
  23         * tui/tui-regs.c (tui_display_register): Call refresh_window
  24         method.
  25         * tui/tui-layout.c (show_source_disasm_command)
  26         (show_source_or_disasm_and_command): Call refresh_window method.
  27         * tui/tui-data.h (struct tui_gen_win_info)
  28         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
  29         New method.
  30
  31 2019-06-25  Tom Tromey  <tom@tromey.com>
  32
  33         * tui/tui.c (tui_rl_other_window, tui_enable)
  34         (tui_is_window_visible, tui_get_command_dimension): Update.
  35         * tui/tui-winsource.c (tui_update_source_window_as_is)
  36         (tui_clear_source_content, tui_erase_source_content)
  37         (tui_show_source_line, tui_source_window_base::refill)
  38         (tui_source_window_base::do_scroll_horizontal)
  39         (tui_source_window_base::set_is_exec_point_at)
  40         (tui_update_breakpoint_info, tui_set_exec_info_content)
  41         (tui_alloc_source_buffer, tui_line_is_displayed)
  42         (tui_addr_is_displayed): Update.
  43         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  44         (tui_check_and_display_highlight_if_needed)
  45         (tui_win_info::make_visible, tui_win_info::refresh)
  46         (tui_refresh_all): Update.
  47         * tui/tui-windata.c (tui_first_data_item_displayed)
  48         (tui_delete_data_content_windows, tui_erase_data_content)
  49         (tui_display_all_data, tui_data_window::refresh_all)
  50         (tui_check_data_values): Update.
  51         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
  52         (tui_set_win_focus_to, tui_win_info::forward_scroll)
  53         (tui_win_info::backward_scroll, tui_refresh_all_win)
  54         (tui_resize_all, tui_set_focus, tui_all_windows_info)
  55         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
  56         (tui_source_window_base::set_new_height)
  57         (tui_data_window::set_new_height)
  58         (make_invisible_and_set_new_height)
  59         (make_visible_with_new_height, new_height_ok)
  60         (parse_scrolling_args): Update.
  61         * tui/tui-stack.c (tui_show_frame_info): Update.
  62         * tui/tui-source.c (tui_set_source_content)
  63         (tui_set_source_content_nil, tui_source_is_displayed)
  64         (tui_source_window::do_scroll_vertical): Update.
  65         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
  66         (tui_display_registers_from, tui_display_reg_element_at_line)
  67         (tui_check_register_values, tui_reg_command): Update.
  68         * tui/tui-layout.c (tui_default_win_height)
  69         (show_source_disasm_command, show_data, init_and_make_win)
  70         (show_source_or_disasm_and_command): Update.
  71         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
  72         (tui_redisplay_readline, tui_mld_flush)
  73         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
  74         (tui_getc): Update.
  75         * tui/tui-disasm.c (tui_set_disassem_content)
  76         (tui_disasm_window::do_scroll_vertical): Update.
  77         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
  78         Now virtual.
  79         (struct tui_win_info): Derive from tui_gen_win_info.
  80         <~tui_win_info>: Mark as override.
  81         <generic>: Remove member.
  82         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
  83         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
  84         (~tui_data_window, ~tui_win_info)
  85         (tui_free_all_source_wins_content): Update.
  86         * tui/tui-command.c (tui_refresh_cmd_win): Update.
  87
  88 2019-06-25  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-layout.c (init_and_make_win): Use new.
  91         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
  92         destructor, initializers.
  93         (tui_alloc_generic_win_info): Don't declare.
  94         * tui/tui-data.c (_locator): Add argument to constructor.
  95         (source_win, disasm_win): New globals.
  96         (exec_info): Remove.
  97         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
  98         Update.
  99         (tui_alloc_generic_win_info): Remove.
 100         (init_content_element): Use new.
 101         (tui_win_info::tui_win_info): Update.
 102         (free_content_elements) <case DATA_WIN>: Use delete.
 103
 104 2019-06-25  Tom Tromey  <tom@tromey.com>
 105
 106         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 107         * tui/tui-windata.c (tui_first_data_item_displayed)
 108         (tui_delete_data_content_windows): Update.
 109         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 110         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 111         (tui_display_registers_from, tui_check_register_values): Update.
 112         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 113         pointer.
 114         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 115         window.
 116         (tui_free_data_content): Update.
 117         (free_content_elements) <case DATA_WIN>: Free the window.
 118
 119 2019-06-25  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 122         Update.
 123         * tui/tui-layout.c (make_command_window)
 124         (show_source_disasm_command, show_data, init_and_make_win)
 125         (show_source_or_disasm_and_command): Update.
 126         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 127         method.
 128         <can_highight, is_highlighted>: Now bool.
 129         (tui_set_win_highlight): Don't declare.
 130         * tui/tui-data.c (tui_set_win_highlight): Remove.
 131
 132 2019-06-25  Tom Tromey  <tom@tromey.com>
 133
 134         * tui/tui-wingeneral.c (make_visible): Remove check of window
 135         type.
 136
 137 2019-06-25  Tom Tromey  <tom@tromey.com>
 138
 139         * tui/tui-win.c (tui_win_info::max_height)
 140         (tui_cmd_window::max_height): New methods.
 141         (new_height_ok): Call max_height.
 142         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 143         <max_height>: New method.
 144
 145 2019-06-25  Tom Tromey  <tom@tromey.com>
 146
 147         * tui/tui-win.c (tui_source_window_base::set_new_height)
 148         (tui_data_window::set_new_height): New methods.
 149         (make_invisible_and_set_new_height): Call set_new_height method.
 150         * tui/tui-data.h (struct tui_win_info)
 151         (struct tui_source_window_base, struct tui_data_window)
 152         <set_new_height>: New method.
 153
 154 2019-06-25  Tom Tromey  <tom@tromey.com>
 155
 156         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 157         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 158         tui_refresh_data_win.
 159         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 160         method.
 161         (tui_refresh_all_win): Call the refresh_all method.
 162         (tui_set_focus): Likewise.
 163         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 164         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 165         Likewise.
 166
 167 2019-06-25  Tom Tromey  <tom@tromey.com>
 168
 169         * tui/tui-winsource.h (tui_refill_source_window)
 170         (tui_set_is_exec_point_at): Don't declare.
 171         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 172         (tui_source_window_base::refill): Rename from
 173         tui_refill_source_window.
 174         (tui_source_window_base::do_scroll_horizontal): Update.
 175         (tui_source_window_base::set_is_exec_point_at): Rename from
 176         tui_set_is_exec_point_at.
 177         (tui_update_all_breakpoint_info): Update.
 178         * tui/tui-stack.c (tui_show_frame_info): Update.
 179         * tui/tui-layout.c (show_data): Add cast.
 180         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 181         * tui/tui-data.h (struct tui_source_window_base) <refill,
 182         set_is_exec_point_at>: New methods.
 183         (tui_source_windows, tui_add_to_source_windows): Update types.
 184         (tui_add_to_source_windows): Remove redundant declaration.
 185         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 186         (tui_source_windows): Change return type.
 187         (tui_clear_source_windows_detail): Update.
 188         (tui_add_to_source_windows): Change type of parameter.
 189         (tui_free_all_source_wins_content): Update.
 190
 191 2019-06-25  Tom Tromey  <tom@tromey.com>
 192
 193         * tui/tui-wingeneral.c (tui_win_info::refresh)
 194         (tui_source_window_base::refresh): New methods.
 195         (tui_refresh_all): Call the refresh method.
 196         * tui/tui-data.h (struct tui_win_info)
 197         (struct tui_source_window_base) <refresh>: New method.
 198
 199 2019-06-25  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui.h (tui_is_window_visible): Return bool.
 202         * tui/tui.c (tui_is_window_visible): Return bool.
 203         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 204         (tui_make_visible, tui_make_invisible)
 205         (tui_win_info::make_visible)
 206         (tui_source_window_base::make_visible, make_all_visible)
 207         (tui_make_all_visible, tui_make_all_invisible): Update.
 208         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 209         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 210         bool.
 211         (struct tui_win_info, struct tui_source_window_base)
 212         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 213         * tui/tui-data.c (tui_init_generic_part): Update.
 214
 215 2019-06-25  Tom Tromey  <tom@tromey.com>
 216
 217         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 218         (tui_source_window_base::make_visible): New methods.
 219         (make_all_visible): Make method call.
 220         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 221         (struct tui_source_window_base, struct tui_cmd_window): Override
 222         make_visible.
 223         (tui_win_is_source_type): Don't declare.
 224         * tui/tui-data.c (tui_win_is_source_type): Remove.
 225
 226 2019-06-25  Tom Tromey  <tom@tromey.com>
 227
 228         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 229         NULL check.
 230
 231 2019-06-25  Tom Tromey  <tom@tromey.com>
 232
 233         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 234         Inline constructor.  Add initializers for members.
 235         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 236         constructors; now inline in class.
 237
 238 2019-06-25  Tom Tromey  <tom@tromey.com>
 239
 240         * tui/tui-regs.c (tui_show_registers): Update.
 241         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 242         bool.
 243         * tui/tui-data.c (tui_data_window::clear_detail)
 244         (tui_data_window): Update.
 245
 246 2019-06-25  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-windata.c (tui_display_all_data)
 249         (tui_display_data_from_line, tui_display_data_from)
 250         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 251         Update.
 252         * tui/tui-regs.c (tui_last_regs_line_no)
 253         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 254         (tui_show_registers, tui_show_register_group)
 255         (tui_display_registers_from, tui_display_reg_element_at_line)
 256         (tui_display_registers_from_line, tui_check_register_values)
 257         (tui_reg_next, tui_reg_prev): Update.
 258         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 259         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 260         tui_data_window.
 261         (struct tui_win_info) <detail>: Remove.  Add new fields from
 262         tui_data_info.
 263         (TUI_DATA_WIN): Add cast.
 264         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 265         (~tui_data_window): Simplify.
 266
 267 2019-06-25  Tom Tromey  <tom@tromey.com>
 268
 269         * tui/tui-layout.c (show_source_disasm_command)
 270         (show_source_or_disasm_and_command): Update.
 271         * tui/tui-io.c (update_cmdwin_start_line)
 272         (tui_redisplay_readline): Update.
 273         * tui/tui-data.h (struct tui_command_info): Remove.
 274         (struct tui_win_info) <detail>: Remove command_info member.
 275         (struct tui_data_window) <start_line>: New member, from
 276         tui_command_info.
 277         (TUI_CMD_WIN): Add casts.
 278
 279 2019-06-25  Tom Tromey  <tom@tromey.com>
 280
 281         * tui/tui-winsource.c (tui_update_source_window)
 282         (tui_refill_source_window)
 283         (tui_source_window_base::do_scroll_horizontal)
 284         (tui_update_breakpoint_info, tui_set_exec_info_content)
 285         (tui_show_exec_info_content, tui_erase_exec_info_content)
 286         (tui_clear_exec_info_content): Update.
 287         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 288         Update.
 289         * tui/tui-win.c (make_invisible_and_set_new_height)
 290         (make_visible_with_new_height): Update.
 291         * tui/tui-source.c (tui_set_source_content)
 292         (tui_show_symtab_source): Update.
 293         * tui/tui-layout.c (extract_display_start_addr)
 294         (show_source_disasm_command, show_data)
 295         (make_source_or_disasm_window)
 296         (show_source_or_disasm_and_command): Update.
 297         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 298         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 299         "gdbarch".
 300         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 301         to tui_source_window_base.
 302         (struct tui_win_info) <detail>: Remove source_info member.
 303         (struct tui_source_window_base) <has_locator>: Inline.
 304         Move contents from tui_source_info; rename has_locator member to
 305         m_has_locator.
 306         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 307         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 308         header file.
 309         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 310         Simplify.
 311         (tui_free_all_source_wins_content): Cast to
 312         tui_source_window_base.
 313
 314 2019-06-25  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-win.c (make_invisible_and_set_new_height)
 317         (make_visible_with_new_height): Call has_locator method.
 318         * tui/tui-layout.c (show_source_disasm_command, show_data)
 319         (show_source_or_disasm_and_command): Update for bool change.
 320         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 321         (tui_win_info) <has_locator>: New method.
 322         (struct tui_source_window_base) <has_locator>: New method.
 323         (tui_win_has_locator): Don't declare.
 324         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 325         from tui_win_has_locator.
 326         (tui_source_window_base): Use false, not FALSE.
 327
 328 2019-06-25  Tom Tromey  <tom@tromey.com>
 329
 330         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 331         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 332         clear_detail method directly.
 333         (tui_clear_win_detail): Remove.
 334
 335 2019-06-25  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 338         "this", not TUI_DISASM_WIN.
 339
 340 2019-06-25  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 343         declare.
 344         * tui/tui-winsource.c
 345         (tui_source_window_base::do_scroll_horizontal): Rename from
 346         tui_horizontal_source_scroll.
 347         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 348         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 349         from tui_vertical_data_scroll.
 350         * tui/tui-win.h (tui_scroll): Don't declare.
 351         * tui/tui-win.c (tui_win_info::forward_scroll)
 352         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 353         (tui_win_info::right_scroll): Rename and update.
 354         (tui_scroll_forward_command, tui_scroll_backward_command)
 355         (tui_scroll_left_command, tui_scroll_right_command): Update.
 356         (tui_scroll): Remove.
 357         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 358         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 359         from tui_vertical_source_scroll.
 360         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 361         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 362         from tui_vertical_disassem_scroll.
 363         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 364         do_scroll_horizontal>: New methods.
 365         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 366         Likewise.
 367         (struct tui_source_window_base): Add do_scroll_horizontal.
 368         (struct tui_source_window, struct tui_disasm_window): Add
 369         do_scroll_vertical.
 370         (struct tui_data_window, struct tui_cmd_window): Add
 371         do_scroll_horizontal and do_scroll_vertical.
 372         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 373
 374 2019-06-25  Tom Tromey  <tom@tromey.com>
 375
 376         * tui/tui-data.h (struct tui_source_window_base): New struct.
 377         (struct tui_source_window): Derive from tui_source_window_base.
 378         (struct tui_disasm_window): New struct.
 379         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 380         from tui_source_window::clear_detail.
 381         (tui_source_window_base): Rename from tui_source_window.
 382         (~tui_source_window_base): Rename from ~tui_source_window.
 383         (tui_alloc_win_info): Create a tui_disasm_window.
 384
 385 2019-06-25  Tom Tromey  <tom@tromey.com>
 386
 387         * tui/tui-data.h (struct tui_source_window)
 388         (struct tui_data_window): Declare destructors.
 389         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 390         destructors.
 391         (tui_win_info): Simplify.
 392
 393 2019-06-25  Tom Tromey  <tom@tromey.com>
 394
 395         * tui/tui-winsource.c (tui_display_main)
 396         (tui_update_source_windows_with_addr)
 397         (tui_update_all_breakpoint_info): Update.
 398         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 399         (new_height_ok, parse_scrolling_args): Update.
 400         * tui/tui-stack.c (tui_show_frame_info): Update.
 401         * tui/tui-data.h (struct tui_list): Remove.
 402         (tui_source_windows): Return a reference to a std::vector.
 403         * tui/tui-data.c (source_windows): Now a std::vector.
 404         (tui_source_windows): Change return type.
 405         (tui_clear_source_windows): Rewrite.
 406         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 407         (tui_free_all_source_wins_content): Rewrite.
 408
 409 2019-06-25  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 412         (struct tui_data_window, struct tui_cmd_window): Declare
 413         clear_detail method.
 414         * tui/tui-data.c (tui_source_window::clear_detail)
 415         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 416         methods.
 417         (tui_clear_win_detail): Simplify.
 418
 419 2019-06-25  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-layout.c (make_source_window, make_disasm_window)
 422         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 423         Return the new window.
 424         (show_source_disasm_command, show_data)
 425         (show_source_or_disasm_and_command): Update.
 426
 427 2019-06-25  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 430         parameter.  Return the new window.
 431         (show_source_disasm_command): Update and remove NULL check.
 432         (show_source_or_disasm_and_command): Update.
 433
 434 2019-06-25  Tom Tromey  <tom@tromey.com>
 435
 436         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 437
 438 2019-06-25  Tom Tromey  <tom@tromey.com>
 439
 440         * tui/tui-data.h (struct tui_win_info): Make constructor
 441         protected.  Make destructor virtual.  Add initializers.
 442         (tui_source_window, tui_data_window, tui_cmd_window): New
 443         classes.
 444         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 445         constructor.  Add "type" parameter.
 446         (tui_source_window, tui_data_window, tui_cmd_window): New
 447         constructors.
 448         (tui_alloc_win_info): Instantiate the appropriate subclass.
 449
 450 2019-06-25  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-win.c (tui_resize_all): Use delete.
 453         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 454         destructor.
 455         (tui_free_window): Don't declare.
 456         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 457         Update.
 458
 459 2019-06-25  Tom Tromey  <tom@tromey.com>
 460
 461         * tui/tui-data.h (struct tui_win_info): Add constructor.
 462         * tui/tui-data.c (tui_alloc_win_info): Use new.
 463         (tui_free_window): Use delete.
 464
 465 2019-06-22  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 468         declare.
 469         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 470
 471 2019-06-22  Tom Tromey  <tom@tromey.com>
 472
 473         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 474         declare.
 475         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 476
 477 2019-06-22  Tom de Vries  <tdevries@suse.de>
 478
 479         * dwarf2read.c (create_addrmap_from_aranges)
 480         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 481         instead of '%zu'.
 482
 483 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 484
 485         * dwarf2read.h (dwarf2_section_info_def): Remove.
 486         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 487         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 488         std::vector<dwarf2_section_info>.
 489         (struct dwo_file) <~dwo_file>: Remove.
 490         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 491         types field.
 492         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 493         (dwarf2_read_debug_names): Likewise.
 494         (create_debug_types_hash_table): Change parameter type to
 495         array_view, adjust code accordingly.
 496         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 497         (partial_die_info::fixup): Likewise.
 498         (determine_prefix): Likewise.
 499         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 500
 501 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 502
 503         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 504         gdb_bfd_ref_ptr.
 505         <~dwo_file>: Remove call to gdb_bfd_unref.
 506         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 507         gdb_bfd_ref_ptr::get.
 508
 509 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 510
 511         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 512         type to htab_up.
 513         * dwarf2read.c (struct dwo_file): Initialize fields.
 514         <~dwo_file>: New.
 515         (free_dwo_file): Remove, move content to ~dwo_file.
 516         (struct dwo_file_deleter): Remove.
 517         (dwo_file_up>: Remove custom deleter.
 518         (free_dwo_files): Remove.
 519         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 520         dwo_files.
 521         (process_skeletonless_type_units): Call unique_ptr::get.
 522         (allocate_dwo_file_hash_table): Add deleter to created hash
 523         table.  Change return type to htab_up.
 524         (lookup_dwo_file_slot): Don't memset dwo_file, call
 525         unique_ptr::get.
 526         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 527         (create_dwo_unit_in_dwp_v2): Likewise.
 528         (open_and_init_dwo_file): Likewise.
 529         (free_dwo_file_from_slot): Remove.
 530
 531 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 532
 533         * dwarf2read.h (struct dwarf2_section_info) <readin,
 534         is_virtual>: Change type to bool.
 535         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 536         true instead of 1.
 537
 538 2019-06-19  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-data.h (tui_init_content_element): Don't declare.
 541
 542 2019-06-19  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-data.h (tui_init_win_info): Don't declare.
 545
 546 2019-06-19  Tom de Vries  <tdevries@suse.de>
 547
 548         * dwarf2read.h (abstract_to_concrete): Change type to
 549         std::unordered_map<sect_offset, std::vector<sect_offset>,
 550         gdb::hash_enum<sect_offset>>.
 551
 552 2019-06-19  Tom Tromey  <tromey@adacore.com>
 553
 554         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 555         EVAL_AVOID_SIDE_EFFECTS specially.
 556
 557 2019-06-19  Tom Tromey  <tromey@adacore.com>
 558
 559         * source-cache.c (highlighter): New global.
 560         (source_cache::get_source_lines): Create a highlighter on demand.
 561
 562 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 563
 564         * defs.h (deprecated_interactive_hook): Delete declaration.
 565         * interps.c (clear_interpreter_hooks): Remove use of
 566         deprecated_interactive_hook.
 567         * top.c (deprecated_interactive_hook): Delete definition.
 568         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 569
 570 2019-06-18  Tom de Vries  <tdevries@suse.de>
 571
 572         PR gdb/24515
 573         * dwarf2read.h (abstract_to_concrete): Change type from
 574         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 575         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 576         * dwarf2read.c (read_variable): Update.
 577         (dwarf2_fetch_die_loc_sect_off): Update.
 578
 579 2019-06-17  Tom de Vries  <tdevries@suse.de>
 580
 581         PR gdb/24617
 582         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 583         accessing parent[parent_len - 1].
 584
 585 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 586
 587         PR gdb/24364
 588         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 589         call dtrace_process_dof with NULL dof.
 590
 591 2019-06-16  Tom de Vries  <tdevries@suse.de>
 592
 593         PR gdb/24445
 594         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 595
 596 2019-06-16  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 599         (make_all_visible): Use address of member.
 600
 601 2019-06-16  Tom Tromey  <tom@tromey.com>
 602
 603         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 604         (tui_free_window, free_content, free_content_elements): Remove
 605         unnecessary cast.
 606         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 607         cast.
 608         * tui/tui-regs.c (tui_show_register_group)
 609         (tui_display_registers_from, tui_display_reg_element_at_line):
 610         Remove unnecessary cast.
 611
 612 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 613
 614         * linux-nat.c (normal_mask): Delete.
 615         (_initialize_linux_nat): Don't initialise normal_mask.
 616
 617 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 618
 619         PR gdb/24445
 620         * dwarf-index-write.h (write_psymtabs_to_index): Add
 621         dwz_basename parameter.
 622         * dwarf-index-write.c (write_gdbindex): Move file writing to
 623         write_gdbindex_1.  Change return type void.
 624         (assert_file_size): Move up, remove filename parameter.
 625         (write_gdbindex_1): New function.
 626         (write_debug_names): Change return type to void, call
 627         assert_file_size.
 628         (struct index_wip_file): New struct.
 629         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 630         file logic to index_wip_file.  Write index for dwz file if
 631         needed.
 632         (save_gdb_index_command): Pass basename of dwz file, if present.
 633         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 634         build-id of dwz file, if present.
 635         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 636         (dwarf2_get_dwz_file): Likewise.
 637         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 638         (dwarf2_get_dwz_file): Likewise.
 639
 640 2019-06-16  Tom Tromey  <tom@tromey.com>
 641
 642         * coffread.c (process_coff_symbol): Use xstrdup.
 643         * value.c (create_internalvar): Use xstrdup.
 644
 645 2019-06-16  Tom Tromey  <tom@tromey.com>
 646
 647         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 648         * breakpoint.c (stopin_command, stopat_command)
 649         (until_break_command, decode_location_default): Remove unnecessary
 650         cast.
 651         * utils.c (subset_compare): Remove unnecessary cast.
 652         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 653         cast.
 654         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 655         cast.
 656         * infcmd.c (path_command): Remove unnecessary cast.
 657         * coffread.c (decode_type): Remove unnecessary cast.
 658         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 659         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 660         * tui/tui-stack.c (tui_show_locator_content)
 661         (tui_show_frame_info): Remove unnecessary cast.
 662         * tui/tui-win.c (tui_scroll_forward_command)
 663         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 664         (parse_scrolling_args): Remove unnecessary cast.
 665         * tui/tui-data.c (init_win_info, tui_del_window)
 666         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 667         (free_content_elements): Remove unnecessary cast.
 668         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 669         unnecessary cast.
 670         * tui/tui-source.c (tui_set_source_content)
 671         (tui_vertical_source_scroll): Remove unnecessary cast.
 672         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 673         cast.
 674         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 675         * tui/tui-regs.c (tui_display_registers_from)
 676         (tui_display_register): Remove unnecessary cast.
 677         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 678         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 679         (make_visible): Remove unnecessary cast.
 680         * tui/tui-winsource.c (tui_erase_source_content)
 681         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 682         unnecessary cast.
 683         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 684         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 685         * stabsread.c (read_type, read_array_type, read_range_type):
 686         Remove unnecessary cast.
 687         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 688         (parse_symbol, parse_type, upgrade_type, parse_external)
 689         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 690         unnecessary cast.
 691         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 692
 693 2019-06-16  Tom Tromey  <tom@tromey.com>
 694
 695         * tui/tui-data.c (tui_alloc_generic_win_info)
 696         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 697         checks.
 698
 699 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 700             Andrew Burgess  <andrew.burgess@embecosm.com>
 701
 702         * f-typeprint.c (f_print_type): Don't return early for not
 703         associated or not allocated types.
 704         (f_type_print_varspec_suffix): Add print_rank parameter and print
 705         ranks of array types in case they dangling.
 706         (f_type_print_base): Add print_rank parameter.
 707
 708 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 709
 710         * NEWS: Mention new MI commands.
 711         * break-catch-throw.c (enum exception_event_kind): Move to
 712         breakpoint.h.
 713         (print_mention_exception_catchpoint): Output text as a single
 714         message.
 715         (catch_exception_command_1): Rename to...
 716         (catch_exception_event): ...this, make non-static, update header
 717         command, and change some parameter types.
 718         (catch_catch_command): Update for changes to
 719         catch_exception_command_1.
 720         (catch_throw_command): Likewise.
 721         (catch_rethrow_command): Likewise.
 722         * breakpoint.c (enum exception_event_kind): Delete.
 723         * breakpoint.h (enum exception_event_kind): Moved here from
 724         break-catch-throw.c.
 725         (catch_exception_event): Declare.
 726         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 727         (mi_cmd_catch_throw): New function.
 728         (mi_cmd_catch_rethrow): New function.
 729         (mi_cmd_catch_catch): New function.
 730         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 731         'catch-catch' entries.
 732         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 733         (mi_cmd_catch_rethrow): Declare.
 734         (mi_cmd_catch_catch): Declare.
 735
 736 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 737
 738         * annotate.c (annotate_source_line): Change return type to void,
 739         update implementation to match.
 740         * annotate.h (annotate_source_line): Change return type to void,
 741         update header comment.
 742         * stack.c (print_frame_info): Don't change what frame information
 743         is printed based on whether annotations are on or not.
 744
 745 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 746
 747         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 748         (annotate_source): Make static.
 749         (annotate_source_line): Moved from source.c and renamed from
 750         identify_source_line.  Update the return type.
 751         * annotate.h (annotate_source): Delete declaration.
 752         (annotate_source_line): Declaration moved from source.h, and
 753         renamed from identify_source_line.  Return type updated.
 754         * source.c (identify_source_line): Moved to annotate.c and renamed
 755         to annotate_source_line.
 756         (info_line_command): Remove check of annotation_level.
 757         * source.h (identify_source_line): Move declaration to annotate.h
 758         and rename to annotate_source_line.
 759         * stack.c: Add 'annotate.h' include.
 760         (print_frame_info): Remove check of annotation_level before
 761         calling annotate_source_line.
 762
 763 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 764
 765         * source-cache.c (source_cache::get_plain_source_lines): Use
 766         open_source_file_with_line_charpos instead of just
 767         open_source_file, remove call to find_source_lines.
 768         (source_cache::get_source_lines): Likewise.
 769         * source.c (find_source_lines): Make static.
 770         (get_filename_and_charpos): Renamed into...
 771         (open_source_file_with_line_charpos): ..this along with changes to
 772         return a scoped_fd, and some other minor clean ups.
 773         (identify_source_line): Use open_source_file_with_line_charpos.
 774         (search_command_helper): Use open_source_file_with_line_charpos
 775         instead of just open_source_file, remove call to
 776         find_source_lines.
 777         * source.h (open_source_file_with_line_charpos): Declare new
 778         function.
 779         (find_source_lines): Delete declaration.
 780
 781 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 782
 783         * source.c (get_filename_and_charpos): Remove fullname
 784         parameter.
 785         (identify_source_line): Update call to get_filename_and_charpos.
 786
 787 2019-06-14  Tom Tromey  <tromey@adacore.com>
 788
 789         PR gdb/24502:
 790         * ui-style.h (skip_ansi_escape): Update comment.
 791         * ui-file.h (class no_terminal_escape_file): New class.
 792         * ui-file.c (no_terminal_escape_file::write)
 793         (no_terminal_escape_file::puts): New methods.
 794         * cli/cli-logging.c (handle_redirections): Use
 795         no_terminal_escape_file.
 796
 797 2019-06-14  Tom Tromey  <tromey@adacore.com>
 798
 799         * NEWS: Move convenience variable news above Python news.
 800
 801 2019-06-14  Tom Tromey  <tom@tromey.com>
 802
 803         * gnulib: Move directory to top-level.
 804         * configure.ac: Don't configure gnulib.
 805         * configure: Rebuild.
 806         * common/common-defs.h: Use new path to gnulib.
 807         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 808         (GNULIB_H): Remove.
 809         (INCGNU): Look in new gnulib location.
 810         (HFILES_NO_SRCDIR): Remove gnulib files.
 811         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 812         (generated_files): Remove GNULIB_H.
 813         ($(LIBGNU), all-lib): Remove targets.
 814         (distclean): Don't mention GNULIB_BUILDDIR.
 815         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 816
 817 2019-06-14  Tom Tromey  <tromey@adacore.com>
 818
 819         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 820         Warn if symbol file does not provide any symbols.
 821
 822 2019-06-14  Tom Tromey  <tromey@adacore.com>
 823
 824         * source.c (find_and_open_source): Respect basenames_may_differ.
 825
 826 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 827
 828         * annotate.c (annotate_breakpoints_invalid): Make use of
 829         scoped_restore_terminal_state.
 830         (annotate_frames_invalid): Likewise.
 831
 832 2019-06-14  Tom Tromey  <tromey@adacore.com>
 833
 834         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 835         allow assignment to an internalvar.
 836
 837 2019-06-14  Tom Tromey  <tromey@adacore.com>
 838
 839         * ada-lex.l: Allow "_" in attribute names.
 840
 841 2019-06-14  Tom Tromey  <tromey@adacore.com>
 842
 843         PR gdb/24653:
 844         * regcache.c (registers_changed): Don't call alloca.
 845         * top.c (execute_command): Don't call alloca.
 846
 847 2019-06-13  Pedro Alves  <palves@redhat.com>
 848
 849         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 850         'expression'.  When parsing an expression, error out if there's
 851         junk after "unlimited".
 852         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 853         (do_set_command): Adjust calls to is_unlimited_literal.
 854
 855 2019-06-13  Pedro Alves  <palves@redhat.com>
 856
 857         * compile/compile.c (make_compile_options_def_group): Add braces
 858         around array_view initializer.
 859         * thread.c (make_thread_apply_all_options_def_group)
 860         (make_thread_apply_all_options_def_group): Likewise.
 861
 862 2019-06-13  Pedro Alves  <palves@redhat.com>
 863
 864         * NEWS (New commands): Mention "maint test-options
 865         require-delimiter", "maint test-options unknown-is-error", "maint
 866         test-options unknown-is-operand" and "maint show
 867         test-options-completion-result".
 868         (New command options, command completion): New section.
 869         (Completion improvements): New section.
 870         Mention that you can abbreviate "unlimited".
 871
 872 2019-06-13  Pedro Alves  <palves@redhat.com>
 873
 874         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 875         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 876         * unittests/cli-utils-selftests.c (test_parse_flags)
 877         (test_parse_flags_qcs): Delete.
 878         (test_cli_utils): Don't call deleted functions.
 879
 880 2019-06-13  Pedro Alves  <palves@redhat.com>
 881
 882         * thread.c: Include "cli/cli-option.h".
 883         (tp_array_compar_ascending): Global.
 884         (tp_array_compar): Delete function.
 885         (tp_array_compar_ascending, tp_array_compar_descending): New
 886         functions.
 887         (ascending_option_def, qcs_flag_option_def)
 888         (thr_qcs_flags_option_defs)
 889         (make_thread_apply_all_options_def_group)
 890         (make_thread_apply_options_def_group): New.
 891         (thread_apply_all_command): Use gdb::option::process_options.
 892         (thread_apply_command_completer)
 893         (thread_apply_all_command_completer): New.
 894         (thread_apply_command): Use gdb::option::process_options.
 895         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 896         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 897         to generate help text of "thread apply".  Adjust "taas"'s help.
 898         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 899         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 900
 901 2019-06-13  Pedro Alves  <palves@redhat.com>
 902
 903         * thread.c (thread_apply_command): Check for invalid TID with
 904         isdigit instead of !isalpha.
 905
 906 2019-06-13  Pedro Alves  <palves@redhat.com>
 907
 908         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 909         (validate_flags_qcs): New.
 910         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 911         (validate_flags_qcs): Declare.
 912         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 913         (make_frame_apply_options_def_group): New.
 914         (frame_apply_command_count): Process options with
 915         gdb::option::process_options.
 916         (frame_apply_completer): New.
 917         (frame_apply_level_completer, frame_apply_all_completer)
 918         (frame_apply_completer): New.
 919         (_initialize_stack): Update help of "frame apply", "frame apply
 920         level", "frame apply all" and "faas" to mention supported options
 921         and install command completers.
 922         * stack.h (frame_apply_all_completer): Declare.
 923         * thread.c: Include "stack.h".
 924         (tfaas_command): Add "--".
 925         (_initialize_thread): Update help "tfaas" to mention supported
 926         options and install command completer.
 927
 928 2019-06-13  Pedro Alves  <palves@redhat.com>
 929
 930         * completer.c (complete_nested_command_line): New.
 931         (gdb_completion_word_break_characters_throw): Add assertion.
 932         * completer.h (complete_nested_command_line): Declare.
 933
 934 2019-06-13  Pedro Alves  <palves@redhat.com>
 935
 936         * stack.c (parse_backtrace_qualifiers): New.
 937         (backtrace_command): Use it.
 938         (backtrace_command_completer): Complete on qualifiers.
 939
 940 2019-06-13  Pedro Alves  <palves@redhat.com>
 941
 942         * frame.c: Include "cli/cli-option.h.
 943         (user_set_backtrace_options): New.
 944         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 945         Delete.
 946         (get_prev_frame): Adjust.
 947         (boolean_option_def, uinteger_option_def)
 948         (set_backtrace_option_defs): New.
 949         (_initialize_frame): Adjust and use
 950         gdb::option::add_setshow_cmds_for_options to install "set
 951         backtrace past-main" and "set backtrace past-entry".
 952         * frame.h: Include "cli/cli-option.h".
 953         (struct frame_print_options): Forward declare.
 954         (print_frame_arguments_all, print_frame_arguments_scalars)
 955         (print_frame_arguments_none): Declare.
 956         (print_entry_values): Delete declaration.
 957         (struct frame_print_options, user_frame_print_options): New.
 958         (struct set_backtrace_options): New.
 959         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 960         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 961         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 962         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 963         (list_args_or_locals): Add frame_print_options parameter.
 964         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 965         * python/py-framefilter.c (enumerate_args): Pass down
 966         USER_FRAME_PRINT_OPTIONS.
 967         * stack.c: Include "cli/cli-option.h".
 968         (print_frame_arguments_all, print_frame_arguments_scalars)
 969         (print_frame_arguments_none): Declare.
 970         (print_raw_frame_arguments, print_entry_values): Delete.
 971         (user_frame_print_options): New.
 972         (boolean_option_def, enum_option_def, frame_print_option_defs):
 973         New.
 974         (struct backtrace_cmd_options): New.
 975         (bt_flag_option_def): New.
 976         (backtrace_command_option_defs): New.
 977         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 978         (print_frame_arg, read_frame_arg, print_frame_args)
 979         (print_frame_info, print_frame): Add frame_print_options parameter
 980         and use it.
 981         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 982         (backtrace_command_1): Add frame_print_options and
 983         backtrace_cmd_options parameters and use them.
 984         (make_backtrace_options_def_group): New.
 985         (backtrace_command): Process command options with
 986         gdb::option::process_options.
 987         (backtrace_command_completer): New.
 988         (_initialize_stack): Extend "backtrace"'s help to mention
 989         supported options.  Install completer for "backtrace".
 990         Install some settings commands with add_setshow_cmds_for_options.
 991
 992 2019-06-13  Pedro Alves  <palves@redhat.com>
 993
 994         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 995         and that "set/show print raw frame-arguments" are now deprecated.
 996
 997         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 998         command.
 999         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1000         * stack.c (_initialize_stack): Install "set/show print
1001         raw-frame-arguments", and deprecate "set/show print raw
1002         frame-arguments".
1003         * valprint.c (_initialize_valprint): Deprecate "set/show print
1004         raw".
1005
1006 2019-06-13  Pedro Alves  <palves@redhat.com>
1007
1008         * compile/compile.c (struct compile_options): New.
1009         (compile_flag_option_def, compile_command_option_defs)
1010         (make_compile_options_def_group): New.
1011         (compile_file_command): Handle options with
1012         gdb::option::process_options.
1013         (compile_file_command_completer): New function.
1014         (compile_code_command): Handle options with
1015         gdb::option::process_options.
1016         (compile_code_command_completer): New function.
1017         (_initialize_compiler): Install completers for "compile code" and
1018         "compile file".  Mention available options in "compile code" and
1019         "compile code"'s help.
1020         * completer.c (advance_to_completion_word): New, factored out from
1021         ...
1022         (advance_to_expression_complete_word_point): ... this.
1023         (advance_to_filename_complete_word_point): New.
1024         * completer.h (advance_to_filename_complete_word_point): New
1025         declaration.
1026
1027 2019-06-13  Pedro Alves  <palves@redhat.com>
1028
1029         * compile/compile.c: Include "cli/cli-option.h".
1030         (compile_print_value): Scope data pointer is now a
1031         value_print_options pointer; adjust.
1032         (compile_print_command): Process options.  Scope data pointer is
1033         now a value_print_options pointer; adjust.
1034         (_initialize_compile): Update "compile print"'s help to include
1035         supported options.  Install a completer for "compile print".
1036         * cp-valprint.c (show_vtblprint, show_objectprint)
1037         (show_static_field_print): Delete.
1038         (_initialize_cp_valprint): Don't install "set print
1039         static-members", "set print vtbl", "set print object" here.
1040         * printcmd.c: Include "cli/cli-option.h" and
1041         "common/gdb_optional.h".
1042         (print_command_parse_format): Rework to fill in a
1043         value_print_options instead of a format_data.
1044         (print_value): Change parameter type from format_data pointer to
1045         value_print_options reference.  Adjust.
1046         (print_command_1): Process options.  Adjust to pass down a
1047         value_print_options.
1048         (print_command_completer): New.
1049         (_initialize_printcmd): Install print_command_completer as
1050         handle_brkchars completer for the "print" command.  Update
1051         "print"'s help to include supported options.
1052         * valprint.c: Include "cli/cli-option.h".
1053         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1054         here from cp-valprint.c.
1055         (boolean_option_def, uinteger_option_def)
1056         (value_print_option_defs, make_value_print_options_def_group):
1057         New.  Use gdb::option::add_setshow_cmds_for_options to install
1058         "set print elements", "set print null-stop", "set print repeats",
1059         "set print pretty", "set print union", "set print array", "set
1060         print address", "set print symbol", "set print array-indexes".
1061         * valprint.h: Include <string> and "cli/cli-option.h".
1062         (make_value_print_options_def_group): Declare.
1063         (print_value): Change parameter type from format_data pointer to
1064         value_print_options reference.
1065         (print_command_completer): Declare.
1066
1067 2019-06-13  Pedro Alves  <palves@redhat.com>
1068
1069         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1070         (COMMON_SFILES): Add maint-test-settings.c.
1071         * cli/cli-decode.c (boolean_enums): New global, factored out from
1072         ...
1073         (add_setshow_boolean_cmd): ... here.
1074         * cli/cli-decode.h (boolean_enums): Declare.
1075         * cli/cli-option.c: New file.
1076         * cli/cli-option.h: New file.
1077         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1078         factored out from ...
1079         (parse_cli_boolean_value(const char *)): ... this.
1080         (is_unlimited_literal): Change parameter type to pointer to
1081         pointer.  Adjust and advance ARG pointer.
1082         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1083         (parse_cli_var_enum): New, factored out from ...
1084         (do_set_command): ... this.  Adjust.
1085         * cli/cli-setshow.h (parse_cli_boolean_value)
1086         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1087         (parse_cli_var_enum): Declare.
1088         * cli/cli-utils.c: Include "cli/cli-option.h".
1089         (get_ulongest): New.
1090         * cli/cli-utils.h (get_ulongest): Declare.
1091         (check_for_argument): New overloads.
1092         * maint-test-options.c: New file.
1093
1094 2019-06-13  Pedro Alves  <palves@redhat.com>
1095
1096         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1097         parse a range if "-" is at the end of the string.
1098
1099 2019-06-13  Pedro Alves  <palves@redhat.com>
1100
1101         * cli/cli-setshow.c (parse_auto_binary_operation)
1102         (parse_cli_boolean_value): Don't allow "o".
1103
1104 2019-06-13  Pedro Alves  <palves@redhat.com>
1105
1106         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1107         * NEWS: Mention maint test-settings KIND.
1108         * maint-test-settings.c: New file.
1109
1110 2019-06-13  Pedro Alves  <palves@redhat.com>
1111
1112         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1113         completer.
1114         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1115         "set" completers.
1116
1117 2019-06-13  Pedro Alves  <palves@redhat.com>
1118
1119         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1120         after item.
1121
1122 2019-06-13  Pedro Alves  <palves@redhat.com>
1123
1124         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1125
1126 2019-06-13  Pedro Alves <palves@redhat.com>
1127
1128         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1129         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1130         call.
1131         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1132         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1133         calls.
1134         (check_for_argument): Skip spaces after argument.
1135
1136 2019-06-13  Pedro Alves  <palves@redhat.com>
1137
1138         * thread.c (thread_apply_command): Adjust TID parsing.
1139         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1140         detected before end of string.
1141         (tid_is_in_list): Error out if LIST is invalid.
1142
1143 2019-06-13  Pedro Alves  <palves@redhat.com>
1144
1145         * completer.c (complete_line_internal_1): Rewind completion word
1146         point.
1147         (completion_tracker::advance_custom_word_point_by): Change
1148         parameter type to int.
1149         * completer.h (completion_tracker::advance_custom_word_point_by):
1150         Likewise.
1151
1152 2019-06-13  Pedro Alves  <palves@redhat.com>
1153
1154         * completer.c (advance_to_completion_word): Handle delimiters.
1155
1156 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1157
1158         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1159
1160 2019-06-11  Tom Tromey  <tom@tromey.com>
1161
1162         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1163         (xmalloc_failed): Move to alloc.c.
1164         * alloc.c: New file.
1165         * Makefile.in (COMMON_SFILES): Add alloc.c.
1166
1167 2019-06-11  Tom Tromey  <tom@tromey.com>
1168
1169         * nat/linux-waitpid.c: Don't include server.h.
1170         (linux_debug): Remove.
1171         (my_waitpid): Update.
1172
1173 2019-06-11  Tom Tromey  <tromey@adacore.com>
1174
1175         * infcall.c (_initialize_infcall): Remove trailing newline from
1176         help.
1177         * user-regs.c (_initialize_user_regs): Remove trailing newline
1178         from help.
1179         * typeprint.c (_initialize_typeprint): Remove trailing newline
1180         from help.
1181         * reverse.c (_initialize_reverse): Remove trailing newlines from
1182         help.
1183         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1184         from help.
1185         * language.c (add_set_language_command): Remove trailing newline
1186         from help.
1187         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1188         help.
1189         * disasm.c (_initialize_disasm): Remove trailing newline from
1190         help.
1191         * top.c (init_main): Remove trailing newline from help.
1192         * interps.c (_initialize_interpreter): Remove trailing newline
1193         from help.
1194         * btrace.c (_initialize_btrace): Remove trailing newlines from
1195         help.
1196         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1197         from help.
1198         * python/python.c (_initialize_python): Remove trailing newline
1199         from help.
1200         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1201         help.
1202         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1203         from help.  Reformat some text.
1204         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1205         from help.
1206         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1207         newline from help.
1208
1209 2019-06-11  Tom Tromey  <tromey@adacore.com>
1210
1211         * darwin-nat.c (darwin_decode_exception_message)
1212         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1213
1214 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1215
1216         * valops.c (value_slice): Check for not allocated or not
1217         associated values.
1218
1219 2019-06-10  Tom de Vries  <tdevries@suse.de>
1220
1221         PR gdb/24618
1222         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1223         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1224         invalid.
1225
1226 2019-06-10  Tom de Vries  <tdevries@suse.de>
1227
1228         PR gdb/24611
1229         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1230         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1231
1232 2019-06-10  Tom de Vries  <tdevries@suse.de>
1233
1234         PR symtab/24545
1235         * symtab.c (struct demangled_name_entry): Add language field.
1236         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1237         static minimal symbol".  Set and use language field.
1238
1239 2019-06-10  Tom Tromey  <tromey@adacore.com>
1240
1241         * ada-lang.c (_initialize_ada_language): Update help text.
1242
1243 2019-06-10  Tom Tromey  <tromey@adacore.com>
1244
1245         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1246         with a newline.
1247         * guile/guile.c (handle_boot_error): Don't end warning with a
1248         newline.
1249         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1250         warning with a newline.
1251         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1252         newline.
1253         (s12z_frame_cache): Likewise.
1254         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1255         a newline.
1256         * solib-svr4.c (disable_probes_interface): Don't end warning with
1257         a newline.
1258         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1259         newline.
1260         * python/python.c (do_finish_initialization): Don't end warning
1261         with a newline.
1262
1263 2019-06-10  Tom Tromey  <tom@tromey.com>
1264
1265         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1266         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1267         gdbpy_enter.
1268
1269 2019-06-10  Tom Tromey  <tromey@adacore.com>
1270
1271         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1272         data.
1273         (elf_new_init): Don't call stabsread_new_init.
1274         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1275         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1276         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1277
1278 2019-06-10  Tom de Vries  <tdevries@suse.de>
1279
1280         PR symtab/16264
1281         PR symtab/24517
1282         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1283
1284 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1285
1286         * source.c (find_and_open_source): Also rewrite relative file
1287         names.
1288
1289 2019-04-26  Amos Bird  <amosbird@gmail.com>
1290
1291         * annotate.c (annotate_thread_exited): Add "thread-exited"
1292         annotation.
1293
1294 2019-06-06  Tom Tromey  <tromey@adacore.com>
1295
1296         * maint.h (class scoped_command_stats): Use
1297         DISABLE_COPY_AND_ASSIGN.
1298         <print_time>: New method.
1299         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1300         print_time.
1301         (scoped_command_stats::print_time): New method.
1302
1303 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1304
1305         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1306         instructions of lengths 6 or 8 bytes.
1307
1308 2019-06-04  Pedro Alves  <palves@redhat.com>
1309
1310         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1311
1312         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1313         * breakpoint.c (condition_completer): Likewise.
1314         * cli/cli-dump.c (scan_expression): Likewise.
1315         * common/filestuff.c (mkdir_recursive): Likewise.
1316         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1317         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1318         (gdb_abspath): Likewise.
1319         * compile/compile-cplus-types.c
1320         (compile_cplus_instance::decl_name): Likewise.
1321         * completer.c (complete_explicit_location):
1322         (signal_completer, reg_or_group_completer_1): Likewise.
1323         * cp-support.c (cp_remove_params_if_any): Likewise.
1324         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1325         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1326         * infcmd.c (strip_bg_char): Likewise.
1327         * linespec.c (copy_token_string): Likewise.
1328         * mi/mi-main.c (output_cores): Likewise.
1329         * psymtab.c (psymtab_search_name):
1330         * symfile.c (test_set_ext_lang_command): Likewise.
1331         * target.c (target_fileio_read_stralloc): Likewise.
1332         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1333         * value.c (complete_internalvar): Likewise.
1334
1335 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1336
1337         Add objfile property to gdb.Type.
1338         * NEWS: Mention Python API addition.
1339         * python/py-type.c (typy_get_objfile): New method.
1340
1341 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1342
1343         * NEWS: Mention the new set|show style [title|highlight].
1344         Mention changes to "show style", "help" and "apropos".
1345
1346 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1347
1348         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1349         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1350         instead of print_help_for_command.
1351         (print_doc_of_command): New function.
1352         (help_list): Add 'apropos -v word' suggestion.
1353         (print_help_for_command): Style the command name using title style.
1354         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1355         (_initialize_cli_cmds): Describe -v in apropos_command help.
1356
1357 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1358
1359         * cli/cli-style.h (cli_style_option): Add name in constructor,
1360         add m_name class member, add constructor with intensity,
1361         add name class function.
1362         (cli_style_option::add_setshow_commands): Remove name argument.
1363         (highlight_style, title_style): New styles.
1364         * cli/cli-style.c (do_show): New function that shows a style
1365         characteristic styling the style name with itself.
1366         (set_style_name): New function.
1367         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1368         Update all callers according to the changes in cli/cli-style.h.
1369         * utils.h (fputs_highlighted): New function.
1370         * utils.c (fputs_highlighted): Likewise.
1371
1372 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1373
1374         * NEWS: Mention new pipe command and new convenience variables.
1375
1376 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1377
1378         * cli/cli-cmds.c (pipe_command): New function.
1379         (_initialize_cli_cmds): Call add_com for pipe_command.
1380         Define | as an alias for pipe.
1381         (exit_status_set_internal_vars): New function.
1382         (shell_escape): Call exit_status_set_internal_vars.
1383         cli/cli-decode.c (find_command_name_length): Recognize | as
1384         a single character command.
1385
1386 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1387
1388         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1389         top.c (execute_command_to_ui_file): New function, mostly a copy
1390         of execute_command_to_string.
1391         (execute_command_to_string): Implement by calling
1392         execute_command_to_ui_file.
1393
1394 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1395
1396         * top.h (saved_command_line): Remove declaration.
1397         * top.c (previous_saved_command_line, previous_repeat_arguments):
1398         New variables.
1399         (saved_command_line): Make static, define together with other
1400         'repeat variables'.
1401         (dont_repeat): Clear repeat_arguments.
1402         (repeat_previous, get_saved_command_line, save_command_line):
1403         New functions.
1404         (gdb_init): Initialize saved_command_line
1405         and previous_saved_command_line.
1406         * main.c (captured_main_1): Remove saved_command_line initialization.
1407         * event-top.c (handle_line_of_input): Update to use
1408         the new 'repeat' related functions instead of direct access to
1409         saved_command_line.
1410         * command.h (repeat_previous, get_saved_command_line,
1411         save_command_line): New declarations.
1412         (dont_repeat): Add comment.
1413
1414 2019-05-30  Tom Tromey  <tromey@adacore.com>
1415
1416         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1417         Fix comment.
1418         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1419
1420 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1421
1422         PR cli/24587
1423         * completer.c (complete): Initialize variable word.
1424
1425 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1426
1427         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1428         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1429         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1430         'body' is NULL to the outter 'if', protecting the '!is_define'
1431         situation as well.
1432
1433 2019-05-29  Tom Tromey  <tromey@adacore.com>
1434
1435         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1436         (dwarf_unknown): New function.
1437         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1438         (dwarf_type_encoding_name): Use dwarf_unknown.
1439
1440 2019-05-29  Tom Tromey  <tromey@adacore.com>
1441
1442         PR c++/20020:
1443         * cp-valprint.c (cp_print_value_fields): Call
1444         cp_print_static_field inside "try".
1445
1446 2019-05-29  Tom Tromey  <tromey@adacore.com>
1447
1448         * inflow.c (struct terminal_info): Add default operator=.
1449         * configure: Rebuild.
1450         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1451         -Wdeprecated-copy-dtor, -Wredundant-move.
1452
1453 2019-05-29  Tom Tromey  <tromey@adacore.com>
1454
1455         * NEWS: Add entry.
1456         * infcmd.c (print_return_value_1): Handle finish_print
1457         option.
1458         (show_print_finish): New function.
1459         (_initialize_infcmd): Add "set/show print finish" commands.
1460         * valprint.c (user_print_options): Initialize new member.
1461         * valprint.h (struct value_print_options) <finish_print>: New
1462         member.
1463
1464 2019-05-28  Tom Tromey  <tromey@adacore.com>
1465
1466         * ada-lang.c (ada_remove_Xbn_suffix)
1467         (find_old_style_renaming_symbol)
1468         (parse_old_style_renaming): Remove.
1469         (ada_find_renaming_symbol): Don't call
1470         find_old_style_renaming_symbol.
1471         (ada_is_renaming_symbol): Rename from
1472         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1473         bool.  Now static.
1474         (ada_read_var_value): Update and simplify.
1475         * ada-exp.y (write_var_or_type): Remove old code.
1476
1477 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1478
1479         * event-top.c: Remove include comment.
1480         * inflow.c (class scoped_ignore_sigttou): Move from here...
1481         * inflow.h (class scoped_ignore_sigttou): ...to here.
1482         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1483         * top.c:  Remove include comment.
1484
1485 2019-05-27  Tom Tromey  <tom@tromey.com>
1486
1487         * NEWS: Fix typo.
1488
1489 2019-05-22  Tom Tromey  <tromey@adacore.com>
1490
1491         * target.c (target_follow_exec): Constify parameter.
1492         * target-delegates.c: Rebuild.
1493         * remote.c (remote_target::follow_exec): Constify parameter.
1494         * infrun.c (follow_exec): Constify parameter.
1495         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1496         (target_follow_exec): Likewise.
1497
1498 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1499
1500         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1501         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1502
1503 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1504
1505         * NEWS: Add debugredirect and testsuite sections.
1506
1507 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1508
1509         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1510         target descriptions using exclusively floating point register name
1511         aliases.
1512
1513 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1514
1515         PR gdb/18644:
1516         * f-lang.c (build_fortran_types): Handle the case where
1517         gdbarch_floatformat_for_type returns a nullptr.
1518
1519 2019-05-21  Tom de Vries  <tdevries@suse.de>
1520
1521         PR cli/24587
1522         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1523
1524 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1525
1526         PR gdb/18644:
1527         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1528         16-byte floats.
1529         * i386-tdep.c (i386_floatformat_for_type): Use
1530         floatformats_ia64_quad for the 16-byte floating point component
1531         within a fortran 32-byte complex number.
1532
1533 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1534
1535         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1536         delete default constructor.
1537         (find_partial_die): Update to return const struct.
1538         (partial_die_parent_scope): Move variable declaration into scope
1539         of its use and change its type to auto.
1540         (guess_partial_die_structure_name): Likewise.
1541         (partial_die_info::fixup): Likewise.
1542
1543 2019-05-17  Tom Tromey  <tromey@adacore.com>
1544
1545         * source.c (find_and_open_source): Remove cast.
1546
1547 2019-05-17  Tom Tromey  <tromey@adacore.com>
1548
1549         * annotate.c (annotate_source): Make "filename" const.
1550         * annotate.h (annotate_source): Use const.
1551
1552 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1553
1554         * disasm.c (set_disassembler_options): Send errors to stderr.
1555
1556 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1557
1558         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1559         (cli_interp_base::set_logging): Check debug_redirect.
1560         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1561         * cli/cli-logging.c (debug_redirect): Add static variable.
1562         (pop_output_files): Add default param.
1563         (handle_redirections): Print debug setting.
1564         (show_logging_command): Likewise.
1565         (_initialize_cli_logging): Add debugredirect command.
1566         * interps.c (current_interp_set_logging): Add debug_redirect
1567         parameter.
1568         * interps.h (set_logging): Add debug_redirect parameter.
1569         (current_interp_set_logging): Likewise.
1570         * mi/mi-common.h: Likewise.
1571         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1572
1573 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1574             Tom Tromey  <tromey@adacore.com>
1575
1576         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1577         directly.
1578         * cli/cli-interp.h (make_logging_output): Remove declaration.
1579         * cli/cli-logging.c (make_logging_output): Remove function.
1580         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1581         directly.
1582         * ui-file.c (tee_file::tee_file): Remove bools.
1583         (tee_file::~tee_file): Remove deletes.
1584         * ui-file.h (tee_file): Remove bools.
1585
1586 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1587
1588         * mi/mi-cmds.h (mi_cmd_complete): New function.
1589         * mi/mi-main.c (mi_cmd_complete): Likewise.
1590         * mi/mi-cmds.c: Define new MI command -complete.
1591         * NEWS: Mention new -complete command.
1592
1593 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1594
1595         * completer.h (complete): New function.
1596         * completer.c (complete): Likewise.
1597         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1598         function defined in completer.h.
1599
1600 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1601
1602         * MAINTAINERS (Write After Approval): Add myself.
1603
1604 2019-05-17  Tom de Vries  <tdevries@suse.de>
1605
1606         PR gdb/24094
1607         * dwarf2read.c (struct cu_partial_die_info): New struct.
1608         (find_partial_die): Return cu_partial_die_info.
1609         (partial_die_parent_scope, guess_partial_die_structure_name)
1610         (partial_die_info::fixup): Handle new return type of find_partial_die.
1611
1612 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1613
1614         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1615         "std::string", simplifying the algorithm.
1616
1617 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1618
1619         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1620         (stap_static_probe_ops::get_probes): Likewise.
1621
1622 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1623
1624         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1625         '-')" and "else if".
1626         (stap_parse_single_operand): Join checks for
1627         "gdbarch_stap_parse_special_token_p" and
1628         "gdbarch_stap_parse_special_token" in the same "if" statement.
1629         Invert check when verifying for operation on register
1630         displacement.
1631
1632 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1633
1634         * stap-probe.c (stap_get_opcode): Update comment.
1635         (stap_get_expected_argument_type): Likewise.
1636         (handle_stap_probe): Likewise.
1637
1638 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1639
1640         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1641         return type to 'bool'.  Adjust comment.  Use 'bool' when
1642         appropriate.
1643         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1644         * stap-probe.c (stap_parse_argument_1): Likewise.
1645         (stap_is_operator): Likewise.
1646         (stap_is_generic_prefix): Likewise.
1647         (stap_is_register_prefix): Likewise.
1648         (stap_is_register_indirection_prefix): Likewise.
1649         (stap_is_integer_prefix): Likewise.
1650         (stap_generic_check_suffix): Likewise.
1651         (stap_check_integer_suffix): Likewise.
1652         (stap_check_register_suffix): Likewise.
1653         (stap_check_register_indirection_suffix): Likewise.
1654         (stap_parse_register_operand): Likewise.
1655         (stap_parse_single_operand): Likewise.
1656         (stap_parse_argument_1): Likewise.
1657         (stap_probe::get_argument_count): Likewise.
1658         (stap_is_operator): Likewise.
1659
1660 2019-05-16  Tom Tromey  <tromey@adacore.com>
1661
1662         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1663         keyword to foreach.
1664
1665 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1666
1667         * linux-thread-db.c (try_thread_db_load_1): Change return type
1668         to bool.
1669         (try_thread_db_load): Likewise.
1670         (try_thread_db_load_from_pdir_1): Likewise.
1671         (try_thread_db_load_from_pdir): Likewise.
1672         (try_thread_db_load_from_sdir): Likewise.
1673         (try_thread_db_load_from_dir): Likewise.
1674         (thread_db_load_search): Likewise.
1675         (has_libpthread): Likewise.
1676         (thread_db_load): Likewise.
1677
1678 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1679
1680         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1681         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1682         NULL, and complain/return if that's the case.
1683
1684 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1685
1686         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1687         (advance, posn, abstract_read_memory): New functions.
1688         [struct mem_read_abstraction]: New struct.
1689         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1690
1691 2019-05-14  Tom Tromey  <tromey@adacore.com>
1692
1693         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1694         value is not lval_memory.
1695
1696 2019-05-14  Tom Tromey  <tromey@adacore.com>
1697
1698         * solib.c (info_sharedlibrary_command): Style the file name.
1699
1700 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1701
1702         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1703         (aarch64_vnv_type): Likewise.
1704         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1705         * common/tdesc.c: Likewise.
1706         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1707         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1708         * features/aarch64-fpu.xml: Add ieee half view.
1709         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1710         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1711         * gdbtypes.h (struct builtin_type): Likewise.
1712         (struct objfile_type): Likewise.
1713
1714 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1715
1716         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1717         typo.
1718         * location.h (string_to_event_location): Likewise.
1719
1720 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1721
1722         GDB 8.3 released.
1723
1724 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1725
1726         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1727         New variable declaration.
1728         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1729         New variable.
1730         (print_one_breakpoint): Use ui_out::test_flags and new global
1731         variable to compute use_fixed_output.
1732         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1733         Remove.
1734         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1735         (mi_multi_location_breakpoint_output_fixed): Remove.
1736         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1737         new variable.
1738         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1739         fix_multi_location_breakpoint_output flag if version >= 3.
1740         * ui-out.h (enum ui_out_flag)
1741         <fix_multi_location_breakpoint_output>: New enumerator.
1742
1743 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1744
1745         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1746
1747 2019-05-10  Tom Tromey  <tromey@adacore.com>
1748
1749         * ada-lang.c (catch_ada_completer): New function.
1750         (_initialize_ada_language): Use it.
1751
1752 2019-05-10  Tom Tromey  <tromey@adacore.com>
1753
1754         * thread.c (print_thread_info): Make "requested_threads" const.
1755         * gdbthread.h (print_thread_info): Make "requested_threads"
1756         const.
1757         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1758         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1759
1760 2019-05-08  Tom Tromey  <tom@tromey.com>
1761
1762         * gdbtypes.c (objfile_type_data): Change type.
1763         (objfile_type, _initialize_gdbtypes): Update.
1764
1765 2019-05-08  Tom Tromey  <tom@tromey.com>
1766
1767         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1768         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1769         (_initialize_dwarf2_frame): Update.
1770
1771 2019-05-08  Tom Tromey  <tom@tromey.com>
1772
1773         * objc-lang.c (objc_objfile_data): Change type.
1774         (find_methods): Update.
1775         (_initialize_objc_lang): Remove.
1776
1777 2019-05-08  Tom Tromey  <tom@tromey.com>
1778
1779         * stabsread.c (rs6000_builtin_type_data): Change type.
1780         (rs6000_builtin_type, _initialize_stabsread): Update.
1781
1782 2019-05-08  Tom Tromey  <tom@tromey.com>
1783
1784         * mips-tdep.c (mips_pdr_data): Remove.
1785         (_initialize_mips_tdep): Update.
1786
1787 2019-05-08  Tom Tromey  <tom@tromey.com>
1788
1789         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1790         (hppa_init_objfile_priv_data, read_unwind_info)
1791         (find_unwind_entry, _initialize_hppa_tdep): Update.
1792
1793 2019-05-08  Tom Tromey  <tom@tromey.com>
1794
1795         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1796         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1797         on obstack.
1798         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1799
1800 2019-05-08  Tom Tromey  <tom@tromey.com>
1801
1802         * mdebugread.c (basic_type_data): Change type.
1803         (basic_type, _initialize_mdebugread): Update.
1804
1805 2019-05-08  Tom Tromey  <tom@tromey.com>
1806
1807         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1808
1809 2019-05-08  Tom Tromey  <tom@tromey.com>
1810
1811         * nto-tdep.c (nto_inferior_data_reg): Change type.
1812         (nto_inferior_data): Update.
1813         (nto_inferior_data_cleanup, nto_new_inferior_data)
1814         (_initialize_nto_tdep): Remove.
1815         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1816
1817 2019-05-08  Tom Tromey  <tom@tromey.com>
1818
1819         * ada-lang.c (struct ada_inferior_data): Add initializers.
1820         (ada_inferior_data): Change type.
1821         (ada_inferior_data_cleanup): Remove.
1822         (get_ada_inferior_data, ada_inferior_exit)
1823         (struct ada_pspace_data): Add initializers, destructor.
1824         (ada_pspace_data_handle): Change type.
1825         (get_ada_pspace_data): Update.
1826         (ada_pspace_data_cleanup): Remove.
1827
1828 2019-05-08  Tom Tromey  <tom@tromey.com>
1829
1830         * coffread.c (struct coff_symfile_info): Add initializers.
1831         (coff_objfile_data_key): Move lower.  Change type.
1832         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1833         Update.
1834         (coff_free_info): Remove.
1835
1836 2019-05-08  Tom Tromey  <tom@tromey.com>
1837
1838         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1839         (fbsd_pspace_data_handle): Move lower.  Change type.
1840         (get_fbsd_pspace_data): Update.
1841         (fbsd_pspace_data_cleanup): Remove.
1842         (_initialize_fbsd_tdep): Update.
1843
1844 2019-05-08  Tom Tromey  <tom@tromey.com>
1845
1846         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1847         (get_ada_tasks_pspace_data): Update.
1848         (ada_tasks_pspace_data_cleanup): Remove.
1849         (_initialize_tasks): Update.
1850         (ada_tasks_inferior_data_handle): Change type.
1851         (get_ada_tasks_inferior_data): Update.
1852         (ada_tasks_inferior_data_cleanup): Remove.
1853         (struct ada_tasks_pspace_data): Add initializers.
1854
1855 2019-05-08  Tom Tromey  <tom@tromey.com>
1856
1857         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1858         * symfile-debug.c (debug_sym_get_probes): Change type.
1859         * stap-probe.c (handle_stap_probe):
1860         (stap_static_probe_ops::get_probes): Change type.
1861         * probe.h (class static_probe_ops) <get_probes>: Change type.
1862         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1863         (parse_probes_in_pspace): Update.
1864         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1865         Update.
1866         (any_static_probe_ops::get_probes): Change type.
1867         * elfread.c (elfread_data): New typedef.
1868         (probe_key): Change type.
1869         (elf_get_probes): Likewise.  Update.
1870         (probe_key_free): Remove.
1871         (_initialize_elfread): Update.
1872         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1873         Change type.
1874         (dtrace_process_dof_probe, dtrace_process_dof)
1875         (dtrace_static_probe_ops::get_probe): Change type.
1876
1877 2019-05-08  Tom Tromey  <tom@tromey.com>
1878
1879         * xcoffread.c (struct xcoff_symfile_info): Rename from
1880         coff_symfile_info.  Add initializers.
1881         (xcoff_objfile_data_key): Move lower.  Change type.
1882         (XCOFF_DATA): Rewrite.
1883         (xcoff_free_info): Remove.
1884         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1885         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1886         (xcoff_initial_scan): Update.
1887
1888 2019-05-08  Tom Tromey  <tom@tromey.com>
1889
1890         * solib-svr4.c (struct svr4_info): Add initializers and
1891         destructor.
1892         <probes_table>: Now an htab_up.
1893         (solib_svr4_pspace_data): Change type.
1894         (free_probes_table): Simplify.
1895         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1896         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1897         (probes_table_remove_objfile_probes, register_solib_event_probe)
1898         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1899         (_initialize_svr4_solib): Update.
1900
1901 2019-05-08  Tom Tromey  <tom@tromey.com>
1902
1903         * remote.c (remote_pspace_data): Change type.
1904         (remote_pspace_data_cleanup): Remove.
1905         (get_remote_exec_file, set_pspace_remote_exec_file)
1906         (_initialize_remote): Update.
1907
1908 2019-05-08  Tom Tromey  <tom@tromey.com>
1909
1910         * breakpoint.c (breakpoint_objfile_key): Change type.
1911         (get_breakpoint_objfile_data): Update.
1912         (free_breakpoint_objfile_data): Remove.
1913         (_initialize_breakpoint): Update.
1914
1915 2019-05-08  Tom Tromey  <tom@tromey.com>
1916
1917         * linux-tdep.c (struct linux_info): Add initializers.
1918         (linux_inferior_data): Move.  Change type.
1919         (invalidate_linux_cache_inf): Update.
1920         (linux_inferior_data_cleanup): Remove.
1921         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1922
1923 2019-05-08  Tom Tromey  <tom@tromey.com>
1924
1925         * auxv.c (auxv_inferior_data): Move.  Change type.
1926         (auxv_inferior_data_cleanup): Remove.
1927         (invalidate_auxv_cache_inf): Rewrite.
1928         (get_auxv_inferior_data, _initialize_auxv): Update.
1929
1930 2019-05-08  Tom Tromey  <tom@tromey.com>
1931
1932         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1933         (symfile_debug_objfile_data_key): Change type.
1934         (symfile_debug_installed, debug_qf_has_symbols)
1935         (debug_qf_find_last_source_symtab)
1936         (debug_qf_forget_cached_source_info)
1937         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1938         (debug_qf_print_stats, debug_qf_dump)
1939         (debug_qf_expand_symtabs_for_function)
1940         (debug_qf_expand_all_symtabs)
1941         (debug_qf_expand_symtabs_with_fullname)
1942         (debug_qf_map_matching_symbols)
1943         (debug_qf_expand_symtabs_matching)
1944         (debug_qf_find_pc_sect_compunit_symtab)
1945         (debug_qf_map_symbol_filenames)
1946         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1947         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1948         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1949         (debug_sym_read_linetable, debug_sym_relocate): Update.
1950         (symfile_debug_free_objfile): Remove.
1951         (install_symfile_debug_logging, _initialize_symfile_debug):
1952         Update.
1953
1954 2019-05-08  Tom Tromey  <tom@tromey.com>
1955
1956         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1957         allocate_on_obstack.
1958         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1959         (get_dwarf2_per_objfile): Update.
1960         (set_dwarf2_per_objfile): Remove.
1961         (dwarf2_has_info, dwarf2_get_section_info): Update.
1962         (dwarf2_free_objfile): Remove.
1963         (_initialize_dwarf2_read): Update.
1964
1965 2019-05-08  Tom Tromey  <tom@tromey.com>
1966
1967         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1968         initializers.
1969         <unsupported_script_warning_printed,
1970         script_not_found_warning_printed>: Now bool.
1971         (auto_load_pspace_data): Change type.
1972         (~auto_load_pspace_info): Rename from
1973         auto_load_pspace_data_cleanup.
1974         (get_auto_load_pspace_data, init_loaded_scripts_info)
1975         (clear_section_scripts, maybe_print_unsupported_script_warning)
1976         (maybe_print_script_not_found_warning, _initialize_auto_load):
1977         Update.
1978
1979 2019-05-08  Tom Tromey  <tom@tromey.com>
1980
1981         * objfiles.c (objfile_pspace_info): Add destructor and
1982         initializers.
1983         (objfiles_pspace_data): Change type.
1984         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1985         (get_objfile_pspace_data): Update.
1986         (objfiles_bfd_data): Change type.
1987         (get_objfile_bfd_data): Update.
1988         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1989
1990 2019-05-08  Tom Tromey  <tom@tromey.com>
1991
1992         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1993         Change type.
1994         (get_catch_syscall_inferior_data): Update.
1995         (catch_syscall_inferior_data_cleanup): Remove.
1996         (_initialize_break_catch_syscall): Update.
1997
1998 2019-05-08  Tom Tromey  <tom@tromey.com>
1999
2000         * inflow.c (struct terminal_info): Add destructor and
2001         initializers.
2002         (inflow_inferior_data): Change type.
2003         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2004         (get_inflow_inferior_data, inflow_inferior_exit)
2005         (swap_terminal_info, _initialize_inflow): Update.
2006
2007 2019-05-08  Tom Tromey  <tom@tromey.com>
2008
2009         * target-dcache.c (target_dcache_cleanup): Remove.
2010         (target_dcache_aspace_key): Change type.
2011         (target_dcache_init_p, target_dcache_invalidate)
2012         (target_dcache_get, target_dcache_get_or_init)
2013         (_initialize_target_dcache): Update.
2014         * dcache.h (struct dcache_deleter): New.
2015
2016 2019-05-08  Tom Tromey  <tom@tromey.com>
2017
2018         * symtab.c (struct symbol_cache): Add destructor and
2019         initializers.
2020         (symbol_cache_key): Move.  Change type.
2021         (make_symbol_cache, free_symbol_cache): Remove.
2022         (get_symbol_cache): Update.
2023         (symbol_cache_cleanup): Remove.
2024         (ALL_PSPACES, symbol_cache_flush)
2025         (maintenance_print_symbol_cache)
2026         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2027         Update.
2028
2029 2019-05-08  Tom Tromey  <tom@tromey.com>
2030
2031         * symtab.c (struct main_info): Add destructor and initializers.
2032         (main_progspace_key): Move.  Change type.
2033         (get_main_info): Update.
2034         (main_info_cleanup): Remove.
2035         (_initialize_symtab): Update.
2036
2037 2019-05-08  Tom Tromey  <tom@tromey.com>
2038
2039         * registry.h (DECLARE_REGISTRY): Define the _key class.
2040
2041 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2042
2043         * NEWS: Merge two 'New commands' sections.
2044
2045 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2046
2047         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2048         parameter and use Ada language definition instead.
2049         (ada_val_print_ptr): Remove unused language parameter.
2050         (ada_val_print_num): Remove language parameter and use Ada language
2051         definition instead.
2052         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2053         parameter.
2054         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2055         parameter and use Ada language definition instead.
2056         (ada_val_print_1): Update all ada_val_print_xxx calls.
2057         Remove language parameter.
2058         (ada_val_print): Update ada_val_print_1 call.
2059
2060 2019-05-08  Tom Tromey  <tromey@adacore.com>
2061
2062         * remote.c (remote_hw_watchpoint_limit)
2063         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2064         Now static.
2065
2066 2019-05-08  Tom Tromey  <tromey@adacore.com>
2067
2068         * maint.c (_initialize_maint_cmds): Move initialization code to
2069         remote.c.
2070         (watchdog, show_watchdog): Move to remote.c.
2071         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2072         "watchdog" static.
2073         (_initialize_remote): Move initialization code from maint.c.
2074         * defs.h (watchdog): Don't declare.
2075
2076 2019-05-08  Tom Tromey  <tromey@adacore.com>
2077
2078         * tui/tui-interp.c: Include main.h.
2079         * interps.c: Include main.h.
2080         * main.h (interpreter_p): Declare.
2081         * defs.h (interpreter_p): Don't declare.
2082
2083 2019-05-08  Tom Tromey  <tromey@adacore.com>
2084
2085         * dwarf2loc.c: Include dwarf2read.h.
2086         * defs.h (read_unsigned_leb128): Don't declare.
2087         * dwarf2read.h (read_unsigned_leb128): Declare.
2088
2089 2019-05-08  Tom Tromey  <tromey@adacore.com>
2090
2091         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2092         method.
2093
2094 2019-05-08  Tom Tromey  <tromey@adacore.com>
2095
2096         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2097         when no wrap column is set.
2098
2099 2019-05-08  Tom Tromey  <tromey@adacore.com>
2100
2101         * c-lang.c (c_get_string): Handle non-C-style arrays.
2102
2103 2019-05-08  Tom Tromey  <tromey@adacore.com>
2104
2105         * typeprint.c (print_offset_data::update): Print the bit offset,
2106         not the number of bits remaining.
2107
2108 2019-05-08  Tom Tromey  <tromey@adacore.com>
2109
2110         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2111         padding at end of comment.
2112
2113 2019-05-08  Tom Tromey  <tromey@adacore.com>
2114
2115         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2116         Compare main types.
2117
2118 2019-05-06  Tom Tromey  <tom@tromey.com>
2119
2120         * common/scoped_mmap.c: Include common-defs.h.
2121         * common/scoped_mmap.h: Don't include config.h.
2122
2123 2019-05-04  Tom Tromey  <tom@tromey.com>
2124
2125         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2126         (struct aarch64_call_info): Add initializers.
2127         <si>: Now a std::vector.
2128         (pass_on_stack, aarch64_push_dummy_call): Update.
2129
2130 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2131             Tom Tromey  <tom@tromey.com>
2132
2133         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2134         (ppc_threads): Now a std::vector.  Now static.
2135         (hwdebug_find_thread_points_by_tid)
2136         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2137         Update.
2138
2139 2019-05-04  Tom Tromey  <tom@tromey.com>
2140
2141         * arc-tdep.c (arc_tdesc_init): Return bool.
2142
2143 2019-05-04  Tom Tromey  <tom@tromey.com>
2144
2145         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2146         Use gdb_assert_not_reached.
2147
2148 2019-05-04  Tom Tromey  <tom@tromey.com>
2149
2150         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2151         "false".
2152
2153 2019-05-04  Tom Tromey  <tom@tromey.com>
2154
2155         * arc-tdep.c (arc_tdesc_init): Use bool.
2156
2157 2019-05-04  Tom Tromey  <tom@tromey.com>
2158
2159         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2160
2161 2019-05-04  Tom Tromey  <tom@tromey.com>
2162
2163         * cli/cli-cmds.c (valid_command_p): Return bool.
2164
2165 2019-05-04  Tom Tromey  <tom@tromey.com>
2166
2167         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2168         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2169
2170 2019-05-04  Raul Tambre  <raul@tambre.ee>
2171
2172         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2173         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2174         operator for comparison.
2175
2176 2019-05-04  Tom Tromey  <tom@tromey.com>
2177
2178         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2179         (lookup_partial_symbol, print_partial_symbols)
2180         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2181         (psymbol_compare): Update.
2182         (add_psymbol_to_bcache): Clear the entire psymbol.
2183         (maintenance_check_psymtabs): Update.
2184         * psympriv.h (struct partial_symbol): Don't derive from
2185         general_symbol_info.
2186         <obj_section, unrelocated_address, address,
2187         set_unrelocated_address>: Update.
2188         <ginfo>: New member.
2189         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2190         (debug_names::write_psymbols): Update.
2191
2192 2019-05-04  Tom de Vries  <tdevries@suse.de>
2193
2194         * contrib/cc-with-tweaks.sh: Support -n arg.
2195
2196 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2197
2198         * corelow.c (core_target::detach): Ensure frame cache and
2199         register caches are cleared.
2200         inferior.c (exit_inferior_1): Likewise.
2201
2202 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2203             Tom Tromey  <tom@tromey.com>
2204
2205         * dictionary.c (collate_pending_symbols_by_language): Remove
2206         "struct" from foreach.
2207         * symtab.c (lookup_global_symbol_from_objfile)
2208         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2209         foreach.
2210         * ser-tcp.c (net_open): Remove "struct" from foreach.
2211         * objfiles.c (objfile_relocate, objfile_rebase)
2212         (objfile_has_symbols): Remove "struct" from foreach.
2213         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2214         from foreach.
2215         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2216         foreach.
2217         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2218         "struct" from foreach.
2219         * ada-lang.c (create_excep_cond_exprs)
2220         (ada_exception_catchpoint_cond_string): Remove "struct" from
2221         foreach.
2222
2223 2019-05-03  Tom Tromey  <tromey@adacore.com>
2224
2225         * ada-exp.y (convert_char_literal): Check suffix of each
2226         enumerator.
2227
2228 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2229
2230         PR ada/21406:
2231         * ada-exp.y (yywrap): Don't define.
2232         * ada-lex.l (%option): Add noyywrap
2233         (yywrap): Remove.
2234
2235 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2236
2237         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2238         _WIN32_WINNT to the XP level, unless already defined to a higher
2239         level.
2240
2241         * unittests/parse-connection-spec-selftests.c:
2242         * ser-tcp.c:
2243         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2244         override.
2245
2246         * symfile.c (find_separate_debug_file): Remove colon from the
2247         drive spec of DOS/Windows file names of the target, so that the
2248         file name produced from DEBUGDIR and the target's directory will
2249         be valid on DOS/Windows systems.
2250
2251 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2252
2253         * rust-lang.c (val_print_struct): Handle printing structures
2254         containing strings.
2255
2256 2019-05-02  Tom Tromey  <tromey@adacore.com>
2257
2258         * valarith.c (_initialize_valarith): Remove.
2259
2260 2019-05-01  Tom Tromey  <tromey@adacore.com>
2261
2262         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2263         bitfields.
2264
2265 2019-05-01  Tom Tromey  <tromey@adacore.com>
2266
2267         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2268         for big-endian copies.
2269
2270 2019-04-30  Ali Tamur  <tamur@google.com>
2271         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2272         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2273         (read_3_bytes): New function.
2274
2275 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2276
2277         * windows-nat.c (main_thread_id): Delete.
2278         (handle_output_debug_string): Replace main_thread_id by
2279         current_event.dwThreadId.
2280         (fake_create_process): Likewise.
2281         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2282         Do not set main_thread_id.
2283         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2284         current_event.dwThreadId.
2285         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2286
2287 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2288
2289         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2290         Use current_event.dwThreadId instead of main_thread_id.
2291
2292 2019-04-30  Tom Tromey  <tromey@adacore.com>
2293
2294         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2295         (create_excep_cond_exprs): Iterate over program spaces.
2296         (ada_exception_catchpoint_cond_string): Examine all minimal
2297         symbols for exception types.
2298
2299 2019-04-30  Tom Tromey  <tromey@adacore.com>
2300
2301         PR c++/24470:
2302         * dwarf2read.c (process_structure_scope): Handle case where type
2303         has template parameters but no symbol was created.
2304
2305 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2306             Chris January  <chris.january@arm.com>
2307
2308         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2309         qualifier.
2310         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2311
2312 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2313
2314         * f-typeprint.c (f_print_type): Update rules for printing
2315         whitespace.
2316         (f_type_print_varspec_suffix): Likewise.
2317
2318 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2319             Chris January  <chris.january@arm.com>
2320
2321         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2322         function arguments.
2323
2324 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2325
2326         * f-lang.c (build_fortran_types): Change name of void type to
2327         lower case.
2328         * f-typeprint.c (f_type_print_base): Print the name of the void
2329         type, rather than a fixed string.
2330         * f-valprint.c (f_decorations): Use lower case void string.
2331
2332 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2333             Chris January  <chris.january@arm.com>
2334
2335         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2336         types for Fortran.
2337
2338 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2339             Chris January  <chris.january@arm.com>
2340             David Lecomber  <david.lecomber@arm.com>
2341
2342         * f-exp.y (BINOP_INTRINSIC): New token.
2343         (exp): New parser rule handling BINOP_INTRINSIC.
2344         (f77_keywords): Add new builtin procedures.
2345         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2346         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2347         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2348         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2349         (print_unop_subexp_f): New function.
2350         (print_binop_subexp_f): New function.
2351         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2352         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2353         (dump_subexp_body_f): Likewise.
2354         (operator_check_f): Likewise.
2355         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2356         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2357
2358 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2359
2360         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2361         UNOP_KIND.
2362         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2363         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2364         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2365         (operator_length_f): New fuction.
2366         (print_subexp_f): New function.
2367         (op_name_f): New function.
2368         (dump_subexp_body_f): New function.
2369         (operator_check_f): New function.
2370         (exp_descriptor_f): Replace standard expression handling functions
2371         with new functions.
2372         * gdb/fortran-operator.def: New file.
2373         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2374         * gdb/std-operator.def: Remove UNOP_KIND.
2375
2376 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2377
2378         * std-operator.def: Remove unbalanced, stray double quote
2379         character.
2380
2381 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2382             Chris January  <chris.january@arm.com>
2383             Daniel Everett  <daniel.everett@arm.com>
2384             Nick Forrington  <nick.forrington@arm.com>
2385             Richard Bunt  <richard.bunt@arm.com>
2386
2387         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2388         of depth when printing anonymous structs or unions.
2389         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2390         Don't print either the top-level value, or the children if the
2391         max-depth is exceeded.
2392         (ppscm_print_children): When printing the key of a map, allow one
2393         extra level of depth.
2394         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2395         print either the top-level value, or the children if the max-depth
2396         is exceeded.
2397         (print_children): When printing the key of a map, allow one extra
2398         level of depth.
2399         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2400         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2401         (user_print_options): Initialise max_depth field.
2402         (val_print_scalar_or_string_type_p): New function.
2403         (val_print): Check to see if the max depth has been reached.
2404         (val_print_check_max_depth): Define new function.
2405         (show_print_max_depth): New function.
2406         (_initialize_valprint): Add 'print max-depth' option.
2407         * valprint.h (struct value_print_options) <max_depth>: New field.
2408         (val_print_check_max_depth): Declare new function.
2409         * NEWS: Document new feature.
2410
2411 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2412
2413         * ada-lang.c (ada_language_defn): Initialise new field.
2414         * c-lang.c (c_is_string_type_p): New function.
2415         (c_language_defn): Initialise new field.
2416         (cplus_language_defn): Initialise new field.
2417         (asm_language_defn): Initialise new field.
2418         (minimal_language_defn): Initialise new field.
2419         * c-lang.h (c_is_string_type_p): Declare new function.
2420         * d-lang.c (d_language_defn): Initialise new field.
2421         * f-lang.c (f_is_string_type_p): New function.
2422         (f_language_defn): Initialise new field.
2423         * go-lang.c (go_is_string_type_p): New function.
2424         (go_language_defn): Initialise new field.
2425         * language.c (default_is_string_type_p): New function.
2426         (unknown_language_defn): Initialise new field.
2427         (auto_language_defn): Initialise new field.
2428         * language.h (struct language_defn) <la_is_string_type_p>: New
2429         member variable.
2430         (default_is_string_type_p): Declare new function.
2431         * m2-lang.c (m2_language_defn): Initialise new field.
2432         * objc-lang.c (objc_language_defn): Initialise new field.
2433         * opencl-lang.c (opencl_language_defn): Initialise new field.
2434         * p-lang.c (pascal_is_string_type_p): New function.
2435         (pascal_language_defn): Initialise new field.
2436         * rust-lang.c (rust_is_string_type_p): New function.
2437         (rust_language_defn): Initialise new field.
2438
2439 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2440
2441         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2442         New field.
2443         * ada-lang.c (ada_language_defn): Initialise new field.
2444         * c-lang.c (c_language_defn): Likewise.
2445         (cplus_language_defn): Likewise.
2446         (asm_language_defn): Likewise.
2447         (minimal_language_defn): Likewise.
2448         * d-lang.c (d_language_defn): Likewise.
2449         * f-lang.c (f_language_defn): Likewise.
2450         * go-lang.c (go_language_defn): Likewise.
2451         * language.c (unknown_language_defn): Likewise.
2452         (auto_language_defn): Likewise.
2453         * m2-lang.c (m2_language_defn): Likewise.
2454         * objc-lang.c (objc_language_defn): Likewise.
2455         * opencl-lang.c (opencl_language_defn): Likewise.
2456         * p-lang.c (pascal_language_defn): Likewise.
2457         * rust-lang.c (rust_language_defn): Likewise.
2458
2459 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2460
2461         * ada-lang.c (ada_is_character_type): Change return type to bool.
2462         (ada_is_string_type): Likewise.
2463         * ada-lang.h (ada_is_character_type): Update declaration
2464         (ada_is_string_type): Likewise.
2465
2466 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2467
2468         Support style in 'frame|thread apply'
2469
2470         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2471         * record.c (record_start, record_stop): Update callers of
2472         execute_command_to_string with false.
2473         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2474         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2475         methods.
2476         (class string_file): New constructor with term_out parameter.
2477         Override methods term_out and can_emit_style_escape.  New member
2478         term_out.
2479         (class stdio_file): Override can_emit_style_escape.
2480         (class tee_file): Override term_out and can_emit_style_escape.
2481         * utils.h (can_emit_style_escape): Remove.
2482         * utils.c (can_emit_style_escape): Likewise.
2483         Update all callers of can_emit_style_escape (SOMESTREAM) to
2484         SOMESTREAM->can_emit_style_escape.
2485         * source-cache.c (source_cache::get_source_lines): Likewise.
2486         * stack.c (frame_apply_command_count): Call execute_command_to_string
2487         passing the term_out characteristic of the current gdb_stdout.
2488         * thread.c (thr_try_catch_cmd): Likewise.
2489         * top.c (execute_command_to_string): pass term_out parameter
2490         to construct the string_file for the command output.
2491         * ui-file.c (term_cli_styling): New function (most code moved
2492         from utils.c can_emit_style_escape).
2493         (string_file::string_file, string_file::can_emit_style_escape,
2494         stdio_file::can_emit_style_escape, tee_file::term_out,
2495         tee_file::can_emit_style_escape): New functions.
2496
2497 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2498
2499         * NEWS: Mention the new set|show may-call-functions.
2500         * infcall.c (may_call_functions_p): New variable.
2501         (show_may_call_functions_p): New function.
2502         (call_function_by_hand_dummy): Throws an error if not
2503         may-call-functions.
2504         (_initialize_infcall): Call add_setshow_boolean_cmd for
2505         may-call-functions.
2506
2507 2019-04-25  Keith Seitz  <keiths@redhat.com>
2508
2509         PR c++/24367
2510         * cp-support.c (inspect_type): Don't attempt substitutions
2511         of symbol with the same name.
2512
2513 2019-04-25  Tom Tromey  <tromey@adacore.com>
2514
2515         PR gdb/24475:
2516         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2517         static.
2518
2519 2019-04-25  Tom Tromey  <tromey@adacore.com>
2520
2521         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2522         rvalue reference.
2523         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2524         (gdb_xml_parser::parse): Use std::move.
2525         * python/python-internal.h (gdbpy_convert_exception): Take a const
2526         reference.
2527         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2528         std::move.
2529         * python/py-utils.c (gdbpy_convert_exception): Take a const
2530         reference.
2531         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2532         Use std::move.
2533         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2534         Use std::move.
2535         * mi/mi-main.c (mi_print_exception): Take a const reference.
2536         * main.c (handle_command_errors): Take a const reference.
2537         * linespec.c (parse_linespec): Use std::move.
2538         * infcall.c (run_inferior_call): Use std::move.
2539         (call_function_by_hand_dummy): Use std::move.
2540         * exec.c (try_open_exec_file): Use std::move.
2541         * exceptions.h (exception_print, exception_fprintf)
2542         (exception_print_same): Update.
2543         * exceptions.c (print_exception, exception_print)
2544         (exception_fprintf, exception_print_same): Change parameters to
2545         const reference.
2546         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2547         * common/new-op.c: Use std::move.
2548         * common/common-exceptions.h (struct gdb_exception): Add move
2549         constructor.
2550         (struct gdb_exception_error, struct gdb_exception_quit, struct
2551         gdb_quit_bad_alloc): Change constructor to move constructor.
2552         (throw_exception): Change parameter to rvalue reference.
2553         * common/common-exceptions.c (throw_exception): Take rvalue
2554         reference.
2555         * cli/cli-interp.c (safe_execute_command): Use std::move.
2556         * breakpoint.c (insert_bp_location, location_to_sals): Use
2557         std::move.
2558
2559 2019-04-25  Tom Tromey  <tromey@adacore.com>
2560
2561         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2562         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2563         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2564         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2565         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2566         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2567         guile/scm-value.c: Use unpack.
2568         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2569         gdbscm_gdb_exception.
2570         (gdbscm_throw_gdb_exception): Likewise.
2571         (struct gdbscm_gdb_exception): New.
2572         (unpack): New function.
2573         (gdbscm_wrap): Use unpack.
2574
2575 2019-04-25  Tom Tromey  <tromey@adacore.com>
2576
2577         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2578         (gdb_rl_callback_handler): Use std::move.
2579         * common/common-exceptions.h (struct gdb_exception): Add move
2580         assignment operator.
2581         (throw_exception_sjlj): Change "exception" to const reference.
2582         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2583         (throw_exception_sjlj): Change "exception" to const reference.
2584
2585 2019-04-25  Tom Tromey  <tromey@adacore.com>
2586
2587         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2588         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2589         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2590         Update.
2591         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2592         Update.
2593         * mi/mi-interp.c (mi_interp::exec): Update.
2594         * linespec.c (parse_linespec): Update.
2595         * infcall.c (run_inferior_call): Update.
2596         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2597         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2598         (gdbscm_lookup_global_symbol): Update.
2599         * guile/scm-param.c (gdbscm_parameter_value): Update.
2600         * guile/scm-frame.c (gdbscm_frame_read_register)
2601         (gdbscm_frame_read_var): Update.
2602         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2603         * exec.c (try_open_exec_file): Update.
2604         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2605         (gdb_rl_callback_handler): Update.
2606         * common/common-exceptions.h (exception_none): Don't declare.
2607         * common/common-exceptions.c (exception_none): Don't define.
2608         (struct catcher) <exception>: Update.
2609         * cli/cli-interp.c (safe_execute_command): Update.
2610         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2611
2612 2019-04-25  Ali Tamur  <tamur@google.com>
2613
2614         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2615         (read_attribute_value): Likewise.
2616         (dwarf2_read_addr_index): Update comment.
2617         (read_str_index): Add DW_FORM_strx.
2618         (dwarf2_string_attr): Likewise.
2619         (dwarf2_const_value_attr): Likewise.
2620         (dump_die_shallow): Likewise.
2621         (dwarf2_fetch_constant_bytes): Likewise.
2622         (skip_form_bytes): Likewise.
2623         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2624
2625 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2626
2627         PR corefiles/11608
2628         PR corefiles/18187
2629         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2630         OFFSET.  Verify if current mapping contains an ELF header.
2631         (linux_find_memory_regions_full): Adjust call to
2632         dump_mapping_p.
2633
2634 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2635             Kang Li <kanglictf@gmail.com>
2636
2637         PR gdb/21600
2638
2639         * dwarf2-frame.c (read_initial_length): Be consistent about using
2640         unsigned representation of length.
2641         (decode_frame_entry_1): Likewise.  Check for wraparound of
2642         end pointer as well as buffer overflow.
2643
2644 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2645
2646         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2647         "vq".
2648
2649 2019-04-24  Tom Tromey  <tromey@adacore.com>
2650
2651         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2652
2653 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2654
2655         * s12z-tdep.c (s12z_unwind_pc): Delete.
2656         (s12z_unwind_sp): Delete.
2657         (s12z_gdbarch_init): Don't register deleted functions with
2658         gdbarch.
2659
2660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2661
2662         * rl78-tdep.c (rl78_unwind_sp): Delete.
2663         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2664
2665 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2668         (xstormy16_unwind_pc): Delete.
2669         (xstormy16_dummy_id): Delete.
2670         (xstormy16_gdbarch_init): Don't register deleted functions with
2671         gdbarch.
2672
2673 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2674
2675         * vax-tdep.c (vax_unwind_pc): Delete.
2676         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2677
2678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * v850-tdep.c (v850_unwind_sp): Delete.
2681         (v850_unwind_pc): Delete.
2682         (v850_dummy_id): Delete.
2683         (v850_gdbarch_init): Don't register deleted functions with
2684         gdbarch.
2685
2686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2687
2688         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2689         (tilegx_unwind_pc): Delete.
2690         (tilegx_unwind_dummy_id): Delete.
2691         (tilegx_gdbarch_init): Don't register deleted functions with
2692         gdbarch.
2693
2694 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2695
2696         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2697         (tic6x_dummy_id): Delete.
2698         (tic6x_gdbarch_init): Don't register deleted functions with
2699         gdbarch.
2700
2701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2702
2703         * sparc-tdep.c (sparc_unwind_pc): Delete.
2704         (sparc32_gdbarch_init): Don't register deleted function with
2705         gdbarch.
2706
2707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2708
2709         * sh-tdep.c (sh_unwind_sp): Delete.
2710         (sh_unwind_pc): Delete.
2711         (sh_dummy_id): Delete.
2712         (sh_gdbarch_init): Don't register deleted functions with
2713         gdbarch.
2714
2715 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2716
2717         * score-tdep.c (score_unwind_sp): Delete.
2718         (score_unwind_pc): Delete.
2719         (score_dummy_id): Delete.
2720         (score_gdbarch_init): Don't register deleted functions with
2721         gdbarch.
2722
2723 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2724
2725         * rx-tdep.c (rx_unwind_pc): Delete.
2726         (rx_unwind_sp): Delete.
2727         (rx_dummy_id): Delete.
2728         (rx_gdbarch_init): Don't register deleted functions with
2729         gdbarch.  Update comment.
2730
2731 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2732
2733         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2734         (rs6000_dummy_id): Delete.
2735         (rs6000_gdbarch_init): Don't register deleted functions with
2736         gdbarch.
2737
2738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2739
2740         * or1k-tdep.c (or1k_dummy_id): Delete.
2741         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2742
2743 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2744
2745         * nios2-tdep.c (nios2_dummy_id): Delete.
2746         (nios2_unwind_sp): Delete.
2747         (nios2_gdbarch_init): Don't register deleted functions with
2748         gdbarch.
2749
2750 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2751
2752         * nds32-tdep.c (nds32_dummy_id): Delete.
2753         (nds32_unwind_pc): Delete.
2754         (nds32_unwind_sp): Delete.
2755         (nds32_gdbarch_init): Don't register deleted functions with
2756         gdbarch.
2757
2758 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2759
2760         * msp430-tdep.c (msp430_unwind_pc): Delete.
2761         (msp430_unwind_sp): Delete.
2762         (msp430_dummy_id): Delete.
2763         (msp430_gdbarch_init): Don't register deleted functions with
2764         gdbarch.
2765
2766 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2767
2768         * moxie-tdep.c (moxie_unwind_sp): Delete.
2769         (moxie_unwind_pc): Delete.
2770         (moxie_dummy_id): Delete.
2771         (moxie_gdbarch_init): Don't register deleted functions with
2772         gdbarch.
2773
2774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2775
2776         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2777         (mn10300_unwind_pc): Delete.
2778         (mn10300_unwind_sp): Delete.
2779         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2780         mn10300_unwind_sp.
2781         (mn10300_frame_unwind_init): Don't register deleted functions with
2782         gdbarch.
2783
2784 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * mep-tdep.c (mep_unwind_pc): Delete.
2787         (mep_unwind_sp): Delete.
2788         (mep_dummy_id): Delete.
2789         (mep_gdbarch_init): Don't register deleted functions with
2790         gdbarch.
2791
2792 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2793
2794         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2795         (m68hc11_unwind_sp): Delete.
2796         (m68hc11_gdbarch_init): Don't register deleted functions with
2797         gdbarch.
2798
2799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2800
2801         * m32r-tdep.c (m32r_unwind_sp): Delete.
2802         (m32r_unwind_pc): Delete.
2803         (m32r_dummy_id): Delete.
2804         (m32r_gdbarch_init): Don't register deleted functions with
2805         gdbarch.
2806
2807 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2808
2809         * m32c-tdep.c (m32c_unwind_pc): Delete.
2810         (m32c_unwind_sp): Delete.
2811         (m32c_dummy_id): Delete.
2812         (m32c_gdbarch_init): Don't register deleted functions with
2813         gdbarch.
2814
2815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2818         (lm32_unwind_pc): Delete.
2819         (lm32_dummy_id): Delete.
2820         (lm32_gdbarch_init): Don't register deleted functions with
2821         gdbarch.
2822
2823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2826         (iq2000_unwind_pc): Delete.
2827         (iq2000_dummy_id): Delete.
2828         (iq2000_gdbarch_init): Don't register deleted functions with
2829         gdbarch.
2830
2831 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2832
2833         * nds32-tdep.c (nds32_type_align): Delete.
2834         (nds32_push_dummy_call): Use type_align instead.
2835
2836 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * arm-tdep.c (arm_type_align): Only handle vector override case.
2839         (arm_push_dummy_call): Use type_align.
2840         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2841
2842 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2843
2844         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2845         case.
2846         (pass_on_stack): Use type_align.
2847         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2848         function.
2849
2850 2019-04-23  Tom Tromey  <tromey@adacore.com>
2851
2852         * dwarf2read.c (line_header::file_name_at): Remove unused
2853         overload.
2854
2855 2019-04-23  Tom de Vries  <tdevries@suse.de>
2856
2857         PR gdb/24438
2858         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2859         invocation.
2860
2861
2862 2019-03-27  Ali Tamur  <tamur@google.com>
2863
2864         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2865         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2866         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2867         (dwarf_expr_context::get_addr_index): Likewise
2868         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2869         (symbol_needs_eval_context::get_addr_index): Likewise
2870         (disassemble_dwarf_expression): Add DW_OP_addrx
2871         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2872         (read_cutu_die_from_dwo): Update comment
2873         (skip_one_die): Add DW_FORM_addrx
2874         (read_attribute_value): Likewise
2875         (var_decode_location): Add DW_OP_addrx
2876         (dwarf2_const_value_attr): Add DW_FORM_addrx
2877         (dump_die_shallow): Likewise
2878         (dwarf2_fetch_constant_bytes): Likewise
2879         (decode_locdesc): Add DW_OP_addrx
2880         (skip_form_bytes): Add DW_FORM_addrx
2881
2882 2019-04-22  Ali Tamur  <tamur@google.com>
2883
2884         * MAINTAINERS (Write After Approval): Add self.
2885
2886 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2887
2888         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2889         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2890         (open_symbol_file_object): Likewise.
2891         (svr4_default_sos): Add info parameter.
2892         (svr4_read_so_list): Likewise.
2893         (svr4_current_sos_direct): Adjust functions calls to pass down
2894         info.
2895         (svr4_current_sos_1): Add info parameter.
2896         (svr4_current_sos): Call get_svr4_info, pass info down to
2897         svr4_current_sos_1.
2898         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2899         get_svr4_info.
2900         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2901         get_svr4_info.
2902         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2903         to get_svr4_info.
2904         (probes_table_remove_objfile_probes): Likewise.
2905         (register_solib_event_probe): Add info parameter.
2906         (solist_update_incremental): Pass info parameter down to
2907         svr4_read_so_list.
2908         (disable_probes_interface): Add info parameter.
2909         (svr4_handle_solib_event): Pass current_program_space to
2910         get_svr4_info.  Adjust disable_probes_interface cleanup.
2911         (svr4_create_probe_breakpoints): Add info parameter, pass it
2912         down to register_solib_event_probe.
2913         (svr4_create_solib_event_breakpoints): Add info parameter,
2914         pass it down to svr4_create_probe_breakpoints.
2915         (enable_break): Pass info down to
2916         svr4_create_solib_event_breakpoints.
2917         (svr4_solib_create_inferior_hook): Pass current_program_space to
2918         get_svr4_info.
2919         (svr4_clear_solib): Likewise.
2920
2921 2019-04-22  Pedro Alves  <palves@redhat.com>
2922
2923         * solib-svr4.c (svr4_free_objfile_observer): New.
2924         (probe_and_action::objfile): New field.
2925         (probes_table_htab_remove_objfile_probes)
2926         (probes_table_remove_objfile_probes): New functions.
2927         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2928         in the new probe_and_action.  Don't store the probe in 'lookup'.
2929         (svr4_create_probe_breakpoints): Pass objfile to
2930         register_solib_event_probe.
2931         (_initialize_svr4_solib): Register a free_objfile observer.
2932
2933 2019-04-19  Tom Tromey  <tom@tromey.com>
2934
2935         * common/queue.h: Remove.
2936
2937 2019-04-19  Tom Tromey  <tom@tromey.com>
2938
2939         * event-loop.c: Don't include "common/queue.h".
2940
2941 2019-04-19  Tom Tromey  <tom@tromey.com>
2942
2943         * remote.c (remote_target): Use delete.
2944         * remote-notif.h: Include <list>, not "common/queue.h".
2945         (notif_client_p): Remove typedef.
2946         (remote_notif_state): Add constructor, destructor, initializer.
2947         <notif_queue>: Now a std::list.
2948         (remote_notif_state_xfree): Don't declare.
2949         * remote-notif.c (remote_notif_process, handle_notification)
2950         (remote_notif_state_allocate): Update.
2951         (~remote_notif_state): Rename from remote_notif_state_xfree.
2952
2953 2019-04-19  Tom Tromey  <tom@tromey.com>
2954
2955         * symfile.c (reread_symbols): Update.
2956         * objfiles.c (objfile_register_static_link)
2957         (objfile_lookup_static_link): Update
2958         (~objfile) Don't delete static_links.
2959         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2960
2961 2019-04-19  Tom Tromey  <tom@tromey.com>
2962
2963         * type-stack.h (struct type_stack) <insert>: Constify string.
2964         * type-stack.c (type_stack::insert): Constify string.
2965         * gdbtypes.h (lookup_template_type): Update.
2966         (address_space_name_to_int): Update.
2967         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2968         const.
2969         (lookup_template_type): Make name const.
2970         * c-exp.y: Update rules.
2971         (lex_one_token, classify_name, classify_inner_name)
2972         (c_print_token): Update.
2973         * p-exp.y: Update rules.
2974         (yylex): Update.
2975         * f-exp.y: Update rules.
2976         (yylex): Update.
2977         * d-exp.y: Update rules.
2978         (lex_one_token, classify_name, classify_inner_name): Update.
2979         * parse.c (write_dollar_variable, copy_name): Return std::string.
2980         * parser-defs.h (copy_name): Change return type.
2981         * m2-exp.y: Update rules.
2982         (yylex): Update.
2983         * go-exp.y (lex_one_token): Update.
2984         Update rules.
2985         (classify_unsafe_function, classify_packaged_name)
2986         (classify_name, yylex): Update.
2987
2988 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2989
2990         * configure.ac: add --enable-source-highlight switch.
2991         * configure: Regenerate.
2992         * top.c (print_gdb_version): plumb --enable-source-highlight
2993         status to "show configuration".
2994
2995 2019-04-19  Tom Tromey  <tromey@adacore.com>
2996
2997         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2998         Check ADA_TYPE_P.
2999         (empty_record, ada_template_to_fixed_record_type_1)
3000         (template_to_static_fixed_type)
3001         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3002         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3003         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3004         macros.
3005
3006 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3007
3008         PR symtab/24423:
3009         * source.c (print_source_lines_base): Advance "iter" when a
3010         control character is seen.
3011
3012 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3013
3014         * inferior.h (struct infcall_suspend_state_deleter):
3015         Catch exception in destructor to avoid crash.
3016
3017 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3018
3019         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3020         close to the add_com "shell".
3021
3022 2019-04-18  Tom Tromey  <tromey@adacore.com>
3023
3024         * process-stratum-target.h (class process_stratum_target)
3025         <stratum>: Add "final".
3026
3027 2019-04-17  Tom Tromey  <tromey@adacore.com>
3028
3029         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3030         against nullptr before use.
3031
3032 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3033
3034         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3035
3036 2019-04-17  Jim Wilson  <jimw@sifive.com>
3037             Andrew Burgess  <andrew.burgess@embecosm.com>
3038
3039         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3040         code read might fail, assume 4-byte breakpoint in that case.
3041
3042 2019-04-15  Leszek Swirski  <leszeks@google.com>
3043
3044         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3045         rather than a hand-rolled POD check when checking for forced MEMORY
3046         classification.
3047
3048 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3049
3050         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3051         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3052         function.
3053         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3054         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3055         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3056         declaration.
3057
3058 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3059
3060         * aarch64-linux-nat.c
3061         (aarch64_linux_nat_target::thread_architecture): Add override.
3062         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3063         each VQ.
3064
3065 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3066
3067         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3068
3069 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3070
3071         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3072         target types of size 96-bits, add some additional comments, and
3073         check that the builtin type we found was the correct size.
3074
3075 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3076
3077         * utils.c (prompt_for_continue): Don't restore the styling at the
3078         end, as applied_style has the wrong value.  This fixes styling in
3079         long lists of file names that are interrupted by the "Continue?"
3080         prompt.
3081
3082 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3083
3084         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3085         * c-lang.c (c_language_defn): Likewise.
3086         (cplus_language_defn): Likewise.
3087         (asm_language_defn): Likewise.
3088         (minimal_language_defn): Likewise.
3089         * d-lang.c (d_language_defn): Likewise.
3090         * f-lang.c (f_language_defn): Likewise.
3091         * go-lang.c (go_language_defn): Likewise.
3092         * language.c (unknown_language_defn): Likewise.
3093         (auto_language_defn): Likewise.
3094         * language.h (struct language_defn): Remove la_magic field.
3095         (LANG_MAGIC): Delete.
3096         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3097         * objc-lang.c (objc_language_defn): Likewise.
3098         * opencl-lang.c (opencl_language_defn): Likewise.
3099         * p-lang.c (pascal_language_defn): Likewise.
3100         * rust-lang.c (rust_language_defn): Likewise.
3101
3102 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3103
3104         * riscv-tdep.c (riscv_type_align): New function.
3105         (riscv_type_alignment): Delete.
3106         (riscv_arg_location): Use 'type_align'.
3107         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3108
3109 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3110
3111         * gdbtypes.c (type_align): A struct with no non-static fields also
3112         has alignment of 1.
3113
3114 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3115
3116         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3117         component to 0.
3118         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3119         member.
3120         (riscv_struct_info::analyse): New implementation using new
3121         analyse_inner member function.
3122         (riscv_struct_info::field_offset): New member function.
3123         (riscv_struct_info::m_offsets): New member variable.
3124         (riscv_struct_info::analyse_inner): New private member function,
3125         takes the old implementation of riscv_struct_info::analyse but
3126         extended to track field offsets.
3127         (riscv_call_arg_struct): Update the struct folding special cases
3128         to handle cases where empty C++ structs, which are non-zero
3129         length, are found.
3130         (riscv_arg_location): Initialise the length of each location, a
3131         non-zero length now indicates the location is in use.
3132         (riscv_push_dummy_call): Allow for the first location having a
3133         non-zero offset when setting up arguments.
3134         (riscv_return_value): Likewise, but for return values.
3135
3136 2019-04-11  Tom Tromey  <tromey@adacore.com>
3137
3138         * utils.c (internal_vproblem): Make "msg" const.
3139
3140 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3141
3142         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3143         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3144         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3145         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3146
3147 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3148
3149         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3150         function.
3151         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3152         of amd64_collect_native_gregset.
3153         (amd64_linux_nat_target::store_registers): Likewise.
3154
3155 2019-04-10  Tom Tromey  <tom@tromey.com>
3156
3157         * symtab.c (lookup_global_symbol_from_objfile)
3158         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3159         * objfiles.h (class separate_debug_iterator): New.
3160         (class separate_debug_range): New.
3161         (struct objfile) <separate_debug_objfiles>: New method.
3162         (objfile_separate_debug_iterate): Don't declare.
3163         * objfiles.c (separate_debug_iterator::operator++): Rename from
3164         objfile_separate_debug_iterate.
3165         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3166         iterator.
3167         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3168         iterator.
3169
3170 2019-04-10  Tom Tromey  <tom@tromey.com>
3171
3172         * symfile.c (reread_symbols): Remove old comment.
3173         * objfiles.c (free_all_objfiles): Fix a typo.
3174
3175 2019-04-10  Tom Tromey  <tom@tromey.com>
3176
3177         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3178         * minsyms.c (lookup_minimal_symbol): Use foreach.
3179         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3180         (lookup_minimal_symbol_solib_trampoline): Likewise.
3181         * symfile.c (reread_symbols): Use foreach.
3182
3183 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3184             Tom Tromey  <tromey@adacore.com>
3185
3186         PR rust/24414:
3187         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3188         (rust_lex_int_test): Change "value" to be LONGEST.
3189         (rust_lex_tests): Add test for long integer literal.
3190
3191 2019-04-09  Tom Tromey  <tromey@adacore.com>
3192
3193         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3194         to bool.
3195         (extended_remote_target::attach): Update.
3196         (remote_target::remote_notice_new_inferior): Update.
3197         (remote_target::add_current_inferior_and_thread): Update.
3198         * inferior.c (exit_inferior_1): Use "false".
3199         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3200
3201 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3202
3203         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3204         the "start" command.
3205
3206 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3207
3208         * python/py-inferior.c (infpy_thread_from_thread_handle):
3209         Adjust comments to reflect renaming of thread_from_thread_handle
3210         to thread_from_handle.  Adjust keywords.  Fix type error message.
3211         (inferior_object_methods): Add thread_from_handle.  Retain
3212         thread_from_thread_handle, but mark it as deprecated.
3213
3214 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3215
3216         * gdbthread.h (find_thread_by_handle): Revise declaration.
3217         * thread.c (find_thread_by_handle): Likewise.  Adjust
3218         implementation too.
3219         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3220         support for buffer objects as handles.
3221
3222 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3223
3224         * python/py-infthread.c (thpy_thread_handle): New function.
3225         (thread_object_methods): Register thpy_thread_handle.
3226
3227 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3228
3229         * gdbthread.h (thread_to_thread_handle): Declare.
3230         * thread.c (gdbtypes.h): Include.
3231         (thread_to_thread_handle): New function.
3232
3233         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3234         (target_thread_info_to_thread_handle): Declare.
3235         * target.c (target_thread_info_to_thread_handle): New function.
3236         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3237         * target-delegates.c: Regenerate.
3238
3239         * linux-thread-db.c (class thread_db_target): Add method
3240         thread_info_to_thread_handle.
3241         (thread_db_target::thread_info_to_thread_handle): Define.
3242         * remote.c (class remote_target): Add new method
3243         thread_info_to_thread_handle.
3244         (remote_target::thread_info_to_thread_handle): Define.
3245
3246 2019-04-08  Pedro Alves  <palves@redhat.com>
3247
3248         * common/common-exceptions.c (throw_exception): Don't create
3249         named object to throw; throw directly.
3250         (throw_it): Likewise.  Don't initialize gdb_exception::message
3251         here, with new; pass FMT and AP to the ctor instead.
3252         * common/common-exceptions.h: Include <string>.
3253         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3254         const char *, va_list)): New ctor.  Use std::make_shared.
3255         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3256         errors)): Delete.
3257         (gdb_exception_error::gdb_exception_error(enum errors, const char
3258         *, va_list)): New.
3259         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3260         Add assertion.
3261         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3262         errors)): Delete.
3263         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3264         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3265         Add assertion.
3266
3267 2019-04-08  Tom Tromey  <tom@tromey.com>
3268
3269         * valops.c (value_rtti_indirect_type): Replace throw_exception
3270         with throw.
3271         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3272         with throw.
3273         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3274         throw.
3275         * target.c (target_translate_tls_address): Replace throw_exception
3276         with throw.
3277         * stack.c (frame_apply_command_count): Replace throw_exception
3278         with throw.
3279         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3280         throw.
3281         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3282         with throw.
3283         * rs6000-tdep.c (rs6000_frame_cache)
3284         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3285         * remote.c: Replace throw_exception with throw.
3286         * record-full.c (record_full_message, record_full_wait_1)
3287         (record_full_restore): Replace throw_exception with throw.
3288         * record-btrace.c:
3289         (get_thread_current_frame_id, record_btrace_start_replaying)
3290         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3291         (cmd_record_btrace_start): Replace throw_exception with throw.
3292         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3293         throw.
3294         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3295         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3296         * linespec.c:
3297         (find_linespec_symbols): Replace throw_exception with throw.
3298         * infrun.c (displaced_step_prepare, resume): Replace
3299         throw_exception with throw.
3300         * infcmd.c (post_create_inferior): Replace throw_exception with
3301         throw.
3302         * inf-loop.c (inferior_event_handler): Replace throw_exception
3303         with throw.
3304         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3305         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3306         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3307         (get_prev_frame_always, get_frame_pc_if_available)
3308         (get_frame_address_in_block_if_available, get_frame_language):
3309         Replace throw_exception with throw.
3310         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3311         throw_exception with throw.
3312         * eval.c (fetch_subexp_value, evaluate_var_value)
3313         (evaluate_funcall, evaluate_subexp_standard): Replace
3314         throw_exception with throw.
3315         * dwarf2loc.c (call_site_find_chain)
3316         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3317         Replace throw_exception with throw.
3318         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3319         with throw.
3320         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3321         throw.
3322         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3323         * completer.c (complete_line_internal): Replace throw_exception
3324         with throw.
3325         * compile/compile-object-run.c (compile_object_run): Replace
3326         throw_exception with throw.
3327         * cli/cli-script.c (process_next_line): Replace throw_exception
3328         with throw.
3329         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3330         (btrace_enable, btrace_maint_update_pt_packets): Replace
3331         throw_exception with throw.
3332         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3333         throw_exception with throw.
3334         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3335         throw_exception with throw.
3336         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3337         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3338         * aarch64-tdep.c (aarch64_make_prologue_cache)
3339         (aarch64_make_stub_cache): Replace throw_exception with throw.
3340
3341 2019-04-08  Tom Tromey  <tom@tromey.com>
3342
3343         * common/common-exceptions.c (throw_exception): Rename from
3344         throw_exception_cxx.  Remove old copy.  Make argument const.
3345         (throw_it): Create and throw exception objects directly.
3346         * common/common-exceptions.h (throw_exception): Make argument
3347         const.
3348         (struct gdb_exception_error): Add constructor.
3349         (struct gdb_exception_quit): Add constructor.
3350
3351 2019-04-08  Tom Tromey  <tom@tromey.com>
3352
3353         * common/common-exceptions.h (exception_rethrow): Don't declare.
3354         (TRY_SJLJ): Update comment.
3355         (TRY, CATCH, END_CATCH): Remove.
3356         * common/common-exceptions.c (exception_rethrow): Remove.
3357
3358 2019-04-08  Tom Tromey  <tom@tromey.com>
3359
3360         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3361         Remove.
3362         (gdb_exception_error): Rename from
3363         gdb_exception_RETURN_MASK_ERROR.
3364         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3365         (gdb_quit_bad_alloc): Update.
3366         * aarch64-tdep.c: Update.
3367         * ada-lang.c: Update.
3368         * ada-typeprint.c: Update.
3369         * ada-valprint.c: Update.
3370         * amd64-tdep.c: Update.
3371         * arch-utils.c: Update.
3372         * break-catch-throw.c: Update.
3373         * breakpoint.c: Update.
3374         * btrace.c: Update.
3375         * c-varobj.c: Update.
3376         * cli/cli-cmds.c: Update.
3377         * cli/cli-interp.c: Update.
3378         * cli/cli-script.c: Update.
3379         * common/common-exceptions.c: Update.
3380         * common/new-op.c: Update.
3381         * common/selftest.c: Update.
3382         * compile/compile-c-symbols.c: Update.
3383         * compile/compile-cplus-symbols.c: Update.
3384         * compile/compile-object-load.c: Update.
3385         * compile/compile-object-run.c: Update.
3386         * completer.c: Update.
3387         * corelow.c: Update.
3388         * cp-abi.c: Update.
3389         * cp-support.c: Update.
3390         * cp-valprint.c: Update.
3391         * darwin-nat.c: Update.
3392         * disasm-selftests.c: Update.
3393         * dtrace-probe.c: Update.
3394         * dwarf-index-cache.c: Update.
3395         * dwarf-index-write.c: Update.
3396         * dwarf2-frame-tailcall.c: Update.
3397         * dwarf2-frame.c: Update.
3398         * dwarf2loc.c: Update.
3399         * dwarf2read.c: Update.
3400         * eval.c: Update.
3401         * event-loop.c: Update.
3402         * event-top.c: Update.
3403         * exec.c: Update.
3404         * f-valprint.c: Update.
3405         * fbsd-tdep.c: Update.
3406         * frame-unwind.c: Update.
3407         * frame.c: Update.
3408         * gdbtypes.c: Update.
3409         * gnu-v3-abi.c: Update.
3410         * guile/guile-internal.h: Update.
3411         * guile/scm-block.c: Update.
3412         * guile/scm-breakpoint.c: Update.
3413         * guile/scm-cmd.c: Update.
3414         * guile/scm-disasm.c: Update.
3415         * guile/scm-frame.c: Update.
3416         * guile/scm-lazy-string.c: Update.
3417         * guile/scm-math.c: Update.
3418         * guile/scm-param.c: Update.
3419         * guile/scm-ports.c: Update.
3420         * guile/scm-pretty-print.c: Update.
3421         * guile/scm-symbol.c: Update.
3422         * guile/scm-symtab.c: Update.
3423         * guile/scm-type.c: Update.
3424         * guile/scm-value.c: Update.
3425         * i386-linux-tdep.c: Update.
3426         * i386-tdep.c: Update.
3427         * inf-loop.c: Update.
3428         * infcall.c: Update.
3429         * infcmd.c: Update.
3430         * infrun.c: Update.
3431         * jit.c: Update.
3432         * language.c: Update.
3433         * linespec.c: Update.
3434         * linux-fork.c: Update.
3435         * linux-nat.c: Update.
3436         * linux-tdep.c: Update.
3437         * linux-thread-db.c: Update.
3438         * main.c: Update.
3439         * mi/mi-cmd-break.c: Update.
3440         * mi/mi-cmd-stack.c: Update.
3441         * mi/mi-interp.c: Update.
3442         * mi/mi-main.c: Update.
3443         * objc-lang.c: Update.
3444         * p-valprint.c: Update.
3445         * parse.c: Update.
3446         * ppc-linux-tdep.c: Update.
3447         * printcmd.c: Update.
3448         * python/py-arch.c: Update.
3449         * python/py-breakpoint.c: Update.
3450         * python/py-cmd.c: Update.
3451         * python/py-finishbreakpoint.c: Update.
3452         * python/py-frame.c: Update.
3453         * python/py-framefilter.c: Update.
3454         * python/py-gdb-readline.c: Update.
3455         * python/py-inferior.c: Update.
3456         * python/py-infthread.c: Update.
3457         * python/py-lazy-string.c: Update.
3458         * python/py-linetable.c: Update.
3459         * python/py-objfile.c: Update.
3460         * python/py-param.c: Update.
3461         * python/py-prettyprint.c: Update.
3462         * python/py-progspace.c: Update.
3463         * python/py-record-btrace.c: Update.
3464         * python/py-record.c: Update.
3465         * python/py-symbol.c: Update.
3466         * python/py-type.c: Update.
3467         * python/py-unwind.c: Update.
3468         * python/py-utils.c: Update.
3469         * python/py-value.c: Update.
3470         * python/python.c: Update.
3471         * record-btrace.c: Update.
3472         * record-full.c: Update.
3473         * remote-fileio.c: Update.
3474         * remote.c: Update.
3475         * riscv-tdep.c: Update.
3476         * rs6000-aix-tdep.c: Update.
3477         * rs6000-tdep.c: Update.
3478         * rust-exp.y: Update.
3479         * rust-lang.c: Update.
3480         * s390-tdep.c: Update.
3481         * selftest-arch.c: Update.
3482         * solib-dsbt.c: Update.
3483         * solib-frv.c: Update.
3484         * solib-spu.c: Update.
3485         * solib-svr4.c: Update.
3486         * solib.c: Update.
3487         * sparc64-linux-tdep.c: Update.
3488         * stack.c: Update.
3489         * symfile-mem.c: Update.
3490         * symmisc.c: Update.
3491         * target.c: Update.
3492         * thread.c: Update.
3493         * top.c: Update.
3494         * tracefile-tfile.c: Update.
3495         * tui/tui.c: Update.
3496         * typeprint.c: Update.
3497         * unittests/cli-utils-selftests.c: Update.
3498         * unittests/parse-connection-spec-selftests.c: Update.
3499         * valops.c: Update.
3500         * valprint.c: Update.
3501         * value.c: Update.
3502         * varobj.c: Update.
3503         * windows-nat.c: Update.
3504         * x86-linux-nat.c: Update.
3505         * xml-support.c: Update.
3506
3507 2019-04-08  Tom Tromey  <tom@tromey.com>
3508
3509         * xml-support.c: Use C++ exception handling.
3510         * x86-linux-nat.c: Use C++ exception handling.
3511         * windows-nat.c: Use C++ exception handling.
3512         * varobj.c: Use C++ exception handling.
3513         * value.c: Use C++ exception handling.
3514         * valprint.c: Use C++ exception handling.
3515         * valops.c: Use C++ exception handling.
3516         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3517         handling.
3518         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3519         * typeprint.c: Use C++ exception handling.
3520         * tui/tui.c: Use C++ exception handling.
3521         * tracefile-tfile.c: Use C++ exception handling.
3522         * top.c: Use C++ exception handling.
3523         * thread.c: Use C++ exception handling.
3524         * target.c: Use C++ exception handling.
3525         * symmisc.c: Use C++ exception handling.
3526         * symfile-mem.c: Use C++ exception handling.
3527         * stack.c: Use C++ exception handling.
3528         * sparc64-linux-tdep.c: Use C++ exception handling.
3529         * solib.c: Use C++ exception handling.
3530         * solib-svr4.c: Use C++ exception handling.
3531         * solib-spu.c: Use C++ exception handling.
3532         * solib-frv.c: Use C++ exception handling.
3533         * solib-dsbt.c: Use C++ exception handling.
3534         * selftest-arch.c: Use C++ exception handling.
3535         * s390-tdep.c: Use C++ exception handling.
3536         * rust-lang.c: Use C++ exception handling.
3537         * rust-exp.y: Use C++ exception handling.
3538         * rs6000-tdep.c: Use C++ exception handling.
3539         * rs6000-aix-tdep.c: Use C++ exception handling.
3540         * riscv-tdep.c: Use C++ exception handling.
3541         * remote.c: Use C++ exception handling.
3542         * remote-fileio.c: Use C++ exception handling.
3543         * record-full.c: Use C++ exception handling.
3544         * record-btrace.c: Use C++ exception handling.
3545         * python/python.c: Use C++ exception handling.
3546         * python/py-value.c: Use C++ exception handling.
3547         * python/py-utils.c: Use C++ exception handling.
3548         * python/py-unwind.c: Use C++ exception handling.
3549         * python/py-type.c: Use C++ exception handling.
3550         * python/py-symbol.c: Use C++ exception handling.
3551         * python/py-record.c: Use C++ exception handling.
3552         * python/py-record-btrace.c: Use C++ exception handling.
3553         * python/py-progspace.c: Use C++ exception handling.
3554         * python/py-prettyprint.c: Use C++ exception handling.
3555         * python/py-param.c: Use C++ exception handling.
3556         * python/py-objfile.c: Use C++ exception handling.
3557         * python/py-linetable.c: Use C++ exception handling.
3558         * python/py-lazy-string.c: Use C++ exception handling.
3559         * python/py-infthread.c: Use C++ exception handling.
3560         * python/py-inferior.c: Use C++ exception handling.
3561         * python/py-gdb-readline.c: Use C++ exception handling.
3562         * python/py-framefilter.c: Use C++ exception handling.
3563         * python/py-frame.c: Use C++ exception handling.
3564         * python/py-finishbreakpoint.c: Use C++ exception handling.
3565         * python/py-cmd.c: Use C++ exception handling.
3566         * python/py-breakpoint.c: Use C++ exception handling.
3567         * python/py-arch.c: Use C++ exception handling.
3568         * printcmd.c: Use C++ exception handling.
3569         * ppc-linux-tdep.c: Use C++ exception handling.
3570         * parse.c: Use C++ exception handling.
3571         * p-valprint.c: Use C++ exception handling.
3572         * objc-lang.c: Use C++ exception handling.
3573         * mi/mi-main.c: Use C++ exception handling.
3574         * mi/mi-interp.c: Use C++ exception handling.
3575         * mi/mi-cmd-stack.c: Use C++ exception handling.
3576         * mi/mi-cmd-break.c: Use C++ exception handling.
3577         * main.c: Use C++ exception handling.
3578         * linux-thread-db.c: Use C++ exception handling.
3579         * linux-tdep.c: Use C++ exception handling.
3580         * linux-nat.c: Use C++ exception handling.
3581         * linux-fork.c: Use C++ exception handling.
3582         * linespec.c: Use C++ exception handling.
3583         * language.c: Use C++ exception handling.
3584         * jit.c: Use C++ exception handling.
3585         * infrun.c: Use C++ exception handling.
3586         * infcmd.c: Use C++ exception handling.
3587         * infcall.c: Use C++ exception handling.
3588         * inf-loop.c: Use C++ exception handling.
3589         * i386-tdep.c: Use C++ exception handling.
3590         * i386-linux-tdep.c: Use C++ exception handling.
3591         * guile/scm-value.c: Use C++ exception handling.
3592         * guile/scm-type.c: Use C++ exception handling.
3593         * guile/scm-symtab.c: Use C++ exception handling.
3594         * guile/scm-symbol.c: Use C++ exception handling.
3595         * guile/scm-pretty-print.c: Use C++ exception handling.
3596         * guile/scm-ports.c: Use C++ exception handling.
3597         * guile/scm-param.c: Use C++ exception handling.
3598         * guile/scm-math.c: Use C++ exception handling.
3599         * guile/scm-lazy-string.c: Use C++ exception handling.
3600         * guile/scm-frame.c: Use C++ exception handling.
3601         * guile/scm-disasm.c: Use C++ exception handling.
3602         * guile/scm-cmd.c: Use C++ exception handling.
3603         * guile/scm-breakpoint.c: Use C++ exception handling.
3604         * guile/scm-block.c: Use C++ exception handling.
3605         * guile/guile-internal.h: Use C++ exception handling.
3606         * gnu-v3-abi.c: Use C++ exception handling.
3607         * gdbtypes.c: Use C++ exception handling.
3608         * frame.c: Use C++ exception handling.
3609         * frame-unwind.c: Use C++ exception handling.
3610         * fbsd-tdep.c: Use C++ exception handling.
3611         * f-valprint.c: Use C++ exception handling.
3612         * exec.c: Use C++ exception handling.
3613         * event-top.c: Use C++ exception handling.
3614         * event-loop.c: Use C++ exception handling.
3615         * eval.c: Use C++ exception handling.
3616         * dwarf2read.c: Use C++ exception handling.
3617         * dwarf2loc.c: Use C++ exception handling.
3618         * dwarf2-frame.c: Use C++ exception handling.
3619         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3620         * dwarf-index-write.c: Use C++ exception handling.
3621         * dwarf-index-cache.c: Use C++ exception handling.
3622         * dtrace-probe.c: Use C++ exception handling.
3623         * disasm-selftests.c: Use C++ exception handling.
3624         * darwin-nat.c: Use C++ exception handling.
3625         * cp-valprint.c: Use C++ exception handling.
3626         * cp-support.c: Use C++ exception handling.
3627         * cp-abi.c: Use C++ exception handling.
3628         * corelow.c: Use C++ exception handling.
3629         * completer.c: Use C++ exception handling.
3630         * compile/compile-object-run.c: Use C++ exception handling.
3631         * compile/compile-object-load.c: Use C++ exception handling.
3632         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3633         * compile/compile-c-symbols.c: Use C++ exception handling.
3634         * common/selftest.c: Use C++ exception handling.
3635         * common/new-op.c: Use C++ exception handling.
3636         * cli/cli-script.c: Use C++ exception handling.
3637         * cli/cli-interp.c: Use C++ exception handling.
3638         * cli/cli-cmds.c: Use C++ exception handling.
3639         * c-varobj.c: Use C++ exception handling.
3640         * btrace.c: Use C++ exception handling.
3641         * breakpoint.c: Use C++ exception handling.
3642         * break-catch-throw.c: Use C++ exception handling.
3643         * arch-utils.c: Use C++ exception handling.
3644         * amd64-tdep.c: Use C++ exception handling.
3645         * ada-valprint.c: Use C++ exception handling.
3646         * ada-typeprint.c: Use C++ exception handling.
3647         * ada-lang.c: Use C++ exception handling.
3648         * aarch64-tdep.c: Use C++ exception handling.
3649
3650 2019-04-08  Tom Tromey  <tom@tromey.com>
3651
3652         * xml-support.c (gdb_xml_parser::parse): Update.
3653         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3654         * value.c (show_convenience): Update.
3655         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3656         (test_parse_flags_qcs): Update.
3657         * thread.c (thr_try_catch_cmd): Update.
3658         * target.c (target_translate_tls_address): Update.
3659         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3660         (info_frame_command_core, frame_apply_command_count): Update.
3661         * rust-exp.y (rust_lex_exception_test): Update.
3662         * riscv-tdep.c (riscv_print_one_register_info): Update.
3663         * remote.c (remote_target::enable_btrace): Update.
3664         * record-btrace.c (record_btrace_enable_warn): Update.
3665         * python/py-utils.c (gdbpy_convert_exception): Update.
3666         * printcmd.c (do_one_display, print_variable_and_value): Update.
3667         * mi/mi-main.c (mi_print_exception): Update.
3668         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3669         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3670         * linux-nat.c (linux_nat_target::attach): Update.
3671         * linux-fork.c (class scoped_switch_fork_info): Update.
3672         * infrun.c (displaced_step_prepare): Update.
3673         * infcall.c (call_function_by_hand_dummy): Update.
3674         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3675         * gnu-v3-abi.c (print_one_vtable): Update.
3676         * frame.c (get_prev_frame_always): Update.
3677         * f-valprint.c (info_common_command_for_block): Update.
3678         * exec.c (try_open_exec_file): Update.
3679         * exceptions.c (print_exception, exception_print)
3680         (exception_fprintf, exception_print_same): Update.
3681         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3682         * dwarf-index-cache.c (index_cache::store)
3683         (index_cache::lookup_gdb_index): Update.
3684         * darwin-nat.c (maybe_cache_shell): Update.
3685         * cp-valprint.c (cp_print_value_fields): Update.
3686         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3687         (gcc_cplus_symbol_address): Update.
3688         * compile/compile-c-symbols.c (gcc_convert_symbol)
3689         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3690         * common/selftest.c: Update.
3691         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3692         a std::string.
3693         (exception_try_scope_entry, exception_try_scope_exit): Don't
3694         declare.
3695         (struct exception_try_scope): Remove.
3696         (TRY): Don't use exception_try_scope.
3697         (struct gdb_exception): Add constructor, operator=.
3698         <what>: New method.
3699         (struct gdb_exception_RETURN_MASK_ALL)
3700         (struct gdb_exception_RETURN_MASK_ERROR)
3701         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3702         (struct gdb_quit_bad_alloc): Update.
3703         * common/common-exceptions.c (exception_none): Change
3704         initializer.
3705         (struct catcher) <state, exception>: Initialize inline.
3706         <prev>: Remove member.
3707         (current_catcher): Remove.
3708         (catchers): New global.
3709         (exceptions_state_mc_init): Simplify.
3710         (catcher_pop): Remove.
3711         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3712         (try_scope_depth, exception_try_scope_entry)
3713         (exception_try_scope_exit): Remove.
3714         (throw_exception_sjlj): Update.
3715         (exception_messages, exception_messages_size): Remove.
3716         (throw_it): Simplify.
3717         (gdb_exception_sliced_copy): Remove.
3718         (throw_exception_cxx): Update.
3719         * cli/cli-script.c (script_from_file): Update.
3720         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3721         Update.
3722         * ada-valprint.c (ada_val_print): Update.
3723         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3724         (create_excep_cond_exprs): Update.
3725
3726 2019-04-08  Tom Tromey  <tom@tromey.com>
3727
3728         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3729         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3730         (TRY, CATCH, END_CATCH): Remove some definitions.
3731         * common/common-exceptions.c: Don't use GDB_XCPT.
3732         (catcher_list_size): Remove.
3733         (throw_exception, throw_it): Simplify.
3734
3735 2019-04-05  Tom Tromey  <tom@tromey.com>
3736
3737         Revert the header-sorting patch.
3738         * ft32-tdep.c: Revert.
3739         * frv-tdep.c: Revert.
3740         * frv-linux-tdep.c: Revert.
3741         * frame.c: Revert.
3742         * frame-unwind.c: Revert.
3743         * frame-base.c: Revert.
3744         * fork-child.c: Revert.
3745         * findvar.c: Revert.
3746         * findcmd.c: Revert.
3747         * filesystem.c: Revert.
3748         * filename-seen-cache.h: Revert.
3749         * filename-seen-cache.c: Revert.
3750         * fbsd-tdep.c: Revert.
3751         * fbsd-nat.h: Revert.
3752         * fbsd-nat.c: Revert.
3753         * f-valprint.c: Revert.
3754         * f-typeprint.c: Revert.
3755         * f-lang.c: Revert.
3756         * extension.h: Revert.
3757         * extension.c: Revert.
3758         * extension-priv.h: Revert.
3759         * expprint.c: Revert.
3760         * exec.h: Revert.
3761         * exec.c: Revert.
3762         * exceptions.c: Revert.
3763         * event-top.c: Revert.
3764         * event-loop.c: Revert.
3765         * eval.c: Revert.
3766         * elfread.c: Revert.
3767         * dwarf2read.h: Revert.
3768         * dwarf2read.c: Revert.
3769         * dwarf2loc.c: Revert.
3770         * dwarf2expr.h: Revert.
3771         * dwarf2expr.c: Revert.
3772         * dwarf2-frame.c: Revert.
3773         * dwarf2-frame-tailcall.c: Revert.
3774         * dwarf-index-write.h: Revert.
3775         * dwarf-index-write.c: Revert.
3776         * dwarf-index-common.c: Revert.
3777         * dwarf-index-cache.h: Revert.
3778         * dwarf-index-cache.c: Revert.
3779         * dummy-frame.c: Revert.
3780         * dtrace-probe.c: Revert.
3781         * disasm.h: Revert.
3782         * disasm.c: Revert.
3783         * disasm-selftests.c: Revert.
3784         * dictionary.c: Revert.
3785         * dicos-tdep.c: Revert.
3786         * demangle.c: Revert.
3787         * dcache.h: Revert.
3788         * dcache.c: Revert.
3789         * darwin-nat.h: Revert.
3790         * darwin-nat.c: Revert.
3791         * darwin-nat-info.c: Revert.
3792         * d-valprint.c: Revert.
3793         * d-namespace.c: Revert.
3794         * d-lang.c: Revert.
3795         * ctf.c: Revert.
3796         * csky-tdep.c: Revert.
3797         * csky-linux-tdep.c: Revert.
3798         * cris-tdep.c: Revert.
3799         * cris-linux-tdep.c: Revert.
3800         * cp-valprint.c: Revert.
3801         * cp-support.c: Revert.
3802         * cp-namespace.c: Revert.
3803         * cp-abi.c: Revert.
3804         * corelow.c: Revert.
3805         * corefile.c: Revert.
3806         * continuations.c: Revert.
3807         * completer.h: Revert.
3808         * completer.c: Revert.
3809         * complaints.c: Revert.
3810         * coffread.c: Revert.
3811         * coff-pe-read.c: Revert.
3812         * cli-out.h: Revert.
3813         * cli-out.c: Revert.
3814         * charset.c: Revert.
3815         * c-varobj.c: Revert.
3816         * c-valprint.c: Revert.
3817         * c-typeprint.c: Revert.
3818         * c-lang.c: Revert.
3819         * buildsym.c: Revert.
3820         * buildsym-legacy.c: Revert.
3821         * build-id.h: Revert.
3822         * build-id.c: Revert.
3823         * btrace.c: Revert.
3824         * bsd-uthread.c: Revert.
3825         * breakpoint.h: Revert.
3826         * breakpoint.c: Revert.
3827         * break-catch-throw.c: Revert.
3828         * break-catch-syscall.c: Revert.
3829         * break-catch-sig.c: Revert.
3830         * blockframe.c: Revert.
3831         * block.c: Revert.
3832         * bfin-tdep.c: Revert.
3833         * bfin-linux-tdep.c: Revert.
3834         * bfd-target.c: Revert.
3835         * bcache.c: Revert.
3836         * ax-general.c: Revert.
3837         * ax-gdb.h: Revert.
3838         * ax-gdb.c: Revert.
3839         * avr-tdep.c: Revert.
3840         * auxv.c: Revert.
3841         * auto-load.c: Revert.
3842         * arm-wince-tdep.c: Revert.
3843         * arm-tdep.c: Revert.
3844         * arm-symbian-tdep.c: Revert.
3845         * arm-pikeos-tdep.c: Revert.
3846         * arm-obsd-tdep.c: Revert.
3847         * arm-nbsd-tdep.c: Revert.
3848         * arm-nbsd-nat.c: Revert.
3849         * arm-linux-tdep.c: Revert.
3850         * arm-linux-nat.c: Revert.
3851         * arm-fbsd-tdep.c: Revert.
3852         * arm-fbsd-nat.c: Revert.
3853         * arm-bsd-tdep.c: Revert.
3854         * arch-utils.c: Revert.
3855         * arc-tdep.c: Revert.
3856         * arc-newlib-tdep.c: Revert.
3857         * annotate.h: Revert.
3858         * annotate.c: Revert.
3859         * amd64-windows-tdep.c: Revert.
3860         * amd64-windows-nat.c: Revert.
3861         * amd64-tdep.c: Revert.
3862         * amd64-sol2-tdep.c: Revert.
3863         * amd64-obsd-tdep.c: Revert.
3864         * amd64-obsd-nat.c: Revert.
3865         * amd64-nbsd-tdep.c: Revert.
3866         * amd64-nbsd-nat.c: Revert.
3867         * amd64-nat.c: Revert.
3868         * amd64-linux-tdep.c: Revert.
3869         * amd64-linux-nat.c: Revert.
3870         * amd64-fbsd-tdep.c: Revert.
3871         * amd64-fbsd-nat.c: Revert.
3872         * amd64-dicos-tdep.c: Revert.
3873         * amd64-darwin-tdep.c: Revert.
3874         * amd64-bsd-nat.c: Revert.
3875         * alpha-tdep.c: Revert.
3876         * alpha-obsd-tdep.c: Revert.
3877         * alpha-nbsd-tdep.c: Revert.
3878         * alpha-mdebug-tdep.c: Revert.
3879         * alpha-linux-tdep.c: Revert.
3880         * alpha-linux-nat.c: Revert.
3881         * alpha-bsd-tdep.c: Revert.
3882         * alpha-bsd-nat.c: Revert.
3883         * aix-thread.c: Revert.
3884         * agent.c: Revert.
3885         * addrmap.c: Revert.
3886         * ada-varobj.c: Revert.
3887         * ada-valprint.c: Revert.
3888         * ada-typeprint.c: Revert.
3889         * ada-tasks.c: Revert.
3890         * ada-lang.c: Revert.
3891         * aarch64-tdep.c: Revert.
3892         * aarch64-ravenscar-thread.c: Revert.
3893         * aarch64-newlib-tdep.c: Revert.
3894         * aarch64-linux-tdep.c: Revert.
3895         * aarch64-linux-nat.c: Revert.
3896         * aarch64-fbsd-tdep.c: Revert.
3897         * aarch64-fbsd-nat.c: Revert.
3898         * aarch32-linux-nat.c: Revert.
3899
3900 2019-04-05  Tom Tromey  <tom@tromey.com>
3901
3902         * ft32-tdep.c: Sort headers.
3903         * frv-tdep.c: Sort headers.
3904         * frv-linux-tdep.c: Sort headers.
3905         * frame.c: Sort headers.
3906         * frame-unwind.c: Sort headers.
3907         * frame-base.c: Sort headers.
3908         * fork-child.c: Sort headers.
3909         * findvar.c: Sort headers.
3910         * findcmd.c: Sort headers.
3911         * filesystem.c: Sort headers.
3912         * filename-seen-cache.h: Sort headers.
3913         * filename-seen-cache.c: Sort headers.
3914         * fbsd-tdep.c: Sort headers.
3915         * fbsd-nat.h: Sort headers.
3916         * fbsd-nat.c: Sort headers.
3917         * f-valprint.c: Sort headers.
3918         * f-typeprint.c: Sort headers.
3919         * f-lang.c: Sort headers.
3920         * extension.h: Sort headers.
3921         * extension.c: Sort headers.
3922         * extension-priv.h: Sort headers.
3923         * expprint.c: Sort headers.
3924         * exec.h: Sort headers.
3925         * exec.c: Sort headers.
3926         * exceptions.c: Sort headers.
3927         * event-top.c: Sort headers.
3928         * event-loop.c: Sort headers.
3929         * eval.c: Sort headers.
3930         * elfread.c: Sort headers.
3931         * dwarf2read.h: Sort headers.
3932         * dwarf2read.c: Sort headers.
3933         * dwarf2loc.c: Sort headers.
3934         * dwarf2expr.h: Sort headers.
3935         * dwarf2expr.c: Sort headers.
3936         * dwarf2-frame.c: Sort headers.
3937         * dwarf2-frame-tailcall.c: Sort headers.
3938         * dwarf-index-write.h: Sort headers.
3939         * dwarf-index-write.c: Sort headers.
3940         * dwarf-index-common.c: Sort headers.
3941         * dwarf-index-cache.h: Sort headers.
3942         * dwarf-index-cache.c: Sort headers.
3943         * dummy-frame.c: Sort headers.
3944         * dtrace-probe.c: Sort headers.
3945         * disasm.h: Sort headers.
3946         * disasm.c: Sort headers.
3947         * disasm-selftests.c: Sort headers.
3948         * dictionary.c: Sort headers.
3949         * dicos-tdep.c: Sort headers.
3950         * demangle.c: Sort headers.
3951         * dcache.h: Sort headers.
3952         * dcache.c: Sort headers.
3953         * darwin-nat.h: Sort headers.
3954         * darwin-nat.c: Sort headers.
3955         * darwin-nat-info.c: Sort headers.
3956         * d-valprint.c: Sort headers.
3957         * d-namespace.c: Sort headers.
3958         * d-lang.c: Sort headers.
3959         * ctf.c: Sort headers.
3960         * csky-tdep.c: Sort headers.
3961         * csky-linux-tdep.c: Sort headers.
3962         * cris-tdep.c: Sort headers.
3963         * cris-linux-tdep.c: Sort headers.
3964         * cp-valprint.c: Sort headers.
3965         * cp-support.c: Sort headers.
3966         * cp-namespace.c: Sort headers.
3967         * cp-abi.c: Sort headers.
3968         * corelow.c: Sort headers.
3969         * corefile.c: Sort headers.
3970         * continuations.c: Sort headers.
3971         * completer.h: Sort headers.
3972         * completer.c: Sort headers.
3973         * complaints.c: Sort headers.
3974         * coffread.c: Sort headers.
3975         * coff-pe-read.c: Sort headers.
3976         * cli-out.h: Sort headers.
3977         * cli-out.c: Sort headers.
3978         * charset.c: Sort headers.
3979         * c-varobj.c: Sort headers.
3980         * c-valprint.c: Sort headers.
3981         * c-typeprint.c: Sort headers.
3982         * c-lang.c: Sort headers.
3983         * buildsym.c: Sort headers.
3984         * buildsym-legacy.c: Sort headers.
3985         * build-id.h: Sort headers.
3986         * build-id.c: Sort headers.
3987         * btrace.c: Sort headers.
3988         * bsd-uthread.c: Sort headers.
3989         * breakpoint.h: Sort headers.
3990         * breakpoint.c: Sort headers.
3991         * break-catch-throw.c: Sort headers.
3992         * break-catch-syscall.c: Sort headers.
3993         * break-catch-sig.c: Sort headers.
3994         * blockframe.c: Sort headers.
3995         * block.c: Sort headers.
3996         * bfin-tdep.c: Sort headers.
3997         * bfin-linux-tdep.c: Sort headers.
3998         * bfd-target.c: Sort headers.
3999         * bcache.c: Sort headers.
4000         * ax-general.c: Sort headers.
4001         * ax-gdb.h: Sort headers.
4002         * ax-gdb.c: Sort headers.
4003         * avr-tdep.c: Sort headers.
4004         * auxv.c: Sort headers.
4005         * auto-load.c: Sort headers.
4006         * arm-wince-tdep.c: Sort headers.
4007         * arm-tdep.c: Sort headers.
4008         * arm-symbian-tdep.c: Sort headers.
4009         * arm-pikeos-tdep.c: Sort headers.
4010         * arm-obsd-tdep.c: Sort headers.
4011         * arm-nbsd-tdep.c: Sort headers.
4012         * arm-nbsd-nat.c: Sort headers.
4013         * arm-linux-tdep.c: Sort headers.
4014         * arm-linux-nat.c: Sort headers.
4015         * arm-fbsd-tdep.c: Sort headers.
4016         * arm-fbsd-nat.c: Sort headers.
4017         * arm-bsd-tdep.c: Sort headers.
4018         * arch-utils.c: Sort headers.
4019         * arc-tdep.c: Sort headers.
4020         * arc-newlib-tdep.c: Sort headers.
4021         * annotate.h: Sort headers.
4022         * annotate.c: Sort headers.
4023         * amd64-windows-tdep.c: Sort headers.
4024         * amd64-windows-nat.c: Sort headers.
4025         * amd64-tdep.c: Sort headers.
4026         * amd64-sol2-tdep.c: Sort headers.
4027         * amd64-obsd-tdep.c: Sort headers.
4028         * amd64-obsd-nat.c: Sort headers.
4029         * amd64-nbsd-tdep.c: Sort headers.
4030         * amd64-nbsd-nat.c: Sort headers.
4031         * amd64-nat.c: Sort headers.
4032         * amd64-linux-tdep.c: Sort headers.
4033         * amd64-linux-nat.c: Sort headers.
4034         * amd64-fbsd-tdep.c: Sort headers.
4035         * amd64-fbsd-nat.c: Sort headers.
4036         * amd64-dicos-tdep.c: Sort headers.
4037         * amd64-darwin-tdep.c: Sort headers.
4038         * amd64-bsd-nat.c: Sort headers.
4039         * alpha-tdep.c: Sort headers.
4040         * alpha-obsd-tdep.c: Sort headers.
4041         * alpha-nbsd-tdep.c: Sort headers.
4042         * alpha-mdebug-tdep.c: Sort headers.
4043         * alpha-linux-tdep.c: Sort headers.
4044         * alpha-linux-nat.c: Sort headers.
4045         * alpha-bsd-tdep.c: Sort headers.
4046         * alpha-bsd-nat.c: Sort headers.
4047         * aix-thread.c: Sort headers.
4048         * agent.c: Sort headers.
4049         * addrmap.c: Sort headers.
4050         * ada-varobj.c: Sort headers.
4051         * ada-valprint.c: Sort headers.
4052         * ada-typeprint.c: Sort headers.
4053         * ada-tasks.c: Sort headers.
4054         * ada-lang.c: Sort headers.
4055         * aarch64-tdep.c: Sort headers.
4056         * aarch64-ravenscar-thread.c: Sort headers.
4057         * aarch64-newlib-tdep.c: Sort headers.
4058         * aarch64-linux-tdep.c: Sort headers.
4059         * aarch64-linux-nat.c: Sort headers.
4060         * aarch64-fbsd-tdep.c: Sort headers.
4061         * aarch64-fbsd-nat.c: Sort headers.
4062         * aarch32-linux-nat.c: Sort headers.
4063
4064 2019-04-04  Tom Tromey  <tom@tromey.com>
4065
4066         * varobj.c (varobj_create): Update.
4067         * rust-exp.y (struct rust_parser) <update_innermost_block,
4068         lookup_symbol>: New methods.
4069         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4070         Rename.
4071         (rust_parser::rust_lookup_type)
4072         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4073         * printcmd.c (display_command, do_one_display): Update.
4074         * parser-defs.h (struct parser_state) <parser_state>: Add
4075         "tracker" parameter.
4076         (block_tracker): New member.
4077         (class innermost_block_tracker) <innermost_block_tracker>: Add
4078         "types" parameter.
4079         <reset>: Remove method.
4080         (innermost_block): Don't declare.
4081         (null_post_parser): Update.
4082         * parse.c (innermost_block): Remove global.
4083         (write_dollar_variable): Update.
4084         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4085         Remove "tracker_types" parameter.
4086         (parse_expression): Add "tracker" parameter.
4087         (parse_expression_for_completion): Update.
4088         (null_post_parser): Add "tracker" parameter.
4089         * p-exp.y: Update rules.
4090         * m2-exp.y: Update rules.
4091         * language.h (struct language_defn) <la_post_parser>: Add
4092         "tracker" parameter.
4093         * go-exp.y: Update rules.
4094         * f-exp.y: Update rules.
4095         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4096         parameter.
4097         * d-exp.y: Update rules.
4098         * c-exp.y: Update rules.
4099         * breakpoint.c (set_breakpoint_condition): Create an
4100         innermost_block_tracker.
4101         (watch_command_1): Likewise.
4102         * ada-lang.c (resolve): Add "tracker" parameter.
4103         (resolve_subexp): Likewise.
4104         * ada-exp.y (write_var_from_sym): Update.
4105
4106 2019-04-04  Tom Tromey  <tom@tromey.com>
4107
4108         * type-stack.h: New file.
4109         * type-stack.c: New file.
4110         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4111         type-stack.h.
4112         (insert_into_type_stack, insert_type, push_type, push_type_int)
4113         (insert_type_address_space, pop_type, pop_type_int)
4114         (pop_typelist, pop_type_stack, append_type_stack)
4115         (push_type_stack, get_type_stack, push_typelist)
4116         (follow_type_instance_flags, follow_types): Don't declare.
4117         * parse.c (type_stack): Remove global.
4118         (parse_exp_in_context): Update.
4119         (insert_into_type_stack, insert_type, push_type, push_type_int)
4120         (insert_type_address_space, pop_type, pop_type_int)
4121         (pop_typelist, pop_type_stack, append_type_stack)
4122         (push_type_stack, get_type_stack, push_typelist)
4123         (follow_type_instance_flags, follow_types): Remove (moved to
4124         type-stack.c).
4125         * f-exp.y (type_stack): New global.
4126         Update rules.
4127         (push_kind_type, f_parse): Update.
4128         * d-exp.y (type_stack): New global.
4129         Update rules.
4130         (d_parse): Update.
4131         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4132         Update rules.
4133         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4134         (HFILES_NO_SRCDIR): Add type-stack.h.
4135
4136 2019-04-04  Tom Tromey  <tom@tromey.com>
4137
4138         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4139         (rust_parser::convert_ast_to_expression, rust_parse)
4140         (rust_lex_test_completion, rust_lex_tests): Update.
4141         * parser-defs.h (struct expr_completion_state): New.
4142         (struct parser_state) <parser_state>: Add completion parameter.
4143         <mark_struct_expression, mark_completion_tag>: New methods.
4144         <parse_completion, m_completion_state>: New members.
4145         (prefixify_expression, null_post_parser): Update.
4146         (mark_struct_expression, mark_completion_tag): Don't declare.
4147         * parse.c (parse_completion, expout_last_struct)
4148         (expout_tag_completion_type, expout_completion_name): Remove
4149         globals.
4150         (parser_state::mark_struct_expression)
4151         (parser_state::mark_completion_tag): Now methods.
4152         (prefixify_expression): Add last_struct parameter.
4153         (prefixify_subexp): Likewise.
4154         (parse_exp_1): Update.
4155         (parse_exp_in_context): Add cstate parameter.  Update.
4156         (parse_expression_for_completion): Create an
4157         expr_completion_state.
4158         (null_post_parser): Add "completion" parameter.
4159         * p-exp.y: Update rules.
4160         (yylex): Update.
4161         * language.h (struct language_defn) <la_post_parser>: Add
4162         "completing" parameter.
4163         * go-exp.y: Update rules.
4164         (lex_one_token): Update.
4165         * expression.h (parse_completion): Don't declare.
4166         * d-exp.y: Update rules.
4167         (lex_one_token): Update rules.
4168         * c-exp.y: Update rules.
4169         (lex_one_token): Update.
4170         * ada-lang.c (resolve): Add "parse_completion" parameter.
4171         (resolve_subexp): Likewise.
4172         (ada_resolve_function): Likewise.
4173
4174 2019-04-04  Tom Tromey  <tom@tromey.com>
4175
4176         * parser-defs.h (struct parser_state) <start_arglist,
4177         end_arglist>: New methods.
4178         <arglist_len, m_funcall_chain>: New members.
4179         (arglist_len, start_arglist, end_arglist): Don't declare.
4180         * parse.c (arglist_len, funcall_chain): Remove global.
4181         (start_arglist, end_arglist): Remove functions.
4182         (parse_exp_in_context): Update.
4183         * p-exp.y: Update rules.
4184         * m2-exp.y: Update rules.
4185         * go-exp.y: Update rules.
4186         * f-exp.y: Update rules.
4187         * d-exp.y: Update rules.
4188         * c-exp.y: Update rules.
4189
4190 2019-04-04  Tom Tromey  <tom@tromey.com>
4191
4192         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4193         lex_operator, push_back>: New methods.
4194         Update all rules.
4195         (rust_parser::lex_hex, lex_escape): Rename and update.
4196         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4197         (rust_parser::lex_operator): Rename and update.
4198         (rust_parser::lex_number, rustyylex, rustyyerror)
4199         (rust_lex_test_init, rust_lex_test_sequence)
4200         (rust_lex_test_push_back, rust_lex_tests): Update.
4201         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4202         parameter.
4203         <lexptr, prev_lexptr>: New members.
4204         (lexptr, prev_lexptr): Don't declare.
4205         * parse.c (lexptr, prev_lexptr): Remove globals.
4206         (parse_exp_in_context): Update.
4207         * p-exp.y (yylex, yyerror): Update.
4208         * m2-exp.y (parse_number, yylex, yyerror): Update.
4209         * go-exp.y (lex_one_token, yyerror): Update.
4210         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4211         * d-exp.y (lex_one_token, yyerror): Update.
4212         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4213         (lex_one_token, yyerror): Update.
4214         * ada-lex.l (YY_INPUT): Update.
4215         (rewind_to_char): Update.
4216         * ada-exp.y (yyerror): Update.
4217
4218 2019-04-04  Tom Tromey  <tom@tromey.com>
4219
4220         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4221         * parser-defs.h (struct parser_state) <parser_state>: Add new
4222         parameter.
4223         <comma_terminates>: New member.
4224         (comma_terminates): Don't declare global.
4225         * parse.c (comma_terminates): Remove global.
4226         (parse_exp_in_context): Update.
4227         * p-exp.y (yylex): Update.
4228         * m2-exp.y (yylex): Update.
4229         * go-exp.y (lex_one_token): Update.
4230         * f-exp.y (yylex): Update.
4231         * d-exp.y (lex_one_token): Update.
4232         * c-exp.y (lex_one_token): Update.
4233         * ada-lex.l: Update.
4234
4235 2019-04-04  Tom Tromey  <tom@tromey.com>
4236
4237         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4238         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4239         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4240         * parser-defs.h (paren_depth): Don't declare.
4241         * parse.c (paren_depth): Remove global.
4242         (parse_exp_in_context): Update.
4243         * p-exp.y (paren_depth): New global.
4244         (pascal_parse): Initialize it.
4245         * m2-exp.y (paren_depth): New global.
4246         (m2_parse): Initialize it.
4247         * go-exp.y (paren_depth): New global.
4248         (go_parse): Initialize it.
4249         * f-exp.y (paren_depth): New global.
4250         (f_parse): Initialize it.
4251         * d-exp.y (paren_depth): New global.
4252         (d_parse): Initialize it.
4253         * c-exp.y (paren_depth): New global.
4254         (c_parse): Initialize it.
4255         * ada-lex.l (paren_depth): New global.
4256         (lexer_init): Initialize it.
4257
4258 2019-04-04  Tom Tromey  <tom@tromey.com>
4259
4260         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4261         (rust_parser::convert_ast_to_type)
4262         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4263         * parser-defs.h (struct parser_state) <parser_state>: Add
4264         parameters.  Initialize new members.
4265         <expression_context_block, expression_context_pc>: New members.
4266         * parse.c (expression_context_block, expression_context_pc):
4267         Remove globals.
4268         (parse_exp_in_context): Update.
4269         * p-exp.y: Update all rules.
4270         (yylex): Update.
4271         * m2-exp.y: Update all rules.
4272         (yylex): Update.
4273         * go-exp.y (yylex): Update.
4274         * f-exp.y (yylex): Update.
4275         * d-exp.y: Update all rules.
4276         (yylex): Update.
4277         * c-exp.y: Update all rules.
4278         (lex_one_token, classify_name, yylex, c_parse): Update.
4279         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4280
4281 2019-04-04  Tom Tromey  <tom@tromey.com>
4282
4283         * gdbarch.h, gdbarch.c: Rebuild.
4284         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4285         * stap-probe.h:
4286         (struct stap_parse_info): Replace "parser_state" with
4287         "expr_builder".
4288         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4289         (parser_state): New class.
4290         * parse.c (expr_builder): Rename.
4291         (expr_builder::release): Rename.
4292         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4293         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4294         (write_exp_elt_longcst, write_exp_elt_floatcst)
4295         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4296         (write_exp_string_vector, write_exp_bitstring)
4297         (write_exp_msymbol, mark_struct_expression)
4298         (write_dollar_variable)
4299         (insert_type_address_space, increase_expout_size): Replace
4300         "parser_state" with "expr_builder".
4301         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4302         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4303         "parser_state" with "expr_builder".
4304
4305 2019-04-04  Tom Tromey  <tom@tromey.com>
4306
4307         * rust-exp.y: Replace "parse_language" with method call.
4308         * p-exp.y:
4309         (yylex): Replace "parse_language" with method call.
4310         * m2-exp.y:
4311         (yylex): Replace "parse_language" with method call.
4312         * go-exp.y (classify_name): Replace "parse_language" with method
4313         call.
4314         * f-exp.y (yylex): Replace "parse_language" with method call.
4315         * d-exp.y (lex_one_token): Replace "parse_language" with method
4316         call.
4317         * c-exp.y:
4318         (lex_one_token, classify_name, yylex): Replace "parse_language"
4319         with method call.
4320         * ada-exp.y (find_primitive_type, type_char)
4321         (type_system_address): Replace "parse_language" with method call.
4322
4323 2019-04-04  Tom Tromey  <tom@tromey.com>
4324
4325         * rust-exp.y: Replace "parse_gdbarch" with method call.
4326         * parse.c (write_dollar_variable, insert_type_address_space):
4327         Replace "parse_gdbarch" with method call.
4328         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4329         call.
4330         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4331         call.
4332         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4333         "parse_gdbarch" with method call.
4334         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4335         with method call.
4336         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4337         "parse_gdbarch" with method call.
4338         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4339         "parse_gdbarch" with method call.
4340         * c-exp.y (parse_type, parse_number, classify_name): Replace
4341         "parse_gdbarch" with method call.
4342         * ada-lex.l: Replace "parse_gdbarch" with method call.
4343         * ada-exp.y (parse_type, find_primitive_type, type_char)
4344         (type_system_address): Replace "parse_gdbarch" with method call.
4345
4346 2019-04-04  Tom Tromey  <tom@tromey.com>
4347
4348         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4349         * stap-probe.c (stap_parse_argument): Update.
4350         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4351         initial_size parameter.
4352         * rust-exp.y (rust_lex_tests): Update.
4353         * parse.c (parser_state): Update.
4354         (parse_exp_in_context): Update.
4355         * parser-defs.h (struct parser_state) <parser_state>: Remove
4356         "initial_size" parameter.
4357
4358 2019-04-04  Tom Tromey  <tom@tromey.com>
4359
4360         * parser-defs.h (increase_expout_size): Don't declare.
4361         * parse.c (increase_expout_size): Now static.
4362
4363 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4364
4365         * gnu-nat.c (gnu_nat_target::wait): Fix
4366         target_waitstatus_to_string call.
4367
4368 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4369
4370         * eval.c (evaluate_subexp_standard): Handle internal functions
4371         during Fortran function call handling.
4372
4373 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4374
4375         * NEWS: Mention new internal functions.
4376         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4377         (read_base_type): Use dwarf2_init_complex_target_type.
4378         * value.c (creal_internal_fn): New function.
4379         (cimag_internal_fn): New function.
4380         (_initialize_values): Register new internal functions.
4381
4382 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4383
4384         * infrun.c (stop_all_threads): If debug_infrun, always
4385         trace the wait status after wait_one, using
4386         target_waitstatus_to_string and target_pid_to_str.
4387         (handle_inferior_event): Replace various trace of
4388         wait status kind by a single trace.
4389         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4390         wait status kind image by target_waitstatus_to_string.
4391         * target/waitstatus.c (target_waitstatus_to_string): Fix
4392         obsolete comment.
4393
4394 2019-04-01  Tom Tromey  <tromey@adacore.com>
4395
4396         PR symtab/23331:
4397         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4398
4399 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4400             Pedro Alves  <palves@redhat.com>
4401
4402         * top.c (quit_force): Call 'finalize_values'.
4403         * value.c (finalize_values): New function.
4404         * value.h (finalize_values): Declare.
4405
4406 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4407
4408         * NEWS: Announce $_gdb_major and $_gdb_minor.
4409
4410         * top.c (init_gdb_version_vars): New function.
4411         (gdb_init): Call init_gdb_version_vars.
4412
4413 2019-03-29  Tom Tromey  <tromey@adacore.com>
4414
4415         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4416         help text.  Remove dead code.
4417
4418 2019-03-29  Keith Seitz  <keiths@redhat.com>
4419
4420         From Siddhesh Poyarekar:
4421         * f-lang.h (f77_get_upperbound): Return LONGEST.
4422         (f77_get_lowerbound): Likewise.
4423         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4424         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4425         print them.
4426         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4427         plongest to format print it.
4428         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4429         (f77_get_upperbound): Likewise.
4430         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4431         LOWER_BOUND to LONGEST.
4432         (f77_create_arrayprint_offset_tbl): Likewise.
4433
4434 2019-03-29  Keith Seitz  <keiths@redhat.com>
4435
4436         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4437         %s/pulongest for TYPE_LENGTH instead of %d in format
4438         strings.
4439         * ada-typerint.c (ada_print_type): Likewise.
4440         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4441         * compile/compile-c-support.c (generate_register_struct): Likewise.
4442         * gdbtypes.c (recursive_dump_type): Likewise.
4443         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4444         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4445         instead of %d in format strings.
4446         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4447         to std::min to ULONGEST.
4448         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4449         instead of %d in format strings.
4450         * tracepoint.c (info_scope_command): Likewise.
4451         * typeprint.c (print_offset_data::update)
4452         (print_offset_data::finish): Likewise.
4453         * xtensa-tdep.c (xtensa_store_return_value)
4454         (xtensa_push_dummy_call): Likewise.
4455
4456 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4457
4458         * windows-nat.c (display_selector): Fixed format specifications
4459         for 64-bit Cygwin.
4460
4461 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4462
4463         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4464
4465 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4466
4467         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4468         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4469         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4470         (nios2_linux_init_abi): Install it.
4471
4472 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4473
4474         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4475
4476 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4477
4478         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4479
4480 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4481             Tom Tromey  <tromey@adacore.com>
4482
4483         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4484
4485 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4486
4487         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4488         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4489         method to compute the bounds of range types. Also print "[evaluated]"
4490         if the bounds' values come from a dynamic evaluation.
4491
4492 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4493
4494         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4495         whitespace when pretty printing is on.
4496
4497 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4498
4499         * ppc-linux-nat.c: Add include.
4500
4501 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4502
4503         * NEWS: Mention AArch64 Pointer Authentication.
4504
4505 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4506
4507         * arm-linux-nat.c: Add include.
4508
4509 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4510
4511         * source-cache.c (source_cache::get_source_lines): Re-read
4512         fullname after calling open_source_file.
4513
4514 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4515
4516         * NEWS: Mention TLS support for FreeBSD.
4517
4518 2019-03-25  Tom Tromey  <tromey@adacore.com>
4519
4520         * minsyms.c (BUNCH_SIZE): Update comment.
4521         (~minimal_symbol_reader): Remove old comment.
4522         (compact_minimal_symbols): Update comment.
4523         (minimal_symbol_reader::install): Remove old comment.  Update
4524         other comments.
4525
4526 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4527
4528         * s390-linux-nat.c: Add include.
4529
4530 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4531
4532         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4533         Call linux_get_hwcap.
4534         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4535         Likewise.
4536         (aarch64_linux_get_hwcap): Remove function.
4537         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4538         declaration.
4539         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4540         linux_get_hwcap.
4541         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4542         * linux-tdep.c (linux_get_hwcap): Add function.
4543         (linux_get_hwcap2): Likewise.
4544         * linux-tdep.h (linux_get_hwcap): Add declaration.
4545         (linux_get_hwcap2): Likewise.
4546         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4547         (ppc_linux_get_hwcap2): Likewise.
4548         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4549         linux_get_hwcap.
4550         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4551         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4552         (ppc_linux_nat_target::read_description): Likewise.
4553         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4554         * s390-linux-nat.c: Likewise.
4555         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4556
4557 2019-03-24  Tom Tromey  <tom@tromey.com>
4558
4559         * ada-lang.c (standard_lookup): Simplify initialization.
4560         (ada_lookup_symbol_nonlocal): Simplify return.
4561         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4562         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4563         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4564         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4565         initialization.
4566         * solib.c (solib_global_lookup): Simplify.
4567         * symtab.c (null_block_symbol): Remove.
4568         (symbol_cache_lookup): Simplify returns.
4569         (lookup_language_this): Simplify returns.
4570         (lookup_symbol_aux): Simplify return.
4571         (lookup_local_symbol): Simplify returns.
4572         (lookup_global_symbol_from_objfile): Simplify return.
4573         (lookup_symbol_in_objfile_symtabs)
4574         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4575         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4576         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4577         * cp-namespace.c (cp_lookup_bare_symbol)
4578         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4579         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4580         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4581         (cp_lookup_symbol_via_imports): Simplify initialization.
4582         (find_symbol_in_baseclass): Likewise.
4583         * symtab.h (null_block_symbol): Remove.
4584         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4585         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4586         (d_lookup_symbol_module): Likewise.
4587         (find_symbol_in_baseclass): Simplify initialization.
4588
4589 2019-03-24  Tom Tromey  <tom@tromey.com>
4590
4591         * expression.h: Don't include symtab.h.
4592         (struct block): Forward declare.
4593
4594 2019-03-24  Tom Tromey  <tom@tromey.com>
4595
4596         * c-exp.y (typebase): Remove casts.
4597         * gdbtypes.c (lookup_unsigned_typename, )
4598         (lookup_signed_typename): Remove cast.
4599         * eval.c (parse_to_comma_and_eval): Remove cast.
4600         * parse.c (write_dollar_variable): Remove cast.
4601         * block.h (struct block) <superblock>: Now const.
4602         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4603         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4604         (map_block): Make "block" const.
4605         * symfile.h (struct quick_symbol_functions)
4606         <map_matching_symbols>: Constify block argument to "callback".
4607         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4608         const.
4609         (find_pc_sect_compunit_symtab): Make "b" const.
4610         (find_symbol_at_address): Likewise.
4611         (search_symbols): Likewise.
4612         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4613         (dw2_debug_names_lookup_symbol): Likewise.
4614         (dw2_map_matching_symbols): Update.
4615         * p-valprint.c (pascal_val_print): Remove "block".
4616         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4617         (aux_add_nonlocal_symbols): Make "block" const.
4618         (resolve_subexp): Remove cast.
4619         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4620         const.
4621         (iterate_over_file_blocks): Likewise.
4622         * f-exp.y (%union) <bval>: Remove.
4623         * coffread.c (patch_opaque_types): Make "b" const.
4624         * spu-tdep.c (spu_catch_start): Make "block" const.
4625         * c-valprint.c (print_unpacked_pointer): Remove "block".
4626         * symmisc.c (dump_symtab_1): Make "b" const.
4627         (block_depth): Make "block" const.
4628         * d-exp.y (%union) <bval>: Remove.
4629         * cp-support.h (cp_lookup_rtti_type): Update.
4630         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4631         * psymtab.c (psym_lookup_symbol): Make "block" const.
4632         (maintenance_check_psymtabs): Make "b" const.
4633         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4634         (enumerate_locals, enumerate_args): Update.
4635         * python/py-symtab.c (stpy_global_block): Make "block" const.
4636         (stpy_static_block): Likewise.
4637         * inline-frame.c (block_starting_point_at): Make "new_block"
4638         const.
4639         * block.c (find_block_in_blockvector): Make return type const.
4640         (blockvector_for_pc_sect): Make "b" const.
4641         (find_block_in_blockvector): Make "b" const.
4642
4643 2019-03-23  Tom Tromey  <tom@tromey.com>
4644
4645         * varobj.c (varobj_create): Update.
4646         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4647         * printcmd.c (display_command, do_one_display): Don't reset
4648         innermost_block.
4649         * parser-defs.h (enum innermost_block_tracker_type): Move to
4650         expression.h.
4651         (innermost_block): Update comment.
4652         * parse.c (parse_exp_1): Add tracker_types parameter.
4653         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4654         tracker_types parameter.  Reset innermost_block.
4655         (parse_exp_in_context): Remove.
4656         (parse_expression_for_completion): Update.
4657         * objfiles.c (~objfile): Don't reset expression_context_block or
4658         innermost_block.
4659         * expression.h (enum innermost_block_tracker_type): Move from
4660         parser-defs.h.
4661         (parse_exp_1): Add tracker_types parameter.
4662         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4663         reset innermost_block.
4664
4665 2019-03-23  Tom Tromey  <tom@tromey.com>
4666
4667         * objfiles.h: Include bcache.h.
4668
4669 2019-03-23  Tom Tromey  <tom@tromey.com>
4670
4671         * linespec.c (get_current_search_block): Use
4672         scoped_restore_current_language.
4673         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4674
4675 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4676             Jiong Wang  <jiong.wang@arm.com>
4677
4678         * aarch64-linux-tdep.c
4679         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4680         section.
4681         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4682
4683 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4684             Jiong Wang  <jiong.wang@arm.com>
4685
4686         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4687         instructions.
4688         (aarch64_analyze_prologue_test): Add PACIASP test.
4689         (aarch64_prologue_prev_register): Unmask PC value.
4690
4691 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4692             Jiong Wang  <jiong.wang@arm.com>
4693
4694         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4695         (aarch64_dwarf2_prev_register): Unmask PC value.
4696         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4697         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4698         DW_CFA_AARCH64_negate_ra_state.
4699         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4700
4701 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4702             Jiong Wang  <jiong.wang@arm.com>
4703
4704         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4705         registers.
4706         (aarch64_pseudo_register_name): Likewise.
4707         (aarch64_pseudo_register_type): Likewise.
4708         (aarch64_pseudo_register_reggroup_p): Likewise.
4709         (aarch64_gdbarch_init): Add pauth registers.
4710         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4711         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4712         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4713         (struct gdbarch_tdep): Add regnum for ra_state.
4714
4715 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4716             Jiong Wang  <jiong.wang@arm.com>
4717
4718         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4719
4720 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4721             Jiong Wang  <jiong.wang@arm.com>
4722
4723         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4724         function.
4725         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4726         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4727         (aarch64_gdbarch_init): Add puth registers.
4728         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4729         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4730         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4731
4732 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4733             Jiong Wang  <jiong.wang@arm.com>
4734
4735         * aarch64-linux-nat.c
4736         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4737         * aarch64-linux-tdep.c
4738         (aarch64_linux_core_read_description): Likewise.
4739         (aarch64_linux_get_hwcap): New function.
4740         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4741         (aarch64_linux_get_hwcap): New declaration.
4742
4743 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4744             Jiong Wang  <jiong.wang@arm.com>
4745
4746         * aarch64-linux-nat.c
4747         (aarch64_linux_nat_target::read_description): Add pauth param.
4748         * aarch64-linux-tdep.c
4749         (aarch64_linux_core_read_description): Likewise.
4750         * aarch64-tdep.c (struct target_desc): Add in pauth.
4751         (aarch64_read_description): Add pauth param.
4752         (aarch64_gdbarch_init): Likewise.
4753         * aarch64-tdep.h (aarch64_read_description): Likewise.
4754         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4755         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4756         * features/Makefile: Add new files.
4757         * features/aarch64-pauth.c: New file.
4758         * features/aarch64-pauth.xml: New file.
4759
4760 2019-03-20  Tom Tromey  <tromey@adacore.com>
4761
4762         * infrun.c (handle_inferior_event): Rename from
4763         handle_inferior_event_1.  Create a scoped_value_mark.
4764         (handle_inferior_event): Remove.
4765
4766 2019-03-19  Tom Tromey  <tromey@adacore.com>
4767
4768         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4769         * infrun.h (print_stop_event): Add "displays" parameter.
4770         * infrun.c (print_stop_event): Add "displays" parameter.
4771
4772 2019-03-19  Pedro Alves  <palves@redhat.com>
4773
4774         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4775         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4776         to -1.  Fix TABs vs spaces.
4777         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4778         * tui/tui-out.h (tui_ui_out) Add intro comments.
4779         <m_line, m_start_of_line>: In-class initialize, and add describing
4780         comment.
4781
4782 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4783
4784         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4785         variable names.
4786         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4787
4788 2019-03-18  Pedro Alves  <palves@redhat.com>
4789             Eli Zaretskii <eliz@gnu.org>
4790
4791         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4792         m_line and m_start_of_line.
4793
4794 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4795
4796         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4797         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4798         it returns a newline.  This fixes a regression in TU mode, whereby
4799         the next line is output on the same screen line as the user input.
4800
4801 2019-03-18  Tom Tromey  <tromey@adacore.com>
4802
4803         * minsyms.c (minimal_symbol_reader::install): Remove call to
4804         obstack_blank.
4805
4806 2019-03-18  Pedro Alves  <palves@redhat.com>
4807
4808         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4809         New globals.
4810         (apply_style): New, factored out from ...
4811         (apply_ansi_escape): ... this.  Handle reverse video mode.
4812         (tui_set_reverse_mode): New function.
4813         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4814         * tui/tui-winsource.c (tui_show_source_line): Use
4815         tui_set_reverse_mode instead of setting A_STANDOUT.
4816         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4817         New setter methods.
4818
4819 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4820
4821         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4822         Handle tabs.
4823
4824 2019-03-18  Tom Tromey  <tromey@adacore.com>
4825
4826         * ada-lang.c (empty_array): Add "high" parameter.
4827         (ada_evaluate_subexp): Update.
4828
4829 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4830
4831         * unittests/string_view-selftests.c: Define
4832         _initialize_string_view_selftests unconditionally.
4833
4834 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4835
4836         PR gdb/24350
4837         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4838
4839 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4840
4841         PR gdb/24351
4842         * windows-nat.c (display_selector): Fix format specifiers.
4843
4844 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4845
4846         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4847         tui_refill_source_window instead of tui_refresh_win, to update the
4848         current execution line.  This fixes redisplay of the current line
4849         when stepping through the code with "next" or "step".
4850
4851 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4852
4853         * source-cache.c (source_cache::get_source_lines): Call
4854         find_source_lines to initialize s->nlines.  This fixes vertical
4855         scrolling of TUI source window when the DOWN arrow is pressed.
4856
4857 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4858
4859         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4860         linux-thread-db.c (_initialize_thread_db): Likewise.
4861
4862 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4863
4864         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4865         wclrtoeol in tui_show_source_line".  This reverts changes made in
4866         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4867
4868 2019-03-15  Tom Tromey  <tom@tromey.com>
4869
4870         * symtab.h (struct minimal_symbol): Derive from
4871         general_symbol_info.
4872         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4873         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4874         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4875         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4876         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4877         (MSYMBOL_SEARCH_NAME): Update.
4878         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4879         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4880         * minsyms.c (minimal_symbol_reader::record_full): Update.
4881
4882 2019-03-15  Tom Tromey  <tom@tromey.com>
4883
4884         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4885
4886 2019-03-15  Tom Tromey  <tom@tromey.com>
4887
4888         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4889         unique_xmalloc_ptr.
4890         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4891         Update.
4892         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4893         (build_minimal_symbol_hash_tables)
4894         (minimal_symbol_reader::install): Update.
4895
4896 2019-03-15  Tom Tromey  <tom@tromey.com>
4897
4898         * symtab.c (create_demangled_names_hash): Update.
4899         (symbol_set_names): Update.
4900         * objfiles.h (struct objfile_per_bfd_storage)
4901         <demangled_names_hash>: Now an htab_up.
4902         * objfiles.c (objfile_per_bfd_storage): Simplify.
4903
4904 2019-03-15  Tom Tromey  <tom@tromey.com>
4905
4906         * objfiles.h (struct objfile_per_bfd_storage): Declare
4907         destructor.
4908         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4909         New.
4910         (get_objfile_bfd_data): Use new.  Don't initialize
4911         language_of_main.
4912         (free_objfile_per_bfd_storage): Remove.
4913         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4914
4915 2019-03-15  Tom Tromey  <tom@tromey.com>
4916
4917         * symfile.c (reread_symbols): Update.
4918         * objfiles.c (objfile::objfile): Update.
4919         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4920         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4921         comment.
4922         (minimal_symbol_reader::install): Update.
4923         (terminate_minimal_symbol_table): Remove.
4924         * jit.c (jit_object_close_impl): Update.
4925
4926 2019-03-15  Tom Tromey  <tom@tromey.com>
4927
4928         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4929         initializations.
4930
4931 2019-03-15  Tom Tromey  <tom@tromey.com>
4932
4933         * objfiles.h (struct objfile_per_bfd_storage)
4934         <demangled_hash_languages>: Now a bitset.
4935         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4936         (lookup_minimal_symbol): Update.
4937
4938 2019-03-15  Tom Tromey  <tom@tromey.com>
4939
4940         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4941         Don't return the symbol.
4942         * coffread.c (record_minimal_symbol): Use record_full.
4943
4944 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4945
4946         The MS-Windows port of ncurses fails to switch to a color pair if
4947         one or both of the colors are the implicit default colors.  This
4948         change records the default colors when TUI is initialized, and
4949         then specifies them explicitly when a color pair uses the default
4950         colors.  This allows color styling in TUI mode on MS-Windows.
4951
4952         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4953         ncurses_norm_attr.
4954         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4955         colors in ncurses_norm_attr.
4956         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4957         "none", replace it with the default color recorded in
4958         ncurses_norm_attr.
4959
4960 2019-03-14  Tom Tromey  <tromey@adacore.com>
4961
4962         * source-cache.h (class source_cache) <get_source_lines>: Return
4963         std::string.
4964         * source-cache.c (source_cache::extract_lines): Handle case where
4965         first_pos==npos.  Return std::string.
4966         (source_cache::get_source_lines): Update.
4967
4968 2019-03-14  Tom Tromey  <tromey@adacore.com>
4969
4970         * NEWS: Add item for "style sources" commands.
4971         * source-cache.c (source_cache::get_source_lines): Check
4972         source_styling.
4973         * cli/cli-style.c (source_styling): New global.
4974         (_initialize_cli_style): Add "style sources" commands.
4975         (show_style_sources): New function.
4976         * cli/cli-style.h (source_styling): Declare.
4977
4978 2019-03-14  Pedro Alves  <palves@redhat.com>
4979             Tom Tromey  <tromey@adacore.com>
4980
4981         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4982         * tui/tui-winsource.c (tui_refill_source_window): New function,
4983         from...
4984         (tui_horizontal_source_scroll): ... here.  Move some logic.
4985         * cli/cli-style.c (set_style_enabled): Notify new observable.
4986         * tui/tui-hooks.c (tui_redisplay_source): New function.
4987         (tui_attach_detach_observers): Attach or detach
4988         tui_redisplay_source.
4989         * observable.h (source_styling_changed): New observable.
4990         * observable.c: Define source_styling_changed observable.
4991
4992 2019-03-13  Tom Tromey  <tromey@adacore.com>
4993
4994         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4995         (i386_gnu_nat_target::store_registers): Update.
4996         * target-debug.h (target_debug_print_std_string): New macro.
4997         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4998         * windows-tdep.c (display_one_tib): Update.
4999         * tui/tui-stack.c (tui_make_status_line): Update.
5000         * top.c (print_inferior_quit_action): Update.
5001         * thread.c (thr_try_catch_cmd): Update.
5002         (add_thread_with_info): Update.
5003         (thread_target_id_str): Update.
5004         (thr_try_catch_cmd): Update.
5005         (thread_command): Update.
5006         (thread_find_command): Update.
5007         * record-btrace.c (record_btrace_target::info_record)
5008         (record_btrace_resume_thread, record_btrace_target::resume)
5009         (record_btrace_cancel_resume, record_btrace_step_thread)
5010         (record_btrace_target::wait, record_btrace_target::wait)
5011         (record_btrace_target::wait, record_btrace_target::stop): Update.
5012         * progspace.c (print_program_space): Update.
5013         * process-stratum-target.c
5014         (process_stratum_target::thread_address_space): Update.
5015         * linux-fork.c (linux_fork_mourn_inferior)
5016         (detach_checkpoint_command, info_checkpoints_command)
5017         (linux_fork_context): Update.
5018         (linux_fork_detach): Update.
5019         (class scoped_switch_fork_info): Update.
5020         (delete_checkpoint_command): Update.
5021         * infrun.c (follow_fork_inferior): Update.
5022         (follow_fork_inferior): Update.
5023         (proceed_after_vfork_done): Update.
5024         (handle_vfork_child_exec_or_exit): Update.
5025         (follow_exec): Update.
5026         (displaced_step_prepare_throw): Update.
5027         (displaced_step_restore): Update.
5028         (start_step_over): Update.
5029         (resume_1): Update.
5030         (clear_proceed_status_thread): Update.
5031         (proceed): Update.
5032         (print_target_wait_results): Update.
5033         (do_target_wait): Update.
5034         (context_switch): Update.
5035         (stop_all_threads): Update.
5036         (restart_threads): Update.
5037         (finish_step_over): Update.
5038         (handle_signal_stop): Update.
5039         (switch_back_to_stepped_thread): Update.
5040         (keep_going_pass_signal): Update.
5041         (print_exited_reason): Update.
5042         (normal_stop): Update.
5043         * inferior.c (inferior_pid_to_str): Change return type.
5044         (print_selected_inferior): Update.
5045         (add_inferior): Update.
5046         (detach_inferior): Update.
5047         * dummy-frame.c (fprint_dummy_frames): Update.
5048         * dcache.c (dcache_info_1): Update.
5049         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5050         (btrace_fetch, btrace_clear): Update.
5051         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5052         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5053         type.
5054         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5055         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5056         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5057         * gdbarch.c, gdbarch.h: Rebuild.
5058         * gdbarch.sh (core_pid_to_str): Change return type.
5059         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5060         return type.
5061         (windows_nat_target::pid_to_str): Change return type.
5062         (windows_delete_thread): Update.
5063         (windows_nat_target::attach): Update.
5064         (windows_nat_target::files_info): Update.
5065         * target-delegates.c: Rebuild.
5066         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5067         return type.
5068         (sol_thread_target::pid_to_str): Change return type.
5069         * remote.c (class remote_target) <pid_to_str>: Change return
5070         type.
5071         (remote_target::pid_to_str): Change return type.
5072         (extended_remote_target::attach, remote_target::remote_stop_ns)
5073         (remote_target::remote_notif_remove_queued_reply)
5074         (remote_target::push_stop_reply, remote_target::disable_btrace):
5075         Update.
5076         (extended_remote_target::attach): Update.
5077         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5078         type.
5079         (gdbsim_target::pid_to_str): Change return type.
5080         * ravenscar-thread.c (struct ravenscar_thread_target)
5081         <pid_to_str>: Change return type.
5082         (ravenscar_thread_target::pid_to_str): Change return type.
5083         * procfs.c (class procfs_target) <pid_to_str>: Change return
5084         type.
5085         (procfs_target::pid_to_str): Change return type.
5086         (procfs_target::attach): Update.
5087         (procfs_target::detach): Update.
5088         (procfs_target::fetch_registers): Update.
5089         (procfs_target::store_registers): Update.
5090         (procfs_target::wait): Update.
5091         (procfs_target::files_info): Update.
5092         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5093         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5094         return type.
5095         (nto_procfs_target::pid_to_str): Change return type.
5096         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5097         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5098         return type.
5099         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5100         (exit_lwp): Update.
5101         (attach_proc_task_lwp_callback, get_detach_signal)
5102         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5103         (linux_nat_target::resume, wait_lwp, stop_callback)
5104         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5105         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5106         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5107         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5108         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5109         type.
5110         (inf_ptrace_target::attach): Update.
5111         (inf_ptrace_target::files_info): Update.
5112         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5113         type.
5114         (go32_nat_target::pid_to_str): Change return type.
5115         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5116         (gnu_nat_target::wait): Update.
5117         (gnu_nat_target::wait): Update.
5118         (gnu_nat_target::resume): Update.
5119         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5120         (fbsd_nat_target::wait): Update.
5121         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5122         type.
5123         (darwin_nat_target::attach): Update.
5124         * corelow.c (class core_target) <pid_to_str>: Change return type.
5125         (core_target::pid_to_str): Change return type.
5126         * target.c (normal_pid_to_str): Change return type.
5127         (default_pid_to_str): Likewise.
5128         (target_pid_to_str): Change return type.
5129         (target_translate_tls_address): Update.
5130         (target_announce_detach): Update.
5131         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5132         return type.
5133         (bsd_uthread_target::pid_to_str): Change return type.
5134         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5135         type.
5136         (bsd_kvm_target::pid_to_str): Change return type.
5137         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5138         return type.
5139         (aix_thread_target::pid_to_str): Change return type.
5140         * target.h (struct target_ops) <pid_to_str>: Change return type.
5141         (target_pid_to_str, normal_pid_to_str): Likewise.
5142         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5143         type.
5144         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5145         type.
5146         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5147         return type.
5148         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5149         type.
5150         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5151         type.
5152         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5153         return type.
5154
5155 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5156
5157         * NEWS: Mention that the new default MI version is 3.  Mention
5158         changes to the output of commands and events that deal with
5159         multi-location breakpoints.
5160         * breakpoint.c: Include "mi/mi-out.h".
5161         (print_one_breakpoint): Change output syntax if using MI version
5162         >= 3.
5163         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5164         New.
5165         (mi_multi_location_breakpoint_output_fixed): New.
5166         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5167         (mi_cmd_fix_multi_location_breakpoint_output): New.
5168         (mi_multi_location_breakpoint_output_fixed): New.
5169         * mi/mi-cmds.c (mi_cmds): Register command
5170         -fix-multi-location-breakpoint-output.
5171         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5172         interpreter "mi".
5173
5174 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5175
5176         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5177         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5178         instantiate mi_ui_out based on interpreter name.
5179         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5180         * mi/mi-main.c (mi_load_progress): Likewise.
5181
5182 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5183
5184         * NEWS: Combine separate "New targets" sections for 8.3.
5185
5186 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5187
5188         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5189         (ppcfbsd_init_abi): Install gdbarch
5190         "fetch_tls_load_module_address" and "get_thread_local_address"
5191         methods.
5192
5193 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5194
5195         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5196         (riscv_fbsd_init_abi): Install gdbarch
5197         "fetch_tls_load_module_address" and "get_thread_local_address"
5198         methods.
5199
5200 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5201
5202         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5203         (i386fbsd_init_abi): Install gdbarch
5204         "fetch_tls_load_module_address" and "get_thread_local_address"
5205         methods.
5206
5207 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5208
5209         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5210         (amd64fbsd_init_abi): Install gdbarch
5211         "fetch_tls_load_module_address" and "get_thread_local_address"
5212         methods.
5213
5214 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5215
5216         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5217         (struct fbsd_pspace_data): New type.
5218         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5219         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5220         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5221         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5222         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5223
5224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5225
5226         * gdbtypes.c (lookup_struct_elt): New function.
5227         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5228         * gdbtypes.h (struct struct_elt): New type.
5229         (lookup_struct_elt): New prototype.
5230
5231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5232
5233         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5234         remove disabled code block.
5235
5236 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5237
5238         * gdbarch.sh (get_thread_local_address): New method.
5239         * gdbarch.h, gdbarch.c: Regenerate.
5240         * target.c (target_translate_tls_address): Use
5241         gdbarch_get_thread_local_address if present instead of
5242         target::get_thread_local_address.
5243
5244 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5245
5246         * target.h (target::get_thread_local_address): Update comment.
5247
5248 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5249
5250         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5251         objfile->separate_debug_objfile_backlink if not NULL.
5252
5253 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5254
5255         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5256         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5257         (amd64bsd_store_inferior_registers): Likewise.
5258         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5259         Enable segment base registers.
5260         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5261         PT_GETFSBASE and PT_GETGSBASE.
5262         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5263         PT_SETGSBASE.
5264         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5265         segment base registers.
5266         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5267
5268 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5269
5270         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5271         Update calls to i386_target_description to add 'segments'
5272         parameter.
5273         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5274         add segment base registers.
5275         * arch/i386.c (i386_create_target_description): Add 'segments'
5276         parameter to enable segment base registers.
5277         * arch/i386.h (i386_create_target_description): Likewise.
5278         * features/i386/32bit-segments.xml: New file.
5279         * features/i386/32bit-segments.c: Generate.
5280         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5281         call to i386_target_description to add 'segments' parameter.
5282         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5283         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5284         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5285         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5286         if feature is present.
5287         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5288         Add 'segments' parameter to call to i386_target_description.
5289         (i386_target_description): Add 'segments' parameter to enable
5290         segment base registers.
5291         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5292         to call to i386_target_description.
5293         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5294         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5295         Define I386_NUM_REGS.
5296         (i386_target_description): Add 'segments' parameter to enable
5297         segment base registers.
5298
5299 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5300
5301         PR/24325
5302         * source-cache.c: #undef open and close, to avoid unresolved
5303         externals during linking.
5304
5305 2019-03-12  Tom Tromey  <tromey@adacore.com>
5306
5307         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5308         const.  Add initializers.
5309         (_initialize_remote): Don't initialize ptid globals.
5310
5311 2019-03-12  Pedro Alves  <palves@redhat.com>
5312
5313         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5314
5315 2019-03-12  Pedro Alves  <palves@redhat.com>
5316
5317         * cp-name-parser.y (main): Remove unused 'len' variable.
5318
5319 2019-03-12  Tom Tromey  <tromey@adacore.com>
5320
5321         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5322         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5323
5324 2019-03-12  Tom Tromey  <tromey@adacore.com>
5325
5326         * linux-nat.c (iterate_over_lwps): Update.
5327         (stop_callback): Remove parameter.
5328         (stop_wait_callback, detach_callback, resume_set_callback)
5329         (select_singlestep_lwp_callback, set_ignore_sigint)
5330         (status_callback, resumed_callback, resume_clear_callback)
5331         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5332         data parameter.
5333         (linux_nat_target::detach, linux_nat_target::resume)
5334         (linux_stop_and_wait_all_lwps, select_event_lwp)
5335         (linux_nat_filter_event, linux_nat_wait_1)
5336         (linux_nat_target::kill, linux_nat_target::stop)
5337         (linux_nat_target::stop): Update.
5338         (linux_nat_resume_callback): Change type.
5339         (resume_stopped_resumed_lwps, count_events_callback)
5340         (select_event_lwp_callback): Likewise.
5341         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5342         * arm-linux-nat.c (struct update_registers_data): Remove.
5343         (update_registers_callback): Change type.
5344         (arm_linux_insert_hw_breakpoint1): Update.
5345         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5346         parameter.
5347         (x86_linux_dr_set_addr): Update.
5348         (x86_linux_dr_set_control): Update.
5349         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5350         (iterate_over_lwps): Use gdb::function_view.
5351         * nat/aarch64-linux-hw-point.c (struct
5352         aarch64_dr_update_callback_param): Remove.
5353         (debug_reg_change_callback): Change type.
5354         (aarch64_notify_debug_reg_change): Update.
5355         * s390-linux-nat.c (s390_refresh_per_info): Update.
5356
5357 2019-03-11  Tom Tromey  <tromey@adacore.com>
5358
5359         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5360         redundant assignment to "this_cu".
5361
5362 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5363
5364         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5365
5366 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5367
5368         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5369         from...
5370         (rank_one_type): ... this.
5371
5372 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5373
5374         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5375         from...
5376         (rank_one_type): ... this.
5377
5378 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5379
5380         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5381         from...
5382         (rank_one_type): ... this.
5383
5384 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5385
5386         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5387         from...
5388         (rank_one_type): ... this.
5389
5390 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5391
5392         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5393         from...
5394         (rank_one_type): ... this.
5395
5396 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5397
5398         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5399         from...
5400         (rank_one_type): ... this.
5401
5402 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5403
5404         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5405         from...
5406         (rank_one_type): ... this.
5407
5408 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5409
5410         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5411         from...
5412         (rank_one_type): ... this.
5413
5414 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5415
5416         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5417         from...
5418         (rank_one_type): ... this.
5419
5420 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5421
5422         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5423         from...
5424         (rank_one_type): ... this.
5425
5426 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5427
5428         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5429         from...
5430         (rank_one_type): ... this.
5431
5432 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5433
5434         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5435         from...
5436         (rank_one_type): ... this.
5437
5438 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5439
5440         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5441         inferior-events' shows the example events.
5442
5443 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5444
5445         Support styling on native MS-Windows console
5446
5447         PR/24315
5448         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5449         on MS-Windows if $TERM is not defined.
5450
5451         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5452
5453         * posix-hdep.c (gdb_console_fputs):
5454         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5455         functions.
5456         * ui-file.h (gdb_console_fputs): Add prototype.
5457
5458         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5459         back to fputs only if the former returns zero.
5460
5461 2019-03-07  Tom Tromey  <tom@tromey.com>
5462
5463         * symmisc.c (print_symbol_bcache_statistics): Update.
5464         (print_objfile_statistics): Update.
5465         * symfile.c (allocate_symtab): Update.
5466         * stabsread.c: Don't include bcache.h.
5467         * psymtab.h (struct psymbol_bcache): Don't declare.
5468         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5469         (psymbol_bcache_init, psymbol_bcache_free)
5470         (psymbol_bcache_get_bcache): Don't declare.
5471         * psymtab.c (struct psymbol_bcache): Remove.
5472         (psymtab_storage::psymtab_storage): Update.
5473         (psymtab_storage::~psymtab_storage): Update.
5474         (psymbol_bcache_init, psymbol_bcache_free)
5475         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5476         (add_psymbol_to_bcache): Update.
5477         (allocate_psymtab): Update.
5478         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5479         macro_cache>: No longer pointers.
5480         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5481         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5482         * macrotab.c (macro_bcache): Update.
5483         * macroexp.c: Don't include bcache.h.
5484         * gdbtypes.c (check_types_worklist): Update.
5485         (types_deeply_equal): Remove TRY/CATCH.  Update.
5486         * elfread.c (elf_symtab_read): Update.
5487         * dwarf2read.c: Don't include bcache.h.
5488         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5489         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5490         (print_bcache_statistics, bcache_memory_used): Don't declare.
5491         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5492         methods.  Rename all data members.
5493         * bcache.c (struct bcache): Move to bcache.h.
5494         (bcache::expand_hash_table): Rename from expand_hash_table.
5495         (bcache): Remove.
5496         (bcache::insert): Rename from bcache_full.
5497         (bcache::compare): Rename from bcache_compare.
5498         (bcache_xmalloc): Remove.
5499         (bcache::~bcache): Rename from bcache_xfree.
5500         (bcache::print_statistics): Rename from print_bcache_statistics.
5501         (bcache::memory_used): Rename from bcache_memory_used.
5502
5503 2019-03-07  Pedro Alves  <palves@redhat.com>
5504
5505         * infrun.c (normal_stop): Also check for
5506         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5507
5508 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5509
5510         * f-lang.c (value_from_host_double): Moved to...
5511         * value.c (value_from_host_double): ...here.
5512         * value.h (value_from_host_double): Declare.
5513         * guile/scm-math.c (vlscm_convert_typed_number): Use
5514         value_from_host_double.
5515         (vlscm_convert_number): Likewise.
5516         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5517         * python/py-value.c (convert_value_from_python): Likewise.
5518
5519 2019-03-06  Tom Tromey  <tom@tromey.com>
5520
5521         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5522
5523 2019-03-06  Tom Tromey  <tom@tromey.com>
5524
5525         * utils.h (free_current_contents): Don't declare.
5526         * utils.c (free_current_contents): Remove.
5527
5528 2019-03-06  Tom Tromey  <tom@tromey.com>
5529
5530         * top.c (quit_force): Update.
5531         * main.c (captured_command_loop): Update.
5532         * common/new-op.c (operator new): Update.
5533         * common/common-exceptions.c (struct catcher)
5534         <save_cleanup_chain>: Remove member.
5535         (exceptions_state_mc_init): Update.
5536         (exception_try_scope_entry): Return nullptr.
5537         (exception_try_scope_exit, exception_rethrow)
5538         (throw_exception_sjlj, throw_exception_cxx): Update.
5539         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5540         (all_cleanups, do_cleanups, discard_cleanups)
5541         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5542         (restore_cleanups, restore_final_cleanups): Don't declare.
5543         (do_final_cleanups): Remove parameter.
5544         * common/cleanups.c (cleanup_chain, make_cleanup)
5545         (make_cleanup_dtor, all_cleanups, do_cleanups)
5546         (discard_my_cleanups, discard_cleanups)
5547         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5548         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5549         (null_cleanup): Remove.
5550         (do_final_cleanups): Remove parameter.
5551
5552 2019-03-06  Tom Tromey  <tom@tromey.com>
5553
5554         * remote.c (remote_target::remote_parse_stop_reply): Use
5555         unique_xmalloc_ptr.
5556
5557 2019-03-06  Tom Tromey  <tom@tromey.com>
5558
5559         * stabsread.c (struct stabs_field_info): Rename from field_info.
5560         <list, fnlist>: Add initializers.
5561         <obstack>: New member.
5562         (read_member_functions, read_struct_fields, read_baseclasses):
5563         Allocate on obstack.  Don't use cleanups.
5564         (read_one_struct_field, read_member_functions, read_struct_fields)
5565         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5566         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5567         (read_struct_type): Update.
5568
5569 2019-03-06  Tom Tromey  <tom@tromey.com>
5570
5571         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5572         * common/filestuff.h (make_cleanup_close): Don't declare.
5573         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5574         Remove.
5575
5576 2019-03-06  Tom Tromey  <tom@tromey.com>
5577
5578         * solib-aix.c: Use make_scope_exit.
5579
5580 2019-03-06  Tom Tromey  <tom@tromey.com>
5581
5582         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5583         Use make_scope_exit.
5584
5585 2019-03-06  Tom Tromey  <tom@tromey.com>
5586
5587         * solib-svr4.c (disable_probes_interface): Remove parameter.
5588         (svr4_handle_solib_event): Use make_scope_exit.
5589
5590 2019-03-06  Tom Tromey  <tom@tromey.com>
5591
5592         * remote.c (struct stop_reply_deleter): Remove.
5593         (stop_reply_up): Update.
5594         (struct stop_reply): Derive from notif_event.  Don't typedef.
5595         <regcache>: Now a std::vector.
5596         (stop_reply_xfree): Remove.
5597         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5598         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5599         (remote_target::discard_pending_stop_replies): Use delete.
5600         (remote_target::remote_parse_stop_reply): Update.
5601         (remote_target::process_stop_reply): Update.
5602         * remote-notif.h (struct notif_event): Add virtual destructor.
5603         Remove "dtr" member.
5604         (struct notif_client) <alloc_event>: Return a unique_ptr.
5605         (notif_event_xfree): Don't declare.
5606         (notif_event_up): New typedef.
5607         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5608         (notif_event_xfree, do_notif_event_xfree): Remove.
5609         (remote_notif_state_xfree): Update.
5610
5611 2019-03-06  Tom Tromey  <tom@tromey.com>
5612
5613         * infrun.c (displaced_step_clear_cleanup): Now a
5614         forward_scope_exit type.
5615         (displaced_step_prepare_throw): Update.
5616         (displaced_step_fixup): Update.
5617
5618 2019-03-06  Tom Tromey  <tom@tromey.com>
5619
5620         * inferior.h (class inferior): Update comment.
5621         * gdbthread.h (class thread_info): Update comment.
5622
5623 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5624             Tom Tromey  <tom@tromey.com>
5625
5626         * stabsread.h (struct stab_section_list): Remove.
5627         (coffstab_build_psymtabs): Update.
5628         * dbxread.c (symbuf_sections): Now a std::vector.
5629         (sect_idx): New global.
5630         (fill_symbuf): Update.
5631         (coffstab_build_psymtabs): Change type of stabsects parameter.
5632         Update.
5633         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5634         std::vector.
5635         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5636         (coff_locate_sections): Update.
5637         (coff_symfile_read): Remove cleanups.  Update.
5638         (init_stringtab): Add storage parameter.
5639         (free_stringtab, free_stringtab_cleanup): Remove.
5640         (init_lineno): Add storage parameter.
5641         (free_linetab, free_linetab_cleanup): Remove.
5642
5643 2019-03-06  Pedro Alves  <palves@redhat.com>
5644
5645         * linux-fork.c (fork_info::clobber_regs): Delete.
5646         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5647         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5648         comment.  Adjust.
5649         (scoped_switch_fork_info::scoped_switch_fork_info)
5650         (checkpoint_command, linux_fork_context): Adjust
5651         fork_save_infrun_state calls.
5652
5653 2019-03-06  Pedro Alves  <palves@redhat.com>
5654
5655         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5656         (inf_has_multiple_threads): Return 'bool' and rewrite using
5657         inferior_info::threads().
5658
5659 2019-03-06  Pedro Alves  <palves@redhat.com>
5660
5661         * linux-fork.c: Include <list>.
5662         (fork_list): Now a std::list instance.
5663         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5664         (forks_exist_p, find_last_fork): Adjust.
5665         (new_fork): Delete.
5666         (one_fork_p): New.
5667         (add_fork): Adjust.
5668         (free_fork): Delete, folded into fork_info::~fork_info().
5669         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5670         Adjust.
5671         (init_fork_list): Delete.
5672         (linux_fork_killall, linux_fork_mourn_inferior)
5673         (linux_fork_detach, info_checkpoints_command): Adjust.
5674         (_initialize_linux_fork): No longer call init_fork_list.
5675
5676 2019-03-06  Pedro Alves  <palves@redhat.com>
5677
5678         * linux-fork.c (new_fork): New, split out of ...
5679         (add_fork): ... this.  Return void.  Move "first fork" special
5680         case from here, to ...
5681         (checkpoint_command): ... here.
5682         * linux-linux.h (add_fork): Return void.
5683
5684 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5685
5686         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5687
5688 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5689             Chris January  <chris.january@arm.com>
5690             David Lecomber  <david.lecomber@arm.com>
5691
5692         * f-exp.y: New token, UNOP_INTRINSIC.
5693         (exp): New pattern using UNOP_INTRINSIC token.
5694         (f77_keywords): Add 'abs' keyword.
5695         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5696         (value_from_host_double): New function.
5697         (evaluate_subexp_f): Support UNOP_ABS.
5698
5699 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5700
5701         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5702         types.
5703
5704 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5705
5706         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5707         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5708         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5709
5710 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5711
5712         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5713
5714 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5715             Chris January  <chris.january@arm.com>
5716
5717         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5718         * f-exp.y: Define 'KIND' token.
5719         (exp): New pattern for KIND expressions.
5720         (ptype): Handle types with a kind extension.
5721         (direct_abs_decl): Extend to spot kind extensions.
5722         (f77_keywords): Add 'kind' to the list.
5723         (push_kind_type): New function.
5724         (convert_to_kind_type): New function.
5725         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5726         * parse.c (operator_length_standard): Likewise.
5727         * parser-defs.h (enum type_pieces): Add tp_kind.
5728         * std-operator.def: Add UNOP_KIND.
5729
5730 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5731
5732         * f-exp.y (f_parse): Set yydebug.
5733
5734 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5735
5736         * f-lang.c (evaluate_subexp_f): New function.
5737         (exp_descriptor_f): New global.
5738         (f_language_defn): Use exp_descriptor_f instead of
5739         exp_descriptor_standard.
5740
5741 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5742
5743         * f-exp.y (struct token): Add comments.
5744         (dot_ops): Remove uppercase versions and the end marker.
5745         (f77_keywords): Likewise.
5746         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5747         entries in the dot_ops array are case insensitive, and use
5748         strncasecmp to compare strings.  Also some whitespace cleanup in
5749         this area.  Similar for the f77_keywords array, except entries in
5750         this list might be case sensitive.
5751
5752 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5753
5754         * f-exp.y (struct f77_boolean_val): Add comments.
5755         (boolean_values): Remove uppercase versions, and end marker.
5756         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5757         and use strncasecmp to achieve case insensitivity.  Additionally,
5758         perform whitespace cleanup around this code.
5759
5760 2019-03-06  Tom Tromey  <tromey@adacore.com>
5761
5762         * remote-sim.c (gdbsim_target_open): Use result of
5763         gdb_argv::release.
5764
5765 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5766         Dirk Schubert  <dirk.schubert@arm.com>
5767         Chris January  <chris.january@arm.com>
5768
5769         * eval.c (evaluate_subexp_standard): Call Fortran argument
5770         wrapping logic.
5771         * f-lang.c (struct value): A value which can be passed into a
5772         Fortran function call.
5773         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5774         where appropriate.
5775         (struct type): Value ready for a Fortran function call.
5776         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5777         is needed.
5778         * f-lang.h (fortran_argument_convert): Declaration.
5779         (fortran_preserve_arg_pointer): Declaration.
5780         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5781
5782 2019-03-05  Tom Tromey  <tromey@adacore.com>
5783
5784         * python/py-prettyprint.c (print_string_repr): Remove #if.
5785         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5786
5787 2019-03-05  Tom Tromey  <tromey@adacore.com>
5788
5789         * target.c (the_dummy_target): Move later.  Change type to
5790         "dummy_target".
5791         (initialize_targets): Don't initialize the_dummy_target.
5792
5793 2019-03-05  Tom Tromey  <tromey@adacore.com>
5794
5795         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5796         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5797
5798 2019-03-05  Tom Tromey  <tromey@adacore.com>
5799
5800         * windows-nat.c (windows_nat_target::attach)
5801         (windows_nat_target::detach): Don't call gdb_flush.
5802         * valprint.c (generic_val_print, val_print, val_print_string):
5803         Don't call gdb_flush.
5804         * utils.c (defaulted_query): Don't call gdb_flush.
5805         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5806         * target.c (target_announce_detach): Don't call gdb_flush.
5807         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5808         * remote.c (extended_remote_target::attach): Don't call
5809         gdb_flush.
5810         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5811         * printcmd.c (do_examine): Don't call gdb_flush.
5812         (info_display_command): Don't call gdb_flush.
5813         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5814         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5815         * memattr.c (info_mem_command): Don't call gdb_flush.
5816         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5817         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5818         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5819         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5820         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5821         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5822         (gnu_nat_target::detach): Don't call gdb_flush.
5823         * f-valprint.c (f_val_print): Don't call gdb_flush.
5824         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5825         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5826         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5827         gdb_flush.
5828         * c-valprint.c (c_val_print): Don't call gdb_flush.
5829         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5830
5831 2019-03-05  Tom Tromey  <tromey@adacore.com>
5832
5833         * varobj.c (update_dynamic_varobj_children): Update.
5834         (install_default_visualizer): Use reset, not release.
5835         * value.c (set_internalvar): Update.
5836         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5837         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5838         ATTRIBUTE_UNUSED_RESULT.
5839
5840 2019-03-05  Tom Tromey  <tromey@adacore.com>
5841
5842         * remote.c (class scoped_remote_fd) <release>: Add
5843         ATTRIBUTE_UNUSED_RESULT.
5844
5845 2019-03-05  Tom Tromey  <tromey@adacore.com>
5846
5847         * macroexp.c (struct macro_buffer) <release>: Add
5848         ATTRIBUTE_UNUSED_RESULT.
5849
5850 2019-03-05  Tom Tromey  <tromey@adacore.com>
5851
5852         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5853         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5854         ATTRIBUTE_UNUSED_RESULT.
5855
5856 2019-03-05  Tom Tromey  <tromey@adacore.com>
5857
5858         * common/scoped_fd.h (class scoped_fd) <release>: Add
5859         ATTRIBUTE_UNUSED_RESULT.
5860
5861 2019-03-05  Tom Tromey  <tromey@adacore.com>
5862
5863         * parser-defs.h (struct parser_state) <release>: Add
5864         ATTRIBUTE_UNUSED_RESULT.
5865
5866 2019-03-05  Tom Tromey  <tromey@adacore.com>
5867
5868         * utils.h (class gdb_argv) <release>: Add
5869         ATTRIBUTE_UNUSED_RESULT.
5870         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5871
5872 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5873
5874         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5875         for-loop range, to avoid compiler warnings.
5876
5877         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5878         avoid compiler warnings about unused variables.
5879
5880         * NEWS: Mention end of support for native debugging on MS-Windows
5881         before XP.
5882
5883         PR gdb/24292
5884         * common/netstuff.c:
5885         * gdbserver/gdbreplay.c
5886         * gdbserver/remote-utils.c:
5887         * ser-tcp.c:
5888         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5889         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5890         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5891         'getaddrinfo' and 'freeaddrinfo' were not available before
5892         Windows XP, and mingw.org's MinGW headers by default define
5893         _WIN32_WINNT to 0x500.
5894
5895 2019-03-01  Gary Benson <gbenson@redhat.com>
5896
5897         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5898
5899 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5900             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5901
5902         PR gdb/8527
5903         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5904         set_sigint_trap, clear_sigint_trap.
5905
5906 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5907
5908         * target.c (target_detach): Clear the regcache and the
5909         frame cache.
5910
5911 2019-02-27  Pedro Alves  <palves@redhat.com>
5912
5913         * utils.c (set_screen_size): When we cap the height/width sizes,
5914         tweak the corresponding command variable to show "unlimited":
5915
5916 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5917             Pedro Alves  <palves@redhat.com>
5918
5919         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5920         before calling rl_set_screen_size.
5921
5922 2019-02-27  Tom Tromey  <tromey@adacore.com>
5923
5924         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5925         define.
5926         * python/py-value.c: Remove Python 2.4 workaround.
5927         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5928         workaround.
5929         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5930         Python 2.4 workaround.
5931         * python/python-internal.h: Remove Python 2.4 comment.
5932         (Py_ssize_t): Don't define.
5933         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5934         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5935         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5936         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5937         * python/python.c (do_start_initialization): Remove Python 2.4
5938         workaround.
5939         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5940         (print_children): Remove Python 2.4 workaround.
5941         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5942         workaround.
5943         (CHARBUFFERPROC_NAME): Remove.
5944         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5945         Python 2.4 workaround.
5946
5947 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5948
5949         * NEWS: Note minimum Python version.
5950
5951 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5952
5953         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5954         code from these functions.  Remove corresponding ifdefs.  Use
5955         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5956         Remove gotos and target of gotos.
5957         (infpy_search_memory): Likewise.
5958
5959 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5960
5961         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5962         (hppa_gdbarch_init): Don't register deleted functions with
5963         gdbarch.
5964
5965 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5966
5967         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5968         (h8300_unwind_sp): Delete.
5969         (h8300_dummy_id): Delete.
5970         (h8300_gdbarch_init): Don't register deleted functions with
5971         gdbarch.
5972
5973 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5974
5975         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5976         (ft32_unwind_pc): Delete.
5977         (ft32_unwind_sp): Delete.
5978         (ft32_gdbarch_init): Don't register deleted functions with
5979         gdbarch.
5980
5981 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5982
5983         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5984         (frv_unwind_pc): Delete.
5985         (frv_unwind_sp): Delete.
5986         (frv_gdbarch_init): Don't register deleted functions with
5987         gdbarch.
5988
5989 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5990
5991         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5992         (riscv_unwind_pc): Delete.
5993         (riscv_unwind_sp): Delete.
5994         (riscv_gdbarch_init): Don't register deleted functions with
5995         gdbarch.
5996
5997 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5998
5999         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6000         (csky_unwind_pc): Delete.
6001         (csky_unwind_sp): Delete.
6002         (csky_gdbarch_init): Don't register deleted functions with
6003         gdbarch.
6004
6005 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6006
6007         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6008         (cris_unwind_pc): Delete.
6009         (cris_unwind_sp): Delete.
6010         (cris_gdbarch_init): Don't register deleted functions with
6011         gdbarch.
6012
6013 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6014
6015         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6016         (bfin_unwind_pc): Delete.
6017         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6018
6019 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6020
6021         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6022         (arm_unwind_pc): Delete.
6023         (arm_unwind_sp): Delete.
6024         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6025
6026 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6027
6028         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6029         (arc_unwind_pc): Delete.
6030         (arc_unwind_sp): Delete.
6031         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6032
6033 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6034
6035         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6036         (alpha_unwind_pc): Delete.
6037         (alpha_gdbarch_init): Don't register deleted functions with
6038         gdbarch.
6039
6040 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6041
6042         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6043         (aarch64_unwind_pc): Delete.
6044         (aarch64_unwind_sp): Delete.
6045         (aarch64_gdbarch_init): Don't register deleted functions with
6046         gdbarch.
6047
6048 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6049
6050         * gdbtypes.c (type_align): Don't consider static members when
6051         computing structure alignment.
6052
6053 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6054
6055         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6056         return 0 for other types.
6057         * arch-utils.c (default_type_align): Always return 0.
6058         * gdbarch.h: Regenerate.
6059         * gdbarch.sh (type_align): Extend comment.
6060         * gdbtypes.c (type_align): Add additional comments, always call
6061         gdbarch_type_align before applying the default rules.
6062         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6063         generic code will then apply a suitable default.
6064         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6065         types, return 0 for other types.
6066
6067 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6068
6069         * NEWS: Create a new section for the next release branch.
6070         Rename the section of the current branch, now that it has
6071         been cut.
6072
6073 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6074
6075         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6076         * version.in: Bump version to 8.3.50.DATE-git.
6077
6078 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6079
6080         * aix-thread.c (ptid_cmp): Remove unused variable.
6081         (get_signaled_thread): Likewise.
6082         (store_regs_user_thread): Likewise.
6083         (store_regs_kernel_thread): Likewise.
6084         (fetch_regs_kernel_thread): Remove shadowed variable.
6085
6086 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6087
6088         * features/riscv/32bit-cpu.xml: Add register numbers.
6089         * features/riscv/32bit-fpu.c: Regenerate.
6090         * features/riscv/32bit-fpu.xml: Add register numbers.
6091         * features/riscv/64bit-cpu.xml: Add register numbers.
6092         * features/riscv/64bit-fpu.c: Regenerate.
6093         * features/riscv/64bit-fpu.xml: Add register numbers.
6094
6095 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6096
6097         * NEWS: Mention two argument form of gdb.Value constructor.
6098         * python/py-value.c (convert_buffer_and_type_to_value): New
6099         function.
6100         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6101         Add support for handling an optional second argument.  Call
6102         convert_buffer_and_type_to_value as appropriate.
6103         * python/python-internal.h (Py_buffer_deleter): New struct.
6104         (Py_buffer_up): New typedef.
6105
6106 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6107
6108         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6109         instead of releasing ownership.
6110
6111 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6112
6113         * dwarf2read.c (open_and_init_dwp_file): Call
6114         elf_numsections instead of bfd_count_sections to initialize
6115         dwp_file->num_sections.
6116
6117 2019-02-25  Tom Tromey  <tromey@adacore.com>
6118
6119         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6120
6121 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6122
6123         * gcore.in: Add '--readnever' option when invoking GDB.
6124
6125 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6126
6127         * MAINTAINERS: Update my email address.
6128
6129 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6130
6131         * build-id.c (build_id_to_debug_bfd_1): New function.
6132         (build_id_to_debug_bfd): Look for separate debug file in
6133         sysroot.
6134
6135 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6136
6137         * gdbarch.sh: Update the copyright year range that is placed into
6138         generated files.
6139
6140 2019-02-22  Keith Seitz  <keiths@redhat.com>
6141
6142         PR symtab/23853
6143         * linespec.c (create_sals_line_offset): Search for the default
6144         symtab's filename instead of its fullname.
6145
6146 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6147
6148         * NEWS: Update style defaults.
6149
6150 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6151
6152         * main.c (captured_main_1): Disable styling in batch mode.
6153
6154 2019-02-20  Tom Tromey  <tom@tromey.com>
6155
6156         * symtab.c (symtab_symbol_info): Fix typos.
6157
6158 2019-02-20  Tom Tromey  <tromey@adacore.com>
6159
6160         * findcmd.c (_initialize_mem_search): Use upper case for
6161         metasyntactic variables.
6162
6163 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6164
6165         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6166         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6167
6168 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6169
6170         * top.h (source_file_name): Change to std::string.
6171         * top.c (source_file_name): Likewise.
6172         (command_line_input): Adjust.
6173         * cli/cli-script.c (script_from_file): Adjust.
6174
6175 2019-02-19  Tom Tromey  <tromey@adacore.com>
6176
6177         * ravenscar-thread.c
6178         (ravenscar_thread_target::update_thread_list): Don't call
6179         ada_build_task_list.
6180         * ada-lang.h (ada_build_task_list): Don't declare.
6181         * ada-tasks.c (struct ada_tasks_inferior_data)
6182         <task_list_valid_p>: Now bool.
6183         (read_known_tasks, ada_task_list_changed)
6184         (ada_tasks_invalidate_inferior_data): Update.
6185         (read_known_tasks_array): Return bool.
6186         (read_known_tasks_list): Likewise.
6187         (read_known_tasks): Return void.
6188         (ada_build_task_list): Now static.
6189
6190 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6191
6192         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6193         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6194
6195 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6196
6197         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6198         variant for ada_tasks_pspace_data_handle and
6199         ada_tasks_inferior_data_handle.
6200         (ada_tasks_pspace_data_cleanup): New function.
6201         (ada_tasks_inferior_data_cleanup): New function.
6202
6203 2019-02-17  Tom Tromey  <tom@tromey.com>
6204
6205         * macrotab.h (macro_source_fullname): Return a std::string.
6206         * macrotab.c (macro_include, check_for_redefinition)
6207         (macro_undef, macro_lookup_definition, foreach_macro)
6208         (foreach_macro_in_scope): Update.
6209         (macro_source_fullname): Return a std::string.
6210         * macrocmd.c (show_pp_source_pos): Update.
6211
6212 2019-02-17  Tom Tromey  <tom@tromey.com>
6213
6214         * macrocmd.c (show_pp_source_pos): Style the file names.
6215
6216 2019-02-17  Tom Tromey  <tom@tromey.com>
6217
6218         PR tui/24197:
6219         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6220
6221 2019-02-17  Tom Tromey  <tom@tromey.com>
6222
6223         * ada-lang.c (user_select_syms): Use filtered printing.
6224         * utils.c (wrap_style): New global.
6225         (desired_style): Remove.
6226         (emit_style_escape): Add stream parameter.
6227         (set_output_style, reset_terminal_style, prompt_for_continue):
6228         Update.
6229         (flush_wrap_buffer): Only flush gdb_stdout.
6230         (wrap_here): Set wrap_style.
6231         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6232         treat escape sequences as a character.  Change when wrap buffer is
6233         flushed.
6234         (fputs_styled): Do not set the output style when the default is
6235         requested.
6236         * ui-style.h (struct ui_file_style) <is_default>: New method.
6237         * source.c (print_source_lines_base): Emit escape sequences in one
6238         piece.
6239
6240 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6241
6242         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6243         integers and enumeration types.
6244
6245 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6246
6247         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6248         instead of lookup_symbol_in_language
6249         (do_exact_match): New function.
6250         (ada_get_symbol_name_matcher): Return do_exact_match when
6251         doing a verbatim match.
6252
6253 2019-02-15  Tom Tromey  <tromey@adacore.com>
6254
6255         * ravenscar-thread.c (ravenscar_thread_target::resume)
6256         (ravenscar_thread_target::wait): Special case wildcard requests.
6257
6258 2019-02-15  Tom Tromey  <tromey@adacore.com>
6259
6260         * ravenscar-thread.c (base_ptid): Remove.
6261         (struct ravenscar_thread_target) <close>: New method.
6262         <m_base_ptid>: New member.
6263         <update_inferior_ptid, active_task, task_is_currently_active,
6264         runtime_initialized>: Declare methods.
6265         <ravenscar_thread_target>: Add constructor.
6266         (ravenscar_thread_target::task_is_currently_active)
6267         (ravenscar_thread_target::update_inferior_ptid)
6268         (ravenscar_runtime_initialized): Rename.  Now methods.
6269         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6270         (ravenscar_thread_target::update_thread_list): Update.
6271         (ravenscar_thread_target::active_task): Now method.
6272         (ravenscar_thread_target::store_registers)
6273         (ravenscar_thread_target::prepare_to_store)
6274         (ravenscar_thread_target::prepare_to_store)
6275         (ravenscar_thread_target::mourn_inferior): Update.
6276         (ravenscar_inferior_created): Use "new" to create target.
6277         (ravenscar_thread_target::get_ada_task_ptid): Update.
6278         (_initialize_ravenscar): Don't initialize base_ptid.
6279         (ravenscar_ops): Remove global.
6280
6281 2019-02-15  Tom Tromey  <tromey@adacore.com>
6282
6283         * target.h (push_target): Declare new overload.
6284         * target.c (push_target): New overload, taking an rvalue reference.
6285         * remote.c (remote_target::open_1): Use push_target overload.
6286         * corelow.c (core_target_open): Use push_target overload.
6287
6288 2019-02-15  Tom Tromey  <tromey@adacore.com>
6289
6290         * ravenscar-thread.c (is_ravenscar_task)
6291         (ravenscar_task_is_currently_active): Return bool.
6292         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6293         (_initialize_ravenscar): Remove "(void)".
6294         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6295         Return bool.
6296
6297 2019-02-15  Tom Tromey  <tromey@adacore.com>
6298
6299         * ravenscar-thread.c (ravenscar_runtime_initializer)
6300         (has_ravenscar_runtime, get_running_thread_id)
6301         (ravenscar_thread_target::resume): Fix indentation.
6302
6303 2019-02-15  Tom Tromey  <tromey@adacore.com>
6304
6305         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6306         from ravenscar_arch_ops.
6307         (sparc_ravenscar_ops::fetch_registers)
6308         (sparc_ravenscar_ops::store_registers): Now methods.
6309         (sparc_ravenscar_prepare_to_store): Remove.
6310         (sparc_ravenscar_ops): Redefine.
6311         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6312         methods and destructor.  Remove members.
6313         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6314         (ravenscar_thread_target::store_registers)
6315         (ravenscar_thread_target::prepare_to_store): Update.
6316         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6317         Remove.
6318         (struct ppc_ravenscar_powerpc_ops): Derive from
6319         ravenscar_arch_ops.
6320         (ppc_ravenscar_powerpc_ops::fetch_registers)
6321         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6322         (ppc_ravenscar_powerpc_ops): Redefine.
6323         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6324         (ppc_ravenscar_e500_ops::fetch_registers)
6325         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6326         (ppc_ravenscar_e500_ops): Redefine.
6327         * aarch64-ravenscar-thread.c
6328         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6329         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6330         (aarch64_ravenscar_fetch_registers)
6331         (aarch64_ravenscar_store_registers): Now methods.
6332         (aarch64_ravenscar_ops): Redefine.
6333
6334 2019-02-15  Tom Tromey  <tromey@adacore.com>
6335
6336         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6337         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6338         (ravenscar_thread_target::stopped_by_watchpoint)
6339         (ravenscar_thread_target::stopped_data_address)
6340         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6341
6342 2019-02-15  Tom Tromey  <tromey@adacore.com>
6343
6344         * ravenscar-thread.c: Fix some typos.
6345
6346 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6347             Tom Tromey  <tromey@adacore.com>
6348
6349         * ada-lang.c (ada_exception_sal): Change addr_string to a
6350         std::string.
6351         (create_ada_exception_catchpoint): Update.
6352
6353 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6354             Tom Tromey  <tromey@adacore.com>
6355
6356         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6357         (bp_location_ops): Remove.
6358         (base_breakpoint_allocate_location): Update.
6359         (free_bp_location): Update.
6360         * ada-lang.c (class ada_catchpoint_location)
6361         <ada_catchpoint_location>: Remove ops parameter.
6362         (ada_catchpoint_location_dtor): Remove.
6363         (ada_catchpoint_location_ops): Remove.
6364         (allocate_location_exception): Update.
6365         * breakpoint.h (struct bp_location_ops): Remove.
6366         (class bp_location) <bp_location>: Remove bp_location_ops
6367         parameter.
6368         <~bp_location>: Add destructor.
6369         <ops>: Remove.
6370
6371 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6372             Pedro Alves  <palves@redhat.com>
6373
6374         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6375         'PATH_MAX'.
6376
6377 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6378             Samuel Thibault  <samuel.thibault@gnu.org>
6379             Thomas Schwinge  <thomas@codesourcery.com>
6380
6381         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6382         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6383
6384 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6385
6386         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6387         (check_empty): Use "const char *".
6388
6389         * gnu-nat.c (gnu_nat_target::detach): Instead of
6390         'detach_inferior (pid)' call
6391         'detach_inferior (find_inferior_pid (pid))'.
6392
6393         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6394         'nat/fork-inferior.o'.
6395         * gnu-nat.c: #include "nat/fork-inferior.h".
6396
6397         * gnu-nat.c (gnu_nat_target::detach): Instead of
6398         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6399         * gnu-nat.h: #include "inf-child.h".
6400         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6401         'i386_gnu_nat_target::fetch_registers'.
6402         (gnu_store_registers): Rename/move to
6403         'i386_gnu_nat_target::store_registers'.
6404
6405         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6406         * gnu-nat.h (mach_thread_info): New function.
6407         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6408
6409         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6410
6411 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6412
6413         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6414
6415 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6416
6417         * windows-nat.c (windows_add_thread): Add new parameter
6418         "main_thread_p" with default value set to false.  Update
6419         function documentation as well as all callers.
6420         (windows_delete_thread): Likewise.
6421         (fake_create_process): Update call to windows_add_thread.
6422         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6423         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6424         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6425         call to windows_delete_thread.
6426
6427 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6428
6429         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6430
6431 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6432
6433         * symfile.c (find_separate_debug_file): Use canonical path of
6434         sysroot with child_path instead of gdb_sysroot if it is valid.
6435
6436 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6437
6438         * symfile.c (find_separate_debug_file): Use child_path to
6439         determine if an object file is under a sysroot.
6440
6441 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6442
6443         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6444         unittests/child-path-selftests.c.
6445         * common/pathstuff.c (child_path): New function.
6446         * common/pathstuff.h (child_path): New prototype.
6447         * unittests/child-path-selftests.c: New file.
6448
6449 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6450
6451         * symfile.c (find_separate_debug_file): Look for separate debug
6452         files in debug directories under the sysroot.
6453
6454 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6455
6456         * symtab.h (struct minimal_symbol data_p): New const method.
6457         (struct minimal_symbol text_p): Likewise.
6458         * symtab.c (output_source_filename): Use file name style
6459         to print file name.
6460         (print_symbol_info): Likewise.
6461         (print_msymbol_info): Use address style to print addresses.
6462         Use function name style to print executable text symbols.
6463         (expand_symtab_containing_pc): Use data_p.
6464         (find_pc_sect_compunit_symtab): Likewise.
6465
6466 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6467
6468         * breakpoint.c (describe_other_breakpoints): Use address style
6469         to print addresses.
6470         (say_where): Likewise.
6471
6472 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6473
6474         * ada-typeprint.c (print_func_type): Print function name
6475         style to print function name.
6476         * c-typeprint.c (c_print_type_1): Likewise.
6477
6478 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6479
6480         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6481         for execve.
6482
6483 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6484
6485         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6486         type_stack.
6487
6488 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6489
6490         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6491         TYPE_CODE_REF types.
6492
6493 2019-02-08  Jim Wilson  <jimw@sifive.com>
6494
6495         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6496         (riscv_linux_fregset): New.
6497         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6498
6499 2019-02-07  Tom Tromey  <tom@tromey.com>
6500
6501         * thread.c (thread_cancel_execution_command): Update.
6502         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6503         methods.
6504         (struct thread_fsm_ops): Remove.
6505         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6506         (thread_fsm_should_stop, thread_fsm_return_value)
6507         (thread_fsm_set_finished, thread_fsm_finished_p)
6508         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6509         Don't declare.
6510         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6511         * infrun.c (clear_proceed_status_thread)
6512         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6513         (print_stop_event): Update.
6514         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6515         Add constructor.
6516         (step_command_fsm_ops): Remove.
6517         (new_step_command_fsm): Remove.
6518         (step_1): Update.
6519         (step_command_fsm::should_stop): Rename from
6520         step_command_fsm_should_stop.
6521         (step_command_fsm::clean_up): Rename from
6522         step_command_fsm_clean_up.
6523         (step_command_fsm::do_async_reply_reason): Rename from
6524         step_command_fsm_async_reply_reason.
6525         (struct until_next_fsm): Inherit from thread_fsm.  Add
6526         constructor.
6527         (until_next_fsm_ops): Remove.
6528         (new_until_next_fsm): Remove.
6529         (until_next_fsm::should_stop): Rename from
6530         until_next_fsm_should_stop.
6531         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6532         (until_next_fsm::do_async_reply_reason): Rename from
6533         until_next_fsm_async_reply_reason.
6534         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6535         constructor.  Change type of breakpoint.
6536         (finish_command_fsm_ops): Remove.
6537         (new_finish_command_fsm): Remove.
6538         (finish_command_fsm::should_stop): Rename from
6539         finish_command_fsm_should_stop.
6540         (finish_command_fsm::clean_up): Rename from
6541         finish_command_fsm_clean_up.
6542         (finish_command_fsm::return_value): Rename from
6543         finish_command_fsm_return_value.
6544         (finish_command_fsm::do_async_reply_reason): Rename from
6545         finish_command_fsm_async_reply_reason.
6546         (finish_command): Update.
6547         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6548         Add constructor.
6549         (call_thread_fsm_ops): Remove.
6550         (call_thread_fsm::call_thread_fsm): Rename from
6551         new_call_thread_fsm.
6552         (call_thread_fsm::should_stop): Rename from
6553         call_thread_fsm_should_stop.
6554         (call_thread_fsm::should_notify_stop): Rename from
6555         call_thread_fsm_should_notify_stop.
6556         (run_inferior_call, call_function_by_hand_dummy): Update.
6557         * cli/cli-interp.c (should_print_stop_to_console): Update.
6558         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6559         Add constructor.  Change type of location_breakpoint,
6560         caller_breakpoint.
6561         (until_break_fsm_ops): Remove.
6562         (new_until_break_fsm): Remove.
6563         (until_break_fsm::should_stop): Rename from
6564         until_break_fsm_should_stop.
6565         (until_break_fsm::clean_up): Rename from
6566         until_break_fsm_clean_up.
6567         (until_break_fsm::do_async_reply_reason): Rename from
6568         until_break_fsm_async_reply_reason.
6569         (until_break_command): Update.
6570         * thread-fsm.c: Remove.
6571         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6572
6573 2019-02-07  Tom Tromey  <tom@tromey.com>
6574
6575         * yy-remap.h: Add include guard.
6576         * xtensa-tdep.h: Add include guard.
6577         * xcoffread.h: Rename include guard.
6578         * varobj-iter.h: Add include guard.
6579         * tui/tui.h: Rename include guard.
6580         * tui/tui-winsource.h: Rename include guard.
6581         * tui/tui-wingeneral.h: Rename include guard.
6582         * tui/tui-windata.h: Rename include guard.
6583         * tui/tui-win.h: Rename include guard.
6584         * tui/tui-stack.h: Rename include guard.
6585         * tui/tui-source.h: Rename include guard.
6586         * tui/tui-regs.h: Rename include guard.
6587         * tui/tui-out.h: Rename include guard.
6588         * tui/tui-layout.h: Rename include guard.
6589         * tui/tui-io.h: Rename include guard.
6590         * tui/tui-hooks.h: Rename include guard.
6591         * tui/tui-file.h: Rename include guard.
6592         * tui/tui-disasm.h: Rename include guard.
6593         * tui/tui-data.h: Rename include guard.
6594         * tui/tui-command.h: Rename include guard.
6595         * tic6x-tdep.h: Add include guard.
6596         * target/waitstatus.h: Rename include guard.
6597         * target/wait.h: Rename include guard.
6598         * target/target.h: Rename include guard.
6599         * target/resume.h: Rename include guard.
6600         * target-float.h: Rename include guard.
6601         * stabsread.h: Add include guard.
6602         * rs6000-tdep.h: Add include guard.
6603         * riscv-fbsd-tdep.h: Add include guard.
6604         * regformats/regdef.h: Rename include guard.
6605         * record.h: Rename include guard.
6606         * python/python.h: Rename include guard.
6607         * python/python-internal.h: Rename include guard.
6608         * python/py-stopevent.h: Rename include guard.
6609         * python/py-ref.h: Rename include guard.
6610         * python/py-record.h: Rename include guard.
6611         * python/py-record-full.h: Rename include guard.
6612         * python/py-record-btrace.h: Rename include guard.
6613         * python/py-instruction.h: Rename include guard.
6614         * python/py-events.h: Rename include guard.
6615         * python/py-event.h: Rename include guard.
6616         * procfs.h: Add include guard.
6617         * proc-utils.h: Add include guard.
6618         * p-lang.h: Add include guard.
6619         * or1k-tdep.h: Rename include guard.
6620         * observable.h: Rename include guard.
6621         * nto-tdep.h: Rename include guard.
6622         * nat/x86-linux.h: Rename include guard.
6623         * nat/x86-linux-dregs.h: Rename include guard.
6624         * nat/x86-gcc-cpuid.h: Add include guard.
6625         * nat/x86-dregs.h: Rename include guard.
6626         * nat/x86-cpuid.h: Rename include guard.
6627         * nat/ppc-linux.h: Rename include guard.
6628         * nat/mips-linux-watch.h: Rename include guard.
6629         * nat/linux-waitpid.h: Rename include guard.
6630         * nat/linux-ptrace.h: Rename include guard.
6631         * nat/linux-procfs.h: Rename include guard.
6632         * nat/linux-osdata.h: Rename include guard.
6633         * nat/linux-nat.h: Rename include guard.
6634         * nat/linux-namespaces.h: Rename include guard.
6635         * nat/linux-btrace.h: Rename include guard.
6636         * nat/glibc_thread_db.h: Rename include guard.
6637         * nat/gdb_thread_db.h: Rename include guard.
6638         * nat/gdb_ptrace.h: Rename include guard.
6639         * nat/fork-inferior.h: Rename include guard.
6640         * nat/amd64-linux-siginfo.h: Rename include guard.
6641         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6642         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6643         * nat/aarch64-linux.h: Rename include guard.
6644         * nat/aarch64-linux-hw-point.h: Rename include guard.
6645         * mn10300-tdep.h: Add include guard.
6646         * mips-linux-tdep.h: Add include guard.
6647         * mi/mi-parse.h: Rename include guard.
6648         * mi/mi-out.h: Rename include guard.
6649         * mi/mi-main.h: Rename include guard.
6650         * mi/mi-interp.h: Rename include guard.
6651         * mi/mi-getopt.h: Rename include guard.
6652         * mi/mi-console.h: Rename include guard.
6653         * mi/mi-common.h: Rename include guard.
6654         * mi/mi-cmds.h: Rename include guard.
6655         * mi/mi-cmd-break.h: Rename include guard.
6656         * m2-lang.h: Add include guard.
6657         * location.h: Rename include guard.
6658         * linux-record.h: Rename include guard.
6659         * linux-nat.h: Add include guard.
6660         * linux-fork.h: Add include guard.
6661         * i386-darwin-tdep.h: Rename include guard.
6662         * hppa-linux-offsets.h: Add include guard.
6663         * guile/guile.h: Rename include guard.
6664         * guile/guile-internal.h: Rename include guard.
6665         * gnu-nat.h: Rename include guard.
6666         * gdb-stabs.h: Rename include guard.
6667         * frv-tdep.h: Add include guard.
6668         * f-lang.h: Add include guard.
6669         * event-loop.h: Add include guard.
6670         * darwin-nat.h: Rename include guard.
6671         * cp-abi.h: Rename include guard.
6672         * config/sparc/nm-sol2.h: Rename include guard.
6673         * config/nm-nto.h: Rename include guard.
6674         * config/nm-linux.h: Add include guard.
6675         * config/i386/nm-i386gnu.h: Rename include guard.
6676         * config/djgpp/nl_types.h: Rename include guard.
6677         * config/djgpp/langinfo.h: Rename include guard.
6678         * compile/gcc-cp-plugin.h: Add include guard.
6679         * compile/gcc-c-plugin.h: Add include guard.
6680         * compile/compile.h: Rename include guard.
6681         * compile/compile-object-run.h: Rename include guard.
6682         * compile/compile-object-load.h: Rename include guard.
6683         * compile/compile-internal.h: Rename include guard.
6684         * compile/compile-cplus.h: Rename include guard.
6685         * compile/compile-c.h: Rename include guard.
6686         * common/xml-utils.h: Rename include guard.
6687         * common/x86-xstate.h: Rename include guard.
6688         * common/version.h: Rename include guard.
6689         * common/vec.h: Rename include guard.
6690         * common/tdesc.h: Rename include guard.
6691         * common/selftest.h: Rename include guard.
6692         * common/scoped_restore.h: Rename include guard.
6693         * common/scoped_mmap.h: Rename include guard.
6694         * common/scoped_fd.h: Rename include guard.
6695         * common/safe-iterator.h: Rename include guard.
6696         * common/run-time-clock.h: Rename include guard.
6697         * common/refcounted-object.h: Rename include guard.
6698         * common/queue.h: Rename include guard.
6699         * common/ptid.h: Rename include guard.
6700         * common/print-utils.h: Rename include guard.
6701         * common/preprocessor.h: Rename include guard.
6702         * common/pathstuff.h: Rename include guard.
6703         * common/observable.h: Rename include guard.
6704         * common/netstuff.h: Rename include guard.
6705         * common/job-control.h: Rename include guard.
6706         * common/host-defs.h: Rename include guard.
6707         * common/gdb_wait.h: Rename include guard.
6708         * common/gdb_vecs.h: Rename include guard.
6709         * common/gdb_unlinker.h: Rename include guard.
6710         * common/gdb_unique_ptr.h: Rename include guard.
6711         * common/gdb_tilde_expand.h: Rename include guard.
6712         * common/gdb_sys_time.h: Rename include guard.
6713         * common/gdb_string_view.h: Rename include guard.
6714         * common/gdb_splay_tree.h: Rename include guard.
6715         * common/gdb_setjmp.h: Rename include guard.
6716         * common/gdb_ref_ptr.h: Rename include guard.
6717         * common/gdb_optional.h: Rename include guard.
6718         * common/gdb_locale.h: Rename include guard.
6719         * common/gdb_assert.h: Rename include guard.
6720         * common/filtered-iterator.h: Rename include guard.
6721         * common/filestuff.h: Rename include guard.
6722         * common/fileio.h: Rename include guard.
6723         * common/environ.h: Rename include guard.
6724         * common/common-utils.h: Rename include guard.
6725         * common/common-types.h: Rename include guard.
6726         * common/common-regcache.h: Rename include guard.
6727         * common/common-inferior.h: Rename include guard.
6728         * common/common-gdbthread.h: Rename include guard.
6729         * common/common-exceptions.h: Rename include guard.
6730         * common/common-defs.h: Rename include guard.
6731         * common/common-debug.h: Rename include guard.
6732         * common/cleanups.h: Rename include guard.
6733         * common/buffer.h: Rename include guard.
6734         * common/btrace-common.h: Rename include guard.
6735         * common/break-common.h: Rename include guard.
6736         * cli/cli-utils.h: Rename include guard.
6737         * cli/cli-style.h: Rename include guard.
6738         * cli/cli-setshow.h: Rename include guard.
6739         * cli/cli-script.h: Rename include guard.
6740         * cli/cli-interp.h: Rename include guard.
6741         * cli/cli-decode.h: Rename include guard.
6742         * cli/cli-cmds.h: Rename include guard.
6743         * charset-list.h: Add include guard.
6744         * buildsym-legacy.h: Rename include guard.
6745         * bfin-tdep.h: Add include guard.
6746         * ax.h: Rename include guard.
6747         * arm-linux-tdep.h: Add include guard.
6748         * arm-fbsd-tdep.h: Add include guard.
6749         * arch/xtensa.h: Rename include guard.
6750         * arch/tic6x.h: Add include guard.
6751         * arch/i386.h: Add include guard.
6752         * arch/arm.h: Rename include guard.
6753         * arch/arm-linux.h: Rename include guard.
6754         * arch/arm-get-next-pcs.h: Rename include guard.
6755         * arch/amd64.h: Add include guard.
6756         * arch/aarch64-insn.h: Rename include guard.
6757         * arch-utils.h: Rename include guard.
6758         * annotate.h: Add include guard.
6759         * amd64-darwin-tdep.h: Rename include guard.
6760         * aarch64-linux-tdep.h: Add include guard.
6761         * aarch64-fbsd-tdep.h: Add include guard.
6762         * aarch32-linux-nat.h: Add include guard.
6763
6764 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6765
6766         * macrotab.c (macro_define_internal): New function that
6767         factorizes macro_define_object_internal and macro_define_function
6768         code.
6769         (macro_define_object_internal): Use macro_define_internal.
6770         (macro_define_function): Likewise.
6771
6772 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6773
6774         * macrocmd.c (extract_identifier): Return
6775         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6776         callers.
6777
6778 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6779
6780         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6781
6782 2019-02-05  Tom Tromey  <tom@tromey.com>
6783
6784         * target.c (target_stack::unpush): Move assertion earlier.
6785
6786 2019-01-30  Tom Tromey  <tom@tromey.com>
6787
6788         PR python/23615:
6789         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6790         (gdbpy_parse_and_eval): Likewise.
6791         * python/python-internal.h (gdbpy_allow_threads): New class.
6792
6793 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6794
6795         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6796         (aarch64_fbsd_fpregmap): Move earlier.
6797         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6798         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6799         instead of individual calls to trad_frame_set_reg_addr.
6800         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6801         earlier.
6802         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6803         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6804         instead of individual calls to trad_frame_set_reg_addr.
6805
6806 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6807
6808         * CONTRIBUTE: Replace contribution list with wiki link.
6809
6810 2019-01-25  Tom Tromey  <tom@tromey.com>
6811
6812         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6813
6814 2019-01-25  Tom Tromey  <tom@tromey.com>
6815
6816         * xtensa-linux-nat.c: Fix common/ includes.
6817         * xml-support.h: Fix common/ includes.
6818         * xml-support.c: Fix common/ includes.
6819         * x86-linux-nat.c: Fix common/ includes.
6820         * windows-nat.c: Fix common/ includes.
6821         * varobj.h: Fix common/ includes.
6822         * varobj.c: Fix common/ includes.
6823         * value.c: Fix common/ includes.
6824         * valops.c: Fix common/ includes.
6825         * utils.c: Fix common/ includes.
6826         * unittests/xml-utils-selftests.c: Fix common/ includes.
6827         * unittests/utils-selftests.c: Fix common/ includes.
6828         * unittests/unpack-selftests.c: Fix common/ includes.
6829         * unittests/tracepoint-selftests.c: Fix common/ includes.
6830         * unittests/style-selftests.c: Fix common/ includes.
6831         * unittests/string_view-selftests.c: Fix common/ includes.
6832         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6833         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6834         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6835         * unittests/rsp-low-selftests.c: Fix common/ includes.
6836         * unittests/parse-connection-spec-selftests.c: Fix common/
6837         includes.
6838         * unittests/optional-selftests.c: Fix common/ includes.
6839         * unittests/offset-type-selftests.c: Fix common/ includes.
6840         * unittests/observable-selftests.c: Fix common/ includes.
6841         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6842         * unittests/memrange-selftests.c: Fix common/ includes.
6843         * unittests/memory-map-selftests.c: Fix common/ includes.
6844         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6845         * unittests/function-view-selftests.c: Fix common/ includes.
6846         * unittests/environ-selftests.c: Fix common/ includes.
6847         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6848         * unittests/common-utils-selftests.c: Fix common/ includes.
6849         * unittests/cli-utils-selftests.c: Fix common/ includes.
6850         * unittests/array-view-selftests.c: Fix common/ includes.
6851         * ui-file.c: Fix common/ includes.
6852         * tui/tui-io.c: Fix common/ includes.
6853         * tracepoint.h: Fix common/ includes.
6854         * tracepoint.c: Fix common/ includes.
6855         * tracefile-tfile.c: Fix common/ includes.
6856         * top.h: Fix common/ includes.
6857         * top.c: Fix common/ includes.
6858         * thread.c: Fix common/ includes.
6859         * target/waitstatus.h: Fix common/ includes.
6860         * target/waitstatus.c: Fix common/ includes.
6861         * target.h: Fix common/ includes.
6862         * target.c: Fix common/ includes.
6863         * target-memory.c: Fix common/ includes.
6864         * target-descriptions.c: Fix common/ includes.
6865         * symtab.h: Fix common/ includes.
6866         * symfile.c: Fix common/ includes.
6867         * stap-probe.c: Fix common/ includes.
6868         * spu-linux-nat.c: Fix common/ includes.
6869         * sparc-nat.c: Fix common/ includes.
6870         * source.c: Fix common/ includes.
6871         * solib.c: Fix common/ includes.
6872         * solib-target.c: Fix common/ includes.
6873         * ser-unix.c: Fix common/ includes.
6874         * ser-tcp.c: Fix common/ includes.
6875         * ser-pipe.c: Fix common/ includes.
6876         * ser-base.c: Fix common/ includes.
6877         * selftest-arch.c: Fix common/ includes.
6878         * s12z-tdep.c: Fix common/ includes.
6879         * rust-exp.y: Fix common/ includes.
6880         * rs6000-aix-tdep.c: Fix common/ includes.
6881         * riscv-tdep.c: Fix common/ includes.
6882         * remote.c: Fix common/ includes.
6883         * remote-notif.h: Fix common/ includes.
6884         * remote-fileio.h: Fix common/ includes.
6885         * remote-fileio.c: Fix common/ includes.
6886         * regcache.h: Fix common/ includes.
6887         * regcache.c: Fix common/ includes.
6888         * record-btrace.c: Fix common/ includes.
6889         * python/python.c: Fix common/ includes.
6890         * python/py-type.c: Fix common/ includes.
6891         * python/py-inferior.c: Fix common/ includes.
6892         * progspace.h: Fix common/ includes.
6893         * producer.c: Fix common/ includes.
6894         * procfs.c: Fix common/ includes.
6895         * proc-api.c: Fix common/ includes.
6896         * printcmd.c: Fix common/ includes.
6897         * ppc-linux-nat.c: Fix common/ includes.
6898         * parser-defs.h: Fix common/ includes.
6899         * osdata.c: Fix common/ includes.
6900         * obsd-nat.c: Fix common/ includes.
6901         * nat/x86-linux.c: Fix common/ includes.
6902         * nat/x86-linux-dregs.c: Fix common/ includes.
6903         * nat/x86-dregs.h: Fix common/ includes.
6904         * nat/x86-dregs.c: Fix common/ includes.
6905         * nat/ppc-linux.c: Fix common/ includes.
6906         * nat/mips-linux-watch.h: Fix common/ includes.
6907         * nat/mips-linux-watch.c: Fix common/ includes.
6908         * nat/linux-waitpid.c: Fix common/ includes.
6909         * nat/linux-ptrace.h: Fix common/ includes.
6910         * nat/linux-ptrace.c: Fix common/ includes.
6911         * nat/linux-procfs.c: Fix common/ includes.
6912         * nat/linux-personality.c: Fix common/ includes.
6913         * nat/linux-osdata.c: Fix common/ includes.
6914         * nat/linux-namespaces.c: Fix common/ includes.
6915         * nat/linux-btrace.h: Fix common/ includes.
6916         * nat/linux-btrace.c: Fix common/ includes.
6917         * nat/fork-inferior.c: Fix common/ includes.
6918         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6919         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6920         * nat/aarch64-linux.c: Fix common/ includes.
6921         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6922         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6923         * namespace.h: Fix common/ includes.
6924         * mips-linux-tdep.c: Fix common/ includes.
6925         * minsyms.c: Fix common/ includes.
6926         * mi/mi-parse.h: Fix common/ includes.
6927         * mi/mi-main.c: Fix common/ includes.
6928         * mi/mi-cmd-env.c: Fix common/ includes.
6929         * memrange.h: Fix common/ includes.
6930         * memattr.c: Fix common/ includes.
6931         * maint.h: Fix common/ includes.
6932         * maint.c: Fix common/ includes.
6933         * main.c: Fix common/ includes.
6934         * machoread.c: Fix common/ includes.
6935         * location.c: Fix common/ includes.
6936         * linux-thread-db.c: Fix common/ includes.
6937         * linux-nat.c: Fix common/ includes.
6938         * linux-fork.c: Fix common/ includes.
6939         * inline-frame.c: Fix common/ includes.
6940         * infrun.c: Fix common/ includes.
6941         * inflow.c: Fix common/ includes.
6942         * inferior.h: Fix common/ includes.
6943         * inferior.c: Fix common/ includes.
6944         * infcmd.c: Fix common/ includes.
6945         * inf-ptrace.c: Fix common/ includes.
6946         * inf-child.c: Fix common/ includes.
6947         * ia64-linux-nat.c: Fix common/ includes.
6948         * i387-tdep.c: Fix common/ includes.
6949         * i386-tdep.c: Fix common/ includes.
6950         * i386-linux-tdep.c: Fix common/ includes.
6951         * i386-linux-nat.c: Fix common/ includes.
6952         * i386-go32-tdep.c: Fix common/ includes.
6953         * i386-fbsd-tdep.c: Fix common/ includes.
6954         * i386-fbsd-nat.c: Fix common/ includes.
6955         * guile/scm-type.c: Fix common/ includes.
6956         * guile/guile.c: Fix common/ includes.
6957         * go32-nat.c: Fix common/ includes.
6958         * gnu-nat.c: Fix common/ includes.
6959         * gdbthread.h: Fix common/ includes.
6960         * gdbarch-selftests.c: Fix common/ includes.
6961         * gdb_usleep.c: Fix common/ includes.
6962         * gdb_select.h: Fix common/ includes.
6963         * gdb_bfd.c: Fix common/ includes.
6964         * gcore.c: Fix common/ includes.
6965         * fork-child.c: Fix common/ includes.
6966         * findvar.c: Fix common/ includes.
6967         * fbsd-nat.c: Fix common/ includes.
6968         * event-top.c: Fix common/ includes.
6969         * event-loop.c: Fix common/ includes.
6970         * dwarf2read.c: Fix common/ includes.
6971         * dwarf2loc.c: Fix common/ includes.
6972         * dwarf2-frame.c: Fix common/ includes.
6973         * dwarf-index-cache.c: Fix common/ includes.
6974         * dtrace-probe.c: Fix common/ includes.
6975         * disasm-selftests.c: Fix common/ includes.
6976         * defs.h: Fix common/ includes.
6977         * csky-tdep.c: Fix common/ includes.
6978         * cp-valprint.c: Fix common/ includes.
6979         * cp-support.h: Fix common/ includes.
6980         * cp-support.c: Fix common/ includes.
6981         * corelow.c: Fix common/ includes.
6982         * completer.h: Fix common/ includes.
6983         * completer.c: Fix common/ includes.
6984         * compile/compile.c: Fix common/ includes.
6985         * compile/compile-loc2c.c: Fix common/ includes.
6986         * compile/compile-cplus-types.c: Fix common/ includes.
6987         * compile/compile-cplus-symbols.c: Fix common/ includes.
6988         * command.h: Fix common/ includes.
6989         * cli/cli-dump.c: Fix common/ includes.
6990         * cli/cli-cmds.c: Fix common/ includes.
6991         * charset.c: Fix common/ includes.
6992         * build-id.c: Fix common/ includes.
6993         * btrace.h: Fix common/ includes.
6994         * btrace.c: Fix common/ includes.
6995         * breakpoint.h: Fix common/ includes.
6996         * breakpoint.c: Fix common/ includes.
6997         * ax.h:
6998         (enum agent_op): Fix common/ includes.
6999         * ax-general.c (struct aop_map): Fix common/ includes.
7000         * ax-gdb.c: Fix common/ includes.
7001         * auxv.c: Fix common/ includes.
7002         * auto-load.c: Fix common/ includes.
7003         * arm-tdep.c: Fix common/ includes.
7004         * arch/riscv.c: Fix common/ includes.
7005         * arch/ppc-linux-common.c: Fix common/ includes.
7006         * arch/i386.c: Fix common/ includes.
7007         * arch/arm.c: Fix common/ includes.
7008         * arch/arm-linux.c: Fix common/ includes.
7009         * arch/arm-get-next-pcs.c: Fix common/ includes.
7010         * arch/amd64.c: Fix common/ includes.
7011         * arch/aarch64.c: Fix common/ includes.
7012         * arch/aarch64-insn.c: Fix common/ includes.
7013         * arch-utils.c: Fix common/ includes.
7014         * amd64-windows-tdep.c: Fix common/ includes.
7015         * amd64-tdep.c: Fix common/ includes.
7016         * amd64-sol2-tdep.c: Fix common/ includes.
7017         * amd64-obsd-tdep.c: Fix common/ includes.
7018         * amd64-nbsd-tdep.c: Fix common/ includes.
7019         * amd64-linux-tdep.c: Fix common/ includes.
7020         * amd64-linux-nat.c: Fix common/ includes.
7021         * amd64-fbsd-tdep.c: Fix common/ includes.
7022         * amd64-fbsd-nat.c: Fix common/ includes.
7023         * amd64-dicos-tdep.c: Fix common/ includes.
7024         * amd64-darwin-tdep.c: Fix common/ includes.
7025         * agent.c: Fix common/ includes.
7026         * ada-lang.h: Fix common/ includes.
7027         * ada-lang.c: Fix common/ includes.
7028         * aarch64-tdep.c: Fix common/ includes.
7029
7030 2019-01-25  Tom Tromey  <tom@tromey.com>
7031
7032         * common/create-version.sh: Use common/version.h.
7033
7034 2019-01-24  Pedro Alves  <palves@redhat.com>
7035
7036         * infrun.c (signal_stop, signal_print, signal_program)
7037         (signal_catch, signal_pass): Now arrays instead of pointers.
7038         (update_signals_program_target, do_target_resume)
7039         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7040         * linux-nat.c (linux_nat_target::pass_signals)
7041         (linux_nat_target::create_inferior, linux_nat_target::attach):
7042         Adjust.
7043         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7044         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7045         * procfs.c (procfs_target::pass_signals): Adjust.
7046         * record-full.c (record_full_target::resume): Adjust.
7047         * remote.c (remote_target::pass_signals)
7048         (remote_target::program_signals): Adjust.
7049         * target-debug.h (target_debug_print_signals): Now takes a
7050         gdb::array_view as parameter.  Adjust.
7051         * target.h (target_ops) <pass_signals, program_signals>: Replace
7052         pointer and length parameters with gdb::array_view.
7053         (target_pass_signals, target_program_signals): Likewise.
7054         * target-delegates.c: Regenerate.
7055
7056 2019-01-24  Pedro Alves  <palves@redhat.com>
7057
7058         * common/forward-scope-exit.h
7059         (forward_scope_exit::forward_scope_exit): Pass arguments to
7060         m_bind_function directly, instead of creating a std::bind and
7061         copying that.
7062
7063 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7064
7065         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7066         for static members.
7067         (pass_in_v_vfp_candidate): Likewise.
7068
7069 2019-01-23  Tom Tromey  <tom@tromey.com>
7070             Pedro Alves  <palves@redhat.com>
7071
7072         * regcache.c (class regcache_invalidator): Remove.
7073         (regcache::raw_write): Use make_scope_exit.
7074
7075 2019-01-23  Tom Tromey  <tom@tromey.com>
7076
7077         * ui-out.h (class ui_out_emit_type): Update comment.
7078
7079 2019-01-23  Tom Tromey  <tom@tromey.com>
7080
7081         * infrun.c (fetch_inferior_event): Update comment.
7082
7083 2019-01-23  Tom Tromey  <tom@tromey.com>
7084             Pedro Alves  <palves@redhat.com>
7085
7086         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7087         parameter.
7088         (fetch_inferior_event): Use SCOPE_EXIT.
7089
7090
7091 2019-01-23  Tom Tromey  <tom@tromey.com>
7092             Pedro Alves  <palves@redhat.com>
7093
7094         * infrun.c (disable_thread_events): Delete.
7095         (stop_all_threads): Use SCOPE_EXIT.
7096
7097 2019-01-23  Tom Tromey  <tom@tromey.com>
7098             Pedro Alves  <palves@redhat.com>
7099
7100         * symfile.c: Include forward-scope-exit.h.
7101         (clear_symtab_users_cleanup): Replace forward declaration with
7102         a FORWARD_SCOPE_EXIT.
7103         (syms_from_objfile_1): Use the forward_scope_exit and
7104         gdb::optional instead of cleanup_function.
7105         (reread_symbols): Use the forward_scope_exit instead of
7106         cleanup_function.
7107         (clear_symtab_users_cleanup): Remove function.
7108
7109 2019-01-23  Tom Tromey  <tom@tromey.com>
7110             Pedro Alves  <palves@redhat.com>
7111
7112         * linux-nat.c: Include scope-exit.h.
7113         (cleanup_target_stop): Remove.
7114         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7115         SCOPE_EXIT.
7116
7117 2019-01-23  Tom Tromey  <tom@tromey.com>
7118             Pedro Alves  <palves@redhat.com>
7119
7120         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7121         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7122
7123 2019-01-23  Tom Tromey  <tom@tromey.com>
7124             Andrew Burgess  <andrew.burgess@embecosm.com>
7125             Pedro Alves  <palves@redhat.com>
7126
7127         * infrun.c (fetch_inferior_event): Use scope_exit.
7128         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7129         * top.c (execute_command): Use scope_exit.
7130         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7131         * utils.c (do_bpstat_clear_actions_cleanup)
7132         (make_bpstat_clear_actions_cleanup): Remove.
7133
7134 2019-01-23  Tom Tromey  <tom@tromey.com>
7135             Pedro Alves  <palves@redhat.com>
7136
7137         * infrun.c: Include "common/scope-exit.h"
7138         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7139         (wait_for_inferior): Use SCOPE_EXIT.
7140         (fetch_inferior_event): Use scope_exit.
7141
7142 2019-01-23  Tom Tromey  <tom@tromey.com>
7143             Pedro Alves  <palves@redhat.com>
7144
7145         * breakpoint.c (create_breakpoint): Remove cleanup.
7146
7147 2019-01-23  Tom Tromey  <tom@tromey.com>
7148             Andrew Burgess  <andrew.burgess@embecosm.com>
7149             Pedro Alves  <palves@redhat.com>
7150
7151 2019-01-23  Pedro Alves  <palves@redhat.com>
7152
7153         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7154
7155 2019-01-23  Pedro Alves  <palves@redhat.com>
7156             Andrew Burgess  <andrew.burgess@embecosm.com>
7157
7158         * gdbthread.h: Include "common/forward-scope-exit.h".
7159         (scoped_finish_thread_state): Redefine custom class in terms of
7160         forward_scope_exit.
7161
7162 2019-01-23  Pedro Alves  <palves@redhat.com>
7163             Andrew Burgess  <andrew.burgess@embecosm.com>
7164
7165         * common/forward-scope-exit.h: New file.
7166
7167 2019-01-23  Pedro Alves  <palves@redhat.com>
7168             Andrew Burgess  <andrew.burgess@embecosm.com>
7169             Tom Tromey  <tom@tromey.com>
7170
7171         * common/scope-exit.h: New file.
7172
7173 2019-01-23  Pedro Alves  <palves@redhat.com>
7174
7175         * common/preprocessor.h (ESC): Rename to ...
7176         (ESC_PARENS): ... this.
7177         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7178         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7179
7180 2019-01-23  Tom Tromey  <tom@tromey.com>
7181
7182         * language.h (class scoped_switch_to_sym_language_if_auto):
7183         Initialize m_lang in both cases.
7184
7185 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7186
7187         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7188         with XCNEW.
7189
7190 2019-01-22  Tom Tromey  <tom@tromey.com>
7191
7192         * corelow.c: Do not include sys/file.h.
7193
7194 2019-01-22  Tom Tromey  <tom@tromey.com>
7195
7196         * tui/tui-wingeneral.h: Include gdb_curses.h.
7197
7198 2019-01-22  Tom Tromey  <tom@tromey.com>
7199
7200         * source-cache.h (class source_cache) <get_source_lines,
7201         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7202
7203 2019-01-22  Tom Tromey  <tom@tromey.com>
7204
7205         * remote-fileio.h (struct remote_target): Declare.
7206
7207 2019-01-22  Tom Tromey  <tom@tromey.com>
7208
7209         * python/py-arch.c: Do not include py-ref.h.
7210         * python/py-bpevent.c: Do not include py-ref.h.
7211         * python/py-cmd.c: Do not include py-ref.h.
7212         * python/py-continueevent.c: Do not include py-ref.h.
7213         * python/py-event.h: Do not include py-ref.h.
7214         * python/py-evtregistry.c: Do not include py-ref.h.
7215         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7216         * python/py-frame.c: Do not include py-ref.h.
7217         * python/py-framefilter.c: Do not include py-ref.h.
7218         * python/py-function.c: Do not include py-ref.h.
7219         * python/py-infevents.c: Do not include py-ref.h.
7220         * python/py-linetable.c: Do not include py-ref.h.
7221         * python/py-objfile.c: Do not include py-ref.h.
7222         * python/py-param.c: Do not include py-ref.h.
7223         * python/py-prettyprint.c: Do not include py-ref.h.
7224         * python/py-progspace.c: Do not include py-ref.h.
7225         * python/py-symbol.c: Do not include py-ref.h.
7226         * python/py-symtab.c: Do not include py-ref.h.
7227         * python/py-type.c: Do not include py-ref.h.
7228         * python/py-unwind.c: Do not include py-ref.h.
7229         * python/py-utils.c: Do not include py-ref.h.
7230         * python/py-value.c: Do not include py-ref.h.
7231         * python/py-varobj.c: Do not include py-ref.h.
7232         * python/py-xmethods.c: Do not include py-ref.h.
7233         * python/python.c: Do not include py-ref.h.
7234         * varobj.c: Do not include py-ref.h.
7235
7236 2019-01-22  Tom Tromey  <tom@tromey.com>
7237
7238         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7239         keyword for bcache.
7240
7241 2019-01-22  Tom Tromey  <tom@tromey.com>
7242
7243         * compile/compile-cplus-types.c: Remove a comment by #include.
7244
7245 2019-01-22  Tom Tromey  <tom@tromey.com>
7246
7247         * compile/gcc-c-plugin.h: Include compile-internal.h.
7248
7249 2019-01-22  Tom Tromey  <tom@tromey.com>
7250
7251         * stabsread.c (EXTERN): Do not define.
7252         (symnum, next_symbol_text_func, processing_gcc_compilation)
7253         (within_function, global_sym_chain, global_stabs)
7254         (previous_stab_code, this_object_header_files)
7255         (n_this_object_header_files)
7256         (n_allocated_this_object_header_files): Define.
7257         * stabsread.h (EXTERN): Never define.  Use "extern".
7258
7259 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7260
7261         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7262         history_value.
7263
7264 2019-01-21  Tom Tromey  <tom@tromey.com>
7265
7266         * ui-out.c: Fix includes.
7267         * tui/tui-source.c: Fix includes.
7268         * target.c: Fix includes.
7269         * remote.c: Fix includes.
7270         * regcache.c: Fix includes.
7271         * python/py-block.c: Fix includes.
7272         * printcmd.c: Fix includes.
7273         * or1k-tdep.c: Fix includes.
7274         * mi/mi-main.c: Fix includes.
7275         * m32r-tdep.c: Fix includes.
7276         * csky-tdep.c: Fix includes.
7277         * compile/compile-cplus-types.c: Fix includes.
7278         * cli/cli-interp.c: Fix includes.
7279
7280 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7281
7282         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7283         for padding.
7284
7285 2019-01-16  Tom Tromey  <tom@tromey.com>
7286
7287         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7288         earlier.
7289         (struct objfile) <msymbols_range>: Move from top level.
7290         <msymbols>: New method.
7291         (class objfile_msymbols): Remove.
7292         * symtab.c (default_collect_symbol_completion_matches_break_on):
7293         Update.
7294         * symmisc.c (dump_msymbols): Update.
7295         * stabsread.c (scan_file_globals): Update.
7296         * objc-lang.c (info_selectors_command, info_classes_command)
7297         (find_methods): Update.
7298         * minsyms.c (find_solib_trampoline_target): Update.
7299         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7300         * coffread.c (coff_symfile_read): Update.
7301         * ada-lang.c (ada_lookup_simple_minsym)
7302         (ada_collect_symbol_completion_matches): Update.
7303
7304 2019-01-16  Tom Tromey  <tom@tromey.com>
7305
7306         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7307         type.  Remove no-argument constructor.
7308         <iterator::operator++>: Simplify.
7309         <begin>: Update.
7310         <end>: Use minimal_symbol_count.
7311
7312 2019-01-16  Tom Tromey  <tom@tromey.com>
7313
7314         * objfiles.h (struct objfile) <psymtabs>: New method.
7315         (class objfile_psymtabs): Remove.
7316         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7317         typedef.
7318         <range>: New method.
7319         (require_partial_symbols): Change return type.
7320         * psymtab.c (require_partial_symbols)
7321         (psym_expand_symtabs_matching): Update.
7322         * mdebugread.c (parse_partial_symbols): Update.
7323         * dbxread.c (dbx_end_psymtab): Update.
7324
7325 2019-01-15  Tom Tromey  <tom@tromey.com>
7326
7327         * symtab.c (lookup_objfile_from_block)
7328         (lookup_symbol_in_objfile_symtabs)
7329         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7330         (find_line_symtab, info_sources_command)
7331         (default_collect_symbol_completion_matches_break_on)
7332         (make_source_files_completion_list): Update.
7333         * symmisc.c (print_objfile_statistics, dump_objfile)
7334         (maintenance_print_symbols, maintenance_info_symtabs)
7335         (maintenance_check_symtabs, maintenance_info_line_tables):
7336         Update.
7337         * source.c (select_source_symtab)
7338         (forget_cached_source_info_for_objfile): Update.
7339         * objfiles.h (class objfile_compunits): Remove.
7340         (struct objfile) <compunits_range>: New typedef.
7341         (compunits): New method.
7342         * objfiles.c (objfile_relocate1): Update.
7343         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7344         * maint.c (count_symtabs_and_blocks): Update.
7345         * linespec.c (iterate_over_all_matching_symtabs): Update.
7346         * cp-support.c (add_symbol_overload_list_qualified): Update.
7347         * coffread.c (coff_symtab_read): Update.
7348         * ada-lang.c (add_nonlocal_symbols)
7349         (ada_collect_symbol_completion_matches)
7350         (ada_add_global_exceptions): Update.
7351
7352 2019-01-15  Tom Tromey  <tom@tromey.com>
7353
7354         * progspace.h (program_space) <objfiles_safe_range>: New
7355         typedef.
7356         <objfiles_safe>: New method.
7357         * objfiles.h (class all_objfiles_safe): Remove.
7358         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7359         * jit.c (jit_inferior_exit_hook): Update.
7360
7361 2019-01-17  Tom Tromey  <tom@tromey.com>
7362
7363         * progspace.h (program_space) <objfiles_range>: New typedef.
7364         <objfiles>: New method.
7365         <objfiles_head>: Rename from objfiles.
7366         (object_files): Update.
7367         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7368         * guile/scm-pretty-print.c
7369         (ppscm_find_pretty_printer_from_objfiles): Update.
7370         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7371         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7372         Update.
7373         * python/py-progspace.c (pspy_get_objfiles): Update.
7374         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7375         Update.
7376         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7377         (objfpy_lookup_objfile_by_build_id): Update.
7378         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7379         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7380         Update.
7381         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7382         (expand_symtab_containing_pc, lookup_objfile_from_block)
7383         (lookup_static_symbol, basic_lookup_transparent_type)
7384         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7385         (find_line_symtab, info_sources_command)
7386         (default_collect_symbol_completion_matches_break_on)
7387         (make_source_files_completion_list, find_main_name): Update.
7388         * symmisc.c (print_symbol_bcache_statistics)
7389         (print_objfile_statistics, maintenance_print_symbols)
7390         (maintenance_print_msymbols, maintenance_print_objfiles)
7391         (maintenance_info_symtabs, maintenance_check_symtabs)
7392         (maintenance_expand_symtabs, maintenance_info_line_tables):
7393         Update.
7394         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7395         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7396         (map_overlay_command, unmap_overlay_command)
7397         (simple_overlay_update, expand_symtabs_matching)
7398         (map_symbol_filenames): Update.
7399         * symfile-debug.c (set_debug_symfile): Update.
7400         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7401         Update.
7402         * source.c (select_source_symtab, forget_cached_source_info):
7403         Update.
7404         * solib.c (solib_read_symbols): Update.
7405         * solib-spu.c (append_ocl_sos): Update.
7406         * psymtab.c (maintenance_print_psymbols)
7407         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7408         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7409         * printcmd.c (info_symbol_command): Update.
7410         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7411         Update.
7412         * objfiles.h (class all_objfiles): Remove.
7413         * objfiles.c (have_partial_symbols, have_full_symbols)
7414         (have_minimal_symbols, qsort_cmp, update_section_map)
7415         (shared_objfile_contains_address_p)
7416         (default_iterate_over_objfiles_in_search_order): Update.
7417         * objc-lang.c (info_selectors_command, info_classes_command)
7418         (find_methods): Update.
7419         * minsyms.c (find_solib_trampoline_target): Update.
7420         * maint.c (maintenance_info_sections)
7421         (maintenance_translate_address, count_symtabs_and_blocks):
7422         Update.
7423         * main.c (captured_main_1): Update.
7424         * linux-thread-db.c (try_thread_db_load_from_pdir)
7425         (has_libpthread): Update.
7426         * linespec.c (iterate_over_all_matching_symtabs)
7427         (search_minsyms_for_name): Update.
7428         * jit.c (jit_find_objf_with_entry_addr): Update.
7429         * hppa-tdep.c (find_unwind_entry)
7430         (hppa_lookup_stub_minimal_symbol): Update.
7431         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7432         Update.
7433         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7434         (elf_gnu_ifunc_resolve_by_got): Update.
7435         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7436         * dwarf-index-write.c (save_gdb_index_command): Update.
7437         * cp-support.c (add_symbol_overload_list_qualified): Update.
7438         * breakpoint.c (create_overlay_event_breakpoint)
7439         (create_longjmp_master_breakpoint)
7440         (create_std_terminate_master_breakpoint)
7441         (create_exception_master_breakpoint): Update.
7442         * blockframe.c (find_pc_partial_function): Update.
7443         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7444         (ada_collect_symbol_completion_matches)
7445         (ada_add_global_exceptions): Update.
7446
7447 2019-01-17  Tom Tromey  <tom@tromey.com>
7448
7449         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7450         declare VEC.
7451         (solib_target_parse_libraries): Change return type.
7452         (library_list_start_segment, library_list_start_section)
7453         (library_list_end_library, library_list_start_library); Update.
7454         (solib_target_free_library_list): Remove.
7455         (solib_target_parse_libraries): Remove cleanup.  Change return
7456         type.
7457         (solib_target_current_sos): Update.
7458
7459 2019-01-17  Tom Tromey  <tromey@bapiya>
7460
7461         * valprint.c: Replace "the the" with "the".
7462         * symtab.c: Replace "the the" with "the".
7463         * solib.c: Replace "the the" with "the".
7464         * solib-dsbt.c: Replace "the the" with "the".
7465         * linespec.c: Replace "the the" with "the".
7466         * dwarf2loc.h: Replace "the the" with "the".
7467         * amd64-windows-tdep.c: Replace "the the" with "the".
7468         * aarch64-tdep.c: Replace "the the" with "the".
7469
7470 2019-01-16  Keith Seitz  <keiths@redhat.com>
7471
7472         PR gdb/23773
7473         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7474         <builder>: Rename to ..
7475         <m_builder>: ... this and make private.
7476         (dwarf2_cu::get_builder): New method.  Change all users of
7477         `builder' to use this method.
7478         (dwarf2_start_symtab): Move to ...
7479         (dwarf2_cu::start_symtab): ... here.  Update all callers
7480         (setup_type_unit_groups): Move to ...
7481         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7482         callers.
7483         (dwarf2_cu::reset_builder): New method.
7484         (process_full_compunit, process_full_type_unit): Use
7485         dwarf2_cu::reset_builder.
7486         (follow_die_offset): Record the ancestor CU if it is different
7487         from the followed DIE's CU.
7488         (follow_die_sig_1): Likewise.
7489
7490 2019-01-15  Tom Tromey  <tom@tromey.com>
7491
7492         * remote.c (class remote_state) <buf>: Now a char_vector.
7493         <buf_size>: Remove.
7494         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7495         parameter.
7496         (remote_target::getpkt_or_notif_sane_1)
7497         (remote_target::getpkt_sane)
7498         (remote_target::getpkt_or_notif_sane): Likewise.
7499         (class remote_target) <putpkt>: New overload.
7500         (remote_target::read_frame): Change type of "buf_p".  Remove
7501         sizeof_p parameter.
7502         (packet_ok): New overload.
7503         (packet_check_result): New overload.
7504         Update all uses.
7505
7506 2019-01-14  Tom Tromey  <tom@tromey.com>
7507
7508         * remote-notif.c (handle_notification, remote_notif_ack)
7509         (remote_notif_parse): Make "buf" const.
7510         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7511         const.
7512         (remote_notif_parse, remote_notif_ack, handle_notification):
7513         Likewise.
7514         * remote.c (remote_notif_stop_parse): Make "buf" const.
7515         (remote_target::remote_parse_stop_reply): Make "buf" const.
7516         (remote_notif_stop_ack): Make "buf" const.
7517
7518 2019-01-14  Tom Tromey  <tom@tromey.com>
7519
7520         * remote.c (remote_console_output): Make parameter const.
7521
7522 2019-01-14  Tom Tromey  <tom@tromey.com>
7523
7524         * target-debug.h (target_debug_print_signals): Constify.
7525         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7526         * procfs.c (procfs_target::pass_signals): Update.
7527         * linux-nat.c (linux_nat_target::pass_signals): Update.
7528         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7529         * target-delegates.c: Rebuild.
7530         * remote.c (remote_target::program_signals): Update.
7531         (remote_target::pass_signals): Update.
7532         * target.c (target_pass_signals): Constify argument.
7533         (target_program_signals): Likewise.
7534         * target.h (struct target_ops) <pass_signals, program_signals>:
7535         Constify argument.
7536         (target_pass_signals, target_program_signals): Constify argument.
7537
7538 2019-01-14  Tom Tromey  <tom@tromey.com>
7539
7540         PR tui/28819:
7541         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7542
7543 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7544
7545         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7546         field.
7547         * rs6000-tdep.c: Include reggroups.h.
7548         (IS_V_ALIAS_PSEUDOREG): Define.
7549         (rs6000_register_name): Return names for the "vX" aliases.
7550         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7551         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7552         aliases.  Call default_register_reggroup_p for all other
7553         pseudo-registers.
7554         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7555         New functions.
7556         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7557         Handle "vX" aliases.
7558         (v_alias_pseudo_register_collect): New function.
7559         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7560         (rs6000_gdbarch_init): Initialize "vX" aliases as
7561         pseudo-registers.  Restore registration of
7562         rs6000_pseudo_register_reggroup_p with
7563         set_tdesc_pseudo_register_reggroup_p.
7564
7565 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7566
7567         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7568         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7569         set_gdbarch_num_pseudo_regs.
7570
7571 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7572
7573         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7574         Remove arg prefixname, add do_set and do_show.
7575         Add member functions set_list and show_list.
7576         * cli/cli-style.c (class cli_style_option): Update accordingly.
7577         (style_set_list): Move to file scope.
7578         (style_show_list): Likewise.
7579         (set_style): Call help_list.
7580         (show_style): Call cmd_show_list.
7581         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7582         Update to use the new macro.
7583
7584 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7585
7586         * ada-lang.c (_initialize_ada_language): Expand the help text
7587         for the "catch exception" command.
7588
7589 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7590
7591         * symtab.c (matching_obj_sections): Initialize obj,
7592         declare it closer to its usage.
7593
7594 2019-01-10  Tom Tromey  <tom@tromey.com>
7595
7596         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7597         (basic_inf_threads_range): Remove.
7598         (inf_threads_range, inf_non_exited_threads_range)
7599         (safe_inf_threads_range): Use next_adapter.
7600
7601 2019-01-10  Keith Seitz  <keiths@redhat.com>
7602
7603         PR gdb/23712
7604         PR symtab/23010
7605         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7606         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7607
7608 2019-01-10  Keith Seitz  <keiths@redhat.com>
7609
7610         PR gdb/23712
7611         PR symtab/23010
7612         * dictionary.c (pending_to_vector): Remove.
7613         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7614         Remove _1 suffix, replacing functions of the same name.  Update
7615         all callers.
7616         (dict_create_hashed, dict_create_hashed_expandable)
7617         (dict_create_linear, dict_create_linear_expandable, dict_free)
7618         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7619         Make functions static.
7620
7621 2019-01-10  Keith Seitz  <keiths@redhat.com>
7622
7623         PR gdb/23712
7624         PR symtab/23010
7625         * dictionary.h (struct dictionary): Replace declaration with
7626         multidictionary.
7627         (dict_create_hashed, dict_create_hashed_expandable)
7628         (dict_create_linear, dict_create_linear_expandable)
7629         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7630         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7631         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7632         taking multidictionary argument.
7633         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7634         * block.h (struct block) <dict>: Change to multidictionary
7635         and rename `multidict'.
7636         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7637         symmisc.c: Update all dictionary references to multidictionary.
7638
7639 2019-01-10  Keith Seitz  <keiths@redhat.com>
7640
7641         PR gdb/23712
7642         PR symtab/23010
7643         * dictionary.c: Include unordered_map.
7644         (pending_to_vector): New function.
7645         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7646         Rewrite the non-"_1" functions to take vector instead
7647         of linked list.
7648         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7649         "new" _1 versions of the same name.
7650         (multidictionary): Define.
7651         (std::hash<enum language): New definition.
7652         (collate_pending_symbols_by_language, mdict_create_hashed)
7653         (mdict_create_hashed_expandable, mdict_create_linear)
7654         (mdict_create_linear_expandable, mdict_free)
7655         (find_language_dictionary, create_new_language_dictionary)
7656         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7657         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7658         (mdict_size, mdict_empty): New functions.
7659         * dictionary.h (mdict_iterator): Define.
7660
7661 2019-01-10  Pedro Alves  <palves@redhat.com>
7662
7663         * breakpoint.c (read_uploaded_action)
7664         (create_tracepoint_from_upload): Adjust to use
7665         gdb::unique_xmalloc_ptr.
7666         * ctf.c (ctf_write_uploaded_tp):
7667         (SET_ARRAY_FIELD): Use emplace_back.
7668         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7669         * tracefile-tfile.c (tfile_write_uploaded_tp):
7670         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7671         gdb::unique_xmalloc_ptr.
7672         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7673         at_string, cond_string, cmd_strings>: Replace char pointers
7674         with gdb::unique_xmalloc_ptr.
7675
7676 2019-01-10  Pedro Alves  <palves@redhat.com>
7677
7678         * solib-target.c (library_list_start_library): Don't xstrdup name.
7679
7680 2019-01-10  Pedro Alves  <palves@redhat.com>
7681
7682         * mdebugread.c (parse_partial_symbols): Use
7683         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7684
7685 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7686
7687         * linux-fork.c (scoped_switch_fork_info)
7688         <~scoped_switch_fork_info>: Fix incorrect variable name.
7689
7690 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7691
7692         * linux-fork.c (scoped_switch_fork_info)
7693         <scoped_switch_fork_info>: Make explicit.
7694         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7695
7696 2019-01-10  Tom Tromey  <tom@tromey.com>
7697
7698         * objfiles.h (objfile::reset_psymtabs): Update.
7699         * objfiles.c (objfile::objfile): Update.
7700         * psymtab.h (psymtab_storage::obstack): Update.
7701         (psymtab_storage::m_obstack): Use gdb::optional.
7702         (class psymtab_storage): Update comment.  Remove objfile
7703         parameter.
7704         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7705
7706 2019-01-10  Tom Tromey  <tom@tromey.com>
7707
7708         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7709         <free_psymtabs>: Now private.
7710         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7711         (allocate_psymtab): Use new method.
7712
7713 2019-01-10  Tom Tromey  <tom@tromey.com>
7714
7715         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7716         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7717         * mdebugread.c (parse_partial_symbols): Use
7718         allocate_dependencies.
7719         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7720         allocate_dependencies.
7721         (process_psymtab_comp_unit_reader)
7722         (build_type_psymtab_dependencies): Likewise.
7723         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7724
7725 2019-01-10  Tom Tromey  <tom@tromey.com>
7726
7727         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7728         PSYMBOL_SET_LANGUAGE.
7729         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7730
7731 2019-01-10  Tom Tromey  <tom@tromey.com>
7732
7733         * psymtab.h (psymtab_storage::obstack): New method.
7734         <m_obstack>: Rename from obstack; now private.
7735         * psymtab.c (psymtab_storage): Update.
7736         * dwarf2read.c (create_addrmap_from_index)
7737         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7738         Update.
7739
7740 2019-01-10  Tom Tromey  <tom@tromey.com>
7741
7742         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7743         * objfiles.h (objfile::reset_psymtabs): New method.
7744
7745 2019-01-10  Tom Tromey  <tom@tromey.com>
7746
7747         * symmisc.c (print_symbol_bcache_statistics): Update.
7748         (print_objfile_statistics): Update.
7749         * symfile.c (reread_symbols): Update.
7750         * psymtab.h (class psymtab_storage): New.
7751         * psymtab.c (psymtab_storage): New constructor.
7752         (~psymtab_storage): New destructor.
7753         (require_partial_symbols): Update.
7754         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7755         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7756         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7757         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7758         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7759         (start_psymtab_common, end_psymtab_common)
7760         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7761         (allocate_psymtab): Update.
7762         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7763         Update.
7764         (dump_psymtab_addrmap, maintenance_print_psymbols)
7765         (maintenance_check_psymtabs): Update.
7766         (class objfile_psymtabs): Move to objfiles.h.
7767         * psympriv.h (discard_psymtab): Now inline.
7768         (psymtab_discarder::psymtab_discarder): Update.
7769         (psymtab_discarder::~psymtab_discarder): Update.
7770         (ALL_OBJFILE_PSYMTABS): Rewrite.
7771         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7772         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7773         Remove fields.
7774         <partial_symtabs>: New field.
7775         (class objfile_psymtabs): Move from psymtab.h.  Update.
7776         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7777         psymbol_cache.
7778         (objfile::~objfile): Don't destroy psymbol_cache.
7779         * mdebugread.c (parse_partial_symbols): Update.
7780         * dwarf2read.c (create_addrmap_from_index)
7781         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7782         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7783         (add_partial_subprogram, dwarf2_ranges_read): Update.
7784         * dwarf-index-write.c (write_address_map)
7785         (write_one_signatured_type, recursively_write_psymbols)
7786         (class debug_names, class debug_names, write_psymtabs_to_index):
7787         Update.
7788
7789 2019-01-10  Tom Tromey  <tom@tromey.com>
7790
7791         * symtab.h (SYMBOL_SET_NAMES): Update.
7792         (symbol_set_names): Update.
7793         (MSYMBOL_SET_NAMES): Update.
7794         * symtab.c (symbol_set_names): Change argument to be an
7795         objfile_per_bfd_storage.
7796         * psymtab.c (add_psymbol_to_bcache): Update.
7797         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7798
7799 2019-01-10  Tom Tromey  <tom@tromey.com>
7800
7801         * symtab.c (create_demangled_names_hash): Change argument to be an
7802         objfile_per_bfd_storage.
7803         (symbol_set_names): Update.
7804
7805 2019-01-10  Tom Tromey  <tom@tromey.com>
7806
7807         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7808         init_psymbol_list.
7809         * psymtab.c (init_psymbol_list): Do nothing if already called.
7810         * psympriv.h (init_psymbol_list): Add comment.
7811         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7812         init_psymbol_list.
7813         * dbxread.c (dbx_symfile_read): Unconditionally call
7814         init_psymbol_list.
7815
7816 2019-01-10  Tom Tromey  <tom@tromey.com>
7817
7818         * xcoffread.c (scan_xcoff_symtab): Update.
7819         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7820         "where".
7821         * mdebugread.c (parse_partial_symbols)
7822         (handle_psymbol_enumerators): Update.
7823         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7824         * dbxread.c (read_dbx_symtab): Update.
7825         * psympriv.h (psymbol_placement): New enum.
7826         (add_psymbol_to_list): Update.
7827
7828 2019-01-10  Tom Tromey  <tom@tromey.com>
7829
7830         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7831         static_psymbols parameters.
7832         (scan_xcoff_symtab): Update.
7833         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7834         static_psymbols parameters.
7835         * psympriv.h (start_psymtab_common): Update.
7836         * mdebugread.c (parse_partial_symbols): Update.
7837         * dwarf2read.c (create_partial_symtab): Update.
7838         * dbxread.c (read_dbx_symtab): Update.
7839         (start_psymtab): Remove global_psymbols and static_psymbols
7840         parameters.
7841
7842 2019-01-10  Tom Tromey  <tom@tromey.com>
7843
7844         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7845         * psymtab.c (allocate_psymtab): Add comment.
7846         * psympriv.h (allocate_psymtab): Add comment.
7847         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7848         initializations.
7849         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7850
7851 2019-01-10  Tom Tromey  <tom@tromey.com>
7852
7853         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7854         Don't declare.
7855         * mipsread.c: Include mdebugread.h.
7856         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7857         Declare.
7858         * elfread.c: Include mdebugread.h.
7859
7860 2019-01-09  Tom Tromey  <tom@tromey.com>
7861
7862         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7863         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7864         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7865         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7866         (psym_lookup_symbol, psym_find_last_source_symtab)
7867         (psym_forget_cached_source_info, psym_print_stats)
7868         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7869         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7870         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7871         (psym_find_compunit_symtab_by_address)
7872         (maintenance_print_psymbols, maintenance_info_psymtabs)
7873         (maintenance_check_psymtabs): Use ranged for.
7874         * psymtab.h (class objfile_psymtabs): New.
7875         (require_partial_symbols): Return objfile_psymtabs.
7876         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7877
7878 2019-01-09  Tom Tromey  <tom@tromey.com>
7879
7880         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7881         (find_pc_mapped_section, list_overlays_command)
7882         (map_overlay_command, unmap_overlay_command)
7883         (simple_overlay_update): Use all_objfiles.
7884         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7885         * printcmd.c (info_symbol_command): Use all_objfiles.
7886         * objfiles.h (ALL_OBJSECTIONS): Remove.
7887         * maint.c (maintenance_translate_address): Use all_objfiles.
7888         * gcore.c (gcore_create_callback): Use all_objfiles.
7889         (objfile_find_memory_regions): Likewise.
7890
7891 2019-01-09  Tom Tromey  <tom@tromey.com>
7892
7893         * symtab.c (find_line_symtab, info_sources_command)
7894         (make_source_files_completion_list): Use objfile_compunits.
7895         * source.c (select_source_symtab): Use objfile_compunits.
7896         * objfiles.h (struct objfile): Update comment.
7897         (ALL_OBJFILES): Remove.
7898         (ALL_FILETABS): Remove.
7899         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7900         objfile_compunits.
7901
7902 2019-01-09  Tom Tromey  <tom@tromey.com>
7903
7904         * symmisc.c (print_objfile_statistics, dump_objfile)
7905         (maintenance_print_symbols): Use compunit_filetabs.
7906         * source.c (forget_cached_source_info_for_objfile): Use
7907         compunit_filetabs.
7908         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7909         (ALL_FILETABS): Use compunit_filetabs.
7910         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7911         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7912
7913 2019-01-09  Tom Tromey  <tom@tromey.com>
7914
7915         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7916         (compunit_filetabs): New.
7917         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7918         compunit_filetabs.
7919         (info_sources_command, make_source_files_completion_list): Remove
7920         declaration.
7921         * symmisc.c (print_objfile_statistics, dump_objfile)
7922         (maintenance_print_symbols): Remove declaration.
7923         (maintenance_info_symtabs): Use compunit_filetabs.
7924         (maintenance_info_line_tables): Likewise.
7925         * source.c (select_source_symtab): Change local variable name.
7926         (forget_cached_source_info_for_objfile): Remove declaration.
7927         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7928         * objfiles.c (objfile_relocate1): Remove declaration.
7929         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7930         declaration.
7931         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7932         * coffread.c (coff_symtab_read): Remove declaration.
7933         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7934         compunit_filetabs.
7935
7936 2019-01-09  Tom Tromey  <tom@tromey.com>
7937
7938         * symtab.c (lookup_objfile_from_block)
7939         (find_pc_sect_compunit_symtab, search_symbols)
7940         (default_collect_symbol_completion_matches_break_on): Use
7941         objfile_compunits.
7942         * objfiles.h (ALL_COMPUNITS): Remove.
7943         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7944         * cp-support.c (add_symbol_overload_list_qualified): Use
7945         objfile_compunits.
7946         * ada-lang.c (ada_collect_symbol_completion_matches)
7947         (ada_add_global_exceptions): Use objfile_compunits.
7948
7949 2019-01-09  Tom Tromey  <tom@tromey.com>
7950
7951         * source.c (select_source_symtab)
7952         (forget_cached_source_info_for_objfile): Remove declaration.
7953         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7954         declaration.
7955         * maint.c (count_symtabs_and_blocks): Remove declaration.
7956         * cp-support.c (add_symbol_overload_list_qualified): Remove
7957         declaration.
7958         * coffread.c (coff_symtab_read): Remove declaration.
7959         * symtab.c (lookup_symbol_in_objfile_symtabs)
7960         (basic_lookup_transparent_type_1): Use objfile_compunits.
7961         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7962         (info_sources_command, search_symbols)
7963         (default_collect_symbol_completion_matches_break_on)
7964         (make_source_files_completion_list): Remove declaration.
7965         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7966         (ada_collect_symbol_completion_matches)
7967         (ada_add_global_exceptions): Remove declaration.
7968         * linespec.c (iterate_over_all_matching_symtabs): Use
7969         objfile_compunits.
7970         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7971         (class objfile_compunits): New.
7972         (ALL_COMPUNITS): Use objfile_compunits.
7973         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7974         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7975         objfile_compunits.
7976         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7977
7978 2019-01-09  Tom Tromey  <tom@tromey.com>
7979
7980         * symtab.c (search_symbols)
7981         (default_collect_symbol_completion_matches_break_on): Use
7982         objfile_msymbols.
7983         * ada-lang.c (ada_lookup_simple_minsym)
7984         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7985         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7986         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7987         objfile_msymbols.
7988         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7989         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7990         * objc-lang.c (find_methods): Use objfile_msymbols.
7991         (info_selectors_command, info_classes_command): Likewise.
7992         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7993         * objfiles.h (class objfile_msymbols): New.
7994         (ALL_OBJFILE_MSYMBOLS): Remove.
7995         (ALL_MSYMBOLS): Remove.
7996
7997 2019-01-09  Tom Tromey  <tom@tromey.com>
7998
7999         * common/next-iterator.h (next_adapter): Add Iterator template
8000         parameter.
8001         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8002         (class all_objfiles_safe): New.
8003         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8004         * objfiles.c (put_objfile_before): Update comment.
8005         (add_separate_debug_objfile): Likewise.
8006         (free_all_objfiles): Use all_objfiles_safe.
8007         (objfile_purge_solibs): Likewise.
8008
8009 2019-01-09  Tom Tromey  <tom@tromey.com>
8010
8011         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8012         (expand_symtab_containing_pc, lookup_static_symbol)
8013         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8014         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8015         all_objfiles.
8016         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8017         * breakpoint.c (create_overlay_event_breakpoint)
8018         (create_longjmp_master_breakpoint)
8019         (create_std_terminate_master_breakpoint)
8020         (create_exception_master_breakpoint): Use all_objfiles.
8021         * linux-thread-db.c (try_thread_db_load_from_pdir)
8022         (has_libpthread): Use all_objfiles.
8023         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8024         * linespec.c (iterate_over_all_matching_symtabs)
8025         (search_minsyms_for_name): Use all_objfiles.
8026         * maint.c (maintenance_info_sections): Use all_objfiles.
8027         * main.c (captured_main_1): Use all_objfiles.
8028         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8029         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8030         * guile/scm-pretty-print.c
8031         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8032         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8033         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8034         (maintenance_print_msymbols): Use all_objfiles.
8035         * source.c (select_source_symtab): Use all_objfiles.
8036         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8037         * symfile.c (remove_symbol_file_command)
8038         (expand_symtabs_matching, map_symbol_filenames): Use
8039         all_objfiles.
8040         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8041         all_objfiles.
8042         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8043         * objc-lang.c (find_methods): Use all_objfiles.
8044         * objfiles.c (have_partial_symbols, have_full_symbols)
8045         (have_minimal_symbols, qsort_cmp)
8046         (default_iterate_over_objfiles_in_search_order): Use
8047         all_objfiles.
8048         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8049         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8050         (maintenance_check_psymtabs): Use all_objfiles.
8051         (ALL_PSYMTABS): Remove.
8052         * compile/compile-object-run.c (do_module_cleanup): Use
8053         all_objfiles.
8054         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8055         * cp-support.c (add_symbol_overload_list_qualified): Use
8056         all_objfiles.
8057         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8058         Use all_objfiles.
8059         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8060         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8061         all_objfiles.
8062         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8063         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8064         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8065         Uses all_objfiles.
8066         * solib.c (solib_read_symbols): Use all_objfiles
8067
8068 2019-01-09  Tom Tromey  <tom@tromey.com>
8069
8070         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8071         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8072         all_objfiles.
8073         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8074         * symmisc.c (print_symbol_bcache_statistics)
8075         (print_objfile_statistics, maintenance_print_objfiles)
8076         (maintenance_info_symtabs, maintenance_check_symtabs)
8077         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8078         all_objfiles.
8079         * source.c (forget_cached_source_info): Use all_objfiles.
8080         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8081         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8082         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8083         * objfiles.c (update_section_map): Use all_objfiles.
8084         (shared_objfile_contains_address_p): Likewise.
8085         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8086         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8087
8088 2019-01-09  Tom Tromey  <tom@tromey.com>
8089
8090         * common/next-iterator.h: New file.
8091         * objfiles.h (class all_objfiles): New.
8092         (struct objfile_iterator): New.
8093
8094 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8095
8096         * NEWS: Move the description of the changed "frame", "select-frame",
8097          and "info frame" commands to the Changed commands section.
8098
8099 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8100
8101         * gdbtypes.c (check_stub_method_group): Remove handling of old
8102         mangling schemes.
8103         * linespec.c (find_methods): Likewise.
8104         * stabsread.c (read_member_functions): Likewise.
8105         * valops.c (search_struct_method): Likewise.
8106         (value_struct_elt_for_reference): Likewise.
8107         * NEWS: Mention this change.
8108
8109 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8110
8111         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8112         print_source_lines.
8113         * source.c (print_source_lines_base): Update line number check.
8114         (print_source_lines): New function.
8115         (source_lines_range::source_lines_range): New function.
8116         * source.h (class source_lines_range): New class.
8117         (print_source_lines): New declaration.
8118
8119 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8120
8121         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8122
8123 2019-01-08  Tom Tromey  <tom@tromey.com>
8124             Simon Marchi  <simon.marchi@ericsson.com>
8125
8126         PR gdb/24060
8127         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8128         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8129         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8130         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8131         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8132         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8133
8134 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * source.c (select_source_symtab): Move header comment to
8137         declaration in source.h.
8138         (forget_cached_source_info_for_objfile): Likewise.
8139         (forget_cached_source_info): Likewise.
8140         (identify_source_line): Likewise.
8141         * source.h (identify_source_line): Move declaration from symtab.h
8142         and add comment from source.c
8143         (print_source_lines): Likewise.
8144         (forget_cached_source_info_for_objfile): Likewise.
8145         (forget_cached_source_info): Likewise.
8146         (select_source_symtab): Likewise.
8147         (enum print_source_lines_flag): Move definition from symtab.h.
8148         * symtab.h (identify_source_line): Move declaration to source.h.
8149         (print_source_lines): Likewise.
8150         (forget_cached_source_info_for_objfile): Likewise.
8151         (forget_cached_source_info): Likewise.
8152         (select_source_symtab): Likewise.
8153         (enum print_source_lines_flag): Move definition to source.h.
8154         * tui/tui-hooks.c: Add 'source.h' include.
8155
8156 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8157
8158         * source.c (print_source_lines_base): Handle requests to print
8159         reverse line number sequences, and guard against empty lines
8160         string.
8161
8162 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8163
8164         * source.c (print_source_lines_base): Fix skip of '\r' if next
8165         character is '\n'.
8166
8167 2019-01-06  Tom Tromey  <tom@tromey.com>
8168
8169         * c-exp.y (struct c_parse_state) <macro_original_text,
8170         expansion_obstack>: New member.
8171         (macro_original_text, expansion_obstack): Remove globals.
8172         (scan_macro_expansion, scanning_macro_expansion)
8173         (finished_macro_expansion): Update.
8174         (scan_macro_cleanup): Remove.
8175         (yylex, c_parse): Update.
8176
8177 2019-01-06  Tom Tromey  <tom@tromey.com>
8178
8179         * c-exp.y (struct c_parse_state) <strings>: New member.
8180         (operator_stoken): Update.
8181
8182 2019-01-06  Tom Tromey  <tom@tromey.com>
8183
8184         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8185         (union type_stack_elt) <typelist_val>: Now a pointer to
8186         std::vector.
8187         (type_stack_cleanup): Don't declare.
8188         (push_typelist): Update.
8189         * parse.c (pop_typelist): Return a std::vector.
8190         (push_typelist): Take a std::vector.
8191         (follow_types): Update.  Do not free args.
8192         (type_stack_cleanup): Remove.
8193         * c-exp.y (struct c_parse_state): New.
8194         (cpstate): New global.
8195         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8196         (nonempty_typelist): Update.
8197         (func_mod): Create a new vector.
8198         (c_parse): Create a c_parse_state.
8199         (check_parameter_typelist): Do not delete params.
8200         (function_method): Update.  Do not delete type_list.
8201
8202 2019-01-06  Tom Tromey  <tom@tromey.com>
8203
8204         PR gdb/28155:
8205         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8206         check_typedef.
8207         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8208         (print_return_value): Likewise.
8209
8210 2019-01-05  Tom Tromey  <tom@tromey.com>
8211
8212         * contrib/cleanup_check.py: Remove.
8213         * contrib/gcc-with-excheck: Remove.
8214         * contrib/exsummary.py: Remove.
8215         * contrib/excheck.py: Remove.
8216
8217 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8218
8219         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8220         NULL. Initialize tpprev to NULL instead of assigning it
8221         to NULL on the next statement.
8222         * windows-nat.c (windows_delete_thread): Remove check for
8223         main_thread_id before printing thread exit notifications.
8224         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8225         Remove thread ID check against main_thread_id.
8226         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8227         windows_delete_thread.
8228         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8229
8230 2019-01-04  Tom Tromey  <tom@tromey.com>
8231
8232         * compile/compile.c (_initialize_compile): Use upper case for
8233         metasyntactic variables.
8234         * symmisc.c (_initialize_symmisc): Use upper case for
8235         metasyntactic variables.
8236         * psymtab.c (_initialize_psymtab): Use upper case for
8237         metasyntactic variables.
8238         * demangle.c (demangle_command): Use upper case for metasyntactic
8239         variables.
8240         (_initialize_demangler): Likewise.
8241         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8242         variables.
8243
8244 2019-01-03  Tom Tromey  <tom@tromey.com>
8245
8246         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8247
8248 2019-01-03  Tom Tromey  <tom@tromey.com>
8249
8250         * python/py-symtab.c (salpy_str): Update.
8251         (struct salpy_sal_object) <symtab>: Now a PyObject.
8252         (salpy_dealloc): Update.
8253         (del_objfile_sal): Use gdbpy_ref.
8254
8255 2019-01-03  Tom Tromey  <tom@tromey.com>
8256
8257         * python/py-type.c (convert_field): Use new_reference.  Return
8258         gdbpy_ref.
8259         (make_fielditem): Return gdbpy_ref.
8260         (typy_fields): Update.
8261         (typy_getitem): Update.
8262         (field_name): Return gdbpy_ref.  Use new_reference.
8263         (typy_iterator_iternext): Update.
8264
8265 2019-01-03  Tom Tromey  <tom@tromey.com>
8266
8267         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8268
8269 2019-01-03  Tom Tromey  <tom@tromey.com>
8270
8271         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8272         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8273         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8274         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8275         (pspy_set_type_printers): Likewise.
8276         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8277         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8278         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8279         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8280         (objfpy_set_type_printers): Likewise.
8281
8282 2019-01-03  Tom Tromey  <tom@tromey.com>
8283
8284         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8285         (gdbpy_print_stack): Use gdbpy_err_fetch.
8286         * python/python-internal.h (class gdbpy_err_fetch): New class.
8287         (class gdbpy_enter) <m_error_type, m_error_value,
8288         m_error_traceback>: Remove.
8289         <m_error>: New member.
8290         (gdbpy_exception_to_string): Don't declare.
8291         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8292         * python/py-value.c (convert_value_from_python): Use
8293         gdbpy_err_fetch.
8294         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8295         gdbpy_exception_to_string.
8296         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8297         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8298         gdbpy_err_fetch.
8299
8300 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8301
8302         * linux-nat.c (delete_lwp_cleanup): Delete.
8303         (struct lwp_deleter): New struct.
8304         (lwp_info_up): New typedef.
8305         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8306         lwp_info_up.
8307
8308 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8309
8310         * linux-fork.c (class scoped_switch_fork_info): New class.
8311         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8312
8313 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8314
8315         * valops.c (find_overload_match): Remove use of null_cleanup, and
8316         calls to do_cleanups.
8317
8318 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8319
8320         * compile/compile-cplus-types.c
8321         (compile_cplus_instance::decl_name): Handle changes to
8322         cp_func_name.
8323         * cp-support.c (cp_func_name): Update header comment, update
8324         return type.
8325         * cp-support.h (cp_func_name): Update return type in declaration.
8326         * valops.c (find_overload_match): Move temp_func local to top
8327         level of function and change its type.  Use temp_func to hold and
8328         delete temporary string obtained from cp_func_name.
8329
8330 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8331
8332         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8333         gdb::char_vector, remove cleanup, and update uses of `msg`.
8334
8335 2019-01-03  Jim Wilson  <jimw@sifive.com>
8336
8337         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8338
8339 2019-01-02  Tom Tromey  <tom@tromey.com>
8340
8341         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8342         (tdesc_parse_xml): Remove cleanups.
8343         * target-descriptions.h (make_cleanup_free_target_description):
8344         Don't declare.
8345         (target_desc_deleter): New struct.
8346         (target_desc_up): New typedef.
8347         * target-descriptions.c (target_desc_deleter::operator()): Rename
8348         from free_target_description.
8349         (make_cleanup_free_target_description): Remove.
8350
8351 2019-01-02  Tom Tromey  <tom@tromey.com>
8352
8353         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8354         constructor, destructor.
8355         (linespec_parser): Remove typedef.
8356         (~linespec_parser): Rename from linespec_parser_delete.
8357         (linespec_lex_to_end, linespec_complete_label)
8358         (linespec_complete): Update.
8359         (decode_line_full): Remove cleanups.
8360         (decode_line_1): Update.
8361
8362 2019-01-02  Tom Tromey  <tom@tromey.com>
8363
8364         * python/python-internal.h (inferior_to_inferior_object): Change
8365         return type.
8366         * python/py-exitedevent.c (create_exited_event_object): Update.
8367         * python/py-inferior.c (inferior_to_inferior_object): Return
8368         gdbpy_ref.
8369         (python_new_inferior, python_inferior_deleted)
8370         (thread_to_thread_object, delete_thread_object)
8371         (build_inferior_list, gdbpy_selected_inferior): Update.
8372         * python/py-infthread.c (create_thread_object): Update.  Also fail
8373         if inferior_to_inferior_object fails.
8374
8375 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8376
8377         * inferior.h (class inferior) <displaced_step_state>: New field.
8378         * infrun.h (struct displaced_step_state): Move here from
8379         infrun.c.  Initialize fields, add constructor.
8380         <inf>: Remove field.
8381         <reset>: New method.
8382         * infrun.c (struct displaced_step_inferior_state): Move to
8383         infrun.h.
8384         (displaced_step_inferior_states): Remove.
8385         (get_displaced_stepping_state): Adust.
8386         (displaced_step_in_progress_any_inferior): Adjust.
8387         (displaced_step_in_progress_thread): Adjust.
8388         (displaced_step_in_progress): Adjust.
8389         (add_displaced_stepping_state): Remove.
8390         (get_displaced_step_closure_by_addr): Adjust.
8391         (remove_displaced_stepping_state): Remove.
8392         (infrun_inferior_exit): Call displaced_step_state.reset.
8393         (use_displaced_stepping): Don't check for NULL.
8394         (displaced_step_prepare_throw): Call
8395         get_displaced_stepping_state.
8396         (displaced_step_fixup): Don't check for NULL.
8397         (prepare_for_detach): Don't check for NULL.
8398
8399 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8400
8401         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8402          in case of call that did not complete.
8403
8404 2019-01-02  Andrey Utkin  <autkin@undo.io>
8405
8406         * symfile.c (find_separate_debug_file): Fix search of debug files for
8407         remote debuggee.
8408
8409 2019-01-02  Tom Tromey  <tom@tromey.com>
8410
8411         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8412         indentation.
8413         * python/py-frame.c (frapy_older): Remove cast.
8414         (frapy_newer): Likewise.
8415         * python/py-breakpoint.c (local_setattro): Remove cast.
8416         * python/py-arch.c (archpy_name): Remove local variable.
8417         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8418
8419 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8420
8421         * unittests/basic_string_view/element_access/char/empty.cc:
8422         Fix year range in copyright header.
8423
8424 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8425
8426         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8427         Delete.
8428         <operator==>: Update with for removed field.
8429         <hash>: Likewise.
8430         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8431         <isa_features>: ...this.
8432         <abi_features>: New field.
8433         (riscv_isa_flen): Update comment.
8434         (riscv_abi_xlen): New declaration.
8435         (riscv_abi_flen): New declaration.
8436         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8437         isa_features.
8438         (riscv_abi_xlen): New function.
8439         (riscv_isa_flen): Update to get answer from isa_features.
8440         (riscv_abi_flen): New function.
8441         (riscv_has_fp_abi): Update to get answer from abi_features.
8442         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8443         xlen and flen.
8444         (riscv_call_info) <xlen, flen>: Update comment.
8445         (riscv_call_arg_struct): Remove invalid assertions
8446         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8447         is removed.
8448         (riscv_gdbarch_init): Gather isa features and abi features
8449         separately, ensure both match on the gdbarch when reusing an old
8450         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8451         a target with 64-bit float hardware.
8452
8453 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8454
8455         * source.c (search_command_helper): Stop reverse search
8456         when line 1 has been searched.
8457
8458 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8459
8460         * record-full.c (record_full_base_target::close): Rewrite
8461         record_full_core_buf_list free logic.
8462
8463 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8464
8465         * break-catch-syscall.c (print_one_catch_syscall): xfree
8466         the last text.
8467
8468 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8469
8470         * top.c (print_gdb_version): Update Copyright year in version
8471         message.
8472
8473 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8474
8475         Update copyright year range in all GDB files.
8476
8477 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8478
8479         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8480
8481 For older changes see ChangeLog-2018.
8482 \f
8483 Local Variables:
8484 mode: change-log
8485 left-margin: 8
8486 fill-column: 74
8487 version-control: never
8488 coding: utf-8
8489 End:
8490