gdb/ChangeLog

   1 2019-01-17  Tom Tromey  <tom@tromey.com>
   2
   3         * progspace.h (program_space) <objfiles_range>: New typedef.
   4         <objfiles>: New method.
   5         <objfiles_head>: Rename from objfiles.
   6         (object_files): Update.
   7         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
   8         * guile/scm-pretty-print.c
   9         (ppscm_find_pretty_printer_from_objfiles): Update.
  10         * guile/scm-objfile.c (gdbscm_objfiles): Update.
  11         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
  12         Update.
  13         * python/py-progspace.c (pspy_get_objfiles): Update.
  14         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
  15         Update.
  16         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
  17         (objfpy_lookup_objfile_by_build_id): Update.
  18         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
  19         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
  20         Update.
  21         * symtab.c (iterate_over_symtabs, matching_obj_sections)
  22         (expand_symtab_containing_pc, lookup_objfile_from_block)
  23         (lookup_static_symbol, basic_lookup_transparent_type)
  24         (find_pc_sect_compunit_symtab, find_symbol_at_address)
  25         (find_line_symtab, info_sources_command)
  26         (default_collect_symbol_completion_matches_break_on)
  27         (make_source_files_completion_list, find_main_name): Update.
  28         * symmisc.c (print_symbol_bcache_statistics)
  29         (print_objfile_statistics, maintenance_print_symbols)
  30         (maintenance_print_msymbols, maintenance_print_objfiles)
  31         (maintenance_info_symtabs, maintenance_check_symtabs)
  32         (maintenance_expand_symtabs, maintenance_info_line_tables):
  33         Update.
  34         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
  35         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
  36         (map_overlay_command, unmap_overlay_command)
  37         (simple_overlay_update, expand_symtabs_matching)
  38         (map_symbol_filenames): Update.
  39         * symfile-debug.c (set_debug_symfile): Update.
  40         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
  41         Update.
  42         * source.c (select_source_symtab, forget_cached_source_info):
  43         Update.
  44         * solib.c (solib_read_symbols): Update.
  45         * solib-spu.c (append_ocl_sos): Update.
  46         * psymtab.c (maintenance_print_psymbols)
  47         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
  48         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
  49         * printcmd.c (info_symbol_command): Update.
  50         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
  51         Update.
  52         * objfiles.h (class all_objfiles): Remove.
  53         * objfiles.c (have_partial_symbols, have_full_symbols)
  54         (have_minimal_symbols, qsort_cmp, update_section_map)
  55         (shared_objfile_contains_address_p)
  56         (default_iterate_over_objfiles_in_search_order): Update.
  57         * objc-lang.c (info_selectors_command, info_classes_command)
  58         (find_methods): Update.
  59         * minsyms.c (find_solib_trampoline_target): Update.
  60         * maint.c (maintenance_info_sections)
  61         (maintenance_translate_address, count_symtabs_and_blocks):
  62         Update.
  63         * main.c (captured_main_1): Update.
  64         * linux-thread-db.c (try_thread_db_load_from_pdir)
  65         (has_libpthread): Update.
  66         * linespec.c (iterate_over_all_matching_symtabs)
  67         (search_minsyms_for_name): Update.
  68         * jit.c (jit_find_objf_with_entry_addr): Update.
  69         * hppa-tdep.c (find_unwind_entry)
  70         (hppa_lookup_stub_minimal_symbol): Update.
  71         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
  72         Update.
  73         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
  74         (elf_gnu_ifunc_resolve_by_got): Update.
  75         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
  76         * dwarf-index-write.c (save_gdb_index_command): Update.
  77         * cp-support.c (add_symbol_overload_list_qualified): Update.
  78         * breakpoint.c (create_overlay_event_breakpoint)
  79         (create_longjmp_master_breakpoint)
  80         (create_std_terminate_master_breakpoint)
  81         (create_exception_master_breakpoint): Update.
  82         * blockframe.c (find_pc_partial_function): Update.
  83         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
  84         (ada_collect_symbol_completion_matches)
  85         (ada_add_global_exceptions): Update.
  86
  87 2019-01-17  Tom Tromey  <tom@tromey.com>
  88
  89         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
  90         declare VEC.
  91         (solib_target_parse_libraries): Change return type.
  92         (library_list_start_segment, library_list_start_section)
  93         (library_list_end_library, library_list_start_library); Update.
  94         (solib_target_free_library_list): Remove.
  95         (solib_target_parse_libraries): Remove cleanup.  Change return
  96         type.
  97         (solib_target_current_sos): Update.
  98
  99 2019-01-17  Tom Tromey  <tromey@bapiya>
 100
 101         * valprint.c: Replace "the the" with "the".
 102         * symtab.c: Replace "the the" with "the".
 103         * solib.c: Replace "the the" with "the".
 104         * solib-dsbt.c: Replace "the the" with "the".
 105         * linespec.c: Replace "the the" with "the".
 106         * dwarf2loc.h: Replace "the the" with "the".
 107         * amd64-windows-tdep.c: Replace "the the" with "the".
 108         * aarch64-tdep.c: Replace "the the" with "the".
 109
 110 2019-01-16  Keith Seitz  <keiths@redhat.com>
 111
 112         PR gdb/23773
 113         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 114         <builder>: Rename to ..
 115         <m_builder>: ... this and make private.
 116         (dwarf2_cu::get_builder): New method.  Change all users of
 117         `builder' to use this method.
 118         (dwarf2_start_symtab): Move to ...
 119         (dwarf2_cu::start_symtab): ... here.  Update all callers
 120         (setup_type_unit_groups): Move to ...
 121         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 122         callers.
 123         (dwarf2_cu::reset_builder): New method.
 124         (process_full_compunit, process_full_type_unit): Use
 125         dwarf2_cu::reset_builder.
 126         (follow_die_offset): Record the ancestor CU if it is different
 127         from the followed DIE's CU.
 128         (follow_die_sig_1): Likewise.
 129
 130 2019-01-15  Tom Tromey  <tom@tromey.com>
 131
 132         * remote.c (class remote_state) <buf>: Now a char_vector.
 133         <buf_size>: Remove.
 134         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 135         parameter.
 136         (remote_target::getpkt_or_notif_sane_1)
 137         (remote_target::getpkt_sane)
 138         (remote_target::getpkt_or_notif_sane): Likewise.
 139         (class remote_target) <putpkt>: New overload.
 140         (remote_target::read_frame): Change type of "buf_p".  Remove
 141         sizeof_p parameter.
 142         (packet_ok): New overload.
 143         (packet_check_result): New overload.
 144         Update all uses.
 145
 146 2019-01-14  Tom Tromey  <tom@tromey.com>
 147
 148         * remote-notif.c (handle_notification, remote_notif_ack)
 149         (remote_notif_parse): Make "buf" const.
 150         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 151         const.
 152         (remote_notif_parse, remote_notif_ack, handle_notification):
 153         Likewise.
 154         * remote.c (remote_notif_stop_parse): Make "buf" const.
 155         (remote_target::remote_parse_stop_reply): Make "buf" const.
 156         (remote_notif_stop_ack): Make "buf" const.
 157
 158 2019-01-14  Tom Tromey  <tom@tromey.com>
 159
 160         * remote.c (remote_console_output): Make parameter const.
 161
 162 2019-01-14  Tom Tromey  <tom@tromey.com>
 163
 164         * target-debug.h (target_debug_print_signals): Constify.
 165         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 166         * procfs.c (procfs_target::pass_signals): Update.
 167         * linux-nat.c (linux_nat_target::pass_signals): Update.
 168         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 169         * target-delegates.c: Rebuild.
 170         * remote.c (remote_target::program_signals): Update.
 171         (remote_target::pass_signals): Update.
 172         * target.c (target_pass_signals): Constify argument.
 173         (target_program_signals): Likewise.
 174         * target.h (struct target_ops) <pass_signals, program_signals>:
 175         Constify argument.
 176         (target_pass_signals, target_program_signals): Constify argument.
 177
 178 2019-01-14  Tom Tromey  <tom@tromey.com>
 179
 180         PR tui/28819:
 181         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 182
 183 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 184
 185         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 186         field.
 187         * rs6000-tdep.c: Include reggroups.h.
 188         (IS_V_ALIAS_PSEUDOREG): Define.
 189         (rs6000_register_name): Return names for the "vX" aliases.
 190         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 191         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 192         aliases.  Call default_register_reggroup_p for all other
 193         pseudo-registers.
 194         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 195         New functions.
 196         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 197         Handle "vX" aliases.
 198         (v_alias_pseudo_register_collect): New function.
 199         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 200         (rs6000_gdbarch_init): Initialize "vX" aliases as
 201         pseudo-registers.  Restore registration of
 202         rs6000_pseudo_register_reggroup_p with
 203         set_tdesc_pseudo_register_reggroup_p.
 204
 205 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 206
 207         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 208         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 209         set_gdbarch_num_pseudo_regs.
 210
 211 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 212
 213         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 214         Remove arg prefixname, add do_set and do_show.
 215         Add member functions set_list and show_list.
 216         * cli/cli-style.c (class cli_style_option): Update accordingly.
 217         (style_set_list): Move to file scope.
 218         (style_show_list): Likewise.
 219         (set_style): Call help_list.
 220         (show_style): Call cmd_show_list.
 221         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 222         Update to use the new macro.
 223
 224 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 225
 226         * ada-lang.c (_initialize_ada_language): Expand the help text
 227         for the "catch exception" command.
 228
 229 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 230
 231         * symtab.c (matching_obj_sections): Initialize obj,
 232         declare it closer to its usage.
 233
 234 2019-01-10  Tom Tromey  <tom@tromey.com>
 235
 236         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 237         (basic_inf_threads_range): Remove.
 238         (inf_threads_range, inf_non_exited_threads_range)
 239         (safe_inf_threads_range): Use next_adapter.
 240
 241 2019-01-10  Keith Seitz  <keiths@redhat.com>
 242
 243         PR gdb/23712
 244         PR symtab/23010
 245         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 246         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 247
 248 2019-01-10  Keith Seitz  <keiths@redhat.com>
 249
 250         PR gdb/23712
 251         PR symtab/23010
 252         * dictionary.c (pending_to_vector): Remove.
 253         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 254         Remove _1 suffix, replacing functions of the same name.  Update
 255         all callers.
 256         (dict_create_hashed, dict_create_hashed_expandable)
 257         (dict_create_linear, dict_create_linear_expandable, dict_free)
 258         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 259         Make functions static.
 260
 261 2019-01-10  Keith Seitz  <keiths@redhat.com>
 262
 263         PR gdb/23712
 264         PR symtab/23010
 265         * dictionary.h (struct dictionary): Replace declaration with
 266         multidictionary.
 267         (dict_create_hashed, dict_create_hashed_expandable)
 268         (dict_create_linear, dict_create_linear_expandable)
 269         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 270         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 271         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 272         taking multidictionary argument.
 273         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 274         * block.h (struct block) <dict>: Change to multidictionary
 275         and rename `multidict'.
 276         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 277         symmisc.c: Update all dictionary references to multidictionary.
 278
 279 2019-01-10  Keith Seitz  <keiths@redhat.com>
 280
 281         PR gdb/23712
 282         PR symtab/23010
 283         * dictionary.c: Include unordered_map.
 284         (pending_to_vector): New function.
 285         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 286         Rewrite the non-"_1" functions to take vector instead
 287         of linked list.
 288         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 289         "new" _1 versions of the same name.
 290         (multidictionary): Define.
 291         (std::hash<enum language): New definition.
 292         (collate_pending_symbols_by_language, mdict_create_hashed)
 293         (mdict_create_hashed_expandable, mdict_create_linear)
 294         (mdict_create_linear_expandable, mdict_free)
 295         (find_language_dictionary, create_new_language_dictionary)
 296         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 297         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 298         (mdict_size, mdict_empty): New functions.
 299         * dictionary.h (mdict_iterator): Define.
 300
 301 2019-01-10  Pedro Alves  <palves@redhat.com>
 302
 303         * breakpoint.c (read_uploaded_action)
 304         (create_tracepoint_from_upload): Adjust to use
 305         gdb::unique_xmalloc_ptr.
 306         * ctf.c (ctf_write_uploaded_tp):
 307         (SET_ARRAY_FIELD): Use emplace_back.
 308         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 309         * tracefile-tfile.c (tfile_write_uploaded_tp):
 310         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 311         gdb::unique_xmalloc_ptr.
 312         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 313         at_string, cond_string, cmd_strings>: Replace char pointers
 314         with gdb::unique_xmalloc_ptr.
 315
 316 2019-01-10  Pedro Alves  <palves@redhat.com>
 317
 318         * solib-target.c (library_list_start_library): Don't xstrdup name.
 319
 320 2019-01-10  Pedro Alves  <palves@redhat.com>
 321
 322         * mdebugread.c (parse_partial_symbols): Use
 323         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 324
 325 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 326
 327         * linux-fork.c (scoped_switch_fork_info)
 328         <~scoped_switch_fork_info>: Fix incorrect variable name.
 329
 330 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * linux-fork.c (scoped_switch_fork_info)
 333         <scoped_switch_fork_info>: Make explicit.
 334         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 335
 336 2019-01-10  Tom Tromey  <tom@tromey.com>
 337
 338         * objfiles.h (objfile::reset_psymtabs): Update.
 339         * objfiles.c (objfile::objfile): Update.
 340         * psymtab.h (psymtab_storage::obstack): Update.
 341         (psymtab_storage::m_obstack): Use gdb::optional.
 342         (class psymtab_storage): Update comment.  Remove objfile
 343         parameter.
 344         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 345
 346 2019-01-10  Tom Tromey  <tom@tromey.com>
 347
 348         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 349         <free_psymtabs>: Now private.
 350         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 351         (allocate_psymtab): Use new method.
 352
 353 2019-01-10  Tom Tromey  <tom@tromey.com>
 354
 355         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 356         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 357         * mdebugread.c (parse_partial_symbols): Use
 358         allocate_dependencies.
 359         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 360         allocate_dependencies.
 361         (process_psymtab_comp_unit_reader)
 362         (build_type_psymtab_dependencies): Likewise.
 363         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 364
 365 2019-01-10  Tom Tromey  <tom@tromey.com>
 366
 367         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 368         PSYMBOL_SET_LANGUAGE.
 369         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 370
 371 2019-01-10  Tom Tromey  <tom@tromey.com>
 372
 373         * psymtab.h (psymtab_storage::obstack): New method.
 374         <m_obstack>: Rename from obstack; now private.
 375         * psymtab.c (psymtab_storage): Update.
 376         * dwarf2read.c (create_addrmap_from_index)
 377         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 378         Update.
 379
 380 2019-01-10  Tom Tromey  <tom@tromey.com>
 381
 382         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 383         * objfiles.h (objfile::reset_psymtabs): New method.
 384
 385 2019-01-10  Tom Tromey  <tom@tromey.com>
 386
 387         * symmisc.c (print_symbol_bcache_statistics): Update.
 388         (print_objfile_statistics): Update.
 389         * symfile.c (reread_symbols): Update.
 390         * psymtab.h (class psymtab_storage): New.
 391         * psymtab.c (psymtab_storage): New constructor.
 392         (~psymtab_storage): New destructor.
 393         (require_partial_symbols): Update.
 394         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 395         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 396         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 397         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 398         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 399         (start_psymtab_common, end_psymtab_common)
 400         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 401         (allocate_psymtab): Update.
 402         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 403         Update.
 404         (dump_psymtab_addrmap, maintenance_print_psymbols)
 405         (maintenance_check_psymtabs): Update.
 406         (class objfile_psymtabs): Move to objfiles.h.
 407         * psympriv.h (discard_psymtab): Now inline.
 408         (psymtab_discarder::psymtab_discarder): Update.
 409         (psymtab_discarder::~psymtab_discarder): Update.
 410         (ALL_OBJFILE_PSYMTABS): Rewrite.
 411         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 412         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 413         Remove fields.
 414         <partial_symtabs>: New field.
 415         (class objfile_psymtabs): Move from psymtab.h.  Update.
 416         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 417         psymbol_cache.
 418         (objfile::~objfile): Don't destroy psymbol_cache.
 419         * mdebugread.c (parse_partial_symbols): Update.
 420         * dwarf2read.c (create_addrmap_from_index)
 421         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 422         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 423         (add_partial_subprogram, dwarf2_ranges_read): Update.
 424         * dwarf-index-write.c (write_address_map)
 425         (write_one_signatured_type, recursively_write_psymbols)
 426         (class debug_names, class debug_names, write_psymtabs_to_index):
 427         Update.
 428
 429 2019-01-10  Tom Tromey  <tom@tromey.com>
 430
 431         * symtab.h (SYMBOL_SET_NAMES): Update.
 432         (symbol_set_names): Update.
 433         (MSYMBOL_SET_NAMES): Update.
 434         * symtab.c (symbol_set_names): Change argument to be an
 435         objfile_per_bfd_storage.
 436         * psymtab.c (add_psymbol_to_bcache): Update.
 437         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 438
 439 2019-01-10  Tom Tromey  <tom@tromey.com>
 440
 441         * symtab.c (create_demangled_names_hash): Change argument to be an
 442         objfile_per_bfd_storage.
 443         (symbol_set_names): Update.
 444
 445 2019-01-10  Tom Tromey  <tom@tromey.com>
 446
 447         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 448         init_psymbol_list.
 449         * psymtab.c (init_psymbol_list): Do nothing if already called.
 450         * psympriv.h (init_psymbol_list): Add comment.
 451         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 452         init_psymbol_list.
 453         * dbxread.c (dbx_symfile_read): Unconditionally call
 454         init_psymbol_list.
 455
 456 2019-01-10  Tom Tromey  <tom@tromey.com>
 457
 458         * xcoffread.c (scan_xcoff_symtab): Update.
 459         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 460         "where".
 461         * mdebugread.c (parse_partial_symbols)
 462         (handle_psymbol_enumerators): Update.
 463         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 464         * dbxread.c (read_dbx_symtab): Update.
 465         * psympriv.h (psymbol_placement): New enum.
 466         (add_psymbol_to_list): Update.
 467
 468 2019-01-10  Tom Tromey  <tom@tromey.com>
 469
 470         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 471         static_psymbols parameters.
 472         (scan_xcoff_symtab): Update.
 473         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 474         static_psymbols parameters.
 475         * psympriv.h (start_psymtab_common): Update.
 476         * mdebugread.c (parse_partial_symbols): Update.
 477         * dwarf2read.c (create_partial_symtab): Update.
 478         * dbxread.c (read_dbx_symtab): Update.
 479         (start_psymtab): Remove global_psymbols and static_psymbols
 480         parameters.
 481
 482 2019-01-10  Tom Tromey  <tom@tromey.com>
 483
 484         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 485         * psymtab.c (allocate_psymtab): Add comment.
 486         * psympriv.h (allocate_psymtab): Add comment.
 487         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 488         initializations.
 489         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 490
 491 2019-01-10  Tom Tromey  <tom@tromey.com>
 492
 493         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 494         Don't declare.
 495         * mipsread.c: Include mdebugread.h.
 496         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 497         Declare.
 498         * elfread.c: Include mdebugread.h.
 499
 500 2019-01-09  Tom Tromey  <tom@tromey.com>
 501
 502         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 503         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 504         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 505         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 506         (psym_lookup_symbol, psym_find_last_source_symtab)
 507         (psym_forget_cached_source_info, psym_print_stats)
 508         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 509         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 510         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 511         (psym_find_compunit_symtab_by_address)
 512         (maintenance_print_psymbols, maintenance_info_psymtabs)
 513         (maintenance_check_psymtabs): Use ranged for.
 514         * psymtab.h (class objfile_psymtabs): New.
 515         (require_partial_symbols): Return objfile_psymtabs.
 516         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 517
 518 2019-01-09  Tom Tromey  <tom@tromey.com>
 519
 520         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 521         (find_pc_mapped_section, list_overlays_command)
 522         (map_overlay_command, unmap_overlay_command)
 523         (simple_overlay_update): Use all_objfiles.
 524         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 525         * printcmd.c (info_symbol_command): Use all_objfiles.
 526         * objfiles.h (ALL_OBJSECTIONS): Remove.
 527         * maint.c (maintenance_translate_address): Use all_objfiles.
 528         * gcore.c (gcore_create_callback): Use all_objfiles.
 529         (objfile_find_memory_regions): Likewise.
 530
 531 2019-01-09  Tom Tromey  <tom@tromey.com>
 532
 533         * symtab.c (find_line_symtab, info_sources_command)
 534         (make_source_files_completion_list): Use objfile_compunits.
 535         * source.c (select_source_symtab): Use objfile_compunits.
 536         * objfiles.h (struct objfile): Update comment.
 537         (ALL_OBJFILES): Remove.
 538         (ALL_FILETABS): Remove.
 539         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 540         objfile_compunits.
 541
 542 2019-01-09  Tom Tromey  <tom@tromey.com>
 543
 544         * symmisc.c (print_objfile_statistics, dump_objfile)
 545         (maintenance_print_symbols): Use compunit_filetabs.
 546         * source.c (forget_cached_source_info_for_objfile): Use
 547         compunit_filetabs.
 548         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 549         (ALL_FILETABS): Use compunit_filetabs.
 550         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 551         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 552
 553 2019-01-09  Tom Tromey  <tom@tromey.com>
 554
 555         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 556         (compunit_filetabs): New.
 557         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 558         compunit_filetabs.
 559         (info_sources_command, make_source_files_completion_list): Remove
 560         declaration.
 561         * symmisc.c (print_objfile_statistics, dump_objfile)
 562         (maintenance_print_symbols): Remove declaration.
 563         (maintenance_info_symtabs): Use compunit_filetabs.
 564         (maintenance_info_line_tables): Likewise.
 565         * source.c (select_source_symtab): Change local variable name.
 566         (forget_cached_source_info_for_objfile): Remove declaration.
 567         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 568         * objfiles.c (objfile_relocate1): Remove declaration.
 569         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 570         declaration.
 571         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 572         * coffread.c (coff_symtab_read): Remove declaration.
 573         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 574         compunit_filetabs.
 575
 576 2019-01-09  Tom Tromey  <tom@tromey.com>
 577
 578         * symtab.c (lookup_objfile_from_block)
 579         (find_pc_sect_compunit_symtab, search_symbols)
 580         (default_collect_symbol_completion_matches_break_on): Use
 581         objfile_compunits.
 582         * objfiles.h (ALL_COMPUNITS): Remove.
 583         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 584         * cp-support.c (add_symbol_overload_list_qualified): Use
 585         objfile_compunits.
 586         * ada-lang.c (ada_collect_symbol_completion_matches)
 587         (ada_add_global_exceptions): Use objfile_compunits.
 588
 589 2019-01-09  Tom Tromey  <tom@tromey.com>
 590
 591         * source.c (select_source_symtab)
 592         (forget_cached_source_info_for_objfile): Remove declaration.
 593         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 594         declaration.
 595         * maint.c (count_symtabs_and_blocks): Remove declaration.
 596         * cp-support.c (add_symbol_overload_list_qualified): Remove
 597         declaration.
 598         * coffread.c (coff_symtab_read): Remove declaration.
 599         * symtab.c (lookup_symbol_in_objfile_symtabs)
 600         (basic_lookup_transparent_type_1): Use objfile_compunits.
 601         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 602         (info_sources_command, search_symbols)
 603         (default_collect_symbol_completion_matches_break_on)
 604         (make_source_files_completion_list): Remove declaration.
 605         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 606         (ada_collect_symbol_completion_matches)
 607         (ada_add_global_exceptions): Remove declaration.
 608         * linespec.c (iterate_over_all_matching_symtabs): Use
 609         objfile_compunits.
 610         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 611         (class objfile_compunits): New.
 612         (ALL_COMPUNITS): Use objfile_compunits.
 613         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 614         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 615         objfile_compunits.
 616         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 617
 618 2019-01-09  Tom Tromey  <tom@tromey.com>
 619
 620         * symtab.c (search_symbols)
 621         (default_collect_symbol_completion_matches_break_on): Use
 622         objfile_msymbols.
 623         * ada-lang.c (ada_lookup_simple_minsym)
 624         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 625         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 626         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 627         objfile_msymbols.
 628         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 629         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 630         * objc-lang.c (find_methods): Use objfile_msymbols.
 631         (info_selectors_command, info_classes_command): Likewise.
 632         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 633         * objfiles.h (class objfile_msymbols): New.
 634         (ALL_OBJFILE_MSYMBOLS): Remove.
 635         (ALL_MSYMBOLS): Remove.
 636
 637 2019-01-09  Tom Tromey  <tom@tromey.com>
 638
 639         * common/next-iterator.h (next_adapter): Add Iterator template
 640         parameter.
 641         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 642         (class all_objfiles_safe): New.
 643         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 644         * objfiles.c (put_objfile_before): Update comment.
 645         (add_separate_debug_objfile): Likewise.
 646         (free_all_objfiles): Use all_objfiles_safe.
 647         (objfile_purge_solibs): Likewise.
 648
 649 2019-01-09  Tom Tromey  <tom@tromey.com>
 650
 651         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 652         (expand_symtab_containing_pc, lookup_static_symbol)
 653         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 654         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 655         all_objfiles.
 656         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 657         * breakpoint.c (create_overlay_event_breakpoint)
 658         (create_longjmp_master_breakpoint)
 659         (create_std_terminate_master_breakpoint)
 660         (create_exception_master_breakpoint): Use all_objfiles.
 661         * linux-thread-db.c (try_thread_db_load_from_pdir)
 662         (has_libpthread): Use all_objfiles.
 663         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 664         * linespec.c (iterate_over_all_matching_symtabs)
 665         (search_minsyms_for_name): Use all_objfiles.
 666         * maint.c (maintenance_info_sections): Use all_objfiles.
 667         * main.c (captured_main_1): Use all_objfiles.
 668         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 669         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 670         * guile/scm-pretty-print.c
 671         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 672         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 673         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 674         (maintenance_print_msymbols): Use all_objfiles.
 675         * source.c (select_source_symtab): Use all_objfiles.
 676         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 677         * symfile.c (remove_symbol_file_command)
 678         (expand_symtabs_matching, map_symbol_filenames): Use
 679         all_objfiles.
 680         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 681         all_objfiles.
 682         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 683         * objc-lang.c (find_methods): Use all_objfiles.
 684         * objfiles.c (have_partial_symbols, have_full_symbols)
 685         (have_minimal_symbols, qsort_cmp)
 686         (default_iterate_over_objfiles_in_search_order): Use
 687         all_objfiles.
 688         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 689         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 690         (maintenance_check_psymtabs): Use all_objfiles.
 691         (ALL_PSYMTABS): Remove.
 692         * compile/compile-object-run.c (do_module_cleanup): Use
 693         all_objfiles.
 694         * blockframe.c (find_pc_partial_function): Use all_objfiles.
 695         * cp-support.c (add_symbol_overload_list_qualified): Use
 696         all_objfiles.
 697         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 698         Use all_objfiles.
 699         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
 700         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
 701         all_objfiles.
 702         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 703         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
 704         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 705         Uses all_objfiles.
 706         * solib.c (solib_read_symbols): Use all_objfiles
 707
 708 2019-01-09  Tom Tromey  <tom@tromey.com>
 709
 710         * probe.c (parse_probes_in_pspace): Use all_objfiles.
 711         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
 712         all_objfiles.
 713         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
 714         * symmisc.c (print_symbol_bcache_statistics)
 715         (print_objfile_statistics, maintenance_print_objfiles)
 716         (maintenance_info_symtabs, maintenance_check_symtabs)
 717         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
 718         all_objfiles.
 719         * source.c (forget_cached_source_info): Use all_objfiles.
 720         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
 721         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 722         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
 723         * objfiles.c (update_section_map): Use all_objfiles.
 724         (shared_objfile_contains_address_p): Likewise.
 725         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
 726         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
 727
 728 2019-01-09  Tom Tromey  <tom@tromey.com>
 729
 730         * common/next-iterator.h: New file.
 731         * objfiles.h (class all_objfiles): New.
 732         (struct objfile_iterator): New.
 733
 734 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 735
 736         * NEWS: Move the description of the changed "frame", "select-frame",
 737          and "info frame" commands to the Changed commands section.
 738
 739 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
 740
 741         * gdbtypes.c (check_stub_method_group): Remove handling of old
 742         mangling schemes.
 743         * linespec.c (find_methods): Likewise.
 744         * stabsread.c (read_member_functions): Likewise.
 745         * valops.c (search_struct_method): Likewise.
 746         (value_struct_elt_for_reference): Likewise.
 747         * NEWS: Mention this change.
 748
 749 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 750
 751         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
 752         print_source_lines.
 753         * source.c (print_source_lines_base): Update line number check.
 754         (print_source_lines): New function.
 755         (source_lines_range::source_lines_range): New function.
 756         * source.h (class source_lines_range): New class.
 757         (print_source_lines): New declaration.
 758
 759 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 760
 761         * linespec.c (linespec_state_destructor): Free self->canonical_names.
 762
 763 2019-01-08  Tom Tromey  <tom@tromey.com>
 764             Simon Marchi  <simon.marchi@ericsson.com>
 765
 766         PR gdb/24060
 767         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
 768         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
 769         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 770         * f-exp.y (DOLLAR_VARIABLE): Likewise.
 771         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
 772         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
 773
 774 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 775
 776         * source.c (select_source_symtab): Move header comment to
 777         declaration in source.h.
 778         (forget_cached_source_info_for_objfile): Likewise.
 779         (forget_cached_source_info): Likewise.
 780         (identify_source_line): Likewise.
 781         * source.h (identify_source_line): Move declaration from symtab.h
 782         and add comment from source.c
 783         (print_source_lines): Likewise.
 784         (forget_cached_source_info_for_objfile): Likewise.
 785         (forget_cached_source_info): Likewise.
 786         (select_source_symtab): Likewise.
 787         (enum print_source_lines_flag): Move definition from symtab.h.
 788         * symtab.h (identify_source_line): Move declaration to source.h.
 789         (print_source_lines): Likewise.
 790         (forget_cached_source_info_for_objfile): Likewise.
 791         (forget_cached_source_info): Likewise.
 792         (select_source_symtab): Likewise.
 793         (enum print_source_lines_flag): Move definition to source.h.
 794         * tui/tui-hooks.c: Add 'source.h' include.
 795
 796 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 797
 798         * source.c (print_source_lines_base): Handle requests to print
 799         reverse line number sequences, and guard against empty lines
 800         string.
 801
 802 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 803
 804         * source.c (print_source_lines_base): Fix skip of '\r' if next
 805         character is '\n'.
 806
 807 2019-01-06  Tom Tromey  <tom@tromey.com>
 808
 809         * c-exp.y (struct c_parse_state) <macro_original_text,
 810         expansion_obstack>: New member.
 811         (macro_original_text, expansion_obstack): Remove globals.
 812         (scan_macro_expansion, scanning_macro_expansion)
 813         (finished_macro_expansion): Update.
 814         (scan_macro_cleanup): Remove.
 815         (yylex, c_parse): Update.
 816
 817 2019-01-06  Tom Tromey  <tom@tromey.com>
 818
 819         * c-exp.y (struct c_parse_state) <strings>: New member.
 820         (operator_stoken): Update.
 821
 822 2019-01-06  Tom Tromey  <tom@tromey.com>
 823
 824         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
 825         (union type_stack_elt) <typelist_val>: Now a pointer to
 826         std::vector.
 827         (type_stack_cleanup): Don't declare.
 828         (push_typelist): Update.
 829         * parse.c (pop_typelist): Return a std::vector.
 830         (push_typelist): Take a std::vector.
 831         (follow_types): Update.  Do not free args.
 832         (type_stack_cleanup): Remove.
 833         * c-exp.y (struct c_parse_state): New.
 834         (cpstate): New global.
 835         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
 836         (nonempty_typelist): Update.
 837         (func_mod): Create a new vector.
 838         (c_parse): Create a c_parse_state.
 839         (check_parameter_typelist): Do not delete params.
 840         (function_method): Update.  Do not delete type_list.
 841
 842 2019-01-06  Tom Tromey  <tom@tromey.com>
 843
 844         PR gdb/28155:
 845         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
 846         check_typedef.
 847         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
 848         (print_return_value): Likewise.
 849
 850 2019-01-05  Tom Tromey  <tom@tromey.com>
 851
 852         * contrib/cleanup_check.py: Remove.
 853         * contrib/gcc-with-excheck: Remove.
 854         * contrib/exsummary.py: Remove.
 855         * contrib/excheck.py: Remove.
 856
 857 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
 858
 859         * thread.c (delete_thread_1): Add gdb_assert that THR is not
 860         NULL. Initialize tpprev to NULL instead of assigning it
 861         to NULL on the next statement.
 862         * windows-nat.c (windows_delete_thread): Remove check for
 863         main_thread_id before printing thread exit notifications.
 864         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
 865         Remove thread ID check against main_thread_id.
 866         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
 867         windows_delete_thread.
 868         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
 869
 870 2019-01-04  Tom Tromey  <tom@tromey.com>
 871
 872         * compile/compile.c (_initialize_compile): Use upper case for
 873         metasyntactic variables.
 874         * symmisc.c (_initialize_symmisc): Use upper case for
 875         metasyntactic variables.
 876         * psymtab.c (_initialize_psymtab): Use upper case for
 877         metasyntactic variables.
 878         * demangle.c (demangle_command): Use upper case for metasyntactic
 879         variables.
 880         (_initialize_demangler): Likewise.
 881         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
 882         variables.
 883
 884 2019-01-03  Tom Tromey  <tom@tromey.com>
 885
 886         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
 887
 888 2019-01-03  Tom Tromey  <tom@tromey.com>
 889
 890         * python/py-symtab.c (salpy_str): Update.
 891         (struct salpy_sal_object) <symtab>: Now a PyObject.
 892         (salpy_dealloc): Update.
 893         (del_objfile_sal): Use gdbpy_ref.
 894
 895 2019-01-03  Tom Tromey  <tom@tromey.com>
 896
 897         * python/py-type.c (convert_field): Use new_reference.  Return
 898         gdbpy_ref.
 899         (make_fielditem): Return gdbpy_ref.
 900         (typy_fields): Update.
 901         (typy_getitem): Update.
 902         (field_name): Return gdbpy_ref.  Use new_reference.
 903         (typy_iterator_iternext): Update.
 904
 905 2019-01-03  Tom Tromey  <tom@tromey.com>
 906
 907         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
 908
 909 2019-01-03  Tom Tromey  <tom@tromey.com>
 910
 911         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
 912         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
 913         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
 914         (pspy_set_frame_filters, pspy_set_frame_unwinders)
 915         (pspy_set_type_printers): Likewise.
 916         * python/py-function.c (fnpy_init): Use gdbpy_ref.
 917         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
 918         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
 919         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
 920         (objfpy_set_type_printers): Likewise.
 921
 922 2019-01-03  Tom Tromey  <tom@tromey.com>
 923
 924         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
 925         (gdbpy_print_stack): Use gdbpy_err_fetch.
 926         * python/python-internal.h (class gdbpy_err_fetch): New class.
 927         (class gdbpy_enter) <m_error_type, m_error_value,
 928         m_error_traceback>: Remove.
 929         <m_error>: New member.
 930         (gdbpy_exception_to_string): Don't declare.
 931         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
 932         * python/py-value.c (convert_value_from_python): Use
 933         gdbpy_err_fetch.
 934         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
 935         gdbpy_exception_to_string.
 936         (gdbpy_handle_exception): Use gdbpy_err_fetch.
 937         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 938         gdbpy_err_fetch.
 939
 940 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 941
 942         * linux-nat.c (delete_lwp_cleanup): Delete.
 943         (struct lwp_deleter): New struct.
 944         (lwp_info_up): New typedef.
 945         (linux_nat_target::follow_fork): Delete cleanup, and make use of
 946         lwp_info_up.
 947
 948 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 949
 950         * linux-fork.c (class scoped_switch_fork_info): New class.
 951         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
 952
 953 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 954
 955         * valops.c (find_overload_match): Remove use of null_cleanup, and
 956         calls to do_cleanups.
 957
 958 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 959
 960         * compile/compile-cplus-types.c
 961         (compile_cplus_instance::decl_name): Handle changes to
 962         cp_func_name.
 963         * cp-support.c (cp_func_name): Update header comment, update
 964         return type.
 965         * cp-support.h (cp_func_name): Update return type in declaration.
 966         * valops.c (find_overload_match): Move temp_func local to top
 967         level of function and change its type.  Use temp_func to hold and
 968         delete temporary string obtained from cp_func_name.
 969
 970 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 971
 972         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
 973         gdb::char_vector, remove cleanup, and update uses of `msg`.
 974
 975 2019-01-03  Jim Wilson  <jimw@sifive.com>
 976
 977         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
 978
 979 2019-01-02  Tom Tromey  <tom@tromey.com>
 980
 981         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
 982         (tdesc_parse_xml): Remove cleanups.
 983         * target-descriptions.h (make_cleanup_free_target_description):
 984         Don't declare.
 985         (target_desc_deleter): New struct.
 986         (target_desc_up): New typedef.
 987         * target-descriptions.c (target_desc_deleter::operator()): Rename
 988         from free_target_description.
 989         (make_cleanup_free_target_description): Remove.
 990
 991 2019-01-02  Tom Tromey  <tom@tromey.com>
 992
 993         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
 994         constructor, destructor.
 995         (linespec_parser): Remove typedef.
 996         (~linespec_parser): Rename from linespec_parser_delete.
 997         (linespec_lex_to_end, linespec_complete_label)
 998         (linespec_complete): Update.
 999         (decode_line_full): Remove cleanups.
1000         (decode_line_1): Update.
1001
1002 2019-01-02  Tom Tromey  <tom@tromey.com>
1003
1004         * python/python-internal.h (inferior_to_inferior_object): Change
1005         return type.
1006         * python/py-exitedevent.c (create_exited_event_object): Update.
1007         * python/py-inferior.c (inferior_to_inferior_object): Return
1008         gdbpy_ref.
1009         (python_new_inferior, python_inferior_deleted)
1010         (thread_to_thread_object, delete_thread_object)
1011         (build_inferior_list, gdbpy_selected_inferior): Update.
1012         * python/py-infthread.c (create_thread_object): Update.  Also fail
1013         if inferior_to_inferior_object fails.
1014
1015 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1016
1017         * inferior.h (class inferior) <displaced_step_state>: New field.
1018         * infrun.h (struct displaced_step_state): Move here from
1019         infrun.c.  Initialize fields, add constructor.
1020         <inf>: Remove field.
1021         <reset>: New method.
1022         * infrun.c (struct displaced_step_inferior_state): Move to
1023         infrun.h.
1024         (displaced_step_inferior_states): Remove.
1025         (get_displaced_stepping_state): Adust.
1026         (displaced_step_in_progress_any_inferior): Adjust.
1027         (displaced_step_in_progress_thread): Adjust.
1028         (displaced_step_in_progress): Adjust.
1029         (add_displaced_stepping_state): Remove.
1030         (get_displaced_step_closure_by_addr): Adjust.
1031         (remove_displaced_stepping_state): Remove.
1032         (infrun_inferior_exit): Call displaced_step_state.reset.
1033         (use_displaced_stepping): Don't check for NULL.
1034         (displaced_step_prepare_throw): Call
1035         get_displaced_stepping_state.
1036         (displaced_step_fixup): Don't check for NULL.
1037         (prepare_for_detach): Don't check for NULL.
1038
1039 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1040
1041         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1042          in case of call that did not complete.
1043
1044 2019-01-02  Andrey Utkin  <autkin@undo.io>
1045
1046         * symfile.c (find_separate_debug_file): Fix search of debug files for
1047         remote debuggee.
1048
1049 2019-01-02  Tom Tromey  <tom@tromey.com>
1050
1051         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1052         indentation.
1053         * python/py-frame.c (frapy_older): Remove cast.
1054         (frapy_newer): Likewise.
1055         * python/py-breakpoint.c (local_setattro): Remove cast.
1056         * python/py-arch.c (archpy_name): Remove local variable.
1057         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1058
1059 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1060
1061         * unittests/basic_string_view/element_access/char/empty.cc:
1062         Fix year range in copyright header.
1063
1064 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1065
1066         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1067         Delete.
1068         <operator==>: Update with for removed field.
1069         <hash>: Likewise.
1070         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1071         <isa_features>: ...this.
1072         <abi_features>: New field.
1073         (riscv_isa_flen): Update comment.
1074         (riscv_abi_xlen): New declaration.
1075         (riscv_abi_flen): New declaration.
1076         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1077         isa_features.
1078         (riscv_abi_xlen): New function.
1079         (riscv_isa_flen): Update to get answer from isa_features.
1080         (riscv_abi_flen): New function.
1081         (riscv_has_fp_abi): Update to get answer from abi_features.
1082         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1083         xlen and flen.
1084         (riscv_call_info) <xlen, flen>: Update comment.
1085         (riscv_call_arg_struct): Remove invalid assertions
1086         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1087         is removed.
1088         (riscv_gdbarch_init): Gather isa features and abi features
1089         separately, ensure both match on the gdbarch when reusing an old
1090         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1091         a target with 64-bit float hardware.
1092
1093 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1094
1095         * source.c (search_command_helper): Stop reverse search
1096         when line 1 has been searched.
1097
1098 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1099
1100         * record-full.c (record_full_base_target::close): Rewrite
1101         record_full_core_buf_list free logic.
1102
1103 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1104
1105         * break-catch-syscall.c (print_one_catch_syscall): xfree
1106         the last text.
1107
1108 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1109
1110         * top.c (print_gdb_version): Update Copyright year in version
1111         message.
1112
1113 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1114
1115         Update copyright year range in all GDB files.
1116
1117 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1118
1119         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1120
1121 For older changes see ChangeLog-2018.
1122 \f
1123 Local Variables:
1124 mode: change-log
1125 left-margin: 8
1126 fill-column: 74
1127 version-control: never
1128 coding: utf-8
1129 End:
1130