gdb/ChangeLog

   1 2019-10-26  Tom de Vries  <tdevries@suse.de>
   2
   3         * aarch64-linux-tdep.c: Fix typos in comments.
   4         * aarch64-tdep.c: Same.
   5         * ada-lang.c: Same.
   6         * amd64-nat.c: Same.
   7         * arc-tdep.c: Same.
   8         * arch/aarch64-insn.c: Same.
   9         * block.c: Same.
  10         * breakpoint.h: Same.
  11         * btrace.h: Same.
  12         * c-varobj.c: Same.
  13         * cli/cli-decode.c: Same.
  14         * cli/cli-script.c: Same.
  15         * cli/cli-utils.h: Same.
  16         * coff-pe-read.c: Same.
  17         * coffread.c: Same.
  18         * compile/compile-cplus-symbols.c: Same.
  19         * compile/compile-object-run.c: Same.
  20         * completer.c: Same.
  21         * corelow.c: Same.
  22         * cp-support.c: Same.
  23         * demangle.c: Same.
  24         * dwarf-index-write.c: Same.
  25         * dwarf2-frame.c: Same.
  26         * dwarf2-frame.h: Same.
  27         * eval.c: Same.
  28         * frame-base.h: Same.
  29         * frame.h: Same.
  30         * gdbcmd.h: Same.
  31         * gdbtypes.h: Same.
  32         * gnu-nat.c: Same.
  33         * guile/scm-objfile.c: Same.
  34         * i386-tdep.c: Same.
  35         * i386-tdep.h: Same.
  36         * infcall.c: Same.
  37         * infcall.h: Same.
  38         * linux-nat.c: Same.
  39         * m68k-tdep.c: Same.
  40         * macroexp.c: Same.
  41         * memattr.c: Same.
  42         * mi/mi-cmd-disas.c: Same.
  43         * mi/mi-getopt.h: Same.
  44         * mi/mi-main.c: Same.
  45         * minsyms.c: Same.
  46         * nat/aarch64-sve-linux-sigcontext.h: Same.
  47         * objfiles.h: Same.
  48         * ppc-linux-nat.c: Same.
  49         * ppc-linux-tdep.c: Same.
  50         * ppc-tdep.h: Same.
  51         * progspace.h: Same.
  52         * prologue-value.h: Same.
  53         * python/py-evtregistry.c: Same.
  54         * python/py-instruction.h: Same.
  55         * record-btrace.c: Same.
  56         * record-full.c: Same.
  57         * remote.c: Same.
  58         * rs6000-tdep.c: Same.
  59         * ser-tcp.c: Same.
  60         * sol-thread.c: Same.
  61         * sparc-sol2-tdep.c: Same.
  62         * sparc64-tdep.c: Same.
  63         * stabsread.c: Same.
  64         * symfile.c: Same.
  65         * symtab.h: Same.
  66         * target.c: Same.
  67         * tracepoint.c: Same.
  68         * tui/tui-data.h: Same.
  69         * tui/tui-io.c: Same.
  70         * tui/tui-win.c: Same.
  71         * tui/tui.c: Same.
  72         * unittests/rsp-low-selftests.c: Same.
  73         * user-regs.h: Same.
  74         * utils.c: Same.
  75         * utils.h: Same.
  76         * valarith.c: Same.
  77         * valops.c: Same.
  78         * valprint.c: Same.
  79         * valprint.h: Same.
  80         * value.c: Same.
  81         * value.h: Same.
  82         * varobj.c: Same.
  83         * x86-nat.h: Same.
  84         * xtensa-tdep.c: Same.
  85
  86 2019-10-25  Ali Tamur <tamur@google.com>
  87
  88         * charset.c (find_charset_names): Reflect API change.
  89
  90 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
  91
  92         * symtab.c (struct demangled_name_entry): Change demangled name
  93         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
  94         part of the struct anymore.
  95         (symbol_set_names): No longer obstack allocate + copy the demangled
  96         name, just store the allocated name from bfd.
  97
  98 2019-10-25  Tom Tromey  <tromey@adacore.com>
  99
 100         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
 101         (bsearch_cie_cmp, add_cie): Remove.
 102         (find_cie): Reimplement.
 103         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
 104         (dwarf2_build_frame_info): Update.
 105
 106 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
 107
 108         PR gdb/25126
 109         * symfile.c (reread_symbols): Call forget_cached_source_info to
 110         clear the stale source cache.
 111
 112 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 113
 114         * configure: Regenerate.
 115         * configure.ac: Remove code that sets python_has_threads.
 116
 117 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
 118
 119         * config.in: Regenerate.
 120         * configure: Regenerate.
 121         * configure.ac: Remove the code that uses sed to get the python
 122         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
 123
 124 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
 125
 126         * python/py-progspace.c (pspy_block_for_pc): Return None for all
 127         error paths.
 128
 129 2019-10-23  Tom Tromey  <tom@tromey.com>
 130
 131         * arc-tdep.c: Remove ".." from include.
 132         * frv-tdep.c: Remove ".." from include.
 133         * lm32-tdep.c: Remove ".." from include.
 134         * microblaze-tdep.c: Remove ".." from include.
 135         * or1k-tdep.h: Remove ".." from include.
 136         * s12z-tdep.c: Remove ".." from include.
 137         * Makefile.in (OPCODES_CFLAGS): Add comment.
 138         (TOP_CFLAGS): New variable.
 139         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
 140
 141 2019-10-23  Tom Tromey  <tom@tromey.com>
 142
 143         * Makefile.in (READLINE_DIR): Update.
 144
 145 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 146
 147         * infcall.c (call_function_by_hand_dummy): Fix the function
 148         comment.  And extract out a code section into...
 149         (reserve_stack_space): ...this new function.
 150
 151 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 152
 153         * infcall.c (value_arg_coerce): Remove an unused parameter.
 154         (call_function_by_hand_dummy): Update the call to
 155         'value_arg_coerce'.
 156
 157 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 158
 159         * infcall.c (call_function_by_hand_dummy): Refactor.
 160
 161 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 162
 163         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
 164
 165 2019-10-23  Tom Tromey  <tom@tromey.com>
 166
 167         * configure: Rebuild.
 168         * configure.ac: Don't check for sigprocmask.
 169         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
 170
 171 2019-10-23  Tom Tromey  <tom@tromey.com>
 172
 173         * configure: Rebuild.
 174         * acinclude.m4: Use m4_include, not sinclude.
 175
 176 2019-10-23  Tom de Vries  <tdevries@suse.de>
 177
 178         PR breakpoints/24687
 179         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
 180
 181 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 182
 183         * symtab.c (struct demangled_name_entry) <language>: Change from
 184         bitfield to regular variable.
 185
 186 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 187
 188         * symtab.c (struct demangled_name_entry): Add a constructor.
 189         (free_demangled_name_entry): New function to call the destructor
 190         for demangled_name_entry.
 191         (create_demangled_names_hash): Pass free_demangled_name_entry to
 192         htab_create_alloc.
 193         (symbol_set_names): Call placement new for demangled_name_entry.
 194         * utils.c: No longer include xxhash.h here, now that fast_hash
 195         is inlined in the header.
 196         * utils.h: Instead, include it here.
 197
 198 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 199
 200         * Makefile.in: Link with libxxhash.
 201         * config.in: Regenerate.
 202         * configure: Regenerate.
 203         * configure.ac: Search for libxxhash.
 204         * utils.c (fast_hash): Use xxhash if present.
 205
 206 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 207
 208         * utils.h (fast_hash): New function.
 209         * symtab.c (hash_demangled_name_entry): Call new function
 210         fast_hash.
 211
 212 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
 213
 214         * symtab.c (struct demangled_name_entry): Change type of mangled
 215         to gdb::string_view. Also adds a constructor that takes the
 216         mangled name.
 217         (hash_demangled_name_entry): Update.
 218         (eq_demangled_name_entry): Update.
 219         (free_demangled_name_entry): New function to call the destructor
 220         now that this is not a POD anymore.
 221         (create_demangled_names_hash): Pass free_demangled_name_entry to
 222         htab_create_alloc.
 223         (symbol_set_names): Update.
 224
 225 2019-10-21  Ali Tamur  <tamu@google.com>
 226
 227         * dwarf2read.c (dir_index): Change type.
 228         (file_name_index): Likewise.
 229         (line_header::include_dir_at): Change comment and implementation on
 230         whether it is DWARF 5.
 231         (line_header::is_valid_file_index): New function.
 232         (line_header::file_name_at): Change comment and implementation on
 233         whether it is DWARF 5.
 234         (line_header::file_names): Change to private field renamed as
 235         m_file_names and introduce a new accessor method.
 236         (line_header::file_names_size): New method.
 237         (line_header::include_dirs): Change to private field and rename as
 238         m_include_dirs.
 239         (dw2_get_file_names_reader): Define local var at a smaller scope and
 240         reflect API change.
 241         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
 242         (process_structure_scope): Likewise.
 243         (line_header::add_include_dir): Change message and reflect renaming.
 244         (line_header::add_file_name): Likewise.
 245         (read_formatted_entries): Handle DW_FORM_data16.
 246         (dwarf_decode_line_header): Fix line header length calculation.
 247         (psymtab_include_file_name): Change comment and API.
 248         (lnp_state_machine::m_file): Update comment and reflect type change.
 249         (lnp_state_machine::record_line): Reflect type change.
 250         (dwarf_decode_lines): Reflect API change.
 251         (file_file_name): Likewise.
 252         (file_full_name): Likewise.
 253
 254 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 255
 256         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
 257
 258 2019-10-21  Tom Tromey  <tom@tromey.com>
 259
 260         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
 261
 262 2019-10-21  Tom Tromey  <tom@tromey.com>
 263
 264         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
 265         NM_H.   Use AC_CONFIG_LINKS.
 266         * configure: Rebuild.
 267         * Makefile.in (NM_H): New variable.
 268         (generated_files): Add NM_H.  Remove gcore.
 269         (nm.h, stamp-nmh): New targets.
 270
 271 2019-10-20  Tom Tromey  <tom@tromey.com>
 272
 273         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
 274         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
 275         obsolete comment.
 276         (put_objfile_before): Now static.
 277
 278 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
 279
 280         * gdbsupport/common-utils.h (startswith): Change return type to
 281         bool.
 282
 283 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
 284
 285         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
 286         * breakpoint.c (bp_locations_compare): Rename to...
 287         (bp_location_is_less_than): ...this, and change to std::sort semantics.
 288         (update_global_location_list): Use std::sort instead of qsort.
 289         * buildsym.c (compare_line_numbers): Rename to...
 290         (lte_is_less_than): ...this, and change to std::sort semantics.
 291         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
 292         instead of qsort.
 293         * disasm.c (compare_lines): Rename to...
 294         (line_is_less_than): ...this, and change to std::sort semantics.
 295         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
 296         of qsort.
 297         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
 298         (fde_is_less_than): ...this, and change to std::sort semantics.
 299         (dwarf2_build_frame_info): Call std::sort instead of qsort.
 300         * mdebugread.c (compare_blocks):
 301         (block_is_less_than): ...this, and change to std::sort semantics.
 302         (sort_blocks): Call std::sort instead of qsort.
 303         * objfiles.c (qsort_cmp): Rename to...
 304         (sort_cmp): ...this, and change to std::sort semantics.
 305         (update_section_map): Call std::sort instead of qsort.
 306         * remote.c (compare_pnums): Remove.
 307         (map_regcache_remote_table): Call std::sort instead of qsort.
 308         * utils.c (compare_positive_ints): Remove.
 309         * utils.h (compare_positive_ints): Remove.
 310         * xcoffread.c (compare_lte): Remove.
 311         (arrange_linetable): Call std::sort instead of qsort.
 312
 313 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
 314
 315         * symfile.c (init_entry_point_info): Fix typo.
 316         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
 317
 318 2019-10-18  Tom de Vries  <tdevries@suse.de>
 319
 320         * aarch64-tdep.c: Fix typos in comments.
 321         * ada-lang.c: Same.
 322         * ada-tasks.c: Same.
 323         * alpha-tdep.c: Same.
 324         * alpha-tdep.h: Same.
 325         * amd64-nat.c: Same.
 326         * amd64-windows-tdep.c: Same.
 327         * arc-tdep.c: Same.
 328         * arc-tdep.h: Same.
 329         * arch-utils.c: Same.
 330         * arm-nbsd-tdep.c: Same.
 331         * arm-tdep.c: Same.
 332         * ax-gdb.c: Same.
 333         * blockframe.c: Same.
 334         * btrace.c: Same.
 335         * c-varobj.c: Same.
 336         * coff-pe-read.c: Same.
 337         * coffread.c: Same.
 338         * cris-tdep.c: Same.
 339         * darwin-nat.c: Same.
 340         * dbxread.c: Same.
 341         * dcache.c: Same.
 342         * disasm.c: Same.
 343         * dtrace-probe.c: Same.
 344         * dwarf-index-write.c: Same.
 345         * dwarf2-frame-tailcall.c: Same.
 346         * dwarf2-frame.c: Same.
 347         * dwarf2read.c: Same.
 348         * eval.c: Same.
 349         * exceptions.c: Same.
 350         * fbsd-tdep.c: Same.
 351         * findvar.c: Same.
 352         * frame.c: Same.
 353         * frv-tdep.c: Same.
 354         * gnu-v3-abi.c: Same.
 355         * go32-nat.c: Same.
 356         * h8300-tdep.c: Same.
 357         * hppa-tdep.c: Same.
 358         * i386-linux-tdep.c: Same.
 359         * i386-tdep.c: Same.
 360         * ia64-libunwind-tdep.c: Same.
 361         * ia64-tdep.c: Same.
 362         * infcmd.c: Same.
 363         * infrun.c: Same.
 364         * linespec.c: Same.
 365         * linux-nat.c: Same.
 366         * linux-thread-db.c: Same.
 367         * machoread.c: Same.
 368         * mdebugread.c: Same.
 369         * mep-tdep.c: Same.
 370         * mn10300-tdep.c: Same.
 371         * namespace.c: Same.
 372         * objfiles.c: Same.
 373         * opencl-lang.c: Same.
 374         * or1k-tdep.c: Same.
 375         * osabi.c: Same.
 376         * ppc-linux-nat.c: Same.
 377         * ppc-linux-tdep.c: Same.
 378         * ppc-sysv-tdep.c: Same.
 379         * printcmd.c: Same.
 380         * procfs.c: Same.
 381         * record-btrace.c: Same.
 382         * record-full.c: Same.
 383         * remote-fileio.c: Same.
 384         * remote.c: Same.
 385         * rs6000-tdep.c: Same.
 386         * s12z-tdep.c: Same.
 387         * score-tdep.c: Same.
 388         * ser-base.c: Same.
 389         * ser-go32.c: Same.
 390         * skip.c: Same.
 391         * sol-thread.c: Same.
 392         * solib-svr4.c: Same.
 393         * solib.c: Same.
 394         * source.c: Same.
 395         * sparc-nat.c: Same.
 396         * sparc-sol2-tdep.c: Same.
 397         * sparc-tdep.c: Same.
 398         * sparc64-tdep.c: Same.
 399         * stabsread.c: Same.
 400         * stack.c: Same.
 401         * symfile.c: Same.
 402         * symtab.c: Same.
 403         * target-descriptions.c: Same.
 404         * target-float.c: Same.
 405         * thread.c: Same.
 406         * utils.c: Same.
 407         * valops.c: Same.
 408         * valprint.c: Same.
 409         * value.c: Same.
 410         * varobj.c: Same.
 411         * windows-nat.c: Same.
 412         * xcoffread.c: Same.
 413         * xstormy16-tdep.c: Same.
 414         * xtensa-tdep.c: Same.
 415
 416 2019-10-17  Tom Tromey  <tromey@adacore.com>
 417
 418         * configure: Rebuild.
 419         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
 420         in AC_CONFIG_FILES invocation.
 421         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
 422         new-style config.status invocation.
 423
 424 2019-10-17  Tom de Vries  <tdevries@suse.de>
 425
 426         * arm-nbsd-nat.c: Fix typos in comments.
 427         * arm-tdep.c: Same.
 428         * darwin-nat-info.c: Same.
 429         * dwarf2read.c: Same.
 430         * elfread.c: Same.
 431         * event-top.c: Same.
 432         * findvar.c: Same.
 433         * gdbtypes.c: Same.
 434         * hppa-tdep.c: Same.
 435         * i386-tdep.c: Same.
 436         * jit.c: Same.
 437         * main.c: Same.
 438         * mdebugread.c: Same.
 439         * moxie-tdep.c: Same.
 440         * nto-procfs.c: Same.
 441         * osabi.c: Same.
 442         * ppc-linux-tdep.c: Same.
 443         * remote.c: Same.
 444         * riscv-tdep.c: Same.
 445         * s390-tdep.c: Same.
 446         * sh-tdep.c: Same.
 447         * sparc-linux-tdep.c: Same.
 448         * sparc-nat.c: Same.
 449         * stack.c: Same.
 450         * target-descriptions.c: Same.
 451         * top.c: Same.
 452         * varobj.c: Same.
 453
 454 2019-10-16  Tom Tromey  <tom@tromey.com>
 455
 456         * objfiles.h (struct objfile) <original_name>: Now const.
 457
 458 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 459
 460         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
 461         pass on to sigsetjmp's second argument.
 462         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
 463
 464 2019-10-16  Keith Seitz  <keiths@redhat.com>
 465
 466         PR gdb/23567
 467         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
 468         sections whose size is greater than the file size.
 469
 470 2019-10-16  Jim Wilson  <jimw@sifive.com>
 471
 472         * riscv-tdep.c (riscv_gcc_target_options): New.
 473         (riscv_gnu_triplet_regexp): New.
 474         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
 475         set_gdbarch_gnu_triplet_regexp.
 476
 477 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
 478
 479         * Makefile.in: Add xml-builtin.h.
 480         * features/feature_to_c.sh: Add an include for xml-builtin.h
 481         to ensure that the compiler checks that the types match.
 482         * xml-builtin.h: New file.
 483         * xml-support.c (fetch_xml_builtin): Add missing const.
 484         * xml-support.h: Remove declaration of xml_builtins.
 485
 486 2019-10-16  Tom de Vries  <tdevries@suse.de>
 487
 488         PR tdep/25096
 489         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
 490         (amd64_classify_aggregate): ... here.
 491         (amd64_classify_aggregate_field): Handled fiels of nested structs
 492         recursively.
 493
 494 2019-10-16  Tom de Vries  <tdevries@suse.de>
 495
 496         PR tdep/24104
 497         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
 498         that handles 'theclass'.
 499
 500 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * linespec.c (decode_digits_ordinary): Update comment.
 503         * make-target-delegates: No longer need to handle VEC case.
 504         * memrange.c (normalize_mem_ranges): Update comment.
 505         * namespace.c (add_using_directive): Update comment.
 506         * objc-lang.c (uniquify_strings): Update comment.
 507         * ppc-linux-nat.c (struct thread_points): Update comment.
 508         * probe.h (find_probes_in_objfile): Update comment.
 509         * target.h (enum flash_preserve_mode): Update comment.
 510         * varobj.c (varobj_restrict_range): Update comment.
 511         * varobj.h (varobj_list_children): Update comment.
 512
 513 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * Makefile.in: Remove references to vec.h and vec.c.
 516         * aarch64-tdep.c: No longer include vec.h.
 517         * ada-lang.c: Likewise.
 518         * ada-lang.h: Likewise.
 519         * arm-tdep.c: Likewise.
 520         * ax.h: Likewise.
 521         * breakpoint.h: Likewise.
 522         * charset.c: Likewise.
 523         * cp-support.h: Likewise.
 524         * dtrace-probe.c: Likewise.
 525         * dwarf2read.c: Likewise.
 526         * extension.h: Likewise.
 527         * gdb_bfd.c: Likewise.
 528         * gdbsupport/gdb_vecs.h: Likewise.
 529         * gdbsupport/vec.c: Remove.
 530         * gdbsupport/vec.h: Remove.
 531         * gdbthread.h: Likewise.
 532         * guile/scm-type.c: Likewise.
 533         * inline-frame.c: Likewise.
 534         * machoread.c: Likewise.
 535         * memattr.c: Likewise.
 536         * memrange.h: Likewise.
 537         * namespace.h: Likewise.
 538         * nat/linux-btrace.h: Likewise.
 539         * osdata.c: Likewise.
 540         * parser-defs.h: Likewise.
 541         * progspace.h: Likewise.
 542         * python/py-type.c: Likewise.
 543         * record-btrace.c: Likewise.
 544         * rust-exp.y: Likewise.
 545         * solib-target.c: Likewise.
 546         * stap-probe.c: Likewise.
 547         * target-descriptions.c: Likewise.
 548         * target-memory.c: Likewise.
 549         * target.h: Likewise.
 550         * varobj.c: Likewise.
 551         * varobj.h: Likewise.
 552         * xml-support.h: Likewise.
 553
 554 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
 557         Update for new std::vector based implementation.
 558         (process_psymtab_comp_unit_reader): Likewise.
 559         (scan_partial_symbols): Likewise.
 560         (recursively_compute_inclusions): Likewise.
 561         (compute_compunit_symtab_includes): Likewise.
 562         (process_imported_unit_die): Likewise.
 563         (queue_and_load_dwo_tu): Likewise.
 564         (follow_die_sig_1): Likewise.
 565         * gdb/dwarf2read.h: Remove DEF_VEC_P.
 566         (typedef dwarf2_per_cu_ptr): Remove.
 567         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
 568         function.
 569         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
 570         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
 571         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
 572         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
 573         std::vector.
 574
 575 2019-10-15  Tom Tromey  <tromey@adacore.com>
 576
 577         * windows-nat.c (windows_nat_target::resume): Use %x when logging
 578         TID.
 579
 580 2019-10-15  Tom Tromey  <tromey@adacore.com>
 581
 582         * windows-nat.c (windows_nat_target::fetch_registers)
 583         (windows_nat_target::store_registers): Rename "pid" to "tid".
 584
 585 2019-10-15  Tom Tromey  <tromey@adacore.com>
 586
 587         * gdbarch.h, gdbarch.c: Rebuild.
 588         * gdbarch.sh (gcc_target_options): Change return type to
 589         std::string.
 590         * compile/compile.c (get_args): Update.
 591         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
 592         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
 593         std::string.
 594         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
 595         std::string.
 596         * arch-utils.c (default_gcc_target_options): Return std::string.
 597         * arch-utils.h (default_gcc_target_options): Return std::string.
 598         * s390-tdep.c (s390_gcc_target_options): Return std::string.
 599
 600 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 601
 602         * breakpoint.c (breakpoint_chain): Make static.
 603         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
 604         of accessing breakpoint_chain.
 605
 606 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
 607
 608         * breakpoint.c (iterate_over_breakpoints): Change function pointer
 609         to a gdb::function_view and return value to bool.
 610         * breakpoint.h (iterate_over_breakpoints): Likewise.
 611         * dummy-frame.c (pop_dummy_frame_bpt): Update.
 612         (pop_dummy_frame): Update.
 613         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
 614         (gdbscm_breakpoints): Update.
 615         * python/py-breakpoint.c (build_bp_list): Update.
 616         (gdbpy_breakpoints): Update.
 617         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
 618         Update.
 619         (bpfinishpy_handle_stop): Update.
 620         (bpfinishpy_handle_exit): Update.
 621         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
 622         (svr4_update_solib_event_breakpoints): Update.
 623
 624 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
 625
 626         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
 627         when unwrapping single-field structs.
 628
 629 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
 630
 631         * dwarf2read.c: Remove includes.
 632
 633 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
 634
 635         * ui-out.c (ui_out::call_do_message): Silence
 636         -Wformat-nonliteral warning.
 637
 638 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
 639
 640         * breakpoint.c: Remove some includes: continuations.h, skip.h,
 641         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
 642         include: readline/tilde.h.
 643
 644 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 645
 646         * remote.c (remote_target::get_trace_status): Remove declaration of
 647         trace_regblock_size.
 648
 649 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
 650
 651         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
 652         (show_user): Remove declaration of cmdlist.
 653         * cli/cli-cmds.h (max_user_call_depth): Declare.
 654         * cli/cli-script.c (execute_user_command): Remove declaration
 655         of max_user_call_depth.
 656
 657 2019-10-11  Jim Wilson  <jimw@sifive.com>
 658
 659         * gdbsupport/print-utils.h (pulongest): Fix comment.
 660         (plongest): Likewise.
 661         (phex): Add missing comment, mention leading zeros.
 662         (phex_nz): Add mention of no leading zeros to comment.
 663
 664         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 665         plongest instead of unsigned long long cast.
 666
 667 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 668
 669         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 670         for external_editor_command and gdbtk_test.
 671
 672 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 673
 674         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 675         * varobj.c (varobjdebug): Move comment to...
 676         * varobj.h (varobjdebug): ...here, and declare.
 677
 678 2019-10-09  Tom Tromey  <tom@tromey.com>
 679
 680         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 681         erase_data_content.
 682
 683 2019-10-09  Tom Tromey  <tom@tromey.com>
 684
 685         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 686         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 687         * tui/tui-command.c (tui_cmd_window::resize)
 688         (tui_refresh_cmd_win): Update.
 689         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 690         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 691         * tui/tui-data.c (~tui_gen_win_info): Remove.
 692         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 693         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 694         (tui_redisplay_readline, tui_mld_flush)
 695         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 696         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 697         (tui_data_window::erase_data_content)
 698         (tui_data_item_window::rerender)
 699         (tui_data_item_window::refresh_window): Update.
 700         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 701         (box_win, tui_gen_win_info::make_window)
 702         (tui_gen_win_info::make_visible): Update.
 703         (tui_delete_win): Remove.
 704         * tui/tui-winsource.c
 705         (tui_source_window_base::do_erase_source_content): Update.
 706         (tui_show_source_line, tui_source_window_base::update_tab_width)
 707         (tui_source_window_base::update_exec_info): Update.
 708         * tui/tui-data.h (struct curses_deleter): New.
 709         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 710         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 711
 712 2019-10-09  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 715
 716 2019-10-09  Tom Tromey  <tom@tromey.com>
 717
 718         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 719         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 720
 721 2019-10-09  Tom Tromey  <tom@tromey.com>
 722
 723         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 724         window height directly.
 725         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 726         declare.
 727         * tui/tui-layout.c (tui_default_win_height): Remove.
 728         (tui_default_win_viewport_height): Remove.
 729
 730 2019-10-09  Tom Tromey  <tom@tromey.com>
 731
 732         * tui/tui.h: Remove comments.
 733
 734 2019-10-09  Tom de Vries  <tdevries@suse.de>
 735
 736         * python/lib/gdb/printer/bound_registers.py: Use
 737         '^builtin_type_bound128' as regexp argument for
 738         add_builtin_pretty_printer.
 739
 740 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 741
 742         * guile/guile.c (guile_extension_script_ops): Remove forward
 743         declaration and mark as static.
 744         (guile_script_ops): Likewise.
 745         (extension_language_guile): Move further down in the file so
 746         it can reference the definitions for guile_{extension_,}script_ops.
 747
 748 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 749
 750         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 751         except SORTL, DFLTCC, and KDSA.
 752
 753 2019-10-08  Tom Tromey  <tromey@adacore.com>
 754
 755         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 756         (struct safe_symbol_file_add_args): Remove.
 757
 758 2019-10-08  Tom Tromey  <tromey@adacore.com>
 759
 760         * windows-nat.c: Don't include buildsym-legacy.h.
 761
 762 2019-10-08  Tom Tromey  <tromey@adacore.com>
 763
 764         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 765
 766 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 767
 768         * gdbtypes.c (overload_debug): Move comment to header.
 769         * gdbtypes.h (overload_debug): Declare.
 770         * valops.c: Remove declaration of overload_debug, instead
 771         include gdbtypes.h.
 772
 773 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 774
 775         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 776         through _().
 777         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 778         move comment...
 779         * language.h (lang_frame_mismatch_warn): ... here. Also add
 780         declaration.
 781         * top.c (lang_frame_mismatch_warn): Remove declaration.
 782         (check_frame_language_change): Pass lang_frame_mismatch_warn
 783         through _().
 784
 785 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 786
 787         * c-lang.h (vtbl_ptr_name): Declare.
 788         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 789         it from the header.
 790         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 791
 792 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 793
 794         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 795         gdb_static_assert.
 796
 797 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 798
 799         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 800         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 801         * ctfread.c: New file.
 802         * ctfread.h: New file.
 803         * elfread.c: Include ctfread.h.
 804         (struct elfinfo text_p): New member ctfsect.
 805         (elf_locate_sections): Mark CTF section.
 806         (elf_symfile_read): Call elfctf_build_psymtabs.
 807         * Makefile.in (LIBCTF): Add.
 808         (CLIBS): Use it.
 809         (CDEPS): Likewise.
 810         (DIST): Add ctfread.c.
 811
 812 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 813
 814         * ctfread.c (struct nextfield): Renamed to ...
 815         (struct ctf_nextfield): ... this.
 816         (struct field_info): Renamed to ...
 817         (strut ctf_field_info): ... this.
 818         (attach_fields_to_type): Update for renamed structures.
 819         (ctf_add_member_cb): Likewise.
 820         (ctf_add_enum_member_cb): Likewise.
 821         (process_struct_members): Likewise.
 822         (process_enum_type): Likewise.
 823
 824 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 825
 826         * tracectf.h: Rename, was ctf.h.
 827         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 828         * tracefile.c: Likewise.
 829         * tracepoint.c: Remove unused include ctf.h.
 830         * mi/mi-main.c: Likewise.
 831         * Makefile.in Replace ctf.c with tracectf.c.
 832
 833 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 834
 835         * version.in: Change version number to "9.0.50.DATE-git".
 836
 837 2019-10-03  Tom Tromey  <tom@tromey.com>
 838
 839         PR rust/24976:
 840         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 841
 842 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 843
 844         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 845         cp_search_name_hash.
 846         * NEWS: Add entry about nested function support.
 847
 848 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 849             Andrew Burgess  <andrew.burgess@embecosm.com>
 850
 851         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 852         for nested static variables when searchin VAR_DOMAIN.
 853         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 854         global scope, update comment.
 855         (add_partial_subprogram): Call add_partial_subprogram recursively
 856         for nested subroutines when processinng Fortran.
 857         (load_partial_dies): Process the child entities of a subprogram
 858         when processing Fortran.
 859         (partial_die_parent_scope): Handle building scope
 860         for Fortran nested functions.
 861         (process_die): Record that nested functions have a scope.
 862         (new_symbol): Always record Fortran subprograms on the global
 863         symbol list.
 864         (determine_prefix): How to build the prefix for Fortran
 865         subprograms.
 866
 867 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 868
 869         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 870         have just sent the thread a SIGSTOP and are waiting for it to
 871         arrive.
 872
 873 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 874
 875         * btrace.c (btrace_add_pc): Remove whitespace before the template
 876         parameter in 'std::vector <...>'.
 877         (parse_xml_btrace_block): Likewise.
 878         (btrace_maint_decode_pt): Likewise.
 879         (btrace_maint_update_packets): Likewise.
 880         (btrace_maint_print_packets): Likewise.
 881         * btrace.h (struct btrace_maint_info): Likewise.
 882         * dwarf2read.c (struct type_unit_group): Likewise.
 883         (build_type_psymtabs_reader): Likewise.
 884         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 885         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 886         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 887
 888 2019-10-03  Tom de Vries  <tdevries@suse.de>
 889
 890         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 891         the first line of the help text for set/show style metadata.
 892
 893 2019-10-02  Tom Tromey  <tromey@adacore.com>
 894
 895         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 896         * gdbsupport/common-inferior.c: New file.
 897         * infcmd.c (startup_with_shell): Don't define.
 898         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 899         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 900         * inferior.h (startup_with_shell): Don't declare.
 901
 902 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 903
 904         * gdbsupport/gdb_assert.h: Include errors.h.
 905         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 906
 907 2019-10-02  Tom Tromey  <tromey@adacore.com>
 908
 909         * NEWS: Add $_ada_exception entry.
 910         * ada-lang.c (struct ada_catchpoint): Add constructor.
 911         <m_kind>: New member.
 912         (allocate_location_exception, re_set_exception): Remove
 913         "ex" parameter.
 914         (should_stop_exception): Compute $_ada_exception.
 915         (check_status_exception, print_it_exception)
 916         (print_one_exception, print_mention_exception): Remove
 917         "ex" parameter.
 918         (allocate_location_catch_exception, re_set_catch_exception)
 919         (check_status_exception, print_it_catch_exception)
 920         (print_one_catch_exception, print_mention_catch_exception)
 921         (print_recreate_catch_exception)
 922         (allocate_location_catch_exception_unhandled)
 923         (re_set_catch_exception_unhandled)
 924         (check_status_exception, print_it_catch_exception_unhandled)
 925         (print_one_catch_exception_unhandled)
 926         (print_mention_catch_exception_unhandled)
 927         (print_recreate_catch_exception_unhandled)
 928         (allocate_location_catch_assert, re_set_catch_assert)
 929         (check_status_assert, print_it_catch_assert)
 930         (print_one_catch_assert, print_mention_catch_assert)
 931         (print_recreate_catch_assert)
 932         (allocate_location_catch_handlers, re_set_catch_handlers)
 933         (check_status_handlers, print_it_catch_handlers)
 934         (print_one_catch_handlers, print_mention_catch_handlers)
 935         (print_recreate_catch_handlers): Remove.
 936         (create_ada_exception_catchpoint): Update.
 937         (initialize_ada_catchpoint_ops): Update.
 938
 939 2019-10-02  Tom Tromey  <tromey@adacore.com>
 940
 941         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 942         (create_excep_cond_exprs): Simplify exception string computation.
 943         (ada_exception_catchpoint_cond_string): Likewise.
 944
 945 2019-10-02  Tom Tromey  <tromey@adacore.com>
 946
 947         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 948         * ada-lang.c (lesseq_defined_than): Handle
 949         LOC_STATIC.
 950         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 951         parameter.
 952         (dwarf2_has_info): Likewise.
 953         (new_symbol): Set maybe_copied on symbol when
 954         appropriate.
 955         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 956         parameter.
 957         <can_copy>: New member.
 958         * elfread.c (record_minimal_symbol): Set maybe_copied
 959         on symbol when appropriate.
 960         (elf_symfile_read): Update call to dwarf2_has_info.
 961         * minsyms.c (lookup_minimal_symbol_linkage): New
 962         function.
 963         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 964         * symtab.c (get_symbol_address, get_msymbol_address):
 965         New functions.
 966         * symtab.h (get_symbol_address, get_msymbol_address):
 967         Declare.
 968         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 969         maybe_copied.
 970         (struct symbol, struct minimal_symbol) <maybe_copied>:
 971         New member.
 972
 973 2019-10-02  Tom Tromey  <tromey@adacore.com>
 974
 975         * source.c (struct current_source_location): New.
 976         (current_source_key): New global.
 977         (current_source_symtab, current_source_line)
 978         (current_source_pspace): Remove.
 979         (get_source_location): New function.
 980         (get_current_source_symtab_and_line)
 981         (set_default_source_symtab_and_line)
 982         (set_current_source_symtab_and_line)
 983         (clear_current_source_symtab_and_line, select_source_symtab)
 984         (info_source_command, print_source_lines_base)
 985         (info_line_command, search_command_helper, _initialize_source):
 986         Update.
 987
 988 2019-10-02  Tom Tromey  <tromey@adacore.com>
 989
 990         * source.c (select_source_symtab): Don't call
 991         decode_line_with_current_source.
 992
 993 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 994
 995         * symtab.c (lookup_global_symbol): Search global block.
 996
 997 2019-10-02  Tom Tromey  <tromey@adacore.com>
 998
 999         * coffread.c (process_coff_symbol): Update.
1000         * dwarf2read.c (var_decode_location, new_symbol): Update.
1001         * mdebugread.c (parse_symbol): Update.
1002         * objfiles.c (relocate_one_symbol): Update.
1003         * stabsread.c (define_symbol, fix_common_block)
1004         (scan_file_globals): Update.
1005         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
1006         (SET_SYMBOL_VALUE_ADDRESS): New macro.
1007         * xcoffread.c (process_xcoff_symbol): Update.
1008
1009 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
1010
1011         * MAINTAINERS: Update my email address.
1012
1013 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1014
1015         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
1016         std::vector.
1017         (build_type_psymtabs_reader): Update for std::vector.
1018         (build_type_psymtab_dependencies): Likewise.
1019         * dwarf2read.h: Remove use of DEF_VEC_P.
1020         (typedef sig_type_ptr): Delete.
1021
1022 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1023
1024         * btrace.c (btrace_maint_clear): Update to handle change from VEC
1025         to std::vector.
1026         (btrace_maint_decode_pt): Likewise, and move allocation of the
1027         vector outside of the loop.
1028         (btrace_maint_update_packets): Update to handle change from VEC to
1029         std::vector.
1030         (btrace_maint_print_packets): Likewise.
1031         (maint_info_btrace_cmd): Likewise.
1032         * btrace.h: Remove use of DEF_VEC_O.
1033         (typedef btrace_pt_packet_s): Delete.
1034         (struct btrace_maint_info) <packets>: Change fromm VEC to
1035         std::vector.
1036         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
1037
1038 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1039
1040         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
1041         make accesses into the vector constant references.
1042         (btrace_add_pc): Update for std::vector.
1043         (btrace_stitch_bts): Likewise.
1044         (parse_xml_btrace_block): Likewise.
1045         (btrace_maint_update_packets): Likewise.
1046         (btrace_maint_print_packets): Likewise.
1047         (maint_info_btrace_cmd): Likewise.
1048         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
1049         std::vector.
1050         (btrace_data::empty): Likewise.
1051         (btrace_data_append): Likewise.
1052         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
1053         (typedef btrace_block_s): Delete.
1054         (struct btrace_block): Add constructor.
1055         (struct btrace_data_bts) <blocks>: Change to std::vector.
1056         * nat/linux-btrace.c (perf_event_read_bts): Update for
1057         std::vector.
1058         (linux_read_bts): Likewise.
1059
1060 2019-10-01  Tom Tromey  <tom@tromey.com>
1061
1062         * cli/cli-logging.c (show_logging_filename): Use styled_string.
1063
1064 2019-10-01  Tom Tromey  <tom@tromey.com>
1065
1066         * stack.c (print_frame, info_frame_command_core): Use
1067         styled_string.
1068         * linux-thread-db.c (try_thread_db_load_1)
1069         (try_thread_db_load_from_pdir_1): Use styled_string.
1070         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
1071         (auto_load_section_scripts, info_auto_load_local_gdbinit)
1072         (maybe_print_unsupported_script_warning)
1073         (maybe_print_script_not_found_warning): Use styled_string.
1074         * ada-lang.c (user_select_syms): Use styled_string.
1075
1076 2019-10-01  Tom Tromey  <tom@tromey.com>
1077
1078         * p-lang.c (pascal_printstr): Use metadata style.
1079         * value.c (show_convenience): Use metadata style.
1080         * valprint.c (valprint_check_validity, val_print_optimized_out)
1081         (val_print_not_saved, val_print_unavailable)
1082         (val_print_invalid_address, generic_val_print, val_print)
1083         (value_check_printable, val_print_array_elements): Use metadata
1084         style.
1085         * ui-out.h (class ui_out) <field_fmt>: New overload.
1086         <do_field_fmt>: Add style parameter.
1087         * ui-out.c (ui_out::field_fmt): New overload.
1088         * typeprint.c (type_print_unknown_return_type)
1089         (val_print_not_allocated, val_print_not_associated): Use metadata
1090         style.
1091         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
1092         parameter.
1093         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
1094         * tracepoint.c (tvariables_info_1): Use metadata style.
1095         * stack.c (print_frame_arg, print_frame_info, print_frame)
1096         (info_frame_command_core): Use metadata style.
1097         * skip.c (info_skip_command): Use metadata style.
1098         * rust-lang.c (rust_print_enum): Use metadata style.
1099         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1100         metadata style.
1101         * python/py-framefilter.c (py_print_single_arg): Use metadata
1102         style.
1103         * printcmd.c (do_one_display, print_variable_and_value): Use
1104         metadata style.
1105         * p-valprint.c (pascal_val_print)
1106         (pascal_object_print_value_fields): Use metadata style.
1107         * p-typeprint.c (pascal_type_print_base): Use metadata style.
1108         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
1109         parameter.
1110         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
1111         * m2-valprint.c (m2_print_long_set): Use metadata style.
1112         * m2-typeprint.c (m2_print_type): Use metadata style.
1113         * infcmd.c (print_return_value_1): Use metadata style.
1114         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
1115         * f-valprint.c (info_common_command_for_block): Use metadata
1116         style.
1117         * f-typeprint.c (f_type_print_base): Use metadata style.
1118         * expprint.c (print_subexp_standard): Use metadata style.
1119         * cp-valprint.c (cp_print_value_fields): Use metadata style.
1120         * cli/cli-style.h (class cli_style_option): Add constructor.
1121         (metadata_style): Declare.
1122         * cli/cli-style.c (metadata_style): New global.
1123         (_initialize_cli_style): Register metadata style.
1124         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
1125         parameter.
1126         * cli-out.c (cli_ui_out::do_field_fmt): Update.
1127         * c-typeprint.c (c_type_print_base_struct_union)
1128         (c_type_print_base_1): Use metadata style.
1129         * breakpoint.c (watchpoint_value_print)
1130         (print_one_breakpoint_location): Use metadata style.
1131         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
1132         style.
1133         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
1134         style.
1135         * ada-valprint.c (val_print_packed_array_elements, printstr)
1136         (print_field_values, ada_val_print_ref, ada_val_print): Use
1137         metadata style.
1138         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
1139         style.
1140         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
1141         style.
1142         * ada-lang.c (user_select_syms): Use metadata style.
1143
1144 2019-10-01  Tom Tromey  <tom@tromey.com>
1145
1146         * cli/cli-cmds.c (pwd_command): Style output.
1147
1148 2019-10-01  Pedro Alves  <palves@redhat.com>
1149             Tom Tromey  <tom@tromey.com>
1150
1151         * symtab.c (print_symbol_info): Use %ps.
1152         (print_msymbol_info): Use %ps.
1153         * symfile.c (symbol_file_add_with_addrs): Use %ps.
1154         * printcmd.c (print_variable_and_value): Use %ps.
1155         * macrocmd.c (show_pp_source_pos): Use %ps.
1156         * infrun.c (print_exited_reason): Use ui_out::message.
1157         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
1158         (describe_other_breakpoints): Use ui_out::message and new
1159         formats.
1160         (say_where): Use new formats.
1161         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
1162         and new formats.
1163
1164 2019-10-01  Pedro Alves  <palves@redhat.com>
1165             Tom Tromey  <tom@tromey.com>
1166
1167         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
1168         (test_gdb_formats): New function.
1169         (run_tests): Call it.
1170         (test_format_specifier): Update.
1171         * utils.h (fputs_filtered): Update comment.
1172         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
1173         (fputs_styled_unfiltered): Declare.
1174         * utils.c (fputs_styled_unfiltered): New function.
1175         (vfprintf_maybe_filtered): Add gdbfmt parameter.
1176         (vfprintf_filtered): Update.
1177         (vfprintf_unfiltered, vprintf_filtered): Update.
1178         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
1179         * ui-out.h (enum ui_out_flag) <unfiltered_output,
1180         disallow_ui_out_field>: New constants.
1181         (enum class field_kind): New.
1182         (struct base_field_s, struct signed_field_s): New.
1183         (signed_field): New function.
1184         (struct string_field_s): New.
1185         (string_field): New function.
1186         (struct styled_string_s): New.
1187         (styled_string): New function.
1188         (class ui_out) <message>: Add comment.
1189         <vmessage, call_do_message>: New methods.
1190         <do_message>: Add style parameter.
1191         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
1192         methods.
1193         (ui_out::message): Rewrite.
1194         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
1195         parameter.
1196         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
1197         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
1198         gdb_extensions parameter.
1199         (class format_piece): Add parameter to constructor.
1200         (n_int_args): New field.
1201         * gdbsupport/format.c (format_pieces::format_pieces): Add
1202         gdb_extensions parameter.  Handle '*'.
1203         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
1204         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
1205         vfprintf_styled_no_gdbfmt.
1206         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
1207         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
1208         unfiltered output.
1209         * ui-style.h (struct ui_file_style) <ptr>: New method.
1210
1211 2019-10-01  Tom Tromey  <tom@tromey.com>
1212
1213         * unittests/format_pieces-selftests.c: Update.  Add final format.
1214         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
1215         empty literal pieces.
1216
1217 2019-10-01  Tom Tromey  <tom@tromey.com>
1218
1219         * ui-out.h (enum class ui_out_style_kind): Remove.
1220         (class ui_out) <field_string, field_stsream, do_field_string>:
1221         Change type of "style".
1222         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
1223         (ui_out::field_string): Update.
1224         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
1225         of "style".
1226         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
1227         * tracepoint.c (print_one_static_tracepoint_marker): Update.
1228         * stack.c (print_frame_arg, print_frame_info, print_frame):
1229         Update.
1230         * source.c (print_source_lines_base): Update.
1231         * solib.c (info_sharedlibrary_command): Update.
1232         * skip.c (info_skip_command): Update.
1233         * record-btrace.c (btrace_call_history_src_line)
1234         (btrace_call_history): Update.
1235         * python/py-framefilter.c (py_print_frame): Update.
1236         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
1237         "style".
1238         * mi/mi-out.c (mi_ui_out::do_table_header)
1239         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
1240         (mi_ui_out::do_field_string): Update.
1241         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1242         Update.
1243         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
1244         "style".
1245         * cli-out.c (cli_ui_out::do_table_header)
1246         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
1247         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
1248         (cli_ui_out::do_field_fmt): Update.
1249         * breakpoint.c (print_breakpoint_location): Update.
1250         (update_static_tracepoint): Update.
1251
1252 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1253
1254         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
1255         conversion of gdb_datadir.
1256         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
1257         remove not needed c_str ().
1258
1259 2019-09-30  Ali Tamur <tamur@google.com>
1260
1261         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
1262         (dwarf2_string_attr): Likewise.
1263
1264 2019-09-30  Ali Tamur <tamur@google.com>
1265
1266         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
1267         (process_full_type_unit): Likewise.
1268         (dump_die_shallow): Likewise.
1269         (cu_debug_loc_section): Likewise.
1270
1271 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
1272
1273         * minsyms.c (compare_minimal_symbols): Rename to...
1274         (minimal_symbol_is_less_than): ...this, and adjust to STL
1275         conventions (return bool, take arguments as references)
1276         (minimal_symbol_reader::install): Call std::sort instead
1277         of qsort.
1278
1279 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
1280
1281         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
1282         hash and why.
1283         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
1284         msymbol_hash, msymbol_demangled_hash>: Improve comments.
1285
1286 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
1287
1288         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
1289         * psympriv.h (add_psymbol_to_list): Move comment here and update
1290         it.
1291
1292 2019-09-29  Tom de Vries  <tdevries@suse.de>
1293
1294         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
1295         Use $tmpdir/$(basename "$output_file").dwz instead of
1296         "${output_file}.dwz".
1297
1298 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
1299
1300         PR gdb/25045
1301         * hppa-linux-nat.c: Include gdbarch.h.
1302
1303 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
1304
1305         * blockframe.c (find_pc_partial_function): Change return type to bool.
1306         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
1307         * minsyms.c (in_gnu_ifunc_stub): Likewise.
1308         (stub_gnu_ifunc_resolve_name): Likewise.
1309         * symtab.c (compare_filenames_for_search): Likewise.
1310         (compare_glob_filenames_for_search): Likewise.
1311         (matching_obj_sections): Likewise.
1312         (symbol_matches_domain): Likewise.
1313         (find_line_symtab): Change out param EXACT_MATCH to bool *.
1314         (find_line_pc): Change return type to bool.
1315         (find_line_pc_range): Likewise.
1316         (producer_is_realview): Likewise.
1317         * symtab.h (symbol_matches_domain): Likewise.
1318         (find_pc_partial_function): Likewise.
1319         (find_pc_line_pc_range): Likewise.
1320         (in_gnu_ifunc_stub): Likewise.
1321         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
1322         (find_line_pc): Likewise.
1323         (find_line_pc_range): Likewise.
1324         (matching_obj_sections): Likewise.
1325         (find_line_symtab): Change out parameter to bool.
1326         (producer_is_realview): Change return type to bool.
1327         (compare_filenames_for_search): Likewise.
1328         (compare_glob_filenames_for_search): Likewise.
1329
1330 2019-09-26  Tom Tromey  <tom@tromey.com>
1331
1332         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
1333         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
1334         * gdb_usleep.h: Remove.
1335         * gdb_usleep.c: Remove.
1336         * utils.c: Don't include gdb_usleep.h.
1337
1338 2019-09-26  Tom Tromey  <tromey@adacore.com>
1339
1340         * python/py-type.c (type_to_type_object): Call check_typedef
1341         for stub types.
1342
1343 2019-09-26  Tom Tromey  <tom@tromey.com>
1344
1345         * utils.h (initialize_utils): Don't declare.
1346         * top.c (gdb_init): Don't call initialize_utils.
1347         * utils.c (initialize_utils): Remove.  Move contents...
1348         (_initialize_utils): ... here.
1349
1350 2019-09-25  Tom Tromey  <tom@tromey.com>
1351
1352         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
1353         * utils.h (make_hex_string): Don't declare.
1354         * utils.c (make_hex_string): Remove.
1355
1356 2019-09-24  Tom de Vries  <tdevries@suse.de>
1357
1358         PR gdb/23815
1359         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
1360         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
1361
1362 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
1363
1364         * NEWS: Mention new simulator port for PRU.
1365
1366 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
1367
1368         * ada-exp.y (write_object_remaining): Update.
1369         * ada-lang.c (ada_decode): Return a std::string instead of a char*
1370         and eliminate the static buffer.
1371         (ada_decode_symbol): Update.
1372         (ada_la_decode): Update.
1373         (ada_sniff_from_mangled_name): Update.
1374         (is_valid_name_for_wild_match): Update.
1375         (ada_lookup_name_info::matches): Update and simplify.
1376         (name_matches_regex): Update.
1377         (ada_add_global_exceptions): Update.
1378         * ada-lang.h (ada_decode): Update signature.
1379         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
1380         * dwarf-index-write.c (debug_names::insert): Update.
1381
1382 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1383
1384         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
1385         formatting.
1386
1387 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
1388
1389         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
1390         Change "nonzero" to "true" in documentation.
1391
1392 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
1393
1394         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
1395         (_initialize_darwin_solib): Don't set
1396         darwin_so_ops.lookup_lib_global_symbol.
1397         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
1398         set_gdbarch_iterate_over_objfiles_in_search_order.
1399         (elf_lookup_lib_symbol): Rename to...
1400         (svr4_iterate_over_objfiles_in_search_order): this, and update
1401         to iterate semantics.
1402         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
1403         * solib.c (solib_global_lookup): Remove.
1404         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
1405         (solib_global_lookup): Remove.
1406         * symtab.c (lookup_global_or_static_symbol): Remove call to
1407         solib_global_lookup.
1408
1409 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1410
1411         * NEWS: Move entries about default MI version now being
1412         version 3, and about the GDB/MI fix for multi-location
1413         breakpoints to the "since GDB 8.3" section.
1414
1415 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
1416
1417         GDB 8.3.1 released.
1418
1419 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
1420
1421         * NEWS: Mention that Cell/B.E. debugging support was removed.
1422         * MAINTAINERS: Remove spu target.
1423
1424         * config/djgpp/fnchange.lst: Remove entries for removed files.
1425
1426         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
1427         spu-multiarch.o, and spu-tdep.o.
1428         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
1429         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
1430         spu-multiarch.c, and spu-tdep.c.
1431         * spu-linux-nat.c: Remove file.
1432         * spu-multiarch.c: Remove file.
1433         * spu-tdep.c: Remove file.
1434         * spu-tdep.h: Remove file.
1435         * solib-spu.c: Remove file.
1436         * solib-spu.h: Remove file.
1437
1438         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
1439         * configure.nat (spu-linux): Remove.
1440         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
1441         solib-multiarch.o from gdb_target_obs.
1442         (spu*-*-*): Remove.
1443
1444         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
1445         feature flag.
1446         (ppc_linux_no_features): Update.
1447         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
1448         Cell/B.E. support.
1449         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
1450         (tdesc_powerpc_cell64l): Likewise.
1451         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
1452         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
1453         Cell/B.E. support.
1454         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
1455         Do not include "features/rs6000/powerpc-cell32l.c" or
1456         "features/rs6000/powerpc-cell64l.c".
1457         (ppc_linux_spu_section): Remove.
1458         (ppc_linux_core_read_description): Remove Cell/B.E. support.
1459         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
1460         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
1461         (ppc_linux_spe_context_lookup): Remove.
1462         (ppc_linux_spe_context_inferior_created): Remove.
1463         (ppc_linux_spe_context_solib_loaded): Remove.
1464         (ppc_linux_spe_context_solib_unloaded): Remove.
1465         (ppc_linux_spe_context): Remove.
1466         (struct ppu2spu_cache): Remove.
1467         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
1468         (struct ppu2spu_data): Remove.
1469         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
1470         ppu2spu_unwind): Remove.
1471         (ppc_linux_init_abi): Remove Cell/B.E. support.
1472         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
1473
1474         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
1475         (rs6000/powerpc-cell64l-expedite): Likewise
1476         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
1477         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
1478         rs6000/powerpc-cell64l.xml.
1479         * features/rs6000/powerpc-cell32l.xml: Remove.
1480         * features/rs6000/powerpc-cell64l.xml: Likewise.
1481         * features/rs6000/powerpc-cell32l.c: Remove generated file.
1482         * features/rs6000/powerpc-cell64l.c: Likewise.
1483         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
1484         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
1485         * regformats/reg-spu.dat: Remove.
1486
1487         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
1488         * corelow.c (struct spuid_list): Remove.
1489         (add_to_spuid_list): Remove.
1490         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1491         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
1492         (remote_protocol_features): Remove associated entries.
1493         (_initialize_remote): No longer initialize them.
1494         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1495         * linux-nat.c (SPUFS_MAGIC): Remove.
1496         (linux_proc_xfer_spu): Remove.
1497         (spu_enumerate_spu_ids): Remove.
1498         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
1499         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
1500         (linux_make_corefile_notes): No longer call it.
1501
1502         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
1503         (cooked_write_test): Likewise.
1504
1505 2019-09-20  Tom Tromey  <tom@tromey.com>
1506
1507         * NEWS: Mention case-sensitivity of TUI commands.
1508         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
1509         (tui_set_win_height_command, parse_scrolling_args): Likewise.
1510         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
1511
1512 2019-09-20  Tom Tromey  <tom@tromey.com>
1513
1514         * tui/tui-source.c (tui_source_window::set_contents): Use
1515         make_unique_xstrdup.
1516         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
1517         make_unique_xstrdup.
1518
1519 2019-09-20  Tom Tromey  <tom@tromey.com>
1520
1521         * tui/tui-data.c: Remove separator comments.
1522         * tui/tui-layout.c: Remove separator comments.
1523         * tui/tui-win.c: Remove separator comments.
1524         * tui/tui-wingeneral.c: Remove separator comments.
1525
1526 2019-09-20  Tom Tromey  <tom@tromey.com>
1527
1528         * tui/tui.h (strcat_to_buf): Don't declare.
1529         * tui/tui.c (strcat_to_buf): Remove.
1530
1531 2019-09-20  Tom Tromey  <tom@tromey.com>
1532
1533         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
1534         from "fullname".
1535         * tui/tui-source.c (tui_source_window::set_contents)
1536         (tui_source_window::location_matches_p)
1537         (tui_source_window::maybe_update): Update.
1538
1539 2019-09-20  Tom Tromey  <tom@tromey.com>
1540
1541         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
1542         Update.
1543         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
1544         prefix.
1545         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1546         (tui_data_window::line_from_reg_element_no)
1547         (tui_data_window::first_reg_element_no_inline)
1548         (tui_data_window::show_registers)
1549         (tui_data_window::show_register_group)
1550         (tui_data_window::display_registers_from)
1551         (tui_data_window::display_registers_from_line)
1552         (tui_data_window::first_data_item_displayed)
1553         (tui_data_window::delete_data_content_windows)
1554         (tui_data_window::erase_data_content)
1555         (tui_data_window::do_scroll_vertical)
1556         (tui_data_window::refresh_window)
1557         (tui_data_window::check_register_values): Update.
1558
1559 2019-09-20  Tom Tromey  <tom@tromey.com>
1560
1561         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1562         (struct tui_locator_window) <full_name, proc_name>: Now
1563         std::string.
1564         * tui/tui-stack.c (tui_locator_window::make_status_line)
1565         (tui_locator_window::set_locator_fullname)
1566         (tui_locator_window::set_locator_info): Update.
1567         * tui/tui-source.c (tui_source_window::set_contents)
1568         (tui_source_window::showing_source_p): Update.
1569
1570 2019-09-20  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1573         Don't call tui_locator_win_info_ptr.
1574
1575 2019-09-20  Tom Tromey  <tom@tromey.com>
1576
1577         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1578
1579 2019-09-20  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1582         height for locator.
1583         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1584         * tui/tui-layout.c (show_source_disasm_command, show_data)
1585         (show_source_or_disasm_and_command): Use 1 as height for locator.
1586
1587 2019-09-20  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui.c (tui_enable): Update.
1590         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1591         Update.
1592         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1593         Update.
1594         * tui/tui-data.c (win_resized): Now bool.
1595         (tui_win_resized): Return bool.
1596         (tui_set_win_resized_to): Accept a bool.
1597
1598 2019-09-20  Tom Tromey  <tom@tromey.com>
1599
1600         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1601         Change type of "refresh_values_only".
1602         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1603         type of "refresh_values_only".
1604
1605 2019-09-20  Tom Tromey  <tom@tromey.com>
1606
1607         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1608         std::string.
1609         (tui_disassemble): Add "pos" parameter.
1610         (tui_disasm_window::set_contents): Simplify.
1611
1612 2019-09-20  Tom Tromey  <tom@tromey.com>
1613
1614         * tui/tui-winsource.h (struct tui_source_window_base)
1615         <show_source_content>: Now private.
1616         * tui/tui-winsource.c
1617         (tui_source_window_base::show_source_content): Don't handle empty
1618         content case.
1619
1620 2019-09-20  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-layout.c (show_source_disasm_command)
1623         (show_source_or_disasm_and_command): Don't call
1624         show_source_content.
1625
1626 2019-09-20  Tom Tromey  <tom@tromey.com>
1627
1628         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1629         Declare.
1630         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1631         from tui_make_status_line.
1632         (tui_locator_window::rerender): Update.
1633
1634 2019-09-20  Tom Tromey  <tom@tromey.com>
1635
1636         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1637         (tui_locator_window::rerender): Update.
1638
1639 2019-09-20  Tom Tromey  <tom@tromey.com>
1640
1641         * tui/tui-winsource.h (struct tui_source_window_base)
1642         <~tui_source_window_base>: Don't declare.
1643         <fullname>: Remove.
1644         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1645         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1646         member.
1647         * tui/tui-source.c (tui_source_window::set_contents): Update.
1648         (tui_source_window::location_matches_p)
1649         (tui_source_window::maybe_update): Update.
1650
1651 2019-09-20  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-winsource.h (~tui_source_element): Remove.
1654         (tui_source_element): Update.
1655         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1656         * tui/tui-winsource.c (tui_show_source_line): Update.
1657         * tui/tui-source.c (tui_source_window::set_contents): Update.
1658         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1659
1660 2019-09-20  Tom Tromey  <tom@tromey.com>
1661
1662         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1663         declare.
1664         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1665         tui_clear_source_windows_detail.
1666         * tui/tui-winsource.h (struct tui_source_window_base)
1667         <clear_detail>: Don't declare.
1668         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1669         Remove.
1670         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1671
1672 2019-09-20  Tom Tromey  <tromey@adacore.com>
1673
1674         PR ada/24919:
1675         * block.c (contained_in): Fix final return value.
1676
1677 2019-09-20  Alan Modra  <amodra@gmail.com>
1678
1679         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1680         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1681         (read_indirect_string_from_dwz): Use bfd accessor.
1682         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1683         * machoread.c (macho_symfile_read_all_oso): Likewise.
1684         * solib.c (solib_bfd_open): Likewise.
1685
1686 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1687
1688         * eval.c: Move declaration of overload_resolution to...
1689         * value.h: ...here.
1690
1691 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1692
1693         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1694         * arm-linux-tdep.c: Likewise.
1695         * arm-nbsd-nat.c: Likewise.
1696         * arm-tdep.h: Declare arm_apcs_32.
1697         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1698
1699 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1700
1701         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1702         * dwarf2read.h: Declare dwarf_always_disassemble.
1703
1704 2019-09-19  Tom de Vries  <tdevries@suse.de>
1705
1706         PR gdb/25009
1707         * source-cache.c (source_cache::ensure): Catch exception thrown during
1708         construction of the highlighter.
1709
1710 2019-09-18  Alan Modra  <amodra@gmail.com>
1711
1712         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1713         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1714         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1715         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1716         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1717         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1718         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1719         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1720         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1721         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1722         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1723         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1724         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1725         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1726         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1727         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1728         * mi/mi-interp.c: Update throughout for bfd section macro and
1729         function changes.
1730         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1731         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1732
1733 2019-09-18  Tom Tromey  <tom@tromey.com>
1734
1735         * NEWS: Add entry.
1736         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1737         call rl_initialize.
1738         (tui_enable): Do not call rl_initialize.
1739
1740 2019-09-18  Christian Groessler  <chris@groessler.org>
1741
1742         * alpha-linux-nat.c: Include gdbarch.h.
1743
1744 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1745
1746         * ui-file.c: Include cli/cli-style.h.
1747         (term_cli_styling): Remove cli_styling declaration.
1748
1749 2019-09-18  Alan Modra  <amodra@gmail.com>
1750
1751         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1752         to bfd_asymbol_section.
1753
1754 2019-09-18  Alan Modra  <amodra@gmail.com>
1755
1756         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1757         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1758         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1759
1760 2019-09-18  Alan Modra  <amodra@gmail.com>
1761
1762         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1763         * spu-linux-nat.c (spu_bfd_open): Likewise.
1764
1765 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1766
1767         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1768         to bool to match definition in dwarf2read.c.
1769
1770 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1771
1772         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1773         (print_signatures): Likewise.
1774         (trust_pad_over_xvs): Likewise.
1775         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1776         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1777         * arm-linux-nat.c (arm_apcs_32): Likewise.
1778         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1779         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1780         * arm-tdep.c (arm_debug): Likewise.
1781         (arm_apcs_32): Likewise.
1782         * auto-load.c (debug_auto_load): Likewise.
1783         (auto_load_gdb_scripts): Likewise.
1784         (global_auto_load): Likewise.
1785         (auto_load_local_gdbinit): Likewise.
1786         (auto_load_local_gdbinit_loaded): Likewise.
1787         * auto-load.h (global_auto_load): Likewise.
1788         (auto_load_local_gdbinit): Likewise.
1789         (auto_load_local_gdbinit_loaded): Likewise.
1790         * breakpoint.c (disconnected_dprintf): Likewise.
1791         (breakpoint_proceeded): Likewise.
1792         (automatic_hardware_breakpoints): Likewise.
1793         (always_inserted_mode): Likewise.
1794         (target_exact_watchpoints): Likewise.
1795         (_initialize_breakpoint): Update.
1796         * breakpoint.h (target_exact_watchpoints): Change to bool.
1797         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1798         * cli/cli-cmds.c (trace_commands): Likewise.
1799         * cli/cli-cmds.h (trace_commands): Likewise.
1800         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1801         to bool*.
1802         * cli/cli-logging.c (logging_overwrite): Change to bool.
1803         (logging_redirect): Likewise.
1804         (debug_redirect): Likewise.
1805         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1806         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1807         to bool.
1808         <boolean_option_def>: Update.
1809         (struct flag_option_def): Change default type of Context to bool
1810         from int.
1811         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1812         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1813         (get_setshow_command_value_string): Likewise.
1814         * cli/cli-style.c (cli_styling): Change to bool.
1815         (source_styling): Likewise.
1816         * cli/cli-style.h (source_styling): Likewise.
1817         (cli_styling): Likewise.
1818         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1819         to bool.
1820         * command.h (var_types): Update comment.
1821         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1822         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1823         bool.
1824         (debug_compile_cplus_scopes): Likewise.
1825         * compile/compile-internal.h (compile_debug): Likewise.
1826         * compile/compile.c (compile_debug): Likewise.
1827         (struct compile_options) <raw>: Likewise.
1828         * cp-support.c (catch_demangler_crashes): Likewise.
1829         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1830         (usr_cmd_cris_dwarf2_cfi): Likewise.
1831         * csky-tdep.c (csky_debug): Likewise.
1832         * darwin-nat.c (enable_mach_exceptions): Likewise.
1833         * dcache.c (dcache_enabled_p): Likewise.
1834         * defs.h (info_verbose): Likewise.
1835         * demangle.c (demangle): Likewise.
1836         (asm_demangle): Likewise.
1837         * dwarf-index-cache.c (debug_index_cache): Likewise.
1838         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1839         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1840         * dwarf2read.c (check_physname): Likewise.
1841         (use_deprecated_index_sections): Likewise.
1842         (dwarf_always_disassemble): Likewise.
1843         * eval.c (overload_resolution): Likewise.
1844         * event-top.c (set_editing_cmd_var): Likewise.
1845         (exec_done_display_p): Likewise.
1846         * event-top.h (set_editing_cmd_var): Likewise.
1847         (exec_done_display_p): Likewise.
1848         * exec.c (write_files): Likewise.
1849         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1850         (debug_fbsd_nat): Likewise.
1851         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1852         Likewise.
1853         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1854         <backtrace_past_entry> Likewise.
1855         * gdb-demangle.h (demangle): Likewise.
1856         (asm_demangle): Likewise.
1857         * gdb_bfd.c (bfd_sharing): Likewise.
1858         * gdbcore.h (write_files): Likewise.
1859         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1860         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1861         * gdbthread.h (print_thread_events): Likewise.
1862         * gdbtypes.c (opaque_type_resolution): Likewise.
1863         (strict_type_checking): Likewise.
1864         * gnu-nat.c (gnu_debug_flag): Likewise.
1865         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1866         * guile/scm-param.c (pascm_variable): Add boolval.
1867         (add_setshow_generic): Update.
1868         (pascm_param_value): Update.
1869         (pascm_set_param_value_x): Update.
1870         * hppa-tdep.c (hppa_debug): Change to bool..
1871         * infcall.c (may_call_functions_p): Likewise.
1872         (coerce_float_to_double_p): Likewise.
1873         (unwind_on_signal_p): Likewise.
1874         (unwind_on_terminating_exception_p): Likewise.
1875         * infcmd.c (startup_with_shell): Likewise.
1876         * inferior.c (print_inferior_events): Likewise.
1877         * inferior.h (startup_with_shell): Likewise.
1878         (print_inferior_events): Likewise.
1879         * infrun.c (step_stop_if_no_debug): Likewise.
1880         (detach_fork): Likewise.
1881         (debug_displaced): Likewise.
1882         (disable_randomization): Likewise.
1883         (non_stop): Likewise.
1884         (non_stop_1): Likewise.
1885         (observer_mode): Likewise.
1886         (observer_mode_1): Likewise.
1887         (set_observer_mode): Update.
1888         (sched_multi): Change to bool.
1889         * infrun.h (debug_displaced): Likewise.
1890         (sched_multi): Likewise.
1891         (step_stop_if_no_debug): Likewise.
1892         (non_stop): Likewise.
1893         (disable_randomization): Likewise.
1894         * linux-tdep.c (use_coredump_filter): Likewise.
1895         (dump_excluded_mappings): Likewise.
1896         * linux-thread-db.c (auto_load_thread_db): Likewise.
1897         (check_thread_db_on_load): Likewise.
1898         * main.c (captured_main_1): Update.
1899         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1900         xx2_opt, boolean_opt>: Change to bool.
1901         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1902         * maint.c (maintenance_profile_p): Likewise.
1903         (per_command_time): Likewise.
1904         (per_command_space): Likewise.
1905         (per_command_symtab): Likewise.
1906         * memattr.c (inaccessible_by_default): Likewise.
1907         * mi/mi-main.c (mi_async): Likewise.
1908         (mi_async_1): Likewise.
1909         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1910         * nat/fork-inferior.h (startup_with_shell): Likewise.
1911         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1912         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1913         * nios2-tdep.c (nios2_debug): Likewise.
1914         * or1k-tdep.c (or1k_debug): Likewise.
1915         * parse.c (parser_debug): Likewise.
1916         * parser-defs.h (parser_debug): Likewise.
1917         * printcmd.c (print_symbol_filename): Likewise.
1918         * proc-api.c (procfs_trace): Likewise.
1919         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1920         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1921         (set_parameter_value): Update.
1922         (add_setshow_generic): Update.
1923         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1924         to bool*.
1925         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1926         int*.
1927         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1928         * record-btrace.c (record_btrace_target::store_registers): Update.
1929         * record-full.c (record_full_memory_query): Change to bool.
1930         (record_full_stop_at_limit): Likewise.
1931         * record-full.h (record_full_memory_query): Likewise.
1932         * remote-notif.c (notif_debug): Likewise.
1933         * remote-notif.h (notif_debug): Likewise.
1934         * remote.c (use_range_stepping): Likewise.
1935         (interrupt_on_connect): Likewise.
1936         (remote_break): Likewise.
1937         * ser-tcp.c (tcp_auto_retry): Likewise.
1938         * ser-unix.c (serial_hwflow): Likewise.
1939         * skip.c (debug_skip): Likewise.
1940         * solib-aix.c (solib_aix_debug): Likewise.
1941         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1942         (spu_auto_flush_cache_p): Likewise.
1943         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1944         Likewise.
1945         (struct info_print_options) <quiet>: Likewise.
1946         * symfile-debug.c (debug_symfile): Likewise.
1947         * symfile.c (auto_solib_add): Likewise.
1948         (separate_debug_file_debug): Likewise.
1949         * symfile.h (auto_solib_add): Likewise.
1950         (separate_debug_file_debug): Likewise.
1951         * symtab.c (basenames_may_differ): Likewise.
1952         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1953         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1954         (struct info_types_options) <quiet>: Likewise.
1955         * symtab.h (demangle): Likewise.
1956         (basenames_may_differ): Likewise.
1957         * target-dcache.c (stack_cache_enabled_1): Likewise.
1958         (code_cache_enabled_1): Likewise.
1959         * target.c (trust_readonly): Likewise.
1960         (may_write_registers): Likewise.
1961         (may_write_memory): Likewise.
1962         (may_insert_breakpoints): Likewise.
1963         (may_insert_tracepoints): Likewise.
1964         (may_insert_fast_tracepoints): Likewise.
1965         (may_stop): Likewise.
1966         (auto_connect_native_target): Likewise.
1967         (target_stop_and_wait): Update.
1968         (target_async_permitted): Change to bool.
1969         (target_async_permitted_1): Likewise.
1970         (may_write_registers_1): Likewise.
1971         (may_write_memory_1): Likewise.
1972         (may_insert_breakpoints_1): Likewise.
1973         (may_insert_tracepoints_1): Likewise.
1974         (may_insert_fast_tracepoints_1): Likewise.
1975         (may_stop_1): Likewise.
1976         * target.h (target_async_permitted): Likewise.
1977         (may_write_registers): Likewise.
1978         (may_write_memory): Likewise.
1979         (may_insert_breakpoints): Likewise.
1980         (may_insert_tracepoints): Likewise.
1981         (may_insert_fast_tracepoints): Likewise.
1982         (may_stop): Likewise.
1983         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1984         (make_thread_apply_all_options_def_group): Change argument from int*
1985         to bool*.
1986         (thread_apply_all_command): Update.
1987         (print_thread_events): Change to bool.
1988         * top.c (confirm): Likewise.
1989         (command_editing_p): Likewise.
1990         (history_expansion_p): Likewise.
1991         (write_history_p): Likewise.
1992         (info_verbose): Likewise.
1993         * top.h (confirm): Likewise.
1994         (history_expansion_p): Likewise.
1995         * tracepoint.c (disconnected_tracing): Likewise.
1996         (circular_trace_buffer): Likewise.
1997         * typeprint.c (print_methods): Likewise.
1998         (print_typedefs): Likewise.
1999         * utils.c (debug_timestamp): Likewise.
2000         (sevenbit_strings): Likewise.
2001         (pagination_enabled): Likewise.
2002         * utils.h (sevenbit_strings): Likewise.
2003         (pagination_enabled): Likewise.
2004         * valops.c (overload_resolution): Likewise.
2005         * valprint.h (struct value_print_options) <prettyformat_arrays,
2006         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
2007         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
2008         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
2009         Likewise.
2010         * windows-nat.c (new_console): Likewise.
2011         (cygwin_exceptions): Likewise.
2012         (new_group): Likewise.
2013         (debug_exec): Likewise.
2014         (debug_events): Likewise.
2015         (debug_memory): Likewise.
2016         (debug_exceptions): Likewise.
2017         (useshell): Likewise.
2018         * windows-tdep.c (maint_display_all_tib): Likewise.
2019         * xml-support.c (debug_xml): Likewise.
2020
2021 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
2022
2023         * source.c (prepare_path_for_appending): New function.
2024         (openp): Make use of new function.
2025         (find_and_open_source): Search for the compilation directory and
2026         source file as a relative path beneath the directory search path.
2027
2028 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2029
2030         * source-cache.c (source_cache::get_line_charpos): Catch
2031         exceptions and return false, this matches the behaviour documented
2032         in the header file.
2033
2034 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
2035
2036         * ada-tasks.c (info_task): Remove quoting of the task's name.
2037
2038 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
2039
2040         * symfile.c (auto_solib_add): Replace comment with a reference
2041         to the header file.
2042
2043 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
2044
2045         * NEWS: Mention that gdb can now be compiled with Python 3
2046         on Windows.
2047
2048 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2049
2050         * maint.c (maint_print_section_data::maint_print_section_data):
2051         Force use of 'float log10 (float)' by casting the argument to
2052         float.
2053
2054 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2055
2056         * maint.c: Add 'cmath' include.
2057         (struct maint_print_section_data): New structure.
2058         (print_section_index): New function.
2059         (print_bfd_section_info): Add header comment, small whitespace
2060         cleanup, and update to call new print_section_index function.
2061         (print_objfile_section_info): Likewise.
2062         (maint_obj_section_from_bfd_section): New function.
2063         (print_bfd_section_info_maybe_relocated): New function.
2064         (maintenance_info_sections): Add header comment, always use
2065         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
2066
2067 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2068
2069         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
2070         inner scope, add check that the objfile has psymtabs before
2071         checking psymtabs_addrmap.
2072         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
2073
2074 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2075
2076         * NEWS: Announce that Ada task names are now shown at more places,
2077         and between quotes (except in info task output).
2078         * gdb/ada-tasks.c (task_to_str): New function.
2079         (display_current_task_id): Call task_to_str.
2080         (task_command_1): Likewise.
2081         (print_ada_task_info): In non-mi mode, Properly align headers and data
2082         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
2083
2084 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2085
2086         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
2087         prstatus.pr_lwp.pr_info instead of making it up.
2088
2089 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2090
2091         * auto-load.c (auto_load_expand_dir_vars): Update.
2092         * defs.h (gdb_datadir): Change to std::string.
2093         (python_libdir): Likewise.
2094         (relocate_gdb_directory): Change return type to std::string.
2095         * guile/guile.c (gdbscm_data_directory): Update.
2096         (initialize_scheme_side): Update.
2097         * jit.c (jit_reader_dir): Change to std::string.
2098         (jit_reader_load_command): Update.
2099         * main.c (gdb_datadir): Change to std::string.
2100         (python_libdir): Likewise.
2101         (set_gdb_data_directory): Update.
2102         (relocate_path): Change to return std::string.
2103         (relocate_gdb_directory): Change to return std::string.
2104         (relocate_gdbinit_path_maybe_in_datadir): Update.
2105         (captured_main_1): Update.
2106         * python/python.c (do_start_initialization): Update.
2107         * top.c (show_gdb_datadir): Update.
2108         * xml-syscall.c (xml_init_syscalls_info): Update.
2109         (init_syscalls_info): Update.
2110
2111 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2112
2113         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
2114         out of get_init_files.
2115         (get_init_files): Update.
2116
2117 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2118
2119         * main.c (get_init_files): Change to use std::string.
2120         (captured_main_1): Update.
2121         (print_gdb_help): Update.
2122
2123 2019-09-11  Ali Tamur  <tamur@google.com>
2124
2125         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
2126         implementation.
2127
2128 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
2129
2130         * dbxread.c (read_dbx_symtab): Update.
2131         * dwarf2read.c (load_partial_dies): Update.
2132         * mdebugread.c (parse_partial_symbols): Update.
2133         (handle_psymbol_enumerators): Update.
2134         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
2135         * psymtab.c (add_psymbol_to_bcache): Likewise.
2136         (add_psymbol_to_list): Likewise.
2137         * symtab.c (symbol_set_names): Likewise.
2138         * symtab.h (symbol_set_names): Likewise.
2139         * xcoffread.c (scan_xcoff_symtab): Update.
2140
2141 2019-09-11  Tom Tromey  <tom@tromey.com>
2142
2143         * symfile-mem.c (symbol_file_add_from_memory): Use
2144         bfd_set_filename.
2145         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
2146         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
2147
2148 2019-09-10  Tom Tromey  <tromey@adacore.com>
2149
2150         * dwarf-index-write.c (write_psymbols): Extend error message.
2151         (debug_names::insert): Add Ada code.
2152         (debug_names::write_psymbols): Remove Ada check.
2153         (debug_names) <m_string_obstack>: New member.
2154         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
2155         (gdb_index_symbol_name_matcher::matches): Remove.
2156         (mapped_index_base::find_name_components_bounds): Add "lang"
2157         parameter.
2158         (mapped_index_base::build_name_components): Also split names
2159         according to Ada syntax.
2160         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
2161         type of "match_callback".
2162         (check_match, check_find_bounds_finds)
2163         (dw2_expand_symtabs_matching): Update.
2164         (dw2_debug_names_iterator): Add new constructor.
2165         (dw2_debug_names_map_matching_symbols): New function.
2166         (dw2_debug_names_expand_symtabs_matching): Update.
2167         (dwarf2_debug_names_functions): Use
2168         dw2_debug_names_map_matching_symbols.
2169
2170 2019-09-10  Tom Tromey  <tromey@adacore.com>
2171
2172         * dwarf2read.c (dw2_get_file_names_reader): Add the
2173         CU's file name to the results.
2174
2175 2019-09-10  Tom Tromey  <tromey@adacore.com>
2176
2177         * ada-lang.c (add_nonlocal_symbols): Combine calls to
2178         map_matching_symbols.  Update.
2179         * dwarf2read.c (dw2_map_matching_symbols): Update.
2180         * psymtab.c (match_partial_symbol): Change type; update.
2181         (psym_map_matching_symbols): Likewise.
2182         * symfile-debug.c (debug_qf_map_matching_symbols): Change
2183         type; update.
2184         * symfile.h (struct quick_symbol_functions)
2185         <map_matching_symbols>: Change "name" to be a lookup_name_info.
2186         Remove "match".
2187
2188 2019-09-10  Tom Tromey  <tromey@adacore.com>
2189
2190         * psymtab.c (map_block): Remove.
2191         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
2192         * symtab.c (iterate_over_symbols_terminated): New function.
2193         * symtab.c (iterate_over_symbols_terminated): Declare.
2194
2195 2019-09-10  Tom Tromey  <tromey@adacore.com>
2196
2197         * ada-lang.c (ada_iterate_over_symbols): Return bool.
2198         * language.h (struct language_defn) <la_iterate_over_symbols>:
2199         Return bool.
2200         * symtab.c (iterate_over_symbols): Return bool.
2201         * symtab.h (iterate_over_symbols): Return bool.
2202
2203 2019-09-10  Tom Tromey  <tromey@adacore.com>
2204
2205         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
2206         (add_nonlocal_symbols): Update.
2207         * dwarf2read.c (dw2_map_matching_symbols): Change type.
2208         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
2209         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
2210         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
2211         Change type of "callback".  Remove "data".
2212
2213
2214 2019-09-09  Ali Tamur  <tamur@google.com>
2215
2216         * dwarf2read.c (comp_unit_head): Update comment.
2217         (dwarf2_dwo_name): New function declaration.
2218         (dwarf_unit_type_name): New function declaration.
2219         (read_comp_unit_head): Add support for new compilation units,
2220         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
2221         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
2222         (currently named as "signature") in their header. Also clarify error
2223         messages.
2224         (lookup_dwo_id): New function. Returns the dwo id of the given
2225         compile unit.
2226         (lookup_dwo_unit): Use the new lookup_dwo_id function.
2227         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
2228         functions.
2229         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
2230         (dwarf2_dwo_name): Get the dwo name if present.
2231         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
2232         purposes.
2233
2234 2019-09-09  Tom Tromey  <tom@tromey.com>
2235
2236         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
2237
2238 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2239
2240         * python/python.c (do_start_initialization): Make progname_copy static,
2241         to avoid a leak report.
2242
2243 2019-09-08  Tom Tromey  <tom@tromey.com>
2244
2245         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
2246
2247 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
2248
2249         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
2250         Change type to gdb::optional<block_enum>.
2251         (dw2_symtab_iter_init): Change block_index parameter type
2252         to gdb::optional<block_enum>.
2253         (dw2_lookup_symbol): Change block_index parameter
2254         type to block_enum.c
2255         (dw2_debug_names_lookup_symbol): Likewise.
2256         * psymtab.c (psym_lookup_symbol): Likewise.
2257         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
2258         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
2259         Likewise.
2260
2261 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
2262
2263         * defs.h (relocate_gdb_directory): Change int to bool in
2264         signature and rename flag to relocatable.
2265         * main.c (relocate_path): Likewise.
2266         (relocate_gdb_directory): Likewise.
2267
2268 2019-09-06  Alan Modra  <amodra@gmail.com>
2269
2270         * coffread.c (coff_symfile_read): Constify filename variable.
2271         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
2272         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
2273         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
2274         * solib.c (reload_shared_libraries_1): Likewise.
2275         * symfile.c (reread_symbols): Likewise.
2276         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
2277         * solib-darwin.c (darwin_bfd_open): Likewise.
2278         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
2279
2280 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
2281
2282         * psymtab.c (print_partial_symbols): Handle missing domain_enum
2283         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
2284
2285 2019-09-03  Tom Tromey  <tromey@adacore.com>
2286
2287         * ada-valprint.c (ada_val_print_num): Don't recurse for range
2288         types.
2289         (has_negatives): Unbias a range type bound.
2290         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
2291         * gdbtypes.c (operator==): Handle new field.
2292         (create_range_type): Add "bias" parameter.
2293         (create_static_range_type, resolve_dynamic_range): Update.
2294         * gdbtypes.h (struct range_bounds) <bias>: New member.
2295         (create_range_type): Add bias parameter.
2296         * printcmd.c (print_scalar_formatted): Unbias range types.
2297         * value.c (unpack_long): Unbias range types.
2298         (pack_long): Bias range types.
2299
2300 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2301
2302         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
2303         probe arguments.
2304
2305 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2306
2307         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
2308         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
2309         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
2310         (compile_probe_arg): Likewise.
2311         * probe.h (get_argument_count): Likewise.
2312         * solib-svr4.c (solib_event_probe_action): Likewise.
2313         * stap-probe.c (stap_probe::get_argument_count): Likewise.
2314
2315 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
2316
2317         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
2318         code to here...
2319         (svr4_create_solib_event_breakpoints): ...from here.
2320
2321 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
2322
2323         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
2324         suffix from warning message.
2325
2326 2019-08-30  Tom Tromey  <tom@tromey.com>
2327
2328         * tui/tui-winsource.h (struct tui_source_window_base)
2329         <refresh_all>: Don't declare.
2330         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
2331         Remove.
2332         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
2333         tui_show_locator_content.
2334         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
2335         declare.
2336         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
2337         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
2338         declare.
2339
2340 2019-08-30  Tom Tromey  <tom@tromey.com>
2341
2342         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
2343
2344 2019-08-30  Tom Tromey  <tom@tromey.com>
2345
2346         * tui/tui-stack.c (_initialize_tui_stack): Move later.
2347         Remove unnecessary forward declarations.
2348
2349 2019-08-30  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
2352         rerender.
2353         (tui_update_locator_fullname, tui_show_frame_info): Don't call
2354         tui_show_locator_content.
2355
2356 2019-08-30  Tom Tromey  <tom@tromey.com>
2357
2358         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
2359         (tui_locator_window::rerender): Rewrite using body of previous
2360         tui_show_locator_content.
2361
2362 2019-08-30  Tom Tromey  <tom@tromey.com>
2363
2364         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
2365         set_locator_fullname>: New methods.
2366         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
2367         Rename from tui_set_locator_fullname.
2368         (tui_locator_window::set_locator_info): Rename from
2369         tui_set_locator_info.  Return bool.
2370         (tui_update_locator_fullname, tui_show_frame_info): Update.
2371
2372 2019-08-30  Tom Tromey  <tom@tromey.com>
2373
2374         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
2375
2376 2019-08-30  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
2379         call touchwin.
2380
2381 2019-08-30  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-wingeneral.c (box_win): Assume win_info and
2384         win_info->handle cannot be NULL.
2385
2386 2019-08-30  Tom Tromey  <tom@tromey.com>
2387
2388         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
2389         refresh_window>: Declare.
2390         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
2391         resize.
2392         (tui_data_item_window::rerender): Rename from
2393         tui_display_register.
2394         (tui_data_item_window::refresh_window): New method.
2395         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
2396         no-op.
2397
2398 2019-08-30  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-regs.h (struct tui_data_window) <regs_content,
2401         regs_column_count, current_group>: Move later.  Now private.
2402         <get_current_group>: New method.
2403         * tui/tui-regs.c (tui_reg_command): Update.
2404         * tui/tui-layout.c (tui_set_layout): Update.
2405
2406 2019-08-30  Tom Tromey  <tom@tromey.com>
2407
2408         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2409         (tui_data_window::rerender): Don't call
2410         check_and_display_highlight_if_needed.
2411         (tui_data_window::refresh_all): Remove call to
2412         erase_data_content.
2413
2414 2019-08-30  Tom Tromey  <tom@tromey.com>
2415
2416         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
2417         (tui_data_window::display_registers_from)
2418         (tui_data_window::display_reg_element_at_line)
2419         (tui_data_window::display_registers_from_line): Remove checks of
2420         "empty".
2421
2422 2019-08-30  Tom Tromey  <tom@tromey.com>
2423
2424         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
2425         Don't declare.
2426         * tui/tui-regs.c (tui_data_window::show_registers): Call
2427         rerender.
2428         (tui_data_window::rerender): Rename from display_all_data.
2429         (tui_data_window::rerender): Remove old implementation.
2430
2431 2019-08-30  Tom Tromey  <tom@tromey.com>
2432
2433         * tui/tui-regs.c (tui_data_window::display_all_data): Change
2434         text.
2435         * tui/tui-data.h (NO_DATA_STRING): Remove define.
2436
2437 2019-08-29  Bernhard Wodok  <barto@gmx.net>
2438             Sergio Durigan Junior  <sergiodj@redhat.com>
2439
2440         PR win32/24284
2441         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
2442
2443 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2444
2445         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
2446         when searching for types.
2447
2448 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
2449
2450         * f-lang.c (f_language_defn): Use f_print_typedef.
2451         * f-lang.h (f_print_typedef): Declare.
2452         * f-typeprint.c (f_print_typedef): Define.
2453
2454 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
2455
2456         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
2457
2458 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
2459
2460         * cli/cli-utils.c (info_print_options_defs): Delete.
2461         (make_info_print_options_def_group): Delete.
2462         (extract_info_print_options): Delete.
2463         (info_print_command_completer): Delete.
2464         (info_print_args_help): Add extra parameter, and optionally
2465         include text about -n flag.
2466         * cli/cli-utils.h (struct info_print_options): Delete.
2467         (extract_info_print_options): Delete declaration.
2468         (info_print_command_completer): Delete declaration.
2469         (info_print_args_help): Add extra parameter, extend header
2470         comment.
2471         * python/python.c (gdbpy_rbreak): Pass additional parameter to
2472         search_symbols.
2473         * stack.c (struct info_print_options): New type.
2474         (info_print_options_defs): New file scoped variable.
2475         (make_info_print_options_def_group): New static function.
2476         (info_print_command_completer): New static function.
2477         (info_locals_command): Update to use new local functions.
2478         (info_args_command): Likewise.
2479         (_initialize_stack): Add extra parameter to calls to
2480         info_print_args_help.
2481         * symtab.c (search_symbols): Add extra parameter, use this to
2482         possibly excluse non-debug symbols.
2483         (symtab_symbol_info): Add extra parameter, which is passed on to
2484         search_symbols.
2485         (struct info_print_options): New type.
2486         (info_print_options_defs): New file scoped variable.
2487         (make_info_print_options_def_group): New static function.
2488         (info_print_command_completer): New static function.
2489         (info_variables_command): Update to use local functions, and pass
2490         extra parameter through to symtab_symbol_info.
2491         (info_functions_command): Likewise.
2492         (info_types_command): Pass additional argument through to
2493         symtab_symbol_info.
2494         (rbreak_command): Pass extra argument to search_symbols.
2495         (_initialize_symtab): Add extra arguments for calls to
2496         info_print_args_help, and update help text for 'info variables',
2497         'whereis', and 'info functions' commands.
2498         * symtab.h (search_symbols): Add extra argument to declaration.
2499         * NEWS: Mention new flags.
2500
2501 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
2502
2503         * symtab.c (lookup_static_symbol): Call the new function (and move
2504         it down to be next to lookup_global_symbol).
2505         (struct global_sym_lookup_data): Add block_enum member and rename to...
2506         (struct global_or_static_sym_lookup_data): ...this.
2507         (lookup_symbol_global_iterator_cb): Pass block_index instead of
2508         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
2509         (lookup_symbol_global_or_static_iterator_cb): ...this.
2510         (lookup_global_or_static_symbol): New function.
2511         (lookup_global_symbol): Call new function.
2512
2513 2019-08-26  Tom de Vries  <tdevries@suse.de>
2514
2515         PR c++/24852
2516         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
2517         when pc_probe.prob == NULL.
2518
2519 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2520
2521         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
2522         variable symbol_linkage to symbol_linkage_.
2523
2524 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
2525
2526         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
2527         represent whether the symbol is static, dynamic, or we don't
2528         know.
2529
2530 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
2531
2532         * gdb/rx-tdep.c (rx_register_names): New.
2533         (rx_register_name): Delete.
2534         (rx_psw_type): Delete.
2535         (rx_fpsw_type): Delete.
2536         (rx_register_type): Delete.
2537         (rx_gdbarch_init): Convert target-descriptions.
2538         (_initialize_rx_tdep): Add initialize_tdesc_rx.
2539         * gdb/features/Makefile: Add rx.xml.
2540         * gdb/features/rx.xml: New.
2541         * gdb/features/rx.c: Generated.
2542         * gdb/NEWS: Mention target description support.
2543
2544 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2545
2546         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
2547         *slot_ptr.
2548
2549 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
2550
2551         * configure.ac: Don't check for 'dlfcn.h' (moved to
2552         gdbsupport/common.m4).
2553         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2554         'gdbsupport/'.
2555         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2556         * compile/compile-c-support.c: Include
2557         'gdbsupport/gdb-dlfcn.h'.
2558         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2559         * gdb-dlfcn.c: Move to...
2560         * gdbsupport/gdb-dlfcn.c: ... here.
2561         * gdb-dlfcn.h: Move to...
2562         * gdbsupport/gdb-dlfcn.h: ... here.
2563
2564 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2565
2566         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2567         the offset field signed.
2568
2569 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2570
2571         * python/lib/gdb/__init__.py (_execute_file): New function.
2572         * python/python.c (python_run_simple_file): Call gdb._execute_file
2573         on Windows.
2574
2575 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2576
2577         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2578         all uses as this was never set to anything but a zero value.
2579
2580 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2581
2582         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2583
2584 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2585
2586         * tui/tui-data.h (tui_gen_win_info): Add an =default
2587         move constructor, required by some GCC versions.
2588
2589 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2590
2591         * go32-nat.c (go32_sysinfo): Add hygon_p.
2592
2593 2019-08-20  Tom Tromey  <tom@tromey.com>
2594
2595         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2596         line_from_reg_element_no, first_reg_element_no_inline,
2597         display_all_data, delete_data_content_windows,
2598         erase_data_content>: Now private.
2599
2600 2019-08-20  Tom Tromey  <tom@tromey.com>
2601
2602         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2603         (tui_unhighlight_win, tui_highlight_win)
2604         (tui_win_info::make_window): Update.
2605         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2606
2607 2019-08-20  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2610         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2611         (MAX_PID_WIDTH): Move to tui-stack.c.
2612         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2613         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2614         (MAX_PID_WIDTH): Move from tui-data.h.
2615
2616 2019-08-20  Tom Tromey  <tom@tromey.com>
2617
2618         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2619         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2620         (box_win): Update.
2621         (tui_gen_win_info::make_window): Rename from tui_make_window.
2622         (tui_win_info::make_window): New method.
2623         (tui_gen_win_info::make_visible): Update.
2624         * tui/tui-source.c (tui_source_window::set_contents): Update.
2625         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2626         (tui_data_window::display_registers_from): Update.
2627         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2628         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2629         Declare.
2630         <can_box>: Remove.
2631         <title>: Remove.
2632         (struct tui_win_info) <make_window>: Declare.
2633         <can_box>: Now virtual.
2634         <title>: New member.
2635         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2636         * tui/tui-command.c (tui_cmd_window::resize): Update.
2637
2638 2019-08-20  Tom Tromey  <tom@tromey.com>
2639
2640         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2641         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2642         (tui_data_window::check_register_values): Update.
2643
2644 2019-08-20  Tom Tromey  <tom@tromey.com>
2645
2646         * tui/tui-regs.h (struct tui_data_window): Use
2647         DISABLE_COPY_AND_ASSIGN.
2648         <regs_content>: Change type, removing unique_ptr.
2649         <tui_data_window>: Add move constructor.
2650         * tui/tui-regs.c (tui_data_window::show_registers)
2651         (tui_data_window::show_register_group)
2652         (tui_data_window::display_registers_from)
2653         (tui_data_window::display_registers_from)
2654         (tui_data_window::first_data_item_displayed)
2655         (tui_data_window::delete_data_content_windows)
2656         (tui_data_window::rerender, tui_data_window::refresh_window)
2657         (tui_data_window::check_register_values): Update.
2658
2659 2019-08-20  Tom Tromey  <tom@tromey.com>
2660
2661         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2662         show_register_group>: Declare.
2663         (tui_show_register_group): Don't declare.
2664         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2665         tui_show_registers.
2666         (tui_data_window::show_register_group): Rename from
2667         tui_show_register_group.
2668         (tui_data_window::check_register_values, tui_reg_command):
2669         Update.
2670         * tui/tui-layout.c (tui_set_layout): Update.
2671
2672 2019-08-20  Tom Tromey  <tom@tromey.com>
2673
2674         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2675         Declare.
2676         (tui_check_register_values): Don't declare.
2677         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2678         from tui_check_register_values.
2679         * tui/tui-hooks.c (tui_register_changed): Update.
2680
2681 2019-08-20  Tom Tromey  <tom@tromey.com>
2682
2683         * tui/tui-regs.c (tui_reg_layout): Move later.
2684         (tui_show_registers): Don't enable TUI mode or change layout.
2685
2686 2019-08-20  Tom Tromey  <tom@tromey.com>
2687
2688         * tui/tui-regs.h (struct tui_data_item_window)
2689         <~tui_data_item_window>: Remove.
2690         <content>: Now a unique_xmalloc_ptr.
2691         * tui/tui-regs.c (tui_register_format): Return a
2692         unique_xmalloc_ptr.
2693         (tui_get_register): Update.
2694         (~tui_data_item_window): Remove.
2695         (tui_data_window::display_registers_from, tui_display_register):
2696         Update.
2697         * tui/tui-io.h (tui_expand_tabs): Update.
2698         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2699         Remove "col" parameter.
2700
2701 2019-08-20  Tom Tromey  <tom@tromey.com>
2702
2703         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2704         field.
2705         * tui/tui-regs.c (~tui_data_item_window): Update.
2706
2707 2019-08-20  Tom Tromey  <tom@tromey.com>
2708
2709         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2710         earlier.
2711
2712 2019-08-20  Tom Tromey  <tom@tromey.com>
2713
2714         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2715
2716 2019-08-20  Tom Tromey  <tom@tromey.com>
2717
2718         * tui/tui-source.h (struct tui_source_window): Update.
2719         * tui/tui-regs.c (tui_show_registers): Update.
2720         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2721         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2722         (NO_REGS_STRING): Remove defines.
2723
2724 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2725
2726         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2727         unnecessary thread walk if remote doesn't support the packet.
2728
2729 2019-08-19  Tom Tromey  <tromey@adacore.com>
2730
2731         * python/py-value.c (value_has_field): Fix indentation.
2732
2733 2019-08-19  Tom Tromey  <tromey@adacore.com>
2734
2735         * printcmd.c (do_one_display, info_display_command): Update.
2736         * block.h (contained_in): Return bool.  Add allow_nested
2737         parameter.
2738         * block.c (contained_in): Return bool.  Add allow_nested
2739         parameter.
2740
2741 2019-08-19  Tom Tromey  <tom@tromey.com>
2742
2743         * configure: Rebuild.
2744         * configure.ac: Disallow the combination of -static-libstdc++ and
2745         source highlight.
2746         * source-cache.c (get_language_name): Handle rust.
2747         (source_cache::get_source_lines): Ignore highlighting exceptions.
2748
2749 2019-08-16  Tom Tromey  <tom@tromey.com>
2750
2751         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2752         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2753         (struct tui_source_window_base) <make_visible, refresh_window,
2754         resize>: Remove methods.
2755         <execution_info>: Remove field.
2756         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2757         (tui_show_source_line, tui_source_window_base)
2758         (~tui_source_window_base): Update.
2759         (tui_source_window_base::resize)
2760         (tui_source_window_base::make_visible)
2761         (tui_source_window_base::refresh_window): Remove.
2762         (tui_source_window_base::update_exec_info): Update.
2763         * tui/tui-source.c (tui_source_window::set_contents): Update.
2764         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2765
2766 2019-08-16  Tom Tromey  <tom@tromey.com>
2767
2768         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2769         deprecated_query_hook.
2770
2771 2019-08-16  Tom Tromey  <tom@tromey.com>
2772
2773         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2774         (tui_update_source_windows_with_line): Update.
2775         * tui/tui-source.h (struct tui_source_window)
2776         <show_symtab_source>: Declare.
2777         (tui_show_symtab_source): Don't declare.
2778         * tui/tui-source.c (tui_show_symtab_source): Rename from
2779         tui_show_symtab_source.
2780
2781 2019-08-16  Tom Tromey  <tom@tromey.com>
2782
2783         * tui/tui-winsource.h (struct tui_source_window_base)
2784         <set_contents>: Declare.
2785         * tui/tui-winsource.c
2786         (tui_source_window_base::update_source_window_as_is): Update.
2787         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2788         Declare.
2789         (tui_set_source_content): Don't declare.
2790         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2791         tui_set_source_content.
2792         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2793         Declare.
2794         (tui_set_disassem_content): Don't declare.
2795         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2796         tui_set_disassem_content.
2797
2798 2019-08-16  Tom Tromey  <tom@tromey.com>
2799
2800         * tui/tui-winsource.h (struct tui_source_window_base)
2801         <update_breakpoint_info>: Declare.
2802         (tui_update_breakpoint_info): Don't declare.
2803         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2804         (tui_update_all_breakpoint_info): Update.
2805         (tui_source_window_base::update_breakpoint_info): Rename from
2806         tui_update_breakpoint_info.
2807         (tui_source_window_base::update_exec_info): Update.
2808
2809 2019-08-16  Tom Tromey  <tom@tromey.com>
2810
2811         * tui/tui-winsource.h (struct tui_source_window_base)
2812         <update_source_window>: Declare.
2813         (tui_update_source_window): Don't declare.
2814         * tui/tui-winsource.c
2815         (tui_source_window_base::update_source_window): Rename from
2816         tui_update_source_window.
2817         (tui_source_window_base::rerender): Update.
2818         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2819         * tui/tui-disasm.c (tui_show_disassem)
2820         (tui_show_disassem_and_update_source)
2821         (tui_disasm_window::maybe_update): Update.
2822
2823 2019-08-16  Tom Tromey  <tom@tromey.com>
2824
2825         * tui/tui-winsource.h (struct tui_source_window_base)
2826         <update_source_window_as_is>: Declare.
2827         (tui_update_source_window_as_is): Don't declare.
2828         * tui/tui-winsource.c (tui_update_source_window): Update
2829         (tui_source_window_base::update_source_window_as_is): Rename from
2830         tui_update_source_window_as_is.
2831         (tui_source_window_base::refill): Update.
2832         * tui/tui-source.c (tui_show_symtab_source): Update.
2833         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2834         Update.
2835
2836 2019-08-16  Tom Tromey  <tom@tromey.com>
2837
2838         * tui/tui-winsource.h (tui_update_source_window)
2839         (tui_update_source_window_as_is): Remove "noerror" parameter.
2840         * tui/tui-winsource.c (tui_update_source_window)
2841         (tui_update_source_window_as_is): Remove "noerror" parameter.
2842         (tui_update_source_windows_with_addr)
2843         (tui_update_source_windows_with_line)
2844         (tui_source_window_base::rerender)
2845         (tui_source_window_base::refill): Update.
2846         * tui/tui-source.h (tui_set_source_content)
2847         (tui_show_symtab_source): Remove "noerror" parameter.
2848         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2849         parameter.
2850         (tui_show_symtab_source): Likewise.
2851         (tui_source_window::maybe_update): Update.
2852         * tui/tui-disasm.c (tui_show_disassem)
2853         (tui_show_disassem_and_update_source)
2854         (tui_disasm_window::do_scroll_vertical)
2855         (tui_disasm_window::maybe_update): Update.
2856
2857 2019-08-16  Tom Tromey  <tom@tromey.com>
2858
2859         * tui/tui.c (tui_is_window_visible): Update.
2860         * tui/tui-wingeneral.c (tui_make_window)
2861         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2862         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2863         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2864         (tui_set_win_height_command, parse_scrolling_args): Update.
2865         * tui/tui-source.c (tui_source_window::style_changed): Update.
2866         * tui/tui-regs.c (tui_show_registers)
2867         (tui_data_window::first_data_item_displayed)
2868         (tui_data_window::delete_data_content_windows)
2869         (tui_check_register_values, tui_reg_command): Update.
2870         * tui/tui-disasm.c (tui_show_disassem): Update.
2871         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2872         method.
2873         <is_visible>: Remove field.
2874         * tui/tui-data.c (tui_next_win, tui_prev_win)
2875         (tui_delete_invisible_windows): Update.
2876
2877 2019-08-16  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-winsource.h (struct tui_source_window_base)
2880         <m_has_locator>: Remove.
2881         * tui/tui-layout.c (show_source_disasm_command, show_data)
2882         (show_source_or_disasm_and_command): Update.
2883
2884 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2885
2886         * NEWS (Other MI changes): New subsection.
2887         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2888         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2889         * arch-utils.c (default_get_pc_address_flags): New function.
2890         * arch-utils.h (default_get_pc_address_flags): New declaration.
2891         * gdbarch.sh: Add get_pc_address_flags.
2892         * gdbarch.c: Regenerate.
2893         * gdbarch.h: Likewise.
2894         * stack.c (print_pc): New function.
2895         (print_frame_info) (print_frame): Call print_pc.
2896
2897 2019-08-16  Tom de Vries  <tdevries@suse.de>
2898
2899         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2900         print_objfile_section_info.
2901
2902 2019-08-15  Tom Tromey  <tom@tromey.com>
2903
2904         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2905         calling update_cmdwin_start_line.
2906         * tui/tui-winsource.h (struct tui_source_window_base)
2907         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2908         <rerender>: Declare.
2909         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2910         Call rerender.
2911         (tui_source_window_base::set_new_height): Remove.
2912         (tui_source_window_base::rerender): Rename from
2913         do_make_visible_with_new_height.
2914         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2915         resize method.
2916         (tui_win_info::make_invisible_and_set_new_height)
2917         (tui_win_info::make_visible_with_new_height): Remove.
2918         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2919         Declare.
2920         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2921         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2922         do_make_visible_with_new_height>: Don't declare.
2923         <rerender>: Declare.
2924         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2925         set_new_height.
2926         (tui_data_window::do_make_visible_with_new_height): Remove.
2927         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2928         call tui_show_locator_content.
2929         (tui_gen_win_info::resize): Call rerender.
2930         (show_source_or_disasm_and_command): Don't call
2931         tui_show_locator_content.
2932         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2933         method.
2934         (struct tui_win_info) <rerender>: Declare.
2935         <set_new_height, make_invisible_and_set_new_height,
2936         make_visible_with_new_height>: Don't declare.
2937         * tui/tui-data.c (tui_win_list::rerender): New method.
2938         * tui/tui-command.h (struct tui_cmd_window)
2939         <do_make_visible_with_new_height>: Don't declare.
2940         * tui/tui-command.c
2941         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2942
2943 2019-08-15  Tom Tromey  <tromey@adacore.com>
2944
2945         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2946         * ada-lang.c (ada_enum_name): Likewise.
2947
2948 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2949
2950         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2951         leading underscore.
2952         (GdbOutputErrorFile): Likewise.
2953         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2954         accordingly.
2955         (execute_unwinders): Rename to have a leading underscore.
2956         (auto_load_packages): Likewise.
2957         (global scope): Adjust call to auto_load_packages accordingly.
2958         (GdbSetPythonDirectory): Likewise.
2959         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2960         instead of execute_unwinders.
2961
2962 2019-08-15  Tom Tromey  <tom@tromey.com>
2963
2964         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2965         (show_data): Don't change window visibility.
2966         (tui_gen_win_info::resize): Remove special case for command
2967         window.  Use wresize, when available.
2968         (show_source_or_disasm_and_command): Don't change window
2969         visibility.
2970         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2971         <make_visible>: New method.
2972         * tui/tui-command.c (tui_cmd_window::resize): New method.
2973
2974 2019-08-15  Tom Tromey  <tom@tromey.com>
2975
2976         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2977         (struct tui_source_windows): New.
2978         * tui/tui-winsource.c (tui_display_main): Update.
2979         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2980         (new_height_ok, parse_scrolling_args): Update.
2981         * tui/tui-layout.c (show_layout, show_data): Update.
2982         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2983         (tui_add_to_source_windows): Don't declare.
2984         * tui/tui-data.c (source_windows, tui_source_windows)
2985         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2986
2987 2019-08-15  Tom Tromey  <tom@tromey.com>
2988
2989         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2990         Rename from reset.
2991         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2992         * tui/tui-layout.c (show_source_disasm_command, show_data):
2993         Update.
2994         (tui_gen_win_info::resize): Rename.
2995         (show_source_or_disasm_and_command): Update.
2996         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2997         reset.
2998
2999 2019-08-15  Tom Tromey  <tom@tromey.com>
3000
3001         * tui/tui-stack.c (tui_initialize_static_data): Remove.
3002         * tui/tui-interp.c (tui_interp::init): Don't call
3003         tui_initialize_static_data.
3004         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
3005
3006 2019-08-15  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
3009         examine tui_win_list.
3010
3011 2019-08-15  Tom Tromey  <tom@tromey.com>
3012
3013         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
3014         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
3015         tui_clear_source_content.
3016         (tui_clear_source_content): Remove.
3017         (tui_source_window_base::do_erase_source_content): Hoist call to
3018         content.clear().
3019         * tui/tui-stack.c (tui_show_frame_info): Don't call
3020         tui_clear_source_content.
3021
3022 2019-08-15  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-winsource.h (struct tui_source_window_base)
3025         <do_erase_source_content>: New method.
3026         <erase_source_content>: New method.
3027         (tui_erase_source_content): Don't declare.
3028         * tui/tui-winsource.c (tui_clear_source_content): Update.
3029         (tui_source_window_base::do_erase_source_content): Rename from
3030         tui_erase_source_content.
3031         (tui_source_window_base::show_source_content): Update.
3032         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3033         * tui/tui-source.h (struct tui_source_window)
3034         <erase_source_content>: New method.
3035         * tui/tui-disasm.h (struct tui_disasm_window)
3036         <erase_source_content>: New method.
3037
3038 2019-08-15  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
3041         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
3042         constructor.
3043         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
3044         * tui/tui-source.c (tui_set_source_content): Update.
3045         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3046
3047 2019-08-15  Tom Tromey  <tom@tromey.com>
3048
3049         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
3050         * tui/tui-winsource.c (tui_line_is_displayed): Move to
3051         tui-source.c.
3052         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
3053         Declare.
3054         * tui/tui-source.c (tui_source_window::line_is_displayed): New
3055         method.
3056         (tui_source_window::maybe_update): Update.
3057
3058 2019-08-15  Tom Tromey  <tom@tromey.com>
3059
3060         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
3061         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
3062         tui-disasm.c.
3063         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
3064         Declare.
3065         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
3066         method.
3067         (tui_disasm_window::maybe_update): Update.
3068
3069 2019-08-15  Tom Tromey  <tom@tromey.com>
3070
3071         * tui/tui-winsource.h (struct tui_source_window_base)
3072         <maybe_update>: Declare.
3073         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
3074         method.
3075         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
3076         Declare.
3077         * tui/tui-source.c (tui_source_window::maybe_update): New method.
3078         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
3079         Declare.
3080         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
3081
3082 2019-08-15  Tom Tromey  <tom@tromey.com>
3083
3084         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
3085
3086 2019-08-15  Tom Tromey  <tom@tromey.com>
3087
3088         * tui/tui-wingeneral.c: Include tui-stack.h.
3089         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
3090         (struct tui_locator_window): Move from tui-data.h.
3091         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
3092         (tui_initialize_static_data): Move from tui-data.c.
3093         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
3094         (struct tui_locator_window): Move to tui-stack.c.
3095         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
3096         (tui_initialize_static_data): Move to tui-stack.c.
3097
3098 2019-08-15  Tom Tromey  <tom@tromey.com>
3099
3100         * tui/tui-layout.c (show_source_disasm_command)
3101         (show_source_or_disasm_and_command): Use make_visible method, not
3102         tui_make_window.
3103         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
3104         Remove.
3105
3106 2019-08-15  Tom Tromey  <tom@tromey.com>
3107
3108         * tui/tui-wingeneral.h (tui_make_window): Update.
3109         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
3110         parameter.
3111         (tui_gen_win_info::make_visible): Update.
3112         * tui/tui-regs.c (tui_data_window::display_registers_from):
3113         Update.
3114         * tui/tui-layout.c (show_source_disasm_command)
3115         (show_source_or_disasm_and_command): Update.
3116         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
3117         (enum tui_box): Remove.
3118         (struct tui_win_info) <can_box>: New method.
3119         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
3120         method.
3121
3122 2019-08-15  Tom de Vries  <tdevries@suse.de>
3123
3124         * linux-nat-trad.c: Include gdbarch.h.
3125
3126 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
3127
3128         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
3129         register sizes.
3130
3131 2019-08-14  Tom Tromey  <tromey@adacore.com>
3132
3133         * darwin-nat.c: Include gdbarch.h.
3134         * darwin-nat-info.c: Include gdbarch.h.
3135
3136 2019-08-13  Tom Tromey  <tom@tromey.com>
3137
3138         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
3139         Remove.
3140         * tui/tui-data.c (tui_initialize_static_data): Update.
3141
3142 2019-08-13  Tom Tromey  <tom@tromey.com>
3143
3144         * tui/tui-winsource.h (struct tui_exec_info_window)
3145         <~tui_exec_info_window, maybe_allocate_content, get_content,
3146         m_content>: Remove.
3147         (struct tui_source_window_base) <set_exec_info_content,
3148         show_exec_info_content>: Don't declare.
3149         * tui/tui-winsource.c
3150         (tui_exec_info_window::maybe_allocate_content): Remove.
3151         (tui_source_window_base::update_exec_info): Rename from
3152         set_exec_info_content.
3153         (tui_source_window_base::show_exec_info_content)
3154         (tui_source_window_base::update_exec_info): Remove.
3155
3156 2019-08-13  Tom Tromey  <tom@tromey.com>
3157
3158         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
3159         declare.
3160         * tui/tui-winsource.c (tui_update_source_window_as_is)
3161         (tui_update_source_windows_with_addr, tui_erase_source_content):
3162         Update.
3163         (tui_clear_exec_info_content): Remove.
3164
3165 2019-08-13  Tom Tromey  <tom@tromey.com>
3166
3167         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
3168         declare.
3169         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
3170         call tui_erase_exec_info_content.
3171         (tui_clear_exec_info_content): Rename from
3172         tui_erase_exec_info_content.
3173         (tui_clear_exec_info_content): Delete.
3174
3175 2019-08-13  Tom Tromey  <tom@tromey.com>
3176
3177         * tui/tui-winsource.h (struct tui_source_window_base)
3178         <show_exec_info_content>: Declare.
3179         (tui_show_exec_info_content): Don't declare.
3180         * tui/tui-winsource.c
3181         (tui_source_window_base::show_exec_info_content): Rename from
3182         tui_show_exec_info_content.
3183         (tui_source_window_base::update_exec_info): Update.
3184
3185 2019-08-13  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
3188         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
3189         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
3190         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
3191         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
3192         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
3193         ... here.
3194
3195 2019-08-13  Tom Tromey  <tom@tromey.com>
3196
3197         * tui/tui-winsource.h (struct tui_source_window_base)
3198         <update_exec_info>: Declare.
3199         (tui_update_exec_info): Don't declare.
3200         * tui/tui-winsource.c (tui_update_source_window_as_is)
3201         (tui_source_window_base::refresh_all)
3202         (tui_update_all_breakpoint_info): Update.
3203         (tui_source_window_base::update_exec_info): Rename from
3204         tui_update_exec_info.
3205         * tui/tui-stack.c (tui_show_frame_info): Update.
3206
3207 2019-08-13  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-winsource.h (struct tui_source_window_base)
3210         <set_exec_info_content>: Declare.
3211         (tui_set_exec_info_content): Don't declare.
3212         * tui/tui-winsource.c
3213         (tui_source_window_base::set_exec_info_content): Rename from
3214         tui_set_exec_info_content.
3215         (tui_update_exec_info): Update.
3216
3217 2019-08-13  Tom Tromey  <tom@tromey.com>
3218
3219         * tui/tui-winsource.h (struct tui_source_window_base)
3220         <show_source_content>: Declare.
3221         (tui_show_source_content): Don't declare.
3222         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3223         (tui_source_window_base::show_source_content): Rename from
3224         tui_show_source_content.
3225         (tui_source_window_base::refresh_all): Update.
3226         * tui/tui-layout.c (show_source_disasm_command)
3227         (show_source_or_disasm_and_command): Update.
3228
3229 2019-08-13  Tom Tromey  <tom@tromey.com>
3230
3231         * tui/tui-winsource.c (tui_erase_source_content)
3232         (tui_show_source_content, tui_source_window_base::refresh_all):
3233         Update.
3234         * tui/tui-wingeneral.h
3235         (tui_check_and_display_highlight_if_needed): Don't declare.
3236         * tui/tui-wingeneral.c
3237         (tui_win_info::check_and_display_highlight_if_needed): Rename from
3238         check_and_display_highlight_if_needed.
3239         * tui/tui-win.c (tui_rehighlight_all)
3240         (tui_win_info::make_visible_with_new_height): Update.
3241         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
3242         (tui_data_window::erase_data_content)
3243         (tui_data_window::display_all_data): Update.
3244         * tui/tui-data.h (struct tui_win_info)
3245         <check_and_display_highlight_if_needed>: Declare.
3246
3247 2019-08-13  Tom Tromey  <tom@tromey.com>
3248
3249         * tui/tui-win.c (tui_resize_all): Call
3250         tui_delete_invisible_windows.
3251         * tui/tui-layout.c (show_layout): Call
3252         tui_delete_invisible_windows.
3253         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
3254         * tui/tui-data.c (tui_delete_invisible_windows): New function.
3255
3256 2019-08-13  Tom Tromey  <tom@tromey.com>
3257
3258         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
3259         tui_add_win_to_layout.
3260
3261 2019-08-13  Tom Tromey  <tom@tromey.com>
3262
3263         * tui/tui-layout.h (tui_default_win_height): Don't declare.
3264         * tui/tui-layout.c (tui_default_win_height): Now static.
3265
3266 2019-08-13  Tom Tromey  <tom@tromey.com>
3267
3268         * tui/tui-layout.c (show_layout): Unify all layout cases into a
3269         single switch.
3270         (show_source_disasm_command, show_source_or_disasm_and_command):
3271         Don't check current layout.
3272
3273 2019-08-13  Tom Tromey  <tom@tromey.com>
3274
3275         * tui/tui-wingeneral.c (make_all_visible): Remove.
3276         (tui_make_all_invisible): Simplify.
3277         * tui/tui-layout.c (tui_make_all_invisible): Move from
3278         tui-wingeneral.c; simplify.
3279         (show_layout): Hoist call to tui_make_all_invisible.
3280         (show_data): Don't call tui_make_all_invisible.
3281
3282 2019-08-13  Tom Tromey  <tom@tromey.com>
3283
3284         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
3285         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
3286
3287 2019-08-13  Tom Tromey  <tom@tromey.com>
3288
3289         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
3290         tui-data.c.
3291         (show_source_disasm_command, show_data)
3292         (show_source_or_disasm_and_command): Don't use
3293         tui_set_current_layout_to.
3294         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
3295         * tui/tui-data.c (current_layout, tui_current_layout): Move to
3296         tui-layout.c.
3297         (tui_set_current_layout_to): Remove.
3298
3299 2019-08-13  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-layout.c (tui_set_layout): Update.
3302         * tui/tui-data.h (struct tui_layout_def): Remove.
3303         (tui_layout_def): Don't declare.
3304         * tui/tui-data.c (layout_def): Remove.
3305         (tui_layout_def): Remove.
3306
3307 2019-08-13  Tom Tromey  <tom@tromey.com>
3308
3309         * tui/tui-winsource.h (struct tui_source_window_base)
3310         <clear_detail>: No longer "override".
3311         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
3312         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
3313         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
3314         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
3315         Remove.
3316         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
3317
3318 2019-08-13  Tom Tromey  <tromey@adacore.com>
3319
3320         * tracepoint.c: Don't include readline.h or history.h.
3321
3322 2019-08-12  Tom Tromey  <tom@tromey.com>
3323
3324         * configure: Rebuild.
3325         * configure.ac: Check for readline 7.
3326         * NEWS: Mention readline 7 requirement.
3327         * README: Update.
3328
3329 2019-08-12  Tom Tromey  <tom@tromey.com>
3330
3331         * mingw-hdep.c (gdb_select): Remove readline hack.
3332
3333 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
3334
3335         * blockframe.c (find_pc_partial_function): Set *block to nullptr
3336         when the function fails.
3337
3338 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
3339
3340         * s390-tdep.c (s390_type_align): New function.
3341         (s390_gdbarch_init): Set it as type_align gdbarch method.
3342
3343 2019-08-09  Tom de Vries  <tdevries@suse.de>
3344
3345         PR gdb/24591
3346         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
3347         pc_low with relocation offset.
3348
3349 2019-08-07  Tom Tromey  <tromey@adacore.com>
3350
3351         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3352         (print_frame_args): Update.
3353         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
3354         Update.
3355         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3356         * frame.h (struct frame_arg): Add initializers.
3357         <error>: Now a unique_xmalloc_ptr.
3358
3359 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
3360
3361         * NEWS: Expand the Pointer Authentication entry.
3362         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
3363         (aarch64_frame_unmask_lr): ... to this.
3364         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
3365         Call aarch64_frame_unmask_lr.
3366         * frame.c (struct frame_info): Add "masked" variable.
3367         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
3368         (fprint_frame): Check for masked pc.
3369         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
3370         declarations.
3371         * python/py-framefilter.c (py_print_frame): Check for masked pc.
3372         * stack.c (print_frame): Check for masked pc.
3373
3374 2019-08-06  Tom Tromey  <tom@tromey.com>
3375
3376         * stabsread.c (patch_block_stabs, read_one_struct_field)
3377         (read_enum_type): Use obstack_strndup.
3378         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
3379         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
3380         * dwarf2read.c (guess_full_die_structure_name)
3381         (anonymous_struct_prefix): Use obstack_strndup.
3382         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
3383         * c-exp.y (yylex): Use obstack_strndup.
3384         * ada-exp.y (write_object_renaming, write_ambiguous_var)
3385         (write_var_or_type): Use obstack_strndup.
3386
3387 2019-08-06  Tom Tromey  <tom@tromey.com>
3388
3389         * symfile.c (reread_symbols): Use obstack_strdup.
3390         * stabsread.c (read_type): Use obstack_strdup.
3391         * gdb_obstack.h (obstack_strdup): New overload.
3392         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
3393         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
3394         (dwarf2_canonicalize_name): Use obstack_strdup.
3395         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
3396         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
3397         Use obstack_strdup.
3398
3399 2019-08-06  Tom Tromey  <tom@tromey.com>
3400
3401         * gdb_obstack.h (obstack_strdup): Define.
3402         * gdb_obstack.c (obstack_strdup): Don't define.
3403
3404 2019-08-06  Tom Tromey  <tom@tromey.com>
3405
3406         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
3407         obstack_strdup.
3408         * typeprint.c (typedef_hash_table::find_global_typedef): Use
3409         obstack_strdup.
3410         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
3411         * stabsread.c (common_block_start): Use obstack_strdup.
3412         * objfiles.c (set_objfile_main_name, objfile): Use
3413         obstack_strdup.
3414         * namespace.c (add_using_directive): Use obstack_strdup.
3415         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
3416         * jit.c (finalize_symtab): Use obstack_strdup.
3417         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
3418         (guess_partial_die_structure_name, partial_die_info::fixup)
3419         (dwarf2_name): Use obstack_strdup.
3420         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
3421         obstack_strdup.
3422         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
3423         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
3424         obstack_strdup.
3425         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
3426
3427 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3428
3429         * unittests/help-doc-selftests.c: New file.
3430         * Makefile.in: Add the new file.
3431
3432 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3433
3434         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
3435         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
3436         the full first line, except when FOR_VALUE_PREFIX.  In this case,
3437         the trailing '.' is not output, and the first character is uppercased.
3438         (print_help_for_command): Update call to print_doc_line.
3439         (print_doc_of_command): Likewise.
3440         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
3441         * cli/cli-option.c (append_indented_doc): Do not append newline.
3442         (build_help_option): Append newline after first appended_indented_doc
3443         only if a second call is done.
3444         (build_help): Append 2 new lines before each option, except the first
3445         one.
3446         * compile/compile.c (_initialize_compile): Add new lines after
3447         %OPTIONS%, when not at the end of the help.
3448         Change help doc or code
3449         producing the help doc to respect the invariants.
3450         * maint-test-options.c (_initialize_maint_test_options): Likewise.
3451         Also removed the new line after 'Options:', as all other commands
3452         do not put an empty line between 'Options:' and the first option.
3453         * printcmd.c (_initialize_printcmd): Likewise.
3454         * stack.c (_initialize_stack): Likewise.
3455         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
3456         incorrectly telling COMMAND is optional.
3457         * ada-lang.c (_initialize_ada_language): Change help doc or code
3458         producing the help doc to respect the invariants.
3459         * ada-tasks.c (_initialize_ada_tasks): Likewise.
3460         * breakpoint.c (_initialize_breakpoint): Likewise.
3461         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
3462         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
3463         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
3464         * cli/cli-style.c (cli_style_option::add_setshow_commands,
3465         _initialize_cli_style): Likewise.
3466         * corelow.c (core_target_info): Likewise.
3467         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
3468         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
3469         * filesystem.c (_initialize_filesystem): Likewise.
3470         * frame.c (_initialize_frame): Likewise.
3471         * gnu-nat.c (add_task_commands): Likewise.
3472         * infcall.c (_initialize_infcall): Likewise.
3473         * infcmd.c (_initialize_infcmd): Likewise.
3474         * interps.c (_initialize_interpreter): Likewise.
3475         * language.c (_initialize_language): Likewise.
3476         * linux-fork.c (_initialize_linux_fork): Likewise.
3477         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
3478         * maint.c (_initialize_maint_cmds): Likewise.
3479         * memattr.c (_initialize_mem): Likewise.
3480         * printcmd.c (_initialize_printcmd): Likewise.
3481         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
3482         _RegEx): Likewise.
3483         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
3484         * record-btrace.c (_initialize_record_btrace): Likewise.
3485         * record-full.c (_initialize_record_full): Likewise.
3486         * record.c (_initialize_record): Likewise.
3487         * regcache-dump.c (_initialize_regcache_dump): Likewise.
3488         * regcache.c (_initialize_regcache): Likewise.
3489         * remote.c (add_packet_config_cmd, init_remote_threadtests,
3490         _initialize_remote): Likewise.
3491         * ser-tcp.c (_initialize_ser_tcp): Likewise.
3492         * serial.c (_initialize_serial): Likewise.
3493         * skip.c (_initialize_step_skip): Likewise.
3494         * source.c (_initialize_source): Likewise.
3495         * stack.c (_initialize_stack): Likewise.
3496         * symfile.c (_initialize_symfile): Likewise.
3497         * symtab.c (_initialize_symtab): Likewise.
3498         * target-descriptions.c (_initialize_target_descriptions): Likewise.
3499         * top.c (init_main): Likewise.
3500         * tracefile-tfile.c (tfile_target_info): Likewise.
3501         * tracepoint.c (_initialize_tracepoint): Likewise.
3502         * tui/tui-win.c (_initialize_tui_win): Likewise.
3503         * utils.c (add_internal_problem_command): Likewise.
3504         * valprint.c (value_print_option_defs): Likewise.
3505
3506 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
3507
3508         PR build/24886
3509         * configure.ac: Drop enable-libmcheck support.
3510         * configure, config.in: Rebuild.
3511         * libmcheck.m4: Remove.
3512         * acinclude.m4: Don't include it.
3513         * Makefile.in: Don't distribute it.
3514         * top.c (print_gdb_configuration): Don't mention it.
3515
3516 2019-08-06  Tom Tromey  <tom@tromey.com>
3517
3518         * utils.c (set_output_style): Sometimes pass stream to
3519         emit_style_escape.
3520         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
3521         * record-btrace.c (btrace_insn_history): Update.
3522         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
3523         method.
3524         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
3525         Update initializers.
3526         <m_uiout>: New field.
3527         <m_di>: Move lower.
3528         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3529         Remove "uiout" parameter.
3530         (dump_insns): Update.
3531         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
3532         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
3533
3534 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
3535
3536         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
3537         (error_in_psymtab_expansion): Likewise.
3538         (lookup_symbol_via_quick_fns): Likewise.
3539         (basic_lookup_transparent_type_quick): Likewise.
3540         (basic_lookup_transparent_type_1): Likewise.
3541
3542 2019-08-06  Tom Tromey  <tromey@adacore.com>
3543
3544         * source.c (last_source_error): Now bool.
3545         (print_source_lines_base): Make "noprint" bool.  Only open
3546         source file when last_source_visited changes.
3547
3548 2019-08-06  Tom Tromey  <tromey@adacore.com>
3549
3550         * annotate.c (annotate_source_line): Use g_source_cache.
3551         * source-cache.c (source_cache::get_plain_source_lines): Change
3552         parameters.  Populate m_offset_cache.
3553         (source_cache::ensure): New method.
3554         (source_cache::get_line_charpos): New method.
3555         (extract_lines): Move lower.  Change parameters.
3556         (source_cache::get_source_lines): Move lower.
3557         * source-cache.h (class source_cache): Update comment.
3558         <get_line_charpos>: New method.
3559         <get_source_lines>: Update comment.
3560         <clear>: Clear m_offset_cache.
3561         <get_plain_source_lines>: Change parameters.
3562         <ensure>: New method
3563         <m_offset_cache>: New member.
3564         * source.c (forget_cached_source_info_for_objfile): Update.
3565         (info_source_command): Use g_source_cache.
3566         (find_source_lines, open_source_file_with_line_charpos): Remove.
3567         (print_source_lines_base, search_command_helper): Use g_source_cache.
3568         * source.h (open_source_file_with_line_charpos): Don't declare.
3569         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3570         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3571         Use g_source_cache.
3572
3573 2019-08-06  Tom Tromey  <tromey@adacore.com>
3574
3575         * source-cache.c (source_cache::get_plain_source_lines):
3576         Remove "first_line" and "last_line" parameters.
3577         (source_cache::get_source_lines): Cache plain text.
3578         * source-cache.h (class source_cache)
3579         <get_plain_source_lines>: Update.
3580
3581 2019-08-06  Tom Tromey  <tromey@adacore.com>
3582
3583         * source-cache.c (extract_lines): No longer a method.
3584         Changed type of parameter.  Include final newline.
3585         (selftests::extract_lines_test): New function.
3586         (_initialize_source_cache): Likewise.
3587         * source-cache.h (class source_cache)
3588         <extract_lines>: Don't declare.
3589
3590 2019-08-06  Tom Tromey  <tromey@adacore.com>
3591
3592         * breakpoint.c (init_breakpoint_sal): Update.
3593         (breakpoint): Update.
3594         * breakpoint.h (struct breakpoint) <filter>: Now a
3595         unique_xmalloc_ptr.
3596
3597 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3598
3599         * NEWS: Mention dictionary access on blocks.
3600         * python/py-block.c (blpy_getitem): New function.
3601         (block_object_as_mapping): New struct.
3602         (block_object_type): Use new struct for tp_as_mapping field.
3603
3604 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3605
3606         * objfiles.h (objfile): Add a comment describing partial symbols.
3607
3608 2019-08-05  Tom Tromey  <tromey@adacore.com>
3609
3610         * compile/compile.c (_initialize_compile): Use _(), not N_().
3611         * thread.c (_initialize_thread): Use _(), not N_().
3612         * stack.c (_initialize_stack): Use _(), not N_().
3613         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3614
3615 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3616
3617         * dwarf2read.c (struct dw2_symtab_iterator):
3618         <want_specific_block>: Remove.
3619         <block_index>: Change type to gdb::optional.
3620         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3621         change type of BLOCK_INDEX parameter to gdb::optional.
3622         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3623         (dw2_lookup_symbol): Don't pass argument for
3624         WANT_SPECIFIC_BLOCK.
3625         (dw2_expand_symtabs_for_function): Don't pass argument for
3626         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3627         (class dw2_debug_names_iterator)
3628         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3629         parameter, change BLOCK_INDEX type to gdb::optional.
3630         <m_want_specific_block>: Remove.
3631         <m_block_index>: Change type to gdb::optional.
3632         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3633         gdb::optional.  Re-write in function of gdb::optional.
3634         (dw2_debug_names_lookup_symbol): Don't pass argument for
3635         WANT_SPECIFIC_BLOCK.
3636         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3637         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3638         BLOCK_INDEX.
3639
3640 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3641
3642         * NEWS: Mention changes to "info sources" command.
3643
3644 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3645
3646         * symtab.c (filename_partial_match_opts): New struct type.
3647         (struct output_source_filename_data): New members
3648         regexp, c_regexp, partial_match.
3649         (output_source_filename): Use new members to decide to print file.
3650         (info_sources_option_defs): New variable.
3651         (make_info_sources_options_def_group, print_info_sources_header,
3652         info_sources_command_completer):
3653         New functions.
3654         (info_sources_command): Read new optional arguments.
3655         (_initialize_symtab): Update info sources help.
3656
3657 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3658
3659         * ada-lang.c (exception_support_info_v0): Renamed from...
3660         (default_exception_support_info): ... this.  Create new
3661         definition for v1.
3662         (ada_has_this_exception_support): Look up catch_handlers_sym.
3663         (ada_exception_support_info_sniffer): Try v0 after default.
3664
3665 2019-08-01  Tom Tromey  <tromey@adacore.com>
3666
3667         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3668         gdbarch.h.
3669
3670 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3671
3672         * s12z-tdep.c: Fix include path for s12z-opc.h.
3673
3674 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3675
3676         * NEWS: Require GNU make 3.82.
3677
3678 2019-07-16  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3681         declare.
3682
3683 2019-07-30  Tom Tromey  <tromey@adacore.com>
3684
3685         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3686
3687 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3688
3689         * printcmd.c (print_address_symbolic): Print negative offsets.
3690         (build_address_symbolic): Force signed arithmetic when computing
3691         offset.
3692
3693 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3694
3695         PR/24474: Add a function to lookup static variables.
3696         * NEWS: Mention this new function.
3697         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3698         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3699         * python/python.c (python_GdbMethods): Add new function.
3700
3701 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3702
3703         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3704         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3705         (objfpy_lookup_static_symbol): New function.
3706         (objfile_object_methods): Add new functions.
3707
3708 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3709
3710         * NEWS: Mention 'set|show print frame-info'.  Mention new
3711         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3712         backtrace argument.  Mention that python frame filtering code
3713         is now consistent with what 'backtrace' command prints.
3714
3715 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3716
3717         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3718         comments.
3719         (print_frame_info_auto, print_frame_info_source_line,
3720         print_frame_info_location, print_frame_info_source_and_location,
3721         print_frame_info_location_and_address, print_frame_info_short_location):
3722         New declarations.
3723         (struct frame_print_options): New member print_frame_info.
3724         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3725         * stack.h (get_user_print_what_frame_info): New declaration.
3726         (frame_show_address): New declaration.
3727         * stack.c (print_frame_arguments_choices): New value 'presence'.
3728         (print_frame_info_auto, print_frame_info_source_line,
3729         print_frame_info_location, print_frame_info_source_and_location,
3730         print_frame_info_location_and_address, print_frame_info_short_location,
3731         print_frame_info_choices, print_frame_info_print_what): New definitions.
3732         (print_frame_args): Only print dots for args if print frame-arguments
3733         is 'presence'.
3734         (frame_print_option_defs): New element for "frame-info".
3735         (get_user_print_what_frame_info): New function.
3736         (frame_show_address): Make non static.  Move comment to stack.h.
3737         (print_frame_info_to_print_what): New function.
3738         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3739         to decide what to print.
3740         (backtrace_command_1): Handle the new print_frame_arguments_presence
3741         value.
3742         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3743         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3744         (py_print_frame): In non-mi mode, use LOCATION as default for
3745         print_what, similarly to frame information printed directly by
3746         backtrace command. Handle frame-info user option in non MI mode.
3747
3748 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3749
3750         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3751         Add case for debugging 32-bit target on 64-bit host.  Revise
3752         comment.
3753
3754 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3755
3756         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3757         instead of find_function_entry_range_from_pc.
3758
3759 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3760
3761         * stack.c (find_frame_funname): Remove code which preferred
3762         minsym over symtab sym in "certain pathological cases".
3763
3764         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3765         parameter.  Change type of "do_demangle" to bool.
3766         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3767         Pass suitable "prefer_sym_over_minsym" flag to
3768         build_address_symbolic().  Don't output "+" for negative offsets.
3769         * printcmd.c (print_address_symbolic): Update invocation of
3770         build_address_symbolic to include a "prefer_sym_over_minsym"
3771         flag.
3772         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3773         Restrict cases in which use of minimal symbol is preferred to that
3774         of a found symbol.  Update comments.
3775
3776         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3777         for entry pc when entry pc is out of range for that FDE.
3778
3779 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3780
3781         PR gdb/24839:
3782         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3783         type.
3784
3785 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3786
3787         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3788         this function's Python signature.
3789
3790
3791 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3792
3793         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3794         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3795         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3796         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3797         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3798
3799
3800 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3801
3802         * h8300-tdep.c (h8300_register_name_common): New.
3803         h8300_register_name): Use h8300_register_name_common.
3804         (h8300s_register_name): Likewise.
3805         (h8300sx_register_name): Likewise.
3806         (h8300h_register_nam): New.
3807         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3808
3809
3810 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3811
3812         * arm-tdep.c (arm_skip_cmse_entry): New function.
3813         (arm_is_sgstubs_section): New function.
3814         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3815
3816 2019-07-22  Tom Tromey  <tom@tromey.com>
3817
3818         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3819         Don't self-assign.
3820
3821 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3822
3823         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3824         type_print.
3825
3826 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3827
3828         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3829         so that GDB doesn't match any msymbols when searching in the
3830         TYPES_DOMAIN.
3831         (print_symbol_info): Print using typedef_print or type_print based
3832         on the type of the symbol.  Add updated FIXME comment moved from...
3833         (_initialize_symtab): ... move and update FIXME comment to above.
3834
3835 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3836
3837         * NEWS: Mention adding -q option to "info types".
3838         * symtab.c (struct info_types_options): New struct.
3839         (info_types_options_defs): New variable.
3840         (make_info_types_options_def_group): New function.
3841         (info_types_command): Use gdb::option framework to parse options.
3842         (info_types_command_completer): New function.
3843         (_initialize_symtab): Extend the help text on "info types" and
3844         register command completer.
3845
3846 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3847
3848         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3849         (lookup_symbol_in_objfile): Change int to block_enum and add a
3850         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3851
3852 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3853
3854         * MAINTAINERS (Write After Approval): Add self.
3855
3856 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3857
3858         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3859         instruction to the dummy code region.
3860
3861 2019-07-19  Tom Tromey  <tromey@adacore.com>
3862
3863         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3864         (ARGSUSED, PARAMS, __func__): Remove rules.
3865
3866 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3867
3868         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3869         * features/arm/arm-with-iwmmxt.c: Remove.
3870         * features/arm/arm-with-iwmmxt.xml: Remove.
3871         * features/arm/arm-with-m-fpa-layout.c: Remove.
3872         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3873         * features/arm/arm-with-m-vfp-d16.c: Remove.
3874         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3875         * features/arm/arm-with-m.c: Remove.
3876         * features/arm/arm-with-m.xml: Remove.
3877         * features/arm/arm-with-neon.c: Remove.
3878         * features/arm/arm-with-neon.xml: Remove.
3879         * features/arm/arm-with-vfpv2.c: Remove.
3880         * features/arm/arm-with-vfpv2.xml: Remove.
3881         * features/arm/arm-with-vfpv3.c: Remove.
3882         * features/arm/arm-with-vfpv3.xml: Remove.
3883
3884 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3885
3886         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3887
3888 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3889
3890         * arch/aarch32.c (aarch32_create_target_description): Create
3891         target descriptions using features.
3892         * arch/arm.c (arm_create_target_description)
3893         (arm_create_mprofile_target_description): Likewise.
3894         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3895
3896 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3897
3898         * Makefile.in: Add new files.
3899         * aarch32-tdep.c: New file.
3900         * aarch32-tdep.h: New file.
3901         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3902         Call aarch32_read_description.
3903         * arch/aarch32.c: New file.
3904         * arch/aarch32.h: New file.
3905         * arch/arm.c (arm_create_target_description)
3906         (arm_create_mprofile_target_description): New function.
3907         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3908         (arm_create_target_description)
3909         (arm_create_mprofile_target_description): New declaration.
3910         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3911         read_description functions.
3912         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3913         Likewise.
3914         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3915         * arm-tdep.c (tdesc_arm_list): New variable.
3916         (arm_register_g_packet_guesses): Call create description functions.
3917         (arm_read_description) (arm_read_mprofile_description): New
3918         function.
3919         * arm-tdep.h (arm_read_description)
3920         (arm_read_mprofile_description): Add declaration.
3921         * configure.tgt: Add new files.
3922
3923 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3924
3925         * top.c (new_ui_command): Open specified terminal just once.
3926
3927 2019-07-18  Tom Tromey  <tromey@adacore.com>
3928
3929         * symtab.c (main_name): Constify return type.
3930         * symfile.c (set_initial_language): Update.
3931         * symtab.h (main_name): Constify return type.
3932
3933 2019-07-17  Tom Tromey  <tom@tromey.com>
3934
3935         * tui/tui-winsource.c (tui_update_source_window)
3936         (tui_update_source_window_as_is)
3937         (tui_update_source_windows_with_line): Remove return.
3938         * tui/tui-disasm.c (tui_show_disassem)
3939         (tui_show_disassem_and_update_source): Remove return.
3940         * tui/tui.c (tui_reset): Remove return.
3941         * tui/tui-wingeneral.c
3942         (tui_check_and_display_highlight_if_needed): Remove return.
3943
3944 2019-07-17  Tom Tromey  <tom@tromey.com>
3945
3946         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3947
3948 2019-07-17  Tom Tromey  <tom@tromey.com>
3949
3950         * tui/tui-winsource.h (struct tui_exec_info_window)
3951         (struct tui_source_window_base): Move from tui-data.h.
3952         * tui/tui-winsource.c: Move many method definitions from
3953         elsewhere.  Remove "structuring" comments.
3954         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3955         (tui_source_window_base::refresh_window): Move to
3956         tui-winsource.c.
3957         * tui/tui-win.c (tui_source_window_base::refresh_all)
3958         (tui_source_window_base::update_tab_width)
3959         (tui_source_window_base::set_new_height)
3960         (tui_source_window_base::do_make_visible_with_new_height): Move to
3961         tui-winsource.c.
3962         * tui/tui-source.h: Update.
3963         * tui/tui-source.c (tui_source_window_base::reset): Move to
3964         tui-winsource.c.
3965         * tui/tui-disasm.h: Update.
3966         * tui/tui-data.h (struct tui_exec_info_window): Move to
3967         tui-winsource.h.
3968         (struct tui_source_window_base): Likewise.
3969         * tui/tui-data.c (tui_source_window_base::clear_detail)
3970         (tui_source_window_base, ~tui_source_window_base): Move to
3971         tui-winsource.c.
3972
3973 2019-07-17  Tom Tromey  <tom@tromey.com>
3974
3975         * tui/tui-win.c (tui_resize_all)
3976         (tui_source_window_base::update_tab_width)
3977         (tui_adjust_win_heights): Update.
3978         (tui_win_info::make_invisible_and_set_new_height): Rename from
3979         make_invisible_and_set_new_height.
3980         * tui/tui-data.h (struct tui_win_info)
3981         <make_invisible_and_set_new_height>: New method.
3982
3983 2019-07-17  Tom Tromey  <tom@tromey.com>
3984
3985         * tui/tui.c: Update.
3986         * tui/tui-source.h (struct tui_source_window): Move from
3987         tui-data.h.
3988         * tui/tui-layout.c: Update.
3989         * tui/tui-disasm.c: Update.
3990         * tui/tui-data.h (struct tui_source_window): Move to
3991         tui-source.h.
3992
3993 2019-07-17  Tom Tromey  <tom@tromey.com>
3994
3995         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3996         tui-data.h.
3997         * tui/tui-data.h (struct tui_disasm_window): Move to
3998         tui-disasm.h.
3999
4000 2019-07-17  Tom Tromey  <tom@tromey.com>
4001
4002         * tui/tui-regs.h (struct tui_data_item_window): Move from
4003         tui-data.h.
4004         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
4005         * tui/tui-data.h (struct tui_data_item_window): Move to
4006         tui-regs.h.
4007         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
4008
4009 2019-07-17  Tom Tromey  <tom@tromey.com>
4010
4011         * tui/tui.c: Update.
4012         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
4013         (tui_cmd_window::max_height): Move to tui-command.c.
4014         * tui/tui-layout.c: Update.
4015         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
4016         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
4017         tui-command.c.
4018         * tui/tui-command.h (struct tui_cmd_window): Move from
4019         tui-data.h.
4020         * tui/tui-command.c: Remove "structuring" comments.
4021         (tui_cmd_window::clear_detail)
4022         (tui_cmd_window::do_make_visible_with_new_height)
4023         (tui_cmd_window::max_height): Move from elsewhere.
4024
4025 2019-07-17  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
4028         Now static.
4029         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
4030         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
4031
4032 2019-07-17  Tom Tromey  <tom@tromey.com>
4033
4034         * tui/tui.c: Update.
4035         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
4036         tui-regs.c.
4037         * tui/tui-windata.h: Remove file.
4038         * tui/tui-windata.c: Remove file.
4039         * tui/tui-win.c (tui_data_window::set_new_height)
4040         (tui_data_window::do_make_visible_with_new_height): Move to
4041         tui-regs.c.
4042         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
4043         * tui/tui-regs.c: Remove "structuring" comments.
4044         (tui_data_window::first_data_item_displayed)
4045         (tui_data_window::delete_data_content_windows)
4046         (tui_data_window::erase_data_content)
4047         (tui_data_window::display_all_data)
4048         (tui_data_window::refresh_all)
4049         (tui_data_window::do_scroll_vertical)
4050         (tui_data_window::clear_detail, tui_data_window::set_new_height)
4051         (tui_data_window::do_make_visible_with_new_height)
4052         (tui_data_window::refresh_window): Move from elsewhere.
4053         (_initialize_tui_regs): Move to end of file.
4054         * tui/tui-layout.c: Update.
4055         * tui/tui-hooks.c: Update.
4056         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
4057         * tui/tui-data.c (tui_data_window::clear_detail): Move to
4058         tui-regs.c.
4059         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
4060
4061 2019-07-17  Tom Tromey  <tom@tromey.com>
4062
4063         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
4064         seen.
4065
4066 2019-07-17  Tom Tromey  <tom@tromey.com>
4067
4068         * tui/tui-win.c (tui_source_window_base::set_new_height)
4069         (tui_source_window_base::do_make_visible_with_new_height): Use
4070         m_has_locator field directly.
4071         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
4072         method.
4073         (struct tui_source_window_base) <has_locator>: Likewise.
4074
4075 2019-07-17  Tom Tromey  <tom@tromey.com>
4076
4077         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
4078         Don't declare.
4079         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
4080         Remove.
4081         * tui/tui-win.c (tui_source_window_base::set_new_height)
4082         (tui_source_window_base::set_new_height)
4083         (make_invisible_and_set_new_height)
4084         (tui_source_window_base::do_make_visible_with_new_height)
4085         (tui_source_window_base::do_make_visible_with_new_height):
4086         Update.
4087         * tui/tui-layout.c (show_source_disasm_command, show_data)
4088         (show_source_or_disasm_and_command): Update.
4089         * tui/tui-layout.c (show_layout): Update.
4090
4091 2019-07-17  Tom Tromey  <tom@tromey.com>
4092
4093         * tui/tui-layout.c (make_data_window): Remove.
4094         (show_data): Unify creation and re-initialization cases.
4095
4096 2019-07-17  Tom Tromey  <tom@tromey.com>
4097
4098         * tui/tui-layout.c (make_source_window, make_disasm_window):
4099         Remove.
4100         (show_data): Unify creation and re-initialization cases.
4101
4102 2019-07-17  Tom Tromey  <tom@tromey.com>
4103
4104         * tui/tui-layout.c (make_command_window): Remove.
4105         (show_source_disasm_command, show_source_or_disasm_and_command):
4106         Unify creation and re-initialization cases.
4107
4108 2019-07-17  Tom Tromey  <tom@tromey.com>
4109
4110         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
4111         creation and re-initialization cases.
4112
4113 2019-07-17  Tom Tromey  <tom@tromey.com>
4114
4115         * tui/tui-regs.c (tui_get_register): Return void.
4116
4117 2019-07-17  Tom Tromey  <tom@tromey.com>
4118
4119         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
4120         Simplify.
4121
4122 2019-07-17  Tom Tromey  <tom@tromey.com>
4123
4124         * tui/tui-layout.c (show_source_disasm_command): Simplify window
4125         resetting.
4126
4127 2019-07-17  Tom Tromey  <tom@tromey.com>
4128
4129         * tui/tui.h (tui_set_layout_by_name): Don't declare.
4130         * tui/tui-regs.c (tui_reg_layout): New function.
4131         (tui_show_registers, tui_reg_command): Use it.
4132         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
4133         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
4134         parameters.
4135         (tui_layout_command): Remove.
4136
4137 2019-07-17  Tom Tromey  <tom@tromey.com>
4138
4139         * tui/tui-layout.h (tui/tui-layout): Return void.
4140         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
4141
4142 2019-07-17  Tom Tromey  <tom@tromey.com>
4143
4144         * tui/tui-layout.c (show_source_disasm_command, show_data):
4145         Update.
4146         (reset_locator): Remove.
4147         (show_source_or_disasm_and_command): Update.
4148
4149 2019-07-17  Tom Tromey  <tom@tromey.com>
4150
4151         * tui/tui-source.c (tui_source_window_base::reset): Remove
4152         win_type parameter.
4153         * tui/tui-layout.c (make_command_window, make_source_window)
4154         (make_disasm_window, make_data_window)
4155         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
4156         (reset_locator, show_source_or_disasm_and_command): Update.
4157         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
4158         win_type parameter.
4159         (struct tui_source_window_base) <reset>: Likewise.
4160
4161 2019-07-17  Tom Tromey  <tom@tromey.com>
4162
4163         * tui/tui-layout.c (show_source_disasm_command): Use
4164         reset_locator.
4165         (reset_locator): New function.
4166         (init_and_make_win): Remove.
4167         (show_source_or_disasm_and_command): Use reset_locator.
4168
4169 2019-07-17  Tom Tromey  <tom@tromey.com>
4170
4171         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
4172         condition.
4173         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
4174         Remove condition.
4175         * tui/tui-source.c (tui_source_window_base::reset): New method.
4176         * tui/tui-layout.c (make_command_window): Don't call
4177         init_and_make_win.
4178         (make_source_window, make_disasm_window): Don't call
4179         make_source_or_disasm_window.
4180         (make_data_window): Don't call init_and_make_win.  Change calling
4181         convention.
4182         (show_source_disasm_command, show_data): Simplify.
4183         (make_source_or_disasm_window): Remove.
4184         (show_source_or_disasm_and_command): Simplify.
4185         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
4186         (struct tui_source_window_base) <reset>: Likewise.
4187         <execution_info>: Remove initializer.
4188         * tui/tui-data.c (tui_source_window_base): Initialize
4189         execution_info.
4190
4191 2019-07-17  Tom Tromey  <tom@tromey.com>
4192
4193         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
4194         variable.
4195
4196 2019-07-17  Tom Tromey  <tom@tromey.com>
4197
4198         * tui/tui.c (tui_rl_other_window): Update.
4199         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
4200         superclass method first.  Always iterate over regs_content.
4201         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
4202         method.
4203         * tui/tui-win.c (tui_set_focus_command): Update.
4204
4205 2019-07-17  Tom Tromey  <tom@tromey.com>
4206
4207         * tui/tui-win.c (tui_set_focus_command): Rename from
4208         tui_set_focus.  Call tui_enable.
4209         (tui_set_focus_command): Remove.
4210
4211 2019-07-17  Tom Tromey  <tom@tromey.com>
4212
4213         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
4214         refresh_window.
4215         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
4216         touchwin.
4217         (tui_data_window::refresh_window): Call refresh_window on data
4218         items.  Always call superclass refresh_window.
4219         (tui_win_info::refresh): Remove.
4220         (tui_source_window_base::refresh_window): Update.
4221         (tui_refresh_all): Update.
4222         * tui/tui-layout.c (show_source_disasm_command): Remove call to
4223         refresh_window.
4224         (show_source_or_disasm_and_command): Likewise.
4225         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
4226         (struct tui_source_window_base) <refresh>: Likewise.
4227
4228 2019-07-17  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-winsource.c (tui_clear_source_content)
4231         (tui_show_source_content): Update.
4232         * tui/tui-source.c (tui_source_window::showing_source_p): Check
4233         whether content is empty.
4234         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
4235         Remove.
4236
4237 2019-07-17  Tom Tromey  <tom@tromey.com>
4238
4239         * tui/tui-winsource.c (tui_erase_source_content): Clear the
4240         window's contents.
4241         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
4242         * tui/tui-source.c (tui_set_source_content_nil): Remove.
4243
4244 2019-07-17  Tom Tromey  <tom@tromey.com>
4245
4246         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
4247         (struct tui_data_item_window): Update.
4248
4249 2019-07-17  Tom Tromey  <tom@tromey.com>
4250
4251         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
4252         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
4253         defines.
4254
4255 2019-07-17  Tom Tromey  <tom@tromey.com>
4256
4257         * tui/tui-winsource.h (tui_erase_source_content)
4258         (tui_clear_source_content): Remove "display_prompt" parameter.
4259         * tui/tui-winsource.c (tui_update_source_window_as_is)
4260         (tui_update_source_windows_with_addr): Update.
4261         (tui_clear_source_content): Remove "display_prompt" parameter.
4262         (tui_erase_source_content): Likewise.  Simplify.
4263         (tui_show_source_content): Update.
4264         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4265         * tui/tui-stack.c (tui_show_frame_info): Update.
4266         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
4267         Remove defines.
4268
4269 2019-07-17  Tom Tromey  <tom@tromey.com>
4270
4271         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4272         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
4273         parameter.
4274         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
4275         parameter.
4276
4277 2019-07-17  Tom Tromey  <tom@tromey.com>
4278
4279         * tui/tui-winsource.c (tui_clear_source_content)
4280         (tui_show_source_content, tui_show_exec_info_content)
4281         (tui_clear_exec_info_content): Update.
4282         * tui/tui-stack.c (tui_show_locator_content): Update.
4283         (tui_show_frame_info): Update.
4284         * tui/tui-source.h (tui_source_window): Don't declare.
4285         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
4286         from tui_source_is_displayed.
4287         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
4288         Remove field.
4289         (struct tui_source_window_base) <content_in_use>: New field.  Now
4290         bool.
4291         (struct tui_source_window) <showing_source_p>: New method.
4292         (TUI_SRC_WIN): Change cast.
4293         * tui/tui-data.c (tui_initialize_static_data): Update.
4294
4295 2019-07-17  Tom Tromey  <tom@tromey.com>
4296
4297         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
4298         location_matches_p.
4299         * tui/tui-source.c (tui_source_window::location_matches_p): New
4300         method.
4301         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
4302         method.
4303         * tui/tui-data.h (struct tui_source_window_base)
4304         <location_matches_p>: New method.
4305         (struct tui_source_window, struct tui_disasm_window)
4306         <location_matches_p>: Likewise.
4307
4308 2019-07-17  Tom Tromey  <tom@tromey.com>
4309
4310         * tui/tui-win.c (tui_set_win_height_command): Rename from
4311         tui_set_win_height.
4312         (tui_set_win_height_command): Remove.
4313
4314 2019-07-17  Tom Tromey  <tom@tromey.com>
4315
4316         * tui/tui-source.c (tui_source_window): New constructor.  Add
4317         observer.
4318         (~tui_source_window): New destructor.
4319         (tui_source_window::style_changed): New method.
4320         * tui/tui-hooks.c (tui_redisplay_source): Remove.
4321         (tui_attach_detach_observers): Update.
4322         * tui/tui-data.h (struct tui_source_window): Make constructor not
4323         inline.  Add destructor.
4324         (struct tui_source_window) <style_changed>: New method.
4325         <m_observable>: New member.
4326
4327 2019-07-17  Tom Tromey  <tom@tromey.com>
4328
4329         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
4330         * tui/tui-win.c (tui_resize_all): Fix typo.
4331
4332 2019-07-17  Tom Tromey  <tom@tromey.com>
4333
4334         * tui/tui-wingeneral.h (tui_refresh_all): Update.
4335         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
4336         (tui_refresh_all): Remove "list" parameter.  Use foreach.
4337         * tui/tui-win.c (window_name_completer): Use foreach.
4338         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
4339         (update_tab_width): Likewise.
4340         * tui/tui-layout.c (show_layout): Update.
4341         * tui/tui-data.h (class tui_window_iterator): New.
4342         (struct all_tui_windows): New.
4343         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
4344
4345 2019-07-17  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
4348         parameter.  Don't reference globals.
4349         (tui_reg_command): Update.
4350
4351 2019-07-17  Tom Tromey  <tom@tromey.com>
4352
4353         * tui/tui-regs.c (tui_show_registers): Simplify.
4354
4355 2019-07-17  Tom Tromey  <tom@tromey.com>
4356
4357         * tui/tui-regs.c (tui_show_registers): Update.
4358         (tui_show_register_group): Add win_info parameter.
4359
4360 2019-07-17  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
4363         Rename from tui_display_reg_element_at_line.
4364         (tui_data_window::display_registers_from_line): Update.
4365         * tui/tui-data.h (struct tui_data_window)
4366         <display_reg_element_at_line>: New method.
4367
4368 2019-07-17  Tom Tromey  <tom@tromey.com>
4369
4370         * tui/tui-regs.h (tui_display_registers_from)
4371         (tui_display_registers_from_line): Don't declare.
4372         * tui/tui-windata.c (tui_data_window::display_all_data)
4373         (tui_data_window::refresh_all)
4374         (tui_data_window::do_scroll_vertical): Update.
4375         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
4376         from tui_display_registers_from.
4377         (tui_display_reg_element_at_line): Update.
4378         (tui_data_window::display_registers_from_line): Rename from
4379         tui_display_registers_from_line.
4380         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
4381         display_registers_from_line>: New methods.
4382
4383 2019-07-17  Tom Tromey  <tom@tromey.com>
4384
4385         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
4386         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
4387         from tui_erase_data_content.
4388         (tui_data_window::display_all_data)
4389         (tui_data_window::refresh_all)
4390         (tui_data_window::do_scroll_vertical): Update.
4391         * tui/tui-regs.c (tui_show_registers): Update.
4392         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
4393         New method.
4394
4395 2019-07-17  Tom Tromey  <tom@tromey.com>
4396
4397         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
4398         declare.
4399         * tui/tui-windata.c
4400         (tui_data_window::delete_data_content_windows): Rename from
4401         tui_delete_data_content_windows.
4402         (tui_data_window::display_all_data)
4403         (tui_data_window::do_scroll_vertical): Update.
4404         * tui/tui-data.h (struct tui_data_window)
4405         <delete_data_content_windows>: New method.
4406
4407 2019-07-17  Tom Tromey  <tom@tromey.com>
4408
4409         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
4410         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
4411
4412 2019-07-17  Tom Tromey  <tom@tromey.com>
4413
4414         * tui/tui-windata.h (tui_display_all_data): Don't declare.
4415         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
4416         from tui_display_all_data.
4417         * tui/tui-win.c
4418         (tui_data_window::do_make_visible_with_new_height): Update.
4419         * tui/tui-regs.c (tui_show_registers): Update.
4420         * tui/tui-layout.c (tui_set_layout): Update.
4421         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
4422         method.
4423
4424 2019-07-17  Tom Tromey  <tom@tromey.com>
4425
4426         * tui/tui-windata.h (tui_display_data_from): Don't declare.
4427         * tui/tui-windata.c (tui_display_data_from): Remove.
4428         (tui_data_window::refresh_all): Update.
4429
4430 2019-07-17  Tom Tromey  <tom@tromey.com>
4431
4432         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
4433         * tui/tui-windata.c (tui_display_data_from_line): Remove.
4434         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
4435         tui_display_registers_from_line.
4436         * tui/tui-regs.h (tui_display_registers_from_line): Update.
4437         * tui/tui-regs.c (tui_display_registers_from_line): Remove
4438         "force_display" parameter.
4439
4440 2019-07-17  Tom Tromey  <tom@tromey.com>
4441
4442         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
4443         declare.
4444         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
4445         Rename from tui_first_reg_element_no_inline.
4446         (tui_display_reg_element_at_line)
4447         (tui_display_registers_from_line): Update.
4448         * tui/tui-data.h (struct tui_data_window)
4449         <first_reg_element_no_inline>: New method.
4450
4451 2019-07-17  Tom Tromey  <tom@tromey.com>
4452
4453         * tui/tui-windata.c (tui_display_data_from)
4454         (tui_data_window::do_scroll_vertical): Update.
4455         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
4456         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
4457         Rename from tui_line_from_reg_element_no.
4458         (tui_display_registers_from_line): Update.
4459         * tui/tui-data.h (struct tui_data_window)
4460         <line_from_reg_element_no>: New method.
4461
4462 2019-07-17  Tom Tromey  <tom@tromey.com>
4463
4464         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
4465         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
4466         tui_last_regs_line_no.
4467         (tui_display_reg_element_at_line)
4468         (tui_display_registers_from_line): Update.
4469         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
4470         method.
4471
4472 2019-07-17  Tom Tromey  <tom@tromey.com>
4473
4474         PR tui/24722:
4475         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
4476         (tui_update_breakpoint_info): Add "being_deleted" parameter.
4477         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
4478         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
4479         (tui_update_breakpoint_info): Likewise.
4480         * tui/tui-hooks.c (tui_event_create_breakpoint)
4481         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
4482         Update.
4483
4484 2019-07-17  Tom Tromey  <tom@tromey.com>
4485
4486         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
4487
4488 2019-07-17  Tom Tromey  <tom@tromey.com>
4489
4490         * tui/tui-winsource.c (tui_update_source_window_as_is)
4491         (tui_update_source_windows_with_addr): Update.
4492         * tui/tui-source.h (tui_set_source_content)
4493         (tui_show_symtab_source): Add "win_info" parameter.
4494         * tui/tui-source.c (tui_set_source_content): Add "win_info"
4495         parameter.
4496         (tui_show_symtab_source): Likewise.
4497
4498 2019-07-17  Tom Tromey  <tom@tromey.com>
4499
4500         * tui/tui-wingeneral.c
4501         (tui_check_and_display_highlight_if_needed): Check can_highlight.
4502
4503 2019-07-17  Tom Tromey  <tom@tromey.com>
4504
4505         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
4506         (struct tui_cmd_window) <can_scroll>: New method.
4507         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
4508         method.
4509
4510 2019-07-17  Tom Tromey  <tromey@adacore.com>
4511
4512         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
4513         do_field_signed>: Rename.  Change type of "value".
4514         * ui-out.c (ui_out::field_signed): Rename from field_int.
4515         Change type of "value".
4516         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
4517         type of "value".
4518         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
4519         do_field_int.  Change type of "value".
4520         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
4521         do_field_int.  Change type of "value".
4522         * tracepoint.c (trace_status_mi, tfind_1)
4523         (print_one_static_tracepoint_marker): Update.
4524         * thread.c (print_thread_info_1, print_selected_thread_frame):
4525         Update.
4526         * stack.c (print_frame, print_frame_info): Update.
4527         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
4528         Update.
4529         * source.c (print_source_lines_base): Update.
4530         * skip.c (info_skip_command): Update.
4531         * record-btrace.c (btrace_ui_out_decode_error)
4532         (btrace_call_history_src_line): Update.
4533         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
4534         Update.
4535         * progspace.c (print_program_space): Update.
4536         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
4537         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
4538         do_field_int.  Change type of "value".
4539         * mi/mi-out.c (mi_ui_out::do_table_begin)
4540         (mi_ui_out::do_table_header): Update.
4541         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
4542         type of "value".
4543         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
4544         (mi_cmd_data_list_changed_registers, output_register)
4545         (mi_cmd_data_read_memory, mi_load_progress)
4546         (mi_cmd_trace_frame_collected): Update.
4547         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
4548         Update.
4549         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
4550         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
4551         (mi_cmd_var_list_children, varobj_update_one): Update.
4552         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4553         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4554         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4555         * inferior.c (print_inferior): Update.
4556         * gdb_bfd.c (print_one_bfd): Update.
4557         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4558         Update.
4559         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4560         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4561         do_field_int.  Change type of "value".
4562         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4563         do_field_int.  Change type of "value".
4564         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4565         (print_one_breakpoint_location, print_it_catch_fork)
4566         (print_one_catch_fork, print_it_catch_vfork)
4567         (print_one_catch_vfork, print_it_catch_solib)
4568         (print_it_catch_exec, print_it_ranged_breakpoint)
4569         (print_mention_watchpoint, print_mention_masked_watchpoint)
4570         (bkpt_print_it, update_static_tracepoint): Update.
4571         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4572         * break-catch-syscall.c (print_it_catch_syscall): Update.
4573         * ada-tasks.c (print_ada_task_info): Update.
4574         * ada-lang.c (print_it_exception, print_mention_exception):
4575         Update.
4576
4577 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4578
4579         PR breakpoints/24541
4580         * gdbarch.c: Regenerate.
4581         * gdbarch.h: Regenerate.
4582         * gdbarch.sh: Adjust return type and parameter types for
4583         'stap_adjust_register'.
4584         (i386_stap_adjust_register): Adjust signature and return new
4585         register name.
4586         * stap-probe.c (stap_parse_register_operand): Adjust use of
4587         'gdbarch_stap_adjust_register'.
4588
4589 2019-07-17  Tom Tromey  <tromey@adacore.com>
4590
4591         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4592         declare VEC.
4593         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4594         std::vector.
4595         (struct s390_process_info): Add initializers.
4596         (s390_add_process): Use new.
4597         (s390_linux_nat_target::low_forget_process): Use delete.
4598         (s390_linux_nat_target::low_new_fork)
4599         (s390_linux_nat_target::stopped_by_watchpoint)
4600         (s390_linux_nat_target::low_prepare_to_resume)
4601         (s390_linux_nat_target::insert_watchpoint)
4602         (s390_linux_nat_target::insert_hw_breakpoint)
4603         (s390_linux_nat_target::remove_watchpoint)
4604         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4605
4606 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4607
4608         * aarch64-fbsd-nat.c: Include regcache.h.
4609         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4610         argument.
4611         (aarch64_fbsd_nat_target::fetch_registers)
4612         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4613         variable.
4614         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4615
4616 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4617
4618         * fbsd-nat.c: Include gdbarch.h.
4619
4620 2019-07-15  Tom Tromey  <tromey@adacore.com>
4621
4622         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4623
4624 2019-07-15  Tom Tromey  <tromey@adacore.com>
4625
4626         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4627         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4628         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4629         * cli-out.c (cli_ui_out::do_field_int): New method.
4630         * ui-out.c (ui_out::field_unsigned): New method.
4631         * symfile.c (generic_load): Use field_unsigned.
4632         (print_transfer_performance): Likewise.
4633         * record-btrace.c (ui_out_field_uint): Remove.
4634         (btrace_call_history_insn_range, btrace_call_history): Use
4635         field_unsigned.
4636         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4637         field_unsigned.
4638         * ui-out.h (class ui_out) <field_unsigned>: New method.
4639         <do_field_unsigned>: Likewise.
4640
4641 2019-07-15  Tom Tromey  <tromey@adacore.com>
4642
4643         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4644         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4645         * target.c (flash_erase_command): Use field_string.
4646         * infrun.c (print_signal_received_reason): Use field_string.
4647         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4648         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4649         field_string.
4650         * ada-tasks.c (print_ada_task_info): Use field_string.
4651
4652 2019-07-15  Tom Tromey  <tromey@adacore.com>
4653
4654         * target.c (flash_erase_command): Use field_core_addr.
4655         * symfile.c (generic_load): Use field_core_addr.
4656         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4657         Use field_core_addr.
4658         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4659         field_core_addr.
4660
4661 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4662
4663         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4664         value if its desired type is smaller than a CORE_ADDR and signed.
4665
4666 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4667
4668         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4669         of changes to field names, and use new is_reference field to
4670         decide if a property is a reference or not.
4671         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4672         field.
4673         (struct dwarf2_property_baton): Update header comment, rename
4674         'referenced_type' to 'property_type' and update comments.
4675         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4676         default property type, store in property baton, update to take
4677         accound of renamed field.
4678         (read_func_scope): Update call to attr_to_dynamic_prop.
4679         (read_array_type): Likewise.
4680         (dwarf2_per_cu_addr_sized_int_type): New function.
4681         (read_subrange_index_type): Move type finding code to
4682         dwarf2_per_cu_addr_sized_int_type.
4683         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4684         (dwarf2_per_cu_addr_type): New function.
4685         (set_die_type): Update calls to attr_to_dynamic_prop.
4686
4687 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4688
4689         * dwarf2read.c (read_subrange_index_type): New function.
4690         (read_subrange_type): Move code into new function and call it.
4691         * gdbtypes.c (create_range_type): Add some asserts.
4692
4693 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4696         update return statements.
4697         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4698         declaration, and update comment to match.
4699         * gdbtypes.c (resolve_dynamic_array): Update call to
4700         dwarf2_evaluate_property to match new return type.
4701
4702 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4703
4704         * valarith.c (value_subscripted_rvalue): Change lowerbound
4705         parameter type from int to LONGEST.
4706         * value.h (value_subscripted_rvalue): Likewise in declaration.
4707
4708 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * cli/cli-utils.c (info_print_command_completer): New function.
4711         * cli/cli-utils.h: Add 'completer.h' include, and forward
4712         declaration for 'struct cmd_list_element'.
4713         (info_print_command_completer): Declare.
4714         * stack.c (_initialize_stack): Add completer for 'info locals' and
4715         'info args'.
4716         * symtab.c (_initialize_symtab): Add completer for 'info
4717         variables' and 'info functions'.
4718         * NEWS: Mention completion for additional info commands.
4719
4720 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4721
4722         * cli/cli-utils.c (extract_info_print_args): Delete.
4723         (extract_arg_maybe_quoted): Delete.
4724         (info_print_options_defs): New variable.
4725         (make_info_print_options_def_group): New function.
4726         (extract_info_print_options): Define new function.
4727         * cli/cli-utils.h (extract_info_print_args): Delete.
4728         (struct info_print_options): New structure.
4729         (extract_info_print_options): Declare new function.
4730         * stack.c (info_locals_command): Update to use new
4731         extract_info_print_options, also add a header comment.
4732         (info_args_command): Likewise.
4733         * symtab.c (info_variables_command): Likewise.
4734         (info_functions_command): Likewise.
4735
4736 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4737
4738         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4739         to extract string arguments.
4740         * common/common-utils.c (extract_string_maybe_quoted): New function.
4741         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4742
4743 2019-07-11  Tom Tromey  <tromey@adacore.com>
4744
4745         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4746         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4747         * top.h (gdbinit): Don't declare.
4748         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4749         into...
4750         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4751         * top.c (gdb_init): Don't call init_cli_cmds.
4752         (gdbinit): Remove.
4753         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4754
4755 2019-07-11  Tom Tromey  <tromey@adacore.com>
4756
4757         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4758         after it has been moved.
4759
4760 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4761
4762         * valops.c (value_must_coerce_to_target): Change return type to
4763         bool.
4764         * value.h (value_must_coerce_to_target): Likewise.
4765
4766 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4767
4768         * breakpoint.c (is_hardware_watchpoint): Remove
4769         forward-declaration.
4770         (is_masked_watchpoint): Change return type to bool.
4771         (is_tracepoint): Likewise.
4772         (is_breakpoint): Likewise.
4773         (is_hardware_watchpoint): Likewise.
4774         (is_watchpoint): Likewise.
4775         (is_no_memory_software_watchpoint): Likewise.
4776         (is_catchpoint): Likewise.
4777         (breakpoint_1): Make FILTER parameter's return type bool.
4778         is_masked_watchpoint): Change return type to bool.
4779         (save_breakpoints): Make FILTER parameter's return type bool.
4780         * breakpoint.h (is_breakpoint): Change return type to bool.
4781         (is_watchpoint): Likewise.
4782         (is_catchpoint): Likewise.
4783         (is_tracepoint): Likewise.
4784
4785 2019-07-10  Tom Tromey  <tom@tromey.com>
4786
4787         * defs.h: Don't include gdbarch.h.
4788         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4789         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4790         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4791         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4792         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4793         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4794         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4795         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4796         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4797         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4798         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4799         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4800         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4801         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4802         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4803         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4804         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4805         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4806         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4807         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4808         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4809         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4810         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4811         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4812         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4813         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4814         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4815
4816 2019-07-10  Tom Tromey  <tromey@adacore.com>
4817
4818         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4819         * breakpoint.c (init_ada_exception_breakpoint): Register as
4820         bp_catchpoint.
4821         (print_one_breakpoint_location, print_one_breakpoint): Use
4822         is_ada_exception_catchpoint.
4823         * ada-lang.c (class ada_catchpoint_location): Pass
4824         bp_loc_software_breakpoint to bp_location constructor.
4825         (is_ada_exception_catchpoint): New function.
4826
4827 2019-07-10  Tom Tromey  <tromey@adacore.com>
4828
4829         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4830         VEC.
4831         (struct arm_exidx_entry): New method operator<.
4832         (struct arm_exidx_data) <section_maps>: Change type.
4833         (arm_exidx_data_free): Remove.
4834         (arm_exidx_data_key): Change type.  Move lower.
4835         (arm_exidx_new_objfile): Update.
4836         (arm_compare_exidx_entries): Remove.
4837         (arm_find_exidx_entry, _initialize_arm_tdep)
4838
4839 2019-07-10  Tom Tromey  <tromey@adacore.com>
4840
4841         * solib-spu.c (ocl_program_data_key): Change type.
4842         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4843         Update.
4844
4845 2019-07-10  Tom Tromey  <tromey@adacore.com>
4846
4847         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4848         (struct solib_aix_inferior_data) <library_list>: Change type.
4849         (solib_aix_inferior_data_handle): Change type.
4850         (get_solib_aix_inferior_data): Update.
4851         (solib_aix_free_library_list): Remove.
4852         (library_list_start_library): Update.
4853         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4854         return type.
4855         (solib_aix_get_library_list)
4856         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4857         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4858
4859 2019-07-10  Tom Tromey  <tromey@adacore.com>
4860
4861         * solib-dsbt.c (struct dsbt_info): Add initializers.
4862         (solib_dsbt_pspace_data): Change type.
4863         (dsbt_pspace_data_cleanup): Remove.
4864         (get_dsbt_info, _initialize_dsbt_solib): Update.
4865
4866 2019-07-10  Tom Tromey  <tromey@adacore.com>
4867
4868         * spu-tdep.c (spu_overlay_data): Change type.
4869         (spu_get_overlay_table, spu_overlay_new_objfile)
4870         (_initialize_spu_tdep): Update.
4871
4872 2019-07-10  Tom Tromey  <tromey@adacore.com>
4873
4874         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4875         destructor.
4876         (dbx_objfile_data_key): Change type and declare later.
4877         (DBX_SYMFILE_INFO): Rewrite.
4878         * dbxread.c (dbx_objfile_data_key): Change type.
4879         (dbx_symfile_init): Update.
4880         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4881         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4882         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4883
4884 2019-07-10  Tom Tromey  <tromey@adacore.com>
4885
4886         * jit.c (jit_program_space_key): Change type.  Move lower.
4887         (get_jit_program_space_data): Update.
4888         (jit_program_space_data_cleanup): Remove.
4889         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4890         Update.
4891         (struct jit_program_space_data): Add initializers.
4892
4893 2019-07-10  Tom Tromey  <tromey@adacore.com>
4894
4895         * solib-darwin.c (struct darwin_info): Add initializers.
4896         (solib_darwin_pspace_data): Change type.
4897         (darwin_pspace_data_cleanup): Remove.
4898         (get_darwin_info, _initialize_darwin_solib): Update.
4899
4900 2019-07-10  Tom Tromey  <tromey@adacore.com>
4901
4902         * remote-sim.c (struct sim_inferior_data): Add initializers,
4903         constructor, and destructor.
4904         (sim_inferior_data_key): Change type.  Move lower.
4905         (check_for_duplicate_sim_descriptor): Update.
4906         (get_sim_inferior_data): Use new.  Update.
4907         (~sim_inferior_data_cleanup): Rename from
4908         sim_inferior_data_cleanup.  Simplify.
4909         (gdbsim_close_inferior, simulator_command)
4910         (sim_command_completer, _initialize_remote_sim): Update.
4911         (next_pid, INITIAL_PID): Move earlier.
4912
4913 2019-07-10  Tom Tromey  <tromey@adacore.com>
4914
4915         * python/python-internal.h (create_thread_object): Return
4916         gdbpy_ref.
4917         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4918         * python/py-inferior.c (struct threadlist_entry): Add
4919         constructor.
4920         <thread_obj>: Now a gdbpy_ref.
4921         (thread_to_thread_object): Update.
4922         (add_thread_object): Use new.
4923         (delete_thread_object): Use delete.
4924         (infpy_threads): Update.
4925         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4926         GIL.
4927
4928 2019-07-10  Tom Tromey  <tromey@adacore.com>
4929
4930         * valops.c (value_cast): Specialize error message for Ada.
4931
4932 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4933
4934         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4935
4936 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4937
4938         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4939         bpstat_should_step): Return bool, adjust comments.
4940         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4941         bpstat_should_step): Likewise.
4942
4943 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4944
4945         * features/Makefile: Use feature target descriptions for Arm.
4946         * features/arm/arm-core.c: Generate new file.
4947         * features/arm/arm-fpa.c: Likewise.
4948         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4949         * features/arm/arm-m-profile.c: Likewise.
4950         * features/arm/arm-vfpv2.c: Likewise.
4951         * features/arm/arm-vfpv3.c: Likewise.
4952         * features/arm/xscale-iwmmxt.c: Likewise.
4953         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4954
4955 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4956
4957         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4958         ptrace earlier.
4959
4960 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4961
4962         * features/aarch64-pauth.c: Regenerate.
4963
4964 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4965
4966         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4967         bool.
4968         (bpstat_what): Use false instead of 0.
4969
4970 2019-07-09  Pedro Alves  <palves@redhat.com>
4971
4972         * break-catch-throw.c (is_exception_catchpoint): New.
4973         * breakpoint.c (print_one_breakpoint_location): New parameter
4974         'raw_loc'.  Handle it.  Use
4975         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4976         looking at the breakpoint's type.
4977         (print_one_breakpoint): If handling "maint info breakpoints", also
4978         print locations of exception catchpoints.
4979         * breakpoint.h (is_exception_catchpoint): Declare.
4980
4981 2019-07-09  Pedro Alves  <palves@redhat.com>
4982
4983         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4984         "addr" field.
4985         (allocate_location_exception_catchpoint): New.
4986         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4987         (initialize_throw_catchpoint_ops): Install
4988         allocate_location_exception_catchpoint as allocate_location
4989         method.
4990         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4991         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4992         bp_loc_other.
4993         (breakpoint_address_is_meaningful): Delete.
4994         (bl_address_is_meaningful): New.
4995         (breakpoint_locations_match): Adjust comment.
4996         (bp_location_from_bp_type): New, factored out of...
4997         (bp_location::bp_location(breakpoint *)): ... this.
4998         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4999         factored out of...
5000         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
5001         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
5002         breakpoint_address_is_meaningful.
5003         (bp_locations_compare): Adjust comment.
5004         (update_global_location_list): Use bl_address_is_meaningful
5005         instead of breakpoint_address_is_meaningful.
5006         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
5007         explicit.
5008         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
5009         * python/py-breakpoint.c (bppy_get_location): No longer check
5010         whether location is null.
5011
5012 2019-07-09  Pedro Alves  <palves@redhat.com>
5013
5014         PR c++/15468
5015         * breakpoint.c (print_one_breakpoint_location): Remove
5016         single-location assert.
5017
5018 2019-07-09  Tom Tromey  <tom@tromey.com>
5019
5020         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
5021         * configure: Rebuild.
5022         * configure.ac: Change common to gdbsupport.
5023         * gdbsupport: Rename from common.
5024         * acinclude.m4: Change common to gdbsupport.
5025         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
5026         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
5027         gdbsupport.
5028         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
5029         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
5030         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
5031         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
5032         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
5033         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
5034         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
5035         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
5036         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
5037         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
5038         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
5039         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
5040         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
5041         coff-pe-read.c, command.h, compile/compile-c-support.c,
5042         compile/compile-c.h, compile/compile-cplus-symbols.c,
5043         compile/compile-cplus-types.c, compile/compile-cplus.h,
5044         compile/compile-loc2c.c, compile/compile.c, completer.c,
5045         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
5046         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
5047         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
5048         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
5049         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
5050         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
5051         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
5052         features/aarch64-core.c, features/aarch64-fpu.c,
5053         features/aarch64-pauth.c, features/aarch64-sve.c,
5054         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
5055         features/i386/32bit-core.c, features/i386/32bit-linux.c,
5056         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
5057         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
5058         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
5059         features/i386/64bit-core.c, features/i386/64bit-linux.c,
5060         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
5061         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
5062         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
5063         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
5064         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
5065         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
5066         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
5067         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
5068         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
5069         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
5070         go32-nat.c, guile/guile.c, guile/scm-ports.c,
5071         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
5072         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
5073         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
5074         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
5075         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
5076         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
5077         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
5078         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
5079         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
5080         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
5081         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
5082         minsyms.c, mips-linux-tdep.c, namespace.h,
5083         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
5084         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
5085         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
5086         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
5087         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
5088         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
5089         nat/linux-waitpid.c, nat/mips-linux-watch.c,
5090         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
5091         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
5092         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
5093         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
5094         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
5095         procfs.c, producer.c, progspace.h, psymtab.h,
5096         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
5097         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
5098         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
5099         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
5100         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
5101         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
5102         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
5103         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
5104         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
5105         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
5106         target-memory.c, target.c, target.h, target/waitstatus.c,
5107         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
5108         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
5109         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
5110         unittests/array-view-selftests.c,
5111         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
5112         unittests/common-utils-selftests.c,
5113         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
5114         unittests/format_pieces-selftests.c,
5115         unittests/function-view-selftests.c,
5116         unittests/lookup_name_info-selftests.c,
5117         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
5118         unittests/mkdir-recursive-selftests.c,
5119         unittests/observable-selftests.c,
5120         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
5121         unittests/parse-connection-spec-selftests.c,
5122         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
5123         unittests/scoped_fd-selftests.c,
5124         unittests/scoped_mmap-selftests.c,
5125         unittests/scoped_restore-selftests.c,
5126         unittests/string_view-selftests.c, unittests/style-selftests.c,
5127         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
5128         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
5129         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
5130         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
5131         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
5132         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
5133
5134 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5135
5136         * linespec.c (decode_digits_list_mode): Set explicit_line to a
5137         bool value.
5138         (decode_digits_ordinary): Set explicit_line field in sal.
5139         * symtab.c (skip_prologue_sal): Don't skip prologue for a
5140         symtab_and_line that was set on an explicit line number in
5141         assembler code.  Do always update the recorded symtab and line if
5142         we do skip the prologue.
5143
5144 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * breakpoint.c (set_breakpoint_location_function): Remove
5147         explicit_loc parameter.
5148         (momentary_breakpoint_from_master): Update call to
5149         set_breakpoint_location_function.
5150         (add_location_to_breakpoint): Likewise.
5151
5152 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
5155         required features based on default bfd type when no specific bfd
5156         is present.
5157
5158 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5159
5160         * NEWS: Mention that GDB printf and eval commands can now print
5161         C-style and Ada-style convenience var strings without
5162         calling the inferior.
5163         * printcmd.c (printf_c_string): Locally print GDB internal var
5164         instead of transiting via the inferior.
5165         (printf_wide_c_string): Likewise.
5166
5167 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5168
5169         PR breakpoints/25011
5170         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
5171
5172 2019-07-04  Tom Tromey  <tom@tromey.com>
5173
5174         PR tui/24724:
5175         * tui/tui-winsource.c (tui_clear_source_content): Update.
5176         (tui_source_window_base::set_is_exec_point_at): Fix comment.
5177         (tui_update_breakpoint_info): Update.
5178         (tui_set_exec_info_content): Update.
5179         * tui/tui-source.c (tui_set_source_content_nil): Update.
5180         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
5181         has_break.
5182         * tui/tui-data.h (enum tui_bp_flag): New.
5183         (tui_bp_flags): New enum flags type.
5184         (struct tui_source_element) <break_mode>: Change type.  Rename
5185         from has_break.
5186         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
5187         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
5188         constants.
5189         * tui/tui-winsource.h: Fix comment.
5190
5191 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5192
5193         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
5194         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
5195         (store_fpregs_to_thread)
5196         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5197         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
5198         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
5199         (IWMMXT_REGS_SIZE): Add define.
5200         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
5201         (fetch_vfp_regs, store_vfp_regs)
5202         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
5203         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
5204
5205 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5206
5207         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
5208         defines.
5209         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
5210         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
5211         (ARM_INT_REGISTER_SIZE): ...to this.
5212         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
5213         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
5214         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
5215         (arm_linux_collect_gregset, supply_nwfpe_register)
5216         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
5217         defines.
5218         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
5219         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
5220         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
5221         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
5222         (arm_return_in_memory, arm_store_return_value)
5223         (arm_get_longjmp_target, arm_register_g_packet_guesses)
5224         (arm_record_ld_st_multiple): Likewise.
5225         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
5226         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
5227
5228 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5229
5230         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
5231         AARCH64_DISPLACED_MODIFIED_INSNS.
5232         * aarch64-tdep.c (struct aarch64_displaced_step_data)
5233         (aarch64_displaced_step_copy_insn): Likewise.
5234         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5235         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
5236         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
5237         ARM_DISPLACED_MODIFIED_INSNS.
5238         * arm-tdep.c (arm_gdbarch_init): Likewise.
5239         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
5240         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
5241         (struct arm_displaced_step_closure): Use
5242         ARM_DISPLACED_MODIFIED_INSNS.
5243
5244 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5245
5246         * features/Makefile: Remove unused xml files.
5247         * features/aarch64.xml: Remove.
5248         * features/i386/amd64-avx-avx512-linux.xml: Remove.
5249         * features/i386/amd64-avx-avx512.xml: Remove.
5250         * features/i386/amd64-avx-linux.xml: Remove.
5251         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
5252         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
5253         * features/i386/amd64-avx-mpx-linux.xml: Remove.
5254         * features/i386/amd64-avx-mpx.xml: Remove.
5255         * features/i386/amd64-avx.xml: Remove.
5256         * features/i386/amd64-linux.xml: Remove.
5257         * features/i386/amd64-mpx-linux.xml: Remove.
5258         * features/i386/amd64-mpx.xml: Remove.
5259         * features/i386/amd64.xml: Remove.
5260         * features/i386/i386-avx-avx512-linux.xml: Remove.
5261         * features/i386/i386-avx-avx512.xml: Remove.
5262         * features/i386/i386-avx-linux.xml: Remove.
5263         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
5264         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
5265         * features/i386/i386-avx-mpx-linux.xml: Remove.
5266         * features/i386/i386-avx-mpx.xml: Remove.
5267         * features/i386/i386-avx.xml: Remove.
5268         * features/i386/i386-linux.xml: Remove.
5269         * features/i386/i386-mmx-linux.xml: Remove.
5270         * features/i386/i386-mmx.xml: Remove.
5271         * features/i386/i386-mpx-linux.xml: Remove.
5272         * features/i386/i386-mpx.xml: Remove.
5273         * features/i386/i386.xml: Remove.
5274         * features/i386/x32-avx-avx512-linux.xml: Remove.
5275         * features/i386/x32-avx-linux.xml: Remove.
5276         * features/i386/x32-linux.xml: Remove.
5277
5278 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5279
5280         * regformats/aarch64.dat: Remove.
5281         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
5282         * regformats/i386/amd64-avx-linux.dat: Remove.
5283         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
5284         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
5285         * regformats/i386/amd64-linux.dat: Remove.
5286         * regformats/i386/amd64-mpx-linux.dat: Remove.
5287         * regformats/i386/amd64.dat: Remove.
5288         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
5289         * regformats/i386/i386-avx-linux.dat: Remove.
5290         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
5291         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
5292         * regformats/i386/i386-linux.dat: Remove.
5293         * regformats/i386/i386-mmx-linux.dat: Remove.
5294         * regformats/i386/i386-mpx-linux.dat: Remove.
5295         * regformats/i386/i386.dat: Remove.
5296         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
5297         * regformats/i386/x32-avx-linux.dat: Remove.
5298         * regformats/i386/x32-linux.dat: Remove.
5299
5300 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
5301
5302         * aarch64-tdep.c: Remove xml self tests.
5303         * amd64-linux-tdep.c: Likewise.
5304         * amd64-tdep.c: Likewise.
5305         * i386-linux-tdep.c: Likewise.
5306         * i386-tdep.c: Likewise.
5307
5308 2019-07-03  Pedro Alves  <palves@redhat.com>
5309
5310         PR cli/24732
5311         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
5312         (pipe_cmd_option_defs): New.
5313         (make_pipe_cmd_options_def_group): New.
5314         (pipe_command): Use gdb::option::process_options.
5315         (pipe_command_completer): New function.
5316         (_initialize_cli_cmds): Install completer for "pipe" command.
5317
5318 2019-07-03  Pedro Alves  <palves@redhat.com>
5319
5320         * cli/cli-option.c (union option_value) <string>: New field.
5321         (struct option_def_and_value): Add ctor, move ctor, dtor and
5322         use DISABLE_COPY_AND_ASSIGN.
5323         (option_def_and_value::clear_value): New.
5324         (parse_option, save_option_value_in_ctx, get_val_type_str)
5325         (add_setshow_cmds_for_options): Handle var_string.
5326         * cli-option.h (union option_def::var_address) <string>: New
5327         field.
5328         (struct string_option_def): New.
5329         * maint-test-options.c (struct test_options_opts): Add default
5330         ctor and use DISABLE_COPY_AND_ASSIGN.
5331         <string_opt>: New field.
5332         (test_options_opts::~test_options_opts): New.
5333         (test_options_opts::dump): Also dump "-string".
5334         (test_options_option_defs): Install "string.
5335
5336 2019-07-03  Pedro Alves  <palves@redhat.com>
5337
5338         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
5339         option_value with a null enumeration.
5340         (complete_options): Save the option values in the context.
5341         (save_option_value_in_ctx): New, factored out from ...
5342         (process_options): ... here.
5343         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
5344         of the function.
5345         * maint-test-options.c (test_options_opts::dump): New, factored
5346         out from ...
5347         (maintenance_test_options_command_mode): ... here.
5348         (maintenance_test_options_command_completion_result): Delete.
5349         (maintenance_test_options_command_completion_text): Update
5350         comment.
5351         (maintenance_show_test_options_completion_result): Change
5352         prototype.  Just print
5353         maintenance_test_options_command_completion_text.
5354         (save_completion_result): New.
5355         (maintenance_test_options_completer_mode): Pass options context to
5356         complete_options, and then save a dump.
5357         (_initialize_maint_test_options): Use add_cmd to install "maint
5358         show test-options-completion-result".
5359
5360 2019-07-03  Pedro Alves  <palves@redhat.com>
5361
5362         * NEWS (New commands): Mention "with" and "maint with".
5363         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
5364         (with_command, with_command_completer): New.
5365         (pipe_command): Adjust to new repeat_previous
5366         interface.
5367         (_initialize_cli_cmds): Install the "with" command and its "w"
5368         alias.
5369         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
5370         declarations.
5371         * cli/cli-setshow.c (parse_cli_var_uinteger)
5372         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
5373         argument strings for all var_types.
5374         (get_setshow_command_value_string): New, factored out from ...
5375         (do_show_command): ... this.
5376         * cli/cli-setshow.h: Include <string>.
5377         (get_setshow_command_value_string): Declare.
5378         * command.h (repeat_previous): Now returns const char *.  Adjust
5379         comment.
5380         * maint.c: Include "cli/cli-cmds.h".
5381         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
5382         (_initialize_maint_cmds): Register the "maintenance with" command.
5383         * top.c (repeat_previous): Move bits from pipe_command here:
5384         Return the saved command line, if any; error out if there's no
5385         command to relaunch.
5386
5387 2019-07-03  Pedro Alves  <palves@redhat.com>
5388
5389         * NEWS (New commands): Mention "maint set/show test-settings"
5390         instead of "maint test-settings".
5391         * maint-test-settings.c (maintenance_test_settings_list): Delete.
5392         (maintenance_test_settings_set_list): Rename to ...
5393         (maintenance_set_test_settings_list): ... this.
5394         (maintenance_test_settings_show_list): Rename to  ...
5395         (maintenance_show_test_settings_list): ... this.
5396         (maintenance_test_settings_cmd): Delete.
5397         (maintenance_test_settings_set_cmd): ...
5398         (maintenance_set_test_settings_cmd): ... this.
5399         (maintenance_test_settings_show_cmd): ...
5400         (maintenance_show_test_settings_cmd): ... this.
5401         (maintenance_test_settings_show_value_cmd):
5402         (maintenance_show_test_settings_value_cmd): ... this.
5403         (_initialize_maint_test_settings): No longer install the "maint
5404         test-settings" prefix command.  Rename "maint test-settings set"
5405         to "maint set test-settings", and "maint test-settings show" to
5406         "maint show test-settings".  Adjust all subcommands.
5407
5408 2019-07-03  Pedro Alves  <palves@redhat.com>
5409
5410         * maint-test-settings.c: Fix file's intro comment.  Replace all
5411         references to "test-options" with references to "test-settings",
5412         in comments.
5413
5414 2019-07-03  Pedro Alves  <palves@redhat.com>
5415
5416         * maint-test-settings.c (maintenance_test_settings_xxx)
5417         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
5418         New.
5419         (maintenance_test_settings_enums): Use them.
5420         (maintenance_test_settings_enum): Default to
5421         maintenance_test_settings_xxx.
5422         (_initialize_maint_test_settings): Initialize
5423         MAINTENANCE_TEST_SETTINGS_FILENAME.
5424
5425 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5426
5427         * breakpoint.h (remove_breakpoints_inf): Change return type to
5428         void, move function documentation here.
5429         * breakpoint.c (remove_breakpoints_inf): Change return type to
5430         void, move function documentation to header.
5431
5432 2019-07-02  Pedro Alves  <palves@redhat.com>
5433
5434         * NEWS (Completion improvements): Mention "info threads".
5435         * thread.c (struct info_threads_opts, info_threads_option_defs)
5436         (make_info_threads_options_def_group): New.
5437         (info_threads_command): Use gdb::option::process_options.
5438         (info_threads_command_completer): New.
5439         (_initialize_thread): Use gdb::option::build_help to build the
5440         help text for "info threads".
5441
5442 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
5443
5444         * defs.h (generic_load): Move from here...
5445         * symfile.h (generic_load): ... to here.  Rename name parameter
5446         to args.
5447         * symfile.c (generic_load): Add comment.
5448
5449 2019-07-01  Tom Tromey  <tromey@adacore.com>
5450
5451         * dwarf2read.c
5452         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
5453         declaration of without_params.  Fix formatting.
5454
5455 2019-07-01  Tom Tromey  <tromey@adacore.com>
5456
5457         * ada-exp.y (find_primitive_type): Update.
5458         * ada-lang.h (ada_lookup_symbol): Update.
5459         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
5460         parameter.
5461         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
5462
5463 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5464
5465         PR breakpoints/24541
5466         * gdbarch.c: Regenerate.
5467         * gdbarch.h: Regenerate.
5468         * gdbarch.sh: Add 'stap_adjust_register'.
5469         * i386-tdep.c: Include '<unordered_set>'.
5470         (i386_stap_adjust_register): New function.
5471         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
5472         * stap-probe.c (stap_parse_register_operand): Call
5473         'gdbarch_stap_adjust_register'.
5474
5475 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
5476
5477         PR python/24742
5478         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
5479         * python/python.c (do_start_initialization): Use 'xmalloc'
5480         instead of 'PyMem_Malloc'.
5481
5482 2019-06-28  Tom Tromey  <tromey@adacore.com>
5483
5484         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
5485         for Ada.
5486
5487 2019-06-27  Tom Tromey  <tromey@adacore.com>
5488
5489         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
5490         objfile_key.
5491         (arm_find_mapping_symbol, arm_record_special_symbol)
5492         (_initialize_arm_tdep): Update.
5493         (arm_objfile_data_free): Remove.
5494
5495 2019-06-27  Tom Tromey  <tromey@adacore.com>
5496
5497         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
5498         to cp_print_static_field.
5499
5500 2019-06-26  Tom Tromey  <tromey@adacore.com>
5501
5502         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
5503         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
5504         declare.
5505
5506 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5507
5508         * features/aarch64-core.c (create_feature_aarch64_core):
5509         Regenerate.
5510         * features/aarch64-core.xml: Add cpsr flags.
5511
5512 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
5513
5514         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
5515         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
5516
5517 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5518
5519         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
5520         field.
5521         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
5522         use.
5523         (arm_record_special_symbol): Don't insert new symbol in sorted
5524         position, push it at the end.
5525
5526 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
5527
5528         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
5529         (arm_mapping_symbol_s): Remove.
5530         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
5531         (arm_mapping_symbol_vec): New typedef.
5532         (struct arm_per_objfile): Add constructor.
5533         <section_maps>: Change type to
5534         std::unique_ptr<arm_mapping_symbol_vec[]>.
5535         (arm_compare_mapping_symbols): Remove.
5536         (arm_find_mapping_symbol): Adjust to section_maps type change.
5537         (arm_objfile_data_free): Call delete on arm_per_objfile.
5538         (arm_record_special_symbol): Adjust to section_maps type change.
5539         Allocate arm_per_objfile with new.
5540
5541 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5542
5543         * cli/cli-cmds.c (alias_command): Compare the alias prefix
5544         with the command prefix.
5545
5546 2019-06-25  Tom Tromey  <tom@tromey.com>
5547
5548         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
5549         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
5550
5551 2019-06-25  Tom Tromey  <tom@tromey.com>
5552
5553         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5554         type.
5555         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5556         protected.
5557
5558 2019-06-25  Tom Tromey  <tom@tromey.com>
5559
5560         * tui/tui-winsource.c
5561         (tui_source_window_base::set_is_exec_point_at): Add check against
5562         LOA_ADDRESS.
5563
5564 2019-06-25  Tom Tromey  <tom@tromey.com>
5565
5566         * tui/tui-source.c (tui_set_source_content): Don't check before
5567         xfree.
5568         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5569
5570 2019-06-25  Tom Tromey  <tom@tromey.com>
5571
5572         * tui/tui-winsource.h (tui_update_source_window_as_is)
5573         (tui_alloc_source_buffer, tui_line_is_displayed)
5574         (tui_addr_is_displayed): Change type of win_info.
5575         * tui/tui-winsource.c (tui_update_source_window_as_is)
5576         (tui_clear_source_content, tui_show_source_line)
5577         (tui_show_source_content, tui_source_window_base::refill)
5578         (tui_source_window_base::set_is_exec_point_at)
5579         (tui_source_window_base::set_is_exec_point_at)
5580         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5581         (tui_alloc_source_buffer, tui_line_is_displayed)
5582         (tui_addr_is_displayed): Change type of win_info.  Update.
5583         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5584         (tui_source_window_base::do_make_visible_with_new_height):
5585         Update.
5586         * tui/tui-source.c (tui_set_source_content)
5587         (tui_set_source_content_nil)
5588         (tui_source_window::do_scroll_vertical): Update.
5589         * tui/tui-layout.c (show_layout): Update.
5590         * tui/tui-disasm.c (tui_set_disassem_content)
5591         (tui_disasm_window::do_scroll_vertical): Update.
5592         * tui/tui-data.h (tui_win_content): Remove.
5593         (struct tui_gen_win_info) <content, content_size>: Remove.
5594         (struct tui_source_element): Add initializers and destructor.
5595         (union tui_which_element, struct tui_win_element): Remove.
5596         (struct tui_source_window_base) <content>: New field.
5597         (struct tui_data_window): Remove destructor.
5598         (tui_alloc_content, tui_free_win_content)
5599         (tui_free_all_source_wins_content): Don't declare.
5600         * tui/tui-data.c (tui_initialize_static_data): Update.
5601         (init_content_element, tui_alloc_content): Remove.
5602         (~tui_gen_win_info): Update.
5603         (~tui_data_window, tui_free_all_source_wins_content)
5604         (tui_free_win_content, free_content, free_content_elements):
5605         Remove.
5606
5607 2019-06-25  Tom Tromey  <tom@tromey.com>
5608
5609         * tui/tui-winsource.h (tui_clear_source_content)
5610         (tui_erase_source_content, tui_show_source_content): Change type
5611         of win_info.
5612         * tui/tui-winsource.c (tui_clear_source_content)
5613         (tui_erase_source_content, tui_show_source_content): Change type
5614         of win_info.
5615         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5616         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5617         win_info.
5618         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5619         win_info.
5620         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5621
5622 2019-06-25  Tom Tromey  <tom@tromey.com>
5623
5624         * tui/tui-winsource.c (tui_clear_source_content)
5625         (tui_source_window_base::set_is_exec_point_at): Update.
5626         * tui/tui-source.c (tui_set_source_content_nil): Update.
5627         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5628         a bool.
5629         * tui/tui-data.c (init_content_element): Update.
5630
5631 2019-06-25  Tom Tromey  <tom@tromey.com>
5632
5633         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5634         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5635         * tui/tui-layout.c (init_and_make_win): Update.
5636         * tui/tui.h (enum tui_win_type): Update.
5637         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5638         tui_win_is_auxillary.
5639         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5640         tui_win_is_auxillary.
5641
5642 2019-06-25  Tom Tromey  <tom@tromey.com>
5643
5644         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5645         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5646         (tui_delete_data_content_windows, tui_display_all_data)
5647         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5648         Update.
5649         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5650         * tui/tui-regs.c (tui_last_regs_line_no)
5651         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5652         (tui_show_registers): Update.
5653         (tui_show_register_group): Return void.  Update.
5654         (tui_display_registers_from, tui_display_reg_element_at_line)
5655         (tui_display_registers_from_line, tui_check_register_values):
5656         Update.
5657         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5658         member.
5659         (struct tui_data_window) <regs_content>: Now a std::vector.
5660         <regs_content_count>: Remove.
5661         (tui_add_content_elements, tui_free_data_content): Don't declare.
5662         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5663         (init_content_element): Remove DATA_WIN case.  Add assert.
5664         (tui_add_content_elements): Remove.
5665         (tui_data_window): Update.
5666         (tui_free_data_content): Remove.
5667         (free_content_elements): Remove DATA_WIN case.
5668
5669 2019-06-25  Tom Tromey  <tom@tromey.com>
5670
5671         * tui/tui-data.c (tui_data_item_window): Update.
5672         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5673         * tui/tui-windata.c (tui_display_all_data)
5674         (tui_display_data_from_line): Update.
5675         (tui_check_data_values): Remove.
5676         * tui/tui-regs.c (tui_show_register_group)
5677         (tui_display_reg_element_at_line): Update.
5678         * tui/tui-hooks.c (tui_register_changed)
5679         (tui_refresh_frame_and_register_information): Call
5680         tui_check_register_values.
5681         * tui/tui-data.h (struct tui_data_window) <data_content,
5682         data_content_count, data_type>: Remove.
5683         (enum tui_data_type): Remove.
5684
5685         * tui/tui-data.c (tui_data_window::clear_detail)
5686         (~tui_data_window): Update.
5687
5688 2019-06-25  Tom Tromey  <tom@tromey.com>
5689
5690         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5691         declare.
5692         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5693         Rename from tui_first_data_item_displayed.  Update.
5694         (tui_data_window::refresh_all)
5695         (tui_data_window::do_scroll_vertical): Update.
5696         * tui/tui-data.h (struct tui_data_window)
5697         <first_data_item_displayed>: Declare new method.
5698
5699 2019-06-25  Tom Tromey  <tom@tromey.com>
5700
5701         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5702         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5703         contents...
5704         (tui_initialize_static_data): ...here.
5705
5706 2019-06-25  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5709         (tui_display_registers_from, tui_check_register_values): Update.
5710         (tui_display_register): Remove win_info parameter; update.
5711         (tui_get_register): Change type of parameters.
5712         * tui/tui-data.h (struct tui_data_element): Remove.
5713         (union tui_which_element) <data>: Remove.
5714         <data_window>: Change type.
5715         (struct tui_data_item_window): New.
5716         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5717         case.  Add assert.
5718         (~tui_data_item_window): New destructor.
5719         (free_content_elements): Remove DATA_ITEM_WIN case.
5720
5721 2019-06-25  Tom Tromey  <tom@tromey.com>
5722
5723         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5724         Remove.
5725
5726 2019-06-25  Tom Tromey  <tom@tromey.com>
5727
5728         * tui/tui-data.h (struct tui_command_element): Remove.
5729         (union tui_which_element) <command>: Remove.
5730         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5731         assert.
5732         (free_content_elements): Remove CMD_WIN case.
5733
5734 2019-06-25  Tom Tromey  <tom@tromey.com>
5735
5736         * tui/tui-layout.c (tui_set_layout): Update.
5737         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5738         * tui/tui-data.c (layout_def): Update.
5739
5740 2019-06-25  Tom Tromey  <tom@tromey.com>
5741
5742         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5743         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5744         (tui_source_window_base::set_new_height): Update.
5745         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5746         Update.
5747         (tui_set_locator_fullname, tui_set_locator_info)
5748         (tui_show_frame_info): Update.
5749         * tui/tui-source.c (tui_set_source_content)
5750         (tui_source_is_displayed): Update.
5751         * tui/tui-layout.c (show_source_disasm_command, show_data)
5752         (show_source_or_disasm_and_command): Update.
5753         * tui/tui-disasm.c (tui_set_disassem_content)
5754         (tui_get_begin_asm_address): Update.
5755         * tui/tui-data.h (struct tui_locator_element): Remove.
5756         (union tui_which_element) <locator>: Remove.
5757         (struct tui_locator_window): New.
5758         (tui_locator_win_info_ptr): Change return type.
5759         * tui/tui-data.c (_locator): Change type.
5760         (tui_locator_win_info_ptr): Change return type.
5761         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5762         (tui_alloc_content): Add assert.
5763
5764 2019-06-25  Tom Tromey  <tom@tromey.com>
5765
5766         * tui/tui-winsource.c
5767         (tui_exec_info_window::maybe_allocate_content): New method.
5768         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5769         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5770         (make_source_or_disasm_window): Add cast.
5771         * tui/tui-data.h (union tui_which_element) <simple_string>:
5772         Remove.
5773         (struct tui_source_info): New.
5774         (struct tui_source_window_base) <execution_info>: Change type.
5775         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5776         case, and add assert.
5777         (tui_alloc_content): Add assert.
5778
5779 2019-06-25  Tom Tromey  <tom@tromey.com>
5780
5781         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5782         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5783         * tui/tui-data.c (tui_alloc_win_info): Remove.
5784
5785 2019-06-25  Tom Tromey  <tom@tromey.com>
5786
5787         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5788         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5789         can_highlight.
5790
5791 2019-06-25  Tom Tromey  <tom@tromey.com>
5792
5793         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5794         make_visible_with_new_height method.
5795         (tui_win_info::make_visible_with_new_height): New method.
5796         (tui_source_window_base::do_make_visible_with_new_height)
5797         (tui_data_window::do_make_visible_with_new_height)
5798         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5799         (make_visible_with_new_height): Remove.
5800         (tui_resize_all, tui_adjust_win_heights): Use
5801         make_visible_with_new_height method.
5802         * tui/tui-data.h (struct tui_win_info)
5803         <do_make_visible_with_new_height, make_visible_with_new_height>:
5804         New methods.
5805         (struct tui_source_window_base, struct tui_data_window)
5806         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5807         methods.
5808
5809 2019-06-25  Tom Tromey  <tom@tromey.com>
5810
5811         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5812         method.
5813         (update_tab_width): Call update_tab_width method.
5814         * tui/tui-data.h (struct tui_win_info)
5815         (struct tui_source_window_base) <update_tab_width>: New methods.
5816
5817 2019-06-25  Tom Tromey  <tom@tromey.com>
5818
5819         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5820         parameter.
5821         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5822         parameter.
5823         (tui_gen_win_info::make_visible): Update.
5824         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5825         parameter.
5826         * tui/tui-data.h (enum tui_box): New enum.
5827         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5828
5829 2019-06-25  Tom Tromey  <tom@tromey.com>
5830
5831         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5832         init_and_make_win for EXEC_INFO_WIN.
5833         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5834         longer inline.
5835         (struct tui_win_info) <~tui_win_info>: Inline.
5836         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5837         Don't declare.
5838         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5839         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5840         Remove.
5841         (tui_initialize_static_data): Update.
5842         (~tui_gen_win_info): Handle more cleanup here.
5843         (~tui_source_window_base): Delete "execution_info".
5844         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5845
5846 2019-06-25  Tom Tromey  <tom@tromey.com>
5847
5848         * tui/tui-layout.c (make_command_window): Don't set
5849         can_highlight.
5850         (show_source_disasm_command): Call the reset method.
5851         (show_data): Don't set can_highlight.  Call the reset method.
5852         (tui_gen_win_info::reset): Rename from init_gen_win_info
5853         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5854         (show_source_or_disasm_and_command): Call the reset method.
5855         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5856         (struct tui_cmd_window): Set can_highlight.
5857
5858 2019-06-25  Tom Tromey  <tom@tromey.com>
5859
5860         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5861         from make_visible.
5862         (tui_make_visible, tui_make_invisible): Rewrite.
5863         (tui_win_info::make_visible): Remove.
5864         (tui_source_window_base::make_visible): Update.
5865         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5866         method.  Moved from...
5867         (struct tui_win_info) <make_visible>: ...here.
5868
5869 2019-06-25  Tom Tromey  <tom@tromey.com>
5870
5871         * tui/tui-winsource.c
5872         (tui_source_window_base::do_scroll_horizontal): Remove direction
5873         parameter.
5874         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5875         direction parameter.
5876         * tui/tui-win.c (tui_win_info::forward_scroll)
5877         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5878         (tui_win_info::right_scroll): Update.
5879         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5880         direction parameter.
5881         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5882         direction parameter.
5883         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5884         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5885         Remove direction parameter.
5886         (struct tui_source_window_base, struct tui_source_window)
5887         (struct tui_disasm_window, struct tui_data_window)
5888         (struct tui_cmd_window): Update.
5889
5890 2019-06-25  Tom Tromey  <tom@tromey.com>
5891
5892         * tui/tui-winsource.h (tui_set_exec_info_content)
5893         (tui_show_exec_info_content, tui_erase_exec_info_content)
5894         (tui_clear_exec_info_content, tui_update_exec_info): Change
5895         argument to tui_source_window_base.
5896         * tui/tui-winsource.c (tui_set_exec_info_content)
5897         (tui_show_exec_info_content, tui_erase_exec_info_content)
5898         (tui_clear_exec_info_content, tui_update_exec_info): Change
5899         argument to tui_source_window_base.
5900
5901 2019-06-25  Tom Tromey  <tom@tromey.com>
5902
5903         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5904         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5905
5906 2019-06-25  Tom Tromey  <tom@tromey.com>
5907
5908         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5909         check.
5910
5911 2019-06-25  Tom Tromey  <tom@tromey.com>
5912
5913         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5914         type to void.
5915         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5916         type to void.
5917         * tui/tui-source.c (tui_set_source_content): Update.
5918         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5919
5920 2019-06-25  Tom Tromey  <tom@tromey.com>
5921
5922         * tui/tui-win.c (window_name_completer, tui_set_focus)
5923         (tui_all_windows_info): Use name method.
5924         * tui/tui-data.h (struct tui_gen_win_info)
5925         (struct tui_source_window, struct tui_disasm_window)
5926         (struct tui_data_window, struct tui_cmd_window) <name>: New
5927         method.
5928         (tui_win_name): Don't declare.
5929         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5930         (tui_win_name): Remove.
5931
5932 2019-06-25  Tom Tromey  <tom@tromey.com>
5933
5934         * tui/tui-winsource.h (tui_update_source_window)
5935         (tui_update_source_window_as_is): Change parameter type.
5936         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5937         to be a tui_source_window_base.
5938         (tui_update_source_window_as_is): Likewise.
5939         * tui/tui-win.c (make_visible_with_new_height): Update.
5940
5941 2019-06-25  Tom Tromey  <tom@tromey.com>
5942
5943         * tui/tui-winsource.c (tui_erase_source_content)
5944         (tui_show_source_content, tui_show_exec_info_content)
5945         (tui_erase_exec_info_content): Use refresh_window method.
5946         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5947         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5948         from tui_refresh_win.
5949         (tui_data_window::refresh_window): New method.
5950         (tui_win_info::refresh, tui_source_window_base::refresh)
5951         (tui_refresh_all): Use refresh_window method.
5952         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5953         method.
5954         * tui/tui-regs.c (tui_display_register): Call refresh_window
5955         method.
5956         * tui/tui-layout.c (show_source_disasm_command)
5957         (show_source_or_disasm_and_command): Call refresh_window method.
5958         * tui/tui-data.h (struct tui_gen_win_info)
5959         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5960         New method.
5961
5962 2019-06-25  Tom Tromey  <tom@tromey.com>
5963
5964         * tui/tui.c (tui_rl_other_window, tui_enable)
5965         (tui_is_window_visible, tui_get_command_dimension): Update.
5966         * tui/tui-winsource.c (tui_update_source_window_as_is)
5967         (tui_clear_source_content, tui_erase_source_content)
5968         (tui_show_source_line, tui_source_window_base::refill)
5969         (tui_source_window_base::do_scroll_horizontal)
5970         (tui_source_window_base::set_is_exec_point_at)
5971         (tui_update_breakpoint_info, tui_set_exec_info_content)
5972         (tui_alloc_source_buffer, tui_line_is_displayed)
5973         (tui_addr_is_displayed): Update.
5974         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5975         (tui_check_and_display_highlight_if_needed)
5976         (tui_win_info::make_visible, tui_win_info::refresh)
5977         (tui_refresh_all): Update.
5978         * tui/tui-windata.c (tui_first_data_item_displayed)
5979         (tui_delete_data_content_windows, tui_erase_data_content)
5980         (tui_display_all_data, tui_data_window::refresh_all)
5981         (tui_check_data_values): Update.
5982         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5983         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5984         (tui_win_info::backward_scroll, tui_refresh_all_win)
5985         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5986         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5987         (tui_source_window_base::set_new_height)
5988         (tui_data_window::set_new_height)
5989         (make_invisible_and_set_new_height)
5990         (make_visible_with_new_height, new_height_ok)
5991         (parse_scrolling_args): Update.
5992         * tui/tui-stack.c (tui_show_frame_info): Update.
5993         * tui/tui-source.c (tui_set_source_content)
5994         (tui_set_source_content_nil, tui_source_is_displayed)
5995         (tui_source_window::do_scroll_vertical): Update.
5996         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5997         (tui_display_registers_from, tui_display_reg_element_at_line)
5998         (tui_check_register_values, tui_reg_command): Update.
5999         * tui/tui-layout.c (tui_default_win_height)
6000         (show_source_disasm_command, show_data, init_and_make_win)
6001         (show_source_or_disasm_and_command): Update.
6002         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
6003         (tui_redisplay_readline, tui_mld_flush)
6004         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
6005         (tui_getc): Update.
6006         * tui/tui-disasm.c (tui_set_disassem_content)
6007         (tui_disasm_window::do_scroll_vertical): Update.
6008         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
6009         Now virtual.
6010         (struct tui_win_info): Derive from tui_gen_win_info.
6011         <~tui_win_info>: Mark as override.
6012         <generic>: Remove member.
6013         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
6014         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
6015         (~tui_data_window, ~tui_win_info)
6016         (tui_free_all_source_wins_content): Update.
6017         * tui/tui-command.c (tui_refresh_cmd_win): Update.
6018
6019 2019-06-25  Tom Tromey  <tom@tromey.com>
6020
6021         * tui/tui-layout.c (init_and_make_win): Use new.
6022         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
6023         destructor, initializers.
6024         (tui_alloc_generic_win_info): Don't declare.
6025         * tui/tui-data.c (_locator): Add argument to constructor.
6026         (source_win, disasm_win): New globals.
6027         (exec_info): Remove.
6028         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
6029         Update.
6030         (tui_alloc_generic_win_info): Remove.
6031         (init_content_element): Use new.
6032         (tui_win_info::tui_win_info): Update.
6033         (free_content_elements) <case DATA_WIN>: Use delete.
6034
6035 2019-06-25  Tom Tromey  <tom@tromey.com>
6036
6037         * tui/tui-wingeneral.c (tui_refresh_win): Update.
6038         * tui/tui-windata.c (tui_first_data_item_displayed)
6039         (tui_delete_data_content_windows): Update.
6040         * tui/tui-win.c (tui_data_window::set_new_height): Update.
6041         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
6042         (tui_display_registers_from, tui_check_register_values): Update.
6043         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
6044         pointer.
6045         * tui/tui-data.c (init_content_element): Update.  Allocate the new
6046         window.
6047         (tui_free_data_content): Update.
6048         (free_content_elements) <case DATA_WIN>: Free the window.
6049
6050 2019-06-25  Tom Tromey  <tom@tromey.com>
6051
6052         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
6053         Update.
6054         * tui/tui-layout.c (make_command_window)
6055         (show_source_disasm_command, show_data, init_and_make_win)
6056         (show_source_or_disasm_and_command): Update.
6057         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
6058         method.
6059         <can_highight, is_highlighted>: Now bool.
6060         (tui_set_win_highlight): Don't declare.
6061         * tui/tui-data.c (tui_set_win_highlight): Remove.
6062
6063 2019-06-25  Tom Tromey  <tom@tromey.com>
6064
6065         * tui/tui-wingeneral.c (make_visible): Remove check of window
6066         type.
6067
6068 2019-06-25  Tom Tromey  <tom@tromey.com>
6069
6070         * tui/tui-win.c (tui_win_info::max_height)
6071         (tui_cmd_window::max_height): New methods.
6072         (new_height_ok): Call max_height.
6073         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
6074         <max_height>: New method.
6075
6076 2019-06-25  Tom Tromey  <tom@tromey.com>
6077
6078         * tui/tui-win.c (tui_source_window_base::set_new_height)
6079         (tui_data_window::set_new_height): New methods.
6080         (make_invisible_and_set_new_height): Call set_new_height method.
6081         * tui/tui-data.h (struct tui_win_info)
6082         (struct tui_source_window_base, struct tui_data_window)
6083         <set_new_height>: New method.
6084
6085 2019-06-25  Tom Tromey  <tom@tromey.com>
6086
6087         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
6088         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
6089         tui_refresh_data_win.
6090         * tui/tui-win.c (tui_source_window_base::refresh_all): New
6091         method.
6092         (tui_refresh_all_win): Call the refresh_all method.
6093         (tui_set_focus): Likewise.
6094         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
6095         (struct tui_source_window_base, struct tui_data_window) <refresh>:
6096         Likewise.
6097
6098 2019-06-25  Tom Tromey  <tom@tromey.com>
6099
6100         * tui/tui-winsource.h (tui_refill_source_window)
6101         (tui_set_is_exec_point_at): Don't declare.
6102         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
6103         (tui_source_window_base::refill): Rename from
6104         tui_refill_source_window.
6105         (tui_source_window_base::do_scroll_horizontal): Update.
6106         (tui_source_window_base::set_is_exec_point_at): Rename from
6107         tui_set_is_exec_point_at.
6108         (tui_update_all_breakpoint_info): Update.
6109         * tui/tui-stack.c (tui_show_frame_info): Update.
6110         * tui/tui-layout.c (show_data): Add cast.
6111         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
6112         * tui/tui-data.h (struct tui_source_window_base) <refill,
6113         set_is_exec_point_at>: New methods.
6114         (tui_source_windows, tui_add_to_source_windows): Update types.
6115         (tui_add_to_source_windows): Remove redundant declaration.
6116         * tui/tui-data.c (source_windows): Store tui_source_window_base.
6117         (tui_source_windows): Change return type.
6118         (tui_clear_source_windows_detail): Update.
6119         (tui_add_to_source_windows): Change type of parameter.
6120         (tui_free_all_source_wins_content): Update.
6121
6122 2019-06-25  Tom Tromey  <tom@tromey.com>
6123
6124         * tui/tui-wingeneral.c (tui_win_info::refresh)
6125         (tui_source_window_base::refresh): New methods.
6126         (tui_refresh_all): Call the refresh method.
6127         * tui/tui-data.h (struct tui_win_info)
6128         (struct tui_source_window_base) <refresh>: New method.
6129
6130 2019-06-25  Tom Tromey  <tom@tromey.com>
6131
6132         * tui/tui.h (tui_is_window_visible): Return bool.
6133         * tui/tui.c (tui_is_window_visible): Return bool.
6134         * tui/tui-wingeneral.c (tui_make_window, make_visible)
6135         (tui_make_visible, tui_make_invisible)
6136         (tui_win_info::make_visible)
6137         (tui_source_window_base::make_visible, make_all_visible)
6138         (tui_make_all_visible, tui_make_all_invisible): Update.
6139         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
6140         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
6141         bool.
6142         (struct tui_win_info, struct tui_source_window_base)
6143         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
6144         * tui/tui-data.c (tui_init_generic_part): Update.
6145
6146 2019-06-25  Tom Tromey  <tom@tromey.com>
6147
6148         * tui/tui-wingeneral.c (tui_win_info::make_visible)
6149         (tui_source_window_base::make_visible): New methods.
6150         (make_all_visible): Make method call.
6151         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
6152         (struct tui_source_window_base, struct tui_cmd_window): Override
6153         make_visible.
6154         (tui_win_is_source_type): Don't declare.
6155         * tui/tui-data.c (tui_win_is_source_type): Remove.
6156
6157 2019-06-25  Tom Tromey  <tom@tromey.com>
6158
6159         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
6160         NULL check.
6161
6162 2019-06-25  Tom Tromey  <tom@tromey.com>
6163
6164         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
6165         Inline constructor.  Add initializers for members.
6166         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
6167         constructors; now inline in class.
6168
6169 2019-06-25  Tom Tromey  <tom@tromey.com>
6170
6171         * tui/tui-regs.c (tui_show_registers): Update.
6172         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
6173         bool.
6174         * tui/tui-data.c (tui_data_window::clear_detail)
6175         (tui_data_window): Update.
6176
6177 2019-06-25  Tom Tromey  <tom@tromey.com>
6178
6179         * tui/tui-windata.c (tui_display_all_data)
6180         (tui_display_data_from_line, tui_display_data_from)
6181         (tui_check_data_values, tui_data_window::do_scroll_vertical):
6182         Update.
6183         * tui/tui-regs.c (tui_last_regs_line_no)
6184         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
6185         (tui_show_registers, tui_show_register_group)
6186         (tui_display_registers_from, tui_display_reg_element_at_line)
6187         (tui_display_registers_from_line, tui_check_register_values)
6188         (tui_reg_next, tui_reg_prev): Update.
6189         * tui/tui-layout.c (tui_set_layout, show_data): Update.
6190         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
6191         tui_data_window.
6192         (struct tui_win_info) <detail>: Remove.  Add new fields from
6193         tui_data_info.
6194         (TUI_DATA_WIN): Add cast.
6195         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
6196         (~tui_data_window): Simplify.
6197
6198 2019-06-25  Tom Tromey  <tom@tromey.com>
6199
6200         * tui/tui-layout.c (show_source_disasm_command)
6201         (show_source_or_disasm_and_command): Update.
6202         * tui/tui-io.c (update_cmdwin_start_line)
6203         (tui_redisplay_readline): Update.
6204         * tui/tui-data.h (struct tui_command_info): Remove.
6205         (struct tui_win_info) <detail>: Remove command_info member.
6206         (struct tui_data_window) <start_line>: New member, from
6207         tui_command_info.
6208         (TUI_CMD_WIN): Add casts.
6209
6210 2019-06-25  Tom Tromey  <tom@tromey.com>
6211
6212         * tui/tui-winsource.c (tui_update_source_window)
6213         (tui_refill_source_window)
6214         (tui_source_window_base::do_scroll_horizontal)
6215         (tui_update_breakpoint_info, tui_set_exec_info_content)
6216         (tui_show_exec_info_content, tui_erase_exec_info_content)
6217         (tui_clear_exec_info_content): Update.
6218         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
6219         Update.
6220         * tui/tui-win.c (make_invisible_and_set_new_height)
6221         (make_visible_with_new_height): Update.
6222         * tui/tui-source.c (tui_set_source_content)
6223         (tui_show_symtab_source): Update.
6224         * tui/tui-layout.c (extract_display_start_addr)
6225         (show_source_disasm_command, show_data)
6226         (make_source_or_disasm_window)
6227         (show_source_or_disasm_and_command): Update.
6228         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
6229         (tui_disasm_window::do_scroll_vertical): Remove shadowing
6230         "gdbarch".
6231         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
6232         to tui_source_window_base.
6233         (struct tui_win_info) <detail>: Remove source_info member.
6234         (struct tui_source_window_base) <has_locator>: Inline.
6235         Move contents from tui_source_info; rename has_locator member to
6236         m_has_locator.
6237         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
6238         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
6239         header file.
6240         (tui_source_window_base::clear_detail, ~tui_source_window_base):
6241         Simplify.
6242         (tui_free_all_source_wins_content): Cast to
6243         tui_source_window_base.
6244
6245 2019-06-25  Tom Tromey  <tom@tromey.com>
6246
6247         * tui/tui-win.c (make_invisible_and_set_new_height)
6248         (make_visible_with_new_height): Call has_locator method.
6249         * tui/tui-layout.c (show_source_disasm_command, show_data)
6250         (show_source_or_disasm_and_command): Update for bool change.
6251         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
6252         (tui_win_info) <has_locator>: New method.
6253         (struct tui_source_window_base) <has_locator>: New method.
6254         (tui_win_has_locator): Don't declare.
6255         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
6256         from tui_win_has_locator.
6257         (tui_source_window_base): Use false, not FALSE.
6258
6259 2019-06-25  Tom Tromey  <tom@tromey.com>
6260
6261         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
6262         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
6263         clear_detail method directly.
6264         (tui_clear_win_detail): Remove.
6265
6266 2019-06-25  Tom Tromey  <tom@tromey.com>
6267
6268         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
6269         "this", not TUI_DISASM_WIN.
6270
6271 2019-06-25  Tom Tromey  <tom@tromey.com>
6272
6273         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
6274         declare.
6275         * tui/tui-winsource.c
6276         (tui_source_window_base::do_scroll_horizontal): Rename from
6277         tui_horizontal_source_scroll.
6278         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
6279         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
6280         from tui_vertical_data_scroll.
6281         * tui/tui-win.h (tui_scroll): Don't declare.
6282         * tui/tui-win.c (tui_win_info::forward_scroll)
6283         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
6284         (tui_win_info::right_scroll): Rename and update.
6285         (tui_scroll_forward_command, tui_scroll_backward_command)
6286         (tui_scroll_left_command, tui_scroll_right_command): Update.
6287         (tui_scroll): Remove.
6288         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
6289         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
6290         from tui_vertical_source_scroll.
6291         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
6292         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
6293         from tui_vertical_disassem_scroll.
6294         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
6295         do_scroll_horizontal>: New methods.
6296         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
6297         Likewise.
6298         (struct tui_source_window_base): Add do_scroll_horizontal.
6299         (struct tui_source_window, struct tui_disasm_window): Add
6300         do_scroll_vertical.
6301         (struct tui_data_window, struct tui_cmd_window): Add
6302         do_scroll_horizontal and do_scroll_vertical.
6303         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
6304
6305 2019-06-25  Tom Tromey  <tom@tromey.com>
6306
6307         * tui/tui-data.h (struct tui_source_window_base): New struct.
6308         (struct tui_source_window): Derive from tui_source_window_base.
6309         (struct tui_disasm_window): New struct.
6310         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
6311         from tui_source_window::clear_detail.
6312         (tui_source_window_base): Rename from tui_source_window.
6313         (~tui_source_window_base): Rename from ~tui_source_window.
6314         (tui_alloc_win_info): Create a tui_disasm_window.
6315
6316 2019-06-25  Tom Tromey  <tom@tromey.com>
6317
6318         * tui/tui-data.h (struct tui_source_window)
6319         (struct tui_data_window): Declare destructors.
6320         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
6321         destructors.
6322         (tui_win_info): Simplify.
6323
6324 2019-06-25  Tom Tromey  <tom@tromey.com>
6325
6326         * tui/tui-winsource.c (tui_display_main)
6327         (tui_update_source_windows_with_addr)
6328         (tui_update_all_breakpoint_info): Update.
6329         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
6330         (new_height_ok, parse_scrolling_args): Update.
6331         * tui/tui-stack.c (tui_show_frame_info): Update.
6332         * tui/tui-data.h (struct tui_list): Remove.
6333         (tui_source_windows): Return a reference to a std::vector.
6334         * tui/tui-data.c (source_windows): Now a std::vector.
6335         (tui_source_windows): Change return type.
6336         (tui_clear_source_windows): Rewrite.
6337         (tui_clear_source_windows_detail, tui_add_to_source_windows)
6338         (tui_free_all_source_wins_content): Rewrite.
6339
6340 2019-06-25  Tom Tromey  <tom@tromey.com>
6341
6342         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
6343         (struct tui_data_window, struct tui_cmd_window): Declare
6344         clear_detail method.
6345         * tui/tui-data.c (tui_source_window::clear_detail)
6346         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
6347         methods.
6348         (tui_clear_win_detail): Simplify.
6349
6350 2019-06-25  Tom Tromey  <tom@tromey.com>
6351
6352         * tui/tui-layout.c (make_source_window, make_disasm_window)
6353         (make_source_or_disasm_window): Remove win_info_ptr parameter.
6354         Return the new window.
6355         (show_source_disasm_command, show_data)
6356         (show_source_or_disasm_and_command): Update.
6357
6358 2019-06-25  Tom Tromey  <tom@tromey.com>
6359
6360         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
6361         parameter.  Return the new window.
6362         (show_source_disasm_command): Update and remove NULL check.
6363         (show_source_or_disasm_and_command): Update.
6364
6365 2019-06-25  Tom Tromey  <tom@tromey.com>
6366
6367         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
6368
6369 2019-06-25  Tom Tromey  <tom@tromey.com>
6370
6371         * tui/tui-data.h (struct tui_win_info): Make constructor
6372         protected.  Make destructor virtual.  Add initializers.
6373         (tui_source_window, tui_data_window, tui_cmd_window): New
6374         classes.
6375         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
6376         constructor.  Add "type" parameter.
6377         (tui_source_window, tui_data_window, tui_cmd_window): New
6378         constructors.
6379         (tui_alloc_win_info): Instantiate the appropriate subclass.
6380
6381 2019-06-25  Tom Tromey  <tom@tromey.com>
6382
6383         * tui/tui-win.c (tui_resize_all): Use delete.
6384         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
6385         destructor.
6386         (tui_free_window): Don't declare.
6387         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
6388         Update.
6389
6390 2019-06-25  Tom Tromey  <tom@tromey.com>
6391
6392         * tui/tui-data.h (struct tui_win_info): Add constructor.
6393         * tui/tui-data.c (tui_alloc_win_info): Use new.
6394         (tui_free_window): Use delete.
6395
6396 2019-06-22  Tom Tromey  <tom@tromey.com>
6397
6398         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
6399         declare.
6400         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
6401
6402 2019-06-22  Tom Tromey  <tom@tromey.com>
6403
6404         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
6405         declare.
6406         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
6407
6408 2019-06-22  Tom de Vries  <tdevries@suse.de>
6409
6410         * dwarf2read.c (create_addrmap_from_aranges)
6411         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
6412         instead of '%zu'.
6413
6414 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
6415
6416         * dwarf2read.h (dwarf2_section_info_def): Remove.
6417         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
6418         * dwarf2read.c (struct dwo_sections) <types>: Change type to
6419         std::vector<dwarf2_section_info>.
6420         (struct dwo_file) <~dwo_file>: Remove.
6421         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
6422         types field.
6423         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
6424         (dwarf2_read_debug_names): Likewise.
6425         (create_debug_types_hash_table): Change parameter type to
6426         array_view, adjust code accordingly.
6427         (dwarf2_locate_dwo_sections): Adjust to std::vector.
6428         (partial_die_info::fixup): Likewise.
6429         (determine_prefix): Likewise.
6430         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
6431
6432 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6433
6434         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
6435         gdb_bfd_ref_ptr.
6436         <~dwo_file>: Remove call to gdb_bfd_unref.
6437         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
6438         gdb_bfd_ref_ptr::get.
6439
6440 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6441
6442         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
6443         type to htab_up.
6444         * dwarf2read.c (struct dwo_file): Initialize fields.
6445         <~dwo_file>: New.
6446         (free_dwo_file): Remove, move content to ~dwo_file.
6447         (struct dwo_file_deleter): Remove.
6448         (dwo_file_up>: Remove custom deleter.
6449         (free_dwo_files): Remove.
6450         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
6451         dwo_files.
6452         (process_skeletonless_type_units): Call unique_ptr::get.
6453         (allocate_dwo_file_hash_table): Add deleter to created hash
6454         table.  Change return type to htab_up.
6455         (lookup_dwo_file_slot): Don't memset dwo_file, call
6456         unique_ptr::get.
6457         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
6458         (create_dwo_unit_in_dwp_v2): Likewise.
6459         (open_and_init_dwo_file): Likewise.
6460         (free_dwo_file_from_slot): Remove.
6461
6462 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
6463
6464         * dwarf2read.h (struct dwarf2_section_info) <readin,
6465         is_virtual>: Change type to bool.
6466         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
6467         true instead of 1.
6468
6469 2019-06-19  Tom Tromey  <tom@tromey.com>
6470
6471         * tui/tui-data.h (tui_init_content_element): Don't declare.
6472
6473 2019-06-19  Tom Tromey  <tom@tromey.com>
6474
6475         * tui/tui-data.h (tui_init_win_info): Don't declare.
6476
6477 2019-06-19  Tom de Vries  <tdevries@suse.de>
6478
6479         * dwarf2read.h (abstract_to_concrete): Change type to
6480         std::unordered_map<sect_offset, std::vector<sect_offset>,
6481         gdb::hash_enum<sect_offset>>.
6482
6483 2019-06-19  Tom Tromey  <tromey@adacore.com>
6484
6485         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
6486         EVAL_AVOID_SIDE_EFFECTS specially.
6487
6488 2019-06-19  Tom Tromey  <tromey@adacore.com>
6489
6490         * source-cache.c (highlighter): New global.
6491         (source_cache::get_source_lines): Create a highlighter on demand.
6492
6493 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6494
6495         * defs.h (deprecated_interactive_hook): Delete declaration.
6496         * interps.c (clear_interpreter_hooks): Remove use of
6497         deprecated_interactive_hook.
6498         * top.c (deprecated_interactive_hook): Delete definition.
6499         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
6500
6501 2019-06-18  Tom de Vries  <tdevries@suse.de>
6502
6503         PR gdb/24515
6504         * dwarf2read.h (abstract_to_concrete): Change type from
6505         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
6506         std::unordered_map<sect_offset, std::vector<sect_offset>>.
6507         * dwarf2read.c (read_variable): Update.
6508         (dwarf2_fetch_die_loc_sect_off): Update.
6509
6510 2019-06-17  Tom de Vries  <tdevries@suse.de>
6511
6512         PR gdb/24617
6513         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
6514         accessing parent[parent_len - 1].
6515
6516 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
6517
6518         PR gdb/24364
6519         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
6520         call dtrace_process_dof with NULL dof.
6521
6522 2019-06-16  Tom de Vries  <tdevries@suse.de>
6523
6524         PR gdb/24445
6525         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
6526
6527 2019-06-16  Tom Tromey  <tom@tromey.com>
6528
6529         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
6530         (make_all_visible): Use address of member.
6531
6532 2019-06-16  Tom Tromey  <tom@tromey.com>
6533
6534         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
6535         (tui_free_window, free_content, free_content_elements): Remove
6536         unnecessary cast.
6537         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
6538         cast.
6539         * tui/tui-regs.c (tui_show_register_group)
6540         (tui_display_registers_from, tui_display_reg_element_at_line):
6541         Remove unnecessary cast.
6542
6543 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
6544
6545         * linux-nat.c (normal_mask): Delete.
6546         (_initialize_linux_nat): Don't initialise normal_mask.
6547
6548 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
6549
6550         PR gdb/24445
6551         * dwarf-index-write.h (write_psymtabs_to_index): Add
6552         dwz_basename parameter.
6553         * dwarf-index-write.c (write_gdbindex): Move file writing to
6554         write_gdbindex_1.  Change return type void.
6555         (assert_file_size): Move up, remove filename parameter.
6556         (write_gdbindex_1): New function.
6557         (write_debug_names): Change return type to void, call
6558         assert_file_size.
6559         (struct index_wip_file): New struct.
6560         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6561         file logic to index_wip_file.  Write index for dwz file if
6562         needed.
6563         (save_gdb_index_command): Pass basename of dwz file, if present.
6564         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6565         build-id of dwz file, if present.
6566         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6567         (dwarf2_get_dwz_file): Likewise.
6568         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6569         (dwarf2_get_dwz_file): Likewise.
6570
6571 2019-06-16  Tom Tromey  <tom@tromey.com>
6572
6573         * coffread.c (process_coff_symbol): Use xstrdup.
6574         * value.c (create_internalvar): Use xstrdup.
6575
6576 2019-06-16  Tom Tromey  <tom@tromey.com>
6577
6578         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6579         * breakpoint.c (stopin_command, stopat_command)
6580         (until_break_command, decode_location_default): Remove unnecessary
6581         cast.
6582         * utils.c (subset_compare): Remove unnecessary cast.
6583         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6584         cast.
6585         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6586         cast.
6587         * infcmd.c (path_command): Remove unnecessary cast.
6588         * coffread.c (decode_type): Remove unnecessary cast.
6589         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6590         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6591         * tui/tui-stack.c (tui_show_locator_content)
6592         (tui_show_frame_info): Remove unnecessary cast.
6593         * tui/tui-win.c (tui_scroll_forward_command)
6594         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6595         (parse_scrolling_args): Remove unnecessary cast.
6596         * tui/tui-data.c (init_win_info, tui_del_window)
6597         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6598         (free_content_elements): Remove unnecessary cast.
6599         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6600         unnecessary cast.
6601         * tui/tui-source.c (tui_set_source_content)
6602         (tui_vertical_source_scroll): Remove unnecessary cast.
6603         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6604         cast.
6605         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6606         * tui/tui-regs.c (tui_display_registers_from)
6607         (tui_display_register): Remove unnecessary cast.
6608         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6609         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6610         (make_visible): Remove unnecessary cast.
6611         * tui/tui-winsource.c (tui_erase_source_content)
6612         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6613         unnecessary cast.
6614         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6615         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6616         * stabsread.c (read_type, read_array_type, read_range_type):
6617         Remove unnecessary cast.
6618         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6619         (parse_symbol, parse_type, upgrade_type, parse_external)
6620         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6621         unnecessary cast.
6622         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6623
6624 2019-06-16  Tom Tromey  <tom@tromey.com>
6625
6626         * tui/tui-data.c (tui_alloc_generic_win_info)
6627         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6628         checks.
6629
6630 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6631             Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         * f-typeprint.c (f_print_type): Don't return early for not
6634         associated or not allocated types.
6635         (f_type_print_varspec_suffix): Add print_rank parameter and print
6636         ranks of array types in case they dangling.
6637         (f_type_print_base): Add print_rank parameter.
6638
6639 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6640
6641         * NEWS: Mention new MI commands.
6642         * break-catch-throw.c (enum exception_event_kind): Move to
6643         breakpoint.h.
6644         (print_mention_exception_catchpoint): Output text as a single
6645         message.
6646         (catch_exception_command_1): Rename to...
6647         (catch_exception_event): ...this, make non-static, update header
6648         command, and change some parameter types.
6649         (catch_catch_command): Update for changes to
6650         catch_exception_command_1.
6651         (catch_throw_command): Likewise.
6652         (catch_rethrow_command): Likewise.
6653         * breakpoint.c (enum exception_event_kind): Delete.
6654         * breakpoint.h (enum exception_event_kind): Moved here from
6655         break-catch-throw.c.
6656         (catch_exception_event): Declare.
6657         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6658         (mi_cmd_catch_throw): New function.
6659         (mi_cmd_catch_rethrow): New function.
6660         (mi_cmd_catch_catch): New function.
6661         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6662         'catch-catch' entries.
6663         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6664         (mi_cmd_catch_rethrow): Declare.
6665         (mi_cmd_catch_catch): Declare.
6666
6667 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6668
6669         * annotate.c (annotate_source_line): Change return type to void,
6670         update implementation to match.
6671         * annotate.h (annotate_source_line): Change return type to void,
6672         update header comment.
6673         * stack.c (print_frame_info): Don't change what frame information
6674         is printed based on whether annotations are on or not.
6675
6676 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6677
6678         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6679         (annotate_source): Make static.
6680         (annotate_source_line): Moved from source.c and renamed from
6681         identify_source_line.  Update the return type.
6682         * annotate.h (annotate_source): Delete declaration.
6683         (annotate_source_line): Declaration moved from source.h, and
6684         renamed from identify_source_line.  Return type updated.
6685         * source.c (identify_source_line): Moved to annotate.c and renamed
6686         to annotate_source_line.
6687         (info_line_command): Remove check of annotation_level.
6688         * source.h (identify_source_line): Move declaration to annotate.h
6689         and rename to annotate_source_line.
6690         * stack.c: Add 'annotate.h' include.
6691         (print_frame_info): Remove check of annotation_level before
6692         calling annotate_source_line.
6693
6694 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6695
6696         * source-cache.c (source_cache::get_plain_source_lines): Use
6697         open_source_file_with_line_charpos instead of just
6698         open_source_file, remove call to find_source_lines.
6699         (source_cache::get_source_lines): Likewise.
6700         * source.c (find_source_lines): Make static.
6701         (get_filename_and_charpos): Renamed into...
6702         (open_source_file_with_line_charpos): ..this along with changes to
6703         return a scoped_fd, and some other minor clean ups.
6704         (identify_source_line): Use open_source_file_with_line_charpos.
6705         (search_command_helper): Use open_source_file_with_line_charpos
6706         instead of just open_source_file, remove call to
6707         find_source_lines.
6708         * source.h (open_source_file_with_line_charpos): Declare new
6709         function.
6710         (find_source_lines): Delete declaration.
6711
6712 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6713
6714         * source.c (get_filename_and_charpos): Remove fullname
6715         parameter.
6716         (identify_source_line): Update call to get_filename_and_charpos.
6717
6718 2019-06-14  Tom Tromey  <tromey@adacore.com>
6719
6720         PR gdb/24502:
6721         * ui-style.h (skip_ansi_escape): Update comment.
6722         * ui-file.h (class no_terminal_escape_file): New class.
6723         * ui-file.c (no_terminal_escape_file::write)
6724         (no_terminal_escape_file::puts): New methods.
6725         * cli/cli-logging.c (handle_redirections): Use
6726         no_terminal_escape_file.
6727
6728 2019-06-14  Tom Tromey  <tromey@adacore.com>
6729
6730         * NEWS: Move convenience variable news above Python news.
6731
6732 2019-06-14  Tom Tromey  <tom@tromey.com>
6733
6734         * gnulib: Move directory to top-level.
6735         * configure.ac: Don't configure gnulib.
6736         * configure: Rebuild.
6737         * common/common-defs.h: Use new path to gnulib.
6738         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6739         (GNULIB_H): Remove.
6740         (INCGNU): Look in new gnulib location.
6741         (HFILES_NO_SRCDIR): Remove gnulib files.
6742         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6743         (generated_files): Remove GNULIB_H.
6744         ($(LIBGNU), all-lib): Remove targets.
6745         (distclean): Don't mention GNULIB_BUILDDIR.
6746         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6747
6748 2019-06-14  Tom Tromey  <tromey@adacore.com>
6749
6750         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6751         Warn if symbol file does not provide any symbols.
6752
6753 2019-06-14  Tom Tromey  <tromey@adacore.com>
6754
6755         * source.c (find_and_open_source): Respect basenames_may_differ.
6756
6757 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6758
6759         * annotate.c (annotate_breakpoints_invalid): Make use of
6760         scoped_restore_terminal_state.
6761         (annotate_frames_invalid): Likewise.
6762
6763 2019-06-14  Tom Tromey  <tromey@adacore.com>
6764
6765         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6766         allow assignment to an internalvar.
6767
6768 2019-06-14  Tom Tromey  <tromey@adacore.com>
6769
6770         * ada-lex.l: Allow "_" in attribute names.
6771
6772 2019-06-14  Tom Tromey  <tromey@adacore.com>
6773
6774         PR gdb/24653:
6775         * regcache.c (registers_changed): Don't call alloca.
6776         * top.c (execute_command): Don't call alloca.
6777
6778 2019-06-13  Pedro Alves  <palves@redhat.com>
6779
6780         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6781         'expression'.  When parsing an expression, error out if there's
6782         junk after "unlimited".
6783         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6784         (do_set_command): Adjust calls to is_unlimited_literal.
6785
6786 2019-06-13  Pedro Alves  <palves@redhat.com>
6787
6788         * compile/compile.c (make_compile_options_def_group): Add braces
6789         around array_view initializer.
6790         * thread.c (make_thread_apply_all_options_def_group)
6791         (make_thread_apply_all_options_def_group): Likewise.
6792
6793 2019-06-13  Pedro Alves  <palves@redhat.com>
6794
6795         * NEWS (New commands): Mention "maint test-options
6796         require-delimiter", "maint test-options unknown-is-error", "maint
6797         test-options unknown-is-operand" and "maint show
6798         test-options-completion-result".
6799         (New command options, command completion): New section.
6800         (Completion improvements): New section.
6801         Mention that you can abbreviate "unlimited".
6802
6803 2019-06-13  Pedro Alves  <palves@redhat.com>
6804
6805         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6806         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6807         * unittests/cli-utils-selftests.c (test_parse_flags)
6808         (test_parse_flags_qcs): Delete.
6809         (test_cli_utils): Don't call deleted functions.
6810
6811 2019-06-13  Pedro Alves  <palves@redhat.com>
6812
6813         * thread.c: Include "cli/cli-option.h".
6814         (tp_array_compar_ascending): Global.
6815         (tp_array_compar): Delete function.
6816         (tp_array_compar_ascending, tp_array_compar_descending): New
6817         functions.
6818         (ascending_option_def, qcs_flag_option_def)
6819         (thr_qcs_flags_option_defs)
6820         (make_thread_apply_all_options_def_group)
6821         (make_thread_apply_options_def_group): New.
6822         (thread_apply_all_command): Use gdb::option::process_options.
6823         (thread_apply_command_completer)
6824         (thread_apply_all_command_completer): New.
6825         (thread_apply_command): Use gdb::option::process_options.
6826         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6827         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6828         to generate help text of "thread apply".  Adjust "taas"'s help.
6829         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6830         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6831
6832 2019-06-13  Pedro Alves  <palves@redhat.com>
6833
6834         * thread.c (thread_apply_command): Check for invalid TID with
6835         isdigit instead of !isalpha.
6836
6837 2019-06-13  Pedro Alves  <palves@redhat.com>
6838
6839         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6840         (validate_flags_qcs): New.
6841         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6842         (validate_flags_qcs): Declare.
6843         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6844         (make_frame_apply_options_def_group): New.
6845         (frame_apply_command_count): Process options with
6846         gdb::option::process_options.
6847         (frame_apply_completer): New.
6848         (frame_apply_level_completer, frame_apply_all_completer)
6849         (frame_apply_completer): New.
6850         (_initialize_stack): Update help of "frame apply", "frame apply
6851         level", "frame apply all" and "faas" to mention supported options
6852         and install command completers.
6853         * stack.h (frame_apply_all_completer): Declare.
6854         * thread.c: Include "stack.h".
6855         (tfaas_command): Add "--".
6856         (_initialize_thread): Update help "tfaas" to mention supported
6857         options and install command completer.
6858
6859 2019-06-13  Pedro Alves  <palves@redhat.com>
6860
6861         * completer.c (complete_nested_command_line): New.
6862         (gdb_completion_word_break_characters_throw): Add assertion.
6863         * completer.h (complete_nested_command_line): Declare.
6864
6865 2019-06-13  Pedro Alves  <palves@redhat.com>
6866
6867         * stack.c (parse_backtrace_qualifiers): New.
6868         (backtrace_command): Use it.
6869         (backtrace_command_completer): Complete on qualifiers.
6870
6871 2019-06-13  Pedro Alves  <palves@redhat.com>
6872
6873         * frame.c: Include "cli/cli-option.h.
6874         (user_set_backtrace_options): New.
6875         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6876         Delete.
6877         (get_prev_frame): Adjust.
6878         (boolean_option_def, uinteger_option_def)
6879         (set_backtrace_option_defs): New.
6880         (_initialize_frame): Adjust and use
6881         gdb::option::add_setshow_cmds_for_options to install "set
6882         backtrace past-main" and "set backtrace past-entry".
6883         * frame.h: Include "cli/cli-option.h".
6884         (struct frame_print_options): Forward declare.
6885         (print_frame_arguments_all, print_frame_arguments_scalars)
6886         (print_frame_arguments_none): Declare.
6887         (print_entry_values): Delete declaration.
6888         (struct frame_print_options, user_frame_print_options): New.
6889         (struct set_backtrace_options): New.
6890         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6891         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6892         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6893         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6894         (list_args_or_locals): Add frame_print_options parameter.
6895         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6896         * python/py-framefilter.c (enumerate_args): Pass down
6897         USER_FRAME_PRINT_OPTIONS.
6898         * stack.c: Include "cli/cli-option.h".
6899         (print_frame_arguments_all, print_frame_arguments_scalars)
6900         (print_frame_arguments_none): Declare.
6901         (print_raw_frame_arguments, print_entry_values): Delete.
6902         (user_frame_print_options): New.
6903         (boolean_option_def, enum_option_def, frame_print_option_defs):
6904         New.
6905         (struct backtrace_cmd_options): New.
6906         (bt_flag_option_def): New.
6907         (backtrace_command_option_defs): New.
6908         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6909         (print_frame_arg, read_frame_arg, print_frame_args)
6910         (print_frame_info, print_frame): Add frame_print_options parameter
6911         and use it.
6912         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6913         (backtrace_command_1): Add frame_print_options and
6914         backtrace_cmd_options parameters and use them.
6915         (make_backtrace_options_def_group): New.
6916         (backtrace_command): Process command options with
6917         gdb::option::process_options.
6918         (backtrace_command_completer): New.
6919         (_initialize_stack): Extend "backtrace"'s help to mention
6920         supported options.  Install completer for "backtrace".
6921         Install some settings commands with add_setshow_cmds_for_options.
6922
6923 2019-06-13  Pedro Alves  <palves@redhat.com>
6924
6925         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6926         and that "set/show print raw frame-arguments" are now deprecated.
6927
6928         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6929         command.
6930         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6931         * stack.c (_initialize_stack): Install "set/show print
6932         raw-frame-arguments", and deprecate "set/show print raw
6933         frame-arguments".
6934         * valprint.c (_initialize_valprint): Deprecate "set/show print
6935         raw".
6936
6937 2019-06-13  Pedro Alves  <palves@redhat.com>
6938
6939         * compile/compile.c (struct compile_options): New.
6940         (compile_flag_option_def, compile_command_option_defs)
6941         (make_compile_options_def_group): New.
6942         (compile_file_command): Handle options with
6943         gdb::option::process_options.
6944         (compile_file_command_completer): New function.
6945         (compile_code_command): Handle options with
6946         gdb::option::process_options.
6947         (compile_code_command_completer): New function.
6948         (_initialize_compiler): Install completers for "compile code" and
6949         "compile file".  Mention available options in "compile code" and
6950         "compile code"'s help.
6951         * completer.c (advance_to_completion_word): New, factored out from
6952         ...
6953         (advance_to_expression_complete_word_point): ... this.
6954         (advance_to_filename_complete_word_point): New.
6955         * completer.h (advance_to_filename_complete_word_point): New
6956         declaration.
6957
6958 2019-06-13  Pedro Alves  <palves@redhat.com>
6959
6960         * compile/compile.c: Include "cli/cli-option.h".
6961         (compile_print_value): Scope data pointer is now a
6962         value_print_options pointer; adjust.
6963         (compile_print_command): Process options.  Scope data pointer is
6964         now a value_print_options pointer; adjust.
6965         (_initialize_compile): Update "compile print"'s help to include
6966         supported options.  Install a completer for "compile print".
6967         * cp-valprint.c (show_vtblprint, show_objectprint)
6968         (show_static_field_print): Delete.
6969         (_initialize_cp_valprint): Don't install "set print
6970         static-members", "set print vtbl", "set print object" here.
6971         * printcmd.c: Include "cli/cli-option.h" and
6972         "common/gdb_optional.h".
6973         (print_command_parse_format): Rework to fill in a
6974         value_print_options instead of a format_data.
6975         (print_value): Change parameter type from format_data pointer to
6976         value_print_options reference.  Adjust.
6977         (print_command_1): Process options.  Adjust to pass down a
6978         value_print_options.
6979         (print_command_completer): New.
6980         (_initialize_printcmd): Install print_command_completer as
6981         handle_brkchars completer for the "print" command.  Update
6982         "print"'s help to include supported options.
6983         * valprint.c: Include "cli/cli-option.h".
6984         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6985         here from cp-valprint.c.
6986         (boolean_option_def, uinteger_option_def)
6987         (value_print_option_defs, make_value_print_options_def_group):
6988         New.  Use gdb::option::add_setshow_cmds_for_options to install
6989         "set print elements", "set print null-stop", "set print repeats",
6990         "set print pretty", "set print union", "set print array", "set
6991         print address", "set print symbol", "set print array-indexes".
6992         * valprint.h: Include <string> and "cli/cli-option.h".
6993         (make_value_print_options_def_group): Declare.
6994         (print_value): Change parameter type from format_data pointer to
6995         value_print_options reference.
6996         (print_command_completer): Declare.
6997
6998 2019-06-13  Pedro Alves  <palves@redhat.com>
6999
7000         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
7001         (COMMON_SFILES): Add maint-test-settings.c.
7002         * cli/cli-decode.c (boolean_enums): New global, factored out from
7003         ...
7004         (add_setshow_boolean_cmd): ... here.
7005         * cli/cli-decode.h (boolean_enums): Declare.
7006         * cli/cli-option.c: New file.
7007         * cli/cli-option.h: New file.
7008         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
7009         factored out from ...
7010         (parse_cli_boolean_value(const char *)): ... this.
7011         (is_unlimited_literal): Change parameter type to pointer to
7012         pointer.  Adjust and advance ARG pointer.
7013         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7014         (parse_cli_var_enum): New, factored out from ...
7015         (do_set_command): ... this.  Adjust.
7016         * cli/cli-setshow.h (parse_cli_boolean_value)
7017         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
7018         (parse_cli_var_enum): Declare.
7019         * cli/cli-utils.c: Include "cli/cli-option.h".
7020         (get_ulongest): New.
7021         * cli/cli-utils.h (get_ulongest): Declare.
7022         (check_for_argument): New overloads.
7023         * maint-test-options.c: New file.
7024
7025 2019-06-13  Pedro Alves  <palves@redhat.com>
7026
7027         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
7028         parse a range if "-" is at the end of the string.
7029
7030 2019-06-13  Pedro Alves  <palves@redhat.com>
7031
7032         * cli/cli-setshow.c (parse_auto_binary_operation)
7033         (parse_cli_boolean_value): Don't allow "o".
7034
7035 2019-06-13  Pedro Alves  <palves@redhat.com>
7036
7037         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
7038         * NEWS: Mention maint test-settings KIND.
7039         * maint-test-settings.c: New file.
7040
7041 2019-06-13  Pedro Alves  <palves@redhat.com>
7042
7043         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
7044         completer.
7045         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
7046         "set" completers.
7047
7048 2019-06-13  Pedro Alves  <palves@redhat.com>
7049
7050         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
7051         after item.
7052
7053 2019-06-13  Pedro Alves  <palves@redhat.com>
7054
7055         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
7056
7057 2019-06-13  Pedro Alves <palves@redhat.com>
7058
7059         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
7060         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
7061         call.
7062         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
7063         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
7064         calls.
7065         (check_for_argument): Skip spaces after argument.
7066
7067 2019-06-13  Pedro Alves  <palves@redhat.com>
7068
7069         * thread.c (thread_apply_command): Adjust TID parsing.
7070         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
7071         detected before end of string.
7072         (tid_is_in_list): Error out if LIST is invalid.
7073
7074 2019-06-13  Pedro Alves  <palves@redhat.com>
7075
7076         * completer.c (complete_line_internal_1): Rewind completion word
7077         point.
7078         (completion_tracker::advance_custom_word_point_by): Change
7079         parameter type to int.
7080         * completer.h (completion_tracker::advance_custom_word_point_by):
7081         Likewise.
7082
7083 2019-06-13  Pedro Alves  <palves@redhat.com>
7084
7085         * completer.c (advance_to_completion_word): Handle delimiters.
7086
7087 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
7088
7089         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
7090
7091 2019-06-11  Tom Tromey  <tom@tromey.com>
7092
7093         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
7094         (xmalloc_failed): Move to alloc.c.
7095         * alloc.c: New file.
7096         * Makefile.in (COMMON_SFILES): Add alloc.c.
7097
7098 2019-06-11  Tom Tromey  <tom@tromey.com>
7099
7100         * nat/linux-waitpid.c: Don't include server.h.
7101         (linux_debug): Remove.
7102         (my_waitpid): Update.
7103
7104 2019-06-11  Tom Tromey  <tromey@adacore.com>
7105
7106         * infcall.c (_initialize_infcall): Remove trailing newline from
7107         help.
7108         * user-regs.c (_initialize_user_regs): Remove trailing newline
7109         from help.
7110         * typeprint.c (_initialize_typeprint): Remove trailing newline
7111         from help.
7112         * reverse.c (_initialize_reverse): Remove trailing newlines from
7113         help.
7114         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
7115         from help.
7116         * language.c (add_set_language_command): Remove trailing newline
7117         from help.
7118         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
7119         help.
7120         * disasm.c (_initialize_disasm): Remove trailing newline from
7121         help.
7122         * top.c (init_main): Remove trailing newline from help.
7123         * interps.c (_initialize_interpreter): Remove trailing newline
7124         from help.
7125         * btrace.c (_initialize_btrace): Remove trailing newlines from
7126         help.
7127         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
7128         from help.
7129         * python/python.c (_initialize_python): Remove trailing newline
7130         from help.
7131         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
7132         help.
7133         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
7134         from help.  Reformat some text.
7135         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
7136         from help.
7137         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
7138         newline from help.
7139
7140 2019-06-11  Tom Tromey  <tromey@adacore.com>
7141
7142         * darwin-nat.c (darwin_decode_exception_message)
7143         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
7144
7145 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7146
7147         * valops.c (value_slice): Check for not allocated or not
7148         associated values.
7149
7150 2019-06-10  Tom de Vries  <tdevries@suse.de>
7151
7152         PR gdb/24618
7153         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
7154         sure an empty slot (defined by a 32-bit zero pair) is recognized as
7155         invalid.
7156
7157 2019-06-10  Tom de Vries  <tdevries@suse.de>
7158
7159         PR gdb/24611
7160         * linespec.c (linespec_lexer_lex_string): Remove incorrect
7161         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
7162
7163 2019-06-10  Tom de Vries  <tdevries@suse.de>
7164
7165         PR symtab/24545
7166         * symtab.c (struct demangled_name_entry): Add language field.
7167         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
7168         static minimal symbol".  Set and use language field.
7169
7170 2019-06-10  Tom Tromey  <tromey@adacore.com>
7171
7172         * ada-lang.c (_initialize_ada_language): Update help text.
7173
7174 2019-06-10  Tom Tromey  <tromey@adacore.com>
7175
7176         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
7177         with a newline.
7178         * guile/guile.c (handle_boot_error): Don't end warning with a
7179         newline.
7180         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
7181         warning with a newline.
7182         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
7183         newline.
7184         (s12z_frame_cache): Likewise.
7185         * dwarf-index-cache.c (index_cache::store): Don't end warning with
7186         a newline.
7187         * solib-svr4.c (disable_probes_interface): Don't end warning with
7188         a newline.
7189         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
7190         newline.
7191         * python/python.c (do_finish_initialization): Don't end warning
7192         with a newline.
7193
7194 2019-06-10  Tom Tromey  <tom@tromey.com>
7195
7196         * python/py-breakpoint.c (gdbpy_breakpoint_created)
7197         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
7198         gdbpy_enter.
7199
7200 2019-06-10  Tom Tromey  <tromey@adacore.com>
7201
7202         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
7203         data.
7204         (elf_new_init): Don't call stabsread_new_init.
7205         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
7206         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
7207         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
7208
7209 2019-06-10  Tom de Vries  <tdevries@suse.de>
7210
7211         PR symtab/16264
7212         PR symtab/24517
7213         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
7214
7215 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
7216
7217         * source.c (find_and_open_source): Also rewrite relative file
7218         names.
7219
7220 2019-04-26  Amos Bird  <amosbird@gmail.com>
7221
7222         * annotate.c (annotate_thread_exited): Add "thread-exited"
7223         annotation.
7224
7225 2019-06-06  Tom Tromey  <tromey@adacore.com>
7226
7227         * maint.h (class scoped_command_stats): Use
7228         DISABLE_COPY_AND_ASSIGN.
7229         <print_time>: New method.
7230         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
7231         print_time.
7232         (scoped_command_stats::print_time): New method.
7233
7234 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7235
7236         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
7237         instructions of lengths 6 or 8 bytes.
7238
7239 2019-06-04  Pedro Alves  <palves@redhat.com>
7240
7241         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
7242
7243         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
7244         * breakpoint.c (condition_completer): Likewise.
7245         * cli/cli-dump.c (scan_expression): Likewise.
7246         * common/filestuff.c (mkdir_recursive): Likewise.
7247         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
7248         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
7249         (gdb_abspath): Likewise.
7250         * compile/compile-cplus-types.c
7251         (compile_cplus_instance::decl_name): Likewise.
7252         * completer.c (complete_explicit_location):
7253         (signal_completer, reg_or_group_completer_1): Likewise.
7254         * cp-support.c (cp_remove_params_if_any): Likewise.
7255         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
7256         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
7257         * infcmd.c (strip_bg_char): Likewise.
7258         * linespec.c (copy_token_string): Likewise.
7259         * mi/mi-main.c (output_cores): Likewise.
7260         * psymtab.c (psymtab_search_name):
7261         * symfile.c (test_set_ext_lang_command): Likewise.
7262         * target.c (target_fileio_read_stralloc): Likewise.
7263         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
7264         * value.c (complete_internalvar): Likewise.
7265
7266 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
7267
7268         Add objfile property to gdb.Type.
7269         * NEWS: Mention Python API addition.
7270         * python/py-type.c (typy_get_objfile): New method.
7271
7272 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7273
7274         * NEWS: Mention the new set|show style [title|highlight].
7275         Mention changes to "show style", "help" and "apropos".
7276
7277 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7278
7279         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
7280         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
7281         instead of print_help_for_command.
7282         (print_doc_of_command): New function.
7283         (help_list): Add 'apropos -v word' suggestion.
7284         (print_help_for_command): Style the command name using title style.
7285         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
7286         (_initialize_cli_cmds): Describe -v in apropos_command help.
7287
7288 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7289
7290         * cli/cli-style.h (cli_style_option): Add name in constructor,
7291         add m_name class member, add constructor with intensity,
7292         add name class function.
7293         (cli_style_option::add_setshow_commands): Remove name argument.
7294         (highlight_style, title_style): New styles.
7295         * cli/cli-style.c (do_show): New function that shows a style
7296         characteristic styling the style name with itself.
7297         (set_style_name): New function.
7298         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
7299         Update all callers according to the changes in cli/cli-style.h.
7300         * utils.h (fputs_highlighted): New function.
7301         * utils.c (fputs_highlighted): Likewise.
7302
7303 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7304
7305         * NEWS: Mention new pipe command and new convenience variables.
7306
7307 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7308
7309         * cli/cli-cmds.c (pipe_command): New function.
7310         (_initialize_cli_cmds): Call add_com for pipe_command.
7311         Define | as an alias for pipe.
7312         (exit_status_set_internal_vars): New function.
7313         (shell_escape): Call exit_status_set_internal_vars.
7314         cli/cli-decode.c (find_command_name_length): Recognize | as
7315         a single character command.
7316
7317 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7318
7319         * gdbcmd.h (execute_command_to_ui_file): New declaration.
7320         top.c (execute_command_to_ui_file): New function, mostly a copy
7321         of execute_command_to_string.
7322         (execute_command_to_string): Implement by calling
7323         execute_command_to_ui_file.
7324
7325 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7326
7327         * top.h (saved_command_line): Remove declaration.
7328         * top.c (previous_saved_command_line, previous_repeat_arguments):
7329         New variables.
7330         (saved_command_line): Make static, define together with other
7331         'repeat variables'.
7332         (dont_repeat): Clear repeat_arguments.
7333         (repeat_previous, get_saved_command_line, save_command_line):
7334         New functions.
7335         (gdb_init): Initialize saved_command_line
7336         and previous_saved_command_line.
7337         * main.c (captured_main_1): Remove saved_command_line initialization.
7338         * event-top.c (handle_line_of_input): Update to use
7339         the new 'repeat' related functions instead of direct access to
7340         saved_command_line.
7341         * command.h (repeat_previous, get_saved_command_line,
7342         save_command_line): New declarations.
7343         (dont_repeat): Add comment.
7344
7345 2019-05-30  Tom Tromey  <tromey@adacore.com>
7346
7347         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
7348         Fix comment.
7349         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
7350
7351 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
7352
7353         PR cli/24587
7354         * completer.c (complete): Initialize variable word.
7355
7356 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
7357
7358         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7359         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
7360         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
7361         'body' is NULL to the outter 'if', protecting the '!is_define'
7362         situation as well.
7363
7364 2019-05-29  Tom Tromey  <tromey@adacore.com>
7365
7366         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
7367         (dwarf_unknown): New function.
7368         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
7369         (dwarf_type_encoding_name): Use dwarf_unknown.
7370
7371 2019-05-29  Tom Tromey  <tromey@adacore.com>
7372
7373         PR c++/20020:
7374         * cp-valprint.c (cp_print_value_fields): Call
7375         cp_print_static_field inside "try".
7376
7377 2019-05-29  Tom Tromey  <tromey@adacore.com>
7378
7379         * inflow.c (struct terminal_info): Add default operator=.
7380         * configure: Rebuild.
7381         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
7382         -Wdeprecated-copy-dtor, -Wredundant-move.
7383
7384 2019-05-29  Tom Tromey  <tromey@adacore.com>
7385
7386         * NEWS: Add entry.
7387         * infcmd.c (print_return_value_1): Handle finish_print
7388         option.
7389         (show_print_finish): New function.
7390         (_initialize_infcmd): Add "set/show print finish" commands.
7391         * valprint.c (user_print_options): Initialize new member.
7392         * valprint.h (struct value_print_options) <finish_print>: New
7393         member.
7394
7395 2019-05-28  Tom Tromey  <tromey@adacore.com>
7396
7397         * ada-lang.c (ada_remove_Xbn_suffix)
7398         (find_old_style_renaming_symbol)
7399         (parse_old_style_renaming): Remove.
7400         (ada_find_renaming_symbol): Don't call
7401         find_old_style_renaming_symbol.
7402         (ada_is_renaming_symbol): Rename from
7403         ada_find_renaming_symbol.  Remove "block" parameter.  Return
7404         bool.  Now static.
7405         (ada_read_var_value): Update and simplify.
7406         * ada-exp.y (write_var_or_type): Remove old code.
7407
7408 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
7409
7410         PR gdb/25010
7411         * event-top.c: Remove include comment.
7412         * inflow.c (class scoped_ignore_sigttou): Move from here...
7413         * inflow.h (class scoped_ignore_sigttou): ...to here.
7414         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
7415         * top.c:  Remove include comment.
7416
7417 2019-05-27  Tom Tromey  <tom@tromey.com>
7418
7419         * NEWS: Fix typo.
7420
7421 2019-05-22  Tom Tromey  <tromey@adacore.com>
7422
7423         * target.c (target_follow_exec): Constify parameter.
7424         * target-delegates.c: Rebuild.
7425         * remote.c (remote_target::follow_exec): Constify parameter.
7426         * infrun.c (follow_exec): Constify parameter.
7427         * target.h (struct target_ops) <follow_exec>: Constify parameter.
7428         (target_follow_exec): Likewise.
7429
7430 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7431
7432         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
7433         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
7434
7435 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
7436
7437         * NEWS: Add debugredirect and testsuite sections.
7438
7439 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
7440
7441         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
7442         target descriptions using exclusively floating point register name
7443         aliases.
7444
7445 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
7446
7447         PR gdb/18644:
7448         * f-lang.c (build_fortran_types): Handle the case where
7449         gdbarch_floatformat_for_type returns a nullptr.
7450
7451 2019-05-21  Tom de Vries  <tdevries@suse.de>
7452
7453         PR cli/24587
7454         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
7455
7456 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7457
7458         PR gdb/18644:
7459         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
7460         16-byte floats.
7461         * i386-tdep.c (i386_floatformat_for_type): Use
7462         floatformats_ia64_quad for the 16-byte floating point component
7463         within a fortran 32-byte complex number.
7464
7465 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7466
7467         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
7468         delete default constructor.
7469         (find_partial_die): Update to return const struct.
7470         (partial_die_parent_scope): Move variable declaration into scope
7471         of its use and change its type to auto.
7472         (guess_partial_die_structure_name): Likewise.
7473         (partial_die_info::fixup): Likewise.
7474
7475 2019-05-17  Tom Tromey  <tromey@adacore.com>
7476
7477         * source.c (find_and_open_source): Remove cast.
7478
7479 2019-05-17  Tom Tromey  <tromey@adacore.com>
7480
7481         * annotate.c (annotate_source): Make "filename" const.
7482         * annotate.h (annotate_source): Use const.
7483
7484 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7485
7486         * disasm.c (set_disassembler_options): Send errors to stderr.
7487
7488 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7489
7490         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
7491         (cli_interp_base::set_logging): Check debug_redirect.
7492         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
7493         * cli/cli-logging.c (debug_redirect): Add static variable.
7494         (pop_output_files): Add default param.
7495         (handle_redirections): Print debug setting.
7496         (show_logging_command): Likewise.
7497         (_initialize_cli_logging): Add debugredirect command.
7498         * interps.c (current_interp_set_logging): Add debug_redirect
7499         parameter.
7500         * interps.h (set_logging): Add debug_redirect parameter.
7501         (current_interp_set_logging): Likewise.
7502         * mi/mi-common.h: Likewise.
7503         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
7504
7505 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
7506             Tom Tromey  <tromey@adacore.com>
7507
7508         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
7509         directly.
7510         * cli/cli-interp.h (make_logging_output): Remove declaration.
7511         * cli/cli-logging.c (make_logging_output): Remove function.
7512         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
7513         directly.
7514         * ui-file.c (tee_file::tee_file): Remove bools.
7515         (tee_file::~tee_file): Remove deletes.
7516         * ui-file.h (tee_file): Remove bools.
7517
7518 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
7519
7520         * mi/mi-cmds.h (mi_cmd_complete): New function.
7521         * mi/mi-main.c (mi_cmd_complete): Likewise.
7522         * mi/mi-cmds.c: Define new MI command -complete.
7523         * NEWS: Mention new -complete command.
7524
7525 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
7526
7527         * completer.h (complete): New function.
7528         * completer.c (complete): Likewise.
7529         * cli/cli-cmds.c: (complete_command): Update to use new complete()
7530         function defined in completer.h.
7531
7532 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
7533
7534         * MAINTAINERS (Write After Approval): Add myself.
7535
7536 2019-05-17  Tom de Vries  <tdevries@suse.de>
7537
7538         PR gdb/24094
7539         * dwarf2read.c (struct cu_partial_die_info): New struct.
7540         (find_partial_die): Return cu_partial_die_info.
7541         (partial_die_parent_scope, guess_partial_die_structure_name)
7542         (partial_die_info::fixup): Handle new return type of find_partial_die.
7543
7544 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7545
7546         PR breakpoints/24541
7547         * stap-probe.c (stap_parse_register_operand): Make "regname" an
7548         "std::string", simplifying the algorithm.
7549
7550 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7551
7552         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7553         (stap_static_probe_ops::get_probes): Likewise.
7554
7555 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7556
7557         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7558         '-')" and "else if".
7559         (stap_parse_single_operand): Join checks for
7560         "gdbarch_stap_parse_special_token_p" and
7561         "gdbarch_stap_parse_special_token" in the same "if" statement.
7562         Invert check when verifying for operation on register
7563         displacement.
7564
7565 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7566
7567         * stap-probe.c (stap_get_opcode): Update comment.
7568         (stap_get_expected_argument_type): Likewise.
7569         (handle_stap_probe): Likewise.
7570
7571 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7572
7573         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7574         return type to 'bool'.  Adjust comment.  Use 'bool' when
7575         appropriate.
7576         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7577         * stap-probe.c (stap_parse_argument_1): Likewise.
7578         (stap_is_operator): Likewise.
7579         (stap_is_generic_prefix): Likewise.
7580         (stap_is_register_prefix): Likewise.
7581         (stap_is_register_indirection_prefix): Likewise.
7582         (stap_is_integer_prefix): Likewise.
7583         (stap_generic_check_suffix): Likewise.
7584         (stap_check_integer_suffix): Likewise.
7585         (stap_check_register_suffix): Likewise.
7586         (stap_check_register_indirection_suffix): Likewise.
7587         (stap_parse_register_operand): Likewise.
7588         (stap_parse_single_operand): Likewise.
7589         (stap_parse_argument_1): Likewise.
7590         (stap_probe::get_argument_count): Likewise.
7591         (stap_is_operator): Likewise.
7592
7593 2019-05-16  Tom Tromey  <tromey@adacore.com>
7594
7595         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7596         keyword to foreach.
7597
7598 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7599
7600         * linux-thread-db.c (try_thread_db_load_1): Change return type
7601         to bool.
7602         (try_thread_db_load): Likewise.
7603         (try_thread_db_load_from_pdir_1): Likewise.
7604         (try_thread_db_load_from_pdir): Likewise.
7605         (try_thread_db_load_from_sdir): Likewise.
7606         (try_thread_db_load_from_dir): Likewise.
7607         (thread_db_load_search): Likewise.
7608         (has_libpthread): Likewise.
7609         (thread_db_load): Likewise.
7610
7611 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7612
7613         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7614         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7615         NULL, and complain/return if that's the case.
7616
7617 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7618
7619         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7620         (advance, posn, abstract_read_memory): New functions.
7621         [struct mem_read_abstraction]: New struct.
7622         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7623
7624 2019-05-14  Tom Tromey  <tromey@adacore.com>
7625
7626         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7627         value is not lval_memory.
7628
7629 2019-05-14  Tom Tromey  <tromey@adacore.com>
7630
7631         * solib.c (info_sharedlibrary_command): Style the file name.
7632
7633 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7634
7635         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7636         (aarch64_vnv_type): Likewise.
7637         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7638         * common/tdesc.c: Likewise.
7639         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7640         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7641         * features/aarch64-fpu.xml: Add ieee half view.
7642         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7643         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7644         * gdbtypes.h (struct builtin_type): Likewise.
7645         (struct objfile_type): Likewise.
7646
7647 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7648
7649         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7650         typo.
7651         * location.h (string_to_event_location): Likewise.
7652
7653 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7654
7655         GDB 8.3 released.
7656
7657 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7658
7659         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7660         New variable declaration.
7661         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7662         New variable.
7663         (print_one_breakpoint): Use ui_out::test_flags and new global
7664         variable to compute use_fixed_output.
7665         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7666         Remove.
7667         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7668         (mi_multi_location_breakpoint_output_fixed): Remove.
7669         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7670         new variable.
7671         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7672         fix_multi_location_breakpoint_output flag if version >= 3.
7673         * ui-out.h (enum ui_out_flag)
7674         <fix_multi_location_breakpoint_output>: New enumerator.
7675
7676 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7677
7678         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7679
7680 2019-05-10  Tom Tromey  <tromey@adacore.com>
7681
7682         * ada-lang.c (catch_ada_completer): New function.
7683         (_initialize_ada_language): Use it.
7684
7685 2019-05-10  Tom Tromey  <tromey@adacore.com>
7686
7687         * thread.c (print_thread_info): Make "requested_threads" const.
7688         * gdbthread.h (print_thread_info): Make "requested_threads"
7689         const.
7690         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7691         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7692
7693 2019-05-08  Tom Tromey  <tom@tromey.com>
7694
7695         * gdbtypes.c (objfile_type_data): Change type.
7696         (objfile_type, _initialize_gdbtypes): Update.
7697
7698 2019-05-08  Tom Tromey  <tom@tromey.com>
7699
7700         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7701         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7702         (_initialize_dwarf2_frame): Update.
7703
7704 2019-05-08  Tom Tromey  <tom@tromey.com>
7705
7706         * objc-lang.c (objc_objfile_data): Change type.
7707         (find_methods): Update.
7708         (_initialize_objc_lang): Remove.
7709
7710 2019-05-08  Tom Tromey  <tom@tromey.com>
7711
7712         * stabsread.c (rs6000_builtin_type_data): Change type.
7713         (rs6000_builtin_type, _initialize_stabsread): Update.
7714
7715 2019-05-08  Tom Tromey  <tom@tromey.com>
7716
7717         * mips-tdep.c (mips_pdr_data): Remove.
7718         (_initialize_mips_tdep): Update.
7719
7720 2019-05-08  Tom Tromey  <tom@tromey.com>
7721
7722         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7723         (hppa_init_objfile_priv_data, read_unwind_info)
7724         (find_unwind_entry, _initialize_hppa_tdep): Update.
7725
7726 2019-05-08  Tom Tromey  <tom@tromey.com>
7727
7728         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7729         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7730         on obstack.
7731         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7732
7733 2019-05-08  Tom Tromey  <tom@tromey.com>
7734
7735         * mdebugread.c (basic_type_data): Change type.
7736         (basic_type, _initialize_mdebugread): Update.
7737
7738 2019-05-08  Tom Tromey  <tom@tromey.com>
7739
7740         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7741
7742 2019-05-08  Tom Tromey  <tom@tromey.com>
7743
7744         * nto-tdep.c (nto_inferior_data_reg): Change type.
7745         (nto_inferior_data): Update.
7746         (nto_inferior_data_cleanup, nto_new_inferior_data)
7747         (_initialize_nto_tdep): Remove.
7748         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7749
7750 2019-05-08  Tom Tromey  <tom@tromey.com>
7751
7752         * ada-lang.c (struct ada_inferior_data): Add initializers.
7753         (ada_inferior_data): Change type.
7754         (ada_inferior_data_cleanup): Remove.
7755         (get_ada_inferior_data, ada_inferior_exit)
7756         (struct ada_pspace_data): Add initializers, destructor.
7757         (ada_pspace_data_handle): Change type.
7758         (get_ada_pspace_data): Update.
7759         (ada_pspace_data_cleanup): Remove.
7760
7761 2019-05-08  Tom Tromey  <tom@tromey.com>
7762
7763         * coffread.c (struct coff_symfile_info): Add initializers.
7764         (coff_objfile_data_key): Move lower.  Change type.
7765         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7766         Update.
7767         (coff_free_info): Remove.
7768
7769 2019-05-08  Tom Tromey  <tom@tromey.com>
7770
7771         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7772         (fbsd_pspace_data_handle): Move lower.  Change type.
7773         (get_fbsd_pspace_data): Update.
7774         (fbsd_pspace_data_cleanup): Remove.
7775         (_initialize_fbsd_tdep): Update.
7776
7777 2019-05-08  Tom Tromey  <tom@tromey.com>
7778
7779         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7780         (get_ada_tasks_pspace_data): Update.
7781         (ada_tasks_pspace_data_cleanup): Remove.
7782         (_initialize_tasks): Update.
7783         (ada_tasks_inferior_data_handle): Change type.
7784         (get_ada_tasks_inferior_data): Update.
7785         (ada_tasks_inferior_data_cleanup): Remove.
7786         (struct ada_tasks_pspace_data): Add initializers.
7787
7788 2019-05-08  Tom Tromey  <tom@tromey.com>
7789
7790         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7791         * symfile-debug.c (debug_sym_get_probes): Change type.
7792         * stap-probe.c (handle_stap_probe):
7793         (stap_static_probe_ops::get_probes): Change type.
7794         * probe.h (class static_probe_ops) <get_probes>: Change type.
7795         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7796         (parse_probes_in_pspace): Update.
7797         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7798         Update.
7799         (any_static_probe_ops::get_probes): Change type.
7800         * elfread.c (elfread_data): New typedef.
7801         (probe_key): Change type.
7802         (elf_get_probes): Likewise.  Update.
7803         (probe_key_free): Remove.
7804         (_initialize_elfread): Update.
7805         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7806         Change type.
7807         (dtrace_process_dof_probe, dtrace_process_dof)
7808         (dtrace_static_probe_ops::get_probe): Change type.
7809
7810 2019-05-08  Tom Tromey  <tom@tromey.com>
7811
7812         * xcoffread.c (struct xcoff_symfile_info): Rename from
7813         coff_symfile_info.  Add initializers.
7814         (xcoff_objfile_data_key): Move lower.  Change type.
7815         (XCOFF_DATA): Rewrite.
7816         (xcoff_free_info): Remove.
7817         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7818         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7819         (xcoff_initial_scan): Update.
7820
7821 2019-05-08  Tom Tromey  <tom@tromey.com>
7822
7823         * solib-svr4.c (struct svr4_info): Add initializers and
7824         destructor.
7825         <probes_table>: Now an htab_up.
7826         (solib_svr4_pspace_data): Change type.
7827         (free_probes_table): Simplify.
7828         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7829         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7830         (probes_table_remove_objfile_probes, register_solib_event_probe)
7831         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7832         (_initialize_svr4_solib): Update.
7833
7834 2019-05-08  Tom Tromey  <tom@tromey.com>
7835
7836         * remote.c (remote_pspace_data): Change type.
7837         (remote_pspace_data_cleanup): Remove.
7838         (get_remote_exec_file, set_pspace_remote_exec_file)
7839         (_initialize_remote): Update.
7840
7841 2019-05-08  Tom Tromey  <tom@tromey.com>
7842
7843         * breakpoint.c (breakpoint_objfile_key): Change type.
7844         (get_breakpoint_objfile_data): Update.
7845         (free_breakpoint_objfile_data): Remove.
7846         (_initialize_breakpoint): Update.
7847
7848 2019-05-08  Tom Tromey  <tom@tromey.com>
7849
7850         * linux-tdep.c (struct linux_info): Add initializers.
7851         (linux_inferior_data): Move.  Change type.
7852         (invalidate_linux_cache_inf): Update.
7853         (linux_inferior_data_cleanup): Remove.
7854         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7855
7856 2019-05-08  Tom Tromey  <tom@tromey.com>
7857
7858         * auxv.c (auxv_inferior_data): Move.  Change type.
7859         (auxv_inferior_data_cleanup): Remove.
7860         (invalidate_auxv_cache_inf): Rewrite.
7861         (get_auxv_inferior_data, _initialize_auxv): Update.
7862
7863 2019-05-08  Tom Tromey  <tom@tromey.com>
7864
7865         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7866         (symfile_debug_objfile_data_key): Change type.
7867         (symfile_debug_installed, debug_qf_has_symbols)
7868         (debug_qf_find_last_source_symtab)
7869         (debug_qf_forget_cached_source_info)
7870         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7871         (debug_qf_print_stats, debug_qf_dump)
7872         (debug_qf_expand_symtabs_for_function)
7873         (debug_qf_expand_all_symtabs)
7874         (debug_qf_expand_symtabs_with_fullname)
7875         (debug_qf_map_matching_symbols)
7876         (debug_qf_expand_symtabs_matching)
7877         (debug_qf_find_pc_sect_compunit_symtab)
7878         (debug_qf_map_symbol_filenames)
7879         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7880         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7881         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7882         (debug_sym_read_linetable, debug_sym_relocate): Update.
7883         (symfile_debug_free_objfile): Remove.
7884         (install_symfile_debug_logging, _initialize_symfile_debug):
7885         Update.
7886
7887 2019-05-08  Tom Tromey  <tom@tromey.com>
7888
7889         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7890         allocate_on_obstack.
7891         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7892         (get_dwarf2_per_objfile): Update.
7893         (set_dwarf2_per_objfile): Remove.
7894         (dwarf2_has_info, dwarf2_get_section_info): Update.
7895         (dwarf2_free_objfile): Remove.
7896         (_initialize_dwarf2_read): Update.
7897
7898 2019-05-08  Tom Tromey  <tom@tromey.com>
7899
7900         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7901         initializers.
7902         <unsupported_script_warning_printed,
7903         script_not_found_warning_printed>: Now bool.
7904         (auto_load_pspace_data): Change type.
7905         (~auto_load_pspace_info): Rename from
7906         auto_load_pspace_data_cleanup.
7907         (get_auto_load_pspace_data, init_loaded_scripts_info)
7908         (clear_section_scripts, maybe_print_unsupported_script_warning)
7909         (maybe_print_script_not_found_warning, _initialize_auto_load):
7910         Update.
7911
7912 2019-05-08  Tom Tromey  <tom@tromey.com>
7913
7914         * objfiles.c (objfile_pspace_info): Add destructor and
7915         initializers.
7916         (objfiles_pspace_data): Change type.
7917         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7918         (get_objfile_pspace_data): Update.
7919         (objfiles_bfd_data): Change type.
7920         (get_objfile_bfd_data): Update.
7921         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7922
7923 2019-05-08  Tom Tromey  <tom@tromey.com>
7924
7925         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7926         Change type.
7927         (get_catch_syscall_inferior_data): Update.
7928         (catch_syscall_inferior_data_cleanup): Remove.
7929         (_initialize_break_catch_syscall): Update.
7930
7931 2019-05-08  Tom Tromey  <tom@tromey.com>
7932
7933         * inflow.c (struct terminal_info): Add destructor and
7934         initializers.
7935         (inflow_inferior_data): Change type.
7936         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7937         (get_inflow_inferior_data, inflow_inferior_exit)
7938         (swap_terminal_info, _initialize_inflow): Update.
7939
7940 2019-05-08  Tom Tromey  <tom@tromey.com>
7941
7942         * target-dcache.c (target_dcache_cleanup): Remove.
7943         (target_dcache_aspace_key): Change type.
7944         (target_dcache_init_p, target_dcache_invalidate)
7945         (target_dcache_get, target_dcache_get_or_init)
7946         (_initialize_target_dcache): Update.
7947         * dcache.h (struct dcache_deleter): New.
7948
7949 2019-05-08  Tom Tromey  <tom@tromey.com>
7950
7951         * symtab.c (struct symbol_cache): Add destructor and
7952         initializers.
7953         (symbol_cache_key): Move.  Change type.
7954         (make_symbol_cache, free_symbol_cache): Remove.
7955         (get_symbol_cache): Update.
7956         (symbol_cache_cleanup): Remove.
7957         (ALL_PSPACES, symbol_cache_flush)
7958         (maintenance_print_symbol_cache)
7959         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7960         Update.
7961
7962 2019-05-08  Tom Tromey  <tom@tromey.com>
7963
7964         * symtab.c (struct main_info): Add destructor and initializers.
7965         (main_progspace_key): Move.  Change type.
7966         (get_main_info): Update.
7967         (main_info_cleanup): Remove.
7968         (_initialize_symtab): Update.
7969
7970 2019-05-08  Tom Tromey  <tom@tromey.com>
7971
7972         * registry.h (DECLARE_REGISTRY): Define the _key class.
7973
7974 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7975
7976         * NEWS: Merge two 'New commands' sections.
7977
7978 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7979
7980         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7981         parameter and use Ada language definition instead.
7982         (ada_val_print_ptr): Remove unused language parameter.
7983         (ada_val_print_num): Remove language parameter and use Ada language
7984         definition instead.
7985         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7986         parameter.
7987         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7988         parameter and use Ada language definition instead.
7989         (ada_val_print_1): Update all ada_val_print_xxx calls.
7990         Remove language parameter.
7991         (ada_val_print): Update ada_val_print_1 call.
7992
7993 2019-05-08  Tom Tromey  <tromey@adacore.com>
7994
7995         * remote.c (remote_hw_watchpoint_limit)
7996         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7997         Now static.
7998
7999 2019-05-08  Tom Tromey  <tromey@adacore.com>
8000
8001         * maint.c (_initialize_maint_cmds): Move initialization code to
8002         remote.c.
8003         (watchdog, show_watchdog): Move to remote.c.
8004         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
8005         "watchdog" static.
8006         (_initialize_remote): Move initialization code from maint.c.
8007         * defs.h (watchdog): Don't declare.
8008
8009 2019-05-08  Tom Tromey  <tromey@adacore.com>
8010
8011         * tui/tui-interp.c: Include main.h.
8012         * interps.c: Include main.h.
8013         * main.h (interpreter_p): Declare.
8014         * defs.h (interpreter_p): Don't declare.
8015
8016 2019-05-08  Tom Tromey  <tromey@adacore.com>
8017
8018         * dwarf2loc.c: Include dwarf2read.h.
8019         * defs.h (read_unsigned_leb128): Don't declare.
8020         * dwarf2read.h (read_unsigned_leb128): Declare.
8021
8022 2019-05-08  Tom Tromey  <tromey@adacore.com>
8023
8024         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
8025         method.
8026
8027 2019-05-08  Tom Tromey  <tromey@adacore.com>
8028
8029         * utils.c (fputs_maybe_filtered): Reset style after paging, even
8030         when no wrap column is set.
8031
8032 2019-05-08  Tom Tromey  <tromey@adacore.com>
8033
8034         * c-lang.c (c_get_string): Handle non-C-style arrays.
8035
8036 2019-05-08  Tom Tromey  <tromey@adacore.com>
8037
8038         * typeprint.c (print_offset_data::update): Print the bit offset,
8039         not the number of bits remaining.
8040
8041 2019-05-08  Tom Tromey  <tromey@adacore.com>
8042
8043         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
8044         padding at end of comment.
8045
8046 2019-05-08  Tom Tromey  <tromey@adacore.com>
8047
8048         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
8049         Compare main types.
8050
8051 2019-05-06  Tom Tromey  <tom@tromey.com>
8052
8053         * common/scoped_mmap.c: Include common-defs.h.
8054         * common/scoped_mmap.h: Don't include config.h.
8055
8056 2019-05-04  Tom Tromey  <tom@tromey.com>
8057
8058         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
8059         (struct aarch64_call_info): Add initializers.
8060         <si>: Now a std::vector.
8061         (pass_on_stack, aarch64_push_dummy_call): Update.
8062
8063 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
8064             Tom Tromey  <tom@tromey.com>
8065
8066         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
8067         (ppc_threads): Now a std::vector.  Now static.
8068         (hwdebug_find_thread_points_by_tid)
8069         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
8070         Update.
8071
8072 2019-05-04  Tom Tromey  <tom@tromey.com>
8073
8074         * arc-tdep.c (arc_tdesc_init): Return bool.
8075
8076 2019-05-04  Tom Tromey  <tom@tromey.com>
8077
8078         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
8079         Use gdb_assert_not_reached.
8080
8081 2019-05-04  Tom Tromey  <tom@tromey.com>
8082
8083         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
8084         "false".
8085
8086 2019-05-04  Tom Tromey  <tom@tromey.com>
8087
8088         * arc-tdep.c (arc_tdesc_init): Use bool.
8089
8090 2019-05-04  Tom Tromey  <tom@tromey.com>
8091
8092         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
8093
8094 2019-05-04  Tom Tromey  <tom@tromey.com>
8095
8096         * cli/cli-cmds.c (valid_command_p): Return bool.
8097
8098 2019-05-04  Tom Tromey  <tom@tromey.com>
8099
8100         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
8101         * command.h (valid_user_defined_cmd_name_p): Channge return type.
8102
8103 2019-05-04  Raul Tambre  <raul@tambre.ee>
8104
8105         * python/lib/gdb/prompt.py (_ExtendedPrompt)
8106         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
8107         operator for comparison.
8108
8109 2019-05-04  Tom Tromey  <tom@tromey.com>
8110
8111         * psymtab.c (psymbol_name_matches, match_partial_symbol)
8112         (lookup_partial_symbol, print_partial_symbols)
8113         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
8114         (psymbol_compare): Update.
8115         (add_psymbol_to_bcache): Clear the entire psymbol.
8116         (maintenance_check_psymtabs): Update.
8117         * psympriv.h (struct partial_symbol): Don't derive from
8118         general_symbol_info.
8119         <obj_section, unrelocated_address, address,
8120         set_unrelocated_address>: Update.
8121         <ginfo>: New member.
8122         * dwarf-index-write.c (write_psymbols, debug_names::insert)
8123         (debug_names::write_psymbols): Update.
8124
8125 2019-05-04  Tom de Vries  <tdevries@suse.de>
8126
8127         * contrib/cc-with-tweaks.sh: Support -n arg.
8128
8129 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8130
8131         * corelow.c (core_target::detach): Ensure frame cache and
8132         register caches are cleared.
8133         inferior.c (exit_inferior_1): Likewise.
8134
8135 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
8136             Tom Tromey  <tom@tromey.com>
8137
8138         * dictionary.c (collate_pending_symbols_by_language): Remove
8139         "struct" from foreach.
8140         * symtab.c (lookup_global_symbol_from_objfile)
8141         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
8142         foreach.
8143         * ser-tcp.c (net_open): Remove "struct" from foreach.
8144         * objfiles.c (objfile_relocate, objfile_rebase)
8145         (objfile_has_symbols): Remove "struct" from foreach.
8146         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
8147         from foreach.
8148         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
8149         foreach.
8150         * darwin-nat.c (thread_info_from_private_thread_info): Remove
8151         "struct" from foreach.
8152         * ada-lang.c (create_excep_cond_exprs)
8153         (ada_exception_catchpoint_cond_string): Remove "struct" from
8154         foreach.
8155
8156 2019-05-03  Tom Tromey  <tromey@adacore.com>
8157
8158         * ada-exp.y (convert_char_literal): Check suffix of each
8159         enumerator.
8160
8161 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
8162
8163         PR ada/21406:
8164         * ada-exp.y (yywrap): Don't define.
8165         * ada-lex.l (%option): Add noyywrap
8166         (yywrap): Remove.
8167
8168 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
8169
8170         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
8171         _WIN32_WINNT to the XP level, unless already defined to a higher
8172         level.
8173
8174         * unittests/parse-connection-spec-selftests.c:
8175         * ser-tcp.c:
8176         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
8177         override.
8178
8179         * symfile.c (find_separate_debug_file): Remove colon from the
8180         drive spec of DOS/Windows file names of the target, so that the
8181         file name produced from DEBUGDIR and the target's directory will
8182         be valid on DOS/Windows systems.
8183
8184 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
8185
8186         * rust-lang.c (val_print_struct): Handle printing structures
8187         containing strings.
8188
8189 2019-05-02  Tom Tromey  <tromey@adacore.com>
8190
8191         * valarith.c (_initialize_valarith): Remove.
8192
8193 2019-05-01  Tom Tromey  <tromey@adacore.com>
8194
8195         * ada-lang.c (ada_value_primitive_field): Treat more fields as
8196         bitfields.
8197
8198 2019-05-01  Tom Tromey  <tromey@adacore.com>
8199
8200         * ada-lang.c (ada_value_assign): Correctly compute starting offset
8201         for big-endian copies.
8202
8203 2019-04-30  Ali Tamur  <tamur@google.com>
8204         * gdb/dwarf2read.c (read_3_bytes): New declaration.
8205         (read_attribute_value): Added DW_FORM_strx1-4 cases.
8206         (read_3_bytes): New function.
8207
8208 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8209
8210         * windows-nat.c (main_thread_id): Delete.
8211         (handle_output_debug_string): Replace main_thread_id by
8212         current_event.dwThreadId.
8213         (fake_create_process): Likewise.
8214         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
8215         Do not set main_thread_id.
8216         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
8217         current_event.dwThreadId.
8218         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
8219
8220 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
8221
8222         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
8223         Use current_event.dwThreadId instead of main_thread_id.
8224
8225 2019-04-30  Tom Tromey  <tromey@adacore.com>
8226
8227         * ada-lang.c (ada_lookup_simple_minsyms): New function.
8228         (create_excep_cond_exprs): Iterate over program spaces.
8229         (ada_exception_catchpoint_cond_string): Examine all minimal
8230         symbols for exception types.
8231
8232 2019-04-30  Tom Tromey  <tromey@adacore.com>
8233
8234         PR c++/24470:
8235         * dwarf2read.c (process_structure_scope): Handle case where type
8236         has template parameters but no symbol was created.
8237
8238 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8239             Chris January  <chris.january@arm.com>
8240
8241         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
8242         qualifier.
8243         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
8244
8245 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8246
8247         * f-typeprint.c (f_print_type): Update rules for printing
8248         whitespace.
8249         (f_type_print_varspec_suffix): Likewise.
8250
8251 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8252             Chris January  <chris.january@arm.com>
8253
8254         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
8255         function arguments.
8256
8257 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8258
8259         * f-lang.c (build_fortran_types): Change name of void type to
8260         lower case.
8261         * f-typeprint.c (f_type_print_base): Print the name of the void
8262         type, rather than a fixed string.
8263         * f-valprint.c (f_decorations): Use lower case void string.
8264
8265 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8266             Chris January  <chris.january@arm.com>
8267
8268         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
8269         types for Fortran.
8270
8271 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8272             Chris January  <chris.january@arm.com>
8273             David Lecomber  <david.lecomber@arm.com>
8274
8275         * f-exp.y (BINOP_INTRINSIC): New token.
8276         (exp): New parser rule handling BINOP_INTRINSIC.
8277         (f77_keywords): Add new builtin procedures.
8278         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
8279         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8280         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
8281         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8282         (print_unop_subexp_f): New function.
8283         (print_binop_subexp_f): New function.
8284         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8285         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
8286         (dump_subexp_body_f): Likewise.
8287         (operator_check_f): Likewise.
8288         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
8289         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
8290
8291 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8292
8293         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
8294         UNOP_KIND.
8295         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
8296         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
8297         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
8298         (operator_length_f): New fuction.
8299         (print_subexp_f): New function.
8300         (op_name_f): New function.
8301         (dump_subexp_body_f): New function.
8302         (operator_check_f): New function.
8303         (exp_descriptor_f): Replace standard expression handling functions
8304         with new functions.
8305         * gdb/fortran-operator.def: New file.
8306         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
8307         * gdb/std-operator.def: Remove UNOP_KIND.
8308
8309 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
8310
8311         * std-operator.def: Remove unbalanced, stray double quote
8312         character.
8313
8314 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8315             Chris January  <chris.january@arm.com>
8316             Daniel Everett  <daniel.everett@arm.com>
8317             Nick Forrington  <nick.forrington@arm.com>
8318             Richard Bunt  <richard.bunt@arm.com>
8319
8320         * cp-valprint.c (cp_print_value_fields): Allow an additional level
8321         of depth when printing anonymous structs or unions.
8322         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
8323         Don't print either the top-level value, or the children if the
8324         max-depth is exceeded.
8325         (ppscm_print_children): When printing the key of a map, allow one
8326         extra level of depth.
8327         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
8328         print either the top-level value, or the children if the max-depth
8329         is exceeded.
8330         (print_children): When printing the key of a map, allow one extra
8331         level of depth.
8332         * python/py-value.c (valpy_format_string): Add max_depth keyword.
8333         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
8334         (user_print_options): Initialise max_depth field.
8335         (val_print_scalar_or_string_type_p): New function.
8336         (val_print): Check to see if the max depth has been reached.
8337         (val_print_check_max_depth): Define new function.
8338         (show_print_max_depth): New function.
8339         (_initialize_valprint): Add 'print max-depth' option.
8340         * valprint.h (struct value_print_options) <max_depth>: New field.
8341         (val_print_check_max_depth): Declare new function.
8342         * NEWS: Document new feature.
8343
8344 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8345
8346         * ada-lang.c (ada_language_defn): Initialise new field.
8347         * c-lang.c (c_is_string_type_p): New function.
8348         (c_language_defn): Initialise new field.
8349         (cplus_language_defn): Initialise new field.
8350         (asm_language_defn): Initialise new field.
8351         (minimal_language_defn): Initialise new field.
8352         * c-lang.h (c_is_string_type_p): Declare new function.
8353         * d-lang.c (d_language_defn): Initialise new field.
8354         * f-lang.c (f_is_string_type_p): New function.
8355         (f_language_defn): Initialise new field.
8356         * go-lang.c (go_is_string_type_p): New function.
8357         (go_language_defn): Initialise new field.
8358         * language.c (default_is_string_type_p): New function.
8359         (unknown_language_defn): Initialise new field.
8360         (auto_language_defn): Initialise new field.
8361         * language.h (struct language_defn) <la_is_string_type_p>: New
8362         member variable.
8363         (default_is_string_type_p): Declare new function.
8364         * m2-lang.c (m2_language_defn): Initialise new field.
8365         * objc-lang.c (objc_language_defn): Initialise new field.
8366         * opencl-lang.c (opencl_language_defn): Initialise new field.
8367         * p-lang.c (pascal_is_string_type_p): New function.
8368         (pascal_language_defn): Initialise new field.
8369         * rust-lang.c (rust_is_string_type_p): New function.
8370         (rust_language_defn): Initialise new field.
8371
8372 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8373
8374         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
8375         New field.
8376         * ada-lang.c (ada_language_defn): Initialise new field.
8377         * c-lang.c (c_language_defn): Likewise.
8378         (cplus_language_defn): Likewise.
8379         (asm_language_defn): Likewise.
8380         (minimal_language_defn): Likewise.
8381         * d-lang.c (d_language_defn): Likewise.
8382         * f-lang.c (f_language_defn): Likewise.
8383         * go-lang.c (go_language_defn): Likewise.
8384         * language.c (unknown_language_defn): Likewise.
8385         (auto_language_defn): Likewise.
8386         * m2-lang.c (m2_language_defn): Likewise.
8387         * objc-lang.c (objc_language_defn): Likewise.
8388         * opencl-lang.c (opencl_language_defn): Likewise.
8389         * p-lang.c (pascal_language_defn): Likewise.
8390         * rust-lang.c (rust_language_defn): Likewise.
8391
8392 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
8393
8394         * ada-lang.c (ada_is_character_type): Change return type to bool.
8395         (ada_is_string_type): Likewise.
8396         * ada-lang.h (ada_is_character_type): Update declaration
8397         (ada_is_string_type): Likewise.
8398
8399 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8400
8401         Support style in 'frame|thread apply'
8402
8403         * gdbcmd.h (execute_command_to_string): New term_out parameter.
8404         * record.c (record_start, record_stop): Update callers of
8405         execute_command_to_string with false.
8406         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
8407         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
8408         methods.
8409         (class string_file): New constructor with term_out parameter.
8410         Override methods term_out and can_emit_style_escape.  New member
8411         term_out.
8412         (class stdio_file): Override can_emit_style_escape.
8413         (class tee_file): Override term_out and can_emit_style_escape.
8414         * utils.h (can_emit_style_escape): Remove.
8415         * utils.c (can_emit_style_escape): Likewise.
8416         Update all callers of can_emit_style_escape (SOMESTREAM) to
8417         SOMESTREAM->can_emit_style_escape.
8418         * source-cache.c (source_cache::get_source_lines): Likewise.
8419         * stack.c (frame_apply_command_count): Call execute_command_to_string
8420         passing the term_out characteristic of the current gdb_stdout.
8421         * thread.c (thr_try_catch_cmd): Likewise.
8422         * top.c (execute_command_to_string): pass term_out parameter
8423         to construct the string_file for the command output.
8424         * ui-file.c (term_cli_styling): New function (most code moved
8425         from utils.c can_emit_style_escape).
8426         (string_file::string_file, string_file::can_emit_style_escape,
8427         stdio_file::can_emit_style_escape, tee_file::term_out,
8428         tee_file::can_emit_style_escape): New functions.
8429
8430 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8431
8432         * NEWS: Mention the new set|show may-call-functions.
8433         * infcall.c (may_call_functions_p): New variable.
8434         (show_may_call_functions_p): New function.
8435         (call_function_by_hand_dummy): Throws an error if not
8436         may-call-functions.
8437         (_initialize_infcall): Call add_setshow_boolean_cmd for
8438         may-call-functions.
8439
8440 2019-04-25  Keith Seitz  <keiths@redhat.com>
8441
8442         PR c++/24367
8443         * cp-support.c (inspect_type): Don't attempt substitutions
8444         of symbol with the same name.
8445
8446 2019-04-25  Tom Tromey  <tromey@adacore.com>
8447
8448         PR gdb/24475:
8449         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
8450         static.
8451
8452 2019-04-25  Tom Tromey  <tromey@adacore.com>
8453
8454         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
8455         rvalue reference.
8456         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
8457         (gdb_xml_parser::parse): Use std::move.
8458         * python/python-internal.h (gdbpy_convert_exception): Take a const
8459         reference.
8460         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
8461         std::move.
8462         * python/py-utils.c (gdbpy_convert_exception): Take a const
8463         reference.
8464         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8465         Use std::move.
8466         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8467         Use std::move.
8468         * mi/mi-main.c (mi_print_exception): Take a const reference.
8469         * main.c (handle_command_errors): Take a const reference.
8470         * linespec.c (parse_linespec): Use std::move.
8471         * infcall.c (run_inferior_call): Use std::move.
8472         (call_function_by_hand_dummy): Use std::move.
8473         * exec.c (try_open_exec_file): Use std::move.
8474         * exceptions.h (exception_print, exception_fprintf)
8475         (exception_print_same): Update.
8476         * exceptions.c (print_exception, exception_print)
8477         (exception_fprintf, exception_print_same): Change parameters to
8478         const reference.
8479         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
8480         * common/new-op.c: Use std::move.
8481         * common/common-exceptions.h (struct gdb_exception): Add move
8482         constructor.
8483         (struct gdb_exception_error, struct gdb_exception_quit, struct
8484         gdb_quit_bad_alloc): Change constructor to move constructor.
8485         (throw_exception): Change parameter to rvalue reference.
8486         * common/common-exceptions.c (throw_exception): Take rvalue
8487         reference.
8488         * cli/cli-interp.c (safe_execute_command): Use std::move.
8489         * breakpoint.c (insert_bp_location, location_to_sals): Use
8490         std::move.
8491
8492 2019-04-25  Tom Tromey  <tromey@adacore.com>
8493
8494         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
8495         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
8496         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
8497         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
8498         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
8499         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
8500         guile/scm-value.c: Use unpack.
8501         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
8502         gdbscm_gdb_exception.
8503         (gdbscm_throw_gdb_exception): Likewise.
8504         (struct gdbscm_gdb_exception): New.
8505         (unpack): New function.
8506         (gdbscm_wrap): Use unpack.
8507
8508 2019-04-25  Tom Tromey  <tromey@adacore.com>
8509
8510         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8511         (gdb_rl_callback_handler): Use std::move.
8512         * common/common-exceptions.h (struct gdb_exception): Add move
8513         assignment operator.
8514         (throw_exception_sjlj): Change "exception" to const reference.
8515         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
8516         (throw_exception_sjlj): Change "exception" to const reference.
8517
8518 2019-04-25  Tom Tromey  <tromey@adacore.com>
8519
8520         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
8521         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
8522         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
8523         Update.
8524         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
8525         Update.
8526         * mi/mi-interp.c (mi_interp::exec): Update.
8527         * linespec.c (parse_linespec): Update.
8528         * infcall.c (run_inferior_call): Update.
8529         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
8530         * guile/scm-symbol.c (gdbscm_lookup_symbol)
8531         (gdbscm_lookup_global_symbol): Update.
8532         * guile/scm-param.c (gdbscm_parameter_value): Update.
8533         * guile/scm-frame.c (gdbscm_frame_read_register)
8534         (gdbscm_frame_read_var): Update.
8535         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
8536         * exec.c (try_open_exec_file): Update.
8537         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
8538         (gdb_rl_callback_handler): Update.
8539         * common/common-exceptions.h (exception_none): Don't declare.
8540         * common/common-exceptions.c (exception_none): Don't define.
8541         (struct catcher) <exception>: Update.
8542         * cli/cli-interp.c (safe_execute_command): Update.
8543         * breakpoint.c (insert_bp_location, location_to_sals): Update.
8544
8545 2019-04-25  Ali Tamur  <tamur@google.com>
8546
8547         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
8548         (read_attribute_value): Likewise.
8549         (dwarf2_read_addr_index): Update comment.
8550         (read_str_index): Add DW_FORM_strx.
8551         (dwarf2_string_attr): Likewise.
8552         (dwarf2_const_value_attr): Likewise.
8553         (dump_die_shallow): Likewise.
8554         (dwarf2_fetch_constant_bytes): Likewise.
8555         (skip_form_bytes): Likewise.
8556         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8557
8558 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8559
8560         PR corefiles/11608
8561         PR corefiles/18187
8562         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8563         OFFSET.  Verify if current mapping contains an ELF header.
8564         (linux_find_memory_regions_full): Adjust call to
8565         dump_mapping_p.
8566
8567 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8568             Kang Li <kanglictf@gmail.com>
8569
8570         PR gdb/21600
8571
8572         * dwarf2-frame.c (read_initial_length): Be consistent about using
8573         unsigned representation of length.
8574         (decode_frame_entry_1): Likewise.  Check for wraparound of
8575         end pointer as well as buffer overflow.
8576
8577 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8578
8579         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8580         "vq".
8581
8582 2019-04-24  Tom Tromey  <tromey@adacore.com>
8583
8584         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8585
8586 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8587
8588         * s12z-tdep.c (s12z_unwind_pc): Delete.
8589         (s12z_unwind_sp): Delete.
8590         (s12z_gdbarch_init): Don't register deleted functions with
8591         gdbarch.
8592
8593 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8594
8595         * rl78-tdep.c (rl78_unwind_sp): Delete.
8596         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8597
8598 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8599
8600         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8601         (xstormy16_unwind_pc): Delete.
8602         (xstormy16_dummy_id): Delete.
8603         (xstormy16_gdbarch_init): Don't register deleted functions with
8604         gdbarch.
8605
8606 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8607
8608         * vax-tdep.c (vax_unwind_pc): Delete.
8609         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8610
8611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8612
8613         * v850-tdep.c (v850_unwind_sp): Delete.
8614         (v850_unwind_pc): Delete.
8615         (v850_dummy_id): Delete.
8616         (v850_gdbarch_init): Don't register deleted functions with
8617         gdbarch.
8618
8619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8620
8621         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8622         (tilegx_unwind_pc): Delete.
8623         (tilegx_unwind_dummy_id): Delete.
8624         (tilegx_gdbarch_init): Don't register deleted functions with
8625         gdbarch.
8626
8627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8628
8629         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8630         (tic6x_dummy_id): Delete.
8631         (tic6x_gdbarch_init): Don't register deleted functions with
8632         gdbarch.
8633
8634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8635
8636         * sparc-tdep.c (sparc_unwind_pc): Delete.
8637         (sparc32_gdbarch_init): Don't register deleted function with
8638         gdbarch.
8639
8640 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8641
8642         * sh-tdep.c (sh_unwind_sp): Delete.
8643         (sh_unwind_pc): Delete.
8644         (sh_dummy_id): Delete.
8645         (sh_gdbarch_init): Don't register deleted functions with
8646         gdbarch.
8647
8648 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8649
8650         * score-tdep.c (score_unwind_sp): Delete.
8651         (score_unwind_pc): Delete.
8652         (score_dummy_id): Delete.
8653         (score_gdbarch_init): Don't register deleted functions with
8654         gdbarch.
8655
8656 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8657
8658         * rx-tdep.c (rx_unwind_pc): Delete.
8659         (rx_unwind_sp): Delete.
8660         (rx_dummy_id): Delete.
8661         (rx_gdbarch_init): Don't register deleted functions with
8662         gdbarch.  Update comment.
8663
8664 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8665
8666         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8667         (rs6000_dummy_id): Delete.
8668         (rs6000_gdbarch_init): Don't register deleted functions with
8669         gdbarch.
8670
8671 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8672
8673         * or1k-tdep.c (or1k_dummy_id): Delete.
8674         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8675
8676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8677
8678         * nios2-tdep.c (nios2_dummy_id): Delete.
8679         (nios2_unwind_sp): Delete.
8680         (nios2_gdbarch_init): Don't register deleted functions with
8681         gdbarch.
8682
8683 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8684
8685         * nds32-tdep.c (nds32_dummy_id): Delete.
8686         (nds32_unwind_pc): Delete.
8687         (nds32_unwind_sp): Delete.
8688         (nds32_gdbarch_init): Don't register deleted functions with
8689         gdbarch.
8690
8691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8692
8693         * msp430-tdep.c (msp430_unwind_pc): Delete.
8694         (msp430_unwind_sp): Delete.
8695         (msp430_dummy_id): Delete.
8696         (msp430_gdbarch_init): Don't register deleted functions with
8697         gdbarch.
8698
8699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8700
8701         * moxie-tdep.c (moxie_unwind_sp): Delete.
8702         (moxie_unwind_pc): Delete.
8703         (moxie_dummy_id): Delete.
8704         (moxie_gdbarch_init): Don't register deleted functions with
8705         gdbarch.
8706
8707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8708
8709         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8710         (mn10300_unwind_pc): Delete.
8711         (mn10300_unwind_sp): Delete.
8712         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8713         mn10300_unwind_sp.
8714         (mn10300_frame_unwind_init): Don't register deleted functions with
8715         gdbarch.
8716
8717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8718
8719         * mep-tdep.c (mep_unwind_pc): Delete.
8720         (mep_unwind_sp): Delete.
8721         (mep_dummy_id): Delete.
8722         (mep_gdbarch_init): Don't register deleted functions with
8723         gdbarch.
8724
8725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8726
8727         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8728         (m68hc11_unwind_sp): Delete.
8729         (m68hc11_gdbarch_init): Don't register deleted functions with
8730         gdbarch.
8731
8732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8733
8734         * m32r-tdep.c (m32r_unwind_sp): Delete.
8735         (m32r_unwind_pc): Delete.
8736         (m32r_dummy_id): Delete.
8737         (m32r_gdbarch_init): Don't register deleted functions with
8738         gdbarch.
8739
8740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8741
8742         * m32c-tdep.c (m32c_unwind_pc): Delete.
8743         (m32c_unwind_sp): Delete.
8744         (m32c_dummy_id): Delete.
8745         (m32c_gdbarch_init): Don't register deleted functions with
8746         gdbarch.
8747
8748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8749
8750         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8751         (lm32_unwind_pc): Delete.
8752         (lm32_dummy_id): Delete.
8753         (lm32_gdbarch_init): Don't register deleted functions with
8754         gdbarch.
8755
8756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8757
8758         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8759         (iq2000_unwind_pc): Delete.
8760         (iq2000_dummy_id): Delete.
8761         (iq2000_gdbarch_init): Don't register deleted functions with
8762         gdbarch.
8763
8764 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8765
8766         * nds32-tdep.c (nds32_type_align): Delete.
8767         (nds32_push_dummy_call): Use type_align instead.
8768
8769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8770
8771         * arm-tdep.c (arm_type_align): Only handle vector override case.
8772         (arm_push_dummy_call): Use type_align.
8773         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8774
8775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8776
8777         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8778         case.
8779         (pass_on_stack): Use type_align.
8780         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8781         function.
8782
8783 2019-04-23  Tom Tromey  <tromey@adacore.com>
8784
8785         * dwarf2read.c (line_header::file_name_at): Remove unused
8786         overload.
8787
8788 2019-04-23  Tom de Vries  <tdevries@suse.de>
8789
8790         PR gdb/24438
8791         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8792         invocation.
8793
8794
8795 2019-03-27  Ali Tamur  <tamur@google.com>
8796
8797         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8798         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8799         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8800         (dwarf_expr_context::get_addr_index): Likewise
8801         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8802         (symbol_needs_eval_context::get_addr_index): Likewise
8803         (disassemble_dwarf_expression): Add DW_OP_addrx
8804         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8805         (read_cutu_die_from_dwo): Update comment
8806         (skip_one_die): Add DW_FORM_addrx
8807         (read_attribute_value): Likewise
8808         (var_decode_location): Add DW_OP_addrx
8809         (dwarf2_const_value_attr): Add DW_FORM_addrx
8810         (dump_die_shallow): Likewise
8811         (dwarf2_fetch_constant_bytes): Likewise
8812         (decode_locdesc): Add DW_OP_addrx
8813         (skip_form_bytes): Add DW_FORM_addrx
8814
8815 2019-04-22  Ali Tamur  <tamur@google.com>
8816
8817         * MAINTAINERS (Write After Approval): Add self.
8818
8819 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8820
8821         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8822         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8823         (open_symbol_file_object): Likewise.
8824         (svr4_default_sos): Add info parameter.
8825         (svr4_read_so_list): Likewise.
8826         (svr4_current_sos_direct): Adjust functions calls to pass down
8827         info.
8828         (svr4_current_sos_1): Add info parameter.
8829         (svr4_current_sos): Call get_svr4_info, pass info down to
8830         svr4_current_sos_1.
8831         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8832         get_svr4_info.
8833         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8834         get_svr4_info.
8835         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8836         to get_svr4_info.
8837         (probes_table_remove_objfile_probes): Likewise.
8838         (register_solib_event_probe): Add info parameter.
8839         (solist_update_incremental): Pass info parameter down to
8840         svr4_read_so_list.
8841         (disable_probes_interface): Add info parameter.
8842         (svr4_handle_solib_event): Pass current_program_space to
8843         get_svr4_info.  Adjust disable_probes_interface cleanup.
8844         (svr4_create_probe_breakpoints): Add info parameter, pass it
8845         down to register_solib_event_probe.
8846         (svr4_create_solib_event_breakpoints): Add info parameter,
8847         pass it down to svr4_create_probe_breakpoints.
8848         (enable_break): Pass info down to
8849         svr4_create_solib_event_breakpoints.
8850         (svr4_solib_create_inferior_hook): Pass current_program_space to
8851         get_svr4_info.
8852         (svr4_clear_solib): Likewise.
8853
8854 2019-04-22  Pedro Alves  <palves@redhat.com>
8855
8856         * solib-svr4.c (svr4_free_objfile_observer): New.
8857         (probe_and_action::objfile): New field.
8858         (probes_table_htab_remove_objfile_probes)
8859         (probes_table_remove_objfile_probes): New functions.
8860         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8861         in the new probe_and_action.  Don't store the probe in 'lookup'.
8862         (svr4_create_probe_breakpoints): Pass objfile to
8863         register_solib_event_probe.
8864         (_initialize_svr4_solib): Register a free_objfile observer.
8865
8866 2019-04-19  Tom Tromey  <tom@tromey.com>
8867
8868         * common/queue.h: Remove.
8869
8870 2019-04-19  Tom Tromey  <tom@tromey.com>
8871
8872         * event-loop.c: Don't include "common/queue.h".
8873
8874 2019-04-19  Tom Tromey  <tom@tromey.com>
8875
8876         * remote.c (remote_target): Use delete.
8877         * remote-notif.h: Include <list>, not "common/queue.h".
8878         (notif_client_p): Remove typedef.
8879         (remote_notif_state): Add constructor, destructor, initializer.
8880         <notif_queue>: Now a std::list.
8881         (remote_notif_state_xfree): Don't declare.
8882         * remote-notif.c (remote_notif_process, handle_notification)
8883         (remote_notif_state_allocate): Update.
8884         (~remote_notif_state): Rename from remote_notif_state_xfree.
8885
8886 2019-04-19  Tom Tromey  <tom@tromey.com>
8887
8888         * symfile.c (reread_symbols): Update.
8889         * objfiles.c (objfile_register_static_link)
8890         (objfile_lookup_static_link): Update
8891         (~objfile) Don't delete static_links.
8892         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8893
8894 2019-04-19  Tom Tromey  <tom@tromey.com>
8895
8896         * type-stack.h (struct type_stack) <insert>: Constify string.
8897         * type-stack.c (type_stack::insert): Constify string.
8898         * gdbtypes.h (lookup_template_type): Update.
8899         (address_space_name_to_int): Update.
8900         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8901         const.
8902         (lookup_template_type): Make name const.
8903         * c-exp.y: Update rules.
8904         (lex_one_token, classify_name, classify_inner_name)
8905         (c_print_token): Update.
8906         * p-exp.y: Update rules.
8907         (yylex): Update.
8908         * f-exp.y: Update rules.
8909         (yylex): Update.
8910         * d-exp.y: Update rules.
8911         (lex_one_token, classify_name, classify_inner_name): Update.
8912         * parse.c (write_dollar_variable, copy_name): Return std::string.
8913         * parser-defs.h (copy_name): Change return type.
8914         * m2-exp.y: Update rules.
8915         (yylex): Update.
8916         * go-exp.y (lex_one_token): Update.
8917         Update rules.
8918         (classify_unsafe_function, classify_packaged_name)
8919         (classify_name, yylex): Update.
8920
8921 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8922
8923         * configure.ac: add --enable-source-highlight switch.
8924         * configure: Regenerate.
8925         * top.c (print_gdb_version): plumb --enable-source-highlight
8926         status to "show configuration".
8927
8928 2019-04-19  Tom Tromey  <tromey@adacore.com>
8929
8930         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8931         Check ADA_TYPE_P.
8932         (empty_record, ada_template_to_fixed_record_type_1)
8933         (template_to_static_fixed_type)
8934         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8935         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8936         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8937         macros.
8938
8939 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8940
8941         PR symtab/24423:
8942         * source.c (print_source_lines_base): Advance "iter" when a
8943         control character is seen.
8944
8945 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8946
8947         * inferior.h (struct infcall_suspend_state_deleter):
8948         Catch exception in destructor to avoid crash.
8949
8950 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8951
8952         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8953         close to the add_com "shell".
8954
8955 2019-04-18  Tom Tromey  <tromey@adacore.com>
8956
8957         * process-stratum-target.h (class process_stratum_target)
8958         <stratum>: Add "final".
8959
8960 2019-04-17  Tom Tromey  <tromey@adacore.com>
8961
8962         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8963         against nullptr before use.
8964
8965 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8966
8967         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8968
8969 2019-04-17  Jim Wilson  <jimw@sifive.com>
8970             Andrew Burgess  <andrew.burgess@embecosm.com>
8971
8972         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8973         code read might fail, assume 4-byte breakpoint in that case.
8974
8975 2019-04-15  Leszek Swirski  <leszeks@google.com>
8976
8977         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8978         rather than a hand-rolled POD check when checking for forced MEMORY
8979         classification.
8980
8981 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8982
8983         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8984         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8985         function.
8986         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8987         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8988         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8989         declaration.
8990
8991 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8992
8993         * aarch64-linux-nat.c
8994         (aarch64_linux_nat_target::thread_architecture): Add override.
8995         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8996         each VQ.
8997
8998 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8999
9000         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
9001
9002 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9003
9004         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
9005         target types of size 96-bits, add some additional comments, and
9006         check that the builtin type we found was the correct size.
9007
9008 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
9009
9010         * utils.c (prompt_for_continue): Don't restore the styling at the
9011         end, as applied_style has the wrong value.  This fixes styling in
9012         long lists of file names that are interrupted by the "Continue?"
9013         prompt.
9014
9015 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
9016
9017         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
9018         * c-lang.c (c_language_defn): Likewise.
9019         (cplus_language_defn): Likewise.
9020         (asm_language_defn): Likewise.
9021         (minimal_language_defn): Likewise.
9022         * d-lang.c (d_language_defn): Likewise.
9023         * f-lang.c (f_language_defn): Likewise.
9024         * go-lang.c (go_language_defn): Likewise.
9025         * language.c (unknown_language_defn): Likewise.
9026         (auto_language_defn): Likewise.
9027         * language.h (struct language_defn): Remove la_magic field.
9028         (LANG_MAGIC): Delete.
9029         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
9030         * objc-lang.c (objc_language_defn): Likewise.
9031         * opencl-lang.c (opencl_language_defn): Likewise.
9032         * p-lang.c (pascal_language_defn): Likewise.
9033         * rust-lang.c (rust_language_defn): Likewise.
9034
9035 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9036
9037         * riscv-tdep.c (riscv_type_align): New function.
9038         (riscv_type_alignment): Delete.
9039         (riscv_arg_location): Use 'type_align'.
9040         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
9041
9042 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9043
9044         * gdbtypes.c (type_align): A struct with no non-static fields also
9045         has alignment of 1.
9046
9047 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
9048
9049         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
9050         component to 0.
9051         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
9052         member.
9053         (riscv_struct_info::analyse): New implementation using new
9054         analyse_inner member function.
9055         (riscv_struct_info::field_offset): New member function.
9056         (riscv_struct_info::m_offsets): New member variable.
9057         (riscv_struct_info::analyse_inner): New private member function,
9058         takes the old implementation of riscv_struct_info::analyse but
9059         extended to track field offsets.
9060         (riscv_call_arg_struct): Update the struct folding special cases
9061         to handle cases where empty C++ structs, which are non-zero
9062         length, are found.
9063         (riscv_arg_location): Initialise the length of each location, a
9064         non-zero length now indicates the location is in use.
9065         (riscv_push_dummy_call): Allow for the first location having a
9066         non-zero offset when setting up arguments.
9067         (riscv_return_value): Likewise, but for return values.
9068
9069 2019-04-11  Tom Tromey  <tromey@adacore.com>
9070
9071         * utils.c (internal_vproblem): Make "msg" const.
9072
9073 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
9074
9075         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
9076         * trad-frame.c (trad_frame_reset_saved_regs): New function.
9077         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
9078         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
9079
9080 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
9081
9082         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
9083         function.
9084         (fill_gregset): Call amd64_linux_collect_native_gregset instead
9085         of amd64_collect_native_gregset.
9086         (amd64_linux_nat_target::store_registers): Likewise.
9087
9088 2019-04-10  Tom Tromey  <tom@tromey.com>
9089
9090         * symtab.c (lookup_global_symbol_from_objfile)
9091         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
9092         * objfiles.h (class separate_debug_iterator): New.
9093         (class separate_debug_range): New.
9094         (struct objfile) <separate_debug_objfiles>: New method.
9095         (objfile_separate_debug_iterate): Don't declare.
9096         * objfiles.c (separate_debug_iterator::operator++): Rename from
9097         objfile_separate_debug_iterate.
9098         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
9099         iterator.
9100         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
9101         iterator.
9102
9103 2019-04-10  Tom Tromey  <tom@tromey.com>
9104
9105         * symfile.c (reread_symbols): Remove old comment.
9106         * objfiles.c (free_all_objfiles): Fix a typo.
9107
9108 2019-04-10  Tom Tromey  <tom@tromey.com>
9109
9110         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
9111         * minsyms.c (lookup_minimal_symbol): Use foreach.
9112         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
9113         (lookup_minimal_symbol_solib_trampoline): Likewise.
9114         * symfile.c (reread_symbols): Use foreach.
9115
9116 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
9117             Tom Tromey  <tromey@adacore.com>
9118
9119         PR rust/24414:
9120         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
9121         (rust_lex_int_test): Change "value" to be LONGEST.
9122         (rust_lex_tests): Add test for long integer literal.
9123
9124 2019-04-09  Tom Tromey  <tromey@adacore.com>
9125
9126         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
9127         to bool.
9128         (extended_remote_target::attach): Update.
9129         (remote_target::remote_notice_new_inferior): Update.
9130         (remote_target::add_current_inferior_and_thread): Update.
9131         * inferior.c (exit_inferior_1): Use "false".
9132         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
9133
9134 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
9135
9136         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
9137         the "start" command.
9138
9139 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9140
9141         * python/py-inferior.c (infpy_thread_from_thread_handle):
9142         Adjust comments to reflect renaming of thread_from_thread_handle
9143         to thread_from_handle.  Adjust keywords.  Fix type error message.
9144         (inferior_object_methods): Add thread_from_handle.  Retain
9145         thread_from_thread_handle, but mark it as deprecated.
9146
9147 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9148
9149         * gdbthread.h (find_thread_by_handle): Revise declaration.
9150         * thread.c (find_thread_by_handle): Likewise.  Adjust
9151         implementation too.
9152         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
9153         support for buffer objects as handles.
9154
9155 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9156
9157         * python/py-infthread.c (thpy_thread_handle): New function.
9158         (thread_object_methods): Register thpy_thread_handle.
9159
9160 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
9161
9162         * gdbthread.h (thread_to_thread_handle): Declare.
9163         * thread.c (gdbtypes.h): Include.
9164         (thread_to_thread_handle): New function.
9165
9166         * target.h (struct target_ops): Add thread_info_to_thread_handle.
9167         (target_thread_info_to_thread_handle): Declare.
9168         * target.c (target_thread_info_to_thread_handle): New function.
9169         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
9170         * target-delegates.c: Regenerate.
9171
9172         * linux-thread-db.c (class thread_db_target): Add method
9173         thread_info_to_thread_handle.
9174         (thread_db_target::thread_info_to_thread_handle): Define.
9175         * remote.c (class remote_target): Add new method
9176         thread_info_to_thread_handle.
9177         (remote_target::thread_info_to_thread_handle): Define.
9178
9179 2019-04-08  Pedro Alves  <palves@redhat.com>
9180
9181         * common/common-exceptions.c (throw_exception): Don't create
9182         named object to throw; throw directly.
9183         (throw_it): Likewise.  Don't initialize gdb_exception::message
9184         here, with new; pass FMT and AP to the ctor instead.
9185         * common/common-exceptions.h: Include <string>.
9186         (gdb_exception::gdb_exception(enum return_reason, enum errors,
9187         const char *, va_list)): New ctor.  Use std::make_shared.
9188         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
9189         errors)): Delete.
9190         (gdb_exception_error::gdb_exception_error(enum errors, const char
9191         *, va_list)): New.
9192         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
9193         Add assertion.
9194         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
9195         errors)): Delete.
9196         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
9197         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
9198         Add assertion.
9199
9200 2019-04-08  Tom Tromey  <tom@tromey.com>
9201
9202         * valops.c (value_rtti_indirect_type): Replace throw_exception
9203         with throw.
9204         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
9205         with throw.
9206         * thread.c (thr_try_catch_cmd): Replace throw_exception with
9207         throw.
9208         * target.c (target_translate_tls_address): Replace throw_exception
9209         with throw.
9210         * stack.c (frame_apply_command_count): Replace throw_exception
9211         with throw.
9212         * solib-spu.c (append_ocl_sos): Replace throw_exception with
9213         throw.
9214         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
9215         with throw.
9216         * rs6000-tdep.c (rs6000_frame_cache)
9217         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
9218         * remote.c: Replace throw_exception with throw.
9219         * record-full.c (record_full_message, record_full_wait_1)
9220         (record_full_restore): Replace throw_exception with throw.
9221         * record-btrace.c:
9222         (get_thread_current_frame_id, record_btrace_start_replaying)
9223         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
9224         (cmd_record_btrace_start): Replace throw_exception with throw.
9225         * parse.c (parse_exp_in_context_1): Replace throw_exception with
9226         throw.
9227         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
9228         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
9229         * linespec.c:
9230         (find_linespec_symbols): Replace throw_exception with throw.
9231         * infrun.c (displaced_step_prepare, resume): Replace
9232         throw_exception with throw.
9233         * infcmd.c (post_create_inferior): Replace throw_exception with
9234         throw.
9235         * inf-loop.c (inferior_event_handler): Replace throw_exception
9236         with throw.
9237         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
9238         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
9239         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
9240         (get_prev_frame_always, get_frame_pc_if_available)
9241         (get_frame_address_in_block_if_available, get_frame_language):
9242         Replace throw_exception with throw.
9243         * frame-unwind.c (frame_unwind_try_unwinder): Replace
9244         throw_exception with throw.
9245         * eval.c (fetch_subexp_value, evaluate_var_value)
9246         (evaluate_funcall, evaluate_subexp_standard): Replace
9247         throw_exception with throw.
9248         * dwarf2loc.c (call_site_find_chain)
9249         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
9250         Replace throw_exception with throw.
9251         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
9252         with throw.
9253         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
9254         throw.
9255         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
9256         * completer.c (complete_line_internal): Replace throw_exception
9257         with throw.
9258         * compile/compile-object-run.c (compile_object_run): Replace
9259         throw_exception with throw.
9260         * cli/cli-script.c (process_next_line): Replace throw_exception
9261         with throw.
9262         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
9263         (btrace_enable, btrace_maint_update_pt_packets): Replace
9264         throw_exception with throw.
9265         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
9266         throw_exception with throw.
9267         * break-catch-throw.c (re_set_exception_catchpoint): Replace
9268         throw_exception with throw.
9269         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
9270         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
9271         * aarch64-tdep.c (aarch64_make_prologue_cache)
9272         (aarch64_make_stub_cache): Replace throw_exception with throw.
9273
9274 2019-04-08  Tom Tromey  <tom@tromey.com>
9275
9276         * common/common-exceptions.c (throw_exception): Rename from
9277         throw_exception_cxx.  Remove old copy.  Make argument const.
9278         (throw_it): Create and throw exception objects directly.
9279         * common/common-exceptions.h (throw_exception): Make argument
9280         const.
9281         (struct gdb_exception_error): Add constructor.
9282         (struct gdb_exception_quit): Add constructor.
9283
9284 2019-04-08  Tom Tromey  <tom@tromey.com>
9285
9286         * common/common-exceptions.h (exception_rethrow): Don't declare.
9287         (TRY_SJLJ): Update comment.
9288         (TRY, CATCH, END_CATCH): Remove.
9289         * common/common-exceptions.c (exception_rethrow): Remove.
9290
9291 2019-04-08  Tom Tromey  <tom@tromey.com>
9292
9293         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
9294         Remove.
9295         (gdb_exception_error): Rename from
9296         gdb_exception_RETURN_MASK_ERROR.
9297         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
9298         (gdb_quit_bad_alloc): Update.
9299         * aarch64-tdep.c: Update.
9300         * ada-lang.c: Update.
9301         * ada-typeprint.c: Update.
9302         * ada-valprint.c: Update.
9303         * amd64-tdep.c: Update.
9304         * arch-utils.c: Update.
9305         * break-catch-throw.c: Update.
9306         * breakpoint.c: Update.
9307         * btrace.c: Update.
9308         * c-varobj.c: Update.
9309         * cli/cli-cmds.c: Update.
9310         * cli/cli-interp.c: Update.
9311         * cli/cli-script.c: Update.
9312         * common/common-exceptions.c: Update.
9313         * common/new-op.c: Update.
9314         * common/selftest.c: Update.
9315         * compile/compile-c-symbols.c: Update.
9316         * compile/compile-cplus-symbols.c: Update.
9317         * compile/compile-object-load.c: Update.
9318         * compile/compile-object-run.c: Update.
9319         * completer.c: Update.
9320         * corelow.c: Update.
9321         * cp-abi.c: Update.
9322         * cp-support.c: Update.
9323         * cp-valprint.c: Update.
9324         * darwin-nat.c: Update.
9325         * disasm-selftests.c: Update.
9326         * dtrace-probe.c: Update.
9327         * dwarf-index-cache.c: Update.
9328         * dwarf-index-write.c: Update.
9329         * dwarf2-frame-tailcall.c: Update.
9330         * dwarf2-frame.c: Update.
9331         * dwarf2loc.c: Update.
9332         * dwarf2read.c: Update.
9333         * eval.c: Update.
9334         * event-loop.c: Update.
9335         * event-top.c: Update.
9336         * exec.c: Update.
9337         * f-valprint.c: Update.
9338         * fbsd-tdep.c: Update.
9339         * frame-unwind.c: Update.
9340         * frame.c: Update.
9341         * gdbtypes.c: Update.
9342         * gnu-v3-abi.c: Update.
9343         * guile/guile-internal.h: Update.
9344         * guile/scm-block.c: Update.
9345         * guile/scm-breakpoint.c: Update.
9346         * guile/scm-cmd.c: Update.
9347         * guile/scm-disasm.c: Update.
9348         * guile/scm-frame.c: Update.
9349         * guile/scm-lazy-string.c: Update.
9350         * guile/scm-math.c: Update.
9351         * guile/scm-param.c: Update.
9352         * guile/scm-ports.c: Update.
9353         * guile/scm-pretty-print.c: Update.
9354         * guile/scm-symbol.c: Update.
9355         * guile/scm-symtab.c: Update.
9356         * guile/scm-type.c: Update.
9357         * guile/scm-value.c: Update.
9358         * i386-linux-tdep.c: Update.
9359         * i386-tdep.c: Update.
9360         * inf-loop.c: Update.
9361         * infcall.c: Update.
9362         * infcmd.c: Update.
9363         * infrun.c: Update.
9364         * jit.c: Update.
9365         * language.c: Update.
9366         * linespec.c: Update.
9367         * linux-fork.c: Update.
9368         * linux-nat.c: Update.
9369         * linux-tdep.c: Update.
9370         * linux-thread-db.c: Update.
9371         * main.c: Update.
9372         * mi/mi-cmd-break.c: Update.
9373         * mi/mi-cmd-stack.c: Update.
9374         * mi/mi-interp.c: Update.
9375         * mi/mi-main.c: Update.
9376         * objc-lang.c: Update.
9377         * p-valprint.c: Update.
9378         * parse.c: Update.
9379         * ppc-linux-tdep.c: Update.
9380         * printcmd.c: Update.
9381         * python/py-arch.c: Update.
9382         * python/py-breakpoint.c: Update.
9383         * python/py-cmd.c: Update.
9384         * python/py-finishbreakpoint.c: Update.
9385         * python/py-frame.c: Update.
9386         * python/py-framefilter.c: Update.
9387         * python/py-gdb-readline.c: Update.
9388         * python/py-inferior.c: Update.
9389         * python/py-infthread.c: Update.
9390         * python/py-lazy-string.c: Update.
9391         * python/py-linetable.c: Update.
9392         * python/py-objfile.c: Update.
9393         * python/py-param.c: Update.
9394         * python/py-prettyprint.c: Update.
9395         * python/py-progspace.c: Update.
9396         * python/py-record-btrace.c: Update.
9397         * python/py-record.c: Update.
9398         * python/py-symbol.c: Update.
9399         * python/py-type.c: Update.
9400         * python/py-unwind.c: Update.
9401         * python/py-utils.c: Update.
9402         * python/py-value.c: Update.
9403         * python/python.c: Update.
9404         * record-btrace.c: Update.
9405         * record-full.c: Update.
9406         * remote-fileio.c: Update.
9407         * remote.c: Update.
9408         * riscv-tdep.c: Update.
9409         * rs6000-aix-tdep.c: Update.
9410         * rs6000-tdep.c: Update.
9411         * rust-exp.y: Update.
9412         * rust-lang.c: Update.
9413         * s390-tdep.c: Update.
9414         * selftest-arch.c: Update.
9415         * solib-dsbt.c: Update.
9416         * solib-frv.c: Update.
9417         * solib-spu.c: Update.
9418         * solib-svr4.c: Update.
9419         * solib.c: Update.
9420         * sparc64-linux-tdep.c: Update.
9421         * stack.c: Update.
9422         * symfile-mem.c: Update.
9423         * symmisc.c: Update.
9424         * target.c: Update.
9425         * thread.c: Update.
9426         * top.c: Update.
9427         * tracefile-tfile.c: Update.
9428         * tui/tui.c: Update.
9429         * typeprint.c: Update.
9430         * unittests/cli-utils-selftests.c: Update.
9431         * unittests/parse-connection-spec-selftests.c: Update.
9432         * valops.c: Update.
9433         * valprint.c: Update.
9434         * value.c: Update.
9435         * varobj.c: Update.
9436         * windows-nat.c: Update.
9437         * x86-linux-nat.c: Update.
9438         * xml-support.c: Update.
9439
9440 2019-04-08  Tom Tromey  <tom@tromey.com>
9441
9442         * xml-support.c: Use C++ exception handling.
9443         * x86-linux-nat.c: Use C++ exception handling.
9444         * windows-nat.c: Use C++ exception handling.
9445         * varobj.c: Use C++ exception handling.
9446         * value.c: Use C++ exception handling.
9447         * valprint.c: Use C++ exception handling.
9448         * valops.c: Use C++ exception handling.
9449         * unittests/parse-connection-spec-selftests.c: Use C++ exception
9450         handling.
9451         * unittests/cli-utils-selftests.c: Use C++ exception handling.
9452         * typeprint.c: Use C++ exception handling.
9453         * tui/tui.c: Use C++ exception handling.
9454         * tracefile-tfile.c: Use C++ exception handling.
9455         * top.c: Use C++ exception handling.
9456         * thread.c: Use C++ exception handling.
9457         * target.c: Use C++ exception handling.
9458         * symmisc.c: Use C++ exception handling.
9459         * symfile-mem.c: Use C++ exception handling.
9460         * stack.c: Use C++ exception handling.
9461         * sparc64-linux-tdep.c: Use C++ exception handling.
9462         * solib.c: Use C++ exception handling.
9463         * solib-svr4.c: Use C++ exception handling.
9464         * solib-spu.c: Use C++ exception handling.
9465         * solib-frv.c: Use C++ exception handling.
9466         * solib-dsbt.c: Use C++ exception handling.
9467         * selftest-arch.c: Use C++ exception handling.
9468         * s390-tdep.c: Use C++ exception handling.
9469         * rust-lang.c: Use C++ exception handling.
9470         * rust-exp.y: Use C++ exception handling.
9471         * rs6000-tdep.c: Use C++ exception handling.
9472         * rs6000-aix-tdep.c: Use C++ exception handling.
9473         * riscv-tdep.c: Use C++ exception handling.
9474         * remote.c: Use C++ exception handling.
9475         * remote-fileio.c: Use C++ exception handling.
9476         * record-full.c: Use C++ exception handling.
9477         * record-btrace.c: Use C++ exception handling.
9478         * python/python.c: Use C++ exception handling.
9479         * python/py-value.c: Use C++ exception handling.
9480         * python/py-utils.c: Use C++ exception handling.
9481         * python/py-unwind.c: Use C++ exception handling.
9482         * python/py-type.c: Use C++ exception handling.
9483         * python/py-symbol.c: Use C++ exception handling.
9484         * python/py-record.c: Use C++ exception handling.
9485         * python/py-record-btrace.c: Use C++ exception handling.
9486         * python/py-progspace.c: Use C++ exception handling.
9487         * python/py-prettyprint.c: Use C++ exception handling.
9488         * python/py-param.c: Use C++ exception handling.
9489         * python/py-objfile.c: Use C++ exception handling.
9490         * python/py-linetable.c: Use C++ exception handling.
9491         * python/py-lazy-string.c: Use C++ exception handling.
9492         * python/py-infthread.c: Use C++ exception handling.
9493         * python/py-inferior.c: Use C++ exception handling.
9494         * python/py-gdb-readline.c: Use C++ exception handling.
9495         * python/py-framefilter.c: Use C++ exception handling.
9496         * python/py-frame.c: Use C++ exception handling.
9497         * python/py-finishbreakpoint.c: Use C++ exception handling.
9498         * python/py-cmd.c: Use C++ exception handling.
9499         * python/py-breakpoint.c: Use C++ exception handling.
9500         * python/py-arch.c: Use C++ exception handling.
9501         * printcmd.c: Use C++ exception handling.
9502         * ppc-linux-tdep.c: Use C++ exception handling.
9503         * parse.c: Use C++ exception handling.
9504         * p-valprint.c: Use C++ exception handling.
9505         * objc-lang.c: Use C++ exception handling.
9506         * mi/mi-main.c: Use C++ exception handling.
9507         * mi/mi-interp.c: Use C++ exception handling.
9508         * mi/mi-cmd-stack.c: Use C++ exception handling.
9509         * mi/mi-cmd-break.c: Use C++ exception handling.
9510         * main.c: Use C++ exception handling.
9511         * linux-thread-db.c: Use C++ exception handling.
9512         * linux-tdep.c: Use C++ exception handling.
9513         * linux-nat.c: Use C++ exception handling.
9514         * linux-fork.c: Use C++ exception handling.
9515         * linespec.c: Use C++ exception handling.
9516         * language.c: Use C++ exception handling.
9517         * jit.c: Use C++ exception handling.
9518         * infrun.c: Use C++ exception handling.
9519         * infcmd.c: Use C++ exception handling.
9520         * infcall.c: Use C++ exception handling.
9521         * inf-loop.c: Use C++ exception handling.
9522         * i386-tdep.c: Use C++ exception handling.
9523         * i386-linux-tdep.c: Use C++ exception handling.
9524         * guile/scm-value.c: Use C++ exception handling.
9525         * guile/scm-type.c: Use C++ exception handling.
9526         * guile/scm-symtab.c: Use C++ exception handling.
9527         * guile/scm-symbol.c: Use C++ exception handling.
9528         * guile/scm-pretty-print.c: Use C++ exception handling.
9529         * guile/scm-ports.c: Use C++ exception handling.
9530         * guile/scm-param.c: Use C++ exception handling.
9531         * guile/scm-math.c: Use C++ exception handling.
9532         * guile/scm-lazy-string.c: Use C++ exception handling.
9533         * guile/scm-frame.c: Use C++ exception handling.
9534         * guile/scm-disasm.c: Use C++ exception handling.
9535         * guile/scm-cmd.c: Use C++ exception handling.
9536         * guile/scm-breakpoint.c: Use C++ exception handling.
9537         * guile/scm-block.c: Use C++ exception handling.
9538         * guile/guile-internal.h: Use C++ exception handling.
9539         * gnu-v3-abi.c: Use C++ exception handling.
9540         * gdbtypes.c: Use C++ exception handling.
9541         * frame.c: Use C++ exception handling.
9542         * frame-unwind.c: Use C++ exception handling.
9543         * fbsd-tdep.c: Use C++ exception handling.
9544         * f-valprint.c: Use C++ exception handling.
9545         * exec.c: Use C++ exception handling.
9546         * event-top.c: Use C++ exception handling.
9547         * event-loop.c: Use C++ exception handling.
9548         * eval.c: Use C++ exception handling.
9549         * dwarf2read.c: Use C++ exception handling.
9550         * dwarf2loc.c: Use C++ exception handling.
9551         * dwarf2-frame.c: Use C++ exception handling.
9552         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9553         * dwarf-index-write.c: Use C++ exception handling.
9554         * dwarf-index-cache.c: Use C++ exception handling.
9555         * dtrace-probe.c: Use C++ exception handling.
9556         * disasm-selftests.c: Use C++ exception handling.
9557         * darwin-nat.c: Use C++ exception handling.
9558         * cp-valprint.c: Use C++ exception handling.
9559         * cp-support.c: Use C++ exception handling.
9560         * cp-abi.c: Use C++ exception handling.
9561         * corelow.c: Use C++ exception handling.
9562         * completer.c: Use C++ exception handling.
9563         * compile/compile-object-run.c: Use C++ exception handling.
9564         * compile/compile-object-load.c: Use C++ exception handling.
9565         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9566         * compile/compile-c-symbols.c: Use C++ exception handling.
9567         * common/selftest.c: Use C++ exception handling.
9568         * common/new-op.c: Use C++ exception handling.
9569         * cli/cli-script.c: Use C++ exception handling.
9570         * cli/cli-interp.c: Use C++ exception handling.
9571         * cli/cli-cmds.c: Use C++ exception handling.
9572         * c-varobj.c: Use C++ exception handling.
9573         * btrace.c: Use C++ exception handling.
9574         * breakpoint.c: Use C++ exception handling.
9575         * break-catch-throw.c: Use C++ exception handling.
9576         * arch-utils.c: Use C++ exception handling.
9577         * amd64-tdep.c: Use C++ exception handling.
9578         * ada-valprint.c: Use C++ exception handling.
9579         * ada-typeprint.c: Use C++ exception handling.
9580         * ada-lang.c: Use C++ exception handling.
9581         * aarch64-tdep.c: Use C++ exception handling.
9582
9583 2019-04-08  Tom Tromey  <tom@tromey.com>
9584
9585         * xml-support.c (gdb_xml_parser::parse): Update.
9586         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9587         * value.c (show_convenience): Update.
9588         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9589         (test_parse_flags_qcs): Update.
9590         * thread.c (thr_try_catch_cmd): Update.
9591         * target.c (target_translate_tls_address): Update.
9592         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9593         (info_frame_command_core, frame_apply_command_count): Update.
9594         * rust-exp.y (rust_lex_exception_test): Update.
9595         * riscv-tdep.c (riscv_print_one_register_info): Update.
9596         * remote.c (remote_target::enable_btrace): Update.
9597         * record-btrace.c (record_btrace_enable_warn): Update.
9598         * python/py-utils.c (gdbpy_convert_exception): Update.
9599         * printcmd.c (do_one_display, print_variable_and_value): Update.
9600         * mi/mi-main.c (mi_print_exception): Update.
9601         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9602         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9603         * linux-nat.c (linux_nat_target::attach): Update.
9604         * linux-fork.c (class scoped_switch_fork_info): Update.
9605         * infrun.c (displaced_step_prepare): Update.
9606         * infcall.c (call_function_by_hand_dummy): Update.
9607         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9608         * gnu-v3-abi.c (print_one_vtable): Update.
9609         * frame.c (get_prev_frame_always): Update.
9610         * f-valprint.c (info_common_command_for_block): Update.
9611         * exec.c (try_open_exec_file): Update.
9612         * exceptions.c (print_exception, exception_print)
9613         (exception_fprintf, exception_print_same): Update.
9614         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9615         * dwarf-index-cache.c (index_cache::store)
9616         (index_cache::lookup_gdb_index): Update.
9617         * darwin-nat.c (maybe_cache_shell): Update.
9618         * cp-valprint.c (cp_print_value_fields): Update.
9619         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9620         (gcc_cplus_symbol_address): Update.
9621         * compile/compile-c-symbols.c (gcc_convert_symbol)
9622         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9623         * common/selftest.c: Update.
9624         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9625         a std::string.
9626         (exception_try_scope_entry, exception_try_scope_exit): Don't
9627         declare.
9628         (struct exception_try_scope): Remove.
9629         (TRY): Don't use exception_try_scope.
9630         (struct gdb_exception): Add constructor, operator=.
9631         <what>: New method.
9632         (struct gdb_exception_RETURN_MASK_ALL)
9633         (struct gdb_exception_RETURN_MASK_ERROR)
9634         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9635         (struct gdb_quit_bad_alloc): Update.
9636         * common/common-exceptions.c (exception_none): Change
9637         initializer.
9638         (struct catcher) <state, exception>: Initialize inline.
9639         <prev>: Remove member.
9640         (current_catcher): Remove.
9641         (catchers): New global.
9642         (exceptions_state_mc_init): Simplify.
9643         (catcher_pop): Remove.
9644         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9645         (try_scope_depth, exception_try_scope_entry)
9646         (exception_try_scope_exit): Remove.
9647         (throw_exception_sjlj): Update.
9648         (exception_messages, exception_messages_size): Remove.
9649         (throw_it): Simplify.
9650         (gdb_exception_sliced_copy): Remove.
9651         (throw_exception_cxx): Update.
9652         * cli/cli-script.c (script_from_file): Update.
9653         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9654         Update.
9655         * ada-valprint.c (ada_val_print): Update.
9656         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9657         (create_excep_cond_exprs): Update.
9658
9659 2019-04-08  Tom Tromey  <tom@tromey.com>
9660
9661         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9662         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9663         (TRY, CATCH, END_CATCH): Remove some definitions.
9664         * common/common-exceptions.c: Don't use GDB_XCPT.
9665         (catcher_list_size): Remove.
9666         (throw_exception, throw_it): Simplify.
9667
9668 2019-04-05  Tom Tromey  <tom@tromey.com>
9669
9670         Revert the header-sorting patch.
9671         * ft32-tdep.c: Revert.
9672         * frv-tdep.c: Revert.
9673         * frv-linux-tdep.c: Revert.
9674         * frame.c: Revert.
9675         * frame-unwind.c: Revert.
9676         * frame-base.c: Revert.
9677         * fork-child.c: Revert.
9678         * findvar.c: Revert.
9679         * findcmd.c: Revert.
9680         * filesystem.c: Revert.
9681         * filename-seen-cache.h: Revert.
9682         * filename-seen-cache.c: Revert.
9683         * fbsd-tdep.c: Revert.
9684         * fbsd-nat.h: Revert.
9685         * fbsd-nat.c: Revert.
9686         * f-valprint.c: Revert.
9687         * f-typeprint.c: Revert.
9688         * f-lang.c: Revert.
9689         * extension.h: Revert.
9690         * extension.c: Revert.
9691         * extension-priv.h: Revert.
9692         * expprint.c: Revert.
9693         * exec.h: Revert.
9694         * exec.c: Revert.
9695         * exceptions.c: Revert.
9696         * event-top.c: Revert.
9697         * event-loop.c: Revert.
9698         * eval.c: Revert.
9699         * elfread.c: Revert.
9700         * dwarf2read.h: Revert.
9701         * dwarf2read.c: Revert.
9702         * dwarf2loc.c: Revert.
9703         * dwarf2expr.h: Revert.
9704         * dwarf2expr.c: Revert.
9705         * dwarf2-frame.c: Revert.
9706         * dwarf2-frame-tailcall.c: Revert.
9707         * dwarf-index-write.h: Revert.
9708         * dwarf-index-write.c: Revert.
9709         * dwarf-index-common.c: Revert.
9710         * dwarf-index-cache.h: Revert.
9711         * dwarf-index-cache.c: Revert.
9712         * dummy-frame.c: Revert.
9713         * dtrace-probe.c: Revert.
9714         * disasm.h: Revert.
9715         * disasm.c: Revert.
9716         * disasm-selftests.c: Revert.
9717         * dictionary.c: Revert.
9718         * dicos-tdep.c: Revert.
9719         * demangle.c: Revert.
9720         * dcache.h: Revert.
9721         * dcache.c: Revert.
9722         * darwin-nat.h: Revert.
9723         * darwin-nat.c: Revert.
9724         * darwin-nat-info.c: Revert.
9725         * d-valprint.c: Revert.
9726         * d-namespace.c: Revert.
9727         * d-lang.c: Revert.
9728         * ctf.c: Revert.
9729         * csky-tdep.c: Revert.
9730         * csky-linux-tdep.c: Revert.
9731         * cris-tdep.c: Revert.
9732         * cris-linux-tdep.c: Revert.
9733         * cp-valprint.c: Revert.
9734         * cp-support.c: Revert.
9735         * cp-namespace.c: Revert.
9736         * cp-abi.c: Revert.
9737         * corelow.c: Revert.
9738         * corefile.c: Revert.
9739         * continuations.c: Revert.
9740         * completer.h: Revert.
9741         * completer.c: Revert.
9742         * complaints.c: Revert.
9743         * coffread.c: Revert.
9744         * coff-pe-read.c: Revert.
9745         * cli-out.h: Revert.
9746         * cli-out.c: Revert.
9747         * charset.c: Revert.
9748         * c-varobj.c: Revert.
9749         * c-valprint.c: Revert.
9750         * c-typeprint.c: Revert.
9751         * c-lang.c: Revert.
9752         * buildsym.c: Revert.
9753         * buildsym-legacy.c: Revert.
9754         * build-id.h: Revert.
9755         * build-id.c: Revert.
9756         * btrace.c: Revert.
9757         * bsd-uthread.c: Revert.
9758         * breakpoint.h: Revert.
9759         * breakpoint.c: Revert.
9760         * break-catch-throw.c: Revert.
9761         * break-catch-syscall.c: Revert.
9762         * break-catch-sig.c: Revert.
9763         * blockframe.c: Revert.
9764         * block.c: Revert.
9765         * bfin-tdep.c: Revert.
9766         * bfin-linux-tdep.c: Revert.
9767         * bfd-target.c: Revert.
9768         * bcache.c: Revert.
9769         * ax-general.c: Revert.
9770         * ax-gdb.h: Revert.
9771         * ax-gdb.c: Revert.
9772         * avr-tdep.c: Revert.
9773         * auxv.c: Revert.
9774         * auto-load.c: Revert.
9775         * arm-wince-tdep.c: Revert.
9776         * arm-tdep.c: Revert.
9777         * arm-symbian-tdep.c: Revert.
9778         * arm-pikeos-tdep.c: Revert.
9779         * arm-obsd-tdep.c: Revert.
9780         * arm-nbsd-tdep.c: Revert.
9781         * arm-nbsd-nat.c: Revert.
9782         * arm-linux-tdep.c: Revert.
9783         * arm-linux-nat.c: Revert.
9784         * arm-fbsd-tdep.c: Revert.
9785         * arm-fbsd-nat.c: Revert.
9786         * arm-bsd-tdep.c: Revert.
9787         * arch-utils.c: Revert.
9788         * arc-tdep.c: Revert.
9789         * arc-newlib-tdep.c: Revert.
9790         * annotate.h: Revert.
9791         * annotate.c: Revert.
9792         * amd64-windows-tdep.c: Revert.
9793         * amd64-windows-nat.c: Revert.
9794         * amd64-tdep.c: Revert.
9795         * amd64-sol2-tdep.c: Revert.
9796         * amd64-obsd-tdep.c: Revert.
9797         * amd64-obsd-nat.c: Revert.
9798         * amd64-nbsd-tdep.c: Revert.
9799         * amd64-nbsd-nat.c: Revert.
9800         * amd64-nat.c: Revert.
9801         * amd64-linux-tdep.c: Revert.
9802         * amd64-linux-nat.c: Revert.
9803         * amd64-fbsd-tdep.c: Revert.
9804         * amd64-fbsd-nat.c: Revert.
9805         * amd64-dicos-tdep.c: Revert.
9806         * amd64-darwin-tdep.c: Revert.
9807         * amd64-bsd-nat.c: Revert.
9808         * alpha-tdep.c: Revert.
9809         * alpha-obsd-tdep.c: Revert.
9810         * alpha-nbsd-tdep.c: Revert.
9811         * alpha-mdebug-tdep.c: Revert.
9812         * alpha-linux-tdep.c: Revert.
9813         * alpha-linux-nat.c: Revert.
9814         * alpha-bsd-tdep.c: Revert.
9815         * alpha-bsd-nat.c: Revert.
9816         * aix-thread.c: Revert.
9817         * agent.c: Revert.
9818         * addrmap.c: Revert.
9819         * ada-varobj.c: Revert.
9820         * ada-valprint.c: Revert.
9821         * ada-typeprint.c: Revert.
9822         * ada-tasks.c: Revert.
9823         * ada-lang.c: Revert.
9824         * aarch64-tdep.c: Revert.
9825         * aarch64-ravenscar-thread.c: Revert.
9826         * aarch64-newlib-tdep.c: Revert.
9827         * aarch64-linux-tdep.c: Revert.
9828         * aarch64-linux-nat.c: Revert.
9829         * aarch64-fbsd-tdep.c: Revert.
9830         * aarch64-fbsd-nat.c: Revert.
9831         * aarch32-linux-nat.c: Revert.
9832
9833 2019-04-05  Tom Tromey  <tom@tromey.com>
9834
9835         * ft32-tdep.c: Sort headers.
9836         * frv-tdep.c: Sort headers.
9837         * frv-linux-tdep.c: Sort headers.
9838         * frame.c: Sort headers.
9839         * frame-unwind.c: Sort headers.
9840         * frame-base.c: Sort headers.
9841         * fork-child.c: Sort headers.
9842         * findvar.c: Sort headers.
9843         * findcmd.c: Sort headers.
9844         * filesystem.c: Sort headers.
9845         * filename-seen-cache.h: Sort headers.
9846         * filename-seen-cache.c: Sort headers.
9847         * fbsd-tdep.c: Sort headers.
9848         * fbsd-nat.h: Sort headers.
9849         * fbsd-nat.c: Sort headers.
9850         * f-valprint.c: Sort headers.
9851         * f-typeprint.c: Sort headers.
9852         * f-lang.c: Sort headers.
9853         * extension.h: Sort headers.
9854         * extension.c: Sort headers.
9855         * extension-priv.h: Sort headers.
9856         * expprint.c: Sort headers.
9857         * exec.h: Sort headers.
9858         * exec.c: Sort headers.
9859         * exceptions.c: Sort headers.
9860         * event-top.c: Sort headers.
9861         * event-loop.c: Sort headers.
9862         * eval.c: Sort headers.
9863         * elfread.c: Sort headers.
9864         * dwarf2read.h: Sort headers.
9865         * dwarf2read.c: Sort headers.
9866         * dwarf2loc.c: Sort headers.
9867         * dwarf2expr.h: Sort headers.
9868         * dwarf2expr.c: Sort headers.
9869         * dwarf2-frame.c: Sort headers.
9870         * dwarf2-frame-tailcall.c: Sort headers.
9871         * dwarf-index-write.h: Sort headers.
9872         * dwarf-index-write.c: Sort headers.
9873         * dwarf-index-common.c: Sort headers.
9874         * dwarf-index-cache.h: Sort headers.
9875         * dwarf-index-cache.c: Sort headers.
9876         * dummy-frame.c: Sort headers.
9877         * dtrace-probe.c: Sort headers.
9878         * disasm.h: Sort headers.
9879         * disasm.c: Sort headers.
9880         * disasm-selftests.c: Sort headers.
9881         * dictionary.c: Sort headers.
9882         * dicos-tdep.c: Sort headers.
9883         * demangle.c: Sort headers.
9884         * dcache.h: Sort headers.
9885         * dcache.c: Sort headers.
9886         * darwin-nat.h: Sort headers.
9887         * darwin-nat.c: Sort headers.
9888         * darwin-nat-info.c: Sort headers.
9889         * d-valprint.c: Sort headers.
9890         * d-namespace.c: Sort headers.
9891         * d-lang.c: Sort headers.
9892         * ctf.c: Sort headers.
9893         * csky-tdep.c: Sort headers.
9894         * csky-linux-tdep.c: Sort headers.
9895         * cris-tdep.c: Sort headers.
9896         * cris-linux-tdep.c: Sort headers.
9897         * cp-valprint.c: Sort headers.
9898         * cp-support.c: Sort headers.
9899         * cp-namespace.c: Sort headers.
9900         * cp-abi.c: Sort headers.
9901         * corelow.c: Sort headers.
9902         * corefile.c: Sort headers.
9903         * continuations.c: Sort headers.
9904         * completer.h: Sort headers.
9905         * completer.c: Sort headers.
9906         * complaints.c: Sort headers.
9907         * coffread.c: Sort headers.
9908         * coff-pe-read.c: Sort headers.
9909         * cli-out.h: Sort headers.
9910         * cli-out.c: Sort headers.
9911         * charset.c: Sort headers.
9912         * c-varobj.c: Sort headers.
9913         * c-valprint.c: Sort headers.
9914         * c-typeprint.c: Sort headers.
9915         * c-lang.c: Sort headers.
9916         * buildsym.c: Sort headers.
9917         * buildsym-legacy.c: Sort headers.
9918         * build-id.h: Sort headers.
9919         * build-id.c: Sort headers.
9920         * btrace.c: Sort headers.
9921         * bsd-uthread.c: Sort headers.
9922         * breakpoint.h: Sort headers.
9923         * breakpoint.c: Sort headers.
9924         * break-catch-throw.c: Sort headers.
9925         * break-catch-syscall.c: Sort headers.
9926         * break-catch-sig.c: Sort headers.
9927         * blockframe.c: Sort headers.
9928         * block.c: Sort headers.
9929         * bfin-tdep.c: Sort headers.
9930         * bfin-linux-tdep.c: Sort headers.
9931         * bfd-target.c: Sort headers.
9932         * bcache.c: Sort headers.
9933         * ax-general.c: Sort headers.
9934         * ax-gdb.h: Sort headers.
9935         * ax-gdb.c: Sort headers.
9936         * avr-tdep.c: Sort headers.
9937         * auxv.c: Sort headers.
9938         * auto-load.c: Sort headers.
9939         * arm-wince-tdep.c: Sort headers.
9940         * arm-tdep.c: Sort headers.
9941         * arm-symbian-tdep.c: Sort headers.
9942         * arm-pikeos-tdep.c: Sort headers.
9943         * arm-obsd-tdep.c: Sort headers.
9944         * arm-nbsd-tdep.c: Sort headers.
9945         * arm-nbsd-nat.c: Sort headers.
9946         * arm-linux-tdep.c: Sort headers.
9947         * arm-linux-nat.c: Sort headers.
9948         * arm-fbsd-tdep.c: Sort headers.
9949         * arm-fbsd-nat.c: Sort headers.
9950         * arm-bsd-tdep.c: Sort headers.
9951         * arch-utils.c: Sort headers.
9952         * arc-tdep.c: Sort headers.
9953         * arc-newlib-tdep.c: Sort headers.
9954         * annotate.h: Sort headers.
9955         * annotate.c: Sort headers.
9956         * amd64-windows-tdep.c: Sort headers.
9957         * amd64-windows-nat.c: Sort headers.
9958         * amd64-tdep.c: Sort headers.
9959         * amd64-sol2-tdep.c: Sort headers.
9960         * amd64-obsd-tdep.c: Sort headers.
9961         * amd64-obsd-nat.c: Sort headers.
9962         * amd64-nbsd-tdep.c: Sort headers.
9963         * amd64-nbsd-nat.c: Sort headers.
9964         * amd64-nat.c: Sort headers.
9965         * amd64-linux-tdep.c: Sort headers.
9966         * amd64-linux-nat.c: Sort headers.
9967         * amd64-fbsd-tdep.c: Sort headers.
9968         * amd64-fbsd-nat.c: Sort headers.
9969         * amd64-dicos-tdep.c: Sort headers.
9970         * amd64-darwin-tdep.c: Sort headers.
9971         * amd64-bsd-nat.c: Sort headers.
9972         * alpha-tdep.c: Sort headers.
9973         * alpha-obsd-tdep.c: Sort headers.
9974         * alpha-nbsd-tdep.c: Sort headers.
9975         * alpha-mdebug-tdep.c: Sort headers.
9976         * alpha-linux-tdep.c: Sort headers.
9977         * alpha-linux-nat.c: Sort headers.
9978         * alpha-bsd-tdep.c: Sort headers.
9979         * alpha-bsd-nat.c: Sort headers.
9980         * aix-thread.c: Sort headers.
9981         * agent.c: Sort headers.
9982         * addrmap.c: Sort headers.
9983         * ada-varobj.c: Sort headers.
9984         * ada-valprint.c: Sort headers.
9985         * ada-typeprint.c: Sort headers.
9986         * ada-tasks.c: Sort headers.
9987         * ada-lang.c: Sort headers.
9988         * aarch64-tdep.c: Sort headers.
9989         * aarch64-ravenscar-thread.c: Sort headers.
9990         * aarch64-newlib-tdep.c: Sort headers.
9991         * aarch64-linux-tdep.c: Sort headers.
9992         * aarch64-linux-nat.c: Sort headers.
9993         * aarch64-fbsd-tdep.c: Sort headers.
9994         * aarch64-fbsd-nat.c: Sort headers.
9995         * aarch32-linux-nat.c: Sort headers.
9996
9997 2019-04-04  Tom Tromey  <tom@tromey.com>
9998
9999         * varobj.c (varobj_create): Update.
10000         * rust-exp.y (struct rust_parser) <update_innermost_block,
10001         lookup_symbol>: New methods.
10002         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
10003         Rename.
10004         (rust_parser::rust_lookup_type)
10005         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10006         * printcmd.c (display_command, do_one_display): Update.
10007         * parser-defs.h (struct parser_state) <parser_state>: Add
10008         "tracker" parameter.
10009         (block_tracker): New member.
10010         (class innermost_block_tracker) <innermost_block_tracker>: Add
10011         "types" parameter.
10012         <reset>: Remove method.
10013         (innermost_block): Don't declare.
10014         (null_post_parser): Update.
10015         * parse.c (innermost_block): Remove global.
10016         (write_dollar_variable): Update.
10017         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
10018         Remove "tracker_types" parameter.
10019         (parse_expression): Add "tracker" parameter.
10020         (parse_expression_for_completion): Update.
10021         (null_post_parser): Add "tracker" parameter.
10022         * p-exp.y: Update rules.
10023         * m2-exp.y: Update rules.
10024         * language.h (struct language_defn) <la_post_parser>: Add
10025         "tracker" parameter.
10026         * go-exp.y: Update rules.
10027         * f-exp.y: Update rules.
10028         * expression.h (parse_expression, parse_exp_1): Add "tracker"
10029         parameter.
10030         * d-exp.y: Update rules.
10031         * c-exp.y: Update rules.
10032         * breakpoint.c (set_breakpoint_condition): Create an
10033         innermost_block_tracker.
10034         (watch_command_1): Likewise.
10035         * ada-lang.c (resolve): Add "tracker" parameter.
10036         (resolve_subexp): Likewise.
10037         * ada-exp.y (write_var_from_sym): Update.
10038
10039 2019-04-04  Tom Tromey  <tom@tromey.com>
10040
10041         * type-stack.h: New file.
10042         * type-stack.c: New file.
10043         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
10044         type-stack.h.
10045         (insert_into_type_stack, insert_type, push_type, push_type_int)
10046         (insert_type_address_space, pop_type, pop_type_int)
10047         (pop_typelist, pop_type_stack, append_type_stack)
10048         (push_type_stack, get_type_stack, push_typelist)
10049         (follow_type_instance_flags, follow_types): Don't declare.
10050         * parse.c (type_stack): Remove global.
10051         (parse_exp_in_context): Update.
10052         (insert_into_type_stack, insert_type, push_type, push_type_int)
10053         (insert_type_address_space, pop_type, pop_type_int)
10054         (pop_typelist, pop_type_stack, append_type_stack)
10055         (push_type_stack, get_type_stack, push_typelist)
10056         (follow_type_instance_flags, follow_types): Remove (moved to
10057         type-stack.c).
10058         * f-exp.y (type_stack): New global.
10059         Update rules.
10060         (push_kind_type, f_parse): Update.
10061         * d-exp.y (type_stack): New global.
10062         Update rules.
10063         (d_parse): Update.
10064         * c-exp.y (struct c_parse_state) <type_stack>: New member.
10065         Update rules.
10066         * Makefile.in (COMMON_SFILES): Add type-stack.c.
10067         (HFILES_NO_SRCDIR): Add type-stack.h.
10068
10069 2019-04-04  Tom Tromey  <tom@tromey.com>
10070
10071         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
10072         (rust_parser::convert_ast_to_expression, rust_parse)
10073         (rust_lex_test_completion, rust_lex_tests): Update.
10074         * parser-defs.h (struct expr_completion_state): New.
10075         (struct parser_state) <parser_state>: Add completion parameter.
10076         <mark_struct_expression, mark_completion_tag>: New methods.
10077         <parse_completion, m_completion_state>: New members.
10078         (prefixify_expression, null_post_parser): Update.
10079         (mark_struct_expression, mark_completion_tag): Don't declare.
10080         * parse.c (parse_completion, expout_last_struct)
10081         (expout_tag_completion_type, expout_completion_name): Remove
10082         globals.
10083         (parser_state::mark_struct_expression)
10084         (parser_state::mark_completion_tag): Now methods.
10085         (prefixify_expression): Add last_struct parameter.
10086         (prefixify_subexp): Likewise.
10087         (parse_exp_1): Update.
10088         (parse_exp_in_context): Add cstate parameter.  Update.
10089         (parse_expression_for_completion): Create an
10090         expr_completion_state.
10091         (null_post_parser): Add "completion" parameter.
10092         * p-exp.y: Update rules.
10093         (yylex): Update.
10094         * language.h (struct language_defn) <la_post_parser>: Add
10095         "completing" parameter.
10096         * go-exp.y: Update rules.
10097         (lex_one_token): Update.
10098         * expression.h (parse_completion): Don't declare.
10099         * d-exp.y: Update rules.
10100         (lex_one_token): Update rules.
10101         * c-exp.y: Update rules.
10102         (lex_one_token): Update.
10103         * ada-lang.c (resolve): Add "parse_completion" parameter.
10104         (resolve_subexp): Likewise.
10105         (ada_resolve_function): Likewise.
10106
10107 2019-04-04  Tom Tromey  <tom@tromey.com>
10108
10109         * parser-defs.h (struct parser_state) <start_arglist,
10110         end_arglist>: New methods.
10111         <arglist_len, m_funcall_chain>: New members.
10112         (arglist_len, start_arglist, end_arglist): Don't declare.
10113         * parse.c (arglist_len, funcall_chain): Remove global.
10114         (start_arglist, end_arglist): Remove functions.
10115         (parse_exp_in_context): Update.
10116         * p-exp.y: Update rules.
10117         * m2-exp.y: Update rules.
10118         * go-exp.y: Update rules.
10119         * f-exp.y: Update rules.
10120         * d-exp.y: Update rules.
10121         * c-exp.y: Update rules.
10122
10123 2019-04-04  Tom Tromey  <tom@tromey.com>
10124
10125         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
10126         lex_operator, push_back>: New methods.
10127         Update all rules.
10128         (rust_parser::lex_hex, lex_escape): Rename and update.
10129         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
10130         (rust_parser::lex_operator): Rename and update.
10131         (rust_parser::lex_number, rustyylex, rustyyerror)
10132         (rust_lex_test_init, rust_lex_test_sequence)
10133         (rust_lex_test_push_back, rust_lex_tests): Update.
10134         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
10135         parameter.
10136         <lexptr, prev_lexptr>: New members.
10137         (lexptr, prev_lexptr): Don't declare.
10138         * parse.c (lexptr, prev_lexptr): Remove globals.
10139         (parse_exp_in_context): Update.
10140         * p-exp.y (yylex, yyerror): Update.
10141         * m2-exp.y (parse_number, yylex, yyerror): Update.
10142         * go-exp.y (lex_one_token, yyerror): Update.
10143         * f-exp.y (match_string_literal, yylex, yyerror): Update.
10144         * d-exp.y (lex_one_token, yyerror): Update.
10145         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
10146         (lex_one_token, yyerror): Update.
10147         * ada-lex.l (YY_INPUT): Update.
10148         (rewind_to_char): Update.
10149         * ada-exp.y (yyerror): Update.
10150
10151 2019-04-04  Tom Tromey  <tom@tromey.com>
10152
10153         * rust-exp.y (rustyylex, rust_lex_tests): Update.
10154         * parser-defs.h (struct parser_state) <parser_state>: Add new
10155         parameter.
10156         <comma_terminates>: New member.
10157         (comma_terminates): Don't declare global.
10158         * parse.c (comma_terminates): Remove global.
10159         (parse_exp_in_context): Update.
10160         * p-exp.y (yylex): Update.
10161         * m2-exp.y (yylex): Update.
10162         * go-exp.y (lex_one_token): Update.
10163         * f-exp.y (yylex): Update.
10164         * d-exp.y (lex_one_token): Update.
10165         * c-exp.y (lex_one_token): Update.
10166         * ada-lex.l: Update.
10167
10168 2019-04-04  Tom Tromey  <tom@tromey.com>
10169
10170         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
10171         (rustyylex, rust_lex_test_init, rust_lex_test_one)
10172         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
10173         * parser-defs.h (paren_depth): Don't declare.
10174         * parse.c (paren_depth): Remove global.
10175         (parse_exp_in_context): Update.
10176         * p-exp.y (paren_depth): New global.
10177         (pascal_parse): Initialize it.
10178         * m2-exp.y (paren_depth): New global.
10179         (m2_parse): Initialize it.
10180         * go-exp.y (paren_depth): New global.
10181         (go_parse): Initialize it.
10182         * f-exp.y (paren_depth): New global.
10183         (f_parse): Initialize it.
10184         * d-exp.y (paren_depth): New global.
10185         (d_parse): Initialize it.
10186         * c-exp.y (paren_depth): New global.
10187         (c_parse): Initialize it.
10188         * ada-lex.l (paren_depth): New global.
10189         (lexer_init): Initialize it.
10190
10191 2019-04-04  Tom Tromey  <tom@tromey.com>
10192
10193         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
10194         (rust_parser::convert_ast_to_type)
10195         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
10196         * parser-defs.h (struct parser_state) <parser_state>: Add
10197         parameters.  Initialize new members.
10198         <expression_context_block, expression_context_pc>: New members.
10199         * parse.c (expression_context_block, expression_context_pc):
10200         Remove globals.
10201         (parse_exp_in_context): Update.
10202         * p-exp.y: Update all rules.
10203         (yylex): Update.
10204         * m2-exp.y: Update all rules.
10205         (yylex): Update.
10206         * go-exp.y (yylex): Update.
10207         * f-exp.y (yylex): Update.
10208         * d-exp.y: Update all rules.
10209         (yylex): Update.
10210         * c-exp.y: Update all rules.
10211         (lex_one_token, classify_name, yylex, c_parse): Update.
10212         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
10213
10214 2019-04-04  Tom Tromey  <tom@tromey.com>
10215
10216         * gdbarch.h, gdbarch.c: Rebuild.
10217         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
10218         * stap-probe.h:
10219         (struct stap_parse_info): Replace "parser_state" with
10220         "expr_builder".
10221         * parser-defs.h (struct expr_builder): Rename from "parser_state".
10222         (parser_state): New class.
10223         * parse.c (expr_builder): Rename.
10224         (expr_builder::release): Rename.
10225         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
10226         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
10227         (write_exp_elt_longcst, write_exp_elt_floatcst)
10228         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
10229         (write_exp_string_vector, write_exp_bitstring)
10230         (write_exp_msymbol, mark_struct_expression)
10231         (write_dollar_variable)
10232         (insert_type_address_space, increase_expout_size): Replace
10233         "parser_state" with "expr_builder".
10234         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
10235         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
10236         "parser_state" with "expr_builder".
10237
10238 2019-04-04  Tom Tromey  <tom@tromey.com>
10239
10240         * rust-exp.y: Replace "parse_language" with method call.
10241         * p-exp.y:
10242         (yylex): Replace "parse_language" with method call.
10243         * m2-exp.y:
10244         (yylex): Replace "parse_language" with method call.
10245         * go-exp.y (classify_name): Replace "parse_language" with method
10246         call.
10247         * f-exp.y (yylex): Replace "parse_language" with method call.
10248         * d-exp.y (lex_one_token): Replace "parse_language" with method
10249         call.
10250         * c-exp.y:
10251         (lex_one_token, classify_name, yylex): Replace "parse_language"
10252         with method call.
10253         * ada-exp.y (find_primitive_type, type_char)
10254         (type_system_address): Replace "parse_language" with method call.
10255
10256 2019-04-04  Tom Tromey  <tom@tromey.com>
10257
10258         * rust-exp.y: Replace "parse_gdbarch" with method call.
10259         * parse.c (write_dollar_variable, insert_type_address_space):
10260         Replace "parse_gdbarch" with method call.
10261         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
10262         call.
10263         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
10264         call.
10265         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
10266         "parse_gdbarch" with method call.
10267         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
10268         with method call.
10269         * f-exp.y (parse_type, parse_f_type, yylex): Replace
10270         "parse_gdbarch" with method call.
10271         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
10272         "parse_gdbarch" with method call.
10273         * c-exp.y (parse_type, parse_number, classify_name): Replace
10274         "parse_gdbarch" with method call.
10275         * ada-lex.l: Replace "parse_gdbarch" with method call.
10276         * ada-exp.y (parse_type, find_primitive_type, type_char)
10277         (type_system_address): Replace "parse_gdbarch" with method call.
10278
10279 2019-04-04  Tom Tromey  <tom@tromey.com>
10280
10281         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
10282         * stap-probe.c (stap_parse_argument): Update.
10283         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
10284         initial_size parameter.
10285         * rust-exp.y (rust_lex_tests): Update.
10286         * parse.c (parser_state): Update.
10287         (parse_exp_in_context): Update.
10288         * parser-defs.h (struct parser_state) <parser_state>: Remove
10289         "initial_size" parameter.
10290
10291 2019-04-04  Tom Tromey  <tom@tromey.com>
10292
10293         * parser-defs.h (increase_expout_size): Don't declare.
10294         * parse.c (increase_expout_size): Now static.
10295
10296 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
10297
10298         * gnu-nat.c (gnu_nat_target::wait): Fix
10299         target_waitstatus_to_string call.
10300
10301 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10302
10303         * eval.c (evaluate_subexp_standard): Handle internal functions
10304         during Fortran function call handling.
10305
10306 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
10307
10308         * NEWS: Mention new internal functions.
10309         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
10310         (read_base_type): Use dwarf2_init_complex_target_type.
10311         * value.c (creal_internal_fn): New function.
10312         (cimag_internal_fn): New function.
10313         (_initialize_values): Register new internal functions.
10314
10315 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10316
10317         * infrun.c (stop_all_threads): If debug_infrun, always
10318         trace the wait status after wait_one, using
10319         target_waitstatus_to_string and target_pid_to_str.
10320         (handle_inferior_event): Replace various trace of
10321         wait status kind by a single trace.
10322         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
10323         wait status kind image by target_waitstatus_to_string.
10324         * target/waitstatus.c (target_waitstatus_to_string): Fix
10325         obsolete comment.
10326
10327 2019-04-01  Tom Tromey  <tromey@adacore.com>
10328
10329         PR symtab/23331:
10330         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
10331
10332 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
10333             Pedro Alves  <palves@redhat.com>
10334
10335         * top.c (quit_force): Call 'finalize_values'.
10336         * value.c (finalize_values): New function.
10337         * value.h (finalize_values): Declare.
10338
10339 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
10340
10341         * NEWS: Announce $_gdb_major and $_gdb_minor.
10342
10343         * top.c (init_gdb_version_vars): New function.
10344         (gdb_init): Call init_gdb_version_vars.
10345
10346 2019-03-29  Tom Tromey  <tromey@adacore.com>
10347
10348         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
10349         help text.  Remove dead code.
10350
10351 2019-03-29  Keith Seitz  <keiths@redhat.com>
10352
10353         From Siddhesh Poyarekar:
10354         * f-lang.h (f77_get_upperbound): Return LONGEST.
10355         (f77_get_lowerbound): Likewise.
10356         * f-typeprint.c (f_type_print_varspec_suffix): Expand
10357         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
10358         print them.
10359         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
10360         plongest to format print it.
10361         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
10362         (f77_get_upperbound): Likewise.
10363         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
10364         LOWER_BOUND to LONGEST.
10365         (f77_create_arrayprint_offset_tbl): Likewise.
10366
10367 2019-03-29  Keith Seitz  <keiths@redhat.com>
10368
10369         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
10370         %s/pulongest for TYPE_LENGTH instead of %d in format
10371         strings.
10372         * ada-typerint.c (ada_print_type): Likewise.
10373         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
10374         * compile/compile-c-support.c (generate_register_struct): Likewise.
10375         * gdbtypes.c (recursive_dump_type): Likewise.
10376         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
10377         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
10378         instead of %d in format strings.
10379         * riscv-tdep.c (riscv_type_alignment): Cast second argument
10380         to std::min to ULONGEST.
10381         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
10382         instead of %d in format strings.
10383         * tracepoint.c (info_scope_command): Likewise.
10384         * typeprint.c (print_offset_data::update)
10385         (print_offset_data::finish): Likewise.
10386         * xtensa-tdep.c (xtensa_store_return_value)
10387         (xtensa_push_dummy_call): Likewise.
10388
10389 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
10390
10391         * windows-nat.c (display_selector): Fixed format specifications
10392         for 64-bit Cygwin.
10393
10394 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10395
10396         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
10397
10398 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
10399
10400         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
10401         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
10402         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
10403         (nios2_linux_init_abi): Install it.
10404
10405 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10406
10407         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
10408
10409 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
10410
10411         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
10412
10413 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10414             Tom Tromey  <tromey@adacore.com>
10415
10416         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
10417
10418 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
10419
10420         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
10421         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
10422         method to compute the bounds of range types. Also print "[evaluated]"
10423         if the bounds' values come from a dynamic evaluation.
10424
10425 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10426
10427         * cp-valprint.c (cp_print_value_fields): Don't print trailing
10428         whitespace when pretty printing is on.
10429
10430 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10431
10432         * ppc-linux-nat.c: Add include.
10433
10434 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10435
10436         * NEWS: Mention AArch64 Pointer Authentication.
10437
10438 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
10439
10440         * arm-linux-nat.c: Add include.
10441
10442 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
10443
10444         * source-cache.c (source_cache::get_source_lines): Re-read
10445         fullname after calling open_source_file.
10446
10447 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
10448
10449         * NEWS: Mention TLS support for FreeBSD.
10450
10451 2019-03-25  Tom Tromey  <tromey@adacore.com>
10452
10453         * minsyms.c (BUNCH_SIZE): Update comment.
10454         (~minimal_symbol_reader): Remove old comment.
10455         (compact_minimal_symbols): Update comment.
10456         (minimal_symbol_reader::install): Remove old comment.  Update
10457         other comments.
10458
10459 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10460
10461         * s390-linux-nat.c: Add include.
10462
10463 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
10464
10465         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
10466         Call linux_get_hwcap.
10467         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
10468         Likewise.
10469         (aarch64_linux_get_hwcap): Remove function.
10470         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
10471         declaration.
10472         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
10473         linux_get_hwcap.
10474         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
10475         * linux-tdep.c (linux_get_hwcap): Add function.
10476         (linux_get_hwcap2): Likewise.
10477         * linux-tdep.h (linux_get_hwcap): Add declaration.
10478         (linux_get_hwcap2): Likewise.
10479         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
10480         (ppc_linux_get_hwcap2): Likewise.
10481         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
10482         linux_get_hwcap.
10483         (ppc_linux_nat_target::insert_watchpoint): Likewise.
10484         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
10485         (ppc_linux_nat_target::read_description): Likewise.
10486         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
10487         * s390-linux-nat.c: Likewise.
10488         * s390-linux-tdep.c (s390_core_read_description): Likewise.
10489
10490 2019-03-24  Tom Tromey  <tom@tromey.com>
10491
10492         * ada-lang.c (standard_lookup): Simplify initialization.
10493         (ada_lookup_symbol_nonlocal): Simplify return.
10494         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
10495         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
10496         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
10497         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
10498         initialization.
10499         * solib.c (solib_global_lookup): Simplify.
10500         * symtab.c (null_block_symbol): Remove.
10501         (symbol_cache_lookup): Simplify returns.
10502         (lookup_language_this): Simplify returns.
10503         (lookup_symbol_aux): Simplify return.
10504         (lookup_local_symbol): Simplify returns.
10505         (lookup_global_symbol_from_objfile): Simplify return.
10506         (lookup_symbol_in_objfile_symtabs)
10507         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
10508         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
10509         (lookup_static_symbol, lookup_global_symbol): Simplify return.
10510         * cp-namespace.c (cp_lookup_bare_symbol)
10511         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
10512         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
10513         (cp_lookup_nested_symbol): Don't use null_block_symbol.
10514         (cp_lookup_symbol_via_imports): Simplify initialization.
10515         (find_symbol_in_baseclass): Likewise.
10516         * symtab.h (null_block_symbol): Remove.
10517         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
10518         (d_lookup_nested_symbol, d_lookup_symbol_imports)
10519         (d_lookup_symbol_module): Likewise.
10520         (find_symbol_in_baseclass): Simplify initialization.
10521
10522 2019-03-24  Tom Tromey  <tom@tromey.com>
10523
10524         * expression.h: Don't include symtab.h.
10525         (struct block): Forward declare.
10526
10527 2019-03-24  Tom Tromey  <tom@tromey.com>
10528
10529         * c-exp.y (typebase): Remove casts.
10530         * gdbtypes.c (lookup_unsigned_typename, )
10531         (lookup_signed_typename): Remove cast.
10532         * eval.c (parse_to_comma_and_eval): Remove cast.
10533         * parse.c (write_dollar_variable): Remove cast.
10534         * block.h (struct block) <superblock>: Now const.
10535         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
10536         * psymtab.c (psym_map_matching_symbols): Make "block" const.
10537         (map_block): Make "block" const.
10538         * symfile.h (struct quick_symbol_functions)
10539         <map_matching_symbols>: Constify block argument to "callback".
10540         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
10541         const.
10542         (find_pc_sect_compunit_symtab): Make "b" const.
10543         (find_symbol_at_address): Likewise.
10544         (search_symbols): Likewise.
10545         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
10546         (dw2_debug_names_lookup_symbol): Likewise.
10547         (dw2_map_matching_symbols): Update.
10548         * p-valprint.c (pascal_val_print): Remove "block".
10549         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
10550         (aux_add_nonlocal_symbols): Make "block" const.
10551         (resolve_subexp): Remove cast.
10552         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10553         const.
10554         (iterate_over_file_blocks): Likewise.
10555         * f-exp.y (%union) <bval>: Remove.
10556         * coffread.c (patch_opaque_types): Make "b" const.
10557         * spu-tdep.c (spu_catch_start): Make "block" const.
10558         * c-valprint.c (print_unpacked_pointer): Remove "block".
10559         * symmisc.c (dump_symtab_1): Make "b" const.
10560         (block_depth): Make "block" const.
10561         * d-exp.y (%union) <bval>: Remove.
10562         * cp-support.h (cp_lookup_rtti_type): Update.
10563         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10564         * psymtab.c (psym_lookup_symbol): Make "block" const.
10565         (maintenance_check_psymtabs): Make "b" const.
10566         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10567         (enumerate_locals, enumerate_args): Update.
10568         * python/py-symtab.c (stpy_global_block): Make "block" const.
10569         (stpy_static_block): Likewise.
10570         * inline-frame.c (block_starting_point_at): Make "new_block"
10571         const.
10572         * block.c (find_block_in_blockvector): Make return type const.
10573         (blockvector_for_pc_sect): Make "b" const.
10574         (find_block_in_blockvector): Make "b" const.
10575
10576 2019-03-23  Tom Tromey  <tom@tromey.com>
10577
10578         * varobj.c (varobj_create): Update.
10579         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10580         * printcmd.c (display_command, do_one_display): Don't reset
10581         innermost_block.
10582         * parser-defs.h (enum innermost_block_tracker_type): Move to
10583         expression.h.
10584         (innermost_block): Update comment.
10585         * parse.c (parse_exp_1): Add tracker_types parameter.
10586         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10587         tracker_types parameter.  Reset innermost_block.
10588         (parse_exp_in_context): Remove.
10589         (parse_expression_for_completion): Update.
10590         * objfiles.c (~objfile): Don't reset expression_context_block or
10591         innermost_block.
10592         * expression.h (enum innermost_block_tracker_type): Move from
10593         parser-defs.h.
10594         (parse_exp_1): Add tracker_types parameter.
10595         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10596         reset innermost_block.
10597
10598 2019-03-23  Tom Tromey  <tom@tromey.com>
10599
10600         * objfiles.h: Include bcache.h.
10601
10602 2019-03-23  Tom Tromey  <tom@tromey.com>
10603
10604         * linespec.c (get_current_search_block): Use
10605         scoped_restore_current_language.
10606         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10607
10608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10609             Jiong Wang  <jiong.wang@arm.com>
10610
10611         * aarch64-linux-tdep.c
10612         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10613         section.
10614         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10615
10616 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10617             Jiong Wang  <jiong.wang@arm.com>
10618
10619         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10620         instructions.
10621         (aarch64_analyze_prologue_test): Add PACIASP test.
10622         (aarch64_prologue_prev_register): Unmask PC value.
10623
10624 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10625             Jiong Wang  <jiong.wang@arm.com>
10626
10627         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10628         (aarch64_dwarf2_prev_register): Unmask PC value.
10629         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10630         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10631         DW_CFA_AARCH64_negate_ra_state.
10632         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10633
10634 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10635             Jiong Wang  <jiong.wang@arm.com>
10636
10637         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10638         registers.
10639         (aarch64_pseudo_register_name): Likewise.
10640         (aarch64_pseudo_register_type): Likewise.
10641         (aarch64_pseudo_register_reggroup_p): Likewise.
10642         (aarch64_gdbarch_init): Add pauth registers.
10643         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10644         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10645         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10646         (struct gdbarch_tdep): Add regnum for ra_state.
10647
10648 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10649             Jiong Wang  <jiong.wang@arm.com>
10650
10651         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10652
10653 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10654             Jiong Wang  <jiong.wang@arm.com>
10655
10656         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10657         function.
10658         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10659         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10660         (aarch64_gdbarch_init): Add puth registers.
10661         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10662         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10663         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10664
10665 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10666             Jiong Wang  <jiong.wang@arm.com>
10667
10668         * aarch64-linux-nat.c
10669         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10670         * aarch64-linux-tdep.c
10671         (aarch64_linux_core_read_description): Likewise.
10672         (aarch64_linux_get_hwcap): New function.
10673         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10674         (aarch64_linux_get_hwcap): New declaration.
10675
10676 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10677             Jiong Wang  <jiong.wang@arm.com>
10678
10679         * aarch64-linux-nat.c
10680         (aarch64_linux_nat_target::read_description): Add pauth param.
10681         * aarch64-linux-tdep.c
10682         (aarch64_linux_core_read_description): Likewise.
10683         * aarch64-tdep.c (struct target_desc): Add in pauth.
10684         (aarch64_read_description): Add pauth param.
10685         (aarch64_gdbarch_init): Likewise.
10686         * aarch64-tdep.h (aarch64_read_description): Likewise.
10687         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10688         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10689         * features/Makefile: Add new files.
10690         * features/aarch64-pauth.c: New file.
10691         * features/aarch64-pauth.xml: New file.
10692
10693 2019-03-20  Tom Tromey  <tromey@adacore.com>
10694
10695         * infrun.c (handle_inferior_event): Rename from
10696         handle_inferior_event_1.  Create a scoped_value_mark.
10697         (handle_inferior_event): Remove.
10698
10699 2019-03-19  Tom Tromey  <tromey@adacore.com>
10700
10701         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10702         * infrun.h (print_stop_event): Add "displays" parameter.
10703         * infrun.c (print_stop_event): Add "displays" parameter.
10704
10705 2019-03-19  Pedro Alves  <palves@redhat.com>
10706
10707         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10708         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10709         to -1.  Fix TABs vs spaces.
10710         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10711         * tui/tui-out.h (tui_ui_out) Add intro comments.
10712         <m_line, m_start_of_line>: In-class initialize, and add describing
10713         comment.
10714
10715 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10716
10717         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10718         variable names.
10719         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10720
10721 2019-03-18  Pedro Alves  <palves@redhat.com>
10722             Eli Zaretskii <eliz@gnu.org>
10723
10724         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10725         m_line and m_start_of_line.
10726
10727 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10728
10729         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10730         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10731         it returns a newline.  This fixes a regression in TU mode, whereby
10732         the next line is output on the same screen line as the user input.
10733
10734 2019-03-18  Tom Tromey  <tromey@adacore.com>
10735
10736         * minsyms.c (minimal_symbol_reader::install): Remove call to
10737         obstack_blank.
10738
10739 2019-03-18  Pedro Alves  <palves@redhat.com>
10740
10741         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10742         New globals.
10743         (apply_style): New, factored out from ...
10744         (apply_ansi_escape): ... this.  Handle reverse video mode.
10745         (tui_set_reverse_mode): New function.
10746         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10747         * tui/tui-winsource.c (tui_show_source_line): Use
10748         tui_set_reverse_mode instead of setting A_STANDOUT.
10749         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10750         New setter methods.
10751
10752 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10753
10754         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10755         Handle tabs.
10756
10757 2019-03-18  Tom Tromey  <tromey@adacore.com>
10758
10759         * ada-lang.c (empty_array): Add "high" parameter.
10760         (ada_evaluate_subexp): Update.
10761
10762 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10763
10764         * unittests/string_view-selftests.c: Define
10765         _initialize_string_view_selftests unconditionally.
10766
10767 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10768
10769         PR gdb/24350
10770         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10771
10772 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10773
10774         PR gdb/24351
10775         * windows-nat.c (display_selector): Fix format specifiers.
10776
10777 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10778
10779         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10780         tui_refill_source_window instead of tui_refresh_win, to update the
10781         current execution line.  This fixes redisplay of the current line
10782         when stepping through the code with "next" or "step".
10783
10784 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10785
10786         * source-cache.c (source_cache::get_source_lines): Call
10787         find_source_lines to initialize s->nlines.  This fixes vertical
10788         scrolling of TUI source window when the DOWN arrow is pressed.
10789
10790 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10791
10792         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10793         linux-thread-db.c (_initialize_thread_db): Likewise.
10794
10795 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10796
10797         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10798         wclrtoeol in tui_show_source_line".  This reverts changes made in
10799         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10800
10801 2019-03-15  Tom Tromey  <tom@tromey.com>
10802
10803         * symtab.h (struct minimal_symbol): Derive from
10804         general_symbol_info.
10805         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10806         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10807         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10808         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10809         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10810         (MSYMBOL_SEARCH_NAME): Update.
10811         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10812         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10813         * minsyms.c (minimal_symbol_reader::record_full): Update.
10814
10815 2019-03-15  Tom Tromey  <tom@tromey.com>
10816
10817         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10818
10819 2019-03-15  Tom Tromey  <tom@tromey.com>
10820
10821         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10822         unique_xmalloc_ptr.
10823         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10824         Update.
10825         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10826         (build_minimal_symbol_hash_tables)
10827         (minimal_symbol_reader::install): Update.
10828
10829 2019-03-15  Tom Tromey  <tom@tromey.com>
10830
10831         * symtab.c (create_demangled_names_hash): Update.
10832         (symbol_set_names): Update.
10833         * objfiles.h (struct objfile_per_bfd_storage)
10834         <demangled_names_hash>: Now an htab_up.
10835         * objfiles.c (objfile_per_bfd_storage): Simplify.
10836
10837 2019-03-15  Tom Tromey  <tom@tromey.com>
10838
10839         * objfiles.h (struct objfile_per_bfd_storage): Declare
10840         destructor.
10841         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10842         New.
10843         (get_objfile_bfd_data): Use new.  Don't initialize
10844         language_of_main.
10845         (free_objfile_per_bfd_storage): Remove.
10846         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10847
10848 2019-03-15  Tom Tromey  <tom@tromey.com>
10849
10850         * symfile.c (reread_symbols): Update.
10851         * objfiles.c (objfile::objfile): Update.
10852         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10853         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10854         comment.
10855         (minimal_symbol_reader::install): Update.
10856         (terminate_minimal_symbol_table): Remove.
10857         * jit.c (jit_object_close_impl): Update.
10858
10859 2019-03-15  Tom Tromey  <tom@tromey.com>
10860
10861         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10862         initializations.
10863
10864 2019-03-15  Tom Tromey  <tom@tromey.com>
10865
10866         * objfiles.h (struct objfile_per_bfd_storage)
10867         <demangled_hash_languages>: Now a bitset.
10868         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10869         (lookup_minimal_symbol): Update.
10870
10871 2019-03-15  Tom Tromey  <tom@tromey.com>
10872
10873         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10874         Don't return the symbol.
10875         * coffread.c (record_minimal_symbol): Use record_full.
10876
10877 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10878
10879         The MS-Windows port of ncurses fails to switch to a color pair if
10880         one or both of the colors are the implicit default colors.  This
10881         change records the default colors when TUI is initialized, and
10882         then specifies them explicitly when a color pair uses the default
10883         colors.  This allows color styling in TUI mode on MS-Windows.
10884
10885         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10886         ncurses_norm_attr.
10887         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10888         colors in ncurses_norm_attr.
10889         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10890         "none", replace it with the default color recorded in
10891         ncurses_norm_attr.
10892
10893 2019-03-14  Tom Tromey  <tromey@adacore.com>
10894
10895         * source-cache.h (class source_cache) <get_source_lines>: Return
10896         std::string.
10897         * source-cache.c (source_cache::extract_lines): Handle case where
10898         first_pos==npos.  Return std::string.
10899         (source_cache::get_source_lines): Update.
10900
10901 2019-03-14  Tom Tromey  <tromey@adacore.com>
10902
10903         * NEWS: Add item for "style sources" commands.
10904         * source-cache.c (source_cache::get_source_lines): Check
10905         source_styling.
10906         * cli/cli-style.c (source_styling): New global.
10907         (_initialize_cli_style): Add "style sources" commands.
10908         (show_style_sources): New function.
10909         * cli/cli-style.h (source_styling): Declare.
10910
10911 2019-03-14  Pedro Alves  <palves@redhat.com>
10912             Tom Tromey  <tromey@adacore.com>
10913
10914         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10915         * tui/tui-winsource.c (tui_refill_source_window): New function,
10916         from...
10917         (tui_horizontal_source_scroll): ... here.  Move some logic.
10918         * cli/cli-style.c (set_style_enabled): Notify new observable.
10919         * tui/tui-hooks.c (tui_redisplay_source): New function.
10920         (tui_attach_detach_observers): Attach or detach
10921         tui_redisplay_source.
10922         * observable.h (source_styling_changed): New observable.
10923         * observable.c: Define source_styling_changed observable.
10924
10925 2019-03-13  Tom Tromey  <tromey@adacore.com>
10926
10927         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10928         (i386_gnu_nat_target::store_registers): Update.
10929         * target-debug.h (target_debug_print_std_string): New macro.
10930         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10931         * windows-tdep.c (display_one_tib): Update.
10932         * tui/tui-stack.c (tui_make_status_line): Update.
10933         * top.c (print_inferior_quit_action): Update.
10934         * thread.c (thr_try_catch_cmd): Update.
10935         (add_thread_with_info): Update.
10936         (thread_target_id_str): Update.
10937         (thr_try_catch_cmd): Update.
10938         (thread_command): Update.
10939         (thread_find_command): Update.
10940         * record-btrace.c (record_btrace_target::info_record)
10941         (record_btrace_resume_thread, record_btrace_target::resume)
10942         (record_btrace_cancel_resume, record_btrace_step_thread)
10943         (record_btrace_target::wait, record_btrace_target::wait)
10944         (record_btrace_target::wait, record_btrace_target::stop): Update.
10945         * progspace.c (print_program_space): Update.
10946         * process-stratum-target.c
10947         (process_stratum_target::thread_address_space): Update.
10948         * linux-fork.c (linux_fork_mourn_inferior)
10949         (detach_checkpoint_command, info_checkpoints_command)
10950         (linux_fork_context): Update.
10951         (linux_fork_detach): Update.
10952         (class scoped_switch_fork_info): Update.
10953         (delete_checkpoint_command): Update.
10954         * infrun.c (follow_fork_inferior): Update.
10955         (follow_fork_inferior): Update.
10956         (proceed_after_vfork_done): Update.
10957         (handle_vfork_child_exec_or_exit): Update.
10958         (follow_exec): Update.
10959         (displaced_step_prepare_throw): Update.
10960         (displaced_step_restore): Update.
10961         (start_step_over): Update.
10962         (resume_1): Update.
10963         (clear_proceed_status_thread): Update.
10964         (proceed): Update.
10965         (print_target_wait_results): Update.
10966         (do_target_wait): Update.
10967         (context_switch): Update.
10968         (stop_all_threads): Update.
10969         (restart_threads): Update.
10970         (finish_step_over): Update.
10971         (handle_signal_stop): Update.
10972         (switch_back_to_stepped_thread): Update.
10973         (keep_going_pass_signal): Update.
10974         (print_exited_reason): Update.
10975         (normal_stop): Update.
10976         * inferior.c (inferior_pid_to_str): Change return type.
10977         (print_selected_inferior): Update.
10978         (add_inferior): Update.
10979         (detach_inferior): Update.
10980         * dummy-frame.c (fprint_dummy_frames): Update.
10981         * dcache.c (dcache_info_1): Update.
10982         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10983         (btrace_fetch, btrace_clear): Update.
10984         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10985         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10986         type.
10987         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10988         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10989         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10990         * gdbarch.c, gdbarch.h: Rebuild.
10991         * gdbarch.sh (core_pid_to_str): Change return type.
10992         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10993         return type.
10994         (windows_nat_target::pid_to_str): Change return type.
10995         (windows_delete_thread): Update.
10996         (windows_nat_target::attach): Update.
10997         (windows_nat_target::files_info): Update.
10998         * target-delegates.c: Rebuild.
10999         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
11000         return type.
11001         (sol_thread_target::pid_to_str): Change return type.
11002         * remote.c (class remote_target) <pid_to_str>: Change return
11003         type.
11004         (remote_target::pid_to_str): Change return type.
11005         (extended_remote_target::attach, remote_target::remote_stop_ns)
11006         (remote_target::remote_notif_remove_queued_reply)
11007         (remote_target::push_stop_reply, remote_target::disable_btrace):
11008         Update.
11009         (extended_remote_target::attach): Update.
11010         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
11011         type.
11012         (gdbsim_target::pid_to_str): Change return type.
11013         * ravenscar-thread.c (struct ravenscar_thread_target)
11014         <pid_to_str>: Change return type.
11015         (ravenscar_thread_target::pid_to_str): Change return type.
11016         * procfs.c (class procfs_target) <pid_to_str>: Change return
11017         type.
11018         (procfs_target::pid_to_str): Change return type.
11019         (procfs_target::attach): Update.
11020         (procfs_target::detach): Update.
11021         (procfs_target::fetch_registers): Update.
11022         (procfs_target::store_registers): Update.
11023         (procfs_target::wait): Update.
11024         (procfs_target::files_info): Update.
11025         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
11026         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
11027         return type.
11028         (nto_procfs_target::pid_to_str): Change return type.
11029         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
11030         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
11031         return type.
11032         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
11033         (exit_lwp): Update.
11034         (attach_proc_task_lwp_callback, get_detach_signal)
11035         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
11036         (linux_nat_target::resume, wait_lwp, stop_callback)
11037         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
11038         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
11039         (linux_nat_wait_1, resume_stopped_resumed_lwps)
11040         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
11041         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
11042         type.
11043         (inf_ptrace_target::attach): Update.
11044         (inf_ptrace_target::files_info): Update.
11045         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
11046         type.
11047         (go32_nat_target::pid_to_str): Change return type.
11048         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
11049         (gnu_nat_target::wait): Update.
11050         (gnu_nat_target::wait): Update.
11051         (gnu_nat_target::resume): Update.
11052         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
11053         (fbsd_nat_target::wait): Update.
11054         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
11055         type.
11056         (darwin_nat_target::attach): Update.
11057         * corelow.c (class core_target) <pid_to_str>: Change return type.
11058         (core_target::pid_to_str): Change return type.
11059         * target.c (normal_pid_to_str): Change return type.
11060         (default_pid_to_str): Likewise.
11061         (target_pid_to_str): Change return type.
11062         (target_translate_tls_address): Update.
11063         (target_announce_detach): Update.
11064         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
11065         return type.
11066         (bsd_uthread_target::pid_to_str): Change return type.
11067         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
11068         type.
11069         (bsd_kvm_target::pid_to_str): Change return type.
11070         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
11071         return type.
11072         (aix_thread_target::pid_to_str): Change return type.
11073         * target.h (struct target_ops) <pid_to_str>: Change return type.
11074         (target_pid_to_str, normal_pid_to_str): Likewise.
11075         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
11076         type.
11077         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
11078         type.
11079         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
11080         return type.
11081         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
11082         type.
11083         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
11084         type.
11085         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
11086         return type.
11087
11088 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
11089
11090         * NEWS: Mention that the new default MI version is 3.  Mention
11091         changes to the output of commands and events that deal with
11092         multi-location breakpoints.
11093         * breakpoint.c: Include "mi/mi-out.h".
11094         (print_one_breakpoint): Change output syntax if using MI version
11095         >= 3.
11096         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
11097         New.
11098         (mi_multi_location_breakpoint_output_fixed): New.
11099         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
11100         (mi_cmd_fix_multi_location_breakpoint_output): New.
11101         (mi_multi_location_breakpoint_output_fixed): New.
11102         * mi/mi-cmds.c (mi_cmds): Register command
11103         -fix-multi-location-breakpoint-output.
11104         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
11105         interpreter "mi".
11106
11107 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
11108
11109         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
11110         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
11111         instantiate mi_ui_out based on interpreter name.
11112         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
11113         * mi/mi-main.c (mi_load_progress): Likewise.
11114
11115 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11116
11117         * NEWS: Combine separate "New targets" sections for 8.3.
11118
11119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11120
11121         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
11122         (ppcfbsd_init_abi): Install gdbarch
11123         "fetch_tls_load_module_address" and "get_thread_local_address"
11124         methods.
11125
11126 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11127
11128         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
11129         (riscv_fbsd_init_abi): Install gdbarch
11130         "fetch_tls_load_module_address" and "get_thread_local_address"
11131         methods.
11132
11133 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11134
11135         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
11136         (i386fbsd_init_abi): Install gdbarch
11137         "fetch_tls_load_module_address" and "get_thread_local_address"
11138         methods.
11139
11140 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11141
11142         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
11143         (amd64fbsd_init_abi): Install gdbarch
11144         "fetch_tls_load_module_address" and "get_thread_local_address"
11145         methods.
11146
11147 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11148
11149         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
11150         (struct fbsd_pspace_data): New type.
11151         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
11152         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
11153         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
11154         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
11155         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
11156
11157 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11158
11159         * gdbtypes.c (lookup_struct_elt): New function.
11160         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
11161         * gdbtypes.h (struct struct_elt): New type.
11162         (lookup_struct_elt): New prototype.
11163
11164 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11165
11166         * gdbtypes.c (lookup_struct_elt_type): Update comment and
11167         remove disabled code block.
11168
11169 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11170
11171         * gdbarch.sh (get_thread_local_address): New method.
11172         * gdbarch.h, gdbarch.c: Regenerate.
11173         * target.c (target_translate_tls_address): Use
11174         gdbarch_get_thread_local_address if present instead of
11175         target::get_thread_local_address.
11176
11177 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11178
11179         * target.h (target::get_thread_local_address): Update comment.
11180
11181 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11182
11183         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
11184         objfile->separate_debug_objfile_backlink if not NULL.
11185
11186 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11187
11188         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
11189         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
11190         (amd64bsd_store_inferior_registers): Likewise.
11191         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11192         Enable segment base registers.
11193         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
11194         PT_GETFSBASE and PT_GETGSBASE.
11195         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
11196         PT_SETGSBASE.
11197         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
11198         segment base registers.
11199         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11200
11201 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
11202
11203         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
11204         Update calls to i386_target_description to add 'segments'
11205         parameter.
11206         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
11207         add segment base registers.
11208         * arch/i386.c (i386_create_target_description): Add 'segments'
11209         parameter to enable segment base registers.
11210         * arch/i386.h (i386_create_target_description): Likewise.
11211         * features/i386/32bit-segments.xml: New file.
11212         * features/i386/32bit-segments.c: Generate.
11213         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
11214         call to i386_target_description to add 'segments' parameter.
11215         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
11216         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
11217         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
11218         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
11219         if feature is present.
11220         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
11221         Add 'segments' parameter to call to i386_target_description.
11222         (i386_target_description): Add 'segments' parameter to enable
11223         segment base registers.
11224         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
11225         to call to i386_target_description.
11226         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
11227         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
11228         Define I386_NUM_REGS.
11229         (i386_target_description): Add 'segments' parameter to enable
11230         segment base registers.
11231
11232 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
11233
11234         PR/24325
11235         * source-cache.c: #undef open and close, to avoid unresolved
11236         externals during linking.
11237
11238 2019-03-12  Tom Tromey  <tromey@adacore.com>
11239
11240         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
11241         const.  Add initializers.
11242         (_initialize_remote): Don't initialize ptid globals.
11243
11244 2019-03-12  Pedro Alves  <palves@redhat.com>
11245
11246         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
11247
11248 2019-03-12  Pedro Alves  <palves@redhat.com>
11249
11250         * cp-name-parser.y (main): Remove unused 'len' variable.
11251
11252 2019-03-12  Tom Tromey  <tromey@adacore.com>
11253
11254         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
11255         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
11256
11257 2019-03-12  Tom Tromey  <tromey@adacore.com>
11258
11259         * linux-nat.c (iterate_over_lwps): Update.
11260         (stop_callback): Remove parameter.
11261         (stop_wait_callback, detach_callback, resume_set_callback)
11262         (select_singlestep_lwp_callback, set_ignore_sigint)
11263         (status_callback, resumed_callback, resume_clear_callback)
11264         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
11265         data parameter.
11266         (linux_nat_target::detach, linux_nat_target::resume)
11267         (linux_stop_and_wait_all_lwps, select_event_lwp)
11268         (linux_nat_filter_event, linux_nat_wait_1)
11269         (linux_nat_target::kill, linux_nat_target::stop)
11270         (linux_nat_target::stop): Update.
11271         (linux_nat_resume_callback): Change type.
11272         (resume_stopped_resumed_lwps, count_events_callback)
11273         (select_event_lwp_callback): Likewise.
11274         (linux_stop_lwp, linux_nat_stop_lwp): Update.
11275         * arm-linux-nat.c (struct update_registers_data): Remove.
11276         (update_registers_callback): Change type.
11277         (arm_linux_insert_hw_breakpoint1): Update.
11278         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
11279         parameter.
11280         (x86_linux_dr_set_addr): Update.
11281         (x86_linux_dr_set_control): Update.
11282         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
11283         (iterate_over_lwps): Use gdb::function_view.
11284         * nat/aarch64-linux-hw-point.c (struct
11285         aarch64_dr_update_callback_param): Remove.
11286         (debug_reg_change_callback): Change type.
11287         (aarch64_notify_debug_reg_change): Update.
11288         * s390-linux-nat.c (s390_refresh_per_info): Update.
11289
11290 2019-03-11  Tom Tromey  <tromey@adacore.com>
11291
11292         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
11293         redundant assignment to "this_cu".
11294
11295 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11296
11297         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
11298
11299 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11300
11301         * gdbtypes.c (rank_one_type_parm_set): New function extracted
11302         from...
11303         (rank_one_type): ... this.
11304
11305 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11306
11307         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
11308         from...
11309         (rank_one_type): ... this.
11310
11311 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11312
11313         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
11314         from...
11315         (rank_one_type): ... this.
11316
11317 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11318
11319         * gdbtypes.c (rank_one_type_parm_float): New function extracted
11320         from...
11321         (rank_one_type): ... this.
11322
11323 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11324
11325         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
11326         from...
11327         (rank_one_type): ... this.
11328
11329 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11330
11331         * gdbtypes.c (rank_one_type_parm_range): New function extracted
11332         from...
11333         (rank_one_type): ... this.
11334
11335 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11336
11337         * gdbtypes.c (rank_one_type_parm_char): New function extracted
11338         from...
11339         (rank_one_type): ... this.
11340
11341 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11342
11343         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
11344         from...
11345         (rank_one_type): ... this.
11346
11347 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11348
11349         * gdbtypes.c (rank_one_type_parm_int): New function extracted
11350         from...
11351         (rank_one_type): ... this.
11352
11353 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11354
11355         * gdbtypes.c (rank_one_type_parm_func): New function extracted
11356         from...
11357         (rank_one_type): ... this.
11358
11359 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11360
11361         * gdbtypes.c (rank_one_type_parm_array): New function extracted
11362         from...
11363         (rank_one_type): ... this.
11364
11365 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
11366
11367         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
11368         from...
11369         (rank_one_type): ... this.
11370
11371 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11372
11373         * inferior.c (initialize_inferiors): Ensure 'help set/show print
11374         inferior-events' shows the example events.
11375
11376 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
11377
11378         Support styling on native MS-Windows console
11379
11380         PR/24315
11381         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
11382         on MS-Windows if $TERM is not defined.
11383
11384         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
11385
11386         * posix-hdep.c (gdb_console_fputs):
11387         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
11388         functions.
11389         * ui-file.h (gdb_console_fputs): Add prototype.
11390
11391         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
11392         back to fputs only if the former returns zero.
11393
11394 2019-03-07  Tom Tromey  <tom@tromey.com>
11395
11396         * symmisc.c (print_symbol_bcache_statistics): Update.
11397         (print_objfile_statistics): Update.
11398         * symfile.c (allocate_symtab): Update.
11399         * stabsread.c: Don't include bcache.h.
11400         * psymtab.h (struct psymbol_bcache): Don't declare.
11401         (class psymtab_storage) <psymbol_cache>: Now a bcache.
11402         (psymbol_bcache_init, psymbol_bcache_free)
11403         (psymbol_bcache_get_bcache): Don't declare.
11404         * psymtab.c (struct psymbol_bcache): Remove.
11405         (psymtab_storage::psymtab_storage): Update.
11406         (psymtab_storage::~psymtab_storage): Update.
11407         (psymbol_bcache_init, psymbol_bcache_free)
11408         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
11409         (add_psymbol_to_bcache): Update.
11410         (allocate_psymtab): Update.
11411         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
11412         macro_cache>: No longer pointers.
11413         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
11414         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
11415         * macrotab.c (macro_bcache): Update.
11416         * macroexp.c: Don't include bcache.h.
11417         * gdbtypes.c (check_types_worklist): Update.
11418         (types_deeply_equal): Remove TRY/CATCH.  Update.
11419         * elfread.c (elf_symtab_read): Update.
11420         * dwarf2read.c: Don't include bcache.h.
11421         * buildsym.c (buildsym_compunit::get_macro_table): Update.
11422         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
11423         (print_bcache_statistics, bcache_memory_used): Don't declare.
11424         (struct bcache): Move from bcache.c.  Add constructor, destructor,
11425         methods.  Rename all data members.
11426         * bcache.c (struct bcache): Move to bcache.h.
11427         (bcache::expand_hash_table): Rename from expand_hash_table.
11428         (bcache): Remove.
11429         (bcache::insert): Rename from bcache_full.
11430         (bcache::compare): Rename from bcache_compare.
11431         (bcache_xmalloc): Remove.
11432         (bcache::~bcache): Rename from bcache_xfree.
11433         (bcache::print_statistics): Rename from print_bcache_statistics.
11434         (bcache::memory_used): Rename from bcache_memory_used.
11435
11436 2019-03-07  Pedro Alves  <palves@redhat.com>
11437
11438         * infrun.c (normal_stop): Also check for
11439         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
11440
11441 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
11442
11443         * f-lang.c (value_from_host_double): Moved to...
11444         * value.c (value_from_host_double): ...here.
11445         * value.h (value_from_host_double): Declare.
11446         * guile/scm-math.c (vlscm_convert_typed_number): Use
11447         value_from_host_double.
11448         (vlscm_convert_number): Likewise.
11449         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
11450         * python/py-value.c (convert_value_from_python): Likewise.
11451
11452 2019-03-06  Tom Tromey  <tom@tromey.com>
11453
11454         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
11455
11456 2019-03-06  Tom Tromey  <tom@tromey.com>
11457
11458         * utils.h (free_current_contents): Don't declare.
11459         * utils.c (free_current_contents): Remove.
11460
11461 2019-03-06  Tom Tromey  <tom@tromey.com>
11462
11463         * top.c (quit_force): Update.
11464         * main.c (captured_command_loop): Update.
11465         * common/new-op.c (operator new): Update.
11466         * common/common-exceptions.c (struct catcher)
11467         <save_cleanup_chain>: Remove member.
11468         (exceptions_state_mc_init): Update.
11469         (exception_try_scope_entry): Return nullptr.
11470         (exception_try_scope_exit, exception_rethrow)
11471         (throw_exception_sjlj, throw_exception_cxx): Update.
11472         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
11473         (all_cleanups, do_cleanups, discard_cleanups)
11474         (discard_final_cleanups, save_cleanups, save_final_cleanups)
11475         (restore_cleanups, restore_final_cleanups): Don't declare.
11476         (do_final_cleanups): Remove parameter.
11477         * common/cleanups.c (cleanup_chain, make_cleanup)
11478         (make_cleanup_dtor, all_cleanups, do_cleanups)
11479         (discard_my_cleanups, discard_cleanups)
11480         (discard_final_cleanups, save_my_cleanups, save_cleanups)
11481         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
11482         (null_cleanup): Remove.
11483         (do_final_cleanups): Remove parameter.
11484
11485 2019-03-06  Tom Tromey  <tom@tromey.com>
11486
11487         * remote.c (remote_target::remote_parse_stop_reply): Use
11488         unique_xmalloc_ptr.
11489
11490 2019-03-06  Tom Tromey  <tom@tromey.com>
11491
11492         * stabsread.c (struct stabs_field_info): Rename from field_info.
11493         <list, fnlist>: Add initializers.
11494         <obstack>: New member.
11495         (read_member_functions, read_struct_fields, read_baseclasses):
11496         Allocate on obstack.  Don't use cleanups.
11497         (read_one_struct_field, read_member_functions, read_struct_fields)
11498         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
11499         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
11500         (read_struct_type): Update.
11501
11502 2019-03-06  Tom Tromey  <tom@tromey.com>
11503
11504         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
11505         * common/filestuff.h (make_cleanup_close): Don't declare.
11506         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
11507         Remove.
11508
11509 2019-03-06  Tom Tromey  <tom@tromey.com>
11510
11511         * solib-aix.c: Use make_scope_exit.
11512
11513 2019-03-06  Tom Tromey  <tom@tromey.com>
11514
11515         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
11516         Use make_scope_exit.
11517
11518 2019-03-06  Tom Tromey  <tom@tromey.com>
11519
11520         * solib-svr4.c (disable_probes_interface): Remove parameter.
11521         (svr4_handle_solib_event): Use make_scope_exit.
11522
11523 2019-03-06  Tom Tromey  <tom@tromey.com>
11524
11525         * remote.c (struct stop_reply_deleter): Remove.
11526         (stop_reply_up): Update.
11527         (struct stop_reply): Derive from notif_event.  Don't typedef.
11528         <regcache>: Now a std::vector.
11529         (stop_reply_xfree): Remove.
11530         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
11531         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
11532         (remote_target::discard_pending_stop_replies): Use delete.
11533         (remote_target::remote_parse_stop_reply): Update.
11534         (remote_target::process_stop_reply): Update.
11535         * remote-notif.h (struct notif_event): Add virtual destructor.
11536         Remove "dtr" member.
11537         (struct notif_client) <alloc_event>: Return a unique_ptr.
11538         (notif_event_xfree): Don't declare.
11539         (notif_event_up): New typedef.
11540         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
11541         (notif_event_xfree, do_notif_event_xfree): Remove.
11542         (remote_notif_state_xfree): Update.
11543
11544 2019-03-06  Tom Tromey  <tom@tromey.com>
11545
11546         * infrun.c (displaced_step_clear_cleanup): Now a
11547         forward_scope_exit type.
11548         (displaced_step_prepare_throw): Update.
11549         (displaced_step_fixup): Update.
11550
11551 2019-03-06  Tom Tromey  <tom@tromey.com>
11552
11553         * inferior.h (class inferior): Update comment.
11554         * gdbthread.h (class thread_info): Update comment.
11555
11556 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11557             Tom Tromey  <tom@tromey.com>
11558
11559         * stabsread.h (struct stab_section_list): Remove.
11560         (coffstab_build_psymtabs): Update.
11561         * dbxread.c (symbuf_sections): Now a std::vector.
11562         (sect_idx): New global.
11563         (fill_symbuf): Update.
11564         (coffstab_build_psymtabs): Change type of stabsects parameter.
11565         Update.
11566         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11567         std::vector.
11568         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11569         (coff_locate_sections): Update.
11570         (coff_symfile_read): Remove cleanups.  Update.
11571         (init_stringtab): Add storage parameter.
11572         (free_stringtab, free_stringtab_cleanup): Remove.
11573         (init_lineno): Add storage parameter.
11574         (free_linetab, free_linetab_cleanup): Remove.
11575
11576 2019-03-06  Pedro Alves  <palves@redhat.com>
11577
11578         * linux-fork.c (fork_info::clobber_regs): Delete.
11579         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11580         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11581         comment.  Adjust.
11582         (scoped_switch_fork_info::scoped_switch_fork_info)
11583         (checkpoint_command, linux_fork_context): Adjust
11584         fork_save_infrun_state calls.
11585
11586 2019-03-06  Pedro Alves  <palves@redhat.com>
11587
11588         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11589         (inf_has_multiple_threads): Return 'bool' and rewrite using
11590         inferior_info::threads().
11591
11592 2019-03-06  Pedro Alves  <palves@redhat.com>
11593
11594         * linux-fork.c: Include <list>.
11595         (fork_list): Now a std::list instance.
11596         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11597         (forks_exist_p, find_last_fork): Adjust.
11598         (new_fork): Delete.
11599         (one_fork_p): New.
11600         (add_fork): Adjust.
11601         (free_fork): Delete, folded into fork_info::~fork_info().
11602         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11603         Adjust.
11604         (init_fork_list): Delete.
11605         (linux_fork_killall, linux_fork_mourn_inferior)
11606         (linux_fork_detach, info_checkpoints_command): Adjust.
11607         (_initialize_linux_fork): No longer call init_fork_list.
11608
11609 2019-03-06  Pedro Alves  <palves@redhat.com>
11610
11611         * linux-fork.c (new_fork): New, split out of ...
11612         (add_fork): ... this.  Return void.  Move "first fork" special
11613         case from here, to ...
11614         (checkpoint_command): ... here.
11615         * linux-linux.h (add_fork): Return void.
11616
11617 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11618
11619         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11620
11621 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11622             Chris January  <chris.january@arm.com>
11623             David Lecomber  <david.lecomber@arm.com>
11624
11625         * f-exp.y: New token, UNOP_INTRINSIC.
11626         (exp): New pattern using UNOP_INTRINSIC token.
11627         (f77_keywords): Add 'abs' keyword.
11628         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11629         (value_from_host_double): New function.
11630         (evaluate_subexp_f): Support UNOP_ABS.
11631
11632 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11633
11634         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11635         types.
11636
11637 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11638
11639         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11640         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11641         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11642
11643 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11644
11645         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11646
11647 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11648             Chris January  <chris.january@arm.com>
11649
11650         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11651         * f-exp.y: Define 'KIND' token.
11652         (exp): New pattern for KIND expressions.
11653         (ptype): Handle types with a kind extension.
11654         (direct_abs_decl): Extend to spot kind extensions.
11655         (f77_keywords): Add 'kind' to the list.
11656         (push_kind_type): New function.
11657         (convert_to_kind_type): New function.
11658         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11659         * parse.c (operator_length_standard): Likewise.
11660         * parser-defs.h (enum type_pieces): Add tp_kind.
11661         * std-operator.def: Add UNOP_KIND.
11662
11663 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11664
11665         * f-exp.y (f_parse): Set yydebug.
11666
11667 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11668
11669         * f-lang.c (evaluate_subexp_f): New function.
11670         (exp_descriptor_f): New global.
11671         (f_language_defn): Use exp_descriptor_f instead of
11672         exp_descriptor_standard.
11673
11674 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11675
11676         * f-exp.y (struct token): Add comments.
11677         (dot_ops): Remove uppercase versions and the end marker.
11678         (f77_keywords): Likewise.
11679         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11680         entries in the dot_ops array are case insensitive, and use
11681         strncasecmp to compare strings.  Also some whitespace cleanup in
11682         this area.  Similar for the f77_keywords array, except entries in
11683         this list might be case sensitive.
11684
11685 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11686
11687         * f-exp.y (struct f77_boolean_val): Add comments.
11688         (boolean_values): Remove uppercase versions, and end marker.
11689         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11690         and use strncasecmp to achieve case insensitivity.  Additionally,
11691         perform whitespace cleanup around this code.
11692
11693 2019-03-06  Tom Tromey  <tromey@adacore.com>
11694
11695         * remote-sim.c (gdbsim_target_open): Use result of
11696         gdb_argv::release.
11697
11698 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11699         Dirk Schubert  <dirk.schubert@arm.com>
11700         Chris January  <chris.january@arm.com>
11701
11702         * eval.c (evaluate_subexp_standard): Call Fortran argument
11703         wrapping logic.
11704         * f-lang.c (struct value): A value which can be passed into a
11705         Fortran function call.
11706         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11707         where appropriate.
11708         (struct type): Value ready for a Fortran function call.
11709         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11710         is needed.
11711         * f-lang.h (fortran_argument_convert): Declaration.
11712         (fortran_preserve_arg_pointer): Declaration.
11713         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11714
11715 2019-03-05  Tom Tromey  <tromey@adacore.com>
11716
11717         * python/py-prettyprint.c (print_string_repr): Remove #if.
11718         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11719
11720 2019-03-05  Tom Tromey  <tromey@adacore.com>
11721
11722         * target.c (the_dummy_target): Move later.  Change type to
11723         "dummy_target".
11724         (initialize_targets): Don't initialize the_dummy_target.
11725
11726 2019-03-05  Tom Tromey  <tromey@adacore.com>
11727
11728         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11729         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11730
11731 2019-03-05  Tom Tromey  <tromey@adacore.com>
11732
11733         * windows-nat.c (windows_nat_target::attach)
11734         (windows_nat_target::detach): Don't call gdb_flush.
11735         * valprint.c (generic_val_print, val_print, val_print_string):
11736         Don't call gdb_flush.
11737         * utils.c (defaulted_query): Don't call gdb_flush.
11738         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11739         * target.c (target_announce_detach): Don't call gdb_flush.
11740         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11741         * remote.c (extended_remote_target::attach): Don't call
11742         gdb_flush.
11743         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11744         * printcmd.c (do_examine): Don't call gdb_flush.
11745         (info_display_command): Don't call gdb_flush.
11746         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11747         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11748         * memattr.c (info_mem_command): Don't call gdb_flush.
11749         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11750         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11751         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11752         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11753         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11754         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11755         (gnu_nat_target::detach): Don't call gdb_flush.
11756         * f-valprint.c (f_val_print): Don't call gdb_flush.
11757         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11758         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11759         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11760         gdb_flush.
11761         * c-valprint.c (c_val_print): Don't call gdb_flush.
11762         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11763
11764 2019-03-05  Tom Tromey  <tromey@adacore.com>
11765
11766         * varobj.c (update_dynamic_varobj_children): Update.
11767         (install_default_visualizer): Use reset, not release.
11768         * value.c (set_internalvar): Update.
11769         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11770         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11771         ATTRIBUTE_UNUSED_RESULT.
11772
11773 2019-03-05  Tom Tromey  <tromey@adacore.com>
11774
11775         * remote.c (class scoped_remote_fd) <release>: Add
11776         ATTRIBUTE_UNUSED_RESULT.
11777
11778 2019-03-05  Tom Tromey  <tromey@adacore.com>
11779
11780         * macroexp.c (struct macro_buffer) <release>: Add
11781         ATTRIBUTE_UNUSED_RESULT.
11782
11783 2019-03-05  Tom Tromey  <tromey@adacore.com>
11784
11785         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11786         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11787         ATTRIBUTE_UNUSED_RESULT.
11788
11789 2019-03-05  Tom Tromey  <tromey@adacore.com>
11790
11791         * common/scoped_fd.h (class scoped_fd) <release>: Add
11792         ATTRIBUTE_UNUSED_RESULT.
11793
11794 2019-03-05  Tom Tromey  <tromey@adacore.com>
11795
11796         * parser-defs.h (struct parser_state) <release>: Add
11797         ATTRIBUTE_UNUSED_RESULT.
11798
11799 2019-03-05  Tom Tromey  <tromey@adacore.com>
11800
11801         * utils.h (class gdb_argv) <release>: Add
11802         ATTRIBUTE_UNUSED_RESULT.
11803         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11804
11805 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11806
11807         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11808         for-loop range, to avoid compiler warnings.
11809
11810         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11811         avoid compiler warnings about unused variables.
11812
11813         * NEWS: Mention end of support for native debugging on MS-Windows
11814         before XP.
11815
11816         PR gdb/24292
11817         * common/netstuff.c:
11818         * gdbserver/gdbreplay.c
11819         * gdbserver/remote-utils.c:
11820         * ser-tcp.c:
11821         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11822         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11823         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11824         'getaddrinfo' and 'freeaddrinfo' were not available before
11825         Windows XP, and mingw.org's MinGW headers by default define
11826         _WIN32_WINNT to 0x500.
11827
11828 2019-03-01  Gary Benson <gbenson@redhat.com>
11829
11830         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11831
11832 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11833             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11834
11835         PR gdb/8527
11836         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11837         set_sigint_trap, clear_sigint_trap.
11838
11839 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11840
11841         * target.c (target_detach): Clear the regcache and the
11842         frame cache.
11843
11844 2019-02-27  Pedro Alves  <palves@redhat.com>
11845
11846         * utils.c (set_screen_size): When we cap the height/width sizes,
11847         tweak the corresponding command variable to show "unlimited":
11848
11849 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11850             Pedro Alves  <palves@redhat.com>
11851
11852         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11853         before calling rl_set_screen_size.
11854
11855 2019-02-27  Tom Tromey  <tromey@adacore.com>
11856
11857         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11858         define.
11859         * python/py-value.c: Remove Python 2.4 workaround.
11860         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11861         workaround.
11862         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11863         Python 2.4 workaround.
11864         * python/python-internal.h: Remove Python 2.4 comment.
11865         (Py_ssize_t): Don't define.
11866         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11867         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11868         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11869         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11870         * python/python.c (do_start_initialization): Remove Python 2.4
11871         workaround.
11872         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11873         (print_children): Remove Python 2.4 workaround.
11874         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11875         workaround.
11876         (CHARBUFFERPROC_NAME): Remove.
11877         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11878         Python 2.4 workaround.
11879
11880 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11881
11882         * NEWS: Note minimum Python version.
11883
11884 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11885
11886         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11887         code from these functions.  Remove corresponding ifdefs.  Use
11888         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11889         Remove gotos and target of gotos.
11890         (infpy_search_memory): Likewise.
11891
11892 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11893
11894         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11895         (hppa_gdbarch_init): Don't register deleted functions with
11896         gdbarch.
11897
11898 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11899
11900         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11901         (h8300_unwind_sp): Delete.
11902         (h8300_dummy_id): Delete.
11903         (h8300_gdbarch_init): Don't register deleted functions with
11904         gdbarch.
11905
11906 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11907
11908         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11909         (ft32_unwind_pc): Delete.
11910         (ft32_unwind_sp): Delete.
11911         (ft32_gdbarch_init): Don't register deleted functions with
11912         gdbarch.
11913
11914 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11915
11916         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11917         (frv_unwind_pc): Delete.
11918         (frv_unwind_sp): Delete.
11919         (frv_gdbarch_init): Don't register deleted functions with
11920         gdbarch.
11921
11922 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11923
11924         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11925         (riscv_unwind_pc): Delete.
11926         (riscv_unwind_sp): Delete.
11927         (riscv_gdbarch_init): Don't register deleted functions with
11928         gdbarch.
11929
11930 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11931
11932         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11933         (csky_unwind_pc): Delete.
11934         (csky_unwind_sp): Delete.
11935         (csky_gdbarch_init): Don't register deleted functions with
11936         gdbarch.
11937
11938 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11939
11940         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11941         (cris_unwind_pc): Delete.
11942         (cris_unwind_sp): Delete.
11943         (cris_gdbarch_init): Don't register deleted functions with
11944         gdbarch.
11945
11946 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11947
11948         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11949         (bfin_unwind_pc): Delete.
11950         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11951
11952 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11953
11954         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11955         (arm_unwind_pc): Delete.
11956         (arm_unwind_sp): Delete.
11957         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11958
11959 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11960
11961         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11962         (arc_unwind_pc): Delete.
11963         (arc_unwind_sp): Delete.
11964         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11965
11966 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11967
11968         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11969         (alpha_unwind_pc): Delete.
11970         (alpha_gdbarch_init): Don't register deleted functions with
11971         gdbarch.
11972
11973 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11974
11975         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11976         (aarch64_unwind_pc): Delete.
11977         (aarch64_unwind_sp): Delete.
11978         (aarch64_gdbarch_init): Don't register deleted functions with
11979         gdbarch.
11980
11981 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11982
11983         * gdbtypes.c (type_align): Don't consider static members when
11984         computing structure alignment.
11985
11986 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11987
11988         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11989         return 0 for other types.
11990         * arch-utils.c (default_type_align): Always return 0.
11991         * gdbarch.h: Regenerate.
11992         * gdbarch.sh (type_align): Extend comment.
11993         * gdbtypes.c (type_align): Add additional comments, always call
11994         gdbarch_type_align before applying the default rules.
11995         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11996         generic code will then apply a suitable default.
11997         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11998         types, return 0 for other types.
11999
12000 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12001
12002         * NEWS: Create a new section for the next release branch.
12003         Rename the section of the current branch, now that it has
12004         been cut.
12005
12006 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
12007
12008         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
12009         * version.in: Bump version to 8.3.50.DATE-git.
12010
12011 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
12012
12013         * aix-thread.c (ptid_cmp): Remove unused variable.
12014         (get_signaled_thread): Likewise.
12015         (store_regs_user_thread): Likewise.
12016         (store_regs_kernel_thread): Likewise.
12017         (fetch_regs_kernel_thread): Remove shadowed variable.
12018
12019 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
12020
12021         * features/riscv/32bit-cpu.xml: Add register numbers.
12022         * features/riscv/32bit-fpu.c: Regenerate.
12023         * features/riscv/32bit-fpu.xml: Add register numbers.
12024         * features/riscv/64bit-cpu.xml: Add register numbers.
12025         * features/riscv/64bit-fpu.c: Regenerate.
12026         * features/riscv/64bit-fpu.xml: Add register numbers.
12027
12028 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
12029
12030         * NEWS: Mention two argument form of gdb.Value constructor.
12031         * python/py-value.c (convert_buffer_and_type_to_value): New
12032         function.
12033         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
12034         Add support for handling an optional second argument.  Call
12035         convert_buffer_and_type_to_value as appropriate.
12036         * python/python-internal.h (Py_buffer_deleter): New struct.
12037         (Py_buffer_up): New typedef.
12038
12039 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
12040
12041         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
12042         instead of releasing ownership.
12043
12044 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
12045
12046         * dwarf2read.c (open_and_init_dwp_file): Call
12047         elf_numsections instead of bfd_count_sections to initialize
12048         dwp_file->num_sections.
12049
12050 2019-02-25  Tom Tromey  <tromey@adacore.com>
12051
12052         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
12053
12054 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
12055
12056         * gcore.in: Add '--readnever' option when invoking GDB.
12057
12058 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12059
12060         * MAINTAINERS: Update my email address.
12061
12062 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
12063
12064         * build-id.c (build_id_to_debug_bfd_1): New function.
12065         (build_id_to_debug_bfd): Look for separate debug file in
12066         sysroot.
12067
12068 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
12069
12070         * gdbarch.sh: Update the copyright year range that is placed into
12071         generated files.
12072
12073 2019-02-22  Keith Seitz  <keiths@redhat.com>
12074
12075         PR symtab/23853
12076         * linespec.c (create_sals_line_offset): Search for the default
12077         symtab's filename instead of its fullname.
12078
12079 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12080
12081         * NEWS: Update style defaults.
12082
12083 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
12084
12085         * main.c (captured_main_1): Disable styling in batch mode.
12086
12087 2019-02-20  Tom Tromey  <tom@tromey.com>
12088
12089         * symtab.c (symtab_symbol_info): Fix typos.
12090
12091 2019-02-20  Tom Tromey  <tromey@adacore.com>
12092
12093         * findcmd.c (_initialize_mem_search): Use upper case for
12094         metasyntactic variables.
12095
12096 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
12097
12098         * aarch64-tdep.c (aarch64_add_reggroups): New function.
12099         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
12100
12101 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
12102
12103         * top.h (source_file_name): Change to std::string.
12104         * top.c (source_file_name): Likewise.
12105         (command_line_input): Adjust.
12106         * cli/cli-script.c (script_from_file): Adjust.
12107
12108 2019-02-19  Tom Tromey  <tromey@adacore.com>
12109
12110         * ravenscar-thread.c
12111         (ravenscar_thread_target::update_thread_list): Don't call
12112         ada_build_task_list.
12113         * ada-lang.h (ada_build_task_list): Don't declare.
12114         * ada-tasks.c (struct ada_tasks_inferior_data)
12115         <task_list_valid_p>: Now bool.
12116         (read_known_tasks, ada_task_list_changed)
12117         (ada_tasks_invalidate_inferior_data): Update.
12118         (read_known_tasks_array): Return bool.
12119         (read_known_tasks_list): Likewise.
12120         (read_known_tasks): Return void.
12121         (ada_build_task_list): Now static.
12122
12123 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
12124
12125         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
12126         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
12127
12128 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12129
12130         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
12131         variant for ada_tasks_pspace_data_handle and
12132         ada_tasks_inferior_data_handle.
12133         (ada_tasks_pspace_data_cleanup): New function.
12134         (ada_tasks_inferior_data_cleanup): New function.
12135
12136 2019-02-17  Tom Tromey  <tom@tromey.com>
12137
12138         * macrotab.h (macro_source_fullname): Return a std::string.
12139         * macrotab.c (macro_include, check_for_redefinition)
12140         (macro_undef, macro_lookup_definition, foreach_macro)
12141         (foreach_macro_in_scope): Update.
12142         (macro_source_fullname): Return a std::string.
12143         * macrocmd.c (show_pp_source_pos): Update.
12144
12145 2019-02-17  Tom Tromey  <tom@tromey.com>
12146
12147         * macrocmd.c (show_pp_source_pos): Style the file names.
12148
12149 2019-02-17  Tom Tromey  <tom@tromey.com>
12150
12151         PR tui/24197:
12152         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
12153
12154 2019-02-17  Tom Tromey  <tom@tromey.com>
12155
12156         * ada-lang.c (user_select_syms): Use filtered printing.
12157         * utils.c (wrap_style): New global.
12158         (desired_style): Remove.
12159         (emit_style_escape): Add stream parameter.
12160         (set_output_style, reset_terminal_style, prompt_for_continue):
12161         Update.
12162         (flush_wrap_buffer): Only flush gdb_stdout.
12163         (wrap_here): Set wrap_style.
12164         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
12165         treat escape sequences as a character.  Change when wrap buffer is
12166         flushed.
12167         (fputs_styled): Do not set the output style when the default is
12168         requested.
12169         * ui-style.h (struct ui_file_style) <is_default>: New method.
12170         * source.c (print_source_lines_base): Emit escape sequences in one
12171         piece.
12172
12173 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12174
12175         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
12176         integers and enumeration types.
12177
12178 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
12179
12180         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
12181         instead of lookup_symbol_in_language
12182         (do_exact_match): New function.
12183         (ada_get_symbol_name_matcher): Return do_exact_match when
12184         doing a verbatim match.
12185
12186 2019-02-15  Tom Tromey  <tromey@adacore.com>
12187
12188         * ravenscar-thread.c (ravenscar_thread_target::resume)
12189         (ravenscar_thread_target::wait): Special case wildcard requests.
12190
12191 2019-02-15  Tom Tromey  <tromey@adacore.com>
12192
12193         * ravenscar-thread.c (base_ptid): Remove.
12194         (struct ravenscar_thread_target) <close>: New method.
12195         <m_base_ptid>: New member.
12196         <update_inferior_ptid, active_task, task_is_currently_active,
12197         runtime_initialized>: Declare methods.
12198         <ravenscar_thread_target>: Add constructor.
12199         (ravenscar_thread_target::task_is_currently_active)
12200         (ravenscar_thread_target::update_inferior_ptid)
12201         (ravenscar_runtime_initialized): Rename.  Now methods.
12202         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
12203         (ravenscar_thread_target::update_thread_list): Update.
12204         (ravenscar_thread_target::active_task): Now method.
12205         (ravenscar_thread_target::store_registers)
12206         (ravenscar_thread_target::prepare_to_store)
12207         (ravenscar_thread_target::prepare_to_store)
12208         (ravenscar_thread_target::mourn_inferior): Update.
12209         (ravenscar_inferior_created): Use "new" to create target.
12210         (ravenscar_thread_target::get_ada_task_ptid): Update.
12211         (_initialize_ravenscar): Don't initialize base_ptid.
12212         (ravenscar_ops): Remove global.
12213
12214 2019-02-15  Tom Tromey  <tromey@adacore.com>
12215
12216         * target.h (push_target): Declare new overload.
12217         * target.c (push_target): New overload, taking an rvalue reference.
12218         * remote.c (remote_target::open_1): Use push_target overload.
12219         * corelow.c (core_target_open): Use push_target overload.
12220
12221 2019-02-15  Tom Tromey  <tromey@adacore.com>
12222
12223         * ravenscar-thread.c (is_ravenscar_task)
12224         (ravenscar_task_is_currently_active): Return bool.
12225         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
12226         (_initialize_ravenscar): Remove "(void)".
12227         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
12228         Return bool.
12229
12230 2019-02-15  Tom Tromey  <tromey@adacore.com>
12231
12232         * ravenscar-thread.c (ravenscar_runtime_initializer)
12233         (has_ravenscar_runtime, get_running_thread_id)
12234         (ravenscar_thread_target::resume): Fix indentation.
12235
12236 2019-02-15  Tom Tromey  <tromey@adacore.com>
12237
12238         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
12239         from ravenscar_arch_ops.
12240         (sparc_ravenscar_ops::fetch_registers)
12241         (sparc_ravenscar_ops::store_registers): Now methods.
12242         (sparc_ravenscar_prepare_to_store): Remove.
12243         (sparc_ravenscar_ops): Redefine.
12244         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
12245         methods and destructor.  Remove members.
12246         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
12247         (ravenscar_thread_target::store_registers)
12248         (ravenscar_thread_target::prepare_to_store): Update.
12249         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
12250         Remove.
12251         (struct ppc_ravenscar_powerpc_ops): Derive from
12252         ravenscar_arch_ops.
12253         (ppc_ravenscar_powerpc_ops::fetch_registers)
12254         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
12255         (ppc_ravenscar_powerpc_ops): Redefine.
12256         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
12257         (ppc_ravenscar_e500_ops::fetch_registers)
12258         (ppc_ravenscar_e500_ops::store_registers): Now methods.
12259         (ppc_ravenscar_e500_ops): Redefine.
12260         * aarch64-ravenscar-thread.c
12261         (aarch64_ravenscar_generic_prepare_to_store): Remove.
12262         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
12263         (aarch64_ravenscar_fetch_registers)
12264         (aarch64_ravenscar_store_registers): Now methods.
12265         (aarch64_ravenscar_ops): Redefine.
12266
12267 2019-02-15  Tom Tromey  <tromey@adacore.com>
12268
12269         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
12270         (ravenscar_thread_target::stopped_by_hw_breakpoint)
12271         (ravenscar_thread_target::stopped_by_watchpoint)
12272         (ravenscar_thread_target::stopped_data_address)
12273         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
12274
12275 2019-02-15  Tom Tromey  <tromey@adacore.com>
12276
12277         * ravenscar-thread.c: Fix some typos.
12278
12279 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12280             Tom Tromey  <tromey@adacore.com>
12281
12282         * ada-lang.c (ada_exception_sal): Change addr_string to a
12283         std::string.
12284         (create_ada_exception_catchpoint): Update.
12285
12286 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12287             Tom Tromey  <tromey@adacore.com>
12288
12289         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
12290         (bp_location_ops): Remove.
12291         (base_breakpoint_allocate_location): Update.
12292         (free_bp_location): Update.
12293         * ada-lang.c (class ada_catchpoint_location)
12294         <ada_catchpoint_location>: Remove ops parameter.
12295         (ada_catchpoint_location_dtor): Remove.
12296         (ada_catchpoint_location_ops): Remove.
12297         (allocate_location_exception): Update.
12298         * breakpoint.h (struct bp_location_ops): Remove.
12299         (class bp_location) <bp_location>: Remove bp_location_ops
12300         parameter.
12301         <~bp_location>: Add destructor.
12302         <ops>: Remove.
12303
12304 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12305             Pedro Alves  <palves@redhat.com>
12306
12307         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
12308         'PATH_MAX'.
12309
12310 2019-02-14  David Michael  <fedora.dm0@gmail.com>
12311             Samuel Thibault  <samuel.thibault@gnu.org>
12312             Thomas Schwinge  <thomas@codesourcery.com>
12313
12314         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
12315         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
12316
12317 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
12318
12319         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
12320         (check_empty): Use "const char *".
12321
12322         * gnu-nat.c (gnu_nat_target::detach): Instead of
12323         'detach_inferior (pid)' call
12324         'detach_inferior (find_inferior_pid (pid))'.
12325
12326         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
12327         'nat/fork-inferior.o'.
12328         * gnu-nat.c: #include "nat/fork-inferior.h".
12329
12330         * gnu-nat.c (gnu_nat_target::detach): Instead of
12331         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
12332         * gnu-nat.h: #include "inf-child.h".
12333         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
12334         'i386_gnu_nat_target::fetch_registers'.
12335         (gnu_store_registers): Rename/move to
12336         'i386_gnu_nat_target::store_registers'.
12337
12338         * config/i386/nm-i386gnu.h: Don't "#include" any files.
12339         * gnu-nat.h (mach_thread_info): New function.
12340         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
12341
12342         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
12343
12344 2019-02-14  Frederic Konrad  <konrad@adacore.com>
12345
12346         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
12347
12348 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
12349
12350         * windows-nat.c (windows_add_thread): Add new parameter
12351         "main_thread_p" with default value set to false.  Update
12352         function documentation as well as all callers.
12353         (windows_delete_thread): Likewise.
12354         (fake_create_process): Update call to windows_add_thread.
12355         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
12356         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
12357         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
12358         call to windows_delete_thread.
12359
12360 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
12361
12362         * MAINTAINERS: Add Andrew Burgess as global maintainer.
12363
12364 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12365
12366         * symfile.c (find_separate_debug_file): Use canonical path of
12367         sysroot with child_path instead of gdb_sysroot if it is valid.
12368
12369 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12370
12371         * symfile.c (find_separate_debug_file): Use child_path to
12372         determine if an object file is under a sysroot.
12373
12374 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12375
12376         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
12377         unittests/child-path-selftests.c.
12378         * common/pathstuff.c (child_path): New function.
12379         * common/pathstuff.h (child_path): New prototype.
12380         * unittests/child-path-selftests.c: New file.
12381
12382 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
12383
12384         * symfile.c (find_separate_debug_file): Look for separate debug
12385         files in debug directories under the sysroot.
12386
12387 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12388
12389         * symtab.h (struct minimal_symbol data_p): New const method.
12390         (struct minimal_symbol text_p): Likewise.
12391         * symtab.c (output_source_filename): Use file name style
12392         to print file name.
12393         (print_symbol_info): Likewise.
12394         (print_msymbol_info): Use address style to print addresses.
12395         Use function name style to print executable text symbols.
12396         (expand_symtab_containing_pc): Use data_p.
12397         (find_pc_sect_compunit_symtab): Likewise.
12398
12399 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12400
12401         * breakpoint.c (describe_other_breakpoints): Use address style
12402         to print addresses.
12403         (say_where): Likewise.
12404
12405 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12406
12407         * ada-typeprint.c (print_func_type): Print function name
12408         style to print function name.
12409         * c-typeprint.c (c_print_type_1): Likewise.
12410
12411 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
12412
12413         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
12414         for execve.
12415
12416 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12417
12418         * c-exp.y (direct_abs_decl): Use emplace_back to record the
12419         type_stack.
12420
12421 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
12422
12423         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
12424         TYPE_CODE_REF types.
12425
12426 2019-02-08  Jim Wilson  <jimw@sifive.com>
12427
12428         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
12429         (riscv_linux_fregset): New.
12430         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
12431
12432 2019-02-07  Tom Tromey  <tom@tromey.com>
12433
12434         * thread.c (thread_cancel_execution_command): Update.
12435         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
12436         methods.
12437         (struct thread_fsm_ops): Remove.
12438         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
12439         (thread_fsm_should_stop, thread_fsm_return_value)
12440         (thread_fsm_set_finished, thread_fsm_finished_p)
12441         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
12442         Don't declare.
12443         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
12444         * infrun.c (clear_proceed_status_thread)
12445         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
12446         (print_stop_event): Update.
12447         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
12448         Add constructor.
12449         (step_command_fsm_ops): Remove.
12450         (new_step_command_fsm): Remove.
12451         (step_1): Update.
12452         (step_command_fsm::should_stop): Rename from
12453         step_command_fsm_should_stop.
12454         (step_command_fsm::clean_up): Rename from
12455         step_command_fsm_clean_up.
12456         (step_command_fsm::do_async_reply_reason): Rename from
12457         step_command_fsm_async_reply_reason.
12458         (struct until_next_fsm): Inherit from thread_fsm.  Add
12459         constructor.
12460         (until_next_fsm_ops): Remove.
12461         (new_until_next_fsm): Remove.
12462         (until_next_fsm::should_stop): Rename from
12463         until_next_fsm_should_stop.
12464         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
12465         (until_next_fsm::do_async_reply_reason): Rename from
12466         until_next_fsm_async_reply_reason.
12467         (struct finish_command_fsm): Inherit from thread_fsm.  Add
12468         constructor.  Change type of breakpoint.
12469         (finish_command_fsm_ops): Remove.
12470         (new_finish_command_fsm): Remove.
12471         (finish_command_fsm::should_stop): Rename from
12472         finish_command_fsm_should_stop.
12473         (finish_command_fsm::clean_up): Rename from
12474         finish_command_fsm_clean_up.
12475         (finish_command_fsm::return_value): Rename from
12476         finish_command_fsm_return_value.
12477         (finish_command_fsm::do_async_reply_reason): Rename from
12478         finish_command_fsm_async_reply_reason.
12479         (finish_command): Update.
12480         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
12481         Add constructor.
12482         (call_thread_fsm_ops): Remove.
12483         (call_thread_fsm::call_thread_fsm): Rename from
12484         new_call_thread_fsm.
12485         (call_thread_fsm::should_stop): Rename from
12486         call_thread_fsm_should_stop.
12487         (call_thread_fsm::should_notify_stop): Rename from
12488         call_thread_fsm_should_notify_stop.
12489         (run_inferior_call, call_function_by_hand_dummy): Update.
12490         * cli/cli-interp.c (should_print_stop_to_console): Update.
12491         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
12492         Add constructor.  Change type of location_breakpoint,
12493         caller_breakpoint.
12494         (until_break_fsm_ops): Remove.
12495         (new_until_break_fsm): Remove.
12496         (until_break_fsm::should_stop): Rename from
12497         until_break_fsm_should_stop.
12498         (until_break_fsm::clean_up): Rename from
12499         until_break_fsm_clean_up.
12500         (until_break_fsm::do_async_reply_reason): Rename from
12501         until_break_fsm_async_reply_reason.
12502         (until_break_command): Update.
12503         * thread-fsm.c: Remove.
12504         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
12505
12506 2019-02-07  Tom Tromey  <tom@tromey.com>
12507
12508         * yy-remap.h: Add include guard.
12509         * xtensa-tdep.h: Add include guard.
12510         * xcoffread.h: Rename include guard.
12511         * varobj-iter.h: Add include guard.
12512         * tui/tui.h: Rename include guard.
12513         * tui/tui-winsource.h: Rename include guard.
12514         * tui/tui-wingeneral.h: Rename include guard.
12515         * tui/tui-windata.h: Rename include guard.
12516         * tui/tui-win.h: Rename include guard.
12517         * tui/tui-stack.h: Rename include guard.
12518         * tui/tui-source.h: Rename include guard.
12519         * tui/tui-regs.h: Rename include guard.
12520         * tui/tui-out.h: Rename include guard.
12521         * tui/tui-layout.h: Rename include guard.
12522         * tui/tui-io.h: Rename include guard.
12523         * tui/tui-hooks.h: Rename include guard.
12524         * tui/tui-file.h: Rename include guard.
12525         * tui/tui-disasm.h: Rename include guard.
12526         * tui/tui-data.h: Rename include guard.
12527         * tui/tui-command.h: Rename include guard.
12528         * tic6x-tdep.h: Add include guard.
12529         * target/waitstatus.h: Rename include guard.
12530         * target/wait.h: Rename include guard.
12531         * target/target.h: Rename include guard.
12532         * target/resume.h: Rename include guard.
12533         * target-float.h: Rename include guard.
12534         * stabsread.h: Add include guard.
12535         * rs6000-tdep.h: Add include guard.
12536         * riscv-fbsd-tdep.h: Add include guard.
12537         * regformats/regdef.h: Rename include guard.
12538         * record.h: Rename include guard.
12539         * python/python.h: Rename include guard.
12540         * python/python-internal.h: Rename include guard.
12541         * python/py-stopevent.h: Rename include guard.
12542         * python/py-ref.h: Rename include guard.
12543         * python/py-record.h: Rename include guard.
12544         * python/py-record-full.h: Rename include guard.
12545         * python/py-record-btrace.h: Rename include guard.
12546         * python/py-instruction.h: Rename include guard.
12547         * python/py-events.h: Rename include guard.
12548         * python/py-event.h: Rename include guard.
12549         * procfs.h: Add include guard.
12550         * proc-utils.h: Add include guard.
12551         * p-lang.h: Add include guard.
12552         * or1k-tdep.h: Rename include guard.
12553         * observable.h: Rename include guard.
12554         * nto-tdep.h: Rename include guard.
12555         * nat/x86-linux.h: Rename include guard.
12556         * nat/x86-linux-dregs.h: Rename include guard.
12557         * nat/x86-gcc-cpuid.h: Add include guard.
12558         * nat/x86-dregs.h: Rename include guard.
12559         * nat/x86-cpuid.h: Rename include guard.
12560         * nat/ppc-linux.h: Rename include guard.
12561         * nat/mips-linux-watch.h: Rename include guard.
12562         * nat/linux-waitpid.h: Rename include guard.
12563         * nat/linux-ptrace.h: Rename include guard.
12564         * nat/linux-procfs.h: Rename include guard.
12565         * nat/linux-osdata.h: Rename include guard.
12566         * nat/linux-nat.h: Rename include guard.
12567         * nat/linux-namespaces.h: Rename include guard.
12568         * nat/linux-btrace.h: Rename include guard.
12569         * nat/glibc_thread_db.h: Rename include guard.
12570         * nat/gdb_thread_db.h: Rename include guard.
12571         * nat/gdb_ptrace.h: Rename include guard.
12572         * nat/fork-inferior.h: Rename include guard.
12573         * nat/amd64-linux-siginfo.h: Rename include guard.
12574         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12575         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12576         * nat/aarch64-linux.h: Rename include guard.
12577         * nat/aarch64-linux-hw-point.h: Rename include guard.
12578         * mn10300-tdep.h: Add include guard.
12579         * mips-linux-tdep.h: Add include guard.
12580         * mi/mi-parse.h: Rename include guard.
12581         * mi/mi-out.h: Rename include guard.
12582         * mi/mi-main.h: Rename include guard.
12583         * mi/mi-interp.h: Rename include guard.
12584         * mi/mi-getopt.h: Rename include guard.
12585         * mi/mi-console.h: Rename include guard.
12586         * mi/mi-common.h: Rename include guard.
12587         * mi/mi-cmds.h: Rename include guard.
12588         * mi/mi-cmd-break.h: Rename include guard.
12589         * m2-lang.h: Add include guard.
12590         * location.h: Rename include guard.
12591         * linux-record.h: Rename include guard.
12592         * linux-nat.h: Add include guard.
12593         * linux-fork.h: Add include guard.
12594         * i386-darwin-tdep.h: Rename include guard.
12595         * hppa-linux-offsets.h: Add include guard.
12596         * guile/guile.h: Rename include guard.
12597         * guile/guile-internal.h: Rename include guard.
12598         * gnu-nat.h: Rename include guard.
12599         * gdb-stabs.h: Rename include guard.
12600         * frv-tdep.h: Add include guard.
12601         * f-lang.h: Add include guard.
12602         * event-loop.h: Add include guard.
12603         * darwin-nat.h: Rename include guard.
12604         * cp-abi.h: Rename include guard.
12605         * config/sparc/nm-sol2.h: Rename include guard.
12606         * config/nm-nto.h: Rename include guard.
12607         * config/nm-linux.h: Add include guard.
12608         * config/i386/nm-i386gnu.h: Rename include guard.
12609         * config/djgpp/nl_types.h: Rename include guard.
12610         * config/djgpp/langinfo.h: Rename include guard.
12611         * compile/gcc-cp-plugin.h: Add include guard.
12612         * compile/gcc-c-plugin.h: Add include guard.
12613         * compile/compile.h: Rename include guard.
12614         * compile/compile-object-run.h: Rename include guard.
12615         * compile/compile-object-load.h: Rename include guard.
12616         * compile/compile-internal.h: Rename include guard.
12617         * compile/compile-cplus.h: Rename include guard.
12618         * compile/compile-c.h: Rename include guard.
12619         * common/xml-utils.h: Rename include guard.
12620         * common/x86-xstate.h: Rename include guard.
12621         * common/version.h: Rename include guard.
12622         * common/vec.h: Rename include guard.
12623         * common/tdesc.h: Rename include guard.
12624         * common/selftest.h: Rename include guard.
12625         * common/scoped_restore.h: Rename include guard.
12626         * common/scoped_mmap.h: Rename include guard.
12627         * common/scoped_fd.h: Rename include guard.
12628         * common/safe-iterator.h: Rename include guard.
12629         * common/run-time-clock.h: Rename include guard.
12630         * common/refcounted-object.h: Rename include guard.
12631         * common/queue.h: Rename include guard.
12632         * common/ptid.h: Rename include guard.
12633         * common/print-utils.h: Rename include guard.
12634         * common/preprocessor.h: Rename include guard.
12635         * common/pathstuff.h: Rename include guard.
12636         * common/observable.h: Rename include guard.
12637         * common/netstuff.h: Rename include guard.
12638         * common/job-control.h: Rename include guard.
12639         * common/host-defs.h: Rename include guard.
12640         * common/gdb_wait.h: Rename include guard.
12641         * common/gdb_vecs.h: Rename include guard.
12642         * common/gdb_unlinker.h: Rename include guard.
12643         * common/gdb_unique_ptr.h: Rename include guard.
12644         * common/gdb_tilde_expand.h: Rename include guard.
12645         * common/gdb_sys_time.h: Rename include guard.
12646         * common/gdb_string_view.h: Rename include guard.
12647         * common/gdb_splay_tree.h: Rename include guard.
12648         * common/gdb_setjmp.h: Rename include guard.
12649         * common/gdb_ref_ptr.h: Rename include guard.
12650         * common/gdb_optional.h: Rename include guard.
12651         * common/gdb_locale.h: Rename include guard.
12652         * common/gdb_assert.h: Rename include guard.
12653         * common/filtered-iterator.h: Rename include guard.
12654         * common/filestuff.h: Rename include guard.
12655         * common/fileio.h: Rename include guard.
12656         * common/environ.h: Rename include guard.
12657         * common/common-utils.h: Rename include guard.
12658         * common/common-types.h: Rename include guard.
12659         * common/common-regcache.h: Rename include guard.
12660         * common/common-inferior.h: Rename include guard.
12661         * common/common-gdbthread.h: Rename include guard.
12662         * common/common-exceptions.h: Rename include guard.
12663         * common/common-defs.h: Rename include guard.
12664         * common/common-debug.h: Rename include guard.
12665         * common/cleanups.h: Rename include guard.
12666         * common/buffer.h: Rename include guard.
12667         * common/btrace-common.h: Rename include guard.
12668         * common/break-common.h: Rename include guard.
12669         * cli/cli-utils.h: Rename include guard.
12670         * cli/cli-style.h: Rename include guard.
12671         * cli/cli-setshow.h: Rename include guard.
12672         * cli/cli-script.h: Rename include guard.
12673         * cli/cli-interp.h: Rename include guard.
12674         * cli/cli-decode.h: Rename include guard.
12675         * cli/cli-cmds.h: Rename include guard.
12676         * charset-list.h: Add include guard.
12677         * buildsym-legacy.h: Rename include guard.
12678         * bfin-tdep.h: Add include guard.
12679         * ax.h: Rename include guard.
12680         * arm-linux-tdep.h: Add include guard.
12681         * arm-fbsd-tdep.h: Add include guard.
12682         * arch/xtensa.h: Rename include guard.
12683         * arch/tic6x.h: Add include guard.
12684         * arch/i386.h: Add include guard.
12685         * arch/arm.h: Rename include guard.
12686         * arch/arm-linux.h: Rename include guard.
12687         * arch/arm-get-next-pcs.h: Rename include guard.
12688         * arch/amd64.h: Add include guard.
12689         * arch/aarch64-insn.h: Rename include guard.
12690         * arch-utils.h: Rename include guard.
12691         * annotate.h: Add include guard.
12692         * amd64-darwin-tdep.h: Rename include guard.
12693         * aarch64-linux-tdep.h: Add include guard.
12694         * aarch64-fbsd-tdep.h: Add include guard.
12695         * aarch32-linux-nat.h: Add include guard.
12696
12697 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12698
12699         * macrotab.c (macro_define_internal): New function that
12700         factorizes macro_define_object_internal and macro_define_function
12701         code.
12702         (macro_define_object_internal): Use macro_define_internal.
12703         (macro_define_function): Likewise.
12704
12705 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12706
12707         * macrocmd.c (extract_identifier): Return
12708         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12709         callers.
12710
12711 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12712
12713         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12714
12715 2019-02-05  Tom Tromey  <tom@tromey.com>
12716
12717         * target.c (target_stack::unpush): Move assertion earlier.
12718
12719 2019-01-30  Tom Tromey  <tom@tromey.com>
12720
12721         PR python/23615:
12722         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12723         (gdbpy_parse_and_eval): Likewise.
12724         * python/python-internal.h (gdbpy_allow_threads): New class.
12725
12726 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12727
12728         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12729         (aarch64_fbsd_fpregmap): Move earlier.
12730         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12731         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12732         instead of individual calls to trad_frame_set_reg_addr.
12733         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12734         earlier.
12735         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12736         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12737         instead of individual calls to trad_frame_set_reg_addr.
12738
12739 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12740
12741         * CONTRIBUTE: Replace contribution list with wiki link.
12742
12743 2019-01-25  Tom Tromey  <tom@tromey.com>
12744
12745         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12746
12747 2019-01-25  Tom Tromey  <tom@tromey.com>
12748
12749         * xtensa-linux-nat.c: Fix common/ includes.
12750         * xml-support.h: Fix common/ includes.
12751         * xml-support.c: Fix common/ includes.
12752         * x86-linux-nat.c: Fix common/ includes.
12753         * windows-nat.c: Fix common/ includes.
12754         * varobj.h: Fix common/ includes.
12755         * varobj.c: Fix common/ includes.
12756         * value.c: Fix common/ includes.
12757         * valops.c: Fix common/ includes.
12758         * utils.c: Fix common/ includes.
12759         * unittests/xml-utils-selftests.c: Fix common/ includes.
12760         * unittests/utils-selftests.c: Fix common/ includes.
12761         * unittests/unpack-selftests.c: Fix common/ includes.
12762         * unittests/tracepoint-selftests.c: Fix common/ includes.
12763         * unittests/style-selftests.c: Fix common/ includes.
12764         * unittests/string_view-selftests.c: Fix common/ includes.
12765         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12766         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12767         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12768         * unittests/rsp-low-selftests.c: Fix common/ includes.
12769         * unittests/parse-connection-spec-selftests.c: Fix common/
12770         includes.
12771         * unittests/optional-selftests.c: Fix common/ includes.
12772         * unittests/offset-type-selftests.c: Fix common/ includes.
12773         * unittests/observable-selftests.c: Fix common/ includes.
12774         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12775         * unittests/memrange-selftests.c: Fix common/ includes.
12776         * unittests/memory-map-selftests.c: Fix common/ includes.
12777         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12778         * unittests/function-view-selftests.c: Fix common/ includes.
12779         * unittests/environ-selftests.c: Fix common/ includes.
12780         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12781         * unittests/common-utils-selftests.c: Fix common/ includes.
12782         * unittests/cli-utils-selftests.c: Fix common/ includes.
12783         * unittests/array-view-selftests.c: Fix common/ includes.
12784         * ui-file.c: Fix common/ includes.
12785         * tui/tui-io.c: Fix common/ includes.
12786         * tracepoint.h: Fix common/ includes.
12787         * tracepoint.c: Fix common/ includes.
12788         * tracefile-tfile.c: Fix common/ includes.
12789         * top.h: Fix common/ includes.
12790         * top.c: Fix common/ includes.
12791         * thread.c: Fix common/ includes.
12792         * target/waitstatus.h: Fix common/ includes.
12793         * target/waitstatus.c: Fix common/ includes.
12794         * target.h: Fix common/ includes.
12795         * target.c: Fix common/ includes.
12796         * target-memory.c: Fix common/ includes.
12797         * target-descriptions.c: Fix common/ includes.
12798         * symtab.h: Fix common/ includes.
12799         * symfile.c: Fix common/ includes.
12800         * stap-probe.c: Fix common/ includes.
12801         * spu-linux-nat.c: Fix common/ includes.
12802         * sparc-nat.c: Fix common/ includes.
12803         * source.c: Fix common/ includes.
12804         * solib.c: Fix common/ includes.
12805         * solib-target.c: Fix common/ includes.
12806         * ser-unix.c: Fix common/ includes.
12807         * ser-tcp.c: Fix common/ includes.
12808         * ser-pipe.c: Fix common/ includes.
12809         * ser-base.c: Fix common/ includes.
12810         * selftest-arch.c: Fix common/ includes.
12811         * s12z-tdep.c: Fix common/ includes.
12812         * rust-exp.y: Fix common/ includes.
12813         * rs6000-aix-tdep.c: Fix common/ includes.
12814         * riscv-tdep.c: Fix common/ includes.
12815         * remote.c: Fix common/ includes.
12816         * remote-notif.h: Fix common/ includes.
12817         * remote-fileio.h: Fix common/ includes.
12818         * remote-fileio.c: Fix common/ includes.
12819         * regcache.h: Fix common/ includes.
12820         * regcache.c: Fix common/ includes.
12821         * record-btrace.c: Fix common/ includes.
12822         * python/python.c: Fix common/ includes.
12823         * python/py-type.c: Fix common/ includes.
12824         * python/py-inferior.c: Fix common/ includes.
12825         * progspace.h: Fix common/ includes.
12826         * producer.c: Fix common/ includes.
12827         * procfs.c: Fix common/ includes.
12828         * proc-api.c: Fix common/ includes.
12829         * printcmd.c: Fix common/ includes.
12830         * ppc-linux-nat.c: Fix common/ includes.
12831         * parser-defs.h: Fix common/ includes.
12832         * osdata.c: Fix common/ includes.
12833         * obsd-nat.c: Fix common/ includes.
12834         * nat/x86-linux.c: Fix common/ includes.
12835         * nat/x86-linux-dregs.c: Fix common/ includes.
12836         * nat/x86-dregs.h: Fix common/ includes.
12837         * nat/x86-dregs.c: Fix common/ includes.
12838         * nat/ppc-linux.c: Fix common/ includes.
12839         * nat/mips-linux-watch.h: Fix common/ includes.
12840         * nat/mips-linux-watch.c: Fix common/ includes.
12841         * nat/linux-waitpid.c: Fix common/ includes.
12842         * nat/linux-ptrace.h: Fix common/ includes.
12843         * nat/linux-ptrace.c: Fix common/ includes.
12844         * nat/linux-procfs.c: Fix common/ includes.
12845         * nat/linux-personality.c: Fix common/ includes.
12846         * nat/linux-osdata.c: Fix common/ includes.
12847         * nat/linux-namespaces.c: Fix common/ includes.
12848         * nat/linux-btrace.h: Fix common/ includes.
12849         * nat/linux-btrace.c: Fix common/ includes.
12850         * nat/fork-inferior.c: Fix common/ includes.
12851         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12852         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12853         * nat/aarch64-linux.c: Fix common/ includes.
12854         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12855         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12856         * namespace.h: Fix common/ includes.
12857         * mips-linux-tdep.c: Fix common/ includes.
12858         * minsyms.c: Fix common/ includes.
12859         * mi/mi-parse.h: Fix common/ includes.
12860         * mi/mi-main.c: Fix common/ includes.
12861         * mi/mi-cmd-env.c: Fix common/ includes.
12862         * memrange.h: Fix common/ includes.
12863         * memattr.c: Fix common/ includes.
12864         * maint.h: Fix common/ includes.
12865         * maint.c: Fix common/ includes.
12866         * main.c: Fix common/ includes.
12867         * machoread.c: Fix common/ includes.
12868         * location.c: Fix common/ includes.
12869         * linux-thread-db.c: Fix common/ includes.
12870         * linux-nat.c: Fix common/ includes.
12871         * linux-fork.c: Fix common/ includes.
12872         * inline-frame.c: Fix common/ includes.
12873         * infrun.c: Fix common/ includes.
12874         * inflow.c: Fix common/ includes.
12875         * inferior.h: Fix common/ includes.
12876         * inferior.c: Fix common/ includes.
12877         * infcmd.c: Fix common/ includes.
12878         * inf-ptrace.c: Fix common/ includes.
12879         * inf-child.c: Fix common/ includes.
12880         * ia64-linux-nat.c: Fix common/ includes.
12881         * i387-tdep.c: Fix common/ includes.
12882         * i386-tdep.c: Fix common/ includes.
12883         * i386-linux-tdep.c: Fix common/ includes.
12884         * i386-linux-nat.c: Fix common/ includes.
12885         * i386-go32-tdep.c: Fix common/ includes.
12886         * i386-fbsd-tdep.c: Fix common/ includes.
12887         * i386-fbsd-nat.c: Fix common/ includes.
12888         * guile/scm-type.c: Fix common/ includes.
12889         * guile/guile.c: Fix common/ includes.
12890         * go32-nat.c: Fix common/ includes.
12891         * gnu-nat.c: Fix common/ includes.
12892         * gdbthread.h: Fix common/ includes.
12893         * gdbarch-selftests.c: Fix common/ includes.
12894         * gdb_usleep.c: Fix common/ includes.
12895         * gdb_select.h: Fix common/ includes.
12896         * gdb_bfd.c: Fix common/ includes.
12897         * gcore.c: Fix common/ includes.
12898         * fork-child.c: Fix common/ includes.
12899         * findvar.c: Fix common/ includes.
12900         * fbsd-nat.c: Fix common/ includes.
12901         * event-top.c: Fix common/ includes.
12902         * event-loop.c: Fix common/ includes.
12903         * dwarf2read.c: Fix common/ includes.
12904         * dwarf2loc.c: Fix common/ includes.
12905         * dwarf2-frame.c: Fix common/ includes.
12906         * dwarf-index-cache.c: Fix common/ includes.
12907         * dtrace-probe.c: Fix common/ includes.
12908         * disasm-selftests.c: Fix common/ includes.
12909         * defs.h: Fix common/ includes.
12910         * csky-tdep.c: Fix common/ includes.
12911         * cp-valprint.c: Fix common/ includes.
12912         * cp-support.h: Fix common/ includes.
12913         * cp-support.c: Fix common/ includes.
12914         * corelow.c: Fix common/ includes.
12915         * completer.h: Fix common/ includes.
12916         * completer.c: Fix common/ includes.
12917         * compile/compile.c: Fix common/ includes.
12918         * compile/compile-loc2c.c: Fix common/ includes.
12919         * compile/compile-cplus-types.c: Fix common/ includes.
12920         * compile/compile-cplus-symbols.c: Fix common/ includes.
12921         * command.h: Fix common/ includes.
12922         * cli/cli-dump.c: Fix common/ includes.
12923         * cli/cli-cmds.c: Fix common/ includes.
12924         * charset.c: Fix common/ includes.
12925         * build-id.c: Fix common/ includes.
12926         * btrace.h: Fix common/ includes.
12927         * btrace.c: Fix common/ includes.
12928         * breakpoint.h: Fix common/ includes.
12929         * breakpoint.c: Fix common/ includes.
12930         * ax.h:
12931         (enum agent_op): Fix common/ includes.
12932         * ax-general.c (struct aop_map): Fix common/ includes.
12933         * ax-gdb.c: Fix common/ includes.
12934         * auxv.c: Fix common/ includes.
12935         * auto-load.c: Fix common/ includes.
12936         * arm-tdep.c: Fix common/ includes.
12937         * arch/riscv.c: Fix common/ includes.
12938         * arch/ppc-linux-common.c: Fix common/ includes.
12939         * arch/i386.c: Fix common/ includes.
12940         * arch/arm.c: Fix common/ includes.
12941         * arch/arm-linux.c: Fix common/ includes.
12942         * arch/arm-get-next-pcs.c: Fix common/ includes.
12943         * arch/amd64.c: Fix common/ includes.
12944         * arch/aarch64.c: Fix common/ includes.
12945         * arch/aarch64-insn.c: Fix common/ includes.
12946         * arch-utils.c: Fix common/ includes.
12947         * amd64-windows-tdep.c: Fix common/ includes.
12948         * amd64-tdep.c: Fix common/ includes.
12949         * amd64-sol2-tdep.c: Fix common/ includes.
12950         * amd64-obsd-tdep.c: Fix common/ includes.
12951         * amd64-nbsd-tdep.c: Fix common/ includes.
12952         * amd64-linux-tdep.c: Fix common/ includes.
12953         * amd64-linux-nat.c: Fix common/ includes.
12954         * amd64-fbsd-tdep.c: Fix common/ includes.
12955         * amd64-fbsd-nat.c: Fix common/ includes.
12956         * amd64-dicos-tdep.c: Fix common/ includes.
12957         * amd64-darwin-tdep.c: Fix common/ includes.
12958         * agent.c: Fix common/ includes.
12959         * ada-lang.h: Fix common/ includes.
12960         * ada-lang.c: Fix common/ includes.
12961         * aarch64-tdep.c: Fix common/ includes.
12962
12963 2019-01-25  Tom Tromey  <tom@tromey.com>
12964
12965         * common/create-version.sh: Use common/version.h.
12966
12967 2019-01-24  Pedro Alves  <palves@redhat.com>
12968
12969         * infrun.c (signal_stop, signal_print, signal_program)
12970         (signal_catch, signal_pass): Now arrays instead of pointers.
12971         (update_signals_program_target, do_target_resume)
12972         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12973         * linux-nat.c (linux_nat_target::pass_signals)
12974         (linux_nat_target::create_inferior, linux_nat_target::attach):
12975         Adjust.
12976         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12977         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12978         * procfs.c (procfs_target::pass_signals): Adjust.
12979         * record-full.c (record_full_target::resume): Adjust.
12980         * remote.c (remote_target::pass_signals)
12981         (remote_target::program_signals): Adjust.
12982         * target-debug.h (target_debug_print_signals): Now takes a
12983         gdb::array_view as parameter.  Adjust.
12984         * target.h (target_ops) <pass_signals, program_signals>: Replace
12985         pointer and length parameters with gdb::array_view.
12986         (target_pass_signals, target_program_signals): Likewise.
12987         * target-delegates.c: Regenerate.
12988
12989 2019-01-24  Pedro Alves  <palves@redhat.com>
12990
12991         * common/forward-scope-exit.h
12992         (forward_scope_exit::forward_scope_exit): Pass arguments to
12993         m_bind_function directly, instead of creating a std::bind and
12994         copying that.
12995
12996 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12997
12998         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12999         for static members.
13000         (pass_in_v_vfp_candidate): Likewise.
13001
13002 2019-01-23  Tom Tromey  <tom@tromey.com>
13003             Pedro Alves  <palves@redhat.com>
13004
13005         * regcache.c (class regcache_invalidator): Remove.
13006         (regcache::raw_write): Use make_scope_exit.
13007
13008 2019-01-23  Tom Tromey  <tom@tromey.com>
13009
13010         * ui-out.h (class ui_out_emit_type): Update comment.
13011
13012 2019-01-23  Tom Tromey  <tom@tromey.com>
13013
13014         * infrun.c (fetch_inferior_event): Update comment.
13015
13016 2019-01-23  Tom Tromey  <tom@tromey.com>
13017             Pedro Alves  <palves@redhat.com>
13018
13019         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
13020         parameter.
13021         (fetch_inferior_event): Use SCOPE_EXIT.
13022
13023
13024 2019-01-23  Tom Tromey  <tom@tromey.com>
13025             Pedro Alves  <palves@redhat.com>
13026
13027         * infrun.c (disable_thread_events): Delete.
13028         (stop_all_threads): Use SCOPE_EXIT.
13029
13030 2019-01-23  Tom Tromey  <tom@tromey.com>
13031             Pedro Alves  <palves@redhat.com>
13032
13033         * symfile.c: Include forward-scope-exit.h.
13034         (clear_symtab_users_cleanup): Replace forward declaration with
13035         a FORWARD_SCOPE_EXIT.
13036         (syms_from_objfile_1): Use the forward_scope_exit and
13037         gdb::optional instead of cleanup_function.
13038         (reread_symbols): Use the forward_scope_exit instead of
13039         cleanup_function.
13040         (clear_symtab_users_cleanup): Remove function.
13041
13042 2019-01-23  Tom Tromey  <tom@tromey.com>
13043             Pedro Alves  <palves@redhat.com>
13044
13045         * linux-nat.c: Include scope-exit.h.
13046         (cleanup_target_stop): Remove.
13047         (linux_nat_target::static_tracepoint_markers_by_strid): Use
13048         SCOPE_EXIT.
13049
13050 2019-01-23  Tom Tromey  <tom@tromey.com>
13051             Pedro Alves  <palves@redhat.com>
13052
13053         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
13054         (call_function_by_hand_dummy): Use SCOPE_EXIT.
13055
13056 2019-01-23  Tom Tromey  <tom@tromey.com>
13057             Andrew Burgess  <andrew.burgess@embecosm.com>
13058             Pedro Alves  <palves@redhat.com>
13059
13060         * infrun.c (fetch_inferior_event): Use scope_exit.
13061         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
13062         * top.c (execute_command): Use scope_exit.
13063         * breakpoint.c (bpstat_do_actions): Use scope_exit.
13064         * utils.c (do_bpstat_clear_actions_cleanup)
13065         (make_bpstat_clear_actions_cleanup): Remove.
13066
13067 2019-01-23  Tom Tromey  <tom@tromey.com>
13068             Pedro Alves  <palves@redhat.com>
13069
13070         * infrun.c: Include "common/scope-exit.h"
13071         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
13072         (wait_for_inferior): Use SCOPE_EXIT.
13073         (fetch_inferior_event): Use scope_exit.
13074
13075 2019-01-23  Tom Tromey  <tom@tromey.com>
13076             Pedro Alves  <palves@redhat.com>
13077
13078         * breakpoint.c (create_breakpoint): Remove cleanup.
13079
13080 2019-01-23  Tom Tromey  <tom@tromey.com>
13081             Andrew Burgess  <andrew.burgess@embecosm.com>
13082             Pedro Alves  <palves@redhat.com>
13083
13084 2019-01-23  Pedro Alves  <palves@redhat.com>
13085
13086         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
13087
13088 2019-01-23  Pedro Alves  <palves@redhat.com>
13089             Andrew Burgess  <andrew.burgess@embecosm.com>
13090
13091         * gdbthread.h: Include "common/forward-scope-exit.h".
13092         (scoped_finish_thread_state): Redefine custom class in terms of
13093         forward_scope_exit.
13094
13095 2019-01-23  Pedro Alves  <palves@redhat.com>
13096             Andrew Burgess  <andrew.burgess@embecosm.com>
13097
13098         * common/forward-scope-exit.h: New file.
13099
13100 2019-01-23  Pedro Alves  <palves@redhat.com>
13101             Andrew Burgess  <andrew.burgess@embecosm.com>
13102             Tom Tromey  <tom@tromey.com>
13103
13104         * common/scope-exit.h: New file.
13105
13106 2019-01-23  Pedro Alves  <palves@redhat.com>
13107
13108         * common/preprocessor.h (ESC): Rename to ...
13109         (ESC_PARENS): ... this.
13110         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
13111         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
13112
13113 2019-01-23  Tom Tromey  <tom@tromey.com>
13114
13115         * language.h (class scoped_switch_to_sym_language_if_auto):
13116         Initialize m_lang in both cases.
13117
13118 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
13119
13120         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
13121         with XCNEW.
13122
13123 2019-01-22  Tom Tromey  <tom@tromey.com>
13124
13125         * corelow.c: Do not include sys/file.h.
13126
13127 2019-01-22  Tom Tromey  <tom@tromey.com>
13128
13129         * tui/tui-wingeneral.h: Include gdb_curses.h.
13130
13131 2019-01-22  Tom Tromey  <tom@tromey.com>
13132
13133         * source-cache.h (class source_cache) <get_source_lines,
13134         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
13135
13136 2019-01-22  Tom Tromey  <tom@tromey.com>
13137
13138         * remote-fileio.h (struct remote_target): Declare.
13139
13140 2019-01-22  Tom Tromey  <tom@tromey.com>
13141
13142         * python/py-arch.c: Do not include py-ref.h.
13143         * python/py-bpevent.c: Do not include py-ref.h.
13144         * python/py-cmd.c: Do not include py-ref.h.
13145         * python/py-continueevent.c: Do not include py-ref.h.
13146         * python/py-event.h: Do not include py-ref.h.
13147         * python/py-evtregistry.c: Do not include py-ref.h.
13148         * python/py-finishbreakpoint.c: Do not include py-ref.h.
13149         * python/py-frame.c: Do not include py-ref.h.
13150         * python/py-framefilter.c: Do not include py-ref.h.
13151         * python/py-function.c: Do not include py-ref.h.
13152         * python/py-infevents.c: Do not include py-ref.h.
13153         * python/py-linetable.c: Do not include py-ref.h.
13154         * python/py-objfile.c: Do not include py-ref.h.
13155         * python/py-param.c: Do not include py-ref.h.
13156         * python/py-prettyprint.c: Do not include py-ref.h.
13157         * python/py-progspace.c: Do not include py-ref.h.
13158         * python/py-symbol.c: Do not include py-ref.h.
13159         * python/py-symtab.c: Do not include py-ref.h.
13160         * python/py-type.c: Do not include py-ref.h.
13161         * python/py-unwind.c: Do not include py-ref.h.
13162         * python/py-utils.c: Do not include py-ref.h.
13163         * python/py-value.c: Do not include py-ref.h.
13164         * python/py-varobj.c: Do not include py-ref.h.
13165         * python/py-xmethods.c: Do not include py-ref.h.
13166         * python/python.c: Do not include py-ref.h.
13167         * varobj.c: Do not include py-ref.h.
13168
13169 2019-01-22  Tom Tromey  <tom@tromey.com>
13170
13171         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
13172         keyword for bcache.
13173
13174 2019-01-22  Tom Tromey  <tom@tromey.com>
13175
13176         * compile/compile-cplus-types.c: Remove a comment by #include.
13177
13178 2019-01-22  Tom Tromey  <tom@tromey.com>
13179
13180         * compile/gcc-c-plugin.h: Include compile-internal.h.
13181
13182 2019-01-22  Tom Tromey  <tom@tromey.com>
13183
13184         * stabsread.c (EXTERN): Do not define.
13185         (symnum, next_symbol_text_func, processing_gcc_compilation)
13186         (within_function, global_sym_chain, global_stabs)
13187         (previous_stab_code, this_object_header_files)
13188         (n_this_object_header_files)
13189         (n_allocated_this_object_header_files): Define.
13190         * stabsread.h (EXTERN): Never define.  Use "extern".
13191
13192 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13193
13194         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
13195         history_value.
13196
13197 2019-01-21  Tom Tromey  <tom@tromey.com>
13198
13199         * ui-out.c: Fix includes.
13200         * tui/tui-source.c: Fix includes.
13201         * target.c: Fix includes.
13202         * remote.c: Fix includes.
13203         * regcache.c: Fix includes.
13204         * python/py-block.c: Fix includes.
13205         * printcmd.c: Fix includes.
13206         * or1k-tdep.c: Fix includes.
13207         * mi/mi-main.c: Fix includes.
13208         * m32r-tdep.c: Fix includes.
13209         * csky-tdep.c: Fix includes.
13210         * compile/compile-cplus-types.c: Fix includes.
13211         * cli/cli-interp.c: Fix includes.
13212
13213 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
13214
13215         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
13216         for padding.
13217
13218 2019-01-16  Tom Tromey  <tom@tromey.com>
13219
13220         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
13221         earlier.
13222         (struct objfile) <msymbols_range>: Move from top level.
13223         <msymbols>: New method.
13224         (class objfile_msymbols): Remove.
13225         * symtab.c (default_collect_symbol_completion_matches_break_on):
13226         Update.
13227         * symmisc.c (dump_msymbols): Update.
13228         * stabsread.c (scan_file_globals): Update.
13229         * objc-lang.c (info_selectors_command, info_classes_command)
13230         (find_methods): Update.
13231         * minsyms.c (find_solib_trampoline_target): Update.
13232         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
13233         * coffread.c (coff_symfile_read): Update.
13234         * ada-lang.c (ada_lookup_simple_minsym)
13235         (ada_collect_symbol_completion_matches): Update.
13236
13237 2019-01-16  Tom Tromey  <tom@tromey.com>
13238
13239         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
13240         type.  Remove no-argument constructor.
13241         <iterator::operator++>: Simplify.
13242         <begin>: Update.
13243         <end>: Use minimal_symbol_count.
13244
13245 2019-01-16  Tom Tromey  <tom@tromey.com>
13246
13247         * objfiles.h (struct objfile) <psymtabs>: New method.
13248         (class objfile_psymtabs): Remove.
13249         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
13250         typedef.
13251         <range>: New method.
13252         (require_partial_symbols): Change return type.
13253         * psymtab.c (require_partial_symbols)
13254         (psym_expand_symtabs_matching): Update.
13255         * mdebugread.c (parse_partial_symbols): Update.
13256         * dbxread.c (dbx_end_psymtab): Update.
13257
13258 2019-01-15  Tom Tromey  <tom@tromey.com>
13259
13260         * symtab.c (lookup_objfile_from_block)
13261         (lookup_symbol_in_objfile_symtabs)
13262         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
13263         (find_line_symtab, info_sources_command)
13264         (default_collect_symbol_completion_matches_break_on)
13265         (make_source_files_completion_list): Update.
13266         * symmisc.c (print_objfile_statistics, dump_objfile)
13267         (maintenance_print_symbols, maintenance_info_symtabs)
13268         (maintenance_check_symtabs, maintenance_info_line_tables):
13269         Update.
13270         * source.c (select_source_symtab)
13271         (forget_cached_source_info_for_objfile): Update.
13272         * objfiles.h (class objfile_compunits): Remove.
13273         (struct objfile) <compunits_range>: New typedef.
13274         (compunits): New method.
13275         * objfiles.c (objfile_relocate1): Update.
13276         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13277         * maint.c (count_symtabs_and_blocks): Update.
13278         * linespec.c (iterate_over_all_matching_symtabs): Update.
13279         * cp-support.c (add_symbol_overload_list_qualified): Update.
13280         * coffread.c (coff_symtab_read): Update.
13281         * ada-lang.c (add_nonlocal_symbols)
13282         (ada_collect_symbol_completion_matches)
13283         (ada_add_global_exceptions): Update.
13284
13285 2019-01-15  Tom Tromey  <tom@tromey.com>
13286
13287         * progspace.h (program_space) <objfiles_safe_range>: New
13288         typedef.
13289         <objfiles_safe>: New method.
13290         * objfiles.h (class all_objfiles_safe): Remove.
13291         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
13292         * jit.c (jit_inferior_exit_hook): Update.
13293
13294 2019-01-17  Tom Tromey  <tom@tromey.com>
13295
13296         * progspace.h (program_space) <objfiles_range>: New typedef.
13297         <objfiles>: New method.
13298         <objfiles_head>: Rename from objfiles.
13299         (object_files): Update.
13300         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
13301         * guile/scm-pretty-print.c
13302         (ppscm_find_pretty_printer_from_objfiles): Update.
13303         * guile/scm-objfile.c (gdbscm_objfiles): Update.
13304         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
13305         Update.
13306         * python/py-progspace.c (pspy_get_objfiles): Update.
13307         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13308         Update.
13309         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13310         (objfpy_lookup_objfile_by_build_id): Update.
13311         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
13312         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13313         Update.
13314         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13315         (expand_symtab_containing_pc, lookup_objfile_from_block)
13316         (lookup_static_symbol, basic_lookup_transparent_type)
13317         (find_pc_sect_compunit_symtab, find_symbol_at_address)
13318         (find_line_symtab, info_sources_command)
13319         (default_collect_symbol_completion_matches_break_on)
13320         (make_source_files_completion_list, find_main_name): Update.
13321         * symmisc.c (print_symbol_bcache_statistics)
13322         (print_objfile_statistics, maintenance_print_symbols)
13323         (maintenance_print_msymbols, maintenance_print_objfiles)
13324         (maintenance_info_symtabs, maintenance_check_symtabs)
13325         (maintenance_expand_symtabs, maintenance_info_line_tables):
13326         Update.
13327         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
13328         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
13329         (map_overlay_command, unmap_overlay_command)
13330         (simple_overlay_update, expand_symtabs_matching)
13331         (map_symbol_filenames): Update.
13332         * symfile-debug.c (set_debug_symfile): Update.
13333         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
13334         Update.
13335         * source.c (select_source_symtab, forget_cached_source_info):
13336         Update.
13337         * solib.c (solib_read_symbols): Update.
13338         * solib-spu.c (append_ocl_sos): Update.
13339         * psymtab.c (maintenance_print_psymbols)
13340         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
13341         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
13342         * printcmd.c (info_symbol_command): Update.
13343         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
13344         Update.
13345         * objfiles.h (class all_objfiles): Remove.
13346         * objfiles.c (have_partial_symbols, have_full_symbols)
13347         (have_minimal_symbols, qsort_cmp, update_section_map)
13348         (shared_objfile_contains_address_p)
13349         (default_iterate_over_objfiles_in_search_order): Update.
13350         * objc-lang.c (info_selectors_command, info_classes_command)
13351         (find_methods): Update.
13352         * minsyms.c (find_solib_trampoline_target): Update.
13353         * maint.c (maintenance_info_sections)
13354         (maintenance_translate_address, count_symtabs_and_blocks):
13355         Update.
13356         * main.c (captured_main_1): Update.
13357         * linux-thread-db.c (try_thread_db_load_from_pdir)
13358         (has_libpthread): Update.
13359         * linespec.c (iterate_over_all_matching_symtabs)
13360         (search_minsyms_for_name): Update.
13361         * jit.c (jit_find_objf_with_entry_addr): Update.
13362         * hppa-tdep.c (find_unwind_entry)
13363         (hppa_lookup_stub_minimal_symbol): Update.
13364         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
13365         Update.
13366         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13367         (elf_gnu_ifunc_resolve_by_got): Update.
13368         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
13369         * dwarf-index-write.c (save_gdb_index_command): Update.
13370         * cp-support.c (add_symbol_overload_list_qualified): Update.
13371         * breakpoint.c (create_overlay_event_breakpoint)
13372         (create_longjmp_master_breakpoint)
13373         (create_std_terminate_master_breakpoint)
13374         (create_exception_master_breakpoint): Update.
13375         * blockframe.c (find_pc_partial_function): Update.
13376         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
13377         (ada_collect_symbol_completion_matches)
13378         (ada_add_global_exceptions): Update.
13379
13380 2019-01-17  Tom Tromey  <tom@tromey.com>
13381
13382         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
13383         declare VEC.
13384         (solib_target_parse_libraries): Change return type.
13385         (library_list_start_segment, library_list_start_section)
13386         (library_list_end_library, library_list_start_library); Update.
13387         (solib_target_free_library_list): Remove.
13388         (solib_target_parse_libraries): Remove cleanup.  Change return
13389         type.
13390         (solib_target_current_sos): Update.
13391
13392 2019-01-17  Tom Tromey  <tromey@bapiya>
13393
13394         * valprint.c: Replace "the the" with "the".
13395         * symtab.c: Replace "the the" with "the".
13396         * solib.c: Replace "the the" with "the".
13397         * solib-dsbt.c: Replace "the the" with "the".
13398         * linespec.c: Replace "the the" with "the".
13399         * dwarf2loc.h: Replace "the the" with "the".
13400         * amd64-windows-tdep.c: Replace "the the" with "the".
13401         * aarch64-tdep.c: Replace "the the" with "the".
13402
13403 2019-01-16  Keith Seitz  <keiths@redhat.com>
13404
13405         PR gdb/23773
13406         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
13407         <builder>: Rename to ..
13408         <m_builder>: ... this and make private.
13409         (dwarf2_cu::get_builder): New method.  Change all users of
13410         `builder' to use this method.
13411         (dwarf2_start_symtab): Move to ...
13412         (dwarf2_cu::start_symtab): ... here.  Update all callers
13413         (setup_type_unit_groups): Move to ...
13414         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
13415         callers.
13416         (dwarf2_cu::reset_builder): New method.
13417         (process_full_compunit, process_full_type_unit): Use
13418         dwarf2_cu::reset_builder.
13419         (follow_die_offset): Record the ancestor CU if it is different
13420         from the followed DIE's CU.
13421         (follow_die_sig_1): Likewise.
13422
13423 2019-01-15  Tom Tromey  <tom@tromey.com>
13424
13425         * remote.c (class remote_state) <buf>: Now a char_vector.
13426         <buf_size>: Remove.
13427         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
13428         parameter.
13429         (remote_target::getpkt_or_notif_sane_1)
13430         (remote_target::getpkt_sane)
13431         (remote_target::getpkt_or_notif_sane): Likewise.
13432         (class remote_target) <putpkt>: New overload.
13433         (remote_target::read_frame): Change type of "buf_p".  Remove
13434         sizeof_p parameter.
13435         (packet_ok): New overload.
13436         (packet_check_result): New overload.
13437         Update all uses.
13438
13439 2019-01-14  Tom Tromey  <tom@tromey.com>
13440
13441         * remote-notif.c (handle_notification, remote_notif_ack)
13442         (remote_notif_parse): Make "buf" const.
13443         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
13444         const.
13445         (remote_notif_parse, remote_notif_ack, handle_notification):
13446         Likewise.
13447         * remote.c (remote_notif_stop_parse): Make "buf" const.
13448         (remote_target::remote_parse_stop_reply): Make "buf" const.
13449         (remote_notif_stop_ack): Make "buf" const.
13450
13451 2019-01-14  Tom Tromey  <tom@tromey.com>
13452
13453         * remote.c (remote_console_output): Make parameter const.
13454
13455 2019-01-14  Tom Tromey  <tom@tromey.com>
13456
13457         * target-debug.h (target_debug_print_signals): Constify.
13458         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
13459         * procfs.c (procfs_target::pass_signals): Update.
13460         * linux-nat.c (linux_nat_target::pass_signals): Update.
13461         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
13462         * target-delegates.c: Rebuild.
13463         * remote.c (remote_target::program_signals): Update.
13464         (remote_target::pass_signals): Update.
13465         * target.c (target_pass_signals): Constify argument.
13466         (target_program_signals): Likewise.
13467         * target.h (struct target_ops) <pass_signals, program_signals>:
13468         Constify argument.
13469         (target_pass_signals, target_program_signals): Constify argument.
13470
13471 2019-01-14  Tom Tromey  <tom@tromey.com>
13472
13473         PR tui/28819:
13474         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
13475
13476 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
13477
13478         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
13479         field.
13480         * rs6000-tdep.c: Include reggroups.h.
13481         (IS_V_ALIAS_PSEUDOREG): Define.
13482         (rs6000_register_name): Return names for the "vX" aliases.
13483         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
13484         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
13485         aliases.  Call default_register_reggroup_p for all other
13486         pseudo-registers.
13487         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
13488         New functions.
13489         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
13490         Handle "vX" aliases.
13491         (v_alias_pseudo_register_collect): New function.
13492         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
13493         (rs6000_gdbarch_init): Initialize "vX" aliases as
13494         pseudo-registers.  Restore registration of
13495         rs6000_pseudo_register_reggroup_p with
13496         set_tdesc_pseudo_register_reggroup_p.
13497
13498 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
13499
13500         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
13501         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
13502         set_gdbarch_num_pseudo_regs.
13503
13504 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13505
13506         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
13507         Remove arg prefixname, add do_set and do_show.
13508         Add member functions set_list and show_list.
13509         * cli/cli-style.c (class cli_style_option): Update accordingly.
13510         (style_set_list): Move to file scope.
13511         (style_show_list): Likewise.
13512         (set_style): Call help_list.
13513         (show_style): Call cmd_show_list.
13514         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
13515         Update to use the new macro.
13516
13517 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
13518
13519         * ada-lang.c (_initialize_ada_language): Expand the help text
13520         for the "catch exception" command.
13521
13522 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13523
13524         * symtab.c (matching_obj_sections): Initialize obj,
13525         declare it closer to its usage.
13526
13527 2019-01-10  Tom Tromey  <tom@tromey.com>
13528
13529         * thread-iter.h (inf_threads_iterator): Use next_iterator.
13530         (basic_inf_threads_range): Remove.
13531         (inf_threads_range, inf_non_exited_threads_range)
13532         (safe_inf_threads_range): Use next_adapter.
13533
13534 2019-01-10  Keith Seitz  <keiths@redhat.com>
13535
13536         PR gdb/23712
13537         PR symtab/23010
13538         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
13539         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
13540
13541 2019-01-10  Keith Seitz  <keiths@redhat.com>
13542
13543         PR gdb/23712
13544         PR symtab/23010
13545         * dictionary.c (pending_to_vector): Remove.
13546         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13547         Remove _1 suffix, replacing functions of the same name.  Update
13548         all callers.
13549         (dict_create_hashed, dict_create_hashed_expandable)
13550         (dict_create_linear, dict_create_linear_expandable, dict_free)
13551         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
13552         Make functions static.
13553
13554 2019-01-10  Keith Seitz  <keiths@redhat.com>
13555
13556         PR gdb/23712
13557         PR symtab/23010
13558         * dictionary.h (struct dictionary): Replace declaration with
13559         multidictionary.
13560         (dict_create_hashed, dict_create_hashed_expandable)
13561         (dict_create_linear, dict_create_linear_expandable)
13562         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13563         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13564         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13565         taking multidictionary argument.
13566         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13567         * block.h (struct block) <dict>: Change to multidictionary
13568         and rename `multidict'.
13569         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13570         symmisc.c: Update all dictionary references to multidictionary.
13571
13572 2019-01-10  Keith Seitz  <keiths@redhat.com>
13573
13574         PR gdb/23712
13575         PR symtab/23010
13576         * dictionary.c: Include unordered_map.
13577         (pending_to_vector): New function.
13578         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13579         Rewrite the non-"_1" functions to take vector instead
13580         of linked list.
13581         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13582         "new" _1 versions of the same name.
13583         (multidictionary): Define.
13584         (std::hash<enum language): New definition.
13585         (collate_pending_symbols_by_language, mdict_create_hashed)
13586         (mdict_create_hashed_expandable, mdict_create_linear)
13587         (mdict_create_linear_expandable, mdict_free)
13588         (find_language_dictionary, create_new_language_dictionary)
13589         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13590         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13591         (mdict_size, mdict_empty): New functions.
13592         * dictionary.h (mdict_iterator): Define.
13593
13594 2019-01-10  Pedro Alves  <palves@redhat.com>
13595
13596         * breakpoint.c (read_uploaded_action)
13597         (create_tracepoint_from_upload): Adjust to use
13598         gdb::unique_xmalloc_ptr.
13599         * ctf.c (ctf_write_uploaded_tp):
13600         (SET_ARRAY_FIELD): Use emplace_back.
13601         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13602         * tracefile-tfile.c (tfile_write_uploaded_tp):
13603         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13604         gdb::unique_xmalloc_ptr.
13605         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13606         at_string, cond_string, cmd_strings>: Replace char pointers
13607         with gdb::unique_xmalloc_ptr.
13608
13609 2019-01-10  Pedro Alves  <palves@redhat.com>
13610
13611         * solib-target.c (library_list_start_library): Don't xstrdup name.
13612
13613 2019-01-10  Pedro Alves  <palves@redhat.com>
13614
13615         * mdebugread.c (parse_partial_symbols): Use
13616         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13617
13618 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13619
13620         * linux-fork.c (scoped_switch_fork_info)
13621         <~scoped_switch_fork_info>: Fix incorrect variable name.
13622
13623 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13624
13625         * linux-fork.c (scoped_switch_fork_info)
13626         <scoped_switch_fork_info>: Make explicit.
13627         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13628
13629 2019-01-10  Tom Tromey  <tom@tromey.com>
13630
13631         * objfiles.h (objfile::reset_psymtabs): Update.
13632         * objfiles.c (objfile::objfile): Update.
13633         * psymtab.h (psymtab_storage::obstack): Update.
13634         (psymtab_storage::m_obstack): Use gdb::optional.
13635         (class psymtab_storage): Update comment.  Remove objfile
13636         parameter.
13637         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13638
13639 2019-01-10  Tom Tromey  <tom@tromey.com>
13640
13641         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13642         <free_psymtabs>: Now private.
13643         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13644         (allocate_psymtab): Use new method.
13645
13646 2019-01-10  Tom Tromey  <tom@tromey.com>
13647
13648         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13649         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13650         * mdebugread.c (parse_partial_symbols): Use
13651         allocate_dependencies.
13652         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13653         allocate_dependencies.
13654         (process_psymtab_comp_unit_reader)
13655         (build_type_psymtab_dependencies): Likewise.
13656         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13657
13658 2019-01-10  Tom Tromey  <tom@tromey.com>
13659
13660         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13661         PSYMBOL_SET_LANGUAGE.
13662         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13663
13664 2019-01-10  Tom Tromey  <tom@tromey.com>
13665
13666         * psymtab.h (psymtab_storage::obstack): New method.
13667         <m_obstack>: Rename from obstack; now private.
13668         * psymtab.c (psymtab_storage): Update.
13669         * dwarf2read.c (create_addrmap_from_index)
13670         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13671         Update.
13672
13673 2019-01-10  Tom Tromey  <tom@tromey.com>
13674
13675         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13676         * objfiles.h (objfile::reset_psymtabs): New method.
13677
13678 2019-01-10  Tom Tromey  <tom@tromey.com>
13679
13680         * symmisc.c (print_symbol_bcache_statistics): Update.
13681         (print_objfile_statistics): Update.
13682         * symfile.c (reread_symbols): Update.
13683         * psymtab.h (class psymtab_storage): New.
13684         * psymtab.c (psymtab_storage): New constructor.
13685         (~psymtab_storage): New destructor.
13686         (require_partial_symbols): Update.
13687         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13688         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13689         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13690         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13691         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13692         (start_psymtab_common, end_psymtab_common)
13693         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13694         (allocate_psymtab): Update.
13695         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13696         Update.
13697         (dump_psymtab_addrmap, maintenance_print_psymbols)
13698         (maintenance_check_psymtabs): Update.
13699         (class objfile_psymtabs): Move to objfiles.h.
13700         * psympriv.h (discard_psymtab): Now inline.
13701         (psymtab_discarder::psymtab_discarder): Update.
13702         (psymtab_discarder::~psymtab_discarder): Update.
13703         (ALL_OBJFILE_PSYMTABS): Rewrite.
13704         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13705         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13706         Remove fields.
13707         <partial_symtabs>: New field.
13708         (class objfile_psymtabs): Move from psymtab.h.  Update.
13709         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13710         psymbol_cache.
13711         (objfile::~objfile): Don't destroy psymbol_cache.
13712         * mdebugread.c (parse_partial_symbols): Update.
13713         * dwarf2read.c (create_addrmap_from_index)
13714         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13715         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13716         (add_partial_subprogram, dwarf2_ranges_read): Update.
13717         * dwarf-index-write.c (write_address_map)
13718         (write_one_signatured_type, recursively_write_psymbols)
13719         (class debug_names, class debug_names, write_psymtabs_to_index):
13720         Update.
13721
13722 2019-01-10  Tom Tromey  <tom@tromey.com>
13723
13724         * symtab.h (SYMBOL_SET_NAMES): Update.
13725         (symbol_set_names): Update.
13726         (MSYMBOL_SET_NAMES): Update.
13727         * symtab.c (symbol_set_names): Change argument to be an
13728         objfile_per_bfd_storage.
13729         * psymtab.c (add_psymbol_to_bcache): Update.
13730         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13731
13732 2019-01-10  Tom Tromey  <tom@tromey.com>
13733
13734         * symtab.c (create_demangled_names_hash): Change argument to be an
13735         objfile_per_bfd_storage.
13736         (symbol_set_names): Update.
13737
13738 2019-01-10  Tom Tromey  <tom@tromey.com>
13739
13740         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13741         init_psymbol_list.
13742         * psymtab.c (init_psymbol_list): Do nothing if already called.
13743         * psympriv.h (init_psymbol_list): Add comment.
13744         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13745         init_psymbol_list.
13746         * dbxread.c (dbx_symfile_read): Unconditionally call
13747         init_psymbol_list.
13748
13749 2019-01-10  Tom Tromey  <tom@tromey.com>
13750
13751         * xcoffread.c (scan_xcoff_symtab): Update.
13752         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13753         "where".
13754         * mdebugread.c (parse_partial_symbols)
13755         (handle_psymbol_enumerators): Update.
13756         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13757         * dbxread.c (read_dbx_symtab): Update.
13758         * psympriv.h (psymbol_placement): New enum.
13759         (add_psymbol_to_list): Update.
13760
13761 2019-01-10  Tom Tromey  <tom@tromey.com>
13762
13763         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13764         static_psymbols parameters.
13765         (scan_xcoff_symtab): Update.
13766         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13767         static_psymbols parameters.
13768         * psympriv.h (start_psymtab_common): Update.
13769         * mdebugread.c (parse_partial_symbols): Update.
13770         * dwarf2read.c (create_partial_symtab): Update.
13771         * dbxread.c (read_dbx_symtab): Update.
13772         (start_psymtab): Remove global_psymbols and static_psymbols
13773         parameters.
13774
13775 2019-01-10  Tom Tromey  <tom@tromey.com>
13776
13777         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13778         * psymtab.c (allocate_psymtab): Add comment.
13779         * psympriv.h (allocate_psymtab): Add comment.
13780         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13781         initializations.
13782         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13783
13784 2019-01-10  Tom Tromey  <tom@tromey.com>
13785
13786         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13787         Don't declare.
13788         * mipsread.c: Include mdebugread.h.
13789         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13790         Declare.
13791         * elfread.c: Include mdebugread.h.
13792
13793 2019-01-09  Tom Tromey  <tom@tromey.com>
13794
13795         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13796         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13797         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13798         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13799         (psym_lookup_symbol, psym_find_last_source_symtab)
13800         (psym_forget_cached_source_info, psym_print_stats)
13801         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13802         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13803         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13804         (psym_find_compunit_symtab_by_address)
13805         (maintenance_print_psymbols, maintenance_info_psymtabs)
13806         (maintenance_check_psymtabs): Use ranged for.
13807         * psymtab.h (class objfile_psymtabs): New.
13808         (require_partial_symbols): Return objfile_psymtabs.
13809         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13810
13811 2019-01-09  Tom Tromey  <tom@tromey.com>
13812
13813         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13814         (find_pc_mapped_section, list_overlays_command)
13815         (map_overlay_command, unmap_overlay_command)
13816         (simple_overlay_update): Use all_objfiles.
13817         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13818         * printcmd.c (info_symbol_command): Use all_objfiles.
13819         * objfiles.h (ALL_OBJSECTIONS): Remove.
13820         * maint.c (maintenance_translate_address): Use all_objfiles.
13821         * gcore.c (gcore_create_callback): Use all_objfiles.
13822         (objfile_find_memory_regions): Likewise.
13823
13824 2019-01-09  Tom Tromey  <tom@tromey.com>
13825
13826         * symtab.c (find_line_symtab, info_sources_command)
13827         (make_source_files_completion_list): Use objfile_compunits.
13828         * source.c (select_source_symtab): Use objfile_compunits.
13829         * objfiles.h (struct objfile): Update comment.
13830         (ALL_OBJFILES): Remove.
13831         (ALL_FILETABS): Remove.
13832         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13833         objfile_compunits.
13834
13835 2019-01-09  Tom Tromey  <tom@tromey.com>
13836
13837         * symmisc.c (print_objfile_statistics, dump_objfile)
13838         (maintenance_print_symbols): Use compunit_filetabs.
13839         * source.c (forget_cached_source_info_for_objfile): Use
13840         compunit_filetabs.
13841         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13842         (ALL_FILETABS): Use compunit_filetabs.
13843         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13844         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13845
13846 2019-01-09  Tom Tromey  <tom@tromey.com>
13847
13848         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13849         (compunit_filetabs): New.
13850         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13851         compunit_filetabs.
13852         (info_sources_command, make_source_files_completion_list): Remove
13853         declaration.
13854         * symmisc.c (print_objfile_statistics, dump_objfile)
13855         (maintenance_print_symbols): Remove declaration.
13856         (maintenance_info_symtabs): Use compunit_filetabs.
13857         (maintenance_info_line_tables): Likewise.
13858         * source.c (select_source_symtab): Change local variable name.
13859         (forget_cached_source_info_for_objfile): Remove declaration.
13860         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13861         * objfiles.c (objfile_relocate1): Remove declaration.
13862         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13863         declaration.
13864         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13865         * coffread.c (coff_symtab_read): Remove declaration.
13866         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13867         compunit_filetabs.
13868
13869 2019-01-09  Tom Tromey  <tom@tromey.com>
13870
13871         * symtab.c (lookup_objfile_from_block)
13872         (find_pc_sect_compunit_symtab, search_symbols)
13873         (default_collect_symbol_completion_matches_break_on): Use
13874         objfile_compunits.
13875         * objfiles.h (ALL_COMPUNITS): Remove.
13876         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13877         * cp-support.c (add_symbol_overload_list_qualified): Use
13878         objfile_compunits.
13879         * ada-lang.c (ada_collect_symbol_completion_matches)
13880         (ada_add_global_exceptions): Use objfile_compunits.
13881
13882 2019-01-09  Tom Tromey  <tom@tromey.com>
13883
13884         * source.c (select_source_symtab)
13885         (forget_cached_source_info_for_objfile): Remove declaration.
13886         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13887         declaration.
13888         * maint.c (count_symtabs_and_blocks): Remove declaration.
13889         * cp-support.c (add_symbol_overload_list_qualified): Remove
13890         declaration.
13891         * coffread.c (coff_symtab_read): Remove declaration.
13892         * symtab.c (lookup_symbol_in_objfile_symtabs)
13893         (basic_lookup_transparent_type_1): Use objfile_compunits.
13894         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13895         (info_sources_command, search_symbols)
13896         (default_collect_symbol_completion_matches_break_on)
13897         (make_source_files_completion_list): Remove declaration.
13898         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13899         (ada_collect_symbol_completion_matches)
13900         (ada_add_global_exceptions): Remove declaration.
13901         * linespec.c (iterate_over_all_matching_symtabs): Use
13902         objfile_compunits.
13903         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13904         (class objfile_compunits): New.
13905         (ALL_COMPUNITS): Use objfile_compunits.
13906         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13907         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13908         objfile_compunits.
13909         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13910
13911 2019-01-09  Tom Tromey  <tom@tromey.com>
13912
13913         * symtab.c (search_symbols)
13914         (default_collect_symbol_completion_matches_break_on): Use
13915         objfile_msymbols.
13916         * ada-lang.c (ada_lookup_simple_minsym)
13917         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13918         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13919         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13920         objfile_msymbols.
13921         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13922         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13923         * objc-lang.c (find_methods): Use objfile_msymbols.
13924         (info_selectors_command, info_classes_command): Likewise.
13925         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13926         * objfiles.h (class objfile_msymbols): New.
13927         (ALL_OBJFILE_MSYMBOLS): Remove.
13928         (ALL_MSYMBOLS): Remove.
13929
13930 2019-01-09  Tom Tromey  <tom@tromey.com>
13931
13932         * common/next-iterator.h (next_adapter): Add Iterator template
13933         parameter.
13934         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13935         (class all_objfiles_safe): New.
13936         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13937         * objfiles.c (put_objfile_before): Update comment.
13938         (add_separate_debug_objfile): Likewise.
13939         (free_all_objfiles): Use all_objfiles_safe.
13940         (objfile_purge_solibs): Likewise.
13941
13942 2019-01-09  Tom Tromey  <tom@tromey.com>
13943
13944         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13945         (expand_symtab_containing_pc, lookup_static_symbol)
13946         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13947         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13948         all_objfiles.
13949         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13950         * breakpoint.c (create_overlay_event_breakpoint)
13951         (create_longjmp_master_breakpoint)
13952         (create_std_terminate_master_breakpoint)
13953         (create_exception_master_breakpoint): Use all_objfiles.
13954         * linux-thread-db.c (try_thread_db_load_from_pdir)
13955         (has_libpthread): Use all_objfiles.
13956         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13957         * linespec.c (iterate_over_all_matching_symtabs)
13958         (search_minsyms_for_name): Use all_objfiles.
13959         * maint.c (maintenance_info_sections): Use all_objfiles.
13960         * main.c (captured_main_1): Use all_objfiles.
13961         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13962         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13963         * guile/scm-pretty-print.c
13964         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13965         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13966         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13967         (maintenance_print_msymbols): Use all_objfiles.
13968         * source.c (select_source_symtab): Use all_objfiles.
13969         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13970         * symfile.c (remove_symbol_file_command)
13971         (expand_symtabs_matching, map_symbol_filenames): Use
13972         all_objfiles.
13973         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13974         all_objfiles.
13975         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13976         * objc-lang.c (find_methods): Use all_objfiles.
13977         * objfiles.c (have_partial_symbols, have_full_symbols)
13978         (have_minimal_symbols, qsort_cmp)
13979         (default_iterate_over_objfiles_in_search_order): Use
13980         all_objfiles.
13981         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13982         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13983         (maintenance_check_psymtabs): Use all_objfiles.
13984         (ALL_PSYMTABS): Remove.
13985         * compile/compile-object-run.c (do_module_cleanup): Use
13986         all_objfiles.
13987         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13988         * cp-support.c (add_symbol_overload_list_qualified): Use
13989         all_objfiles.
13990         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13991         Use all_objfiles.
13992         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13993         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13994         all_objfiles.
13995         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13996         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13997         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13998         Uses all_objfiles.
13999         * solib.c (solib_read_symbols): Use all_objfiles
14000
14001 2019-01-09  Tom Tromey  <tom@tromey.com>
14002
14003         * probe.c (parse_probes_in_pspace): Use all_objfiles.
14004         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
14005         all_objfiles.
14006         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
14007         * symmisc.c (print_symbol_bcache_statistics)
14008         (print_objfile_statistics, maintenance_print_objfiles)
14009         (maintenance_info_symtabs, maintenance_check_symtabs)
14010         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
14011         all_objfiles.
14012         * source.c (forget_cached_source_info): Use all_objfiles.
14013         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
14014         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
14015         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
14016         * objfiles.c (update_section_map): Use all_objfiles.
14017         (shared_objfile_contains_address_p): Likewise.
14018         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
14019         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
14020
14021 2019-01-09  Tom Tromey  <tom@tromey.com>
14022
14023         * common/next-iterator.h: New file.
14024         * objfiles.h (class all_objfiles): New.
14025         (struct objfile_iterator): New.
14026
14027 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14028
14029         * NEWS: Move the description of the changed "frame", "select-frame",
14030          and "info frame" commands to the Changed commands section.
14031
14032 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
14033
14034         * gdbtypes.c (check_stub_method_group): Remove handling of old
14035         mangling schemes.
14036         * linespec.c (find_methods): Likewise.
14037         * stabsread.c (read_member_functions): Likewise.
14038         * valops.c (search_struct_method): Likewise.
14039         (value_struct_elt_for_reference): Likewise.
14040         * NEWS: Mention this change.
14041
14042 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
14043
14044         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
14045         print_source_lines.
14046         * source.c (print_source_lines_base): Update line number check.
14047         (print_source_lines): New function.
14048         (source_lines_range::source_lines_range): New function.
14049         * source.h (class source_lines_range): New class.
14050         (print_source_lines): New declaration.
14051
14052 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14053
14054         * linespec.c (linespec_state_destructor): Free self->canonical_names.
14055
14056 2019-01-08  Tom Tromey  <tom@tromey.com>
14057             Simon Marchi  <simon.marchi@ericsson.com>
14058
14059         PR gdb/24060
14060         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
14061         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
14062         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14063         * f-exp.y (DOLLAR_VARIABLE): Likewise.
14064         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
14065         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
14066
14067 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14068
14069         * source.c (select_source_symtab): Move header comment to
14070         declaration in source.h.
14071         (forget_cached_source_info_for_objfile): Likewise.
14072         (forget_cached_source_info): Likewise.
14073         (identify_source_line): Likewise.
14074         * source.h (identify_source_line): Move declaration from symtab.h
14075         and add comment from source.c
14076         (print_source_lines): Likewise.
14077         (forget_cached_source_info_for_objfile): Likewise.
14078         (forget_cached_source_info): Likewise.
14079         (select_source_symtab): Likewise.
14080         (enum print_source_lines_flag): Move definition from symtab.h.
14081         * symtab.h (identify_source_line): Move declaration to source.h.
14082         (print_source_lines): Likewise.
14083         (forget_cached_source_info_for_objfile): Likewise.
14084         (forget_cached_source_info): Likewise.
14085         (select_source_symtab): Likewise.
14086         (enum print_source_lines_flag): Move definition to source.h.
14087         * tui/tui-hooks.c: Add 'source.h' include.
14088
14089 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14090
14091         * source.c (print_source_lines_base): Handle requests to print
14092         reverse line number sequences, and guard against empty lines
14093         string.
14094
14095 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
14096
14097         * source.c (print_source_lines_base): Fix skip of '\r' if next
14098         character is '\n'.
14099
14100 2019-01-06  Tom Tromey  <tom@tromey.com>
14101
14102         * c-exp.y (struct c_parse_state) <macro_original_text,
14103         expansion_obstack>: New member.
14104         (macro_original_text, expansion_obstack): Remove globals.
14105         (scan_macro_expansion, scanning_macro_expansion)
14106         (finished_macro_expansion): Update.
14107         (scan_macro_cleanup): Remove.
14108         (yylex, c_parse): Update.
14109
14110 2019-01-06  Tom Tromey  <tom@tromey.com>
14111
14112         * c-exp.y (struct c_parse_state) <strings>: New member.
14113         (operator_stoken): Update.
14114
14115 2019-01-06  Tom Tromey  <tom@tromey.com>
14116
14117         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
14118         (union type_stack_elt) <typelist_val>: Now a pointer to
14119         std::vector.
14120         (type_stack_cleanup): Don't declare.
14121         (push_typelist): Update.
14122         * parse.c (pop_typelist): Return a std::vector.
14123         (push_typelist): Take a std::vector.
14124         (follow_types): Update.  Do not free args.
14125         (type_stack_cleanup): Remove.
14126         * c-exp.y (struct c_parse_state): New.
14127         (cpstate): New global.
14128         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
14129         (nonempty_typelist): Update.
14130         (func_mod): Create a new vector.
14131         (c_parse): Create a c_parse_state.
14132         (check_parameter_typelist): Do not delete params.
14133         (function_method): Update.  Do not delete type_list.
14134
14135 2019-01-06  Tom Tromey  <tom@tromey.com>
14136
14137         PR gdb/28155:
14138         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
14139         check_typedef.
14140         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
14141         (print_return_value): Likewise.
14142
14143 2019-01-05  Tom Tromey  <tom@tromey.com>
14144
14145         * contrib/cleanup_check.py: Remove.
14146         * contrib/gcc-with-excheck: Remove.
14147         * contrib/exsummary.py: Remove.
14148         * contrib/excheck.py: Remove.
14149
14150 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
14151
14152         * thread.c (delete_thread_1): Add gdb_assert that THR is not
14153         NULL. Initialize tpprev to NULL instead of assigning it
14154         to NULL on the next statement.
14155         * windows-nat.c (windows_delete_thread): Remove check for
14156         main_thread_id before printing thread exit notifications.
14157         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
14158         Remove thread ID check against main_thread_id.
14159         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
14160         windows_delete_thread.
14161         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
14162
14163 2019-01-04  Tom Tromey  <tom@tromey.com>
14164
14165         * compile/compile.c (_initialize_compile): Use upper case for
14166         metasyntactic variables.
14167         * symmisc.c (_initialize_symmisc): Use upper case for
14168         metasyntactic variables.
14169         * psymtab.c (_initialize_psymtab): Use upper case for
14170         metasyntactic variables.
14171         * demangle.c (demangle_command): Use upper case for metasyntactic
14172         variables.
14173         (_initialize_demangler): Likewise.
14174         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
14175         variables.
14176
14177 2019-01-03  Tom Tromey  <tom@tromey.com>
14178
14179         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
14180
14181 2019-01-03  Tom Tromey  <tom@tromey.com>
14182
14183         * python/py-symtab.c (salpy_str): Update.
14184         (struct salpy_sal_object) <symtab>: Now a PyObject.
14185         (salpy_dealloc): Update.
14186         (del_objfile_sal): Use gdbpy_ref.
14187
14188 2019-01-03  Tom Tromey  <tom@tromey.com>
14189
14190         * python/py-type.c (convert_field): Use new_reference.  Return
14191         gdbpy_ref.
14192         (make_fielditem): Return gdbpy_ref.
14193         (typy_fields): Update.
14194         (typy_getitem): Update.
14195         (field_name): Return gdbpy_ref.  Use new_reference.
14196         (typy_iterator_iternext): Update.
14197
14198 2019-01-03  Tom Tromey  <tom@tromey.com>
14199
14200         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
14201
14202 2019-01-03  Tom Tromey  <tom@tromey.com>
14203
14204         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
14205         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
14206         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
14207         (pspy_set_frame_filters, pspy_set_frame_unwinders)
14208         (pspy_set_type_printers): Likewise.
14209         * python/py-function.c (fnpy_init): Use gdbpy_ref.
14210         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
14211         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
14212         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
14213         (objfpy_set_type_printers): Likewise.
14214
14215 2019-01-03  Tom Tromey  <tom@tromey.com>
14216
14217         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
14218         (gdbpy_print_stack): Use gdbpy_err_fetch.
14219         * python/python-internal.h (class gdbpy_err_fetch): New class.
14220         (class gdbpy_enter) <m_error_type, m_error_value,
14221         m_error_traceback>: Remove.
14222         <m_error>: New member.
14223         (gdbpy_exception_to_string): Don't declare.
14224         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
14225         * python/py-value.c (convert_value_from_python): Use
14226         gdbpy_err_fetch.
14227         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
14228         gdbpy_exception_to_string.
14229         (gdbpy_handle_exception): Use gdbpy_err_fetch.
14230         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
14231         gdbpy_err_fetch.
14232
14233 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14234
14235         * linux-nat.c (delete_lwp_cleanup): Delete.
14236         (struct lwp_deleter): New struct.
14237         (lwp_info_up): New typedef.
14238         (linux_nat_target::follow_fork): Delete cleanup, and make use of
14239         lwp_info_up.
14240
14241 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14242
14243         * linux-fork.c (class scoped_switch_fork_info): New class.
14244         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
14245
14246 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14247
14248         * valops.c (find_overload_match): Remove use of null_cleanup, and
14249         calls to do_cleanups.
14250
14251 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14252
14253         * compile/compile-cplus-types.c
14254         (compile_cplus_instance::decl_name): Handle changes to
14255         cp_func_name.
14256         * cp-support.c (cp_func_name): Update header comment, update
14257         return type.
14258         * cp-support.h (cp_func_name): Update return type in declaration.
14259         * valops.c (find_overload_match): Move temp_func local to top
14260         level of function and change its type.  Use temp_func to hold and
14261         delete temporary string obtained from cp_func_name.
14262
14263 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
14264
14265         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
14266         gdb::char_vector, remove cleanup, and update uses of `msg`.
14267
14268 2019-01-03  Jim Wilson  <jimw@sifive.com>
14269
14270         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
14271
14272 2019-01-02  Tom Tromey  <tom@tromey.com>
14273
14274         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
14275         (tdesc_parse_xml): Remove cleanups.
14276         * target-descriptions.h (make_cleanup_free_target_description):
14277         Don't declare.
14278         (target_desc_deleter): New struct.
14279         (target_desc_up): New typedef.
14280         * target-descriptions.c (target_desc_deleter::operator()): Rename
14281         from free_target_description.
14282         (make_cleanup_free_target_description): Remove.
14283
14284 2019-01-02  Tom Tromey  <tom@tromey.com>
14285
14286         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
14287         constructor, destructor.
14288         (linespec_parser): Remove typedef.
14289         (~linespec_parser): Rename from linespec_parser_delete.
14290         (linespec_lex_to_end, linespec_complete_label)
14291         (linespec_complete): Update.
14292         (decode_line_full): Remove cleanups.
14293         (decode_line_1): Update.
14294
14295 2019-01-02  Tom Tromey  <tom@tromey.com>
14296
14297         * python/python-internal.h (inferior_to_inferior_object): Change
14298         return type.
14299         * python/py-exitedevent.c (create_exited_event_object): Update.
14300         * python/py-inferior.c (inferior_to_inferior_object): Return
14301         gdbpy_ref.
14302         (python_new_inferior, python_inferior_deleted)
14303         (thread_to_thread_object, delete_thread_object)
14304         (build_inferior_list, gdbpy_selected_inferior): Update.
14305         * python/py-infthread.c (create_thread_object): Update.  Also fail
14306         if inferior_to_inferior_object fails.
14307
14308 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
14309
14310         * inferior.h (class inferior) <displaced_step_state>: New field.
14311         * infrun.h (struct displaced_step_state): Move here from
14312         infrun.c.  Initialize fields, add constructor.
14313         <inf>: Remove field.
14314         <reset>: New method.
14315         * infrun.c (struct displaced_step_inferior_state): Move to
14316         infrun.h.
14317         (displaced_step_inferior_states): Remove.
14318         (get_displaced_stepping_state): Adust.
14319         (displaced_step_in_progress_any_inferior): Adjust.
14320         (displaced_step_in_progress_thread): Adjust.
14321         (displaced_step_in_progress): Adjust.
14322         (add_displaced_stepping_state): Remove.
14323         (get_displaced_step_closure_by_addr): Adjust.
14324         (remove_displaced_stepping_state): Remove.
14325         (infrun_inferior_exit): Call displaced_step_state.reset.
14326         (use_displaced_stepping): Don't check for NULL.
14327         (displaced_step_prepare_throw): Call
14328         get_displaced_stepping_state.
14329         (displaced_step_fixup): Don't check for NULL.
14330         (prepare_for_detach): Don't check for NULL.
14331
14332 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14333
14334         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
14335          in case of call that did not complete.
14336
14337 2019-01-02  Andrey Utkin  <autkin@undo.io>
14338
14339         * symfile.c (find_separate_debug_file): Fix search of debug files for
14340         remote debuggee.
14341
14342 2019-01-02  Tom Tromey  <tom@tromey.com>
14343
14344         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
14345         indentation.
14346         * python/py-frame.c (frapy_older): Remove cast.
14347         (frapy_newer): Likewise.
14348         * python/py-breakpoint.c (local_setattro): Remove cast.
14349         * python/py-arch.c (archpy_name): Remove local variable.
14350         * python/py-type.c (gdbpy_lookup_type): Remove cast.
14351
14352 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
14353
14354         * unittests/basic_string_view/element_access/char/empty.cc:
14355         Fix year range in copyright header.
14356
14357 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
14358
14359         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
14360         Delete.
14361         <operator==>: Update with for removed field.
14362         <hash>: Likewise.
14363         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
14364         <isa_features>: ...this.
14365         <abi_features>: New field.
14366         (riscv_isa_flen): Update comment.
14367         (riscv_abi_xlen): New declaration.
14368         (riscv_abi_flen): New declaration.
14369         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
14370         isa_features.
14371         (riscv_abi_xlen): New function.
14372         (riscv_isa_flen): Update to get answer from isa_features.
14373         (riscv_abi_flen): New function.
14374         (riscv_has_fp_abi): Update to get answer from abi_features.
14375         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
14376         xlen and flen.
14377         (riscv_call_info) <xlen, flen>: Update comment.
14378         (riscv_call_arg_struct): Remove invalid assertions
14379         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
14380         is removed.
14381         (riscv_gdbarch_init): Gather isa features and abi features
14382         separately, ensure both match on the gdbarch when reusing an old
14383         gdbarch.  Relax an error check to allow 32-bit abi float to run on
14384         a target with 64-bit float hardware.
14385
14386 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14387
14388         * source.c (search_command_helper): Stop reverse search
14389         when line 1 has been searched.
14390
14391 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14392
14393         * record-full.c (record_full_base_target::close): Rewrite
14394         record_full_core_buf_list free logic.
14395
14396 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14397
14398         * break-catch-syscall.c (print_one_catch_syscall): xfree
14399         the last text.
14400
14401 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14402
14403         * top.c (print_gdb_version): Update Copyright year in version
14404         message.
14405
14406 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
14407
14408         Update copyright year range in all GDB files.
14409
14410 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
14411
14412         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
14413
14414 For older changes see ChangeLog-2018.
14415 \f
14416 Local Variables:
14417 mode: change-log
14418 left-margin: 8
14419 fill-column: 74
14420 version-control: never
14421 coding: utf-8
14422 End:
14423