gdb/ChangeLog

   1 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * f-lang.c (build_fortran_types): Change name of void type to
   4         lower case.
   5         * f-typeprint.c (f_type_print_base): Print the name of the void
   6         type, rather than a fixed string.
   7         * f-valprint.c (f_decorations): Use lower case void string.
   8
   9 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  10             Chris January  <chris.january@arm.com>
  11
  12         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  13         types for Fortran.
  14
  15 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  16             Chris January  <chris.january@arm.com>
  17             David Lecomber  <david.lecomber@arm.com>
  18
  19         * f-exp.y (BINOP_INTRINSIC): New token.
  20         (exp): New parser rule handling BINOP_INTRINSIC.
  21         (f77_keywords): Add new builtin procedures.
  22         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  23         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  24         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  25         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  26         (print_unop_subexp_f): New function.
  27         (print_binop_subexp_f): New function.
  28         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  29         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  30         (dump_subexp_body_f): Likewise.
  31         (operator_check_f): Likewise.
  32         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  33         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
  34
  35 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
  38         UNOP_KIND.
  39         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
  40         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
  41         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
  42         (operator_length_f): New fuction.
  43         (print_subexp_f): New function.
  44         (op_name_f): New function.
  45         (dump_subexp_body_f): New function.
  46         (operator_check_f): New function.
  47         (exp_descriptor_f): Replace standard expression handling functions
  48         with new functions.
  49         * gdb/fortran-operator.def: New file.
  50         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
  51         * gdb/std-operator.def: Remove UNOP_KIND.
  52
  53 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  54
  55         * std-operator.def: Remove unbalanced, stray double quote
  56         character.
  57
  58 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  59             Chris January  <chris.january@arm.com>
  60             Daniel Everett  <daniel.everett@arm.com>
  61             Nick Forrington  <nick.forrington@arm.com>
  62             Richard Bunt  <richard.bunt@arm.com>
  63
  64         * cp-valprint.c (cp_print_value_fields): Allow an additional level
  65         of depth when printing anonymous structs or unions.
  66         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
  67         Don't print either the top-level value, or the children if the
  68         max-depth is exceeded.
  69         (ppscm_print_children): When printing the key of a map, allow one
  70         extra level of depth.
  71         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
  72         print either the top-level value, or the children if the max-depth
  73         is exceeded.
  74         (print_children): When printing the key of a map, allow one extra
  75         level of depth.
  76         * python/py-value.c (valpy_format_string): Add max_depth keyword.
  77         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
  78         (user_print_options): Initialise max_depth field.
  79         (val_print_scalar_or_string_type_p): New function.
  80         (val_print): Check to see if the max depth has been reached.
  81         (val_print_check_max_depth): Define new function.
  82         (show_print_max_depth): New function.
  83         (_initialize_valprint): Add 'print max-depth' option.
  84         * valprint.h (struct value_print_options) <max_depth>: New field.
  85         (val_print_check_max_depth): Declare new function.
  86         * NEWS: Document new feature.
  87
  88 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  89
  90         * ada-lang.c (ada_language_defn): Initialise new field.
  91         * c-lang.c (c_is_string_type_p): New function.
  92         (c_language_defn): Initialise new field.
  93         (cplus_language_defn): Initialise new field.
  94         (asm_language_defn): Initialise new field.
  95         (minimal_language_defn): Initialise new field.
  96         * c-lang.h (c_is_string_type_p): Declare new function.
  97         * d-lang.c (d_language_defn): Initialise new field.
  98         * f-lang.c (f_is_string_type_p): New function.
  99         (f_language_defn): Initialise new field.
 100         * go-lang.c (go_is_string_type_p): New function.
 101         (go_language_defn): Initialise new field.
 102         * language.c (default_is_string_type_p): New function.
 103         (unknown_language_defn): Initialise new field.
 104         (auto_language_defn): Initialise new field.
 105         * language.h (struct language_defn) <la_is_string_type_p>: New
 106         member variable.
 107         (default_is_string_type_p): Declare new function.
 108         * m2-lang.c (m2_language_defn): Initialise new field.
 109         * objc-lang.c (objc_language_defn): Initialise new field.
 110         * opencl-lang.c (opencl_language_defn): Initialise new field.
 111         * p-lang.c (pascal_is_string_type_p): New function.
 112         (pascal_language_defn): Initialise new field.
 113         * rust-lang.c (rust_is_string_type_p): New function.
 114         (rust_language_defn): Initialise new field.
 115
 116 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 119         New field.
 120         * ada-lang.c (ada_language_defn): Initialise new field.
 121         * c-lang.c (c_language_defn): Likewise.
 122         (cplus_language_defn): Likewise.
 123         (asm_language_defn): Likewise.
 124         (minimal_language_defn): Likewise.
 125         * d-lang.c (d_language_defn): Likewise.
 126         * f-lang.c (f_language_defn): Likewise.
 127         * go-lang.c (go_language_defn): Likewise.
 128         * language.c (unknown_language_defn): Likewise.
 129         (auto_language_defn): Likewise.
 130         * m2-lang.c (m2_language_defn): Likewise.
 131         * objc-lang.c (objc_language_defn): Likewise.
 132         * opencl-lang.c (opencl_language_defn): Likewise.
 133         * p-lang.c (pascal_language_defn): Likewise.
 134         * rust-lang.c (rust_language_defn): Likewise.
 135
 136 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 137
 138         * ada-lang.c (ada_is_character_type): Change return type to bool.
 139         (ada_is_string_type): Likewise.
 140         * ada-lang.h (ada_is_character_type): Update declaration
 141         (ada_is_string_type): Likewise.
 142
 143 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 144
 145         Support style in 'frame|thread apply'
 146
 147         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 148         * record.c (record_start, record_stop): Update callers of
 149         execute_command_to_string with false.
 150         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 151         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 152         methods.
 153         (class string_file): New constructor with term_out parameter.
 154         Override methods term_out and can_emit_style_escape.  New member
 155         term_out.
 156         (class stdio_file): Override can_emit_style_escape.
 157         (class tee_file): Override term_out and can_emit_style_escape.
 158         * utils.h (can_emit_style_escape): Remove.
 159         * utils.c (can_emit_style_escape): Likewise.
 160         Update all callers of can_emit_style_escape (SOMESTREAM) to
 161         SOMESTREAM->can_emit_style_escape.
 162         * source-cache.c (source_cache::get_source_lines): Likewise.
 163         * stack.c (frame_apply_command_count): Call execute_command_to_string
 164         passing the term_out characteristic of the current gdb_stdout.
 165         * thread.c (thr_try_catch_cmd): Likewise.
 166         * top.c (execute_command_to_string): pass term_out parameter
 167         to construct the string_file for the command output.
 168         * ui-file.c (term_cli_styling): New function (most code moved
 169         from utils.c can_emit_style_escape).
 170         (string_file::string_file, string_file::can_emit_style_escape,
 171         stdio_file::can_emit_style_escape, tee_file::term_out,
 172         tee_file::can_emit_style_escape): New functions.
 173
 174 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 175
 176         * NEWS: Mention the new set|show may-call-functions.
 177         * infcall.c (may_call_functions_p): New variable.
 178         (show_may_call_functions_p): New function.
 179         (call_function_by_hand_dummy): Throws an error if not
 180         may-call-functions.
 181         (_initialize_infcall): Call add_setshow_boolean_cmd for
 182         may-call-functions.
 183
 184 2019-04-25  Keith Seitz  <keiths@redhat.com>
 185
 186         PR c++/24367
 187         * cp-support.c (inspect_type): Don't attempt substitutions
 188         of symbol with the same name.
 189
 190 2019-04-25  Tom Tromey  <tromey@adacore.com>
 191
 192         PR gdb/24475:
 193         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 194         static.
 195
 196 2019-04-25  Tom Tromey  <tromey@adacore.com>
 197
 198         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 199         rvalue reference.
 200         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 201         (gdb_xml_parser::parse): Use std::move.
 202         * python/python-internal.h (gdbpy_convert_exception): Take a const
 203         reference.
 204         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 205         std::move.
 206         * python/py-utils.c (gdbpy_convert_exception): Take a const
 207         reference.
 208         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 209         Use std::move.
 210         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 211         Use std::move.
 212         * mi/mi-main.c (mi_print_exception): Take a const reference.
 213         * main.c (handle_command_errors): Take a const reference.
 214         * linespec.c (parse_linespec): Use std::move.
 215         * infcall.c (run_inferior_call): Use std::move.
 216         (call_function_by_hand_dummy): Use std::move.
 217         * exec.c (try_open_exec_file): Use std::move.
 218         * exceptions.h (exception_print, exception_fprintf)
 219         (exception_print_same): Update.
 220         * exceptions.c (print_exception, exception_print)
 221         (exception_fprintf, exception_print_same): Change parameters to
 222         const reference.
 223         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 224         * common/new-op.c: Use std::move.
 225         * common/common-exceptions.h (struct gdb_exception): Add move
 226         constructor.
 227         (struct gdb_exception_error, struct gdb_exception_quit, struct
 228         gdb_quit_bad_alloc): Change constructor to move constructor.
 229         (throw_exception): Change parameter to rvalue reference.
 230         * common/common-exceptions.c (throw_exception): Take rvalue
 231         reference.
 232         * cli/cli-interp.c (safe_execute_command): Use std::move.
 233         * breakpoint.c (insert_bp_location, location_to_sals): Use
 234         std::move.
 235
 236 2019-04-25  Tom Tromey  <tromey@adacore.com>
 237
 238         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 239         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 240         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 241         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 242         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 243         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 244         guile/scm-value.c: Use unpack.
 245         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 246         gdbscm_gdb_exception.
 247         (gdbscm_throw_gdb_exception): Likewise.
 248         (struct gdbscm_gdb_exception): New.
 249         (unpack): New function.
 250         (gdbscm_wrap): Use unpack.
 251
 252 2019-04-25  Tom Tromey  <tromey@adacore.com>
 253
 254         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 255         (gdb_rl_callback_handler): Use std::move.
 256         * common/common-exceptions.h (struct gdb_exception): Add move
 257         assignment operator.
 258         (throw_exception_sjlj): Change "exception" to const reference.
 259         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 260         (throw_exception_sjlj): Change "exception" to const reference.
 261
 262 2019-04-25  Tom Tromey  <tromey@adacore.com>
 263
 264         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 265         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 266         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 267         Update.
 268         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 269         Update.
 270         * mi/mi-interp.c (mi_interp::exec): Update.
 271         * linespec.c (parse_linespec): Update.
 272         * infcall.c (run_inferior_call): Update.
 273         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 274         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 275         (gdbscm_lookup_global_symbol): Update.
 276         * guile/scm-param.c (gdbscm_parameter_value): Update.
 277         * guile/scm-frame.c (gdbscm_frame_read_register)
 278         (gdbscm_frame_read_var): Update.
 279         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 280         * exec.c (try_open_exec_file): Update.
 281         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 282         (gdb_rl_callback_handler): Update.
 283         * common/common-exceptions.h (exception_none): Don't declare.
 284         * common/common-exceptions.c (exception_none): Don't define.
 285         (struct catcher) <exception>: Update.
 286         * cli/cli-interp.c (safe_execute_command): Update.
 287         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 288
 289 2019-04-25  Ali Tamur  <tamur@google.com>
 290
 291         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 292         (read_attribute_value): Likewise.
 293         (dwarf2_read_addr_index): Update comment.
 294         (read_str_index): Add DW_FORM_strx.
 295         (dwarf2_string_attr): Likewise.
 296         (dwarf2_const_value_attr): Likewise.
 297         (dump_die_shallow): Likewise.
 298         (dwarf2_fetch_constant_bytes): Likewise.
 299         (skip_form_bytes): Likewise.
 300         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 301
 302 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 303
 304         PR corefiles/11608
 305         PR corefiles/18187
 306         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 307         OFFSET.  Verify if current mapping contains an ELF header.
 308         (linux_find_memory_regions_full): Adjust call to
 309         dump_mapping_p.
 310
 311 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 312             Kang Li <kanglictf@gmail.com>
 313
 314         PR gdb/21600
 315
 316         * dwarf2-frame.c (read_initial_length): Be consistent about using
 317         unsigned representation of length.
 318         (decode_frame_entry_1): Likewise.  Check for wraparound of
 319         end pointer as well as buffer overflow.
 320
 321 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 322
 323         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 324         "vq".
 325
 326 2019-04-24  Tom Tromey  <tromey@adacore.com>
 327
 328         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 329
 330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 331
 332         * s12z-tdep.c (s12z_unwind_pc): Delete.
 333         (s12z_unwind_sp): Delete.
 334         (s12z_gdbarch_init): Don't register deleted functions with
 335         gdbarch.
 336
 337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 338
 339         * rl78-tdep.c (rl78_unwind_sp): Delete.
 340         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 341
 342 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 343
 344         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 345         (xstormy16_unwind_pc): Delete.
 346         (xstormy16_dummy_id): Delete.
 347         (xstormy16_gdbarch_init): Don't register deleted functions with
 348         gdbarch.
 349
 350 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 351
 352         * vax-tdep.c (vax_unwind_pc): Delete.
 353         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 354
 355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 356
 357         * v850-tdep.c (v850_unwind_sp): Delete.
 358         (v850_unwind_pc): Delete.
 359         (v850_dummy_id): Delete.
 360         (v850_gdbarch_init): Don't register deleted functions with
 361         gdbarch.
 362
 363 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 364
 365         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 366         (tilegx_unwind_pc): Delete.
 367         (tilegx_unwind_dummy_id): Delete.
 368         (tilegx_gdbarch_init): Don't register deleted functions with
 369         gdbarch.
 370
 371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 372
 373         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 374         (tic6x_dummy_id): Delete.
 375         (tic6x_gdbarch_init): Don't register deleted functions with
 376         gdbarch.
 377
 378 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 379
 380         * sparc-tdep.c (sparc_unwind_pc): Delete.
 381         (sparc32_gdbarch_init): Don't register deleted function with
 382         gdbarch.
 383
 384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 385
 386         * sh-tdep.c (sh_unwind_sp): Delete.
 387         (sh_unwind_pc): Delete.
 388         (sh_dummy_id): Delete.
 389         (sh_gdbarch_init): Don't register deleted functions with
 390         gdbarch.
 391
 392 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 393
 394         * score-tdep.c (score_unwind_sp): Delete.
 395         (score_unwind_pc): Delete.
 396         (score_dummy_id): Delete.
 397         (score_gdbarch_init): Don't register deleted functions with
 398         gdbarch.
 399
 400 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 401
 402         * rx-tdep.c (rx_unwind_pc): Delete.
 403         (rx_unwind_sp): Delete.
 404         (rx_dummy_id): Delete.
 405         (rx_gdbarch_init): Don't register deleted functions with
 406         gdbarch.  Update comment.
 407
 408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 411         (rs6000_dummy_id): Delete.
 412         (rs6000_gdbarch_init): Don't register deleted functions with
 413         gdbarch.
 414
 415 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 416
 417         * or1k-tdep.c (or1k_dummy_id): Delete.
 418         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 419
 420 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 421
 422         * nios2-tdep.c (nios2_dummy_id): Delete.
 423         (nios2_unwind_sp): Delete.
 424         (nios2_gdbarch_init): Don't register deleted functions with
 425         gdbarch.
 426
 427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * nds32-tdep.c (nds32_dummy_id): Delete.
 430         (nds32_unwind_pc): Delete.
 431         (nds32_unwind_sp): Delete.
 432         (nds32_gdbarch_init): Don't register deleted functions with
 433         gdbarch.
 434
 435 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 436
 437         * msp430-tdep.c (msp430_unwind_pc): Delete.
 438         (msp430_unwind_sp): Delete.
 439         (msp430_dummy_id): Delete.
 440         (msp430_gdbarch_init): Don't register deleted functions with
 441         gdbarch.
 442
 443 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 444
 445         * moxie-tdep.c (moxie_unwind_sp): Delete.
 446         (moxie_unwind_pc): Delete.
 447         (moxie_dummy_id): Delete.
 448         (moxie_gdbarch_init): Don't register deleted functions with
 449         gdbarch.
 450
 451 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 452
 453         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 454         (mn10300_unwind_pc): Delete.
 455         (mn10300_unwind_sp): Delete.
 456         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 457         mn10300_unwind_sp.
 458         (mn10300_frame_unwind_init): Don't register deleted functions with
 459         gdbarch.
 460
 461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 462
 463         * mep-tdep.c (mep_unwind_pc): Delete.
 464         (mep_unwind_sp): Delete.
 465         (mep_dummy_id): Delete.
 466         (mep_gdbarch_init): Don't register deleted functions with
 467         gdbarch.
 468
 469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 470
 471         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 472         (m68hc11_unwind_sp): Delete.
 473         (m68hc11_gdbarch_init): Don't register deleted functions with
 474         gdbarch.
 475
 476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 477
 478         * m32r-tdep.c (m32r_unwind_sp): Delete.
 479         (m32r_unwind_pc): Delete.
 480         (m32r_dummy_id): Delete.
 481         (m32r_gdbarch_init): Don't register deleted functions with
 482         gdbarch.
 483
 484 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 485
 486         * m32c-tdep.c (m32c_unwind_pc): Delete.
 487         (m32c_unwind_sp): Delete.
 488         (m32c_dummy_id): Delete.
 489         (m32c_gdbarch_init): Don't register deleted functions with
 490         gdbarch.
 491
 492 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 493
 494         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 495         (lm32_unwind_pc): Delete.
 496         (lm32_dummy_id): Delete.
 497         (lm32_gdbarch_init): Don't register deleted functions with
 498         gdbarch.
 499
 500 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 501
 502         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 503         (iq2000_unwind_pc): Delete.
 504         (iq2000_dummy_id): Delete.
 505         (iq2000_gdbarch_init): Don't register deleted functions with
 506         gdbarch.
 507
 508 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 509
 510         * nds32-tdep.c (nds32_type_align): Delete.
 511         (nds32_push_dummy_call): Use type_align instead.
 512
 513 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 514
 515         * arm-tdep.c (arm_type_align): Only handle vector override case.
 516         (arm_push_dummy_call): Use type_align.
 517         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 518
 519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 522         case.
 523         (pass_on_stack): Use type_align.
 524         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 525         function.
 526
 527 2019-04-23  Tom Tromey  <tromey@adacore.com>
 528
 529         * dwarf2read.c (line_header::file_name_at): Remove unused
 530         overload.
 531
 532 2019-04-23  Tom de Vries  <tdevries@suse.de>
 533
 534         PR gdb/24438
 535         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 536         invocation.
 537
 538
 539 2019-03-27  Ali Tamur  <tamur@google.com>
 540
 541         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 542         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 543         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 544         (dwarf_expr_context::get_addr_index): Likewise
 545         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 546         (symbol_needs_eval_context::get_addr_index): Likewise
 547         (disassemble_dwarf_expression): Add DW_OP_addrx
 548         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 549         (read_cutu_die_from_dwo): Update comment
 550         (skip_one_die): Add DW_FORM_addrx
 551         (read_attribute_value): Likewise
 552         (var_decode_location): Add DW_OP_addrx
 553         (dwarf2_const_value_attr): Add DW_FORM_addrx
 554         (dump_die_shallow): Likewise
 555         (dwarf2_fetch_constant_bytes): Likewise
 556         (decode_locdesc): Add DW_OP_addrx
 557         (skip_form_bytes): Add DW_FORM_addrx
 558
 559 2019-04-22  Ali Tamur  <tamur@google.com>
 560
 561         * MAINTAINERS (Write After Approval): Add self.
 562
 563 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 564
 565         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 566         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 567         (open_symbol_file_object): Likewise.
 568         (svr4_default_sos): Add info parameter.
 569         (svr4_read_so_list): Likewise.
 570         (svr4_current_sos_direct): Adjust functions calls to pass down
 571         info.
 572         (svr4_current_sos_1): Add info parameter.
 573         (svr4_current_sos): Call get_svr4_info, pass info down to
 574         svr4_current_sos_1.
 575         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 576         get_svr4_info.
 577         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 578         get_svr4_info.
 579         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 580         to get_svr4_info.
 581         (probes_table_remove_objfile_probes): Likewise.
 582         (register_solib_event_probe): Add info parameter.
 583         (solist_update_incremental): Pass info parameter down to
 584         svr4_read_so_list.
 585         (disable_probes_interface): Add info parameter.
 586         (svr4_handle_solib_event): Pass current_program_space to
 587         get_svr4_info.  Adjust disable_probes_interface cleanup.
 588         (svr4_create_probe_breakpoints): Add info parameter, pass it
 589         down to register_solib_event_probe.
 590         (svr4_create_solib_event_breakpoints): Add info parameter,
 591         pass it down to svr4_create_probe_breakpoints.
 592         (enable_break): Pass info down to
 593         svr4_create_solib_event_breakpoints.
 594         (svr4_solib_create_inferior_hook): Pass current_program_space to
 595         get_svr4_info.
 596         (svr4_clear_solib): Likewise.
 597
 598 2019-04-22  Pedro Alves  <palves@redhat.com>
 599
 600         * solib-svr4.c (svr4_free_objfile_observer): New.
 601         (probe_and_action::objfile): New field.
 602         (probes_table_htab_remove_objfile_probes)
 603         (probes_table_remove_objfile_probes): New functions.
 604         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 605         in the new probe_and_action.  Don't store the probe in 'lookup'.
 606         (svr4_create_probe_breakpoints): Pass objfile to
 607         register_solib_event_probe.
 608         (_initialize_svr4_solib): Register a free_objfile observer.
 609
 610 2019-04-19  Tom Tromey  <tom@tromey.com>
 611
 612         * common/queue.h: Remove.
 613
 614 2019-04-19  Tom Tromey  <tom@tromey.com>
 615
 616         * event-loop.c: Don't include "common/queue.h".
 617
 618 2019-04-19  Tom Tromey  <tom@tromey.com>
 619
 620         * remote.c (remote_target): Use delete.
 621         * remote-notif.h: Include <list>, not "common/queue.h".
 622         (notif_client_p): Remove typedef.
 623         (remote_notif_state): Add constructor, destructor, initializer.
 624         <notif_queue>: Now a std::list.
 625         (remote_notif_state_xfree): Don't declare.
 626         * remote-notif.c (remote_notif_process, handle_notification)
 627         (remote_notif_state_allocate): Update.
 628         (~remote_notif_state): Rename from remote_notif_state_xfree.
 629
 630 2019-04-19  Tom Tromey  <tom@tromey.com>
 631
 632         * symfile.c (reread_symbols): Update.
 633         * objfiles.c (objfile_register_static_link)
 634         (objfile_lookup_static_link): Update
 635         (~objfile) Don't delete static_links.
 636         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 637
 638 2019-04-19  Tom Tromey  <tom@tromey.com>
 639
 640         * type-stack.h (struct type_stack) <insert>: Constify string.
 641         * type-stack.c (type_stack::insert): Constify string.
 642         * gdbtypes.h (lookup_template_type): Update.
 643         (address_space_name_to_int): Update.
 644         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 645         const.
 646         (lookup_template_type): Make name const.
 647         * c-exp.y: Update rules.
 648         (lex_one_token, classify_name, classify_inner_name)
 649         (c_print_token): Update.
 650         * p-exp.y: Update rules.
 651         (yylex): Update.
 652         * f-exp.y: Update rules.
 653         (yylex): Update.
 654         * d-exp.y: Update rules.
 655         (lex_one_token, classify_name, classify_inner_name): Update.
 656         * parse.c (write_dollar_variable, copy_name): Return std::string.
 657         * parser-defs.h (copy_name): Change return type.
 658         * m2-exp.y: Update rules.
 659         (yylex): Update.
 660         * go-exp.y (lex_one_token): Update.
 661         Update rules.
 662         (classify_unsafe_function, classify_packaged_name)
 663         (classify_name, yylex): Update.
 664
 665 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 666
 667         * configure.ac: add --enable-source-highlight switch.
 668         * configure: Regenerate.
 669         * top.c (print_gdb_version): plumb --enable-source-highlight
 670         status to "show configuration".
 671
 672 2019-04-19  Tom Tromey  <tromey@adacore.com>
 673
 674         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 675         Check ADA_TYPE_P.
 676         (empty_record, ada_template_to_fixed_record_type_1)
 677         (template_to_static_fixed_type)
 678         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 679         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 680         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 681         macros.
 682
 683 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 684
 685         PR symtab/24423:
 686         * source.c (print_source_lines_base): Advance "iter" when a
 687         control character is seen.
 688
 689 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 690
 691         * inferior.h (struct infcall_suspend_state_deleter):
 692         Catch exception in destructor to avoid crash.
 693
 694 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 695
 696         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 697         close to the add_com "shell".
 698
 699 2019-04-18  Tom Tromey  <tromey@adacore.com>
 700
 701         * process-stratum-target.h (class process_stratum_target)
 702         <stratum>: Add "final".
 703
 704 2019-04-17  Tom Tromey  <tromey@adacore.com>
 705
 706         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 707         against nullptr before use.
 708
 709 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 710
 711         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 712
 713 2019-04-17  Jim Wilson  <jimw@sifive.com>
 714             Andrew Burgess  <andrew.burgess@embecosm.com>
 715
 716         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 717         code read might fail, assume 4-byte breakpoint in that case.
 718
 719 2019-04-15  Leszek Swirski  <leszeks@google.com>
 720
 721         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 722         rather than a hand-rolled POD check when checking for forced MEMORY
 723         classification.
 724
 725 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 726
 727         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 728         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 729         function.
 730         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 731         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 732         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 733         declaration.
 734
 735 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 736
 737         * aarch64-linux-nat.c
 738         (aarch64_linux_nat_target::thread_architecture): Add override.
 739         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 740         each VQ.
 741
 742 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 743
 744         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 745
 746 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 747
 748         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 749         target types of size 96-bits, add some additional comments, and
 750         check that the builtin type we found was the correct size.
 751
 752 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 753
 754         * utils.c (prompt_for_continue): Don't restore the styling at the
 755         end, as applied_style has the wrong value.  This fixes styling in
 756         long lists of file names that are interrupted by the "Continue?"
 757         prompt.
 758
 759 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 760
 761         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 762         * c-lang.c (c_language_defn): Likewise.
 763         (cplus_language_defn): Likewise.
 764         (asm_language_defn): Likewise.
 765         (minimal_language_defn): Likewise.
 766         * d-lang.c (d_language_defn): Likewise.
 767         * f-lang.c (f_language_defn): Likewise.
 768         * go-lang.c (go_language_defn): Likewise.
 769         * language.c (unknown_language_defn): Likewise.
 770         (auto_language_defn): Likewise.
 771         * language.h (struct language_defn): Remove la_magic field.
 772         (LANG_MAGIC): Delete.
 773         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 774         * objc-lang.c (objc_language_defn): Likewise.
 775         * opencl-lang.c (opencl_language_defn): Likewise.
 776         * p-lang.c (pascal_language_defn): Likewise.
 777         * rust-lang.c (rust_language_defn): Likewise.
 778
 779 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 780
 781         * riscv-tdep.c (riscv_type_align): New function.
 782         (riscv_type_alignment): Delete.
 783         (riscv_arg_location): Use 'type_align'.
 784         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 785
 786 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 787
 788         * gdbtypes.c (type_align): A struct with no non-static fields also
 789         has alignment of 1.
 790
 791 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 792
 793         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 794         component to 0.
 795         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 796         member.
 797         (riscv_struct_info::analyse): New implementation using new
 798         analyse_inner member function.
 799         (riscv_struct_info::field_offset): New member function.
 800         (riscv_struct_info::m_offsets): New member variable.
 801         (riscv_struct_info::analyse_inner): New private member function,
 802         takes the old implementation of riscv_struct_info::analyse but
 803         extended to track field offsets.
 804         (riscv_call_arg_struct): Update the struct folding special cases
 805         to handle cases where empty C++ structs, which are non-zero
 806         length, are found.
 807         (riscv_arg_location): Initialise the length of each location, a
 808         non-zero length now indicates the location is in use.
 809         (riscv_push_dummy_call): Allow for the first location having a
 810         non-zero offset when setting up arguments.
 811         (riscv_return_value): Likewise, but for return values.
 812
 813 2019-04-11  Tom Tromey  <tromey@adacore.com>
 814
 815         * utils.c (internal_vproblem): Make "msg" const.
 816
 817 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 818
 819         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 820         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 821         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 822         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 823
 824 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 825
 826         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 827         function.
 828         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 829         of amd64_collect_native_gregset.
 830         (amd64_linux_nat_target::store_registers): Likewise.
 831
 832 2019-04-10  Tom Tromey  <tom@tromey.com>
 833
 834         * symtab.c (lookup_global_symbol_from_objfile)
 835         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 836         * objfiles.h (class separate_debug_iterator): New.
 837         (class separate_debug_range): New.
 838         (struct objfile) <separate_debug_objfiles>: New method.
 839         (objfile_separate_debug_iterate): Don't declare.
 840         * objfiles.c (separate_debug_iterator::operator++): Rename from
 841         objfile_separate_debug_iterate.
 842         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 843         iterator.
 844         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 845         iterator.
 846
 847 2019-04-10  Tom Tromey  <tom@tromey.com>
 848
 849         * symfile.c (reread_symbols): Remove old comment.
 850         * objfiles.c (free_all_objfiles): Fix a typo.
 851
 852 2019-04-10  Tom Tromey  <tom@tromey.com>
 853
 854         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 855         * minsyms.c (lookup_minimal_symbol): Use foreach.
 856         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 857         (lookup_minimal_symbol_solib_trampoline): Likewise.
 858         * symfile.c (reread_symbols): Use foreach.
 859
 860 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 861             Tom Tromey  <tromey@adacore.com>
 862
 863         PR rust/24414:
 864         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 865         (rust_lex_int_test): Change "value" to be LONGEST.
 866         (rust_lex_tests): Add test for long integer literal.
 867
 868 2019-04-09  Tom Tromey  <tromey@adacore.com>
 869
 870         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 871         to bool.
 872         (extended_remote_target::attach): Update.
 873         (remote_target::remote_notice_new_inferior): Update.
 874         (remote_target::add_current_inferior_and_thread): Update.
 875         * inferior.c (exit_inferior_1): Use "false".
 876         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 877
 878 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 879
 880         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 881         the "start" command.
 882
 883 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 884
 885         * python/py-inferior.c (infpy_thread_from_thread_handle):
 886         Adjust comments to reflect renaming of thread_from_thread_handle
 887         to thread_from_handle.  Adjust keywords.  Fix type error message.
 888         (inferior_object_methods): Add thread_from_handle.  Retain
 889         thread_from_thread_handle, but mark it as deprecated.
 890
 891 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 892
 893         * gdbthread.h (find_thread_by_handle): Revise declaration.
 894         * thread.c (find_thread_by_handle): Likewise.  Adjust
 895         implementation too.
 896         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 897         support for buffer objects as handles.
 898
 899 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 900
 901         * python/py-infthread.c (thpy_thread_handle): New function.
 902         (thread_object_methods): Register thpy_thread_handle.
 903
 904 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 905
 906         * gdbthread.h (thread_to_thread_handle): Declare.
 907         * thread.c (gdbtypes.h): Include.
 908         (thread_to_thread_handle): New function.
 909
 910         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 911         (target_thread_info_to_thread_handle): Declare.
 912         * target.c (target_thread_info_to_thread_handle): New function.
 913         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 914         * target-delegates.c: Regenerate.
 915
 916         * linux-thread-db.c (class thread_db_target): Add method
 917         thread_info_to_thread_handle.
 918         (thread_db_target::thread_info_to_thread_handle): Define.
 919         * remote.c (class remote_target): Add new method
 920         thread_info_to_thread_handle.
 921         (remote_target::thread_info_to_thread_handle): Define.
 922
 923 2019-04-08  Pedro Alves  <palves@redhat.com>
 924
 925         * common/common-exceptions.c (throw_exception): Don't create
 926         named object to throw; throw directly.
 927         (throw_it): Likewise.  Don't initialize gdb_exception::message
 928         here, with new; pass FMT and AP to the ctor instead.
 929         * common/common-exceptions.h: Include <string>.
 930         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 931         const char *, va_list)): New ctor.  Use std::make_shared.
 932         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 933         errors)): Delete.
 934         (gdb_exception_error::gdb_exception_error(enum errors, const char
 935         *, va_list)): New.
 936         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 937         Add assertion.
 938         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 939         errors)): Delete.
 940         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 941         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 942         Add assertion.
 943
 944 2019-04-08  Tom Tromey  <tom@tromey.com>
 945
 946         * valops.c (value_rtti_indirect_type): Replace throw_exception
 947         with throw.
 948         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 949         with throw.
 950         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 951         throw.
 952         * target.c (target_translate_tls_address): Replace throw_exception
 953         with throw.
 954         * stack.c (frame_apply_command_count): Replace throw_exception
 955         with throw.
 956         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 957         throw.
 958         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 959         with throw.
 960         * rs6000-tdep.c (rs6000_frame_cache)
 961         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 962         * remote.c: Replace throw_exception with throw.
 963         * record-full.c (record_full_message, record_full_wait_1)
 964         (record_full_restore): Replace throw_exception with throw.
 965         * record-btrace.c:
 966         (get_thread_current_frame_id, record_btrace_start_replaying)
 967         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 968         (cmd_record_btrace_start): Replace throw_exception with throw.
 969         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 970         throw.
 971         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 972         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 973         * linespec.c:
 974         (find_linespec_symbols): Replace throw_exception with throw.
 975         * infrun.c (displaced_step_prepare, resume): Replace
 976         throw_exception with throw.
 977         * infcmd.c (post_create_inferior): Replace throw_exception with
 978         throw.
 979         * inf-loop.c (inferior_event_handler): Replace throw_exception
 980         with throw.
 981         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 982         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 983         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 984         (get_prev_frame_always, get_frame_pc_if_available)
 985         (get_frame_address_in_block_if_available, get_frame_language):
 986         Replace throw_exception with throw.
 987         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 988         throw_exception with throw.
 989         * eval.c (fetch_subexp_value, evaluate_var_value)
 990         (evaluate_funcall, evaluate_subexp_standard): Replace
 991         throw_exception with throw.
 992         * dwarf2loc.c (call_site_find_chain)
 993         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 994         Replace throw_exception with throw.
 995         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 996         with throw.
 997         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 998         throw.
 999         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1000         * completer.c (complete_line_internal): Replace throw_exception
1001         with throw.
1002         * compile/compile-object-run.c (compile_object_run): Replace
1003         throw_exception with throw.
1004         * cli/cli-script.c (process_next_line): Replace throw_exception
1005         with throw.
1006         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1007         (btrace_enable, btrace_maint_update_pt_packets): Replace
1008         throw_exception with throw.
1009         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1010         throw_exception with throw.
1011         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1012         throw_exception with throw.
1013         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1014         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1015         * aarch64-tdep.c (aarch64_make_prologue_cache)
1016         (aarch64_make_stub_cache): Replace throw_exception with throw.
1017
1018 2019-04-08  Tom Tromey  <tom@tromey.com>
1019
1020         * common/common-exceptions.c (throw_exception): Rename from
1021         throw_exception_cxx.  Remove old copy.  Make argument const.
1022         (throw_it): Create and throw exception objects directly.
1023         * common/common-exceptions.h (throw_exception): Make argument
1024         const.
1025         (struct gdb_exception_error): Add constructor.
1026         (struct gdb_exception_quit): Add constructor.
1027
1028 2019-04-08  Tom Tromey  <tom@tromey.com>
1029
1030         * common/common-exceptions.h (exception_rethrow): Don't declare.
1031         (TRY_SJLJ): Update comment.
1032         (TRY, CATCH, END_CATCH): Remove.
1033         * common/common-exceptions.c (exception_rethrow): Remove.
1034
1035 2019-04-08  Tom Tromey  <tom@tromey.com>
1036
1037         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1038         Remove.
1039         (gdb_exception_error): Rename from
1040         gdb_exception_RETURN_MASK_ERROR.
1041         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1042         (gdb_quit_bad_alloc): Update.
1043         * aarch64-tdep.c: Update.
1044         * ada-lang.c: Update.
1045         * ada-typeprint.c: Update.
1046         * ada-valprint.c: Update.
1047         * amd64-tdep.c: Update.
1048         * arch-utils.c: Update.
1049         * break-catch-throw.c: Update.
1050         * breakpoint.c: Update.
1051         * btrace.c: Update.
1052         * c-varobj.c: Update.
1053         * cli/cli-cmds.c: Update.
1054         * cli/cli-interp.c: Update.
1055         * cli/cli-script.c: Update.
1056         * common/common-exceptions.c: Update.
1057         * common/new-op.c: Update.
1058         * common/selftest.c: Update.
1059         * compile/compile-c-symbols.c: Update.
1060         * compile/compile-cplus-symbols.c: Update.
1061         * compile/compile-object-load.c: Update.
1062         * compile/compile-object-run.c: Update.
1063         * completer.c: Update.
1064         * corelow.c: Update.
1065         * cp-abi.c: Update.
1066         * cp-support.c: Update.
1067         * cp-valprint.c: Update.
1068         * darwin-nat.c: Update.
1069         * disasm-selftests.c: Update.
1070         * dtrace-probe.c: Update.
1071         * dwarf-index-cache.c: Update.
1072         * dwarf-index-write.c: Update.
1073         * dwarf2-frame-tailcall.c: Update.
1074         * dwarf2-frame.c: Update.
1075         * dwarf2loc.c: Update.
1076         * dwarf2read.c: Update.
1077         * eval.c: Update.
1078         * event-loop.c: Update.
1079         * event-top.c: Update.
1080         * exec.c: Update.
1081         * f-valprint.c: Update.
1082         * fbsd-tdep.c: Update.
1083         * frame-unwind.c: Update.
1084         * frame.c: Update.
1085         * gdbtypes.c: Update.
1086         * gnu-v3-abi.c: Update.
1087         * guile/guile-internal.h: Update.
1088         * guile/scm-block.c: Update.
1089         * guile/scm-breakpoint.c: Update.
1090         * guile/scm-cmd.c: Update.
1091         * guile/scm-disasm.c: Update.
1092         * guile/scm-frame.c: Update.
1093         * guile/scm-lazy-string.c: Update.
1094         * guile/scm-math.c: Update.
1095         * guile/scm-param.c: Update.
1096         * guile/scm-ports.c: Update.
1097         * guile/scm-pretty-print.c: Update.
1098         * guile/scm-symbol.c: Update.
1099         * guile/scm-symtab.c: Update.
1100         * guile/scm-type.c: Update.
1101         * guile/scm-value.c: Update.
1102         * i386-linux-tdep.c: Update.
1103         * i386-tdep.c: Update.
1104         * inf-loop.c: Update.
1105         * infcall.c: Update.
1106         * infcmd.c: Update.
1107         * infrun.c: Update.
1108         * jit.c: Update.
1109         * language.c: Update.
1110         * linespec.c: Update.
1111         * linux-fork.c: Update.
1112         * linux-nat.c: Update.
1113         * linux-tdep.c: Update.
1114         * linux-thread-db.c: Update.
1115         * main.c: Update.
1116         * mi/mi-cmd-break.c: Update.
1117         * mi/mi-cmd-stack.c: Update.
1118         * mi/mi-interp.c: Update.
1119         * mi/mi-main.c: Update.
1120         * objc-lang.c: Update.
1121         * p-valprint.c: Update.
1122         * parse.c: Update.
1123         * ppc-linux-tdep.c: Update.
1124         * printcmd.c: Update.
1125         * python/py-arch.c: Update.
1126         * python/py-breakpoint.c: Update.
1127         * python/py-cmd.c: Update.
1128         * python/py-finishbreakpoint.c: Update.
1129         * python/py-frame.c: Update.
1130         * python/py-framefilter.c: Update.
1131         * python/py-gdb-readline.c: Update.
1132         * python/py-inferior.c: Update.
1133         * python/py-infthread.c: Update.
1134         * python/py-lazy-string.c: Update.
1135         * python/py-linetable.c: Update.
1136         * python/py-objfile.c: Update.
1137         * python/py-param.c: Update.
1138         * python/py-prettyprint.c: Update.
1139         * python/py-progspace.c: Update.
1140         * python/py-record-btrace.c: Update.
1141         * python/py-record.c: Update.
1142         * python/py-symbol.c: Update.
1143         * python/py-type.c: Update.
1144         * python/py-unwind.c: Update.
1145         * python/py-utils.c: Update.
1146         * python/py-value.c: Update.
1147         * python/python.c: Update.
1148         * record-btrace.c: Update.
1149         * record-full.c: Update.
1150         * remote-fileio.c: Update.
1151         * remote.c: Update.
1152         * riscv-tdep.c: Update.
1153         * rs6000-aix-tdep.c: Update.
1154         * rs6000-tdep.c: Update.
1155         * rust-exp.y: Update.
1156         * rust-lang.c: Update.
1157         * s390-tdep.c: Update.
1158         * selftest-arch.c: Update.
1159         * solib-dsbt.c: Update.
1160         * solib-frv.c: Update.
1161         * solib-spu.c: Update.
1162         * solib-svr4.c: Update.
1163         * solib.c: Update.
1164         * sparc64-linux-tdep.c: Update.
1165         * stack.c: Update.
1166         * symfile-mem.c: Update.
1167         * symmisc.c: Update.
1168         * target.c: Update.
1169         * thread.c: Update.
1170         * top.c: Update.
1171         * tracefile-tfile.c: Update.
1172         * tui/tui.c: Update.
1173         * typeprint.c: Update.
1174         * unittests/cli-utils-selftests.c: Update.
1175         * unittests/parse-connection-spec-selftests.c: Update.
1176         * valops.c: Update.
1177         * valprint.c: Update.
1178         * value.c: Update.
1179         * varobj.c: Update.
1180         * windows-nat.c: Update.
1181         * x86-linux-nat.c: Update.
1182         * xml-support.c: Update.
1183
1184 2019-04-08  Tom Tromey  <tom@tromey.com>
1185
1186         * xml-support.c: Use C++ exception handling.
1187         * x86-linux-nat.c: Use C++ exception handling.
1188         * windows-nat.c: Use C++ exception handling.
1189         * varobj.c: Use C++ exception handling.
1190         * value.c: Use C++ exception handling.
1191         * valprint.c: Use C++ exception handling.
1192         * valops.c: Use C++ exception handling.
1193         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1194         handling.
1195         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1196         * typeprint.c: Use C++ exception handling.
1197         * tui/tui.c: Use C++ exception handling.
1198         * tracefile-tfile.c: Use C++ exception handling.
1199         * top.c: Use C++ exception handling.
1200         * thread.c: Use C++ exception handling.
1201         * target.c: Use C++ exception handling.
1202         * symmisc.c: Use C++ exception handling.
1203         * symfile-mem.c: Use C++ exception handling.
1204         * stack.c: Use C++ exception handling.
1205         * sparc64-linux-tdep.c: Use C++ exception handling.
1206         * solib.c: Use C++ exception handling.
1207         * solib-svr4.c: Use C++ exception handling.
1208         * solib-spu.c: Use C++ exception handling.
1209         * solib-frv.c: Use C++ exception handling.
1210         * solib-dsbt.c: Use C++ exception handling.
1211         * selftest-arch.c: Use C++ exception handling.
1212         * s390-tdep.c: Use C++ exception handling.
1213         * rust-lang.c: Use C++ exception handling.
1214         * rust-exp.y: Use C++ exception handling.
1215         * rs6000-tdep.c: Use C++ exception handling.
1216         * rs6000-aix-tdep.c: Use C++ exception handling.
1217         * riscv-tdep.c: Use C++ exception handling.
1218         * remote.c: Use C++ exception handling.
1219         * remote-fileio.c: Use C++ exception handling.
1220         * record-full.c: Use C++ exception handling.
1221         * record-btrace.c: Use C++ exception handling.
1222         * python/python.c: Use C++ exception handling.
1223         * python/py-value.c: Use C++ exception handling.
1224         * python/py-utils.c: Use C++ exception handling.
1225         * python/py-unwind.c: Use C++ exception handling.
1226         * python/py-type.c: Use C++ exception handling.
1227         * python/py-symbol.c: Use C++ exception handling.
1228         * python/py-record.c: Use C++ exception handling.
1229         * python/py-record-btrace.c: Use C++ exception handling.
1230         * python/py-progspace.c: Use C++ exception handling.
1231         * python/py-prettyprint.c: Use C++ exception handling.
1232         * python/py-param.c: Use C++ exception handling.
1233         * python/py-objfile.c: Use C++ exception handling.
1234         * python/py-linetable.c: Use C++ exception handling.
1235         * python/py-lazy-string.c: Use C++ exception handling.
1236         * python/py-infthread.c: Use C++ exception handling.
1237         * python/py-inferior.c: Use C++ exception handling.
1238         * python/py-gdb-readline.c: Use C++ exception handling.
1239         * python/py-framefilter.c: Use C++ exception handling.
1240         * python/py-frame.c: Use C++ exception handling.
1241         * python/py-finishbreakpoint.c: Use C++ exception handling.
1242         * python/py-cmd.c: Use C++ exception handling.
1243         * python/py-breakpoint.c: Use C++ exception handling.
1244         * python/py-arch.c: Use C++ exception handling.
1245         * printcmd.c: Use C++ exception handling.
1246         * ppc-linux-tdep.c: Use C++ exception handling.
1247         * parse.c: Use C++ exception handling.
1248         * p-valprint.c: Use C++ exception handling.
1249         * objc-lang.c: Use C++ exception handling.
1250         * mi/mi-main.c: Use C++ exception handling.
1251         * mi/mi-interp.c: Use C++ exception handling.
1252         * mi/mi-cmd-stack.c: Use C++ exception handling.
1253         * mi/mi-cmd-break.c: Use C++ exception handling.
1254         * main.c: Use C++ exception handling.
1255         * linux-thread-db.c: Use C++ exception handling.
1256         * linux-tdep.c: Use C++ exception handling.
1257         * linux-nat.c: Use C++ exception handling.
1258         * linux-fork.c: Use C++ exception handling.
1259         * linespec.c: Use C++ exception handling.
1260         * language.c: Use C++ exception handling.
1261         * jit.c: Use C++ exception handling.
1262         * infrun.c: Use C++ exception handling.
1263         * infcmd.c: Use C++ exception handling.
1264         * infcall.c: Use C++ exception handling.
1265         * inf-loop.c: Use C++ exception handling.
1266         * i386-tdep.c: Use C++ exception handling.
1267         * i386-linux-tdep.c: Use C++ exception handling.
1268         * guile/scm-value.c: Use C++ exception handling.
1269         * guile/scm-type.c: Use C++ exception handling.
1270         * guile/scm-symtab.c: Use C++ exception handling.
1271         * guile/scm-symbol.c: Use C++ exception handling.
1272         * guile/scm-pretty-print.c: Use C++ exception handling.
1273         * guile/scm-ports.c: Use C++ exception handling.
1274         * guile/scm-param.c: Use C++ exception handling.
1275         * guile/scm-math.c: Use C++ exception handling.
1276         * guile/scm-lazy-string.c: Use C++ exception handling.
1277         * guile/scm-frame.c: Use C++ exception handling.
1278         * guile/scm-disasm.c: Use C++ exception handling.
1279         * guile/scm-cmd.c: Use C++ exception handling.
1280         * guile/scm-breakpoint.c: Use C++ exception handling.
1281         * guile/scm-block.c: Use C++ exception handling.
1282         * guile/guile-internal.h: Use C++ exception handling.
1283         * gnu-v3-abi.c: Use C++ exception handling.
1284         * gdbtypes.c: Use C++ exception handling.
1285         * frame.c: Use C++ exception handling.
1286         * frame-unwind.c: Use C++ exception handling.
1287         * fbsd-tdep.c: Use C++ exception handling.
1288         * f-valprint.c: Use C++ exception handling.
1289         * exec.c: Use C++ exception handling.
1290         * event-top.c: Use C++ exception handling.
1291         * event-loop.c: Use C++ exception handling.
1292         * eval.c: Use C++ exception handling.
1293         * dwarf2read.c: Use C++ exception handling.
1294         * dwarf2loc.c: Use C++ exception handling.
1295         * dwarf2-frame.c: Use C++ exception handling.
1296         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1297         * dwarf-index-write.c: Use C++ exception handling.
1298         * dwarf-index-cache.c: Use C++ exception handling.
1299         * dtrace-probe.c: Use C++ exception handling.
1300         * disasm-selftests.c: Use C++ exception handling.
1301         * darwin-nat.c: Use C++ exception handling.
1302         * cp-valprint.c: Use C++ exception handling.
1303         * cp-support.c: Use C++ exception handling.
1304         * cp-abi.c: Use C++ exception handling.
1305         * corelow.c: Use C++ exception handling.
1306         * completer.c: Use C++ exception handling.
1307         * compile/compile-object-run.c: Use C++ exception handling.
1308         * compile/compile-object-load.c: Use C++ exception handling.
1309         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1310         * compile/compile-c-symbols.c: Use C++ exception handling.
1311         * common/selftest.c: Use C++ exception handling.
1312         * common/new-op.c: Use C++ exception handling.
1313         * cli/cli-script.c: Use C++ exception handling.
1314         * cli/cli-interp.c: Use C++ exception handling.
1315         * cli/cli-cmds.c: Use C++ exception handling.
1316         * c-varobj.c: Use C++ exception handling.
1317         * btrace.c: Use C++ exception handling.
1318         * breakpoint.c: Use C++ exception handling.
1319         * break-catch-throw.c: Use C++ exception handling.
1320         * arch-utils.c: Use C++ exception handling.
1321         * amd64-tdep.c: Use C++ exception handling.
1322         * ada-valprint.c: Use C++ exception handling.
1323         * ada-typeprint.c: Use C++ exception handling.
1324         * ada-lang.c: Use C++ exception handling.
1325         * aarch64-tdep.c: Use C++ exception handling.
1326
1327 2019-04-08  Tom Tromey  <tom@tromey.com>
1328
1329         * xml-support.c (gdb_xml_parser::parse): Update.
1330         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1331         * value.c (show_convenience): Update.
1332         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1333         (test_parse_flags_qcs): Update.
1334         * thread.c (thr_try_catch_cmd): Update.
1335         * target.c (target_translate_tls_address): Update.
1336         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1337         (info_frame_command_core, frame_apply_command_count): Update.
1338         * rust-exp.y (rust_lex_exception_test): Update.
1339         * riscv-tdep.c (riscv_print_one_register_info): Update.
1340         * remote.c (remote_target::enable_btrace): Update.
1341         * record-btrace.c (record_btrace_enable_warn): Update.
1342         * python/py-utils.c (gdbpy_convert_exception): Update.
1343         * printcmd.c (do_one_display, print_variable_and_value): Update.
1344         * mi/mi-main.c (mi_print_exception): Update.
1345         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1346         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1347         * linux-nat.c (linux_nat_target::attach): Update.
1348         * linux-fork.c (class scoped_switch_fork_info): Update.
1349         * infrun.c (displaced_step_prepare): Update.
1350         * infcall.c (call_function_by_hand_dummy): Update.
1351         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1352         * gnu-v3-abi.c (print_one_vtable): Update.
1353         * frame.c (get_prev_frame_always): Update.
1354         * f-valprint.c (info_common_command_for_block): Update.
1355         * exec.c (try_open_exec_file): Update.
1356         * exceptions.c (print_exception, exception_print)
1357         (exception_fprintf, exception_print_same): Update.
1358         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1359         * dwarf-index-cache.c (index_cache::store)
1360         (index_cache::lookup_gdb_index): Update.
1361         * darwin-nat.c (maybe_cache_shell): Update.
1362         * cp-valprint.c (cp_print_value_fields): Update.
1363         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1364         (gcc_cplus_symbol_address): Update.
1365         * compile/compile-c-symbols.c (gcc_convert_symbol)
1366         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1367         * common/selftest.c: Update.
1368         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1369         a std::string.
1370         (exception_try_scope_entry, exception_try_scope_exit): Don't
1371         declare.
1372         (struct exception_try_scope): Remove.
1373         (TRY): Don't use exception_try_scope.
1374         (struct gdb_exception): Add constructor, operator=.
1375         <what>: New method.
1376         (struct gdb_exception_RETURN_MASK_ALL)
1377         (struct gdb_exception_RETURN_MASK_ERROR)
1378         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1379         (struct gdb_quit_bad_alloc): Update.
1380         * common/common-exceptions.c (exception_none): Change
1381         initializer.
1382         (struct catcher) <state, exception>: Initialize inline.
1383         <prev>: Remove member.
1384         (current_catcher): Remove.
1385         (catchers): New global.
1386         (exceptions_state_mc_init): Simplify.
1387         (catcher_pop): Remove.
1388         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1389         (try_scope_depth, exception_try_scope_entry)
1390         (exception_try_scope_exit): Remove.
1391         (throw_exception_sjlj): Update.
1392         (exception_messages, exception_messages_size): Remove.
1393         (throw_it): Simplify.
1394         (gdb_exception_sliced_copy): Remove.
1395         (throw_exception_cxx): Update.
1396         * cli/cli-script.c (script_from_file): Update.
1397         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1398         Update.
1399         * ada-valprint.c (ada_val_print): Update.
1400         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1401         (create_excep_cond_exprs): Update.
1402
1403 2019-04-08  Tom Tromey  <tom@tromey.com>
1404
1405         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1406         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1407         (TRY, CATCH, END_CATCH): Remove some definitions.
1408         * common/common-exceptions.c: Don't use GDB_XCPT.
1409         (catcher_list_size): Remove.
1410         (throw_exception, throw_it): Simplify.
1411
1412 2019-04-05  Tom Tromey  <tom@tromey.com>
1413
1414         Revert the header-sorting patch.
1415         * ft32-tdep.c: Revert.
1416         * frv-tdep.c: Revert.
1417         * frv-linux-tdep.c: Revert.
1418         * frame.c: Revert.
1419         * frame-unwind.c: Revert.
1420         * frame-base.c: Revert.
1421         * fork-child.c: Revert.
1422         * findvar.c: Revert.
1423         * findcmd.c: Revert.
1424         * filesystem.c: Revert.
1425         * filename-seen-cache.h: Revert.
1426         * filename-seen-cache.c: Revert.
1427         * fbsd-tdep.c: Revert.
1428         * fbsd-nat.h: Revert.
1429         * fbsd-nat.c: Revert.
1430         * f-valprint.c: Revert.
1431         * f-typeprint.c: Revert.
1432         * f-lang.c: Revert.
1433         * extension.h: Revert.
1434         * extension.c: Revert.
1435         * extension-priv.h: Revert.
1436         * expprint.c: Revert.
1437         * exec.h: Revert.
1438         * exec.c: Revert.
1439         * exceptions.c: Revert.
1440         * event-top.c: Revert.
1441         * event-loop.c: Revert.
1442         * eval.c: Revert.
1443         * elfread.c: Revert.
1444         * dwarf2read.h: Revert.
1445         * dwarf2read.c: Revert.
1446         * dwarf2loc.c: Revert.
1447         * dwarf2expr.h: Revert.
1448         * dwarf2expr.c: Revert.
1449         * dwarf2-frame.c: Revert.
1450         * dwarf2-frame-tailcall.c: Revert.
1451         * dwarf-index-write.h: Revert.
1452         * dwarf-index-write.c: Revert.
1453         * dwarf-index-common.c: Revert.
1454         * dwarf-index-cache.h: Revert.
1455         * dwarf-index-cache.c: Revert.
1456         * dummy-frame.c: Revert.
1457         * dtrace-probe.c: Revert.
1458         * disasm.h: Revert.
1459         * disasm.c: Revert.
1460         * disasm-selftests.c: Revert.
1461         * dictionary.c: Revert.
1462         * dicos-tdep.c: Revert.
1463         * demangle.c: Revert.
1464         * dcache.h: Revert.
1465         * dcache.c: Revert.
1466         * darwin-nat.h: Revert.
1467         * darwin-nat.c: Revert.
1468         * darwin-nat-info.c: Revert.
1469         * d-valprint.c: Revert.
1470         * d-namespace.c: Revert.
1471         * d-lang.c: Revert.
1472         * ctf.c: Revert.
1473         * csky-tdep.c: Revert.
1474         * csky-linux-tdep.c: Revert.
1475         * cris-tdep.c: Revert.
1476         * cris-linux-tdep.c: Revert.
1477         * cp-valprint.c: Revert.
1478         * cp-support.c: Revert.
1479         * cp-namespace.c: Revert.
1480         * cp-abi.c: Revert.
1481         * corelow.c: Revert.
1482         * corefile.c: Revert.
1483         * continuations.c: Revert.
1484         * completer.h: Revert.
1485         * completer.c: Revert.
1486         * complaints.c: Revert.
1487         * coffread.c: Revert.
1488         * coff-pe-read.c: Revert.
1489         * cli-out.h: Revert.
1490         * cli-out.c: Revert.
1491         * charset.c: Revert.
1492         * c-varobj.c: Revert.
1493         * c-valprint.c: Revert.
1494         * c-typeprint.c: Revert.
1495         * c-lang.c: Revert.
1496         * buildsym.c: Revert.
1497         * buildsym-legacy.c: Revert.
1498         * build-id.h: Revert.
1499         * build-id.c: Revert.
1500         * btrace.c: Revert.
1501         * bsd-uthread.c: Revert.
1502         * breakpoint.h: Revert.
1503         * breakpoint.c: Revert.
1504         * break-catch-throw.c: Revert.
1505         * break-catch-syscall.c: Revert.
1506         * break-catch-sig.c: Revert.
1507         * blockframe.c: Revert.
1508         * block.c: Revert.
1509         * bfin-tdep.c: Revert.
1510         * bfin-linux-tdep.c: Revert.
1511         * bfd-target.c: Revert.
1512         * bcache.c: Revert.
1513         * ax-general.c: Revert.
1514         * ax-gdb.h: Revert.
1515         * ax-gdb.c: Revert.
1516         * avr-tdep.c: Revert.
1517         * auxv.c: Revert.
1518         * auto-load.c: Revert.
1519         * arm-wince-tdep.c: Revert.
1520         * arm-tdep.c: Revert.
1521         * arm-symbian-tdep.c: Revert.
1522         * arm-pikeos-tdep.c: Revert.
1523         * arm-obsd-tdep.c: Revert.
1524         * arm-nbsd-tdep.c: Revert.
1525         * arm-nbsd-nat.c: Revert.
1526         * arm-linux-tdep.c: Revert.
1527         * arm-linux-nat.c: Revert.
1528         * arm-fbsd-tdep.c: Revert.
1529         * arm-fbsd-nat.c: Revert.
1530         * arm-bsd-tdep.c: Revert.
1531         * arch-utils.c: Revert.
1532         * arc-tdep.c: Revert.
1533         * arc-newlib-tdep.c: Revert.
1534         * annotate.h: Revert.
1535         * annotate.c: Revert.
1536         * amd64-windows-tdep.c: Revert.
1537         * amd64-windows-nat.c: Revert.
1538         * amd64-tdep.c: Revert.
1539         * amd64-sol2-tdep.c: Revert.
1540         * amd64-obsd-tdep.c: Revert.
1541         * amd64-obsd-nat.c: Revert.
1542         * amd64-nbsd-tdep.c: Revert.
1543         * amd64-nbsd-nat.c: Revert.
1544         * amd64-nat.c: Revert.
1545         * amd64-linux-tdep.c: Revert.
1546         * amd64-linux-nat.c: Revert.
1547         * amd64-fbsd-tdep.c: Revert.
1548         * amd64-fbsd-nat.c: Revert.
1549         * amd64-dicos-tdep.c: Revert.
1550         * amd64-darwin-tdep.c: Revert.
1551         * amd64-bsd-nat.c: Revert.
1552         * alpha-tdep.c: Revert.
1553         * alpha-obsd-tdep.c: Revert.
1554         * alpha-nbsd-tdep.c: Revert.
1555         * alpha-mdebug-tdep.c: Revert.
1556         * alpha-linux-tdep.c: Revert.
1557         * alpha-linux-nat.c: Revert.
1558         * alpha-bsd-tdep.c: Revert.
1559         * alpha-bsd-nat.c: Revert.
1560         * aix-thread.c: Revert.
1561         * agent.c: Revert.
1562         * addrmap.c: Revert.
1563         * ada-varobj.c: Revert.
1564         * ada-valprint.c: Revert.
1565         * ada-typeprint.c: Revert.
1566         * ada-tasks.c: Revert.
1567         * ada-lang.c: Revert.
1568         * aarch64-tdep.c: Revert.
1569         * aarch64-ravenscar-thread.c: Revert.
1570         * aarch64-newlib-tdep.c: Revert.
1571         * aarch64-linux-tdep.c: Revert.
1572         * aarch64-linux-nat.c: Revert.
1573         * aarch64-fbsd-tdep.c: Revert.
1574         * aarch64-fbsd-nat.c: Revert.
1575         * aarch32-linux-nat.c: Revert.
1576
1577 2019-04-05  Tom Tromey  <tom@tromey.com>
1578
1579         * ft32-tdep.c: Sort headers.
1580         * frv-tdep.c: Sort headers.
1581         * frv-linux-tdep.c: Sort headers.
1582         * frame.c: Sort headers.
1583         * frame-unwind.c: Sort headers.
1584         * frame-base.c: Sort headers.
1585         * fork-child.c: Sort headers.
1586         * findvar.c: Sort headers.
1587         * findcmd.c: Sort headers.
1588         * filesystem.c: Sort headers.
1589         * filename-seen-cache.h: Sort headers.
1590         * filename-seen-cache.c: Sort headers.
1591         * fbsd-tdep.c: Sort headers.
1592         * fbsd-nat.h: Sort headers.
1593         * fbsd-nat.c: Sort headers.
1594         * f-valprint.c: Sort headers.
1595         * f-typeprint.c: Sort headers.
1596         * f-lang.c: Sort headers.
1597         * extension.h: Sort headers.
1598         * extension.c: Sort headers.
1599         * extension-priv.h: Sort headers.
1600         * expprint.c: Sort headers.
1601         * exec.h: Sort headers.
1602         * exec.c: Sort headers.
1603         * exceptions.c: Sort headers.
1604         * event-top.c: Sort headers.
1605         * event-loop.c: Sort headers.
1606         * eval.c: Sort headers.
1607         * elfread.c: Sort headers.
1608         * dwarf2read.h: Sort headers.
1609         * dwarf2read.c: Sort headers.
1610         * dwarf2loc.c: Sort headers.
1611         * dwarf2expr.h: Sort headers.
1612         * dwarf2expr.c: Sort headers.
1613         * dwarf2-frame.c: Sort headers.
1614         * dwarf2-frame-tailcall.c: Sort headers.
1615         * dwarf-index-write.h: Sort headers.
1616         * dwarf-index-write.c: Sort headers.
1617         * dwarf-index-common.c: Sort headers.
1618         * dwarf-index-cache.h: Sort headers.
1619         * dwarf-index-cache.c: Sort headers.
1620         * dummy-frame.c: Sort headers.
1621         * dtrace-probe.c: Sort headers.
1622         * disasm.h: Sort headers.
1623         * disasm.c: Sort headers.
1624         * disasm-selftests.c: Sort headers.
1625         * dictionary.c: Sort headers.
1626         * dicos-tdep.c: Sort headers.
1627         * demangle.c: Sort headers.
1628         * dcache.h: Sort headers.
1629         * dcache.c: Sort headers.
1630         * darwin-nat.h: Sort headers.
1631         * darwin-nat.c: Sort headers.
1632         * darwin-nat-info.c: Sort headers.
1633         * d-valprint.c: Sort headers.
1634         * d-namespace.c: Sort headers.
1635         * d-lang.c: Sort headers.
1636         * ctf.c: Sort headers.
1637         * csky-tdep.c: Sort headers.
1638         * csky-linux-tdep.c: Sort headers.
1639         * cris-tdep.c: Sort headers.
1640         * cris-linux-tdep.c: Sort headers.
1641         * cp-valprint.c: Sort headers.
1642         * cp-support.c: Sort headers.
1643         * cp-namespace.c: Sort headers.
1644         * cp-abi.c: Sort headers.
1645         * corelow.c: Sort headers.
1646         * corefile.c: Sort headers.
1647         * continuations.c: Sort headers.
1648         * completer.h: Sort headers.
1649         * completer.c: Sort headers.
1650         * complaints.c: Sort headers.
1651         * coffread.c: Sort headers.
1652         * coff-pe-read.c: Sort headers.
1653         * cli-out.h: Sort headers.
1654         * cli-out.c: Sort headers.
1655         * charset.c: Sort headers.
1656         * c-varobj.c: Sort headers.
1657         * c-valprint.c: Sort headers.
1658         * c-typeprint.c: Sort headers.
1659         * c-lang.c: Sort headers.
1660         * buildsym.c: Sort headers.
1661         * buildsym-legacy.c: Sort headers.
1662         * build-id.h: Sort headers.
1663         * build-id.c: Sort headers.
1664         * btrace.c: Sort headers.
1665         * bsd-uthread.c: Sort headers.
1666         * breakpoint.h: Sort headers.
1667         * breakpoint.c: Sort headers.
1668         * break-catch-throw.c: Sort headers.
1669         * break-catch-syscall.c: Sort headers.
1670         * break-catch-sig.c: Sort headers.
1671         * blockframe.c: Sort headers.
1672         * block.c: Sort headers.
1673         * bfin-tdep.c: Sort headers.
1674         * bfin-linux-tdep.c: Sort headers.
1675         * bfd-target.c: Sort headers.
1676         * bcache.c: Sort headers.
1677         * ax-general.c: Sort headers.
1678         * ax-gdb.h: Sort headers.
1679         * ax-gdb.c: Sort headers.
1680         * avr-tdep.c: Sort headers.
1681         * auxv.c: Sort headers.
1682         * auto-load.c: Sort headers.
1683         * arm-wince-tdep.c: Sort headers.
1684         * arm-tdep.c: Sort headers.
1685         * arm-symbian-tdep.c: Sort headers.
1686         * arm-pikeos-tdep.c: Sort headers.
1687         * arm-obsd-tdep.c: Sort headers.
1688         * arm-nbsd-tdep.c: Sort headers.
1689         * arm-nbsd-nat.c: Sort headers.
1690         * arm-linux-tdep.c: Sort headers.
1691         * arm-linux-nat.c: Sort headers.
1692         * arm-fbsd-tdep.c: Sort headers.
1693         * arm-fbsd-nat.c: Sort headers.
1694         * arm-bsd-tdep.c: Sort headers.
1695         * arch-utils.c: Sort headers.
1696         * arc-tdep.c: Sort headers.
1697         * arc-newlib-tdep.c: Sort headers.
1698         * annotate.h: Sort headers.
1699         * annotate.c: Sort headers.
1700         * amd64-windows-tdep.c: Sort headers.
1701         * amd64-windows-nat.c: Sort headers.
1702         * amd64-tdep.c: Sort headers.
1703         * amd64-sol2-tdep.c: Sort headers.
1704         * amd64-obsd-tdep.c: Sort headers.
1705         * amd64-obsd-nat.c: Sort headers.
1706         * amd64-nbsd-tdep.c: Sort headers.
1707         * amd64-nbsd-nat.c: Sort headers.
1708         * amd64-nat.c: Sort headers.
1709         * amd64-linux-tdep.c: Sort headers.
1710         * amd64-linux-nat.c: Sort headers.
1711         * amd64-fbsd-tdep.c: Sort headers.
1712         * amd64-fbsd-nat.c: Sort headers.
1713         * amd64-dicos-tdep.c: Sort headers.
1714         * amd64-darwin-tdep.c: Sort headers.
1715         * amd64-bsd-nat.c: Sort headers.
1716         * alpha-tdep.c: Sort headers.
1717         * alpha-obsd-tdep.c: Sort headers.
1718         * alpha-nbsd-tdep.c: Sort headers.
1719         * alpha-mdebug-tdep.c: Sort headers.
1720         * alpha-linux-tdep.c: Sort headers.
1721         * alpha-linux-nat.c: Sort headers.
1722         * alpha-bsd-tdep.c: Sort headers.
1723         * alpha-bsd-nat.c: Sort headers.
1724         * aix-thread.c: Sort headers.
1725         * agent.c: Sort headers.
1726         * addrmap.c: Sort headers.
1727         * ada-varobj.c: Sort headers.
1728         * ada-valprint.c: Sort headers.
1729         * ada-typeprint.c: Sort headers.
1730         * ada-tasks.c: Sort headers.
1731         * ada-lang.c: Sort headers.
1732         * aarch64-tdep.c: Sort headers.
1733         * aarch64-ravenscar-thread.c: Sort headers.
1734         * aarch64-newlib-tdep.c: Sort headers.
1735         * aarch64-linux-tdep.c: Sort headers.
1736         * aarch64-linux-nat.c: Sort headers.
1737         * aarch64-fbsd-tdep.c: Sort headers.
1738         * aarch64-fbsd-nat.c: Sort headers.
1739         * aarch32-linux-nat.c: Sort headers.
1740
1741 2019-04-04  Tom Tromey  <tom@tromey.com>
1742
1743         * varobj.c (varobj_create): Update.
1744         * rust-exp.y (struct rust_parser) <update_innermost_block,
1745         lookup_symbol>: New methods.
1746         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1747         Rename.
1748         (rust_parser::rust_lookup_type)
1749         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1750         * printcmd.c (display_command, do_one_display): Update.
1751         * parser-defs.h (struct parser_state) <parser_state>: Add
1752         "tracker" parameter.
1753         (block_tracker): New member.
1754         (class innermost_block_tracker) <innermost_block_tracker>: Add
1755         "types" parameter.
1756         <reset>: Remove method.
1757         (innermost_block): Don't declare.
1758         (null_post_parser): Update.
1759         * parse.c (innermost_block): Remove global.
1760         (write_dollar_variable): Update.
1761         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1762         Remove "tracker_types" parameter.
1763         (parse_expression): Add "tracker" parameter.
1764         (parse_expression_for_completion): Update.
1765         (null_post_parser): Add "tracker" parameter.
1766         * p-exp.y: Update rules.
1767         * m2-exp.y: Update rules.
1768         * language.h (struct language_defn) <la_post_parser>: Add
1769         "tracker" parameter.
1770         * go-exp.y: Update rules.
1771         * f-exp.y: Update rules.
1772         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1773         parameter.
1774         * d-exp.y: Update rules.
1775         * c-exp.y: Update rules.
1776         * breakpoint.c (set_breakpoint_condition): Create an
1777         innermost_block_tracker.
1778         (watch_command_1): Likewise.
1779         * ada-lang.c (resolve): Add "tracker" parameter.
1780         (resolve_subexp): Likewise.
1781         * ada-exp.y (write_var_from_sym): Update.
1782
1783 2019-04-04  Tom Tromey  <tom@tromey.com>
1784
1785         * type-stack.h: New file.
1786         * type-stack.c: New file.
1787         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1788         type-stack.h.
1789         (insert_into_type_stack, insert_type, push_type, push_type_int)
1790         (insert_type_address_space, pop_type, pop_type_int)
1791         (pop_typelist, pop_type_stack, append_type_stack)
1792         (push_type_stack, get_type_stack, push_typelist)
1793         (follow_type_instance_flags, follow_types): Don't declare.
1794         * parse.c (type_stack): Remove global.
1795         (parse_exp_in_context): Update.
1796         (insert_into_type_stack, insert_type, push_type, push_type_int)
1797         (insert_type_address_space, pop_type, pop_type_int)
1798         (pop_typelist, pop_type_stack, append_type_stack)
1799         (push_type_stack, get_type_stack, push_typelist)
1800         (follow_type_instance_flags, follow_types): Remove (moved to
1801         type-stack.c).
1802         * f-exp.y (type_stack): New global.
1803         Update rules.
1804         (push_kind_type, f_parse): Update.
1805         * d-exp.y (type_stack): New global.
1806         Update rules.
1807         (d_parse): Update.
1808         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1809         Update rules.
1810         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1811         (HFILES_NO_SRCDIR): Add type-stack.h.
1812
1813 2019-04-04  Tom Tromey  <tom@tromey.com>
1814
1815         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1816         (rust_parser::convert_ast_to_expression, rust_parse)
1817         (rust_lex_test_completion, rust_lex_tests): Update.
1818         * parser-defs.h (struct expr_completion_state): New.
1819         (struct parser_state) <parser_state>: Add completion parameter.
1820         <mark_struct_expression, mark_completion_tag>: New methods.
1821         <parse_completion, m_completion_state>: New members.
1822         (prefixify_expression, null_post_parser): Update.
1823         (mark_struct_expression, mark_completion_tag): Don't declare.
1824         * parse.c (parse_completion, expout_last_struct)
1825         (expout_tag_completion_type, expout_completion_name): Remove
1826         globals.
1827         (parser_state::mark_struct_expression)
1828         (parser_state::mark_completion_tag): Now methods.
1829         (prefixify_expression): Add last_struct parameter.
1830         (prefixify_subexp): Likewise.
1831         (parse_exp_1): Update.
1832         (parse_exp_in_context): Add cstate parameter.  Update.
1833         (parse_expression_for_completion): Create an
1834         expr_completion_state.
1835         (null_post_parser): Add "completion" parameter.
1836         * p-exp.y: Update rules.
1837         (yylex): Update.
1838         * language.h (struct language_defn) <la_post_parser>: Add
1839         "completing" parameter.
1840         * go-exp.y: Update rules.
1841         (lex_one_token): Update.
1842         * expression.h (parse_completion): Don't declare.
1843         * d-exp.y: Update rules.
1844         (lex_one_token): Update rules.
1845         * c-exp.y: Update rules.
1846         (lex_one_token): Update.
1847         * ada-lang.c (resolve): Add "parse_completion" parameter.
1848         (resolve_subexp): Likewise.
1849         (ada_resolve_function): Likewise.
1850
1851 2019-04-04  Tom Tromey  <tom@tromey.com>
1852
1853         * parser-defs.h (struct parser_state) <start_arglist,
1854         end_arglist>: New methods.
1855         <arglist_len, m_funcall_chain>: New members.
1856         (arglist_len, start_arglist, end_arglist): Don't declare.
1857         * parse.c (arglist_len, funcall_chain): Remove global.
1858         (start_arglist, end_arglist): Remove functions.
1859         (parse_exp_in_context): Update.
1860         * p-exp.y: Update rules.
1861         * m2-exp.y: Update rules.
1862         * go-exp.y: Update rules.
1863         * f-exp.y: Update rules.
1864         * d-exp.y: Update rules.
1865         * c-exp.y: Update rules.
1866
1867 2019-04-04  Tom Tromey  <tom@tromey.com>
1868
1869         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1870         lex_operator, push_back>: New methods.
1871         Update all rules.
1872         (rust_parser::lex_hex, lex_escape): Rename and update.
1873         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1874         (rust_parser::lex_operator): Rename and update.
1875         (rust_parser::lex_number, rustyylex, rustyyerror)
1876         (rust_lex_test_init, rust_lex_test_sequence)
1877         (rust_lex_test_push_back, rust_lex_tests): Update.
1878         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1879         parameter.
1880         <lexptr, prev_lexptr>: New members.
1881         (lexptr, prev_lexptr): Don't declare.
1882         * parse.c (lexptr, prev_lexptr): Remove globals.
1883         (parse_exp_in_context): Update.
1884         * p-exp.y (yylex, yyerror): Update.
1885         * m2-exp.y (parse_number, yylex, yyerror): Update.
1886         * go-exp.y (lex_one_token, yyerror): Update.
1887         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1888         * d-exp.y (lex_one_token, yyerror): Update.
1889         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1890         (lex_one_token, yyerror): Update.
1891         * ada-lex.l (YY_INPUT): Update.
1892         (rewind_to_char): Update.
1893         * ada-exp.y (yyerror): Update.
1894
1895 2019-04-04  Tom Tromey  <tom@tromey.com>
1896
1897         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1898         * parser-defs.h (struct parser_state) <parser_state>: Add new
1899         parameter.
1900         <comma_terminates>: New member.
1901         (comma_terminates): Don't declare global.
1902         * parse.c (comma_terminates): Remove global.
1903         (parse_exp_in_context): Update.
1904         * p-exp.y (yylex): Update.
1905         * m2-exp.y (yylex): Update.
1906         * go-exp.y (lex_one_token): Update.
1907         * f-exp.y (yylex): Update.
1908         * d-exp.y (lex_one_token): Update.
1909         * c-exp.y (lex_one_token): Update.
1910         * ada-lex.l: Update.
1911
1912 2019-04-04  Tom Tromey  <tom@tromey.com>
1913
1914         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1915         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1916         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1917         * parser-defs.h (paren_depth): Don't declare.
1918         * parse.c (paren_depth): Remove global.
1919         (parse_exp_in_context): Update.
1920         * p-exp.y (paren_depth): New global.
1921         (pascal_parse): Initialize it.
1922         * m2-exp.y (paren_depth): New global.
1923         (m2_parse): Initialize it.
1924         * go-exp.y (paren_depth): New global.
1925         (go_parse): Initialize it.
1926         * f-exp.y (paren_depth): New global.
1927         (f_parse): Initialize it.
1928         * d-exp.y (paren_depth): New global.
1929         (d_parse): Initialize it.
1930         * c-exp.y (paren_depth): New global.
1931         (c_parse): Initialize it.
1932         * ada-lex.l (paren_depth): New global.
1933         (lexer_init): Initialize it.
1934
1935 2019-04-04  Tom Tromey  <tom@tromey.com>
1936
1937         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1938         (rust_parser::convert_ast_to_type)
1939         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1940         * parser-defs.h (struct parser_state) <parser_state>: Add
1941         parameters.  Initialize new members.
1942         <expression_context_block, expression_context_pc>: New members.
1943         * parse.c (expression_context_block, expression_context_pc):
1944         Remove globals.
1945         (parse_exp_in_context): Update.
1946         * p-exp.y: Update all rules.
1947         (yylex): Update.
1948         * m2-exp.y: Update all rules.
1949         (yylex): Update.
1950         * go-exp.y (yylex): Update.
1951         * f-exp.y (yylex): Update.
1952         * d-exp.y: Update all rules.
1953         (yylex): Update.
1954         * c-exp.y: Update all rules.
1955         (lex_one_token, classify_name, yylex, c_parse): Update.
1956         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1957
1958 2019-04-04  Tom Tromey  <tom@tromey.com>
1959
1960         * gdbarch.h, gdbarch.c: Rebuild.
1961         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1962         * stap-probe.h:
1963         (struct stap_parse_info): Replace "parser_state" with
1964         "expr_builder".
1965         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1966         (parser_state): New class.
1967         * parse.c (expr_builder): Rename.
1968         (expr_builder::release): Rename.
1969         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1970         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1971         (write_exp_elt_longcst, write_exp_elt_floatcst)
1972         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1973         (write_exp_string_vector, write_exp_bitstring)
1974         (write_exp_msymbol, mark_struct_expression)
1975         (write_dollar_variable)
1976         (insert_type_address_space, increase_expout_size): Replace
1977         "parser_state" with "expr_builder".
1978         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1979         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1980         "parser_state" with "expr_builder".
1981
1982 2019-04-04  Tom Tromey  <tom@tromey.com>
1983
1984         * rust-exp.y: Replace "parse_language" with method call.
1985         * p-exp.y:
1986         (yylex): Replace "parse_language" with method call.
1987         * m2-exp.y:
1988         (yylex): Replace "parse_language" with method call.
1989         * go-exp.y (classify_name): Replace "parse_language" with method
1990         call.
1991         * f-exp.y (yylex): Replace "parse_language" with method call.
1992         * d-exp.y (lex_one_token): Replace "parse_language" with method
1993         call.
1994         * c-exp.y:
1995         (lex_one_token, classify_name, yylex): Replace "parse_language"
1996         with method call.
1997         * ada-exp.y (find_primitive_type, type_char)
1998         (type_system_address): Replace "parse_language" with method call.
1999
2000 2019-04-04  Tom Tromey  <tom@tromey.com>
2001
2002         * rust-exp.y: Replace "parse_gdbarch" with method call.
2003         * parse.c (write_dollar_variable, insert_type_address_space):
2004         Replace "parse_gdbarch" with method call.
2005         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2006         call.
2007         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2008         call.
2009         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2010         "parse_gdbarch" with method call.
2011         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2012         with method call.
2013         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2014         "parse_gdbarch" with method call.
2015         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2016         "parse_gdbarch" with method call.
2017         * c-exp.y (parse_type, parse_number, classify_name): Replace
2018         "parse_gdbarch" with method call.
2019         * ada-lex.l: Replace "parse_gdbarch" with method call.
2020         * ada-exp.y (parse_type, find_primitive_type, type_char)
2021         (type_system_address): Replace "parse_gdbarch" with method call.
2022
2023 2019-04-04  Tom Tromey  <tom@tromey.com>
2024
2025         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2026         * stap-probe.c (stap_parse_argument): Update.
2027         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2028         initial_size parameter.
2029         * rust-exp.y (rust_lex_tests): Update.
2030         * parse.c (parser_state): Update.
2031         (parse_exp_in_context): Update.
2032         * parser-defs.h (struct parser_state) <parser_state>: Remove
2033         "initial_size" parameter.
2034
2035 2019-04-04  Tom Tromey  <tom@tromey.com>
2036
2037         * parser-defs.h (increase_expout_size): Don't declare.
2038         * parse.c (increase_expout_size): Now static.
2039
2040 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2041
2042         * gnu-nat.c (gnu_nat_target::wait): Fix
2043         target_waitstatus_to_string call.
2044
2045 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2046
2047         * eval.c (evaluate_subexp_standard): Handle internal functions
2048         during Fortran function call handling.
2049
2050 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2051
2052         * NEWS: Mention new internal functions.
2053         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2054         (read_base_type): Use dwarf2_init_complex_target_type.
2055         * value.c (creal_internal_fn): New function.
2056         (cimag_internal_fn): New function.
2057         (_initialize_values): Register new internal functions.
2058
2059 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2060
2061         * infrun.c (stop_all_threads): If debug_infrun, always
2062         trace the wait status after wait_one, using
2063         target_waitstatus_to_string and target_pid_to_str.
2064         (handle_inferior_event): Replace various trace of
2065         wait status kind by a single trace.
2066         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2067         wait status kind image by target_waitstatus_to_string.
2068         * target/waitstatus.c (target_waitstatus_to_string): Fix
2069         obsolete comment.
2070
2071 2019-04-01  Tom Tromey  <tromey@adacore.com>
2072
2073         PR symtab/23331:
2074         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2075
2076 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2077             Pedro Alves  <palves@redhat.com>
2078
2079         * top.c (quit_force): Call 'finalize_values'.
2080         * value.c (finalize_values): New function.
2081         * value.h (finalize_values): Declare.
2082
2083 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2084
2085         * NEWS: Announce $_gdb_major and $_gdb_minor.
2086
2087         * top.c (init_gdb_version_vars): New function.
2088         (gdb_init): Call init_gdb_version_vars.
2089
2090 2019-03-29  Tom Tromey  <tromey@adacore.com>
2091
2092         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2093         help text.  Remove dead code.
2094
2095 2019-03-29  Keith Seitz  <keiths@redhat.com>
2096
2097         From Siddhesh Poyarekar:
2098         * f-lang.h (f77_get_upperbound): Return LONGEST.
2099         (f77_get_lowerbound): Likewise.
2100         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2101         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2102         print them.
2103         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2104         plongest to format print it.
2105         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2106         (f77_get_upperbound): Likewise.
2107         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2108         LOWER_BOUND to LONGEST.
2109         (f77_create_arrayprint_offset_tbl): Likewise.
2110
2111 2019-03-29  Keith Seitz  <keiths@redhat.com>
2112
2113         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2114         %s/pulongest for TYPE_LENGTH instead of %d in format
2115         strings.
2116         * ada-typerint.c (ada_print_type): Likewise.
2117         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2118         * compile/compile-c-support.c (generate_register_struct): Likewise.
2119         * gdbtypes.c (recursive_dump_type): Likewise.
2120         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2121         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2122         instead of %d in format strings.
2123         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2124         to std::min to ULONGEST.
2125         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2126         instead of %d in format strings.
2127         * tracepoint.c (info_scope_command): Likewise.
2128         * typeprint.c (print_offset_data::update)
2129         (print_offset_data::finish): Likewise.
2130         * xtensa-tdep.c (xtensa_store_return_value)
2131         (xtensa_push_dummy_call): Likewise.
2132
2133 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2134
2135         * windows-nat.c (display_selector): Fixed format specifications
2136         for 64-bit Cygwin.
2137
2138 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2139
2140         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2141
2142 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2143
2144         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2145         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2146         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2147         (nios2_linux_init_abi): Install it.
2148
2149 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2150
2151         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2152
2153 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2154
2155         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2156
2157 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2158             Tom Tromey  <tromey@adacore.com>
2159
2160         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2161
2162 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2163
2164         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2165         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2166         method to compute the bounds of range types. Also print "[evaluated]"
2167         if the bounds' values come from a dynamic evaluation.
2168
2169 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2170
2171         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2172         whitespace when pretty printing is on.
2173
2174 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2175
2176         * ppc-linux-nat.c: Add include.
2177
2178 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2179
2180         * NEWS: Mention AArch64 Pointer Authentication.
2181
2182 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2183
2184         * arm-linux-nat.c: Add include.
2185
2186 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2187
2188         * source-cache.c (source_cache::get_source_lines): Re-read
2189         fullname after calling open_source_file.
2190
2191 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2192
2193         * NEWS: Mention TLS support for FreeBSD.
2194
2195 2019-03-25  Tom Tromey  <tromey@adacore.com>
2196
2197         * minsyms.c (BUNCH_SIZE): Update comment.
2198         (~minimal_symbol_reader): Remove old comment.
2199         (compact_minimal_symbols): Update comment.
2200         (minimal_symbol_reader::install): Remove old comment.  Update
2201         other comments.
2202
2203 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2204
2205         * s390-linux-nat.c: Add include.
2206
2207 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2208
2209         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2210         Call linux_get_hwcap.
2211         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2212         Likewise.
2213         (aarch64_linux_get_hwcap): Remove function.
2214         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2215         declaration.
2216         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2217         linux_get_hwcap.
2218         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2219         * linux-tdep.c (linux_get_hwcap): Add function.
2220         (linux_get_hwcap2): Likewise.
2221         * linux-tdep.h (linux_get_hwcap): Add declaration.
2222         (linux_get_hwcap2): Likewise.
2223         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2224         (ppc_linux_get_hwcap2): Likewise.
2225         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2226         linux_get_hwcap.
2227         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2228         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2229         (ppc_linux_nat_target::read_description): Likewise.
2230         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2231         * s390-linux-nat.c: Likewise.
2232         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2233
2234 2019-03-24  Tom Tromey  <tom@tromey.com>
2235
2236         * ada-lang.c (standard_lookup): Simplify initialization.
2237         (ada_lookup_symbol_nonlocal): Simplify return.
2238         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2239         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2240         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2241         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2242         initialization.
2243         * solib.c (solib_global_lookup): Simplify.
2244         * symtab.c (null_block_symbol): Remove.
2245         (symbol_cache_lookup): Simplify returns.
2246         (lookup_language_this): Simplify returns.
2247         (lookup_symbol_aux): Simplify return.
2248         (lookup_local_symbol): Simplify returns.
2249         (lookup_global_symbol_from_objfile): Simplify return.
2250         (lookup_symbol_in_objfile_symtabs)
2251         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2252         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2253         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2254         * cp-namespace.c (cp_lookup_bare_symbol)
2255         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2256         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2257         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2258         (cp_lookup_symbol_via_imports): Simplify initialization.
2259         (find_symbol_in_baseclass): Likewise.
2260         * symtab.h (null_block_symbol): Remove.
2261         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2262         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2263         (d_lookup_symbol_module): Likewise.
2264         (find_symbol_in_baseclass): Simplify initialization.
2265
2266 2019-03-24  Tom Tromey  <tom@tromey.com>
2267
2268         * expression.h: Don't include symtab.h.
2269         (struct block): Forward declare.
2270
2271 2019-03-24  Tom Tromey  <tom@tromey.com>
2272
2273         * c-exp.y (typebase): Remove casts.
2274         * gdbtypes.c (lookup_unsigned_typename, )
2275         (lookup_signed_typename): Remove cast.
2276         * eval.c (parse_to_comma_and_eval): Remove cast.
2277         * parse.c (write_dollar_variable): Remove cast.
2278         * block.h (struct block) <superblock>: Now const.
2279         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2280         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2281         (map_block): Make "block" const.
2282         * symfile.h (struct quick_symbol_functions)
2283         <map_matching_symbols>: Constify block argument to "callback".
2284         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2285         const.
2286         (find_pc_sect_compunit_symtab): Make "b" const.
2287         (find_symbol_at_address): Likewise.
2288         (search_symbols): Likewise.
2289         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2290         (dw2_debug_names_lookup_symbol): Likewise.
2291         (dw2_map_matching_symbols): Update.
2292         * p-valprint.c (pascal_val_print): Remove "block".
2293         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2294         (aux_add_nonlocal_symbols): Make "block" const.
2295         (resolve_subexp): Remove cast.
2296         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2297         const.
2298         (iterate_over_file_blocks): Likewise.
2299         * f-exp.y (%union) <bval>: Remove.
2300         * coffread.c (patch_opaque_types): Make "b" const.
2301         * spu-tdep.c (spu_catch_start): Make "block" const.
2302         * c-valprint.c (print_unpacked_pointer): Remove "block".
2303         * symmisc.c (dump_symtab_1): Make "b" const.
2304         (block_depth): Make "block" const.
2305         * d-exp.y (%union) <bval>: Remove.
2306         * cp-support.h (cp_lookup_rtti_type): Update.
2307         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2308         * psymtab.c (psym_lookup_symbol): Make "block" const.
2309         (maintenance_check_psymtabs): Make "b" const.
2310         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2311         (enumerate_locals, enumerate_args): Update.
2312         * python/py-symtab.c (stpy_global_block): Make "block" const.
2313         (stpy_static_block): Likewise.
2314         * inline-frame.c (block_starting_point_at): Make "new_block"
2315         const.
2316         * block.c (find_block_in_blockvector): Make return type const.
2317         (blockvector_for_pc_sect): Make "b" const.
2318         (find_block_in_blockvector): Make "b" const.
2319
2320 2019-03-23  Tom Tromey  <tom@tromey.com>
2321
2322         * varobj.c (varobj_create): Update.
2323         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2324         * printcmd.c (display_command, do_one_display): Don't reset
2325         innermost_block.
2326         * parser-defs.h (enum innermost_block_tracker_type): Move to
2327         expression.h.
2328         (innermost_block): Update comment.
2329         * parse.c (parse_exp_1): Add tracker_types parameter.
2330         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2331         tracker_types parameter.  Reset innermost_block.
2332         (parse_exp_in_context): Remove.
2333         (parse_expression_for_completion): Update.
2334         * objfiles.c (~objfile): Don't reset expression_context_block or
2335         innermost_block.
2336         * expression.h (enum innermost_block_tracker_type): Move from
2337         parser-defs.h.
2338         (parse_exp_1): Add tracker_types parameter.
2339         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2340         reset innermost_block.
2341
2342 2019-03-23  Tom Tromey  <tom@tromey.com>
2343
2344         * objfiles.h: Include bcache.h.
2345
2346 2019-03-23  Tom Tromey  <tom@tromey.com>
2347
2348         * linespec.c (get_current_search_block): Use
2349         scoped_restore_current_language.
2350         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2351
2352 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2353             Jiong Wang  <jiong.wang@arm.com>
2354
2355         * aarch64-linux-tdep.c
2356         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2357         section.
2358         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2359
2360 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2361             Jiong Wang  <jiong.wang@arm.com>
2362
2363         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2364         instructions.
2365         (aarch64_analyze_prologue_test): Add PACIASP test.
2366         (aarch64_prologue_prev_register): Unmask PC value.
2367
2368 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2369             Jiong Wang  <jiong.wang@arm.com>
2370
2371         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2372         (aarch64_dwarf2_prev_register): Unmask PC value.
2373         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2374         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2375         DW_CFA_AARCH64_negate_ra_state.
2376         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2377
2378 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2379             Jiong Wang  <jiong.wang@arm.com>
2380
2381         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2382         registers.
2383         (aarch64_pseudo_register_name): Likewise.
2384         (aarch64_pseudo_register_type): Likewise.
2385         (aarch64_pseudo_register_reggroup_p): Likewise.
2386         (aarch64_gdbarch_init): Add pauth registers.
2387         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2388         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2389         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2390         (struct gdbarch_tdep): Add regnum for ra_state.
2391
2392 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2393             Jiong Wang  <jiong.wang@arm.com>
2394
2395         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2396
2397 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2398             Jiong Wang  <jiong.wang@arm.com>
2399
2400         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2401         function.
2402         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2403         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2404         (aarch64_gdbarch_init): Add puth registers.
2405         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2406         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2407         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2408
2409 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2410             Jiong Wang  <jiong.wang@arm.com>
2411
2412         * aarch64-linux-nat.c
2413         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2414         * aarch64-linux-tdep.c
2415         (aarch64_linux_core_read_description): Likewise.
2416         (aarch64_linux_get_hwcap): New function.
2417         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2418         (aarch64_linux_get_hwcap): New declaration.
2419
2420 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2421             Jiong Wang  <jiong.wang@arm.com>
2422
2423         * aarch64-linux-nat.c
2424         (aarch64_linux_nat_target::read_description): Add pauth param.
2425         * aarch64-linux-tdep.c
2426         (aarch64_linux_core_read_description): Likewise.
2427         * aarch64-tdep.c (struct target_desc): Add in pauth.
2428         (aarch64_read_description): Add pauth param.
2429         (aarch64_gdbarch_init): Likewise.
2430         * aarch64-tdep.h (aarch64_read_description): Likewise.
2431         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2432         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2433         * features/Makefile: Add new files.
2434         * features/aarch64-pauth.c: New file.
2435         * features/aarch64-pauth.xml: New file.
2436
2437 2019-03-20  Tom Tromey  <tromey@adacore.com>
2438
2439         * infrun.c (handle_inferior_event): Rename from
2440         handle_inferior_event_1.  Create a scoped_value_mark.
2441         (handle_inferior_event): Remove.
2442
2443 2019-03-19  Tom Tromey  <tromey@adacore.com>
2444
2445         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2446         * infrun.h (print_stop_event): Add "displays" parameter.
2447         * infrun.c (print_stop_event): Add "displays" parameter.
2448
2449 2019-03-19  Pedro Alves  <palves@redhat.com>
2450
2451         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2452         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2453         to -1.  Fix TABs vs spaces.
2454         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2455         * tui/tui-out.h (tui_ui_out) Add intro comments.
2456         <m_line, m_start_of_line>: In-class initialize, and add describing
2457         comment.
2458
2459 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2460
2461         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2462         variable names.
2463         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2464
2465 2019-03-18  Pedro Alves  <palves@redhat.com>
2466             Eli Zaretskii <eliz@gnu.org>
2467
2468         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2469         m_line and m_start_of_line.
2470
2471 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2472
2473         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2474         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2475         it returns a newline.  This fixes a regression in TU mode, whereby
2476         the next line is output on the same screen line as the user input.
2477
2478 2019-03-18  Tom Tromey  <tromey@adacore.com>
2479
2480         * minsyms.c (minimal_symbol_reader::install): Remove call to
2481         obstack_blank.
2482
2483 2019-03-18  Pedro Alves  <palves@redhat.com>
2484
2485         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2486         New globals.
2487         (apply_style): New, factored out from ...
2488         (apply_ansi_escape): ... this.  Handle reverse video mode.
2489         (tui_set_reverse_mode): New function.
2490         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2491         * tui/tui-winsource.c (tui_show_source_line): Use
2492         tui_set_reverse_mode instead of setting A_STANDOUT.
2493         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2494         New setter methods.
2495
2496 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2497
2498         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2499         Handle tabs.
2500
2501 2019-03-18  Tom Tromey  <tromey@adacore.com>
2502
2503         * ada-lang.c (empty_array): Add "high" parameter.
2504         (ada_evaluate_subexp): Update.
2505
2506 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2507
2508         * unittests/string_view-selftests.c: Define
2509         _initialize_string_view_selftests unconditionally.
2510
2511 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2512
2513         PR gdb/24350
2514         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2515
2516 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2517
2518         PR gdb/24351
2519         * windows-nat.c (display_selector): Fix format specifiers.
2520
2521 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2522
2523         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2524         tui_refill_source_window instead of tui_refresh_win, to update the
2525         current execution line.  This fixes redisplay of the current line
2526         when stepping through the code with "next" or "step".
2527
2528 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2529
2530         * source-cache.c (source_cache::get_source_lines): Call
2531         find_source_lines to initialize s->nlines.  This fixes vertical
2532         scrolling of TUI source window when the DOWN arrow is pressed.
2533
2534 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2535
2536         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2537         linux-thread-db.c (_initialize_thread_db): Likewise.
2538
2539 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2540
2541         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2542         wclrtoeol in tui_show_source_line".  This reverts changes made in
2543         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2544
2545 2019-03-15  Tom Tromey  <tom@tromey.com>
2546
2547         * symtab.h (struct minimal_symbol): Derive from
2548         general_symbol_info.
2549         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2550         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2551         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2552         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2553         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2554         (MSYMBOL_SEARCH_NAME): Update.
2555         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2556         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2557         * minsyms.c (minimal_symbol_reader::record_full): Update.
2558
2559 2019-03-15  Tom Tromey  <tom@tromey.com>
2560
2561         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2562
2563 2019-03-15  Tom Tromey  <tom@tromey.com>
2564
2565         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2566         unique_xmalloc_ptr.
2567         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2568         Update.
2569         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2570         (build_minimal_symbol_hash_tables)
2571         (minimal_symbol_reader::install): Update.
2572
2573 2019-03-15  Tom Tromey  <tom@tromey.com>
2574
2575         * symtab.c (create_demangled_names_hash): Update.
2576         (symbol_set_names): Update.
2577         * objfiles.h (struct objfile_per_bfd_storage)
2578         <demangled_names_hash>: Now an htab_up.
2579         * objfiles.c (objfile_per_bfd_storage): Simplify.
2580
2581 2019-03-15  Tom Tromey  <tom@tromey.com>
2582
2583         * objfiles.h (struct objfile_per_bfd_storage): Declare
2584         destructor.
2585         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2586         New.
2587         (get_objfile_bfd_data): Use new.  Don't initialize
2588         language_of_main.
2589         (free_objfile_per_bfd_storage): Remove.
2590         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2591
2592 2019-03-15  Tom Tromey  <tom@tromey.com>
2593
2594         * symfile.c (reread_symbols): Update.
2595         * objfiles.c (objfile::objfile): Update.
2596         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2597         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2598         comment.
2599         (minimal_symbol_reader::install): Update.
2600         (terminate_minimal_symbol_table): Remove.
2601         * jit.c (jit_object_close_impl): Update.
2602
2603 2019-03-15  Tom Tromey  <tom@tromey.com>
2604
2605         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2606         initializations.
2607
2608 2019-03-15  Tom Tromey  <tom@tromey.com>
2609
2610         * objfiles.h (struct objfile_per_bfd_storage)
2611         <demangled_hash_languages>: Now a bitset.
2612         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2613         (lookup_minimal_symbol): Update.
2614
2615 2019-03-15  Tom Tromey  <tom@tromey.com>
2616
2617         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2618         Don't return the symbol.
2619         * coffread.c (record_minimal_symbol): Use record_full.
2620
2621 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2622
2623         The MS-Windows port of ncurses fails to switch to a color pair if
2624         one or both of the colors are the implicit default colors.  This
2625         change records the default colors when TUI is initialized, and
2626         then specifies them explicitly when a color pair uses the default
2627         colors.  This allows color styling in TUI mode on MS-Windows.
2628
2629         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2630         ncurses_norm_attr.
2631         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2632         colors in ncurses_norm_attr.
2633         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2634         "none", replace it with the default color recorded in
2635         ncurses_norm_attr.
2636
2637 2019-03-14  Tom Tromey  <tromey@adacore.com>
2638
2639         * source-cache.h (class source_cache) <get_source_lines>: Return
2640         std::string.
2641         * source-cache.c (source_cache::extract_lines): Handle case where
2642         first_pos==npos.  Return std::string.
2643         (source_cache::get_source_lines): Update.
2644
2645 2019-03-14  Tom Tromey  <tromey@adacore.com>
2646
2647         * NEWS: Add item for "style sources" commands.
2648         * source-cache.c (source_cache::get_source_lines): Check
2649         source_styling.
2650         * cli/cli-style.c (source_styling): New global.
2651         (_initialize_cli_style): Add "style sources" commands.
2652         (show_style_sources): New function.
2653         * cli/cli-style.h (source_styling): Declare.
2654
2655 2019-03-14  Pedro Alves  <palves@redhat.com>
2656             Tom Tromey  <tromey@adacore.com>
2657
2658         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2659         * tui/tui-winsource.c (tui_refill_source_window): New function,
2660         from...
2661         (tui_horizontal_source_scroll): ... here.  Move some logic.
2662         * cli/cli-style.c (set_style_enabled): Notify new observable.
2663         * tui/tui-hooks.c (tui_redisplay_source): New function.
2664         (tui_attach_detach_observers): Attach or detach
2665         tui_redisplay_source.
2666         * observable.h (source_styling_changed): New observable.
2667         * observable.c: Define source_styling_changed observable.
2668
2669 2019-03-13  Tom Tromey  <tromey@adacore.com>
2670
2671         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2672         (i386_gnu_nat_target::store_registers): Update.
2673         * target-debug.h (target_debug_print_std_string): New macro.
2674         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2675         * windows-tdep.c (display_one_tib): Update.
2676         * tui/tui-stack.c (tui_make_status_line): Update.
2677         * top.c (print_inferior_quit_action): Update.
2678         * thread.c (thr_try_catch_cmd): Update.
2679         (add_thread_with_info): Update.
2680         (thread_target_id_str): Update.
2681         (thr_try_catch_cmd): Update.
2682         (thread_command): Update.
2683         (thread_find_command): Update.
2684         * record-btrace.c (record_btrace_target::info_record)
2685         (record_btrace_resume_thread, record_btrace_target::resume)
2686         (record_btrace_cancel_resume, record_btrace_step_thread)
2687         (record_btrace_target::wait, record_btrace_target::wait)
2688         (record_btrace_target::wait, record_btrace_target::stop): Update.
2689         * progspace.c (print_program_space): Update.
2690         * process-stratum-target.c
2691         (process_stratum_target::thread_address_space): Update.
2692         * linux-fork.c (linux_fork_mourn_inferior)
2693         (detach_checkpoint_command, info_checkpoints_command)
2694         (linux_fork_context): Update.
2695         (linux_fork_detach): Update.
2696         (class scoped_switch_fork_info): Update.
2697         (delete_checkpoint_command): Update.
2698         * infrun.c (follow_fork_inferior): Update.
2699         (follow_fork_inferior): Update.
2700         (proceed_after_vfork_done): Update.
2701         (handle_vfork_child_exec_or_exit): Update.
2702         (follow_exec): Update.
2703         (displaced_step_prepare_throw): Update.
2704         (displaced_step_restore): Update.
2705         (start_step_over): Update.
2706         (resume_1): Update.
2707         (clear_proceed_status_thread): Update.
2708         (proceed): Update.
2709         (print_target_wait_results): Update.
2710         (do_target_wait): Update.
2711         (context_switch): Update.
2712         (stop_all_threads): Update.
2713         (restart_threads): Update.
2714         (finish_step_over): Update.
2715         (handle_signal_stop): Update.
2716         (switch_back_to_stepped_thread): Update.
2717         (keep_going_pass_signal): Update.
2718         (print_exited_reason): Update.
2719         (normal_stop): Update.
2720         * inferior.c (inferior_pid_to_str): Change return type.
2721         (print_selected_inferior): Update.
2722         (add_inferior): Update.
2723         (detach_inferior): Update.
2724         * dummy-frame.c (fprint_dummy_frames): Update.
2725         * dcache.c (dcache_info_1): Update.
2726         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2727         (btrace_fetch, btrace_clear): Update.
2728         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2729         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2730         type.
2731         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2732         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2733         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2734         * gdbarch.c, gdbarch.h: Rebuild.
2735         * gdbarch.sh (core_pid_to_str): Change return type.
2736         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2737         return type.
2738         (windows_nat_target::pid_to_str): Change return type.
2739         (windows_delete_thread): Update.
2740         (windows_nat_target::attach): Update.
2741         (windows_nat_target::files_info): Update.
2742         * target-delegates.c: Rebuild.
2743         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2744         return type.
2745         (sol_thread_target::pid_to_str): Change return type.
2746         * remote.c (class remote_target) <pid_to_str>: Change return
2747         type.
2748         (remote_target::pid_to_str): Change return type.
2749         (extended_remote_target::attach, remote_target::remote_stop_ns)
2750         (remote_target::remote_notif_remove_queued_reply)
2751         (remote_target::push_stop_reply, remote_target::disable_btrace):
2752         Update.
2753         (extended_remote_target::attach): Update.
2754         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2755         type.
2756         (gdbsim_target::pid_to_str): Change return type.
2757         * ravenscar-thread.c (struct ravenscar_thread_target)
2758         <pid_to_str>: Change return type.
2759         (ravenscar_thread_target::pid_to_str): Change return type.
2760         * procfs.c (class procfs_target) <pid_to_str>: Change return
2761         type.
2762         (procfs_target::pid_to_str): Change return type.
2763         (procfs_target::attach): Update.
2764         (procfs_target::detach): Update.
2765         (procfs_target::fetch_registers): Update.
2766         (procfs_target::store_registers): Update.
2767         (procfs_target::wait): Update.
2768         (procfs_target::files_info): Update.
2769         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2770         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2771         return type.
2772         (nto_procfs_target::pid_to_str): Change return type.
2773         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2774         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2775         return type.
2776         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2777         (exit_lwp): Update.
2778         (attach_proc_task_lwp_callback, get_detach_signal)
2779         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2780         (linux_nat_target::resume, wait_lwp, stop_callback)
2781         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2782         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2783         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2784         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2785         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2786         type.
2787         (inf_ptrace_target::attach): Update.
2788         (inf_ptrace_target::files_info): Update.
2789         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2790         type.
2791         (go32_nat_target::pid_to_str): Change return type.
2792         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2793         (gnu_nat_target::wait): Update.
2794         (gnu_nat_target::wait): Update.
2795         (gnu_nat_target::resume): Update.
2796         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2797         (fbsd_nat_target::wait): Update.
2798         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2799         type.
2800         (darwin_nat_target::attach): Update.
2801         * corelow.c (class core_target) <pid_to_str>: Change return type.
2802         (core_target::pid_to_str): Change return type.
2803         * target.c (normal_pid_to_str): Change return type.
2804         (default_pid_to_str): Likewise.
2805         (target_pid_to_str): Change return type.
2806         (target_translate_tls_address): Update.
2807         (target_announce_detach): Update.
2808         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2809         return type.
2810         (bsd_uthread_target::pid_to_str): Change return type.
2811         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2812         type.
2813         (bsd_kvm_target::pid_to_str): Change return type.
2814         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2815         return type.
2816         (aix_thread_target::pid_to_str): Change return type.
2817         * target.h (struct target_ops) <pid_to_str>: Change return type.
2818         (target_pid_to_str, normal_pid_to_str): Likewise.
2819         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2820         type.
2821         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2822         type.
2823         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2824         return type.
2825         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2826         type.
2827         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2828         type.
2829         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2830         return type.
2831
2832 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2833
2834         * NEWS: Mention that the new default MI version is 3.  Mention
2835         changes to the output of commands and events that deal with
2836         multi-location breakpoints.
2837         * breakpoint.c: Include "mi/mi-out.h".
2838         (print_one_breakpoint): Change output syntax if using MI version
2839         >= 3.
2840         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2841         New.
2842         (mi_multi_location_breakpoint_output_fixed): New.
2843         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2844         (mi_cmd_fix_multi_location_breakpoint_output): New.
2845         (mi_multi_location_breakpoint_output_fixed): New.
2846         * mi/mi-cmds.c (mi_cmds): Register command
2847         -fix-multi-location-breakpoint-output.
2848         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2849         interpreter "mi".
2850
2851 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2852
2853         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2854         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2855         instantiate mi_ui_out based on interpreter name.
2856         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2857         * mi/mi-main.c (mi_load_progress): Likewise.
2858
2859 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2860
2861         * NEWS: Combine separate "New targets" sections for 8.3.
2862
2863 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2864
2865         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2866         (ppcfbsd_init_abi): Install gdbarch
2867         "fetch_tls_load_module_address" and "get_thread_local_address"
2868         methods.
2869
2870 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2871
2872         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2873         (riscv_fbsd_init_abi): Install gdbarch
2874         "fetch_tls_load_module_address" and "get_thread_local_address"
2875         methods.
2876
2877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2878
2879         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2880         (i386fbsd_init_abi): Install gdbarch
2881         "fetch_tls_load_module_address" and "get_thread_local_address"
2882         methods.
2883
2884 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2885
2886         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2887         (amd64fbsd_init_abi): Install gdbarch
2888         "fetch_tls_load_module_address" and "get_thread_local_address"
2889         methods.
2890
2891 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2892
2893         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2894         (struct fbsd_pspace_data): New type.
2895         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2896         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2897         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2898         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2899         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2900
2901 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2902
2903         * gdbtypes.c (lookup_struct_elt): New function.
2904         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2905         * gdbtypes.h (struct struct_elt): New type.
2906         (lookup_struct_elt): New prototype.
2907
2908 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2909
2910         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2911         remove disabled code block.
2912
2913 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2914
2915         * gdbarch.sh (get_thread_local_address): New method.
2916         * gdbarch.h, gdbarch.c: Regenerate.
2917         * target.c (target_translate_tls_address): Use
2918         gdbarch_get_thread_local_address if present instead of
2919         target::get_thread_local_address.
2920
2921 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2922
2923         * target.h (target::get_thread_local_address): Update comment.
2924
2925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2926
2927         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2928         objfile->separate_debug_objfile_backlink if not NULL.
2929
2930 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2931
2932         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2933         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2934         (amd64bsd_store_inferior_registers): Likewise.
2935         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2936         Enable segment base registers.
2937         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2938         PT_GETFSBASE and PT_GETGSBASE.
2939         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2940         PT_SETGSBASE.
2941         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2942         segment base registers.
2943         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2944
2945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2946
2947         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2948         Update calls to i386_target_description to add 'segments'
2949         parameter.
2950         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2951         add segment base registers.
2952         * arch/i386.c (i386_create_target_description): Add 'segments'
2953         parameter to enable segment base registers.
2954         * arch/i386.h (i386_create_target_description): Likewise.
2955         * features/i386/32bit-segments.xml: New file.
2956         * features/i386/32bit-segments.c: Generate.
2957         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2958         call to i386_target_description to add 'segments' parameter.
2959         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2960         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2961         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2962         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2963         if feature is present.
2964         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2965         Add 'segments' parameter to call to i386_target_description.
2966         (i386_target_description): Add 'segments' parameter to enable
2967         segment base registers.
2968         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2969         to call to i386_target_description.
2970         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2971         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2972         Define I386_NUM_REGS.
2973         (i386_target_description): Add 'segments' parameter to enable
2974         segment base registers.
2975
2976 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2977
2978         PR/24325
2979         * source-cache.c: #undef open and close, to avoid unresolved
2980         externals during linking.
2981
2982 2019-03-12  Tom Tromey  <tromey@adacore.com>
2983
2984         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2985         const.  Add initializers.
2986         (_initialize_remote): Don't initialize ptid globals.
2987
2988 2019-03-12  Pedro Alves  <palves@redhat.com>
2989
2990         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2991
2992 2019-03-12  Pedro Alves  <palves@redhat.com>
2993
2994         * cp-name-parser.y (main): Remove unused 'len' variable.
2995
2996 2019-03-12  Tom Tromey  <tromey@adacore.com>
2997
2998         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2999         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3000
3001 2019-03-12  Tom Tromey  <tromey@adacore.com>
3002
3003         * linux-nat.c (iterate_over_lwps): Update.
3004         (stop_callback): Remove parameter.
3005         (stop_wait_callback, detach_callback, resume_set_callback)
3006         (select_singlestep_lwp_callback, set_ignore_sigint)
3007         (status_callback, resumed_callback, resume_clear_callback)
3008         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3009         data parameter.
3010         (linux_nat_target::detach, linux_nat_target::resume)
3011         (linux_stop_and_wait_all_lwps, select_event_lwp)
3012         (linux_nat_filter_event, linux_nat_wait_1)
3013         (linux_nat_target::kill, linux_nat_target::stop)
3014         (linux_nat_target::stop): Update.
3015         (linux_nat_resume_callback): Change type.
3016         (resume_stopped_resumed_lwps, count_events_callback)
3017         (select_event_lwp_callback): Likewise.
3018         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3019         * arm-linux-nat.c (struct update_registers_data): Remove.
3020         (update_registers_callback): Change type.
3021         (arm_linux_insert_hw_breakpoint1): Update.
3022         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3023         parameter.
3024         (x86_linux_dr_set_addr): Update.
3025         (x86_linux_dr_set_control): Update.
3026         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3027         (iterate_over_lwps): Use gdb::function_view.
3028         * nat/aarch64-linux-hw-point.c (struct
3029         aarch64_dr_update_callback_param): Remove.
3030         (debug_reg_change_callback): Change type.
3031         (aarch64_notify_debug_reg_change): Update.
3032         * s390-linux-nat.c (s390_refresh_per_info): Update.
3033
3034 2019-03-11  Tom Tromey  <tromey@adacore.com>
3035
3036         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3037         redundant assignment to "this_cu".
3038
3039 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3040
3041         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3042
3043 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3044
3045         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3046         from...
3047         (rank_one_type): ... this.
3048
3049 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3050
3051         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3052         from...
3053         (rank_one_type): ... this.
3054
3055 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3056
3057         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3058         from...
3059         (rank_one_type): ... this.
3060
3061 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3062
3063         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3064         from...
3065         (rank_one_type): ... this.
3066
3067 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3068
3069         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3070         from...
3071         (rank_one_type): ... this.
3072
3073 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3074
3075         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3076         from...
3077         (rank_one_type): ... this.
3078
3079 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3080
3081         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3082         from...
3083         (rank_one_type): ... this.
3084
3085 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3086
3087         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3088         from...
3089         (rank_one_type): ... this.
3090
3091 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3092
3093         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3094         from...
3095         (rank_one_type): ... this.
3096
3097 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3098
3099         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3100         from...
3101         (rank_one_type): ... this.
3102
3103 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3104
3105         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3106         from...
3107         (rank_one_type): ... this.
3108
3109 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3110
3111         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3112         from...
3113         (rank_one_type): ... this.
3114
3115 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3116
3117         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3118         inferior-events' shows the example events.
3119
3120 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3121
3122         Support styling on native MS-Windows console
3123
3124         PR/24315
3125         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3126         on MS-Windows if $TERM is not defined.
3127
3128         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3129
3130         * posix-hdep.c (gdb_console_fputs):
3131         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3132         functions.
3133         * ui-file.h (gdb_console_fputs): Add prototype.
3134
3135         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3136         back to fputs only if the former returns zero.
3137
3138 2019-03-07  Tom Tromey  <tom@tromey.com>
3139
3140         * symmisc.c (print_symbol_bcache_statistics): Update.
3141         (print_objfile_statistics): Update.
3142         * symfile.c (allocate_symtab): Update.
3143         * stabsread.c: Don't include bcache.h.
3144         * psymtab.h (struct psymbol_bcache): Don't declare.
3145         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3146         (psymbol_bcache_init, psymbol_bcache_free)
3147         (psymbol_bcache_get_bcache): Don't declare.
3148         * psymtab.c (struct psymbol_bcache): Remove.
3149         (psymtab_storage::psymtab_storage): Update.
3150         (psymtab_storage::~psymtab_storage): Update.
3151         (psymbol_bcache_init, psymbol_bcache_free)
3152         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3153         (add_psymbol_to_bcache): Update.
3154         (allocate_psymtab): Update.
3155         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3156         macro_cache>: No longer pointers.
3157         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3158         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3159         * macrotab.c (macro_bcache): Update.
3160         * macroexp.c: Don't include bcache.h.
3161         * gdbtypes.c (check_types_worklist): Update.
3162         (types_deeply_equal): Remove TRY/CATCH.  Update.
3163         * elfread.c (elf_symtab_read): Update.
3164         * dwarf2read.c: Don't include bcache.h.
3165         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3166         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3167         (print_bcache_statistics, bcache_memory_used): Don't declare.
3168         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3169         methods.  Rename all data members.
3170         * bcache.c (struct bcache): Move to bcache.h.
3171         (bcache::expand_hash_table): Rename from expand_hash_table.
3172         (bcache): Remove.
3173         (bcache::insert): Rename from bcache_full.
3174         (bcache::compare): Rename from bcache_compare.
3175         (bcache_xmalloc): Remove.
3176         (bcache::~bcache): Rename from bcache_xfree.
3177         (bcache::print_statistics): Rename from print_bcache_statistics.
3178         (bcache::memory_used): Rename from bcache_memory_used.
3179
3180 2019-03-07  Pedro Alves  <palves@redhat.com>
3181
3182         * infrun.c (normal_stop): Also check for
3183         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3184
3185 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3186
3187         * f-lang.c (value_from_host_double): Moved to...
3188         * value.c (value_from_host_double): ...here.
3189         * value.h (value_from_host_double): Declare.
3190         * guile/scm-math.c (vlscm_convert_typed_number): Use
3191         value_from_host_double.
3192         (vlscm_convert_number): Likewise.
3193         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3194         * python/py-value.c (convert_value_from_python): Likewise.
3195
3196 2019-03-06  Tom Tromey  <tom@tromey.com>
3197
3198         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3199
3200 2019-03-06  Tom Tromey  <tom@tromey.com>
3201
3202         * utils.h (free_current_contents): Don't declare.
3203         * utils.c (free_current_contents): Remove.
3204
3205 2019-03-06  Tom Tromey  <tom@tromey.com>
3206
3207         * top.c (quit_force): Update.
3208         * main.c (captured_command_loop): Update.
3209         * common/new-op.c (operator new): Update.
3210         * common/common-exceptions.c (struct catcher)
3211         <save_cleanup_chain>: Remove member.
3212         (exceptions_state_mc_init): Update.
3213         (exception_try_scope_entry): Return nullptr.
3214         (exception_try_scope_exit, exception_rethrow)
3215         (throw_exception_sjlj, throw_exception_cxx): Update.
3216         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3217         (all_cleanups, do_cleanups, discard_cleanups)
3218         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3219         (restore_cleanups, restore_final_cleanups): Don't declare.
3220         (do_final_cleanups): Remove parameter.
3221         * common/cleanups.c (cleanup_chain, make_cleanup)
3222         (make_cleanup_dtor, all_cleanups, do_cleanups)
3223         (discard_my_cleanups, discard_cleanups)
3224         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3225         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3226         (null_cleanup): Remove.
3227         (do_final_cleanups): Remove parameter.
3228
3229 2019-03-06  Tom Tromey  <tom@tromey.com>
3230
3231         * remote.c (remote_target::remote_parse_stop_reply): Use
3232         unique_xmalloc_ptr.
3233
3234 2019-03-06  Tom Tromey  <tom@tromey.com>
3235
3236         * stabsread.c (struct stabs_field_info): Rename from field_info.
3237         <list, fnlist>: Add initializers.
3238         <obstack>: New member.
3239         (read_member_functions, read_struct_fields, read_baseclasses):
3240         Allocate on obstack.  Don't use cleanups.
3241         (read_one_struct_field, read_member_functions, read_struct_fields)
3242         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3243         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3244         (read_struct_type): Update.
3245
3246 2019-03-06  Tom Tromey  <tom@tromey.com>
3247
3248         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3249         * common/filestuff.h (make_cleanup_close): Don't declare.
3250         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3251         Remove.
3252
3253 2019-03-06  Tom Tromey  <tom@tromey.com>
3254
3255         * solib-aix.c: Use make_scope_exit.
3256
3257 2019-03-06  Tom Tromey  <tom@tromey.com>
3258
3259         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3260         Use make_scope_exit.
3261
3262 2019-03-06  Tom Tromey  <tom@tromey.com>
3263
3264         * solib-svr4.c (disable_probes_interface): Remove parameter.
3265         (svr4_handle_solib_event): Use make_scope_exit.
3266
3267 2019-03-06  Tom Tromey  <tom@tromey.com>
3268
3269         * remote.c (struct stop_reply_deleter): Remove.
3270         (stop_reply_up): Update.
3271         (struct stop_reply): Derive from notif_event.  Don't typedef.
3272         <regcache>: Now a std::vector.
3273         (stop_reply_xfree): Remove.
3274         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3275         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3276         (remote_target::discard_pending_stop_replies): Use delete.
3277         (remote_target::remote_parse_stop_reply): Update.
3278         (remote_target::process_stop_reply): Update.
3279         * remote-notif.h (struct notif_event): Add virtual destructor.
3280         Remove "dtr" member.
3281         (struct notif_client) <alloc_event>: Return a unique_ptr.
3282         (notif_event_xfree): Don't declare.
3283         (notif_event_up): New typedef.
3284         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3285         (notif_event_xfree, do_notif_event_xfree): Remove.
3286         (remote_notif_state_xfree): Update.
3287
3288 2019-03-06  Tom Tromey  <tom@tromey.com>
3289
3290         * infrun.c (displaced_step_clear_cleanup): Now a
3291         forward_scope_exit type.
3292         (displaced_step_prepare_throw): Update.
3293         (displaced_step_fixup): Update.
3294
3295 2019-03-06  Tom Tromey  <tom@tromey.com>
3296
3297         * inferior.h (class inferior): Update comment.
3298         * gdbthread.h (class thread_info): Update comment.
3299
3300 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3301             Tom Tromey  <tom@tromey.com>
3302
3303         * stabsread.h (struct stab_section_list): Remove.
3304         (coffstab_build_psymtabs): Update.
3305         * dbxread.c (symbuf_sections): Now a std::vector.
3306         (sect_idx): New global.
3307         (fill_symbuf): Update.
3308         (coffstab_build_psymtabs): Change type of stabsects parameter.
3309         Update.
3310         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3311         std::vector.
3312         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3313         (coff_locate_sections): Update.
3314         (coff_symfile_read): Remove cleanups.  Update.
3315         (init_stringtab): Add storage parameter.
3316         (free_stringtab, free_stringtab_cleanup): Remove.
3317         (init_lineno): Add storage parameter.
3318         (free_linetab, free_linetab_cleanup): Remove.
3319
3320 2019-03-06  Pedro Alves  <palves@redhat.com>
3321
3322         * linux-fork.c (fork_info::clobber_regs): Delete.
3323         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3324         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3325         comment.  Adjust.
3326         (scoped_switch_fork_info::scoped_switch_fork_info)
3327         (checkpoint_command, linux_fork_context): Adjust
3328         fork_save_infrun_state calls.
3329
3330 2019-03-06  Pedro Alves  <palves@redhat.com>
3331
3332         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3333         (inf_has_multiple_threads): Return 'bool' and rewrite using
3334         inferior_info::threads().
3335
3336 2019-03-06  Pedro Alves  <palves@redhat.com>
3337
3338         * linux-fork.c: Include <list>.
3339         (fork_list): Now a std::list instance.
3340         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3341         (forks_exist_p, find_last_fork): Adjust.
3342         (new_fork): Delete.
3343         (one_fork_p): New.
3344         (add_fork): Adjust.
3345         (free_fork): Delete, folded into fork_info::~fork_info().
3346         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3347         Adjust.
3348         (init_fork_list): Delete.
3349         (linux_fork_killall, linux_fork_mourn_inferior)
3350         (linux_fork_detach, info_checkpoints_command): Adjust.
3351         (_initialize_linux_fork): No longer call init_fork_list.
3352
3353 2019-03-06  Pedro Alves  <palves@redhat.com>
3354
3355         * linux-fork.c (new_fork): New, split out of ...
3356         (add_fork): ... this.  Return void.  Move "first fork" special
3357         case from here, to ...
3358         (checkpoint_command): ... here.
3359         * linux-linux.h (add_fork): Return void.
3360
3361 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3362
3363         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3364
3365 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3366             Chris January  <chris.january@arm.com>
3367             David Lecomber  <david.lecomber@arm.com>
3368
3369         * f-exp.y: New token, UNOP_INTRINSIC.
3370         (exp): New pattern using UNOP_INTRINSIC token.
3371         (f77_keywords): Add 'abs' keyword.
3372         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3373         (value_from_host_double): New function.
3374         (evaluate_subexp_f): Support UNOP_ABS.
3375
3376 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3377
3378         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3379         types.
3380
3381 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3382
3383         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3384         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3385         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3386
3387 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3388
3389         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3390
3391 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3392             Chris January  <chris.january@arm.com>
3393
3394         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3395         * f-exp.y: Define 'KIND' token.
3396         (exp): New pattern for KIND expressions.
3397         (ptype): Handle types with a kind extension.
3398         (direct_abs_decl): Extend to spot kind extensions.
3399         (f77_keywords): Add 'kind' to the list.
3400         (push_kind_type): New function.
3401         (convert_to_kind_type): New function.
3402         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3403         * parse.c (operator_length_standard): Likewise.
3404         * parser-defs.h (enum type_pieces): Add tp_kind.
3405         * std-operator.def: Add UNOP_KIND.
3406
3407 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3408
3409         * f-exp.y (f_parse): Set yydebug.
3410
3411 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3412
3413         * f-lang.c (evaluate_subexp_f): New function.
3414         (exp_descriptor_f): New global.
3415         (f_language_defn): Use exp_descriptor_f instead of
3416         exp_descriptor_standard.
3417
3418 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3419
3420         * f-exp.y (struct token): Add comments.
3421         (dot_ops): Remove uppercase versions and the end marker.
3422         (f77_keywords): Likewise.
3423         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3424         entries in the dot_ops array are case insensitive, and use
3425         strncasecmp to compare strings.  Also some whitespace cleanup in
3426         this area.  Similar for the f77_keywords array, except entries in
3427         this list might be case sensitive.
3428
3429 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * f-exp.y (struct f77_boolean_val): Add comments.
3432         (boolean_values): Remove uppercase versions, and end marker.
3433         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3434         and use strncasecmp to achieve case insensitivity.  Additionally,
3435         perform whitespace cleanup around this code.
3436
3437 2019-03-06  Tom Tromey  <tromey@adacore.com>
3438
3439         * remote-sim.c (gdbsim_target_open): Use result of
3440         gdb_argv::release.
3441
3442 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3443         Dirk Schubert  <dirk.schubert@arm.com>
3444         Chris January  <chris.january@arm.com>
3445
3446         * eval.c (evaluate_subexp_standard): Call Fortran argument
3447         wrapping logic.
3448         * f-lang.c (struct value): A value which can be passed into a
3449         Fortran function call.
3450         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3451         where appropriate.
3452         (struct type): Value ready for a Fortran function call.
3453         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3454         is needed.
3455         * f-lang.h (fortran_argument_convert): Declaration.
3456         (fortran_preserve_arg_pointer): Declaration.
3457         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3458
3459 2019-03-05  Tom Tromey  <tromey@adacore.com>
3460
3461         * python/py-prettyprint.c (print_string_repr): Remove #if.
3462         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3463
3464 2019-03-05  Tom Tromey  <tromey@adacore.com>
3465
3466         * target.c (the_dummy_target): Move later.  Change type to
3467         "dummy_target".
3468         (initialize_targets): Don't initialize the_dummy_target.
3469
3470 2019-03-05  Tom Tromey  <tromey@adacore.com>
3471
3472         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3473         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3474
3475 2019-03-05  Tom Tromey  <tromey@adacore.com>
3476
3477         * windows-nat.c (windows_nat_target::attach)
3478         (windows_nat_target::detach): Don't call gdb_flush.
3479         * valprint.c (generic_val_print, val_print, val_print_string):
3480         Don't call gdb_flush.
3481         * utils.c (defaulted_query): Don't call gdb_flush.
3482         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3483         * target.c (target_announce_detach): Don't call gdb_flush.
3484         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3485         * remote.c (extended_remote_target::attach): Don't call
3486         gdb_flush.
3487         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3488         * printcmd.c (do_examine): Don't call gdb_flush.
3489         (info_display_command): Don't call gdb_flush.
3490         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3491         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3492         * memattr.c (info_mem_command): Don't call gdb_flush.
3493         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3494         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3495         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3496         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3497         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3498         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3499         (gnu_nat_target::detach): Don't call gdb_flush.
3500         * f-valprint.c (f_val_print): Don't call gdb_flush.
3501         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3502         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3503         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3504         gdb_flush.
3505         * c-valprint.c (c_val_print): Don't call gdb_flush.
3506         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3507
3508 2019-03-05  Tom Tromey  <tromey@adacore.com>
3509
3510         * varobj.c (update_dynamic_varobj_children): Update.
3511         (install_default_visualizer): Use reset, not release.
3512         * value.c (set_internalvar): Update.
3513         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3514         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3515         ATTRIBUTE_UNUSED_RESULT.
3516
3517 2019-03-05  Tom Tromey  <tromey@adacore.com>
3518
3519         * remote.c (class scoped_remote_fd) <release>: Add
3520         ATTRIBUTE_UNUSED_RESULT.
3521
3522 2019-03-05  Tom Tromey  <tromey@adacore.com>
3523
3524         * macroexp.c (struct macro_buffer) <release>: Add
3525         ATTRIBUTE_UNUSED_RESULT.
3526
3527 2019-03-05  Tom Tromey  <tromey@adacore.com>
3528
3529         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3530         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3531         ATTRIBUTE_UNUSED_RESULT.
3532
3533 2019-03-05  Tom Tromey  <tromey@adacore.com>
3534
3535         * common/scoped_fd.h (class scoped_fd) <release>: Add
3536         ATTRIBUTE_UNUSED_RESULT.
3537
3538 2019-03-05  Tom Tromey  <tromey@adacore.com>
3539
3540         * parser-defs.h (struct parser_state) <release>: Add
3541         ATTRIBUTE_UNUSED_RESULT.
3542
3543 2019-03-05  Tom Tromey  <tromey@adacore.com>
3544
3545         * utils.h (class gdb_argv) <release>: Add
3546         ATTRIBUTE_UNUSED_RESULT.
3547         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3548
3549 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3550
3551         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3552         for-loop range, to avoid compiler warnings.
3553
3554         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3555         avoid compiler warnings about unused variables.
3556
3557         * NEWS: Mention end of support for native debugging on MS-Windows
3558         before XP.
3559
3560         PR gdb/24292
3561         * common/netstuff.c:
3562         * gdbserver/gdbreplay.c
3563         * gdbserver/remote-utils.c:
3564         * ser-tcp.c:
3565         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3566         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3567         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3568         'getaddrinfo' and 'freeaddrinfo' were not available before
3569         Windows XP, and mingw.org's MinGW headers by default define
3570         _WIN32_WINNT to 0x500.
3571
3572 2019-03-01  Gary Benson <gbenson@redhat.com>
3573
3574         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3575
3576 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3577             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3578
3579         PR gdb/8527
3580         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3581         set_sigint_trap, clear_sigint_trap.
3582
3583 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3584
3585         * target.c (target_detach): Clear the regcache and the
3586         frame cache.
3587
3588 2019-02-27  Pedro Alves  <palves@redhat.com>
3589
3590         * utils.c (set_screen_size): When we cap the height/width sizes,
3591         tweak the corresponding command variable to show "unlimited":
3592
3593 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3594             Pedro Alves  <palves@redhat.com>
3595
3596         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3597         before calling rl_set_screen_size.
3598
3599 2019-02-27  Tom Tromey  <tromey@adacore.com>
3600
3601         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3602         define.
3603         * python/py-value.c: Remove Python 2.4 workaround.
3604         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3605         workaround.
3606         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3607         Python 2.4 workaround.
3608         * python/python-internal.h: Remove Python 2.4 comment.
3609         (Py_ssize_t): Don't define.
3610         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3611         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3612         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3613         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3614         * python/python.c (do_start_initialization): Remove Python 2.4
3615         workaround.
3616         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3617         (print_children): Remove Python 2.4 workaround.
3618         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3619         workaround.
3620         (CHARBUFFERPROC_NAME): Remove.
3621         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3622         Python 2.4 workaround.
3623
3624 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3625
3626         * NEWS: Note minimum Python version.
3627
3628 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3629
3630         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3631         code from these functions.  Remove corresponding ifdefs.  Use
3632         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3633         Remove gotos and target of gotos.
3634         (infpy_search_memory): Likewise.
3635
3636 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3637
3638         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3639         (hppa_gdbarch_init): Don't register deleted functions with
3640         gdbarch.
3641
3642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3643
3644         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3645         (h8300_unwind_sp): Delete.
3646         (h8300_dummy_id): Delete.
3647         (h8300_gdbarch_init): Don't register deleted functions with
3648         gdbarch.
3649
3650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3651
3652         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3653         (ft32_unwind_pc): Delete.
3654         (ft32_unwind_sp): Delete.
3655         (ft32_gdbarch_init): Don't register deleted functions with
3656         gdbarch.
3657
3658 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3659
3660         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3661         (frv_unwind_pc): Delete.
3662         (frv_unwind_sp): Delete.
3663         (frv_gdbarch_init): Don't register deleted functions with
3664         gdbarch.
3665
3666 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3667
3668         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3669         (riscv_unwind_pc): Delete.
3670         (riscv_unwind_sp): Delete.
3671         (riscv_gdbarch_init): Don't register deleted functions with
3672         gdbarch.
3673
3674 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3677         (csky_unwind_pc): Delete.
3678         (csky_unwind_sp): Delete.
3679         (csky_gdbarch_init): Don't register deleted functions with
3680         gdbarch.
3681
3682 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3683
3684         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3685         (cris_unwind_pc): Delete.
3686         (cris_unwind_sp): Delete.
3687         (cris_gdbarch_init): Don't register deleted functions with
3688         gdbarch.
3689
3690 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3691
3692         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3693         (bfin_unwind_pc): Delete.
3694         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3695
3696 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3699         (arm_unwind_pc): Delete.
3700         (arm_unwind_sp): Delete.
3701         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3702
3703 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3704
3705         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3706         (arc_unwind_pc): Delete.
3707         (arc_unwind_sp): Delete.
3708         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3709
3710 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3711
3712         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3713         (alpha_unwind_pc): Delete.
3714         (alpha_gdbarch_init): Don't register deleted functions with
3715         gdbarch.
3716
3717 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3718
3719         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3720         (aarch64_unwind_pc): Delete.
3721         (aarch64_unwind_sp): Delete.
3722         (aarch64_gdbarch_init): Don't register deleted functions with
3723         gdbarch.
3724
3725 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * gdbtypes.c (type_align): Don't consider static members when
3728         computing structure alignment.
3729
3730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3731
3732         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3733         return 0 for other types.
3734         * arch-utils.c (default_type_align): Always return 0.
3735         * gdbarch.h: Regenerate.
3736         * gdbarch.sh (type_align): Extend comment.
3737         * gdbtypes.c (type_align): Add additional comments, always call
3738         gdbarch_type_align before applying the default rules.
3739         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3740         generic code will then apply a suitable default.
3741         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3742         types, return 0 for other types.
3743
3744 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3745
3746         * NEWS: Create a new section for the next release branch.
3747         Rename the section of the current branch, now that it has
3748         been cut.
3749
3750 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3751
3752         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3753         * version.in: Bump version to 8.3.50.DATE-git.
3754
3755 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3756
3757         * aix-thread.c (ptid_cmp): Remove unused variable.
3758         (get_signaled_thread): Likewise.
3759         (store_regs_user_thread): Likewise.
3760         (store_regs_kernel_thread): Likewise.
3761         (fetch_regs_kernel_thread): Remove shadowed variable.
3762
3763 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3764
3765         * features/riscv/32bit-cpu.xml: Add register numbers.
3766         * features/riscv/32bit-fpu.c: Regenerate.
3767         * features/riscv/32bit-fpu.xml: Add register numbers.
3768         * features/riscv/64bit-cpu.xml: Add register numbers.
3769         * features/riscv/64bit-fpu.c: Regenerate.
3770         * features/riscv/64bit-fpu.xml: Add register numbers.
3771
3772 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3773
3774         * NEWS: Mention two argument form of gdb.Value constructor.
3775         * python/py-value.c (convert_buffer_and_type_to_value): New
3776         function.
3777         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3778         Add support for handling an optional second argument.  Call
3779         convert_buffer_and_type_to_value as appropriate.
3780         * python/python-internal.h (Py_buffer_deleter): New struct.
3781         (Py_buffer_up): New typedef.
3782
3783 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3784
3785         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3786         instead of releasing ownership.
3787
3788 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3789
3790         * dwarf2read.c (open_and_init_dwp_file): Call
3791         elf_numsections instead of bfd_count_sections to initialize
3792         dwp_file->num_sections.
3793
3794 2019-02-25  Tom Tromey  <tromey@adacore.com>
3795
3796         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3797
3798 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3799
3800         * gcore.in: Add '--readnever' option when invoking GDB.
3801
3802 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3803
3804         * MAINTAINERS: Update my email address.
3805
3806 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3807
3808         * build-id.c (build_id_to_debug_bfd_1): New function.
3809         (build_id_to_debug_bfd): Look for separate debug file in
3810         sysroot.
3811
3812 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3813
3814         * gdbarch.sh: Update the copyright year range that is placed into
3815         generated files.
3816
3817 2019-02-22  Keith Seitz  <keiths@redhat.com>
3818
3819         PR symtab/23853
3820         * linespec.c (create_sals_line_offset): Search for the default
3821         symtab's filename instead of its fullname.
3822
3823 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3824
3825         * NEWS: Update style defaults.
3826
3827 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3828
3829         * main.c (captured_main_1): Disable styling in batch mode.
3830
3831 2019-02-20  Tom Tromey  <tom@tromey.com>
3832
3833         * symtab.c (symtab_symbol_info): Fix typos.
3834
3835 2019-02-20  Tom Tromey  <tromey@adacore.com>
3836
3837         * findcmd.c (_initialize_mem_search): Use upper case for
3838         metasyntactic variables.
3839
3840 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3841
3842         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3843         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3844
3845 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3846
3847         * top.h (source_file_name): Change to std::string.
3848         * top.c (source_file_name): Likewise.
3849         (command_line_input): Adjust.
3850         * cli/cli-script.c (script_from_file): Adjust.
3851
3852 2019-02-19  Tom Tromey  <tromey@adacore.com>
3853
3854         * ravenscar-thread.c
3855         (ravenscar_thread_target::update_thread_list): Don't call
3856         ada_build_task_list.
3857         * ada-lang.h (ada_build_task_list): Don't declare.
3858         * ada-tasks.c (struct ada_tasks_inferior_data)
3859         <task_list_valid_p>: Now bool.
3860         (read_known_tasks, ada_task_list_changed)
3861         (ada_tasks_invalidate_inferior_data): Update.
3862         (read_known_tasks_array): Return bool.
3863         (read_known_tasks_list): Likewise.
3864         (read_known_tasks): Return void.
3865         (ada_build_task_list): Now static.
3866
3867 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3868
3869         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3870         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3871
3872 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3873
3874         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3875         variant for ada_tasks_pspace_data_handle and
3876         ada_tasks_inferior_data_handle.
3877         (ada_tasks_pspace_data_cleanup): New function.
3878         (ada_tasks_inferior_data_cleanup): New function.
3879
3880 2019-02-17  Tom Tromey  <tom@tromey.com>
3881
3882         * macrotab.h (macro_source_fullname): Return a std::string.
3883         * macrotab.c (macro_include, check_for_redefinition)
3884         (macro_undef, macro_lookup_definition, foreach_macro)
3885         (foreach_macro_in_scope): Update.
3886         (macro_source_fullname): Return a std::string.
3887         * macrocmd.c (show_pp_source_pos): Update.
3888
3889 2019-02-17  Tom Tromey  <tom@tromey.com>
3890
3891         * macrocmd.c (show_pp_source_pos): Style the file names.
3892
3893 2019-02-17  Tom Tromey  <tom@tromey.com>
3894
3895         PR tui/24197:
3896         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3897
3898 2019-02-17  Tom Tromey  <tom@tromey.com>
3899
3900         * ada-lang.c (user_select_syms): Use filtered printing.
3901         * utils.c (wrap_style): New global.
3902         (desired_style): Remove.
3903         (emit_style_escape): Add stream parameter.
3904         (set_output_style, reset_terminal_style, prompt_for_continue):
3905         Update.
3906         (flush_wrap_buffer): Only flush gdb_stdout.
3907         (wrap_here): Set wrap_style.
3908         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3909         treat escape sequences as a character.  Change when wrap buffer is
3910         flushed.
3911         (fputs_styled): Do not set the output style when the default is
3912         requested.
3913         * ui-style.h (struct ui_file_style) <is_default>: New method.
3914         * source.c (print_source_lines_base): Emit escape sequences in one
3915         piece.
3916
3917 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3918
3919         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3920         integers and enumeration types.
3921
3922 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3923
3924         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3925         instead of lookup_symbol_in_language
3926         (do_exact_match): New function.
3927         (ada_get_symbol_name_matcher): Return do_exact_match when
3928         doing a verbatim match.
3929
3930 2019-02-15  Tom Tromey  <tromey@adacore.com>
3931
3932         * ravenscar-thread.c (ravenscar_thread_target::resume)
3933         (ravenscar_thread_target::wait): Special case wildcard requests.
3934
3935 2019-02-15  Tom Tromey  <tromey@adacore.com>
3936
3937         * ravenscar-thread.c (base_ptid): Remove.
3938         (struct ravenscar_thread_target) <close>: New method.
3939         <m_base_ptid>: New member.
3940         <update_inferior_ptid, active_task, task_is_currently_active,
3941         runtime_initialized>: Declare methods.
3942         <ravenscar_thread_target>: Add constructor.
3943         (ravenscar_thread_target::task_is_currently_active)
3944         (ravenscar_thread_target::update_inferior_ptid)
3945         (ravenscar_runtime_initialized): Rename.  Now methods.
3946         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3947         (ravenscar_thread_target::update_thread_list): Update.
3948         (ravenscar_thread_target::active_task): Now method.
3949         (ravenscar_thread_target::store_registers)
3950         (ravenscar_thread_target::prepare_to_store)
3951         (ravenscar_thread_target::prepare_to_store)
3952         (ravenscar_thread_target::mourn_inferior): Update.
3953         (ravenscar_inferior_created): Use "new" to create target.
3954         (ravenscar_thread_target::get_ada_task_ptid): Update.
3955         (_initialize_ravenscar): Don't initialize base_ptid.
3956         (ravenscar_ops): Remove global.
3957
3958 2019-02-15  Tom Tromey  <tromey@adacore.com>
3959
3960         * target.h (push_target): Declare new overload.
3961         * target.c (push_target): New overload, taking an rvalue reference.
3962         * remote.c (remote_target::open_1): Use push_target overload.
3963         * corelow.c (core_target_open): Use push_target overload.
3964
3965 2019-02-15  Tom Tromey  <tromey@adacore.com>
3966
3967         * ravenscar-thread.c (is_ravenscar_task)
3968         (ravenscar_task_is_currently_active): Return bool.
3969         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3970         (_initialize_ravenscar): Remove "(void)".
3971         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3972         Return bool.
3973
3974 2019-02-15  Tom Tromey  <tromey@adacore.com>
3975
3976         * ravenscar-thread.c (ravenscar_runtime_initializer)
3977         (has_ravenscar_runtime, get_running_thread_id)
3978         (ravenscar_thread_target::resume): Fix indentation.
3979
3980 2019-02-15  Tom Tromey  <tromey@adacore.com>
3981
3982         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3983         from ravenscar_arch_ops.
3984         (sparc_ravenscar_ops::fetch_registers)
3985         (sparc_ravenscar_ops::store_registers): Now methods.
3986         (sparc_ravenscar_prepare_to_store): Remove.
3987         (sparc_ravenscar_ops): Redefine.
3988         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3989         methods and destructor.  Remove members.
3990         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3991         (ravenscar_thread_target::store_registers)
3992         (ravenscar_thread_target::prepare_to_store): Update.
3993         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3994         Remove.
3995         (struct ppc_ravenscar_powerpc_ops): Derive from
3996         ravenscar_arch_ops.
3997         (ppc_ravenscar_powerpc_ops::fetch_registers)
3998         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3999         (ppc_ravenscar_powerpc_ops): Redefine.
4000         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4001         (ppc_ravenscar_e500_ops::fetch_registers)
4002         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4003         (ppc_ravenscar_e500_ops): Redefine.
4004         * aarch64-ravenscar-thread.c
4005         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4006         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4007         (aarch64_ravenscar_fetch_registers)
4008         (aarch64_ravenscar_store_registers): Now methods.
4009         (aarch64_ravenscar_ops): Redefine.
4010
4011 2019-02-15  Tom Tromey  <tromey@adacore.com>
4012
4013         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4014         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4015         (ravenscar_thread_target::stopped_by_watchpoint)
4016         (ravenscar_thread_target::stopped_data_address)
4017         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4018
4019 2019-02-15  Tom Tromey  <tromey@adacore.com>
4020
4021         * ravenscar-thread.c: Fix some typos.
4022
4023 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4024             Tom Tromey  <tromey@adacore.com>
4025
4026         * ada-lang.c (ada_exception_sal): Change addr_string to a
4027         std::string.
4028         (create_ada_exception_catchpoint): Update.
4029
4030 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4031             Tom Tromey  <tromey@adacore.com>
4032
4033         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4034         (bp_location_ops): Remove.
4035         (base_breakpoint_allocate_location): Update.
4036         (free_bp_location): Update.
4037         * ada-lang.c (class ada_catchpoint_location)
4038         <ada_catchpoint_location>: Remove ops parameter.
4039         (ada_catchpoint_location_dtor): Remove.
4040         (ada_catchpoint_location_ops): Remove.
4041         (allocate_location_exception): Update.
4042         * breakpoint.h (struct bp_location_ops): Remove.
4043         (class bp_location) <bp_location>: Remove bp_location_ops
4044         parameter.
4045         <~bp_location>: Add destructor.
4046         <ops>: Remove.
4047
4048 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4049             Pedro Alves  <palves@redhat.com>
4050
4051         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4052         'PATH_MAX'.
4053
4054 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4055             Samuel Thibault  <samuel.thibault@gnu.org>
4056             Thomas Schwinge  <thomas@codesourcery.com>
4057
4058         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4059         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4060
4061 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4062
4063         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4064         (check_empty): Use "const char *".
4065
4066         * gnu-nat.c (gnu_nat_target::detach): Instead of
4067         'detach_inferior (pid)' call
4068         'detach_inferior (find_inferior_pid (pid))'.
4069
4070         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4071         'nat/fork-inferior.o'.
4072         * gnu-nat.c: #include "nat/fork-inferior.h".
4073
4074         * gnu-nat.c (gnu_nat_target::detach): Instead of
4075         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4076         * gnu-nat.h: #include "inf-child.h".
4077         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4078         'i386_gnu_nat_target::fetch_registers'.
4079         (gnu_store_registers): Rename/move to
4080         'i386_gnu_nat_target::store_registers'.
4081
4082         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4083         * gnu-nat.h (mach_thread_info): New function.
4084         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4085
4086         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4087
4088 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4089
4090         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4091
4092 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4093
4094         * windows-nat.c (windows_add_thread): Add new parameter
4095         "main_thread_p" with default value set to false.  Update
4096         function documentation as well as all callers.
4097         (windows_delete_thread): Likewise.
4098         (fake_create_process): Update call to windows_add_thread.
4099         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4100         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4101         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4102         call to windows_delete_thread.
4103
4104 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4105
4106         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4107
4108 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4109
4110         * symfile.c (find_separate_debug_file): Use canonical path of
4111         sysroot with child_path instead of gdb_sysroot if it is valid.
4112
4113 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4114
4115         * symfile.c (find_separate_debug_file): Use child_path to
4116         determine if an object file is under a sysroot.
4117
4118 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4119
4120         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4121         unittests/child-path-selftests.c.
4122         * common/pathstuff.c (child_path): New function.
4123         * common/pathstuff.h (child_path): New prototype.
4124         * unittests/child-path-selftests.c: New file.
4125
4126 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4127
4128         * symfile.c (find_separate_debug_file): Look for separate debug
4129         files in debug directories under the sysroot.
4130
4131 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4132
4133         * symtab.h (struct minimal_symbol data_p): New const method.
4134         (struct minimal_symbol text_p): Likewise.
4135         * symtab.c (output_source_filename): Use file name style
4136         to print file name.
4137         (print_symbol_info): Likewise.
4138         (print_msymbol_info): Use address style to print addresses.
4139         Use function name style to print executable text symbols.
4140         (expand_symtab_containing_pc): Use data_p.
4141         (find_pc_sect_compunit_symtab): Likewise.
4142
4143 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4144
4145         * breakpoint.c (describe_other_breakpoints): Use address style
4146         to print addresses.
4147         (say_where): Likewise.
4148
4149 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4150
4151         * ada-typeprint.c (print_func_type): Print function name
4152         style to print function name.
4153         * c-typeprint.c (c_print_type_1): Likewise.
4154
4155 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4156
4157         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4158         for execve.
4159
4160 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4161
4162         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4163         type_stack.
4164
4165 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4166
4167         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4168         TYPE_CODE_REF types.
4169
4170 2019-02-08  Jim Wilson  <jimw@sifive.com>
4171
4172         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4173         (riscv_linux_fregset): New.
4174         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4175
4176 2019-02-07  Tom Tromey  <tom@tromey.com>
4177
4178         * thread.c (thread_cancel_execution_command): Update.
4179         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4180         methods.
4181         (struct thread_fsm_ops): Remove.
4182         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4183         (thread_fsm_should_stop, thread_fsm_return_value)
4184         (thread_fsm_set_finished, thread_fsm_finished_p)
4185         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4186         Don't declare.
4187         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4188         * infrun.c (clear_proceed_status_thread)
4189         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4190         (print_stop_event): Update.
4191         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4192         Add constructor.
4193         (step_command_fsm_ops): Remove.
4194         (new_step_command_fsm): Remove.
4195         (step_1): Update.
4196         (step_command_fsm::should_stop): Rename from
4197         step_command_fsm_should_stop.
4198         (step_command_fsm::clean_up): Rename from
4199         step_command_fsm_clean_up.
4200         (step_command_fsm::do_async_reply_reason): Rename from
4201         step_command_fsm_async_reply_reason.
4202         (struct until_next_fsm): Inherit from thread_fsm.  Add
4203         constructor.
4204         (until_next_fsm_ops): Remove.
4205         (new_until_next_fsm): Remove.
4206         (until_next_fsm::should_stop): Rename from
4207         until_next_fsm_should_stop.
4208         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4209         (until_next_fsm::do_async_reply_reason): Rename from
4210         until_next_fsm_async_reply_reason.
4211         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4212         constructor.  Change type of breakpoint.
4213         (finish_command_fsm_ops): Remove.
4214         (new_finish_command_fsm): Remove.
4215         (finish_command_fsm::should_stop): Rename from
4216         finish_command_fsm_should_stop.
4217         (finish_command_fsm::clean_up): Rename from
4218         finish_command_fsm_clean_up.
4219         (finish_command_fsm::return_value): Rename from
4220         finish_command_fsm_return_value.
4221         (finish_command_fsm::do_async_reply_reason): Rename from
4222         finish_command_fsm_async_reply_reason.
4223         (finish_command): Update.
4224         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4225         Add constructor.
4226         (call_thread_fsm_ops): Remove.
4227         (call_thread_fsm::call_thread_fsm): Rename from
4228         new_call_thread_fsm.
4229         (call_thread_fsm::should_stop): Rename from
4230         call_thread_fsm_should_stop.
4231         (call_thread_fsm::should_notify_stop): Rename from
4232         call_thread_fsm_should_notify_stop.
4233         (run_inferior_call, call_function_by_hand_dummy): Update.
4234         * cli/cli-interp.c (should_print_stop_to_console): Update.
4235         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4236         Add constructor.  Change type of location_breakpoint,
4237         caller_breakpoint.
4238         (until_break_fsm_ops): Remove.
4239         (new_until_break_fsm): Remove.
4240         (until_break_fsm::should_stop): Rename from
4241         until_break_fsm_should_stop.
4242         (until_break_fsm::clean_up): Rename from
4243         until_break_fsm_clean_up.
4244         (until_break_fsm::do_async_reply_reason): Rename from
4245         until_break_fsm_async_reply_reason.
4246         (until_break_command): Update.
4247         * thread-fsm.c: Remove.
4248         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4249
4250 2019-02-07  Tom Tromey  <tom@tromey.com>
4251
4252         * yy-remap.h: Add include guard.
4253         * xtensa-tdep.h: Add include guard.
4254         * xcoffread.h: Rename include guard.
4255         * varobj-iter.h: Add include guard.
4256         * tui/tui.h: Rename include guard.
4257         * tui/tui-winsource.h: Rename include guard.
4258         * tui/tui-wingeneral.h: Rename include guard.
4259         * tui/tui-windata.h: Rename include guard.
4260         * tui/tui-win.h: Rename include guard.
4261         * tui/tui-stack.h: Rename include guard.
4262         * tui/tui-source.h: Rename include guard.
4263         * tui/tui-regs.h: Rename include guard.
4264         * tui/tui-out.h: Rename include guard.
4265         * tui/tui-layout.h: Rename include guard.
4266         * tui/tui-io.h: Rename include guard.
4267         * tui/tui-hooks.h: Rename include guard.
4268         * tui/tui-file.h: Rename include guard.
4269         * tui/tui-disasm.h: Rename include guard.
4270         * tui/tui-data.h: Rename include guard.
4271         * tui/tui-command.h: Rename include guard.
4272         * tic6x-tdep.h: Add include guard.
4273         * target/waitstatus.h: Rename include guard.
4274         * target/wait.h: Rename include guard.
4275         * target/target.h: Rename include guard.
4276         * target/resume.h: Rename include guard.
4277         * target-float.h: Rename include guard.
4278         * stabsread.h: Add include guard.
4279         * rs6000-tdep.h: Add include guard.
4280         * riscv-fbsd-tdep.h: Add include guard.
4281         * regformats/regdef.h: Rename include guard.
4282         * record.h: Rename include guard.
4283         * python/python.h: Rename include guard.
4284         * python/python-internal.h: Rename include guard.
4285         * python/py-stopevent.h: Rename include guard.
4286         * python/py-ref.h: Rename include guard.
4287         * python/py-record.h: Rename include guard.
4288         * python/py-record-full.h: Rename include guard.
4289         * python/py-record-btrace.h: Rename include guard.
4290         * python/py-instruction.h: Rename include guard.
4291         * python/py-events.h: Rename include guard.
4292         * python/py-event.h: Rename include guard.
4293         * procfs.h: Add include guard.
4294         * proc-utils.h: Add include guard.
4295         * p-lang.h: Add include guard.
4296         * or1k-tdep.h: Rename include guard.
4297         * observable.h: Rename include guard.
4298         * nto-tdep.h: Rename include guard.
4299         * nat/x86-linux.h: Rename include guard.
4300         * nat/x86-linux-dregs.h: Rename include guard.
4301         * nat/x86-gcc-cpuid.h: Add include guard.
4302         * nat/x86-dregs.h: Rename include guard.
4303         * nat/x86-cpuid.h: Rename include guard.
4304         * nat/ppc-linux.h: Rename include guard.
4305         * nat/mips-linux-watch.h: Rename include guard.
4306         * nat/linux-waitpid.h: Rename include guard.
4307         * nat/linux-ptrace.h: Rename include guard.
4308         * nat/linux-procfs.h: Rename include guard.
4309         * nat/linux-osdata.h: Rename include guard.
4310         * nat/linux-nat.h: Rename include guard.
4311         * nat/linux-namespaces.h: Rename include guard.
4312         * nat/linux-btrace.h: Rename include guard.
4313         * nat/glibc_thread_db.h: Rename include guard.
4314         * nat/gdb_thread_db.h: Rename include guard.
4315         * nat/gdb_ptrace.h: Rename include guard.
4316         * nat/fork-inferior.h: Rename include guard.
4317         * nat/amd64-linux-siginfo.h: Rename include guard.
4318         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4319         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4320         * nat/aarch64-linux.h: Rename include guard.
4321         * nat/aarch64-linux-hw-point.h: Rename include guard.
4322         * mn10300-tdep.h: Add include guard.
4323         * mips-linux-tdep.h: Add include guard.
4324         * mi/mi-parse.h: Rename include guard.
4325         * mi/mi-out.h: Rename include guard.
4326         * mi/mi-main.h: Rename include guard.
4327         * mi/mi-interp.h: Rename include guard.
4328         * mi/mi-getopt.h: Rename include guard.
4329         * mi/mi-console.h: Rename include guard.
4330         * mi/mi-common.h: Rename include guard.
4331         * mi/mi-cmds.h: Rename include guard.
4332         * mi/mi-cmd-break.h: Rename include guard.
4333         * m2-lang.h: Add include guard.
4334         * location.h: Rename include guard.
4335         * linux-record.h: Rename include guard.
4336         * linux-nat.h: Add include guard.
4337         * linux-fork.h: Add include guard.
4338         * i386-darwin-tdep.h: Rename include guard.
4339         * hppa-linux-offsets.h: Add include guard.
4340         * guile/guile.h: Rename include guard.
4341         * guile/guile-internal.h: Rename include guard.
4342         * gnu-nat.h: Rename include guard.
4343         * gdb-stabs.h: Rename include guard.
4344         * frv-tdep.h: Add include guard.
4345         * f-lang.h: Add include guard.
4346         * event-loop.h: Add include guard.
4347         * darwin-nat.h: Rename include guard.
4348         * cp-abi.h: Rename include guard.
4349         * config/sparc/nm-sol2.h: Rename include guard.
4350         * config/nm-nto.h: Rename include guard.
4351         * config/nm-linux.h: Add include guard.
4352         * config/i386/nm-i386gnu.h: Rename include guard.
4353         * config/djgpp/nl_types.h: Rename include guard.
4354         * config/djgpp/langinfo.h: Rename include guard.
4355         * compile/gcc-cp-plugin.h: Add include guard.
4356         * compile/gcc-c-plugin.h: Add include guard.
4357         * compile/compile.h: Rename include guard.
4358         * compile/compile-object-run.h: Rename include guard.
4359         * compile/compile-object-load.h: Rename include guard.
4360         * compile/compile-internal.h: Rename include guard.
4361         * compile/compile-cplus.h: Rename include guard.
4362         * compile/compile-c.h: Rename include guard.
4363         * common/xml-utils.h: Rename include guard.
4364         * common/x86-xstate.h: Rename include guard.
4365         * common/version.h: Rename include guard.
4366         * common/vec.h: Rename include guard.
4367         * common/tdesc.h: Rename include guard.
4368         * common/selftest.h: Rename include guard.
4369         * common/scoped_restore.h: Rename include guard.
4370         * common/scoped_mmap.h: Rename include guard.
4371         * common/scoped_fd.h: Rename include guard.
4372         * common/safe-iterator.h: Rename include guard.
4373         * common/run-time-clock.h: Rename include guard.
4374         * common/refcounted-object.h: Rename include guard.
4375         * common/queue.h: Rename include guard.
4376         * common/ptid.h: Rename include guard.
4377         * common/print-utils.h: Rename include guard.
4378         * common/preprocessor.h: Rename include guard.
4379         * common/pathstuff.h: Rename include guard.
4380         * common/observable.h: Rename include guard.
4381         * common/netstuff.h: Rename include guard.
4382         * common/job-control.h: Rename include guard.
4383         * common/host-defs.h: Rename include guard.
4384         * common/gdb_wait.h: Rename include guard.
4385         * common/gdb_vecs.h: Rename include guard.
4386         * common/gdb_unlinker.h: Rename include guard.
4387         * common/gdb_unique_ptr.h: Rename include guard.
4388         * common/gdb_tilde_expand.h: Rename include guard.
4389         * common/gdb_sys_time.h: Rename include guard.
4390         * common/gdb_string_view.h: Rename include guard.
4391         * common/gdb_splay_tree.h: Rename include guard.
4392         * common/gdb_setjmp.h: Rename include guard.
4393         * common/gdb_ref_ptr.h: Rename include guard.
4394         * common/gdb_optional.h: Rename include guard.
4395         * common/gdb_locale.h: Rename include guard.
4396         * common/gdb_assert.h: Rename include guard.
4397         * common/filtered-iterator.h: Rename include guard.
4398         * common/filestuff.h: Rename include guard.
4399         * common/fileio.h: Rename include guard.
4400         * common/environ.h: Rename include guard.
4401         * common/common-utils.h: Rename include guard.
4402         * common/common-types.h: Rename include guard.
4403         * common/common-regcache.h: Rename include guard.
4404         * common/common-inferior.h: Rename include guard.
4405         * common/common-gdbthread.h: Rename include guard.
4406         * common/common-exceptions.h: Rename include guard.
4407         * common/common-defs.h: Rename include guard.
4408         * common/common-debug.h: Rename include guard.
4409         * common/cleanups.h: Rename include guard.
4410         * common/buffer.h: Rename include guard.
4411         * common/btrace-common.h: Rename include guard.
4412         * common/break-common.h: Rename include guard.
4413         * cli/cli-utils.h: Rename include guard.
4414         * cli/cli-style.h: Rename include guard.
4415         * cli/cli-setshow.h: Rename include guard.
4416         * cli/cli-script.h: Rename include guard.
4417         * cli/cli-interp.h: Rename include guard.
4418         * cli/cli-decode.h: Rename include guard.
4419         * cli/cli-cmds.h: Rename include guard.
4420         * charset-list.h: Add include guard.
4421         * buildsym-legacy.h: Rename include guard.
4422         * bfin-tdep.h: Add include guard.
4423         * ax.h: Rename include guard.
4424         * arm-linux-tdep.h: Add include guard.
4425         * arm-fbsd-tdep.h: Add include guard.
4426         * arch/xtensa.h: Rename include guard.
4427         * arch/tic6x.h: Add include guard.
4428         * arch/i386.h: Add include guard.
4429         * arch/arm.h: Rename include guard.
4430         * arch/arm-linux.h: Rename include guard.
4431         * arch/arm-get-next-pcs.h: Rename include guard.
4432         * arch/amd64.h: Add include guard.
4433         * arch/aarch64-insn.h: Rename include guard.
4434         * arch-utils.h: Rename include guard.
4435         * annotate.h: Add include guard.
4436         * amd64-darwin-tdep.h: Rename include guard.
4437         * aarch64-linux-tdep.h: Add include guard.
4438         * aarch64-fbsd-tdep.h: Add include guard.
4439         * aarch32-linux-nat.h: Add include guard.
4440
4441 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4442
4443         * macrotab.c (macro_define_internal): New function that
4444         factorizes macro_define_object_internal and macro_define_function
4445         code.
4446         (macro_define_object_internal): Use macro_define_internal.
4447         (macro_define_function): Likewise.
4448
4449 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4450
4451         * macrocmd.c (extract_identifier): Return
4452         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4453         callers.
4454
4455 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4456
4457         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4458
4459 2019-02-05  Tom Tromey  <tom@tromey.com>
4460
4461         * target.c (target_stack::unpush): Move assertion earlier.
4462
4463 2019-01-30  Tom Tromey  <tom@tromey.com>
4464
4465         PR python/23615:
4466         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4467         (gdbpy_parse_and_eval): Likewise.
4468         * python/python-internal.h (gdbpy_allow_threads): New class.
4469
4470 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4471
4472         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4473         (aarch64_fbsd_fpregmap): Move earlier.
4474         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4475         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4476         instead of individual calls to trad_frame_set_reg_addr.
4477         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4478         earlier.
4479         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4480         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4481         instead of individual calls to trad_frame_set_reg_addr.
4482
4483 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4484
4485         * CONTRIBUTE: Replace contribution list with wiki link.
4486
4487 2019-01-25  Tom Tromey  <tom@tromey.com>
4488
4489         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4490
4491 2019-01-25  Tom Tromey  <tom@tromey.com>
4492
4493         * xtensa-linux-nat.c: Fix common/ includes.
4494         * xml-support.h: Fix common/ includes.
4495         * xml-support.c: Fix common/ includes.
4496         * x86-linux-nat.c: Fix common/ includes.
4497         * windows-nat.c: Fix common/ includes.
4498         * varobj.h: Fix common/ includes.
4499         * varobj.c: Fix common/ includes.
4500         * value.c: Fix common/ includes.
4501         * valops.c: Fix common/ includes.
4502         * utils.c: Fix common/ includes.
4503         * unittests/xml-utils-selftests.c: Fix common/ includes.
4504         * unittests/utils-selftests.c: Fix common/ includes.
4505         * unittests/unpack-selftests.c: Fix common/ includes.
4506         * unittests/tracepoint-selftests.c: Fix common/ includes.
4507         * unittests/style-selftests.c: Fix common/ includes.
4508         * unittests/string_view-selftests.c: Fix common/ includes.
4509         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4510         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4511         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4512         * unittests/rsp-low-selftests.c: Fix common/ includes.
4513         * unittests/parse-connection-spec-selftests.c: Fix common/
4514         includes.
4515         * unittests/optional-selftests.c: Fix common/ includes.
4516         * unittests/offset-type-selftests.c: Fix common/ includes.
4517         * unittests/observable-selftests.c: Fix common/ includes.
4518         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4519         * unittests/memrange-selftests.c: Fix common/ includes.
4520         * unittests/memory-map-selftests.c: Fix common/ includes.
4521         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4522         * unittests/function-view-selftests.c: Fix common/ includes.
4523         * unittests/environ-selftests.c: Fix common/ includes.
4524         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4525         * unittests/common-utils-selftests.c: Fix common/ includes.
4526         * unittests/cli-utils-selftests.c: Fix common/ includes.
4527         * unittests/array-view-selftests.c: Fix common/ includes.
4528         * ui-file.c: Fix common/ includes.
4529         * tui/tui-io.c: Fix common/ includes.
4530         * tracepoint.h: Fix common/ includes.
4531         * tracepoint.c: Fix common/ includes.
4532         * tracefile-tfile.c: Fix common/ includes.
4533         * top.h: Fix common/ includes.
4534         * top.c: Fix common/ includes.
4535         * thread.c: Fix common/ includes.
4536         * target/waitstatus.h: Fix common/ includes.
4537         * target/waitstatus.c: Fix common/ includes.
4538         * target.h: Fix common/ includes.
4539         * target.c: Fix common/ includes.
4540         * target-memory.c: Fix common/ includes.
4541         * target-descriptions.c: Fix common/ includes.
4542         * symtab.h: Fix common/ includes.
4543         * symfile.c: Fix common/ includes.
4544         * stap-probe.c: Fix common/ includes.
4545         * spu-linux-nat.c: Fix common/ includes.
4546         * sparc-nat.c: Fix common/ includes.
4547         * source.c: Fix common/ includes.
4548         * solib.c: Fix common/ includes.
4549         * solib-target.c: Fix common/ includes.
4550         * ser-unix.c: Fix common/ includes.
4551         * ser-tcp.c: Fix common/ includes.
4552         * ser-pipe.c: Fix common/ includes.
4553         * ser-base.c: Fix common/ includes.
4554         * selftest-arch.c: Fix common/ includes.
4555         * s12z-tdep.c: Fix common/ includes.
4556         * rust-exp.y: Fix common/ includes.
4557         * rs6000-aix-tdep.c: Fix common/ includes.
4558         * riscv-tdep.c: Fix common/ includes.
4559         * remote.c: Fix common/ includes.
4560         * remote-notif.h: Fix common/ includes.
4561         * remote-fileio.h: Fix common/ includes.
4562         * remote-fileio.c: Fix common/ includes.
4563         * regcache.h: Fix common/ includes.
4564         * regcache.c: Fix common/ includes.
4565         * record-btrace.c: Fix common/ includes.
4566         * python/python.c: Fix common/ includes.
4567         * python/py-type.c: Fix common/ includes.
4568         * python/py-inferior.c: Fix common/ includes.
4569         * progspace.h: Fix common/ includes.
4570         * producer.c: Fix common/ includes.
4571         * procfs.c: Fix common/ includes.
4572         * proc-api.c: Fix common/ includes.
4573         * printcmd.c: Fix common/ includes.
4574         * ppc-linux-nat.c: Fix common/ includes.
4575         * parser-defs.h: Fix common/ includes.
4576         * osdata.c: Fix common/ includes.
4577         * obsd-nat.c: Fix common/ includes.
4578         * nat/x86-linux.c: Fix common/ includes.
4579         * nat/x86-linux-dregs.c: Fix common/ includes.
4580         * nat/x86-dregs.h: Fix common/ includes.
4581         * nat/x86-dregs.c: Fix common/ includes.
4582         * nat/ppc-linux.c: Fix common/ includes.
4583         * nat/mips-linux-watch.h: Fix common/ includes.
4584         * nat/mips-linux-watch.c: Fix common/ includes.
4585         * nat/linux-waitpid.c: Fix common/ includes.
4586         * nat/linux-ptrace.h: Fix common/ includes.
4587         * nat/linux-ptrace.c: Fix common/ includes.
4588         * nat/linux-procfs.c: Fix common/ includes.
4589         * nat/linux-personality.c: Fix common/ includes.
4590         * nat/linux-osdata.c: Fix common/ includes.
4591         * nat/linux-namespaces.c: Fix common/ includes.
4592         * nat/linux-btrace.h: Fix common/ includes.
4593         * nat/linux-btrace.c: Fix common/ includes.
4594         * nat/fork-inferior.c: Fix common/ includes.
4595         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4596         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4597         * nat/aarch64-linux.c: Fix common/ includes.
4598         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4599         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4600         * namespace.h: Fix common/ includes.
4601         * mips-linux-tdep.c: Fix common/ includes.
4602         * minsyms.c: Fix common/ includes.
4603         * mi/mi-parse.h: Fix common/ includes.
4604         * mi/mi-main.c: Fix common/ includes.
4605         * mi/mi-cmd-env.c: Fix common/ includes.
4606         * memrange.h: Fix common/ includes.
4607         * memattr.c: Fix common/ includes.
4608         * maint.h: Fix common/ includes.
4609         * maint.c: Fix common/ includes.
4610         * main.c: Fix common/ includes.
4611         * machoread.c: Fix common/ includes.
4612         * location.c: Fix common/ includes.
4613         * linux-thread-db.c: Fix common/ includes.
4614         * linux-nat.c: Fix common/ includes.
4615         * linux-fork.c: Fix common/ includes.
4616         * inline-frame.c: Fix common/ includes.
4617         * infrun.c: Fix common/ includes.
4618         * inflow.c: Fix common/ includes.
4619         * inferior.h: Fix common/ includes.
4620         * inferior.c: Fix common/ includes.
4621         * infcmd.c: Fix common/ includes.
4622         * inf-ptrace.c: Fix common/ includes.
4623         * inf-child.c: Fix common/ includes.
4624         * ia64-linux-nat.c: Fix common/ includes.
4625         * i387-tdep.c: Fix common/ includes.
4626         * i386-tdep.c: Fix common/ includes.
4627         * i386-linux-tdep.c: Fix common/ includes.
4628         * i386-linux-nat.c: Fix common/ includes.
4629         * i386-go32-tdep.c: Fix common/ includes.
4630         * i386-fbsd-tdep.c: Fix common/ includes.
4631         * i386-fbsd-nat.c: Fix common/ includes.
4632         * guile/scm-type.c: Fix common/ includes.
4633         * guile/guile.c: Fix common/ includes.
4634         * go32-nat.c: Fix common/ includes.
4635         * gnu-nat.c: Fix common/ includes.
4636         * gdbthread.h: Fix common/ includes.
4637         * gdbarch-selftests.c: Fix common/ includes.
4638         * gdb_usleep.c: Fix common/ includes.
4639         * gdb_select.h: Fix common/ includes.
4640         * gdb_bfd.c: Fix common/ includes.
4641         * gcore.c: Fix common/ includes.
4642         * fork-child.c: Fix common/ includes.
4643         * findvar.c: Fix common/ includes.
4644         * fbsd-nat.c: Fix common/ includes.
4645         * event-top.c: Fix common/ includes.
4646         * event-loop.c: Fix common/ includes.
4647         * dwarf2read.c: Fix common/ includes.
4648         * dwarf2loc.c: Fix common/ includes.
4649         * dwarf2-frame.c: Fix common/ includes.
4650         * dwarf-index-cache.c: Fix common/ includes.
4651         * dtrace-probe.c: Fix common/ includes.
4652         * disasm-selftests.c: Fix common/ includes.
4653         * defs.h: Fix common/ includes.
4654         * csky-tdep.c: Fix common/ includes.
4655         * cp-valprint.c: Fix common/ includes.
4656         * cp-support.h: Fix common/ includes.
4657         * cp-support.c: Fix common/ includes.
4658         * corelow.c: Fix common/ includes.
4659         * completer.h: Fix common/ includes.
4660         * completer.c: Fix common/ includes.
4661         * compile/compile.c: Fix common/ includes.
4662         * compile/compile-loc2c.c: Fix common/ includes.
4663         * compile/compile-cplus-types.c: Fix common/ includes.
4664         * compile/compile-cplus-symbols.c: Fix common/ includes.
4665         * command.h: Fix common/ includes.
4666         * cli/cli-dump.c: Fix common/ includes.
4667         * cli/cli-cmds.c: Fix common/ includes.
4668         * charset.c: Fix common/ includes.
4669         * build-id.c: Fix common/ includes.
4670         * btrace.h: Fix common/ includes.
4671         * btrace.c: Fix common/ includes.
4672         * breakpoint.h: Fix common/ includes.
4673         * breakpoint.c: Fix common/ includes.
4674         * ax.h:
4675         (enum agent_op): Fix common/ includes.
4676         * ax-general.c (struct aop_map): Fix common/ includes.
4677         * ax-gdb.c: Fix common/ includes.
4678         * auxv.c: Fix common/ includes.
4679         * auto-load.c: Fix common/ includes.
4680         * arm-tdep.c: Fix common/ includes.
4681         * arch/riscv.c: Fix common/ includes.
4682         * arch/ppc-linux-common.c: Fix common/ includes.
4683         * arch/i386.c: Fix common/ includes.
4684         * arch/arm.c: Fix common/ includes.
4685         * arch/arm-linux.c: Fix common/ includes.
4686         * arch/arm-get-next-pcs.c: Fix common/ includes.
4687         * arch/amd64.c: Fix common/ includes.
4688         * arch/aarch64.c: Fix common/ includes.
4689         * arch/aarch64-insn.c: Fix common/ includes.
4690         * arch-utils.c: Fix common/ includes.
4691         * amd64-windows-tdep.c: Fix common/ includes.
4692         * amd64-tdep.c: Fix common/ includes.
4693         * amd64-sol2-tdep.c: Fix common/ includes.
4694         * amd64-obsd-tdep.c: Fix common/ includes.
4695         * amd64-nbsd-tdep.c: Fix common/ includes.
4696         * amd64-linux-tdep.c: Fix common/ includes.
4697         * amd64-linux-nat.c: Fix common/ includes.
4698         * amd64-fbsd-tdep.c: Fix common/ includes.
4699         * amd64-fbsd-nat.c: Fix common/ includes.
4700         * amd64-dicos-tdep.c: Fix common/ includes.
4701         * amd64-darwin-tdep.c: Fix common/ includes.
4702         * agent.c: Fix common/ includes.
4703         * ada-lang.h: Fix common/ includes.
4704         * ada-lang.c: Fix common/ includes.
4705         * aarch64-tdep.c: Fix common/ includes.
4706
4707 2019-01-25  Tom Tromey  <tom@tromey.com>
4708
4709         * common/create-version.sh: Use common/version.h.
4710
4711 2019-01-24  Pedro Alves  <palves@redhat.com>
4712
4713         * infrun.c (signal_stop, signal_print, signal_program)
4714         (signal_catch, signal_pass): Now arrays instead of pointers.
4715         (update_signals_program_target, do_target_resume)
4716         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4717         * linux-nat.c (linux_nat_target::pass_signals)
4718         (linux_nat_target::create_inferior, linux_nat_target::attach):
4719         Adjust.
4720         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4721         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4722         * procfs.c (procfs_target::pass_signals): Adjust.
4723         * record-full.c (record_full_target::resume): Adjust.
4724         * remote.c (remote_target::pass_signals)
4725         (remote_target::program_signals): Adjust.
4726         * target-debug.h (target_debug_print_signals): Now takes a
4727         gdb::array_view as parameter.  Adjust.
4728         * target.h (target_ops) <pass_signals, program_signals>: Replace
4729         pointer and length parameters with gdb::array_view.
4730         (target_pass_signals, target_program_signals): Likewise.
4731         * target-delegates.c: Regenerate.
4732
4733 2019-01-24  Pedro Alves  <palves@redhat.com>
4734
4735         * common/forward-scope-exit.h
4736         (forward_scope_exit::forward_scope_exit): Pass arguments to
4737         m_bind_function directly, instead of creating a std::bind and
4738         copying that.
4739
4740 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4741
4742         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4743         for static members.
4744         (pass_in_v_vfp_candidate): Likewise.
4745
4746 2019-01-23  Tom Tromey  <tom@tromey.com>
4747             Pedro Alves  <palves@redhat.com>
4748
4749         * regcache.c (class regcache_invalidator): Remove.
4750         (regcache::raw_write): Use make_scope_exit.
4751
4752 2019-01-23  Tom Tromey  <tom@tromey.com>
4753
4754         * ui-out.h (class ui_out_emit_type): Update comment.
4755
4756 2019-01-23  Tom Tromey  <tom@tromey.com>
4757
4758         * infrun.c (fetch_inferior_event): Update comment.
4759
4760 2019-01-23  Tom Tromey  <tom@tromey.com>
4761             Pedro Alves  <palves@redhat.com>
4762
4763         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4764         parameter.
4765         (fetch_inferior_event): Use SCOPE_EXIT.
4766
4767
4768 2019-01-23  Tom Tromey  <tom@tromey.com>
4769             Pedro Alves  <palves@redhat.com>
4770
4771         * infrun.c (disable_thread_events): Delete.
4772         (stop_all_threads): Use SCOPE_EXIT.
4773
4774 2019-01-23  Tom Tromey  <tom@tromey.com>
4775             Pedro Alves  <palves@redhat.com>
4776
4777         * symfile.c: Include forward-scope-exit.h.
4778         (clear_symtab_users_cleanup): Replace forward declaration with
4779         a FORWARD_SCOPE_EXIT.
4780         (syms_from_objfile_1): Use the forward_scope_exit and
4781         gdb::optional instead of cleanup_function.
4782         (reread_symbols): Use the forward_scope_exit instead of
4783         cleanup_function.
4784         (clear_symtab_users_cleanup): Remove function.
4785
4786 2019-01-23  Tom Tromey  <tom@tromey.com>
4787             Pedro Alves  <palves@redhat.com>
4788
4789         * linux-nat.c: Include scope-exit.h.
4790         (cleanup_target_stop): Remove.
4791         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4792         SCOPE_EXIT.
4793
4794 2019-01-23  Tom Tromey  <tom@tromey.com>
4795             Pedro Alves  <palves@redhat.com>
4796
4797         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4798         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4799
4800 2019-01-23  Tom Tromey  <tom@tromey.com>
4801             Andrew Burgess  <andrew.burgess@embecosm.com>
4802             Pedro Alves  <palves@redhat.com>
4803
4804         * infrun.c (fetch_inferior_event): Use scope_exit.
4805         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4806         * top.c (execute_command): Use scope_exit.
4807         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4808         * utils.c (do_bpstat_clear_actions_cleanup)
4809         (make_bpstat_clear_actions_cleanup): Remove.
4810
4811 2019-01-23  Tom Tromey  <tom@tromey.com>
4812             Pedro Alves  <palves@redhat.com>
4813
4814         * infrun.c: Include "common/scope-exit.h"
4815         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4816         (wait_for_inferior): Use SCOPE_EXIT.
4817         (fetch_inferior_event): Use scope_exit.
4818
4819 2019-01-23  Tom Tromey  <tom@tromey.com>
4820             Pedro Alves  <palves@redhat.com>
4821
4822         * breakpoint.c (create_breakpoint): Remove cleanup.
4823
4824 2019-01-23  Tom Tromey  <tom@tromey.com>
4825             Andrew Burgess  <andrew.burgess@embecosm.com>
4826             Pedro Alves  <palves@redhat.com>
4827
4828 2019-01-23  Pedro Alves  <palves@redhat.com>
4829
4830         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4831
4832 2019-01-23  Pedro Alves  <palves@redhat.com>
4833             Andrew Burgess  <andrew.burgess@embecosm.com>
4834
4835         * gdbthread.h: Include "common/forward-scope-exit.h".
4836         (scoped_finish_thread_state): Redefine custom class in terms of
4837         forward_scope_exit.
4838
4839 2019-01-23  Pedro Alves  <palves@redhat.com>
4840             Andrew Burgess  <andrew.burgess@embecosm.com>
4841
4842         * common/forward-scope-exit.h: New file.
4843
4844 2019-01-23  Pedro Alves  <palves@redhat.com>
4845             Andrew Burgess  <andrew.burgess@embecosm.com>
4846             Tom Tromey  <tom@tromey.com>
4847
4848         * common/scope-exit.h: New file.
4849
4850 2019-01-23  Pedro Alves  <palves@redhat.com>
4851
4852         * common/preprocessor.h (ESC): Rename to ...
4853         (ESC_PARENS): ... this.
4854         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4855         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4856
4857 2019-01-23  Tom Tromey  <tom@tromey.com>
4858
4859         * language.h (class scoped_switch_to_sym_language_if_auto):
4860         Initialize m_lang in both cases.
4861
4862 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4863
4864         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4865         with XCNEW.
4866
4867 2019-01-22  Tom Tromey  <tom@tromey.com>
4868
4869         * corelow.c: Do not include sys/file.h.
4870
4871 2019-01-22  Tom Tromey  <tom@tromey.com>
4872
4873         * tui/tui-wingeneral.h: Include gdb_curses.h.
4874
4875 2019-01-22  Tom Tromey  <tom@tromey.com>
4876
4877         * source-cache.h (class source_cache) <get_source_lines,
4878         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4879
4880 2019-01-22  Tom Tromey  <tom@tromey.com>
4881
4882         * remote-fileio.h (struct remote_target): Declare.
4883
4884 2019-01-22  Tom Tromey  <tom@tromey.com>
4885
4886         * python/py-arch.c: Do not include py-ref.h.
4887         * python/py-bpevent.c: Do not include py-ref.h.
4888         * python/py-cmd.c: Do not include py-ref.h.
4889         * python/py-continueevent.c: Do not include py-ref.h.
4890         * python/py-event.h: Do not include py-ref.h.
4891         * python/py-evtregistry.c: Do not include py-ref.h.
4892         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4893         * python/py-frame.c: Do not include py-ref.h.
4894         * python/py-framefilter.c: Do not include py-ref.h.
4895         * python/py-function.c: Do not include py-ref.h.
4896         * python/py-infevents.c: Do not include py-ref.h.
4897         * python/py-linetable.c: Do not include py-ref.h.
4898         * python/py-objfile.c: Do not include py-ref.h.
4899         * python/py-param.c: Do not include py-ref.h.
4900         * python/py-prettyprint.c: Do not include py-ref.h.
4901         * python/py-progspace.c: Do not include py-ref.h.
4902         * python/py-symbol.c: Do not include py-ref.h.
4903         * python/py-symtab.c: Do not include py-ref.h.
4904         * python/py-type.c: Do not include py-ref.h.
4905         * python/py-unwind.c: Do not include py-ref.h.
4906         * python/py-utils.c: Do not include py-ref.h.
4907         * python/py-value.c: Do not include py-ref.h.
4908         * python/py-varobj.c: Do not include py-ref.h.
4909         * python/py-xmethods.c: Do not include py-ref.h.
4910         * python/python.c: Do not include py-ref.h.
4911         * varobj.c: Do not include py-ref.h.
4912
4913 2019-01-22  Tom Tromey  <tom@tromey.com>
4914
4915         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4916         keyword for bcache.
4917
4918 2019-01-22  Tom Tromey  <tom@tromey.com>
4919
4920         * compile/compile-cplus-types.c: Remove a comment by #include.
4921
4922 2019-01-22  Tom Tromey  <tom@tromey.com>
4923
4924         * compile/gcc-c-plugin.h: Include compile-internal.h.
4925
4926 2019-01-22  Tom Tromey  <tom@tromey.com>
4927
4928         * stabsread.c (EXTERN): Do not define.
4929         (symnum, next_symbol_text_func, processing_gcc_compilation)
4930         (within_function, global_sym_chain, global_stabs)
4931         (previous_stab_code, this_object_header_files)
4932         (n_this_object_header_files)
4933         (n_allocated_this_object_header_files): Define.
4934         * stabsread.h (EXTERN): Never define.  Use "extern".
4935
4936 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4937
4938         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4939         history_value.
4940
4941 2019-01-21  Tom Tromey  <tom@tromey.com>
4942
4943         * ui-out.c: Fix includes.
4944         * tui/tui-source.c: Fix includes.
4945         * target.c: Fix includes.
4946         * remote.c: Fix includes.
4947         * regcache.c: Fix includes.
4948         * python/py-block.c: Fix includes.
4949         * printcmd.c: Fix includes.
4950         * or1k-tdep.c: Fix includes.
4951         * mi/mi-main.c: Fix includes.
4952         * m32r-tdep.c: Fix includes.
4953         * csky-tdep.c: Fix includes.
4954         * compile/compile-cplus-types.c: Fix includes.
4955         * cli/cli-interp.c: Fix includes.
4956
4957 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4958
4959         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4960         for padding.
4961
4962 2019-01-16  Tom Tromey  <tom@tromey.com>
4963
4964         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4965         earlier.
4966         (struct objfile) <msymbols_range>: Move from top level.
4967         <msymbols>: New method.
4968         (class objfile_msymbols): Remove.
4969         * symtab.c (default_collect_symbol_completion_matches_break_on):
4970         Update.
4971         * symmisc.c (dump_msymbols): Update.
4972         * stabsread.c (scan_file_globals): Update.
4973         * objc-lang.c (info_selectors_command, info_classes_command)
4974         (find_methods): Update.
4975         * minsyms.c (find_solib_trampoline_target): Update.
4976         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4977         * coffread.c (coff_symfile_read): Update.
4978         * ada-lang.c (ada_lookup_simple_minsym)
4979         (ada_collect_symbol_completion_matches): Update.
4980
4981 2019-01-16  Tom Tromey  <tom@tromey.com>
4982
4983         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4984         type.  Remove no-argument constructor.
4985         <iterator::operator++>: Simplify.
4986         <begin>: Update.
4987         <end>: Use minimal_symbol_count.
4988
4989 2019-01-16  Tom Tromey  <tom@tromey.com>
4990
4991         * objfiles.h (struct objfile) <psymtabs>: New method.
4992         (class objfile_psymtabs): Remove.
4993         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4994         typedef.
4995         <range>: New method.
4996         (require_partial_symbols): Change return type.
4997         * psymtab.c (require_partial_symbols)
4998         (psym_expand_symtabs_matching): Update.
4999         * mdebugread.c (parse_partial_symbols): Update.
5000         * dbxread.c (dbx_end_psymtab): Update.
5001
5002 2019-01-15  Tom Tromey  <tom@tromey.com>
5003
5004         * symtab.c (lookup_objfile_from_block)
5005         (lookup_symbol_in_objfile_symtabs)
5006         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5007         (find_line_symtab, info_sources_command)
5008         (default_collect_symbol_completion_matches_break_on)
5009         (make_source_files_completion_list): Update.
5010         * symmisc.c (print_objfile_statistics, dump_objfile)
5011         (maintenance_print_symbols, maintenance_info_symtabs)
5012         (maintenance_check_symtabs, maintenance_info_line_tables):
5013         Update.
5014         * source.c (select_source_symtab)
5015         (forget_cached_source_info_for_objfile): Update.
5016         * objfiles.h (class objfile_compunits): Remove.
5017         (struct objfile) <compunits_range>: New typedef.
5018         (compunits): New method.
5019         * objfiles.c (objfile_relocate1): Update.
5020         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5021         * maint.c (count_symtabs_and_blocks): Update.
5022         * linespec.c (iterate_over_all_matching_symtabs): Update.
5023         * cp-support.c (add_symbol_overload_list_qualified): Update.
5024         * coffread.c (coff_symtab_read): Update.
5025         * ada-lang.c (add_nonlocal_symbols)
5026         (ada_collect_symbol_completion_matches)
5027         (ada_add_global_exceptions): Update.
5028
5029 2019-01-15  Tom Tromey  <tom@tromey.com>
5030
5031         * progspace.h (program_space) <objfiles_safe_range>: New
5032         typedef.
5033         <objfiles_safe>: New method.
5034         * objfiles.h (class all_objfiles_safe): Remove.
5035         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5036         * jit.c (jit_inferior_exit_hook): Update.
5037
5038 2019-01-17  Tom Tromey  <tom@tromey.com>
5039
5040         * progspace.h (program_space) <objfiles_range>: New typedef.
5041         <objfiles>: New method.
5042         <objfiles_head>: Rename from objfiles.
5043         (object_files): Update.
5044         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5045         * guile/scm-pretty-print.c
5046         (ppscm_find_pretty_printer_from_objfiles): Update.
5047         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5048         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5049         Update.
5050         * python/py-progspace.c (pspy_get_objfiles): Update.
5051         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5052         Update.
5053         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5054         (objfpy_lookup_objfile_by_build_id): Update.
5055         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5056         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5057         Update.
5058         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5059         (expand_symtab_containing_pc, lookup_objfile_from_block)
5060         (lookup_static_symbol, basic_lookup_transparent_type)
5061         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5062         (find_line_symtab, info_sources_command)
5063         (default_collect_symbol_completion_matches_break_on)
5064         (make_source_files_completion_list, find_main_name): Update.
5065         * symmisc.c (print_symbol_bcache_statistics)
5066         (print_objfile_statistics, maintenance_print_symbols)
5067         (maintenance_print_msymbols, maintenance_print_objfiles)
5068         (maintenance_info_symtabs, maintenance_check_symtabs)
5069         (maintenance_expand_symtabs, maintenance_info_line_tables):
5070         Update.
5071         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5072         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5073         (map_overlay_command, unmap_overlay_command)
5074         (simple_overlay_update, expand_symtabs_matching)
5075         (map_symbol_filenames): Update.
5076         * symfile-debug.c (set_debug_symfile): Update.
5077         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5078         Update.
5079         * source.c (select_source_symtab, forget_cached_source_info):
5080         Update.
5081         * solib.c (solib_read_symbols): Update.
5082         * solib-spu.c (append_ocl_sos): Update.
5083         * psymtab.c (maintenance_print_psymbols)
5084         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5085         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5086         * printcmd.c (info_symbol_command): Update.
5087         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5088         Update.
5089         * objfiles.h (class all_objfiles): Remove.
5090         * objfiles.c (have_partial_symbols, have_full_symbols)
5091         (have_minimal_symbols, qsort_cmp, update_section_map)
5092         (shared_objfile_contains_address_p)
5093         (default_iterate_over_objfiles_in_search_order): Update.
5094         * objc-lang.c (info_selectors_command, info_classes_command)
5095         (find_methods): Update.
5096         * minsyms.c (find_solib_trampoline_target): Update.
5097         * maint.c (maintenance_info_sections)
5098         (maintenance_translate_address, count_symtabs_and_blocks):
5099         Update.
5100         * main.c (captured_main_1): Update.
5101         * linux-thread-db.c (try_thread_db_load_from_pdir)
5102         (has_libpthread): Update.
5103         * linespec.c (iterate_over_all_matching_symtabs)
5104         (search_minsyms_for_name): Update.
5105         * jit.c (jit_find_objf_with_entry_addr): Update.
5106         * hppa-tdep.c (find_unwind_entry)
5107         (hppa_lookup_stub_minimal_symbol): Update.
5108         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5109         Update.
5110         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5111         (elf_gnu_ifunc_resolve_by_got): Update.
5112         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5113         * dwarf-index-write.c (save_gdb_index_command): Update.
5114         * cp-support.c (add_symbol_overload_list_qualified): Update.
5115         * breakpoint.c (create_overlay_event_breakpoint)
5116         (create_longjmp_master_breakpoint)
5117         (create_std_terminate_master_breakpoint)
5118         (create_exception_master_breakpoint): Update.
5119         * blockframe.c (find_pc_partial_function): Update.
5120         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5121         (ada_collect_symbol_completion_matches)
5122         (ada_add_global_exceptions): Update.
5123
5124 2019-01-17  Tom Tromey  <tom@tromey.com>
5125
5126         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5127         declare VEC.
5128         (solib_target_parse_libraries): Change return type.
5129         (library_list_start_segment, library_list_start_section)
5130         (library_list_end_library, library_list_start_library); Update.
5131         (solib_target_free_library_list): Remove.
5132         (solib_target_parse_libraries): Remove cleanup.  Change return
5133         type.
5134         (solib_target_current_sos): Update.
5135
5136 2019-01-17  Tom Tromey  <tromey@bapiya>
5137
5138         * valprint.c: Replace "the the" with "the".
5139         * symtab.c: Replace "the the" with "the".
5140         * solib.c: Replace "the the" with "the".
5141         * solib-dsbt.c: Replace "the the" with "the".
5142         * linespec.c: Replace "the the" with "the".
5143         * dwarf2loc.h: Replace "the the" with "the".
5144         * amd64-windows-tdep.c: Replace "the the" with "the".
5145         * aarch64-tdep.c: Replace "the the" with "the".
5146
5147 2019-01-16  Keith Seitz  <keiths@redhat.com>
5148
5149         PR gdb/23773
5150         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5151         <builder>: Rename to ..
5152         <m_builder>: ... this and make private.
5153         (dwarf2_cu::get_builder): New method.  Change all users of
5154         `builder' to use this method.
5155         (dwarf2_start_symtab): Move to ...
5156         (dwarf2_cu::start_symtab): ... here.  Update all callers
5157         (setup_type_unit_groups): Move to ...
5158         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5159         callers.
5160         (dwarf2_cu::reset_builder): New method.
5161         (process_full_compunit, process_full_type_unit): Use
5162         dwarf2_cu::reset_builder.
5163         (follow_die_offset): Record the ancestor CU if it is different
5164         from the followed DIE's CU.
5165         (follow_die_sig_1): Likewise.
5166
5167 2019-01-15  Tom Tromey  <tom@tromey.com>
5168
5169         * remote.c (class remote_state) <buf>: Now a char_vector.
5170         <buf_size>: Remove.
5171         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5172         parameter.
5173         (remote_target::getpkt_or_notif_sane_1)
5174         (remote_target::getpkt_sane)
5175         (remote_target::getpkt_or_notif_sane): Likewise.
5176         (class remote_target) <putpkt>: New overload.
5177         (remote_target::read_frame): Change type of "buf_p".  Remove
5178         sizeof_p parameter.
5179         (packet_ok): New overload.
5180         (packet_check_result): New overload.
5181         Update all uses.
5182
5183 2019-01-14  Tom Tromey  <tom@tromey.com>
5184
5185         * remote-notif.c (handle_notification, remote_notif_ack)
5186         (remote_notif_parse): Make "buf" const.
5187         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5188         const.
5189         (remote_notif_parse, remote_notif_ack, handle_notification):
5190         Likewise.
5191         * remote.c (remote_notif_stop_parse): Make "buf" const.
5192         (remote_target::remote_parse_stop_reply): Make "buf" const.
5193         (remote_notif_stop_ack): Make "buf" const.
5194
5195 2019-01-14  Tom Tromey  <tom@tromey.com>
5196
5197         * remote.c (remote_console_output): Make parameter const.
5198
5199 2019-01-14  Tom Tromey  <tom@tromey.com>
5200
5201         * target-debug.h (target_debug_print_signals): Constify.
5202         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5203         * procfs.c (procfs_target::pass_signals): Update.
5204         * linux-nat.c (linux_nat_target::pass_signals): Update.
5205         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5206         * target-delegates.c: Rebuild.
5207         * remote.c (remote_target::program_signals): Update.
5208         (remote_target::pass_signals): Update.
5209         * target.c (target_pass_signals): Constify argument.
5210         (target_program_signals): Likewise.
5211         * target.h (struct target_ops) <pass_signals, program_signals>:
5212         Constify argument.
5213         (target_pass_signals, target_program_signals): Constify argument.
5214
5215 2019-01-14  Tom Tromey  <tom@tromey.com>
5216
5217         PR tui/28819:
5218         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5219
5220 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5221
5222         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5223         field.
5224         * rs6000-tdep.c: Include reggroups.h.
5225         (IS_V_ALIAS_PSEUDOREG): Define.
5226         (rs6000_register_name): Return names for the "vX" aliases.
5227         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5228         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5229         aliases.  Call default_register_reggroup_p for all other
5230         pseudo-registers.
5231         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5232         New functions.
5233         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5234         Handle "vX" aliases.
5235         (v_alias_pseudo_register_collect): New function.
5236         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5237         (rs6000_gdbarch_init): Initialize "vX" aliases as
5238         pseudo-registers.  Restore registration of
5239         rs6000_pseudo_register_reggroup_p with
5240         set_tdesc_pseudo_register_reggroup_p.
5241
5242 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5243
5244         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5245         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5246         set_gdbarch_num_pseudo_regs.
5247
5248 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5249
5250         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5251         Remove arg prefixname, add do_set and do_show.
5252         Add member functions set_list and show_list.
5253         * cli/cli-style.c (class cli_style_option): Update accordingly.
5254         (style_set_list): Move to file scope.
5255         (style_show_list): Likewise.
5256         (set_style): Call help_list.
5257         (show_style): Call cmd_show_list.
5258         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5259         Update to use the new macro.
5260
5261 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5262
5263         * ada-lang.c (_initialize_ada_language): Expand the help text
5264         for the "catch exception" command.
5265
5266 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5267
5268         * symtab.c (matching_obj_sections): Initialize obj,
5269         declare it closer to its usage.
5270
5271 2019-01-10  Tom Tromey  <tom@tromey.com>
5272
5273         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5274         (basic_inf_threads_range): Remove.
5275         (inf_threads_range, inf_non_exited_threads_range)
5276         (safe_inf_threads_range): Use next_adapter.
5277
5278 2019-01-10  Keith Seitz  <keiths@redhat.com>
5279
5280         PR gdb/23712
5281         PR symtab/23010
5282         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5283         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5284
5285 2019-01-10  Keith Seitz  <keiths@redhat.com>
5286
5287         PR gdb/23712
5288         PR symtab/23010
5289         * dictionary.c (pending_to_vector): Remove.
5290         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5291         Remove _1 suffix, replacing functions of the same name.  Update
5292         all callers.
5293         (dict_create_hashed, dict_create_hashed_expandable)
5294         (dict_create_linear, dict_create_linear_expandable, dict_free)
5295         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5296         Make functions static.
5297
5298 2019-01-10  Keith Seitz  <keiths@redhat.com>
5299
5300         PR gdb/23712
5301         PR symtab/23010
5302         * dictionary.h (struct dictionary): Replace declaration with
5303         multidictionary.
5304         (dict_create_hashed, dict_create_hashed_expandable)
5305         (dict_create_linear, dict_create_linear_expandable)
5306         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5307         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5308         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5309         taking multidictionary argument.
5310         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5311         * block.h (struct block) <dict>: Change to multidictionary
5312         and rename `multidict'.
5313         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5314         symmisc.c: Update all dictionary references to multidictionary.
5315
5316 2019-01-10  Keith Seitz  <keiths@redhat.com>
5317
5318         PR gdb/23712
5319         PR symtab/23010
5320         * dictionary.c: Include unordered_map.
5321         (pending_to_vector): New function.
5322         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5323         Rewrite the non-"_1" functions to take vector instead
5324         of linked list.
5325         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5326         "new" _1 versions of the same name.
5327         (multidictionary): Define.
5328         (std::hash<enum language): New definition.
5329         (collate_pending_symbols_by_language, mdict_create_hashed)
5330         (mdict_create_hashed_expandable, mdict_create_linear)
5331         (mdict_create_linear_expandable, mdict_free)
5332         (find_language_dictionary, create_new_language_dictionary)
5333         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5334         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5335         (mdict_size, mdict_empty): New functions.
5336         * dictionary.h (mdict_iterator): Define.
5337
5338 2019-01-10  Pedro Alves  <palves@redhat.com>
5339
5340         * breakpoint.c (read_uploaded_action)
5341         (create_tracepoint_from_upload): Adjust to use
5342         gdb::unique_xmalloc_ptr.
5343         * ctf.c (ctf_write_uploaded_tp):
5344         (SET_ARRAY_FIELD): Use emplace_back.
5345         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5346         * tracefile-tfile.c (tfile_write_uploaded_tp):
5347         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5348         gdb::unique_xmalloc_ptr.
5349         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5350         at_string, cond_string, cmd_strings>: Replace char pointers
5351         with gdb::unique_xmalloc_ptr.
5352
5353 2019-01-10  Pedro Alves  <palves@redhat.com>
5354
5355         * solib-target.c (library_list_start_library): Don't xstrdup name.
5356
5357 2019-01-10  Pedro Alves  <palves@redhat.com>
5358
5359         * mdebugread.c (parse_partial_symbols): Use
5360         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5361
5362 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5363
5364         * linux-fork.c (scoped_switch_fork_info)
5365         <~scoped_switch_fork_info>: Fix incorrect variable name.
5366
5367 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5368
5369         * linux-fork.c (scoped_switch_fork_info)
5370         <scoped_switch_fork_info>: Make explicit.
5371         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5372
5373 2019-01-10  Tom Tromey  <tom@tromey.com>
5374
5375         * objfiles.h (objfile::reset_psymtabs): Update.
5376         * objfiles.c (objfile::objfile): Update.
5377         * psymtab.h (psymtab_storage::obstack): Update.
5378         (psymtab_storage::m_obstack): Use gdb::optional.
5379         (class psymtab_storage): Update comment.  Remove objfile
5380         parameter.
5381         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5382
5383 2019-01-10  Tom Tromey  <tom@tromey.com>
5384
5385         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5386         <free_psymtabs>: Now private.
5387         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5388         (allocate_psymtab): Use new method.
5389
5390 2019-01-10  Tom Tromey  <tom@tromey.com>
5391
5392         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5393         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5394         * mdebugread.c (parse_partial_symbols): Use
5395         allocate_dependencies.
5396         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5397         allocate_dependencies.
5398         (process_psymtab_comp_unit_reader)
5399         (build_type_psymtab_dependencies): Likewise.
5400         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5401
5402 2019-01-10  Tom Tromey  <tom@tromey.com>
5403
5404         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5405         PSYMBOL_SET_LANGUAGE.
5406         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5407
5408 2019-01-10  Tom Tromey  <tom@tromey.com>
5409
5410         * psymtab.h (psymtab_storage::obstack): New method.
5411         <m_obstack>: Rename from obstack; now private.
5412         * psymtab.c (psymtab_storage): Update.
5413         * dwarf2read.c (create_addrmap_from_index)
5414         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5415         Update.
5416
5417 2019-01-10  Tom Tromey  <tom@tromey.com>
5418
5419         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5420         * objfiles.h (objfile::reset_psymtabs): New method.
5421
5422 2019-01-10  Tom Tromey  <tom@tromey.com>
5423
5424         * symmisc.c (print_symbol_bcache_statistics): Update.
5425         (print_objfile_statistics): Update.
5426         * symfile.c (reread_symbols): Update.
5427         * psymtab.h (class psymtab_storage): New.
5428         * psymtab.c (psymtab_storage): New constructor.
5429         (~psymtab_storage): New destructor.
5430         (require_partial_symbols): Update.
5431         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5432         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5433         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5434         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5435         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5436         (start_psymtab_common, end_psymtab_common)
5437         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5438         (allocate_psymtab): Update.
5439         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5440         Update.
5441         (dump_psymtab_addrmap, maintenance_print_psymbols)
5442         (maintenance_check_psymtabs): Update.
5443         (class objfile_psymtabs): Move to objfiles.h.
5444         * psympriv.h (discard_psymtab): Now inline.
5445         (psymtab_discarder::psymtab_discarder): Update.
5446         (psymtab_discarder::~psymtab_discarder): Update.
5447         (ALL_OBJFILE_PSYMTABS): Rewrite.
5448         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5449         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5450         Remove fields.
5451         <partial_symtabs>: New field.
5452         (class objfile_psymtabs): Move from psymtab.h.  Update.
5453         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5454         psymbol_cache.
5455         (objfile::~objfile): Don't destroy psymbol_cache.
5456         * mdebugread.c (parse_partial_symbols): Update.
5457         * dwarf2read.c (create_addrmap_from_index)
5458         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5459         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5460         (add_partial_subprogram, dwarf2_ranges_read): Update.
5461         * dwarf-index-write.c (write_address_map)
5462         (write_one_signatured_type, recursively_write_psymbols)
5463         (class debug_names, class debug_names, write_psymtabs_to_index):
5464         Update.
5465
5466 2019-01-10  Tom Tromey  <tom@tromey.com>
5467
5468         * symtab.h (SYMBOL_SET_NAMES): Update.
5469         (symbol_set_names): Update.
5470         (MSYMBOL_SET_NAMES): Update.
5471         * symtab.c (symbol_set_names): Change argument to be an
5472         objfile_per_bfd_storage.
5473         * psymtab.c (add_psymbol_to_bcache): Update.
5474         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5475
5476 2019-01-10  Tom Tromey  <tom@tromey.com>
5477
5478         * symtab.c (create_demangled_names_hash): Change argument to be an
5479         objfile_per_bfd_storage.
5480         (symbol_set_names): Update.
5481
5482 2019-01-10  Tom Tromey  <tom@tromey.com>
5483
5484         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5485         init_psymbol_list.
5486         * psymtab.c (init_psymbol_list): Do nothing if already called.
5487         * psympriv.h (init_psymbol_list): Add comment.
5488         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5489         init_psymbol_list.
5490         * dbxread.c (dbx_symfile_read): Unconditionally call
5491         init_psymbol_list.
5492
5493 2019-01-10  Tom Tromey  <tom@tromey.com>
5494
5495         * xcoffread.c (scan_xcoff_symtab): Update.
5496         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5497         "where".
5498         * mdebugread.c (parse_partial_symbols)
5499         (handle_psymbol_enumerators): Update.
5500         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5501         * dbxread.c (read_dbx_symtab): Update.
5502         * psympriv.h (psymbol_placement): New enum.
5503         (add_psymbol_to_list): Update.
5504
5505 2019-01-10  Tom Tromey  <tom@tromey.com>
5506
5507         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5508         static_psymbols parameters.
5509         (scan_xcoff_symtab): Update.
5510         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5511         static_psymbols parameters.
5512         * psympriv.h (start_psymtab_common): Update.
5513         * mdebugread.c (parse_partial_symbols): Update.
5514         * dwarf2read.c (create_partial_symtab): Update.
5515         * dbxread.c (read_dbx_symtab): Update.
5516         (start_psymtab): Remove global_psymbols and static_psymbols
5517         parameters.
5518
5519 2019-01-10  Tom Tromey  <tom@tromey.com>
5520
5521         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5522         * psymtab.c (allocate_psymtab): Add comment.
5523         * psympriv.h (allocate_psymtab): Add comment.
5524         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5525         initializations.
5526         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5527
5528 2019-01-10  Tom Tromey  <tom@tromey.com>
5529
5530         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5531         Don't declare.
5532         * mipsread.c: Include mdebugread.h.
5533         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5534         Declare.
5535         * elfread.c: Include mdebugread.h.
5536
5537 2019-01-09  Tom Tromey  <tom@tromey.com>
5538
5539         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5540         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5541         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5542         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5543         (psym_lookup_symbol, psym_find_last_source_symtab)
5544         (psym_forget_cached_source_info, psym_print_stats)
5545         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5546         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5547         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5548         (psym_find_compunit_symtab_by_address)
5549         (maintenance_print_psymbols, maintenance_info_psymtabs)
5550         (maintenance_check_psymtabs): Use ranged for.
5551         * psymtab.h (class objfile_psymtabs): New.
5552         (require_partial_symbols): Return objfile_psymtabs.
5553         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5554
5555 2019-01-09  Tom Tromey  <tom@tromey.com>
5556
5557         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5558         (find_pc_mapped_section, list_overlays_command)
5559         (map_overlay_command, unmap_overlay_command)
5560         (simple_overlay_update): Use all_objfiles.
5561         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5562         * printcmd.c (info_symbol_command): Use all_objfiles.
5563         * objfiles.h (ALL_OBJSECTIONS): Remove.
5564         * maint.c (maintenance_translate_address): Use all_objfiles.
5565         * gcore.c (gcore_create_callback): Use all_objfiles.
5566         (objfile_find_memory_regions): Likewise.
5567
5568 2019-01-09  Tom Tromey  <tom@tromey.com>
5569
5570         * symtab.c (find_line_symtab, info_sources_command)
5571         (make_source_files_completion_list): Use objfile_compunits.
5572         * source.c (select_source_symtab): Use objfile_compunits.
5573         * objfiles.h (struct objfile): Update comment.
5574         (ALL_OBJFILES): Remove.
5575         (ALL_FILETABS): Remove.
5576         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5577         objfile_compunits.
5578
5579 2019-01-09  Tom Tromey  <tom@tromey.com>
5580
5581         * symmisc.c (print_objfile_statistics, dump_objfile)
5582         (maintenance_print_symbols): Use compunit_filetabs.
5583         * source.c (forget_cached_source_info_for_objfile): Use
5584         compunit_filetabs.
5585         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5586         (ALL_FILETABS): Use compunit_filetabs.
5587         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5588         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5589
5590 2019-01-09  Tom Tromey  <tom@tromey.com>
5591
5592         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5593         (compunit_filetabs): New.
5594         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5595         compunit_filetabs.
5596         (info_sources_command, make_source_files_completion_list): Remove
5597         declaration.
5598         * symmisc.c (print_objfile_statistics, dump_objfile)
5599         (maintenance_print_symbols): Remove declaration.
5600         (maintenance_info_symtabs): Use compunit_filetabs.
5601         (maintenance_info_line_tables): Likewise.
5602         * source.c (select_source_symtab): Change local variable name.
5603         (forget_cached_source_info_for_objfile): Remove declaration.
5604         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5605         * objfiles.c (objfile_relocate1): Remove declaration.
5606         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5607         declaration.
5608         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5609         * coffread.c (coff_symtab_read): Remove declaration.
5610         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5611         compunit_filetabs.
5612
5613 2019-01-09  Tom Tromey  <tom@tromey.com>
5614
5615         * symtab.c (lookup_objfile_from_block)
5616         (find_pc_sect_compunit_symtab, search_symbols)
5617         (default_collect_symbol_completion_matches_break_on): Use
5618         objfile_compunits.
5619         * objfiles.h (ALL_COMPUNITS): Remove.
5620         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5621         * cp-support.c (add_symbol_overload_list_qualified): Use
5622         objfile_compunits.
5623         * ada-lang.c (ada_collect_symbol_completion_matches)
5624         (ada_add_global_exceptions): Use objfile_compunits.
5625
5626 2019-01-09  Tom Tromey  <tom@tromey.com>
5627
5628         * source.c (select_source_symtab)
5629         (forget_cached_source_info_for_objfile): Remove declaration.
5630         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5631         declaration.
5632         * maint.c (count_symtabs_and_blocks): Remove declaration.
5633         * cp-support.c (add_symbol_overload_list_qualified): Remove
5634         declaration.
5635         * coffread.c (coff_symtab_read): Remove declaration.
5636         * symtab.c (lookup_symbol_in_objfile_symtabs)
5637         (basic_lookup_transparent_type_1): Use objfile_compunits.
5638         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5639         (info_sources_command, search_symbols)
5640         (default_collect_symbol_completion_matches_break_on)
5641         (make_source_files_completion_list): Remove declaration.
5642         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5643         (ada_collect_symbol_completion_matches)
5644         (ada_add_global_exceptions): Remove declaration.
5645         * linespec.c (iterate_over_all_matching_symtabs): Use
5646         objfile_compunits.
5647         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5648         (class objfile_compunits): New.
5649         (ALL_COMPUNITS): Use objfile_compunits.
5650         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5651         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5652         objfile_compunits.
5653         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5654
5655 2019-01-09  Tom Tromey  <tom@tromey.com>
5656
5657         * symtab.c (search_symbols)
5658         (default_collect_symbol_completion_matches_break_on): Use
5659         objfile_msymbols.
5660         * ada-lang.c (ada_lookup_simple_minsym)
5661         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5662         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5663         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5664         objfile_msymbols.
5665         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5666         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5667         * objc-lang.c (find_methods): Use objfile_msymbols.
5668         (info_selectors_command, info_classes_command): Likewise.
5669         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5670         * objfiles.h (class objfile_msymbols): New.
5671         (ALL_OBJFILE_MSYMBOLS): Remove.
5672         (ALL_MSYMBOLS): Remove.
5673
5674 2019-01-09  Tom Tromey  <tom@tromey.com>
5675
5676         * common/next-iterator.h (next_adapter): Add Iterator template
5677         parameter.
5678         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5679         (class all_objfiles_safe): New.
5680         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5681         * objfiles.c (put_objfile_before): Update comment.
5682         (add_separate_debug_objfile): Likewise.
5683         (free_all_objfiles): Use all_objfiles_safe.
5684         (objfile_purge_solibs): Likewise.
5685
5686 2019-01-09  Tom Tromey  <tom@tromey.com>
5687
5688         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5689         (expand_symtab_containing_pc, lookup_static_symbol)
5690         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5691         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5692         all_objfiles.
5693         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5694         * breakpoint.c (create_overlay_event_breakpoint)
5695         (create_longjmp_master_breakpoint)
5696         (create_std_terminate_master_breakpoint)
5697         (create_exception_master_breakpoint): Use all_objfiles.
5698         * linux-thread-db.c (try_thread_db_load_from_pdir)
5699         (has_libpthread): Use all_objfiles.
5700         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5701         * linespec.c (iterate_over_all_matching_symtabs)
5702         (search_minsyms_for_name): Use all_objfiles.
5703         * maint.c (maintenance_info_sections): Use all_objfiles.
5704         * main.c (captured_main_1): Use all_objfiles.
5705         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5706         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5707         * guile/scm-pretty-print.c
5708         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5709         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5710         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5711         (maintenance_print_msymbols): Use all_objfiles.
5712         * source.c (select_source_symtab): Use all_objfiles.
5713         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5714         * symfile.c (remove_symbol_file_command)
5715         (expand_symtabs_matching, map_symbol_filenames): Use
5716         all_objfiles.
5717         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5718         all_objfiles.
5719         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5720         * objc-lang.c (find_methods): Use all_objfiles.
5721         * objfiles.c (have_partial_symbols, have_full_symbols)
5722         (have_minimal_symbols, qsort_cmp)
5723         (default_iterate_over_objfiles_in_search_order): Use
5724         all_objfiles.
5725         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5726         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5727         (maintenance_check_psymtabs): Use all_objfiles.
5728         (ALL_PSYMTABS): Remove.
5729         * compile/compile-object-run.c (do_module_cleanup): Use
5730         all_objfiles.
5731         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5732         * cp-support.c (add_symbol_overload_list_qualified): Use
5733         all_objfiles.
5734         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5735         Use all_objfiles.
5736         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5737         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5738         all_objfiles.
5739         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5740         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5741         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5742         Uses all_objfiles.
5743         * solib.c (solib_read_symbols): Use all_objfiles
5744
5745 2019-01-09  Tom Tromey  <tom@tromey.com>
5746
5747         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5748         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5749         all_objfiles.
5750         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5751         * symmisc.c (print_symbol_bcache_statistics)
5752         (print_objfile_statistics, maintenance_print_objfiles)
5753         (maintenance_info_symtabs, maintenance_check_symtabs)
5754         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5755         all_objfiles.
5756         * source.c (forget_cached_source_info): Use all_objfiles.
5757         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5758         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5759         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5760         * objfiles.c (update_section_map): Use all_objfiles.
5761         (shared_objfile_contains_address_p): Likewise.
5762         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5763         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5764
5765 2019-01-09  Tom Tromey  <tom@tromey.com>
5766
5767         * common/next-iterator.h: New file.
5768         * objfiles.h (class all_objfiles): New.
5769         (struct objfile_iterator): New.
5770
5771 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5772
5773         * NEWS: Move the description of the changed "frame", "select-frame",
5774          and "info frame" commands to the Changed commands section.
5775
5776 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5777
5778         * gdbtypes.c (check_stub_method_group): Remove handling of old
5779         mangling schemes.
5780         * linespec.c (find_methods): Likewise.
5781         * stabsread.c (read_member_functions): Likewise.
5782         * valops.c (search_struct_method): Likewise.
5783         (value_struct_elt_for_reference): Likewise.
5784         * NEWS: Mention this change.
5785
5786 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5787
5788         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5789         print_source_lines.
5790         * source.c (print_source_lines_base): Update line number check.
5791         (print_source_lines): New function.
5792         (source_lines_range::source_lines_range): New function.
5793         * source.h (class source_lines_range): New class.
5794         (print_source_lines): New declaration.
5795
5796 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5797
5798         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5799
5800 2019-01-08  Tom Tromey  <tom@tromey.com>
5801             Simon Marchi  <simon.marchi@ericsson.com>
5802
5803         PR gdb/24060
5804         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5805         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5806         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5807         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5808         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5809         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5810
5811 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5812
5813         * source.c (select_source_symtab): Move header comment to
5814         declaration in source.h.
5815         (forget_cached_source_info_for_objfile): Likewise.
5816         (forget_cached_source_info): Likewise.
5817         (identify_source_line): Likewise.
5818         * source.h (identify_source_line): Move declaration from symtab.h
5819         and add comment from source.c
5820         (print_source_lines): Likewise.
5821         (forget_cached_source_info_for_objfile): Likewise.
5822         (forget_cached_source_info): Likewise.
5823         (select_source_symtab): Likewise.
5824         (enum print_source_lines_flag): Move definition from symtab.h.
5825         * symtab.h (identify_source_line): Move declaration to source.h.
5826         (print_source_lines): Likewise.
5827         (forget_cached_source_info_for_objfile): Likewise.
5828         (forget_cached_source_info): Likewise.
5829         (select_source_symtab): Likewise.
5830         (enum print_source_lines_flag): Move definition to source.h.
5831         * tui/tui-hooks.c: Add 'source.h' include.
5832
5833 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5834
5835         * source.c (print_source_lines_base): Handle requests to print
5836         reverse line number sequences, and guard against empty lines
5837         string.
5838
5839 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5840
5841         * source.c (print_source_lines_base): Fix skip of '\r' if next
5842         character is '\n'.
5843
5844 2019-01-06  Tom Tromey  <tom@tromey.com>
5845
5846         * c-exp.y (struct c_parse_state) <macro_original_text,
5847         expansion_obstack>: New member.
5848         (macro_original_text, expansion_obstack): Remove globals.
5849         (scan_macro_expansion, scanning_macro_expansion)
5850         (finished_macro_expansion): Update.
5851         (scan_macro_cleanup): Remove.
5852         (yylex, c_parse): Update.
5853
5854 2019-01-06  Tom Tromey  <tom@tromey.com>
5855
5856         * c-exp.y (struct c_parse_state) <strings>: New member.
5857         (operator_stoken): Update.
5858
5859 2019-01-06  Tom Tromey  <tom@tromey.com>
5860
5861         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5862         (union type_stack_elt) <typelist_val>: Now a pointer to
5863         std::vector.
5864         (type_stack_cleanup): Don't declare.
5865         (push_typelist): Update.
5866         * parse.c (pop_typelist): Return a std::vector.
5867         (push_typelist): Take a std::vector.
5868         (follow_types): Update.  Do not free args.
5869         (type_stack_cleanup): Remove.
5870         * c-exp.y (struct c_parse_state): New.
5871         (cpstate): New global.
5872         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5873         (nonempty_typelist): Update.
5874         (func_mod): Create a new vector.
5875         (c_parse): Create a c_parse_state.
5876         (check_parameter_typelist): Do not delete params.
5877         (function_method): Update.  Do not delete type_list.
5878
5879 2019-01-06  Tom Tromey  <tom@tromey.com>
5880
5881         PR gdb/28155:
5882         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5883         check_typedef.
5884         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5885         (print_return_value): Likewise.
5886
5887 2019-01-05  Tom Tromey  <tom@tromey.com>
5888
5889         * contrib/cleanup_check.py: Remove.
5890         * contrib/gcc-with-excheck: Remove.
5891         * contrib/exsummary.py: Remove.
5892         * contrib/excheck.py: Remove.
5893
5894 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5895
5896         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5897         NULL. Initialize tpprev to NULL instead of assigning it
5898         to NULL on the next statement.
5899         * windows-nat.c (windows_delete_thread): Remove check for
5900         main_thread_id before printing thread exit notifications.
5901         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5902         Remove thread ID check against main_thread_id.
5903         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5904         windows_delete_thread.
5905         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5906
5907 2019-01-04  Tom Tromey  <tom@tromey.com>
5908
5909         * compile/compile.c (_initialize_compile): Use upper case for
5910         metasyntactic variables.
5911         * symmisc.c (_initialize_symmisc): Use upper case for
5912         metasyntactic variables.
5913         * psymtab.c (_initialize_psymtab): Use upper case for
5914         metasyntactic variables.
5915         * demangle.c (demangle_command): Use upper case for metasyntactic
5916         variables.
5917         (_initialize_demangler): Likewise.
5918         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5919         variables.
5920
5921 2019-01-03  Tom Tromey  <tom@tromey.com>
5922
5923         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5924
5925 2019-01-03  Tom Tromey  <tom@tromey.com>
5926
5927         * python/py-symtab.c (salpy_str): Update.
5928         (struct salpy_sal_object) <symtab>: Now a PyObject.
5929         (salpy_dealloc): Update.
5930         (del_objfile_sal): Use gdbpy_ref.
5931
5932 2019-01-03  Tom Tromey  <tom@tromey.com>
5933
5934         * python/py-type.c (convert_field): Use new_reference.  Return
5935         gdbpy_ref.
5936         (make_fielditem): Return gdbpy_ref.
5937         (typy_fields): Update.
5938         (typy_getitem): Update.
5939         (field_name): Return gdbpy_ref.  Use new_reference.
5940         (typy_iterator_iternext): Update.
5941
5942 2019-01-03  Tom Tromey  <tom@tromey.com>
5943
5944         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5945
5946 2019-01-03  Tom Tromey  <tom@tromey.com>
5947
5948         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5949         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5950         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5951         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5952         (pspy_set_type_printers): Likewise.
5953         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5954         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5955         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5956         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5957         (objfpy_set_type_printers): Likewise.
5958
5959 2019-01-03  Tom Tromey  <tom@tromey.com>
5960
5961         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5962         (gdbpy_print_stack): Use gdbpy_err_fetch.
5963         * python/python-internal.h (class gdbpy_err_fetch): New class.
5964         (class gdbpy_enter) <m_error_type, m_error_value,
5965         m_error_traceback>: Remove.
5966         <m_error>: New member.
5967         (gdbpy_exception_to_string): Don't declare.
5968         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5969         * python/py-value.c (convert_value_from_python): Use
5970         gdbpy_err_fetch.
5971         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5972         gdbpy_exception_to_string.
5973         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5974         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5975         gdbpy_err_fetch.
5976
5977 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5978
5979         * linux-nat.c (delete_lwp_cleanup): Delete.
5980         (struct lwp_deleter): New struct.
5981         (lwp_info_up): New typedef.
5982         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5983         lwp_info_up.
5984
5985 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5986
5987         * linux-fork.c (class scoped_switch_fork_info): New class.
5988         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5989
5990 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5991
5992         * valops.c (find_overload_match): Remove use of null_cleanup, and
5993         calls to do_cleanups.
5994
5995 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5996
5997         * compile/compile-cplus-types.c
5998         (compile_cplus_instance::decl_name): Handle changes to
5999         cp_func_name.
6000         * cp-support.c (cp_func_name): Update header comment, update
6001         return type.
6002         * cp-support.h (cp_func_name): Update return type in declaration.
6003         * valops.c (find_overload_match): Move temp_func local to top
6004         level of function and change its type.  Use temp_func to hold and
6005         delete temporary string obtained from cp_func_name.
6006
6007 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6008
6009         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6010         gdb::char_vector, remove cleanup, and update uses of `msg`.
6011
6012 2019-01-03  Jim Wilson  <jimw@sifive.com>
6013
6014         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6015
6016 2019-01-02  Tom Tromey  <tom@tromey.com>
6017
6018         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6019         (tdesc_parse_xml): Remove cleanups.
6020         * target-descriptions.h (make_cleanup_free_target_description):
6021         Don't declare.
6022         (target_desc_deleter): New struct.
6023         (target_desc_up): New typedef.
6024         * target-descriptions.c (target_desc_deleter::operator()): Rename
6025         from free_target_description.
6026         (make_cleanup_free_target_description): Remove.
6027
6028 2019-01-02  Tom Tromey  <tom@tromey.com>
6029
6030         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6031         constructor, destructor.
6032         (linespec_parser): Remove typedef.
6033         (~linespec_parser): Rename from linespec_parser_delete.
6034         (linespec_lex_to_end, linespec_complete_label)
6035         (linespec_complete): Update.
6036         (decode_line_full): Remove cleanups.
6037         (decode_line_1): Update.
6038
6039 2019-01-02  Tom Tromey  <tom@tromey.com>
6040
6041         * python/python-internal.h (inferior_to_inferior_object): Change
6042         return type.
6043         * python/py-exitedevent.c (create_exited_event_object): Update.
6044         * python/py-inferior.c (inferior_to_inferior_object): Return
6045         gdbpy_ref.
6046         (python_new_inferior, python_inferior_deleted)
6047         (thread_to_thread_object, delete_thread_object)
6048         (build_inferior_list, gdbpy_selected_inferior): Update.
6049         * python/py-infthread.c (create_thread_object): Update.  Also fail
6050         if inferior_to_inferior_object fails.
6051
6052 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6053
6054         * inferior.h (class inferior) <displaced_step_state>: New field.
6055         * infrun.h (struct displaced_step_state): Move here from
6056         infrun.c.  Initialize fields, add constructor.
6057         <inf>: Remove field.
6058         <reset>: New method.
6059         * infrun.c (struct displaced_step_inferior_state): Move to
6060         infrun.h.
6061         (displaced_step_inferior_states): Remove.
6062         (get_displaced_stepping_state): Adust.
6063         (displaced_step_in_progress_any_inferior): Adjust.
6064         (displaced_step_in_progress_thread): Adjust.
6065         (displaced_step_in_progress): Adjust.
6066         (add_displaced_stepping_state): Remove.
6067         (get_displaced_step_closure_by_addr): Adjust.
6068         (remove_displaced_stepping_state): Remove.
6069         (infrun_inferior_exit): Call displaced_step_state.reset.
6070         (use_displaced_stepping): Don't check for NULL.
6071         (displaced_step_prepare_throw): Call
6072         get_displaced_stepping_state.
6073         (displaced_step_fixup): Don't check for NULL.
6074         (prepare_for_detach): Don't check for NULL.
6075
6076 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6077
6078         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6079          in case of call that did not complete.
6080
6081 2019-01-02  Andrey Utkin  <autkin@undo.io>
6082
6083         * symfile.c (find_separate_debug_file): Fix search of debug files for
6084         remote debuggee.
6085
6086 2019-01-02  Tom Tromey  <tom@tromey.com>
6087
6088         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6089         indentation.
6090         * python/py-frame.c (frapy_older): Remove cast.
6091         (frapy_newer): Likewise.
6092         * python/py-breakpoint.c (local_setattro): Remove cast.
6093         * python/py-arch.c (archpy_name): Remove local variable.
6094         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6095
6096 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6097
6098         * unittests/basic_string_view/element_access/char/empty.cc:
6099         Fix year range in copyright header.
6100
6101 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6102
6103         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6104         Delete.
6105         <operator==>: Update with for removed field.
6106         <hash>: Likewise.
6107         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6108         <isa_features>: ...this.
6109         <abi_features>: New field.
6110         (riscv_isa_flen): Update comment.
6111         (riscv_abi_xlen): New declaration.
6112         (riscv_abi_flen): New declaration.
6113         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6114         isa_features.
6115         (riscv_abi_xlen): New function.
6116         (riscv_isa_flen): Update to get answer from isa_features.
6117         (riscv_abi_flen): New function.
6118         (riscv_has_fp_abi): Update to get answer from abi_features.
6119         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6120         xlen and flen.
6121         (riscv_call_info) <xlen, flen>: Update comment.
6122         (riscv_call_arg_struct): Remove invalid assertions
6123         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6124         is removed.
6125         (riscv_gdbarch_init): Gather isa features and abi features
6126         separately, ensure both match on the gdbarch when reusing an old
6127         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6128         a target with 64-bit float hardware.
6129
6130 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6131
6132         * source.c (search_command_helper): Stop reverse search
6133         when line 1 has been searched.
6134
6135 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6136
6137         * record-full.c (record_full_base_target::close): Rewrite
6138         record_full_core_buf_list free logic.
6139
6140 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6141
6142         * break-catch-syscall.c (print_one_catch_syscall): xfree
6143         the last text.
6144
6145 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6146
6147         * top.c (print_gdb_version): Update Copyright year in version
6148         message.
6149
6150 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6151
6152         Update copyright year range in all GDB files.
6153
6154 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6155
6156         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6157
6158 For older changes see ChangeLog-2018.
6159 \f
6160 Local Variables:
6161 mode: change-log
6162 left-margin: 8
6163 fill-column: 74
6164 version-control: never
6165 coding: utf-8
6166 End:
6167