gdb/ChangeLog

   1 2019-02-14  David Michael  <fedora.dm0@gmail.com>
   2             Samuel Thibault  <samuel.thibault@gnu.org>
   3             Thomas Schwinge  <thomas@codesourcery.com>
   4
   5         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
   6         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
   7
   8 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
   9
  10         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
  11         (check_empty): Use "const char *".
  12
  13         * gnu-nat.c (gnu_nat_target::detach): Instead of
  14         'detach_inferior (pid)' call
  15         'detach_inferior (find_inferior_pid (pid))'.
  16
  17         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
  18         'nat/fork-inferior.o'.
  19         * gnu-nat.c: #include "nat/fork-inferior.h".
  20
  21         * gnu-nat.c (gnu_nat_target::detach): Instead of
  22         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
  23         * gnu-nat.h: #include "inf-child.h".
  24         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
  25         'i386_gnu_nat_target::fetch_registers'.
  26         (gnu_store_registers): Rename/move to
  27         'i386_gnu_nat_target::store_registers'.
  28
  29         * config/i386/nm-i386gnu.h: Don't "#include" any files.
  30         * gnu-nat.h (mach_thread_info): New function.
  31         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
  32
  33         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
  34
  35 2019-02-14  Frederic Konrad  <konrad@adacore.com>
  36
  37         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
  38
  39 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
  40
  41         * windows-nat.c (windows_add_thread): Add new parameter
  42         "main_thread_p" with default value set to false.  Update
  43         function documentation as well as all callers.
  44         (windows_delete_thread): Likewise.
  45         (fake_create_process): Update call to windows_add_thread.
  46         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
  47         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
  48         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
  49         call to windows_delete_thread.
  50
  51 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
  52
  53         * MAINTAINERS: Add Andrew Burgess as global maintainer.
  54
  55 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  56
  57         * symfile.c (find_separate_debug_file): Use canonical path of
  58         sysroot with child_path instead of gdb_sysroot if it is valid.
  59
  60 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  61
  62         * symfile.c (find_separate_debug_file): Use child_path to
  63         determine if an object file is under a sysroot.
  64
  65 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  66
  67         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
  68         unittests/child-path-selftests.c.
  69         * common/pathstuff.c (child_path): New function.
  70         * common/pathstuff.h (child_path): New prototype.
  71         * unittests/child-path-selftests.c: New file.
  72
  73 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
  74
  75         * symfile.c (find_separate_debug_file): Look for separate debug
  76         files in debug directories under the sysroot.
  77
  78 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  79
  80         * symtab.h (struct minimal_symbol data_p): New const method.
  81         (struct minimal_symbol text_p): Likewise.
  82         * symtab.c (output_source_filename): Use file name style
  83         to print file name.
  84         (print_symbol_info): Likewise.
  85         (print_msymbol_info): Use address style to print addresses.
  86         Use function name style to print executable text symbols.
  87         (expand_symtab_containing_pc): Use data_p.
  88         (find_pc_sect_compunit_symtab): Likewise.
  89
  90 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  91
  92         * breakpoint.c (describe_other_breakpoints): Use address style
  93         to print addresses.
  94         (say_where): Likewise.
  95
  96 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  97
  98         * ada-typeprint.c (print_func_type): Print function name
  99         style to print function name.
 100         * c-typeprint.c (c_print_type_1): Likewise.
 101
 102 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
 103
 104         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
 105         for execve.
 106
 107 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 108
 109         * c-exp.y (direct_abs_decl): Use emplace_back to record the
 110         type_stack.
 111
 112 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
 113
 114         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
 115         TYPE_CODE_REF types.
 116
 117 2019-02-08  Jim Wilson  <jimw@sifive.com>
 118
 119         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
 120         (riscv_linux_fregset): New.
 121         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
 122
 123 2019-02-07  Tom Tromey  <tom@tromey.com>
 124
 125         * thread.c (thread_cancel_execution_command): Update.
 126         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
 127         methods.
 128         (struct thread_fsm_ops): Remove.
 129         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
 130         (thread_fsm_should_stop, thread_fsm_return_value)
 131         (thread_fsm_set_finished, thread_fsm_finished_p)
 132         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
 133         Don't declare.
 134         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
 135         * infrun.c (clear_proceed_status_thread)
 136         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
 137         (print_stop_event): Update.
 138         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
 139         Add constructor.
 140         (step_command_fsm_ops): Remove.
 141         (new_step_command_fsm): Remove.
 142         (step_1): Update.
 143         (step_command_fsm::should_stop): Rename from
 144         step_command_fsm_should_stop.
 145         (step_command_fsm::clean_up): Rename from
 146         step_command_fsm_clean_up.
 147         (step_command_fsm::do_async_reply_reason): Rename from
 148         step_command_fsm_async_reply_reason.
 149         (struct until_next_fsm): Inherit from thread_fsm.  Add
 150         constructor.
 151         (until_next_fsm_ops): Remove.
 152         (new_until_next_fsm): Remove.
 153         (until_next_fsm::should_stop): Rename from
 154         until_next_fsm_should_stop.
 155         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
 156         (until_next_fsm::do_async_reply_reason): Rename from
 157         until_next_fsm_async_reply_reason.
 158         (struct finish_command_fsm): Inherit from thread_fsm.  Add
 159         constructor.  Change type of breakpoint.
 160         (finish_command_fsm_ops): Remove.
 161         (new_finish_command_fsm): Remove.
 162         (finish_command_fsm::should_stop): Rename from
 163         finish_command_fsm_should_stop.
 164         (finish_command_fsm::clean_up): Rename from
 165         finish_command_fsm_clean_up.
 166         (finish_command_fsm::return_value): Rename from
 167         finish_command_fsm_return_value.
 168         (finish_command_fsm::do_async_reply_reason): Rename from
 169         finish_command_fsm_async_reply_reason.
 170         (finish_command): Update.
 171         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
 172         Add constructor.
 173         (call_thread_fsm_ops): Remove.
 174         (call_thread_fsm::call_thread_fsm): Rename from
 175         new_call_thread_fsm.
 176         (call_thread_fsm::should_stop): Rename from
 177         call_thread_fsm_should_stop.
 178         (call_thread_fsm::should_notify_stop): Rename from
 179         call_thread_fsm_should_notify_stop.
 180         (run_inferior_call, call_function_by_hand_dummy): Update.
 181         * cli/cli-interp.c (should_print_stop_to_console): Update.
 182         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
 183         Add constructor.  Change type of location_breakpoint,
 184         caller_breakpoint.
 185         (until_break_fsm_ops): Remove.
 186         (new_until_break_fsm): Remove.
 187         (until_break_fsm::should_stop): Rename from
 188         until_break_fsm_should_stop.
 189         (until_break_fsm::clean_up): Rename from
 190         until_break_fsm_clean_up.
 191         (until_break_fsm::do_async_reply_reason): Rename from
 192         until_break_fsm_async_reply_reason.
 193         (until_break_command): Update.
 194         * thread-fsm.c: Remove.
 195         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
 196
 197 2019-02-07  Tom Tromey  <tom@tromey.com>
 198
 199         * yy-remap.h: Add include guard.
 200         * xtensa-tdep.h: Add include guard.
 201         * xcoffread.h: Rename include guard.
 202         * varobj-iter.h: Add include guard.
 203         * tui/tui.h: Rename include guard.
 204         * tui/tui-winsource.h: Rename include guard.
 205         * tui/tui-wingeneral.h: Rename include guard.
 206         * tui/tui-windata.h: Rename include guard.
 207         * tui/tui-win.h: Rename include guard.
 208         * tui/tui-stack.h: Rename include guard.
 209         * tui/tui-source.h: Rename include guard.
 210         * tui/tui-regs.h: Rename include guard.
 211         * tui/tui-out.h: Rename include guard.
 212         * tui/tui-layout.h: Rename include guard.
 213         * tui/tui-io.h: Rename include guard.
 214         * tui/tui-hooks.h: Rename include guard.
 215         * tui/tui-file.h: Rename include guard.
 216         * tui/tui-disasm.h: Rename include guard.
 217         * tui/tui-data.h: Rename include guard.
 218         * tui/tui-command.h: Rename include guard.
 219         * tic6x-tdep.h: Add include guard.
 220         * target/waitstatus.h: Rename include guard.
 221         * target/wait.h: Rename include guard.
 222         * target/target.h: Rename include guard.
 223         * target/resume.h: Rename include guard.
 224         * target-float.h: Rename include guard.
 225         * stabsread.h: Add include guard.
 226         * rs6000-tdep.h: Add include guard.
 227         * riscv-fbsd-tdep.h: Add include guard.
 228         * regformats/regdef.h: Rename include guard.
 229         * record.h: Rename include guard.
 230         * python/python.h: Rename include guard.
 231         * python/python-internal.h: Rename include guard.
 232         * python/py-stopevent.h: Rename include guard.
 233         * python/py-ref.h: Rename include guard.
 234         * python/py-record.h: Rename include guard.
 235         * python/py-record-full.h: Rename include guard.
 236         * python/py-record-btrace.h: Rename include guard.
 237         * python/py-instruction.h: Rename include guard.
 238         * python/py-events.h: Rename include guard.
 239         * python/py-event.h: Rename include guard.
 240         * procfs.h: Add include guard.
 241         * proc-utils.h: Add include guard.
 242         * p-lang.h: Add include guard.
 243         * or1k-tdep.h: Rename include guard.
 244         * observable.h: Rename include guard.
 245         * nto-tdep.h: Rename include guard.
 246         * nat/x86-linux.h: Rename include guard.
 247         * nat/x86-linux-dregs.h: Rename include guard.
 248         * nat/x86-gcc-cpuid.h: Add include guard.
 249         * nat/x86-dregs.h: Rename include guard.
 250         * nat/x86-cpuid.h: Rename include guard.
 251         * nat/ppc-linux.h: Rename include guard.
 252         * nat/mips-linux-watch.h: Rename include guard.
 253         * nat/linux-waitpid.h: Rename include guard.
 254         * nat/linux-ptrace.h: Rename include guard.
 255         * nat/linux-procfs.h: Rename include guard.
 256         * nat/linux-osdata.h: Rename include guard.
 257         * nat/linux-nat.h: Rename include guard.
 258         * nat/linux-namespaces.h: Rename include guard.
 259         * nat/linux-btrace.h: Rename include guard.
 260         * nat/glibc_thread_db.h: Rename include guard.
 261         * nat/gdb_thread_db.h: Rename include guard.
 262         * nat/gdb_ptrace.h: Rename include guard.
 263         * nat/fork-inferior.h: Rename include guard.
 264         * nat/amd64-linux-siginfo.h: Rename include guard.
 265         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
 266         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
 267         * nat/aarch64-linux.h: Rename include guard.
 268         * nat/aarch64-linux-hw-point.h: Rename include guard.
 269         * mn10300-tdep.h: Add include guard.
 270         * mips-linux-tdep.h: Add include guard.
 271         * mi/mi-parse.h: Rename include guard.
 272         * mi/mi-out.h: Rename include guard.
 273         * mi/mi-main.h: Rename include guard.
 274         * mi/mi-interp.h: Rename include guard.
 275         * mi/mi-getopt.h: Rename include guard.
 276         * mi/mi-console.h: Rename include guard.
 277         * mi/mi-common.h: Rename include guard.
 278         * mi/mi-cmds.h: Rename include guard.
 279         * mi/mi-cmd-break.h: Rename include guard.
 280         * m2-lang.h: Add include guard.
 281         * location.h: Rename include guard.
 282         * linux-record.h: Rename include guard.
 283         * linux-nat.h: Add include guard.
 284         * linux-fork.h: Add include guard.
 285         * i386-darwin-tdep.h: Rename include guard.
 286         * hppa-linux-offsets.h: Add include guard.
 287         * guile/guile.h: Rename include guard.
 288         * guile/guile-internal.h: Rename include guard.
 289         * gnu-nat.h: Rename include guard.
 290         * gdb-stabs.h: Rename include guard.
 291         * frv-tdep.h: Add include guard.
 292         * f-lang.h: Add include guard.
 293         * event-loop.h: Add include guard.
 294         * darwin-nat.h: Rename include guard.
 295         * cp-abi.h: Rename include guard.
 296         * config/sparc/nm-sol2.h: Rename include guard.
 297         * config/nm-nto.h: Rename include guard.
 298         * config/nm-linux.h: Add include guard.
 299         * config/i386/nm-i386gnu.h: Rename include guard.
 300         * config/djgpp/nl_types.h: Rename include guard.
 301         * config/djgpp/langinfo.h: Rename include guard.
 302         * compile/gcc-cp-plugin.h: Add include guard.
 303         * compile/gcc-c-plugin.h: Add include guard.
 304         * compile/compile.h: Rename include guard.
 305         * compile/compile-object-run.h: Rename include guard.
 306         * compile/compile-object-load.h: Rename include guard.
 307         * compile/compile-internal.h: Rename include guard.
 308         * compile/compile-cplus.h: Rename include guard.
 309         * compile/compile-c.h: Rename include guard.
 310         * common/xml-utils.h: Rename include guard.
 311         * common/x86-xstate.h: Rename include guard.
 312         * common/version.h: Rename include guard.
 313         * common/vec.h: Rename include guard.
 314         * common/tdesc.h: Rename include guard.
 315         * common/selftest.h: Rename include guard.
 316         * common/scoped_restore.h: Rename include guard.
 317         * common/scoped_mmap.h: Rename include guard.
 318         * common/scoped_fd.h: Rename include guard.
 319         * common/safe-iterator.h: Rename include guard.
 320         * common/run-time-clock.h: Rename include guard.
 321         * common/refcounted-object.h: Rename include guard.
 322         * common/queue.h: Rename include guard.
 323         * common/ptid.h: Rename include guard.
 324         * common/print-utils.h: Rename include guard.
 325         * common/preprocessor.h: Rename include guard.
 326         * common/pathstuff.h: Rename include guard.
 327         * common/observable.h: Rename include guard.
 328         * common/netstuff.h: Rename include guard.
 329         * common/job-control.h: Rename include guard.
 330         * common/host-defs.h: Rename include guard.
 331         * common/gdb_wait.h: Rename include guard.
 332         * common/gdb_vecs.h: Rename include guard.
 333         * common/gdb_unlinker.h: Rename include guard.
 334         * common/gdb_unique_ptr.h: Rename include guard.
 335         * common/gdb_tilde_expand.h: Rename include guard.
 336         * common/gdb_sys_time.h: Rename include guard.
 337         * common/gdb_string_view.h: Rename include guard.
 338         * common/gdb_splay_tree.h: Rename include guard.
 339         * common/gdb_setjmp.h: Rename include guard.
 340         * common/gdb_ref_ptr.h: Rename include guard.
 341         * common/gdb_optional.h: Rename include guard.
 342         * common/gdb_locale.h: Rename include guard.
 343         * common/gdb_assert.h: Rename include guard.
 344         * common/filtered-iterator.h: Rename include guard.
 345         * common/filestuff.h: Rename include guard.
 346         * common/fileio.h: Rename include guard.
 347         * common/environ.h: Rename include guard.
 348         * common/common-utils.h: Rename include guard.
 349         * common/common-types.h: Rename include guard.
 350         * common/common-regcache.h: Rename include guard.
 351         * common/common-inferior.h: Rename include guard.
 352         * common/common-gdbthread.h: Rename include guard.
 353         * common/common-exceptions.h: Rename include guard.
 354         * common/common-defs.h: Rename include guard.
 355         * common/common-debug.h: Rename include guard.
 356         * common/cleanups.h: Rename include guard.
 357         * common/buffer.h: Rename include guard.
 358         * common/btrace-common.h: Rename include guard.
 359         * common/break-common.h: Rename include guard.
 360         * cli/cli-utils.h: Rename include guard.
 361         * cli/cli-style.h: Rename include guard.
 362         * cli/cli-setshow.h: Rename include guard.
 363         * cli/cli-script.h: Rename include guard.
 364         * cli/cli-interp.h: Rename include guard.
 365         * cli/cli-decode.h: Rename include guard.
 366         * cli/cli-cmds.h: Rename include guard.
 367         * charset-list.h: Add include guard.
 368         * buildsym-legacy.h: Rename include guard.
 369         * bfin-tdep.h: Add include guard.
 370         * ax.h: Rename include guard.
 371         * arm-linux-tdep.h: Add include guard.
 372         * arm-fbsd-tdep.h: Add include guard.
 373         * arch/xtensa.h: Rename include guard.
 374         * arch/tic6x.h: Add include guard.
 375         * arch/i386.h: Add include guard.
 376         * arch/arm.h: Rename include guard.
 377         * arch/arm-linux.h: Rename include guard.
 378         * arch/arm-get-next-pcs.h: Rename include guard.
 379         * arch/amd64.h: Add include guard.
 380         * arch/aarch64-insn.h: Rename include guard.
 381         * arch-utils.h: Rename include guard.
 382         * annotate.h: Add include guard.
 383         * amd64-darwin-tdep.h: Rename include guard.
 384         * aarch64-linux-tdep.h: Add include guard.
 385         * aarch64-fbsd-tdep.h: Add include guard.
 386         * aarch32-linux-nat.h: Add include guard.
 387
 388 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 389
 390         * macrotab.c (macro_define_internal): New function that
 391         factorizes macro_define_object_internal and macro_define_function
 392         code.
 393         (macro_define_object_internal): Use macro_define_internal.
 394         (macro_define_function): Likewise.
 395
 396 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 397
 398         * macrocmd.c (extract_identifier): Return
 399         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
 400         callers.
 401
 402 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
 403
 404         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
 405
 406 2019-02-05  Tom Tromey  <tom@tromey.com>
 407
 408         * target.c (target_stack::unpush): Move assertion earlier.
 409
 410 2019-01-30  Tom Tromey  <tom@tromey.com>
 411
 412         PR python/23615:
 413         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
 414         (gdbpy_parse_and_eval): Likewise.
 415         * python/python-internal.h (gdbpy_allow_threads): New class.
 416
 417 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
 418
 419         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
 420         (aarch64_fbsd_fpregmap): Move earlier.
 421         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
 422         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 423         instead of individual calls to trad_frame_set_reg_addr.
 424         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
 425         earlier.
 426         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
 427         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
 428         instead of individual calls to trad_frame_set_reg_addr.
 429
 430 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
 431
 432         * CONTRIBUTE: Replace contribution list with wiki link.
 433
 434 2019-01-25  Tom Tromey  <tom@tromey.com>
 435
 436         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
 437
 438 2019-01-25  Tom Tromey  <tom@tromey.com>
 439
 440         * xtensa-linux-nat.c: Fix common/ includes.
 441         * xml-support.h: Fix common/ includes.
 442         * xml-support.c: Fix common/ includes.
 443         * x86-linux-nat.c: Fix common/ includes.
 444         * windows-nat.c: Fix common/ includes.
 445         * varobj.h: Fix common/ includes.
 446         * varobj.c: Fix common/ includes.
 447         * value.c: Fix common/ includes.
 448         * valops.c: Fix common/ includes.
 449         * utils.c: Fix common/ includes.
 450         * unittests/xml-utils-selftests.c: Fix common/ includes.
 451         * unittests/utils-selftests.c: Fix common/ includes.
 452         * unittests/unpack-selftests.c: Fix common/ includes.
 453         * unittests/tracepoint-selftests.c: Fix common/ includes.
 454         * unittests/style-selftests.c: Fix common/ includes.
 455         * unittests/string_view-selftests.c: Fix common/ includes.
 456         * unittests/scoped_restore-selftests.c: Fix common/ includes.
 457         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
 458         * unittests/scoped_fd-selftests.c: Fix common/ includes.
 459         * unittests/rsp-low-selftests.c: Fix common/ includes.
 460         * unittests/parse-connection-spec-selftests.c: Fix common/
 461         includes.
 462         * unittests/optional-selftests.c: Fix common/ includes.
 463         * unittests/offset-type-selftests.c: Fix common/ includes.
 464         * unittests/observable-selftests.c: Fix common/ includes.
 465         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
 466         * unittests/memrange-selftests.c: Fix common/ includes.
 467         * unittests/memory-map-selftests.c: Fix common/ includes.
 468         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
 469         * unittests/function-view-selftests.c: Fix common/ includes.
 470         * unittests/environ-selftests.c: Fix common/ includes.
 471         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
 472         * unittests/common-utils-selftests.c: Fix common/ includes.
 473         * unittests/cli-utils-selftests.c: Fix common/ includes.
 474         * unittests/array-view-selftests.c: Fix common/ includes.
 475         * ui-file.c: Fix common/ includes.
 476         * tui/tui-io.c: Fix common/ includes.
 477         * tracepoint.h: Fix common/ includes.
 478         * tracepoint.c: Fix common/ includes.
 479         * tracefile-tfile.c: Fix common/ includes.
 480         * top.h: Fix common/ includes.
 481         * top.c: Fix common/ includes.
 482         * thread.c: Fix common/ includes.
 483         * target/waitstatus.h: Fix common/ includes.
 484         * target/waitstatus.c: Fix common/ includes.
 485         * target.h: Fix common/ includes.
 486         * target.c: Fix common/ includes.
 487         * target-memory.c: Fix common/ includes.
 488         * target-descriptions.c: Fix common/ includes.
 489         * symtab.h: Fix common/ includes.
 490         * symfile.c: Fix common/ includes.
 491         * stap-probe.c: Fix common/ includes.
 492         * spu-linux-nat.c: Fix common/ includes.
 493         * sparc-nat.c: Fix common/ includes.
 494         * source.c: Fix common/ includes.
 495         * solib.c: Fix common/ includes.
 496         * solib-target.c: Fix common/ includes.
 497         * ser-unix.c: Fix common/ includes.
 498         * ser-tcp.c: Fix common/ includes.
 499         * ser-pipe.c: Fix common/ includes.
 500         * ser-base.c: Fix common/ includes.
 501         * selftest-arch.c: Fix common/ includes.
 502         * s12z-tdep.c: Fix common/ includes.
 503         * rust-exp.y: Fix common/ includes.
 504         * rs6000-aix-tdep.c: Fix common/ includes.
 505         * riscv-tdep.c: Fix common/ includes.
 506         * remote.c: Fix common/ includes.
 507         * remote-notif.h: Fix common/ includes.
 508         * remote-fileio.h: Fix common/ includes.
 509         * remote-fileio.c: Fix common/ includes.
 510         * regcache.h: Fix common/ includes.
 511         * regcache.c: Fix common/ includes.
 512         * record-btrace.c: Fix common/ includes.
 513         * python/python.c: Fix common/ includes.
 514         * python/py-type.c: Fix common/ includes.
 515         * python/py-inferior.c: Fix common/ includes.
 516         * progspace.h: Fix common/ includes.
 517         * producer.c: Fix common/ includes.
 518         * procfs.c: Fix common/ includes.
 519         * proc-api.c: Fix common/ includes.
 520         * printcmd.c: Fix common/ includes.
 521         * ppc-linux-nat.c: Fix common/ includes.
 522         * parser-defs.h: Fix common/ includes.
 523         * osdata.c: Fix common/ includes.
 524         * obsd-nat.c: Fix common/ includes.
 525         * nat/x86-linux.c: Fix common/ includes.
 526         * nat/x86-linux-dregs.c: Fix common/ includes.
 527         * nat/x86-dregs.h: Fix common/ includes.
 528         * nat/x86-dregs.c: Fix common/ includes.
 529         * nat/ppc-linux.c: Fix common/ includes.
 530         * nat/mips-linux-watch.h: Fix common/ includes.
 531         * nat/mips-linux-watch.c: Fix common/ includes.
 532         * nat/linux-waitpid.c: Fix common/ includes.
 533         * nat/linux-ptrace.h: Fix common/ includes.
 534         * nat/linux-ptrace.c: Fix common/ includes.
 535         * nat/linux-procfs.c: Fix common/ includes.
 536         * nat/linux-personality.c: Fix common/ includes.
 537         * nat/linux-osdata.c: Fix common/ includes.
 538         * nat/linux-namespaces.c: Fix common/ includes.
 539         * nat/linux-btrace.h: Fix common/ includes.
 540         * nat/linux-btrace.c: Fix common/ includes.
 541         * nat/fork-inferior.c: Fix common/ includes.
 542         * nat/amd64-linux-siginfo.c: Fix common/ includes.
 543         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
 544         * nat/aarch64-linux.c: Fix common/ includes.
 545         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
 546         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
 547         * namespace.h: Fix common/ includes.
 548         * mips-linux-tdep.c: Fix common/ includes.
 549         * minsyms.c: Fix common/ includes.
 550         * mi/mi-parse.h: Fix common/ includes.
 551         * mi/mi-main.c: Fix common/ includes.
 552         * mi/mi-cmd-env.c: Fix common/ includes.
 553         * memrange.h: Fix common/ includes.
 554         * memattr.c: Fix common/ includes.
 555         * maint.h: Fix common/ includes.
 556         * maint.c: Fix common/ includes.
 557         * main.c: Fix common/ includes.
 558         * machoread.c: Fix common/ includes.
 559         * location.c: Fix common/ includes.
 560         * linux-thread-db.c: Fix common/ includes.
 561         * linux-nat.c: Fix common/ includes.
 562         * linux-fork.c: Fix common/ includes.
 563         * inline-frame.c: Fix common/ includes.
 564         * infrun.c: Fix common/ includes.
 565         * inflow.c: Fix common/ includes.
 566         * inferior.h: Fix common/ includes.
 567         * inferior.c: Fix common/ includes.
 568         * infcmd.c: Fix common/ includes.
 569         * inf-ptrace.c: Fix common/ includes.
 570         * inf-child.c: Fix common/ includes.
 571         * ia64-linux-nat.c: Fix common/ includes.
 572         * i387-tdep.c: Fix common/ includes.
 573         * i386-tdep.c: Fix common/ includes.
 574         * i386-linux-tdep.c: Fix common/ includes.
 575         * i386-linux-nat.c: Fix common/ includes.
 576         * i386-go32-tdep.c: Fix common/ includes.
 577         * i386-fbsd-tdep.c: Fix common/ includes.
 578         * i386-fbsd-nat.c: Fix common/ includes.
 579         * guile/scm-type.c: Fix common/ includes.
 580         * guile/guile.c: Fix common/ includes.
 581         * go32-nat.c: Fix common/ includes.
 582         * gnu-nat.c: Fix common/ includes.
 583         * gdbthread.h: Fix common/ includes.
 584         * gdbarch-selftests.c: Fix common/ includes.
 585         * gdb_usleep.c: Fix common/ includes.
 586         * gdb_select.h: Fix common/ includes.
 587         * gdb_bfd.c: Fix common/ includes.
 588         * gcore.c: Fix common/ includes.
 589         * fork-child.c: Fix common/ includes.
 590         * findvar.c: Fix common/ includes.
 591         * fbsd-nat.c: Fix common/ includes.
 592         * event-top.c: Fix common/ includes.
 593         * event-loop.c: Fix common/ includes.
 594         * dwarf2read.c: Fix common/ includes.
 595         * dwarf2loc.c: Fix common/ includes.
 596         * dwarf2-frame.c: Fix common/ includes.
 597         * dwarf-index-cache.c: Fix common/ includes.
 598         * dtrace-probe.c: Fix common/ includes.
 599         * disasm-selftests.c: Fix common/ includes.
 600         * defs.h: Fix common/ includes.
 601         * csky-tdep.c: Fix common/ includes.
 602         * cp-valprint.c: Fix common/ includes.
 603         * cp-support.h: Fix common/ includes.
 604         * cp-support.c: Fix common/ includes.
 605         * corelow.c: Fix common/ includes.
 606         * completer.h: Fix common/ includes.
 607         * completer.c: Fix common/ includes.
 608         * compile/compile.c: Fix common/ includes.
 609         * compile/compile-loc2c.c: Fix common/ includes.
 610         * compile/compile-cplus-types.c: Fix common/ includes.
 611         * compile/compile-cplus-symbols.c: Fix common/ includes.
 612         * command.h: Fix common/ includes.
 613         * cli/cli-dump.c: Fix common/ includes.
 614         * cli/cli-cmds.c: Fix common/ includes.
 615         * charset.c: Fix common/ includes.
 616         * build-id.c: Fix common/ includes.
 617         * btrace.h: Fix common/ includes.
 618         * btrace.c: Fix common/ includes.
 619         * breakpoint.h: Fix common/ includes.
 620         * breakpoint.c: Fix common/ includes.
 621         * ax.h:
 622         (enum agent_op): Fix common/ includes.
 623         * ax-general.c (struct aop_map): Fix common/ includes.
 624         * ax-gdb.c: Fix common/ includes.
 625         * auxv.c: Fix common/ includes.
 626         * auto-load.c: Fix common/ includes.
 627         * arm-tdep.c: Fix common/ includes.
 628         * arch/riscv.c: Fix common/ includes.
 629         * arch/ppc-linux-common.c: Fix common/ includes.
 630         * arch/i386.c: Fix common/ includes.
 631         * arch/arm.c: Fix common/ includes.
 632         * arch/arm-linux.c: Fix common/ includes.
 633         * arch/arm-get-next-pcs.c: Fix common/ includes.
 634         * arch/amd64.c: Fix common/ includes.
 635         * arch/aarch64.c: Fix common/ includes.
 636         * arch/aarch64-insn.c: Fix common/ includes.
 637         * arch-utils.c: Fix common/ includes.
 638         * amd64-windows-tdep.c: Fix common/ includes.
 639         * amd64-tdep.c: Fix common/ includes.
 640         * amd64-sol2-tdep.c: Fix common/ includes.
 641         * amd64-obsd-tdep.c: Fix common/ includes.
 642         * amd64-nbsd-tdep.c: Fix common/ includes.
 643         * amd64-linux-tdep.c: Fix common/ includes.
 644         * amd64-linux-nat.c: Fix common/ includes.
 645         * amd64-fbsd-tdep.c: Fix common/ includes.
 646         * amd64-fbsd-nat.c: Fix common/ includes.
 647         * amd64-dicos-tdep.c: Fix common/ includes.
 648         * amd64-darwin-tdep.c: Fix common/ includes.
 649         * agent.c: Fix common/ includes.
 650         * ada-lang.h: Fix common/ includes.
 651         * ada-lang.c: Fix common/ includes.
 652         * aarch64-tdep.c: Fix common/ includes.
 653
 654 2019-01-25  Tom Tromey  <tom@tromey.com>
 655
 656         * common/create-version.sh: Use common/version.h.
 657
 658 2019-01-24  Pedro Alves  <palves@redhat.com>
 659
 660         * infrun.c (signal_stop, signal_print, signal_program)
 661         (signal_catch, signal_pass): Now arrays instead of pointers.
 662         (update_signals_program_target, do_target_resume)
 663         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
 664         * linux-nat.c (linux_nat_target::pass_signals)
 665         (linux_nat_target::create_inferior, linux_nat_target::attach):
 666         Adjust.
 667         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
 668         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
 669         * procfs.c (procfs_target::pass_signals): Adjust.
 670         * record-full.c (record_full_target::resume): Adjust.
 671         * remote.c (remote_target::pass_signals)
 672         (remote_target::program_signals): Adjust.
 673         * target-debug.h (target_debug_print_signals): Now takes a
 674         gdb::array_view as parameter.  Adjust.
 675         * target.h (target_ops) <pass_signals, program_signals>: Replace
 676         pointer and length parameters with gdb::array_view.
 677         (target_pass_signals, target_program_signals): Likewise.
 678         * target-delegates.c: Regenerate.
 679
 680 2019-01-24  Pedro Alves  <palves@redhat.com>
 681
 682         * common/forward-scope-exit.h
 683         (forward_scope_exit::forward_scope_exit): Pass arguments to
 684         m_bind_function directly, instead of creating a std::bind and
 685         copying that.
 686
 687 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
 688
 689         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 690         for static members.
 691         (pass_in_v_vfp_candidate): Likewise.
 692
 693 2019-01-23  Tom Tromey  <tom@tromey.com>
 694             Pedro Alves  <palves@redhat.com>
 695
 696         * regcache.c (class regcache_invalidator): Remove.
 697         (regcache::raw_write): Use make_scope_exit.
 698
 699 2019-01-23  Tom Tromey  <tom@tromey.com>
 700
 701         * ui-out.h (class ui_out_emit_type): Update comment.
 702
 703 2019-01-23  Tom Tromey  <tom@tromey.com>
 704
 705         * infrun.c (fetch_inferior_event): Update comment.
 706
 707 2019-01-23  Tom Tromey  <tom@tromey.com>
 708             Pedro Alves  <palves@redhat.com>
 709
 710         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
 711         parameter.
 712         (fetch_inferior_event): Use SCOPE_EXIT.
 713
 714
 715 2019-01-23  Tom Tromey  <tom@tromey.com>
 716             Pedro Alves  <palves@redhat.com>
 717
 718         * infrun.c (disable_thread_events): Delete.
 719         (stop_all_threads): Use SCOPE_EXIT.
 720
 721 2019-01-23  Tom Tromey  <tom@tromey.com>
 722             Pedro Alves  <palves@redhat.com>
 723
 724         * symfile.c: Include forward-scope-exit.h.
 725         (clear_symtab_users_cleanup): Replace forward declaration with
 726         a FORWARD_SCOPE_EXIT.
 727         (syms_from_objfile_1): Use the forward_scope_exit and
 728         gdb::optional instead of cleanup_function.
 729         (reread_symbols): Use the forward_scope_exit instead of
 730         cleanup_function.
 731         (clear_symtab_users_cleanup): Remove function.
 732
 733 2019-01-23  Tom Tromey  <tom@tromey.com>
 734             Pedro Alves  <palves@redhat.com>
 735
 736         * linux-nat.c: Include scope-exit.h.
 737         (cleanup_target_stop): Remove.
 738         (linux_nat_target::static_tracepoint_markers_by_strid): Use
 739         SCOPE_EXIT.
 740
 741 2019-01-23  Tom Tromey  <tom@tromey.com>
 742             Pedro Alves  <palves@redhat.com>
 743
 744         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
 745         (call_function_by_hand_dummy): Use SCOPE_EXIT.
 746
 747 2019-01-23  Tom Tromey  <tom@tromey.com>
 748             Andrew Burgess  <andrew.burgess@embecosm.com>
 749             Pedro Alves  <palves@redhat.com>
 750
 751         * infrun.c (fetch_inferior_event): Use scope_exit.
 752         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
 753         * top.c (execute_command): Use scope_exit.
 754         * breakpoint.c (bpstat_do_actions): Use scope_exit.
 755         * utils.c (do_bpstat_clear_actions_cleanup)
 756         (make_bpstat_clear_actions_cleanup): Remove.
 757
 758 2019-01-23  Tom Tromey  <tom@tromey.com>
 759             Pedro Alves  <palves@redhat.com>
 760
 761         * infrun.c: Include "common/scope-exit.h"
 762         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
 763         (wait_for_inferior): Use SCOPE_EXIT.
 764         (fetch_inferior_event): Use scope_exit.
 765
 766 2019-01-23  Tom Tromey  <tom@tromey.com>
 767             Pedro Alves  <palves@redhat.com>
 768
 769         * breakpoint.c (create_breakpoint): Remove cleanup.
 770
 771 2019-01-23  Tom Tromey  <tom@tromey.com>
 772             Andrew Burgess  <andrew.burgess@embecosm.com>
 773             Pedro Alves  <palves@redhat.com>
 774
 775 2019-01-23  Pedro Alves  <palves@redhat.com>
 776
 777         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
 778
 779 2019-01-23  Pedro Alves  <palves@redhat.com>
 780             Andrew Burgess  <andrew.burgess@embecosm.com>
 781
 782         * gdbthread.h: Include "common/forward-scope-exit.h".
 783         (scoped_finish_thread_state): Redefine custom class in terms of
 784         forward_scope_exit.
 785
 786 2019-01-23  Pedro Alves  <palves@redhat.com>
 787             Andrew Burgess  <andrew.burgess@embecosm.com>
 788
 789         * common/forward-scope-exit.h: New file.
 790
 791 2019-01-23  Pedro Alves  <palves@redhat.com>
 792             Andrew Burgess  <andrew.burgess@embecosm.com>
 793             Tom Tromey  <tom@tromey.com>
 794
 795         * common/scope-exit.h: New file.
 796
 797 2019-01-23  Pedro Alves  <palves@redhat.com>
 798
 799         * common/preprocessor.h (ESC): Rename to ...
 800         (ESC_PARENS): ... this.
 801         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 802         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 803
 804 2019-01-23  Tom Tromey  <tom@tromey.com>
 805
 806         * language.h (class scoped_switch_to_sym_language_if_auto):
 807         Initialize m_lang in both cases.
 808
 809 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 810
 811         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 812         with XCNEW.
 813
 814 2019-01-22  Tom Tromey  <tom@tromey.com>
 815
 816         * corelow.c: Do not include sys/file.h.
 817
 818 2019-01-22  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-wingeneral.h: Include gdb_curses.h.
 821
 822 2019-01-22  Tom Tromey  <tom@tromey.com>
 823
 824         * source-cache.h (class source_cache) <get_source_lines,
 825         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 826
 827 2019-01-22  Tom Tromey  <tom@tromey.com>
 828
 829         * remote-fileio.h (struct remote_target): Declare.
 830
 831 2019-01-22  Tom Tromey  <tom@tromey.com>
 832
 833         * python/py-arch.c: Do not include py-ref.h.
 834         * python/py-bpevent.c: Do not include py-ref.h.
 835         * python/py-cmd.c: Do not include py-ref.h.
 836         * python/py-continueevent.c: Do not include py-ref.h.
 837         * python/py-event.h: Do not include py-ref.h.
 838         * python/py-evtregistry.c: Do not include py-ref.h.
 839         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 840         * python/py-frame.c: Do not include py-ref.h.
 841         * python/py-framefilter.c: Do not include py-ref.h.
 842         * python/py-function.c: Do not include py-ref.h.
 843         * python/py-infevents.c: Do not include py-ref.h.
 844         * python/py-linetable.c: Do not include py-ref.h.
 845         * python/py-objfile.c: Do not include py-ref.h.
 846         * python/py-param.c: Do not include py-ref.h.
 847         * python/py-prettyprint.c: Do not include py-ref.h.
 848         * python/py-progspace.c: Do not include py-ref.h.
 849         * python/py-symbol.c: Do not include py-ref.h.
 850         * python/py-symtab.c: Do not include py-ref.h.
 851         * python/py-type.c: Do not include py-ref.h.
 852         * python/py-unwind.c: Do not include py-ref.h.
 853         * python/py-utils.c: Do not include py-ref.h.
 854         * python/py-value.c: Do not include py-ref.h.
 855         * python/py-varobj.c: Do not include py-ref.h.
 856         * python/py-xmethods.c: Do not include py-ref.h.
 857         * python/python.c: Do not include py-ref.h.
 858         * varobj.c: Do not include py-ref.h.
 859
 860 2019-01-22  Tom Tromey  <tom@tromey.com>
 861
 862         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 863         keyword for bcache.
 864
 865 2019-01-22  Tom Tromey  <tom@tromey.com>
 866
 867         * compile/compile-cplus-types.c: Remove a comment by #include.
 868
 869 2019-01-22  Tom Tromey  <tom@tromey.com>
 870
 871         * compile/gcc-c-plugin.h: Include compile-internal.h.
 872
 873 2019-01-22  Tom Tromey  <tom@tromey.com>
 874
 875         * stabsread.c (EXTERN): Do not define.
 876         (symnum, next_symbol_text_func, processing_gcc_compilation)
 877         (within_function, global_sym_chain, global_stabs)
 878         (previous_stab_code, this_object_header_files)
 879         (n_this_object_header_files)
 880         (n_allocated_this_object_header_files): Define.
 881         * stabsread.h (EXTERN): Never define.  Use "extern".
 882
 883 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 884
 885         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 886         history_value.
 887
 888 2019-01-21  Tom Tromey  <tom@tromey.com>
 889
 890         * ui-out.c: Fix includes.
 891         * tui/tui-source.c: Fix includes.
 892         * target.c: Fix includes.
 893         * remote.c: Fix includes.
 894         * regcache.c: Fix includes.
 895         * python/py-block.c: Fix includes.
 896         * printcmd.c: Fix includes.
 897         * or1k-tdep.c: Fix includes.
 898         * mi/mi-main.c: Fix includes.
 899         * m32r-tdep.c: Fix includes.
 900         * csky-tdep.c: Fix includes.
 901         * compile/compile-cplus-types.c: Fix includes.
 902         * cli/cli-interp.c: Fix includes.
 903
 904 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 905
 906         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 907         for padding.
 908
 909 2019-01-16  Tom Tromey  <tom@tromey.com>
 910
 911         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 912         earlier.
 913         (struct objfile) <msymbols_range>: Move from top level.
 914         <msymbols>: New method.
 915         (class objfile_msymbols): Remove.
 916         * symtab.c (default_collect_symbol_completion_matches_break_on):
 917         Update.
 918         * symmisc.c (dump_msymbols): Update.
 919         * stabsread.c (scan_file_globals): Update.
 920         * objc-lang.c (info_selectors_command, info_classes_command)
 921         (find_methods): Update.
 922         * minsyms.c (find_solib_trampoline_target): Update.
 923         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 924         * coffread.c (coff_symfile_read): Update.
 925         * ada-lang.c (ada_lookup_simple_minsym)
 926         (ada_collect_symbol_completion_matches): Update.
 927
 928 2019-01-16  Tom Tromey  <tom@tromey.com>
 929
 930         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 931         type.  Remove no-argument constructor.
 932         <iterator::operator++>: Simplify.
 933         <begin>: Update.
 934         <end>: Use minimal_symbol_count.
 935
 936 2019-01-16  Tom Tromey  <tom@tromey.com>
 937
 938         * objfiles.h (struct objfile) <psymtabs>: New method.
 939         (class objfile_psymtabs): Remove.
 940         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 941         typedef.
 942         <range>: New method.
 943         (require_partial_symbols): Change return type.
 944         * psymtab.c (require_partial_symbols)
 945         (psym_expand_symtabs_matching): Update.
 946         * mdebugread.c (parse_partial_symbols): Update.
 947         * dbxread.c (dbx_end_psymtab): Update.
 948
 949 2019-01-15  Tom Tromey  <tom@tromey.com>
 950
 951         * symtab.c (lookup_objfile_from_block)
 952         (lookup_symbol_in_objfile_symtabs)
 953         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 954         (find_line_symtab, info_sources_command)
 955         (default_collect_symbol_completion_matches_break_on)
 956         (make_source_files_completion_list): Update.
 957         * symmisc.c (print_objfile_statistics, dump_objfile)
 958         (maintenance_print_symbols, maintenance_info_symtabs)
 959         (maintenance_check_symtabs, maintenance_info_line_tables):
 960         Update.
 961         * source.c (select_source_symtab)
 962         (forget_cached_source_info_for_objfile): Update.
 963         * objfiles.h (class objfile_compunits): Remove.
 964         (struct objfile) <compunits_range>: New typedef.
 965         (compunits): New method.
 966         * objfiles.c (objfile_relocate1): Update.
 967         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 968         * maint.c (count_symtabs_and_blocks): Update.
 969         * linespec.c (iterate_over_all_matching_symtabs): Update.
 970         * cp-support.c (add_symbol_overload_list_qualified): Update.
 971         * coffread.c (coff_symtab_read): Update.
 972         * ada-lang.c (add_nonlocal_symbols)
 973         (ada_collect_symbol_completion_matches)
 974         (ada_add_global_exceptions): Update.
 975
 976 2019-01-15  Tom Tromey  <tom@tromey.com>
 977
 978         * progspace.h (program_space) <objfiles_safe_range>: New
 979         typedef.
 980         <objfiles_safe>: New method.
 981         * objfiles.h (class all_objfiles_safe): Remove.
 982         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 983         * jit.c (jit_inferior_exit_hook): Update.
 984
 985 2019-01-17  Tom Tromey  <tom@tromey.com>
 986
 987         * progspace.h (program_space) <objfiles_range>: New typedef.
 988         <objfiles>: New method.
 989         <objfiles_head>: Rename from objfiles.
 990         (object_files): Update.
 991         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 992         * guile/scm-pretty-print.c
 993         (ppscm_find_pretty_printer_from_objfiles): Update.
 994         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 995         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 996         Update.
 997         * python/py-progspace.c (pspy_get_objfiles): Update.
 998         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 999         Update.
1000         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1001         (objfpy_lookup_objfile_by_build_id): Update.
1002         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
1003         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1004         Update.
1005         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1006         (expand_symtab_containing_pc, lookup_objfile_from_block)
1007         (lookup_static_symbol, basic_lookup_transparent_type)
1008         (find_pc_sect_compunit_symtab, find_symbol_at_address)
1009         (find_line_symtab, info_sources_command)
1010         (default_collect_symbol_completion_matches_break_on)
1011         (make_source_files_completion_list, find_main_name): Update.
1012         * symmisc.c (print_symbol_bcache_statistics)
1013         (print_objfile_statistics, maintenance_print_symbols)
1014         (maintenance_print_msymbols, maintenance_print_objfiles)
1015         (maintenance_info_symtabs, maintenance_check_symtabs)
1016         (maintenance_expand_symtabs, maintenance_info_line_tables):
1017         Update.
1018         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
1019         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
1020         (map_overlay_command, unmap_overlay_command)
1021         (simple_overlay_update, expand_symtabs_matching)
1022         (map_symbol_filenames): Update.
1023         * symfile-debug.c (set_debug_symfile): Update.
1024         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
1025         Update.
1026         * source.c (select_source_symtab, forget_cached_source_info):
1027         Update.
1028         * solib.c (solib_read_symbols): Update.
1029         * solib-spu.c (append_ocl_sos): Update.
1030         * psymtab.c (maintenance_print_psymbols)
1031         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
1032         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
1033         * printcmd.c (info_symbol_command): Update.
1034         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
1035         Update.
1036         * objfiles.h (class all_objfiles): Remove.
1037         * objfiles.c (have_partial_symbols, have_full_symbols)
1038         (have_minimal_symbols, qsort_cmp, update_section_map)
1039         (shared_objfile_contains_address_p)
1040         (default_iterate_over_objfiles_in_search_order): Update.
1041         * objc-lang.c (info_selectors_command, info_classes_command)
1042         (find_methods): Update.
1043         * minsyms.c (find_solib_trampoline_target): Update.
1044         * maint.c (maintenance_info_sections)
1045         (maintenance_translate_address, count_symtabs_and_blocks):
1046         Update.
1047         * main.c (captured_main_1): Update.
1048         * linux-thread-db.c (try_thread_db_load_from_pdir)
1049         (has_libpthread): Update.
1050         * linespec.c (iterate_over_all_matching_symtabs)
1051         (search_minsyms_for_name): Update.
1052         * jit.c (jit_find_objf_with_entry_addr): Update.
1053         * hppa-tdep.c (find_unwind_entry)
1054         (hppa_lookup_stub_minimal_symbol): Update.
1055         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
1056         Update.
1057         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1058         (elf_gnu_ifunc_resolve_by_got): Update.
1059         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
1060         * dwarf-index-write.c (save_gdb_index_command): Update.
1061         * cp-support.c (add_symbol_overload_list_qualified): Update.
1062         * breakpoint.c (create_overlay_event_breakpoint)
1063         (create_longjmp_master_breakpoint)
1064         (create_std_terminate_master_breakpoint)
1065         (create_exception_master_breakpoint): Update.
1066         * blockframe.c (find_pc_partial_function): Update.
1067         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
1068         (ada_collect_symbol_completion_matches)
1069         (ada_add_global_exceptions): Update.
1070
1071 2019-01-17  Tom Tromey  <tom@tromey.com>
1072
1073         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
1074         declare VEC.
1075         (solib_target_parse_libraries): Change return type.
1076         (library_list_start_segment, library_list_start_section)
1077         (library_list_end_library, library_list_start_library); Update.
1078         (solib_target_free_library_list): Remove.
1079         (solib_target_parse_libraries): Remove cleanup.  Change return
1080         type.
1081         (solib_target_current_sos): Update.
1082
1083 2019-01-17  Tom Tromey  <tromey@bapiya>
1084
1085         * valprint.c: Replace "the the" with "the".
1086         * symtab.c: Replace "the the" with "the".
1087         * solib.c: Replace "the the" with "the".
1088         * solib-dsbt.c: Replace "the the" with "the".
1089         * linespec.c: Replace "the the" with "the".
1090         * dwarf2loc.h: Replace "the the" with "the".
1091         * amd64-windows-tdep.c: Replace "the the" with "the".
1092         * aarch64-tdep.c: Replace "the the" with "the".
1093
1094 2019-01-16  Keith Seitz  <keiths@redhat.com>
1095
1096         PR gdb/23773
1097         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
1098         <builder>: Rename to ..
1099         <m_builder>: ... this and make private.
1100         (dwarf2_cu::get_builder): New method.  Change all users of
1101         `builder' to use this method.
1102         (dwarf2_start_symtab): Move to ...
1103         (dwarf2_cu::start_symtab): ... here.  Update all callers
1104         (setup_type_unit_groups): Move to ...
1105         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
1106         callers.
1107         (dwarf2_cu::reset_builder): New method.
1108         (process_full_compunit, process_full_type_unit): Use
1109         dwarf2_cu::reset_builder.
1110         (follow_die_offset): Record the ancestor CU if it is different
1111         from the followed DIE's CU.
1112         (follow_die_sig_1): Likewise.
1113
1114 2019-01-15  Tom Tromey  <tom@tromey.com>
1115
1116         * remote.c (class remote_state) <buf>: Now a char_vector.
1117         <buf_size>: Remove.
1118         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
1119         parameter.
1120         (remote_target::getpkt_or_notif_sane_1)
1121         (remote_target::getpkt_sane)
1122         (remote_target::getpkt_or_notif_sane): Likewise.
1123         (class remote_target) <putpkt>: New overload.
1124         (remote_target::read_frame): Change type of "buf_p".  Remove
1125         sizeof_p parameter.
1126         (packet_ok): New overload.
1127         (packet_check_result): New overload.
1128         Update all uses.
1129
1130 2019-01-14  Tom Tromey  <tom@tromey.com>
1131
1132         * remote-notif.c (handle_notification, remote_notif_ack)
1133         (remote_notif_parse): Make "buf" const.
1134         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
1135         const.
1136         (remote_notif_parse, remote_notif_ack, handle_notification):
1137         Likewise.
1138         * remote.c (remote_notif_stop_parse): Make "buf" const.
1139         (remote_target::remote_parse_stop_reply): Make "buf" const.
1140         (remote_notif_stop_ack): Make "buf" const.
1141
1142 2019-01-14  Tom Tromey  <tom@tromey.com>
1143
1144         * remote.c (remote_console_output): Make parameter const.
1145
1146 2019-01-14  Tom Tromey  <tom@tromey.com>
1147
1148         * target-debug.h (target_debug_print_signals): Constify.
1149         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
1150         * procfs.c (procfs_target::pass_signals): Update.
1151         * linux-nat.c (linux_nat_target::pass_signals): Update.
1152         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
1153         * target-delegates.c: Rebuild.
1154         * remote.c (remote_target::program_signals): Update.
1155         (remote_target::pass_signals): Update.
1156         * target.c (target_pass_signals): Constify argument.
1157         (target_program_signals): Likewise.
1158         * target.h (struct target_ops) <pass_signals, program_signals>:
1159         Constify argument.
1160         (target_pass_signals, target_program_signals): Constify argument.
1161
1162 2019-01-14  Tom Tromey  <tom@tromey.com>
1163
1164         PR tui/28819:
1165         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
1166
1167 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1168
1169         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
1170         field.
1171         * rs6000-tdep.c: Include reggroups.h.
1172         (IS_V_ALIAS_PSEUDOREG): Define.
1173         (rs6000_register_name): Return names for the "vX" aliases.
1174         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
1175         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
1176         aliases.  Call default_register_reggroup_p for all other
1177         pseudo-registers.
1178         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
1179         New functions.
1180         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
1181         Handle "vX" aliases.
1182         (v_alias_pseudo_register_collect): New function.
1183         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
1184         (rs6000_gdbarch_init): Initialize "vX" aliases as
1185         pseudo-registers.  Restore registration of
1186         rs6000_pseudo_register_reggroup_p with
1187         set_tdesc_pseudo_register_reggroup_p.
1188
1189 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
1190
1191         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
1192         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
1193         set_gdbarch_num_pseudo_regs.
1194
1195 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1196
1197         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
1198         Remove arg prefixname, add do_set and do_show.
1199         Add member functions set_list and show_list.
1200         * cli/cli-style.c (class cli_style_option): Update accordingly.
1201         (style_set_list): Move to file scope.
1202         (style_show_list): Likewise.
1203         (set_style): Call help_list.
1204         (show_style): Call cmd_show_list.
1205         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
1206         Update to use the new macro.
1207
1208 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
1209
1210         * ada-lang.c (_initialize_ada_language): Expand the help text
1211         for the "catch exception" command.
1212
1213 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1214
1215         * symtab.c (matching_obj_sections): Initialize obj,
1216         declare it closer to its usage.
1217
1218 2019-01-10  Tom Tromey  <tom@tromey.com>
1219
1220         * thread-iter.h (inf_threads_iterator): Use next_iterator.
1221         (basic_inf_threads_range): Remove.
1222         (inf_threads_range, inf_non_exited_threads_range)
1223         (safe_inf_threads_range): Use next_adapter.
1224
1225 2019-01-10  Keith Seitz  <keiths@redhat.com>
1226
1227         PR gdb/23712
1228         PR symtab/23010
1229         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
1230         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
1231
1232 2019-01-10  Keith Seitz  <keiths@redhat.com>
1233
1234         PR gdb/23712
1235         PR symtab/23010
1236         * dictionary.c (pending_to_vector): Remove.
1237         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1238         Remove _1 suffix, replacing functions of the same name.  Update
1239         all callers.
1240         (dict_create_hashed, dict_create_hashed_expandable)
1241         (dict_create_linear, dict_create_linear_expandable, dict_free)
1242         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
1243         Make functions static.
1244
1245 2019-01-10  Keith Seitz  <keiths@redhat.com>
1246
1247         PR gdb/23712
1248         PR symtab/23010
1249         * dictionary.h (struct dictionary): Replace declaration with
1250         multidictionary.
1251         (dict_create_hashed, dict_create_hashed_expandable)
1252         (dict_create_linear, dict_create_linear_expandable)
1253         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
1254         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
1255         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
1256         taking multidictionary argument.
1257         [ALL_DICT_SYMBOLS]: Update for multidictionary.
1258         * block.h (struct block) <dict>: Change to multidictionary
1259         and rename `multidict'.
1260         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
1261         symmisc.c: Update all dictionary references to multidictionary.
1262
1263 2019-01-10  Keith Seitz  <keiths@redhat.com>
1264
1265         PR gdb/23712
1266         PR symtab/23010
1267         * dictionary.c: Include unordered_map.
1268         (pending_to_vector): New function.
1269         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
1270         Rewrite the non-"_1" functions to take vector instead
1271         of linked list.
1272         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
1273         "new" _1 versions of the same name.
1274         (multidictionary): Define.
1275         (std::hash<enum language): New definition.
1276         (collate_pending_symbols_by_language, mdict_create_hashed)
1277         (mdict_create_hashed_expandable, mdict_create_linear)
1278         (mdict_create_linear_expandable, mdict_free)
1279         (find_language_dictionary, create_new_language_dictionary)
1280         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
1281         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
1282         (mdict_size, mdict_empty): New functions.
1283         * dictionary.h (mdict_iterator): Define.
1284
1285 2019-01-10  Pedro Alves  <palves@redhat.com>
1286
1287         * breakpoint.c (read_uploaded_action)
1288         (create_tracepoint_from_upload): Adjust to use
1289         gdb::unique_xmalloc_ptr.
1290         * ctf.c (ctf_write_uploaded_tp):
1291         (SET_ARRAY_FIELD): Use emplace_back.
1292         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
1293         * tracefile-tfile.c (tfile_write_uploaded_tp):
1294         * tracepoint.c (parse_tracepoint_definition): Adjust to use
1295         gdb::unique_xmalloc_ptr.
1296         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
1297         at_string, cond_string, cmd_strings>: Replace char pointers
1298         with gdb::unique_xmalloc_ptr.
1299
1300 2019-01-10  Pedro Alves  <palves@redhat.com>
1301
1302         * solib-target.c (library_list_start_library): Don't xstrdup name.
1303
1304 2019-01-10  Pedro Alves  <palves@redhat.com>
1305
1306         * mdebugread.c (parse_partial_symbols): Use
1307         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
1308
1309 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1310
1311         * linux-fork.c (scoped_switch_fork_info)
1312         <~scoped_switch_fork_info>: Fix incorrect variable name.
1313
1314 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1315
1316         * linux-fork.c (scoped_switch_fork_info)
1317         <scoped_switch_fork_info>: Make explicit.
1318         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
1319
1320 2019-01-10  Tom Tromey  <tom@tromey.com>
1321
1322         * objfiles.h (objfile::reset_psymtabs): Update.
1323         * objfiles.c (objfile::objfile): Update.
1324         * psymtab.h (psymtab_storage::obstack): Update.
1325         (psymtab_storage::m_obstack): Use gdb::optional.
1326         (class psymtab_storage): Update comment.  Remove objfile
1327         parameter.
1328         * psymtab.c (psymtab_storage::psymtab_storage): Update.
1329
1330 2019-01-10  Tom Tromey  <tom@tromey.com>
1331
1332         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
1333         <free_psymtabs>: Now private.
1334         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
1335         (allocate_psymtab): Use new method.
1336
1337 2019-01-10  Tom Tromey  <tom@tromey.com>
1338
1339         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
1340         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
1341         * mdebugread.c (parse_partial_symbols): Use
1342         allocate_dependencies.
1343         * dwarf2read.c (dwarf2_create_include_psymtab): Use
1344         allocate_dependencies.
1345         (process_psymtab_comp_unit_reader)
1346         (build_type_psymtab_dependencies): Likewise.
1347         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
1348
1349 2019-01-10  Tom Tromey  <tom@tromey.com>
1350
1351         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
1352         PSYMBOL_SET_LANGUAGE.
1353         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
1354
1355 2019-01-10  Tom Tromey  <tom@tromey.com>
1356
1357         * psymtab.h (psymtab_storage::obstack): New method.
1358         <m_obstack>: Rename from obstack; now private.
1359         * psymtab.c (psymtab_storage): Update.
1360         * dwarf2read.c (create_addrmap_from_index)
1361         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
1362         Update.
1363
1364 2019-01-10  Tom Tromey  <tom@tromey.com>
1365
1366         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
1367         * objfiles.h (objfile::reset_psymtabs): New method.
1368
1369 2019-01-10  Tom Tromey  <tom@tromey.com>
1370
1371         * symmisc.c (print_symbol_bcache_statistics): Update.
1372         (print_objfile_statistics): Update.
1373         * symfile.c (reread_symbols): Update.
1374         * psymtab.h (class psymtab_storage): New.
1375         * psymtab.c (psymtab_storage): New constructor.
1376         (~psymtab_storage): New destructor.
1377         (require_partial_symbols): Update.
1378         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
1379         (find_pc_sect_psymtab, find_pc_sect_psymbol)
1380         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
1381         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
1382         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
1383         (start_psymtab_common, end_psymtab_common)
1384         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
1385         (allocate_psymtab): Update.
1386         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
1387         Update.
1388         (dump_psymtab_addrmap, maintenance_print_psymbols)
1389         (maintenance_check_psymtabs): Update.
1390         (class objfile_psymtabs): Move to objfiles.h.
1391         * psympriv.h (discard_psymtab): Now inline.
1392         (psymtab_discarder::psymtab_discarder): Update.
1393         (psymtab_discarder::~psymtab_discarder): Update.
1394         (ALL_OBJFILE_PSYMTABS): Rewrite.
1395         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
1396         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
1397         Remove fields.
1398         <partial_symtabs>: New field.
1399         (class objfile_psymtabs): Move from psymtab.h.  Update.
1400         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
1401         psymbol_cache.
1402         (objfile::~objfile): Don't destroy psymbol_cache.
1403         * mdebugread.c (parse_partial_symbols): Update.
1404         * dwarf2read.c (create_addrmap_from_index)
1405         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
1406         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
1407         (add_partial_subprogram, dwarf2_ranges_read): Update.
1408         * dwarf-index-write.c (write_address_map)
1409         (write_one_signatured_type, recursively_write_psymbols)
1410         (class debug_names, class debug_names, write_psymtabs_to_index):
1411         Update.
1412
1413 2019-01-10  Tom Tromey  <tom@tromey.com>
1414
1415         * symtab.h (SYMBOL_SET_NAMES): Update.
1416         (symbol_set_names): Update.
1417         (MSYMBOL_SET_NAMES): Update.
1418         * symtab.c (symbol_set_names): Change argument to be an
1419         objfile_per_bfd_storage.
1420         * psymtab.c (add_psymbol_to_bcache): Update.
1421         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
1422
1423 2019-01-10  Tom Tromey  <tom@tromey.com>
1424
1425         * symtab.c (create_demangled_names_hash): Change argument to be an
1426         objfile_per_bfd_storage.
1427         (symbol_set_names): Update.
1428
1429 2019-01-10  Tom Tromey  <tom@tromey.com>
1430
1431         * xcoffread.c (xcoff_initial_scan): Unconditionally call
1432         init_psymbol_list.
1433         * psymtab.c (init_psymbol_list): Do nothing if already called.
1434         * psympriv.h (init_psymbol_list): Add comment.
1435         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
1436         init_psymbol_list.
1437         * dbxread.c (dbx_symfile_read): Unconditionally call
1438         init_psymbol_list.
1439
1440 2019-01-10  Tom Tromey  <tom@tromey.com>
1441
1442         * xcoffread.c (scan_xcoff_symtab): Update.
1443         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
1444         "where".
1445         * mdebugread.c (parse_partial_symbols)
1446         (handle_psymbol_enumerators): Update.
1447         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
1448         * dbxread.c (read_dbx_symtab): Update.
1449         * psympriv.h (psymbol_placement): New enum.
1450         (add_psymbol_to_list): Update.
1451
1452 2019-01-10  Tom Tromey  <tom@tromey.com>
1453
1454         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
1455         static_psymbols parameters.
1456         (scan_xcoff_symtab): Update.
1457         * psymtab.c (start_psymtab_common): Remove global_psymbols and
1458         static_psymbols parameters.
1459         * psympriv.h (start_psymtab_common): Update.
1460         * mdebugread.c (parse_partial_symbols): Update.
1461         * dwarf2read.c (create_partial_symtab): Update.
1462         * dbxread.c (read_dbx_symtab): Update.
1463         (start_psymtab): Remove global_psymbols and static_psymbols
1464         parameters.
1465
1466 2019-01-10  Tom Tromey  <tom@tromey.com>
1467
1468         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
1469         * psymtab.c (allocate_psymtab): Add comment.
1470         * psympriv.h (allocate_psymtab): Add comment.
1471         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
1472         initializations.
1473         * dbxread.c (dbx_end_psymtab): Remove some initializations.
1474
1475 2019-01-10  Tom Tromey  <tom@tromey.com>
1476
1477         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1478         Don't declare.
1479         * mipsread.c: Include mdebugread.h.
1480         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
1481         Declare.
1482         * elfread.c: Include mdebugread.h.
1483
1484 2019-01-09  Tom Tromey  <tom@tromey.com>
1485
1486         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
1487         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
1488         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
1489         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1490         (psym_lookup_symbol, psym_find_last_source_symtab)
1491         (psym_forget_cached_source_info, psym_print_stats)
1492         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1493         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1494         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1495         (psym_find_compunit_symtab_by_address)
1496         (maintenance_print_psymbols, maintenance_info_psymtabs)
1497         (maintenance_check_psymtabs): Use ranged for.
1498         * psymtab.h (class objfile_psymtabs): New.
1499         (require_partial_symbols): Return objfile_psymtabs.
1500         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
1501
1502 2019-01-09  Tom Tromey  <tom@tromey.com>
1503
1504         * symfile.c (overlay_invalidate_all, find_pc_overlay)
1505         (find_pc_mapped_section, list_overlays_command)
1506         (map_overlay_command, unmap_overlay_command)
1507         (simple_overlay_update): Use all_objfiles.
1508         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
1509         * printcmd.c (info_symbol_command): Use all_objfiles.
1510         * objfiles.h (ALL_OBJSECTIONS): Remove.
1511         * maint.c (maintenance_translate_address): Use all_objfiles.
1512         * gcore.c (gcore_create_callback): Use all_objfiles.
1513         (objfile_find_memory_regions): Likewise.
1514
1515 2019-01-09  Tom Tromey  <tom@tromey.com>
1516
1517         * symtab.c (find_line_symtab, info_sources_command)
1518         (make_source_files_completion_list): Use objfile_compunits.
1519         * source.c (select_source_symtab): Use objfile_compunits.
1520         * objfiles.h (struct objfile): Update comment.
1521         (ALL_OBJFILES): Remove.
1522         (ALL_FILETABS): Remove.
1523         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
1524         objfile_compunits.
1525
1526 2019-01-09  Tom Tromey  <tom@tromey.com>
1527
1528         * symmisc.c (print_objfile_statistics, dump_objfile)
1529         (maintenance_print_symbols): Use compunit_filetabs.
1530         * source.c (forget_cached_source_info_for_objfile): Use
1531         compunit_filetabs.
1532         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
1533         (ALL_FILETABS): Use compunit_filetabs.
1534         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
1535         * coffread.c (coff_symtab_read): Use compunit_filetabs.
1536
1537 2019-01-09  Tom Tromey  <tom@tromey.com>
1538
1539         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
1540         (compunit_filetabs): New.
1541         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
1542         compunit_filetabs.
1543         (info_sources_command, make_source_files_completion_list): Remove
1544         declaration.
1545         * symmisc.c (print_objfile_statistics, dump_objfile)
1546         (maintenance_print_symbols): Remove declaration.
1547         (maintenance_info_symtabs): Use compunit_filetabs.
1548         (maintenance_info_line_tables): Likewise.
1549         * source.c (select_source_symtab): Change local variable name.
1550         (forget_cached_source_info_for_objfile): Remove declaration.
1551         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
1552         * objfiles.c (objfile_relocate1): Remove declaration.
1553         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1554         declaration.
1555         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
1556         * coffread.c (coff_symtab_read): Remove declaration.
1557         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1558         compunit_filetabs.
1559
1560 2019-01-09  Tom Tromey  <tom@tromey.com>
1561
1562         * symtab.c (lookup_objfile_from_block)
1563         (find_pc_sect_compunit_symtab, search_symbols)
1564         (default_collect_symbol_completion_matches_break_on): Use
1565         objfile_compunits.
1566         * objfiles.h (ALL_COMPUNITS): Remove.
1567         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
1568         * cp-support.c (add_symbol_overload_list_qualified): Use
1569         objfile_compunits.
1570         * ada-lang.c (ada_collect_symbol_completion_matches)
1571         (ada_add_global_exceptions): Use objfile_compunits.
1572
1573 2019-01-09  Tom Tromey  <tom@tromey.com>
1574
1575         * source.c (select_source_symtab)
1576         (forget_cached_source_info_for_objfile): Remove declaration.
1577         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
1578         declaration.
1579         * maint.c (count_symtabs_and_blocks): Remove declaration.
1580         * cp-support.c (add_symbol_overload_list_qualified): Remove
1581         declaration.
1582         * coffread.c (coff_symtab_read): Remove declaration.
1583         * symtab.c (lookup_symbol_in_objfile_symtabs)
1584         (basic_lookup_transparent_type_1): Use objfile_compunits.
1585         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
1586         (info_sources_command, search_symbols)
1587         (default_collect_symbol_completion_matches_break_on)
1588         (make_source_files_completion_list): Remove declaration.
1589         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
1590         (ada_collect_symbol_completion_matches)
1591         (ada_add_global_exceptions): Remove declaration.
1592         * linespec.c (iterate_over_all_matching_symtabs): Use
1593         objfile_compunits.
1594         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
1595         (class objfile_compunits): New.
1596         (ALL_COMPUNITS): Use objfile_compunits.
1597         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
1598         (maintenance_check_symtabs, maintenance_info_line_tables): Use
1599         objfile_compunits.
1600         * objfiles.c (objfile_relocate1): Use objfile_compunits.
1601
1602 2019-01-09  Tom Tromey  <tom@tromey.com>
1603
1604         * symtab.c (search_symbols)
1605         (default_collect_symbol_completion_matches_break_on): Use
1606         objfile_msymbols.
1607         * ada-lang.c (ada_lookup_simple_minsym)
1608         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
1609         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
1610         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
1611         objfile_msymbols.
1612         * coffread.c (coff_symfile_read): Use objfile_msymbols.
1613         * symmisc.c (dump_msymbols): Use objfile_msymbols.
1614         * objc-lang.c (find_methods): Use objfile_msymbols.
1615         (info_selectors_command, info_classes_command): Likewise.
1616         * stabsread.c (scan_file_globals): Use objfile_msymbols.
1617         * objfiles.h (class objfile_msymbols): New.
1618         (ALL_OBJFILE_MSYMBOLS): Remove.
1619         (ALL_MSYMBOLS): Remove.
1620
1621 2019-01-09  Tom Tromey  <tom@tromey.com>
1622
1623         * common/next-iterator.h (next_adapter): Add Iterator template
1624         parameter.
1625         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
1626         (class all_objfiles_safe): New.
1627         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
1628         * objfiles.c (put_objfile_before): Update comment.
1629         (add_separate_debug_objfile): Likewise.
1630         (free_all_objfiles): Use all_objfiles_safe.
1631         (objfile_purge_solibs): Likewise.
1632
1633 2019-01-09  Tom Tromey  <tom@tromey.com>
1634
1635         * symtab.c (iterate_over_symtabs, matching_obj_sections)
1636         (expand_symtab_containing_pc, lookup_static_symbol)
1637         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
1638         (find_symbol_at_address, find_line_symtab, find_main_name): Use
1639         all_objfiles.
1640         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
1641         * breakpoint.c (create_overlay_event_breakpoint)
1642         (create_longjmp_master_breakpoint)
1643         (create_std_terminate_master_breakpoint)
1644         (create_exception_master_breakpoint): Use all_objfiles.
1645         * linux-thread-db.c (try_thread_db_load_from_pdir)
1646         (has_libpthread): Use all_objfiles.
1647         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
1648         * linespec.c (iterate_over_all_matching_symtabs)
1649         (search_minsyms_for_name): Use all_objfiles.
1650         * maint.c (maintenance_info_sections): Use all_objfiles.
1651         * main.c (captured_main_1): Use all_objfiles.
1652         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
1653         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
1654         * guile/scm-pretty-print.c
1655         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
1656         * solib-spu.c (append_ocl_sos): Use all_objfiles.
1657         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
1658         (maintenance_print_msymbols): Use all_objfiles.
1659         * source.c (select_source_symtab): Use all_objfiles.
1660         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
1661         * symfile.c (remove_symbol_file_command)
1662         (expand_symtabs_matching, map_symbol_filenames): Use
1663         all_objfiles.
1664         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
1665         all_objfiles.
1666         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
1667         * objc-lang.c (find_methods): Use all_objfiles.
1668         * objfiles.c (have_partial_symbols, have_full_symbols)
1669         (have_minimal_symbols, qsort_cmp)
1670         (default_iterate_over_objfiles_in_search_order): Use
1671         all_objfiles.
1672         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
1673         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
1674         (maintenance_check_psymtabs): Use all_objfiles.
1675         (ALL_PSYMTABS): Remove.
1676         * compile/compile-object-run.c (do_module_cleanup): Use
1677         all_objfiles.
1678         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1679         * cp-support.c (add_symbol_overload_list_qualified): Use
1680         all_objfiles.
1681         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1682         Use all_objfiles.
1683         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1684         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1685         all_objfiles.
1686         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1687         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1688         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1689         Uses all_objfiles.
1690         * solib.c (solib_read_symbols): Use all_objfiles
1691
1692 2019-01-09  Tom Tromey  <tom@tromey.com>
1693
1694         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1695         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1696         all_objfiles.
1697         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1698         * symmisc.c (print_symbol_bcache_statistics)
1699         (print_objfile_statistics, maintenance_print_objfiles)
1700         (maintenance_info_symtabs, maintenance_check_symtabs)
1701         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1702         all_objfiles.
1703         * source.c (forget_cached_source_info): Use all_objfiles.
1704         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1705         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1706         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1707         * objfiles.c (update_section_map): Use all_objfiles.
1708         (shared_objfile_contains_address_p): Likewise.
1709         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1710         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1711
1712 2019-01-09  Tom Tromey  <tom@tromey.com>
1713
1714         * common/next-iterator.h: New file.
1715         * objfiles.h (class all_objfiles): New.
1716         (struct objfile_iterator): New.
1717
1718 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1719
1720         * NEWS: Move the description of the changed "frame", "select-frame",
1721          and "info frame" commands to the Changed commands section.
1722
1723 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1724
1725         * gdbtypes.c (check_stub_method_group): Remove handling of old
1726         mangling schemes.
1727         * linespec.c (find_methods): Likewise.
1728         * stabsread.c (read_member_functions): Likewise.
1729         * valops.c (search_struct_method): Likewise.
1730         (value_struct_elt_for_reference): Likewise.
1731         * NEWS: Mention this change.
1732
1733 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1734
1735         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1736         print_source_lines.
1737         * source.c (print_source_lines_base): Update line number check.
1738         (print_source_lines): New function.
1739         (source_lines_range::source_lines_range): New function.
1740         * source.h (class source_lines_range): New class.
1741         (print_source_lines): New declaration.
1742
1743 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1744
1745         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1746
1747 2019-01-08  Tom Tromey  <tom@tromey.com>
1748             Simon Marchi  <simon.marchi@ericsson.com>
1749
1750         PR gdb/24060
1751         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1752         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1753         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1754         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1755         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1756         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1757
1758 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1759
1760         * source.c (select_source_symtab): Move header comment to
1761         declaration in source.h.
1762         (forget_cached_source_info_for_objfile): Likewise.
1763         (forget_cached_source_info): Likewise.
1764         (identify_source_line): Likewise.
1765         * source.h (identify_source_line): Move declaration from symtab.h
1766         and add comment from source.c
1767         (print_source_lines): Likewise.
1768         (forget_cached_source_info_for_objfile): Likewise.
1769         (forget_cached_source_info): Likewise.
1770         (select_source_symtab): Likewise.
1771         (enum print_source_lines_flag): Move definition from symtab.h.
1772         * symtab.h (identify_source_line): Move declaration to source.h.
1773         (print_source_lines): Likewise.
1774         (forget_cached_source_info_for_objfile): Likewise.
1775         (forget_cached_source_info): Likewise.
1776         (select_source_symtab): Likewise.
1777         (enum print_source_lines_flag): Move definition to source.h.
1778         * tui/tui-hooks.c: Add 'source.h' include.
1779
1780 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1781
1782         * source.c (print_source_lines_base): Handle requests to print
1783         reverse line number sequences, and guard against empty lines
1784         string.
1785
1786 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1787
1788         * source.c (print_source_lines_base): Fix skip of '\r' if next
1789         character is '\n'.
1790
1791 2019-01-06  Tom Tromey  <tom@tromey.com>
1792
1793         * c-exp.y (struct c_parse_state) <macro_original_text,
1794         expansion_obstack>: New member.
1795         (macro_original_text, expansion_obstack): Remove globals.
1796         (scan_macro_expansion, scanning_macro_expansion)
1797         (finished_macro_expansion): Update.
1798         (scan_macro_cleanup): Remove.
1799         (yylex, c_parse): Update.
1800
1801 2019-01-06  Tom Tromey  <tom@tromey.com>
1802
1803         * c-exp.y (struct c_parse_state) <strings>: New member.
1804         (operator_stoken): Update.
1805
1806 2019-01-06  Tom Tromey  <tom@tromey.com>
1807
1808         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1809         (union type_stack_elt) <typelist_val>: Now a pointer to
1810         std::vector.
1811         (type_stack_cleanup): Don't declare.
1812         (push_typelist): Update.
1813         * parse.c (pop_typelist): Return a std::vector.
1814         (push_typelist): Take a std::vector.
1815         (follow_types): Update.  Do not free args.
1816         (type_stack_cleanup): Remove.
1817         * c-exp.y (struct c_parse_state): New.
1818         (cpstate): New global.
1819         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1820         (nonempty_typelist): Update.
1821         (func_mod): Create a new vector.
1822         (c_parse): Create a c_parse_state.
1823         (check_parameter_typelist): Do not delete params.
1824         (function_method): Update.  Do not delete type_list.
1825
1826 2019-01-06  Tom Tromey  <tom@tromey.com>
1827
1828         PR gdb/28155:
1829         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1830         check_typedef.
1831         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1832         (print_return_value): Likewise.
1833
1834 2019-01-05  Tom Tromey  <tom@tromey.com>
1835
1836         * contrib/cleanup_check.py: Remove.
1837         * contrib/gcc-with-excheck: Remove.
1838         * contrib/exsummary.py: Remove.
1839         * contrib/excheck.py: Remove.
1840
1841 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1842
1843         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1844         NULL. Initialize tpprev to NULL instead of assigning it
1845         to NULL on the next statement.
1846         * windows-nat.c (windows_delete_thread): Remove check for
1847         main_thread_id before printing thread exit notifications.
1848         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1849         Remove thread ID check against main_thread_id.
1850         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1851         windows_delete_thread.
1852         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1853
1854 2019-01-04  Tom Tromey  <tom@tromey.com>
1855
1856         * compile/compile.c (_initialize_compile): Use upper case for
1857         metasyntactic variables.
1858         * symmisc.c (_initialize_symmisc): Use upper case for
1859         metasyntactic variables.
1860         * psymtab.c (_initialize_psymtab): Use upper case for
1861         metasyntactic variables.
1862         * demangle.c (demangle_command): Use upper case for metasyntactic
1863         variables.
1864         (_initialize_demangler): Likewise.
1865         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1866         variables.
1867
1868 2019-01-03  Tom Tromey  <tom@tromey.com>
1869
1870         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1871
1872 2019-01-03  Tom Tromey  <tom@tromey.com>
1873
1874         * python/py-symtab.c (salpy_str): Update.
1875         (struct salpy_sal_object) <symtab>: Now a PyObject.
1876         (salpy_dealloc): Update.
1877         (del_objfile_sal): Use gdbpy_ref.
1878
1879 2019-01-03  Tom Tromey  <tom@tromey.com>
1880
1881         * python/py-type.c (convert_field): Use new_reference.  Return
1882         gdbpy_ref.
1883         (make_fielditem): Return gdbpy_ref.
1884         (typy_fields): Update.
1885         (typy_getitem): Update.
1886         (field_name): Return gdbpy_ref.  Use new_reference.
1887         (typy_iterator_iternext): Update.
1888
1889 2019-01-03  Tom Tromey  <tom@tromey.com>
1890
1891         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1892
1893 2019-01-03  Tom Tromey  <tom@tromey.com>
1894
1895         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1896         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1897         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1898         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1899         (pspy_set_type_printers): Likewise.
1900         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1901         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1902         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1903         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1904         (objfpy_set_type_printers): Likewise.
1905
1906 2019-01-03  Tom Tromey  <tom@tromey.com>
1907
1908         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1909         (gdbpy_print_stack): Use gdbpy_err_fetch.
1910         * python/python-internal.h (class gdbpy_err_fetch): New class.
1911         (class gdbpy_enter) <m_error_type, m_error_value,
1912         m_error_traceback>: Remove.
1913         <m_error>: New member.
1914         (gdbpy_exception_to_string): Don't declare.
1915         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1916         * python/py-value.c (convert_value_from_python): Use
1917         gdbpy_err_fetch.
1918         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1919         gdbpy_exception_to_string.
1920         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1921         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1922         gdbpy_err_fetch.
1923
1924 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1925
1926         * linux-nat.c (delete_lwp_cleanup): Delete.
1927         (struct lwp_deleter): New struct.
1928         (lwp_info_up): New typedef.
1929         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1930         lwp_info_up.
1931
1932 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1933
1934         * linux-fork.c (class scoped_switch_fork_info): New class.
1935         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1936
1937 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1938
1939         * valops.c (find_overload_match): Remove use of null_cleanup, and
1940         calls to do_cleanups.
1941
1942 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1943
1944         * compile/compile-cplus-types.c
1945         (compile_cplus_instance::decl_name): Handle changes to
1946         cp_func_name.
1947         * cp-support.c (cp_func_name): Update header comment, update
1948         return type.
1949         * cp-support.h (cp_func_name): Update return type in declaration.
1950         * valops.c (find_overload_match): Move temp_func local to top
1951         level of function and change its type.  Use temp_func to hold and
1952         delete temporary string obtained from cp_func_name.
1953
1954 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1955
1956         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1957         gdb::char_vector, remove cleanup, and update uses of `msg`.
1958
1959 2019-01-03  Jim Wilson  <jimw@sifive.com>
1960
1961         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1962
1963 2019-01-02  Tom Tromey  <tom@tromey.com>
1964
1965         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1966         (tdesc_parse_xml): Remove cleanups.
1967         * target-descriptions.h (make_cleanup_free_target_description):
1968         Don't declare.
1969         (target_desc_deleter): New struct.
1970         (target_desc_up): New typedef.
1971         * target-descriptions.c (target_desc_deleter::operator()): Rename
1972         from free_target_description.
1973         (make_cleanup_free_target_description): Remove.
1974
1975 2019-01-02  Tom Tromey  <tom@tromey.com>
1976
1977         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1978         constructor, destructor.
1979         (linespec_parser): Remove typedef.
1980         (~linespec_parser): Rename from linespec_parser_delete.
1981         (linespec_lex_to_end, linespec_complete_label)
1982         (linespec_complete): Update.
1983         (decode_line_full): Remove cleanups.
1984         (decode_line_1): Update.
1985
1986 2019-01-02  Tom Tromey  <tom@tromey.com>
1987
1988         * python/python-internal.h (inferior_to_inferior_object): Change
1989         return type.
1990         * python/py-exitedevent.c (create_exited_event_object): Update.
1991         * python/py-inferior.c (inferior_to_inferior_object): Return
1992         gdbpy_ref.
1993         (python_new_inferior, python_inferior_deleted)
1994         (thread_to_thread_object, delete_thread_object)
1995         (build_inferior_list, gdbpy_selected_inferior): Update.
1996         * python/py-infthread.c (create_thread_object): Update.  Also fail
1997         if inferior_to_inferior_object fails.
1998
1999 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
2000
2001         * inferior.h (class inferior) <displaced_step_state>: New field.
2002         * infrun.h (struct displaced_step_state): Move here from
2003         infrun.c.  Initialize fields, add constructor.
2004         <inf>: Remove field.
2005         <reset>: New method.
2006         * infrun.c (struct displaced_step_inferior_state): Move to
2007         infrun.h.
2008         (displaced_step_inferior_states): Remove.
2009         (get_displaced_stepping_state): Adust.
2010         (displaced_step_in_progress_any_inferior): Adjust.
2011         (displaced_step_in_progress_thread): Adjust.
2012         (displaced_step_in_progress): Adjust.
2013         (add_displaced_stepping_state): Remove.
2014         (get_displaced_step_closure_by_addr): Adjust.
2015         (remove_displaced_stepping_state): Remove.
2016         (infrun_inferior_exit): Call displaced_step_state.reset.
2017         (use_displaced_stepping): Don't check for NULL.
2018         (displaced_step_prepare_throw): Call
2019         get_displaced_stepping_state.
2020         (displaced_step_fixup): Don't check for NULL.
2021         (prepare_for_detach): Don't check for NULL.
2022
2023 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2024
2025         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
2026          in case of call that did not complete.
2027
2028 2019-01-02  Andrey Utkin  <autkin@undo.io>
2029
2030         * symfile.c (find_separate_debug_file): Fix search of debug files for
2031         remote debuggee.
2032
2033 2019-01-02  Tom Tromey  <tom@tromey.com>
2034
2035         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
2036         indentation.
2037         * python/py-frame.c (frapy_older): Remove cast.
2038         (frapy_newer): Likewise.
2039         * python/py-breakpoint.c (local_setattro): Remove cast.
2040         * python/py-arch.c (archpy_name): Remove local variable.
2041         * python/py-type.c (gdbpy_lookup_type): Remove cast.
2042
2043 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
2044
2045         * unittests/basic_string_view/element_access/char/empty.cc:
2046         Fix year range in copyright header.
2047
2048 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2049
2050         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
2051         Delete.
2052         <operator==>: Update with for removed field.
2053         <hash>: Likewise.
2054         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
2055         <isa_features>: ...this.
2056         <abi_features>: New field.
2057         (riscv_isa_flen): Update comment.
2058         (riscv_abi_xlen): New declaration.
2059         (riscv_abi_flen): New declaration.
2060         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
2061         isa_features.
2062         (riscv_abi_xlen): New function.
2063         (riscv_isa_flen): Update to get answer from isa_features.
2064         (riscv_abi_flen): New function.
2065         (riscv_has_fp_abi): Update to get answer from abi_features.
2066         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
2067         xlen and flen.
2068         (riscv_call_info) <xlen, flen>: Update comment.
2069         (riscv_call_arg_struct): Remove invalid assertions
2070         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
2071         is removed.
2072         (riscv_gdbarch_init): Gather isa features and abi features
2073         separately, ensure both match on the gdbarch when reusing an old
2074         gdbarch.  Relax an error check to allow 32-bit abi float to run on
2075         a target with 64-bit float hardware.
2076
2077 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2078
2079         * source.c (search_command_helper): Stop reverse search
2080         when line 1 has been searched.
2081
2082 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2083
2084         * record-full.c (record_full_base_target::close): Rewrite
2085         record_full_core_buf_list free logic.
2086
2087 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2088
2089         * break-catch-syscall.c (print_one_catch_syscall): xfree
2090         the last text.
2091
2092 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2093
2094         * top.c (print_gdb_version): Update Copyright year in version
2095         message.
2096
2097 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
2098
2099         Update copyright year range in all GDB files.
2100
2101 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
2102
2103         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
2104
2105 For older changes see ChangeLog-2018.
2106 \f
2107 Local Variables:
2108 mode: change-log
2109 left-margin: 8
2110 fill-column: 74
2111 version-control: never
2112 coding: utf-8
2113 End:
2114