gdb/ChangeLog

   1 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
   2             Chris January  <chris.january@arm.com>
   3
   4         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
   5         qualifier.
   6         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
   7
   8 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
   9
  10         * f-typeprint.c (f_print_type): Update rules for printing
  11         whitespace.
  12         (f_type_print_varspec_suffix): Likewise.
  13
  14 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  15             Chris January  <chris.january@arm.com>
  16
  17         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  18         function arguments.
  19
  20 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  21
  22         * f-lang.c (build_fortran_types): Change name of void type to
  23         lower case.
  24         * f-typeprint.c (f_type_print_base): Print the name of the void
  25         type, rather than a fixed string.
  26         * f-valprint.c (f_decorations): Use lower case void string.
  27
  28 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  29             Chris January  <chris.january@arm.com>
  30
  31         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  32         types for Fortran.
  33
  34 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  35             Chris January  <chris.january@arm.com>
  36             David Lecomber  <david.lecomber@arm.com>
  37
  38         * f-exp.y (BINOP_INTRINSIC): New token.
  39         (exp): New parser rule handling BINOP_INTRINSIC.
  40         (f77_keywords): Add new builtin procedures.
  41         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  42         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  43         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  44         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  45         (print_unop_subexp_f): New function.
  46         (print_binop_subexp_f): New function.
  47         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  48         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  49         (dump_subexp_body_f): Likewise.
  50         (operator_check_f): Likewise.
  51         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  52         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
  53
  54 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  55
  56         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
  57         UNOP_KIND.
  58         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
  59         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
  60         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
  61         (operator_length_f): New fuction.
  62         (print_subexp_f): New function.
  63         (op_name_f): New function.
  64         (dump_subexp_body_f): New function.
  65         (operator_check_f): New function.
  66         (exp_descriptor_f): Replace standard expression handling functions
  67         with new functions.
  68         * gdb/fortran-operator.def: New file.
  69         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
  70         * gdb/std-operator.def: Remove UNOP_KIND.
  71
  72 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  73
  74         * std-operator.def: Remove unbalanced, stray double quote
  75         character.
  76
  77 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
  78             Chris January  <chris.january@arm.com>
  79             Daniel Everett  <daniel.everett@arm.com>
  80             Nick Forrington  <nick.forrington@arm.com>
  81             Richard Bunt  <richard.bunt@arm.com>
  82
  83         * cp-valprint.c (cp_print_value_fields): Allow an additional level
  84         of depth when printing anonymous structs or unions.
  85         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
  86         Don't print either the top-level value, or the children if the
  87         max-depth is exceeded.
  88         (ppscm_print_children): When printing the key of a map, allow one
  89         extra level of depth.
  90         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
  91         print either the top-level value, or the children if the max-depth
  92         is exceeded.
  93         (print_children): When printing the key of a map, allow one extra
  94         level of depth.
  95         * python/py-value.c (valpy_format_string): Add max_depth keyword.
  96         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
  97         (user_print_options): Initialise max_depth field.
  98         (val_print_scalar_or_string_type_p): New function.
  99         (val_print): Check to see if the max depth has been reached.
 100         (val_print_check_max_depth): Define new function.
 101         (show_print_max_depth): New function.
 102         (_initialize_valprint): Add 'print max-depth' option.
 103         * valprint.h (struct value_print_options) <max_depth>: New field.
 104         (val_print_check_max_depth): Declare new function.
 105         * NEWS: Document new feature.
 106
 107 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 108
 109         * ada-lang.c (ada_language_defn): Initialise new field.
 110         * c-lang.c (c_is_string_type_p): New function.
 111         (c_language_defn): Initialise new field.
 112         (cplus_language_defn): Initialise new field.
 113         (asm_language_defn): Initialise new field.
 114         (minimal_language_defn): Initialise new field.
 115         * c-lang.h (c_is_string_type_p): Declare new function.
 116         * d-lang.c (d_language_defn): Initialise new field.
 117         * f-lang.c (f_is_string_type_p): New function.
 118         (f_language_defn): Initialise new field.
 119         * go-lang.c (go_is_string_type_p): New function.
 120         (go_language_defn): Initialise new field.
 121         * language.c (default_is_string_type_p): New function.
 122         (unknown_language_defn): Initialise new field.
 123         (auto_language_defn): Initialise new field.
 124         * language.h (struct language_defn) <la_is_string_type_p>: New
 125         member variable.
 126         (default_is_string_type_p): Declare new function.
 127         * m2-lang.c (m2_language_defn): Initialise new field.
 128         * objc-lang.c (objc_language_defn): Initialise new field.
 129         * opencl-lang.c (opencl_language_defn): Initialise new field.
 130         * p-lang.c (pascal_is_string_type_p): New function.
 131         (pascal_language_defn): Initialise new field.
 132         * rust-lang.c (rust_is_string_type_p): New function.
 133         (rust_language_defn): Initialise new field.
 134
 135 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 136
 137         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 138         New field.
 139         * ada-lang.c (ada_language_defn): Initialise new field.
 140         * c-lang.c (c_language_defn): Likewise.
 141         (cplus_language_defn): Likewise.
 142         (asm_language_defn): Likewise.
 143         (minimal_language_defn): Likewise.
 144         * d-lang.c (d_language_defn): Likewise.
 145         * f-lang.c (f_language_defn): Likewise.
 146         * go-lang.c (go_language_defn): Likewise.
 147         * language.c (unknown_language_defn): Likewise.
 148         (auto_language_defn): Likewise.
 149         * m2-lang.c (m2_language_defn): Likewise.
 150         * objc-lang.c (objc_language_defn): Likewise.
 151         * opencl-lang.c (opencl_language_defn): Likewise.
 152         * p-lang.c (pascal_language_defn): Likewise.
 153         * rust-lang.c (rust_language_defn): Likewise.
 154
 155 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 156
 157         * ada-lang.c (ada_is_character_type): Change return type to bool.
 158         (ada_is_string_type): Likewise.
 159         * ada-lang.h (ada_is_character_type): Update declaration
 160         (ada_is_string_type): Likewise.
 161
 162 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 163
 164         Support style in 'frame|thread apply'
 165
 166         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 167         * record.c (record_start, record_stop): Update callers of
 168         execute_command_to_string with false.
 169         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 170         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 171         methods.
 172         (class string_file): New constructor with term_out parameter.
 173         Override methods term_out and can_emit_style_escape.  New member
 174         term_out.
 175         (class stdio_file): Override can_emit_style_escape.
 176         (class tee_file): Override term_out and can_emit_style_escape.
 177         * utils.h (can_emit_style_escape): Remove.
 178         * utils.c (can_emit_style_escape): Likewise.
 179         Update all callers of can_emit_style_escape (SOMESTREAM) to
 180         SOMESTREAM->can_emit_style_escape.
 181         * source-cache.c (source_cache::get_source_lines): Likewise.
 182         * stack.c (frame_apply_command_count): Call execute_command_to_string
 183         passing the term_out characteristic of the current gdb_stdout.
 184         * thread.c (thr_try_catch_cmd): Likewise.
 185         * top.c (execute_command_to_string): pass term_out parameter
 186         to construct the string_file for the command output.
 187         * ui-file.c (term_cli_styling): New function (most code moved
 188         from utils.c can_emit_style_escape).
 189         (string_file::string_file, string_file::can_emit_style_escape,
 190         stdio_file::can_emit_style_escape, tee_file::term_out,
 191         tee_file::can_emit_style_escape): New functions.
 192
 193 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 194
 195         * NEWS: Mention the new set|show may-call-functions.
 196         * infcall.c (may_call_functions_p): New variable.
 197         (show_may_call_functions_p): New function.
 198         (call_function_by_hand_dummy): Throws an error if not
 199         may-call-functions.
 200         (_initialize_infcall): Call add_setshow_boolean_cmd for
 201         may-call-functions.
 202
 203 2019-04-25  Keith Seitz  <keiths@redhat.com>
 204
 205         PR c++/24367
 206         * cp-support.c (inspect_type): Don't attempt substitutions
 207         of symbol with the same name.
 208
 209 2019-04-25  Tom Tromey  <tromey@adacore.com>
 210
 211         PR gdb/24475:
 212         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 213         static.
 214
 215 2019-04-25  Tom Tromey  <tromey@adacore.com>
 216
 217         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 218         rvalue reference.
 219         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 220         (gdb_xml_parser::parse): Use std::move.
 221         * python/python-internal.h (gdbpy_convert_exception): Take a const
 222         reference.
 223         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 224         std::move.
 225         * python/py-utils.c (gdbpy_convert_exception): Take a const
 226         reference.
 227         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 228         Use std::move.
 229         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 230         Use std::move.
 231         * mi/mi-main.c (mi_print_exception): Take a const reference.
 232         * main.c (handle_command_errors): Take a const reference.
 233         * linespec.c (parse_linespec): Use std::move.
 234         * infcall.c (run_inferior_call): Use std::move.
 235         (call_function_by_hand_dummy): Use std::move.
 236         * exec.c (try_open_exec_file): Use std::move.
 237         * exceptions.h (exception_print, exception_fprintf)
 238         (exception_print_same): Update.
 239         * exceptions.c (print_exception, exception_print)
 240         (exception_fprintf, exception_print_same): Change parameters to
 241         const reference.
 242         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 243         * common/new-op.c: Use std::move.
 244         * common/common-exceptions.h (struct gdb_exception): Add move
 245         constructor.
 246         (struct gdb_exception_error, struct gdb_exception_quit, struct
 247         gdb_quit_bad_alloc): Change constructor to move constructor.
 248         (throw_exception): Change parameter to rvalue reference.
 249         * common/common-exceptions.c (throw_exception): Take rvalue
 250         reference.
 251         * cli/cli-interp.c (safe_execute_command): Use std::move.
 252         * breakpoint.c (insert_bp_location, location_to_sals): Use
 253         std::move.
 254
 255 2019-04-25  Tom Tromey  <tromey@adacore.com>
 256
 257         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 258         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 259         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 260         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 261         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 262         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 263         guile/scm-value.c: Use unpack.
 264         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 265         gdbscm_gdb_exception.
 266         (gdbscm_throw_gdb_exception): Likewise.
 267         (struct gdbscm_gdb_exception): New.
 268         (unpack): New function.
 269         (gdbscm_wrap): Use unpack.
 270
 271 2019-04-25  Tom Tromey  <tromey@adacore.com>
 272
 273         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 274         (gdb_rl_callback_handler): Use std::move.
 275         * common/common-exceptions.h (struct gdb_exception): Add move
 276         assignment operator.
 277         (throw_exception_sjlj): Change "exception" to const reference.
 278         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 279         (throw_exception_sjlj): Change "exception" to const reference.
 280
 281 2019-04-25  Tom Tromey  <tromey@adacore.com>
 282
 283         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 284         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 285         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 286         Update.
 287         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 288         Update.
 289         * mi/mi-interp.c (mi_interp::exec): Update.
 290         * linespec.c (parse_linespec): Update.
 291         * infcall.c (run_inferior_call): Update.
 292         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 293         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 294         (gdbscm_lookup_global_symbol): Update.
 295         * guile/scm-param.c (gdbscm_parameter_value): Update.
 296         * guile/scm-frame.c (gdbscm_frame_read_register)
 297         (gdbscm_frame_read_var): Update.
 298         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 299         * exec.c (try_open_exec_file): Update.
 300         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 301         (gdb_rl_callback_handler): Update.
 302         * common/common-exceptions.h (exception_none): Don't declare.
 303         * common/common-exceptions.c (exception_none): Don't define.
 304         (struct catcher) <exception>: Update.
 305         * cli/cli-interp.c (safe_execute_command): Update.
 306         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 307
 308 2019-04-25  Ali Tamur  <tamur@google.com>
 309
 310         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 311         (read_attribute_value): Likewise.
 312         (dwarf2_read_addr_index): Update comment.
 313         (read_str_index): Add DW_FORM_strx.
 314         (dwarf2_string_attr): Likewise.
 315         (dwarf2_const_value_attr): Likewise.
 316         (dump_die_shallow): Likewise.
 317         (dwarf2_fetch_constant_bytes): Likewise.
 318         (skip_form_bytes): Likewise.
 319         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 320
 321 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 322
 323         PR corefiles/11608
 324         PR corefiles/18187
 325         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 326         OFFSET.  Verify if current mapping contains an ELF header.
 327         (linux_find_memory_regions_full): Adjust call to
 328         dump_mapping_p.
 329
 330 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 331             Kang Li <kanglictf@gmail.com>
 332
 333         PR gdb/21600
 334
 335         * dwarf2-frame.c (read_initial_length): Be consistent about using
 336         unsigned representation of length.
 337         (decode_frame_entry_1): Likewise.  Check for wraparound of
 338         end pointer as well as buffer overflow.
 339
 340 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 341
 342         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 343         "vq".
 344
 345 2019-04-24  Tom Tromey  <tromey@adacore.com>
 346
 347         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 348
 349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 350
 351         * s12z-tdep.c (s12z_unwind_pc): Delete.
 352         (s12z_unwind_sp): Delete.
 353         (s12z_gdbarch_init): Don't register deleted functions with
 354         gdbarch.
 355
 356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 357
 358         * rl78-tdep.c (rl78_unwind_sp): Delete.
 359         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 360
 361 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 362
 363         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 364         (xstormy16_unwind_pc): Delete.
 365         (xstormy16_dummy_id): Delete.
 366         (xstormy16_gdbarch_init): Don't register deleted functions with
 367         gdbarch.
 368
 369 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 370
 371         * vax-tdep.c (vax_unwind_pc): Delete.
 372         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 373
 374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 375
 376         * v850-tdep.c (v850_unwind_sp): Delete.
 377         (v850_unwind_pc): Delete.
 378         (v850_dummy_id): Delete.
 379         (v850_gdbarch_init): Don't register deleted functions with
 380         gdbarch.
 381
 382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 383
 384         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 385         (tilegx_unwind_pc): Delete.
 386         (tilegx_unwind_dummy_id): Delete.
 387         (tilegx_gdbarch_init): Don't register deleted functions with
 388         gdbarch.
 389
 390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 391
 392         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 393         (tic6x_dummy_id): Delete.
 394         (tic6x_gdbarch_init): Don't register deleted functions with
 395         gdbarch.
 396
 397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 398
 399         * sparc-tdep.c (sparc_unwind_pc): Delete.
 400         (sparc32_gdbarch_init): Don't register deleted function with
 401         gdbarch.
 402
 403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 404
 405         * sh-tdep.c (sh_unwind_sp): Delete.
 406         (sh_unwind_pc): Delete.
 407         (sh_dummy_id): Delete.
 408         (sh_gdbarch_init): Don't register deleted functions with
 409         gdbarch.
 410
 411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 412
 413         * score-tdep.c (score_unwind_sp): Delete.
 414         (score_unwind_pc): Delete.
 415         (score_dummy_id): Delete.
 416         (score_gdbarch_init): Don't register deleted functions with
 417         gdbarch.
 418
 419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 420
 421         * rx-tdep.c (rx_unwind_pc): Delete.
 422         (rx_unwind_sp): Delete.
 423         (rx_dummy_id): Delete.
 424         (rx_gdbarch_init): Don't register deleted functions with
 425         gdbarch.  Update comment.
 426
 427 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 428
 429         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 430         (rs6000_dummy_id): Delete.
 431         (rs6000_gdbarch_init): Don't register deleted functions with
 432         gdbarch.
 433
 434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 435
 436         * or1k-tdep.c (or1k_dummy_id): Delete.
 437         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 438
 439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 440
 441         * nios2-tdep.c (nios2_dummy_id): Delete.
 442         (nios2_unwind_sp): Delete.
 443         (nios2_gdbarch_init): Don't register deleted functions with
 444         gdbarch.
 445
 446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 447
 448         * nds32-tdep.c (nds32_dummy_id): Delete.
 449         (nds32_unwind_pc): Delete.
 450         (nds32_unwind_sp): Delete.
 451         (nds32_gdbarch_init): Don't register deleted functions with
 452         gdbarch.
 453
 454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 455
 456         * msp430-tdep.c (msp430_unwind_pc): Delete.
 457         (msp430_unwind_sp): Delete.
 458         (msp430_dummy_id): Delete.
 459         (msp430_gdbarch_init): Don't register deleted functions with
 460         gdbarch.
 461
 462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 463
 464         * moxie-tdep.c (moxie_unwind_sp): Delete.
 465         (moxie_unwind_pc): Delete.
 466         (moxie_dummy_id): Delete.
 467         (moxie_gdbarch_init): Don't register deleted functions with
 468         gdbarch.
 469
 470 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 471
 472         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 473         (mn10300_unwind_pc): Delete.
 474         (mn10300_unwind_sp): Delete.
 475         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 476         mn10300_unwind_sp.
 477         (mn10300_frame_unwind_init): Don't register deleted functions with
 478         gdbarch.
 479
 480 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 481
 482         * mep-tdep.c (mep_unwind_pc): Delete.
 483         (mep_unwind_sp): Delete.
 484         (mep_dummy_id): Delete.
 485         (mep_gdbarch_init): Don't register deleted functions with
 486         gdbarch.
 487
 488 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 489
 490         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 491         (m68hc11_unwind_sp): Delete.
 492         (m68hc11_gdbarch_init): Don't register deleted functions with
 493         gdbarch.
 494
 495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 496
 497         * m32r-tdep.c (m32r_unwind_sp): Delete.
 498         (m32r_unwind_pc): Delete.
 499         (m32r_dummy_id): Delete.
 500         (m32r_gdbarch_init): Don't register deleted functions with
 501         gdbarch.
 502
 503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 504
 505         * m32c-tdep.c (m32c_unwind_pc): Delete.
 506         (m32c_unwind_sp): Delete.
 507         (m32c_dummy_id): Delete.
 508         (m32c_gdbarch_init): Don't register deleted functions with
 509         gdbarch.
 510
 511 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 512
 513         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 514         (lm32_unwind_pc): Delete.
 515         (lm32_dummy_id): Delete.
 516         (lm32_gdbarch_init): Don't register deleted functions with
 517         gdbarch.
 518
 519 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 520
 521         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 522         (iq2000_unwind_pc): Delete.
 523         (iq2000_dummy_id): Delete.
 524         (iq2000_gdbarch_init): Don't register deleted functions with
 525         gdbarch.
 526
 527 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 528
 529         * nds32-tdep.c (nds32_type_align): Delete.
 530         (nds32_push_dummy_call): Use type_align instead.
 531
 532 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 533
 534         * arm-tdep.c (arm_type_align): Only handle vector override case.
 535         (arm_push_dummy_call): Use type_align.
 536         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 537
 538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 541         case.
 542         (pass_on_stack): Use type_align.
 543         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 544         function.
 545
 546 2019-04-23  Tom Tromey  <tromey@adacore.com>
 547
 548         * dwarf2read.c (line_header::file_name_at): Remove unused
 549         overload.
 550
 551 2019-04-23  Tom de Vries  <tdevries@suse.de>
 552
 553         PR gdb/24438
 554         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 555         invocation.
 556
 557
 558 2019-03-27  Ali Tamur  <tamur@google.com>
 559
 560         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 561         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 562         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 563         (dwarf_expr_context::get_addr_index): Likewise
 564         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 565         (symbol_needs_eval_context::get_addr_index): Likewise
 566         (disassemble_dwarf_expression): Add DW_OP_addrx
 567         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 568         (read_cutu_die_from_dwo): Update comment
 569         (skip_one_die): Add DW_FORM_addrx
 570         (read_attribute_value): Likewise
 571         (var_decode_location): Add DW_OP_addrx
 572         (dwarf2_const_value_attr): Add DW_FORM_addrx
 573         (dump_die_shallow): Likewise
 574         (dwarf2_fetch_constant_bytes): Likewise
 575         (decode_locdesc): Add DW_OP_addrx
 576         (skip_form_bytes): Add DW_FORM_addrx
 577
 578 2019-04-22  Ali Tamur  <tamur@google.com>
 579
 580         * MAINTAINERS (Write After Approval): Add self.
 581
 582 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 583
 584         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 585         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 586         (open_symbol_file_object): Likewise.
 587         (svr4_default_sos): Add info parameter.
 588         (svr4_read_so_list): Likewise.
 589         (svr4_current_sos_direct): Adjust functions calls to pass down
 590         info.
 591         (svr4_current_sos_1): Add info parameter.
 592         (svr4_current_sos): Call get_svr4_info, pass info down to
 593         svr4_current_sos_1.
 594         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 595         get_svr4_info.
 596         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 597         get_svr4_info.
 598         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 599         to get_svr4_info.
 600         (probes_table_remove_objfile_probes): Likewise.
 601         (register_solib_event_probe): Add info parameter.
 602         (solist_update_incremental): Pass info parameter down to
 603         svr4_read_so_list.
 604         (disable_probes_interface): Add info parameter.
 605         (svr4_handle_solib_event): Pass current_program_space to
 606         get_svr4_info.  Adjust disable_probes_interface cleanup.
 607         (svr4_create_probe_breakpoints): Add info parameter, pass it
 608         down to register_solib_event_probe.
 609         (svr4_create_solib_event_breakpoints): Add info parameter,
 610         pass it down to svr4_create_probe_breakpoints.
 611         (enable_break): Pass info down to
 612         svr4_create_solib_event_breakpoints.
 613         (svr4_solib_create_inferior_hook): Pass current_program_space to
 614         get_svr4_info.
 615         (svr4_clear_solib): Likewise.
 616
 617 2019-04-22  Pedro Alves  <palves@redhat.com>
 618
 619         * solib-svr4.c (svr4_free_objfile_observer): New.
 620         (probe_and_action::objfile): New field.
 621         (probes_table_htab_remove_objfile_probes)
 622         (probes_table_remove_objfile_probes): New functions.
 623         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 624         in the new probe_and_action.  Don't store the probe in 'lookup'.
 625         (svr4_create_probe_breakpoints): Pass objfile to
 626         register_solib_event_probe.
 627         (_initialize_svr4_solib): Register a free_objfile observer.
 628
 629 2019-04-19  Tom Tromey  <tom@tromey.com>
 630
 631         * common/queue.h: Remove.
 632
 633 2019-04-19  Tom Tromey  <tom@tromey.com>
 634
 635         * event-loop.c: Don't include "common/queue.h".
 636
 637 2019-04-19  Tom Tromey  <tom@tromey.com>
 638
 639         * remote.c (remote_target): Use delete.
 640         * remote-notif.h: Include <list>, not "common/queue.h".
 641         (notif_client_p): Remove typedef.
 642         (remote_notif_state): Add constructor, destructor, initializer.
 643         <notif_queue>: Now a std::list.
 644         (remote_notif_state_xfree): Don't declare.
 645         * remote-notif.c (remote_notif_process, handle_notification)
 646         (remote_notif_state_allocate): Update.
 647         (~remote_notif_state): Rename from remote_notif_state_xfree.
 648
 649 2019-04-19  Tom Tromey  <tom@tromey.com>
 650
 651         * symfile.c (reread_symbols): Update.
 652         * objfiles.c (objfile_register_static_link)
 653         (objfile_lookup_static_link): Update
 654         (~objfile) Don't delete static_links.
 655         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 656
 657 2019-04-19  Tom Tromey  <tom@tromey.com>
 658
 659         * type-stack.h (struct type_stack) <insert>: Constify string.
 660         * type-stack.c (type_stack::insert): Constify string.
 661         * gdbtypes.h (lookup_template_type): Update.
 662         (address_space_name_to_int): Update.
 663         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 664         const.
 665         (lookup_template_type): Make name const.
 666         * c-exp.y: Update rules.
 667         (lex_one_token, classify_name, classify_inner_name)
 668         (c_print_token): Update.
 669         * p-exp.y: Update rules.
 670         (yylex): Update.
 671         * f-exp.y: Update rules.
 672         (yylex): Update.
 673         * d-exp.y: Update rules.
 674         (lex_one_token, classify_name, classify_inner_name): Update.
 675         * parse.c (write_dollar_variable, copy_name): Return std::string.
 676         * parser-defs.h (copy_name): Change return type.
 677         * m2-exp.y: Update rules.
 678         (yylex): Update.
 679         * go-exp.y (lex_one_token): Update.
 680         Update rules.
 681         (classify_unsafe_function, classify_packaged_name)
 682         (classify_name, yylex): Update.
 683
 684 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 685
 686         * configure.ac: add --enable-source-highlight switch.
 687         * configure: Regenerate.
 688         * top.c (print_gdb_version): plumb --enable-source-highlight
 689         status to "show configuration".
 690
 691 2019-04-19  Tom Tromey  <tromey@adacore.com>
 692
 693         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 694         Check ADA_TYPE_P.
 695         (empty_record, ada_template_to_fixed_record_type_1)
 696         (template_to_static_fixed_type)
 697         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 698         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 699         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 700         macros.
 701
 702 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 703
 704         PR symtab/24423:
 705         * source.c (print_source_lines_base): Advance "iter" when a
 706         control character is seen.
 707
 708 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 709
 710         * inferior.h (struct infcall_suspend_state_deleter):
 711         Catch exception in destructor to avoid crash.
 712
 713 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 714
 715         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 716         close to the add_com "shell".
 717
 718 2019-04-18  Tom Tromey  <tromey@adacore.com>
 719
 720         * process-stratum-target.h (class process_stratum_target)
 721         <stratum>: Add "final".
 722
 723 2019-04-17  Tom Tromey  <tromey@adacore.com>
 724
 725         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 726         against nullptr before use.
 727
 728 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 729
 730         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 731
 732 2019-04-17  Jim Wilson  <jimw@sifive.com>
 733             Andrew Burgess  <andrew.burgess@embecosm.com>
 734
 735         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 736         code read might fail, assume 4-byte breakpoint in that case.
 737
 738 2019-04-15  Leszek Swirski  <leszeks@google.com>
 739
 740         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 741         rather than a hand-rolled POD check when checking for forced MEMORY
 742         classification.
 743
 744 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 745
 746         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 747         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 748         function.
 749         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 750         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 751         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 752         declaration.
 753
 754 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 755
 756         * aarch64-linux-nat.c
 757         (aarch64_linux_nat_target::thread_architecture): Add override.
 758         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 759         each VQ.
 760
 761 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 762
 763         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 764
 765 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 766
 767         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 768         target types of size 96-bits, add some additional comments, and
 769         check that the builtin type we found was the correct size.
 770
 771 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 772
 773         * utils.c (prompt_for_continue): Don't restore the styling at the
 774         end, as applied_style has the wrong value.  This fixes styling in
 775         long lists of file names that are interrupted by the "Continue?"
 776         prompt.
 777
 778 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 779
 780         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 781         * c-lang.c (c_language_defn): Likewise.
 782         (cplus_language_defn): Likewise.
 783         (asm_language_defn): Likewise.
 784         (minimal_language_defn): Likewise.
 785         * d-lang.c (d_language_defn): Likewise.
 786         * f-lang.c (f_language_defn): Likewise.
 787         * go-lang.c (go_language_defn): Likewise.
 788         * language.c (unknown_language_defn): Likewise.
 789         (auto_language_defn): Likewise.
 790         * language.h (struct language_defn): Remove la_magic field.
 791         (LANG_MAGIC): Delete.
 792         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 793         * objc-lang.c (objc_language_defn): Likewise.
 794         * opencl-lang.c (opencl_language_defn): Likewise.
 795         * p-lang.c (pascal_language_defn): Likewise.
 796         * rust-lang.c (rust_language_defn): Likewise.
 797
 798 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 799
 800         * riscv-tdep.c (riscv_type_align): New function.
 801         (riscv_type_alignment): Delete.
 802         (riscv_arg_location): Use 'type_align'.
 803         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 804
 805 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 806
 807         * gdbtypes.c (type_align): A struct with no non-static fields also
 808         has alignment of 1.
 809
 810 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 811
 812         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 813         component to 0.
 814         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 815         member.
 816         (riscv_struct_info::analyse): New implementation using new
 817         analyse_inner member function.
 818         (riscv_struct_info::field_offset): New member function.
 819         (riscv_struct_info::m_offsets): New member variable.
 820         (riscv_struct_info::analyse_inner): New private member function,
 821         takes the old implementation of riscv_struct_info::analyse but
 822         extended to track field offsets.
 823         (riscv_call_arg_struct): Update the struct folding special cases
 824         to handle cases where empty C++ structs, which are non-zero
 825         length, are found.
 826         (riscv_arg_location): Initialise the length of each location, a
 827         non-zero length now indicates the location is in use.
 828         (riscv_push_dummy_call): Allow for the first location having a
 829         non-zero offset when setting up arguments.
 830         (riscv_return_value): Likewise, but for return values.
 831
 832 2019-04-11  Tom Tromey  <tromey@adacore.com>
 833
 834         * utils.c (internal_vproblem): Make "msg" const.
 835
 836 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 837
 838         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 839         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 840         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 841         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 842
 843 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 844
 845         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 846         function.
 847         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 848         of amd64_collect_native_gregset.
 849         (amd64_linux_nat_target::store_registers): Likewise.
 850
 851 2019-04-10  Tom Tromey  <tom@tromey.com>
 852
 853         * symtab.c (lookup_global_symbol_from_objfile)
 854         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 855         * objfiles.h (class separate_debug_iterator): New.
 856         (class separate_debug_range): New.
 857         (struct objfile) <separate_debug_objfiles>: New method.
 858         (objfile_separate_debug_iterate): Don't declare.
 859         * objfiles.c (separate_debug_iterator::operator++): Rename from
 860         objfile_separate_debug_iterate.
 861         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 862         iterator.
 863         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 864         iterator.
 865
 866 2019-04-10  Tom Tromey  <tom@tromey.com>
 867
 868         * symfile.c (reread_symbols): Remove old comment.
 869         * objfiles.c (free_all_objfiles): Fix a typo.
 870
 871 2019-04-10  Tom Tromey  <tom@tromey.com>
 872
 873         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 874         * minsyms.c (lookup_minimal_symbol): Use foreach.
 875         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 876         (lookup_minimal_symbol_solib_trampoline): Likewise.
 877         * symfile.c (reread_symbols): Use foreach.
 878
 879 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 880             Tom Tromey  <tromey@adacore.com>
 881
 882         PR rust/24414:
 883         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 884         (rust_lex_int_test): Change "value" to be LONGEST.
 885         (rust_lex_tests): Add test for long integer literal.
 886
 887 2019-04-09  Tom Tromey  <tromey@adacore.com>
 888
 889         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 890         to bool.
 891         (extended_remote_target::attach): Update.
 892         (remote_target::remote_notice_new_inferior): Update.
 893         (remote_target::add_current_inferior_and_thread): Update.
 894         * inferior.c (exit_inferior_1): Use "false".
 895         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 896
 897 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 898
 899         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 900         the "start" command.
 901
 902 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 903
 904         * python/py-inferior.c (infpy_thread_from_thread_handle):
 905         Adjust comments to reflect renaming of thread_from_thread_handle
 906         to thread_from_handle.  Adjust keywords.  Fix type error message.
 907         (inferior_object_methods): Add thread_from_handle.  Retain
 908         thread_from_thread_handle, but mark it as deprecated.
 909
 910 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 911
 912         * gdbthread.h (find_thread_by_handle): Revise declaration.
 913         * thread.c (find_thread_by_handle): Likewise.  Adjust
 914         implementation too.
 915         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 916         support for buffer objects as handles.
 917
 918 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 919
 920         * python/py-infthread.c (thpy_thread_handle): New function.
 921         (thread_object_methods): Register thpy_thread_handle.
 922
 923 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 924
 925         * gdbthread.h (thread_to_thread_handle): Declare.
 926         * thread.c (gdbtypes.h): Include.
 927         (thread_to_thread_handle): New function.
 928
 929         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 930         (target_thread_info_to_thread_handle): Declare.
 931         * target.c (target_thread_info_to_thread_handle): New function.
 932         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 933         * target-delegates.c: Regenerate.
 934
 935         * linux-thread-db.c (class thread_db_target): Add method
 936         thread_info_to_thread_handle.
 937         (thread_db_target::thread_info_to_thread_handle): Define.
 938         * remote.c (class remote_target): Add new method
 939         thread_info_to_thread_handle.
 940         (remote_target::thread_info_to_thread_handle): Define.
 941
 942 2019-04-08  Pedro Alves  <palves@redhat.com>
 943
 944         * common/common-exceptions.c (throw_exception): Don't create
 945         named object to throw; throw directly.
 946         (throw_it): Likewise.  Don't initialize gdb_exception::message
 947         here, with new; pass FMT and AP to the ctor instead.
 948         * common/common-exceptions.h: Include <string>.
 949         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 950         const char *, va_list)): New ctor.  Use std::make_shared.
 951         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 952         errors)): Delete.
 953         (gdb_exception_error::gdb_exception_error(enum errors, const char
 954         *, va_list)): New.
 955         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 956         Add assertion.
 957         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 958         errors)): Delete.
 959         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 960         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 961         Add assertion.
 962
 963 2019-04-08  Tom Tromey  <tom@tromey.com>
 964
 965         * valops.c (value_rtti_indirect_type): Replace throw_exception
 966         with throw.
 967         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 968         with throw.
 969         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 970         throw.
 971         * target.c (target_translate_tls_address): Replace throw_exception
 972         with throw.
 973         * stack.c (frame_apply_command_count): Replace throw_exception
 974         with throw.
 975         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 976         throw.
 977         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 978         with throw.
 979         * rs6000-tdep.c (rs6000_frame_cache)
 980         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 981         * remote.c: Replace throw_exception with throw.
 982         * record-full.c (record_full_message, record_full_wait_1)
 983         (record_full_restore): Replace throw_exception with throw.
 984         * record-btrace.c:
 985         (get_thread_current_frame_id, record_btrace_start_replaying)
 986         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 987         (cmd_record_btrace_start): Replace throw_exception with throw.
 988         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 989         throw.
 990         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 991         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 992         * linespec.c:
 993         (find_linespec_symbols): Replace throw_exception with throw.
 994         * infrun.c (displaced_step_prepare, resume): Replace
 995         throw_exception with throw.
 996         * infcmd.c (post_create_inferior): Replace throw_exception with
 997         throw.
 998         * inf-loop.c (inferior_event_handler): Replace throw_exception
 999         with throw.
1000         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1001         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1002         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1003         (get_prev_frame_always, get_frame_pc_if_available)
1004         (get_frame_address_in_block_if_available, get_frame_language):
1005         Replace throw_exception with throw.
1006         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1007         throw_exception with throw.
1008         * eval.c (fetch_subexp_value, evaluate_var_value)
1009         (evaluate_funcall, evaluate_subexp_standard): Replace
1010         throw_exception with throw.
1011         * dwarf2loc.c (call_site_find_chain)
1012         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1013         Replace throw_exception with throw.
1014         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1015         with throw.
1016         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1017         throw.
1018         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1019         * completer.c (complete_line_internal): Replace throw_exception
1020         with throw.
1021         * compile/compile-object-run.c (compile_object_run): Replace
1022         throw_exception with throw.
1023         * cli/cli-script.c (process_next_line): Replace throw_exception
1024         with throw.
1025         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1026         (btrace_enable, btrace_maint_update_pt_packets): Replace
1027         throw_exception with throw.
1028         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1029         throw_exception with throw.
1030         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1031         throw_exception with throw.
1032         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1033         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1034         * aarch64-tdep.c (aarch64_make_prologue_cache)
1035         (aarch64_make_stub_cache): Replace throw_exception with throw.
1036
1037 2019-04-08  Tom Tromey  <tom@tromey.com>
1038
1039         * common/common-exceptions.c (throw_exception): Rename from
1040         throw_exception_cxx.  Remove old copy.  Make argument const.
1041         (throw_it): Create and throw exception objects directly.
1042         * common/common-exceptions.h (throw_exception): Make argument
1043         const.
1044         (struct gdb_exception_error): Add constructor.
1045         (struct gdb_exception_quit): Add constructor.
1046
1047 2019-04-08  Tom Tromey  <tom@tromey.com>
1048
1049         * common/common-exceptions.h (exception_rethrow): Don't declare.
1050         (TRY_SJLJ): Update comment.
1051         (TRY, CATCH, END_CATCH): Remove.
1052         * common/common-exceptions.c (exception_rethrow): Remove.
1053
1054 2019-04-08  Tom Tromey  <tom@tromey.com>
1055
1056         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1057         Remove.
1058         (gdb_exception_error): Rename from
1059         gdb_exception_RETURN_MASK_ERROR.
1060         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1061         (gdb_quit_bad_alloc): Update.
1062         * aarch64-tdep.c: Update.
1063         * ada-lang.c: Update.
1064         * ada-typeprint.c: Update.
1065         * ada-valprint.c: Update.
1066         * amd64-tdep.c: Update.
1067         * arch-utils.c: Update.
1068         * break-catch-throw.c: Update.
1069         * breakpoint.c: Update.
1070         * btrace.c: Update.
1071         * c-varobj.c: Update.
1072         * cli/cli-cmds.c: Update.
1073         * cli/cli-interp.c: Update.
1074         * cli/cli-script.c: Update.
1075         * common/common-exceptions.c: Update.
1076         * common/new-op.c: Update.
1077         * common/selftest.c: Update.
1078         * compile/compile-c-symbols.c: Update.
1079         * compile/compile-cplus-symbols.c: Update.
1080         * compile/compile-object-load.c: Update.
1081         * compile/compile-object-run.c: Update.
1082         * completer.c: Update.
1083         * corelow.c: Update.
1084         * cp-abi.c: Update.
1085         * cp-support.c: Update.
1086         * cp-valprint.c: Update.
1087         * darwin-nat.c: Update.
1088         * disasm-selftests.c: Update.
1089         * dtrace-probe.c: Update.
1090         * dwarf-index-cache.c: Update.
1091         * dwarf-index-write.c: Update.
1092         * dwarf2-frame-tailcall.c: Update.
1093         * dwarf2-frame.c: Update.
1094         * dwarf2loc.c: Update.
1095         * dwarf2read.c: Update.
1096         * eval.c: Update.
1097         * event-loop.c: Update.
1098         * event-top.c: Update.
1099         * exec.c: Update.
1100         * f-valprint.c: Update.
1101         * fbsd-tdep.c: Update.
1102         * frame-unwind.c: Update.
1103         * frame.c: Update.
1104         * gdbtypes.c: Update.
1105         * gnu-v3-abi.c: Update.
1106         * guile/guile-internal.h: Update.
1107         * guile/scm-block.c: Update.
1108         * guile/scm-breakpoint.c: Update.
1109         * guile/scm-cmd.c: Update.
1110         * guile/scm-disasm.c: Update.
1111         * guile/scm-frame.c: Update.
1112         * guile/scm-lazy-string.c: Update.
1113         * guile/scm-math.c: Update.
1114         * guile/scm-param.c: Update.
1115         * guile/scm-ports.c: Update.
1116         * guile/scm-pretty-print.c: Update.
1117         * guile/scm-symbol.c: Update.
1118         * guile/scm-symtab.c: Update.
1119         * guile/scm-type.c: Update.
1120         * guile/scm-value.c: Update.
1121         * i386-linux-tdep.c: Update.
1122         * i386-tdep.c: Update.
1123         * inf-loop.c: Update.
1124         * infcall.c: Update.
1125         * infcmd.c: Update.
1126         * infrun.c: Update.
1127         * jit.c: Update.
1128         * language.c: Update.
1129         * linespec.c: Update.
1130         * linux-fork.c: Update.
1131         * linux-nat.c: Update.
1132         * linux-tdep.c: Update.
1133         * linux-thread-db.c: Update.
1134         * main.c: Update.
1135         * mi/mi-cmd-break.c: Update.
1136         * mi/mi-cmd-stack.c: Update.
1137         * mi/mi-interp.c: Update.
1138         * mi/mi-main.c: Update.
1139         * objc-lang.c: Update.
1140         * p-valprint.c: Update.
1141         * parse.c: Update.
1142         * ppc-linux-tdep.c: Update.
1143         * printcmd.c: Update.
1144         * python/py-arch.c: Update.
1145         * python/py-breakpoint.c: Update.
1146         * python/py-cmd.c: Update.
1147         * python/py-finishbreakpoint.c: Update.
1148         * python/py-frame.c: Update.
1149         * python/py-framefilter.c: Update.
1150         * python/py-gdb-readline.c: Update.
1151         * python/py-inferior.c: Update.
1152         * python/py-infthread.c: Update.
1153         * python/py-lazy-string.c: Update.
1154         * python/py-linetable.c: Update.
1155         * python/py-objfile.c: Update.
1156         * python/py-param.c: Update.
1157         * python/py-prettyprint.c: Update.
1158         * python/py-progspace.c: Update.
1159         * python/py-record-btrace.c: Update.
1160         * python/py-record.c: Update.
1161         * python/py-symbol.c: Update.
1162         * python/py-type.c: Update.
1163         * python/py-unwind.c: Update.
1164         * python/py-utils.c: Update.
1165         * python/py-value.c: Update.
1166         * python/python.c: Update.
1167         * record-btrace.c: Update.
1168         * record-full.c: Update.
1169         * remote-fileio.c: Update.
1170         * remote.c: Update.
1171         * riscv-tdep.c: Update.
1172         * rs6000-aix-tdep.c: Update.
1173         * rs6000-tdep.c: Update.
1174         * rust-exp.y: Update.
1175         * rust-lang.c: Update.
1176         * s390-tdep.c: Update.
1177         * selftest-arch.c: Update.
1178         * solib-dsbt.c: Update.
1179         * solib-frv.c: Update.
1180         * solib-spu.c: Update.
1181         * solib-svr4.c: Update.
1182         * solib.c: Update.
1183         * sparc64-linux-tdep.c: Update.
1184         * stack.c: Update.
1185         * symfile-mem.c: Update.
1186         * symmisc.c: Update.
1187         * target.c: Update.
1188         * thread.c: Update.
1189         * top.c: Update.
1190         * tracefile-tfile.c: Update.
1191         * tui/tui.c: Update.
1192         * typeprint.c: Update.
1193         * unittests/cli-utils-selftests.c: Update.
1194         * unittests/parse-connection-spec-selftests.c: Update.
1195         * valops.c: Update.
1196         * valprint.c: Update.
1197         * value.c: Update.
1198         * varobj.c: Update.
1199         * windows-nat.c: Update.
1200         * x86-linux-nat.c: Update.
1201         * xml-support.c: Update.
1202
1203 2019-04-08  Tom Tromey  <tom@tromey.com>
1204
1205         * xml-support.c: Use C++ exception handling.
1206         * x86-linux-nat.c: Use C++ exception handling.
1207         * windows-nat.c: Use C++ exception handling.
1208         * varobj.c: Use C++ exception handling.
1209         * value.c: Use C++ exception handling.
1210         * valprint.c: Use C++ exception handling.
1211         * valops.c: Use C++ exception handling.
1212         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1213         handling.
1214         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1215         * typeprint.c: Use C++ exception handling.
1216         * tui/tui.c: Use C++ exception handling.
1217         * tracefile-tfile.c: Use C++ exception handling.
1218         * top.c: Use C++ exception handling.
1219         * thread.c: Use C++ exception handling.
1220         * target.c: Use C++ exception handling.
1221         * symmisc.c: Use C++ exception handling.
1222         * symfile-mem.c: Use C++ exception handling.
1223         * stack.c: Use C++ exception handling.
1224         * sparc64-linux-tdep.c: Use C++ exception handling.
1225         * solib.c: Use C++ exception handling.
1226         * solib-svr4.c: Use C++ exception handling.
1227         * solib-spu.c: Use C++ exception handling.
1228         * solib-frv.c: Use C++ exception handling.
1229         * solib-dsbt.c: Use C++ exception handling.
1230         * selftest-arch.c: Use C++ exception handling.
1231         * s390-tdep.c: Use C++ exception handling.
1232         * rust-lang.c: Use C++ exception handling.
1233         * rust-exp.y: Use C++ exception handling.
1234         * rs6000-tdep.c: Use C++ exception handling.
1235         * rs6000-aix-tdep.c: Use C++ exception handling.
1236         * riscv-tdep.c: Use C++ exception handling.
1237         * remote.c: Use C++ exception handling.
1238         * remote-fileio.c: Use C++ exception handling.
1239         * record-full.c: Use C++ exception handling.
1240         * record-btrace.c: Use C++ exception handling.
1241         * python/python.c: Use C++ exception handling.
1242         * python/py-value.c: Use C++ exception handling.
1243         * python/py-utils.c: Use C++ exception handling.
1244         * python/py-unwind.c: Use C++ exception handling.
1245         * python/py-type.c: Use C++ exception handling.
1246         * python/py-symbol.c: Use C++ exception handling.
1247         * python/py-record.c: Use C++ exception handling.
1248         * python/py-record-btrace.c: Use C++ exception handling.
1249         * python/py-progspace.c: Use C++ exception handling.
1250         * python/py-prettyprint.c: Use C++ exception handling.
1251         * python/py-param.c: Use C++ exception handling.
1252         * python/py-objfile.c: Use C++ exception handling.
1253         * python/py-linetable.c: Use C++ exception handling.
1254         * python/py-lazy-string.c: Use C++ exception handling.
1255         * python/py-infthread.c: Use C++ exception handling.
1256         * python/py-inferior.c: Use C++ exception handling.
1257         * python/py-gdb-readline.c: Use C++ exception handling.
1258         * python/py-framefilter.c: Use C++ exception handling.
1259         * python/py-frame.c: Use C++ exception handling.
1260         * python/py-finishbreakpoint.c: Use C++ exception handling.
1261         * python/py-cmd.c: Use C++ exception handling.
1262         * python/py-breakpoint.c: Use C++ exception handling.
1263         * python/py-arch.c: Use C++ exception handling.
1264         * printcmd.c: Use C++ exception handling.
1265         * ppc-linux-tdep.c: Use C++ exception handling.
1266         * parse.c: Use C++ exception handling.
1267         * p-valprint.c: Use C++ exception handling.
1268         * objc-lang.c: Use C++ exception handling.
1269         * mi/mi-main.c: Use C++ exception handling.
1270         * mi/mi-interp.c: Use C++ exception handling.
1271         * mi/mi-cmd-stack.c: Use C++ exception handling.
1272         * mi/mi-cmd-break.c: Use C++ exception handling.
1273         * main.c: Use C++ exception handling.
1274         * linux-thread-db.c: Use C++ exception handling.
1275         * linux-tdep.c: Use C++ exception handling.
1276         * linux-nat.c: Use C++ exception handling.
1277         * linux-fork.c: Use C++ exception handling.
1278         * linespec.c: Use C++ exception handling.
1279         * language.c: Use C++ exception handling.
1280         * jit.c: Use C++ exception handling.
1281         * infrun.c: Use C++ exception handling.
1282         * infcmd.c: Use C++ exception handling.
1283         * infcall.c: Use C++ exception handling.
1284         * inf-loop.c: Use C++ exception handling.
1285         * i386-tdep.c: Use C++ exception handling.
1286         * i386-linux-tdep.c: Use C++ exception handling.
1287         * guile/scm-value.c: Use C++ exception handling.
1288         * guile/scm-type.c: Use C++ exception handling.
1289         * guile/scm-symtab.c: Use C++ exception handling.
1290         * guile/scm-symbol.c: Use C++ exception handling.
1291         * guile/scm-pretty-print.c: Use C++ exception handling.
1292         * guile/scm-ports.c: Use C++ exception handling.
1293         * guile/scm-param.c: Use C++ exception handling.
1294         * guile/scm-math.c: Use C++ exception handling.
1295         * guile/scm-lazy-string.c: Use C++ exception handling.
1296         * guile/scm-frame.c: Use C++ exception handling.
1297         * guile/scm-disasm.c: Use C++ exception handling.
1298         * guile/scm-cmd.c: Use C++ exception handling.
1299         * guile/scm-breakpoint.c: Use C++ exception handling.
1300         * guile/scm-block.c: Use C++ exception handling.
1301         * guile/guile-internal.h: Use C++ exception handling.
1302         * gnu-v3-abi.c: Use C++ exception handling.
1303         * gdbtypes.c: Use C++ exception handling.
1304         * frame.c: Use C++ exception handling.
1305         * frame-unwind.c: Use C++ exception handling.
1306         * fbsd-tdep.c: Use C++ exception handling.
1307         * f-valprint.c: Use C++ exception handling.
1308         * exec.c: Use C++ exception handling.
1309         * event-top.c: Use C++ exception handling.
1310         * event-loop.c: Use C++ exception handling.
1311         * eval.c: Use C++ exception handling.
1312         * dwarf2read.c: Use C++ exception handling.
1313         * dwarf2loc.c: Use C++ exception handling.
1314         * dwarf2-frame.c: Use C++ exception handling.
1315         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1316         * dwarf-index-write.c: Use C++ exception handling.
1317         * dwarf-index-cache.c: Use C++ exception handling.
1318         * dtrace-probe.c: Use C++ exception handling.
1319         * disasm-selftests.c: Use C++ exception handling.
1320         * darwin-nat.c: Use C++ exception handling.
1321         * cp-valprint.c: Use C++ exception handling.
1322         * cp-support.c: Use C++ exception handling.
1323         * cp-abi.c: Use C++ exception handling.
1324         * corelow.c: Use C++ exception handling.
1325         * completer.c: Use C++ exception handling.
1326         * compile/compile-object-run.c: Use C++ exception handling.
1327         * compile/compile-object-load.c: Use C++ exception handling.
1328         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1329         * compile/compile-c-symbols.c: Use C++ exception handling.
1330         * common/selftest.c: Use C++ exception handling.
1331         * common/new-op.c: Use C++ exception handling.
1332         * cli/cli-script.c: Use C++ exception handling.
1333         * cli/cli-interp.c: Use C++ exception handling.
1334         * cli/cli-cmds.c: Use C++ exception handling.
1335         * c-varobj.c: Use C++ exception handling.
1336         * btrace.c: Use C++ exception handling.
1337         * breakpoint.c: Use C++ exception handling.
1338         * break-catch-throw.c: Use C++ exception handling.
1339         * arch-utils.c: Use C++ exception handling.
1340         * amd64-tdep.c: Use C++ exception handling.
1341         * ada-valprint.c: Use C++ exception handling.
1342         * ada-typeprint.c: Use C++ exception handling.
1343         * ada-lang.c: Use C++ exception handling.
1344         * aarch64-tdep.c: Use C++ exception handling.
1345
1346 2019-04-08  Tom Tromey  <tom@tromey.com>
1347
1348         * xml-support.c (gdb_xml_parser::parse): Update.
1349         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1350         * value.c (show_convenience): Update.
1351         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1352         (test_parse_flags_qcs): Update.
1353         * thread.c (thr_try_catch_cmd): Update.
1354         * target.c (target_translate_tls_address): Update.
1355         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1356         (info_frame_command_core, frame_apply_command_count): Update.
1357         * rust-exp.y (rust_lex_exception_test): Update.
1358         * riscv-tdep.c (riscv_print_one_register_info): Update.
1359         * remote.c (remote_target::enable_btrace): Update.
1360         * record-btrace.c (record_btrace_enable_warn): Update.
1361         * python/py-utils.c (gdbpy_convert_exception): Update.
1362         * printcmd.c (do_one_display, print_variable_and_value): Update.
1363         * mi/mi-main.c (mi_print_exception): Update.
1364         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1365         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1366         * linux-nat.c (linux_nat_target::attach): Update.
1367         * linux-fork.c (class scoped_switch_fork_info): Update.
1368         * infrun.c (displaced_step_prepare): Update.
1369         * infcall.c (call_function_by_hand_dummy): Update.
1370         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1371         * gnu-v3-abi.c (print_one_vtable): Update.
1372         * frame.c (get_prev_frame_always): Update.
1373         * f-valprint.c (info_common_command_for_block): Update.
1374         * exec.c (try_open_exec_file): Update.
1375         * exceptions.c (print_exception, exception_print)
1376         (exception_fprintf, exception_print_same): Update.
1377         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1378         * dwarf-index-cache.c (index_cache::store)
1379         (index_cache::lookup_gdb_index): Update.
1380         * darwin-nat.c (maybe_cache_shell): Update.
1381         * cp-valprint.c (cp_print_value_fields): Update.
1382         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1383         (gcc_cplus_symbol_address): Update.
1384         * compile/compile-c-symbols.c (gcc_convert_symbol)
1385         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1386         * common/selftest.c: Update.
1387         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1388         a std::string.
1389         (exception_try_scope_entry, exception_try_scope_exit): Don't
1390         declare.
1391         (struct exception_try_scope): Remove.
1392         (TRY): Don't use exception_try_scope.
1393         (struct gdb_exception): Add constructor, operator=.
1394         <what>: New method.
1395         (struct gdb_exception_RETURN_MASK_ALL)
1396         (struct gdb_exception_RETURN_MASK_ERROR)
1397         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1398         (struct gdb_quit_bad_alloc): Update.
1399         * common/common-exceptions.c (exception_none): Change
1400         initializer.
1401         (struct catcher) <state, exception>: Initialize inline.
1402         <prev>: Remove member.
1403         (current_catcher): Remove.
1404         (catchers): New global.
1405         (exceptions_state_mc_init): Simplify.
1406         (catcher_pop): Remove.
1407         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1408         (try_scope_depth, exception_try_scope_entry)
1409         (exception_try_scope_exit): Remove.
1410         (throw_exception_sjlj): Update.
1411         (exception_messages, exception_messages_size): Remove.
1412         (throw_it): Simplify.
1413         (gdb_exception_sliced_copy): Remove.
1414         (throw_exception_cxx): Update.
1415         * cli/cli-script.c (script_from_file): Update.
1416         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1417         Update.
1418         * ada-valprint.c (ada_val_print): Update.
1419         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1420         (create_excep_cond_exprs): Update.
1421
1422 2019-04-08  Tom Tromey  <tom@tromey.com>
1423
1424         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1425         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1426         (TRY, CATCH, END_CATCH): Remove some definitions.
1427         * common/common-exceptions.c: Don't use GDB_XCPT.
1428         (catcher_list_size): Remove.
1429         (throw_exception, throw_it): Simplify.
1430
1431 2019-04-05  Tom Tromey  <tom@tromey.com>
1432
1433         Revert the header-sorting patch.
1434         * ft32-tdep.c: Revert.
1435         * frv-tdep.c: Revert.
1436         * frv-linux-tdep.c: Revert.
1437         * frame.c: Revert.
1438         * frame-unwind.c: Revert.
1439         * frame-base.c: Revert.
1440         * fork-child.c: Revert.
1441         * findvar.c: Revert.
1442         * findcmd.c: Revert.
1443         * filesystem.c: Revert.
1444         * filename-seen-cache.h: Revert.
1445         * filename-seen-cache.c: Revert.
1446         * fbsd-tdep.c: Revert.
1447         * fbsd-nat.h: Revert.
1448         * fbsd-nat.c: Revert.
1449         * f-valprint.c: Revert.
1450         * f-typeprint.c: Revert.
1451         * f-lang.c: Revert.
1452         * extension.h: Revert.
1453         * extension.c: Revert.
1454         * extension-priv.h: Revert.
1455         * expprint.c: Revert.
1456         * exec.h: Revert.
1457         * exec.c: Revert.
1458         * exceptions.c: Revert.
1459         * event-top.c: Revert.
1460         * event-loop.c: Revert.
1461         * eval.c: Revert.
1462         * elfread.c: Revert.
1463         * dwarf2read.h: Revert.
1464         * dwarf2read.c: Revert.
1465         * dwarf2loc.c: Revert.
1466         * dwarf2expr.h: Revert.
1467         * dwarf2expr.c: Revert.
1468         * dwarf2-frame.c: Revert.
1469         * dwarf2-frame-tailcall.c: Revert.
1470         * dwarf-index-write.h: Revert.
1471         * dwarf-index-write.c: Revert.
1472         * dwarf-index-common.c: Revert.
1473         * dwarf-index-cache.h: Revert.
1474         * dwarf-index-cache.c: Revert.
1475         * dummy-frame.c: Revert.
1476         * dtrace-probe.c: Revert.
1477         * disasm.h: Revert.
1478         * disasm.c: Revert.
1479         * disasm-selftests.c: Revert.
1480         * dictionary.c: Revert.
1481         * dicos-tdep.c: Revert.
1482         * demangle.c: Revert.
1483         * dcache.h: Revert.
1484         * dcache.c: Revert.
1485         * darwin-nat.h: Revert.
1486         * darwin-nat.c: Revert.
1487         * darwin-nat-info.c: Revert.
1488         * d-valprint.c: Revert.
1489         * d-namespace.c: Revert.
1490         * d-lang.c: Revert.
1491         * ctf.c: Revert.
1492         * csky-tdep.c: Revert.
1493         * csky-linux-tdep.c: Revert.
1494         * cris-tdep.c: Revert.
1495         * cris-linux-tdep.c: Revert.
1496         * cp-valprint.c: Revert.
1497         * cp-support.c: Revert.
1498         * cp-namespace.c: Revert.
1499         * cp-abi.c: Revert.
1500         * corelow.c: Revert.
1501         * corefile.c: Revert.
1502         * continuations.c: Revert.
1503         * completer.h: Revert.
1504         * completer.c: Revert.
1505         * complaints.c: Revert.
1506         * coffread.c: Revert.
1507         * coff-pe-read.c: Revert.
1508         * cli-out.h: Revert.
1509         * cli-out.c: Revert.
1510         * charset.c: Revert.
1511         * c-varobj.c: Revert.
1512         * c-valprint.c: Revert.
1513         * c-typeprint.c: Revert.
1514         * c-lang.c: Revert.
1515         * buildsym.c: Revert.
1516         * buildsym-legacy.c: Revert.
1517         * build-id.h: Revert.
1518         * build-id.c: Revert.
1519         * btrace.c: Revert.
1520         * bsd-uthread.c: Revert.
1521         * breakpoint.h: Revert.
1522         * breakpoint.c: Revert.
1523         * break-catch-throw.c: Revert.
1524         * break-catch-syscall.c: Revert.
1525         * break-catch-sig.c: Revert.
1526         * blockframe.c: Revert.
1527         * block.c: Revert.
1528         * bfin-tdep.c: Revert.
1529         * bfin-linux-tdep.c: Revert.
1530         * bfd-target.c: Revert.
1531         * bcache.c: Revert.
1532         * ax-general.c: Revert.
1533         * ax-gdb.h: Revert.
1534         * ax-gdb.c: Revert.
1535         * avr-tdep.c: Revert.
1536         * auxv.c: Revert.
1537         * auto-load.c: Revert.
1538         * arm-wince-tdep.c: Revert.
1539         * arm-tdep.c: Revert.
1540         * arm-symbian-tdep.c: Revert.
1541         * arm-pikeos-tdep.c: Revert.
1542         * arm-obsd-tdep.c: Revert.
1543         * arm-nbsd-tdep.c: Revert.
1544         * arm-nbsd-nat.c: Revert.
1545         * arm-linux-tdep.c: Revert.
1546         * arm-linux-nat.c: Revert.
1547         * arm-fbsd-tdep.c: Revert.
1548         * arm-fbsd-nat.c: Revert.
1549         * arm-bsd-tdep.c: Revert.
1550         * arch-utils.c: Revert.
1551         * arc-tdep.c: Revert.
1552         * arc-newlib-tdep.c: Revert.
1553         * annotate.h: Revert.
1554         * annotate.c: Revert.
1555         * amd64-windows-tdep.c: Revert.
1556         * amd64-windows-nat.c: Revert.
1557         * amd64-tdep.c: Revert.
1558         * amd64-sol2-tdep.c: Revert.
1559         * amd64-obsd-tdep.c: Revert.
1560         * amd64-obsd-nat.c: Revert.
1561         * amd64-nbsd-tdep.c: Revert.
1562         * amd64-nbsd-nat.c: Revert.
1563         * amd64-nat.c: Revert.
1564         * amd64-linux-tdep.c: Revert.
1565         * amd64-linux-nat.c: Revert.
1566         * amd64-fbsd-tdep.c: Revert.
1567         * amd64-fbsd-nat.c: Revert.
1568         * amd64-dicos-tdep.c: Revert.
1569         * amd64-darwin-tdep.c: Revert.
1570         * amd64-bsd-nat.c: Revert.
1571         * alpha-tdep.c: Revert.
1572         * alpha-obsd-tdep.c: Revert.
1573         * alpha-nbsd-tdep.c: Revert.
1574         * alpha-mdebug-tdep.c: Revert.
1575         * alpha-linux-tdep.c: Revert.
1576         * alpha-linux-nat.c: Revert.
1577         * alpha-bsd-tdep.c: Revert.
1578         * alpha-bsd-nat.c: Revert.
1579         * aix-thread.c: Revert.
1580         * agent.c: Revert.
1581         * addrmap.c: Revert.
1582         * ada-varobj.c: Revert.
1583         * ada-valprint.c: Revert.
1584         * ada-typeprint.c: Revert.
1585         * ada-tasks.c: Revert.
1586         * ada-lang.c: Revert.
1587         * aarch64-tdep.c: Revert.
1588         * aarch64-ravenscar-thread.c: Revert.
1589         * aarch64-newlib-tdep.c: Revert.
1590         * aarch64-linux-tdep.c: Revert.
1591         * aarch64-linux-nat.c: Revert.
1592         * aarch64-fbsd-tdep.c: Revert.
1593         * aarch64-fbsd-nat.c: Revert.
1594         * aarch32-linux-nat.c: Revert.
1595
1596 2019-04-05  Tom Tromey  <tom@tromey.com>
1597
1598         * ft32-tdep.c: Sort headers.
1599         * frv-tdep.c: Sort headers.
1600         * frv-linux-tdep.c: Sort headers.
1601         * frame.c: Sort headers.
1602         * frame-unwind.c: Sort headers.
1603         * frame-base.c: Sort headers.
1604         * fork-child.c: Sort headers.
1605         * findvar.c: Sort headers.
1606         * findcmd.c: Sort headers.
1607         * filesystem.c: Sort headers.
1608         * filename-seen-cache.h: Sort headers.
1609         * filename-seen-cache.c: Sort headers.
1610         * fbsd-tdep.c: Sort headers.
1611         * fbsd-nat.h: Sort headers.
1612         * fbsd-nat.c: Sort headers.
1613         * f-valprint.c: Sort headers.
1614         * f-typeprint.c: Sort headers.
1615         * f-lang.c: Sort headers.
1616         * extension.h: Sort headers.
1617         * extension.c: Sort headers.
1618         * extension-priv.h: Sort headers.
1619         * expprint.c: Sort headers.
1620         * exec.h: Sort headers.
1621         * exec.c: Sort headers.
1622         * exceptions.c: Sort headers.
1623         * event-top.c: Sort headers.
1624         * event-loop.c: Sort headers.
1625         * eval.c: Sort headers.
1626         * elfread.c: Sort headers.
1627         * dwarf2read.h: Sort headers.
1628         * dwarf2read.c: Sort headers.
1629         * dwarf2loc.c: Sort headers.
1630         * dwarf2expr.h: Sort headers.
1631         * dwarf2expr.c: Sort headers.
1632         * dwarf2-frame.c: Sort headers.
1633         * dwarf2-frame-tailcall.c: Sort headers.
1634         * dwarf-index-write.h: Sort headers.
1635         * dwarf-index-write.c: Sort headers.
1636         * dwarf-index-common.c: Sort headers.
1637         * dwarf-index-cache.h: Sort headers.
1638         * dwarf-index-cache.c: Sort headers.
1639         * dummy-frame.c: Sort headers.
1640         * dtrace-probe.c: Sort headers.
1641         * disasm.h: Sort headers.
1642         * disasm.c: Sort headers.
1643         * disasm-selftests.c: Sort headers.
1644         * dictionary.c: Sort headers.
1645         * dicos-tdep.c: Sort headers.
1646         * demangle.c: Sort headers.
1647         * dcache.h: Sort headers.
1648         * dcache.c: Sort headers.
1649         * darwin-nat.h: Sort headers.
1650         * darwin-nat.c: Sort headers.
1651         * darwin-nat-info.c: Sort headers.
1652         * d-valprint.c: Sort headers.
1653         * d-namespace.c: Sort headers.
1654         * d-lang.c: Sort headers.
1655         * ctf.c: Sort headers.
1656         * csky-tdep.c: Sort headers.
1657         * csky-linux-tdep.c: Sort headers.
1658         * cris-tdep.c: Sort headers.
1659         * cris-linux-tdep.c: Sort headers.
1660         * cp-valprint.c: Sort headers.
1661         * cp-support.c: Sort headers.
1662         * cp-namespace.c: Sort headers.
1663         * cp-abi.c: Sort headers.
1664         * corelow.c: Sort headers.
1665         * corefile.c: Sort headers.
1666         * continuations.c: Sort headers.
1667         * completer.h: Sort headers.
1668         * completer.c: Sort headers.
1669         * complaints.c: Sort headers.
1670         * coffread.c: Sort headers.
1671         * coff-pe-read.c: Sort headers.
1672         * cli-out.h: Sort headers.
1673         * cli-out.c: Sort headers.
1674         * charset.c: Sort headers.
1675         * c-varobj.c: Sort headers.
1676         * c-valprint.c: Sort headers.
1677         * c-typeprint.c: Sort headers.
1678         * c-lang.c: Sort headers.
1679         * buildsym.c: Sort headers.
1680         * buildsym-legacy.c: Sort headers.
1681         * build-id.h: Sort headers.
1682         * build-id.c: Sort headers.
1683         * btrace.c: Sort headers.
1684         * bsd-uthread.c: Sort headers.
1685         * breakpoint.h: Sort headers.
1686         * breakpoint.c: Sort headers.
1687         * break-catch-throw.c: Sort headers.
1688         * break-catch-syscall.c: Sort headers.
1689         * break-catch-sig.c: Sort headers.
1690         * blockframe.c: Sort headers.
1691         * block.c: Sort headers.
1692         * bfin-tdep.c: Sort headers.
1693         * bfin-linux-tdep.c: Sort headers.
1694         * bfd-target.c: Sort headers.
1695         * bcache.c: Sort headers.
1696         * ax-general.c: Sort headers.
1697         * ax-gdb.h: Sort headers.
1698         * ax-gdb.c: Sort headers.
1699         * avr-tdep.c: Sort headers.
1700         * auxv.c: Sort headers.
1701         * auto-load.c: Sort headers.
1702         * arm-wince-tdep.c: Sort headers.
1703         * arm-tdep.c: Sort headers.
1704         * arm-symbian-tdep.c: Sort headers.
1705         * arm-pikeos-tdep.c: Sort headers.
1706         * arm-obsd-tdep.c: Sort headers.
1707         * arm-nbsd-tdep.c: Sort headers.
1708         * arm-nbsd-nat.c: Sort headers.
1709         * arm-linux-tdep.c: Sort headers.
1710         * arm-linux-nat.c: Sort headers.
1711         * arm-fbsd-tdep.c: Sort headers.
1712         * arm-fbsd-nat.c: Sort headers.
1713         * arm-bsd-tdep.c: Sort headers.
1714         * arch-utils.c: Sort headers.
1715         * arc-tdep.c: Sort headers.
1716         * arc-newlib-tdep.c: Sort headers.
1717         * annotate.h: Sort headers.
1718         * annotate.c: Sort headers.
1719         * amd64-windows-tdep.c: Sort headers.
1720         * amd64-windows-nat.c: Sort headers.
1721         * amd64-tdep.c: Sort headers.
1722         * amd64-sol2-tdep.c: Sort headers.
1723         * amd64-obsd-tdep.c: Sort headers.
1724         * amd64-obsd-nat.c: Sort headers.
1725         * amd64-nbsd-tdep.c: Sort headers.
1726         * amd64-nbsd-nat.c: Sort headers.
1727         * amd64-nat.c: Sort headers.
1728         * amd64-linux-tdep.c: Sort headers.
1729         * amd64-linux-nat.c: Sort headers.
1730         * amd64-fbsd-tdep.c: Sort headers.
1731         * amd64-fbsd-nat.c: Sort headers.
1732         * amd64-dicos-tdep.c: Sort headers.
1733         * amd64-darwin-tdep.c: Sort headers.
1734         * amd64-bsd-nat.c: Sort headers.
1735         * alpha-tdep.c: Sort headers.
1736         * alpha-obsd-tdep.c: Sort headers.
1737         * alpha-nbsd-tdep.c: Sort headers.
1738         * alpha-mdebug-tdep.c: Sort headers.
1739         * alpha-linux-tdep.c: Sort headers.
1740         * alpha-linux-nat.c: Sort headers.
1741         * alpha-bsd-tdep.c: Sort headers.
1742         * alpha-bsd-nat.c: Sort headers.
1743         * aix-thread.c: Sort headers.
1744         * agent.c: Sort headers.
1745         * addrmap.c: Sort headers.
1746         * ada-varobj.c: Sort headers.
1747         * ada-valprint.c: Sort headers.
1748         * ada-typeprint.c: Sort headers.
1749         * ada-tasks.c: Sort headers.
1750         * ada-lang.c: Sort headers.
1751         * aarch64-tdep.c: Sort headers.
1752         * aarch64-ravenscar-thread.c: Sort headers.
1753         * aarch64-newlib-tdep.c: Sort headers.
1754         * aarch64-linux-tdep.c: Sort headers.
1755         * aarch64-linux-nat.c: Sort headers.
1756         * aarch64-fbsd-tdep.c: Sort headers.
1757         * aarch64-fbsd-nat.c: Sort headers.
1758         * aarch32-linux-nat.c: Sort headers.
1759
1760 2019-04-04  Tom Tromey  <tom@tromey.com>
1761
1762         * varobj.c (varobj_create): Update.
1763         * rust-exp.y (struct rust_parser) <update_innermost_block,
1764         lookup_symbol>: New methods.
1765         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1766         Rename.
1767         (rust_parser::rust_lookup_type)
1768         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1769         * printcmd.c (display_command, do_one_display): Update.
1770         * parser-defs.h (struct parser_state) <parser_state>: Add
1771         "tracker" parameter.
1772         (block_tracker): New member.
1773         (class innermost_block_tracker) <innermost_block_tracker>: Add
1774         "types" parameter.
1775         <reset>: Remove method.
1776         (innermost_block): Don't declare.
1777         (null_post_parser): Update.
1778         * parse.c (innermost_block): Remove global.
1779         (write_dollar_variable): Update.
1780         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1781         Remove "tracker_types" parameter.
1782         (parse_expression): Add "tracker" parameter.
1783         (parse_expression_for_completion): Update.
1784         (null_post_parser): Add "tracker" parameter.
1785         * p-exp.y: Update rules.
1786         * m2-exp.y: Update rules.
1787         * language.h (struct language_defn) <la_post_parser>: Add
1788         "tracker" parameter.
1789         * go-exp.y: Update rules.
1790         * f-exp.y: Update rules.
1791         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1792         parameter.
1793         * d-exp.y: Update rules.
1794         * c-exp.y: Update rules.
1795         * breakpoint.c (set_breakpoint_condition): Create an
1796         innermost_block_tracker.
1797         (watch_command_1): Likewise.
1798         * ada-lang.c (resolve): Add "tracker" parameter.
1799         (resolve_subexp): Likewise.
1800         * ada-exp.y (write_var_from_sym): Update.
1801
1802 2019-04-04  Tom Tromey  <tom@tromey.com>
1803
1804         * type-stack.h: New file.
1805         * type-stack.c: New file.
1806         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1807         type-stack.h.
1808         (insert_into_type_stack, insert_type, push_type, push_type_int)
1809         (insert_type_address_space, pop_type, pop_type_int)
1810         (pop_typelist, pop_type_stack, append_type_stack)
1811         (push_type_stack, get_type_stack, push_typelist)
1812         (follow_type_instance_flags, follow_types): Don't declare.
1813         * parse.c (type_stack): Remove global.
1814         (parse_exp_in_context): Update.
1815         (insert_into_type_stack, insert_type, push_type, push_type_int)
1816         (insert_type_address_space, pop_type, pop_type_int)
1817         (pop_typelist, pop_type_stack, append_type_stack)
1818         (push_type_stack, get_type_stack, push_typelist)
1819         (follow_type_instance_flags, follow_types): Remove (moved to
1820         type-stack.c).
1821         * f-exp.y (type_stack): New global.
1822         Update rules.
1823         (push_kind_type, f_parse): Update.
1824         * d-exp.y (type_stack): New global.
1825         Update rules.
1826         (d_parse): Update.
1827         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1828         Update rules.
1829         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1830         (HFILES_NO_SRCDIR): Add type-stack.h.
1831
1832 2019-04-04  Tom Tromey  <tom@tromey.com>
1833
1834         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1835         (rust_parser::convert_ast_to_expression, rust_parse)
1836         (rust_lex_test_completion, rust_lex_tests): Update.
1837         * parser-defs.h (struct expr_completion_state): New.
1838         (struct parser_state) <parser_state>: Add completion parameter.
1839         <mark_struct_expression, mark_completion_tag>: New methods.
1840         <parse_completion, m_completion_state>: New members.
1841         (prefixify_expression, null_post_parser): Update.
1842         (mark_struct_expression, mark_completion_tag): Don't declare.
1843         * parse.c (parse_completion, expout_last_struct)
1844         (expout_tag_completion_type, expout_completion_name): Remove
1845         globals.
1846         (parser_state::mark_struct_expression)
1847         (parser_state::mark_completion_tag): Now methods.
1848         (prefixify_expression): Add last_struct parameter.
1849         (prefixify_subexp): Likewise.
1850         (parse_exp_1): Update.
1851         (parse_exp_in_context): Add cstate parameter.  Update.
1852         (parse_expression_for_completion): Create an
1853         expr_completion_state.
1854         (null_post_parser): Add "completion" parameter.
1855         * p-exp.y: Update rules.
1856         (yylex): Update.
1857         * language.h (struct language_defn) <la_post_parser>: Add
1858         "completing" parameter.
1859         * go-exp.y: Update rules.
1860         (lex_one_token): Update.
1861         * expression.h (parse_completion): Don't declare.
1862         * d-exp.y: Update rules.
1863         (lex_one_token): Update rules.
1864         * c-exp.y: Update rules.
1865         (lex_one_token): Update.
1866         * ada-lang.c (resolve): Add "parse_completion" parameter.
1867         (resolve_subexp): Likewise.
1868         (ada_resolve_function): Likewise.
1869
1870 2019-04-04  Tom Tromey  <tom@tromey.com>
1871
1872         * parser-defs.h (struct parser_state) <start_arglist,
1873         end_arglist>: New methods.
1874         <arglist_len, m_funcall_chain>: New members.
1875         (arglist_len, start_arglist, end_arglist): Don't declare.
1876         * parse.c (arglist_len, funcall_chain): Remove global.
1877         (start_arglist, end_arglist): Remove functions.
1878         (parse_exp_in_context): Update.
1879         * p-exp.y: Update rules.
1880         * m2-exp.y: Update rules.
1881         * go-exp.y: Update rules.
1882         * f-exp.y: Update rules.
1883         * d-exp.y: Update rules.
1884         * c-exp.y: Update rules.
1885
1886 2019-04-04  Tom Tromey  <tom@tromey.com>
1887
1888         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1889         lex_operator, push_back>: New methods.
1890         Update all rules.
1891         (rust_parser::lex_hex, lex_escape): Rename and update.
1892         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1893         (rust_parser::lex_operator): Rename and update.
1894         (rust_parser::lex_number, rustyylex, rustyyerror)
1895         (rust_lex_test_init, rust_lex_test_sequence)
1896         (rust_lex_test_push_back, rust_lex_tests): Update.
1897         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1898         parameter.
1899         <lexptr, prev_lexptr>: New members.
1900         (lexptr, prev_lexptr): Don't declare.
1901         * parse.c (lexptr, prev_lexptr): Remove globals.
1902         (parse_exp_in_context): Update.
1903         * p-exp.y (yylex, yyerror): Update.
1904         * m2-exp.y (parse_number, yylex, yyerror): Update.
1905         * go-exp.y (lex_one_token, yyerror): Update.
1906         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1907         * d-exp.y (lex_one_token, yyerror): Update.
1908         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1909         (lex_one_token, yyerror): Update.
1910         * ada-lex.l (YY_INPUT): Update.
1911         (rewind_to_char): Update.
1912         * ada-exp.y (yyerror): Update.
1913
1914 2019-04-04  Tom Tromey  <tom@tromey.com>
1915
1916         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1917         * parser-defs.h (struct parser_state) <parser_state>: Add new
1918         parameter.
1919         <comma_terminates>: New member.
1920         (comma_terminates): Don't declare global.
1921         * parse.c (comma_terminates): Remove global.
1922         (parse_exp_in_context): Update.
1923         * p-exp.y (yylex): Update.
1924         * m2-exp.y (yylex): Update.
1925         * go-exp.y (lex_one_token): Update.
1926         * f-exp.y (yylex): Update.
1927         * d-exp.y (lex_one_token): Update.
1928         * c-exp.y (lex_one_token): Update.
1929         * ada-lex.l: Update.
1930
1931 2019-04-04  Tom Tromey  <tom@tromey.com>
1932
1933         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1934         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1935         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1936         * parser-defs.h (paren_depth): Don't declare.
1937         * parse.c (paren_depth): Remove global.
1938         (parse_exp_in_context): Update.
1939         * p-exp.y (paren_depth): New global.
1940         (pascal_parse): Initialize it.
1941         * m2-exp.y (paren_depth): New global.
1942         (m2_parse): Initialize it.
1943         * go-exp.y (paren_depth): New global.
1944         (go_parse): Initialize it.
1945         * f-exp.y (paren_depth): New global.
1946         (f_parse): Initialize it.
1947         * d-exp.y (paren_depth): New global.
1948         (d_parse): Initialize it.
1949         * c-exp.y (paren_depth): New global.
1950         (c_parse): Initialize it.
1951         * ada-lex.l (paren_depth): New global.
1952         (lexer_init): Initialize it.
1953
1954 2019-04-04  Tom Tromey  <tom@tromey.com>
1955
1956         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1957         (rust_parser::convert_ast_to_type)
1958         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1959         * parser-defs.h (struct parser_state) <parser_state>: Add
1960         parameters.  Initialize new members.
1961         <expression_context_block, expression_context_pc>: New members.
1962         * parse.c (expression_context_block, expression_context_pc):
1963         Remove globals.
1964         (parse_exp_in_context): Update.
1965         * p-exp.y: Update all rules.
1966         (yylex): Update.
1967         * m2-exp.y: Update all rules.
1968         (yylex): Update.
1969         * go-exp.y (yylex): Update.
1970         * f-exp.y (yylex): Update.
1971         * d-exp.y: Update all rules.
1972         (yylex): Update.
1973         * c-exp.y: Update all rules.
1974         (lex_one_token, classify_name, yylex, c_parse): Update.
1975         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1976
1977 2019-04-04  Tom Tromey  <tom@tromey.com>
1978
1979         * gdbarch.h, gdbarch.c: Rebuild.
1980         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1981         * stap-probe.h:
1982         (struct stap_parse_info): Replace "parser_state" with
1983         "expr_builder".
1984         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1985         (parser_state): New class.
1986         * parse.c (expr_builder): Rename.
1987         (expr_builder::release): Rename.
1988         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1989         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1990         (write_exp_elt_longcst, write_exp_elt_floatcst)
1991         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1992         (write_exp_string_vector, write_exp_bitstring)
1993         (write_exp_msymbol, mark_struct_expression)
1994         (write_dollar_variable)
1995         (insert_type_address_space, increase_expout_size): Replace
1996         "parser_state" with "expr_builder".
1997         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1998         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1999         "parser_state" with "expr_builder".
2000
2001 2019-04-04  Tom Tromey  <tom@tromey.com>
2002
2003         * rust-exp.y: Replace "parse_language" with method call.
2004         * p-exp.y:
2005         (yylex): Replace "parse_language" with method call.
2006         * m2-exp.y:
2007         (yylex): Replace "parse_language" with method call.
2008         * go-exp.y (classify_name): Replace "parse_language" with method
2009         call.
2010         * f-exp.y (yylex): Replace "parse_language" with method call.
2011         * d-exp.y (lex_one_token): Replace "parse_language" with method
2012         call.
2013         * c-exp.y:
2014         (lex_one_token, classify_name, yylex): Replace "parse_language"
2015         with method call.
2016         * ada-exp.y (find_primitive_type, type_char)
2017         (type_system_address): Replace "parse_language" with method call.
2018
2019 2019-04-04  Tom Tromey  <tom@tromey.com>
2020
2021         * rust-exp.y: Replace "parse_gdbarch" with method call.
2022         * parse.c (write_dollar_variable, insert_type_address_space):
2023         Replace "parse_gdbarch" with method call.
2024         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2025         call.
2026         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2027         call.
2028         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2029         "parse_gdbarch" with method call.
2030         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2031         with method call.
2032         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2033         "parse_gdbarch" with method call.
2034         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2035         "parse_gdbarch" with method call.
2036         * c-exp.y (parse_type, parse_number, classify_name): Replace
2037         "parse_gdbarch" with method call.
2038         * ada-lex.l: Replace "parse_gdbarch" with method call.
2039         * ada-exp.y (parse_type, find_primitive_type, type_char)
2040         (type_system_address): Replace "parse_gdbarch" with method call.
2041
2042 2019-04-04  Tom Tromey  <tom@tromey.com>
2043
2044         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2045         * stap-probe.c (stap_parse_argument): Update.
2046         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2047         initial_size parameter.
2048         * rust-exp.y (rust_lex_tests): Update.
2049         * parse.c (parser_state): Update.
2050         (parse_exp_in_context): Update.
2051         * parser-defs.h (struct parser_state) <parser_state>: Remove
2052         "initial_size" parameter.
2053
2054 2019-04-04  Tom Tromey  <tom@tromey.com>
2055
2056         * parser-defs.h (increase_expout_size): Don't declare.
2057         * parse.c (increase_expout_size): Now static.
2058
2059 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2060
2061         * gnu-nat.c (gnu_nat_target::wait): Fix
2062         target_waitstatus_to_string call.
2063
2064 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2065
2066         * eval.c (evaluate_subexp_standard): Handle internal functions
2067         during Fortran function call handling.
2068
2069 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2070
2071         * NEWS: Mention new internal functions.
2072         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2073         (read_base_type): Use dwarf2_init_complex_target_type.
2074         * value.c (creal_internal_fn): New function.
2075         (cimag_internal_fn): New function.
2076         (_initialize_values): Register new internal functions.
2077
2078 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2079
2080         * infrun.c (stop_all_threads): If debug_infrun, always
2081         trace the wait status after wait_one, using
2082         target_waitstatus_to_string and target_pid_to_str.
2083         (handle_inferior_event): Replace various trace of
2084         wait status kind by a single trace.
2085         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2086         wait status kind image by target_waitstatus_to_string.
2087         * target/waitstatus.c (target_waitstatus_to_string): Fix
2088         obsolete comment.
2089
2090 2019-04-01  Tom Tromey  <tromey@adacore.com>
2091
2092         PR symtab/23331:
2093         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2094
2095 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2096             Pedro Alves  <palves@redhat.com>
2097
2098         * top.c (quit_force): Call 'finalize_values'.
2099         * value.c (finalize_values): New function.
2100         * value.h (finalize_values): Declare.
2101
2102 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2103
2104         * NEWS: Announce $_gdb_major and $_gdb_minor.
2105
2106         * top.c (init_gdb_version_vars): New function.
2107         (gdb_init): Call init_gdb_version_vars.
2108
2109 2019-03-29  Tom Tromey  <tromey@adacore.com>
2110
2111         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2112         help text.  Remove dead code.
2113
2114 2019-03-29  Keith Seitz  <keiths@redhat.com>
2115
2116         From Siddhesh Poyarekar:
2117         * f-lang.h (f77_get_upperbound): Return LONGEST.
2118         (f77_get_lowerbound): Likewise.
2119         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2120         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2121         print them.
2122         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2123         plongest to format print it.
2124         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2125         (f77_get_upperbound): Likewise.
2126         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2127         LOWER_BOUND to LONGEST.
2128         (f77_create_arrayprint_offset_tbl): Likewise.
2129
2130 2019-03-29  Keith Seitz  <keiths@redhat.com>
2131
2132         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2133         %s/pulongest for TYPE_LENGTH instead of %d in format
2134         strings.
2135         * ada-typerint.c (ada_print_type): Likewise.
2136         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2137         * compile/compile-c-support.c (generate_register_struct): Likewise.
2138         * gdbtypes.c (recursive_dump_type): Likewise.
2139         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2140         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2141         instead of %d in format strings.
2142         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2143         to std::min to ULONGEST.
2144         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2145         instead of %d in format strings.
2146         * tracepoint.c (info_scope_command): Likewise.
2147         * typeprint.c (print_offset_data::update)
2148         (print_offset_data::finish): Likewise.
2149         * xtensa-tdep.c (xtensa_store_return_value)
2150         (xtensa_push_dummy_call): Likewise.
2151
2152 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2153
2154         * windows-nat.c (display_selector): Fixed format specifications
2155         for 64-bit Cygwin.
2156
2157 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2158
2159         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2160
2161 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2162
2163         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2164         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2165         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2166         (nios2_linux_init_abi): Install it.
2167
2168 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2169
2170         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2171
2172 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2173
2174         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2175
2176 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2177             Tom Tromey  <tromey@adacore.com>
2178
2179         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2180
2181 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2182
2183         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2184         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2185         method to compute the bounds of range types. Also print "[evaluated]"
2186         if the bounds' values come from a dynamic evaluation.
2187
2188 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2189
2190         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2191         whitespace when pretty printing is on.
2192
2193 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2194
2195         * ppc-linux-nat.c: Add include.
2196
2197 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2198
2199         * NEWS: Mention AArch64 Pointer Authentication.
2200
2201 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2202
2203         * arm-linux-nat.c: Add include.
2204
2205 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2206
2207         * source-cache.c (source_cache::get_source_lines): Re-read
2208         fullname after calling open_source_file.
2209
2210 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2211
2212         * NEWS: Mention TLS support for FreeBSD.
2213
2214 2019-03-25  Tom Tromey  <tromey@adacore.com>
2215
2216         * minsyms.c (BUNCH_SIZE): Update comment.
2217         (~minimal_symbol_reader): Remove old comment.
2218         (compact_minimal_symbols): Update comment.
2219         (minimal_symbol_reader::install): Remove old comment.  Update
2220         other comments.
2221
2222 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2223
2224         * s390-linux-nat.c: Add include.
2225
2226 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2227
2228         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2229         Call linux_get_hwcap.
2230         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2231         Likewise.
2232         (aarch64_linux_get_hwcap): Remove function.
2233         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2234         declaration.
2235         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2236         linux_get_hwcap.
2237         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2238         * linux-tdep.c (linux_get_hwcap): Add function.
2239         (linux_get_hwcap2): Likewise.
2240         * linux-tdep.h (linux_get_hwcap): Add declaration.
2241         (linux_get_hwcap2): Likewise.
2242         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2243         (ppc_linux_get_hwcap2): Likewise.
2244         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2245         linux_get_hwcap.
2246         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2247         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2248         (ppc_linux_nat_target::read_description): Likewise.
2249         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2250         * s390-linux-nat.c: Likewise.
2251         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2252
2253 2019-03-24  Tom Tromey  <tom@tromey.com>
2254
2255         * ada-lang.c (standard_lookup): Simplify initialization.
2256         (ada_lookup_symbol_nonlocal): Simplify return.
2257         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2258         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2259         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2260         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2261         initialization.
2262         * solib.c (solib_global_lookup): Simplify.
2263         * symtab.c (null_block_symbol): Remove.
2264         (symbol_cache_lookup): Simplify returns.
2265         (lookup_language_this): Simplify returns.
2266         (lookup_symbol_aux): Simplify return.
2267         (lookup_local_symbol): Simplify returns.
2268         (lookup_global_symbol_from_objfile): Simplify return.
2269         (lookup_symbol_in_objfile_symtabs)
2270         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2271         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2272         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2273         * cp-namespace.c (cp_lookup_bare_symbol)
2274         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2275         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2276         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2277         (cp_lookup_symbol_via_imports): Simplify initialization.
2278         (find_symbol_in_baseclass): Likewise.
2279         * symtab.h (null_block_symbol): Remove.
2280         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2281         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2282         (d_lookup_symbol_module): Likewise.
2283         (find_symbol_in_baseclass): Simplify initialization.
2284
2285 2019-03-24  Tom Tromey  <tom@tromey.com>
2286
2287         * expression.h: Don't include symtab.h.
2288         (struct block): Forward declare.
2289
2290 2019-03-24  Tom Tromey  <tom@tromey.com>
2291
2292         * c-exp.y (typebase): Remove casts.
2293         * gdbtypes.c (lookup_unsigned_typename, )
2294         (lookup_signed_typename): Remove cast.
2295         * eval.c (parse_to_comma_and_eval): Remove cast.
2296         * parse.c (write_dollar_variable): Remove cast.
2297         * block.h (struct block) <superblock>: Now const.
2298         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2299         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2300         (map_block): Make "block" const.
2301         * symfile.h (struct quick_symbol_functions)
2302         <map_matching_symbols>: Constify block argument to "callback".
2303         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2304         const.
2305         (find_pc_sect_compunit_symtab): Make "b" const.
2306         (find_symbol_at_address): Likewise.
2307         (search_symbols): Likewise.
2308         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2309         (dw2_debug_names_lookup_symbol): Likewise.
2310         (dw2_map_matching_symbols): Update.
2311         * p-valprint.c (pascal_val_print): Remove "block".
2312         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2313         (aux_add_nonlocal_symbols): Make "block" const.
2314         (resolve_subexp): Remove cast.
2315         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2316         const.
2317         (iterate_over_file_blocks): Likewise.
2318         * f-exp.y (%union) <bval>: Remove.
2319         * coffread.c (patch_opaque_types): Make "b" const.
2320         * spu-tdep.c (spu_catch_start): Make "block" const.
2321         * c-valprint.c (print_unpacked_pointer): Remove "block".
2322         * symmisc.c (dump_symtab_1): Make "b" const.
2323         (block_depth): Make "block" const.
2324         * d-exp.y (%union) <bval>: Remove.
2325         * cp-support.h (cp_lookup_rtti_type): Update.
2326         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2327         * psymtab.c (psym_lookup_symbol): Make "block" const.
2328         (maintenance_check_psymtabs): Make "b" const.
2329         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2330         (enumerate_locals, enumerate_args): Update.
2331         * python/py-symtab.c (stpy_global_block): Make "block" const.
2332         (stpy_static_block): Likewise.
2333         * inline-frame.c (block_starting_point_at): Make "new_block"
2334         const.
2335         * block.c (find_block_in_blockvector): Make return type const.
2336         (blockvector_for_pc_sect): Make "b" const.
2337         (find_block_in_blockvector): Make "b" const.
2338
2339 2019-03-23  Tom Tromey  <tom@tromey.com>
2340
2341         * varobj.c (varobj_create): Update.
2342         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2343         * printcmd.c (display_command, do_one_display): Don't reset
2344         innermost_block.
2345         * parser-defs.h (enum innermost_block_tracker_type): Move to
2346         expression.h.
2347         (innermost_block): Update comment.
2348         * parse.c (parse_exp_1): Add tracker_types parameter.
2349         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2350         tracker_types parameter.  Reset innermost_block.
2351         (parse_exp_in_context): Remove.
2352         (parse_expression_for_completion): Update.
2353         * objfiles.c (~objfile): Don't reset expression_context_block or
2354         innermost_block.
2355         * expression.h (enum innermost_block_tracker_type): Move from
2356         parser-defs.h.
2357         (parse_exp_1): Add tracker_types parameter.
2358         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2359         reset innermost_block.
2360
2361 2019-03-23  Tom Tromey  <tom@tromey.com>
2362
2363         * objfiles.h: Include bcache.h.
2364
2365 2019-03-23  Tom Tromey  <tom@tromey.com>
2366
2367         * linespec.c (get_current_search_block): Use
2368         scoped_restore_current_language.
2369         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2370
2371 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2372             Jiong Wang  <jiong.wang@arm.com>
2373
2374         * aarch64-linux-tdep.c
2375         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2376         section.
2377         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2378
2379 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2380             Jiong Wang  <jiong.wang@arm.com>
2381
2382         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2383         instructions.
2384         (aarch64_analyze_prologue_test): Add PACIASP test.
2385         (aarch64_prologue_prev_register): Unmask PC value.
2386
2387 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2388             Jiong Wang  <jiong.wang@arm.com>
2389
2390         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2391         (aarch64_dwarf2_prev_register): Unmask PC value.
2392         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2393         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2394         DW_CFA_AARCH64_negate_ra_state.
2395         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2396
2397 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2398             Jiong Wang  <jiong.wang@arm.com>
2399
2400         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2401         registers.
2402         (aarch64_pseudo_register_name): Likewise.
2403         (aarch64_pseudo_register_type): Likewise.
2404         (aarch64_pseudo_register_reggroup_p): Likewise.
2405         (aarch64_gdbarch_init): Add pauth registers.
2406         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2407         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2408         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2409         (struct gdbarch_tdep): Add regnum for ra_state.
2410
2411 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2412             Jiong Wang  <jiong.wang@arm.com>
2413
2414         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2415
2416 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2417             Jiong Wang  <jiong.wang@arm.com>
2418
2419         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2420         function.
2421         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2422         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2423         (aarch64_gdbarch_init): Add puth registers.
2424         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2425         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2426         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2427
2428 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2429             Jiong Wang  <jiong.wang@arm.com>
2430
2431         * aarch64-linux-nat.c
2432         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2433         * aarch64-linux-tdep.c
2434         (aarch64_linux_core_read_description): Likewise.
2435         (aarch64_linux_get_hwcap): New function.
2436         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2437         (aarch64_linux_get_hwcap): New declaration.
2438
2439 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2440             Jiong Wang  <jiong.wang@arm.com>
2441
2442         * aarch64-linux-nat.c
2443         (aarch64_linux_nat_target::read_description): Add pauth param.
2444         * aarch64-linux-tdep.c
2445         (aarch64_linux_core_read_description): Likewise.
2446         * aarch64-tdep.c (struct target_desc): Add in pauth.
2447         (aarch64_read_description): Add pauth param.
2448         (aarch64_gdbarch_init): Likewise.
2449         * aarch64-tdep.h (aarch64_read_description): Likewise.
2450         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2451         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2452         * features/Makefile: Add new files.
2453         * features/aarch64-pauth.c: New file.
2454         * features/aarch64-pauth.xml: New file.
2455
2456 2019-03-20  Tom Tromey  <tromey@adacore.com>
2457
2458         * infrun.c (handle_inferior_event): Rename from
2459         handle_inferior_event_1.  Create a scoped_value_mark.
2460         (handle_inferior_event): Remove.
2461
2462 2019-03-19  Tom Tromey  <tromey@adacore.com>
2463
2464         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2465         * infrun.h (print_stop_event): Add "displays" parameter.
2466         * infrun.c (print_stop_event): Add "displays" parameter.
2467
2468 2019-03-19  Pedro Alves  <palves@redhat.com>
2469
2470         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2471         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2472         to -1.  Fix TABs vs spaces.
2473         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2474         * tui/tui-out.h (tui_ui_out) Add intro comments.
2475         <m_line, m_start_of_line>: In-class initialize, and add describing
2476         comment.
2477
2478 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2479
2480         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2481         variable names.
2482         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2483
2484 2019-03-18  Pedro Alves  <palves@redhat.com>
2485             Eli Zaretskii <eliz@gnu.org>
2486
2487         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2488         m_line and m_start_of_line.
2489
2490 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2491
2492         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2493         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2494         it returns a newline.  This fixes a regression in TU mode, whereby
2495         the next line is output on the same screen line as the user input.
2496
2497 2019-03-18  Tom Tromey  <tromey@adacore.com>
2498
2499         * minsyms.c (minimal_symbol_reader::install): Remove call to
2500         obstack_blank.
2501
2502 2019-03-18  Pedro Alves  <palves@redhat.com>
2503
2504         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2505         New globals.
2506         (apply_style): New, factored out from ...
2507         (apply_ansi_escape): ... this.  Handle reverse video mode.
2508         (tui_set_reverse_mode): New function.
2509         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2510         * tui/tui-winsource.c (tui_show_source_line): Use
2511         tui_set_reverse_mode instead of setting A_STANDOUT.
2512         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2513         New setter methods.
2514
2515 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2516
2517         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2518         Handle tabs.
2519
2520 2019-03-18  Tom Tromey  <tromey@adacore.com>
2521
2522         * ada-lang.c (empty_array): Add "high" parameter.
2523         (ada_evaluate_subexp): Update.
2524
2525 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2526
2527         * unittests/string_view-selftests.c: Define
2528         _initialize_string_view_selftests unconditionally.
2529
2530 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2531
2532         PR gdb/24350
2533         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2534
2535 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2536
2537         PR gdb/24351
2538         * windows-nat.c (display_selector): Fix format specifiers.
2539
2540 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2541
2542         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2543         tui_refill_source_window instead of tui_refresh_win, to update the
2544         current execution line.  This fixes redisplay of the current line
2545         when stepping through the code with "next" or "step".
2546
2547 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2548
2549         * source-cache.c (source_cache::get_source_lines): Call
2550         find_source_lines to initialize s->nlines.  This fixes vertical
2551         scrolling of TUI source window when the DOWN arrow is pressed.
2552
2553 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2554
2555         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2556         linux-thread-db.c (_initialize_thread_db): Likewise.
2557
2558 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2559
2560         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2561         wclrtoeol in tui_show_source_line".  This reverts changes made in
2562         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2563
2564 2019-03-15  Tom Tromey  <tom@tromey.com>
2565
2566         * symtab.h (struct minimal_symbol): Derive from
2567         general_symbol_info.
2568         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2569         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2570         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2571         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2572         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2573         (MSYMBOL_SEARCH_NAME): Update.
2574         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2575         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2576         * minsyms.c (minimal_symbol_reader::record_full): Update.
2577
2578 2019-03-15  Tom Tromey  <tom@tromey.com>
2579
2580         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2581
2582 2019-03-15  Tom Tromey  <tom@tromey.com>
2583
2584         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2585         unique_xmalloc_ptr.
2586         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2587         Update.
2588         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2589         (build_minimal_symbol_hash_tables)
2590         (minimal_symbol_reader::install): Update.
2591
2592 2019-03-15  Tom Tromey  <tom@tromey.com>
2593
2594         * symtab.c (create_demangled_names_hash): Update.
2595         (symbol_set_names): Update.
2596         * objfiles.h (struct objfile_per_bfd_storage)
2597         <demangled_names_hash>: Now an htab_up.
2598         * objfiles.c (objfile_per_bfd_storage): Simplify.
2599
2600 2019-03-15  Tom Tromey  <tom@tromey.com>
2601
2602         * objfiles.h (struct objfile_per_bfd_storage): Declare
2603         destructor.
2604         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2605         New.
2606         (get_objfile_bfd_data): Use new.  Don't initialize
2607         language_of_main.
2608         (free_objfile_per_bfd_storage): Remove.
2609         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2610
2611 2019-03-15  Tom Tromey  <tom@tromey.com>
2612
2613         * symfile.c (reread_symbols): Update.
2614         * objfiles.c (objfile::objfile): Update.
2615         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2616         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2617         comment.
2618         (minimal_symbol_reader::install): Update.
2619         (terminate_minimal_symbol_table): Remove.
2620         * jit.c (jit_object_close_impl): Update.
2621
2622 2019-03-15  Tom Tromey  <tom@tromey.com>
2623
2624         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2625         initializations.
2626
2627 2019-03-15  Tom Tromey  <tom@tromey.com>
2628
2629         * objfiles.h (struct objfile_per_bfd_storage)
2630         <demangled_hash_languages>: Now a bitset.
2631         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2632         (lookup_minimal_symbol): Update.
2633
2634 2019-03-15  Tom Tromey  <tom@tromey.com>
2635
2636         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2637         Don't return the symbol.
2638         * coffread.c (record_minimal_symbol): Use record_full.
2639
2640 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2641
2642         The MS-Windows port of ncurses fails to switch to a color pair if
2643         one or both of the colors are the implicit default colors.  This
2644         change records the default colors when TUI is initialized, and
2645         then specifies them explicitly when a color pair uses the default
2646         colors.  This allows color styling in TUI mode on MS-Windows.
2647
2648         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2649         ncurses_norm_attr.
2650         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2651         colors in ncurses_norm_attr.
2652         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2653         "none", replace it with the default color recorded in
2654         ncurses_norm_attr.
2655
2656 2019-03-14  Tom Tromey  <tromey@adacore.com>
2657
2658         * source-cache.h (class source_cache) <get_source_lines>: Return
2659         std::string.
2660         * source-cache.c (source_cache::extract_lines): Handle case where
2661         first_pos==npos.  Return std::string.
2662         (source_cache::get_source_lines): Update.
2663
2664 2019-03-14  Tom Tromey  <tromey@adacore.com>
2665
2666         * NEWS: Add item for "style sources" commands.
2667         * source-cache.c (source_cache::get_source_lines): Check
2668         source_styling.
2669         * cli/cli-style.c (source_styling): New global.
2670         (_initialize_cli_style): Add "style sources" commands.
2671         (show_style_sources): New function.
2672         * cli/cli-style.h (source_styling): Declare.
2673
2674 2019-03-14  Pedro Alves  <palves@redhat.com>
2675             Tom Tromey  <tromey@adacore.com>
2676
2677         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2678         * tui/tui-winsource.c (tui_refill_source_window): New function,
2679         from...
2680         (tui_horizontal_source_scroll): ... here.  Move some logic.
2681         * cli/cli-style.c (set_style_enabled): Notify new observable.
2682         * tui/tui-hooks.c (tui_redisplay_source): New function.
2683         (tui_attach_detach_observers): Attach or detach
2684         tui_redisplay_source.
2685         * observable.h (source_styling_changed): New observable.
2686         * observable.c: Define source_styling_changed observable.
2687
2688 2019-03-13  Tom Tromey  <tromey@adacore.com>
2689
2690         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2691         (i386_gnu_nat_target::store_registers): Update.
2692         * target-debug.h (target_debug_print_std_string): New macro.
2693         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2694         * windows-tdep.c (display_one_tib): Update.
2695         * tui/tui-stack.c (tui_make_status_line): Update.
2696         * top.c (print_inferior_quit_action): Update.
2697         * thread.c (thr_try_catch_cmd): Update.
2698         (add_thread_with_info): Update.
2699         (thread_target_id_str): Update.
2700         (thr_try_catch_cmd): Update.
2701         (thread_command): Update.
2702         (thread_find_command): Update.
2703         * record-btrace.c (record_btrace_target::info_record)
2704         (record_btrace_resume_thread, record_btrace_target::resume)
2705         (record_btrace_cancel_resume, record_btrace_step_thread)
2706         (record_btrace_target::wait, record_btrace_target::wait)
2707         (record_btrace_target::wait, record_btrace_target::stop): Update.
2708         * progspace.c (print_program_space): Update.
2709         * process-stratum-target.c
2710         (process_stratum_target::thread_address_space): Update.
2711         * linux-fork.c (linux_fork_mourn_inferior)
2712         (detach_checkpoint_command, info_checkpoints_command)
2713         (linux_fork_context): Update.
2714         (linux_fork_detach): Update.
2715         (class scoped_switch_fork_info): Update.
2716         (delete_checkpoint_command): Update.
2717         * infrun.c (follow_fork_inferior): Update.
2718         (follow_fork_inferior): Update.
2719         (proceed_after_vfork_done): Update.
2720         (handle_vfork_child_exec_or_exit): Update.
2721         (follow_exec): Update.
2722         (displaced_step_prepare_throw): Update.
2723         (displaced_step_restore): Update.
2724         (start_step_over): Update.
2725         (resume_1): Update.
2726         (clear_proceed_status_thread): Update.
2727         (proceed): Update.
2728         (print_target_wait_results): Update.
2729         (do_target_wait): Update.
2730         (context_switch): Update.
2731         (stop_all_threads): Update.
2732         (restart_threads): Update.
2733         (finish_step_over): Update.
2734         (handle_signal_stop): Update.
2735         (switch_back_to_stepped_thread): Update.
2736         (keep_going_pass_signal): Update.
2737         (print_exited_reason): Update.
2738         (normal_stop): Update.
2739         * inferior.c (inferior_pid_to_str): Change return type.
2740         (print_selected_inferior): Update.
2741         (add_inferior): Update.
2742         (detach_inferior): Update.
2743         * dummy-frame.c (fprint_dummy_frames): Update.
2744         * dcache.c (dcache_info_1): Update.
2745         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2746         (btrace_fetch, btrace_clear): Update.
2747         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2748         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2749         type.
2750         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2751         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2752         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2753         * gdbarch.c, gdbarch.h: Rebuild.
2754         * gdbarch.sh (core_pid_to_str): Change return type.
2755         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2756         return type.
2757         (windows_nat_target::pid_to_str): Change return type.
2758         (windows_delete_thread): Update.
2759         (windows_nat_target::attach): Update.
2760         (windows_nat_target::files_info): Update.
2761         * target-delegates.c: Rebuild.
2762         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2763         return type.
2764         (sol_thread_target::pid_to_str): Change return type.
2765         * remote.c (class remote_target) <pid_to_str>: Change return
2766         type.
2767         (remote_target::pid_to_str): Change return type.
2768         (extended_remote_target::attach, remote_target::remote_stop_ns)
2769         (remote_target::remote_notif_remove_queued_reply)
2770         (remote_target::push_stop_reply, remote_target::disable_btrace):
2771         Update.
2772         (extended_remote_target::attach): Update.
2773         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2774         type.
2775         (gdbsim_target::pid_to_str): Change return type.
2776         * ravenscar-thread.c (struct ravenscar_thread_target)
2777         <pid_to_str>: Change return type.
2778         (ravenscar_thread_target::pid_to_str): Change return type.
2779         * procfs.c (class procfs_target) <pid_to_str>: Change return
2780         type.
2781         (procfs_target::pid_to_str): Change return type.
2782         (procfs_target::attach): Update.
2783         (procfs_target::detach): Update.
2784         (procfs_target::fetch_registers): Update.
2785         (procfs_target::store_registers): Update.
2786         (procfs_target::wait): Update.
2787         (procfs_target::files_info): Update.
2788         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2789         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2790         return type.
2791         (nto_procfs_target::pid_to_str): Change return type.
2792         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2793         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2794         return type.
2795         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2796         (exit_lwp): Update.
2797         (attach_proc_task_lwp_callback, get_detach_signal)
2798         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2799         (linux_nat_target::resume, wait_lwp, stop_callback)
2800         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2801         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2802         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2803         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2804         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2805         type.
2806         (inf_ptrace_target::attach): Update.
2807         (inf_ptrace_target::files_info): Update.
2808         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2809         type.
2810         (go32_nat_target::pid_to_str): Change return type.
2811         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2812         (gnu_nat_target::wait): Update.
2813         (gnu_nat_target::wait): Update.
2814         (gnu_nat_target::resume): Update.
2815         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2816         (fbsd_nat_target::wait): Update.
2817         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2818         type.
2819         (darwin_nat_target::attach): Update.
2820         * corelow.c (class core_target) <pid_to_str>: Change return type.
2821         (core_target::pid_to_str): Change return type.
2822         * target.c (normal_pid_to_str): Change return type.
2823         (default_pid_to_str): Likewise.
2824         (target_pid_to_str): Change return type.
2825         (target_translate_tls_address): Update.
2826         (target_announce_detach): Update.
2827         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2828         return type.
2829         (bsd_uthread_target::pid_to_str): Change return type.
2830         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2831         type.
2832         (bsd_kvm_target::pid_to_str): Change return type.
2833         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2834         return type.
2835         (aix_thread_target::pid_to_str): Change return type.
2836         * target.h (struct target_ops) <pid_to_str>: Change return type.
2837         (target_pid_to_str, normal_pid_to_str): Likewise.
2838         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2839         type.
2840         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2841         type.
2842         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2843         return type.
2844         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2845         type.
2846         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2847         type.
2848         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2849         return type.
2850
2851 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2852
2853         * NEWS: Mention that the new default MI version is 3.  Mention
2854         changes to the output of commands and events that deal with
2855         multi-location breakpoints.
2856         * breakpoint.c: Include "mi/mi-out.h".
2857         (print_one_breakpoint): Change output syntax if using MI version
2858         >= 3.
2859         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2860         New.
2861         (mi_multi_location_breakpoint_output_fixed): New.
2862         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2863         (mi_cmd_fix_multi_location_breakpoint_output): New.
2864         (mi_multi_location_breakpoint_output_fixed): New.
2865         * mi/mi-cmds.c (mi_cmds): Register command
2866         -fix-multi-location-breakpoint-output.
2867         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2868         interpreter "mi".
2869
2870 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2871
2872         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2873         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2874         instantiate mi_ui_out based on interpreter name.
2875         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2876         * mi/mi-main.c (mi_load_progress): Likewise.
2877
2878 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2879
2880         * NEWS: Combine separate "New targets" sections for 8.3.
2881
2882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2883
2884         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2885         (ppcfbsd_init_abi): Install gdbarch
2886         "fetch_tls_load_module_address" and "get_thread_local_address"
2887         methods.
2888
2889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2890
2891         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2892         (riscv_fbsd_init_abi): Install gdbarch
2893         "fetch_tls_load_module_address" and "get_thread_local_address"
2894         methods.
2895
2896 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2897
2898         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2899         (i386fbsd_init_abi): Install gdbarch
2900         "fetch_tls_load_module_address" and "get_thread_local_address"
2901         methods.
2902
2903 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2904
2905         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2906         (amd64fbsd_init_abi): Install gdbarch
2907         "fetch_tls_load_module_address" and "get_thread_local_address"
2908         methods.
2909
2910 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2911
2912         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2913         (struct fbsd_pspace_data): New type.
2914         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2915         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2916         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2917         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2918         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2919
2920 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2921
2922         * gdbtypes.c (lookup_struct_elt): New function.
2923         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2924         * gdbtypes.h (struct struct_elt): New type.
2925         (lookup_struct_elt): New prototype.
2926
2927 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2928
2929         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2930         remove disabled code block.
2931
2932 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2933
2934         * gdbarch.sh (get_thread_local_address): New method.
2935         * gdbarch.h, gdbarch.c: Regenerate.
2936         * target.c (target_translate_tls_address): Use
2937         gdbarch_get_thread_local_address if present instead of
2938         target::get_thread_local_address.
2939
2940 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2941
2942         * target.h (target::get_thread_local_address): Update comment.
2943
2944 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2945
2946         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2947         objfile->separate_debug_objfile_backlink if not NULL.
2948
2949 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2950
2951         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2952         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2953         (amd64bsd_store_inferior_registers): Likewise.
2954         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2955         Enable segment base registers.
2956         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2957         PT_GETFSBASE and PT_GETGSBASE.
2958         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2959         PT_SETGSBASE.
2960         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2961         segment base registers.
2962         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2963
2964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2965
2966         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2967         Update calls to i386_target_description to add 'segments'
2968         parameter.
2969         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2970         add segment base registers.
2971         * arch/i386.c (i386_create_target_description): Add 'segments'
2972         parameter to enable segment base registers.
2973         * arch/i386.h (i386_create_target_description): Likewise.
2974         * features/i386/32bit-segments.xml: New file.
2975         * features/i386/32bit-segments.c: Generate.
2976         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2977         call to i386_target_description to add 'segments' parameter.
2978         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2979         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2980         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2981         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2982         if feature is present.
2983         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2984         Add 'segments' parameter to call to i386_target_description.
2985         (i386_target_description): Add 'segments' parameter to enable
2986         segment base registers.
2987         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2988         to call to i386_target_description.
2989         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2990         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2991         Define I386_NUM_REGS.
2992         (i386_target_description): Add 'segments' parameter to enable
2993         segment base registers.
2994
2995 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2996
2997         PR/24325
2998         * source-cache.c: #undef open and close, to avoid unresolved
2999         externals during linking.
3000
3001 2019-03-12  Tom Tromey  <tromey@adacore.com>
3002
3003         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3004         const.  Add initializers.
3005         (_initialize_remote): Don't initialize ptid globals.
3006
3007 2019-03-12  Pedro Alves  <palves@redhat.com>
3008
3009         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3010
3011 2019-03-12  Pedro Alves  <palves@redhat.com>
3012
3013         * cp-name-parser.y (main): Remove unused 'len' variable.
3014
3015 2019-03-12  Tom Tromey  <tromey@adacore.com>
3016
3017         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3018         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3019
3020 2019-03-12  Tom Tromey  <tromey@adacore.com>
3021
3022         * linux-nat.c (iterate_over_lwps): Update.
3023         (stop_callback): Remove parameter.
3024         (stop_wait_callback, detach_callback, resume_set_callback)
3025         (select_singlestep_lwp_callback, set_ignore_sigint)
3026         (status_callback, resumed_callback, resume_clear_callback)
3027         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3028         data parameter.
3029         (linux_nat_target::detach, linux_nat_target::resume)
3030         (linux_stop_and_wait_all_lwps, select_event_lwp)
3031         (linux_nat_filter_event, linux_nat_wait_1)
3032         (linux_nat_target::kill, linux_nat_target::stop)
3033         (linux_nat_target::stop): Update.
3034         (linux_nat_resume_callback): Change type.
3035         (resume_stopped_resumed_lwps, count_events_callback)
3036         (select_event_lwp_callback): Likewise.
3037         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3038         * arm-linux-nat.c (struct update_registers_data): Remove.
3039         (update_registers_callback): Change type.
3040         (arm_linux_insert_hw_breakpoint1): Update.
3041         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3042         parameter.
3043         (x86_linux_dr_set_addr): Update.
3044         (x86_linux_dr_set_control): Update.
3045         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3046         (iterate_over_lwps): Use gdb::function_view.
3047         * nat/aarch64-linux-hw-point.c (struct
3048         aarch64_dr_update_callback_param): Remove.
3049         (debug_reg_change_callback): Change type.
3050         (aarch64_notify_debug_reg_change): Update.
3051         * s390-linux-nat.c (s390_refresh_per_info): Update.
3052
3053 2019-03-11  Tom Tromey  <tromey@adacore.com>
3054
3055         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3056         redundant assignment to "this_cu".
3057
3058 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3059
3060         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3061
3062 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3063
3064         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3065         from...
3066         (rank_one_type): ... this.
3067
3068 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3069
3070         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3071         from...
3072         (rank_one_type): ... this.
3073
3074 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3075
3076         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3077         from...
3078         (rank_one_type): ... this.
3079
3080 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3081
3082         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3083         from...
3084         (rank_one_type): ... this.
3085
3086 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3087
3088         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3089         from...
3090         (rank_one_type): ... this.
3091
3092 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3093
3094         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3095         from...
3096         (rank_one_type): ... this.
3097
3098 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3099
3100         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3101         from...
3102         (rank_one_type): ... this.
3103
3104 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3105
3106         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3107         from...
3108         (rank_one_type): ... this.
3109
3110 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3111
3112         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3113         from...
3114         (rank_one_type): ... this.
3115
3116 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3117
3118         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3119         from...
3120         (rank_one_type): ... this.
3121
3122 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3123
3124         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3125         from...
3126         (rank_one_type): ... this.
3127
3128 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3129
3130         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3131         from...
3132         (rank_one_type): ... this.
3133
3134 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3135
3136         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3137         inferior-events' shows the example events.
3138
3139 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3140
3141         Support styling on native MS-Windows console
3142
3143         PR/24315
3144         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3145         on MS-Windows if $TERM is not defined.
3146
3147         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3148
3149         * posix-hdep.c (gdb_console_fputs):
3150         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3151         functions.
3152         * ui-file.h (gdb_console_fputs): Add prototype.
3153
3154         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3155         back to fputs only if the former returns zero.
3156
3157 2019-03-07  Tom Tromey  <tom@tromey.com>
3158
3159         * symmisc.c (print_symbol_bcache_statistics): Update.
3160         (print_objfile_statistics): Update.
3161         * symfile.c (allocate_symtab): Update.
3162         * stabsread.c: Don't include bcache.h.
3163         * psymtab.h (struct psymbol_bcache): Don't declare.
3164         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3165         (psymbol_bcache_init, psymbol_bcache_free)
3166         (psymbol_bcache_get_bcache): Don't declare.
3167         * psymtab.c (struct psymbol_bcache): Remove.
3168         (psymtab_storage::psymtab_storage): Update.
3169         (psymtab_storage::~psymtab_storage): Update.
3170         (psymbol_bcache_init, psymbol_bcache_free)
3171         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3172         (add_psymbol_to_bcache): Update.
3173         (allocate_psymtab): Update.
3174         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3175         macro_cache>: No longer pointers.
3176         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3177         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3178         * macrotab.c (macro_bcache): Update.
3179         * macroexp.c: Don't include bcache.h.
3180         * gdbtypes.c (check_types_worklist): Update.
3181         (types_deeply_equal): Remove TRY/CATCH.  Update.
3182         * elfread.c (elf_symtab_read): Update.
3183         * dwarf2read.c: Don't include bcache.h.
3184         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3185         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3186         (print_bcache_statistics, bcache_memory_used): Don't declare.
3187         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3188         methods.  Rename all data members.
3189         * bcache.c (struct bcache): Move to bcache.h.
3190         (bcache::expand_hash_table): Rename from expand_hash_table.
3191         (bcache): Remove.
3192         (bcache::insert): Rename from bcache_full.
3193         (bcache::compare): Rename from bcache_compare.
3194         (bcache_xmalloc): Remove.
3195         (bcache::~bcache): Rename from bcache_xfree.
3196         (bcache::print_statistics): Rename from print_bcache_statistics.
3197         (bcache::memory_used): Rename from bcache_memory_used.
3198
3199 2019-03-07  Pedro Alves  <palves@redhat.com>
3200
3201         * infrun.c (normal_stop): Also check for
3202         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3203
3204 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3205
3206         * f-lang.c (value_from_host_double): Moved to...
3207         * value.c (value_from_host_double): ...here.
3208         * value.h (value_from_host_double): Declare.
3209         * guile/scm-math.c (vlscm_convert_typed_number): Use
3210         value_from_host_double.
3211         (vlscm_convert_number): Likewise.
3212         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3213         * python/py-value.c (convert_value_from_python): Likewise.
3214
3215 2019-03-06  Tom Tromey  <tom@tromey.com>
3216
3217         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3218
3219 2019-03-06  Tom Tromey  <tom@tromey.com>
3220
3221         * utils.h (free_current_contents): Don't declare.
3222         * utils.c (free_current_contents): Remove.
3223
3224 2019-03-06  Tom Tromey  <tom@tromey.com>
3225
3226         * top.c (quit_force): Update.
3227         * main.c (captured_command_loop): Update.
3228         * common/new-op.c (operator new): Update.
3229         * common/common-exceptions.c (struct catcher)
3230         <save_cleanup_chain>: Remove member.
3231         (exceptions_state_mc_init): Update.
3232         (exception_try_scope_entry): Return nullptr.
3233         (exception_try_scope_exit, exception_rethrow)
3234         (throw_exception_sjlj, throw_exception_cxx): Update.
3235         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3236         (all_cleanups, do_cleanups, discard_cleanups)
3237         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3238         (restore_cleanups, restore_final_cleanups): Don't declare.
3239         (do_final_cleanups): Remove parameter.
3240         * common/cleanups.c (cleanup_chain, make_cleanup)
3241         (make_cleanup_dtor, all_cleanups, do_cleanups)
3242         (discard_my_cleanups, discard_cleanups)
3243         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3244         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3245         (null_cleanup): Remove.
3246         (do_final_cleanups): Remove parameter.
3247
3248 2019-03-06  Tom Tromey  <tom@tromey.com>
3249
3250         * remote.c (remote_target::remote_parse_stop_reply): Use
3251         unique_xmalloc_ptr.
3252
3253 2019-03-06  Tom Tromey  <tom@tromey.com>
3254
3255         * stabsread.c (struct stabs_field_info): Rename from field_info.
3256         <list, fnlist>: Add initializers.
3257         <obstack>: New member.
3258         (read_member_functions, read_struct_fields, read_baseclasses):
3259         Allocate on obstack.  Don't use cleanups.
3260         (read_one_struct_field, read_member_functions, read_struct_fields)
3261         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3262         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3263         (read_struct_type): Update.
3264
3265 2019-03-06  Tom Tromey  <tom@tromey.com>
3266
3267         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3268         * common/filestuff.h (make_cleanup_close): Don't declare.
3269         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3270         Remove.
3271
3272 2019-03-06  Tom Tromey  <tom@tromey.com>
3273
3274         * solib-aix.c: Use make_scope_exit.
3275
3276 2019-03-06  Tom Tromey  <tom@tromey.com>
3277
3278         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3279         Use make_scope_exit.
3280
3281 2019-03-06  Tom Tromey  <tom@tromey.com>
3282
3283         * solib-svr4.c (disable_probes_interface): Remove parameter.
3284         (svr4_handle_solib_event): Use make_scope_exit.
3285
3286 2019-03-06  Tom Tromey  <tom@tromey.com>
3287
3288         * remote.c (struct stop_reply_deleter): Remove.
3289         (stop_reply_up): Update.
3290         (struct stop_reply): Derive from notif_event.  Don't typedef.
3291         <regcache>: Now a std::vector.
3292         (stop_reply_xfree): Remove.
3293         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3294         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3295         (remote_target::discard_pending_stop_replies): Use delete.
3296         (remote_target::remote_parse_stop_reply): Update.
3297         (remote_target::process_stop_reply): Update.
3298         * remote-notif.h (struct notif_event): Add virtual destructor.
3299         Remove "dtr" member.
3300         (struct notif_client) <alloc_event>: Return a unique_ptr.
3301         (notif_event_xfree): Don't declare.
3302         (notif_event_up): New typedef.
3303         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3304         (notif_event_xfree, do_notif_event_xfree): Remove.
3305         (remote_notif_state_xfree): Update.
3306
3307 2019-03-06  Tom Tromey  <tom@tromey.com>
3308
3309         * infrun.c (displaced_step_clear_cleanup): Now a
3310         forward_scope_exit type.
3311         (displaced_step_prepare_throw): Update.
3312         (displaced_step_fixup): Update.
3313
3314 2019-03-06  Tom Tromey  <tom@tromey.com>
3315
3316         * inferior.h (class inferior): Update comment.
3317         * gdbthread.h (class thread_info): Update comment.
3318
3319 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3320             Tom Tromey  <tom@tromey.com>
3321
3322         * stabsread.h (struct stab_section_list): Remove.
3323         (coffstab_build_psymtabs): Update.
3324         * dbxread.c (symbuf_sections): Now a std::vector.
3325         (sect_idx): New global.
3326         (fill_symbuf): Update.
3327         (coffstab_build_psymtabs): Change type of stabsects parameter.
3328         Update.
3329         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3330         std::vector.
3331         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3332         (coff_locate_sections): Update.
3333         (coff_symfile_read): Remove cleanups.  Update.
3334         (init_stringtab): Add storage parameter.
3335         (free_stringtab, free_stringtab_cleanup): Remove.
3336         (init_lineno): Add storage parameter.
3337         (free_linetab, free_linetab_cleanup): Remove.
3338
3339 2019-03-06  Pedro Alves  <palves@redhat.com>
3340
3341         * linux-fork.c (fork_info::clobber_regs): Delete.
3342         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3343         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3344         comment.  Adjust.
3345         (scoped_switch_fork_info::scoped_switch_fork_info)
3346         (checkpoint_command, linux_fork_context): Adjust
3347         fork_save_infrun_state calls.
3348
3349 2019-03-06  Pedro Alves  <palves@redhat.com>
3350
3351         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3352         (inf_has_multiple_threads): Return 'bool' and rewrite using
3353         inferior_info::threads().
3354
3355 2019-03-06  Pedro Alves  <palves@redhat.com>
3356
3357         * linux-fork.c: Include <list>.
3358         (fork_list): Now a std::list instance.
3359         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3360         (forks_exist_p, find_last_fork): Adjust.
3361         (new_fork): Delete.
3362         (one_fork_p): New.
3363         (add_fork): Adjust.
3364         (free_fork): Delete, folded into fork_info::~fork_info().
3365         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3366         Adjust.
3367         (init_fork_list): Delete.
3368         (linux_fork_killall, linux_fork_mourn_inferior)
3369         (linux_fork_detach, info_checkpoints_command): Adjust.
3370         (_initialize_linux_fork): No longer call init_fork_list.
3371
3372 2019-03-06  Pedro Alves  <palves@redhat.com>
3373
3374         * linux-fork.c (new_fork): New, split out of ...
3375         (add_fork): ... this.  Return void.  Move "first fork" special
3376         case from here, to ...
3377         (checkpoint_command): ... here.
3378         * linux-linux.h (add_fork): Return void.
3379
3380 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3381
3382         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3383
3384 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3385             Chris January  <chris.january@arm.com>
3386             David Lecomber  <david.lecomber@arm.com>
3387
3388         * f-exp.y: New token, UNOP_INTRINSIC.
3389         (exp): New pattern using UNOP_INTRINSIC token.
3390         (f77_keywords): Add 'abs' keyword.
3391         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3392         (value_from_host_double): New function.
3393         (evaluate_subexp_f): Support UNOP_ABS.
3394
3395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3396
3397         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3398         types.
3399
3400 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3401
3402         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3403         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3404         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3405
3406 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3407
3408         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3409
3410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3411             Chris January  <chris.january@arm.com>
3412
3413         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3414         * f-exp.y: Define 'KIND' token.
3415         (exp): New pattern for KIND expressions.
3416         (ptype): Handle types with a kind extension.
3417         (direct_abs_decl): Extend to spot kind extensions.
3418         (f77_keywords): Add 'kind' to the list.
3419         (push_kind_type): New function.
3420         (convert_to_kind_type): New function.
3421         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3422         * parse.c (operator_length_standard): Likewise.
3423         * parser-defs.h (enum type_pieces): Add tp_kind.
3424         * std-operator.def: Add UNOP_KIND.
3425
3426 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3427
3428         * f-exp.y (f_parse): Set yydebug.
3429
3430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         * f-lang.c (evaluate_subexp_f): New function.
3433         (exp_descriptor_f): New global.
3434         (f_language_defn): Use exp_descriptor_f instead of
3435         exp_descriptor_standard.
3436
3437 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3438
3439         * f-exp.y (struct token): Add comments.
3440         (dot_ops): Remove uppercase versions and the end marker.
3441         (f77_keywords): Likewise.
3442         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3443         entries in the dot_ops array are case insensitive, and use
3444         strncasecmp to compare strings.  Also some whitespace cleanup in
3445         this area.  Similar for the f77_keywords array, except entries in
3446         this list might be case sensitive.
3447
3448 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3449
3450         * f-exp.y (struct f77_boolean_val): Add comments.
3451         (boolean_values): Remove uppercase versions, and end marker.
3452         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3453         and use strncasecmp to achieve case insensitivity.  Additionally,
3454         perform whitespace cleanup around this code.
3455
3456 2019-03-06  Tom Tromey  <tromey@adacore.com>
3457
3458         * remote-sim.c (gdbsim_target_open): Use result of
3459         gdb_argv::release.
3460
3461 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3462         Dirk Schubert  <dirk.schubert@arm.com>
3463         Chris January  <chris.january@arm.com>
3464
3465         * eval.c (evaluate_subexp_standard): Call Fortran argument
3466         wrapping logic.
3467         * f-lang.c (struct value): A value which can be passed into a
3468         Fortran function call.
3469         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3470         where appropriate.
3471         (struct type): Value ready for a Fortran function call.
3472         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3473         is needed.
3474         * f-lang.h (fortran_argument_convert): Declaration.
3475         (fortran_preserve_arg_pointer): Declaration.
3476         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3477
3478 2019-03-05  Tom Tromey  <tromey@adacore.com>
3479
3480         * python/py-prettyprint.c (print_string_repr): Remove #if.
3481         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3482
3483 2019-03-05  Tom Tromey  <tromey@adacore.com>
3484
3485         * target.c (the_dummy_target): Move later.  Change type to
3486         "dummy_target".
3487         (initialize_targets): Don't initialize the_dummy_target.
3488
3489 2019-03-05  Tom Tromey  <tromey@adacore.com>
3490
3491         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3492         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3493
3494 2019-03-05  Tom Tromey  <tromey@adacore.com>
3495
3496         * windows-nat.c (windows_nat_target::attach)
3497         (windows_nat_target::detach): Don't call gdb_flush.
3498         * valprint.c (generic_val_print, val_print, val_print_string):
3499         Don't call gdb_flush.
3500         * utils.c (defaulted_query): Don't call gdb_flush.
3501         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3502         * target.c (target_announce_detach): Don't call gdb_flush.
3503         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3504         * remote.c (extended_remote_target::attach): Don't call
3505         gdb_flush.
3506         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3507         * printcmd.c (do_examine): Don't call gdb_flush.
3508         (info_display_command): Don't call gdb_flush.
3509         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3510         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3511         * memattr.c (info_mem_command): Don't call gdb_flush.
3512         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3513         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3514         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3515         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3516         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3517         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3518         (gnu_nat_target::detach): Don't call gdb_flush.
3519         * f-valprint.c (f_val_print): Don't call gdb_flush.
3520         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3521         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3522         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3523         gdb_flush.
3524         * c-valprint.c (c_val_print): Don't call gdb_flush.
3525         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3526
3527 2019-03-05  Tom Tromey  <tromey@adacore.com>
3528
3529         * varobj.c (update_dynamic_varobj_children): Update.
3530         (install_default_visualizer): Use reset, not release.
3531         * value.c (set_internalvar): Update.
3532         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3533         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3534         ATTRIBUTE_UNUSED_RESULT.
3535
3536 2019-03-05  Tom Tromey  <tromey@adacore.com>
3537
3538         * remote.c (class scoped_remote_fd) <release>: Add
3539         ATTRIBUTE_UNUSED_RESULT.
3540
3541 2019-03-05  Tom Tromey  <tromey@adacore.com>
3542
3543         * macroexp.c (struct macro_buffer) <release>: Add
3544         ATTRIBUTE_UNUSED_RESULT.
3545
3546 2019-03-05  Tom Tromey  <tromey@adacore.com>
3547
3548         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3549         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3550         ATTRIBUTE_UNUSED_RESULT.
3551
3552 2019-03-05  Tom Tromey  <tromey@adacore.com>
3553
3554         * common/scoped_fd.h (class scoped_fd) <release>: Add
3555         ATTRIBUTE_UNUSED_RESULT.
3556
3557 2019-03-05  Tom Tromey  <tromey@adacore.com>
3558
3559         * parser-defs.h (struct parser_state) <release>: Add
3560         ATTRIBUTE_UNUSED_RESULT.
3561
3562 2019-03-05  Tom Tromey  <tromey@adacore.com>
3563
3564         * utils.h (class gdb_argv) <release>: Add
3565         ATTRIBUTE_UNUSED_RESULT.
3566         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3567
3568 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3569
3570         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3571         for-loop range, to avoid compiler warnings.
3572
3573         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3574         avoid compiler warnings about unused variables.
3575
3576         * NEWS: Mention end of support for native debugging on MS-Windows
3577         before XP.
3578
3579         PR gdb/24292
3580         * common/netstuff.c:
3581         * gdbserver/gdbreplay.c
3582         * gdbserver/remote-utils.c:
3583         * ser-tcp.c:
3584         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3585         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3586         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3587         'getaddrinfo' and 'freeaddrinfo' were not available before
3588         Windows XP, and mingw.org's MinGW headers by default define
3589         _WIN32_WINNT to 0x500.
3590
3591 2019-03-01  Gary Benson <gbenson@redhat.com>
3592
3593         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3594
3595 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3596             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3597
3598         PR gdb/8527
3599         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3600         set_sigint_trap, clear_sigint_trap.
3601
3602 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3603
3604         * target.c (target_detach): Clear the regcache and the
3605         frame cache.
3606
3607 2019-02-27  Pedro Alves  <palves@redhat.com>
3608
3609         * utils.c (set_screen_size): When we cap the height/width sizes,
3610         tweak the corresponding command variable to show "unlimited":
3611
3612 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3613             Pedro Alves  <palves@redhat.com>
3614
3615         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3616         before calling rl_set_screen_size.
3617
3618 2019-02-27  Tom Tromey  <tromey@adacore.com>
3619
3620         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3621         define.
3622         * python/py-value.c: Remove Python 2.4 workaround.
3623         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3624         workaround.
3625         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3626         Python 2.4 workaround.
3627         * python/python-internal.h: Remove Python 2.4 comment.
3628         (Py_ssize_t): Don't define.
3629         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3630         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3631         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3632         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3633         * python/python.c (do_start_initialization): Remove Python 2.4
3634         workaround.
3635         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3636         (print_children): Remove Python 2.4 workaround.
3637         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3638         workaround.
3639         (CHARBUFFERPROC_NAME): Remove.
3640         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3641         Python 2.4 workaround.
3642
3643 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3644
3645         * NEWS: Note minimum Python version.
3646
3647 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3648
3649         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3650         code from these functions.  Remove corresponding ifdefs.  Use
3651         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3652         Remove gotos and target of gotos.
3653         (infpy_search_memory): Likewise.
3654
3655 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3656
3657         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3658         (hppa_gdbarch_init): Don't register deleted functions with
3659         gdbarch.
3660
3661 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3662
3663         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3664         (h8300_unwind_sp): Delete.
3665         (h8300_dummy_id): Delete.
3666         (h8300_gdbarch_init): Don't register deleted functions with
3667         gdbarch.
3668
3669 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3670
3671         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3672         (ft32_unwind_pc): Delete.
3673         (ft32_unwind_sp): Delete.
3674         (ft32_gdbarch_init): Don't register deleted functions with
3675         gdbarch.
3676
3677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3678
3679         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3680         (frv_unwind_pc): Delete.
3681         (frv_unwind_sp): Delete.
3682         (frv_gdbarch_init): Don't register deleted functions with
3683         gdbarch.
3684
3685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3686
3687         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3688         (riscv_unwind_pc): Delete.
3689         (riscv_unwind_sp): Delete.
3690         (riscv_gdbarch_init): Don't register deleted functions with
3691         gdbarch.
3692
3693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3694
3695         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3696         (csky_unwind_pc): Delete.
3697         (csky_unwind_sp): Delete.
3698         (csky_gdbarch_init): Don't register deleted functions with
3699         gdbarch.
3700
3701 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3702
3703         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3704         (cris_unwind_pc): Delete.
3705         (cris_unwind_sp): Delete.
3706         (cris_gdbarch_init): Don't register deleted functions with
3707         gdbarch.
3708
3709 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3710
3711         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3712         (bfin_unwind_pc): Delete.
3713         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3714
3715 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3716
3717         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3718         (arm_unwind_pc): Delete.
3719         (arm_unwind_sp): Delete.
3720         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3721
3722 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3723
3724         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3725         (arc_unwind_pc): Delete.
3726         (arc_unwind_sp): Delete.
3727         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3728
3729 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3730
3731         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3732         (alpha_unwind_pc): Delete.
3733         (alpha_gdbarch_init): Don't register deleted functions with
3734         gdbarch.
3735
3736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3737
3738         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3739         (aarch64_unwind_pc): Delete.
3740         (aarch64_unwind_sp): Delete.
3741         (aarch64_gdbarch_init): Don't register deleted functions with
3742         gdbarch.
3743
3744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         * gdbtypes.c (type_align): Don't consider static members when
3747         computing structure alignment.
3748
3749 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3750
3751         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3752         return 0 for other types.
3753         * arch-utils.c (default_type_align): Always return 0.
3754         * gdbarch.h: Regenerate.
3755         * gdbarch.sh (type_align): Extend comment.
3756         * gdbtypes.c (type_align): Add additional comments, always call
3757         gdbarch_type_align before applying the default rules.
3758         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3759         generic code will then apply a suitable default.
3760         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3761         types, return 0 for other types.
3762
3763 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3764
3765         * NEWS: Create a new section for the next release branch.
3766         Rename the section of the current branch, now that it has
3767         been cut.
3768
3769 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3770
3771         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3772         * version.in: Bump version to 8.3.50.DATE-git.
3773
3774 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3775
3776         * aix-thread.c (ptid_cmp): Remove unused variable.
3777         (get_signaled_thread): Likewise.
3778         (store_regs_user_thread): Likewise.
3779         (store_regs_kernel_thread): Likewise.
3780         (fetch_regs_kernel_thread): Remove shadowed variable.
3781
3782 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3783
3784         * features/riscv/32bit-cpu.xml: Add register numbers.
3785         * features/riscv/32bit-fpu.c: Regenerate.
3786         * features/riscv/32bit-fpu.xml: Add register numbers.
3787         * features/riscv/64bit-cpu.xml: Add register numbers.
3788         * features/riscv/64bit-fpu.c: Regenerate.
3789         * features/riscv/64bit-fpu.xml: Add register numbers.
3790
3791 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3792
3793         * NEWS: Mention two argument form of gdb.Value constructor.
3794         * python/py-value.c (convert_buffer_and_type_to_value): New
3795         function.
3796         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3797         Add support for handling an optional second argument.  Call
3798         convert_buffer_and_type_to_value as appropriate.
3799         * python/python-internal.h (Py_buffer_deleter): New struct.
3800         (Py_buffer_up): New typedef.
3801
3802 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3803
3804         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3805         instead of releasing ownership.
3806
3807 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3808
3809         * dwarf2read.c (open_and_init_dwp_file): Call
3810         elf_numsections instead of bfd_count_sections to initialize
3811         dwp_file->num_sections.
3812
3813 2019-02-25  Tom Tromey  <tromey@adacore.com>
3814
3815         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3816
3817 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3818
3819         * gcore.in: Add '--readnever' option when invoking GDB.
3820
3821 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3822
3823         * MAINTAINERS: Update my email address.
3824
3825 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3826
3827         * build-id.c (build_id_to_debug_bfd_1): New function.
3828         (build_id_to_debug_bfd): Look for separate debug file in
3829         sysroot.
3830
3831 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3832
3833         * gdbarch.sh: Update the copyright year range that is placed into
3834         generated files.
3835
3836 2019-02-22  Keith Seitz  <keiths@redhat.com>
3837
3838         PR symtab/23853
3839         * linespec.c (create_sals_line_offset): Search for the default
3840         symtab's filename instead of its fullname.
3841
3842 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3843
3844         * NEWS: Update style defaults.
3845
3846 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3847
3848         * main.c (captured_main_1): Disable styling in batch mode.
3849
3850 2019-02-20  Tom Tromey  <tom@tromey.com>
3851
3852         * symtab.c (symtab_symbol_info): Fix typos.
3853
3854 2019-02-20  Tom Tromey  <tromey@adacore.com>
3855
3856         * findcmd.c (_initialize_mem_search): Use upper case for
3857         metasyntactic variables.
3858
3859 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3860
3861         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3862         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3863
3864 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3865
3866         * top.h (source_file_name): Change to std::string.
3867         * top.c (source_file_name): Likewise.
3868         (command_line_input): Adjust.
3869         * cli/cli-script.c (script_from_file): Adjust.
3870
3871 2019-02-19  Tom Tromey  <tromey@adacore.com>
3872
3873         * ravenscar-thread.c
3874         (ravenscar_thread_target::update_thread_list): Don't call
3875         ada_build_task_list.
3876         * ada-lang.h (ada_build_task_list): Don't declare.
3877         * ada-tasks.c (struct ada_tasks_inferior_data)
3878         <task_list_valid_p>: Now bool.
3879         (read_known_tasks, ada_task_list_changed)
3880         (ada_tasks_invalidate_inferior_data): Update.
3881         (read_known_tasks_array): Return bool.
3882         (read_known_tasks_list): Likewise.
3883         (read_known_tasks): Return void.
3884         (ada_build_task_list): Now static.
3885
3886 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3887
3888         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3889         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3890
3891 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3892
3893         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3894         variant for ada_tasks_pspace_data_handle and
3895         ada_tasks_inferior_data_handle.
3896         (ada_tasks_pspace_data_cleanup): New function.
3897         (ada_tasks_inferior_data_cleanup): New function.
3898
3899 2019-02-17  Tom Tromey  <tom@tromey.com>
3900
3901         * macrotab.h (macro_source_fullname): Return a std::string.
3902         * macrotab.c (macro_include, check_for_redefinition)
3903         (macro_undef, macro_lookup_definition, foreach_macro)
3904         (foreach_macro_in_scope): Update.
3905         (macro_source_fullname): Return a std::string.
3906         * macrocmd.c (show_pp_source_pos): Update.
3907
3908 2019-02-17  Tom Tromey  <tom@tromey.com>
3909
3910         * macrocmd.c (show_pp_source_pos): Style the file names.
3911
3912 2019-02-17  Tom Tromey  <tom@tromey.com>
3913
3914         PR tui/24197:
3915         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3916
3917 2019-02-17  Tom Tromey  <tom@tromey.com>
3918
3919         * ada-lang.c (user_select_syms): Use filtered printing.
3920         * utils.c (wrap_style): New global.
3921         (desired_style): Remove.
3922         (emit_style_escape): Add stream parameter.
3923         (set_output_style, reset_terminal_style, prompt_for_continue):
3924         Update.
3925         (flush_wrap_buffer): Only flush gdb_stdout.
3926         (wrap_here): Set wrap_style.
3927         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3928         treat escape sequences as a character.  Change when wrap buffer is
3929         flushed.
3930         (fputs_styled): Do not set the output style when the default is
3931         requested.
3932         * ui-style.h (struct ui_file_style) <is_default>: New method.
3933         * source.c (print_source_lines_base): Emit escape sequences in one
3934         piece.
3935
3936 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3937
3938         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3939         integers and enumeration types.
3940
3941 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3942
3943         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3944         instead of lookup_symbol_in_language
3945         (do_exact_match): New function.
3946         (ada_get_symbol_name_matcher): Return do_exact_match when
3947         doing a verbatim match.
3948
3949 2019-02-15  Tom Tromey  <tromey@adacore.com>
3950
3951         * ravenscar-thread.c (ravenscar_thread_target::resume)
3952         (ravenscar_thread_target::wait): Special case wildcard requests.
3953
3954 2019-02-15  Tom Tromey  <tromey@adacore.com>
3955
3956         * ravenscar-thread.c (base_ptid): Remove.
3957         (struct ravenscar_thread_target) <close>: New method.
3958         <m_base_ptid>: New member.
3959         <update_inferior_ptid, active_task, task_is_currently_active,
3960         runtime_initialized>: Declare methods.
3961         <ravenscar_thread_target>: Add constructor.
3962         (ravenscar_thread_target::task_is_currently_active)
3963         (ravenscar_thread_target::update_inferior_ptid)
3964         (ravenscar_runtime_initialized): Rename.  Now methods.
3965         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3966         (ravenscar_thread_target::update_thread_list): Update.
3967         (ravenscar_thread_target::active_task): Now method.
3968         (ravenscar_thread_target::store_registers)
3969         (ravenscar_thread_target::prepare_to_store)
3970         (ravenscar_thread_target::prepare_to_store)
3971         (ravenscar_thread_target::mourn_inferior): Update.
3972         (ravenscar_inferior_created): Use "new" to create target.
3973         (ravenscar_thread_target::get_ada_task_ptid): Update.
3974         (_initialize_ravenscar): Don't initialize base_ptid.
3975         (ravenscar_ops): Remove global.
3976
3977 2019-02-15  Tom Tromey  <tromey@adacore.com>
3978
3979         * target.h (push_target): Declare new overload.
3980         * target.c (push_target): New overload, taking an rvalue reference.
3981         * remote.c (remote_target::open_1): Use push_target overload.
3982         * corelow.c (core_target_open): Use push_target overload.
3983
3984 2019-02-15  Tom Tromey  <tromey@adacore.com>
3985
3986         * ravenscar-thread.c (is_ravenscar_task)
3987         (ravenscar_task_is_currently_active): Return bool.
3988         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3989         (_initialize_ravenscar): Remove "(void)".
3990         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3991         Return bool.
3992
3993 2019-02-15  Tom Tromey  <tromey@adacore.com>
3994
3995         * ravenscar-thread.c (ravenscar_runtime_initializer)
3996         (has_ravenscar_runtime, get_running_thread_id)
3997         (ravenscar_thread_target::resume): Fix indentation.
3998
3999 2019-02-15  Tom Tromey  <tromey@adacore.com>
4000
4001         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4002         from ravenscar_arch_ops.
4003         (sparc_ravenscar_ops::fetch_registers)
4004         (sparc_ravenscar_ops::store_registers): Now methods.
4005         (sparc_ravenscar_prepare_to_store): Remove.
4006         (sparc_ravenscar_ops): Redefine.
4007         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4008         methods and destructor.  Remove members.
4009         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4010         (ravenscar_thread_target::store_registers)
4011         (ravenscar_thread_target::prepare_to_store): Update.
4012         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4013         Remove.
4014         (struct ppc_ravenscar_powerpc_ops): Derive from
4015         ravenscar_arch_ops.
4016         (ppc_ravenscar_powerpc_ops::fetch_registers)
4017         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4018         (ppc_ravenscar_powerpc_ops): Redefine.
4019         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4020         (ppc_ravenscar_e500_ops::fetch_registers)
4021         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4022         (ppc_ravenscar_e500_ops): Redefine.
4023         * aarch64-ravenscar-thread.c
4024         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4025         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4026         (aarch64_ravenscar_fetch_registers)
4027         (aarch64_ravenscar_store_registers): Now methods.
4028         (aarch64_ravenscar_ops): Redefine.
4029
4030 2019-02-15  Tom Tromey  <tromey@adacore.com>
4031
4032         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4033         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4034         (ravenscar_thread_target::stopped_by_watchpoint)
4035         (ravenscar_thread_target::stopped_data_address)
4036         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4037
4038 2019-02-15  Tom Tromey  <tromey@adacore.com>
4039
4040         * ravenscar-thread.c: Fix some typos.
4041
4042 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4043             Tom Tromey  <tromey@adacore.com>
4044
4045         * ada-lang.c (ada_exception_sal): Change addr_string to a
4046         std::string.
4047         (create_ada_exception_catchpoint): Update.
4048
4049 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4050             Tom Tromey  <tromey@adacore.com>
4051
4052         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4053         (bp_location_ops): Remove.
4054         (base_breakpoint_allocate_location): Update.
4055         (free_bp_location): Update.
4056         * ada-lang.c (class ada_catchpoint_location)
4057         <ada_catchpoint_location>: Remove ops parameter.
4058         (ada_catchpoint_location_dtor): Remove.
4059         (ada_catchpoint_location_ops): Remove.
4060         (allocate_location_exception): Update.
4061         * breakpoint.h (struct bp_location_ops): Remove.
4062         (class bp_location) <bp_location>: Remove bp_location_ops
4063         parameter.
4064         <~bp_location>: Add destructor.
4065         <ops>: Remove.
4066
4067 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4068             Pedro Alves  <palves@redhat.com>
4069
4070         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4071         'PATH_MAX'.
4072
4073 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4074             Samuel Thibault  <samuel.thibault@gnu.org>
4075             Thomas Schwinge  <thomas@codesourcery.com>
4076
4077         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4078         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4079
4080 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4081
4082         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4083         (check_empty): Use "const char *".
4084
4085         * gnu-nat.c (gnu_nat_target::detach): Instead of
4086         'detach_inferior (pid)' call
4087         'detach_inferior (find_inferior_pid (pid))'.
4088
4089         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4090         'nat/fork-inferior.o'.
4091         * gnu-nat.c: #include "nat/fork-inferior.h".
4092
4093         * gnu-nat.c (gnu_nat_target::detach): Instead of
4094         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4095         * gnu-nat.h: #include "inf-child.h".
4096         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4097         'i386_gnu_nat_target::fetch_registers'.
4098         (gnu_store_registers): Rename/move to
4099         'i386_gnu_nat_target::store_registers'.
4100
4101         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4102         * gnu-nat.h (mach_thread_info): New function.
4103         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4104
4105         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4106
4107 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4108
4109         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4110
4111 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4112
4113         * windows-nat.c (windows_add_thread): Add new parameter
4114         "main_thread_p" with default value set to false.  Update
4115         function documentation as well as all callers.
4116         (windows_delete_thread): Likewise.
4117         (fake_create_process): Update call to windows_add_thread.
4118         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4119         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4120         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4121         call to windows_delete_thread.
4122
4123 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4124
4125         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4126
4127 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4128
4129         * symfile.c (find_separate_debug_file): Use canonical path of
4130         sysroot with child_path instead of gdb_sysroot if it is valid.
4131
4132 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4133
4134         * symfile.c (find_separate_debug_file): Use child_path to
4135         determine if an object file is under a sysroot.
4136
4137 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4138
4139         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4140         unittests/child-path-selftests.c.
4141         * common/pathstuff.c (child_path): New function.
4142         * common/pathstuff.h (child_path): New prototype.
4143         * unittests/child-path-selftests.c: New file.
4144
4145 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4146
4147         * symfile.c (find_separate_debug_file): Look for separate debug
4148         files in debug directories under the sysroot.
4149
4150 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4151
4152         * symtab.h (struct minimal_symbol data_p): New const method.
4153         (struct minimal_symbol text_p): Likewise.
4154         * symtab.c (output_source_filename): Use file name style
4155         to print file name.
4156         (print_symbol_info): Likewise.
4157         (print_msymbol_info): Use address style to print addresses.
4158         Use function name style to print executable text symbols.
4159         (expand_symtab_containing_pc): Use data_p.
4160         (find_pc_sect_compunit_symtab): Likewise.
4161
4162 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4163
4164         * breakpoint.c (describe_other_breakpoints): Use address style
4165         to print addresses.
4166         (say_where): Likewise.
4167
4168 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4169
4170         * ada-typeprint.c (print_func_type): Print function name
4171         style to print function name.
4172         * c-typeprint.c (c_print_type_1): Likewise.
4173
4174 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4175
4176         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4177         for execve.
4178
4179 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4180
4181         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4182         type_stack.
4183
4184 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4185
4186         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4187         TYPE_CODE_REF types.
4188
4189 2019-02-08  Jim Wilson  <jimw@sifive.com>
4190
4191         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4192         (riscv_linux_fregset): New.
4193         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4194
4195 2019-02-07  Tom Tromey  <tom@tromey.com>
4196
4197         * thread.c (thread_cancel_execution_command): Update.
4198         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4199         methods.
4200         (struct thread_fsm_ops): Remove.
4201         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4202         (thread_fsm_should_stop, thread_fsm_return_value)
4203         (thread_fsm_set_finished, thread_fsm_finished_p)
4204         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4205         Don't declare.
4206         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4207         * infrun.c (clear_proceed_status_thread)
4208         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4209         (print_stop_event): Update.
4210         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4211         Add constructor.
4212         (step_command_fsm_ops): Remove.
4213         (new_step_command_fsm): Remove.
4214         (step_1): Update.
4215         (step_command_fsm::should_stop): Rename from
4216         step_command_fsm_should_stop.
4217         (step_command_fsm::clean_up): Rename from
4218         step_command_fsm_clean_up.
4219         (step_command_fsm::do_async_reply_reason): Rename from
4220         step_command_fsm_async_reply_reason.
4221         (struct until_next_fsm): Inherit from thread_fsm.  Add
4222         constructor.
4223         (until_next_fsm_ops): Remove.
4224         (new_until_next_fsm): Remove.
4225         (until_next_fsm::should_stop): Rename from
4226         until_next_fsm_should_stop.
4227         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4228         (until_next_fsm::do_async_reply_reason): Rename from
4229         until_next_fsm_async_reply_reason.
4230         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4231         constructor.  Change type of breakpoint.
4232         (finish_command_fsm_ops): Remove.
4233         (new_finish_command_fsm): Remove.
4234         (finish_command_fsm::should_stop): Rename from
4235         finish_command_fsm_should_stop.
4236         (finish_command_fsm::clean_up): Rename from
4237         finish_command_fsm_clean_up.
4238         (finish_command_fsm::return_value): Rename from
4239         finish_command_fsm_return_value.
4240         (finish_command_fsm::do_async_reply_reason): Rename from
4241         finish_command_fsm_async_reply_reason.
4242         (finish_command): Update.
4243         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4244         Add constructor.
4245         (call_thread_fsm_ops): Remove.
4246         (call_thread_fsm::call_thread_fsm): Rename from
4247         new_call_thread_fsm.
4248         (call_thread_fsm::should_stop): Rename from
4249         call_thread_fsm_should_stop.
4250         (call_thread_fsm::should_notify_stop): Rename from
4251         call_thread_fsm_should_notify_stop.
4252         (run_inferior_call, call_function_by_hand_dummy): Update.
4253         * cli/cli-interp.c (should_print_stop_to_console): Update.
4254         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4255         Add constructor.  Change type of location_breakpoint,
4256         caller_breakpoint.
4257         (until_break_fsm_ops): Remove.
4258         (new_until_break_fsm): Remove.
4259         (until_break_fsm::should_stop): Rename from
4260         until_break_fsm_should_stop.
4261         (until_break_fsm::clean_up): Rename from
4262         until_break_fsm_clean_up.
4263         (until_break_fsm::do_async_reply_reason): Rename from
4264         until_break_fsm_async_reply_reason.
4265         (until_break_command): Update.
4266         * thread-fsm.c: Remove.
4267         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4268
4269 2019-02-07  Tom Tromey  <tom@tromey.com>
4270
4271         * yy-remap.h: Add include guard.
4272         * xtensa-tdep.h: Add include guard.
4273         * xcoffread.h: Rename include guard.
4274         * varobj-iter.h: Add include guard.
4275         * tui/tui.h: Rename include guard.
4276         * tui/tui-winsource.h: Rename include guard.
4277         * tui/tui-wingeneral.h: Rename include guard.
4278         * tui/tui-windata.h: Rename include guard.
4279         * tui/tui-win.h: Rename include guard.
4280         * tui/tui-stack.h: Rename include guard.
4281         * tui/tui-source.h: Rename include guard.
4282         * tui/tui-regs.h: Rename include guard.
4283         * tui/tui-out.h: Rename include guard.
4284         * tui/tui-layout.h: Rename include guard.
4285         * tui/tui-io.h: Rename include guard.
4286         * tui/tui-hooks.h: Rename include guard.
4287         * tui/tui-file.h: Rename include guard.
4288         * tui/tui-disasm.h: Rename include guard.
4289         * tui/tui-data.h: Rename include guard.
4290         * tui/tui-command.h: Rename include guard.
4291         * tic6x-tdep.h: Add include guard.
4292         * target/waitstatus.h: Rename include guard.
4293         * target/wait.h: Rename include guard.
4294         * target/target.h: Rename include guard.
4295         * target/resume.h: Rename include guard.
4296         * target-float.h: Rename include guard.
4297         * stabsread.h: Add include guard.
4298         * rs6000-tdep.h: Add include guard.
4299         * riscv-fbsd-tdep.h: Add include guard.
4300         * regformats/regdef.h: Rename include guard.
4301         * record.h: Rename include guard.
4302         * python/python.h: Rename include guard.
4303         * python/python-internal.h: Rename include guard.
4304         * python/py-stopevent.h: Rename include guard.
4305         * python/py-ref.h: Rename include guard.
4306         * python/py-record.h: Rename include guard.
4307         * python/py-record-full.h: Rename include guard.
4308         * python/py-record-btrace.h: Rename include guard.
4309         * python/py-instruction.h: Rename include guard.
4310         * python/py-events.h: Rename include guard.
4311         * python/py-event.h: Rename include guard.
4312         * procfs.h: Add include guard.
4313         * proc-utils.h: Add include guard.
4314         * p-lang.h: Add include guard.
4315         * or1k-tdep.h: Rename include guard.
4316         * observable.h: Rename include guard.
4317         * nto-tdep.h: Rename include guard.
4318         * nat/x86-linux.h: Rename include guard.
4319         * nat/x86-linux-dregs.h: Rename include guard.
4320         * nat/x86-gcc-cpuid.h: Add include guard.
4321         * nat/x86-dregs.h: Rename include guard.
4322         * nat/x86-cpuid.h: Rename include guard.
4323         * nat/ppc-linux.h: Rename include guard.
4324         * nat/mips-linux-watch.h: Rename include guard.
4325         * nat/linux-waitpid.h: Rename include guard.
4326         * nat/linux-ptrace.h: Rename include guard.
4327         * nat/linux-procfs.h: Rename include guard.
4328         * nat/linux-osdata.h: Rename include guard.
4329         * nat/linux-nat.h: Rename include guard.
4330         * nat/linux-namespaces.h: Rename include guard.
4331         * nat/linux-btrace.h: Rename include guard.
4332         * nat/glibc_thread_db.h: Rename include guard.
4333         * nat/gdb_thread_db.h: Rename include guard.
4334         * nat/gdb_ptrace.h: Rename include guard.
4335         * nat/fork-inferior.h: Rename include guard.
4336         * nat/amd64-linux-siginfo.h: Rename include guard.
4337         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4338         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4339         * nat/aarch64-linux.h: Rename include guard.
4340         * nat/aarch64-linux-hw-point.h: Rename include guard.
4341         * mn10300-tdep.h: Add include guard.
4342         * mips-linux-tdep.h: Add include guard.
4343         * mi/mi-parse.h: Rename include guard.
4344         * mi/mi-out.h: Rename include guard.
4345         * mi/mi-main.h: Rename include guard.
4346         * mi/mi-interp.h: Rename include guard.
4347         * mi/mi-getopt.h: Rename include guard.
4348         * mi/mi-console.h: Rename include guard.
4349         * mi/mi-common.h: Rename include guard.
4350         * mi/mi-cmds.h: Rename include guard.
4351         * mi/mi-cmd-break.h: Rename include guard.
4352         * m2-lang.h: Add include guard.
4353         * location.h: Rename include guard.
4354         * linux-record.h: Rename include guard.
4355         * linux-nat.h: Add include guard.
4356         * linux-fork.h: Add include guard.
4357         * i386-darwin-tdep.h: Rename include guard.
4358         * hppa-linux-offsets.h: Add include guard.
4359         * guile/guile.h: Rename include guard.
4360         * guile/guile-internal.h: Rename include guard.
4361         * gnu-nat.h: Rename include guard.
4362         * gdb-stabs.h: Rename include guard.
4363         * frv-tdep.h: Add include guard.
4364         * f-lang.h: Add include guard.
4365         * event-loop.h: Add include guard.
4366         * darwin-nat.h: Rename include guard.
4367         * cp-abi.h: Rename include guard.
4368         * config/sparc/nm-sol2.h: Rename include guard.
4369         * config/nm-nto.h: Rename include guard.
4370         * config/nm-linux.h: Add include guard.
4371         * config/i386/nm-i386gnu.h: Rename include guard.
4372         * config/djgpp/nl_types.h: Rename include guard.
4373         * config/djgpp/langinfo.h: Rename include guard.
4374         * compile/gcc-cp-plugin.h: Add include guard.
4375         * compile/gcc-c-plugin.h: Add include guard.
4376         * compile/compile.h: Rename include guard.
4377         * compile/compile-object-run.h: Rename include guard.
4378         * compile/compile-object-load.h: Rename include guard.
4379         * compile/compile-internal.h: Rename include guard.
4380         * compile/compile-cplus.h: Rename include guard.
4381         * compile/compile-c.h: Rename include guard.
4382         * common/xml-utils.h: Rename include guard.
4383         * common/x86-xstate.h: Rename include guard.
4384         * common/version.h: Rename include guard.
4385         * common/vec.h: Rename include guard.
4386         * common/tdesc.h: Rename include guard.
4387         * common/selftest.h: Rename include guard.
4388         * common/scoped_restore.h: Rename include guard.
4389         * common/scoped_mmap.h: Rename include guard.
4390         * common/scoped_fd.h: Rename include guard.
4391         * common/safe-iterator.h: Rename include guard.
4392         * common/run-time-clock.h: Rename include guard.
4393         * common/refcounted-object.h: Rename include guard.
4394         * common/queue.h: Rename include guard.
4395         * common/ptid.h: Rename include guard.
4396         * common/print-utils.h: Rename include guard.
4397         * common/preprocessor.h: Rename include guard.
4398         * common/pathstuff.h: Rename include guard.
4399         * common/observable.h: Rename include guard.
4400         * common/netstuff.h: Rename include guard.
4401         * common/job-control.h: Rename include guard.
4402         * common/host-defs.h: Rename include guard.
4403         * common/gdb_wait.h: Rename include guard.
4404         * common/gdb_vecs.h: Rename include guard.
4405         * common/gdb_unlinker.h: Rename include guard.
4406         * common/gdb_unique_ptr.h: Rename include guard.
4407         * common/gdb_tilde_expand.h: Rename include guard.
4408         * common/gdb_sys_time.h: Rename include guard.
4409         * common/gdb_string_view.h: Rename include guard.
4410         * common/gdb_splay_tree.h: Rename include guard.
4411         * common/gdb_setjmp.h: Rename include guard.
4412         * common/gdb_ref_ptr.h: Rename include guard.
4413         * common/gdb_optional.h: Rename include guard.
4414         * common/gdb_locale.h: Rename include guard.
4415         * common/gdb_assert.h: Rename include guard.
4416         * common/filtered-iterator.h: Rename include guard.
4417         * common/filestuff.h: Rename include guard.
4418         * common/fileio.h: Rename include guard.
4419         * common/environ.h: Rename include guard.
4420         * common/common-utils.h: Rename include guard.
4421         * common/common-types.h: Rename include guard.
4422         * common/common-regcache.h: Rename include guard.
4423         * common/common-inferior.h: Rename include guard.
4424         * common/common-gdbthread.h: Rename include guard.
4425         * common/common-exceptions.h: Rename include guard.
4426         * common/common-defs.h: Rename include guard.
4427         * common/common-debug.h: Rename include guard.
4428         * common/cleanups.h: Rename include guard.
4429         * common/buffer.h: Rename include guard.
4430         * common/btrace-common.h: Rename include guard.
4431         * common/break-common.h: Rename include guard.
4432         * cli/cli-utils.h: Rename include guard.
4433         * cli/cli-style.h: Rename include guard.
4434         * cli/cli-setshow.h: Rename include guard.
4435         * cli/cli-script.h: Rename include guard.
4436         * cli/cli-interp.h: Rename include guard.
4437         * cli/cli-decode.h: Rename include guard.
4438         * cli/cli-cmds.h: Rename include guard.
4439         * charset-list.h: Add include guard.
4440         * buildsym-legacy.h: Rename include guard.
4441         * bfin-tdep.h: Add include guard.
4442         * ax.h: Rename include guard.
4443         * arm-linux-tdep.h: Add include guard.
4444         * arm-fbsd-tdep.h: Add include guard.
4445         * arch/xtensa.h: Rename include guard.
4446         * arch/tic6x.h: Add include guard.
4447         * arch/i386.h: Add include guard.
4448         * arch/arm.h: Rename include guard.
4449         * arch/arm-linux.h: Rename include guard.
4450         * arch/arm-get-next-pcs.h: Rename include guard.
4451         * arch/amd64.h: Add include guard.
4452         * arch/aarch64-insn.h: Rename include guard.
4453         * arch-utils.h: Rename include guard.
4454         * annotate.h: Add include guard.
4455         * amd64-darwin-tdep.h: Rename include guard.
4456         * aarch64-linux-tdep.h: Add include guard.
4457         * aarch64-fbsd-tdep.h: Add include guard.
4458         * aarch32-linux-nat.h: Add include guard.
4459
4460 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4461
4462         * macrotab.c (macro_define_internal): New function that
4463         factorizes macro_define_object_internal and macro_define_function
4464         code.
4465         (macro_define_object_internal): Use macro_define_internal.
4466         (macro_define_function): Likewise.
4467
4468 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4469
4470         * macrocmd.c (extract_identifier): Return
4471         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4472         callers.
4473
4474 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4475
4476         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4477
4478 2019-02-05  Tom Tromey  <tom@tromey.com>
4479
4480         * target.c (target_stack::unpush): Move assertion earlier.
4481
4482 2019-01-30  Tom Tromey  <tom@tromey.com>
4483
4484         PR python/23615:
4485         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4486         (gdbpy_parse_and_eval): Likewise.
4487         * python/python-internal.h (gdbpy_allow_threads): New class.
4488
4489 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4490
4491         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4492         (aarch64_fbsd_fpregmap): Move earlier.
4493         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4494         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4495         instead of individual calls to trad_frame_set_reg_addr.
4496         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4497         earlier.
4498         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4499         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4500         instead of individual calls to trad_frame_set_reg_addr.
4501
4502 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4503
4504         * CONTRIBUTE: Replace contribution list with wiki link.
4505
4506 2019-01-25  Tom Tromey  <tom@tromey.com>
4507
4508         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4509
4510 2019-01-25  Tom Tromey  <tom@tromey.com>
4511
4512         * xtensa-linux-nat.c: Fix common/ includes.
4513         * xml-support.h: Fix common/ includes.
4514         * xml-support.c: Fix common/ includes.
4515         * x86-linux-nat.c: Fix common/ includes.
4516         * windows-nat.c: Fix common/ includes.
4517         * varobj.h: Fix common/ includes.
4518         * varobj.c: Fix common/ includes.
4519         * value.c: Fix common/ includes.
4520         * valops.c: Fix common/ includes.
4521         * utils.c: Fix common/ includes.
4522         * unittests/xml-utils-selftests.c: Fix common/ includes.
4523         * unittests/utils-selftests.c: Fix common/ includes.
4524         * unittests/unpack-selftests.c: Fix common/ includes.
4525         * unittests/tracepoint-selftests.c: Fix common/ includes.
4526         * unittests/style-selftests.c: Fix common/ includes.
4527         * unittests/string_view-selftests.c: Fix common/ includes.
4528         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4529         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4530         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4531         * unittests/rsp-low-selftests.c: Fix common/ includes.
4532         * unittests/parse-connection-spec-selftests.c: Fix common/
4533         includes.
4534         * unittests/optional-selftests.c: Fix common/ includes.
4535         * unittests/offset-type-selftests.c: Fix common/ includes.
4536         * unittests/observable-selftests.c: Fix common/ includes.
4537         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4538         * unittests/memrange-selftests.c: Fix common/ includes.
4539         * unittests/memory-map-selftests.c: Fix common/ includes.
4540         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4541         * unittests/function-view-selftests.c: Fix common/ includes.
4542         * unittests/environ-selftests.c: Fix common/ includes.
4543         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4544         * unittests/common-utils-selftests.c: Fix common/ includes.
4545         * unittests/cli-utils-selftests.c: Fix common/ includes.
4546         * unittests/array-view-selftests.c: Fix common/ includes.
4547         * ui-file.c: Fix common/ includes.
4548         * tui/tui-io.c: Fix common/ includes.
4549         * tracepoint.h: Fix common/ includes.
4550         * tracepoint.c: Fix common/ includes.
4551         * tracefile-tfile.c: Fix common/ includes.
4552         * top.h: Fix common/ includes.
4553         * top.c: Fix common/ includes.
4554         * thread.c: Fix common/ includes.
4555         * target/waitstatus.h: Fix common/ includes.
4556         * target/waitstatus.c: Fix common/ includes.
4557         * target.h: Fix common/ includes.
4558         * target.c: Fix common/ includes.
4559         * target-memory.c: Fix common/ includes.
4560         * target-descriptions.c: Fix common/ includes.
4561         * symtab.h: Fix common/ includes.
4562         * symfile.c: Fix common/ includes.
4563         * stap-probe.c: Fix common/ includes.
4564         * spu-linux-nat.c: Fix common/ includes.
4565         * sparc-nat.c: Fix common/ includes.
4566         * source.c: Fix common/ includes.
4567         * solib.c: Fix common/ includes.
4568         * solib-target.c: Fix common/ includes.
4569         * ser-unix.c: Fix common/ includes.
4570         * ser-tcp.c: Fix common/ includes.
4571         * ser-pipe.c: Fix common/ includes.
4572         * ser-base.c: Fix common/ includes.
4573         * selftest-arch.c: Fix common/ includes.
4574         * s12z-tdep.c: Fix common/ includes.
4575         * rust-exp.y: Fix common/ includes.
4576         * rs6000-aix-tdep.c: Fix common/ includes.
4577         * riscv-tdep.c: Fix common/ includes.
4578         * remote.c: Fix common/ includes.
4579         * remote-notif.h: Fix common/ includes.
4580         * remote-fileio.h: Fix common/ includes.
4581         * remote-fileio.c: Fix common/ includes.
4582         * regcache.h: Fix common/ includes.
4583         * regcache.c: Fix common/ includes.
4584         * record-btrace.c: Fix common/ includes.
4585         * python/python.c: Fix common/ includes.
4586         * python/py-type.c: Fix common/ includes.
4587         * python/py-inferior.c: Fix common/ includes.
4588         * progspace.h: Fix common/ includes.
4589         * producer.c: Fix common/ includes.
4590         * procfs.c: Fix common/ includes.
4591         * proc-api.c: Fix common/ includes.
4592         * printcmd.c: Fix common/ includes.
4593         * ppc-linux-nat.c: Fix common/ includes.
4594         * parser-defs.h: Fix common/ includes.
4595         * osdata.c: Fix common/ includes.
4596         * obsd-nat.c: Fix common/ includes.
4597         * nat/x86-linux.c: Fix common/ includes.
4598         * nat/x86-linux-dregs.c: Fix common/ includes.
4599         * nat/x86-dregs.h: Fix common/ includes.
4600         * nat/x86-dregs.c: Fix common/ includes.
4601         * nat/ppc-linux.c: Fix common/ includes.
4602         * nat/mips-linux-watch.h: Fix common/ includes.
4603         * nat/mips-linux-watch.c: Fix common/ includes.
4604         * nat/linux-waitpid.c: Fix common/ includes.
4605         * nat/linux-ptrace.h: Fix common/ includes.
4606         * nat/linux-ptrace.c: Fix common/ includes.
4607         * nat/linux-procfs.c: Fix common/ includes.
4608         * nat/linux-personality.c: Fix common/ includes.
4609         * nat/linux-osdata.c: Fix common/ includes.
4610         * nat/linux-namespaces.c: Fix common/ includes.
4611         * nat/linux-btrace.h: Fix common/ includes.
4612         * nat/linux-btrace.c: Fix common/ includes.
4613         * nat/fork-inferior.c: Fix common/ includes.
4614         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4615         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4616         * nat/aarch64-linux.c: Fix common/ includes.
4617         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4618         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4619         * namespace.h: Fix common/ includes.
4620         * mips-linux-tdep.c: Fix common/ includes.
4621         * minsyms.c: Fix common/ includes.
4622         * mi/mi-parse.h: Fix common/ includes.
4623         * mi/mi-main.c: Fix common/ includes.
4624         * mi/mi-cmd-env.c: Fix common/ includes.
4625         * memrange.h: Fix common/ includes.
4626         * memattr.c: Fix common/ includes.
4627         * maint.h: Fix common/ includes.
4628         * maint.c: Fix common/ includes.
4629         * main.c: Fix common/ includes.
4630         * machoread.c: Fix common/ includes.
4631         * location.c: Fix common/ includes.
4632         * linux-thread-db.c: Fix common/ includes.
4633         * linux-nat.c: Fix common/ includes.
4634         * linux-fork.c: Fix common/ includes.
4635         * inline-frame.c: Fix common/ includes.
4636         * infrun.c: Fix common/ includes.
4637         * inflow.c: Fix common/ includes.
4638         * inferior.h: Fix common/ includes.
4639         * inferior.c: Fix common/ includes.
4640         * infcmd.c: Fix common/ includes.
4641         * inf-ptrace.c: Fix common/ includes.
4642         * inf-child.c: Fix common/ includes.
4643         * ia64-linux-nat.c: Fix common/ includes.
4644         * i387-tdep.c: Fix common/ includes.
4645         * i386-tdep.c: Fix common/ includes.
4646         * i386-linux-tdep.c: Fix common/ includes.
4647         * i386-linux-nat.c: Fix common/ includes.
4648         * i386-go32-tdep.c: Fix common/ includes.
4649         * i386-fbsd-tdep.c: Fix common/ includes.
4650         * i386-fbsd-nat.c: Fix common/ includes.
4651         * guile/scm-type.c: Fix common/ includes.
4652         * guile/guile.c: Fix common/ includes.
4653         * go32-nat.c: Fix common/ includes.
4654         * gnu-nat.c: Fix common/ includes.
4655         * gdbthread.h: Fix common/ includes.
4656         * gdbarch-selftests.c: Fix common/ includes.
4657         * gdb_usleep.c: Fix common/ includes.
4658         * gdb_select.h: Fix common/ includes.
4659         * gdb_bfd.c: Fix common/ includes.
4660         * gcore.c: Fix common/ includes.
4661         * fork-child.c: Fix common/ includes.
4662         * findvar.c: Fix common/ includes.
4663         * fbsd-nat.c: Fix common/ includes.
4664         * event-top.c: Fix common/ includes.
4665         * event-loop.c: Fix common/ includes.
4666         * dwarf2read.c: Fix common/ includes.
4667         * dwarf2loc.c: Fix common/ includes.
4668         * dwarf2-frame.c: Fix common/ includes.
4669         * dwarf-index-cache.c: Fix common/ includes.
4670         * dtrace-probe.c: Fix common/ includes.
4671         * disasm-selftests.c: Fix common/ includes.
4672         * defs.h: Fix common/ includes.
4673         * csky-tdep.c: Fix common/ includes.
4674         * cp-valprint.c: Fix common/ includes.
4675         * cp-support.h: Fix common/ includes.
4676         * cp-support.c: Fix common/ includes.
4677         * corelow.c: Fix common/ includes.
4678         * completer.h: Fix common/ includes.
4679         * completer.c: Fix common/ includes.
4680         * compile/compile.c: Fix common/ includes.
4681         * compile/compile-loc2c.c: Fix common/ includes.
4682         * compile/compile-cplus-types.c: Fix common/ includes.
4683         * compile/compile-cplus-symbols.c: Fix common/ includes.
4684         * command.h: Fix common/ includes.
4685         * cli/cli-dump.c: Fix common/ includes.
4686         * cli/cli-cmds.c: Fix common/ includes.
4687         * charset.c: Fix common/ includes.
4688         * build-id.c: Fix common/ includes.
4689         * btrace.h: Fix common/ includes.
4690         * btrace.c: Fix common/ includes.
4691         * breakpoint.h: Fix common/ includes.
4692         * breakpoint.c: Fix common/ includes.
4693         * ax.h:
4694         (enum agent_op): Fix common/ includes.
4695         * ax-general.c (struct aop_map): Fix common/ includes.
4696         * ax-gdb.c: Fix common/ includes.
4697         * auxv.c: Fix common/ includes.
4698         * auto-load.c: Fix common/ includes.
4699         * arm-tdep.c: Fix common/ includes.
4700         * arch/riscv.c: Fix common/ includes.
4701         * arch/ppc-linux-common.c: Fix common/ includes.
4702         * arch/i386.c: Fix common/ includes.
4703         * arch/arm.c: Fix common/ includes.
4704         * arch/arm-linux.c: Fix common/ includes.
4705         * arch/arm-get-next-pcs.c: Fix common/ includes.
4706         * arch/amd64.c: Fix common/ includes.
4707         * arch/aarch64.c: Fix common/ includes.
4708         * arch/aarch64-insn.c: Fix common/ includes.
4709         * arch-utils.c: Fix common/ includes.
4710         * amd64-windows-tdep.c: Fix common/ includes.
4711         * amd64-tdep.c: Fix common/ includes.
4712         * amd64-sol2-tdep.c: Fix common/ includes.
4713         * amd64-obsd-tdep.c: Fix common/ includes.
4714         * amd64-nbsd-tdep.c: Fix common/ includes.
4715         * amd64-linux-tdep.c: Fix common/ includes.
4716         * amd64-linux-nat.c: Fix common/ includes.
4717         * amd64-fbsd-tdep.c: Fix common/ includes.
4718         * amd64-fbsd-nat.c: Fix common/ includes.
4719         * amd64-dicos-tdep.c: Fix common/ includes.
4720         * amd64-darwin-tdep.c: Fix common/ includes.
4721         * agent.c: Fix common/ includes.
4722         * ada-lang.h: Fix common/ includes.
4723         * ada-lang.c: Fix common/ includes.
4724         * aarch64-tdep.c: Fix common/ includes.
4725
4726 2019-01-25  Tom Tromey  <tom@tromey.com>
4727
4728         * common/create-version.sh: Use common/version.h.
4729
4730 2019-01-24  Pedro Alves  <palves@redhat.com>
4731
4732         * infrun.c (signal_stop, signal_print, signal_program)
4733         (signal_catch, signal_pass): Now arrays instead of pointers.
4734         (update_signals_program_target, do_target_resume)
4735         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4736         * linux-nat.c (linux_nat_target::pass_signals)
4737         (linux_nat_target::create_inferior, linux_nat_target::attach):
4738         Adjust.
4739         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4740         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4741         * procfs.c (procfs_target::pass_signals): Adjust.
4742         * record-full.c (record_full_target::resume): Adjust.
4743         * remote.c (remote_target::pass_signals)
4744         (remote_target::program_signals): Adjust.
4745         * target-debug.h (target_debug_print_signals): Now takes a
4746         gdb::array_view as parameter.  Adjust.
4747         * target.h (target_ops) <pass_signals, program_signals>: Replace
4748         pointer and length parameters with gdb::array_view.
4749         (target_pass_signals, target_program_signals): Likewise.
4750         * target-delegates.c: Regenerate.
4751
4752 2019-01-24  Pedro Alves  <palves@redhat.com>
4753
4754         * common/forward-scope-exit.h
4755         (forward_scope_exit::forward_scope_exit): Pass arguments to
4756         m_bind_function directly, instead of creating a std::bind and
4757         copying that.
4758
4759 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4760
4761         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4762         for static members.
4763         (pass_in_v_vfp_candidate): Likewise.
4764
4765 2019-01-23  Tom Tromey  <tom@tromey.com>
4766             Pedro Alves  <palves@redhat.com>
4767
4768         * regcache.c (class regcache_invalidator): Remove.
4769         (regcache::raw_write): Use make_scope_exit.
4770
4771 2019-01-23  Tom Tromey  <tom@tromey.com>
4772
4773         * ui-out.h (class ui_out_emit_type): Update comment.
4774
4775 2019-01-23  Tom Tromey  <tom@tromey.com>
4776
4777         * infrun.c (fetch_inferior_event): Update comment.
4778
4779 2019-01-23  Tom Tromey  <tom@tromey.com>
4780             Pedro Alves  <palves@redhat.com>
4781
4782         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4783         parameter.
4784         (fetch_inferior_event): Use SCOPE_EXIT.
4785
4786
4787 2019-01-23  Tom Tromey  <tom@tromey.com>
4788             Pedro Alves  <palves@redhat.com>
4789
4790         * infrun.c (disable_thread_events): Delete.
4791         (stop_all_threads): Use SCOPE_EXIT.
4792
4793 2019-01-23  Tom Tromey  <tom@tromey.com>
4794             Pedro Alves  <palves@redhat.com>
4795
4796         * symfile.c: Include forward-scope-exit.h.
4797         (clear_symtab_users_cleanup): Replace forward declaration with
4798         a FORWARD_SCOPE_EXIT.
4799         (syms_from_objfile_1): Use the forward_scope_exit and
4800         gdb::optional instead of cleanup_function.
4801         (reread_symbols): Use the forward_scope_exit instead of
4802         cleanup_function.
4803         (clear_symtab_users_cleanup): Remove function.
4804
4805 2019-01-23  Tom Tromey  <tom@tromey.com>
4806             Pedro Alves  <palves@redhat.com>
4807
4808         * linux-nat.c: Include scope-exit.h.
4809         (cleanup_target_stop): Remove.
4810         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4811         SCOPE_EXIT.
4812
4813 2019-01-23  Tom Tromey  <tom@tromey.com>
4814             Pedro Alves  <palves@redhat.com>
4815
4816         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4817         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4818
4819 2019-01-23  Tom Tromey  <tom@tromey.com>
4820             Andrew Burgess  <andrew.burgess@embecosm.com>
4821             Pedro Alves  <palves@redhat.com>
4822
4823         * infrun.c (fetch_inferior_event): Use scope_exit.
4824         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4825         * top.c (execute_command): Use scope_exit.
4826         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4827         * utils.c (do_bpstat_clear_actions_cleanup)
4828         (make_bpstat_clear_actions_cleanup): Remove.
4829
4830 2019-01-23  Tom Tromey  <tom@tromey.com>
4831             Pedro Alves  <palves@redhat.com>
4832
4833         * infrun.c: Include "common/scope-exit.h"
4834         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4835         (wait_for_inferior): Use SCOPE_EXIT.
4836         (fetch_inferior_event): Use scope_exit.
4837
4838 2019-01-23  Tom Tromey  <tom@tromey.com>
4839             Pedro Alves  <palves@redhat.com>
4840
4841         * breakpoint.c (create_breakpoint): Remove cleanup.
4842
4843 2019-01-23  Tom Tromey  <tom@tromey.com>
4844             Andrew Burgess  <andrew.burgess@embecosm.com>
4845             Pedro Alves  <palves@redhat.com>
4846
4847 2019-01-23  Pedro Alves  <palves@redhat.com>
4848
4849         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4850
4851 2019-01-23  Pedro Alves  <palves@redhat.com>
4852             Andrew Burgess  <andrew.burgess@embecosm.com>
4853
4854         * gdbthread.h: Include "common/forward-scope-exit.h".
4855         (scoped_finish_thread_state): Redefine custom class in terms of
4856         forward_scope_exit.
4857
4858 2019-01-23  Pedro Alves  <palves@redhat.com>
4859             Andrew Burgess  <andrew.burgess@embecosm.com>
4860
4861         * common/forward-scope-exit.h: New file.
4862
4863 2019-01-23  Pedro Alves  <palves@redhat.com>
4864             Andrew Burgess  <andrew.burgess@embecosm.com>
4865             Tom Tromey  <tom@tromey.com>
4866
4867         * common/scope-exit.h: New file.
4868
4869 2019-01-23  Pedro Alves  <palves@redhat.com>
4870
4871         * common/preprocessor.h (ESC): Rename to ...
4872         (ESC_PARENS): ... this.
4873         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4874         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4875
4876 2019-01-23  Tom Tromey  <tom@tromey.com>
4877
4878         * language.h (class scoped_switch_to_sym_language_if_auto):
4879         Initialize m_lang in both cases.
4880
4881 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4882
4883         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4884         with XCNEW.
4885
4886 2019-01-22  Tom Tromey  <tom@tromey.com>
4887
4888         * corelow.c: Do not include sys/file.h.
4889
4890 2019-01-22  Tom Tromey  <tom@tromey.com>
4891
4892         * tui/tui-wingeneral.h: Include gdb_curses.h.
4893
4894 2019-01-22  Tom Tromey  <tom@tromey.com>
4895
4896         * source-cache.h (class source_cache) <get_source_lines,
4897         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4898
4899 2019-01-22  Tom Tromey  <tom@tromey.com>
4900
4901         * remote-fileio.h (struct remote_target): Declare.
4902
4903 2019-01-22  Tom Tromey  <tom@tromey.com>
4904
4905         * python/py-arch.c: Do not include py-ref.h.
4906         * python/py-bpevent.c: Do not include py-ref.h.
4907         * python/py-cmd.c: Do not include py-ref.h.
4908         * python/py-continueevent.c: Do not include py-ref.h.
4909         * python/py-event.h: Do not include py-ref.h.
4910         * python/py-evtregistry.c: Do not include py-ref.h.
4911         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4912         * python/py-frame.c: Do not include py-ref.h.
4913         * python/py-framefilter.c: Do not include py-ref.h.
4914         * python/py-function.c: Do not include py-ref.h.
4915         * python/py-infevents.c: Do not include py-ref.h.
4916         * python/py-linetable.c: Do not include py-ref.h.
4917         * python/py-objfile.c: Do not include py-ref.h.
4918         * python/py-param.c: Do not include py-ref.h.
4919         * python/py-prettyprint.c: Do not include py-ref.h.
4920         * python/py-progspace.c: Do not include py-ref.h.
4921         * python/py-symbol.c: Do not include py-ref.h.
4922         * python/py-symtab.c: Do not include py-ref.h.
4923         * python/py-type.c: Do not include py-ref.h.
4924         * python/py-unwind.c: Do not include py-ref.h.
4925         * python/py-utils.c: Do not include py-ref.h.
4926         * python/py-value.c: Do not include py-ref.h.
4927         * python/py-varobj.c: Do not include py-ref.h.
4928         * python/py-xmethods.c: Do not include py-ref.h.
4929         * python/python.c: Do not include py-ref.h.
4930         * varobj.c: Do not include py-ref.h.
4931
4932 2019-01-22  Tom Tromey  <tom@tromey.com>
4933
4934         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4935         keyword for bcache.
4936
4937 2019-01-22  Tom Tromey  <tom@tromey.com>
4938
4939         * compile/compile-cplus-types.c: Remove a comment by #include.
4940
4941 2019-01-22  Tom Tromey  <tom@tromey.com>
4942
4943         * compile/gcc-c-plugin.h: Include compile-internal.h.
4944
4945 2019-01-22  Tom Tromey  <tom@tromey.com>
4946
4947         * stabsread.c (EXTERN): Do not define.
4948         (symnum, next_symbol_text_func, processing_gcc_compilation)
4949         (within_function, global_sym_chain, global_stabs)
4950         (previous_stab_code, this_object_header_files)
4951         (n_this_object_header_files)
4952         (n_allocated_this_object_header_files): Define.
4953         * stabsread.h (EXTERN): Never define.  Use "extern".
4954
4955 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4956
4957         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4958         history_value.
4959
4960 2019-01-21  Tom Tromey  <tom@tromey.com>
4961
4962         * ui-out.c: Fix includes.
4963         * tui/tui-source.c: Fix includes.
4964         * target.c: Fix includes.
4965         * remote.c: Fix includes.
4966         * regcache.c: Fix includes.
4967         * python/py-block.c: Fix includes.
4968         * printcmd.c: Fix includes.
4969         * or1k-tdep.c: Fix includes.
4970         * mi/mi-main.c: Fix includes.
4971         * m32r-tdep.c: Fix includes.
4972         * csky-tdep.c: Fix includes.
4973         * compile/compile-cplus-types.c: Fix includes.
4974         * cli/cli-interp.c: Fix includes.
4975
4976 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4977
4978         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4979         for padding.
4980
4981 2019-01-16  Tom Tromey  <tom@tromey.com>
4982
4983         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4984         earlier.
4985         (struct objfile) <msymbols_range>: Move from top level.
4986         <msymbols>: New method.
4987         (class objfile_msymbols): Remove.
4988         * symtab.c (default_collect_symbol_completion_matches_break_on):
4989         Update.
4990         * symmisc.c (dump_msymbols): Update.
4991         * stabsread.c (scan_file_globals): Update.
4992         * objc-lang.c (info_selectors_command, info_classes_command)
4993         (find_methods): Update.
4994         * minsyms.c (find_solib_trampoline_target): Update.
4995         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4996         * coffread.c (coff_symfile_read): Update.
4997         * ada-lang.c (ada_lookup_simple_minsym)
4998         (ada_collect_symbol_completion_matches): Update.
4999
5000 2019-01-16  Tom Tromey  <tom@tromey.com>
5001
5002         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5003         type.  Remove no-argument constructor.
5004         <iterator::operator++>: Simplify.
5005         <begin>: Update.
5006         <end>: Use minimal_symbol_count.
5007
5008 2019-01-16  Tom Tromey  <tom@tromey.com>
5009
5010         * objfiles.h (struct objfile) <psymtabs>: New method.
5011         (class objfile_psymtabs): Remove.
5012         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5013         typedef.
5014         <range>: New method.
5015         (require_partial_symbols): Change return type.
5016         * psymtab.c (require_partial_symbols)
5017         (psym_expand_symtabs_matching): Update.
5018         * mdebugread.c (parse_partial_symbols): Update.
5019         * dbxread.c (dbx_end_psymtab): Update.
5020
5021 2019-01-15  Tom Tromey  <tom@tromey.com>
5022
5023         * symtab.c (lookup_objfile_from_block)
5024         (lookup_symbol_in_objfile_symtabs)
5025         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5026         (find_line_symtab, info_sources_command)
5027         (default_collect_symbol_completion_matches_break_on)
5028         (make_source_files_completion_list): Update.
5029         * symmisc.c (print_objfile_statistics, dump_objfile)
5030         (maintenance_print_symbols, maintenance_info_symtabs)
5031         (maintenance_check_symtabs, maintenance_info_line_tables):
5032         Update.
5033         * source.c (select_source_symtab)
5034         (forget_cached_source_info_for_objfile): Update.
5035         * objfiles.h (class objfile_compunits): Remove.
5036         (struct objfile) <compunits_range>: New typedef.
5037         (compunits): New method.
5038         * objfiles.c (objfile_relocate1): Update.
5039         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5040         * maint.c (count_symtabs_and_blocks): Update.
5041         * linespec.c (iterate_over_all_matching_symtabs): Update.
5042         * cp-support.c (add_symbol_overload_list_qualified): Update.
5043         * coffread.c (coff_symtab_read): Update.
5044         * ada-lang.c (add_nonlocal_symbols)
5045         (ada_collect_symbol_completion_matches)
5046         (ada_add_global_exceptions): Update.
5047
5048 2019-01-15  Tom Tromey  <tom@tromey.com>
5049
5050         * progspace.h (program_space) <objfiles_safe_range>: New
5051         typedef.
5052         <objfiles_safe>: New method.
5053         * objfiles.h (class all_objfiles_safe): Remove.
5054         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5055         * jit.c (jit_inferior_exit_hook): Update.
5056
5057 2019-01-17  Tom Tromey  <tom@tromey.com>
5058
5059         * progspace.h (program_space) <objfiles_range>: New typedef.
5060         <objfiles>: New method.
5061         <objfiles_head>: Rename from objfiles.
5062         (object_files): Update.
5063         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5064         * guile/scm-pretty-print.c
5065         (ppscm_find_pretty_printer_from_objfiles): Update.
5066         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5067         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5068         Update.
5069         * python/py-progspace.c (pspy_get_objfiles): Update.
5070         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5071         Update.
5072         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5073         (objfpy_lookup_objfile_by_build_id): Update.
5074         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5075         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5076         Update.
5077         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5078         (expand_symtab_containing_pc, lookup_objfile_from_block)
5079         (lookup_static_symbol, basic_lookup_transparent_type)
5080         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5081         (find_line_symtab, info_sources_command)
5082         (default_collect_symbol_completion_matches_break_on)
5083         (make_source_files_completion_list, find_main_name): Update.
5084         * symmisc.c (print_symbol_bcache_statistics)
5085         (print_objfile_statistics, maintenance_print_symbols)
5086         (maintenance_print_msymbols, maintenance_print_objfiles)
5087         (maintenance_info_symtabs, maintenance_check_symtabs)
5088         (maintenance_expand_symtabs, maintenance_info_line_tables):
5089         Update.
5090         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5091         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5092         (map_overlay_command, unmap_overlay_command)
5093         (simple_overlay_update, expand_symtabs_matching)
5094         (map_symbol_filenames): Update.
5095         * symfile-debug.c (set_debug_symfile): Update.
5096         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5097         Update.
5098         * source.c (select_source_symtab, forget_cached_source_info):
5099         Update.
5100         * solib.c (solib_read_symbols): Update.
5101         * solib-spu.c (append_ocl_sos): Update.
5102         * psymtab.c (maintenance_print_psymbols)
5103         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5104         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5105         * printcmd.c (info_symbol_command): Update.
5106         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5107         Update.
5108         * objfiles.h (class all_objfiles): Remove.
5109         * objfiles.c (have_partial_symbols, have_full_symbols)
5110         (have_minimal_symbols, qsort_cmp, update_section_map)
5111         (shared_objfile_contains_address_p)
5112         (default_iterate_over_objfiles_in_search_order): Update.
5113         * objc-lang.c (info_selectors_command, info_classes_command)
5114         (find_methods): Update.
5115         * minsyms.c (find_solib_trampoline_target): Update.
5116         * maint.c (maintenance_info_sections)
5117         (maintenance_translate_address, count_symtabs_and_blocks):
5118         Update.
5119         * main.c (captured_main_1): Update.
5120         * linux-thread-db.c (try_thread_db_load_from_pdir)
5121         (has_libpthread): Update.
5122         * linespec.c (iterate_over_all_matching_symtabs)
5123         (search_minsyms_for_name): Update.
5124         * jit.c (jit_find_objf_with_entry_addr): Update.
5125         * hppa-tdep.c (find_unwind_entry)
5126         (hppa_lookup_stub_minimal_symbol): Update.
5127         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5128         Update.
5129         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5130         (elf_gnu_ifunc_resolve_by_got): Update.
5131         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5132         * dwarf-index-write.c (save_gdb_index_command): Update.
5133         * cp-support.c (add_symbol_overload_list_qualified): Update.
5134         * breakpoint.c (create_overlay_event_breakpoint)
5135         (create_longjmp_master_breakpoint)
5136         (create_std_terminate_master_breakpoint)
5137         (create_exception_master_breakpoint): Update.
5138         * blockframe.c (find_pc_partial_function): Update.
5139         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5140         (ada_collect_symbol_completion_matches)
5141         (ada_add_global_exceptions): Update.
5142
5143 2019-01-17  Tom Tromey  <tom@tromey.com>
5144
5145         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5146         declare VEC.
5147         (solib_target_parse_libraries): Change return type.
5148         (library_list_start_segment, library_list_start_section)
5149         (library_list_end_library, library_list_start_library); Update.
5150         (solib_target_free_library_list): Remove.
5151         (solib_target_parse_libraries): Remove cleanup.  Change return
5152         type.
5153         (solib_target_current_sos): Update.
5154
5155 2019-01-17  Tom Tromey  <tromey@bapiya>
5156
5157         * valprint.c: Replace "the the" with "the".
5158         * symtab.c: Replace "the the" with "the".
5159         * solib.c: Replace "the the" with "the".
5160         * solib-dsbt.c: Replace "the the" with "the".
5161         * linespec.c: Replace "the the" with "the".
5162         * dwarf2loc.h: Replace "the the" with "the".
5163         * amd64-windows-tdep.c: Replace "the the" with "the".
5164         * aarch64-tdep.c: Replace "the the" with "the".
5165
5166 2019-01-16  Keith Seitz  <keiths@redhat.com>
5167
5168         PR gdb/23773
5169         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5170         <builder>: Rename to ..
5171         <m_builder>: ... this and make private.
5172         (dwarf2_cu::get_builder): New method.  Change all users of
5173         `builder' to use this method.
5174         (dwarf2_start_symtab): Move to ...
5175         (dwarf2_cu::start_symtab): ... here.  Update all callers
5176         (setup_type_unit_groups): Move to ...
5177         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5178         callers.
5179         (dwarf2_cu::reset_builder): New method.
5180         (process_full_compunit, process_full_type_unit): Use
5181         dwarf2_cu::reset_builder.
5182         (follow_die_offset): Record the ancestor CU if it is different
5183         from the followed DIE's CU.
5184         (follow_die_sig_1): Likewise.
5185
5186 2019-01-15  Tom Tromey  <tom@tromey.com>
5187
5188         * remote.c (class remote_state) <buf>: Now a char_vector.
5189         <buf_size>: Remove.
5190         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5191         parameter.
5192         (remote_target::getpkt_or_notif_sane_1)
5193         (remote_target::getpkt_sane)
5194         (remote_target::getpkt_or_notif_sane): Likewise.
5195         (class remote_target) <putpkt>: New overload.
5196         (remote_target::read_frame): Change type of "buf_p".  Remove
5197         sizeof_p parameter.
5198         (packet_ok): New overload.
5199         (packet_check_result): New overload.
5200         Update all uses.
5201
5202 2019-01-14  Tom Tromey  <tom@tromey.com>
5203
5204         * remote-notif.c (handle_notification, remote_notif_ack)
5205         (remote_notif_parse): Make "buf" const.
5206         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5207         const.
5208         (remote_notif_parse, remote_notif_ack, handle_notification):
5209         Likewise.
5210         * remote.c (remote_notif_stop_parse): Make "buf" const.
5211         (remote_target::remote_parse_stop_reply): Make "buf" const.
5212         (remote_notif_stop_ack): Make "buf" const.
5213
5214 2019-01-14  Tom Tromey  <tom@tromey.com>
5215
5216         * remote.c (remote_console_output): Make parameter const.
5217
5218 2019-01-14  Tom Tromey  <tom@tromey.com>
5219
5220         * target-debug.h (target_debug_print_signals): Constify.
5221         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5222         * procfs.c (procfs_target::pass_signals): Update.
5223         * linux-nat.c (linux_nat_target::pass_signals): Update.
5224         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5225         * target-delegates.c: Rebuild.
5226         * remote.c (remote_target::program_signals): Update.
5227         (remote_target::pass_signals): Update.
5228         * target.c (target_pass_signals): Constify argument.
5229         (target_program_signals): Likewise.
5230         * target.h (struct target_ops) <pass_signals, program_signals>:
5231         Constify argument.
5232         (target_pass_signals, target_program_signals): Constify argument.
5233
5234 2019-01-14  Tom Tromey  <tom@tromey.com>
5235
5236         PR tui/28819:
5237         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5238
5239 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5240
5241         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5242         field.
5243         * rs6000-tdep.c: Include reggroups.h.
5244         (IS_V_ALIAS_PSEUDOREG): Define.
5245         (rs6000_register_name): Return names for the "vX" aliases.
5246         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5247         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5248         aliases.  Call default_register_reggroup_p for all other
5249         pseudo-registers.
5250         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5251         New functions.
5252         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5253         Handle "vX" aliases.
5254         (v_alias_pseudo_register_collect): New function.
5255         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5256         (rs6000_gdbarch_init): Initialize "vX" aliases as
5257         pseudo-registers.  Restore registration of
5258         rs6000_pseudo_register_reggroup_p with
5259         set_tdesc_pseudo_register_reggroup_p.
5260
5261 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5262
5263         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5264         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5265         set_gdbarch_num_pseudo_regs.
5266
5267 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5268
5269         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5270         Remove arg prefixname, add do_set and do_show.
5271         Add member functions set_list and show_list.
5272         * cli/cli-style.c (class cli_style_option): Update accordingly.
5273         (style_set_list): Move to file scope.
5274         (style_show_list): Likewise.
5275         (set_style): Call help_list.
5276         (show_style): Call cmd_show_list.
5277         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5278         Update to use the new macro.
5279
5280 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5281
5282         * ada-lang.c (_initialize_ada_language): Expand the help text
5283         for the "catch exception" command.
5284
5285 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5286
5287         * symtab.c (matching_obj_sections): Initialize obj,
5288         declare it closer to its usage.
5289
5290 2019-01-10  Tom Tromey  <tom@tromey.com>
5291
5292         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5293         (basic_inf_threads_range): Remove.
5294         (inf_threads_range, inf_non_exited_threads_range)
5295         (safe_inf_threads_range): Use next_adapter.
5296
5297 2019-01-10  Keith Seitz  <keiths@redhat.com>
5298
5299         PR gdb/23712
5300         PR symtab/23010
5301         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5302         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5303
5304 2019-01-10  Keith Seitz  <keiths@redhat.com>
5305
5306         PR gdb/23712
5307         PR symtab/23010
5308         * dictionary.c (pending_to_vector): Remove.
5309         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5310         Remove _1 suffix, replacing functions of the same name.  Update
5311         all callers.
5312         (dict_create_hashed, dict_create_hashed_expandable)
5313         (dict_create_linear, dict_create_linear_expandable, dict_free)
5314         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5315         Make functions static.
5316
5317 2019-01-10  Keith Seitz  <keiths@redhat.com>
5318
5319         PR gdb/23712
5320         PR symtab/23010
5321         * dictionary.h (struct dictionary): Replace declaration with
5322         multidictionary.
5323         (dict_create_hashed, dict_create_hashed_expandable)
5324         (dict_create_linear, dict_create_linear_expandable)
5325         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5326         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5327         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5328         taking multidictionary argument.
5329         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5330         * block.h (struct block) <dict>: Change to multidictionary
5331         and rename `multidict'.
5332         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5333         symmisc.c: Update all dictionary references to multidictionary.
5334
5335 2019-01-10  Keith Seitz  <keiths@redhat.com>
5336
5337         PR gdb/23712
5338         PR symtab/23010
5339         * dictionary.c: Include unordered_map.
5340         (pending_to_vector): New function.
5341         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5342         Rewrite the non-"_1" functions to take vector instead
5343         of linked list.
5344         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5345         "new" _1 versions of the same name.
5346         (multidictionary): Define.
5347         (std::hash<enum language): New definition.
5348         (collate_pending_symbols_by_language, mdict_create_hashed)
5349         (mdict_create_hashed_expandable, mdict_create_linear)
5350         (mdict_create_linear_expandable, mdict_free)
5351         (find_language_dictionary, create_new_language_dictionary)
5352         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5353         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5354         (mdict_size, mdict_empty): New functions.
5355         * dictionary.h (mdict_iterator): Define.
5356
5357 2019-01-10  Pedro Alves  <palves@redhat.com>
5358
5359         * breakpoint.c (read_uploaded_action)
5360         (create_tracepoint_from_upload): Adjust to use
5361         gdb::unique_xmalloc_ptr.
5362         * ctf.c (ctf_write_uploaded_tp):
5363         (SET_ARRAY_FIELD): Use emplace_back.
5364         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5365         * tracefile-tfile.c (tfile_write_uploaded_tp):
5366         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5367         gdb::unique_xmalloc_ptr.
5368         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5369         at_string, cond_string, cmd_strings>: Replace char pointers
5370         with gdb::unique_xmalloc_ptr.
5371
5372 2019-01-10  Pedro Alves  <palves@redhat.com>
5373
5374         * solib-target.c (library_list_start_library): Don't xstrdup name.
5375
5376 2019-01-10  Pedro Alves  <palves@redhat.com>
5377
5378         * mdebugread.c (parse_partial_symbols): Use
5379         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5380
5381 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5382
5383         * linux-fork.c (scoped_switch_fork_info)
5384         <~scoped_switch_fork_info>: Fix incorrect variable name.
5385
5386 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5387
5388         * linux-fork.c (scoped_switch_fork_info)
5389         <scoped_switch_fork_info>: Make explicit.
5390         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5391
5392 2019-01-10  Tom Tromey  <tom@tromey.com>
5393
5394         * objfiles.h (objfile::reset_psymtabs): Update.
5395         * objfiles.c (objfile::objfile): Update.
5396         * psymtab.h (psymtab_storage::obstack): Update.
5397         (psymtab_storage::m_obstack): Use gdb::optional.
5398         (class psymtab_storage): Update comment.  Remove objfile
5399         parameter.
5400         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5401
5402 2019-01-10  Tom Tromey  <tom@tromey.com>
5403
5404         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5405         <free_psymtabs>: Now private.
5406         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5407         (allocate_psymtab): Use new method.
5408
5409 2019-01-10  Tom Tromey  <tom@tromey.com>
5410
5411         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5412         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5413         * mdebugread.c (parse_partial_symbols): Use
5414         allocate_dependencies.
5415         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5416         allocate_dependencies.
5417         (process_psymtab_comp_unit_reader)
5418         (build_type_psymtab_dependencies): Likewise.
5419         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5420
5421 2019-01-10  Tom Tromey  <tom@tromey.com>
5422
5423         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5424         PSYMBOL_SET_LANGUAGE.
5425         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5426
5427 2019-01-10  Tom Tromey  <tom@tromey.com>
5428
5429         * psymtab.h (psymtab_storage::obstack): New method.
5430         <m_obstack>: Rename from obstack; now private.
5431         * psymtab.c (psymtab_storage): Update.
5432         * dwarf2read.c (create_addrmap_from_index)
5433         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5434         Update.
5435
5436 2019-01-10  Tom Tromey  <tom@tromey.com>
5437
5438         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5439         * objfiles.h (objfile::reset_psymtabs): New method.
5440
5441 2019-01-10  Tom Tromey  <tom@tromey.com>
5442
5443         * symmisc.c (print_symbol_bcache_statistics): Update.
5444         (print_objfile_statistics): Update.
5445         * symfile.c (reread_symbols): Update.
5446         * psymtab.h (class psymtab_storage): New.
5447         * psymtab.c (psymtab_storage): New constructor.
5448         (~psymtab_storage): New destructor.
5449         (require_partial_symbols): Update.
5450         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5451         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5452         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5453         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5454         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5455         (start_psymtab_common, end_psymtab_common)
5456         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5457         (allocate_psymtab): Update.
5458         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5459         Update.
5460         (dump_psymtab_addrmap, maintenance_print_psymbols)
5461         (maintenance_check_psymtabs): Update.
5462         (class objfile_psymtabs): Move to objfiles.h.
5463         * psympriv.h (discard_psymtab): Now inline.
5464         (psymtab_discarder::psymtab_discarder): Update.
5465         (psymtab_discarder::~psymtab_discarder): Update.
5466         (ALL_OBJFILE_PSYMTABS): Rewrite.
5467         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5468         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5469         Remove fields.
5470         <partial_symtabs>: New field.
5471         (class objfile_psymtabs): Move from psymtab.h.  Update.
5472         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5473         psymbol_cache.
5474         (objfile::~objfile): Don't destroy psymbol_cache.
5475         * mdebugread.c (parse_partial_symbols): Update.
5476         * dwarf2read.c (create_addrmap_from_index)
5477         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5478         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5479         (add_partial_subprogram, dwarf2_ranges_read): Update.
5480         * dwarf-index-write.c (write_address_map)
5481         (write_one_signatured_type, recursively_write_psymbols)
5482         (class debug_names, class debug_names, write_psymtabs_to_index):
5483         Update.
5484
5485 2019-01-10  Tom Tromey  <tom@tromey.com>
5486
5487         * symtab.h (SYMBOL_SET_NAMES): Update.
5488         (symbol_set_names): Update.
5489         (MSYMBOL_SET_NAMES): Update.
5490         * symtab.c (symbol_set_names): Change argument to be an
5491         objfile_per_bfd_storage.
5492         * psymtab.c (add_psymbol_to_bcache): Update.
5493         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5494
5495 2019-01-10  Tom Tromey  <tom@tromey.com>
5496
5497         * symtab.c (create_demangled_names_hash): Change argument to be an
5498         objfile_per_bfd_storage.
5499         (symbol_set_names): Update.
5500
5501 2019-01-10  Tom Tromey  <tom@tromey.com>
5502
5503         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5504         init_psymbol_list.
5505         * psymtab.c (init_psymbol_list): Do nothing if already called.
5506         * psympriv.h (init_psymbol_list): Add comment.
5507         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5508         init_psymbol_list.
5509         * dbxread.c (dbx_symfile_read): Unconditionally call
5510         init_psymbol_list.
5511
5512 2019-01-10  Tom Tromey  <tom@tromey.com>
5513
5514         * xcoffread.c (scan_xcoff_symtab): Update.
5515         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5516         "where".
5517         * mdebugread.c (parse_partial_symbols)
5518         (handle_psymbol_enumerators): Update.
5519         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5520         * dbxread.c (read_dbx_symtab): Update.
5521         * psympriv.h (psymbol_placement): New enum.
5522         (add_psymbol_to_list): Update.
5523
5524 2019-01-10  Tom Tromey  <tom@tromey.com>
5525
5526         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5527         static_psymbols parameters.
5528         (scan_xcoff_symtab): Update.
5529         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5530         static_psymbols parameters.
5531         * psympriv.h (start_psymtab_common): Update.
5532         * mdebugread.c (parse_partial_symbols): Update.
5533         * dwarf2read.c (create_partial_symtab): Update.
5534         * dbxread.c (read_dbx_symtab): Update.
5535         (start_psymtab): Remove global_psymbols and static_psymbols
5536         parameters.
5537
5538 2019-01-10  Tom Tromey  <tom@tromey.com>
5539
5540         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5541         * psymtab.c (allocate_psymtab): Add comment.
5542         * psympriv.h (allocate_psymtab): Add comment.
5543         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5544         initializations.
5545         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5546
5547 2019-01-10  Tom Tromey  <tom@tromey.com>
5548
5549         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5550         Don't declare.
5551         * mipsread.c: Include mdebugread.h.
5552         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5553         Declare.
5554         * elfread.c: Include mdebugread.h.
5555
5556 2019-01-09  Tom Tromey  <tom@tromey.com>
5557
5558         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5559         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5560         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5561         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5562         (psym_lookup_symbol, psym_find_last_source_symtab)
5563         (psym_forget_cached_source_info, psym_print_stats)
5564         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5565         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5566         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5567         (psym_find_compunit_symtab_by_address)
5568         (maintenance_print_psymbols, maintenance_info_psymtabs)
5569         (maintenance_check_psymtabs): Use ranged for.
5570         * psymtab.h (class objfile_psymtabs): New.
5571         (require_partial_symbols): Return objfile_psymtabs.
5572         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5573
5574 2019-01-09  Tom Tromey  <tom@tromey.com>
5575
5576         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5577         (find_pc_mapped_section, list_overlays_command)
5578         (map_overlay_command, unmap_overlay_command)
5579         (simple_overlay_update): Use all_objfiles.
5580         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5581         * printcmd.c (info_symbol_command): Use all_objfiles.
5582         * objfiles.h (ALL_OBJSECTIONS): Remove.
5583         * maint.c (maintenance_translate_address): Use all_objfiles.
5584         * gcore.c (gcore_create_callback): Use all_objfiles.
5585         (objfile_find_memory_regions): Likewise.
5586
5587 2019-01-09  Tom Tromey  <tom@tromey.com>
5588
5589         * symtab.c (find_line_symtab, info_sources_command)
5590         (make_source_files_completion_list): Use objfile_compunits.
5591         * source.c (select_source_symtab): Use objfile_compunits.
5592         * objfiles.h (struct objfile): Update comment.
5593         (ALL_OBJFILES): Remove.
5594         (ALL_FILETABS): Remove.
5595         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5596         objfile_compunits.
5597
5598 2019-01-09  Tom Tromey  <tom@tromey.com>
5599
5600         * symmisc.c (print_objfile_statistics, dump_objfile)
5601         (maintenance_print_symbols): Use compunit_filetabs.
5602         * source.c (forget_cached_source_info_for_objfile): Use
5603         compunit_filetabs.
5604         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5605         (ALL_FILETABS): Use compunit_filetabs.
5606         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5607         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5608
5609 2019-01-09  Tom Tromey  <tom@tromey.com>
5610
5611         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5612         (compunit_filetabs): New.
5613         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5614         compunit_filetabs.
5615         (info_sources_command, make_source_files_completion_list): Remove
5616         declaration.
5617         * symmisc.c (print_objfile_statistics, dump_objfile)
5618         (maintenance_print_symbols): Remove declaration.
5619         (maintenance_info_symtabs): Use compunit_filetabs.
5620         (maintenance_info_line_tables): Likewise.
5621         * source.c (select_source_symtab): Change local variable name.
5622         (forget_cached_source_info_for_objfile): Remove declaration.
5623         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5624         * objfiles.c (objfile_relocate1): Remove declaration.
5625         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5626         declaration.
5627         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5628         * coffread.c (coff_symtab_read): Remove declaration.
5629         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5630         compunit_filetabs.
5631
5632 2019-01-09  Tom Tromey  <tom@tromey.com>
5633
5634         * symtab.c (lookup_objfile_from_block)
5635         (find_pc_sect_compunit_symtab, search_symbols)
5636         (default_collect_symbol_completion_matches_break_on): Use
5637         objfile_compunits.
5638         * objfiles.h (ALL_COMPUNITS): Remove.
5639         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5640         * cp-support.c (add_symbol_overload_list_qualified): Use
5641         objfile_compunits.
5642         * ada-lang.c (ada_collect_symbol_completion_matches)
5643         (ada_add_global_exceptions): Use objfile_compunits.
5644
5645 2019-01-09  Tom Tromey  <tom@tromey.com>
5646
5647         * source.c (select_source_symtab)
5648         (forget_cached_source_info_for_objfile): Remove declaration.
5649         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5650         declaration.
5651         * maint.c (count_symtabs_and_blocks): Remove declaration.
5652         * cp-support.c (add_symbol_overload_list_qualified): Remove
5653         declaration.
5654         * coffread.c (coff_symtab_read): Remove declaration.
5655         * symtab.c (lookup_symbol_in_objfile_symtabs)
5656         (basic_lookup_transparent_type_1): Use objfile_compunits.
5657         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5658         (info_sources_command, search_symbols)
5659         (default_collect_symbol_completion_matches_break_on)
5660         (make_source_files_completion_list): Remove declaration.
5661         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5662         (ada_collect_symbol_completion_matches)
5663         (ada_add_global_exceptions): Remove declaration.
5664         * linespec.c (iterate_over_all_matching_symtabs): Use
5665         objfile_compunits.
5666         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5667         (class objfile_compunits): New.
5668         (ALL_COMPUNITS): Use objfile_compunits.
5669         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5670         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5671         objfile_compunits.
5672         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5673
5674 2019-01-09  Tom Tromey  <tom@tromey.com>
5675
5676         * symtab.c (search_symbols)
5677         (default_collect_symbol_completion_matches_break_on): Use
5678         objfile_msymbols.
5679         * ada-lang.c (ada_lookup_simple_minsym)
5680         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5681         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5682         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5683         objfile_msymbols.
5684         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5685         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5686         * objc-lang.c (find_methods): Use objfile_msymbols.
5687         (info_selectors_command, info_classes_command): Likewise.
5688         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5689         * objfiles.h (class objfile_msymbols): New.
5690         (ALL_OBJFILE_MSYMBOLS): Remove.
5691         (ALL_MSYMBOLS): Remove.
5692
5693 2019-01-09  Tom Tromey  <tom@tromey.com>
5694
5695         * common/next-iterator.h (next_adapter): Add Iterator template
5696         parameter.
5697         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5698         (class all_objfiles_safe): New.
5699         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5700         * objfiles.c (put_objfile_before): Update comment.
5701         (add_separate_debug_objfile): Likewise.
5702         (free_all_objfiles): Use all_objfiles_safe.
5703         (objfile_purge_solibs): Likewise.
5704
5705 2019-01-09  Tom Tromey  <tom@tromey.com>
5706
5707         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5708         (expand_symtab_containing_pc, lookup_static_symbol)
5709         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5710         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5711         all_objfiles.
5712         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5713         * breakpoint.c (create_overlay_event_breakpoint)
5714         (create_longjmp_master_breakpoint)
5715         (create_std_terminate_master_breakpoint)
5716         (create_exception_master_breakpoint): Use all_objfiles.
5717         * linux-thread-db.c (try_thread_db_load_from_pdir)
5718         (has_libpthread): Use all_objfiles.
5719         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5720         * linespec.c (iterate_over_all_matching_symtabs)
5721         (search_minsyms_for_name): Use all_objfiles.
5722         * maint.c (maintenance_info_sections): Use all_objfiles.
5723         * main.c (captured_main_1): Use all_objfiles.
5724         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5725         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5726         * guile/scm-pretty-print.c
5727         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5728         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5729         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5730         (maintenance_print_msymbols): Use all_objfiles.
5731         * source.c (select_source_symtab): Use all_objfiles.
5732         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5733         * symfile.c (remove_symbol_file_command)
5734         (expand_symtabs_matching, map_symbol_filenames): Use
5735         all_objfiles.
5736         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5737         all_objfiles.
5738         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5739         * objc-lang.c (find_methods): Use all_objfiles.
5740         * objfiles.c (have_partial_symbols, have_full_symbols)
5741         (have_minimal_symbols, qsort_cmp)
5742         (default_iterate_over_objfiles_in_search_order): Use
5743         all_objfiles.
5744         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5745         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5746         (maintenance_check_psymtabs): Use all_objfiles.
5747         (ALL_PSYMTABS): Remove.
5748         * compile/compile-object-run.c (do_module_cleanup): Use
5749         all_objfiles.
5750         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5751         * cp-support.c (add_symbol_overload_list_qualified): Use
5752         all_objfiles.
5753         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5754         Use all_objfiles.
5755         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5756         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5757         all_objfiles.
5758         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5759         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5760         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5761         Uses all_objfiles.
5762         * solib.c (solib_read_symbols): Use all_objfiles
5763
5764 2019-01-09  Tom Tromey  <tom@tromey.com>
5765
5766         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5767         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5768         all_objfiles.
5769         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5770         * symmisc.c (print_symbol_bcache_statistics)
5771         (print_objfile_statistics, maintenance_print_objfiles)
5772         (maintenance_info_symtabs, maintenance_check_symtabs)
5773         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5774         all_objfiles.
5775         * source.c (forget_cached_source_info): Use all_objfiles.
5776         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5777         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5778         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5779         * objfiles.c (update_section_map): Use all_objfiles.
5780         (shared_objfile_contains_address_p): Likewise.
5781         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5782         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5783
5784 2019-01-09  Tom Tromey  <tom@tromey.com>
5785
5786         * common/next-iterator.h: New file.
5787         * objfiles.h (class all_objfiles): New.
5788         (struct objfile_iterator): New.
5789
5790 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5791
5792         * NEWS: Move the description of the changed "frame", "select-frame",
5793          and "info frame" commands to the Changed commands section.
5794
5795 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5796
5797         * gdbtypes.c (check_stub_method_group): Remove handling of old
5798         mangling schemes.
5799         * linespec.c (find_methods): Likewise.
5800         * stabsread.c (read_member_functions): Likewise.
5801         * valops.c (search_struct_method): Likewise.
5802         (value_struct_elt_for_reference): Likewise.
5803         * NEWS: Mention this change.
5804
5805 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5806
5807         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5808         print_source_lines.
5809         * source.c (print_source_lines_base): Update line number check.
5810         (print_source_lines): New function.
5811         (source_lines_range::source_lines_range): New function.
5812         * source.h (class source_lines_range): New class.
5813         (print_source_lines): New declaration.
5814
5815 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5816
5817         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5818
5819 2019-01-08  Tom Tromey  <tom@tromey.com>
5820             Simon Marchi  <simon.marchi@ericsson.com>
5821
5822         PR gdb/24060
5823         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5824         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5825         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5826         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5827         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5828         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5829
5830 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5831
5832         * source.c (select_source_symtab): Move header comment to
5833         declaration in source.h.
5834         (forget_cached_source_info_for_objfile): Likewise.
5835         (forget_cached_source_info): Likewise.
5836         (identify_source_line): Likewise.
5837         * source.h (identify_source_line): Move declaration from symtab.h
5838         and add comment from source.c
5839         (print_source_lines): Likewise.
5840         (forget_cached_source_info_for_objfile): Likewise.
5841         (forget_cached_source_info): Likewise.
5842         (select_source_symtab): Likewise.
5843         (enum print_source_lines_flag): Move definition from symtab.h.
5844         * symtab.h (identify_source_line): Move declaration to source.h.
5845         (print_source_lines): Likewise.
5846         (forget_cached_source_info_for_objfile): Likewise.
5847         (forget_cached_source_info): Likewise.
5848         (select_source_symtab): Likewise.
5849         (enum print_source_lines_flag): Move definition to source.h.
5850         * tui/tui-hooks.c: Add 'source.h' include.
5851
5852 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5853
5854         * source.c (print_source_lines_base): Handle requests to print
5855         reverse line number sequences, and guard against empty lines
5856         string.
5857
5858 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5859
5860         * source.c (print_source_lines_base): Fix skip of '\r' if next
5861         character is '\n'.
5862
5863 2019-01-06  Tom Tromey  <tom@tromey.com>
5864
5865         * c-exp.y (struct c_parse_state) <macro_original_text,
5866         expansion_obstack>: New member.
5867         (macro_original_text, expansion_obstack): Remove globals.
5868         (scan_macro_expansion, scanning_macro_expansion)
5869         (finished_macro_expansion): Update.
5870         (scan_macro_cleanup): Remove.
5871         (yylex, c_parse): Update.
5872
5873 2019-01-06  Tom Tromey  <tom@tromey.com>
5874
5875         * c-exp.y (struct c_parse_state) <strings>: New member.
5876         (operator_stoken): Update.
5877
5878 2019-01-06  Tom Tromey  <tom@tromey.com>
5879
5880         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5881         (union type_stack_elt) <typelist_val>: Now a pointer to
5882         std::vector.
5883         (type_stack_cleanup): Don't declare.
5884         (push_typelist): Update.
5885         * parse.c (pop_typelist): Return a std::vector.
5886         (push_typelist): Take a std::vector.
5887         (follow_types): Update.  Do not free args.
5888         (type_stack_cleanup): Remove.
5889         * c-exp.y (struct c_parse_state): New.
5890         (cpstate): New global.
5891         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5892         (nonempty_typelist): Update.
5893         (func_mod): Create a new vector.
5894         (c_parse): Create a c_parse_state.
5895         (check_parameter_typelist): Do not delete params.
5896         (function_method): Update.  Do not delete type_list.
5897
5898 2019-01-06  Tom Tromey  <tom@tromey.com>
5899
5900         PR gdb/28155:
5901         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5902         check_typedef.
5903         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5904         (print_return_value): Likewise.
5905
5906 2019-01-05  Tom Tromey  <tom@tromey.com>
5907
5908         * contrib/cleanup_check.py: Remove.
5909         * contrib/gcc-with-excheck: Remove.
5910         * contrib/exsummary.py: Remove.
5911         * contrib/excheck.py: Remove.
5912
5913 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5914
5915         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5916         NULL. Initialize tpprev to NULL instead of assigning it
5917         to NULL on the next statement.
5918         * windows-nat.c (windows_delete_thread): Remove check for
5919         main_thread_id before printing thread exit notifications.
5920         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5921         Remove thread ID check against main_thread_id.
5922         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5923         windows_delete_thread.
5924         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5925
5926 2019-01-04  Tom Tromey  <tom@tromey.com>
5927
5928         * compile/compile.c (_initialize_compile): Use upper case for
5929         metasyntactic variables.
5930         * symmisc.c (_initialize_symmisc): Use upper case for
5931         metasyntactic variables.
5932         * psymtab.c (_initialize_psymtab): Use upper case for
5933         metasyntactic variables.
5934         * demangle.c (demangle_command): Use upper case for metasyntactic
5935         variables.
5936         (_initialize_demangler): Likewise.
5937         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5938         variables.
5939
5940 2019-01-03  Tom Tromey  <tom@tromey.com>
5941
5942         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5943
5944 2019-01-03  Tom Tromey  <tom@tromey.com>
5945
5946         * python/py-symtab.c (salpy_str): Update.
5947         (struct salpy_sal_object) <symtab>: Now a PyObject.
5948         (salpy_dealloc): Update.
5949         (del_objfile_sal): Use gdbpy_ref.
5950
5951 2019-01-03  Tom Tromey  <tom@tromey.com>
5952
5953         * python/py-type.c (convert_field): Use new_reference.  Return
5954         gdbpy_ref.
5955         (make_fielditem): Return gdbpy_ref.
5956         (typy_fields): Update.
5957         (typy_getitem): Update.
5958         (field_name): Return gdbpy_ref.  Use new_reference.
5959         (typy_iterator_iternext): Update.
5960
5961 2019-01-03  Tom Tromey  <tom@tromey.com>
5962
5963         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5964
5965 2019-01-03  Tom Tromey  <tom@tromey.com>
5966
5967         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5968         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5969         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5970         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5971         (pspy_set_type_printers): Likewise.
5972         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5973         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5974         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5975         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5976         (objfpy_set_type_printers): Likewise.
5977
5978 2019-01-03  Tom Tromey  <tom@tromey.com>
5979
5980         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5981         (gdbpy_print_stack): Use gdbpy_err_fetch.
5982         * python/python-internal.h (class gdbpy_err_fetch): New class.
5983         (class gdbpy_enter) <m_error_type, m_error_value,
5984         m_error_traceback>: Remove.
5985         <m_error>: New member.
5986         (gdbpy_exception_to_string): Don't declare.
5987         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5988         * python/py-value.c (convert_value_from_python): Use
5989         gdbpy_err_fetch.
5990         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5991         gdbpy_exception_to_string.
5992         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5993         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5994         gdbpy_err_fetch.
5995
5996 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * linux-nat.c (delete_lwp_cleanup): Delete.
5999         (struct lwp_deleter): New struct.
6000         (lwp_info_up): New typedef.
6001         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6002         lwp_info_up.
6003
6004 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * linux-fork.c (class scoped_switch_fork_info): New class.
6007         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6008
6009 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6010
6011         * valops.c (find_overload_match): Remove use of null_cleanup, and
6012         calls to do_cleanups.
6013
6014 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6015
6016         * compile/compile-cplus-types.c
6017         (compile_cplus_instance::decl_name): Handle changes to
6018         cp_func_name.
6019         * cp-support.c (cp_func_name): Update header comment, update
6020         return type.
6021         * cp-support.h (cp_func_name): Update return type in declaration.
6022         * valops.c (find_overload_match): Move temp_func local to top
6023         level of function and change its type.  Use temp_func to hold and
6024         delete temporary string obtained from cp_func_name.
6025
6026 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6027
6028         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6029         gdb::char_vector, remove cleanup, and update uses of `msg`.
6030
6031 2019-01-03  Jim Wilson  <jimw@sifive.com>
6032
6033         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6034
6035 2019-01-02  Tom Tromey  <tom@tromey.com>
6036
6037         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6038         (tdesc_parse_xml): Remove cleanups.
6039         * target-descriptions.h (make_cleanup_free_target_description):
6040         Don't declare.
6041         (target_desc_deleter): New struct.
6042         (target_desc_up): New typedef.
6043         * target-descriptions.c (target_desc_deleter::operator()): Rename
6044         from free_target_description.
6045         (make_cleanup_free_target_description): Remove.
6046
6047 2019-01-02  Tom Tromey  <tom@tromey.com>
6048
6049         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6050         constructor, destructor.
6051         (linespec_parser): Remove typedef.
6052         (~linespec_parser): Rename from linespec_parser_delete.
6053         (linespec_lex_to_end, linespec_complete_label)
6054         (linespec_complete): Update.
6055         (decode_line_full): Remove cleanups.
6056         (decode_line_1): Update.
6057
6058 2019-01-02  Tom Tromey  <tom@tromey.com>
6059
6060         * python/python-internal.h (inferior_to_inferior_object): Change
6061         return type.
6062         * python/py-exitedevent.c (create_exited_event_object): Update.
6063         * python/py-inferior.c (inferior_to_inferior_object): Return
6064         gdbpy_ref.
6065         (python_new_inferior, python_inferior_deleted)
6066         (thread_to_thread_object, delete_thread_object)
6067         (build_inferior_list, gdbpy_selected_inferior): Update.
6068         * python/py-infthread.c (create_thread_object): Update.  Also fail
6069         if inferior_to_inferior_object fails.
6070
6071 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6072
6073         * inferior.h (class inferior) <displaced_step_state>: New field.
6074         * infrun.h (struct displaced_step_state): Move here from
6075         infrun.c.  Initialize fields, add constructor.
6076         <inf>: Remove field.
6077         <reset>: New method.
6078         * infrun.c (struct displaced_step_inferior_state): Move to
6079         infrun.h.
6080         (displaced_step_inferior_states): Remove.
6081         (get_displaced_stepping_state): Adust.
6082         (displaced_step_in_progress_any_inferior): Adjust.
6083         (displaced_step_in_progress_thread): Adjust.
6084         (displaced_step_in_progress): Adjust.
6085         (add_displaced_stepping_state): Remove.
6086         (get_displaced_step_closure_by_addr): Adjust.
6087         (remove_displaced_stepping_state): Remove.
6088         (infrun_inferior_exit): Call displaced_step_state.reset.
6089         (use_displaced_stepping): Don't check for NULL.
6090         (displaced_step_prepare_throw): Call
6091         get_displaced_stepping_state.
6092         (displaced_step_fixup): Don't check for NULL.
6093         (prepare_for_detach): Don't check for NULL.
6094
6095 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6096
6097         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6098          in case of call that did not complete.
6099
6100 2019-01-02  Andrey Utkin  <autkin@undo.io>
6101
6102         * symfile.c (find_separate_debug_file): Fix search of debug files for
6103         remote debuggee.
6104
6105 2019-01-02  Tom Tromey  <tom@tromey.com>
6106
6107         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6108         indentation.
6109         * python/py-frame.c (frapy_older): Remove cast.
6110         (frapy_newer): Likewise.
6111         * python/py-breakpoint.c (local_setattro): Remove cast.
6112         * python/py-arch.c (archpy_name): Remove local variable.
6113         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6114
6115 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6116
6117         * unittests/basic_string_view/element_access/char/empty.cc:
6118         Fix year range in copyright header.
6119
6120 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6121
6122         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6123         Delete.
6124         <operator==>: Update with for removed field.
6125         <hash>: Likewise.
6126         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6127         <isa_features>: ...this.
6128         <abi_features>: New field.
6129         (riscv_isa_flen): Update comment.
6130         (riscv_abi_xlen): New declaration.
6131         (riscv_abi_flen): New declaration.
6132         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6133         isa_features.
6134         (riscv_abi_xlen): New function.
6135         (riscv_isa_flen): Update to get answer from isa_features.
6136         (riscv_abi_flen): New function.
6137         (riscv_has_fp_abi): Update to get answer from abi_features.
6138         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6139         xlen and flen.
6140         (riscv_call_info) <xlen, flen>: Update comment.
6141         (riscv_call_arg_struct): Remove invalid assertions
6142         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6143         is removed.
6144         (riscv_gdbarch_init): Gather isa features and abi features
6145         separately, ensure both match on the gdbarch when reusing an old
6146         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6147         a target with 64-bit float hardware.
6148
6149 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6150
6151         * source.c (search_command_helper): Stop reverse search
6152         when line 1 has been searched.
6153
6154 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6155
6156         * record-full.c (record_full_base_target::close): Rewrite
6157         record_full_core_buf_list free logic.
6158
6159 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6160
6161         * break-catch-syscall.c (print_one_catch_syscall): xfree
6162         the last text.
6163
6164 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6165
6166         * top.c (print_gdb_version): Update Copyright year in version
6167         message.
6168
6169 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6170
6171         Update copyright year range in all GDB files.
6172
6173 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6174
6175         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6176
6177 For older changes see ChangeLog-2018.
6178 \f
6179 Local Variables:
6180 mode: change-log
6181 left-margin: 8
6182 fill-column: 74
6183 version-control: never
6184 coding: utf-8
6185 End:
6186