gdb/ChangeLog

   1 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
   4
   5 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
   6
   7         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
   8         displaced_step_closure_up.
   9         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
  10         (struct displaced_step_closure_up):
  11         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
  12         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
  13         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
  14         Likewise.
  15         * gdbarch.sh (displaced_step_copy_insn): Likewise.
  16         * gdbarch.c, gdbarch.h: Re-generate.
  17         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
  18         displaced_step_closure_up.
  19         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
  20         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
  21         * infrun.h (displaced_step_closure_up): New type alias.
  22         (struct displaced_step_inferior_state) <step_closure>: Change
  23         type to displaced_step_closure_up.
  24         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
  25         displaced_step_closure_up.
  26         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
  27
  28 2020-02-14  Tom Tromey  <tom@tromey.com>
  29
  30         * minidebug.c (gnu_debug_key): New global.
  31         (find_separate_debug_file_in_section): Use it.
  32
  33 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
  34
  35         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
  36         std::unique_ptr.
  37         * gdbarch.c: Re-generate.
  38         * gdbarch.h: Re-generate.
  39         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
  40         change.
  41         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
  42         type to std::unique_ptr.
  43         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
  44         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
  45         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
  46         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
  47         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
  48         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
  49         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
  50         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
  51         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
  52
  53 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
  54
  55         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
  56         std::unique_ptr.
  57         (displaced_step_clear): Rename to...
  58         (displaced_step_reset): ... this.  Just call displaced->reset ().
  59         (displaced_step_clear_cleanup): Rename to...
  60         (displaced_step_reset_cleanup): ... this.
  61         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
  62         (displaced_step_fixup): Likewise.
  63         (resume_1): Likewise.
  64         (handle_inferior_event): Restore child's memory before calling
  65         displaced_step_fixup on the parent.
  66         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
  67         to std::unique_ptr.
  68         <step_closure>: Change type to std::unique_ptr.
  69
  70 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
  71
  72         * arm-tdep.c: Include count-one-bits.h.
  73         (cleanup_block_store_pc): Use count_one_bits.
  74         (cleanup_block_load_pc): Use count_one_bits.
  75         (arm_copy_block_xfer): Use count_one_bits.
  76         (thumb2_copy_block_xfer): Use count_one_bits.
  77         (thumb_copy_pop_pc_16bit): Use count_one_bits.
  78         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
  79         (thumb_get_next_pcs_raw): Use count_one_bits.
  80         (arm_get_next_pcs_raw): Use count_one_bits_l.
  81         * arch/arm.c (bitcount): Remove.
  82         * arch/arm.h (bitcount): Remove.
  83
  84 2020-02-14  Tom Tromey  <tromey@adacore.com>
  85
  86         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
  87         Update.
  88         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
  89         * dwarf2/loc.c (call_site_find_chain_1): Return
  90         unique_xmalloc_ptr.
  91         (call_site_find_chain): Likewise.
  92
  93 2020-02-14  Richard Biener  <rguenther@suse.de>
  94
  95         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
  96         on expression with division operators.
  97
  98 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
  99
 100         * MAINTAINERS (Write After Approval): Adding myself.
 101
 102 2020-02-12  Tom Tromey  <tom@tromey.com>
 103
 104         * event-loop.c (event_data, gdb_event, event_handler_func):
 105         Remove.
 106
 107 2020-02-12  Tom Tromey  <tom@tromey.com>
 108
 109         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
 110         (dwarf2_frame_objfile_data): Add comment.
 111         (find_comp_unit, set_comp_unit): New functions.
 112         (dwarf2_frame_find_fde): Use find_comp_unit.
 113         (dwarf2_build_frame_info): Use set_comp_unit.
 114
 115 2020-02-12  Tom Tromey  <tom@tromey.com>
 116
 117         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
 118         (comp_unit): Don't initialize objfile.
 119         (execute_cfa_program): Add text_offset parameter.
 120         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
 121         (dwarf2_frame_cache): Update.
 122         (dwarf2_build_frame_info): Don't set "objfile" member.
 123
 124 2020-02-12  Tom Tromey  <tom@tromey.com>
 125
 126         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
 127         (decode_frame_entry): Likewise.
 128         (dwarf2_build_frame_info): Update.
 129
 130 2020-02-12  Tom Tromey  <tom@tromey.com>
 131
 132         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
 133         (decode_frame_entry_1): Use the comp_unit obstack.
 134
 135 2020-02-12  Tom Tromey  <tom@tromey.com>
 136
 137         * dwarf2/frame.c (struct comp_unit): Add initializers and
 138         constructor.
 139         (dwarf2_frame_objfile_data): Store a comp_unit.
 140         (dwarf2_frame_find_fde): Update.
 141         (dwarf2_build_frame_info): Use "new".
 142
 143 2020-02-12  Tom Tromey  <tom@tromey.com>
 144
 145         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
 146         (dwarf2_fde_table): Typedef for std::vector.
 147         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
 148         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
 149         (decode_frame_entry): Update.
 150         (dwarf2_build_frame_info): Use "new".
 151
 152 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
 153
 154         * arm-tdep.c (arm_gdbarch_init): Update.
 155         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
 156         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
 157         have_neon, is_m>: Change to bool.
 158
 159 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
 160
 161         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
 162
 163 2020-02-12  Tom Tromey  <tom@tromey.com>
 164
 165         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
 166
 167 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
 168
 169         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
 170         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
 171
 172 2020-02-11  Tom Tromey  <tom@tromey.com>
 173
 174         * psymtab.h: Update comment.
 175
 176 2020-02-11  Tom Tromey  <tom@tromey.com>
 177
 178         * gdb_obstack.h (struct auto_obstack): Use
 179         DISABLE_COPY_AND_ASSIGN.
 180
 181 2020-02-11  Tom Tromey  <tom@tromey.com>
 182
 183         * dwarf2/frame.h (struct objfile): Don't forward declare.
 184
 185 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 186
 187         * cris-tdep.c (cris_supply_gregset): Change signature to match
 188         what struct regset expects.
 189         (cris_regset): New struct.
 190         (fetch_core_registers): Remove.
 191         (cris_iterate_over_regset_sections): New function.
 192         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
 193         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
 194
 195 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 196
 197         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
 198         registers.
 199
 200 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
 201
 202         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
 203
 204 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 205
 206         * configure: Re-generate.
 207
 208 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 209
 210         * configure: Re-generate.
 211
 212 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
 213
 214         * acinclude: Update warning.m4 path.
 215         * warning.m4: Move to gdbsupport.
 216
 217 2020-02-11  Tom Tromey  <tromey@adacore.com>
 218
 219         * remote.c (remote_console_output): Update.
 220         * printcmd.c (printf_command): Update.
 221         * event-loop.c (gdb_wait_for_event): Update.
 222         * linux-nat.c (sigchld_handler): Update.
 223         * remote-sim.c (gdb_os_write_stdout): Update.
 224         (gdb_os_flush_stdout): Update.
 225         (gdb_os_flush_stderr): Update.
 226         (gdb_os_write_stderr): Update.
 227         * exceptions.c (print_exception): Update.
 228         * remote-fileio.c (remote_fileio_func_read): Update.
 229         (remote_fileio_func_write): Update.
 230         * tui/tui.c (tui_enable): Update.
 231         * tui/tui-interp.c (tui_interp::init): Update.
 232         * utils.c (init_page_info): Update.
 233         (putchar_unfiltered, fputc_unfiltered): Update.
 234         (gdb_flush): Update.
 235         (emit_style_escape): Update.
 236         (flush_wrap_buffer, fputs_maybe_filtered): Update.
 237         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
 238         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
 239         (stderr_file::write): Update.
 240         (stderr_file::puts): Update.
 241         * ui-file.h (ui_file_isatty, ui_file_write)
 242         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
 243         (ui_file_puts): Don't declare.
 244
 245 2020-02-10  Tom de Vries  <tdevries@suse.de>
 246
 247         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
 248         sentinel to char *.
 249
 250 2020-02-09  Tom de Vries  <tdevries@suse.de>
 251
 252         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
 253         filename if it matches "<artificial>".
 254
 255 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
 256
 257         * windows-tdep.c (struct enum_value_name): New struct.
 258         (create_enum): New function.
 259         (windows_get_siginfo_type): Create and use enum types.
 260
 261 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
 262
 263         * NEWS: Mention $_siginfo support for Windows.
 264         * windows-nat.c (handle_exception): Set siginfo_er.
 265         (windows_nat_target::mourn_inferior): Reset siginfo_er.
 266         (windows_xfer_siginfo): New function.
 267         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
 268         * windows-tdep.c (struct windows_gdbarch_data): New struct.
 269         (init_windows_gdbarch_data): New function.
 270         (get_windows_gdbarch_data): New function.
 271         (windows_get_siginfo_type): New function.
 272         (windows_init_abi): Register windows_get_siginfo_type.
 273         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
 274
 275 2020-02-08  Tom Tromey  <tom@tromey.com>
 276
 277         * dwarf2/read.c (class cutu_reader) <cutu_reader,
 278         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
 279         <keep>: Declare method.
 280         <m_keep>: Remove member.
 281         <~cutu_reader>: Remove.
 282         (cutu_reader::init_tu_and_read_dwo_dies): Update.
 283         (cutu_reader::cutu_reader): Update.
 284         (cutu_reader::keep): Rename from ~cutu_reader.
 285         (process_psymtab_comp_unit, build_type_psymtabs_1)
 286         (process_skeletonless_type_unit, load_partial_comp_unit)
 287         (load_full_comp_unit, dwarf2_read_addr_index)
 288         (read_signatured_type): Update.
 289
 290 2020-02-08  Tom Tromey  <tom@tromey.com>
 291
 292         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
 293         "want_partial_unit" parameter.
 294         (process_psymtab_comp_unit): Change want_partial_unit to bool.
 295         Inline check for DW_TAG_partial_unit.
 296         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
 297
 298 2020-02-08  Tom Tromey  <tom@tromey.com>
 299
 300         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
 301         read.c.
 302         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
 303         read.c.
 304
 305 2020-02-08  Tom Tromey  <tom@tromey.com>
 306
 307         * dwarf2/read.c (read_address): Move to comp-unit.c.
 308         (dwarf2_rnglists_process, dwarf2_ranges_process)
 309         (read_attribute_value, dwarf_decode_lines_1)
 310         (var_decode_location, decode_locdesc): Update.
 311         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
 312         read.c.  Remove "cu" parameter.
 313         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
 314         method.
 315
 316 2020-02-08  Tom Tromey  <tom@tromey.com>
 317
 318         * dwarf2/read.c (read_attribute_value, read_indirect_string)
 319         (read_indirect_line_string): Update.
 320         * dwarf2/comp-unit.c (read_offset): Remove.
 321         (read_comp_unit_head): Update.
 322         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
 323         method.
 324         (read_offset): Don't declare.
 325
 326 2020-02-08  Tom Tromey  <tom@tromey.com>
 327
 328         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
 329         * dwarf2/read.c (struct comp_unit_head): Move to
 330         dwarf2/comp-unit.h.
 331         (enum class rcuh_kind): Move to comp-unit.h.
 332         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
 333         (read_comp_unit_head, error_check_comp_unit_head)
 334         (read_and_check_comp_unit_head): Move to comp-unit.c.
 335         (read_offset, dwarf_unit_type_name): Likewise.
 336         (create_debug_type_hash_table, read_cutu_die_from_dwo)
 337         (cutu_reader::cutu_reader, read_call_site_scope)
 338         (find_partial_die, follow_die_offset): Update.
 339         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
 340
 341 2020-02-08  Tom Tromey  <tom@tromey.com>
 342
 343         * dwarf2/read.c (read_offset_1): Move to leb.c.
 344         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
 345         (dwarf_decode_macro_bytes): Update.
 346         * dwarf2/leb.c (read_offset): Rename; move from read.c.
 347         * dwarf2/leb.h (read_offset): Declare.
 348
 349 2020-02-08  Tom Tromey  <tom@tromey.com>
 350
 351         * dwarf2/read.c (dwarf2_section_size): Remove.
 352         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
 353         Update.
 354         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
 355
 356 2020-02-08  Tom Tromey  <tom@tromey.com>
 357
 358         * dwarf2/read.c (read_initial_length): Move to leb.c.
 359         * dwarf2/leb.h (read_initial_length): Declare.
 360         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
 361         handle_nonstd parameter.
 362         * dwarf2/frame.c (read_initial_length): Remove.
 363         (decode_frame_entry_1): Update.
 364
 365 2020-02-08  Tom Tromey  <tom@tromey.com>
 366
 367         * dwarf2/loc.c (dwarf2_find_location_expression)
 368         (dwarf_evaluate_loc_desc::get_tls_address)
 369         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
 370         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
 371         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
 372         (dwarf2_compile_property_to_c)
 373         (dwarf2_loc_desc_get_symbol_read_needs)
 374         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
 375         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
 376         (loclist_describe_location, loclist_tracepoint_var_ref)
 377         (loclist_generate_c_location): Update.
 378         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
 379         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
 380         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
 381         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
 382         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
 383         (dwarf2_per_cu_data::addr_size)
 384         (dwarf2_per_cu_data::ref_addr_size)
 385         (dwarf2_per_cu_data::text_offset)
 386         (dwarf2_per_cu_data::addr_type): Now methods.
 387         (per_cu_header_read_in): Make per_cu "const".
 388         (dwarf2_version): Remove.
 389         (dwarf2_per_cu_data::int_type): Now a method.
 390         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
 391         (set_die_type, read_array_type, read_subrange_index_type)
 392         (read_tag_string_type, read_subrange_type): Update.
 393         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
 394         offset_size, ref_addr_size, text_offset, addr_type, version,
 395         objfile, int_type, addr_sized_int_type>: Declare methods.
 396
 397 2020-02-08  Tom Tromey  <tom@tromey.com>
 398
 399         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
 400         Move earlier.
 401
 402 2020-02-08  Tom Tromey  <tom@tromey.com>
 403
 404         * dwarf2/read.h (dwarf_line_debug): Declare.
 405         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
 406         * dwarf2/read.c: Move line_header code to new files.
 407         (dwarf_line_debug): No longer static.
 408         * dwarf2/line-header.c: New file.
 409         * dwarf2/line-header.h: New file.
 410
 411 2020-02-08  Tom Tromey  <tom@tromey.com>
 412
 413         * dwarf2/read.c (struct line_header) <file_full_name,
 414         file_file_name>: Return unique_xmalloc_ptr.
 415         (line_header::file_file_name): Update.
 416         (line_header::file_full_name): Update.
 417         (dw2_get_file_names_reader): Update.
 418         (macro_start_file): Update.
 419
 420 2020-02-08  Tom Tromey  <tom@tromey.com>
 421
 422         * dwarf2/read.c (struct line_header) <file_full_name,
 423         file_file_name>: Declare methods.
 424         (dw2_get_file_names_reader): Update.
 425         (file_file_name): Now a method.
 426         (file_full_name): Likewise.
 427         (macro_start_file): Update.
 428
 429 2020-02-08  Tom Tromey  <tom@tromey.com>
 430
 431         * dwarf2/read.c (dwarf_always_disassemble)
 432         (show_dwarf_always_disassemble): Move to loc.c.
 433         (_initialize_dwarf2_read): Move "always-disassemble" registration
 434         to loc.c.
 435         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
 436         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
 437         static.
 438         (show_dwarf_always_disassemble): Move from read.c.
 439         (_initialize_dwarf2loc): Move always-disassemble from read.c.
 440
 441 2020-02-08  Tom Tromey  <tom@tromey.com>
 442
 443         * dwarf2/read.c (~dwarf2_per_objfile): Update.
 444         (create_quick_file_names_table): Return htab_up.
 445         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
 446         Update.
 447         * dwarf2/read.h (struct dwarf2_per_objfile)
 448         <quick_file_names_table>: Now htab_up.
 449
 450 2020-02-08  Tom Tromey  <tom@tromey.com>
 451
 452         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
 453
 454 2020-02-08  Tom Tromey  <tom@tromey.com>
 455
 456         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
 457         Rewrite.
 458         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
 459         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
 460         (abbrev_table::abbrev_table): No longer inline.
 461         (ABBREV_HASH_SIZE): Remove.
 462         (abbrev_table::m_abbrevs): Now an htab_up.
 463
 464 2020-02-08  Tom Tromey  <tom@tromey.com>
 465
 466         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
 467         (cutu_reader): Update.
 468         (build_type_psymtabs_1): Update.
 469         * dwarf2/abbrev.c (abbrev_table::read): Rename.
 470         (abbrev_table::alloc_abbrev): Update.
 471         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
 472         (abbrev_table::read): New static method, renamed from
 473         abbrev_table_read_table.
 474         (abbrev_table::alloc_abbrev)
 475         (abbrev_table::add_abbrev): Now private.
 476         (abbrev_table::abbrev_table): Now private.
 477         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
 478
 479 2020-02-08  Tom Tromey  <tom@tromey.com>
 480
 481         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
 482         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
 483         htab_up.
 484
 485 2020-02-08  Tom Tromey  <tom@tromey.com>
 486
 487         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
 488         htab_up.
 489         (lookup_dwo_unit_in_dwp): Update.
 490         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
 491         on obstack.
 492
 493 2020-02-08  Tom Tromey  <tom@tromey.com>
 494
 495         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
 496         obstack.
 497
 498 2020-02-08  Tom Tromey  <tom@tromey.com>
 499
 500         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
 501         line_header_hash.
 502         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
 503         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
 504         Change type to htab_up.
 505
 506 2020-02-08  Tom Tromey  <tom@tromey.com>
 507
 508         * dwarf2/read.c (allocate_type_unit_groups_table): Return
 509         htab_up.  Don't allocate on obstack.
 510         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
 511         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
 512         Change type to htab_up.
 513
 514 2020-02-08  Tom Tromey  <tom@tromey.com>
 515
 516         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
 517         Change type to htab_up.
 518         * dwarf2/read.c (create_signatured_type_table_from_index)
 519         (create_signatured_type_table_from_debug_names)
 520         (create_all_type_units, add_type_unit)
 521         (lookup_dwo_signatured_type, lookup_signatured_type)
 522         (process_skeletonless_type_unit): Update.
 523         (create_debug_type_hash_table, create_debug_types_hash_table):
 524         Change type of types_htab.
 525         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
 526         htab_up.  Don't allocate on obstack.
 527         (create_cus_hash_table): Change type of cus_htab parameter.
 528         (struct dwo_file) <cus, tus>: Now htab_up.
 529         (lookup_dwo_signatured_type, lookup_dwo_cutu)
 530         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
 531         (queue_and_load_all_dwo_tus): Update.
 532         * dwarf2/index-write.c (write_gdbindex): Update.
 533         (write_debug_names): Update.
 534
 535 2020-02-08  Tom Tromey  <tom@tromey.com>
 536
 537         * dwarf2/read.h (struct dwarf2_queue_item): Move from
 538         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
 539         destructor.
 540         (struct dwarf2_per_objfile) <queue>: New member.
 541         * dwarf2/read.c (struct dwarf2_queue_item): Move to
 542         dwarf2/read.h.
 543         (dwarf2_queue, dwarf2_queue_tail): Remove.
 544         (class dwarf2_queue_guard): Add parameter to constructor.  Use
 545         DISABLE_COPY_AND_ASSIGN.
 546         <m_per_objfile>: New member.
 547         <~dwarf2_queue_guard>: Rewrite.
 548         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
 549         Update.
 550         (~dwarf2_queue_item): New.
 551
 552 2020-02-08  Tom Tromey  <tom@tromey.com>
 553
 554         * dwarf2/read.c (struct die_info) <has_children>: New member.
 555         (dw2_get_file_names_reader): Remove has_children.
 556         (dw2_get_file_names): Update.
 557         (read_cutu_die_from_dwo): Remove has_children.
 558         (cutu_reader::init_tu_and_read_dwo_dies)
 559         (cutu_reader::cutu_reader): Update.
 560         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
 561         Remove has_children.
 562         (build_type_psymtabs_1, process_skeletonless_type_unit)
 563         (load_partial_comp_unit, load_full_comp_unit): Update.
 564         (create_dwo_cu_reader): Remove has_children.
 565         (create_cus_hash_table, read_die_and_children): Update.
 566         (read_full_die_1,read_full_die): Remove has_children.
 567         (read_signatured_type): Update.
 568         (class cutu_reader) <has_children>: Remove.
 569
 570 2020-02-08  Tom Tromey  <tom@tromey.com>
 571
 572         * dwarf2/expr.c: Rename from dwarf2expr.c.
 573         * dwarf2/expr.h: Rename from dwarf2expr.h.
 574         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
 575         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
 576         * dwarf2/frame.c: Rename from dwarf2-frame.c.
 577         * dwarf2/frame.h: Rename from dwarf2-frame.h.
 578         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
 579         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
 580         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
 581         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
 582         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
 583         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
 584         * dwarf2/loc.c: Rename from dwarf2loc.c.
 585         * dwarf2/loc.h: Rename from dwarf2loc.h.
 586         * dwarf2/read.c: Rename from dwarf2read.c.
 587         * dwarf2/read.h: Rename from dwarf2read.h.
 588         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
 589         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
 590         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
 591         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
 592         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
 593         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
 594         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
 595         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
 596         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
 597         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
 598         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
 599         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
 600         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
 601         Update.
 602         * Makefile.in (COMMON_SFILES): Update.
 603         (HFILES_NO_SRCDIR): Update.
 604
 605 2020-02-08  Tom Tromey  <tom@tromey.com>
 606
 607         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
 608         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
 609
 610 2020-02-08  Tom Tromey  <tom@tromey.com>
 611
 612         * dwarf2read.h (struct die_info): Don't declare.
 613
 614 2020-02-08  Tom Tromey  <tom@tromey.com>
 615
 616         * dwarf2read.h (die_info_ptr): Remove typedef.
 617
 618 2020-02-08  Tom Tromey  <tom@tromey.com>
 619
 620         * dwarf2read.c (read_call_site_scope)
 621         (handle_data_member_location, dwarf2_add_member_fn)
 622         (mark_common_block_symbol_computed, read_common_block)
 623         (attr_to_dynamic_prop, partial_die_info::read)
 624         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
 625         (dwarf2_symbol_mark_computed, set_die_type): Update.
 626         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
 627         method.
 628         (attr_form_is_block): Don't declare.
 629         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
 630
 631 2020-02-08  Tom Tromey  <tom@tromey.com>
 632
 633         * dwarf2read.c (dwarf2_find_base_address, )
 634         (read_call_site_scope, rust_containing_type)
 635         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
 636         (handle_data_member_location, dwarf2_add_member_fn)
 637         (get_alignment, read_structure_type, process_structure_scope)
 638         (mark_common_block_symbol_computed, read_common_block)
 639         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
 640         (partial_die_info::read, read_attribute_value, new_symbol)
 641         (lookup_die_type, dwarf2_get_ref_die_offset)
 642         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
 643         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
 644         (dwarf2_symbol_mark_computed): Update.
 645         * dwarf2/attribute.h (struct attribute) <value_as_address,
 646         form_is_section_offset, form_is_constant, form_is_ref>: Declare
 647         methods.
 648         (value_as_address, attr_form_is_section_offset)
 649         (attr_form_is_constant, attr_form_is_ref): Don't declare.
 650         * dwarf2/attribute.c (attribute::value_as_address)
 651         (attribute::form_is_section_offset, attribute::form_is_constant)
 652         (attribute::form_is_ref): Now methods.
 653
 654 2020-02-08  Tom Tromey  <tom@tromey.com>
 655
 656         * dwarf2read.c (struct attribute, DW_STRING)
 657         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
 658         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
 659         (attr_form_is_block, attr_form_is_section_offset)
 660         (attr_form_is_constant, attr_form_is_ref): Move.
 661         * dwarf2/attribute.h: New file.
 662         * dwarf2/attribute.c: New file, from dwarf2read.c.
 663         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
 664
 665 2020-02-08  Tom Tromey  <tom@tromey.com>
 666
 667         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
 668         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
 669         Move.
 670         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
 671         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
 672         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
 673         abbrev.c.
 674         * dwarf2/abbrev.h: New file.
 675         * dwarf2/abbrev.c: New file, from dwarf2read.c.
 676         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
 677
 678 2020-02-08  Tom Tromey  <tom@tromey.com>
 679
 680         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
 681         (dwarf2_section_size, dwarf2_get_section_info)
 682         (create_signatured_type_table_from_debug_names)
 683         (create_addrmap_from_aranges, read_debug_names_from_section)
 684         (get_gdb_index_contents_from_section, read_comp_unit_head)
 685         (error_check_comp_unit_head, read_abbrev_offset)
 686         (create_debug_type_hash_table, init_cu_die_reader)
 687         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
 688         (read_comp_units_from_section, create_cus_hash_table)
 689         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
 690         (create_dwp_v2_section, dwarf2_rnglists_process)
 691         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
 692         (abbrev_table_read_table, read_indirect_string_at_offset_from)
 693         (read_indirect_string_from_dwz, read_addr_index_1)
 694         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
 695         (dwarf_decode_macro_bytes, dwarf_decode_macros)
 696         (fill_in_loclist_baton): Update.
 697         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
 698         get_containing_section, get_bfd_owner, get_bfd_section,
 699         get_file_name, get_id, get_flags, empty, read>: Declare methods.
 700         (dwarf2_read_section, get_section_name, get_section_file_name)
 701         (get_containing_section, get_section_bfd_owner)
 702         (get_section_bfd_section, get_section_name, get_section_file_name)
 703         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
 704         declare.
 705         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
 706         (dwarf2_section_info::get_bfd_owner)
 707         (dwarf2_section_info::get_bfd_section)
 708         (dwarf2_section_info::get_name)
 709         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
 710         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
 711         (dwarf2_section_info::read): Now methods.
 712         * dwarf-index-write.c (class debug_names): Update.
 713
 714 2020-02-08  Tom Tromey  <tom@tromey.com>
 715
 716         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
 717         Move to dwarf2/section.h.
 718         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
 719         (get_section_bfd_section, get_section_name)
 720         (get_section_file_name, get_section_id, get_section_flags)
 721         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
 722         dwarf2/section.c.
 723         * dwarf2/section.h: New file.
 724         * dwarf2/section.c: New file, from dwarf2read.c.
 725         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
 726
 727 2020-02-08  Tom Tromey  <tom@tromey.com>
 728
 729         * dwarf2read.h (read_unsigned_leb128): Don't declare.
 730         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
 731         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
 732         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
 733         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
 734         * dwarf2/leb.h: New file, from dwarf2read.c.
 735         * dwarf2/leb.c: New file, from dwarf2read.c.
 736         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
 737         Remove.
 738         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
 739         (COMMON_SFILES): Add dwarf2/leb.c.
 740
 741 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
 742
 743         GDB 9.1 released.
 744
 745 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
 746
 747         PR gdb/25190:
 748         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
 749         * gdb/remote.c (remote_console_output): Update.
 750         * gdb/ui-file.c (fputs_unfiltered): Rename to...
 751         (ui_file_puts): ...this.
 752         * gdb/ui-file.h (ui_file_puts): Add declaration.
 753         * gdb/utils.c (emit_style_escape): Update.
 754         (flush_wrap_buffer): Update.
 755         (fputs_maybe_filtered): Update.
 756         (fputs_unfiltered): Add function.
 757
 758 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
 759
 760         * gdb/event-loop.c (gdb_wait_for_event): Update.
 761         * gdb/printcmd.c (printf_command): Update.
 762         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
 763         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
 764         (gdb_os_flush_stderr): Update.
 765         * gdb/remote.c (remote_console_output): Update.
 766         * gdb/ui-file.c (gdb_flush): Rename to...
 767         (ui_file_flush): ...this.
 768         (stderr_file::write): Update.
 769         (stderr_file::puts): Update.
 770         * gdb/ui-file.h (gdb_flush): Rename to...
 771         (ui_file_flush): ...this.
 772         * gdb/utils.c (gdb_flush): Add function.
 773         * gdb/utils.h (gdb_flush): Add declaration.
 774
 775 2020-02-07  Tom Tromey  <tromey@adacore.com>
 776
 777         PR breakpoints/24915:
 778         * source.c (find_and_open_source): Do not check basenames_may_differ.
 779
 780 2020-02-07  Tom Tromey  <tom@tromey.com>
 781
 782         * README: Update gdbserver documentation.
 783         * gdbserver: Move to top level.
 784         * configure.tgt (build_gdbserver): Remove.
 785         * configure.ac: Remove --enable-gdbserver.
 786         * configure: Rebuild.
 787         * Makefile.in (distclean): Don't mention gdbserver.
 788
 789 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
 790
 791         * source-cache.c (source_cache::ensure): Surround
 792         get_plain_source_lines with a try/catch.
 793         (source_cache::get_line_charpos): Get rid of try/catch
 794         and only check for the return value of "ensure".
 795         * tui/tui-source.c (tui_source_window::set_contents):
 796         Simplify "nlines" calculation.
 797
 798 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
 799
 800         * MAINTAINERS (Write After Approval): Add myself.
 801
 802 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
 803
 804         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
 805         function call.
 806
 807 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
 808
 809         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
 810
 811 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
 812
 813         * nat/riscv-linux-tdesc.h: New file.
 814         * nat/riscv-linux-tdesc.c: New file, taking code from...
 815         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
 816         ... here.
 817         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
 818         NATDEPFILES.
 819
 820 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 821
 822         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
 823         we don't set the fake simulator ptid to the null_ptid.
 824
 825 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
 826
 827         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
 828         * gdbthread.h (class thread_info) <resumed>: Likewise.
 829         * infrun.c (resume_1): Likewise.
 830         (proceed): Likewise.
 831         (infrun_thread_stop_requested): Likewise.
 832         (stop_all_threads): Likewise.
 833         (handle_inferior_event): Likewise.
 834         (restart_threads): Likewise.
 835         (finish_step_over): Likewise.
 836         (keep_going_stepped_thread): Likewise.
 837         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
 838         (linux_handle_extended_wait): Likewise.
 839         * record-btrace.c (get_thread_current_frame_id): Likewise.
 840         * record-full.c (record_full_wait_1): Likewise.
 841         * remote.c (remote_target::process_initial_stop_replies): Likewise.
 842         * target.c (target_resume): Likewise.
 843         * thread.c (set_running_thread): Likewise.
 844
 845 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 846
 847         * f-valprint.c (f77_print_array_1): Changed datatype of index
 848         variable to LONGEST from int to enable it to contain bound
 849         values correctly.
 850
 851 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
 852
 853         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
 854         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
 855         offsets according to FLEN determined.
 856         (riscv_linux_nat_target::read_description): Determine FLEN
 857         dynamically.
 858         (riscv_linux_nat_target::fetch_registers): Size regset buffer
 859         according to FLEN determined.
 860         (riscv_linux_nat_target::store_registers): Likewise.
 861
 862 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
 863
 864         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
 865         when reg->group is empty and reggroup is not.
 866
 867 2020-01-31  Tom Tromey  <tromey@adacore.com>
 868
 869         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
 870         Call beneath target's mourn_inferior after unpushing.
 871
 872 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 873
 874         PR tui/9765
 875         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
 876         have enough lines to fill the screen, still return the lowest
 877         address we found.
 878
 879 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
 880
 881         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
 882         '-', '<', and '>' commands.
 883
 884 2020-01-29  Pedro Alves  <palves@redhat.com>
 885             Sergio Durigan Junior  <sergiodj@redhat.com>
 886
 887         * infcmd.c (construct_inferior_arguments): Assert that
 888         'argc' is greater than 0.
 889
 890 2020-01-29  Luis Machado  <luis.machado@linaro.org>
 891
 892         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
 893         (BRK_INSN_MASK): Define to 0xd4200000.
 894         (aarch64_program_breakpoint_here_p): New function.
 895         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
 896         * arch-utils.c (default_program_breakpoint_here_p): Moved from
 897         breakpoint.c.
 898         * arch-utils.h (default_program_breakpoint_here_p): Moved from
 899         breakpoint.h
 900         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
 901         call gdbarch_program_breakpoint_here_p.
 902         (program_breakpoint_here): Moved to arch-utils.c, renamed to
 903         default_program_breakpoint_here_p, changed return type to bool and
 904         simplified.
 905         * breakpoint.h (program_breakpoint_here): Moved prototype to
 906         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
 907         return type to bool.
 908         * gdbarch.c: Regenerate.
 909         * gdbarch.h: Regenerate.
 910         * gdbarch.sh (program_breakpoint_here_p): New method.
 911         * infrun.c (handle_signal_stop): Call
 912         gdbarch_program_breakpoint_here_p.
 913
 914 2020-01-26  Tom Tromey  <tom@tromey.com>
 915
 916         * ctfread.c (struct ctf_fp_info): Reindent.
 917         (_initialize_ctfread): Remove.
 918
 919 2020-01-26  Tom Tromey  <tom@tromey.com>
 920
 921         * psymtab.c (partial_map_expand_apply)
 922         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
 923         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
 924         (psym_print_stats, psym_expand_symtabs_for_function)
 925         (psym_map_symbol_filenames, psym_map_matching_symbols)
 926         (psym_expand_symtabs_matching)
 927         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
 928         (maintenance_check_psymtabs): Use new methods.
 929         * psympriv.h (struct partial_symtab) <readin_p,
 930         get_compunit_symtab>: New methods.
 931         <readin, compunit_symtab>: Remove members.
 932         (struct standard_psymtab): New.
 933         (struct legacy_psymtab): Derive from standard_psymtab.
 934         * dwarf2read.h (struct dwarf2_psymtab): Derive from
 935         standard_psymtab.
 936         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
 937
 938 2020-01-26  Tom Tromey  <tom@tromey.com>
 939
 940         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
 941         read_dependencies.  Add assert.
 942         * psymtab.c (partial_symtab::read_dependencies): New method.
 943         * psympriv.h (struct partial_symtab) <read_dependencies>: New
 944         method.
 945         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
 946         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
 947         read_dependencies.
 948         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
 949         Add assert.
 950
 951 2020-01-26  Tom Tromey  <tom@tromey.com>
 952
 953         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
 954         Call expand_psymtab.
 955         (xcoff_read_symtab): Call expand_psymtab.
 956         (xcoff_start_psymtab, xcoff_end_psymtab): Set
 957         legacy_expand_psymtab.
 958         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
 959         method.
 960         (struct legacy_psymtab) <expand_psymtab>: Implement.
 961         <legacy_expand_psymtab>: New member.
 962         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
 963         (parse_partial_symbols): Set legacy_expand_psymtab.
 964         (psymtab_to_symtab_1): Change argument order.  Call
 965         expand_psymtab.
 966         (new_psymtab): Set legacy_expand_psymtab.
 967         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
 968         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
 969         expand_psymtab.
 970         (dwarf2_psymtab::expand_psymtab): Rename from
 971         psymtab_to_symtab_1.  Call expand_psymtab.
 972         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
 973         (dbx_end_psymtab): Likewise.
 974         (dbx_psymtab_to_symtab_1): Change argument order. Call
 975         expand_psymtab.
 976         (dbx_read_symtab): Call expand_psymtab.
 977         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
 978         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
 979         (ctf_psymtab::read_symtab): Call expand_psymtab.
 980
 981 2020-01-26  Tom Tromey  <tom@tromey.com>
 982
 983         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
 984         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
 985         messages.
 986         * mdebugread.c (mdebug_read_symtab): Remove prints.
 987         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
 988         assert.
 989         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
 990
 991 2020-01-26  Tom Tromey  <tom@tromey.com>
 992
 993         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
 994         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
 995         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
 996         legacy_symtab.
 997         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
 998         * psymtab.c (psymtab_to_symtab): Call method.
 999         (dump_psymtab): Update.
1000         * psympriv.h (struct partial_symtab): Add virtual destructor.
1001         <read_symtab>: New method.
1002         (struct legacy_symtab): New.
1003         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
1004         (struct pst_map) <pst>: Now a legacy_psymtab.
1005         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
1006         (new_psymtab): Use legacy_psymtab.
1007         * dwarf2read.h (struct dwarf2_psymtab): New.
1008         (struct dwarf2_per_cu_data) <psymtab>: Use it.
1009         * dwarf2read.c (dwarf2_create_include_psymtab)
1010         (dwarf2_build_include_psymtabs, create_type_unit_group)
1011         (create_partial_symtab, process_psymtab_comp_unit_reader)
1012         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
1013         (set_partial_user): Use dwarf2_psymtab.
1014         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
1015         (psymtab_to_symtab_1, process_full_comp_unit)
1016         (process_full_type_unit, dwarf2_ranges_read)
1017         (dwarf2_get_pc_bounds, psymtab_include_file_name)
1018         (dwarf_decode_lines): Use dwarf2_psymtab.
1019         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
1020         (add_address_entry_worker, write_one_signatured_type)
1021         (recursively_count_psymbols, recursively_write_psymbols)
1022         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
1023         (write_debug_names): Likewise.
1024         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
1025         <pst>: Now a legacy_psymtab.
1026         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
1027         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
1028         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
1029         * ctfread.c (struct ctf_psymtab): New.
1030         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
1031         ctf_psymtab.
1032         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
1033         (create_partial_symtab): Return a ctf_psymtab.
1034         (scan_partial_symbols): Update.
1035
1036 2020-01-26  Tom Tromey  <tom@tromey.com>
1037
1038         * xcoffread.c (xcoff_start_psymtab): Use new.
1039         * psymtab.c (partial_symtab::partial_symtab): New constructor,
1040         renamed from start_psymtab_common.
1041         * psympriv.h (struct partial_symtab): Add new constructor.
1042         (start_psymtab_common): Don't declare.
1043         * mdebugread.c (parse_partial_symbols): Use new.
1044         * dwarf2read.c (create_partial_symtab): Use new.
1045         * dbxread.c (start_psymtab): Use new.
1046         * ctfread.c (create_partial_symtab): Use new.
1047
1048 2020-01-26  Tom Tromey  <tom@tromey.com>
1049
1050         * xcoffread.c (xcoff_end_psymtab): Use new.
1051         * psymtab.c (start_psymtab_common): Use new.
1052         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
1053         Update.
1054         * psympriv.h (struct partial_symtab): Add parameters to
1055         constructor.  Don't inline.
1056         (allocate_psymtab): Don't declare.
1057         * mdebugread.c (new_psymtab): Use new.
1058         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
1059         * dbxread.c (dbx_end_psymtab): Use new.
1060
1061 2020-01-26  Tom Tromey  <tom@tromey.com>
1062
1063         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
1064         allocate_psymtab.  Update documentation.
1065         * psymtab.c (psymtab_storage::install_psymtab): Rename from
1066         allocate_psymtab.  Do not use new.
1067         (allocate_psymtab): Use new.  Update.
1068
1069 2020-01-26  Tom Tromey  <tom@tromey.com>
1070
1071         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1072         * psymtab.c (psym_print_stats): Update.
1073         * psympriv.h (struct partial_symtab) <readin,
1074         psymtabs_addrmap_supported, anonymous>: Now bool.
1075         * mdebugread.c (psymtab_to_symtab_1): Update.
1076         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
1077         (build_type_psymtabs_reader, psymtab_to_symtab_1)
1078         (process_full_comp_unit, process_full_type_unit): Update.
1079         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1080         * ctfread.c (psymtab_to_symtab): Update.
1081
1082 2020-01-26  Tom Tromey  <tom@tromey.com>
1083
1084         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
1085         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
1086         * psymtab.c (psymtab_storage): Delete psymtabs.
1087         (psymtab_storage::allocate_psymtab): Use new.
1088         (psymtab_storage::discard_psymtab): Use delete.
1089         * psympriv.h (struct partial_symtab): Add constructor and
1090         initializers.
1091
1092 2020-01-26  Tom Tromey  <tom@tromey.com>
1093
1094         * machoread.c: Do not include psympriv.h.
1095
1096 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1097
1098         * NEWS: Mention the new option and the set/show commands.
1099
1100 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1101
1102         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
1103         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
1104         (validate_exec_file): New variables, enums, functions.
1105         (exec_file_locate_attach, print_section_info): Style the filenames.
1106         (_initialize_exec): Install show_exec_file_mismatch_command and
1107          set_exec_file_mismatch_command.
1108         * gdbcore.h (validate_exec_file): Declare.
1109         * infcmd.c (attach_command): Call validate_exec_file.
1110         * remote.c ( remote_target::remote_add_inferior): Likewise.
1111
1112 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1113
1114         * frame.c (find_frame_sal): Move call to get_next_frame into more
1115         inner scope.
1116         * inline-frame.c (inilne_state) <inline_state>: Update argument
1117         types.
1118         (inilne_state) <skipped_symbol>: Rename to...
1119         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
1120         (skip_inline_frames): Build vector of skipped symbols and use this
1121         to reate the inline_state.
1122         (inline_skipped_symbol): Add a comment and some assertions, fetch
1123         skipped symbol from the list.
1124
1125 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1126
1127         * buildsym.c (lte_is_less_than): Delete.
1128         (buildsym_compunit::end_symtab_with_blockvector): Create local
1129         lambda function to sort line table entries, and use
1130         std::stable_sort instead of std::sort.
1131         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
1132         markers when looking for a previous line.
1133
1134 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1135
1136         * dwarf2read.c (lnp_state_machine::record_line): Include
1137         end_sequence parameter in debug print out.  Record the line if we
1138         are at an end_sequence marker even if it's not the start of a
1139         statement.
1140         * symmisc.c (maintenance_print_one_line_table): Print end of
1141         sequence markers with 'END' not '0'.
1142
1143 2020-01-24  Pedro Alves  <palves@redhat.com>
1144
1145         PR gdb/25410
1146         * thread.c (scoped_restore_current_thread::restore): Use
1147         switch_to_inferior_no_thread.
1148         * exec.c: Include "progspace-and-thread.h".
1149         (add_target_sections, remove_target_sections):
1150         scoped_restore_current_pspace_and_thread instead of
1151         scoped_restore_current_thread.
1152         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
1153         and aspace to the inferior before calling clone_program_space.
1154         Remove stale comment.
1155
1156 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1157
1158         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
1159         (arm_netbsd_nat_target::fetch_registers): ...this.
1160         (arm_nbsd_nat_target::store_registers): Rename to...
1161         (arm_netbsd_nat_target::store_registers): ...this.
1162
1163 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1164
1165         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
1166         register_t.
1167
1168 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
1169
1170         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
1171         Update comment.
1172         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
1173         Likewise.
1174         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
1175         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
1176         the correct replacement (iterate_over_regset_sections).
1177         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
1178         Update comment.
1179
1180 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
1181
1182         PR gdb/23718
1183         * gdb/python/python.c (execute_gdb_command): Call
1184         async_enable_stdin in catch block.
1185
1186 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1187
1188         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
1189         SWITCH_THRU_ALL_UIS.
1190
1191 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
1192
1193         PR tui/9765
1194         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
1195         comment, add extra parameter, and update to store previous symbol
1196         when appropriate.
1197         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
1198         add extra parameter.
1199         * tui/tui-disasm.c (tui_disassemble): Update header comment,
1200         remove unneeded parameter, add try/catch around gdb_print_insn,
1201         rewrite to add items to asm_lines vector.
1202         (tui_find_backward_disassembly_start_address): New function.
1203         (tui_find_disassembly_address): Updated throughout.
1204         (tui_disasm_window::set_contents): Update for changes to
1205         tui_disassemble.
1206         (tui_disasm_window::do_scroll_vertical): No need to adjust the
1207         number of lines to scroll.
1208
1209 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
1210
1211         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
1212         (SECT_OFF_DATA): Likewise.
1213         (SECT_OFF_RODATA): Likewise.
1214         (SECT_OFF_TEXT): Likewise.
1215         (SECT_OFF_BSS): Likewise.
1216         (struct objfile) <text_section_offset, data_section_offset>: New
1217         methods.
1218         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
1219         objfile::text_section_offset.
1220         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
1221         * coffread.c (coff_symtab_read): Likewise.
1222         (enter_linenos): Likewise.
1223         (process_coff_symbol): Likewise.
1224         * ctfread.c (get_objfile_text_range): Likewise.
1225         * dtrace-probe.c (dtrace_probe::get_relocated_address):
1226         Use objfile::data_section_offset.
1227         * dwarf2-frame.c (execute_cfa_program): Use
1228         objfile::text_section_offset.
1229         (dwarf2_frame_find_fde): Likewise.
1230         * dwarf2read.c (create_addrmap_from_index): Likewise.
1231         (create_addrmap_from_aranges): Likewise.
1232         (dw2_find_pc_sect_compunit_symtab): Likewise.
1233         (process_psymtab_comp_unit_reader): Likewise.
1234         (add_partial_symbol): Likewise.
1235         (add_partial_subprogram): Likewise.
1236         (process_full_comp_unit): Likewise.
1237         (read_file_scope): Likewise.
1238         (read_func_scope): Likewise.
1239         (read_lexical_block_scope): Likewise.
1240         (read_call_site_scope): Likewise.
1241         (dwarf2_rnglists_process): Likewise.
1242         (dwarf2_ranges_process): Likewise.
1243         (dwarf2_ranges_read): Likewise.
1244         (dwarf_decode_lines_1): Likewise.
1245         (new_symbol): Likewise.
1246         (dwarf2_fetch_die_loc_sect_off): Likewise.
1247         (dwarf2_per_cu_text_offset): Likewise.
1248         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
1249         * hppa-tdep.c (read_unwind_info): Likewise.
1250         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
1251         * psympriv.h (struct partial_symtab): Likewise.
1252         * psymtab.c (find_pc_sect_psymtab): Likewise.
1253         * solib-svr4.c (enable_break): Likewise.
1254         * stap-probe.c (relocate_address): Use
1255         objfile::data_section_offset.
1256         * xcoffread.c (enter_line_range): Use
1257         objfile::text_section_offset.
1258         (read_xcoff_symtab): Likewise.
1259
1260 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
1261
1262         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
1263         declaration to narrower scopes.
1264
1265 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
1266
1267         * darwin-nat.h (struct darwin_exception_msg, enum
1268         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
1269         Move up.
1270         (class darwin_nat_target) <wait_1, check_new_threads,
1271         decode_exception_message, decode_message, stop_inferior,
1272         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
1273         * darwin-nat.c (darwin_check_new_threads): Rename to...
1274         (darwin_nat_target::check_new_threads): ... this.
1275         (darwin_suspend_inferior_it): Remove.
1276         (darwin_decode_exception_message): Rename to...
1277         (darwin_nat_target::decode_exception_message): ... this.
1278         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
1279         (darwin_decode_message): Rename to...
1280         (darwin_nat_target::decode_message): ... this.
1281         (cancel_breakpoint): Rename to...
1282         (darwin_nat_target::cancel_breakpoint): ... this.
1283         (darwin_wait): Rename to...
1284         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
1285         instead of iterate_over_inferiors.
1286         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
1287         (darwin_stop_inferior): Rename to...
1288         (darwin_nat_target::stop_inferior): ... this.
1289         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
1290         (darwin_init_thread_list): Rename to...
1291         (darwin_nat_target::init_thread_list): ... this.
1292         (darwin_ptrace_him): Rename to...
1293         (darwin_nat_target::ptrace_him): ... this.
1294         (darwin_nat_target::create_inferior): Pass lambda function to
1295         fork_inferior.
1296         (darwin_nat_target::detach): Call stop_inferior instead of
1297         darwin_stop_inferior.
1298         * fork-inferior.h (fork_inferior): Change init_trace_fun
1299         parameter to gdb::function_view.
1300         * fork-inferior.c (fork_inferior): Likewise.
1301
1302 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
1303
1304         * i386-cygwin-tdep.c (core_process_module_section): Update.
1305         * windows-nat.c (struct lm_info_windows): Add text_offset.
1306         (windows_xfer_shared_libraries): Update.
1307         * windows-tdep.c (windows_xfer_shared_library):
1308         Add text_offset_cached argument.
1309         * windows-tdep.h (windows_xfer_shared_library): Update.
1310
1311 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
1312
1313         * gdbarch.sh: Add declaration for _initialize_gdbarch.
1314
1315 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
1316
1317         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
1318         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
1319         replace with range-based for.
1320         (gdbsim_interrupt_inferior): Remove.
1321         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
1322         with a range-based for.  Inline code from
1323         gdbsim_interrupt_inferior.
1324
1325 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
1326
1327         * infrun.c (proceed): Fix indentation.
1328
1329 2020-01-21  Tom Tromey  <tromey@adacore.com>
1330
1331         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
1332         * python/python.c (python_extension_ops): Update.
1333         (gdbpy_colorize): New function.
1334         * python/lib/gdb/__init__.py (colorize): New function.
1335         * extension.h (ext_lang_colorize): Declare.
1336         * extension.c (ext_lang_colorize): New function.
1337         * extension-priv.h (struct extension_language_ops) <colorize>: New
1338         member.
1339         * cli/cli-style.c (_initialize_cli_style): Update help text.
1340
1341 2020-01-21  Luis Machado  <luis.machado@linaro.org>
1342
1343         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
1344         <cond>: Change type to bool.
1345         (aarch64_displaced_step_b_cond): Update cond to use bool type.
1346         (aarch64_displaced_step_cb): Likewise.
1347         (aarch64_displaced_step_tb): Likewise.
1348
1349 2020-01-21  Luis Machado  <luis.machado@linaro.org>
1350
1351         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
1352         output.
1353
1354 2020-01-21  Luis Machado  <luis.machado@linaro.org>
1355
1356         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
1357         <pc_adjust>: Adjust the documentation.
1358         (aarch64_displaced_step_fixup): Check if PC really moved before
1359         adjusting it.
1360
1361 2020-01-19  Tom Tromey  <tom@tromey.com>
1362
1363         * disasm.c (~gdb_disassembler): New destructor.
1364         (gdb_buffered_insn_length): Call disassemble_free_target.
1365         * disasm.h (class gdb_disassembler): Declare destructor.  Use
1366         DISABLE_COPY_AND_ASSIGN.
1367
1368 2020-01-19  Tom Tromey  <tom@tromey.com>
1369
1370         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
1371         (die_reader_func_ftype): Remove.
1372         (cutu_reader): New class.
1373         (dw2_get_file_names_reader): Remove "data" parameter.
1374         (dw2_get_file_names): Use cutu_reader.
1375         (create_debug_type_hash_table): Update.
1376         (read_cutu_die_from_dwo): Update comment.
1377         (lookup_dwo_unit): Add dwo_name parameter.
1378         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
1379         die_reader_func_ftype and data parameters.
1380         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
1381         Remove die_reader_func_ftype and data parameters.
1382         (~cutu_reader): New; from init_cutu_and_read_dies.
1383         (cutu_reader::cutu_reader): Rename from
1384         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
1385         and data parameters.
1386         (init_cutu_and_read_dies_simple): Remove.
1387         (struct process_psymtab_comp_unit_data): Remove.
1388         (process_psymtab_comp_unit_reader): Remove data parameter; add
1389         want_partial_unit and pretend_language parameters.
1390         (process_psymtab_comp_unit): Use cutu_reader.
1391         (build_type_psymtabs_reader): Remove data parameter.
1392         (build_type_psymtabs_1): Use cutu_reader.
1393         (process_skeletonless_type_unit): Likewise.
1394         (load_partial_comp_unit_reader): Remove.
1395         (load_partial_comp_unit): Use cutu_reader.
1396         (load_full_comp_unit_reader): Remove.
1397         (load_full_comp_unit): Use cutu_reader.
1398         (struct create_dwo_cu_data): Remove.
1399         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
1400         dwo_unit parameters.
1401         (create_cus_hash_table): Use cutu_reader.
1402         (struct dwarf2_read_addr_index_data): Remove.
1403         (dwarf2_read_addr_index_reader): Remove.
1404         (dwarf2_read_addr_index): Use cutu_reader.
1405         (read_signatured_type_reader): Remove.
1406         (read_signatured_type): Use cutu_reader.
1407
1408 2020-01-19  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
1411         * tui/tui-wingeneral.h (class tui_suppress_output): New.
1412         (tui_wrefresh): Declare.
1413         * tui/tui-wingeneral.c (suppress_output): New global.
1414         (tui_suppress_output, ~tui_suppress_output): New constructor and
1415         destructor.
1416         (tui_wrefresh): New function.
1417         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
1418         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
1419         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
1420         method.
1421         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
1422         tui_wrefresh.
1423         (tui_data_window::no_refresh): New method.
1424         (tui_data_item_window::refresh_window): Call tui_wrefresh.
1425         (tui_reg_command): Use tui_suppress_output
1426         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
1427         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
1428         method.
1429         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
1430
1431 2020-01-19  Tom Tromey  <tom@tromey.com>
1432
1433         * tui/tui-winsource.c (tui_update_source_windows_with_line):
1434         Handle case where symtab is null.
1435
1436 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
1437
1438         * linux-fork.c (one_fork_p): Simplify.
1439
1440 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1441
1442         * top.c (struct qt_args): Remove.
1443         (kill_or_detach): Change return type to void, replace `void *`
1444         parameter with a proper one.
1445         (print_inferior_quit_action):  Likewise.
1446         (quit_confirm): Use range-based for loop to iterate over inferiors.
1447         (quit_force): Likewise.
1448
1449 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1450
1451         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
1452         `void *` parameter with proper parameters.
1453         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
1454         (print_one_inferior): Change return type to void, replace `void *`
1455         parameter with proper parameters.
1456         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
1457         inferiors.
1458         (get_other_inferior): Remove.
1459         (mi_cmd_remove_inferior): Use range-based loop to iterate over
1460         inferiors.
1461
1462 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1463
1464         * mi/mi-interp.c (report_initial_inferior): Remove.
1465         (mi_interp::init): Use range-based for to iterate over inferiors.
1466
1467 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
1468
1469         * python/py-inferior.c (build_inferior_list): Remove.
1470         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
1471
1472 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
1473
1474         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
1475         (btrace_stitch_trace): Likewise.
1476         * charset.c (intermediate_encoding): Likewise (vaild).
1477         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
1478         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
1479         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
1480
1481 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
1482
1483         * windows-tdep.c (windows_get_tlb_type):
1484         Add rtl_user_process_parameters type.
1485
1486 2020-01-16  Pedro Alves  <palves@redhat.com>
1487             Norbert Lange  <nolange79@gmail.com>
1488
1489         PR build/24805
1490         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
1491         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
1492         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
1493         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
1494         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
1495         (ps_plog): Redeclare exported functions with default visibility.
1496
1497 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
1498
1499         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
1500         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
1501
1502 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
1503
1504         * infcmd.c (post_create_inferior): Use get_thread_regcache
1505         instead of get_current_regcache.
1506
1507 2020-01-14  Tom Tromey  <tom@tromey.com>
1508
1509         PR symtab/12535:
1510         * python/python.c (gdbpy_decode_line): Treat empty string the same
1511         as no argument.
1512
1513 2020-01-14  Tom Tromey  <tom@tromey.com>
1514
1515         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
1516
1517 2020-01-14  Tom Tromey  <tom@tromey.com>
1518
1519         * nat/linux-btrace.c: Don't include <config.h>.
1520         * nat/linux-ptrace.c: Don't include <config.h>.
1521         * nat/x86-linux-dregs.c: Don't include <config.h>.
1522
1523 2020-01-14  Tom Tromey  <tom@tromey.com>
1524
1525         * configure: Rebuild.
1526         * configure.ac: Move many checks to ../gdbsupport/common.m4.
1527
1528 2020-01-14  Tom Tromey  <tom@tromey.com>
1529
1530         * nat/x86-linux-dregs.c: Include configh.h.
1531         * nat/linux-ptrace.c: Include configh.h.
1532         * nat/linux-btrace.c: Include configh.h.
1533         * defs.h: Include config.h, bfd.h.
1534         * configure.ac: Don't source common.host.
1535         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
1536         * configure: Rebuild.
1537         * acinclude.m4: Update path.
1538         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
1539         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
1540         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
1541         (CLIBS): Add LIBSUPPORT.
1542         (CDEPS): Likewise.
1543         (COMMON_SFILES): Remove gdbsupport files.
1544         (HFILES_NO_SRCDIR): Likewise.
1545         (stamp-version): Update path to create-version.sh.
1546         (ALLDEPFILES): Remove gdbsupport files.
1547
1548 2020-01-14  Tom Tromey  <tom@tromey.com>
1549
1550         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
1551         USE_WIN32API when needed.
1552         * configure.ac (USE_WIN32API): Don't define.
1553         (WIN32LIBS): Use WIN32APILIBS.
1554         * configure: Rebuild.
1555
1556 2020-01-14  Tom Tromey  <tom@tromey.com>
1557
1558         * configure: Rebuild.
1559         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
1560
1561 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1562
1563         * skip.c (skip_function_command): Make skip w/o arguments use the
1564         name of the inlined function if pc is inside any inlined function.
1565
1566 2020-01-14  Luis Machado  <luis.machado@linaro.org>
1567
1568         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
1569         * infrun.c (resume_1): Likewise.
1570         (handle_inferior_event): Remove stale comment.
1571         * linux-nat.c (linux_nat_target::resume): Update comments.
1572         (save_stop_reason): Likewise.
1573         (linux_nat_filter_event): Likewise.
1574         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
1575
1576 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1577
1578         * elfread.c (record_minimal_symbol): Set section index to 0 for
1579         non-allocatable sections.
1580
1581
1582 2020-01-13  Ali Tamur <tamur@google.com>
1583
1584         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
1585         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
1586         to gdb::optional.  Update comments.
1587         (dwo_file): Update comments.
1588         (read_attribute): Update API to take an additional out parameter,
1589         need_reprocess.  This is used to mark attributes that need other
1590         attributes (e.g. str_offsets_base) for correct computation which may not
1591         have been read yet.
1592         (read_attribute_reprocess): New function declaration.
1593         (read_addr_index): Likewise.
1594         (read_dwo_str_index): Likewise.
1595         (read_stub_str_index): Likewise.
1596         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
1597         (lookup_addr_base): New function definition.
1598         (lookup_ranges_base): Likewise.
1599         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
1600         lookup_ranges_base.
1601         (init_cutu_and_read_dies): Update comments.
1602         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
1603         unit.  This is used to inherit parent's str_offsets_base and addr_base.
1604         Update comments.
1605         (init_cutu_and_read_dies_simple): Reflect API changes.
1606         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
1607         (create_cus_hash_table): Change API to take parent compile unit.
1608         Reflect API changes.
1609         (open_and_init_dwo_file): Reflect API changes.
1610         (dwarf2_get_pc_bounds): Update comments.
1611         (dwarf2_record_block_ranges): Likewise.
1612         (read_full_die_1): Change implementation to reprocess attributes that
1613         need str_offsets_base and addr_base.
1614         (partial_die_info::read): Likewise.
1615         (read_attribute_reprocess): New function definition.
1616         (read_attribute_value): Change API to take an additional out parameter,
1617         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
1618         when a non-dwo compile unit has index based attributes.
1619         (read_attribute): Reflect API changes.
1620         (read_addr_index_1): Reflect API changes.  Update comments.
1621         (dwarf2_read_addr_index_data): Reflect API changes.
1622         (dwarf2_read_addr_index): Likewise.
1623         (read_str_index): Change API and implementation.  This becomes a helper
1624         to be used by the new string index related methods.  Update error
1625         message and comments.
1626         (read_dwo_str_index): New function definition.
1627         (read_stub_str_index): Likewise.
1628         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
1629         * symfile.h (dwarf2_debug_sections): Likewise.
1630         * xcoffread.c (dwarf2_debug_sections): Likewise.
1631
1632 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1633
1634         * gdbcore.h (struct core_fns) <core_read_registers>: Change
1635         core_reg_sect type to gdb_byte *.
1636         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
1637         * cris-tdep.c (fetch_core_registers): Likewise.
1638         * corelow.c (core_target::get_core_register_section): Change
1639         type of `contents` to gdb::byte_vector.
1640
1641 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1642
1643         * tui/tui-wingeneral.c (box_win): Position the title in the center
1644         of the border.
1645
1646 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
1647
1648         * corelow.c (core_target::get_core_register_section): Use
1649           std::vector instead of alloca.
1650
1651 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1652
1653         * warning.m4: Add -Wmissing-declarations to build_warnings.
1654         * configure: Re-generate.
1655
1656 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1657
1658         * python/python.c (init__gdb_module): Add declaration.
1659
1660 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
1661
1662         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
1663         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
1664         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
1665         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
1666         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
1667         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
1668         * ada-exp.y (_initialize_ada_exp): Add declaration.
1669         * ada-lang.c (_initialize_ada_language): Add declaration.
1670         * ada-tasks.c (_initialize_tasks): Add declaration.
1671         * agent.c (_initialize_agent): Add declaration.
1672         * aix-thread.c (_initialize_aix_thread): Add declaration.
1673         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
1674         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
1675         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
1676         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
1677         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
1678         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
1679         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
1680         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
1681         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
1682         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
1683         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
1684         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
1685         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
1686         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
1687         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
1688         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
1689         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
1690         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
1691         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
1692         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
1693         * annotate.c (_initialize_annotate): Add declaration.
1694         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
1695         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
1696         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
1697         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
1698         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
1699         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
1700         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
1701         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
1702         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
1703         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
1704         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
1705         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
1706         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
1707         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
1708         * auto-load.c (_initialize_auto_load): Add declaration.
1709         * auxv.c (_initialize_auxv): Add declaration.
1710         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
1711         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
1712         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
1713         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
1714         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
1715         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
1716         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
1717         * breakpoint.c (_initialize_breakpoint): Add declaration.
1718         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
1719         * btrace.c (_initialize_btrace): Add declaration.
1720         * charset.c (_initialize_charset): Add declaration.
1721         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
1722         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
1723         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
1724         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
1725         * cli/cli-script.c (_initialize_cli_script): Add declaration.
1726         * cli/cli-style.c (_initialize_cli_style): Add declaration.
1727         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
1728         * coffread.c (_initialize_coffread): Add declaration.
1729         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
1730         * compile/compile.c (_initialize_compile): Add declaration.
1731         * complaints.c (_initialize_complaints): Add declaration.
1732         * completer.c (_initialize_completer): Add declaration.
1733         * copying.c (_initialize_copying): Add declaration.
1734         * corefile.c (_initialize_core): Add declaration.
1735         * corelow.c (_initialize_corelow): Add declaration.
1736         * cp-abi.c (_initialize_cp_abi): Add declaration.
1737         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
1738         * cp-support.c (_initialize_cp_support): Add declaration.
1739         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
1740         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
1741         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
1742         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
1743         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
1744         * ctfread.c (_initialize_ctfread): Add declaration.
1745         * d-lang.c (_initialize_d_language): Add declaration.
1746         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
1747         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
1748         * dbxread.c (_initialize_dbxread): Add declaration.
1749         * dcache.c (_initialize_dcache): Add declaration.
1750         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
1751         * disasm.c (_initialize_disasm): Add declaration.
1752         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
1753         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
1754         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
1755         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
1756         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
1757         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
1758         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
1759         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
1760         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
1761         * elfread.c (_initialize_elfread): Add declaration.
1762         * exec.c (_initialize_exec): Add declaration.
1763         * extension.c (_initialize_extension): Add declaration.
1764         * f-lang.c (_initialize_f_language): Add declaration.
1765         * f-valprint.c (_initialize_f_valprint): Add declaration.
1766         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
1767         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
1768         * filesystem.c (_initialize_filesystem): Add declaration.
1769         * findcmd.c (_initialize_mem_search): Add declaration.
1770         * findvar.c (_initialize_findvar): Add declaration.
1771         * fork-child.c (_initialize_fork_child): Add declaration.
1772         * frame-base.c (_initialize_frame_base): Add declaration.
1773         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
1774         * frame.c (_initialize_frame): Add declaration.
1775         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
1776         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
1777         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
1778         * gcore.c (_initialize_gcore): Add declaration.
1779         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
1780         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
1781         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
1782         * gdbarch.c (_initialize_gdbarch): Add declaration.
1783         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
1784         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
1785         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
1786         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
1787         * go-lang.c (_initialize_go_language): Add declaration.
1788         * go32-nat.c (_initialize_go32_nat): Add declaration.
1789         * guile/guile.c (_initialize_guile): Add declaration.
1790         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
1791         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
1792         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
1793         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
1794         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
1795         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
1796         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
1797         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
1798         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
1799         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
1800         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
1801         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
1802         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
1803         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
1804         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
1805         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
1806         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
1807         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
1808         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
1809         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
1810         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
1811         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
1812         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
1813         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
1814         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
1815         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
1816         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
1817         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
1818         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
1819         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
1820         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
1821         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
1822         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
1823         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
1824         * infcall.c (_initialize_infcall): Add declaration.
1825         * infcmd.c (_initialize_infcmd): Add declaration.
1826         * inflow.c (_initialize_inflow): Add declaration.
1827         * infrun.c (_initialize_infrun): Add declaration.
1828         * interps.c (_initialize_interpreter): Add declaration.
1829         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
1830         * jit.c (_initialize_jit): Add declaration.
1831         * language.c (_initialize_language): Add declaration.
1832         * linux-fork.c (_initialize_linux_fork): Add declaration.
1833         * linux-nat.c (_initialize_linux_nat): Add declaration.
1834         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
1835         * linux-thread-db.c (_initialize_thread_db): Add declaration.
1836         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
1837         * m2-lang.c (_initialize_m2_language): Add declaration.
1838         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
1839         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
1840         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
1841         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
1842         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
1843         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
1844         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
1845         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
1846         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
1847         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
1848         * machoread.c (_initialize_machoread): Add declaration.
1849         * macrocmd.c (_initialize_macrocmd): Add declaration.
1850         * macroscope.c (_initialize_macroscope): Add declaration.
1851         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
1852         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
1853         * maint.c (_initialize_maint_cmds): Add declaration.
1854         * mdebugread.c (_initialize_mdebugread): Add declaration.
1855         * memattr.c (_initialize_mem): Add declaration.
1856         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
1857         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
1858         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
1859         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
1860         * mi/mi-main.c (_initialize_mi_main): Add declaration.
1861         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
1862         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
1863         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
1864         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
1865         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
1866         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
1867         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
1868         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
1869         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
1870         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
1871         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
1872         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
1873         * mipsread.c (_initialize_mipsread): Add declaration.
1874         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
1875         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
1876         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
1877         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
1878         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
1879         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
1880         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
1881         * nto-procfs.c (_initialize_procfs): Add declaration.
1882         * objc-lang.c (_initialize_objc_language): Add declaration.
1883         * observable.c (_initialize_observer): Add declaration.
1884         * opencl-lang.c (_initialize_opencl_language): Add declaration.
1885         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
1886         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
1887         * osabi.c (_initialize_gdb_osabi): Add declaration.
1888         * osdata.c (_initialize_osdata): Add declaration.
1889         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
1890         * parse.c (_initialize_parse): Add declaration.
1891         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
1892         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
1893         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
1894         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
1895         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
1896         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
1897         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
1898         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
1899         * printcmd.c (_initialize_printcmd): Add declaration.
1900         * probe.c (_initialize_probe): Add declaration.
1901         * proc-api.c (_initialize_proc_api): Add declaration.
1902         * proc-events.c (_initialize_proc_events): Add declaration.
1903         * proc-service.c (_initialize_proc_service): Add declaration.
1904         * procfs.c (_initialize_procfs): Add declaration.
1905         * producer.c (_initialize_producer): Add declaration.
1906         * psymtab.c (_initialize_psymtab): Add declaration.
1907         * python/python.c (_initialize_python): Add declaration.
1908         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
1909         * record-btrace.c (_initialize_record_btrace): Add declaration.
1910         * record-full.c (_initialize_record_full): Add declaration.
1911         * record.c (_initialize_record): Add declaration.
1912         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
1913         * regcache.c (_initialize_regcache): Add declaration.
1914         * reggroups.c (_initialize_reggroup): Add declaration.
1915         * remote-notif.c (_initialize_notif): Add declaration.
1916         * remote-sim.c (_initialize_remote_sim): Add declaration.
1917         * remote.c (_initialize_remote): Add declaration.
1918         * reverse.c (_initialize_reverse): Add declaration.
1919         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
1920         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
1921         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
1922         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
1923         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
1924         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
1925         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
1926         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
1927         Add declaration.
1928         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
1929         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
1930         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
1931         * rust-exp.y (_initialize_rust_exp): Add declaration.
1932         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
1933         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
1934         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
1935         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
1936         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
1937         * score-tdep.c (_initialize_score_tdep): Add declaration.
1938         * ser-go32.c (_initialize_ser_dos): Add declaration.
1939         * ser-mingw.c (_initialize_ser_windows): Add declaration.
1940         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
1941         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
1942         * ser-uds.c (_initialize_ser_socket): Add declaration.
1943         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
1944         * serial.c (_initialize_serial): Add declaration.
1945         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
1946         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
1947         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
1948         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
1949         * skip.c (_initialize_step_skip): Add declaration.
1950         * sol-thread.c (_initialize_sol_thread): Add declaration.
1951         * solib-aix.c (_initialize_solib_aix): Add declaration.
1952         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
1953         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
1954         * solib-frv.c (_initialize_frv_solib): Add declaration.
1955         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
1956         * solib-target.c (_initialize_solib_target): Add declaration.
1957         * solib.c (_initialize_solib): Add declaration.
1958         * source-cache.c (_initialize_source_cache): Add declaration.
1959         * source.c (_initialize_source): Add declaration.
1960         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
1961         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
1962         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
1963         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
1964         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
1965         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
1966         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
1967         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
1968         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
1969         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
1970         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
1971         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
1972         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
1973         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
1974         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
1975         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
1976         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
1977         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
1978         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
1979         * stabsread.c (_initialize_stabsread): Add declaration.
1980         * stack.c (_initialize_stack): Add declaration.
1981         * stap-probe.c (_initialize_stap_probe): Add declaration.
1982         * std-regs.c (_initialize_frame_reg): Add declaration.
1983         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
1984         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
1985         * symfile.c (_initialize_symfile): Add declaration.
1986         * symmisc.c (_initialize_symmisc): Add declaration.
1987         * symtab.c (_initialize_symtab): Add declaration.
1988         * target.c (_initialize_target): Add declaration.
1989         * target-connection.c (_initialize_target_connection): Add
1990         declaration.
1991         * target-dcache.c (_initialize_target_dcache): Add declaration.
1992         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
1993         * thread.c (_initialize_thread): Add declaration.
1994         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
1995         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
1996         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
1997         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
1998         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
1999         * tracectf.c (_initialize_ctf): Add declaration.
2000         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
2001         * tracefile.c (_initialize_tracefile): Add declaration.
2002         * tracepoint.c (_initialize_tracepoint): Add declaration.
2003         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
2004         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
2005         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
2006         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
2007         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
2008         * tui/tui-win.c (_initialize_tui_win): Add declaration.
2009         * tui/tui.c (_initialize_tui): Add declaration.
2010         * typeprint.c (_initialize_typeprint): Add declaration.
2011         * ui-style.c (_initialize_ui_style): Add declaration.
2012         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
2013         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
2014         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
2015         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
2016         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
2017         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
2018         * unittests/filtered_iterator-selftests.c
2019         (_initialize_filtered_iterator_selftests): Add declaration.
2020         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
2021         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
2022         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
2023         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
2024         * unittests/main-thread-selftests.c
2025         (_initialize_main_thread_selftests): Add declaration.
2026         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
2027         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
2028         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
2029         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
2030         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
2031         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
2032         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
2033         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
2034         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
2035         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
2036         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
2037         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
2038         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
2039         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
2040         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
2041         declaration.
2042         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
2043         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
2044         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
2045         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
2046         * user-regs.c (_initialize_user_regs): Add declaration.
2047         * utils.c (_initialize_utils): Add declaration.
2048         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
2049         * valops.c (_initialize_valops): Add declaration.
2050         * valprint.c (_initialize_valprint): Add declaration.
2051         * value.c (_initialize_values): Add declaration.
2052         * varobj.c (_initialize_varobj): Add declaration.
2053         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
2054         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
2055         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
2056         * windows-nat.c (_initialize_windows_nat): Add declaration.
2057         (_initialize_check_for_gdb_ini): Add declaration.
2058         (_initialize_loadable): Add declaration.
2059         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
2060         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
2061         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
2062         * xcoffread.c (_initialize_xcoffread): Add declaration.
2063         * xml-support.c (_initialize_xml_support): Add declaration.
2064         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
2065         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
2066         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
2067         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
2068
2069 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2070
2071         * regformats/regdat.sh: Generate declaration for init function.
2072
2073 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
2074
2075         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
2076         up.
2077         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
2078         close_one_inferior>: New methods.
2079         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
2080         pass down target to find_inferior_pid.
2081         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
2082         Pass down target to find_inferior_ptid.
2083         (gdbsim_target::create_inferior): Pass down target to
2084         add_thread_silent.
2085         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
2086         target down to find_inferior_ptid and switch_to_thread.
2087         (gdbsim_target::close): Update to call close_one_inferior.
2088         (struct resume_data): Remove.
2089         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
2090         directly, rather than through a void pointer.
2091         (gdbsim_target::resume): Update to call resume_one_inferior.
2092
2093 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
2094
2095         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
2096
2097 2020-01-12  Pedro Alves  <palves@redhat.com>
2098
2099         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
2100         directly for the current inferior instead of
2101         discard_all_inferiors.
2102         (discard_all_inferiors): Delete.
2103
2104 2020-01-11  Tom Tromey  <tom@tromey.com>
2105
2106         * tui/tui-wingeneral.c (box_win): Check cli_styling.
2107         * tui/tui-winsource.c (tui_source_window_base::refill): Use
2108         deprecated_safe_get_selected_frame.
2109
2110 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2111
2112         * inferior.c (print_inferior): Switch inferior before printing it.
2113
2114 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
2115             Pedro Alves  <palves@redhat.com>
2116
2117         * progspace-and-thread.c (switch_to_program_space_and_thread):
2118         Assert there's an inferior for PSPACE.  Use
2119         switch_to_inferior_no_thread to switch the inferior too.
2120         * progspace.c (program_space::~program_space): Call
2121         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
2122         (program_space::free_all_objfiles): Don't call clear_symtab_users
2123         here.
2124         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
2125
2126 2020-01-10  Pedro Alves  <palves@redhat.com>
2127
2128         * NEWS: Mention multi-target debugging, "info connections", and
2129         "add-inferior -no-connection".
2130
2131 2020-01-10  Pedro Alves  <palves@redhat.com>
2132
2133         * infrun.c: Include "target-connection.h".
2134         (check_multi_target_resumption): New.
2135         (proceed): Call it.
2136         * target-connection.c (make_target_connection_string): Make
2137         extern.
2138         * target-connection.h (make_target_connection_string): Declare.
2139
2140 2020-01-10  Pedro Alves  <palves@redhat.com>
2141
2142         * Makefile.in (COMMON_SFILES): Add target-connection.c.
2143         * inferior.c (uiout_field_connection): New function.
2144         (print_inferior): Add new "connection-id" column.
2145         (add_inferior_command): Show connection number/string of added
2146         inferior.
2147         * process-stratum-target.h
2148         (process_stratum_target::connection_string): New virtual method.
2149         (process_stratum_target::connection_number): New field.
2150         * remote.c (remote_target::connection_string): New override.
2151         * target-connection.c: New file.
2152         * target-connection.h: New file.
2153         * target.c (decref_target): Remove process_stratum targets from
2154         the connection list.
2155         (target_stack::push): Add process_stratum targets to the
2156         connection list.
2157
2158 2020-01-10  Pedro Alves  <palves@redhat.com>
2159
2160         Revert:
2161         2016-04-12  Pedro Alves  <palves@redhat.com>
2162         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
2163         Remove references to name.
2164         * serial.h (struct serial) <name>: Delete.
2165
2166 2020-01-10  Pedro Alves  <palves@redhat.com>
2167
2168         * gdbarch-selftests.c (register_to_value_test): Remove "target
2169         already pushed" check.
2170
2171 2020-01-10  Pedro Alves  <palves@redhat.com>
2172             John Baldwin  <jhb@FreeBSD.org>
2173
2174         * aarch64-linux-nat.c
2175         (aarch64_linux_nat_target::thread_architecture): Adjust.
2176         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
2177         (task_command_1): Likewise.
2178         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
2179         (aix_thread_target::wait, aix_thread_target::fetch_registers)
2180         (aix_thread_target::store_registers)
2181         (aix_thread_target::thread_alive): Adjust.
2182         * amd64-fbsd-tdep.c: Include "inferior.h".
2183         (amd64fbsd_get_thread_local_address): Pass down target.
2184         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
2185         thread's gdbarch instead of target_gdbarch.
2186         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
2187         get_last_target_status.
2188         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
2189         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
2190         inferiors.
2191         (update_inserted_breakpoint_locations): Skip if inferiors with no
2192         execution.
2193         (update_global_location_list): When handling moribund locations,
2194         find representative inferior for location's pspace, and use thread
2195         count of its process_stratum target.
2196         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
2197         * bsd-uthread.c (bsd_uthread_target::wait): Use
2198         as_process_stratum_target and adjust thread_change_ptid and
2199         add_thread calls.
2200         (bsd_uthread_target::update_thread_list): Use
2201         as_process_stratum_target and adjust find_thread_ptid,
2202         thread_change_ptid and add_thread calls.
2203         * btrace.c (maint_btrace_packet_history_cmd): Adjust
2204         find_thread_ptid call.
2205         * corelow.c (add_to_thread_list): Adjust add_thread call.
2206         (core_target_open): Adjust add_thread_silent and thread_count
2207         calls.
2208         (core_target::pid_to_str): Adjust find_inferior_ptid call.
2209         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
2210         * event-top.c (async_disconnect): Pop targets from all inferiors.
2211         * exec.c (add_target_sections): Push exec target on all inferiors
2212         sharing the program space.
2213         (remove_target_sections): Remove the exec target from all
2214         inferiors sharing the program space.
2215         (exec_on_vfork): New.
2216         * exec.h (exec_on_vfork): Declare.
2217         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
2218         Pass it down.
2219         (fbsd_nat_target::update_thread_list): Adjust.
2220         (fbsd_nat_target::resume): Adjust.
2221         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
2222         down.
2223         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
2224         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
2225         get_thread_arch_regcache call.
2226         * fork-child.c (gdb_startup_inferior): Pass target down to
2227         startup_inferior and set_executing.
2228         * gdbthread.h (struct process_stratum_target): Forward declare.
2229         (add_thread, add_thread_silent, add_thread_with_info)
2230         (in_thread_list): Add process_stratum_target parameter.
2231         (find_thread_ptid(inferior*, ptid_t)): New overload.
2232         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
2233         parameter.
2234         (all_threads()): Delete overload.
2235         (all_threads, all_non_exited_threads): Add process_stratum_target
2236         parameter.
2237         (all_threads_safe): Use brace initialization.
2238         (thread_count): Add process_stratum_target parameter.
2239         (set_resumed, set_running, set_stop_requested, set_executing)
2240         (threads_are_executing, finish_thread_state): Add
2241         process_stratum_target parameter.
2242         (switch_to_thread): Use is_current_thread.
2243         * i386-fbsd-tdep.c: Include "inferior.h".
2244         (i386fbsd_get_thread_local_address): Pass down target.
2245         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
2246         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
2247         have_inferiors check.
2248         * inf-ptrace.c (inf_ptrace_target::create_inferior)
2249         (inf_ptrace_target::attach): Adjust.
2250         * infcall.c (run_inferior_call): Adjust.
2251         * infcmd.c (run_command_1): Pass target to
2252         scoped_finish_thread_state.
2253         (proceed_thread_callback): Skip inferiors with no execution.
2254         (continue_command): Rename 'all_threads' local to avoid hiding
2255         'all_threads' function.  Adjust get_last_target_status call.
2256         (prepare_one_step): Adjust set_running call.
2257         (signal_command): Use user_visible_resume_target.  Compare thread
2258         pointers instead of inferior_ptid.
2259         (info_program_command): Adjust to pass down target.
2260         (attach_command): Mark target's 'thread_executing' flag.
2261         (stop_current_target_threads_ns): New, factored out from ...
2262         (interrupt_target_1): ... this.  Switch inferior before making
2263         target calls.
2264         * inferior-iter.h
2265         (struct all_inferiors_iterator, struct all_inferiors_range)
2266         (struct all_inferiors_safe_range)
2267         (struct all_non_exited_inferiors_range): Filter on
2268         process_stratum_target too.  Remove explicit.
2269         * inferior.c (inferior::inferior): Push dummy target on target
2270         stack.
2271         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
2272         Add process_stratum_target parameter, and pass it down.
2273         (have_live_inferiors): Adjust.
2274         (switch_to_inferior_and_push_target): New.
2275         (add_inferior_command, clone_inferior_command): Handle
2276         "-no-connection" parameter.  Use
2277         switch_to_inferior_and_push_target.
2278         (_initialize_inferior): Mention "-no-connection" option in
2279         the help of "add-inferior" and "clone-inferior" commands.
2280         * inferior.h: Include "process-stratum-target.h".
2281         (interrupt_target_1): Use bool.
2282         (struct inferior) <push_target, unpush_target, target_is_pushed,
2283         find_target_beneath, top_target, process_target, target_at,
2284         m_stack>: New.
2285         (discard_all_inferiors): Delete.
2286         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
2287         (all_inferiors, all_non_exited_inferiors): Add
2288         process_stratum_target parameter.
2289         * infrun.c: Include "gdb_select.h" and <unordered_map>.
2290         (target_last_proc_target): New global.
2291         (follow_fork_inferior): Push target on new inferior.  Pass target
2292         to add_thread_silent.  Call exec_on_vfork.  Handle target's
2293         reference count.
2294         (follow_fork): Adjust get_last_target_status call.  Also consider
2295         target.
2296         (follow_exec): Push target on new inferior.
2297         (struct execution_control_state) <target>: New field.
2298         (user_visible_resume_target): New.
2299         (do_target_resume): Call target_async.
2300         (resume_1): Set target's threads_executing flag.  Consider resume
2301         target.
2302         (commit_resume_all_targets): New.
2303         (proceed): Also consider resume target.  Skip threads of inferiors
2304         with no execution.  Commit resumtion in all targets.
2305         (start_remote): Pass current inferior to wait_for_inferior.
2306         (infrun_thread_stop_requested): Consider target as well.  Pass
2307         thread_info pointer to clear_inline_frame_state instead of ptid.
2308         (infrun_thread_thread_exit): Consider target as well.
2309         (random_pending_event_thread): New inferior parameter.  Use it.
2310         (do_target_wait): Rename to ...
2311         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
2312         down.
2313         (threads_are_resumed_pending_p, do_target_wait): New.
2314         (prepare_for_detach): Adjust calls.
2315         (wait_for_inferior): New inferior parameter.  Handle it.  Use
2316         do_target_wait_1 instead of do_target_wait.
2317         (fetch_inferior_event): Adjust.  Switch to representative
2318         inferior.  Pass target down.
2319         (set_last_target_status): Add process_stratum_target parameter.
2320         Save target in global.
2321         (get_last_target_status): Add process_stratum_target parameter and
2322         handle it.
2323         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
2324         (context_switch): Check inferior_ptid == null_ptid before calling
2325         inferior_thread().
2326         (get_inferior_stop_soon): Pass down target.
2327         (wait_one): Rename to ...
2328         (poll_one_curr_target): ... this.
2329         (struct wait_one_event): New.
2330         (wait_one): New.
2331         (stop_all_threads): Adjust.
2332         (handle_no_resumed, handle_inferior_event): Adjust to consider the
2333         event's target.
2334         (switch_back_to_stepped_thread): Also consider target.
2335         (print_stop_event): Update.
2336         (normal_stop): Update.  Also consider the resume target.
2337         * infrun.h (wait_for_inferior): Remove declaration.
2338         (user_visible_resume_target): New declaration.
2339         (get_last_target_status, set_last_target_status): New
2340         process_stratum_target parameter.
2341         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
2342         process_stratum_target parameter, and use it.
2343         (clear_inline_frame_state (thread_info*)): New.
2344         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
2345         process_stratum_target parameter.
2346         (clear_inline_frame_state (thread_info*)): Declare.
2347         * linux-fork.c (delete_checkpoint_command): Pass target down to
2348         find_thread_ptid.
2349         (checkpoint_command): Adjust.
2350         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
2351         instead of just tweaking inferior_ptid.
2352         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
2353         (exit_lwp): Pass target down to find_thread_ptid.
2354         (attach_proc_task_lwp_callback): Pass target down to
2355         add_thread/set_running/set_executing.
2356         (linux_nat_target::attach): Pass target down to
2357         thread_change_ptid.
2358         (get_detach_signal): Pass target down to find_thread_ptid.
2359         Consider last target status's target.
2360         (linux_resume_one_lwp_throw, resume_lwp)
2361         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
2362         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
2363         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
2364         (linux_nat_target::async_wait_fd): New.
2365         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
2366         target down.
2367         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
2368         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
2369         * linux-thread-db.c (struct thread_db_info::process_target): New
2370         field.
2371         (add_thread_db_info): Save target.
2372         (get_thread_db_info): New process_stratum_target parameter.  Also
2373         match target.
2374         (delete_thread_db_info): New process_stratum_target parameter.
2375         Also match target.
2376         (thread_from_lwp): Adjust to pass down target.
2377         (thread_db_notice_clone): Pass down target.
2378         (check_thread_db_callback): Pass down target.
2379         (try_thread_db_load_1): Always push the thread_db target.
2380         (try_thread_db_load, record_thread): Pass target down.
2381         (thread_db_target::detach): Pass target down.  Always unpush the
2382         thread_db target.
2383         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
2384         target down.  Always unpush the thread_db target.
2385         (find_new_threads_callback, thread_db_find_new_threads_2)
2386         (thread_db_target::update_thread_list): Pass target down.
2387         (thread_db_target::pid_to_str): Pass current inferior down.
2388         (thread_db_target::get_thread_local_address): Pass target down.
2389         (thread_db_target::resume, maintenance_check_libthread_db): Pass
2390         target down.
2391         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
2392         * procfs.c (procfs_target::procfs_init_inferior): Declare.
2393         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
2394         (procfs_init_inferior): Rename to ...
2395         (procfs_target::procfs_init_inferior): ... this and adjust.
2396         (procfs_target::create_inferior, procfs_notice_thread)
2397         (procfs_do_thread_registers): Adjust.
2398         * ppc-fbsd-tdep.c: Include "inferior.h".
2399         (ppcfbsd_get_thread_local_address): Pass down target.
2400         * proc-service.c (ps_xfer_memory): Switch current inferior and
2401         program space as well.
2402         (get_ps_regcache): Pass target down.
2403         * process-stratum-target.c
2404         (process_stratum_target::thread_address_space)
2405         (process_stratum_target::thread_architecture): Pass target down.
2406         * process-stratum-target.h
2407         (process_stratum_target::threads_executing): New field.
2408         (as_process_stratum_target): New.
2409         * ravenscar-thread.c
2410         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
2411         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
2412         down.
2413         * record-btrace.c (record_btrace_target::info_record): Adjust.
2414         (record_btrace_target::record_method)
2415         (record_btrace_target::record_is_replaying)
2416         (record_btrace_target::fetch_registers)
2417         (get_thread_current_frame_id, record_btrace_target::resume)
2418         (record_btrace_target::wait, record_btrace_target::stop): Pass
2419         target down.
2420         * record-full.c (record_full_wait_1): Switch to event thread.
2421         Pass target down.
2422         * regcache.c (regcache::regcache)
2423         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
2424         process_stratum_target parameter and handle it.
2425         (current_thread_target): New global.
2426         (get_thread_regcache): Add process_stratum_target parameter and
2427         handle it.  Switch inferior before calling target method.
2428         (get_thread_regcache): Pass target down.
2429         (get_thread_regcache_for_ptid): Pass target down.
2430         (registers_changed_ptid): Add process_stratum_target parameter and
2431         handle it.
2432         (registers_changed_thread, registers_changed): Pass target down.
2433         (test_get_thread_arch_aspace_regcache): New.
2434         (current_regcache_test): Define a couple local test_target_ops
2435         instances and use them for testing.
2436         (readwrite_regcache): Pass process_stratum_target parameter.
2437         (cooked_read_test, cooked_write_test): Pass mock_target down.
2438         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
2439         (get_thread_arch_aspace_regcache): Add process_stratum_target
2440         parameter.
2441         (regcache::target): New method.
2442         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
2443         (regcache::registers_changed_ptid): Add process_stratum_target
2444         parameter.
2445         (regcache::m_target): New field.
2446         (registers_changed_ptid): Add process_stratum_target parameter.
2447         * remote.c (remote_state::supports_vCont_probed): New field.
2448         (remote_target::async_wait_fd): New method.
2449         (remote_unpush_and_throw): Add remote_target parameter.
2450         (get_current_remote_target): Adjust.
2451         (remote_target::remote_add_inferior): Push target.
2452         (remote_target::remote_add_thread)
2453         (remote_target::remote_notice_new_inferior)
2454         (get_remote_thread_info): Pass target down.
2455         (remote_target::update_thread_list): Skip threads of inferiors
2456         bound to other targets.  (remote_target::close): Don't discard
2457         inferiors.  (remote_target::add_current_inferior_and_thread)
2458         (remote_target::process_initial_stop_replies)
2459         (remote_target::start_remote)
2460         (remote_target::remote_serial_quit_handler): Pass down target.
2461         (remote_target::remote_unpush_target): New remote_target
2462         parameter.  Unpush the target from all inferiors.
2463         (remote_target::remote_unpush_and_throw): New remote_target
2464         parameter.  Pass it down.
2465         (remote_target::open_1): Check whether the current inferior has
2466         execution instead of checking whether any inferior is live.  Pass
2467         target down.
2468         (remote_target::remote_detach_1): Pass down target.  Use
2469         remote_unpush_target.
2470         (extended_remote_target::attach): Pass down target.
2471         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
2472         (remote_target::append_resumption): Pass down target.
2473         (remote_target::append_pending_thread_resumptions)
2474         (remote_target::remote_resume_with_hc, remote_target::resume)
2475         (remote_target::commit_resume): Pass down target.
2476         (remote_target::remote_stop_ns): Check supports_vCont_probed.
2477         (remote_target::interrupt_query)
2478         (remote_target::remove_new_fork_children)
2479         (remote_target::check_pending_events_prevent_wildcard_vcont)
2480         (remote_target::remote_parse_stop_reply)
2481         (remote_target::process_stop_reply): Pass down target.
2482         (first_remote_resumed_thread): New remote_target parameter.  Pass
2483         it down.
2484         (remote_target::wait_as): Pass down target.
2485         (unpush_and_perror): New remote_target parameter.  Pass it down.
2486         (remote_target::readchar, remote_target::remote_serial_write)
2487         (remote_target::getpkt_or_notif_sane_1)
2488         (remote_target::kill_new_fork_children, remote_target::kill): Pass
2489         down target.
2490         (remote_target::mourn_inferior): Pass down target.  Use
2491         remote_unpush_target.
2492         (remote_target::core_of_thread)
2493         (remote_target::remote_btrace_maybe_reopen): Pass down target.
2494         (remote_target::pid_to_exec_file)
2495         (remote_target::thread_handle_to_thread_info): Pass down target.
2496         (remote_target::async_wait_fd): New.
2497         * riscv-fbsd-tdep.c: Include "inferior.h".
2498         (riscv_fbsd_get_thread_local_address): Pass down target.
2499         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
2500         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
2501         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
2502         Adjust.
2503         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
2504         * solib-svr4.c (enable_break): Pass down target.
2505         * spu-multiarch.c (parse_spufs_run): Pass down target.
2506         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
2507         * target-delegates.c: Regenerate.
2508         * target.c (g_target_stack): Delete.
2509         (current_top_target): Return the current inferior's top target.
2510         (target_has_execution_1): Refer to the passed-in inferior's top
2511         target.
2512         (target_supports_terminal_ours): Check whether the initial
2513         inferior was already created.
2514         (decref_target): New.
2515         (target_stack::push): Incref/decref the target.
2516         (push_target, push_target, unpush_target): Adjust.
2517         (target_stack::unpush): Defref target.
2518         (target_is_pushed): Return bool.  Adjust to refer to the current
2519         inferior's target stack.
2520         (dispose_inferior): Delete, and inline parts ...
2521         (target_preopen): ... here.  Only dispose of the current inferior.
2522         (target_detach): Hold strong target reference while detaching.
2523         Pass target down.
2524         (target_thread_name): Add assertion.
2525         (target_resume): Pass down target.
2526         (target_ops::beneath, find_target_at): Adjust to refer to the
2527         current inferior's target stack.
2528         (get_dummy_target): New.
2529         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
2530         has a thread running.
2531         (initialize_targets): Rename to ...
2532         (_initialize_target): ... this.
2533         * target.h: Include "gdbsupport/refcounted-object.h".
2534         (struct target_ops): Inherit refcounted_object.
2535         (target_ops::shortname, target_ops::longname): Make const.
2536         (target_ops::async_wait_fd): New method.
2537         (decref_target): Declare.
2538         (struct target_ops_ref_policy): New.
2539         (target_ops_ref): New typedef.
2540         (get_dummy_target): Declare function.
2541         (target_is_pushed): Return bool.
2542         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
2543         (all_matching_threads_iterator::all_matching_threads_iterator):
2544         Handle filter target.
2545         * thread-iter.h (struct all_matching_threads_iterator, struct
2546         all_matching_threads_range, class all_non_exited_threads_range):
2547         Filter by target too.  Remove explicit.
2548         * thread.c (threads_executing): Delete.
2549         (inferior_thread): Pass down current inferior.
2550         (clear_thread_inferior_resources): Pass down thread pointer
2551         instead of ptid_t.
2552         (add_thread_silent, add_thread_with_info, add_thread): Add
2553         process_stratum_target parameter.  Use it for thread and inferior
2554         searches.
2555         (is_current_thread): New.
2556         (thread_info::deletable): Use it.
2557         (find_thread_ptid, thread_count, in_thread_list)
2558         (thread_change_ptid, set_resumed, set_running): New
2559         process_stratum_target parameter.  Pass it down.
2560         (set_executing): New process_stratum_target parameter.  Pass it
2561         down.  Adjust reference to 'threads_executing'.
2562         (threads_are_executing): New process_stratum_target parameter.
2563         Adjust reference to 'threads_executing'.
2564         (set_stop_requested, finish_thread_state): New
2565         process_stratum_target parameter.  Pass it down.
2566         (switch_to_thread): Also match inferior.
2567         (switch_to_thread): New process_stratum_target parameter.  Pass it
2568         down.
2569         (update_threads_executing): Reimplement.
2570         * top.c (quit_force): Pop targets from all inferior.
2571         (gdb_init): Don't call initialize_targets.
2572         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
2573         Declare.
2574         (windows_add_thread, windows_delete_thread): Adjust.
2575         (get_windows_debug_event): Rename to ...
2576         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
2577         * tracefile-tfile.c (tfile_target_open): Pass down target.
2578         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
2579         Forward declare.
2580         (switch_to_thread): Add process_stratum_target parameter.
2581         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
2582         parameter.  Use it.
2583         (mi_on_resume): Pass target down.
2584         * nat/fork-inferior.c (startup_inferior): Add
2585         process_stratum_target parameter.  Pass it down.
2586         * nat/fork-inferior.h (startup_inferior): Add
2587         process_stratum_target parameter.
2588         * python/py-threadevent.c (py_get_event_thread): Pass target down.
2589
2590 2020-01-10  Pedro Alves  <palves@redhat.com>
2591
2592         * remote.c (remote_target::start_remote): Don't set inferior_ptid
2593         directly.  Instead find the first thread in the thread list and
2594         use switch_to_thread.
2595
2596 2020-01-10  Pedro Alves  <palves@redhat.com>
2597
2598         * remote.c (remote_target::remote_add_inferior): Don't bind a
2599         process to the current inferior if the current inferior is already
2600         bound to a process.
2601
2602 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2603             Pedro Alves  <palves@redhat.com>
2604
2605         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
2606         If no process is specified, return null_ptid instead of
2607         inferior_ptid.
2608         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
2609         TARGET_WAITKIND_SIGNALLED with no pid.
2610
2611 2020-01-10  Pedro Alves  <palves@redhat.com>
2612
2613         * remote.c (first_remote_resumed_thread): New.
2614         (remote_target::wait_as): Use it as default event_ptid instead of
2615         inferior_ptid.
2616
2617 2020-01-10  Pedro Alves  <palves@redhat.com>
2618
2619         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
2620
2621 2020-01-10  Pedro Alves  <palves@redhat.com>
2622
2623         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
2624         not -1.
2625
2626 2020-01-10  Pedro Alves  <palves@redhat.com>
2627
2628         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
2629         ptid to get_last_target_status.
2630         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
2631         ptid to get_last_target_status.
2632         * infcmd.c (continue_command): Don't pass a target_waitstatus to
2633         get_last_target_status.
2634         (info_program_command): Don't pass a target_waitstatus to
2635         get_last_target_status.
2636         * infrun.c (init_wait_for_inferior): Use
2637         nullify_last_target_wait_ptid.
2638         (get_last_target_status): Handle nullptr arguments.
2639         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
2640         (print_stop_event): Don't pass a ptid to get_last_target_status.
2641         (normal_stop): Don't pass a ptid to get_last_target_status.
2642         * infrun.h (get_last_target_status, set_last_target_status): Move
2643         comments here and update.
2644         (nullify_last_target_wait_ptid): Declare.
2645         * linux-fork.c (fork_load_infrun_state): Remove local extern
2646         declaration of nullify_last_target_wait_ptid.
2647         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
2648         to get_last_target_status.
2649
2650 2020-01-10  Pedro Alves  <palves@redhat.com>
2651
2652         * gdbthread.h (scoped_restore_current_thread)
2653         <dont_restore, restore, m_dont_restore>: Declare.
2654         * thread.c (thread_alive): Add assertion.  Return bool.
2655         (switch_to_thread_if_alive): New.
2656         (prune_threads): Switch inferior/thread.
2657         (print_thread_info_1): Switch thread before calling target methods.
2658         (scoped_restore_current_thread::restore): New, factored out from
2659         ...
2660         (scoped_restore_current_thread::~scoped_restore_current_thread):
2661         ... this.
2662         (scoped_restore_current_thread::scoped_restore_current_thread):
2663         Add assertion.
2664         (thread_apply_all_command, thread_select): Use
2665         switch_to_thread_if_alive.
2666         * infrun.c (proceed, restart_threads, handle_signal_stop)
2667         (switch_back_to_stepped_thread): Switch current thread before
2668         calling target methods.
2669
2670 2020-01-10  Pedro Alves <palves@redhat.com>
2671
2672         * inferior.c (switch_to_inferior_no_thread): New function,
2673         factored out from ...
2674         (inferior_command): ... here.
2675         * inferior.h (switch_to_inferior_no_thread): Declare.
2676         * mi/mi-main.c (run_one_inferior): Use
2677         switch_to_inferior_no_thread.
2678
2679 2020-01-10  Pedro Alves  <palves@redhat.com>
2680
2681         * infcmd.c (kill_command): Remove dead code.
2682
2683 2020-01-10  Pedro Alves  <palves@redhat.com>
2684
2685         * remote.c (remote_target::mourn_inferior): No longer check
2686         whether the target is running.
2687
2688 2020-01-10  Pedro Alves  <palves@redhat.com>
2689
2690         * corelow.c (core_target::has_execution): Change parameter type to
2691         inferior pointer.
2692         * inferior.c (number_of_live_inferiors): Use
2693         inferior::has_execution instead of target_has_execution_1.
2694         * inferior.h (inferior::has_execution): New.
2695         * linux-thread-db.c (thread_db_target::update_thread_list): Use
2696         inferior::has_execution instead of target_has_execution_1.
2697         * process-stratum-target.c
2698         (process_stratum_target::has_execution): Change parameter type to
2699         inferior pointer.  Check the inferior's PID instead of
2700         inferior_ptid.
2701         * process-stratum-target.h
2702         (process_stratum_target::has_execution): Change parameter type to
2703         inferior pointer.
2704         * record-full.c (record_full_core_target::has_execution): Change
2705         parameter type to inferior pointer.
2706         * target.c (target_has_execution_1): Change parameter type to
2707         inferior pointer.
2708         (target_has_execution_current): Adjust.
2709         * target.h (target_ops::has_execution): Change parameter type to
2710         inferior pointer.
2711         (target_has_execution_1): Change parameter type to inferior
2712         pointer.  Change return type to bool.
2713         * tracefile.h (tracefile_target::has_execution): Change parameter
2714         type to inferior pointer.
2715
2716 2020-01-10  Pedro Alves  <palves@redhat.com>
2717
2718         * exceptions.c (print_flush): Remove current_top_target() check.
2719
2720 2020-01-10  Pedro Alves  <palves@redhat.com>
2721
2722         * remote.c (show_remote_exec_file): Show the current inferior's
2723         exec-file instead of the command variable's value.
2724
2725 2020-01-10  Pedro Alves  <palves@redhat.com>
2726
2727         * record-full.c (record_full_resume_ptid): New global.
2728         (record_full_target::resume): Set it.
2729         (record_full_wait_1): Use record_full_resume_ptid instead of
2730         inferior_ptid.
2731
2732 2020-01-10  Pedro Alves  <palves@redhat.com>
2733
2734         * gdbthread.h (scoped_restore_current_thread)
2735         <dont_restore, restore, m_dont_restore>: Declare.
2736         * thread.c (thread_alive): Add assertion.  Return bool.
2737         (switch_to_thread_if_alive): New.
2738         (prune_threads): Switch inferior/thread.
2739         (print_thread_info_1): Switch thread before calling target methods.
2740         (scoped_restore_current_thread::restore): New, factored out from
2741         ...
2742         (scoped_restore_current_thread::~scoped_restore_current_thread):
2743         ... this.
2744         (scoped_restore_current_thread::scoped_restore_current_thread):
2745         Add assertion.
2746         (thread_apply_all_command, thread_select): Use
2747         switch_to_thread_if_alive.
2748
2749 2020-01-10  George Barrett  <bob@bob131.so>
2750
2751         * stap-probe.c (stap_modify_semaphore): Don't check for null
2752         semaphores.
2753         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
2754         for null semaphores.
2755
2756 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2757
2758         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
2759         all source windows, and maintain horizontal scroll status while
2760         doing so.
2761
2762 2020-01-09  Tom Tromey  <tom@tromey.com>
2763
2764         PR tui/18932:
2765         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
2766         update_source_window, not print_source_lines.
2767
2768 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
2769
2770         * tui/tui.c (tui_enable): Register tui hooks after calling
2771         tui_display_main.
2772
2773 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
2774
2775         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
2776
2777 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
2778
2779         * thread.c (print_thread_info_1): Fix indentation.
2780
2781 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
2782
2783         * symtab.c (general_symbol_info::compute_and_set_names): Move the
2784         unique_xmalloc_ptr outside the if to always free the demangled name.
2785
2786 2020-01-08  Tom Tromey  <tromey@adacore.com>
2787
2788         * xcoffread.c (enter_line_range, read_xcoff_symtab)
2789         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
2790         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
2791         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
2792         Remove.
2793         (section_offsets): New typedef.
2794         * symtab.c (fixup_section, get_msymbol_address): Update.
2795         * symmisc.c (dump_msymbols): Update.
2796         * symfile.h (relative_addr_info_to_section_offsets)
2797         (symfile_map_offsets_to_segments): Update.
2798         * symfile.c (build_section_addr_info_from_objfile)
2799         (init_objfile_sect_indices): Update.
2800         (struct place_section_arg): Change type of "offsets".
2801         (place_section): Update.
2802         (relative_addr_info_to_section_offsets): Change type of
2803         "section_offsets".  Remove "num_sections" parameter.
2804         (default_symfile_offsets, syms_from_objfile_1)
2805         (set_objfile_default_section_offset): Update.
2806         (reread_symbols): No need to preserve section offsets by hand.
2807         (symfile_map_offsets_to_segments): Change type of "offsets".
2808         * stap-probe.c (relocate_address): Update.
2809         * stabsread.h (process_one_symbol): Update.
2810         * solib-target.c (struct lm_info_target) <offsets>: Change type.
2811         (solib_target_relocate_section_addresses): Update.
2812         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
2813         Update.
2814         * solib-frv.c (frv_relocate_main_executable): Update.
2815         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
2816         * solib-aix.c (solib_aix_get_section_offsets): Change return
2817         type.
2818         (solib_aix_solib_create_inferior_hook): Update.
2819         * remote.c (remote_target::get_offsets): Update.
2820         * psymtab.c (find_pc_sect_psymtab): Update.
2821         * psympriv.h (struct partial_symbol) <address, text_low,
2822         text_high>: Update.
2823         * objfiles.h (obj_section_offset): Update.
2824         (struct objfile) <section_offsets>: Change type.
2825         <num_sections>: Remove.
2826         (objfile_relocate): Update.
2827         * objfiles.c (entry_point_address_query): Update
2828         (relocate_one_symbol): Change type of "section_offsets".
2829         (objfile_relocate1, objfile_relocate1): Change type of
2830         "new_offsets".
2831         (objfile_rebase1): Update.
2832         * mipsread.c (mipscoff_symfile_read): Update.
2833         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
2834         parameter.
2835         * mdebugread.c (parse_symbol): Change type of "section_offsets".
2836         (parse_external, psymtab_to_symtab_1): Update.
2837         * machoread.c (macho_symfile_offsets): Update.
2838         * ia64-tdep.c (ia64_find_unwind_table): Update.
2839         * hppa-tdep.c (read_unwind_info): Update.
2840         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
2841         * dwarf2read.c (create_addrmap_from_index)
2842         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
2843         (process_psymtab_comp_unit_reader, add_partial_symbol)
2844         (add_partial_subprogram, process_full_comp_unit)
2845         (read_file_scope, read_func_scope, read_lexical_block_scope)
2846         (read_call_site_scope, dwarf2_rnglists_process)
2847         (dwarf2_ranges_process, dwarf2_ranges_read)
2848         (dwarf_decode_lines_1, var_decode_location, new_symbol)
2849         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
2850         Update.
2851         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
2852         Update.
2853         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
2854         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
2855         (process_one_symbol): Change type of "section_offsets".
2856         * ctfread.c (get_objfile_text_range): Update.
2857         * coffread.c (coff_symtab_read, enter_linenos)
2858         (process_coff_symbol): Update.
2859         * coff-pe-read.c (add_pe_forwarded_sym): Update.
2860         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
2861
2862 2020-01-08  Tom Tromey  <tromey@adacore.com>
2863
2864         * dwarf2read.c (parse_macro_definition): Use std::string.
2865         (parse_macro_definition): Likewise.
2866
2867 2020-01-08  Tom Tromey  <tromey@adacore.com>
2868
2869         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
2870         (ATTR_ALLOC_CHUNK): Remove.
2871
2872 2020-01-08  Tom Tromey  <tromey@adacore.com>
2873
2874         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
2875
2876 2020-01-08  Tom Tromey  <tromey@adacore.com>
2877
2878         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
2879         (dwarf2_compute_name, open_dwo_file): Likewise.
2880         (process_enumeration_scope): Use std::vector.
2881         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
2882         (partial_die_info::fixup, dwarf2_start_subfile)
2883         (guess_full_die_structure_name, dwarf2_name): Likewise.
2884         (determine_prefix): Update.
2885         (guess_full_die_structure_name): Make return type const.
2886         (partial_die_full_name): Return unique_xmalloc_ptr.
2887         (DW_FIELD_ALLOC_CHUNK): Remove.
2888
2889 2020-01-07  Tom Tromey  <tromey@adacore.com>
2890
2891         PR build/24937:
2892         * stap-probe.c (class stap_static_probe_ops): Add constructor.
2893
2894 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
2895
2896         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
2897
2898 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2899
2900         * stack.c (print_frame_info): Move disassemble_next_line code
2901         inside source_print block.
2902
2903 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2904
2905         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
2906         gdb/signals.h, as we are now using native signal symbols.
2907
2908 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
2909
2910         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
2911         overflow by an early check of content vs threshold.
2912         * tui/tui-source.c (tui_source_window::line_is_displayed):
2913         Likewise.
2914
2915 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2916
2917         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
2918
2919 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
2920
2921         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
2922         export table if no section contains it's RVA.
2923
2924 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2925
2926         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
2927
2928 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
2929
2930         * source.c (print_source_lines_base): Set last_line_listed.
2931
2932 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
2933
2934         * tui/tui-disasm.c: Remove trailing spaces.
2935
2936 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
2937             Pedro Alves  <palves@redhat.com>
2938
2939         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
2940         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
2941         (windows_gdb_signal_to_target): New function, uses the above
2942         enumeration to convert GDB internal signal codes to equivalent
2943         Windows codes.
2944         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
2945         * windows-nat.c: Include "gdb_wait.h".
2946         (get_windows_debug_event): Extract the fatal exception from the
2947         exit status and convert to the equivalent Posix signal number.
2948         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
2949         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
2950         * gdbsupport/gdb_wait.c: New file, implements
2951         windows_status_to_termsig.
2952         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
2953         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
2954
2955 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2956
2957         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
2958         show_layout.
2959
2960 2020-01-05  Luis Machado  <luis.machado@linaro.org>
2961
2962         * aarch64-linux-nat.c
2963         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
2964         and bfd_mach_aarch64.
2965
2966 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2967
2968         * ui-file.c (stdio_file::can_emit_style_escape)
2969         (tee_file::can_emit_style_escape): Ensure style is used also on
2970         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
2971         to gdb_stdout.
2972         * main.c (set_gdb_data_directory): Use file style to output the
2973         warning that the given pathname is not a directory.
2974         * top.c (show_history_filename, gdb_safe_append_history)
2975         (show_gdb_datadir): Use file style.
2976
2977 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
2978
2979         * solib-target.c (struct lm_info_target):
2980         Change offsets to be a unique_xmalloc_ptr.
2981         (solib_target_relocate_section_addresses): Update.
2982
2983 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
2984
2985         * windows-nat.c (windows_clear_solib): Free so_list linked list.
2986
2987 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
2988
2989         * MAINTAINERS (Write After Approval): Add myself.
2990
2991 2020-01-02  Luis Machado  <luis.machado@linaro.org>
2992
2993         * proc-service.c (get_ps_regcache): Remove reference to obsolete
2994         Cell BE architecture.
2995         * target.h (struct target_ops) <thread_architecture>: Likewise.
2996
2997 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
2998
2999         * Makefile.in: Use INSTALL_PROGRAM_ENV.
3000
3001 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
3002
3003         * MAINTAINERS (Write After Approval): Add myself.
3004
3005 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3006
3007         * gdbarch.sh: Update copyright year range of generated files.
3008
3009 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3010
3011         Update copyright year range in all GDB files.
3012
3013 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3014
3015         * copyright.py: Convert to Python 3.
3016
3017 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3018
3019         * copyright.py: Adapt after move of gnulib directory from gdb
3020         directory to toplevel directory.
3021
3022 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3023
3024         * copyright.py (main): Exit if run from the wrong directory.
3025
3026 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3027
3028         * top.c (print_gdb_version): Change copyright year to 2020.
3029
3030 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
3031
3032         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
3033
3034 For older changes see ChangeLog-2019.
3035 \f
3036 Local Variables:
3037 mode: change-log
3038 left-margin: 8
3039 fill-column: 74
3040 version-control: never
3041 coding: utf-8
3042 End: