gdb/ChangeLog

   1 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
   2
   3         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
   4         ada_is_fixed_point_type.  Update all callers.
   5         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
   6         all callers.
   7         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
   8         Update all callers.
   9         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
  10         print_fixed_point_type.  Update all callers.
  11         * ada-valprint.c (ada_value_print_num): Replace call to
  12         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
  13
  14 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
  15
  16         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
  17         processors.
  18         (cpu_supports_bts): Add CV_AMD case.
  19
  20 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
  21             Simon Marchi  <simon.marchi@efficios.com>
  22
  23         * infrun.c (stop_all_threads): Collect multiple wait events at
  24         each pass.
  25
  26 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
  27
  28         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
  29         type::code instead.
  30
  31 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
  32
  33         * gdbtypes.h (struct type) <code, set_code>: New methods.
  34         (TYPE_CODE): Use type::code.  Change all call sites used to set
  35         the code to use type::set_code instead.
  36
  37 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  38             Tom de Vries  <tdevries@suse.de>
  39             Pedro Alves  <palves@redhat.com>
  40
  41         PR threads/25478
  42         * infrun.c (stop_all_threads): Do NOT ignore
  43         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
  44         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
  45         received.
  46         (handle_no_resumed): Remove code handling a live inferior with no
  47         threads.
  48         * remote.c (has_single_non_exited_thread): New.
  49         (remote_target::update_thread_list): Do not delete a thread if is
  50         the last thread of the process.
  51         * thread.c (thread_select): Call delete_exited_threads instead of
  52         prune_threads.
  53
  54 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  55
  56         * infrun.c (stop_all_threads): Enable/disable thread events of all
  57         targets.  Move a debug message denoting the end of the function
  58         into the SCOPED_EXIT block.
  59
  60 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  61
  62         * process-stratum-target.h: Include <set>.
  63         (all_non_exited_process_targets, switch_to_target_no_thread): New
  64         function declarations.
  65         * process-stratum-target.c (all_non_exited_process_targets)
  66         (switch_to_target_no_thread): New function implementations.
  67
  68 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  69
  70         * infrun.c (handle_inferior_event): Extract out a piece of code
  71         into...
  72         (mark_non_executing_threads): ...this new function.
  73
  74 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  75
  76         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
  77         use.
  78
  79 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  80
  81         * regcache.c (regcache_read_pc_protected): New function
  82         implementation that returns 0 if the PC cannot read via
  83         'regcache_read_pc'.
  84         * infrun.c (proceed): Call 'regcache_read_pc_protected'
  85         instead of 'regcache_read_pc'.
  86         (keep_going_pass_signal): Ditto.
  87
  88 2020-05-13  Tom Tromey  <tromey@adacore.com>
  89
  90         * ada-lang.c (align_value): Remove.
  91         (ada_template_to_fixed_record_type_1): Use align_up.
  92
  93 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
  94
  95         * async-event.c: Update the copyright year.
  96         * async-event.h: Update the copyright year.
  97
  98 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
  99
 100         * objfiles.h (is_addr_in_objfile,
 101         shared_objfile_contains_address_p): Return bool.
 102         * objfile.c (is_addr_in_objfile,
 103         shared_objfile_contains_address_p): Return bool.
 104
 105 2020-05-11  Tom Tromey  <tromey@adacore.com>
 106
 107         * cli/cli-cmds.c (info_command): Restore.
 108         (_initialize_cli_cmds): Use add_prefix_command for "info".
 109         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
 110
 111 2020-05-11  Tom Tromey  <tromey@adacore.com>
 112
 113         * ada-lang.c (ada_value_primitive_field): Now public.
 114         * ada-lang.h (ada_value_primitive_field): Declare.
 115         * ada-valprint.c (print_field_values): Use
 116         ada_value_primitive_field for wrapper fields.
 117
 118 2020-05-11  Tom de Vries  <tdevries@suse.de>
 119
 120         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
 121         MODULE_DOMAIN.
 122
 123 2020-05-11  Tom de Vries  <tdevries@suse.de>
 124
 125         PR symtab/25941
 126         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
 127         with length 0, if not gdb-produced.
 128         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
 129
 130 2020-05-09  Tom de Vries  <tdevries@suse.de>
 131
 132         PR gdb/25955
 133         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
 134         calculation.
 135
 136 2020-05-09  Tom Tromey  <tom@tromey.com>
 137
 138         * top.c (server_command): Now bool.
 139         * top.h (server_command): Now bool.
 140
 141 2020-05-08  Tom Tromey  <tromey@adacore.com>
 142
 143         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
 144         already being processed.
 145
 146 2020-05-08  Tom Tromey  <tom@tromey.com>
 147
 148         * printcmd.c (struct display) <next>: Remove.
 149         <display>: New constructor.
 150         <exp_string>: Now a std::string.
 151         <enabled_p>: Now a bool.
 152         (display_number): Move definition earlier.
 153         (displays): Rename from display_chain.  Now a std::vector.
 154         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
 155         (display_command): Update.
 156         (do_one_display, disable_display)
 157         (enable_disable_display_command, do_enable_disable_display):
 158         Update.
 159         (free_display): Remove.
 160         (clear_displays): Rewrite.
 161         (delete_display): Update.
 162         (map_display_numbers): Use function_view.  Remove "data"
 163         parameter.  Update.
 164         (do_delete_display): Remove.
 165         (undisplay_command): Update.
 166         (do_one_display, do_displays, disable_display)
 167         (info_display_command): Update.
 168         (do_enable_disable_display): Remove.
 169         (enable_disable_display_command)
 170         (clear_dangling_display_expressions): Update.
 171
 172 2020-05-08  Tom Tromey  <tom@tromey.com>
 173
 174         * symtab.c (set_symbol_cache_size)
 175         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
 176         (maintenance_print_symbol_cache_statistics): Update.
 177         * symmisc.c (print_symbol_bcache_statistics)
 178         (print_objfile_statistics, maintenance_print_objfiles)
 179         (maintenance_info_symtabs, maintenance_check_symtabs)
 180         (maintenance_expand_symtabs, maintenance_info_line_tables):
 181         Update.
 182         * symfile-debug.c (set_debug_symfile): Update.
 183         * source.c (forget_cached_source_info): Update.
 184         * python/python.c (gdbpy_progspaces): Update.
 185         * psymtab.c (maintenance_info_psymtabs): Update.
 186         * probe.c (parse_probes): Update.
 187         * linespec.c (iterate_over_all_matching_symtabs)
 188         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
 189         * guile/scm-progspace.c (gdbscm_progspaces): Update.
 190         * exec.c (exec_target::close): Update.
 191         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
 192         * breakpoint.c (print_one_breakpoint_location)
 193         (create_longjmp_master_breakpoint)
 194         (create_std_terminate_master_breakpoint): Update.
 195         * progspace.c (program_spaces): Now a std::vector.
 196         (maybe_new_address_space): Update.
 197         (add_program_space): Remove.
 198         (program_space::program_space): Update.
 199         (remove_program_space): Update.
 200         (number_of_program_spaces): Remove.
 201         (print_program_space, update_address_spaces): Update.
 202         * progspace.h (program_spaces): Change type.
 203         (ALL_PSPACES): Remove.
 204         (number_of_program_spaces): Don't declare.
 205         (struct program_space) <next>: Remove.
 206
 207 2020-05-08  Tom Tromey  <tom@tromey.com>
 208
 209         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
 210         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
 211         (enable_break): Update.
 212         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
 213         (frv_fdpic_find_canonical_descriptor): Update.
 214         (frv_fetch_objfile_link_map): Update.
 215         * progspace.c (program_space::free_all_objfiles): Update.
 216         (program_space::solibs): New method.
 217         * progspace.h (struct program_space) <solibs>: New method.
 218         * solist.h (master_so_list): Don't declare.
 219         (ALL_SO_LIBS): Remove.
 220         * solib.h (so_list_head): Remove.
 221         (update_solib_list): Update comment.
 222         * solib.c (master_so_list): Remove.
 223         (solib_used, update_solib_list, solib_add)
 224         (info_sharedlibrary_command, clear_solib)
 225         (reload_shared_libraries_1, remove_user_added_objfile): Update.
 226
 227 2020-05-08  Tom Tromey  <tom@tromey.com>
 228
 229         * extension.c (extension_languages): Now a std::array.
 230         (ALL_EXTENSION_LANGUAGES): Remove.
 231         (get_ext_lang_defn, get_ext_lang_of_file)
 232         (eval_ext_lang_from_control_command): Update.
 233         (finish_ext_lang_initialization)
 234         (auto_load_ext_lang_scripts_for_objfile)
 235         (ext_lang_type_printers::ext_lang_type_printers)
 236         (apply_ext_lang_type_printers)
 237         (ext_lang_type_printers::~ext_lang_type_printers)
 238         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
 239         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
 240         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
 241         (get_matching_xmethod_workers, ext_lang_colorize)
 242         (ext_lang_before_prompt): Update.
 243         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
 244
 245 2020-05-08  Tom Tromey  <tom@tromey.com>
 246
 247         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
 248         overload.
 249         <swap_string, m_string>: Remove.
 250         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
 251         Update.
 252         * stabsread.c (define_symbol, read_type): Update.
 253         * linespec.c (find_linespec_symbols): Update.
 254         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
 255         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
 256         * dbxread.c (read_dbx_symtab): Update.
 257         * cp-support.h (cp_canonicalize_string_full)
 258         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
 259         Return unique_xmalloc_ptr.
 260         * cp-support.c (inspect_type): Update.
 261         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
 262         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
 263         Likewise.
 264         * c-typeprint.c (print_name_maybe_canonical): Update.
 265         * break-catch-throw.c (check_status_exception_catchpoint):
 266         Update.
 267
 268 2020-05-08  Tom de Vries  <tdevries@suse.de>
 269
 270         * infrun.c (follow_fork): Copy current_line and current_symtab to
 271         child thread.
 272
 273 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 274
 275         * async-event.c (struct async_signal_handler, struct
 276         async_event_handler): Reformat, remove typedef.
 277
 278 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 279
 280         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
 281         access thistype->main_type->dyn_prop_list directly.
 282
 283 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 284
 285         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
 286         (remove_dyn_prop): Remove.  Update all users to use
 287         type::remove_dyn_prop.
 288         * gdbtypes.c (remove_dyn_prop): Rename to...
 289         (type::remove_dyn_prop): ... this.
 290
 291 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
 292
 293         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
 294         (add_dyn_prop): Remove.  Update all users to use
 295         type::add_dyn_prop.
 296         * gdbtypes.c (add_dyn_prop): Rename to...
 297         (type::add_dyn_prop): ... this.
 298
 299 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
 300
 301         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
 302         (get_dyn_prop): Remove.  Update all users to use
 303         type::dyn_prop.
 304         * gdbtypes.c (get_dyn_prop): Rename to...
 305         (type::dyn_prop): ... this.
 306
 307 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 308
 309         * gdbtypes.h (struct main_type) <flag_static>: Remove.
 310
 311 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
 312
 313         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
 314         instruction, skip it if it's there.
 315
 316 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
 317
 318         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
 319
 320 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
 321
 322         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
 323         * gdbtypes.c (recursive_dump_type): Remove use of
 324         TYPE_INCOMPLETE.
 325
 326 2020-05-03  Tom Tromey  <tom@tromey.com>
 327
 328         * breakpoint.c (catch_command, tcatch_command): Remove.
 329         (_initialize_breakpoint): Use add_basic_prefix_cmd,
 330         add_show_prefix_cmd.
 331         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
 332         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
 333         Remove.
 334         (add_internal_problem_command): Use add_basic_prefix_cmd,
 335         add_show_prefix_cmd.
 336         * mips-tdep.c (set_mipsfpu_command): Remove.
 337         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
 338         * dwarf2/index-cache.c (set_index_cache_command): Remove.
 339         (_initialize_index_cache): Use add_basic_prefix_cmd.
 340         * memattr.c (dummy_cmd): Remove.
 341         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
 342         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
 343         (_initialize_tui_win): Use add_basic_prefix_cmd,
 344         add_show_prefix_cmd.
 345         * cli/cli-logging.c (set_logging_command): Remove.
 346         (_initialize_cli_logging): Use add_basic_prefix_cmd,
 347         add_show_prefix_cmd.
 348         (show_logging_command): Remove.
 349         * target.c (target_command): Remove.
 350         (add_target): Use add_basic_prefix_cmd.
 351
 352 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
 353
 354         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
 355
 356 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 357
 358         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
 359         info_command.
 360
 361 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
 362
 363         * nbsd-nat.c (nbsd_enable_proc_events)
 364         (nbsd_nat_target::post_startup_inferior): Add.
 365         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
 366         (nbsd_nat_target::update_thread_list): Rewrite.
 367         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
 368         "PTRACE_LWP_CREATE".
 369         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
 370
 371 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 372
 373         * stack.c (_initialize_stack): Remove duplicated creation
 374         of "frame" command and "f" alias.
 375
 376 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 377
 378         PR gdb/18706
 379         * gdbtypes.c (check_typedef): Calculate size of array of
 380         stubbed type.
 381
 382 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 383
 384         PR gdb/15559
 385         * i386-tdep.c (i386_push_dummy_call): Call
 386         i386_thiscall_push_dummy_call.
 387         (i386_thiscall_push_dummy_call): New function.
 388         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
 389         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
 390         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
 391
 392 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 393
 394         * gdbarch.sh (do_read): Add shellcheck disable directive for
 395         warning SC2162.
 396
 397 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 398
 399         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
 400         "referenced but not assigned" warning.
 401
 402 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 403
 404         * gdbarch.sh: Remove code that sets fallbackdefault.
 405
 406 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 407
 408         * gdbarch.sh: Use shell operators && and || instead of
 409         -a and -o.
 410
 411 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 412
 413         * gdbarch.sh: Use $(...) instead of `...`.
 414
 415 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 416
 417         * gdbarch.sh: Use double quotes around variables.
 418
 419 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 420
 421         * gdbarch.sh: Use %s with printf, instead of variables in the
 422         format string.
 423
 424 2020-04-29  Tom Tromey  <tromey@adacore.com>
 425
 426         PR ada/25875:
 427         * dwarf2/read.c (update_enumeration_type_from_children): Compute
 428         type fields here.
 429         (read_enumeration_type): Call
 430         update_enumeration_type_from_children later.  Update comments.
 431         (process_enumeration_scope): Don't create type fields.
 432
 433 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 434
 435         * nbsd-tdep.c: Include "xml-syscall.h".
 436         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
 437
 438 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 439
 440         * nbsd-nat.c: Include "sys/wait.h".
 441         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
 442         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
 443         (nbsd_nat_target::remove_exec_catchpoint)
 444         (nbsd_nat_target::set_syscall_catchpoint): Add.
 445         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
 446         (nbsd_nat_target::insert_exec_catchpoint)
 447         (nbsd_nat_target::remove_exec_catchpoint)
 448         (nbsd_nat_target::set_syscall_catchpoint): Add.
 449         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
 450         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
 451         `nbsd_get_syscall_number'.
 452
 453 2020-04-29  Tom Tromey  <tom@tromey.com>
 454
 455         * stack.c (print_block_frame_labels): Remove.
 456
 457 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 458
 459         PR gdb/17320
 460         * ada-valprint.c (val_print_packed_array_elements): Move array
 461         end bracket to new line.
 462         (ada_val_print_string): Remove extra spaces before first array
 463         element.
 464         * c-valprint.c (c_value_print_array): Likewise.
 465         * m2-valprint.c (m2_print_array_contents): Likewise.
 466         (m2_value_print_inner): Likewise.
 467         * p-valprint.c (pascal_value_print_inner): Likewise.
 468         * valprint.c (generic_val_print_array): Likewise.
 469         (value_print_array_elements): Move first array element and array
 470         end bracket to new line.
 471
 472 2020-04-29  Tom de Vries  <tdevries@suse.de>
 473
 474         PR symtab/25889
 475         * linespec.c (find_method): Fix ix calculation.
 476
 477 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
 478
 479         * syscalls/update-netbsd.sh: New file.
 480         * syscalls/netbsd.xml: Regenerate.
 481         * data-directory/Makefile.in: Register `netbsd.xml' in
 482         `SYSCALLS_FILES'.
 483
 484 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 485
 486         * syscalls/update-freebsd.sh: Add double quotes.
 487
 488 2020-04-28  Tom Tromey  <tom@tromey.com>
 489
 490         * NEWS: Update.
 491         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
 492         (cmdpy_init): Allow class_tui.
 493
 494 2020-04-28 Mark Williams <mark@myosotissp.com>
 495
 496         PR gdb/24480
 497         * dwarf2read.c: Add missing assingments to list_in_scope when
 498         start_symtab was already called.
 499
 500 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 501
 502         PR gdb/25881
 503         * dwarf2/read.c (offset_map_type): Use
 504         gdb:hash_enum<sect_offset> as hash function.
 505
 506 2020-04-28  Tom de Vries  <tdevries@suse.de>
 507
 508         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
 509         with DW_AT_signature.
 510
 511 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
 512
 513         * configure.ac: Remove check for fs_base/gs_base in
 514         user_regs_struct.
 515         * configure: Re-generate.
 516         * config.in: Re-generate.
 517         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
 518         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
 519         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
 520
 521 2020-04-27  Luis Machado  <luis.machado@linaro.org>
 522
 523         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
 524         problematic inline frame unwinding situation.
 525         * frame.c (frame_id_computed_p): New function.
 526         * frame.h (frame_id_computed_p): New prototype.
 527
 528 2020-04-26  Tom Tromey  <tom@tromey.com>
 529
 530         * command.h (enum command_class) <class_pseudo>: Remove.
 531
 532 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 533
 534         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
 535         and whitespace.
 536
 537 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
 538
 539        * inf-ptrace.c (inf_ptrace_target::wait): Remove
 540        `PT_GET_PROCESS_STATE' block.
 541
 542 2020-04-24  Tom Tromey  <tom@tromey.com>
 543
 544         * symtab.h (symbol_get_demangled_name): Don't declare.
 545         * symtab.c (symbol_get_demangled_name): Remove.
 546         (general_symbol_info::natural_name)
 547         (general_symbol_info::demangled_name): Update.
 548
 549 2020-04-24  Tom Tromey  <tom@tromey.com>
 550
 551         PR rust/25025:
 552         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
 553
 554 2020-04-24  Tom Tromey  <tom@tromey.com>
 555
 556         PR symtab/12707:
 557         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
 558         exists.
 559         (new_symbol): Likewise.
 560         * compile/compile-object-load.c (get_out_value_type): Use
 561         symbol_matches_search_name.
 562
 563 2020-04-24  Tom Tromey  <tom@tromey.com>
 564
 565         * dwarf2/read.c (add_partial_symbol): Do not call
 566         compute_and_set_names.
 567
 568 2020-04-24  Tom Tromey  <tom@tromey.com>
 569
 570         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
 571         overload.
 572
 573 2020-04-24  Tom Tromey  <tom@tromey.com>
 574
 575         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
 576         (add_psymbol_to_list): New overload.  Make old overload call new
 577         one.
 578         * psympriv.h (add_psymbol_to_list): New overload.
 579
 580 2020-04-24  Tom Tromey  <tom@tromey.com>
 581
 582         * dwarf2/read.c (partial_die_info::read) <case
 583         DW_AT_linkage_name>: Use value_as_string.
 584         (dwarf2_string_attr): Use value_as_string.
 585         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
 586         method.
 587         * dwarf2/attribute.c (attribute::value_as_string): New method.
 588
 589 2020-04-24  Tom Tromey  <tom@tromey.com>
 590
 591         * symtab.c (general_symbol_info::natural_name)
 592         (general_symbol_info::demangled_name): Check for language_rust.
 593
 594 2020-04-24  Tom Tromey  <tom@tromey.com>
 595
 596         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 597         (dwarf2_physname): ... from here.
 598         (partial_die_info::read): Add Rust "{" hack.
 599
 600 2020-04-24  Tom Tromey  <tom@tromey.com>
 601
 602         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 603         method.
 604         (symbol_set_demangled_name): Don't declare.
 605         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 606         symbol_set_demangled_name.
 607         (general_symbol_info::set_language)
 608         (general_symbol_info::compute_and_set_names): Update.
 609         * minsyms.c (minimal_symbol_reader::install): Update.
 610         * dwarf2/read.c (new_symbol): Update.
 611
 612 2020-04-24  Tom Tromey  <tromey@adacore.com>
 613
 614         PR python/23662:
 615         * python/py-type.c (convert_field): Handle
 616         FIELD_LOC_KIND_DWARF_BLOCK.
 617         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 618         (typy_get_dynamic): Nw function.
 619         (type_object_getset): Add "dynamic".
 620         * NEWS: Add entry.
 621
 622 2020-04-24  Tom Tromey  <tromey@adacore.com>
 623
 624         * ada-typeprint.c (print_choices, print_variant_part)
 625         (print_record_field_types_dynamic): New functions.
 626         (print_record_field_types): Use print_record_field_types_dynamic.
 627
 628 2020-04-24  Tom Tromey  <tromey@adacore.com>
 629
 630         * dwarf2/read.c (handle_data_member_location): New overload.
 631         (dwarf2_add_field): Use it.
 632         (decode_locdesc): Add "computed" parameter.  Update comment.
 633         * gdbtypes.c (is_dynamic_type_internal): Also look for
 634         FIELD_LOC_KIND_DWARF_BLOCK.
 635         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 636         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 637         virtual base classes.
 638         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 639         FIELD_LOC_KIND_DWARF_BLOCK.
 640
 641 2020-04-24  Tom Tromey  <tromey@adacore.com>
 642
 643         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 644         * gdbtypes.c (is_dynamic_type_internal): Check
 645         TYPE_HAS_DYNAMIC_LENGTH.
 646         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 647         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 648         New macros.
 649         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 650         constant.
 651
 652 2020-04-24  Tom Tromey  <tromey@adacore.com>
 653
 654         * dwarf2/read.c (struct variant_field): Rewrite.
 655         (struct variant_part_builder): New.
 656         (struct nextfield): Remove "variant" field.  Add "offset".
 657         (struct field_info): Add "current_variant_part" and
 658         "variant_parts".
 659         (alloc_discriminant_info): Remove.
 660         (alloc_rust_variant): New function.
 661         (quirk_rust_enum): Update.
 662         (dwarf2_add_field): Set "offset" member.  Don't handle
 663         DW_TAG_variant_part.
 664         (offset_map_type): New typedef.
 665         (convert_variant_range, create_one_variant)
 666         (create_one_variant_part, create_variant_parts)
 667         (add_variant_property): New functions.
 668         (dwarf2_attach_fields_to_type): Call add_variant_property.
 669         (read_structure_type): Don't handle DW_TAG_variant_part.
 670         (handle_variant_part, handle_variant): New functions.
 671         (handle_struct_member_die): Use them.
 672         (process_structure_scope): Don't handle variant parts.
 673         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 674         (struct discriminant_info): Remove.
 675         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 676         (struct main_type) <flag_discriminated_union>: Remove.
 677         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 678         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 679         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 680         Update.
 681         * valops.c (value_union_variant): Remove.
 682         * value.h (value_union_variant): Don't declare.
 683
 684 2020-04-24  Tom Tromey  <tromey@adacore.com>
 685
 686         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 687         (ada_value_primitive_packed_val): Update.
 688         * ada-valprint.c (ada_value_print_1): Update.
 689         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 690         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 691         just an address.  Use evaluate_for_locexpr_baton.
 692         (dwarf2_evaluate_property): Update.
 693         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 694         array_view.
 695         * findvar.c (default_read_var_value): Update.
 696         * gdbtypes.c (compute_variant_fields_inner)
 697         (resolve_dynamic_type_internal): Update.
 698         (resolve_dynamic_type): Change type of valaddr parameter.
 699         * gdbtypes.h (resolve_dynamic_type): Update.
 700         * valarith.c (value_subscripted_rvalue): Update.
 701         * value.c (value_from_contents_and_address): Update.
 702
 703 2020-04-24  Tom Tromey  <tromey@adacore.com>
 704
 705         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 706         "push_initial_value" parameter.
 707         (dwarf2_evaluate_property): Likewise.
 708         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 709
 710 2020-04-24  Tom Tromey  <tromey@adacore.com>
 711
 712         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 713         (variant::matches, compute_variant_fields_recurse)
 714         (compute_variant_fields_inner, compute_variant_fields): New
 715         functions.
 716         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 717         Use resolved_type after type is made.
 718         (operator==): Add new cases.
 719         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 720         (struct discriminant_range, struct variant, struct variant_part):
 721         New.
 722         (union dynamic_prop_data) <variant_parts, original_type>: New
 723         members.
 724         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 725         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 726         constants.
 727         * value.c (unpack_bits_as_long): Now public.
 728         * value.h (unpack_bits_as_long): Declare.
 729
 730 2020-04-24  Tom Tromey  <tromey@adacore.com>
 731
 732         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 733         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 734
 735 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 736
 737         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 738
 739 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 740
 741         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 742         (remove_fork_catchpoint, post_startup_inferior)
 743         (post_attach): Move...
 744         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 745         (remove_fork_catchpoint, post_startup_inferior)
 746         (post_attach): ...here.
 747         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 748         (remove_fork_catchpoint, post_startup_inferior)
 749         (post_attach): Move...
 750         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 751         (remove_fork_catchpoint, post_startup_inferior)
 752         (post_attach): ...here.
 753
 754 2020-04-24  Tom Tromey  <tromey@adacore.com>
 755
 756         * nat/windows-nat.h (struct windows_thread_info)
 757         <pc_adjusted>: New member.
 758         * windows-nat.c (windows_fetch_one_register): Check
 759         pc_adjusted.
 760         (windows_nat_target::get_windows_debug_event)
 761         (windows_nat_target::wait): Set pc_adjusted.
 762
 763 2020-04-24  Tom de Vries  <tdevries@suse.de>
 764
 765         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
 766         Run gdb-add-index inside temp dir.
 767
 768 2020-04-23  Tom Tromey  <tromey@adacore.com>
 769
 770         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
 771         in loop.
 772
 773 2020-04-23  Luis Machado  <luis.machado@linaro.org>
 774
 775         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
 776         get_frame_register instead of gdbarch_unwind_pc.
 777
 778 2020-04-23  Tom de Vries  <tdevries@suse.de>
 779
 780         * symtab.c (lookup_global_symbol): Prefer def over decl.
 781
 782 2020-04-23  Tom de Vries  <tdevries@suse.de>
 783
 784         PR symtab/25807
 785         * block.c (best_symbol, better_symbol): Promote to external.
 786         * block.h (best_symbol, better_symbol): Declare.
 787         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
 788         decl.
 789
 790 2020-04-23  Tom Tromey  <tromey@adacore.com>
 791
 792         PR ada/25837:
 793         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
 794         "const char *", not a "const std::string &".
 795         <name_and_matcher::operator==>: Update.
 796         * unittests/lookup_name_info-selftests.c: Change type of
 797         "result".
 798
 799 2020-04-23  Tom Tromey  <tom@tromey.com>
 800
 801         * inferior.h (iterate_over_inferiors): Don't declare.
 802         * inferior.c (iterate_over_inferiors): Remove.
 803         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
 804         Remove.
 805         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
 806         use iterate_over_inferiors.
 807         (darwin_resume_inferior_it)
 808         (struct resume_inferior_threads_param)
 809         (darwin_resume_inferior_threads_it): Remove.
 810         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
 811
 812 2020-04-23  Tom de Vries  <tdevries@suse.de>
 813
 814         * blockframe.c (find_pc_partial_function): Use
 815         find_pc_sect_compunit_symtab rather than
 816         objfile->sf->qf->find_pc_sect_compunit_symtab.
 817
 818 2020-04-22  Tom de Vries  <tdevries@suse.de>
 819
 820         PR symtab/25764
 821         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
 822         in psymtabs.
 823
 824 2020-04-22  Tom de Vries  <tdevries@suse.de>
 825
 826         PR symtab/25801
 827         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
 828         symtabs.
 829
 830 2020-04-22  Tom de Vries  <tdevries@suse.de>
 831
 832         PR symtab/25700
 833         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
 834         CU if already created.
 835
 836 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 837
 838         * infrun.c (displaced_step_fixup): Switch to the event_thread
 839         before calling displaced_step_restore, not after.
 840
 841 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 842
 843         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
 844         its inferior is not recorded by us.
 845         (record_btrace_target_open): Replace call to
 846         all_non_exited_threads () with call to current_inferior
 847         ()->non_exited_threads ().
 848         (record_btrace_target::stop_recording): Likewise.
 849         (record_btrace_target::close): Likewise.
 850         (record_btrace_target::wait): Likewise.
 851         (record_btrace_target::record_stop_replaying): Likewise.
 852
 853 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 854
 855         * btrace.c (btrace_enable): Throw an error on double enables and
 856         when enabling recording fails.
 857         (btrace_disable): Throw an error if the thread is not recorded.
 858
 859 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 860
 861         * record-btrace.c (record_btrace_target::fetch_registers): Forward
 862         request if we do not have a thread_info.
 863
 864 2020-04-21  Tom de Vries  <tdevries@suse.de>
 865
 866         PR gdb/25471
 867         * thread.c
 868         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
 869         exception in get_frame_id.
 870
 871 2020-04-20  Tom Tromey  <tromey@adacore.com>
 872
 873         * python/python.c (struct gdbpy_event): Mark move constructor as
 874         noexcept.
 875         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
 876         constructor as noexcept.
 877         * completer.h (struct completion_result): Mark move constructor as
 878         noexcept.
 879         * completer.c (completion_result::completion_result): Use
 880         initialization style.  Don't call reset_match_list.
 881
 882 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
 883
 884         * MAINTAINERS (Write After Approval): Add myself.
 885
 886 2020-04-18  Tom Tromey  <tom@tromey.com>
 887
 888         * windows-tdep.c (init_w32_command_list)
 889         (w32_prefix_command_valid): Restore.
 890         (_initialize_windows_tdep): Call init_w32_command_list.
 891
 892 2020-04-18  Tom Tromey  <tom@tromey.com>
 893
 894         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
 895         * value.c (value_fn_field): Update.
 896         * valops.c (find_function_in_inferior)
 897         (value_allocate_space_in_inferior): Update.
 898         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 899         Update.
 900         * tui/tui-source.c (tui_source_window::set_contents): Update.
 901         * symtab.c (lookup_global_or_static_symbol)
 902         (find_function_start_sal_1, skip_prologue_sal)
 903         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
 904         * symmisc.c (dump_msymbols, dump_symtab_1)
 905         (maintenance_print_one_line_table): Update.
 906         * symfile.c (init_entry_point_info, section_is_mapped)
 907         (list_overlays_command, simple_read_overlay_table)
 908         (simple_overlay_update_1): Update.
 909         * stap-probe.c (handle_stap_probe): Update.
 910         * stabsread.c (dbx_init_float_type, define_symbol)
 911         (read_one_struct_field, read_enum_type, read_range_type): Update.
 912         * source.c (info_line_command): Update.
 913         * python/python.c (gdbpy_source_objfile_script)
 914         (gdbpy_execute_objfile_script): Update.
 915         * python/py-type.c (save_objfile_types): Update.
 916         * python/py-objfile.c (py_free_objfile): Update.
 917         * python/py-inferior.c (python_new_objfile): Update.
 918         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
 919         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
 920         (maintenance_check_psymtabs): Update.
 921         * printcmd.c (info_address_command): Update.
 922         * objfiles.h (struct objfile) <arch>: New method, from
 923         get_objfile_arch.
 924         (get_objfile_arch): Don't declare.
 925         * objfiles.c (get_objfile_arch): Remove.
 926         (filter_overlapping_sections): Update.
 927         * minsyms.c (msymbol_is_function): Update.
 928         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
 929         (output_nondebug_symbol): Update.
 930         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
 931         (mdebug_expand_psymtab): Update.
 932         * machoread.c (macho_add_oso_symfile): Update.
 933         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
 934         Update.
 935         * linux-fork.c (checkpoint_command): Update.
 936         * linespec.c (convert_linespec_to_sals): Update.
 937         * jit.c (finalize_symtab): Update.
 938         * infrun.c (insert_exception_resume_from_probe): Update.
 939         * ia64-tdep.c (ia64_find_unwind_table): Update.
 940         * hppa-tdep.c (internalize_unwinds): Update.
 941         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
 942         Update.
 943         * gcore.c (call_target_sbrk): Update.
 944         * elfread.c (record_minimal_symbol, elf_symtab_read)
 945         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
 946         (elf_gnu_ifunc_resolve_by_got): Update.
 947         * dwarf2/read.c (create_addrmap_from_index)
 948         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 949         (read_debug_names_from_section)
 950         (process_psymtab_comp_unit_reader, add_partial_symbol)
 951         (add_partial_subprogram, process_full_comp_unit)
 952         (read_file_scope, read_func_scope, read_lexical_block_scope)
 953         (read_call_site_scope, dwarf2_ranges_read)
 954         (dwarf2_record_block_ranges, dwarf2_add_field)
 955         (mark_common_block_symbol_computed, read_tag_pointer_type)
 956         (read_tag_string_type, dwarf2_init_float_type)
 957         (dwarf2_init_complex_target_type, read_base_type)
 958         (partial_die_info::read, partial_die_info::read)
 959         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
 960         (dwarf2_fetch_die_loc_sect_off): Update.
 961         * dwarf2/loc.c (dwarf2_find_location_expression)
 962         (class dwarf_evaluate_loc_desc, rw_pieced_value)
 963         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
 964         (dwarf2_loc_desc_get_symbol_read_needs)
 965         (locexpr_describe_location_piece, locexpr_describe_location_1)
 966         (loclist_describe_location): Update.
 967         * dwarf2/index-write.c (write_debug_names): Update.
 968         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
 969         * dtrace-probe.c (dtrace_process_dof): Update.
 970         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
 971         (process_one_symbol): Update.
 972         * ctfread.c (ctf_init_float_type, read_base_type): Update.
 973         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
 974         (coff_read_enum_type): Update.
 975         * cli/cli-cmds.c (edit_command, list_command): Update.
 976         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
 977         * breakpoint.c (create_overlay_event_breakpoint)
 978         (create_longjmp_master_breakpoint)
 979         (create_std_terminate_master_breakpoint)
 980         (create_exception_master_breakpoint, get_sal_arch): Update.
 981         * block.c (block_gdbarch): Update.
 982         * annotate.c (annotate_source_line): Update.
 983
 984 2020-04-17  Tom Tromey  <tromey@adacore.com>
 985
 986         * auto-load.c (show_auto_load_cmd): Remove.
 987         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
 988         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
 989         (maintenance_print_arc_command): Remove.
 990         * tui/tui-win.c (tui_command): Remove.
 991         (tui_get_cmd_list): Use add_basic_prefix_cmd.
 992         * tui/tui-layout.c (tui_layout_command): Remove.
 993         (_initialize_tui_layout): Use add_basic_prefix_cmd.
 994         * python/python.c (user_set_python, user_show_python): Remove.
 995         (_initialize_python): Use add_basic_prefix_cmd,
 996         add_show_prefix_cmd.
 997         * guile/guile.c (set_guile_command, show_guile_command): Remove.
 998         (install_gdb_commands): Use add_basic_prefix_cmd,
 999         add_show_prefix_cmd.
1000         (info_guile_command): Remove.
1001         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
1002         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
1003         add_show_prefix_cmd.
1004         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1005         Remove do_set and do_show parameters.
1006         * cli/cli-style.c (set_style, show_style): Remove.
1007         (_initialize_cli_style): Use add_basic_prefix_cmd,
1008         add_show_prefix_cmd.
1009         (cli_style_option::add_setshow_commands): Remove do_set and
1010         do_show parameters.
1011         (cli_style_option::add_setshow_commands): Use
1012         add_basic_prefix_cmd, add_show_prefix_cmd.
1013         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
1014         (set_style_name): Remove.
1015         * cli/cli-dump.c (dump_command, append_command): Remove.
1016         (srec_dump_command, ihex_dump_command, verilog_dump_command)
1017         (tekhex_dump_command, binary_dump_command)
1018         (binary_append_command): Remove.
1019         (_initialize_cli_dump): Use add_basic_prefix_cmd.
1020         * windows-tdep.c (w32_prefix_command_valid): Remove global.
1021         (init_w32_command_list): Remove; move into ...
1022         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
1023         * valprint.c (set_print, show_print, set_print_raw)
1024         (show_print_raw): Remove.
1025         (_initialize_valprint): Use add_basic_prefix_cmd,
1026         add_show_prefix_cmd.
1027         * typeprint.c (set_print_type, show_print_type): Remove.
1028         (_initialize_typeprint): Use add_basic_prefix_cmd,
1029         add_show_prefix_cmd.
1030         * record.c (set_record_command, show_record_command): Remove.
1031         (_initialize_record): Use add_basic_prefix_cmd,
1032         add_show_prefix_cmd.
1033         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
1034         add_show_prefix_cmd.
1035         (info_command, show_command, set_debug, show_debug): Remove.
1036         * top.h (set_history, show_history): Don't declare.
1037         * top.c (set_history, show_history): Remove.
1038         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
1039         (unset_tdesc_cmd): Remove.
1040         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
1041         add_show_prefix_cmd.
1042         * symtab.c (info_module_command): Remove.
1043         (_initialize_symtab): Use add_basic_prefix_cmd.
1044         * symfile.c (overlay_command): Remove.
1045         (_initialize_symfile): Use add_basic_prefix_cmd.
1046         * sparc64-tdep.c (info_adi_command): Remove.
1047         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
1048         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
1049         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
1050         add_show_prefix_cmd.
1051         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
1052         (_initialize_serial): Use add_basic_prefix_cmd,
1053         add_show_prefix_cmd.
1054         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
1055         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
1056         add_show_prefix_cmd.
1057         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
1058         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
1059         add_show_prefix_cmd.
1060         * riscv-tdep.c (show_riscv_command, set_riscv_command)
1061         (show_debug_riscv_command, set_debug_riscv_command): Remove.
1062         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
1063         add_show_prefix_cmd.
1064         * remote.c (remote_command, set_remote_cmd): Remove.
1065         (_initialize_remote): Use add_basic_prefix_cmd.
1066         * record-full.c (set_record_full_command)
1067         (show_record_full_command): Remove.
1068         (_initialize_record_full): Use add_basic_prefix_cmd,
1069         add_show_prefix_cmd.
1070         * record-btrace.c (cmd_set_record_btrace)
1071         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
1072         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
1073         (cmd_show_record_btrace_pt): Remove.
1074         (_initialize_record_btrace): Use add_basic_prefix_cmd,
1075         add_show_prefix_cmd.
1076         * ravenscar-thread.c (set_ravenscar_command)
1077         (show_ravenscar_command): Remove.
1078         (_initialize_ravenscar): Use add_basic_prefix_cmd,
1079         add_show_prefix_cmd.
1080         * mips-tdep.c (show_mips_command, set_mips_command)
1081         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
1082         add_show_prefix_cmd.
1083         * maint.c (maintenance_command, maintenance_info_command)
1084         (maintenance_check_command, maintenance_print_command)
1085         (maintenance_set_cmd, maintenance_show_cmd): Remove.
1086         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
1087         add_show_prefix_cmd.
1088         (show_per_command_cmd): Remove.
1089         * maint-test-settings.c (maintenance_set_test_settings_cmd):
1090         Remove.
1091         (maintenance_show_test_settings_cmd): Remove.
1092         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
1093         add_show_prefix_cmd.
1094         * maint-test-options.c (maintenance_test_options_command):
1095         Remove.
1096         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
1097         * macrocmd.c (macro_command): Remove
1098         (_initialize_macrocmd): Use add_basic_prefix_cmd.
1099         * language.c (set_check, show_check): Remove.
1100         (_initialize_language): Use add_basic_prefix_cmd,
1101         add_show_prefix_cmd.
1102         * infcmd.c (unset_command): Remove.
1103         (_initialize_infcmd): Use add_basic_prefix_cmd.
1104         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
1105         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
1106         add_show_prefix_cmd.
1107         * go32-nat.c (go32_info_dos_command): Remove.
1108         (_initialize_go32_nat): Use add_basic_prefix_cmd.
1109         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
1110         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
1111         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
1112         (_initialize_frame): Use add_basic_prefix_cmd,
1113         add_show_prefix_cmd.
1114         * dcache.c (set_dcache_command, show_dcache_command): Remove.
1115         (_initialize_dcache): Use add_basic_prefix_cmd,
1116         add_show_prefix_cmd.
1117         * cp-support.c (maint_cplus_command): Remove.
1118         (_initialize_cp_support): Use add_basic_prefix_cmd.
1119         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
1120         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
1121         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
1122         add_basic_prefix_cmd, add_show_prefix_cmd.
1123         * breakpoint.c (save_command): Remove.
1124         (_initialize_breakpoint): Use add_basic_prefix_cmd.
1125         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
1126         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
1127         add_show_prefix_cmd.
1128         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
1129         (set_ada_command, show_ada_command): Remove.
1130         (_initialize_ada_language): Use add_basic_prefix_cmd,
1131         add_show_prefix_cmd.
1132         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
1133
1134 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
1135
1136         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
1137         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
1138
1139 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1140
1141         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
1142         warning messages.
1143
1144 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
1145
1146         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
1147         import table is not at beginning of .idata section.
1148
1149 2020-04-16  Pedro Alves  <palves@redhat.com>
1150
1151         * inferior.c (delete_inferior): Use delete operator directly
1152         instead of delete_program_space.
1153         * progspace.c (add_program_space): New, factored out from
1154         program_space::program_space.
1155         (remove_program_space): New, factored out from
1156         delete_program_space.
1157         (program_space::program_space): Remove intro comment.  Rewrite.
1158         (program_space::~program_space): Remove intro comment.  Call
1159         remove_program_space.
1160         (delete_program_space): Delete.
1161         * progspace.h (program_space::program_space): Make explicit.  Move
1162         intro comment here, adjusted.
1163         (program_space::~program_space): Move intro comment here,
1164         adjusted.
1165         (delete_program_space): Remove.
1166
1167 2020-04-16  Tom Tromey  <tromey@adacore.com>
1168
1169         * windows-nat.c (windows_nat::handle_access_violation): New
1170         function.
1171         * nat/windows-nat.h (handle_access_violation): Declare.
1172         * nat/windows-nat.c (handle_exception): Move Cygwin code to
1173         windows-nat.c.  Call handle_access_violation.
1174
1175 2020-04-16  Tom de Vries  <tdevries@suse.de>
1176
1177         PR symtab/25791
1178         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
1179         CUs without psymtab.
1180
1181 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
1182
1183         * python/python.c (do_start_initialization): Don't call
1184         PyEval_InitThreads for Python 3.9 and beyond.
1185
1186 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
1187
1188         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
1189         thread functions.
1190         (obsd_nat_target::wait): Likewise.
1191
1192 2020-04-15  Tom Tromey  <tromey@adacore.com>
1193
1194         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
1195         (DEBUG_EXCEPT): Use debug_printf.
1196
1197 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1198
1199         * completer.c (class completion_tracker::completion_hash_entry)
1200         <hash_name>: New member function.
1201         (completion_tracker::discard_completions): New callback to hash a
1202         completion_hash_entry, pass this to htab_create_alloc.
1203
1204 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
1205
1206         * windows-nat.c (windows_make_so): Warn rather than stopping with
1207         an error if realpath() fails.
1208
1209 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
1210
1211         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
1212         (nbsd_nat_target::info_proc): Add do_status.
1213
1214 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
1215             Tom de Vries  <tdevries@suse.de>
1216
1217         PR symtab/25718
1218         * psympriv.h (struct partial_symtab::read_symtab)
1219         (struct partial_symtab::expand_psymtab)
1220         (struct partial_symtab::read_dependencies): Update comments.
1221         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
1222         read_symtab for includer.
1223         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
1224         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
1225         (struct dwarf2_include_psymtab::m_readin): Remove.
1226         (struct dwarf2_include_psymtab::includer): New member function.
1227         (dwarf2_psymtab::expand_psymtab): Assert !readin.
1228
1229 2020-04-14  Tom de Vries  <tdevries@suse.de>
1230
1231         PR symtab/25720
1232         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
1233         with NULL symbol_matcher and lookup_name.
1234         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
1235         and lookup_name.
1236         * dwarf2/read.c (dw2_expand_symtabs_matching)
1237         (dw2_debug_names_expand_symtabs_matching): Same.
1238         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
1239         Make lookup_name a pointer.  Update comment.
1240         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
1241         lookup_name being a pointer.
1242         * symfile.c (expand_symtabs_matching): Same.
1243         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
1244         * linespec.c (iterate_over_all_matching_symtabs): Same.
1245
1246 2020-04-13  Tom Tromey  <tom@tromey.com>
1247
1248         * run-on-main-thread.c: Update include.
1249         * unittests/main-thread-selftests.c: Update include.
1250         * tui/tui-win.c: Update include.
1251         * tui/tui-io.c: Update include.
1252         * tui/tui-interp.c: Update include.
1253         * tui/tui-hooks.c: Update include.
1254         * top.h: Update include.
1255         * top.c: Update include.
1256         * ser-base.c: Update include.
1257         * remote.c: Update include.
1258         * remote-notif.c: Update include.
1259         * remote-fileio.c: Update include.
1260         * record-full.c: Update include.
1261         * record-btrace.c: Update include.
1262         * python/python.c: Update include.
1263         * posix-hdep.c: Update include.
1264         * mingw-hdep.c: Update include.
1265         * mi/mi-main.c: Update include.
1266         * mi/mi-interp.c: Update include.
1267         * main.c: Update include.
1268         * linux-nat.c: Update include.
1269         * interps.c: Update include.
1270         * infrun.c: Update include.
1271         * inf-loop.c: Update include.
1272         * event-top.c: Update include.
1273         * event-loop.c: Move to ../gdbsupport/.
1274         * event-loop.h: Move to ../gdbsupport/.
1275         * async-event.h: Update include.
1276         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
1277
1278 2020-04-13  Tom Tromey  <tom@tromey.com>
1279
1280         * tui/tui-win.c: Include async-event.h.
1281         * remote.c: Include async-event.h.
1282         * remote-notif.c: Include async-event.h.
1283         * record-full.c: Include async-event.h.
1284         * record-btrace.c: Include async-event.h.
1285         * infrun.c: Include async-event.h.
1286         * event-top.c: Include async-event.h.
1287         * event-loop.h: Move some declarations to async-event.h.
1288         * event-loop.c: Don't include ser-event.h or top.h.  Move some
1289         code to async-event.c.
1290         * async-event.h: New file.
1291         * async-event.c: New file.
1292         * Makefile.in (COMMON_SFILES): Add async-event.c.
1293         (HFILES_NO_SRCDIR): Add async-event.h.
1294
1295 2020-04-13  Tom Tromey  <tom@tromey.com>
1296
1297         * utils.c (flush_streams): New function.
1298         * event-loop.c (gdb_wait_for_event): Call flush_streams.
1299
1300 2020-04-13  Tom Tromey  <tom@tromey.com>
1301
1302         * event-loop.c (handle_file_event): Use warning, not
1303         printf_unfiltered.
1304
1305 2020-04-13  Tom Tromey  <tom@tromey.com>
1306
1307         * event-loop.c: Include <chrono>.
1308
1309 2020-04-13  Tom Tromey  <tom@tromey.com>
1310
1311         * gdb_select.h: Move to ../gdbsupport/.
1312         * event-loop.c: Update include path.
1313         * top.c: Update include path.
1314         * ser-base.c: Update include path.
1315         * ui-file.c: Update include path.
1316         * ser-tcp.c: Update include path.
1317         * guile/scm-ports.c: Update include path.
1318         * posix-hdep.c: Update include path.
1319         * ser-unix.c: Update include path.
1320         * gdb_usleep.c: Update include path.
1321         * mingw-hdep.c: Update include path.
1322         * inflow.c: Update include path.
1323         * infrun.c: Update include path.
1324         * event-top.c: Update include path.
1325
1326 2020-04-13  Tom Tromey  <tom@tromey.com>
1327
1328         * configure: Rebuild.
1329         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1330
1331 2020-04-13  Tom Tromey  <tom@tromey.com>
1332
1333         * event-loop.h (start_event_loop): Don't declare.
1334         * event-loop.c (start_event_loop): Move...
1335         * main.c (start_event_loop): ...here.  Now static.
1336
1337 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1338
1339         * MAINTAINERS: Update my email address.
1340
1341 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1342
1343         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1344         IP_ALL.
1345
1346 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1347
1348         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1349         (nbsd_nat_target::info_proc): Add do_cmdline.
1350
1351 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1352
1353         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1354         (nbsd_nat_target::info_proc): Add do_cwd.
1355
1356 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1357
1358         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
1359
1360 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
1361
1362         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
1363         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
1364         (nbsd_nat_target::info_proc): New functions.
1365         * nbsd-nat.c (kinfo_get_vmmap): New function.
1366         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
1367         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
1368         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
1369         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
1370         functions.
1371         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
1372         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
1373         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
1374         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
1375         (KINFO_VME_FLAG_GROWS_DOWN): New.
1376
1377 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
1378
1379         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
1380         bit shift.
1381
1382 2020-04-10  Tom Tromey  <tromey@adacore.com>
1383
1384         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
1385
1386 2020-04-10  Tom Tromey  <tromey@adacore.com>
1387
1388         * symtab.c (get_symbol_address, get_msymbol_address): Skip
1389         separate debug files.
1390
1391 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
1392
1393         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1394         Move to...
1395         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1396         ... here.
1397         * windows-nat.c (windows_nat_target::get_windows_debug_event):
1398         Check for STATUS_WX86_BREAKPOINT.
1399         (windows_nat_target::wait): Same.
1400
1401 2020-04-10  Tom de Vries  <tdevries@suse.de>
1402
1403         PR cli/25808
1404         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
1405
1406 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1407
1408         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
1409         (Write After Approval): Remove Tom de Vries.
1410
1411 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1412
1413         revert partially:
1414         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1415
1416         * buildsym.c (record_line): Fix undefined behavior and preserve
1417         lines at eof.
1418
1419 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
1420
1421         * auxv.h (svr4_auxv_parse): New.
1422         * auxv.c (default_auxv_parse): Split into default_auxv_parse
1423         and generic_auxv_parse.
1424         (svr4_auxv_parse): Add.
1425         * obsd-tdep.c: Include "auxv.h".
1426         (obsd_auxv_parse): Remove.
1427         (obsd_init_abi): Remove comment.
1428         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
1429         from `obsd_auxv_parse' to `svr4_auxv_parse'.
1430         * nbsd-tdep.c: Include "auxv.h".
1431         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
1432
1433 2020-04-08  Tom Tromey  <tromey@adacore.com>
1434
1435         * nat/windows-nat.h (last_wait_event): Don't declare.
1436         (wait_for_debug_event): Update comment.
1437         * nat/windows-nat.c (last_wait_event): Now static.
1438
1439 2020-04-08  Tom Tromey  <tromey@adacore.com>
1440
1441         * windows-nat.c (wait_for_debug_event): Move to
1442         nat/windows-nat.c.
1443         * nat/windows-nat.h (wait_for_debug_event): Declare.
1444         * nat/windows-nat.c (wait_for_debug_event): Move from
1445         windows-nat.c.  No longer static.
1446
1447 2020-04-08  Tom Tromey  <tromey@adacore.com>
1448
1449         * windows-nat.c (get_windows_debug_event): Use
1450         fetch_pending_stop.
1451         * nat/windows-nat.h (fetch_pending_stop): Declare.
1452         * nat/windows-nat.c (fetch_pending_stop): New function.
1453
1454 2020-04-08  Tom Tromey  <tromey@adacore.com>
1455
1456         * windows-nat.c (windows_continue): Use matching_pending_stop and
1457         continue_last_debug_event.
1458         * nat/windows-nat.h (matching_pending_stop)
1459         (continue_last_debug_event): Declare.
1460         * nat/windows-nat.c (DEBUG_EVENTS): New define.
1461         (matching_pending_stop, continue_last_debug_event): New
1462         functions.
1463
1464 2020-04-08  Tom Tromey  <tromey@adacore.com>
1465
1466         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
1467         (handle_exception_result): Move to nat/windows-nat.h.
1468         (DEBUG_EXCEPTION_SIMPLE): Remove.
1469         (windows_nat::handle_ms_vc_exception): New function.
1470         (handle_exception): Move to nat/windows-nat.c.
1471         (get_windows_debug_event): Update.
1472         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
1473         nat/windows-nat.c.
1474         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
1475         (handle_exception_result): Move from windows-nat.c.
1476         (handle_exception): Declare.
1477         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
1478         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
1479         windows-nat.c.
1480
1481 2020-04-08  Tom Tromey  <tromey@adacore.com>
1482
1483         * windows-nat.c (exception_count, event_count): Remove.
1484         (handle_exception, get_windows_debug_event)
1485         (do_initial_windows_stuff): Update.
1486
1487 2020-04-08  Tom Tromey  <tromey@adacore.com>
1488
1489         * windows-nat.c (windows_nat::handle_load_dll)
1490         (windows_nat::handle_unload_dll): Rename.  No longer static.
1491         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1492         Declare.
1493
1494 2020-04-08  Tom Tromey  <tromey@adacore.com>
1495
1496         * complaints.h (stop_whining): Declare at top-level.
1497         (complaint): Don't declare stop_whining.
1498
1499 2020-04-08  Tom Tromey  <tromey@adacore.com>
1500
1501         * windows-nat.c (windows_nat::handle_output_debug_string):
1502         Rename.  No longer static.
1503         * nat/windows-nat.h (handle_output_debug_string): Declare.
1504
1505 2020-04-08  Tom Tromey  <tromey@adacore.com>
1506
1507         * windows-nat.c (current_process_handle, current_process_id)
1508         (main_thread_id, last_sig, current_event, last_wait_event)
1509         (current_windows_thread, desired_stop_thread_id, pending_stops)
1510         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1511         (display_selectors, fake_create_process)
1512         (get_windows_debug_event): Update.
1513         * nat/windows-nat.h (current_process_handle, current_process_id)
1514         (main_thread_id, last_sig, current_event, last_wait_event)
1515         (current_windows_thread, desired_stop_thread_id, pending_stops)
1516         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1517         * nat/windows-nat.c (current_process_handle, current_process_id)
1518         (main_thread_id, last_sig, current_event, last_wait_event)
1519         (current_windows_thread, desired_stop_thread_id, pending_stops)
1520         (siginfo_er): New globals.  Move from windows-nat.c.
1521
1522 2020-04-08  Tom Tromey  <tromey@adacore.com>
1523
1524         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1525         (handle_load_dll): Update.
1526         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1527
1528 2020-04-08  Tom Tromey  <tromey@adacore.com>
1529
1530         * windows-nat.c (enum thread_disposition_type): Move to
1531         nat/windows-nat.h.
1532         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1533         static.
1534         (windows_add_thread, windows_nat_target::fetch_registers)
1535         (windows_nat_target::store_registers, handle_exception)
1536         (windows_nat_target::resume, get_windows_debug_event)
1537         (windows_nat_target::get_tib_address)
1538         (windows_nat_target::thread_name)
1539         (windows_nat_target::thread_alive): Update.
1540         * nat/windows-nat.h (enum thread_disposition_type): Move from
1541         windows-nat.c.
1542         (thread_rec): Declare.
1543
1544 2020-04-08  Tom Tromey  <tromey@adacore.com>
1545
1546         * windows-nat.c: Add "using namespace".
1547         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1548         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1549
1550 2020-04-08  Tom Tromey  <tromey@adacore.com>
1551
1552         * nat/windows-nat.h (struct windows_thread_info): Declare
1553         destructor.
1554         * nat/windows-nat.c (~windows_thread_info): New.
1555
1556 2020-04-08  Tom Tromey  <tromey@adacore.com>
1557
1558         PR gdb/22992
1559         * windows-nat.c (current_event): Update comment.
1560         (last_wait_event, desired_stop_thread_id): New globals.
1561         (struct pending_stop): New.
1562         (pending_stops): New global.
1563         (windows_nat_target) <stopped_by_sw_breakpoint>
1564         <supports_stopped_by_sw_breakpoint>: New methods.
1565         (windows_fetch_one_register): Add assertions.  Adjust PC.
1566         (windows_continue): Handle pending stops.  Suspend other threads
1567         when stepping.  Use last_wait_event
1568         (wait_for_debug_event): New function.
1569         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1570         pending stops.  Queue spurious stops.
1571         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1572         (windows_nat_target::kill): Use wait_for_debug_event.
1573         * nat/windows-nat.h (struct windows_thread_info)
1574         <stopped_at_software_breakpoint>: New field.
1575         * nat/windows-nat.c (windows_thread_info::resume): Clear
1576         stopped_at_software_breakpoint.
1577
1578 2020-04-08  Tom Tromey  <tromey@adacore.com>
1579
1580         * windows-nat.c (enum thread_disposition_type): New.
1581         (thread_rec): Replace "get_context" parameter with "disposition";
1582         change type.
1583         (windows_add_thread, windows_nat_target::fetch_registers)
1584         (windows_nat_target::store_registers, handle_exception)
1585         (windows_nat_target::resume, get_windows_debug_event)
1586         (windows_nat_target::get_tib_address)
1587         (windows_nat_target::thread_name)
1588         (windows_nat_target::thread_alive): Update.
1589
1590 2020-04-08  Tom Tromey  <tromey@adacore.com>
1591
1592         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1593         (windows_continue): Use windows_continue::resume.
1594         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1595         resume>: Declare new methods.
1596         * nat/windows-nat.c: New file.
1597         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1598
1599 2020-04-08  Tom Tromey  <tromey@adacore.com>
1600
1601         * windows-nat.c (windows_add_thread, windows_delete_thread)
1602         (windows_nat_target::fetch_registers)
1603         (windows_nat_target::store_registers, fake_create_process)
1604         (windows_nat_target::resume, windows_nat_target::resume)
1605         (get_windows_debug_event, windows_nat_target::wait)
1606         (windows_nat_target::pid_to_str)
1607         (windows_nat_target::get_tib_address)
1608         (windows_nat_target::get_ada_task_ptid)
1609         (windows_nat_target::thread_name)
1610         (windows_nat_target::thread_alive): Use lwp, not tid.
1611
1612 2020-04-08  Tom Tromey  <tromey@adacore.com>
1613
1614         * windows-nat.c (handle_exception)
1615         (windows_nat_target::thread_name): Update.
1616         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1617         <name>: Now unique_xmalloc_ptr.
1618
1619 2020-04-08  Tom Tromey  <tromey@adacore.com>
1620
1621         * windows-nat.c (thread_rec)
1622         (windows_nat_target::fetch_registers): Update.
1623         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1624         Update comment.
1625         <debug_registers_changed, reload_context>: Now bool.
1626
1627 2020-04-08  Tom Tromey  <tromey@adacore.com>
1628
1629         * windows-nat.c (windows_add_thread): Use new.
1630         (windows_init_thread_list, windows_delete_thread): Use delete.
1631         (get_windows_debug_event): Update.
1632         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1633         destructor, and initializers.
1634
1635 2020-04-08  Tom Tromey  <tromey@adacore.com>
1636
1637         * windows-nat.c (struct windows_thread_info): Remove.
1638         * nat/windows-nat.h: New file.
1639
1640 2020-04-08  Tom Tromey  <tromey@adacore.com>
1641
1642         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1643         (thread_rec, windows_add_thread, windows_delete_thread)
1644         (windows_continue): Update.
1645
1646 2020-04-08  Tom Tromey  <tromey@adacore.com>
1647
1648         * windows-nat.c (struct windows_thread_info): Remove typedef.
1649         (thread_head): Remove.
1650         (thread_list): New global.
1651         (thread_rec, windows_add_thread, windows_init_thread_list)
1652         (windows_delete_thread, windows_continue): Update.
1653
1654 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1655
1656         * windows-tdep.h (windows_init_abi): Add comment.
1657         (cygwin_init_abi): New declaration.
1658         * windows-tdep.c: Split signal enumeration in two, one for
1659         Windows and one for Cygwin.
1660         (windows_gdb_signal_to_target): Only deal with signal of the
1661         Windows OS ABI.
1662         (cygwin_gdb_signal_to_target): New function.
1663         (windows_init_abi): Rename to windows_init_abi_common, don't set
1664         gdb_signal_to_target gdbarch method.  Add new new function with
1665         this name.
1666         (cygwin_init_abi): New function.
1667         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1668         comment.  Don't call windows_init_abi.
1669         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1670         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1671         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1672         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1673         a new function of this name.
1674         (i386_cygwin_init_abi): New function.
1675         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1676         OS ABI Cygwin.
1677
1678 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1679
1680         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1681         parameter.c.
1682         (dwarf2_read_gdb_index): Update.
1683
1684 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1685
1686         * nbsd-tdep.c: Include "objfiles.h".
1687         (nbsd_skip_solib_resolver): New.
1688         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1689
1690 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1691
1692         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1693         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1694         with DW_LLE_base_addressx are being emitted in DWARFv5.
1695         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1696         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1697         unsigned integer.
1698
1699 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1700
1701         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1702         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1703         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1704         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1705         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1706         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1707         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1708
1709
1710 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1711
1712         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1713         (read_loclist_index): New function definition.
1714         (lookup_loclist_base): New function definition.
1715         (read_loclist_header): New function definition.
1716         (dwarf2_cu): Add loclist_base and loclist_header field.
1717         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1718         (read_full_die_1): Read the value of DW_AT_loclists_base.
1719         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1720         (read_attribute_value): Handle DW_FORM_loclistx.
1721         (skip_one_die): Handle DW_FORM_loclistx.
1722         (loclist_header): New structure declaration.
1723         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1724
1725 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1726
1727         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1728         constructor.  Remove `addr` parameter from other constructor and
1729         add `per_cu` parameter.
1730         * dwarf2/read.c (create_partial_symtab): Update.
1731
1732 2020-04-07  Tom de Vries  <tdevries@suse.de>
1733
1734         PR symtab/25796
1735         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1736         (partial_die_info::fixup): Inherit has_const_value.
1737
1738 2020-04-07  Tom de Vries  <tdevries@suse.de>
1739
1740         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1741         symbols without address.
1742
1743 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1744
1745         * nbsd-nat.h (struct thread_info): Add forward declaration.
1746         (nbsd_nat_target::thread_alive): Add.
1747         (nbsd_nat_target::thread_name): Likewise.
1748         (nbsd_nat_target::update_thread_list): Likewise.
1749         (update_thread_list::post_attach): Likewise.
1750         (post_attach::pid_to_str): Likewise.
1751         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1752         (nbsd_thread_lister): Add.
1753         (nbsd_nat_target::thread_alive): Likewise.
1754         (nbsd_nat_target::thread_name): Likewise.
1755         (nbsd_add_threads): Likewise.
1756         (update_thread_list::post_attach): Likewise.
1757         (nbsd_nat_target::update_thread_list): Likewise.
1758         (post_attach::pid_to_str): Likewise.
1759
1760 2020-04-06  Tom Tromey  <tromey@adacore.com>
1761
1762         * ada-valprint.c (print_variant_part): Extract the variant field.
1763         (print_field_values): Use the field as the outer value when
1764         recursing.
1765
1766 2020-04-06  Tom Tromey  <tromey@adacore.com>
1767
1768         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
1769         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
1770         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
1771         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
1772         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
1773
1774 2020-04-06  Tom Tromey  <tromey@adacore.com>
1775
1776         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
1777         TYPE_CODE_ERROR.
1778
1779 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1780
1781         * nbsd-tdep.c: Include "gdbarch.h".
1782         Define enum with NetBSD signal numbers.
1783         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
1784         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
1785         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1786         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
1787         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
1788         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
1789         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
1790         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
1791         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
1792         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
1793         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
1794         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
1795
1796 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
1797
1798         PR gdb/25325
1799         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
1800
1801 2020-04-03  Tom Tromey  <tromey@adacore.com>
1802
1803         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
1804         Read constant block.
1805
1806 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1807
1808         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
1809         (gdb_bfd_get_full_section_contents): New declaration.
1810         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
1811         * windows-tdep.c (is_linked_with_cygwin_dll): Use
1812         gdb_bfd_get_full_section_contents.
1813
1814 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1815
1816         * exec.c (build_section_table): Replace internal_error with
1817         gdb_assert.
1818         (section_table_xfer_memory_partial): Likewise.
1819         * mdebugread.c (parse_partial_symbols): Likewise.
1820         * psymtab.c (lookup_partial_symbol): Likewise.
1821         * utils.c (wrap_here): Likewise.
1822
1823 2020-04-02  Tom Tromey  <tromey@adacore.com>
1824
1825         * f-lang.c (build_fortran_types): Use arch_type to initialize
1826         builtin_complex_s32 in the TYPE_CODE_ERROR case.
1827
1828 2020-04-02  Tom Tromey  <tromey@adacore.com>
1829
1830         * dwarf2/read.c (partial_die_info::read): Do not create a vector
1831         of attributes.
1832
1833 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1834             Bernd Edlinger <bernd.edlinger@hotmail.de>
1835             Tom Tromey  <tromey@adacore.com>
1836
1837         * buildsym.c (buildsym_compunit::record_line): Remove
1838         deduplication code.
1839
1840 2020-04-02  Tom de Vries  <tdevries@suse.de>
1841
1842         PR ada/24671
1843         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1844
1845 2020-04-02  Tom de Vries  <tdevries@suse.de>
1846
1847         * dwarf2/read.c (dwarf2_gdb_index_functions,
1848         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1849         NULL.
1850         * psymtab.c (psym_lookup_global_symbol_language): New function.
1851         (psym_functions): Init psym_lookup_global_symbol_language with
1852         psym_lookup_global_symbol_language.
1853         * symfile-debug.c (debug_sym_quick_functions): Init
1854         lookup_global_symbol_language with NULL.
1855         * symfile.c (set_initial_language): Remove fixme comment.
1856         * symfile.h (struct quick_symbol_functions): Add
1857         lookup_global_symbol_language.
1858         * symtab.c (find_quick_global_symbol_language): New function.
1859         (find_main_name): Use find_quick_global_symbol_language.
1860
1861 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1862
1863         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1864
1865 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1866
1867         * buildsym.c (record_line): Fix undefined behavior and preserve
1868         lines at eof.
1869
1870 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1871
1872         * buildsym.c (record_line): Fix the resizing condition.
1873
1874 2020-04-01  Tom Tromey  <tom@tromey.com>
1875
1876         * value.h (value_literal_complex): Add comment.
1877         * valops.c (value_literal_complex): Refer to value.h.
1878
1879 2020-04-01  Tom Tromey  <tom@tromey.com>
1880
1881         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1882         (scalar_type): New rule, from typebase.
1883         (typebase): Use scalar_type.  Recognize complex types.
1884         (field_name): Handle FLOAT_KEYWORD.
1885         (ident_tokens): Add _Complex and __complex__.
1886
1887 2020-04-01  Tom Tromey  <tom@tromey.com>
1888
1889         PR exp/25299:
1890         * valarith.c (promotion_type, complex_binop): New functions.
1891         (scalar_binop): Handle complex numbers.  Use promotion_type.
1892         (value_pos, value_neg, value_complement): Handle complex numbers.
1893
1894 2020-04-01  Tom Tromey  <tom@tromey.com>
1895
1896         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1897         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1898         (parse_number): Handle complex numbers.
1899
1900 2020-04-01  Tom Tromey  <tom@tromey.com>
1901
1902         * c-valprint.c (c_decorations): Change complex suffix to "i".
1903
1904 2020-04-01  Tom Tromey  <tom@tromey.com>
1905
1906         * valprint.c (generic_value_print_complex): Use accessors.
1907         * value.h (value_real_part, value_imaginary_part): Declare.
1908         * valops.c (value_real_part, value_imaginary_part): New
1909         functions.
1910         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
1911
1912 2020-04-01  Tom Tromey  <tom@tromey.com>
1913
1914         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
1915         (read_range_type): Update.
1916         * mdebugread.c (basic_type): Update.
1917         * go-lang.c (build_go_types): Use init_complex_type.
1918         * gdbtypes.h (struct main_type) <complex_type>: New member.
1919         (init_complex_type): Update.
1920         (arch_complex_type): Don't declare.
1921         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
1922         Make name if none given.  Use alloc_type_copy.  Look for cached
1923         complex type.
1924         (arch_complex_type): Remove.
1925         (gdbtypes_post_init): Use init_complex_type.
1926         * f-lang.c (build_fortran_types): Use init_complex_type.
1927         * dwarf2/read.c (read_base_type): Update.
1928         * d-lang.c (build_d_types): Use init_complex_type.
1929         * ctfread.c (read_base_type): Update.
1930
1931 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1932
1933         * infrun.c (stop_all_threads): Update assertion, plus when
1934         stopping threads, take into account that we might be trying
1935         to stop an all-stop target.
1936         (stop_waiting): Call 'stop_all_threads' if there exists a
1937         non-stop target.
1938
1939 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1940
1941         * target.h (exists_non_stop_target): New function declaration.
1942         * target.c (exists_non_stop_target): New function.
1943
1944 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
1945
1946         PR gdb/24789
1947         * eval.c (is_integral_or_integral_reference): New function.
1948         (evaluate_subexp_standard): Allow integer references in
1949         pointer arithmetic.
1950
1951 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1952
1953         * remote.c (remote_target::remote_parse_stop_reply): Remove the
1954         check for no ptid in the stop reply when the target is non-stop.
1955
1956 2020-04-01  Tom Tromey  <tromey@adacore.com>
1957
1958         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
1959         "name" parameter to rvalue reference.  Initialize m_name_holder.
1960         <lookup_name_info>: New overloads.
1961         <name>: Return gdb::string_view.
1962         <c_str>: New method.
1963         <make_ignore_params>: Update.
1964         <search_name_hash>: Update.
1965         <language_lookup_name>: Return const char *.
1966         <m_name>: Change type.
1967         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
1968         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
1969         (lookup_name_info::match_any): Update.
1970         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
1971         Update.
1972         * minsyms.c (linkage_name_str): Update.
1973         * language.c (default_symbol_name_matcher): Update.
1974         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
1975         Update.
1976         * ada-lang.c (ada_fold_name): Change parameter to string_view.
1977         (ada_lookup_name_info::ada_lookup_name_info): Update.
1978         (literal_symbol_name_matcher): Update.
1979
1980 2020-04-01  Tom Tromey  <tromey@adacore.com>
1981
1982         * psymtab.c (psymtab_search_name): Remove function.
1983         (psym_lookup_symbol): Create search name and lookup name here.
1984         (lookup_partial_symbol): Remove "name" parameter; add
1985         lookup_name.
1986         (psym_expand_symtabs_for_function): Update.
1987
1988 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
1989
1990         PR tui/25597:
1991         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
1992
1993 2020-03-31  Tom Tromey  <tromey@adacore.com>
1994
1995         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
1996         memcpy.
1997
1998 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
1999
2000         * features/riscv/32bit-csr.xml: Regenerated.
2001         * features/riscv/64bit-csr.xml: Regenerated.
2002
2003 2020-03-30  Tom Tromey  <tromey@adacore.com>
2004
2005         * ada-valprint.c (print_variant_part): Update.
2006         * ada-lang.h (ada_which_variant_applies): Update.
2007         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
2008         outer_valaddr parameters; replace with "outer" value parameter.
2009         (to_fixed_variant_branch_type): Update.
2010
2011 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2012
2013         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
2014         <list>.  Remove inclusion of observable.h.
2015         (PPC_DEBUG_CURRENT_VERSION): Move up define.
2016         (struct arch_lwp_info): New struct.
2017         (class ppc_linux_dreg_interface): New class.
2018         (struct ppc_linux_process_info): New struct.
2019         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
2020         <low_new_clone, low_forget_process, low_prepare_to_resume>
2021         <copy_thread_dreg_state, mark_thread_stale>
2022         <mark_debug_registers_changed, register_hw_breakpoint>
2023         <clear_hw_breakpoint, register_wp, clear_wp>
2024         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
2025         <num_memory_accesses, get_trigger_type>
2026         <create_watchpoint_request, hwdebug_point_cmp>
2027         <init_arch_lwp_info, get_arch_lwp_info>
2028         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
2029         methods.
2030         <struct ptid_hash>: New inner struct.
2031         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
2032         members.
2033         (saved_dabr_value, hwdebug_info, max_slots_number)
2034         (struct hw_break_tuple, struct thread_points, ppc_threads)
2035         (have_ptrace_hwdebug_interface)
2036         (hwdebug_find_thread_points_by_tid)
2037         (hwdebug_insert_point, hwdebug_remove_point): Remove.
2038         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
2039         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
2040         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
2041         use m_dreg_interface.
2042         (hwdebug_point_cmp): Change to...
2043         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
2044         reference arguments instead of pointers.
2045         (ppc_linux_nat_target::ranged_break_num_registers): Use
2046         m_dreg_interface.
2047         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
2048         m_dreg_interface.  Call register_hw_breakpoint.
2049         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
2050         m_dreg_interface.  Call clear_hw_breakpoint.
2051         (get_trigger_type): Change to...
2052         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
2053         comment.
2054         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
2055         use m_dreg_interface.  Call register_hw_breakpoint.
2056         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
2057         use m_dreg_interface.  Call clear_hw_breakpoint.
2058         (can_use_watchpoint_cond_accel): Change to...
2059         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
2060         method.  Update comment, use m_dreg_interface and
2061         m_process_info.
2062         (calculate_dvc): Change to...
2063         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
2064         m_dreg_interface.
2065         (num_memory_accesses): Change to...
2066         (ppc_linux_nat_target::num_memory_accesses): ...this method.
2067         (check_condition): Change to...
2068         (ppc_linux_nat_target::check_condition): ...this method.
2069         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
2070         comment, use m_dreg_interface.
2071         (create_watchpoint_request): Change to...
2072         (ppc_linux_nat_target::create_watchpoint_request): ...this
2073         method.  Use m_dreg_interface.
2074         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
2075         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
2076         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
2077         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
2078         (ppc_linux_nat_target::low_forget_process)
2079         (ppc_linux_nat_target::low_new_fork)
2080         (ppc_linux_nat_target::low_new_clone)
2081         (ppc_linux_nat_target::low_delete_thread)
2082         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
2083         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
2084         only call mark_thread_stale.
2085         (ppc_linux_thread_exit): Remove.
2086         (ppc_linux_nat_target::stopped_data_address): Change to...
2087         (ppc_linux_nat_target::low_stopped_data_address): This. Add
2088         comment, use m_dreg_interface and m_thread_hw_breakpoints.
2089         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
2090         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
2091         comment.  Call low_stopped_data_address.
2092         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
2093         m_dreg_interface.
2094         (ppc_linux_nat_target::masked_watch_num_registers): Use
2095         m_dreg_interface.
2096         (ppc_linux_nat_target::copy_thread_dreg_state)
2097         (ppc_linux_nat_target::mark_thread_stale)
2098         (ppc_linux_nat_target::mark_debug_registers_changed)
2099         (ppc_linux_nat_target::register_hw_breakpoint)
2100         (ppc_linux_nat_target::clear_hw_breakpoint)
2101         (ppc_linux_nat_target::register_wp)
2102         (ppc_linux_nat_target::clear_wp)
2103         (ppc_linux_nat_target::init_arch_lwp_info)
2104         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
2105         (_initialize_ppc_linux_nat): Remove observer callback.
2106
2107 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2108
2109         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
2110         (ppc_linux_nat_target::auxv_parse)
2111         (ppc_linux_nat_target::read_description)
2112         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
2113         Move up.
2114
2115 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2116
2117         * linux-nat.h (low_new_clone): New method.
2118         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
2119
2120 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2121
2122         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
2123         (dbx_expand_psymtab): ... this.
2124         (start_psymtab): Update.
2125         * mdebugread.c (psymtab_to_symtab_1): Rename to...
2126         (mdebug_expand_psymtab): ... this.
2127         (parse_partial_symbols): Update.
2128         (new_psymtab): Update.
2129         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
2130         (xcoff_expand_psymtab): ... this.
2131         (xcoff_start_psymtab): Update.
2132
2133 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2134
2135         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
2136         <expand_dependencies>: ... this.
2137         * psymtab.c (partial_symtab::read_dependencies): Rename to...
2138         (partial_symtab::expand_dependencies): ... this.
2139         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
2140         Update.
2141         (dwarf2_psymtab::expand_psymtab): Update.
2142         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
2143         * mdebugread.c (psymtab_to_symtab_1): Update.
2144         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
2145
2146 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
2147
2148         * psympriv.h (discard_psymtab): Remove.
2149         * dbxread.c (dbx_end_psymtab): Update.
2150         * xcoffread.c (xcoff_end_psymtab): Update.
2151
2152 2020-03-28  Tom Tromey  <tom@tromey.com>
2153
2154         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
2155         comment.
2156
2157 2020-03-28  Tom Tromey  <tom@tromey.com>
2158
2159         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
2160
2161 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
2162
2163         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2164
2165 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
2166
2167         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
2168
2169 2020-03-26  Tom Tromey  <tom@tromey.com>
2170
2171         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
2172         (mark_common_block_symbol_computed, read_tag_string_type)
2173         (attr_to_dynamic_prop, read_subrange_type): Update.
2174         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
2175         to be methods on struct attribute.
2176         (skip_one_die, process_imported_unit_die, read_namespace_alias)
2177         (read_call_site_scope, partial_die_info::read)
2178         (partial_die_info::read, lookup_die_type, follow_die_ref):
2179         Update.
2180         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
2181         from dwarf2_get_ref_die_offset.
2182         (attribute::constant_value): New method, from
2183         dwarf2_get_attr_constant_value.
2184         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
2185         Declare method.
2186         <constant_value>: New method.
2187
2188 2020-03-26  Tom Tromey  <tom@tromey.com>
2189
2190         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
2191         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
2192         (dwarf_type_encoding_name): Move to stringify.c.
2193         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
2194         * dwarf2/stringify.c: New file.
2195         * dwarf2/stringify.h: New file.
2196
2197 2020-03-26  Tom Tromey  <tom@tromey.com>
2198
2199         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
2200         Rewrite.
2201
2202 2020-03-26  Tom Tromey  <tom@tromey.com>
2203
2204         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
2205         methods.
2206         * dwarf2/read.c (lookup_addr_base): Move to die.h.
2207         (lookup_ranges_base): Likewise.
2208         (read_cutu_die_from_dwo, read_full_die_1): Update.
2209
2210 2020-03-26  Tom Tromey  <tom@tromey.com>
2211
2212         * dwarf2/read.c (read_import_statement, read_file_scope)
2213         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
2214         (read_lexical_block_scope, read_call_site_scope)
2215         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
2216         (handle_struct_member_die, process_structure_scope)
2217         (update_enumeration_type_from_children)
2218         (process_enumeration_scope, read_array_type, read_common_block)
2219         (read_namespace, read_module, read_subroutine_type): Update.
2220         (sibling_die): Remove.
2221
2222 2020-03-26  Tom Tromey  <tom@tromey.com>
2223
2224         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
2225         (build_type_psymtabs_reader, read_structure_type)
2226         (read_enumeration_type, read_full_die_1): Update.
2227         (dwarf2_attr_no_follow): Move to die.h.
2228         * dwarf2/die.h (struct die_info) <attr>: New method.
2229
2230 2020-03-26  Tom Tromey  <tom@tromey.com>
2231
2232         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
2233         <base_address>: Now an optional.
2234         (dwarf2_find_base_address, dwarf2_rnglists_process)
2235         (dwarf2_ranges_process, fill_in_loclist_baton)
2236         (dwarf2_symbol_mark_computed): Update.
2237
2238 2020-03-26  Tom Tromey  <tom@tromey.com>
2239
2240         * dwarf2/read.c (struct die_info): Move to die.h.
2241         * dwarf2/die.h: New file.
2242
2243 2020-03-26  Tom Tromey  <tom@tromey.com>
2244
2245         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
2246         * dwarf2/read.c
2247         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2248         Move to line-header.c.
2249         (read_checked_initial_length_and_offset, read_formatted_entries):
2250         Likewise.
2251         (dwarf_decode_line_header): Split into two.
2252         * dwarf2/line-header.c
2253         (dwarf2_statement_list_fits_in_line_number_section_complaint):
2254         Move from read.c.
2255         (read_checked_initial_length_and_offset, read_formatted_entries):
2256         Likewise.
2257         (dwarf_decode_line_header): New function, split from read.c.
2258
2259 2020-03-26  Tom Tromey  <tom@tromey.com>
2260
2261         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
2262         Declare method.
2263         * dwarf2/read.c (read_attribute_value): Update.
2264         (dwarf2_per_objfile::read_line_string): Rename from
2265         read_indirect_line_string.
2266         (read_formatted_entries): Update.
2267
2268 2020-03-26  Tom Tromey  <tom@tromey.com>
2269
2270         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
2271         variable.
2272
2273 2020-03-26  Tom Tromey  <tom@tromey.com>
2274
2275         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
2276         const.
2277         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
2278         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
2279         parameter const.
2280
2281 2020-03-26  Tom Tromey  <tom@tromey.com>
2282
2283         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
2284         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
2285         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
2286         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
2287
2288 2020-03-26  Tom Tromey  <tom@tromey.com>
2289
2290         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
2291         file_names_size, file_full_name, file_file_name>: Use const.
2292         <file_name_at, file_names>: Add const overload.
2293         * dwarf2/line-header.c (line_header::file_file_name)
2294         (line_header::file_full_name): Update.
2295
2296 2020-03-26  Tom Tromey  <tom@tromey.com>
2297
2298         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
2299         (macro_start_file, consume_improper_spaces)
2300         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
2301         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
2302         (dwarf_decode_macros): Move to macro.c.
2303         * dwarf2/macro.c: New file.
2304         * dwarf2/macro.h: New file.
2305         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
2306
2307 2020-03-26  Tom Tromey  <tom@tromey.com>
2308
2309         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2310         method.
2311         * dwarf2/section.c: New method.  From
2312         read_indirect_string_at_offset_from.
2313         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2314         (read_indirect_string_at_offset_from): Move to section.c.
2315         (read_indirect_string_at_offset): Rewrite.
2316         (read_indirect_line_string_at_offset): Remove.
2317         (read_indirect_string, read_indirect_line_string)
2318         (dwarf_decode_macro_bytes): Update.
2319
2320 2020-03-26  Tom Tromey  <tom@tromey.com>
2321
2322         * dwarf2/section.h (struct dwarf2_section_info)
2323         <overload_complaint>: Declare.
2324         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2325         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2326         Rename from dwarf2_section_buffer_overflow_complaint.
2327         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2328         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2329
2330 2020-03-26  Tom Tromey  <tom@tromey.com>
2331
2332         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2333         Declare.
2334         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2335         Move from read.c.
2336         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2337         to section.c.
2338
2339 2020-03-26  Tom Tromey  <tom@tromey.com>
2340
2341         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2342
2343 2020-03-26  Tom Tromey  <tom@tromey.com>
2344
2345         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2346         "builder".
2347         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2348         parameter.
2349         (dwarf_decode_macros): Update.
2350
2351 2020-03-26  Tom Tromey  <tom@tromey.com>
2352
2353         * dwarf2/read.c (read_attribute_value): Update.
2354         (read_indirect_string_from_dwz): Move to dwz.c; change into
2355         method.
2356         (dwarf_decode_macro_bytes): Update.
2357         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
2358         * dwarf2/dwz.c: New file.
2359         * Makefile.in (COMMON_SFILES): Add dwz.c.
2360
2361 2020-03-26  Tom Tromey  <tom@tromey.com>
2362
2363         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
2364         * dwarf2/read.c: Add include.
2365         * dwarf2/index-write.c: Add include.
2366         * dwarf2/index-cache.c: Add include.
2367         * dwarf2/dwz.h: New file.
2368
2369 2020-03-25  Tom Tromey  <tom@tromey.com>
2370
2371         * compile/compile-object-load.c (get_out_value_type): Mention
2372         correct symbol name in error message.
2373
2374 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
2375
2376         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2377
2378 2020-03-25  Tom de Vries  <tdevries@suse.de>
2379
2380         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
2381         * symmisc.c (dump_symtab_1): Print user and includes fields.
2382         (maintenance_info_symtabs): Same.
2383
2384 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2385
2386         PR gdb/25534
2387         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
2388         (riscv_regcache_cooked_write): New function.
2389         (riscv_push_dummy_call): Use new function.
2390         (riscv_return_value): Likewise.
2391
2392 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
2393
2394         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
2395         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
2396         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
2397         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
2398         * infrun.c (follow_fork): Likewise.
2399         (follow_fork_inferior): Likewise.
2400         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
2401         * linux-nat.h (class linux_nat_target): Likewise.
2402         * remote.c (class remote_target) <follow_fork>: Likewise.
2403         (remote_target::follow_fork): Likewise.
2404         * target-delegates.c: Re-generate.
2405         * target.c (default_follow_fork): Likewise.
2406         (target_follow_fork): Likewise.
2407         * target.h (struct target_ops) <follow_fork>: Likewise.
2408         (target_follow_fork): Likewise.
2409
2410 2020-03-24  Tom de Vries  <tdevries@suse.de>
2411
2412         * psymtab.c (maintenance_info_psymtabs): Print user field.
2413
2414 2020-03-20  Tom Tromey  <tromey@adacore.com>
2415
2416         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
2417         const.
2418         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
2419         const.
2420
2421 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
2422
2423         * ptrace.m4: Don't check for ptrace declaration.
2424         * config.in: Re-generate.
2425         * configure: Re-generate.
2426         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
2427         not defined.
2428
2429 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2430
2431         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
2432         `PTRACE_TYPE_RET'.
2433         * i386-bsd-nat.c (gdb_ptrace): Likewise.
2434         * sparc-nat.c (gdb_ptrace): Likewise.
2435         * x86-bsd-nat.c (gdb_ptrace): Likewise.
2436
2437 2020-03-20  Tom Tromey  <tromey@adacore.com>
2438
2439         * c-exp.y (lex_one_token): Fix assert.
2440
2441 2020-03-20  Tom Tromey  <tromey@adacore.com>
2442
2443         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
2444         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
2445         strncpy call.
2446
2447 2020-03-20  Tom Tromey  <tromey@adacore.com>
2448
2449         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
2450
2451 2020-03-20  Tom Tromey  <tromey@adacore.com>
2452
2453         * ada-valprint.c (print_variant_part): Remove parameters; switch
2454         to value-based API.
2455         (print_field_values): Likewise.
2456         (ada_val_print_struct_union): Likewise.
2457         (ada_value_print_1): Update.
2458
2459 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2460
2461         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
2462         nbsd_nat_target instead of inf_ptrace_target.
2463         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2464         nbsd_nat_target.
2465
2466 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2467
2468         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
2469         it to the ptrace call.
2470         * (store_registers): Likewise.
2471
2472 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2473
2474         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
2475         it to the ptrace call.
2476         * (store_registers): Likewise.
2477
2478 2020-03-19  Luis Machado  <luis.machado@linaro.org>
2479
2480         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
2481         valid, fetch vg value from ptrace.
2482
2483 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2484         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
2485         * inf-ptrace.c: Likewise.
2486         * (gdb_ptrace): Add.
2487         * (inf_ptrace_target::resume): Update.
2488         * (inf_ptrace_target::xfer_partial): Likewise.
2489         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2490         * (inf_ptrace_peek_poke): Update.
2491
2492 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2493
2494         * x86-bsd-nat.c (gdb_ptrace): New.
2495         * (x86bsd_dr_set): Add new argument `ptid'.
2496         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2497         x86bsd_dr_set_addr): Update.
2498
2499 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2500
2501         * remote.c (remote_target::process_stop_reply): Handle events for
2502         all threads differently.
2503
2504 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2505
2506         * completer.c (completion_tracker::remove_completion): Define new
2507         function.
2508         * completer.h (completion_tracker::remove_completion): Declare new
2509         function.
2510         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2511         when adding a C++ function symbol.
2512
2513 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2514
2515         * completer.c (completion_tracker::completion_hash_entry): Define
2516         new class.
2517         (advance_to_filename_complete_word_point): Call
2518         recompute_lowest_common_denominator.
2519         (completion_tracker::completion_tracker): Call discard_completions
2520         to setup the hash table.
2521         (completion_tracker::discard_completions): Allow for being called
2522         from the constructor, pass new equal function, and element deleter
2523         when constructing the hash table.  Initialise new class member
2524         variables.
2525         (completion_tracker::maybe_add_completion): Remove use of
2526         m_entries_vec, and store more information into m_entries_hash.
2527         (completion_tracker::recompute_lcd_visitor): New function, most
2528         content taken from...
2529         (completion_tracker::recompute_lowest_common_denominator):
2530         ...here, this now just visits each item in the hash calling the
2531         above visitor.
2532         (completion_tracker::build_completion_result): Remove use of
2533         m_entries_vec, call recompute_lowest_common_denominator.
2534         * completer.h (completion_tracker::have_completions): Remove use
2535         of m_entries_vec.
2536         (completion_tracker::completion_hash_entry): Declare new class.
2537         (completion_tracker::recompute_lowest_common_denominator): Change
2538         function signature.
2539         (completion_tracker::recompute_lcd_visitor): Declare new function.
2540         (completion_tracker::m_entries_vec): Delete.
2541         (completion_tracker::m_entries_hash): Initialize to NULL.
2542         (completion_tracker::m_lowest_common_denominator_valid): New
2543         member variable.
2544         (completion_tracker::m_lowest_common_denominator_max_length): New
2545         member variable.
2546
2547 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2548
2549         * regformats/regdef.h: Put reg in gdb namespace.
2550
2551 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2552
2553         * i386-bsd-nat.c (gdb_ptrace): New.
2554         * (i386bsd_fetch_inferior_registers,
2555         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2556         * (i386bsd_fetch_inferior_registers,
2557         i386bsd_store_inferior_registers) Use gdb_ptrace.
2558
2559 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2560
2561         * amd64-bsd-nat.c (gdb_ptrace): New.
2562         * (amd64bsd_fetch_inferior_registers,
2563         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2564         * (amd64bsd_fetch_inferior_registers,
2565         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2566
2567 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2568
2569         * user-regs.c (user_reg::read): Rename to...
2570         (user_reg::xread): ...this.
2571         * (append_user_reg): Rename argument `read' to `xread'.
2572         * (user_reg_add_builtin): Likewise.
2573         * (user_reg_add): Likewise.
2574         * (value_of_user_reg): Likewise.
2575
2576 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2577
2578         * sparc-nat.c (gdb_ptrace): New.
2579         * sparc-nat.c (sparc_fetch_inferior_registers)
2580         (sparc_store_inferior_registers) Remove obsolete comment.
2581         * sparc-nat.c (sparc_fetch_inferior_registers)
2582         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2583         * sparc-nat.c (sparc_fetch_inferior_registers)
2584         (sparc_store_inferior_registers) Use gdb_ptrace.
2585
2586 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2587
2588         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2589         it to the ptrace call.
2590         * sh-nbsd-nat.c (store_registers): Likewise.
2591
2592 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2593
2594         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2595         nbsd_nat_target instead of inf_ptrace_target.
2596         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2597         nbsd_nat_target.
2598
2599 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2600
2601         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2602
2603 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2604
2605         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2606         <sys/sysctl.h>.
2607         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2608
2609 2020-03-17  Tom de Vries  <tdevries@suse.de>
2610
2611         PR gdb/23710
2612         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2613         fields.
2614         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2615         fields.
2616         (process_imported_unit_die): Skip import of c++ CUs.
2617
2618 2020-03-16  Tom Tromey  <tom@tromey.com>
2619
2620         * p-valprint.c (pascal_object_print_value): Initialize
2621         base_value.
2622
2623 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2624             Shahab Vahedi  <shahab@synopsys.com>
2625
2626         * Makefile.in: Add arch/arc.o
2627         * configure.tgt: Likewise.
2628         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2629         (_initialize_arc_tdep): Don't initialize old target descriptions.
2630         (arc_read_description): New function to cache target descriptions.
2631         * arc-tdep.h (arc_read_description): Add proto type.
2632         * arch/arc.c: New file.
2633         * arch/arc.h: Likewise.
2634         * features/Makefile: Replace old target descriptions with new.
2635         * features/arc-arcompact.c: Remove.
2636         * features/arc-arcompact.xml: Likewise.
2637         * features/arc-v2.c: Likewise
2638         * features/arc-v2.xml: Likewise
2639         * features/arc/aux-arcompact.xml: New file.
2640         * features/arc/aux-v2.xml: Likewise.
2641         * features/arc/core-arcompact.xml: Likewise.
2642         * features/arc/core-v2.xml: Likewise.
2643         * features/arc/aux-arcompact.c: Generate.
2644         * features/arc/aux-v2.c: Likewise.
2645         * features/arc/core-arcompact.c: Likewise.
2646         * features/arc/core-v2.c: Likewise.
2647         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2648
2649 2020-03-16  Tom Tromey  <tromey@adacore.com>
2650
2651         PR gdb/25663:
2652         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2653         putting value into bcache.
2654
2655 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2656
2657         PR gdb/21500
2658         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2659         to...
2660         (amd64_windows_init_abi_common): ... this.  Don't set size of
2661         long type.
2662         (amd64_windows_init_abi): New function.
2663         (amd64_cygwin_init_abi): New function.
2664         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2665         the Cygwin OS ABI.
2666         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2667         comment.
2668
2669 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2670
2671         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2672         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2673         (pe_import_directory_entry): New struct type.
2674         (is_linked_with_cygwin_dll): New function.
2675         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2676         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2677         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2678
2679 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2680
2681         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2682         i386_cygwin_core_osabi_sniffer.
2683
2684 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2685
2686         * i386-cygwin-tdep.c: Rename to...
2687         * i386-windows-tdep.c: ... this.
2688         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2689         i386-windows-tdep.c.
2690         * configure.tgt: Likewise.
2691
2692 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2693
2694         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2695         * osabi.c (gdb_osabi_names): Add "Windows".
2696         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2697         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2698         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2699         i386_cygwin_osabi_sniffer.
2700         (_initialize_i386_cygwin_tdep): Register OS ABI
2701         GDB_OSABI_WINDOWS for i386.
2702         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2703         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2704         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2705         for x86-64.
2706         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2707         when the target matches '*-*-mingw*'.
2708
2709 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2710
2711         * defs.h (enum gdb_osabi): Move to...
2712         * osabi.h (enum gdb_osabi): ... here.
2713         * gdbarch.sh: Include osabi.h in gdbarch.h.
2714         * gdbarch.h: Re-generate.
2715
2716 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2717
2718         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2719         function.
2720         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2721
2722 2020-03-14  Tom Tromey  <tom@tromey.com>
2723
2724         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2725         for C++.
2726         (c_type_print_modifier): Likewise.  Add "language" parameter.
2727         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2728         (c_type_print_base_1): Update.
2729         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2730         constants.
2731         * type-stack.c (type_stack::insert): Handle tp_atomic and
2732         tp_restrict.
2733         (type_stack::follow_type_instance_flags): Likewise.
2734         (type_stack::follow_types): Likewise.  Merge type-following code.
2735         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2736         (space_identifier, cv_with_space_id)
2737         (const_or_volatile_or_space_identifier_noopt)
2738         (const_or_volatile_or_space_identifier): Remove.
2739         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2740         rules.
2741         (ptr_operator, typebase): Update.
2742         (enum token_flag) <FLAG_C>: New constant.
2743         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2744         "_Atomic".
2745         (lex_one_token): Handle FLAG_C.
2746
2747 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2748
2749         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2750         it to the ptrace call.
2751         * m68k-bsd-nat.c (store_registers): Likewise.
2752
2753 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2754
2755         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
2756         gdb_byte *.
2757         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
2758         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
2759         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
2760
2761 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2762
2763         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
2764         nbsd_nat_target instead of inf_ptrace_target.
2765         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2766         nbsd_nat_target.
2767
2768 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2769
2770         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
2771         register_t.
2772
2773 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2774
2775         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
2776         it to the ptrace call.
2777         * alpha-bsd-nat.c (store_registers): Likewise.
2778
2779 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2780
2781         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
2782         includes.
2783         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
2784         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
2785         fill_fpregset): Likewise.
2786
2787 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2788
2789         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
2790         nbsd_nat_target instead of inf_ptrace_target.
2791         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2792         nbsd_nat_target.
2793
2794 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2795
2796         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
2797         register_t.
2798
2799 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2800
2801         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
2802         it to the ptrace call.
2803         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
2804         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
2805         * arm-nbsd-nat.c (store_register): Likewise.
2806         * arm-nbsd-nat.c (store_regs): Likewise.
2807         * arm-nbsd-nat.c (store_fp_register): Likewise.
2808         * arm-nbsd-nat.c (store_fp_regs): Likewise.
2809
2810 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2811
2812         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
2813         nbsd_nat_target instead of inf_ptrace_target.
2814         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2815         nbsd_nat_target.
2816
2817 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2818
2819         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
2820         it to the ptrace call.
2821         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
2822
2823 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2824
2825         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
2826         it to the ptrace call.
2827         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
2828
2829 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2830
2831         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
2832         gdb_byte *.
2833         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
2834
2835 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2836
2837         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2838         instead of inf_ptrace_target.
2839         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2840         nbsd_nat_target.
2841
2842 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2843
2844         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2845         register_t.
2846
2847 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2848
2849         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2850         register_t.
2851
2852 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2853
2854         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2855         register_t.
2856
2857 2020-03-13  Tom Tromey  <tom@tromey.com>
2858
2859         * value.h (val_print): Don't declare.
2860         * valprint.h (val_print_array_elements)
2861         (val_print_scalar_formatted, generic_val_print): Don't declare.
2862         * valprint.c (generic_val_print_array): Take a struct value.
2863         (generic_val_print_ptr, generic_val_print_memberptr)
2864         (generic_val_print_bool, generic_val_print_int)
2865         (generic_val_print_char, generic_val_print_complex)
2866         (generic_val_print): Remove.
2867         (generic_value_print): Update.
2868         (do_val_print): Remove unused parameters.  Don't call
2869         la_val_print.
2870         (val_print): Remove.
2871         (common_val_print): Update.  Don't call value_check_printable.
2872         (val_print_scalar_formatted, val_print_array_elements): Remove.
2873         * rust-lang.c (rust_val_print): Remove.
2874         (rust_language_defn): Update.
2875         * p-valprint.c (pascal_val_print): Remove.
2876         (pascal_value_print_inner): Update.
2877         (pascal_object_print_val_fields, pascal_object_print_val):
2878         Remove.
2879         (pascal_object_print_static_field): Update.
2880         * p-lang.h (pascal_val_print): Don't declare.
2881         * p-lang.c (pascal_language_defn): Update.
2882         * opencl-lang.c (opencl_language_defn): Update.
2883         * objc-lang.c (objc_language_defn): Update.
2884         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2885         * m2-lang.h (m2_val_print): Don't declare.
2886         * m2-lang.c (m2_language_defn): Update.
2887         * language.h (struct language_defn) <la_val_print>: Remove.
2888         * language.c (unk_lang_value_print_inner): Rename.  Change
2889         argument types.
2890         (unknown_language_defn, auto_language_defn): Update.
2891         * go-valprint.c (go_val_print): Remove.
2892         * go-lang.h (go_val_print): Don't declare.
2893         * go-lang.c (go_language_defn): Update.
2894         * f-valprint.c (f_val_print): Remove.
2895         * f-lang.h (f_value_print): Don't declare.
2896         * f-lang.c (f_language_defn): Update.
2897         * d-valprint.c (d_val_print): Remove.
2898         * d-lang.h (d_value_print): Don't declare.
2899         * d-lang.c (d_language_defn): Update.
2900         * cp-valprint.c (cp_print_value_fields)
2901         (cp_print_value_fields_rtti, cp_print_value): Remove.
2902         (cp_print_static_field): Update.
2903         * c-valprint.c (c_val_print_array, c_val_print_ptr)
2904         (c_val_print_struct, c_val_print_union, c_val_print_int)
2905         (c_val_print_memberptr, c_val_print): Remove.
2906         * c-lang.h (c_val_print_array, cp_print_value_fields)
2907         (cp_print_value_fields_rtti): Don't declare.
2908         * c-lang.c (c_language_defn, cplus_language_defn)
2909         (asm_language_defn, minimal_language_defn): Update.
2910         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
2911         (ada_val_print_enum): Take a struct value.
2912         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
2913         (ada_val_print): Remove.
2914         (ada_value_print_1): Update.
2915         (printable_val_type): Remove.
2916         * ada-lang.h (ada_val_print): Don't declare.
2917         * ada-lang.c (ada_language_defn): Update.
2918
2919 2020-03-13  Tom Tromey  <tom@tromey.com>
2920
2921         * valprint.c (do_val_print): Update.
2922         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
2923         a struct value.
2924         (value_to_value_object_no_release): Declare.
2925         * python/py-value.c (value_to_value_object_no_release): New
2926         function.
2927         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
2928         struct value.
2929         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
2930         function.
2931         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
2932         a struct value.
2933         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
2934         Declare.
2935         (gdbscm_apply_val_pretty_printer): Take a struct value.
2936         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
2937         value.
2938         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
2939         value.
2940         * extension-priv.h (struct extension_language_ops)
2941         <apply_val_pretty_printer>: Take a struct value.
2942         * cp-valprint.c (cp_print_value): Create a struct value.
2943         (cp_print_value): Update.
2944
2945 2020-03-13  Tom Tromey  <tom@tromey.com>
2946
2947         * ada-valprint.c (print_field_values): Call common_val_print.
2948
2949 2020-03-13  Tom Tromey  <tom@tromey.com>
2950
2951         * ada-valprint.c (val_print_packed_array_elements): Remove
2952         bitoffset and val parameters.  Call common_val_print.
2953         (ada_val_print_string): Remove offset, address, and original_value
2954         parameters.
2955         (ada_val_print_array): Update.
2956         (ada_value_print_array): New function.
2957         (ada_value_print_1): Call it.
2958
2959 2020-03-13  Tom Tromey  <tom@tromey.com>
2960
2961         * ada-valprint.c (ada_value_print): Use common_val_print.
2962
2963 2020-03-13  Tom Tromey  <tom@tromey.com>
2964
2965         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
2966
2967 2020-03-13  Tom Tromey  <tom@tromey.com>
2968
2969         * ada-valprint.c (ada_value_print_num): New function.
2970         (ada_value_print_1): Use it.
2971
2972 2020-03-13  Tom Tromey  <tom@tromey.com>
2973
2974         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
2975
2976 2020-03-13  Tom Tromey  <tom@tromey.com>
2977
2978         * ada-valprint.c (ada_value_print_ptr): New function.
2979         (ada_value_print_1): Use it.
2980
2981 2020-03-13  Tom Tromey  <tom@tromey.com>
2982
2983         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
2984         call common_val_print.
2985         (ada_val_print_1): Update.
2986         (ada_value_print_1): New function.
2987         (ada_value_print_inner): Rewrite.
2988
2989 2020-03-13  Tom Tromey  <tom@tromey.com>
2990
2991         * cp-valprint.c (cp_print_value_fields): Update.
2992         (cp_print_value): New function.
2993
2994 2020-03-13  Tom Tromey  <tom@tromey.com>
2995
2996         * m2-valprint.c (m2_value_print_inner): Use
2997         cp_print_value_fields.
2998         * cp-valprint.c (cp_print_value_fields): New function.
2999         * c-valprint.c (c_value_print_struct): New function.
3000         (c_value_print_inner): Use c_value_print_struct.
3001         * c-lang.h (cp_print_value_fields): Declare.
3002
3003 2020-03-13  Tom Tromey  <tom@tromey.com>
3004
3005         * c-valprint.c (c_value_print_array): New function.
3006         (c_value_print_inner): Use it.
3007
3008 2020-03-13  Tom Tromey  <tom@tromey.com>
3009
3010         * c-valprint.c (c_value_print_memberptr): New function.
3011         (c_value_print_inner): Use it.
3012
3013 2020-03-13  Tom Tromey  <tom@tromey.com>
3014
3015         * c-valprint.c (c_value_print_int): New function.
3016         (c_value_print_inner): Use it.
3017
3018 2020-03-13  Tom Tromey  <tom@tromey.com>
3019
3020         * c-valprint.c (c_value_print_ptr): New function.
3021         (c_value_print_inner): Use it.
3022
3023 2020-03-13  Tom Tromey  <tom@tromey.com>
3024
3025         * c-valprint.c (c_value_print_inner): Rewrite.
3026
3027 2020-03-13  Tom Tromey  <tom@tromey.com>
3028
3029         * valprint.c (generic_value_print_complex): New function.
3030         (generic_value_print): Use it.
3031
3032 2020-03-13  Tom Tromey  <tom@tromey.com>
3033
3034         * valprint.c (generic_val_print_float): Don't call
3035         val_print_scalar_formatted.
3036         (generic_val_print, generic_value_print): Update.
3037
3038 2020-03-13  Tom Tromey  <tom@tromey.com>
3039
3040         * valprint.c (generic_value_print_char): New function
3041         (generic_value_print): Use it.
3042
3043 2020-03-13  Tom Tromey  <tom@tromey.com>
3044
3045         * valprint.c (generic_value_print_int): New function.
3046         (generic_value_print): Use it.
3047
3048 2020-03-13  Tom Tromey  <tom@tromey.com>
3049
3050         * valprint.c (generic_value_print_bool): New function.
3051         (generic_value_print): Use it.
3052
3053 2020-03-13  Tom Tromey  <tom@tromey.com>
3054
3055         * valprint.c (generic_val_print_func): Simplify.
3056         (generic_val_print, generic_value_print): Update.
3057
3058 2020-03-13  Tom Tromey  <tom@tromey.com>
3059
3060         * valprint.c (generic_val_print_flags): Remove.
3061         (generic_val_print, generic_value_print): Update.
3062         (val_print_type_code_flags): Add original_value parameter.
3063
3064 2020-03-13  Tom Tromey  <tom@tromey.com>
3065
3066         * valprint.c (generic_val_print): Update.
3067         (generic_value_print): Update.
3068         * valprint.c (generic_val_print_enum): Don't call
3069         val_print_scalar_formatted.
3070
3071 2020-03-13  Tom Tromey  <tom@tromey.com>
3072
3073         * valprint.c (generic_value_print): Call generic_value_print_ptr.
3074         * valprint.c (generic_value_print_ptr): New function.
3075
3076 2020-03-13  Tom Tromey  <tom@tromey.com>
3077
3078         * valprint.c (generic_value_print): Rewrite.
3079
3080 2020-03-13  Tom Tromey  <tom@tromey.com>
3081
3082         * p-valprint.c (pascal_object_print_value_fields)
3083         (pascal_object_print_value): New functions.
3084
3085 2020-03-13  Tom Tromey  <tom@tromey.com>
3086
3087         * p-valprint.c (pascal_value_print_inner): Rewrite.
3088
3089 2020-03-13  Tom Tromey  <tom@tromey.com>
3090
3091         * f-valprint.c (f_value_print_innner): Rewrite.
3092
3093 2020-03-13  Tom Tromey  <tom@tromey.com>
3094
3095         * m2-valprint.c (m2_print_unbounded_array): New overload.
3096         (m2_print_unbounded_array): Update.
3097         (m2_print_array_contents): Take a struct value.
3098         (m2_value_print_inner): Rewrite.
3099
3100 2020-03-13  Tom Tromey  <tom@tromey.com>
3101
3102         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
3103         (d_value_print_inner): New function.
3104         * d-lang.h (d_value_print_inner): Declare.
3105         * d-lang.c (d_language_defn): Use d_value_print_inner.
3106
3107 2020-03-13  Tom Tromey  <tom@tromey.com>
3108
3109         * go-valprint.c (go_value_print_inner): New function.
3110         * go-lang.h (go_value_print_inner): Declare.
3111         * go-lang.c (go_language_defn): Use go_value_print_inner.
3112
3113 2020-03-13  Tom Tromey  <tom@tromey.com>
3114
3115         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
3116         API.
3117         (rust_val_print): Rewrite.
3118         (rust_value_print_inner): New function, from rust_val_print.
3119         (rust_language_defn): Use rust_value_print_inner.
3120
3121 2020-03-13  Tom Tromey  <tom@tromey.com>
3122
3123         * ada-valprint.c (ada_value_print_inner): New function.
3124         * ada-lang.h (ada_value_print_inner): Declare.
3125         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
3126
3127 2020-03-13  Tom Tromey  <tom@tromey.com>
3128
3129         * f-valprint.c (f_value_print_innner): New function.
3130         * f-lang.h (f_value_print_innner): Declare.
3131         * f-lang.c (f_language_defn): Use f_value_print_innner.
3132
3133 2020-03-13  Tom Tromey  <tom@tromey.com>
3134
3135         * p-valprint.c (pascal_value_print_inner): New function.
3136         * p-lang.h (pascal_value_print_inner): Declare.
3137         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
3138
3139 2020-03-13  Tom Tromey  <tom@tromey.com>
3140
3141         * m2-valprint.c (m2_value_print_inner): New function.
3142         * m2-lang.h (m2_value_print_inner): Declare.
3143         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
3144
3145 2020-03-13  Tom Tromey  <tom@tromey.com>
3146
3147         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
3148         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
3149         * c-valprint.c (c_value_print_inner): New function.
3150         * c-lang.h (c_value_print_inner): Declare.
3151         * c-lang.c (c_language_defn, cplus_language_defn)
3152         (asm_language_defn, minimal_language_defn): Use
3153         c_value_print_inner.
3154
3155 2020-03-13  Tom Tromey  <tom@tromey.com>
3156
3157         * p-valprint.c (pascal_object_print_value_fields): Now static.
3158         * p-lang.h (pascal_object_print_value_fields): Don't declare.
3159
3160 2020-03-13  Tom Tromey  <tom@tromey.com>
3161
3162         * c-valprint.c (c_val_print_array): Simplify.
3163
3164 2020-03-13  Tom Tromey  <tom@tromey.com>
3165
3166         * valprint.c (value_print_array_elements): New function.
3167         * valprint.h (value_print_array_elements): Declare.
3168
3169 2020-03-13  Tom Tromey  <tom@tromey.com>
3170
3171         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
3172         * mips-tdep.c (mips_print_register): Use
3173         value_print_scalar_formatted.
3174
3175 2020-03-13  Tom Tromey  <tom@tromey.com>
3176
3177         * valprint.h (value_print_scalar_formatted): Declare.
3178         * valprint.c (value_print_scalar_formatted): New function.
3179
3180 2020-03-13  Tom Tromey  <tom@tromey.com>
3181
3182         * valprint.h (generic_value_print): Declare.
3183         * valprint.c (generic_value_print): New function.
3184
3185 2020-03-13  Tom Tromey  <tom@tromey.com>
3186
3187         * valprint.c (do_val_print): Call la_value_print_inner, if
3188         available.
3189         * rust-lang.c (rust_language_defn): Update.
3190         * p-lang.c (pascal_language_defn): Update.
3191         * opencl-lang.c (opencl_language_defn): Update.
3192         * objc-lang.c (objc_language_defn): Update.
3193         * m2-lang.c (m2_language_defn): Update.
3194         * language.h (struct language_defn) <la_value_print_inner>: New
3195         member.
3196         * language.c (unknown_language_defn, auto_language_defn): Update.
3197         * go-lang.c (go_language_defn): Update.
3198         * f-lang.c (f_language_defn): Update.
3199         * d-lang.c (d_language_defn): Update.
3200         * c-lang.c (c_language_defn, cplus_language_defn)
3201         (asm_language_defn, minimal_language_defn): Update.
3202         * ada-lang.c (ada_language_defn): Update.
3203
3204 2020-03-13  Tom Tromey  <tom@tromey.com>
3205
3206         * c-valprint.c (c_value_print): Use common_val_print.
3207
3208 2020-03-13  Tom Tromey  <tom@tromey.com>
3209
3210         * cp-valprint.c (cp_print_static_field): Use common_val_print.
3211
3212 2020-03-13  Tom Tromey  <tom@tromey.com>
3213
3214         * f-valprint.c (f77_print_array_1, f_val_print): Use
3215         common_val_print.
3216
3217 2020-03-13  Tom Tromey  <tom@tromey.com>
3218
3219         * riscv-tdep.c (riscv_print_one_register_info): Use
3220         common_val_print.
3221
3222 2020-03-13  Tom Tromey  <tom@tromey.com>
3223
3224         * mi/mi-main.c (output_register): Use common_val_print.
3225
3226 2020-03-13  Tom Tromey  <tom@tromey.com>
3227
3228         * infcmd.c (default_print_one_register_info): Use
3229         common_val_print.
3230
3231 2020-03-13  Tom Tromey  <tom@tromey.com>
3232
3233         * valprint.h (common_val_print_checked): Declare.
3234         * valprint.c (common_val_print_checked): New function.
3235         * stack.c (print_frame_arg): Use common_val_print_checked.
3236
3237 2020-03-13  Tom Tromey  <tom@tromey.com>
3238
3239         * valprint.c (do_val_print): New function, from val_print.
3240         (val_print): Use do_val_print.
3241         (common_val_print): Use do_val_print.
3242
3243 2020-03-13  Tom Tromey  <tom@tromey.com>
3244
3245         * valprint.c (value_print): Use scoped_value_mark.
3246
3247 2020-03-13  Tom de Vries  <tdevries@suse.de>
3248
3249         PR symtab/25646
3250         * psymtab.c (partial_symtab::partial_symtab): Don't set
3251         globals_offset and statics_offset.  Push element onto
3252         current_global_psymbols and current_static_psymbols stacks.
3253         (concat): New function.
3254         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
3255         element from current_global_psymbols and current_static_psymbols
3256         stacks.  Concat popped elements to global_psymbols and
3257         static_symbols.
3258         (add_psymbol_to_list): Use current_global_psymbols and
3259         current_static_psymbols stacks.
3260         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
3261         current_static_psymbols fields.
3262
3263 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3264
3265         * corelow.c (sniff_core_bfd): Remove.
3266         (class core_target) <m_core_vec>: Remove.
3267         (core_target::core_target): Update.
3268         (core_file_fns): Remove.
3269         (deprecated_add_core_fns): Remove.
3270         (default_core_sniffer): Remove.
3271         (sniff_core_bfd): Remove.
3272         (default_check_format): Remove.
3273         (gdb_check_format): Remove.
3274         (core_target_open): Update.
3275         (core_target::get_core_register_section): Update.
3276         (get_core_registers_cb): Update.
3277         (core_target::fetch_registers): Update.
3278         * gdbcore.h (struct core_fns): Remove.
3279         (deprecated_add_core_fns): Remove.
3280         (default_core_sniffer): Remove.
3281         (default_check_format): Remove.
3282
3283 2020-03-12  Tom Tromey  <tom@tromey.com>
3284
3285         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
3286         CORE_ADDR.
3287         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
3288
3289 2020-03-12  Tom Tromey  <tom@tromey.com>
3290
3291         * remote.c (remote_target::download_tracepoint)
3292         (remote_target::enable_tracepoint)
3293         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
3294         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
3295         sprintf_vma.
3296
3297 2020-03-12  Tom Tromey  <tom@tromey.com>
3298
3299         * symfile-mem.c: Update CORE_ADDR size assert.
3300
3301 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3302
3303         * selftest.m4: Move to gdbsupport/.
3304         * acinclude.m4: Update path to selftest.m4.
3305
3306 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3307
3308         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
3309         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3310         gdbarch-selfselftests.c and selftest-arch.c.
3311         (SUBDIR_UNITTESTS_OBS): Rename to...
3312         (SELFTESTS_OBS): ... this.
3313         (COMMON_SFILES): Remove disasm-selftests.c and
3314         gdbarch-selftests.c.
3315         * configure.ac: Don't add selftest-arch.{c,o} to
3316         CONFIG_{SRCS,OBS}.
3317         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3318         preprocessor conditions.
3319
3320 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3321
3322         * configure.ac: Don't source bfd/development.sh.
3323         * selftest.m4: Modify comment.
3324         * configure: Re-generate.
3325
3326 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3327
3328         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3329         not "true" or "false".
3330         * configure: Re-generate.
3331
3332 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3333
3334         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3335         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3336         renamed to arm_nbsd_supply_gregset.
3337         (fetch_register): Update to call arm_nbsd_supply_gregset.
3338         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3339         (arm_netbsd_nat_target::fetch_registers): Update.
3340         (fetch_elfcore_registers): Removed.
3341         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3342         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3343         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3344         not require NetBSD system headers.
3345         (arm_nbsd_regset): New struct.
3346         (arm_nbsd_iterate_over_regset_sections): New function.
3347         (arm_netbsd_init_abi_common): Updated to call
3348         set_gdbarch_iterate_over_regset_sections.
3349         * arm-nbsd-tdep.h: New file.
3350
3351 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3352
3353         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3354         recursion.
3355
3356 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
3357
3358         * configure: Re-generate.
3359
3360 2020-03-11  Tom Tromey  <tromey@adacore.com>
3361
3362         * ada-typeprint.c (print_choices): Fix comment.
3363
3364 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3365
3366         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
3367         previous item in the list, when the list has no items.
3368
3369 2020-03-11  Tom de Vries  <tdevries@suse.de>
3370
3371         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
3372         PROP_LOCLIST handling code.
3373
3374 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3375
3376         * buildsym-legacy.c (record_line): Pass extra parameter to
3377         record_line.
3378         * buildsym.c (buildsym_compunit::record_line): Take an extra
3379         parameter, reduce duplication in the line table, and record the
3380         is_stmt flag in the line table.
3381         * buildsym.h (buildsym_compunit::record_line): Add extra
3382         parameter.
3383         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
3384         non-statement lines.
3385         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
3386         this to the symtab builder.
3387         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
3388         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
3389         through to dwarf_record_line_1.
3390         * infrun.c (process_event_stop_test): When stepping, don't stop at
3391         a non-statement instruction, and only refresh the step info when
3392         we land in the middle of a line's range.  Also add an extra
3393         comment.
3394         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
3395         field.
3396         * record-btrace.c (btrace_find_line_range): Only record lines
3397         marked as is-statement.
3398         * stack.c (frame_show_address): Show the frame address if we are
3399         in a non-statement sal.
3400         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
3401         (maintenance_print_one_line_table): Print a header for the is_stmt
3402         column, and include is_stmt information in the output.
3403         * symtab.c (find_pc_sect_line): Find lines marked as statements in
3404         preference to non-statements.
3405         (find_pcs_for_symtab_line): Prefer is-statement entries.
3406         (find_line_common): Likewise.
3407         * symtab.h (struct linetable_entry): Add is_stmt field.
3408         (struct symtab_and_line): Likewise.
3409         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
3410         arranging the line table.
3411
3412 2020-03-07  Tom de Vries  <tdevries@suse.de>
3413
3414         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
3415         DIE.
3416
3417 2020-03-07  Tom Tromey  <tom@tromey.com>
3418
3419         * valops.c (value_literal_complex): Remove obsolete comment.
3420         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
3421         comment.
3422
3423 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3424
3425         * infrun.h: Forward-declare thread_info.
3426         (set_step_info): Add thread_info parameter, add doc.
3427         * infrun.c (set_step_info): Add thread_info parameter, move doc
3428         to header.
3429         * infrun.c (process_event_stop_test): Pass thread to
3430         set_step_info call.
3431         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
3432         set_step_info.
3433         (prepare_one_step): Add thread_info parameter, pass it to
3434         set_step_frame and prepare_one_step (recursive) call.
3435         (step_1): Pass thread to prepare_one_step call.
3436         (step_command_fsm::should_stop): Pass thread to
3437         prepare_one_step.
3438         (until_next_fsm): Pass thread to set_step_frame call.
3439         (finish_command): Pass thread to set_step_info call.
3440
3441 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
3442
3443         * windows-tdep.c (windows_solib_create_inferior_hook):
3444         Check if inferior is running.
3445
3446 2020-03-06  Tom de Vries  <tdevries@suse.de>
3447
3448         * NEWS: Fix "the the".
3449         * ctfread.c: Same.
3450
3451 2020-03-06  Tom de Vries  <tdevries@suse.de>
3452
3453         * psymtab.c (psymtab_to_symtab): Don't print "done.".
3454
3455 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3456
3457         * .dir-locals.el: Add a comment referencing the other copies of
3458         this file.
3459
3460 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
3461
3462         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
3463         psargs.
3464
3465 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3466
3467         * .gitattributes: New file.
3468
3469 2020-03-04  Tom Tromey  <tom@tromey.com>
3470
3471         * symmisc.c (print_symbol_bcache_statistics)
3472         (print_objfile_statistics): Update.
3473         * symfile.c (allocate_symtab): Use intern.
3474         * psymtab.c (partial_symtab::partial_symtab): Use intern.
3475         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3476         macro_cache>: Remove.
3477         <string_cache>: New member.
3478         (struct objfile) <intern>: New methods.
3479         * elfread.c (elf_symtab_read): Use intern.
3480         * dwarf2/read.c (fixup_go_packaging): Intern package name.
3481         (dwarf2_compute_name, dwarf2_physname)
3482         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
3483         names.
3484         (guess_partial_die_structure_name): Update.
3485         (partial_die_info::fixup): Intern name.
3486         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3487         name.
3488         (dwarf2_name): Intern name.  Update.
3489         * buildsym.c (buildsym_compunit::get_macro_table): Use
3490         string_cache.
3491
3492 2020-03-04  Tom Tromey  <tom@tromey.com>
3493
3494         * jit.c (bfd_open_from_target_memory): Make "target" const.
3495         * corefile.c (gnutarget): Now const.
3496         * gdbcore.h (gnutarget): Now const.
3497
3498 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3499
3500         * NEWS: Mention support for WOW64 processes.
3501         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3502         (amd64_windows_segment_register_p): Remove static.
3503         (_initialize_amd64_windows_nat): Update.
3504         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3505         * i386-windows-nat.c (context_offset): Update.
3506         (i386_mappings): Rename and remove static.
3507         (i386_windows_segment_register_p): Remove static.
3508         (_initialize_i386_windows_nat): Update.
3509         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3510         (STATUS_WX86_SINGLE_STEP): New macro.
3511         (EnumProcessModulesEx): New macro.
3512         (Wow64SuspendThread): New macro.
3513         (Wow64GetThreadContext): New macro.
3514         (Wow64SetThreadContext): New macro.
3515         (Wow64GetThreadSelectorEntry): New macro.
3516         (windows_set_context_register_offsets): Add static.
3517         (windows_set_segment_register_p): Likewise.
3518         (windows_add_thread): Adapt for WOW64 processes.
3519         (windows_fetch_one_register): Likewise.
3520         (windows_nat_target::fetch_registers): Likewise.
3521         (windows_store_one_register): Likewise.
3522         (display_selector): Likewise.
3523         (display_selectors): Likewise.
3524         (handle_exception): Likewise.
3525         (windows_continue): Likewise.
3526         (windows_nat_target::resume): Likewise.
3527         (windows_add_all_dlls): Likewise.
3528         (do_initial_windows_stuff): Likewise.
3529         (windows_nat_target::attach): Likewise.
3530         (windows_get_exec_module_filename): Likewise.
3531         (windows_nat_target::create_inferior): Likewise.
3532         (windows_xfer_siginfo): Likewise.
3533         (_initialize_loadable): Initialize Wow64SuspendThread,
3534         Wow64GetThreadContext, Wow64SetThreadContext,
3535         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3536         * windows-nat.h (windows_set_context_register_offsets):
3537         Remove declaration.
3538         (windows_set_segment_register_p): Likewise.
3539         (i386_windows_segment_register_p): Add declaration.
3540         (amd64_windows_segment_register_p): Likewise.
3541
3542 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3543
3544         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3545         in "info registers" for AArch64/ARM.
3546
3547         The change caused "info registers" to not print GPR's.
3548
3549         gdb/ChangeLog:
3550
3551         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3552
3553         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3554         when reg->group is empty and reggroup is not.
3555
3556 2020-03-03  Tom Tromey  <tromey@adacore.com>
3557
3558         * dwarf2/frame.c (struct dwarf2_frame_cache)
3559         <checked_tailcall_bottom, entry_cfa_sp_offset,
3560         entry_cfa_sp_offset_p>: Remove members.
3561         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3562         (dwarf2_frame_prev_register): Don't call
3563         dwarf2_tailcall_sniffer_first.
3564         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3565         * frame-unwind.c (add_unwinder): New fuction.
3566         (frame_unwind_init): Use it.  Add tailcall unwinder.
3567
3568 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3569             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3570
3571         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3572         value should be printed as true.
3573
3574 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3575
3576         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3577         (windows_init_abi): Set and use windows_so_ops.
3578
3579 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3580
3581         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3582         when verifying if dealing with a convenience variable.
3583
3584 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3585
3586         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3587
3588 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3589
3590         * infrun.c (gdbarch_supports_displaced_stepping): New.
3591         (use_displaced_stepping): Break up conditions in smaller pieces.
3592         Use gdbarch_supports_displaced_stepping.
3593         (displaced_step_prepare_throw): Use
3594         gdbarch_supports_displaced_stepping.
3595
3596 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3597
3598         * NEWS: Mention new behaviour of the history filename.
3599         * top.c (write_history_p): Add comment.
3600         (show_write_history_p): Add header comment, give a different
3601         message when history writing is on, but the history filename is
3602         empty.
3603         (history_filename): Add comment.
3604         (history_filename_empty): New function.
3605         (show_history_filename): Add header comment, give a different
3606         message when the filename is empty.
3607         (init_history): Compare history_filename against nullptr, and only
3608         read history if the filename is not empty.
3609         (set_history_filename): Add header comment, and only make
3610         non-empty filenames absolute.
3611         (init_main): Make the filename argument to 'set history filename'
3612         optional.
3613
3614 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3615
3616         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3617         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3618         (fetch_fp_register): Update.
3619         (fetch_fp_regs): Update.
3620         (store_fp_register): Update.
3621         (store_fp_regs): Update.
3622         (arm_netbsd_nat_target::read_description): New function.
3623         (fetch_elfcore_registers): Update.
3624
3625 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3626
3627         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3628         general_thread if the stop reply is missing a thread-id.
3629         (remote_target::process_stop_reply): Use the first non-exited
3630         thread if the target didn't pass a thread-id.
3631         * infrun.c (do_target_wait): Move call to
3632         switch_to_inferior_no_thread to ....
3633         (do_target_wait_1): ... here.
3634
3635 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3636
3637         * debuginfod-support.c: Include defs.h first.
3638
3639 2020-02-28  Tom de Vries  <tdevries@suse.de>
3640
3641         * symfile.c (set_initial_language): Use default language for lookup.
3642
3643 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3644
3645         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3646         reader variable, pass `this` to read_cutu_die_from_dwo.
3647
3648 2020-02-27  Aaron Merey  <amerey@redhat.com>
3649
3650         * source.c (open_source_file): Check for nullptr when computing
3651         srcpath.
3652
3653 2020-02-27  Tom Tromey  <tromey@adacore.com>
3654
3655         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3656         member.
3657         (dwarf2_add_field): Don't update nfields.
3658         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3659
3660 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3661
3662         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3663         abs.
3664
3665 2020-02-26  Tom Tromey  <tom@tromey.com>
3666
3667         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3668         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3669         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3670         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3671         per_cu_data.
3672
3673 2020-02-26  Tom Tromey  <tom@tromey.com>
3674
3675         * dwarf2/index-write.c (psym_index_map): Change type.
3676         (add_address_entry_worker, write_one_signatured_type)
3677         (recursively_count_psymbols, recursively_write_psymbols)
3678         (class debug_names, psyms_seen_size, write_gdbindex)
3679         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3680
3681 2020-02-26  Aaron Merey  <amerey@redhat.com>
3682
3683         * Makefile.in: Handle optional debuginfod support.
3684         * NEWS: Update.
3685         * README: Add --with-debuginfod summary.
3686         * config.in: Regenerate.
3687         * configure: Regenerate.
3688         * configure.ac: Handle optional debuginfod support.
3689         * debuginfod-support.c: debuginfod helper functions.
3690         * debuginfod-support.h: Ditto.
3691         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3692         summary.
3693         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3694         when a dwz file cannot be found.
3695         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3696         debuginfo file cannot be found.
3697         * source.c (open_source_file): Query debuginfod servers when a
3698         source file cannot be found.
3699         * top.c (print_gdb_configuration): Include
3700         --{with,without}-debuginfod in the output.
3701
3702 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3703
3704         * thread.c (thr_try_catch_cmd): Print thread name.
3705
3706 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3707
3708         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3709         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3710         dwarf2_fetch_die_type_sect_off): Move to...
3711         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3712         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3713         dwarf2_fetch_die_type_sect_off): ... here.
3714         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3715         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3716         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3717
3718 2020-02-26  Tom de Vries  <tdevries@suse.de>
3719
3720         PR gdb/25603
3721         * symfile.c (set_initial_language): Exit-early if
3722         language_mode == language_mode_manual.
3723
3724 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3725
3726         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3727         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3728         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3729
3730 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3731
3732         * gdbtypes.c (create_array_type_with_stride): Handle negative
3733         array strides.
3734         * valarith.c (value_subscripted_rvalue): Likewise.
3735
3736 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3737
3738         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3739
3740 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3741
3742         * loc.h (dwarf2_get_die_type): Move to...
3743         * read.h (dwarf2_get_die_type): ... here.
3744         * read.c (dwarf2_get_die_type): Move doc to header.
3745
3746 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3747
3748         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3749         'gnulib/Makefile.in' to the list.
3750
3751 2020-02-24  Tom Tromey  <tom@tromey.com>
3752
3753         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
3754         Remove.
3755         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
3756         XOBNEWVEC.
3757
3758 2020-02-24  Tom Tromey  <tom@tromey.com>
3759
3760         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
3761         New method.
3762         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
3763         (dw2_do_instantiate_symtab, dw2_get_file_names)
3764         (build_type_psymtab_dependencies, load_full_type_unit): Update.
3765
3766 2020-02-24  Tom Tromey  <tom@tromey.com>
3767
3768         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
3769         make_scoped_restore.
3770         (dwarf2_psymtab::read_symtab): Don't clear
3771         reading_partial_symbols.
3772
3773 2020-02-24  Tom de Vries  <tdevries@suse.de>
3774
3775         PR gdb/25592
3776         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
3777
3778 2020-02-24  Tom de Vries  <tdevries@suse.de>
3779
3780         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
3781         commands layout next/prev/regs.
3782
3783 2020-02-22  Tom Tromey  <tom@tromey.com>
3784
3785         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
3786         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
3787
3788 2020-02-22  Tom Tromey  <tom@tromey.com>
3789
3790         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
3791
3792 2020-02-22  Tom Tromey  <tom@tromey.com>
3793
3794         * tui/tui-win.c (_initialize_tui_win): Add usage text.
3795         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
3796         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
3797         * tui/tui.c (_initialize_tui): Add usage text.
3798
3799 2020-02-22  Tom Tromey  <tom@tromey.com>
3800
3801         * tui/tui-win.c (tui_set_focus_command)
3802         (tui_set_win_height_command): Use error_no_arg.
3803         (_initialize_tui_win): Update help text.
3804         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
3805
3806 2020-02-22  Tom Tromey  <tom@tromey.com>
3807
3808         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
3809         * tui/tui-disasm.h (struct tui_disasm_window)
3810         <display_start_addr>: Declare.
3811         * tui/tui-source.h (struct tui_source_window)
3812         <display_start_addr>: Declare.
3813         * tui/tui-winsource.h (struct tui_source_window_base)
3814         <show_source_line, display_start_addr>: New methods.
3815         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
3816         Rename and move to protected section.
3817         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
3818         (tui_source_window_base::do_erase_source_content): Update.
3819         (tui_source_window_base::show_source_line): Now a method.
3820         (tui_source_window_base::show_source_content)
3821         (tui_source_window_base::tui_source_window_base)
3822         (tui_source_window_base::rerender)
3823         (tui_source_window_base::refill)
3824         (tui_source_window_base::do_scroll_horizontal)
3825         (tui_source_window_base::set_is_exec_point_at)
3826         (tui_source_window_base::update_breakpoint_info)
3827         (tui_source_window_base::update_exec_info): Update.
3828         * tui/tui-source.c (tui_source_window::set_contents)
3829         (tui_source_window::showing_source_p)
3830         (tui_source_window::do_scroll_vertical)
3831         (tui_source_window::location_matches_p)
3832         (tui_source_window::line_is_displayed): Update.
3833         (tui_source_window::display_start_addr): New method.
3834         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3835         (tui_disasm_window::do_scroll_vertical)
3836         (tui_disasm_window::location_matches_p): Update.
3837         (tui_disasm_window::display_start_addr): New method.
3838
3839 2020-02-22  Tom Tromey  <tom@tromey.com>
3840
3841         * NEWS: Add entry for gdb.register_window_type.
3842         * tui/tui-layout.h (window_factory): New typedef.
3843         (tui_register_window): Declare.
3844         * tui/tui-layout.c (saved_tui_windows): New global.
3845         (tui_apply_current_layout): Use it.
3846         (tui_register_window): New function.
3847         * python/python.c (do_start_initialization): Call
3848         gdbpy_initialize_tui.
3849         (python_GdbMethods): Add "register_window_type" function.
3850         * python/python-internal.h (gdbpy_register_tui_window)
3851         (gdbpy_initialize_tui): Declare.
3852         * python/py-tui.c: New file.
3853         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3854
3855 2020-02-22  Tom Tromey  <tom@tromey.com>
3856
3857         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3858
3859 2020-02-22  Tom Tromey  <tom@tromey.com>
3860
3861         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3862         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3863         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3864         (tui_set_win_focus_to): Move from tui-win.c.
3865
3866 2020-02-22  Tom Tromey  <tom@tromey.com>
3867
3868         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3869         functions.
3870         (known_window_types): New global.
3871         (tui_get_window_by_name): Reimplement.
3872         (initialize_known_windows): New function.
3873         (validate_window_name): Rewrite.
3874         (_initialize_tui_layout): Call initialize_known_windows.
3875
3876 2020-02-22  Tom Tromey  <tom@tromey.com>
3877
3878         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3879         Remove constants.
3880         * tui/tui-winsource.h (struct tui_source_window_base)
3881         <tui_source_window_base>: Remove parameter.
3882         * tui/tui-winsource.c
3883         (tui_source_window_base::tui_source_window_base): Remove
3884         parameter.
3885         (tui_source_window_base::refill): Update.
3886         * tui/tui-stack.h (struct tui_locator_window)
3887         <tui_locator_window>: Update.
3888         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3889         Default the constructor.
3890         * tui/tui-regs.h (struct tui_data_item_window)
3891         <tui_data_item_window>: Default the constructor.
3892         (struct tui_data_window) <tui_data_window>: Likewise.
3893         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3894         Default the constructor.
3895         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3896         Default the constructor.
3897         <type>: Remove.
3898         (struct tui_win_info) <tui_win_info>: Default the constructor.
3899         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3900         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3901         Default the constructor.
3902
3903 2020-02-22  Tom Tromey  <tom@tromey.com>
3904
3905         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
3906         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
3907         * tui/tui-win.c (tui_resize_all): Don't call
3908         tui_delete_invisible_windows.
3909         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
3910         done.
3911         (tui_set_layout): Update.
3912         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
3913         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
3914         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
3915
3916 2020-02-22  Tom Tromey  <tom@tromey.com>
3917
3918         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
3919         correctly.
3920
3921 2020-02-22  Tom Tromey  <tom@tromey.com>
3922
3923         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
3924
3925 2020-02-22  Tom Tromey  <tom@tromey.com>
3926
3927         * tui/tui-winsource.h (struct tui_source_window_iterator)
3928         <inner_iterator>: New etytypedef.
3929         <tui_source_window_iterator>: Take "end" parameter.
3930         <tui_source_window_iterator>: Take iterator.
3931         <operator*, advance>: Update.
3932         <m_iter>: Change type.
3933         <m_end>: New field.
3934         (struct tui_source_windows) <begin, end>: Update.
3935         * tui/tui-layout.c (tui_windows): New global.
3936         (tui_apply_current_layout): Clear tui_windows.
3937         (tui_layout_window::apply): Update tui_windows.
3938         * tui/tui-data.h (tui_windows): Declare.
3939         (all_tui_windows): Now inline function.
3940         (class tui_window_iterator, struct all_tui_windows): Remove.
3941
3942 2020-02-22  Tom Tromey  <tom@tromey.com>
3943
3944         PR tui/17850:
3945         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
3946         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
3947         "height" argument.
3948         (class tui_layout_window) <get_sizes>: Likewise.
3949         (class tui_layout_split) <tui_layout_split>: Add "vertical"
3950         argument.
3951         <get_sizes>: Add "height" argument.
3952         <m_vertical>: New field.
3953         * tui/tui-layout.c (tui_layout_split::clone): Update.
3954         (tui_layout_split::get_sizes): Add "height" argument.
3955         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
3956         (tui_new_layout_command): Parse "-horizontal".
3957         (_initialize_tui_layout): Update help string.
3958         (tui_layout_split::specification): Add "-horizontal" when needed.
3959         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
3960         argument.
3961         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
3962         New methods.
3963
3964 2020-02-22  Tom Tromey  <tom@tromey.com>
3965
3966         * tui/tui-layout.h (enum tui_adjust_result): New.
3967         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
3968         (class tui_layout_window) <adjust_size>: Return
3969         tui_adjust_result.  Rewrite.
3970         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
3971         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
3972
3973 2020-02-22  Tom Tromey  <tom@tromey.com>
3974
3975         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
3976         parameter and return types.
3977         (class tui_layout_base) <specification>: Add "depth".
3978         (class tui_layout_window) <specification>: Add "depth".
3979         (class tui_layout_split) <specification>: Add "depth".
3980         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
3981         and return types.
3982         (tui_new_layout_command): Parse sub-layouts.
3983         (_initialize_tui_layout): Update help string.
3984         (tui_layout_window::specification): Add "depth".
3985         (add_layout_command): Update.
3986
3987 2020-02-22  Tom Tromey  <tom@tromey.com>
3988
3989         * NEWS: Add "tui new-layout" item.
3990         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
3991         Add new-layout command to help text.
3992         (validate_window_name): New function.
3993         (tui_new_layout_command): New function.
3994         (_initialize_tui_layout): Register "new-layout".
3995         (tui_layout_window::specification): New method.
3996         (tui_layout_window::specification): New method.
3997         * tui/tui-layout.h (class tui_layout_base) <specification>: New
3998         method.
3999         (class tui_layout_window) <specification>: New method.
4000         (class tui_layout_split) <specification>: New method.
4001
4002 2020-02-22  Tom Tromey  <tom@tromey.com>
4003
4004         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
4005         * tui/tui-win.c (window_name_completer): Update comment.
4006         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
4007         Declare method.
4008         (class tui_layout_window) <replace_window>: Likewise.
4009         (class tui_layout_split) <replace_window>: Likewise.
4010         (tui_set_layout): Don't declare.
4011         (tui_set_initial_layout): Declare function.
4012         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
4013         (asm_regs_layout): New globals.
4014         (tui_current_layout, show_layout): Remove.
4015         (tui_set_layout, tui_add_win_to_layout): Rewrite.
4016         (find_layout, tui_apply_layout): New function.
4017         (layout_completer): Remove.
4018         (tui_next_layout): Reimplement.
4019         (tui_next_layout_command): New function.
4020         (tui_set_initial_layout, tui_prev_layout_command): New functions.
4021         (tui_regs_layout): Reimplement.
4022         (tui_regs_layout_command): New function.
4023         (extract_display_start_addr): Rewrite.
4024         (next_layout, prev_layout): Remove.
4025         (tui_layout_window::replace_window): New method.
4026         (tui_layout_split::replace_window): New method.
4027         (destroy_layout): New function.
4028         (layout_list): New global.
4029         (add_layout_command): New function.
4030         (initialize_layouts): Update.
4031         (tui_layout_command): New function.
4032         (_initialize_tui_layout): Install "layout" commands.
4033         * tui/tui-data.h (enum tui_layout_type): Remove.
4034         (tui_current_layout): Don't declare.
4035
4036 2020-02-22  Tom Tromey  <tom@tromey.com>
4037
4038         * tui/tui-regs.c (tui_reg_layout): Remove.
4039         (tui_reg_command): Use tui_regs_layout.
4040         * tui/tui-layout.h (tui_reg_command): Declare.
4041         * tui/tui-layout.c (tui_reg_command): New function.
4042
4043 2020-02-22  Tom Tromey  <tom@tromey.com>
4044
4045         * tui/tui.c (tui_rl_delete_other_windows): Call
4046         tui_remove_some_windows.
4047         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
4048         Declare method.
4049         (class tui_layout_window) <remove_windows>: New method.
4050         (class tui_layout_split) <remove_windows>: Declare.
4051         (tui_remove_some_windows): Declare.
4052         * tui/tui-layout.c (tui_remove_some_windows): New function.
4053         (tui_layout_split::remove_windows): New method.
4054
4055 2020-02-22  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
4058         * tui/tui-layout.h (tui_next_layout): Declare.
4059         * tui/tui-layout.c (tui_next_layout): New function.
4060
4061 2020-02-22  Tom Tromey  <tom@tromey.com>
4062
4063         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
4064         correct coordinates.
4065
4066 2020-02-22  Tom Tromey  <tom@tromey.com>
4067
4068         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
4069         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
4070         DATA_WIN case.
4071
4072 2020-02-22  Tom Tromey  <tom@tromey.com>
4073
4074         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
4075         TUI_DISASM_WIN, not tui_win_list.
4076
4077 2020-02-22  Tom Tromey  <tom@tromey.com>
4078
4079         * valprint.c (generic_val_print_enum_1)
4080         (val_print_type_code_flags): Style member names.
4081         * rust-lang.c (val_print_struct, rust_print_enum)
4082         (rust_print_struct_def, rust_internal_print_type): Style member
4083         names.
4084         * p-valprint.c (pascal_object_print_value_fields): Style member
4085         names.  Only call fprintf_symbol_filtered for static members.
4086         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
4087         * f-valprint.c (f_val_print): Style member names.
4088         * f-typeprint.c (f_type_print_base): Style member names.
4089         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
4090         call fprintf_symbol_filtered for static members.
4091         (cp_print_class_member): Style member names.
4092         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
4093         member names.
4094         * ada-valprint.c (ada_print_scalar): Style enum names.
4095         (ada_val_print_enum): Likewise.
4096         * ada-typeprint.c (print_enum_type): Style enum names.
4097
4098 2020-02-21  Tom Tromey  <tom@tromey.com>
4099
4100         * psympriv.h (struct partial_symtab): Update comment.
4101
4102 2020-02-21  Tom Tromey  <tromey@adacore.com>
4103
4104         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
4105         type is CORE_ADDR.
4106
4107 2020-02-21  Tom de Vries  <tdevries@suse.de>
4108
4109         PR gdb/25534
4110         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
4111         if dependencies[i]->user != NULL.
4112
4113 2020-02-21  Ali Tamur  <tamur@google.com>
4114
4115         * dwarf2/read.c (dwarf2_name): Add null check.
4116
4117 2020-02-20  Tom Tromey  <tom@tromey.com>
4118
4119         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
4120         ">=", in binary search.
4121         (dwarf2_find_containing_comp_unit): New overload.
4122         (run_test): New self-test.
4123         (_initialize_dwarf2_read): Register new test.
4124
4125 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
4126
4127         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
4128         * riscv-tdep.h: Likewise.
4129         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
4130         rv32-only CSR.
4131         * features/riscv/64bit-csr.xml: Regenerated.
4132
4133 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
4134             Tom Tromey  <tom@tromey.com>
4135
4136         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
4137         of 'fputc_unfiltered'.
4138         (putchar_unfiltered): Call 'fputc_unfiltered'.
4139         (fputc_unfiltered): Call 'fputs_unfiltered'.
4140
4141 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
4142
4143         * config.in: Regenerate.
4144         * configure: Regenerate.
4145         * configure.ac: Add --with-python-libdir option.
4146         * main.c: Use WITH_PYTHON_LIBDIR.
4147
4148 2020-02-19  Tom Tromey  <tom@tromey.com>
4149
4150         * symtab.c (general_symbol_info::compute_and_set_names): Use
4151         obstack_strndup.  Simplify call to symbol_set_demangled_name.
4152
4153 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
4154
4155         * dwarf2/read.c (allocate_signatured_type_table,
4156         allocate_dwo_unit_table, allocate_type_unit_groups_table,
4157         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
4158         Remove objfile parameter, update all callers.
4159
4160 2020-02-19  Doug Evans  <dje@google.com>
4161
4162         PR rust/25535
4163         * rust-lang.c (rust_print_enum): Apply embedded_offset to
4164         rust_enum_variant calculation.
4165
4166 2020-02-19  Tom Tromey  <tromey@adacore.com>
4167
4168         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
4169
4170 2020-02-19  Tom Tromey  <tromey@adacore.com>
4171
4172         * ada-lang.c (cache_symbol): Use obstack_strdup.
4173
4174 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4175
4176         * configure: Regenerate.
4177
4178 2020-02-19  Tom Tromey  <tromey@adacore.com>
4179
4180         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
4181         NULL check.
4182
4183 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
4184
4185         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
4186
4187 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
4188
4189         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
4190         if GDBSERVER is not defined.
4191         (riscv_tdesc_cache): Likewise, also store const target_desc.
4192         (STATIC_IN_GDB): Define.
4193         (riscv_create_target_description): Update declaration with
4194         STATIC_IN_GDB.
4195         (riscv_lookup_target_description): New function, only define if
4196         GDBSERVER is not defined.
4197         * arch/riscv.h (riscv_create_target_description): Declare only
4198         when GDBSERVER is defined.
4199         (riscv_lookup_target_description): New declaration when GDBSERVER
4200         is not defined.
4201         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
4202         (riscv_linux_read_features): ...this, and return
4203         riscv_gdbarch_features instead of target_desc.
4204         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
4205         (riscv_linux_read_description): Rename to...
4206         (riscv_linux_read_features): ...this.
4207         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4208         Update to use riscv_gdbarch_features and
4209         riscv_lookup_target_description.
4210         * riscv-tdep.c (riscv_find_default_target_description): Use
4211         riscv_lookup_target_description instead of
4212         riscv_create_target_description.
4213
4214 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4215
4216         * valprint.c (generic_val_print_enum_1): When printing a flag
4217         enum with value 0 and there is no enumerator with value 0, print
4218         just "0" instead of "(unknown: 0x0)".
4219
4220 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4221
4222         * valprint.c (generic_val_print_enum_1): Print unknown part of
4223         flag enum in hex.
4224
4225 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4226
4227         * dwarf2/read.c (update_enumeration_type_from_children): Allow
4228         flag enums to contain duplicate enumerators.
4229         * valprint.c (generic_val_print_enum_1): Update comment.
4230
4231 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4232
4233         * dwarf2/read.c: Include "count-one-bits.h".
4234         (update_enumeration_type_from_children): If an enumerator has
4235         multiple bits set, don't treat the enumeration as a "flag enum".
4236         * valprint.c (generic_val_print_enum_1): Assert that enumerators
4237         of flag enums have 0 or 1 bit set.
4238
4239 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4240
4241         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
4242         conversion.
4243         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4244         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4245         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4246         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4247         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4248
4249 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
4250
4251         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
4252
4253 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4254
4255         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
4256         displaced_step_closure_up.
4257         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4258         (struct displaced_step_closure_up):
4259         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4260         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4261         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
4262         Likewise.
4263         * gdbarch.sh (displaced_step_copy_insn): Likewise.
4264         * gdbarch.c, gdbarch.h: Re-generate.
4265         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
4266         displaced_step_closure_up.
4267         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4268         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4269         * infrun.h (displaced_step_closure_up): New type alias.
4270         (struct displaced_step_inferior_state) <step_closure>: Change
4271         type to displaced_step_closure_up.
4272         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
4273         displaced_step_closure_up.
4274         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4275
4276 2020-02-14  Tom Tromey  <tom@tromey.com>
4277
4278         * minidebug.c (gnu_debug_key): New global.
4279         (find_separate_debug_file_in_section): Use it.
4280
4281 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4282
4283         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
4284         std::unique_ptr.
4285         * gdbarch.c: Re-generate.
4286         * gdbarch.h: Re-generate.
4287         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
4288         change.
4289         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
4290         type to std::unique_ptr.
4291         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4292         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4293         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4294         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4295         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
4296         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4297         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4298         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4299         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4300
4301 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4302
4303         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
4304         std::unique_ptr.
4305         (displaced_step_clear): Rename to...
4306         (displaced_step_reset): ... this.  Just call displaced->reset ().
4307         (displaced_step_clear_cleanup): Rename to...
4308         (displaced_step_reset_cleanup): ... this.
4309         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4310         (displaced_step_fixup): Likewise.
4311         (resume_1): Likewise.
4312         (handle_inferior_event): Restore child's memory before calling
4313         displaced_step_fixup on the parent.
4314         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4315         to std::unique_ptr.
4316         <step_closure>: Change type to std::unique_ptr.
4317
4318 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4319
4320         * arm-tdep.c: Include count-one-bits.h.
4321         (cleanup_block_store_pc): Use count_one_bits.
4322         (cleanup_block_load_pc): Use count_one_bits.
4323         (arm_copy_block_xfer): Use count_one_bits.
4324         (thumb2_copy_block_xfer): Use count_one_bits.
4325         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4326         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4327         (thumb_get_next_pcs_raw): Use count_one_bits.
4328         (arm_get_next_pcs_raw): Use count_one_bits_l.
4329         * arch/arm.c (bitcount): Remove.
4330         * arch/arm.h (bitcount): Remove.
4331
4332 2020-02-14  Tom Tromey  <tromey@adacore.com>
4333
4334         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4335         Update.
4336         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4337         * dwarf2/loc.c (call_site_find_chain_1): Return
4338         unique_xmalloc_ptr.
4339         (call_site_find_chain): Likewise.
4340
4341 2020-02-14  Richard Biener  <rguenther@suse.de>
4342
4343         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4344         on expression with division operators.
4345
4346 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4347
4348         * MAINTAINERS (Write After Approval): Adding myself.
4349
4350 2020-02-12  Tom Tromey  <tom@tromey.com>
4351
4352         * event-loop.c (event_data, gdb_event, event_handler_func):
4353         Remove.
4354
4355 2020-02-12  Tom Tromey  <tom@tromey.com>
4356
4357         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
4358         (dwarf2_frame_objfile_data): Add comment.
4359         (find_comp_unit, set_comp_unit): New functions.
4360         (dwarf2_frame_find_fde): Use find_comp_unit.
4361         (dwarf2_build_frame_info): Use set_comp_unit.
4362
4363 2020-02-12  Tom Tromey  <tom@tromey.com>
4364
4365         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
4366         (comp_unit): Don't initialize objfile.
4367         (execute_cfa_program): Add text_offset parameter.
4368         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
4369         (dwarf2_frame_cache): Update.
4370         (dwarf2_build_frame_info): Don't set "objfile" member.
4371
4372 2020-02-12  Tom Tromey  <tom@tromey.com>
4373
4374         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
4375         (decode_frame_entry): Likewise.
4376         (dwarf2_build_frame_info): Update.
4377
4378 2020-02-12  Tom Tromey  <tom@tromey.com>
4379
4380         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
4381         (decode_frame_entry_1): Use the comp_unit obstack.
4382
4383 2020-02-12  Tom Tromey  <tom@tromey.com>
4384
4385         * dwarf2/frame.c (struct comp_unit): Add initializers and
4386         constructor.
4387         (dwarf2_frame_objfile_data): Store a comp_unit.
4388         (dwarf2_frame_find_fde): Update.
4389         (dwarf2_build_frame_info): Use "new".
4390
4391 2020-02-12  Tom Tromey  <tom@tromey.com>
4392
4393         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
4394         (dwarf2_fde_table): Typedef for std::vector.
4395         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
4396         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
4397         (decode_frame_entry): Update.
4398         (dwarf2_build_frame_info): Use "new".
4399
4400 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4401
4402         * arm-tdep.c (arm_gdbarch_init): Update.
4403         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
4404         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
4405         have_neon, is_m>: Change to bool.
4406
4407 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4408
4409         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
4410
4411 2020-02-12  Tom Tromey  <tom@tromey.com>
4412
4413         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
4414
4415 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
4416
4417         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
4418         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
4419
4420 2020-02-11  Tom Tromey  <tom@tromey.com>
4421
4422         * psymtab.h: Update comment.
4423
4424 2020-02-11  Tom Tromey  <tom@tromey.com>
4425
4426         * gdb_obstack.h (struct auto_obstack): Use
4427         DISABLE_COPY_AND_ASSIGN.
4428
4429 2020-02-11  Tom Tromey  <tom@tromey.com>
4430
4431         * dwarf2/frame.h (struct objfile): Don't forward declare.
4432
4433 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4434
4435         * cris-tdep.c (cris_supply_gregset): Change signature to match
4436         what struct regset expects.
4437         (cris_regset): New struct.
4438         (fetch_core_registers): Remove.
4439         (cris_iterate_over_regset_sections): New function.
4440         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
4441         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
4442
4443 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4444
4445         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
4446         registers.
4447
4448 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4449
4450         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
4451
4452 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4453
4454         * configure: Re-generate.
4455
4456 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4457
4458         * configure: Re-generate.
4459
4460 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4461
4462         * acinclude: Update warning.m4 path.
4463         * warning.m4: Move to gdbsupport.
4464
4465 2020-02-11  Tom Tromey  <tromey@adacore.com>
4466
4467         * remote.c (remote_console_output): Update.
4468         * printcmd.c (printf_command): Update.
4469         * event-loop.c (gdb_wait_for_event): Update.
4470         * linux-nat.c (sigchld_handler): Update.
4471         * remote-sim.c (gdb_os_write_stdout): Update.
4472         (gdb_os_flush_stdout): Update.
4473         (gdb_os_flush_stderr): Update.
4474         (gdb_os_write_stderr): Update.
4475         * exceptions.c (print_exception): Update.
4476         * remote-fileio.c (remote_fileio_func_read): Update.
4477         (remote_fileio_func_write): Update.
4478         * tui/tui.c (tui_enable): Update.
4479         * tui/tui-interp.c (tui_interp::init): Update.
4480         * utils.c (init_page_info): Update.
4481         (putchar_unfiltered, fputc_unfiltered): Update.
4482         (gdb_flush): Update.
4483         (emit_style_escape): Update.
4484         (flush_wrap_buffer, fputs_maybe_filtered): Update.
4485         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
4486         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4487         (stderr_file::write): Update.
4488         (stderr_file::puts): Update.
4489         * ui-file.h (ui_file_isatty, ui_file_write)
4490         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4491         (ui_file_puts): Don't declare.
4492
4493 2020-02-10  Tom de Vries  <tdevries@suse.de>
4494
4495         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4496         sentinel to char *.
4497
4498 2020-02-09  Tom de Vries  <tdevries@suse.de>
4499
4500         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4501         filename if it matches "<artificial>".
4502
4503 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4504
4505         * windows-tdep.c (struct enum_value_name): New struct.
4506         (create_enum): New function.
4507         (windows_get_siginfo_type): Create and use enum types.
4508
4509 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4510
4511         * NEWS: Mention $_siginfo support for Windows.
4512         * windows-nat.c (handle_exception): Set siginfo_er.
4513         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4514         (windows_xfer_siginfo): New function.
4515         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4516         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4517         (init_windows_gdbarch_data): New function.
4518         (get_windows_gdbarch_data): New function.
4519         (windows_get_siginfo_type): New function.
4520         (windows_init_abi): Register windows_get_siginfo_type.
4521         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4522
4523 2020-02-08  Tom Tromey  <tom@tromey.com>
4524
4525         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4526         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4527         <keep>: Declare method.
4528         <m_keep>: Remove member.
4529         <~cutu_reader>: Remove.
4530         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4531         (cutu_reader::cutu_reader): Update.
4532         (cutu_reader::keep): Rename from ~cutu_reader.
4533         (process_psymtab_comp_unit, build_type_psymtabs_1)
4534         (process_skeletonless_type_unit, load_partial_comp_unit)
4535         (load_full_comp_unit, dwarf2_read_addr_index)
4536         (read_signatured_type): Update.
4537
4538 2020-02-08  Tom Tromey  <tom@tromey.com>
4539
4540         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4541         "want_partial_unit" parameter.
4542         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4543         Inline check for DW_TAG_partial_unit.
4544         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4545
4546 2020-02-08  Tom Tromey  <tom@tromey.com>
4547
4548         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4549         read.c.
4550         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4551         read.c.
4552
4553 2020-02-08  Tom Tromey  <tom@tromey.com>
4554
4555         * dwarf2/read.c (read_address): Move to comp-unit.c.
4556         (dwarf2_rnglists_process, dwarf2_ranges_process)
4557         (read_attribute_value, dwarf_decode_lines_1)
4558         (var_decode_location, decode_locdesc): Update.
4559         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4560         read.c.  Remove "cu" parameter.
4561         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4562         method.
4563
4564 2020-02-08  Tom Tromey  <tom@tromey.com>
4565
4566         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4567         (read_indirect_line_string): Update.
4568         * dwarf2/comp-unit.c (read_offset): Remove.
4569         (read_comp_unit_head): Update.
4570         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4571         method.
4572         (read_offset): Don't declare.
4573
4574 2020-02-08  Tom Tromey  <tom@tromey.com>
4575
4576         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4577         * dwarf2/read.c (struct comp_unit_head): Move to
4578         dwarf2/comp-unit.h.
4579         (enum class rcuh_kind): Move to comp-unit.h.
4580         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4581         (read_comp_unit_head, error_check_comp_unit_head)
4582         (read_and_check_comp_unit_head): Move to comp-unit.c.
4583         (read_offset, dwarf_unit_type_name): Likewise.
4584         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4585         (cutu_reader::cutu_reader, read_call_site_scope)
4586         (find_partial_die, follow_die_offset): Update.
4587         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4588
4589 2020-02-08  Tom Tromey  <tom@tromey.com>
4590
4591         * dwarf2/read.c (read_offset_1): Move to leb.c.
4592         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4593         (dwarf_decode_macro_bytes): Update.
4594         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4595         * dwarf2/leb.h (read_offset): Declare.
4596
4597 2020-02-08  Tom Tromey  <tom@tromey.com>
4598
4599         * dwarf2/read.c (dwarf2_section_size): Remove.
4600         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4601         Update.
4602         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4603
4604 2020-02-08  Tom Tromey  <tom@tromey.com>
4605
4606         * dwarf2/read.c (read_initial_length): Move to leb.c.
4607         * dwarf2/leb.h (read_initial_length): Declare.
4608         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4609         handle_nonstd parameter.
4610         * dwarf2/frame.c (read_initial_length): Remove.
4611         (decode_frame_entry_1): Update.
4612
4613 2020-02-08  Tom Tromey  <tom@tromey.com>
4614
4615         * dwarf2/loc.c (dwarf2_find_location_expression)
4616         (dwarf_evaluate_loc_desc::get_tls_address)
4617         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4618         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4619         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4620         (dwarf2_compile_property_to_c)
4621         (dwarf2_loc_desc_get_symbol_read_needs)
4622         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4623         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4624         (loclist_describe_location, loclist_tracepoint_var_ref)
4625         (loclist_generate_c_location): Update.
4626         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4627         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4628         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4629         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4630         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4631         (dwarf2_per_cu_data::addr_size)
4632         (dwarf2_per_cu_data::ref_addr_size)
4633         (dwarf2_per_cu_data::text_offset)
4634         (dwarf2_per_cu_data::addr_type): Now methods.
4635         (per_cu_header_read_in): Make per_cu "const".
4636         (dwarf2_version): Remove.
4637         (dwarf2_per_cu_data::int_type): Now a method.
4638         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4639         (set_die_type, read_array_type, read_subrange_index_type)
4640         (read_tag_string_type, read_subrange_type): Update.
4641         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4642         offset_size, ref_addr_size, text_offset, addr_type, version,
4643         objfile, int_type, addr_sized_int_type>: Declare methods.
4644
4645 2020-02-08  Tom Tromey  <tom@tromey.com>
4646
4647         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4648         Move earlier.
4649
4650 2020-02-08  Tom Tromey  <tom@tromey.com>
4651
4652         * dwarf2/read.h (dwarf_line_debug): Declare.
4653         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4654         * dwarf2/read.c: Move line_header code to new files.
4655         (dwarf_line_debug): No longer static.
4656         * dwarf2/line-header.c: New file.
4657         * dwarf2/line-header.h: New file.
4658
4659 2020-02-08  Tom Tromey  <tom@tromey.com>
4660
4661         * dwarf2/read.c (struct line_header) <file_full_name,
4662         file_file_name>: Return unique_xmalloc_ptr.
4663         (line_header::file_file_name): Update.
4664         (line_header::file_full_name): Update.
4665         (dw2_get_file_names_reader): Update.
4666         (macro_start_file): Update.
4667
4668 2020-02-08  Tom Tromey  <tom@tromey.com>
4669
4670         * dwarf2/read.c (struct line_header) <file_full_name,
4671         file_file_name>: Declare methods.
4672         (dw2_get_file_names_reader): Update.
4673         (file_file_name): Now a method.
4674         (file_full_name): Likewise.
4675         (macro_start_file): Update.
4676
4677 2020-02-08  Tom Tromey  <tom@tromey.com>
4678
4679         * dwarf2/read.c (dwarf_always_disassemble)
4680         (show_dwarf_always_disassemble): Move to loc.c.
4681         (_initialize_dwarf2_read): Move "always-disassemble" registration
4682         to loc.c.
4683         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4684         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4685         static.
4686         (show_dwarf_always_disassemble): Move from read.c.
4687         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4688
4689 2020-02-08  Tom Tromey  <tom@tromey.com>
4690
4691         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4692         (create_quick_file_names_table): Return htab_up.
4693         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4694         Update.
4695         * dwarf2/read.h (struct dwarf2_per_objfile)
4696         <quick_file_names_table>: Now htab_up.
4697
4698 2020-02-08  Tom Tromey  <tom@tromey.com>
4699
4700         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4701
4702 2020-02-08  Tom Tromey  <tom@tromey.com>
4703
4704         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4705         Rewrite.
4706         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4707         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4708         (abbrev_table::abbrev_table): No longer inline.
4709         (ABBREV_HASH_SIZE): Remove.
4710         (abbrev_table::m_abbrevs): Now an htab_up.
4711
4712 2020-02-08  Tom Tromey  <tom@tromey.com>
4713
4714         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4715         (cutu_reader): Update.
4716         (build_type_psymtabs_1): Update.
4717         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4718         (abbrev_table::alloc_abbrev): Update.
4719         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4720         (abbrev_table::read): New static method, renamed from
4721         abbrev_table_read_table.
4722         (abbrev_table::alloc_abbrev)
4723         (abbrev_table::add_abbrev): Now private.
4724         (abbrev_table::abbrev_table): Now private.
4725         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4726
4727 2020-02-08  Tom Tromey  <tom@tromey.com>
4728
4729         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4730         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4731         htab_up.
4732
4733 2020-02-08  Tom Tromey  <tom@tromey.com>
4734
4735         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4736         htab_up.
4737         (lookup_dwo_unit_in_dwp): Update.
4738         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4739         on obstack.
4740
4741 2020-02-08  Tom Tromey  <tom@tromey.com>
4742
4743         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4744         obstack.
4745
4746 2020-02-08  Tom Tromey  <tom@tromey.com>
4747
4748         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4749         line_header_hash.
4750         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4751         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4752         Change type to htab_up.
4753
4754 2020-02-08  Tom Tromey  <tom@tromey.com>
4755
4756         * dwarf2/read.c (allocate_type_unit_groups_table): Return
4757         htab_up.  Don't allocate on obstack.
4758         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
4759         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
4760         Change type to htab_up.
4761
4762 2020-02-08  Tom Tromey  <tom@tromey.com>
4763
4764         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
4765         Change type to htab_up.
4766         * dwarf2/read.c (create_signatured_type_table_from_index)
4767         (create_signatured_type_table_from_debug_names)
4768         (create_all_type_units, add_type_unit)
4769         (lookup_dwo_signatured_type, lookup_signatured_type)
4770         (process_skeletonless_type_unit): Update.
4771         (create_debug_type_hash_table, create_debug_types_hash_table):
4772         Change type of types_htab.
4773         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
4774         htab_up.  Don't allocate on obstack.
4775         (create_cus_hash_table): Change type of cus_htab parameter.
4776         (struct dwo_file) <cus, tus>: Now htab_up.
4777         (lookup_dwo_signatured_type, lookup_dwo_cutu)
4778         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
4779         (queue_and_load_all_dwo_tus): Update.
4780         * dwarf2/index-write.c (write_gdbindex): Update.
4781         (write_debug_names): Update.
4782
4783 2020-02-08  Tom Tromey  <tom@tromey.com>
4784
4785         * dwarf2/read.h (struct dwarf2_queue_item): Move from
4786         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
4787         destructor.
4788         (struct dwarf2_per_objfile) <queue>: New member.
4789         * dwarf2/read.c (struct dwarf2_queue_item): Move to
4790         dwarf2/read.h.
4791         (dwarf2_queue, dwarf2_queue_tail): Remove.
4792         (class dwarf2_queue_guard): Add parameter to constructor.  Use
4793         DISABLE_COPY_AND_ASSIGN.
4794         <m_per_objfile>: New member.
4795         <~dwarf2_queue_guard>: Rewrite.
4796         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
4797         Update.
4798         (~dwarf2_queue_item): New.
4799
4800 2020-02-08  Tom Tromey  <tom@tromey.com>
4801
4802         * dwarf2/read.c (struct die_info) <has_children>: New member.
4803         (dw2_get_file_names_reader): Remove has_children.
4804         (dw2_get_file_names): Update.
4805         (read_cutu_die_from_dwo): Remove has_children.
4806         (cutu_reader::init_tu_and_read_dwo_dies)
4807         (cutu_reader::cutu_reader): Update.
4808         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
4809         Remove has_children.
4810         (build_type_psymtabs_1, process_skeletonless_type_unit)
4811         (load_partial_comp_unit, load_full_comp_unit): Update.
4812         (create_dwo_cu_reader): Remove has_children.
4813         (create_cus_hash_table, read_die_and_children): Update.
4814         (read_full_die_1,read_full_die): Remove has_children.
4815         (read_signatured_type): Update.
4816         (class cutu_reader) <has_children>: Remove.
4817
4818 2020-02-08  Tom Tromey  <tom@tromey.com>
4819
4820         * dwarf2/expr.c: Rename from dwarf2expr.c.
4821         * dwarf2/expr.h: Rename from dwarf2expr.h.
4822         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
4823         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
4824         * dwarf2/frame.c: Rename from dwarf2-frame.c.
4825         * dwarf2/frame.h: Rename from dwarf2-frame.h.
4826         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
4827         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
4828         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
4829         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
4830         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
4831         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
4832         * dwarf2/loc.c: Rename from dwarf2loc.c.
4833         * dwarf2/loc.h: Rename from dwarf2loc.h.
4834         * dwarf2/read.c: Rename from dwarf2read.c.
4835         * dwarf2/read.h: Rename from dwarf2read.h.
4836         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4837         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4838         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4839         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4840         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4841         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4842         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4843         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4844         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4845         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4846         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4847         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4848         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4849         Update.
4850         * Makefile.in (COMMON_SFILES): Update.
4851         (HFILES_NO_SRCDIR): Update.
4852
4853 2020-02-08  Tom Tromey  <tom@tromey.com>
4854
4855         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4856         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4857
4858 2020-02-08  Tom Tromey  <tom@tromey.com>
4859
4860         * dwarf2read.h (struct die_info): Don't declare.
4861
4862 2020-02-08  Tom Tromey  <tom@tromey.com>
4863
4864         * dwarf2read.h (die_info_ptr): Remove typedef.
4865
4866 2020-02-08  Tom Tromey  <tom@tromey.com>
4867
4868         * dwarf2read.c (read_call_site_scope)
4869         (handle_data_member_location, dwarf2_add_member_fn)
4870         (mark_common_block_symbol_computed, read_common_block)
4871         (attr_to_dynamic_prop, partial_die_info::read)
4872         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4873         (dwarf2_symbol_mark_computed, set_die_type): Update.
4874         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4875         method.
4876         (attr_form_is_block): Don't declare.
4877         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4878
4879 2020-02-08  Tom Tromey  <tom@tromey.com>
4880
4881         * dwarf2read.c (dwarf2_find_base_address, )
4882         (read_call_site_scope, rust_containing_type)
4883         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4884         (handle_data_member_location, dwarf2_add_member_fn)
4885         (get_alignment, read_structure_type, process_structure_scope)
4886         (mark_common_block_symbol_computed, read_common_block)
4887         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4888         (partial_die_info::read, read_attribute_value, new_symbol)
4889         (lookup_die_type, dwarf2_get_ref_die_offset)
4890         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4891         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4892         (dwarf2_symbol_mark_computed): Update.
4893         * dwarf2/attribute.h (struct attribute) <value_as_address,
4894         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4895         methods.
4896         (value_as_address, attr_form_is_section_offset)
4897         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4898         * dwarf2/attribute.c (attribute::value_as_address)
4899         (attribute::form_is_section_offset, attribute::form_is_constant)
4900         (attribute::form_is_ref): Now methods.
4901
4902 2020-02-08  Tom Tromey  <tom@tromey.com>
4903
4904         * dwarf2read.c (struct attribute, DW_STRING)
4905         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
4906         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
4907         (attr_form_is_block, attr_form_is_section_offset)
4908         (attr_form_is_constant, attr_form_is_ref): Move.
4909         * dwarf2/attribute.h: New file.
4910         * dwarf2/attribute.c: New file, from dwarf2read.c.
4911         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
4912
4913 2020-02-08  Tom Tromey  <tom@tromey.com>
4914
4915         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
4916         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
4917         Move.
4918         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
4919         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
4920         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
4921         abbrev.c.
4922         * dwarf2/abbrev.h: New file.
4923         * dwarf2/abbrev.c: New file, from dwarf2read.c.
4924         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
4925
4926 2020-02-08  Tom Tromey  <tom@tromey.com>
4927
4928         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
4929         (dwarf2_section_size, dwarf2_get_section_info)
4930         (create_signatured_type_table_from_debug_names)
4931         (create_addrmap_from_aranges, read_debug_names_from_section)
4932         (get_gdb_index_contents_from_section, read_comp_unit_head)
4933         (error_check_comp_unit_head, read_abbrev_offset)
4934         (create_debug_type_hash_table, init_cu_die_reader)
4935         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
4936         (read_comp_units_from_section, create_cus_hash_table)
4937         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4938         (create_dwp_v2_section, dwarf2_rnglists_process)
4939         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
4940         (abbrev_table_read_table, read_indirect_string_at_offset_from)
4941         (read_indirect_string_from_dwz, read_addr_index_1)
4942         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
4943         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4944         (fill_in_loclist_baton): Update.
4945         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
4946         get_containing_section, get_bfd_owner, get_bfd_section,
4947         get_file_name, get_id, get_flags, empty, read>: Declare methods.
4948         (dwarf2_read_section, get_section_name, get_section_file_name)
4949         (get_containing_section, get_section_bfd_owner)
4950         (get_section_bfd_section, get_section_name, get_section_file_name)
4951         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
4952         declare.
4953         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
4954         (dwarf2_section_info::get_bfd_owner)
4955         (dwarf2_section_info::get_bfd_section)
4956         (dwarf2_section_info::get_name)
4957         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
4958         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
4959         (dwarf2_section_info::read): Now methods.
4960         * dwarf-index-write.c (class debug_names): Update.
4961
4962 2020-02-08  Tom Tromey  <tom@tromey.com>
4963
4964         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
4965         Move to dwarf2/section.h.
4966         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
4967         (get_section_bfd_section, get_section_name)
4968         (get_section_file_name, get_section_id, get_section_flags)
4969         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
4970         dwarf2/section.c.
4971         * dwarf2/section.h: New file.
4972         * dwarf2/section.c: New file, from dwarf2read.c.
4973         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
4974
4975 2020-02-08  Tom Tromey  <tom@tromey.com>
4976
4977         * dwarf2read.h (read_unsigned_leb128): Don't declare.
4978         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
4979         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
4980         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
4981         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
4982         * dwarf2/leb.h: New file, from dwarf2read.c.
4983         * dwarf2/leb.c: New file, from dwarf2read.c.
4984         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
4985         Remove.
4986         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
4987         (COMMON_SFILES): Add dwarf2/leb.c.
4988
4989 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
4990
4991         GDB 9.1 released.
4992
4993 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4994
4995         PR gdb/25190:
4996         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
4997         * gdb/remote.c (remote_console_output): Update.
4998         * gdb/ui-file.c (fputs_unfiltered): Rename to...
4999         (ui_file_puts): ...this.
5000         * gdb/ui-file.h (ui_file_puts): Add declaration.
5001         * gdb/utils.c (emit_style_escape): Update.
5002         (flush_wrap_buffer): Update.
5003         (fputs_maybe_filtered): Update.
5004         (fputs_unfiltered): Add function.
5005
5006 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
5007
5008         * gdb/event-loop.c (gdb_wait_for_event): Update.
5009         * gdb/printcmd.c (printf_command): Update.
5010         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
5011         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
5012         (gdb_os_flush_stderr): Update.
5013         * gdb/remote.c (remote_console_output): Update.
5014         * gdb/ui-file.c (gdb_flush): Rename to...
5015         (ui_file_flush): ...this.
5016         (stderr_file::write): Update.
5017         (stderr_file::puts): Update.
5018         * gdb/ui-file.h (gdb_flush): Rename to...
5019         (ui_file_flush): ...this.
5020         * gdb/utils.c (gdb_flush): Add function.
5021         * gdb/utils.h (gdb_flush): Add declaration.
5022
5023 2020-02-07  Tom Tromey  <tromey@adacore.com>
5024
5025         PR breakpoints/24915:
5026         * source.c (find_and_open_source): Do not check basenames_may_differ.
5027
5028 2020-02-07  Tom Tromey  <tom@tromey.com>
5029
5030         * README: Update gdbserver documentation.
5031         * gdbserver: Move to top level.
5032         * configure.tgt (build_gdbserver): Remove.
5033         * configure.ac: Remove --enable-gdbserver.
5034         * configure: Rebuild.
5035         * Makefile.in (distclean): Don't mention gdbserver.
5036
5037 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5038
5039         * source-cache.c (source_cache::ensure): Surround
5040         get_plain_source_lines with a try/catch.
5041         (source_cache::get_line_charpos): Get rid of try/catch
5042         and only check for the return value of "ensure".
5043         * tui/tui-source.c (tui_source_window::set_contents):
5044         Simplify "nlines" calculation.
5045
5046 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
5047
5048         * MAINTAINERS (Write After Approval): Add myself.
5049
5050 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5051
5052         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
5053         function call.
5054
5055 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
5056
5057         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
5058
5059 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
5060
5061         * nat/riscv-linux-tdesc.h: New file.
5062         * nat/riscv-linux-tdesc.c: New file, taking code from...
5063         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
5064         ... here.
5065         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
5066         NATDEPFILES.
5067
5068 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
5071         we don't set the fake simulator ptid to the null_ptid.
5072
5073 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
5074
5075         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
5076         * gdbthread.h (class thread_info) <resumed>: Likewise.
5077         * infrun.c (resume_1): Likewise.
5078         (proceed): Likewise.
5079         (infrun_thread_stop_requested): Likewise.
5080         (stop_all_threads): Likewise.
5081         (handle_inferior_event): Likewise.
5082         (restart_threads): Likewise.
5083         (finish_step_over): Likewise.
5084         (keep_going_stepped_thread): Likewise.
5085         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
5086         (linux_handle_extended_wait): Likewise.
5087         * record-btrace.c (get_thread_current_frame_id): Likewise.
5088         * record-full.c (record_full_wait_1): Likewise.
5089         * remote.c (remote_target::process_initial_stop_replies): Likewise.
5090         * target.c (target_resume): Likewise.
5091         * thread.c (set_running_thread): Likewise.
5092
5093 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
5094
5095         * f-valprint.c (f77_print_array_1): Changed datatype of index
5096         variable to LONGEST from int to enable it to contain bound
5097         values correctly.
5098
5099 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
5100
5101         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
5102         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
5103         offsets according to FLEN determined.
5104         (riscv_linux_nat_target::read_description): Determine FLEN
5105         dynamically.
5106         (riscv_linux_nat_target::fetch_registers): Size regset buffer
5107         according to FLEN determined.
5108         (riscv_linux_nat_target::store_registers): Likewise.
5109
5110 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
5111
5112         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
5113         when reg->group is empty and reggroup is not.
5114
5115 2020-01-31  Tom Tromey  <tromey@adacore.com>
5116
5117         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
5118         Call beneath target's mourn_inferior after unpushing.
5119
5120 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5121
5122         PR tui/9765
5123         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
5124         have enough lines to fill the screen, still return the lowest
5125         address we found.
5126
5127 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
5128
5129         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
5130         '-', '<', and '>' commands.
5131
5132 2020-01-29  Pedro Alves  <palves@redhat.com>
5133             Sergio Durigan Junior  <sergiodj@redhat.com>
5134
5135         * infcmd.c (construct_inferior_arguments): Assert that
5136         'argc' is greater than 0.
5137
5138 2020-01-29  Luis Machado  <luis.machado@linaro.org>
5139
5140         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
5141         (BRK_INSN_MASK): Define to 0xd4200000.
5142         (aarch64_program_breakpoint_here_p): New function.
5143         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
5144         * arch-utils.c (default_program_breakpoint_here_p): Moved from
5145         breakpoint.c.
5146         * arch-utils.h (default_program_breakpoint_here_p): Moved from
5147         breakpoint.h
5148         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
5149         call gdbarch_program_breakpoint_here_p.
5150         (program_breakpoint_here): Moved to arch-utils.c, renamed to
5151         default_program_breakpoint_here_p, changed return type to bool and
5152         simplified.
5153         * breakpoint.h (program_breakpoint_here): Moved prototype to
5154         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
5155         return type to bool.
5156         * gdbarch.c: Regenerate.
5157         * gdbarch.h: Regenerate.
5158         * gdbarch.sh (program_breakpoint_here_p): New method.
5159         * infrun.c (handle_signal_stop): Call
5160         gdbarch_program_breakpoint_here_p.
5161
5162 2020-01-26  Tom Tromey  <tom@tromey.com>
5163
5164         * ctfread.c (struct ctf_fp_info): Reindent.
5165         (_initialize_ctfread): Remove.
5166
5167 2020-01-26  Tom Tromey  <tom@tromey.com>
5168
5169         * psymtab.c (partial_map_expand_apply)
5170         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
5171         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
5172         (psym_print_stats, psym_expand_symtabs_for_function)
5173         (psym_map_symbol_filenames, psym_map_matching_symbols)
5174         (psym_expand_symtabs_matching)
5175         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
5176         (maintenance_check_psymtabs): Use new methods.
5177         * psympriv.h (struct partial_symtab) <readin_p,
5178         get_compunit_symtab>: New methods.
5179         <readin, compunit_symtab>: Remove members.
5180         (struct standard_psymtab): New.
5181         (struct legacy_psymtab): Derive from standard_psymtab.
5182         * dwarf2read.h (struct dwarf2_psymtab): Derive from
5183         standard_psymtab.
5184         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
5185
5186 2020-01-26  Tom Tromey  <tom@tromey.com>
5187
5188         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
5189         read_dependencies.  Add assert.
5190         * psymtab.c (partial_symtab::read_dependencies): New method.
5191         * psympriv.h (struct partial_symtab) <read_dependencies>: New
5192         method.
5193         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
5194         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
5195         read_dependencies.
5196         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
5197         Add assert.
5198
5199 2020-01-26  Tom Tromey  <tom@tromey.com>
5200
5201         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
5202         Call expand_psymtab.
5203         (xcoff_read_symtab): Call expand_psymtab.
5204         (xcoff_start_psymtab, xcoff_end_psymtab): Set
5205         legacy_expand_psymtab.
5206         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
5207         method.
5208         (struct legacy_psymtab) <expand_psymtab>: Implement.
5209         <legacy_expand_psymtab>: New member.
5210         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
5211         (parse_partial_symbols): Set legacy_expand_psymtab.
5212         (psymtab_to_symtab_1): Change argument order.  Call
5213         expand_psymtab.
5214         (new_psymtab): Set legacy_expand_psymtab.
5215         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
5216         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
5217         expand_psymtab.
5218         (dwarf2_psymtab::expand_psymtab): Rename from
5219         psymtab_to_symtab_1.  Call expand_psymtab.
5220         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
5221         (dbx_end_psymtab): Likewise.
5222         (dbx_psymtab_to_symtab_1): Change argument order. Call
5223         expand_psymtab.
5224         (dbx_read_symtab): Call expand_psymtab.
5225         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
5226         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
5227         (ctf_psymtab::read_symtab): Call expand_psymtab.
5228
5229 2020-01-26  Tom Tromey  <tom@tromey.com>
5230
5231         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
5232         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
5233         messages.
5234         * mdebugread.c (mdebug_read_symtab): Remove prints.
5235         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
5236         assert.
5237         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
5238
5239 2020-01-26  Tom Tromey  <tom@tromey.com>
5240
5241         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
5242         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
5243         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
5244         legacy_symtab.
5245         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
5246         * psymtab.c (psymtab_to_symtab): Call method.
5247         (dump_psymtab): Update.
5248         * psympriv.h (struct partial_symtab): Add virtual destructor.
5249         <read_symtab>: New method.
5250         (struct legacy_symtab): New.
5251         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
5252         (struct pst_map) <pst>: Now a legacy_psymtab.
5253         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
5254         (new_psymtab): Use legacy_psymtab.
5255         * dwarf2read.h (struct dwarf2_psymtab): New.
5256         (struct dwarf2_per_cu_data) <psymtab>: Use it.
5257         * dwarf2read.c (dwarf2_create_include_psymtab)
5258         (dwarf2_build_include_psymtabs, create_type_unit_group)
5259         (create_partial_symtab, process_psymtab_comp_unit_reader)
5260         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
5261         (set_partial_user): Use dwarf2_psymtab.
5262         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
5263         (psymtab_to_symtab_1, process_full_comp_unit)
5264         (process_full_type_unit, dwarf2_ranges_read)
5265         (dwarf2_get_pc_bounds, psymtab_include_file_name)
5266         (dwarf_decode_lines): Use dwarf2_psymtab.
5267         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
5268         (add_address_entry_worker, write_one_signatured_type)
5269         (recursively_count_psymbols, recursively_write_psymbols)
5270         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
5271         (write_debug_names): Likewise.
5272         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
5273         <pst>: Now a legacy_psymtab.
5274         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
5275         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
5276         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
5277         * ctfread.c (struct ctf_psymtab): New.
5278         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
5279         ctf_psymtab.
5280         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
5281         (create_partial_symtab): Return a ctf_psymtab.
5282         (scan_partial_symbols): Update.
5283
5284 2020-01-26  Tom Tromey  <tom@tromey.com>
5285
5286         * xcoffread.c (xcoff_start_psymtab): Use new.
5287         * psymtab.c (partial_symtab::partial_symtab): New constructor,
5288         renamed from start_psymtab_common.
5289         * psympriv.h (struct partial_symtab): Add new constructor.
5290         (start_psymtab_common): Don't declare.
5291         * mdebugread.c (parse_partial_symbols): Use new.
5292         * dwarf2read.c (create_partial_symtab): Use new.
5293         * dbxread.c (start_psymtab): Use new.
5294         * ctfread.c (create_partial_symtab): Use new.
5295
5296 2020-01-26  Tom Tromey  <tom@tromey.com>
5297
5298         * xcoffread.c (xcoff_end_psymtab): Use new.
5299         * psymtab.c (start_psymtab_common): Use new.
5300         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
5301         Update.
5302         * psympriv.h (struct partial_symtab): Add parameters to
5303         constructor.  Don't inline.
5304         (allocate_psymtab): Don't declare.
5305         * mdebugread.c (new_psymtab): Use new.
5306         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
5307         * dbxread.c (dbx_end_psymtab): Use new.
5308
5309 2020-01-26  Tom Tromey  <tom@tromey.com>
5310
5311         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5312         allocate_psymtab.  Update documentation.
5313         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5314         allocate_psymtab.  Do not use new.
5315         (allocate_psymtab): Use new.  Update.
5316
5317 2020-01-26  Tom Tromey  <tom@tromey.com>
5318
5319         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5320         * psymtab.c (psym_print_stats): Update.
5321         * psympriv.h (struct partial_symtab) <readin,
5322         psymtabs_addrmap_supported, anonymous>: Now bool.
5323         * mdebugread.c (psymtab_to_symtab_1): Update.
5324         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5325         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5326         (process_full_comp_unit, process_full_type_unit): Update.
5327         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5328         * ctfread.c (psymtab_to_symtab): Update.
5329
5330 2020-01-26  Tom Tromey  <tom@tromey.com>
5331
5332         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5333         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5334         * psymtab.c (psymtab_storage): Delete psymtabs.
5335         (psymtab_storage::allocate_psymtab): Use new.
5336         (psymtab_storage::discard_psymtab): Use delete.
5337         * psympriv.h (struct partial_symtab): Add constructor and
5338         initializers.
5339
5340 2020-01-26  Tom Tromey  <tom@tromey.com>
5341
5342         * machoread.c: Do not include psympriv.h.
5343
5344 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5345
5346         * NEWS: Mention the new option and the set/show commands.
5347
5348 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5349
5350         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5351         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5352         (validate_exec_file): New variables, enums, functions.
5353         (exec_file_locate_attach, print_section_info): Style the filenames.
5354         (_initialize_exec): Install show_exec_file_mismatch_command and
5355          set_exec_file_mismatch_command.
5356         * gdbcore.h (validate_exec_file): Declare.
5357         * infcmd.c (attach_command): Call validate_exec_file.
5358         * remote.c ( remote_target::remote_add_inferior): Likewise.
5359
5360 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5361
5362         * frame.c (find_frame_sal): Move call to get_next_frame into more
5363         inner scope.
5364         * inline-frame.c (inilne_state) <inline_state>: Update argument
5365         types.
5366         (inilne_state) <skipped_symbol>: Rename to...
5367         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
5368         (skip_inline_frames): Build vector of skipped symbols and use this
5369         to reate the inline_state.
5370         (inline_skipped_symbol): Add a comment and some assertions, fetch
5371         skipped symbol from the list.
5372
5373 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5374
5375         * buildsym.c (lte_is_less_than): Delete.
5376         (buildsym_compunit::end_symtab_with_blockvector): Create local
5377         lambda function to sort line table entries, and use
5378         std::stable_sort instead of std::sort.
5379         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
5380         markers when looking for a previous line.
5381
5382 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5383
5384         * dwarf2read.c (lnp_state_machine::record_line): Include
5385         end_sequence parameter in debug print out.  Record the line if we
5386         are at an end_sequence marker even if it's not the start of a
5387         statement.
5388         * symmisc.c (maintenance_print_one_line_table): Print end of
5389         sequence markers with 'END' not '0'.
5390
5391 2020-01-24  Pedro Alves  <palves@redhat.com>
5392
5393         PR gdb/25410
5394         * thread.c (scoped_restore_current_thread::restore): Use
5395         switch_to_inferior_no_thread.
5396         * exec.c: Include "progspace-and-thread.h".
5397         (add_target_sections, remove_target_sections):
5398         scoped_restore_current_pspace_and_thread instead of
5399         scoped_restore_current_thread.
5400         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
5401         and aspace to the inferior before calling clone_program_space.
5402         Remove stale comment.
5403
5404 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5405
5406         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
5407         (arm_netbsd_nat_target::fetch_registers): ...this.
5408         (arm_nbsd_nat_target::store_registers): Rename to...
5409         (arm_netbsd_nat_target::store_registers): ...this.
5410
5411 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5412
5413         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5414         register_t.
5415
5416 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5417
5418         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
5419         Update comment.
5420         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
5421         Likewise.
5422         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
5423         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
5424         the correct replacement (iterate_over_regset_sections).
5425         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
5426         Update comment.
5427
5428 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
5429
5430         PR gdb/23718
5431         * gdb/python/python.c (execute_gdb_command): Call
5432         async_enable_stdin in catch block.
5433
5434 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5435
5436         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
5437         SWITCH_THRU_ALL_UIS.
5438
5439 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5440
5441         PR tui/9765
5442         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
5443         comment, add extra parameter, and update to store previous symbol
5444         when appropriate.
5445         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
5446         add extra parameter.
5447         * tui/tui-disasm.c (tui_disassemble): Update header comment,
5448         remove unneeded parameter, add try/catch around gdb_print_insn,
5449         rewrite to add items to asm_lines vector.
5450         (tui_find_backward_disassembly_start_address): New function.
5451         (tui_find_disassembly_address): Updated throughout.
5452         (tui_disasm_window::set_contents): Update for changes to
5453         tui_disassemble.
5454         (tui_disasm_window::do_scroll_vertical): No need to adjust the
5455         number of lines to scroll.
5456
5457 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
5458
5459         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
5460         (SECT_OFF_DATA): Likewise.
5461         (SECT_OFF_RODATA): Likewise.
5462         (SECT_OFF_TEXT): Likewise.
5463         (SECT_OFF_BSS): Likewise.
5464         (struct objfile) <text_section_offset, data_section_offset>: New
5465         methods.
5466         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
5467         objfile::text_section_offset.
5468         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
5469         * coffread.c (coff_symtab_read): Likewise.
5470         (enter_linenos): Likewise.
5471         (process_coff_symbol): Likewise.
5472         * ctfread.c (get_objfile_text_range): Likewise.
5473         * dtrace-probe.c (dtrace_probe::get_relocated_address):
5474         Use objfile::data_section_offset.
5475         * dwarf2-frame.c (execute_cfa_program): Use
5476         objfile::text_section_offset.
5477         (dwarf2_frame_find_fde): Likewise.
5478         * dwarf2read.c (create_addrmap_from_index): Likewise.
5479         (create_addrmap_from_aranges): Likewise.
5480         (dw2_find_pc_sect_compunit_symtab): Likewise.
5481         (process_psymtab_comp_unit_reader): Likewise.
5482         (add_partial_symbol): Likewise.
5483         (add_partial_subprogram): Likewise.
5484         (process_full_comp_unit): Likewise.
5485         (read_file_scope): Likewise.
5486         (read_func_scope): Likewise.
5487         (read_lexical_block_scope): Likewise.
5488         (read_call_site_scope): Likewise.
5489         (dwarf2_rnglists_process): Likewise.
5490         (dwarf2_ranges_process): Likewise.
5491         (dwarf2_ranges_read): Likewise.
5492         (dwarf_decode_lines_1): Likewise.
5493         (new_symbol): Likewise.
5494         (dwarf2_fetch_die_loc_sect_off): Likewise.
5495         (dwarf2_per_cu_text_offset): Likewise.
5496         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5497         * hppa-tdep.c (read_unwind_info): Likewise.
5498         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5499         * psympriv.h (struct partial_symtab): Likewise.
5500         * psymtab.c (find_pc_sect_psymtab): Likewise.
5501         * solib-svr4.c (enable_break): Likewise.
5502         * stap-probe.c (relocate_address): Use
5503         objfile::data_section_offset.
5504         * xcoffread.c (enter_line_range): Use
5505         objfile::text_section_offset.
5506         (read_xcoff_symtab): Likewise.
5507
5508 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5509
5510         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5511         declaration to narrower scopes.
5512
5513 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5514
5515         * darwin-nat.h (struct darwin_exception_msg, enum
5516         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5517         Move up.
5518         (class darwin_nat_target) <wait_1, check_new_threads,
5519         decode_exception_message, decode_message, stop_inferior,
5520         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5521         * darwin-nat.c (darwin_check_new_threads): Rename to...
5522         (darwin_nat_target::check_new_threads): ... this.
5523         (darwin_suspend_inferior_it): Remove.
5524         (darwin_decode_exception_message): Rename to...
5525         (darwin_nat_target::decode_exception_message): ... this.
5526         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5527         (darwin_decode_message): Rename to...
5528         (darwin_nat_target::decode_message): ... this.
5529         (cancel_breakpoint): Rename to...
5530         (darwin_nat_target::cancel_breakpoint): ... this.
5531         (darwin_wait): Rename to...
5532         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5533         instead of iterate_over_inferiors.
5534         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5535         (darwin_stop_inferior): Rename to...
5536         (darwin_nat_target::stop_inferior): ... this.
5537         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5538         (darwin_init_thread_list): Rename to...
5539         (darwin_nat_target::init_thread_list): ... this.
5540         (darwin_ptrace_him): Rename to...
5541         (darwin_nat_target::ptrace_him): ... this.
5542         (darwin_nat_target::create_inferior): Pass lambda function to
5543         fork_inferior.
5544         (darwin_nat_target::detach): Call stop_inferior instead of
5545         darwin_stop_inferior.
5546         * fork-inferior.h (fork_inferior): Change init_trace_fun
5547         parameter to gdb::function_view.
5548         * fork-inferior.c (fork_inferior): Likewise.
5549
5550 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5551
5552         * i386-cygwin-tdep.c (core_process_module_section): Update.
5553         * windows-nat.c (struct lm_info_windows): Add text_offset.
5554         (windows_xfer_shared_libraries): Update.
5555         * windows-tdep.c (windows_xfer_shared_library):
5556         Add text_offset_cached argument.
5557         * windows-tdep.h (windows_xfer_shared_library): Update.
5558
5559 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5560
5561         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5562
5563 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5564
5565         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5566         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5567         replace with range-based for.
5568         (gdbsim_interrupt_inferior): Remove.
5569         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5570         with a range-based for.  Inline code from
5571         gdbsim_interrupt_inferior.
5572
5573 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5574
5575         * infrun.c (proceed): Fix indentation.
5576
5577 2020-01-21  Tom Tromey  <tromey@adacore.com>
5578
5579         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5580         * python/python.c (python_extension_ops): Update.
5581         (gdbpy_colorize): New function.
5582         * python/lib/gdb/__init__.py (colorize): New function.
5583         * extension.h (ext_lang_colorize): Declare.
5584         * extension.c (ext_lang_colorize): New function.
5585         * extension-priv.h (struct extension_language_ops) <colorize>: New
5586         member.
5587         * cli/cli-style.c (_initialize_cli_style): Update help text.
5588
5589 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5590
5591         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5592         <cond>: Change type to bool.
5593         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5594         (aarch64_displaced_step_cb): Likewise.
5595         (aarch64_displaced_step_tb): Likewise.
5596
5597 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5598
5599         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5600         output.
5601
5602 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5603
5604         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5605         <pc_adjust>: Adjust the documentation.
5606         (aarch64_displaced_step_fixup): Check if PC really moved before
5607         adjusting it.
5608
5609 2020-01-19  Tom Tromey  <tom@tromey.com>
5610
5611         * disasm.c (~gdb_disassembler): New destructor.
5612         (gdb_buffered_insn_length): Call disassemble_free_target.
5613         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5614         DISABLE_COPY_AND_ASSIGN.
5615
5616 2020-01-19  Tom Tromey  <tom@tromey.com>
5617
5618         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5619         (die_reader_func_ftype): Remove.
5620         (cutu_reader): New class.
5621         (dw2_get_file_names_reader): Remove "data" parameter.
5622         (dw2_get_file_names): Use cutu_reader.
5623         (create_debug_type_hash_table): Update.
5624         (read_cutu_die_from_dwo): Update comment.
5625         (lookup_dwo_unit): Add dwo_name parameter.
5626         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5627         die_reader_func_ftype and data parameters.
5628         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5629         Remove die_reader_func_ftype and data parameters.
5630         (~cutu_reader): New; from init_cutu_and_read_dies.
5631         (cutu_reader::cutu_reader): Rename from
5632         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5633         and data parameters.
5634         (init_cutu_and_read_dies_simple): Remove.
5635         (struct process_psymtab_comp_unit_data): Remove.
5636         (process_psymtab_comp_unit_reader): Remove data parameter; add
5637         want_partial_unit and pretend_language parameters.
5638         (process_psymtab_comp_unit): Use cutu_reader.
5639         (build_type_psymtabs_reader): Remove data parameter.
5640         (build_type_psymtabs_1): Use cutu_reader.
5641         (process_skeletonless_type_unit): Likewise.
5642         (load_partial_comp_unit_reader): Remove.
5643         (load_partial_comp_unit): Use cutu_reader.
5644         (load_full_comp_unit_reader): Remove.
5645         (load_full_comp_unit): Use cutu_reader.
5646         (struct create_dwo_cu_data): Remove.
5647         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5648         dwo_unit parameters.
5649         (create_cus_hash_table): Use cutu_reader.
5650         (struct dwarf2_read_addr_index_data): Remove.
5651         (dwarf2_read_addr_index_reader): Remove.
5652         (dwarf2_read_addr_index): Use cutu_reader.
5653         (read_signatured_type_reader): Remove.
5654         (read_signatured_type): Use cutu_reader.
5655
5656 2020-01-19  Tom Tromey  <tom@tromey.com>
5657
5658         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5659         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5660         (tui_wrefresh): Declare.
5661         * tui/tui-wingeneral.c (suppress_output): New global.
5662         (tui_suppress_output, ~tui_suppress_output): New constructor and
5663         destructor.
5664         (tui_wrefresh): New function.
5665         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5666         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5667         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5668         method.
5669         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5670         tui_wrefresh.
5671         (tui_data_window::no_refresh): New method.
5672         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5673         (tui_reg_command): Use tui_suppress_output
5674         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5675         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5676         method.
5677         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5678
5679 2020-01-19  Tom Tromey  <tom@tromey.com>
5680
5681         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5682         Handle case where symtab is null.
5683
5684 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5685
5686         * linux-fork.c (one_fork_p): Simplify.
5687
5688 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5689
5690         * top.c (struct qt_args): Remove.
5691         (kill_or_detach): Change return type to void, replace `void *`
5692         parameter with a proper one.
5693         (print_inferior_quit_action):  Likewise.
5694         (quit_confirm): Use range-based for loop to iterate over inferiors.
5695         (quit_force): Likewise.
5696
5697 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5698
5699         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5700         `void *` parameter with proper parameters.
5701         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5702         (print_one_inferior): Change return type to void, replace `void *`
5703         parameter with proper parameters.
5704         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5705         inferiors.
5706         (get_other_inferior): Remove.
5707         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5708         inferiors.
5709
5710 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5711
5712         * mi/mi-interp.c (report_initial_inferior): Remove.
5713         (mi_interp::init): Use range-based for to iterate over inferiors.
5714
5715 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5716
5717         * python/py-inferior.c (build_inferior_list): Remove.
5718         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5719
5720 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5721
5722         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5723         (btrace_stitch_trace): Likewise.
5724         * charset.c (intermediate_encoding): Likewise (vaild).
5725         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5726         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5727         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5728
5729 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5730
5731         * windows-tdep.c (windows_get_tlb_type):
5732         Add rtl_user_process_parameters type.
5733
5734 2020-01-16  Pedro Alves  <palves@redhat.com>
5735             Norbert Lange  <nolange79@gmail.com>
5736
5737         PR build/24805
5738         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5739         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5740         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5741         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5742         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5743         (ps_plog): Redeclare exported functions with default visibility.
5744
5745 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5746
5747         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5748         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5749
5750 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5751
5752         * infcmd.c (post_create_inferior): Use get_thread_regcache
5753         instead of get_current_regcache.
5754
5755 2020-01-14  Tom Tromey  <tom@tromey.com>
5756
5757         PR symtab/12535:
5758         * python/python.c (gdbpy_decode_line): Treat empty string the same
5759         as no argument.
5760
5761 2020-01-14  Tom Tromey  <tom@tromey.com>
5762
5763         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
5764
5765 2020-01-14  Tom Tromey  <tom@tromey.com>
5766
5767         * nat/linux-btrace.c: Don't include <config.h>.
5768         * nat/linux-ptrace.c: Don't include <config.h>.
5769         * nat/x86-linux-dregs.c: Don't include <config.h>.
5770
5771 2020-01-14  Tom Tromey  <tom@tromey.com>
5772
5773         * configure: Rebuild.
5774         * configure.ac: Move many checks to ../gdbsupport/common.m4.
5775
5776 2020-01-14  Tom Tromey  <tom@tromey.com>
5777
5778         * nat/x86-linux-dregs.c: Include configh.h.
5779         * nat/linux-ptrace.c: Include configh.h.
5780         * nat/linux-btrace.c: Include configh.h.
5781         * defs.h: Include config.h, bfd.h.
5782         * configure.ac: Don't source common.host.
5783         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
5784         * configure: Rebuild.
5785         * acinclude.m4: Update path.
5786         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
5787         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
5788         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
5789         (CLIBS): Add LIBSUPPORT.
5790         (CDEPS): Likewise.
5791         (COMMON_SFILES): Remove gdbsupport files.
5792         (HFILES_NO_SRCDIR): Likewise.
5793         (stamp-version): Update path to create-version.sh.
5794         (ALLDEPFILES): Remove gdbsupport files.
5795
5796 2020-01-14  Tom Tromey  <tom@tromey.com>
5797
5798         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
5799         USE_WIN32API when needed.
5800         * configure.ac (USE_WIN32API): Don't define.
5801         (WIN32LIBS): Use WIN32APILIBS.
5802         * configure: Rebuild.
5803
5804 2020-01-14  Tom Tromey  <tom@tromey.com>
5805
5806         * configure: Rebuild.
5807         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
5808
5809 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5810
5811         * skip.c (skip_function_command): Make skip w/o arguments use the
5812         name of the inlined function if pc is inside any inlined function.
5813
5814 2020-01-14  Luis Machado  <luis.machado@linaro.org>
5815
5816         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
5817         * infrun.c (resume_1): Likewise.
5818         (handle_inferior_event): Remove stale comment.
5819         * linux-nat.c (linux_nat_target::resume): Update comments.
5820         (save_stop_reason): Likewise.
5821         (linux_nat_filter_event): Likewise.
5822         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
5823
5824 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5825
5826         * elfread.c (record_minimal_symbol): Set section index to 0 for
5827         non-allocatable sections.
5828
5829
5830 2020-01-13  Ali Tamur <tamur@google.com>
5831
5832         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
5833         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
5834         to gdb::optional.  Update comments.
5835         (dwo_file): Update comments.
5836         (read_attribute): Update API to take an additional out parameter,
5837         need_reprocess.  This is used to mark attributes that need other
5838         attributes (e.g. str_offsets_base) for correct computation which may not
5839         have been read yet.
5840         (read_attribute_reprocess): New function declaration.
5841         (read_addr_index): Likewise.
5842         (read_dwo_str_index): Likewise.
5843         (read_stub_str_index): Likewise.
5844         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5845         (lookup_addr_base): New function definition.
5846         (lookup_ranges_base): Likewise.
5847         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5848         lookup_ranges_base.
5849         (init_cutu_and_read_dies): Update comments.
5850         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5851         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5852         Update comments.
5853         (init_cutu_and_read_dies_simple): Reflect API changes.
5854         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5855         (create_cus_hash_table): Change API to take parent compile unit.
5856         Reflect API changes.
5857         (open_and_init_dwo_file): Reflect API changes.
5858         (dwarf2_get_pc_bounds): Update comments.
5859         (dwarf2_record_block_ranges): Likewise.
5860         (read_full_die_1): Change implementation to reprocess attributes that
5861         need str_offsets_base and addr_base.
5862         (partial_die_info::read): Likewise.
5863         (read_attribute_reprocess): New function definition.
5864         (read_attribute_value): Change API to take an additional out parameter,
5865         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5866         when a non-dwo compile unit has index based attributes.
5867         (read_attribute): Reflect API changes.
5868         (read_addr_index_1): Reflect API changes.  Update comments.
5869         (dwarf2_read_addr_index_data): Reflect API changes.
5870         (dwarf2_read_addr_index): Likewise.
5871         (read_str_index): Change API and implementation.  This becomes a helper
5872         to be used by the new string index related methods.  Update error
5873         message and comments.
5874         (read_dwo_str_index): New function definition.
5875         (read_stub_str_index): Likewise.
5876         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5877         * symfile.h (dwarf2_debug_sections): Likewise.
5878         * xcoffread.c (dwarf2_debug_sections): Likewise.
5879
5880 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5881
5882         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5883         core_reg_sect type to gdb_byte *.
5884         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5885         * cris-tdep.c (fetch_core_registers): Likewise.
5886         * corelow.c (core_target::get_core_register_section): Change
5887         type of `contents` to gdb::byte_vector.
5888
5889 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5890
5891         * tui/tui-wingeneral.c (box_win): Position the title in the center
5892         of the border.
5893
5894 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5895
5896         * corelow.c (core_target::get_core_register_section): Use
5897           std::vector instead of alloca.
5898
5899 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5900
5901         * warning.m4: Add -Wmissing-declarations to build_warnings.
5902         * configure: Re-generate.
5903
5904 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5905
5906         * python/python.c (init__gdb_module): Add declaration.
5907
5908 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5909
5910         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
5911         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
5912         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
5913         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
5914         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
5915         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
5916         * ada-exp.y (_initialize_ada_exp): Add declaration.
5917         * ada-lang.c (_initialize_ada_language): Add declaration.
5918         * ada-tasks.c (_initialize_tasks): Add declaration.
5919         * agent.c (_initialize_agent): Add declaration.
5920         * aix-thread.c (_initialize_aix_thread): Add declaration.
5921         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
5922         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
5923         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
5924         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
5925         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
5926         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
5927         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
5928         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
5929         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
5930         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
5931         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
5932         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
5933         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
5934         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
5935         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
5936         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
5937         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
5938         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
5939         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
5940         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
5941         * annotate.c (_initialize_annotate): Add declaration.
5942         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
5943         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
5944         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
5945         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
5946         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
5947         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
5948         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
5949         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
5950         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
5951         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
5952         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
5953         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
5954         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
5955         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
5956         * auto-load.c (_initialize_auto_load): Add declaration.
5957         * auxv.c (_initialize_auxv): Add declaration.
5958         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
5959         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
5960         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
5961         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
5962         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
5963         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
5964         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
5965         * breakpoint.c (_initialize_breakpoint): Add declaration.
5966         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
5967         * btrace.c (_initialize_btrace): Add declaration.
5968         * charset.c (_initialize_charset): Add declaration.
5969         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
5970         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
5971         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
5972         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
5973         * cli/cli-script.c (_initialize_cli_script): Add declaration.
5974         * cli/cli-style.c (_initialize_cli_style): Add declaration.
5975         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
5976         * coffread.c (_initialize_coffread): Add declaration.
5977         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
5978         * compile/compile.c (_initialize_compile): Add declaration.
5979         * complaints.c (_initialize_complaints): Add declaration.
5980         * completer.c (_initialize_completer): Add declaration.
5981         * copying.c (_initialize_copying): Add declaration.
5982         * corefile.c (_initialize_core): Add declaration.
5983         * corelow.c (_initialize_corelow): Add declaration.
5984         * cp-abi.c (_initialize_cp_abi): Add declaration.
5985         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
5986         * cp-support.c (_initialize_cp_support): Add declaration.
5987         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
5988         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
5989         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
5990         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
5991         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
5992         * ctfread.c (_initialize_ctfread): Add declaration.
5993         * d-lang.c (_initialize_d_language): Add declaration.
5994         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
5995         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
5996         * dbxread.c (_initialize_dbxread): Add declaration.
5997         * dcache.c (_initialize_dcache): Add declaration.
5998         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
5999         * disasm.c (_initialize_disasm): Add declaration.
6000         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
6001         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
6002         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
6003         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
6004         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
6005         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
6006         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
6007         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
6008         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
6009         * elfread.c (_initialize_elfread): Add declaration.
6010         * exec.c (_initialize_exec): Add declaration.
6011         * extension.c (_initialize_extension): Add declaration.
6012         * f-lang.c (_initialize_f_language): Add declaration.
6013         * f-valprint.c (_initialize_f_valprint): Add declaration.
6014         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
6015         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
6016         * filesystem.c (_initialize_filesystem): Add declaration.
6017         * findcmd.c (_initialize_mem_search): Add declaration.
6018         * findvar.c (_initialize_findvar): Add declaration.
6019         * fork-child.c (_initialize_fork_child): Add declaration.
6020         * frame-base.c (_initialize_frame_base): Add declaration.
6021         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
6022         * frame.c (_initialize_frame): Add declaration.
6023         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
6024         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
6025         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
6026         * gcore.c (_initialize_gcore): Add declaration.
6027         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
6028         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
6029         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
6030         * gdbarch.c (_initialize_gdbarch): Add declaration.
6031         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
6032         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
6033         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
6034         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
6035         * go-lang.c (_initialize_go_language): Add declaration.
6036         * go32-nat.c (_initialize_go32_nat): Add declaration.
6037         * guile/guile.c (_initialize_guile): Add declaration.
6038         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
6039         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
6040         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
6041         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
6042         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
6043         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
6044         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
6045         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
6046         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
6047         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
6048         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
6049         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
6050         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
6051         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
6052         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
6053         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
6054         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
6055         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
6056         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
6057         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
6058         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
6059         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
6060         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
6061         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
6062         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
6063         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
6064         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
6065         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
6066         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
6067         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
6068         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
6069         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
6070         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
6071         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
6072         * infcall.c (_initialize_infcall): Add declaration.
6073         * infcmd.c (_initialize_infcmd): Add declaration.
6074         * inflow.c (_initialize_inflow): Add declaration.
6075         * infrun.c (_initialize_infrun): Add declaration.
6076         * interps.c (_initialize_interpreter): Add declaration.
6077         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
6078         * jit.c (_initialize_jit): Add declaration.
6079         * language.c (_initialize_language): Add declaration.
6080         * linux-fork.c (_initialize_linux_fork): Add declaration.
6081         * linux-nat.c (_initialize_linux_nat): Add declaration.
6082         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
6083         * linux-thread-db.c (_initialize_thread_db): Add declaration.
6084         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
6085         * m2-lang.c (_initialize_m2_language): Add declaration.
6086         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
6087         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
6088         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
6089         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
6090         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
6091         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
6092         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
6093         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
6094         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
6095         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
6096         * machoread.c (_initialize_machoread): Add declaration.
6097         * macrocmd.c (_initialize_macrocmd): Add declaration.
6098         * macroscope.c (_initialize_macroscope): Add declaration.
6099         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
6100         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
6101         * maint.c (_initialize_maint_cmds): Add declaration.
6102         * mdebugread.c (_initialize_mdebugread): Add declaration.
6103         * memattr.c (_initialize_mem): Add declaration.
6104         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
6105         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
6106         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
6107         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
6108         * mi/mi-main.c (_initialize_mi_main): Add declaration.
6109         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
6110         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
6111         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
6112         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
6113         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
6114         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
6115         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
6116         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
6117         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
6118         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
6119         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
6120         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
6121         * mipsread.c (_initialize_mipsread): Add declaration.
6122         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
6123         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
6124         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
6125         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
6126         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
6127         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
6128         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
6129         * nto-procfs.c (_initialize_procfs): Add declaration.
6130         * objc-lang.c (_initialize_objc_language): Add declaration.
6131         * observable.c (_initialize_observer): Add declaration.
6132         * opencl-lang.c (_initialize_opencl_language): Add declaration.
6133         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
6134         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
6135         * osabi.c (_initialize_gdb_osabi): Add declaration.
6136         * osdata.c (_initialize_osdata): Add declaration.
6137         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
6138         * parse.c (_initialize_parse): Add declaration.
6139         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
6140         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
6141         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
6142         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
6143         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
6144         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
6145         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
6146         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
6147         * printcmd.c (_initialize_printcmd): Add declaration.
6148         * probe.c (_initialize_probe): Add declaration.
6149         * proc-api.c (_initialize_proc_api): Add declaration.
6150         * proc-events.c (_initialize_proc_events): Add declaration.
6151         * proc-service.c (_initialize_proc_service): Add declaration.
6152         * procfs.c (_initialize_procfs): Add declaration.
6153         * producer.c (_initialize_producer): Add declaration.
6154         * psymtab.c (_initialize_psymtab): Add declaration.
6155         * python/python.c (_initialize_python): Add declaration.
6156         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
6157         * record-btrace.c (_initialize_record_btrace): Add declaration.
6158         * record-full.c (_initialize_record_full): Add declaration.
6159         * record.c (_initialize_record): Add declaration.
6160         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
6161         * regcache.c (_initialize_regcache): Add declaration.
6162         * reggroups.c (_initialize_reggroup): Add declaration.
6163         * remote-notif.c (_initialize_notif): Add declaration.
6164         * remote-sim.c (_initialize_remote_sim): Add declaration.
6165         * remote.c (_initialize_remote): Add declaration.
6166         * reverse.c (_initialize_reverse): Add declaration.
6167         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
6168         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
6169         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
6170         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
6171         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
6172         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
6173         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
6174         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
6175         Add declaration.
6176         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
6177         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
6178         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
6179         * rust-exp.y (_initialize_rust_exp): Add declaration.
6180         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
6181         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
6182         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
6183         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
6184         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
6185         * score-tdep.c (_initialize_score_tdep): Add declaration.
6186         * ser-go32.c (_initialize_ser_dos): Add declaration.
6187         * ser-mingw.c (_initialize_ser_windows): Add declaration.
6188         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
6189         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
6190         * ser-uds.c (_initialize_ser_socket): Add declaration.
6191         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
6192         * serial.c (_initialize_serial): Add declaration.
6193         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
6194         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
6195         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
6196         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
6197         * skip.c (_initialize_step_skip): Add declaration.
6198         * sol-thread.c (_initialize_sol_thread): Add declaration.
6199         * solib-aix.c (_initialize_solib_aix): Add declaration.
6200         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
6201         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
6202         * solib-frv.c (_initialize_frv_solib): Add declaration.
6203         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
6204         * solib-target.c (_initialize_solib_target): Add declaration.
6205         * solib.c (_initialize_solib): Add declaration.
6206         * source-cache.c (_initialize_source_cache): Add declaration.
6207         * source.c (_initialize_source): Add declaration.
6208         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
6209         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
6210         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
6211         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
6212         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
6213         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
6214         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
6215         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
6216         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
6217         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
6218         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
6219         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
6220         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
6221         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
6222         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
6223         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
6224         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
6225         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
6226         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
6227         * stabsread.c (_initialize_stabsread): Add declaration.
6228         * stack.c (_initialize_stack): Add declaration.
6229         * stap-probe.c (_initialize_stap_probe): Add declaration.
6230         * std-regs.c (_initialize_frame_reg): Add declaration.
6231         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
6232         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
6233         * symfile.c (_initialize_symfile): Add declaration.
6234         * symmisc.c (_initialize_symmisc): Add declaration.
6235         * symtab.c (_initialize_symtab): Add declaration.
6236         * target.c (_initialize_target): Add declaration.
6237         * target-connection.c (_initialize_target_connection): Add
6238         declaration.
6239         * target-dcache.c (_initialize_target_dcache): Add declaration.
6240         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
6241         * thread.c (_initialize_thread): Add declaration.
6242         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
6243         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
6244         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
6245         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
6246         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
6247         * tracectf.c (_initialize_ctf): Add declaration.
6248         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
6249         * tracefile.c (_initialize_tracefile): Add declaration.
6250         * tracepoint.c (_initialize_tracepoint): Add declaration.
6251         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
6252         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
6253         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
6254         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
6255         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
6256         * tui/tui-win.c (_initialize_tui_win): Add declaration.
6257         * tui/tui.c (_initialize_tui): Add declaration.
6258         * typeprint.c (_initialize_typeprint): Add declaration.
6259         * ui-style.c (_initialize_ui_style): Add declaration.
6260         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
6261         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
6262         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
6263         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
6264         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
6265         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
6266         * unittests/filtered_iterator-selftests.c
6267         (_initialize_filtered_iterator_selftests): Add declaration.
6268         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
6269         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
6270         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
6271         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
6272         * unittests/main-thread-selftests.c
6273         (_initialize_main_thread_selftests): Add declaration.
6274         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
6275         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
6276         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
6277         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
6278         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
6279         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
6280         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
6281         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
6282         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
6283         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
6284         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
6285         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
6286         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
6287         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
6288         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
6289         declaration.
6290         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
6291         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
6292         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
6293         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
6294         * user-regs.c (_initialize_user_regs): Add declaration.
6295         * utils.c (_initialize_utils): Add declaration.
6296         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
6297         * valops.c (_initialize_valops): Add declaration.
6298         * valprint.c (_initialize_valprint): Add declaration.
6299         * value.c (_initialize_values): Add declaration.
6300         * varobj.c (_initialize_varobj): Add declaration.
6301         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
6302         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
6303         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
6304         * windows-nat.c (_initialize_windows_nat): Add declaration.
6305         (_initialize_check_for_gdb_ini): Add declaration.
6306         (_initialize_loadable): Add declaration.
6307         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
6308         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
6309         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6310         * xcoffread.c (_initialize_xcoffread): Add declaration.
6311         * xml-support.c (_initialize_xml_support): Add declaration.
6312         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6313         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6314         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6315         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6316
6317 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6318
6319         * regformats/regdat.sh: Generate declaration for init function.
6320
6321 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6322
6323         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6324         up.
6325         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6326         close_one_inferior>: New methods.
6327         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6328         pass down target to find_inferior_pid.
6329         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6330         Pass down target to find_inferior_ptid.
6331         (gdbsim_target::create_inferior): Pass down target to
6332         add_thread_silent.
6333         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6334         target down to find_inferior_ptid and switch_to_thread.
6335         (gdbsim_target::close): Update to call close_one_inferior.
6336         (struct resume_data): Remove.
6337         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6338         directly, rather than through a void pointer.
6339         (gdbsim_target::resume): Update to call resume_one_inferior.
6340
6341 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6342
6343         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6344
6345 2020-01-12  Pedro Alves  <palves@redhat.com>
6346
6347         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6348         directly for the current inferior instead of
6349         discard_all_inferiors.
6350         (discard_all_inferiors): Delete.
6351
6352 2020-01-11  Tom Tromey  <tom@tromey.com>
6353
6354         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6355         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6356         deprecated_safe_get_selected_frame.
6357
6358 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6359
6360         * inferior.c (print_inferior): Switch inferior before printing it.
6361
6362 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
6363             Pedro Alves  <palves@redhat.com>
6364
6365         * progspace-and-thread.c (switch_to_program_space_and_thread):
6366         Assert there's an inferior for PSPACE.  Use
6367         switch_to_inferior_no_thread to switch the inferior too.
6368         * progspace.c (program_space::~program_space): Call
6369         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
6370         (program_space::free_all_objfiles): Don't call clear_symtab_users
6371         here.
6372         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
6373
6374 2020-01-10  Pedro Alves  <palves@redhat.com>
6375
6376         * NEWS: Mention multi-target debugging, "info connections", and
6377         "add-inferior -no-connection".
6378
6379 2020-01-10  Pedro Alves  <palves@redhat.com>
6380
6381         * infrun.c: Include "target-connection.h".
6382         (check_multi_target_resumption): New.
6383         (proceed): Call it.
6384         * target-connection.c (make_target_connection_string): Make
6385         extern.
6386         * target-connection.h (make_target_connection_string): Declare.
6387
6388 2020-01-10  Pedro Alves  <palves@redhat.com>
6389
6390         * Makefile.in (COMMON_SFILES): Add target-connection.c.
6391         * inferior.c (uiout_field_connection): New function.
6392         (print_inferior): Add new "connection-id" column.
6393         (add_inferior_command): Show connection number/string of added
6394         inferior.
6395         * process-stratum-target.h
6396         (process_stratum_target::connection_string): New virtual method.
6397         (process_stratum_target::connection_number): New field.
6398         * remote.c (remote_target::connection_string): New override.
6399         * target-connection.c: New file.
6400         * target-connection.h: New file.
6401         * target.c (decref_target): Remove process_stratum targets from
6402         the connection list.
6403         (target_stack::push): Add process_stratum targets to the
6404         connection list.
6405
6406 2020-01-10  Pedro Alves  <palves@redhat.com>
6407
6408         Revert:
6409         2016-04-12  Pedro Alves  <palves@redhat.com>
6410         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
6411         Remove references to name.
6412         * serial.h (struct serial) <name>: Delete.
6413
6414 2020-01-10  Pedro Alves  <palves@redhat.com>
6415
6416         * gdbarch-selftests.c (register_to_value_test): Remove "target
6417         already pushed" check.
6418
6419 2020-01-10  Pedro Alves  <palves@redhat.com>
6420             John Baldwin  <jhb@FreeBSD.org>
6421
6422         * aarch64-linux-nat.c
6423         (aarch64_linux_nat_target::thread_architecture): Adjust.
6424         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
6425         (task_command_1): Likewise.
6426         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
6427         (aix_thread_target::wait, aix_thread_target::fetch_registers)
6428         (aix_thread_target::store_registers)
6429         (aix_thread_target::thread_alive): Adjust.
6430         * amd64-fbsd-tdep.c: Include "inferior.h".
6431         (amd64fbsd_get_thread_local_address): Pass down target.
6432         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
6433         thread's gdbarch instead of target_gdbarch.
6434         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
6435         get_last_target_status.
6436         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
6437         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
6438         inferiors.
6439         (update_inserted_breakpoint_locations): Skip if inferiors with no
6440         execution.
6441         (update_global_location_list): When handling moribund locations,
6442         find representative inferior for location's pspace, and use thread
6443         count of its process_stratum target.
6444         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
6445         * bsd-uthread.c (bsd_uthread_target::wait): Use
6446         as_process_stratum_target and adjust thread_change_ptid and
6447         add_thread calls.
6448         (bsd_uthread_target::update_thread_list): Use
6449         as_process_stratum_target and adjust find_thread_ptid,
6450         thread_change_ptid and add_thread calls.
6451         * btrace.c (maint_btrace_packet_history_cmd): Adjust
6452         find_thread_ptid call.
6453         * corelow.c (add_to_thread_list): Adjust add_thread call.
6454         (core_target_open): Adjust add_thread_silent and thread_count
6455         calls.
6456         (core_target::pid_to_str): Adjust find_inferior_ptid call.
6457         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
6458         * event-top.c (async_disconnect): Pop targets from all inferiors.
6459         * exec.c (add_target_sections): Push exec target on all inferiors
6460         sharing the program space.
6461         (remove_target_sections): Remove the exec target from all
6462         inferiors sharing the program space.
6463         (exec_on_vfork): New.
6464         * exec.h (exec_on_vfork): Declare.
6465         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
6466         Pass it down.
6467         (fbsd_nat_target::update_thread_list): Adjust.
6468         (fbsd_nat_target::resume): Adjust.
6469         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
6470         down.
6471         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
6472         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
6473         get_thread_arch_regcache call.
6474         * fork-child.c (gdb_startup_inferior): Pass target down to
6475         startup_inferior and set_executing.
6476         * gdbthread.h (struct process_stratum_target): Forward declare.
6477         (add_thread, add_thread_silent, add_thread_with_info)
6478         (in_thread_list): Add process_stratum_target parameter.
6479         (find_thread_ptid(inferior*, ptid_t)): New overload.
6480         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
6481         parameter.
6482         (all_threads()): Delete overload.
6483         (all_threads, all_non_exited_threads): Add process_stratum_target
6484         parameter.
6485         (all_threads_safe): Use brace initialization.
6486         (thread_count): Add process_stratum_target parameter.
6487         (set_resumed, set_running, set_stop_requested, set_executing)
6488         (threads_are_executing, finish_thread_state): Add
6489         process_stratum_target parameter.
6490         (switch_to_thread): Use is_current_thread.
6491         * i386-fbsd-tdep.c: Include "inferior.h".
6492         (i386fbsd_get_thread_local_address): Pass down target.
6493         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6494         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6495         have_inferiors check.
6496         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6497         (inf_ptrace_target::attach): Adjust.
6498         * infcall.c (run_inferior_call): Adjust.
6499         * infcmd.c (run_command_1): Pass target to
6500         scoped_finish_thread_state.
6501         (proceed_thread_callback): Skip inferiors with no execution.
6502         (continue_command): Rename 'all_threads' local to avoid hiding
6503         'all_threads' function.  Adjust get_last_target_status call.
6504         (prepare_one_step): Adjust set_running call.
6505         (signal_command): Use user_visible_resume_target.  Compare thread
6506         pointers instead of inferior_ptid.
6507         (info_program_command): Adjust to pass down target.
6508         (attach_command): Mark target's 'thread_executing' flag.
6509         (stop_current_target_threads_ns): New, factored out from ...
6510         (interrupt_target_1): ... this.  Switch inferior before making
6511         target calls.
6512         * inferior-iter.h
6513         (struct all_inferiors_iterator, struct all_inferiors_range)
6514         (struct all_inferiors_safe_range)
6515         (struct all_non_exited_inferiors_range): Filter on
6516         process_stratum_target too.  Remove explicit.
6517         * inferior.c (inferior::inferior): Push dummy target on target
6518         stack.
6519         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6520         Add process_stratum_target parameter, and pass it down.
6521         (have_live_inferiors): Adjust.
6522         (switch_to_inferior_and_push_target): New.
6523         (add_inferior_command, clone_inferior_command): Handle
6524         "-no-connection" parameter.  Use
6525         switch_to_inferior_and_push_target.
6526         (_initialize_inferior): Mention "-no-connection" option in
6527         the help of "add-inferior" and "clone-inferior" commands.
6528         * inferior.h: Include "process-stratum-target.h".
6529         (interrupt_target_1): Use bool.
6530         (struct inferior) <push_target, unpush_target, target_is_pushed,
6531         find_target_beneath, top_target, process_target, target_at,
6532         m_stack>: New.
6533         (discard_all_inferiors): Delete.
6534         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6535         (all_inferiors, all_non_exited_inferiors): Add
6536         process_stratum_target parameter.
6537         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6538         (target_last_proc_target): New global.
6539         (follow_fork_inferior): Push target on new inferior.  Pass target
6540         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6541         reference count.
6542         (follow_fork): Adjust get_last_target_status call.  Also consider
6543         target.
6544         (follow_exec): Push target on new inferior.
6545         (struct execution_control_state) <target>: New field.
6546         (user_visible_resume_target): New.
6547         (do_target_resume): Call target_async.
6548         (resume_1): Set target's threads_executing flag.  Consider resume
6549         target.
6550         (commit_resume_all_targets): New.
6551         (proceed): Also consider resume target.  Skip threads of inferiors
6552         with no execution.  Commit resumtion in all targets.
6553         (start_remote): Pass current inferior to wait_for_inferior.
6554         (infrun_thread_stop_requested): Consider target as well.  Pass
6555         thread_info pointer to clear_inline_frame_state instead of ptid.
6556         (infrun_thread_thread_exit): Consider target as well.
6557         (random_pending_event_thread): New inferior parameter.  Use it.
6558         (do_target_wait): Rename to ...
6559         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6560         down.
6561         (threads_are_resumed_pending_p, do_target_wait): New.
6562         (prepare_for_detach): Adjust calls.
6563         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6564         do_target_wait_1 instead of do_target_wait.
6565         (fetch_inferior_event): Adjust.  Switch to representative
6566         inferior.  Pass target down.
6567         (set_last_target_status): Add process_stratum_target parameter.
6568         Save target in global.
6569         (get_last_target_status): Add process_stratum_target parameter and
6570         handle it.
6571         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6572         (context_switch): Check inferior_ptid == null_ptid before calling
6573         inferior_thread().
6574         (get_inferior_stop_soon): Pass down target.
6575         (wait_one): Rename to ...
6576         (poll_one_curr_target): ... this.
6577         (struct wait_one_event): New.
6578         (wait_one): New.
6579         (stop_all_threads): Adjust.
6580         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6581         event's target.
6582         (switch_back_to_stepped_thread): Also consider target.
6583         (print_stop_event): Update.
6584         (normal_stop): Update.  Also consider the resume target.
6585         * infrun.h (wait_for_inferior): Remove declaration.
6586         (user_visible_resume_target): New declaration.
6587         (get_last_target_status, set_last_target_status): New
6588         process_stratum_target parameter.
6589         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6590         process_stratum_target parameter, and use it.
6591         (clear_inline_frame_state (thread_info*)): New.
6592         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6593         process_stratum_target parameter.
6594         (clear_inline_frame_state (thread_info*)): Declare.
6595         * linux-fork.c (delete_checkpoint_command): Pass target down to
6596         find_thread_ptid.
6597         (checkpoint_command): Adjust.
6598         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6599         instead of just tweaking inferior_ptid.
6600         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6601         (exit_lwp): Pass target down to find_thread_ptid.
6602         (attach_proc_task_lwp_callback): Pass target down to
6603         add_thread/set_running/set_executing.
6604         (linux_nat_target::attach): Pass target down to
6605         thread_change_ptid.
6606         (get_detach_signal): Pass target down to find_thread_ptid.
6607         Consider last target status's target.
6608         (linux_resume_one_lwp_throw, resume_lwp)
6609         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6610         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6611         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6612         (linux_nat_target::async_wait_fd): New.
6613         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6614         target down.
6615         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6616         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6617         * linux-thread-db.c (struct thread_db_info::process_target): New
6618         field.
6619         (add_thread_db_info): Save target.
6620         (get_thread_db_info): New process_stratum_target parameter.  Also
6621         match target.
6622         (delete_thread_db_info): New process_stratum_target parameter.
6623         Also match target.
6624         (thread_from_lwp): Adjust to pass down target.
6625         (thread_db_notice_clone): Pass down target.
6626         (check_thread_db_callback): Pass down target.
6627         (try_thread_db_load_1): Always push the thread_db target.
6628         (try_thread_db_load, record_thread): Pass target down.
6629         (thread_db_target::detach): Pass target down.  Always unpush the
6630         thread_db target.
6631         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6632         target down.  Always unpush the thread_db target.
6633         (find_new_threads_callback, thread_db_find_new_threads_2)
6634         (thread_db_target::update_thread_list): Pass target down.
6635         (thread_db_target::pid_to_str): Pass current inferior down.
6636         (thread_db_target::get_thread_local_address): Pass target down.
6637         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6638         target down.
6639         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6640         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6641         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6642         (procfs_init_inferior): Rename to ...
6643         (procfs_target::procfs_init_inferior): ... this and adjust.
6644         (procfs_target::create_inferior, procfs_notice_thread)
6645         (procfs_do_thread_registers): Adjust.
6646         * ppc-fbsd-tdep.c: Include "inferior.h".
6647         (ppcfbsd_get_thread_local_address): Pass down target.
6648         * proc-service.c (ps_xfer_memory): Switch current inferior and
6649         program space as well.
6650         (get_ps_regcache): Pass target down.
6651         * process-stratum-target.c
6652         (process_stratum_target::thread_address_space)
6653         (process_stratum_target::thread_architecture): Pass target down.
6654         * process-stratum-target.h
6655         (process_stratum_target::threads_executing): New field.
6656         (as_process_stratum_target): New.
6657         * ravenscar-thread.c
6658         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6659         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6660         down.
6661         * record-btrace.c (record_btrace_target::info_record): Adjust.
6662         (record_btrace_target::record_method)
6663         (record_btrace_target::record_is_replaying)
6664         (record_btrace_target::fetch_registers)
6665         (get_thread_current_frame_id, record_btrace_target::resume)
6666         (record_btrace_target::wait, record_btrace_target::stop): Pass
6667         target down.
6668         * record-full.c (record_full_wait_1): Switch to event thread.
6669         Pass target down.
6670         * regcache.c (regcache::regcache)
6671         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6672         process_stratum_target parameter and handle it.
6673         (current_thread_target): New global.
6674         (get_thread_regcache): Add process_stratum_target parameter and
6675         handle it.  Switch inferior before calling target method.
6676         (get_thread_regcache): Pass target down.
6677         (get_thread_regcache_for_ptid): Pass target down.
6678         (registers_changed_ptid): Add process_stratum_target parameter and
6679         handle it.
6680         (registers_changed_thread, registers_changed): Pass target down.
6681         (test_get_thread_arch_aspace_regcache): New.
6682         (current_regcache_test): Define a couple local test_target_ops
6683         instances and use them for testing.
6684         (readwrite_regcache): Pass process_stratum_target parameter.
6685         (cooked_read_test, cooked_write_test): Pass mock_target down.
6686         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6687         (get_thread_arch_aspace_regcache): Add process_stratum_target
6688         parameter.
6689         (regcache::target): New method.
6690         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6691         (regcache::registers_changed_ptid): Add process_stratum_target
6692         parameter.
6693         (regcache::m_target): New field.
6694         (registers_changed_ptid): Add process_stratum_target parameter.
6695         * remote.c (remote_state::supports_vCont_probed): New field.
6696         (remote_target::async_wait_fd): New method.
6697         (remote_unpush_and_throw): Add remote_target parameter.
6698         (get_current_remote_target): Adjust.
6699         (remote_target::remote_add_inferior): Push target.
6700         (remote_target::remote_add_thread)
6701         (remote_target::remote_notice_new_inferior)
6702         (get_remote_thread_info): Pass target down.
6703         (remote_target::update_thread_list): Skip threads of inferiors
6704         bound to other targets.  (remote_target::close): Don't discard
6705         inferiors.  (remote_target::add_current_inferior_and_thread)
6706         (remote_target::process_initial_stop_replies)
6707         (remote_target::start_remote)
6708         (remote_target::remote_serial_quit_handler): Pass down target.
6709         (remote_target::remote_unpush_target): New remote_target
6710         parameter.  Unpush the target from all inferiors.
6711         (remote_target::remote_unpush_and_throw): New remote_target
6712         parameter.  Pass it down.
6713         (remote_target::open_1): Check whether the current inferior has
6714         execution instead of checking whether any inferior is live.  Pass
6715         target down.
6716         (remote_target::remote_detach_1): Pass down target.  Use
6717         remote_unpush_target.
6718         (extended_remote_target::attach): Pass down target.
6719         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6720         (remote_target::append_resumption): Pass down target.
6721         (remote_target::append_pending_thread_resumptions)
6722         (remote_target::remote_resume_with_hc, remote_target::resume)
6723         (remote_target::commit_resume): Pass down target.
6724         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6725         (remote_target::interrupt_query)
6726         (remote_target::remove_new_fork_children)
6727         (remote_target::check_pending_events_prevent_wildcard_vcont)
6728         (remote_target::remote_parse_stop_reply)
6729         (remote_target::process_stop_reply): Pass down target.
6730         (first_remote_resumed_thread): New remote_target parameter.  Pass
6731         it down.
6732         (remote_target::wait_as): Pass down target.
6733         (unpush_and_perror): New remote_target parameter.  Pass it down.
6734         (remote_target::readchar, remote_target::remote_serial_write)
6735         (remote_target::getpkt_or_notif_sane_1)
6736         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6737         down target.
6738         (remote_target::mourn_inferior): Pass down target.  Use
6739         remote_unpush_target.
6740         (remote_target::core_of_thread)
6741         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6742         (remote_target::pid_to_exec_file)
6743         (remote_target::thread_handle_to_thread_info): Pass down target.
6744         (remote_target::async_wait_fd): New.
6745         * riscv-fbsd-tdep.c: Include "inferior.h".
6746         (riscv_fbsd_get_thread_local_address): Pass down target.
6747         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6748         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6749         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6750         Adjust.
6751         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6752         * solib-svr4.c (enable_break): Pass down target.
6753         * spu-multiarch.c (parse_spufs_run): Pass down target.
6754         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
6755         * target-delegates.c: Regenerate.
6756         * target.c (g_target_stack): Delete.
6757         (current_top_target): Return the current inferior's top target.
6758         (target_has_execution_1): Refer to the passed-in inferior's top
6759         target.
6760         (target_supports_terminal_ours): Check whether the initial
6761         inferior was already created.
6762         (decref_target): New.
6763         (target_stack::push): Incref/decref the target.
6764         (push_target, push_target, unpush_target): Adjust.
6765         (target_stack::unpush): Defref target.
6766         (target_is_pushed): Return bool.  Adjust to refer to the current
6767         inferior's target stack.
6768         (dispose_inferior): Delete, and inline parts ...
6769         (target_preopen): ... here.  Only dispose of the current inferior.
6770         (target_detach): Hold strong target reference while detaching.
6771         Pass target down.
6772         (target_thread_name): Add assertion.
6773         (target_resume): Pass down target.
6774         (target_ops::beneath, find_target_at): Adjust to refer to the
6775         current inferior's target stack.
6776         (get_dummy_target): New.
6777         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
6778         has a thread running.
6779         (initialize_targets): Rename to ...
6780         (_initialize_target): ... this.
6781         * target.h: Include "gdbsupport/refcounted-object.h".
6782         (struct target_ops): Inherit refcounted_object.
6783         (target_ops::shortname, target_ops::longname): Make const.
6784         (target_ops::async_wait_fd): New method.
6785         (decref_target): Declare.
6786         (struct target_ops_ref_policy): New.
6787         (target_ops_ref): New typedef.
6788         (get_dummy_target): Declare function.
6789         (target_is_pushed): Return bool.
6790         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
6791         (all_matching_threads_iterator::all_matching_threads_iterator):
6792         Handle filter target.
6793         * thread-iter.h (struct all_matching_threads_iterator, struct
6794         all_matching_threads_range, class all_non_exited_threads_range):
6795         Filter by target too.  Remove explicit.
6796         * thread.c (threads_executing): Delete.
6797         (inferior_thread): Pass down current inferior.
6798         (clear_thread_inferior_resources): Pass down thread pointer
6799         instead of ptid_t.
6800         (add_thread_silent, add_thread_with_info, add_thread): Add
6801         process_stratum_target parameter.  Use it for thread and inferior
6802         searches.
6803         (is_current_thread): New.
6804         (thread_info::deletable): Use it.
6805         (find_thread_ptid, thread_count, in_thread_list)
6806         (thread_change_ptid, set_resumed, set_running): New
6807         process_stratum_target parameter.  Pass it down.
6808         (set_executing): New process_stratum_target parameter.  Pass it
6809         down.  Adjust reference to 'threads_executing'.
6810         (threads_are_executing): New process_stratum_target parameter.
6811         Adjust reference to 'threads_executing'.
6812         (set_stop_requested, finish_thread_state): New
6813         process_stratum_target parameter.  Pass it down.
6814         (switch_to_thread): Also match inferior.
6815         (switch_to_thread): New process_stratum_target parameter.  Pass it
6816         down.
6817         (update_threads_executing): Reimplement.
6818         * top.c (quit_force): Pop targets from all inferior.
6819         (gdb_init): Don't call initialize_targets.
6820         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
6821         Declare.
6822         (windows_add_thread, windows_delete_thread): Adjust.
6823         (get_windows_debug_event): Rename to ...
6824         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
6825         * tracefile-tfile.c (tfile_target_open): Pass down target.
6826         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
6827         Forward declare.
6828         (switch_to_thread): Add process_stratum_target parameter.
6829         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
6830         parameter.  Use it.
6831         (mi_on_resume): Pass target down.
6832         * nat/fork-inferior.c (startup_inferior): Add
6833         process_stratum_target parameter.  Pass it down.
6834         * nat/fork-inferior.h (startup_inferior): Add
6835         process_stratum_target parameter.
6836         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6837
6838 2020-01-10  Pedro Alves  <palves@redhat.com>
6839
6840         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6841         directly.  Instead find the first thread in the thread list and
6842         use switch_to_thread.
6843
6844 2020-01-10  Pedro Alves  <palves@redhat.com>
6845
6846         * remote.c (remote_target::remote_add_inferior): Don't bind a
6847         process to the current inferior if the current inferior is already
6848         bound to a process.
6849
6850 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6851             Pedro Alves  <palves@redhat.com>
6852
6853         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6854         If no process is specified, return null_ptid instead of
6855         inferior_ptid.
6856         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6857         TARGET_WAITKIND_SIGNALLED with no pid.
6858
6859 2020-01-10  Pedro Alves  <palves@redhat.com>
6860
6861         * remote.c (first_remote_resumed_thread): New.
6862         (remote_target::wait_as): Use it as default event_ptid instead of
6863         inferior_ptid.
6864
6865 2020-01-10  Pedro Alves  <palves@redhat.com>
6866
6867         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6868
6869 2020-01-10  Pedro Alves  <palves@redhat.com>
6870
6871         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6872         not -1.
6873
6874 2020-01-10  Pedro Alves  <palves@redhat.com>
6875
6876         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6877         ptid to get_last_target_status.
6878         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6879         ptid to get_last_target_status.
6880         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6881         get_last_target_status.
6882         (info_program_command): Don't pass a target_waitstatus to
6883         get_last_target_status.
6884         * infrun.c (init_wait_for_inferior): Use
6885         nullify_last_target_wait_ptid.
6886         (get_last_target_status): Handle nullptr arguments.
6887         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6888         (print_stop_event): Don't pass a ptid to get_last_target_status.
6889         (normal_stop): Don't pass a ptid to get_last_target_status.
6890         * infrun.h (get_last_target_status, set_last_target_status): Move
6891         comments here and update.
6892         (nullify_last_target_wait_ptid): Declare.
6893         * linux-fork.c (fork_load_infrun_state): Remove local extern
6894         declaration of nullify_last_target_wait_ptid.
6895         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6896         to get_last_target_status.
6897
6898 2020-01-10  Pedro Alves  <palves@redhat.com>
6899
6900         * gdbthread.h (scoped_restore_current_thread)
6901         <dont_restore, restore, m_dont_restore>: Declare.
6902         * thread.c (thread_alive): Add assertion.  Return bool.
6903         (switch_to_thread_if_alive): New.
6904         (prune_threads): Switch inferior/thread.
6905         (print_thread_info_1): Switch thread before calling target methods.
6906         (scoped_restore_current_thread::restore): New, factored out from
6907         ...
6908         (scoped_restore_current_thread::~scoped_restore_current_thread):
6909         ... this.
6910         (scoped_restore_current_thread::scoped_restore_current_thread):
6911         Add assertion.
6912         (thread_apply_all_command, thread_select): Use
6913         switch_to_thread_if_alive.
6914         * infrun.c (proceed, restart_threads, handle_signal_stop)
6915         (switch_back_to_stepped_thread): Switch current thread before
6916         calling target methods.
6917
6918 2020-01-10  Pedro Alves <palves@redhat.com>
6919
6920         * inferior.c (switch_to_inferior_no_thread): New function,
6921         factored out from ...
6922         (inferior_command): ... here.
6923         * inferior.h (switch_to_inferior_no_thread): Declare.
6924         * mi/mi-main.c (run_one_inferior): Use
6925         switch_to_inferior_no_thread.
6926
6927 2020-01-10  Pedro Alves  <palves@redhat.com>
6928
6929         * infcmd.c (kill_command): Remove dead code.
6930
6931 2020-01-10  Pedro Alves  <palves@redhat.com>
6932
6933         * remote.c (remote_target::mourn_inferior): No longer check
6934         whether the target is running.
6935
6936 2020-01-10  Pedro Alves  <palves@redhat.com>
6937
6938         * corelow.c (core_target::has_execution): Change parameter type to
6939         inferior pointer.
6940         * inferior.c (number_of_live_inferiors): Use
6941         inferior::has_execution instead of target_has_execution_1.
6942         * inferior.h (inferior::has_execution): New.
6943         * linux-thread-db.c (thread_db_target::update_thread_list): Use
6944         inferior::has_execution instead of target_has_execution_1.
6945         * process-stratum-target.c
6946         (process_stratum_target::has_execution): Change parameter type to
6947         inferior pointer.  Check the inferior's PID instead of
6948         inferior_ptid.
6949         * process-stratum-target.h
6950         (process_stratum_target::has_execution): Change parameter type to
6951         inferior pointer.
6952         * record-full.c (record_full_core_target::has_execution): Change
6953         parameter type to inferior pointer.
6954         * target.c (target_has_execution_1): Change parameter type to
6955         inferior pointer.
6956         (target_has_execution_current): Adjust.
6957         * target.h (target_ops::has_execution): Change parameter type to
6958         inferior pointer.
6959         (target_has_execution_1): Change parameter type to inferior
6960         pointer.  Change return type to bool.
6961         * tracefile.h (tracefile_target::has_execution): Change parameter
6962         type to inferior pointer.
6963
6964 2020-01-10  Pedro Alves  <palves@redhat.com>
6965
6966         * exceptions.c (print_flush): Remove current_top_target() check.
6967
6968 2020-01-10  Pedro Alves  <palves@redhat.com>
6969
6970         * remote.c (show_remote_exec_file): Show the current inferior's
6971         exec-file instead of the command variable's value.
6972
6973 2020-01-10  Pedro Alves  <palves@redhat.com>
6974
6975         * record-full.c (record_full_resume_ptid): New global.
6976         (record_full_target::resume): Set it.
6977         (record_full_wait_1): Use record_full_resume_ptid instead of
6978         inferior_ptid.
6979
6980 2020-01-10  Pedro Alves  <palves@redhat.com>
6981
6982         * gdbthread.h (scoped_restore_current_thread)
6983         <dont_restore, restore, m_dont_restore>: Declare.
6984         * thread.c (thread_alive): Add assertion.  Return bool.
6985         (switch_to_thread_if_alive): New.
6986         (prune_threads): Switch inferior/thread.
6987         (print_thread_info_1): Switch thread before calling target methods.
6988         (scoped_restore_current_thread::restore): New, factored out from
6989         ...
6990         (scoped_restore_current_thread::~scoped_restore_current_thread):
6991         ... this.
6992         (scoped_restore_current_thread::scoped_restore_current_thread):
6993         Add assertion.
6994         (thread_apply_all_command, thread_select): Use
6995         switch_to_thread_if_alive.
6996
6997 2020-01-10  George Barrett  <bob@bob131.so>
6998
6999         * stap-probe.c (stap_modify_semaphore): Don't check for null
7000         semaphores.
7001         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
7002         for null semaphores.
7003
7004 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7005
7006         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
7007         all source windows, and maintain horizontal scroll status while
7008         doing so.
7009
7010 2020-01-09  Tom Tromey  <tom@tromey.com>
7011
7012         PR tui/18932:
7013         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
7014         update_source_window, not print_source_lines.
7015
7016 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7017
7018         * tui/tui.c (tui_enable): Register tui hooks after calling
7019         tui_display_main.
7020
7021 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7022
7023         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
7024
7025 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
7026
7027         * thread.c (print_thread_info_1): Fix indentation.
7028
7029 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
7030
7031         * symtab.c (general_symbol_info::compute_and_set_names): Move the
7032         unique_xmalloc_ptr outside the if to always free the demangled name.
7033
7034 2020-01-08  Tom Tromey  <tromey@adacore.com>
7035
7036         * xcoffread.c (enter_line_range, read_xcoff_symtab)
7037         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
7038         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
7039         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
7040         Remove.
7041         (section_offsets): New typedef.
7042         * symtab.c (fixup_section, get_msymbol_address): Update.
7043         * symmisc.c (dump_msymbols): Update.
7044         * symfile.h (relative_addr_info_to_section_offsets)
7045         (symfile_map_offsets_to_segments): Update.
7046         * symfile.c (build_section_addr_info_from_objfile)
7047         (init_objfile_sect_indices): Update.
7048         (struct place_section_arg): Change type of "offsets".
7049         (place_section): Update.
7050         (relative_addr_info_to_section_offsets): Change type of
7051         "section_offsets".  Remove "num_sections" parameter.
7052         (default_symfile_offsets, syms_from_objfile_1)
7053         (set_objfile_default_section_offset): Update.
7054         (reread_symbols): No need to preserve section offsets by hand.
7055         (symfile_map_offsets_to_segments): Change type of "offsets".
7056         * stap-probe.c (relocate_address): Update.
7057         * stabsread.h (process_one_symbol): Update.
7058         * solib-target.c (struct lm_info_target) <offsets>: Change type.
7059         (solib_target_relocate_section_addresses): Update.
7060         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
7061         Update.
7062         * solib-frv.c (frv_relocate_main_executable): Update.
7063         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
7064         * solib-aix.c (solib_aix_get_section_offsets): Change return
7065         type.
7066         (solib_aix_solib_create_inferior_hook): Update.
7067         * remote.c (remote_target::get_offsets): Update.
7068         * psymtab.c (find_pc_sect_psymtab): Update.
7069         * psympriv.h (struct partial_symbol) <address, text_low,
7070         text_high>: Update.
7071         * objfiles.h (obj_section_offset): Update.
7072         (struct objfile) <section_offsets>: Change type.
7073         <num_sections>: Remove.
7074         (objfile_relocate): Update.
7075         * objfiles.c (entry_point_address_query): Update
7076         (relocate_one_symbol): Change type of "section_offsets".
7077         (objfile_relocate1, objfile_relocate1): Change type of
7078         "new_offsets".
7079         (objfile_rebase1): Update.
7080         * mipsread.c (mipscoff_symfile_read): Update.
7081         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
7082         parameter.
7083         * mdebugread.c (parse_symbol): Change type of "section_offsets".
7084         (parse_external, psymtab_to_symtab_1): Update.
7085         * machoread.c (macho_symfile_offsets): Update.
7086         * ia64-tdep.c (ia64_find_unwind_table): Update.
7087         * hppa-tdep.c (read_unwind_info): Update.
7088         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
7089         * dwarf2read.c (create_addrmap_from_index)
7090         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7091         (process_psymtab_comp_unit_reader, add_partial_symbol)
7092         (add_partial_subprogram, process_full_comp_unit)
7093         (read_file_scope, read_func_scope, read_lexical_block_scope)
7094         (read_call_site_scope, dwarf2_rnglists_process)
7095         (dwarf2_ranges_process, dwarf2_ranges_read)
7096         (dwarf_decode_lines_1, var_decode_location, new_symbol)
7097         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
7098         Update.
7099         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
7100         Update.
7101         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
7102         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
7103         (process_one_symbol): Change type of "section_offsets".
7104         * ctfread.c (get_objfile_text_range): Update.
7105         * coffread.c (coff_symtab_read, enter_linenos)
7106         (process_coff_symbol): Update.
7107         * coff-pe-read.c (add_pe_forwarded_sym): Update.
7108         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
7109
7110 2020-01-08  Tom Tromey  <tromey@adacore.com>
7111
7112         * dwarf2read.c (parse_macro_definition): Use std::string.
7113         (parse_macro_definition): Likewise.
7114
7115 2020-01-08  Tom Tromey  <tromey@adacore.com>
7116
7117         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
7118         (ATTR_ALLOC_CHUNK): Remove.
7119
7120 2020-01-08  Tom Tromey  <tromey@adacore.com>
7121
7122         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
7123
7124 2020-01-08  Tom Tromey  <tromey@adacore.com>
7125
7126         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
7127         (dwarf2_compute_name, open_dwo_file): Likewise.
7128         (process_enumeration_scope): Use std::vector.
7129         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
7130         (partial_die_info::fixup, dwarf2_start_subfile)
7131         (guess_full_die_structure_name, dwarf2_name): Likewise.
7132         (determine_prefix): Update.
7133         (guess_full_die_structure_name): Make return type const.
7134         (partial_die_full_name): Return unique_xmalloc_ptr.
7135         (DW_FIELD_ALLOC_CHUNK): Remove.
7136
7137 2020-01-07  Tom Tromey  <tromey@adacore.com>
7138
7139         PR build/24937:
7140         * stap-probe.c (class stap_static_probe_ops): Add constructor.
7141
7142 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7143
7144         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
7145
7146 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7147
7148         * stack.c (print_frame_info): Move disassemble_next_line code
7149         inside source_print block.
7150
7151 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7152
7153         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
7154         gdb/signals.h, as we are now using native signal symbols.
7155
7156 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7157
7158         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
7159         overflow by an early check of content vs threshold.
7160         * tui/tui-source.c (tui_source_window::line_is_displayed):
7161         Likewise.
7162
7163 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7164
7165         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
7166
7167 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
7168
7169         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
7170         export table if no section contains it's RVA.
7171
7172 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7173
7174         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
7175
7176 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
7177
7178         * source.c (print_source_lines_base): Set last_line_listed.
7179
7180 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
7181
7182         * tui/tui-disasm.c: Remove trailing spaces.
7183
7184 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
7185             Pedro Alves  <palves@redhat.com>
7186
7187         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
7188         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
7189         (windows_gdb_signal_to_target): New function, uses the above
7190         enumeration to convert GDB internal signal codes to equivalent
7191         Windows codes.
7192         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
7193         * windows-nat.c: Include "gdb_wait.h".
7194         (get_windows_debug_event): Extract the fatal exception from the
7195         exit status and convert to the equivalent Posix signal number.
7196         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
7197         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
7198         * gdbsupport/gdb_wait.c: New file, implements
7199         windows_status_to_termsig.
7200         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
7201         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
7202
7203 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
7204
7205         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
7206         show_layout.
7207
7208 2020-01-05  Luis Machado  <luis.machado@linaro.org>
7209
7210         * aarch64-linux-nat.c
7211         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
7212         and bfd_mach_aarch64.
7213
7214 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7215
7216         * ui-file.c (stdio_file::can_emit_style_escape)
7217         (tee_file::can_emit_style_escape): Ensure style is used also on
7218         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
7219         to gdb_stdout.
7220         * main.c (set_gdb_data_directory): Use file style to output the
7221         warning that the given pathname is not a directory.
7222         * top.c (show_history_filename, gdb_safe_append_history)
7223         (show_gdb_datadir): Use file style.
7224
7225 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7226
7227         * solib-target.c (struct lm_info_target):
7228         Change offsets to be a unique_xmalloc_ptr.
7229         (solib_target_relocate_section_addresses): Update.
7230
7231 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
7232
7233         * windows-nat.c (windows_clear_solib): Free so_list linked list.
7234
7235 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7236
7237         * MAINTAINERS (Write After Approval): Add myself.
7238
7239 2020-01-02  Luis Machado  <luis.machado@linaro.org>
7240
7241         * proc-service.c (get_ps_regcache): Remove reference to obsolete
7242         Cell BE architecture.
7243         * target.h (struct target_ops) <thread_architecture>: Likewise.
7244
7245 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7246
7247         * Makefile.in: Use INSTALL_PROGRAM_ENV.
7248
7249 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
7250
7251         * MAINTAINERS (Write After Approval): Add myself.
7252
7253 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7254
7255         * gdbarch.sh: Update copyright year range of generated files.
7256
7257 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7258
7259         Update copyright year range in all GDB files.
7260
7261 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7262
7263         * copyright.py: Convert to Python 3.
7264
7265 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7266
7267         * copyright.py: Adapt after move of gnulib directory from gdb
7268         directory to toplevel directory.
7269
7270 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7271
7272         * copyright.py (main): Exit if run from the wrong directory.
7273
7274 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7275
7276         * top.c (print_gdb_version): Change copyright year to 2020.
7277
7278 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
7279
7280         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
7281
7282 For older changes see ChangeLog-2019.
7283 \f
7284 Local Variables:
7285 mode: change-log
7286 left-margin: 8
7287 fill-column: 74
7288 version-control: never
7289 coding: utf-8
7290 End: