gdb/ChangeLog

   1 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
   2
   3         * NEWS: Mention that gdb can now be compiled with Python 3
   4         on Windows.
   5
   6 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
   7
   8         * maint.c (maint_print_section_data::maint_print_section_data):
   9         Force use of 'float log10 (float)' by casting the argument to
  10         float.
  11
  12 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  13
  14         * maint.c: Add 'cmath' include.
  15         (struct maint_print_section_data): New structure.
  16         (print_section_index): New function.
  17         (print_bfd_section_info): Add header comment, small whitespace
  18         cleanup, and update to call new print_section_index function.
  19         (print_objfile_section_info): Likewise.
  20         (maint_obj_section_from_bfd_section): New function.
  21         (print_bfd_section_info_maybe_relocated): New function.
  22         (maintenance_info_sections): Add header comment, always use
  23         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
  24
  25 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
  26
  27         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
  28         inner scope, add check that the objfile has psymtabs before
  29         checking psymtabs_addrmap.
  30         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
  31
  32 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  33
  34         * NEWS: Announce that Ada task names are now shown at more places,
  35         and between quotes (except in info task output).
  36         * gdb/ada-tasks.c (task_to_str): New function.
  37         (display_current_task_id): Call task_to_str.
  38         (task_command_1): Likewise.
  39         (print_ada_task_info): In non-mi mode, Properly align headers and data
  40         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
  41
  42 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
  43
  44         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
  45         prstatus.pr_lwp.pr_info instead of making it up.
  46
  47 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  48
  49         * auto-load.c (auto_load_expand_dir_vars): Update.
  50         * defs.h (gdb_datadir): Change to std::string.
  51         (python_libdir): Likewise.
  52         (relocate_gdb_directory): Change return type to std::string.
  53         * guile/guile.c (gdbscm_data_directory): Update.
  54         (initialize_scheme_side): Update.
  55         * jit.c (jit_reader_dir): Change to std::string.
  56         (jit_reader_load_command): Update.
  57         * main.c (gdb_datadir): Change to std::string.
  58         (python_libdir): Likewise.
  59         (set_gdb_data_directory): Update.
  60         (relocate_path): Change to return std::string.
  61         (relocate_gdb_directory): Change to return std::string.
  62         (relocate_gdbinit_path_maybe_in_datadir): Update.
  63         (captured_main_1): Update.
  64         * python/python.c (do_start_initialization): Update.
  65         * top.c (show_gdb_datadir): Update.
  66         * xml-syscall.c (xml_init_syscalls_info): Update.
  67         (init_syscalls_info): Update.
  68
  69 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  70
  71         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
  72         out of get_init_files.
  73         (get_init_files): Update.
  74
  75 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  76
  77         * main.c (get_init_files): Change to use std::string.
  78         (captured_main_1): Update.
  79         (print_gdb_help): Update.
  80
  81 2019-09-11  Ali Tamur  <tamur@google.com>
  82
  83         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
  84         implementation.
  85
  86 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
  87
  88         * dbxread.c (read_dbx_symtab): Update.
  89         * dwarf2read.c (load_partial_dies): Update.
  90         * mdebugread.c (parse_partial_symbols): Update.
  91         (handle_psymbol_enumerators): Update.
  92         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
  93         * psymtab.c (add_psymbol_to_bcache): Likewise.
  94         (add_psymbol_to_list): Likewise.
  95         * symtab.c (symbol_set_names): Likewise.
  96         * symtab.h (symbol_set_names): Likewise.
  97         * xcoffread.c (scan_xcoff_symtab): Update.
  98
  99 2019-09-11  Tom Tromey  <tom@tromey.com>
 100
 101         * symfile-mem.c (symbol_file_add_from_memory): Use
 102         bfd_set_filename.
 103         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 104         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 105
 106 2019-09-10  Tom Tromey  <tromey@adacore.com>
 107
 108         * dwarf-index-write.c (write_psymbols): Extend error message.
 109         (debug_names::insert): Add Ada code.
 110         (debug_names::write_psymbols): Remove Ada check.
 111         (debug_names) <m_string_obstack>: New member.
 112         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 113         (gdb_index_symbol_name_matcher::matches): Remove.
 114         (mapped_index_base::find_name_components_bounds): Add "lang"
 115         parameter.
 116         (mapped_index_base::build_name_components): Also split names
 117         according to Ada syntax.
 118         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 119         type of "match_callback".
 120         (check_match, check_find_bounds_finds)
 121         (dw2_expand_symtabs_matching): Update.
 122         (dw2_debug_names_iterator): Add new constructor.
 123         (dw2_debug_names_map_matching_symbols): New function.
 124         (dw2_debug_names_expand_symtabs_matching): Update.
 125         (dwarf2_debug_names_functions): Use
 126         dw2_debug_names_map_matching_symbols.
 127
 128 2019-09-10  Tom Tromey  <tromey@adacore.com>
 129
 130         * dwarf2read.c (dw2_get_file_names_reader): Add the
 131         CU's file name to the results.
 132
 133 2019-09-10  Tom Tromey  <tromey@adacore.com>
 134
 135         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 136         map_matching_symbols.  Update.
 137         * dwarf2read.c (dw2_map_matching_symbols): Update.
 138         * psymtab.c (match_partial_symbol): Change type; update.
 139         (psym_map_matching_symbols): Likewise.
 140         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 141         type; update.
 142         * symfile.h (struct quick_symbol_functions)
 143         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 144         Remove "match".
 145
 146 2019-09-10  Tom Tromey  <tromey@adacore.com>
 147
 148         * psymtab.c (map_block): Remove.
 149         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 150         * symtab.c (iterate_over_symbols_terminated): New function.
 151         * symtab.c (iterate_over_symbols_terminated): Declare.
 152
 153 2019-09-10  Tom Tromey  <tromey@adacore.com>
 154
 155         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 156         * language.h (struct language_defn) <la_iterate_over_symbols>:
 157         Return bool.
 158         * symtab.c (iterate_over_symbols): Return bool.
 159         * symtab.h (iterate_over_symbols): Return bool.
 160
 161 2019-09-10  Tom Tromey  <tromey@adacore.com>
 162
 163         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 164         (add_nonlocal_symbols): Update.
 165         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 166         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 167         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 168         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 169         Change type of "callback".  Remove "data".
 170
 171
 172 2019-09-09  Ali Tamur  <tamur@google.com>
 173
 174         * dwarf2read.c (comp_unit_head): Update comment.
 175         (dwarf2_dwo_name): New function declaration.
 176         (dwarf_unit_type_name): New function declaration.
 177         (read_comp_unit_head): Add support for new compilation units,
 178         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 179         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 180         (currently named as "signature") in their header. Also clarify error
 181         messages.
 182         (lookup_dwo_id): New function. Returns the dwo id of the given
 183         compile unit.
 184         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 185         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 186         functions.
 187         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 188         (dwarf2_dwo_name): Get the dwo name if present.
 189         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 190         purposes.
 191
 192 2019-09-09  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 195
 196 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 197
 198         * python/python.c (do_start_initialization): Make progname_copy static,
 199         to avoid a leak report.
 200
 201 2019-09-08  Tom Tromey  <tom@tromey.com>
 202
 203         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 204
 205 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 206
 207         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 208         Change type to gdb::optional<block_enum>.
 209         (dw2_symtab_iter_init): Change block_index parameter type
 210         to gdb::optional<block_enum>.
 211         (dw2_lookup_symbol): Change block_index parameter
 212         type to block_enum.c
 213         (dw2_debug_names_lookup_symbol): Likewise.
 214         * psymtab.c (psym_lookup_symbol): Likewise.
 215         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 216         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 217         Likewise.
 218
 219 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 220
 221         * defs.h (relocate_gdb_directory): Change int to bool in
 222         signature and rename flag to relocatable.
 223         * main.c (relocate_path): Likewise.
 224         (relocate_gdb_directory): Likewise.
 225
 226 2019-09-06  Alan Modra  <amodra@gmail.com>
 227
 228         * coffread.c (coff_symfile_read): Constify filename variable.
 229         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 230         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 231         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 232         * solib.c (reload_shared_libraries_1): Likewise.
 233         * symfile.c (reread_symbols): Likewise.
 234         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 235         * solib-darwin.c (darwin_bfd_open): Likewise.
 236         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 237
 238 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 239
 240         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 241         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 242
 243 2019-09-03  Tom Tromey  <tromey@adacore.com>
 244
 245         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 246         types.
 247         (has_negatives): Unbias a range type bound.
 248         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 249         * gdbtypes.c (operator==): Handle new field.
 250         (create_range_type): Add "bias" parameter.
 251         (create_static_range_type, resolve_dynamic_range): Update.
 252         * gdbtypes.h (struct range_bounds) <bias>: New member.
 253         (create_range_type): Add bias parameter.
 254         * printcmd.c (print_scalar_formatted): Unbias range types.
 255         * value.c (unpack_long): Unbias range types.
 256         (pack_long): Bias range types.
 257
 258 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 259
 260         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 261         probe arguments.
 262
 263 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 264
 265         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 266         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 267         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 268         (compile_probe_arg): Likewise.
 269         * probe.h (get_argument_count): Likewise.
 270         * solib-svr4.c (solib_event_probe_action): Likewise.
 271         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 272
 273 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 274
 275         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 276         code to here...
 277         (svr4_create_solib_event_breakpoints): ...from here.
 278
 279 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 280
 281         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 282         suffix from warning message.
 283
 284 2019-08-30  Tom Tromey  <tom@tromey.com>
 285
 286         * tui/tui-winsource.h (struct tui_source_window_base)
 287         <refresh_all>: Don't declare.
 288         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 289         Remove.
 290         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 291         tui_show_locator_content.
 292         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 293         declare.
 294         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 295         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 296         declare.
 297
 298 2019-08-30  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 301
 302 2019-08-30  Tom Tromey  <tom@tromey.com>
 303
 304         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 305         Remove unnecessary forward declarations.
 306
 307 2019-08-30  Tom Tromey  <tom@tromey.com>
 308
 309         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 310         rerender.
 311         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 312         tui_show_locator_content.
 313
 314 2019-08-30  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 317         (tui_locator_window::rerender): Rewrite using body of previous
 318         tui_show_locator_content.
 319
 320 2019-08-30  Tom Tromey  <tom@tromey.com>
 321
 322         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 323         set_locator_fullname>: New methods.
 324         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 325         Rename from tui_set_locator_fullname.
 326         (tui_locator_window::set_locator_info): Rename from
 327         tui_set_locator_info.  Return bool.
 328         (tui_update_locator_fullname, tui_show_frame_info): Update.
 329
 330 2019-08-30  Tom Tromey  <tom@tromey.com>
 331
 332         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 333
 334 2019-08-30  Tom Tromey  <tom@tromey.com>
 335
 336         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 337         call touchwin.
 338
 339 2019-08-30  Tom Tromey  <tom@tromey.com>
 340
 341         * tui/tui-wingeneral.c (box_win): Assume win_info and
 342         win_info->handle cannot be NULL.
 343
 344 2019-08-30  Tom Tromey  <tom@tromey.com>
 345
 346         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 347         refresh_window>: Declare.
 348         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 349         resize.
 350         (tui_data_item_window::rerender): Rename from
 351         tui_display_register.
 352         (tui_data_item_window::refresh_window): New method.
 353         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 354         no-op.
 355
 356 2019-08-30  Tom Tromey  <tom@tromey.com>
 357
 358         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 359         regs_column_count, current_group>: Move later.  Now private.
 360         <get_current_group>: New method.
 361         * tui/tui-regs.c (tui_reg_command): Update.
 362         * tui/tui-layout.c (tui_set_layout): Update.
 363
 364 2019-08-30  Tom Tromey  <tom@tromey.com>
 365
 366         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 367         (tui_data_window::rerender): Don't call
 368         check_and_display_highlight_if_needed.
 369         (tui_data_window::refresh_all): Remove call to
 370         erase_data_content.
 371
 372 2019-08-30  Tom Tromey  <tom@tromey.com>
 373
 374         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 375         (tui_data_window::display_registers_from)
 376         (tui_data_window::display_reg_element_at_line)
 377         (tui_data_window::display_registers_from_line): Remove checks of
 378         "empty".
 379
 380 2019-08-30  Tom Tromey  <tom@tromey.com>
 381
 382         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
 383         Don't declare.
 384         * tui/tui-regs.c (tui_data_window::show_registers): Call
 385         rerender.
 386         (tui_data_window::rerender): Rename from display_all_data.
 387         (tui_data_window::rerender): Remove old implementation.
 388
 389 2019-08-30  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-regs.c (tui_data_window::display_all_data): Change
 392         text.
 393         * tui/tui-data.h (NO_DATA_STRING): Remove define.
 394
 395 2019-08-29  Bernhard Wodok  <barto@gmx.net>
 396             Sergio Durigan Junior  <sergiodj@redhat.com>
 397
 398         PR win32/24284
 399         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
 400
 401 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 402
 403         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
 404         when searching for types.
 405
 406 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
 407
 408         * f-lang.c (f_language_defn): Use f_print_typedef.
 409         * f-lang.h (f_print_typedef): Declare.
 410         * f-typeprint.c (f_print_typedef): Define.
 411
 412 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
 413
 414         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
 415
 416 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
 417
 418         * cli/cli-utils.c (info_print_options_defs): Delete.
 419         (make_info_print_options_def_group): Delete.
 420         (extract_info_print_options): Delete.
 421         (info_print_command_completer): Delete.
 422         (info_print_args_help): Add extra parameter, and optionally
 423         include text about -n flag.
 424         * cli/cli-utils.h (struct info_print_options): Delete.
 425         (extract_info_print_options): Delete declaration.
 426         (info_print_command_completer): Delete declaration.
 427         (info_print_args_help): Add extra parameter, extend header
 428         comment.
 429         * python/python.c (gdbpy_rbreak): Pass additional parameter to
 430         search_symbols.
 431         * stack.c (struct info_print_options): New type.
 432         (info_print_options_defs): New file scoped variable.
 433         (make_info_print_options_def_group): New static function.
 434         (info_print_command_completer): New static function.
 435         (info_locals_command): Update to use new local functions.
 436         (info_args_command): Likewise.
 437         (_initialize_stack): Add extra parameter to calls to
 438         info_print_args_help.
 439         * symtab.c (search_symbols): Add extra parameter, use this to
 440         possibly excluse non-debug symbols.
 441         (symtab_symbol_info): Add extra parameter, which is passed on to
 442         search_symbols.
 443         (struct info_print_options): New type.
 444         (info_print_options_defs): New file scoped variable.
 445         (make_info_print_options_def_group): New static function.
 446         (info_print_command_completer): New static function.
 447         (info_variables_command): Update to use local functions, and pass
 448         extra parameter through to symtab_symbol_info.
 449         (info_functions_command): Likewise.
 450         (info_types_command): Pass additional argument through to
 451         symtab_symbol_info.
 452         (rbreak_command): Pass extra argument to search_symbols.
 453         (_initialize_symtab): Add extra arguments for calls to
 454         info_print_args_help, and update help text for 'info variables',
 455         'whereis', and 'info functions' commands.
 456         * symtab.h (search_symbols): Add extra argument to declaration.
 457         * NEWS: Mention new flags.
 458
 459 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
 460
 461         * symtab.c (lookup_static_symbol): Call the new function (and move
 462         it down to be next to lookup_global_symbol).
 463         (struct global_sym_lookup_data): Add block_enum member and rename to...
 464         (struct global_or_static_sym_lookup_data): ...this.
 465         (lookup_symbol_global_iterator_cb): Pass block_index instead of
 466         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
 467         (lookup_symbol_global_or_static_iterator_cb): ...this.
 468         (lookup_global_or_static_symbol): New function.
 469         (lookup_global_symbol): Call new function.
 470
 471 2019-08-26  Tom de Vries  <tdevries@suse.de>
 472
 473         PR c++/24852
 474         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
 475         when pc_probe.prob == NULL.
 476
 477 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 478
 479         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
 480         variable symbol_linkage to symbol_linkage_.
 481
 482 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
 483
 484         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
 485         represent whether the symbol is static, dynamic, or we don't
 486         know.
 487
 488 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
 489
 490         * gdb/rx-tdep.c (rx_register_names): New.
 491         (rx_register_name): Delete.
 492         (rx_psw_type): Delete.
 493         (rx_fpsw_type): Delete.
 494         (rx_register_type): Delete.
 495         (rx_gdbarch_init): Convert target-descriptions.
 496         (_initialize_rx_tdep): Add initialize_tdesc_rx.
 497         * gdb/features/Makefile: Add rx.xml.
 498         * gdb/features/rx.xml: New.
 499         * gdb/features/rx.c: Generated.
 500         * gdb/NEWS: Mention target description support.
 501
 502 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 503
 504         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
 505         *slot_ptr.
 506
 507 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
 508
 509         * configure.ac: Don't check for 'dlfcn.h' (moved to
 510         gdbsupport/common.m4).
 511         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
 512         'gdbsupport/'.
 513         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
 514         * compile/compile-c-support.c: Include
 515         'gdbsupport/gdb-dlfcn.h'.
 516         * gdbsupport/common.m4: Check for 'dlfcn.h'.
 517         * gdb-dlfcn.c: Move to...
 518         * gdbsupport/gdb-dlfcn.c: ... here.
 519         * gdb-dlfcn.h: Move to...
 520         * gdbsupport/gdb-dlfcn.h: ... here.
 521
 522 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
 523
 524         * nios2-tdep.c (struct reg_value): Improve comments.  Make
 525         the offset field signed.
 526
 527 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
 528
 529         * python/lib/gdb/__init__.py (_execute_file): New function.
 530         * python/python.c (python_run_simple_file): Call gdb._execute_file
 531         on Windows.
 532
 533 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
 534
 535         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
 536         all uses as this was never set to anything but a zero value.
 537
 538 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
 539
 540         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
 541
 542 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
 543
 544         * tui/tui-data.h (tui_gen_win_info): Add an =default
 545         move constructor, required by some GCC versions.
 546
 547 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
 548
 549         * go32-nat.c (go32_sysinfo): Add hygon_p.
 550
 551 2019-08-20  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
 554         line_from_reg_element_no, first_reg_element_no_inline,
 555         display_all_data, delete_data_content_windows,
 556         erase_data_content>: Now private.
 557
 558 2019-08-20  Tom Tromey  <tom@tromey.com>
 559
 560         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
 561         (tui_unhighlight_win, tui_highlight_win)
 562         (tui_win_info::make_window): Update.
 563         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
 564
 565 2019-08-20  Tom Tromey  <tom@tromey.com>
 566
 567         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 568         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 569         (MAX_PID_WIDTH): Move to tui-stack.c.
 570         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
 571         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
 572         (MAX_PID_WIDTH): Move from tui-data.h.
 573
 574 2019-08-20  Tom Tromey  <tom@tromey.com>
 575
 576         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
 577         * tui/tui-wingeneral.c (box_win): Change type of win_info.
 578         (box_win): Update.
 579         (tui_gen_win_info::make_window): Rename from tui_make_window.
 580         (tui_win_info::make_window): New method.
 581         (tui_gen_win_info::make_visible): Update.
 582         * tui/tui-source.c (tui_source_window::set_contents): Update.
 583         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 584         (tui_data_window::display_registers_from): Update.
 585         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 586         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
 587         Declare.
 588         <can_box>: Remove.
 589         <title>: Remove.
 590         (struct tui_win_info) <make_window>: Declare.
 591         <can_box>: Now virtual.
 592         <title>: New member.
 593         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
 594         * tui/tui-command.c (tui_cmd_window::resize): Update.
 595
 596 2019-08-20  Tom Tromey  <tom@tromey.com>
 597
 598         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
 599         * tui/tui-regs.c (tui_data_window::show_registers): Update.
 600         (tui_data_window::check_register_values): Update.
 601
 602 2019-08-20  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-regs.h (struct tui_data_window): Use
 605         DISABLE_COPY_AND_ASSIGN.
 606         <regs_content>: Change type, removing unique_ptr.
 607         <tui_data_window>: Add move constructor.
 608         * tui/tui-regs.c (tui_data_window::show_registers)
 609         (tui_data_window::show_register_group)
 610         (tui_data_window::display_registers_from)
 611         (tui_data_window::display_registers_from)
 612         (tui_data_window::first_data_item_displayed)
 613         (tui_data_window::delete_data_content_windows)
 614         (tui_data_window::rerender, tui_data_window::refresh_window)
 615         (tui_data_window::check_register_values): Update.
 616
 617 2019-08-20  Tom Tromey  <tom@tromey.com>
 618
 619         * tui/tui-regs.h (struct tui_data_window) <show_registers,
 620         show_register_group>: Declare.
 621         (tui_show_register_group): Don't declare.
 622         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
 623         tui_show_registers.
 624         (tui_data_window::show_register_group): Rename from
 625         tui_show_register_group.
 626         (tui_data_window::check_register_values, tui_reg_command):
 627         Update.
 628         * tui/tui-layout.c (tui_set_layout): Update.
 629
 630 2019-08-20  Tom Tromey  <tom@tromey.com>
 631
 632         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
 633         Declare.
 634         (tui_check_register_values): Don't declare.
 635         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
 636         from tui_check_register_values.
 637         * tui/tui-hooks.c (tui_register_changed): Update.
 638
 639 2019-08-20  Tom Tromey  <tom@tromey.com>
 640
 641         * tui/tui-regs.c (tui_reg_layout): Move later.
 642         (tui_show_registers): Don't enable TUI mode or change layout.
 643
 644 2019-08-20  Tom Tromey  <tom@tromey.com>
 645
 646         * tui/tui-regs.h (struct tui_data_item_window)
 647         <~tui_data_item_window>: Remove.
 648         <content>: Now a unique_xmalloc_ptr.
 649         * tui/tui-regs.c (tui_register_format): Return a
 650         unique_xmalloc_ptr.
 651         (tui_get_register): Update.
 652         (~tui_data_item_window): Remove.
 653         (tui_data_window::display_registers_from, tui_display_register):
 654         Update.
 655         * tui/tui-io.h (tui_expand_tabs): Update.
 656         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
 657         Remove "col" parameter.
 658
 659 2019-08-20  Tom Tromey  <tom@tromey.com>
 660
 661         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
 662         field.
 663         * tui/tui-regs.c (~tui_data_item_window): Update.
 664
 665 2019-08-20  Tom Tromey  <tom@tromey.com>
 666
 667         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
 668         earlier.
 669
 670 2019-08-20  Tom Tromey  <tom@tromey.com>
 671
 672         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
 673
 674 2019-08-20  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-source.h (struct tui_source_window): Update.
 677         * tui/tui-regs.c (tui_show_registers): Update.
 678         * tui/tui-disasm.h (struct tui_disasm_window): Update.
 679         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
 680         (NO_REGS_STRING): Remove defines.
 681
 682 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
 683
 684         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
 685         unnecessary thread walk if remote doesn't support the packet.
 686
 687 2019-08-19  Tom Tromey  <tromey@adacore.com>
 688
 689         * python/py-value.c (value_has_field): Fix indentation.
 690
 691 2019-08-19  Tom Tromey  <tromey@adacore.com>
 692
 693         * printcmd.c (do_one_display, info_display_command): Update.
 694         * block.h (contained_in): Return bool.  Add allow_nested
 695         parameter.
 696         * block.c (contained_in): Return bool.  Add allow_nested
 697         parameter.
 698
 699 2019-08-19  Tom Tromey  <tom@tromey.com>
 700
 701         * configure: Rebuild.
 702         * configure.ac: Disallow the combination of -static-libstdc++ and
 703         source highlight.
 704         * source-cache.c (get_language_name): Handle rust.
 705         (source_cache::get_source_lines): Ignore highlighting exceptions.
 706
 707 2019-08-16  Tom Tromey  <tom@tromey.com>
 708
 709         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
 710         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
 711         (struct tui_source_window_base) <make_visible, refresh_window,
 712         resize>: Remove methods.
 713         <execution_info>: Remove field.
 714         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
 715         (tui_show_source_line, tui_source_window_base)
 716         (~tui_source_window_base): Update.
 717         (tui_source_window_base::resize)
 718         (tui_source_window_base::make_visible)
 719         (tui_source_window_base::refresh_window): Remove.
 720         (tui_source_window_base::update_exec_info): Update.
 721         * tui/tui-source.c (tui_source_window::set_contents): Update.
 722         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 723
 724 2019-08-16  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-hooks.c (tui_remove_hooks): Don't set
 727         deprecated_query_hook.
 728
 729 2019-08-16  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 732         (tui_update_source_windows_with_line): Update.
 733         * tui/tui-source.h (struct tui_source_window)
 734         <show_symtab_source>: Declare.
 735         (tui_show_symtab_source): Don't declare.
 736         * tui/tui-source.c (tui_show_symtab_source): Rename from
 737         tui_show_symtab_source.
 738
 739 2019-08-16  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-winsource.h (struct tui_source_window_base)
 742         <set_contents>: Declare.
 743         * tui/tui-winsource.c
 744         (tui_source_window_base::update_source_window_as_is): Update.
 745         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 746         Declare.
 747         (tui_set_source_content): Don't declare.
 748         * tui/tui-source.c (tui_source_window::set_contents): Rename from
 749         tui_set_source_content.
 750         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 751         Declare.
 752         (tui_set_disassem_content): Don't declare.
 753         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
 754         tui_set_disassem_content.
 755
 756 2019-08-16  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-winsource.h (struct tui_source_window_base)
 759         <update_breakpoint_info>: Declare.
 760         (tui_update_breakpoint_info): Don't declare.
 761         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
 762         (tui_update_all_breakpoint_info): Update.
 763         (tui_source_window_base::update_breakpoint_info): Rename from
 764         tui_update_breakpoint_info.
 765         (tui_source_window_base::update_exec_info): Update.
 766
 767 2019-08-16  Tom Tromey  <tom@tromey.com>
 768
 769         * tui/tui-winsource.h (struct tui_source_window_base)
 770         <update_source_window>: Declare.
 771         (tui_update_source_window): Don't declare.
 772         * tui/tui-winsource.c
 773         (tui_source_window_base::update_source_window): Rename from
 774         tui_update_source_window.
 775         (tui_source_window_base::rerender): Update.
 776         * tui/tui-source.c (tui_source_window::maybe_update): Update.
 777         * tui/tui-disasm.c (tui_show_disassem)
 778         (tui_show_disassem_and_update_source)
 779         (tui_disasm_window::maybe_update): Update.
 780
 781 2019-08-16  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-winsource.h (struct tui_source_window_base)
 784         <update_source_window_as_is>: Declare.
 785         (tui_update_source_window_as_is): Don't declare.
 786         * tui/tui-winsource.c (tui_update_source_window): Update
 787         (tui_source_window_base::update_source_window_as_is): Rename from
 788         tui_update_source_window_as_is.
 789         (tui_source_window_base::refill): Update.
 790         * tui/tui-source.c (tui_show_symtab_source): Update.
 791         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
 792         Update.
 793
 794 2019-08-16  Tom Tromey  <tom@tromey.com>
 795
 796         * tui/tui-winsource.h (tui_update_source_window)
 797         (tui_update_source_window_as_is): Remove "noerror" parameter.
 798         * tui/tui-winsource.c (tui_update_source_window)
 799         (tui_update_source_window_as_is): Remove "noerror" parameter.
 800         (tui_update_source_windows_with_addr)
 801         (tui_update_source_windows_with_line)
 802         (tui_source_window_base::rerender)
 803         (tui_source_window_base::refill): Update.
 804         * tui/tui-source.h (tui_set_source_content)
 805         (tui_show_symtab_source): Remove "noerror" parameter.
 806         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
 807         parameter.
 808         (tui_show_symtab_source): Likewise.
 809         (tui_source_window::maybe_update): Update.
 810         * tui/tui-disasm.c (tui_show_disassem)
 811         (tui_show_disassem_and_update_source)
 812         (tui_disasm_window::do_scroll_vertical)
 813         (tui_disasm_window::maybe_update): Update.
 814
 815 2019-08-16  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui.c (tui_is_window_visible): Update.
 818         * tui/tui-wingeneral.c (tui_make_window)
 819         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
 820         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
 821         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
 822         (tui_set_win_height_command, parse_scrolling_args): Update.
 823         * tui/tui-source.c (tui_source_window::style_changed): Update.
 824         * tui/tui-regs.c (tui_show_registers)
 825         (tui_data_window::first_data_item_displayed)
 826         (tui_data_window::delete_data_content_windows)
 827         (tui_check_register_values, tui_reg_command): Update.
 828         * tui/tui-disasm.c (tui_show_disassem): Update.
 829         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
 830         method.
 831         <is_visible>: Remove field.
 832         * tui/tui-data.c (tui_next_win, tui_prev_win)
 833         (tui_delete_invisible_windows): Update.
 834
 835 2019-08-16  Tom Tromey  <tom@tromey.com>
 836
 837         * tui/tui-winsource.h (struct tui_source_window_base)
 838         <m_has_locator>: Remove.
 839         * tui/tui-layout.c (show_source_disasm_command, show_data)
 840         (show_source_or_disasm_and_command): Update.
 841
 842 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
 843
 844         * NEWS (Other MI changes): New subsection.
 845         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
 846         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
 847         * arch-utils.c (default_get_pc_address_flags): New function.
 848         * arch-utils.h (default_get_pc_address_flags): New declaration.
 849         * gdbarch.sh: Add get_pc_address_flags.
 850         * gdbarch.c: Regenerate.
 851         * gdbarch.h: Likewise.
 852         * stack.c (print_pc): New function.
 853         (print_frame_info) (print_frame): Call print_pc.
 854
 855 2019-08-16  Tom de Vries  <tdevries@suse.de>
 856
 857         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
 858         print_objfile_section_info.
 859
 860 2019-08-15  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
 863         calling update_cmdwin_start_line.
 864         * tui/tui-winsource.h (struct tui_source_window_base)
 865         <do_make_visible_with_new_height, set_new_height>: Don't declare.
 866         <rerender>: Declare.
 867         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
 868         Call rerender.
 869         (tui_source_window_base::set_new_height): Remove.
 870         (tui_source_window_base::rerender): Rename from
 871         do_make_visible_with_new_height.
 872         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
 873         resize method.
 874         (tui_win_info::make_invisible_and_set_new_height)
 875         (tui_win_info::make_visible_with_new_height): Remove.
 876         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
 877         Declare.
 878         * tui/tui-stack.c (tui_locator_window::rerender): New method.
 879         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
 880         do_make_visible_with_new_height>: Don't declare.
 881         <rerender>: Declare.
 882         * tui/tui-regs.c (tui_data_window::rerender): Rename from
 883         set_new_height.
 884         (tui_data_window::do_make_visible_with_new_height): Remove.
 885         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
 886         call tui_show_locator_content.
 887         (tui_gen_win_info::resize): Call rerender.
 888         (show_source_or_disasm_and_command): Don't call
 889         tui_show_locator_content.
 890         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
 891         method.
 892         (struct tui_win_info) <rerender>: Declare.
 893         <set_new_height, make_invisible_and_set_new_height,
 894         make_visible_with_new_height>: Don't declare.
 895         * tui/tui-data.c (tui_win_list::rerender): New method.
 896         * tui/tui-command.h (struct tui_cmd_window)
 897         <do_make_visible_with_new_height>: Don't declare.
 898         * tui/tui-command.c
 899         (tui_cmd_window::do_make_visible_with_new_height): Remove.
 900
 901 2019-08-15  Tom Tromey  <tromey@adacore.com>
 902
 903         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
 904         * ada-lang.c (ada_enum_name): Likewise.
 905
 906 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
 907
 908         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
 909         leading underscore.
 910         (GdbOutputErrorFile): Likewise.
 911         (global scope): Adjust constructor calls to GdbOutput{,Error}File
 912         accordingly.
 913         (execute_unwinders): Rename to have a leading underscore.
 914         (auto_load_packages): Likewise.
 915         (global scope): Adjust call to auto_load_packages accordingly.
 916         (GdbSetPythonDirectory): Likewise.
 917         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
 918         instead of execute_unwinders.
 919
 920 2019-08-15  Tom Tromey  <tom@tromey.com>
 921
 922         * tui/tui-layout.c (show_layout, show_source_disasm_command)
 923         (show_data): Don't change window visibility.
 924         (tui_gen_win_info::resize): Remove special case for command
 925         window.  Use wresize, when available.
 926         (show_source_or_disasm_and_command): Don't change window
 927         visibility.
 928         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
 929         <make_visible>: New method.
 930         * tui/tui-command.c (tui_cmd_window::resize): New method.
 931
 932 2019-08-15  Tom Tromey  <tom@tromey.com>
 933
 934         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
 935         (struct tui_source_windows): New.
 936         * tui/tui-winsource.c (tui_display_main): Update.
 937         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 938         (new_height_ok, parse_scrolling_args): Update.
 939         * tui/tui-layout.c (show_layout, show_data): Update.
 940         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
 941         (tui_add_to_source_windows): Don't declare.
 942         * tui/tui-data.c (source_windows, tui_source_windows)
 943         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
 944
 945 2019-08-15  Tom Tromey  <tom@tromey.com>
 946
 947         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
 948         Rename from reset.
 949         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
 950         * tui/tui-layout.c (show_source_disasm_command, show_data):
 951         Update.
 952         (tui_gen_win_info::resize): Rename.
 953         (show_source_or_disasm_and_command): Update.
 954         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
 955         reset.
 956
 957 2019-08-15  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-stack.c (tui_initialize_static_data): Remove.
 960         * tui/tui-interp.c (tui_interp::init): Don't call
 961         tui_initialize_static_data.
 962         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
 963
 964 2019-08-15  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
 967         examine tui_win_list.
 968
 969 2019-08-15  Tom Tromey  <tom@tromey.com>
 970
 971         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
 972         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
 973         tui_clear_source_content.
 974         (tui_clear_source_content): Remove.
 975         (tui_source_window_base::do_erase_source_content): Hoist call to
 976         content.clear().
 977         * tui/tui-stack.c (tui_show_frame_info): Don't call
 978         tui_clear_source_content.
 979
 980 2019-08-15  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui-winsource.h (struct tui_source_window_base)
 983         <do_erase_source_content>: New method.
 984         <erase_source_content>: New method.
 985         (tui_erase_source_content): Don't declare.
 986         * tui/tui-winsource.c (tui_clear_source_content): Update.
 987         (tui_source_window_base::do_erase_source_content): Rename from
 988         tui_erase_source_content.
 989         (tui_source_window_base::show_source_content): Update.
 990         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 991         * tui/tui-source.h (struct tui_source_window)
 992         <erase_source_content>: New method.
 993         * tui/tui-disasm.h (struct tui_disasm_window)
 994         <erase_source_content>: New method.
 995
 996 2019-08-15  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
 999         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1000         constructor.
1001         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1002         * tui/tui-source.c (tui_set_source_content): Update.
1003         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1004
1005 2019-08-15  Tom Tromey  <tom@tromey.com>
1006
1007         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1008         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1009         tui-source.c.
1010         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1011         Declare.
1012         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1013         method.
1014         (tui_source_window::maybe_update): Update.
1015
1016 2019-08-15  Tom Tromey  <tom@tromey.com>
1017
1018         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1019         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1020         tui-disasm.c.
1021         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1022         Declare.
1023         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1024         method.
1025         (tui_disasm_window::maybe_update): Update.
1026
1027 2019-08-15  Tom Tromey  <tom@tromey.com>
1028
1029         * tui/tui-winsource.h (struct tui_source_window_base)
1030         <maybe_update>: Declare.
1031         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1032         method.
1033         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1034         Declare.
1035         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1036         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1037         Declare.
1038         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1039
1040 2019-08-15  Tom Tromey  <tom@tromey.com>
1041
1042         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1043
1044 2019-08-15  Tom Tromey  <tom@tromey.com>
1045
1046         * tui/tui-wingeneral.c: Include tui-stack.h.
1047         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1048         (struct tui_locator_window): Move from tui-data.h.
1049         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1050         (tui_initialize_static_data): Move from tui-data.c.
1051         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1052         (struct tui_locator_window): Move to tui-stack.c.
1053         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1054         (tui_initialize_static_data): Move to tui-stack.c.
1055
1056 2019-08-15  Tom Tromey  <tom@tromey.com>
1057
1058         * tui/tui-layout.c (show_source_disasm_command)
1059         (show_source_or_disasm_and_command): Use make_visible method, not
1060         tui_make_window.
1061         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1062         Remove.
1063
1064 2019-08-15  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-wingeneral.h (tui_make_window): Update.
1067         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1068         parameter.
1069         (tui_gen_win_info::make_visible): Update.
1070         * tui/tui-regs.c (tui_data_window::display_registers_from):
1071         Update.
1072         * tui/tui-layout.c (show_source_disasm_command)
1073         (show_source_or_disasm_and_command): Update.
1074         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1075         (enum tui_box): Remove.
1076         (struct tui_win_info) <can_box>: New method.
1077         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1078         method.
1079
1080 2019-08-15  Tom de Vries  <tdevries@suse.de>
1081
1082         * linux-nat-trad.c: Include gdbarch.h.
1083
1084 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1085
1086         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1087         register sizes.
1088
1089 2019-08-14  Tom Tromey  <tromey@adacore.com>
1090
1091         * darwin-nat.c: Include gdbarch.h.
1092         * darwin-nat-info.c: Include gdbarch.h.
1093
1094 2019-08-13  Tom Tromey  <tom@tromey.com>
1095
1096         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1097         Remove.
1098         * tui/tui-data.c (tui_initialize_static_data): Update.
1099
1100 2019-08-13  Tom Tromey  <tom@tromey.com>
1101
1102         * tui/tui-winsource.h (struct tui_exec_info_window)
1103         <~tui_exec_info_window, maybe_allocate_content, get_content,
1104         m_content>: Remove.
1105         (struct tui_source_window_base) <set_exec_info_content,
1106         show_exec_info_content>: Don't declare.
1107         * tui/tui-winsource.c
1108         (tui_exec_info_window::maybe_allocate_content): Remove.
1109         (tui_source_window_base::update_exec_info): Rename from
1110         set_exec_info_content.
1111         (tui_source_window_base::show_exec_info_content)
1112         (tui_source_window_base::update_exec_info): Remove.
1113
1114 2019-08-13  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1117         declare.
1118         * tui/tui-winsource.c (tui_update_source_window_as_is)
1119         (tui_update_source_windows_with_addr, tui_erase_source_content):
1120         Update.
1121         (tui_clear_exec_info_content): Remove.
1122
1123 2019-08-13  Tom Tromey  <tom@tromey.com>
1124
1125         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1126         declare.
1127         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1128         call tui_erase_exec_info_content.
1129         (tui_clear_exec_info_content): Rename from
1130         tui_erase_exec_info_content.
1131         (tui_clear_exec_info_content): Delete.
1132
1133 2019-08-13  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-winsource.h (struct tui_source_window_base)
1136         <show_exec_info_content>: Declare.
1137         (tui_show_exec_info_content): Don't declare.
1138         * tui/tui-winsource.c
1139         (tui_source_window_base::show_exec_info_content): Rename from
1140         tui_show_exec_info_content.
1141         (tui_source_window_base::update_exec_info): Update.
1142
1143 2019-08-13  Tom Tromey  <tom@tromey.com>
1144
1145         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1146         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1147         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1148         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1149         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1150         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1151         ... here.
1152
1153 2019-08-13  Tom Tromey  <tom@tromey.com>
1154
1155         * tui/tui-winsource.h (struct tui_source_window_base)
1156         <update_exec_info>: Declare.
1157         (tui_update_exec_info): Don't declare.
1158         * tui/tui-winsource.c (tui_update_source_window_as_is)
1159         (tui_source_window_base::refresh_all)
1160         (tui_update_all_breakpoint_info): Update.
1161         (tui_source_window_base::update_exec_info): Rename from
1162         tui_update_exec_info.
1163         * tui/tui-stack.c (tui_show_frame_info): Update.
1164
1165 2019-08-13  Tom Tromey  <tom@tromey.com>
1166
1167         * tui/tui-winsource.h (struct tui_source_window_base)
1168         <set_exec_info_content>: Declare.
1169         (tui_set_exec_info_content): Don't declare.
1170         * tui/tui-winsource.c
1171         (tui_source_window_base::set_exec_info_content): Rename from
1172         tui_set_exec_info_content.
1173         (tui_update_exec_info): Update.
1174
1175 2019-08-13  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-winsource.h (struct tui_source_window_base)
1178         <show_source_content>: Declare.
1179         (tui_show_source_content): Don't declare.
1180         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1181         (tui_source_window_base::show_source_content): Rename from
1182         tui_show_source_content.
1183         (tui_source_window_base::refresh_all): Update.
1184         * tui/tui-layout.c (show_source_disasm_command)
1185         (show_source_or_disasm_and_command): Update.
1186
1187 2019-08-13  Tom Tromey  <tom@tromey.com>
1188
1189         * tui/tui-winsource.c (tui_erase_source_content)
1190         (tui_show_source_content, tui_source_window_base::refresh_all):
1191         Update.
1192         * tui/tui-wingeneral.h
1193         (tui_check_and_display_highlight_if_needed): Don't declare.
1194         * tui/tui-wingeneral.c
1195         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1196         check_and_display_highlight_if_needed.
1197         * tui/tui-win.c (tui_rehighlight_all)
1198         (tui_win_info::make_visible_with_new_height): Update.
1199         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1200         (tui_data_window::erase_data_content)
1201         (tui_data_window::display_all_data): Update.
1202         * tui/tui-data.h (struct tui_win_info)
1203         <check_and_display_highlight_if_needed>: Declare.
1204
1205 2019-08-13  Tom Tromey  <tom@tromey.com>
1206
1207         * tui/tui-win.c (tui_resize_all): Call
1208         tui_delete_invisible_windows.
1209         * tui/tui-layout.c (show_layout): Call
1210         tui_delete_invisible_windows.
1211         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1212         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1213
1214 2019-08-13  Tom Tromey  <tom@tromey.com>
1215
1216         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1217         tui_add_win_to_layout.
1218
1219 2019-08-13  Tom Tromey  <tom@tromey.com>
1220
1221         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1222         * tui/tui-layout.c (tui_default_win_height): Now static.
1223
1224 2019-08-13  Tom Tromey  <tom@tromey.com>
1225
1226         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1227         single switch.
1228         (show_source_disasm_command, show_source_or_disasm_and_command):
1229         Don't check current layout.
1230
1231 2019-08-13  Tom Tromey  <tom@tromey.com>
1232
1233         * tui/tui-wingeneral.c (make_all_visible): Remove.
1234         (tui_make_all_invisible): Simplify.
1235         * tui/tui-layout.c (tui_make_all_invisible): Move from
1236         tui-wingeneral.c; simplify.
1237         (show_layout): Hoist call to tui_make_all_invisible.
1238         (show_data): Don't call tui_make_all_invisible.
1239
1240 2019-08-13  Tom Tromey  <tom@tromey.com>
1241
1242         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1243         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1244
1245 2019-08-13  Tom Tromey  <tom@tromey.com>
1246
1247         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1248         tui-data.c.
1249         (show_source_disasm_command, show_data)
1250         (show_source_or_disasm_and_command): Don't use
1251         tui_set_current_layout_to.
1252         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1253         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1254         tui-layout.c.
1255         (tui_set_current_layout_to): Remove.
1256
1257 2019-08-13  Tom Tromey  <tom@tromey.com>
1258
1259         * tui/tui-layout.c (tui_set_layout): Update.
1260         * tui/tui-data.h (struct tui_layout_def): Remove.
1261         (tui_layout_def): Don't declare.
1262         * tui/tui-data.c (layout_def): Remove.
1263         (tui_layout_def): Remove.
1264
1265 2019-08-13  Tom Tromey  <tom@tromey.com>
1266
1267         * tui/tui-winsource.h (struct tui_source_window_base)
1268         <clear_detail>: No longer "override".
1269         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1270         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1271         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1272         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1273         Remove.
1274         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1275
1276 2019-08-13  Tom Tromey  <tromey@adacore.com>
1277
1278         * tracepoint.c: Don't include readline.h or history.h.
1279
1280 2019-08-12  Tom Tromey  <tom@tromey.com>
1281
1282         * configure: Rebuild.
1283         * configure.ac: Check for readline 7.
1284         * NEWS: Mention readline 7 requirement.
1285         * README: Update.
1286
1287 2019-08-12  Tom Tromey  <tom@tromey.com>
1288
1289         * mingw-hdep.c (gdb_select): Remove readline hack.
1290
1291 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1292
1293         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1294         when the function fails.
1295
1296 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1297
1298         * s390-tdep.c (s390_type_align): New function.
1299         (s390_gdbarch_init): Set it as type_align gdbarch method.
1300
1301 2019-08-09  Tom de Vries  <tdevries@suse.de>
1302
1303         PR gdb/24591
1304         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1305         pc_low with relocation offset.
1306
1307 2019-08-07  Tom Tromey  <tromey@adacore.com>
1308
1309         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1310         (print_frame_args): Update.
1311         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1312         Update.
1313         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1314         * frame.h (struct frame_arg): Add initializers.
1315         <error>: Now a unique_xmalloc_ptr.
1316
1317 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1318
1319         * NEWS: Expand the Pointer Authentication entry.
1320         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1321         (aarch64_frame_unmask_lr): ... to this.
1322         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1323         Call aarch64_frame_unmask_lr.
1324         * frame.c (struct frame_info): Add "masked" variable.
1325         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1326         (fprint_frame): Check for masked pc.
1327         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1328         declarations.
1329         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1330         * stack.c (print_frame): Check for masked pc.
1331
1332 2019-08-06  Tom Tromey  <tom@tromey.com>
1333
1334         * stabsread.c (patch_block_stabs, read_one_struct_field)
1335         (read_enum_type): Use obstack_strndup.
1336         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1337         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1338         * dwarf2read.c (guess_full_die_structure_name)
1339         (anonymous_struct_prefix): Use obstack_strndup.
1340         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1341         * c-exp.y (yylex): Use obstack_strndup.
1342         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1343         (write_var_or_type): Use obstack_strndup.
1344
1345 2019-08-06  Tom Tromey  <tom@tromey.com>
1346
1347         * symfile.c (reread_symbols): Use obstack_strdup.
1348         * stabsread.c (read_type): Use obstack_strdup.
1349         * gdb_obstack.h (obstack_strdup): New overload.
1350         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1351         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1352         (dwarf2_canonicalize_name): Use obstack_strdup.
1353         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1354         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1355         Use obstack_strdup.
1356
1357 2019-08-06  Tom Tromey  <tom@tromey.com>
1358
1359         * gdb_obstack.h (obstack_strdup): Define.
1360         * gdb_obstack.c (obstack_strdup): Don't define.
1361
1362 2019-08-06  Tom Tromey  <tom@tromey.com>
1363
1364         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1365         obstack_strdup.
1366         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1367         obstack_strdup.
1368         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1369         * stabsread.c (common_block_start): Use obstack_strdup.
1370         * objfiles.c (set_objfile_main_name, objfile): Use
1371         obstack_strdup.
1372         * namespace.c (add_using_directive): Use obstack_strdup.
1373         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1374         * jit.c (finalize_symtab): Use obstack_strdup.
1375         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
1376         (guess_partial_die_structure_name, partial_die_info::fixup)
1377         (dwarf2_name): Use obstack_strdup.
1378         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
1379         obstack_strdup.
1380         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
1381         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
1382         obstack_strdup.
1383         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
1384
1385 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1386
1387         * unittests/help-doc-selftests.c: New file.
1388         * Makefile.in: Add the new file.
1389
1390 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1391
1392         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
1393         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
1394         the full first line, except when FOR_VALUE_PREFIX.  In this case,
1395         the trailing '.' is not output, and the first character is uppercased.
1396         (print_help_for_command): Update call to print_doc_line.
1397         (print_doc_of_command): Likewise.
1398         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
1399         * cli/cli-option.c (append_indented_doc): Do not append newline.
1400         (build_help_option): Append newline after first appended_indented_doc
1401         only if a second call is done.
1402         (build_help): Append 2 new lines before each option, except the first
1403         one.
1404         * compile/compile.c (_initialize_compile): Add new lines after
1405         %OPTIONS%, when not at the end of the help.
1406         Change help doc or code
1407         producing the help doc to respect the invariants.
1408         * maint-test-options.c (_initialize_maint_test_options): Likewise.
1409         Also removed the new line after 'Options:', as all other commands
1410         do not put an empty line between 'Options:' and the first option.
1411         * printcmd.c (_initialize_printcmd): Likewise.
1412         * stack.c (_initialize_stack): Likewise.
1413         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
1414         incorrectly telling COMMAND is optional.
1415         * ada-lang.c (_initialize_ada_language): Change help doc or code
1416         producing the help doc to respect the invariants.
1417         * ada-tasks.c (_initialize_ada_tasks): Likewise.
1418         * breakpoint.c (_initialize_breakpoint): Likewise.
1419         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
1420         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
1421         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
1422         * cli/cli-style.c (cli_style_option::add_setshow_commands,
1423         _initialize_cli_style): Likewise.
1424         * corelow.c (core_target_info): Likewise.
1425         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
1426         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
1427         * filesystem.c (_initialize_filesystem): Likewise.
1428         * frame.c (_initialize_frame): Likewise.
1429         * gnu-nat.c (add_task_commands): Likewise.
1430         * infcall.c (_initialize_infcall): Likewise.
1431         * infcmd.c (_initialize_infcmd): Likewise.
1432         * interps.c (_initialize_interpreter): Likewise.
1433         * language.c (_initialize_language): Likewise.
1434         * linux-fork.c (_initialize_linux_fork): Likewise.
1435         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
1436         * maint.c (_initialize_maint_cmds): Likewise.
1437         * memattr.c (_initialize_mem): Likewise.
1438         * printcmd.c (_initialize_printcmd): Likewise.
1439         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
1440         _RegEx): Likewise.
1441         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
1442         * record-btrace.c (_initialize_record_btrace): Likewise.
1443         * record-full.c (_initialize_record_full): Likewise.
1444         * record.c (_initialize_record): Likewise.
1445         * regcache-dump.c (_initialize_regcache_dump): Likewise.
1446         * regcache.c (_initialize_regcache): Likewise.
1447         * remote.c (add_packet_config_cmd, init_remote_threadtests,
1448         _initialize_remote): Likewise.
1449         * ser-tcp.c (_initialize_ser_tcp): Likewise.
1450         * serial.c (_initialize_serial): Likewise.
1451         * skip.c (_initialize_step_skip): Likewise.
1452         * source.c (_initialize_source): Likewise.
1453         * stack.c (_initialize_stack): Likewise.
1454         * symfile.c (_initialize_symfile): Likewise.
1455         * symtab.c (_initialize_symtab): Likewise.
1456         * target-descriptions.c (_initialize_target_descriptions): Likewise.
1457         * top.c (init_main): Likewise.
1458         * tracefile-tfile.c (tfile_target_info): Likewise.
1459         * tracepoint.c (_initialize_tracepoint): Likewise.
1460         * tui/tui-win.c (_initialize_tui_win): Likewise.
1461         * utils.c (add_internal_problem_command): Likewise.
1462         * valprint.c (value_print_option_defs): Likewise.
1463
1464 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
1465
1466         PR build/24886
1467         * configure.ac: Drop enable-libmcheck support.
1468         * configure, config.in: Rebuild.
1469         * libmcheck.m4: Remove.
1470         * acinclude.m4: Don't include it.
1471         * Makefile.in: Don't distribute it.
1472         * top.c (print_gdb_configuration): Don't mention it.
1473
1474 2019-08-06  Tom Tromey  <tom@tromey.com>
1475
1476         * utils.c (set_output_style): Sometimes pass stream to
1477         emit_style_escape.
1478         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
1479         * record-btrace.c (btrace_insn_history): Update.
1480         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
1481         method.
1482         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
1483         Update initializers.
1484         <m_uiout>: New field.
1485         <m_di>: Move lower.
1486         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1487         Remove "uiout" parameter.
1488         (dump_insns): Update.
1489         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
1490         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
1491
1492 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
1493
1494         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
1495         (error_in_psymtab_expansion): Likewise.
1496         (lookup_symbol_via_quick_fns): Likewise.
1497         (basic_lookup_transparent_type_quick): Likewise.
1498         (basic_lookup_transparent_type_1): Likewise.
1499
1500 2019-08-06  Tom Tromey  <tromey@adacore.com>
1501
1502         * source.c (last_source_error): Now bool.
1503         (print_source_lines_base): Make "noprint" bool.  Only open
1504         source file when last_source_visited changes.
1505
1506 2019-08-06  Tom Tromey  <tromey@adacore.com>
1507
1508         * annotate.c (annotate_source_line): Use g_source_cache.
1509         * source-cache.c (source_cache::get_plain_source_lines): Change
1510         parameters.  Populate m_offset_cache.
1511         (source_cache::ensure): New method.
1512         (source_cache::get_line_charpos): New method.
1513         (extract_lines): Move lower.  Change parameters.
1514         (source_cache::get_source_lines): Move lower.
1515         * source-cache.h (class source_cache): Update comment.
1516         <get_line_charpos>: New method.
1517         <get_source_lines>: Update comment.
1518         <clear>: Clear m_offset_cache.
1519         <get_plain_source_lines>: Change parameters.
1520         <ensure>: New method
1521         <m_offset_cache>: New member.
1522         * source.c (forget_cached_source_info_for_objfile): Update.
1523         (info_source_command): Use g_source_cache.
1524         (find_source_lines, open_source_file_with_line_charpos): Remove.
1525         (print_source_lines_base, search_command_helper): Use g_source_cache.
1526         * source.h (open_source_file_with_line_charpos): Don't declare.
1527         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
1528         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
1529         Use g_source_cache.
1530
1531 2019-08-06  Tom Tromey  <tromey@adacore.com>
1532
1533         * source-cache.c (source_cache::get_plain_source_lines):
1534         Remove "first_line" and "last_line" parameters.
1535         (source_cache::get_source_lines): Cache plain text.
1536         * source-cache.h (class source_cache)
1537         <get_plain_source_lines>: Update.
1538
1539 2019-08-06  Tom Tromey  <tromey@adacore.com>
1540
1541         * source-cache.c (extract_lines): No longer a method.
1542         Changed type of parameter.  Include final newline.
1543         (selftests::extract_lines_test): New function.
1544         (_initialize_source_cache): Likewise.
1545         * source-cache.h (class source_cache)
1546         <extract_lines>: Don't declare.
1547
1548 2019-08-06  Tom Tromey  <tromey@adacore.com>
1549
1550         * breakpoint.c (init_breakpoint_sal): Update.
1551         (breakpoint): Update.
1552         * breakpoint.h (struct breakpoint) <filter>: Now a
1553         unique_xmalloc_ptr.
1554
1555 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1556
1557         * NEWS: Mention dictionary access on blocks.
1558         * python/py-block.c (blpy_getitem): New function.
1559         (block_object_as_mapping): New struct.
1560         (block_object_type): Use new struct for tp_as_mapping field.
1561
1562 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
1563
1564         * objfiles.h (objfile): Add a comment describing partial symbols.
1565
1566 2019-08-05  Tom Tromey  <tromey@adacore.com>
1567
1568         * compile/compile.c (_initialize_compile): Use _(), not N_().
1569         * thread.c (_initialize_thread): Use _(), not N_().
1570         * stack.c (_initialize_stack): Use _(), not N_().
1571         * printcmd.c (_initialize_printcmd): Use _(), not N_().
1572
1573 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
1574
1575         * dwarf2read.c (struct dw2_symtab_iterator):
1576         <want_specific_block>: Remove.
1577         <block_index>: Change type to gdb::optional.
1578         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
1579         change type of BLOCK_INDEX parameter to gdb::optional.
1580         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
1581         (dw2_lookup_symbol): Don't pass argument for
1582         WANT_SPECIFIC_BLOCK.
1583         (dw2_expand_symtabs_for_function): Don't pass argument for
1584         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
1585         (class dw2_debug_names_iterator)
1586         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
1587         parameter, change BLOCK_INDEX type to gdb::optional.
1588         <m_want_specific_block>: Remove.
1589         <m_block_index>: Change type to gdb::optional.
1590         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
1591         gdb::optional.  Re-write in function of gdb::optional.
1592         (dw2_debug_names_lookup_symbol): Don't pass argument for
1593         WANT_SPECIFIC_BLOCK.
1594         (dw2_debug_names_expand_symtabs_for_function): Don't pass
1595         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
1596         BLOCK_INDEX.
1597
1598 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1599
1600         * NEWS: Mention changes to "info sources" command.
1601
1602 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1603
1604         * symtab.c (filename_partial_match_opts): New struct type.
1605         (struct output_source_filename_data): New members
1606         regexp, c_regexp, partial_match.
1607         (output_source_filename): Use new members to decide to print file.
1608         (info_sources_option_defs): New variable.
1609         (make_info_sources_options_def_group, print_info_sources_header,
1610         info_sources_command_completer):
1611         New functions.
1612         (info_sources_command): Read new optional arguments.
1613         (_initialize_symtab): Update info sources help.
1614
1615 2019-08-02  Alexandre Oliva <oliva@adacore.com>
1616
1617         * ada-lang.c (exception_support_info_v0): Renamed from...
1618         (default_exception_support_info): ... this.  Create new
1619         definition for v1.
1620         (ada_has_this_exception_support): Look up catch_handlers_sym.
1621         (ada_exception_support_info_sniffer): Try v0 after default.
1622
1623 2019-08-01  Tom Tromey  <tromey@adacore.com>
1624
1625         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
1626         gdbarch.h.
1627
1628 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
1629
1630         * s12z-tdep.c: Fix include path for s12z-opc.h.
1631
1632 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
1633
1634         * NEWS: Require GNU make 3.82.
1635
1636 2019-07-16  Tom Tromey  <tom@tromey.com>
1637
1638         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
1639         declare.
1640
1641 2019-07-30  Tom Tromey  <tromey@adacore.com>
1642
1643         * block.c (contained_in): Remove BLOCK_FUNCTION check.
1644
1645 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
1646
1647         * printcmd.c (print_address_symbolic): Print negative offsets.
1648         (build_address_symbolic): Force signed arithmetic when computing
1649         offset.
1650
1651 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
1652
1653         PR/24474: Add a function to lookup static variables.
1654         * NEWS: Mention this new function.
1655         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
1656         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
1657         * python/python.c (python_GdbMethods): Add new function.
1658
1659 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
1660
1661         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
1662         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
1663         (objfpy_lookup_static_symbol): New function.
1664         (objfile_object_methods): Add new functions.
1665
1666 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1667
1668         * NEWS: Mention 'set|show print frame-info'.  Mention new
1669         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
1670         backtrace argument.  Mention that python frame filtering code
1671         is now consistent with what 'backtrace' command prints.
1672
1673 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1674
1675         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
1676         comments.
1677         (print_frame_info_auto, print_frame_info_source_line,
1678         print_frame_info_location, print_frame_info_source_and_location,
1679         print_frame_info_location_and_address, print_frame_info_short_location):
1680         New declarations.
1681         (struct frame_print_options): New member print_frame_info.
1682         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
1683         * stack.h (get_user_print_what_frame_info): New declaration.
1684         (frame_show_address): New declaration.
1685         * stack.c (print_frame_arguments_choices): New value 'presence'.
1686         (print_frame_info_auto, print_frame_info_source_line,
1687         print_frame_info_location, print_frame_info_source_and_location,
1688         print_frame_info_location_and_address, print_frame_info_short_location,
1689         print_frame_info_choices, print_frame_info_print_what): New definitions.
1690         (print_frame_args): Only print dots for args if print frame-arguments
1691         is 'presence'.
1692         (frame_print_option_defs): New element for "frame-info".
1693         (get_user_print_what_frame_info): New function.
1694         (frame_show_address): Make non static.  Move comment to stack.h.
1695         (print_frame_info_to_print_what): New function.
1696         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
1697         to decide what to print.
1698         (backtrace_command_1): Handle the new print_frame_arguments_presence
1699         value.
1700         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
1701         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
1702         (py_print_frame): In non-mi mode, use LOCATION as default for
1703         print_what, similarly to frame information printed directly by
1704         backtrace command. Handle frame-info user option in non MI mode.
1705
1706 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1707
1708         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
1709         Add case for debugging 32-bit target on 64-bit host.  Revise
1710         comment.
1711
1712 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1713
1714         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
1715         instead of find_function_entry_range_from_pc.
1716
1717 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
1718
1719         * stack.c (find_frame_funname): Remove code which preferred
1720         minsym over symtab sym in "certain pathological cases".
1721
1722         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
1723         parameter.  Change type of "do_demangle" to bool.
1724         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
1725         Pass suitable "prefer_sym_over_minsym" flag to
1726         build_address_symbolic().  Don't output "+" for negative offsets.
1727         * printcmd.c (print_address_symbolic): Update invocation of
1728         build_address_symbolic to include a "prefer_sym_over_minsym"
1729         flag.
1730         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
1731         Restrict cases in which use of minimal symbol is preferred to that
1732         of a found symbol.  Update comments.
1733
1734         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
1735         for entry pc when entry pc is out of range for that FDE.
1736
1737 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
1738
1739         PR gdb/24839:
1740         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
1741         type.
1742
1743 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
1744
1745         * python/py-objfile.c (add_separate_debug_file): Fix comment about
1746         this function's Python signature.
1747
1748
1749 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
1750
1751         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
1752         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1753         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
1754         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
1755         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
1756
1757
1758 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
1759
1760         * h8300-tdep.c (h8300_register_name_common): New.
1761         h8300_register_name): Use h8300_register_name_common.
1762         (h8300s_register_name): Likewise.
1763         (h8300sx_register_name): Likewise.
1764         (h8300h_register_nam): New.
1765         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
1766
1767
1768 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
1769
1770         * arm-tdep.c (arm_skip_cmse_entry): New function.
1771         (arm_is_sgstubs_section): New function.
1772         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
1773
1774 2019-07-22  Tom Tromey  <tom@tromey.com>
1775
1776         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
1777         Don't self-assign.
1778
1779 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1780
1781         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
1782         type_print.
1783
1784 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1785
1786         * symtab.c (search_symbols): Adjust msymbol matching type arrays
1787         so that GDB doesn't match any msymbols when searching in the
1788         TYPES_DOMAIN.
1789         (print_symbol_info): Print using typedef_print or type_print based
1790         on the type of the symbol.  Add updated FIXME comment moved from...
1791         (_initialize_symtab): ... move and update FIXME comment to above.
1792
1793 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1794
1795         * NEWS: Mention adding -q option to "info types".
1796         * symtab.c (struct info_types_options): New struct.
1797         (info_types_options_defs): New variable.
1798         (make_info_types_options_def_group): New function.
1799         (info_types_command): Use gdb::option framework to parse options.
1800         (info_types_command_completer): New function.
1801         (_initialize_symtab): Extend the help text on "info types" and
1802         register command completer.
1803
1804 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
1805
1806         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
1807         (lookup_symbol_in_objfile): Change int to block_enum and add a
1808         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
1809
1810 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
1811
1812         * MAINTAINERS (Write After Approval): Add self.
1813
1814 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
1815
1816         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
1817         instruction to the dummy code region.
1818
1819 2019-07-19  Tom Tromey  <tromey@adacore.com>
1820
1821         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
1822         (ARGSUSED, PARAMS, __func__): Remove rules.
1823
1824 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1825
1826         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
1827         * features/arm/arm-with-iwmmxt.c: Remove.
1828         * features/arm/arm-with-iwmmxt.xml: Remove.
1829         * features/arm/arm-with-m-fpa-layout.c: Remove.
1830         * features/arm/arm-with-m-fpa-layout.xml: Remove.
1831         * features/arm/arm-with-m-vfp-d16.c: Remove.
1832         * features/arm/arm-with-m-vfp-d16.xml: Remove.
1833         * features/arm/arm-with-m.c: Remove.
1834         * features/arm/arm-with-m.xml: Remove.
1835         * features/arm/arm-with-neon.c: Remove.
1836         * features/arm/arm-with-neon.xml: Remove.
1837         * features/arm/arm-with-vfpv2.c: Remove.
1838         * features/arm/arm-with-vfpv2.xml: Remove.
1839         * features/arm/arm-with-vfpv3.c: Remove.
1840         * features/arm/arm-with-vfpv3.xml: Remove.
1841
1842 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1843
1844         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
1845
1846 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1847
1848         * arch/aarch32.c (aarch32_create_target_description): Create
1849         target descriptions using features.
1850         * arch/arm.c (arm_create_target_description)
1851         (arm_create_mprofile_target_description): Likewise.
1852         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
1853
1854 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
1855
1856         * Makefile.in: Add new files.
1857         * aarch32-tdep.c: New file.
1858         * aarch32-tdep.h: New file.
1859         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1860         Call aarch32_read_description.
1861         * arch/aarch32.c: New file.
1862         * arch/aarch32.h: New file.
1863         * arch/arm.c (arm_create_target_description)
1864         (arm_create_mprofile_target_description): New function.
1865         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
1866         (arm_create_target_description)
1867         (arm_create_mprofile_target_description): New declaration.
1868         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
1869         read_description functions.
1870         * arm-linux-nat.c (arm_linux_nat_target::read_description):
1871         Likewise.
1872         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1873         * arm-tdep.c (tdesc_arm_list): New variable.
1874         (arm_register_g_packet_guesses): Call create description functions.
1875         (arm_read_description) (arm_read_mprofile_description): New
1876         function.
1877         * arm-tdep.h (arm_read_description)
1878         (arm_read_mprofile_description): Add declaration.
1879         * configure.tgt: Add new files.
1880
1881 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
1882
1883         * top.c (new_ui_command): Open specified terminal just once.
1884
1885 2019-07-18  Tom Tromey  <tromey@adacore.com>
1886
1887         * symtab.c (main_name): Constify return type.
1888         * symfile.c (set_initial_language): Update.
1889         * symtab.h (main_name): Constify return type.
1890
1891 2019-07-17  Tom Tromey  <tom@tromey.com>
1892
1893         * tui/tui-winsource.c (tui_update_source_window)
1894         (tui_update_source_window_as_is)
1895         (tui_update_source_windows_with_line): Remove return.
1896         * tui/tui-disasm.c (tui_show_disassem)
1897         (tui_show_disassem_and_update_source): Remove return.
1898         * tui/tui.c (tui_reset): Remove return.
1899         * tui/tui-wingeneral.c
1900         (tui_check_and_display_highlight_if_needed): Remove return.
1901
1902 2019-07-17  Tom Tromey  <tom@tromey.com>
1903
1904         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
1905
1906 2019-07-17  Tom Tromey  <tom@tromey.com>
1907
1908         * tui/tui-winsource.h (struct tui_exec_info_window)
1909         (struct tui_source_window_base): Move from tui-data.h.
1910         * tui/tui-winsource.c: Move many method definitions from
1911         elsewhere.  Remove "structuring" comments.
1912         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
1913         (tui_source_window_base::refresh_window): Move to
1914         tui-winsource.c.
1915         * tui/tui-win.c (tui_source_window_base::refresh_all)
1916         (tui_source_window_base::update_tab_width)
1917         (tui_source_window_base::set_new_height)
1918         (tui_source_window_base::do_make_visible_with_new_height): Move to
1919         tui-winsource.c.
1920         * tui/tui-source.h: Update.
1921         * tui/tui-source.c (tui_source_window_base::reset): Move to
1922         tui-winsource.c.
1923         * tui/tui-disasm.h: Update.
1924         * tui/tui-data.h (struct tui_exec_info_window): Move to
1925         tui-winsource.h.
1926         (struct tui_source_window_base): Likewise.
1927         * tui/tui-data.c (tui_source_window_base::clear_detail)
1928         (tui_source_window_base, ~tui_source_window_base): Move to
1929         tui-winsource.c.
1930
1931 2019-07-17  Tom Tromey  <tom@tromey.com>
1932
1933         * tui/tui-win.c (tui_resize_all)
1934         (tui_source_window_base::update_tab_width)
1935         (tui_adjust_win_heights): Update.
1936         (tui_win_info::make_invisible_and_set_new_height): Rename from
1937         make_invisible_and_set_new_height.
1938         * tui/tui-data.h (struct tui_win_info)
1939         <make_invisible_and_set_new_height>: New method.
1940
1941 2019-07-17  Tom Tromey  <tom@tromey.com>
1942
1943         * tui/tui.c: Update.
1944         * tui/tui-source.h (struct tui_source_window): Move from
1945         tui-data.h.
1946         * tui/tui-layout.c: Update.
1947         * tui/tui-disasm.c: Update.
1948         * tui/tui-data.h (struct tui_source_window): Move to
1949         tui-source.h.
1950
1951 2019-07-17  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui-disasm.h (struct tui_disasm_window): Move from
1954         tui-data.h.
1955         * tui/tui-data.h (struct tui_disasm_window): Move to
1956         tui-disasm.h.
1957
1958 2019-07-17  Tom Tromey  <tom@tromey.com>
1959
1960         * tui/tui-regs.h (struct tui_data_item_window): Move from
1961         tui-data.h.
1962         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
1963         * tui/tui-data.h (struct tui_data_item_window): Move to
1964         tui-regs.h.
1965         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
1966
1967 2019-07-17  Tom Tromey  <tom@tromey.com>
1968
1969         * tui/tui.c: Update.
1970         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
1971         (tui_cmd_window::max_height): Move to tui-command.c.
1972         * tui/tui-layout.c: Update.
1973         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
1974         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
1975         tui-command.c.
1976         * tui/tui-command.h (struct tui_cmd_window): Move from
1977         tui-data.h.
1978         * tui/tui-command.c: Remove "structuring" comments.
1979         (tui_cmd_window::clear_detail)
1980         (tui_cmd_window::do_make_visible_with_new_height)
1981         (tui_cmd_window::max_height): Move from elsewhere.
1982
1983 2019-07-17  Tom Tromey  <tom@tromey.com>
1984
1985         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
1986         Now static.
1987         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
1988         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
1989
1990 2019-07-17  Tom Tromey  <tom@tromey.com>
1991
1992         * tui/tui.c: Update.
1993         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
1994         tui-regs.c.
1995         * tui/tui-windata.h: Remove file.
1996         * tui/tui-windata.c: Remove file.
1997         * tui/tui-win.c (tui_data_window::set_new_height)
1998         (tui_data_window::do_make_visible_with_new_height): Move to
1999         tui-regs.c.
2000         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2001         * tui/tui-regs.c: Remove "structuring" comments.
2002         (tui_data_window::first_data_item_displayed)
2003         (tui_data_window::delete_data_content_windows)
2004         (tui_data_window::erase_data_content)
2005         (tui_data_window::display_all_data)
2006         (tui_data_window::refresh_all)
2007         (tui_data_window::do_scroll_vertical)
2008         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2009         (tui_data_window::do_make_visible_with_new_height)
2010         (tui_data_window::refresh_window): Move from elsewhere.
2011         (_initialize_tui_regs): Move to end of file.
2012         * tui/tui-layout.c: Update.
2013         * tui/tui-hooks.c: Update.
2014         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2015         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2016         tui-regs.c.
2017         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2018
2019 2019-07-17  Tom Tromey  <tom@tromey.com>
2020
2021         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2022         seen.
2023
2024 2019-07-17  Tom Tromey  <tom@tromey.com>
2025
2026         * tui/tui-win.c (tui_source_window_base::set_new_height)
2027         (tui_source_window_base::do_make_visible_with_new_height): Use
2028         m_has_locator field directly.
2029         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2030         method.
2031         (struct tui_source_window_base) <has_locator>: Likewise.
2032
2033 2019-07-17  Tom Tromey  <tom@tromey.com>
2034
2035         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2036         Don't declare.
2037         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2038         Remove.
2039         * tui/tui-win.c (tui_source_window_base::set_new_height)
2040         (tui_source_window_base::set_new_height)
2041         (make_invisible_and_set_new_height)
2042         (tui_source_window_base::do_make_visible_with_new_height)
2043         (tui_source_window_base::do_make_visible_with_new_height):
2044         Update.
2045         * tui/tui-layout.c (show_source_disasm_command, show_data)
2046         (show_source_or_disasm_and_command): Update.
2047         * tui/tui-layout.c (show_layout): Update.
2048
2049 2019-07-17  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-layout.c (make_data_window): Remove.
2052         (show_data): Unify creation and re-initialization cases.
2053
2054 2019-07-17  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-layout.c (make_source_window, make_disasm_window):
2057         Remove.
2058         (show_data): Unify creation and re-initialization cases.
2059
2060 2019-07-17  Tom Tromey  <tom@tromey.com>
2061
2062         * tui/tui-layout.c (make_command_window): Remove.
2063         (show_source_disasm_command, show_source_or_disasm_and_command):
2064         Unify creation and re-initialization cases.
2065
2066 2019-07-17  Tom Tromey  <tom@tromey.com>
2067
2068         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2069         creation and re-initialization cases.
2070
2071 2019-07-17  Tom Tromey  <tom@tromey.com>
2072
2073         * tui/tui-regs.c (tui_get_register): Return void.
2074
2075 2019-07-17  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2078         Simplify.
2079
2080 2019-07-17  Tom Tromey  <tom@tromey.com>
2081
2082         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2083         resetting.
2084
2085 2019-07-17  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2088         * tui/tui-regs.c (tui_reg_layout): New function.
2089         (tui_show_registers, tui_reg_command): Use it.
2090         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2091         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2092         parameters.
2093         (tui_layout_command): Remove.
2094
2095 2019-07-17  Tom Tromey  <tom@tromey.com>
2096
2097         * tui/tui-layout.h (tui/tui-layout): Return void.
2098         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2099
2100 2019-07-17  Tom Tromey  <tom@tromey.com>
2101
2102         * tui/tui-layout.c (show_source_disasm_command, show_data):
2103         Update.
2104         (reset_locator): Remove.
2105         (show_source_or_disasm_and_command): Update.
2106
2107 2019-07-17  Tom Tromey  <tom@tromey.com>
2108
2109         * tui/tui-source.c (tui_source_window_base::reset): Remove
2110         win_type parameter.
2111         * tui/tui-layout.c (make_command_window, make_source_window)
2112         (make_disasm_window, make_data_window)
2113         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2114         (reset_locator, show_source_or_disasm_and_command): Update.
2115         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2116         win_type parameter.
2117         (struct tui_source_window_base) <reset>: Likewise.
2118
2119 2019-07-17  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-layout.c (show_source_disasm_command): Use
2122         reset_locator.
2123         (reset_locator): New function.
2124         (init_and_make_win): Remove.
2125         (show_source_or_disasm_and_command): Use reset_locator.
2126
2127 2019-07-17  Tom Tromey  <tom@tromey.com>
2128
2129         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2130         condition.
2131         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2132         Remove condition.
2133         * tui/tui-source.c (tui_source_window_base::reset): New method.
2134         * tui/tui-layout.c (make_command_window): Don't call
2135         init_and_make_win.
2136         (make_source_window, make_disasm_window): Don't call
2137         make_source_or_disasm_window.
2138         (make_data_window): Don't call init_and_make_win.  Change calling
2139         convention.
2140         (show_source_disasm_command, show_data): Simplify.
2141         (make_source_or_disasm_window): Remove.
2142         (show_source_or_disasm_and_command): Simplify.
2143         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2144         (struct tui_source_window_base) <reset>: Likewise.
2145         <execution_info>: Remove initializer.
2146         * tui/tui-data.c (tui_source_window_base): Initialize
2147         execution_info.
2148
2149 2019-07-17  Tom Tromey  <tom@tromey.com>
2150
2151         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2152         variable.
2153
2154 2019-07-17  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui.c (tui_rl_other_window): Update.
2157         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2158         superclass method first.  Always iterate over regs_content.
2159         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2160         method.
2161         * tui/tui-win.c (tui_set_focus_command): Update.
2162
2163 2019-07-17  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-win.c (tui_set_focus_command): Rename from
2166         tui_set_focus.  Call tui_enable.
2167         (tui_set_focus_command): Remove.
2168
2169 2019-07-17  Tom Tromey  <tom@tromey.com>
2170
2171         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2172         refresh_window.
2173         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2174         touchwin.
2175         (tui_data_window::refresh_window): Call refresh_window on data
2176         items.  Always call superclass refresh_window.
2177         (tui_win_info::refresh): Remove.
2178         (tui_source_window_base::refresh_window): Update.
2179         (tui_refresh_all): Update.
2180         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2181         refresh_window.
2182         (show_source_or_disasm_and_command): Likewise.
2183         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2184         (struct tui_source_window_base) <refresh>: Likewise.
2185
2186 2019-07-17  Tom Tromey  <tom@tromey.com>
2187
2188         * tui/tui-winsource.c (tui_clear_source_content)
2189         (tui_show_source_content): Update.
2190         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2191         whether content is empty.
2192         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2193         Remove.
2194
2195 2019-07-17  Tom Tromey  <tom@tromey.com>
2196
2197         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2198         window's contents.
2199         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2200         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2201
2202 2019-07-17  Tom Tromey  <tom@tromey.com>
2203
2204         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2205         (struct tui_data_item_window): Update.
2206
2207 2019-07-17  Tom Tromey  <tom@tromey.com>
2208
2209         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2210         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2211         defines.
2212
2213 2019-07-17  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-winsource.h (tui_erase_source_content)
2216         (tui_clear_source_content): Remove "display_prompt" parameter.
2217         * tui/tui-winsource.c (tui_update_source_window_as_is)
2218         (tui_update_source_windows_with_addr): Update.
2219         (tui_clear_source_content): Remove "display_prompt" parameter.
2220         (tui_erase_source_content): Likewise.  Simplify.
2221         (tui_show_source_content): Update.
2222         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2223         * tui/tui-stack.c (tui_show_frame_info): Update.
2224         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2225         Remove defines.
2226
2227 2019-07-17  Tom Tromey  <tom@tromey.com>
2228
2229         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2230         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2231         parameter.
2232         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2233         parameter.
2234
2235 2019-07-17  Tom Tromey  <tom@tromey.com>
2236
2237         * tui/tui-winsource.c (tui_clear_source_content)
2238         (tui_show_source_content, tui_show_exec_info_content)
2239         (tui_clear_exec_info_content): Update.
2240         * tui/tui-stack.c (tui_show_locator_content): Update.
2241         (tui_show_frame_info): Update.
2242         * tui/tui-source.h (tui_source_window): Don't declare.
2243         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2244         from tui_source_is_displayed.
2245         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2246         Remove field.
2247         (struct tui_source_window_base) <content_in_use>: New field.  Now
2248         bool.
2249         (struct tui_source_window) <showing_source_p>: New method.
2250         (TUI_SRC_WIN): Change cast.
2251         * tui/tui-data.c (tui_initialize_static_data): Update.
2252
2253 2019-07-17  Tom Tromey  <tom@tromey.com>
2254
2255         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2256         location_matches_p.
2257         * tui/tui-source.c (tui_source_window::location_matches_p): New
2258         method.
2259         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2260         method.
2261         * tui/tui-data.h (struct tui_source_window_base)
2262         <location_matches_p>: New method.
2263         (struct tui_source_window, struct tui_disasm_window)
2264         <location_matches_p>: Likewise.
2265
2266 2019-07-17  Tom Tromey  <tom@tromey.com>
2267
2268         * tui/tui-win.c (tui_set_win_height_command): Rename from
2269         tui_set_win_height.
2270         (tui_set_win_height_command): Remove.
2271
2272 2019-07-17  Tom Tromey  <tom@tromey.com>
2273
2274         * tui/tui-source.c (tui_source_window): New constructor.  Add
2275         observer.
2276         (~tui_source_window): New destructor.
2277         (tui_source_window::style_changed): New method.
2278         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2279         (tui_attach_detach_observers): Update.
2280         * tui/tui-data.h (struct tui_source_window): Make constructor not
2281         inline.  Add destructor.
2282         (struct tui_source_window) <style_changed>: New method.
2283         <m_observable>: New member.
2284
2285 2019-07-17  Tom Tromey  <tom@tromey.com>
2286
2287         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2288         * tui/tui-win.c (tui_resize_all): Fix typo.
2289
2290 2019-07-17  Tom Tromey  <tom@tromey.com>
2291
2292         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2293         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2294         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2295         * tui/tui-win.c (window_name_completer): Use foreach.
2296         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2297         (update_tab_width): Likewise.
2298         * tui/tui-layout.c (show_layout): Update.
2299         * tui/tui-data.h (class tui_window_iterator): New.
2300         (struct all_tui_windows): New.
2301         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2302
2303 2019-07-17  Tom Tromey  <tom@tromey.com>
2304
2305         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2306         parameter.  Don't reference globals.
2307         (tui_reg_command): Update.
2308
2309 2019-07-17  Tom Tromey  <tom@tromey.com>
2310
2311         * tui/tui-regs.c (tui_show_registers): Simplify.
2312
2313 2019-07-17  Tom Tromey  <tom@tromey.com>
2314
2315         * tui/tui-regs.c (tui_show_registers): Update.
2316         (tui_show_register_group): Add win_info parameter.
2317
2318 2019-07-17  Tom Tromey  <tom@tromey.com>
2319
2320         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2321         Rename from tui_display_reg_element_at_line.
2322         (tui_data_window::display_registers_from_line): Update.
2323         * tui/tui-data.h (struct tui_data_window)
2324         <display_reg_element_at_line>: New method.
2325
2326 2019-07-17  Tom Tromey  <tom@tromey.com>
2327
2328         * tui/tui-regs.h (tui_display_registers_from)
2329         (tui_display_registers_from_line): Don't declare.
2330         * tui/tui-windata.c (tui_data_window::display_all_data)
2331         (tui_data_window::refresh_all)
2332         (tui_data_window::do_scroll_vertical): Update.
2333         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2334         from tui_display_registers_from.
2335         (tui_display_reg_element_at_line): Update.
2336         (tui_data_window::display_registers_from_line): Rename from
2337         tui_display_registers_from_line.
2338         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2339         display_registers_from_line>: New methods.
2340
2341 2019-07-17  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2344         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2345         from tui_erase_data_content.
2346         (tui_data_window::display_all_data)
2347         (tui_data_window::refresh_all)
2348         (tui_data_window::do_scroll_vertical): Update.
2349         * tui/tui-regs.c (tui_show_registers): Update.
2350         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2351         New method.
2352
2353 2019-07-17  Tom Tromey  <tom@tromey.com>
2354
2355         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2356         declare.
2357         * tui/tui-windata.c
2358         (tui_data_window::delete_data_content_windows): Rename from
2359         tui_delete_data_content_windows.
2360         (tui_data_window::display_all_data)
2361         (tui_data_window::do_scroll_vertical): Update.
2362         * tui/tui-data.h (struct tui_data_window)
2363         <delete_data_content_windows>: New method.
2364
2365 2019-07-17  Tom Tromey  <tom@tromey.com>
2366
2367         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2368         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2369
2370 2019-07-17  Tom Tromey  <tom@tromey.com>
2371
2372         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2373         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2374         from tui_display_all_data.
2375         * tui/tui-win.c
2376         (tui_data_window::do_make_visible_with_new_height): Update.
2377         * tui/tui-regs.c (tui_show_registers): Update.
2378         * tui/tui-layout.c (tui_set_layout): Update.
2379         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
2380         method.
2381
2382 2019-07-17  Tom Tromey  <tom@tromey.com>
2383
2384         * tui/tui-windata.h (tui_display_data_from): Don't declare.
2385         * tui/tui-windata.c (tui_display_data_from): Remove.
2386         (tui_data_window::refresh_all): Update.
2387
2388 2019-07-17  Tom Tromey  <tom@tromey.com>
2389
2390         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
2391         * tui/tui-windata.c (tui_display_data_from_line): Remove.
2392         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
2393         tui_display_registers_from_line.
2394         * tui/tui-regs.h (tui_display_registers_from_line): Update.
2395         * tui/tui-regs.c (tui_display_registers_from_line): Remove
2396         "force_display" parameter.
2397
2398 2019-07-17  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
2401         declare.
2402         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
2403         Rename from tui_first_reg_element_no_inline.
2404         (tui_display_reg_element_at_line)
2405         (tui_display_registers_from_line): Update.
2406         * tui/tui-data.h (struct tui_data_window)
2407         <first_reg_element_no_inline>: New method.
2408
2409 2019-07-17  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-windata.c (tui_display_data_from)
2412         (tui_data_window::do_scroll_vertical): Update.
2413         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
2414         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
2415         Rename from tui_line_from_reg_element_no.
2416         (tui_display_registers_from_line): Update.
2417         * tui/tui-data.h (struct tui_data_window)
2418         <line_from_reg_element_no>: New method.
2419
2420 2019-07-17  Tom Tromey  <tom@tromey.com>
2421
2422         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
2423         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
2424         tui_last_regs_line_no.
2425         (tui_display_reg_element_at_line)
2426         (tui_display_registers_from_line): Update.
2427         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
2428         method.
2429
2430 2019-07-17  Tom Tromey  <tom@tromey.com>
2431
2432         PR tui/24722:
2433         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
2434         (tui_update_breakpoint_info): Add "being_deleted" parameter.
2435         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2436         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
2437         (tui_update_breakpoint_info): Likewise.
2438         * tui/tui-hooks.c (tui_event_create_breakpoint)
2439         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
2440         Update.
2441
2442 2019-07-17  Tom Tromey  <tom@tromey.com>
2443
2444         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
2445
2446 2019-07-17  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-winsource.c (tui_update_source_window_as_is)
2449         (tui_update_source_windows_with_addr): Update.
2450         * tui/tui-source.h (tui_set_source_content)
2451         (tui_show_symtab_source): Add "win_info" parameter.
2452         * tui/tui-source.c (tui_set_source_content): Add "win_info"
2453         parameter.
2454         (tui_show_symtab_source): Likewise.
2455
2456 2019-07-17  Tom Tromey  <tom@tromey.com>
2457
2458         * tui/tui-wingeneral.c
2459         (tui_check_and_display_highlight_if_needed): Check can_highlight.
2460
2461 2019-07-17  Tom Tromey  <tom@tromey.com>
2462
2463         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
2464         (struct tui_cmd_window) <can_scroll>: New method.
2465         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
2466         method.
2467
2468 2019-07-17  Tom Tromey  <tromey@adacore.com>
2469
2470         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
2471         do_field_signed>: Rename.  Change type of "value".
2472         * ui-out.c (ui_out::field_signed): Rename from field_int.
2473         Change type of "value".
2474         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
2475         type of "value".
2476         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
2477         do_field_int.  Change type of "value".
2478         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
2479         do_field_int.  Change type of "value".
2480         * tracepoint.c (trace_status_mi, tfind_1)
2481         (print_one_static_tracepoint_marker): Update.
2482         * thread.c (print_thread_info_1, print_selected_thread_frame):
2483         Update.
2484         * stack.c (print_frame, print_frame_info): Update.
2485         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
2486         Update.
2487         * source.c (print_source_lines_base): Update.
2488         * skip.c (info_skip_command): Update.
2489         * record-btrace.c (btrace_ui_out_decode_error)
2490         (btrace_call_history_src_line): Update.
2491         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
2492         Update.
2493         * progspace.c (print_program_space): Update.
2494         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
2495         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
2496         do_field_int.  Change type of "value".
2497         * mi/mi-out.c (mi_ui_out::do_table_begin)
2498         (mi_ui_out::do_table_header): Update.
2499         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
2500         type of "value".
2501         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
2502         (mi_cmd_data_list_changed_registers, output_register)
2503         (mi_cmd_data_read_memory, mi_load_progress)
2504         (mi_cmd_trace_frame_collected): Update.
2505         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
2506         Update.
2507         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
2508         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
2509         (mi_cmd_var_list_children, varobj_update_one): Update.
2510         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
2511         (mi_cmd_stack_list_args, list_arg_or_local): Update.
2512         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
2513         * inferior.c (print_inferior): Update.
2514         * gdb_bfd.c (print_one_bfd): Update.
2515         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2516         Update.
2517         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
2518         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
2519         do_field_int.  Change type of "value".
2520         * cli-out.c (cli_ui_out::do_field_signed): Rename from
2521         do_field_int.  Change type of "value".
2522         * breakpoint.c (watchpoint_check, print_breakpoint_location)
2523         (print_one_breakpoint_location, print_it_catch_fork)
2524         (print_one_catch_fork, print_it_catch_vfork)
2525         (print_one_catch_vfork, print_it_catch_solib)
2526         (print_it_catch_exec, print_it_ranged_breakpoint)
2527         (print_mention_watchpoint, print_mention_masked_watchpoint)
2528         (bkpt_print_it, update_static_tracepoint): Update.
2529         * break-catch-throw.c (print_it_exception_catchpoint): Update.
2530         * break-catch-syscall.c (print_it_catch_syscall): Update.
2531         * ada-tasks.c (print_ada_task_info): Update.
2532         * ada-lang.c (print_it_exception, print_mention_exception):
2533         Update.
2534
2535 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
2536
2537         PR breakpoints/24541
2538         * gdbarch.c: Regenerate.
2539         * gdbarch.h: Regenerate.
2540         * gdbarch.sh: Adjust return type and parameter types for
2541         'stap_adjust_register'.
2542         (i386_stap_adjust_register): Adjust signature and return new
2543         register name.
2544         * stap-probe.c (stap_parse_register_operand): Adjust use of
2545         'gdbarch_stap_adjust_register'.
2546
2547 2019-07-17  Tom Tromey  <tromey@adacore.com>
2548
2549         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
2550         declare VEC.
2551         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
2552         std::vector.
2553         (struct s390_process_info): Add initializers.
2554         (s390_add_process): Use new.
2555         (s390_linux_nat_target::low_forget_process): Use delete.
2556         (s390_linux_nat_target::low_new_fork)
2557         (s390_linux_nat_target::stopped_by_watchpoint)
2558         (s390_linux_nat_target::low_prepare_to_resume)
2559         (s390_linux_nat_target::insert_watchpoint)
2560         (s390_linux_nat_target::insert_hw_breakpoint)
2561         (s390_linux_nat_target::remove_watchpoint)
2562         (s390_linux_nat_target::remove_hw_breakpoint): Update.
2563
2564 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2565
2566         * aarch64-fbsd-nat.c: Include regcache.h.
2567         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
2568         argument.
2569         (aarch64_fbsd_nat_target::fetch_registers)
2570         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
2571         variable.
2572         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
2573
2574 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
2575
2576         * fbsd-nat.c: Include gdbarch.h.
2577
2578 2019-07-15  Tom Tromey  <tromey@adacore.com>
2579
2580         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
2581
2582 2019-07-15  Tom Tromey  <tromey@adacore.com>
2583
2584         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
2585         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
2586         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
2587         * cli-out.c (cli_ui_out::do_field_int): New method.
2588         * ui-out.c (ui_out::field_unsigned): New method.
2589         * symfile.c (generic_load): Use field_unsigned.
2590         (print_transfer_performance): Likewise.
2591         * record-btrace.c (ui_out_field_uint): Remove.
2592         (btrace_call_history_insn_range, btrace_call_history): Use
2593         field_unsigned.
2594         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
2595         field_unsigned.
2596         * ui-out.h (class ui_out) <field_unsigned>: New method.
2597         <do_field_unsigned>: Likewise.
2598
2599 2019-07-15  Tom Tromey  <tromey@adacore.com>
2600
2601         * mi/mi-main.c (list_available_thread_groups): Use field_string.
2602         * mi/mi-interp.c (mi_memory_changed): Use field_string.
2603         * target.c (flash_erase_command): Use field_string.
2604         * infrun.c (print_signal_received_reason): Use field_string.
2605         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
2606         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
2607         field_string.
2608         * ada-tasks.c (print_ada_task_info): Use field_string.
2609
2610 2019-07-15  Tom Tromey  <tromey@adacore.com>
2611
2612         * target.c (flash_erase_command): Use field_core_addr.
2613         * symfile.c (generic_load): Use field_core_addr.
2614         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
2615         Use field_core_addr.
2616         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
2617         field_core_addr.
2618
2619 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2620
2621         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
2622         value if its desired type is smaller than a CORE_ADDR and signed.
2623
2624 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2625
2626         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
2627         of changes to field names, and use new is_reference field to
2628         decide if a property is a reference or not.
2629         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
2630         field.
2631         (struct dwarf2_property_baton): Update header comment, rename
2632         'referenced_type' to 'property_type' and update comments.
2633         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
2634         default property type, store in property baton, update to take
2635         accound of renamed field.
2636         (read_func_scope): Update call to attr_to_dynamic_prop.
2637         (read_array_type): Likewise.
2638         (dwarf2_per_cu_addr_sized_int_type): New function.
2639         (read_subrange_index_type): Move type finding code to
2640         dwarf2_per_cu_addr_sized_int_type.
2641         (read_subrange_type): Update calls to attr_to_dynamic_prop.
2642         (dwarf2_per_cu_addr_type): New function.
2643         (set_die_type): Update calls to attr_to_dynamic_prop.
2644
2645 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2646
2647         * dwarf2read.c (read_subrange_index_type): New function.
2648         (read_subrange_type): Move code into new function and call it.
2649         * gdbtypes.c (create_range_type): Add some asserts.
2650
2651 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2652
2653         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
2654         update return statements.
2655         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
2656         declaration, and update comment to match.
2657         * gdbtypes.c (resolve_dynamic_array): Update call to
2658         dwarf2_evaluate_property to match new return type.
2659
2660 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2661
2662         * valarith.c (value_subscripted_rvalue): Change lowerbound
2663         parameter type from int to LONGEST.
2664         * value.h (value_subscripted_rvalue): Likewise in declaration.
2665
2666 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2667
2668         * cli/cli-utils.c (info_print_command_completer): New function.
2669         * cli/cli-utils.h: Add 'completer.h' include, and forward
2670         declaration for 'struct cmd_list_element'.
2671         (info_print_command_completer): Declare.
2672         * stack.c (_initialize_stack): Add completer for 'info locals' and
2673         'info args'.
2674         * symtab.c (_initialize_symtab): Add completer for 'info
2675         variables' and 'info functions'.
2676         * NEWS: Mention completion for additional info commands.
2677
2678 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2679
2680         * cli/cli-utils.c (extract_info_print_args): Delete.
2681         (extract_arg_maybe_quoted): Delete.
2682         (info_print_options_defs): New variable.
2683         (make_info_print_options_def_group): New function.
2684         (extract_info_print_options): Define new function.
2685         * cli/cli-utils.h (extract_info_print_args): Delete.
2686         (struct info_print_options): New structure.
2687         (extract_info_print_options): Declare new function.
2688         * stack.c (info_locals_command): Update to use new
2689         extract_info_print_options, also add a header comment.
2690         (info_args_command): Likewise.
2691         * symtab.c (info_variables_command): Likewise.
2692         (info_functions_command): Likewise.
2693
2694 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2695
2696         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
2697         to extract string arguments.
2698         * common/common-utils.c (extract_string_maybe_quoted): New function.
2699         * common/common-utils.h (extract_string_maybe_quoted): Declare.
2700
2701 2019-07-11  Tom Tromey  <tromey@adacore.com>
2702
2703         * main.c (get_init_files): Use GDBINIT, not gdbinit.
2704         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
2705         * top.h (gdbinit): Don't declare.
2706         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
2707         into...
2708         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
2709         * top.c (gdb_init): Don't call init_cli_cmds.
2710         (gdbinit): Remove.
2711         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
2712
2713 2019-07-11  Tom Tromey  <tromey@adacore.com>
2714
2715         * python/py-inferior.c (add_thread_object): Don't use thread_obj
2716         after it has been moved.
2717
2718 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2719
2720         * valops.c (value_must_coerce_to_target): Change return type to
2721         bool.
2722         * value.h (value_must_coerce_to_target): Likewise.
2723
2724 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
2725
2726         * breakpoint.c (is_hardware_watchpoint): Remove
2727         forward-declaration.
2728         (is_masked_watchpoint): Change return type to bool.
2729         (is_tracepoint): Likewise.
2730         (is_breakpoint): Likewise.
2731         (is_hardware_watchpoint): Likewise.
2732         (is_watchpoint): Likewise.
2733         (is_no_memory_software_watchpoint): Likewise.
2734         (is_catchpoint): Likewise.
2735         (breakpoint_1): Make FILTER parameter's return type bool.
2736         is_masked_watchpoint): Change return type to bool.
2737         (save_breakpoints): Make FILTER parameter's return type bool.
2738         * breakpoint.h (is_breakpoint): Change return type to bool.
2739         (is_watchpoint): Likewise.
2740         (is_catchpoint): Likewise.
2741         (is_tracepoint): Likewise.
2742
2743 2019-07-10  Tom Tromey  <tom@tromey.com>
2744
2745         * defs.h: Don't include gdbarch.h.
2746         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
2747         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
2748         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
2749         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
2750         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
2751         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
2752         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
2753         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
2754         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
2755         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
2756         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
2757         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
2758         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
2759         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
2760         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
2761         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
2762         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
2763         record-btrace.c, record.h, regcache-dump.c, regcache.h,
2764         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
2765         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
2766         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
2767         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
2768         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
2769         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
2770         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
2771         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
2772         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
2773
2774 2019-07-10  Tom Tromey  <tromey@adacore.com>
2775
2776         * ada-lang.h (is_ada_exception_catchpoint): Declare.
2777         * breakpoint.c (init_ada_exception_breakpoint): Register as
2778         bp_catchpoint.
2779         (print_one_breakpoint_location, print_one_breakpoint): Use
2780         is_ada_exception_catchpoint.
2781         * ada-lang.c (class ada_catchpoint_location): Pass
2782         bp_loc_software_breakpoint to bp_location constructor.
2783         (is_ada_exception_catchpoint): New function.
2784
2785 2019-07-10  Tom Tromey  <tromey@adacore.com>
2786
2787         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
2788         VEC.
2789         (struct arm_exidx_entry): New method operator<.
2790         (struct arm_exidx_data) <section_maps>: Change type.
2791         (arm_exidx_data_free): Remove.
2792         (arm_exidx_data_key): Change type.  Move lower.
2793         (arm_exidx_new_objfile): Update.
2794         (arm_compare_exidx_entries): Remove.
2795         (arm_find_exidx_entry, _initialize_arm_tdep)
2796
2797 2019-07-10  Tom Tromey  <tromey@adacore.com>
2798
2799         * solib-spu.c (ocl_program_data_key): Change type.
2800         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
2801         Update.
2802
2803 2019-07-10  Tom Tromey  <tromey@adacore.com>
2804
2805         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
2806         (struct solib_aix_inferior_data) <library_list>: Change type.
2807         (solib_aix_inferior_data_handle): Change type.
2808         (get_solib_aix_inferior_data): Update.
2809         (solib_aix_free_library_list): Remove.
2810         (library_list_start_library): Update.
2811         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
2812         return type.
2813         (solib_aix_get_library_list)
2814         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
2815         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
2816
2817 2019-07-10  Tom Tromey  <tromey@adacore.com>
2818
2819         * solib-dsbt.c (struct dsbt_info): Add initializers.
2820         (solib_dsbt_pspace_data): Change type.
2821         (dsbt_pspace_data_cleanup): Remove.
2822         (get_dsbt_info, _initialize_dsbt_solib): Update.
2823
2824 2019-07-10  Tom Tromey  <tromey@adacore.com>
2825
2826         * spu-tdep.c (spu_overlay_data): Change type.
2827         (spu_get_overlay_table, spu_overlay_new_objfile)
2828         (_initialize_spu_tdep): Update.
2829
2830 2019-07-10  Tom Tromey  <tromey@adacore.com>
2831
2832         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
2833         destructor.
2834         (dbx_objfile_data_key): Change type and declare later.
2835         (DBX_SYMFILE_INFO): Rewrite.
2836         * dbxread.c (dbx_objfile_data_key): Change type.
2837         (dbx_symfile_init): Update.
2838         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
2839         (coffstab_build_psymtabs, elfstab_build_psymtabs)
2840         (stabsect_build_psymtabs, _initialize_dbxread): Update.
2841
2842 2019-07-10  Tom Tromey  <tromey@adacore.com>
2843
2844         * jit.c (jit_program_space_key): Change type.  Move lower.
2845         (get_jit_program_space_data): Update.
2846         (jit_program_space_data_cleanup): Remove.
2847         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
2848         Update.
2849         (struct jit_program_space_data): Add initializers.
2850
2851 2019-07-10  Tom Tromey  <tromey@adacore.com>
2852
2853         * solib-darwin.c (struct darwin_info): Add initializers.
2854         (solib_darwin_pspace_data): Change type.
2855         (darwin_pspace_data_cleanup): Remove.
2856         (get_darwin_info, _initialize_darwin_solib): Update.
2857
2858 2019-07-10  Tom Tromey  <tromey@adacore.com>
2859
2860         * remote-sim.c (struct sim_inferior_data): Add initializers,
2861         constructor, and destructor.
2862         (sim_inferior_data_key): Change type.  Move lower.
2863         (check_for_duplicate_sim_descriptor): Update.
2864         (get_sim_inferior_data): Use new.  Update.
2865         (~sim_inferior_data_cleanup): Rename from
2866         sim_inferior_data_cleanup.  Simplify.
2867         (gdbsim_close_inferior, simulator_command)
2868         (sim_command_completer, _initialize_remote_sim): Update.
2869         (next_pid, INITIAL_PID): Move earlier.
2870
2871 2019-07-10  Tom Tromey  <tromey@adacore.com>
2872
2873         * python/python-internal.h (create_thread_object): Return
2874         gdbpy_ref.
2875         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
2876         * python/py-inferior.c (struct threadlist_entry): Add
2877         constructor.
2878         <thread_obj>: Now a gdbpy_ref.
2879         (thread_to_thread_object): Update.
2880         (add_thread_object): Use new.
2881         (delete_thread_object): Use delete.
2882         (infpy_threads): Update.
2883         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
2884         GIL.
2885
2886 2019-07-10  Tom Tromey  <tromey@adacore.com>
2887
2888         * valops.c (value_cast): Specialize error message for Ada.
2889
2890 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2891
2892         * breakpoint.c (breakpoint_1): Update doc and parameter names.
2893
2894 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
2895
2896         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
2897         bpstat_should_step): Return bool, adjust comments.
2898         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
2899         bpstat_should_step): Likewise.
2900
2901 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2902
2903         * features/Makefile: Use feature target descriptions for Arm.
2904         * features/arm/arm-core.c: Generate new file.
2905         * features/arm/arm-fpa.c: Likewise.
2906         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
2907         * features/arm/arm-m-profile.c: Likewise.
2908         * features/arm/arm-vfpv2.c: Likewise.
2909         * features/arm/arm-vfpv3.c: Likewise.
2910         * features/arm/xscale-iwmmxt.c: Likewise.
2911         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
2912
2913 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2914
2915         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
2916         ptrace earlier.
2917
2918 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
2919
2920         * features/aarch64-pauth.c: Regenerate.
2921
2922 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
2923
2924         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
2925         bool.
2926         (bpstat_what): Use false instead of 0.
2927
2928 2019-07-09  Pedro Alves  <palves@redhat.com>
2929
2930         * break-catch-throw.c (is_exception_catchpoint): New.
2931         * breakpoint.c (print_one_breakpoint_location): New parameter
2932         'raw_loc'.  Handle it.  Use
2933         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
2934         looking at the breakpoint's type.
2935         (print_one_breakpoint): If handling "maint info breakpoints", also
2936         print locations of exception catchpoints.
2937         * breakpoint.h (is_exception_catchpoint): Declare.
2938
2939 2019-07-09  Pedro Alves  <palves@redhat.com>
2940
2941         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
2942         "addr" field.
2943         (allocate_location_exception_catchpoint): New.
2944         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
2945         (initialize_throw_catchpoint_ops): Install
2946         allocate_location_exception_catchpoint as allocate_location
2947         method.
2948         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
2949         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
2950         bp_loc_other.
2951         (breakpoint_address_is_meaningful): Delete.
2952         (bl_address_is_meaningful): New.
2953         (breakpoint_locations_match): Adjust comment.
2954         (bp_location_from_bp_type): New, factored out of...
2955         (bp_location::bp_location(breakpoint *)): ... this.
2956         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
2957         factored out of...
2958         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
2959         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
2960         breakpoint_address_is_meaningful.
2961         (bp_locations_compare): Adjust comment.
2962         (update_global_location_list): Use bl_address_is_meaningful
2963         instead of breakpoint_address_is_meaningful.
2964         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
2965         explicit.
2966         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
2967         * python/py-breakpoint.c (bppy_get_location): No longer check
2968         whether location is null.
2969
2970 2019-07-09  Pedro Alves  <palves@redhat.com>
2971
2972         PR c++/15468
2973         * breakpoint.c (print_one_breakpoint_location): Remove
2974         single-location assert.
2975
2976 2019-07-09  Tom Tromey  <tom@tromey.com>
2977
2978         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
2979         * configure: Rebuild.
2980         * configure.ac: Change common to gdbsupport.
2981         * gdbsupport: Rename from common.
2982         * acinclude.m4: Change common to gdbsupport.
2983         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
2984         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
2985         gdbsupport.
2986         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
2987         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
2988         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
2989         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
2990         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
2991         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
2992         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
2993         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
2994         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
2995         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
2996         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
2997         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
2998         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
2999         coff-pe-read.c, command.h, compile/compile-c-support.c,
3000         compile/compile-c.h, compile/compile-cplus-symbols.c,
3001         compile/compile-cplus-types.c, compile/compile-cplus.h,
3002         compile/compile-loc2c.c, compile/compile.c, completer.c,
3003         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3004         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3005         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3006         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3007         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3008         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3009         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3010         features/aarch64-core.c, features/aarch64-fpu.c,
3011         features/aarch64-pauth.c, features/aarch64-sve.c,
3012         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3013         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3014         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3015         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3016         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3017         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3018         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3019         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3020         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3021         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3022         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3023         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3024         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3025         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3026         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3027         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3028         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3029         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3030         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3031         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3032         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3033         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3034         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3035         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3036         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3037         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3038         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3039         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3040         minsyms.c, mips-linux-tdep.c, namespace.h,
3041         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3042         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3043         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3044         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3045         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3046         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3047         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3048         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3049         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3050         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3051         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3052         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3053         procfs.c, producer.c, progspace.h, psymtab.h,
3054         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3055         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3056         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3057         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3058         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3059         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3060         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3061         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3062         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3063         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3064         target-memory.c, target.c, target.h, target/waitstatus.c,
3065         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3066         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3067         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3068         unittests/array-view-selftests.c,
3069         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3070         unittests/common-utils-selftests.c,
3071         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3072         unittests/format_pieces-selftests.c,
3073         unittests/function-view-selftests.c,
3074         unittests/lookup_name_info-selftests.c,
3075         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3076         unittests/mkdir-recursive-selftests.c,
3077         unittests/observable-selftests.c,
3078         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3079         unittests/parse-connection-spec-selftests.c,
3080         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3081         unittests/scoped_fd-selftests.c,
3082         unittests/scoped_mmap-selftests.c,
3083         unittests/scoped_restore-selftests.c,
3084         unittests/string_view-selftests.c, unittests/style-selftests.c,
3085         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3086         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3087         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3088         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3089         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3090         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3091
3092 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3093
3094         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3095         bool value.
3096         (decode_digits_ordinary): Set explicit_line field in sal.
3097         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3098         symtab_and_line that was set on an explicit line number in
3099         assembler code.  Do always update the recorded symtab and line if
3100         we do skip the prologue.
3101
3102 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3103
3104         * breakpoint.c (set_breakpoint_location_function): Remove
3105         explicit_loc parameter.
3106         (momentary_breakpoint_from_master): Update call to
3107         set_breakpoint_location_function.
3108         (add_location_to_breakpoint): Likewise.
3109
3110 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3111
3112         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3113         required features based on default bfd type when no specific bfd
3114         is present.
3115
3116 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3117
3118         * NEWS: Mention that GDB printf and eval commands can now print
3119         C-style and Ada-style convenience var strings without
3120         calling the inferior.
3121         * printcmd.c (printf_c_string): Locally print GDB internal var
3122         instead of transiting via the inferior.
3123         (printf_wide_c_string): Likewise.
3124
3125 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3126
3127         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3128
3129 2019-07-04  Tom Tromey  <tom@tromey.com>
3130
3131         PR tui/24724:
3132         * tui/tui-winsource.c (tui_clear_source_content): Update.
3133         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3134         (tui_update_breakpoint_info): Update.
3135         (tui_set_exec_info_content): Update.
3136         * tui/tui-source.c (tui_set_source_content_nil): Update.
3137         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3138         has_break.
3139         * tui/tui-data.h (enum tui_bp_flag): New.
3140         (tui_bp_flags): New enum flags type.
3141         (struct tui_source_element) <break_mode>: Change type.  Rename
3142         from has_break.
3143         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3144         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3145         constants.
3146         * tui/tui-winsource.h: Fix comment.
3147
3148 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3149
3150         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3151         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3152         (store_fpregs_to_thread)
3153         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3154         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3155         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3156         (IWMMXT_REGS_SIZE): Add define.
3157         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3158         (fetch_vfp_regs, store_vfp_regs)
3159         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3160         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3161
3162 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3163
3164         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3165         defines.
3166         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3167         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3168         (ARM_INT_REGISTER_SIZE): ...to this.
3169         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3170         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3171         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3172         (arm_linux_collect_gregset, supply_nwfpe_register)
3173         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3174         defines.
3175         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3176         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3177         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3178         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3179         (arm_return_in_memory, arm_store_return_value)
3180         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3181         (arm_record_ld_st_multiple): Likewise.
3182         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3183         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3184
3185 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3186
3187         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3188         AARCH64_DISPLACED_MODIFIED_INSNS.
3189         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3190         (aarch64_displaced_step_copy_insn): Likewise.
3191         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3192         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3193         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3194         ARM_DISPLACED_MODIFIED_INSNS.
3195         * arm-tdep.c (arm_gdbarch_init): Likewise.
3196         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3197         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3198         (struct arm_displaced_step_closure): Use
3199         ARM_DISPLACED_MODIFIED_INSNS.
3200
3201 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3202
3203         * features/Makefile: Remove unused xml files.
3204         * features/aarch64.xml: Remove.
3205         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3206         * features/i386/amd64-avx-avx512.xml: Remove.
3207         * features/i386/amd64-avx-linux.xml: Remove.
3208         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3209         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3210         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3211         * features/i386/amd64-avx-mpx.xml: Remove.
3212         * features/i386/amd64-avx.xml: Remove.
3213         * features/i386/amd64-linux.xml: Remove.
3214         * features/i386/amd64-mpx-linux.xml: Remove.
3215         * features/i386/amd64-mpx.xml: Remove.
3216         * features/i386/amd64.xml: Remove.
3217         * features/i386/i386-avx-avx512-linux.xml: Remove.
3218         * features/i386/i386-avx-avx512.xml: Remove.
3219         * features/i386/i386-avx-linux.xml: Remove.
3220         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3221         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3222         * features/i386/i386-avx-mpx-linux.xml: Remove.
3223         * features/i386/i386-avx-mpx.xml: Remove.
3224         * features/i386/i386-avx.xml: Remove.
3225         * features/i386/i386-linux.xml: Remove.
3226         * features/i386/i386-mmx-linux.xml: Remove.
3227         * features/i386/i386-mmx.xml: Remove.
3228         * features/i386/i386-mpx-linux.xml: Remove.
3229         * features/i386/i386-mpx.xml: Remove.
3230         * features/i386/i386.xml: Remove.
3231         * features/i386/x32-avx-avx512-linux.xml: Remove.
3232         * features/i386/x32-avx-linux.xml: Remove.
3233         * features/i386/x32-linux.xml: Remove.
3234
3235 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3236
3237         * regformats/aarch64.dat: Remove.
3238         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3239         * regformats/i386/amd64-avx-linux.dat: Remove.
3240         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3241         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3242         * regformats/i386/amd64-linux.dat: Remove.
3243         * regformats/i386/amd64-mpx-linux.dat: Remove.
3244         * regformats/i386/amd64.dat: Remove.
3245         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3246         * regformats/i386/i386-avx-linux.dat: Remove.
3247         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3248         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3249         * regformats/i386/i386-linux.dat: Remove.
3250         * regformats/i386/i386-mmx-linux.dat: Remove.
3251         * regformats/i386/i386-mpx-linux.dat: Remove.
3252         * regformats/i386/i386.dat: Remove.
3253         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3254         * regformats/i386/x32-avx-linux.dat: Remove.
3255         * regformats/i386/x32-linux.dat: Remove.
3256
3257 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3258
3259         * aarch64-tdep.c: Remove xml self tests.
3260         * amd64-linux-tdep.c: Likewise.
3261         * amd64-tdep.c: Likewise.
3262         * i386-linux-tdep.c: Likewise.
3263         * i386-tdep.c: Likewise.
3264
3265 2019-07-03  Pedro Alves  <palves@redhat.com>
3266
3267         PR cli/24732
3268         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3269         (pipe_cmd_option_defs): New.
3270         (make_pipe_cmd_options_def_group): New.
3271         (pipe_command): Use gdb::option::process_options.
3272         (pipe_command_completer): New function.
3273         (_initialize_cli_cmds): Install completer for "pipe" command.
3274
3275 2019-07-03  Pedro Alves  <palves@redhat.com>
3276
3277         * cli/cli-option.c (union option_value) <string>: New field.
3278         (struct option_def_and_value): Add ctor, move ctor, dtor and
3279         use DISABLE_COPY_AND_ASSIGN.
3280         (option_def_and_value::clear_value): New.
3281         (parse_option, save_option_value_in_ctx, get_val_type_str)
3282         (add_setshow_cmds_for_options): Handle var_string.
3283         * cli-option.h (union option_def::var_address) <string>: New
3284         field.
3285         (struct string_option_def): New.
3286         * maint-test-options.c (struct test_options_opts): Add default
3287         ctor and use DISABLE_COPY_AND_ASSIGN.
3288         <string_opt>: New field.
3289         (test_options_opts::~test_options_opts): New.
3290         (test_options_opts::dump): Also dump "-string".
3291         (test_options_option_defs): Install "string.
3292
3293 2019-07-03  Pedro Alves  <palves@redhat.com>
3294
3295         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3296         option_value with a null enumeration.
3297         (complete_options): Save the option values in the context.
3298         (save_option_value_in_ctx): New, factored out from ...
3299         (process_options): ... here.
3300         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3301         of the function.
3302         * maint-test-options.c (test_options_opts::dump): New, factored
3303         out from ...
3304         (maintenance_test_options_command_mode): ... here.
3305         (maintenance_test_options_command_completion_result): Delete.
3306         (maintenance_test_options_command_completion_text): Update
3307         comment.
3308         (maintenance_show_test_options_completion_result): Change
3309         prototype.  Just print
3310         maintenance_test_options_command_completion_text.
3311         (save_completion_result): New.
3312         (maintenance_test_options_completer_mode): Pass options context to
3313         complete_options, and then save a dump.
3314         (_initialize_maint_test_options): Use add_cmd to install "maint
3315         show test-options-completion-result".
3316
3317 2019-07-03  Pedro Alves  <palves@redhat.com>
3318
3319         * NEWS (New commands): Mention "with" and "maint with".
3320         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3321         (with_command, with_command_completer): New.
3322         (pipe_command): Adjust to new repeat_previous
3323         interface.
3324         (_initialize_cli_cmds): Install the "with" command and its "w"
3325         alias.
3326         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3327         declarations.
3328         * cli/cli-setshow.c (parse_cli_var_uinteger)
3329         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3330         argument strings for all var_types.
3331         (get_setshow_command_value_string): New, factored out from ...
3332         (do_show_command): ... this.
3333         * cli/cli-setshow.h: Include <string>.
3334         (get_setshow_command_value_string): Declare.
3335         * command.h (repeat_previous): Now returns const char *.  Adjust
3336         comment.
3337         * maint.c: Include "cli/cli-cmds.h".
3338         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3339         (_initialize_maint_cmds): Register the "maintenance with" command.
3340         * top.c (repeat_previous): Move bits from pipe_command here:
3341         Return the saved command line, if any; error out if there's no
3342         command to relaunch.
3343
3344 2019-07-03  Pedro Alves  <palves@redhat.com>
3345
3346         * NEWS (New commands): Mention "maint set/show test-settings"
3347         instead of "maint test-settings".
3348         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3349         (maintenance_test_settings_set_list): Rename to ...
3350         (maintenance_set_test_settings_list): ... this.
3351         (maintenance_test_settings_show_list): Rename to  ...
3352         (maintenance_show_test_settings_list): ... this.
3353         (maintenance_test_settings_cmd): Delete.
3354         (maintenance_test_settings_set_cmd): ...
3355         (maintenance_set_test_settings_cmd): ... this.
3356         (maintenance_test_settings_show_cmd): ...
3357         (maintenance_show_test_settings_cmd): ... this.
3358         (maintenance_test_settings_show_value_cmd):
3359         (maintenance_show_test_settings_value_cmd): ... this.
3360         (_initialize_maint_test_settings): No longer install the "maint
3361         test-settings" prefix command.  Rename "maint test-settings set"
3362         to "maint set test-settings", and "maint test-settings show" to
3363         "maint show test-settings".  Adjust all subcommands.
3364
3365 2019-07-03  Pedro Alves  <palves@redhat.com>
3366
3367         * maint-test-settings.c: Fix file's intro comment.  Replace all
3368         references to "test-options" with references to "test-settings",
3369         in comments.
3370
3371 2019-07-03  Pedro Alves  <palves@redhat.com>
3372
3373         * maint-test-settings.c (maintenance_test_settings_xxx)
3374         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3375         New.
3376         (maintenance_test_settings_enums): Use them.
3377         (maintenance_test_settings_enum): Default to
3378         maintenance_test_settings_xxx.
3379         (_initialize_maint_test_settings): Initialize
3380         MAINTENANCE_TEST_SETTINGS_FILENAME.
3381
3382 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3383
3384         * breakpoint.h (remove_breakpoints_inf): Change return type to
3385         void, move function documentation here.
3386         * breakpoint.c (remove_breakpoints_inf): Change return type to
3387         void, move function documentation to header.
3388
3389 2019-07-02  Pedro Alves  <palves@redhat.com>
3390
3391         * NEWS (Completion improvements): Mention "info threads".
3392         * thread.c (struct info_threads_opts, info_threads_option_defs)
3393         (make_info_threads_options_def_group): New.
3394         (info_threads_command): Use gdb::option::process_options.
3395         (info_threads_command_completer): New.
3396         (_initialize_thread): Use gdb::option::build_help to build the
3397         help text for "info threads".
3398
3399 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
3400
3401         * defs.h (generic_load): Move from here...
3402         * symfile.h (generic_load): ... to here.  Rename name parameter
3403         to args.
3404         * symfile.c (generic_load): Add comment.
3405
3406 2019-07-01  Tom Tromey  <tromey@adacore.com>
3407
3408         * dwarf2read.c
3409         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
3410         declaration of without_params.  Fix formatting.
3411
3412 2019-07-01  Tom Tromey  <tromey@adacore.com>
3413
3414         * ada-exp.y (find_primitive_type): Update.
3415         * ada-lang.h (ada_lookup_symbol): Update.
3416         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
3417         parameter.
3418         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
3419
3420 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3421
3422         PR breakpoints/24541
3423         * gdbarch.c: Regenerate.
3424         * gdbarch.h: Regenerate.
3425         * gdbarch.sh: Add 'stap_adjust_register'.
3426         * i386-tdep.c: Include '<unordered_set>'.
3427         (i386_stap_adjust_register): New function.
3428         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
3429         * stap-probe.c (stap_parse_register_operand): Call
3430         'gdbarch_stap_adjust_register'.
3431
3432 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
3433
3434         PR python/24742
3435         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
3436         * python/python.c (do_start_initialization): Use 'xmalloc'
3437         instead of 'PyMem_Malloc'.
3438
3439 2019-06-28  Tom Tromey  <tromey@adacore.com>
3440
3441         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
3442         for Ada.
3443
3444 2019-06-27  Tom Tromey  <tromey@adacore.com>
3445
3446         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
3447         objfile_key.
3448         (arm_find_mapping_symbol, arm_record_special_symbol)
3449         (_initialize_arm_tdep): Update.
3450         (arm_objfile_data_free): Remove.
3451
3452 2019-06-27  Tom Tromey  <tromey@adacore.com>
3453
3454         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
3455         to cp_print_static_field.
3456
3457 2019-06-26  Tom Tromey  <tromey@adacore.com>
3458
3459         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
3460         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
3461         declare.
3462
3463 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3464
3465         * features/aarch64-core.c (create_feature_aarch64_core):
3466         Regenerate.
3467         * features/aarch64-core.xml: Add cpsr flags.
3468
3469 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
3470
3471         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
3472         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
3473
3474 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3475
3476         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
3477         field.
3478         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
3479         use.
3480         (arm_record_special_symbol): Don't insert new symbol in sorted
3481         position, push it at the end.
3482
3483 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
3484
3485         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
3486         (arm_mapping_symbol_s): Remove.
3487         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
3488         (arm_mapping_symbol_vec): New typedef.
3489         (struct arm_per_objfile): Add constructor.
3490         <section_maps>: Change type to
3491         std::unique_ptr<arm_mapping_symbol_vec[]>.
3492         (arm_compare_mapping_symbols): Remove.
3493         (arm_find_mapping_symbol): Adjust to section_maps type change.
3494         (arm_objfile_data_free): Call delete on arm_per_objfile.
3495         (arm_record_special_symbol): Adjust to section_maps type change.
3496         Allocate arm_per_objfile with new.
3497
3498 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3499
3500         * cli/cli-cmds.c (alias_command): Compare the alias prefix
3501         with the command prefix.
3502
3503 2019-06-25  Tom Tromey  <tom@tromey.com>
3504
3505         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
3506         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
3507
3508 2019-06-25  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
3511         type.
3512         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
3513         protected.
3514
3515 2019-06-25  Tom Tromey  <tom@tromey.com>
3516
3517         * tui/tui-winsource.c
3518         (tui_source_window_base::set_is_exec_point_at): Add check against
3519         LOA_ADDRESS.
3520
3521 2019-06-25  Tom Tromey  <tom@tromey.com>
3522
3523         * tui/tui-source.c (tui_set_source_content): Don't check before
3524         xfree.
3525         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
3526
3527 2019-06-25  Tom Tromey  <tom@tromey.com>
3528
3529         * tui/tui-winsource.h (tui_update_source_window_as_is)
3530         (tui_alloc_source_buffer, tui_line_is_displayed)
3531         (tui_addr_is_displayed): Change type of win_info.
3532         * tui/tui-winsource.c (tui_update_source_window_as_is)
3533         (tui_clear_source_content, tui_show_source_line)
3534         (tui_show_source_content, tui_source_window_base::refill)
3535         (tui_source_window_base::set_is_exec_point_at)
3536         (tui_source_window_base::set_is_exec_point_at)
3537         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
3538         (tui_alloc_source_buffer, tui_line_is_displayed)
3539         (tui_addr_is_displayed): Change type of win_info.  Update.
3540         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3541         (tui_source_window_base::do_make_visible_with_new_height):
3542         Update.
3543         * tui/tui-source.c (tui_set_source_content)
3544         (tui_set_source_content_nil)
3545         (tui_source_window::do_scroll_vertical): Update.
3546         * tui/tui-layout.c (show_layout): Update.
3547         * tui/tui-disasm.c (tui_set_disassem_content)
3548         (tui_disasm_window::do_scroll_vertical): Update.
3549         * tui/tui-data.h (tui_win_content): Remove.
3550         (struct tui_gen_win_info) <content, content_size>: Remove.
3551         (struct tui_source_element): Add initializers and destructor.
3552         (union tui_which_element, struct tui_win_element): Remove.
3553         (struct tui_source_window_base) <content>: New field.
3554         (struct tui_data_window): Remove destructor.
3555         (tui_alloc_content, tui_free_win_content)
3556         (tui_free_all_source_wins_content): Don't declare.
3557         * tui/tui-data.c (tui_initialize_static_data): Update.
3558         (init_content_element, tui_alloc_content): Remove.
3559         (~tui_gen_win_info): Update.
3560         (~tui_data_window, tui_free_all_source_wins_content)
3561         (tui_free_win_content, free_content, free_content_elements):
3562         Remove.
3563
3564 2019-06-25  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-winsource.h (tui_clear_source_content)
3567         (tui_erase_source_content, tui_show_source_content): Change type
3568         of win_info.
3569         * tui/tui-winsource.c (tui_clear_source_content)
3570         (tui_erase_source_content, tui_show_source_content): Change type
3571         of win_info.
3572         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3573         * tui/tui-source.h (tui_set_source_content_nil): Change type of
3574         win_info.
3575         * tui/tui-source.c (tui_set_source_content_nil): Change type of
3576         win_info.
3577         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
3578
3579 2019-06-25  Tom Tromey  <tom@tromey.com>
3580
3581         * tui/tui-winsource.c (tui_clear_source_content)
3582         (tui_source_window_base::set_is_exec_point_at): Update.
3583         * tui/tui-source.c (tui_set_source_content_nil): Update.
3584         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
3585         a bool.
3586         * tui/tui-data.c (init_content_element): Update.
3587
3588 2019-06-25  Tom Tromey  <tom@tromey.com>
3589
3590         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
3591         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
3592         * tui/tui-layout.c (init_and_make_win): Update.
3593         * tui/tui.h (enum tui_win_type): Update.
3594         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
3595         tui_win_is_auxillary.
3596         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
3597         tui_win_is_auxillary.
3598
3599 2019-06-25  Tom Tromey  <tom@tromey.com>
3600
3601         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
3602         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
3603         (tui_delete_data_content_windows, tui_display_all_data)
3604         (tui_data_window::do_scroll_vertical, tui_display_data_from):
3605         Update.
3606         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
3607         * tui/tui-regs.c (tui_last_regs_line_no)
3608         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
3609         (tui_show_registers): Update.
3610         (tui_show_register_group): Return void.  Update.
3611         (tui_display_registers_from, tui_display_reg_element_at_line)
3612         (tui_display_registers_from_line, tui_check_register_values):
3613         Update.
3614         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
3615         member.
3616         (struct tui_data_window) <regs_content>: Now a std::vector.
3617         <regs_content_count>: Remove.
3618         (tui_add_content_elements, tui_free_data_content): Don't declare.
3619         * tui/tui-data.c (tui_data_window::clear_detail): Update.
3620         (init_content_element): Remove DATA_WIN case.  Add assert.
3621         (tui_add_content_elements): Remove.
3622         (tui_data_window): Update.
3623         (tui_free_data_content): Remove.
3624         (free_content_elements): Remove DATA_WIN case.
3625
3626 2019-06-25  Tom Tromey  <tom@tromey.com>
3627
3628         * tui/tui-data.c (tui_data_item_window): Update.
3629         * tui/tui-windata.h (tui_check_data_values): Don't declare.
3630         * tui/tui-windata.c (tui_display_all_data)
3631         (tui_display_data_from_line): Update.
3632         (tui_check_data_values): Remove.
3633         * tui/tui-regs.c (tui_show_register_group)
3634         (tui_display_reg_element_at_line): Update.
3635         * tui/tui-hooks.c (tui_register_changed)
3636         (tui_refresh_frame_and_register_information): Call
3637         tui_check_register_values.
3638         * tui/tui-data.h (struct tui_data_window) <data_content,
3639         data_content_count, data_type>: Remove.
3640         (enum tui_data_type): Remove.
3641
3642         * tui/tui-data.c (tui_data_window::clear_detail)
3643         (~tui_data_window): Update.
3644
3645 2019-06-25  Tom Tromey  <tom@tromey.com>
3646
3647         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
3648         declare.
3649         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
3650         Rename from tui_first_data_item_displayed.  Update.
3651         (tui_data_window::refresh_all)
3652         (tui_data_window::do_scroll_vertical): Update.
3653         * tui/tui-data.h (struct tui_data_window)
3654         <first_data_item_displayed>: Declare new method.
3655
3656 2019-06-25  Tom Tromey  <tom@tromey.com>
3657
3658         * tui/tui-data.h (tui_init_generic_part): Don't declare.
3659         * tui/tui-data.c (tui_init_generic_part): Remove, moving
3660         contents...
3661         (tui_initialize_static_data): ...here.
3662
3663 2019-06-25  Tom Tromey  <tom@tromey.com>
3664
3665         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3666         (tui_display_registers_from, tui_check_register_values): Update.
3667         (tui_display_register): Remove win_info parameter; update.
3668         (tui_get_register): Change type of parameters.
3669         * tui/tui-data.h (struct tui_data_element): Remove.
3670         (union tui_which_element) <data>: Remove.
3671         <data_window>: Change type.
3672         (struct tui_data_item_window): New.
3673         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
3674         case.  Add assert.
3675         (~tui_data_item_window): New destructor.
3676         (free_content_elements): Remove DATA_ITEM_WIN case.
3677
3678 2019-06-25  Tom Tromey  <tom@tromey.com>
3679
3680         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
3681         Remove.
3682
3683 2019-06-25  Tom Tromey  <tom@tromey.com>
3684
3685         * tui/tui-data.h (struct tui_command_element): Remove.
3686         (union tui_which_element) <command>: Remove.
3687         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
3688         assert.
3689         (free_content_elements): Remove CMD_WIN case.
3690
3691 2019-06-25  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-layout.c (tui_set_layout): Update.
3694         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
3695         * tui/tui-data.c (layout_def): Update.
3696
3697 2019-06-25  Tom Tromey  <tom@tromey.com>
3698
3699         * tui/tui-wingeneral.c (tui_refresh_all): Update.
3700         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
3701         (tui_source_window_base::set_new_height): Update.
3702         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
3703         Update.
3704         (tui_set_locator_fullname, tui_set_locator_info)
3705         (tui_show_frame_info): Update.
3706         * tui/tui-source.c (tui_set_source_content)
3707         (tui_source_is_displayed): Update.
3708         * tui/tui-layout.c (show_source_disasm_command, show_data)
3709         (show_source_or_disasm_and_command): Update.
3710         * tui/tui-disasm.c (tui_set_disassem_content)
3711         (tui_get_begin_asm_address): Update.
3712         * tui/tui-data.h (struct tui_locator_element): Remove.
3713         (union tui_which_element) <locator>: Remove.
3714         (struct tui_locator_window): New.
3715         (tui_locator_win_info_ptr): Change return type.
3716         * tui/tui-data.c (_locator): Change type.
3717         (tui_locator_win_info_ptr): Change return type.
3718         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
3719         (tui_alloc_content): Add assert.
3720
3721 2019-06-25  Tom Tromey  <tom@tromey.com>
3722
3723         * tui/tui-winsource.c
3724         (tui_exec_info_window::maybe_allocate_content): New method.
3725         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
3726         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
3727         (make_source_or_disasm_window): Add cast.
3728         * tui/tui-data.h (union tui_which_element) <simple_string>:
3729         Remove.
3730         (struct tui_source_info): New.
3731         (struct tui_source_window_base) <execution_info>: Change type.
3732         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
3733         case, and add assert.
3734         (tui_alloc_content): Add assert.
3735
3736 2019-06-25  Tom Tromey  <tom@tromey.com>
3737
3738         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
3739         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
3740         * tui/tui-data.c (tui_alloc_win_info): Remove.
3741
3742 2019-06-25  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
3745         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
3746         can_highlight.
3747
3748 2019-06-25  Tom Tromey  <tom@tromey.com>
3749
3750         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
3751         make_visible_with_new_height method.
3752         (tui_win_info::make_visible_with_new_height): New method.
3753         (tui_source_window_base::do_make_visible_with_new_height)
3754         (tui_data_window::do_make_visible_with_new_height)
3755         (tui_cmd_window::do_make_visible_with_new_height): New methods.
3756         (make_visible_with_new_height): Remove.
3757         (tui_resize_all, tui_adjust_win_heights): Use
3758         make_visible_with_new_height method.
3759         * tui/tui-data.h (struct tui_win_info)
3760         <do_make_visible_with_new_height, make_visible_with_new_height>:
3761         New methods.
3762         (struct tui_source_window_base, struct tui_data_window)
3763         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
3764         methods.
3765
3766 2019-06-25  Tom Tromey  <tom@tromey.com>
3767
3768         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
3769         method.
3770         (update_tab_width): Call update_tab_width method.
3771         * tui/tui-data.h (struct tui_win_info)
3772         (struct tui_source_window_base) <update_tab_width>: New methods.
3773
3774 2019-06-25  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
3777         parameter.
3778         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
3779         parameter.
3780         (tui_gen_win_info::make_visible): Update.
3781         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
3782         parameter.
3783         * tui/tui-data.h (enum tui_box): New enum.
3784         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
3785
3786 2019-06-25  Tom Tromey  <tom@tromey.com>
3787
3788         * tui/tui-layout.c (make_source_or_disasm_window): Always use
3789         init_and_make_win for EXEC_INFO_WIN.
3790         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
3791         longer inline.
3792         (struct tui_win_info) <~tui_win_info>: Inline.
3793         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3794         Don't declare.
3795         * tui/tui-data.c (source_win, disasm_win): Remove globals.
3796         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3797         Remove.
3798         (tui_initialize_static_data): Update.
3799         (~tui_gen_win_info): Handle more cleanup here.
3800         (~tui_source_window_base): Delete "execution_info".
3801         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
3802
3803 2019-06-25  Tom Tromey  <tom@tromey.com>
3804
3805         * tui/tui-layout.c (make_command_window): Don't set
3806         can_highlight.
3807         (show_source_disasm_command): Call the reset method.
3808         (show_data): Don't set can_highlight.  Call the reset method.
3809         (tui_gen_win_info::reset): Rename from init_gen_win_info
3810         (init_and_make_win): Simplify.  Return tui_gen_win_info.
3811         (show_source_or_disasm_and_command): Call the reset method.
3812         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
3813         (struct tui_cmd_window): Set can_highlight.
3814
3815 2019-06-25  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
3818         from make_visible.
3819         (tui_make_visible, tui_make_invisible): Rewrite.
3820         (tui_win_info::make_visible): Remove.
3821         (tui_source_window_base::make_visible): Update.
3822         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
3823         method.  Moved from...
3824         (struct tui_win_info) <make_visible>: ...here.
3825
3826 2019-06-25  Tom Tromey  <tom@tromey.com>
3827
3828         * tui/tui-winsource.c
3829         (tui_source_window_base::do_scroll_horizontal): Remove direction
3830         parameter.
3831         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
3832         direction parameter.
3833         * tui/tui-win.c (tui_win_info::forward_scroll)
3834         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
3835         (tui_win_info::right_scroll): Update.
3836         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
3837         direction parameter.
3838         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
3839         direction parameter.
3840         * tui/tui-data.h (enum tui_scroll_direction): Remove.
3841         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
3842         Remove direction parameter.
3843         (struct tui_source_window_base, struct tui_source_window)
3844         (struct tui_disasm_window, struct tui_data_window)
3845         (struct tui_cmd_window): Update.
3846
3847 2019-06-25  Tom Tromey  <tom@tromey.com>
3848
3849         * tui/tui-winsource.h (tui_set_exec_info_content)
3850         (tui_show_exec_info_content, tui_erase_exec_info_content)
3851         (tui_clear_exec_info_content, tui_update_exec_info): Change
3852         argument to tui_source_window_base.
3853         * tui/tui-winsource.c (tui_set_exec_info_content)
3854         (tui_show_exec_info_content, tui_erase_exec_info_content)
3855         (tui_clear_exec_info_content, tui_update_exec_info): Change
3856         argument to tui_source_window_base.
3857
3858 2019-06-25  Tom Tromey  <tom@tromey.com>
3859
3860         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
3861         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
3862
3863 2019-06-25  Tom Tromey  <tom@tromey.com>
3864
3865         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
3866         check.
3867
3868 2019-06-25  Tom Tromey  <tom@tromey.com>
3869
3870         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
3871         type to void.
3872         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
3873         type to void.
3874         * tui/tui-source.c (tui_set_source_content): Update.
3875         * tui/tui-disasm.c (tui_set_disassem_content): Update.
3876
3877 2019-06-25  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-win.c (window_name_completer, tui_set_focus)
3880         (tui_all_windows_info): Use name method.
3881         * tui/tui-data.h (struct tui_gen_win_info)
3882         (struct tui_source_window, struct tui_disasm_window)
3883         (struct tui_data_window, struct tui_cmd_window) <name>: New
3884         method.
3885         (tui_win_name): Don't declare.
3886         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
3887         (tui_win_name): Remove.
3888
3889 2019-06-25  Tom Tromey  <tom@tromey.com>
3890
3891         * tui/tui-winsource.h (tui_update_source_window)
3892         (tui_update_source_window_as_is): Change parameter type.
3893         * tui/tui-winsource.c (tui_update_source_window): Change win_info
3894         to be a tui_source_window_base.
3895         (tui_update_source_window_as_is): Likewise.
3896         * tui/tui-win.c (make_visible_with_new_height): Update.
3897
3898 2019-06-25  Tom Tromey  <tom@tromey.com>
3899
3900         * tui/tui-winsource.c (tui_erase_source_content)
3901         (tui_show_source_content, tui_show_exec_info_content)
3902         (tui_erase_exec_info_content): Use refresh_window method.
3903         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
3904         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
3905         from tui_refresh_win.
3906         (tui_data_window::refresh_window): New method.
3907         (tui_win_info::refresh, tui_source_window_base::refresh)
3908         (tui_refresh_all): Use refresh_window method.
3909         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
3910         method.
3911         * tui/tui-regs.c (tui_display_register): Call refresh_window
3912         method.
3913         * tui/tui-layout.c (show_source_disasm_command)
3914         (show_source_or_disasm_and_command): Call refresh_window method.
3915         * tui/tui-data.h (struct tui_gen_win_info)
3916         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
3917         New method.
3918
3919 2019-06-25  Tom Tromey  <tom@tromey.com>
3920
3921         * tui/tui.c (tui_rl_other_window, tui_enable)
3922         (tui_is_window_visible, tui_get_command_dimension): Update.
3923         * tui/tui-winsource.c (tui_update_source_window_as_is)
3924         (tui_clear_source_content, tui_erase_source_content)
3925         (tui_show_source_line, tui_source_window_base::refill)
3926         (tui_source_window_base::do_scroll_horizontal)
3927         (tui_source_window_base::set_is_exec_point_at)
3928         (tui_update_breakpoint_info, tui_set_exec_info_content)
3929         (tui_alloc_source_buffer, tui_line_is_displayed)
3930         (tui_addr_is_displayed): Update.
3931         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
3932         (tui_check_and_display_highlight_if_needed)
3933         (tui_win_info::make_visible, tui_win_info::refresh)
3934         (tui_refresh_all): Update.
3935         * tui/tui-windata.c (tui_first_data_item_displayed)
3936         (tui_delete_data_content_windows, tui_erase_data_content)
3937         (tui_display_all_data, tui_data_window::refresh_all)
3938         (tui_check_data_values): Update.
3939         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
3940         (tui_set_win_focus_to, tui_win_info::forward_scroll)
3941         (tui_win_info::backward_scroll, tui_refresh_all_win)
3942         (tui_resize_all, tui_set_focus, tui_all_windows_info)
3943         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
3944         (tui_source_window_base::set_new_height)
3945         (tui_data_window::set_new_height)
3946         (make_invisible_and_set_new_height)
3947         (make_visible_with_new_height, new_height_ok)
3948         (parse_scrolling_args): Update.
3949         * tui/tui-stack.c (tui_show_frame_info): Update.
3950         * tui/tui-source.c (tui_set_source_content)
3951         (tui_set_source_content_nil, tui_source_is_displayed)
3952         (tui_source_window::do_scroll_vertical): Update.
3953         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3954         (tui_display_registers_from, tui_display_reg_element_at_line)
3955         (tui_check_register_values, tui_reg_command): Update.
3956         * tui/tui-layout.c (tui_default_win_height)
3957         (show_source_disasm_command, show_data, init_and_make_win)
3958         (show_source_or_disasm_and_command): Update.
3959         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3960         (tui_redisplay_readline, tui_mld_flush)
3961         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
3962         (tui_getc): Update.
3963         * tui/tui-disasm.c (tui_set_disassem_content)
3964         (tui_disasm_window::do_scroll_vertical): Update.
3965         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
3966         Now virtual.
3967         (struct tui_win_info): Derive from tui_gen_win_info.
3968         <~tui_win_info>: Mark as override.
3969         <generic>: Remove member.
3970         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
3971         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
3972         (~tui_data_window, ~tui_win_info)
3973         (tui_free_all_source_wins_content): Update.
3974         * tui/tui-command.c (tui_refresh_cmd_win): Update.
3975
3976 2019-06-25  Tom Tromey  <tom@tromey.com>
3977
3978         * tui/tui-layout.c (init_and_make_win): Use new.
3979         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
3980         destructor, initializers.
3981         (tui_alloc_generic_win_info): Don't declare.
3982         * tui/tui-data.c (_locator): Add argument to constructor.
3983         (source_win, disasm_win): New globals.
3984         (exec_info): Remove.
3985         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
3986         Update.
3987         (tui_alloc_generic_win_info): Remove.
3988         (init_content_element): Use new.
3989         (tui_win_info::tui_win_info): Update.
3990         (free_content_elements) <case DATA_WIN>: Use delete.
3991
3992 2019-06-25  Tom Tromey  <tom@tromey.com>
3993
3994         * tui/tui-wingeneral.c (tui_refresh_win): Update.
3995         * tui/tui-windata.c (tui_first_data_item_displayed)
3996         (tui_delete_data_content_windows): Update.
3997         * tui/tui-win.c (tui_data_window::set_new_height): Update.
3998         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
3999         (tui_display_registers_from, tui_check_register_values): Update.
4000         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4001         pointer.
4002         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4003         window.
4004         (tui_free_data_content): Update.
4005         (free_content_elements) <case DATA_WIN>: Free the window.
4006
4007 2019-06-25  Tom Tromey  <tom@tromey.com>
4008
4009         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4010         Update.
4011         * tui/tui-layout.c (make_command_window)
4012         (show_source_disasm_command, show_data, init_and_make_win)
4013         (show_source_or_disasm_and_command): Update.
4014         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4015         method.
4016         <can_highight, is_highlighted>: Now bool.
4017         (tui_set_win_highlight): Don't declare.
4018         * tui/tui-data.c (tui_set_win_highlight): Remove.
4019
4020 2019-06-25  Tom Tromey  <tom@tromey.com>
4021
4022         * tui/tui-wingeneral.c (make_visible): Remove check of window
4023         type.
4024
4025 2019-06-25  Tom Tromey  <tom@tromey.com>
4026
4027         * tui/tui-win.c (tui_win_info::max_height)
4028         (tui_cmd_window::max_height): New methods.
4029         (new_height_ok): Call max_height.
4030         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4031         <max_height>: New method.
4032
4033 2019-06-25  Tom Tromey  <tom@tromey.com>
4034
4035         * tui/tui-win.c (tui_source_window_base::set_new_height)
4036         (tui_data_window::set_new_height): New methods.
4037         (make_invisible_and_set_new_height): Call set_new_height method.
4038         * tui/tui-data.h (struct tui_win_info)
4039         (struct tui_source_window_base, struct tui_data_window)
4040         <set_new_height>: New method.
4041
4042 2019-06-25  Tom Tromey  <tom@tromey.com>
4043
4044         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4045         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4046         tui_refresh_data_win.
4047         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4048         method.
4049         (tui_refresh_all_win): Call the refresh_all method.
4050         (tui_set_focus): Likewise.
4051         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4052         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4053         Likewise.
4054
4055 2019-06-25  Tom Tromey  <tom@tromey.com>
4056
4057         * tui/tui-winsource.h (tui_refill_source_window)
4058         (tui_set_is_exec_point_at): Don't declare.
4059         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4060         (tui_source_window_base::refill): Rename from
4061         tui_refill_source_window.
4062         (tui_source_window_base::do_scroll_horizontal): Update.
4063         (tui_source_window_base::set_is_exec_point_at): Rename from
4064         tui_set_is_exec_point_at.
4065         (tui_update_all_breakpoint_info): Update.
4066         * tui/tui-stack.c (tui_show_frame_info): Update.
4067         * tui/tui-layout.c (show_data): Add cast.
4068         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4069         * tui/tui-data.h (struct tui_source_window_base) <refill,
4070         set_is_exec_point_at>: New methods.
4071         (tui_source_windows, tui_add_to_source_windows): Update types.
4072         (tui_add_to_source_windows): Remove redundant declaration.
4073         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4074         (tui_source_windows): Change return type.
4075         (tui_clear_source_windows_detail): Update.
4076         (tui_add_to_source_windows): Change type of parameter.
4077         (tui_free_all_source_wins_content): Update.
4078
4079 2019-06-25  Tom Tromey  <tom@tromey.com>
4080
4081         * tui/tui-wingeneral.c (tui_win_info::refresh)
4082         (tui_source_window_base::refresh): New methods.
4083         (tui_refresh_all): Call the refresh method.
4084         * tui/tui-data.h (struct tui_win_info)
4085         (struct tui_source_window_base) <refresh>: New method.
4086
4087 2019-06-25  Tom Tromey  <tom@tromey.com>
4088
4089         * tui/tui.h (tui_is_window_visible): Return bool.
4090         * tui/tui.c (tui_is_window_visible): Return bool.
4091         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4092         (tui_make_visible, tui_make_invisible)
4093         (tui_win_info::make_visible)
4094         (tui_source_window_base::make_visible, make_all_visible)
4095         (tui_make_all_visible, tui_make_all_invisible): Update.
4096         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4097         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4098         bool.
4099         (struct tui_win_info, struct tui_source_window_base)
4100         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4101         * tui/tui-data.c (tui_init_generic_part): Update.
4102
4103 2019-06-25  Tom Tromey  <tom@tromey.com>
4104
4105         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4106         (tui_source_window_base::make_visible): New methods.
4107         (make_all_visible): Make method call.
4108         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4109         (struct tui_source_window_base, struct tui_cmd_window): Override
4110         make_visible.
4111         (tui_win_is_source_type): Don't declare.
4112         * tui/tui-data.c (tui_win_is_source_type): Remove.
4113
4114 2019-06-25  Tom Tromey  <tom@tromey.com>
4115
4116         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4117         NULL check.
4118
4119 2019-06-25  Tom Tromey  <tom@tromey.com>
4120
4121         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4122         Inline constructor.  Add initializers for members.
4123         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4124         constructors; now inline in class.
4125
4126 2019-06-25  Tom Tromey  <tom@tromey.com>
4127
4128         * tui/tui-regs.c (tui_show_registers): Update.
4129         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4130         bool.
4131         * tui/tui-data.c (tui_data_window::clear_detail)
4132         (tui_data_window): Update.
4133
4134 2019-06-25  Tom Tromey  <tom@tromey.com>
4135
4136         * tui/tui-windata.c (tui_display_all_data)
4137         (tui_display_data_from_line, tui_display_data_from)
4138         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4139         Update.
4140         * tui/tui-regs.c (tui_last_regs_line_no)
4141         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4142         (tui_show_registers, tui_show_register_group)
4143         (tui_display_registers_from, tui_display_reg_element_at_line)
4144         (tui_display_registers_from_line, tui_check_register_values)
4145         (tui_reg_next, tui_reg_prev): Update.
4146         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4147         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4148         tui_data_window.
4149         (struct tui_win_info) <detail>: Remove.  Add new fields from
4150         tui_data_info.
4151         (TUI_DATA_WIN): Add cast.
4152         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4153         (~tui_data_window): Simplify.
4154
4155 2019-06-25  Tom Tromey  <tom@tromey.com>
4156
4157         * tui/tui-layout.c (show_source_disasm_command)
4158         (show_source_or_disasm_and_command): Update.
4159         * tui/tui-io.c (update_cmdwin_start_line)
4160         (tui_redisplay_readline): Update.
4161         * tui/tui-data.h (struct tui_command_info): Remove.
4162         (struct tui_win_info) <detail>: Remove command_info member.
4163         (struct tui_data_window) <start_line>: New member, from
4164         tui_command_info.
4165         (TUI_CMD_WIN): Add casts.
4166
4167 2019-06-25  Tom Tromey  <tom@tromey.com>
4168
4169         * tui/tui-winsource.c (tui_update_source_window)
4170         (tui_refill_source_window)
4171         (tui_source_window_base::do_scroll_horizontal)
4172         (tui_update_breakpoint_info, tui_set_exec_info_content)
4173         (tui_show_exec_info_content, tui_erase_exec_info_content)
4174         (tui_clear_exec_info_content): Update.
4175         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4176         Update.
4177         * tui/tui-win.c (make_invisible_and_set_new_height)
4178         (make_visible_with_new_height): Update.
4179         * tui/tui-source.c (tui_set_source_content)
4180         (tui_show_symtab_source): Update.
4181         * tui/tui-layout.c (extract_display_start_addr)
4182         (show_source_disasm_command, show_data)
4183         (make_source_or_disasm_window)
4184         (show_source_or_disasm_and_command): Update.
4185         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4186         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4187         "gdbarch".
4188         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4189         to tui_source_window_base.
4190         (struct tui_win_info) <detail>: Remove source_info member.
4191         (struct tui_source_window_base) <has_locator>: Inline.
4192         Move contents from tui_source_info; rename has_locator member to
4193         m_has_locator.
4194         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4195         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4196         header file.
4197         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4198         Simplify.
4199         (tui_free_all_source_wins_content): Cast to
4200         tui_source_window_base.
4201
4202 2019-06-25  Tom Tromey  <tom@tromey.com>
4203
4204         * tui/tui-win.c (make_invisible_and_set_new_height)
4205         (make_visible_with_new_height): Call has_locator method.
4206         * tui/tui-layout.c (show_source_disasm_command, show_data)
4207         (show_source_or_disasm_and_command): Update for bool change.
4208         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4209         (tui_win_info) <has_locator>: New method.
4210         (struct tui_source_window_base) <has_locator>: New method.
4211         (tui_win_has_locator): Don't declare.
4212         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4213         from tui_win_has_locator.
4214         (tui_source_window_base): Use false, not FALSE.
4215
4216 2019-06-25  Tom Tromey  <tom@tromey.com>
4217
4218         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4219         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4220         clear_detail method directly.
4221         (tui_clear_win_detail): Remove.
4222
4223 2019-06-25  Tom Tromey  <tom@tromey.com>
4224
4225         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4226         "this", not TUI_DISASM_WIN.
4227
4228 2019-06-25  Tom Tromey  <tom@tromey.com>
4229
4230         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4231         declare.
4232         * tui/tui-winsource.c
4233         (tui_source_window_base::do_scroll_horizontal): Rename from
4234         tui_horizontal_source_scroll.
4235         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4236         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4237         from tui_vertical_data_scroll.
4238         * tui/tui-win.h (tui_scroll): Don't declare.
4239         * tui/tui-win.c (tui_win_info::forward_scroll)
4240         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4241         (tui_win_info::right_scroll): Rename and update.
4242         (tui_scroll_forward_command, tui_scroll_backward_command)
4243         (tui_scroll_left_command, tui_scroll_right_command): Update.
4244         (tui_scroll): Remove.
4245         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4246         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4247         from tui_vertical_source_scroll.
4248         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4249         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4250         from tui_vertical_disassem_scroll.
4251         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4252         do_scroll_horizontal>: New methods.
4253         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4254         Likewise.
4255         (struct tui_source_window_base): Add do_scroll_horizontal.
4256         (struct tui_source_window, struct tui_disasm_window): Add
4257         do_scroll_vertical.
4258         (struct tui_data_window, struct tui_cmd_window): Add
4259         do_scroll_horizontal and do_scroll_vertical.
4260         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4261
4262 2019-06-25  Tom Tromey  <tom@tromey.com>
4263
4264         * tui/tui-data.h (struct tui_source_window_base): New struct.
4265         (struct tui_source_window): Derive from tui_source_window_base.
4266         (struct tui_disasm_window): New struct.
4267         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4268         from tui_source_window::clear_detail.
4269         (tui_source_window_base): Rename from tui_source_window.
4270         (~tui_source_window_base): Rename from ~tui_source_window.
4271         (tui_alloc_win_info): Create a tui_disasm_window.
4272
4273 2019-06-25  Tom Tromey  <tom@tromey.com>
4274
4275         * tui/tui-data.h (struct tui_source_window)
4276         (struct tui_data_window): Declare destructors.
4277         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4278         destructors.
4279         (tui_win_info): Simplify.
4280
4281 2019-06-25  Tom Tromey  <tom@tromey.com>
4282
4283         * tui/tui-winsource.c (tui_display_main)
4284         (tui_update_source_windows_with_addr)
4285         (tui_update_all_breakpoint_info): Update.
4286         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4287         (new_height_ok, parse_scrolling_args): Update.
4288         * tui/tui-stack.c (tui_show_frame_info): Update.
4289         * tui/tui-data.h (struct tui_list): Remove.
4290         (tui_source_windows): Return a reference to a std::vector.
4291         * tui/tui-data.c (source_windows): Now a std::vector.
4292         (tui_source_windows): Change return type.
4293         (tui_clear_source_windows): Rewrite.
4294         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4295         (tui_free_all_source_wins_content): Rewrite.
4296
4297 2019-06-25  Tom Tromey  <tom@tromey.com>
4298
4299         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4300         (struct tui_data_window, struct tui_cmd_window): Declare
4301         clear_detail method.
4302         * tui/tui-data.c (tui_source_window::clear_detail)
4303         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4304         methods.
4305         (tui_clear_win_detail): Simplify.
4306
4307 2019-06-25  Tom Tromey  <tom@tromey.com>
4308
4309         * tui/tui-layout.c (make_source_window, make_disasm_window)
4310         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4311         Return the new window.
4312         (show_source_disasm_command, show_data)
4313         (show_source_or_disasm_and_command): Update.
4314
4315 2019-06-25  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4318         parameter.  Return the new window.
4319         (show_source_disasm_command): Update and remove NULL check.
4320         (show_source_or_disasm_and_command): Update.
4321
4322 2019-06-25  Tom Tromey  <tom@tromey.com>
4323
4324         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4325
4326 2019-06-25  Tom Tromey  <tom@tromey.com>
4327
4328         * tui/tui-data.h (struct tui_win_info): Make constructor
4329         protected.  Make destructor virtual.  Add initializers.
4330         (tui_source_window, tui_data_window, tui_cmd_window): New
4331         classes.
4332         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4333         constructor.  Add "type" parameter.
4334         (tui_source_window, tui_data_window, tui_cmd_window): New
4335         constructors.
4336         (tui_alloc_win_info): Instantiate the appropriate subclass.
4337
4338 2019-06-25  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-win.c (tui_resize_all): Use delete.
4341         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4342         destructor.
4343         (tui_free_window): Don't declare.
4344         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4345         Update.
4346
4347 2019-06-25  Tom Tromey  <tom@tromey.com>
4348
4349         * tui/tui-data.h (struct tui_win_info): Add constructor.
4350         * tui/tui-data.c (tui_alloc_win_info): Use new.
4351         (tui_free_window): Use delete.
4352
4353 2019-06-22  Tom Tromey  <tom@tromey.com>
4354
4355         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4356         declare.
4357         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4358
4359 2019-06-22  Tom Tromey  <tom@tromey.com>
4360
4361         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4362         declare.
4363         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4364
4365 2019-06-22  Tom de Vries  <tdevries@suse.de>
4366
4367         * dwarf2read.c (create_addrmap_from_aranges)
4368         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4369         instead of '%zu'.
4370
4371 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4372
4373         * dwarf2read.h (dwarf2_section_info_def): Remove.
4374         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4375         * dwarf2read.c (struct dwo_sections) <types>: Change type to
4376         std::vector<dwarf2_section_info>.
4377         (struct dwo_file) <~dwo_file>: Remove.
4378         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
4379         types field.
4380         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
4381         (dwarf2_read_debug_names): Likewise.
4382         (create_debug_types_hash_table): Change parameter type to
4383         array_view, adjust code accordingly.
4384         (dwarf2_locate_dwo_sections): Adjust to std::vector.
4385         (partial_die_info::fixup): Likewise.
4386         (determine_prefix): Likewise.
4387         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
4388
4389 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4390
4391         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
4392         gdb_bfd_ref_ptr.
4393         <~dwo_file>: Remove call to gdb_bfd_unref.
4394         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
4395         gdb_bfd_ref_ptr::get.
4396
4397 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4398
4399         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
4400         type to htab_up.
4401         * dwarf2read.c (struct dwo_file): Initialize fields.
4402         <~dwo_file>: New.
4403         (free_dwo_file): Remove, move content to ~dwo_file.
4404         (struct dwo_file_deleter): Remove.
4405         (dwo_file_up>: Remove custom deleter.
4406         (free_dwo_files): Remove.
4407         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
4408         dwo_files.
4409         (process_skeletonless_type_units): Call unique_ptr::get.
4410         (allocate_dwo_file_hash_table): Add deleter to created hash
4411         table.  Change return type to htab_up.
4412         (lookup_dwo_file_slot): Don't memset dwo_file, call
4413         unique_ptr::get.
4414         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
4415         (create_dwo_unit_in_dwp_v2): Likewise.
4416         (open_and_init_dwo_file): Likewise.
4417         (free_dwo_file_from_slot): Remove.
4418
4419 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
4420
4421         * dwarf2read.h (struct dwarf2_section_info) <readin,
4422         is_virtual>: Change type to bool.
4423         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
4424         true instead of 1.
4425
4426 2019-06-19  Tom Tromey  <tom@tromey.com>
4427
4428         * tui/tui-data.h (tui_init_content_element): Don't declare.
4429
4430 2019-06-19  Tom Tromey  <tom@tromey.com>
4431
4432         * tui/tui-data.h (tui_init_win_info): Don't declare.
4433
4434 2019-06-19  Tom de Vries  <tdevries@suse.de>
4435
4436         * dwarf2read.h (abstract_to_concrete): Change type to
4437         std::unordered_map<sect_offset, std::vector<sect_offset>,
4438         gdb::hash_enum<sect_offset>>.
4439
4440 2019-06-19  Tom Tromey  <tromey@adacore.com>
4441
4442         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
4443         EVAL_AVOID_SIDE_EFFECTS specially.
4444
4445 2019-06-19  Tom Tromey  <tromey@adacore.com>
4446
4447         * source-cache.c (highlighter): New global.
4448         (source_cache::get_source_lines): Create a highlighter on demand.
4449
4450 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
4451
4452         * defs.h (deprecated_interactive_hook): Delete declaration.
4453         * interps.c (clear_interpreter_hooks): Remove use of
4454         deprecated_interactive_hook.
4455         * top.c (deprecated_interactive_hook): Delete definition.
4456         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
4457
4458 2019-06-18  Tom de Vries  <tdevries@suse.de>
4459
4460         PR gdb/24515
4461         * dwarf2read.h (abstract_to_concrete): Change type from
4462         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
4463         std::unordered_map<sect_offset, std::vector<sect_offset>>.
4464         * dwarf2read.c (read_variable): Update.
4465         (dwarf2_fetch_die_loc_sect_off): Update.
4466
4467 2019-06-17  Tom de Vries  <tdevries@suse.de>
4468
4469         PR gdb/24617
4470         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
4471         accessing parent[parent_len - 1].
4472
4473 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
4474
4475         PR gdb/24364
4476         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
4477         call dtrace_process_dof with NULL dof.
4478
4479 2019-06-16  Tom de Vries  <tdevries@suse.de>
4480
4481         PR gdb/24445
4482         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
4483
4484 2019-06-16  Tom Tromey  <tom@tromey.com>
4485
4486         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4487         (make_all_visible): Use address of member.
4488
4489 2019-06-16  Tom Tromey  <tom@tromey.com>
4490
4491         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
4492         (tui_free_window, free_content, free_content_elements): Remove
4493         unnecessary cast.
4494         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
4495         cast.
4496         * tui/tui-regs.c (tui_show_register_group)
4497         (tui_display_registers_from, tui_display_reg_element_at_line):
4498         Remove unnecessary cast.
4499
4500 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
4501
4502         * linux-nat.c (normal_mask): Delete.
4503         (_initialize_linux_nat): Don't initialise normal_mask.
4504
4505 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
4506
4507         PR gdb/24445
4508         * dwarf-index-write.h (write_psymtabs_to_index): Add
4509         dwz_basename parameter.
4510         * dwarf-index-write.c (write_gdbindex): Move file writing to
4511         write_gdbindex_1.  Change return type void.
4512         (assert_file_size): Move up, remove filename parameter.
4513         (write_gdbindex_1): New function.
4514         (write_debug_names): Change return type to void, call
4515         assert_file_size.
4516         (struct index_wip_file): New struct.
4517         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
4518         file logic to index_wip_file.  Write index for dwz file if
4519         needed.
4520         (save_gdb_index_command): Pass basename of dwz file, if present.
4521         * dwarf-index-cache.c (index_cache::store): Obtain and pass
4522         build-id of dwz file, if present.
4523         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
4524         (dwarf2_get_dwz_file): Likewise.
4525         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
4526         (dwarf2_get_dwz_file): Likewise.
4527
4528 2019-06-16  Tom Tromey  <tom@tromey.com>
4529
4530         * coffread.c (process_coff_symbol): Use xstrdup.
4531         * value.c (create_internalvar): Use xstrdup.
4532
4533 2019-06-16  Tom Tromey  <tom@tromey.com>
4534
4535         * valops.c (value_cast, value_slice): Remove unnecessary cast.
4536         * breakpoint.c (stopin_command, stopat_command)
4537         (until_break_command, decode_location_default): Remove unnecessary
4538         cast.
4539         * utils.c (subset_compare): Remove unnecessary cast.
4540         * ada-lang.c (ada_update_initial_language): Remove unnecessary
4541         cast.
4542         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
4543         cast.
4544         * infcmd.c (path_command): Remove unnecessary cast.
4545         * coffread.c (decode_type): Remove unnecessary cast.
4546         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
4547         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
4548         * tui/tui-stack.c (tui_show_locator_content)
4549         (tui_show_frame_info): Remove unnecessary cast.
4550         * tui/tui-win.c (tui_scroll_forward_command)
4551         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
4552         (parse_scrolling_args): Remove unnecessary cast.
4553         * tui/tui-data.c (init_win_info, tui_del_window)
4554         (tui_free_window, tui_del_data_windows, tui_free_data_content)
4555         (free_content_elements): Remove unnecessary cast.
4556         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
4557         unnecessary cast.
4558         * tui/tui-source.c (tui_set_source_content)
4559         (tui_vertical_source_scroll): Remove unnecessary cast.
4560         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
4561         cast.
4562         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
4563         * tui/tui-regs.c (tui_display_registers_from)
4564         (tui_display_register): Remove unnecessary cast.
4565         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
4566         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
4567         (make_visible): Remove unnecessary cast.
4568         * tui/tui-winsource.c (tui_erase_source_content)
4569         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
4570         unnecessary cast.
4571         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
4572         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
4573         * stabsread.c (read_type, read_array_type, read_range_type):
4574         Remove unnecessary cast.
4575         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
4576         (parse_symbol, parse_type, upgrade_type, parse_external)
4577         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
4578         unnecessary cast.
4579         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
4580
4581 2019-06-16  Tom Tromey  <tom@tromey.com>
4582
4583         * tui/tui-data.c (tui_alloc_generic_win_info)
4584         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
4585         checks.
4586
4587 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
4588             Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * f-typeprint.c (f_print_type): Don't return early for not
4591         associated or not allocated types.
4592         (f_type_print_varspec_suffix): Add print_rank parameter and print
4593         ranks of array types in case they dangling.
4594         (f_type_print_base): Add print_rank parameter.
4595
4596 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4597
4598         * NEWS: Mention new MI commands.
4599         * break-catch-throw.c (enum exception_event_kind): Move to
4600         breakpoint.h.
4601         (print_mention_exception_catchpoint): Output text as a single
4602         message.
4603         (catch_exception_command_1): Rename to...
4604         (catch_exception_event): ...this, make non-static, update header
4605         command, and change some parameter types.
4606         (catch_catch_command): Update for changes to
4607         catch_exception_command_1.
4608         (catch_throw_command): Likewise.
4609         (catch_rethrow_command): Likewise.
4610         * breakpoint.c (enum exception_event_kind): Delete.
4611         * breakpoint.h (enum exception_event_kind): Moved here from
4612         break-catch-throw.c.
4613         (catch_exception_event): Declare.
4614         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
4615         (mi_cmd_catch_throw): New function.
4616         (mi_cmd_catch_rethrow): New function.
4617         (mi_cmd_catch_catch): New function.
4618         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
4619         'catch-catch' entries.
4620         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
4621         (mi_cmd_catch_rethrow): Declare.
4622         (mi_cmd_catch_catch): Declare.
4623
4624 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4625
4626         * annotate.c (annotate_source_line): Change return type to void,
4627         update implementation to match.
4628         * annotate.h (annotate_source_line): Change return type to void,
4629         update header comment.
4630         * stack.c (print_frame_info): Don't change what frame information
4631         is printed based on whether annotations are on or not.
4632
4633 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4634
4635         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
4636         (annotate_source): Make static.
4637         (annotate_source_line): Moved from source.c and renamed from
4638         identify_source_line.  Update the return type.
4639         * annotate.h (annotate_source): Delete declaration.
4640         (annotate_source_line): Declaration moved from source.h, and
4641         renamed from identify_source_line.  Return type updated.
4642         * source.c (identify_source_line): Moved to annotate.c and renamed
4643         to annotate_source_line.
4644         (info_line_command): Remove check of annotation_level.
4645         * source.h (identify_source_line): Move declaration to annotate.h
4646         and rename to annotate_source_line.
4647         * stack.c: Add 'annotate.h' include.
4648         (print_frame_info): Remove check of annotation_level before
4649         calling annotate_source_line.
4650
4651 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4652
4653         * source-cache.c (source_cache::get_plain_source_lines): Use
4654         open_source_file_with_line_charpos instead of just
4655         open_source_file, remove call to find_source_lines.
4656         (source_cache::get_source_lines): Likewise.
4657         * source.c (find_source_lines): Make static.
4658         (get_filename_and_charpos): Renamed into...
4659         (open_source_file_with_line_charpos): ..this along with changes to
4660         return a scoped_fd, and some other minor clean ups.
4661         (identify_source_line): Use open_source_file_with_line_charpos.
4662         (search_command_helper): Use open_source_file_with_line_charpos
4663         instead of just open_source_file, remove call to
4664         find_source_lines.
4665         * source.h (open_source_file_with_line_charpos): Declare new
4666         function.
4667         (find_source_lines): Delete declaration.
4668
4669 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4670
4671         * source.c (get_filename_and_charpos): Remove fullname
4672         parameter.
4673         (identify_source_line): Update call to get_filename_and_charpos.
4674
4675 2019-06-14  Tom Tromey  <tromey@adacore.com>
4676
4677         PR gdb/24502:
4678         * ui-style.h (skip_ansi_escape): Update comment.
4679         * ui-file.h (class no_terminal_escape_file): New class.
4680         * ui-file.c (no_terminal_escape_file::write)
4681         (no_terminal_escape_file::puts): New methods.
4682         * cli/cli-logging.c (handle_redirections): Use
4683         no_terminal_escape_file.
4684
4685 2019-06-14  Tom Tromey  <tromey@adacore.com>
4686
4687         * NEWS: Move convenience variable news above Python news.
4688
4689 2019-06-14  Tom Tromey  <tom@tromey.com>
4690
4691         * gnulib: Move directory to top-level.
4692         * configure.ac: Don't configure gnulib.
4693         * configure: Rebuild.
4694         * common/common-defs.h: Use new path to gnulib.
4695         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
4696         (GNULIB_H): Remove.
4697         (INCGNU): Look in new gnulib location.
4698         (HFILES_NO_SRCDIR): Remove gnulib files.
4699         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
4700         (generated_files): Remove GNULIB_H.
4701         ($(LIBGNU), all-lib): Remove targets.
4702         (distclean): Don't mention GNULIB_BUILDDIR.
4703         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
4704
4705 2019-06-14  Tom Tromey  <tromey@adacore.com>
4706
4707         * symfile.c (add_symbol_file_command): Remove obsolete comment.
4708         Warn if symbol file does not provide any symbols.
4709
4710 2019-06-14  Tom Tromey  <tromey@adacore.com>
4711
4712         * source.c (find_and_open_source): Respect basenames_may_differ.
4713
4714 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
4715
4716         * annotate.c (annotate_breakpoints_invalid): Make use of
4717         scoped_restore_terminal_state.
4718         (annotate_frames_invalid): Likewise.
4719
4720 2019-06-14  Tom Tromey  <tromey@adacore.com>
4721
4722         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
4723         allow assignment to an internalvar.
4724
4725 2019-06-14  Tom Tromey  <tromey@adacore.com>
4726
4727         * ada-lex.l: Allow "_" in attribute names.
4728
4729 2019-06-14  Tom Tromey  <tromey@adacore.com>
4730
4731         PR gdb/24653:
4732         * regcache.c (registers_changed): Don't call alloca.
4733         * top.c (execute_command): Don't call alloca.
4734
4735 2019-06-13  Pedro Alves  <palves@redhat.com>
4736
4737         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
4738         'expression'.  When parsing an expression, error out if there's
4739         junk after "unlimited".
4740         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4741         (do_set_command): Adjust calls to is_unlimited_literal.
4742
4743 2019-06-13  Pedro Alves  <palves@redhat.com>
4744
4745         * compile/compile.c (make_compile_options_def_group): Add braces
4746         around array_view initializer.
4747         * thread.c (make_thread_apply_all_options_def_group)
4748         (make_thread_apply_all_options_def_group): Likewise.
4749
4750 2019-06-13  Pedro Alves  <palves@redhat.com>
4751
4752         * NEWS (New commands): Mention "maint test-options
4753         require-delimiter", "maint test-options unknown-is-error", "maint
4754         test-options unknown-is-operand" and "maint show
4755         test-options-completion-result".
4756         (New command options, command completion): New section.
4757         (Completion improvements): New section.
4758         Mention that you can abbreviate "unlimited".
4759
4760 2019-06-13  Pedro Alves  <palves@redhat.com>
4761
4762         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
4763         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
4764         * unittests/cli-utils-selftests.c (test_parse_flags)
4765         (test_parse_flags_qcs): Delete.
4766         (test_cli_utils): Don't call deleted functions.
4767
4768 2019-06-13  Pedro Alves  <palves@redhat.com>
4769
4770         * thread.c: Include "cli/cli-option.h".
4771         (tp_array_compar_ascending): Global.
4772         (tp_array_compar): Delete function.
4773         (tp_array_compar_ascending, tp_array_compar_descending): New
4774         functions.
4775         (ascending_option_def, qcs_flag_option_def)
4776         (thr_qcs_flags_option_defs)
4777         (make_thread_apply_all_options_def_group)
4778         (make_thread_apply_options_def_group): New.
4779         (thread_apply_all_command): Use gdb::option::process_options.
4780         (thread_apply_command_completer)
4781         (thread_apply_all_command_completer): New.
4782         (thread_apply_command): Use gdb::option::process_options.
4783         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
4784         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
4785         to generate help text of "thread apply".  Adjust "taas"'s help.
4786         * tid-parse.c (tid_range_parser::in_thread_range): New method.
4787         * tid-parse.h (tid_range_parser::in_thread_range): New method.
4788
4789 2019-06-13  Pedro Alves  <palves@redhat.com>
4790
4791         * thread.c (thread_apply_command): Check for invalid TID with
4792         isdigit instead of !isalpha.
4793
4794 2019-06-13  Pedro Alves  <palves@redhat.com>
4795
4796         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
4797         (validate_flags_qcs): New.
4798         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
4799         (validate_flags_qcs): Declare.
4800         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
4801         (make_frame_apply_options_def_group): New.
4802         (frame_apply_command_count): Process options with
4803         gdb::option::process_options.
4804         (frame_apply_completer): New.
4805         (frame_apply_level_completer, frame_apply_all_completer)
4806         (frame_apply_completer): New.
4807         (_initialize_stack): Update help of "frame apply", "frame apply
4808         level", "frame apply all" and "faas" to mention supported options
4809         and install command completers.
4810         * stack.h (frame_apply_all_completer): Declare.
4811         * thread.c: Include "stack.h".
4812         (tfaas_command): Add "--".
4813         (_initialize_thread): Update help "tfaas" to mention supported
4814         options and install command completer.
4815
4816 2019-06-13  Pedro Alves  <palves@redhat.com>
4817
4818         * completer.c (complete_nested_command_line): New.
4819         (gdb_completion_word_break_characters_throw): Add assertion.
4820         * completer.h (complete_nested_command_line): Declare.
4821
4822 2019-06-13  Pedro Alves  <palves@redhat.com>
4823
4824         * stack.c (parse_backtrace_qualifiers): New.
4825         (backtrace_command): Use it.
4826         (backtrace_command_completer): Complete on qualifiers.
4827
4828 2019-06-13  Pedro Alves  <palves@redhat.com>
4829
4830         * frame.c: Include "cli/cli-option.h.
4831         (user_set_backtrace_options): New.
4832         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
4833         Delete.
4834         (get_prev_frame): Adjust.
4835         (boolean_option_def, uinteger_option_def)
4836         (set_backtrace_option_defs): New.
4837         (_initialize_frame): Adjust and use
4838         gdb::option::add_setshow_cmds_for_options to install "set
4839         backtrace past-main" and "set backtrace past-entry".
4840         * frame.h: Include "cli/cli-option.h".
4841         (struct frame_print_options): Forward declare.
4842         (print_frame_arguments_all, print_frame_arguments_scalars)
4843         (print_frame_arguments_none): Declare.
4844         (print_entry_values): Delete declaration.
4845         (struct frame_print_options, user_frame_print_options): New.
4846         (struct set_backtrace_options): New.
4847         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
4848         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
4849         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
4850         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
4851         (list_args_or_locals): Add frame_print_options parameter.
4852         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4853         * python/py-framefilter.c (enumerate_args): Pass down
4854         USER_FRAME_PRINT_OPTIONS.
4855         * stack.c: Include "cli/cli-option.h".
4856         (print_frame_arguments_all, print_frame_arguments_scalars)
4857         (print_frame_arguments_none): Declare.
4858         (print_raw_frame_arguments, print_entry_values): Delete.
4859         (user_frame_print_options): New.
4860         (boolean_option_def, enum_option_def, frame_print_option_defs):
4861         New.
4862         (struct backtrace_cmd_options): New.
4863         (bt_flag_option_def): New.
4864         (backtrace_command_option_defs): New.
4865         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
4866         (print_frame_arg, read_frame_arg, print_frame_args)
4867         (print_frame_info, print_frame): Add frame_print_options parameter
4868         and use it.
4869         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
4870         (backtrace_command_1): Add frame_print_options and
4871         backtrace_cmd_options parameters and use them.
4872         (make_backtrace_options_def_group): New.
4873         (backtrace_command): Process command options with
4874         gdb::option::process_options.
4875         (backtrace_command_completer): New.
4876         (_initialize_stack): Extend "backtrace"'s help to mention
4877         supported options.  Install completer for "backtrace".
4878         Install some settings commands with add_setshow_cmds_for_options.
4879
4880 2019-06-13  Pedro Alves  <palves@redhat.com>
4881
4882         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
4883         and that "set/show print raw frame-arguments" are now deprecated.
4884
4885         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
4886         command.
4887         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
4888         * stack.c (_initialize_stack): Install "set/show print
4889         raw-frame-arguments", and deprecate "set/show print raw
4890         frame-arguments".
4891         * valprint.c (_initialize_valprint): Deprecate "set/show print
4892         raw".
4893
4894 2019-06-13  Pedro Alves  <palves@redhat.com>
4895
4896         * compile/compile.c (struct compile_options): New.
4897         (compile_flag_option_def, compile_command_option_defs)
4898         (make_compile_options_def_group): New.
4899         (compile_file_command): Handle options with
4900         gdb::option::process_options.
4901         (compile_file_command_completer): New function.
4902         (compile_code_command): Handle options with
4903         gdb::option::process_options.
4904         (compile_code_command_completer): New function.
4905         (_initialize_compiler): Install completers for "compile code" and
4906         "compile file".  Mention available options in "compile code" and
4907         "compile code"'s help.
4908         * completer.c (advance_to_completion_word): New, factored out from
4909         ...
4910         (advance_to_expression_complete_word_point): ... this.
4911         (advance_to_filename_complete_word_point): New.
4912         * completer.h (advance_to_filename_complete_word_point): New
4913         declaration.
4914
4915 2019-06-13  Pedro Alves  <palves@redhat.com>
4916
4917         * compile/compile.c: Include "cli/cli-option.h".
4918         (compile_print_value): Scope data pointer is now a
4919         value_print_options pointer; adjust.
4920         (compile_print_command): Process options.  Scope data pointer is
4921         now a value_print_options pointer; adjust.
4922         (_initialize_compile): Update "compile print"'s help to include
4923         supported options.  Install a completer for "compile print".
4924         * cp-valprint.c (show_vtblprint, show_objectprint)
4925         (show_static_field_print): Delete.
4926         (_initialize_cp_valprint): Don't install "set print
4927         static-members", "set print vtbl", "set print object" here.
4928         * printcmd.c: Include "cli/cli-option.h" and
4929         "common/gdb_optional.h".
4930         (print_command_parse_format): Rework to fill in a
4931         value_print_options instead of a format_data.
4932         (print_value): Change parameter type from format_data pointer to
4933         value_print_options reference.  Adjust.
4934         (print_command_1): Process options.  Adjust to pass down a
4935         value_print_options.
4936         (print_command_completer): New.
4937         (_initialize_printcmd): Install print_command_completer as
4938         handle_brkchars completer for the "print" command.  Update
4939         "print"'s help to include supported options.
4940         * valprint.c: Include "cli/cli-option.h".
4941         (show_vtblprint, show_objectprint, show_static_field_print): Moved
4942         here from cp-valprint.c.
4943         (boolean_option_def, uinteger_option_def)
4944         (value_print_option_defs, make_value_print_options_def_group):
4945         New.  Use gdb::option::add_setshow_cmds_for_options to install
4946         "set print elements", "set print null-stop", "set print repeats",
4947         "set print pretty", "set print union", "set print array", "set
4948         print address", "set print symbol", "set print array-indexes".
4949         * valprint.h: Include <string> and "cli/cli-option.h".
4950         (make_value_print_options_def_group): Declare.
4951         (print_value): Change parameter type from format_data pointer to
4952         value_print_options reference.
4953         (print_command_completer): Declare.
4954
4955 2019-06-13  Pedro Alves  <palves@redhat.com>
4956
4957         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
4958         (COMMON_SFILES): Add maint-test-settings.c.
4959         * cli/cli-decode.c (boolean_enums): New global, factored out from
4960         ...
4961         (add_setshow_boolean_cmd): ... here.
4962         * cli/cli-decode.h (boolean_enums): Declare.
4963         * cli/cli-option.c: New file.
4964         * cli/cli-option.h: New file.
4965         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
4966         factored out from ...
4967         (parse_cli_boolean_value(const char *)): ... this.
4968         (is_unlimited_literal): Change parameter type to pointer to
4969         pointer.  Adjust and advance ARG pointer.
4970         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4971         (parse_cli_var_enum): New, factored out from ...
4972         (do_set_command): ... this.  Adjust.
4973         * cli/cli-setshow.h (parse_cli_boolean_value)
4974         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
4975         (parse_cli_var_enum): Declare.
4976         * cli/cli-utils.c: Include "cli/cli-option.h".
4977         (get_ulongest): New.
4978         * cli/cli-utils.h (get_ulongest): Declare.
4979         (check_for_argument): New overloads.
4980         * maint-test-options.c: New file.
4981
4982 2019-06-13  Pedro Alves  <palves@redhat.com>
4983
4984         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
4985         parse a range if "-" is at the end of the string.
4986
4987 2019-06-13  Pedro Alves  <palves@redhat.com>
4988
4989         * cli/cli-setshow.c (parse_auto_binary_operation)
4990         (parse_cli_boolean_value): Don't allow "o".
4991
4992 2019-06-13  Pedro Alves  <palves@redhat.com>
4993
4994         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
4995         * NEWS: Mention maint test-settings KIND.
4996         * maint-test-settings.c: New file.
4997
4998 2019-06-13  Pedro Alves  <palves@redhat.com>
4999
5000         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5001         completer.
5002         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5003         "set" completers.
5004
5005 2019-06-13  Pedro Alves  <palves@redhat.com>
5006
5007         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5008         after item.
5009
5010 2019-06-13  Pedro Alves  <palves@redhat.com>
5011
5012         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5013
5014 2019-06-13  Pedro Alves <palves@redhat.com>
5015
5016         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5017         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5018         call.
5019         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5020         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5021         calls.
5022         (check_for_argument): Skip spaces after argument.
5023
5024 2019-06-13  Pedro Alves  <palves@redhat.com>
5025
5026         * thread.c (thread_apply_command): Adjust TID parsing.
5027         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5028         detected before end of string.
5029         (tid_is_in_list): Error out if LIST is invalid.
5030
5031 2019-06-13  Pedro Alves  <palves@redhat.com>
5032
5033         * completer.c (complete_line_internal_1): Rewind completion word
5034         point.
5035         (completion_tracker::advance_custom_word_point_by): Change
5036         parameter type to int.
5037         * completer.h (completion_tracker::advance_custom_word_point_by):
5038         Likewise.
5039
5040 2019-06-13  Pedro Alves  <palves@redhat.com>
5041
5042         * completer.c (advance_to_completion_word): Handle delimiters.
5043
5044 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5045
5046         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5047
5048 2019-06-11  Tom Tromey  <tom@tromey.com>
5049
5050         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5051         (xmalloc_failed): Move to alloc.c.
5052         * alloc.c: New file.
5053         * Makefile.in (COMMON_SFILES): Add alloc.c.
5054
5055 2019-06-11  Tom Tromey  <tom@tromey.com>
5056
5057         * nat/linux-waitpid.c: Don't include server.h.
5058         (linux_debug): Remove.
5059         (my_waitpid): Update.
5060
5061 2019-06-11  Tom Tromey  <tromey@adacore.com>
5062
5063         * infcall.c (_initialize_infcall): Remove trailing newline from
5064         help.
5065         * user-regs.c (_initialize_user_regs): Remove trailing newline
5066         from help.
5067         * typeprint.c (_initialize_typeprint): Remove trailing newline
5068         from help.
5069         * reverse.c (_initialize_reverse): Remove trailing newlines from
5070         help.
5071         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5072         from help.
5073         * language.c (add_set_language_command): Remove trailing newline
5074         from help.
5075         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5076         help.
5077         * disasm.c (_initialize_disasm): Remove trailing newline from
5078         help.
5079         * top.c (init_main): Remove trailing newline from help.
5080         * interps.c (_initialize_interpreter): Remove trailing newline
5081         from help.
5082         * btrace.c (_initialize_btrace): Remove trailing newlines from
5083         help.
5084         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5085         from help.
5086         * python/python.c (_initialize_python): Remove trailing newline
5087         from help.
5088         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5089         help.
5090         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5091         from help.  Reformat some text.
5092         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5093         from help.
5094         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5095         newline from help.
5096
5097 2019-06-11  Tom Tromey  <tromey@adacore.com>
5098
5099         * darwin-nat.c (darwin_decode_exception_message)
5100         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5101
5102 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5103
5104         * valops.c (value_slice): Check for not allocated or not
5105         associated values.
5106
5107 2019-06-10  Tom de Vries  <tdevries@suse.de>
5108
5109         PR gdb/24618
5110         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5111         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5112         invalid.
5113
5114 2019-06-10  Tom de Vries  <tdevries@suse.de>
5115
5116         PR gdb/24611
5117         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5118         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5119
5120 2019-06-10  Tom de Vries  <tdevries@suse.de>
5121
5122         PR symtab/24545
5123         * symtab.c (struct demangled_name_entry): Add language field.
5124         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5125         static minimal symbol".  Set and use language field.
5126
5127 2019-06-10  Tom Tromey  <tromey@adacore.com>
5128
5129         * ada-lang.c (_initialize_ada_language): Update help text.
5130
5131 2019-06-10  Tom Tromey  <tromey@adacore.com>
5132
5133         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5134         with a newline.
5135         * guile/guile.c (handle_boot_error): Don't end warning with a
5136         newline.
5137         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5138         warning with a newline.
5139         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5140         newline.
5141         (s12z_frame_cache): Likewise.
5142         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5143         a newline.
5144         * solib-svr4.c (disable_probes_interface): Don't end warning with
5145         a newline.
5146         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5147         newline.
5148         * python/python.c (do_finish_initialization): Don't end warning
5149         with a newline.
5150
5151 2019-06-10  Tom Tromey  <tom@tromey.com>
5152
5153         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5154         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5155         gdbpy_enter.
5156
5157 2019-06-10  Tom Tromey  <tromey@adacore.com>
5158
5159         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5160         data.
5161         (elf_new_init): Don't call stabsread_new_init.
5162         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5163         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5164         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5165
5166 2019-06-10  Tom de Vries  <tdevries@suse.de>
5167
5168         PR symtab/16264
5169         PR symtab/24517
5170         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5171
5172 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5173
5174         * source.c (find_and_open_source): Also rewrite relative file
5175         names.
5176
5177 2019-04-26  Amos Bird  <amosbird@gmail.com>
5178
5179         * annotate.c (annotate_thread_exited): Add "thread-exited"
5180         annotation.
5181
5182 2019-06-06  Tom Tromey  <tromey@adacore.com>
5183
5184         * maint.h (class scoped_command_stats): Use
5185         DISABLE_COPY_AND_ASSIGN.
5186         <print_time>: New method.
5187         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5188         print_time.
5189         (scoped_command_stats::print_time): New method.
5190
5191 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5192
5193         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5194         instructions of lengths 6 or 8 bytes.
5195
5196 2019-06-04  Pedro Alves  <palves@redhat.com>
5197
5198         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5199
5200         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5201         * breakpoint.c (condition_completer): Likewise.
5202         * cli/cli-dump.c (scan_expression): Likewise.
5203         * common/filestuff.c (mkdir_recursive): Likewise.
5204         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5205         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5206         (gdb_abspath): Likewise.
5207         * compile/compile-cplus-types.c
5208         (compile_cplus_instance::decl_name): Likewise.
5209         * completer.c (complete_explicit_location):
5210         (signal_completer, reg_or_group_completer_1): Likewise.
5211         * cp-support.c (cp_remove_params_if_any): Likewise.
5212         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5213         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5214         * infcmd.c (strip_bg_char): Likewise.
5215         * linespec.c (copy_token_string): Likewise.
5216         * mi/mi-main.c (output_cores): Likewise.
5217         * psymtab.c (psymtab_search_name):
5218         * symfile.c (test_set_ext_lang_command): Likewise.
5219         * target.c (target_fileio_read_stralloc): Likewise.
5220         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5221         * value.c (complete_internalvar): Likewise.
5222
5223 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5224
5225         Add objfile property to gdb.Type.
5226         * NEWS: Mention Python API addition.
5227         * python/py-type.c (typy_get_objfile): New method.
5228
5229 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5230
5231         * NEWS: Mention the new set|show style [title|highlight].
5232         Mention changes to "show style", "help" and "apropos".
5233
5234 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5235
5236         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5237         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5238         instead of print_help_for_command.
5239         (print_doc_of_command): New function.
5240         (help_list): Add 'apropos -v word' suggestion.
5241         (print_help_for_command): Style the command name using title style.
5242         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5243         (_initialize_cli_cmds): Describe -v in apropos_command help.
5244
5245 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5246
5247         * cli/cli-style.h (cli_style_option): Add name in constructor,
5248         add m_name class member, add constructor with intensity,
5249         add name class function.
5250         (cli_style_option::add_setshow_commands): Remove name argument.
5251         (highlight_style, title_style): New styles.
5252         * cli/cli-style.c (do_show): New function that shows a style
5253         characteristic styling the style name with itself.
5254         (set_style_name): New function.
5255         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5256         Update all callers according to the changes in cli/cli-style.h.
5257         * utils.h (fputs_highlighted): New function.
5258         * utils.c (fputs_highlighted): Likewise.
5259
5260 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5261
5262         * NEWS: Mention new pipe command and new convenience variables.
5263
5264 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5265
5266         * cli/cli-cmds.c (pipe_command): New function.
5267         (_initialize_cli_cmds): Call add_com for pipe_command.
5268         Define | as an alias for pipe.
5269         (exit_status_set_internal_vars): New function.
5270         (shell_escape): Call exit_status_set_internal_vars.
5271         cli/cli-decode.c (find_command_name_length): Recognize | as
5272         a single character command.
5273
5274 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5275
5276         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5277         top.c (execute_command_to_ui_file): New function, mostly a copy
5278         of execute_command_to_string.
5279         (execute_command_to_string): Implement by calling
5280         execute_command_to_ui_file.
5281
5282 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5283
5284         * top.h (saved_command_line): Remove declaration.
5285         * top.c (previous_saved_command_line, previous_repeat_arguments):
5286         New variables.
5287         (saved_command_line): Make static, define together with other
5288         'repeat variables'.
5289         (dont_repeat): Clear repeat_arguments.
5290         (repeat_previous, get_saved_command_line, save_command_line):
5291         New functions.
5292         (gdb_init): Initialize saved_command_line
5293         and previous_saved_command_line.
5294         * main.c (captured_main_1): Remove saved_command_line initialization.
5295         * event-top.c (handle_line_of_input): Update to use
5296         the new 'repeat' related functions instead of direct access to
5297         saved_command_line.
5298         * command.h (repeat_previous, get_saved_command_line,
5299         save_command_line): New declarations.
5300         (dont_repeat): Add comment.
5301
5302 2019-05-30  Tom Tromey  <tromey@adacore.com>
5303
5304         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5305         Fix comment.
5306         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5307
5308 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5309
5310         PR cli/24587
5311         * completer.c (complete): Initialize variable word.
5312
5313 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5314
5315         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5316         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5317         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5318         'body' is NULL to the outter 'if', protecting the '!is_define'
5319         situation as well.
5320
5321 2019-05-29  Tom Tromey  <tromey@adacore.com>
5322
5323         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5324         (dwarf_unknown): New function.
5325         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5326         (dwarf_type_encoding_name): Use dwarf_unknown.
5327
5328 2019-05-29  Tom Tromey  <tromey@adacore.com>
5329
5330         PR c++/20020:
5331         * cp-valprint.c (cp_print_value_fields): Call
5332         cp_print_static_field inside "try".
5333
5334 2019-05-29  Tom Tromey  <tromey@adacore.com>
5335
5336         * inflow.c (struct terminal_info): Add default operator=.
5337         * configure: Rebuild.
5338         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5339         -Wdeprecated-copy-dtor, -Wredundant-move.
5340
5341 2019-05-29  Tom Tromey  <tromey@adacore.com>
5342
5343         * NEWS: Add entry.
5344         * infcmd.c (print_return_value_1): Handle finish_print
5345         option.
5346         (show_print_finish): New function.
5347         (_initialize_infcmd): Add "set/show print finish" commands.
5348         * valprint.c (user_print_options): Initialize new member.
5349         * valprint.h (struct value_print_options) <finish_print>: New
5350         member.
5351
5352 2019-05-28  Tom Tromey  <tromey@adacore.com>
5353
5354         * ada-lang.c (ada_remove_Xbn_suffix)
5355         (find_old_style_renaming_symbol)
5356         (parse_old_style_renaming): Remove.
5357         (ada_find_renaming_symbol): Don't call
5358         find_old_style_renaming_symbol.
5359         (ada_is_renaming_symbol): Rename from
5360         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5361         bool.  Now static.
5362         (ada_read_var_value): Update and simplify.
5363         * ada-exp.y (write_var_or_type): Remove old code.
5364
5365 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5366
5367         * event-top.c: Remove include comment.
5368         * inflow.c (class scoped_ignore_sigttou): Move from here...
5369         * inflow.h (class scoped_ignore_sigttou): ...to here.
5370         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5371         * top.c:  Remove include comment.
5372
5373 2019-05-27  Tom Tromey  <tom@tromey.com>
5374
5375         * NEWS: Fix typo.
5376
5377 2019-05-22  Tom Tromey  <tromey@adacore.com>
5378
5379         * target.c (target_follow_exec): Constify parameter.
5380         * target-delegates.c: Rebuild.
5381         * remote.c (remote_target::follow_exec): Constify parameter.
5382         * infrun.c (follow_exec): Constify parameter.
5383         * target.h (struct target_ops) <follow_exec>: Constify parameter.
5384         (target_follow_exec): Likewise.
5385
5386 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5387
5388         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
5389         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
5390
5391 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
5392
5393         * NEWS: Add debugredirect and testsuite sections.
5394
5395 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
5396
5397         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
5398         target descriptions using exclusively floating point register name
5399         aliases.
5400
5401 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
5402
5403         PR gdb/18644:
5404         * f-lang.c (build_fortran_types): Handle the case where
5405         gdbarch_floatformat_for_type returns a nullptr.
5406
5407 2019-05-21  Tom de Vries  <tdevries@suse.de>
5408
5409         PR cli/24587
5410         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
5411
5412 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5413
5414         PR gdb/18644:
5415         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
5416         16-byte floats.
5417         * i386-tdep.c (i386_floatformat_for_type): Use
5418         floatformats_ia64_quad for the 16-byte floating point component
5419         within a fortran 32-byte complex number.
5420
5421 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5422
5423         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
5424         delete default constructor.
5425         (find_partial_die): Update to return const struct.
5426         (partial_die_parent_scope): Move variable declaration into scope
5427         of its use and change its type to auto.
5428         (guess_partial_die_structure_name): Likewise.
5429         (partial_die_info::fixup): Likewise.
5430
5431 2019-05-17  Tom Tromey  <tromey@adacore.com>
5432
5433         * source.c (find_and_open_source): Remove cast.
5434
5435 2019-05-17  Tom Tromey  <tromey@adacore.com>
5436
5437         * annotate.c (annotate_source): Make "filename" const.
5438         * annotate.h (annotate_source): Use const.
5439
5440 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5441
5442         * disasm.c (set_disassembler_options): Send errors to stderr.
5443
5444 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5445
5446         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
5447         (cli_interp_base::set_logging): Check debug_redirect.
5448         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
5449         * cli/cli-logging.c (debug_redirect): Add static variable.
5450         (pop_output_files): Add default param.
5451         (handle_redirections): Print debug setting.
5452         (show_logging_command): Likewise.
5453         (_initialize_cli_logging): Add debugredirect command.
5454         * interps.c (current_interp_set_logging): Add debug_redirect
5455         parameter.
5456         * interps.h (set_logging): Add debug_redirect parameter.
5457         (current_interp_set_logging): Likewise.
5458         * mi/mi-common.h: Likewise.
5459         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
5460
5461 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
5462             Tom Tromey  <tromey@adacore.com>
5463
5464         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
5465         directly.
5466         * cli/cli-interp.h (make_logging_output): Remove declaration.
5467         * cli/cli-logging.c (make_logging_output): Remove function.
5468         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
5469         directly.
5470         * ui-file.c (tee_file::tee_file): Remove bools.
5471         (tee_file::~tee_file): Remove deletes.
5472         * ui-file.h (tee_file): Remove bools.
5473
5474 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
5475
5476         * mi/mi-cmds.h (mi_cmd_complete): New function.
5477         * mi/mi-main.c (mi_cmd_complete): Likewise.
5478         * mi/mi-cmds.c: Define new MI command -complete.
5479         * NEWS: Mention new -complete command.
5480
5481 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
5482
5483         * completer.h (complete): New function.
5484         * completer.c (complete): Likewise.
5485         * cli/cli-cmds.c: (complete_command): Update to use new complete()
5486         function defined in completer.h.
5487
5488 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
5489
5490         * MAINTAINERS (Write After Approval): Add myself.
5491
5492 2019-05-17  Tom de Vries  <tdevries@suse.de>
5493
5494         PR gdb/24094
5495         * dwarf2read.c (struct cu_partial_die_info): New struct.
5496         (find_partial_die): Return cu_partial_die_info.
5497         (partial_die_parent_scope, guess_partial_die_structure_name)
5498         (partial_die_info::fixup): Handle new return type of find_partial_die.
5499
5500 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5501
5502         * stap-probe.c (stap_parse_register_operand): Make "regname" an
5503         "std::string", simplifying the algorithm.
5504
5505 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5506
5507         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
5508         (stap_static_probe_ops::get_probes): Likewise.
5509
5510 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5511
5512         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
5513         '-')" and "else if".
5514         (stap_parse_single_operand): Join checks for
5515         "gdbarch_stap_parse_special_token_p" and
5516         "gdbarch_stap_parse_special_token" in the same "if" statement.
5517         Invert check when verifying for operation on register
5518         displacement.
5519
5520 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5521
5522         * stap-probe.c (stap_get_opcode): Update comment.
5523         (stap_get_expected_argument_type): Likewise.
5524         (handle_stap_probe): Likewise.
5525
5526 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
5527
5528         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
5529         return type to 'bool'.  Adjust comment.  Use 'bool' when
5530         appropriate.
5531         (i386_stap_parse_special_token_three_arg_disp): Likewise.
5532         * stap-probe.c (stap_parse_argument_1): Likewise.
5533         (stap_is_operator): Likewise.
5534         (stap_is_generic_prefix): Likewise.
5535         (stap_is_register_prefix): Likewise.
5536         (stap_is_register_indirection_prefix): Likewise.
5537         (stap_is_integer_prefix): Likewise.
5538         (stap_generic_check_suffix): Likewise.
5539         (stap_check_integer_suffix): Likewise.
5540         (stap_check_register_suffix): Likewise.
5541         (stap_check_register_indirection_suffix): Likewise.
5542         (stap_parse_register_operand): Likewise.
5543         (stap_parse_single_operand): Likewise.
5544         (stap_parse_argument_1): Likewise.
5545         (stap_probe::get_argument_count): Likewise.
5546         (stap_is_operator): Likewise.
5547
5548 2019-05-16  Tom Tromey  <tromey@adacore.com>
5549
5550         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
5551         keyword to foreach.
5552
5553 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
5554
5555         * linux-thread-db.c (try_thread_db_load_1): Change return type
5556         to bool.
5557         (try_thread_db_load): Likewise.
5558         (try_thread_db_load_from_pdir_1): Likewise.
5559         (try_thread_db_load_from_pdir): Likewise.
5560         (try_thread_db_load_from_sdir): Likewise.
5561         (try_thread_db_load_from_dir): Likewise.
5562         (thread_db_load_search): Likewise.
5563         (has_libpthread): Likewise.
5564         (thread_db_load): Likewise.
5565
5566 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
5567
5568         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5569         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
5570         NULL, and complain/return if that's the case.
5571
5572 2019-05-15  John Darrington <john@darrington.wattle.id.au>
5573
5574         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
5575         (advance, posn, abstract_read_memory): New functions.
5576         [struct mem_read_abstraction]: New struct.
5577         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
5578
5579 2019-05-14  Tom Tromey  <tromey@adacore.com>
5580
5581         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
5582         value is not lval_memory.
5583
5584 2019-05-14  Tom Tromey  <tromey@adacore.com>
5585
5586         * solib.c (info_sharedlibrary_command): Style the file name.
5587
5588 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
5589
5590         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
5591         (aarch64_vnv_type): Likewise.
5592         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
5593         * common/tdesc.c: Likewise.
5594         * common/tdesc.h (enum tdesc_type_kind): Likewise.
5595         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
5596         * features/aarch64-fpu.xml: Add ieee half view.
5597         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
5598         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
5599         * gdbtypes.h (struct builtin_type): Likewise.
5600         (struct objfile_type): Likewise.
5601
5602 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
5603
5604         * language.c (language_sniff_from_mangled_name): Fix "langauge"
5605         typo.
5606         * location.h (string_to_event_location): Likewise.
5607
5608 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
5609
5610         GDB 8.3 released.
5611
5612 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5613
5614         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
5615         New variable declaration.
5616         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
5617         New variable.
5618         (print_one_breakpoint): Use ui_out::test_flags and new global
5619         variable to compute use_fixed_output.
5620         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
5621         Remove.
5622         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
5623         (mi_multi_location_breakpoint_output_fixed): Remove.
5624         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
5625         new variable.
5626         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
5627         fix_multi_location_breakpoint_output flag if version >= 3.
5628         * ui-out.h (enum ui_out_flag)
5629         <fix_multi_location_breakpoint_output>: New enumerator.
5630
5631 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
5632
5633         * contrib/cc-with-tweaks.sh: Validate dwz's work.
5634
5635 2019-05-10  Tom Tromey  <tromey@adacore.com>
5636
5637         * ada-lang.c (catch_ada_completer): New function.
5638         (_initialize_ada_language): Use it.
5639
5640 2019-05-10  Tom Tromey  <tromey@adacore.com>
5641
5642         * thread.c (print_thread_info): Make "requested_threads" const.
5643         * gdbthread.h (print_thread_info): Make "requested_threads"
5644         const.
5645         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
5646         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
5647
5648 2019-05-08  Tom Tromey  <tom@tromey.com>
5649
5650         * gdbtypes.c (objfile_type_data): Change type.
5651         (objfile_type, _initialize_gdbtypes): Update.
5652
5653 2019-05-08  Tom Tromey  <tom@tromey.com>
5654
5655         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
5656         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
5657         (_initialize_dwarf2_frame): Update.
5658
5659 2019-05-08  Tom Tromey  <tom@tromey.com>
5660
5661         * objc-lang.c (objc_objfile_data): Change type.
5662         (find_methods): Update.
5663         (_initialize_objc_lang): Remove.
5664
5665 2019-05-08  Tom Tromey  <tom@tromey.com>
5666
5667         * stabsread.c (rs6000_builtin_type_data): Change type.
5668         (rs6000_builtin_type, _initialize_stabsread): Update.
5669
5670 2019-05-08  Tom Tromey  <tom@tromey.com>
5671
5672         * mips-tdep.c (mips_pdr_data): Remove.
5673         (_initialize_mips_tdep): Update.
5674
5675 2019-05-08  Tom Tromey  <tom@tromey.com>
5676
5677         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
5678         (hppa_init_objfile_priv_data, read_unwind_info)
5679         (find_unwind_entry, _initialize_hppa_tdep): Update.
5680
5681 2019-05-08  Tom Tromey  <tom@tromey.com>
5682
5683         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
5684         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
5685         on obstack.
5686         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
5687
5688 2019-05-08  Tom Tromey  <tom@tromey.com>
5689
5690         * mdebugread.c (basic_type_data): Change type.
5691         (basic_type, _initialize_mdebugread): Update.
5692
5693 2019-05-08  Tom Tromey  <tom@tromey.com>
5694
5695         * common/gdb_unique_ptr.h (struct noop_deleter): New.
5696
5697 2019-05-08  Tom Tromey  <tom@tromey.com>
5698
5699         * nto-tdep.c (nto_inferior_data_reg): Change type.
5700         (nto_inferior_data): Update.
5701         (nto_inferior_data_cleanup, nto_new_inferior_data)
5702         (_initialize_nto_tdep): Remove.
5703         * nto-tdep.h (struct nto_inferior_data): Add initializers.
5704
5705 2019-05-08  Tom Tromey  <tom@tromey.com>
5706
5707         * ada-lang.c (struct ada_inferior_data): Add initializers.
5708         (ada_inferior_data): Change type.
5709         (ada_inferior_data_cleanup): Remove.
5710         (get_ada_inferior_data, ada_inferior_exit)
5711         (struct ada_pspace_data): Add initializers, destructor.
5712         (ada_pspace_data_handle): Change type.
5713         (get_ada_pspace_data): Update.
5714         (ada_pspace_data_cleanup): Remove.
5715
5716 2019-05-08  Tom Tromey  <tom@tromey.com>
5717
5718         * coffread.c (struct coff_symfile_info): Add initializers.
5719         (coff_objfile_data_key): Move lower.  Change type.
5720         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
5721         Update.
5722         (coff_free_info): Remove.
5723
5724 2019-05-08  Tom Tromey  <tom@tromey.com>
5725
5726         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
5727         (fbsd_pspace_data_handle): Move lower.  Change type.
5728         (get_fbsd_pspace_data): Update.
5729         (fbsd_pspace_data_cleanup): Remove.
5730         (_initialize_fbsd_tdep): Update.
5731
5732 2019-05-08  Tom Tromey  <tom@tromey.com>
5733
5734         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
5735         (get_ada_tasks_pspace_data): Update.
5736         (ada_tasks_pspace_data_cleanup): Remove.
5737         (_initialize_tasks): Update.
5738         (ada_tasks_inferior_data_handle): Change type.
5739         (get_ada_tasks_inferior_data): Update.
5740         (ada_tasks_inferior_data_cleanup): Remove.
5741         (struct ada_tasks_pspace_data): Add initializers.
5742
5743 2019-05-08  Tom Tromey  <tom@tromey.com>
5744
5745         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
5746         * symfile-debug.c (debug_sym_get_probes): Change type.
5747         * stap-probe.c (handle_stap_probe):
5748         (stap_static_probe_ops::get_probes): Change type.
5749         * probe.h (class static_probe_ops) <get_probes>: Change type.
5750         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
5751         (parse_probes_in_pspace): Update.
5752         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
5753         Update.
5754         (any_static_probe_ops::get_probes): Change type.
5755         * elfread.c (elfread_data): New typedef.
5756         (probe_key): Change type.
5757         (elf_get_probes): Likewise.  Update.
5758         (probe_key_free): Remove.
5759         (_initialize_elfread): Update.
5760         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
5761         Change type.
5762         (dtrace_process_dof_probe, dtrace_process_dof)
5763         (dtrace_static_probe_ops::get_probe): Change type.
5764
5765 2019-05-08  Tom Tromey  <tom@tromey.com>
5766
5767         * xcoffread.c (struct xcoff_symfile_info): Rename from
5768         coff_symfile_info.  Add initializers.
5769         (xcoff_objfile_data_key): Move lower.  Change type.
5770         (XCOFF_DATA): Rewrite.
5771         (xcoff_free_info): Remove.
5772         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
5773         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
5774         (xcoff_initial_scan): Update.
5775
5776 2019-05-08  Tom Tromey  <tom@tromey.com>
5777
5778         * solib-svr4.c (struct svr4_info): Add initializers and
5779         destructor.
5780         <probes_table>: Now an htab_up.
5781         (solib_svr4_pspace_data): Change type.
5782         (free_probes_table): Simplify.
5783         (~svr4_info): Rename from svr4_pspace_data_cleanup.
5784         (get_svr4_info, probes_table_htab_remove_objfile_probes)
5785         (probes_table_remove_objfile_probes, register_solib_event_probe)
5786         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
5787         (_initialize_svr4_solib): Update.
5788
5789 2019-05-08  Tom Tromey  <tom@tromey.com>
5790
5791         * remote.c (remote_pspace_data): Change type.
5792         (remote_pspace_data_cleanup): Remove.
5793         (get_remote_exec_file, set_pspace_remote_exec_file)
5794         (_initialize_remote): Update.
5795
5796 2019-05-08  Tom Tromey  <tom@tromey.com>
5797
5798         * breakpoint.c (breakpoint_objfile_key): Change type.
5799         (get_breakpoint_objfile_data): Update.
5800         (free_breakpoint_objfile_data): Remove.
5801         (_initialize_breakpoint): Update.
5802
5803 2019-05-08  Tom Tromey  <tom@tromey.com>
5804
5805         * linux-tdep.c (struct linux_info): Add initializers.
5806         (linux_inferior_data): Move.  Change type.
5807         (invalidate_linux_cache_inf): Update.
5808         (linux_inferior_data_cleanup): Remove.
5809         (get_linux_inferior_data, _initialize_linux_tdep): Update.
5810
5811 2019-05-08  Tom Tromey  <tom@tromey.com>
5812
5813         * auxv.c (auxv_inferior_data): Move.  Change type.
5814         (auxv_inferior_data_cleanup): Remove.
5815         (invalidate_auxv_cache_inf): Rewrite.
5816         (get_auxv_inferior_data, _initialize_auxv): Update.
5817
5818 2019-05-08  Tom Tromey  <tom@tromey.com>
5819
5820         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
5821         (symfile_debug_objfile_data_key): Change type.
5822         (symfile_debug_installed, debug_qf_has_symbols)
5823         (debug_qf_find_last_source_symtab)
5824         (debug_qf_forget_cached_source_info)
5825         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
5826         (debug_qf_print_stats, debug_qf_dump)
5827         (debug_qf_expand_symtabs_for_function)
5828         (debug_qf_expand_all_symtabs)
5829         (debug_qf_expand_symtabs_with_fullname)
5830         (debug_qf_map_matching_symbols)
5831         (debug_qf_expand_symtabs_matching)
5832         (debug_qf_find_pc_sect_compunit_symtab)
5833         (debug_qf_map_symbol_filenames)
5834         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
5835         (debug_sym_new_init, debug_sym_init, debug_sym_read)
5836         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
5837         (debug_sym_read_linetable, debug_sym_relocate): Update.
5838         (symfile_debug_free_objfile): Remove.
5839         (install_symfile_debug_logging, _initialize_symfile_debug):
5840         Update.
5841
5842 2019-05-08  Tom Tromey  <tom@tromey.com>
5843
5844         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
5845         allocate_on_obstack.
5846         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
5847         (get_dwarf2_per_objfile): Update.
5848         (set_dwarf2_per_objfile): Remove.
5849         (dwarf2_has_info, dwarf2_get_section_info): Update.
5850         (dwarf2_free_objfile): Remove.
5851         (_initialize_dwarf2_read): Update.
5852
5853 2019-05-08  Tom Tromey  <tom@tromey.com>
5854
5855         * auto-load.c (struct auto_load_pspace_info): Add destructor and
5856         initializers.
5857         <unsupported_script_warning_printed,
5858         script_not_found_warning_printed>: Now bool.
5859         (auto_load_pspace_data): Change type.
5860         (~auto_load_pspace_info): Rename from
5861         auto_load_pspace_data_cleanup.
5862         (get_auto_load_pspace_data, init_loaded_scripts_info)
5863         (clear_section_scripts, maybe_print_unsupported_script_warning)
5864         (maybe_print_script_not_found_warning, _initialize_auto_load):
5865         Update.
5866
5867 2019-05-08  Tom Tromey  <tom@tromey.com>
5868
5869         * objfiles.c (objfile_pspace_info): Add destructor and
5870         initializers.
5871         (objfiles_pspace_data): Change type.
5872         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
5873         (get_objfile_pspace_data): Update.
5874         (objfiles_bfd_data): Change type.
5875         (get_objfile_bfd_data): Update.
5876         (objfile_bfd_data_free, _initialize_objfiles): Remove.
5877
5878 2019-05-08  Tom Tromey  <tom@tromey.com>
5879
5880         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
5881         Change type.
5882         (get_catch_syscall_inferior_data): Update.
5883         (catch_syscall_inferior_data_cleanup): Remove.
5884         (_initialize_break_catch_syscall): Update.
5885
5886 2019-05-08  Tom Tromey  <tom@tromey.com>
5887
5888         * inflow.c (struct terminal_info): Add destructor and
5889         initializers.
5890         (inflow_inferior_data): Change type.
5891         (~terminal_info): Rename from inflow_inferior_data_cleanup.
5892         (get_inflow_inferior_data, inflow_inferior_exit)
5893         (swap_terminal_info, _initialize_inflow): Update.
5894
5895 2019-05-08  Tom Tromey  <tom@tromey.com>
5896
5897         * target-dcache.c (target_dcache_cleanup): Remove.
5898         (target_dcache_aspace_key): Change type.
5899         (target_dcache_init_p, target_dcache_invalidate)
5900         (target_dcache_get, target_dcache_get_or_init)
5901         (_initialize_target_dcache): Update.
5902         * dcache.h (struct dcache_deleter): New.
5903
5904 2019-05-08  Tom Tromey  <tom@tromey.com>
5905
5906         * symtab.c (struct symbol_cache): Add destructor and
5907         initializers.
5908         (symbol_cache_key): Move.  Change type.
5909         (make_symbol_cache, free_symbol_cache): Remove.
5910         (get_symbol_cache): Update.
5911         (symbol_cache_cleanup): Remove.
5912         (ALL_PSPACES, symbol_cache_flush)
5913         (maintenance_print_symbol_cache)
5914         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
5915         Update.
5916
5917 2019-05-08  Tom Tromey  <tom@tromey.com>
5918
5919         * symtab.c (struct main_info): Add destructor and initializers.
5920         (main_progspace_key): Move.  Change type.
5921         (get_main_info): Update.
5922         (main_info_cleanup): Remove.
5923         (_initialize_symtab): Update.
5924
5925 2019-05-08  Tom Tromey  <tom@tromey.com>
5926
5927         * registry.h (DECLARE_REGISTRY): Define the _key class.
5928
5929 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5930
5931         * NEWS: Merge two 'New commands' sections.
5932
5933 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
5934
5935         * ada-valprint.c (ada_val_print_gnat_array): Remove language
5936         parameter and use Ada language definition instead.
5937         (ada_val_print_ptr): Remove unused language parameter.
5938         (ada_val_print_num): Remove language parameter and use Ada language
5939         definition instead.
5940         (ada_val_print_enum, ada_val_print_flt): Remove unused language
5941         parameter.
5942         (ada_val_print_struct_union, ada_val_print_ref): Remove language
5943         parameter and use Ada language definition instead.
5944         (ada_val_print_1): Update all ada_val_print_xxx calls.
5945         Remove language parameter.
5946         (ada_val_print): Update ada_val_print_1 call.
5947
5948 2019-05-08  Tom Tromey  <tromey@adacore.com>
5949
5950         * remote.c (remote_hw_watchpoint_limit)
5951         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
5952         Now static.
5953
5954 2019-05-08  Tom Tromey  <tromey@adacore.com>
5955
5956         * maint.c (_initialize_maint_cmds): Move initialization code to
5957         remote.c.
5958         (watchdog, show_watchdog): Move to remote.c.
5959         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
5960         "watchdog" static.
5961         (_initialize_remote): Move initialization code from maint.c.
5962         * defs.h (watchdog): Don't declare.
5963
5964 2019-05-08  Tom Tromey  <tromey@adacore.com>
5965
5966         * tui/tui-interp.c: Include main.h.
5967         * interps.c: Include main.h.
5968         * main.h (interpreter_p): Declare.
5969         * defs.h (interpreter_p): Don't declare.
5970
5971 2019-05-08  Tom Tromey  <tromey@adacore.com>
5972
5973         * dwarf2loc.c: Include dwarf2read.h.
5974         * defs.h (read_unsigned_leb128): Don't declare.
5975         * dwarf2read.h (read_unsigned_leb128): Declare.
5976
5977 2019-05-08  Tom Tromey  <tromey@adacore.com>
5978
5979         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
5980         method.
5981
5982 2019-05-08  Tom Tromey  <tromey@adacore.com>
5983
5984         * utils.c (fputs_maybe_filtered): Reset style after paging, even
5985         when no wrap column is set.
5986
5987 2019-05-08  Tom Tromey  <tromey@adacore.com>
5988
5989         * c-lang.c (c_get_string): Handle non-C-style arrays.
5990
5991 2019-05-08  Tom Tromey  <tromey@adacore.com>
5992
5993         * typeprint.c (print_offset_data::update): Print the bit offset,
5994         not the number of bits remaining.
5995
5996 2019-05-08  Tom Tromey  <tromey@adacore.com>
5997
5998         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
5999         padding at end of comment.
6000
6001 2019-05-08  Tom Tromey  <tromey@adacore.com>
6002
6003         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6004         Compare main types.
6005
6006 2019-05-06  Tom Tromey  <tom@tromey.com>
6007
6008         * common/scoped_mmap.c: Include common-defs.h.
6009         * common/scoped_mmap.h: Don't include config.h.
6010
6011 2019-05-04  Tom Tromey  <tom@tromey.com>
6012
6013         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6014         (struct aarch64_call_info): Add initializers.
6015         <si>: Now a std::vector.
6016         (pass_on_stack, aarch64_push_dummy_call): Update.
6017
6018 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6019             Tom Tromey  <tom@tromey.com>
6020
6021         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6022         (ppc_threads): Now a std::vector.  Now static.
6023         (hwdebug_find_thread_points_by_tid)
6024         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6025         Update.
6026
6027 2019-05-04  Tom Tromey  <tom@tromey.com>
6028
6029         * arc-tdep.c (arc_tdesc_init): Return bool.
6030
6031 2019-05-04  Tom Tromey  <tom@tromey.com>
6032
6033         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6034         Use gdb_assert_not_reached.
6035
6036 2019-05-04  Tom Tromey  <tom@tromey.com>
6037
6038         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6039         "false".
6040
6041 2019-05-04  Tom Tromey  <tom@tromey.com>
6042
6043         * arc-tdep.c (arc_tdesc_init): Use bool.
6044
6045 2019-05-04  Tom Tromey  <tom@tromey.com>
6046
6047         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6048
6049 2019-05-04  Tom Tromey  <tom@tromey.com>
6050
6051         * cli/cli-cmds.c (valid_command_p): Return bool.
6052
6053 2019-05-04  Tom Tromey  <tom@tromey.com>
6054
6055         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6056         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6057
6058 2019-05-04  Raul Tambre  <raul@tambre.ee>
6059
6060         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6061         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6062         operator for comparison.
6063
6064 2019-05-04  Tom Tromey  <tom@tromey.com>
6065
6066         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6067         (lookup_partial_symbol, print_partial_symbols)
6068         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6069         (psymbol_compare): Update.
6070         (add_psymbol_to_bcache): Clear the entire psymbol.
6071         (maintenance_check_psymtabs): Update.
6072         * psympriv.h (struct partial_symbol): Don't derive from
6073         general_symbol_info.
6074         <obj_section, unrelocated_address, address,
6075         set_unrelocated_address>: Update.
6076         <ginfo>: New member.
6077         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6078         (debug_names::write_psymbols): Update.
6079
6080 2019-05-04  Tom de Vries  <tdevries@suse.de>
6081
6082         * contrib/cc-with-tweaks.sh: Support -n arg.
6083
6084 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6085
6086         * corelow.c (core_target::detach): Ensure frame cache and
6087         register caches are cleared.
6088         inferior.c (exit_inferior_1): Likewise.
6089
6090 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6091             Tom Tromey  <tom@tromey.com>
6092
6093         * dictionary.c (collate_pending_symbols_by_language): Remove
6094         "struct" from foreach.
6095         * symtab.c (lookup_global_symbol_from_objfile)
6096         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6097         foreach.
6098         * ser-tcp.c (net_open): Remove "struct" from foreach.
6099         * objfiles.c (objfile_relocate, objfile_rebase)
6100         (objfile_has_symbols): Remove "struct" from foreach.
6101         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6102         from foreach.
6103         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6104         foreach.
6105         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6106         "struct" from foreach.
6107         * ada-lang.c (create_excep_cond_exprs)
6108         (ada_exception_catchpoint_cond_string): Remove "struct" from
6109         foreach.
6110
6111 2019-05-03  Tom Tromey  <tromey@adacore.com>
6112
6113         * ada-exp.y (convert_char_literal): Check suffix of each
6114         enumerator.
6115
6116 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6117
6118         PR ada/21406:
6119         * ada-exp.y (yywrap): Don't define.
6120         * ada-lex.l (%option): Add noyywrap
6121         (yywrap): Remove.
6122
6123 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6124
6125         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6126         _WIN32_WINNT to the XP level, unless already defined to a higher
6127         level.
6128
6129         * unittests/parse-connection-spec-selftests.c:
6130         * ser-tcp.c:
6131         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6132         override.
6133
6134         * symfile.c (find_separate_debug_file): Remove colon from the
6135         drive spec of DOS/Windows file names of the target, so that the
6136         file name produced from DEBUGDIR and the target's directory will
6137         be valid on DOS/Windows systems.
6138
6139 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6140
6141         * rust-lang.c (val_print_struct): Handle printing structures
6142         containing strings.
6143
6144 2019-05-02  Tom Tromey  <tromey@adacore.com>
6145
6146         * valarith.c (_initialize_valarith): Remove.
6147
6148 2019-05-01  Tom Tromey  <tromey@adacore.com>
6149
6150         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6151         bitfields.
6152
6153 2019-05-01  Tom Tromey  <tromey@adacore.com>
6154
6155         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6156         for big-endian copies.
6157
6158 2019-04-30  Ali Tamur  <tamur@google.com>
6159         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6160         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6161         (read_3_bytes): New function.
6162
6163 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6164
6165         * windows-nat.c (main_thread_id): Delete.
6166         (handle_output_debug_string): Replace main_thread_id by
6167         current_event.dwThreadId.
6168         (fake_create_process): Likewise.
6169         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6170         Do not set main_thread_id.
6171         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6172         current_event.dwThreadId.
6173         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6174
6175 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6176
6177         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6178         Use current_event.dwThreadId instead of main_thread_id.
6179
6180 2019-04-30  Tom Tromey  <tromey@adacore.com>
6181
6182         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6183         (create_excep_cond_exprs): Iterate over program spaces.
6184         (ada_exception_catchpoint_cond_string): Examine all minimal
6185         symbols for exception types.
6186
6187 2019-04-30  Tom Tromey  <tromey@adacore.com>
6188
6189         PR c++/24470:
6190         * dwarf2read.c (process_structure_scope): Handle case where type
6191         has template parameters but no symbol was created.
6192
6193 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6194             Chris January  <chris.january@arm.com>
6195
6196         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6197         qualifier.
6198         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6199
6200 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6201
6202         * f-typeprint.c (f_print_type): Update rules for printing
6203         whitespace.
6204         (f_type_print_varspec_suffix): Likewise.
6205
6206 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6207             Chris January  <chris.january@arm.com>
6208
6209         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6210         function arguments.
6211
6212 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6213
6214         * f-lang.c (build_fortran_types): Change name of void type to
6215         lower case.
6216         * f-typeprint.c (f_type_print_base): Print the name of the void
6217         type, rather than a fixed string.
6218         * f-valprint.c (f_decorations): Use lower case void string.
6219
6220 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6221             Chris January  <chris.january@arm.com>
6222
6223         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6224         types for Fortran.
6225
6226 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6227             Chris January  <chris.january@arm.com>
6228             David Lecomber  <david.lecomber@arm.com>
6229
6230         * f-exp.y (BINOP_INTRINSIC): New token.
6231         (exp): New parser rule handling BINOP_INTRINSIC.
6232         (f77_keywords): Add new builtin procedures.
6233         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6234         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6235         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6236         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6237         (print_unop_subexp_f): New function.
6238         (print_binop_subexp_f): New function.
6239         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6240         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6241         (dump_subexp_body_f): Likewise.
6242         (operator_check_f): Likewise.
6243         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6244         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6245
6246 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6247
6248         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6249         UNOP_KIND.
6250         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6251         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6252         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6253         (operator_length_f): New fuction.
6254         (print_subexp_f): New function.
6255         (op_name_f): New function.
6256         (dump_subexp_body_f): New function.
6257         (operator_check_f): New function.
6258         (exp_descriptor_f): Replace standard expression handling functions
6259         with new functions.
6260         * gdb/fortran-operator.def: New file.
6261         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6262         * gdb/std-operator.def: Remove UNOP_KIND.
6263
6264 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6265
6266         * std-operator.def: Remove unbalanced, stray double quote
6267         character.
6268
6269 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6270             Chris January  <chris.january@arm.com>
6271             Daniel Everett  <daniel.everett@arm.com>
6272             Nick Forrington  <nick.forrington@arm.com>
6273             Richard Bunt  <richard.bunt@arm.com>
6274
6275         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6276         of depth when printing anonymous structs or unions.
6277         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6278         Don't print either the top-level value, or the children if the
6279         max-depth is exceeded.
6280         (ppscm_print_children): When printing the key of a map, allow one
6281         extra level of depth.
6282         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6283         print either the top-level value, or the children if the max-depth
6284         is exceeded.
6285         (print_children): When printing the key of a map, allow one extra
6286         level of depth.
6287         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6288         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6289         (user_print_options): Initialise max_depth field.
6290         (val_print_scalar_or_string_type_p): New function.
6291         (val_print): Check to see if the max depth has been reached.
6292         (val_print_check_max_depth): Define new function.
6293         (show_print_max_depth): New function.
6294         (_initialize_valprint): Add 'print max-depth' option.
6295         * valprint.h (struct value_print_options) <max_depth>: New field.
6296         (val_print_check_max_depth): Declare new function.
6297         * NEWS: Document new feature.
6298
6299 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6300
6301         * ada-lang.c (ada_language_defn): Initialise new field.
6302         * c-lang.c (c_is_string_type_p): New function.
6303         (c_language_defn): Initialise new field.
6304         (cplus_language_defn): Initialise new field.
6305         (asm_language_defn): Initialise new field.
6306         (minimal_language_defn): Initialise new field.
6307         * c-lang.h (c_is_string_type_p): Declare new function.
6308         * d-lang.c (d_language_defn): Initialise new field.
6309         * f-lang.c (f_is_string_type_p): New function.
6310         (f_language_defn): Initialise new field.
6311         * go-lang.c (go_is_string_type_p): New function.
6312         (go_language_defn): Initialise new field.
6313         * language.c (default_is_string_type_p): New function.
6314         (unknown_language_defn): Initialise new field.
6315         (auto_language_defn): Initialise new field.
6316         * language.h (struct language_defn) <la_is_string_type_p>: New
6317         member variable.
6318         (default_is_string_type_p): Declare new function.
6319         * m2-lang.c (m2_language_defn): Initialise new field.
6320         * objc-lang.c (objc_language_defn): Initialise new field.
6321         * opencl-lang.c (opencl_language_defn): Initialise new field.
6322         * p-lang.c (pascal_is_string_type_p): New function.
6323         (pascal_language_defn): Initialise new field.
6324         * rust-lang.c (rust_is_string_type_p): New function.
6325         (rust_language_defn): Initialise new field.
6326
6327 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6328
6329         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6330         New field.
6331         * ada-lang.c (ada_language_defn): Initialise new field.
6332         * c-lang.c (c_language_defn): Likewise.
6333         (cplus_language_defn): Likewise.
6334         (asm_language_defn): Likewise.
6335         (minimal_language_defn): Likewise.
6336         * d-lang.c (d_language_defn): Likewise.
6337         * f-lang.c (f_language_defn): Likewise.
6338         * go-lang.c (go_language_defn): Likewise.
6339         * language.c (unknown_language_defn): Likewise.
6340         (auto_language_defn): Likewise.
6341         * m2-lang.c (m2_language_defn): Likewise.
6342         * objc-lang.c (objc_language_defn): Likewise.
6343         * opencl-lang.c (opencl_language_defn): Likewise.
6344         * p-lang.c (pascal_language_defn): Likewise.
6345         * rust-lang.c (rust_language_defn): Likewise.
6346
6347 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6348
6349         * ada-lang.c (ada_is_character_type): Change return type to bool.
6350         (ada_is_string_type): Likewise.
6351         * ada-lang.h (ada_is_character_type): Update declaration
6352         (ada_is_string_type): Likewise.
6353
6354 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6355
6356         Support style in 'frame|thread apply'
6357
6358         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6359         * record.c (record_start, record_stop): Update callers of
6360         execute_command_to_string with false.
6361         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6362         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6363         methods.
6364         (class string_file): New constructor with term_out parameter.
6365         Override methods term_out and can_emit_style_escape.  New member
6366         term_out.
6367         (class stdio_file): Override can_emit_style_escape.
6368         (class tee_file): Override term_out and can_emit_style_escape.
6369         * utils.h (can_emit_style_escape): Remove.
6370         * utils.c (can_emit_style_escape): Likewise.
6371         Update all callers of can_emit_style_escape (SOMESTREAM) to
6372         SOMESTREAM->can_emit_style_escape.
6373         * source-cache.c (source_cache::get_source_lines): Likewise.
6374         * stack.c (frame_apply_command_count): Call execute_command_to_string
6375         passing the term_out characteristic of the current gdb_stdout.
6376         * thread.c (thr_try_catch_cmd): Likewise.
6377         * top.c (execute_command_to_string): pass term_out parameter
6378         to construct the string_file for the command output.
6379         * ui-file.c (term_cli_styling): New function (most code moved
6380         from utils.c can_emit_style_escape).
6381         (string_file::string_file, string_file::can_emit_style_escape,
6382         stdio_file::can_emit_style_escape, tee_file::term_out,
6383         tee_file::can_emit_style_escape): New functions.
6384
6385 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6386
6387         * NEWS: Mention the new set|show may-call-functions.
6388         * infcall.c (may_call_functions_p): New variable.
6389         (show_may_call_functions_p): New function.
6390         (call_function_by_hand_dummy): Throws an error if not
6391         may-call-functions.
6392         (_initialize_infcall): Call add_setshow_boolean_cmd for
6393         may-call-functions.
6394
6395 2019-04-25  Keith Seitz  <keiths@redhat.com>
6396
6397         PR c++/24367
6398         * cp-support.c (inspect_type): Don't attempt substitutions
6399         of symbol with the same name.
6400
6401 2019-04-25  Tom Tromey  <tromey@adacore.com>
6402
6403         PR gdb/24475:
6404         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
6405         static.
6406
6407 2019-04-25  Tom Tromey  <tromey@adacore.com>
6408
6409         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
6410         rvalue reference.
6411         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
6412         (gdb_xml_parser::parse): Use std::move.
6413         * python/python-internal.h (gdbpy_convert_exception): Take a const
6414         reference.
6415         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
6416         std::move.
6417         * python/py-utils.c (gdbpy_convert_exception): Take a const
6418         reference.
6419         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6420         Use std::move.
6421         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6422         Use std::move.
6423         * mi/mi-main.c (mi_print_exception): Take a const reference.
6424         * main.c (handle_command_errors): Take a const reference.
6425         * linespec.c (parse_linespec): Use std::move.
6426         * infcall.c (run_inferior_call): Use std::move.
6427         (call_function_by_hand_dummy): Use std::move.
6428         * exec.c (try_open_exec_file): Use std::move.
6429         * exceptions.h (exception_print, exception_fprintf)
6430         (exception_print_same): Update.
6431         * exceptions.c (print_exception, exception_print)
6432         (exception_fprintf, exception_print_same): Change parameters to
6433         const reference.
6434         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
6435         * common/new-op.c: Use std::move.
6436         * common/common-exceptions.h (struct gdb_exception): Add move
6437         constructor.
6438         (struct gdb_exception_error, struct gdb_exception_quit, struct
6439         gdb_quit_bad_alloc): Change constructor to move constructor.
6440         (throw_exception): Change parameter to rvalue reference.
6441         * common/common-exceptions.c (throw_exception): Take rvalue
6442         reference.
6443         * cli/cli-interp.c (safe_execute_command): Use std::move.
6444         * breakpoint.c (insert_bp_location, location_to_sals): Use
6445         std::move.
6446
6447 2019-04-25  Tom Tromey  <tromey@adacore.com>
6448
6449         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
6450         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
6451         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
6452         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
6453         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
6454         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
6455         guile/scm-value.c: Use unpack.
6456         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
6457         gdbscm_gdb_exception.
6458         (gdbscm_throw_gdb_exception): Likewise.
6459         (struct gdbscm_gdb_exception): New.
6460         (unpack): New function.
6461         (gdbscm_wrap): Use unpack.
6462
6463 2019-04-25  Tom Tromey  <tromey@adacore.com>
6464
6465         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6466         (gdb_rl_callback_handler): Use std::move.
6467         * common/common-exceptions.h (struct gdb_exception): Add move
6468         assignment operator.
6469         (throw_exception_sjlj): Change "exception" to const reference.
6470         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
6471         (throw_exception_sjlj): Change "exception" to const reference.
6472
6473 2019-04-25  Tom Tromey  <tromey@adacore.com>
6474
6475         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
6476         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
6477         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
6478         Update.
6479         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
6480         Update.
6481         * mi/mi-interp.c (mi_interp::exec): Update.
6482         * linespec.c (parse_linespec): Update.
6483         * infcall.c (run_inferior_call): Update.
6484         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
6485         * guile/scm-symbol.c (gdbscm_lookup_symbol)
6486         (gdbscm_lookup_global_symbol): Update.
6487         * guile/scm-param.c (gdbscm_parameter_value): Update.
6488         * guile/scm-frame.c (gdbscm_frame_read_register)
6489         (gdbscm_frame_read_var): Update.
6490         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
6491         * exec.c (try_open_exec_file): Update.
6492         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
6493         (gdb_rl_callback_handler): Update.
6494         * common/common-exceptions.h (exception_none): Don't declare.
6495         * common/common-exceptions.c (exception_none): Don't define.
6496         (struct catcher) <exception>: Update.
6497         * cli/cli-interp.c (safe_execute_command): Update.
6498         * breakpoint.c (insert_bp_location, location_to_sals): Update.
6499
6500 2019-04-25  Ali Tamur  <tamur@google.com>
6501
6502         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
6503         (read_attribute_value): Likewise.
6504         (dwarf2_read_addr_index): Update comment.
6505         (read_str_index): Add DW_FORM_strx.
6506         (dwarf2_string_attr): Likewise.
6507         (dwarf2_const_value_attr): Likewise.
6508         (dump_die_shallow): Likewise.
6509         (dwarf2_fetch_constant_bytes): Likewise.
6510         (skip_form_bytes): Likewise.
6511         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
6512
6513 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
6514
6515         PR corefiles/11608
6516         PR corefiles/18187
6517         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
6518         OFFSET.  Verify if current mapping contains an ELF header.
6519         (linux_find_memory_regions_full): Adjust call to
6520         dump_mapping_p.
6521
6522 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
6523             Kang Li <kanglictf@gmail.com>
6524
6525         PR gdb/21600
6526
6527         * dwarf2-frame.c (read_initial_length): Be consistent about using
6528         unsigned representation of length.
6529         (decode_frame_entry_1): Likewise.  Check for wraparound of
6530         end pointer as well as buffer overflow.
6531
6532 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
6533
6534         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
6535         "vq".
6536
6537 2019-04-24  Tom Tromey  <tromey@adacore.com>
6538
6539         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
6540
6541 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6542
6543         * s12z-tdep.c (s12z_unwind_pc): Delete.
6544         (s12z_unwind_sp): Delete.
6545         (s12z_gdbarch_init): Don't register deleted functions with
6546         gdbarch.
6547
6548 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6549
6550         * rl78-tdep.c (rl78_unwind_sp): Delete.
6551         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
6552
6553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6554
6555         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
6556         (xstormy16_unwind_pc): Delete.
6557         (xstormy16_dummy_id): Delete.
6558         (xstormy16_gdbarch_init): Don't register deleted functions with
6559         gdbarch.
6560
6561 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6562
6563         * vax-tdep.c (vax_unwind_pc): Delete.
6564         (vax_gdbarch_init): Don't register deleted function with gdbarch.
6565
6566 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6567
6568         * v850-tdep.c (v850_unwind_sp): Delete.
6569         (v850_unwind_pc): Delete.
6570         (v850_dummy_id): Delete.
6571         (v850_gdbarch_init): Don't register deleted functions with
6572         gdbarch.
6573
6574 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6575
6576         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
6577         (tilegx_unwind_pc): Delete.
6578         (tilegx_unwind_dummy_id): Delete.
6579         (tilegx_gdbarch_init): Don't register deleted functions with
6580         gdbarch.
6581
6582 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6583
6584         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
6585         (tic6x_dummy_id): Delete.
6586         (tic6x_gdbarch_init): Don't register deleted functions with
6587         gdbarch.
6588
6589 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6590
6591         * sparc-tdep.c (sparc_unwind_pc): Delete.
6592         (sparc32_gdbarch_init): Don't register deleted function with
6593         gdbarch.
6594
6595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6596
6597         * sh-tdep.c (sh_unwind_sp): Delete.
6598         (sh_unwind_pc): Delete.
6599         (sh_dummy_id): Delete.
6600         (sh_gdbarch_init): Don't register deleted functions with
6601         gdbarch.
6602
6603 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6604
6605         * score-tdep.c (score_unwind_sp): Delete.
6606         (score_unwind_pc): Delete.
6607         (score_dummy_id): Delete.
6608         (score_gdbarch_init): Don't register deleted functions with
6609         gdbarch.
6610
6611 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6612
6613         * rx-tdep.c (rx_unwind_pc): Delete.
6614         (rx_unwind_sp): Delete.
6615         (rx_dummy_id): Delete.
6616         (rx_gdbarch_init): Don't register deleted functions with
6617         gdbarch.  Update comment.
6618
6619 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6620
6621         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
6622         (rs6000_dummy_id): Delete.
6623         (rs6000_gdbarch_init): Don't register deleted functions with
6624         gdbarch.
6625
6626 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6627
6628         * or1k-tdep.c (or1k_dummy_id): Delete.
6629         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
6630
6631 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6632
6633         * nios2-tdep.c (nios2_dummy_id): Delete.
6634         (nios2_unwind_sp): Delete.
6635         (nios2_gdbarch_init): Don't register deleted functions with
6636         gdbarch.
6637
6638 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6639
6640         * nds32-tdep.c (nds32_dummy_id): Delete.
6641         (nds32_unwind_pc): Delete.
6642         (nds32_unwind_sp): Delete.
6643         (nds32_gdbarch_init): Don't register deleted functions with
6644         gdbarch.
6645
6646 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6647
6648         * msp430-tdep.c (msp430_unwind_pc): Delete.
6649         (msp430_unwind_sp): Delete.
6650         (msp430_dummy_id): Delete.
6651         (msp430_gdbarch_init): Don't register deleted functions with
6652         gdbarch.
6653
6654 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6655
6656         * moxie-tdep.c (moxie_unwind_sp): Delete.
6657         (moxie_unwind_pc): Delete.
6658         (moxie_dummy_id): Delete.
6659         (moxie_gdbarch_init): Don't register deleted functions with
6660         gdbarch.
6661
6662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6663
6664         * mn10300-tdep.c (mn10300_dummy_id): Delete.
6665         (mn10300_unwind_pc): Delete.
6666         (mn10300_unwind_sp): Delete.
6667         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
6668         mn10300_unwind_sp.
6669         (mn10300_frame_unwind_init): Don't register deleted functions with
6670         gdbarch.
6671
6672 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6673
6674         * mep-tdep.c (mep_unwind_pc): Delete.
6675         (mep_unwind_sp): Delete.
6676         (mep_dummy_id): Delete.
6677         (mep_gdbarch_init): Don't register deleted functions with
6678         gdbarch.
6679
6680 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6681
6682         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
6683         (m68hc11_unwind_sp): Delete.
6684         (m68hc11_gdbarch_init): Don't register deleted functions with
6685         gdbarch.
6686
6687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6688
6689         * m32r-tdep.c (m32r_unwind_sp): Delete.
6690         (m32r_unwind_pc): Delete.
6691         (m32r_dummy_id): Delete.
6692         (m32r_gdbarch_init): Don't register deleted functions with
6693         gdbarch.
6694
6695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6696
6697         * m32c-tdep.c (m32c_unwind_pc): Delete.
6698         (m32c_unwind_sp): Delete.
6699         (m32c_dummy_id): Delete.
6700         (m32c_gdbarch_init): Don't register deleted functions with
6701         gdbarch.
6702
6703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6704
6705         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
6706         (lm32_unwind_pc): Delete.
6707         (lm32_dummy_id): Delete.
6708         (lm32_gdbarch_init): Don't register deleted functions with
6709         gdbarch.
6710
6711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6712
6713         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
6714         (iq2000_unwind_pc): Delete.
6715         (iq2000_dummy_id): Delete.
6716         (iq2000_gdbarch_init): Don't register deleted functions with
6717         gdbarch.
6718
6719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6720
6721         * nds32-tdep.c (nds32_type_align): Delete.
6722         (nds32_push_dummy_call): Use type_align instead.
6723
6724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6725
6726         * arm-tdep.c (arm_type_align): Only handle vector override case.
6727         (arm_push_dummy_call): Use type_align.
6728         (arm_gdbarch_init): Register arm_type_align gdbarch function.
6729
6730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
6731
6732         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
6733         case.
6734         (pass_on_stack): Use type_align.
6735         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
6736         function.
6737
6738 2019-04-23  Tom Tromey  <tromey@adacore.com>
6739
6740         * dwarf2read.c (line_header::file_name_at): Remove unused
6741         overload.
6742
6743 2019-04-23  Tom de Vries  <tdevries@suse.de>
6744
6745         PR gdb/24438
6746         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
6747         invocation.
6748
6749
6750 2019-03-27  Ali Tamur  <tamur@google.com>
6751
6752         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
6753         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
6754         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
6755         (dwarf_expr_context::get_addr_index): Likewise
6756         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
6757         (symbol_needs_eval_context::get_addr_index): Likewise
6758         (disassemble_dwarf_expression): Add DW_OP_addrx
6759         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
6760         (read_cutu_die_from_dwo): Update comment
6761         (skip_one_die): Add DW_FORM_addrx
6762         (read_attribute_value): Likewise
6763         (var_decode_location): Add DW_OP_addrx
6764         (dwarf2_const_value_attr): Add DW_FORM_addrx
6765         (dump_die_shallow): Likewise
6766         (dwarf2_fetch_constant_bytes): Likewise
6767         (decode_locdesc): Add DW_OP_addrx
6768         (skip_form_bytes): Add DW_FORM_addrx
6769
6770 2019-04-22  Ali Tamur  <tamur@google.com>
6771
6772         * MAINTAINERS (Write After Approval): Add self.
6773
6774 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
6775
6776         * solib-svr4.c (get_svr4_info): Add pspace parameter.
6777         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
6778         (open_symbol_file_object): Likewise.
6779         (svr4_default_sos): Add info parameter.
6780         (svr4_read_so_list): Likewise.
6781         (svr4_current_sos_direct): Adjust functions calls to pass down
6782         info.
6783         (svr4_current_sos_1): Add info parameter.
6784         (svr4_current_sos): Call get_svr4_info, pass info down to
6785         svr4_current_sos_1.
6786         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
6787         get_svr4_info.
6788         (svr4_in_dynsym_resolve_code): Pass current_program_space to
6789         get_svr4_info.
6790         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
6791         to get_svr4_info.
6792         (probes_table_remove_objfile_probes): Likewise.
6793         (register_solib_event_probe): Add info parameter.
6794         (solist_update_incremental): Pass info parameter down to
6795         svr4_read_so_list.
6796         (disable_probes_interface): Add info parameter.
6797         (svr4_handle_solib_event): Pass current_program_space to
6798         get_svr4_info.  Adjust disable_probes_interface cleanup.
6799         (svr4_create_probe_breakpoints): Add info parameter, pass it
6800         down to register_solib_event_probe.
6801         (svr4_create_solib_event_breakpoints): Add info parameter,
6802         pass it down to svr4_create_probe_breakpoints.
6803         (enable_break): Pass info down to
6804         svr4_create_solib_event_breakpoints.
6805         (svr4_solib_create_inferior_hook): Pass current_program_space to
6806         get_svr4_info.
6807         (svr4_clear_solib): Likewise.
6808
6809 2019-04-22  Pedro Alves  <palves@redhat.com>
6810
6811         * solib-svr4.c (svr4_free_objfile_observer): New.
6812         (probe_and_action::objfile): New field.
6813         (probes_table_htab_remove_objfile_probes)
6814         (probes_table_remove_objfile_probes): New functions.
6815         (register_solib_event_probe): Add 'objfile' parameter.  Store it
6816         in the new probe_and_action.  Don't store the probe in 'lookup'.
6817         (svr4_create_probe_breakpoints): Pass objfile to
6818         register_solib_event_probe.
6819         (_initialize_svr4_solib): Register a free_objfile observer.
6820
6821 2019-04-19  Tom Tromey  <tom@tromey.com>
6822
6823         * common/queue.h: Remove.
6824
6825 2019-04-19  Tom Tromey  <tom@tromey.com>
6826
6827         * event-loop.c: Don't include "common/queue.h".
6828
6829 2019-04-19  Tom Tromey  <tom@tromey.com>
6830
6831         * remote.c (remote_target): Use delete.
6832         * remote-notif.h: Include <list>, not "common/queue.h".
6833         (notif_client_p): Remove typedef.
6834         (remote_notif_state): Add constructor, destructor, initializer.
6835         <notif_queue>: Now a std::list.
6836         (remote_notif_state_xfree): Don't declare.
6837         * remote-notif.c (remote_notif_process, handle_notification)
6838         (remote_notif_state_allocate): Update.
6839         (~remote_notif_state): Rename from remote_notif_state_xfree.
6840
6841 2019-04-19  Tom Tromey  <tom@tromey.com>
6842
6843         * symfile.c (reread_symbols): Update.
6844         * objfiles.c (objfile_register_static_link)
6845         (objfile_lookup_static_link): Update
6846         (~objfile) Don't delete static_links.
6847         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
6848
6849 2019-04-19  Tom Tromey  <tom@tromey.com>
6850
6851         * type-stack.h (struct type_stack) <insert>: Constify string.
6852         * type-stack.c (type_stack::insert): Constify string.
6853         * gdbtypes.h (lookup_template_type): Update.
6854         (address_space_name_to_int): Update.
6855         * gdbtypes.c (address_space_name_to_int): Make space_identifier
6856         const.
6857         (lookup_template_type): Make name const.
6858         * c-exp.y: Update rules.
6859         (lex_one_token, classify_name, classify_inner_name)
6860         (c_print_token): Update.
6861         * p-exp.y: Update rules.
6862         (yylex): Update.
6863         * f-exp.y: Update rules.
6864         (yylex): Update.
6865         * d-exp.y: Update rules.
6866         (lex_one_token, classify_name, classify_inner_name): Update.
6867         * parse.c (write_dollar_variable, copy_name): Return std::string.
6868         * parser-defs.h (copy_name): Change return type.
6869         * m2-exp.y: Update rules.
6870         (yylex): Update.
6871         * go-exp.y (lex_one_token): Update.
6872         Update rules.
6873         (classify_unsafe_function, classify_packaged_name)
6874         (classify_name, yylex): Update.
6875
6876 2019-04-19  Sergei Trofimovich <siarheit@google.com>
6877
6878         * configure.ac: add --enable-source-highlight switch.
6879         * configure: Regenerate.
6880         * top.c (print_gdb_version): plumb --enable-source-highlight
6881         status to "show configuration".
6882
6883 2019-04-19  Tom Tromey  <tromey@adacore.com>
6884
6885         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
6886         Check ADA_TYPE_P.
6887         (empty_record, ada_template_to_fixed_record_type_1)
6888         (template_to_static_fixed_type)
6889         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
6890         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
6891         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
6892         macros.
6893
6894 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
6895
6896         PR symtab/24423:
6897         * source.c (print_source_lines_base): Advance "iter" when a
6898         control character is seen.
6899
6900 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6901
6902         * inferior.h (struct infcall_suspend_state_deleter):
6903         Catch exception in destructor to avoid crash.
6904
6905 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6906
6907         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
6908         close to the add_com "shell".
6909
6910 2019-04-18  Tom Tromey  <tromey@adacore.com>
6911
6912         * process-stratum-target.h (class process_stratum_target)
6913         <stratum>: Add "final".
6914
6915 2019-04-17  Tom Tromey  <tromey@adacore.com>
6916
6917         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
6918         against nullptr before use.
6919
6920 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
6921
6922         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
6923
6924 2019-04-17  Jim Wilson  <jimw@sifive.com>
6925             Andrew Burgess  <andrew.burgess@embecosm.com>
6926
6927         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
6928         code read might fail, assume 4-byte breakpoint in that case.
6929
6930 2019-04-15  Leszek Swirski  <leszeks@google.com>
6931
6932         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
6933         rather than a hand-rolled POD check when checking for forced MEMORY
6934         classification.
6935
6936 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6937
6938         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
6939         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
6940         function.
6941         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
6942         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
6943         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
6944         declaration.
6945
6946 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6947
6948         * aarch64-linux-nat.c
6949         (aarch64_linux_nat_target::thread_architecture): Add override.
6950         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
6951         each VQ.
6952
6953 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
6954
6955         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
6956
6957 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
6958
6959         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
6960         target types of size 96-bits, add some additional comments, and
6961         check that the builtin type we found was the correct size.
6962
6963 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
6964
6965         * utils.c (prompt_for_continue): Don't restore the styling at the
6966         end, as applied_style has the wrong value.  This fixes styling in
6967         long lists of file names that are interrupted by the "Continue?"
6968         prompt.
6969
6970 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
6971
6972         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
6973         * c-lang.c (c_language_defn): Likewise.
6974         (cplus_language_defn): Likewise.
6975         (asm_language_defn): Likewise.
6976         (minimal_language_defn): Likewise.
6977         * d-lang.c (d_language_defn): Likewise.
6978         * f-lang.c (f_language_defn): Likewise.
6979         * go-lang.c (go_language_defn): Likewise.
6980         * language.c (unknown_language_defn): Likewise.
6981         (auto_language_defn): Likewise.
6982         * language.h (struct language_defn): Remove la_magic field.
6983         (LANG_MAGIC): Delete.
6984         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
6985         * objc-lang.c (objc_language_defn): Likewise.
6986         * opencl-lang.c (opencl_language_defn): Likewise.
6987         * p-lang.c (pascal_language_defn): Likewise.
6988         * rust-lang.c (rust_language_defn): Likewise.
6989
6990 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6991
6992         * riscv-tdep.c (riscv_type_align): New function.
6993         (riscv_type_alignment): Delete.
6994         (riscv_arg_location): Use 'type_align'.
6995         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
6996
6997 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6998
6999         * gdbtypes.c (type_align): A struct with no non-static fields also
7000         has alignment of 1.
7001
7002 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7003
7004         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7005         component to 0.
7006         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7007         member.
7008         (riscv_struct_info::analyse): New implementation using new
7009         analyse_inner member function.
7010         (riscv_struct_info::field_offset): New member function.
7011         (riscv_struct_info::m_offsets): New member variable.
7012         (riscv_struct_info::analyse_inner): New private member function,
7013         takes the old implementation of riscv_struct_info::analyse but
7014         extended to track field offsets.
7015         (riscv_call_arg_struct): Update the struct folding special cases
7016         to handle cases where empty C++ structs, which are non-zero
7017         length, are found.
7018         (riscv_arg_location): Initialise the length of each location, a
7019         non-zero length now indicates the location is in use.
7020         (riscv_push_dummy_call): Allow for the first location having a
7021         non-zero offset when setting up arguments.
7022         (riscv_return_value): Likewise, but for return values.
7023
7024 2019-04-11  Tom Tromey  <tromey@adacore.com>
7025
7026         * utils.c (internal_vproblem): Make "msg" const.
7027
7028 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7029
7030         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7031         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7032         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7033         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7034
7035 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7036
7037         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7038         function.
7039         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7040         of amd64_collect_native_gregset.
7041         (amd64_linux_nat_target::store_registers): Likewise.
7042
7043 2019-04-10  Tom Tromey  <tom@tromey.com>
7044
7045         * symtab.c (lookup_global_symbol_from_objfile)
7046         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7047         * objfiles.h (class separate_debug_iterator): New.
7048         (class separate_debug_range): New.
7049         (struct objfile) <separate_debug_objfiles>: New method.
7050         (objfile_separate_debug_iterate): Don't declare.
7051         * objfiles.c (separate_debug_iterator::operator++): Rename from
7052         objfile_separate_debug_iterate.
7053         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7054         iterator.
7055         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7056         iterator.
7057
7058 2019-04-10  Tom Tromey  <tom@tromey.com>
7059
7060         * symfile.c (reread_symbols): Remove old comment.
7061         * objfiles.c (free_all_objfiles): Fix a typo.
7062
7063 2019-04-10  Tom Tromey  <tom@tromey.com>
7064
7065         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7066         * minsyms.c (lookup_minimal_symbol): Use foreach.
7067         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7068         (lookup_minimal_symbol_solib_trampoline): Likewise.
7069         * symfile.c (reread_symbols): Use foreach.
7070
7071 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7072             Tom Tromey  <tromey@adacore.com>
7073
7074         PR rust/24414:
7075         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7076         (rust_lex_int_test): Change "value" to be LONGEST.
7077         (rust_lex_tests): Add test for long integer literal.
7078
7079 2019-04-09  Tom Tromey  <tromey@adacore.com>
7080
7081         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7082         to bool.
7083         (extended_remote_target::attach): Update.
7084         (remote_target::remote_notice_new_inferior): Update.
7085         (remote_target::add_current_inferior_and_thread): Update.
7086         * inferior.c (exit_inferior_1): Use "false".
7087         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7088
7089 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7090
7091         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7092         the "start" command.
7093
7094 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7095
7096         * python/py-inferior.c (infpy_thread_from_thread_handle):
7097         Adjust comments to reflect renaming of thread_from_thread_handle
7098         to thread_from_handle.  Adjust keywords.  Fix type error message.
7099         (inferior_object_methods): Add thread_from_handle.  Retain
7100         thread_from_thread_handle, but mark it as deprecated.
7101
7102 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7103
7104         * gdbthread.h (find_thread_by_handle): Revise declaration.
7105         * thread.c (find_thread_by_handle): Likewise.  Adjust
7106         implementation too.
7107         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7108         support for buffer objects as handles.
7109
7110 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7111
7112         * python/py-infthread.c (thpy_thread_handle): New function.
7113         (thread_object_methods): Register thpy_thread_handle.
7114
7115 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7116
7117         * gdbthread.h (thread_to_thread_handle): Declare.
7118         * thread.c (gdbtypes.h): Include.
7119         (thread_to_thread_handle): New function.
7120
7121         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7122         (target_thread_info_to_thread_handle): Declare.
7123         * target.c (target_thread_info_to_thread_handle): New function.
7124         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7125         * target-delegates.c: Regenerate.
7126
7127         * linux-thread-db.c (class thread_db_target): Add method
7128         thread_info_to_thread_handle.
7129         (thread_db_target::thread_info_to_thread_handle): Define.
7130         * remote.c (class remote_target): Add new method
7131         thread_info_to_thread_handle.
7132         (remote_target::thread_info_to_thread_handle): Define.
7133
7134 2019-04-08  Pedro Alves  <palves@redhat.com>
7135
7136         * common/common-exceptions.c (throw_exception): Don't create
7137         named object to throw; throw directly.
7138         (throw_it): Likewise.  Don't initialize gdb_exception::message
7139         here, with new; pass FMT and AP to the ctor instead.
7140         * common/common-exceptions.h: Include <string>.
7141         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7142         const char *, va_list)): New ctor.  Use std::make_shared.
7143         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7144         errors)): Delete.
7145         (gdb_exception_error::gdb_exception_error(enum errors, const char
7146         *, va_list)): New.
7147         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7148         Add assertion.
7149         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7150         errors)): Delete.
7151         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7152         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7153         Add assertion.
7154
7155 2019-04-08  Tom Tromey  <tom@tromey.com>
7156
7157         * valops.c (value_rtti_indirect_type): Replace throw_exception
7158         with throw.
7159         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7160         with throw.
7161         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7162         throw.
7163         * target.c (target_translate_tls_address): Replace throw_exception
7164         with throw.
7165         * stack.c (frame_apply_command_count): Replace throw_exception
7166         with throw.
7167         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7168         throw.
7169         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7170         with throw.
7171         * rs6000-tdep.c (rs6000_frame_cache)
7172         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7173         * remote.c: Replace throw_exception with throw.
7174         * record-full.c (record_full_message, record_full_wait_1)
7175         (record_full_restore): Replace throw_exception with throw.
7176         * record-btrace.c:
7177         (get_thread_current_frame_id, record_btrace_start_replaying)
7178         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7179         (cmd_record_btrace_start): Replace throw_exception with throw.
7180         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7181         throw.
7182         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7183         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7184         * linespec.c:
7185         (find_linespec_symbols): Replace throw_exception with throw.
7186         * infrun.c (displaced_step_prepare, resume): Replace
7187         throw_exception with throw.
7188         * infcmd.c (post_create_inferior): Replace throw_exception with
7189         throw.
7190         * inf-loop.c (inferior_event_handler): Replace throw_exception
7191         with throw.
7192         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7193         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7194         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7195         (get_prev_frame_always, get_frame_pc_if_available)
7196         (get_frame_address_in_block_if_available, get_frame_language):
7197         Replace throw_exception with throw.
7198         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7199         throw_exception with throw.
7200         * eval.c (fetch_subexp_value, evaluate_var_value)
7201         (evaluate_funcall, evaluate_subexp_standard): Replace
7202         throw_exception with throw.
7203         * dwarf2loc.c (call_site_find_chain)
7204         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7205         Replace throw_exception with throw.
7206         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7207         with throw.
7208         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7209         throw.
7210         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7211         * completer.c (complete_line_internal): Replace throw_exception
7212         with throw.
7213         * compile/compile-object-run.c (compile_object_run): Replace
7214         throw_exception with throw.
7215         * cli/cli-script.c (process_next_line): Replace throw_exception
7216         with throw.
7217         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7218         (btrace_enable, btrace_maint_update_pt_packets): Replace
7219         throw_exception with throw.
7220         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7221         throw_exception with throw.
7222         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7223         throw_exception with throw.
7224         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7225         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7226         * aarch64-tdep.c (aarch64_make_prologue_cache)
7227         (aarch64_make_stub_cache): Replace throw_exception with throw.
7228
7229 2019-04-08  Tom Tromey  <tom@tromey.com>
7230
7231         * common/common-exceptions.c (throw_exception): Rename from
7232         throw_exception_cxx.  Remove old copy.  Make argument const.
7233         (throw_it): Create and throw exception objects directly.
7234         * common/common-exceptions.h (throw_exception): Make argument
7235         const.
7236         (struct gdb_exception_error): Add constructor.
7237         (struct gdb_exception_quit): Add constructor.
7238
7239 2019-04-08  Tom Tromey  <tom@tromey.com>
7240
7241         * common/common-exceptions.h (exception_rethrow): Don't declare.
7242         (TRY_SJLJ): Update comment.
7243         (TRY, CATCH, END_CATCH): Remove.
7244         * common/common-exceptions.c (exception_rethrow): Remove.
7245
7246 2019-04-08  Tom Tromey  <tom@tromey.com>
7247
7248         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7249         Remove.
7250         (gdb_exception_error): Rename from
7251         gdb_exception_RETURN_MASK_ERROR.
7252         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7253         (gdb_quit_bad_alloc): Update.
7254         * aarch64-tdep.c: Update.
7255         * ada-lang.c: Update.
7256         * ada-typeprint.c: Update.
7257         * ada-valprint.c: Update.
7258         * amd64-tdep.c: Update.
7259         * arch-utils.c: Update.
7260         * break-catch-throw.c: Update.
7261         * breakpoint.c: Update.
7262         * btrace.c: Update.
7263         * c-varobj.c: Update.
7264         * cli/cli-cmds.c: Update.
7265         * cli/cli-interp.c: Update.
7266         * cli/cli-script.c: Update.
7267         * common/common-exceptions.c: Update.
7268         * common/new-op.c: Update.
7269         * common/selftest.c: Update.
7270         * compile/compile-c-symbols.c: Update.
7271         * compile/compile-cplus-symbols.c: Update.
7272         * compile/compile-object-load.c: Update.
7273         * compile/compile-object-run.c: Update.
7274         * completer.c: Update.
7275         * corelow.c: Update.
7276         * cp-abi.c: Update.
7277         * cp-support.c: Update.
7278         * cp-valprint.c: Update.
7279         * darwin-nat.c: Update.
7280         * disasm-selftests.c: Update.
7281         * dtrace-probe.c: Update.
7282         * dwarf-index-cache.c: Update.
7283         * dwarf-index-write.c: Update.
7284         * dwarf2-frame-tailcall.c: Update.
7285         * dwarf2-frame.c: Update.
7286         * dwarf2loc.c: Update.
7287         * dwarf2read.c: Update.
7288         * eval.c: Update.
7289         * event-loop.c: Update.
7290         * event-top.c: Update.
7291         * exec.c: Update.
7292         * f-valprint.c: Update.
7293         * fbsd-tdep.c: Update.
7294         * frame-unwind.c: Update.
7295         * frame.c: Update.
7296         * gdbtypes.c: Update.
7297         * gnu-v3-abi.c: Update.
7298         * guile/guile-internal.h: Update.
7299         * guile/scm-block.c: Update.
7300         * guile/scm-breakpoint.c: Update.
7301         * guile/scm-cmd.c: Update.
7302         * guile/scm-disasm.c: Update.
7303         * guile/scm-frame.c: Update.
7304         * guile/scm-lazy-string.c: Update.
7305         * guile/scm-math.c: Update.
7306         * guile/scm-param.c: Update.
7307         * guile/scm-ports.c: Update.
7308         * guile/scm-pretty-print.c: Update.
7309         * guile/scm-symbol.c: Update.
7310         * guile/scm-symtab.c: Update.
7311         * guile/scm-type.c: Update.
7312         * guile/scm-value.c: Update.
7313         * i386-linux-tdep.c: Update.
7314         * i386-tdep.c: Update.
7315         * inf-loop.c: Update.
7316         * infcall.c: Update.
7317         * infcmd.c: Update.
7318         * infrun.c: Update.
7319         * jit.c: Update.
7320         * language.c: Update.
7321         * linespec.c: Update.
7322         * linux-fork.c: Update.
7323         * linux-nat.c: Update.
7324         * linux-tdep.c: Update.
7325         * linux-thread-db.c: Update.
7326         * main.c: Update.
7327         * mi/mi-cmd-break.c: Update.
7328         * mi/mi-cmd-stack.c: Update.
7329         * mi/mi-interp.c: Update.
7330         * mi/mi-main.c: Update.
7331         * objc-lang.c: Update.
7332         * p-valprint.c: Update.
7333         * parse.c: Update.
7334         * ppc-linux-tdep.c: Update.
7335         * printcmd.c: Update.
7336         * python/py-arch.c: Update.
7337         * python/py-breakpoint.c: Update.
7338         * python/py-cmd.c: Update.
7339         * python/py-finishbreakpoint.c: Update.
7340         * python/py-frame.c: Update.
7341         * python/py-framefilter.c: Update.
7342         * python/py-gdb-readline.c: Update.
7343         * python/py-inferior.c: Update.
7344         * python/py-infthread.c: Update.
7345         * python/py-lazy-string.c: Update.
7346         * python/py-linetable.c: Update.
7347         * python/py-objfile.c: Update.
7348         * python/py-param.c: Update.
7349         * python/py-prettyprint.c: Update.
7350         * python/py-progspace.c: Update.
7351         * python/py-record-btrace.c: Update.
7352         * python/py-record.c: Update.
7353         * python/py-symbol.c: Update.
7354         * python/py-type.c: Update.
7355         * python/py-unwind.c: Update.
7356         * python/py-utils.c: Update.
7357         * python/py-value.c: Update.
7358         * python/python.c: Update.
7359         * record-btrace.c: Update.
7360         * record-full.c: Update.
7361         * remote-fileio.c: Update.
7362         * remote.c: Update.
7363         * riscv-tdep.c: Update.
7364         * rs6000-aix-tdep.c: Update.
7365         * rs6000-tdep.c: Update.
7366         * rust-exp.y: Update.
7367         * rust-lang.c: Update.
7368         * s390-tdep.c: Update.
7369         * selftest-arch.c: Update.
7370         * solib-dsbt.c: Update.
7371         * solib-frv.c: Update.
7372         * solib-spu.c: Update.
7373         * solib-svr4.c: Update.
7374         * solib.c: Update.
7375         * sparc64-linux-tdep.c: Update.
7376         * stack.c: Update.
7377         * symfile-mem.c: Update.
7378         * symmisc.c: Update.
7379         * target.c: Update.
7380         * thread.c: Update.
7381         * top.c: Update.
7382         * tracefile-tfile.c: Update.
7383         * tui/tui.c: Update.
7384         * typeprint.c: Update.
7385         * unittests/cli-utils-selftests.c: Update.
7386         * unittests/parse-connection-spec-selftests.c: Update.
7387         * valops.c: Update.
7388         * valprint.c: Update.
7389         * value.c: Update.
7390         * varobj.c: Update.
7391         * windows-nat.c: Update.
7392         * x86-linux-nat.c: Update.
7393         * xml-support.c: Update.
7394
7395 2019-04-08  Tom Tromey  <tom@tromey.com>
7396
7397         * xml-support.c: Use C++ exception handling.
7398         * x86-linux-nat.c: Use C++ exception handling.
7399         * windows-nat.c: Use C++ exception handling.
7400         * varobj.c: Use C++ exception handling.
7401         * value.c: Use C++ exception handling.
7402         * valprint.c: Use C++ exception handling.
7403         * valops.c: Use C++ exception handling.
7404         * unittests/parse-connection-spec-selftests.c: Use C++ exception
7405         handling.
7406         * unittests/cli-utils-selftests.c: Use C++ exception handling.
7407         * typeprint.c: Use C++ exception handling.
7408         * tui/tui.c: Use C++ exception handling.
7409         * tracefile-tfile.c: Use C++ exception handling.
7410         * top.c: Use C++ exception handling.
7411         * thread.c: Use C++ exception handling.
7412         * target.c: Use C++ exception handling.
7413         * symmisc.c: Use C++ exception handling.
7414         * symfile-mem.c: Use C++ exception handling.
7415         * stack.c: Use C++ exception handling.
7416         * sparc64-linux-tdep.c: Use C++ exception handling.
7417         * solib.c: Use C++ exception handling.
7418         * solib-svr4.c: Use C++ exception handling.
7419         * solib-spu.c: Use C++ exception handling.
7420         * solib-frv.c: Use C++ exception handling.
7421         * solib-dsbt.c: Use C++ exception handling.
7422         * selftest-arch.c: Use C++ exception handling.
7423         * s390-tdep.c: Use C++ exception handling.
7424         * rust-lang.c: Use C++ exception handling.
7425         * rust-exp.y: Use C++ exception handling.
7426         * rs6000-tdep.c: Use C++ exception handling.
7427         * rs6000-aix-tdep.c: Use C++ exception handling.
7428         * riscv-tdep.c: Use C++ exception handling.
7429         * remote.c: Use C++ exception handling.
7430         * remote-fileio.c: Use C++ exception handling.
7431         * record-full.c: Use C++ exception handling.
7432         * record-btrace.c: Use C++ exception handling.
7433         * python/python.c: Use C++ exception handling.
7434         * python/py-value.c: Use C++ exception handling.
7435         * python/py-utils.c: Use C++ exception handling.
7436         * python/py-unwind.c: Use C++ exception handling.
7437         * python/py-type.c: Use C++ exception handling.
7438         * python/py-symbol.c: Use C++ exception handling.
7439         * python/py-record.c: Use C++ exception handling.
7440         * python/py-record-btrace.c: Use C++ exception handling.
7441         * python/py-progspace.c: Use C++ exception handling.
7442         * python/py-prettyprint.c: Use C++ exception handling.
7443         * python/py-param.c: Use C++ exception handling.
7444         * python/py-objfile.c: Use C++ exception handling.
7445         * python/py-linetable.c: Use C++ exception handling.
7446         * python/py-lazy-string.c: Use C++ exception handling.
7447         * python/py-infthread.c: Use C++ exception handling.
7448         * python/py-inferior.c: Use C++ exception handling.
7449         * python/py-gdb-readline.c: Use C++ exception handling.
7450         * python/py-framefilter.c: Use C++ exception handling.
7451         * python/py-frame.c: Use C++ exception handling.
7452         * python/py-finishbreakpoint.c: Use C++ exception handling.
7453         * python/py-cmd.c: Use C++ exception handling.
7454         * python/py-breakpoint.c: Use C++ exception handling.
7455         * python/py-arch.c: Use C++ exception handling.
7456         * printcmd.c: Use C++ exception handling.
7457         * ppc-linux-tdep.c: Use C++ exception handling.
7458         * parse.c: Use C++ exception handling.
7459         * p-valprint.c: Use C++ exception handling.
7460         * objc-lang.c: Use C++ exception handling.
7461         * mi/mi-main.c: Use C++ exception handling.
7462         * mi/mi-interp.c: Use C++ exception handling.
7463         * mi/mi-cmd-stack.c: Use C++ exception handling.
7464         * mi/mi-cmd-break.c: Use C++ exception handling.
7465         * main.c: Use C++ exception handling.
7466         * linux-thread-db.c: Use C++ exception handling.
7467         * linux-tdep.c: Use C++ exception handling.
7468         * linux-nat.c: Use C++ exception handling.
7469         * linux-fork.c: Use C++ exception handling.
7470         * linespec.c: Use C++ exception handling.
7471         * language.c: Use C++ exception handling.
7472         * jit.c: Use C++ exception handling.
7473         * infrun.c: Use C++ exception handling.
7474         * infcmd.c: Use C++ exception handling.
7475         * infcall.c: Use C++ exception handling.
7476         * inf-loop.c: Use C++ exception handling.
7477         * i386-tdep.c: Use C++ exception handling.
7478         * i386-linux-tdep.c: Use C++ exception handling.
7479         * guile/scm-value.c: Use C++ exception handling.
7480         * guile/scm-type.c: Use C++ exception handling.
7481         * guile/scm-symtab.c: Use C++ exception handling.
7482         * guile/scm-symbol.c: Use C++ exception handling.
7483         * guile/scm-pretty-print.c: Use C++ exception handling.
7484         * guile/scm-ports.c: Use C++ exception handling.
7485         * guile/scm-param.c: Use C++ exception handling.
7486         * guile/scm-math.c: Use C++ exception handling.
7487         * guile/scm-lazy-string.c: Use C++ exception handling.
7488         * guile/scm-frame.c: Use C++ exception handling.
7489         * guile/scm-disasm.c: Use C++ exception handling.
7490         * guile/scm-cmd.c: Use C++ exception handling.
7491         * guile/scm-breakpoint.c: Use C++ exception handling.
7492         * guile/scm-block.c: Use C++ exception handling.
7493         * guile/guile-internal.h: Use C++ exception handling.
7494         * gnu-v3-abi.c: Use C++ exception handling.
7495         * gdbtypes.c: Use C++ exception handling.
7496         * frame.c: Use C++ exception handling.
7497         * frame-unwind.c: Use C++ exception handling.
7498         * fbsd-tdep.c: Use C++ exception handling.
7499         * f-valprint.c: Use C++ exception handling.
7500         * exec.c: Use C++ exception handling.
7501         * event-top.c: Use C++ exception handling.
7502         * event-loop.c: Use C++ exception handling.
7503         * eval.c: Use C++ exception handling.
7504         * dwarf2read.c: Use C++ exception handling.
7505         * dwarf2loc.c: Use C++ exception handling.
7506         * dwarf2-frame.c: Use C++ exception handling.
7507         * dwarf2-frame-tailcall.c: Use C++ exception handling.
7508         * dwarf-index-write.c: Use C++ exception handling.
7509         * dwarf-index-cache.c: Use C++ exception handling.
7510         * dtrace-probe.c: Use C++ exception handling.
7511         * disasm-selftests.c: Use C++ exception handling.
7512         * darwin-nat.c: Use C++ exception handling.
7513         * cp-valprint.c: Use C++ exception handling.
7514         * cp-support.c: Use C++ exception handling.
7515         * cp-abi.c: Use C++ exception handling.
7516         * corelow.c: Use C++ exception handling.
7517         * completer.c: Use C++ exception handling.
7518         * compile/compile-object-run.c: Use C++ exception handling.
7519         * compile/compile-object-load.c: Use C++ exception handling.
7520         * compile/compile-cplus-symbols.c: Use C++ exception handling.
7521         * compile/compile-c-symbols.c: Use C++ exception handling.
7522         * common/selftest.c: Use C++ exception handling.
7523         * common/new-op.c: Use C++ exception handling.
7524         * cli/cli-script.c: Use C++ exception handling.
7525         * cli/cli-interp.c: Use C++ exception handling.
7526         * cli/cli-cmds.c: Use C++ exception handling.
7527         * c-varobj.c: Use C++ exception handling.
7528         * btrace.c: Use C++ exception handling.
7529         * breakpoint.c: Use C++ exception handling.
7530         * break-catch-throw.c: Use C++ exception handling.
7531         * arch-utils.c: Use C++ exception handling.
7532         * amd64-tdep.c: Use C++ exception handling.
7533         * ada-valprint.c: Use C++ exception handling.
7534         * ada-typeprint.c: Use C++ exception handling.
7535         * ada-lang.c: Use C++ exception handling.
7536         * aarch64-tdep.c: Use C++ exception handling.
7537
7538 2019-04-08  Tom Tromey  <tom@tromey.com>
7539
7540         * xml-support.c (gdb_xml_parser::parse): Update.
7541         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
7542         * value.c (show_convenience): Update.
7543         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
7544         (test_parse_flags_qcs): Update.
7545         * thread.c (thr_try_catch_cmd): Update.
7546         * target.c (target_translate_tls_address): Update.
7547         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
7548         (info_frame_command_core, frame_apply_command_count): Update.
7549         * rust-exp.y (rust_lex_exception_test): Update.
7550         * riscv-tdep.c (riscv_print_one_register_info): Update.
7551         * remote.c (remote_target::enable_btrace): Update.
7552         * record-btrace.c (record_btrace_enable_warn): Update.
7553         * python/py-utils.c (gdbpy_convert_exception): Update.
7554         * printcmd.c (do_one_display, print_variable_and_value): Update.
7555         * mi/mi-main.c (mi_print_exception): Update.
7556         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
7557         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
7558         * linux-nat.c (linux_nat_target::attach): Update.
7559         * linux-fork.c (class scoped_switch_fork_info): Update.
7560         * infrun.c (displaced_step_prepare): Update.
7561         * infcall.c (call_function_by_hand_dummy): Update.
7562         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
7563         * gnu-v3-abi.c (print_one_vtable): Update.
7564         * frame.c (get_prev_frame_always): Update.
7565         * f-valprint.c (info_common_command_for_block): Update.
7566         * exec.c (try_open_exec_file): Update.
7567         * exceptions.c (print_exception, exception_print)
7568         (exception_fprintf, exception_print_same): Update.
7569         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
7570         * dwarf-index-cache.c (index_cache::store)
7571         (index_cache::lookup_gdb_index): Update.
7572         * darwin-nat.c (maybe_cache_shell): Update.
7573         * cp-valprint.c (cp_print_value_fields): Update.
7574         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
7575         (gcc_cplus_symbol_address): Update.
7576         * compile/compile-c-symbols.c (gcc_convert_symbol)
7577         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
7578         * common/selftest.c: Update.
7579         * common/common-exceptions.h (struct gdb_exception) <message>: Now
7580         a std::string.
7581         (exception_try_scope_entry, exception_try_scope_exit): Don't
7582         declare.
7583         (struct exception_try_scope): Remove.
7584         (TRY): Don't use exception_try_scope.
7585         (struct gdb_exception): Add constructor, operator=.
7586         <what>: New method.
7587         (struct gdb_exception_RETURN_MASK_ALL)
7588         (struct gdb_exception_RETURN_MASK_ERROR)
7589         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
7590         (struct gdb_quit_bad_alloc): Update.
7591         * common/common-exceptions.c (exception_none): Change
7592         initializer.
7593         (struct catcher) <state, exception>: Initialize inline.
7594         <prev>: Remove member.
7595         (current_catcher): Remove.
7596         (catchers): New global.
7597         (exceptions_state_mc_init): Simplify.
7598         (catcher_pop): Remove.
7599         (exceptions_state_mc, exceptions_state_mc_catch): Update.
7600         (try_scope_depth, exception_try_scope_entry)
7601         (exception_try_scope_exit): Remove.
7602         (throw_exception_sjlj): Update.
7603         (exception_messages, exception_messages_size): Remove.
7604         (throw_it): Simplify.
7605         (gdb_exception_sliced_copy): Remove.
7606         (throw_exception_cxx): Update.
7607         * cli/cli-script.c (script_from_file): Update.
7608         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
7609         Update.
7610         * ada-valprint.c (ada_val_print): Update.
7611         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
7612         (create_excep_cond_exprs): Update.
7613
7614 2019-04-08  Tom Tromey  <tom@tromey.com>
7615
7616         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
7617         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
7618         (TRY, CATCH, END_CATCH): Remove some definitions.
7619         * common/common-exceptions.c: Don't use GDB_XCPT.
7620         (catcher_list_size): Remove.
7621         (throw_exception, throw_it): Simplify.
7622
7623 2019-04-05  Tom Tromey  <tom@tromey.com>
7624
7625         Revert the header-sorting patch.
7626         * ft32-tdep.c: Revert.
7627         * frv-tdep.c: Revert.
7628         * frv-linux-tdep.c: Revert.
7629         * frame.c: Revert.
7630         * frame-unwind.c: Revert.
7631         * frame-base.c: Revert.
7632         * fork-child.c: Revert.
7633         * findvar.c: Revert.
7634         * findcmd.c: Revert.
7635         * filesystem.c: Revert.
7636         * filename-seen-cache.h: Revert.
7637         * filename-seen-cache.c: Revert.
7638         * fbsd-tdep.c: Revert.
7639         * fbsd-nat.h: Revert.
7640         * fbsd-nat.c: Revert.
7641         * f-valprint.c: Revert.
7642         * f-typeprint.c: Revert.
7643         * f-lang.c: Revert.
7644         * extension.h: Revert.
7645         * extension.c: Revert.
7646         * extension-priv.h: Revert.
7647         * expprint.c: Revert.
7648         * exec.h: Revert.
7649         * exec.c: Revert.
7650         * exceptions.c: Revert.
7651         * event-top.c: Revert.
7652         * event-loop.c: Revert.
7653         * eval.c: Revert.
7654         * elfread.c: Revert.
7655         * dwarf2read.h: Revert.
7656         * dwarf2read.c: Revert.
7657         * dwarf2loc.c: Revert.
7658         * dwarf2expr.h: Revert.
7659         * dwarf2expr.c: Revert.
7660         * dwarf2-frame.c: Revert.
7661         * dwarf2-frame-tailcall.c: Revert.
7662         * dwarf-index-write.h: Revert.
7663         * dwarf-index-write.c: Revert.
7664         * dwarf-index-common.c: Revert.
7665         * dwarf-index-cache.h: Revert.
7666         * dwarf-index-cache.c: Revert.
7667         * dummy-frame.c: Revert.
7668         * dtrace-probe.c: Revert.
7669         * disasm.h: Revert.
7670         * disasm.c: Revert.
7671         * disasm-selftests.c: Revert.
7672         * dictionary.c: Revert.
7673         * dicos-tdep.c: Revert.
7674         * demangle.c: Revert.
7675         * dcache.h: Revert.
7676         * dcache.c: Revert.
7677         * darwin-nat.h: Revert.
7678         * darwin-nat.c: Revert.
7679         * darwin-nat-info.c: Revert.
7680         * d-valprint.c: Revert.
7681         * d-namespace.c: Revert.
7682         * d-lang.c: Revert.
7683         * ctf.c: Revert.
7684         * csky-tdep.c: Revert.
7685         * csky-linux-tdep.c: Revert.
7686         * cris-tdep.c: Revert.
7687         * cris-linux-tdep.c: Revert.
7688         * cp-valprint.c: Revert.
7689         * cp-support.c: Revert.
7690         * cp-namespace.c: Revert.
7691         * cp-abi.c: Revert.
7692         * corelow.c: Revert.
7693         * corefile.c: Revert.
7694         * continuations.c: Revert.
7695         * completer.h: Revert.
7696         * completer.c: Revert.
7697         * complaints.c: Revert.
7698         * coffread.c: Revert.
7699         * coff-pe-read.c: Revert.
7700         * cli-out.h: Revert.
7701         * cli-out.c: Revert.
7702         * charset.c: Revert.
7703         * c-varobj.c: Revert.
7704         * c-valprint.c: Revert.
7705         * c-typeprint.c: Revert.
7706         * c-lang.c: Revert.
7707         * buildsym.c: Revert.
7708         * buildsym-legacy.c: Revert.
7709         * build-id.h: Revert.
7710         * build-id.c: Revert.
7711         * btrace.c: Revert.
7712         * bsd-uthread.c: Revert.
7713         * breakpoint.h: Revert.
7714         * breakpoint.c: Revert.
7715         * break-catch-throw.c: Revert.
7716         * break-catch-syscall.c: Revert.
7717         * break-catch-sig.c: Revert.
7718         * blockframe.c: Revert.
7719         * block.c: Revert.
7720         * bfin-tdep.c: Revert.
7721         * bfin-linux-tdep.c: Revert.
7722         * bfd-target.c: Revert.
7723         * bcache.c: Revert.
7724         * ax-general.c: Revert.
7725         * ax-gdb.h: Revert.
7726         * ax-gdb.c: Revert.
7727         * avr-tdep.c: Revert.
7728         * auxv.c: Revert.
7729         * auto-load.c: Revert.
7730         * arm-wince-tdep.c: Revert.
7731         * arm-tdep.c: Revert.
7732         * arm-symbian-tdep.c: Revert.
7733         * arm-pikeos-tdep.c: Revert.
7734         * arm-obsd-tdep.c: Revert.
7735         * arm-nbsd-tdep.c: Revert.
7736         * arm-nbsd-nat.c: Revert.
7737         * arm-linux-tdep.c: Revert.
7738         * arm-linux-nat.c: Revert.
7739         * arm-fbsd-tdep.c: Revert.
7740         * arm-fbsd-nat.c: Revert.
7741         * arm-bsd-tdep.c: Revert.
7742         * arch-utils.c: Revert.
7743         * arc-tdep.c: Revert.
7744         * arc-newlib-tdep.c: Revert.
7745         * annotate.h: Revert.
7746         * annotate.c: Revert.
7747         * amd64-windows-tdep.c: Revert.
7748         * amd64-windows-nat.c: Revert.
7749         * amd64-tdep.c: Revert.
7750         * amd64-sol2-tdep.c: Revert.
7751         * amd64-obsd-tdep.c: Revert.
7752         * amd64-obsd-nat.c: Revert.
7753         * amd64-nbsd-tdep.c: Revert.
7754         * amd64-nbsd-nat.c: Revert.
7755         * amd64-nat.c: Revert.
7756         * amd64-linux-tdep.c: Revert.
7757         * amd64-linux-nat.c: Revert.
7758         * amd64-fbsd-tdep.c: Revert.
7759         * amd64-fbsd-nat.c: Revert.
7760         * amd64-dicos-tdep.c: Revert.
7761         * amd64-darwin-tdep.c: Revert.
7762         * amd64-bsd-nat.c: Revert.
7763         * alpha-tdep.c: Revert.
7764         * alpha-obsd-tdep.c: Revert.
7765         * alpha-nbsd-tdep.c: Revert.
7766         * alpha-mdebug-tdep.c: Revert.
7767         * alpha-linux-tdep.c: Revert.
7768         * alpha-linux-nat.c: Revert.
7769         * alpha-bsd-tdep.c: Revert.
7770         * alpha-bsd-nat.c: Revert.
7771         * aix-thread.c: Revert.
7772         * agent.c: Revert.
7773         * addrmap.c: Revert.
7774         * ada-varobj.c: Revert.
7775         * ada-valprint.c: Revert.
7776         * ada-typeprint.c: Revert.
7777         * ada-tasks.c: Revert.
7778         * ada-lang.c: Revert.
7779         * aarch64-tdep.c: Revert.
7780         * aarch64-ravenscar-thread.c: Revert.
7781         * aarch64-newlib-tdep.c: Revert.
7782         * aarch64-linux-tdep.c: Revert.
7783         * aarch64-linux-nat.c: Revert.
7784         * aarch64-fbsd-tdep.c: Revert.
7785         * aarch64-fbsd-nat.c: Revert.
7786         * aarch32-linux-nat.c: Revert.
7787
7788 2019-04-05  Tom Tromey  <tom@tromey.com>
7789
7790         * ft32-tdep.c: Sort headers.
7791         * frv-tdep.c: Sort headers.
7792         * frv-linux-tdep.c: Sort headers.
7793         * frame.c: Sort headers.
7794         * frame-unwind.c: Sort headers.
7795         * frame-base.c: Sort headers.
7796         * fork-child.c: Sort headers.
7797         * findvar.c: Sort headers.
7798         * findcmd.c: Sort headers.
7799         * filesystem.c: Sort headers.
7800         * filename-seen-cache.h: Sort headers.
7801         * filename-seen-cache.c: Sort headers.
7802         * fbsd-tdep.c: Sort headers.
7803         * fbsd-nat.h: Sort headers.
7804         * fbsd-nat.c: Sort headers.
7805         * f-valprint.c: Sort headers.
7806         * f-typeprint.c: Sort headers.
7807         * f-lang.c: Sort headers.
7808         * extension.h: Sort headers.
7809         * extension.c: Sort headers.
7810         * extension-priv.h: Sort headers.
7811         * expprint.c: Sort headers.
7812         * exec.h: Sort headers.
7813         * exec.c: Sort headers.
7814         * exceptions.c: Sort headers.
7815         * event-top.c: Sort headers.
7816         * event-loop.c: Sort headers.
7817         * eval.c: Sort headers.
7818         * elfread.c: Sort headers.
7819         * dwarf2read.h: Sort headers.
7820         * dwarf2read.c: Sort headers.
7821         * dwarf2loc.c: Sort headers.
7822         * dwarf2expr.h: Sort headers.
7823         * dwarf2expr.c: Sort headers.
7824         * dwarf2-frame.c: Sort headers.
7825         * dwarf2-frame-tailcall.c: Sort headers.
7826         * dwarf-index-write.h: Sort headers.
7827         * dwarf-index-write.c: Sort headers.
7828         * dwarf-index-common.c: Sort headers.
7829         * dwarf-index-cache.h: Sort headers.
7830         * dwarf-index-cache.c: Sort headers.
7831         * dummy-frame.c: Sort headers.
7832         * dtrace-probe.c: Sort headers.
7833         * disasm.h: Sort headers.
7834         * disasm.c: Sort headers.
7835         * disasm-selftests.c: Sort headers.
7836         * dictionary.c: Sort headers.
7837         * dicos-tdep.c: Sort headers.
7838         * demangle.c: Sort headers.
7839         * dcache.h: Sort headers.
7840         * dcache.c: Sort headers.
7841         * darwin-nat.h: Sort headers.
7842         * darwin-nat.c: Sort headers.
7843         * darwin-nat-info.c: Sort headers.
7844         * d-valprint.c: Sort headers.
7845         * d-namespace.c: Sort headers.
7846         * d-lang.c: Sort headers.
7847         * ctf.c: Sort headers.
7848         * csky-tdep.c: Sort headers.
7849         * csky-linux-tdep.c: Sort headers.
7850         * cris-tdep.c: Sort headers.
7851         * cris-linux-tdep.c: Sort headers.
7852         * cp-valprint.c: Sort headers.
7853         * cp-support.c: Sort headers.
7854         * cp-namespace.c: Sort headers.
7855         * cp-abi.c: Sort headers.
7856         * corelow.c: Sort headers.
7857         * corefile.c: Sort headers.
7858         * continuations.c: Sort headers.
7859         * completer.h: Sort headers.
7860         * completer.c: Sort headers.
7861         * complaints.c: Sort headers.
7862         * coffread.c: Sort headers.
7863         * coff-pe-read.c: Sort headers.
7864         * cli-out.h: Sort headers.
7865         * cli-out.c: Sort headers.
7866         * charset.c: Sort headers.
7867         * c-varobj.c: Sort headers.
7868         * c-valprint.c: Sort headers.
7869         * c-typeprint.c: Sort headers.
7870         * c-lang.c: Sort headers.
7871         * buildsym.c: Sort headers.
7872         * buildsym-legacy.c: Sort headers.
7873         * build-id.h: Sort headers.
7874         * build-id.c: Sort headers.
7875         * btrace.c: Sort headers.
7876         * bsd-uthread.c: Sort headers.
7877         * breakpoint.h: Sort headers.
7878         * breakpoint.c: Sort headers.
7879         * break-catch-throw.c: Sort headers.
7880         * break-catch-syscall.c: Sort headers.
7881         * break-catch-sig.c: Sort headers.
7882         * blockframe.c: Sort headers.
7883         * block.c: Sort headers.
7884         * bfin-tdep.c: Sort headers.
7885         * bfin-linux-tdep.c: Sort headers.
7886         * bfd-target.c: Sort headers.
7887         * bcache.c: Sort headers.
7888         * ax-general.c: Sort headers.
7889         * ax-gdb.h: Sort headers.
7890         * ax-gdb.c: Sort headers.
7891         * avr-tdep.c: Sort headers.
7892         * auxv.c: Sort headers.
7893         * auto-load.c: Sort headers.
7894         * arm-wince-tdep.c: Sort headers.
7895         * arm-tdep.c: Sort headers.
7896         * arm-symbian-tdep.c: Sort headers.
7897         * arm-pikeos-tdep.c: Sort headers.
7898         * arm-obsd-tdep.c: Sort headers.
7899         * arm-nbsd-tdep.c: Sort headers.
7900         * arm-nbsd-nat.c: Sort headers.
7901         * arm-linux-tdep.c: Sort headers.
7902         * arm-linux-nat.c: Sort headers.
7903         * arm-fbsd-tdep.c: Sort headers.
7904         * arm-fbsd-nat.c: Sort headers.
7905         * arm-bsd-tdep.c: Sort headers.
7906         * arch-utils.c: Sort headers.
7907         * arc-tdep.c: Sort headers.
7908         * arc-newlib-tdep.c: Sort headers.
7909         * annotate.h: Sort headers.
7910         * annotate.c: Sort headers.
7911         * amd64-windows-tdep.c: Sort headers.
7912         * amd64-windows-nat.c: Sort headers.
7913         * amd64-tdep.c: Sort headers.
7914         * amd64-sol2-tdep.c: Sort headers.
7915         * amd64-obsd-tdep.c: Sort headers.
7916         * amd64-obsd-nat.c: Sort headers.
7917         * amd64-nbsd-tdep.c: Sort headers.
7918         * amd64-nbsd-nat.c: Sort headers.
7919         * amd64-nat.c: Sort headers.
7920         * amd64-linux-tdep.c: Sort headers.
7921         * amd64-linux-nat.c: Sort headers.
7922         * amd64-fbsd-tdep.c: Sort headers.
7923         * amd64-fbsd-nat.c: Sort headers.
7924         * amd64-dicos-tdep.c: Sort headers.
7925         * amd64-darwin-tdep.c: Sort headers.
7926         * amd64-bsd-nat.c: Sort headers.
7927         * alpha-tdep.c: Sort headers.
7928         * alpha-obsd-tdep.c: Sort headers.
7929         * alpha-nbsd-tdep.c: Sort headers.
7930         * alpha-mdebug-tdep.c: Sort headers.
7931         * alpha-linux-tdep.c: Sort headers.
7932         * alpha-linux-nat.c: Sort headers.
7933         * alpha-bsd-tdep.c: Sort headers.
7934         * alpha-bsd-nat.c: Sort headers.
7935         * aix-thread.c: Sort headers.
7936         * agent.c: Sort headers.
7937         * addrmap.c: Sort headers.
7938         * ada-varobj.c: Sort headers.
7939         * ada-valprint.c: Sort headers.
7940         * ada-typeprint.c: Sort headers.
7941         * ada-tasks.c: Sort headers.
7942         * ada-lang.c: Sort headers.
7943         * aarch64-tdep.c: Sort headers.
7944         * aarch64-ravenscar-thread.c: Sort headers.
7945         * aarch64-newlib-tdep.c: Sort headers.
7946         * aarch64-linux-tdep.c: Sort headers.
7947         * aarch64-linux-nat.c: Sort headers.
7948         * aarch64-fbsd-tdep.c: Sort headers.
7949         * aarch64-fbsd-nat.c: Sort headers.
7950         * aarch32-linux-nat.c: Sort headers.
7951
7952 2019-04-04  Tom Tromey  <tom@tromey.com>
7953
7954         * varobj.c (varobj_create): Update.
7955         * rust-exp.y (struct rust_parser) <update_innermost_block,
7956         lookup_symbol>: New methods.
7957         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
7958         Rename.
7959         (rust_parser::rust_lookup_type)
7960         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
7961         * printcmd.c (display_command, do_one_display): Update.
7962         * parser-defs.h (struct parser_state) <parser_state>: Add
7963         "tracker" parameter.
7964         (block_tracker): New member.
7965         (class innermost_block_tracker) <innermost_block_tracker>: Add
7966         "types" parameter.
7967         <reset>: Remove method.
7968         (innermost_block): Don't declare.
7969         (null_post_parser): Update.
7970         * parse.c (innermost_block): Remove global.
7971         (write_dollar_variable): Update.
7972         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
7973         Remove "tracker_types" parameter.
7974         (parse_expression): Add "tracker" parameter.
7975         (parse_expression_for_completion): Update.
7976         (null_post_parser): Add "tracker" parameter.
7977         * p-exp.y: Update rules.
7978         * m2-exp.y: Update rules.
7979         * language.h (struct language_defn) <la_post_parser>: Add
7980         "tracker" parameter.
7981         * go-exp.y: Update rules.
7982         * f-exp.y: Update rules.
7983         * expression.h (parse_expression, parse_exp_1): Add "tracker"
7984         parameter.
7985         * d-exp.y: Update rules.
7986         * c-exp.y: Update rules.
7987         * breakpoint.c (set_breakpoint_condition): Create an
7988         innermost_block_tracker.
7989         (watch_command_1): Likewise.
7990         * ada-lang.c (resolve): Add "tracker" parameter.
7991         (resolve_subexp): Likewise.
7992         * ada-exp.y (write_var_from_sym): Update.
7993
7994 2019-04-04  Tom Tromey  <tom@tromey.com>
7995
7996         * type-stack.h: New file.
7997         * type-stack.c: New file.
7998         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
7999         type-stack.h.
8000         (insert_into_type_stack, insert_type, push_type, push_type_int)
8001         (insert_type_address_space, pop_type, pop_type_int)
8002         (pop_typelist, pop_type_stack, append_type_stack)
8003         (push_type_stack, get_type_stack, push_typelist)
8004         (follow_type_instance_flags, follow_types): Don't declare.
8005         * parse.c (type_stack): Remove global.
8006         (parse_exp_in_context): Update.
8007         (insert_into_type_stack, insert_type, push_type, push_type_int)
8008         (insert_type_address_space, pop_type, pop_type_int)
8009         (pop_typelist, pop_type_stack, append_type_stack)
8010         (push_type_stack, get_type_stack, push_typelist)
8011         (follow_type_instance_flags, follow_types): Remove (moved to
8012         type-stack.c).
8013         * f-exp.y (type_stack): New global.
8014         Update rules.
8015         (push_kind_type, f_parse): Update.
8016         * d-exp.y (type_stack): New global.
8017         Update rules.
8018         (d_parse): Update.
8019         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8020         Update rules.
8021         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8022         (HFILES_NO_SRCDIR): Add type-stack.h.
8023
8024 2019-04-04  Tom Tromey  <tom@tromey.com>
8025
8026         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8027         (rust_parser::convert_ast_to_expression, rust_parse)
8028         (rust_lex_test_completion, rust_lex_tests): Update.
8029         * parser-defs.h (struct expr_completion_state): New.
8030         (struct parser_state) <parser_state>: Add completion parameter.
8031         <mark_struct_expression, mark_completion_tag>: New methods.
8032         <parse_completion, m_completion_state>: New members.
8033         (prefixify_expression, null_post_parser): Update.
8034         (mark_struct_expression, mark_completion_tag): Don't declare.
8035         * parse.c (parse_completion, expout_last_struct)
8036         (expout_tag_completion_type, expout_completion_name): Remove
8037         globals.
8038         (parser_state::mark_struct_expression)
8039         (parser_state::mark_completion_tag): Now methods.
8040         (prefixify_expression): Add last_struct parameter.
8041         (prefixify_subexp): Likewise.
8042         (parse_exp_1): Update.
8043         (parse_exp_in_context): Add cstate parameter.  Update.
8044         (parse_expression_for_completion): Create an
8045         expr_completion_state.
8046         (null_post_parser): Add "completion" parameter.
8047         * p-exp.y: Update rules.
8048         (yylex): Update.
8049         * language.h (struct language_defn) <la_post_parser>: Add
8050         "completing" parameter.
8051         * go-exp.y: Update rules.
8052         (lex_one_token): Update.
8053         * expression.h (parse_completion): Don't declare.
8054         * d-exp.y: Update rules.
8055         (lex_one_token): Update rules.
8056         * c-exp.y: Update rules.
8057         (lex_one_token): Update.
8058         * ada-lang.c (resolve): Add "parse_completion" parameter.
8059         (resolve_subexp): Likewise.
8060         (ada_resolve_function): Likewise.
8061
8062 2019-04-04  Tom Tromey  <tom@tromey.com>
8063
8064         * parser-defs.h (struct parser_state) <start_arglist,
8065         end_arglist>: New methods.
8066         <arglist_len, m_funcall_chain>: New members.
8067         (arglist_len, start_arglist, end_arglist): Don't declare.
8068         * parse.c (arglist_len, funcall_chain): Remove global.
8069         (start_arglist, end_arglist): Remove functions.
8070         (parse_exp_in_context): Update.
8071         * p-exp.y: Update rules.
8072         * m2-exp.y: Update rules.
8073         * go-exp.y: Update rules.
8074         * f-exp.y: Update rules.
8075         * d-exp.y: Update rules.
8076         * c-exp.y: Update rules.
8077
8078 2019-04-04  Tom Tromey  <tom@tromey.com>
8079
8080         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8081         lex_operator, push_back>: New methods.
8082         Update all rules.
8083         (rust_parser::lex_hex, lex_escape): Rename and update.
8084         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8085         (rust_parser::lex_operator): Rename and update.
8086         (rust_parser::lex_number, rustyylex, rustyyerror)
8087         (rust_lex_test_init, rust_lex_test_sequence)
8088         (rust_lex_test_push_back, rust_lex_tests): Update.
8089         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8090         parameter.
8091         <lexptr, prev_lexptr>: New members.
8092         (lexptr, prev_lexptr): Don't declare.
8093         * parse.c (lexptr, prev_lexptr): Remove globals.
8094         (parse_exp_in_context): Update.
8095         * p-exp.y (yylex, yyerror): Update.
8096         * m2-exp.y (parse_number, yylex, yyerror): Update.
8097         * go-exp.y (lex_one_token, yyerror): Update.
8098         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8099         * d-exp.y (lex_one_token, yyerror): Update.
8100         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8101         (lex_one_token, yyerror): Update.
8102         * ada-lex.l (YY_INPUT): Update.
8103         (rewind_to_char): Update.
8104         * ada-exp.y (yyerror): Update.
8105
8106 2019-04-04  Tom Tromey  <tom@tromey.com>
8107
8108         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8109         * parser-defs.h (struct parser_state) <parser_state>: Add new
8110         parameter.
8111         <comma_terminates>: New member.
8112         (comma_terminates): Don't declare global.
8113         * parse.c (comma_terminates): Remove global.
8114         (parse_exp_in_context): Update.
8115         * p-exp.y (yylex): Update.
8116         * m2-exp.y (yylex): Update.
8117         * go-exp.y (lex_one_token): Update.
8118         * f-exp.y (yylex): Update.
8119         * d-exp.y (lex_one_token): Update.
8120         * c-exp.y (lex_one_token): Update.
8121         * ada-lex.l: Update.
8122
8123 2019-04-04  Tom Tromey  <tom@tromey.com>
8124
8125         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8126         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8127         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8128         * parser-defs.h (paren_depth): Don't declare.
8129         * parse.c (paren_depth): Remove global.
8130         (parse_exp_in_context): Update.
8131         * p-exp.y (paren_depth): New global.
8132         (pascal_parse): Initialize it.
8133         * m2-exp.y (paren_depth): New global.
8134         (m2_parse): Initialize it.
8135         * go-exp.y (paren_depth): New global.
8136         (go_parse): Initialize it.
8137         * f-exp.y (paren_depth): New global.
8138         (f_parse): Initialize it.
8139         * d-exp.y (paren_depth): New global.
8140         (d_parse): Initialize it.
8141         * c-exp.y (paren_depth): New global.
8142         (c_parse): Initialize it.
8143         * ada-lex.l (paren_depth): New global.
8144         (lexer_init): Initialize it.
8145
8146 2019-04-04  Tom Tromey  <tom@tromey.com>
8147
8148         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8149         (rust_parser::convert_ast_to_type)
8150         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8151         * parser-defs.h (struct parser_state) <parser_state>: Add
8152         parameters.  Initialize new members.
8153         <expression_context_block, expression_context_pc>: New members.
8154         * parse.c (expression_context_block, expression_context_pc):
8155         Remove globals.
8156         (parse_exp_in_context): Update.
8157         * p-exp.y: Update all rules.
8158         (yylex): Update.
8159         * m2-exp.y: Update all rules.
8160         (yylex): Update.
8161         * go-exp.y (yylex): Update.
8162         * f-exp.y (yylex): Update.
8163         * d-exp.y: Update all rules.
8164         (yylex): Update.
8165         * c-exp.y: Update all rules.
8166         (lex_one_token, classify_name, yylex, c_parse): Update.
8167         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8168
8169 2019-04-04  Tom Tromey  <tom@tromey.com>
8170
8171         * gdbarch.h, gdbarch.c: Rebuild.
8172         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8173         * stap-probe.h:
8174         (struct stap_parse_info): Replace "parser_state" with
8175         "expr_builder".
8176         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8177         (parser_state): New class.
8178         * parse.c (expr_builder): Rename.
8179         (expr_builder::release): Rename.
8180         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8181         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8182         (write_exp_elt_longcst, write_exp_elt_floatcst)
8183         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8184         (write_exp_string_vector, write_exp_bitstring)
8185         (write_exp_msymbol, mark_struct_expression)
8186         (write_dollar_variable)
8187         (insert_type_address_space, increase_expout_size): Replace
8188         "parser_state" with "expr_builder".
8189         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8190         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8191         "parser_state" with "expr_builder".
8192
8193 2019-04-04  Tom Tromey  <tom@tromey.com>
8194
8195         * rust-exp.y: Replace "parse_language" with method call.
8196         * p-exp.y:
8197         (yylex): Replace "parse_language" with method call.
8198         * m2-exp.y:
8199         (yylex): Replace "parse_language" with method call.
8200         * go-exp.y (classify_name): Replace "parse_language" with method
8201         call.
8202         * f-exp.y (yylex): Replace "parse_language" with method call.
8203         * d-exp.y (lex_one_token): Replace "parse_language" with method
8204         call.
8205         * c-exp.y:
8206         (lex_one_token, classify_name, yylex): Replace "parse_language"
8207         with method call.
8208         * ada-exp.y (find_primitive_type, type_char)
8209         (type_system_address): Replace "parse_language" with method call.
8210
8211 2019-04-04  Tom Tromey  <tom@tromey.com>
8212
8213         * rust-exp.y: Replace "parse_gdbarch" with method call.
8214         * parse.c (write_dollar_variable, insert_type_address_space):
8215         Replace "parse_gdbarch" with method call.
8216         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8217         call.
8218         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8219         call.
8220         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8221         "parse_gdbarch" with method call.
8222         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8223         with method call.
8224         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8225         "parse_gdbarch" with method call.
8226         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8227         "parse_gdbarch" with method call.
8228         * c-exp.y (parse_type, parse_number, classify_name): Replace
8229         "parse_gdbarch" with method call.
8230         * ada-lex.l: Replace "parse_gdbarch" with method call.
8231         * ada-exp.y (parse_type, find_primitive_type, type_char)
8232         (type_system_address): Replace "parse_gdbarch" with method call.
8233
8234 2019-04-04  Tom Tromey  <tom@tromey.com>
8235
8236         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8237         * stap-probe.c (stap_parse_argument): Update.
8238         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8239         initial_size parameter.
8240         * rust-exp.y (rust_lex_tests): Update.
8241         * parse.c (parser_state): Update.
8242         (parse_exp_in_context): Update.
8243         * parser-defs.h (struct parser_state) <parser_state>: Remove
8244         "initial_size" parameter.
8245
8246 2019-04-04  Tom Tromey  <tom@tromey.com>
8247
8248         * parser-defs.h (increase_expout_size): Don't declare.
8249         * parse.c (increase_expout_size): Now static.
8250
8251 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8252
8253         * gnu-nat.c (gnu_nat_target::wait): Fix
8254         target_waitstatus_to_string call.
8255
8256 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8257
8258         * eval.c (evaluate_subexp_standard): Handle internal functions
8259         during Fortran function call handling.
8260
8261 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8262
8263         * NEWS: Mention new internal functions.
8264         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8265         (read_base_type): Use dwarf2_init_complex_target_type.
8266         * value.c (creal_internal_fn): New function.
8267         (cimag_internal_fn): New function.
8268         (_initialize_values): Register new internal functions.
8269
8270 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8271
8272         * infrun.c (stop_all_threads): If debug_infrun, always
8273         trace the wait status after wait_one, using
8274         target_waitstatus_to_string and target_pid_to_str.
8275         (handle_inferior_event): Replace various trace of
8276         wait status kind by a single trace.
8277         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8278         wait status kind image by target_waitstatus_to_string.
8279         * target/waitstatus.c (target_waitstatus_to_string): Fix
8280         obsolete comment.
8281
8282 2019-04-01  Tom Tromey  <tromey@adacore.com>
8283
8284         PR symtab/23331:
8285         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8286
8287 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8288             Pedro Alves  <palves@redhat.com>
8289
8290         * top.c (quit_force): Call 'finalize_values'.
8291         * value.c (finalize_values): New function.
8292         * value.h (finalize_values): Declare.
8293
8294 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8295
8296         * NEWS: Announce $_gdb_major and $_gdb_minor.
8297
8298         * top.c (init_gdb_version_vars): New function.
8299         (gdb_init): Call init_gdb_version_vars.
8300
8301 2019-03-29  Tom Tromey  <tromey@adacore.com>
8302
8303         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8304         help text.  Remove dead code.
8305
8306 2019-03-29  Keith Seitz  <keiths@redhat.com>
8307
8308         From Siddhesh Poyarekar:
8309         * f-lang.h (f77_get_upperbound): Return LONGEST.
8310         (f77_get_lowerbound): Likewise.
8311         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8312         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8313         print them.
8314         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8315         plongest to format print it.
8316         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8317         (f77_get_upperbound): Likewise.
8318         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8319         LOWER_BOUND to LONGEST.
8320         (f77_create_arrayprint_offset_tbl): Likewise.
8321
8322 2019-03-29  Keith Seitz  <keiths@redhat.com>
8323
8324         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8325         %s/pulongest for TYPE_LENGTH instead of %d in format
8326         strings.
8327         * ada-typerint.c (ada_print_type): Likewise.
8328         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8329         * compile/compile-c-support.c (generate_register_struct): Likewise.
8330         * gdbtypes.c (recursive_dump_type): Likewise.
8331         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8332         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8333         instead of %d in format strings.
8334         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8335         to std::min to ULONGEST.
8336         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8337         instead of %d in format strings.
8338         * tracepoint.c (info_scope_command): Likewise.
8339         * typeprint.c (print_offset_data::update)
8340         (print_offset_data::finish): Likewise.
8341         * xtensa-tdep.c (xtensa_store_return_value)
8342         (xtensa_push_dummy_call): Likewise.
8343
8344 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8345
8346         * windows-nat.c (display_selector): Fixed format specifications
8347         for 64-bit Cygwin.
8348
8349 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8350
8351         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8352
8353 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8354
8355         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8356         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8357         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8358         (nios2_linux_init_abi): Install it.
8359
8360 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8361
8362         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8363
8364 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8365
8366         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8367
8368 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8369             Tom Tromey  <tromey@adacore.com>
8370
8371         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8372
8373 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8374
8375         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
8376         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
8377         method to compute the bounds of range types. Also print "[evaluated]"
8378         if the bounds' values come from a dynamic evaluation.
8379
8380 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
8381
8382         * cp-valprint.c (cp_print_value_fields): Don't print trailing
8383         whitespace when pretty printing is on.
8384
8385 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8386
8387         * ppc-linux-nat.c: Add include.
8388
8389 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8390
8391         * NEWS: Mention AArch64 Pointer Authentication.
8392
8393 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
8394
8395         * arm-linux-nat.c: Add include.
8396
8397 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
8398
8399         * source-cache.c (source_cache::get_source_lines): Re-read
8400         fullname after calling open_source_file.
8401
8402 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
8403
8404         * NEWS: Mention TLS support for FreeBSD.
8405
8406 2019-03-25  Tom Tromey  <tromey@adacore.com>
8407
8408         * minsyms.c (BUNCH_SIZE): Update comment.
8409         (~minimal_symbol_reader): Remove old comment.
8410         (compact_minimal_symbols): Update comment.
8411         (minimal_symbol_reader::install): Remove old comment.  Update
8412         other comments.
8413
8414 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8415
8416         * s390-linux-nat.c: Add include.
8417
8418 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
8419
8420         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
8421         Call linux_get_hwcap.
8422         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
8423         Likewise.
8424         (aarch64_linux_get_hwcap): Remove function.
8425         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
8426         declaration.
8427         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
8428         linux_get_hwcap.
8429         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
8430         * linux-tdep.c (linux_get_hwcap): Add function.
8431         (linux_get_hwcap2): Likewise.
8432         * linux-tdep.h (linux_get_hwcap): Add declaration.
8433         (linux_get_hwcap2): Likewise.
8434         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
8435         (ppc_linux_get_hwcap2): Likewise.
8436         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
8437         linux_get_hwcap.
8438         (ppc_linux_nat_target::insert_watchpoint): Likewise.
8439         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
8440         (ppc_linux_nat_target::read_description): Likewise.
8441         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
8442         * s390-linux-nat.c: Likewise.
8443         * s390-linux-tdep.c (s390_core_read_description): Likewise.
8444
8445 2019-03-24  Tom Tromey  <tom@tromey.com>
8446
8447         * ada-lang.c (standard_lookup): Simplify initialization.
8448         (ada_lookup_symbol_nonlocal): Simplify return.
8449         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
8450         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
8451         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
8452         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
8453         initialization.
8454         * solib.c (solib_global_lookup): Simplify.
8455         * symtab.c (null_block_symbol): Remove.
8456         (symbol_cache_lookup): Simplify returns.
8457         (lookup_language_this): Simplify returns.
8458         (lookup_symbol_aux): Simplify return.
8459         (lookup_local_symbol): Simplify returns.
8460         (lookup_global_symbol_from_objfile): Simplify return.
8461         (lookup_symbol_in_objfile_symtabs)
8462         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
8463         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
8464         (lookup_static_symbol, lookup_global_symbol): Simplify return.
8465         * cp-namespace.c (cp_lookup_bare_symbol)
8466         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
8467         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
8468         (cp_lookup_nested_symbol): Don't use null_block_symbol.
8469         (cp_lookup_symbol_via_imports): Simplify initialization.
8470         (find_symbol_in_baseclass): Likewise.
8471         * symtab.h (null_block_symbol): Remove.
8472         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
8473         (d_lookup_nested_symbol, d_lookup_symbol_imports)
8474         (d_lookup_symbol_module): Likewise.
8475         (find_symbol_in_baseclass): Simplify initialization.
8476
8477 2019-03-24  Tom Tromey  <tom@tromey.com>
8478
8479         * expression.h: Don't include symtab.h.
8480         (struct block): Forward declare.
8481
8482 2019-03-24  Tom Tromey  <tom@tromey.com>
8483
8484         * c-exp.y (typebase): Remove casts.
8485         * gdbtypes.c (lookup_unsigned_typename, )
8486         (lookup_signed_typename): Remove cast.
8487         * eval.c (parse_to_comma_and_eval): Remove cast.
8488         * parse.c (write_dollar_variable): Remove cast.
8489         * block.h (struct block) <superblock>: Now const.
8490         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
8491         * psymtab.c (psym_map_matching_symbols): Make "block" const.
8492         (map_block): Make "block" const.
8493         * symfile.h (struct quick_symbol_functions)
8494         <map_matching_symbols>: Constify block argument to "callback".
8495         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
8496         const.
8497         (find_pc_sect_compunit_symtab): Make "b" const.
8498         (find_symbol_at_address): Likewise.
8499         (search_symbols): Likewise.
8500         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
8501         (dw2_debug_names_lookup_symbol): Likewise.
8502         (dw2_map_matching_symbols): Update.
8503         * p-valprint.c (pascal_val_print): Remove "block".
8504         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
8505         (aux_add_nonlocal_symbols): Make "block" const.
8506         (resolve_subexp): Remove cast.
8507         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
8508         const.
8509         (iterate_over_file_blocks): Likewise.
8510         * f-exp.y (%union) <bval>: Remove.
8511         * coffread.c (patch_opaque_types): Make "b" const.
8512         * spu-tdep.c (spu_catch_start): Make "block" const.
8513         * c-valprint.c (print_unpacked_pointer): Remove "block".
8514         * symmisc.c (dump_symtab_1): Make "b" const.
8515         (block_depth): Make "block" const.
8516         * d-exp.y (%union) <bval>: Remove.
8517         * cp-support.h (cp_lookup_rtti_type): Update.
8518         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
8519         * psymtab.c (psym_lookup_symbol): Make "block" const.
8520         (maintenance_check_psymtabs): Make "b" const.
8521         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
8522         (enumerate_locals, enumerate_args): Update.
8523         * python/py-symtab.c (stpy_global_block): Make "block" const.
8524         (stpy_static_block): Likewise.
8525         * inline-frame.c (block_starting_point_at): Make "new_block"
8526         const.
8527         * block.c (find_block_in_blockvector): Make return type const.
8528         (blockvector_for_pc_sect): Make "b" const.
8529         (find_block_in_blockvector): Make "b" const.
8530
8531 2019-03-23  Tom Tromey  <tom@tromey.com>
8532
8533         * varobj.c (varobj_create): Update.
8534         * symfile.c (clear_symtab_users): Don't reset innermost_block.
8535         * printcmd.c (display_command, do_one_display): Don't reset
8536         innermost_block.
8537         * parser-defs.h (enum innermost_block_tracker_type): Move to
8538         expression.h.
8539         (innermost_block): Update comment.
8540         * parse.c (parse_exp_1): Add tracker_types parameter.
8541         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
8542         tracker_types parameter.  Reset innermost_block.
8543         (parse_exp_in_context): Remove.
8544         (parse_expression_for_completion): Update.
8545         * objfiles.c (~objfile): Don't reset expression_context_block or
8546         innermost_block.
8547         * expression.h (enum innermost_block_tracker_type): Move from
8548         parser-defs.h.
8549         (parse_exp_1): Add tracker_types parameter.
8550         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
8551         reset innermost_block.
8552
8553 2019-03-23  Tom Tromey  <tom@tromey.com>
8554
8555         * objfiles.h: Include bcache.h.
8556
8557 2019-03-23  Tom Tromey  <tom@tromey.com>
8558
8559         * linespec.c (get_current_search_block): Use
8560         scoped_restore_current_language.
8561         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
8562
8563 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8564             Jiong Wang  <jiong.wang@arm.com>
8565
8566         * aarch64-linux-tdep.c
8567         (aarch64_linux_iterate_over_regset_sections): Check for pauth
8568         section.
8569         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
8570
8571 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8572             Jiong Wang  <jiong.wang@arm.com>
8573
8574         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
8575         instructions.
8576         (aarch64_analyze_prologue_test): Add PACIASP test.
8577         (aarch64_prologue_prev_register): Unmask PC value.
8578
8579 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8580             Jiong Wang  <jiong.wang@arm.com>
8581
8582         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
8583         (aarch64_dwarf2_prev_register): Unmask PC value.
8584         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
8585         (aarch64_execute_dwarf_cfa_vendor_op): Check for
8586         DW_CFA_AARCH64_negate_ra_state.
8587         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
8588
8589 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8590             Jiong Wang  <jiong.wang@arm.com>
8591
8592         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
8593         registers.
8594         (aarch64_pseudo_register_name): Likewise.
8595         (aarch64_pseudo_register_type): Likewise.
8596         (aarch64_pseudo_register_reggroup_p): Likewise.
8597         (aarch64_gdbarch_init): Add pauth registers.
8598         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
8599         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
8600         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
8601         (struct gdbarch_tdep): Add regnum for ra_state.
8602
8603 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8604             Jiong Wang  <jiong.wang@arm.com>
8605
8606         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
8607
8608 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8609             Jiong Wang  <jiong.wang@arm.com>
8610
8611         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
8612         function.
8613         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
8614         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
8615         (aarch64_gdbarch_init): Add puth registers.
8616         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
8617         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
8618         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
8619
8620 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8621             Jiong Wang  <jiong.wang@arm.com>
8622
8623         * aarch64-linux-nat.c
8624         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
8625         * aarch64-linux-tdep.c
8626         (aarch64_linux_core_read_description): Likewise.
8627         (aarch64_linux_get_hwcap): New function.
8628         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
8629         (aarch64_linux_get_hwcap): New declaration.
8630
8631 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
8632             Jiong Wang  <jiong.wang@arm.com>
8633
8634         * aarch64-linux-nat.c
8635         (aarch64_linux_nat_target::read_description): Add pauth param.
8636         * aarch64-linux-tdep.c
8637         (aarch64_linux_core_read_description): Likewise.
8638         * aarch64-tdep.c (struct target_desc): Add in pauth.
8639         (aarch64_read_description): Add pauth param.
8640         (aarch64_gdbarch_init): Likewise.
8641         * aarch64-tdep.h (aarch64_read_description): Likewise.
8642         * arch/aarch64.c (aarch64_create_target_description): Likewise.
8643         * arch/aarch64.h (aarch64_create_target_description): Likewise.
8644         * features/Makefile: Add new files.
8645         * features/aarch64-pauth.c: New file.
8646         * features/aarch64-pauth.xml: New file.
8647
8648 2019-03-20  Tom Tromey  <tromey@adacore.com>
8649
8650         * infrun.c (handle_inferior_event): Rename from
8651         handle_inferior_event_1.  Create a scoped_value_mark.
8652         (handle_inferior_event): Remove.
8653
8654 2019-03-19  Tom Tromey  <tromey@adacore.com>
8655
8656         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
8657         * infrun.h (print_stop_event): Add "displays" parameter.
8658         * infrun.c (print_stop_event): Add "displays" parameter.
8659
8660 2019-03-19  Pedro Alves  <palves@redhat.com>
8661
8662         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
8663         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
8664         to -1.  Fix TABs vs spaces.
8665         (tui_ui_out::tui_ui_out): Don't initialize fields here.
8666         * tui/tui-out.h (tui_ui_out) Add intro comments.
8667         <m_line, m_start_of_line>: In-class initialize, and add describing
8668         comment.
8669
8670 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
8671
8672         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
8673         variable names.
8674         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
8675
8676 2019-03-18  Pedro Alves  <palves@redhat.com>
8677             Eli Zaretskii <eliz@gnu.org>
8678
8679         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
8680         m_line and m_start_of_line.
8681
8682 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
8683
8684         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
8685         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
8686         it returns a newline.  This fixes a regression in TU mode, whereby
8687         the next line is output on the same screen line as the user input.
8688
8689 2019-03-18  Tom Tromey  <tromey@adacore.com>
8690
8691         * minsyms.c (minimal_symbol_reader::install): Remove call to
8692         obstack_blank.
8693
8694 2019-03-18  Pedro Alves  <palves@redhat.com>
8695
8696         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
8697         New globals.
8698         (apply_style): New, factored out from ...
8699         (apply_ansi_escape): ... this.  Handle reverse video mode.
8700         (tui_set_reverse_mode): New function.
8701         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
8702         * tui/tui-winsource.c (tui_show_source_line): Use
8703         tui_set_reverse_mode instead of setting A_STANDOUT.
8704         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
8705         New setter methods.
8706
8707 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
8708
8709         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
8710         Handle tabs.
8711
8712 2019-03-18  Tom Tromey  <tromey@adacore.com>
8713
8714         * ada-lang.c (empty_array): Add "high" parameter.
8715         (ada_evaluate_subexp): Update.
8716
8717 2019-03-17  Sergei Trofimovich <siarheit@google.com>
8718
8719         * unittests/string_view-selftests.c: Define
8720         _initialize_string_view_selftests unconditionally.
8721
8722 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8723
8724         PR gdb/24350
8725         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
8726
8727 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
8728
8729         PR gdb/24351
8730         * windows-nat.c (display_selector): Fix format specifiers.
8731
8732 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
8733
8734         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
8735         tui_refill_source_window instead of tui_refresh_win, to update the
8736         current execution line.  This fixes redisplay of the current line
8737         when stepping through the code with "next" or "step".
8738
8739 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8740
8741         * source-cache.c (source_cache::get_source_lines): Call
8742         find_source_lines to initialize s->nlines.  This fixes vertical
8743         scrolling of TUI source window when the DOWN arrow is pressed.
8744
8745 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8746
8747         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
8748         linux-thread-db.c (_initialize_thread_db): Likewise.
8749
8750 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
8751
8752         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
8753         wclrtoeol in tui_show_source_line".  This reverts changes made in
8754         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
8755
8756 2019-03-15  Tom Tromey  <tom@tromey.com>
8757
8758         * symtab.h (struct minimal_symbol): Derive from
8759         general_symbol_info.
8760         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
8761         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
8762         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
8763         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
8764         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
8765         (MSYMBOL_SEARCH_NAME): Update.
8766         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
8767         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
8768         * minsyms.c (minimal_symbol_reader::record_full): Update.
8769
8770 2019-03-15  Tom Tromey  <tom@tromey.com>
8771
8772         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
8773
8774 2019-03-15  Tom Tromey  <tom@tromey.com>
8775
8776         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
8777         unique_xmalloc_ptr.
8778         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
8779         Update.
8780         * minsyms.c (lookup_minimal_symbol_by_pc_section)
8781         (build_minimal_symbol_hash_tables)
8782         (minimal_symbol_reader::install): Update.
8783
8784 2019-03-15  Tom Tromey  <tom@tromey.com>
8785
8786         * symtab.c (create_demangled_names_hash): Update.
8787         (symbol_set_names): Update.
8788         * objfiles.h (struct objfile_per_bfd_storage)
8789         <demangled_names_hash>: Now an htab_up.
8790         * objfiles.c (objfile_per_bfd_storage): Simplify.
8791
8792 2019-03-15  Tom Tromey  <tom@tromey.com>
8793
8794         * objfiles.h (struct objfile_per_bfd_storage): Declare
8795         destructor.
8796         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
8797         New.
8798         (get_objfile_bfd_data): Use new.  Don't initialize
8799         language_of_main.
8800         (free_objfile_per_bfd_storage): Remove.
8801         (objfile_bfd_data_free, objfile::~objfile): Use delete.
8802
8803 2019-03-15  Tom Tromey  <tom@tromey.com>
8804
8805         * symfile.c (reread_symbols): Update.
8806         * objfiles.c (objfile::objfile): Update.
8807         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
8808         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
8809         comment.
8810         (minimal_symbol_reader::install): Update.
8811         (terminate_minimal_symbol_table): Remove.
8812         * jit.c (jit_object_close_impl): Update.
8813
8814 2019-03-15  Tom Tromey  <tom@tromey.com>
8815
8816         * minsyms.c (minimal_symbol_reader::record_full): Remove some
8817         initializations.
8818
8819 2019-03-15  Tom Tromey  <tom@tromey.com>
8820
8821         * objfiles.h (struct objfile_per_bfd_storage)
8822         <demangled_hash_languages>: Now a bitset.
8823         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
8824         (lookup_minimal_symbol): Update.
8825
8826 2019-03-15  Tom Tromey  <tom@tromey.com>
8827
8828         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
8829         Don't return the symbol.
8830         * coffread.c (record_minimal_symbol): Use record_full.
8831
8832 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
8833
8834         The MS-Windows port of ncurses fails to switch to a color pair if
8835         one or both of the colors are the implicit default colors.  This
8836         change records the default colors when TUI is initialized, and
8837         then specifies them explicitly when a color pair uses the default
8838         colors.  This allows color styling in TUI mode on MS-Windows.
8839
8840         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
8841         ncurses_norm_attr.
8842         (tui_initialize_io) [__MINGW32__]: Record the default terminal
8843         colors in ncurses_norm_attr.
8844         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
8845         "none", replace it with the default color recorded in
8846         ncurses_norm_attr.
8847
8848 2019-03-14  Tom Tromey  <tromey@adacore.com>
8849
8850         * source-cache.h (class source_cache) <get_source_lines>: Return
8851         std::string.
8852         * source-cache.c (source_cache::extract_lines): Handle case where
8853         first_pos==npos.  Return std::string.
8854         (source_cache::get_source_lines): Update.
8855
8856 2019-03-14  Tom Tromey  <tromey@adacore.com>
8857
8858         * NEWS: Add item for "style sources" commands.
8859         * source-cache.c (source_cache::get_source_lines): Check
8860         source_styling.
8861         * cli/cli-style.c (source_styling): New global.
8862         (_initialize_cli_style): Add "style sources" commands.
8863         (show_style_sources): New function.
8864         * cli/cli-style.h (source_styling): Declare.
8865
8866 2019-03-14  Pedro Alves  <palves@redhat.com>
8867             Tom Tromey  <tromey@adacore.com>
8868
8869         * tui/tui-winsource.h (tui_refill_source_window): Declare.
8870         * tui/tui-winsource.c (tui_refill_source_window): New function,
8871         from...
8872         (tui_horizontal_source_scroll): ... here.  Move some logic.
8873         * cli/cli-style.c (set_style_enabled): Notify new observable.
8874         * tui/tui-hooks.c (tui_redisplay_source): New function.
8875         (tui_attach_detach_observers): Attach or detach
8876         tui_redisplay_source.
8877         * observable.h (source_styling_changed): New observable.
8878         * observable.c: Define source_styling_changed observable.
8879
8880 2019-03-13  Tom Tromey  <tromey@adacore.com>
8881
8882         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
8883         (i386_gnu_nat_target::store_registers): Update.
8884         * target-debug.h (target_debug_print_std_string): New macro.
8885         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8886         * windows-tdep.c (display_one_tib): Update.
8887         * tui/tui-stack.c (tui_make_status_line): Update.
8888         * top.c (print_inferior_quit_action): Update.
8889         * thread.c (thr_try_catch_cmd): Update.
8890         (add_thread_with_info): Update.
8891         (thread_target_id_str): Update.
8892         (thr_try_catch_cmd): Update.
8893         (thread_command): Update.
8894         (thread_find_command): Update.
8895         * record-btrace.c (record_btrace_target::info_record)
8896         (record_btrace_resume_thread, record_btrace_target::resume)
8897         (record_btrace_cancel_resume, record_btrace_step_thread)
8898         (record_btrace_target::wait, record_btrace_target::wait)
8899         (record_btrace_target::wait, record_btrace_target::stop): Update.
8900         * progspace.c (print_program_space): Update.
8901         * process-stratum-target.c
8902         (process_stratum_target::thread_address_space): Update.
8903         * linux-fork.c (linux_fork_mourn_inferior)
8904         (detach_checkpoint_command, info_checkpoints_command)
8905         (linux_fork_context): Update.
8906         (linux_fork_detach): Update.
8907         (class scoped_switch_fork_info): Update.
8908         (delete_checkpoint_command): Update.
8909         * infrun.c (follow_fork_inferior): Update.
8910         (follow_fork_inferior): Update.
8911         (proceed_after_vfork_done): Update.
8912         (handle_vfork_child_exec_or_exit): Update.
8913         (follow_exec): Update.
8914         (displaced_step_prepare_throw): Update.
8915         (displaced_step_restore): Update.
8916         (start_step_over): Update.
8917         (resume_1): Update.
8918         (clear_proceed_status_thread): Update.
8919         (proceed): Update.
8920         (print_target_wait_results): Update.
8921         (do_target_wait): Update.
8922         (context_switch): Update.
8923         (stop_all_threads): Update.
8924         (restart_threads): Update.
8925         (finish_step_over): Update.
8926         (handle_signal_stop): Update.
8927         (switch_back_to_stepped_thread): Update.
8928         (keep_going_pass_signal): Update.
8929         (print_exited_reason): Update.
8930         (normal_stop): Update.
8931         * inferior.c (inferior_pid_to_str): Change return type.
8932         (print_selected_inferior): Update.
8933         (add_inferior): Update.
8934         (detach_inferior): Update.
8935         * dummy-frame.c (fprint_dummy_frames): Update.
8936         * dcache.c (dcache_info_1): Update.
8937         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
8938         (btrace_fetch, btrace_clear): Update.
8939         * linux-tdep.c (linux_core_pid_to_str): Change return type.
8940         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
8941         type.
8942         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
8943         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
8944         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
8945         * gdbarch.c, gdbarch.h: Rebuild.
8946         * gdbarch.sh (core_pid_to_str): Change return type.
8947         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
8948         return type.
8949         (windows_nat_target::pid_to_str): Change return type.
8950         (windows_delete_thread): Update.
8951         (windows_nat_target::attach): Update.
8952         (windows_nat_target::files_info): Update.
8953         * target-delegates.c: Rebuild.
8954         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
8955         return type.
8956         (sol_thread_target::pid_to_str): Change return type.
8957         * remote.c (class remote_target) <pid_to_str>: Change return
8958         type.
8959         (remote_target::pid_to_str): Change return type.
8960         (extended_remote_target::attach, remote_target::remote_stop_ns)
8961         (remote_target::remote_notif_remove_queued_reply)
8962         (remote_target::push_stop_reply, remote_target::disable_btrace):
8963         Update.
8964         (extended_remote_target::attach): Update.
8965         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
8966         type.
8967         (gdbsim_target::pid_to_str): Change return type.
8968         * ravenscar-thread.c (struct ravenscar_thread_target)
8969         <pid_to_str>: Change return type.
8970         (ravenscar_thread_target::pid_to_str): Change return type.
8971         * procfs.c (class procfs_target) <pid_to_str>: Change return
8972         type.
8973         (procfs_target::pid_to_str): Change return type.
8974         (procfs_target::attach): Update.
8975         (procfs_target::detach): Update.
8976         (procfs_target::fetch_registers): Update.
8977         (procfs_target::store_registers): Update.
8978         (procfs_target::wait): Update.
8979         (procfs_target::files_info): Update.
8980         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
8981         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
8982         return type.
8983         (nto_procfs_target::pid_to_str): Change return type.
8984         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
8985         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
8986         return type.
8987         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
8988         (exit_lwp): Update.
8989         (attach_proc_task_lwp_callback, get_detach_signal)
8990         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
8991         (linux_nat_target::resume, wait_lwp, stop_callback)
8992         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
8993         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
8994         (linux_nat_wait_1, resume_stopped_resumed_lwps)
8995         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
8996         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
8997         type.
8998         (inf_ptrace_target::attach): Update.
8999         (inf_ptrace_target::files_info): Update.
9000         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9001         type.
9002         (go32_nat_target::pid_to_str): Change return type.
9003         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9004         (gnu_nat_target::wait): Update.
9005         (gnu_nat_target::wait): Update.
9006         (gnu_nat_target::resume): Update.
9007         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9008         (fbsd_nat_target::wait): Update.
9009         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9010         type.
9011         (darwin_nat_target::attach): Update.
9012         * corelow.c (class core_target) <pid_to_str>: Change return type.
9013         (core_target::pid_to_str): Change return type.
9014         * target.c (normal_pid_to_str): Change return type.
9015         (default_pid_to_str): Likewise.
9016         (target_pid_to_str): Change return type.
9017         (target_translate_tls_address): Update.
9018         (target_announce_detach): Update.
9019         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9020         return type.
9021         (bsd_uthread_target::pid_to_str): Change return type.
9022         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9023         type.
9024         (bsd_kvm_target::pid_to_str): Change return type.
9025         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9026         return type.
9027         (aix_thread_target::pid_to_str): Change return type.
9028         * target.h (struct target_ops) <pid_to_str>: Change return type.
9029         (target_pid_to_str, normal_pid_to_str): Likewise.
9030         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9031         type.
9032         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9033         type.
9034         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9035         return type.
9036         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9037         type.
9038         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9039         type.
9040         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9041         return type.
9042
9043 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9044
9045         * NEWS: Mention that the new default MI version is 3.  Mention
9046         changes to the output of commands and events that deal with
9047         multi-location breakpoints.
9048         * breakpoint.c: Include "mi/mi-out.h".
9049         (print_one_breakpoint): Change output syntax if using MI version
9050         >= 3.
9051         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9052         New.
9053         (mi_multi_location_breakpoint_output_fixed): New.
9054         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9055         (mi_cmd_fix_multi_location_breakpoint_output): New.
9056         (mi_multi_location_breakpoint_output_fixed): New.
9057         * mi/mi-cmds.c (mi_cmds): Register command
9058         -fix-multi-location-breakpoint-output.
9059         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9060         interpreter "mi".
9061
9062 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9063
9064         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9065         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9066         instantiate mi_ui_out based on interpreter name.
9067         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9068         * mi/mi-main.c (mi_load_progress): Likewise.
9069
9070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9071
9072         * NEWS: Combine separate "New targets" sections for 8.3.
9073
9074 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9075
9076         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9077         (ppcfbsd_init_abi): Install gdbarch
9078         "fetch_tls_load_module_address" and "get_thread_local_address"
9079         methods.
9080
9081 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9082
9083         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9084         (riscv_fbsd_init_abi): Install gdbarch
9085         "fetch_tls_load_module_address" and "get_thread_local_address"
9086         methods.
9087
9088 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9089
9090         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9091         (i386fbsd_init_abi): Install gdbarch
9092         "fetch_tls_load_module_address" and "get_thread_local_address"
9093         methods.
9094
9095 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9096
9097         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9098         (amd64fbsd_init_abi): Install gdbarch
9099         "fetch_tls_load_module_address" and "get_thread_local_address"
9100         methods.
9101
9102 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9103
9104         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9105         (struct fbsd_pspace_data): New type.
9106         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9107         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9108         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9109         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9110         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9111
9112 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9113
9114         * gdbtypes.c (lookup_struct_elt): New function.
9115         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9116         * gdbtypes.h (struct struct_elt): New type.
9117         (lookup_struct_elt): New prototype.
9118
9119 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9120
9121         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9122         remove disabled code block.
9123
9124 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9125
9126         * gdbarch.sh (get_thread_local_address): New method.
9127         * gdbarch.h, gdbarch.c: Regenerate.
9128         * target.c (target_translate_tls_address): Use
9129         gdbarch_get_thread_local_address if present instead of
9130         target::get_thread_local_address.
9131
9132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9133
9134         * target.h (target::get_thread_local_address): Update comment.
9135
9136 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9137
9138         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9139         objfile->separate_debug_objfile_backlink if not NULL.
9140
9141 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9142
9143         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9144         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9145         (amd64bsd_store_inferior_registers): Likewise.
9146         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9147         Enable segment base registers.
9148         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9149         PT_GETFSBASE and PT_GETGSBASE.
9150         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9151         PT_SETGSBASE.
9152         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9153         segment base registers.
9154         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9155
9156 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9157
9158         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9159         Update calls to i386_target_description to add 'segments'
9160         parameter.
9161         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9162         add segment base registers.
9163         * arch/i386.c (i386_create_target_description): Add 'segments'
9164         parameter to enable segment base registers.
9165         * arch/i386.h (i386_create_target_description): Likewise.
9166         * features/i386/32bit-segments.xml: New file.
9167         * features/i386/32bit-segments.c: Generate.
9168         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9169         call to i386_target_description to add 'segments' parameter.
9170         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9171         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9172         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9173         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9174         if feature is present.
9175         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9176         Add 'segments' parameter to call to i386_target_description.
9177         (i386_target_description): Add 'segments' parameter to enable
9178         segment base registers.
9179         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9180         to call to i386_target_description.
9181         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9182         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9183         Define I386_NUM_REGS.
9184         (i386_target_description): Add 'segments' parameter to enable
9185         segment base registers.
9186
9187 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9188
9189         PR/24325
9190         * source-cache.c: #undef open and close, to avoid unresolved
9191         externals during linking.
9192
9193 2019-03-12  Tom Tromey  <tromey@adacore.com>
9194
9195         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9196         const.  Add initializers.
9197         (_initialize_remote): Don't initialize ptid globals.
9198
9199 2019-03-12  Pedro Alves  <palves@redhat.com>
9200
9201         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9202
9203 2019-03-12  Pedro Alves  <palves@redhat.com>
9204
9205         * cp-name-parser.y (main): Remove unused 'len' variable.
9206
9207 2019-03-12  Tom Tromey  <tromey@adacore.com>
9208
9209         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9210         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9211
9212 2019-03-12  Tom Tromey  <tromey@adacore.com>
9213
9214         * linux-nat.c (iterate_over_lwps): Update.
9215         (stop_callback): Remove parameter.
9216         (stop_wait_callback, detach_callback, resume_set_callback)
9217         (select_singlestep_lwp_callback, set_ignore_sigint)
9218         (status_callback, resumed_callback, resume_clear_callback)
9219         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9220         data parameter.
9221         (linux_nat_target::detach, linux_nat_target::resume)
9222         (linux_stop_and_wait_all_lwps, select_event_lwp)
9223         (linux_nat_filter_event, linux_nat_wait_1)
9224         (linux_nat_target::kill, linux_nat_target::stop)
9225         (linux_nat_target::stop): Update.
9226         (linux_nat_resume_callback): Change type.
9227         (resume_stopped_resumed_lwps, count_events_callback)
9228         (select_event_lwp_callback): Likewise.
9229         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9230         * arm-linux-nat.c (struct update_registers_data): Remove.
9231         (update_registers_callback): Change type.
9232         (arm_linux_insert_hw_breakpoint1): Update.
9233         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9234         parameter.
9235         (x86_linux_dr_set_addr): Update.
9236         (x86_linux_dr_set_control): Update.
9237         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9238         (iterate_over_lwps): Use gdb::function_view.
9239         * nat/aarch64-linux-hw-point.c (struct
9240         aarch64_dr_update_callback_param): Remove.
9241         (debug_reg_change_callback): Change type.
9242         (aarch64_notify_debug_reg_change): Update.
9243         * s390-linux-nat.c (s390_refresh_per_info): Update.
9244
9245 2019-03-11  Tom Tromey  <tromey@adacore.com>
9246
9247         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9248         redundant assignment to "this_cu".
9249
9250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9251
9252         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9253
9254 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9255
9256         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9257         from...
9258         (rank_one_type): ... this.
9259
9260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9261
9262         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9263         from...
9264         (rank_one_type): ... this.
9265
9266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9267
9268         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9269         from...
9270         (rank_one_type): ... this.
9271
9272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9273
9274         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9275         from...
9276         (rank_one_type): ... this.
9277
9278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9279
9280         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9281         from...
9282         (rank_one_type): ... this.
9283
9284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9285
9286         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9287         from...
9288         (rank_one_type): ... this.
9289
9290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9291
9292         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9293         from...
9294         (rank_one_type): ... this.
9295
9296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9297
9298         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9299         from...
9300         (rank_one_type): ... this.
9301
9302 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9303
9304         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9305         from...
9306         (rank_one_type): ... this.
9307
9308 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9309
9310         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9311         from...
9312         (rank_one_type): ... this.
9313
9314 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9315
9316         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9317         from...
9318         (rank_one_type): ... this.
9319
9320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9321
9322         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9323         from...
9324         (rank_one_type): ... this.
9325
9326 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9327
9328         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9329         inferior-events' shows the example events.
9330
9331 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9332
9333         Support styling on native MS-Windows console
9334
9335         PR/24315
9336         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9337         on MS-Windows if $TERM is not defined.
9338
9339         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9340
9341         * posix-hdep.c (gdb_console_fputs):
9342         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9343         functions.
9344         * ui-file.h (gdb_console_fputs): Add prototype.
9345
9346         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9347         back to fputs only if the former returns zero.
9348
9349 2019-03-07  Tom Tromey  <tom@tromey.com>
9350
9351         * symmisc.c (print_symbol_bcache_statistics): Update.
9352         (print_objfile_statistics): Update.
9353         * symfile.c (allocate_symtab): Update.
9354         * stabsread.c: Don't include bcache.h.
9355         * psymtab.h (struct psymbol_bcache): Don't declare.
9356         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9357         (psymbol_bcache_init, psymbol_bcache_free)
9358         (psymbol_bcache_get_bcache): Don't declare.
9359         * psymtab.c (struct psymbol_bcache): Remove.
9360         (psymtab_storage::psymtab_storage): Update.
9361         (psymtab_storage::~psymtab_storage): Update.
9362         (psymbol_bcache_init, psymbol_bcache_free)
9363         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9364         (add_psymbol_to_bcache): Update.
9365         (allocate_psymtab): Update.
9366         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9367         macro_cache>: No longer pointers.
9368         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9369         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9370         * macrotab.c (macro_bcache): Update.
9371         * macroexp.c: Don't include bcache.h.
9372         * gdbtypes.c (check_types_worklist): Update.
9373         (types_deeply_equal): Remove TRY/CATCH.  Update.
9374         * elfread.c (elf_symtab_read): Update.
9375         * dwarf2read.c: Don't include bcache.h.
9376         * buildsym.c (buildsym_compunit::get_macro_table): Update.
9377         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
9378         (print_bcache_statistics, bcache_memory_used): Don't declare.
9379         (struct bcache): Move from bcache.c.  Add constructor, destructor,
9380         methods.  Rename all data members.
9381         * bcache.c (struct bcache): Move to bcache.h.
9382         (bcache::expand_hash_table): Rename from expand_hash_table.
9383         (bcache): Remove.
9384         (bcache::insert): Rename from bcache_full.
9385         (bcache::compare): Rename from bcache_compare.
9386         (bcache_xmalloc): Remove.
9387         (bcache::~bcache): Rename from bcache_xfree.
9388         (bcache::print_statistics): Rename from print_bcache_statistics.
9389         (bcache::memory_used): Rename from bcache_memory_used.
9390
9391 2019-03-07  Pedro Alves  <palves@redhat.com>
9392
9393         * infrun.c (normal_stop): Also check for
9394         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
9395
9396 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
9397
9398         * f-lang.c (value_from_host_double): Moved to...
9399         * value.c (value_from_host_double): ...here.
9400         * value.h (value_from_host_double): Declare.
9401         * guile/scm-math.c (vlscm_convert_typed_number): Use
9402         value_from_host_double.
9403         (vlscm_convert_number): Likewise.
9404         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
9405         * python/py-value.c (convert_value_from_python): Likewise.
9406
9407 2019-03-06  Tom Tromey  <tom@tromey.com>
9408
9409         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
9410
9411 2019-03-06  Tom Tromey  <tom@tromey.com>
9412
9413         * utils.h (free_current_contents): Don't declare.
9414         * utils.c (free_current_contents): Remove.
9415
9416 2019-03-06  Tom Tromey  <tom@tromey.com>
9417
9418         * top.c (quit_force): Update.
9419         * main.c (captured_command_loop): Update.
9420         * common/new-op.c (operator new): Update.
9421         * common/common-exceptions.c (struct catcher)
9422         <save_cleanup_chain>: Remove member.
9423         (exceptions_state_mc_init): Update.
9424         (exception_try_scope_entry): Return nullptr.
9425         (exception_try_scope_exit, exception_rethrow)
9426         (throw_exception_sjlj, throw_exception_cxx): Update.
9427         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
9428         (all_cleanups, do_cleanups, discard_cleanups)
9429         (discard_final_cleanups, save_cleanups, save_final_cleanups)
9430         (restore_cleanups, restore_final_cleanups): Don't declare.
9431         (do_final_cleanups): Remove parameter.
9432         * common/cleanups.c (cleanup_chain, make_cleanup)
9433         (make_cleanup_dtor, all_cleanups, do_cleanups)
9434         (discard_my_cleanups, discard_cleanups)
9435         (discard_final_cleanups, save_my_cleanups, save_cleanups)
9436         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
9437         (null_cleanup): Remove.
9438         (do_final_cleanups): Remove parameter.
9439
9440 2019-03-06  Tom Tromey  <tom@tromey.com>
9441
9442         * remote.c (remote_target::remote_parse_stop_reply): Use
9443         unique_xmalloc_ptr.
9444
9445 2019-03-06  Tom Tromey  <tom@tromey.com>
9446
9447         * stabsread.c (struct stabs_field_info): Rename from field_info.
9448         <list, fnlist>: Add initializers.
9449         <obstack>: New member.
9450         (read_member_functions, read_struct_fields, read_baseclasses):
9451         Allocate on obstack.  Don't use cleanups.
9452         (read_one_struct_field, read_member_functions, read_struct_fields)
9453         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
9454         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
9455         (read_struct_type): Update.
9456
9457 2019-03-06  Tom Tromey  <tom@tromey.com>
9458
9459         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
9460         * common/filestuff.h (make_cleanup_close): Don't declare.
9461         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
9462         Remove.
9463
9464 2019-03-06  Tom Tromey  <tom@tromey.com>
9465
9466         * solib-aix.c: Use make_scope_exit.
9467
9468 2019-03-06  Tom Tromey  <tom@tromey.com>
9469
9470         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
9471         Use make_scope_exit.
9472
9473 2019-03-06  Tom Tromey  <tom@tromey.com>
9474
9475         * solib-svr4.c (disable_probes_interface): Remove parameter.
9476         (svr4_handle_solib_event): Use make_scope_exit.
9477
9478 2019-03-06  Tom Tromey  <tom@tromey.com>
9479
9480         * remote.c (struct stop_reply_deleter): Remove.
9481         (stop_reply_up): Update.
9482         (struct stop_reply): Derive from notif_event.  Don't typedef.
9483         <regcache>: Now a std::vector.
9484         (stop_reply_xfree): Remove.
9485         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
9486         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
9487         (remote_target::discard_pending_stop_replies): Use delete.
9488         (remote_target::remote_parse_stop_reply): Update.
9489         (remote_target::process_stop_reply): Update.
9490         * remote-notif.h (struct notif_event): Add virtual destructor.
9491         Remove "dtr" member.
9492         (struct notif_client) <alloc_event>: Return a unique_ptr.
9493         (notif_event_xfree): Don't declare.
9494         (notif_event_up): New typedef.
9495         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
9496         (notif_event_xfree, do_notif_event_xfree): Remove.
9497         (remote_notif_state_xfree): Update.
9498
9499 2019-03-06  Tom Tromey  <tom@tromey.com>
9500
9501         * infrun.c (displaced_step_clear_cleanup): Now a
9502         forward_scope_exit type.
9503         (displaced_step_prepare_throw): Update.
9504         (displaced_step_fixup): Update.
9505
9506 2019-03-06  Tom Tromey  <tom@tromey.com>
9507
9508         * inferior.h (class inferior): Update comment.
9509         * gdbthread.h (class thread_info): Update comment.
9510
9511 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
9512             Tom Tromey  <tom@tromey.com>
9513
9514         * stabsread.h (struct stab_section_list): Remove.
9515         (coffstab_build_psymtabs): Update.
9516         * dbxread.c (symbuf_sections): Now a std::vector.
9517         (sect_idx): New global.
9518         (fill_symbuf): Update.
9519         (coffstab_build_psymtabs): Change type of stabsects parameter.
9520         Update.
9521         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
9522         std::vector.
9523         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
9524         (coff_locate_sections): Update.
9525         (coff_symfile_read): Remove cleanups.  Update.
9526         (init_stringtab): Add storage parameter.
9527         (free_stringtab, free_stringtab_cleanup): Remove.
9528         (init_lineno): Add storage parameter.
9529         (free_linetab, free_linetab_cleanup): Remove.
9530
9531 2019-03-06  Pedro Alves  <palves@redhat.com>
9532
9533         * linux-fork.c (fork_info::clobber_regs): Delete.
9534         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
9535         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
9536         comment.  Adjust.
9537         (scoped_switch_fork_info::scoped_switch_fork_info)
9538         (checkpoint_command, linux_fork_context): Adjust
9539         fork_save_infrun_state calls.
9540
9541 2019-03-06  Pedro Alves  <palves@redhat.com>
9542
9543         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
9544         (inf_has_multiple_threads): Return 'bool' and rewrite using
9545         inferior_info::threads().
9546
9547 2019-03-06  Pedro Alves  <palves@redhat.com>
9548
9549         * linux-fork.c: Include <list>.
9550         (fork_list): Now a std::list instance.
9551         (fork_info): Add ctor, dtor, and in-class initialize all fields.
9552         (forks_exist_p, find_last_fork): Adjust.
9553         (new_fork): Delete.
9554         (one_fork_p): New.
9555         (add_fork): Adjust.
9556         (free_fork): Delete, folded into fork_info::~fork_info().
9557         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
9558         Adjust.
9559         (init_fork_list): Delete.
9560         (linux_fork_killall, linux_fork_mourn_inferior)
9561         (linux_fork_detach, info_checkpoints_command): Adjust.
9562         (_initialize_linux_fork): No longer call init_fork_list.
9563
9564 2019-03-06  Pedro Alves  <palves@redhat.com>
9565
9566         * linux-fork.c (new_fork): New, split out of ...
9567         (add_fork): ... this.  Return void.  Move "first fork" special
9568         case from here, to ...
9569         (checkpoint_command): ... here.
9570         * linux-linux.h (add_fork): Return void.
9571
9572 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9573
9574         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
9575
9576 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9577             Chris January  <chris.january@arm.com>
9578             David Lecomber  <david.lecomber@arm.com>
9579
9580         * f-exp.y: New token, UNOP_INTRINSIC.
9581         (exp): New pattern using UNOP_INTRINSIC token.
9582         (f77_keywords): Add 'abs' keyword.
9583         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
9584         (value_from_host_double): New function.
9585         (evaluate_subexp_f): Support UNOP_ABS.
9586
9587 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9588
9589         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
9590         types.
9591
9592 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9593
9594         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
9595         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
9596         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
9597
9598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9599
9600         * f-exp.y (convert_to_kind_type): Handle more type kinds.
9601
9602 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9603             Chris January  <chris.january@arm.com>
9604
9605         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
9606         * f-exp.y: Define 'KIND' token.
9607         (exp): New pattern for KIND expressions.
9608         (ptype): Handle types with a kind extension.
9609         (direct_abs_decl): Extend to spot kind extensions.
9610         (f77_keywords): Add 'kind' to the list.
9611         (push_kind_type): New function.
9612         (convert_to_kind_type): New function.
9613         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
9614         * parse.c (operator_length_standard): Likewise.
9615         * parser-defs.h (enum type_pieces): Add tp_kind.
9616         * std-operator.def: Add UNOP_KIND.
9617
9618 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9619
9620         * f-exp.y (f_parse): Set yydebug.
9621
9622 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9623
9624         * f-lang.c (evaluate_subexp_f): New function.
9625         (exp_descriptor_f): New global.
9626         (f_language_defn): Use exp_descriptor_f instead of
9627         exp_descriptor_standard.
9628
9629 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9630
9631         * f-exp.y (struct token): Add comments.
9632         (dot_ops): Remove uppercase versions and the end marker.
9633         (f77_keywords): Likewise.
9634         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
9635         entries in the dot_ops array are case insensitive, and use
9636         strncasecmp to compare strings.  Also some whitespace cleanup in
9637         this area.  Similar for the f77_keywords array, except entries in
9638         this list might be case sensitive.
9639
9640 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
9641
9642         * f-exp.y (struct f77_boolean_val): Add comments.
9643         (boolean_values): Remove uppercase versions, and end marker.
9644         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
9645         and use strncasecmp to achieve case insensitivity.  Additionally,
9646         perform whitespace cleanup around this code.
9647
9648 2019-03-06  Tom Tromey  <tromey@adacore.com>
9649
9650         * remote-sim.c (gdbsim_target_open): Use result of
9651         gdb_argv::release.
9652
9653 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
9654         Dirk Schubert  <dirk.schubert@arm.com>
9655         Chris January  <chris.january@arm.com>
9656
9657         * eval.c (evaluate_subexp_standard): Call Fortran argument
9658         wrapping logic.
9659         * f-lang.c (struct value): A value which can be passed into a
9660         Fortran function call.
9661         (fortran_argument_convert): Wrap Fortran arguments in a pointer
9662         where appropriate.
9663         (struct type): Value ready for a Fortran function call.
9664         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
9665         is needed.
9666         * f-lang.h (fortran_argument_convert): Declaration.
9667         (fortran_preserve_arg_pointer): Declaration.
9668         * infcall.c (value_arg_coerce): Call Fortran argument logic.
9669
9670 2019-03-05  Tom Tromey  <tromey@adacore.com>
9671
9672         * python/py-prettyprint.c (print_string_repr): Remove #if.
9673         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
9674
9675 2019-03-05  Tom Tromey  <tromey@adacore.com>
9676
9677         * target.c (the_dummy_target): Move later.  Change type to
9678         "dummy_target".
9679         (initialize_targets): Don't initialize the_dummy_target.
9680
9681 2019-03-05  Tom Tromey  <tromey@adacore.com>
9682
9683         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
9684         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
9685
9686 2019-03-05  Tom Tromey  <tromey@adacore.com>
9687
9688         * windows-nat.c (windows_nat_target::attach)
9689         (windows_nat_target::detach): Don't call gdb_flush.
9690         * valprint.c (generic_val_print, val_print, val_print_string):
9691         Don't call gdb_flush.
9692         * utils.c (defaulted_query): Don't call gdb_flush.
9693         * typeprint.c (print_type_scalar): Don't call gdb_flush.
9694         * target.c (target_announce_detach): Don't call gdb_flush.
9695         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
9696         * remote.c (extended_remote_target::attach): Don't call
9697         gdb_flush.
9698         * procfs.c (procfs_target::detach): Don't call gdb_flush.
9699         * printcmd.c (do_examine): Don't call gdb_flush.
9700         (info_display_command): Don't call gdb_flush.
9701         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
9702         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
9703         * memattr.c (info_mem_command): Don't call gdb_flush.
9704         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
9705         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
9706         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
9707         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
9708         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
9709         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
9710         (gnu_nat_target::detach): Don't call gdb_flush.
9711         * f-valprint.c (f_val_print): Don't call gdb_flush.
9712         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
9713         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
9714         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
9715         gdb_flush.
9716         * c-valprint.c (c_val_print): Don't call gdb_flush.
9717         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
9718
9719 2019-03-05  Tom Tromey  <tromey@adacore.com>
9720
9721         * varobj.c (update_dynamic_varobj_children): Update.
9722         (install_default_visualizer): Use reset, not release.
9723         * value.c (set_internalvar): Update.
9724         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
9725         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
9726         ATTRIBUTE_UNUSED_RESULT.
9727
9728 2019-03-05  Tom Tromey  <tromey@adacore.com>
9729
9730         * remote.c (class scoped_remote_fd) <release>: Add
9731         ATTRIBUTE_UNUSED_RESULT.
9732
9733 2019-03-05  Tom Tromey  <tromey@adacore.com>
9734
9735         * macroexp.c (struct macro_buffer) <release>: Add
9736         ATTRIBUTE_UNUSED_RESULT.
9737
9738 2019-03-05  Tom Tromey  <tromey@adacore.com>
9739
9740         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
9741         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
9742         ATTRIBUTE_UNUSED_RESULT.
9743
9744 2019-03-05  Tom Tromey  <tromey@adacore.com>
9745
9746         * common/scoped_fd.h (class scoped_fd) <release>: Add
9747         ATTRIBUTE_UNUSED_RESULT.
9748
9749 2019-03-05  Tom Tromey  <tromey@adacore.com>
9750
9751         * parser-defs.h (struct parser_state) <release>: Add
9752         ATTRIBUTE_UNUSED_RESULT.
9753
9754 2019-03-05  Tom Tromey  <tromey@adacore.com>
9755
9756         * utils.h (class gdb_argv) <release>: Add
9757         ATTRIBUTE_UNUSED_RESULT.
9758         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
9759
9760 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
9761
9762         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
9763         for-loop range, to avoid compiler warnings.
9764
9765         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
9766         avoid compiler warnings about unused variables.
9767
9768         * NEWS: Mention end of support for native debugging on MS-Windows
9769         before XP.
9770
9771         PR gdb/24292
9772         * common/netstuff.c:
9773         * gdbserver/gdbreplay.c
9774         * gdbserver/remote-utils.c:
9775         * ser-tcp.c:
9776         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
9777         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
9778         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
9779         'getaddrinfo' and 'freeaddrinfo' were not available before
9780         Windows XP, and mingw.org's MinGW headers by default define
9781         _WIN32_WINNT to 0x500.
9782
9783 2019-03-01  Gary Benson <gbenson@redhat.com>
9784
9785         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
9786
9787 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
9788             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
9789
9790         PR gdb/8527
9791         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
9792         set_sigint_trap, clear_sigint_trap.
9793
9794 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9795
9796         * target.c (target_detach): Clear the regcache and the
9797         frame cache.
9798
9799 2019-02-27  Pedro Alves  <palves@redhat.com>
9800
9801         * utils.c (set_screen_size): When we cap the height/width sizes,
9802         tweak the corresponding command variable to show "unlimited":
9803
9804 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
9805             Pedro Alves  <palves@redhat.com>
9806
9807         * utils.c (set_screen_size): Reduce "infinite" rows and columns
9808         before calling rl_set_screen_size.
9809
9810 2019-02-27  Tom Tromey  <tromey@adacore.com>
9811
9812         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
9813         define.
9814         * python/py-value.c: Remove Python 2.4 workaround.
9815         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
9816         workaround.
9817         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
9818         Python 2.4 workaround.
9819         * python/python-internal.h: Remove Python 2.4 comment.
9820         (Py_ssize_t): Don't define.
9821         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
9822         (gdb_Py_DECREF): Remove Python 2.4 workaround.
9823         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
9824         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
9825         * python/python.c (do_start_initialization): Remove Python 2.4
9826         workaround.
9827         * python/py-prettyprint.c (class dummy_python_frame): Remove.
9828         (print_children): Remove Python 2.4 workaround.
9829         * python/py-inferior.c (buffer_procs): Remove Python 2.4
9830         workaround.
9831         (CHARBUFFERPROC_NAME): Remove.
9832         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
9833         Python 2.4 workaround.
9834
9835 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9836
9837         * NEWS: Note minimum Python version.
9838
9839 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
9840
9841         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
9842         code from these functions.  Remove corresponding ifdefs.  Use
9843         Py_buffer_up instead of explicit calls to PyBuffer_Release.
9844         Remove gotos and target of gotos.
9845         (infpy_search_memory): Likewise.
9846
9847 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9848
9849         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
9850         (hppa_gdbarch_init): Don't register deleted functions with
9851         gdbarch.
9852
9853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9854
9855         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
9856         (h8300_unwind_sp): Delete.
9857         (h8300_dummy_id): Delete.
9858         (h8300_gdbarch_init): Don't register deleted functions with
9859         gdbarch.
9860
9861 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9862
9863         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
9864         (ft32_unwind_pc): Delete.
9865         (ft32_unwind_sp): Delete.
9866         (ft32_gdbarch_init): Don't register deleted functions with
9867         gdbarch.
9868
9869 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9870
9871         * gdb/frv-tdep.c (frv_dummy_id): Delete.
9872         (frv_unwind_pc): Delete.
9873         (frv_unwind_sp): Delete.
9874         (frv_gdbarch_init): Don't register deleted functions with
9875         gdbarch.
9876
9877 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9878
9879         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
9880         (riscv_unwind_pc): Delete.
9881         (riscv_unwind_sp): Delete.
9882         (riscv_gdbarch_init): Don't register deleted functions with
9883         gdbarch.
9884
9885 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9886
9887         * gdb/csky-tdep.c (csky_dummy_id): Delete.
9888         (csky_unwind_pc): Delete.
9889         (csky_unwind_sp): Delete.
9890         (csky_gdbarch_init): Don't register deleted functions with
9891         gdbarch.
9892
9893 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9894
9895         * gdb/cris-tdep.c (cris_dummy_id): Delete.
9896         (cris_unwind_pc): Delete.
9897         (cris_unwind_sp): Delete.
9898         (cris_gdbarch_init): Don't register deleted functions with
9899         gdbarch.
9900
9901 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9902
9903         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
9904         (bfin_unwind_pc): Delete.
9905         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
9906
9907 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9908
9909         * gdb/arm-tdep.c (arm_dummy_id): Delete.
9910         (arm_unwind_pc): Delete.
9911         (arm_unwind_sp): Delete.
9912         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
9913
9914 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9915
9916         * gdb/arc-tdep.c (arc_dummy_id): Delete.
9917         (arc_unwind_pc): Delete.
9918         (arc_unwind_sp): Delete.
9919         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
9920
9921 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9922
9923         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
9924         (alpha_unwind_pc): Delete.
9925         (alpha_gdbarch_init): Don't register deleted functions with
9926         gdbarch.
9927
9928 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9929
9930         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
9931         (aarch64_unwind_pc): Delete.
9932         (aarch64_unwind_sp): Delete.
9933         (aarch64_gdbarch_init): Don't register deleted functions with
9934         gdbarch.
9935
9936 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9937
9938         * gdbtypes.c (type_align): Don't consider static members when
9939         computing structure alignment.
9940
9941 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
9942
9943         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
9944         return 0 for other types.
9945         * arch-utils.c (default_type_align): Always return 0.
9946         * gdbarch.h: Regenerate.
9947         * gdbarch.sh (type_align): Extend comment.
9948         * gdbtypes.c (type_align): Add additional comments, always call
9949         gdbarch_type_align before applying the default rules.
9950         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
9951         generic code will then apply a suitable default.
9952         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
9953         types, return 0 for other types.
9954
9955 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9956
9957         * NEWS: Create a new section for the next release branch.
9958         Rename the section of the current branch, now that it has
9959         been cut.
9960
9961 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
9962
9963         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
9964         * version.in: Bump version to 8.3.50.DATE-git.
9965
9966 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
9967
9968         * aix-thread.c (ptid_cmp): Remove unused variable.
9969         (get_signaled_thread): Likewise.
9970         (store_regs_user_thread): Likewise.
9971         (store_regs_kernel_thread): Likewise.
9972         (fetch_regs_kernel_thread): Remove shadowed variable.
9973
9974 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9975
9976         * features/riscv/32bit-cpu.xml: Add register numbers.
9977         * features/riscv/32bit-fpu.c: Regenerate.
9978         * features/riscv/32bit-fpu.xml: Add register numbers.
9979         * features/riscv/64bit-cpu.xml: Add register numbers.
9980         * features/riscv/64bit-fpu.c: Regenerate.
9981         * features/riscv/64bit-fpu.xml: Add register numbers.
9982
9983 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
9984
9985         * NEWS: Mention two argument form of gdb.Value constructor.
9986         * python/py-value.c (convert_buffer_and_type_to_value): New
9987         function.
9988         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
9989         Add support for handling an optional second argument.  Call
9990         convert_buffer_and_type_to_value as appropriate.
9991         * python/python-internal.h (Py_buffer_deleter): New struct.
9992         (Py_buffer_up): New typedef.
9993
9994 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
9995
9996         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
9997         instead of releasing ownership.
9998
9999 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10000
10001         * dwarf2read.c (open_and_init_dwp_file): Call
10002         elf_numsections instead of bfd_count_sections to initialize
10003         dwp_file->num_sections.
10004
10005 2019-02-25  Tom Tromey  <tromey@adacore.com>
10006
10007         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10008
10009 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10010
10011         * gcore.in: Add '--readnever' option when invoking GDB.
10012
10013 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10014
10015         * MAINTAINERS: Update my email address.
10016
10017 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10018
10019         * build-id.c (build_id_to_debug_bfd_1): New function.
10020         (build_id_to_debug_bfd): Look for separate debug file in
10021         sysroot.
10022
10023 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10024
10025         * gdbarch.sh: Update the copyright year range that is placed into
10026         generated files.
10027
10028 2019-02-22  Keith Seitz  <keiths@redhat.com>
10029
10030         PR symtab/23853
10031         * linespec.c (create_sals_line_offset): Search for the default
10032         symtab's filename instead of its fullname.
10033
10034 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10035
10036         * NEWS: Update style defaults.
10037
10038 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10039
10040         * main.c (captured_main_1): Disable styling in batch mode.
10041
10042 2019-02-20  Tom Tromey  <tom@tromey.com>
10043
10044         * symtab.c (symtab_symbol_info): Fix typos.
10045
10046 2019-02-20  Tom Tromey  <tromey@adacore.com>
10047
10048         * findcmd.c (_initialize_mem_search): Use upper case for
10049         metasyntactic variables.
10050
10051 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10052
10053         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10054         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10055
10056 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10057
10058         * top.h (source_file_name): Change to std::string.
10059         * top.c (source_file_name): Likewise.
10060         (command_line_input): Adjust.
10061         * cli/cli-script.c (script_from_file): Adjust.
10062
10063 2019-02-19  Tom Tromey  <tromey@adacore.com>
10064
10065         * ravenscar-thread.c
10066         (ravenscar_thread_target::update_thread_list): Don't call
10067         ada_build_task_list.
10068         * ada-lang.h (ada_build_task_list): Don't declare.
10069         * ada-tasks.c (struct ada_tasks_inferior_data)
10070         <task_list_valid_p>: Now bool.
10071         (read_known_tasks, ada_task_list_changed)
10072         (ada_tasks_invalidate_inferior_data): Update.
10073         (read_known_tasks_array): Return bool.
10074         (read_known_tasks_list): Likewise.
10075         (read_known_tasks): Return void.
10076         (ada_build_task_list): Now static.
10077
10078 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10079
10080         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10081         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10082
10083 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10084
10085         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10086         variant for ada_tasks_pspace_data_handle and
10087         ada_tasks_inferior_data_handle.
10088         (ada_tasks_pspace_data_cleanup): New function.
10089         (ada_tasks_inferior_data_cleanup): New function.
10090
10091 2019-02-17  Tom Tromey  <tom@tromey.com>
10092
10093         * macrotab.h (macro_source_fullname): Return a std::string.
10094         * macrotab.c (macro_include, check_for_redefinition)
10095         (macro_undef, macro_lookup_definition, foreach_macro)
10096         (foreach_macro_in_scope): Update.
10097         (macro_source_fullname): Return a std::string.
10098         * macrocmd.c (show_pp_source_pos): Update.
10099
10100 2019-02-17  Tom Tromey  <tom@tromey.com>
10101
10102         * macrocmd.c (show_pp_source_pos): Style the file names.
10103
10104 2019-02-17  Tom Tromey  <tom@tromey.com>
10105
10106         PR tui/24197:
10107         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10108
10109 2019-02-17  Tom Tromey  <tom@tromey.com>
10110
10111         * ada-lang.c (user_select_syms): Use filtered printing.
10112         * utils.c (wrap_style): New global.
10113         (desired_style): Remove.
10114         (emit_style_escape): Add stream parameter.
10115         (set_output_style, reset_terminal_style, prompt_for_continue):
10116         Update.
10117         (flush_wrap_buffer): Only flush gdb_stdout.
10118         (wrap_here): Set wrap_style.
10119         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10120         treat escape sequences as a character.  Change when wrap buffer is
10121         flushed.
10122         (fputs_styled): Do not set the output style when the default is
10123         requested.
10124         * ui-style.h (struct ui_file_style) <is_default>: New method.
10125         * source.c (print_source_lines_base): Emit escape sequences in one
10126         piece.
10127
10128 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10129
10130         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10131         integers and enumeration types.
10132
10133 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10134
10135         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10136         instead of lookup_symbol_in_language
10137         (do_exact_match): New function.
10138         (ada_get_symbol_name_matcher): Return do_exact_match when
10139         doing a verbatim match.
10140
10141 2019-02-15  Tom Tromey  <tromey@adacore.com>
10142
10143         * ravenscar-thread.c (ravenscar_thread_target::resume)
10144         (ravenscar_thread_target::wait): Special case wildcard requests.
10145
10146 2019-02-15  Tom Tromey  <tromey@adacore.com>
10147
10148         * ravenscar-thread.c (base_ptid): Remove.
10149         (struct ravenscar_thread_target) <close>: New method.
10150         <m_base_ptid>: New member.
10151         <update_inferior_ptid, active_task, task_is_currently_active,
10152         runtime_initialized>: Declare methods.
10153         <ravenscar_thread_target>: Add constructor.
10154         (ravenscar_thread_target::task_is_currently_active)
10155         (ravenscar_thread_target::update_inferior_ptid)
10156         (ravenscar_runtime_initialized): Rename.  Now methods.
10157         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10158         (ravenscar_thread_target::update_thread_list): Update.
10159         (ravenscar_thread_target::active_task): Now method.
10160         (ravenscar_thread_target::store_registers)
10161         (ravenscar_thread_target::prepare_to_store)
10162         (ravenscar_thread_target::prepare_to_store)
10163         (ravenscar_thread_target::mourn_inferior): Update.
10164         (ravenscar_inferior_created): Use "new" to create target.
10165         (ravenscar_thread_target::get_ada_task_ptid): Update.
10166         (_initialize_ravenscar): Don't initialize base_ptid.
10167         (ravenscar_ops): Remove global.
10168
10169 2019-02-15  Tom Tromey  <tromey@adacore.com>
10170
10171         * target.h (push_target): Declare new overload.
10172         * target.c (push_target): New overload, taking an rvalue reference.
10173         * remote.c (remote_target::open_1): Use push_target overload.
10174         * corelow.c (core_target_open): Use push_target overload.
10175
10176 2019-02-15  Tom Tromey  <tromey@adacore.com>
10177
10178         * ravenscar-thread.c (is_ravenscar_task)
10179         (ravenscar_task_is_currently_active): Return bool.
10180         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10181         (_initialize_ravenscar): Remove "(void)".
10182         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10183         Return bool.
10184
10185 2019-02-15  Tom Tromey  <tromey@adacore.com>
10186
10187         * ravenscar-thread.c (ravenscar_runtime_initializer)
10188         (has_ravenscar_runtime, get_running_thread_id)
10189         (ravenscar_thread_target::resume): Fix indentation.
10190
10191 2019-02-15  Tom Tromey  <tromey@adacore.com>
10192
10193         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10194         from ravenscar_arch_ops.
10195         (sparc_ravenscar_ops::fetch_registers)
10196         (sparc_ravenscar_ops::store_registers): Now methods.
10197         (sparc_ravenscar_prepare_to_store): Remove.
10198         (sparc_ravenscar_ops): Redefine.
10199         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10200         methods and destructor.  Remove members.
10201         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10202         (ravenscar_thread_target::store_registers)
10203         (ravenscar_thread_target::prepare_to_store): Update.
10204         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10205         Remove.
10206         (struct ppc_ravenscar_powerpc_ops): Derive from
10207         ravenscar_arch_ops.
10208         (ppc_ravenscar_powerpc_ops::fetch_registers)
10209         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10210         (ppc_ravenscar_powerpc_ops): Redefine.
10211         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10212         (ppc_ravenscar_e500_ops::fetch_registers)
10213         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10214         (ppc_ravenscar_e500_ops): Redefine.
10215         * aarch64-ravenscar-thread.c
10216         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10217         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10218         (aarch64_ravenscar_fetch_registers)
10219         (aarch64_ravenscar_store_registers): Now methods.
10220         (aarch64_ravenscar_ops): Redefine.
10221
10222 2019-02-15  Tom Tromey  <tromey@adacore.com>
10223
10224         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10225         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10226         (ravenscar_thread_target::stopped_by_watchpoint)
10227         (ravenscar_thread_target::stopped_data_address)
10228         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10229
10230 2019-02-15  Tom Tromey  <tromey@adacore.com>
10231
10232         * ravenscar-thread.c: Fix some typos.
10233
10234 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10235             Tom Tromey  <tromey@adacore.com>
10236
10237         * ada-lang.c (ada_exception_sal): Change addr_string to a
10238         std::string.
10239         (create_ada_exception_catchpoint): Update.
10240
10241 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10242             Tom Tromey  <tromey@adacore.com>
10243
10244         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10245         (bp_location_ops): Remove.
10246         (base_breakpoint_allocate_location): Update.
10247         (free_bp_location): Update.
10248         * ada-lang.c (class ada_catchpoint_location)
10249         <ada_catchpoint_location>: Remove ops parameter.
10250         (ada_catchpoint_location_dtor): Remove.
10251         (ada_catchpoint_location_ops): Remove.
10252         (allocate_location_exception): Update.
10253         * breakpoint.h (struct bp_location_ops): Remove.
10254         (class bp_location) <bp_location>: Remove bp_location_ops
10255         parameter.
10256         <~bp_location>: Add destructor.
10257         <ops>: Remove.
10258
10259 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10260             Pedro Alves  <palves@redhat.com>
10261
10262         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10263         'PATH_MAX'.
10264
10265 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10266             Samuel Thibault  <samuel.thibault@gnu.org>
10267             Thomas Schwinge  <thomas@codesourcery.com>
10268
10269         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10270         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10271
10272 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10273
10274         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10275         (check_empty): Use "const char *".
10276
10277         * gnu-nat.c (gnu_nat_target::detach): Instead of
10278         'detach_inferior (pid)' call
10279         'detach_inferior (find_inferior_pid (pid))'.
10280
10281         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10282         'nat/fork-inferior.o'.
10283         * gnu-nat.c: #include "nat/fork-inferior.h".
10284
10285         * gnu-nat.c (gnu_nat_target::detach): Instead of
10286         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10287         * gnu-nat.h: #include "inf-child.h".
10288         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10289         'i386_gnu_nat_target::fetch_registers'.
10290         (gnu_store_registers): Rename/move to
10291         'i386_gnu_nat_target::store_registers'.
10292
10293         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10294         * gnu-nat.h (mach_thread_info): New function.
10295         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10296
10297         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10298
10299 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10300
10301         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10302
10303 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10304
10305         * windows-nat.c (windows_add_thread): Add new parameter
10306         "main_thread_p" with default value set to false.  Update
10307         function documentation as well as all callers.
10308         (windows_delete_thread): Likewise.
10309         (fake_create_process): Update call to windows_add_thread.
10310         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10311         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10312         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10313         call to windows_delete_thread.
10314
10315 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10316
10317         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10318
10319 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10320
10321         * symfile.c (find_separate_debug_file): Use canonical path of
10322         sysroot with child_path instead of gdb_sysroot if it is valid.
10323
10324 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10325
10326         * symfile.c (find_separate_debug_file): Use child_path to
10327         determine if an object file is under a sysroot.
10328
10329 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10330
10331         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10332         unittests/child-path-selftests.c.
10333         * common/pathstuff.c (child_path): New function.
10334         * common/pathstuff.h (child_path): New prototype.
10335         * unittests/child-path-selftests.c: New file.
10336
10337 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10338
10339         * symfile.c (find_separate_debug_file): Look for separate debug
10340         files in debug directories under the sysroot.
10341
10342 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10343
10344         * symtab.h (struct minimal_symbol data_p): New const method.
10345         (struct minimal_symbol text_p): Likewise.
10346         * symtab.c (output_source_filename): Use file name style
10347         to print file name.
10348         (print_symbol_info): Likewise.
10349         (print_msymbol_info): Use address style to print addresses.
10350         Use function name style to print executable text symbols.
10351         (expand_symtab_containing_pc): Use data_p.
10352         (find_pc_sect_compunit_symtab): Likewise.
10353
10354 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10355
10356         * breakpoint.c (describe_other_breakpoints): Use address style
10357         to print addresses.
10358         (say_where): Likewise.
10359
10360 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10361
10362         * ada-typeprint.c (print_func_type): Print function name
10363         style to print function name.
10364         * c-typeprint.c (c_print_type_1): Likewise.
10365
10366 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10367
10368         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10369         for execve.
10370
10371 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10372
10373         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10374         type_stack.
10375
10376 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
10377
10378         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
10379         TYPE_CODE_REF types.
10380
10381 2019-02-08  Jim Wilson  <jimw@sifive.com>
10382
10383         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
10384         (riscv_linux_fregset): New.
10385         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
10386
10387 2019-02-07  Tom Tromey  <tom@tromey.com>
10388
10389         * thread.c (thread_cancel_execution_command): Update.
10390         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
10391         methods.
10392         (struct thread_fsm_ops): Remove.
10393         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
10394         (thread_fsm_should_stop, thread_fsm_return_value)
10395         (thread_fsm_set_finished, thread_fsm_finished_p)
10396         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
10397         Don't declare.
10398         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
10399         * infrun.c (clear_proceed_status_thread)
10400         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
10401         (print_stop_event): Update.
10402         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
10403         Add constructor.
10404         (step_command_fsm_ops): Remove.
10405         (new_step_command_fsm): Remove.
10406         (step_1): Update.
10407         (step_command_fsm::should_stop): Rename from
10408         step_command_fsm_should_stop.
10409         (step_command_fsm::clean_up): Rename from
10410         step_command_fsm_clean_up.
10411         (step_command_fsm::do_async_reply_reason): Rename from
10412         step_command_fsm_async_reply_reason.
10413         (struct until_next_fsm): Inherit from thread_fsm.  Add
10414         constructor.
10415         (until_next_fsm_ops): Remove.
10416         (new_until_next_fsm): Remove.
10417         (until_next_fsm::should_stop): Rename from
10418         until_next_fsm_should_stop.
10419         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
10420         (until_next_fsm::do_async_reply_reason): Rename from
10421         until_next_fsm_async_reply_reason.
10422         (struct finish_command_fsm): Inherit from thread_fsm.  Add
10423         constructor.  Change type of breakpoint.
10424         (finish_command_fsm_ops): Remove.
10425         (new_finish_command_fsm): Remove.
10426         (finish_command_fsm::should_stop): Rename from
10427         finish_command_fsm_should_stop.
10428         (finish_command_fsm::clean_up): Rename from
10429         finish_command_fsm_clean_up.
10430         (finish_command_fsm::return_value): Rename from
10431         finish_command_fsm_return_value.
10432         (finish_command_fsm::do_async_reply_reason): Rename from
10433         finish_command_fsm_async_reply_reason.
10434         (finish_command): Update.
10435         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
10436         Add constructor.
10437         (call_thread_fsm_ops): Remove.
10438         (call_thread_fsm::call_thread_fsm): Rename from
10439         new_call_thread_fsm.
10440         (call_thread_fsm::should_stop): Rename from
10441         call_thread_fsm_should_stop.
10442         (call_thread_fsm::should_notify_stop): Rename from
10443         call_thread_fsm_should_notify_stop.
10444         (run_inferior_call, call_function_by_hand_dummy): Update.
10445         * cli/cli-interp.c (should_print_stop_to_console): Update.
10446         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
10447         Add constructor.  Change type of location_breakpoint,
10448         caller_breakpoint.
10449         (until_break_fsm_ops): Remove.
10450         (new_until_break_fsm): Remove.
10451         (until_break_fsm::should_stop): Rename from
10452         until_break_fsm_should_stop.
10453         (until_break_fsm::clean_up): Rename from
10454         until_break_fsm_clean_up.
10455         (until_break_fsm::do_async_reply_reason): Rename from
10456         until_break_fsm_async_reply_reason.
10457         (until_break_command): Update.
10458         * thread-fsm.c: Remove.
10459         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
10460
10461 2019-02-07  Tom Tromey  <tom@tromey.com>
10462
10463         * yy-remap.h: Add include guard.
10464         * xtensa-tdep.h: Add include guard.
10465         * xcoffread.h: Rename include guard.
10466         * varobj-iter.h: Add include guard.
10467         * tui/tui.h: Rename include guard.
10468         * tui/tui-winsource.h: Rename include guard.
10469         * tui/tui-wingeneral.h: Rename include guard.
10470         * tui/tui-windata.h: Rename include guard.
10471         * tui/tui-win.h: Rename include guard.
10472         * tui/tui-stack.h: Rename include guard.
10473         * tui/tui-source.h: Rename include guard.
10474         * tui/tui-regs.h: Rename include guard.
10475         * tui/tui-out.h: Rename include guard.
10476         * tui/tui-layout.h: Rename include guard.
10477         * tui/tui-io.h: Rename include guard.
10478         * tui/tui-hooks.h: Rename include guard.
10479         * tui/tui-file.h: Rename include guard.
10480         * tui/tui-disasm.h: Rename include guard.
10481         * tui/tui-data.h: Rename include guard.
10482         * tui/tui-command.h: Rename include guard.
10483         * tic6x-tdep.h: Add include guard.
10484         * target/waitstatus.h: Rename include guard.
10485         * target/wait.h: Rename include guard.
10486         * target/target.h: Rename include guard.
10487         * target/resume.h: Rename include guard.
10488         * target-float.h: Rename include guard.
10489         * stabsread.h: Add include guard.
10490         * rs6000-tdep.h: Add include guard.
10491         * riscv-fbsd-tdep.h: Add include guard.
10492         * regformats/regdef.h: Rename include guard.
10493         * record.h: Rename include guard.
10494         * python/python.h: Rename include guard.
10495         * python/python-internal.h: Rename include guard.
10496         * python/py-stopevent.h: Rename include guard.
10497         * python/py-ref.h: Rename include guard.
10498         * python/py-record.h: Rename include guard.
10499         * python/py-record-full.h: Rename include guard.
10500         * python/py-record-btrace.h: Rename include guard.
10501         * python/py-instruction.h: Rename include guard.
10502         * python/py-events.h: Rename include guard.
10503         * python/py-event.h: Rename include guard.
10504         * procfs.h: Add include guard.
10505         * proc-utils.h: Add include guard.
10506         * p-lang.h: Add include guard.
10507         * or1k-tdep.h: Rename include guard.
10508         * observable.h: Rename include guard.
10509         * nto-tdep.h: Rename include guard.
10510         * nat/x86-linux.h: Rename include guard.
10511         * nat/x86-linux-dregs.h: Rename include guard.
10512         * nat/x86-gcc-cpuid.h: Add include guard.
10513         * nat/x86-dregs.h: Rename include guard.
10514         * nat/x86-cpuid.h: Rename include guard.
10515         * nat/ppc-linux.h: Rename include guard.
10516         * nat/mips-linux-watch.h: Rename include guard.
10517         * nat/linux-waitpid.h: Rename include guard.
10518         * nat/linux-ptrace.h: Rename include guard.
10519         * nat/linux-procfs.h: Rename include guard.
10520         * nat/linux-osdata.h: Rename include guard.
10521         * nat/linux-nat.h: Rename include guard.
10522         * nat/linux-namespaces.h: Rename include guard.
10523         * nat/linux-btrace.h: Rename include guard.
10524         * nat/glibc_thread_db.h: Rename include guard.
10525         * nat/gdb_thread_db.h: Rename include guard.
10526         * nat/gdb_ptrace.h: Rename include guard.
10527         * nat/fork-inferior.h: Rename include guard.
10528         * nat/amd64-linux-siginfo.h: Rename include guard.
10529         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
10530         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
10531         * nat/aarch64-linux.h: Rename include guard.
10532         * nat/aarch64-linux-hw-point.h: Rename include guard.
10533         * mn10300-tdep.h: Add include guard.
10534         * mips-linux-tdep.h: Add include guard.
10535         * mi/mi-parse.h: Rename include guard.
10536         * mi/mi-out.h: Rename include guard.
10537         * mi/mi-main.h: Rename include guard.
10538         * mi/mi-interp.h: Rename include guard.
10539         * mi/mi-getopt.h: Rename include guard.
10540         * mi/mi-console.h: Rename include guard.
10541         * mi/mi-common.h: Rename include guard.
10542         * mi/mi-cmds.h: Rename include guard.
10543         * mi/mi-cmd-break.h: Rename include guard.
10544         * m2-lang.h: Add include guard.
10545         * location.h: Rename include guard.
10546         * linux-record.h: Rename include guard.
10547         * linux-nat.h: Add include guard.
10548         * linux-fork.h: Add include guard.
10549         * i386-darwin-tdep.h: Rename include guard.
10550         * hppa-linux-offsets.h: Add include guard.
10551         * guile/guile.h: Rename include guard.
10552         * guile/guile-internal.h: Rename include guard.
10553         * gnu-nat.h: Rename include guard.
10554         * gdb-stabs.h: Rename include guard.
10555         * frv-tdep.h: Add include guard.
10556         * f-lang.h: Add include guard.
10557         * event-loop.h: Add include guard.
10558         * darwin-nat.h: Rename include guard.
10559         * cp-abi.h: Rename include guard.
10560         * config/sparc/nm-sol2.h: Rename include guard.
10561         * config/nm-nto.h: Rename include guard.
10562         * config/nm-linux.h: Add include guard.
10563         * config/i386/nm-i386gnu.h: Rename include guard.
10564         * config/djgpp/nl_types.h: Rename include guard.
10565         * config/djgpp/langinfo.h: Rename include guard.
10566         * compile/gcc-cp-plugin.h: Add include guard.
10567         * compile/gcc-c-plugin.h: Add include guard.
10568         * compile/compile.h: Rename include guard.
10569         * compile/compile-object-run.h: Rename include guard.
10570         * compile/compile-object-load.h: Rename include guard.
10571         * compile/compile-internal.h: Rename include guard.
10572         * compile/compile-cplus.h: Rename include guard.
10573         * compile/compile-c.h: Rename include guard.
10574         * common/xml-utils.h: Rename include guard.
10575         * common/x86-xstate.h: Rename include guard.
10576         * common/version.h: Rename include guard.
10577         * common/vec.h: Rename include guard.
10578         * common/tdesc.h: Rename include guard.
10579         * common/selftest.h: Rename include guard.
10580         * common/scoped_restore.h: Rename include guard.
10581         * common/scoped_mmap.h: Rename include guard.
10582         * common/scoped_fd.h: Rename include guard.
10583         * common/safe-iterator.h: Rename include guard.
10584         * common/run-time-clock.h: Rename include guard.
10585         * common/refcounted-object.h: Rename include guard.
10586         * common/queue.h: Rename include guard.
10587         * common/ptid.h: Rename include guard.
10588         * common/print-utils.h: Rename include guard.
10589         * common/preprocessor.h: Rename include guard.
10590         * common/pathstuff.h: Rename include guard.
10591         * common/observable.h: Rename include guard.
10592         * common/netstuff.h: Rename include guard.
10593         * common/job-control.h: Rename include guard.
10594         * common/host-defs.h: Rename include guard.
10595         * common/gdb_wait.h: Rename include guard.
10596         * common/gdb_vecs.h: Rename include guard.
10597         * common/gdb_unlinker.h: Rename include guard.
10598         * common/gdb_unique_ptr.h: Rename include guard.
10599         * common/gdb_tilde_expand.h: Rename include guard.
10600         * common/gdb_sys_time.h: Rename include guard.
10601         * common/gdb_string_view.h: Rename include guard.
10602         * common/gdb_splay_tree.h: Rename include guard.
10603         * common/gdb_setjmp.h: Rename include guard.
10604         * common/gdb_ref_ptr.h: Rename include guard.
10605         * common/gdb_optional.h: Rename include guard.
10606         * common/gdb_locale.h: Rename include guard.
10607         * common/gdb_assert.h: Rename include guard.
10608         * common/filtered-iterator.h: Rename include guard.
10609         * common/filestuff.h: Rename include guard.
10610         * common/fileio.h: Rename include guard.
10611         * common/environ.h: Rename include guard.
10612         * common/common-utils.h: Rename include guard.
10613         * common/common-types.h: Rename include guard.
10614         * common/common-regcache.h: Rename include guard.
10615         * common/common-inferior.h: Rename include guard.
10616         * common/common-gdbthread.h: Rename include guard.
10617         * common/common-exceptions.h: Rename include guard.
10618         * common/common-defs.h: Rename include guard.
10619         * common/common-debug.h: Rename include guard.
10620         * common/cleanups.h: Rename include guard.
10621         * common/buffer.h: Rename include guard.
10622         * common/btrace-common.h: Rename include guard.
10623         * common/break-common.h: Rename include guard.
10624         * cli/cli-utils.h: Rename include guard.
10625         * cli/cli-style.h: Rename include guard.
10626         * cli/cli-setshow.h: Rename include guard.
10627         * cli/cli-script.h: Rename include guard.
10628         * cli/cli-interp.h: Rename include guard.
10629         * cli/cli-decode.h: Rename include guard.
10630         * cli/cli-cmds.h: Rename include guard.
10631         * charset-list.h: Add include guard.
10632         * buildsym-legacy.h: Rename include guard.
10633         * bfin-tdep.h: Add include guard.
10634         * ax.h: Rename include guard.
10635         * arm-linux-tdep.h: Add include guard.
10636         * arm-fbsd-tdep.h: Add include guard.
10637         * arch/xtensa.h: Rename include guard.
10638         * arch/tic6x.h: Add include guard.
10639         * arch/i386.h: Add include guard.
10640         * arch/arm.h: Rename include guard.
10641         * arch/arm-linux.h: Rename include guard.
10642         * arch/arm-get-next-pcs.h: Rename include guard.
10643         * arch/amd64.h: Add include guard.
10644         * arch/aarch64-insn.h: Rename include guard.
10645         * arch-utils.h: Rename include guard.
10646         * annotate.h: Add include guard.
10647         * amd64-darwin-tdep.h: Rename include guard.
10648         * aarch64-linux-tdep.h: Add include guard.
10649         * aarch64-fbsd-tdep.h: Add include guard.
10650         * aarch32-linux-nat.h: Add include guard.
10651
10652 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10653
10654         * macrotab.c (macro_define_internal): New function that
10655         factorizes macro_define_object_internal and macro_define_function
10656         code.
10657         (macro_define_object_internal): Use macro_define_internal.
10658         (macro_define_function): Likewise.
10659
10660 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10661
10662         * macrocmd.c (extract_identifier): Return
10663         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
10664         callers.
10665
10666 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
10667
10668         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
10669
10670 2019-02-05  Tom Tromey  <tom@tromey.com>
10671
10672         * target.c (target_stack::unpush): Move assertion earlier.
10673
10674 2019-01-30  Tom Tromey  <tom@tromey.com>
10675
10676         PR python/23615:
10677         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
10678         (gdbpy_parse_and_eval): Likewise.
10679         * python/python-internal.h (gdbpy_allow_threads): New class.
10680
10681 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
10682
10683         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
10684         (aarch64_fbsd_fpregmap): Move earlier.
10685         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
10686         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10687         instead of individual calls to trad_frame_set_reg_addr.
10688         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
10689         earlier.
10690         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
10691         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
10692         instead of individual calls to trad_frame_set_reg_addr.
10693
10694 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
10695
10696         * CONTRIBUTE: Replace contribution list with wiki link.
10697
10698 2019-01-25  Tom Tromey  <tom@tromey.com>
10699
10700         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
10701
10702 2019-01-25  Tom Tromey  <tom@tromey.com>
10703
10704         * xtensa-linux-nat.c: Fix common/ includes.
10705         * xml-support.h: Fix common/ includes.
10706         * xml-support.c: Fix common/ includes.
10707         * x86-linux-nat.c: Fix common/ includes.
10708         * windows-nat.c: Fix common/ includes.
10709         * varobj.h: Fix common/ includes.
10710         * varobj.c: Fix common/ includes.
10711         * value.c: Fix common/ includes.
10712         * valops.c: Fix common/ includes.
10713         * utils.c: Fix common/ includes.
10714         * unittests/xml-utils-selftests.c: Fix common/ includes.
10715         * unittests/utils-selftests.c: Fix common/ includes.
10716         * unittests/unpack-selftests.c: Fix common/ includes.
10717         * unittests/tracepoint-selftests.c: Fix common/ includes.
10718         * unittests/style-selftests.c: Fix common/ includes.
10719         * unittests/string_view-selftests.c: Fix common/ includes.
10720         * unittests/scoped_restore-selftests.c: Fix common/ includes.
10721         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
10722         * unittests/scoped_fd-selftests.c: Fix common/ includes.
10723         * unittests/rsp-low-selftests.c: Fix common/ includes.
10724         * unittests/parse-connection-spec-selftests.c: Fix common/
10725         includes.
10726         * unittests/optional-selftests.c: Fix common/ includes.
10727         * unittests/offset-type-selftests.c: Fix common/ includes.
10728         * unittests/observable-selftests.c: Fix common/ includes.
10729         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
10730         * unittests/memrange-selftests.c: Fix common/ includes.
10731         * unittests/memory-map-selftests.c: Fix common/ includes.
10732         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
10733         * unittests/function-view-selftests.c: Fix common/ includes.
10734         * unittests/environ-selftests.c: Fix common/ includes.
10735         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
10736         * unittests/common-utils-selftests.c: Fix common/ includes.
10737         * unittests/cli-utils-selftests.c: Fix common/ includes.
10738         * unittests/array-view-selftests.c: Fix common/ includes.
10739         * ui-file.c: Fix common/ includes.
10740         * tui/tui-io.c: Fix common/ includes.
10741         * tracepoint.h: Fix common/ includes.
10742         * tracepoint.c: Fix common/ includes.
10743         * tracefile-tfile.c: Fix common/ includes.
10744         * top.h: Fix common/ includes.
10745         * top.c: Fix common/ includes.
10746         * thread.c: Fix common/ includes.
10747         * target/waitstatus.h: Fix common/ includes.
10748         * target/waitstatus.c: Fix common/ includes.
10749         * target.h: Fix common/ includes.
10750         * target.c: Fix common/ includes.
10751         * target-memory.c: Fix common/ includes.
10752         * target-descriptions.c: Fix common/ includes.
10753         * symtab.h: Fix common/ includes.
10754         * symfile.c: Fix common/ includes.
10755         * stap-probe.c: Fix common/ includes.
10756         * spu-linux-nat.c: Fix common/ includes.
10757         * sparc-nat.c: Fix common/ includes.
10758         * source.c: Fix common/ includes.
10759         * solib.c: Fix common/ includes.
10760         * solib-target.c: Fix common/ includes.
10761         * ser-unix.c: Fix common/ includes.
10762         * ser-tcp.c: Fix common/ includes.
10763         * ser-pipe.c: Fix common/ includes.
10764         * ser-base.c: Fix common/ includes.
10765         * selftest-arch.c: Fix common/ includes.
10766         * s12z-tdep.c: Fix common/ includes.
10767         * rust-exp.y: Fix common/ includes.
10768         * rs6000-aix-tdep.c: Fix common/ includes.
10769         * riscv-tdep.c: Fix common/ includes.
10770         * remote.c: Fix common/ includes.
10771         * remote-notif.h: Fix common/ includes.
10772         * remote-fileio.h: Fix common/ includes.
10773         * remote-fileio.c: Fix common/ includes.
10774         * regcache.h: Fix common/ includes.
10775         * regcache.c: Fix common/ includes.
10776         * record-btrace.c: Fix common/ includes.
10777         * python/python.c: Fix common/ includes.
10778         * python/py-type.c: Fix common/ includes.
10779         * python/py-inferior.c: Fix common/ includes.
10780         * progspace.h: Fix common/ includes.
10781         * producer.c: Fix common/ includes.
10782         * procfs.c: Fix common/ includes.
10783         * proc-api.c: Fix common/ includes.
10784         * printcmd.c: Fix common/ includes.
10785         * ppc-linux-nat.c: Fix common/ includes.
10786         * parser-defs.h: Fix common/ includes.
10787         * osdata.c: Fix common/ includes.
10788         * obsd-nat.c: Fix common/ includes.
10789         * nat/x86-linux.c: Fix common/ includes.
10790         * nat/x86-linux-dregs.c: Fix common/ includes.
10791         * nat/x86-dregs.h: Fix common/ includes.
10792         * nat/x86-dregs.c: Fix common/ includes.
10793         * nat/ppc-linux.c: Fix common/ includes.
10794         * nat/mips-linux-watch.h: Fix common/ includes.
10795         * nat/mips-linux-watch.c: Fix common/ includes.
10796         * nat/linux-waitpid.c: Fix common/ includes.
10797         * nat/linux-ptrace.h: Fix common/ includes.
10798         * nat/linux-ptrace.c: Fix common/ includes.
10799         * nat/linux-procfs.c: Fix common/ includes.
10800         * nat/linux-personality.c: Fix common/ includes.
10801         * nat/linux-osdata.c: Fix common/ includes.
10802         * nat/linux-namespaces.c: Fix common/ includes.
10803         * nat/linux-btrace.h: Fix common/ includes.
10804         * nat/linux-btrace.c: Fix common/ includes.
10805         * nat/fork-inferior.c: Fix common/ includes.
10806         * nat/amd64-linux-siginfo.c: Fix common/ includes.
10807         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
10808         * nat/aarch64-linux.c: Fix common/ includes.
10809         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
10810         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
10811         * namespace.h: Fix common/ includes.
10812         * mips-linux-tdep.c: Fix common/ includes.
10813         * minsyms.c: Fix common/ includes.
10814         * mi/mi-parse.h: Fix common/ includes.
10815         * mi/mi-main.c: Fix common/ includes.
10816         * mi/mi-cmd-env.c: Fix common/ includes.
10817         * memrange.h: Fix common/ includes.
10818         * memattr.c: Fix common/ includes.
10819         * maint.h: Fix common/ includes.
10820         * maint.c: Fix common/ includes.
10821         * main.c: Fix common/ includes.
10822         * machoread.c: Fix common/ includes.
10823         * location.c: Fix common/ includes.
10824         * linux-thread-db.c: Fix common/ includes.
10825         * linux-nat.c: Fix common/ includes.
10826         * linux-fork.c: Fix common/ includes.
10827         * inline-frame.c: Fix common/ includes.
10828         * infrun.c: Fix common/ includes.
10829         * inflow.c: Fix common/ includes.
10830         * inferior.h: Fix common/ includes.
10831         * inferior.c: Fix common/ includes.
10832         * infcmd.c: Fix common/ includes.
10833         * inf-ptrace.c: Fix common/ includes.
10834         * inf-child.c: Fix common/ includes.
10835         * ia64-linux-nat.c: Fix common/ includes.
10836         * i387-tdep.c: Fix common/ includes.
10837         * i386-tdep.c: Fix common/ includes.
10838         * i386-linux-tdep.c: Fix common/ includes.
10839         * i386-linux-nat.c: Fix common/ includes.
10840         * i386-go32-tdep.c: Fix common/ includes.
10841         * i386-fbsd-tdep.c: Fix common/ includes.
10842         * i386-fbsd-nat.c: Fix common/ includes.
10843         * guile/scm-type.c: Fix common/ includes.
10844         * guile/guile.c: Fix common/ includes.
10845         * go32-nat.c: Fix common/ includes.
10846         * gnu-nat.c: Fix common/ includes.
10847         * gdbthread.h: Fix common/ includes.
10848         * gdbarch-selftests.c: Fix common/ includes.
10849         * gdb_usleep.c: Fix common/ includes.
10850         * gdb_select.h: Fix common/ includes.
10851         * gdb_bfd.c: Fix common/ includes.
10852         * gcore.c: Fix common/ includes.
10853         * fork-child.c: Fix common/ includes.
10854         * findvar.c: Fix common/ includes.
10855         * fbsd-nat.c: Fix common/ includes.
10856         * event-top.c: Fix common/ includes.
10857         * event-loop.c: Fix common/ includes.
10858         * dwarf2read.c: Fix common/ includes.
10859         * dwarf2loc.c: Fix common/ includes.
10860         * dwarf2-frame.c: Fix common/ includes.
10861         * dwarf-index-cache.c: Fix common/ includes.
10862         * dtrace-probe.c: Fix common/ includes.
10863         * disasm-selftests.c: Fix common/ includes.
10864         * defs.h: Fix common/ includes.
10865         * csky-tdep.c: Fix common/ includes.
10866         * cp-valprint.c: Fix common/ includes.
10867         * cp-support.h: Fix common/ includes.
10868         * cp-support.c: Fix common/ includes.
10869         * corelow.c: Fix common/ includes.
10870         * completer.h: Fix common/ includes.
10871         * completer.c: Fix common/ includes.
10872         * compile/compile.c: Fix common/ includes.
10873         * compile/compile-loc2c.c: Fix common/ includes.
10874         * compile/compile-cplus-types.c: Fix common/ includes.
10875         * compile/compile-cplus-symbols.c: Fix common/ includes.
10876         * command.h: Fix common/ includes.
10877         * cli/cli-dump.c: Fix common/ includes.
10878         * cli/cli-cmds.c: Fix common/ includes.
10879         * charset.c: Fix common/ includes.
10880         * build-id.c: Fix common/ includes.
10881         * btrace.h: Fix common/ includes.
10882         * btrace.c: Fix common/ includes.
10883         * breakpoint.h: Fix common/ includes.
10884         * breakpoint.c: Fix common/ includes.
10885         * ax.h:
10886         (enum agent_op): Fix common/ includes.
10887         * ax-general.c (struct aop_map): Fix common/ includes.
10888         * ax-gdb.c: Fix common/ includes.
10889         * auxv.c: Fix common/ includes.
10890         * auto-load.c: Fix common/ includes.
10891         * arm-tdep.c: Fix common/ includes.
10892         * arch/riscv.c: Fix common/ includes.
10893         * arch/ppc-linux-common.c: Fix common/ includes.
10894         * arch/i386.c: Fix common/ includes.
10895         * arch/arm.c: Fix common/ includes.
10896         * arch/arm-linux.c: Fix common/ includes.
10897         * arch/arm-get-next-pcs.c: Fix common/ includes.
10898         * arch/amd64.c: Fix common/ includes.
10899         * arch/aarch64.c: Fix common/ includes.
10900         * arch/aarch64-insn.c: Fix common/ includes.
10901         * arch-utils.c: Fix common/ includes.
10902         * amd64-windows-tdep.c: Fix common/ includes.
10903         * amd64-tdep.c: Fix common/ includes.
10904         * amd64-sol2-tdep.c: Fix common/ includes.
10905         * amd64-obsd-tdep.c: Fix common/ includes.
10906         * amd64-nbsd-tdep.c: Fix common/ includes.
10907         * amd64-linux-tdep.c: Fix common/ includes.
10908         * amd64-linux-nat.c: Fix common/ includes.
10909         * amd64-fbsd-tdep.c: Fix common/ includes.
10910         * amd64-fbsd-nat.c: Fix common/ includes.
10911         * amd64-dicos-tdep.c: Fix common/ includes.
10912         * amd64-darwin-tdep.c: Fix common/ includes.
10913         * agent.c: Fix common/ includes.
10914         * ada-lang.h: Fix common/ includes.
10915         * ada-lang.c: Fix common/ includes.
10916         * aarch64-tdep.c: Fix common/ includes.
10917
10918 2019-01-25  Tom Tromey  <tom@tromey.com>
10919
10920         * common/create-version.sh: Use common/version.h.
10921
10922 2019-01-24  Pedro Alves  <palves@redhat.com>
10923
10924         * infrun.c (signal_stop, signal_print, signal_program)
10925         (signal_catch, signal_pass): Now arrays instead of pointers.
10926         (update_signals_program_target, do_target_resume)
10927         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
10928         * linux-nat.c (linux_nat_target::pass_signals)
10929         (linux_nat_target::create_inferior, linux_nat_target::attach):
10930         Adjust.
10931         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
10932         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
10933         * procfs.c (procfs_target::pass_signals): Adjust.
10934         * record-full.c (record_full_target::resume): Adjust.
10935         * remote.c (remote_target::pass_signals)
10936         (remote_target::program_signals): Adjust.
10937         * target-debug.h (target_debug_print_signals): Now takes a
10938         gdb::array_view as parameter.  Adjust.
10939         * target.h (target_ops) <pass_signals, program_signals>: Replace
10940         pointer and length parameters with gdb::array_view.
10941         (target_pass_signals, target_program_signals): Likewise.
10942         * target-delegates.c: Regenerate.
10943
10944 2019-01-24  Pedro Alves  <palves@redhat.com>
10945
10946         * common/forward-scope-exit.h
10947         (forward_scope_exit::forward_scope_exit): Pass arguments to
10948         m_bind_function directly, instead of creating a std::bind and
10949         copying that.
10950
10951 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
10952
10953         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
10954         for static members.
10955         (pass_in_v_vfp_candidate): Likewise.
10956
10957 2019-01-23  Tom Tromey  <tom@tromey.com>
10958             Pedro Alves  <palves@redhat.com>
10959
10960         * regcache.c (class regcache_invalidator): Remove.
10961         (regcache::raw_write): Use make_scope_exit.
10962
10963 2019-01-23  Tom Tromey  <tom@tromey.com>
10964
10965         * ui-out.h (class ui_out_emit_type): Update comment.
10966
10967 2019-01-23  Tom Tromey  <tom@tromey.com>
10968
10969         * infrun.c (fetch_inferior_event): Update comment.
10970
10971 2019-01-23  Tom Tromey  <tom@tromey.com>
10972             Pedro Alves  <palves@redhat.com>
10973
10974         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
10975         parameter.
10976         (fetch_inferior_event): Use SCOPE_EXIT.
10977
10978
10979 2019-01-23  Tom Tromey  <tom@tromey.com>
10980             Pedro Alves  <palves@redhat.com>
10981
10982         * infrun.c (disable_thread_events): Delete.
10983         (stop_all_threads): Use SCOPE_EXIT.
10984
10985 2019-01-23  Tom Tromey  <tom@tromey.com>
10986             Pedro Alves  <palves@redhat.com>
10987
10988         * symfile.c: Include forward-scope-exit.h.
10989         (clear_symtab_users_cleanup): Replace forward declaration with
10990         a FORWARD_SCOPE_EXIT.
10991         (syms_from_objfile_1): Use the forward_scope_exit and
10992         gdb::optional instead of cleanup_function.
10993         (reread_symbols): Use the forward_scope_exit instead of
10994         cleanup_function.
10995         (clear_symtab_users_cleanup): Remove function.
10996
10997 2019-01-23  Tom Tromey  <tom@tromey.com>
10998             Pedro Alves  <palves@redhat.com>
10999
11000         * linux-nat.c: Include scope-exit.h.
11001         (cleanup_target_stop): Remove.
11002         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11003         SCOPE_EXIT.
11004
11005 2019-01-23  Tom Tromey  <tom@tromey.com>
11006             Pedro Alves  <palves@redhat.com>
11007
11008         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11009         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11010
11011 2019-01-23  Tom Tromey  <tom@tromey.com>
11012             Andrew Burgess  <andrew.burgess@embecosm.com>
11013             Pedro Alves  <palves@redhat.com>
11014
11015         * infrun.c (fetch_inferior_event): Use scope_exit.
11016         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11017         * top.c (execute_command): Use scope_exit.
11018         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11019         * utils.c (do_bpstat_clear_actions_cleanup)
11020         (make_bpstat_clear_actions_cleanup): Remove.
11021
11022 2019-01-23  Tom Tromey  <tom@tromey.com>
11023             Pedro Alves  <palves@redhat.com>
11024
11025         * infrun.c: Include "common/scope-exit.h"
11026         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11027         (wait_for_inferior): Use SCOPE_EXIT.
11028         (fetch_inferior_event): Use scope_exit.
11029
11030 2019-01-23  Tom Tromey  <tom@tromey.com>
11031             Pedro Alves  <palves@redhat.com>
11032
11033         * breakpoint.c (create_breakpoint): Remove cleanup.
11034
11035 2019-01-23  Tom Tromey  <tom@tromey.com>
11036             Andrew Burgess  <andrew.burgess@embecosm.com>
11037             Pedro Alves  <palves@redhat.com>
11038
11039 2019-01-23  Pedro Alves  <palves@redhat.com>
11040
11041         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11042
11043 2019-01-23  Pedro Alves  <palves@redhat.com>
11044             Andrew Burgess  <andrew.burgess@embecosm.com>
11045
11046         * gdbthread.h: Include "common/forward-scope-exit.h".
11047         (scoped_finish_thread_state): Redefine custom class in terms of
11048         forward_scope_exit.
11049
11050 2019-01-23  Pedro Alves  <palves@redhat.com>
11051             Andrew Burgess  <andrew.burgess@embecosm.com>
11052
11053         * common/forward-scope-exit.h: New file.
11054
11055 2019-01-23  Pedro Alves  <palves@redhat.com>
11056             Andrew Burgess  <andrew.burgess@embecosm.com>
11057             Tom Tromey  <tom@tromey.com>
11058
11059         * common/scope-exit.h: New file.
11060
11061 2019-01-23  Pedro Alves  <palves@redhat.com>
11062
11063         * common/preprocessor.h (ESC): Rename to ...
11064         (ESC_PARENS): ... this.
11065         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11066         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11067
11068 2019-01-23  Tom Tromey  <tom@tromey.com>
11069
11070         * language.h (class scoped_switch_to_sym_language_if_auto):
11071         Initialize m_lang in both cases.
11072
11073 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11074
11075         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11076         with XCNEW.
11077
11078 2019-01-22  Tom Tromey  <tom@tromey.com>
11079
11080         * corelow.c: Do not include sys/file.h.
11081
11082 2019-01-22  Tom Tromey  <tom@tromey.com>
11083
11084         * tui/tui-wingeneral.h: Include gdb_curses.h.
11085
11086 2019-01-22  Tom Tromey  <tom@tromey.com>
11087
11088         * source-cache.h (class source_cache) <get_source_lines,
11089         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11090
11091 2019-01-22  Tom Tromey  <tom@tromey.com>
11092
11093         * remote-fileio.h (struct remote_target): Declare.
11094
11095 2019-01-22  Tom Tromey  <tom@tromey.com>
11096
11097         * python/py-arch.c: Do not include py-ref.h.
11098         * python/py-bpevent.c: Do not include py-ref.h.
11099         * python/py-cmd.c: Do not include py-ref.h.
11100         * python/py-continueevent.c: Do not include py-ref.h.
11101         * python/py-event.h: Do not include py-ref.h.
11102         * python/py-evtregistry.c: Do not include py-ref.h.
11103         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11104         * python/py-frame.c: Do not include py-ref.h.
11105         * python/py-framefilter.c: Do not include py-ref.h.
11106         * python/py-function.c: Do not include py-ref.h.
11107         * python/py-infevents.c: Do not include py-ref.h.
11108         * python/py-linetable.c: Do not include py-ref.h.
11109         * python/py-objfile.c: Do not include py-ref.h.
11110         * python/py-param.c: Do not include py-ref.h.
11111         * python/py-prettyprint.c: Do not include py-ref.h.
11112         * python/py-progspace.c: Do not include py-ref.h.
11113         * python/py-symbol.c: Do not include py-ref.h.
11114         * python/py-symtab.c: Do not include py-ref.h.
11115         * python/py-type.c: Do not include py-ref.h.
11116         * python/py-unwind.c: Do not include py-ref.h.
11117         * python/py-utils.c: Do not include py-ref.h.
11118         * python/py-value.c: Do not include py-ref.h.
11119         * python/py-varobj.c: Do not include py-ref.h.
11120         * python/py-xmethods.c: Do not include py-ref.h.
11121         * python/python.c: Do not include py-ref.h.
11122         * varobj.c: Do not include py-ref.h.
11123
11124 2019-01-22  Tom Tromey  <tom@tromey.com>
11125
11126         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11127         keyword for bcache.
11128
11129 2019-01-22  Tom Tromey  <tom@tromey.com>
11130
11131         * compile/compile-cplus-types.c: Remove a comment by #include.
11132
11133 2019-01-22  Tom Tromey  <tom@tromey.com>
11134
11135         * compile/gcc-c-plugin.h: Include compile-internal.h.
11136
11137 2019-01-22  Tom Tromey  <tom@tromey.com>
11138
11139         * stabsread.c (EXTERN): Do not define.
11140         (symnum, next_symbol_text_func, processing_gcc_compilation)
11141         (within_function, global_sym_chain, global_stabs)
11142         (previous_stab_code, this_object_header_files)
11143         (n_this_object_header_files)
11144         (n_allocated_this_object_header_files): Define.
11145         * stabsread.h (EXTERN): Never define.  Use "extern".
11146
11147 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11148
11149         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11150         history_value.
11151
11152 2019-01-21  Tom Tromey  <tom@tromey.com>
11153
11154         * ui-out.c: Fix includes.
11155         * tui/tui-source.c: Fix includes.
11156         * target.c: Fix includes.
11157         * remote.c: Fix includes.
11158         * regcache.c: Fix includes.
11159         * python/py-block.c: Fix includes.
11160         * printcmd.c: Fix includes.
11161         * or1k-tdep.c: Fix includes.
11162         * mi/mi-main.c: Fix includes.
11163         * m32r-tdep.c: Fix includes.
11164         * csky-tdep.c: Fix includes.
11165         * compile/compile-cplus-types.c: Fix includes.
11166         * cli/cli-interp.c: Fix includes.
11167
11168 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11169
11170         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11171         for padding.
11172
11173 2019-01-16  Tom Tromey  <tom@tromey.com>
11174
11175         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11176         earlier.
11177         (struct objfile) <msymbols_range>: Move from top level.
11178         <msymbols>: New method.
11179         (class objfile_msymbols): Remove.
11180         * symtab.c (default_collect_symbol_completion_matches_break_on):
11181         Update.
11182         * symmisc.c (dump_msymbols): Update.
11183         * stabsread.c (scan_file_globals): Update.
11184         * objc-lang.c (info_selectors_command, info_classes_command)
11185         (find_methods): Update.
11186         * minsyms.c (find_solib_trampoline_target): Update.
11187         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11188         * coffread.c (coff_symfile_read): Update.
11189         * ada-lang.c (ada_lookup_simple_minsym)
11190         (ada_collect_symbol_completion_matches): Update.
11191
11192 2019-01-16  Tom Tromey  <tom@tromey.com>
11193
11194         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11195         type.  Remove no-argument constructor.
11196         <iterator::operator++>: Simplify.
11197         <begin>: Update.
11198         <end>: Use minimal_symbol_count.
11199
11200 2019-01-16  Tom Tromey  <tom@tromey.com>
11201
11202         * objfiles.h (struct objfile) <psymtabs>: New method.
11203         (class objfile_psymtabs): Remove.
11204         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11205         typedef.
11206         <range>: New method.
11207         (require_partial_symbols): Change return type.
11208         * psymtab.c (require_partial_symbols)
11209         (psym_expand_symtabs_matching): Update.
11210         * mdebugread.c (parse_partial_symbols): Update.
11211         * dbxread.c (dbx_end_psymtab): Update.
11212
11213 2019-01-15  Tom Tromey  <tom@tromey.com>
11214
11215         * symtab.c (lookup_objfile_from_block)
11216         (lookup_symbol_in_objfile_symtabs)
11217         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11218         (find_line_symtab, info_sources_command)
11219         (default_collect_symbol_completion_matches_break_on)
11220         (make_source_files_completion_list): Update.
11221         * symmisc.c (print_objfile_statistics, dump_objfile)
11222         (maintenance_print_symbols, maintenance_info_symtabs)
11223         (maintenance_check_symtabs, maintenance_info_line_tables):
11224         Update.
11225         * source.c (select_source_symtab)
11226         (forget_cached_source_info_for_objfile): Update.
11227         * objfiles.h (class objfile_compunits): Remove.
11228         (struct objfile) <compunits_range>: New typedef.
11229         (compunits): New method.
11230         * objfiles.c (objfile_relocate1): Update.
11231         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11232         * maint.c (count_symtabs_and_blocks): Update.
11233         * linespec.c (iterate_over_all_matching_symtabs): Update.
11234         * cp-support.c (add_symbol_overload_list_qualified): Update.
11235         * coffread.c (coff_symtab_read): Update.
11236         * ada-lang.c (add_nonlocal_symbols)
11237         (ada_collect_symbol_completion_matches)
11238         (ada_add_global_exceptions): Update.
11239
11240 2019-01-15  Tom Tromey  <tom@tromey.com>
11241
11242         * progspace.h (program_space) <objfiles_safe_range>: New
11243         typedef.
11244         <objfiles_safe>: New method.
11245         * objfiles.h (class all_objfiles_safe): Remove.
11246         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11247         * jit.c (jit_inferior_exit_hook): Update.
11248
11249 2019-01-17  Tom Tromey  <tom@tromey.com>
11250
11251         * progspace.h (program_space) <objfiles_range>: New typedef.
11252         <objfiles>: New method.
11253         <objfiles_head>: Rename from objfiles.
11254         (object_files): Update.
11255         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11256         * guile/scm-pretty-print.c
11257         (ppscm_find_pretty_printer_from_objfiles): Update.
11258         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11259         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11260         Update.
11261         * python/py-progspace.c (pspy_get_objfiles): Update.
11262         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11263         Update.
11264         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11265         (objfpy_lookup_objfile_by_build_id): Update.
11266         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11267         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11268         Update.
11269         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11270         (expand_symtab_containing_pc, lookup_objfile_from_block)
11271         (lookup_static_symbol, basic_lookup_transparent_type)
11272         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11273         (find_line_symtab, info_sources_command)
11274         (default_collect_symbol_completion_matches_break_on)
11275         (make_source_files_completion_list, find_main_name): Update.
11276         * symmisc.c (print_symbol_bcache_statistics)
11277         (print_objfile_statistics, maintenance_print_symbols)
11278         (maintenance_print_msymbols, maintenance_print_objfiles)
11279         (maintenance_info_symtabs, maintenance_check_symtabs)
11280         (maintenance_expand_symtabs, maintenance_info_line_tables):
11281         Update.
11282         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11283         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11284         (map_overlay_command, unmap_overlay_command)
11285         (simple_overlay_update, expand_symtabs_matching)
11286         (map_symbol_filenames): Update.
11287         * symfile-debug.c (set_debug_symfile): Update.
11288         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11289         Update.
11290         * source.c (select_source_symtab, forget_cached_source_info):
11291         Update.
11292         * solib.c (solib_read_symbols): Update.
11293         * solib-spu.c (append_ocl_sos): Update.
11294         * psymtab.c (maintenance_print_psymbols)
11295         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11296         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11297         * printcmd.c (info_symbol_command): Update.
11298         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11299         Update.
11300         * objfiles.h (class all_objfiles): Remove.
11301         * objfiles.c (have_partial_symbols, have_full_symbols)
11302         (have_minimal_symbols, qsort_cmp, update_section_map)
11303         (shared_objfile_contains_address_p)
11304         (default_iterate_over_objfiles_in_search_order): Update.
11305         * objc-lang.c (info_selectors_command, info_classes_command)
11306         (find_methods): Update.
11307         * minsyms.c (find_solib_trampoline_target): Update.
11308         * maint.c (maintenance_info_sections)
11309         (maintenance_translate_address, count_symtabs_and_blocks):
11310         Update.
11311         * main.c (captured_main_1): Update.
11312         * linux-thread-db.c (try_thread_db_load_from_pdir)
11313         (has_libpthread): Update.
11314         * linespec.c (iterate_over_all_matching_symtabs)
11315         (search_minsyms_for_name): Update.
11316         * jit.c (jit_find_objf_with_entry_addr): Update.
11317         * hppa-tdep.c (find_unwind_entry)
11318         (hppa_lookup_stub_minimal_symbol): Update.
11319         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11320         Update.
11321         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11322         (elf_gnu_ifunc_resolve_by_got): Update.
11323         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11324         * dwarf-index-write.c (save_gdb_index_command): Update.
11325         * cp-support.c (add_symbol_overload_list_qualified): Update.
11326         * breakpoint.c (create_overlay_event_breakpoint)
11327         (create_longjmp_master_breakpoint)
11328         (create_std_terminate_master_breakpoint)
11329         (create_exception_master_breakpoint): Update.
11330         * blockframe.c (find_pc_partial_function): Update.
11331         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11332         (ada_collect_symbol_completion_matches)
11333         (ada_add_global_exceptions): Update.
11334
11335 2019-01-17  Tom Tromey  <tom@tromey.com>
11336
11337         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11338         declare VEC.
11339         (solib_target_parse_libraries): Change return type.
11340         (library_list_start_segment, library_list_start_section)
11341         (library_list_end_library, library_list_start_library); Update.
11342         (solib_target_free_library_list): Remove.
11343         (solib_target_parse_libraries): Remove cleanup.  Change return
11344         type.
11345         (solib_target_current_sos): Update.
11346
11347 2019-01-17  Tom Tromey  <tromey@bapiya>
11348
11349         * valprint.c: Replace "the the" with "the".
11350         * symtab.c: Replace "the the" with "the".
11351         * solib.c: Replace "the the" with "the".
11352         * solib-dsbt.c: Replace "the the" with "the".
11353         * linespec.c: Replace "the the" with "the".
11354         * dwarf2loc.h: Replace "the the" with "the".
11355         * amd64-windows-tdep.c: Replace "the the" with "the".
11356         * aarch64-tdep.c: Replace "the the" with "the".
11357
11358 2019-01-16  Keith Seitz  <keiths@redhat.com>
11359
11360         PR gdb/23773
11361         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11362         <builder>: Rename to ..
11363         <m_builder>: ... this and make private.
11364         (dwarf2_cu::get_builder): New method.  Change all users of
11365         `builder' to use this method.
11366         (dwarf2_start_symtab): Move to ...
11367         (dwarf2_cu::start_symtab): ... here.  Update all callers
11368         (setup_type_unit_groups): Move to ...
11369         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11370         callers.
11371         (dwarf2_cu::reset_builder): New method.
11372         (process_full_compunit, process_full_type_unit): Use
11373         dwarf2_cu::reset_builder.
11374         (follow_die_offset): Record the ancestor CU if it is different
11375         from the followed DIE's CU.
11376         (follow_die_sig_1): Likewise.
11377
11378 2019-01-15  Tom Tromey  <tom@tromey.com>
11379
11380         * remote.c (class remote_state) <buf>: Now a char_vector.
11381         <buf_size>: Remove.
11382         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
11383         parameter.
11384         (remote_target::getpkt_or_notif_sane_1)
11385         (remote_target::getpkt_sane)
11386         (remote_target::getpkt_or_notif_sane): Likewise.
11387         (class remote_target) <putpkt>: New overload.
11388         (remote_target::read_frame): Change type of "buf_p".  Remove
11389         sizeof_p parameter.
11390         (packet_ok): New overload.
11391         (packet_check_result): New overload.
11392         Update all uses.
11393
11394 2019-01-14  Tom Tromey  <tom@tromey.com>
11395
11396         * remote-notif.c (handle_notification, remote_notif_ack)
11397         (remote_notif_parse): Make "buf" const.
11398         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
11399         const.
11400         (remote_notif_parse, remote_notif_ack, handle_notification):
11401         Likewise.
11402         * remote.c (remote_notif_stop_parse): Make "buf" const.
11403         (remote_target::remote_parse_stop_reply): Make "buf" const.
11404         (remote_notif_stop_ack): Make "buf" const.
11405
11406 2019-01-14  Tom Tromey  <tom@tromey.com>
11407
11408         * remote.c (remote_console_output): Make parameter const.
11409
11410 2019-01-14  Tom Tromey  <tom@tromey.com>
11411
11412         * target-debug.h (target_debug_print_signals): Constify.
11413         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
11414         * procfs.c (procfs_target::pass_signals): Update.
11415         * linux-nat.c (linux_nat_target::pass_signals): Update.
11416         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
11417         * target-delegates.c: Rebuild.
11418         * remote.c (remote_target::program_signals): Update.
11419         (remote_target::pass_signals): Update.
11420         * target.c (target_pass_signals): Constify argument.
11421         (target_program_signals): Likewise.
11422         * target.h (struct target_ops) <pass_signals, program_signals>:
11423         Constify argument.
11424         (target_pass_signals, target_program_signals): Constify argument.
11425
11426 2019-01-14  Tom Tromey  <tom@tromey.com>
11427
11428         PR tui/28819:
11429         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
11430
11431 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
11432
11433         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
11434         field.
11435         * rs6000-tdep.c: Include reggroups.h.
11436         (IS_V_ALIAS_PSEUDOREG): Define.
11437         (rs6000_register_name): Return names for the "vX" aliases.
11438         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
11439         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
11440         aliases.  Call default_register_reggroup_p for all other
11441         pseudo-registers.
11442         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
11443         New functions.
11444         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
11445         Handle "vX" aliases.
11446         (v_alias_pseudo_register_collect): New function.
11447         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
11448         (rs6000_gdbarch_init): Initialize "vX" aliases as
11449         pseudo-registers.  Restore registration of
11450         rs6000_pseudo_register_reggroup_p with
11451         set_tdesc_pseudo_register_reggroup_p.
11452
11453 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
11454
11455         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
11456         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
11457         set_gdbarch_num_pseudo_regs.
11458
11459 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11460
11461         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
11462         Remove arg prefixname, add do_set and do_show.
11463         Add member functions set_list and show_list.
11464         * cli/cli-style.c (class cli_style_option): Update accordingly.
11465         (style_set_list): Move to file scope.
11466         (style_show_list): Likewise.
11467         (set_style): Call help_list.
11468         (show_style): Call cmd_show_list.
11469         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
11470         Update to use the new macro.
11471
11472 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
11473
11474         * ada-lang.c (_initialize_ada_language): Expand the help text
11475         for the "catch exception" command.
11476
11477 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11478
11479         * symtab.c (matching_obj_sections): Initialize obj,
11480         declare it closer to its usage.
11481
11482 2019-01-10  Tom Tromey  <tom@tromey.com>
11483
11484         * thread-iter.h (inf_threads_iterator): Use next_iterator.
11485         (basic_inf_threads_range): Remove.
11486         (inf_threads_range, inf_non_exited_threads_range)
11487         (safe_inf_threads_range): Use next_adapter.
11488
11489 2019-01-10  Keith Seitz  <keiths@redhat.com>
11490
11491         PR gdb/23712
11492         PR symtab/23010
11493         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
11494         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
11495
11496 2019-01-10  Keith Seitz  <keiths@redhat.com>
11497
11498         PR gdb/23712
11499         PR symtab/23010
11500         * dictionary.c (pending_to_vector): Remove.
11501         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11502         Remove _1 suffix, replacing functions of the same name.  Update
11503         all callers.
11504         (dict_create_hashed, dict_create_hashed_expandable)
11505         (dict_create_linear, dict_create_linear_expandable, dict_free)
11506         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
11507         Make functions static.
11508
11509 2019-01-10  Keith Seitz  <keiths@redhat.com>
11510
11511         PR gdb/23712
11512         PR symtab/23010
11513         * dictionary.h (struct dictionary): Replace declaration with
11514         multidictionary.
11515         (dict_create_hashed, dict_create_hashed_expandable)
11516         (dict_create_linear, dict_create_linear_expandable)
11517         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
11518         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
11519         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
11520         taking multidictionary argument.
11521         [ALL_DICT_SYMBOLS]: Update for multidictionary.
11522         * block.h (struct block) <dict>: Change to multidictionary
11523         and rename `multidict'.
11524         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
11525         symmisc.c: Update all dictionary references to multidictionary.
11526
11527 2019-01-10  Keith Seitz  <keiths@redhat.com>
11528
11529         PR gdb/23712
11530         PR symtab/23010
11531         * dictionary.c: Include unordered_map.
11532         (pending_to_vector): New function.
11533         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
11534         Rewrite the non-"_1" functions to take vector instead
11535         of linked list.
11536         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
11537         "new" _1 versions of the same name.
11538         (multidictionary): Define.
11539         (std::hash<enum language): New definition.
11540         (collate_pending_symbols_by_language, mdict_create_hashed)
11541         (mdict_create_hashed_expandable, mdict_create_linear)
11542         (mdict_create_linear_expandable, mdict_free)
11543         (find_language_dictionary, create_new_language_dictionary)
11544         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
11545         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
11546         (mdict_size, mdict_empty): New functions.
11547         * dictionary.h (mdict_iterator): Define.
11548
11549 2019-01-10  Pedro Alves  <palves@redhat.com>
11550
11551         * breakpoint.c (read_uploaded_action)
11552         (create_tracepoint_from_upload): Adjust to use
11553         gdb::unique_xmalloc_ptr.
11554         * ctf.c (ctf_write_uploaded_tp):
11555         (SET_ARRAY_FIELD): Use emplace_back.
11556         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
11557         * tracefile-tfile.c (tfile_write_uploaded_tp):
11558         * tracepoint.c (parse_tracepoint_definition): Adjust to use
11559         gdb::unique_xmalloc_ptr.
11560         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
11561         at_string, cond_string, cmd_strings>: Replace char pointers
11562         with gdb::unique_xmalloc_ptr.
11563
11564 2019-01-10  Pedro Alves  <palves@redhat.com>
11565
11566         * solib-target.c (library_list_start_library): Don't xstrdup name.
11567
11568 2019-01-10  Pedro Alves  <palves@redhat.com>
11569
11570         * mdebugread.c (parse_partial_symbols): Use
11571         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
11572
11573 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11574
11575         * linux-fork.c (scoped_switch_fork_info)
11576         <~scoped_switch_fork_info>: Fix incorrect variable name.
11577
11578 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
11579
11580         * linux-fork.c (scoped_switch_fork_info)
11581         <scoped_switch_fork_info>: Make explicit.
11582         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
11583
11584 2019-01-10  Tom Tromey  <tom@tromey.com>
11585
11586         * objfiles.h (objfile::reset_psymtabs): Update.
11587         * objfiles.c (objfile::objfile): Update.
11588         * psymtab.h (psymtab_storage::obstack): Update.
11589         (psymtab_storage::m_obstack): Use gdb::optional.
11590         (class psymtab_storage): Update comment.  Remove objfile
11591         parameter.
11592         * psymtab.c (psymtab_storage::psymtab_storage): Update.
11593
11594 2019-01-10  Tom Tromey  <tom@tromey.com>
11595
11596         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
11597         <free_psymtabs>: Now private.
11598         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
11599         (allocate_psymtab): Use new method.
11600
11601 2019-01-10  Tom Tromey  <tom@tromey.com>
11602
11603         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
11604         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
11605         * mdebugread.c (parse_partial_symbols): Use
11606         allocate_dependencies.
11607         * dwarf2read.c (dwarf2_create_include_psymtab): Use
11608         allocate_dependencies.
11609         (process_psymtab_comp_unit_reader)
11610         (build_type_psymtab_dependencies): Likewise.
11611         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
11612
11613 2019-01-10  Tom Tromey  <tom@tromey.com>
11614
11615         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
11616         PSYMBOL_SET_LANGUAGE.
11617         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
11618
11619 2019-01-10  Tom Tromey  <tom@tromey.com>
11620
11621         * psymtab.h (psymtab_storage::obstack): New method.
11622         <m_obstack>: Rename from obstack; now private.
11623         * psymtab.c (psymtab_storage): Update.
11624         * dwarf2read.c (create_addrmap_from_index)
11625         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
11626         Update.
11627
11628 2019-01-10  Tom Tromey  <tom@tromey.com>
11629
11630         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
11631         * objfiles.h (objfile::reset_psymtabs): New method.
11632
11633 2019-01-10  Tom Tromey  <tom@tromey.com>
11634
11635         * symmisc.c (print_symbol_bcache_statistics): Update.
11636         (print_objfile_statistics): Update.
11637         * symfile.c (reread_symbols): Update.
11638         * psymtab.h (class psymtab_storage): New.
11639         * psymtab.c (psymtab_storage): New constructor.
11640         (~psymtab_storage): New destructor.
11641         (require_partial_symbols): Update.
11642         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
11643         (find_pc_sect_psymtab, find_pc_sect_psymbol)
11644         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
11645         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
11646         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
11647         (start_psymtab_common, end_psymtab_common)
11648         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
11649         (allocate_psymtab): Update.
11650         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
11651         Update.
11652         (dump_psymtab_addrmap, maintenance_print_psymbols)
11653         (maintenance_check_psymtabs): Update.
11654         (class objfile_psymtabs): Move to objfiles.h.
11655         * psympriv.h (discard_psymtab): Now inline.
11656         (psymtab_discarder::psymtab_discarder): Update.
11657         (psymtab_discarder::~psymtab_discarder): Update.
11658         (ALL_OBJFILE_PSYMTABS): Rewrite.
11659         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
11660         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
11661         Remove fields.
11662         <partial_symtabs>: New field.
11663         (class objfile_psymtabs): Move from psymtab.h.  Update.
11664         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
11665         psymbol_cache.
11666         (objfile::~objfile): Don't destroy psymbol_cache.
11667         * mdebugread.c (parse_partial_symbols): Update.
11668         * dwarf2read.c (create_addrmap_from_index)
11669         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
11670         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
11671         (add_partial_subprogram, dwarf2_ranges_read): Update.
11672         * dwarf-index-write.c (write_address_map)
11673         (write_one_signatured_type, recursively_write_psymbols)
11674         (class debug_names, class debug_names, write_psymtabs_to_index):
11675         Update.
11676
11677 2019-01-10  Tom Tromey  <tom@tromey.com>
11678
11679         * symtab.h (SYMBOL_SET_NAMES): Update.
11680         (symbol_set_names): Update.
11681         (MSYMBOL_SET_NAMES): Update.
11682         * symtab.c (symbol_set_names): Change argument to be an
11683         objfile_per_bfd_storage.
11684         * psymtab.c (add_psymbol_to_bcache): Update.
11685         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
11686
11687 2019-01-10  Tom Tromey  <tom@tromey.com>
11688
11689         * symtab.c (create_demangled_names_hash): Change argument to be an
11690         objfile_per_bfd_storage.
11691         (symbol_set_names): Update.
11692
11693 2019-01-10  Tom Tromey  <tom@tromey.com>
11694
11695         * xcoffread.c (xcoff_initial_scan): Unconditionally call
11696         init_psymbol_list.
11697         * psymtab.c (init_psymbol_list): Do nothing if already called.
11698         * psympriv.h (init_psymbol_list): Add comment.
11699         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
11700         init_psymbol_list.
11701         * dbxread.c (dbx_symfile_read): Unconditionally call
11702         init_psymbol_list.
11703
11704 2019-01-10  Tom Tromey  <tom@tromey.com>
11705
11706         * xcoffread.c (scan_xcoff_symtab): Update.
11707         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
11708         "where".
11709         * mdebugread.c (parse_partial_symbols)
11710         (handle_psymbol_enumerators): Update.
11711         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
11712         * dbxread.c (read_dbx_symtab): Update.
11713         * psympriv.h (psymbol_placement): New enum.
11714         (add_psymbol_to_list): Update.
11715
11716 2019-01-10  Tom Tromey  <tom@tromey.com>
11717
11718         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
11719         static_psymbols parameters.
11720         (scan_xcoff_symtab): Update.
11721         * psymtab.c (start_psymtab_common): Remove global_psymbols and
11722         static_psymbols parameters.
11723         * psympriv.h (start_psymtab_common): Update.
11724         * mdebugread.c (parse_partial_symbols): Update.
11725         * dwarf2read.c (create_partial_symtab): Update.
11726         * dbxread.c (read_dbx_symtab): Update.
11727         (start_psymtab): Remove global_psymbols and static_psymbols
11728         parameters.
11729
11730 2019-01-10  Tom Tromey  <tom@tromey.com>
11731
11732         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
11733         * psymtab.c (allocate_psymtab): Add comment.
11734         * psympriv.h (allocate_psymtab): Add comment.
11735         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
11736         initializations.
11737         * dbxread.c (dbx_end_psymtab): Remove some initializations.
11738
11739 2019-01-10  Tom Tromey  <tom@tromey.com>
11740
11741         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11742         Don't declare.
11743         * mipsread.c: Include mdebugread.h.
11744         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
11745         Declare.
11746         * elfread.c: Include mdebugread.h.
11747
11748 2019-01-09  Tom Tromey  <tom@tromey.com>
11749
11750         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
11751         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
11752         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
11753         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
11754         (psym_lookup_symbol, psym_find_last_source_symtab)
11755         (psym_forget_cached_source_info, psym_print_stats)
11756         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
11757         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
11758         (psym_map_matching_symbols, psym_expand_symtabs_matching)
11759         (psym_find_compunit_symtab_by_address)
11760         (maintenance_print_psymbols, maintenance_info_psymtabs)
11761         (maintenance_check_psymtabs): Use ranged for.
11762         * psymtab.h (class objfile_psymtabs): New.
11763         (require_partial_symbols): Return objfile_psymtabs.
11764         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
11765
11766 2019-01-09  Tom Tromey  <tom@tromey.com>
11767
11768         * symfile.c (overlay_invalidate_all, find_pc_overlay)
11769         (find_pc_mapped_section, list_overlays_command)
11770         (map_overlay_command, unmap_overlay_command)
11771         (simple_overlay_update): Use all_objfiles.
11772         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
11773         * printcmd.c (info_symbol_command): Use all_objfiles.
11774         * objfiles.h (ALL_OBJSECTIONS): Remove.
11775         * maint.c (maintenance_translate_address): Use all_objfiles.
11776         * gcore.c (gcore_create_callback): Use all_objfiles.
11777         (objfile_find_memory_regions): Likewise.
11778
11779 2019-01-09  Tom Tromey  <tom@tromey.com>
11780
11781         * symtab.c (find_line_symtab, info_sources_command)
11782         (make_source_files_completion_list): Use objfile_compunits.
11783         * source.c (select_source_symtab): Use objfile_compunits.
11784         * objfiles.h (struct objfile): Update comment.
11785         (ALL_OBJFILES): Remove.
11786         (ALL_FILETABS): Remove.
11787         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
11788         objfile_compunits.
11789
11790 2019-01-09  Tom Tromey  <tom@tromey.com>
11791
11792         * symmisc.c (print_objfile_statistics, dump_objfile)
11793         (maintenance_print_symbols): Use compunit_filetabs.
11794         * source.c (forget_cached_source_info_for_objfile): Use
11795         compunit_filetabs.
11796         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
11797         (ALL_FILETABS): Use compunit_filetabs.
11798         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
11799         * coffread.c (coff_symtab_read): Use compunit_filetabs.
11800
11801 2019-01-09  Tom Tromey  <tom@tromey.com>
11802
11803         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
11804         (compunit_filetabs): New.
11805         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
11806         compunit_filetabs.
11807         (info_sources_command, make_source_files_completion_list): Remove
11808         declaration.
11809         * symmisc.c (print_objfile_statistics, dump_objfile)
11810         (maintenance_print_symbols): Remove declaration.
11811         (maintenance_info_symtabs): Use compunit_filetabs.
11812         (maintenance_info_line_tables): Likewise.
11813         * source.c (select_source_symtab): Change local variable name.
11814         (forget_cached_source_info_for_objfile): Remove declaration.
11815         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
11816         * objfiles.c (objfile_relocate1): Remove declaration.
11817         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11818         declaration.
11819         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
11820         * coffread.c (coff_symtab_read): Remove declaration.
11821         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
11822         compunit_filetabs.
11823
11824 2019-01-09  Tom Tromey  <tom@tromey.com>
11825
11826         * symtab.c (lookup_objfile_from_block)
11827         (find_pc_sect_compunit_symtab, search_symbols)
11828         (default_collect_symbol_completion_matches_break_on): Use
11829         objfile_compunits.
11830         * objfiles.h (ALL_COMPUNITS): Remove.
11831         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
11832         * cp-support.c (add_symbol_overload_list_qualified): Use
11833         objfile_compunits.
11834         * ada-lang.c (ada_collect_symbol_completion_matches)
11835         (ada_add_global_exceptions): Use objfile_compunits.
11836
11837 2019-01-09  Tom Tromey  <tom@tromey.com>
11838
11839         * source.c (select_source_symtab)
11840         (forget_cached_source_info_for_objfile): Remove declaration.
11841         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
11842         declaration.
11843         * maint.c (count_symtabs_and_blocks): Remove declaration.
11844         * cp-support.c (add_symbol_overload_list_qualified): Remove
11845         declaration.
11846         * coffread.c (coff_symtab_read): Remove declaration.
11847         * symtab.c (lookup_symbol_in_objfile_symtabs)
11848         (basic_lookup_transparent_type_1): Use objfile_compunits.
11849         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
11850         (info_sources_command, search_symbols)
11851         (default_collect_symbol_completion_matches_break_on)
11852         (make_source_files_completion_list): Remove declaration.
11853         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
11854         (ada_collect_symbol_completion_matches)
11855         (ada_add_global_exceptions): Remove declaration.
11856         * linespec.c (iterate_over_all_matching_symtabs): Use
11857         objfile_compunits.
11858         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
11859         (class objfile_compunits): New.
11860         (ALL_COMPUNITS): Use objfile_compunits.
11861         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
11862         (maintenance_check_symtabs, maintenance_info_line_tables): Use
11863         objfile_compunits.
11864         * objfiles.c (objfile_relocate1): Use objfile_compunits.
11865
11866 2019-01-09  Tom Tromey  <tom@tromey.com>
11867
11868         * symtab.c (search_symbols)
11869         (default_collect_symbol_completion_matches_break_on): Use
11870         objfile_msymbols.
11871         * ada-lang.c (ada_lookup_simple_minsym)
11872         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
11873         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
11874         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
11875         objfile_msymbols.
11876         * coffread.c (coff_symfile_read): Use objfile_msymbols.
11877         * symmisc.c (dump_msymbols): Use objfile_msymbols.
11878         * objc-lang.c (find_methods): Use objfile_msymbols.
11879         (info_selectors_command, info_classes_command): Likewise.
11880         * stabsread.c (scan_file_globals): Use objfile_msymbols.
11881         * objfiles.h (class objfile_msymbols): New.
11882         (ALL_OBJFILE_MSYMBOLS): Remove.
11883         (ALL_MSYMBOLS): Remove.
11884
11885 2019-01-09  Tom Tromey  <tom@tromey.com>
11886
11887         * common/next-iterator.h (next_adapter): Add Iterator template
11888         parameter.
11889         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
11890         (class all_objfiles_safe): New.
11891         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
11892         * objfiles.c (put_objfile_before): Update comment.
11893         (add_separate_debug_objfile): Likewise.
11894         (free_all_objfiles): Use all_objfiles_safe.
11895         (objfile_purge_solibs): Likewise.
11896
11897 2019-01-09  Tom Tromey  <tom@tromey.com>
11898
11899         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11900         (expand_symtab_containing_pc, lookup_static_symbol)
11901         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
11902         (find_symbol_at_address, find_line_symtab, find_main_name): Use
11903         all_objfiles.
11904         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
11905         * breakpoint.c (create_overlay_event_breakpoint)
11906         (create_longjmp_master_breakpoint)
11907         (create_std_terminate_master_breakpoint)
11908         (create_exception_master_breakpoint): Use all_objfiles.
11909         * linux-thread-db.c (try_thread_db_load_from_pdir)
11910         (has_libpthread): Use all_objfiles.
11911         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
11912         * linespec.c (iterate_over_all_matching_symtabs)
11913         (search_minsyms_for_name): Use all_objfiles.
11914         * maint.c (maintenance_info_sections): Use all_objfiles.
11915         * main.c (captured_main_1): Use all_objfiles.
11916         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
11917         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
11918         * guile/scm-pretty-print.c
11919         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
11920         * solib-spu.c (append_ocl_sos): Use all_objfiles.
11921         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
11922         (maintenance_print_msymbols): Use all_objfiles.
11923         * source.c (select_source_symtab): Use all_objfiles.
11924         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
11925         * symfile.c (remove_symbol_file_command)
11926         (expand_symtabs_matching, map_symbol_filenames): Use
11927         all_objfiles.
11928         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
11929         all_objfiles.
11930         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
11931         * objc-lang.c (find_methods): Use all_objfiles.
11932         * objfiles.c (have_partial_symbols, have_full_symbols)
11933         (have_minimal_symbols, qsort_cmp)
11934         (default_iterate_over_objfiles_in_search_order): Use
11935         all_objfiles.
11936         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
11937         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
11938         (maintenance_check_psymtabs): Use all_objfiles.
11939         (ALL_PSYMTABS): Remove.
11940         * compile/compile-object-run.c (do_module_cleanup): Use
11941         all_objfiles.
11942         * blockframe.c (find_pc_partial_function): Use all_objfiles.
11943         * cp-support.c (add_symbol_overload_list_qualified): Use
11944         all_objfiles.
11945         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11946         Use all_objfiles.
11947         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
11948         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
11949         all_objfiles.
11950         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11951         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
11952         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11953         Uses all_objfiles.
11954         * solib.c (solib_read_symbols): Use all_objfiles
11955
11956 2019-01-09  Tom Tromey  <tom@tromey.com>
11957
11958         * probe.c (parse_probes_in_pspace): Use all_objfiles.
11959         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
11960         all_objfiles.
11961         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
11962         * symmisc.c (print_symbol_bcache_statistics)
11963         (print_objfile_statistics, maintenance_print_objfiles)
11964         (maintenance_info_symtabs, maintenance_check_symtabs)
11965         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
11966         all_objfiles.
11967         * source.c (forget_cached_source_info): Use all_objfiles.
11968         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
11969         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11970         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
11971         * objfiles.c (update_section_map): Use all_objfiles.
11972         (shared_objfile_contains_address_p): Likewise.
11973         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
11974         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
11975
11976 2019-01-09  Tom Tromey  <tom@tromey.com>
11977
11978         * common/next-iterator.h: New file.
11979         * objfiles.h (class all_objfiles): New.
11980         (struct objfile_iterator): New.
11981
11982 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11983
11984         * NEWS: Move the description of the changed "frame", "select-frame",
11985          and "info frame" commands to the Changed commands section.
11986
11987 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
11988
11989         * gdbtypes.c (check_stub_method_group): Remove handling of old
11990         mangling schemes.
11991         * linespec.c (find_methods): Likewise.
11992         * stabsread.c (read_member_functions): Likewise.
11993         * valops.c (search_struct_method): Likewise.
11994         (value_struct_elt_for_reference): Likewise.
11995         * NEWS: Mention this change.
11996
11997 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
11998
11999         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12000         print_source_lines.
12001         * source.c (print_source_lines_base): Update line number check.
12002         (print_source_lines): New function.
12003         (source_lines_range::source_lines_range): New function.
12004         * source.h (class source_lines_range): New class.
12005         (print_source_lines): New declaration.
12006
12007 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12008
12009         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12010
12011 2019-01-08  Tom Tromey  <tom@tromey.com>
12012             Simon Marchi  <simon.marchi@ericsson.com>
12013
12014         PR gdb/24060
12015         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12016         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12017         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12018         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12019         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12020         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12021
12022 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12023
12024         * source.c (select_source_symtab): Move header comment to
12025         declaration in source.h.
12026         (forget_cached_source_info_for_objfile): Likewise.
12027         (forget_cached_source_info): Likewise.
12028         (identify_source_line): Likewise.
12029         * source.h (identify_source_line): Move declaration from symtab.h
12030         and add comment from source.c
12031         (print_source_lines): Likewise.
12032         (forget_cached_source_info_for_objfile): Likewise.
12033         (forget_cached_source_info): Likewise.
12034         (select_source_symtab): Likewise.
12035         (enum print_source_lines_flag): Move definition from symtab.h.
12036         * symtab.h (identify_source_line): Move declaration to source.h.
12037         (print_source_lines): Likewise.
12038         (forget_cached_source_info_for_objfile): Likewise.
12039         (forget_cached_source_info): Likewise.
12040         (select_source_symtab): Likewise.
12041         (enum print_source_lines_flag): Move definition to source.h.
12042         * tui/tui-hooks.c: Add 'source.h' include.
12043
12044 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12045
12046         * source.c (print_source_lines_base): Handle requests to print
12047         reverse line number sequences, and guard against empty lines
12048         string.
12049
12050 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12051
12052         * source.c (print_source_lines_base): Fix skip of '\r' if next
12053         character is '\n'.
12054
12055 2019-01-06  Tom Tromey  <tom@tromey.com>
12056
12057         * c-exp.y (struct c_parse_state) <macro_original_text,
12058         expansion_obstack>: New member.
12059         (macro_original_text, expansion_obstack): Remove globals.
12060         (scan_macro_expansion, scanning_macro_expansion)
12061         (finished_macro_expansion): Update.
12062         (scan_macro_cleanup): Remove.
12063         (yylex, c_parse): Update.
12064
12065 2019-01-06  Tom Tromey  <tom@tromey.com>
12066
12067         * c-exp.y (struct c_parse_state) <strings>: New member.
12068         (operator_stoken): Update.
12069
12070 2019-01-06  Tom Tromey  <tom@tromey.com>
12071
12072         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12073         (union type_stack_elt) <typelist_val>: Now a pointer to
12074         std::vector.
12075         (type_stack_cleanup): Don't declare.
12076         (push_typelist): Update.
12077         * parse.c (pop_typelist): Return a std::vector.
12078         (push_typelist): Take a std::vector.
12079         (follow_types): Update.  Do not free args.
12080         (type_stack_cleanup): Remove.
12081         * c-exp.y (struct c_parse_state): New.
12082         (cpstate): New global.
12083         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12084         (nonempty_typelist): Update.
12085         (func_mod): Create a new vector.
12086         (c_parse): Create a c_parse_state.
12087         (check_parameter_typelist): Do not delete params.
12088         (function_method): Update.  Do not delete type_list.
12089
12090 2019-01-06  Tom Tromey  <tom@tromey.com>
12091
12092         PR gdb/28155:
12093         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12094         check_typedef.
12095         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12096         (print_return_value): Likewise.
12097
12098 2019-01-05  Tom Tromey  <tom@tromey.com>
12099
12100         * contrib/cleanup_check.py: Remove.
12101         * contrib/gcc-with-excheck: Remove.
12102         * contrib/exsummary.py: Remove.
12103         * contrib/excheck.py: Remove.
12104
12105 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12106
12107         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12108         NULL. Initialize tpprev to NULL instead of assigning it
12109         to NULL on the next statement.
12110         * windows-nat.c (windows_delete_thread): Remove check for
12111         main_thread_id before printing thread exit notifications.
12112         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12113         Remove thread ID check against main_thread_id.
12114         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12115         windows_delete_thread.
12116         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12117
12118 2019-01-04  Tom Tromey  <tom@tromey.com>
12119
12120         * compile/compile.c (_initialize_compile): Use upper case for
12121         metasyntactic variables.
12122         * symmisc.c (_initialize_symmisc): Use upper case for
12123         metasyntactic variables.
12124         * psymtab.c (_initialize_psymtab): Use upper case for
12125         metasyntactic variables.
12126         * demangle.c (demangle_command): Use upper case for metasyntactic
12127         variables.
12128         (_initialize_demangler): Likewise.
12129         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12130         variables.
12131
12132 2019-01-03  Tom Tromey  <tom@tromey.com>
12133
12134         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12135
12136 2019-01-03  Tom Tromey  <tom@tromey.com>
12137
12138         * python/py-symtab.c (salpy_str): Update.
12139         (struct salpy_sal_object) <symtab>: Now a PyObject.
12140         (salpy_dealloc): Update.
12141         (del_objfile_sal): Use gdbpy_ref.
12142
12143 2019-01-03  Tom Tromey  <tom@tromey.com>
12144
12145         * python/py-type.c (convert_field): Use new_reference.  Return
12146         gdbpy_ref.
12147         (make_fielditem): Return gdbpy_ref.
12148         (typy_fields): Update.
12149         (typy_getitem): Update.
12150         (field_name): Return gdbpy_ref.  Use new_reference.
12151         (typy_iterator_iternext): Update.
12152
12153 2019-01-03  Tom Tromey  <tom@tromey.com>
12154
12155         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12156
12157 2019-01-03  Tom Tromey  <tom@tromey.com>
12158
12159         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12160         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12161         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12162         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12163         (pspy_set_type_printers): Likewise.
12164         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12165         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12166         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12167         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12168         (objfpy_set_type_printers): Likewise.
12169
12170 2019-01-03  Tom Tromey  <tom@tromey.com>
12171
12172         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12173         (gdbpy_print_stack): Use gdbpy_err_fetch.
12174         * python/python-internal.h (class gdbpy_err_fetch): New class.
12175         (class gdbpy_enter) <m_error_type, m_error_value,
12176         m_error_traceback>: Remove.
12177         <m_error>: New member.
12178         (gdbpy_exception_to_string): Don't declare.
12179         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12180         * python/py-value.c (convert_value_from_python): Use
12181         gdbpy_err_fetch.
12182         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12183         gdbpy_exception_to_string.
12184         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12185         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12186         gdbpy_err_fetch.
12187
12188 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12189
12190         * linux-nat.c (delete_lwp_cleanup): Delete.
12191         (struct lwp_deleter): New struct.
12192         (lwp_info_up): New typedef.
12193         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12194         lwp_info_up.
12195
12196 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12197
12198         * linux-fork.c (class scoped_switch_fork_info): New class.
12199         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12200
12201 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12202
12203         * valops.c (find_overload_match): Remove use of null_cleanup, and
12204         calls to do_cleanups.
12205
12206 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12207
12208         * compile/compile-cplus-types.c
12209         (compile_cplus_instance::decl_name): Handle changes to
12210         cp_func_name.
12211         * cp-support.c (cp_func_name): Update header comment, update
12212         return type.
12213         * cp-support.h (cp_func_name): Update return type in declaration.
12214         * valops.c (find_overload_match): Move temp_func local to top
12215         level of function and change its type.  Use temp_func to hold and
12216         delete temporary string obtained from cp_func_name.
12217
12218 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12219
12220         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12221         gdb::char_vector, remove cleanup, and update uses of `msg`.
12222
12223 2019-01-03  Jim Wilson  <jimw@sifive.com>
12224
12225         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12226
12227 2019-01-02  Tom Tromey  <tom@tromey.com>
12228
12229         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12230         (tdesc_parse_xml): Remove cleanups.
12231         * target-descriptions.h (make_cleanup_free_target_description):
12232         Don't declare.
12233         (target_desc_deleter): New struct.
12234         (target_desc_up): New typedef.
12235         * target-descriptions.c (target_desc_deleter::operator()): Rename
12236         from free_target_description.
12237         (make_cleanup_free_target_description): Remove.
12238
12239 2019-01-02  Tom Tromey  <tom@tromey.com>
12240
12241         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12242         constructor, destructor.
12243         (linespec_parser): Remove typedef.
12244         (~linespec_parser): Rename from linespec_parser_delete.
12245         (linespec_lex_to_end, linespec_complete_label)
12246         (linespec_complete): Update.
12247         (decode_line_full): Remove cleanups.
12248         (decode_line_1): Update.
12249
12250 2019-01-02  Tom Tromey  <tom@tromey.com>
12251
12252         * python/python-internal.h (inferior_to_inferior_object): Change
12253         return type.
12254         * python/py-exitedevent.c (create_exited_event_object): Update.
12255         * python/py-inferior.c (inferior_to_inferior_object): Return
12256         gdbpy_ref.
12257         (python_new_inferior, python_inferior_deleted)
12258         (thread_to_thread_object, delete_thread_object)
12259         (build_inferior_list, gdbpy_selected_inferior): Update.
12260         * python/py-infthread.c (create_thread_object): Update.  Also fail
12261         if inferior_to_inferior_object fails.
12262
12263 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12264
12265         * inferior.h (class inferior) <displaced_step_state>: New field.
12266         * infrun.h (struct displaced_step_state): Move here from
12267         infrun.c.  Initialize fields, add constructor.
12268         <inf>: Remove field.
12269         <reset>: New method.
12270         * infrun.c (struct displaced_step_inferior_state): Move to
12271         infrun.h.
12272         (displaced_step_inferior_states): Remove.
12273         (get_displaced_stepping_state): Adust.
12274         (displaced_step_in_progress_any_inferior): Adjust.
12275         (displaced_step_in_progress_thread): Adjust.
12276         (displaced_step_in_progress): Adjust.
12277         (add_displaced_stepping_state): Remove.
12278         (get_displaced_step_closure_by_addr): Adjust.
12279         (remove_displaced_stepping_state): Remove.
12280         (infrun_inferior_exit): Call displaced_step_state.reset.
12281         (use_displaced_stepping): Don't check for NULL.
12282         (displaced_step_prepare_throw): Call
12283         get_displaced_stepping_state.
12284         (displaced_step_fixup): Don't check for NULL.
12285         (prepare_for_detach): Don't check for NULL.
12286
12287 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12288
12289         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12290          in case of call that did not complete.
12291
12292 2019-01-02  Andrey Utkin  <autkin@undo.io>
12293
12294         * symfile.c (find_separate_debug_file): Fix search of debug files for
12295         remote debuggee.
12296
12297 2019-01-02  Tom Tromey  <tom@tromey.com>
12298
12299         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12300         indentation.
12301         * python/py-frame.c (frapy_older): Remove cast.
12302         (frapy_newer): Likewise.
12303         * python/py-breakpoint.c (local_setattro): Remove cast.
12304         * python/py-arch.c (archpy_name): Remove local variable.
12305         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12306
12307 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12308
12309         * unittests/basic_string_view/element_access/char/empty.cc:
12310         Fix year range in copyright header.
12311
12312 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12313
12314         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12315         Delete.
12316         <operator==>: Update with for removed field.
12317         <hash>: Likewise.
12318         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12319         <isa_features>: ...this.
12320         <abi_features>: New field.
12321         (riscv_isa_flen): Update comment.
12322         (riscv_abi_xlen): New declaration.
12323         (riscv_abi_flen): New declaration.
12324         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12325         isa_features.
12326         (riscv_abi_xlen): New function.
12327         (riscv_isa_flen): Update to get answer from isa_features.
12328         (riscv_abi_flen): New function.
12329         (riscv_has_fp_abi): Update to get answer from abi_features.
12330         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12331         xlen and flen.
12332         (riscv_call_info) <xlen, flen>: Update comment.
12333         (riscv_call_arg_struct): Remove invalid assertions
12334         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12335         is removed.
12336         (riscv_gdbarch_init): Gather isa features and abi features
12337         separately, ensure both match on the gdbarch when reusing an old
12338         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12339         a target with 64-bit float hardware.
12340
12341 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12342
12343         * source.c (search_command_helper): Stop reverse search
12344         when line 1 has been searched.
12345
12346 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12347
12348         * record-full.c (record_full_base_target::close): Rewrite
12349         record_full_core_buf_list free logic.
12350
12351 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12352
12353         * break-catch-syscall.c (print_one_catch_syscall): xfree
12354         the last text.
12355
12356 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12357
12358         * top.c (print_gdb_version): Update Copyright year in version
12359         message.
12360
12361 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12362
12363         Update copyright year range in all GDB files.
12364
12365 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12366
12367         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12368
12369 For older changes see ChangeLog-2018.
12370 \f
12371 Local Variables:
12372 mode: change-log
12373 left-margin: 8
12374 fill-column: 74
12375 version-control: never
12376 coding: utf-8
12377 End:
12378