gdb/ChangeLog

   1 2019-04-30  Ali Tamur  <tamur@google.com>
   2         * gdb/dwarf2read.c (read_3_bytes): New declaration.
   3         (read_attribute_value): Added DW_FORM_strx1-4 cases.
   4         (read_3_bytes): New function.
   5
   6 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
   7
   8         * windows-nat.c (main_thread_id): Delete.
   9         (handle_output_debug_string): Replace main_thread_id by
  10         current_event.dwThreadId.
  11         (fake_create_process): Likewise.
  12         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
  13         Do not set main_thread_id.
  14         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
  15         current_event.dwThreadId.
  16         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
  17
  18 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
  19
  20         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
  21         Use current_event.dwThreadId instead of main_thread_id.
  22
  23 2019-04-30  Tom Tromey  <tromey@adacore.com>
  24
  25         * ada-lang.c (ada_lookup_simple_minsyms): New function.
  26         (create_excep_cond_exprs): Iterate over program spaces.
  27         (ada_exception_catchpoint_cond_string): Examine all minimal
  28         symbols for exception types.
  29
  30 2019-04-30  Tom Tromey  <tromey@adacore.com>
  31
  32         PR c++/24470:
  33         * dwarf2read.c (process_structure_scope): Handle case where type
  34         has template parameters but no symbol was created.
  35
  36 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  37             Chris January  <chris.january@arm.com>
  38
  39         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
  40         qualifier.
  41         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
  42
  43 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  44
  45         * f-typeprint.c (f_print_type): Update rules for printing
  46         whitespace.
  47         (f_type_print_varspec_suffix): Likewise.
  48
  49 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  50             Chris January  <chris.january@arm.com>
  51
  52         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
  53         function arguments.
  54
  55 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  56
  57         * f-lang.c (build_fortran_types): Change name of void type to
  58         lower case.
  59         * f-typeprint.c (f_type_print_base): Print the name of the void
  60         type, rather than a fixed string.
  61         * f-valprint.c (f_decorations): Use lower case void string.
  62
  63 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  64             Chris January  <chris.january@arm.com>
  65
  66         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
  67         types for Fortran.
  68
  69 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  70             Chris January  <chris.january@arm.com>
  71             David Lecomber  <david.lecomber@arm.com>
  72
  73         * f-exp.y (BINOP_INTRINSIC): New token.
  74         (exp): New parser rule handling BINOP_INTRINSIC.
  75         (f77_keywords): Add new builtin procedures.
  76         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
  77         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  78         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
  79         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  80         (print_unop_subexp_f): New function.
  81         (print_binop_subexp_f): New function.
  82         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  83         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
  84         (dump_subexp_body_f): Likewise.
  85         (operator_check_f): Likewise.
  86         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
  87         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
  88
  89 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
  90
  91         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
  92         UNOP_KIND.
  93         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
  94         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
  95         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
  96         (operator_length_f): New fuction.
  97         (print_subexp_f): New function.
  98         (op_name_f): New function.
  99         (dump_subexp_body_f): New function.
 100         (operator_check_f): New function.
 101         (exp_descriptor_f): Replace standard expression handling functions
 102         with new functions.
 103         * gdb/fortran-operator.def: New file.
 104         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
 105         * gdb/std-operator.def: Remove UNOP_KIND.
 106
 107 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
 108
 109         * std-operator.def: Remove unbalanced, stray double quote
 110         character.
 111
 112 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 113             Chris January  <chris.january@arm.com>
 114             Daniel Everett  <daniel.everett@arm.com>
 115             Nick Forrington  <nick.forrington@arm.com>
 116             Richard Bunt  <richard.bunt@arm.com>
 117
 118         * cp-valprint.c (cp_print_value_fields): Allow an additional level
 119         of depth when printing anonymous structs or unions.
 120         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
 121         Don't print either the top-level value, or the children if the
 122         max-depth is exceeded.
 123         (ppscm_print_children): When printing the key of a map, allow one
 124         extra level of depth.
 125         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
 126         print either the top-level value, or the children if the max-depth
 127         is exceeded.
 128         (print_children): When printing the key of a map, allow one extra
 129         level of depth.
 130         * python/py-value.c (valpy_format_string): Add max_depth keyword.
 131         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
 132         (user_print_options): Initialise max_depth field.
 133         (val_print_scalar_or_string_type_p): New function.
 134         (val_print): Check to see if the max depth has been reached.
 135         (val_print_check_max_depth): Define new function.
 136         (show_print_max_depth): New function.
 137         (_initialize_valprint): Add 'print max-depth' option.
 138         * valprint.h (struct value_print_options) <max_depth>: New field.
 139         (val_print_check_max_depth): Declare new function.
 140         * NEWS: Document new feature.
 141
 142 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 143
 144         * ada-lang.c (ada_language_defn): Initialise new field.
 145         * c-lang.c (c_is_string_type_p): New function.
 146         (c_language_defn): Initialise new field.
 147         (cplus_language_defn): Initialise new field.
 148         (asm_language_defn): Initialise new field.
 149         (minimal_language_defn): Initialise new field.
 150         * c-lang.h (c_is_string_type_p): Declare new function.
 151         * d-lang.c (d_language_defn): Initialise new field.
 152         * f-lang.c (f_is_string_type_p): New function.
 153         (f_language_defn): Initialise new field.
 154         * go-lang.c (go_is_string_type_p): New function.
 155         (go_language_defn): Initialise new field.
 156         * language.c (default_is_string_type_p): New function.
 157         (unknown_language_defn): Initialise new field.
 158         (auto_language_defn): Initialise new field.
 159         * language.h (struct language_defn) <la_is_string_type_p>: New
 160         member variable.
 161         (default_is_string_type_p): Declare new function.
 162         * m2-lang.c (m2_language_defn): Initialise new field.
 163         * objc-lang.c (objc_language_defn): Initialise new field.
 164         * opencl-lang.c (opencl_language_defn): Initialise new field.
 165         * p-lang.c (pascal_is_string_type_p): New function.
 166         (pascal_language_defn): Initialise new field.
 167         * rust-lang.c (rust_is_string_type_p): New function.
 168         (rust_language_defn): Initialise new field.
 169
 170 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 171
 172         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
 173         New field.
 174         * ada-lang.c (ada_language_defn): Initialise new field.
 175         * c-lang.c (c_language_defn): Likewise.
 176         (cplus_language_defn): Likewise.
 177         (asm_language_defn): Likewise.
 178         (minimal_language_defn): Likewise.
 179         * d-lang.c (d_language_defn): Likewise.
 180         * f-lang.c (f_language_defn): Likewise.
 181         * go-lang.c (go_language_defn): Likewise.
 182         * language.c (unknown_language_defn): Likewise.
 183         (auto_language_defn): Likewise.
 184         * m2-lang.c (m2_language_defn): Likewise.
 185         * objc-lang.c (objc_language_defn): Likewise.
 186         * opencl-lang.c (opencl_language_defn): Likewise.
 187         * p-lang.c (pascal_language_defn): Likewise.
 188         * rust-lang.c (rust_language_defn): Likewise.
 189
 190 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
 191
 192         * ada-lang.c (ada_is_character_type): Change return type to bool.
 193         (ada_is_string_type): Likewise.
 194         * ada-lang.h (ada_is_character_type): Update declaration
 195         (ada_is_string_type): Likewise.
 196
 197 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 198
 199         Support style in 'frame|thread apply'
 200
 201         * gdbcmd.h (execute_command_to_string): New term_out parameter.
 202         * record.c (record_start, record_stop): Update callers of
 203         execute_command_to_string with false.
 204         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
 205         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
 206         methods.
 207         (class string_file): New constructor with term_out parameter.
 208         Override methods term_out and can_emit_style_escape.  New member
 209         term_out.
 210         (class stdio_file): Override can_emit_style_escape.
 211         (class tee_file): Override term_out and can_emit_style_escape.
 212         * utils.h (can_emit_style_escape): Remove.
 213         * utils.c (can_emit_style_escape): Likewise.
 214         Update all callers of can_emit_style_escape (SOMESTREAM) to
 215         SOMESTREAM->can_emit_style_escape.
 216         * source-cache.c (source_cache::get_source_lines): Likewise.
 217         * stack.c (frame_apply_command_count): Call execute_command_to_string
 218         passing the term_out characteristic of the current gdb_stdout.
 219         * thread.c (thr_try_catch_cmd): Likewise.
 220         * top.c (execute_command_to_string): pass term_out parameter
 221         to construct the string_file for the command output.
 222         * ui-file.c (term_cli_styling): New function (most code moved
 223         from utils.c can_emit_style_escape).
 224         (string_file::string_file, string_file::can_emit_style_escape,
 225         stdio_file::can_emit_style_escape, tee_file::term_out,
 226         tee_file::can_emit_style_escape): New functions.
 227
 228 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 229
 230         * NEWS: Mention the new set|show may-call-functions.
 231         * infcall.c (may_call_functions_p): New variable.
 232         (show_may_call_functions_p): New function.
 233         (call_function_by_hand_dummy): Throws an error if not
 234         may-call-functions.
 235         (_initialize_infcall): Call add_setshow_boolean_cmd for
 236         may-call-functions.
 237
 238 2019-04-25  Keith Seitz  <keiths@redhat.com>
 239
 240         PR c++/24367
 241         * cp-support.c (inspect_type): Don't attempt substitutions
 242         of symbol with the same name.
 243
 244 2019-04-25  Tom Tromey  <tromey@adacore.com>
 245
 246         PR gdb/24475:
 247         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
 248         static.
 249
 250 2019-04-25  Tom Tromey  <tromey@adacore.com>
 251
 252         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
 253         rvalue reference.
 254         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
 255         (gdb_xml_parser::parse): Use std::move.
 256         * python/python-internal.h (gdbpy_convert_exception): Take a const
 257         reference.
 258         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
 259         std::move.
 260         * python/py-utils.c (gdbpy_convert_exception): Take a const
 261         reference.
 262         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 263         Use std::move.
 264         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 265         Use std::move.
 266         * mi/mi-main.c (mi_print_exception): Take a const reference.
 267         * main.c (handle_command_errors): Take a const reference.
 268         * linespec.c (parse_linespec): Use std::move.
 269         * infcall.c (run_inferior_call): Use std::move.
 270         (call_function_by_hand_dummy): Use std::move.
 271         * exec.c (try_open_exec_file): Use std::move.
 272         * exceptions.h (exception_print, exception_fprintf)
 273         (exception_print_same): Update.
 274         * exceptions.c (print_exception, exception_print)
 275         (exception_fprintf, exception_print_same): Change parameters to
 276         const reference.
 277         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
 278         * common/new-op.c: Use std::move.
 279         * common/common-exceptions.h (struct gdb_exception): Add move
 280         constructor.
 281         (struct gdb_exception_error, struct gdb_exception_quit, struct
 282         gdb_quit_bad_alloc): Change constructor to move constructor.
 283         (throw_exception): Change parameter to rvalue reference.
 284         * common/common-exceptions.c (throw_exception): Take rvalue
 285         reference.
 286         * cli/cli-interp.c (safe_execute_command): Use std::move.
 287         * breakpoint.c (insert_bp_location, location_to_sals): Use
 288         std::move.
 289
 290 2019-04-25  Tom Tromey  <tromey@adacore.com>
 291
 292         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
 293         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
 294         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
 295         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
 296         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
 297         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
 298         guile/scm-value.c: Use unpack.
 299         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
 300         gdbscm_gdb_exception.
 301         (gdbscm_throw_gdb_exception): Likewise.
 302         (struct gdbscm_gdb_exception): New.
 303         (unpack): New function.
 304         (gdbscm_wrap): Use unpack.
 305
 306 2019-04-25  Tom Tromey  <tromey@adacore.com>
 307
 308         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 309         (gdb_rl_callback_handler): Use std::move.
 310         * common/common-exceptions.h (struct gdb_exception): Add move
 311         assignment operator.
 312         (throw_exception_sjlj): Change "exception" to const reference.
 313         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
 314         (throw_exception_sjlj): Change "exception" to const reference.
 315
 316 2019-04-25  Tom Tromey  <tromey@adacore.com>
 317
 318         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
 319         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
 320         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
 321         Update.
 322         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
 323         Update.
 324         * mi/mi-interp.c (mi_interp::exec): Update.
 325         * linespec.c (parse_linespec): Update.
 326         * infcall.c (run_inferior_call): Update.
 327         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
 328         * guile/scm-symbol.c (gdbscm_lookup_symbol)
 329         (gdbscm_lookup_global_symbol): Update.
 330         * guile/scm-param.c (gdbscm_parameter_value): Update.
 331         * guile/scm-frame.c (gdbscm_frame_read_register)
 332         (gdbscm_frame_read_var): Update.
 333         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
 334         * exec.c (try_open_exec_file): Update.
 335         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
 336         (gdb_rl_callback_handler): Update.
 337         * common/common-exceptions.h (exception_none): Don't declare.
 338         * common/common-exceptions.c (exception_none): Don't define.
 339         (struct catcher) <exception>: Update.
 340         * cli/cli-interp.c (safe_execute_command): Update.
 341         * breakpoint.c (insert_bp_location, location_to_sals): Update.
 342
 343 2019-04-25  Ali Tamur  <tamur@google.com>
 344
 345         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
 346         (read_attribute_value): Likewise.
 347         (dwarf2_read_addr_index): Update comment.
 348         (read_str_index): Add DW_FORM_strx.
 349         (dwarf2_string_attr): Likewise.
 350         (dwarf2_const_value_attr): Likewise.
 351         (dump_die_shallow): Likewise.
 352         (dwarf2_fetch_constant_bytes): Likewise.
 353         (skip_form_bytes): Likewise.
 354         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
 355
 356 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
 357
 358         PR corefiles/11608
 359         PR corefiles/18187
 360         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
 361         OFFSET.  Verify if current mapping contains an ELF header.
 362         (linux_find_memory_regions_full): Adjust call to
 363         dump_mapping_p.
 364
 365 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
 366             Kang Li <kanglictf@gmail.com>
 367
 368         PR gdb/21600
 369
 370         * dwarf2-frame.c (read_initial_length): Be consistent about using
 371         unsigned representation of length.
 372         (decode_frame_entry_1): Likewise.  Check for wraparound of
 373         end pointer as well as buffer overflow.
 374
 375 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
 376
 377         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
 378         "vq".
 379
 380 2019-04-24  Tom Tromey  <tromey@adacore.com>
 381
 382         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
 383
 384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 385
 386         * s12z-tdep.c (s12z_unwind_pc): Delete.
 387         (s12z_unwind_sp): Delete.
 388         (s12z_gdbarch_init): Don't register deleted functions with
 389         gdbarch.
 390
 391 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 392
 393         * rl78-tdep.c (rl78_unwind_sp): Delete.
 394         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
 395
 396 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 397
 398         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
 399         (xstormy16_unwind_pc): Delete.
 400         (xstormy16_dummy_id): Delete.
 401         (xstormy16_gdbarch_init): Don't register deleted functions with
 402         gdbarch.
 403
 404 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 405
 406         * vax-tdep.c (vax_unwind_pc): Delete.
 407         (vax_gdbarch_init): Don't register deleted function with gdbarch.
 408
 409 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 410
 411         * v850-tdep.c (v850_unwind_sp): Delete.
 412         (v850_unwind_pc): Delete.
 413         (v850_dummy_id): Delete.
 414         (v850_gdbarch_init): Don't register deleted functions with
 415         gdbarch.
 416
 417 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 418
 419         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
 420         (tilegx_unwind_pc): Delete.
 421         (tilegx_unwind_dummy_id): Delete.
 422         (tilegx_gdbarch_init): Don't register deleted functions with
 423         gdbarch.
 424
 425 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 426
 427         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
 428         (tic6x_dummy_id): Delete.
 429         (tic6x_gdbarch_init): Don't register deleted functions with
 430         gdbarch.
 431
 432 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 433
 434         * sparc-tdep.c (sparc_unwind_pc): Delete.
 435         (sparc32_gdbarch_init): Don't register deleted function with
 436         gdbarch.
 437
 438 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 439
 440         * sh-tdep.c (sh_unwind_sp): Delete.
 441         (sh_unwind_pc): Delete.
 442         (sh_dummy_id): Delete.
 443         (sh_gdbarch_init): Don't register deleted functions with
 444         gdbarch.
 445
 446 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 447
 448         * score-tdep.c (score_unwind_sp): Delete.
 449         (score_unwind_pc): Delete.
 450         (score_dummy_id): Delete.
 451         (score_gdbarch_init): Don't register deleted functions with
 452         gdbarch.
 453
 454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 455
 456         * rx-tdep.c (rx_unwind_pc): Delete.
 457         (rx_unwind_sp): Delete.
 458         (rx_dummy_id): Delete.
 459         (rx_gdbarch_init): Don't register deleted functions with
 460         gdbarch.  Update comment.
 461
 462 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 463
 464         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
 465         (rs6000_dummy_id): Delete.
 466         (rs6000_gdbarch_init): Don't register deleted functions with
 467         gdbarch.
 468
 469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 470
 471         * or1k-tdep.c (or1k_dummy_id): Delete.
 472         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
 473
 474 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 475
 476         * nios2-tdep.c (nios2_dummy_id): Delete.
 477         (nios2_unwind_sp): Delete.
 478         (nios2_gdbarch_init): Don't register deleted functions with
 479         gdbarch.
 480
 481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 482
 483         * nds32-tdep.c (nds32_dummy_id): Delete.
 484         (nds32_unwind_pc): Delete.
 485         (nds32_unwind_sp): Delete.
 486         (nds32_gdbarch_init): Don't register deleted functions with
 487         gdbarch.
 488
 489 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 490
 491         * msp430-tdep.c (msp430_unwind_pc): Delete.
 492         (msp430_unwind_sp): Delete.
 493         (msp430_dummy_id): Delete.
 494         (msp430_gdbarch_init): Don't register deleted functions with
 495         gdbarch.
 496
 497 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 498
 499         * moxie-tdep.c (moxie_unwind_sp): Delete.
 500         (moxie_unwind_pc): Delete.
 501         (moxie_dummy_id): Delete.
 502         (moxie_gdbarch_init): Don't register deleted functions with
 503         gdbarch.
 504
 505 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 506
 507         * mn10300-tdep.c (mn10300_dummy_id): Delete.
 508         (mn10300_unwind_pc): Delete.
 509         (mn10300_unwind_sp): Delete.
 510         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
 511         mn10300_unwind_sp.
 512         (mn10300_frame_unwind_init): Don't register deleted functions with
 513         gdbarch.
 514
 515 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 516
 517         * mep-tdep.c (mep_unwind_pc): Delete.
 518         (mep_unwind_sp): Delete.
 519         (mep_dummy_id): Delete.
 520         (mep_gdbarch_init): Don't register deleted functions with
 521         gdbarch.
 522
 523 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 524
 525         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
 526         (m68hc11_unwind_sp): Delete.
 527         (m68hc11_gdbarch_init): Don't register deleted functions with
 528         gdbarch.
 529
 530 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 531
 532         * m32r-tdep.c (m32r_unwind_sp): Delete.
 533         (m32r_unwind_pc): Delete.
 534         (m32r_dummy_id): Delete.
 535         (m32r_gdbarch_init): Don't register deleted functions with
 536         gdbarch.
 537
 538 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 539
 540         * m32c-tdep.c (m32c_unwind_pc): Delete.
 541         (m32c_unwind_sp): Delete.
 542         (m32c_dummy_id): Delete.
 543         (m32c_gdbarch_init): Don't register deleted functions with
 544         gdbarch.
 545
 546 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 547
 548         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
 549         (lm32_unwind_pc): Delete.
 550         (lm32_dummy_id): Delete.
 551         (lm32_gdbarch_init): Don't register deleted functions with
 552         gdbarch.
 553
 554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 555
 556         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
 557         (iq2000_unwind_pc): Delete.
 558         (iq2000_dummy_id): Delete.
 559         (iq2000_gdbarch_init): Don't register deleted functions with
 560         gdbarch.
 561
 562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 563
 564         * nds32-tdep.c (nds32_type_align): Delete.
 565         (nds32_push_dummy_call): Use type_align instead.
 566
 567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 568
 569         * arm-tdep.c (arm_type_align): Only handle vector override case.
 570         (arm_push_dummy_call): Use type_align.
 571         (arm_gdbarch_init): Register arm_type_align gdbarch function.
 572
 573 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 574
 575         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
 576         case.
 577         (pass_on_stack): Use type_align.
 578         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
 579         function.
 580
 581 2019-04-23  Tom Tromey  <tromey@adacore.com>
 582
 583         * dwarf2read.c (line_header::file_name_at): Remove unused
 584         overload.
 585
 586 2019-04-23  Tom de Vries  <tdevries@suse.de>
 587
 588         PR gdb/24438
 589         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 590         invocation.
 591
 592
 593 2019-03-27  Ali Tamur  <tamur@google.com>
 594
 595         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 596         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 597         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 598         (dwarf_expr_context::get_addr_index): Likewise
 599         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 600         (symbol_needs_eval_context::get_addr_index): Likewise
 601         (disassemble_dwarf_expression): Add DW_OP_addrx
 602         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 603         (read_cutu_die_from_dwo): Update comment
 604         (skip_one_die): Add DW_FORM_addrx
 605         (read_attribute_value): Likewise
 606         (var_decode_location): Add DW_OP_addrx
 607         (dwarf2_const_value_attr): Add DW_FORM_addrx
 608         (dump_die_shallow): Likewise
 609         (dwarf2_fetch_constant_bytes): Likewise
 610         (decode_locdesc): Add DW_OP_addrx
 611         (skip_form_bytes): Add DW_FORM_addrx
 612
 613 2019-04-22  Ali Tamur  <tamur@google.com>
 614
 615         * MAINTAINERS (Write After Approval): Add self.
 616
 617 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 618
 619         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 620         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 621         (open_symbol_file_object): Likewise.
 622         (svr4_default_sos): Add info parameter.
 623         (svr4_read_so_list): Likewise.
 624         (svr4_current_sos_direct): Adjust functions calls to pass down
 625         info.
 626         (svr4_current_sos_1): Add info parameter.
 627         (svr4_current_sos): Call get_svr4_info, pass info down to
 628         svr4_current_sos_1.
 629         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 630         get_svr4_info.
 631         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 632         get_svr4_info.
 633         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 634         to get_svr4_info.
 635         (probes_table_remove_objfile_probes): Likewise.
 636         (register_solib_event_probe): Add info parameter.
 637         (solist_update_incremental): Pass info parameter down to
 638         svr4_read_so_list.
 639         (disable_probes_interface): Add info parameter.
 640         (svr4_handle_solib_event): Pass current_program_space to
 641         get_svr4_info.  Adjust disable_probes_interface cleanup.
 642         (svr4_create_probe_breakpoints): Add info parameter, pass it
 643         down to register_solib_event_probe.
 644         (svr4_create_solib_event_breakpoints): Add info parameter,
 645         pass it down to svr4_create_probe_breakpoints.
 646         (enable_break): Pass info down to
 647         svr4_create_solib_event_breakpoints.
 648         (svr4_solib_create_inferior_hook): Pass current_program_space to
 649         get_svr4_info.
 650         (svr4_clear_solib): Likewise.
 651
 652 2019-04-22  Pedro Alves  <palves@redhat.com>
 653
 654         * solib-svr4.c (svr4_free_objfile_observer): New.
 655         (probe_and_action::objfile): New field.
 656         (probes_table_htab_remove_objfile_probes)
 657         (probes_table_remove_objfile_probes): New functions.
 658         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 659         in the new probe_and_action.  Don't store the probe in 'lookup'.
 660         (svr4_create_probe_breakpoints): Pass objfile to
 661         register_solib_event_probe.
 662         (_initialize_svr4_solib): Register a free_objfile observer.
 663
 664 2019-04-19  Tom Tromey  <tom@tromey.com>
 665
 666         * common/queue.h: Remove.
 667
 668 2019-04-19  Tom Tromey  <tom@tromey.com>
 669
 670         * event-loop.c: Don't include "common/queue.h".
 671
 672 2019-04-19  Tom Tromey  <tom@tromey.com>
 673
 674         * remote.c (remote_target): Use delete.
 675         * remote-notif.h: Include <list>, not "common/queue.h".
 676         (notif_client_p): Remove typedef.
 677         (remote_notif_state): Add constructor, destructor, initializer.
 678         <notif_queue>: Now a std::list.
 679         (remote_notif_state_xfree): Don't declare.
 680         * remote-notif.c (remote_notif_process, handle_notification)
 681         (remote_notif_state_allocate): Update.
 682         (~remote_notif_state): Rename from remote_notif_state_xfree.
 683
 684 2019-04-19  Tom Tromey  <tom@tromey.com>
 685
 686         * symfile.c (reread_symbols): Update.
 687         * objfiles.c (objfile_register_static_link)
 688         (objfile_lookup_static_link): Update
 689         (~objfile) Don't delete static_links.
 690         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 691
 692 2019-04-19  Tom Tromey  <tom@tromey.com>
 693
 694         * type-stack.h (struct type_stack) <insert>: Constify string.
 695         * type-stack.c (type_stack::insert): Constify string.
 696         * gdbtypes.h (lookup_template_type): Update.
 697         (address_space_name_to_int): Update.
 698         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 699         const.
 700         (lookup_template_type): Make name const.
 701         * c-exp.y: Update rules.
 702         (lex_one_token, classify_name, classify_inner_name)
 703         (c_print_token): Update.
 704         * p-exp.y: Update rules.
 705         (yylex): Update.
 706         * f-exp.y: Update rules.
 707         (yylex): Update.
 708         * d-exp.y: Update rules.
 709         (lex_one_token, classify_name, classify_inner_name): Update.
 710         * parse.c (write_dollar_variable, copy_name): Return std::string.
 711         * parser-defs.h (copy_name): Change return type.
 712         * m2-exp.y: Update rules.
 713         (yylex): Update.
 714         * go-exp.y (lex_one_token): Update.
 715         Update rules.
 716         (classify_unsafe_function, classify_packaged_name)
 717         (classify_name, yylex): Update.
 718
 719 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 720
 721         * configure.ac: add --enable-source-highlight switch.
 722         * configure: Regenerate.
 723         * top.c (print_gdb_version): plumb --enable-source-highlight
 724         status to "show configuration".
 725
 726 2019-04-19  Tom Tromey  <tromey@adacore.com>
 727
 728         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 729         Check ADA_TYPE_P.
 730         (empty_record, ada_template_to_fixed_record_type_1)
 731         (template_to_static_fixed_type)
 732         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 733         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 734         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 735         macros.
 736
 737 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 738
 739         PR symtab/24423:
 740         * source.c (print_source_lines_base): Advance "iter" when a
 741         control character is seen.
 742
 743 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 744
 745         * inferior.h (struct infcall_suspend_state_deleter):
 746         Catch exception in destructor to avoid crash.
 747
 748 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 749
 750         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 751         close to the add_com "shell".
 752
 753 2019-04-18  Tom Tromey  <tromey@adacore.com>
 754
 755         * process-stratum-target.h (class process_stratum_target)
 756         <stratum>: Add "final".
 757
 758 2019-04-17  Tom Tromey  <tromey@adacore.com>
 759
 760         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 761         against nullptr before use.
 762
 763 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 764
 765         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 766
 767 2019-04-17  Jim Wilson  <jimw@sifive.com>
 768             Andrew Burgess  <andrew.burgess@embecosm.com>
 769
 770         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 771         code read might fail, assume 4-byte breakpoint in that case.
 772
 773 2019-04-15  Leszek Swirski  <leszeks@google.com>
 774
 775         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 776         rather than a hand-rolled POD check when checking for forced MEMORY
 777         classification.
 778
 779 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 780
 781         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 782         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 783         function.
 784         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 785         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 786         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 787         declaration.
 788
 789 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 790
 791         * aarch64-linux-nat.c
 792         (aarch64_linux_nat_target::thread_architecture): Add override.
 793         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 794         each VQ.
 795
 796 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 797
 798         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 799
 800 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 801
 802         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 803         target types of size 96-bits, add some additional comments, and
 804         check that the builtin type we found was the correct size.
 805
 806 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 807
 808         * utils.c (prompt_for_continue): Don't restore the styling at the
 809         end, as applied_style has the wrong value.  This fixes styling in
 810         long lists of file names that are interrupted by the "Continue?"
 811         prompt.
 812
 813 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 814
 815         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 816         * c-lang.c (c_language_defn): Likewise.
 817         (cplus_language_defn): Likewise.
 818         (asm_language_defn): Likewise.
 819         (minimal_language_defn): Likewise.
 820         * d-lang.c (d_language_defn): Likewise.
 821         * f-lang.c (f_language_defn): Likewise.
 822         * go-lang.c (go_language_defn): Likewise.
 823         * language.c (unknown_language_defn): Likewise.
 824         (auto_language_defn): Likewise.
 825         * language.h (struct language_defn): Remove la_magic field.
 826         (LANG_MAGIC): Delete.
 827         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 828         * objc-lang.c (objc_language_defn): Likewise.
 829         * opencl-lang.c (opencl_language_defn): Likewise.
 830         * p-lang.c (pascal_language_defn): Likewise.
 831         * rust-lang.c (rust_language_defn): Likewise.
 832
 833 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 834
 835         * riscv-tdep.c (riscv_type_align): New function.
 836         (riscv_type_alignment): Delete.
 837         (riscv_arg_location): Use 'type_align'.
 838         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 839
 840 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 841
 842         * gdbtypes.c (type_align): A struct with no non-static fields also
 843         has alignment of 1.
 844
 845 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 846
 847         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 848         component to 0.
 849         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 850         member.
 851         (riscv_struct_info::analyse): New implementation using new
 852         analyse_inner member function.
 853         (riscv_struct_info::field_offset): New member function.
 854         (riscv_struct_info::m_offsets): New member variable.
 855         (riscv_struct_info::analyse_inner): New private member function,
 856         takes the old implementation of riscv_struct_info::analyse but
 857         extended to track field offsets.
 858         (riscv_call_arg_struct): Update the struct folding special cases
 859         to handle cases where empty C++ structs, which are non-zero
 860         length, are found.
 861         (riscv_arg_location): Initialise the length of each location, a
 862         non-zero length now indicates the location is in use.
 863         (riscv_push_dummy_call): Allow for the first location having a
 864         non-zero offset when setting up arguments.
 865         (riscv_return_value): Likewise, but for return values.
 866
 867 2019-04-11  Tom Tromey  <tromey@adacore.com>
 868
 869         * utils.c (internal_vproblem): Make "msg" const.
 870
 871 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 872
 873         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 874         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 875         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 876         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 877
 878 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 879
 880         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 881         function.
 882         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 883         of amd64_collect_native_gregset.
 884         (amd64_linux_nat_target::store_registers): Likewise.
 885
 886 2019-04-10  Tom Tromey  <tom@tromey.com>
 887
 888         * symtab.c (lookup_global_symbol_from_objfile)
 889         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 890         * objfiles.h (class separate_debug_iterator): New.
 891         (class separate_debug_range): New.
 892         (struct objfile) <separate_debug_objfiles>: New method.
 893         (objfile_separate_debug_iterate): Don't declare.
 894         * objfiles.c (separate_debug_iterator::operator++): Rename from
 895         objfile_separate_debug_iterate.
 896         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 897         iterator.
 898         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 899         iterator.
 900
 901 2019-04-10  Tom Tromey  <tom@tromey.com>
 902
 903         * symfile.c (reread_symbols): Remove old comment.
 904         * objfiles.c (free_all_objfiles): Fix a typo.
 905
 906 2019-04-10  Tom Tromey  <tom@tromey.com>
 907
 908         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 909         * minsyms.c (lookup_minimal_symbol): Use foreach.
 910         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 911         (lookup_minimal_symbol_solib_trampoline): Likewise.
 912         * symfile.c (reread_symbols): Use foreach.
 913
 914 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 915             Tom Tromey  <tromey@adacore.com>
 916
 917         PR rust/24414:
 918         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 919         (rust_lex_int_test): Change "value" to be LONGEST.
 920         (rust_lex_tests): Add test for long integer literal.
 921
 922 2019-04-09  Tom Tromey  <tromey@adacore.com>
 923
 924         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 925         to bool.
 926         (extended_remote_target::attach): Update.
 927         (remote_target::remote_notice_new_inferior): Update.
 928         (remote_target::add_current_inferior_and_thread): Update.
 929         * inferior.c (exit_inferior_1): Use "false".
 930         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 931
 932 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 933
 934         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 935         the "start" command.
 936
 937 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 938
 939         * python/py-inferior.c (infpy_thread_from_thread_handle):
 940         Adjust comments to reflect renaming of thread_from_thread_handle
 941         to thread_from_handle.  Adjust keywords.  Fix type error message.
 942         (inferior_object_methods): Add thread_from_handle.  Retain
 943         thread_from_thread_handle, but mark it as deprecated.
 944
 945 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 946
 947         * gdbthread.h (find_thread_by_handle): Revise declaration.
 948         * thread.c (find_thread_by_handle): Likewise.  Adjust
 949         implementation too.
 950         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 951         support for buffer objects as handles.
 952
 953 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 954
 955         * python/py-infthread.c (thpy_thread_handle): New function.
 956         (thread_object_methods): Register thpy_thread_handle.
 957
 958 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 959
 960         * gdbthread.h (thread_to_thread_handle): Declare.
 961         * thread.c (gdbtypes.h): Include.
 962         (thread_to_thread_handle): New function.
 963
 964         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 965         (target_thread_info_to_thread_handle): Declare.
 966         * target.c (target_thread_info_to_thread_handle): New function.
 967         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 968         * target-delegates.c: Regenerate.
 969
 970         * linux-thread-db.c (class thread_db_target): Add method
 971         thread_info_to_thread_handle.
 972         (thread_db_target::thread_info_to_thread_handle): Define.
 973         * remote.c (class remote_target): Add new method
 974         thread_info_to_thread_handle.
 975         (remote_target::thread_info_to_thread_handle): Define.
 976
 977 2019-04-08  Pedro Alves  <palves@redhat.com>
 978
 979         * common/common-exceptions.c (throw_exception): Don't create
 980         named object to throw; throw directly.
 981         (throw_it): Likewise.  Don't initialize gdb_exception::message
 982         here, with new; pass FMT and AP to the ctor instead.
 983         * common/common-exceptions.h: Include <string>.
 984         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 985         const char *, va_list)): New ctor.  Use std::make_shared.
 986         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 987         errors)): Delete.
 988         (gdb_exception_error::gdb_exception_error(enum errors, const char
 989         *, va_list)): New.
 990         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 991         Add assertion.
 992         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 993         errors)): Delete.
 994         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 995         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 996         Add assertion.
 997
 998 2019-04-08  Tom Tromey  <tom@tromey.com>
 999
1000         * valops.c (value_rtti_indirect_type): Replace throw_exception
1001         with throw.
1002         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
1003         with throw.
1004         * thread.c (thr_try_catch_cmd): Replace throw_exception with
1005         throw.
1006         * target.c (target_translate_tls_address): Replace throw_exception
1007         with throw.
1008         * stack.c (frame_apply_command_count): Replace throw_exception
1009         with throw.
1010         * solib-spu.c (append_ocl_sos): Replace throw_exception with
1011         throw.
1012         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
1013         with throw.
1014         * rs6000-tdep.c (rs6000_frame_cache)
1015         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
1016         * remote.c: Replace throw_exception with throw.
1017         * record-full.c (record_full_message, record_full_wait_1)
1018         (record_full_restore): Replace throw_exception with throw.
1019         * record-btrace.c:
1020         (get_thread_current_frame_id, record_btrace_start_replaying)
1021         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
1022         (cmd_record_btrace_start): Replace throw_exception with throw.
1023         * parse.c (parse_exp_in_context_1): Replace throw_exception with
1024         throw.
1025         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
1026         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
1027         * linespec.c:
1028         (find_linespec_symbols): Replace throw_exception with throw.
1029         * infrun.c (displaced_step_prepare, resume): Replace
1030         throw_exception with throw.
1031         * infcmd.c (post_create_inferior): Replace throw_exception with
1032         throw.
1033         * inf-loop.c (inferior_event_handler): Replace throw_exception
1034         with throw.
1035         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
1036         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
1037         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
1038         (get_prev_frame_always, get_frame_pc_if_available)
1039         (get_frame_address_in_block_if_available, get_frame_language):
1040         Replace throw_exception with throw.
1041         * frame-unwind.c (frame_unwind_try_unwinder): Replace
1042         throw_exception with throw.
1043         * eval.c (fetch_subexp_value, evaluate_var_value)
1044         (evaluate_funcall, evaluate_subexp_standard): Replace
1045         throw_exception with throw.
1046         * dwarf2loc.c (call_site_find_chain)
1047         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
1048         Replace throw_exception with throw.
1049         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
1050         with throw.
1051         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
1052         throw.
1053         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
1054         * completer.c (complete_line_internal): Replace throw_exception
1055         with throw.
1056         * compile/compile-object-run.c (compile_object_run): Replace
1057         throw_exception with throw.
1058         * cli/cli-script.c (process_next_line): Replace throw_exception
1059         with throw.
1060         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
1061         (btrace_enable, btrace_maint_update_pt_packets): Replace
1062         throw_exception with throw.
1063         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
1064         throw_exception with throw.
1065         * break-catch-throw.c (re_set_exception_catchpoint): Replace
1066         throw_exception with throw.
1067         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
1068         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
1069         * aarch64-tdep.c (aarch64_make_prologue_cache)
1070         (aarch64_make_stub_cache): Replace throw_exception with throw.
1071
1072 2019-04-08  Tom Tromey  <tom@tromey.com>
1073
1074         * common/common-exceptions.c (throw_exception): Rename from
1075         throw_exception_cxx.  Remove old copy.  Make argument const.
1076         (throw_it): Create and throw exception objects directly.
1077         * common/common-exceptions.h (throw_exception): Make argument
1078         const.
1079         (struct gdb_exception_error): Add constructor.
1080         (struct gdb_exception_quit): Add constructor.
1081
1082 2019-04-08  Tom Tromey  <tom@tromey.com>
1083
1084         * common/common-exceptions.h (exception_rethrow): Don't declare.
1085         (TRY_SJLJ): Update comment.
1086         (TRY, CATCH, END_CATCH): Remove.
1087         * common/common-exceptions.c (exception_rethrow): Remove.
1088
1089 2019-04-08  Tom Tromey  <tom@tromey.com>
1090
1091         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
1092         Remove.
1093         (gdb_exception_error): Rename from
1094         gdb_exception_RETURN_MASK_ERROR.
1095         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
1096         (gdb_quit_bad_alloc): Update.
1097         * aarch64-tdep.c: Update.
1098         * ada-lang.c: Update.
1099         * ada-typeprint.c: Update.
1100         * ada-valprint.c: Update.
1101         * amd64-tdep.c: Update.
1102         * arch-utils.c: Update.
1103         * break-catch-throw.c: Update.
1104         * breakpoint.c: Update.
1105         * btrace.c: Update.
1106         * c-varobj.c: Update.
1107         * cli/cli-cmds.c: Update.
1108         * cli/cli-interp.c: Update.
1109         * cli/cli-script.c: Update.
1110         * common/common-exceptions.c: Update.
1111         * common/new-op.c: Update.
1112         * common/selftest.c: Update.
1113         * compile/compile-c-symbols.c: Update.
1114         * compile/compile-cplus-symbols.c: Update.
1115         * compile/compile-object-load.c: Update.
1116         * compile/compile-object-run.c: Update.
1117         * completer.c: Update.
1118         * corelow.c: Update.
1119         * cp-abi.c: Update.
1120         * cp-support.c: Update.
1121         * cp-valprint.c: Update.
1122         * darwin-nat.c: Update.
1123         * disasm-selftests.c: Update.
1124         * dtrace-probe.c: Update.
1125         * dwarf-index-cache.c: Update.
1126         * dwarf-index-write.c: Update.
1127         * dwarf2-frame-tailcall.c: Update.
1128         * dwarf2-frame.c: Update.
1129         * dwarf2loc.c: Update.
1130         * dwarf2read.c: Update.
1131         * eval.c: Update.
1132         * event-loop.c: Update.
1133         * event-top.c: Update.
1134         * exec.c: Update.
1135         * f-valprint.c: Update.
1136         * fbsd-tdep.c: Update.
1137         * frame-unwind.c: Update.
1138         * frame.c: Update.
1139         * gdbtypes.c: Update.
1140         * gnu-v3-abi.c: Update.
1141         * guile/guile-internal.h: Update.
1142         * guile/scm-block.c: Update.
1143         * guile/scm-breakpoint.c: Update.
1144         * guile/scm-cmd.c: Update.
1145         * guile/scm-disasm.c: Update.
1146         * guile/scm-frame.c: Update.
1147         * guile/scm-lazy-string.c: Update.
1148         * guile/scm-math.c: Update.
1149         * guile/scm-param.c: Update.
1150         * guile/scm-ports.c: Update.
1151         * guile/scm-pretty-print.c: Update.
1152         * guile/scm-symbol.c: Update.
1153         * guile/scm-symtab.c: Update.
1154         * guile/scm-type.c: Update.
1155         * guile/scm-value.c: Update.
1156         * i386-linux-tdep.c: Update.
1157         * i386-tdep.c: Update.
1158         * inf-loop.c: Update.
1159         * infcall.c: Update.
1160         * infcmd.c: Update.
1161         * infrun.c: Update.
1162         * jit.c: Update.
1163         * language.c: Update.
1164         * linespec.c: Update.
1165         * linux-fork.c: Update.
1166         * linux-nat.c: Update.
1167         * linux-tdep.c: Update.
1168         * linux-thread-db.c: Update.
1169         * main.c: Update.
1170         * mi/mi-cmd-break.c: Update.
1171         * mi/mi-cmd-stack.c: Update.
1172         * mi/mi-interp.c: Update.
1173         * mi/mi-main.c: Update.
1174         * objc-lang.c: Update.
1175         * p-valprint.c: Update.
1176         * parse.c: Update.
1177         * ppc-linux-tdep.c: Update.
1178         * printcmd.c: Update.
1179         * python/py-arch.c: Update.
1180         * python/py-breakpoint.c: Update.
1181         * python/py-cmd.c: Update.
1182         * python/py-finishbreakpoint.c: Update.
1183         * python/py-frame.c: Update.
1184         * python/py-framefilter.c: Update.
1185         * python/py-gdb-readline.c: Update.
1186         * python/py-inferior.c: Update.
1187         * python/py-infthread.c: Update.
1188         * python/py-lazy-string.c: Update.
1189         * python/py-linetable.c: Update.
1190         * python/py-objfile.c: Update.
1191         * python/py-param.c: Update.
1192         * python/py-prettyprint.c: Update.
1193         * python/py-progspace.c: Update.
1194         * python/py-record-btrace.c: Update.
1195         * python/py-record.c: Update.
1196         * python/py-symbol.c: Update.
1197         * python/py-type.c: Update.
1198         * python/py-unwind.c: Update.
1199         * python/py-utils.c: Update.
1200         * python/py-value.c: Update.
1201         * python/python.c: Update.
1202         * record-btrace.c: Update.
1203         * record-full.c: Update.
1204         * remote-fileio.c: Update.
1205         * remote.c: Update.
1206         * riscv-tdep.c: Update.
1207         * rs6000-aix-tdep.c: Update.
1208         * rs6000-tdep.c: Update.
1209         * rust-exp.y: Update.
1210         * rust-lang.c: Update.
1211         * s390-tdep.c: Update.
1212         * selftest-arch.c: Update.
1213         * solib-dsbt.c: Update.
1214         * solib-frv.c: Update.
1215         * solib-spu.c: Update.
1216         * solib-svr4.c: Update.
1217         * solib.c: Update.
1218         * sparc64-linux-tdep.c: Update.
1219         * stack.c: Update.
1220         * symfile-mem.c: Update.
1221         * symmisc.c: Update.
1222         * target.c: Update.
1223         * thread.c: Update.
1224         * top.c: Update.
1225         * tracefile-tfile.c: Update.
1226         * tui/tui.c: Update.
1227         * typeprint.c: Update.
1228         * unittests/cli-utils-selftests.c: Update.
1229         * unittests/parse-connection-spec-selftests.c: Update.
1230         * valops.c: Update.
1231         * valprint.c: Update.
1232         * value.c: Update.
1233         * varobj.c: Update.
1234         * windows-nat.c: Update.
1235         * x86-linux-nat.c: Update.
1236         * xml-support.c: Update.
1237
1238 2019-04-08  Tom Tromey  <tom@tromey.com>
1239
1240         * xml-support.c: Use C++ exception handling.
1241         * x86-linux-nat.c: Use C++ exception handling.
1242         * windows-nat.c: Use C++ exception handling.
1243         * varobj.c: Use C++ exception handling.
1244         * value.c: Use C++ exception handling.
1245         * valprint.c: Use C++ exception handling.
1246         * valops.c: Use C++ exception handling.
1247         * unittests/parse-connection-spec-selftests.c: Use C++ exception
1248         handling.
1249         * unittests/cli-utils-selftests.c: Use C++ exception handling.
1250         * typeprint.c: Use C++ exception handling.
1251         * tui/tui.c: Use C++ exception handling.
1252         * tracefile-tfile.c: Use C++ exception handling.
1253         * top.c: Use C++ exception handling.
1254         * thread.c: Use C++ exception handling.
1255         * target.c: Use C++ exception handling.
1256         * symmisc.c: Use C++ exception handling.
1257         * symfile-mem.c: Use C++ exception handling.
1258         * stack.c: Use C++ exception handling.
1259         * sparc64-linux-tdep.c: Use C++ exception handling.
1260         * solib.c: Use C++ exception handling.
1261         * solib-svr4.c: Use C++ exception handling.
1262         * solib-spu.c: Use C++ exception handling.
1263         * solib-frv.c: Use C++ exception handling.
1264         * solib-dsbt.c: Use C++ exception handling.
1265         * selftest-arch.c: Use C++ exception handling.
1266         * s390-tdep.c: Use C++ exception handling.
1267         * rust-lang.c: Use C++ exception handling.
1268         * rust-exp.y: Use C++ exception handling.
1269         * rs6000-tdep.c: Use C++ exception handling.
1270         * rs6000-aix-tdep.c: Use C++ exception handling.
1271         * riscv-tdep.c: Use C++ exception handling.
1272         * remote.c: Use C++ exception handling.
1273         * remote-fileio.c: Use C++ exception handling.
1274         * record-full.c: Use C++ exception handling.
1275         * record-btrace.c: Use C++ exception handling.
1276         * python/python.c: Use C++ exception handling.
1277         * python/py-value.c: Use C++ exception handling.
1278         * python/py-utils.c: Use C++ exception handling.
1279         * python/py-unwind.c: Use C++ exception handling.
1280         * python/py-type.c: Use C++ exception handling.
1281         * python/py-symbol.c: Use C++ exception handling.
1282         * python/py-record.c: Use C++ exception handling.
1283         * python/py-record-btrace.c: Use C++ exception handling.
1284         * python/py-progspace.c: Use C++ exception handling.
1285         * python/py-prettyprint.c: Use C++ exception handling.
1286         * python/py-param.c: Use C++ exception handling.
1287         * python/py-objfile.c: Use C++ exception handling.
1288         * python/py-linetable.c: Use C++ exception handling.
1289         * python/py-lazy-string.c: Use C++ exception handling.
1290         * python/py-infthread.c: Use C++ exception handling.
1291         * python/py-inferior.c: Use C++ exception handling.
1292         * python/py-gdb-readline.c: Use C++ exception handling.
1293         * python/py-framefilter.c: Use C++ exception handling.
1294         * python/py-frame.c: Use C++ exception handling.
1295         * python/py-finishbreakpoint.c: Use C++ exception handling.
1296         * python/py-cmd.c: Use C++ exception handling.
1297         * python/py-breakpoint.c: Use C++ exception handling.
1298         * python/py-arch.c: Use C++ exception handling.
1299         * printcmd.c: Use C++ exception handling.
1300         * ppc-linux-tdep.c: Use C++ exception handling.
1301         * parse.c: Use C++ exception handling.
1302         * p-valprint.c: Use C++ exception handling.
1303         * objc-lang.c: Use C++ exception handling.
1304         * mi/mi-main.c: Use C++ exception handling.
1305         * mi/mi-interp.c: Use C++ exception handling.
1306         * mi/mi-cmd-stack.c: Use C++ exception handling.
1307         * mi/mi-cmd-break.c: Use C++ exception handling.
1308         * main.c: Use C++ exception handling.
1309         * linux-thread-db.c: Use C++ exception handling.
1310         * linux-tdep.c: Use C++ exception handling.
1311         * linux-nat.c: Use C++ exception handling.
1312         * linux-fork.c: Use C++ exception handling.
1313         * linespec.c: Use C++ exception handling.
1314         * language.c: Use C++ exception handling.
1315         * jit.c: Use C++ exception handling.
1316         * infrun.c: Use C++ exception handling.
1317         * infcmd.c: Use C++ exception handling.
1318         * infcall.c: Use C++ exception handling.
1319         * inf-loop.c: Use C++ exception handling.
1320         * i386-tdep.c: Use C++ exception handling.
1321         * i386-linux-tdep.c: Use C++ exception handling.
1322         * guile/scm-value.c: Use C++ exception handling.
1323         * guile/scm-type.c: Use C++ exception handling.
1324         * guile/scm-symtab.c: Use C++ exception handling.
1325         * guile/scm-symbol.c: Use C++ exception handling.
1326         * guile/scm-pretty-print.c: Use C++ exception handling.
1327         * guile/scm-ports.c: Use C++ exception handling.
1328         * guile/scm-param.c: Use C++ exception handling.
1329         * guile/scm-math.c: Use C++ exception handling.
1330         * guile/scm-lazy-string.c: Use C++ exception handling.
1331         * guile/scm-frame.c: Use C++ exception handling.
1332         * guile/scm-disasm.c: Use C++ exception handling.
1333         * guile/scm-cmd.c: Use C++ exception handling.
1334         * guile/scm-breakpoint.c: Use C++ exception handling.
1335         * guile/scm-block.c: Use C++ exception handling.
1336         * guile/guile-internal.h: Use C++ exception handling.
1337         * gnu-v3-abi.c: Use C++ exception handling.
1338         * gdbtypes.c: Use C++ exception handling.
1339         * frame.c: Use C++ exception handling.
1340         * frame-unwind.c: Use C++ exception handling.
1341         * fbsd-tdep.c: Use C++ exception handling.
1342         * f-valprint.c: Use C++ exception handling.
1343         * exec.c: Use C++ exception handling.
1344         * event-top.c: Use C++ exception handling.
1345         * event-loop.c: Use C++ exception handling.
1346         * eval.c: Use C++ exception handling.
1347         * dwarf2read.c: Use C++ exception handling.
1348         * dwarf2loc.c: Use C++ exception handling.
1349         * dwarf2-frame.c: Use C++ exception handling.
1350         * dwarf2-frame-tailcall.c: Use C++ exception handling.
1351         * dwarf-index-write.c: Use C++ exception handling.
1352         * dwarf-index-cache.c: Use C++ exception handling.
1353         * dtrace-probe.c: Use C++ exception handling.
1354         * disasm-selftests.c: Use C++ exception handling.
1355         * darwin-nat.c: Use C++ exception handling.
1356         * cp-valprint.c: Use C++ exception handling.
1357         * cp-support.c: Use C++ exception handling.
1358         * cp-abi.c: Use C++ exception handling.
1359         * corelow.c: Use C++ exception handling.
1360         * completer.c: Use C++ exception handling.
1361         * compile/compile-object-run.c: Use C++ exception handling.
1362         * compile/compile-object-load.c: Use C++ exception handling.
1363         * compile/compile-cplus-symbols.c: Use C++ exception handling.
1364         * compile/compile-c-symbols.c: Use C++ exception handling.
1365         * common/selftest.c: Use C++ exception handling.
1366         * common/new-op.c: Use C++ exception handling.
1367         * cli/cli-script.c: Use C++ exception handling.
1368         * cli/cli-interp.c: Use C++ exception handling.
1369         * cli/cli-cmds.c: Use C++ exception handling.
1370         * c-varobj.c: Use C++ exception handling.
1371         * btrace.c: Use C++ exception handling.
1372         * breakpoint.c: Use C++ exception handling.
1373         * break-catch-throw.c: Use C++ exception handling.
1374         * arch-utils.c: Use C++ exception handling.
1375         * amd64-tdep.c: Use C++ exception handling.
1376         * ada-valprint.c: Use C++ exception handling.
1377         * ada-typeprint.c: Use C++ exception handling.
1378         * ada-lang.c: Use C++ exception handling.
1379         * aarch64-tdep.c: Use C++ exception handling.
1380
1381 2019-04-08  Tom Tromey  <tom@tromey.com>
1382
1383         * xml-support.c (gdb_xml_parser::parse): Update.
1384         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
1385         * value.c (show_convenience): Update.
1386         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
1387         (test_parse_flags_qcs): Update.
1388         * thread.c (thr_try_catch_cmd): Update.
1389         * target.c (target_translate_tls_address): Update.
1390         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1391         (info_frame_command_core, frame_apply_command_count): Update.
1392         * rust-exp.y (rust_lex_exception_test): Update.
1393         * riscv-tdep.c (riscv_print_one_register_info): Update.
1394         * remote.c (remote_target::enable_btrace): Update.
1395         * record-btrace.c (record_btrace_enable_warn): Update.
1396         * python/py-utils.c (gdbpy_convert_exception): Update.
1397         * printcmd.c (do_one_display, print_variable_and_value): Update.
1398         * mi/mi-main.c (mi_print_exception): Update.
1399         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
1400         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1401         * linux-nat.c (linux_nat_target::attach): Update.
1402         * linux-fork.c (class scoped_switch_fork_info): Update.
1403         * infrun.c (displaced_step_prepare): Update.
1404         * infcall.c (call_function_by_hand_dummy): Update.
1405         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
1406         * gnu-v3-abi.c (print_one_vtable): Update.
1407         * frame.c (get_prev_frame_always): Update.
1408         * f-valprint.c (info_common_command_for_block): Update.
1409         * exec.c (try_open_exec_file): Update.
1410         * exceptions.c (print_exception, exception_print)
1411         (exception_fprintf, exception_print_same): Update.
1412         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
1413         * dwarf-index-cache.c (index_cache::store)
1414         (index_cache::lookup_gdb_index): Update.
1415         * darwin-nat.c (maybe_cache_shell): Update.
1416         * cp-valprint.c (cp_print_value_fields): Update.
1417         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
1418         (gcc_cplus_symbol_address): Update.
1419         * compile/compile-c-symbols.c (gcc_convert_symbol)
1420         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
1421         * common/selftest.c: Update.
1422         * common/common-exceptions.h (struct gdb_exception) <message>: Now
1423         a std::string.
1424         (exception_try_scope_entry, exception_try_scope_exit): Don't
1425         declare.
1426         (struct exception_try_scope): Remove.
1427         (TRY): Don't use exception_try_scope.
1428         (struct gdb_exception): Add constructor, operator=.
1429         <what>: New method.
1430         (struct gdb_exception_RETURN_MASK_ALL)
1431         (struct gdb_exception_RETURN_MASK_ERROR)
1432         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
1433         (struct gdb_quit_bad_alloc): Update.
1434         * common/common-exceptions.c (exception_none): Change
1435         initializer.
1436         (struct catcher) <state, exception>: Initialize inline.
1437         <prev>: Remove member.
1438         (current_catcher): Remove.
1439         (catchers): New global.
1440         (exceptions_state_mc_init): Simplify.
1441         (catcher_pop): Remove.
1442         (exceptions_state_mc, exceptions_state_mc_catch): Update.
1443         (try_scope_depth, exception_try_scope_entry)
1444         (exception_try_scope_exit): Remove.
1445         (throw_exception_sjlj): Update.
1446         (exception_messages, exception_messages_size): Remove.
1447         (throw_it): Simplify.
1448         (gdb_exception_sliced_copy): Remove.
1449         (throw_exception_cxx): Update.
1450         * cli/cli-script.c (script_from_file): Update.
1451         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
1452         Update.
1453         * ada-valprint.c (ada_val_print): Update.
1454         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
1455         (create_excep_cond_exprs): Update.
1456
1457 2019-04-08  Tom Tromey  <tom@tromey.com>
1458
1459         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
1460         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
1461         (TRY, CATCH, END_CATCH): Remove some definitions.
1462         * common/common-exceptions.c: Don't use GDB_XCPT.
1463         (catcher_list_size): Remove.
1464         (throw_exception, throw_it): Simplify.
1465
1466 2019-04-05  Tom Tromey  <tom@tromey.com>
1467
1468         Revert the header-sorting patch.
1469         * ft32-tdep.c: Revert.
1470         * frv-tdep.c: Revert.
1471         * frv-linux-tdep.c: Revert.
1472         * frame.c: Revert.
1473         * frame-unwind.c: Revert.
1474         * frame-base.c: Revert.
1475         * fork-child.c: Revert.
1476         * findvar.c: Revert.
1477         * findcmd.c: Revert.
1478         * filesystem.c: Revert.
1479         * filename-seen-cache.h: Revert.
1480         * filename-seen-cache.c: Revert.
1481         * fbsd-tdep.c: Revert.
1482         * fbsd-nat.h: Revert.
1483         * fbsd-nat.c: Revert.
1484         * f-valprint.c: Revert.
1485         * f-typeprint.c: Revert.
1486         * f-lang.c: Revert.
1487         * extension.h: Revert.
1488         * extension.c: Revert.
1489         * extension-priv.h: Revert.
1490         * expprint.c: Revert.
1491         * exec.h: Revert.
1492         * exec.c: Revert.
1493         * exceptions.c: Revert.
1494         * event-top.c: Revert.
1495         * event-loop.c: Revert.
1496         * eval.c: Revert.
1497         * elfread.c: Revert.
1498         * dwarf2read.h: Revert.
1499         * dwarf2read.c: Revert.
1500         * dwarf2loc.c: Revert.
1501         * dwarf2expr.h: Revert.
1502         * dwarf2expr.c: Revert.
1503         * dwarf2-frame.c: Revert.
1504         * dwarf2-frame-tailcall.c: Revert.
1505         * dwarf-index-write.h: Revert.
1506         * dwarf-index-write.c: Revert.
1507         * dwarf-index-common.c: Revert.
1508         * dwarf-index-cache.h: Revert.
1509         * dwarf-index-cache.c: Revert.
1510         * dummy-frame.c: Revert.
1511         * dtrace-probe.c: Revert.
1512         * disasm.h: Revert.
1513         * disasm.c: Revert.
1514         * disasm-selftests.c: Revert.
1515         * dictionary.c: Revert.
1516         * dicos-tdep.c: Revert.
1517         * demangle.c: Revert.
1518         * dcache.h: Revert.
1519         * dcache.c: Revert.
1520         * darwin-nat.h: Revert.
1521         * darwin-nat.c: Revert.
1522         * darwin-nat-info.c: Revert.
1523         * d-valprint.c: Revert.
1524         * d-namespace.c: Revert.
1525         * d-lang.c: Revert.
1526         * ctf.c: Revert.
1527         * csky-tdep.c: Revert.
1528         * csky-linux-tdep.c: Revert.
1529         * cris-tdep.c: Revert.
1530         * cris-linux-tdep.c: Revert.
1531         * cp-valprint.c: Revert.
1532         * cp-support.c: Revert.
1533         * cp-namespace.c: Revert.
1534         * cp-abi.c: Revert.
1535         * corelow.c: Revert.
1536         * corefile.c: Revert.
1537         * continuations.c: Revert.
1538         * completer.h: Revert.
1539         * completer.c: Revert.
1540         * complaints.c: Revert.
1541         * coffread.c: Revert.
1542         * coff-pe-read.c: Revert.
1543         * cli-out.h: Revert.
1544         * cli-out.c: Revert.
1545         * charset.c: Revert.
1546         * c-varobj.c: Revert.
1547         * c-valprint.c: Revert.
1548         * c-typeprint.c: Revert.
1549         * c-lang.c: Revert.
1550         * buildsym.c: Revert.
1551         * buildsym-legacy.c: Revert.
1552         * build-id.h: Revert.
1553         * build-id.c: Revert.
1554         * btrace.c: Revert.
1555         * bsd-uthread.c: Revert.
1556         * breakpoint.h: Revert.
1557         * breakpoint.c: Revert.
1558         * break-catch-throw.c: Revert.
1559         * break-catch-syscall.c: Revert.
1560         * break-catch-sig.c: Revert.
1561         * blockframe.c: Revert.
1562         * block.c: Revert.
1563         * bfin-tdep.c: Revert.
1564         * bfin-linux-tdep.c: Revert.
1565         * bfd-target.c: Revert.
1566         * bcache.c: Revert.
1567         * ax-general.c: Revert.
1568         * ax-gdb.h: Revert.
1569         * ax-gdb.c: Revert.
1570         * avr-tdep.c: Revert.
1571         * auxv.c: Revert.
1572         * auto-load.c: Revert.
1573         * arm-wince-tdep.c: Revert.
1574         * arm-tdep.c: Revert.
1575         * arm-symbian-tdep.c: Revert.
1576         * arm-pikeos-tdep.c: Revert.
1577         * arm-obsd-tdep.c: Revert.
1578         * arm-nbsd-tdep.c: Revert.
1579         * arm-nbsd-nat.c: Revert.
1580         * arm-linux-tdep.c: Revert.
1581         * arm-linux-nat.c: Revert.
1582         * arm-fbsd-tdep.c: Revert.
1583         * arm-fbsd-nat.c: Revert.
1584         * arm-bsd-tdep.c: Revert.
1585         * arch-utils.c: Revert.
1586         * arc-tdep.c: Revert.
1587         * arc-newlib-tdep.c: Revert.
1588         * annotate.h: Revert.
1589         * annotate.c: Revert.
1590         * amd64-windows-tdep.c: Revert.
1591         * amd64-windows-nat.c: Revert.
1592         * amd64-tdep.c: Revert.
1593         * amd64-sol2-tdep.c: Revert.
1594         * amd64-obsd-tdep.c: Revert.
1595         * amd64-obsd-nat.c: Revert.
1596         * amd64-nbsd-tdep.c: Revert.
1597         * amd64-nbsd-nat.c: Revert.
1598         * amd64-nat.c: Revert.
1599         * amd64-linux-tdep.c: Revert.
1600         * amd64-linux-nat.c: Revert.
1601         * amd64-fbsd-tdep.c: Revert.
1602         * amd64-fbsd-nat.c: Revert.
1603         * amd64-dicos-tdep.c: Revert.
1604         * amd64-darwin-tdep.c: Revert.
1605         * amd64-bsd-nat.c: Revert.
1606         * alpha-tdep.c: Revert.
1607         * alpha-obsd-tdep.c: Revert.
1608         * alpha-nbsd-tdep.c: Revert.
1609         * alpha-mdebug-tdep.c: Revert.
1610         * alpha-linux-tdep.c: Revert.
1611         * alpha-linux-nat.c: Revert.
1612         * alpha-bsd-tdep.c: Revert.
1613         * alpha-bsd-nat.c: Revert.
1614         * aix-thread.c: Revert.
1615         * agent.c: Revert.
1616         * addrmap.c: Revert.
1617         * ada-varobj.c: Revert.
1618         * ada-valprint.c: Revert.
1619         * ada-typeprint.c: Revert.
1620         * ada-tasks.c: Revert.
1621         * ada-lang.c: Revert.
1622         * aarch64-tdep.c: Revert.
1623         * aarch64-ravenscar-thread.c: Revert.
1624         * aarch64-newlib-tdep.c: Revert.
1625         * aarch64-linux-tdep.c: Revert.
1626         * aarch64-linux-nat.c: Revert.
1627         * aarch64-fbsd-tdep.c: Revert.
1628         * aarch64-fbsd-nat.c: Revert.
1629         * aarch32-linux-nat.c: Revert.
1630
1631 2019-04-05  Tom Tromey  <tom@tromey.com>
1632
1633         * ft32-tdep.c: Sort headers.
1634         * frv-tdep.c: Sort headers.
1635         * frv-linux-tdep.c: Sort headers.
1636         * frame.c: Sort headers.
1637         * frame-unwind.c: Sort headers.
1638         * frame-base.c: Sort headers.
1639         * fork-child.c: Sort headers.
1640         * findvar.c: Sort headers.
1641         * findcmd.c: Sort headers.
1642         * filesystem.c: Sort headers.
1643         * filename-seen-cache.h: Sort headers.
1644         * filename-seen-cache.c: Sort headers.
1645         * fbsd-tdep.c: Sort headers.
1646         * fbsd-nat.h: Sort headers.
1647         * fbsd-nat.c: Sort headers.
1648         * f-valprint.c: Sort headers.
1649         * f-typeprint.c: Sort headers.
1650         * f-lang.c: Sort headers.
1651         * extension.h: Sort headers.
1652         * extension.c: Sort headers.
1653         * extension-priv.h: Sort headers.
1654         * expprint.c: Sort headers.
1655         * exec.h: Sort headers.
1656         * exec.c: Sort headers.
1657         * exceptions.c: Sort headers.
1658         * event-top.c: Sort headers.
1659         * event-loop.c: Sort headers.
1660         * eval.c: Sort headers.
1661         * elfread.c: Sort headers.
1662         * dwarf2read.h: Sort headers.
1663         * dwarf2read.c: Sort headers.
1664         * dwarf2loc.c: Sort headers.
1665         * dwarf2expr.h: Sort headers.
1666         * dwarf2expr.c: Sort headers.
1667         * dwarf2-frame.c: Sort headers.
1668         * dwarf2-frame-tailcall.c: Sort headers.
1669         * dwarf-index-write.h: Sort headers.
1670         * dwarf-index-write.c: Sort headers.
1671         * dwarf-index-common.c: Sort headers.
1672         * dwarf-index-cache.h: Sort headers.
1673         * dwarf-index-cache.c: Sort headers.
1674         * dummy-frame.c: Sort headers.
1675         * dtrace-probe.c: Sort headers.
1676         * disasm.h: Sort headers.
1677         * disasm.c: Sort headers.
1678         * disasm-selftests.c: Sort headers.
1679         * dictionary.c: Sort headers.
1680         * dicos-tdep.c: Sort headers.
1681         * demangle.c: Sort headers.
1682         * dcache.h: Sort headers.
1683         * dcache.c: Sort headers.
1684         * darwin-nat.h: Sort headers.
1685         * darwin-nat.c: Sort headers.
1686         * darwin-nat-info.c: Sort headers.
1687         * d-valprint.c: Sort headers.
1688         * d-namespace.c: Sort headers.
1689         * d-lang.c: Sort headers.
1690         * ctf.c: Sort headers.
1691         * csky-tdep.c: Sort headers.
1692         * csky-linux-tdep.c: Sort headers.
1693         * cris-tdep.c: Sort headers.
1694         * cris-linux-tdep.c: Sort headers.
1695         * cp-valprint.c: Sort headers.
1696         * cp-support.c: Sort headers.
1697         * cp-namespace.c: Sort headers.
1698         * cp-abi.c: Sort headers.
1699         * corelow.c: Sort headers.
1700         * corefile.c: Sort headers.
1701         * continuations.c: Sort headers.
1702         * completer.h: Sort headers.
1703         * completer.c: Sort headers.
1704         * complaints.c: Sort headers.
1705         * coffread.c: Sort headers.
1706         * coff-pe-read.c: Sort headers.
1707         * cli-out.h: Sort headers.
1708         * cli-out.c: Sort headers.
1709         * charset.c: Sort headers.
1710         * c-varobj.c: Sort headers.
1711         * c-valprint.c: Sort headers.
1712         * c-typeprint.c: Sort headers.
1713         * c-lang.c: Sort headers.
1714         * buildsym.c: Sort headers.
1715         * buildsym-legacy.c: Sort headers.
1716         * build-id.h: Sort headers.
1717         * build-id.c: Sort headers.
1718         * btrace.c: Sort headers.
1719         * bsd-uthread.c: Sort headers.
1720         * breakpoint.h: Sort headers.
1721         * breakpoint.c: Sort headers.
1722         * break-catch-throw.c: Sort headers.
1723         * break-catch-syscall.c: Sort headers.
1724         * break-catch-sig.c: Sort headers.
1725         * blockframe.c: Sort headers.
1726         * block.c: Sort headers.
1727         * bfin-tdep.c: Sort headers.
1728         * bfin-linux-tdep.c: Sort headers.
1729         * bfd-target.c: Sort headers.
1730         * bcache.c: Sort headers.
1731         * ax-general.c: Sort headers.
1732         * ax-gdb.h: Sort headers.
1733         * ax-gdb.c: Sort headers.
1734         * avr-tdep.c: Sort headers.
1735         * auxv.c: Sort headers.
1736         * auto-load.c: Sort headers.
1737         * arm-wince-tdep.c: Sort headers.
1738         * arm-tdep.c: Sort headers.
1739         * arm-symbian-tdep.c: Sort headers.
1740         * arm-pikeos-tdep.c: Sort headers.
1741         * arm-obsd-tdep.c: Sort headers.
1742         * arm-nbsd-tdep.c: Sort headers.
1743         * arm-nbsd-nat.c: Sort headers.
1744         * arm-linux-tdep.c: Sort headers.
1745         * arm-linux-nat.c: Sort headers.
1746         * arm-fbsd-tdep.c: Sort headers.
1747         * arm-fbsd-nat.c: Sort headers.
1748         * arm-bsd-tdep.c: Sort headers.
1749         * arch-utils.c: Sort headers.
1750         * arc-tdep.c: Sort headers.
1751         * arc-newlib-tdep.c: Sort headers.
1752         * annotate.h: Sort headers.
1753         * annotate.c: Sort headers.
1754         * amd64-windows-tdep.c: Sort headers.
1755         * amd64-windows-nat.c: Sort headers.
1756         * amd64-tdep.c: Sort headers.
1757         * amd64-sol2-tdep.c: Sort headers.
1758         * amd64-obsd-tdep.c: Sort headers.
1759         * amd64-obsd-nat.c: Sort headers.
1760         * amd64-nbsd-tdep.c: Sort headers.
1761         * amd64-nbsd-nat.c: Sort headers.
1762         * amd64-nat.c: Sort headers.
1763         * amd64-linux-tdep.c: Sort headers.
1764         * amd64-linux-nat.c: Sort headers.
1765         * amd64-fbsd-tdep.c: Sort headers.
1766         * amd64-fbsd-nat.c: Sort headers.
1767         * amd64-dicos-tdep.c: Sort headers.
1768         * amd64-darwin-tdep.c: Sort headers.
1769         * amd64-bsd-nat.c: Sort headers.
1770         * alpha-tdep.c: Sort headers.
1771         * alpha-obsd-tdep.c: Sort headers.
1772         * alpha-nbsd-tdep.c: Sort headers.
1773         * alpha-mdebug-tdep.c: Sort headers.
1774         * alpha-linux-tdep.c: Sort headers.
1775         * alpha-linux-nat.c: Sort headers.
1776         * alpha-bsd-tdep.c: Sort headers.
1777         * alpha-bsd-nat.c: Sort headers.
1778         * aix-thread.c: Sort headers.
1779         * agent.c: Sort headers.
1780         * addrmap.c: Sort headers.
1781         * ada-varobj.c: Sort headers.
1782         * ada-valprint.c: Sort headers.
1783         * ada-typeprint.c: Sort headers.
1784         * ada-tasks.c: Sort headers.
1785         * ada-lang.c: Sort headers.
1786         * aarch64-tdep.c: Sort headers.
1787         * aarch64-ravenscar-thread.c: Sort headers.
1788         * aarch64-newlib-tdep.c: Sort headers.
1789         * aarch64-linux-tdep.c: Sort headers.
1790         * aarch64-linux-nat.c: Sort headers.
1791         * aarch64-fbsd-tdep.c: Sort headers.
1792         * aarch64-fbsd-nat.c: Sort headers.
1793         * aarch32-linux-nat.c: Sort headers.
1794
1795 2019-04-04  Tom Tromey  <tom@tromey.com>
1796
1797         * varobj.c (varobj_create): Update.
1798         * rust-exp.y (struct rust_parser) <update_innermost_block,
1799         lookup_symbol>: New methods.
1800         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1801         Rename.
1802         (rust_parser::rust_lookup_type)
1803         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1804         * printcmd.c (display_command, do_one_display): Update.
1805         * parser-defs.h (struct parser_state) <parser_state>: Add
1806         "tracker" parameter.
1807         (block_tracker): New member.
1808         (class innermost_block_tracker) <innermost_block_tracker>: Add
1809         "types" parameter.
1810         <reset>: Remove method.
1811         (innermost_block): Don't declare.
1812         (null_post_parser): Update.
1813         * parse.c (innermost_block): Remove global.
1814         (write_dollar_variable): Update.
1815         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1816         Remove "tracker_types" parameter.
1817         (parse_expression): Add "tracker" parameter.
1818         (parse_expression_for_completion): Update.
1819         (null_post_parser): Add "tracker" parameter.
1820         * p-exp.y: Update rules.
1821         * m2-exp.y: Update rules.
1822         * language.h (struct language_defn) <la_post_parser>: Add
1823         "tracker" parameter.
1824         * go-exp.y: Update rules.
1825         * f-exp.y: Update rules.
1826         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1827         parameter.
1828         * d-exp.y: Update rules.
1829         * c-exp.y: Update rules.
1830         * breakpoint.c (set_breakpoint_condition): Create an
1831         innermost_block_tracker.
1832         (watch_command_1): Likewise.
1833         * ada-lang.c (resolve): Add "tracker" parameter.
1834         (resolve_subexp): Likewise.
1835         * ada-exp.y (write_var_from_sym): Update.
1836
1837 2019-04-04  Tom Tromey  <tom@tromey.com>
1838
1839         * type-stack.h: New file.
1840         * type-stack.c: New file.
1841         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1842         type-stack.h.
1843         (insert_into_type_stack, insert_type, push_type, push_type_int)
1844         (insert_type_address_space, pop_type, pop_type_int)
1845         (pop_typelist, pop_type_stack, append_type_stack)
1846         (push_type_stack, get_type_stack, push_typelist)
1847         (follow_type_instance_flags, follow_types): Don't declare.
1848         * parse.c (type_stack): Remove global.
1849         (parse_exp_in_context): Update.
1850         (insert_into_type_stack, insert_type, push_type, push_type_int)
1851         (insert_type_address_space, pop_type, pop_type_int)
1852         (pop_typelist, pop_type_stack, append_type_stack)
1853         (push_type_stack, get_type_stack, push_typelist)
1854         (follow_type_instance_flags, follow_types): Remove (moved to
1855         type-stack.c).
1856         * f-exp.y (type_stack): New global.
1857         Update rules.
1858         (push_kind_type, f_parse): Update.
1859         * d-exp.y (type_stack): New global.
1860         Update rules.
1861         (d_parse): Update.
1862         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1863         Update rules.
1864         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1865         (HFILES_NO_SRCDIR): Add type-stack.h.
1866
1867 2019-04-04  Tom Tromey  <tom@tromey.com>
1868
1869         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1870         (rust_parser::convert_ast_to_expression, rust_parse)
1871         (rust_lex_test_completion, rust_lex_tests): Update.
1872         * parser-defs.h (struct expr_completion_state): New.
1873         (struct parser_state) <parser_state>: Add completion parameter.
1874         <mark_struct_expression, mark_completion_tag>: New methods.
1875         <parse_completion, m_completion_state>: New members.
1876         (prefixify_expression, null_post_parser): Update.
1877         (mark_struct_expression, mark_completion_tag): Don't declare.
1878         * parse.c (parse_completion, expout_last_struct)
1879         (expout_tag_completion_type, expout_completion_name): Remove
1880         globals.
1881         (parser_state::mark_struct_expression)
1882         (parser_state::mark_completion_tag): Now methods.
1883         (prefixify_expression): Add last_struct parameter.
1884         (prefixify_subexp): Likewise.
1885         (parse_exp_1): Update.
1886         (parse_exp_in_context): Add cstate parameter.  Update.
1887         (parse_expression_for_completion): Create an
1888         expr_completion_state.
1889         (null_post_parser): Add "completion" parameter.
1890         * p-exp.y: Update rules.
1891         (yylex): Update.
1892         * language.h (struct language_defn) <la_post_parser>: Add
1893         "completing" parameter.
1894         * go-exp.y: Update rules.
1895         (lex_one_token): Update.
1896         * expression.h (parse_completion): Don't declare.
1897         * d-exp.y: Update rules.
1898         (lex_one_token): Update rules.
1899         * c-exp.y: Update rules.
1900         (lex_one_token): Update.
1901         * ada-lang.c (resolve): Add "parse_completion" parameter.
1902         (resolve_subexp): Likewise.
1903         (ada_resolve_function): Likewise.
1904
1905 2019-04-04  Tom Tromey  <tom@tromey.com>
1906
1907         * parser-defs.h (struct parser_state) <start_arglist,
1908         end_arglist>: New methods.
1909         <arglist_len, m_funcall_chain>: New members.
1910         (arglist_len, start_arglist, end_arglist): Don't declare.
1911         * parse.c (arglist_len, funcall_chain): Remove global.
1912         (start_arglist, end_arglist): Remove functions.
1913         (parse_exp_in_context): Update.
1914         * p-exp.y: Update rules.
1915         * m2-exp.y: Update rules.
1916         * go-exp.y: Update rules.
1917         * f-exp.y: Update rules.
1918         * d-exp.y: Update rules.
1919         * c-exp.y: Update rules.
1920
1921 2019-04-04  Tom Tromey  <tom@tromey.com>
1922
1923         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1924         lex_operator, push_back>: New methods.
1925         Update all rules.
1926         (rust_parser::lex_hex, lex_escape): Rename and update.
1927         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1928         (rust_parser::lex_operator): Rename and update.
1929         (rust_parser::lex_number, rustyylex, rustyyerror)
1930         (rust_lex_test_init, rust_lex_test_sequence)
1931         (rust_lex_test_push_back, rust_lex_tests): Update.
1932         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1933         parameter.
1934         <lexptr, prev_lexptr>: New members.
1935         (lexptr, prev_lexptr): Don't declare.
1936         * parse.c (lexptr, prev_lexptr): Remove globals.
1937         (parse_exp_in_context): Update.
1938         * p-exp.y (yylex, yyerror): Update.
1939         * m2-exp.y (parse_number, yylex, yyerror): Update.
1940         * go-exp.y (lex_one_token, yyerror): Update.
1941         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1942         * d-exp.y (lex_one_token, yyerror): Update.
1943         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1944         (lex_one_token, yyerror): Update.
1945         * ada-lex.l (YY_INPUT): Update.
1946         (rewind_to_char): Update.
1947         * ada-exp.y (yyerror): Update.
1948
1949 2019-04-04  Tom Tromey  <tom@tromey.com>
1950
1951         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1952         * parser-defs.h (struct parser_state) <parser_state>: Add new
1953         parameter.
1954         <comma_terminates>: New member.
1955         (comma_terminates): Don't declare global.
1956         * parse.c (comma_terminates): Remove global.
1957         (parse_exp_in_context): Update.
1958         * p-exp.y (yylex): Update.
1959         * m2-exp.y (yylex): Update.
1960         * go-exp.y (lex_one_token): Update.
1961         * f-exp.y (yylex): Update.
1962         * d-exp.y (lex_one_token): Update.
1963         * c-exp.y (lex_one_token): Update.
1964         * ada-lex.l: Update.
1965
1966 2019-04-04  Tom Tromey  <tom@tromey.com>
1967
1968         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1969         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1970         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1971         * parser-defs.h (paren_depth): Don't declare.
1972         * parse.c (paren_depth): Remove global.
1973         (parse_exp_in_context): Update.
1974         * p-exp.y (paren_depth): New global.
1975         (pascal_parse): Initialize it.
1976         * m2-exp.y (paren_depth): New global.
1977         (m2_parse): Initialize it.
1978         * go-exp.y (paren_depth): New global.
1979         (go_parse): Initialize it.
1980         * f-exp.y (paren_depth): New global.
1981         (f_parse): Initialize it.
1982         * d-exp.y (paren_depth): New global.
1983         (d_parse): Initialize it.
1984         * c-exp.y (paren_depth): New global.
1985         (c_parse): Initialize it.
1986         * ada-lex.l (paren_depth): New global.
1987         (lexer_init): Initialize it.
1988
1989 2019-04-04  Tom Tromey  <tom@tromey.com>
1990
1991         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1992         (rust_parser::convert_ast_to_type)
1993         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1994         * parser-defs.h (struct parser_state) <parser_state>: Add
1995         parameters.  Initialize new members.
1996         <expression_context_block, expression_context_pc>: New members.
1997         * parse.c (expression_context_block, expression_context_pc):
1998         Remove globals.
1999         (parse_exp_in_context): Update.
2000         * p-exp.y: Update all rules.
2001         (yylex): Update.
2002         * m2-exp.y: Update all rules.
2003         (yylex): Update.
2004         * go-exp.y (yylex): Update.
2005         * f-exp.y (yylex): Update.
2006         * d-exp.y: Update all rules.
2007         (yylex): Update.
2008         * c-exp.y: Update all rules.
2009         (lex_one_token, classify_name, yylex, c_parse): Update.
2010         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
2011
2012 2019-04-04  Tom Tromey  <tom@tromey.com>
2013
2014         * gdbarch.h, gdbarch.c: Rebuild.
2015         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
2016         * stap-probe.h:
2017         (struct stap_parse_info): Replace "parser_state" with
2018         "expr_builder".
2019         * parser-defs.h (struct expr_builder): Rename from "parser_state".
2020         (parser_state): New class.
2021         * parse.c (expr_builder): Rename.
2022         (expr_builder::release): Rename.
2023         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
2024         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
2025         (write_exp_elt_longcst, write_exp_elt_floatcst)
2026         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
2027         (write_exp_string_vector, write_exp_bitstring)
2028         (write_exp_msymbol, mark_struct_expression)
2029         (write_dollar_variable)
2030         (insert_type_address_space, increase_expout_size): Replace
2031         "parser_state" with "expr_builder".
2032         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
2033         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
2034         "parser_state" with "expr_builder".
2035
2036 2019-04-04  Tom Tromey  <tom@tromey.com>
2037
2038         * rust-exp.y: Replace "parse_language" with method call.
2039         * p-exp.y:
2040         (yylex): Replace "parse_language" with method call.
2041         * m2-exp.y:
2042         (yylex): Replace "parse_language" with method call.
2043         * go-exp.y (classify_name): Replace "parse_language" with method
2044         call.
2045         * f-exp.y (yylex): Replace "parse_language" with method call.
2046         * d-exp.y (lex_one_token): Replace "parse_language" with method
2047         call.
2048         * c-exp.y:
2049         (lex_one_token, classify_name, yylex): Replace "parse_language"
2050         with method call.
2051         * ada-exp.y (find_primitive_type, type_char)
2052         (type_system_address): Replace "parse_language" with method call.
2053
2054 2019-04-04  Tom Tromey  <tom@tromey.com>
2055
2056         * rust-exp.y: Replace "parse_gdbarch" with method call.
2057         * parse.c (write_dollar_variable, insert_type_address_space):
2058         Replace "parse_gdbarch" with method call.
2059         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
2060         call.
2061         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
2062         call.
2063         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
2064         "parse_gdbarch" with method call.
2065         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
2066         with method call.
2067         * f-exp.y (parse_type, parse_f_type, yylex): Replace
2068         "parse_gdbarch" with method call.
2069         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
2070         "parse_gdbarch" with method call.
2071         * c-exp.y (parse_type, parse_number, classify_name): Replace
2072         "parse_gdbarch" with method call.
2073         * ada-lex.l: Replace "parse_gdbarch" with method call.
2074         * ada-exp.y (parse_type, find_primitive_type, type_char)
2075         (type_system_address): Replace "parse_gdbarch" with method call.
2076
2077 2019-04-04  Tom Tromey  <tom@tromey.com>
2078
2079         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
2080         * stap-probe.c (stap_parse_argument): Update.
2081         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
2082         initial_size parameter.
2083         * rust-exp.y (rust_lex_tests): Update.
2084         * parse.c (parser_state): Update.
2085         (parse_exp_in_context): Update.
2086         * parser-defs.h (struct parser_state) <parser_state>: Remove
2087         "initial_size" parameter.
2088
2089 2019-04-04  Tom Tromey  <tom@tromey.com>
2090
2091         * parser-defs.h (increase_expout_size): Don't declare.
2092         * parse.c (increase_expout_size): Now static.
2093
2094 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
2095
2096         * gnu-nat.c (gnu_nat_target::wait): Fix
2097         target_waitstatus_to_string call.
2098
2099 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2100
2101         * eval.c (evaluate_subexp_standard): Handle internal functions
2102         during Fortran function call handling.
2103
2104 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2105
2106         * NEWS: Mention new internal functions.
2107         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
2108         (read_base_type): Use dwarf2_init_complex_target_type.
2109         * value.c (creal_internal_fn): New function.
2110         (cimag_internal_fn): New function.
2111         (_initialize_values): Register new internal functions.
2112
2113 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2114
2115         * infrun.c (stop_all_threads): If debug_infrun, always
2116         trace the wait status after wait_one, using
2117         target_waitstatus_to_string and target_pid_to_str.
2118         (handle_inferior_event): Replace various trace of
2119         wait status kind by a single trace.
2120         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
2121         wait status kind image by target_waitstatus_to_string.
2122         * target/waitstatus.c (target_waitstatus_to_string): Fix
2123         obsolete comment.
2124
2125 2019-04-01  Tom Tromey  <tromey@adacore.com>
2126
2127         PR symtab/23331:
2128         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
2129
2130 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
2131             Pedro Alves  <palves@redhat.com>
2132
2133         * top.c (quit_force): Call 'finalize_values'.
2134         * value.c (finalize_values): New function.
2135         * value.h (finalize_values): Declare.
2136
2137 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
2138
2139         * NEWS: Announce $_gdb_major and $_gdb_minor.
2140
2141         * top.c (init_gdb_version_vars): New function.
2142         (gdb_init): Call init_gdb_version_vars.
2143
2144 2019-03-29  Tom Tromey  <tromey@adacore.com>
2145
2146         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
2147         help text.  Remove dead code.
2148
2149 2019-03-29  Keith Seitz  <keiths@redhat.com>
2150
2151         From Siddhesh Poyarekar:
2152         * f-lang.h (f77_get_upperbound): Return LONGEST.
2153         (f77_get_lowerbound): Likewise.
2154         * f-typeprint.c (f_type_print_varspec_suffix): Expand
2155         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
2156         print them.
2157         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
2158         plongest to format print it.
2159         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
2160         (f77_get_upperbound): Likewise.
2161         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
2162         LOWER_BOUND to LONGEST.
2163         (f77_create_arrayprint_offset_tbl): Likewise.
2164
2165 2019-03-29  Keith Seitz  <keiths@redhat.com>
2166
2167         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
2168         %s/pulongest for TYPE_LENGTH instead of %d in format
2169         strings.
2170         * ada-typerint.c (ada_print_type): Likewise.
2171         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
2172         * compile/compile-c-support.c (generate_register_struct): Likewise.
2173         * gdbtypes.c (recursive_dump_type): Likewise.
2174         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
2175         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
2176         instead of %d in format strings.
2177         * riscv-tdep.c (riscv_type_alignment): Cast second argument
2178         to std::min to ULONGEST.
2179         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
2180         instead of %d in format strings.
2181         * tracepoint.c (info_scope_command): Likewise.
2182         * typeprint.c (print_offset_data::update)
2183         (print_offset_data::finish): Likewise.
2184         * xtensa-tdep.c (xtensa_store_return_value)
2185         (xtensa_push_dummy_call): Likewise.
2186
2187 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
2188
2189         * windows-nat.c (display_selector): Fixed format specifications
2190         for 64-bit Cygwin.
2191
2192 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2193
2194         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
2195
2196 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
2197
2198         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
2199         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
2200         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
2201         (nios2_linux_init_abi): Install it.
2202
2203 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2204
2205         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
2206
2207 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
2208
2209         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
2210
2211 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2212             Tom Tromey  <tromey@adacore.com>
2213
2214         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
2215
2216 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
2217
2218         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
2219         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
2220         method to compute the bounds of range types. Also print "[evaluated]"
2221         if the bounds' values come from a dynamic evaluation.
2222
2223 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * cp-valprint.c (cp_print_value_fields): Don't print trailing
2226         whitespace when pretty printing is on.
2227
2228 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2229
2230         * ppc-linux-nat.c: Add include.
2231
2232 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2233
2234         * NEWS: Mention AArch64 Pointer Authentication.
2235
2236 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
2237
2238         * arm-linux-nat.c: Add include.
2239
2240 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
2241
2242         * source-cache.c (source_cache::get_source_lines): Re-read
2243         fullname after calling open_source_file.
2244
2245 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
2246
2247         * NEWS: Mention TLS support for FreeBSD.
2248
2249 2019-03-25  Tom Tromey  <tromey@adacore.com>
2250
2251         * minsyms.c (BUNCH_SIZE): Update comment.
2252         (~minimal_symbol_reader): Remove old comment.
2253         (compact_minimal_symbols): Update comment.
2254         (minimal_symbol_reader::install): Remove old comment.  Update
2255         other comments.
2256
2257 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2258
2259         * s390-linux-nat.c: Add include.
2260
2261 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
2262
2263         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2264         Call linux_get_hwcap.
2265         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
2266         Likewise.
2267         (aarch64_linux_get_hwcap): Remove function.
2268         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
2269         declaration.
2270         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
2271         linux_get_hwcap.
2272         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2273         * linux-tdep.c (linux_get_hwcap): Add function.
2274         (linux_get_hwcap2): Likewise.
2275         * linux-tdep.h (linux_get_hwcap): Add declaration.
2276         (linux_get_hwcap2): Likewise.
2277         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
2278         (ppc_linux_get_hwcap2): Likewise.
2279         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
2280         linux_get_hwcap.
2281         (ppc_linux_nat_target::insert_watchpoint): Likewise.
2282         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
2283         (ppc_linux_nat_target::read_description): Likewise.
2284         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
2285         * s390-linux-nat.c: Likewise.
2286         * s390-linux-tdep.c (s390_core_read_description): Likewise.
2287
2288 2019-03-24  Tom Tromey  <tom@tromey.com>
2289
2290         * ada-lang.c (standard_lookup): Simplify initialization.
2291         (ada_lookup_symbol_nonlocal): Simplify return.
2292         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
2293         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
2294         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
2295         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
2296         initialization.
2297         * solib.c (solib_global_lookup): Simplify.
2298         * symtab.c (null_block_symbol): Remove.
2299         (symbol_cache_lookup): Simplify returns.
2300         (lookup_language_this): Simplify returns.
2301         (lookup_symbol_aux): Simplify return.
2302         (lookup_local_symbol): Simplify returns.
2303         (lookup_global_symbol_from_objfile): Simplify return.
2304         (lookup_symbol_in_objfile_symtabs)
2305         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
2306         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
2307         (lookup_static_symbol, lookup_global_symbol): Simplify return.
2308         * cp-namespace.c (cp_lookup_bare_symbol)
2309         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
2310         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
2311         (cp_lookup_nested_symbol): Don't use null_block_symbol.
2312         (cp_lookup_symbol_via_imports): Simplify initialization.
2313         (find_symbol_in_baseclass): Likewise.
2314         * symtab.h (null_block_symbol): Remove.
2315         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
2316         (d_lookup_nested_symbol, d_lookup_symbol_imports)
2317         (d_lookup_symbol_module): Likewise.
2318         (find_symbol_in_baseclass): Simplify initialization.
2319
2320 2019-03-24  Tom Tromey  <tom@tromey.com>
2321
2322         * expression.h: Don't include symtab.h.
2323         (struct block): Forward declare.
2324
2325 2019-03-24  Tom Tromey  <tom@tromey.com>
2326
2327         * c-exp.y (typebase): Remove casts.
2328         * gdbtypes.c (lookup_unsigned_typename, )
2329         (lookup_signed_typename): Remove cast.
2330         * eval.c (parse_to_comma_and_eval): Remove cast.
2331         * parse.c (write_dollar_variable): Remove cast.
2332         * block.h (struct block) <superblock>: Now const.
2333         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
2334         * psymtab.c (psym_map_matching_symbols): Make "block" const.
2335         (map_block): Make "block" const.
2336         * symfile.h (struct quick_symbol_functions)
2337         <map_matching_symbols>: Constify block argument to "callback".
2338         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
2339         const.
2340         (find_pc_sect_compunit_symtab): Make "b" const.
2341         (find_symbol_at_address): Likewise.
2342         (search_symbols): Likewise.
2343         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
2344         (dw2_debug_names_lookup_symbol): Likewise.
2345         (dw2_map_matching_symbols): Update.
2346         * p-valprint.c (pascal_val_print): Remove "block".
2347         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
2348         (aux_add_nonlocal_symbols): Make "block" const.
2349         (resolve_subexp): Remove cast.
2350         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
2351         const.
2352         (iterate_over_file_blocks): Likewise.
2353         * f-exp.y (%union) <bval>: Remove.
2354         * coffread.c (patch_opaque_types): Make "b" const.
2355         * spu-tdep.c (spu_catch_start): Make "block" const.
2356         * c-valprint.c (print_unpacked_pointer): Remove "block".
2357         * symmisc.c (dump_symtab_1): Make "b" const.
2358         (block_depth): Make "block" const.
2359         * d-exp.y (%union) <bval>: Remove.
2360         * cp-support.h (cp_lookup_rtti_type): Update.
2361         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
2362         * psymtab.c (psym_lookup_symbol): Make "block" const.
2363         (maintenance_check_psymtabs): Make "b" const.
2364         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
2365         (enumerate_locals, enumerate_args): Update.
2366         * python/py-symtab.c (stpy_global_block): Make "block" const.
2367         (stpy_static_block): Likewise.
2368         * inline-frame.c (block_starting_point_at): Make "new_block"
2369         const.
2370         * block.c (find_block_in_blockvector): Make return type const.
2371         (blockvector_for_pc_sect): Make "b" const.
2372         (find_block_in_blockvector): Make "b" const.
2373
2374 2019-03-23  Tom Tromey  <tom@tromey.com>
2375
2376         * varobj.c (varobj_create): Update.
2377         * symfile.c (clear_symtab_users): Don't reset innermost_block.
2378         * printcmd.c (display_command, do_one_display): Don't reset
2379         innermost_block.
2380         * parser-defs.h (enum innermost_block_tracker_type): Move to
2381         expression.h.
2382         (innermost_block): Update comment.
2383         * parse.c (parse_exp_1): Add tracker_types parameter.
2384         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
2385         tracker_types parameter.  Reset innermost_block.
2386         (parse_exp_in_context): Remove.
2387         (parse_expression_for_completion): Update.
2388         * objfiles.c (~objfile): Don't reset expression_context_block or
2389         innermost_block.
2390         * expression.h (enum innermost_block_tracker_type): Move from
2391         parser-defs.h.
2392         (parse_exp_1): Add tracker_types parameter.
2393         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
2394         reset innermost_block.
2395
2396 2019-03-23  Tom Tromey  <tom@tromey.com>
2397
2398         * objfiles.h: Include bcache.h.
2399
2400 2019-03-23  Tom Tromey  <tom@tromey.com>
2401
2402         * linespec.c (get_current_search_block): Use
2403         scoped_restore_current_language.
2404         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
2405
2406 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2407             Jiong Wang  <jiong.wang@arm.com>
2408
2409         * aarch64-linux-tdep.c
2410         (aarch64_linux_iterate_over_regset_sections): Check for pauth
2411         section.
2412         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
2413
2414 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2415             Jiong Wang  <jiong.wang@arm.com>
2416
2417         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
2418         instructions.
2419         (aarch64_analyze_prologue_test): Add PACIASP test.
2420         (aarch64_prologue_prev_register): Unmask PC value.
2421
2422 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2423             Jiong Wang  <jiong.wang@arm.com>
2424
2425         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
2426         (aarch64_dwarf2_prev_register): Unmask PC value.
2427         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
2428         (aarch64_execute_dwarf_cfa_vendor_op): Check for
2429         DW_CFA_AARCH64_negate_ra_state.
2430         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
2431
2432 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2433             Jiong Wang  <jiong.wang@arm.com>
2434
2435         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
2436         registers.
2437         (aarch64_pseudo_register_name): Likewise.
2438         (aarch64_pseudo_register_type): Likewise.
2439         (aarch64_pseudo_register_reggroup_p): Likewise.
2440         (aarch64_gdbarch_init): Add pauth registers.
2441         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
2442         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
2443         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
2444         (struct gdbarch_tdep): Add regnum for ra_state.
2445
2446 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2447             Jiong Wang  <jiong.wang@arm.com>
2448
2449         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
2450
2451 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2452             Jiong Wang  <jiong.wang@arm.com>
2453
2454         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
2455         function.
2456         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
2457         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
2458         (aarch64_gdbarch_init): Add puth registers.
2459         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
2460         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
2461         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
2462
2463 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2464             Jiong Wang  <jiong.wang@arm.com>
2465
2466         * aarch64-linux-nat.c
2467         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
2468         * aarch64-linux-tdep.c
2469         (aarch64_linux_core_read_description): Likewise.
2470         (aarch64_linux_get_hwcap): New function.
2471         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
2472         (aarch64_linux_get_hwcap): New declaration.
2473
2474 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
2475             Jiong Wang  <jiong.wang@arm.com>
2476
2477         * aarch64-linux-nat.c
2478         (aarch64_linux_nat_target::read_description): Add pauth param.
2479         * aarch64-linux-tdep.c
2480         (aarch64_linux_core_read_description): Likewise.
2481         * aarch64-tdep.c (struct target_desc): Add in pauth.
2482         (aarch64_read_description): Add pauth param.
2483         (aarch64_gdbarch_init): Likewise.
2484         * aarch64-tdep.h (aarch64_read_description): Likewise.
2485         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2486         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2487         * features/Makefile: Add new files.
2488         * features/aarch64-pauth.c: New file.
2489         * features/aarch64-pauth.xml: New file.
2490
2491 2019-03-20  Tom Tromey  <tromey@adacore.com>
2492
2493         * infrun.c (handle_inferior_event): Rename from
2494         handle_inferior_event_1.  Create a scoped_value_mark.
2495         (handle_inferior_event): Remove.
2496
2497 2019-03-19  Tom Tromey  <tromey@adacore.com>
2498
2499         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2500         * infrun.h (print_stop_event): Add "displays" parameter.
2501         * infrun.c (print_stop_event): Add "displays" parameter.
2502
2503 2019-03-19  Pedro Alves  <palves@redhat.com>
2504
2505         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2506         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2507         to -1.  Fix TABs vs spaces.
2508         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2509         * tui/tui-out.h (tui_ui_out) Add intro comments.
2510         <m_line, m_start_of_line>: In-class initialize, and add describing
2511         comment.
2512
2513 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2514
2515         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2516         variable names.
2517         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2518
2519 2019-03-18  Pedro Alves  <palves@redhat.com>
2520             Eli Zaretskii <eliz@gnu.org>
2521
2522         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2523         m_line and m_start_of_line.
2524
2525 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2526
2527         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2528         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2529         it returns a newline.  This fixes a regression in TU mode, whereby
2530         the next line is output on the same screen line as the user input.
2531
2532 2019-03-18  Tom Tromey  <tromey@adacore.com>
2533
2534         * minsyms.c (minimal_symbol_reader::install): Remove call to
2535         obstack_blank.
2536
2537 2019-03-18  Pedro Alves  <palves@redhat.com>
2538
2539         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2540         New globals.
2541         (apply_style): New, factored out from ...
2542         (apply_ansi_escape): ... this.  Handle reverse video mode.
2543         (tui_set_reverse_mode): New function.
2544         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2545         * tui/tui-winsource.c (tui_show_source_line): Use
2546         tui_set_reverse_mode instead of setting A_STANDOUT.
2547         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2548         New setter methods.
2549
2550 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2551
2552         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2553         Handle tabs.
2554
2555 2019-03-18  Tom Tromey  <tromey@adacore.com>
2556
2557         * ada-lang.c (empty_array): Add "high" parameter.
2558         (ada_evaluate_subexp): Update.
2559
2560 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2561
2562         * unittests/string_view-selftests.c: Define
2563         _initialize_string_view_selftests unconditionally.
2564
2565 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2566
2567         PR gdb/24350
2568         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2569
2570 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2571
2572         PR gdb/24351
2573         * windows-nat.c (display_selector): Fix format specifiers.
2574
2575 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2576
2577         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2578         tui_refill_source_window instead of tui_refresh_win, to update the
2579         current execution line.  This fixes redisplay of the current line
2580         when stepping through the code with "next" or "step".
2581
2582 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2583
2584         * source-cache.c (source_cache::get_source_lines): Call
2585         find_source_lines to initialize s->nlines.  This fixes vertical
2586         scrolling of TUI source window when the DOWN arrow is pressed.
2587
2588 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2589
2590         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2591         linux-thread-db.c (_initialize_thread_db): Likewise.
2592
2593 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2594
2595         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2596         wclrtoeol in tui_show_source_line".  This reverts changes made in
2597         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2598
2599 2019-03-15  Tom Tromey  <tom@tromey.com>
2600
2601         * symtab.h (struct minimal_symbol): Derive from
2602         general_symbol_info.
2603         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2604         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2605         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2606         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2607         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2608         (MSYMBOL_SEARCH_NAME): Update.
2609         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2610         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2611         * minsyms.c (minimal_symbol_reader::record_full): Update.
2612
2613 2019-03-15  Tom Tromey  <tom@tromey.com>
2614
2615         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2616
2617 2019-03-15  Tom Tromey  <tom@tromey.com>
2618
2619         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2620         unique_xmalloc_ptr.
2621         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2622         Update.
2623         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2624         (build_minimal_symbol_hash_tables)
2625         (minimal_symbol_reader::install): Update.
2626
2627 2019-03-15  Tom Tromey  <tom@tromey.com>
2628
2629         * symtab.c (create_demangled_names_hash): Update.
2630         (symbol_set_names): Update.
2631         * objfiles.h (struct objfile_per_bfd_storage)
2632         <demangled_names_hash>: Now an htab_up.
2633         * objfiles.c (objfile_per_bfd_storage): Simplify.
2634
2635 2019-03-15  Tom Tromey  <tom@tromey.com>
2636
2637         * objfiles.h (struct objfile_per_bfd_storage): Declare
2638         destructor.
2639         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2640         New.
2641         (get_objfile_bfd_data): Use new.  Don't initialize
2642         language_of_main.
2643         (free_objfile_per_bfd_storage): Remove.
2644         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2645
2646 2019-03-15  Tom Tromey  <tom@tromey.com>
2647
2648         * symfile.c (reread_symbols): Update.
2649         * objfiles.c (objfile::objfile): Update.
2650         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2651         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2652         comment.
2653         (minimal_symbol_reader::install): Update.
2654         (terminate_minimal_symbol_table): Remove.
2655         * jit.c (jit_object_close_impl): Update.
2656
2657 2019-03-15  Tom Tromey  <tom@tromey.com>
2658
2659         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2660         initializations.
2661
2662 2019-03-15  Tom Tromey  <tom@tromey.com>
2663
2664         * objfiles.h (struct objfile_per_bfd_storage)
2665         <demangled_hash_languages>: Now a bitset.
2666         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2667         (lookup_minimal_symbol): Update.
2668
2669 2019-03-15  Tom Tromey  <tom@tromey.com>
2670
2671         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2672         Don't return the symbol.
2673         * coffread.c (record_minimal_symbol): Use record_full.
2674
2675 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2676
2677         The MS-Windows port of ncurses fails to switch to a color pair if
2678         one or both of the colors are the implicit default colors.  This
2679         change records the default colors when TUI is initialized, and
2680         then specifies them explicitly when a color pair uses the default
2681         colors.  This allows color styling in TUI mode on MS-Windows.
2682
2683         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2684         ncurses_norm_attr.
2685         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2686         colors in ncurses_norm_attr.
2687         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2688         "none", replace it with the default color recorded in
2689         ncurses_norm_attr.
2690
2691 2019-03-14  Tom Tromey  <tromey@adacore.com>
2692
2693         * source-cache.h (class source_cache) <get_source_lines>: Return
2694         std::string.
2695         * source-cache.c (source_cache::extract_lines): Handle case where
2696         first_pos==npos.  Return std::string.
2697         (source_cache::get_source_lines): Update.
2698
2699 2019-03-14  Tom Tromey  <tromey@adacore.com>
2700
2701         * NEWS: Add item for "style sources" commands.
2702         * source-cache.c (source_cache::get_source_lines): Check
2703         source_styling.
2704         * cli/cli-style.c (source_styling): New global.
2705         (_initialize_cli_style): Add "style sources" commands.
2706         (show_style_sources): New function.
2707         * cli/cli-style.h (source_styling): Declare.
2708
2709 2019-03-14  Pedro Alves  <palves@redhat.com>
2710             Tom Tromey  <tromey@adacore.com>
2711
2712         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2713         * tui/tui-winsource.c (tui_refill_source_window): New function,
2714         from...
2715         (tui_horizontal_source_scroll): ... here.  Move some logic.
2716         * cli/cli-style.c (set_style_enabled): Notify new observable.
2717         * tui/tui-hooks.c (tui_redisplay_source): New function.
2718         (tui_attach_detach_observers): Attach or detach
2719         tui_redisplay_source.
2720         * observable.h (source_styling_changed): New observable.
2721         * observable.c: Define source_styling_changed observable.
2722
2723 2019-03-13  Tom Tromey  <tromey@adacore.com>
2724
2725         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2726         (i386_gnu_nat_target::store_registers): Update.
2727         * target-debug.h (target_debug_print_std_string): New macro.
2728         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2729         * windows-tdep.c (display_one_tib): Update.
2730         * tui/tui-stack.c (tui_make_status_line): Update.
2731         * top.c (print_inferior_quit_action): Update.
2732         * thread.c (thr_try_catch_cmd): Update.
2733         (add_thread_with_info): Update.
2734         (thread_target_id_str): Update.
2735         (thr_try_catch_cmd): Update.
2736         (thread_command): Update.
2737         (thread_find_command): Update.
2738         * record-btrace.c (record_btrace_target::info_record)
2739         (record_btrace_resume_thread, record_btrace_target::resume)
2740         (record_btrace_cancel_resume, record_btrace_step_thread)
2741         (record_btrace_target::wait, record_btrace_target::wait)
2742         (record_btrace_target::wait, record_btrace_target::stop): Update.
2743         * progspace.c (print_program_space): Update.
2744         * process-stratum-target.c
2745         (process_stratum_target::thread_address_space): Update.
2746         * linux-fork.c (linux_fork_mourn_inferior)
2747         (detach_checkpoint_command, info_checkpoints_command)
2748         (linux_fork_context): Update.
2749         (linux_fork_detach): Update.
2750         (class scoped_switch_fork_info): Update.
2751         (delete_checkpoint_command): Update.
2752         * infrun.c (follow_fork_inferior): Update.
2753         (follow_fork_inferior): Update.
2754         (proceed_after_vfork_done): Update.
2755         (handle_vfork_child_exec_or_exit): Update.
2756         (follow_exec): Update.
2757         (displaced_step_prepare_throw): Update.
2758         (displaced_step_restore): Update.
2759         (start_step_over): Update.
2760         (resume_1): Update.
2761         (clear_proceed_status_thread): Update.
2762         (proceed): Update.
2763         (print_target_wait_results): Update.
2764         (do_target_wait): Update.
2765         (context_switch): Update.
2766         (stop_all_threads): Update.
2767         (restart_threads): Update.
2768         (finish_step_over): Update.
2769         (handle_signal_stop): Update.
2770         (switch_back_to_stepped_thread): Update.
2771         (keep_going_pass_signal): Update.
2772         (print_exited_reason): Update.
2773         (normal_stop): Update.
2774         * inferior.c (inferior_pid_to_str): Change return type.
2775         (print_selected_inferior): Update.
2776         (add_inferior): Update.
2777         (detach_inferior): Update.
2778         * dummy-frame.c (fprint_dummy_frames): Update.
2779         * dcache.c (dcache_info_1): Update.
2780         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2781         (btrace_fetch, btrace_clear): Update.
2782         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2783         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2784         type.
2785         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2786         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2787         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2788         * gdbarch.c, gdbarch.h: Rebuild.
2789         * gdbarch.sh (core_pid_to_str): Change return type.
2790         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2791         return type.
2792         (windows_nat_target::pid_to_str): Change return type.
2793         (windows_delete_thread): Update.
2794         (windows_nat_target::attach): Update.
2795         (windows_nat_target::files_info): Update.
2796         * target-delegates.c: Rebuild.
2797         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2798         return type.
2799         (sol_thread_target::pid_to_str): Change return type.
2800         * remote.c (class remote_target) <pid_to_str>: Change return
2801         type.
2802         (remote_target::pid_to_str): Change return type.
2803         (extended_remote_target::attach, remote_target::remote_stop_ns)
2804         (remote_target::remote_notif_remove_queued_reply)
2805         (remote_target::push_stop_reply, remote_target::disable_btrace):
2806         Update.
2807         (extended_remote_target::attach): Update.
2808         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2809         type.
2810         (gdbsim_target::pid_to_str): Change return type.
2811         * ravenscar-thread.c (struct ravenscar_thread_target)
2812         <pid_to_str>: Change return type.
2813         (ravenscar_thread_target::pid_to_str): Change return type.
2814         * procfs.c (class procfs_target) <pid_to_str>: Change return
2815         type.
2816         (procfs_target::pid_to_str): Change return type.
2817         (procfs_target::attach): Update.
2818         (procfs_target::detach): Update.
2819         (procfs_target::fetch_registers): Update.
2820         (procfs_target::store_registers): Update.
2821         (procfs_target::wait): Update.
2822         (procfs_target::files_info): Update.
2823         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2824         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2825         return type.
2826         (nto_procfs_target::pid_to_str): Change return type.
2827         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2828         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2829         return type.
2830         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2831         (exit_lwp): Update.
2832         (attach_proc_task_lwp_callback, get_detach_signal)
2833         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2834         (linux_nat_target::resume, wait_lwp, stop_callback)
2835         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2836         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2837         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2838         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2839         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2840         type.
2841         (inf_ptrace_target::attach): Update.
2842         (inf_ptrace_target::files_info): Update.
2843         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2844         type.
2845         (go32_nat_target::pid_to_str): Change return type.
2846         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2847         (gnu_nat_target::wait): Update.
2848         (gnu_nat_target::wait): Update.
2849         (gnu_nat_target::resume): Update.
2850         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2851         (fbsd_nat_target::wait): Update.
2852         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2853         type.
2854         (darwin_nat_target::attach): Update.
2855         * corelow.c (class core_target) <pid_to_str>: Change return type.
2856         (core_target::pid_to_str): Change return type.
2857         * target.c (normal_pid_to_str): Change return type.
2858         (default_pid_to_str): Likewise.
2859         (target_pid_to_str): Change return type.
2860         (target_translate_tls_address): Update.
2861         (target_announce_detach): Update.
2862         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2863         return type.
2864         (bsd_uthread_target::pid_to_str): Change return type.
2865         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2866         type.
2867         (bsd_kvm_target::pid_to_str): Change return type.
2868         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2869         return type.
2870         (aix_thread_target::pid_to_str): Change return type.
2871         * target.h (struct target_ops) <pid_to_str>: Change return type.
2872         (target_pid_to_str, normal_pid_to_str): Likewise.
2873         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2874         type.
2875         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2876         type.
2877         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2878         return type.
2879         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2880         type.
2881         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2882         type.
2883         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2884         return type.
2885
2886 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2887
2888         * NEWS: Mention that the new default MI version is 3.  Mention
2889         changes to the output of commands and events that deal with
2890         multi-location breakpoints.
2891         * breakpoint.c: Include "mi/mi-out.h".
2892         (print_one_breakpoint): Change output syntax if using MI version
2893         >= 3.
2894         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2895         New.
2896         (mi_multi_location_breakpoint_output_fixed): New.
2897         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2898         (mi_cmd_fix_multi_location_breakpoint_output): New.
2899         (mi_multi_location_breakpoint_output_fixed): New.
2900         * mi/mi-cmds.c (mi_cmds): Register command
2901         -fix-multi-location-breakpoint-output.
2902         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2903         interpreter "mi".
2904
2905 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2906
2907         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2908         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2909         instantiate mi_ui_out based on interpreter name.
2910         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2911         * mi/mi-main.c (mi_load_progress): Likewise.
2912
2913 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2914
2915         * NEWS: Combine separate "New targets" sections for 8.3.
2916
2917 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2918
2919         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2920         (ppcfbsd_init_abi): Install gdbarch
2921         "fetch_tls_load_module_address" and "get_thread_local_address"
2922         methods.
2923
2924 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2925
2926         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2927         (riscv_fbsd_init_abi): Install gdbarch
2928         "fetch_tls_load_module_address" and "get_thread_local_address"
2929         methods.
2930
2931 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2932
2933         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2934         (i386fbsd_init_abi): Install gdbarch
2935         "fetch_tls_load_module_address" and "get_thread_local_address"
2936         methods.
2937
2938 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2939
2940         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2941         (amd64fbsd_init_abi): Install gdbarch
2942         "fetch_tls_load_module_address" and "get_thread_local_address"
2943         methods.
2944
2945 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2946
2947         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2948         (struct fbsd_pspace_data): New type.
2949         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2950         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2951         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2952         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2953         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2954
2955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2956
2957         * gdbtypes.c (lookup_struct_elt): New function.
2958         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2959         * gdbtypes.h (struct struct_elt): New type.
2960         (lookup_struct_elt): New prototype.
2961
2962 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2963
2964         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2965         remove disabled code block.
2966
2967 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2968
2969         * gdbarch.sh (get_thread_local_address): New method.
2970         * gdbarch.h, gdbarch.c: Regenerate.
2971         * target.c (target_translate_tls_address): Use
2972         gdbarch_get_thread_local_address if present instead of
2973         target::get_thread_local_address.
2974
2975 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2976
2977         * target.h (target::get_thread_local_address): Update comment.
2978
2979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2980
2981         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2982         objfile->separate_debug_objfile_backlink if not NULL.
2983
2984 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2985
2986         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2987         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2988         (amd64bsd_store_inferior_registers): Likewise.
2989         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2990         Enable segment base registers.
2991         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2992         PT_GETFSBASE and PT_GETGSBASE.
2993         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2994         PT_SETGSBASE.
2995         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2996         segment base registers.
2997         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2998
2999 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
3000
3001         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
3002         Update calls to i386_target_description to add 'segments'
3003         parameter.
3004         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
3005         add segment base registers.
3006         * arch/i386.c (i386_create_target_description): Add 'segments'
3007         parameter to enable segment base registers.
3008         * arch/i386.h (i386_create_target_description): Likewise.
3009         * features/i386/32bit-segments.xml: New file.
3010         * features/i386/32bit-segments.c: Generate.
3011         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
3012         call to i386_target_description to add 'segments' parameter.
3013         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
3014         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
3015         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
3016         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
3017         if feature is present.
3018         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
3019         Add 'segments' parameter to call to i386_target_description.
3020         (i386_target_description): Add 'segments' parameter to enable
3021         segment base registers.
3022         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
3023         to call to i386_target_description.
3024         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
3025         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
3026         Define I386_NUM_REGS.
3027         (i386_target_description): Add 'segments' parameter to enable
3028         segment base registers.
3029
3030 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
3031
3032         PR/24325
3033         * source-cache.c: #undef open and close, to avoid unresolved
3034         externals during linking.
3035
3036 2019-03-12  Tom Tromey  <tromey@adacore.com>
3037
3038         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
3039         const.  Add initializers.
3040         (_initialize_remote): Don't initialize ptid globals.
3041
3042 2019-03-12  Pedro Alves  <palves@redhat.com>
3043
3044         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
3045
3046 2019-03-12  Pedro Alves  <palves@redhat.com>
3047
3048         * cp-name-parser.y (main): Remove unused 'len' variable.
3049
3050 2019-03-12  Tom Tromey  <tromey@adacore.com>
3051
3052         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
3053         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
3054
3055 2019-03-12  Tom Tromey  <tromey@adacore.com>
3056
3057         * linux-nat.c (iterate_over_lwps): Update.
3058         (stop_callback): Remove parameter.
3059         (stop_wait_callback, detach_callback, resume_set_callback)
3060         (select_singlestep_lwp_callback, set_ignore_sigint)
3061         (status_callback, resumed_callback, resume_clear_callback)
3062         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
3063         data parameter.
3064         (linux_nat_target::detach, linux_nat_target::resume)
3065         (linux_stop_and_wait_all_lwps, select_event_lwp)
3066         (linux_nat_filter_event, linux_nat_wait_1)
3067         (linux_nat_target::kill, linux_nat_target::stop)
3068         (linux_nat_target::stop): Update.
3069         (linux_nat_resume_callback): Change type.
3070         (resume_stopped_resumed_lwps, count_events_callback)
3071         (select_event_lwp_callback): Likewise.
3072         (linux_stop_lwp, linux_nat_stop_lwp): Update.
3073         * arm-linux-nat.c (struct update_registers_data): Remove.
3074         (update_registers_callback): Change type.
3075         (arm_linux_insert_hw_breakpoint1): Update.
3076         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
3077         parameter.
3078         (x86_linux_dr_set_addr): Update.
3079         (x86_linux_dr_set_control): Update.
3080         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
3081         (iterate_over_lwps): Use gdb::function_view.
3082         * nat/aarch64-linux-hw-point.c (struct
3083         aarch64_dr_update_callback_param): Remove.
3084         (debug_reg_change_callback): Change type.
3085         (aarch64_notify_debug_reg_change): Update.
3086         * s390-linux-nat.c (s390_refresh_per_info): Update.
3087
3088 2019-03-11  Tom Tromey  <tromey@adacore.com>
3089
3090         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
3091         redundant assignment to "this_cu".
3092
3093 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3094
3095         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
3096
3097 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3098
3099         * gdbtypes.c (rank_one_type_parm_set): New function extracted
3100         from...
3101         (rank_one_type): ... this.
3102
3103 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3104
3105         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
3106         from...
3107         (rank_one_type): ... this.
3108
3109 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3110
3111         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
3112         from...
3113         (rank_one_type): ... this.
3114
3115 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3116
3117         * gdbtypes.c (rank_one_type_parm_float): New function extracted
3118         from...
3119         (rank_one_type): ... this.
3120
3121 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3122
3123         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
3124         from...
3125         (rank_one_type): ... this.
3126
3127 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3128
3129         * gdbtypes.c (rank_one_type_parm_range): New function extracted
3130         from...
3131         (rank_one_type): ... this.
3132
3133 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3134
3135         * gdbtypes.c (rank_one_type_parm_char): New function extracted
3136         from...
3137         (rank_one_type): ... this.
3138
3139 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3140
3141         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
3142         from...
3143         (rank_one_type): ... this.
3144
3145 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3146
3147         * gdbtypes.c (rank_one_type_parm_int): New function extracted
3148         from...
3149         (rank_one_type): ... this.
3150
3151 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3152
3153         * gdbtypes.c (rank_one_type_parm_func): New function extracted
3154         from...
3155         (rank_one_type): ... this.
3156
3157 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3158
3159         * gdbtypes.c (rank_one_type_parm_array): New function extracted
3160         from...
3161         (rank_one_type): ... this.
3162
3163 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
3164
3165         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
3166         from...
3167         (rank_one_type): ... this.
3168
3169 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3170
3171         * inferior.c (initialize_inferiors): Ensure 'help set/show print
3172         inferior-events' shows the example events.
3173
3174 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
3175
3176         Support styling on native MS-Windows console
3177
3178         PR/24315
3179         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
3180         on MS-Windows if $TERM is not defined.
3181
3182         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
3183
3184         * posix-hdep.c (gdb_console_fputs):
3185         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
3186         functions.
3187         * ui-file.h (gdb_console_fputs): Add prototype.
3188
3189         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
3190         back to fputs only if the former returns zero.
3191
3192 2019-03-07  Tom Tromey  <tom@tromey.com>
3193
3194         * symmisc.c (print_symbol_bcache_statistics): Update.
3195         (print_objfile_statistics): Update.
3196         * symfile.c (allocate_symtab): Update.
3197         * stabsread.c: Don't include bcache.h.
3198         * psymtab.h (struct psymbol_bcache): Don't declare.
3199         (class psymtab_storage) <psymbol_cache>: Now a bcache.
3200         (psymbol_bcache_init, psymbol_bcache_free)
3201         (psymbol_bcache_get_bcache): Don't declare.
3202         * psymtab.c (struct psymbol_bcache): Remove.
3203         (psymtab_storage::psymtab_storage): Update.
3204         (psymtab_storage::~psymtab_storage): Update.
3205         (psymbol_bcache_init, psymbol_bcache_free)
3206         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
3207         (add_psymbol_to_bcache): Update.
3208         (allocate_psymtab): Update.
3209         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3210         macro_cache>: No longer pointers.
3211         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
3212         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
3213         * macrotab.c (macro_bcache): Update.
3214         * macroexp.c: Don't include bcache.h.
3215         * gdbtypes.c (check_types_worklist): Update.
3216         (types_deeply_equal): Remove TRY/CATCH.  Update.
3217         * elfread.c (elf_symtab_read): Update.
3218         * dwarf2read.c: Don't include bcache.h.
3219         * buildsym.c (buildsym_compunit::get_macro_table): Update.
3220         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
3221         (print_bcache_statistics, bcache_memory_used): Don't declare.
3222         (struct bcache): Move from bcache.c.  Add constructor, destructor,
3223         methods.  Rename all data members.
3224         * bcache.c (struct bcache): Move to bcache.h.
3225         (bcache::expand_hash_table): Rename from expand_hash_table.
3226         (bcache): Remove.
3227         (bcache::insert): Rename from bcache_full.
3228         (bcache::compare): Rename from bcache_compare.
3229         (bcache_xmalloc): Remove.
3230         (bcache::~bcache): Rename from bcache_xfree.
3231         (bcache::print_statistics): Rename from print_bcache_statistics.
3232         (bcache::memory_used): Rename from bcache_memory_used.
3233
3234 2019-03-07  Pedro Alves  <palves@redhat.com>
3235
3236         * infrun.c (normal_stop): Also check for
3237         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
3238
3239 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3240
3241         * f-lang.c (value_from_host_double): Moved to...
3242         * value.c (value_from_host_double): ...here.
3243         * value.h (value_from_host_double): Declare.
3244         * guile/scm-math.c (vlscm_convert_typed_number): Use
3245         value_from_host_double.
3246         (vlscm_convert_number): Likewise.
3247         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
3248         * python/py-value.c (convert_value_from_python): Likewise.
3249
3250 2019-03-06  Tom Tromey  <tom@tromey.com>
3251
3252         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
3253
3254 2019-03-06  Tom Tromey  <tom@tromey.com>
3255
3256         * utils.h (free_current_contents): Don't declare.
3257         * utils.c (free_current_contents): Remove.
3258
3259 2019-03-06  Tom Tromey  <tom@tromey.com>
3260
3261         * top.c (quit_force): Update.
3262         * main.c (captured_command_loop): Update.
3263         * common/new-op.c (operator new): Update.
3264         * common/common-exceptions.c (struct catcher)
3265         <save_cleanup_chain>: Remove member.
3266         (exceptions_state_mc_init): Update.
3267         (exception_try_scope_entry): Return nullptr.
3268         (exception_try_scope_exit, exception_rethrow)
3269         (throw_exception_sjlj, throw_exception_cxx): Update.
3270         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
3271         (all_cleanups, do_cleanups, discard_cleanups)
3272         (discard_final_cleanups, save_cleanups, save_final_cleanups)
3273         (restore_cleanups, restore_final_cleanups): Don't declare.
3274         (do_final_cleanups): Remove parameter.
3275         * common/cleanups.c (cleanup_chain, make_cleanup)
3276         (make_cleanup_dtor, all_cleanups, do_cleanups)
3277         (discard_my_cleanups, discard_cleanups)
3278         (discard_final_cleanups, save_my_cleanups, save_cleanups)
3279         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
3280         (null_cleanup): Remove.
3281         (do_final_cleanups): Remove parameter.
3282
3283 2019-03-06  Tom Tromey  <tom@tromey.com>
3284
3285         * remote.c (remote_target::remote_parse_stop_reply): Use
3286         unique_xmalloc_ptr.
3287
3288 2019-03-06  Tom Tromey  <tom@tromey.com>
3289
3290         * stabsread.c (struct stabs_field_info): Rename from field_info.
3291         <list, fnlist>: Add initializers.
3292         <obstack>: New member.
3293         (read_member_functions, read_struct_fields, read_baseclasses):
3294         Allocate on obstack.  Don't use cleanups.
3295         (read_one_struct_field, read_member_functions, read_struct_fields)
3296         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
3297         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
3298         (read_struct_type): Update.
3299
3300 2019-03-06  Tom Tromey  <tom@tromey.com>
3301
3302         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
3303         * common/filestuff.h (make_cleanup_close): Don't declare.
3304         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
3305         Remove.
3306
3307 2019-03-06  Tom Tromey  <tom@tromey.com>
3308
3309         * solib-aix.c: Use make_scope_exit.
3310
3311 2019-03-06  Tom Tromey  <tom@tromey.com>
3312
3313         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
3314         Use make_scope_exit.
3315
3316 2019-03-06  Tom Tromey  <tom@tromey.com>
3317
3318         * solib-svr4.c (disable_probes_interface): Remove parameter.
3319         (svr4_handle_solib_event): Use make_scope_exit.
3320
3321 2019-03-06  Tom Tromey  <tom@tromey.com>
3322
3323         * remote.c (struct stop_reply_deleter): Remove.
3324         (stop_reply_up): Update.
3325         (struct stop_reply): Derive from notif_event.  Don't typedef.
3326         <regcache>: Now a std::vector.
3327         (stop_reply_xfree): Remove.
3328         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
3329         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
3330         (remote_target::discard_pending_stop_replies): Use delete.
3331         (remote_target::remote_parse_stop_reply): Update.
3332         (remote_target::process_stop_reply): Update.
3333         * remote-notif.h (struct notif_event): Add virtual destructor.
3334         Remove "dtr" member.
3335         (struct notif_client) <alloc_event>: Return a unique_ptr.
3336         (notif_event_xfree): Don't declare.
3337         (notif_event_up): New typedef.
3338         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
3339         (notif_event_xfree, do_notif_event_xfree): Remove.
3340         (remote_notif_state_xfree): Update.
3341
3342 2019-03-06  Tom Tromey  <tom@tromey.com>
3343
3344         * infrun.c (displaced_step_clear_cleanup): Now a
3345         forward_scope_exit type.
3346         (displaced_step_prepare_throw): Update.
3347         (displaced_step_fixup): Update.
3348
3349 2019-03-06  Tom Tromey  <tom@tromey.com>
3350
3351         * inferior.h (class inferior): Update comment.
3352         * gdbthread.h (class thread_info): Update comment.
3353
3354 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
3355             Tom Tromey  <tom@tromey.com>
3356
3357         * stabsread.h (struct stab_section_list): Remove.
3358         (coffstab_build_psymtabs): Update.
3359         * dbxread.c (symbuf_sections): Now a std::vector.
3360         (sect_idx): New global.
3361         (fill_symbuf): Update.
3362         (coffstab_build_psymtabs): Change type of stabsects parameter.
3363         Update.
3364         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
3365         std::vector.
3366         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
3367         (coff_locate_sections): Update.
3368         (coff_symfile_read): Remove cleanups.  Update.
3369         (init_stringtab): Add storage parameter.
3370         (free_stringtab, free_stringtab_cleanup): Remove.
3371         (init_lineno): Add storage parameter.
3372         (free_linetab, free_linetab_cleanup): Remove.
3373
3374 2019-03-06  Pedro Alves  <palves@redhat.com>
3375
3376         * linux-fork.c (fork_info::clobber_regs): Delete.
3377         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
3378         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
3379         comment.  Adjust.
3380         (scoped_switch_fork_info::scoped_switch_fork_info)
3381         (checkpoint_command, linux_fork_context): Adjust
3382         fork_save_infrun_state calls.
3383
3384 2019-03-06  Pedro Alves  <palves@redhat.com>
3385
3386         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
3387         (inf_has_multiple_threads): Return 'bool' and rewrite using
3388         inferior_info::threads().
3389
3390 2019-03-06  Pedro Alves  <palves@redhat.com>
3391
3392         * linux-fork.c: Include <list>.
3393         (fork_list): Now a std::list instance.
3394         (fork_info): Add ctor, dtor, and in-class initialize all fields.
3395         (forks_exist_p, find_last_fork): Adjust.
3396         (new_fork): Delete.
3397         (one_fork_p): New.
3398         (add_fork): Adjust.
3399         (free_fork): Delete, folded into fork_info::~fork_info().
3400         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
3401         Adjust.
3402         (init_fork_list): Delete.
3403         (linux_fork_killall, linux_fork_mourn_inferior)
3404         (linux_fork_detach, info_checkpoints_command): Adjust.
3405         (_initialize_linux_fork): No longer call init_fork_list.
3406
3407 2019-03-06  Pedro Alves  <palves@redhat.com>
3408
3409         * linux-fork.c (new_fork): New, split out of ...
3410         (add_fork): ... this.  Return void.  Move "first fork" special
3411         case from here, to ...
3412         (checkpoint_command): ... here.
3413         * linux-linux.h (add_fork): Return void.
3414
3415 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3416
3417         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
3418
3419 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3420             Chris January  <chris.january@arm.com>
3421             David Lecomber  <david.lecomber@arm.com>
3422
3423         * f-exp.y: New token, UNOP_INTRINSIC.
3424         (exp): New pattern using UNOP_INTRINSIC token.
3425         (f77_keywords): Add 'abs' keyword.
3426         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
3427         (value_from_host_double): New function.
3428         (evaluate_subexp_f): Support UNOP_ABS.
3429
3430 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3431
3432         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
3433         types.
3434
3435 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3436
3437         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
3438         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
3439         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
3440
3441 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * f-exp.y (convert_to_kind_type): Handle more type kinds.
3444
3445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3446             Chris January  <chris.january@arm.com>
3447
3448         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
3449         * f-exp.y: Define 'KIND' token.
3450         (exp): New pattern for KIND expressions.
3451         (ptype): Handle types with a kind extension.
3452         (direct_abs_decl): Extend to spot kind extensions.
3453         (f77_keywords): Add 'kind' to the list.
3454         (push_kind_type): New function.
3455         (convert_to_kind_type): New function.
3456         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
3457         * parse.c (operator_length_standard): Likewise.
3458         * parser-defs.h (enum type_pieces): Add tp_kind.
3459         * std-operator.def: Add UNOP_KIND.
3460
3461 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3462
3463         * f-exp.y (f_parse): Set yydebug.
3464
3465 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3466
3467         * f-lang.c (evaluate_subexp_f): New function.
3468         (exp_descriptor_f): New global.
3469         (f_language_defn): Use exp_descriptor_f instead of
3470         exp_descriptor_standard.
3471
3472 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3473
3474         * f-exp.y (struct token): Add comments.
3475         (dot_ops): Remove uppercase versions and the end marker.
3476         (f77_keywords): Likewise.
3477         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
3478         entries in the dot_ops array are case insensitive, and use
3479         strncasecmp to compare strings.  Also some whitespace cleanup in
3480         this area.  Similar for the f77_keywords array, except entries in
3481         this list might be case sensitive.
3482
3483 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3484
3485         * f-exp.y (struct f77_boolean_val): Add comments.
3486         (boolean_values): Remove uppercase versions, and end marker.
3487         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3488         and use strncasecmp to achieve case insensitivity.  Additionally,
3489         perform whitespace cleanup around this code.
3490
3491 2019-03-06  Tom Tromey  <tromey@adacore.com>
3492
3493         * remote-sim.c (gdbsim_target_open): Use result of
3494         gdb_argv::release.
3495
3496 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3497         Dirk Schubert  <dirk.schubert@arm.com>
3498         Chris January  <chris.january@arm.com>
3499
3500         * eval.c (evaluate_subexp_standard): Call Fortran argument
3501         wrapping logic.
3502         * f-lang.c (struct value): A value which can be passed into a
3503         Fortran function call.
3504         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3505         where appropriate.
3506         (struct type): Value ready for a Fortran function call.
3507         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3508         is needed.
3509         * f-lang.h (fortran_argument_convert): Declaration.
3510         (fortran_preserve_arg_pointer): Declaration.
3511         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3512
3513 2019-03-05  Tom Tromey  <tromey@adacore.com>
3514
3515         * python/py-prettyprint.c (print_string_repr): Remove #if.
3516         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3517
3518 2019-03-05  Tom Tromey  <tromey@adacore.com>
3519
3520         * target.c (the_dummy_target): Move later.  Change type to
3521         "dummy_target".
3522         (initialize_targets): Don't initialize the_dummy_target.
3523
3524 2019-03-05  Tom Tromey  <tromey@adacore.com>
3525
3526         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3527         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3528
3529 2019-03-05  Tom Tromey  <tromey@adacore.com>
3530
3531         * windows-nat.c (windows_nat_target::attach)
3532         (windows_nat_target::detach): Don't call gdb_flush.
3533         * valprint.c (generic_val_print, val_print, val_print_string):
3534         Don't call gdb_flush.
3535         * utils.c (defaulted_query): Don't call gdb_flush.
3536         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3537         * target.c (target_announce_detach): Don't call gdb_flush.
3538         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3539         * remote.c (extended_remote_target::attach): Don't call
3540         gdb_flush.
3541         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3542         * printcmd.c (do_examine): Don't call gdb_flush.
3543         (info_display_command): Don't call gdb_flush.
3544         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3545         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3546         * memattr.c (info_mem_command): Don't call gdb_flush.
3547         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3548         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3549         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3550         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3551         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3552         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3553         (gnu_nat_target::detach): Don't call gdb_flush.
3554         * f-valprint.c (f_val_print): Don't call gdb_flush.
3555         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3556         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3557         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3558         gdb_flush.
3559         * c-valprint.c (c_val_print): Don't call gdb_flush.
3560         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3561
3562 2019-03-05  Tom Tromey  <tromey@adacore.com>
3563
3564         * varobj.c (update_dynamic_varobj_children): Update.
3565         (install_default_visualizer): Use reset, not release.
3566         * value.c (set_internalvar): Update.
3567         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3568         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3569         ATTRIBUTE_UNUSED_RESULT.
3570
3571 2019-03-05  Tom Tromey  <tromey@adacore.com>
3572
3573         * remote.c (class scoped_remote_fd) <release>: Add
3574         ATTRIBUTE_UNUSED_RESULT.
3575
3576 2019-03-05  Tom Tromey  <tromey@adacore.com>
3577
3578         * macroexp.c (struct macro_buffer) <release>: Add
3579         ATTRIBUTE_UNUSED_RESULT.
3580
3581 2019-03-05  Tom Tromey  <tromey@adacore.com>
3582
3583         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3584         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3585         ATTRIBUTE_UNUSED_RESULT.
3586
3587 2019-03-05  Tom Tromey  <tromey@adacore.com>
3588
3589         * common/scoped_fd.h (class scoped_fd) <release>: Add
3590         ATTRIBUTE_UNUSED_RESULT.
3591
3592 2019-03-05  Tom Tromey  <tromey@adacore.com>
3593
3594         * parser-defs.h (struct parser_state) <release>: Add
3595         ATTRIBUTE_UNUSED_RESULT.
3596
3597 2019-03-05  Tom Tromey  <tromey@adacore.com>
3598
3599         * utils.h (class gdb_argv) <release>: Add
3600         ATTRIBUTE_UNUSED_RESULT.
3601         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3602
3603 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3604
3605         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3606         for-loop range, to avoid compiler warnings.
3607
3608         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3609         avoid compiler warnings about unused variables.
3610
3611         * NEWS: Mention end of support for native debugging on MS-Windows
3612         before XP.
3613
3614         PR gdb/24292
3615         * common/netstuff.c:
3616         * gdbserver/gdbreplay.c
3617         * gdbserver/remote-utils.c:
3618         * ser-tcp.c:
3619         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3620         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3621         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3622         'getaddrinfo' and 'freeaddrinfo' were not available before
3623         Windows XP, and mingw.org's MinGW headers by default define
3624         _WIN32_WINNT to 0x500.
3625
3626 2019-03-01  Gary Benson <gbenson@redhat.com>
3627
3628         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3629
3630 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3631             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3632
3633         PR gdb/8527
3634         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3635         set_sigint_trap, clear_sigint_trap.
3636
3637 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3638
3639         * target.c (target_detach): Clear the regcache and the
3640         frame cache.
3641
3642 2019-02-27  Pedro Alves  <palves@redhat.com>
3643
3644         * utils.c (set_screen_size): When we cap the height/width sizes,
3645         tweak the corresponding command variable to show "unlimited":
3646
3647 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3648             Pedro Alves  <palves@redhat.com>
3649
3650         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3651         before calling rl_set_screen_size.
3652
3653 2019-02-27  Tom Tromey  <tromey@adacore.com>
3654
3655         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3656         define.
3657         * python/py-value.c: Remove Python 2.4 workaround.
3658         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3659         workaround.
3660         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3661         Python 2.4 workaround.
3662         * python/python-internal.h: Remove Python 2.4 comment.
3663         (Py_ssize_t): Don't define.
3664         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3665         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3666         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3667         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3668         * python/python.c (do_start_initialization): Remove Python 2.4
3669         workaround.
3670         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3671         (print_children): Remove Python 2.4 workaround.
3672         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3673         workaround.
3674         (CHARBUFFERPROC_NAME): Remove.
3675         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3676         Python 2.4 workaround.
3677
3678 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3679
3680         * NEWS: Note minimum Python version.
3681
3682 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3683
3684         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3685         code from these functions.  Remove corresponding ifdefs.  Use
3686         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3687         Remove gotos and target of gotos.
3688         (infpy_search_memory): Likewise.
3689
3690 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3691
3692         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3693         (hppa_gdbarch_init): Don't register deleted functions with
3694         gdbarch.
3695
3696 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3699         (h8300_unwind_sp): Delete.
3700         (h8300_dummy_id): Delete.
3701         (h8300_gdbarch_init): Don't register deleted functions with
3702         gdbarch.
3703
3704 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3705
3706         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3707         (ft32_unwind_pc): Delete.
3708         (ft32_unwind_sp): Delete.
3709         (ft32_gdbarch_init): Don't register deleted functions with
3710         gdbarch.
3711
3712 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3713
3714         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3715         (frv_unwind_pc): Delete.
3716         (frv_unwind_sp): Delete.
3717         (frv_gdbarch_init): Don't register deleted functions with
3718         gdbarch.
3719
3720 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3721
3722         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3723         (riscv_unwind_pc): Delete.
3724         (riscv_unwind_sp): Delete.
3725         (riscv_gdbarch_init): Don't register deleted functions with
3726         gdbarch.
3727
3728 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3729
3730         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3731         (csky_unwind_pc): Delete.
3732         (csky_unwind_sp): Delete.
3733         (csky_gdbarch_init): Don't register deleted functions with
3734         gdbarch.
3735
3736 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3737
3738         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3739         (cris_unwind_pc): Delete.
3740         (cris_unwind_sp): Delete.
3741         (cris_gdbarch_init): Don't register deleted functions with
3742         gdbarch.
3743
3744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3745
3746         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3747         (bfin_unwind_pc): Delete.
3748         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3749
3750 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3751
3752         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3753         (arm_unwind_pc): Delete.
3754         (arm_unwind_sp): Delete.
3755         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3756
3757 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3760         (arc_unwind_pc): Delete.
3761         (arc_unwind_sp): Delete.
3762         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3763
3764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3765
3766         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3767         (alpha_unwind_pc): Delete.
3768         (alpha_gdbarch_init): Don't register deleted functions with
3769         gdbarch.
3770
3771 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3772
3773         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3774         (aarch64_unwind_pc): Delete.
3775         (aarch64_unwind_sp): Delete.
3776         (aarch64_gdbarch_init): Don't register deleted functions with
3777         gdbarch.
3778
3779 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3780
3781         * gdbtypes.c (type_align): Don't consider static members when
3782         computing structure alignment.
3783
3784 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3785
3786         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3787         return 0 for other types.
3788         * arch-utils.c (default_type_align): Always return 0.
3789         * gdbarch.h: Regenerate.
3790         * gdbarch.sh (type_align): Extend comment.
3791         * gdbtypes.c (type_align): Add additional comments, always call
3792         gdbarch_type_align before applying the default rules.
3793         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3794         generic code will then apply a suitable default.
3795         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3796         types, return 0 for other types.
3797
3798 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3799
3800         * NEWS: Create a new section for the next release branch.
3801         Rename the section of the current branch, now that it has
3802         been cut.
3803
3804 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3805
3806         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3807         * version.in: Bump version to 8.3.50.DATE-git.
3808
3809 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3810
3811         * aix-thread.c (ptid_cmp): Remove unused variable.
3812         (get_signaled_thread): Likewise.
3813         (store_regs_user_thread): Likewise.
3814         (store_regs_kernel_thread): Likewise.
3815         (fetch_regs_kernel_thread): Remove shadowed variable.
3816
3817 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3818
3819         * features/riscv/32bit-cpu.xml: Add register numbers.
3820         * features/riscv/32bit-fpu.c: Regenerate.
3821         * features/riscv/32bit-fpu.xml: Add register numbers.
3822         * features/riscv/64bit-cpu.xml: Add register numbers.
3823         * features/riscv/64bit-fpu.c: Regenerate.
3824         * features/riscv/64bit-fpu.xml: Add register numbers.
3825
3826 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3827
3828         * NEWS: Mention two argument form of gdb.Value constructor.
3829         * python/py-value.c (convert_buffer_and_type_to_value): New
3830         function.
3831         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3832         Add support for handling an optional second argument.  Call
3833         convert_buffer_and_type_to_value as appropriate.
3834         * python/python-internal.h (Py_buffer_deleter): New struct.
3835         (Py_buffer_up): New typedef.
3836
3837 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3838
3839         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3840         instead of releasing ownership.
3841
3842 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3843
3844         * dwarf2read.c (open_and_init_dwp_file): Call
3845         elf_numsections instead of bfd_count_sections to initialize
3846         dwp_file->num_sections.
3847
3848 2019-02-25  Tom Tromey  <tromey@adacore.com>
3849
3850         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3851
3852 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3853
3854         * gcore.in: Add '--readnever' option when invoking GDB.
3855
3856 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3857
3858         * MAINTAINERS: Update my email address.
3859
3860 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3861
3862         * build-id.c (build_id_to_debug_bfd_1): New function.
3863         (build_id_to_debug_bfd): Look for separate debug file in
3864         sysroot.
3865
3866 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3867
3868         * gdbarch.sh: Update the copyright year range that is placed into
3869         generated files.
3870
3871 2019-02-22  Keith Seitz  <keiths@redhat.com>
3872
3873         PR symtab/23853
3874         * linespec.c (create_sals_line_offset): Search for the default
3875         symtab's filename instead of its fullname.
3876
3877 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3878
3879         * NEWS: Update style defaults.
3880
3881 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3882
3883         * main.c (captured_main_1): Disable styling in batch mode.
3884
3885 2019-02-20  Tom Tromey  <tom@tromey.com>
3886
3887         * symtab.c (symtab_symbol_info): Fix typos.
3888
3889 2019-02-20  Tom Tromey  <tromey@adacore.com>
3890
3891         * findcmd.c (_initialize_mem_search): Use upper case for
3892         metasyntactic variables.
3893
3894 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3895
3896         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3897         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3898
3899 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3900
3901         * top.h (source_file_name): Change to std::string.
3902         * top.c (source_file_name): Likewise.
3903         (command_line_input): Adjust.
3904         * cli/cli-script.c (script_from_file): Adjust.
3905
3906 2019-02-19  Tom Tromey  <tromey@adacore.com>
3907
3908         * ravenscar-thread.c
3909         (ravenscar_thread_target::update_thread_list): Don't call
3910         ada_build_task_list.
3911         * ada-lang.h (ada_build_task_list): Don't declare.
3912         * ada-tasks.c (struct ada_tasks_inferior_data)
3913         <task_list_valid_p>: Now bool.
3914         (read_known_tasks, ada_task_list_changed)
3915         (ada_tasks_invalidate_inferior_data): Update.
3916         (read_known_tasks_array): Return bool.
3917         (read_known_tasks_list): Likewise.
3918         (read_known_tasks): Return void.
3919         (ada_build_task_list): Now static.
3920
3921 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3922
3923         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3924         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3925
3926 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3927
3928         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3929         variant for ada_tasks_pspace_data_handle and
3930         ada_tasks_inferior_data_handle.
3931         (ada_tasks_pspace_data_cleanup): New function.
3932         (ada_tasks_inferior_data_cleanup): New function.
3933
3934 2019-02-17  Tom Tromey  <tom@tromey.com>
3935
3936         * macrotab.h (macro_source_fullname): Return a std::string.
3937         * macrotab.c (macro_include, check_for_redefinition)
3938         (macro_undef, macro_lookup_definition, foreach_macro)
3939         (foreach_macro_in_scope): Update.
3940         (macro_source_fullname): Return a std::string.
3941         * macrocmd.c (show_pp_source_pos): Update.
3942
3943 2019-02-17  Tom Tromey  <tom@tromey.com>
3944
3945         * macrocmd.c (show_pp_source_pos): Style the file names.
3946
3947 2019-02-17  Tom Tromey  <tom@tromey.com>
3948
3949         PR tui/24197:
3950         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3951
3952 2019-02-17  Tom Tromey  <tom@tromey.com>
3953
3954         * ada-lang.c (user_select_syms): Use filtered printing.
3955         * utils.c (wrap_style): New global.
3956         (desired_style): Remove.
3957         (emit_style_escape): Add stream parameter.
3958         (set_output_style, reset_terminal_style, prompt_for_continue):
3959         Update.
3960         (flush_wrap_buffer): Only flush gdb_stdout.
3961         (wrap_here): Set wrap_style.
3962         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3963         treat escape sequences as a character.  Change when wrap buffer is
3964         flushed.
3965         (fputs_styled): Do not set the output style when the default is
3966         requested.
3967         * ui-style.h (struct ui_file_style) <is_default>: New method.
3968         * source.c (print_source_lines_base): Emit escape sequences in one
3969         piece.
3970
3971 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3972
3973         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3974         integers and enumeration types.
3975
3976 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3977
3978         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3979         instead of lookup_symbol_in_language
3980         (do_exact_match): New function.
3981         (ada_get_symbol_name_matcher): Return do_exact_match when
3982         doing a verbatim match.
3983
3984 2019-02-15  Tom Tromey  <tromey@adacore.com>
3985
3986         * ravenscar-thread.c (ravenscar_thread_target::resume)
3987         (ravenscar_thread_target::wait): Special case wildcard requests.
3988
3989 2019-02-15  Tom Tromey  <tromey@adacore.com>
3990
3991         * ravenscar-thread.c (base_ptid): Remove.
3992         (struct ravenscar_thread_target) <close>: New method.
3993         <m_base_ptid>: New member.
3994         <update_inferior_ptid, active_task, task_is_currently_active,
3995         runtime_initialized>: Declare methods.
3996         <ravenscar_thread_target>: Add constructor.
3997         (ravenscar_thread_target::task_is_currently_active)
3998         (ravenscar_thread_target::update_inferior_ptid)
3999         (ravenscar_runtime_initialized): Rename.  Now methods.
4000         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
4001         (ravenscar_thread_target::update_thread_list): Update.
4002         (ravenscar_thread_target::active_task): Now method.
4003         (ravenscar_thread_target::store_registers)
4004         (ravenscar_thread_target::prepare_to_store)
4005         (ravenscar_thread_target::prepare_to_store)
4006         (ravenscar_thread_target::mourn_inferior): Update.
4007         (ravenscar_inferior_created): Use "new" to create target.
4008         (ravenscar_thread_target::get_ada_task_ptid): Update.
4009         (_initialize_ravenscar): Don't initialize base_ptid.
4010         (ravenscar_ops): Remove global.
4011
4012 2019-02-15  Tom Tromey  <tromey@adacore.com>
4013
4014         * target.h (push_target): Declare new overload.
4015         * target.c (push_target): New overload, taking an rvalue reference.
4016         * remote.c (remote_target::open_1): Use push_target overload.
4017         * corelow.c (core_target_open): Use push_target overload.
4018
4019 2019-02-15  Tom Tromey  <tromey@adacore.com>
4020
4021         * ravenscar-thread.c (is_ravenscar_task)
4022         (ravenscar_task_is_currently_active): Return bool.
4023         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
4024         (_initialize_ravenscar): Remove "(void)".
4025         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
4026         Return bool.
4027
4028 2019-02-15  Tom Tromey  <tromey@adacore.com>
4029
4030         * ravenscar-thread.c (ravenscar_runtime_initializer)
4031         (has_ravenscar_runtime, get_running_thread_id)
4032         (ravenscar_thread_target::resume): Fix indentation.
4033
4034 2019-02-15  Tom Tromey  <tromey@adacore.com>
4035
4036         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
4037         from ravenscar_arch_ops.
4038         (sparc_ravenscar_ops::fetch_registers)
4039         (sparc_ravenscar_ops::store_registers): Now methods.
4040         (sparc_ravenscar_prepare_to_store): Remove.
4041         (sparc_ravenscar_ops): Redefine.
4042         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
4043         methods and destructor.  Remove members.
4044         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
4045         (ravenscar_thread_target::store_registers)
4046         (ravenscar_thread_target::prepare_to_store): Update.
4047         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
4048         Remove.
4049         (struct ppc_ravenscar_powerpc_ops): Derive from
4050         ravenscar_arch_ops.
4051         (ppc_ravenscar_powerpc_ops::fetch_registers)
4052         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
4053         (ppc_ravenscar_powerpc_ops): Redefine.
4054         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
4055         (ppc_ravenscar_e500_ops::fetch_registers)
4056         (ppc_ravenscar_e500_ops::store_registers): Now methods.
4057         (ppc_ravenscar_e500_ops): Redefine.
4058         * aarch64-ravenscar-thread.c
4059         (aarch64_ravenscar_generic_prepare_to_store): Remove.
4060         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
4061         (aarch64_ravenscar_fetch_registers)
4062         (aarch64_ravenscar_store_registers): Now methods.
4063         (aarch64_ravenscar_ops): Redefine.
4064
4065 2019-02-15  Tom Tromey  <tromey@adacore.com>
4066
4067         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
4068         (ravenscar_thread_target::stopped_by_hw_breakpoint)
4069         (ravenscar_thread_target::stopped_by_watchpoint)
4070         (ravenscar_thread_target::stopped_data_address)
4071         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
4072
4073 2019-02-15  Tom Tromey  <tromey@adacore.com>
4074
4075         * ravenscar-thread.c: Fix some typos.
4076
4077 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4078             Tom Tromey  <tromey@adacore.com>
4079
4080         * ada-lang.c (ada_exception_sal): Change addr_string to a
4081         std::string.
4082         (create_ada_exception_catchpoint): Update.
4083
4084 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4085             Tom Tromey  <tromey@adacore.com>
4086
4087         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
4088         (bp_location_ops): Remove.
4089         (base_breakpoint_allocate_location): Update.
4090         (free_bp_location): Update.
4091         * ada-lang.c (class ada_catchpoint_location)
4092         <ada_catchpoint_location>: Remove ops parameter.
4093         (ada_catchpoint_location_dtor): Remove.
4094         (ada_catchpoint_location_ops): Remove.
4095         (allocate_location_exception): Update.
4096         * breakpoint.h (struct bp_location_ops): Remove.
4097         (class bp_location) <bp_location>: Remove bp_location_ops
4098         parameter.
4099         <~bp_location>: Add destructor.
4100         <ops>: Remove.
4101
4102 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4103             Pedro Alves  <palves@redhat.com>
4104
4105         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
4106         'PATH_MAX'.
4107
4108 2019-02-14  David Michael  <fedora.dm0@gmail.com>
4109             Samuel Thibault  <samuel.thibault@gnu.org>
4110             Thomas Schwinge  <thomas@codesourcery.com>
4111
4112         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
4113         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
4114
4115 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
4116
4117         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
4118         (check_empty): Use "const char *".
4119
4120         * gnu-nat.c (gnu_nat_target::detach): Instead of
4121         'detach_inferior (pid)' call
4122         'detach_inferior (find_inferior_pid (pid))'.
4123
4124         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
4125         'nat/fork-inferior.o'.
4126         * gnu-nat.c: #include "nat/fork-inferior.h".
4127
4128         * gnu-nat.c (gnu_nat_target::detach): Instead of
4129         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
4130         * gnu-nat.h: #include "inf-child.h".
4131         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
4132         'i386_gnu_nat_target::fetch_registers'.
4133         (gnu_store_registers): Rename/move to
4134         'i386_gnu_nat_target::store_registers'.
4135
4136         * config/i386/nm-i386gnu.h: Don't "#include" any files.
4137         * gnu-nat.h (mach_thread_info): New function.
4138         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
4139
4140         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
4141
4142 2019-02-14  Frederic Konrad  <konrad@adacore.com>
4143
4144         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
4145
4146 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
4147
4148         * windows-nat.c (windows_add_thread): Add new parameter
4149         "main_thread_p" with default value set to false.  Update
4150         function documentation as well as all callers.
4151         (windows_delete_thread): Likewise.
4152         (fake_create_process): Update call to windows_add_thread.
4153         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
4154         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
4155         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
4156         call to windows_delete_thread.
4157
4158 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
4159
4160         * MAINTAINERS: Add Andrew Burgess as global maintainer.
4161
4162 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4163
4164         * symfile.c (find_separate_debug_file): Use canonical path of
4165         sysroot with child_path instead of gdb_sysroot if it is valid.
4166
4167 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4168
4169         * symfile.c (find_separate_debug_file): Use child_path to
4170         determine if an object file is under a sysroot.
4171
4172 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4173
4174         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
4175         unittests/child-path-selftests.c.
4176         * common/pathstuff.c (child_path): New function.
4177         * common/pathstuff.h (child_path): New prototype.
4178         * unittests/child-path-selftests.c: New file.
4179
4180 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
4181
4182         * symfile.c (find_separate_debug_file): Look for separate debug
4183         files in debug directories under the sysroot.
4184
4185 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4186
4187         * symtab.h (struct minimal_symbol data_p): New const method.
4188         (struct minimal_symbol text_p): Likewise.
4189         * symtab.c (output_source_filename): Use file name style
4190         to print file name.
4191         (print_symbol_info): Likewise.
4192         (print_msymbol_info): Use address style to print addresses.
4193         Use function name style to print executable text symbols.
4194         (expand_symtab_containing_pc): Use data_p.
4195         (find_pc_sect_compunit_symtab): Likewise.
4196
4197 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4198
4199         * breakpoint.c (describe_other_breakpoints): Use address style
4200         to print addresses.
4201         (say_where): Likewise.
4202
4203 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4204
4205         * ada-typeprint.c (print_func_type): Print function name
4206         style to print function name.
4207         * c-typeprint.c (c_print_type_1): Likewise.
4208
4209 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
4210
4211         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
4212         for execve.
4213
4214 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4215
4216         * c-exp.y (direct_abs_decl): Use emplace_back to record the
4217         type_stack.
4218
4219 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
4220
4221         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
4222         TYPE_CODE_REF types.
4223
4224 2019-02-08  Jim Wilson  <jimw@sifive.com>
4225
4226         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
4227         (riscv_linux_fregset): New.
4228         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
4229
4230 2019-02-07  Tom Tromey  <tom@tromey.com>
4231
4232         * thread.c (thread_cancel_execution_command): Update.
4233         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
4234         methods.
4235         (struct thread_fsm_ops): Remove.
4236         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
4237         (thread_fsm_should_stop, thread_fsm_return_value)
4238         (thread_fsm_set_finished, thread_fsm_finished_p)
4239         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
4240         Don't declare.
4241         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
4242         * infrun.c (clear_proceed_status_thread)
4243         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
4244         (print_stop_event): Update.
4245         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
4246         Add constructor.
4247         (step_command_fsm_ops): Remove.
4248         (new_step_command_fsm): Remove.
4249         (step_1): Update.
4250         (step_command_fsm::should_stop): Rename from
4251         step_command_fsm_should_stop.
4252         (step_command_fsm::clean_up): Rename from
4253         step_command_fsm_clean_up.
4254         (step_command_fsm::do_async_reply_reason): Rename from
4255         step_command_fsm_async_reply_reason.
4256         (struct until_next_fsm): Inherit from thread_fsm.  Add
4257         constructor.
4258         (until_next_fsm_ops): Remove.
4259         (new_until_next_fsm): Remove.
4260         (until_next_fsm::should_stop): Rename from
4261         until_next_fsm_should_stop.
4262         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
4263         (until_next_fsm::do_async_reply_reason): Rename from
4264         until_next_fsm_async_reply_reason.
4265         (struct finish_command_fsm): Inherit from thread_fsm.  Add
4266         constructor.  Change type of breakpoint.
4267         (finish_command_fsm_ops): Remove.
4268         (new_finish_command_fsm): Remove.
4269         (finish_command_fsm::should_stop): Rename from
4270         finish_command_fsm_should_stop.
4271         (finish_command_fsm::clean_up): Rename from
4272         finish_command_fsm_clean_up.
4273         (finish_command_fsm::return_value): Rename from
4274         finish_command_fsm_return_value.
4275         (finish_command_fsm::do_async_reply_reason): Rename from
4276         finish_command_fsm_async_reply_reason.
4277         (finish_command): Update.
4278         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
4279         Add constructor.
4280         (call_thread_fsm_ops): Remove.
4281         (call_thread_fsm::call_thread_fsm): Rename from
4282         new_call_thread_fsm.
4283         (call_thread_fsm::should_stop): Rename from
4284         call_thread_fsm_should_stop.
4285         (call_thread_fsm::should_notify_stop): Rename from
4286         call_thread_fsm_should_notify_stop.
4287         (run_inferior_call, call_function_by_hand_dummy): Update.
4288         * cli/cli-interp.c (should_print_stop_to_console): Update.
4289         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
4290         Add constructor.  Change type of location_breakpoint,
4291         caller_breakpoint.
4292         (until_break_fsm_ops): Remove.
4293         (new_until_break_fsm): Remove.
4294         (until_break_fsm::should_stop): Rename from
4295         until_break_fsm_should_stop.
4296         (until_break_fsm::clean_up): Rename from
4297         until_break_fsm_clean_up.
4298         (until_break_fsm::do_async_reply_reason): Rename from
4299         until_break_fsm_async_reply_reason.
4300         (until_break_command): Update.
4301         * thread-fsm.c: Remove.
4302         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
4303
4304 2019-02-07  Tom Tromey  <tom@tromey.com>
4305
4306         * yy-remap.h: Add include guard.
4307         * xtensa-tdep.h: Add include guard.
4308         * xcoffread.h: Rename include guard.
4309         * varobj-iter.h: Add include guard.
4310         * tui/tui.h: Rename include guard.
4311         * tui/tui-winsource.h: Rename include guard.
4312         * tui/tui-wingeneral.h: Rename include guard.
4313         * tui/tui-windata.h: Rename include guard.
4314         * tui/tui-win.h: Rename include guard.
4315         * tui/tui-stack.h: Rename include guard.
4316         * tui/tui-source.h: Rename include guard.
4317         * tui/tui-regs.h: Rename include guard.
4318         * tui/tui-out.h: Rename include guard.
4319         * tui/tui-layout.h: Rename include guard.
4320         * tui/tui-io.h: Rename include guard.
4321         * tui/tui-hooks.h: Rename include guard.
4322         * tui/tui-file.h: Rename include guard.
4323         * tui/tui-disasm.h: Rename include guard.
4324         * tui/tui-data.h: Rename include guard.
4325         * tui/tui-command.h: Rename include guard.
4326         * tic6x-tdep.h: Add include guard.
4327         * target/waitstatus.h: Rename include guard.
4328         * target/wait.h: Rename include guard.
4329         * target/target.h: Rename include guard.
4330         * target/resume.h: Rename include guard.
4331         * target-float.h: Rename include guard.
4332         * stabsread.h: Add include guard.
4333         * rs6000-tdep.h: Add include guard.
4334         * riscv-fbsd-tdep.h: Add include guard.
4335         * regformats/regdef.h: Rename include guard.
4336         * record.h: Rename include guard.
4337         * python/python.h: Rename include guard.
4338         * python/python-internal.h: Rename include guard.
4339         * python/py-stopevent.h: Rename include guard.
4340         * python/py-ref.h: Rename include guard.
4341         * python/py-record.h: Rename include guard.
4342         * python/py-record-full.h: Rename include guard.
4343         * python/py-record-btrace.h: Rename include guard.
4344         * python/py-instruction.h: Rename include guard.
4345         * python/py-events.h: Rename include guard.
4346         * python/py-event.h: Rename include guard.
4347         * procfs.h: Add include guard.
4348         * proc-utils.h: Add include guard.
4349         * p-lang.h: Add include guard.
4350         * or1k-tdep.h: Rename include guard.
4351         * observable.h: Rename include guard.
4352         * nto-tdep.h: Rename include guard.
4353         * nat/x86-linux.h: Rename include guard.
4354         * nat/x86-linux-dregs.h: Rename include guard.
4355         * nat/x86-gcc-cpuid.h: Add include guard.
4356         * nat/x86-dregs.h: Rename include guard.
4357         * nat/x86-cpuid.h: Rename include guard.
4358         * nat/ppc-linux.h: Rename include guard.
4359         * nat/mips-linux-watch.h: Rename include guard.
4360         * nat/linux-waitpid.h: Rename include guard.
4361         * nat/linux-ptrace.h: Rename include guard.
4362         * nat/linux-procfs.h: Rename include guard.
4363         * nat/linux-osdata.h: Rename include guard.
4364         * nat/linux-nat.h: Rename include guard.
4365         * nat/linux-namespaces.h: Rename include guard.
4366         * nat/linux-btrace.h: Rename include guard.
4367         * nat/glibc_thread_db.h: Rename include guard.
4368         * nat/gdb_thread_db.h: Rename include guard.
4369         * nat/gdb_ptrace.h: Rename include guard.
4370         * nat/fork-inferior.h: Rename include guard.
4371         * nat/amd64-linux-siginfo.h: Rename include guard.
4372         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
4373         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
4374         * nat/aarch64-linux.h: Rename include guard.
4375         * nat/aarch64-linux-hw-point.h: Rename include guard.
4376         * mn10300-tdep.h: Add include guard.
4377         * mips-linux-tdep.h: Add include guard.
4378         * mi/mi-parse.h: Rename include guard.
4379         * mi/mi-out.h: Rename include guard.
4380         * mi/mi-main.h: Rename include guard.
4381         * mi/mi-interp.h: Rename include guard.
4382         * mi/mi-getopt.h: Rename include guard.
4383         * mi/mi-console.h: Rename include guard.
4384         * mi/mi-common.h: Rename include guard.
4385         * mi/mi-cmds.h: Rename include guard.
4386         * mi/mi-cmd-break.h: Rename include guard.
4387         * m2-lang.h: Add include guard.
4388         * location.h: Rename include guard.
4389         * linux-record.h: Rename include guard.
4390         * linux-nat.h: Add include guard.
4391         * linux-fork.h: Add include guard.
4392         * i386-darwin-tdep.h: Rename include guard.
4393         * hppa-linux-offsets.h: Add include guard.
4394         * guile/guile.h: Rename include guard.
4395         * guile/guile-internal.h: Rename include guard.
4396         * gnu-nat.h: Rename include guard.
4397         * gdb-stabs.h: Rename include guard.
4398         * frv-tdep.h: Add include guard.
4399         * f-lang.h: Add include guard.
4400         * event-loop.h: Add include guard.
4401         * darwin-nat.h: Rename include guard.
4402         * cp-abi.h: Rename include guard.
4403         * config/sparc/nm-sol2.h: Rename include guard.
4404         * config/nm-nto.h: Rename include guard.
4405         * config/nm-linux.h: Add include guard.
4406         * config/i386/nm-i386gnu.h: Rename include guard.
4407         * config/djgpp/nl_types.h: Rename include guard.
4408         * config/djgpp/langinfo.h: Rename include guard.
4409         * compile/gcc-cp-plugin.h: Add include guard.
4410         * compile/gcc-c-plugin.h: Add include guard.
4411         * compile/compile.h: Rename include guard.
4412         * compile/compile-object-run.h: Rename include guard.
4413         * compile/compile-object-load.h: Rename include guard.
4414         * compile/compile-internal.h: Rename include guard.
4415         * compile/compile-cplus.h: Rename include guard.
4416         * compile/compile-c.h: Rename include guard.
4417         * common/xml-utils.h: Rename include guard.
4418         * common/x86-xstate.h: Rename include guard.
4419         * common/version.h: Rename include guard.
4420         * common/vec.h: Rename include guard.
4421         * common/tdesc.h: Rename include guard.
4422         * common/selftest.h: Rename include guard.
4423         * common/scoped_restore.h: Rename include guard.
4424         * common/scoped_mmap.h: Rename include guard.
4425         * common/scoped_fd.h: Rename include guard.
4426         * common/safe-iterator.h: Rename include guard.
4427         * common/run-time-clock.h: Rename include guard.
4428         * common/refcounted-object.h: Rename include guard.
4429         * common/queue.h: Rename include guard.
4430         * common/ptid.h: Rename include guard.
4431         * common/print-utils.h: Rename include guard.
4432         * common/preprocessor.h: Rename include guard.
4433         * common/pathstuff.h: Rename include guard.
4434         * common/observable.h: Rename include guard.
4435         * common/netstuff.h: Rename include guard.
4436         * common/job-control.h: Rename include guard.
4437         * common/host-defs.h: Rename include guard.
4438         * common/gdb_wait.h: Rename include guard.
4439         * common/gdb_vecs.h: Rename include guard.
4440         * common/gdb_unlinker.h: Rename include guard.
4441         * common/gdb_unique_ptr.h: Rename include guard.
4442         * common/gdb_tilde_expand.h: Rename include guard.
4443         * common/gdb_sys_time.h: Rename include guard.
4444         * common/gdb_string_view.h: Rename include guard.
4445         * common/gdb_splay_tree.h: Rename include guard.
4446         * common/gdb_setjmp.h: Rename include guard.
4447         * common/gdb_ref_ptr.h: Rename include guard.
4448         * common/gdb_optional.h: Rename include guard.
4449         * common/gdb_locale.h: Rename include guard.
4450         * common/gdb_assert.h: Rename include guard.
4451         * common/filtered-iterator.h: Rename include guard.
4452         * common/filestuff.h: Rename include guard.
4453         * common/fileio.h: Rename include guard.
4454         * common/environ.h: Rename include guard.
4455         * common/common-utils.h: Rename include guard.
4456         * common/common-types.h: Rename include guard.
4457         * common/common-regcache.h: Rename include guard.
4458         * common/common-inferior.h: Rename include guard.
4459         * common/common-gdbthread.h: Rename include guard.
4460         * common/common-exceptions.h: Rename include guard.
4461         * common/common-defs.h: Rename include guard.
4462         * common/common-debug.h: Rename include guard.
4463         * common/cleanups.h: Rename include guard.
4464         * common/buffer.h: Rename include guard.
4465         * common/btrace-common.h: Rename include guard.
4466         * common/break-common.h: Rename include guard.
4467         * cli/cli-utils.h: Rename include guard.
4468         * cli/cli-style.h: Rename include guard.
4469         * cli/cli-setshow.h: Rename include guard.
4470         * cli/cli-script.h: Rename include guard.
4471         * cli/cli-interp.h: Rename include guard.
4472         * cli/cli-decode.h: Rename include guard.
4473         * cli/cli-cmds.h: Rename include guard.
4474         * charset-list.h: Add include guard.
4475         * buildsym-legacy.h: Rename include guard.
4476         * bfin-tdep.h: Add include guard.
4477         * ax.h: Rename include guard.
4478         * arm-linux-tdep.h: Add include guard.
4479         * arm-fbsd-tdep.h: Add include guard.
4480         * arch/xtensa.h: Rename include guard.
4481         * arch/tic6x.h: Add include guard.
4482         * arch/i386.h: Add include guard.
4483         * arch/arm.h: Rename include guard.
4484         * arch/arm-linux.h: Rename include guard.
4485         * arch/arm-get-next-pcs.h: Rename include guard.
4486         * arch/amd64.h: Add include guard.
4487         * arch/aarch64-insn.h: Rename include guard.
4488         * arch-utils.h: Rename include guard.
4489         * annotate.h: Add include guard.
4490         * amd64-darwin-tdep.h: Rename include guard.
4491         * aarch64-linux-tdep.h: Add include guard.
4492         * aarch64-fbsd-tdep.h: Add include guard.
4493         * aarch32-linux-nat.h: Add include guard.
4494
4495 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4496
4497         * macrotab.c (macro_define_internal): New function that
4498         factorizes macro_define_object_internal and macro_define_function
4499         code.
4500         (macro_define_object_internal): Use macro_define_internal.
4501         (macro_define_function): Likewise.
4502
4503 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4504
4505         * macrocmd.c (extract_identifier): Return
4506         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4507         callers.
4508
4509 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4510
4511         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4512
4513 2019-02-05  Tom Tromey  <tom@tromey.com>
4514
4515         * target.c (target_stack::unpush): Move assertion earlier.
4516
4517 2019-01-30  Tom Tromey  <tom@tromey.com>
4518
4519         PR python/23615:
4520         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4521         (gdbpy_parse_and_eval): Likewise.
4522         * python/python-internal.h (gdbpy_allow_threads): New class.
4523
4524 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4525
4526         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4527         (aarch64_fbsd_fpregmap): Move earlier.
4528         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4529         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4530         instead of individual calls to trad_frame_set_reg_addr.
4531         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4532         earlier.
4533         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4534         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4535         instead of individual calls to trad_frame_set_reg_addr.
4536
4537 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4538
4539         * CONTRIBUTE: Replace contribution list with wiki link.
4540
4541 2019-01-25  Tom Tromey  <tom@tromey.com>
4542
4543         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4544
4545 2019-01-25  Tom Tromey  <tom@tromey.com>
4546
4547         * xtensa-linux-nat.c: Fix common/ includes.
4548         * xml-support.h: Fix common/ includes.
4549         * xml-support.c: Fix common/ includes.
4550         * x86-linux-nat.c: Fix common/ includes.
4551         * windows-nat.c: Fix common/ includes.
4552         * varobj.h: Fix common/ includes.
4553         * varobj.c: Fix common/ includes.
4554         * value.c: Fix common/ includes.
4555         * valops.c: Fix common/ includes.
4556         * utils.c: Fix common/ includes.
4557         * unittests/xml-utils-selftests.c: Fix common/ includes.
4558         * unittests/utils-selftests.c: Fix common/ includes.
4559         * unittests/unpack-selftests.c: Fix common/ includes.
4560         * unittests/tracepoint-selftests.c: Fix common/ includes.
4561         * unittests/style-selftests.c: Fix common/ includes.
4562         * unittests/string_view-selftests.c: Fix common/ includes.
4563         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4564         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4565         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4566         * unittests/rsp-low-selftests.c: Fix common/ includes.
4567         * unittests/parse-connection-spec-selftests.c: Fix common/
4568         includes.
4569         * unittests/optional-selftests.c: Fix common/ includes.
4570         * unittests/offset-type-selftests.c: Fix common/ includes.
4571         * unittests/observable-selftests.c: Fix common/ includes.
4572         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4573         * unittests/memrange-selftests.c: Fix common/ includes.
4574         * unittests/memory-map-selftests.c: Fix common/ includes.
4575         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4576         * unittests/function-view-selftests.c: Fix common/ includes.
4577         * unittests/environ-selftests.c: Fix common/ includes.
4578         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4579         * unittests/common-utils-selftests.c: Fix common/ includes.
4580         * unittests/cli-utils-selftests.c: Fix common/ includes.
4581         * unittests/array-view-selftests.c: Fix common/ includes.
4582         * ui-file.c: Fix common/ includes.
4583         * tui/tui-io.c: Fix common/ includes.
4584         * tracepoint.h: Fix common/ includes.
4585         * tracepoint.c: Fix common/ includes.
4586         * tracefile-tfile.c: Fix common/ includes.
4587         * top.h: Fix common/ includes.
4588         * top.c: Fix common/ includes.
4589         * thread.c: Fix common/ includes.
4590         * target/waitstatus.h: Fix common/ includes.
4591         * target/waitstatus.c: Fix common/ includes.
4592         * target.h: Fix common/ includes.
4593         * target.c: Fix common/ includes.
4594         * target-memory.c: Fix common/ includes.
4595         * target-descriptions.c: Fix common/ includes.
4596         * symtab.h: Fix common/ includes.
4597         * symfile.c: Fix common/ includes.
4598         * stap-probe.c: Fix common/ includes.
4599         * spu-linux-nat.c: Fix common/ includes.
4600         * sparc-nat.c: Fix common/ includes.
4601         * source.c: Fix common/ includes.
4602         * solib.c: Fix common/ includes.
4603         * solib-target.c: Fix common/ includes.
4604         * ser-unix.c: Fix common/ includes.
4605         * ser-tcp.c: Fix common/ includes.
4606         * ser-pipe.c: Fix common/ includes.
4607         * ser-base.c: Fix common/ includes.
4608         * selftest-arch.c: Fix common/ includes.
4609         * s12z-tdep.c: Fix common/ includes.
4610         * rust-exp.y: Fix common/ includes.
4611         * rs6000-aix-tdep.c: Fix common/ includes.
4612         * riscv-tdep.c: Fix common/ includes.
4613         * remote.c: Fix common/ includes.
4614         * remote-notif.h: Fix common/ includes.
4615         * remote-fileio.h: Fix common/ includes.
4616         * remote-fileio.c: Fix common/ includes.
4617         * regcache.h: Fix common/ includes.
4618         * regcache.c: Fix common/ includes.
4619         * record-btrace.c: Fix common/ includes.
4620         * python/python.c: Fix common/ includes.
4621         * python/py-type.c: Fix common/ includes.
4622         * python/py-inferior.c: Fix common/ includes.
4623         * progspace.h: Fix common/ includes.
4624         * producer.c: Fix common/ includes.
4625         * procfs.c: Fix common/ includes.
4626         * proc-api.c: Fix common/ includes.
4627         * printcmd.c: Fix common/ includes.
4628         * ppc-linux-nat.c: Fix common/ includes.
4629         * parser-defs.h: Fix common/ includes.
4630         * osdata.c: Fix common/ includes.
4631         * obsd-nat.c: Fix common/ includes.
4632         * nat/x86-linux.c: Fix common/ includes.
4633         * nat/x86-linux-dregs.c: Fix common/ includes.
4634         * nat/x86-dregs.h: Fix common/ includes.
4635         * nat/x86-dregs.c: Fix common/ includes.
4636         * nat/ppc-linux.c: Fix common/ includes.
4637         * nat/mips-linux-watch.h: Fix common/ includes.
4638         * nat/mips-linux-watch.c: Fix common/ includes.
4639         * nat/linux-waitpid.c: Fix common/ includes.
4640         * nat/linux-ptrace.h: Fix common/ includes.
4641         * nat/linux-ptrace.c: Fix common/ includes.
4642         * nat/linux-procfs.c: Fix common/ includes.
4643         * nat/linux-personality.c: Fix common/ includes.
4644         * nat/linux-osdata.c: Fix common/ includes.
4645         * nat/linux-namespaces.c: Fix common/ includes.
4646         * nat/linux-btrace.h: Fix common/ includes.
4647         * nat/linux-btrace.c: Fix common/ includes.
4648         * nat/fork-inferior.c: Fix common/ includes.
4649         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4650         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4651         * nat/aarch64-linux.c: Fix common/ includes.
4652         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4653         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4654         * namespace.h: Fix common/ includes.
4655         * mips-linux-tdep.c: Fix common/ includes.
4656         * minsyms.c: Fix common/ includes.
4657         * mi/mi-parse.h: Fix common/ includes.
4658         * mi/mi-main.c: Fix common/ includes.
4659         * mi/mi-cmd-env.c: Fix common/ includes.
4660         * memrange.h: Fix common/ includes.
4661         * memattr.c: Fix common/ includes.
4662         * maint.h: Fix common/ includes.
4663         * maint.c: Fix common/ includes.
4664         * main.c: Fix common/ includes.
4665         * machoread.c: Fix common/ includes.
4666         * location.c: Fix common/ includes.
4667         * linux-thread-db.c: Fix common/ includes.
4668         * linux-nat.c: Fix common/ includes.
4669         * linux-fork.c: Fix common/ includes.
4670         * inline-frame.c: Fix common/ includes.
4671         * infrun.c: Fix common/ includes.
4672         * inflow.c: Fix common/ includes.
4673         * inferior.h: Fix common/ includes.
4674         * inferior.c: Fix common/ includes.
4675         * infcmd.c: Fix common/ includes.
4676         * inf-ptrace.c: Fix common/ includes.
4677         * inf-child.c: Fix common/ includes.
4678         * ia64-linux-nat.c: Fix common/ includes.
4679         * i387-tdep.c: Fix common/ includes.
4680         * i386-tdep.c: Fix common/ includes.
4681         * i386-linux-tdep.c: Fix common/ includes.
4682         * i386-linux-nat.c: Fix common/ includes.
4683         * i386-go32-tdep.c: Fix common/ includes.
4684         * i386-fbsd-tdep.c: Fix common/ includes.
4685         * i386-fbsd-nat.c: Fix common/ includes.
4686         * guile/scm-type.c: Fix common/ includes.
4687         * guile/guile.c: Fix common/ includes.
4688         * go32-nat.c: Fix common/ includes.
4689         * gnu-nat.c: Fix common/ includes.
4690         * gdbthread.h: Fix common/ includes.
4691         * gdbarch-selftests.c: Fix common/ includes.
4692         * gdb_usleep.c: Fix common/ includes.
4693         * gdb_select.h: Fix common/ includes.
4694         * gdb_bfd.c: Fix common/ includes.
4695         * gcore.c: Fix common/ includes.
4696         * fork-child.c: Fix common/ includes.
4697         * findvar.c: Fix common/ includes.
4698         * fbsd-nat.c: Fix common/ includes.
4699         * event-top.c: Fix common/ includes.
4700         * event-loop.c: Fix common/ includes.
4701         * dwarf2read.c: Fix common/ includes.
4702         * dwarf2loc.c: Fix common/ includes.
4703         * dwarf2-frame.c: Fix common/ includes.
4704         * dwarf-index-cache.c: Fix common/ includes.
4705         * dtrace-probe.c: Fix common/ includes.
4706         * disasm-selftests.c: Fix common/ includes.
4707         * defs.h: Fix common/ includes.
4708         * csky-tdep.c: Fix common/ includes.
4709         * cp-valprint.c: Fix common/ includes.
4710         * cp-support.h: Fix common/ includes.
4711         * cp-support.c: Fix common/ includes.
4712         * corelow.c: Fix common/ includes.
4713         * completer.h: Fix common/ includes.
4714         * completer.c: Fix common/ includes.
4715         * compile/compile.c: Fix common/ includes.
4716         * compile/compile-loc2c.c: Fix common/ includes.
4717         * compile/compile-cplus-types.c: Fix common/ includes.
4718         * compile/compile-cplus-symbols.c: Fix common/ includes.
4719         * command.h: Fix common/ includes.
4720         * cli/cli-dump.c: Fix common/ includes.
4721         * cli/cli-cmds.c: Fix common/ includes.
4722         * charset.c: Fix common/ includes.
4723         * build-id.c: Fix common/ includes.
4724         * btrace.h: Fix common/ includes.
4725         * btrace.c: Fix common/ includes.
4726         * breakpoint.h: Fix common/ includes.
4727         * breakpoint.c: Fix common/ includes.
4728         * ax.h:
4729         (enum agent_op): Fix common/ includes.
4730         * ax-general.c (struct aop_map): Fix common/ includes.
4731         * ax-gdb.c: Fix common/ includes.
4732         * auxv.c: Fix common/ includes.
4733         * auto-load.c: Fix common/ includes.
4734         * arm-tdep.c: Fix common/ includes.
4735         * arch/riscv.c: Fix common/ includes.
4736         * arch/ppc-linux-common.c: Fix common/ includes.
4737         * arch/i386.c: Fix common/ includes.
4738         * arch/arm.c: Fix common/ includes.
4739         * arch/arm-linux.c: Fix common/ includes.
4740         * arch/arm-get-next-pcs.c: Fix common/ includes.
4741         * arch/amd64.c: Fix common/ includes.
4742         * arch/aarch64.c: Fix common/ includes.
4743         * arch/aarch64-insn.c: Fix common/ includes.
4744         * arch-utils.c: Fix common/ includes.
4745         * amd64-windows-tdep.c: Fix common/ includes.
4746         * amd64-tdep.c: Fix common/ includes.
4747         * amd64-sol2-tdep.c: Fix common/ includes.
4748         * amd64-obsd-tdep.c: Fix common/ includes.
4749         * amd64-nbsd-tdep.c: Fix common/ includes.
4750         * amd64-linux-tdep.c: Fix common/ includes.
4751         * amd64-linux-nat.c: Fix common/ includes.
4752         * amd64-fbsd-tdep.c: Fix common/ includes.
4753         * amd64-fbsd-nat.c: Fix common/ includes.
4754         * amd64-dicos-tdep.c: Fix common/ includes.
4755         * amd64-darwin-tdep.c: Fix common/ includes.
4756         * agent.c: Fix common/ includes.
4757         * ada-lang.h: Fix common/ includes.
4758         * ada-lang.c: Fix common/ includes.
4759         * aarch64-tdep.c: Fix common/ includes.
4760
4761 2019-01-25  Tom Tromey  <tom@tromey.com>
4762
4763         * common/create-version.sh: Use common/version.h.
4764
4765 2019-01-24  Pedro Alves  <palves@redhat.com>
4766
4767         * infrun.c (signal_stop, signal_print, signal_program)
4768         (signal_catch, signal_pass): Now arrays instead of pointers.
4769         (update_signals_program_target, do_target_resume)
4770         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4771         * linux-nat.c (linux_nat_target::pass_signals)
4772         (linux_nat_target::create_inferior, linux_nat_target::attach):
4773         Adjust.
4774         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4775         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4776         * procfs.c (procfs_target::pass_signals): Adjust.
4777         * record-full.c (record_full_target::resume): Adjust.
4778         * remote.c (remote_target::pass_signals)
4779         (remote_target::program_signals): Adjust.
4780         * target-debug.h (target_debug_print_signals): Now takes a
4781         gdb::array_view as parameter.  Adjust.
4782         * target.h (target_ops) <pass_signals, program_signals>: Replace
4783         pointer and length parameters with gdb::array_view.
4784         (target_pass_signals, target_program_signals): Likewise.
4785         * target-delegates.c: Regenerate.
4786
4787 2019-01-24  Pedro Alves  <palves@redhat.com>
4788
4789         * common/forward-scope-exit.h
4790         (forward_scope_exit::forward_scope_exit): Pass arguments to
4791         m_bind_function directly, instead of creating a std::bind and
4792         copying that.
4793
4794 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4795
4796         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4797         for static members.
4798         (pass_in_v_vfp_candidate): Likewise.
4799
4800 2019-01-23  Tom Tromey  <tom@tromey.com>
4801             Pedro Alves  <palves@redhat.com>
4802
4803         * regcache.c (class regcache_invalidator): Remove.
4804         (regcache::raw_write): Use make_scope_exit.
4805
4806 2019-01-23  Tom Tromey  <tom@tromey.com>
4807
4808         * ui-out.h (class ui_out_emit_type): Update comment.
4809
4810 2019-01-23  Tom Tromey  <tom@tromey.com>
4811
4812         * infrun.c (fetch_inferior_event): Update comment.
4813
4814 2019-01-23  Tom Tromey  <tom@tromey.com>
4815             Pedro Alves  <palves@redhat.com>
4816
4817         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4818         parameter.
4819         (fetch_inferior_event): Use SCOPE_EXIT.
4820
4821
4822 2019-01-23  Tom Tromey  <tom@tromey.com>
4823             Pedro Alves  <palves@redhat.com>
4824
4825         * infrun.c (disable_thread_events): Delete.
4826         (stop_all_threads): Use SCOPE_EXIT.
4827
4828 2019-01-23  Tom Tromey  <tom@tromey.com>
4829             Pedro Alves  <palves@redhat.com>
4830
4831         * symfile.c: Include forward-scope-exit.h.
4832         (clear_symtab_users_cleanup): Replace forward declaration with
4833         a FORWARD_SCOPE_EXIT.
4834         (syms_from_objfile_1): Use the forward_scope_exit and
4835         gdb::optional instead of cleanup_function.
4836         (reread_symbols): Use the forward_scope_exit instead of
4837         cleanup_function.
4838         (clear_symtab_users_cleanup): Remove function.
4839
4840 2019-01-23  Tom Tromey  <tom@tromey.com>
4841             Pedro Alves  <palves@redhat.com>
4842
4843         * linux-nat.c: Include scope-exit.h.
4844         (cleanup_target_stop): Remove.
4845         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4846         SCOPE_EXIT.
4847
4848 2019-01-23  Tom Tromey  <tom@tromey.com>
4849             Pedro Alves  <palves@redhat.com>
4850
4851         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4852         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4853
4854 2019-01-23  Tom Tromey  <tom@tromey.com>
4855             Andrew Burgess  <andrew.burgess@embecosm.com>
4856             Pedro Alves  <palves@redhat.com>
4857
4858         * infrun.c (fetch_inferior_event): Use scope_exit.
4859         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4860         * top.c (execute_command): Use scope_exit.
4861         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4862         * utils.c (do_bpstat_clear_actions_cleanup)
4863         (make_bpstat_clear_actions_cleanup): Remove.
4864
4865 2019-01-23  Tom Tromey  <tom@tromey.com>
4866             Pedro Alves  <palves@redhat.com>
4867
4868         * infrun.c: Include "common/scope-exit.h"
4869         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4870         (wait_for_inferior): Use SCOPE_EXIT.
4871         (fetch_inferior_event): Use scope_exit.
4872
4873 2019-01-23  Tom Tromey  <tom@tromey.com>
4874             Pedro Alves  <palves@redhat.com>
4875
4876         * breakpoint.c (create_breakpoint): Remove cleanup.
4877
4878 2019-01-23  Tom Tromey  <tom@tromey.com>
4879             Andrew Burgess  <andrew.burgess@embecosm.com>
4880             Pedro Alves  <palves@redhat.com>
4881
4882 2019-01-23  Pedro Alves  <palves@redhat.com>
4883
4884         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4885
4886 2019-01-23  Pedro Alves  <palves@redhat.com>
4887             Andrew Burgess  <andrew.burgess@embecosm.com>
4888
4889         * gdbthread.h: Include "common/forward-scope-exit.h".
4890         (scoped_finish_thread_state): Redefine custom class in terms of
4891         forward_scope_exit.
4892
4893 2019-01-23  Pedro Alves  <palves@redhat.com>
4894             Andrew Burgess  <andrew.burgess@embecosm.com>
4895
4896         * common/forward-scope-exit.h: New file.
4897
4898 2019-01-23  Pedro Alves  <palves@redhat.com>
4899             Andrew Burgess  <andrew.burgess@embecosm.com>
4900             Tom Tromey  <tom@tromey.com>
4901
4902         * common/scope-exit.h: New file.
4903
4904 2019-01-23  Pedro Alves  <palves@redhat.com>
4905
4906         * common/preprocessor.h (ESC): Rename to ...
4907         (ESC_PARENS): ... this.
4908         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4909         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4910
4911 2019-01-23  Tom Tromey  <tom@tromey.com>
4912
4913         * language.h (class scoped_switch_to_sym_language_if_auto):
4914         Initialize m_lang in both cases.
4915
4916 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4917
4918         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4919         with XCNEW.
4920
4921 2019-01-22  Tom Tromey  <tom@tromey.com>
4922
4923         * corelow.c: Do not include sys/file.h.
4924
4925 2019-01-22  Tom Tromey  <tom@tromey.com>
4926
4927         * tui/tui-wingeneral.h: Include gdb_curses.h.
4928
4929 2019-01-22  Tom Tromey  <tom@tromey.com>
4930
4931         * source-cache.h (class source_cache) <get_source_lines,
4932         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4933
4934 2019-01-22  Tom Tromey  <tom@tromey.com>
4935
4936         * remote-fileio.h (struct remote_target): Declare.
4937
4938 2019-01-22  Tom Tromey  <tom@tromey.com>
4939
4940         * python/py-arch.c: Do not include py-ref.h.
4941         * python/py-bpevent.c: Do not include py-ref.h.
4942         * python/py-cmd.c: Do not include py-ref.h.
4943         * python/py-continueevent.c: Do not include py-ref.h.
4944         * python/py-event.h: Do not include py-ref.h.
4945         * python/py-evtregistry.c: Do not include py-ref.h.
4946         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4947         * python/py-frame.c: Do not include py-ref.h.
4948         * python/py-framefilter.c: Do not include py-ref.h.
4949         * python/py-function.c: Do not include py-ref.h.
4950         * python/py-infevents.c: Do not include py-ref.h.
4951         * python/py-linetable.c: Do not include py-ref.h.
4952         * python/py-objfile.c: Do not include py-ref.h.
4953         * python/py-param.c: Do not include py-ref.h.
4954         * python/py-prettyprint.c: Do not include py-ref.h.
4955         * python/py-progspace.c: Do not include py-ref.h.
4956         * python/py-symbol.c: Do not include py-ref.h.
4957         * python/py-symtab.c: Do not include py-ref.h.
4958         * python/py-type.c: Do not include py-ref.h.
4959         * python/py-unwind.c: Do not include py-ref.h.
4960         * python/py-utils.c: Do not include py-ref.h.
4961         * python/py-value.c: Do not include py-ref.h.
4962         * python/py-varobj.c: Do not include py-ref.h.
4963         * python/py-xmethods.c: Do not include py-ref.h.
4964         * python/python.c: Do not include py-ref.h.
4965         * varobj.c: Do not include py-ref.h.
4966
4967 2019-01-22  Tom Tromey  <tom@tromey.com>
4968
4969         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4970         keyword for bcache.
4971
4972 2019-01-22  Tom Tromey  <tom@tromey.com>
4973
4974         * compile/compile-cplus-types.c: Remove a comment by #include.
4975
4976 2019-01-22  Tom Tromey  <tom@tromey.com>
4977
4978         * compile/gcc-c-plugin.h: Include compile-internal.h.
4979
4980 2019-01-22  Tom Tromey  <tom@tromey.com>
4981
4982         * stabsread.c (EXTERN): Do not define.
4983         (symnum, next_symbol_text_func, processing_gcc_compilation)
4984         (within_function, global_sym_chain, global_stabs)
4985         (previous_stab_code, this_object_header_files)
4986         (n_this_object_header_files)
4987         (n_allocated_this_object_header_files): Define.
4988         * stabsread.h (EXTERN): Never define.  Use "extern".
4989
4990 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4991
4992         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4993         history_value.
4994
4995 2019-01-21  Tom Tromey  <tom@tromey.com>
4996
4997         * ui-out.c: Fix includes.
4998         * tui/tui-source.c: Fix includes.
4999         * target.c: Fix includes.
5000         * remote.c: Fix includes.
5001         * regcache.c: Fix includes.
5002         * python/py-block.c: Fix includes.
5003         * printcmd.c: Fix includes.
5004         * or1k-tdep.c: Fix includes.
5005         * mi/mi-main.c: Fix includes.
5006         * m32r-tdep.c: Fix includes.
5007         * csky-tdep.c: Fix includes.
5008         * compile/compile-cplus-types.c: Fix includes.
5009         * cli/cli-interp.c: Fix includes.
5010
5011 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
5012
5013         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5014         for padding.
5015
5016 2019-01-16  Tom Tromey  <tom@tromey.com>
5017
5018         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
5019         earlier.
5020         (struct objfile) <msymbols_range>: Move from top level.
5021         <msymbols>: New method.
5022         (class objfile_msymbols): Remove.
5023         * symtab.c (default_collect_symbol_completion_matches_break_on):
5024         Update.
5025         * symmisc.c (dump_msymbols): Update.
5026         * stabsread.c (scan_file_globals): Update.
5027         * objc-lang.c (info_selectors_command, info_classes_command)
5028         (find_methods): Update.
5029         * minsyms.c (find_solib_trampoline_target): Update.
5030         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
5031         * coffread.c (coff_symfile_read): Update.
5032         * ada-lang.c (ada_lookup_simple_minsym)
5033         (ada_collect_symbol_completion_matches): Update.
5034
5035 2019-01-16  Tom Tromey  <tom@tromey.com>
5036
5037         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
5038         type.  Remove no-argument constructor.
5039         <iterator::operator++>: Simplify.
5040         <begin>: Update.
5041         <end>: Use minimal_symbol_count.
5042
5043 2019-01-16  Tom Tromey  <tom@tromey.com>
5044
5045         * objfiles.h (struct objfile) <psymtabs>: New method.
5046         (class objfile_psymtabs): Remove.
5047         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
5048         typedef.
5049         <range>: New method.
5050         (require_partial_symbols): Change return type.
5051         * psymtab.c (require_partial_symbols)
5052         (psym_expand_symtabs_matching): Update.
5053         * mdebugread.c (parse_partial_symbols): Update.
5054         * dbxread.c (dbx_end_psymtab): Update.
5055
5056 2019-01-15  Tom Tromey  <tom@tromey.com>
5057
5058         * symtab.c (lookup_objfile_from_block)
5059         (lookup_symbol_in_objfile_symtabs)
5060         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
5061         (find_line_symtab, info_sources_command)
5062         (default_collect_symbol_completion_matches_break_on)
5063         (make_source_files_completion_list): Update.
5064         * symmisc.c (print_objfile_statistics, dump_objfile)
5065         (maintenance_print_symbols, maintenance_info_symtabs)
5066         (maintenance_check_symtabs, maintenance_info_line_tables):
5067         Update.
5068         * source.c (select_source_symtab)
5069         (forget_cached_source_info_for_objfile): Update.
5070         * objfiles.h (class objfile_compunits): Remove.
5071         (struct objfile) <compunits_range>: New typedef.
5072         (compunits): New method.
5073         * objfiles.c (objfile_relocate1): Update.
5074         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5075         * maint.c (count_symtabs_and_blocks): Update.
5076         * linespec.c (iterate_over_all_matching_symtabs): Update.
5077         * cp-support.c (add_symbol_overload_list_qualified): Update.
5078         * coffread.c (coff_symtab_read): Update.
5079         * ada-lang.c (add_nonlocal_symbols)
5080         (ada_collect_symbol_completion_matches)
5081         (ada_add_global_exceptions): Update.
5082
5083 2019-01-15  Tom Tromey  <tom@tromey.com>
5084
5085         * progspace.h (program_space) <objfiles_safe_range>: New
5086         typedef.
5087         <objfiles_safe>: New method.
5088         * objfiles.h (class all_objfiles_safe): Remove.
5089         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
5090         * jit.c (jit_inferior_exit_hook): Update.
5091
5092 2019-01-17  Tom Tromey  <tom@tromey.com>
5093
5094         * progspace.h (program_space) <objfiles_range>: New typedef.
5095         <objfiles>: New method.
5096         <objfiles_head>: Rename from objfiles.
5097         (object_files): Update.
5098         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
5099         * guile/scm-pretty-print.c
5100         (ppscm_find_pretty_printer_from_objfiles): Update.
5101         * guile/scm-objfile.c (gdbscm_objfiles): Update.
5102         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
5103         Update.
5104         * python/py-progspace.c (pspy_get_objfiles): Update.
5105         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5106         Update.
5107         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5108         (objfpy_lookup_objfile_by_build_id): Update.
5109         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
5110         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5111         Update.
5112         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5113         (expand_symtab_containing_pc, lookup_objfile_from_block)
5114         (lookup_static_symbol, basic_lookup_transparent_type)
5115         (find_pc_sect_compunit_symtab, find_symbol_at_address)
5116         (find_line_symtab, info_sources_command)
5117         (default_collect_symbol_completion_matches_break_on)
5118         (make_source_files_completion_list, find_main_name): Update.
5119         * symmisc.c (print_symbol_bcache_statistics)
5120         (print_objfile_statistics, maintenance_print_symbols)
5121         (maintenance_print_msymbols, maintenance_print_objfiles)
5122         (maintenance_info_symtabs, maintenance_check_symtabs)
5123         (maintenance_expand_symtabs, maintenance_info_line_tables):
5124         Update.
5125         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
5126         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
5127         (map_overlay_command, unmap_overlay_command)
5128         (simple_overlay_update, expand_symtabs_matching)
5129         (map_symbol_filenames): Update.
5130         * symfile-debug.c (set_debug_symfile): Update.
5131         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
5132         Update.
5133         * source.c (select_source_symtab, forget_cached_source_info):
5134         Update.
5135         * solib.c (solib_read_symbols): Update.
5136         * solib-spu.c (append_ocl_sos): Update.
5137         * psymtab.c (maintenance_print_psymbols)
5138         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
5139         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
5140         * printcmd.c (info_symbol_command): Update.
5141         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
5142         Update.
5143         * objfiles.h (class all_objfiles): Remove.
5144         * objfiles.c (have_partial_symbols, have_full_symbols)
5145         (have_minimal_symbols, qsort_cmp, update_section_map)
5146         (shared_objfile_contains_address_p)
5147         (default_iterate_over_objfiles_in_search_order): Update.
5148         * objc-lang.c (info_selectors_command, info_classes_command)
5149         (find_methods): Update.
5150         * minsyms.c (find_solib_trampoline_target): Update.
5151         * maint.c (maintenance_info_sections)
5152         (maintenance_translate_address, count_symtabs_and_blocks):
5153         Update.
5154         * main.c (captured_main_1): Update.
5155         * linux-thread-db.c (try_thread_db_load_from_pdir)
5156         (has_libpthread): Update.
5157         * linespec.c (iterate_over_all_matching_symtabs)
5158         (search_minsyms_for_name): Update.
5159         * jit.c (jit_find_objf_with_entry_addr): Update.
5160         * hppa-tdep.c (find_unwind_entry)
5161         (hppa_lookup_stub_minimal_symbol): Update.
5162         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
5163         Update.
5164         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5165         (elf_gnu_ifunc_resolve_by_got): Update.
5166         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
5167         * dwarf-index-write.c (save_gdb_index_command): Update.
5168         * cp-support.c (add_symbol_overload_list_qualified): Update.
5169         * breakpoint.c (create_overlay_event_breakpoint)
5170         (create_longjmp_master_breakpoint)
5171         (create_std_terminate_master_breakpoint)
5172         (create_exception_master_breakpoint): Update.
5173         * blockframe.c (find_pc_partial_function): Update.
5174         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
5175         (ada_collect_symbol_completion_matches)
5176         (ada_add_global_exceptions): Update.
5177
5178 2019-01-17  Tom Tromey  <tom@tromey.com>
5179
5180         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
5181         declare VEC.
5182         (solib_target_parse_libraries): Change return type.
5183         (library_list_start_segment, library_list_start_section)
5184         (library_list_end_library, library_list_start_library); Update.
5185         (solib_target_free_library_list): Remove.
5186         (solib_target_parse_libraries): Remove cleanup.  Change return
5187         type.
5188         (solib_target_current_sos): Update.
5189
5190 2019-01-17  Tom Tromey  <tromey@bapiya>
5191
5192         * valprint.c: Replace "the the" with "the".
5193         * symtab.c: Replace "the the" with "the".
5194         * solib.c: Replace "the the" with "the".
5195         * solib-dsbt.c: Replace "the the" with "the".
5196         * linespec.c: Replace "the the" with "the".
5197         * dwarf2loc.h: Replace "the the" with "the".
5198         * amd64-windows-tdep.c: Replace "the the" with "the".
5199         * aarch64-tdep.c: Replace "the the" with "the".
5200
5201 2019-01-16  Keith Seitz  <keiths@redhat.com>
5202
5203         PR gdb/23773
5204         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
5205         <builder>: Rename to ..
5206         <m_builder>: ... this and make private.
5207         (dwarf2_cu::get_builder): New method.  Change all users of
5208         `builder' to use this method.
5209         (dwarf2_start_symtab): Move to ...
5210         (dwarf2_cu::start_symtab): ... here.  Update all callers
5211         (setup_type_unit_groups): Move to ...
5212         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
5213         callers.
5214         (dwarf2_cu::reset_builder): New method.
5215         (process_full_compunit, process_full_type_unit): Use
5216         dwarf2_cu::reset_builder.
5217         (follow_die_offset): Record the ancestor CU if it is different
5218         from the followed DIE's CU.
5219         (follow_die_sig_1): Likewise.
5220
5221 2019-01-15  Tom Tromey  <tom@tromey.com>
5222
5223         * remote.c (class remote_state) <buf>: Now a char_vector.
5224         <buf_size>: Remove.
5225         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
5226         parameter.
5227         (remote_target::getpkt_or_notif_sane_1)
5228         (remote_target::getpkt_sane)
5229         (remote_target::getpkt_or_notif_sane): Likewise.
5230         (class remote_target) <putpkt>: New overload.
5231         (remote_target::read_frame): Change type of "buf_p".  Remove
5232         sizeof_p parameter.
5233         (packet_ok): New overload.
5234         (packet_check_result): New overload.
5235         Update all uses.
5236
5237 2019-01-14  Tom Tromey  <tom@tromey.com>
5238
5239         * remote-notif.c (handle_notification, remote_notif_ack)
5240         (remote_notif_parse): Make "buf" const.
5241         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
5242         const.
5243         (remote_notif_parse, remote_notif_ack, handle_notification):
5244         Likewise.
5245         * remote.c (remote_notif_stop_parse): Make "buf" const.
5246         (remote_target::remote_parse_stop_reply): Make "buf" const.
5247         (remote_notif_stop_ack): Make "buf" const.
5248
5249 2019-01-14  Tom Tromey  <tom@tromey.com>
5250
5251         * remote.c (remote_console_output): Make parameter const.
5252
5253 2019-01-14  Tom Tromey  <tom@tromey.com>
5254
5255         * target-debug.h (target_debug_print_signals): Constify.
5256         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
5257         * procfs.c (procfs_target::pass_signals): Update.
5258         * linux-nat.c (linux_nat_target::pass_signals): Update.
5259         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
5260         * target-delegates.c: Rebuild.
5261         * remote.c (remote_target::program_signals): Update.
5262         (remote_target::pass_signals): Update.
5263         * target.c (target_pass_signals): Constify argument.
5264         (target_program_signals): Likewise.
5265         * target.h (struct target_ops) <pass_signals, program_signals>:
5266         Constify argument.
5267         (target_pass_signals, target_program_signals): Constify argument.
5268
5269 2019-01-14  Tom Tromey  <tom@tromey.com>
5270
5271         PR tui/28819:
5272         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
5273
5274 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5275
5276         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
5277         field.
5278         * rs6000-tdep.c: Include reggroups.h.
5279         (IS_V_ALIAS_PSEUDOREG): Define.
5280         (rs6000_register_name): Return names for the "vX" aliases.
5281         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
5282         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
5283         aliases.  Call default_register_reggroup_p for all other
5284         pseudo-registers.
5285         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
5286         New functions.
5287         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
5288         Handle "vX" aliases.
5289         (v_alias_pseudo_register_collect): New function.
5290         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
5291         (rs6000_gdbarch_init): Initialize "vX" aliases as
5292         pseudo-registers.  Restore registration of
5293         rs6000_pseudo_register_reggroup_p with
5294         set_tdesc_pseudo_register_reggroup_p.
5295
5296 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
5297
5298         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
5299         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
5300         set_gdbarch_num_pseudo_regs.
5301
5302 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5303
5304         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
5305         Remove arg prefixname, add do_set and do_show.
5306         Add member functions set_list and show_list.
5307         * cli/cli-style.c (class cli_style_option): Update accordingly.
5308         (style_set_list): Move to file scope.
5309         (style_show_list): Likewise.
5310         (set_style): Call help_list.
5311         (show_style): Call cmd_show_list.
5312         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
5313         Update to use the new macro.
5314
5315 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
5316
5317         * ada-lang.c (_initialize_ada_language): Expand the help text
5318         for the "catch exception" command.
5319
5320 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5321
5322         * symtab.c (matching_obj_sections): Initialize obj,
5323         declare it closer to its usage.
5324
5325 2019-01-10  Tom Tromey  <tom@tromey.com>
5326
5327         * thread-iter.h (inf_threads_iterator): Use next_iterator.
5328         (basic_inf_threads_range): Remove.
5329         (inf_threads_range, inf_non_exited_threads_range)
5330         (safe_inf_threads_range): Use next_adapter.
5331
5332 2019-01-10  Keith Seitz  <keiths@redhat.com>
5333
5334         PR gdb/23712
5335         PR symtab/23010
5336         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
5337         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
5338
5339 2019-01-10  Keith Seitz  <keiths@redhat.com>
5340
5341         PR gdb/23712
5342         PR symtab/23010
5343         * dictionary.c (pending_to_vector): Remove.
5344         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5345         Remove _1 suffix, replacing functions of the same name.  Update
5346         all callers.
5347         (dict_create_hashed, dict_create_hashed_expandable)
5348         (dict_create_linear, dict_create_linear_expandable, dict_free)
5349         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
5350         Make functions static.
5351
5352 2019-01-10  Keith Seitz  <keiths@redhat.com>
5353
5354         PR gdb/23712
5355         PR symtab/23010
5356         * dictionary.h (struct dictionary): Replace declaration with
5357         multidictionary.
5358         (dict_create_hashed, dict_create_hashed_expandable)
5359         (dict_create_linear, dict_create_linear_expandable)
5360         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
5361         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
5362         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
5363         taking multidictionary argument.
5364         [ALL_DICT_SYMBOLS]: Update for multidictionary.
5365         * block.h (struct block) <dict>: Change to multidictionary
5366         and rename `multidict'.
5367         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
5368         symmisc.c: Update all dictionary references to multidictionary.
5369
5370 2019-01-10  Keith Seitz  <keiths@redhat.com>
5371
5372         PR gdb/23712
5373         PR symtab/23010
5374         * dictionary.c: Include unordered_map.
5375         (pending_to_vector): New function.
5376         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
5377         Rewrite the non-"_1" functions to take vector instead
5378         of linked list.
5379         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
5380         "new" _1 versions of the same name.
5381         (multidictionary): Define.
5382         (std::hash<enum language): New definition.
5383         (collate_pending_symbols_by_language, mdict_create_hashed)
5384         (mdict_create_hashed_expandable, mdict_create_linear)
5385         (mdict_create_linear_expandable, mdict_free)
5386         (find_language_dictionary, create_new_language_dictionary)
5387         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
5388         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
5389         (mdict_size, mdict_empty): New functions.
5390         * dictionary.h (mdict_iterator): Define.
5391
5392 2019-01-10  Pedro Alves  <palves@redhat.com>
5393
5394         * breakpoint.c (read_uploaded_action)
5395         (create_tracepoint_from_upload): Adjust to use
5396         gdb::unique_xmalloc_ptr.
5397         * ctf.c (ctf_write_uploaded_tp):
5398         (SET_ARRAY_FIELD): Use emplace_back.
5399         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
5400         * tracefile-tfile.c (tfile_write_uploaded_tp):
5401         * tracepoint.c (parse_tracepoint_definition): Adjust to use
5402         gdb::unique_xmalloc_ptr.
5403         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
5404         at_string, cond_string, cmd_strings>: Replace char pointers
5405         with gdb::unique_xmalloc_ptr.
5406
5407 2019-01-10  Pedro Alves  <palves@redhat.com>
5408
5409         * solib-target.c (library_list_start_library): Don't xstrdup name.
5410
5411 2019-01-10  Pedro Alves  <palves@redhat.com>
5412
5413         * mdebugread.c (parse_partial_symbols): Use
5414         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
5415
5416 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5417
5418         * linux-fork.c (scoped_switch_fork_info)
5419         <~scoped_switch_fork_info>: Fix incorrect variable name.
5420
5421 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5422
5423         * linux-fork.c (scoped_switch_fork_info)
5424         <scoped_switch_fork_info>: Make explicit.
5425         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
5426
5427 2019-01-10  Tom Tromey  <tom@tromey.com>
5428
5429         * objfiles.h (objfile::reset_psymtabs): Update.
5430         * objfiles.c (objfile::objfile): Update.
5431         * psymtab.h (psymtab_storage::obstack): Update.
5432         (psymtab_storage::m_obstack): Use gdb::optional.
5433         (class psymtab_storage): Update comment.  Remove objfile
5434         parameter.
5435         * psymtab.c (psymtab_storage::psymtab_storage): Update.
5436
5437 2019-01-10  Tom Tromey  <tom@tromey.com>
5438
5439         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
5440         <free_psymtabs>: Now private.
5441         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
5442         (allocate_psymtab): Use new method.
5443
5444 2019-01-10  Tom Tromey  <tom@tromey.com>
5445
5446         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
5447         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
5448         * mdebugread.c (parse_partial_symbols): Use
5449         allocate_dependencies.
5450         * dwarf2read.c (dwarf2_create_include_psymtab): Use
5451         allocate_dependencies.
5452         (process_psymtab_comp_unit_reader)
5453         (build_type_psymtab_dependencies): Likewise.
5454         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
5455
5456 2019-01-10  Tom Tromey  <tom@tromey.com>
5457
5458         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
5459         PSYMBOL_SET_LANGUAGE.
5460         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
5461
5462 2019-01-10  Tom Tromey  <tom@tromey.com>
5463
5464         * psymtab.h (psymtab_storage::obstack): New method.
5465         <m_obstack>: Rename from obstack; now private.
5466         * psymtab.c (psymtab_storage): Update.
5467         * dwarf2read.c (create_addrmap_from_index)
5468         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
5469         Update.
5470
5471 2019-01-10  Tom Tromey  <tom@tromey.com>
5472
5473         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
5474         * objfiles.h (objfile::reset_psymtabs): New method.
5475
5476 2019-01-10  Tom Tromey  <tom@tromey.com>
5477
5478         * symmisc.c (print_symbol_bcache_statistics): Update.
5479         (print_objfile_statistics): Update.
5480         * symfile.c (reread_symbols): Update.
5481         * psymtab.h (class psymtab_storage): New.
5482         * psymtab.c (psymtab_storage): New constructor.
5483         (~psymtab_storage): New destructor.
5484         (require_partial_symbols): Update.
5485         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5486         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5487         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5488         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5489         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5490         (start_psymtab_common, end_psymtab_common)
5491         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5492         (allocate_psymtab): Update.
5493         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5494         Update.
5495         (dump_psymtab_addrmap, maintenance_print_psymbols)
5496         (maintenance_check_psymtabs): Update.
5497         (class objfile_psymtabs): Move to objfiles.h.
5498         * psympriv.h (discard_psymtab): Now inline.
5499         (psymtab_discarder::psymtab_discarder): Update.
5500         (psymtab_discarder::~psymtab_discarder): Update.
5501         (ALL_OBJFILE_PSYMTABS): Rewrite.
5502         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5503         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5504         Remove fields.
5505         <partial_symtabs>: New field.
5506         (class objfile_psymtabs): Move from psymtab.h.  Update.
5507         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5508         psymbol_cache.
5509         (objfile::~objfile): Don't destroy psymbol_cache.
5510         * mdebugread.c (parse_partial_symbols): Update.
5511         * dwarf2read.c (create_addrmap_from_index)
5512         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5513         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5514         (add_partial_subprogram, dwarf2_ranges_read): Update.
5515         * dwarf-index-write.c (write_address_map)
5516         (write_one_signatured_type, recursively_write_psymbols)
5517         (class debug_names, class debug_names, write_psymtabs_to_index):
5518         Update.
5519
5520 2019-01-10  Tom Tromey  <tom@tromey.com>
5521
5522         * symtab.h (SYMBOL_SET_NAMES): Update.
5523         (symbol_set_names): Update.
5524         (MSYMBOL_SET_NAMES): Update.
5525         * symtab.c (symbol_set_names): Change argument to be an
5526         objfile_per_bfd_storage.
5527         * psymtab.c (add_psymbol_to_bcache): Update.
5528         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5529
5530 2019-01-10  Tom Tromey  <tom@tromey.com>
5531
5532         * symtab.c (create_demangled_names_hash): Change argument to be an
5533         objfile_per_bfd_storage.
5534         (symbol_set_names): Update.
5535
5536 2019-01-10  Tom Tromey  <tom@tromey.com>
5537
5538         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5539         init_psymbol_list.
5540         * psymtab.c (init_psymbol_list): Do nothing if already called.
5541         * psympriv.h (init_psymbol_list): Add comment.
5542         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5543         init_psymbol_list.
5544         * dbxread.c (dbx_symfile_read): Unconditionally call
5545         init_psymbol_list.
5546
5547 2019-01-10  Tom Tromey  <tom@tromey.com>
5548
5549         * xcoffread.c (scan_xcoff_symtab): Update.
5550         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5551         "where".
5552         * mdebugread.c (parse_partial_symbols)
5553         (handle_psymbol_enumerators): Update.
5554         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5555         * dbxread.c (read_dbx_symtab): Update.
5556         * psympriv.h (psymbol_placement): New enum.
5557         (add_psymbol_to_list): Update.
5558
5559 2019-01-10  Tom Tromey  <tom@tromey.com>
5560
5561         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5562         static_psymbols parameters.
5563         (scan_xcoff_symtab): Update.
5564         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5565         static_psymbols parameters.
5566         * psympriv.h (start_psymtab_common): Update.
5567         * mdebugread.c (parse_partial_symbols): Update.
5568         * dwarf2read.c (create_partial_symtab): Update.
5569         * dbxread.c (read_dbx_symtab): Update.
5570         (start_psymtab): Remove global_psymbols and static_psymbols
5571         parameters.
5572
5573 2019-01-10  Tom Tromey  <tom@tromey.com>
5574
5575         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5576         * psymtab.c (allocate_psymtab): Add comment.
5577         * psympriv.h (allocate_psymtab): Add comment.
5578         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5579         initializations.
5580         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5581
5582 2019-01-10  Tom Tromey  <tom@tromey.com>
5583
5584         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5585         Don't declare.
5586         * mipsread.c: Include mdebugread.h.
5587         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5588         Declare.
5589         * elfread.c: Include mdebugread.h.
5590
5591 2019-01-09  Tom Tromey  <tom@tromey.com>
5592
5593         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5594         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5595         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5596         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5597         (psym_lookup_symbol, psym_find_last_source_symtab)
5598         (psym_forget_cached_source_info, psym_print_stats)
5599         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5600         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5601         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5602         (psym_find_compunit_symtab_by_address)
5603         (maintenance_print_psymbols, maintenance_info_psymtabs)
5604         (maintenance_check_psymtabs): Use ranged for.
5605         * psymtab.h (class objfile_psymtabs): New.
5606         (require_partial_symbols): Return objfile_psymtabs.
5607         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5608
5609 2019-01-09  Tom Tromey  <tom@tromey.com>
5610
5611         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5612         (find_pc_mapped_section, list_overlays_command)
5613         (map_overlay_command, unmap_overlay_command)
5614         (simple_overlay_update): Use all_objfiles.
5615         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5616         * printcmd.c (info_symbol_command): Use all_objfiles.
5617         * objfiles.h (ALL_OBJSECTIONS): Remove.
5618         * maint.c (maintenance_translate_address): Use all_objfiles.
5619         * gcore.c (gcore_create_callback): Use all_objfiles.
5620         (objfile_find_memory_regions): Likewise.
5621
5622 2019-01-09  Tom Tromey  <tom@tromey.com>
5623
5624         * symtab.c (find_line_symtab, info_sources_command)
5625         (make_source_files_completion_list): Use objfile_compunits.
5626         * source.c (select_source_symtab): Use objfile_compunits.
5627         * objfiles.h (struct objfile): Update comment.
5628         (ALL_OBJFILES): Remove.
5629         (ALL_FILETABS): Remove.
5630         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5631         objfile_compunits.
5632
5633 2019-01-09  Tom Tromey  <tom@tromey.com>
5634
5635         * symmisc.c (print_objfile_statistics, dump_objfile)
5636         (maintenance_print_symbols): Use compunit_filetabs.
5637         * source.c (forget_cached_source_info_for_objfile): Use
5638         compunit_filetabs.
5639         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5640         (ALL_FILETABS): Use compunit_filetabs.
5641         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5642         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5643
5644 2019-01-09  Tom Tromey  <tom@tromey.com>
5645
5646         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5647         (compunit_filetabs): New.
5648         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5649         compunit_filetabs.
5650         (info_sources_command, make_source_files_completion_list): Remove
5651         declaration.
5652         * symmisc.c (print_objfile_statistics, dump_objfile)
5653         (maintenance_print_symbols): Remove declaration.
5654         (maintenance_info_symtabs): Use compunit_filetabs.
5655         (maintenance_info_line_tables): Likewise.
5656         * source.c (select_source_symtab): Change local variable name.
5657         (forget_cached_source_info_for_objfile): Remove declaration.
5658         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5659         * objfiles.c (objfile_relocate1): Remove declaration.
5660         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5661         declaration.
5662         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5663         * coffread.c (coff_symtab_read): Remove declaration.
5664         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5665         compunit_filetabs.
5666
5667 2019-01-09  Tom Tromey  <tom@tromey.com>
5668
5669         * symtab.c (lookup_objfile_from_block)
5670         (find_pc_sect_compunit_symtab, search_symbols)
5671         (default_collect_symbol_completion_matches_break_on): Use
5672         objfile_compunits.
5673         * objfiles.h (ALL_COMPUNITS): Remove.
5674         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5675         * cp-support.c (add_symbol_overload_list_qualified): Use
5676         objfile_compunits.
5677         * ada-lang.c (ada_collect_symbol_completion_matches)
5678         (ada_add_global_exceptions): Use objfile_compunits.
5679
5680 2019-01-09  Tom Tromey  <tom@tromey.com>
5681
5682         * source.c (select_source_symtab)
5683         (forget_cached_source_info_for_objfile): Remove declaration.
5684         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5685         declaration.
5686         * maint.c (count_symtabs_and_blocks): Remove declaration.
5687         * cp-support.c (add_symbol_overload_list_qualified): Remove
5688         declaration.
5689         * coffread.c (coff_symtab_read): Remove declaration.
5690         * symtab.c (lookup_symbol_in_objfile_symtabs)
5691         (basic_lookup_transparent_type_1): Use objfile_compunits.
5692         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5693         (info_sources_command, search_symbols)
5694         (default_collect_symbol_completion_matches_break_on)
5695         (make_source_files_completion_list): Remove declaration.
5696         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5697         (ada_collect_symbol_completion_matches)
5698         (ada_add_global_exceptions): Remove declaration.
5699         * linespec.c (iterate_over_all_matching_symtabs): Use
5700         objfile_compunits.
5701         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5702         (class objfile_compunits): New.
5703         (ALL_COMPUNITS): Use objfile_compunits.
5704         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5705         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5706         objfile_compunits.
5707         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5708
5709 2019-01-09  Tom Tromey  <tom@tromey.com>
5710
5711         * symtab.c (search_symbols)
5712         (default_collect_symbol_completion_matches_break_on): Use
5713         objfile_msymbols.
5714         * ada-lang.c (ada_lookup_simple_minsym)
5715         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5716         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5717         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5718         objfile_msymbols.
5719         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5720         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5721         * objc-lang.c (find_methods): Use objfile_msymbols.
5722         (info_selectors_command, info_classes_command): Likewise.
5723         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5724         * objfiles.h (class objfile_msymbols): New.
5725         (ALL_OBJFILE_MSYMBOLS): Remove.
5726         (ALL_MSYMBOLS): Remove.
5727
5728 2019-01-09  Tom Tromey  <tom@tromey.com>
5729
5730         * common/next-iterator.h (next_adapter): Add Iterator template
5731         parameter.
5732         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5733         (class all_objfiles_safe): New.
5734         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5735         * objfiles.c (put_objfile_before): Update comment.
5736         (add_separate_debug_objfile): Likewise.
5737         (free_all_objfiles): Use all_objfiles_safe.
5738         (objfile_purge_solibs): Likewise.
5739
5740 2019-01-09  Tom Tromey  <tom@tromey.com>
5741
5742         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5743         (expand_symtab_containing_pc, lookup_static_symbol)
5744         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5745         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5746         all_objfiles.
5747         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5748         * breakpoint.c (create_overlay_event_breakpoint)
5749         (create_longjmp_master_breakpoint)
5750         (create_std_terminate_master_breakpoint)
5751         (create_exception_master_breakpoint): Use all_objfiles.
5752         * linux-thread-db.c (try_thread_db_load_from_pdir)
5753         (has_libpthread): Use all_objfiles.
5754         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5755         * linespec.c (iterate_over_all_matching_symtabs)
5756         (search_minsyms_for_name): Use all_objfiles.
5757         * maint.c (maintenance_info_sections): Use all_objfiles.
5758         * main.c (captured_main_1): Use all_objfiles.
5759         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5760         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5761         * guile/scm-pretty-print.c
5762         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5763         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5764         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5765         (maintenance_print_msymbols): Use all_objfiles.
5766         * source.c (select_source_symtab): Use all_objfiles.
5767         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5768         * symfile.c (remove_symbol_file_command)
5769         (expand_symtabs_matching, map_symbol_filenames): Use
5770         all_objfiles.
5771         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5772         all_objfiles.
5773         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5774         * objc-lang.c (find_methods): Use all_objfiles.
5775         * objfiles.c (have_partial_symbols, have_full_symbols)
5776         (have_minimal_symbols, qsort_cmp)
5777         (default_iterate_over_objfiles_in_search_order): Use
5778         all_objfiles.
5779         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5780         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5781         (maintenance_check_psymtabs): Use all_objfiles.
5782         (ALL_PSYMTABS): Remove.
5783         * compile/compile-object-run.c (do_module_cleanup): Use
5784         all_objfiles.
5785         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5786         * cp-support.c (add_symbol_overload_list_qualified): Use
5787         all_objfiles.
5788         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5789         Use all_objfiles.
5790         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5791         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5792         all_objfiles.
5793         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5794         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5795         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5796         Uses all_objfiles.
5797         * solib.c (solib_read_symbols): Use all_objfiles
5798
5799 2019-01-09  Tom Tromey  <tom@tromey.com>
5800
5801         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5802         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5803         all_objfiles.
5804         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5805         * symmisc.c (print_symbol_bcache_statistics)
5806         (print_objfile_statistics, maintenance_print_objfiles)
5807         (maintenance_info_symtabs, maintenance_check_symtabs)
5808         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5809         all_objfiles.
5810         * source.c (forget_cached_source_info): Use all_objfiles.
5811         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5812         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5813         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5814         * objfiles.c (update_section_map): Use all_objfiles.
5815         (shared_objfile_contains_address_p): Likewise.
5816         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5817         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5818
5819 2019-01-09  Tom Tromey  <tom@tromey.com>
5820
5821         * common/next-iterator.h: New file.
5822         * objfiles.h (class all_objfiles): New.
5823         (struct objfile_iterator): New.
5824
5825 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5826
5827         * NEWS: Move the description of the changed "frame", "select-frame",
5828          and "info frame" commands to the Changed commands section.
5829
5830 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5831
5832         * gdbtypes.c (check_stub_method_group): Remove handling of old
5833         mangling schemes.
5834         * linespec.c (find_methods): Likewise.
5835         * stabsread.c (read_member_functions): Likewise.
5836         * valops.c (search_struct_method): Likewise.
5837         (value_struct_elt_for_reference): Likewise.
5838         * NEWS: Mention this change.
5839
5840 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5841
5842         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5843         print_source_lines.
5844         * source.c (print_source_lines_base): Update line number check.
5845         (print_source_lines): New function.
5846         (source_lines_range::source_lines_range): New function.
5847         * source.h (class source_lines_range): New class.
5848         (print_source_lines): New declaration.
5849
5850 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5851
5852         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5853
5854 2019-01-08  Tom Tromey  <tom@tromey.com>
5855             Simon Marchi  <simon.marchi@ericsson.com>
5856
5857         PR gdb/24060
5858         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5859         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5860         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5861         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5862         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5863         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5864
5865 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5866
5867         * source.c (select_source_symtab): Move header comment to
5868         declaration in source.h.
5869         (forget_cached_source_info_for_objfile): Likewise.
5870         (forget_cached_source_info): Likewise.
5871         (identify_source_line): Likewise.
5872         * source.h (identify_source_line): Move declaration from symtab.h
5873         and add comment from source.c
5874         (print_source_lines): Likewise.
5875         (forget_cached_source_info_for_objfile): Likewise.
5876         (forget_cached_source_info): Likewise.
5877         (select_source_symtab): Likewise.
5878         (enum print_source_lines_flag): Move definition from symtab.h.
5879         * symtab.h (identify_source_line): Move declaration to source.h.
5880         (print_source_lines): Likewise.
5881         (forget_cached_source_info_for_objfile): Likewise.
5882         (forget_cached_source_info): Likewise.
5883         (select_source_symtab): Likewise.
5884         (enum print_source_lines_flag): Move definition to source.h.
5885         * tui/tui-hooks.c: Add 'source.h' include.
5886
5887 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5888
5889         * source.c (print_source_lines_base): Handle requests to print
5890         reverse line number sequences, and guard against empty lines
5891         string.
5892
5893 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5894
5895         * source.c (print_source_lines_base): Fix skip of '\r' if next
5896         character is '\n'.
5897
5898 2019-01-06  Tom Tromey  <tom@tromey.com>
5899
5900         * c-exp.y (struct c_parse_state) <macro_original_text,
5901         expansion_obstack>: New member.
5902         (macro_original_text, expansion_obstack): Remove globals.
5903         (scan_macro_expansion, scanning_macro_expansion)
5904         (finished_macro_expansion): Update.
5905         (scan_macro_cleanup): Remove.
5906         (yylex, c_parse): Update.
5907
5908 2019-01-06  Tom Tromey  <tom@tromey.com>
5909
5910         * c-exp.y (struct c_parse_state) <strings>: New member.
5911         (operator_stoken): Update.
5912
5913 2019-01-06  Tom Tromey  <tom@tromey.com>
5914
5915         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5916         (union type_stack_elt) <typelist_val>: Now a pointer to
5917         std::vector.
5918         (type_stack_cleanup): Don't declare.
5919         (push_typelist): Update.
5920         * parse.c (pop_typelist): Return a std::vector.
5921         (push_typelist): Take a std::vector.
5922         (follow_types): Update.  Do not free args.
5923         (type_stack_cleanup): Remove.
5924         * c-exp.y (struct c_parse_state): New.
5925         (cpstate): New global.
5926         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5927         (nonempty_typelist): Update.
5928         (func_mod): Create a new vector.
5929         (c_parse): Create a c_parse_state.
5930         (check_parameter_typelist): Do not delete params.
5931         (function_method): Update.  Do not delete type_list.
5932
5933 2019-01-06  Tom Tromey  <tom@tromey.com>
5934
5935         PR gdb/28155:
5936         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5937         check_typedef.
5938         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5939         (print_return_value): Likewise.
5940
5941 2019-01-05  Tom Tromey  <tom@tromey.com>
5942
5943         * contrib/cleanup_check.py: Remove.
5944         * contrib/gcc-with-excheck: Remove.
5945         * contrib/exsummary.py: Remove.
5946         * contrib/excheck.py: Remove.
5947
5948 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5949
5950         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5951         NULL. Initialize tpprev to NULL instead of assigning it
5952         to NULL on the next statement.
5953         * windows-nat.c (windows_delete_thread): Remove check for
5954         main_thread_id before printing thread exit notifications.
5955         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5956         Remove thread ID check against main_thread_id.
5957         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5958         windows_delete_thread.
5959         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5960
5961 2019-01-04  Tom Tromey  <tom@tromey.com>
5962
5963         * compile/compile.c (_initialize_compile): Use upper case for
5964         metasyntactic variables.
5965         * symmisc.c (_initialize_symmisc): Use upper case for
5966         metasyntactic variables.
5967         * psymtab.c (_initialize_psymtab): Use upper case for
5968         metasyntactic variables.
5969         * demangle.c (demangle_command): Use upper case for metasyntactic
5970         variables.
5971         (_initialize_demangler): Likewise.
5972         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5973         variables.
5974
5975 2019-01-03  Tom Tromey  <tom@tromey.com>
5976
5977         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5978
5979 2019-01-03  Tom Tromey  <tom@tromey.com>
5980
5981         * python/py-symtab.c (salpy_str): Update.
5982         (struct salpy_sal_object) <symtab>: Now a PyObject.
5983         (salpy_dealloc): Update.
5984         (del_objfile_sal): Use gdbpy_ref.
5985
5986 2019-01-03  Tom Tromey  <tom@tromey.com>
5987
5988         * python/py-type.c (convert_field): Use new_reference.  Return
5989         gdbpy_ref.
5990         (make_fielditem): Return gdbpy_ref.
5991         (typy_fields): Update.
5992         (typy_getitem): Update.
5993         (field_name): Return gdbpy_ref.  Use new_reference.
5994         (typy_iterator_iternext): Update.
5995
5996 2019-01-03  Tom Tromey  <tom@tromey.com>
5997
5998         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5999
6000 2019-01-03  Tom Tromey  <tom@tromey.com>
6001
6002         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
6003         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
6004         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
6005         (pspy_set_frame_filters, pspy_set_frame_unwinders)
6006         (pspy_set_type_printers): Likewise.
6007         * python/py-function.c (fnpy_init): Use gdbpy_ref.
6008         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
6009         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
6010         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
6011         (objfpy_set_type_printers): Likewise.
6012
6013 2019-01-03  Tom Tromey  <tom@tromey.com>
6014
6015         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
6016         (gdbpy_print_stack): Use gdbpy_err_fetch.
6017         * python/python-internal.h (class gdbpy_err_fetch): New class.
6018         (class gdbpy_enter) <m_error_type, m_error_value,
6019         m_error_traceback>: Remove.
6020         <m_error>: New member.
6021         (gdbpy_exception_to_string): Don't declare.
6022         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
6023         * python/py-value.c (convert_value_from_python): Use
6024         gdbpy_err_fetch.
6025         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
6026         gdbpy_exception_to_string.
6027         (gdbpy_handle_exception): Use gdbpy_err_fetch.
6028         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
6029         gdbpy_err_fetch.
6030
6031 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6032
6033         * linux-nat.c (delete_lwp_cleanup): Delete.
6034         (struct lwp_deleter): New struct.
6035         (lwp_info_up): New typedef.
6036         (linux_nat_target::follow_fork): Delete cleanup, and make use of
6037         lwp_info_up.
6038
6039 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6040
6041         * linux-fork.c (class scoped_switch_fork_info): New class.
6042         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
6043
6044 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * valops.c (find_overload_match): Remove use of null_cleanup, and
6047         calls to do_cleanups.
6048
6049 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6050
6051         * compile/compile-cplus-types.c
6052         (compile_cplus_instance::decl_name): Handle changes to
6053         cp_func_name.
6054         * cp-support.c (cp_func_name): Update header comment, update
6055         return type.
6056         * cp-support.h (cp_func_name): Update return type in declaration.
6057         * valops.c (find_overload_match): Move temp_func local to top
6058         level of function and change its type.  Use temp_func to hold and
6059         delete temporary string obtained from cp_func_name.
6060
6061 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
6062
6063         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
6064         gdb::char_vector, remove cleanup, and update uses of `msg`.
6065
6066 2019-01-03  Jim Wilson  <jimw@sifive.com>
6067
6068         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
6069
6070 2019-01-02  Tom Tromey  <tom@tromey.com>
6071
6072         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
6073         (tdesc_parse_xml): Remove cleanups.
6074         * target-descriptions.h (make_cleanup_free_target_description):
6075         Don't declare.
6076         (target_desc_deleter): New struct.
6077         (target_desc_up): New typedef.
6078         * target-descriptions.c (target_desc_deleter::operator()): Rename
6079         from free_target_description.
6080         (make_cleanup_free_target_description): Remove.
6081
6082 2019-01-02  Tom Tromey  <tom@tromey.com>
6083
6084         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
6085         constructor, destructor.
6086         (linespec_parser): Remove typedef.
6087         (~linespec_parser): Rename from linespec_parser_delete.
6088         (linespec_lex_to_end, linespec_complete_label)
6089         (linespec_complete): Update.
6090         (decode_line_full): Remove cleanups.
6091         (decode_line_1): Update.
6092
6093 2019-01-02  Tom Tromey  <tom@tromey.com>
6094
6095         * python/python-internal.h (inferior_to_inferior_object): Change
6096         return type.
6097         * python/py-exitedevent.c (create_exited_event_object): Update.
6098         * python/py-inferior.c (inferior_to_inferior_object): Return
6099         gdbpy_ref.
6100         (python_new_inferior, python_inferior_deleted)
6101         (thread_to_thread_object, delete_thread_object)
6102         (build_inferior_list, gdbpy_selected_inferior): Update.
6103         * python/py-infthread.c (create_thread_object): Update.  Also fail
6104         if inferior_to_inferior_object fails.
6105
6106 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
6107
6108         * inferior.h (class inferior) <displaced_step_state>: New field.
6109         * infrun.h (struct displaced_step_state): Move here from
6110         infrun.c.  Initialize fields, add constructor.
6111         <inf>: Remove field.
6112         <reset>: New method.
6113         * infrun.c (struct displaced_step_inferior_state): Move to
6114         infrun.h.
6115         (displaced_step_inferior_states): Remove.
6116         (get_displaced_stepping_state): Adust.
6117         (displaced_step_in_progress_any_inferior): Adjust.
6118         (displaced_step_in_progress_thread): Adjust.
6119         (displaced_step_in_progress): Adjust.
6120         (add_displaced_stepping_state): Remove.
6121         (get_displaced_step_closure_by_addr): Adjust.
6122         (remove_displaced_stepping_state): Remove.
6123         (infrun_inferior_exit): Call displaced_step_state.reset.
6124         (use_displaced_stepping): Don't check for NULL.
6125         (displaced_step_prepare_throw): Call
6126         get_displaced_stepping_state.
6127         (displaced_step_fixup): Don't check for NULL.
6128         (prepare_for_detach): Don't check for NULL.
6129
6130 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6131
6132         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
6133          in case of call that did not complete.
6134
6135 2019-01-02  Andrey Utkin  <autkin@undo.io>
6136
6137         * symfile.c (find_separate_debug_file): Fix search of debug files for
6138         remote debuggee.
6139
6140 2019-01-02  Tom Tromey  <tom@tromey.com>
6141
6142         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
6143         indentation.
6144         * python/py-frame.c (frapy_older): Remove cast.
6145         (frapy_newer): Likewise.
6146         * python/py-breakpoint.c (local_setattro): Remove cast.
6147         * python/py-arch.c (archpy_name): Remove local variable.
6148         * python/py-type.c (gdbpy_lookup_type): Remove cast.
6149
6150 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
6151
6152         * unittests/basic_string_view/element_access/char/empty.cc:
6153         Fix year range in copyright header.
6154
6155 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
6156
6157         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
6158         Delete.
6159         <operator==>: Update with for removed field.
6160         <hash>: Likewise.
6161         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
6162         <isa_features>: ...this.
6163         <abi_features>: New field.
6164         (riscv_isa_flen): Update comment.
6165         (riscv_abi_xlen): New declaration.
6166         (riscv_abi_flen): New declaration.
6167         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
6168         isa_features.
6169         (riscv_abi_xlen): New function.
6170         (riscv_isa_flen): Update to get answer from isa_features.
6171         (riscv_abi_flen): New function.
6172         (riscv_has_fp_abi): Update to get answer from abi_features.
6173         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
6174         xlen and flen.
6175         (riscv_call_info) <xlen, flen>: Update comment.
6176         (riscv_call_arg_struct): Remove invalid assertions
6177         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
6178         is removed.
6179         (riscv_gdbarch_init): Gather isa features and abi features
6180         separately, ensure both match on the gdbarch when reusing an old
6181         gdbarch.  Relax an error check to allow 32-bit abi float to run on
6182         a target with 64-bit float hardware.
6183
6184 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6185
6186         * source.c (search_command_helper): Stop reverse search
6187         when line 1 has been searched.
6188
6189 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6190
6191         * record-full.c (record_full_base_target::close): Rewrite
6192         record_full_core_buf_list free logic.
6193
6194 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6195
6196         * break-catch-syscall.c (print_one_catch_syscall): xfree
6197         the last text.
6198
6199 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6200
6201         * top.c (print_gdb_version): Update Copyright year in version
6202         message.
6203
6204 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
6205
6206         Update copyright year range in all GDB files.
6207
6208 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
6209
6210         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
6211
6212 For older changes see ChangeLog-2018.
6213 \f
6214 Local Variables:
6215 mode: change-log
6216 left-margin: 8
6217 fill-column: 74
6218 version-control: never
6219 coding: utf-8
6220 End:
6221