gdb/ChangeLog

   1 2019-07-17  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-wingeneral.c
   4         (tui_check_and_display_highlight_if_needed): Check can_highlight.
   5
   6 2019-07-17  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
   9         (struct tui_cmd_window) <can_scroll>: New method.
  10         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
  11         method.
  12
  13 2019-07-17  Tom Tromey  <tromey@adacore.com>
  14
  15         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
  16         do_field_signed>: Rename.  Change type of "value".
  17         * ui-out.c (ui_out::field_signed): Rename from field_int.
  18         Change type of "value".
  19         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
  20         type of "value".
  21         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
  22         do_field_int.  Change type of "value".
  23         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
  24         do_field_int.  Change type of "value".
  25         * tracepoint.c (trace_status_mi, tfind_1)
  26         (print_one_static_tracepoint_marker): Update.
  27         * thread.c (print_thread_info_1, print_selected_thread_frame):
  28         Update.
  29         * stack.c (print_frame, print_frame_info): Update.
  30         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
  31         Update.
  32         * source.c (print_source_lines_base): Update.
  33         * skip.c (info_skip_command): Update.
  34         * record-btrace.c (btrace_ui_out_decode_error)
  35         (btrace_call_history_src_line): Update.
  36         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
  37         Update.
  38         * progspace.c (print_program_space): Update.
  39         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
  40         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
  41         do_field_int.  Change type of "value".
  42         * mi/mi-out.c (mi_ui_out::do_table_begin)
  43         (mi_ui_out::do_table_header): Update.
  44         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
  45         type of "value".
  46         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
  47         (mi_cmd_data_list_changed_registers, output_register)
  48         (mi_cmd_data_read_memory, mi_load_progress)
  49         (mi_cmd_trace_frame_collected): Update.
  50         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
  51         Update.
  52         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
  53         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
  54         (mi_cmd_var_list_children, varobj_update_one): Update.
  55         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
  56         (mi_cmd_stack_list_args, list_arg_or_local): Update.
  57         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
  58         * inferior.c (print_inferior): Update.
  59         * gdb_bfd.c (print_one_bfd): Update.
  60         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
  61         Update.
  62         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
  63         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
  64         do_field_int.  Change type of "value".
  65         * cli-out.c (cli_ui_out::do_field_signed): Rename from
  66         do_field_int.  Change type of "value".
  67         * breakpoint.c (watchpoint_check, print_breakpoint_location)
  68         (print_one_breakpoint_location, print_it_catch_fork)
  69         (print_one_catch_fork, print_it_catch_vfork)
  70         (print_one_catch_vfork, print_it_catch_solib)
  71         (print_it_catch_exec, print_it_ranged_breakpoint)
  72         (print_mention_watchpoint, print_mention_masked_watchpoint)
  73         (bkpt_print_it, update_static_tracepoint): Update.
  74         * break-catch-throw.c (print_it_exception_catchpoint): Update.
  75         * break-catch-syscall.c (print_it_catch_syscall): Update.
  76         * ada-tasks.c (print_ada_task_info): Update.
  77         * ada-lang.c (print_it_exception, print_mention_exception):
  78         Update.
  79
  80 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
  81
  82         PR breakpoints/24541
  83         * gdbarch.c: Regenerate.
  84         * gdbarch.h: Regenerate.
  85         * gdbarch.sh: Adjust return type and parameter types for
  86         'stap_adjust_register'.
  87         (i386_stap_adjust_register): Adjust signature and return new
  88         register name.
  89         * stap-probe.c (stap_parse_register_operand): Adjust use of
  90         'gdbarch_stap_adjust_register'.
  91
  92 2019-07-17  Tom Tromey  <tromey@adacore.com>
  93
  94         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
  95         declare VEC.
  96         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
  97         std::vector.
  98         (struct s390_process_info): Add initializers.
  99         (s390_add_process): Use new.
 100         (s390_linux_nat_target::low_forget_process): Use delete.
 101         (s390_linux_nat_target::low_new_fork)
 102         (s390_linux_nat_target::stopped_by_watchpoint)
 103         (s390_linux_nat_target::low_prepare_to_resume)
 104         (s390_linux_nat_target::insert_watchpoint)
 105         (s390_linux_nat_target::insert_hw_breakpoint)
 106         (s390_linux_nat_target::remove_watchpoint)
 107         (s390_linux_nat_target::remove_hw_breakpoint): Update.
 108
 109 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 110
 111         * aarch64-fbsd-nat.c: Include regcache.h.
 112         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
 113         argument.
 114         (aarch64_fbsd_nat_target::fetch_registers)
 115         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
 116         variable.
 117         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
 118
 119 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
 120
 121         * fbsd-nat.c: Include gdbarch.h.
 122
 123 2019-07-15  Tom Tromey  <tromey@adacore.com>
 124
 125         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
 126
 127 2019-07-15  Tom Tromey  <tromey@adacore.com>
 128
 129         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
 130         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
 131         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
 132         * cli-out.c (cli_ui_out::do_field_int): New method.
 133         * ui-out.c (ui_out::field_unsigned): New method.
 134         * symfile.c (generic_load): Use field_unsigned.
 135         (print_transfer_performance): Likewise.
 136         * record-btrace.c (ui_out_field_uint): Remove.
 137         (btrace_call_history_insn_range, btrace_call_history): Use
 138         field_unsigned.
 139         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
 140         field_unsigned.
 141         * ui-out.h (class ui_out) <field_unsigned>: New method.
 142         <do_field_unsigned>: Likewise.
 143
 144 2019-07-15  Tom Tromey  <tromey@adacore.com>
 145
 146         * mi/mi-main.c (list_available_thread_groups): Use field_string.
 147         * mi/mi-interp.c (mi_memory_changed): Use field_string.
 148         * target.c (flash_erase_command): Use field_string.
 149         * infrun.c (print_signal_received_reason): Use field_string.
 150         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
 151         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
 152         field_string.
 153         * ada-tasks.c (print_ada_task_info): Use field_string.
 154
 155 2019-07-15  Tom Tromey  <tromey@adacore.com>
 156
 157         * target.c (flash_erase_command): Use field_core_addr.
 158         * symfile.c (generic_load): Use field_core_addr.
 159         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
 160         Use field_core_addr.
 161         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
 162         field_core_addr.
 163
 164 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 165
 166         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
 167         value if its desired type is smaller than a CORE_ADDR and signed.
 168
 169 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 170
 171         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
 172         of changes to field names, and use new is_reference field to
 173         decide if a property is a reference or not.
 174         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
 175         field.
 176         (struct dwarf2_property_baton): Update header comment, rename
 177         'referenced_type' to 'property_type' and update comments.
 178         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
 179         default property type, store in property baton, update to take
 180         accound of renamed field.
 181         (read_func_scope): Update call to attr_to_dynamic_prop.
 182         (read_array_type): Likewise.
 183         (dwarf2_per_cu_addr_sized_int_type): New function.
 184         (read_subrange_index_type): Move type finding code to
 185         dwarf2_per_cu_addr_sized_int_type.
 186         (read_subrange_type): Update calls to attr_to_dynamic_prop.
 187         (dwarf2_per_cu_addr_type): New function.
 188         (set_die_type): Update calls to attr_to_dynamic_prop.
 189
 190 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 191
 192         * dwarf2read.c (read_subrange_index_type): New function.
 193         (read_subrange_type): Move code into new function and call it.
 194         * gdbtypes.c (create_range_type): Add some asserts.
 195
 196 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 197
 198         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
 199         update return statements.
 200         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
 201         declaration, and update comment to match.
 202         * gdbtypes.c (resolve_dynamic_array): Update call to
 203         dwarf2_evaluate_property to match new return type.
 204
 205 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 206
 207         * valarith.c (value_subscripted_rvalue): Change lowerbound
 208         parameter type from int to LONGEST.
 209         * value.h (value_subscripted_rvalue): Likewise in declaration.
 210
 211 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 212
 213         * cli/cli-utils.c (info_print_command_completer): New function.
 214         * cli/cli-utils.h: Add 'completer.h' include, and forward
 215         declaration for 'struct cmd_list_element'.
 216         (info_print_command_completer): Declare.
 217         * stack.c (_initialize_stack): Add completer for 'info locals' and
 218         'info args'.
 219         * symtab.c (_initialize_symtab): Add completer for 'info
 220         variables' and 'info functions'.
 221         * NEWS: Mention completion for additional info commands.
 222
 223 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 224
 225         * cli/cli-utils.c (extract_info_print_args): Delete.
 226         (extract_arg_maybe_quoted): Delete.
 227         (info_print_options_defs): New variable.
 228         (make_info_print_options_def_group): New function.
 229         (extract_info_print_options): Define new function.
 230         * cli/cli-utils.h (extract_info_print_args): Delete.
 231         (struct info_print_options): New structure.
 232         (extract_info_print_options): Declare new function.
 233         * stack.c (info_locals_command): Update to use new
 234         extract_info_print_options, also add a header comment.
 235         (info_args_command): Likewise.
 236         * symtab.c (info_variables_command): Likewise.
 237         (info_functions_command): Likewise.
 238
 239 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 240
 241         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
 242         to extract string arguments.
 243         * common/common-utils.c (extract_string_maybe_quoted): New function.
 244         * common/common-utils.h (extract_string_maybe_quoted): Declare.
 245
 246 2019-07-11  Tom Tromey  <tromey@adacore.com>
 247
 248         * main.c (get_init_files): Use GDBINIT, not gdbinit.
 249         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
 250         * top.h (gdbinit): Don't declare.
 251         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
 252         into...
 253         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
 254         * top.c (gdb_init): Don't call init_cli_cmds.
 255         (gdbinit): Remove.
 256         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
 257
 258 2019-07-11  Tom Tromey  <tromey@adacore.com>
 259
 260         * python/py-inferior.c (add_thread_object): Don't use thread_obj
 261         after it has been moved.
 262
 263 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 264
 265         * valops.c (value_must_coerce_to_target): Change return type to
 266         bool.
 267         * value.h (value_must_coerce_to_target): Likewise.
 268
 269 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
 270
 271         * breakpoint.c (is_hardware_watchpoint): Remove
 272         forward-declaration.
 273         (is_masked_watchpoint): Change return type to bool.
 274         (is_tracepoint): Likewise.
 275         (is_breakpoint): Likewise.
 276         (is_hardware_watchpoint): Likewise.
 277         (is_watchpoint): Likewise.
 278         (is_no_memory_software_watchpoint): Likewise.
 279         (is_catchpoint): Likewise.
 280         (breakpoint_1): Make FILTER parameter's return type bool.
 281         is_masked_watchpoint): Change return type to bool.
 282         (save_breakpoints): Make FILTER parameter's return type bool.
 283         * breakpoint.h (is_breakpoint): Change return type to bool.
 284         (is_watchpoint): Likewise.
 285         (is_catchpoint): Likewise.
 286         (is_tracepoint): Likewise.
 287
 288 2019-07-10  Tom Tromey  <tom@tromey.com>
 289
 290         * defs.h: Don't include gdbarch.h.
 291         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
 292         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
 293         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
 294         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
 295         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
 296         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
 297         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
 298         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
 299         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
 300         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
 301         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
 302         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
 303         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
 304         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
 305         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
 306         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
 307         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
 308         record-btrace.c, record.h, regcache-dump.c, regcache.h,
 309         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
 310         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
 311         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
 312         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
 313         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
 314         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
 315         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
 316         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
 317         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
 318
 319 2019-07-10  Tom Tromey  <tromey@adacore.com>
 320
 321         * ada-lang.h (is_ada_exception_catchpoint): Declare.
 322         * breakpoint.c (init_ada_exception_breakpoint): Register as
 323         bp_catchpoint.
 324         (print_one_breakpoint_location, print_one_breakpoint): Use
 325         is_ada_exception_catchpoint.
 326         * ada-lang.c (class ada_catchpoint_location): Pass
 327         bp_loc_software_breakpoint to bp_location constructor.
 328         (is_ada_exception_catchpoint): New function.
 329
 330 2019-07-10  Tom Tromey  <tromey@adacore.com>
 331
 332         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
 333         VEC.
 334         (struct arm_exidx_entry): New method operator<.
 335         (struct arm_exidx_data) <section_maps>: Change type.
 336         (arm_exidx_data_free): Remove.
 337         (arm_exidx_data_key): Change type.  Move lower.
 338         (arm_exidx_new_objfile): Update.
 339         (arm_compare_exidx_entries): Remove.
 340         (arm_find_exidx_entry, _initialize_arm_tdep)
 341
 342 2019-07-10  Tom Tromey  <tromey@adacore.com>
 343
 344         * solib-spu.c (ocl_program_data_key): Change type.
 345         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
 346         Update.
 347
 348 2019-07-10  Tom Tromey  <tromey@adacore.com>
 349
 350         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
 351         (struct solib_aix_inferior_data) <library_list>: Change type.
 352         (solib_aix_inferior_data_handle): Change type.
 353         (get_solib_aix_inferior_data): Update.
 354         (solib_aix_free_library_list): Remove.
 355         (library_list_start_library): Update.
 356         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
 357         return type.
 358         (solib_aix_get_library_list)
 359         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
 360         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
 361
 362 2019-07-10  Tom Tromey  <tromey@adacore.com>
 363
 364         * solib-dsbt.c (struct dsbt_info): Add initializers.
 365         (solib_dsbt_pspace_data): Change type.
 366         (dsbt_pspace_data_cleanup): Remove.
 367         (get_dsbt_info, _initialize_dsbt_solib): Update.
 368
 369 2019-07-10  Tom Tromey  <tromey@adacore.com>
 370
 371         * spu-tdep.c (spu_overlay_data): Change type.
 372         (spu_get_overlay_table, spu_overlay_new_objfile)
 373         (_initialize_spu_tdep): Update.
 374
 375 2019-07-10  Tom Tromey  <tromey@adacore.com>
 376
 377         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
 378         destructor.
 379         (dbx_objfile_data_key): Change type and declare later.
 380         (DBX_SYMFILE_INFO): Rewrite.
 381         * dbxread.c (dbx_objfile_data_key): Change type.
 382         (dbx_symfile_init): Update.
 383         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
 384         (coffstab_build_psymtabs, elfstab_build_psymtabs)
 385         (stabsect_build_psymtabs, _initialize_dbxread): Update.
 386
 387 2019-07-10  Tom Tromey  <tromey@adacore.com>
 388
 389         * jit.c (jit_program_space_key): Change type.  Move lower.
 390         (get_jit_program_space_data): Update.
 391         (jit_program_space_data_cleanup): Remove.
 392         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
 393         Update.
 394         (struct jit_program_space_data): Add initializers.
 395
 396 2019-07-10  Tom Tromey  <tromey@adacore.com>
 397
 398         * solib-darwin.c (struct darwin_info): Add initializers.
 399         (solib_darwin_pspace_data): Change type.
 400         (darwin_pspace_data_cleanup): Remove.
 401         (get_darwin_info, _initialize_darwin_solib): Update.
 402
 403 2019-07-10  Tom Tromey  <tromey@adacore.com>
 404
 405         * remote-sim.c (struct sim_inferior_data): Add initializers,
 406         constructor, and destructor.
 407         (sim_inferior_data_key): Change type.  Move lower.
 408         (check_for_duplicate_sim_descriptor): Update.
 409         (get_sim_inferior_data): Use new.  Update.
 410         (~sim_inferior_data_cleanup): Rename from
 411         sim_inferior_data_cleanup.  Simplify.
 412         (gdbsim_close_inferior, simulator_command)
 413         (sim_command_completer, _initialize_remote_sim): Update.
 414         (next_pid, INITIAL_PID): Move earlier.
 415
 416 2019-07-10  Tom Tromey  <tromey@adacore.com>
 417
 418         * python/python-internal.h (create_thread_object): Return
 419         gdbpy_ref.
 420         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
 421         * python/py-inferior.c (struct threadlist_entry): Add
 422         constructor.
 423         <thread_obj>: Now a gdbpy_ref.
 424         (thread_to_thread_object): Update.
 425         (add_thread_object): Use new.
 426         (delete_thread_object): Use delete.
 427         (infpy_threads): Update.
 428         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
 429         GIL.
 430
 431 2019-07-10  Tom Tromey  <tromey@adacore.com>
 432
 433         * valops.c (value_cast): Specialize error message for Ada.
 434
 435 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 436
 437         * breakpoint.c (breakpoint_1): Update doc and parameter names.
 438
 439 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
 440
 441         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
 442         bpstat_should_step): Return bool, adjust comments.
 443         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
 444         bpstat_should_step): Likewise.
 445
 446 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 447
 448         * features/Makefile: Use feature target descriptions for Arm.
 449         * features/arm/arm-core.c: Generate new file.
 450         * features/arm/arm-fpa.c: Likewise.
 451         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
 452         * features/arm/arm-m-profile.c: Likewise.
 453         * features/arm/arm-vfpv2.c: Likewise.
 454         * features/arm/arm-vfpv3.c: Likewise.
 455         * features/arm/xscale-iwmmxt.c: Likewise.
 456         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
 457
 458 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 459
 460         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
 461         ptrace earlier.
 462
 463 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
 464
 465         * features/aarch64-pauth.c: Regenerate.
 466
 467 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
 468
 469         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
 470         bool.
 471         (bpstat_what): Use false instead of 0.
 472
 473 2019-07-09  Pedro Alves  <palves@redhat.com>
 474
 475         * break-catch-throw.c (is_exception_catchpoint): New.
 476         * breakpoint.c (print_one_breakpoint_location): New parameter
 477         'raw_loc'.  Handle it.  Use
 478         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
 479         looking at the breakpoint's type.
 480         (print_one_breakpoint): If handling "maint info breakpoints", also
 481         print locations of exception catchpoints.
 482         * breakpoint.h (is_exception_catchpoint): Declare.
 483
 484 2019-07-09  Pedro Alves  <palves@redhat.com>
 485
 486         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
 487         "addr" field.
 488         (allocate_location_exception_catchpoint): New.
 489         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
 490         (initialize_throw_catchpoint_ops): Install
 491         allocate_location_exception_catchpoint as allocate_location
 492         method.
 493         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
 494         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
 495         bp_loc_other.
 496         (breakpoint_address_is_meaningful): Delete.
 497         (bl_address_is_meaningful): New.
 498         (breakpoint_locations_match): Adjust comment.
 499         (bp_location_from_bp_type): New, factored out of...
 500         (bp_location::bp_location(breakpoint *)): ... this.
 501         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
 502         factored out of...
 503         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
 504         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
 505         breakpoint_address_is_meaningful.
 506         (bp_locations_compare): Adjust comment.
 507         (update_global_location_list): Use bl_address_is_meaningful
 508         instead of breakpoint_address_is_meaningful.
 509         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
 510         explicit.
 511         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
 512         * python/py-breakpoint.c (bppy_get_location): No longer check
 513         whether location is null.
 514
 515 2019-07-09  Pedro Alves  <palves@redhat.com>
 516
 517         PR c++/15468
 518         * breakpoint.c (print_one_breakpoint_location): Remove
 519         single-location assert.
 520
 521 2019-07-09  Tom Tromey  <tom@tromey.com>
 522
 523         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
 524         * configure: Rebuild.
 525         * configure.ac: Change common to gdbsupport.
 526         * gdbsupport: Rename from common.
 527         * acinclude.m4: Change common to gdbsupport.
 528         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
 529         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
 530         gdbsupport.
 531         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
 532         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
 533         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
 534         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
 535         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
 536         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
 537         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
 538         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
 539         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
 540         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
 541         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
 542         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
 543         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
 544         coff-pe-read.c, command.h, compile/compile-c-support.c,
 545         compile/compile-c.h, compile/compile-cplus-symbols.c,
 546         compile/compile-cplus-types.c, compile/compile-cplus.h,
 547         compile/compile-loc2c.c, compile/compile.c, completer.c,
 548         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
 549         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
 550         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
 551         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
 552         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
 553         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
 554         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
 555         features/aarch64-core.c, features/aarch64-fpu.c,
 556         features/aarch64-pauth.c, features/aarch64-sve.c,
 557         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
 558         features/i386/32bit-core.c, features/i386/32bit-linux.c,
 559         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
 560         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
 561         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
 562         features/i386/64bit-core.c, features/i386/64bit-linux.c,
 563         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
 564         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
 565         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
 566         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
 567         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
 568         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
 569         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
 570         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
 571         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
 572         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
 573         go32-nat.c, guile/guile.c, guile/scm-ports.c,
 574         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
 575         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
 576         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
 577         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
 578         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
 579         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
 580         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
 581         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
 582         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
 583         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
 584         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
 585         minsyms.c, mips-linux-tdep.c, namespace.h,
 586         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
 587         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
 588         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
 589         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
 590         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
 591         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
 592         nat/linux-waitpid.c, nat/mips-linux-watch.c,
 593         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
 594         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
 595         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
 596         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
 597         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
 598         procfs.c, producer.c, progspace.h, psymtab.h,
 599         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
 600         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
 601         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
 602         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
 603         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
 604         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
 605         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
 606         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
 607         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
 608         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
 609         target-memory.c, target.c, target.h, target/waitstatus.c,
 610         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
 611         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
 612         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
 613         unittests/array-view-selftests.c,
 614         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
 615         unittests/common-utils-selftests.c,
 616         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
 617         unittests/format_pieces-selftests.c,
 618         unittests/function-view-selftests.c,
 619         unittests/lookup_name_info-selftests.c,
 620         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
 621         unittests/mkdir-recursive-selftests.c,
 622         unittests/observable-selftests.c,
 623         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
 624         unittests/parse-connection-spec-selftests.c,
 625         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
 626         unittests/scoped_fd-selftests.c,
 627         unittests/scoped_mmap-selftests.c,
 628         unittests/scoped_restore-selftests.c,
 629         unittests/string_view-selftests.c, unittests/style-selftests.c,
 630         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
 631         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
 632         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
 633         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
 634         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
 635         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
 636
 637 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 638
 639         * linespec.c (decode_digits_list_mode): Set explicit_line to a
 640         bool value.
 641         (decode_digits_ordinary): Set explicit_line field in sal.
 642         * symtab.c (skip_prologue_sal): Don't skip prologue for a
 643         symtab_and_line that was set on an explicit line number in
 644         assembler code.  Do always update the recorded symtab and line if
 645         we do skip the prologue.
 646
 647 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 648
 649         * breakpoint.c (set_breakpoint_location_function): Remove
 650         explicit_loc parameter.
 651         (momentary_breakpoint_from_master): Update call to
 652         set_breakpoint_location_function.
 653         (add_location_to_breakpoint): Likewise.
 654
 655 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
 656
 657         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
 658         required features based on default bfd type when no specific bfd
 659         is present.
 660
 661 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 662
 663         * NEWS: Mention that GDB printf and eval commands can now print
 664         C-style and Ada-style convenience var strings without
 665         calling the inferior.
 666         * printcmd.c (printf_c_string): Locally print GDB internal var
 667         instead of transiting via the inferior.
 668         (printf_wide_c_string): Likewise.
 669
 670 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 671
 672         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
 673
 674 2019-07-04  Tom Tromey  <tom@tromey.com>
 675
 676         PR tui/24724:
 677         * tui/tui-winsource.c (tui_clear_source_content): Update.
 678         (tui_source_window_base::set_is_exec_point_at): Fix comment.
 679         (tui_update_breakpoint_info): Update.
 680         (tui_set_exec_info_content): Update.
 681         * tui/tui-source.c (tui_set_source_content_nil): Update.
 682         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
 683         has_break.
 684         * tui/tui-data.h (enum tui_bp_flag): New.
 685         (tui_bp_flags): New enum flags type.
 686         (struct tui_source_element) <break_mode>: Change type.  Rename
 687         from has_break.
 688         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
 689         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
 690         constants.
 691         * tui/tui-winsource.h: Fix comment.
 692
 693 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 694
 695         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
 696         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
 697         (store_fpregs_to_thread)
 698         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 699         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
 700         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
 701         (IWMMXT_REGS_SIZE): Add define.
 702         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
 703         (fetch_vfp_regs, store_vfp_regs)
 704         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
 705         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
 706
 707 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 708
 709         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
 710         defines.
 711         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
 712         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
 713         (ARM_INT_REGISTER_SIZE): ...to this.
 714         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
 715         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
 716         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
 717         (arm_linux_collect_gregset, supply_nwfpe_register)
 718         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
 719         defines.
 720         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
 721         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
 722         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
 723         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
 724         (arm_return_in_memory, arm_store_return_value)
 725         (arm_get_longjmp_target, arm_register_g_packet_guesses)
 726         (arm_record_ld_st_multiple): Likewise.
 727         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
 728         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
 729
 730 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 731
 732         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
 733         AARCH64_DISPLACED_MODIFIED_INSNS.
 734         * aarch64-tdep.c (struct aarch64_displaced_step_data)
 735         (aarch64_displaced_step_copy_insn): Likewise.
 736         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 737         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
 738         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
 739         ARM_DISPLACED_MODIFIED_INSNS.
 740         * arm-tdep.c (arm_gdbarch_init): Likewise.
 741         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
 742         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
 743         (struct arm_displaced_step_closure): Use
 744         ARM_DISPLACED_MODIFIED_INSNS.
 745
 746 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 747
 748         * features/Makefile: Remove unused xml files.
 749         * features/aarch64.xml: Remove.
 750         * features/i386/amd64-avx-avx512-linux.xml: Remove.
 751         * features/i386/amd64-avx-avx512.xml: Remove.
 752         * features/i386/amd64-avx-linux.xml: Remove.
 753         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
 754         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
 755         * features/i386/amd64-avx-mpx-linux.xml: Remove.
 756         * features/i386/amd64-avx-mpx.xml: Remove.
 757         * features/i386/amd64-avx.xml: Remove.
 758         * features/i386/amd64-linux.xml: Remove.
 759         * features/i386/amd64-mpx-linux.xml: Remove.
 760         * features/i386/amd64-mpx.xml: Remove.
 761         * features/i386/amd64.xml: Remove.
 762         * features/i386/i386-avx-avx512-linux.xml: Remove.
 763         * features/i386/i386-avx-avx512.xml: Remove.
 764         * features/i386/i386-avx-linux.xml: Remove.
 765         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
 766         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
 767         * features/i386/i386-avx-mpx-linux.xml: Remove.
 768         * features/i386/i386-avx-mpx.xml: Remove.
 769         * features/i386/i386-avx.xml: Remove.
 770         * features/i386/i386-linux.xml: Remove.
 771         * features/i386/i386-mmx-linux.xml: Remove.
 772         * features/i386/i386-mmx.xml: Remove.
 773         * features/i386/i386-mpx-linux.xml: Remove.
 774         * features/i386/i386-mpx.xml: Remove.
 775         * features/i386/i386.xml: Remove.
 776         * features/i386/x32-avx-avx512-linux.xml: Remove.
 777         * features/i386/x32-avx-linux.xml: Remove.
 778         * features/i386/x32-linux.xml: Remove.
 779
 780 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 781
 782         * regformats/aarch64.dat: Remove.
 783         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
 784         * regformats/i386/amd64-avx-linux.dat: Remove.
 785         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
 786         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
 787         * regformats/i386/amd64-linux.dat: Remove.
 788         * regformats/i386/amd64-mpx-linux.dat: Remove.
 789         * regformats/i386/amd64.dat: Remove.
 790         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
 791         * regformats/i386/i386-avx-linux.dat: Remove.
 792         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
 793         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
 794         * regformats/i386/i386-linux.dat: Remove.
 795         * regformats/i386/i386-mmx-linux.dat: Remove.
 796         * regformats/i386/i386-mpx-linux.dat: Remove.
 797         * regformats/i386/i386.dat: Remove.
 798         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
 799         * regformats/i386/x32-avx-linux.dat: Remove.
 800         * regformats/i386/x32-linux.dat: Remove.
 801
 802 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
 803
 804         * aarch64-tdep.c: Remove xml self tests.
 805         * amd64-linux-tdep.c: Likewise.
 806         * amd64-tdep.c: Likewise.
 807         * i386-linux-tdep.c: Likewise.
 808         * i386-tdep.c: Likewise.
 809
 810 2019-07-03  Pedro Alves  <palves@redhat.com>
 811
 812         PR cli/24732
 813         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
 814         (pipe_cmd_option_defs): New.
 815         (make_pipe_cmd_options_def_group): New.
 816         (pipe_command): Use gdb::option::process_options.
 817         (pipe_command_completer): New function.
 818         (_initialize_cli_cmds): Install completer for "pipe" command.
 819
 820 2019-07-03  Pedro Alves  <palves@redhat.com>
 821
 822         * cli/cli-option.c (union option_value) <string>: New field.
 823         (struct option_def_and_value): Add ctor, move ctor, dtor and
 824         use DISABLE_COPY_AND_ASSIGN.
 825         (option_def_and_value::clear_value): New.
 826         (parse_option, save_option_value_in_ctx, get_val_type_str)
 827         (add_setshow_cmds_for_options): Handle var_string.
 828         * cli-option.h (union option_def::var_address) <string>: New
 829         field.
 830         (struct string_option_def): New.
 831         * maint-test-options.c (struct test_options_opts): Add default
 832         ctor and use DISABLE_COPY_AND_ASSIGN.
 833         <string_opt>: New field.
 834         (test_options_opts::~test_options_opts): New.
 835         (test_options_opts::dump): Also dump "-string".
 836         (test_options_option_defs): Install "string.
 837
 838 2019-07-03  Pedro Alves  <palves@redhat.com>
 839
 840         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
 841         option_value with a null enumeration.
 842         (complete_options): Save the option values in the context.
 843         (save_option_value_in_ctx): New, factored out from ...
 844         (process_options): ... here.
 845         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
 846         of the function.
 847         * maint-test-options.c (test_options_opts::dump): New, factored
 848         out from ...
 849         (maintenance_test_options_command_mode): ... here.
 850         (maintenance_test_options_command_completion_result): Delete.
 851         (maintenance_test_options_command_completion_text): Update
 852         comment.
 853         (maintenance_show_test_options_completion_result): Change
 854         prototype.  Just print
 855         maintenance_test_options_command_completion_text.
 856         (save_completion_result): New.
 857         (maintenance_test_options_completer_mode): Pass options context to
 858         complete_options, and then save a dump.
 859         (_initialize_maint_test_options): Use add_cmd to install "maint
 860         show test-options-completion-result".
 861
 862 2019-07-03  Pedro Alves  <palves@redhat.com>
 863
 864         * NEWS (New commands): Mention "with" and "maint with".
 865         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
 866         (with_command, with_command_completer): New.
 867         (pipe_command): Adjust to new repeat_previous
 868         interface.
 869         (_initialize_cli_cmds): Install the "with" command and its "w"
 870         alias.
 871         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
 872         declarations.
 873         * cli/cli-setshow.c (parse_cli_var_uinteger)
 874         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
 875         argument strings for all var_types.
 876         (get_setshow_command_value_string): New, factored out from ...
 877         (do_show_command): ... this.
 878         * cli/cli-setshow.h: Include <string>.
 879         (get_setshow_command_value_string): Declare.
 880         * command.h (repeat_previous): Now returns const char *.  Adjust
 881         comment.
 882         * maint.c: Include "cli/cli-cmds.h".
 883         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
 884         (_initialize_maint_cmds): Register the "maintenance with" command.
 885         * top.c (repeat_previous): Move bits from pipe_command here:
 886         Return the saved command line, if any; error out if there's no
 887         command to relaunch.
 888
 889 2019-07-03  Pedro Alves  <palves@redhat.com>
 890
 891         * NEWS (New commands): Mention "maint set/show test-settings"
 892         instead of "maint test-settings".
 893         * maint-test-settings.c (maintenance_test_settings_list): Delete.
 894         (maintenance_test_settings_set_list): Rename to ...
 895         (maintenance_set_test_settings_list): ... this.
 896         (maintenance_test_settings_show_list): Rename to  ...
 897         (maintenance_show_test_settings_list): ... this.
 898         (maintenance_test_settings_cmd): Delete.
 899         (maintenance_test_settings_set_cmd): ...
 900         (maintenance_set_test_settings_cmd): ... this.
 901         (maintenance_test_settings_show_cmd): ...
 902         (maintenance_show_test_settings_cmd): ... this.
 903         (maintenance_test_settings_show_value_cmd):
 904         (maintenance_show_test_settings_value_cmd): ... this.
 905         (_initialize_maint_test_settings): No longer install the "maint
 906         test-settings" prefix command.  Rename "maint test-settings set"
 907         to "maint set test-settings", and "maint test-settings show" to
 908         "maint show test-settings".  Adjust all subcommands.
 909
 910 2019-07-03  Pedro Alves  <palves@redhat.com>
 911
 912         * maint-test-settings.c: Fix file's intro comment.  Replace all
 913         references to "test-options" with references to "test-settings",
 914         in comments.
 915
 916 2019-07-03  Pedro Alves  <palves@redhat.com>
 917
 918         * maint-test-settings.c (maintenance_test_settings_xxx)
 919         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 920         New.
 921         (maintenance_test_settings_enums): Use them.
 922         (maintenance_test_settings_enum): Default to
 923         maintenance_test_settings_xxx.
 924         (_initialize_maint_test_settings): Initialize
 925         MAINTENANCE_TEST_SETTINGS_FILENAME.
 926
 927 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 928
 929         * breakpoint.h (remove_breakpoints_inf): Change return type to
 930         void, move function documentation here.
 931         * breakpoint.c (remove_breakpoints_inf): Change return type to
 932         void, move function documentation to header.
 933
 934 2019-07-02  Pedro Alves  <palves@redhat.com>
 935
 936         * NEWS (Completion improvements): Mention "info threads".
 937         * thread.c (struct info_threads_opts, info_threads_option_defs)
 938         (make_info_threads_options_def_group): New.
 939         (info_threads_command): Use gdb::option::process_options.
 940         (info_threads_command_completer): New.
 941         (_initialize_thread): Use gdb::option::build_help to build the
 942         help text for "info threads".
 943
 944 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 945
 946         * defs.h (generic_load): Move from here...
 947         * symfile.h (generic_load): ... to here.  Rename name parameter
 948         to args.
 949         * symfile.c (generic_load): Add comment.
 950
 951 2019-07-01  Tom Tromey  <tromey@adacore.com>
 952
 953         * dwarf2read.c
 954         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 955         declaration of without_params.  Fix formatting.
 956
 957 2019-07-01  Tom Tromey  <tromey@adacore.com>
 958
 959         * ada-exp.y (find_primitive_type): Update.
 960         * ada-lang.h (ada_lookup_symbol): Update.
 961         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 962         parameter.
 963         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 964
 965 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 966
 967         PR breakpoints/24541
 968         * gdbarch.c: Regenerate.
 969         * gdbarch.h: Regenerate.
 970         * gdbarch.sh: Add 'stap_adjust_register'.
 971         * i386-tdep.c: Include '<unordered_set>'.
 972         (i386_stap_adjust_register): New function.
 973         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 974         * stap-probe.c (stap_parse_register_operand): Call
 975         'gdbarch_stap_adjust_register'.
 976
 977 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 978
 979         PR python/24742
 980         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 981         * python/python.c (do_start_initialization): Use 'xmalloc'
 982         instead of 'PyMem_Malloc'.
 983
 984 2019-06-28  Tom Tromey  <tromey@adacore.com>
 985
 986         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 987         for Ada.
 988
 989 2019-06-27  Tom Tromey  <tromey@adacore.com>
 990
 991         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 992         objfile_key.
 993         (arm_find_mapping_symbol, arm_record_special_symbol)
 994         (_initialize_arm_tdep): Update.
 995         (arm_objfile_data_free): Remove.
 996
 997 2019-06-27  Tom Tromey  <tromey@adacore.com>
 998
 999         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
1000         to cp_print_static_field.
1001
1002 2019-06-26  Tom Tromey  <tromey@adacore.com>
1003
1004         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
1005         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
1006         declare.
1007
1008 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1009
1010         * features/aarch64-core.c (create_feature_aarch64_core):
1011         Regenerate.
1012         * features/aarch64-core.xml: Add cpsr flags.
1013
1014 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
1015
1016         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
1017         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
1018
1019 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1020
1021         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
1022         field.
1023         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
1024         use.
1025         (arm_record_special_symbol): Don't insert new symbol in sorted
1026         position, push it at the end.
1027
1028 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
1029
1030         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
1031         (arm_mapping_symbol_s): Remove.
1032         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
1033         (arm_mapping_symbol_vec): New typedef.
1034         (struct arm_per_objfile): Add constructor.
1035         <section_maps>: Change type to
1036         std::unique_ptr<arm_mapping_symbol_vec[]>.
1037         (arm_compare_mapping_symbols): Remove.
1038         (arm_find_mapping_symbol): Adjust to section_maps type change.
1039         (arm_objfile_data_free): Call delete on arm_per_objfile.
1040         (arm_record_special_symbol): Adjust to section_maps type change.
1041         Allocate arm_per_objfile with new.
1042
1043 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1044
1045         * cli/cli-cmds.c (alias_command): Compare the alias prefix
1046         with the command prefix.
1047
1048 2019-06-25  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
1051         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
1052
1053 2019-06-25  Tom Tromey  <tom@tromey.com>
1054
1055         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
1056         type.
1057         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
1058         protected.
1059
1060 2019-06-25  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-winsource.c
1063         (tui_source_window_base::set_is_exec_point_at): Add check against
1064         LOA_ADDRESS.
1065
1066 2019-06-25  Tom Tromey  <tom@tromey.com>
1067
1068         * tui/tui-source.c (tui_set_source_content): Don't check before
1069         xfree.
1070         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
1071
1072 2019-06-25  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui-winsource.h (tui_update_source_window_as_is)
1075         (tui_alloc_source_buffer, tui_line_is_displayed)
1076         (tui_addr_is_displayed): Change type of win_info.
1077         * tui/tui-winsource.c (tui_update_source_window_as_is)
1078         (tui_clear_source_content, tui_show_source_line)
1079         (tui_show_source_content, tui_source_window_base::refill)
1080         (tui_source_window_base::set_is_exec_point_at)
1081         (tui_source_window_base::set_is_exec_point_at)
1082         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
1083         (tui_alloc_source_buffer, tui_line_is_displayed)
1084         (tui_addr_is_displayed): Change type of win_info.  Update.
1085         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1086         (tui_source_window_base::do_make_visible_with_new_height):
1087         Update.
1088         * tui/tui-source.c (tui_set_source_content)
1089         (tui_set_source_content_nil)
1090         (tui_source_window::do_scroll_vertical): Update.
1091         * tui/tui-layout.c (show_layout): Update.
1092         * tui/tui-disasm.c (tui_set_disassem_content)
1093         (tui_disasm_window::do_scroll_vertical): Update.
1094         * tui/tui-data.h (tui_win_content): Remove.
1095         (struct tui_gen_win_info) <content, content_size>: Remove.
1096         (struct tui_source_element): Add initializers and destructor.
1097         (union tui_which_element, struct tui_win_element): Remove.
1098         (struct tui_source_window_base) <content>: New field.
1099         (struct tui_data_window): Remove destructor.
1100         (tui_alloc_content, tui_free_win_content)
1101         (tui_free_all_source_wins_content): Don't declare.
1102         * tui/tui-data.c (tui_initialize_static_data): Update.
1103         (init_content_element, tui_alloc_content): Remove.
1104         (~tui_gen_win_info): Update.
1105         (~tui_data_window, tui_free_all_source_wins_content)
1106         (tui_free_win_content, free_content, free_content_elements):
1107         Remove.
1108
1109 2019-06-25  Tom Tromey  <tom@tromey.com>
1110
1111         * tui/tui-winsource.h (tui_clear_source_content)
1112         (tui_erase_source_content, tui_show_source_content): Change type
1113         of win_info.
1114         * tui/tui-winsource.c (tui_clear_source_content)
1115         (tui_erase_source_content, tui_show_source_content): Change type
1116         of win_info.
1117         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1118         * tui/tui-source.h (tui_set_source_content_nil): Change type of
1119         win_info.
1120         * tui/tui-source.c (tui_set_source_content_nil): Change type of
1121         win_info.
1122         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
1123
1124 2019-06-25  Tom Tromey  <tom@tromey.com>
1125
1126         * tui/tui-winsource.c (tui_clear_source_content)
1127         (tui_source_window_base::set_is_exec_point_at): Update.
1128         * tui/tui-source.c (tui_set_source_content_nil): Update.
1129         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
1130         a bool.
1131         * tui/tui-data.c (init_content_element): Update.
1132
1133 2019-06-25  Tom Tromey  <tom@tromey.com>
1134
1135         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
1136         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
1137         * tui/tui-layout.c (init_and_make_win): Update.
1138         * tui/tui.h (enum tui_win_type): Update.
1139         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
1140         tui_win_is_auxillary.
1141         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
1142         tui_win_is_auxillary.
1143
1144 2019-06-25  Tom Tromey  <tom@tromey.com>
1145
1146         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
1147         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
1148         (tui_delete_data_content_windows, tui_display_all_data)
1149         (tui_data_window::do_scroll_vertical, tui_display_data_from):
1150         Update.
1151         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
1152         * tui/tui-regs.c (tui_last_regs_line_no)
1153         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1154         (tui_show_registers): Update.
1155         (tui_show_register_group): Return void.  Update.
1156         (tui_display_registers_from, tui_display_reg_element_at_line)
1157         (tui_display_registers_from_line, tui_check_register_values):
1158         Update.
1159         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
1160         member.
1161         (struct tui_data_window) <regs_content>: Now a std::vector.
1162         <regs_content_count>: Remove.
1163         (tui_add_content_elements, tui_free_data_content): Don't declare.
1164         * tui/tui-data.c (tui_data_window::clear_detail): Update.
1165         (init_content_element): Remove DATA_WIN case.  Add assert.
1166         (tui_add_content_elements): Remove.
1167         (tui_data_window): Update.
1168         (tui_free_data_content): Remove.
1169         (free_content_elements): Remove DATA_WIN case.
1170
1171 2019-06-25  Tom Tromey  <tom@tromey.com>
1172
1173         * tui/tui-data.c (tui_data_item_window): Update.
1174         * tui/tui-windata.h (tui_check_data_values): Don't declare.
1175         * tui/tui-windata.c (tui_display_all_data)
1176         (tui_display_data_from_line): Update.
1177         (tui_check_data_values): Remove.
1178         * tui/tui-regs.c (tui_show_register_group)
1179         (tui_display_reg_element_at_line): Update.
1180         * tui/tui-hooks.c (tui_register_changed)
1181         (tui_refresh_frame_and_register_information): Call
1182         tui_check_register_values.
1183         * tui/tui-data.h (struct tui_data_window) <data_content,
1184         data_content_count, data_type>: Remove.
1185         (enum tui_data_type): Remove.
1186
1187         * tui/tui-data.c (tui_data_window::clear_detail)
1188         (~tui_data_window): Update.
1189
1190 2019-06-25  Tom Tromey  <tom@tromey.com>
1191
1192         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
1193         declare.
1194         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
1195         Rename from tui_first_data_item_displayed.  Update.
1196         (tui_data_window::refresh_all)
1197         (tui_data_window::do_scroll_vertical): Update.
1198         * tui/tui-data.h (struct tui_data_window)
1199         <first_data_item_displayed>: Declare new method.
1200
1201 2019-06-25  Tom Tromey  <tom@tromey.com>
1202
1203         * tui/tui-data.h (tui_init_generic_part): Don't declare.
1204         * tui/tui-data.c (tui_init_generic_part): Remove, moving
1205         contents...
1206         (tui_initialize_static_data): ...here.
1207
1208 2019-06-25  Tom Tromey  <tom@tromey.com>
1209
1210         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1211         (tui_display_registers_from, tui_check_register_values): Update.
1212         (tui_display_register): Remove win_info parameter; update.
1213         (tui_get_register): Change type of parameters.
1214         * tui/tui-data.h (struct tui_data_element): Remove.
1215         (union tui_which_element) <data>: Remove.
1216         <data_window>: Change type.
1217         (struct tui_data_item_window): New.
1218         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
1219         case.  Add assert.
1220         (~tui_data_item_window): New destructor.
1221         (free_content_elements): Remove DATA_ITEM_WIN case.
1222
1223 2019-06-25  Tom Tromey  <tom@tromey.com>
1224
1225         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
1226         Remove.
1227
1228 2019-06-25  Tom Tromey  <tom@tromey.com>
1229
1230         * tui/tui-data.h (struct tui_command_element): Remove.
1231         (union tui_which_element) <command>: Remove.
1232         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
1233         assert.
1234         (free_content_elements): Remove CMD_WIN case.
1235
1236 2019-06-25  Tom Tromey  <tom@tromey.com>
1237
1238         * tui/tui-layout.c (tui_set_layout): Update.
1239         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
1240         * tui/tui-data.c (layout_def): Update.
1241
1242 2019-06-25  Tom Tromey  <tom@tromey.com>
1243
1244         * tui/tui-wingeneral.c (tui_refresh_all): Update.
1245         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1246         (tui_source_window_base::set_new_height): Update.
1247         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
1248         Update.
1249         (tui_set_locator_fullname, tui_set_locator_info)
1250         (tui_show_frame_info): Update.
1251         * tui/tui-source.c (tui_set_source_content)
1252         (tui_source_is_displayed): Update.
1253         * tui/tui-layout.c (show_source_disasm_command, show_data)
1254         (show_source_or_disasm_and_command): Update.
1255         * tui/tui-disasm.c (tui_set_disassem_content)
1256         (tui_get_begin_asm_address): Update.
1257         * tui/tui-data.h (struct tui_locator_element): Remove.
1258         (union tui_which_element) <locator>: Remove.
1259         (struct tui_locator_window): New.
1260         (tui_locator_win_info_ptr): Change return type.
1261         * tui/tui-data.c (_locator): Change type.
1262         (tui_locator_win_info_ptr): Change return type.
1263         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
1264         (tui_alloc_content): Add assert.
1265
1266 2019-06-25  Tom Tromey  <tom@tromey.com>
1267
1268         * tui/tui-winsource.c
1269         (tui_exec_info_window::maybe_allocate_content): New method.
1270         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
1271         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
1272         (make_source_or_disasm_window): Add cast.
1273         * tui/tui-data.h (union tui_which_element) <simple_string>:
1274         Remove.
1275         (struct tui_source_info): New.
1276         (struct tui_source_window_base) <execution_info>: Change type.
1277         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
1278         case, and add assert.
1279         (tui_alloc_content): Add assert.
1280
1281 2019-06-25  Tom Tromey  <tom@tromey.com>
1282
1283         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
1284         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
1285         * tui/tui-data.c (tui_alloc_win_info): Remove.
1286
1287 2019-06-25  Tom Tromey  <tom@tromey.com>
1288
1289         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
1290         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
1291         can_highlight.
1292
1293 2019-06-25  Tom Tromey  <tom@tromey.com>
1294
1295         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
1296         make_visible_with_new_height method.
1297         (tui_win_info::make_visible_with_new_height): New method.
1298         (tui_source_window_base::do_make_visible_with_new_height)
1299         (tui_data_window::do_make_visible_with_new_height)
1300         (tui_cmd_window::do_make_visible_with_new_height): New methods.
1301         (make_visible_with_new_height): Remove.
1302         (tui_resize_all, tui_adjust_win_heights): Use
1303         make_visible_with_new_height method.
1304         * tui/tui-data.h (struct tui_win_info)
1305         <do_make_visible_with_new_height, make_visible_with_new_height>:
1306         New methods.
1307         (struct tui_source_window_base, struct tui_data_window)
1308         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
1309         methods.
1310
1311 2019-06-25  Tom Tromey  <tom@tromey.com>
1312
1313         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
1314         method.
1315         (update_tab_width): Call update_tab_width method.
1316         * tui/tui-data.h (struct tui_win_info)
1317         (struct tui_source_window_base) <update_tab_width>: New methods.
1318
1319 2019-06-25  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
1322         parameter.
1323         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
1324         parameter.
1325         (tui_gen_win_info::make_visible): Update.
1326         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
1327         parameter.
1328         * tui/tui-data.h (enum tui_box): New enum.
1329         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
1330
1331 2019-06-25  Tom Tromey  <tom@tromey.com>
1332
1333         * tui/tui-layout.c (make_source_or_disasm_window): Always use
1334         init_and_make_win for EXEC_INFO_WIN.
1335         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
1336         longer inline.
1337         (struct tui_win_info) <~tui_win_info>: Inline.
1338         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1339         Don't declare.
1340         * tui/tui-data.c (source_win, disasm_win): Remove globals.
1341         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1342         Remove.
1343         (tui_initialize_static_data): Update.
1344         (~tui_gen_win_info): Handle more cleanup here.
1345         (~tui_source_window_base): Delete "execution_info".
1346         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
1347
1348 2019-06-25  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-layout.c (make_command_window): Don't set
1351         can_highlight.
1352         (show_source_disasm_command): Call the reset method.
1353         (show_data): Don't set can_highlight.  Call the reset method.
1354         (tui_gen_win_info::reset): Rename from init_gen_win_info
1355         (init_and_make_win): Simplify.  Return tui_gen_win_info.
1356         (show_source_or_disasm_and_command): Call the reset method.
1357         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
1358         (struct tui_cmd_window): Set can_highlight.
1359
1360 2019-06-25  Tom Tromey  <tom@tromey.com>
1361
1362         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
1363         from make_visible.
1364         (tui_make_visible, tui_make_invisible): Rewrite.
1365         (tui_win_info::make_visible): Remove.
1366         (tui_source_window_base::make_visible): Update.
1367         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
1368         method.  Moved from...
1369         (struct tui_win_info) <make_visible>: ...here.
1370
1371 2019-06-25  Tom Tromey  <tom@tromey.com>
1372
1373         * tui/tui-winsource.c
1374         (tui_source_window_base::do_scroll_horizontal): Remove direction
1375         parameter.
1376         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
1377         direction parameter.
1378         * tui/tui-win.c (tui_win_info::forward_scroll)
1379         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1380         (tui_win_info::right_scroll): Update.
1381         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
1382         direction parameter.
1383         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
1384         direction parameter.
1385         * tui/tui-data.h (enum tui_scroll_direction): Remove.
1386         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
1387         Remove direction parameter.
1388         (struct tui_source_window_base, struct tui_source_window)
1389         (struct tui_disasm_window, struct tui_data_window)
1390         (struct tui_cmd_window): Update.
1391
1392 2019-06-25  Tom Tromey  <tom@tromey.com>
1393
1394         * tui/tui-winsource.h (tui_set_exec_info_content)
1395         (tui_show_exec_info_content, tui_erase_exec_info_content)
1396         (tui_clear_exec_info_content, tui_update_exec_info): Change
1397         argument to tui_source_window_base.
1398         * tui/tui-winsource.c (tui_set_exec_info_content)
1399         (tui_show_exec_info_content, tui_erase_exec_info_content)
1400         (tui_clear_exec_info_content, tui_update_exec_info): Change
1401         argument to tui_source_window_base.
1402
1403 2019-06-25  Tom Tromey  <tom@tromey.com>
1404
1405         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
1406         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
1407
1408 2019-06-25  Tom Tromey  <tom@tromey.com>
1409
1410         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
1411         check.
1412
1413 2019-06-25  Tom Tromey  <tom@tromey.com>
1414
1415         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
1416         type to void.
1417         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
1418         type to void.
1419         * tui/tui-source.c (tui_set_source_content): Update.
1420         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1421
1422 2019-06-25  Tom Tromey  <tom@tromey.com>
1423
1424         * tui/tui-win.c (window_name_completer, tui_set_focus)
1425         (tui_all_windows_info): Use name method.
1426         * tui/tui-data.h (struct tui_gen_win_info)
1427         (struct tui_source_window, struct tui_disasm_window)
1428         (struct tui_data_window, struct tui_cmd_window) <name>: New
1429         method.
1430         (tui_win_name): Don't declare.
1431         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
1432         (tui_win_name): Remove.
1433
1434 2019-06-25  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-winsource.h (tui_update_source_window)
1437         (tui_update_source_window_as_is): Change parameter type.
1438         * tui/tui-winsource.c (tui_update_source_window): Change win_info
1439         to be a tui_source_window_base.
1440         (tui_update_source_window_as_is): Likewise.
1441         * tui/tui-win.c (make_visible_with_new_height): Update.
1442
1443 2019-06-25  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-winsource.c (tui_erase_source_content)
1446         (tui_show_source_content, tui_show_exec_info_content)
1447         (tui_erase_exec_info_content): Use refresh_window method.
1448         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
1449         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
1450         from tui_refresh_win.
1451         (tui_data_window::refresh_window): New method.
1452         (tui_win_info::refresh, tui_source_window_base::refresh)
1453         (tui_refresh_all): Use refresh_window method.
1454         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
1455         method.
1456         * tui/tui-regs.c (tui_display_register): Call refresh_window
1457         method.
1458         * tui/tui-layout.c (show_source_disasm_command)
1459         (show_source_or_disasm_and_command): Call refresh_window method.
1460         * tui/tui-data.h (struct tui_gen_win_info)
1461         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
1462         New method.
1463
1464 2019-06-25  Tom Tromey  <tom@tromey.com>
1465
1466         * tui/tui.c (tui_rl_other_window, tui_enable)
1467         (tui_is_window_visible, tui_get_command_dimension): Update.
1468         * tui/tui-winsource.c (tui_update_source_window_as_is)
1469         (tui_clear_source_content, tui_erase_source_content)
1470         (tui_show_source_line, tui_source_window_base::refill)
1471         (tui_source_window_base::do_scroll_horizontal)
1472         (tui_source_window_base::set_is_exec_point_at)
1473         (tui_update_breakpoint_info, tui_set_exec_info_content)
1474         (tui_alloc_source_buffer, tui_line_is_displayed)
1475         (tui_addr_is_displayed): Update.
1476         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1477         (tui_check_and_display_highlight_if_needed)
1478         (tui_win_info::make_visible, tui_win_info::refresh)
1479         (tui_refresh_all): Update.
1480         * tui/tui-windata.c (tui_first_data_item_displayed)
1481         (tui_delete_data_content_windows, tui_erase_data_content)
1482         (tui_display_all_data, tui_data_window::refresh_all)
1483         (tui_check_data_values): Update.
1484         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
1485         (tui_set_win_focus_to, tui_win_info::forward_scroll)
1486         (tui_win_info::backward_scroll, tui_refresh_all_win)
1487         (tui_resize_all, tui_set_focus, tui_all_windows_info)
1488         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
1489         (tui_source_window_base::set_new_height)
1490         (tui_data_window::set_new_height)
1491         (make_invisible_and_set_new_height)
1492         (make_visible_with_new_height, new_height_ok)
1493         (parse_scrolling_args): Update.
1494         * tui/tui-stack.c (tui_show_frame_info): Update.
1495         * tui/tui-source.c (tui_set_source_content)
1496         (tui_set_source_content_nil, tui_source_is_displayed)
1497         (tui_source_window::do_scroll_vertical): Update.
1498         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1499         (tui_display_registers_from, tui_display_reg_element_at_line)
1500         (tui_check_register_values, tui_reg_command): Update.
1501         * tui/tui-layout.c (tui_default_win_height)
1502         (show_source_disasm_command, show_data, init_and_make_win)
1503         (show_source_or_disasm_and_command): Update.
1504         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
1505         (tui_redisplay_readline, tui_mld_flush)
1506         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
1507         (tui_getc): Update.
1508         * tui/tui-disasm.c (tui_set_disassem_content)
1509         (tui_disasm_window::do_scroll_vertical): Update.
1510         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
1511         Now virtual.
1512         (struct tui_win_info): Derive from tui_gen_win_info.
1513         <~tui_win_info>: Mark as override.
1514         <generic>: Remove member.
1515         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
1516         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
1517         (~tui_data_window, ~tui_win_info)
1518         (tui_free_all_source_wins_content): Update.
1519         * tui/tui-command.c (tui_refresh_cmd_win): Update.
1520
1521 2019-06-25  Tom Tromey  <tom@tromey.com>
1522
1523         * tui/tui-layout.c (init_and_make_win): Use new.
1524         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
1525         destructor, initializers.
1526         (tui_alloc_generic_win_info): Don't declare.
1527         * tui/tui-data.c (_locator): Add argument to constructor.
1528         (source_win, disasm_win): New globals.
1529         (exec_info): Remove.
1530         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
1531         Update.
1532         (tui_alloc_generic_win_info): Remove.
1533         (init_content_element): Use new.
1534         (tui_win_info::tui_win_info): Update.
1535         (free_content_elements) <case DATA_WIN>: Use delete.
1536
1537 2019-06-25  Tom Tromey  <tom@tromey.com>
1538
1539         * tui/tui-wingeneral.c (tui_refresh_win): Update.
1540         * tui/tui-windata.c (tui_first_data_item_displayed)
1541         (tui_delete_data_content_windows): Update.
1542         * tui/tui-win.c (tui_data_window::set_new_height): Update.
1543         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
1544         (tui_display_registers_from, tui_check_register_values): Update.
1545         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
1546         pointer.
1547         * tui/tui-data.c (init_content_element): Update.  Allocate the new
1548         window.
1549         (tui_free_data_content): Update.
1550         (free_content_elements) <case DATA_WIN>: Free the window.
1551
1552 2019-06-25  Tom Tromey  <tom@tromey.com>
1553
1554         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
1555         Update.
1556         * tui/tui-layout.c (make_command_window)
1557         (show_source_disasm_command, show_data, init_and_make_win)
1558         (show_source_or_disasm_and_command): Update.
1559         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
1560         method.
1561         <can_highight, is_highlighted>: Now bool.
1562         (tui_set_win_highlight): Don't declare.
1563         * tui/tui-data.c (tui_set_win_highlight): Remove.
1564
1565 2019-06-25  Tom Tromey  <tom@tromey.com>
1566
1567         * tui/tui-wingeneral.c (make_visible): Remove check of window
1568         type.
1569
1570 2019-06-25  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-win.c (tui_win_info::max_height)
1573         (tui_cmd_window::max_height): New methods.
1574         (new_height_ok): Call max_height.
1575         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
1576         <max_height>: New method.
1577
1578 2019-06-25  Tom Tromey  <tom@tromey.com>
1579
1580         * tui/tui-win.c (tui_source_window_base::set_new_height)
1581         (tui_data_window::set_new_height): New methods.
1582         (make_invisible_and_set_new_height): Call set_new_height method.
1583         * tui/tui-data.h (struct tui_win_info)
1584         (struct tui_source_window_base, struct tui_data_window)
1585         <set_new_height>: New method.
1586
1587 2019-06-25  Tom Tromey  <tom@tromey.com>
1588
1589         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
1590         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
1591         tui_refresh_data_win.
1592         * tui/tui-win.c (tui_source_window_base::refresh_all): New
1593         method.
1594         (tui_refresh_all_win): Call the refresh_all method.
1595         (tui_set_focus): Likewise.
1596         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
1597         (struct tui_source_window_base, struct tui_data_window) <refresh>:
1598         Likewise.
1599
1600 2019-06-25  Tom Tromey  <tom@tromey.com>
1601
1602         * tui/tui-winsource.h (tui_refill_source_window)
1603         (tui_set_is_exec_point_at): Don't declare.
1604         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1605         (tui_source_window_base::refill): Rename from
1606         tui_refill_source_window.
1607         (tui_source_window_base::do_scroll_horizontal): Update.
1608         (tui_source_window_base::set_is_exec_point_at): Rename from
1609         tui_set_is_exec_point_at.
1610         (tui_update_all_breakpoint_info): Update.
1611         * tui/tui-stack.c (tui_show_frame_info): Update.
1612         * tui/tui-layout.c (show_data): Add cast.
1613         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
1614         * tui/tui-data.h (struct tui_source_window_base) <refill,
1615         set_is_exec_point_at>: New methods.
1616         (tui_source_windows, tui_add_to_source_windows): Update types.
1617         (tui_add_to_source_windows): Remove redundant declaration.
1618         * tui/tui-data.c (source_windows): Store tui_source_window_base.
1619         (tui_source_windows): Change return type.
1620         (tui_clear_source_windows_detail): Update.
1621         (tui_add_to_source_windows): Change type of parameter.
1622         (tui_free_all_source_wins_content): Update.
1623
1624 2019-06-25  Tom Tromey  <tom@tromey.com>
1625
1626         * tui/tui-wingeneral.c (tui_win_info::refresh)
1627         (tui_source_window_base::refresh): New methods.
1628         (tui_refresh_all): Call the refresh method.
1629         * tui/tui-data.h (struct tui_win_info)
1630         (struct tui_source_window_base) <refresh>: New method.
1631
1632 2019-06-25  Tom Tromey  <tom@tromey.com>
1633
1634         * tui/tui.h (tui_is_window_visible): Return bool.
1635         * tui/tui.c (tui_is_window_visible): Return bool.
1636         * tui/tui-wingeneral.c (tui_make_window, make_visible)
1637         (tui_make_visible, tui_make_invisible)
1638         (tui_win_info::make_visible)
1639         (tui_source_window_base::make_visible, make_all_visible)
1640         (tui_make_all_visible, tui_make_all_invisible): Update.
1641         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
1642         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
1643         bool.
1644         (struct tui_win_info, struct tui_source_window_base)
1645         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
1646         * tui/tui-data.c (tui_init_generic_part): Update.
1647
1648 2019-06-25  Tom Tromey  <tom@tromey.com>
1649
1650         * tui/tui-wingeneral.c (tui_win_info::make_visible)
1651         (tui_source_window_base::make_visible): New methods.
1652         (make_all_visible): Make method call.
1653         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
1654         (struct tui_source_window_base, struct tui_cmd_window): Override
1655         make_visible.
1656         (tui_win_is_source_type): Don't declare.
1657         * tui/tui-data.c (tui_win_is_source_type): Remove.
1658
1659 2019-06-25  Tom Tromey  <tom@tromey.com>
1660
1661         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
1662         NULL check.
1663
1664 2019-06-25  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
1667         Inline constructor.  Add initializers for members.
1668         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
1669         constructors; now inline in class.
1670
1671 2019-06-25  Tom Tromey  <tom@tromey.com>
1672
1673         * tui/tui-regs.c (tui_show_registers): Update.
1674         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
1675         bool.
1676         * tui/tui-data.c (tui_data_window::clear_detail)
1677         (tui_data_window): Update.
1678
1679 2019-06-25  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-windata.c (tui_display_all_data)
1682         (tui_display_data_from_line, tui_display_data_from)
1683         (tui_check_data_values, tui_data_window::do_scroll_vertical):
1684         Update.
1685         * tui/tui-regs.c (tui_last_regs_line_no)
1686         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
1687         (tui_show_registers, tui_show_register_group)
1688         (tui_display_registers_from, tui_display_reg_element_at_line)
1689         (tui_display_registers_from_line, tui_check_register_values)
1690         (tui_reg_next, tui_reg_prev): Update.
1691         * tui/tui-layout.c (tui_set_layout, show_data): Update.
1692         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
1693         tui_data_window.
1694         (struct tui_win_info) <detail>: Remove.  Add new fields from
1695         tui_data_info.
1696         (TUI_DATA_WIN): Add cast.
1697         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
1698         (~tui_data_window): Simplify.
1699
1700 2019-06-25  Tom Tromey  <tom@tromey.com>
1701
1702         * tui/tui-layout.c (show_source_disasm_command)
1703         (show_source_or_disasm_and_command): Update.
1704         * tui/tui-io.c (update_cmdwin_start_line)
1705         (tui_redisplay_readline): Update.
1706         * tui/tui-data.h (struct tui_command_info): Remove.
1707         (struct tui_win_info) <detail>: Remove command_info member.
1708         (struct tui_data_window) <start_line>: New member, from
1709         tui_command_info.
1710         (TUI_CMD_WIN): Add casts.
1711
1712 2019-06-25  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui-winsource.c (tui_update_source_window)
1715         (tui_refill_source_window)
1716         (tui_source_window_base::do_scroll_horizontal)
1717         (tui_update_breakpoint_info, tui_set_exec_info_content)
1718         (tui_show_exec_info_content, tui_erase_exec_info_content)
1719         (tui_clear_exec_info_content): Update.
1720         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
1721         Update.
1722         * tui/tui-win.c (make_invisible_and_set_new_height)
1723         (make_visible_with_new_height): Update.
1724         * tui/tui-source.c (tui_set_source_content)
1725         (tui_show_symtab_source): Update.
1726         * tui/tui-layout.c (extract_display_start_addr)
1727         (show_source_disasm_command, show_data)
1728         (make_source_or_disasm_window)
1729         (show_source_or_disasm_and_command): Update.
1730         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
1731         (tui_disasm_window::do_scroll_vertical): Remove shadowing
1732         "gdbarch".
1733         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
1734         to tui_source_window_base.
1735         (struct tui_win_info) <detail>: Remove source_info member.
1736         (struct tui_source_window_base) <has_locator>: Inline.
1737         Move contents from tui_source_info; rename has_locator member to
1738         m_has_locator.
1739         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
1740         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
1741         header file.
1742         (tui_source_window_base::clear_detail, ~tui_source_window_base):
1743         Simplify.
1744         (tui_free_all_source_wins_content): Cast to
1745         tui_source_window_base.
1746
1747 2019-06-25  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-win.c (make_invisible_and_set_new_height)
1750         (make_visible_with_new_height): Call has_locator method.
1751         * tui/tui-layout.c (show_source_disasm_command, show_data)
1752         (show_source_or_disasm_and_command): Update for bool change.
1753         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
1754         (tui_win_info) <has_locator>: New method.
1755         (struct tui_source_window_base) <has_locator>: New method.
1756         (tui_win_has_locator): Don't declare.
1757         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
1758         from tui_win_has_locator.
1759         (tui_source_window_base): Use false, not FALSE.
1760
1761 2019-06-25  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
1764         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
1765         clear_detail method directly.
1766         (tui_clear_win_detail): Remove.
1767
1768 2019-06-25  Tom Tromey  <tom@tromey.com>
1769
1770         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
1771         "this", not TUI_DISASM_WIN.
1772
1773 2019-06-25  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
1776         declare.
1777         * tui/tui-winsource.c
1778         (tui_source_window_base::do_scroll_horizontal): Rename from
1779         tui_horizontal_source_scroll.
1780         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
1781         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
1782         from tui_vertical_data_scroll.
1783         * tui/tui-win.h (tui_scroll): Don't declare.
1784         * tui/tui-win.c (tui_win_info::forward_scroll)
1785         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
1786         (tui_win_info::right_scroll): Rename and update.
1787         (tui_scroll_forward_command, tui_scroll_backward_command)
1788         (tui_scroll_left_command, tui_scroll_right_command): Update.
1789         (tui_scroll): Remove.
1790         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
1791         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
1792         from tui_vertical_source_scroll.
1793         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
1794         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
1795         from tui_vertical_disassem_scroll.
1796         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
1797         do_scroll_horizontal>: New methods.
1798         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
1799         Likewise.
1800         (struct tui_source_window_base): Add do_scroll_horizontal.
1801         (struct tui_source_window, struct tui_disasm_window): Add
1802         do_scroll_vertical.
1803         (struct tui_data_window, struct tui_cmd_window): Add
1804         do_scroll_horizontal and do_scroll_vertical.
1805         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
1806
1807 2019-06-25  Tom Tromey  <tom@tromey.com>
1808
1809         * tui/tui-data.h (struct tui_source_window_base): New struct.
1810         (struct tui_source_window): Derive from tui_source_window_base.
1811         (struct tui_disasm_window): New struct.
1812         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1813         from tui_source_window::clear_detail.
1814         (tui_source_window_base): Rename from tui_source_window.
1815         (~tui_source_window_base): Rename from ~tui_source_window.
1816         (tui_alloc_win_info): Create a tui_disasm_window.
1817
1818 2019-06-25  Tom Tromey  <tom@tromey.com>
1819
1820         * tui/tui-data.h (struct tui_source_window)
1821         (struct tui_data_window): Declare destructors.
1822         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1823         destructors.
1824         (tui_win_info): Simplify.
1825
1826 2019-06-25  Tom Tromey  <tom@tromey.com>
1827
1828         * tui/tui-winsource.c (tui_display_main)
1829         (tui_update_source_windows_with_addr)
1830         (tui_update_all_breakpoint_info): Update.
1831         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1832         (new_height_ok, parse_scrolling_args): Update.
1833         * tui/tui-stack.c (tui_show_frame_info): Update.
1834         * tui/tui-data.h (struct tui_list): Remove.
1835         (tui_source_windows): Return a reference to a std::vector.
1836         * tui/tui-data.c (source_windows): Now a std::vector.
1837         (tui_source_windows): Change return type.
1838         (tui_clear_source_windows): Rewrite.
1839         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1840         (tui_free_all_source_wins_content): Rewrite.
1841
1842 2019-06-25  Tom Tromey  <tom@tromey.com>
1843
1844         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1845         (struct tui_data_window, struct tui_cmd_window): Declare
1846         clear_detail method.
1847         * tui/tui-data.c (tui_source_window::clear_detail)
1848         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1849         methods.
1850         (tui_clear_win_detail): Simplify.
1851
1852 2019-06-25  Tom Tromey  <tom@tromey.com>
1853
1854         * tui/tui-layout.c (make_source_window, make_disasm_window)
1855         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1856         Return the new window.
1857         (show_source_disasm_command, show_data)
1858         (show_source_or_disasm_and_command): Update.
1859
1860 2019-06-25  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1863         parameter.  Return the new window.
1864         (show_source_disasm_command): Update and remove NULL check.
1865         (show_source_or_disasm_and_command): Update.
1866
1867 2019-06-25  Tom Tromey  <tom@tromey.com>
1868
1869         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1870
1871 2019-06-25  Tom Tromey  <tom@tromey.com>
1872
1873         * tui/tui-data.h (struct tui_win_info): Make constructor
1874         protected.  Make destructor virtual.  Add initializers.
1875         (tui_source_window, tui_data_window, tui_cmd_window): New
1876         classes.
1877         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1878         constructor.  Add "type" parameter.
1879         (tui_source_window, tui_data_window, tui_cmd_window): New
1880         constructors.
1881         (tui_alloc_win_info): Instantiate the appropriate subclass.
1882
1883 2019-06-25  Tom Tromey  <tom@tromey.com>
1884
1885         * tui/tui-win.c (tui_resize_all): Use delete.
1886         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1887         destructor.
1888         (tui_free_window): Don't declare.
1889         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1890         Update.
1891
1892 2019-06-25  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-data.h (struct tui_win_info): Add constructor.
1895         * tui/tui-data.c (tui_alloc_win_info): Use new.
1896         (tui_free_window): Use delete.
1897
1898 2019-06-22  Tom Tromey  <tom@tromey.com>
1899
1900         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1901         declare.
1902         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1903
1904 2019-06-22  Tom Tromey  <tom@tromey.com>
1905
1906         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1907         declare.
1908         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1909
1910 2019-06-22  Tom de Vries  <tdevries@suse.de>
1911
1912         * dwarf2read.c (create_addrmap_from_aranges)
1913         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1914         instead of '%zu'.
1915
1916 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1917
1918         * dwarf2read.h (dwarf2_section_info_def): Remove.
1919         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1920         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1921         std::vector<dwarf2_section_info>.
1922         (struct dwo_file) <~dwo_file>: Remove.
1923         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1924         types field.
1925         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1926         (dwarf2_read_debug_names): Likewise.
1927         (create_debug_types_hash_table): Change parameter type to
1928         array_view, adjust code accordingly.
1929         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1930         (partial_die_info::fixup): Likewise.
1931         (determine_prefix): Likewise.
1932         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1933
1934 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1935
1936         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1937         gdb_bfd_ref_ptr.
1938         <~dwo_file>: Remove call to gdb_bfd_unref.
1939         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1940         gdb_bfd_ref_ptr::get.
1941
1942 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1943
1944         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1945         type to htab_up.
1946         * dwarf2read.c (struct dwo_file): Initialize fields.
1947         <~dwo_file>: New.
1948         (free_dwo_file): Remove, move content to ~dwo_file.
1949         (struct dwo_file_deleter): Remove.
1950         (dwo_file_up>: Remove custom deleter.
1951         (free_dwo_files): Remove.
1952         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1953         dwo_files.
1954         (process_skeletonless_type_units): Call unique_ptr::get.
1955         (allocate_dwo_file_hash_table): Add deleter to created hash
1956         table.  Change return type to htab_up.
1957         (lookup_dwo_file_slot): Don't memset dwo_file, call
1958         unique_ptr::get.
1959         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1960         (create_dwo_unit_in_dwp_v2): Likewise.
1961         (open_and_init_dwo_file): Likewise.
1962         (free_dwo_file_from_slot): Remove.
1963
1964 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1965
1966         * dwarf2read.h (struct dwarf2_section_info) <readin,
1967         is_virtual>: Change type to bool.
1968         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1969         true instead of 1.
1970
1971 2019-06-19  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-data.h (tui_init_content_element): Don't declare.
1974
1975 2019-06-19  Tom Tromey  <tom@tromey.com>
1976
1977         * tui/tui-data.h (tui_init_win_info): Don't declare.
1978
1979 2019-06-19  Tom de Vries  <tdevries@suse.de>
1980
1981         * dwarf2read.h (abstract_to_concrete): Change type to
1982         std::unordered_map<sect_offset, std::vector<sect_offset>,
1983         gdb::hash_enum<sect_offset>>.
1984
1985 2019-06-19  Tom Tromey  <tromey@adacore.com>
1986
1987         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1988         EVAL_AVOID_SIDE_EFFECTS specially.
1989
1990 2019-06-19  Tom Tromey  <tromey@adacore.com>
1991
1992         * source-cache.c (highlighter): New global.
1993         (source_cache::get_source_lines): Create a highlighter on demand.
1994
1995 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1996
1997         * defs.h (deprecated_interactive_hook): Delete declaration.
1998         * interps.c (clear_interpreter_hooks): Remove use of
1999         deprecated_interactive_hook.
2000         * top.c (deprecated_interactive_hook): Delete definition.
2001         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
2002
2003 2019-06-18  Tom de Vries  <tdevries@suse.de>
2004
2005         PR gdb/24515
2006         * dwarf2read.h (abstract_to_concrete): Change type from
2007         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
2008         std::unordered_map<sect_offset, std::vector<sect_offset>>.
2009         * dwarf2read.c (read_variable): Update.
2010         (dwarf2_fetch_die_loc_sect_off): Update.
2011
2012 2019-06-17  Tom de Vries  <tdevries@suse.de>
2013
2014         PR gdb/24617
2015         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
2016         accessing parent[parent_len - 1].
2017
2018 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
2019
2020         PR gdb/24364
2021         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
2022         call dtrace_process_dof with NULL dof.
2023
2024 2019-06-16  Tom de Vries  <tdevries@suse.de>
2025
2026         PR gdb/24445
2027         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
2028
2029 2019-06-16  Tom Tromey  <tom@tromey.com>
2030
2031         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
2032         (make_all_visible): Use address of member.
2033
2034 2019-06-16  Tom Tromey  <tom@tromey.com>
2035
2036         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
2037         (tui_free_window, free_content, free_content_elements): Remove
2038         unnecessary cast.
2039         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
2040         cast.
2041         * tui/tui-regs.c (tui_show_register_group)
2042         (tui_display_registers_from, tui_display_reg_element_at_line):
2043         Remove unnecessary cast.
2044
2045 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
2046
2047         * linux-nat.c (normal_mask): Delete.
2048         (_initialize_linux_nat): Don't initialise normal_mask.
2049
2050 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
2051
2052         PR gdb/24445
2053         * dwarf-index-write.h (write_psymtabs_to_index): Add
2054         dwz_basename parameter.
2055         * dwarf-index-write.c (write_gdbindex): Move file writing to
2056         write_gdbindex_1.  Change return type void.
2057         (assert_file_size): Move up, remove filename parameter.
2058         (write_gdbindex_1): New function.
2059         (write_debug_names): Change return type to void, call
2060         assert_file_size.
2061         (struct index_wip_file): New struct.
2062         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
2063         file logic to index_wip_file.  Write index for dwz file if
2064         needed.
2065         (save_gdb_index_command): Pass basename of dwz file, if present.
2066         * dwarf-index-cache.c (index_cache::store): Obtain and pass
2067         build-id of dwz file, if present.
2068         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
2069         (dwarf2_get_dwz_file): Likewise.
2070         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
2071         (dwarf2_get_dwz_file): Likewise.
2072
2073 2019-06-16  Tom Tromey  <tom@tromey.com>
2074
2075         * coffread.c (process_coff_symbol): Use xstrdup.
2076         * value.c (create_internalvar): Use xstrdup.
2077
2078 2019-06-16  Tom Tromey  <tom@tromey.com>
2079
2080         * valops.c (value_cast, value_slice): Remove unnecessary cast.
2081         * breakpoint.c (stopin_command, stopat_command)
2082         (until_break_command, decode_location_default): Remove unnecessary
2083         cast.
2084         * utils.c (subset_compare): Remove unnecessary cast.
2085         * ada-lang.c (ada_update_initial_language): Remove unnecessary
2086         cast.
2087         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
2088         cast.
2089         * infcmd.c (path_command): Remove unnecessary cast.
2090         * coffread.c (decode_type): Remove unnecessary cast.
2091         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
2092         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
2093         * tui/tui-stack.c (tui_show_locator_content)
2094         (tui_show_frame_info): Remove unnecessary cast.
2095         * tui/tui-win.c (tui_scroll_forward_command)
2096         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
2097         (parse_scrolling_args): Remove unnecessary cast.
2098         * tui/tui-data.c (init_win_info, tui_del_window)
2099         (tui_free_window, tui_del_data_windows, tui_free_data_content)
2100         (free_content_elements): Remove unnecessary cast.
2101         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
2102         unnecessary cast.
2103         * tui/tui-source.c (tui_set_source_content)
2104         (tui_vertical_source_scroll): Remove unnecessary cast.
2105         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
2106         cast.
2107         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
2108         * tui/tui-regs.c (tui_display_registers_from)
2109         (tui_display_register): Remove unnecessary cast.
2110         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
2111         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
2112         (make_visible): Remove unnecessary cast.
2113         * tui/tui-winsource.c (tui_erase_source_content)
2114         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
2115         unnecessary cast.
2116         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
2117         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
2118         * stabsread.c (read_type, read_array_type, read_range_type):
2119         Remove unnecessary cast.
2120         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
2121         (parse_symbol, parse_type, upgrade_type, parse_external)
2122         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
2123         unnecessary cast.
2124         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
2125
2126 2019-06-16  Tom Tromey  <tom@tromey.com>
2127
2128         * tui/tui-data.c (tui_alloc_generic_win_info)
2129         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
2130         checks.
2131
2132 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
2133             Andrew Burgess  <andrew.burgess@embecosm.com>
2134
2135         * f-typeprint.c (f_print_type): Don't return early for not
2136         associated or not allocated types.
2137         (f_type_print_varspec_suffix): Add print_rank parameter and print
2138         ranks of array types in case they dangling.
2139         (f_type_print_base): Add print_rank parameter.
2140
2141 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2142
2143         * NEWS: Mention new MI commands.
2144         * break-catch-throw.c (enum exception_event_kind): Move to
2145         breakpoint.h.
2146         (print_mention_exception_catchpoint): Output text as a single
2147         message.
2148         (catch_exception_command_1): Rename to...
2149         (catch_exception_event): ...this, make non-static, update header
2150         command, and change some parameter types.
2151         (catch_catch_command): Update for changes to
2152         catch_exception_command_1.
2153         (catch_throw_command): Likewise.
2154         (catch_rethrow_command): Likewise.
2155         * breakpoint.c (enum exception_event_kind): Delete.
2156         * breakpoint.h (enum exception_event_kind): Moved here from
2157         break-catch-throw.c.
2158         (catch_exception_event): Declare.
2159         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
2160         (mi_cmd_catch_throw): New function.
2161         (mi_cmd_catch_rethrow): New function.
2162         (mi_cmd_catch_catch): New function.
2163         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
2164         'catch-catch' entries.
2165         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
2166         (mi_cmd_catch_rethrow): Declare.
2167         (mi_cmd_catch_catch): Declare.
2168
2169 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2170
2171         * annotate.c (annotate_source_line): Change return type to void,
2172         update implementation to match.
2173         * annotate.h (annotate_source_line): Change return type to void,
2174         update header comment.
2175         * stack.c (print_frame_info): Don't change what frame information
2176         is printed based on whether annotations are on or not.
2177
2178 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
2181         (annotate_source): Make static.
2182         (annotate_source_line): Moved from source.c and renamed from
2183         identify_source_line.  Update the return type.
2184         * annotate.h (annotate_source): Delete declaration.
2185         (annotate_source_line): Declaration moved from source.h, and
2186         renamed from identify_source_line.  Return type updated.
2187         * source.c (identify_source_line): Moved to annotate.c and renamed
2188         to annotate_source_line.
2189         (info_line_command): Remove check of annotation_level.
2190         * source.h (identify_source_line): Move declaration to annotate.h
2191         and rename to annotate_source_line.
2192         * stack.c: Add 'annotate.h' include.
2193         (print_frame_info): Remove check of annotation_level before
2194         calling annotate_source_line.
2195
2196 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2197
2198         * source-cache.c (source_cache::get_plain_source_lines): Use
2199         open_source_file_with_line_charpos instead of just
2200         open_source_file, remove call to find_source_lines.
2201         (source_cache::get_source_lines): Likewise.
2202         * source.c (find_source_lines): Make static.
2203         (get_filename_and_charpos): Renamed into...
2204         (open_source_file_with_line_charpos): ..this along with changes to
2205         return a scoped_fd, and some other minor clean ups.
2206         (identify_source_line): Use open_source_file_with_line_charpos.
2207         (search_command_helper): Use open_source_file_with_line_charpos
2208         instead of just open_source_file, remove call to
2209         find_source_lines.
2210         * source.h (open_source_file_with_line_charpos): Declare new
2211         function.
2212         (find_source_lines): Delete declaration.
2213
2214 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
2215
2216         * source.c (get_filename_and_charpos): Remove fullname
2217         parameter.
2218         (identify_source_line): Update call to get_filename_and_charpos.
2219
2220 2019-06-14  Tom Tromey  <tromey@adacore.com>
2221
2222         PR gdb/24502:
2223         * ui-style.h (skip_ansi_escape): Update comment.
2224         * ui-file.h (class no_terminal_escape_file): New class.
2225         * ui-file.c (no_terminal_escape_file::write)
2226         (no_terminal_escape_file::puts): New methods.
2227         * cli/cli-logging.c (handle_redirections): Use
2228         no_terminal_escape_file.
2229
2230 2019-06-14  Tom Tromey  <tromey@adacore.com>
2231
2232         * NEWS: Move convenience variable news above Python news.
2233
2234 2019-06-14  Tom Tromey  <tom@tromey.com>
2235
2236         * gnulib: Move directory to top-level.
2237         * configure.ac: Don't configure gnulib.
2238         * configure: Rebuild.
2239         * common/common-defs.h: Use new path to gnulib.
2240         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
2241         (GNULIB_H): Remove.
2242         (INCGNU): Look in new gnulib location.
2243         (HFILES_NO_SRCDIR): Remove gnulib files.
2244         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
2245         (generated_files): Remove GNULIB_H.
2246         ($(LIBGNU), all-lib): Remove targets.
2247         (distclean): Don't mention GNULIB_BUILDDIR.
2248         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
2249
2250 2019-06-14  Tom Tromey  <tromey@adacore.com>
2251
2252         * symfile.c (add_symbol_file_command): Remove obsolete comment.
2253         Warn if symbol file does not provide any symbols.
2254
2255 2019-06-14  Tom Tromey  <tromey@adacore.com>
2256
2257         * source.c (find_and_open_source): Respect basenames_may_differ.
2258
2259 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
2260
2261         * annotate.c (annotate_breakpoints_invalid): Make use of
2262         scoped_restore_terminal_state.
2263         (annotate_frames_invalid): Likewise.
2264
2265 2019-06-14  Tom Tromey  <tromey@adacore.com>
2266
2267         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
2268         allow assignment to an internalvar.
2269
2270 2019-06-14  Tom Tromey  <tromey@adacore.com>
2271
2272         * ada-lex.l: Allow "_" in attribute names.
2273
2274 2019-06-14  Tom Tromey  <tromey@adacore.com>
2275
2276         PR gdb/24653:
2277         * regcache.c (registers_changed): Don't call alloca.
2278         * top.c (execute_command): Don't call alloca.
2279
2280 2019-06-13  Pedro Alves  <palves@redhat.com>
2281
2282         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
2283         'expression'.  When parsing an expression, error out if there's
2284         junk after "unlimited".
2285         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2286         (do_set_command): Adjust calls to is_unlimited_literal.
2287
2288 2019-06-13  Pedro Alves  <palves@redhat.com>
2289
2290         * compile/compile.c (make_compile_options_def_group): Add braces
2291         around array_view initializer.
2292         * thread.c (make_thread_apply_all_options_def_group)
2293         (make_thread_apply_all_options_def_group): Likewise.
2294
2295 2019-06-13  Pedro Alves  <palves@redhat.com>
2296
2297         * NEWS (New commands): Mention "maint test-options
2298         require-delimiter", "maint test-options unknown-is-error", "maint
2299         test-options unknown-is-operand" and "maint show
2300         test-options-completion-result".
2301         (New command options, command completion): New section.
2302         (Completion improvements): New section.
2303         Mention that you can abbreviate "unlimited".
2304
2305 2019-06-13  Pedro Alves  <palves@redhat.com>
2306
2307         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
2308         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
2309         * unittests/cli-utils-selftests.c (test_parse_flags)
2310         (test_parse_flags_qcs): Delete.
2311         (test_cli_utils): Don't call deleted functions.
2312
2313 2019-06-13  Pedro Alves  <palves@redhat.com>
2314
2315         * thread.c: Include "cli/cli-option.h".
2316         (tp_array_compar_ascending): Global.
2317         (tp_array_compar): Delete function.
2318         (tp_array_compar_ascending, tp_array_compar_descending): New
2319         functions.
2320         (ascending_option_def, qcs_flag_option_def)
2321         (thr_qcs_flags_option_defs)
2322         (make_thread_apply_all_options_def_group)
2323         (make_thread_apply_options_def_group): New.
2324         (thread_apply_all_command): Use gdb::option::process_options.
2325         (thread_apply_command_completer)
2326         (thread_apply_all_command_completer): New.
2327         (thread_apply_command): Use gdb::option::process_options.
2328         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
2329         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
2330         to generate help text of "thread apply".  Adjust "taas"'s help.
2331         * tid-parse.c (tid_range_parser::in_thread_range): New method.
2332         * tid-parse.h (tid_range_parser::in_thread_range): New method.
2333
2334 2019-06-13  Pedro Alves  <palves@redhat.com>
2335
2336         * thread.c (thread_apply_command): Check for invalid TID with
2337         isdigit instead of !isalpha.
2338
2339 2019-06-13  Pedro Alves  <palves@redhat.com>
2340
2341         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
2342         (validate_flags_qcs): New.
2343         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
2344         (validate_flags_qcs): Declare.
2345         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
2346         (make_frame_apply_options_def_group): New.
2347         (frame_apply_command_count): Process options with
2348         gdb::option::process_options.
2349         (frame_apply_completer): New.
2350         (frame_apply_level_completer, frame_apply_all_completer)
2351         (frame_apply_completer): New.
2352         (_initialize_stack): Update help of "frame apply", "frame apply
2353         level", "frame apply all" and "faas" to mention supported options
2354         and install command completers.
2355         * stack.h (frame_apply_all_completer): Declare.
2356         * thread.c: Include "stack.h".
2357         (tfaas_command): Add "--".
2358         (_initialize_thread): Update help "tfaas" to mention supported
2359         options and install command completer.
2360
2361 2019-06-13  Pedro Alves  <palves@redhat.com>
2362
2363         * completer.c (complete_nested_command_line): New.
2364         (gdb_completion_word_break_characters_throw): Add assertion.
2365         * completer.h (complete_nested_command_line): Declare.
2366
2367 2019-06-13  Pedro Alves  <palves@redhat.com>
2368
2369         * stack.c (parse_backtrace_qualifiers): New.
2370         (backtrace_command): Use it.
2371         (backtrace_command_completer): Complete on qualifiers.
2372
2373 2019-06-13  Pedro Alves  <palves@redhat.com>
2374
2375         * frame.c: Include "cli/cli-option.h.
2376         (user_set_backtrace_options): New.
2377         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
2378         Delete.
2379         (get_prev_frame): Adjust.
2380         (boolean_option_def, uinteger_option_def)
2381         (set_backtrace_option_defs): New.
2382         (_initialize_frame): Adjust and use
2383         gdb::option::add_setshow_cmds_for_options to install "set
2384         backtrace past-main" and "set backtrace past-entry".
2385         * frame.h: Include "cli/cli-option.h".
2386         (struct frame_print_options): Forward declare.
2387         (print_frame_arguments_all, print_frame_arguments_scalars)
2388         (print_frame_arguments_none): Declare.
2389         (print_entry_values): Delete declaration.
2390         (struct frame_print_options, user_frame_print_options): New.
2391         (struct set_backtrace_options): New.
2392         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
2393         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
2394         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
2395         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
2396         (list_args_or_locals): Add frame_print_options parameter.
2397         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2398         * python/py-framefilter.c (enumerate_args): Pass down
2399         USER_FRAME_PRINT_OPTIONS.
2400         * stack.c: Include "cli/cli-option.h".
2401         (print_frame_arguments_all, print_frame_arguments_scalars)
2402         (print_frame_arguments_none): Declare.
2403         (print_raw_frame_arguments, print_entry_values): Delete.
2404         (user_frame_print_options): New.
2405         (boolean_option_def, enum_option_def, frame_print_option_defs):
2406         New.
2407         (struct backtrace_cmd_options): New.
2408         (bt_flag_option_def): New.
2409         (backtrace_command_option_defs): New.
2410         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
2411         (print_frame_arg, read_frame_arg, print_frame_args)
2412         (print_frame_info, print_frame): Add frame_print_options parameter
2413         and use it.
2414         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
2415         (backtrace_command_1): Add frame_print_options and
2416         backtrace_cmd_options parameters and use them.
2417         (make_backtrace_options_def_group): New.
2418         (backtrace_command): Process command options with
2419         gdb::option::process_options.
2420         (backtrace_command_completer): New.
2421         (_initialize_stack): Extend "backtrace"'s help to mention
2422         supported options.  Install completer for "backtrace".
2423         Install some settings commands with add_setshow_cmds_for_options.
2424
2425 2019-06-13  Pedro Alves  <palves@redhat.com>
2426
2427         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
2428         and that "set/show print raw frame-arguments" are now deprecated.
2429
2430         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
2431         command.
2432         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
2433         * stack.c (_initialize_stack): Install "set/show print
2434         raw-frame-arguments", and deprecate "set/show print raw
2435         frame-arguments".
2436         * valprint.c (_initialize_valprint): Deprecate "set/show print
2437         raw".
2438
2439 2019-06-13  Pedro Alves  <palves@redhat.com>
2440
2441         * compile/compile.c (struct compile_options): New.
2442         (compile_flag_option_def, compile_command_option_defs)
2443         (make_compile_options_def_group): New.
2444         (compile_file_command): Handle options with
2445         gdb::option::process_options.
2446         (compile_file_command_completer): New function.
2447         (compile_code_command): Handle options with
2448         gdb::option::process_options.
2449         (compile_code_command_completer): New function.
2450         (_initialize_compiler): Install completers for "compile code" and
2451         "compile file".  Mention available options in "compile code" and
2452         "compile code"'s help.
2453         * completer.c (advance_to_completion_word): New, factored out from
2454         ...
2455         (advance_to_expression_complete_word_point): ... this.
2456         (advance_to_filename_complete_word_point): New.
2457         * completer.h (advance_to_filename_complete_word_point): New
2458         declaration.
2459
2460 2019-06-13  Pedro Alves  <palves@redhat.com>
2461
2462         * compile/compile.c: Include "cli/cli-option.h".
2463         (compile_print_value): Scope data pointer is now a
2464         value_print_options pointer; adjust.
2465         (compile_print_command): Process options.  Scope data pointer is
2466         now a value_print_options pointer; adjust.
2467         (_initialize_compile): Update "compile print"'s help to include
2468         supported options.  Install a completer for "compile print".
2469         * cp-valprint.c (show_vtblprint, show_objectprint)
2470         (show_static_field_print): Delete.
2471         (_initialize_cp_valprint): Don't install "set print
2472         static-members", "set print vtbl", "set print object" here.
2473         * printcmd.c: Include "cli/cli-option.h" and
2474         "common/gdb_optional.h".
2475         (print_command_parse_format): Rework to fill in a
2476         value_print_options instead of a format_data.
2477         (print_value): Change parameter type from format_data pointer to
2478         value_print_options reference.  Adjust.
2479         (print_command_1): Process options.  Adjust to pass down a
2480         value_print_options.
2481         (print_command_completer): New.
2482         (_initialize_printcmd): Install print_command_completer as
2483         handle_brkchars completer for the "print" command.  Update
2484         "print"'s help to include supported options.
2485         * valprint.c: Include "cli/cli-option.h".
2486         (show_vtblprint, show_objectprint, show_static_field_print): Moved
2487         here from cp-valprint.c.
2488         (boolean_option_def, uinteger_option_def)
2489         (value_print_option_defs, make_value_print_options_def_group):
2490         New.  Use gdb::option::add_setshow_cmds_for_options to install
2491         "set print elements", "set print null-stop", "set print repeats",
2492         "set print pretty", "set print union", "set print array", "set
2493         print address", "set print symbol", "set print array-indexes".
2494         * valprint.h: Include <string> and "cli/cli-option.h".
2495         (make_value_print_options_def_group): Declare.
2496         (print_value): Change parameter type from format_data pointer to
2497         value_print_options reference.
2498         (print_command_completer): Declare.
2499
2500 2019-06-13  Pedro Alves  <palves@redhat.com>
2501
2502         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
2503         (COMMON_SFILES): Add maint-test-settings.c.
2504         * cli/cli-decode.c (boolean_enums): New global, factored out from
2505         ...
2506         (add_setshow_boolean_cmd): ... here.
2507         * cli/cli-decode.h (boolean_enums): Declare.
2508         * cli/cli-option.c: New file.
2509         * cli/cli-option.h: New file.
2510         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
2511         factored out from ...
2512         (parse_cli_boolean_value(const char *)): ... this.
2513         (is_unlimited_literal): Change parameter type to pointer to
2514         pointer.  Adjust and advance ARG pointer.
2515         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2516         (parse_cli_var_enum): New, factored out from ...
2517         (do_set_command): ... this.  Adjust.
2518         * cli/cli-setshow.h (parse_cli_boolean_value)
2519         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
2520         (parse_cli_var_enum): Declare.
2521         * cli/cli-utils.c: Include "cli/cli-option.h".
2522         (get_ulongest): New.
2523         * cli/cli-utils.h (get_ulongest): Declare.
2524         (check_for_argument): New overloads.
2525         * maint-test-options.c: New file.
2526
2527 2019-06-13  Pedro Alves  <palves@redhat.com>
2528
2529         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
2530         parse a range if "-" is at the end of the string.
2531
2532 2019-06-13  Pedro Alves  <palves@redhat.com>
2533
2534         * cli/cli-setshow.c (parse_auto_binary_operation)
2535         (parse_cli_boolean_value): Don't allow "o".
2536
2537 2019-06-13  Pedro Alves  <palves@redhat.com>
2538
2539         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
2540         * NEWS: Mention maint test-settings KIND.
2541         * maint-test-settings.c: New file.
2542
2543 2019-06-13  Pedro Alves  <palves@redhat.com>
2544
2545         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
2546         completer.
2547         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
2548         "set" completers.
2549
2550 2019-06-13  Pedro Alves  <palves@redhat.com>
2551
2552         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
2553         after item.
2554
2555 2019-06-13  Pedro Alves  <palves@redhat.com>
2556
2557         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
2558
2559 2019-06-13  Pedro Alves <palves@redhat.com>
2560
2561         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
2562         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
2563         call.
2564         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
2565         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
2566         calls.
2567         (check_for_argument): Skip spaces after argument.
2568
2569 2019-06-13  Pedro Alves  <palves@redhat.com>
2570
2571         * thread.c (thread_apply_command): Adjust TID parsing.
2572         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
2573         detected before end of string.
2574         (tid_is_in_list): Error out if LIST is invalid.
2575
2576 2019-06-13  Pedro Alves  <palves@redhat.com>
2577
2578         * completer.c (complete_line_internal_1): Rewind completion word
2579         point.
2580         (completion_tracker::advance_custom_word_point_by): Change
2581         parameter type to int.
2582         * completer.h (completion_tracker::advance_custom_word_point_by):
2583         Likewise.
2584
2585 2019-06-13  Pedro Alves  <palves@redhat.com>
2586
2587         * completer.c (advance_to_completion_word): Handle delimiters.
2588
2589 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
2590
2591         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
2592
2593 2019-06-11  Tom Tromey  <tom@tromey.com>
2594
2595         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
2596         (xmalloc_failed): Move to alloc.c.
2597         * alloc.c: New file.
2598         * Makefile.in (COMMON_SFILES): Add alloc.c.
2599
2600 2019-06-11  Tom Tromey  <tom@tromey.com>
2601
2602         * nat/linux-waitpid.c: Don't include server.h.
2603         (linux_debug): Remove.
2604         (my_waitpid): Update.
2605
2606 2019-06-11  Tom Tromey  <tromey@adacore.com>
2607
2608         * infcall.c (_initialize_infcall): Remove trailing newline from
2609         help.
2610         * user-regs.c (_initialize_user_regs): Remove trailing newline
2611         from help.
2612         * typeprint.c (_initialize_typeprint): Remove trailing newline
2613         from help.
2614         * reverse.c (_initialize_reverse): Remove trailing newlines from
2615         help.
2616         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
2617         from help.
2618         * language.c (add_set_language_command): Remove trailing newline
2619         from help.
2620         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
2621         help.
2622         * disasm.c (_initialize_disasm): Remove trailing newline from
2623         help.
2624         * top.c (init_main): Remove trailing newline from help.
2625         * interps.c (_initialize_interpreter): Remove trailing newline
2626         from help.
2627         * btrace.c (_initialize_btrace): Remove trailing newlines from
2628         help.
2629         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
2630         from help.
2631         * python/python.c (_initialize_python): Remove trailing newline
2632         from help.
2633         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
2634         help.
2635         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
2636         from help.  Reformat some text.
2637         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
2638         from help.
2639         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
2640         newline from help.
2641
2642 2019-06-11  Tom Tromey  <tromey@adacore.com>
2643
2644         * darwin-nat.c (darwin_decode_exception_message)
2645         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
2646
2647 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2648
2649         * valops.c (value_slice): Check for not allocated or not
2650         associated values.
2651
2652 2019-06-10  Tom de Vries  <tdevries@suse.de>
2653
2654         PR gdb/24618
2655         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
2656         sure an empty slot (defined by a 32-bit zero pair) is recognized as
2657         invalid.
2658
2659 2019-06-10  Tom de Vries  <tdevries@suse.de>
2660
2661         PR gdb/24611
2662         * linespec.c (linespec_lexer_lex_string): Remove incorrect
2663         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
2664
2665 2019-06-10  Tom de Vries  <tdevries@suse.de>
2666
2667         PR symtab/24545
2668         * symtab.c (struct demangled_name_entry): Add language field.
2669         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
2670         static minimal symbol".  Set and use language field.
2671
2672 2019-06-10  Tom Tromey  <tromey@adacore.com>
2673
2674         * ada-lang.c (_initialize_ada_language): Update help text.
2675
2676 2019-06-10  Tom Tromey  <tromey@adacore.com>
2677
2678         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
2679         with a newline.
2680         * guile/guile.c (handle_boot_error): Don't end warning with a
2681         newline.
2682         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
2683         warning with a newline.
2684         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
2685         newline.
2686         (s12z_frame_cache): Likewise.
2687         * dwarf-index-cache.c (index_cache::store): Don't end warning with
2688         a newline.
2689         * solib-svr4.c (disable_probes_interface): Don't end warning with
2690         a newline.
2691         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
2692         newline.
2693         * python/python.c (do_finish_initialization): Don't end warning
2694         with a newline.
2695
2696 2019-06-10  Tom Tromey  <tom@tromey.com>
2697
2698         * python/py-breakpoint.c (gdbpy_breakpoint_created)
2699         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
2700         gdbpy_enter.
2701
2702 2019-06-10  Tom Tromey  <tromey@adacore.com>
2703
2704         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
2705         data.
2706         (elf_new_init): Don't call stabsread_new_init.
2707         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
2708         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
2709         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
2710
2711 2019-06-10  Tom de Vries  <tdevries@suse.de>
2712
2713         PR symtab/16264
2714         PR symtab/24517
2715         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
2716
2717 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
2718
2719         * source.c (find_and_open_source): Also rewrite relative file
2720         names.
2721
2722 2019-04-26  Amos Bird  <amosbird@gmail.com>
2723
2724         * annotate.c (annotate_thread_exited): Add "thread-exited"
2725         annotation.
2726
2727 2019-06-06  Tom Tromey  <tromey@adacore.com>
2728
2729         * maint.h (class scoped_command_stats): Use
2730         DISABLE_COPY_AND_ASSIGN.
2731         <print_time>: New method.
2732         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
2733         print_time.
2734         (scoped_command_stats::print_time): New method.
2735
2736 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
2737
2738         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
2739         instructions of lengths 6 or 8 bytes.
2740
2741 2019-06-04  Pedro Alves  <palves@redhat.com>
2742
2743         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
2744
2745         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
2746         * breakpoint.c (condition_completer): Likewise.
2747         * cli/cli-dump.c (scan_expression): Likewise.
2748         * common/filestuff.c (mkdir_recursive): Likewise.
2749         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
2750         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
2751         (gdb_abspath): Likewise.
2752         * compile/compile-cplus-types.c
2753         (compile_cplus_instance::decl_name): Likewise.
2754         * completer.c (complete_explicit_location):
2755         (signal_completer, reg_or_group_completer_1): Likewise.
2756         * cp-support.c (cp_remove_params_if_any): Likewise.
2757         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
2758         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
2759         * infcmd.c (strip_bg_char): Likewise.
2760         * linespec.c (copy_token_string): Likewise.
2761         * mi/mi-main.c (output_cores): Likewise.
2762         * psymtab.c (psymtab_search_name):
2763         * symfile.c (test_set_ext_lang_command): Likewise.
2764         * target.c (target_fileio_read_stralloc): Likewise.
2765         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
2766         * value.c (complete_internalvar): Likewise.
2767
2768 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
2769
2770         Add objfile property to gdb.Type.
2771         * NEWS: Mention Python API addition.
2772         * python/py-type.c (typy_get_objfile): New method.
2773
2774 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2775
2776         * NEWS: Mention the new set|show style [title|highlight].
2777         Mention changes to "show style", "help" and "apropos".
2778
2779 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2780
2781         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
2782         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
2783         instead of print_help_for_command.
2784         (print_doc_of_command): New function.
2785         (help_list): Add 'apropos -v word' suggestion.
2786         (print_help_for_command): Style the command name using title style.
2787         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
2788         (_initialize_cli_cmds): Describe -v in apropos_command help.
2789
2790 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2791
2792         * cli/cli-style.h (cli_style_option): Add name in constructor,
2793         add m_name class member, add constructor with intensity,
2794         add name class function.
2795         (cli_style_option::add_setshow_commands): Remove name argument.
2796         (highlight_style, title_style): New styles.
2797         * cli/cli-style.c (do_show): New function that shows a style
2798         characteristic styling the style name with itself.
2799         (set_style_name): New function.
2800         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
2801         Update all callers according to the changes in cli/cli-style.h.
2802         * utils.h (fputs_highlighted): New function.
2803         * utils.c (fputs_highlighted): Likewise.
2804
2805 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2806
2807         * NEWS: Mention new pipe command and new convenience variables.
2808
2809 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2810
2811         * cli/cli-cmds.c (pipe_command): New function.
2812         (_initialize_cli_cmds): Call add_com for pipe_command.
2813         Define | as an alias for pipe.
2814         (exit_status_set_internal_vars): New function.
2815         (shell_escape): Call exit_status_set_internal_vars.
2816         cli/cli-decode.c (find_command_name_length): Recognize | as
2817         a single character command.
2818
2819 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2820
2821         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2822         top.c (execute_command_to_ui_file): New function, mostly a copy
2823         of execute_command_to_string.
2824         (execute_command_to_string): Implement by calling
2825         execute_command_to_ui_file.
2826
2827 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2828
2829         * top.h (saved_command_line): Remove declaration.
2830         * top.c (previous_saved_command_line, previous_repeat_arguments):
2831         New variables.
2832         (saved_command_line): Make static, define together with other
2833         'repeat variables'.
2834         (dont_repeat): Clear repeat_arguments.
2835         (repeat_previous, get_saved_command_line, save_command_line):
2836         New functions.
2837         (gdb_init): Initialize saved_command_line
2838         and previous_saved_command_line.
2839         * main.c (captured_main_1): Remove saved_command_line initialization.
2840         * event-top.c (handle_line_of_input): Update to use
2841         the new 'repeat' related functions instead of direct access to
2842         saved_command_line.
2843         * command.h (repeat_previous, get_saved_command_line,
2844         save_command_line): New declarations.
2845         (dont_repeat): Add comment.
2846
2847 2019-05-30  Tom Tromey  <tromey@adacore.com>
2848
2849         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2850         Fix comment.
2851         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2852
2853 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2854
2855         PR cli/24587
2856         * completer.c (complete): Initialize variable word.
2857
2858 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2859
2860         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2861         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2862         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2863         'body' is NULL to the outter 'if', protecting the '!is_define'
2864         situation as well.
2865
2866 2019-05-29  Tom Tromey  <tromey@adacore.com>
2867
2868         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2869         (dwarf_unknown): New function.
2870         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2871         (dwarf_type_encoding_name): Use dwarf_unknown.
2872
2873 2019-05-29  Tom Tromey  <tromey@adacore.com>
2874
2875         PR c++/20020:
2876         * cp-valprint.c (cp_print_value_fields): Call
2877         cp_print_static_field inside "try".
2878
2879 2019-05-29  Tom Tromey  <tromey@adacore.com>
2880
2881         * inflow.c (struct terminal_info): Add default operator=.
2882         * configure: Rebuild.
2883         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2884         -Wdeprecated-copy-dtor, -Wredundant-move.
2885
2886 2019-05-29  Tom Tromey  <tromey@adacore.com>
2887
2888         * NEWS: Add entry.
2889         * infcmd.c (print_return_value_1): Handle finish_print
2890         option.
2891         (show_print_finish): New function.
2892         (_initialize_infcmd): Add "set/show print finish" commands.
2893         * valprint.c (user_print_options): Initialize new member.
2894         * valprint.h (struct value_print_options) <finish_print>: New
2895         member.
2896
2897 2019-05-28  Tom Tromey  <tromey@adacore.com>
2898
2899         * ada-lang.c (ada_remove_Xbn_suffix)
2900         (find_old_style_renaming_symbol)
2901         (parse_old_style_renaming): Remove.
2902         (ada_find_renaming_symbol): Don't call
2903         find_old_style_renaming_symbol.
2904         (ada_is_renaming_symbol): Rename from
2905         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2906         bool.  Now static.
2907         (ada_read_var_value): Update and simplify.
2908         * ada-exp.y (write_var_or_type): Remove old code.
2909
2910 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2911
2912         * event-top.c: Remove include comment.
2913         * inflow.c (class scoped_ignore_sigttou): Move from here...
2914         * inflow.h (class scoped_ignore_sigttou): ...to here.
2915         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2916         * top.c:  Remove include comment.
2917
2918 2019-05-27  Tom Tromey  <tom@tromey.com>
2919
2920         * NEWS: Fix typo.
2921
2922 2019-05-22  Tom Tromey  <tromey@adacore.com>
2923
2924         * target.c (target_follow_exec): Constify parameter.
2925         * target-delegates.c: Rebuild.
2926         * remote.c (remote_target::follow_exec): Constify parameter.
2927         * infrun.c (follow_exec): Constify parameter.
2928         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2929         (target_follow_exec): Likewise.
2930
2931 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2932
2933         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2934         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2935
2936 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2937
2938         * NEWS: Add debugredirect and testsuite sections.
2939
2940 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2941
2942         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2943         target descriptions using exclusively floating point register name
2944         aliases.
2945
2946 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2947
2948         PR gdb/18644:
2949         * f-lang.c (build_fortran_types): Handle the case where
2950         gdbarch_floatformat_for_type returns a nullptr.
2951
2952 2019-05-21  Tom de Vries  <tdevries@suse.de>
2953
2954         PR cli/24587
2955         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2956
2957 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2958
2959         PR gdb/18644:
2960         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2961         16-byte floats.
2962         * i386-tdep.c (i386_floatformat_for_type): Use
2963         floatformats_ia64_quad for the 16-byte floating point component
2964         within a fortran 32-byte complex number.
2965
2966 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2969         delete default constructor.
2970         (find_partial_die): Update to return const struct.
2971         (partial_die_parent_scope): Move variable declaration into scope
2972         of its use and change its type to auto.
2973         (guess_partial_die_structure_name): Likewise.
2974         (partial_die_info::fixup): Likewise.
2975
2976 2019-05-17  Tom Tromey  <tromey@adacore.com>
2977
2978         * source.c (find_and_open_source): Remove cast.
2979
2980 2019-05-17  Tom Tromey  <tromey@adacore.com>
2981
2982         * annotate.c (annotate_source): Make "filename" const.
2983         * annotate.h (annotate_source): Use const.
2984
2985 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2986
2987         * disasm.c (set_disassembler_options): Send errors to stderr.
2988
2989 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2990
2991         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2992         (cli_interp_base::set_logging): Check debug_redirect.
2993         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2994         * cli/cli-logging.c (debug_redirect): Add static variable.
2995         (pop_output_files): Add default param.
2996         (handle_redirections): Print debug setting.
2997         (show_logging_command): Likewise.
2998         (_initialize_cli_logging): Add debugredirect command.
2999         * interps.c (current_interp_set_logging): Add debug_redirect
3000         parameter.
3001         * interps.h (set_logging): Add debug_redirect parameter.
3002         (current_interp_set_logging): Likewise.
3003         * mi/mi-common.h: Likewise.
3004         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
3005
3006 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
3007             Tom Tromey  <tromey@adacore.com>
3008
3009         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
3010         directly.
3011         * cli/cli-interp.h (make_logging_output): Remove declaration.
3012         * cli/cli-logging.c (make_logging_output): Remove function.
3013         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
3014         directly.
3015         * ui-file.c (tee_file::tee_file): Remove bools.
3016         (tee_file::~tee_file): Remove deletes.
3017         * ui-file.h (tee_file): Remove bools.
3018
3019 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
3020
3021         * mi/mi-cmds.h (mi_cmd_complete): New function.
3022         * mi/mi-main.c (mi_cmd_complete): Likewise.
3023         * mi/mi-cmds.c: Define new MI command -complete.
3024         * NEWS: Mention new -complete command.
3025
3026 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
3027
3028         * completer.h (complete): New function.
3029         * completer.c (complete): Likewise.
3030         * cli/cli-cmds.c: (complete_command): Update to use new complete()
3031         function defined in completer.h.
3032
3033 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
3034
3035         * MAINTAINERS (Write After Approval): Add myself.
3036
3037 2019-05-17  Tom de Vries  <tdevries@suse.de>
3038
3039         PR gdb/24094
3040         * dwarf2read.c (struct cu_partial_die_info): New struct.
3041         (find_partial_die): Return cu_partial_die_info.
3042         (partial_die_parent_scope, guess_partial_die_structure_name)
3043         (partial_die_info::fixup): Handle new return type of find_partial_die.
3044
3045 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3046
3047         * stap-probe.c (stap_parse_register_operand): Make "regname" an
3048         "std::string", simplifying the algorithm.
3049
3050 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3051
3052         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
3053         (stap_static_probe_ops::get_probes): Likewise.
3054
3055 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3056
3057         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
3058         '-')" and "else if".
3059         (stap_parse_single_operand): Join checks for
3060         "gdbarch_stap_parse_special_token_p" and
3061         "gdbarch_stap_parse_special_token" in the same "if" statement.
3062         Invert check when verifying for operation on register
3063         displacement.
3064
3065 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3066
3067         * stap-probe.c (stap_get_opcode): Update comment.
3068         (stap_get_expected_argument_type): Likewise.
3069         (handle_stap_probe): Likewise.
3070
3071 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
3072
3073         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
3074         return type to 'bool'.  Adjust comment.  Use 'bool' when
3075         appropriate.
3076         (i386_stap_parse_special_token_three_arg_disp): Likewise.
3077         * stap-probe.c (stap_parse_argument_1): Likewise.
3078         (stap_is_operator): Likewise.
3079         (stap_is_generic_prefix): Likewise.
3080         (stap_is_register_prefix): Likewise.
3081         (stap_is_register_indirection_prefix): Likewise.
3082         (stap_is_integer_prefix): Likewise.
3083         (stap_generic_check_suffix): Likewise.
3084         (stap_check_integer_suffix): Likewise.
3085         (stap_check_register_suffix): Likewise.
3086         (stap_check_register_indirection_suffix): Likewise.
3087         (stap_parse_register_operand): Likewise.
3088         (stap_parse_single_operand): Likewise.
3089         (stap_parse_argument_1): Likewise.
3090         (stap_probe::get_argument_count): Likewise.
3091         (stap_is_operator): Likewise.
3092
3093 2019-05-16  Tom Tromey  <tromey@adacore.com>
3094
3095         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
3096         keyword to foreach.
3097
3098 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
3099
3100         * linux-thread-db.c (try_thread_db_load_1): Change return type
3101         to bool.
3102         (try_thread_db_load): Likewise.
3103         (try_thread_db_load_from_pdir_1): Likewise.
3104         (try_thread_db_load_from_pdir): Likewise.
3105         (try_thread_db_load_from_sdir): Likewise.
3106         (try_thread_db_load_from_dir): Likewise.
3107         (thread_db_load_search): Likewise.
3108         (has_libpthread): Likewise.
3109         (thread_db_load): Likewise.
3110
3111 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
3112
3113         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
3114         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
3115         NULL, and complain/return if that's the case.
3116
3117 2019-05-15  John Darrington <john@darrington.wattle.id.au>
3118
3119         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
3120         (advance, posn, abstract_read_memory): New functions.
3121         [struct mem_read_abstraction]: New struct.
3122         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
3123
3124 2019-05-14  Tom Tromey  <tromey@adacore.com>
3125
3126         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
3127         value is not lval_memory.
3128
3129 2019-05-14  Tom Tromey  <tromey@adacore.com>
3130
3131         * solib.c (info_sharedlibrary_command): Style the file name.
3132
3133 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
3134
3135         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
3136         (aarch64_vnv_type): Likewise.
3137         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
3138         * common/tdesc.c: Likewise.
3139         * common/tdesc.h (enum tdesc_type_kind): Likewise.
3140         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
3141         * features/aarch64-fpu.xml: Add ieee half view.
3142         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
3143         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
3144         * gdbtypes.h (struct builtin_type): Likewise.
3145         (struct objfile_type): Likewise.
3146
3147 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
3148
3149         * language.c (language_sniff_from_mangled_name): Fix "langauge"
3150         typo.
3151         * location.h (string_to_event_location): Likewise.
3152
3153 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
3154
3155         GDB 8.3 released.
3156
3157 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3158
3159         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
3160         New variable declaration.
3161         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
3162         New variable.
3163         (print_one_breakpoint): Use ui_out::test_flags and new global
3164         variable to compute use_fixed_output.
3165         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
3166         Remove.
3167         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
3168         (mi_multi_location_breakpoint_output_fixed): Remove.
3169         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
3170         new variable.
3171         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
3172         fix_multi_location_breakpoint_output flag if version >= 3.
3173         * ui-out.h (enum ui_out_flag)
3174         <fix_multi_location_breakpoint_output>: New enumerator.
3175
3176 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
3177
3178         * contrib/cc-with-tweaks.sh: Validate dwz's work.
3179
3180 2019-05-10  Tom Tromey  <tromey@adacore.com>
3181
3182         * ada-lang.c (catch_ada_completer): New function.
3183         (_initialize_ada_language): Use it.
3184
3185 2019-05-10  Tom Tromey  <tromey@adacore.com>
3186
3187         * thread.c (print_thread_info): Make "requested_threads" const.
3188         * gdbthread.h (print_thread_info): Make "requested_threads"
3189         const.
3190         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
3191         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
3192
3193 2019-05-08  Tom Tromey  <tom@tromey.com>
3194
3195         * gdbtypes.c (objfile_type_data): Change type.
3196         (objfile_type, _initialize_gdbtypes): Update.
3197
3198 2019-05-08  Tom Tromey  <tom@tromey.com>
3199
3200         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
3201         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
3202         (_initialize_dwarf2_frame): Update.
3203
3204 2019-05-08  Tom Tromey  <tom@tromey.com>
3205
3206         * objc-lang.c (objc_objfile_data): Change type.
3207         (find_methods): Update.
3208         (_initialize_objc_lang): Remove.
3209
3210 2019-05-08  Tom Tromey  <tom@tromey.com>
3211
3212         * stabsread.c (rs6000_builtin_type_data): Change type.
3213         (rs6000_builtin_type, _initialize_stabsread): Update.
3214
3215 2019-05-08  Tom Tromey  <tom@tromey.com>
3216
3217         * mips-tdep.c (mips_pdr_data): Remove.
3218         (_initialize_mips_tdep): Update.
3219
3220 2019-05-08  Tom Tromey  <tom@tromey.com>
3221
3222         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
3223         (hppa_init_objfile_priv_data, read_unwind_info)
3224         (find_unwind_entry, _initialize_hppa_tdep): Update.
3225
3226 2019-05-08  Tom Tromey  <tom@tromey.com>
3227
3228         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
3229         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
3230         on obstack.
3231         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
3232
3233 2019-05-08  Tom Tromey  <tom@tromey.com>
3234
3235         * mdebugread.c (basic_type_data): Change type.
3236         (basic_type, _initialize_mdebugread): Update.
3237
3238 2019-05-08  Tom Tromey  <tom@tromey.com>
3239
3240         * common/gdb_unique_ptr.h (struct noop_deleter): New.
3241
3242 2019-05-08  Tom Tromey  <tom@tromey.com>
3243
3244         * nto-tdep.c (nto_inferior_data_reg): Change type.
3245         (nto_inferior_data): Update.
3246         (nto_inferior_data_cleanup, nto_new_inferior_data)
3247         (_initialize_nto_tdep): Remove.
3248         * nto-tdep.h (struct nto_inferior_data): Add initializers.
3249
3250 2019-05-08  Tom Tromey  <tom@tromey.com>
3251
3252         * ada-lang.c (struct ada_inferior_data): Add initializers.
3253         (ada_inferior_data): Change type.
3254         (ada_inferior_data_cleanup): Remove.
3255         (get_ada_inferior_data, ada_inferior_exit)
3256         (struct ada_pspace_data): Add initializers, destructor.
3257         (ada_pspace_data_handle): Change type.
3258         (get_ada_pspace_data): Update.
3259         (ada_pspace_data_cleanup): Remove.
3260
3261 2019-05-08  Tom Tromey  <tom@tromey.com>
3262
3263         * coffread.c (struct coff_symfile_info): Add initializers.
3264         (coff_objfile_data_key): Move lower.  Change type.
3265         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
3266         Update.
3267         (coff_free_info): Remove.
3268
3269 2019-05-08  Tom Tromey  <tom@tromey.com>
3270
3271         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
3272         (fbsd_pspace_data_handle): Move lower.  Change type.
3273         (get_fbsd_pspace_data): Update.
3274         (fbsd_pspace_data_cleanup): Remove.
3275         (_initialize_fbsd_tdep): Update.
3276
3277 2019-05-08  Tom Tromey  <tom@tromey.com>
3278
3279         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
3280         (get_ada_tasks_pspace_data): Update.
3281         (ada_tasks_pspace_data_cleanup): Remove.
3282         (_initialize_tasks): Update.
3283         (ada_tasks_inferior_data_handle): Change type.
3284         (get_ada_tasks_inferior_data): Update.
3285         (ada_tasks_inferior_data_cleanup): Remove.
3286         (struct ada_tasks_pspace_data): Add initializers.
3287
3288 2019-05-08  Tom Tromey  <tom@tromey.com>
3289
3290         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
3291         * symfile-debug.c (debug_sym_get_probes): Change type.
3292         * stap-probe.c (handle_stap_probe):
3293         (stap_static_probe_ops::get_probes): Change type.
3294         * probe.h (class static_probe_ops) <get_probes>: Change type.
3295         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
3296         (parse_probes_in_pspace): Update.
3297         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
3298         Update.
3299         (any_static_probe_ops::get_probes): Change type.
3300         * elfread.c (elfread_data): New typedef.
3301         (probe_key): Change type.
3302         (elf_get_probes): Likewise.  Update.
3303         (probe_key_free): Remove.
3304         (_initialize_elfread): Update.
3305         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
3306         Change type.
3307         (dtrace_process_dof_probe, dtrace_process_dof)
3308         (dtrace_static_probe_ops::get_probe): Change type.
3309
3310 2019-05-08  Tom Tromey  <tom@tromey.com>
3311
3312         * xcoffread.c (struct xcoff_symfile_info): Rename from
3313         coff_symfile_info.  Add initializers.
3314         (xcoff_objfile_data_key): Move lower.  Change type.
3315         (XCOFF_DATA): Rewrite.
3316         (xcoff_free_info): Remove.
3317         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
3318         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
3319         (xcoff_initial_scan): Update.
3320
3321 2019-05-08  Tom Tromey  <tom@tromey.com>
3322
3323         * solib-svr4.c (struct svr4_info): Add initializers and
3324         destructor.
3325         <probes_table>: Now an htab_up.
3326         (solib_svr4_pspace_data): Change type.
3327         (free_probes_table): Simplify.
3328         (~svr4_info): Rename from svr4_pspace_data_cleanup.
3329         (get_svr4_info, probes_table_htab_remove_objfile_probes)
3330         (probes_table_remove_objfile_probes, register_solib_event_probe)
3331         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
3332         (_initialize_svr4_solib): Update.
3333
3334 2019-05-08  Tom Tromey  <tom@tromey.com>
3335
3336         * remote.c (remote_pspace_data): Change type.
3337         (remote_pspace_data_cleanup): Remove.
3338         (get_remote_exec_file, set_pspace_remote_exec_file)
3339         (_initialize_remote): Update.
3340
3341 2019-05-08  Tom Tromey  <tom@tromey.com>
3342
3343         * breakpoint.c (breakpoint_objfile_key): Change type.
3344         (get_breakpoint_objfile_data): Update.
3345         (free_breakpoint_objfile_data): Remove.
3346         (_initialize_breakpoint): Update.
3347
3348 2019-05-08  Tom Tromey  <tom@tromey.com>
3349
3350         * linux-tdep.c (struct linux_info): Add initializers.
3351         (linux_inferior_data): Move.  Change type.
3352         (invalidate_linux_cache_inf): Update.
3353         (linux_inferior_data_cleanup): Remove.
3354         (get_linux_inferior_data, _initialize_linux_tdep): Update.
3355
3356 2019-05-08  Tom Tromey  <tom@tromey.com>
3357
3358         * auxv.c (auxv_inferior_data): Move.  Change type.
3359         (auxv_inferior_data_cleanup): Remove.
3360         (invalidate_auxv_cache_inf): Rewrite.
3361         (get_auxv_inferior_data, _initialize_auxv): Update.
3362
3363 2019-05-08  Tom Tromey  <tom@tromey.com>
3364
3365         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
3366         (symfile_debug_objfile_data_key): Change type.
3367         (symfile_debug_installed, debug_qf_has_symbols)
3368         (debug_qf_find_last_source_symtab)
3369         (debug_qf_forget_cached_source_info)
3370         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
3371         (debug_qf_print_stats, debug_qf_dump)
3372         (debug_qf_expand_symtabs_for_function)
3373         (debug_qf_expand_all_symtabs)
3374         (debug_qf_expand_symtabs_with_fullname)
3375         (debug_qf_map_matching_symbols)
3376         (debug_qf_expand_symtabs_matching)
3377         (debug_qf_find_pc_sect_compunit_symtab)
3378         (debug_qf_map_symbol_filenames)
3379         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
3380         (debug_sym_new_init, debug_sym_init, debug_sym_read)
3381         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
3382         (debug_sym_read_linetable, debug_sym_relocate): Update.
3383         (symfile_debug_free_objfile): Remove.
3384         (install_symfile_debug_logging, _initialize_symfile_debug):
3385         Update.
3386
3387 2019-05-08  Tom Tromey  <tom@tromey.com>
3388
3389         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
3390         allocate_on_obstack.
3391         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
3392         (get_dwarf2_per_objfile): Update.
3393         (set_dwarf2_per_objfile): Remove.
3394         (dwarf2_has_info, dwarf2_get_section_info): Update.
3395         (dwarf2_free_objfile): Remove.
3396         (_initialize_dwarf2_read): Update.
3397
3398 2019-05-08  Tom Tromey  <tom@tromey.com>
3399
3400         * auto-load.c (struct auto_load_pspace_info): Add destructor and
3401         initializers.
3402         <unsupported_script_warning_printed,
3403         script_not_found_warning_printed>: Now bool.
3404         (auto_load_pspace_data): Change type.
3405         (~auto_load_pspace_info): Rename from
3406         auto_load_pspace_data_cleanup.
3407         (get_auto_load_pspace_data, init_loaded_scripts_info)
3408         (clear_section_scripts, maybe_print_unsupported_script_warning)
3409         (maybe_print_script_not_found_warning, _initialize_auto_load):
3410         Update.
3411
3412 2019-05-08  Tom Tromey  <tom@tromey.com>
3413
3414         * objfiles.c (objfile_pspace_info): Add destructor and
3415         initializers.
3416         (objfiles_pspace_data): Change type.
3417         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
3418         (get_objfile_pspace_data): Update.
3419         (objfiles_bfd_data): Change type.
3420         (get_objfile_bfd_data): Update.
3421         (objfile_bfd_data_free, _initialize_objfiles): Remove.
3422
3423 2019-05-08  Tom Tromey  <tom@tromey.com>
3424
3425         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
3426         Change type.
3427         (get_catch_syscall_inferior_data): Update.
3428         (catch_syscall_inferior_data_cleanup): Remove.
3429         (_initialize_break_catch_syscall): Update.
3430
3431 2019-05-08  Tom Tromey  <tom@tromey.com>
3432
3433         * inflow.c (struct terminal_info): Add destructor and
3434         initializers.
3435         (inflow_inferior_data): Change type.
3436         (~terminal_info): Rename from inflow_inferior_data_cleanup.
3437         (get_inflow_inferior_data, inflow_inferior_exit)
3438         (swap_terminal_info, _initialize_inflow): Update.
3439
3440 2019-05-08  Tom Tromey  <tom@tromey.com>
3441
3442         * target-dcache.c (target_dcache_cleanup): Remove.
3443         (target_dcache_aspace_key): Change type.
3444         (target_dcache_init_p, target_dcache_invalidate)
3445         (target_dcache_get, target_dcache_get_or_init)
3446         (_initialize_target_dcache): Update.
3447         * dcache.h (struct dcache_deleter): New.
3448
3449 2019-05-08  Tom Tromey  <tom@tromey.com>
3450
3451         * symtab.c (struct symbol_cache): Add destructor and
3452         initializers.
3453         (symbol_cache_key): Move.  Change type.
3454         (make_symbol_cache, free_symbol_cache): Remove.
3455         (get_symbol_cache): Update.
3456         (symbol_cache_cleanup): Remove.
3457         (ALL_PSPACES, symbol_cache_flush)
3458         (maintenance_print_symbol_cache)
3459         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
3460         Update.
3461
3462 2019-05-08  Tom Tromey  <tom@tromey.com>
3463
3464         * symtab.c (struct main_info): Add destructor and initializers.
3465         (main_progspace_key): Move.  Change type.
3466         (get_main_info): Update.
3467         (main_info_cleanup): Remove.
3468         (_initialize_symtab): Update.
3469
3470 2019-05-08  Tom Tromey  <tom@tromey.com>
3471
3472         * registry.h (DECLARE_REGISTRY): Define the _key class.
3473
3474 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
3475
3476         * NEWS: Merge two 'New commands' sections.
3477
3478 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
3479
3480         * ada-valprint.c (ada_val_print_gnat_array): Remove language
3481         parameter and use Ada language definition instead.
3482         (ada_val_print_ptr): Remove unused language parameter.
3483         (ada_val_print_num): Remove language parameter and use Ada language
3484         definition instead.
3485         (ada_val_print_enum, ada_val_print_flt): Remove unused language
3486         parameter.
3487         (ada_val_print_struct_union, ada_val_print_ref): Remove language
3488         parameter and use Ada language definition instead.
3489         (ada_val_print_1): Update all ada_val_print_xxx calls.
3490         Remove language parameter.
3491         (ada_val_print): Update ada_val_print_1 call.
3492
3493 2019-05-08  Tom Tromey  <tromey@adacore.com>
3494
3495         * remote.c (remote_hw_watchpoint_limit)
3496         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
3497         Now static.
3498
3499 2019-05-08  Tom Tromey  <tromey@adacore.com>
3500
3501         * maint.c (_initialize_maint_cmds): Move initialization code to
3502         remote.c.
3503         (watchdog, show_watchdog): Move to remote.c.
3504         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
3505         "watchdog" static.
3506         (_initialize_remote): Move initialization code from maint.c.
3507         * defs.h (watchdog): Don't declare.
3508
3509 2019-05-08  Tom Tromey  <tromey@adacore.com>
3510
3511         * tui/tui-interp.c: Include main.h.
3512         * interps.c: Include main.h.
3513         * main.h (interpreter_p): Declare.
3514         * defs.h (interpreter_p): Don't declare.
3515
3516 2019-05-08  Tom Tromey  <tromey@adacore.com>
3517
3518         * dwarf2loc.c: Include dwarf2read.h.
3519         * defs.h (read_unsigned_leb128): Don't declare.
3520         * dwarf2read.h (read_unsigned_leb128): Declare.
3521
3522 2019-05-08  Tom Tromey  <tromey@adacore.com>
3523
3524         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
3525         method.
3526
3527 2019-05-08  Tom Tromey  <tromey@adacore.com>
3528
3529         * utils.c (fputs_maybe_filtered): Reset style after paging, even
3530         when no wrap column is set.
3531
3532 2019-05-08  Tom Tromey  <tromey@adacore.com>
3533
3534         * c-lang.c (c_get_string): Handle non-C-style arrays.
3535
3536 2019-05-08  Tom Tromey  <tromey@adacore.com>
3537
3538         * typeprint.c (print_offset_data::update): Print the bit offset,
3539         not the number of bits remaining.
3540
3541 2019-05-08  Tom Tromey  <tromey@adacore.com>
3542
3543         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
3544         padding at end of comment.
3545
3546 2019-05-08  Tom Tromey  <tromey@adacore.com>
3547
3548         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
3549         Compare main types.
3550
3551 2019-05-06  Tom Tromey  <tom@tromey.com>
3552
3553         * common/scoped_mmap.c: Include common-defs.h.
3554         * common/scoped_mmap.h: Don't include config.h.
3555
3556 2019-05-04  Tom Tromey  <tom@tromey.com>
3557
3558         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
3559         (struct aarch64_call_info): Add initializers.
3560         <si>: Now a std::vector.
3561         (pass_on_stack, aarch64_push_dummy_call): Update.
3562
3563 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
3564             Tom Tromey  <tom@tromey.com>
3565
3566         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
3567         (ppc_threads): Now a std::vector.  Now static.
3568         (hwdebug_find_thread_points_by_tid)
3569         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
3570         Update.
3571
3572 2019-05-04  Tom Tromey  <tom@tromey.com>
3573
3574         * arc-tdep.c (arc_tdesc_init): Return bool.
3575
3576 2019-05-04  Tom Tromey  <tom@tromey.com>
3577
3578         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
3579         Use gdb_assert_not_reached.
3580
3581 2019-05-04  Tom Tromey  <tom@tromey.com>
3582
3583         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
3584         "false".
3585
3586 2019-05-04  Tom Tromey  <tom@tromey.com>
3587
3588         * arc-tdep.c (arc_tdesc_init): Use bool.
3589
3590 2019-05-04  Tom Tromey  <tom@tromey.com>
3591
3592         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
3593
3594 2019-05-04  Tom Tromey  <tom@tromey.com>
3595
3596         * cli/cli-cmds.c (valid_command_p): Return bool.
3597
3598 2019-05-04  Tom Tromey  <tom@tromey.com>
3599
3600         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
3601         * command.h (valid_user_defined_cmd_name_p): Channge return type.
3602
3603 2019-05-04  Raul Tambre  <raul@tambre.ee>
3604
3605         * python/lib/gdb/prompt.py (_ExtendedPrompt)
3606         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
3607         operator for comparison.
3608
3609 2019-05-04  Tom Tromey  <tom@tromey.com>
3610
3611         * psymtab.c (psymbol_name_matches, match_partial_symbol)
3612         (lookup_partial_symbol, print_partial_symbols)
3613         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
3614         (psymbol_compare): Update.
3615         (add_psymbol_to_bcache): Clear the entire psymbol.
3616         (maintenance_check_psymtabs): Update.
3617         * psympriv.h (struct partial_symbol): Don't derive from
3618         general_symbol_info.
3619         <obj_section, unrelocated_address, address,
3620         set_unrelocated_address>: Update.
3621         <ginfo>: New member.
3622         * dwarf-index-write.c (write_psymbols, debug_names::insert)
3623         (debug_names::write_psymbols): Update.
3624
3625 2019-05-04  Tom de Vries  <tdevries@suse.de>
3626
3627         * contrib/cc-with-tweaks.sh: Support -n arg.
3628
3629 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3630
3631         * corelow.c (core_target::detach): Ensure frame cache and
3632         register caches are cleared.
3633         inferior.c (exit_inferior_1): Likewise.
3634
3635 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
3636             Tom Tromey  <tom@tromey.com>
3637
3638         * dictionary.c (collate_pending_symbols_by_language): Remove
3639         "struct" from foreach.
3640         * symtab.c (lookup_global_symbol_from_objfile)
3641         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
3642         foreach.
3643         * ser-tcp.c (net_open): Remove "struct" from foreach.
3644         * objfiles.c (objfile_relocate, objfile_rebase)
3645         (objfile_has_symbols): Remove "struct" from foreach.
3646         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
3647         from foreach.
3648         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
3649         foreach.
3650         * darwin-nat.c (thread_info_from_private_thread_info): Remove
3651         "struct" from foreach.
3652         * ada-lang.c (create_excep_cond_exprs)
3653         (ada_exception_catchpoint_cond_string): Remove "struct" from
3654         foreach.
3655
3656 2019-05-03  Tom Tromey  <tromey@adacore.com>
3657
3658         * ada-exp.y (convert_char_literal): Check suffix of each
3659         enumerator.
3660
3661 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
3662
3663         PR ada/21406:
3664         * ada-exp.y (yywrap): Don't define.
3665         * ada-lex.l (%option): Add noyywrap
3666         (yywrap): Remove.
3667
3668 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
3669
3670         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
3671         _WIN32_WINNT to the XP level, unless already defined to a higher
3672         level.
3673
3674         * unittests/parse-connection-spec-selftests.c:
3675         * ser-tcp.c:
3676         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
3677         override.
3678
3679         * symfile.c (find_separate_debug_file): Remove colon from the
3680         drive spec of DOS/Windows file names of the target, so that the
3681         file name produced from DEBUGDIR and the target's directory will
3682         be valid on DOS/Windows systems.
3683
3684 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3685
3686         * rust-lang.c (val_print_struct): Handle printing structures
3687         containing strings.
3688
3689 2019-05-02  Tom Tromey  <tromey@adacore.com>
3690
3691         * valarith.c (_initialize_valarith): Remove.
3692
3693 2019-05-01  Tom Tromey  <tromey@adacore.com>
3694
3695         * ada-lang.c (ada_value_primitive_field): Treat more fields as
3696         bitfields.
3697
3698 2019-05-01  Tom Tromey  <tromey@adacore.com>
3699
3700         * ada-lang.c (ada_value_assign): Correctly compute starting offset
3701         for big-endian copies.
3702
3703 2019-04-30  Ali Tamur  <tamur@google.com>
3704         * gdb/dwarf2read.c (read_3_bytes): New declaration.
3705         (read_attribute_value): Added DW_FORM_strx1-4 cases.
3706         (read_3_bytes): New function.
3707
3708 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3709
3710         * windows-nat.c (main_thread_id): Delete.
3711         (handle_output_debug_string): Replace main_thread_id by
3712         current_event.dwThreadId.
3713         (fake_create_process): Likewise.
3714         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
3715         Do not set main_thread_id.
3716         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
3717         current_event.dwThreadId.
3718         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
3719
3720 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
3721
3722         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
3723         Use current_event.dwThreadId instead of main_thread_id.
3724
3725 2019-04-30  Tom Tromey  <tromey@adacore.com>
3726
3727         * ada-lang.c (ada_lookup_simple_minsyms): New function.
3728         (create_excep_cond_exprs): Iterate over program spaces.
3729         (ada_exception_catchpoint_cond_string): Examine all minimal
3730         symbols for exception types.
3731
3732 2019-04-30  Tom Tromey  <tromey@adacore.com>
3733
3734         PR c++/24470:
3735         * dwarf2read.c (process_structure_scope): Handle case where type
3736         has template parameters but no symbol was created.
3737
3738 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3739             Chris January  <chris.january@arm.com>
3740
3741         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
3742         qualifier.
3743         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
3744
3745 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3746
3747         * f-typeprint.c (f_print_type): Update rules for printing
3748         whitespace.
3749         (f_type_print_varspec_suffix): Likewise.
3750
3751 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3752             Chris January  <chris.january@arm.com>
3753
3754         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
3755         function arguments.
3756
3757 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3758
3759         * f-lang.c (build_fortran_types): Change name of void type to
3760         lower case.
3761         * f-typeprint.c (f_type_print_base): Print the name of the void
3762         type, rather than a fixed string.
3763         * f-valprint.c (f_decorations): Use lower case void string.
3764
3765 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3766             Chris January  <chris.january@arm.com>
3767
3768         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
3769         types for Fortran.
3770
3771 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3772             Chris January  <chris.january@arm.com>
3773             David Lecomber  <david.lecomber@arm.com>
3774
3775         * f-exp.y (BINOP_INTRINSIC): New token.
3776         (exp): New parser rule handling BINOP_INTRINSIC.
3777         (f77_keywords): Add new builtin procedures.
3778         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
3779         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3780         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
3781         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3782         (print_unop_subexp_f): New function.
3783         (print_binop_subexp_f): New function.
3784         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3785         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
3786         (dump_subexp_body_f): Likewise.
3787         (operator_check_f): Likewise.
3788         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
3789         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
3790
3791 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3792
3793         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
3794         UNOP_KIND.
3795         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
3796         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
3797         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
3798         (operator_length_f): New fuction.
3799         (print_subexp_f): New function.
3800         (op_name_f): New function.
3801         (dump_subexp_body_f): New function.
3802         (operator_check_f): New function.
3803         (exp_descriptor_f): Replace standard expression handling functions
3804         with new functions.
3805         * gdb/fortran-operator.def: New file.
3806         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
3807         * gdb/std-operator.def: Remove UNOP_KIND.
3808
3809 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3810
3811         * std-operator.def: Remove unbalanced, stray double quote
3812         character.
3813
3814 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3815             Chris January  <chris.january@arm.com>
3816             Daniel Everett  <daniel.everett@arm.com>
3817             Nick Forrington  <nick.forrington@arm.com>
3818             Richard Bunt  <richard.bunt@arm.com>
3819
3820         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3821         of depth when printing anonymous structs or unions.
3822         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3823         Don't print either the top-level value, or the children if the
3824         max-depth is exceeded.
3825         (ppscm_print_children): When printing the key of a map, allow one
3826         extra level of depth.
3827         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3828         print either the top-level value, or the children if the max-depth
3829         is exceeded.
3830         (print_children): When printing the key of a map, allow one extra
3831         level of depth.
3832         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3833         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3834         (user_print_options): Initialise max_depth field.
3835         (val_print_scalar_or_string_type_p): New function.
3836         (val_print): Check to see if the max depth has been reached.
3837         (val_print_check_max_depth): Define new function.
3838         (show_print_max_depth): New function.
3839         (_initialize_valprint): Add 'print max-depth' option.
3840         * valprint.h (struct value_print_options) <max_depth>: New field.
3841         (val_print_check_max_depth): Declare new function.
3842         * NEWS: Document new feature.
3843
3844 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3845
3846         * ada-lang.c (ada_language_defn): Initialise new field.
3847         * c-lang.c (c_is_string_type_p): New function.
3848         (c_language_defn): Initialise new field.
3849         (cplus_language_defn): Initialise new field.
3850         (asm_language_defn): Initialise new field.
3851         (minimal_language_defn): Initialise new field.
3852         * c-lang.h (c_is_string_type_p): Declare new function.
3853         * d-lang.c (d_language_defn): Initialise new field.
3854         * f-lang.c (f_is_string_type_p): New function.
3855         (f_language_defn): Initialise new field.
3856         * go-lang.c (go_is_string_type_p): New function.
3857         (go_language_defn): Initialise new field.
3858         * language.c (default_is_string_type_p): New function.
3859         (unknown_language_defn): Initialise new field.
3860         (auto_language_defn): Initialise new field.
3861         * language.h (struct language_defn) <la_is_string_type_p>: New
3862         member variable.
3863         (default_is_string_type_p): Declare new function.
3864         * m2-lang.c (m2_language_defn): Initialise new field.
3865         * objc-lang.c (objc_language_defn): Initialise new field.
3866         * opencl-lang.c (opencl_language_defn): Initialise new field.
3867         * p-lang.c (pascal_is_string_type_p): New function.
3868         (pascal_language_defn): Initialise new field.
3869         * rust-lang.c (rust_is_string_type_p): New function.
3870         (rust_language_defn): Initialise new field.
3871
3872 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3873
3874         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3875         New field.
3876         * ada-lang.c (ada_language_defn): Initialise new field.
3877         * c-lang.c (c_language_defn): Likewise.
3878         (cplus_language_defn): Likewise.
3879         (asm_language_defn): Likewise.
3880         (minimal_language_defn): Likewise.
3881         * d-lang.c (d_language_defn): Likewise.
3882         * f-lang.c (f_language_defn): Likewise.
3883         * go-lang.c (go_language_defn): Likewise.
3884         * language.c (unknown_language_defn): Likewise.
3885         (auto_language_defn): Likewise.
3886         * m2-lang.c (m2_language_defn): Likewise.
3887         * objc-lang.c (objc_language_defn): Likewise.
3888         * opencl-lang.c (opencl_language_defn): Likewise.
3889         * p-lang.c (pascal_language_defn): Likewise.
3890         * rust-lang.c (rust_language_defn): Likewise.
3891
3892 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * ada-lang.c (ada_is_character_type): Change return type to bool.
3895         (ada_is_string_type): Likewise.
3896         * ada-lang.h (ada_is_character_type): Update declaration
3897         (ada_is_string_type): Likewise.
3898
3899 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3900
3901         Support style in 'frame|thread apply'
3902
3903         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3904         * record.c (record_start, record_stop): Update callers of
3905         execute_command_to_string with false.
3906         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3907         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3908         methods.
3909         (class string_file): New constructor with term_out parameter.
3910         Override methods term_out and can_emit_style_escape.  New member
3911         term_out.
3912         (class stdio_file): Override can_emit_style_escape.
3913         (class tee_file): Override term_out and can_emit_style_escape.
3914         * utils.h (can_emit_style_escape): Remove.
3915         * utils.c (can_emit_style_escape): Likewise.
3916         Update all callers of can_emit_style_escape (SOMESTREAM) to
3917         SOMESTREAM->can_emit_style_escape.
3918         * source-cache.c (source_cache::get_source_lines): Likewise.
3919         * stack.c (frame_apply_command_count): Call execute_command_to_string
3920         passing the term_out characteristic of the current gdb_stdout.
3921         * thread.c (thr_try_catch_cmd): Likewise.
3922         * top.c (execute_command_to_string): pass term_out parameter
3923         to construct the string_file for the command output.
3924         * ui-file.c (term_cli_styling): New function (most code moved
3925         from utils.c can_emit_style_escape).
3926         (string_file::string_file, string_file::can_emit_style_escape,
3927         stdio_file::can_emit_style_escape, tee_file::term_out,
3928         tee_file::can_emit_style_escape): New functions.
3929
3930 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3931
3932         * NEWS: Mention the new set|show may-call-functions.
3933         * infcall.c (may_call_functions_p): New variable.
3934         (show_may_call_functions_p): New function.
3935         (call_function_by_hand_dummy): Throws an error if not
3936         may-call-functions.
3937         (_initialize_infcall): Call add_setshow_boolean_cmd for
3938         may-call-functions.
3939
3940 2019-04-25  Keith Seitz  <keiths@redhat.com>
3941
3942         PR c++/24367
3943         * cp-support.c (inspect_type): Don't attempt substitutions
3944         of symbol with the same name.
3945
3946 2019-04-25  Tom Tromey  <tromey@adacore.com>
3947
3948         PR gdb/24475:
3949         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3950         static.
3951
3952 2019-04-25  Tom Tromey  <tromey@adacore.com>
3953
3954         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3955         rvalue reference.
3956         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3957         (gdb_xml_parser::parse): Use std::move.
3958         * python/python-internal.h (gdbpy_convert_exception): Take a const
3959         reference.
3960         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3961         std::move.
3962         * python/py-utils.c (gdbpy_convert_exception): Take a const
3963         reference.
3964         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3965         Use std::move.
3966         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3967         Use std::move.
3968         * mi/mi-main.c (mi_print_exception): Take a const reference.
3969         * main.c (handle_command_errors): Take a const reference.
3970         * linespec.c (parse_linespec): Use std::move.
3971         * infcall.c (run_inferior_call): Use std::move.
3972         (call_function_by_hand_dummy): Use std::move.
3973         * exec.c (try_open_exec_file): Use std::move.
3974         * exceptions.h (exception_print, exception_fprintf)
3975         (exception_print_same): Update.
3976         * exceptions.c (print_exception, exception_print)
3977         (exception_fprintf, exception_print_same): Change parameters to
3978         const reference.
3979         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3980         * common/new-op.c: Use std::move.
3981         * common/common-exceptions.h (struct gdb_exception): Add move
3982         constructor.
3983         (struct gdb_exception_error, struct gdb_exception_quit, struct
3984         gdb_quit_bad_alloc): Change constructor to move constructor.
3985         (throw_exception): Change parameter to rvalue reference.
3986         * common/common-exceptions.c (throw_exception): Take rvalue
3987         reference.
3988         * cli/cli-interp.c (safe_execute_command): Use std::move.
3989         * breakpoint.c (insert_bp_location, location_to_sals): Use
3990         std::move.
3991
3992 2019-04-25  Tom Tromey  <tromey@adacore.com>
3993
3994         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3995         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3996         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3997         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3998         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3999         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
4000         guile/scm-value.c: Use unpack.
4001         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
4002         gdbscm_gdb_exception.
4003         (gdbscm_throw_gdb_exception): Likewise.
4004         (struct gdbscm_gdb_exception): New.
4005         (unpack): New function.
4006         (gdbscm_wrap): Use unpack.
4007
4008 2019-04-25  Tom Tromey  <tromey@adacore.com>
4009
4010         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4011         (gdb_rl_callback_handler): Use std::move.
4012         * common/common-exceptions.h (struct gdb_exception): Add move
4013         assignment operator.
4014         (throw_exception_sjlj): Change "exception" to const reference.
4015         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
4016         (throw_exception_sjlj): Change "exception" to const reference.
4017
4018 2019-04-25  Tom Tromey  <tromey@adacore.com>
4019
4020         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
4021         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
4022         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
4023         Update.
4024         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
4025         Update.
4026         * mi/mi-interp.c (mi_interp::exec): Update.
4027         * linespec.c (parse_linespec): Update.
4028         * infcall.c (run_inferior_call): Update.
4029         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
4030         * guile/scm-symbol.c (gdbscm_lookup_symbol)
4031         (gdbscm_lookup_global_symbol): Update.
4032         * guile/scm-param.c (gdbscm_parameter_value): Update.
4033         * guile/scm-frame.c (gdbscm_frame_read_register)
4034         (gdbscm_frame_read_var): Update.
4035         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
4036         * exec.c (try_open_exec_file): Update.
4037         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
4038         (gdb_rl_callback_handler): Update.
4039         * common/common-exceptions.h (exception_none): Don't declare.
4040         * common/common-exceptions.c (exception_none): Don't define.
4041         (struct catcher) <exception>: Update.
4042         * cli/cli-interp.c (safe_execute_command): Update.
4043         * breakpoint.c (insert_bp_location, location_to_sals): Update.
4044
4045 2019-04-25  Ali Tamur  <tamur@google.com>
4046
4047         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
4048         (read_attribute_value): Likewise.
4049         (dwarf2_read_addr_index): Update comment.
4050         (read_str_index): Add DW_FORM_strx.
4051         (dwarf2_string_attr): Likewise.
4052         (dwarf2_const_value_attr): Likewise.
4053         (dump_die_shallow): Likewise.
4054         (dwarf2_fetch_constant_bytes): Likewise.
4055         (skip_form_bytes): Likewise.
4056         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
4057
4058 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
4059
4060         PR corefiles/11608
4061         PR corefiles/18187
4062         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
4063         OFFSET.  Verify if current mapping contains an ELF header.
4064         (linux_find_memory_regions_full): Adjust call to
4065         dump_mapping_p.
4066
4067 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
4068             Kang Li <kanglictf@gmail.com>
4069
4070         PR gdb/21600
4071
4072         * dwarf2-frame.c (read_initial_length): Be consistent about using
4073         unsigned representation of length.
4074         (decode_frame_entry_1): Likewise.  Check for wraparound of
4075         end pointer as well as buffer overflow.
4076
4077 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
4078
4079         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
4080         "vq".
4081
4082 2019-04-24  Tom Tromey  <tromey@adacore.com>
4083
4084         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
4085
4086 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4087
4088         * s12z-tdep.c (s12z_unwind_pc): Delete.
4089         (s12z_unwind_sp): Delete.
4090         (s12z_gdbarch_init): Don't register deleted functions with
4091         gdbarch.
4092
4093 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4094
4095         * rl78-tdep.c (rl78_unwind_sp): Delete.
4096         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
4097
4098 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4099
4100         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
4101         (xstormy16_unwind_pc): Delete.
4102         (xstormy16_dummy_id): Delete.
4103         (xstormy16_gdbarch_init): Don't register deleted functions with
4104         gdbarch.
4105
4106 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4107
4108         * vax-tdep.c (vax_unwind_pc): Delete.
4109         (vax_gdbarch_init): Don't register deleted function with gdbarch.
4110
4111 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4112
4113         * v850-tdep.c (v850_unwind_sp): Delete.
4114         (v850_unwind_pc): Delete.
4115         (v850_dummy_id): Delete.
4116         (v850_gdbarch_init): Don't register deleted functions with
4117         gdbarch.
4118
4119 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4120
4121         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
4122         (tilegx_unwind_pc): Delete.
4123         (tilegx_unwind_dummy_id): Delete.
4124         (tilegx_gdbarch_init): Don't register deleted functions with
4125         gdbarch.
4126
4127 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4128
4129         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
4130         (tic6x_dummy_id): Delete.
4131         (tic6x_gdbarch_init): Don't register deleted functions with
4132         gdbarch.
4133
4134 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4135
4136         * sparc-tdep.c (sparc_unwind_pc): Delete.
4137         (sparc32_gdbarch_init): Don't register deleted function with
4138         gdbarch.
4139
4140 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * sh-tdep.c (sh_unwind_sp): Delete.
4143         (sh_unwind_pc): Delete.
4144         (sh_dummy_id): Delete.
4145         (sh_gdbarch_init): Don't register deleted functions with
4146         gdbarch.
4147
4148 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4149
4150         * score-tdep.c (score_unwind_sp): Delete.
4151         (score_unwind_pc): Delete.
4152         (score_dummy_id): Delete.
4153         (score_gdbarch_init): Don't register deleted functions with
4154         gdbarch.
4155
4156 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4157
4158         * rx-tdep.c (rx_unwind_pc): Delete.
4159         (rx_unwind_sp): Delete.
4160         (rx_dummy_id): Delete.
4161         (rx_gdbarch_init): Don't register deleted functions with
4162         gdbarch.  Update comment.
4163
4164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4165
4166         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
4167         (rs6000_dummy_id): Delete.
4168         (rs6000_gdbarch_init): Don't register deleted functions with
4169         gdbarch.
4170
4171 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4172
4173         * or1k-tdep.c (or1k_dummy_id): Delete.
4174         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
4175
4176 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4177
4178         * nios2-tdep.c (nios2_dummy_id): Delete.
4179         (nios2_unwind_sp): Delete.
4180         (nios2_gdbarch_init): Don't register deleted functions with
4181         gdbarch.
4182
4183 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4184
4185         * nds32-tdep.c (nds32_dummy_id): Delete.
4186         (nds32_unwind_pc): Delete.
4187         (nds32_unwind_sp): Delete.
4188         (nds32_gdbarch_init): Don't register deleted functions with
4189         gdbarch.
4190
4191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4192
4193         * msp430-tdep.c (msp430_unwind_pc): Delete.
4194         (msp430_unwind_sp): Delete.
4195         (msp430_dummy_id): Delete.
4196         (msp430_gdbarch_init): Don't register deleted functions with
4197         gdbarch.
4198
4199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4200
4201         * moxie-tdep.c (moxie_unwind_sp): Delete.
4202         (moxie_unwind_pc): Delete.
4203         (moxie_dummy_id): Delete.
4204         (moxie_gdbarch_init): Don't register deleted functions with
4205         gdbarch.
4206
4207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4208
4209         * mn10300-tdep.c (mn10300_dummy_id): Delete.
4210         (mn10300_unwind_pc): Delete.
4211         (mn10300_unwind_sp): Delete.
4212         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
4213         mn10300_unwind_sp.
4214         (mn10300_frame_unwind_init): Don't register deleted functions with
4215         gdbarch.
4216
4217 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4218
4219         * mep-tdep.c (mep_unwind_pc): Delete.
4220         (mep_unwind_sp): Delete.
4221         (mep_dummy_id): Delete.
4222         (mep_gdbarch_init): Don't register deleted functions with
4223         gdbarch.
4224
4225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4226
4227         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
4228         (m68hc11_unwind_sp): Delete.
4229         (m68hc11_gdbarch_init): Don't register deleted functions with
4230         gdbarch.
4231
4232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4233
4234         * m32r-tdep.c (m32r_unwind_sp): Delete.
4235         (m32r_unwind_pc): Delete.
4236         (m32r_dummy_id): Delete.
4237         (m32r_gdbarch_init): Don't register deleted functions with
4238         gdbarch.
4239
4240 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4241
4242         * m32c-tdep.c (m32c_unwind_pc): Delete.
4243         (m32c_unwind_sp): Delete.
4244         (m32c_dummy_id): Delete.
4245         (m32c_gdbarch_init): Don't register deleted functions with
4246         gdbarch.
4247
4248 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4249
4250         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
4251         (lm32_unwind_pc): Delete.
4252         (lm32_dummy_id): Delete.
4253         (lm32_gdbarch_init): Don't register deleted functions with
4254         gdbarch.
4255
4256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4257
4258         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
4259         (iq2000_unwind_pc): Delete.
4260         (iq2000_dummy_id): Delete.
4261         (iq2000_gdbarch_init): Don't register deleted functions with
4262         gdbarch.
4263
4264 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4265
4266         * nds32-tdep.c (nds32_type_align): Delete.
4267         (nds32_push_dummy_call): Use type_align instead.
4268
4269 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4270
4271         * arm-tdep.c (arm_type_align): Only handle vector override case.
4272         (arm_push_dummy_call): Use type_align.
4273         (arm_gdbarch_init): Register arm_type_align gdbarch function.
4274
4275 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
4276
4277         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
4278         case.
4279         (pass_on_stack): Use type_align.
4280         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
4281         function.
4282
4283 2019-04-23  Tom Tromey  <tromey@adacore.com>
4284
4285         * dwarf2read.c (line_header::file_name_at): Remove unused
4286         overload.
4287
4288 2019-04-23  Tom de Vries  <tdevries@suse.de>
4289
4290         PR gdb/24438
4291         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
4292         invocation.
4293
4294
4295 2019-03-27  Ali Tamur  <tamur@google.com>
4296
4297         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
4298         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
4299         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
4300         (dwarf_expr_context::get_addr_index): Likewise
4301         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
4302         (symbol_needs_eval_context::get_addr_index): Likewise
4303         (disassemble_dwarf_expression): Add DW_OP_addrx
4304         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
4305         (read_cutu_die_from_dwo): Update comment
4306         (skip_one_die): Add DW_FORM_addrx
4307         (read_attribute_value): Likewise
4308         (var_decode_location): Add DW_OP_addrx
4309         (dwarf2_const_value_attr): Add DW_FORM_addrx
4310         (dump_die_shallow): Likewise
4311         (dwarf2_fetch_constant_bytes): Likewise
4312         (decode_locdesc): Add DW_OP_addrx
4313         (skip_form_bytes): Add DW_FORM_addrx
4314
4315 2019-04-22  Ali Tamur  <tamur@google.com>
4316
4317         * MAINTAINERS (Write After Approval): Add self.
4318
4319 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
4320
4321         * solib-svr4.c (get_svr4_info): Add pspace parameter.
4322         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
4323         (open_symbol_file_object): Likewise.
4324         (svr4_default_sos): Add info parameter.
4325         (svr4_read_so_list): Likewise.
4326         (svr4_current_sos_direct): Adjust functions calls to pass down
4327         info.
4328         (svr4_current_sos_1): Add info parameter.
4329         (svr4_current_sos): Call get_svr4_info, pass info down to
4330         svr4_current_sos_1.
4331         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
4332         get_svr4_info.
4333         (svr4_in_dynsym_resolve_code): Pass current_program_space to
4334         get_svr4_info.
4335         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
4336         to get_svr4_info.
4337         (probes_table_remove_objfile_probes): Likewise.
4338         (register_solib_event_probe): Add info parameter.
4339         (solist_update_incremental): Pass info parameter down to
4340         svr4_read_so_list.
4341         (disable_probes_interface): Add info parameter.
4342         (svr4_handle_solib_event): Pass current_program_space to
4343         get_svr4_info.  Adjust disable_probes_interface cleanup.
4344         (svr4_create_probe_breakpoints): Add info parameter, pass it
4345         down to register_solib_event_probe.
4346         (svr4_create_solib_event_breakpoints): Add info parameter,
4347         pass it down to svr4_create_probe_breakpoints.
4348         (enable_break): Pass info down to
4349         svr4_create_solib_event_breakpoints.
4350         (svr4_solib_create_inferior_hook): Pass current_program_space to
4351         get_svr4_info.
4352         (svr4_clear_solib): Likewise.
4353
4354 2019-04-22  Pedro Alves  <palves@redhat.com>
4355
4356         * solib-svr4.c (svr4_free_objfile_observer): New.
4357         (probe_and_action::objfile): New field.
4358         (probes_table_htab_remove_objfile_probes)
4359         (probes_table_remove_objfile_probes): New functions.
4360         (register_solib_event_probe): Add 'objfile' parameter.  Store it
4361         in the new probe_and_action.  Don't store the probe in 'lookup'.
4362         (svr4_create_probe_breakpoints): Pass objfile to
4363         register_solib_event_probe.
4364         (_initialize_svr4_solib): Register a free_objfile observer.
4365
4366 2019-04-19  Tom Tromey  <tom@tromey.com>
4367
4368         * common/queue.h: Remove.
4369
4370 2019-04-19  Tom Tromey  <tom@tromey.com>
4371
4372         * event-loop.c: Don't include "common/queue.h".
4373
4374 2019-04-19  Tom Tromey  <tom@tromey.com>
4375
4376         * remote.c (remote_target): Use delete.
4377         * remote-notif.h: Include <list>, not "common/queue.h".
4378         (notif_client_p): Remove typedef.
4379         (remote_notif_state): Add constructor, destructor, initializer.
4380         <notif_queue>: Now a std::list.
4381         (remote_notif_state_xfree): Don't declare.
4382         * remote-notif.c (remote_notif_process, handle_notification)
4383         (remote_notif_state_allocate): Update.
4384         (~remote_notif_state): Rename from remote_notif_state_xfree.
4385
4386 2019-04-19  Tom Tromey  <tom@tromey.com>
4387
4388         * symfile.c (reread_symbols): Update.
4389         * objfiles.c (objfile_register_static_link)
4390         (objfile_lookup_static_link): Update
4391         (~objfile) Don't delete static_links.
4392         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
4393
4394 2019-04-19  Tom Tromey  <tom@tromey.com>
4395
4396         * type-stack.h (struct type_stack) <insert>: Constify string.
4397         * type-stack.c (type_stack::insert): Constify string.
4398         * gdbtypes.h (lookup_template_type): Update.
4399         (address_space_name_to_int): Update.
4400         * gdbtypes.c (address_space_name_to_int): Make space_identifier
4401         const.
4402         (lookup_template_type): Make name const.
4403         * c-exp.y: Update rules.
4404         (lex_one_token, classify_name, classify_inner_name)
4405         (c_print_token): Update.
4406         * p-exp.y: Update rules.
4407         (yylex): Update.
4408         * f-exp.y: Update rules.
4409         (yylex): Update.
4410         * d-exp.y: Update rules.
4411         (lex_one_token, classify_name, classify_inner_name): Update.
4412         * parse.c (write_dollar_variable, copy_name): Return std::string.
4413         * parser-defs.h (copy_name): Change return type.
4414         * m2-exp.y: Update rules.
4415         (yylex): Update.
4416         * go-exp.y (lex_one_token): Update.
4417         Update rules.
4418         (classify_unsafe_function, classify_packaged_name)
4419         (classify_name, yylex): Update.
4420
4421 2019-04-19  Sergei Trofimovich <siarheit@google.com>
4422
4423         * configure.ac: add --enable-source-highlight switch.
4424         * configure: Regenerate.
4425         * top.c (print_gdb_version): plumb --enable-source-highlight
4426         status to "show configuration".
4427
4428 2019-04-19  Tom Tromey  <tromey@adacore.com>
4429
4430         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
4431         Check ADA_TYPE_P.
4432         (empty_record, ada_template_to_fixed_record_type_1)
4433         (template_to_static_fixed_type)
4434         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
4435         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
4436         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
4437         macros.
4438
4439 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
4440
4441         PR symtab/24423:
4442         * source.c (print_source_lines_base): Advance "iter" when a
4443         control character is seen.
4444
4445 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4446
4447         * inferior.h (struct infcall_suspend_state_deleter):
4448         Catch exception in destructor to avoid crash.
4449
4450 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4451
4452         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
4453         close to the add_com "shell".
4454
4455 2019-04-18  Tom Tromey  <tromey@adacore.com>
4456
4457         * process-stratum-target.h (class process_stratum_target)
4458         <stratum>: Add "final".
4459
4460 2019-04-17  Tom Tromey  <tromey@adacore.com>
4461
4462         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
4463         against nullptr before use.
4464
4465 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
4466
4467         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
4468
4469 2019-04-17  Jim Wilson  <jimw@sifive.com>
4470             Andrew Burgess  <andrew.burgess@embecosm.com>
4471
4472         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
4473         code read might fail, assume 4-byte breakpoint in that case.
4474
4475 2019-04-15  Leszek Swirski  <leszeks@google.com>
4476
4477         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
4478         rather than a hand-rolled POD check when checking for forced MEMORY
4479         classification.
4480
4481 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4482
4483         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
4484         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
4485         function.
4486         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
4487         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
4488         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
4489         declaration.
4490
4491 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4492
4493         * aarch64-linux-nat.c
4494         (aarch64_linux_nat_target::thread_architecture): Add override.
4495         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
4496         each VQ.
4497
4498 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
4499
4500         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
4501
4502 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
4503
4504         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
4505         target types of size 96-bits, add some additional comments, and
4506         check that the builtin type we found was the correct size.
4507
4508 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
4509
4510         * utils.c (prompt_for_continue): Don't restore the styling at the
4511         end, as applied_style has the wrong value.  This fixes styling in
4512         long lists of file names that are interrupted by the "Continue?"
4513         prompt.
4514
4515 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4516
4517         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
4518         * c-lang.c (c_language_defn): Likewise.
4519         (cplus_language_defn): Likewise.
4520         (asm_language_defn): Likewise.
4521         (minimal_language_defn): Likewise.
4522         * d-lang.c (d_language_defn): Likewise.
4523         * f-lang.c (f_language_defn): Likewise.
4524         * go-lang.c (go_language_defn): Likewise.
4525         * language.c (unknown_language_defn): Likewise.
4526         (auto_language_defn): Likewise.
4527         * language.h (struct language_defn): Remove la_magic field.
4528         (LANG_MAGIC): Delete.
4529         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
4530         * objc-lang.c (objc_language_defn): Likewise.
4531         * opencl-lang.c (opencl_language_defn): Likewise.
4532         * p-lang.c (pascal_language_defn): Likewise.
4533         * rust-lang.c (rust_language_defn): Likewise.
4534
4535 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4536
4537         * riscv-tdep.c (riscv_type_align): New function.
4538         (riscv_type_alignment): Delete.
4539         (riscv_arg_location): Use 'type_align'.
4540         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
4541
4542 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4543
4544         * gdbtypes.c (type_align): A struct with no non-static fields also
4545         has alignment of 1.
4546
4547 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4548
4549         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
4550         component to 0.
4551         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
4552         member.
4553         (riscv_struct_info::analyse): New implementation using new
4554         analyse_inner member function.
4555         (riscv_struct_info::field_offset): New member function.
4556         (riscv_struct_info::m_offsets): New member variable.
4557         (riscv_struct_info::analyse_inner): New private member function,
4558         takes the old implementation of riscv_struct_info::analyse but
4559         extended to track field offsets.
4560         (riscv_call_arg_struct): Update the struct folding special cases
4561         to handle cases where empty C++ structs, which are non-zero
4562         length, are found.
4563         (riscv_arg_location): Initialise the length of each location, a
4564         non-zero length now indicates the location is in use.
4565         (riscv_push_dummy_call): Allow for the first location having a
4566         non-zero offset when setting up arguments.
4567         (riscv_return_value): Likewise, but for return values.
4568
4569 2019-04-11  Tom Tromey  <tromey@adacore.com>
4570
4571         * utils.c (internal_vproblem): Make "msg" const.
4572
4573 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
4574
4575         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
4576         * trad-frame.c (trad_frame_reset_saved_regs): New function.
4577         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
4578         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
4579
4580 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
4581
4582         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
4583         function.
4584         (fill_gregset): Call amd64_linux_collect_native_gregset instead
4585         of amd64_collect_native_gregset.
4586         (amd64_linux_nat_target::store_registers): Likewise.
4587
4588 2019-04-10  Tom Tromey  <tom@tromey.com>
4589
4590         * symtab.c (lookup_global_symbol_from_objfile)
4591         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
4592         * objfiles.h (class separate_debug_iterator): New.
4593         (class separate_debug_range): New.
4594         (struct objfile) <separate_debug_objfiles>: New method.
4595         (objfile_separate_debug_iterate): Don't declare.
4596         * objfiles.c (separate_debug_iterator::operator++): Rename from
4597         objfile_separate_debug_iterate.
4598         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
4599         iterator.
4600         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
4601         iterator.
4602
4603 2019-04-10  Tom Tromey  <tom@tromey.com>
4604
4605         * symfile.c (reread_symbols): Remove old comment.
4606         * objfiles.c (free_all_objfiles): Fix a typo.
4607
4608 2019-04-10  Tom Tromey  <tom@tromey.com>
4609
4610         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
4611         * minsyms.c (lookup_minimal_symbol): Use foreach.
4612         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
4613         (lookup_minimal_symbol_solib_trampoline): Likewise.
4614         * symfile.c (reread_symbols): Use foreach.
4615
4616 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
4617             Tom Tromey  <tromey@adacore.com>
4618
4619         PR rust/24414:
4620         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
4621         (rust_lex_int_test): Change "value" to be LONGEST.
4622         (rust_lex_tests): Add test for long integer literal.
4623
4624 2019-04-09  Tom Tromey  <tromey@adacore.com>
4625
4626         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
4627         to bool.
4628         (extended_remote_target::attach): Update.
4629         (remote_target::remote_notice_new_inferior): Update.
4630         (remote_target::add_current_inferior_and_thread): Update.
4631         * inferior.c (exit_inferior_1): Use "false".
4632         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
4633
4634 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
4635
4636         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
4637         the "start" command.
4638
4639 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4640
4641         * python/py-inferior.c (infpy_thread_from_thread_handle):
4642         Adjust comments to reflect renaming of thread_from_thread_handle
4643         to thread_from_handle.  Adjust keywords.  Fix type error message.
4644         (inferior_object_methods): Add thread_from_handle.  Retain
4645         thread_from_thread_handle, but mark it as deprecated.
4646
4647 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4648
4649         * gdbthread.h (find_thread_by_handle): Revise declaration.
4650         * thread.c (find_thread_by_handle): Likewise.  Adjust
4651         implementation too.
4652         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
4653         support for buffer objects as handles.
4654
4655 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4656
4657         * python/py-infthread.c (thpy_thread_handle): New function.
4658         (thread_object_methods): Register thpy_thread_handle.
4659
4660 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
4661
4662         * gdbthread.h (thread_to_thread_handle): Declare.
4663         * thread.c (gdbtypes.h): Include.
4664         (thread_to_thread_handle): New function.
4665
4666         * target.h (struct target_ops): Add thread_info_to_thread_handle.
4667         (target_thread_info_to_thread_handle): Declare.
4668         * target.c (target_thread_info_to_thread_handle): New function.
4669         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
4670         * target-delegates.c: Regenerate.
4671
4672         * linux-thread-db.c (class thread_db_target): Add method
4673         thread_info_to_thread_handle.
4674         (thread_db_target::thread_info_to_thread_handle): Define.
4675         * remote.c (class remote_target): Add new method
4676         thread_info_to_thread_handle.
4677         (remote_target::thread_info_to_thread_handle): Define.
4678
4679 2019-04-08  Pedro Alves  <palves@redhat.com>
4680
4681         * common/common-exceptions.c (throw_exception): Don't create
4682         named object to throw; throw directly.
4683         (throw_it): Likewise.  Don't initialize gdb_exception::message
4684         here, with new; pass FMT and AP to the ctor instead.
4685         * common/common-exceptions.h: Include <string>.
4686         (gdb_exception::gdb_exception(enum return_reason, enum errors,
4687         const char *, va_list)): New ctor.  Use std::make_shared.
4688         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
4689         errors)): Delete.
4690         (gdb_exception_error::gdb_exception_error(enum errors, const char
4691         *, va_list)): New.
4692         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
4693         Add assertion.
4694         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
4695         errors)): Delete.
4696         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
4697         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
4698         Add assertion.
4699
4700 2019-04-08  Tom Tromey  <tom@tromey.com>
4701
4702         * valops.c (value_rtti_indirect_type): Replace throw_exception
4703         with throw.
4704         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
4705         with throw.
4706         * thread.c (thr_try_catch_cmd): Replace throw_exception with
4707         throw.
4708         * target.c (target_translate_tls_address): Replace throw_exception
4709         with throw.
4710         * stack.c (frame_apply_command_count): Replace throw_exception
4711         with throw.
4712         * solib-spu.c (append_ocl_sos): Replace throw_exception with
4713         throw.
4714         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
4715         with throw.
4716         * rs6000-tdep.c (rs6000_frame_cache)
4717         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
4718         * remote.c: Replace throw_exception with throw.
4719         * record-full.c (record_full_message, record_full_wait_1)
4720         (record_full_restore): Replace throw_exception with throw.
4721         * record-btrace.c:
4722         (get_thread_current_frame_id, record_btrace_start_replaying)
4723         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
4724         (cmd_record_btrace_start): Replace throw_exception with throw.
4725         * parse.c (parse_exp_in_context_1): Replace throw_exception with
4726         throw.
4727         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
4728         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
4729         * linespec.c:
4730         (find_linespec_symbols): Replace throw_exception with throw.
4731         * infrun.c (displaced_step_prepare, resume): Replace
4732         throw_exception with throw.
4733         * infcmd.c (post_create_inferior): Replace throw_exception with
4734         throw.
4735         * inf-loop.c (inferior_event_handler): Replace throw_exception
4736         with throw.
4737         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
4738         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
4739         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
4740         (get_prev_frame_always, get_frame_pc_if_available)
4741         (get_frame_address_in_block_if_available, get_frame_language):
4742         Replace throw_exception with throw.
4743         * frame-unwind.c (frame_unwind_try_unwinder): Replace
4744         throw_exception with throw.
4745         * eval.c (fetch_subexp_value, evaluate_var_value)
4746         (evaluate_funcall, evaluate_subexp_standard): Replace
4747         throw_exception with throw.
4748         * dwarf2loc.c (call_site_find_chain)
4749         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
4750         Replace throw_exception with throw.
4751         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
4752         with throw.
4753         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
4754         throw.
4755         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
4756         * completer.c (complete_line_internal): Replace throw_exception
4757         with throw.
4758         * compile/compile-object-run.c (compile_object_run): Replace
4759         throw_exception with throw.
4760         * cli/cli-script.c (process_next_line): Replace throw_exception
4761         with throw.
4762         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
4763         (btrace_enable, btrace_maint_update_pt_packets): Replace
4764         throw_exception with throw.
4765         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
4766         throw_exception with throw.
4767         * break-catch-throw.c (re_set_exception_catchpoint): Replace
4768         throw_exception with throw.
4769         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
4770         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
4771         * aarch64-tdep.c (aarch64_make_prologue_cache)
4772         (aarch64_make_stub_cache): Replace throw_exception with throw.
4773
4774 2019-04-08  Tom Tromey  <tom@tromey.com>
4775
4776         * common/common-exceptions.c (throw_exception): Rename from
4777         throw_exception_cxx.  Remove old copy.  Make argument const.
4778         (throw_it): Create and throw exception objects directly.
4779         * common/common-exceptions.h (throw_exception): Make argument
4780         const.
4781         (struct gdb_exception_error): Add constructor.
4782         (struct gdb_exception_quit): Add constructor.
4783
4784 2019-04-08  Tom Tromey  <tom@tromey.com>
4785
4786         * common/common-exceptions.h (exception_rethrow): Don't declare.
4787         (TRY_SJLJ): Update comment.
4788         (TRY, CATCH, END_CATCH): Remove.
4789         * common/common-exceptions.c (exception_rethrow): Remove.
4790
4791 2019-04-08  Tom Tromey  <tom@tromey.com>
4792
4793         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
4794         Remove.
4795         (gdb_exception_error): Rename from
4796         gdb_exception_RETURN_MASK_ERROR.
4797         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
4798         (gdb_quit_bad_alloc): Update.
4799         * aarch64-tdep.c: Update.
4800         * ada-lang.c: Update.
4801         * ada-typeprint.c: Update.
4802         * ada-valprint.c: Update.
4803         * amd64-tdep.c: Update.
4804         * arch-utils.c: Update.
4805         * break-catch-throw.c: Update.
4806         * breakpoint.c: Update.
4807         * btrace.c: Update.
4808         * c-varobj.c: Update.
4809         * cli/cli-cmds.c: Update.
4810         * cli/cli-interp.c: Update.
4811         * cli/cli-script.c: Update.
4812         * common/common-exceptions.c: Update.
4813         * common/new-op.c: Update.
4814         * common/selftest.c: Update.
4815         * compile/compile-c-symbols.c: Update.
4816         * compile/compile-cplus-symbols.c: Update.
4817         * compile/compile-object-load.c: Update.
4818         * compile/compile-object-run.c: Update.
4819         * completer.c: Update.
4820         * corelow.c: Update.
4821         * cp-abi.c: Update.
4822         * cp-support.c: Update.
4823         * cp-valprint.c: Update.
4824         * darwin-nat.c: Update.
4825         * disasm-selftests.c: Update.
4826         * dtrace-probe.c: Update.
4827         * dwarf-index-cache.c: Update.
4828         * dwarf-index-write.c: Update.
4829         * dwarf2-frame-tailcall.c: Update.
4830         * dwarf2-frame.c: Update.
4831         * dwarf2loc.c: Update.
4832         * dwarf2read.c: Update.
4833         * eval.c: Update.
4834         * event-loop.c: Update.
4835         * event-top.c: Update.
4836         * exec.c: Update.
4837         * f-valprint.c: Update.
4838         * fbsd-tdep.c: Update.
4839         * frame-unwind.c: Update.
4840         * frame.c: Update.
4841         * gdbtypes.c: Update.
4842         * gnu-v3-abi.c: Update.
4843         * guile/guile-internal.h: Update.
4844         * guile/scm-block.c: Update.
4845         * guile/scm-breakpoint.c: Update.
4846         * guile/scm-cmd.c: Update.
4847         * guile/scm-disasm.c: Update.
4848         * guile/scm-frame.c: Update.
4849         * guile/scm-lazy-string.c: Update.
4850         * guile/scm-math.c: Update.
4851         * guile/scm-param.c: Update.
4852         * guile/scm-ports.c: Update.
4853         * guile/scm-pretty-print.c: Update.
4854         * guile/scm-symbol.c: Update.
4855         * guile/scm-symtab.c: Update.
4856         * guile/scm-type.c: Update.
4857         * guile/scm-value.c: Update.
4858         * i386-linux-tdep.c: Update.
4859         * i386-tdep.c: Update.
4860         * inf-loop.c: Update.
4861         * infcall.c: Update.
4862         * infcmd.c: Update.
4863         * infrun.c: Update.
4864         * jit.c: Update.
4865         * language.c: Update.
4866         * linespec.c: Update.
4867         * linux-fork.c: Update.
4868         * linux-nat.c: Update.
4869         * linux-tdep.c: Update.
4870         * linux-thread-db.c: Update.
4871         * main.c: Update.
4872         * mi/mi-cmd-break.c: Update.
4873         * mi/mi-cmd-stack.c: Update.
4874         * mi/mi-interp.c: Update.
4875         * mi/mi-main.c: Update.
4876         * objc-lang.c: Update.
4877         * p-valprint.c: Update.
4878         * parse.c: Update.
4879         * ppc-linux-tdep.c: Update.
4880         * printcmd.c: Update.
4881         * python/py-arch.c: Update.
4882         * python/py-breakpoint.c: Update.
4883         * python/py-cmd.c: Update.
4884         * python/py-finishbreakpoint.c: Update.
4885         * python/py-frame.c: Update.
4886         * python/py-framefilter.c: Update.
4887         * python/py-gdb-readline.c: Update.
4888         * python/py-inferior.c: Update.
4889         * python/py-infthread.c: Update.
4890         * python/py-lazy-string.c: Update.
4891         * python/py-linetable.c: Update.
4892         * python/py-objfile.c: Update.
4893         * python/py-param.c: Update.
4894         * python/py-prettyprint.c: Update.
4895         * python/py-progspace.c: Update.
4896         * python/py-record-btrace.c: Update.
4897         * python/py-record.c: Update.
4898         * python/py-symbol.c: Update.
4899         * python/py-type.c: Update.
4900         * python/py-unwind.c: Update.
4901         * python/py-utils.c: Update.
4902         * python/py-value.c: Update.
4903         * python/python.c: Update.
4904         * record-btrace.c: Update.
4905         * record-full.c: Update.
4906         * remote-fileio.c: Update.
4907         * remote.c: Update.
4908         * riscv-tdep.c: Update.
4909         * rs6000-aix-tdep.c: Update.
4910         * rs6000-tdep.c: Update.
4911         * rust-exp.y: Update.
4912         * rust-lang.c: Update.
4913         * s390-tdep.c: Update.
4914         * selftest-arch.c: Update.
4915         * solib-dsbt.c: Update.
4916         * solib-frv.c: Update.
4917         * solib-spu.c: Update.
4918         * solib-svr4.c: Update.
4919         * solib.c: Update.
4920         * sparc64-linux-tdep.c: Update.
4921         * stack.c: Update.
4922         * symfile-mem.c: Update.
4923         * symmisc.c: Update.
4924         * target.c: Update.
4925         * thread.c: Update.
4926         * top.c: Update.
4927         * tracefile-tfile.c: Update.
4928         * tui/tui.c: Update.
4929         * typeprint.c: Update.
4930         * unittests/cli-utils-selftests.c: Update.
4931         * unittests/parse-connection-spec-selftests.c: Update.
4932         * valops.c: Update.
4933         * valprint.c: Update.
4934         * value.c: Update.
4935         * varobj.c: Update.
4936         * windows-nat.c: Update.
4937         * x86-linux-nat.c: Update.
4938         * xml-support.c: Update.
4939
4940 2019-04-08  Tom Tromey  <tom@tromey.com>
4941
4942         * xml-support.c: Use C++ exception handling.
4943         * x86-linux-nat.c: Use C++ exception handling.
4944         * windows-nat.c: Use C++ exception handling.
4945         * varobj.c: Use C++ exception handling.
4946         * value.c: Use C++ exception handling.
4947         * valprint.c: Use C++ exception handling.
4948         * valops.c: Use C++ exception handling.
4949         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4950         handling.
4951         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4952         * typeprint.c: Use C++ exception handling.
4953         * tui/tui.c: Use C++ exception handling.
4954         * tracefile-tfile.c: Use C++ exception handling.
4955         * top.c: Use C++ exception handling.
4956         * thread.c: Use C++ exception handling.
4957         * target.c: Use C++ exception handling.
4958         * symmisc.c: Use C++ exception handling.
4959         * symfile-mem.c: Use C++ exception handling.
4960         * stack.c: Use C++ exception handling.
4961         * sparc64-linux-tdep.c: Use C++ exception handling.
4962         * solib.c: Use C++ exception handling.
4963         * solib-svr4.c: Use C++ exception handling.
4964         * solib-spu.c: Use C++ exception handling.
4965         * solib-frv.c: Use C++ exception handling.
4966         * solib-dsbt.c: Use C++ exception handling.
4967         * selftest-arch.c: Use C++ exception handling.
4968         * s390-tdep.c: Use C++ exception handling.
4969         * rust-lang.c: Use C++ exception handling.
4970         * rust-exp.y: Use C++ exception handling.
4971         * rs6000-tdep.c: Use C++ exception handling.
4972         * rs6000-aix-tdep.c: Use C++ exception handling.
4973         * riscv-tdep.c: Use C++ exception handling.
4974         * remote.c: Use C++ exception handling.
4975         * remote-fileio.c: Use C++ exception handling.
4976         * record-full.c: Use C++ exception handling.
4977         * record-btrace.c: Use C++ exception handling.
4978         * python/python.c: Use C++ exception handling.
4979         * python/py-value.c: Use C++ exception handling.
4980         * python/py-utils.c: Use C++ exception handling.
4981         * python/py-unwind.c: Use C++ exception handling.
4982         * python/py-type.c: Use C++ exception handling.
4983         * python/py-symbol.c: Use C++ exception handling.
4984         * python/py-record.c: Use C++ exception handling.
4985         * python/py-record-btrace.c: Use C++ exception handling.
4986         * python/py-progspace.c: Use C++ exception handling.
4987         * python/py-prettyprint.c: Use C++ exception handling.
4988         * python/py-param.c: Use C++ exception handling.
4989         * python/py-objfile.c: Use C++ exception handling.
4990         * python/py-linetable.c: Use C++ exception handling.
4991         * python/py-lazy-string.c: Use C++ exception handling.
4992         * python/py-infthread.c: Use C++ exception handling.
4993         * python/py-inferior.c: Use C++ exception handling.
4994         * python/py-gdb-readline.c: Use C++ exception handling.
4995         * python/py-framefilter.c: Use C++ exception handling.
4996         * python/py-frame.c: Use C++ exception handling.
4997         * python/py-finishbreakpoint.c: Use C++ exception handling.
4998         * python/py-cmd.c: Use C++ exception handling.
4999         * python/py-breakpoint.c: Use C++ exception handling.
5000         * python/py-arch.c: Use C++ exception handling.
5001         * printcmd.c: Use C++ exception handling.
5002         * ppc-linux-tdep.c: Use C++ exception handling.
5003         * parse.c: Use C++ exception handling.
5004         * p-valprint.c: Use C++ exception handling.
5005         * objc-lang.c: Use C++ exception handling.
5006         * mi/mi-main.c: Use C++ exception handling.
5007         * mi/mi-interp.c: Use C++ exception handling.
5008         * mi/mi-cmd-stack.c: Use C++ exception handling.
5009         * mi/mi-cmd-break.c: Use C++ exception handling.
5010         * main.c: Use C++ exception handling.
5011         * linux-thread-db.c: Use C++ exception handling.
5012         * linux-tdep.c: Use C++ exception handling.
5013         * linux-nat.c: Use C++ exception handling.
5014         * linux-fork.c: Use C++ exception handling.
5015         * linespec.c: Use C++ exception handling.
5016         * language.c: Use C++ exception handling.
5017         * jit.c: Use C++ exception handling.
5018         * infrun.c: Use C++ exception handling.
5019         * infcmd.c: Use C++ exception handling.
5020         * infcall.c: Use C++ exception handling.
5021         * inf-loop.c: Use C++ exception handling.
5022         * i386-tdep.c: Use C++ exception handling.
5023         * i386-linux-tdep.c: Use C++ exception handling.
5024         * guile/scm-value.c: Use C++ exception handling.
5025         * guile/scm-type.c: Use C++ exception handling.
5026         * guile/scm-symtab.c: Use C++ exception handling.
5027         * guile/scm-symbol.c: Use C++ exception handling.
5028         * guile/scm-pretty-print.c: Use C++ exception handling.
5029         * guile/scm-ports.c: Use C++ exception handling.
5030         * guile/scm-param.c: Use C++ exception handling.
5031         * guile/scm-math.c: Use C++ exception handling.
5032         * guile/scm-lazy-string.c: Use C++ exception handling.
5033         * guile/scm-frame.c: Use C++ exception handling.
5034         * guile/scm-disasm.c: Use C++ exception handling.
5035         * guile/scm-cmd.c: Use C++ exception handling.
5036         * guile/scm-breakpoint.c: Use C++ exception handling.
5037         * guile/scm-block.c: Use C++ exception handling.
5038         * guile/guile-internal.h: Use C++ exception handling.
5039         * gnu-v3-abi.c: Use C++ exception handling.
5040         * gdbtypes.c: Use C++ exception handling.
5041         * frame.c: Use C++ exception handling.
5042         * frame-unwind.c: Use C++ exception handling.
5043         * fbsd-tdep.c: Use C++ exception handling.
5044         * f-valprint.c: Use C++ exception handling.
5045         * exec.c: Use C++ exception handling.
5046         * event-top.c: Use C++ exception handling.
5047         * event-loop.c: Use C++ exception handling.
5048         * eval.c: Use C++ exception handling.
5049         * dwarf2read.c: Use C++ exception handling.
5050         * dwarf2loc.c: Use C++ exception handling.
5051         * dwarf2-frame.c: Use C++ exception handling.
5052         * dwarf2-frame-tailcall.c: Use C++ exception handling.
5053         * dwarf-index-write.c: Use C++ exception handling.
5054         * dwarf-index-cache.c: Use C++ exception handling.
5055         * dtrace-probe.c: Use C++ exception handling.
5056         * disasm-selftests.c: Use C++ exception handling.
5057         * darwin-nat.c: Use C++ exception handling.
5058         * cp-valprint.c: Use C++ exception handling.
5059         * cp-support.c: Use C++ exception handling.
5060         * cp-abi.c: Use C++ exception handling.
5061         * corelow.c: Use C++ exception handling.
5062         * completer.c: Use C++ exception handling.
5063         * compile/compile-object-run.c: Use C++ exception handling.
5064         * compile/compile-object-load.c: Use C++ exception handling.
5065         * compile/compile-cplus-symbols.c: Use C++ exception handling.
5066         * compile/compile-c-symbols.c: Use C++ exception handling.
5067         * common/selftest.c: Use C++ exception handling.
5068         * common/new-op.c: Use C++ exception handling.
5069         * cli/cli-script.c: Use C++ exception handling.
5070         * cli/cli-interp.c: Use C++ exception handling.
5071         * cli/cli-cmds.c: Use C++ exception handling.
5072         * c-varobj.c: Use C++ exception handling.
5073         * btrace.c: Use C++ exception handling.
5074         * breakpoint.c: Use C++ exception handling.
5075         * break-catch-throw.c: Use C++ exception handling.
5076         * arch-utils.c: Use C++ exception handling.
5077         * amd64-tdep.c: Use C++ exception handling.
5078         * ada-valprint.c: Use C++ exception handling.
5079         * ada-typeprint.c: Use C++ exception handling.
5080         * ada-lang.c: Use C++ exception handling.
5081         * aarch64-tdep.c: Use C++ exception handling.
5082
5083 2019-04-08  Tom Tromey  <tom@tromey.com>
5084
5085         * xml-support.c (gdb_xml_parser::parse): Update.
5086         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5087         * value.c (show_convenience): Update.
5088         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
5089         (test_parse_flags_qcs): Update.
5090         * thread.c (thr_try_catch_cmd): Update.
5091         * target.c (target_translate_tls_address): Update.
5092         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5093         (info_frame_command_core, frame_apply_command_count): Update.
5094         * rust-exp.y (rust_lex_exception_test): Update.
5095         * riscv-tdep.c (riscv_print_one_register_info): Update.
5096         * remote.c (remote_target::enable_btrace): Update.
5097         * record-btrace.c (record_btrace_enable_warn): Update.
5098         * python/py-utils.c (gdbpy_convert_exception): Update.
5099         * printcmd.c (do_one_display, print_variable_and_value): Update.
5100         * mi/mi-main.c (mi_print_exception): Update.
5101         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
5102         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5103         * linux-nat.c (linux_nat_target::attach): Update.
5104         * linux-fork.c (class scoped_switch_fork_info): Update.
5105         * infrun.c (displaced_step_prepare): Update.
5106         * infcall.c (call_function_by_hand_dummy): Update.
5107         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
5108         * gnu-v3-abi.c (print_one_vtable): Update.
5109         * frame.c (get_prev_frame_always): Update.
5110         * f-valprint.c (info_common_command_for_block): Update.
5111         * exec.c (try_open_exec_file): Update.
5112         * exceptions.c (print_exception, exception_print)
5113         (exception_fprintf, exception_print_same): Update.
5114         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
5115         * dwarf-index-cache.c (index_cache::store)
5116         (index_cache::lookup_gdb_index): Update.
5117         * darwin-nat.c (maybe_cache_shell): Update.
5118         * cp-valprint.c (cp_print_value_fields): Update.
5119         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
5120         (gcc_cplus_symbol_address): Update.
5121         * compile/compile-c-symbols.c (gcc_convert_symbol)
5122         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
5123         * common/selftest.c: Update.
5124         * common/common-exceptions.h (struct gdb_exception) <message>: Now
5125         a std::string.
5126         (exception_try_scope_entry, exception_try_scope_exit): Don't
5127         declare.
5128         (struct exception_try_scope): Remove.
5129         (TRY): Don't use exception_try_scope.
5130         (struct gdb_exception): Add constructor, operator=.
5131         <what>: New method.
5132         (struct gdb_exception_RETURN_MASK_ALL)
5133         (struct gdb_exception_RETURN_MASK_ERROR)
5134         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
5135         (struct gdb_quit_bad_alloc): Update.
5136         * common/common-exceptions.c (exception_none): Change
5137         initializer.
5138         (struct catcher) <state, exception>: Initialize inline.
5139         <prev>: Remove member.
5140         (current_catcher): Remove.
5141         (catchers): New global.
5142         (exceptions_state_mc_init): Simplify.
5143         (catcher_pop): Remove.
5144         (exceptions_state_mc, exceptions_state_mc_catch): Update.
5145         (try_scope_depth, exception_try_scope_entry)
5146         (exception_try_scope_exit): Remove.
5147         (throw_exception_sjlj): Update.
5148         (exception_messages, exception_messages_size): Remove.
5149         (throw_it): Simplify.
5150         (gdb_exception_sliced_copy): Remove.
5151         (throw_exception_cxx): Update.
5152         * cli/cli-script.c (script_from_file): Update.
5153         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
5154         Update.
5155         * ada-valprint.c (ada_val_print): Update.
5156         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
5157         (create_excep_cond_exprs): Update.
5158
5159 2019-04-08  Tom Tromey  <tom@tromey.com>
5160
5161         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
5162         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
5163         (TRY, CATCH, END_CATCH): Remove some definitions.
5164         * common/common-exceptions.c: Don't use GDB_XCPT.
5165         (catcher_list_size): Remove.
5166         (throw_exception, throw_it): Simplify.
5167
5168 2019-04-05  Tom Tromey  <tom@tromey.com>
5169
5170         Revert the header-sorting patch.
5171         * ft32-tdep.c: Revert.
5172         * frv-tdep.c: Revert.
5173         * frv-linux-tdep.c: Revert.
5174         * frame.c: Revert.
5175         * frame-unwind.c: Revert.
5176         * frame-base.c: Revert.
5177         * fork-child.c: Revert.
5178         * findvar.c: Revert.
5179         * findcmd.c: Revert.
5180         * filesystem.c: Revert.
5181         * filename-seen-cache.h: Revert.
5182         * filename-seen-cache.c: Revert.
5183         * fbsd-tdep.c: Revert.
5184         * fbsd-nat.h: Revert.
5185         * fbsd-nat.c: Revert.
5186         * f-valprint.c: Revert.
5187         * f-typeprint.c: Revert.
5188         * f-lang.c: Revert.
5189         * extension.h: Revert.
5190         * extension.c: Revert.
5191         * extension-priv.h: Revert.
5192         * expprint.c: Revert.
5193         * exec.h: Revert.
5194         * exec.c: Revert.
5195         * exceptions.c: Revert.
5196         * event-top.c: Revert.
5197         * event-loop.c: Revert.
5198         * eval.c: Revert.
5199         * elfread.c: Revert.
5200         * dwarf2read.h: Revert.
5201         * dwarf2read.c: Revert.
5202         * dwarf2loc.c: Revert.
5203         * dwarf2expr.h: Revert.
5204         * dwarf2expr.c: Revert.
5205         * dwarf2-frame.c: Revert.
5206         * dwarf2-frame-tailcall.c: Revert.
5207         * dwarf-index-write.h: Revert.
5208         * dwarf-index-write.c: Revert.
5209         * dwarf-index-common.c: Revert.
5210         * dwarf-index-cache.h: Revert.
5211         * dwarf-index-cache.c: Revert.
5212         * dummy-frame.c: Revert.
5213         * dtrace-probe.c: Revert.
5214         * disasm.h: Revert.
5215         * disasm.c: Revert.
5216         * disasm-selftests.c: Revert.
5217         * dictionary.c: Revert.
5218         * dicos-tdep.c: Revert.
5219         * demangle.c: Revert.
5220         * dcache.h: Revert.
5221         * dcache.c: Revert.
5222         * darwin-nat.h: Revert.
5223         * darwin-nat.c: Revert.
5224         * darwin-nat-info.c: Revert.
5225         * d-valprint.c: Revert.
5226         * d-namespace.c: Revert.
5227         * d-lang.c: Revert.
5228         * ctf.c: Revert.
5229         * csky-tdep.c: Revert.
5230         * csky-linux-tdep.c: Revert.
5231         * cris-tdep.c: Revert.
5232         * cris-linux-tdep.c: Revert.
5233         * cp-valprint.c: Revert.
5234         * cp-support.c: Revert.
5235         * cp-namespace.c: Revert.
5236         * cp-abi.c: Revert.
5237         * corelow.c: Revert.
5238         * corefile.c: Revert.
5239         * continuations.c: Revert.
5240         * completer.h: Revert.
5241         * completer.c: Revert.
5242         * complaints.c: Revert.
5243         * coffread.c: Revert.
5244         * coff-pe-read.c: Revert.
5245         * cli-out.h: Revert.
5246         * cli-out.c: Revert.
5247         * charset.c: Revert.
5248         * c-varobj.c: Revert.
5249         * c-valprint.c: Revert.
5250         * c-typeprint.c: Revert.
5251         * c-lang.c: Revert.
5252         * buildsym.c: Revert.
5253         * buildsym-legacy.c: Revert.
5254         * build-id.h: Revert.
5255         * build-id.c: Revert.
5256         * btrace.c: Revert.
5257         * bsd-uthread.c: Revert.
5258         * breakpoint.h: Revert.
5259         * breakpoint.c: Revert.
5260         * break-catch-throw.c: Revert.
5261         * break-catch-syscall.c: Revert.
5262         * break-catch-sig.c: Revert.
5263         * blockframe.c: Revert.
5264         * block.c: Revert.
5265         * bfin-tdep.c: Revert.
5266         * bfin-linux-tdep.c: Revert.
5267         * bfd-target.c: Revert.
5268         * bcache.c: Revert.
5269         * ax-general.c: Revert.
5270         * ax-gdb.h: Revert.
5271         * ax-gdb.c: Revert.
5272         * avr-tdep.c: Revert.
5273         * auxv.c: Revert.
5274         * auto-load.c: Revert.
5275         * arm-wince-tdep.c: Revert.
5276         * arm-tdep.c: Revert.
5277         * arm-symbian-tdep.c: Revert.
5278         * arm-pikeos-tdep.c: Revert.
5279         * arm-obsd-tdep.c: Revert.
5280         * arm-nbsd-tdep.c: Revert.
5281         * arm-nbsd-nat.c: Revert.
5282         * arm-linux-tdep.c: Revert.
5283         * arm-linux-nat.c: Revert.
5284         * arm-fbsd-tdep.c: Revert.
5285         * arm-fbsd-nat.c: Revert.
5286         * arm-bsd-tdep.c: Revert.
5287         * arch-utils.c: Revert.
5288         * arc-tdep.c: Revert.
5289         * arc-newlib-tdep.c: Revert.
5290         * annotate.h: Revert.
5291         * annotate.c: Revert.
5292         * amd64-windows-tdep.c: Revert.
5293         * amd64-windows-nat.c: Revert.
5294         * amd64-tdep.c: Revert.
5295         * amd64-sol2-tdep.c: Revert.
5296         * amd64-obsd-tdep.c: Revert.
5297         * amd64-obsd-nat.c: Revert.
5298         * amd64-nbsd-tdep.c: Revert.
5299         * amd64-nbsd-nat.c: Revert.
5300         * amd64-nat.c: Revert.
5301         * amd64-linux-tdep.c: Revert.
5302         * amd64-linux-nat.c: Revert.
5303         * amd64-fbsd-tdep.c: Revert.
5304         * amd64-fbsd-nat.c: Revert.
5305         * amd64-dicos-tdep.c: Revert.
5306         * amd64-darwin-tdep.c: Revert.
5307         * amd64-bsd-nat.c: Revert.
5308         * alpha-tdep.c: Revert.
5309         * alpha-obsd-tdep.c: Revert.
5310         * alpha-nbsd-tdep.c: Revert.
5311         * alpha-mdebug-tdep.c: Revert.
5312         * alpha-linux-tdep.c: Revert.
5313         * alpha-linux-nat.c: Revert.
5314         * alpha-bsd-tdep.c: Revert.
5315         * alpha-bsd-nat.c: Revert.
5316         * aix-thread.c: Revert.
5317         * agent.c: Revert.
5318         * addrmap.c: Revert.
5319         * ada-varobj.c: Revert.
5320         * ada-valprint.c: Revert.
5321         * ada-typeprint.c: Revert.
5322         * ada-tasks.c: Revert.
5323         * ada-lang.c: Revert.
5324         * aarch64-tdep.c: Revert.
5325         * aarch64-ravenscar-thread.c: Revert.
5326         * aarch64-newlib-tdep.c: Revert.
5327         * aarch64-linux-tdep.c: Revert.
5328         * aarch64-linux-nat.c: Revert.
5329         * aarch64-fbsd-tdep.c: Revert.
5330         * aarch64-fbsd-nat.c: Revert.
5331         * aarch32-linux-nat.c: Revert.
5332
5333 2019-04-05  Tom Tromey  <tom@tromey.com>
5334
5335         * ft32-tdep.c: Sort headers.
5336         * frv-tdep.c: Sort headers.
5337         * frv-linux-tdep.c: Sort headers.
5338         * frame.c: Sort headers.
5339         * frame-unwind.c: Sort headers.
5340         * frame-base.c: Sort headers.
5341         * fork-child.c: Sort headers.
5342         * findvar.c: Sort headers.
5343         * findcmd.c: Sort headers.
5344         * filesystem.c: Sort headers.
5345         * filename-seen-cache.h: Sort headers.
5346         * filename-seen-cache.c: Sort headers.
5347         * fbsd-tdep.c: Sort headers.
5348         * fbsd-nat.h: Sort headers.
5349         * fbsd-nat.c: Sort headers.
5350         * f-valprint.c: Sort headers.
5351         * f-typeprint.c: Sort headers.
5352         * f-lang.c: Sort headers.
5353         * extension.h: Sort headers.
5354         * extension.c: Sort headers.
5355         * extension-priv.h: Sort headers.
5356         * expprint.c: Sort headers.
5357         * exec.h: Sort headers.
5358         * exec.c: Sort headers.
5359         * exceptions.c: Sort headers.
5360         * event-top.c: Sort headers.
5361         * event-loop.c: Sort headers.
5362         * eval.c: Sort headers.
5363         * elfread.c: Sort headers.
5364         * dwarf2read.h: Sort headers.
5365         * dwarf2read.c: Sort headers.
5366         * dwarf2loc.c: Sort headers.
5367         * dwarf2expr.h: Sort headers.
5368         * dwarf2expr.c: Sort headers.
5369         * dwarf2-frame.c: Sort headers.
5370         * dwarf2-frame-tailcall.c: Sort headers.
5371         * dwarf-index-write.h: Sort headers.
5372         * dwarf-index-write.c: Sort headers.
5373         * dwarf-index-common.c: Sort headers.
5374         * dwarf-index-cache.h: Sort headers.
5375         * dwarf-index-cache.c: Sort headers.
5376         * dummy-frame.c: Sort headers.
5377         * dtrace-probe.c: Sort headers.
5378         * disasm.h: Sort headers.
5379         * disasm.c: Sort headers.
5380         * disasm-selftests.c: Sort headers.
5381         * dictionary.c: Sort headers.
5382         * dicos-tdep.c: Sort headers.
5383         * demangle.c: Sort headers.
5384         * dcache.h: Sort headers.
5385         * dcache.c: Sort headers.
5386         * darwin-nat.h: Sort headers.
5387         * darwin-nat.c: Sort headers.
5388         * darwin-nat-info.c: Sort headers.
5389         * d-valprint.c: Sort headers.
5390         * d-namespace.c: Sort headers.
5391         * d-lang.c: Sort headers.
5392         * ctf.c: Sort headers.
5393         * csky-tdep.c: Sort headers.
5394         * csky-linux-tdep.c: Sort headers.
5395         * cris-tdep.c: Sort headers.
5396         * cris-linux-tdep.c: Sort headers.
5397         * cp-valprint.c: Sort headers.
5398         * cp-support.c: Sort headers.
5399         * cp-namespace.c: Sort headers.
5400         * cp-abi.c: Sort headers.
5401         * corelow.c: Sort headers.
5402         * corefile.c: Sort headers.
5403         * continuations.c: Sort headers.
5404         * completer.h: Sort headers.
5405         * completer.c: Sort headers.
5406         * complaints.c: Sort headers.
5407         * coffread.c: Sort headers.
5408         * coff-pe-read.c: Sort headers.
5409         * cli-out.h: Sort headers.
5410         * cli-out.c: Sort headers.
5411         * charset.c: Sort headers.
5412         * c-varobj.c: Sort headers.
5413         * c-valprint.c: Sort headers.
5414         * c-typeprint.c: Sort headers.
5415         * c-lang.c: Sort headers.
5416         * buildsym.c: Sort headers.
5417         * buildsym-legacy.c: Sort headers.
5418         * build-id.h: Sort headers.
5419         * build-id.c: Sort headers.
5420         * btrace.c: Sort headers.
5421         * bsd-uthread.c: Sort headers.
5422         * breakpoint.h: Sort headers.
5423         * breakpoint.c: Sort headers.
5424         * break-catch-throw.c: Sort headers.
5425         * break-catch-syscall.c: Sort headers.
5426         * break-catch-sig.c: Sort headers.
5427         * blockframe.c: Sort headers.
5428         * block.c: Sort headers.
5429         * bfin-tdep.c: Sort headers.
5430         * bfin-linux-tdep.c: Sort headers.
5431         * bfd-target.c: Sort headers.
5432         * bcache.c: Sort headers.
5433         * ax-general.c: Sort headers.
5434         * ax-gdb.h: Sort headers.
5435         * ax-gdb.c: Sort headers.
5436         * avr-tdep.c: Sort headers.
5437         * auxv.c: Sort headers.
5438         * auto-load.c: Sort headers.
5439         * arm-wince-tdep.c: Sort headers.
5440         * arm-tdep.c: Sort headers.
5441         * arm-symbian-tdep.c: Sort headers.
5442         * arm-pikeos-tdep.c: Sort headers.
5443         * arm-obsd-tdep.c: Sort headers.
5444         * arm-nbsd-tdep.c: Sort headers.
5445         * arm-nbsd-nat.c: Sort headers.
5446         * arm-linux-tdep.c: Sort headers.
5447         * arm-linux-nat.c: Sort headers.
5448         * arm-fbsd-tdep.c: Sort headers.
5449         * arm-fbsd-nat.c: Sort headers.
5450         * arm-bsd-tdep.c: Sort headers.
5451         * arch-utils.c: Sort headers.
5452         * arc-tdep.c: Sort headers.
5453         * arc-newlib-tdep.c: Sort headers.
5454         * annotate.h: Sort headers.
5455         * annotate.c: Sort headers.
5456         * amd64-windows-tdep.c: Sort headers.
5457         * amd64-windows-nat.c: Sort headers.
5458         * amd64-tdep.c: Sort headers.
5459         * amd64-sol2-tdep.c: Sort headers.
5460         * amd64-obsd-tdep.c: Sort headers.
5461         * amd64-obsd-nat.c: Sort headers.
5462         * amd64-nbsd-tdep.c: Sort headers.
5463         * amd64-nbsd-nat.c: Sort headers.
5464         * amd64-nat.c: Sort headers.
5465         * amd64-linux-tdep.c: Sort headers.
5466         * amd64-linux-nat.c: Sort headers.
5467         * amd64-fbsd-tdep.c: Sort headers.
5468         * amd64-fbsd-nat.c: Sort headers.
5469         * amd64-dicos-tdep.c: Sort headers.
5470         * amd64-darwin-tdep.c: Sort headers.
5471         * amd64-bsd-nat.c: Sort headers.
5472         * alpha-tdep.c: Sort headers.
5473         * alpha-obsd-tdep.c: Sort headers.
5474         * alpha-nbsd-tdep.c: Sort headers.
5475         * alpha-mdebug-tdep.c: Sort headers.
5476         * alpha-linux-tdep.c: Sort headers.
5477         * alpha-linux-nat.c: Sort headers.
5478         * alpha-bsd-tdep.c: Sort headers.
5479         * alpha-bsd-nat.c: Sort headers.
5480         * aix-thread.c: Sort headers.
5481         * agent.c: Sort headers.
5482         * addrmap.c: Sort headers.
5483         * ada-varobj.c: Sort headers.
5484         * ada-valprint.c: Sort headers.
5485         * ada-typeprint.c: Sort headers.
5486         * ada-tasks.c: Sort headers.
5487         * ada-lang.c: Sort headers.
5488         * aarch64-tdep.c: Sort headers.
5489         * aarch64-ravenscar-thread.c: Sort headers.
5490         * aarch64-newlib-tdep.c: Sort headers.
5491         * aarch64-linux-tdep.c: Sort headers.
5492         * aarch64-linux-nat.c: Sort headers.
5493         * aarch64-fbsd-tdep.c: Sort headers.
5494         * aarch64-fbsd-nat.c: Sort headers.
5495         * aarch32-linux-nat.c: Sort headers.
5496
5497 2019-04-04  Tom Tromey  <tom@tromey.com>
5498
5499         * varobj.c (varobj_create): Update.
5500         * rust-exp.y (struct rust_parser) <update_innermost_block,
5501         lookup_symbol>: New methods.
5502         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
5503         Rename.
5504         (rust_parser::rust_lookup_type)
5505         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5506         * printcmd.c (display_command, do_one_display): Update.
5507         * parser-defs.h (struct parser_state) <parser_state>: Add
5508         "tracker" parameter.
5509         (block_tracker): New member.
5510         (class innermost_block_tracker) <innermost_block_tracker>: Add
5511         "types" parameter.
5512         <reset>: Remove method.
5513         (innermost_block): Don't declare.
5514         (null_post_parser): Update.
5515         * parse.c (innermost_block): Remove global.
5516         (write_dollar_variable): Update.
5517         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
5518         Remove "tracker_types" parameter.
5519         (parse_expression): Add "tracker" parameter.
5520         (parse_expression_for_completion): Update.
5521         (null_post_parser): Add "tracker" parameter.
5522         * p-exp.y: Update rules.
5523         * m2-exp.y: Update rules.
5524         * language.h (struct language_defn) <la_post_parser>: Add
5525         "tracker" parameter.
5526         * go-exp.y: Update rules.
5527         * f-exp.y: Update rules.
5528         * expression.h (parse_expression, parse_exp_1): Add "tracker"
5529         parameter.
5530         * d-exp.y: Update rules.
5531         * c-exp.y: Update rules.
5532         * breakpoint.c (set_breakpoint_condition): Create an
5533         innermost_block_tracker.
5534         (watch_command_1): Likewise.
5535         * ada-lang.c (resolve): Add "tracker" parameter.
5536         (resolve_subexp): Likewise.
5537         * ada-exp.y (write_var_from_sym): Update.
5538
5539 2019-04-04  Tom Tromey  <tom@tromey.com>
5540
5541         * type-stack.h: New file.
5542         * type-stack.c: New file.
5543         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
5544         type-stack.h.
5545         (insert_into_type_stack, insert_type, push_type, push_type_int)
5546         (insert_type_address_space, pop_type, pop_type_int)
5547         (pop_typelist, pop_type_stack, append_type_stack)
5548         (push_type_stack, get_type_stack, push_typelist)
5549         (follow_type_instance_flags, follow_types): Don't declare.
5550         * parse.c (type_stack): Remove global.
5551         (parse_exp_in_context): Update.
5552         (insert_into_type_stack, insert_type, push_type, push_type_int)
5553         (insert_type_address_space, pop_type, pop_type_int)
5554         (pop_typelist, pop_type_stack, append_type_stack)
5555         (push_type_stack, get_type_stack, push_typelist)
5556         (follow_type_instance_flags, follow_types): Remove (moved to
5557         type-stack.c).
5558         * f-exp.y (type_stack): New global.
5559         Update rules.
5560         (push_kind_type, f_parse): Update.
5561         * d-exp.y (type_stack): New global.
5562         Update rules.
5563         (d_parse): Update.
5564         * c-exp.y (struct c_parse_state) <type_stack>: New member.
5565         Update rules.
5566         * Makefile.in (COMMON_SFILES): Add type-stack.c.
5567         (HFILES_NO_SRCDIR): Add type-stack.h.
5568
5569 2019-04-04  Tom Tromey  <tom@tromey.com>
5570
5571         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
5572         (rust_parser::convert_ast_to_expression, rust_parse)
5573         (rust_lex_test_completion, rust_lex_tests): Update.
5574         * parser-defs.h (struct expr_completion_state): New.
5575         (struct parser_state) <parser_state>: Add completion parameter.
5576         <mark_struct_expression, mark_completion_tag>: New methods.
5577         <parse_completion, m_completion_state>: New members.
5578         (prefixify_expression, null_post_parser): Update.
5579         (mark_struct_expression, mark_completion_tag): Don't declare.
5580         * parse.c (parse_completion, expout_last_struct)
5581         (expout_tag_completion_type, expout_completion_name): Remove
5582         globals.
5583         (parser_state::mark_struct_expression)
5584         (parser_state::mark_completion_tag): Now methods.
5585         (prefixify_expression): Add last_struct parameter.
5586         (prefixify_subexp): Likewise.
5587         (parse_exp_1): Update.
5588         (parse_exp_in_context): Add cstate parameter.  Update.
5589         (parse_expression_for_completion): Create an
5590         expr_completion_state.
5591         (null_post_parser): Add "completion" parameter.
5592         * p-exp.y: Update rules.
5593         (yylex): Update.
5594         * language.h (struct language_defn) <la_post_parser>: Add
5595         "completing" parameter.
5596         * go-exp.y: Update rules.
5597         (lex_one_token): Update.
5598         * expression.h (parse_completion): Don't declare.
5599         * d-exp.y: Update rules.
5600         (lex_one_token): Update rules.
5601         * c-exp.y: Update rules.
5602         (lex_one_token): Update.
5603         * ada-lang.c (resolve): Add "parse_completion" parameter.
5604         (resolve_subexp): Likewise.
5605         (ada_resolve_function): Likewise.
5606
5607 2019-04-04  Tom Tromey  <tom@tromey.com>
5608
5609         * parser-defs.h (struct parser_state) <start_arglist,
5610         end_arglist>: New methods.
5611         <arglist_len, m_funcall_chain>: New members.
5612         (arglist_len, start_arglist, end_arglist): Don't declare.
5613         * parse.c (arglist_len, funcall_chain): Remove global.
5614         (start_arglist, end_arglist): Remove functions.
5615         (parse_exp_in_context): Update.
5616         * p-exp.y: Update rules.
5617         * m2-exp.y: Update rules.
5618         * go-exp.y: Update rules.
5619         * f-exp.y: Update rules.
5620         * d-exp.y: Update rules.
5621         * c-exp.y: Update rules.
5622
5623 2019-04-04  Tom Tromey  <tom@tromey.com>
5624
5625         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
5626         lex_operator, push_back>: New methods.
5627         Update all rules.
5628         (rust_parser::lex_hex, lex_escape): Rename and update.
5629         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
5630         (rust_parser::lex_operator): Rename and update.
5631         (rust_parser::lex_number, rustyylex, rustyyerror)
5632         (rust_lex_test_init, rust_lex_test_sequence)
5633         (rust_lex_test_push_back, rust_lex_tests): Update.
5634         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
5635         parameter.
5636         <lexptr, prev_lexptr>: New members.
5637         (lexptr, prev_lexptr): Don't declare.
5638         * parse.c (lexptr, prev_lexptr): Remove globals.
5639         (parse_exp_in_context): Update.
5640         * p-exp.y (yylex, yyerror): Update.
5641         * m2-exp.y (parse_number, yylex, yyerror): Update.
5642         * go-exp.y (lex_one_token, yyerror): Update.
5643         * f-exp.y (match_string_literal, yylex, yyerror): Update.
5644         * d-exp.y (lex_one_token, yyerror): Update.
5645         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
5646         (lex_one_token, yyerror): Update.
5647         * ada-lex.l (YY_INPUT): Update.
5648         (rewind_to_char): Update.
5649         * ada-exp.y (yyerror): Update.
5650
5651 2019-04-04  Tom Tromey  <tom@tromey.com>
5652
5653         * rust-exp.y (rustyylex, rust_lex_tests): Update.
5654         * parser-defs.h (struct parser_state) <parser_state>: Add new
5655         parameter.
5656         <comma_terminates>: New member.
5657         (comma_terminates): Don't declare global.
5658         * parse.c (comma_terminates): Remove global.
5659         (parse_exp_in_context): Update.
5660         * p-exp.y (yylex): Update.
5661         * m2-exp.y (yylex): Update.
5662         * go-exp.y (lex_one_token): Update.
5663         * f-exp.y (yylex): Update.
5664         * d-exp.y (lex_one_token): Update.
5665         * c-exp.y (lex_one_token): Update.
5666         * ada-lex.l: Update.
5667
5668 2019-04-04  Tom Tromey  <tom@tromey.com>
5669
5670         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
5671         (rustyylex, rust_lex_test_init, rust_lex_test_one)
5672         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
5673         * parser-defs.h (paren_depth): Don't declare.
5674         * parse.c (paren_depth): Remove global.
5675         (parse_exp_in_context): Update.
5676         * p-exp.y (paren_depth): New global.
5677         (pascal_parse): Initialize it.
5678         * m2-exp.y (paren_depth): New global.
5679         (m2_parse): Initialize it.
5680         * go-exp.y (paren_depth): New global.
5681         (go_parse): Initialize it.
5682         * f-exp.y (paren_depth): New global.
5683         (f_parse): Initialize it.
5684         * d-exp.y (paren_depth): New global.
5685         (d_parse): Initialize it.
5686         * c-exp.y (paren_depth): New global.
5687         (c_parse): Initialize it.
5688         * ada-lex.l (paren_depth): New global.
5689         (lexer_init): Initialize it.
5690
5691 2019-04-04  Tom Tromey  <tom@tromey.com>
5692
5693         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
5694         (rust_parser::convert_ast_to_type)
5695         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
5696         * parser-defs.h (struct parser_state) <parser_state>: Add
5697         parameters.  Initialize new members.
5698         <expression_context_block, expression_context_pc>: New members.
5699         * parse.c (expression_context_block, expression_context_pc):
5700         Remove globals.
5701         (parse_exp_in_context): Update.
5702         * p-exp.y: Update all rules.
5703         (yylex): Update.
5704         * m2-exp.y: Update all rules.
5705         (yylex): Update.
5706         * go-exp.y (yylex): Update.
5707         * f-exp.y (yylex): Update.
5708         * d-exp.y: Update all rules.
5709         (yylex): Update.
5710         * c-exp.y: Update all rules.
5711         (lex_one_token, classify_name, yylex, c_parse): Update.
5712         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
5713
5714 2019-04-04  Tom Tromey  <tom@tromey.com>
5715
5716         * gdbarch.h, gdbarch.c: Rebuild.
5717         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
5718         * stap-probe.h:
5719         (struct stap_parse_info): Replace "parser_state" with
5720         "expr_builder".
5721         * parser-defs.h (struct expr_builder): Rename from "parser_state".
5722         (parser_state): New class.
5723         * parse.c (expr_builder): Rename.
5724         (expr_builder::release): Rename.
5725         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
5726         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
5727         (write_exp_elt_longcst, write_exp_elt_floatcst)
5728         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
5729         (write_exp_string_vector, write_exp_bitstring)
5730         (write_exp_msymbol, mark_struct_expression)
5731         (write_dollar_variable)
5732         (insert_type_address_space, increase_expout_size): Replace
5733         "parser_state" with "expr_builder".
5734         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
5735         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
5736         "parser_state" with "expr_builder".
5737
5738 2019-04-04  Tom Tromey  <tom@tromey.com>
5739
5740         * rust-exp.y: Replace "parse_language" with method call.
5741         * p-exp.y:
5742         (yylex): Replace "parse_language" with method call.
5743         * m2-exp.y:
5744         (yylex): Replace "parse_language" with method call.
5745         * go-exp.y (classify_name): Replace "parse_language" with method
5746         call.
5747         * f-exp.y (yylex): Replace "parse_language" with method call.
5748         * d-exp.y (lex_one_token): Replace "parse_language" with method
5749         call.
5750         * c-exp.y:
5751         (lex_one_token, classify_name, yylex): Replace "parse_language"
5752         with method call.
5753         * ada-exp.y (find_primitive_type, type_char)
5754         (type_system_address): Replace "parse_language" with method call.
5755
5756 2019-04-04  Tom Tromey  <tom@tromey.com>
5757
5758         * rust-exp.y: Replace "parse_gdbarch" with method call.
5759         * parse.c (write_dollar_variable, insert_type_address_space):
5760         Replace "parse_gdbarch" with method call.
5761         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
5762         call.
5763         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
5764         call.
5765         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
5766         "parse_gdbarch" with method call.
5767         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
5768         with method call.
5769         * f-exp.y (parse_type, parse_f_type, yylex): Replace
5770         "parse_gdbarch" with method call.
5771         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
5772         "parse_gdbarch" with method call.
5773         * c-exp.y (parse_type, parse_number, classify_name): Replace
5774         "parse_gdbarch" with method call.
5775         * ada-lex.l: Replace "parse_gdbarch" with method call.
5776         * ada-exp.y (parse_type, find_primitive_type, type_char)
5777         (type_system_address): Replace "parse_gdbarch" with method call.
5778
5779 2019-04-04  Tom Tromey  <tom@tromey.com>
5780
5781         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
5782         * stap-probe.c (stap_parse_argument): Update.
5783         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
5784         initial_size parameter.
5785         * rust-exp.y (rust_lex_tests): Update.
5786         * parse.c (parser_state): Update.
5787         (parse_exp_in_context): Update.
5788         * parser-defs.h (struct parser_state) <parser_state>: Remove
5789         "initial_size" parameter.
5790
5791 2019-04-04  Tom Tromey  <tom@tromey.com>
5792
5793         * parser-defs.h (increase_expout_size): Don't declare.
5794         * parse.c (increase_expout_size): Now static.
5795
5796 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
5797
5798         * gnu-nat.c (gnu_nat_target::wait): Fix
5799         target_waitstatus_to_string call.
5800
5801 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5802
5803         * eval.c (evaluate_subexp_standard): Handle internal functions
5804         during Fortran function call handling.
5805
5806 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5807
5808         * NEWS: Mention new internal functions.
5809         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5810         (read_base_type): Use dwarf2_init_complex_target_type.
5811         * value.c (creal_internal_fn): New function.
5812         (cimag_internal_fn): New function.
5813         (_initialize_values): Register new internal functions.
5814
5815 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5816
5817         * infrun.c (stop_all_threads): If debug_infrun, always
5818         trace the wait status after wait_one, using
5819         target_waitstatus_to_string and target_pid_to_str.
5820         (handle_inferior_event): Replace various trace of
5821         wait status kind by a single trace.
5822         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5823         wait status kind image by target_waitstatus_to_string.
5824         * target/waitstatus.c (target_waitstatus_to_string): Fix
5825         obsolete comment.
5826
5827 2019-04-01  Tom Tromey  <tromey@adacore.com>
5828
5829         PR symtab/23331:
5830         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5831
5832 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5833             Pedro Alves  <palves@redhat.com>
5834
5835         * top.c (quit_force): Call 'finalize_values'.
5836         * value.c (finalize_values): New function.
5837         * value.h (finalize_values): Declare.
5838
5839 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5840
5841         * NEWS: Announce $_gdb_major and $_gdb_minor.
5842
5843         * top.c (init_gdb_version_vars): New function.
5844         (gdb_init): Call init_gdb_version_vars.
5845
5846 2019-03-29  Tom Tromey  <tromey@adacore.com>
5847
5848         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5849         help text.  Remove dead code.
5850
5851 2019-03-29  Keith Seitz  <keiths@redhat.com>
5852
5853         From Siddhesh Poyarekar:
5854         * f-lang.h (f77_get_upperbound): Return LONGEST.
5855         (f77_get_lowerbound): Likewise.
5856         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5857         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5858         print them.
5859         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5860         plongest to format print it.
5861         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5862         (f77_get_upperbound): Likewise.
5863         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5864         LOWER_BOUND to LONGEST.
5865         (f77_create_arrayprint_offset_tbl): Likewise.
5866
5867 2019-03-29  Keith Seitz  <keiths@redhat.com>
5868
5869         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5870         %s/pulongest for TYPE_LENGTH instead of %d in format
5871         strings.
5872         * ada-typerint.c (ada_print_type): Likewise.
5873         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5874         * compile/compile-c-support.c (generate_register_struct): Likewise.
5875         * gdbtypes.c (recursive_dump_type): Likewise.
5876         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5877         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5878         instead of %d in format strings.
5879         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5880         to std::min to ULONGEST.
5881         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5882         instead of %d in format strings.
5883         * tracepoint.c (info_scope_command): Likewise.
5884         * typeprint.c (print_offset_data::update)
5885         (print_offset_data::finish): Likewise.
5886         * xtensa-tdep.c (xtensa_store_return_value)
5887         (xtensa_push_dummy_call): Likewise.
5888
5889 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5890
5891         * windows-nat.c (display_selector): Fixed format specifications
5892         for 64-bit Cygwin.
5893
5894 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5895
5896         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5897
5898 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5899
5900         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5901         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5902         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5903         (nios2_linux_init_abi): Install it.
5904
5905 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5906
5907         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5908
5909 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5910
5911         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5912
5913 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5914             Tom Tromey  <tromey@adacore.com>
5915
5916         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5917
5918 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5919
5920         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5921         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5922         method to compute the bounds of range types. Also print "[evaluated]"
5923         if the bounds' values come from a dynamic evaluation.
5924
5925 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5926
5927         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5928         whitespace when pretty printing is on.
5929
5930 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5931
5932         * ppc-linux-nat.c: Add include.
5933
5934 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5935
5936         * NEWS: Mention AArch64 Pointer Authentication.
5937
5938 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5939
5940         * arm-linux-nat.c: Add include.
5941
5942 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5943
5944         * source-cache.c (source_cache::get_source_lines): Re-read
5945         fullname after calling open_source_file.
5946
5947 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5948
5949         * NEWS: Mention TLS support for FreeBSD.
5950
5951 2019-03-25  Tom Tromey  <tromey@adacore.com>
5952
5953         * minsyms.c (BUNCH_SIZE): Update comment.
5954         (~minimal_symbol_reader): Remove old comment.
5955         (compact_minimal_symbols): Update comment.
5956         (minimal_symbol_reader::install): Remove old comment.  Update
5957         other comments.
5958
5959 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5960
5961         * s390-linux-nat.c: Add include.
5962
5963 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5964
5965         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5966         Call linux_get_hwcap.
5967         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5968         Likewise.
5969         (aarch64_linux_get_hwcap): Remove function.
5970         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5971         declaration.
5972         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5973         linux_get_hwcap.
5974         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5975         * linux-tdep.c (linux_get_hwcap): Add function.
5976         (linux_get_hwcap2): Likewise.
5977         * linux-tdep.h (linux_get_hwcap): Add declaration.
5978         (linux_get_hwcap2): Likewise.
5979         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5980         (ppc_linux_get_hwcap2): Likewise.
5981         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5982         linux_get_hwcap.
5983         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5984         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5985         (ppc_linux_nat_target::read_description): Likewise.
5986         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5987         * s390-linux-nat.c: Likewise.
5988         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5989
5990 2019-03-24  Tom Tromey  <tom@tromey.com>
5991
5992         * ada-lang.c (standard_lookup): Simplify initialization.
5993         (ada_lookup_symbol_nonlocal): Simplify return.
5994         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5995         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5996         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5997         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5998         initialization.
5999         * solib.c (solib_global_lookup): Simplify.
6000         * symtab.c (null_block_symbol): Remove.
6001         (symbol_cache_lookup): Simplify returns.
6002         (lookup_language_this): Simplify returns.
6003         (lookup_symbol_aux): Simplify return.
6004         (lookup_local_symbol): Simplify returns.
6005         (lookup_global_symbol_from_objfile): Simplify return.
6006         (lookup_symbol_in_objfile_symtabs)
6007         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
6008         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
6009         (lookup_static_symbol, lookup_global_symbol): Simplify return.
6010         * cp-namespace.c (cp_lookup_bare_symbol)
6011         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
6012         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
6013         (cp_lookup_nested_symbol): Don't use null_block_symbol.
6014         (cp_lookup_symbol_via_imports): Simplify initialization.
6015         (find_symbol_in_baseclass): Likewise.
6016         * symtab.h (null_block_symbol): Remove.
6017         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
6018         (d_lookup_nested_symbol, d_lookup_symbol_imports)
6019         (d_lookup_symbol_module): Likewise.
6020         (find_symbol_in_baseclass): Simplify initialization.
6021
6022 2019-03-24  Tom Tromey  <tom@tromey.com>
6023
6024         * expression.h: Don't include symtab.h.
6025         (struct block): Forward declare.
6026
6027 2019-03-24  Tom Tromey  <tom@tromey.com>
6028
6029         * c-exp.y (typebase): Remove casts.
6030         * gdbtypes.c (lookup_unsigned_typename, )
6031         (lookup_signed_typename): Remove cast.
6032         * eval.c (parse_to_comma_and_eval): Remove cast.
6033         * parse.c (write_dollar_variable): Remove cast.
6034         * block.h (struct block) <superblock>: Now const.
6035         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
6036         * psymtab.c (psym_map_matching_symbols): Make "block" const.
6037         (map_block): Make "block" const.
6038         * symfile.h (struct quick_symbol_functions)
6039         <map_matching_symbols>: Constify block argument to "callback".
6040         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
6041         const.
6042         (find_pc_sect_compunit_symtab): Make "b" const.
6043         (find_symbol_at_address): Likewise.
6044         (search_symbols): Likewise.
6045         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
6046         (dw2_debug_names_lookup_symbol): Likewise.
6047         (dw2_map_matching_symbols): Update.
6048         * p-valprint.c (pascal_val_print): Remove "block".
6049         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
6050         (aux_add_nonlocal_symbols): Make "block" const.
6051         (resolve_subexp): Remove cast.
6052         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
6053         const.
6054         (iterate_over_file_blocks): Likewise.
6055         * f-exp.y (%union) <bval>: Remove.
6056         * coffread.c (patch_opaque_types): Make "b" const.
6057         * spu-tdep.c (spu_catch_start): Make "block" const.
6058         * c-valprint.c (print_unpacked_pointer): Remove "block".
6059         * symmisc.c (dump_symtab_1): Make "b" const.
6060         (block_depth): Make "block" const.
6061         * d-exp.y (%union) <bval>: Remove.
6062         * cp-support.h (cp_lookup_rtti_type): Update.
6063         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
6064         * psymtab.c (psym_lookup_symbol): Make "block" const.
6065         (maintenance_check_psymtabs): Make "b" const.
6066         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
6067         (enumerate_locals, enumerate_args): Update.
6068         * python/py-symtab.c (stpy_global_block): Make "block" const.
6069         (stpy_static_block): Likewise.
6070         * inline-frame.c (block_starting_point_at): Make "new_block"
6071         const.
6072         * block.c (find_block_in_blockvector): Make return type const.
6073         (blockvector_for_pc_sect): Make "b" const.
6074         (find_block_in_blockvector): Make "b" const.
6075
6076 2019-03-23  Tom Tromey  <tom@tromey.com>
6077
6078         * varobj.c (varobj_create): Update.
6079         * symfile.c (clear_symtab_users): Don't reset innermost_block.
6080         * printcmd.c (display_command, do_one_display): Don't reset
6081         innermost_block.
6082         * parser-defs.h (enum innermost_block_tracker_type): Move to
6083         expression.h.
6084         (innermost_block): Update comment.
6085         * parse.c (parse_exp_1): Add tracker_types parameter.
6086         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
6087         tracker_types parameter.  Reset innermost_block.
6088         (parse_exp_in_context): Remove.
6089         (parse_expression_for_completion): Update.
6090         * objfiles.c (~objfile): Don't reset expression_context_block or
6091         innermost_block.
6092         * expression.h (enum innermost_block_tracker_type): Move from
6093         parser-defs.h.
6094         (parse_exp_1): Add tracker_types parameter.
6095         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
6096         reset innermost_block.
6097
6098 2019-03-23  Tom Tromey  <tom@tromey.com>
6099
6100         * objfiles.h: Include bcache.h.
6101
6102 2019-03-23  Tom Tromey  <tom@tromey.com>
6103
6104         * linespec.c (get_current_search_block): Use
6105         scoped_restore_current_language.
6106         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
6107
6108 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6109             Jiong Wang  <jiong.wang@arm.com>
6110
6111         * aarch64-linux-tdep.c
6112         (aarch64_linux_iterate_over_regset_sections): Check for pauth
6113         section.
6114         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
6115
6116 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6117             Jiong Wang  <jiong.wang@arm.com>
6118
6119         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
6120         instructions.
6121         (aarch64_analyze_prologue_test): Add PACIASP test.
6122         (aarch64_prologue_prev_register): Unmask PC value.
6123
6124 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6125             Jiong Wang  <jiong.wang@arm.com>
6126
6127         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
6128         (aarch64_dwarf2_prev_register): Unmask PC value.
6129         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
6130         (aarch64_execute_dwarf_cfa_vendor_op): Check for
6131         DW_CFA_AARCH64_negate_ra_state.
6132         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
6133
6134 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6135             Jiong Wang  <jiong.wang@arm.com>
6136
6137         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
6138         registers.
6139         (aarch64_pseudo_register_name): Likewise.
6140         (aarch64_pseudo_register_type): Likewise.
6141         (aarch64_pseudo_register_reggroup_p): Likewise.
6142         (aarch64_gdbarch_init): Add pauth registers.
6143         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
6144         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
6145         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
6146         (struct gdbarch_tdep): Add regnum for ra_state.
6147
6148 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6149             Jiong Wang  <jiong.wang@arm.com>
6150
6151         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
6152
6153 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6154             Jiong Wang  <jiong.wang@arm.com>
6155
6156         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
6157         function.
6158         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
6159         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
6160         (aarch64_gdbarch_init): Add puth registers.
6161         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
6162         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
6163         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
6164
6165 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6166             Jiong Wang  <jiong.wang@arm.com>
6167
6168         * aarch64-linux-nat.c
6169         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
6170         * aarch64-linux-tdep.c
6171         (aarch64_linux_core_read_description): Likewise.
6172         (aarch64_linux_get_hwcap): New function.
6173         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
6174         (aarch64_linux_get_hwcap): New declaration.
6175
6176 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
6177             Jiong Wang  <jiong.wang@arm.com>
6178
6179         * aarch64-linux-nat.c
6180         (aarch64_linux_nat_target::read_description): Add pauth param.
6181         * aarch64-linux-tdep.c
6182         (aarch64_linux_core_read_description): Likewise.
6183         * aarch64-tdep.c (struct target_desc): Add in pauth.
6184         (aarch64_read_description): Add pauth param.
6185         (aarch64_gdbarch_init): Likewise.
6186         * aarch64-tdep.h (aarch64_read_description): Likewise.
6187         * arch/aarch64.c (aarch64_create_target_description): Likewise.
6188         * arch/aarch64.h (aarch64_create_target_description): Likewise.
6189         * features/Makefile: Add new files.
6190         * features/aarch64-pauth.c: New file.
6191         * features/aarch64-pauth.xml: New file.
6192
6193 2019-03-20  Tom Tromey  <tromey@adacore.com>
6194
6195         * infrun.c (handle_inferior_event): Rename from
6196         handle_inferior_event_1.  Create a scoped_value_mark.
6197         (handle_inferior_event): Remove.
6198
6199 2019-03-19  Tom Tromey  <tromey@adacore.com>
6200
6201         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
6202         * infrun.h (print_stop_event): Add "displays" parameter.
6203         * infrun.c (print_stop_event): Add "displays" parameter.
6204
6205 2019-03-19  Pedro Alves  <palves@redhat.com>
6206
6207         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
6208         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
6209         to -1.  Fix TABs vs spaces.
6210         (tui_ui_out::tui_ui_out): Don't initialize fields here.
6211         * tui/tui-out.h (tui_ui_out) Add intro comments.
6212         <m_line, m_start_of_line>: In-class initialize, and add describing
6213         comment.
6214
6215 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
6216
6217         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
6218         variable names.
6219         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
6220
6221 2019-03-18  Pedro Alves  <palves@redhat.com>
6222             Eli Zaretskii <eliz@gnu.org>
6223
6224         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
6225         m_line and m_start_of_line.
6226
6227 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
6228
6229         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
6230         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
6231         it returns a newline.  This fixes a regression in TU mode, whereby
6232         the next line is output on the same screen line as the user input.
6233
6234 2019-03-18  Tom Tromey  <tromey@adacore.com>
6235
6236         * minsyms.c (minimal_symbol_reader::install): Remove call to
6237         obstack_blank.
6238
6239 2019-03-18  Pedro Alves  <palves@redhat.com>
6240
6241         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
6242         New globals.
6243         (apply_style): New, factored out from ...
6244         (apply_ansi_escape): ... this.  Handle reverse video mode.
6245         (tui_set_reverse_mode): New function.
6246         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
6247         * tui/tui-winsource.c (tui_show_source_line): Use
6248         tui_set_reverse_mode instead of setting A_STANDOUT.
6249         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
6250         New setter methods.
6251
6252 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
6253
6254         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
6255         Handle tabs.
6256
6257 2019-03-18  Tom Tromey  <tromey@adacore.com>
6258
6259         * ada-lang.c (empty_array): Add "high" parameter.
6260         (ada_evaluate_subexp): Update.
6261
6262 2019-03-17  Sergei Trofimovich <siarheit@google.com>
6263
6264         * unittests/string_view-selftests.c: Define
6265         _initialize_string_view_selftests unconditionally.
6266
6267 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6268
6269         PR gdb/24350
6270         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
6271
6272 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
6273
6274         PR gdb/24351
6275         * windows-nat.c (display_selector): Fix format specifiers.
6276
6277 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
6278
6279         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
6280         tui_refill_source_window instead of tui_refresh_win, to update the
6281         current execution line.  This fixes redisplay of the current line
6282         when stepping through the code with "next" or "step".
6283
6284 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6285
6286         * source-cache.c (source_cache::get_source_lines): Call
6287         find_source_lines to initialize s->nlines.  This fixes vertical
6288         scrolling of TUI source window when the DOWN arrow is pressed.
6289
6290 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6291
6292         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
6293         linux-thread-db.c (_initialize_thread_db): Likewise.
6294
6295 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
6296
6297         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
6298         wclrtoeol in tui_show_source_line".  This reverts changes made in
6299         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
6300
6301 2019-03-15  Tom Tromey  <tom@tromey.com>
6302
6303         * symtab.h (struct minimal_symbol): Derive from
6304         general_symbol_info.
6305         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
6306         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
6307         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
6308         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
6309         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
6310         (MSYMBOL_SEARCH_NAME): Update.
6311         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
6312         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
6313         * minsyms.c (minimal_symbol_reader::record_full): Update.
6314
6315 2019-03-15  Tom Tromey  <tom@tromey.com>
6316
6317         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
6318
6319 2019-03-15  Tom Tromey  <tom@tromey.com>
6320
6321         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
6322         unique_xmalloc_ptr.
6323         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
6324         Update.
6325         * minsyms.c (lookup_minimal_symbol_by_pc_section)
6326         (build_minimal_symbol_hash_tables)
6327         (minimal_symbol_reader::install): Update.
6328
6329 2019-03-15  Tom Tromey  <tom@tromey.com>
6330
6331         * symtab.c (create_demangled_names_hash): Update.
6332         (symbol_set_names): Update.
6333         * objfiles.h (struct objfile_per_bfd_storage)
6334         <demangled_names_hash>: Now an htab_up.
6335         * objfiles.c (objfile_per_bfd_storage): Simplify.
6336
6337 2019-03-15  Tom Tromey  <tom@tromey.com>
6338
6339         * objfiles.h (struct objfile_per_bfd_storage): Declare
6340         destructor.
6341         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
6342         New.
6343         (get_objfile_bfd_data): Use new.  Don't initialize
6344         language_of_main.
6345         (free_objfile_per_bfd_storage): Remove.
6346         (objfile_bfd_data_free, objfile::~objfile): Use delete.
6347
6348 2019-03-15  Tom Tromey  <tom@tromey.com>
6349
6350         * symfile.c (reread_symbols): Update.
6351         * objfiles.c (objfile::objfile): Update.
6352         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
6353         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
6354         comment.
6355         (minimal_symbol_reader::install): Update.
6356         (terminate_minimal_symbol_table): Remove.
6357         * jit.c (jit_object_close_impl): Update.
6358
6359 2019-03-15  Tom Tromey  <tom@tromey.com>
6360
6361         * minsyms.c (minimal_symbol_reader::record_full): Remove some
6362         initializations.
6363
6364 2019-03-15  Tom Tromey  <tom@tromey.com>
6365
6366         * objfiles.h (struct objfile_per_bfd_storage)
6367         <demangled_hash_languages>: Now a bitset.
6368         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
6369         (lookup_minimal_symbol): Update.
6370
6371 2019-03-15  Tom Tromey  <tom@tromey.com>
6372
6373         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
6374         Don't return the symbol.
6375         * coffread.c (record_minimal_symbol): Use record_full.
6376
6377 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
6378
6379         The MS-Windows port of ncurses fails to switch to a color pair if
6380         one or both of the colors are the implicit default colors.  This
6381         change records the default colors when TUI is initialized, and
6382         then specifies them explicitly when a color pair uses the default
6383         colors.  This allows color styling in TUI mode on MS-Windows.
6384
6385         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
6386         ncurses_norm_attr.
6387         (tui_initialize_io) [__MINGW32__]: Record the default terminal
6388         colors in ncurses_norm_attr.
6389         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
6390         "none", replace it with the default color recorded in
6391         ncurses_norm_attr.
6392
6393 2019-03-14  Tom Tromey  <tromey@adacore.com>
6394
6395         * source-cache.h (class source_cache) <get_source_lines>: Return
6396         std::string.
6397         * source-cache.c (source_cache::extract_lines): Handle case where
6398         first_pos==npos.  Return std::string.
6399         (source_cache::get_source_lines): Update.
6400
6401 2019-03-14  Tom Tromey  <tromey@adacore.com>
6402
6403         * NEWS: Add item for "style sources" commands.
6404         * source-cache.c (source_cache::get_source_lines): Check
6405         source_styling.
6406         * cli/cli-style.c (source_styling): New global.
6407         (_initialize_cli_style): Add "style sources" commands.
6408         (show_style_sources): New function.
6409         * cli/cli-style.h (source_styling): Declare.
6410
6411 2019-03-14  Pedro Alves  <palves@redhat.com>
6412             Tom Tromey  <tromey@adacore.com>
6413
6414         * tui/tui-winsource.h (tui_refill_source_window): Declare.
6415         * tui/tui-winsource.c (tui_refill_source_window): New function,
6416         from...
6417         (tui_horizontal_source_scroll): ... here.  Move some logic.
6418         * cli/cli-style.c (set_style_enabled): Notify new observable.
6419         * tui/tui-hooks.c (tui_redisplay_source): New function.
6420         (tui_attach_detach_observers): Attach or detach
6421         tui_redisplay_source.
6422         * observable.h (source_styling_changed): New observable.
6423         * observable.c: Define source_styling_changed observable.
6424
6425 2019-03-13  Tom Tromey  <tromey@adacore.com>
6426
6427         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
6428         (i386_gnu_nat_target::store_registers): Update.
6429         * target-debug.h (target_debug_print_std_string): New macro.
6430         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
6431         * windows-tdep.c (display_one_tib): Update.
6432         * tui/tui-stack.c (tui_make_status_line): Update.
6433         * top.c (print_inferior_quit_action): Update.
6434         * thread.c (thr_try_catch_cmd): Update.
6435         (add_thread_with_info): Update.
6436         (thread_target_id_str): Update.
6437         (thr_try_catch_cmd): Update.
6438         (thread_command): Update.
6439         (thread_find_command): Update.
6440         * record-btrace.c (record_btrace_target::info_record)
6441         (record_btrace_resume_thread, record_btrace_target::resume)
6442         (record_btrace_cancel_resume, record_btrace_step_thread)
6443         (record_btrace_target::wait, record_btrace_target::wait)
6444         (record_btrace_target::wait, record_btrace_target::stop): Update.
6445         * progspace.c (print_program_space): Update.
6446         * process-stratum-target.c
6447         (process_stratum_target::thread_address_space): Update.
6448         * linux-fork.c (linux_fork_mourn_inferior)
6449         (detach_checkpoint_command, info_checkpoints_command)
6450         (linux_fork_context): Update.
6451         (linux_fork_detach): Update.
6452         (class scoped_switch_fork_info): Update.
6453         (delete_checkpoint_command): Update.
6454         * infrun.c (follow_fork_inferior): Update.
6455         (follow_fork_inferior): Update.
6456         (proceed_after_vfork_done): Update.
6457         (handle_vfork_child_exec_or_exit): Update.
6458         (follow_exec): Update.
6459         (displaced_step_prepare_throw): Update.
6460         (displaced_step_restore): Update.
6461         (start_step_over): Update.
6462         (resume_1): Update.
6463         (clear_proceed_status_thread): Update.
6464         (proceed): Update.
6465         (print_target_wait_results): Update.
6466         (do_target_wait): Update.
6467         (context_switch): Update.
6468         (stop_all_threads): Update.
6469         (restart_threads): Update.
6470         (finish_step_over): Update.
6471         (handle_signal_stop): Update.
6472         (switch_back_to_stepped_thread): Update.
6473         (keep_going_pass_signal): Update.
6474         (print_exited_reason): Update.
6475         (normal_stop): Update.
6476         * inferior.c (inferior_pid_to_str): Change return type.
6477         (print_selected_inferior): Update.
6478         (add_inferior): Update.
6479         (detach_inferior): Update.
6480         * dummy-frame.c (fprint_dummy_frames): Update.
6481         * dcache.c (dcache_info_1): Update.
6482         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
6483         (btrace_fetch, btrace_clear): Update.
6484         * linux-tdep.c (linux_core_pid_to_str): Change return type.
6485         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
6486         type.
6487         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
6488         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
6489         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
6490         * gdbarch.c, gdbarch.h: Rebuild.
6491         * gdbarch.sh (core_pid_to_str): Change return type.
6492         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
6493         return type.
6494         (windows_nat_target::pid_to_str): Change return type.
6495         (windows_delete_thread): Update.
6496         (windows_nat_target::attach): Update.
6497         (windows_nat_target::files_info): Update.
6498         * target-delegates.c: Rebuild.
6499         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
6500         return type.
6501         (sol_thread_target::pid_to_str): Change return type.
6502         * remote.c (class remote_target) <pid_to_str>: Change return
6503         type.
6504         (remote_target::pid_to_str): Change return type.
6505         (extended_remote_target::attach, remote_target::remote_stop_ns)
6506         (remote_target::remote_notif_remove_queued_reply)
6507         (remote_target::push_stop_reply, remote_target::disable_btrace):
6508         Update.
6509         (extended_remote_target::attach): Update.
6510         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
6511         type.
6512         (gdbsim_target::pid_to_str): Change return type.
6513         * ravenscar-thread.c (struct ravenscar_thread_target)
6514         <pid_to_str>: Change return type.
6515         (ravenscar_thread_target::pid_to_str): Change return type.
6516         * procfs.c (class procfs_target) <pid_to_str>: Change return
6517         type.
6518         (procfs_target::pid_to_str): Change return type.
6519         (procfs_target::attach): Update.
6520         (procfs_target::detach): Update.
6521         (procfs_target::fetch_registers): Update.
6522         (procfs_target::store_registers): Update.
6523         (procfs_target::wait): Update.
6524         (procfs_target::files_info): Update.
6525         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
6526         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
6527         return type.
6528         (nto_procfs_target::pid_to_str): Change return type.
6529         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
6530         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
6531         return type.
6532         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
6533         (exit_lwp): Update.
6534         (attach_proc_task_lwp_callback, get_detach_signal)
6535         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
6536         (linux_nat_target::resume, wait_lwp, stop_callback)
6537         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
6538         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
6539         (linux_nat_wait_1, resume_stopped_resumed_lwps)
6540         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
6541         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
6542         type.
6543         (inf_ptrace_target::attach): Update.
6544         (inf_ptrace_target::files_info): Update.
6545         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
6546         type.
6547         (go32_nat_target::pid_to_str): Change return type.
6548         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
6549         (gnu_nat_target::wait): Update.
6550         (gnu_nat_target::wait): Update.
6551         (gnu_nat_target::resume): Update.
6552         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
6553         (fbsd_nat_target::wait): Update.
6554         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
6555         type.
6556         (darwin_nat_target::attach): Update.
6557         * corelow.c (class core_target) <pid_to_str>: Change return type.
6558         (core_target::pid_to_str): Change return type.
6559         * target.c (normal_pid_to_str): Change return type.
6560         (default_pid_to_str): Likewise.
6561         (target_pid_to_str): Change return type.
6562         (target_translate_tls_address): Update.
6563         (target_announce_detach): Update.
6564         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
6565         return type.
6566         (bsd_uthread_target::pid_to_str): Change return type.
6567         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
6568         type.
6569         (bsd_kvm_target::pid_to_str): Change return type.
6570         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
6571         return type.
6572         (aix_thread_target::pid_to_str): Change return type.
6573         * target.h (struct target_ops) <pid_to_str>: Change return type.
6574         (target_pid_to_str, normal_pid_to_str): Likewise.
6575         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
6576         type.
6577         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
6578         type.
6579         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
6580         return type.
6581         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
6582         type.
6583         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
6584         type.
6585         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
6586         return type.
6587
6588 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
6589
6590         * NEWS: Mention that the new default MI version is 3.  Mention
6591         changes to the output of commands and events that deal with
6592         multi-location breakpoints.
6593         * breakpoint.c: Include "mi/mi-out.h".
6594         (print_one_breakpoint): Change output syntax if using MI version
6595         >= 3.
6596         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
6597         New.
6598         (mi_multi_location_breakpoint_output_fixed): New.
6599         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
6600         (mi_cmd_fix_multi_location_breakpoint_output): New.
6601         (mi_multi_location_breakpoint_output_fixed): New.
6602         * mi/mi-cmds.c (mi_cmds): Register command
6603         -fix-multi-location-breakpoint-output.
6604         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
6605         interpreter "mi".
6606
6607 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
6608
6609         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
6610         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
6611         instantiate mi_ui_out based on interpreter name.
6612         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
6613         * mi/mi-main.c (mi_load_progress): Likewise.
6614
6615 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6616
6617         * NEWS: Combine separate "New targets" sections for 8.3.
6618
6619 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6620
6621         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
6622         (ppcfbsd_init_abi): Install gdbarch
6623         "fetch_tls_load_module_address" and "get_thread_local_address"
6624         methods.
6625
6626 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6627
6628         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
6629         (riscv_fbsd_init_abi): Install gdbarch
6630         "fetch_tls_load_module_address" and "get_thread_local_address"
6631         methods.
6632
6633 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6634
6635         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
6636         (i386fbsd_init_abi): Install gdbarch
6637         "fetch_tls_load_module_address" and "get_thread_local_address"
6638         methods.
6639
6640 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6641
6642         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
6643         (amd64fbsd_init_abi): Install gdbarch
6644         "fetch_tls_load_module_address" and "get_thread_local_address"
6645         methods.
6646
6647 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6648
6649         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
6650         (struct fbsd_pspace_data): New type.
6651         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
6652         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
6653         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
6654         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
6655         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
6656
6657 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6658
6659         * gdbtypes.c (lookup_struct_elt): New function.
6660         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
6661         * gdbtypes.h (struct struct_elt): New type.
6662         (lookup_struct_elt): New prototype.
6663
6664 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6665
6666         * gdbtypes.c (lookup_struct_elt_type): Update comment and
6667         remove disabled code block.
6668
6669 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6670
6671         * gdbarch.sh (get_thread_local_address): New method.
6672         * gdbarch.h, gdbarch.c: Regenerate.
6673         * target.c (target_translate_tls_address): Use
6674         gdbarch_get_thread_local_address if present instead of
6675         target::get_thread_local_address.
6676
6677 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6678
6679         * target.h (target::get_thread_local_address): Update comment.
6680
6681 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6682
6683         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
6684         objfile->separate_debug_objfile_backlink if not NULL.
6685
6686 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6687
6688         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
6689         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
6690         (amd64bsd_store_inferior_registers): Likewise.
6691         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6692         Enable segment base registers.
6693         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
6694         PT_GETFSBASE and PT_GETGSBASE.
6695         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
6696         PT_SETGSBASE.
6697         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
6698         segment base registers.
6699         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6700
6701 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
6702
6703         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
6704         Update calls to i386_target_description to add 'segments'
6705         parameter.
6706         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
6707         add segment base registers.
6708         * arch/i386.c (i386_create_target_description): Add 'segments'
6709         parameter to enable segment base registers.
6710         * arch/i386.h (i386_create_target_description): Likewise.
6711         * features/i386/32bit-segments.xml: New file.
6712         * features/i386/32bit-segments.c: Generate.
6713         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
6714         call to i386_target_description to add 'segments' parameter.
6715         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
6716         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
6717         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
6718         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
6719         if feature is present.
6720         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
6721         Add 'segments' parameter to call to i386_target_description.
6722         (i386_target_description): Add 'segments' parameter to enable
6723         segment base registers.
6724         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
6725         to call to i386_target_description.
6726         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
6727         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
6728         Define I386_NUM_REGS.
6729         (i386_target_description): Add 'segments' parameter to enable
6730         segment base registers.
6731
6732 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
6733
6734         PR/24325
6735         * source-cache.c: #undef open and close, to avoid unresolved
6736         externals during linking.
6737
6738 2019-03-12  Tom Tromey  <tromey@adacore.com>
6739
6740         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
6741         const.  Add initializers.
6742         (_initialize_remote): Don't initialize ptid globals.
6743
6744 2019-03-12  Pedro Alves  <palves@redhat.com>
6745
6746         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
6747
6748 2019-03-12  Pedro Alves  <palves@redhat.com>
6749
6750         * cp-name-parser.y (main): Remove unused 'len' variable.
6751
6752 2019-03-12  Tom Tromey  <tromey@adacore.com>
6753
6754         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
6755         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
6756
6757 2019-03-12  Tom Tromey  <tromey@adacore.com>
6758
6759         * linux-nat.c (iterate_over_lwps): Update.
6760         (stop_callback): Remove parameter.
6761         (stop_wait_callback, detach_callback, resume_set_callback)
6762         (select_singlestep_lwp_callback, set_ignore_sigint)
6763         (status_callback, resumed_callback, resume_clear_callback)
6764         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
6765         data parameter.
6766         (linux_nat_target::detach, linux_nat_target::resume)
6767         (linux_stop_and_wait_all_lwps, select_event_lwp)
6768         (linux_nat_filter_event, linux_nat_wait_1)
6769         (linux_nat_target::kill, linux_nat_target::stop)
6770         (linux_nat_target::stop): Update.
6771         (linux_nat_resume_callback): Change type.
6772         (resume_stopped_resumed_lwps, count_events_callback)
6773         (select_event_lwp_callback): Likewise.
6774         (linux_stop_lwp, linux_nat_stop_lwp): Update.
6775         * arm-linux-nat.c (struct update_registers_data): Remove.
6776         (update_registers_callback): Change type.
6777         (arm_linux_insert_hw_breakpoint1): Update.
6778         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
6779         parameter.
6780         (x86_linux_dr_set_addr): Update.
6781         (x86_linux_dr_set_control): Update.
6782         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
6783         (iterate_over_lwps): Use gdb::function_view.
6784         * nat/aarch64-linux-hw-point.c (struct
6785         aarch64_dr_update_callback_param): Remove.
6786         (debug_reg_change_callback): Change type.
6787         (aarch64_notify_debug_reg_change): Update.
6788         * s390-linux-nat.c (s390_refresh_per_info): Update.
6789
6790 2019-03-11  Tom Tromey  <tromey@adacore.com>
6791
6792         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
6793         redundant assignment to "this_cu".
6794
6795 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6796
6797         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
6798
6799 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6800
6801         * gdbtypes.c (rank_one_type_parm_set): New function extracted
6802         from...
6803         (rank_one_type): ... this.
6804
6805 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6806
6807         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
6808         from...
6809         (rank_one_type): ... this.
6810
6811 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6812
6813         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6814         from...
6815         (rank_one_type): ... this.
6816
6817 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6818
6819         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6820         from...
6821         (rank_one_type): ... this.
6822
6823 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6824
6825         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6826         from...
6827         (rank_one_type): ... this.
6828
6829 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6830
6831         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6832         from...
6833         (rank_one_type): ... this.
6834
6835 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6836
6837         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6838         from...
6839         (rank_one_type): ... this.
6840
6841 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6842
6843         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6844         from...
6845         (rank_one_type): ... this.
6846
6847 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6848
6849         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6850         from...
6851         (rank_one_type): ... this.
6852
6853 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6854
6855         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6856         from...
6857         (rank_one_type): ... this.
6858
6859 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6860
6861         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6862         from...
6863         (rank_one_type): ... this.
6864
6865 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6866
6867         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6868         from...
6869         (rank_one_type): ... this.
6870
6871 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6872
6873         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6874         inferior-events' shows the example events.
6875
6876 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6877
6878         Support styling on native MS-Windows console
6879
6880         PR/24315
6881         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6882         on MS-Windows if $TERM is not defined.
6883
6884         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6885
6886         * posix-hdep.c (gdb_console_fputs):
6887         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6888         functions.
6889         * ui-file.h (gdb_console_fputs): Add prototype.
6890
6891         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6892         back to fputs only if the former returns zero.
6893
6894 2019-03-07  Tom Tromey  <tom@tromey.com>
6895
6896         * symmisc.c (print_symbol_bcache_statistics): Update.
6897         (print_objfile_statistics): Update.
6898         * symfile.c (allocate_symtab): Update.
6899         * stabsread.c: Don't include bcache.h.
6900         * psymtab.h (struct psymbol_bcache): Don't declare.
6901         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6902         (psymbol_bcache_init, psymbol_bcache_free)
6903         (psymbol_bcache_get_bcache): Don't declare.
6904         * psymtab.c (struct psymbol_bcache): Remove.
6905         (psymtab_storage::psymtab_storage): Update.
6906         (psymtab_storage::~psymtab_storage): Update.
6907         (psymbol_bcache_init, psymbol_bcache_free)
6908         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6909         (add_psymbol_to_bcache): Update.
6910         (allocate_psymtab): Update.
6911         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6912         macro_cache>: No longer pointers.
6913         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6914         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6915         * macrotab.c (macro_bcache): Update.
6916         * macroexp.c: Don't include bcache.h.
6917         * gdbtypes.c (check_types_worklist): Update.
6918         (types_deeply_equal): Remove TRY/CATCH.  Update.
6919         * elfread.c (elf_symtab_read): Update.
6920         * dwarf2read.c: Don't include bcache.h.
6921         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6922         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6923         (print_bcache_statistics, bcache_memory_used): Don't declare.
6924         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6925         methods.  Rename all data members.
6926         * bcache.c (struct bcache): Move to bcache.h.
6927         (bcache::expand_hash_table): Rename from expand_hash_table.
6928         (bcache): Remove.
6929         (bcache::insert): Rename from bcache_full.
6930         (bcache::compare): Rename from bcache_compare.
6931         (bcache_xmalloc): Remove.
6932         (bcache::~bcache): Rename from bcache_xfree.
6933         (bcache::print_statistics): Rename from print_bcache_statistics.
6934         (bcache::memory_used): Rename from bcache_memory_used.
6935
6936 2019-03-07  Pedro Alves  <palves@redhat.com>
6937
6938         * infrun.c (normal_stop): Also check for
6939         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6940
6941 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6942
6943         * f-lang.c (value_from_host_double): Moved to...
6944         * value.c (value_from_host_double): ...here.
6945         * value.h (value_from_host_double): Declare.
6946         * guile/scm-math.c (vlscm_convert_typed_number): Use
6947         value_from_host_double.
6948         (vlscm_convert_number): Likewise.
6949         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6950         * python/py-value.c (convert_value_from_python): Likewise.
6951
6952 2019-03-06  Tom Tromey  <tom@tromey.com>
6953
6954         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6955
6956 2019-03-06  Tom Tromey  <tom@tromey.com>
6957
6958         * utils.h (free_current_contents): Don't declare.
6959         * utils.c (free_current_contents): Remove.
6960
6961 2019-03-06  Tom Tromey  <tom@tromey.com>
6962
6963         * top.c (quit_force): Update.
6964         * main.c (captured_command_loop): Update.
6965         * common/new-op.c (operator new): Update.
6966         * common/common-exceptions.c (struct catcher)
6967         <save_cleanup_chain>: Remove member.
6968         (exceptions_state_mc_init): Update.
6969         (exception_try_scope_entry): Return nullptr.
6970         (exception_try_scope_exit, exception_rethrow)
6971         (throw_exception_sjlj, throw_exception_cxx): Update.
6972         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6973         (all_cleanups, do_cleanups, discard_cleanups)
6974         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6975         (restore_cleanups, restore_final_cleanups): Don't declare.
6976         (do_final_cleanups): Remove parameter.
6977         * common/cleanups.c (cleanup_chain, make_cleanup)
6978         (make_cleanup_dtor, all_cleanups, do_cleanups)
6979         (discard_my_cleanups, discard_cleanups)
6980         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6981         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6982         (null_cleanup): Remove.
6983         (do_final_cleanups): Remove parameter.
6984
6985 2019-03-06  Tom Tromey  <tom@tromey.com>
6986
6987         * remote.c (remote_target::remote_parse_stop_reply): Use
6988         unique_xmalloc_ptr.
6989
6990 2019-03-06  Tom Tromey  <tom@tromey.com>
6991
6992         * stabsread.c (struct stabs_field_info): Rename from field_info.
6993         <list, fnlist>: Add initializers.
6994         <obstack>: New member.
6995         (read_member_functions, read_struct_fields, read_baseclasses):
6996         Allocate on obstack.  Don't use cleanups.
6997         (read_one_struct_field, read_member_functions, read_struct_fields)
6998         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6999         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
7000         (read_struct_type): Update.
7001
7002 2019-03-06  Tom Tromey  <tom@tromey.com>
7003
7004         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
7005         * common/filestuff.h (make_cleanup_close): Don't declare.
7006         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
7007         Remove.
7008
7009 2019-03-06  Tom Tromey  <tom@tromey.com>
7010
7011         * solib-aix.c: Use make_scope_exit.
7012
7013 2019-03-06  Tom Tromey  <tom@tromey.com>
7014
7015         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
7016         Use make_scope_exit.
7017
7018 2019-03-06  Tom Tromey  <tom@tromey.com>
7019
7020         * solib-svr4.c (disable_probes_interface): Remove parameter.
7021         (svr4_handle_solib_event): Use make_scope_exit.
7022
7023 2019-03-06  Tom Tromey  <tom@tromey.com>
7024
7025         * remote.c (struct stop_reply_deleter): Remove.
7026         (stop_reply_up): Update.
7027         (struct stop_reply): Derive from notif_event.  Don't typedef.
7028         <regcache>: Now a std::vector.
7029         (stop_reply_xfree): Remove.
7030         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
7031         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
7032         (remote_target::discard_pending_stop_replies): Use delete.
7033         (remote_target::remote_parse_stop_reply): Update.
7034         (remote_target::process_stop_reply): Update.
7035         * remote-notif.h (struct notif_event): Add virtual destructor.
7036         Remove "dtr" member.
7037         (struct notif_client) <alloc_event>: Return a unique_ptr.
7038         (notif_event_xfree): Don't declare.
7039         (notif_event_up): New typedef.
7040         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
7041         (notif_event_xfree, do_notif_event_xfree): Remove.
7042         (remote_notif_state_xfree): Update.
7043
7044 2019-03-06  Tom Tromey  <tom@tromey.com>
7045
7046         * infrun.c (displaced_step_clear_cleanup): Now a
7047         forward_scope_exit type.
7048         (displaced_step_prepare_throw): Update.
7049         (displaced_step_fixup): Update.
7050
7051 2019-03-06  Tom Tromey  <tom@tromey.com>
7052
7053         * inferior.h (class inferior): Update comment.
7054         * gdbthread.h (class thread_info): Update comment.
7055
7056 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
7057             Tom Tromey  <tom@tromey.com>
7058
7059         * stabsread.h (struct stab_section_list): Remove.
7060         (coffstab_build_psymtabs): Update.
7061         * dbxread.c (symbuf_sections): Now a std::vector.
7062         (sect_idx): New global.
7063         (fill_symbuf): Update.
7064         (coffstab_build_psymtabs): Change type of stabsects parameter.
7065         Update.
7066         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
7067         std::vector.
7068         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
7069         (coff_locate_sections): Update.
7070         (coff_symfile_read): Remove cleanups.  Update.
7071         (init_stringtab): Add storage parameter.
7072         (free_stringtab, free_stringtab_cleanup): Remove.
7073         (init_lineno): Add storage parameter.
7074         (free_linetab, free_linetab_cleanup): Remove.
7075
7076 2019-03-06  Pedro Alves  <palves@redhat.com>
7077
7078         * linux-fork.c (fork_info::clobber_regs): Delete.
7079         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
7080         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
7081         comment.  Adjust.
7082         (scoped_switch_fork_info::scoped_switch_fork_info)
7083         (checkpoint_command, linux_fork_context): Adjust
7084         fork_save_infrun_state calls.
7085
7086 2019-03-06  Pedro Alves  <palves@redhat.com>
7087
7088         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
7089         (inf_has_multiple_threads): Return 'bool' and rewrite using
7090         inferior_info::threads().
7091
7092 2019-03-06  Pedro Alves  <palves@redhat.com>
7093
7094         * linux-fork.c: Include <list>.
7095         (fork_list): Now a std::list instance.
7096         (fork_info): Add ctor, dtor, and in-class initialize all fields.
7097         (forks_exist_p, find_last_fork): Adjust.
7098         (new_fork): Delete.
7099         (one_fork_p): New.
7100         (add_fork): Adjust.
7101         (free_fork): Delete, folded into fork_info::~fork_info().
7102         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
7103         Adjust.
7104         (init_fork_list): Delete.
7105         (linux_fork_killall, linux_fork_mourn_inferior)
7106         (linux_fork_detach, info_checkpoints_command): Adjust.
7107         (_initialize_linux_fork): No longer call init_fork_list.
7108
7109 2019-03-06  Pedro Alves  <palves@redhat.com>
7110
7111         * linux-fork.c (new_fork): New, split out of ...
7112         (add_fork): ... this.  Return void.  Move "first fork" special
7113         case from here, to ...
7114         (checkpoint_command): ... here.
7115         * linux-linux.h (add_fork): Return void.
7116
7117 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7118
7119         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
7120
7121 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7122             Chris January  <chris.january@arm.com>
7123             David Lecomber  <david.lecomber@arm.com>
7124
7125         * f-exp.y: New token, UNOP_INTRINSIC.
7126         (exp): New pattern using UNOP_INTRINSIC token.
7127         (f77_keywords): Add 'abs' keyword.
7128         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
7129         (value_from_host_double): New function.
7130         (evaluate_subexp_f): Support UNOP_ABS.
7131
7132 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7133
7134         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
7135         types.
7136
7137 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7138
7139         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
7140         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
7141         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
7142
7143 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7144
7145         * f-exp.y (convert_to_kind_type): Handle more type kinds.
7146
7147 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7148             Chris January  <chris.january@arm.com>
7149
7150         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
7151         * f-exp.y: Define 'KIND' token.
7152         (exp): New pattern for KIND expressions.
7153         (ptype): Handle types with a kind extension.
7154         (direct_abs_decl): Extend to spot kind extensions.
7155         (f77_keywords): Add 'kind' to the list.
7156         (push_kind_type): New function.
7157         (convert_to_kind_type): New function.
7158         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
7159         * parse.c (operator_length_standard): Likewise.
7160         * parser-defs.h (enum type_pieces): Add tp_kind.
7161         * std-operator.def: Add UNOP_KIND.
7162
7163 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7164
7165         * f-exp.y (f_parse): Set yydebug.
7166
7167 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7168
7169         * f-lang.c (evaluate_subexp_f): New function.
7170         (exp_descriptor_f): New global.
7171         (f_language_defn): Use exp_descriptor_f instead of
7172         exp_descriptor_standard.
7173
7174 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7175
7176         * f-exp.y (struct token): Add comments.
7177         (dot_ops): Remove uppercase versions and the end marker.
7178         (f77_keywords): Likewise.
7179         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
7180         entries in the dot_ops array are case insensitive, and use
7181         strncasecmp to compare strings.  Also some whitespace cleanup in
7182         this area.  Similar for the f77_keywords array, except entries in
7183         this list might be case sensitive.
7184
7185 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7186
7187         * f-exp.y (struct f77_boolean_val): Add comments.
7188         (boolean_values): Remove uppercase versions, and end marker.
7189         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
7190         and use strncasecmp to achieve case insensitivity.  Additionally,
7191         perform whitespace cleanup around this code.
7192
7193 2019-03-06  Tom Tromey  <tromey@adacore.com>
7194
7195         * remote-sim.c (gdbsim_target_open): Use result of
7196         gdb_argv::release.
7197
7198 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
7199         Dirk Schubert  <dirk.schubert@arm.com>
7200         Chris January  <chris.january@arm.com>
7201
7202         * eval.c (evaluate_subexp_standard): Call Fortran argument
7203         wrapping logic.
7204         * f-lang.c (struct value): A value which can be passed into a
7205         Fortran function call.
7206         (fortran_argument_convert): Wrap Fortran arguments in a pointer
7207         where appropriate.
7208         (struct type): Value ready for a Fortran function call.
7209         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
7210         is needed.
7211         * f-lang.h (fortran_argument_convert): Declaration.
7212         (fortran_preserve_arg_pointer): Declaration.
7213         * infcall.c (value_arg_coerce): Call Fortran argument logic.
7214
7215 2019-03-05  Tom Tromey  <tromey@adacore.com>
7216
7217         * python/py-prettyprint.c (print_string_repr): Remove #if.
7218         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
7219
7220 2019-03-05  Tom Tromey  <tromey@adacore.com>
7221
7222         * target.c (the_dummy_target): Move later.  Change type to
7223         "dummy_target".
7224         (initialize_targets): Don't initialize the_dummy_target.
7225
7226 2019-03-05  Tom Tromey  <tromey@adacore.com>
7227
7228         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
7229         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
7230
7231 2019-03-05  Tom Tromey  <tromey@adacore.com>
7232
7233         * windows-nat.c (windows_nat_target::attach)
7234         (windows_nat_target::detach): Don't call gdb_flush.
7235         * valprint.c (generic_val_print, val_print, val_print_string):
7236         Don't call gdb_flush.
7237         * utils.c (defaulted_query): Don't call gdb_flush.
7238         * typeprint.c (print_type_scalar): Don't call gdb_flush.
7239         * target.c (target_announce_detach): Don't call gdb_flush.
7240         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
7241         * remote.c (extended_remote_target::attach): Don't call
7242         gdb_flush.
7243         * procfs.c (procfs_target::detach): Don't call gdb_flush.
7244         * printcmd.c (do_examine): Don't call gdb_flush.
7245         (info_display_command): Don't call gdb_flush.
7246         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
7247         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
7248         * memattr.c (info_mem_command): Don't call gdb_flush.
7249         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
7250         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
7251         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
7252         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
7253         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
7254         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
7255         (gnu_nat_target::detach): Don't call gdb_flush.
7256         * f-valprint.c (f_val_print): Don't call gdb_flush.
7257         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
7258         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
7259         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
7260         gdb_flush.
7261         * c-valprint.c (c_val_print): Don't call gdb_flush.
7262         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
7263
7264 2019-03-05  Tom Tromey  <tromey@adacore.com>
7265
7266         * varobj.c (update_dynamic_varobj_children): Update.
7267         (install_default_visualizer): Use reset, not release.
7268         * value.c (set_internalvar): Update.
7269         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
7270         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
7271         ATTRIBUTE_UNUSED_RESULT.
7272
7273 2019-03-05  Tom Tromey  <tromey@adacore.com>
7274
7275         * remote.c (class scoped_remote_fd) <release>: Add
7276         ATTRIBUTE_UNUSED_RESULT.
7277
7278 2019-03-05  Tom Tromey  <tromey@adacore.com>
7279
7280         * macroexp.c (struct macro_buffer) <release>: Add
7281         ATTRIBUTE_UNUSED_RESULT.
7282
7283 2019-03-05  Tom Tromey  <tromey@adacore.com>
7284
7285         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
7286         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
7287         ATTRIBUTE_UNUSED_RESULT.
7288
7289 2019-03-05  Tom Tromey  <tromey@adacore.com>
7290
7291         * common/scoped_fd.h (class scoped_fd) <release>: Add
7292         ATTRIBUTE_UNUSED_RESULT.
7293
7294 2019-03-05  Tom Tromey  <tromey@adacore.com>
7295
7296         * parser-defs.h (struct parser_state) <release>: Add
7297         ATTRIBUTE_UNUSED_RESULT.
7298
7299 2019-03-05  Tom Tromey  <tromey@adacore.com>
7300
7301         * utils.h (class gdb_argv) <release>: Add
7302         ATTRIBUTE_UNUSED_RESULT.
7303         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
7304
7305 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
7306
7307         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
7308         for-loop range, to avoid compiler warnings.
7309
7310         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
7311         avoid compiler warnings about unused variables.
7312
7313         * NEWS: Mention end of support for native debugging on MS-Windows
7314         before XP.
7315
7316         PR gdb/24292
7317         * common/netstuff.c:
7318         * gdbserver/gdbreplay.c
7319         * gdbserver/remote-utils.c:
7320         * ser-tcp.c:
7321         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
7322         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
7323         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
7324         'getaddrinfo' and 'freeaddrinfo' were not available before
7325         Windows XP, and mingw.org's MinGW headers by default define
7326         _WIN32_WINNT to 0x500.
7327
7328 2019-03-01  Gary Benson <gbenson@redhat.com>
7329
7330         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
7331
7332 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
7333             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
7334
7335         PR gdb/8527
7336         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
7337         set_sigint_trap, clear_sigint_trap.
7338
7339 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7340
7341         * target.c (target_detach): Clear the regcache and the
7342         frame cache.
7343
7344 2019-02-27  Pedro Alves  <palves@redhat.com>
7345
7346         * utils.c (set_screen_size): When we cap the height/width sizes,
7347         tweak the corresponding command variable to show "unlimited":
7348
7349 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
7350             Pedro Alves  <palves@redhat.com>
7351
7352         * utils.c (set_screen_size): Reduce "infinite" rows and columns
7353         before calling rl_set_screen_size.
7354
7355 2019-02-27  Tom Tromey  <tromey@adacore.com>
7356
7357         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
7358         define.
7359         * python/py-value.c: Remove Python 2.4 workaround.
7360         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
7361         workaround.
7362         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
7363         Python 2.4 workaround.
7364         * python/python-internal.h: Remove Python 2.4 comment.
7365         (Py_ssize_t): Don't define.
7366         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
7367         (gdb_Py_DECREF): Remove Python 2.4 workaround.
7368         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
7369         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
7370         * python/python.c (do_start_initialization): Remove Python 2.4
7371         workaround.
7372         * python/py-prettyprint.c (class dummy_python_frame): Remove.
7373         (print_children): Remove Python 2.4 workaround.
7374         * python/py-inferior.c (buffer_procs): Remove Python 2.4
7375         workaround.
7376         (CHARBUFFERPROC_NAME): Remove.
7377         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
7378         Python 2.4 workaround.
7379
7380 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7381
7382         * NEWS: Note minimum Python version.
7383
7384 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
7385
7386         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
7387         code from these functions.  Remove corresponding ifdefs.  Use
7388         Py_buffer_up instead of explicit calls to PyBuffer_Release.
7389         Remove gotos and target of gotos.
7390         (infpy_search_memory): Likewise.
7391
7392 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7393
7394         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
7395         (hppa_gdbarch_init): Don't register deleted functions with
7396         gdbarch.
7397
7398 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7399
7400         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
7401         (h8300_unwind_sp): Delete.
7402         (h8300_dummy_id): Delete.
7403         (h8300_gdbarch_init): Don't register deleted functions with
7404         gdbarch.
7405
7406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7407
7408         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
7409         (ft32_unwind_pc): Delete.
7410         (ft32_unwind_sp): Delete.
7411         (ft32_gdbarch_init): Don't register deleted functions with
7412         gdbarch.
7413
7414 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7415
7416         * gdb/frv-tdep.c (frv_dummy_id): Delete.
7417         (frv_unwind_pc): Delete.
7418         (frv_unwind_sp): Delete.
7419         (frv_gdbarch_init): Don't register deleted functions with
7420         gdbarch.
7421
7422 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7423
7424         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
7425         (riscv_unwind_pc): Delete.
7426         (riscv_unwind_sp): Delete.
7427         (riscv_gdbarch_init): Don't register deleted functions with
7428         gdbarch.
7429
7430 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7431
7432         * gdb/csky-tdep.c (csky_dummy_id): Delete.
7433         (csky_unwind_pc): Delete.
7434         (csky_unwind_sp): Delete.
7435         (csky_gdbarch_init): Don't register deleted functions with
7436         gdbarch.
7437
7438 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7439
7440         * gdb/cris-tdep.c (cris_dummy_id): Delete.
7441         (cris_unwind_pc): Delete.
7442         (cris_unwind_sp): Delete.
7443         (cris_gdbarch_init): Don't register deleted functions with
7444         gdbarch.
7445
7446 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7447
7448         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
7449         (bfin_unwind_pc): Delete.
7450         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
7451
7452 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7453
7454         * gdb/arm-tdep.c (arm_dummy_id): Delete.
7455         (arm_unwind_pc): Delete.
7456         (arm_unwind_sp): Delete.
7457         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
7458
7459 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7460
7461         * gdb/arc-tdep.c (arc_dummy_id): Delete.
7462         (arc_unwind_pc): Delete.
7463         (arc_unwind_sp): Delete.
7464         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
7465
7466 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7467
7468         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
7469         (alpha_unwind_pc): Delete.
7470         (alpha_gdbarch_init): Don't register deleted functions with
7471         gdbarch.
7472
7473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7474
7475         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
7476         (aarch64_unwind_pc): Delete.
7477         (aarch64_unwind_sp): Delete.
7478         (aarch64_gdbarch_init): Don't register deleted functions with
7479         gdbarch.
7480
7481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7482
7483         * gdbtypes.c (type_align): Don't consider static members when
7484         computing structure alignment.
7485
7486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7487
7488         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
7489         return 0 for other types.
7490         * arch-utils.c (default_type_align): Always return 0.
7491         * gdbarch.h: Regenerate.
7492         * gdbarch.sh (type_align): Extend comment.
7493         * gdbtypes.c (type_align): Add additional comments, always call
7494         gdbarch_type_align before applying the default rules.
7495         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
7496         generic code will then apply a suitable default.
7497         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
7498         types, return 0 for other types.
7499
7500 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7501
7502         * NEWS: Create a new section for the next release branch.
7503         Rename the section of the current branch, now that it has
7504         been cut.
7505
7506 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
7507
7508         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
7509         * version.in: Bump version to 8.3.50.DATE-git.
7510
7511 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
7512
7513         * aix-thread.c (ptid_cmp): Remove unused variable.
7514         (get_signaled_thread): Likewise.
7515         (store_regs_user_thread): Likewise.
7516         (store_regs_kernel_thread): Likewise.
7517         (fetch_regs_kernel_thread): Remove shadowed variable.
7518
7519 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * features/riscv/32bit-cpu.xml: Add register numbers.
7522         * features/riscv/32bit-fpu.c: Regenerate.
7523         * features/riscv/32bit-fpu.xml: Add register numbers.
7524         * features/riscv/64bit-cpu.xml: Add register numbers.
7525         * features/riscv/64bit-fpu.c: Regenerate.
7526         * features/riscv/64bit-fpu.xml: Add register numbers.
7527
7528 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
7529
7530         * NEWS: Mention two argument form of gdb.Value constructor.
7531         * python/py-value.c (convert_buffer_and_type_to_value): New
7532         function.
7533         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
7534         Add support for handling an optional second argument.  Call
7535         convert_buffer_and_type_to_value as appropriate.
7536         * python/python-internal.h (Py_buffer_deleter): New struct.
7537         (Py_buffer_up): New typedef.
7538
7539 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
7540
7541         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
7542         instead of releasing ownership.
7543
7544 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
7545
7546         * dwarf2read.c (open_and_init_dwp_file): Call
7547         elf_numsections instead of bfd_count_sections to initialize
7548         dwp_file->num_sections.
7549
7550 2019-02-25  Tom Tromey  <tromey@adacore.com>
7551
7552         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
7553
7554 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
7555
7556         * gcore.in: Add '--readnever' option when invoking GDB.
7557
7558 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7559
7560         * MAINTAINERS: Update my email address.
7561
7562 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
7563
7564         * build-id.c (build_id_to_debug_bfd_1): New function.
7565         (build_id_to_debug_bfd): Look for separate debug file in
7566         sysroot.
7567
7568 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
7569
7570         * gdbarch.sh: Update the copyright year range that is placed into
7571         generated files.
7572
7573 2019-02-22  Keith Seitz  <keiths@redhat.com>
7574
7575         PR symtab/23853
7576         * linespec.c (create_sals_line_offset): Search for the default
7577         symtab's filename instead of its fullname.
7578
7579 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7580
7581         * NEWS: Update style defaults.
7582
7583 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
7584
7585         * main.c (captured_main_1): Disable styling in batch mode.
7586
7587 2019-02-20  Tom Tromey  <tom@tromey.com>
7588
7589         * symtab.c (symtab_symbol_info): Fix typos.
7590
7591 2019-02-20  Tom Tromey  <tromey@adacore.com>
7592
7593         * findcmd.c (_initialize_mem_search): Use upper case for
7594         metasyntactic variables.
7595
7596 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
7597
7598         * aarch64-tdep.c (aarch64_add_reggroups): New function.
7599         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
7600
7601 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
7602
7603         * top.h (source_file_name): Change to std::string.
7604         * top.c (source_file_name): Likewise.
7605         (command_line_input): Adjust.
7606         * cli/cli-script.c (script_from_file): Adjust.
7607
7608 2019-02-19  Tom Tromey  <tromey@adacore.com>
7609
7610         * ravenscar-thread.c
7611         (ravenscar_thread_target::update_thread_list): Don't call
7612         ada_build_task_list.
7613         * ada-lang.h (ada_build_task_list): Don't declare.
7614         * ada-tasks.c (struct ada_tasks_inferior_data)
7615         <task_list_valid_p>: Now bool.
7616         (read_known_tasks, ada_task_list_changed)
7617         (ada_tasks_invalidate_inferior_data): Update.
7618         (read_known_tasks_array): Return bool.
7619         (read_known_tasks_list): Likewise.
7620         (read_known_tasks): Return void.
7621         (ada_build_task_list): Now static.
7622
7623 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
7624
7625         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
7626         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
7627
7628 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7629
7630         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
7631         variant for ada_tasks_pspace_data_handle and
7632         ada_tasks_inferior_data_handle.
7633         (ada_tasks_pspace_data_cleanup): New function.
7634         (ada_tasks_inferior_data_cleanup): New function.
7635
7636 2019-02-17  Tom Tromey  <tom@tromey.com>
7637
7638         * macrotab.h (macro_source_fullname): Return a std::string.
7639         * macrotab.c (macro_include, check_for_redefinition)
7640         (macro_undef, macro_lookup_definition, foreach_macro)
7641         (foreach_macro_in_scope): Update.
7642         (macro_source_fullname): Return a std::string.
7643         * macrocmd.c (show_pp_source_pos): Update.
7644
7645 2019-02-17  Tom Tromey  <tom@tromey.com>
7646
7647         * macrocmd.c (show_pp_source_pos): Style the file names.
7648
7649 2019-02-17  Tom Tromey  <tom@tromey.com>
7650
7651         PR tui/24197:
7652         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
7653
7654 2019-02-17  Tom Tromey  <tom@tromey.com>
7655
7656         * ada-lang.c (user_select_syms): Use filtered printing.
7657         * utils.c (wrap_style): New global.
7658         (desired_style): Remove.
7659         (emit_style_escape): Add stream parameter.
7660         (set_output_style, reset_terminal_style, prompt_for_continue):
7661         Update.
7662         (flush_wrap_buffer): Only flush gdb_stdout.
7663         (wrap_here): Set wrap_style.
7664         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
7665         treat escape sequences as a character.  Change when wrap buffer is
7666         flushed.
7667         (fputs_styled): Do not set the output style when the default is
7668         requested.
7669         * ui-style.h (struct ui_file_style) <is_default>: New method.
7670         * source.c (print_source_lines_base): Emit escape sequences in one
7671         piece.
7672
7673 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7674
7675         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
7676         integers and enumeration types.
7677
7678 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
7679
7680         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
7681         instead of lookup_symbol_in_language
7682         (do_exact_match): New function.
7683         (ada_get_symbol_name_matcher): Return do_exact_match when
7684         doing a verbatim match.
7685
7686 2019-02-15  Tom Tromey  <tromey@adacore.com>
7687
7688         * ravenscar-thread.c (ravenscar_thread_target::resume)
7689         (ravenscar_thread_target::wait): Special case wildcard requests.
7690
7691 2019-02-15  Tom Tromey  <tromey@adacore.com>
7692
7693         * ravenscar-thread.c (base_ptid): Remove.
7694         (struct ravenscar_thread_target) <close>: New method.
7695         <m_base_ptid>: New member.
7696         <update_inferior_ptid, active_task, task_is_currently_active,
7697         runtime_initialized>: Declare methods.
7698         <ravenscar_thread_target>: Add constructor.
7699         (ravenscar_thread_target::task_is_currently_active)
7700         (ravenscar_thread_target::update_inferior_ptid)
7701         (ravenscar_runtime_initialized): Rename.  Now methods.
7702         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
7703         (ravenscar_thread_target::update_thread_list): Update.
7704         (ravenscar_thread_target::active_task): Now method.
7705         (ravenscar_thread_target::store_registers)
7706         (ravenscar_thread_target::prepare_to_store)
7707         (ravenscar_thread_target::prepare_to_store)
7708         (ravenscar_thread_target::mourn_inferior): Update.
7709         (ravenscar_inferior_created): Use "new" to create target.
7710         (ravenscar_thread_target::get_ada_task_ptid): Update.
7711         (_initialize_ravenscar): Don't initialize base_ptid.
7712         (ravenscar_ops): Remove global.
7713
7714 2019-02-15  Tom Tromey  <tromey@adacore.com>
7715
7716         * target.h (push_target): Declare new overload.
7717         * target.c (push_target): New overload, taking an rvalue reference.
7718         * remote.c (remote_target::open_1): Use push_target overload.
7719         * corelow.c (core_target_open): Use push_target overload.
7720
7721 2019-02-15  Tom Tromey  <tromey@adacore.com>
7722
7723         * ravenscar-thread.c (is_ravenscar_task)
7724         (ravenscar_task_is_currently_active): Return bool.
7725         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
7726         (_initialize_ravenscar): Remove "(void)".
7727         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
7728         Return bool.
7729
7730 2019-02-15  Tom Tromey  <tromey@adacore.com>
7731
7732         * ravenscar-thread.c (ravenscar_runtime_initializer)
7733         (has_ravenscar_runtime, get_running_thread_id)
7734         (ravenscar_thread_target::resume): Fix indentation.
7735
7736 2019-02-15  Tom Tromey  <tromey@adacore.com>
7737
7738         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
7739         from ravenscar_arch_ops.
7740         (sparc_ravenscar_ops::fetch_registers)
7741         (sparc_ravenscar_ops::store_registers): Now methods.
7742         (sparc_ravenscar_prepare_to_store): Remove.
7743         (sparc_ravenscar_ops): Redefine.
7744         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
7745         methods and destructor.  Remove members.
7746         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
7747         (ravenscar_thread_target::store_registers)
7748         (ravenscar_thread_target::prepare_to_store): Update.
7749         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
7750         Remove.
7751         (struct ppc_ravenscar_powerpc_ops): Derive from
7752         ravenscar_arch_ops.
7753         (ppc_ravenscar_powerpc_ops::fetch_registers)
7754         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
7755         (ppc_ravenscar_powerpc_ops): Redefine.
7756         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
7757         (ppc_ravenscar_e500_ops::fetch_registers)
7758         (ppc_ravenscar_e500_ops::store_registers): Now methods.
7759         (ppc_ravenscar_e500_ops): Redefine.
7760         * aarch64-ravenscar-thread.c
7761         (aarch64_ravenscar_generic_prepare_to_store): Remove.
7762         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
7763         (aarch64_ravenscar_fetch_registers)
7764         (aarch64_ravenscar_store_registers): Now methods.
7765         (aarch64_ravenscar_ops): Redefine.
7766
7767 2019-02-15  Tom Tromey  <tromey@adacore.com>
7768
7769         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
7770         (ravenscar_thread_target::stopped_by_hw_breakpoint)
7771         (ravenscar_thread_target::stopped_by_watchpoint)
7772         (ravenscar_thread_target::stopped_data_address)
7773         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
7774
7775 2019-02-15  Tom Tromey  <tromey@adacore.com>
7776
7777         * ravenscar-thread.c: Fix some typos.
7778
7779 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7780             Tom Tromey  <tromey@adacore.com>
7781
7782         * ada-lang.c (ada_exception_sal): Change addr_string to a
7783         std::string.
7784         (create_ada_exception_catchpoint): Update.
7785
7786 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7787             Tom Tromey  <tromey@adacore.com>
7788
7789         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
7790         (bp_location_ops): Remove.
7791         (base_breakpoint_allocate_location): Update.
7792         (free_bp_location): Update.
7793         * ada-lang.c (class ada_catchpoint_location)
7794         <ada_catchpoint_location>: Remove ops parameter.
7795         (ada_catchpoint_location_dtor): Remove.
7796         (ada_catchpoint_location_ops): Remove.
7797         (allocate_location_exception): Update.
7798         * breakpoint.h (struct bp_location_ops): Remove.
7799         (class bp_location) <bp_location>: Remove bp_location_ops
7800         parameter.
7801         <~bp_location>: Add destructor.
7802         <ops>: Remove.
7803
7804 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7805             Pedro Alves  <palves@redhat.com>
7806
7807         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
7808         'PATH_MAX'.
7809
7810 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7811             Samuel Thibault  <samuel.thibault@gnu.org>
7812             Thomas Schwinge  <thomas@codesourcery.com>
7813
7814         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7815         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7816
7817 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7818
7819         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7820         (check_empty): Use "const char *".
7821
7822         * gnu-nat.c (gnu_nat_target::detach): Instead of
7823         'detach_inferior (pid)' call
7824         'detach_inferior (find_inferior_pid (pid))'.
7825
7826         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7827         'nat/fork-inferior.o'.
7828         * gnu-nat.c: #include "nat/fork-inferior.h".
7829
7830         * gnu-nat.c (gnu_nat_target::detach): Instead of
7831         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7832         * gnu-nat.h: #include "inf-child.h".
7833         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7834         'i386_gnu_nat_target::fetch_registers'.
7835         (gnu_store_registers): Rename/move to
7836         'i386_gnu_nat_target::store_registers'.
7837
7838         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7839         * gnu-nat.h (mach_thread_info): New function.
7840         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7841
7842         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7843
7844 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7845
7846         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7847
7848 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7849
7850         * windows-nat.c (windows_add_thread): Add new parameter
7851         "main_thread_p" with default value set to false.  Update
7852         function documentation as well as all callers.
7853         (windows_delete_thread): Likewise.
7854         (fake_create_process): Update call to windows_add_thread.
7855         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7856         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7857         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7858         call to windows_delete_thread.
7859
7860 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7861
7862         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7863
7864 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7865
7866         * symfile.c (find_separate_debug_file): Use canonical path of
7867         sysroot with child_path instead of gdb_sysroot if it is valid.
7868
7869 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7870
7871         * symfile.c (find_separate_debug_file): Use child_path to
7872         determine if an object file is under a sysroot.
7873
7874 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7875
7876         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7877         unittests/child-path-selftests.c.
7878         * common/pathstuff.c (child_path): New function.
7879         * common/pathstuff.h (child_path): New prototype.
7880         * unittests/child-path-selftests.c: New file.
7881
7882 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7883
7884         * symfile.c (find_separate_debug_file): Look for separate debug
7885         files in debug directories under the sysroot.
7886
7887 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7888
7889         * symtab.h (struct minimal_symbol data_p): New const method.
7890         (struct minimal_symbol text_p): Likewise.
7891         * symtab.c (output_source_filename): Use file name style
7892         to print file name.
7893         (print_symbol_info): Likewise.
7894         (print_msymbol_info): Use address style to print addresses.
7895         Use function name style to print executable text symbols.
7896         (expand_symtab_containing_pc): Use data_p.
7897         (find_pc_sect_compunit_symtab): Likewise.
7898
7899 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7900
7901         * breakpoint.c (describe_other_breakpoints): Use address style
7902         to print addresses.
7903         (say_where): Likewise.
7904
7905 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7906
7907         * ada-typeprint.c (print_func_type): Print function name
7908         style to print function name.
7909         * c-typeprint.c (c_print_type_1): Likewise.
7910
7911 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7912
7913         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7914         for execve.
7915
7916 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7917
7918         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7919         type_stack.
7920
7921 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7922
7923         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7924         TYPE_CODE_REF types.
7925
7926 2019-02-08  Jim Wilson  <jimw@sifive.com>
7927
7928         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7929         (riscv_linux_fregset): New.
7930         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7931
7932 2019-02-07  Tom Tromey  <tom@tromey.com>
7933
7934         * thread.c (thread_cancel_execution_command): Update.
7935         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7936         methods.
7937         (struct thread_fsm_ops): Remove.
7938         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7939         (thread_fsm_should_stop, thread_fsm_return_value)
7940         (thread_fsm_set_finished, thread_fsm_finished_p)
7941         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7942         Don't declare.
7943         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7944         * infrun.c (clear_proceed_status_thread)
7945         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7946         (print_stop_event): Update.
7947         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7948         Add constructor.
7949         (step_command_fsm_ops): Remove.
7950         (new_step_command_fsm): Remove.
7951         (step_1): Update.
7952         (step_command_fsm::should_stop): Rename from
7953         step_command_fsm_should_stop.
7954         (step_command_fsm::clean_up): Rename from
7955         step_command_fsm_clean_up.
7956         (step_command_fsm::do_async_reply_reason): Rename from
7957         step_command_fsm_async_reply_reason.
7958         (struct until_next_fsm): Inherit from thread_fsm.  Add
7959         constructor.
7960         (until_next_fsm_ops): Remove.
7961         (new_until_next_fsm): Remove.
7962         (until_next_fsm::should_stop): Rename from
7963         until_next_fsm_should_stop.
7964         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7965         (until_next_fsm::do_async_reply_reason): Rename from
7966         until_next_fsm_async_reply_reason.
7967         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7968         constructor.  Change type of breakpoint.
7969         (finish_command_fsm_ops): Remove.
7970         (new_finish_command_fsm): Remove.
7971         (finish_command_fsm::should_stop): Rename from
7972         finish_command_fsm_should_stop.
7973         (finish_command_fsm::clean_up): Rename from
7974         finish_command_fsm_clean_up.
7975         (finish_command_fsm::return_value): Rename from
7976         finish_command_fsm_return_value.
7977         (finish_command_fsm::do_async_reply_reason): Rename from
7978         finish_command_fsm_async_reply_reason.
7979         (finish_command): Update.
7980         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7981         Add constructor.
7982         (call_thread_fsm_ops): Remove.
7983         (call_thread_fsm::call_thread_fsm): Rename from
7984         new_call_thread_fsm.
7985         (call_thread_fsm::should_stop): Rename from
7986         call_thread_fsm_should_stop.
7987         (call_thread_fsm::should_notify_stop): Rename from
7988         call_thread_fsm_should_notify_stop.
7989         (run_inferior_call, call_function_by_hand_dummy): Update.
7990         * cli/cli-interp.c (should_print_stop_to_console): Update.
7991         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7992         Add constructor.  Change type of location_breakpoint,
7993         caller_breakpoint.
7994         (until_break_fsm_ops): Remove.
7995         (new_until_break_fsm): Remove.
7996         (until_break_fsm::should_stop): Rename from
7997         until_break_fsm_should_stop.
7998         (until_break_fsm::clean_up): Rename from
7999         until_break_fsm_clean_up.
8000         (until_break_fsm::do_async_reply_reason): Rename from
8001         until_break_fsm_async_reply_reason.
8002         (until_break_command): Update.
8003         * thread-fsm.c: Remove.
8004         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
8005
8006 2019-02-07  Tom Tromey  <tom@tromey.com>
8007
8008         * yy-remap.h: Add include guard.
8009         * xtensa-tdep.h: Add include guard.
8010         * xcoffread.h: Rename include guard.
8011         * varobj-iter.h: Add include guard.
8012         * tui/tui.h: Rename include guard.
8013         * tui/tui-winsource.h: Rename include guard.
8014         * tui/tui-wingeneral.h: Rename include guard.
8015         * tui/tui-windata.h: Rename include guard.
8016         * tui/tui-win.h: Rename include guard.
8017         * tui/tui-stack.h: Rename include guard.
8018         * tui/tui-source.h: Rename include guard.
8019         * tui/tui-regs.h: Rename include guard.
8020         * tui/tui-out.h: Rename include guard.
8021         * tui/tui-layout.h: Rename include guard.
8022         * tui/tui-io.h: Rename include guard.
8023         * tui/tui-hooks.h: Rename include guard.
8024         * tui/tui-file.h: Rename include guard.
8025         * tui/tui-disasm.h: Rename include guard.
8026         * tui/tui-data.h: Rename include guard.
8027         * tui/tui-command.h: Rename include guard.
8028         * tic6x-tdep.h: Add include guard.
8029         * target/waitstatus.h: Rename include guard.
8030         * target/wait.h: Rename include guard.
8031         * target/target.h: Rename include guard.
8032         * target/resume.h: Rename include guard.
8033         * target-float.h: Rename include guard.
8034         * stabsread.h: Add include guard.
8035         * rs6000-tdep.h: Add include guard.
8036         * riscv-fbsd-tdep.h: Add include guard.
8037         * regformats/regdef.h: Rename include guard.
8038         * record.h: Rename include guard.
8039         * python/python.h: Rename include guard.
8040         * python/python-internal.h: Rename include guard.
8041         * python/py-stopevent.h: Rename include guard.
8042         * python/py-ref.h: Rename include guard.
8043         * python/py-record.h: Rename include guard.
8044         * python/py-record-full.h: Rename include guard.
8045         * python/py-record-btrace.h: Rename include guard.
8046         * python/py-instruction.h: Rename include guard.
8047         * python/py-events.h: Rename include guard.
8048         * python/py-event.h: Rename include guard.
8049         * procfs.h: Add include guard.
8050         * proc-utils.h: Add include guard.
8051         * p-lang.h: Add include guard.
8052         * or1k-tdep.h: Rename include guard.
8053         * observable.h: Rename include guard.
8054         * nto-tdep.h: Rename include guard.
8055         * nat/x86-linux.h: Rename include guard.
8056         * nat/x86-linux-dregs.h: Rename include guard.
8057         * nat/x86-gcc-cpuid.h: Add include guard.
8058         * nat/x86-dregs.h: Rename include guard.
8059         * nat/x86-cpuid.h: Rename include guard.
8060         * nat/ppc-linux.h: Rename include guard.
8061         * nat/mips-linux-watch.h: Rename include guard.
8062         * nat/linux-waitpid.h: Rename include guard.
8063         * nat/linux-ptrace.h: Rename include guard.
8064         * nat/linux-procfs.h: Rename include guard.
8065         * nat/linux-osdata.h: Rename include guard.
8066         * nat/linux-nat.h: Rename include guard.
8067         * nat/linux-namespaces.h: Rename include guard.
8068         * nat/linux-btrace.h: Rename include guard.
8069         * nat/glibc_thread_db.h: Rename include guard.
8070         * nat/gdb_thread_db.h: Rename include guard.
8071         * nat/gdb_ptrace.h: Rename include guard.
8072         * nat/fork-inferior.h: Rename include guard.
8073         * nat/amd64-linux-siginfo.h: Rename include guard.
8074         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
8075         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
8076         * nat/aarch64-linux.h: Rename include guard.
8077         * nat/aarch64-linux-hw-point.h: Rename include guard.
8078         * mn10300-tdep.h: Add include guard.
8079         * mips-linux-tdep.h: Add include guard.
8080         * mi/mi-parse.h: Rename include guard.
8081         * mi/mi-out.h: Rename include guard.
8082         * mi/mi-main.h: Rename include guard.
8083         * mi/mi-interp.h: Rename include guard.
8084         * mi/mi-getopt.h: Rename include guard.
8085         * mi/mi-console.h: Rename include guard.
8086         * mi/mi-common.h: Rename include guard.
8087         * mi/mi-cmds.h: Rename include guard.
8088         * mi/mi-cmd-break.h: Rename include guard.
8089         * m2-lang.h: Add include guard.
8090         * location.h: Rename include guard.
8091         * linux-record.h: Rename include guard.
8092         * linux-nat.h: Add include guard.
8093         * linux-fork.h: Add include guard.
8094         * i386-darwin-tdep.h: Rename include guard.
8095         * hppa-linux-offsets.h: Add include guard.
8096         * guile/guile.h: Rename include guard.
8097         * guile/guile-internal.h: Rename include guard.
8098         * gnu-nat.h: Rename include guard.
8099         * gdb-stabs.h: Rename include guard.
8100         * frv-tdep.h: Add include guard.
8101         * f-lang.h: Add include guard.
8102         * event-loop.h: Add include guard.
8103         * darwin-nat.h: Rename include guard.
8104         * cp-abi.h: Rename include guard.
8105         * config/sparc/nm-sol2.h: Rename include guard.
8106         * config/nm-nto.h: Rename include guard.
8107         * config/nm-linux.h: Add include guard.
8108         * config/i386/nm-i386gnu.h: Rename include guard.
8109         * config/djgpp/nl_types.h: Rename include guard.
8110         * config/djgpp/langinfo.h: Rename include guard.
8111         * compile/gcc-cp-plugin.h: Add include guard.
8112         * compile/gcc-c-plugin.h: Add include guard.
8113         * compile/compile.h: Rename include guard.
8114         * compile/compile-object-run.h: Rename include guard.
8115         * compile/compile-object-load.h: Rename include guard.
8116         * compile/compile-internal.h: Rename include guard.
8117         * compile/compile-cplus.h: Rename include guard.
8118         * compile/compile-c.h: Rename include guard.
8119         * common/xml-utils.h: Rename include guard.
8120         * common/x86-xstate.h: Rename include guard.
8121         * common/version.h: Rename include guard.
8122         * common/vec.h: Rename include guard.
8123         * common/tdesc.h: Rename include guard.
8124         * common/selftest.h: Rename include guard.
8125         * common/scoped_restore.h: Rename include guard.
8126         * common/scoped_mmap.h: Rename include guard.
8127         * common/scoped_fd.h: Rename include guard.
8128         * common/safe-iterator.h: Rename include guard.
8129         * common/run-time-clock.h: Rename include guard.
8130         * common/refcounted-object.h: Rename include guard.
8131         * common/queue.h: Rename include guard.
8132         * common/ptid.h: Rename include guard.
8133         * common/print-utils.h: Rename include guard.
8134         * common/preprocessor.h: Rename include guard.
8135         * common/pathstuff.h: Rename include guard.
8136         * common/observable.h: Rename include guard.
8137         * common/netstuff.h: Rename include guard.
8138         * common/job-control.h: Rename include guard.
8139         * common/host-defs.h: Rename include guard.
8140         * common/gdb_wait.h: Rename include guard.
8141         * common/gdb_vecs.h: Rename include guard.
8142         * common/gdb_unlinker.h: Rename include guard.
8143         * common/gdb_unique_ptr.h: Rename include guard.
8144         * common/gdb_tilde_expand.h: Rename include guard.
8145         * common/gdb_sys_time.h: Rename include guard.
8146         * common/gdb_string_view.h: Rename include guard.
8147         * common/gdb_splay_tree.h: Rename include guard.
8148         * common/gdb_setjmp.h: Rename include guard.
8149         * common/gdb_ref_ptr.h: Rename include guard.
8150         * common/gdb_optional.h: Rename include guard.
8151         * common/gdb_locale.h: Rename include guard.
8152         * common/gdb_assert.h: Rename include guard.
8153         * common/filtered-iterator.h: Rename include guard.
8154         * common/filestuff.h: Rename include guard.
8155         * common/fileio.h: Rename include guard.
8156         * common/environ.h: Rename include guard.
8157         * common/common-utils.h: Rename include guard.
8158         * common/common-types.h: Rename include guard.
8159         * common/common-regcache.h: Rename include guard.
8160         * common/common-inferior.h: Rename include guard.
8161         * common/common-gdbthread.h: Rename include guard.
8162         * common/common-exceptions.h: Rename include guard.
8163         * common/common-defs.h: Rename include guard.
8164         * common/common-debug.h: Rename include guard.
8165         * common/cleanups.h: Rename include guard.
8166         * common/buffer.h: Rename include guard.
8167         * common/btrace-common.h: Rename include guard.
8168         * common/break-common.h: Rename include guard.
8169         * cli/cli-utils.h: Rename include guard.
8170         * cli/cli-style.h: Rename include guard.
8171         * cli/cli-setshow.h: Rename include guard.
8172         * cli/cli-script.h: Rename include guard.
8173         * cli/cli-interp.h: Rename include guard.
8174         * cli/cli-decode.h: Rename include guard.
8175         * cli/cli-cmds.h: Rename include guard.
8176         * charset-list.h: Add include guard.
8177         * buildsym-legacy.h: Rename include guard.
8178         * bfin-tdep.h: Add include guard.
8179         * ax.h: Rename include guard.
8180         * arm-linux-tdep.h: Add include guard.
8181         * arm-fbsd-tdep.h: Add include guard.
8182         * arch/xtensa.h: Rename include guard.
8183         * arch/tic6x.h: Add include guard.
8184         * arch/i386.h: Add include guard.
8185         * arch/arm.h: Rename include guard.
8186         * arch/arm-linux.h: Rename include guard.
8187         * arch/arm-get-next-pcs.h: Rename include guard.
8188         * arch/amd64.h: Add include guard.
8189         * arch/aarch64-insn.h: Rename include guard.
8190         * arch-utils.h: Rename include guard.
8191         * annotate.h: Add include guard.
8192         * amd64-darwin-tdep.h: Rename include guard.
8193         * aarch64-linux-tdep.h: Add include guard.
8194         * aarch64-fbsd-tdep.h: Add include guard.
8195         * aarch32-linux-nat.h: Add include guard.
8196
8197 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8198
8199         * macrotab.c (macro_define_internal): New function that
8200         factorizes macro_define_object_internal and macro_define_function
8201         code.
8202         (macro_define_object_internal): Use macro_define_internal.
8203         (macro_define_function): Likewise.
8204
8205 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8206
8207         * macrocmd.c (extract_identifier): Return
8208         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
8209         callers.
8210
8211 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
8212
8213         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
8214
8215 2019-02-05  Tom Tromey  <tom@tromey.com>
8216
8217         * target.c (target_stack::unpush): Move assertion earlier.
8218
8219 2019-01-30  Tom Tromey  <tom@tromey.com>
8220
8221         PR python/23615:
8222         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
8223         (gdbpy_parse_and_eval): Likewise.
8224         * python/python-internal.h (gdbpy_allow_threads): New class.
8225
8226 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
8227
8228         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
8229         (aarch64_fbsd_fpregmap): Move earlier.
8230         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
8231         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8232         instead of individual calls to trad_frame_set_reg_addr.
8233         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
8234         earlier.
8235         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
8236         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
8237         instead of individual calls to trad_frame_set_reg_addr.
8238
8239 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
8240
8241         * CONTRIBUTE: Replace contribution list with wiki link.
8242
8243 2019-01-25  Tom Tromey  <tom@tromey.com>
8244
8245         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
8246
8247 2019-01-25  Tom Tromey  <tom@tromey.com>
8248
8249         * xtensa-linux-nat.c: Fix common/ includes.
8250         * xml-support.h: Fix common/ includes.
8251         * xml-support.c: Fix common/ includes.
8252         * x86-linux-nat.c: Fix common/ includes.
8253         * windows-nat.c: Fix common/ includes.
8254         * varobj.h: Fix common/ includes.
8255         * varobj.c: Fix common/ includes.
8256         * value.c: Fix common/ includes.
8257         * valops.c: Fix common/ includes.
8258         * utils.c: Fix common/ includes.
8259         * unittests/xml-utils-selftests.c: Fix common/ includes.
8260         * unittests/utils-selftests.c: Fix common/ includes.
8261         * unittests/unpack-selftests.c: Fix common/ includes.
8262         * unittests/tracepoint-selftests.c: Fix common/ includes.
8263         * unittests/style-selftests.c: Fix common/ includes.
8264         * unittests/string_view-selftests.c: Fix common/ includes.
8265         * unittests/scoped_restore-selftests.c: Fix common/ includes.
8266         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
8267         * unittests/scoped_fd-selftests.c: Fix common/ includes.
8268         * unittests/rsp-low-selftests.c: Fix common/ includes.
8269         * unittests/parse-connection-spec-selftests.c: Fix common/
8270         includes.
8271         * unittests/optional-selftests.c: Fix common/ includes.
8272         * unittests/offset-type-selftests.c: Fix common/ includes.
8273         * unittests/observable-selftests.c: Fix common/ includes.
8274         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
8275         * unittests/memrange-selftests.c: Fix common/ includes.
8276         * unittests/memory-map-selftests.c: Fix common/ includes.
8277         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
8278         * unittests/function-view-selftests.c: Fix common/ includes.
8279         * unittests/environ-selftests.c: Fix common/ includes.
8280         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
8281         * unittests/common-utils-selftests.c: Fix common/ includes.
8282         * unittests/cli-utils-selftests.c: Fix common/ includes.
8283         * unittests/array-view-selftests.c: Fix common/ includes.
8284         * ui-file.c: Fix common/ includes.
8285         * tui/tui-io.c: Fix common/ includes.
8286         * tracepoint.h: Fix common/ includes.
8287         * tracepoint.c: Fix common/ includes.
8288         * tracefile-tfile.c: Fix common/ includes.
8289         * top.h: Fix common/ includes.
8290         * top.c: Fix common/ includes.
8291         * thread.c: Fix common/ includes.
8292         * target/waitstatus.h: Fix common/ includes.
8293         * target/waitstatus.c: Fix common/ includes.
8294         * target.h: Fix common/ includes.
8295         * target.c: Fix common/ includes.
8296         * target-memory.c: Fix common/ includes.
8297         * target-descriptions.c: Fix common/ includes.
8298         * symtab.h: Fix common/ includes.
8299         * symfile.c: Fix common/ includes.
8300         * stap-probe.c: Fix common/ includes.
8301         * spu-linux-nat.c: Fix common/ includes.
8302         * sparc-nat.c: Fix common/ includes.
8303         * source.c: Fix common/ includes.
8304         * solib.c: Fix common/ includes.
8305         * solib-target.c: Fix common/ includes.
8306         * ser-unix.c: Fix common/ includes.
8307         * ser-tcp.c: Fix common/ includes.
8308         * ser-pipe.c: Fix common/ includes.
8309         * ser-base.c: Fix common/ includes.
8310         * selftest-arch.c: Fix common/ includes.
8311         * s12z-tdep.c: Fix common/ includes.
8312         * rust-exp.y: Fix common/ includes.
8313         * rs6000-aix-tdep.c: Fix common/ includes.
8314         * riscv-tdep.c: Fix common/ includes.
8315         * remote.c: Fix common/ includes.
8316         * remote-notif.h: Fix common/ includes.
8317         * remote-fileio.h: Fix common/ includes.
8318         * remote-fileio.c: Fix common/ includes.
8319         * regcache.h: Fix common/ includes.
8320         * regcache.c: Fix common/ includes.
8321         * record-btrace.c: Fix common/ includes.
8322         * python/python.c: Fix common/ includes.
8323         * python/py-type.c: Fix common/ includes.
8324         * python/py-inferior.c: Fix common/ includes.
8325         * progspace.h: Fix common/ includes.
8326         * producer.c: Fix common/ includes.
8327         * procfs.c: Fix common/ includes.
8328         * proc-api.c: Fix common/ includes.
8329         * printcmd.c: Fix common/ includes.
8330         * ppc-linux-nat.c: Fix common/ includes.
8331         * parser-defs.h: Fix common/ includes.
8332         * osdata.c: Fix common/ includes.
8333         * obsd-nat.c: Fix common/ includes.
8334         * nat/x86-linux.c: Fix common/ includes.
8335         * nat/x86-linux-dregs.c: Fix common/ includes.
8336         * nat/x86-dregs.h: Fix common/ includes.
8337         * nat/x86-dregs.c: Fix common/ includes.
8338         * nat/ppc-linux.c: Fix common/ includes.
8339         * nat/mips-linux-watch.h: Fix common/ includes.
8340         * nat/mips-linux-watch.c: Fix common/ includes.
8341         * nat/linux-waitpid.c: Fix common/ includes.
8342         * nat/linux-ptrace.h: Fix common/ includes.
8343         * nat/linux-ptrace.c: Fix common/ includes.
8344         * nat/linux-procfs.c: Fix common/ includes.
8345         * nat/linux-personality.c: Fix common/ includes.
8346         * nat/linux-osdata.c: Fix common/ includes.
8347         * nat/linux-namespaces.c: Fix common/ includes.
8348         * nat/linux-btrace.h: Fix common/ includes.
8349         * nat/linux-btrace.c: Fix common/ includes.
8350         * nat/fork-inferior.c: Fix common/ includes.
8351         * nat/amd64-linux-siginfo.c: Fix common/ includes.
8352         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
8353         * nat/aarch64-linux.c: Fix common/ includes.
8354         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
8355         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
8356         * namespace.h: Fix common/ includes.
8357         * mips-linux-tdep.c: Fix common/ includes.
8358         * minsyms.c: Fix common/ includes.
8359         * mi/mi-parse.h: Fix common/ includes.
8360         * mi/mi-main.c: Fix common/ includes.
8361         * mi/mi-cmd-env.c: Fix common/ includes.
8362         * memrange.h: Fix common/ includes.
8363         * memattr.c: Fix common/ includes.
8364         * maint.h: Fix common/ includes.
8365         * maint.c: Fix common/ includes.
8366         * main.c: Fix common/ includes.
8367         * machoread.c: Fix common/ includes.
8368         * location.c: Fix common/ includes.
8369         * linux-thread-db.c: Fix common/ includes.
8370         * linux-nat.c: Fix common/ includes.
8371         * linux-fork.c: Fix common/ includes.
8372         * inline-frame.c: Fix common/ includes.
8373         * infrun.c: Fix common/ includes.
8374         * inflow.c: Fix common/ includes.
8375         * inferior.h: Fix common/ includes.
8376         * inferior.c: Fix common/ includes.
8377         * infcmd.c: Fix common/ includes.
8378         * inf-ptrace.c: Fix common/ includes.
8379         * inf-child.c: Fix common/ includes.
8380         * ia64-linux-nat.c: Fix common/ includes.
8381         * i387-tdep.c: Fix common/ includes.
8382         * i386-tdep.c: Fix common/ includes.
8383         * i386-linux-tdep.c: Fix common/ includes.
8384         * i386-linux-nat.c: Fix common/ includes.
8385         * i386-go32-tdep.c: Fix common/ includes.
8386         * i386-fbsd-tdep.c: Fix common/ includes.
8387         * i386-fbsd-nat.c: Fix common/ includes.
8388         * guile/scm-type.c: Fix common/ includes.
8389         * guile/guile.c: Fix common/ includes.
8390         * go32-nat.c: Fix common/ includes.
8391         * gnu-nat.c: Fix common/ includes.
8392         * gdbthread.h: Fix common/ includes.
8393         * gdbarch-selftests.c: Fix common/ includes.
8394         * gdb_usleep.c: Fix common/ includes.
8395         * gdb_select.h: Fix common/ includes.
8396         * gdb_bfd.c: Fix common/ includes.
8397         * gcore.c: Fix common/ includes.
8398         * fork-child.c: Fix common/ includes.
8399         * findvar.c: Fix common/ includes.
8400         * fbsd-nat.c: Fix common/ includes.
8401         * event-top.c: Fix common/ includes.
8402         * event-loop.c: Fix common/ includes.
8403         * dwarf2read.c: Fix common/ includes.
8404         * dwarf2loc.c: Fix common/ includes.
8405         * dwarf2-frame.c: Fix common/ includes.
8406         * dwarf-index-cache.c: Fix common/ includes.
8407         * dtrace-probe.c: Fix common/ includes.
8408         * disasm-selftests.c: Fix common/ includes.
8409         * defs.h: Fix common/ includes.
8410         * csky-tdep.c: Fix common/ includes.
8411         * cp-valprint.c: Fix common/ includes.
8412         * cp-support.h: Fix common/ includes.
8413         * cp-support.c: Fix common/ includes.
8414         * corelow.c: Fix common/ includes.
8415         * completer.h: Fix common/ includes.
8416         * completer.c: Fix common/ includes.
8417         * compile/compile.c: Fix common/ includes.
8418         * compile/compile-loc2c.c: Fix common/ includes.
8419         * compile/compile-cplus-types.c: Fix common/ includes.
8420         * compile/compile-cplus-symbols.c: Fix common/ includes.
8421         * command.h: Fix common/ includes.
8422         * cli/cli-dump.c: Fix common/ includes.
8423         * cli/cli-cmds.c: Fix common/ includes.
8424         * charset.c: Fix common/ includes.
8425         * build-id.c: Fix common/ includes.
8426         * btrace.h: Fix common/ includes.
8427         * btrace.c: Fix common/ includes.
8428         * breakpoint.h: Fix common/ includes.
8429         * breakpoint.c: Fix common/ includes.
8430         * ax.h:
8431         (enum agent_op): Fix common/ includes.
8432         * ax-general.c (struct aop_map): Fix common/ includes.
8433         * ax-gdb.c: Fix common/ includes.
8434         * auxv.c: Fix common/ includes.
8435         * auto-load.c: Fix common/ includes.
8436         * arm-tdep.c: Fix common/ includes.
8437         * arch/riscv.c: Fix common/ includes.
8438         * arch/ppc-linux-common.c: Fix common/ includes.
8439         * arch/i386.c: Fix common/ includes.
8440         * arch/arm.c: Fix common/ includes.
8441         * arch/arm-linux.c: Fix common/ includes.
8442         * arch/arm-get-next-pcs.c: Fix common/ includes.
8443         * arch/amd64.c: Fix common/ includes.
8444         * arch/aarch64.c: Fix common/ includes.
8445         * arch/aarch64-insn.c: Fix common/ includes.
8446         * arch-utils.c: Fix common/ includes.
8447         * amd64-windows-tdep.c: Fix common/ includes.
8448         * amd64-tdep.c: Fix common/ includes.
8449         * amd64-sol2-tdep.c: Fix common/ includes.
8450         * amd64-obsd-tdep.c: Fix common/ includes.
8451         * amd64-nbsd-tdep.c: Fix common/ includes.
8452         * amd64-linux-tdep.c: Fix common/ includes.
8453         * amd64-linux-nat.c: Fix common/ includes.
8454         * amd64-fbsd-tdep.c: Fix common/ includes.
8455         * amd64-fbsd-nat.c: Fix common/ includes.
8456         * amd64-dicos-tdep.c: Fix common/ includes.
8457         * amd64-darwin-tdep.c: Fix common/ includes.
8458         * agent.c: Fix common/ includes.
8459         * ada-lang.h: Fix common/ includes.
8460         * ada-lang.c: Fix common/ includes.
8461         * aarch64-tdep.c: Fix common/ includes.
8462
8463 2019-01-25  Tom Tromey  <tom@tromey.com>
8464
8465         * common/create-version.sh: Use common/version.h.
8466
8467 2019-01-24  Pedro Alves  <palves@redhat.com>
8468
8469         * infrun.c (signal_stop, signal_print, signal_program)
8470         (signal_catch, signal_pass): Now arrays instead of pointers.
8471         (update_signals_program_target, do_target_resume)
8472         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
8473         * linux-nat.c (linux_nat_target::pass_signals)
8474         (linux_nat_target::create_inferior, linux_nat_target::attach):
8475         Adjust.
8476         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
8477         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
8478         * procfs.c (procfs_target::pass_signals): Adjust.
8479         * record-full.c (record_full_target::resume): Adjust.
8480         * remote.c (remote_target::pass_signals)
8481         (remote_target::program_signals): Adjust.
8482         * target-debug.h (target_debug_print_signals): Now takes a
8483         gdb::array_view as parameter.  Adjust.
8484         * target.h (target_ops) <pass_signals, program_signals>: Replace
8485         pointer and length parameters with gdb::array_view.
8486         (target_pass_signals, target_program_signals): Likewise.
8487         * target-delegates.c: Regenerate.
8488
8489 2019-01-24  Pedro Alves  <palves@redhat.com>
8490
8491         * common/forward-scope-exit.h
8492         (forward_scope_exit::forward_scope_exit): Pass arguments to
8493         m_bind_function directly, instead of creating a std::bind and
8494         copying that.
8495
8496 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
8497
8498         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8499         for static members.
8500         (pass_in_v_vfp_candidate): Likewise.
8501
8502 2019-01-23  Tom Tromey  <tom@tromey.com>
8503             Pedro Alves  <palves@redhat.com>
8504
8505         * regcache.c (class regcache_invalidator): Remove.
8506         (regcache::raw_write): Use make_scope_exit.
8507
8508 2019-01-23  Tom Tromey  <tom@tromey.com>
8509
8510         * ui-out.h (class ui_out_emit_type): Update comment.
8511
8512 2019-01-23  Tom Tromey  <tom@tromey.com>
8513
8514         * infrun.c (fetch_inferior_event): Update comment.
8515
8516 2019-01-23  Tom Tromey  <tom@tromey.com>
8517             Pedro Alves  <palves@redhat.com>
8518
8519         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
8520         parameter.
8521         (fetch_inferior_event): Use SCOPE_EXIT.
8522
8523
8524 2019-01-23  Tom Tromey  <tom@tromey.com>
8525             Pedro Alves  <palves@redhat.com>
8526
8527         * infrun.c (disable_thread_events): Delete.
8528         (stop_all_threads): Use SCOPE_EXIT.
8529
8530 2019-01-23  Tom Tromey  <tom@tromey.com>
8531             Pedro Alves  <palves@redhat.com>
8532
8533         * symfile.c: Include forward-scope-exit.h.
8534         (clear_symtab_users_cleanup): Replace forward declaration with
8535         a FORWARD_SCOPE_EXIT.
8536         (syms_from_objfile_1): Use the forward_scope_exit and
8537         gdb::optional instead of cleanup_function.
8538         (reread_symbols): Use the forward_scope_exit instead of
8539         cleanup_function.
8540         (clear_symtab_users_cleanup): Remove function.
8541
8542 2019-01-23  Tom Tromey  <tom@tromey.com>
8543             Pedro Alves  <palves@redhat.com>
8544
8545         * linux-nat.c: Include scope-exit.h.
8546         (cleanup_target_stop): Remove.
8547         (linux_nat_target::static_tracepoint_markers_by_strid): Use
8548         SCOPE_EXIT.
8549
8550 2019-01-23  Tom Tromey  <tom@tromey.com>
8551             Pedro Alves  <palves@redhat.com>
8552
8553         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
8554         (call_function_by_hand_dummy): Use SCOPE_EXIT.
8555
8556 2019-01-23  Tom Tromey  <tom@tromey.com>
8557             Andrew Burgess  <andrew.burgess@embecosm.com>
8558             Pedro Alves  <palves@redhat.com>
8559
8560         * infrun.c (fetch_inferior_event): Use scope_exit.
8561         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
8562         * top.c (execute_command): Use scope_exit.
8563         * breakpoint.c (bpstat_do_actions): Use scope_exit.
8564         * utils.c (do_bpstat_clear_actions_cleanup)
8565         (make_bpstat_clear_actions_cleanup): Remove.
8566
8567 2019-01-23  Tom Tromey  <tom@tromey.com>
8568             Pedro Alves  <palves@redhat.com>
8569
8570         * infrun.c: Include "common/scope-exit.h"
8571         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
8572         (wait_for_inferior): Use SCOPE_EXIT.
8573         (fetch_inferior_event): Use scope_exit.
8574
8575 2019-01-23  Tom Tromey  <tom@tromey.com>
8576             Pedro Alves  <palves@redhat.com>
8577
8578         * breakpoint.c (create_breakpoint): Remove cleanup.
8579
8580 2019-01-23  Tom Tromey  <tom@tromey.com>
8581             Andrew Burgess  <andrew.burgess@embecosm.com>
8582             Pedro Alves  <palves@redhat.com>
8583
8584 2019-01-23  Pedro Alves  <palves@redhat.com>
8585
8586         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
8587
8588 2019-01-23  Pedro Alves  <palves@redhat.com>
8589             Andrew Burgess  <andrew.burgess@embecosm.com>
8590
8591         * gdbthread.h: Include "common/forward-scope-exit.h".
8592         (scoped_finish_thread_state): Redefine custom class in terms of
8593         forward_scope_exit.
8594
8595 2019-01-23  Pedro Alves  <palves@redhat.com>
8596             Andrew Burgess  <andrew.burgess@embecosm.com>
8597
8598         * common/forward-scope-exit.h: New file.
8599
8600 2019-01-23  Pedro Alves  <palves@redhat.com>
8601             Andrew Burgess  <andrew.burgess@embecosm.com>
8602             Tom Tromey  <tom@tromey.com>
8603
8604         * common/scope-exit.h: New file.
8605
8606 2019-01-23  Pedro Alves  <palves@redhat.com>
8607
8608         * common/preprocessor.h (ESC): Rename to ...
8609         (ESC_PARENS): ... this.
8610         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
8611         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
8612
8613 2019-01-23  Tom Tromey  <tom@tromey.com>
8614
8615         * language.h (class scoped_switch_to_sym_language_if_auto):
8616         Initialize m_lang in both cases.
8617
8618 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
8619
8620         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
8621         with XCNEW.
8622
8623 2019-01-22  Tom Tromey  <tom@tromey.com>
8624
8625         * corelow.c: Do not include sys/file.h.
8626
8627 2019-01-22  Tom Tromey  <tom@tromey.com>
8628
8629         * tui/tui-wingeneral.h: Include gdb_curses.h.
8630
8631 2019-01-22  Tom Tromey  <tom@tromey.com>
8632
8633         * source-cache.h (class source_cache) <get_source_lines,
8634         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
8635
8636 2019-01-22  Tom Tromey  <tom@tromey.com>
8637
8638         * remote-fileio.h (struct remote_target): Declare.
8639
8640 2019-01-22  Tom Tromey  <tom@tromey.com>
8641
8642         * python/py-arch.c: Do not include py-ref.h.
8643         * python/py-bpevent.c: Do not include py-ref.h.
8644         * python/py-cmd.c: Do not include py-ref.h.
8645         * python/py-continueevent.c: Do not include py-ref.h.
8646         * python/py-event.h: Do not include py-ref.h.
8647         * python/py-evtregistry.c: Do not include py-ref.h.
8648         * python/py-finishbreakpoint.c: Do not include py-ref.h.
8649         * python/py-frame.c: Do not include py-ref.h.
8650         * python/py-framefilter.c: Do not include py-ref.h.
8651         * python/py-function.c: Do not include py-ref.h.
8652         * python/py-infevents.c: Do not include py-ref.h.
8653         * python/py-linetable.c: Do not include py-ref.h.
8654         * python/py-objfile.c: Do not include py-ref.h.
8655         * python/py-param.c: Do not include py-ref.h.
8656         * python/py-prettyprint.c: Do not include py-ref.h.
8657         * python/py-progspace.c: Do not include py-ref.h.
8658         * python/py-symbol.c: Do not include py-ref.h.
8659         * python/py-symtab.c: Do not include py-ref.h.
8660         * python/py-type.c: Do not include py-ref.h.
8661         * python/py-unwind.c: Do not include py-ref.h.
8662         * python/py-utils.c: Do not include py-ref.h.
8663         * python/py-value.c: Do not include py-ref.h.
8664         * python/py-varobj.c: Do not include py-ref.h.
8665         * python/py-xmethods.c: Do not include py-ref.h.
8666         * python/python.c: Do not include py-ref.h.
8667         * varobj.c: Do not include py-ref.h.
8668
8669 2019-01-22  Tom Tromey  <tom@tromey.com>
8670
8671         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
8672         keyword for bcache.
8673
8674 2019-01-22  Tom Tromey  <tom@tromey.com>
8675
8676         * compile/compile-cplus-types.c: Remove a comment by #include.
8677
8678 2019-01-22  Tom Tromey  <tom@tromey.com>
8679
8680         * compile/gcc-c-plugin.h: Include compile-internal.h.
8681
8682 2019-01-22  Tom Tromey  <tom@tromey.com>
8683
8684         * stabsread.c (EXTERN): Do not define.
8685         (symnum, next_symbol_text_func, processing_gcc_compilation)
8686         (within_function, global_sym_chain, global_stabs)
8687         (previous_stab_code, this_object_header_files)
8688         (n_this_object_header_files)
8689         (n_allocated_this_object_header_files): Define.
8690         * stabsread.h (EXTERN): Never define.  Use "extern".
8691
8692 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8693
8694         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
8695         history_value.
8696
8697 2019-01-21  Tom Tromey  <tom@tromey.com>
8698
8699         * ui-out.c: Fix includes.
8700         * tui/tui-source.c: Fix includes.
8701         * target.c: Fix includes.
8702         * remote.c: Fix includes.
8703         * regcache.c: Fix includes.
8704         * python/py-block.c: Fix includes.
8705         * printcmd.c: Fix includes.
8706         * or1k-tdep.c: Fix includes.
8707         * mi/mi-main.c: Fix includes.
8708         * m32r-tdep.c: Fix includes.
8709         * csky-tdep.c: Fix includes.
8710         * compile/compile-cplus-types.c: Fix includes.
8711         * cli/cli-interp.c: Fix includes.
8712
8713 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
8714
8715         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
8716         for padding.
8717
8718 2019-01-16  Tom Tromey  <tom@tromey.com>
8719
8720         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
8721         earlier.
8722         (struct objfile) <msymbols_range>: Move from top level.
8723         <msymbols>: New method.
8724         (class objfile_msymbols): Remove.
8725         * symtab.c (default_collect_symbol_completion_matches_break_on):
8726         Update.
8727         * symmisc.c (dump_msymbols): Update.
8728         * stabsread.c (scan_file_globals): Update.
8729         * objc-lang.c (info_selectors_command, info_classes_command)
8730         (find_methods): Update.
8731         * minsyms.c (find_solib_trampoline_target): Update.
8732         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
8733         * coffread.c (coff_symfile_read): Update.
8734         * ada-lang.c (ada_lookup_simple_minsym)
8735         (ada_collect_symbol_completion_matches): Update.
8736
8737 2019-01-16  Tom Tromey  <tom@tromey.com>
8738
8739         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
8740         type.  Remove no-argument constructor.
8741         <iterator::operator++>: Simplify.
8742         <begin>: Update.
8743         <end>: Use minimal_symbol_count.
8744
8745 2019-01-16  Tom Tromey  <tom@tromey.com>
8746
8747         * objfiles.h (struct objfile) <psymtabs>: New method.
8748         (class objfile_psymtabs): Remove.
8749         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
8750         typedef.
8751         <range>: New method.
8752         (require_partial_symbols): Change return type.
8753         * psymtab.c (require_partial_symbols)
8754         (psym_expand_symtabs_matching): Update.
8755         * mdebugread.c (parse_partial_symbols): Update.
8756         * dbxread.c (dbx_end_psymtab): Update.
8757
8758 2019-01-15  Tom Tromey  <tom@tromey.com>
8759
8760         * symtab.c (lookup_objfile_from_block)
8761         (lookup_symbol_in_objfile_symtabs)
8762         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
8763         (find_line_symtab, info_sources_command)
8764         (default_collect_symbol_completion_matches_break_on)
8765         (make_source_files_completion_list): Update.
8766         * symmisc.c (print_objfile_statistics, dump_objfile)
8767         (maintenance_print_symbols, maintenance_info_symtabs)
8768         (maintenance_check_symtabs, maintenance_info_line_tables):
8769         Update.
8770         * source.c (select_source_symtab)
8771         (forget_cached_source_info_for_objfile): Update.
8772         * objfiles.h (class objfile_compunits): Remove.
8773         (struct objfile) <compunits_range>: New typedef.
8774         (compunits): New method.
8775         * objfiles.c (objfile_relocate1): Update.
8776         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8777         * maint.c (count_symtabs_and_blocks): Update.
8778         * linespec.c (iterate_over_all_matching_symtabs): Update.
8779         * cp-support.c (add_symbol_overload_list_qualified): Update.
8780         * coffread.c (coff_symtab_read): Update.
8781         * ada-lang.c (add_nonlocal_symbols)
8782         (ada_collect_symbol_completion_matches)
8783         (ada_add_global_exceptions): Update.
8784
8785 2019-01-15  Tom Tromey  <tom@tromey.com>
8786
8787         * progspace.h (program_space) <objfiles_safe_range>: New
8788         typedef.
8789         <objfiles_safe>: New method.
8790         * objfiles.h (class all_objfiles_safe): Remove.
8791         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
8792         * jit.c (jit_inferior_exit_hook): Update.
8793
8794 2019-01-17  Tom Tromey  <tom@tromey.com>
8795
8796         * progspace.h (program_space) <objfiles_range>: New typedef.
8797         <objfiles>: New method.
8798         <objfiles_head>: Rename from objfiles.
8799         (object_files): Update.
8800         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
8801         * guile/scm-pretty-print.c
8802         (ppscm_find_pretty_printer_from_objfiles): Update.
8803         * guile/scm-objfile.c (gdbscm_objfiles): Update.
8804         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
8805         Update.
8806         * python/py-progspace.c (pspy_get_objfiles): Update.
8807         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8808         Update.
8809         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8810         (objfpy_lookup_objfile_by_build_id): Update.
8811         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8812         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8813         Update.
8814         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8815         (expand_symtab_containing_pc, lookup_objfile_from_block)
8816         (lookup_static_symbol, basic_lookup_transparent_type)
8817         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8818         (find_line_symtab, info_sources_command)
8819         (default_collect_symbol_completion_matches_break_on)
8820         (make_source_files_completion_list, find_main_name): Update.
8821         * symmisc.c (print_symbol_bcache_statistics)
8822         (print_objfile_statistics, maintenance_print_symbols)
8823         (maintenance_print_msymbols, maintenance_print_objfiles)
8824         (maintenance_info_symtabs, maintenance_check_symtabs)
8825         (maintenance_expand_symtabs, maintenance_info_line_tables):
8826         Update.
8827         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8828         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8829         (map_overlay_command, unmap_overlay_command)
8830         (simple_overlay_update, expand_symtabs_matching)
8831         (map_symbol_filenames): Update.
8832         * symfile-debug.c (set_debug_symfile): Update.
8833         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8834         Update.
8835         * source.c (select_source_symtab, forget_cached_source_info):
8836         Update.
8837         * solib.c (solib_read_symbols): Update.
8838         * solib-spu.c (append_ocl_sos): Update.
8839         * psymtab.c (maintenance_print_psymbols)
8840         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8841         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8842         * printcmd.c (info_symbol_command): Update.
8843         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8844         Update.
8845         * objfiles.h (class all_objfiles): Remove.
8846         * objfiles.c (have_partial_symbols, have_full_symbols)
8847         (have_minimal_symbols, qsort_cmp, update_section_map)
8848         (shared_objfile_contains_address_p)
8849         (default_iterate_over_objfiles_in_search_order): Update.
8850         * objc-lang.c (info_selectors_command, info_classes_command)
8851         (find_methods): Update.
8852         * minsyms.c (find_solib_trampoline_target): Update.
8853         * maint.c (maintenance_info_sections)
8854         (maintenance_translate_address, count_symtabs_and_blocks):
8855         Update.
8856         * main.c (captured_main_1): Update.
8857         * linux-thread-db.c (try_thread_db_load_from_pdir)
8858         (has_libpthread): Update.
8859         * linespec.c (iterate_over_all_matching_symtabs)
8860         (search_minsyms_for_name): Update.
8861         * jit.c (jit_find_objf_with_entry_addr): Update.
8862         * hppa-tdep.c (find_unwind_entry)
8863         (hppa_lookup_stub_minimal_symbol): Update.
8864         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8865         Update.
8866         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8867         (elf_gnu_ifunc_resolve_by_got): Update.
8868         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8869         * dwarf-index-write.c (save_gdb_index_command): Update.
8870         * cp-support.c (add_symbol_overload_list_qualified): Update.
8871         * breakpoint.c (create_overlay_event_breakpoint)
8872         (create_longjmp_master_breakpoint)
8873         (create_std_terminate_master_breakpoint)
8874         (create_exception_master_breakpoint): Update.
8875         * blockframe.c (find_pc_partial_function): Update.
8876         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8877         (ada_collect_symbol_completion_matches)
8878         (ada_add_global_exceptions): Update.
8879
8880 2019-01-17  Tom Tromey  <tom@tromey.com>
8881
8882         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8883         declare VEC.
8884         (solib_target_parse_libraries): Change return type.
8885         (library_list_start_segment, library_list_start_section)
8886         (library_list_end_library, library_list_start_library); Update.
8887         (solib_target_free_library_list): Remove.
8888         (solib_target_parse_libraries): Remove cleanup.  Change return
8889         type.
8890         (solib_target_current_sos): Update.
8891
8892 2019-01-17  Tom Tromey  <tromey@bapiya>
8893
8894         * valprint.c: Replace "the the" with "the".
8895         * symtab.c: Replace "the the" with "the".
8896         * solib.c: Replace "the the" with "the".
8897         * solib-dsbt.c: Replace "the the" with "the".
8898         * linespec.c: Replace "the the" with "the".
8899         * dwarf2loc.h: Replace "the the" with "the".
8900         * amd64-windows-tdep.c: Replace "the the" with "the".
8901         * aarch64-tdep.c: Replace "the the" with "the".
8902
8903 2019-01-16  Keith Seitz  <keiths@redhat.com>
8904
8905         PR gdb/23773
8906         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8907         <builder>: Rename to ..
8908         <m_builder>: ... this and make private.
8909         (dwarf2_cu::get_builder): New method.  Change all users of
8910         `builder' to use this method.
8911         (dwarf2_start_symtab): Move to ...
8912         (dwarf2_cu::start_symtab): ... here.  Update all callers
8913         (setup_type_unit_groups): Move to ...
8914         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8915         callers.
8916         (dwarf2_cu::reset_builder): New method.
8917         (process_full_compunit, process_full_type_unit): Use
8918         dwarf2_cu::reset_builder.
8919         (follow_die_offset): Record the ancestor CU if it is different
8920         from the followed DIE's CU.
8921         (follow_die_sig_1): Likewise.
8922
8923 2019-01-15  Tom Tromey  <tom@tromey.com>
8924
8925         * remote.c (class remote_state) <buf>: Now a char_vector.
8926         <buf_size>: Remove.
8927         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8928         parameter.
8929         (remote_target::getpkt_or_notif_sane_1)
8930         (remote_target::getpkt_sane)
8931         (remote_target::getpkt_or_notif_sane): Likewise.
8932         (class remote_target) <putpkt>: New overload.
8933         (remote_target::read_frame): Change type of "buf_p".  Remove
8934         sizeof_p parameter.
8935         (packet_ok): New overload.
8936         (packet_check_result): New overload.
8937         Update all uses.
8938
8939 2019-01-14  Tom Tromey  <tom@tromey.com>
8940
8941         * remote-notif.c (handle_notification, remote_notif_ack)
8942         (remote_notif_parse): Make "buf" const.
8943         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8944         const.
8945         (remote_notif_parse, remote_notif_ack, handle_notification):
8946         Likewise.
8947         * remote.c (remote_notif_stop_parse): Make "buf" const.
8948         (remote_target::remote_parse_stop_reply): Make "buf" const.
8949         (remote_notif_stop_ack): Make "buf" const.
8950
8951 2019-01-14  Tom Tromey  <tom@tromey.com>
8952
8953         * remote.c (remote_console_output): Make parameter const.
8954
8955 2019-01-14  Tom Tromey  <tom@tromey.com>
8956
8957         * target-debug.h (target_debug_print_signals): Constify.
8958         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8959         * procfs.c (procfs_target::pass_signals): Update.
8960         * linux-nat.c (linux_nat_target::pass_signals): Update.
8961         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8962         * target-delegates.c: Rebuild.
8963         * remote.c (remote_target::program_signals): Update.
8964         (remote_target::pass_signals): Update.
8965         * target.c (target_pass_signals): Constify argument.
8966         (target_program_signals): Likewise.
8967         * target.h (struct target_ops) <pass_signals, program_signals>:
8968         Constify argument.
8969         (target_pass_signals, target_program_signals): Constify argument.
8970
8971 2019-01-14  Tom Tromey  <tom@tromey.com>
8972
8973         PR tui/28819:
8974         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8975
8976 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8977
8978         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8979         field.
8980         * rs6000-tdep.c: Include reggroups.h.
8981         (IS_V_ALIAS_PSEUDOREG): Define.
8982         (rs6000_register_name): Return names for the "vX" aliases.
8983         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8984         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8985         aliases.  Call default_register_reggroup_p for all other
8986         pseudo-registers.
8987         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8988         New functions.
8989         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8990         Handle "vX" aliases.
8991         (v_alias_pseudo_register_collect): New function.
8992         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8993         (rs6000_gdbarch_init): Initialize "vX" aliases as
8994         pseudo-registers.  Restore registration of
8995         rs6000_pseudo_register_reggroup_p with
8996         set_tdesc_pseudo_register_reggroup_p.
8997
8998 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8999
9000         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
9001         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
9002         set_gdbarch_num_pseudo_regs.
9003
9004 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9005
9006         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
9007         Remove arg prefixname, add do_set and do_show.
9008         Add member functions set_list and show_list.
9009         * cli/cli-style.c (class cli_style_option): Update accordingly.
9010         (style_set_list): Move to file scope.
9011         (style_show_list): Likewise.
9012         (set_style): Call help_list.
9013         (show_style): Call cmd_show_list.
9014         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
9015         Update to use the new macro.
9016
9017 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
9018
9019         * ada-lang.c (_initialize_ada_language): Expand the help text
9020         for the "catch exception" command.
9021
9022 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9023
9024         * symtab.c (matching_obj_sections): Initialize obj,
9025         declare it closer to its usage.
9026
9027 2019-01-10  Tom Tromey  <tom@tromey.com>
9028
9029         * thread-iter.h (inf_threads_iterator): Use next_iterator.
9030         (basic_inf_threads_range): Remove.
9031         (inf_threads_range, inf_non_exited_threads_range)
9032         (safe_inf_threads_range): Use next_adapter.
9033
9034 2019-01-10  Keith Seitz  <keiths@redhat.com>
9035
9036         PR gdb/23712
9037         PR symtab/23010
9038         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
9039         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
9040
9041 2019-01-10  Keith Seitz  <keiths@redhat.com>
9042
9043         PR gdb/23712
9044         PR symtab/23010
9045         * dictionary.c (pending_to_vector): Remove.
9046         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9047         Remove _1 suffix, replacing functions of the same name.  Update
9048         all callers.
9049         (dict_create_hashed, dict_create_hashed_expandable)
9050         (dict_create_linear, dict_create_linear_expandable, dict_free)
9051         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
9052         Make functions static.
9053
9054 2019-01-10  Keith Seitz  <keiths@redhat.com>
9055
9056         PR gdb/23712
9057         PR symtab/23010
9058         * dictionary.h (struct dictionary): Replace declaration with
9059         multidictionary.
9060         (dict_create_hashed, dict_create_hashed_expandable)
9061         (dict_create_linear, dict_create_linear_expandable)
9062         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
9063         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
9064         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
9065         taking multidictionary argument.
9066         [ALL_DICT_SYMBOLS]: Update for multidictionary.
9067         * block.h (struct block) <dict>: Change to multidictionary
9068         and rename `multidict'.
9069         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
9070         symmisc.c: Update all dictionary references to multidictionary.
9071
9072 2019-01-10  Keith Seitz  <keiths@redhat.com>
9073
9074         PR gdb/23712
9075         PR symtab/23010
9076         * dictionary.c: Include unordered_map.
9077         (pending_to_vector): New function.
9078         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
9079         Rewrite the non-"_1" functions to take vector instead
9080         of linked list.
9081         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
9082         "new" _1 versions of the same name.
9083         (multidictionary): Define.
9084         (std::hash<enum language): New definition.
9085         (collate_pending_symbols_by_language, mdict_create_hashed)
9086         (mdict_create_hashed_expandable, mdict_create_linear)
9087         (mdict_create_linear_expandable, mdict_free)
9088         (find_language_dictionary, create_new_language_dictionary)
9089         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
9090         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
9091         (mdict_size, mdict_empty): New functions.
9092         * dictionary.h (mdict_iterator): Define.
9093
9094 2019-01-10  Pedro Alves  <palves@redhat.com>
9095
9096         * breakpoint.c (read_uploaded_action)
9097         (create_tracepoint_from_upload): Adjust to use
9098         gdb::unique_xmalloc_ptr.
9099         * ctf.c (ctf_write_uploaded_tp):
9100         (SET_ARRAY_FIELD): Use emplace_back.
9101         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
9102         * tracefile-tfile.c (tfile_write_uploaded_tp):
9103         * tracepoint.c (parse_tracepoint_definition): Adjust to use
9104         gdb::unique_xmalloc_ptr.
9105         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
9106         at_string, cond_string, cmd_strings>: Replace char pointers
9107         with gdb::unique_xmalloc_ptr.
9108
9109 2019-01-10  Pedro Alves  <palves@redhat.com>
9110
9111         * solib-target.c (library_list_start_library): Don't xstrdup name.
9112
9113 2019-01-10  Pedro Alves  <palves@redhat.com>
9114
9115         * mdebugread.c (parse_partial_symbols): Use
9116         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
9117
9118 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9119
9120         * linux-fork.c (scoped_switch_fork_info)
9121         <~scoped_switch_fork_info>: Fix incorrect variable name.
9122
9123 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9124
9125         * linux-fork.c (scoped_switch_fork_info)
9126         <scoped_switch_fork_info>: Make explicit.
9127         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
9128
9129 2019-01-10  Tom Tromey  <tom@tromey.com>
9130
9131         * objfiles.h (objfile::reset_psymtabs): Update.
9132         * objfiles.c (objfile::objfile): Update.
9133         * psymtab.h (psymtab_storage::obstack): Update.
9134         (psymtab_storage::m_obstack): Use gdb::optional.
9135         (class psymtab_storage): Update comment.  Remove objfile
9136         parameter.
9137         * psymtab.c (psymtab_storage::psymtab_storage): Update.
9138
9139 2019-01-10  Tom Tromey  <tom@tromey.com>
9140
9141         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
9142         <free_psymtabs>: Now private.
9143         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
9144         (allocate_psymtab): Use new method.
9145
9146 2019-01-10  Tom Tromey  <tom@tromey.com>
9147
9148         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
9149         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
9150         * mdebugread.c (parse_partial_symbols): Use
9151         allocate_dependencies.
9152         * dwarf2read.c (dwarf2_create_include_psymtab): Use
9153         allocate_dependencies.
9154         (process_psymtab_comp_unit_reader)
9155         (build_type_psymtab_dependencies): Likewise.
9156         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
9157
9158 2019-01-10  Tom Tromey  <tom@tromey.com>
9159
9160         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
9161         PSYMBOL_SET_LANGUAGE.
9162         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
9163
9164 2019-01-10  Tom Tromey  <tom@tromey.com>
9165
9166         * psymtab.h (psymtab_storage::obstack): New method.
9167         <m_obstack>: Rename from obstack; now private.
9168         * psymtab.c (psymtab_storage): Update.
9169         * dwarf2read.c (create_addrmap_from_index)
9170         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
9171         Update.
9172
9173 2019-01-10  Tom Tromey  <tom@tromey.com>
9174
9175         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
9176         * objfiles.h (objfile::reset_psymtabs): New method.
9177
9178 2019-01-10  Tom Tromey  <tom@tromey.com>
9179
9180         * symmisc.c (print_symbol_bcache_statistics): Update.
9181         (print_objfile_statistics): Update.
9182         * symfile.c (reread_symbols): Update.
9183         * psymtab.h (class psymtab_storage): New.
9184         * psymtab.c (psymtab_storage): New constructor.
9185         (~psymtab_storage): New destructor.
9186         (require_partial_symbols): Update.
9187         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
9188         (find_pc_sect_psymtab, find_pc_sect_psymbol)
9189         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
9190         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
9191         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
9192         (start_psymtab_common, end_psymtab_common)
9193         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
9194         (allocate_psymtab): Update.
9195         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
9196         Update.
9197         (dump_psymtab_addrmap, maintenance_print_psymbols)
9198         (maintenance_check_psymtabs): Update.
9199         (class objfile_psymtabs): Move to objfiles.h.
9200         * psympriv.h (discard_psymtab): Now inline.
9201         (psymtab_discarder::psymtab_discarder): Update.
9202         (psymtab_discarder::~psymtab_discarder): Update.
9203         (ALL_OBJFILE_PSYMTABS): Rewrite.
9204         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
9205         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
9206         Remove fields.
9207         <partial_symtabs>: New field.
9208         (class objfile_psymtabs): Move from psymtab.h.  Update.
9209         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
9210         psymbol_cache.
9211         (objfile::~objfile): Don't destroy psymbol_cache.
9212         * mdebugread.c (parse_partial_symbols): Update.
9213         * dwarf2read.c (create_addrmap_from_index)
9214         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
9215         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
9216         (add_partial_subprogram, dwarf2_ranges_read): Update.
9217         * dwarf-index-write.c (write_address_map)
9218         (write_one_signatured_type, recursively_write_psymbols)
9219         (class debug_names, class debug_names, write_psymtabs_to_index):
9220         Update.
9221
9222 2019-01-10  Tom Tromey  <tom@tromey.com>
9223
9224         * symtab.h (SYMBOL_SET_NAMES): Update.
9225         (symbol_set_names): Update.
9226         (MSYMBOL_SET_NAMES): Update.
9227         * symtab.c (symbol_set_names): Change argument to be an
9228         objfile_per_bfd_storage.
9229         * psymtab.c (add_psymbol_to_bcache): Update.
9230         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
9231
9232 2019-01-10  Tom Tromey  <tom@tromey.com>
9233
9234         * symtab.c (create_demangled_names_hash): Change argument to be an
9235         objfile_per_bfd_storage.
9236         (symbol_set_names): Update.
9237
9238 2019-01-10  Tom Tromey  <tom@tromey.com>
9239
9240         * xcoffread.c (xcoff_initial_scan): Unconditionally call
9241         init_psymbol_list.
9242         * psymtab.c (init_psymbol_list): Do nothing if already called.
9243         * psympriv.h (init_psymbol_list): Add comment.
9244         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
9245         init_psymbol_list.
9246         * dbxread.c (dbx_symfile_read): Unconditionally call
9247         init_psymbol_list.
9248
9249 2019-01-10  Tom Tromey  <tom@tromey.com>
9250
9251         * xcoffread.c (scan_xcoff_symtab): Update.
9252         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
9253         "where".
9254         * mdebugread.c (parse_partial_symbols)
9255         (handle_psymbol_enumerators): Update.
9256         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
9257         * dbxread.c (read_dbx_symtab): Update.
9258         * psympriv.h (psymbol_placement): New enum.
9259         (add_psymbol_to_list): Update.
9260
9261 2019-01-10  Tom Tromey  <tom@tromey.com>
9262
9263         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
9264         static_psymbols parameters.
9265         (scan_xcoff_symtab): Update.
9266         * psymtab.c (start_psymtab_common): Remove global_psymbols and
9267         static_psymbols parameters.
9268         * psympriv.h (start_psymtab_common): Update.
9269         * mdebugread.c (parse_partial_symbols): Update.
9270         * dwarf2read.c (create_partial_symtab): Update.
9271         * dbxread.c (read_dbx_symtab): Update.
9272         (start_psymtab): Remove global_psymbols and static_psymbols
9273         parameters.
9274
9275 2019-01-10  Tom Tromey  <tom@tromey.com>
9276
9277         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
9278         * psymtab.c (allocate_psymtab): Add comment.
9279         * psympriv.h (allocate_psymtab): Add comment.
9280         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
9281         initializations.
9282         * dbxread.c (dbx_end_psymtab): Remove some initializations.
9283
9284 2019-01-10  Tom Tromey  <tom@tromey.com>
9285
9286         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9287         Don't declare.
9288         * mipsread.c: Include mdebugread.h.
9289         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
9290         Declare.
9291         * elfread.c: Include mdebugread.h.
9292
9293 2019-01-09  Tom Tromey  <tom@tromey.com>
9294
9295         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
9296         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
9297         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
9298         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
9299         (psym_lookup_symbol, psym_find_last_source_symtab)
9300         (psym_forget_cached_source_info, psym_print_stats)
9301         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
9302         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
9303         (psym_map_matching_symbols, psym_expand_symtabs_matching)
9304         (psym_find_compunit_symtab_by_address)
9305         (maintenance_print_psymbols, maintenance_info_psymtabs)
9306         (maintenance_check_psymtabs): Use ranged for.
9307         * psymtab.h (class objfile_psymtabs): New.
9308         (require_partial_symbols): Return objfile_psymtabs.
9309         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
9310
9311 2019-01-09  Tom Tromey  <tom@tromey.com>
9312
9313         * symfile.c (overlay_invalidate_all, find_pc_overlay)
9314         (find_pc_mapped_section, list_overlays_command)
9315         (map_overlay_command, unmap_overlay_command)
9316         (simple_overlay_update): Use all_objfiles.
9317         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
9318         * printcmd.c (info_symbol_command): Use all_objfiles.
9319         * objfiles.h (ALL_OBJSECTIONS): Remove.
9320         * maint.c (maintenance_translate_address): Use all_objfiles.
9321         * gcore.c (gcore_create_callback): Use all_objfiles.
9322         (objfile_find_memory_regions): Likewise.
9323
9324 2019-01-09  Tom Tromey  <tom@tromey.com>
9325
9326         * symtab.c (find_line_symtab, info_sources_command)
9327         (make_source_files_completion_list): Use objfile_compunits.
9328         * source.c (select_source_symtab): Use objfile_compunits.
9329         * objfiles.h (struct objfile): Update comment.
9330         (ALL_OBJFILES): Remove.
9331         (ALL_FILETABS): Remove.
9332         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
9333         objfile_compunits.
9334
9335 2019-01-09  Tom Tromey  <tom@tromey.com>
9336
9337         * symmisc.c (print_objfile_statistics, dump_objfile)
9338         (maintenance_print_symbols): Use compunit_filetabs.
9339         * source.c (forget_cached_source_info_for_objfile): Use
9340         compunit_filetabs.
9341         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
9342         (ALL_FILETABS): Use compunit_filetabs.
9343         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
9344         * coffread.c (coff_symtab_read): Use compunit_filetabs.
9345
9346 2019-01-09  Tom Tromey  <tom@tromey.com>
9347
9348         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
9349         (compunit_filetabs): New.
9350         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
9351         compunit_filetabs.
9352         (info_sources_command, make_source_files_completion_list): Remove
9353         declaration.
9354         * symmisc.c (print_objfile_statistics, dump_objfile)
9355         (maintenance_print_symbols): Remove declaration.
9356         (maintenance_info_symtabs): Use compunit_filetabs.
9357         (maintenance_info_line_tables): Likewise.
9358         * source.c (select_source_symtab): Change local variable name.
9359         (forget_cached_source_info_for_objfile): Remove declaration.
9360         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
9361         * objfiles.c (objfile_relocate1): Remove declaration.
9362         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9363         declaration.
9364         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
9365         * coffread.c (coff_symtab_read): Remove declaration.
9366         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
9367         compunit_filetabs.
9368
9369 2019-01-09  Tom Tromey  <tom@tromey.com>
9370
9371         * symtab.c (lookup_objfile_from_block)
9372         (find_pc_sect_compunit_symtab, search_symbols)
9373         (default_collect_symbol_completion_matches_break_on): Use
9374         objfile_compunits.
9375         * objfiles.h (ALL_COMPUNITS): Remove.
9376         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
9377         * cp-support.c (add_symbol_overload_list_qualified): Use
9378         objfile_compunits.
9379         * ada-lang.c (ada_collect_symbol_completion_matches)
9380         (ada_add_global_exceptions): Use objfile_compunits.
9381
9382 2019-01-09  Tom Tromey  <tom@tromey.com>
9383
9384         * source.c (select_source_symtab)
9385         (forget_cached_source_info_for_objfile): Remove declaration.
9386         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
9387         declaration.
9388         * maint.c (count_symtabs_and_blocks): Remove declaration.
9389         * cp-support.c (add_symbol_overload_list_qualified): Remove
9390         declaration.
9391         * coffread.c (coff_symtab_read): Remove declaration.
9392         * symtab.c (lookup_symbol_in_objfile_symtabs)
9393         (basic_lookup_transparent_type_1): Use objfile_compunits.
9394         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
9395         (info_sources_command, search_symbols)
9396         (default_collect_symbol_completion_matches_break_on)
9397         (make_source_files_completion_list): Remove declaration.
9398         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
9399         (ada_collect_symbol_completion_matches)
9400         (ada_add_global_exceptions): Remove declaration.
9401         * linespec.c (iterate_over_all_matching_symtabs): Use
9402         objfile_compunits.
9403         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
9404         (class objfile_compunits): New.
9405         (ALL_COMPUNITS): Use objfile_compunits.
9406         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
9407         (maintenance_check_symtabs, maintenance_info_line_tables): Use
9408         objfile_compunits.
9409         * objfiles.c (objfile_relocate1): Use objfile_compunits.
9410
9411 2019-01-09  Tom Tromey  <tom@tromey.com>
9412
9413         * symtab.c (search_symbols)
9414         (default_collect_symbol_completion_matches_break_on): Use
9415         objfile_msymbols.
9416         * ada-lang.c (ada_lookup_simple_minsym)
9417         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
9418         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
9419         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
9420         objfile_msymbols.
9421         * coffread.c (coff_symfile_read): Use objfile_msymbols.
9422         * symmisc.c (dump_msymbols): Use objfile_msymbols.
9423         * objc-lang.c (find_methods): Use objfile_msymbols.
9424         (info_selectors_command, info_classes_command): Likewise.
9425         * stabsread.c (scan_file_globals): Use objfile_msymbols.
9426         * objfiles.h (class objfile_msymbols): New.
9427         (ALL_OBJFILE_MSYMBOLS): Remove.
9428         (ALL_MSYMBOLS): Remove.
9429
9430 2019-01-09  Tom Tromey  <tom@tromey.com>
9431
9432         * common/next-iterator.h (next_adapter): Add Iterator template
9433         parameter.
9434         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
9435         (class all_objfiles_safe): New.
9436         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
9437         * objfiles.c (put_objfile_before): Update comment.
9438         (add_separate_debug_objfile): Likewise.
9439         (free_all_objfiles): Use all_objfiles_safe.
9440         (objfile_purge_solibs): Likewise.
9441
9442 2019-01-09  Tom Tromey  <tom@tromey.com>
9443
9444         * symtab.c (iterate_over_symtabs, matching_obj_sections)
9445         (expand_symtab_containing_pc, lookup_static_symbol)
9446         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
9447         (find_symbol_at_address, find_line_symtab, find_main_name): Use
9448         all_objfiles.
9449         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
9450         * breakpoint.c (create_overlay_event_breakpoint)
9451         (create_longjmp_master_breakpoint)
9452         (create_std_terminate_master_breakpoint)
9453         (create_exception_master_breakpoint): Use all_objfiles.
9454         * linux-thread-db.c (try_thread_db_load_from_pdir)
9455         (has_libpthread): Use all_objfiles.
9456         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
9457         * linespec.c (iterate_over_all_matching_symtabs)
9458         (search_minsyms_for_name): Use all_objfiles.
9459         * maint.c (maintenance_info_sections): Use all_objfiles.
9460         * main.c (captured_main_1): Use all_objfiles.
9461         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
9462         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
9463         * guile/scm-pretty-print.c
9464         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
9465         * solib-spu.c (append_ocl_sos): Use all_objfiles.
9466         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
9467         (maintenance_print_msymbols): Use all_objfiles.
9468         * source.c (select_source_symtab): Use all_objfiles.
9469         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
9470         * symfile.c (remove_symbol_file_command)
9471         (expand_symtabs_matching, map_symbol_filenames): Use
9472         all_objfiles.
9473         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
9474         all_objfiles.
9475         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
9476         * objc-lang.c (find_methods): Use all_objfiles.
9477         * objfiles.c (have_partial_symbols, have_full_symbols)
9478         (have_minimal_symbols, qsort_cmp)
9479         (default_iterate_over_objfiles_in_search_order): Use
9480         all_objfiles.
9481         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
9482         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
9483         (maintenance_check_psymtabs): Use all_objfiles.
9484         (ALL_PSYMTABS): Remove.
9485         * compile/compile-object-run.c (do_module_cleanup): Use
9486         all_objfiles.
9487         * blockframe.c (find_pc_partial_function): Use all_objfiles.
9488         * cp-support.c (add_symbol_overload_list_qualified): Use
9489         all_objfiles.
9490         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
9491         Use all_objfiles.
9492         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
9493         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
9494         all_objfiles.
9495         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
9496         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
9497         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
9498         Uses all_objfiles.
9499         * solib.c (solib_read_symbols): Use all_objfiles
9500
9501 2019-01-09  Tom Tromey  <tom@tromey.com>
9502
9503         * probe.c (parse_probes_in_pspace): Use all_objfiles.
9504         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
9505         all_objfiles.
9506         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
9507         * symmisc.c (print_symbol_bcache_statistics)
9508         (print_objfile_statistics, maintenance_print_objfiles)
9509         (maintenance_info_symtabs, maintenance_check_symtabs)
9510         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
9511         all_objfiles.
9512         * source.c (forget_cached_source_info): Use all_objfiles.
9513         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
9514         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
9515         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
9516         * objfiles.c (update_section_map): Use all_objfiles.
9517         (shared_objfile_contains_address_p): Likewise.
9518         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
9519         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
9520
9521 2019-01-09  Tom Tromey  <tom@tromey.com>
9522
9523         * common/next-iterator.h: New file.
9524         * objfiles.h (class all_objfiles): New.
9525         (struct objfile_iterator): New.
9526
9527 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9528
9529         * NEWS: Move the description of the changed "frame", "select-frame",
9530          and "info frame" commands to the Changed commands section.
9531
9532 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
9533
9534         * gdbtypes.c (check_stub_method_group): Remove handling of old
9535         mangling schemes.
9536         * linespec.c (find_methods): Likewise.
9537         * stabsread.c (read_member_functions): Likewise.
9538         * valops.c (search_struct_method): Likewise.
9539         (value_struct_elt_for_reference): Likewise.
9540         * NEWS: Mention this change.
9541
9542 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
9543
9544         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
9545         print_source_lines.
9546         * source.c (print_source_lines_base): Update line number check.
9547         (print_source_lines): New function.
9548         (source_lines_range::source_lines_range): New function.
9549         * source.h (class source_lines_range): New class.
9550         (print_source_lines): New declaration.
9551
9552 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9553
9554         * linespec.c (linespec_state_destructor): Free self->canonical_names.
9555
9556 2019-01-08  Tom Tromey  <tom@tromey.com>
9557             Simon Marchi  <simon.marchi@ericsson.com>
9558
9559         PR gdb/24060
9560         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
9561         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
9562         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9563         * f-exp.y (DOLLAR_VARIABLE): Likewise.
9564         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
9565         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
9566
9567 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9568
9569         * source.c (select_source_symtab): Move header comment to
9570         declaration in source.h.
9571         (forget_cached_source_info_for_objfile): Likewise.
9572         (forget_cached_source_info): Likewise.
9573         (identify_source_line): Likewise.
9574         * source.h (identify_source_line): Move declaration from symtab.h
9575         and add comment from source.c
9576         (print_source_lines): Likewise.
9577         (forget_cached_source_info_for_objfile): Likewise.
9578         (forget_cached_source_info): Likewise.
9579         (select_source_symtab): Likewise.
9580         (enum print_source_lines_flag): Move definition from symtab.h.
9581         * symtab.h (identify_source_line): Move declaration to source.h.
9582         (print_source_lines): Likewise.
9583         (forget_cached_source_info_for_objfile): Likewise.
9584         (forget_cached_source_info): Likewise.
9585         (select_source_symtab): Likewise.
9586         (enum print_source_lines_flag): Move definition to source.h.
9587         * tui/tui-hooks.c: Add 'source.h' include.
9588
9589 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9590
9591         * source.c (print_source_lines_base): Handle requests to print
9592         reverse line number sequences, and guard against empty lines
9593         string.
9594
9595 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
9596
9597         * source.c (print_source_lines_base): Fix skip of '\r' if next
9598         character is '\n'.
9599
9600 2019-01-06  Tom Tromey  <tom@tromey.com>
9601
9602         * c-exp.y (struct c_parse_state) <macro_original_text,
9603         expansion_obstack>: New member.
9604         (macro_original_text, expansion_obstack): Remove globals.
9605         (scan_macro_expansion, scanning_macro_expansion)
9606         (finished_macro_expansion): Update.
9607         (scan_macro_cleanup): Remove.
9608         (yylex, c_parse): Update.
9609
9610 2019-01-06  Tom Tromey  <tom@tromey.com>
9611
9612         * c-exp.y (struct c_parse_state) <strings>: New member.
9613         (operator_stoken): Update.
9614
9615 2019-01-06  Tom Tromey  <tom@tromey.com>
9616
9617         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
9618         (union type_stack_elt) <typelist_val>: Now a pointer to
9619         std::vector.
9620         (type_stack_cleanup): Don't declare.
9621         (push_typelist): Update.
9622         * parse.c (pop_typelist): Return a std::vector.
9623         (push_typelist): Take a std::vector.
9624         (follow_types): Update.  Do not free args.
9625         (type_stack_cleanup): Remove.
9626         * c-exp.y (struct c_parse_state): New.
9627         (cpstate): New global.
9628         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
9629         (nonempty_typelist): Update.
9630         (func_mod): Create a new vector.
9631         (c_parse): Create a c_parse_state.
9632         (check_parameter_typelist): Do not delete params.
9633         (function_method): Update.  Do not delete type_list.
9634
9635 2019-01-06  Tom Tromey  <tom@tromey.com>
9636
9637         PR gdb/28155:
9638         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
9639         check_typedef.
9640         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
9641         (print_return_value): Likewise.
9642
9643 2019-01-05  Tom Tromey  <tom@tromey.com>
9644
9645         * contrib/cleanup_check.py: Remove.
9646         * contrib/gcc-with-excheck: Remove.
9647         * contrib/exsummary.py: Remove.
9648         * contrib/excheck.py: Remove.
9649
9650 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
9651
9652         * thread.c (delete_thread_1): Add gdb_assert that THR is not
9653         NULL. Initialize tpprev to NULL instead of assigning it
9654         to NULL on the next statement.
9655         * windows-nat.c (windows_delete_thread): Remove check for
9656         main_thread_id before printing thread exit notifications.
9657         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
9658         Remove thread ID check against main_thread_id.
9659         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
9660         windows_delete_thread.
9661         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
9662
9663 2019-01-04  Tom Tromey  <tom@tromey.com>
9664
9665         * compile/compile.c (_initialize_compile): Use upper case for
9666         metasyntactic variables.
9667         * symmisc.c (_initialize_symmisc): Use upper case for
9668         metasyntactic variables.
9669         * psymtab.c (_initialize_psymtab): Use upper case for
9670         metasyntactic variables.
9671         * demangle.c (demangle_command): Use upper case for metasyntactic
9672         variables.
9673         (_initialize_demangler): Likewise.
9674         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
9675         variables.
9676
9677 2019-01-03  Tom Tromey  <tom@tromey.com>
9678
9679         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
9680
9681 2019-01-03  Tom Tromey  <tom@tromey.com>
9682
9683         * python/py-symtab.c (salpy_str): Update.
9684         (struct salpy_sal_object) <symtab>: Now a PyObject.
9685         (salpy_dealloc): Update.
9686         (del_objfile_sal): Use gdbpy_ref.
9687
9688 2019-01-03  Tom Tromey  <tom@tromey.com>
9689
9690         * python/py-type.c (convert_field): Use new_reference.  Return
9691         gdbpy_ref.
9692         (make_fielditem): Return gdbpy_ref.
9693         (typy_fields): Update.
9694         (typy_getitem): Update.
9695         (field_name): Return gdbpy_ref.  Use new_reference.
9696         (typy_iterator_iternext): Update.
9697
9698 2019-01-03  Tom Tromey  <tom@tromey.com>
9699
9700         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
9701
9702 2019-01-03  Tom Tromey  <tom@tromey.com>
9703
9704         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
9705         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
9706         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
9707         (pspy_set_frame_filters, pspy_set_frame_unwinders)
9708         (pspy_set_type_printers): Likewise.
9709         * python/py-function.c (fnpy_init): Use gdbpy_ref.
9710         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
9711         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
9712         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
9713         (objfpy_set_type_printers): Likewise.
9714
9715 2019-01-03  Tom Tromey  <tom@tromey.com>
9716
9717         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
9718         (gdbpy_print_stack): Use gdbpy_err_fetch.
9719         * python/python-internal.h (class gdbpy_err_fetch): New class.
9720         (class gdbpy_enter) <m_error_type, m_error_value,
9721         m_error_traceback>: Remove.
9722         <m_error>: New member.
9723         (gdbpy_exception_to_string): Don't declare.
9724         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
9725         * python/py-value.c (convert_value_from_python): Use
9726         gdbpy_err_fetch.
9727         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
9728         gdbpy_exception_to_string.
9729         (gdbpy_handle_exception): Use gdbpy_err_fetch.
9730         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
9731         gdbpy_err_fetch.
9732
9733 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9734
9735         * linux-nat.c (delete_lwp_cleanup): Delete.
9736         (struct lwp_deleter): New struct.
9737         (lwp_info_up): New typedef.
9738         (linux_nat_target::follow_fork): Delete cleanup, and make use of
9739         lwp_info_up.
9740
9741 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9742
9743         * linux-fork.c (class scoped_switch_fork_info): New class.
9744         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
9745
9746 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9747
9748         * valops.c (find_overload_match): Remove use of null_cleanup, and
9749         calls to do_cleanups.
9750
9751 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9752
9753         * compile/compile-cplus-types.c
9754         (compile_cplus_instance::decl_name): Handle changes to
9755         cp_func_name.
9756         * cp-support.c (cp_func_name): Update header comment, update
9757         return type.
9758         * cp-support.h (cp_func_name): Update return type in declaration.
9759         * valops.c (find_overload_match): Move temp_func local to top
9760         level of function and change its type.  Use temp_func to hold and
9761         delete temporary string obtained from cp_func_name.
9762
9763 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
9764
9765         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
9766         gdb::char_vector, remove cleanup, and update uses of `msg`.
9767
9768 2019-01-03  Jim Wilson  <jimw@sifive.com>
9769
9770         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
9771
9772 2019-01-02  Tom Tromey  <tom@tromey.com>
9773
9774         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
9775         (tdesc_parse_xml): Remove cleanups.
9776         * target-descriptions.h (make_cleanup_free_target_description):
9777         Don't declare.
9778         (target_desc_deleter): New struct.
9779         (target_desc_up): New typedef.
9780         * target-descriptions.c (target_desc_deleter::operator()): Rename
9781         from free_target_description.
9782         (make_cleanup_free_target_description): Remove.
9783
9784 2019-01-02  Tom Tromey  <tom@tromey.com>
9785
9786         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
9787         constructor, destructor.
9788         (linespec_parser): Remove typedef.
9789         (~linespec_parser): Rename from linespec_parser_delete.
9790         (linespec_lex_to_end, linespec_complete_label)
9791         (linespec_complete): Update.
9792         (decode_line_full): Remove cleanups.
9793         (decode_line_1): Update.
9794
9795 2019-01-02  Tom Tromey  <tom@tromey.com>
9796
9797         * python/python-internal.h (inferior_to_inferior_object): Change
9798         return type.
9799         * python/py-exitedevent.c (create_exited_event_object): Update.
9800         * python/py-inferior.c (inferior_to_inferior_object): Return
9801         gdbpy_ref.
9802         (python_new_inferior, python_inferior_deleted)
9803         (thread_to_thread_object, delete_thread_object)
9804         (build_inferior_list, gdbpy_selected_inferior): Update.
9805         * python/py-infthread.c (create_thread_object): Update.  Also fail
9806         if inferior_to_inferior_object fails.
9807
9808 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9809
9810         * inferior.h (class inferior) <displaced_step_state>: New field.
9811         * infrun.h (struct displaced_step_state): Move here from
9812         infrun.c.  Initialize fields, add constructor.
9813         <inf>: Remove field.
9814         <reset>: New method.
9815         * infrun.c (struct displaced_step_inferior_state): Move to
9816         infrun.h.
9817         (displaced_step_inferior_states): Remove.
9818         (get_displaced_stepping_state): Adust.
9819         (displaced_step_in_progress_any_inferior): Adjust.
9820         (displaced_step_in_progress_thread): Adjust.
9821         (displaced_step_in_progress): Adjust.
9822         (add_displaced_stepping_state): Remove.
9823         (get_displaced_step_closure_by_addr): Adjust.
9824         (remove_displaced_stepping_state): Remove.
9825         (infrun_inferior_exit): Call displaced_step_state.reset.
9826         (use_displaced_stepping): Don't check for NULL.
9827         (displaced_step_prepare_throw): Call
9828         get_displaced_stepping_state.
9829         (displaced_step_fixup): Don't check for NULL.
9830         (prepare_for_detach): Don't check for NULL.
9831
9832 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9833
9834         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9835          in case of call that did not complete.
9836
9837 2019-01-02  Andrey Utkin  <autkin@undo.io>
9838
9839         * symfile.c (find_separate_debug_file): Fix search of debug files for
9840         remote debuggee.
9841
9842 2019-01-02  Tom Tromey  <tom@tromey.com>
9843
9844         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9845         indentation.
9846         * python/py-frame.c (frapy_older): Remove cast.
9847         (frapy_newer): Likewise.
9848         * python/py-breakpoint.c (local_setattro): Remove cast.
9849         * python/py-arch.c (archpy_name): Remove local variable.
9850         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9851
9852 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9853
9854         * unittests/basic_string_view/element_access/char/empty.cc:
9855         Fix year range in copyright header.
9856
9857 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9858
9859         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9860         Delete.
9861         <operator==>: Update with for removed field.
9862         <hash>: Likewise.
9863         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9864         <isa_features>: ...this.
9865         <abi_features>: New field.
9866         (riscv_isa_flen): Update comment.
9867         (riscv_abi_xlen): New declaration.
9868         (riscv_abi_flen): New declaration.
9869         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9870         isa_features.
9871         (riscv_abi_xlen): New function.
9872         (riscv_isa_flen): Update to get answer from isa_features.
9873         (riscv_abi_flen): New function.
9874         (riscv_has_fp_abi): Update to get answer from abi_features.
9875         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9876         xlen and flen.
9877         (riscv_call_info) <xlen, flen>: Update comment.
9878         (riscv_call_arg_struct): Remove invalid assertions
9879         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9880         is removed.
9881         (riscv_gdbarch_init): Gather isa features and abi features
9882         separately, ensure both match on the gdbarch when reusing an old
9883         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9884         a target with 64-bit float hardware.
9885
9886 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9887
9888         * source.c (search_command_helper): Stop reverse search
9889         when line 1 has been searched.
9890
9891 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9892
9893         * record-full.c (record_full_base_target::close): Rewrite
9894         record_full_core_buf_list free logic.
9895
9896 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9897
9898         * break-catch-syscall.c (print_one_catch_syscall): xfree
9899         the last text.
9900
9901 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9902
9903         * top.c (print_gdb_version): Update Copyright year in version
9904         message.
9905
9906 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9907
9908         Update copyright year range in all GDB files.
9909
9910 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9911
9912         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9913
9914 For older changes see ChangeLog-2018.
9915 \f
9916 Local Variables:
9917 mode: change-log
9918 left-margin: 8
9919 fill-column: 74
9920 version-control: never
9921 coding: utf-8
9922 End:
9923